d007aea8e8bfc343da7f849720ff2224a0d76fd8
[WebKit.git] / Tools / ChangeLog
1 2011-02-04  Martin Robinson  <mrobinson@igalia.com>
2
3         Reviewed by Adam Barth.
4
5         [GTK] plugins/plugin-document-back-forward.html fails
6         https://bugs.webkit.org/show_bug.cgi?id=53833
7
8         Add the new "alert on load" functionality for the Unix version of the
9         test plugin. This functionality was originally introduced in r77706.
10
11         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
12         (webkit_test_plugin_new_instance): Add new plugin fuctionality.
13
14 2011-02-04  Kundu Suchismita  <suchi.kundu@nokia.com>
15
16         Reviewed by Andreas Kling.
17
18         Local Storage settings can be enable/disable from "Develop" menu
19         https://bugs.webkit.org/show_bug.cgi?id=52296
20
21         * QtTestBrowser/launcherwindow.cpp:
22         (LauncherWindow::createChrome):
23         (LauncherWindow::toggleLocalStorage):
24         (LauncherWindow::toggleOfflineStorageDatabase):
25         (LauncherWindow::toggleOfflineWebApplicationCache):
26         (LauncherWindow::setOfflineStorageDefaultQuota):
27         * QtTestBrowser/launcherwindow.h:
28         (WindowOptions::WindowOptions):
29         * QtTestBrowser/main.cpp:
30         (LauncherApplication::handleUserOptions):
31
32 2011-02-04  Tony Chang  <tony@chromium.org>
33
34         Reviewed by Eric Seidel.
35
36         get test-webkitpy running on win32 python
37         https://bugs.webkit.org/show_bug.cgi?id=53822
38
39         The test harness crashes with a WindowsError because it can't find
40         'svn' when using subprocess.Popen.  This gets us past the error
41         so we can see the failing tests on the Chromium Win Release Tests
42         bot.
43
44         * Scripts/webkitpy/common/system/executive.py:
45
46 2011-02-04  Martin Robinson  <mrobinson@igalia.com>
47
48         Reviewed by Gustavo Noronha Silva.
49
50         [GTK] fast/events/pagehide-timeout.html fails
51         https://bugs.webkit.org/show_bug.cgi?id=53771
52
53         Add knowledge of the document browser cache model the DRT. When resetting
54         WebKit settings to consistent values between tests, default to the document
55         browser cache model.
56
57         * DumpRenderTree/gtk/DumpRenderTree.cpp:
58         (resetDefaultsToConsistentValues): Reset the cache model to the document browser
59         cache model between tests.
60         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
61         (LayoutTestController::setCacheModel): An int value of 2 here corresponds to the
62         document browser cache model.
63
64 2011-02-04  Adam Barth  <abarth@webkit.org>
65
66         Reviewed by Eric Seidel.
67
68         PluginDocuments don't create widgets for plugins on back/forward
69         https://bugs.webkit.org/show_bug.cgi?id=53474
70
71         Teach the test plugin how to call alert on load.
72
73         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
74         (NPP_New):
75
76 2011-02-04  Adam Roben  <aroben@apple.com>
77
78         Add a test case for encode/decode of FormData/FormDataElement
79
80         If the fix made in r77401 is broken, this new test will crash.
81
82         Fixes <http://webkit.org/b/53616> <rdar://problem/8949883>.
83
84         Reviewed by Sam Weinig.
85
86         * TestWebKitAPI/Test.h: Moved the bulk of TEST_ASSERT into a new _TEST_ASSERT_HELPER macro.
87         Added a new TEST_ASSERT_RETURN macro that can be used in functions with a return value.
88
89         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp: Added.
90         (TestWebKitAPI::didFinishLoadForFrame): Record that the load is finished.
91         (TestWebKitAPI::setPageLoaderClient): Hook up the loader client.
92         (TestWebKitAPI::createSessionStateContainingFormData): Load simple-form.html, submit the
93         form, an return the session state data.
94         (TestWebKitAPI::TEST): Create some session state that contains form data from one WKPage,
95         and restore it into another WKPage.
96
97         * TestWebKitAPI/Tests/WebKit2/simple-form.html: Added.
98
99         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
100         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
101         * TestWebKitAPI/win/copy-resources.cmd:
102         Added new files.
103
104 2011-02-04  Adam Roben  <aroben@apple.com>
105
106         Move code to run JavaScript tests into its own files
107
108         This will allow other tests to use this mechanism.
109
110         Fixes <http://webkit.org/b/53806> SpacebarScrolling should share its JavaScript-fu with the
111         world
112
113         Reviewed by Sam Weinig.
114
115         * TestWebKitAPI/JavaScriptTest.cpp: Added.
116         * TestWebKitAPI/JavaScriptTest.h: Added.
117         Moved code here...
118
119         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp: ...from here.
120
121         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
122         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
123         Added the new files.
124
125 2011-02-04  Dirk Pranke  <dpranke@chromium.org>
126
127         Reviewed by Mihai Parparita.
128
129         merge test expectations for chromium, chromium-gpu. The
130         chromium-gpu port will no longer maintain its own
131         test expectations file.
132
133         Also add in a graphics_type() call on the port object to
134         determine what graphics type to use in the test configuration,
135         and log the configuration as a config setting.
136
137         https://bugs.webkit.org/show_bug.cgi?id=53562
138
139         * Scripts/webkitpy/layout_tests/port/base.py:
140         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
141         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
142         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
143
144 2011-02-04  Mikhail Naganov  <mnaganov@chromium.org>
145
146         Reviewed by Pavel Feldman.
147
148         Web Inspector: fix processing Unicode literals from .js sources in check-inspector-strings.
149         https://bugs.webkit.org/show_bug.cgi?id=53781
150
151         * Scripts/check-inspector-strings:
152
153 2011-02-04  Adam Roben  <aroben@apple.com>
154
155         Include the crashing function in the link to a crash log on Mac
156
157         Fixes <http://webkit.org/b/53780> Crash log links in results.html should include the
158         function that crashed on Mac
159
160         Reviewed by David Kilzer.
161
162         * Scripts/old-run-webkit-tests:
163         (crashLocation): Moved all the Windows code inside an if instead of using an early return,
164         but didn't otherwise change it. Added an if for Mac that parses the crashing function out of
165         the crash log.
166
167 2011-02-04  Adam Roben  <aroben@apple.com>
168
169         Link to Mac crash logs from results.html
170
171         Fixes <http://webkit.org/b/14861> run-webkit-tests should link to Mac crash logs in
172         results.html
173
174         Reviewed by David Kilzer.
175
176         * Scripts/old-run-webkit-tests:
177         (captureSavedCrashLog): Added a case for Apple's Mac port. We get the crash log out of
178         ~/Library/Logs/CrashReporter, and wait for ReportCrash to exit before trying to get the log.
179
180 2011-02-03  Maciej Stachowiak  <mjs@apple.com>
181
182         Reviewed by Dan Bernstein.
183
184         WebKit2: Need WebKit2 equivalent of WebResourceLoadDelegate::willSendRequest in the Bundle
185         https://bugs.webkit.org/show_bug.cgi?id=52897
186         <rdar://problem/8898294>
187
188         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
189         (WTR::InjectedBundlePage::InjectedBundlePage):
190         (WTR::InjectedBundlePage::willSendRequestForFrame):
191         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
192
193 2011-02-03  Ivan Krstić  <ike@apple.com>
194
195         Unreviewed.
196
197         Adding myself to committers.py.
198
199         * Scripts/webkitpy/common/config/committers.py:
200
201 2011-02-03  James Kozianski  <koz@chromium.org>
202
203         Reviewed by Dimitri Glazkov.
204
205         Add navigator.registerProtocolHandler behind a flag.
206         https://bugs.webkit.org/show_bug.cgi?id=52609
207
208         * Scripts/build-webkit:
209
210 2011-02-03  Hayato Ito  <hayato@chromium.org>
211
212         Reviewed by Eric Seidel.
213
214         [NRWT] Remove TestArgs class, which is wrongly used.
215
216         https://bugs.webkit.org/show_bug.cgi?id=53063
217
218         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
219         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
220         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
221         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
222         * Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py:
223         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
224
225 2011-02-03  Andrew Wason  <rectalogic@rectalogic.com>
226
227         Reviewed by Kenneth Russell.
228
229         Change ENABLE_3D_CANVAS to ENABLE_WEBGL
230         https://bugs.webkit.org/show_bug.cgi?id=53714
231
232         * Scripts/build-webkit: change --3d-canvas build option
233           to set ENABLE_WEBGL
234
235 2011-02-03  Hayato Ito  <hayato@chromium.org>
236
237         Reviewed by Tony Chang.
238
239         [NRWT] Introduces Input/Output class used by base.Driver into port/base.py and
240         move _run_single_test() and _process_output() functions from
241         dump_render_tree_thread.py to a single_test_runner.py as an individual module.
242
243         This is clean up and acts as a preparation for elimination of test_types/*
244         classes. These classes will move to the single_test_runner module introduced
245         in this patch.
246
247         https://bugs.webkit.org/show_bug.cgi?id=53004
248
249         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
250         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py: Added.
251         * Scripts/webkitpy/layout_tests/layout_package/test_input.py:
252         * Scripts/webkitpy/layout_tests/layout_package/test_output.py: Removed.
253         * Scripts/webkitpy/layout_tests/port/base.py:
254         * Scripts/webkitpy/layout_tests/port/chromium.py:
255         * Scripts/webkitpy/layout_tests/port/dryrun.py:
256         * Scripts/webkitpy/layout_tests/port/test.py:
257         * Scripts/webkitpy/layout_tests/port/webkit.py:
258         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
259         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
260         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
261
262 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
263
264         Unreviewed, build fix.
265
266         Delete a line that was accidentally missed in r77586; without it
267         there is still a race between the two threads.
268
269         https://bugs.webkit.org/show_bug.cgi?id=51572
270
271         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
272
273 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
274
275         Reviewed by Tony Chang.
276
277         nrwt: handle "broken pipe" notifications from DRT more cleanly.
278
279         https://bugs.webkit.org/show_bug.cgi?id=52927
280
281         * Scripts/webkitpy/layout_tests/port/server_process.py:
282         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
283
284 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
285
286         Reviewed by Kenneth Russell.
287
288         Update, resubmit change to bug 51572. I think the race that was
289         fixed in r76703 caused the hang that caused us to roll this
290         patch out before, so I'd like to try again.
291
292         https://bugs.webkit.org/show_bug.cgi?id=51572
293
294         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
295         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
296
297 2011-02-03  Daniel Cheng  <dcheng@chromium.org>
298
299         Unreviewed.
300
301         Adding myself to committers.py.
302
303         * Scripts/webkitpy/common/config/committers.py:
304
305 2011-02-03  Adam Roben  <aroben@apple.com>
306
307         Include the crashing function in the link to a crash log
308
309         Fixes <http://webkit.org/b/53739> Crash log links in results.html should include the
310         function that crashed
311
312         Reviewed by David Kilzer.
313
314         * Scripts/old-run-webkit-tests:
315         (crashLocation): Added. Returns the location of the crash.
316         (linksForErrorTest): Include the crash location in the link text for the crash log, if one
317         could be determined.
318
319 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
320
321         Unreviewed, build fix.
322
323         Actually make the changes suggested by Mihai in his review
324         of bug 53720 :(
325
326         https://bugs.webkit.org/show_bug.cgi?id=53720
327
328         * Scripts/webkitpy/layout_tests/port/test_files.py:
329         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
330
331 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
332
333         Reviewed by Mihai Parparita.
334
335         new-run-webkit-tests: Fix bug introduced in r77434 that was
336         causing us to run the canvas GPU tests on the Mac GPU port. This
337         bug revealed that we were not setting the port.name() field
338         properly in many cases, so I've cleaned up all of that code, and
339         removed a few comments about "version-specific" GPU ports that
340         don't exist and just confused things.
341
342         Testing also revealed that port.abspath_for_test() wasn't
343         normalizing paths on Windows properly, so I fixed that as well.
344
345         https://bugs.webkit.org/show_bug.cgi?id=53719
346
347         * Scripts/webkitpy/layout_tests/port/base.py:
348         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
349         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
350
351 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
352
353         Reviewed by Mihai Parparita.
354
355         new-run-webkit-tests: fix normalization of paths on windows when gathering files
356
357         r77434 introduced a bug that was causing the test expectations
358         for the GPU ports to not be treated properly. It turns out that
359         when we gathered the list of test files on Windows, we would
360         return paths of the form "c:\LayoutTests/fast/canvas", and the
361         mixture of backslashes and forward slashes was confusing things.
362
363         This patch normalizes all of the filenames returned from
364         test_files.find(), and adds better tests for this (fixing a
365         couple of other bugs found in the meantime).
366
367         https://bugs.webkit.org/show_bug.cgi?id=53720
368
369         * Scripts/webkitpy/layout_tests/port/test.py:
370         * Scripts/webkitpy/layout_tests/port/test_files.py:
371         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
372
373 2011-02-03  Adam Roben  <aroben@apple.com>
374
375         Add links to Windows crash logs in results.html
376
377         Fixes <http://webkit.org/b/53718> run-webkit-tests should link to Windows crash logs in
378         results.html
379
380         Reviewed by David Kilzer.
381
382         * Scripts/old-run-webkit-tests:
383         (top level): Added $crashLogTag and $windowsCrashLogFilePrefix (which came from
384         createDebuggerCommandFile).
385         (testCrashedOrTimedOut): If the test crashed, capture any saved crash log after the dump
386         tool has exited.
387         (captureSavedCrashLog): Added. Finds the crash log for the test that just crashed and moves
388         it into the test results directory tree. Only implemented for Cygwin currently.
389         (findNewestFileMatchingGlob): Added. Does what it says.
390         (htmlForResultsSection): Only link to files that exist.
391         (linksForErrorTest): Add a link to the crash log.
392         (deleteExpectedAndActualResults): Delete any old crash log for this test.
393         (createDebuggerCommandFile): Use the new $windowsCrashLogFilePrefix constant instead of
394         hardcoding it here.
395
396 2011-02-03  Adam Roben  <aroben@apple.com>
397
398         Tell the debugger the path to the WebKit source tree when saving a crash log
399
400         This allows the debugger to include the crashing line of code in the log.
401
402         Fixes <http://webkit.org/b/53678> Crash logs from buildslaves don't show the crashing line
403         of code
404
405         Reviewed by Sam Weinig.
406
407         * Scripts/old-run-webkit-tests:
408         (createDebuggerCommandFile): Added. Saves commands that we'd like the debugger to run to a
409         file and returns the path to that file. The commands we pass came from
410         setUpWindowsCrashLogSaving, but I've added a .srcpath command to tell the debugger where the
411         WebKit source code lives.
412         (setUpWindowsCrashLogSaving): Instead of specifying the commands directly on the command
413         line using -c, save them to a file and specify the path to that file using -cf. This works
414         around what is presumably a bug in Windows's command line parsing, where having multiple
415         quoted paths in the debugger commands causes the post-mortem debugger not to be invoked at
416         all. Also pulled the options we pass to the debugger out into a list that is then join()ed
417         together to make them easier to modify in the future.
418
419 2011-02-02  Sam Weinig  <sam@webkit.org>
420
421         Reviewed by Anders Carlsson.
422
423         Add notification of the end of a rubber band.
424         <rdar://problem/8940648>
425
426         * MiniBrowser/mac/BrowserWindowController.m:
427         (-[BrowserWindowController awakeFromNib]):
428         * WebKitTestRunner/TestController.cpp:
429         (WTR::TestController::createOtherPage):
430         (WTR::TestController::initialize):
431         Stub out the new WKUIClient function.
432
433 2011-02-03  Gabor Rapcsanyi  <rgabor@webkit.org>
434
435         Unreviewed.
436
437         Adding myself to committers.py.
438
439         * Scripts/webkitpy/common/config/committers.py:
440
441 2011-02-03  Balazs Kelemen  <kbalazs@webkit.org>
442
443         Reviewed by Csaba Osztrogonác.
444
445         [Qt][WK2] MiniBrowser's window size should be 800x600
446         https://bugs.webkit.org/show_bug.cgi?id=53670
447
448         Make layout test failure debugging easier.
449         * MiniBrowser/qt/BrowserWindow.cpp:
450         (BrowserWindow::BrowserWindow):
451
452 2011-02-02  Andy Estes  <aestes@apple.com>
453
454         Reviewed by Mark Rowe.
455
456         'update-webkit' should handle OpenSource and Internal using different
457         VCSs.
458
459         * Scripts/update-webkit: Re-check the VCS type when updating Apple's
460         Internal directory.
461
462 2011-02-02  Dirk Pranke  <dpranke@chromium.org>
463
464         Reviewed by Mihai Parparita.
465
466         new-run-webkit-tests: hardcode the directories to scan for tests
467         for GPU bots instead of SKIPping them. See bug 53562 for some
468         context, but we will now hard-code the list of directories to
469         use by default instead of skipping over directories in the
470         expectations file. We do this so that we will be able to merge
471         the expectations files without getting conflicting SKIP
472         directives. Note that this change will reduce the # of tests
473         being run on the Mac GPU bots, because we're accidentally
474         including some today.
475
476         https://bugs.webkit.org/show_bug.cgi?id=53631
477
478         * Scripts/webkitpy/layout_tests/port/base.py:
479         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
480         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
481
482 2011-02-02  Sam Weinig  <sam@webkit.org>
483
484         Reviewed by Beth Dakin.
485
486         Add ChromeClient function to paint custom overhang areas.
487         https://bugs.webkit.org/show_bug.cgi?id=53639
488
489         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
490         (WTR::InjectedBundlePage::InjectedBundlePage):
491         Stub out new callback.
492
493 2011-02-02  Dirk Pranke  <dpranke@chromium.org>
494
495         Reviewed by Tony Chang.
496
497         new-run-webkit-tests: support chromium code paths in mock_drt
498
499         https://bugs.webkit.org/show_bug.cgi?id=53471
500
501         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
502         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
503
504 2011-02-02  Adam Klein  <adamk@chromium.org>
505
506         Reviewed by Tony Chang.
507
508         Update new-run-webkit-tests --chromium to put output under Source/...
509         https://bugs.webkit.org/show_bug.cgi?id=53612
510
511         * BuildSlaveSupport/test-result-archive:
512         * Scripts/webkitpy/layout_tests/port/chromium.py:
513
514 2011-01-28  Tony Chang  <tony@chromium.org>
515
516         Reviewed by Eric Seidel.
517
518         [chromium] remove --use-test-shell from NRWT
519         https://bugs.webkit.org/show_bug.cgi?id=53346
520
521         I've already started removing some of the bindings like eventSender so
522         this already doesn't work isn't useful.  Also updated some comments to
523         refer to DRT instead of test_shell.
524
525         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
526         * Scripts/webkitpy/layout_tests/port/chromium.py:
527         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
528         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
529         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
530         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
531         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
532         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
533
534 2011-02-02  Steve Lacey  <sjl@chromium.org>
535
536         Reviewed by Eric Carlson.
537
538         Implement basic media statistics on media elements.
539         https://bugs.webkit.org/show_bug.cgi?id=53322
540
541         * Scripts/build-webkit:
542
543 2011-02-02  Kevin Ollivier  <kevino@theolliviers.com>
544
545         [wx] Build fixes for wxWebKit.
546
547         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
548         (LayoutTestController::setSerializeHTTPLoads):
549         * wx/browser/wscript:
550         * wx/build/build_utils.py:
551         * wx/build/settings.py:
552
553 2011-02-01  Dirk Pranke  <dpranke@chromium.org>
554
555         Reviewed by Mihai Parparita.
556
557         new-run-webkit-tests: stop skipping so many tests
558
559         r77163 introduced a regression where we weren't resetting test
560         expectations properly and were skipping too many tests as a
561         result. This patch fixes that and adds a test for it.
562
563         https://bugs.webkit.org/show_bug.cgi?id=53551
564
565         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
566         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
567
568 2011-02-01  Dirk Pranke  <dpranke@chromium.org>
569
570         Reviewed by Tony Chang.
571
572         new-run-webkit-tests: add first stub of test_runner2. This
573         will add support for the 'inline', 'threads', and 'processes'
574         flags to --worker-model, but for now the implementatios just
575         fall back on the old ones.
576
577         https://bugs.webkit.org/show_bug.cgi?id=53157
578
579         * Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
580         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
581
582 2011-02-01  Mihai Parparita  <mihaip@chromium.org>
583
584         Reviewed by James Robinson.
585
586         [Chromium] run-chromium-webkit-unit-tests looks for binaries in the wrong place
587         https://bugs.webkit.org/show_bug.cgi?id=53522
588
589         * Scripts/run-chromium-webkit-unit-tests:
590
591 2011-02-01  Adam Barth  <abarth@webkit.org>
592
593         Reviewed by Mihai Parparita.
594
595         Using Control-C to cancel webkit-patch or other python tools causes
596         unpleasant traceback console spew
597         https://bugs.webkit.org/show_bug.cgi?id=53462
598
599         Catch the exception and don't print the stack trace.
600
601         * Scripts/webkit-patch:
602
603 2011-02-01  Scott Cameron  <sccameron@rim.com>
604
605         Reviewed by Daniel Bates.
606
607         Use Windows format for MinGW HTTPD path.
608         https://bugs.webkit.org/show_bug.cgi?id=53503
609
610         * Scripts/webkitperl/httpd.pm:
611           - Use single-quotes around MySys value for $httpdPath in getHTTPDPath()
612             so that we don't have to escape the space characters in the path. Also,
613             changed path to Windows-style path and removed FIXME comment.
614
615 2011-02-01  Balazs Kelemen  <kbalazs@webkit.org>
616
617         Reviewed by Andreas Kling.
618
619         [Qt][WK2] Add a way to use shared process model in MiniBrowser
620         https://bugs.webkit.org/show_bug.cgi?id=53090
621
622         * MiniBrowser/qt/BrowserView.cpp:
623         (BrowserView::BrowserView): Removed the m_context member.
624         From now the context is guaranteed to be non-null and we
625         don't need to store that in the object.
626         * MiniBrowser/qt/BrowserView.h:
627         * MiniBrowser/qt/BrowserWindow.cpp:
628         Added static bool to determine that new windows need to be
629         created with their own context or not. Use the same context
630         and web process by default to be inilne with the other ports.
631         (BrowserWindow::BrowserWindow):
632         (BrowserWindow::newWindow):
633         * MiniBrowser/qt/BrowserWindow.h:
634         * MiniBrowser/qt/main.cpp:
635         (main): Added command line switch to be able to use the
636         non-shared process model. Simplify the handling of the command line
637         switches a little bit.
638
639 2011-02-01  Zoltan Horvath  <zoltan@webkit.org>
640
641         Reviewed by Andreas Kling.
642
643         [Qt] Add Window menu and Toggle FullScreen action to MiniBrowser.
644         https://bugs.webkit.org/show_bug.cgi?id=53491
645
646         * MiniBrowser/qt/BrowserWindow.cpp:
647         (BrowserWindow::BrowserWindow):
648         (BrowserWindow::toggleFullScreenMode):
649         * MiniBrowser/qt/BrowserWindow.h:
650
651 2011-02-01  Zoltan Horvath  <zoltan@webkit.org>
652
653         Reviewed by Andreas Kling.
654
655         [Qt] Add Toggle Frame Flattening, Auto Load Images and Disable JavaScript actions to MiniBrowser.
656         https://bugs.webkit.org/show_bug.cgi?id=53489
657
658         Add Toggle Frame Flattening action to Develop menu. Add Auto Load Images and Disable JavaScript actions
659         to Settings menu.
660
661         * MiniBrowser/qt/BrowserWindow.cpp:
662         (BrowserWindow::BrowserWindow):
663         (BrowserWindow::toggleFrameFlattening):
664         (BrowserWindow::toggleDisableJavaScript):
665         (BrowserWindow::toggleAutoLoadImages):
666         * MiniBrowser/qt/BrowserWindow.h:
667
668 2011-01-31  Mihai Parparita  <mihaip@chromium.org>
669
670         Reviewed by Tony Chang.
671
672         [Chromium] Switch chromium-mac to use ChromiumDriver
673         https://bugs.webkit.org/show_bug.cgi?id=53461
674         
675         For the sake of consistency with the other Chromium platforms (and so
676         that chromium-mac picks up special flags like --enable-hardware-gpu),
677         switch chromium-mac from the WebKitDriver to ChromiumDriver.
678
679         * Scripts/webkitpy/layout_tests/port/chromium.py:
680
681 2011-01-31  Dirk Pranke  <dpranke@chromium.org>
682
683         Reviewed by Mihai Parparita.
684
685         The current modifier parsing code in test_expectations is
686         fragile and hard-coded, so it's not easy to understand the logic
687         or easily add new types of modifiers (like GPU vs. CPU testing
688         for graphics tests, or 32-bit vs. 64-bit differences).
689
690         This is the first of two patches that will add in more generic
691         support and then eliminate the GPU-specific test expectations
692         files for Chromium.
693
694         This patch adds two standalone objects for handling modifiers. The
695         rules for interpreting modifiers, precedence, and conflicts are
696         given in the docstring to the ModifierMatcher class, which
697         returns ModifierMatchResult objects.
698         
699         This patch also adds routines to the Port interface and a
700         default set of values in the base object, in order to obtain the
701         values needed on a given test run. These values are then passed
702         to the expectation parser. This also allows us to clean up the
703         logic used to lint all of the different configurations in a
704         single test_expectations.txt file.
705
706         The next patch will merge in the separate GPU expectations file.
707
708         https://bugs.webkit.org/show_bug.cgi?id=51222
709
710         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
711         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
712         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
713         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
714         * Scripts/webkitpy/layout_tests/port/base.py:
715         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
716         * Scripts/webkitpy/layout_tests/port/chromium.py:
717         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
718         * Scripts/webkitpy/layout_tests/port/test.py:
719         * Scripts/webkitpy/layout_tests/port/webkit.py:
720         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
721         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
722         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
723         * Tools/Scripts/webkitpy/style/checkers/test_expectations.py:
724         * Tools/Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
725
726 2011-01-31  Scott Cameron  <sccameron@rim.com>
727
728         Reviewed by Daniel Bates.
729
730         update run-webkit-httpd to be able to launch Apache2.2 in a MSYS environment
731         https://bugs.webkit.org/show_bug.cgi?id=50036
732
733         This will add an Apache2.2 configuration file and modifies scripts to allow
734         running an httpd server in an MSYS environment.
735
736         The default Apache2.2 installation path has been preserved and PHP5 modules disabled
737         in order to allow for simple installation/execution.  Simply install the latest
738         Apache2.2 version with OpenSSL from http://httpd.apache.org/download.cgi#apache22 to
739         be able to execute run-webkit-httpd.
740         
741
742         * Scripts/run-webkit-httpd:
743         * Scripts/webkitperl/httpd.pm:
744
745 2011-01-31  Tony Chang  <tony@chromium.org>
746
747         Reviewed by Eric Seidel.
748
749         mac DRT should report RTL scroll offset relative to top right corner
750         https://bugs.webkit.org/show_bug.cgi?id=53324
751
752         * DumpRenderTree/mac/DumpRenderTree.mm:
753         (dumpFrameScrollPosition):
754
755 2011-01-31  Zoltan Horvath  <zoltan@webkit.org>
756
757         Reviewed by Andreas Kling.
758
759         [Qt] Add Take Screen Shot action to MiniBrowser
760         https://bugs.webkit.org/show_bug.cgi?id=53422
761
762         Add Take Screen Shot action to MiniBrowser's view menu.
763
764         * MiniBrowser/qt/BrowserWindow.cpp:
765         (BrowserWindow::BrowserWindow):
766         (BrowserWindow::screenshot):
767         * MiniBrowser/qt/BrowserWindow.h:
768
769 2011-01-31  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
770
771         Reviewed by Xan Lopez.
772
773         [GTK] REGRESSION:  http/tests/media/video-{cookie,referer}.html failing
774         https://bugs.webkit.org/show_bug.cgi?id=53379
775
776         Remove left over #ifdef's. I thought all of the conditional code
777         had been freed from the condition, but I forgot to check DRT.
778
779         * DumpRenderTree/gtk/DumpRenderTree.cpp:
780         (resetDefaultsToConsistentValues):
781         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
782         (LayoutTestController::setAlwaysAcceptCookies):
783
784 2011-01-30  Dirk Pranke  <dpranke@chromium.org>
785
786         Unreviewed, build fix.
787
788         Fix regression introduced in r77093 - path.rsplit() doesn't
789         take keyword arguments.
790
791         https://bugs.webkit.org/show_bug.cgi?id=53326
792
793         * Scripts/webkitpy/common/system/filesystem_mock.py:
794
795 2011-01-30  Dirk Pranke  <dpranke@chromium.org>
796
797         Reviewed by Mihai Parparita.
798
799         Add more unit tests for rebaseline-chromium-webkit-tests. This
800         change involves restructuring a bunch of r-c-w-t code to make it
801         more testable as well. We also add wrapper classes for handling
802         testing zip files and fetching URLs.
803
804         https://bugs.webkit.org/show_bug.cgi?id=53040
805
806         * Scripts/webkitpy/common/system/urlfetcher.py:
807         * Scripts/webkitpy/common/system/urlfetcher_mock.py:
808         * Scripts/webkitpy/common/system/zipfileset_mock.py:
809         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
810         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
811         * Scripts/webkitpy/tool/mocktool.py:
812
813 2011-01-30  Dirk Pranke  <dpranke@chromium.org>
814
815         Reviewed by Eric Seidel.
816
817         Clean up of the filesystem-related modules used in webkitpy.
818         I've added relpath() to the filesystem interface, modified
819         ospath.relpath() so that it could work with the filesystem
820         interface, and modified the fileset* routines to use the
821         filesystem interface consistently.
822
823         This patch also adds a close() routine to the fileset routines
824         to indicate that the caller is done with the fileset. This
825         allows zipfileset to clean up after itself when it creates
826         tempfiles to store downloads.
827
828         https://bugs.webkit.org/show_bug.cgi?id=53326
829
830         * Scripts/webkitpy/common/system/directoryfileset.py:
831         * Scripts/webkitpy/common/system/fileset.py:
832         * Scripts/webkitpy/common/system/filesystem.py:
833         * Scripts/webkitpy/common/system/filesystem_mock.py:
834         * Scripts/webkitpy/common/system/filesystem_unittest.py:
835         * Scripts/webkitpy/common/system/ospath.py:
836         * Scripts/webkitpy/common/system/zipfileset.py:
837         * Scripts/webkitpy/common/system/zipfileset_unittest.py:
838
839 2011-01-30  Balazs Kelemen  <kbalazs@webkit.org>
840
841         Reviewed by Csaba Osztrogonác.
842
843         [Qt][WK2]REGRESSION (r76991): Fix build errors
844         https://bugs.webkit.org/show_bug.cgi?id=53400
845
846         Revert the temporary build fix (http://trac.webkit.org/changeset/77088)
847         and remove WebKit2Prefix.h from the build.
848         * MiniBrowser/qt/MiniBrowser.pro:
849
850 2011-01-30  Csaba Osztrogonác  <ossy@webkit.org>
851
852         Unreviewed.
853
854         [Qt][WK2] Buildfix.
855
856         * MiniBrowser/qt/MiniBrowser.pro:
857
858 2011-01-28  Simon Fraser  <simon.fraser@apple.com>
859
860         Reviewed by Adam Roben.
861         
862         define NOMINMAX when building ImageDiff, as we do elsewhere.
863
864         Add various clampToInt() methods to MathExtras.h
865         https://bugs.webkit.org/show_bug.cgi?id=52910
866
867         * DumpRenderTree/win/ImageDiffCommon.vsprops:
868
869 2011-01-28  Maciej Stachowiak  <mjs@apple.com>
870
871         Reviewed by Darin Adler.
872
873         WebKitTestRunner needs layoutTestController.setPOSIXLocale
874         https://bugs.webkit.org/show_bug.cgi?id=42682
875
876         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
877         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
878         (WTR::InjectedBundle::resetLocalSettings):
879         (WTR::InjectedBundle::didReceiveMessage):
880         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
881         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
882         (WTR::LayoutTestController::setPOSIXLocale):
883         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
884
885 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
886  
887          Reviewed by Mihai Parparita.
888  
889          test-webkitpy: fix webkitpy.layout_tests.port.mac_unittest.MacTest.test_skipped_file_paths
890  
891          This patch re-enables this test and changes it to
892          handle all of the mac platform versions, not just the one
893          it is running on.
894  
895          https://bugs.webkit.org/show_bug.cgi?id=53356
896  
897          * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
898  
899 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
900
901         Unreviewed, build fix.
902
903         Take two. The fix in 77023 didn't work, because we were
904         still calling path.abspath_to_uri, which calls _cygpath under
905         the covers, and it appears the cygpath on the bots does
906         something different than it does on my machine. This patch
907         removes the calls to path.abspath_to_uri, so it should be safe.
908         If it doesn't work, I'll roll it out along with r76982 and 77023.
909
910         https://bugs.webkit.org/show_bug.cgi?id=53126
911
912         * Scripts/webkitpy/layout_tests/port/test.py:
913
914 2011-01-28  David Kilzer  <ddkilzer@apple.com>
915
916         <rdar://problem/8930699> build-webkit gives a bogus warning with newer versions of Xcode 
917         <http://webkit.org/b/53353>
918
919         Reviewed by Mark Rowe.
920
921         * Scripts/webkitdirs.pm:
922         (checkRequiredSystemConfig): Check the Xcode marketing version
923         in addition to the DevCoreTools build version before complaining
924         about an old version of Xcode.  Also make the Mac OS X version
925         check use Perl's built-in version string comparitor.
926
927 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
928
929         Unreviewed, build fix.
930
931         Work around breakage on Win 7 Release bot caused by r76982
932         and the fact that windows ports use "file:////" instead of
933         "file:///". Ideally the test code should be isolated from
934         this, but it isn't yet. Will fix properly in a bit.
935
936         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
937
938 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
939
940         Reviewed by Tony Chang.
941
942         new-run-webkit-tests: change worker model values to
943         "old-inline", "old-threads" in preparation for test_runner2 /
944         multiprocessing changes.
945
946         https://bugs.webkit.org/show_bug.cgi?id=53156
947
948         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
949         * Scripts/webkitpy/layout_tests/port/base.py:
950         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
951         * Scripts/webkitpy/layout_tests/port/mac.py:
952         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
953
954 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
955
956         Reviewed by Tony Chang.
957
958         committers.py - add an IRC nickname for dpranke
959         https://bugs.webkit.org/show_bug.cgi?id=53335
960
961         * Scripts/webkitpy/common/config/committers.py:
962
963 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
964
965         Reviewed by Tony Chang.
966
967         new-run-webkit-tests: add a "mock DRT" port implementation
968         and a separate class that emulates what we expect the
969         DumpRenderTree behavior to be.
970
971         This will eventually replace port/dryrun.py and allow us to get
972         better test coverage of the new-run-webkit-tests code as well as
973         a reference for what new-run-webkit-tests expects from DRT.
974
975         This is the first attempt at this, and it is pretty bare-boned. It
976         really only has been tested on the 'mac' port (and a little on
977         the 'chromium-mac' port.
978
979         https://bugs.webkit.org/show_bug.cgi?id=53126
980
981         * Scripts/webkitpy/common/system/filesystem_mock.py:
982         * Scripts/webkitpy/layout_tests/port/dryrun.py:
983         * Scripts/webkitpy/layout_tests/port/factory.py:
984         * Scripts/webkitpy/layout_tests/port/mock_drt.py: Added.
985         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Added.
986         * Scripts/webkitpy/layout_tests/port/test.py:
987
988 2011-01-28  Pratik Solanki  <psolanki@apple.com>
989
990         Unreviewed. Removing .swp file checked in by mistake.
991
992         * Scripts/.webkitdirs.pm.swp: Removed.
993
994 2011-01-28  Pratik Solanki  <psolanki@apple.com>
995
996         Reviewed by David Kilzer.
997
998         Space not necessary for undefined feature
999         https://bugs.webkit.org/show_bug.cgi?id=53317
1000
1001         * Scripts/build-webkit:
1002
1003 2011-01-28  Chang Shu  <chang.shu@nokia.com>
1004
1005         Reviewed by Andreas Kling.
1006
1007         Reset NetworkAccessManager to clean up credentials from previous tests.
1008         This change causes no performance overhead either.
1009         https://bugs.webkit.org/show_bug.cgi?id=36688
1010
1011         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1012         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1013         (WebCore::DumpRenderTree::open):
1014         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1015
1016 2011-01-28  Zoltan Horvath  <zoltan@webkit.org>
1017
1018         Reviewed by Andreas Kling.
1019
1020         [Qt] Add Zoom Text Only action to MiniBrowser
1021         https://bugs.webkit.org/show_bug.cgi?id=53297
1022
1023         Add Zoom Text Only action to MiniBrowser's view menu, change zoom levels to avoid unnecessary divides.
1024
1025         * MiniBrowser/qt/BrowserWindow.cpp:
1026         (BrowserWindow::BrowserWindow):
1027         (BrowserWindow::zoomIn):
1028         (BrowserWindow::zoomOut):
1029         (BrowserWindow::resetZoom):
1030         (BrowserWindow::toggleZoomTextOnly):
1031         (BrowserWindow::applyZoom):
1032         * MiniBrowser/qt/BrowserWindow.h:
1033
1034 2011-01-28  Adam Barth  <abarth@webkit.org>
1035
1036         Reviewed by Eric Seidel.
1037
1038         Add webkit-patch roll-chromium-deps
1039         https://bugs.webkit.org/show_bug.cgi?id=53288
1040
1041         This command updates the Source/WebKit/chromium/DEPS file with the
1042         last-known good revision of Chromium (or a revision specified on the
1043         command line).  I'd eventually like to turn this into a SheriffBot
1044         command, but this is the first step.
1045
1046         This patch somewhat sprawled because I needed to move a bunch of code
1047         out of ChangeLog that should never have been there in the first place.
1048         Also, I had to fix a bug in MockUser in order to test the new command.
1049
1050         * Scripts/webkitpy/common/checkout/api.py:
1051         * Scripts/webkitpy/common/checkout/changelog.py:
1052         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1053         * Scripts/webkitpy/common/checkout/deps.py: Added.
1054         * Scripts/webkitpy/common/config/urls.py:
1055         * Scripts/webkitpy/tool/commands/__init__.py:
1056         * Scripts/webkitpy/tool/commands/download_unittest.py:
1057         * Scripts/webkitpy/tool/commands/roll.py: Added.
1058         * Scripts/webkitpy/tool/commands/roll_unittest.py: Added.
1059         * Scripts/webkitpy/tool/commands/upload_unittest.py:
1060         * Scripts/webkitpy/tool/mocktool.py:
1061         * Scripts/webkitpy/tool/steps/__init__.py:
1062         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py: Added.
1063         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
1064         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py: Added.
1065         * Scripts/webkitpy/tool/steps/suggestreviewers_unittest.py:
1066         * Scripts/webkitpy/tool/steps/updatechromiumdeps.py: Added.
1067         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
1068
1069 2011-01-27  Greg Coletta  <greg.coletta@nokia.com>
1070
1071         Reviewed by Laszlo Gombos.
1072
1073         Get rid of prefix header dependency for WebKit2 build system
1074         https://bugs.webkit.org/show_bug.cgi?id=50174
1075
1076         Change the style checker so that it enforces config.h include for
1077         WebKit2.
1078
1079         * Scripts/webkitpy/style/checker.py:
1080
1081 2011-01-27  Maciej Stachowiak  <mjs@apple.com>
1082
1083         Reviewed by Darin Adler.
1084
1085         execCommand("Paste") doesn't work in WebKitTestRunner
1086         https://bugs.webkit.org/show_bug.cgi?id=52785
1087
1088         Enable both of the settings needed to allow paste.
1089         
1090         * WebKitTestRunner/TestController.cpp:
1091         (WTR::TestController::resetStateToConsistentValues):
1092
1093 2011-01-27  Jacob Dinu  <dinu.jacob@nokia.com>
1094
1095         Reviewed by Andreas Kling.
1096
1097         [Qt] QtTestBrowser: User input lost when toggling use of QGraphicsView
1098         https://bugs.webkit.org/show_bug.cgi?id=48440
1099
1100         Preserve user input when toggling use of QGraphicsView
1101
1102         * QtTestBrowser/launcherwindow.cpp:
1103         (LauncherWindow::initializeView):
1104         (LauncherWindow::loadFinished):
1105         * QtTestBrowser/launcherwindow.h:
1106         * QtTestBrowser/mainwindow.cpp:
1107         (MainWindow::addressUrl):
1108         * QtTestBrowser/mainwindow.h:
1109
1110 2011-01-27  Dirk Pranke  <dpranke@chromium.org>
1111
1112         Reviewed by Mihai Parparita.
1113
1114         new-run-webkit-tests: turn off pixel tests correctly by default
1115         for webkit-based ports. r70013 (bug 47510) used
1116         port.set_option_default() to attempt to set default values, but
1117         that didn't work correctly. I have removed set_option_default
1118         for now since it was only being used in two places and in three
1119         useless unit tests. There is a separate bug open to fix the
1120         option parsing (48095), so this workaround is fine for now.
1121
1122         https://bugs.webkit.org/show_bug.cgi?id=53217
1123
1124         * Scripts/webkitpy/layout_tests/port/webkit.py:
1125         * Scripts/webkitpy/layout_tests/port/base.py:
1126         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1127
1128 2011-01-27  Balazs Kelemen  <kbalazs@webkit.org>
1129
1130         Rubber-stamped by Ariya Hidayat.
1131
1132         Trivial crash fix in WTR.
1133
1134         * WebKitTestRunner/TestController.cpp:
1135         (WTR::TestController::initialize): Increase the size
1136         of the vector by one to be able to store the null character.
1137
1138 2011-01-27  Balazs Kelemen  <kbalazs@webkit.org>
1139
1140         Reviewed by Csaba Osztrogonác.
1141
1142         [Qt][WK2] WTR should be initialized in the same way as DRT
1143         https://bugs.webkit.org/show_bug.cgi?id=53240
1144
1145         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
1146         (WTR::activateFonts): Added missing initialization steps.
1147
1148 2011-01-27  Joone Hur <joone.hur@collabora.co.uk>
1149
1150         Unreviewed. 
1151
1152         Adding myself to committers.py.
1153
1154         * Scripts/webkitpy/common/config/committers.py:
1155
1156 2011-01-27  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1157
1158         Reviewed by Csaba Osztrogonác.
1159
1160         [Qt] [Symbian] Move project files into Source
1161         https://bugs.webkit.org/show_bug.cgi?id=52891
1162
1163         Fix the Symbian build after the project files
1164         are moved to Source directory. On Symbian qmake
1165         needs to run in the same directory where the main
1166         pro files (WebKit.pro, Tools.pro) are located.
1167
1168         * Scripts/webkitdirs.pm: Change to the directory where the pro file
1169         is located before running qmake for Symbian. Qmake on Symbian
1170         does not properly honor the "-o" option, work it around by setting
1171         the name of the Makefile to bld.inf.
1172
1173 2011-01-27  Zoltan Horvath  <zoltan@webkit.org>
1174
1175         Reviewed by Andreas Kling.
1176
1177         [Qt] Add simple zooming features to MiniBrowser
1178         https://bugs.webkit.org/show_bug.cgi?id=53231
1179
1180         Add View menu and Zoom In, Zoom Out, Zoom Reset actions to MiniBrowser.
1181
1182         * MiniBrowser/qt/BrowserWindow.cpp:
1183         (BrowserWindow::BrowserWindow):
1184         (BrowserWindow::zoomIn):
1185         (BrowserWindow::zoomOut):
1186         (BrowserWindow::resetZoom):
1187         (BrowserWindow::updateUserAgentList):
1188         (BrowserWindow::applyZoom):
1189         * MiniBrowser/qt/BrowserWindow.h:
1190
1191 2011-01-26  Maciej Stachowiak  <mjs@apple.com>
1192
1193         Reviewed by Dan Bernstein.
1194
1195         WebKitTestRunner needs to support layoutTestController.evaluateInWebInspector
1196         https://bugs.webkit.org/show_bug.cgi?id=42319
1197         
1198         Add evaluateInWebInspector and other APIs needed for inspector tests to run.
1199
1200         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1201         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1202         (WTR::LayoutTestController::showWebInspector):
1203         (WTR::LayoutTestController::closeWebInspector):
1204         (WTR::LayoutTestController::evaluateInWebInspector):
1205         (WTR::LayoutTestController::setTimelineProfilingEnabled):
1206         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1207         * WebKitTestRunner/TestInvocation.cpp:
1208         (WTR::shouldOpenWebInspector):
1209         (WTR::TestInvocation::invoke):
1210         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
1211
1212 2011-01-26  Martin Robinson  <mrobinson@igalia.com>
1213
1214         Reviewed by Xan Lopez.
1215
1216         [GTK] Pixel dumps do not include scrollbars in output images
1217         https://bugs.webkit.org/show_bug.cgi?id=53216
1218
1219         Show scrollbars in pixel dumps. This will fix pixel dumps for tests
1220         that have scrollbars.
1221
1222         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
1223         (createBitmapContextFromWebView): Take the snapshot of the containing GtkScrolledWindow
1224         instead of the web view itself.
1225
1226 2011-01-26  Dirk Pranke  <dpranke@chromium.org>
1227
1228         Reviewed by Mihai Parparita.
1229
1230         Fix regression introduced in r76322 ... new-run-webkit-tests
1231         was attempting to save the image diff output as a UTF-8-encoded
1232         file.
1233
1234         https://bugs.webkit.org/show_bug.cgi?id=53210
1235
1236         * Scripts/webkitpy/layout_tests/port/webkit.py:
1237
1238 2011-01-26  Sheriff Bot  <webkit.review.bot@gmail.com>
1239
1240         Unreviewed, rolling out r76709.
1241         http://trac.webkit.org/changeset/76709
1242         https://bugs.webkit.org/show_bug.cgi?id=53194
1243
1244         "broke python tests on non-snowleopard platforms" (Requested
1245         by dpranke on #webkit).
1246
1247         * Scripts/webkitpy/layout_tests/port/factory.py:
1248         * Scripts/webkitpy/layout_tests/port/mock_drt.py: Removed.
1249         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Removed.
1250
1251 2011-01-26  Dirk Pranke  <dpranke@chromium.org>
1252
1253         Reviewed by Tony Chang.
1254
1255         new-run-webkit-tests: add a "mock DRT" port implementation
1256         and a separate class that emulates what we expect the
1257         DumpRenderTree behavior to be.
1258
1259         This will eventually replace port/dryrun.py and allow us to get
1260         better test coverage of the new-run-webkit-tests code as well as
1261         a reference for what new-run-webkit-tests expects from DRT.
1262
1263         This is the first attempt at this, and it is pretty bare-boned. It
1264         really only has been tested on the 'mac' port (and a little on
1265         the 'chromium-mac' port.
1266
1267         https://bugs.webkit.org/show_bug.cgi?id=53126
1268
1269         * Scripts/webkitpy/layout_tests/port/mock_drt.py: Added.
1270         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Added.
1271         * Scripts/webkitpy/layout_tests/port/factory.py:
1272
1273 2011-01-26  Xianzhu Wang  <wangxianzhu@google.com>
1274
1275         Reviewed by Tony Chang.
1276
1277         Add '--no-timeout' option to Chromium DRT to ease debugging.
1278         https://bugs.webkit.org/show_bug.cgi?id=52873
1279
1280         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1281         (main):
1282
1283 2011-01-26  Csaba Osztrogonác  <ossy@webkit.org>
1284
1285         Reviewed by Andreas Kling.
1286
1287         [Qt] Fix qt_minimal build
1288         https://bugs.webkit.org/show_bug.cgi?id=53172
1289
1290         * QtTestBrowser/locationedit.h:
1291
1292 2011-01-26  Mansi Mithal  <mansi.mithal@nokia.com>
1293
1294         Reviewed by Antonio Gomes.
1295
1296         QtTestBrowser should have a UI Setting to disable plugins
1297         https://bugs.webkit.org/show_bug.cgi?id=52408
1298         
1299         Added a new action item named "Disable Plugins"
1300         under the "Settings" menu. 
1301
1302         * QtTestBrowser/launcherwindow.cpp:
1303         (LauncherWindow::createChrome):
1304         (LauncherWindow::togglePlugins):
1305         * QtTestBrowser/launcherwindow.h:
1306
1307 2011-01-25  Patrick Gansterer  <paroga@webkit.org>
1308
1309         Reviewed by Adam Barth.
1310
1311         Move main CMakeLists.txt into Source directory
1312         https://bugs.webkit.org/show_bug.cgi?id=52888
1313
1314         * Scripts/webkitdirs.pm:
1315
1316 2011-01-25  Patrick Gansterer  <paroga@webkit.org>
1317
1318         Reviewed by Eric Seidel.
1319
1320         Improve label text in submit-to-ews
1321         https://bugs.webkit.org/show_bug.cgi?id=53130
1322
1323         * QueueStatusServer/templates/submittoews.html:
1324
1325 2011-01-25  Mansi Mithal  <mansi.mithal@nokia.com>
1326
1327         Reviewed by Antonio Gomes.
1328
1329         QtTestBrowser should have a UI Settings to prevent loading images
1330         https://bugs.webkit.org/show_bug.cgi?id=52409
1331         
1332         Added a new action item named "DisableAutoLoadImages"
1333         under the "Settings" menu 
1334
1335         * QtTestBrowser/launcherwindow.cpp:
1336         (LauncherWindow::createChrome):
1337         (LauncherWindow::toggleAutoLoadImages):
1338         * QtTestBrowser/launcherwindow.h:
1339
1340 2011-01-25  Dirk Pranke  <dpranke@chromium.org>
1341
1342         Reviewed by Tony Chang.
1343
1344         Minor bug fixes and cleanup for filesystem wrappers, port/* test
1345         classes, test_expectations.py. This change adds "test-win" and
1346         "test-mac" variants to the test port so that we can better test
1347         rebaselining, and adds a MockUser() object for reuse in testing.
1348
1349         https://bugs.webkit.org/show_bug.cgi?id=53036
1350
1351         * Scripts/webkitpy/common/system/filesystem.py:
1352         * Scripts/webkitpy/common/system/filesystem_mock.py:
1353         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1354         * Scripts/webkitpy/layout_tests/port/factory.py:
1355         * Scripts/webkitpy/layout_tests/port/base.py:
1356         * Scripts/webkitpy/layout_tests/port/test.py:
1357         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1358         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
1359         * Scripts/webkitpy/tool/mocktool.py:
1360
1361 2011-01-25  Tony Chang  <tony@chromium.org>
1362
1363         Reviewed by Dimitri Glazkov.
1364
1365         [chromium] remove unused layoutTestController callback
1366         https://bugs.webkit.org/show_bug.cgi?id=53103
1367
1368         This method is used by a test_shell_test, but not needed by DRT.
1369
1370         * DumpRenderTree/chromium/LayoutTestController.cpp:
1371         (LayoutTestController::LayoutTestController):
1372         * DumpRenderTree/chromium/LayoutTestController.h:
1373
1374 2011-01-25  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1375
1376         Reviewed by Andreas Kling.
1377
1378         [GTK] Remove 64 bits release bot from the buildbot master
1379         https://bugs.webkit.org/show_bug.cgi?id=52899
1380
1381         Removes the 64 bits release slave from the buildbot configuration,
1382         so that we can use it as an EWS.
1383
1384         * BuildSlaveSupport/build.webkit.org-config/config.json:
1385
1386 2011-01-24  Maciej Stachowiak  <mjs@apple.com>
1387
1388         Reviewed by Dan Bernstein.
1389
1390         Implement database quota callback to fix storage tests on WebKit2 bot
1391         https://bugs.webkit.org/show_bug.cgi?id=53064
1392
1393         * WebKitTestRunner/TestController.cpp:
1394         (WTR::exceededDatabaseQuota):
1395         (WTR::TestController::createOtherPage):
1396         (WTR::TestController::initialize):
1397
1398 2011-01-24  Maciej Stachowiak  <mjs@apple.com>
1399
1400         Reviewed by Anders Carlsson.
1401
1402         Use designated temp directory for the database for WebKit2
1403         https://bugs.webkit.org/show_bug.cgi?id=53052
1404         
1405         Adopt the new WK2 API for this.
1406
1407         * WebKitTestRunner/TestController.cpp:
1408         (WTR::TestController::libraryPathForTesting):
1409         (WTR::TestController::initialize):
1410         * WebKitTestRunner/TestController.h:
1411         * WebKitTestRunner/mac/TestControllerMac.mm:
1412         (WTR::TestController::platformLibraryPathForTesting):
1413         * WebKitTestRunner/qt/TestControllerQt.cpp:
1414         (WTR::TestController::platformLibraryPathForTesting):
1415         * WebKitTestRunner/win/TestControllerWin.cpp:
1416         (WTR::TestController::platformLibraryPathForTesting):
1417
1418 2011-01-24  Lucas Forschler  <lforschler@apple.com>
1419
1420         Reviewed by Stephanie Lewis.
1421
1422         Add a new Leopard test bot.
1423
1424         * BuildSlaveSupport/build.webkit.org-config/config.json:
1425
1426 2011-01-24  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1427
1428         Reviewed by Adam Barth.
1429
1430         Add EFL Builder to core waterfall
1431         https://bugs.webkit.org/show_bug.cgi?id=52704
1432
1433         Add EFL Builder to the core waterfall again.
1434
1435         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1436         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1437
1438 2011-01-24  Xianzhu Wang  <wangxianzhu@google.com>
1439
1440         Reviewed by Tony Chang.
1441
1442         new-run-webkit-tests fails to start HTTP server if there are proxy settings
1443         https://bugs.webkit.org/show_bug.cgi?id=52872
1444
1445         Force disabling proxy to resolve the problem.
1446
1447         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
1448         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
1449
1450 2011-01-24  Andreas Kling  <kling@webkit.org>
1451
1452         Reviewed by Darin Adler.
1453
1454         check-webkit-style: Update exemptions following Source/ move.
1455         https://bugs.webkit.org/show_bug.cgi?id=53017
1456
1457         * Scripts/webkitpy/style/checker.py:
1458         * Scripts/webkitpy/style/checker_unittest.py:
1459
1460 2011-01-24  Andras Becsi  <abecsi@webkit.org>
1461
1462         Rubber-stamped by Csaba Osztrogonác.
1463
1464         [Qt] Move project files into Source
1465         https://bugs.webkit.org/show_bug.cgi?id=52891
1466
1467         * DumpRenderTree/qt/ImageDiff.pro: Add missing "Source" to WebKit.pri path
1468
1469 2011-01-24  Mikhail Naganov  <mnaganov@chromium.org>
1470
1471         Reviewed by Yury Semikhatsky.
1472
1473         Web Inspector: Find duplicate strings in localizedStrings.js
1474
1475         https://bugs.webkit.org/show_bug.cgi?id=53005
1476
1477         * Scripts/check-inspector-strings:
1478
1479 2011-01-24  Zoltan Horvath  <zoltan@webkit.org>
1480
1481         Reviewed by Andreas Kling.
1482
1483         [Qt] Regroup MiniBrowser's menubar and add open file action
1484         https://bugs.webkit.org/show_bug.cgi?id=53000
1485
1486         Add File and Develop menu to MiniBrowser's menubar and add open file action to File menu.
1487
1488         * MiniBrowser/qt/BrowserWindow.cpp:
1489         (BrowserWindow::BrowserWindow):
1490         (BrowserWindow::openFile):
1491         (BrowserWindow::~BrowserWindow):
1492         * MiniBrowser/qt/BrowserWindow.h:
1493
1494 2011-01-24  Csaba Osztrogonác  <ossy@webkit.org>
1495
1496         Unreviewed fix after r76496
1497
1498         [Qt] Move project files into Source
1499         https://bugs.webkit.org/show_bug.cgi?id=52891
1500
1501         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Remove unnecessary "Source" from the path.
1502         * BuildSlaveSupport/built-product-archive: Remove unnecessary "Source" from the path.
1503         * Scripts/webkitdirs.pm: Add the accidentally removed slash to the path.
1504
1505 2011-01-24  Andras Becsi  <abecsi@webkit.org>
1506
1507         Reviewed by Csaba Osztrogonác.
1508
1509         [Qt] Move project files into Source
1510         https://bugs.webkit.org/show_bug.cgi?id=52891
1511
1512         * DerivedSources.pro: Renamed from DerivedSources.pro.
1513         * DumpRenderTree/qt/DumpRenderTree.pro:
1514         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1515         * MiniBrowser/DerivedSources.pro:
1516         * MiniBrowser/qt/MiniBrowser.pro:
1517         * QtTestBrowser/QtTestBrowser.pro:
1518         * Scripts/webkitdirs.pm:
1519         * Tools.pro: Added.
1520         * WebKitTestRunner/DerivedSources.pro:
1521         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1522         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1523
1524 2011-01-22  Geoffrey Garen  <ggaren@apple.com>
1525
1526         Reviewed by Dan Bernstein.
1527
1528         Beefed up --threaded mode to catch even more kinds of errors.
1529         https://bugs.webkit.org/show_bug.cgi?id=52971
1530
1531         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Use a shared
1532         context group to force JSC to mark multiple threads. (This used to be
1533         the default, but it changed in SnowLeopard.)
1534         (runJavaScriptThread): Do more locking and unlocking, and more allocation,
1535         to give threading mistakes more chances to show themselves.
1536         (startJavaScriptThreads):
1537         (stopJavaScriptThreads):
1538
1539 2011-01-22  Robert Hogan  <robert@webkit.org>
1540
1541         Reviewed by Andreas Kling.
1542
1543         [Qt] Support layoutTestController.addURLToRedirect()
1544         https://bugs.webkit.org/show_bug.cgi?id=52956
1545
1546         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1547         (LayoutTestController::addURLToRedirect):
1548         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1549
1550 2011-01-22  Robert Hogan  <robert@webkit.org>
1551
1552         Reviewed by Kenneth Rohde Christiansen.
1553
1554         [Qt] REGRESSION (r72360): http/tests/security/aboutBlank/xss-DENIED-* tests fail
1555         https://bugs.webkit.org/show_bug.cgi?id=49802
1556
1557         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1558         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1559         (WebCore::DumpRenderTree::open):
1560
1561 2011-01-21  Adam Barth  <abarth@webkit.org>
1562
1563         Reviewed by Maciej Stachowiak.
1564
1565         Disable mac_unittest.py that fails on some of the Mac bots
1566         https://bugs.webkit.org/show_bug.cgi?id=52947
1567
1568         As noted in the comment, this test does not appear to be correct
1569         because the function this test is testing returns different results
1570         depending on which flavor of Mac the test is run on.  This patch
1571         disable the test.  Hopefully we can re-enable the test once we've
1572         probably insulated the test from its environment.
1573
1574         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1575
1576 2011-01-21  Dirk Pranke  <dpranke@chromium.org>
1577
1578         Reviewed by Mihai Parparita.
1579
1580         Fix bug introduced in r76322 that caused NRWT to not actually
1581         read the Skipped files properly.
1582
1583         https://bugs.webkit.org/show_bug.cgi?id=52771
1584
1585         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1586         * Scripts/webkitpy/layout_tests/port/webkit.py:
1587         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1588
1589 2011-01-21  Sam Weinig  <sam@webkit.org>
1590
1591         Reviewed by Geoffrey Sean Garen and Mark Rowe.
1592
1593         WebKitTestRunner needs the HOME environment variable to be set.
1594         <rdar://problem/8896573>
1595
1596         * Scripts/old-run-webkit-tests: Set the HOME environment variable if
1597         it exists.
1598
1599 2011-01-21  Dirk Pranke  <dpranke@chromium.org>
1600
1601         Reviewed by Eric Seidel.
1602
1603         Suppress a few remaining integration tests so that none of the
1604         layout_test unit tests ever read from the filesystem or launch
1605         subprocesses that aren't part of the unit tests.
1606
1607         Also fix a minor bug in the printing unit tests that was
1608         incorrectly relying on sys.argv.
1609
1610         https://bugs.webkit.org/show_bug.cgi?id=52863
1611
1612         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1613         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1614         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1615
1616 2011-01-21  Darin Adler  <darin@apple.com>
1617
1618        Fix Mac build.
1619
1620         * MiniBrowser/mac/BrowserWindowController.m:
1621         (-[BrowserWindowController awakeFromNib]): Pass 0 for runModal function.
1622
1623 2011-01-20  Darin Adler  <darin@apple.com>
1624
1625         Reviewed by Dan Bernstein.
1626
1627         WebKit2: Implement showModalDialog
1628         https://bugs.webkit.org/show_bug.cgi?id=52855
1629
1630         This fixes WebKitTestRunner to compile, but more work is probably
1631         needed to get it to pass the tests.
1632
1633         * WebKitTestRunner/TestController.cpp:
1634         (WTR::TestController::runModal): Added. Calls through to the
1635         platform-specific version of runModal.
1636         (WTR::TestController::createOtherPage): Changed to be a private
1637         static member function so it can refer to runModal, which is
1638         a private static member function.
1639         (WTR::TestController::initialize): Pass 0 for the runModal
1640         function since we don't need to run the main window modal.
1641         I suspect this is wrong and will need to change.
1642         * WebKitTestRunner/TestController.h: Added declarations for
1643         the functions added above.
1644         * WebKitTestRunner/mac/TestControllerMac.mm:
1645         (WTR::TestController::runModal): Added. Untested implementation.
1646         * WebKitTestRunner/qt/TestControllerQt.cpp:
1647         (WTR::TestController::runModal): Added.
1648         * WebKitTestRunner/win/TestControllerWin.cpp:
1649         (WTR::TestController::runModal): Added.
1650
1651 2011-01-21  Eric Seidel  <eric@webkit.org>
1652
1653         Reviewed by Adam Barth.
1654
1655         Split Host object off from WebKitPatch for easier re-use
1656         https://bugs.webkit.org/show_bug.cgi?id=52284
1657
1658         new-run-webkit-tests and other tools are eventually going to want one of these.
1659         Basically you need to inherit from this class if you want to pretend to be a
1660         self.tool object for Steps/Commands.
1661
1662         * Scripts/webkitpy/common/host.py: Added.
1663         * Scripts/webkitpy/tool/main.py:
1664
1665 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1666
1667         Reviewed by Adam Barth.
1668
1669         Disable the tests that start and stop the http server and web
1670         server, so that we don't have to worry about port collisions on
1671         the bots.
1672
1673         https://bugs.webkit.org/show_bug.cgi?id=52861
1674
1675         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1676
1677 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1678
1679         Reviewed by Eric Seidel.
1680
1681         nrwt: rewrite google_chrome_unittest to use mock filesystem.
1682         
1683         https://bugs.webkit.org/show_bug.cgi?id=52772
1684         
1685         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
1686
1687 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1688
1689         Reviewed by Eric Siedel.
1690
1691         nrwt: clean up almost all remaining port references, remove
1692         unnecessary import clauses. The only remaining references are
1693         in places where a mock filesystem makes no sense or can't be
1694         used, and in one routine in port/google_chrome_unittest that
1695         I'll rewrite in a separate patch.
1696
1697         https://bugs.webkit.org/show_bug.cgi?id=52771
1698
1699         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1700         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1701         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1702         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1703         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1704         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1705         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1706         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
1707         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
1708         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
1709         * Scripts/webkitpy/layout_tests/port/gtk.py:
1710         * Scripts/webkitpy/layout_tests/port/mac.py:
1711         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1712         * Scripts/webkitpy/layout_tests/port/qt.py:
1713         * Scripts/webkitpy/layout_tests/port/webkit.py:
1714         * Scripts/webkitpy/layout_tests/port/win.py:
1715         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
1716
1717 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1718
1719         Reviewed by Mihai Parparita.
1720
1721         remove fs refs from run_webkit_tests, rebaseline_chromium_webkit_tests
1722
1723         https://bugs.webkit.org/show_bug.cgi?id=52762
1724
1725         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1726         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1727
1728 2011-01-20  Tony Chang  <tony@chromium.org>
1729
1730         Reviewed by Ojan Vafai.
1731
1732         [chromium] fix the paths used for the rebaseline tool
1733         https://bugs.webkit.org/show_bug.cgi?id=52857
1734
1735         Some of the bots were renamed so the path to grab the results zip
1736         file has changed.
1737
1738         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1739
1740 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1741
1742         Reviewed by Tony Chang.
1743
1744         Fix bug introduced in r72688 / bug 52768 that broke the
1745         generation of the output filename links in the results.html
1746         output. Apparently none of the unit tests actually checked to
1747         make sure the generated links were correct :(
1748
1749         https://bugs.webkit.org/show_bug.cgi?id=52854
1750
1751         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1752         * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
1753
1754 2011-01-20  Alexey Proskuryakov  <ap@apple.com>
1755
1756         Reviewed by Darin Adler.
1757
1758         https://bugs.webkit.org/show_bug.cgi?id=52849
1759         Make window.print work with WebKit2
1760
1761         * MiniBrowser/mac/BrowserWindowController.m:
1762         (-[BrowserWindowController awakeFromNib]):
1763         * WebKitTestRunner/TestController.cpp:
1764         (WTR::createOtherPage):
1765         (WTR::TestController::initialize):
1766         Added zeroes to WKPageUIClient structures to avoid build failures.
1767
1768 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1769
1770         Reviewed by Eric Seidel.
1771
1772         nrwt: remove fs refs from printing, test_failures, test_expectations, text_diff
1773
1774         https://bugs.webkit.org/show_bug.cgi?id=52756
1775
1776         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1777         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1778         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1779         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
1780         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1781         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
1782
1783 2011-01-20  Mansi Mithal  <mansi.mithal@nokia.com>
1784
1785         Reviewed by Antonio Gomes.
1786
1787         QtTestBrowser should have a seperate menu for Settings
1788         https://bugs.webkit.org/show_bug.cgi?id=52817
1789         
1790         Added a new menu item named "Settings"
1791         and moved the "Enable interrupting js scripts" and "Enable js pop up windows" under the "Settings" menu 
1792
1793         * QtTestBrowser/launcherwindow.cpp:
1794         (LauncherWindow::createChrome):
1795
1796 2011-01-20  Sam Weinig  <sam@webkit.org>
1797
1798         Reviewed by John Sullivan.
1799
1800         Update update-webkit-localizable-strings with new path to WebKit.
1801
1802         * Scripts/update-webkit-localizable-strings:
1803
1804 2011-01-20  James Robinson  <jamesr@chromium.org>
1805
1806         Reviewed by Darin Fisher.
1807
1808         Implement mozilla's requestAnimationFrame API
1809         https://bugs.webkit.org/show_bug.cgi?id=51218
1810
1811         Chromium DumpRenderTree support for window.webkitRequestAnimationFrame.
1812
1813         * DumpRenderTree/chromium/WebViewHost.cpp:
1814         (invokeScheduleComposite):
1815         (WebViewHost::scheduleAnimation):
1816         (WebViewHost::paintInvalidatedRegion):
1817         * DumpRenderTree/chromium/WebViewHost.h:
1818
1819 2011-01-20  Maciej Stachowiak  <mjs@apple.com>
1820
1821         Reviewed by Adam Roben.
1822
1823         WebKitTestRunner needs to support layoutTestController.evaluateScriptInIsolatedWorld
1824         https://bugs.webkit.org/show_bug.cgi?id=42327
1825
1826         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm: Add support
1827         for methods that take their normal arguments but also a JSContextRef.
1828         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: IDL definition
1829         for evaluateScriptInIsolatedWorld.
1830         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1831         (WTR::InjectedBundlePage::didClearWindowForFrame): Set a magic variable only if
1832         this call is for an isolated world.
1833         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1834         (WTR::worldMap): Helper to create a world map.
1835         (WTR::LayoutTestController::worldIDForWorld): Map from an ID to a world.
1836         (WTR::LayoutTestController::evaluateScriptInIsolatedWorld): The newly
1837         added LayoutTestController API.
1838         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1839
1840 2011-01-19  Adam Roben  <aroben@apple.com>
1841
1842         Convert paths in environment variables back to msys-style inside commit-log-editor
1843
1844         When this script gets run from inside git commit, msys-style paths in the environment will
1845         have been turned into Windows-style paths with forward slashes. This screws up functions
1846         like File::Spec->rel2abs, which seem to rely on $PWD having an msys-style path. We convert
1847         the paths back to msys-style before doing anything else.
1848
1849         Fixes <http://webkit.org/b/48527> commit-log-editor uses full paths for section headers when
1850         using msysgit's Perl and multiple ChangeLogs have been edited
1851
1852         Reviewed by David Kilzer.
1853
1854         * Scripts/commit-log-editor: Call fixEnvironment before doing anything else.
1855         (fixEnvironment): Added. When run in msys in conjunction with git (i.e., when invoked from
1856         inside git commit), convert Windows-style paths in the environment back to msys-style paths.
1857
1858 2011-01-20  Zoltan Horvath  <zoltan@webkit.org>
1859
1860         [Win] Unreviewed build fix after r76248.
1861
1862         * DumpRenderTree/ForwardingHeaders/wtf/FastAllocBase.h: Added.
1863
1864 2011-01-20  Zoltan Horvath  <zoltan@webkit.org>
1865
1866         Reviewed by Csaba Osztrogonác.
1867
1868         Refactoring of the custom allocation framework
1869         https://bugs.webkit.org/show_bug.cgi?id=49897
1870
1871         Inheriting from FastAllocBase can result in objects getting larger (bug #33896, #46589).
1872         The modification replaces Noncopyable and FastAllocBase classes and these inherits with their
1873         equivalent macro implementation at the necessary places.
1874 2011-01-20  Yi Shen  <yi.4.shen@nokia.com>
1875
1876         Unreviewed. 
1877
1878         Adding myself to committers.py.
1879
1880         * Scripts/webkitpy/common/config/committers.py:
1881
1882 2011-01-20  Adam Barth  <abarth@webkit.org>
1883
1884         Reviewed by Tony Chang.
1885
1886         Chromium builders don't delete unversioned directories when DEPS change
1887         https://bugs.webkit.org/show_bug.cgi?id=52745
1888
1889         If we pass this option to gclient sync, gclient will delete directories
1890         that are no longer part of DEPS instead of leaving them around to
1891         confuse us later.  Apparently, the downstream buildbots use this option
1892         already.
1893
1894         * Scripts/update-webkit-chromium:
1895
1896 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1897
1898         Unreviewed, build fix - I pulled this patch in to fix an issue
1899         revealed by r76195 running on some new bots). Also fix a couple
1900         of other issues revealed in testing.
1901
1902         nrwt: remove fs refs from layout_package/json*
1903
1904         https://bugs.webkit.org/show_bug.cgi?id=52754
1905
1906         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1907         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1908         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
1909         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1910         * Scripts/webkitpy/layout_tests/port/base.py:
1911
1912 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1913
1914         Unreviewed, build fix.
1915
1916         Fix a couple of minor bugs discovered while bringing up new bots
1917         for testing.
1918
1919         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1920         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1921
1922 2011-01-19  James Robinson  <jamesr@chromium.org>
1923
1924         Unreviewed, rolling out r76194.
1925         http://trac.webkit.org/changeset/76194
1926         https://bugs.webkit.org/show_bug.cgi?id=51218
1927
1928         Caused mysterious compile failure on the chromium win
1929         build.webkit.org bots
1930
1931         * DumpRenderTree/chromium/WebViewHost.cpp:
1932         (WebViewHost::paintInvalidatedRegion):
1933         * DumpRenderTree/chromium/WebViewHost.h:
1934
1935 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1936
1937         Reviewed by Mihai Parparita.
1938
1939         remove fs refs from test_runner, dump_render_tree_thread
1940
1941         https://bugs.webkit.org/show_bug.cgi?id=52753
1942
1943         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1944         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1945         * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
1946         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1947
1948 2011-01-19  James Robinson  <jamesr@chromium.org>
1949
1950         Reviewed by Darin Fisher.
1951
1952         Implement mozilla's requestAnimationFrame API
1953         https://bugs.webkit.org/show_bug.cgi?id=51218
1954
1955         Chromium DumpRenderTree support for window.webkitRequestAnimationFrame.
1956
1957         * DumpRenderTree/chromium/WebViewHost.cpp:
1958         (invokeScheduleComposite):
1959         (WebViewHost::scheduleAnimation):
1960         (WebViewHost::paintInvalidatedRegion):
1961         * DumpRenderTree/chromium/WebViewHost.h:
1962
1963 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1964
1965         Unreviewed, build fix.
1966
1967         Fix a few incorrect "self._filesystem" references introduced in
1968         r76184.
1969
1970         * Scripts/webkitpy/layout_tests/port/chromium.py:
1971         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1972
1973 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1974
1975         Reviewed by Mihai Parparita.
1976
1977         add a .sep property, abspath(), isabs(), mtime(), and
1978         open_text_file_for_writing() to filesystem modules. Some of
1979         these properties are not needed in this patch but will be needed
1980         in subsequent patches (I'm doing this to avoid having to track
1981         multiple versions of a single file).
1982
1983         Also, change most of the port/* modules to use the filesystem
1984         objects instead of referencing the filesystem directly.
1985
1986         https://bugs.webkit.org/show_bug.cgi?id=52748
1987
1988         * Scripts/webkitpy/common/system/filesystem.py:
1989         * Scripts/webkitpy/common/system/filesystem_mock.py:
1990         * Scripts/webkitpy/layout_tests/port/__init__.py:
1991         * Scripts/webkitpy/layout_tests/port/base.py:
1992         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1993         * Scripts/webkitpy/layout_tests/port/chromium.py:
1994         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1995         * Scripts/webkitpy/layout_tests/port/config.py:
1996         * Scripts/webkitpy/layout_tests/port/test.py:
1997         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
1998
1999 2011-01-19  Maciej Stachowiak  <mjs@apple.com>
2000
2001         Reviewed by Anders Carlsson.
2002
2003         If resetting between tests times out, treat it as a WebProcess crash
2004         https://bugs.webkit.org/show_bug.cgi?id=52757
2005
2006         * WebKitTestRunner/TestController.cpp:
2007         (WTR::TestController::runTest):
2008
2009 2011-01-19  Alexey Proskuryakov  <ap@apple.com>
2010
2011         Reviewed by Darin Adler.
2012
2013         https://bugs.webkit.org/show_bug.cgi?id=52739
2014         Make it possible for a WebKit2 client to print headers and footers
2015
2016         Added dummy implementations for new printing UIClient calls.
2017
2018         * MiniBrowser/mac/BrowserWindowController.m:
2019         (-[BrowserWindowController awakeFromNib]):
2020         * WebKitTestRunner/TestController.cpp:
2021         (WTR::createOtherPage):
2022         (WTR::TestController::initialize):
2023
2024 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2025
2026         Reviewed by Ojan Vafai.
2027
2028         Change webkitpy/layout_tests/port/test.py to use the
2029         in-memory filesystem for cleaner unit testing. This
2030         change allows us to kill a lot of code that was
2031         specific to the test port, at the cost of being a
2032         little less clear about how things would work if
2033         you didn't have a filesystem.
2034
2035         https://bugs.webkit.org/show_bug.cgi?id=52605
2036
2037         * Scripts/webkitpy/layout_tests/port/test.py:
2038
2039 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2040
2041         Unreviewed, build fix.
2042
2043         Fix test failure caused by committing attachment 79368 instead
2044         of attachment 79461 on bug 52604.
2045
2046         * Scripts/webkitpy/common/system/filesystem_mock.py:
2047
2048 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2049
2050         Reviewed by Mihai Parparita.
2051
2052         new-run-webkit-tests: remove use of os.walk, use mock filesystem for better
2053         unit testing. os.walk() is too much of a hassle to implement on
2054         top of the in-memory mock filesystem and adding the necessary
2055         interface to files_under() gives clients a cleaner API anyway
2056         (for this particular usage model).
2057
2058         https://bugs.webkit.org/show_bug.cgi?id=52691
2059
2060         * Scripts/webkitpy/common/system/filesystem.py:
2061         * Scripts/webkitpy/common/system/filesystem_mock.py:
2062         * Scripts/webkitpy/layout_tests/port/test_files.py:
2063         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
2064
2065 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2066
2067         Reviewed by Tony Chang.
2068
2069         Change more modules in the layout-tests code to use the
2070         filesystem wrapper for cleaner unit testing.
2071
2072         This patch also adds the glob() wrapper to the filesystem
2073         abstraction.
2074         
2075         https://bugs.webkit.org/show_bug.cgi?id=52604
2076
2077         * Scripts/webkitpy/layout_tests/port/test_files.py:
2078         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
2079         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
2080         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2081         * Scripts/webkitpy/common/system/filesystem.py:
2082         * Scripts/webkitpy/common/system/filesystem_mock.py:
2083
2084 2011-01-19  Levi Weintraub  <leviw@chromium.org>
2085
2086         Unreviewed.
2087
2088         Updating my email addresses and irc nick.
2089
2090         * Scripts/webkitpy/common/config/committers.py:
2091
2092 2011-01-19  Tony Chang  <tony@chromium.org>
2093
2094         Reviewed by Mihai Parparita.
2095
2096         [chromium] [linux] if check-sys-deps fails, output the failure reason
2097         https://bugs.webkit.org/show_bug.cgi?id=52671
2098
2099         * Scripts/webkitpy/common/system/executive_mock.py: Add support for
2100             error handler functions.
2101         * Scripts/webkitpy/layout_tests/port/chromium.py:
2102             output the error text from --check-sys-deps
2103         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2104
2105 2011-01-19  Aparna Nandyal  <aparna.nand@wipro.com>
2106
2107         Reviewed by Andreas Kling.
2108
2109         [Qt] QtTestBrowser crashes when closing if Facebook is opened
2110         https://bugs.webkit.org/show_bug.cgi?id=52554
2111         
2112         QtNetworkAccessManager is created in a thread and set as
2113         member variable in QWebPage. When the thread is destroyed
2114         the object is still used. So fix will set the object to
2115         NULL once the thread is destroyed.
2116
2117         * QtTestBrowser/launcherwindow.cpp:
2118         (LauncherWindow::~LauncherWindow):
2119
2120 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
2121
2122         Rubber stamped by Csaba Osztrogonac
2123
2124         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: Removed unncessary inculde of WKStringCF.h
2125
2126 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
2127
2128         Reviewed by Tony Chang.
2129
2130         new-run-webkit-tests: add a --build-directory command line argument
2131
2132         Official Google Chrome builds use a non-standard build directory
2133         location. This patch adds a --build-directory argument that
2134         allows that location to be specified on the command line. Only
2135         Chromium-based builds will use this flag for now, but anyone can
2136         in the future.
2137
2138         There are no unit tests for this since it's difficult to test
2139         until mock filesystems are fully supported in the code. This was
2140         tested by hand for now.
2141
2142         https://bugs.webkit.org/show_bug.cgi?id=52694
2143
2144         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2145         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2146         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2147         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2148
2149 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
2150
2151         Not reviewed. Bot fix.
2152
2153         Remove an inadvertently committed debugging print.
2154
2155         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2156         (LayoutTestController::notifyDone):
2157
2158 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
2159
2160         Reviewed by Sam Weinig.
2161
2162         WebKitTestRunner should track loading more like DumpRenderTree
2163         https://bugs.webkit.org/show_bug.cgi?id=52692
2164
2165         Change load tracking to track the current top loading frame, in the manner of DumpRenderTree.
2166         This makes some tests that call notifyDone multiple times pass.
2167         
2168         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2169         (WTR::InjectedBundle::InjectedBundle):
2170         (WTR::InjectedBundle::done):
2171         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2172         (WTR::InjectedBundle::topLoadingFrame):
2173         (WTR::InjectedBundle::setTopLoadingFrame):
2174         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2175         (WTR::InjectedBundlePage::InjectedBundlePage):
2176         (WTR::InjectedBundlePage::stopLoading):
2177         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
2178         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
2179         (WTR::InjectedBundlePage::didFinishLoadForFrame):
2180         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
2181         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2182         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2183         (WTR::LayoutTestController::notifyDone):
2184         * WebKitTestRunner/TestController.cpp:
2185         (WTR::TestController::didReceiveMessageFromInjectedBundle):
2186
2187 2011-01-18  Mihai Parparita  <mihaip@chromium.org>
2188
2189         Reviewed by Kent Tamura.
2190
2191         [Chromium] NRWT looking for DRT binary in the wrong path on Mac
2192         https://bugs.webkit.org/show_bug.cgi?id=52678
2193         
2194         Update path now that WebKit is inside Source.
2195
2196         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2197
2198 2011-01-18  Robert Hogan  <robert@webkit.org>
2199
2200         Reviewed by Simon Hausmann.
2201
2202         [Qt] http/tests/incremental/slow-utf8-text.pl fails
2203         https://bugs.webkit.org/show_bug.cgi?id=44282
2204
2205         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2206         (WebCore::DumpRenderTree::dump):
2207
2208 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
2209
2210         Reviewed by Mihai Parparita.
2211
2212         Fix a small race condition that could cause the unit tests for
2213         new-run-webkit-tests to fail in a multithreaded environment.
2214         There was a small window in the code where one thread would
2215         check to see if a thread had raised an exception, do something,
2216         and then check to see if the thread was alive. If the other
2217         thread raised an exception and exited in between these two
2218         steps, the exception would be lost. Flipping the order of the
2219         two checks fixes the race, since we will now always check for an
2220         exception on the thread before exiting.
2221
2222         https://bugs.webkit.org/show_bug.cgi?id=51579
2223
2224         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
2225
2226 2011-01-18  Eric Seidel  <eric@webkit.org>
2227
2228         Reviewed by Adam Barth.
2229
2230         commit-queue dies when test archiving fails
2231         https://bugs.webkit.org/show_bug.cgi?id=52617
2232
2233         I looked at the machine and it had 10 archives already
2234         thus find_unused_name was returning None.  I've upped
2235         the limit to 100 (per bug) and tested the case where
2236         find_unused_name returns None (making archive return None).
2237
2238         * Scripts/webkitpy/common/system/workspace.py:
2239         * Scripts/webkitpy/common/system/workspace_unittest.py:
2240         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2241         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2242         * Scripts/webkitpy/tool/commands/queues.py:
2243
2244 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
2245
2246         Reviewed by Ojan Vafai.
2247
2248         Update rebaseline-chromium-webkit-tests unit tests to use a mock
2249         filesystem. Also fix a couple of "with" statements missed by
2250         r76050.
2251
2252         https://bugs.webkit.org/show_bug.cgi?id=52487
2253
2254         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
2255
2256 2011-01-18  Sergio Villar Senin  <svillar@igalia.com>
2257
2258         Reviewed by Martin Robinson.
2259
2260         [Gtk] Build fixes for gtk3 build
2261         https://bugs.webkit.org/show_bug.cgi?id=52648
2262
2263         * DumpRenderTree/gtk/EventSender.cpp:
2264         (beginDragWithFilesCallback):
2265
2266 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
2267
2268         Reviewed by Mihai Parparita.
2269
2270         Update rebaseline-chromium-webkit-tests to use filesystem objects
2271         instead of direct references to os.path, shutil, tempfile, etc.
2272
2273         This patch doesn't change anything, but will allow subsequent
2274         patches to change the unit tests to no longer use the real
2275         filesystem.
2276
2277         This patch adds a bunch more methods to the filesystem object as
2278         well.
2279
2280         https://bugs.webkit.org/show_bug.cgi?id=52482
2281
2282         * Scripts/webkitpy/common/system/filesystem.py:
2283         * Scripts/webkitpy/common/system/filesystem_mock.py:
2284         * Scripts/webkitpy/tool/commands/queues.py:
2285         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2286         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
2287
2288 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
2289
2290         Reviewed by Mihai Parparita.
2291
2292         new-run-webkit-tests shouldn't crash when you try to run a
2293         directory containing only skipped files.
2294
2295         https://bugs.webkit.org/show_bug.cgi?id=52478
2296         
2297         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2298         * Scripts/webkitpy/layout_tests/port/test.py:
2299         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2300
2301 2011-01-18  Adam Bergkvist  <adam.bergkvist@ericsson.com> and Martin Robinson  <mrobinson@igalia.com>
2302
2303         Reviewed by Gustavo Noronha Silva.
2304
2305         [GTK] The GTK+ EventSender needs support for beginDragWithFiles
2306         https://bugs.webkit.org/show_bug.cgi?id=40833
2307
2308         * DumpRenderTree/gtk/EventSender.cpp: Add a beginDragWithFiles implementation for the
2309         GTK+ event sender.
2310         (dragWithFilesDragDataGetCallback): Added.
2311         (dragWithFilesDragEndCallback): Added.
2312         (beginDragWithFilesCallback): Added.
2313
2314 2011-01-18  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2315
2316         Reviewed by Adam Barth.
2317
2318         ews: Add additional watcher to efl ews
2319         https://bugs.webkit.org/show_bug.cgi?id=52613
2320
2321         Add gyuyoung.kim@samsung.com to watcher list of efl-ews.
2322
2323         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2324
2325 2011-01-17  Tony Gentilcore  <tonyg@chromium.org>
2326
2327         Reviewed by Alexey Proskuryakov.
2328
2329         Fix some headers with missing or misspelled #ifndef guards
2330         https://bugs.webkit.org/show_bug.cgi?id=52545
2331
2332         * DumpRenderTree/chromium/TestEventPrinter.h:
2333         * DumpRenderTree/chromium/WebPreferences.h:
2334
2335 2011-01-17  Jessie Berlin  <jberlin@apple.com>
2336
2337         Reviewed by Anders Carlsson.
2338
2339         REGRESSION: Assertion failure in FrameLoader::continueLoadAfterWillSubmitForm() when
2340         navigating back to an unreachable URL
2341         https://bugs.webkit.org/show_bug.cgi?id=52388
2342
2343         Add a third parameter (unreachableURL) to queueLoadHTMLString.
2344
2345         * DumpRenderTree/LayoutTestController.cpp:
2346         (queueLoadHTMLStringCallback):
2347         (LayoutTestController::queueLoadHTMLString):
2348         (LayoutTestController::queueLoadAlternateHTMLString):
2349         * DumpRenderTree/LayoutTestController.h:
2350
2351         * DumpRenderTree/WorkQueueItem.h:
2352         (LoadHTMLStringItem::LoadHTMLStringItem):
2353
2354         * DumpRenderTree/chromium/LayoutTestController.cpp:
2355         (WorkItemLoadHTMLString::WorkItemLoadHTMLString):
2356         (WorkItemLoadHTMLString::run):
2357         (LayoutTestController::queueLoadHTMLString):
2358
2359         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
2360         (LoadHTMLStringItem::invoke):
2361         * DumpRenderTree/mac/WorkQueueItemMac.mm:
2362         (LoadHTMLStringItem::invoke):
2363         * DumpRenderTree/win/WorkQueueItemWin.cpp:
2364         (LoadHTMLStringItem::invoke):
2365
2366 2011-01-17  Dan Bernstein  <mitz@apple.com>
2367
2368         Rubber-stamped by Mark Rowe.
2369
2370         Update xcodeproj svn:ignore to include xcuserdata.
2371
2372         * DumpRenderTree/DumpRenderTree.xcodeproj: Modified property svn:ignore.
2373         * MiniBrowser/MiniBrowser.xcodeproj: Modified property svn:ignore.
2374         * TestWebKitAPI/TestWebKitAPI.xcodeproj: Modified property svn:ignore.
2375         * WebKitLauncher/WebKitLauncher.xcodeproj: Modified property svn:ignore.
2376         * WebKitTestRunner/WebKitTestRunner.xcodeproj: Modified property svn:ignore.
2377
2378 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
2379
2380         Unreviewed fix after r75908.
2381
2382         Move WebKit into Source
2383         https://bugs.webkit.org/show_bug.cgi?id=52530
2384
2385         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add Source to the path for Qt API tests.
2386
2387 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
2388
2389         Unreviewed.
2390
2391         Remove accidentally committed debug printing after r75908.
2392
2393         * Scripts/webkitdirs.pm:
2394
2395 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
2396
2397         Unreviewed.
2398
2399         Add myself to committers list
2400         https://bugs.webkit.org/show_bug.cgi?id=52566
2401
2402         * Scripts/webkitpy/common/config/committers.py:
2403
2404 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
2405
2406         Reviewed by Jeremy Orlow.
2407
2408         GeolocationController should call stopUpdating on destruction
2409         https://bugs.webkit.org/show_bug.cgi?id=52216
2410
2411         fast/dom/Geolocation/window-close-crash.html requires that a
2412         Geolocation watch be started in a secondary window. Consequently,
2413         we need to allow geolocation permission and provide a mock
2414         geolocation position for the secondary window's
2415         GeolocationClientMock.
2416
2417         * DumpRenderTree/chromium/LayoutTestController.cpp:
2418         (LayoutTestController::setGeolocationPermission):
2419         (LayoutTestController::setMockGeolocationPosition):
2420         (LayoutTestController::setMockGeolocationError):
2421         * DumpRenderTree/chromium/TestShell.h:
2422         (TestShell::windowList):
2423
2424 2011-01-16  Adam Barth  <abarth@webkit.org>
2425
2426         Update more include paths to reflect WebKit move.
2427
2428         * DumpRenderTree/chromium/EventSender.cpp:
2429         (EventSender::keyDown):
2430         (EventSender::needsShiftModifier):
2431         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
2432         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
2433
2434 2011-01-16  Kent Tamura  <tkent@chromium.org>
2435
2436         Unreviewed, Chromium build fix.
2437
2438         * Scripts/update-webkit-chromium: Webkit/chromium -> Source/WebKit/chromium
2439
2440 2011-01-16  Martin Robinson  <mrobinson@igalia.com>
2441
2442         Build fix for GTK+ after source directory movement.
2443
2444         * GNUmakefile.am: Correct include paths.
2445
2446 2011-01-16  Adam Barth  <abarth@webkit.org>
2447
2448         Teach svn-apply about WebKit move.
2449
2450         * Scripts/VCSUtils.pm:
2451
2452 2011-01-16  Adam Barth  <abarth@webkit.org>
2453
2454         Rubber-stamped by Eric Seidel.
2455
2456         Move WebKit into Source
2457         https://bugs.webkit.org/show_bug.cgi?id=52530
2458
2459         * DumpRenderTree/mac/InternalHeaders/WebKit/WebTypesInternal.h:
2460         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2461         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2462         * DumpRenderTree/qt/GCControllerQt.cpp:
2463         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2464         * DumpRenderTree/qt/PlainTextControllerQt.cpp:
2465         * DumpRenderTree/qt/TextInputControllerQt.cpp:
2466         * DumpRenderTree/wscript:
2467         * QtTestBrowser/launcherwindow.h:
2468         * Scripts/build-webkit:
2469         * Scripts/webkitdirs.pm:
2470
2471 2011-01-15  Adam Barth  <abarth@webkit.org>
2472
2473         Teach svn-apply about WebKit2 move.
2474
2475         * Scripts/VCSUtils.pm:
2476
2477 2011-01-15  Adam Barth  <abarth@webkit.org>
2478
2479         Rubber-stamped by Eric Seidel.
2480
2481         Move WebKit2 into Source
2482         https://bugs.webkit.org/show_bug.cgi?id=52438
2483
2484         * MiniBrowser/qt/MiniBrowser.pro:
2485         * Scripts/build-webkit:
2486         * Scripts/do-file-rename:
2487         * Scripts/do-webcore-rename:
2488         * Scripts/test-webkitpy:
2489         * Scripts/webkitdirs.pm:
2490         * Scripts/webkitpy/style/checker.py:
2491         * WebKitTestRunner/DerivedSources.pro:
2492         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2493         * WebKitTestRunner/qt/WebKitTestRunner.pro:
2494
2495 2011-01-15  Jochen Eisinger  <jochen@chromium.org>
2496
2497         Reviewed by David Levin.
2498
2499         [chromium] remove obsolete createView method
2500         https://bugs.webkit.org/show_bug.cgi?id=52437
2501
2502         * DumpRenderTree/chromium/WebViewHost.cpp:
2503         (WebViewHost::createView):
2504         * DumpRenderTree/chromium/WebViewHost.h:
2505
2506 2011-01-14  Brian Weinstein  <bweinstein@apple.com>
2507
2508         Reviewed by Geoff Garen.
2509
2510         ShouldLoadResourceForFrame should use strings, not URLs.
2511         https://bugs.webkit.org/show_bug.cgi?id=52476
2512
2513         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2514         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Update to use a WKStringRef.
2515         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2516
2517 2011-01-14  Tony Gentilcore  <tonyg@chromium.org>
2518
2519         Reviewed by David Levin.
2520
2521         Add Tony Gentilcore as a reviewer
2522         https://bugs.webkit.org/show_bug.cgi?id=52480
2523
2524         * Scripts/webkitpy/common/config/committers.py:
2525
2526 2011-01-14  David Levin  <levin@chromium.org>
2527
2528         Reviewed by Eric Seidel.
2529
2530         check-webkit-style: _FunctionState should keep track of where the function name starts.
2531         https://bugs.webkit.org/show_bug.cgi?id=52454
2532
2533         * Scripts/webkitpy/style/checkers/cpp.py: Added function_name_start_position to
2534         _FunctionState and logic for setting it correctly.
2535         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests.
2536
2537 2011-01-14  Vincent Scheib  <scheib@chromium.org>
2538
2539         Reviewed by David Levin.
2540
2541         Add support to DumpRenderTree to use the GPU rather than software renderer
2542         https://bugs.webkit.org/show_bug.cgi?id=52333
2543
2544         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2545         (main):
2546         * Scripts/webkitpy/layout_tests/port/chromium.py:
2547         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2548
2549 2011-01-14  Tony Chang  <tony@chromium.org>
2550
2551         Reviewed by Kent Tamura.
2552
2553         [chromium] update fonts.conf to fix 6 linux tests in drt
2554         https://bugs.webkit.org/show_bug.cgi?id=52411
2555
2556         * DumpRenderTree/chromium/fonts.conf: Update to match the copy in
2557             chromium's src/webkit/tools/test_shell/resources/fonts.conf
2558
2559 2011-01-14  Eric Seidel  <eric@webkit.org>
2560
2561         Original patch from Peter Gal  <galpater@inf.u-szeged.hu>
2562
2563         Reviewed by Adam Barth.
2564
2565         Fix when running Tools/Scripts/check-webkit-style without arguments.
2566         https://bugs.webkit.org/show_bug.cgi?id=52261#c16
2567
2568         * Scripts/webkitpy/common/checkout/scm.py: Handle None for changed_files argument better in Git.create_patch method.
2569         * Scripts/webkitpy/common/checkout/scm_unittest.py:
2570
2571 2011-01-04  Jochen Eisinger  <jochen@chromium.org>
2572
2573         Reviewed by David Levin.
2574
2575         Store the tempdir object in a variable so it doesn't get deleted too early.
2576         https://bugs.webkit.org/show_bug.cgi?id=51875
2577
2578         * Scripts/update-webkit-auxiliary-libs:
2579         * Scripts/update-webkit-support-libs:
2580
2581 2011-01-14  Eric Seidel  <eric@webkit.org>
2582
2583         Unreviewed.  Make it work in python 2.5.
2584
2585         webkit-patch suggest-reviewers dies when ChangeLogs are missing
2586         https://bugs.webkit.org/show_bug.cgi?id=49158
2587
2588         * Scripts/webkitpy/common/checkout/api_unittest.py:
2589
2590 2011-01-14  Sheriff Bot  <webkit.review.bot@gmail.com>
2591
2592         Unreviewed, rolling out r75774.
2593         http://trac.webkit.org/changeset/75774
2594         https://bugs.webkit.org/show_bug.cgi?id=52431
2595
2596         gtk builds were broken (Requested by loislo2 on #webkit).
2597
2598         * Scripts/webkitpy/common/checkout/scm.py:
2599
2600 2011-01-14  David Levin  <levin@chromium.org>
2601
2602         Reviewed by Shinichiro Hamaji.
2603
2604         check-webkit-style: _FunctionState should detect pure functions.
2605         https://bugs.webkit.org/show_bug.cgi?id=52428
2606
2607         * Scripts/webkitpy/style/checkers/cpp.py: Added detection for if a function declaration
2608         is a pure virtual function.
2609         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests for verifying that pure
2610         virtual functions are correctly detected.
2611
2612 2011-01-13  Ilya Tikhonovsky  <loislo@chromium.org>
2613
2614         Reviewed by Yury Semikhatsky.
2615
2616         Just small fix for problem with check-webkit-style.
2617         It just didn't work for this patch.
2618         Old code can't concatenate a list of strings with None.
2619
2620         * Scripts/webkitpy/common/checkout/scm.py:
2621
2622 2011-01-13  David Levin  <levin@chromium.org>
2623
2624         Reviewed by Shinichiro Hamaji.
2625
2626         check-webkit-style: _FunctionState should use Position to know where items are.
2627         https://bugs.webkit.org/show_bug.cgi?id=52424
2628
2629         * Scripts/webkitpy/style/checkers/cpp.py:
2630         (_FunctionState.*): Changed _FunctionState to use Position instead of line numbers.
2631         (detect_functions): Changed to pass Position's to _FunctionState.begin and
2632         did some minor clean-up.
2633         (*): Other changes are simply about converting to use the Position's in_FunctionState
2634         instead of line numbers.
2635         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Changed the test code
2636         to verify the positions stored in _FunctionState.
2637
2638 2011-01-13  Eric Seidel  <eric@webkit.org>
2639
2640         Reviewed by David Levin.
2641
2642         webkit-patch suggest-reviewers dies when ChangeLogs are missing
2643         https://bugs.webkit.org/show_bug.cgi?id=49158
2644
2645         This is not the most elegant, but it is a very safe fix to this bug.
2646         One advantage of catching ScriptError like this instead of adding a
2647         new added_or_modified_files or fixing all changed_files callers
2648         to use a more specific change_files variant, is that we catch
2649         all kinds of ScriptErrors which might cause our (non-essential)
2650         suggest-reviewers code to fail out.  This should make passing
2651         --suggest-reviewers to webkit-patch upload much more robust
2652         and may even make it possible for us to make it default.
2653
2654         The root of the problem here is that SCM.changed_files includes
2655         deleted ChangeLog paths (from moves, etc) which then when we ask
2656         SVN/Git for the contents of the file at that revision, the command
2657         errors out and Executive.run_command raises a ScriptError.
2658
2659         In the future we might fix this differently by making all current
2660         callers of chagned_files use a more specific method for requesting
2661         what types of changes they're interested in (adds, modifies, deletes, etc.)
2662
2663         * Scripts/webkitpy/common/checkout/api.py:
2664         * Scripts/webkitpy/common/checkout/api_unittest.py:
2665
2666 2011-01-13  Dan Bernstein  <mitz@apple.com>
2667
2668         Reviewed by Alexey Proskuryakov.
2669
2670         <rdar://problem/8827065> REGRESSION (r71884): Cross-origin XHR fails if willSendRequest changes the URL
2671         https://bugs.webkit.org/show_bug.cgi?id=52419
2672
2673         Allow to further control the behavior of the willSendRequest delegate callback by making it
2674         set a different URL in the new request.
2675
2676         * DumpRenderTree/LayoutTestController.cpp:
2677         (addURLToRedirectCallback): Added.
2678         (LayoutTestController::staticFunctions): Added addURLToRedirect.
2679         (LayoutTestController::addURLToRedirect): Added. Adds the redirection to the map.
2680         (LayoutTestController::redirectionDestinationForURL): Added this getter.
2681         * DumpRenderTree/LayoutTestController.h:
2682         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2683         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]): Check
2684         if there is a redirection for the request’s URL, established by addURLToRedirect(), and if so,
2685         change the URL in the new request to the redirect destination.
2686
2687 2011-01-13  Eric Seidel  <eric@webkit.org>
2688
2689         Reviewed by Mihai Parparita.
2690
2691         webkit-patch suggest-reviewers fails due to invalid utf8 in ChangeLog files
2692         https://bugs.webkit.org/show_bug.cgi?id=52416
2693
2694         Example: webkit-patch suggest-reviewers -g ca3890fe74d94d85d6bfa48f9ea497b094d8e717 
2695         UnicodeDecodeError: 'utf8' codec can't decode bytes in position 536-538: invalid data
2696
2697         I also added FIXMEs about the changed_files returning deleted files problem
2698         which is causing the other most common exception for suggest-reviewers
2699         (and is probably breaking sheriff-bots blame detection).
2700
2701         * Scripts/webkitpy/common/checkout/api.py:
2702         * Scripts/webkitpy/common/checkout/api_unittest.py:
2703         * Scripts/webkitpy/common/checkout/scm.py:
2704
2705 2011-01-13  Eric Seidel  <eric@webkit.org>
2706
2707         Reviewed by Adam Barth.
2708
2709         results archives from commit-queue are too large to upload
2710         https://bugs.webkit.org/show_bug.cgi?id=52405
2711
2712         * Scripts/webkitpy/common/system/filesystem.py:
2713         * Scripts/webkitpy/common/system/filesystem_mock.py:
2714         * Scripts/webkitpy/tool/commands/queues.py:
2715
2716 2011-01-13  Alejandro G. Castro  <alex@igalia.com>
2717
2718         Reviewed by Martin Robinson.
2719
2720         [gtk] Zero-sized font does not yet work
2721         https://bugs.webkit.org/show_bug.cgi?id=49793
2722
2723         Set minimum-font-size to 0 for the DRT.
2724
2725         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2726         (resetDefaultsToConsistentValues):
2727
2728 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
2729
2730         Reviewed by Darin Adler.
2731
2732         Make old-run-webkit-tests more robust on buildbots
2733         https://bugs.webkit.org/show_bug.cgi?id=52364
2734
2735         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Pass --exit-after-n-failures 500 to old-run-webkit-tests script.
2736
2737 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
2738
2739         Reviewed by Darin Adler.
2740
2741         Make old-run-webkit-tests more robust on buildbots
2742         https://bugs.webkit.org/show_bug.cgi?id=52364
2743
2744         * Scripts/old-run-webkit-tests: Ensure that testResultsDirectory is empty.
2745
2746 2011-01-13  Tony Chang  <tony@chromium.org>
2747
2748         Reviewed by Kent Tamura.
2749
2750         [chromium] fix plugins/plugin-javascript-access.html on Linux and Mac
2751         https://bugs.webkit.org/show_bug.cgi?id=52332
2752
2753         Forked Info.plist is not longer needed.
2754
2755         * DumpRenderTree/chromium/TestNetscapePlugIn/Info.plist: Removed.
2756
2757 2011-01-13  Mikhail Naganov  <mnaganov@chromium.org>
2758
2759         Reviewed by Timothy Hatcher.
2760
2761         Web Inspector: Cleanup after r75613 -- make all UI-facing strings
2762         to be passed directly to WebInspector.UIString
2763
2764         https://bugs.webkit.org/show_bug.cgi?id=52365
2765
2766         * Scripts/check-inspector-strings:
2767
2768 2011-01-13  Sheriff Bot  <webkit.review.bot@gmail.com>
2769
2770         Unreviewed, rolling out r74881.
2771         http://trac.webkit.org/changeset/74881
2772         https://bugs.webkit.org/show_bug.cgi?id=52357
2773
2774         The EFL builder has been red for days (Requested by abarth on
2775         #webkit).
2776
2777         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2778         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2779
2780 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
2781
2782         Reviewed by David Levin.
2783
2784         Add beforeunload support to WebKitTestRunner
2785         https://bugs.webkit.org/show_bug.cgi?id=52353
2786         
2787         This makes a number of currently failing tests pass.
2788
2789         * WebKitTestRunner/TestController.cpp:
2790         (WTR::runBeforeUnloadConfirmPanel):
2791         (WTR::createOtherPage):
2792         (WTR::TestController::initialize):
2793
2794 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
2795
2796         Reviewed by Sam Weinig.
2797
2798         Detect, identify and recover from WebProcess crashes in run-webkit-tests
2799         https://bugs.webkit.org/show_bug.cgi?id=52330
2800
2801         * Scripts/old-run-webkit-tests: Detect when the regression test tool reports
2802         a web process crash.
2803         * WebKitTestRunner/TestController.cpp:
2804         (WTR::TestController::initialize): Set up a processDidCrash
2805         callback.
2806         (WTR::TestController::processDidCrash): Report that the Web process
2807         crashed.
2808         * WebKitTestRunner/TestController.h:
2809
2810 2011-01-12  David Levin  <levin@chromium.org>
2811
2812         Reviewed by Shinichiro Hamaji.
2813
2814         check-webkit-style -- close_expression function doesn't work correctly.
2815         https://bugs.webkit.org/show_bug.cgi?id=52272
2816
2817         * Scripts/webkitpy/style/checkers/cpp.py:
2818         (Position.__str__): Added a way to convert it to a string which is useful in tests.
2819         (Position.__cmp__): Added a way to compare Position which is useful in tests and
2820         generally useful (for upcoming code changes).
2821         (close_expression): Changed to use Position for input and output.
2822         Also, fixed many bugs such as only working correctly for parenthesis,
2823         not working correctly if given an offset in a line and not finding
2824         the real closing element if there were multiple closing elements in
2825         the same line.
2826         (detect_functions): Adjusted due to the change in arguments for
2827         close_expression.
2828         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2829         (CppStyleTestBase.assert_positions_equal): Added a way to verify that
2830         two positions are the same.
2831         (CppStyleTest.test_position): Added tests for the __str_ and __cmp__ methods.
2832         (CppStyleTest.test_close_expression): Added tests to catch the issues
2833         that were fixed.
2834
2835 2011-01-12  Sheriff Bot  <webkit.review.bot@gmail.com>
2836
2837         Unreviewed, rolling out r75576.
2838         http://trac.webkit.org/changeset/75576
2839         https://bugs.webkit.org/show_bug.cgi?id=52304
2840
2841         broke rebaseline-chromium-webkit-test (Requested by thakis on
2842         #webkit).
2843
2844         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2845         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2846         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
2847         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2848         * Scripts/webkitpy/layout_tests/port/base.py:
2849         * Scripts/webkitpy/layout_tests/port/chromium.py:
2850         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2851         * Scripts/webkitpy/layout_tests/port/test.py:
2852         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2853         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2854         * Scripts/webkitpy/style/checkers/test_expectations.py:
2855         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
2856
2857 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
2858
2859         Reviewed by Darin Adler.
2860
2861         Add a no-build option to run-webkit-tests, to avoid building DRT/WKTR
2862         https://bugs.webkit.org/show_bug.cgi?id=52307
2863
2864         * Scripts/old-run-webkit-tests:
2865
2866 2011-01-12  Koan-Sin Tan  <koansin.tan@gmail.com>
2867
2868         Reviewed by Martin Robinson.
2869
2870         [Gtk] WebKitGtk+ doesn't build on Mac OS X 10.6
2871         https://bugs.webkit.org/show_bug.cgi?id=50867
2872
2873         Fixed library extention for Mac in webkitdirs.pm and type conflict in
2874         TestNetscapePlugin.cpp 
2875
2876         * GNUmakefile.am: Don't use AppKit when compiling TestNetscapePlugin for GTK+
2877         * Scripts/webkitdirs.pm:
2878
2879 2011-01-12  Mikhail Naganov  <mnaganov@chromium.org>
2880
2881         Reviewed by Pavel Feldman.
2882
2883         Add check-inspector-strings script.
2884
2885         https://bugs.webkit.org/show_bug.cgi?id=52295
2886
2887         * Scripts/check-inspector-strings: Added.
2888
2889 2011-01-12  Adam Roben  <aroben@apple.com>
2890
2891         Advertise the .testnetscape file extension on Windows
2892
2893         Fixes <http://webkit.org/b/52298>
2894         plugins/no-mime-with-valid-extension.html fails on Windows
2895
2896         Reviewed by Dan Bernstein.
2897
2898         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Added a
2899         FileExtents field to map the .testnetscape file extension to the
2900         application/x-webkit-test-netscape MIME type, just as we do on Mac.
2901
2902 2011-01-12  Adam Barth  <abarth@webkit.org>
2903
2904         Reviewed by Eric Seidel.
2905
2906         Make webkit-patch support subdirectories for SVN checkouts
2907         https://bugs.webkit.org/show_bug.cgi?id=52261
2908
2909         os.relpath does not exist on Python 2.5, so we need to call our version
2910         of the API.
2911
2912         * Scripts/webkitpy/common/checkout/scm.py:
2913
2914 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
2915
2916         Reviewed by Eric Seidel.
2917
2918         Close additional pages opened during a test once the test completes.
2919         https://bugs.webkit.org/show_bug.cgi?id=52276
2920
2921         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2922         (WTR::InjectedBundle::done):
2923
2924 2011-01-11  David Levin  <levin@chromium.org>
2925
2926         Reviewed by Eric Seidel.
2927
2928         Errors should be separated from the command line in bot messages.
2929         https://bugs.webkit.org/show_bug.cgi?id=52275
2930
2931         * Scripts/webkitpy/common/system/executive.py:
2932         (ScriptError.message_with_output): Added a newline to separate the command
2933         line from the errors.
2934         * Scripts/webkitpy/common/system/executive_unittest.py:
2935         (ScriptErrorTest.test_message_with_output): Added tests for the various code
2936         paths in message_with_output.
2937
2938 2011-01-11  Eric Seidel  <eric@webkit.org>
2939
2940         Unreviewed.
2941
2942         commit-queue should know how to upload archived results (for test flakes or general failures)
2943         https://bugs.webkit.org/show_bug.cgi?id=52048
2944
2945         The zips are mostly empty due to forgetting -r.
2946         Expected diffs were not being pulled from the archive due
2947         to the archive having longer paths than I realized.
2948
2949         * Scripts/webkitpy/common/system/workspace.py:
2950         * Scripts/webkitpy/common/system/workspace_unittest.py:
2951         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2952         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2953
2954 2011-01-11  Dirk Pranke  <dpranke@chromium.org>
2955
2956         Reviewed by Ojan Vafai.
2957
2958         The current modifier parsing code in test_expectations is
2959         fragile and hard-coded, so it's not easy to understand the logic
2960         or easily add new types of modifiers (like GPU vs. CPU testing
2961         for graphics tests, or 32-bit vs. 64-bit differences).
2962
2963         This is the first of two patches that will add in more generic
2964         support and then eliminate the GPU-specific test expectations
2965         files for Chromium.
2966
2967         This patch adds two standalone objects for handling modifiers. The
2968         rules for interpreting modifiers, precedence, and conflicts are
2969         given in the docstring to the ModifierMatcher class, which
2970         returns ModifierMatchResult objects.
2971         
2972         This patch also adds routines to the Port interface and a
2973         default set of values in the base object, in order to obtain the
2974         values needed on a given test run. These values are then passed
2975         to the expectation parser. This also allows us to clean up the
2976         logic used to lint all of the different configurations in a
2977         single test_expectations.txt file.
2978
2979         The next patch will merge in the separate GPU expectations file.
2980
2981         https://bugs.webkit.org/show_bug.cgi?id=51222
2982
2983         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2984         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2985         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
2986         * Scripts/webkitpy/layout_tests/port/base.py:
2987         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2988         * Scripts/webkitpy/layout_tests/port/chromium.py:
2989         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2990         * Scripts/webkitpy/layout_tests/port/test.py:
2991         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2992         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2993
2994 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
2995
2996         Reviewed by Adam Barth.
2997
2998         Make webkit-patch support subdirectories for SVN checkouts
2999         https://bugs.webkit.org/show_bug.cgi?id=52261
3000
3001         * Scripts/webkitpy/common/checkout/scm.py:
3002         * Scripts/webkitpy/style_references.py:
3003         * Scripts/webkitpy/tool/main.py:
3004         * Scripts/webkitpy/tool/steps/preparechangelog.py:
3005
3006 2011-01-11  Eric Seidel  <eric@webkit.org>
3007
3008         Unreviewed.
3009
3010         commit-queue should know how to upload archived results (for test flakes or general failures)
3011         https://bugs.webkit.org/show_bug.cgi?id=52048
3012
3013         I changed the API for archive_last_layout_test_results w/o updating the implementation.  Oops.
3014         This fixes an exception seen on the commit-queue when attempting to report flaky tests.
3015
3016         * Scripts/webkitpy/common/system/workspace.py:
3017         * Scripts/webkitpy/common/system/workspace_unittest.py:
3018         * Scripts/webkitpy/tool/commands/queues.py:
3019
3020 2011-01-11  Sam Weinig  <sam@webkit.org>
3021
3022         Roll r75474 back in.
3023
3024 2011-01-11  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
3025
3026         Reviewed by Kenneth Rohde Christiansen.
3027
3028         [Qt] Remove uses of QFuture since it isn't supported on all platforms.
3029         https://bugs.webkit.org/show_bug.cgi?id=51204
3030
3031         * QtTestBrowser/webpage.h:
3032         (QtNAMThread::QtNAMThread):
3033         (QtNAMThread::networkAccessManager):
3034         (QtNAMThread::run):
3035
3036 2011-01-11  Peter Varga  <pvarga@webkit.org>
3037
3038         Unreviewed.
3039
3040         Add myself to committers' list.
3041
3042         * Scripts/webkitpy/common/config/committers.py:
3043
3044 2011-01-11  Eric Seidel  <eric@webkit.org>
3045
3046         Reviewed by Adam Barth.
3047
3048         commit-queue should know how to upload archived results (for test flakes or general failures)
3049         https://bugs.webkit.org/show_bug.cgi?id=52048
3050
3051         Now the queue will always upload results.  Either the entire zip, or just
3052         the diffs.txt in the case of text failures.
3053
3054         This should make understanding flakes much easier, and paves the way
3055         for having the EWS run layout tests (and upload failures).
3056
3057         In order to upload .zip files I had to teach bugzilla.py to autodetect
3058         mime types from the filename.  Since mimetypes.py doesn't include a mapping
3059         for .patch files, I have it add one before calling guess_type.
3060
3061         We may find that always uploading the whole zip instead of just the -diffs.txt
3062         file is preferable, but for now I'm keeping the old behavior because it makes
3063         quickly understanding text failures easy.
3064
3065         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3066         * Scripts/webkitpy/common/system/workspace.py: Added.
3067         * Scripts/webkitpy/common/system/workspace_unittest.py: Added.
3068         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3069         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3070         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3071         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3072         * Scripts/webkitpy/tool/commands/queues.py:
3073         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3074
3075 2011-01-10  Sheriff Bot  <webkit.review.bot@gmail.com>
3076
3077         Unreviewed, rolling out r75464.
3078         http://trac.webkit.org/changeset/75464
3079         https://bugs.webkit.org/show_bug.cgi?id=52193
3080
3081         Followup rollout for 75474 (Requested by Ossy on #webkit).
3082
3083         * MiniBrowser/mac/BrowserWindowController.m:
3084         (-[BrowserWindowController awakeFromNib]):
3085         * MiniBrowser/win/BrowserView.cpp:
3086         (BrowserView::create):
3087         * WebKitTestRunner/TestController.cpp:
3088         (WTR::createOtherPage):
3089         (WTR::TestController::initialize):
3090
3091 2011-01-10  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3092
3093         Reviewed by Csaba Osztrogonác.
3094
3095         [Qt] Baseline qt_minimal configuration
3096         https://bugs.webkit.org/show_bug.cgi?id=51313
3097
3098         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3099         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): Add
3100         QT_NO_UNDOSTACK guard.
3101
3102         * QtTestBrowser/launcherwindow.cpp:
3103         (LauncherWindow::createChrome): Add QT_NO_SHORTCUT and QT_NO_PRINTER
3104         guards.
3105         (LauncherWindow::applyZoom): Add QT_NO_ANIMATION guard.
3106         (LauncherWindow::screenshot): Add QT_NO_FILEDIALOG guard.
3107         (LauncherWindow::selectElements): Add QT_NO_INPUTDIALOG guard.
3108         (LauncherWindow::showUserAgentDialog): Add QT_NO_COMBOBOX guard.
3109
3110         * QtTestBrowser/launcherwindow.h:
3111         * QtTestBrowser/locationedit.cpp: Add QT_NO_INPUTDIALOG guard.
3112         * QtTestBrowser/locationedit.h: Ditto.
3113
3114         * QtTestBrowser/mainwindow.cpp:
3115         (MainWindow::buildUI): Add QT_NO_INPUTDIALOG, QT_NO_SHORTCUT and
3116         QT_NO_UNDOSTACK guards.
3117         (MainWindow::setAddressUrl): Add QT_NO_INPUTDIALOG guard.
3118         (MainWindow::changeLocation): Ditto.
3119         (MainWindow::openFile): Add QT_NO_FILEDIALOG guard.
3120         (MainWindow::openLocation): Add QT_NO_INPUTDIALOG guard.
3121
3122         * QtTestBrowser/webpage.cpp:
3123         (WebPage::openUrlInDefaultBrowser): Add QT_NO_DESKTOPSERVICES guard.
3124         (WebPage::authenticationRequired): Add QT_NO_LINEEDIT guard.
3125
3126         * QtTestBrowser/webview.cpp:
3127         (WebViewGraphicsBased::animatedFlip): Add QT_NO_ANIMATION guard.
3128         (WebViewGraphicsBased::animatedYFlip): Ditto.
3129
3130 2011-01-10  Sam Weinig  <sam@webkit.org>
3131
3132         Fix build.
3133
3134         * MiniBrowser/mac/BrowserWindowController.m:
3135         (-[BrowserWindowController awakeFromNib]):
3136         * MiniBrowser/win/BrowserView.cpp:
3137         (BrowserView::create):
3138         * WebKitTestRunner/TestController.cpp:
3139         (WTR::createOtherPage):
3140         (WTR::TestController::initialize):
3141
3142 2011-01-10  Eric Seidel  <eric@webkit.org>
3143
3144         Reviewed by Ojan Vafai.
3145
3146         style-queue messages are way too long for big patches
3147         https://bugs.webkit.org/show_bug.cgi?id=52161
3148
3149         We definitely could build much fancier list-to-string-with-limit functions
3150         but this should be sufficient for our needs at the moment.
3151
3152         * Scripts/webkitpy/common/system/executive.py:
3153         * Scripts/webkitpy/common/system/executive_unittest.py:
3154
3155 2011-01-10  Tony Chang  <tony@chromium.org>
3156
3157         Unreviewed, rolling out r75398.
3158         http://trac.webkit.org/changeset/75398
3159         https://bugs.webkit.org/show_bug.cgi?id=52008
3160
3161         Some layout tests are crashing on Chromium Win.
3162
3163         * DumpRenderTree/chromium/WebViewHost.cpp:
3164         (WebViewHost::updatePaintRect):
3165         * DumpRenderTree/chromium/WebViewHost.h:
3166
3167 2011-01-10  Adam Roben  <aroben@apple.com>
3168
3169         Roll out r75392
3170
3171         It isn't needed now that r75289 has been rolled out.
3172
3173         * Scripts/run-javascriptcore-tests:
3174
3175 2011-01-10  Maciej Stachowiak  <mjs@apple.com>
3176
3177         Reviewed by Anders Carlsson.
3178
3179         WebKitTestRunner uses crazy amounts of CPU, making layout tests slow and flaky
3180         https://bugs.webkit.org/show_bug.cgi?id=52160
3181
3182         * WebKitTestRunner/mac/TestControllerMac.mm:
3183         (WTR::TestController::platformRunUntil): Instead of busy-looping, wait for the timeout.
3184         Anything that can make runUntil() conditions turn true will happen on a run loop cycle
3185         anyway.
3186
3187 2011-01-10  Tony Chang  <tony@chromium.org>
3188
3189         Reviewed by Mihai Parparita.
3190
3191         [chromium] fix for animated gif layout tests
3192         https://bugs.webkit.org/show_bug.cgi?id=52008
3193
3194         * DumpRenderTree/chromium/WebViewHost.cpp: Schedule a paint when we update the paint rect
3195             to trigger gif animations.
3196         (WebViewHostPaintTask::WebViewHostPaintTask):
3197         (WebViewHostPaintTask::runIfValid):
3198         (WebViewHost::updatePaintRect):
3199         * DumpRenderTree/chromium/WebViewHost.h:
3200         (WebViewHost::taskList):
3201
3202 2011-01-10  Alejandro G. Castro  <alex@igalia.com>
3203
3204         Reviewed by Xan Lopez.
3205
3206         [GTK] Fix gtk2 compilation for master
3207         https://bugs.webkit.org/show_bug.cgi?id=51885
3208
3209         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
3210         (createBitmapContextFromWebView): Replaced the old
3211         gdk_drawable_get_size with gdk_pixmap_get_size.
3212
3213 2011-01-10  Patrick Gansterer  <paroga@webkit.org>
3214
3215         Reviewed by Laszlo Gombos.
3216
3217         [WINCE] Reenable NPAPI after r75203
3218         https://bugs.webkit.org/show_bug.cgi?id=52109
3219
3220         Remove the !isWinCE() check for ENABLE_NETSCAPE_PLUGIN_API and replace
3221         it with !isEfl(), because EFL port does not support NPAPI (yet).
3222
3223         * Scripts/build-webkit:
3224
3225 2011-01-10  Adam Roben  <aroben@apple.com>
3226
3227         Skip some asserting JS tests
3228
3229         See <http://webkit.org/b/52156>.
3230
3231         * Scripts/run-javascriptcore-tests:
3232
3233 2011-01-10  Martin Robinson  <mrobinson@igalia.com>
3234
3235         Reviewed by Xan Lopez.
3236
3237         [GTK] build-webkit disable Blob support via arguments passed to automake
3238         https://bugs.webkit.org/show_bug.cgi?id=52097
3239
3240         * Scripts/build-webkit: Enable Blob support when building WebKitGTK+ via
3241         build-webkit.
3242
3243 2011-01-10  Adam Roben  <aroben@apple.com>
3244
3245         Use the same name and description for TestNetscapePlugin on Windows and
3246         Mac
3247
3248         Fixes <http://webkit.org/b/52151>
3249         fast/frames/iframe-reparenting-plugins.html fails on Windows
3250
3251         Reviewed by Steve Falkenburg.
3252
3253         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Copied
3254         the name and description from Mac's Info.plist.
3255
3256 2011-01-10  Siddharth Mathur <siddharth.mathur@nokia.com>
3257
3258         Reviewed by Laszlo Gombos.
3259
3260         [Qt][WK2] Guard gcc-specific syntax
3261
3262         Non-gcc based compliers choke on the "-include"
3263         syntax for preinclude, place guard around it.
3264
3265         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3266         * WebKitTestRunner/qt/WebKitTestRunner.pro:
3267
3268 2011-01-10  Andreas Kling  <kling@webkit.org>
3269
3270         Reviewed by Simon Hausmann.
3271
3272         [Qt] [WK2] MiniBrowser does not load pages opened in new windows
3273         https://bugs.webkit.org/show_bug.cgi?id=52111
3274
3275         When getting a createNewPage() callback from QWKPage, create the
3276         new page with the same QWKContext as the page that is passed to
3277         the callback.
3278
3279         * MiniBrowser/qt/BrowserView.h:
3280         * MiniBrowser/qt/BrowserWindow.cpp:
3281         (newPageFunction):
3282         (BrowserWindow::BrowserWindow):
3283         * MiniBrowser/qt/BrowserWindow.h:
3284
3285 2011-01-10  Andreas Kling  <kling@webkit.org>
3286
3287         Reviewed by Kenneth Rohde Christiansen.
3288
3289         [Qt] MiniBrowser: Remove superfluous createNewPage() callback
3290
3291         BrowserView set its own useless createNewPage() callback on QWKPage.
3292         This was immediately overridden by BrowserWindow anyway, so remove
3293         the BrowserView one.
3294
3295         * MiniBrowser/qt/BrowserView.cpp:
3296         (BrowserView::BrowserView):
3297
3298 2011-01-10  John Knottenbelt  <jknotten@chromium.org>
3299
3300         Reviewed by Jeremy Orlow.
3301
3302         [Chromium] Remove non-client-based Geolocation code
3303         https://bugs.webkit.org/show_bug.cgi?id=50921
3304
3305         * DumpRenderTree/chromium/LayoutTestController.cpp:
3306         (LayoutTestController::setGeolocationPermission):
3307         (LayoutTestController::setMockGeolocationPosition):
3308         (LayoutTestController::setMockGeolocationError):
3309         * DumpRenderTree/chromium/WebViewHost.cpp:
3310         (WebViewHost::geolocationClientMock):
3311         (WebViewHost::reset):
3312         * DumpRenderTree/chromium/WebViewHost.h:
3313
3314 2011-01-10  Eric Seidel  <eric@webkit.org>
3315
3316         Reviewed by Adam Barth.
3317
3318         Commit bot tried to land r? cq+ patch
3319         https://bugs.webkit.org/show_bug.cgi?id=36638
3320
3321         It should now be possible to post a patch with r? and cq+ and the
3322         commit-queue will correctly wait for the r+ before attempting to land the patch.
3323         (This was a feature requested by several users.)
3324
3325         One caveat: We don't actually reject r-, cq+ patches from the queue
3326         (we just ignore them), but I think that's OK for now.
3327
3328         I also noticed that setting r- once a commit-queue node had grabbed
3329         a patch would not properly cancel the landing.  That's fixed and
3330         tested in this patch.
3331
3332         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3333         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3334         * Scripts/webkitpy/tool/bot/feeders.py:
3335         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
3336
3337 2011-01-08  Benjamin Poulain  <benjamin.poulain@nokia.com>
3338
3339         Reviewed by Kenneth Rohde Christiansen.
3340
3341         [Qt] QtWebKit crashes when using XMLHttpRequest from the unload event
3342         https://bugs.webkit.org/show_bug.cgi?id=51934
3343
3344         When accessing the network from the destructor of QWebPage, the network access manager
3345         was already deleted because the object WebPage was already destructed.
3346
3347         This solve the problem by linking the lifetime of the network access manager to WebPage's QObject.
3348         The object is now destructed in the destructor of QObject.
3349
3350         * QtTestBrowser/webpage.cpp:
3351         (WebPage::WebPage):
3352         (WebPage::setQnamThreaded):
3353         * QtTestBrowser/webpage.h:
3354         (QtNAMThread::QtNAMThread):
3355
3356 2011-01-08  Eric Seidel  <eric@webkit.org>
3357
3358         Reviewed by Ojan Vafai.
3359
3360         test_failures.py should not mention TestShell (long live DumpRenderTree!)
3361         https://bugs.webkit.org/show_bug.cgi?id=52067
3362
3363         I ran test-webkitpy, but didn't bother adding a unit test for this string change.
3364         https://bugs.webkit.org/show_bug.cgi?id=51138#c3 is an example of why this is needed.
3365
3366         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
3367
3368 2011-01-08  Eric Seidel  <eric@webkit.org>
3369
3370         Reviewed by Mihai Parparita.
3371
3372         commit-queue hangs when the ChangeLog diff is bad
3373         https://bugs.webkit.org/show_bug.cgi?id=52072
3374
3375         * Scripts/webkitpy/tool/steps/validatechangelogs.py:
3376         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
3377
3378 2011-01-08  Adam Barth  <abarth@webkit.org>
3379
3380         Teach svn-apply how to re-write WebCore to Source/WebCore.
3381
3382         * Scripts/VCSUtils.pm:
3383
3384 2011-01-07  Adam Barth  <abarth@webkit.org>
3385
3386         Rubber-stamped by Eric Seidel.
3387
3388         Move WebCore to Source
3389         https://bugs.webkit.org/show_bug.cgi?id=52050
3390
3391         Update the tools to understand WebCore's new location.
3392
3393         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3394         * DumpRenderTree/wscript:
3395         * GNUmakefile.am:
3396         * Scripts/build-webkit:
3397         * Scripts/do-file-rename:
3398         * Scripts/do-webcore-rename:
3399         * Scripts/generate-qt-inspector-resource:
3400         * Scripts/prepare-ChangeLog:
3401         * Scripts/run-bindings-tests:
3402         * Scripts/update-iexploder-cssproperties:
3403         * Scripts/update-sources-list.py:
3404         * Scripts/update-webkit-localizable-strings:
3405         * Scripts/webkitdirs.pm:
3406         * Scripts/webkitpy/common/config/build.py:
3407         * Scripts/webkitpy/common/config/build_unittest.py:
3408         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
3409         * Scripts/webkitpy/style/checker.py:
3410         * Scripts/webkitpy/style/checker_unittest.py:
3411         * WebKitTestRunner/DerivedSources.pro:
3412         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3413         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh:
3414         * wx/browser/wscript:
3415         * wx/build/settings.py:
3416
3417 2011-01-07  Maciej Stachowiak  <mjs@apple.com>
3418
3419         Reviewed by Sam Weinig.
3420
3421         Make WebKitTestRunner rest between loads more robust to avoid test crashes
3422         https://bugs.webkit.org/show_bug.cgi?id=52086
3423
3424         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3425         (WTR::InjectedBundle::didReceiveMessage):
3426         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3427         (WTR::LayoutTestController::notifyDone):
3428         * WebKitTestRunner/TestController.cpp:
3429         (WTR::TestController::resetStateToConsistentValues):
3430         (WTR::TestController::run):
3431
3432 2011-01-07  James Robinson  <jamesr@chromium.org>
3433
3434         Revert "Implement mozilla's animationTime property"
3435         https://bugs.webkit.org/show_bug.cgi?id=51952
3436
3437         This approach isn't quite right.
3438
3439         * DumpRenderTree/chromium/WebViewHost.cpp:
3440         (WebViewHost::paintInvalidatedRegion):
3441
3442 2011-01-07  Adam Roben  <aroben@apple.com>
3443
3444         Build master fix
3445
3446         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3447         (RunWebKitTests.start): Don't try to concatenate a list and a string.
3448
3449 2011-01-07  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>
3450
3451         Reviewed by Csaba Osztrogonác.
3452
3453         run-qtwebkit-tests should be able to kill a testsuite.
3454
3455         Add new option in the script that can setup a timeout for a test.
3456         If the test execution takes more then specified time then the test
3457         would be terminated.
3458
3459         [Qt] run-qtwebkit-tests needs timeout
3460         https://bugs.webkit.org/show_bug.cgi?id=51894
3461
3462         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3463         * Scripts/run-qtwebkit-tests:
3464
3465 2011-01-07  Csaba Osztrogonác  <ossy@webkit.org>
3466
3467         Unreviewed fix after r75233.
3468
3469         Based on idea from Eric Seidel.
3470
3471         Add remote zip file handling to webkitpy.
3472         https://bugs.webkit.org/show_bug.cgi?id=50901
3473
3474         * Scripts/webkitpy/common/system/fileset.py: Make python 2.5 happy.
3475
3476 2011-01-07  Shane Stephens  <shanestephens@google.com>
3477
3478         Reviewed by Eric Seidel.
3479
3480         svn-apply: should support git binary delta diffs
3481         https://bugs.webkit.org/show_bug.cgi?id=38864
3482
3483         * Scripts/VCSUtils.pm:
3484         * Scripts/svn-apply:
3485
3486 2011-01-06  Julie Parent  <jparent@chromium.org>
3487
3488         Reviewed by Eric Seidel.
3489
3490         Test Result Server not removing old results.
3491         https://bugs.webkit.org/show_bug.cgi?id=52012
3492
3493         * TestResultServer/model/jsonresults.py:
3494         Fix off-by-one: Truncate if >= num_runs, not just >.
3495         * TestResultServer/model/jsonresults_unittest.py:
3496         Add unit test to test that merging in a new result with the same value
3497         as the last result causes previous result to fall off.
3498
3499 2011-01-06  James Kozianski  <koz@chromium.org>
3500
3501         Reviewed by Mihai Parparita.
3502
3503         Add classes to provide a consistent interface to a set of files.
3504         https://bugs.webkit.org/show_bug.cgi?id=50901
3505
3506         These classes allow us to write code that is agnostic to whether a
3507         particular set of files resides in a local directory or in a zip file
3508         on a remote machine.
3509
3510         * Scripts/webkitpy/common/system/directoryfileset.py: Added.
3511         * Scripts/webkitpy/common/system/directoryfileset_unittest.py: Added.
3512         * Scripts/webkitpy/common/system/fileset.py: Added.
3513         * Scripts/webkitpy/common/system/filesystem.py:
3514         * Scripts/webkitpy/common/system/filesystem_mock.py:
3515         * Scripts/webkitpy/common/system/zipfileset.py: Added.
3516         * Scripts/webkitpy/common/system/zipfileset_unittest.py: Added.
3517
3518 2011-01-06  Eric Seidel  <eric@webkit.org>
3519
3520         Reviewed by Adam Barth.
3521
3522         NetworkTransaction should log the url it is retrying
3523         https://bugs.webkit.org/show_bug.cgi?id=52043
3524
3525         * Scripts/webkitpy/common/net/networktransaction.py:
3526         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
3527
3528 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
3529
3530         Windows build fix.
3531         Import os before using it.
3532
3533         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3534
3535 2011-01-06  Eric Seidel  <eric@webkit.org>
3536
3537         Reviewed by Adam Barth.
3538
3539         StyleQueue fails to report errors when patches have many files
3540         https://bugs.webkit.org/show_bug.cgi?id=52042
3541
3542         This is one of at least two errors preventing style error reporting at the moment.
3543         When we moved to passing the list of files to check explicitly,
3544         we started to exceed the 500 character TEXT field limit for our AppEngine model object.
3545         We could change the type of the QueueStatus.message type, or we could
3546         just teach statusserver.py how to clamp values (and warn when it does).
3547         I chose the latter path.
3548
3549         * Scripts/webkitpy/common/net/statusserver.py:
3550
3551 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
3552
3553         Reviewed by Stephanie Lewis.
3554         
3555         Fix syntax error in script.
3556
3557         Windows bots need to archive/unarchive builds to/from configuration-specific directories
3558         https://bugs.webkit.org/show_bug.cgi?id=51996
3559
3560         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3561
3562 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3563
3564         Unreviewed, fixing WinCE build after r75196.
3565
3566         WinCE port does not (yet) support NPAPI.
3567
3568         * Scripts/build-webkit:
3569
3570 2011-01-06  Xan Lopez  <xlopez@igalia.com>
3571
3572         Reviewed by Darin Adler.
3573
3574         File::Spec->rel2abs in sunspider-compare-results mangles parameters
3575         https://bugs.webkit.org/show_bug.cgi?id=52015
3576
3577         * Scripts/sunspider-compare-results: call rel2abs on our arguments
3578         after the platform has been detected, otherwise the script will
3579         mangle things like '--gtk' into '/a/path/--gtk', breaking the
3580         detection.
3581
3582 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3583
3584         Reviewed by Eric Seidel.
3585
3586         Add ENABLE_NETSCAPE_PLUGIN_API, ENABLE_ORIENTATION_EVENTS and ENABLE_TOUCH_EVENTS flags to build-webkit
3587         https://bugs.webkit.org/show_bug.cgi?id=51346
3588
3589         * Scripts/build-webkit:
3590
3591 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
3592
3593         Reviewed by Adam Roben.
3594
3595         Windows bots need to archive/unarchive builds to/from configuration-specific directories
3596         https://bugs.webkit.org/show_bug.cgi?id=51996
3597         
3598         After the configuration directory change, we were archiving the incorrect directory for
3599         build product, so we were running tests on the wrong binaries.
3600         
3601         This change archives the correct directory, and also unarchives it into a configuration-
3602         specific directory.
3603
3604         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Use a configuration-specific directory on Windows.
3605         * BuildSlaveSupport/built-product-archive: Unarchive/archive to/from proper directory.
3606
3607 2011-01-06  Eric Seidel  <eric@webkit.org>
3608
3609         Reviewed by Mihai Parparita.
3610
3611         commit-queue mentions "Text diff mismatch" 4 times instead of once per failure
3612         https://bugs.webkit.org/show_bug.cgi?id=52002
3613
3614         See an example of this here:
3615         https://bugs.webkit.org/show_bug.cgi?id=51314#c2
3616
3617         It's due to the fact that we pass around TestFailure() instance
3618         objects and yet expect them to all compare to be the same.
3619
3620         This is bad.  We should either have shared instances of these values
3621         or we should just pass around the class names.  There are already hacks
3622         in place to make TestFailure objects pass equality tests, I just added
3623         a __hash__ implementation so they can be used in sets as expected.
3624
3625         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3626         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
3627
3628 2011-01-06  Evan Martin  <evan@chromium.org>
3629
3630         Reviewed by Tony Chang.
3631
3632         [gdb] handle inaccessible memory and UChar*
3633         https://bugs.webkit.org/show_bug.cgi?id=52003
3634
3635         To pretty-print a UChar*, we just grope around in the memory
3636         looking for a terminating NUL.  We need to handle the exception
3637         that can occur when we poke into an invalid location.
3638
3639         Additionally, the logic for choosing which pretty-printer would
3640         early return before hitting the point where we'd use the UChar*
3641         printer.  (Did this ever work?  How did it regress?)
3642
3643         * gdb/webkit.py:
3644
3645 2011-01-05  Brian Weinstein  <bweinstein@apple.com>
3646
3647         Reviewed by Ada Chan.
3648
3649         WebKit2: Should be able to call into injected bundle to ask if we should allow resource loads
3650         https://bugs.webkit.org/show_bug.cgi?id=51969
3651         
3652         Add shouldLoadResourceForFrame to WTR::InjectedBundlePage.
3653
3654         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3655         (WTR::InjectedBundlePage::InjectedBundlePage):
3656         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Stub implementation.
3657         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3658
3659 2011-01-06  James Robinson  <jamesr@chromium.org>
3660
3661         Reviewed by Simon Fraser.
3662
3663         Implement mozilla's animationTime property
3664         https://bugs.webkit.org/show_bug.cgi?id=51952
3665
3666         Chromium DRT support for webkitAnimationTime.
3667
3668         * DumpRenderTree/chromium/WebViewHost.cpp:
3669         (WebViewHost::paintInvalidatedRegion):
3670
3671 2011-01-06  Julie Parent  <jparent@chromium.org>
3672
3673         Reviewed by Tony Chang.
3674
3675         Test Result Server always truncates number of results to JSON_RESULTS_MAX_BUILDS
3676         https://bugs.webkit.org/show_bug.cgi?id=51217
3677
3678         * TestResultServer/model/jsonresults.py:
3679         Pass num_runs through to _remove_items_over_max_number_of_builds, and use the value.
3680         Adds missing documentation.
3681         * TestResultServer/model/jsonresults_unittest.py:
3682         Add unit test to test that truncation happens at smaller value than JSON_RESULTS_MAX_BUILDS.
3683         Update test_merge to take a number of builds to truncate at.
3684
3685 2011-01-06  Adam Barth  <abarth@webkit.org>
3686
3687         Reviewed by Eric Seidel.
3688
3689         The EWS should log outside of the working directory
3690         https://bugs.webkit.org/show_bug.cgi?id=51986
3691
3692         This patch prepare us for using git clean -x -d -f in the EWS wrapper
3693         script, which will actually clean the working copy back to a pristine
3694         state instead of leaving untracked directories and ignored files.
3695
3696         * Scripts/webkitpy/tool/commands/queues.py:
3697         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3698
3699 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
3700
3701         Windows build fix.
3702         Back out attempted change to built-product-archive.
3703
3704         * BuildSlaveSupport/built-product-archive:
3705
3706 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
3707
3708         Windows build fix.
3709         Include configuration name when unpacking a build archive.
3710
3711         Needed, since we split Windows build results into configuration-specific directories
3712         under WebKitOutputDir.
3713
3714         * BuildSlaveSupport/built-product-archive:
3715
3716 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
3717
3718         Reviewed by Darin Adler.
3719
3720         Debug and Release builds on Windows clobber each other
3721         https://bugs.webkit.org/show_bug.cgi?id=49185
3722
3723         Changes the structure of WebKitBuild build products directory so we
3724         completely separate each build configuration into independent directories.
3725         
3726         Although we previously had per-configuration directories for obj, this change adds
3727         per-configuration directories for bin, lib, obj, and include. Each configuration's
3728         build products are stored within a directory inside of WebKitBuild.
3729         
3730         Most use of $(WebKitOutputDir) in the build files has been replaced by $(ConfigurationBuildDir),
3731         defined in common.vsprops to be $(WebKitOutputDir)\$(ConfigurationName).
3732
3733         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops:
3734         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd:
3735         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd:
3736         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
3737         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd:
3738         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd:
3739         * DumpRenderTree/win/ImageDiffCommon.vsprops:
3740         * DumpRenderTree/win/ImageDiffPostBuild.cmd:
3741         * DumpRenderTree/win/ImageDiffPreBuild.cmd:
3742         * FindSafari/FindSafari.vcproj:
3743         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
3744         * MiniBrowser/MiniBrowserPostBuild.cmd:
3745         * MiniBrowser/MiniBrowserPreBuild.cmd:
3746         * Scripts/webkitdirs.pm:
3747         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
3748         * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops:
3749         * TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd:
3750         * TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd:
3751         * TestWebKitAPI/win/copy-resources.cmd:
3752         * WebKitAPITest/WebKitAPITestCommon.vsprops:
3753         * WebKitAPITest/WebKitAPITestPostBuild.cmd:
3754         * WebKitAPITest/WebKitAPITestPreBuild.cmd:
3755         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
3756         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
3757         * WebKitTestRunner/win/InjectedBundle.vcproj:
3758         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops:
3759         * WebKitTestRunner/win/InjectedBundlePostBuild.cmd:
3760         * WebKitTestRunner/win/InjectedBundlePreBuild.cmd:
3761         * WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd:
3762         * WebKitTestRunner/win/WebKitTestRunnerPreBuild.cmd:
3763         * WinLauncher/WinLauncherCommon.vsprops:
3764         * WinLauncher/WinLauncherPostBuild.cmd:
3765         * WinLauncher/WinLauncherPreBuild.cmd:
3766
3767 2011-01-05  Jan Erik Hanssen  <jhanssen@sencha.com>
3768
3769         Reviewed by Ariya Hidayat.
3770
3771         [Qt] TestNetscapePlugin doesn't link on OS X
3772         https://bugs.webkit.org/show_bug.cgi?id=51948
3773
3774         Only add a dependency on libX11 on X11 systems
3775
3776         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3777
3778 2011-01-05  Jeff Miller  <jeffm@apple.com>
3779
3780         Reviewed by Adam Roben.
3781
3782         check-webkit-style should allow unnecessary parameter names in WebKit2 APIs because we're matching CF's header style
3783         https://bugs.webkit.org/show_bug.cgi?id=51970
3784
3785         * Scripts/webkitpy/style/checker.py:
3786         Add -readability/naming for WebKit2 C API directories.
3787
3788 2011-01-05  Eric Seidel  <eric@webkit.org>
3789
3790         Unreviewed, just fixing one more log error from my previous python patch.
3791
3792         Move LayoutTestResults over to ne