Fix for https://bugs.webkit.org/show_bug.cgi?id=57286 Alternative fix for:
[WebKit.git] / Tools / ChangeLog
1 2011-03-28  Tony Chang  <tony@chromium.org>
2
3         Reviewed by Adam Barth.
4
5         [chromium] have DRT write the png checksum into a png comment
6         https://bugs.webkit.org/show_bug.cgi?id=57255
7
8         * DumpRenderTree/chromium/TestShell.cpp:
9         (TestShell::dumpImage):
10
11 2011-03-28  Adele Peterson  <adele@apple.com>
12
13         Removing Qt stub, since it doesn't use the same header as the others.
14
15         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
16
17 2011-03-28  Adele Peterson  <adele@apple.com>
18
19         Added a few more stubs.
20
21         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
22         (LayoutTestController::hasGrammarMarker):
23         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
24         (LayoutTestController::hasGrammarMarker):
25         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
26         (LayoutTestController::hasGrammarMarker):
27
28 2011-03-28  Adele Peterson  <adele@apple.com>
29
30         Build fix.
31
32         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
33         (LayoutTestController::hasGrammarMarker):
34
35 2011-03-28  Adele Peterson  <adele@apple.com>
36
37         Reviewed by Eric Seidel.
38
39         Testing support for <rdar://problem/9112694> REGRESSION (r79411): "Check grammar with spelling" context menu doesn't check as you type
40         https://bugs.webkit.org/show_bug.cgi?id=57173
41
42         * DumpRenderTree/LayoutTestController.cpp:
43         (hasGrammarMarkerCallback): Added.
44         (LayoutTestController::staticFunctions): Added case for hasGrammarMarker.
45         * DumpRenderTree/LayoutTestController.h:
46         * DumpRenderTree/mac/DumpRenderTree.mm: (createWebViewAndOffscreenWindow): Call setGrammarCheckingEnabled.
47         * DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::hasGrammarMarker): Added. Call new hasGrammarMarker method.
48
49 2011-03-28  Csaba Osztrogonác  <ossy@webkit.org>
50
51         Reviewed by Benjamin Poulain.
52
53         [Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
54         https://bugs.webkit.org/show_bug.cgi?id=57087
55
56         Trivial typo fix after r82082.
57
58         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
59         (WTR::activateFonts):
60
61 2011-03-28  Alexis Menard  <alexis.menard@openbossa.org>
62
63         Reviewed by Andreas Kling.
64
65         Add myself to the committers list.
66
67         * Scripts/webkitpy/common/config/committers.py:
68
69 2011-03-28  Simon Fraser  <simon.fraser@apple.com>
70
71         Reviewed by Sam Weinig.
72
73         WebKit2 unfortunately uses code from WebKit, so MiniBrowser needs
74         to link against WebKit.framework for now.
75
76         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
77
78 2011-03-28  Benjamin Poulain  <benjamin.poulain@nokia.com>
79
80         Reviewed by Andreas Kling.
81
82         [Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
83         https://bugs.webkit.org/show_bug.cgi?id=57087
84
85         Disable QT_ASCII_CAST_WARNINGS for applications.
86
87         * DumpRenderTree/qt/DumpRenderTree.pro:
88         * DumpRenderTree/qt/ImageDiff.pro:
89         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
90         * MiniBrowser/qt/MiniBrowser.pro:
91         * QtTestBrowser/QtTestBrowser.pro:
92         * WebKitTestRunner/qt/WebKitTestRunner.pro:
93
94 2011-03-28  Andreas Kling  <kling@webkit.org>
95
96         Reviewed by Kenneth Rohde Christiansen.
97
98         [Qt] QtTestBrowser doesn't reset its window title when opening about:blank
99         https://bugs.webkit.org/show_bug.cgi?id=57224
100
101         * QtTestBrowser/mainwindow.cpp:
102         (MainWindow::buildUI):
103         (MainWindow::onTitleChanged):
104         * QtTestBrowser/mainwindow.h:
105
106 2011-03-27  Jer Noble  <jer.noble@apple.com>
107
108         Reviewed by Maciej Stachowiak.
109
110         Full Screen: disable keyboard access by default
111         https://bugs.webkit.org/show_bug.cgi?id=56684
112
113         Accept the withKeyboard parameter to supportsFullScreenForElement.
114
115         * DumpRenderTree/mac/UIDelegate.mm:
116         (-[UIDelegate webView:supportsFullScreenForElement:withKeyboard:]):
117
118 2011-03-27  Patrick Gansterer  <paroga@webkit.org>
119
120         Reviewed by David Levin.
121
122         check-webkit-style should check ChangeLog for a valid bug number
123         https://bugs.webkit.org/show_bug.cgi?id=57184
124
125         * Scripts/webkitpy/style/checker.py:
126         * Scripts/webkitpy/style/checker_unittest.py:
127         * Scripts/webkitpy/style/checkers/changelog.py: Added.
128         * Scripts/webkitpy/style/checkers/changelog_unittest.py: Added.
129
130 2011-03-27  Benjamin Poulain  <benjamin.poulain@nokia.com>
131
132         Reviewed by Andreas Kling.
133
134         [Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
135         https://bugs.webkit.org/show_bug.cgi?id=57087
136
137         Use explicit conversion for string to avoid depending on the default codec
138         installed by the user code.
139
140         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
141         (WTR::activateFonts):
142
143 2011-03-26  Maciej Stachowiak  <mjs@apple.com>
144
145         Revert inadvertantly committed changes.
146
147         * Scripts/old-run-webkit-tests:
148         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
149
150 2011-03-26  Andreas Kling  <kling@webkit.org>
151
152         Reviewed by Kenneth Rohde Christiansen.
153
154         [Qt] Show page icons (favicons) in QtTestBrowser location bar.
155         https://bugs.webkit.org/show_bug.cgi?id=57162
156
157         * QtTestBrowser/QtTestBrowser.qrc:
158         * QtTestBrowser/favicon.png: Added.
159         * QtTestBrowser/locationedit.cpp:
160         (defaultPageIcon):
161         (LocationEdit::LocationEdit):
162         (LocationEdit::setPageIcon):
163         (LocationEdit::resizeEvent):
164         (LocationEdit::updateInternalGeometry):
165         * QtTestBrowser/locationedit.h:
166         * QtTestBrowser/mainwindow.cpp:
167         (MainWindow::buildUI):
168         (MainWindow::onIconChanged):
169         (MainWindow::onLoadStarted):
170         * QtTestBrowser/mainwindow.h:
171
172 2011-03-23  Martin Robinson  <mrobinson@igalia.com>
173
174         Reviewed by Xan Lopez.
175
176         [GTK] Force DumpRenderTree to use 96 DPI
177         https://bugs.webkit.org/show_bug.cgi?id=56866
178
179         Make sure that GTK+ is set to use 96 DPI when running tests. This ensures
180         broader compatibility with WebKit2 and makes setting font sizes more straightforward.
181
182         * DumpRenderTree/gtk/DumpRenderTree.cpp:
183         (initializeGtkFontSettings): Set the screen resolution and GTK+ xft property to 96 DPI.
184         (resetDefaultsToConsistentValues):Remove the call which repeatedly set the GDK screen resolution.
185         (setDefaultsToConsistentStateValuesForTesting): Update the font sizes to reflect the new DPI.
186
187 2011-03-25  Andy Estes  <aestes@apple.com>
188
189         Reviewed by Adele Peterson.
190
191         REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
192         https://bugs.webkit.org/show_bug.cgi?id=49016
193
194         TestNetscapePlugIn needs to register support for an image MIME type so
195         we can test that the embed tag prefers plug-ins to render image MIME
196         types.
197
198         * DumpRenderTree/TestNetscapePlugIn/mac/Info.plist: Register image/png.
199         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
200         (NP_GetMIMEDescription): Ditto.
201         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Ditto.
202
203 2011-03-25  Jessie Berlin  <jberlin@apple.com>
204
205         Reviewed by Sam Weinig.
206
207         WebKit2: Need to be able to set and get the Cookie Storage Policy.
208         https://bugs.webkit.org/show_bug.cgi?id=50780
209
210         Add a test for getting and setting the HTTP Cookie Accept Policy in WebKit2.
211
212         The test is named "CookieManager" so that we can eventually exercise more of the
213         CookieManager functionality in the test.
214
215         * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp: Added.
216         (TestWebKitAPI::didGetTestHTTPCookieAcceptPolicy):
217         Assert that the policy returned is equal to the policy set in
218         didGetUserHTTPCookieAcceptPolicy, and then restore the user's policy.
219         (TestWebKitAPI::didGetUserHTTPCookieAcceptPolicy):
220         Set the policy to something different than the user's policy and get the policy again.
221         (TestWebKitAPI::didFinishLoadForFrame):
222         Get the user's policy so that it can be restored at the end of the test.
223         (TestWebKitAPI::TEST):
224         Load about:blank so that the Web Process gets instatiated (needed to get the
225         CookieManager).
226
227         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
228         Add CookieManager.cpp.
229
230 2011-03-24  Kevin Ollivier  <kevino@theolliviers.com>
231
232         [wx] Fix the build so that gcc-4.1 and up can be used to build on SnowLeopard.
233
234         * wx/build/settings.py:
235
236 2011-03-24  Ilya Sherman  <isherman@chromium.org>
237
238         Reviewed by Adam Roben.
239
240         Implement layoutTestController.setAutoFilled in DRT on Windows
241         https://bugs.webkit.org/show_bug.cgi?id=56828
242
243         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
244         (LayoutTestController::setAutofilled): Implemented.
245
246 2011-03-24  Brent Fulgham  <bfulgham@webkit.org>
247
248         Unreviewed build correction.
249
250         Correct vsprops file for Debug variant of the CFLite build.
251         Disable a CFNETWORK-specific test when building for CFLite.
252
253         * TestWebKitAPI/Configurations/TestWebKitAPIDebugCairoCFLite.vsprops:
254         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
255
256 2011-03-24  Dirk Pranke  <dpranke@chromium.org>
257
258         Reviewed by Adam Barth.
259
260         fix regressions introduced in 81908 - there were a couple of
261         code paths that only fired under python 2.5 that I missed.
262
263         Also change a couple of 'python' references to sys.executable
264         in order to handle runing test-webkitpy with a binary other than
265         something called 'python'.
266
267         https://bugs.webkit.org/show_bug.cgi?id=57063
268
269         * Scripts/webkitpy/layout_tests/port/mac.py:
270         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
271         * Scripts/webkitpy/test/cat.py:
272         * Scripts/webkitpy/test/echo.py:
273
274 2011-03-24  Brent Fulgham  <bfulgham@webkit.org>
275
276         Unreviewed build correction.
277
278         Add a stub implementation of the TestInvocation dumping logic.
279         Update project files to reflect new file.
280
281         * WebKitTestRunner/cairo: Added.
282         * WebKitTestRunner/cairo/TestInvocationCairo.cpp: Added.
283         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
284         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
285
286 2011-03-24  Dirk Pranke  <dpranke@chromium.org>
287
288         Reviewed by Tony Chang.
289
290         new-run-webkit-tests: clean up worker model defaults. This
291         changes the default behavior to 'threads' instead of
292         'old-threads', and clarifies that chromium-win-* and
293         chromium-mac-leopard are exceptions.
294
295         https://bugs.webkit.org/show_bug.cgi?id=56971
296
297         * Scripts/webkitpy/layout_tests/port/base.py:
298         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
299         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
300         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
301         * Scripts/webkitpy/layout_tests/port/test.py:
302         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
303
304 2011-03-23  Leandro Gracia Gil  <leandrogracia@chromium.org>
305
306         Reviewed by Darin Adler.
307
308         Media Stream API: fix the order of the options in build-webkit.
309         https://bugs.webkit.org/show_bug.cgi?id=56949
310
311         Fix the order of the options in build-webkit.
312
313         * Scripts/build-webkit:
314
315 2011-03-23  Adam Klein  <adamk@chromium.org>
316
317         Reviewed by Mihai Parparita.
318
319         Add an option to new-run-webkit-httpd to allow overriding the location of LayoutTests directory
320         https://bugs.webkit.org/show_bug.cgi?id=56884
321
322         This option will be utilized by Chromium's ui_tests to allow
323         referencing js-test-resources from a layout test over HTTP.
324
325         * Scripts/new-run-webkit-httpd:
326         Added --layout_tests_dir option.
327         * Scripts/webkitpy/layout_tests/port/http_server.py:
328         Plumbed through as layout_tests_dir param.
329
330 2011-03-23  Dirk Pranke  <dpranke@chromium.org>
331
332         Reviewed by Mihai Parparita.
333
334         new-run-webkit-tests: run tests in ascending alphabetical order per
335         dir. This is a second attempt at the fix; the first attempt, in 
336         r81597, broke the behavior on the old-inline and old-threads
337         worker models.
338
339         https://bugs.webkit.org/show_bug.cgi?id=56760
340
341         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
342         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
343         * Scripts/webkitpy/layout_tests/port/test.py:
344         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
345
346 2011-03-23  Mario Sanchez Prada  <msanchez@igalia.com>
347
348         Reviewed by Martin Robinson.
349
350         [GTK] GTK's DRT to ouput detail's string for the 'property-change' signal
351         https://bugs.webkit.org/show_bug.cgi?id=56953
352
353         Print the string for the detail of 'property-change' signal.
354
355         * DumpRenderTree/gtk/AccessibilityCallbacks.cpp:
356         (axObjectEventListener): Print the detail string.
357
358 2011-03-23  Yury Semikhatsky  <yurys@chromium.org>
359
360         Reviewed by Pavel Feldman.
361
362         [V8] Web Inspector: compile DebuggerScript.js into DebuggerScriptSource.h
363         https://bugs.webkit.org/show_bug.cgi?id=56843
364
365         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
366         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
367
368 2011-03-22  Eric Seidel  <eric@webkit.org>
369
370         Reviewed by Adam Barth.
371
372         Teach update-webkit about gyp
373         https://bugs.webkit.org/show_bug.cgi?id=56881
374
375         This makes it possible for someone who builds from Xcode
376         to just run update-webkit --gyp and have the project files
377         generated after update automatically.
378
379         I also added a stand-alone "generate-project-files" script
380         wrapping Source/gyp/configure.  This makes running gyp simpler
381         since most people will not have gyp or Source/gyp in their path.
382
383         * Scripts/build-webkit:
384         * Scripts/generate-project-files: Added.
385         * Scripts/update-webkit:
386
387 2011-03-22  Anton D'Auria  <adauria@apple.com>
388
389         Reviewed by Alexey Proskuryakov.
390
391         Add +[WebApplicationCache getOriginsWithCache]
392         https://bugs.webkit.org/show_bug.cgi?id=56722
393
394         * DumpRenderTree/LayoutTestController.cpp:
395         (originsWithApplicationCacheCallback):
396         (LayoutTestController::staticFunctions):
397         * DumpRenderTree/LayoutTestController.h:
398         * DumpRenderTree/chromium/LayoutTestController.cpp: Added stub.
399         (LayoutTestController::originsWithApplicationCache):
400         * DumpRenderTree/chromium/LayoutTestController.h:
401         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Added stub.
402         (LayoutTestController::originsWithApplicationCache):
403         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Pass array of origin's database identifiers.
404         (originsArrayToJS): Helper function for converting array of WebSecurityOrigins to a JS array of origin identifiers.
405         (LayoutTestController::originsWithApplicationCache):
406         (LayoutTestController::originsWithLocalStorage):
407         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Added stub.
408         (LayoutTestController::originsWithApplicationCache):
409         * DumpRenderTree/qt/LayoutTestControllerQt.h:
410         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Added stub.
411         (LayoutTestController::originsWithApplicationCache):
412         * DumpRenderTree/wx/LayoutTestControllerWx.cpp: Added stub.
413         (LayoutTestController::originsWithApplicationCache):
414
415 2011-03-22  Eric Seidel  <eric@webkit.org>
416
417         Reviewed by Adam Barth.
418
419         Add support to build-webkit for building with gyp-generated project files
420         https://bugs.webkit.org/show_bug.cgi?id=56877
421
422         build-webkit is a cesspool.  This change just hacks in --gyp support for Mac.
423         Eventually we'll want to support gyp-generated projects in a more general manner.
424
425         * Scripts/build-webkit:
426
427 2011-03-22  David Kilzer  <ddkilzer@apple.com>
428
429         <http://webkit.org/b/56781> Add --dsym switch to enable dsym generation when building with Xcode
430
431         Reviewed by Joseph Pecoraro.
432
433         * Scripts/build-webkit: Updated usage statement to include
434         --dsym.
435         * Scripts/webkitdirs.pm: Added $generateDsym variable.
436         (generateDsym): Added. Call determineGenerateDsym() and
437         return $generateDsym.
438         (determineGenerateDsym): Added.  Parse @ARGV for --dsym and set
439         $generateDsym.
440         (argumentsForXcode): Added.  Returns additional arguments for
441         xcodebuild based on command-line switches.
442         (XcodeOptions): Updated to include argumentsForXcode() in the
443         array returned.
444
445 2011-03-22  Adam Roben  <aroben@apple.com>
446
447         Make Leopard Debug bots and Windows XP Debug (Tests) core builders
448
449         These bots are consistently green again.
450
451         Fixes <http://webkit.org/b/56830> Leopard Debug bots and Windows XP Debug (Tests) should be
452         core builders
453
454         Rubber-stamped by Antti Koivisto.
455
456         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
457         (BuildBot.__init__): Loosened the regexps for Leopard and Windows.
458
459         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
460         (BuildBotTest.test_builder_name_regexps): Updated expectations.
461
462 2011-03-21  Sheriff Bot  <webkit.review.bot@gmail.com>
463
464         Unreviewed, rolling out r81597.
465         http://trac.webkit.org/changeset/81597
466         https://bugs.webkit.org/show_bug.cgi?id=56801
467
468         Change results in lots of unexpected flaky on the dashboard.
469         (Requested by pfeldman on #webkit).
470
471         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
472         * Scripts/webkitpy/layout_tests/port/test.py:
473         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
474
475 2011-03-21  Sam Weinig  <sam@webkit.org>
476
477         Fix failing tests on the WebKit2 bots.
478
479         * WebKitTestRunner/TestController.cpp:
480         (WTR::TestController::resetStateToConsistentValues):
481
482 2011-03-21  Daniel Sievers  <sievers@google.com>
483
484         Reviewed by Simon Fraser.
485
486         [Chromium] Make RenderAsTextBehavior and LayerTreeAsTextBehavior tweakable from the DumpRenderTree commandline
487         https://bugs.webkit.org/show_bug.cgi?id=56139
488
489         * DumpRenderTree/chromium/DumpRenderTree.cpp:
490         (main):
491         * DumpRenderTree/chromium/LayoutTestController.cpp:
492         (LayoutTestController::LayoutTestController):
493         (LayoutTestController::layerTreeAsText):
494         * DumpRenderTree/chromium/LayoutTestController.h:
495         (LayoutTestController::setShowDebugLayerTree):
496         * DumpRenderTree/chromium/TestShell.cpp:
497         (TestShell::runFileTest):
498         (TestShell::dump):
499         * DumpRenderTree/chromium/TestShell.h:
500         (TestParams::TestParams):
501
502 2011-03-21  Adam Roben  <aroben@apple.com>
503
504         Try again to get buildbot to show run-javascriptcore-tests's actual.html as an HTML file
505
506         Fixes <http://webkit.org/b/56746> build.webkit.org shows run-javascriptcore-tests's HTML
507         output as plain text
508
509         Reviewed by David Kilzer.
510
511         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
512         (RunJavaScriptCoreTests): List actual.html as one of our log files so it will get uploaded
513         to the master.
514         (RunJavaScriptCoreTests.commandComplete): Reading the actual.html file here won't work,
515         since we're running on the build master, not the slave. Instead, turn the raw source of
516         actual.html which the build slave uploaded into an HTML log.
517
518 2011-03-21  Dirk Pranke  <dpranke@chromium.org>
519
520         Reviewed by Mihai Parparita.
521
522         new-run-webkit-tests: run tests in ascending alphabetical order per dir
523         https://bugs.webkit.org/show_bug.cgi?id=56760
524
525         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
526         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
527         * Scripts/webkitpy/layout_tests/port/test.py:
528
529 2011-03-21  Leandro Gracia Gil  <leandrogracia@chromium.org>
530
531         Reviewed by Steve Block.
532
533         Media Stream API patch 0: adding compilation guards.
534         https://bugs.webkit.org/show_bug.cgi?id=56458
535
536         Adding options to enable the media stream API feature in Chromium.
537
538         * Scripts/build-webkit:
539
540 2011-03-21  Qi Zhang  <qi.2.zhang@nokia.com>
541
542         Reviewed by Laszlo Gombos.
543
544         [Qt] Add a command line option to capture stdout and stderr for DumpRenderTree
545         https://bugs.webkit.org/show_bug.cgi?id=56323
546
547         Using freopen to redirect STDOUT and STDERR when DumpRenderTree command line provide 
548         "--stdout" or "--stderr" option.
549
550         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
551         (WebCore::DumpRenderTree::~DumpRenderTree):
552         (WebCore::DumpRenderTree::processArgsLine):
553         (WebCore::DumpRenderTree::loadNextTestInStandAloneMode):
554         * DumpRenderTree/qt/DumpRenderTreeQt.h:
555         (WebCore::DumpRenderTree::setRedirectOutputFileName):
556         (WebCore::DumpRenderTree::setRedirectErrorFileName):
557         * DumpRenderTree/qt/main.cpp:
558         (isOption):
559         (takeOptionValue):
560         (printUsage):
561         (main):
562
563 2011-03-21  Adam Roben  <aroben@apple.com>
564
565         Fix exceptions on the buildbot due to my last change
566
567         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
568         (RunJavaScriptCoreTests.commandComplete): Catch exceptions due to actual.html not existing.
569
570 2011-03-21  Adam Roben  <aroben@apple.com>
571
572         Teach buildbot to treat run-javascriptcore-tests's actual.html as an HTML file
573
574         Fixes <http://webkit.org/b/56746> build.webkit.org shows run-javascriptcore-tests's HTML
575         output as plain text
576
577         Reviewed by Darin Adler.
578
579         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
580         (RunJavaScriptCoreTests): Removed the logfiles variable, which can only handle plaintext
581         logs.
582         (RunJavaScriptCoreTests.commandComplete): Use the addHTMLLog method to upload actual.html to
583         the build master. This will correctly treat it as HTML.
584
585 2011-03-20  Bill Budge  <bbudge@chromium.org>
586
587         Reviewed by Adam Barth.
588
589         Rename ThreadSafeShared to ThreadSafeRefCounted
590         https://bugs.webkit.org/show_bug.cgi?id=56714
591
592         No new tests. Exposes no new functionality.
593
594         * DumpRenderTree/ForwardingHeaders/wtf/ThreadSafeRefCounted.h: Copied from DumpRenderTree/ForwardingHeaders/wtf/ThreadSafeShared.h.
595         * DumpRenderTree/ForwardingHeaders/wtf/ThreadSafeShared.h: Removed.
596         * Scripts/do-webcore-rename:
597
598 2011-03-19  Anton D'Auria  <adauria@apple.com>
599
600         Reviewed by Dan Bernstein.
601
602         Add stub to LayoutTestControllerGtk.cpp to fix GTK build
603         https://bugs.webkit.org/show_bug.cgi?id=56719
604
605         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Adding stub.
606         (LayoutTestController::clearApplicationCacheForOrigin):
607
608 2011-03-19  Anton D'Auria  <adauria@apple.com>
609
610         Reviewed by Alexey Proskuryakov.
611
612         ApplicationCacheGroup is not obsolete after being deleted via ApplicationCacheStorage::deleteEntriesForOrigin
613         https://bugs.webkit.org/show_bug.cgi?id=56415
614
615         * DumpRenderTree/LayoutTestController.cpp:
616         (clearApplicationCacheForOriginCallback):
617         (LayoutTestController::staticFunctions):
618         * DumpRenderTree/LayoutTestController.h:
619         * DumpRenderTree/chromium/LayoutTestController.cpp: Adding stubs.
620         (LayoutTestController::LayoutTestController):
621         (LayoutTestController::clearAllApplicationCaches):
622         (LayoutTestController::clearApplicationCacheForOrigin): 
623         * DumpRenderTree/chromium/LayoutTestController.h:
624         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Adding stub.
625         (LayoutTestController::clearApplicationCacheForOrigin):
626         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Adding stub.
627         (LayoutTestController::clearApplicationCacheForOrigin):
628         * DumpRenderTree/qt/LayoutTestControllerQt.h:
629         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Adding stub.
630         (LayoutTestController::clearApplicationCacheForOrigin):
631         * DumpRenderTree/wx/LayoutTestControllerWx.cpp: Adding stub.
632         (LayoutTestController::clearApplicationCacheForOrigin):
633
634 2011-03-18  Dan Bernstein  <mitz@apple.com>
635
636         Revised build fix for r81135.
637
638         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
639         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
640
641 2011-03-18  Adam Roben  <aroben@apple.com>
642
643         Windows build fix
644
645         * WebKitTestRunner/config.h: Add a missing #endif.
646
647 2011-03-18  Andreas Kling  <kling@webkit.org>
648
649         Unbreak Qt build after r81494.
650
651         * WebKitTestRunner/qt/TestInvocationQt.cpp:
652         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
653
654 2011-03-18  Sam Weinig  <sam@webkit.org>
655
656         Fix windows build. This was really Adam Roben's fault. I swear!
657
658         * WebKitTestRunner/config.h:
659
660 2011-03-18  Sam Weinig  <sam@webkit.org>
661
662         Reviewed by Adam Roben.
663
664         Pixel tests don't work in WebKitTestRunner on Windows
665         https://bugs.webkit.org/show_bug.cgi?id=56630
666
667         Cross-platformize (Mac and Windows CG) the pixel dumping code in WebKitTestRunner to use WebKit2
668         built-in snapshotting instead of using the window server on the Mac.
669
670         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
671         (WTR::InjectedBundle::InjectedBundle):
672         (WTR::InjectedBundle::didReceiveMessage):
673         (WTR::InjectedBundle::beginTesting):
674         (WTR::InjectedBundle::done):
675         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
676         (WTR::InjectedBundle::setPixelResult):
677         (WTR::InjectedBundle::shouldDumpPixels):
678         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
679         (WTR::InjectedBundlePage::dump):
680         Take the snapshot in the bundle and send it to the UIProcess for dumping.
681
682         * WebKitTestRunner/TestInvocation.cpp:
683         (WTR::TestInvocation::invoke):
684         (WTR::TestInvocation::dump):
685         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
686         * WebKitTestRunner/TestInvocation.h:
687         * WebKitTestRunner/cg: Added.
688         * WebKitTestRunner/cg/TestInvocationCG.cpp: Copied from WebKitTestRunner/mac/TestInvocationMac.mm.
689         (WTR::createCGContextFromImage):
690         (WTR::computeMD5HashStringForContext):
691         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
692         * WebKitTestRunner/mac/TestInvocationMac.mm: Removed.
693         Making pixel dumping code shared for CG ports. Also use the WTF/MD5 instead of platform specific code.
694
695         * WebKitTestRunner/win/TestInvocationWin.cpp:
696         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
697         Keep stub for Cairo build.
698
699         * WebKitTestRunner/Configurations/WebKitTestRunnerCoreGraphics.vsprops: Added.
700         Add CG configuration.
701
702         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
703         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
704         Add new files.
705
706 2011-03-18  Adam Roben  <aroben@apple.com>
707
708         Don't allow Leaks Viewer's vertical scrollbar to cover up long function names
709
710         Rubber-stamped by Simon Fraser.
711
712         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
713         (.data-grid .data-container): Use overflow-y:auto instead of the Inspector's default
714         overflow-y:overlay so that the scrollbar doesn't overlay the content.
715
716 2011-03-18  Adam Roben  <aroben@apple.com>
717
718         Don't ellipsize long or indented function names in Leaks Viewer
719
720         Fixes <http://webkit.org/b/56037> Leaks viewer needs horizontal
721         scrollbar
722
723         Reviewed by Simon Fraser.
724
725         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
726         (.data-grid .data-container):
727         (.data-grid td > div, .data-grid th > div):
728         Allow the contents to extend to the right.
729
730 2011-03-18  Adam Roben  <aroben@apple.com>
731
732         Fix some leaks in DRT seen on the leaks bot
733
734         Fixes <http://webkit.org/b/56638> addURLToRedirectCallback and
735         setWillSendRequestClearHeaderCallback in DRT are leaky
736
737         Reviewed by Alexey Proskuryakov.
738
739         * DumpRenderTree/ForwardingHeaders/wtf/OwnArrayPtr.h: Added.
740
741         * DumpRenderTree/LayoutTestController.cpp:
742         (addURLToRedirectCallback):
743         (setWillSendRequestClearHeaderCallback):
744         Use OwnArrayPtr to cause the strings to be deleted.
745
746 2011-03-18  Adam Roben  <aroben@apple.com>
747
748         Fix a NSURLCredential leak seen on the leaks bot
749
750         Fixes <http://webkit.org/b/56637> -[SynchronousLoader
751         connection:didReceiveAuthenticationChallenge:] is leaky
752
753         Reviewed by John Sullivan.
754
755         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
756         (-[SynchronousLoader connection:didReceiveAuthenticationChallenge:]): Use a RetainPtr to
757         cause the NSURLCredential to be released.
758
759 2011-03-18  John Knottenbelt  <jknotten@chromium.org>
760
761         Unreviewed.
762
763         Remove unnecessary brackets around my email address.
764
765         * Scripts/webkitpy/common/config/committers.py:
766
767 2011-03-18  Adam Roben  <aroben@apple.com>
768         
769         Remove some files I accidentally added in r81454
770
771         * WebKitTestRunner/Configurations/WebKitTestRunnerCoreGraphics.vsprops: Removed.
772         * WebKitTestRunner/cg/TestInvocationCG.cpp: Removed.
773
774 2011-03-18  Adam Roben  <aroben@apple.com>
775
776         Ignore an NSNumberFormatter leak on SnowLeopard
777
778         * Scripts/old-run-webkit-tests:
779         (countAndPrintLeaks): Ignore leaks in -[NSNumberFormatter
780         getObjectValue:forString:errorDescription:].
781
782 2011-03-18  Adam Roben  <aroben@apple.com>
783
784         Fix a leak beneath LayoutTestController::authenticateSession seen on the bots
785
786         Rubber-stamped by Mark Rowe.
787
788         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
789         (LayoutTestController::authenticateSession): Use a RetainPtr to cause the NSURLRequest to be
790         released.
791
792 2011-03-17  Adam Roben  <aroben@apple.com>
793
794         Address a review comment I missed in r81445
795
796         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js:
797         (LeaksParserWorker.prototype._parseLeaks): Anchor the RegExp used to find the number of
798         leaked bytes to speed up searching on long lines.
799
800 2011-03-17  Adam Roben  <aroben@apple.com>
801
802         Mark leaky builds orange, even if all regression tests passed
803
804         Fixes <http://webkit.org/b/56609> SnowLeopard Intel Leaks bot appears green on
805         build.webkit.org when all tests pass even though there are still leaks
806
807         Reviewed by Dan Bernstein.
808
809         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
810         (RunWebKitLeakTests): Set the warnOnWarnings property to True so that the entire build will
811         be marked orange if this build step generates warnings.
812
813 2011-03-17  Adam Roben  <aroben@apple.com>
814
815         Allow values in Leaks Viewer to be shown as percentages
816
817         Double-clicking on a column will toggle between showing percentages and showing real values.
818
819         Fixes <http://webkit.org/b/56628> Would like to view values as percentages of the total
820         number of leaked bytes in Leaks Viewer
821
822         Reviewed by Joe Pecoraro.
823
824         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js:
825         (LeaksParserWorker.prototype._incorporateLeaks): Calculate the (never-shown) top-level
826         node's totalTime, which is used in calculating percentages.
827
828         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js:
829         (monkeyPatchInspectorObjects): Only format values as bytes if we aren't supposed to be
830         showing them as percentages.
831
832 2011-03-17  Adam Roben  <aroben@apple.com>
833
834         Show the number of leaked bytes, not just leaked allocations, in Leaks Viewer
835
836         The Self and Total columns now report the number of leaked bytes. The new Calls column shows
837         the number of leaked allocations. And the new Average column shows the average number of
838         leaked bytes per call.
839
840         Fixes <http://webkit.org/b/56344> Leaks Viewer should show how many bytes were leaked, not
841         just how many allocations
842
843         Reviewed by Joe Pecoraro.
844
845         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js:
846         (LeaksParserWorker.prototype._parseLeaks): Parse the number of leaked bytes from the "Leak:"
847         line and store it with the leak stack.
848         (LeaksParserWorker.prototype._createNode): Initialize the averageTime and numberOfCalls
849         properties.
850         (LeaksParserWorker.prototype._incorporateLeaks): Updated to get the stack from the .stack
851         property, and changed to store the number of leaked bytes in .selfTime/.totalTime.
852         .numberOfCalls now holds the number of leaked allocations.
853
854         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js:
855         (Preferences): Set samplingCPUProfiler to false so that the Average and Calls columns will
856         appear.
857         (monkeyPatchInspectorObjects): Format the values as bytes.
858
859 2011-03-17  Adam Roben  <aroben@apple.com>
860
861         Make Leaks Viewer able to count leaks in builds that didn't fail any regression tests
862
863         Fixes <http://webkit.org/b/56626> Leaks Viewer omits recent builds which didn't fail any
864         regression tests
865
866         Reviewed by James Robinson.
867
868         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
869         (RecentBuildsLoader.prototype.start): Get the number of leaks out of the "text" array, which
870         is always populated, even when all regression tests pass.
871
872 2011-03-10  Hayato Ito  <hayato@chromium.org>
873
874         Reviewed by Tony Chang.
875
876         Add a check logic for reftests in case that a reftest is marked AS REBASELINE.
877
878         https://bugs.webkit.org/show_bug.cgi?id=56076
879
880         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
881
882 2011-03-17  Adam Roben  <aroben@apple.com>
883
884         Skip a compositing-sensitive test when accelerated compositing is disabled
885
886         Reviewed by Sam Weinig.
887
888         * Scripts/old-run-webkit-tests: Skip media/media-document-audio-repaint.html when
889         accelerated compositing is disabled.
890
891 2011-03-17  Adam Roben  <aroben@apple.com>
892
893         Start using PlatformSpecificScheduler for the Mac builders
894
895         The current set of file/directory patterns should work for Mac builders. We may discover
896         that there are more files and directories we can exclude from the Mac builds, but they can
897         be added later.
898
899         Fixes <http://webkit.org/b/56593> Mac builders do lots of unnecessary builds
900
901         Reviewed by Mark Rowe.
902
903         * BuildSlaveSupport/build.webkit.org-config/config.json: Moved the Mac builders into two
904         PlatformSpecificSchedulers: one for Leopard, and one for SnowLeopard.
905
906         * Scripts/webkitpy/common/config/build.py:
907         (_should_file_trigger_build): Allow "mac-leopard" and "mac-snowleopard" platforms, and
908         cleaned up patterns a little bit.
909
910         * Scripts/webkitpy/common/config/build_unittest.py:
911         (ShouldBuildTest): Fixed some expected results.
912         (ShouldBuildTest.test_should_build): Start testing "mac-leopard" and "mac-snowleopard"
913         platforms.
914
915 2011-03-17  Jeff Miller  <jeffm@apple.com>
916
917         Use a consistent set of file patterns in the svn:ignore property for all .xcodeproj directories, specifically:
918         
919         *.mode*
920         *.pbxuser
921         *.perspective*
922         project.xcworkspace
923         xcuserdata
924
925         * DumpRenderTree/DumpRenderTree.xcodeproj: Modified property svn:ignore.
926         * MiniBrowser/MiniBrowser.xcodeproj: Modified property svn:ignore.
927         * TestWebKitAPI/TestWebKitAPI.xcodeproj: Modified property svn:ignore.
928         * WebKitLauncher/WebKitLauncher.xcodeproj: Modified property svn:ignore.
929         * WebKitTestRunner/WebKitTestRunner.xcodeproj: Modified property svn:ignore.
930
931 2011-03-17  Adam Roben  <aroben@apple.com>
932
933         Make old-run-webkit-tests pick up mac-wk2 results when running in WebKit2 mode on Windows
934
935         Fixes <http://webkit.org/b/56563> Running WebKit2 tests on Windows should use results from
936         mac-wk2
937
938         Reviewed by Anders Carlsson.
939
940         * Scripts/old-run-webkit-tests:
941         (expectedDirectoryForTest): Clean up the code to search in extra Mac platform result
942         directories on Windows. Add mac-wk2 to the set of extra platforms we look in on Windows when
943         we're running in WebKit2 mode.
944
945 2011-03-17  Mikhail Naganov  <mnaganov@chromium.org>
946
947         Reviewed by Yury Semikhatsky.
948
949         Web Inspector: Clean up Inspector strings.
950         https://bugs.webkit.org/show_bug.cgi?id=56557
951
952         Modify the script to deal correctly with "\xNN" escapes, and to
953         check strings in Chromium's DevTools.js.
954
955         * Scripts/check-inspector-strings:
956
957 2011-03-17  Keith Kyzivat  <keith.kyzivat@nokia.com>
958
959         Reviewed by Benjamin Poulain.
960
961         Update autoinstall to install mechanize 0.2.4
962         https://bugs.webkit.org/show_bug.cgi?id=56499
963
964         Newer versions of mechanize support HTTPS proxies, which is necessary
965         for people using webkit-patch behind firewalls.
966
967         * Scripts/webkitpy/common/system/autoinstall.py:
968         * Scripts/webkitpy/thirdparty/__init__.py:
969
970 2011-03-16  Sam Weinig  <sam@webkit.org>
971
972         Reviewed by Adam Roben.
973
974         REGRESSION (r81084): media/invalid-media-url-crash.html and editing/execCommand/indent-paragraphs.html failing on WebKit2
975         https://bugs.webkit.org/show_bug.cgi?id=56541
976
977         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
978         (WTR::InjectedBundlePage::willSendRequestForFrame):
979         Check for an empty host in addition to a null host.  This bug was introduced
980         when porting off of the KURL code and onto the WKURLRef version.
981
982 2011-03-16  Sam Weinig  <sam@webkit.org>
983
984         Reviewed by Adam Roben.
985
986         Add Lucas Forschler to the list of WebKit committers.
987
988         * Scripts/webkitpy/common/config/committers.py:
989
990 2011-03-16  Sam Weinig  <sam@webkit.org>
991
992         Reviewed upon and dictated through Adam Roben.
993
994         Escape crashing function names in results.html. This fixes an issue
995         when a crash involves a type with templates.
996
997         * Scripts/old-run-webkit-tests:
998
999 2011-03-16  Daniel Sievers  <sievers@google.com>
1000
1001         Reviewed by James Robinson.
1002
1003         Add setting to always force compositing mode
1004         https://bugs.webkit.org/show_bug.cgi?id=56156
1005
1006         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1007         (main):
1008         * DumpRenderTree/chromium/TestShell.cpp:
1009         (TestShell::TestShell):
1010         (TestShell::resetWebSettings):
1011         * DumpRenderTree/chromium/TestShell.h:
1012         (TestShell::setForceCompositingMode):
1013         * DumpRenderTree/chromium/WebPreferences.cpp:
1014         (WebPreferences::reset):
1015         (WebPreferences::applyTo):
1016         * DumpRenderTree/chromium/WebPreferences.h:
1017
1018 2011-03-15  Hayato Ito  <hayato@chromium.org>
1019
1020         Reviewed by Ojan Vafai.
1021
1022         Ignore files that will be used by reftests in old-run-webkit-tests.
1023
1024         https://bugs.webkit.org/show_bug.cgi?id=55936
1025
1026         * Scripts/old-run-webkit-tests:
1027
1028 2011-03-15  Felipe Oliveira da Silva Netto  <f.dachshund@gmail.com>
1029
1030         Reviewed by Adam Roben.
1031
1032         Function relativeScriptsDir doesn't return the correct relative
1033         Scripts directory.
1034
1035         * Scripts/webkitdirs.pm:
1036         (relativeScriptsDir): Ensure we use the directory that contains
1037         webkitdirs.pm, not the one that contains the original script that
1038         was invoked.
1039
1040 2011-03-15  Kevin Ollivier  <kevino@theolliviers.com>
1041
1042         [wx] Build fixes for long linker commands on Win and method return error, plus a Mac
1043         fix to link against the Security framework after recent WebKitSystemInterface changes.
1044
1045         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1046         (LayoutTestController::originsWithLocalStorage):
1047         * wx/build/settings.py:
1048         * wx/build/waf_extensions.py:
1049
1050 2011-03-15  Sam Weinig  <sam@webkit.org>
1051
1052         Reviewed by Darin Adler.
1053
1054         Add script to convert a patch to a prettypatch and show in the default browser
1055         https://bugs.webkit.org/show_bug.cgi?id=56416
1056
1057         This can be used either like
1058             $ svn-create-patch | show-pretty-diff
1059         or
1060             $ show-pretty-diff patch.diff
1061
1062         * Scripts/show-pretty-diff: Added.
1063
1064 2011-03-15  Brian Weinstein  <bweinstein@apple.com>
1065
1066         Rubber-stamped by Adam Roben.
1067
1068         Adding myself as a reviewer.
1069
1070         * Scripts/webkitpy/common/config/committers.py:
1071
1072 2011-03-15  Anders Carlsson  <andersca@apple.com>
1073
1074         Try to fix the Windows build.
1075
1076         * DumpRenderTree/TestNetscapePlugIn/Tests/NPDeallocateCalledBeforeNPShutdown.cpp:
1077         (NPDeallocateCalledBeforeNPShutdown::TestObject::~TestObject):
1078
1079 2011-03-15  Anders Carlsson  <andersca@apple.com>
1080
1081         Reviewed by Sam Weinig.
1082
1083         Make sure that NP_Shutdown is always the last NPP function called
1084         https://bugs.webkit.org/show_bug.cgi?id=56391
1085
1086         Add a test that times out if an NP_Deallocate object is called after NP_Shutdown.
1087
1088         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1089         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
1090         (PluginTest::PluginTest):
1091         (PluginTest::NP_Shutdown):
1092         (PluginTest::registerNPShutdownFunction):
1093         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
1094         * DumpRenderTree/TestNetscapePlugIn/Tests/NPDeallocateCalledBeforeNPShutdown.cpp: Added.
1095         (NPDeallocateCalledBeforeNPShutdown::NPDeallocateCalledBeforeNPShutdown):
1096         (NPDeallocateCalledBeforeNPShutdown::TestObject::~TestObject):
1097         (NPDeallocateCalledBeforeNPShutdown::ScriptableObject::hasProperty):
1098         (NPDeallocateCalledBeforeNPShutdown::ScriptableObject::getProperty):
1099         (NPDeallocateCalledBeforeNPShutdown::NPP_New):
1100         (NPDeallocateCalledBeforeNPShutdown::NPP_GetValue):
1101         (NPDeallocateCalledBeforeNPShutdown::shutdown):
1102         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1103         (NP_Shutdown):
1104         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1105         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1106         * GNUmakefile.am:
1107
1108 2011-03-15  Ilya Sherman  <isherman@chromium.org>
1109
1110         Reviewed by Tony Chang.
1111
1112         Autofilled form elements are assigned fixed background color but not text color
1113         https://bugs.webkit.org/show_bug.cgi?id=48382
1114
1115         * DumpRenderTree/LayoutTestController.cpp:
1116         (setAutofilledCallback): Added.
1117         (LayoutTestController::staticFunctions):
1118         * DumpRenderTree/LayoutTestController.h:
1119         * DumpRenderTree/chromium/LayoutTestController.cpp:
1120         (LayoutTestController::LayoutTestController):
1121         (LayoutTestController::setAutofilled): Added.
1122         * DumpRenderTree/chromium/LayoutTestController.h:
1123         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1124         (LayoutTestController::setAutofilled): Added.
1125         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1126         (LayoutTestController::setAutofilled): Added.
1127         (LayoutTestController::setValueForUser): Style tweak.
1128         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1129         (LayoutTestController::setAutofilled): Added (stub).
1130         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1131         (LayoutTestController::setAutofilled): Added (stub).
1132
1133 2011-03-15  Dan Bernstein  <mitz@apple.com>
1134
1135         Build fix after r81135.
1136
1137         * TestWebKitAPI/Configurations/InjectedBundle.xcconfig:
1138
1139 2011-03-15  Dan Bernstein  <mitz@apple.com>
1140
1141         Build fix after r81135.
1142
1143         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
1144         * WebKitTestRunner/mac/TestControllerMac.mm:
1145         * WebKitTestRunner/mac/TestInvocationMac.mm:
1146         * WebKitTestRunner/mac/main.mm:
1147
1148 2011-03-15  Balazs Kelemen  <kbalazs@webkit.org>
1149
1150         Reviewed by Adam Barth.
1151
1152         REGRESSION(80977): breaks Qt ARMv7 Linux Release bot
1153         https://bugs.webkit.org/show_bug.cgi?id=56349
1154
1155         * QtTestBrowser/QtTestBrowser.pro: Link against fontconfig
1156         on platforms where we use it. Copied from DumpRenderTree.pro.
1157
1158 2011-03-15  Dan Bernstein  <mitz@apple.com>
1159
1160         Build fix after r81135.
1161
1162         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
1163         * DumpRenderTree/mac/WebArchiveDumpSupportMac.mm:
1164
1165 2011-03-15  Kevin Ollivier  <kevino@theolliviers.com>
1166
1167         Reviewed by Darin Adler.
1168
1169         Introduce WTF_USE_EXPORT_MACROS, which will allow us to put shared library import/export
1170         info into the headers rather than in export symbol definition files, but disable it on 
1171         all platforms initially so we can deal with port build issues one port at a time.
1172         
1173         https://bugs.webkit.org/show_bug.cgi?id=27551
1174
1175         * DumpRenderTree/cg/ImageDiffCG.cpp:
1176         * DumpRenderTree/chromium/config.h:
1177         * DumpRenderTree/config.h:
1178         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1179         * TestWebKitAPI/TestWebKitAPIPrefix.h:
1180         * WebKitAPITest/HostWindow.cpp:
1181         * WebKitAPITest/TestsController.cpp:
1182         * WebKitAPITest/config.h: Added.
1183         * WebKitAPITest/main.cpp:
1184         * WebKitAPITest/tests/WebViewDestruction.cpp:
1185         * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.cpp:
1186         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1187         * WebKitTestRunner/InjectedBundle/GCController.cpp:
1188         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1189         * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp:
1190         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1191         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1192         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
1193         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
1194         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
1195         * WebKitTestRunner/InjectedBundle/win/ActivateFonts.cpp:
1196         * WebKitTestRunner/InjectedBundle/win/InjectedBundleWin.cpp:
1197         * WebKitTestRunner/InjectedBundle/win/LayoutTestControllerWin.cpp:
1198         * WebKitTestRunner/TestController.cpp:
1199         * WebKitTestRunner/TestInvocation.cpp:
1200         * WebKitTestRunner/config.h: Added.
1201         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1202         * WebKitTestRunner/qt/TestControllerQt.cpp:
1203         * WebKitTestRunner/qt/TestInvocationQt.cpp:
1204         * WebKitTestRunner/qt/main.cpp:
1205         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
1206         * WebKitTestRunner/win/TestControllerWin.cpp:
1207         * WebKitTestRunner/win/TestInvocationWin.cpp:
1208         * WebKitTestRunner/win/main.cpp:
1209         * wx/build/settings.py:
1210
1211 2011-03-15  Hayato Ito  <hayato@chromium.org>
1212
1213         Reviewed by Shinichiro Hamaji.
1214
1215         [NRWT] Add support for reftests to new-run-webkit-tests.
1216
1217         https://bugs.webkit.org/show_bug.cgi?id=55457
1218
1219         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
1220         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1221         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
1222         * Scripts/webkitpy/layout_tests/port/base.py:
1223         * Scripts/webkitpy/layout_tests/port/dryrun.py:
1224         * Scripts/webkitpy/layout_tests/port/test.py:
1225         * Scripts/webkitpy/layout_tests/port/test_files.py:
1226         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1227
1228 2011-03-15  Alejandro G. Castro  <alex@igalia.com>
1229
1230         Reviewed by Martin Robinson.
1231
1232         [GTK] Fix compilation warning after r80892
1233         https://bugs.webkit.org/show_bug.cgi?id=56302
1234
1235         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1236         (LayoutTestController::originsWithLocalStorage):
1237
1238 2011-03-15  Robert Hogan  <robert@webkit.org>
1239
1240         Reviewed by Adam Barth.
1241
1242         Document the qmakearg argument, and hint how to build webkit2 on Qt
1243         https://bugs.webkit.org/show_bug.cgi?id=56326
1244
1245         * Scripts/build-webkit: add --qmakearg to build-webkit --help
1246
1247 2011-03-15  Adam Roben  <aroben@apple.com>
1248
1249         Make Windows 7 Release (Tests) a core builder
1250
1251         We can probably make Windows XP Debug (Tests) a core builder, too, but we should probably
1252         give it a few more days of greenness first.
1253
1254         Fixes <http://webkit.org/b/55665> Windows 7 Release (Tests) should be a core builder
1255
1256         Reviewed by Sam Weinig.
1257
1258         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1259         (BuildBot): Added a regexp to match Windows 7 Release (Tests).
1260
1261         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1262         (BuildBotTest): Updated the list of builders to match the current list on build.webkit.org.
1263         Updated the core regexps to match the buildbot module. Updated the expected results to match
1264         the current set of core builders.
1265
1266 2011-03-14  Adam Roben  <aroben@apple.com>
1267
1268         Add forgotten file from r81116
1269
1270         * TestWebKitAPI/Configurations/TestWebKitAPICFNetwork.vsprops: Added.
1271
1272 2011-03-14  Sam Weinig  <sam@webkit.org>
1273
1274         Reviewed by Adam Roben.
1275
1276         about:blank fake responses don't get serialized when sent the UIProcess
1277         <rdar://problem/9108119>
1278         https://bugs.webkit.org/show_bug.cgi?id=56357
1279
1280         * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp: Added.
1281         (TestWebKitAPI::decidePolicyForResponse):
1282         (TestWebKitAPI::TEST):
1283         Add test that loads of about:blank have a response with a MIMEType of text/html.
1284
1285         * TestWebKitAPI/PlatformUtilities.h:
1286         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
1287         (TestWebKitAPI::Util::MIMETypeForWKURLResponse):
1288         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
1289         (TestWebKitAPI::Util::MIMETypeForWKURLResponse):
1290         Add helper to get the MIMEType from a WKURLResponse.
1291
1292         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1293         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1294         Add new files.
1295
1296 2011-03-14  Jarkko Sakkinen  <jarkko.j.sakkinen@gmail.com>
1297
1298         Reviewed by Kenneth Rohde Christiansen.
1299
1300         [Qt] Command-line options for QGLWidget and WebGL to QtTestBrowser
1301         https://bugs.webkit.org/show_bug.cgi?id=56006
1302
1303         * QtTestBrowser/launcherwindow.cpp:
1304         (LauncherWindow::initializeView):
1305         * QtTestBrowser/main.cpp:
1306         (LauncherApplication::handleUserOptions):
1307
1308 2011-03-14  James Kozianski  <koz@chromium.org>
1309
1310         Reviewed by Ojan Vafai.
1311
1312         Add method to make BuildBot return test outputs
1313         https://bugs.webkit.org/show_bug.cgi?id=54374
1314
1315         The Builder.latest_cached_build will be used by the new rebaseline
1316         script to determine the build to use baselines from.
1317
1318         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1319         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1320
1321 2011-03-14  Adam Roben  <aroben@apple.com>
1322
1323         Test that WKBundlePageCanHandleRequest returns true for empty document URLs
1324
1325         Reviewed by Sam Weinig.
1326
1327         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp: Added.
1328         (TestWebKitAPI::didReceiveMessageFromInjectedBundle): Store the result of the test.
1329         (TestWebKitAPI::setInjectedBundleClient): Hook up our callback.
1330         (TestWebKitAPI::TEST): Register "emptyscheme" as an empty document scheme, load a page to
1331         ensure the web process is initialized, then ask the bundle to run the test and assert that
1332         it succeeded.
1333
1334         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest_Bundle.cpp: Added.
1335         (TestWebKitAPI::CanHandleRequestTest::CanHandleRequestTest): Just call up to the base class.
1336         (TestWebKitAPI::canHandleURL): Helper function to test whether WebKit2 claims to be able to
1337         handle a given URL.
1338         (TestWebKitAPI::runTest): Check that empty document URLs can be handled (and that an unknown
1339         URL type cannot be handled).
1340         (TestWebKitAPI::CanHandleRequestTest::didReceiveMessage): Run the test and return the
1341         result.
1342
1343         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1344         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1345         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
1346         Added new files to the project.
1347
1348 2011-03-14  Sheriff Bot  <webkit.review.bot@gmail.com>
1349
1350         Unreviewed, rolling out r81094.
1351         http://trac.webkit.org/changeset/81094
1352         https://bugs.webkit.org/show_bug.cgi?id=56355
1353
1354         Broke the chromium DRT related build. (Requested by dave_levin
1355         on #webkit).
1356
1357         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1358         (main):
1359         * DumpRenderTree/chromium/LayoutTestController.cpp:
1360         (LayoutTestController::LayoutTestController):
1361         (LayoutTestController::layerTreeAsText):
1362         * DumpRenderTree/chromium/LayoutTestController.h:
1363         * DumpRenderTree/chromium/TestShell.cpp:
1364         (TestShell::runFileTest):
1365         (TestShell::dump):
1366         * DumpRenderTree/chromium/TestShell.h:
1367         (TestParams::TestParams):
1368
1369 2011-03-14  Daniel Sievers  <sievers@google.com>
1370
1371         Reviewed by Simon Fraser.
1372
1373         [Chromium] Make RenderAsTextBehavior and LayerTreeAsTextBehavior tweakable from the DumpRenderTree commandline
1374         https://bugs.webkit.org/show_bug.cgi?id=56139
1375
1376         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1377         (main):
1378         * DumpRenderTree/chromium/LayoutTestController.cpp:
1379         (LayoutTestController::LayoutTestController):
1380         (LayoutTestController::layerTreeAsText):
1381         * DumpRenderTree/chromium/LayoutTestController.h:
1382         (LayoutTestController::setShowDebugLayerTree):
1383         * DumpRenderTree/chromium/TestShell.cpp:
1384         (TestShell::runFileTest):
1385         (TestShell::dump):
1386         * DumpRenderTree/chromium/TestShell.h:
1387         (TestParams::TestParams):
1388
1389 2011-03-14  Balazs Kelemen  <kbalazs@webkit.org>
1390
1391         Reviewed by Adam Roben.
1392
1393         [Qt][WK2]Unbreak InjectedBundle on Qt
1394         https://bugs.webkit.org/show_bug.cgi?id=54109
1395
1396         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1397         (WTR::InjectedBundlePage::willSendRequestForFrame): Use new WebKit2
1398         API's instead of KURL to analyze the URL.
1399         * WebKitTestRunner/StringFunctions.h:
1400         (WTR::adoptWK): Moved from InjectedBundlePage.cpp to make it available globally
1401         in the WebKitTestRunner project.
1402         (WTR::toWK): Use adoptWK.
1403         (WTR::operator<<): Added helper for printing a WKURL.
1404         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Do not link
1405         against WebCore.
1406
1407 2011-03-14  Balazs Kelemen  <kbalazs@webkit.org>
1408
1409         Reviewed by Kenneth Rohde Christiansen.
1410
1411         check-webkit-style falsely should not complain about WebKit2 API headers in the Shared directory
1412         https://bugs.webkit.org/show_bug.cgi?id=56321
1413
1414         * Scripts/webkitpy/style/checker.py: Add the patch "Source/WebKit2/Shared/API/c"
1415         to the list of exceptions for WebKit2 C API headers.
1416
1417 2011-03-14  Adam Roben  <aroben@apple.com>
1418
1419         Show the list of recent leaky builds in reverse chronological order
1420
1421         Previously they were being shown in a deterministic but surprising order based on
1422         lexicographically sorting the build offsets (-1, -10, -2, -3...).
1423
1424         Fixes <http://webkit.org/b/56342> Leaks Viewer shows recent builds in a strange order
1425
1426         Reviewed by Darin Adler.
1427
1428         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
1429         (RecentBuildsLoader.prototype.start): Sort the builds by revision before passing them to our
1430         callback.
1431
1432 2011-03-14  Adam Roben  <aroben@apple.com>
1433
1434         Show a list of up to 10 recent leaky builds when Leaks Viewer loads
1435
1436         Fixes <http://webkit.org/b/56043> Leaks Viewer should present a list of recent builds to
1437         analyze
1438
1439         Reviewed by David Kilzer and Joe Pecoraro.
1440
1441         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
1442         (#url-prompt): Made this a bit taller to make room for the list of builds.
1443
1444         (#recent-builds-loading-indicator):
1445         (#recent-builds-list):
1446         Added styles for the build list and loading indicator.
1447
1448         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
1449         (LeaksViewer.loaded): Pass the URL from the query through decodeURIComponent before loading
1450         it. This will unescape it.
1451         (LeaksViewer.urlPromptButtonClicked): Moved code from here to _urlChosenFromPrompt.
1452         (LeaksViewer._didLoadRecentBuilds): Added. Stores the builds and updates the prompt.
1453         (LeaksViewer._displayURLPrompt): Start loading the recent leaky builds.
1454         (LeaksViewer._updateURLPrompt): Create a list of the recent leaky builds and add them to the
1455         prompt UI.
1456         (LeaksViewer._urlChosenFromPrompt): Added. Code came from urlPromptButtonClicked. This is
1457         now also used when a recent build is clicked.
1458
1459         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js: Added.
1460         (RecentBuildsLoader): Store the callback.
1461         (RecentBuildsLoader.prototype.start): Load the N most recent builds from the specified
1462         builder. Find the revision number, leak count, and results URL for each one. Pass the
1463         resulting info to our callback.
1464
1465         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Utilities.js:
1466         (range): Added this helper function to return an array containing the integers [0, n).
1467
1468         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html: Added
1469         RecentBuildsLoader.js and added text to the prompt UI to show the recent builds.
1470
1471 2011-03-14  Mark Rowe  <mrowe@apple.com>
1472
1473         Reviewed by Adam Roben.
1474
1475         Fix two memory leaks within LayoutTestController's storage support.
1476
1477         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1478         (LayoutTestController::originsWithLocalStorage): Don't leak the JSStringRef that is returned
1479         by JSStringCreateWithCFString.
1480         (LayoutTestController::deleteLocalStorageForOrigin): Don't leak the WebSecurityOrigin that we
1481         allocate.
1482
1483 2011-03-14  Mark Rowe  <mrowe@apple.com>
1484
1485         Reviewed by Oliver Hunt.
1486
1487         <http://webkit.org/b/56304> REGRESSION(r80892): 100,000+ leaks seen on the build bot
1488
1489         * DumpRenderTree/LayoutTestController.cpp:
1490         (LayoutTestController::staticFunctions): Remove duplicate entries.
1491
1492 2011-03-14  Alice Liu  <alice.liu@apple.com>
1493
1494         Reviewed by Dan Bernstein.
1495
1496         DumpRenderTree Perl Support fails to build with ARCHS="i386 x86_64"
1497
1498         * DumpRenderTree/mac/PerlSupport/Makefile:
1499         Add whitespace when joining "-arch" with the architectures passed in as arguments.
1500
1501 2011-03-14  Daniel Bates  <dbates@rim.com>
1502
1503         https://bugs.webkit.org/show_bug.cgi?id=55438
1504         Add double quotes around value of -DCMAKE_WINCE_SDK that I inadvertently did not add
1505         when landing changeset 81041 <http://trac.webkit.org/changeset/81041>.
1506
1507         * Scripts/build-webkit:
1508
1509 2011-03-14  Daniel Bates  <dbates@rim.com>
1510
1511         Reviewed by David Kilzer.
1512
1513         Cleanup: Separate port-specific implementation details from webkitdirs::buildCMakeProject()
1514         https://bugs.webkit.org/show_bug.cgi?id=55438
1515
1516         Separate out the EFL- and WinCE-specific logic from the port-independent logic in
1517         webkitdirs::buildCMakeProject(). Also, remove redundant code for generating the
1518         CMake arguments for feature defines.
1519
1520         * Scripts/build-webkit:
1521           - Added cMakeArgsFromFeatures() to convert the @features array to CMake arguments.
1522           - Modified EFL and WinCE-specific building logic to call buildCMakeProjectOrExit().
1523           - Sorted forward declarations.
1524           - Initialize $makeArgs with the empty string so as to simplify its use in string operations;
1525             Modified call sites as needed.
1526         * Scripts/webkitdirs.pm:
1527           - Added cleanCMakeGeneratedProject() to clean a CMake build.
1528           - Added buildCMakeGeneratedProject() to build using generated build system.
1529           - Added buildCMakeProjectOrExit() which is a facade for building a CMake project.
1530           - Added generateBuildSystemFromCMakeProject() to generate the build system from
1531             a CMake project.
1532           - Removed buildCMakeProject(). This functionality is in buildCMakeProjectOrExit().
1533
1534 2011-03-14  John Knottenbelt  <jknotten@chromium.org>
1535
1536         Reviewed by Steve Block.
1537
1538         Detach Geolocation from Frame when Page destroyed.
1539         https://bugs.webkit.org/show_bug.cgi?id=52877
1540
1541         Extend the layout test controller to expose the number of pending
1542         geolocation requests, so that we can test that the requests have
1543         been cancelled on page close.
1544
1545         * DumpRenderTree/LayoutTestController.cpp:
1546         (numberOfPendingGeolocationPermissionRequestsCallback):
1547         (LayoutTestController::staticFunctions):
1548         * DumpRenderTree/LayoutTestController.h:
1549         * DumpRenderTree/chromium/LayoutTestController.cpp:
1550         (LayoutTestController::LayoutTestController):
1551         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
1552         * DumpRenderTree/chromium/LayoutTestController.h:
1553         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1554         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
1555         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1556         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
1557         * DumpRenderTree/mac/UIDelegate.h:
1558         * DumpRenderTree/mac/UIDelegate.mm:
1559         (-[UIDelegate numberOfPendingGeolocationPermissionRequests]):
1560         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1561         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
1562         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1563         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1564         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
1565         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1566         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
1567
1568
1569 2011-03-14  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1570
1571         Unreviewed. Modify my email address in committers.py.
1572
1573         * Scripts/webkitpy/common/config/committers.py:
1574
1575 2011-03-13  Joe Wild  <joseph.wild@nokia.com>
1576
1577         Reviewed by Kenneth Rohde Christiansen.
1578
1579         [Qt] QtLauncher does not load the same set of fonts as the DRT
1580         https://bugs.webkit.org/show_bug.cgi?id=34959
1581
1582         This patch adds the option "-use-test-fonts" to the QtTestBrowser.
1583         When this option is used the webkit fonts are loaded the same
1584         as they are in DumpRenderTree.  This option can be used on
1585         QtTestBrowser and run-launcher.  It can only be used
1586         on Linux systems with FcInit and is configured as such.
1587
1588         * QtTestBrowser/launcherwindow.h:
1589         (WindowOptions::WindowOptions):
1590         * QtTestBrowser/main.cpp:
1591         (initWebKitTestFonts):
1592         (launcherMain):
1593         (LauncherApplication::handleUserOptions):
1594
1595 2011-03-12  Dan Bernstein  <mitz@apple.com>
1596
1597         Reviewed by Mark Rowe.
1598
1599         <rdar://problem/8995822> Build DumpRenderTree perl support only for the architectures
1600         DumpRenderTree is being built for.
1601
1602         * DumpRenderTree/mac/PerlSupport/Makefile:
1603
1604 2011-03-12  Dan Bernstein  <mitz@apple.com>
1605
1606         Suggested by Mark Rowe.
1607
1608         * DumpRenderTree/mac/Configurations/Base.xcconfig: Leave C++ exceptions enabled
1609         as they were before r80915.
1610
1611 2011-03-12  Anders Carlsson  <andersca@apple.com>
1612
1613         Reviewed by Sam Weinig.
1614
1615         Should be able to download a PDF to the Downloads folder
1616         https://bugs.webkit.org/show_bug.cgi?id=56256
1617
1618         * MiniBrowser/mac/BrowserWindowController.m:
1619         (-[BrowserWindowController awakeFromNib]):
1620         * WebKitTestRunner/TestController.cpp:
1621         (WTR::TestController::createOtherPage):
1622         (WTR::TestController::initialize):
1623         Update for API changes.
1624
1625 2011-03-11  Anton D'Auria  <adauria@apple.com>
1626
1627         Reviewed and landed by Brady Eidson.
1628
1629         https://bugs.webkit.org/show_bug.cgi?id=51878
1630         Add WebKit1 API to view and delete local storage
1631
1632         Added tests that write to LocalStorage, delete one origin, get list of origins with local storage, delete all origins.
1633
1634         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1635         * DumpRenderTree/LayoutTestController.cpp:
1636         (syncLocalStorageCallback):
1637         (observeStorageTrackerNotificationsCallback):
1638         (deleteAllLocalStorageCallback):
1639         (deleteLocalStorageForOriginCallback):
1640         (originsWithLocalStorageCallback):
1641         (LayoutTestController::staticFunctions):
1642         * DumpRenderTree/LayoutTestController.h:
1643         * DumpRenderTree/StorageTrackerDelegate.h: Added.
1644         * DumpRenderTree/StorageTrackerDelegate.mm: Added.
1645         (-[StorageTrackerDelegate init]):
1646         (-[StorageTrackerDelegate logNotifications:controller:]):
1647         (-[StorageTrackerDelegate originModified:]):
1648         (-[StorageTrackerDelegate dealloc]):
1649         (-[StorageTrackerDelegate setControllerToNotifyDone:]):
1650         * DumpRenderTree/chromium/LayoutTestController.cpp:
1651         (LayoutTestController::LayoutTestController):
1652         (LayoutTestController::deleteAllLocalStorage):
1653         (LayoutTestController::originsWithLocalStorage):
1654         (LayoutTestController::deleteLocalStorageForOrigin):
1655         (observeStorageTrackerNotifications):
1656         (syncLocalStorage):
1657         * DumpRenderTree/chromium/LayoutTestController.h:
1658         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1659         (LayoutTestController::originsWithLocalStorage):
1660         (LayoutTestController::deleteAllLocalStorage):
1661         (LayoutTestController::deleteLocalStorageForOrigin):
1662         (LayoutTestController::observeStorageTrackerNotifications):
1663         (LayoutTestController::syncLocalStorage):
1664         * DumpRenderTree/mac/DumpRenderTree.mm:
1665         (resetDefaultsToConsistentValues):
1666         (allocateGlobalControllers):
1667         (releaseGlobalControllers):
1668         * DumpRenderTree/mac/DumpRenderTreeMac.h:
1669         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1670         (LayoutTestController::syncLocalStorage):
1671         (LayoutTestController::observeStorageTrackerNotifications):
1672         (LayoutTestController::deleteAllLocalStorage):
1673         (LayoutTestController::originsWithLocalStorage):
1674         (LayoutTestController::deleteLocalStorageForOrigin):
1675         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1676         (LayoutTestController::originsWithLocalStorage):
1677         (LayoutTestController::deleteAllLocalStorage):
1678         (LayoutTestController::deleteLocalStorageForOrigin):
1679         (LayoutTestController::observeStorageTrackerNotifications):
1680         (LayoutTestController::syncLocalStorage):
1681         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1682         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1683         (LayoutTestController::clearAllApplicationCaches):
1684         (LayoutTestController::syncLocalStorage):
1685         (LayoutTestController::observeStorageTrackerNotifications):
1686         (LayoutTestController::clearAllDatabases):
1687         (LayoutTestController::deleteAllLocalStorage):
1688         (LayoutTestController::originsWithLocalStorage):
1689         (LayoutTestController::deleteLocalStorageForOrigin):
1690         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1691         (LayoutTestController::syncLocalStorage):
1692         (LayoutTestController::observeStorageTrackerNotifications):
1693         (LayoutTestController::clearAllDatabases):
1694         (LayoutTestController::deleteAllLocalStorage):
1695         (LayoutTestController::originsWithLocalStorage):
1696         (LayoutTestController::deleteLocalStorageForOrigin):
1697
1698 2011-03-11  Jessie Berlin  <jberlin@apple.com>
1699
1700         Reviewed by Adam Roben.
1701
1702         Crash calling WebContext::clearResourceCaches(InMemoryResourceCachesOnly) before the Web
1703         Process has finished launching.
1704         https://bugs.webkit.org/show_bug.cgi?id=56208
1705
1706         * TestWebKitAPI/Tests/WebKit2/SendingMessagesToTheWebProcessBeforeItIsValid.cpp: Added.
1707         (TestWebKitAPI::TEST):
1708         Test that calling WKContextClearResourceCaches works with both options when called before
1709         the Web Process is valid.
1710
1711         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1712         Add the new test.
1713         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1714         Ditto.
1715
1716 2011-03-11  Adam Roben  <aroben@apple.com>
1717
1718         Make it possible to view all leaks from a build at once in Leaks Viewer
1719
1720         You can now give Leaks Viewer the URL of a build results page (e.g.,
1721         <http://build.webkit.org/results/SnowLeopard%20Intel%20Leaks/r80847%20(15493)/>), and it
1722         will load all the leaks files from that build.
1723
1724         Fixes <http://webkit.org/b/56030> Leaks Viewer: Would like to be able to look at all leaks
1725         files from a particular build at once, rather than one at a time
1726
1727         Reviewed by David Kilzer.
1728
1729         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksLoader.js: Added.
1730         (LeaksLoader): Initialize our properties.
1731         (LeaksLoader.prototype.start): If the URL ends in .txt, assume it's a single leaks file and
1732         load it. Otherwise assume it's a build results page URL and start fetching the leaks files
1733         from that page.
1734         (LeaksLoader.prototype._loadLeaksFiles): Tell our client how many leaks files we're loading
1735         so it can provide feedback. Then load each one and pass it to the client.
1736         (LeaksLoader.prototype._loadLeaksFromResultsPage): Load the HTML of the results page, parse
1737         it into a DOM, pull out all the links to leaks files, and load each one.
1738
1739         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParser.js: Added.
1740         (LeaksParser): Initialize our worker.
1741         (LeaksParser.prototype.addLeaksFile): Tell the worker about the leaks file's contents.
1742
1743         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js: Added.
1744         This code mostly came from Worker.js.
1745         (LeaksParserWorker): Initialize our profile.
1746         (LeaksParserWorker.prototype.addLeaksFile): Parse the leaks file and incorporate it into our
1747         profile.
1748         (LeaksParserWorker.prototype._parseLeaks):
1749         (LeaksParserWorker.prototype._createNode):
1750         (LeaksParserWorker.prototype._incorporateLeaks):
1751         Moved these functions here from LeaksViewer. _incorporateLeaks is essentially just a renamed
1752         version of createProfile which adds to this.profile instead of making a new profile each
1753         time.
1754         (onmessage): Parse the file and send back the new profile.
1755
1756         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
1757         (#loading-indicator):
1758         (#spinner):
1759         (#loading-indicator-label):
1760         Tweaked styles to accomodate a longer label.
1761
1762         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
1763         (LeaksViewer.loaded): Set up a loader and parser.
1764
1765         (LeaksViewer.get filesLeftToParse):
1766         (LeaksViewer.set filesLeftToParse):
1767         Added these simple accessors.
1768
1769         (LeaksViewer._didCountLeaksFiles): Callback from LeaksLoader. Stores the count.
1770         (LeaksViewer._didLoadLeaksFile): Callback from LeaksLoader. Passes the file contents off to
1771         the parser.
1772         (LeaksViewer._didParseLeaksFile): Callback from LeaksParser. If all files have been parsed,
1773         tell the ProfilerAgent and mark that we're done loading. (Code came from the old
1774         _loadLeaksFromURL function).
1775         (LeaksViewer._loadLeaksFromURL): Now just calls through to the loader.
1776         (LeaksViewer._loadingIndicatorText): Added. Returns the text that should show up in the
1777         loading indicator, including the number of files being loaded.
1778         (LeaksViewer._loadingStatusChanged): Update the loading indicator's label, too.
1779         (LeaksViewer._updateLoadingIndicatorLabel): Added. Just updates the label!
1780         (LeaksViewer._updateTitle): Moved code to compute the "Loading" text to
1781         _loadingIndicatorText.
1782
1783         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Utilities.js: Added.
1784         (getResource): Moved here from LeaksViewer.js.
1785
1786         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Worker.js: Subsumed by
1787         LeaksParserWorker.js.
1788
1789         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html: Added new JS
1790         files, added a #loading-indicator-label element, and tweaked the prompt wording.
1791
1792 2011-03-11  Adam Roben  <aroben@apple.com>
1793
1794         Don't trigger a build when build.webkit.org's HTML files are modified
1795
1796         Fixes <http://webkit.org/b/56190> Windows bots shouldn't have built r80848/r80851, but did
1797
1798         Reviewed by Dan Bernstein.
1799
1800         * Scripts/webkitpy/common/config/build.py:
1801         (_should_file_trigger_build): Added build.webkit.org's public_html directory to the list of
1802         directories that shouldn't trigger builds. Re-sorted the list.
1803
1804         * Scripts/webkitpy/common/config/build_unittest.py:
1805         (ShouldBuildTest): Added a test to cover the above change.
1806
1807 2011-03-11  Adam Roben  <aroben@apple.com>
1808
1809         Roll out r80848
1810
1811         It was accidentally committed.
1812
1813         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
1814         (LeaksViewer._loadLeaksFromURL):
1815
1816 2011-03-11  Tony Chang  <tony@chromium.org>
1817
1818         Reviewed by Ojan Vafai.
1819
1820         kill hung lighttpd processes on the chromium win bot
1821         https://bugs.webkit.org/show_bug.cgi?id=56152
1822
1823         Sometimes this process doesn't exit and it holds on to
1824         a log file that we can't delete or copy, causing the tests
1825         to go red.
1826
1827         * BuildSlaveSupport/win/kill-old-processes:
1828
1829 2011-03-11  Ilya Sherman  <isherman@chromium.org>
1830
1831         Reviewed by Kent Tamura.
1832
1833         [Chromium] missing HTMLInputElement::setValueForUser() to tests
1834         https://bugs.webkit.org/show_bug.cgi?id=55854
1835
1836         * DumpRenderTree/chromium/LayoutTestController.cpp:
1837         (LayoutTestController::LayoutTestController):
1838         (LayoutTestController::setValueForUser): Added.
1839         * DumpRenderTree/chromium/LayoutTestController.h:
1840
1841 2011-03-10  Peter Kasting  <pkasting@google.com>
1842
1843         Reviewed by Dimitri Glazkov.
1844
1845         Clean up some gross code in TestShellWin.cpp.  No functional change.
1846         https://bugs.webkit.org/show_bug.cgi?id=56048
1847
1848         * DumpRenderTree/chromium/TestShellWin.cpp:
1849         (checkLayoutTestSystemDependencies):
1850
1851 2011-03-10  Keith Kyzivat  <keith.kyzivat@nokia.com>
1852
1853         Reviewed by Laszlo Gombos.
1854
1855         [Qt] Buildfix for platforms where X11 is not available (e.g. Symbian)
1856
1857         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
1858         (WTR::activateFonts): Guard X11-specific code with Q_WS_X11.
1859
1860 2011-03-10  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1861
1862         Reviewed by Kenneth Rohde Christiansen.
1863
1864         [EFL] Make single backing store the default for EWebLauncher
1865         https://bugs.webkit.org/show_bug.cgi?id=55753
1866
1867         Set single backing store the default for EWebLauncher.
1868
1869         * EWebLauncher/main.c:
1870         (main):
1871
1872 2011-03-10  Adam Roben  <aroben@apple.com>
1873
1874         Ignore errors from files being held open when creating a test result archive
1875
1876         Fixes <http://webkit.org/b/55581> Test results don't get uploaded if test-result-archive
1877         fails to delete the results directory
1878
1879         Reviewed by Mark Rowe.
1880
1881         * BuildSlaveSupport/test-result-archive:
1882         (archiveTestResults): Ignore errno 2 when deleting the results directory, since it can be
1883         thrown when a process is holding a file open.
1884
1885 2011-03-10  Sheriff Bot  <webkit.review.bot@gmail.com>
1886
1887         Unreviewed, rolling out r80701.
1888         http://trac.webkit.org/changeset/80701
1889         https://bugs.webkit.org/show_bug.cgi?id=56126
1890
1891         fast/dom/Geolocation/window-close-crash.html fails on Snow
1892         Leopard release builds (Requested by mihaip on #webkit).
1893
1894         * DumpRenderTree/LayoutTestController.cpp:
1895         (LayoutTestController::staticFunctions):
1896         * DumpRenderTree/LayoutTestController.h:
1897         * DumpRenderTree/chromium/LayoutTestController.cpp:
1898         (LayoutTestController::LayoutTestController):
1899         * DumpRenderTree/chromium/LayoutTestController.h:
1900         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1901         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1902         * DumpRenderTree/mac/UIDelegate.h:
1903         * DumpRenderTree/mac/UIDelegate.mm:
1904         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1905         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1906         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1907         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1908
1909 2011-03-10  Philippe Normand  <pnormand@igalia.com>
1910
1911         Reviewed by Gustavo Noronha Silva.
1912
1913         [GTK] run-gtk-tests doesn't fail if a test crashes
1914         https://bugs.webkit.org/show_bug.cgi?id=56089
1915
1916         * Scripts/run-gtk-tests: gtester -k exits with a 0 exit status
1917         even if a test crashes. So run the tests individually and if a
1918         test fails remember its exit code so run-gtk-test fails too, if
1919         required.
1920
1921 2011-01-26  John Knottenbelt  <jknotten@chromium.org>
1922
1923         Reviewed by Dmitry Titov.
1924
1925         Detach Geolocation from Frame when Page destroyed.
1926         https://bugs.webkit.org/show_bug.cgi?id=52877
1927
1928         Extend the layout test controller to expose the number of pending
1929         geolocation requests, so that we can test that the requests have
1930         been cancelled on page close.
1931
1932         * DumpRenderTree/LayoutTestController.cpp:
1933         (numberOfPendingGeolocationPermissionRequestsCallback):
1934         (LayoutTestController::staticFunctions):
1935         * DumpRenderTree/LayoutTestController.h:
1936         * DumpRenderTree/chromium/LayoutTestController.cpp:
1937         (LayoutTestController::LayoutTestController):
1938         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
1939         * DumpRenderTree/chromium/LayoutTestController.h:
1940         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1941         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
1942         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1943         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
1944         * DumpRenderTree/mac/UIDelegate.h:
1945         * DumpRenderTree/mac/UIDelegate.mm:
1946         (-[UIDelegate numberOfPendingGeolocationPermissionRequests]):
1947         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1948         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
1949         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1950         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1951         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
1952         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1953         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
1954
1955
1956 2011-03-09  Adam Roben  <aroben@apple.com>
1957
1958         Hide Leaks Viewer's URL prompt by default
1959
1960         We will show it as needed. I think I left it visible by default by accident after doing some
1961         testing.
1962
1963         Fixes <http://webkit.org/b/56031> Leaks Viewer: URL prompt overlay shouldn't appear when a
1964         URL is passed as a query parameter, but does
1965
1966         Reviewed by Simon Fraser.
1967
1968         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html:
1969
1970 2011-03-09  Adam Roben  <aroben@apple.com>
1971
1972         Don't use Element.classList or box-shadow in Leaks Viewer
1973
1974         They aren't supported by Safari 5. Luckily we have substitutes for them!
1975
1976         Fixes <http://webkit.org/b/56035> Leaks viewer doesn't work in Safari 5
1977
1978         Reviewed by Simon Fraser.
1979
1980         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
1981         (#url-prompt): Use -webkit-box-shadow instead of box-shadow.
1982
1983         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
1984         (LeaksViewer.urlPromptButtonClicked):
1985         (LeaksViewer._displayURLPrompt):
1986         (LeaksViewer._setLoadingIndicatorHidden):
1987         Use add/removeStyleClass (from utilities.js) instead of Element.classList.
1988
1989 2011-03-09  Adam Roben  <aroben@apple.com>
1990
1991         Add a link to the Leaks Viewer tool on the build.webkit.org homepage
1992
1993         Rubber-stamped by David Kilzer.
1994
1995         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
1996
1997 2011-03-09  Adam Roben  <aroben@apple.com>
1998
1999         Add a Leaks Viewer tool to build.webkit.org
2000
2001         This tool parses leaks from the files generated by the leaks bot and displays them in a
2002         view similar to the Web Inspector's Profiles pane (in fact, it uses the Web Inspector's
2003         code).
2004
2005         The URL of the leaks file can be entered in a prompt when the tools is first shown, or can
2006         be passed to the tool via the "url" query parameter.
2007
2008         Only one leaks file can be viewed at a time for now. Only the number of leaks, as opposed to
2009         the number of leaked bytes, is shown. And this tool has made apparent some bugs in the Web
2010         Inspector's Heavy profile view. But it's still pretty useful as-is.
2011
2012         Fixes <http://webkit.org/b/56028> Would like a Shark-like tool for viewing leaks from leak bots
2013
2014         Reviewed by Darin Adler.
2015
2016         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css: Added.
2017         (#url-prompt-container): This is the dark overlay that is shown behind the URL prompt.
2018         (#url-prompt): This is the prompt itself.
2019
2020         (#loading-indicator):
2021         (#loading-indicator > img):
2022         These show a spinner in the bottom-right when we're loading a leaks file.
2023
2024         (.percent-time-status-bar-item): Hide the Percent button since we never want to show leaks
2025         as percentages.
2026
2027         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js: Added.
2028         (LeaksViewer.loaded): Initialize ourselves and start loading the leaks file (or prompt for a
2029         URL if one wasn't given to us as a query parameter).
2030
2031         (LeaksViewer.get loading):
2032         (LeaksViewer.set loading):
2033         (LeaksViewer.get url):
2034         (LeaksViewer.set url):
2035         Pretty simple accessors.
2036
2037         (LeaksViewer.urlPromptButtonClicked): Start loading the URL from the prompt and hide the
2038         prompt.
2039         (LeaksViewer._displayURLPrompt): Show the prompt and focus the URL input.
2040         (LeaksViewer._loadLeaksFromURL): Start fetching the leaks file. When we've retrieved the
2041         file, hand it off to a Web Worker that will parse it into a fake "profile", then hand off
2042         the profile to the Web Inspector code once it's been created.
2043         (LeaksViewer._loadingStatusChanged): Update our loading indicator and title.
2044         (LeaksViewer._setLoadingIndicatorHidden): Simply hide or show the indicator.
2045         (LeaksViewer._updateTitle): Set our title based on our URL and loading status.
2046         (getResource): Helper function to fetch a resource via XHR and pass it to a callback.
2047
2048         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js: Added.
2049         (WebInspector.UIString): Just a simple implementation since this tool isn't localized.
2050         (ProfilerAgent.getProfile): Store the callback.
2051         (ProfilerAgent.profileReady): Call the callback.
2052         (monkeyPatchInspectorObjects): Fix up WebInspector.ProfileDataGridNode to show the self leak
2053         count and total leak counts as real values, not percentages or milliseconds.
2054
2055         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Worker.js: Added.
2056         (onmessage): Create a profile based on the leaks file and pass it back to our caller.
2057         (parseLeaks): Extract call stacks out of a leaks file.
2058         (createNode): Helper function to create a new empty profile node.
2059         (createProfile): Take the leak stacks and turn them into a fake "profile" for consumption by
2060         WebInspector.ProfileView.
2061
2062         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html: Added.
2063
2064 2011-03-09  Dan Bernstein  <mitz@apple.com>
2065
2066         Reviewed by Adam Roben.
2067
2068         Combine multiple --ignore-tests values
2069         https://bugs.webkit.org/show_bug.cgi?id=56016
2070
2071         * Scripts/old-run-webkit-tests:
2072
2073 2011-03-08  Kenji Imasaki  <imasaki@chromium.org>
2074
2075         Reviewed by David Levin.
2076
2077         Adding myself to the committer file.
2078
2079         * Scripts/webkitpy/common/config/committers.py:
2080
2081 2011-03-08  Jessie Berlin  <jberlin@apple.com>
2082
2083         Rubber-stamped by Adam Roben.
2084
2085         Fix two leaks I introduced into the API tests.
2086
2087         * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp:
2088         (TestWebKitAPI::TEST):
2089
2090 2011-03-08  Jessie Berlin  <jberlin@apple.com>
2091
2092         Reviewed by Anders Carlsson.
2093
2094         Crash in CFNetwork visiting google.com
2095         https://bugs.webkit.org/show_bug.cgi?id=55958
2096
2097         Add a test for not trying to copy a null CFURLResponse.
2098
2099         * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp: Added.
2100         (TestWebKitAPI::TEST):
2101         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2102
2103 2011-03-08  Hayato Ito  <hayato@chromium.org>
2104
2105         Reviewed by Ojan Vafai.
2106
2107         [NRWT] Renamed a FailureWithType class to a ComparisonTestFailure class.
2108
2109         FailureWithType is a confusing naming because we have removed test_type/* classes in r79840.
2110
2111         https://bugs.webkit.org/show_bug.cgi?id=55450
2112
2113         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
2114
2115 2011-03-08  Carlos Garcia Campos  <cgarcia@igalia.com>
2116
2117         Reviewed by Martin Robinson.
2118
2119         [GTK] Add layoutTestController.setValueForUser() after r80412
2120         https://bugs.webkit.org/show_bug.cgi?id=55862
2121
2122         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2123         (LayoutTestController::setValueForUser): Implement setValueForUser()
2124
2125 2011-03-08  Patrick Gansterer  <paroga@webkit.org>
2126
2127         Reviewed by Adam Barth.
2128
2129         Add script_shell_command to WebKitPort
2130         https://bugs.webkit.org/show_bug.cgi?id=55925
2131
2132         Add a central place where we generate the shell command from the script name.
2133         This function will be used later to detect the correct script interpreter on Win32.
2134
2135         * Scripts/webkitpy/common/config/ports.py:
2136         * Scripts/webkitpy/layout_tests/port/base.py:
2137         * Scripts/webkitpy/tool/steps/abstractstep.py:
2138         * Scripts/webkitpy/tool/steps/preparechangelog.py:
2139
2140 2011-03-07  Ojan Vafai  <ojan@chromium.org>
2141
2142         Reviewed by Adam Barth.
2143
2144         add webkit-patch attach-to-bug for posting to bugzilla from the commandline
2145         https://bugs.webkit.org/show_bug.cgi?id=55749
2146
2147         * Scripts/webkitpy/tool/commands/upload.py:
2148         * Scripts/webkitpy/tool/commands/upload_unittest.py:
2149         * Scripts/webkitpy/tool/steps/__init__.py:
2150         * Scripts/webkitpy/tool/steps/attachtobug.py: Added.
2151         * Scripts/webkitpy/tool/steps/options.py:
2152
2153 2011-03-07  Daniel Cheng  <dcheng@chromium.org>
2154
2155         Reviewed by David Levin.
2156
2157         Add support for DataTransferItems
2158         https://bugs.webkit.org/show_bug.cgi?id=55115
2159
2160         Enable data transfer items in DRT.
2161
2162         * DumpRenderTree/chromium/TestShell.cpp:
2163         (TestShell::TestShell):
2164
2165 2011-03-06  Ojan Vafai  <ojan@chromium.org>
2166
2167         Reviewed by Tony Chang.
2168
2169         [test dashboard] pull treemap files
2170         https://bugs.webkit.org/show_bug.cgi?id=55852
2171
2172         * TestResultServer/handlers/dashboardhandler.py:
2173
2174 2011-03-03  Hayato Ito  <hayato@chromium.org>
2175
2176         Reviewed by Mihai Parparita.
2177
2178         [NRWT] Clear output image file used by DumpRenderTree to make sure the
2179         previous image should not be used in the ChromiumDriver.
2180
2181         Also make sure that output image from the ChromiumDriver should be ''
2182         (empty string) if a test crashes for consistency with the WebKitDriver
2183         implementation.
2184
2185         https://bugs.webkit.org/show_bug.cgi?id=55746
2186
2187         * Scripts/webkitpy/layout_tests/port/chromium.py:
2188
2189 2011-03-07  Zan Dobersek  <zandobersek@gmail.com>
2190
2191         Reviewed by Martin Robinson.
2192
2193         [Gtk] fast/js/navigator-language.html fails locally
2194         https://bugs.webkit.org/show_bug.cgi?id=55880
2195
2196         Add LANG variable to the clean environment when running
2197         old-run-webkit-tests script.
2198
2199         * Scripts/old-run-webkit-tests:
2200
2201 2011-03-07  Tony Chang  <tony@chromium.org>
2202
2203         Reviewed by Mihai Parparita.
2204
2205         [Chromium] Find .checksum files without .pngs and vice-versa
2206         https://bugs.webkit.org/show_bug.cgi?id=55236
2207
2208         * Scripts/find-mismatched-layout-test-results: Added. A script for finding
2209             mismatched results.
2210
2211 2011-03-07  Chris Fleizach  <cfleizach@apple.com>
2212
2213         Reviewed by Beth Dakin.
2214
2215         AX: WK1 needs to use the ScrollView attachment for AXScrollArea, WK2 should not use this element.
2216         https://bugs.webkit.org/show_bug.cgi?id=55706
2217
2218         The rootElement in DRT should point to the scroll view. In WK1, that will be the parent of the rootObject.
2219
2220         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
2221         (AccessibilityController::focusedElement):
2222            Remove FIXME comment about caching the focusedElement. In fact, we shouldn't cache this 
2223            because it could change at any time.
2224         (AccessibilityController::rootElement):
2225
2226 2011-03-07  Sam Weinig  <sam@webkit.org>
2227
2228         Reviewed by Anders Carlsson.
2229
2230         Add unableToImplementPolicy callback for WebKit2 policy client
2231         <rdar://problem/9071902>
2232         https://bugs.webkit.org/show_bug.cgi?id=55884
2233
2234         * MiniBrowser/mac/BrowserWindowController.m:
2235         (-[BrowserWindowController awakeFromNib]):
2236         Update policy client initialization struct for new member.
2237
2238 2011-03-07  Sam Weinig  <sam@webkit.org>
2239
2240         Reviewed by Anders Carlsson.
2241
2242         Replace WebKit2's decidePolicyForMIMEType with decidePolicyForResponse
2243         https://bugs.webkit.org/show_bug.cgi?id=55827
2244
2245         * MiniBrowser/mac/BrowserWindowController.m:
2246         (decidePolicyForResponse):
2247         (-[BrowserWindowController awakeFromNib]):
2248         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
2249         (TestWebKitAPI::decidePolicyForResponse):
2250         (TestWebKitAPI::TEST):
2251         Update tools for new name.
2252
2253 2011-03-06  Daniel Bates  <dbates@rim.com>
2254
2255         Reviewed by Eric Seidel and David Kilzer.
2256
2257         Fix misspelled word in build-webkit's checkForJavaSDK() and sort forward declarations
2258         https://bugs.webkit.org/show_bug.cgi?id=55503
2259
2260         Fix misspelled word "Dowloads" [sic] in the message printed to standard output
2261         in checkForJavaSDK().
2262
2263         Also, remove extraneous space in function prototype for unlinkZeroFiles.
2264
2265         * Scripts/build-webkit:
2266
2267 2011-03-05  Brian Weinstein  <bweinstein@apple.com>
2268
2269         Reviewed by Sam Weinig.
2270
2271         Fix Web Process crashes caused by https://bugs.webkit.org/show_bug.cgi?id=53919.
2272
2273         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2274         (WTR::InjectedBundlePage::willSendRequestForFrame): Retain the WKURLRequestRef returned
2275             by willSendRequestForFrame. The API expects a retained reference to the URL request.
2276
2277 2011-03-05  Ilya Sherman  <isherman@chromium.org>
2278
2279         Reviewed by Darin Adler.
2280
2281         HTMLInputElement::setValue() should schedule change event when the element is focused
2282         In service of https://code.google.com/p/chromium/issues/detail?id=42716
2283         https://bugs.webkit.org/show_bug.cgi?id=53160
2284
2285         * DumpRenderTree/LayoutTestController.cpp:
2286         (setValueForUserCallback):
2287         (LayoutTestController::staticFunctions):
2288         * DumpRenderTree/LayoutTestController.h:
2289         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2290         (LayoutTestController::setValueForUser): Stubbed out; need real implementation.
2291         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2292         (LayoutTestController::setValueForUser): Expose HTMLInputElement::setValueForUser() to tests
2293         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2294         (LayoutTestController::setValueForUser): Stubbed out; need real implementation.
2295         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2296         (LayoutTestController::setValueForUser): Stubbed out; need real implementation.
2297         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2298         (LayoutTestController::setValueForUser): Stubbed out; need real implementation.
2299
2300 2011-03-04  Mark Rowe  <mrowe@apple.com>
2301
2302         Reviewed by Alexey Proskuryakov.
2303
2304         <rdar://problem/9055252> DumpRenderTree is crashing with GuardMalloc
2305
2306         GuardMalloc does not expect the memory containing its malloc_zone_t to ever be read-only.
2307         
2308         * DumpRenderTree/mac/CheckedMalloc.cpp:
2309         (protectionOfRegion): Retrieve the protection flags for the VM region containing the given address.
2310         (makeLargeMallocFailSilently): Save the initial protection flags, temporarily make the region writeable,
2311         and then restore the initial protection flags when we're done.
2312
2313 2011-03-04  Evan Martin  <evan@chromium.org>
2314
2315         Reviewed by Tony Chang.
2316
2317         [gdb] pretty-print KURL in gdb
2318         https://bugs.webkit.org/show_bug.cgi?id=55788
2319
2320         * gdb/webkit.py: extend the pretty-printers to print WTF::CString
2321         and KURLGooglePrivate.  As always, "p/r" can be used to sidestep
2322         pretty-printing.
2323
2324 2011-03-03  Timothy Hatcher  <timothy@apple.com>
2325
2326         Update the tests that use WKPageRunJavaScriptInMainFrame use the WKSerializedScriptValueRef.
2327
2328         Reviewed by Darin Adler.
2329
2330         * TestWebKitAPI/JavaScriptTest.cpp:
2331         (TestWebKitAPI::javaScriptCallback):
2332         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
2333         (TestWebKitAPI::didRunJavaScript):
2334         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
2335         (TestWebKitAPI::nullJavaScriptCallback):
2336         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
2337         (TestWebKitAPI::didRunJavaScript):
2338
2339 2011-03-03  Timothy Hatcher  <timothy@apple.com>
2340
2341         Make run-api-tests show failed if a test fails.
2342
2343         https://webkit.org/b/55725
2344
2345         Reviewed by Sam Weinig.
2346
2347         * Scripts/run-api-tests:
2348         (runTest): Remove "my" from the nested $result assignment so the
2349         check outside the condition sees the real result.
2350
2351 2011-03-02  MORITA Hajime  <morrita@google.com>
2352
2353         Reviewed by Kent Tamura.
2354
2355         [Chromium][DRT] WebTask should use webkit_support::TaskAdaptor
2356         https://bugs.webkit.org/show_bug.cgi?id=55434
2357
2358         Changed WebTask to be a subclass of webkit_support::TaskAdaptor
2359         and passed the object webkit_support::PostDelayedTask directly.
2360
2361         Note that the change keeps postTask() as is because it has a
2362         semantics taht webkit_support::PostDelayedTask() has; It jumps to
2363         the main thread.
2364
2365         * DumpRenderTree/chromium/Task.cpp:
2366         (postDelayedTask):
2367         * DumpRenderTree/chromium/Task.h:
2368         (WebTask::Run):
2369
2370 2011-03-03  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
2371
2372         Reviewed by Kenneth Rohde Christiansen.
2373
2374         [QT] Implement mock client-based geolocation for layout testing
2375         https://bugs.webkit.org/show_bug.cgi?id=54334
2376
2377         Implement testing for Client-Based geolocation for QtWebkit.
2378
2379         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2380         (WebCore::DumpRenderTree::DumpRenderTree):
2381         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2382         (LayoutTestController::reset):
2383         (LayoutTestController::setGeolocationPermission):
2384         (LayoutTestController::setMockGeolocationError):
2385         (LayoutTestController::setMockGeolocationPosition):
2386
2387 2011-03-03  Sheriff Bot  <webkit.review.bot@gmail.com>
2388
2389         Unreviewed, rolling out r80237.
2390         http://trac.webkit.org/changeset/80237
2391         https://bugs.webkit.org/show_bug.cgi?id=55714
2392
2393         Windows bots aren't ready to be core (Requested by aroben on
2394         #webkit).
2395
2396         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2397         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2398
2399 2011-03-03  Mihai Parparita  <mihaip@chromium.org>
2400
2401         Reviewed by Tony Chang.
2402
2403         NRWT: AttributeError: TestRunner2 instance has no attribute '_cancel_workers'
2404         https://bugs.webkit.org/show_bug.cgi?id=55694
2405         
2406         Fixes for interruptions in NRWT:
2407         - Make TestRunInterruptedException be pickleable correctly (the base
2408           Exception class defines a __reduce__ that does not include the reason)
2409         - Fix ordering of returned arguments from TestRunner2._run_tests
2410           (interrupted and keyboard_interrupted were reversed)
2411         - Fix cancel_workers callsites (was using old name).
2412         - In handle_exception re-raise actual exception instance that was thrown
2413
2414         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2415         * Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
2416         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
2417         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2418
2419 2011-03-03  Qi Zhang  <qi.2.zhang@nokia.com>
2420
2421         Unreviewed.
2422
2423         Adding myself as a committer.
2424
2425         * Scripts/webkitpy/common/config/committers.py:
2426
2427 2011-03-03  Tony Gentilcore  <tonyg@chromium.org>
2428
2429         Reviewed by Mihai Parparita.
2430
2431         Teach sheriffbot to answer whois commands
2432         https://bugs.webkit.org/show_bug.cgi?id=55687
2433
2434         * Scripts/webkitpy/tool/bot/irc_command.py:
2435         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2436         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
2437
2438 2011-03-03  Victoria Kirst  <vrk@google.com>
2439
2440         Reviewed by Eric Carlson.
2441
2442         Enable media tests in chromium-gpu/test_expectations
2443         https://bugs.webkit.org/show_bug.cgi?id=53608
2444
2445         Add media folder to the list of GPU test paths.
2446
2447         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2448
2449 2011-03-03  Adam Roben  <aroben@apple.com>
2450
2451         Work around a bug in KURL's parsing of Windows-style absolute file: URLs
2452
2453         Fixes <http://webkit.org/b/55674> Many tests fail in WebKit2 mode on Windows due to
2454         incorrect parsing of absolute Windows-style file: URLs
2455
2456         Reviewed by Tim Hatcher.
2457
2458         * WebKitTestRunner/TestInvocation.cpp:
2459         (WTR::createWKURL): Add a "localhost" host to file: URLs we create to work around
2460         <http://webkit.org/b/55683>.
2461
2462 2011-03-03  Tony Chang  <tony@chromium.org>
2463
2464         Reviewed by Dimitri Glazkov.
2465
2466         [chromium] Run kill-old-processes on the chromium-win bot too
2467         https://bugs.webkit.org/show_bug.cgi?id=55630
2468
2469         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2470         * BuildSlaveSupport/win/kill-old-processes: Add wdiff.exe to the kill list.
2471
2472 2011-03-03  Carlos Garcia Campos  <cgarcia@igalia.com>
2473
2474         Reviewed by Martin Robinson.
2475
2476         [GTK] DRT needs implementation of EventSender.scheduleAsynchronousClick
2477         https://bugs.webkit.org/show_bug.cgi?id=53960
2478
2479         * DumpRenderTree/gtk/EventSender.cpp:
2480         (sendClick):
2481         (scheduleAsynchronousClickCallback):
2482
2483 2011-03-03  Adam Roben  <aroben@apple.com>
2484
2485         Look for Windows-style paths when checking whether a test is an Inspector test
2486
2487         WTR part of <http://webkit.org/b/55672> <rdar://problem/9080867> All inspector tests time
2488         out or crash on Windows 7 Release (WebKit2 Tests)
2489
2490         Reviewed by Darin Adler.
2491
2492         * WebKitTestRunner/TestInvocation.cpp:
2493         (WTR::shouldOpenWebInspector): Also look for backslashes, since that's what we'll get on
2494         Windows.
2495
2496 2011-03-03  Adam Roben  <aroben@apple.com>
2497
2498         Make Windows 7 Release (Tests) a core builder
2499
2500         We can probably make Windows XP Debug (Tests) a core builder, too, but we should probably
2501         give it a few more days of greenness first.
2502
2503         Fixes <http://webkit.org/b/55665> Windows 7 Release (Tests) should be a core builder
2504
2505         Reviewed by Andreas Kling.
2506
2507         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2508         (BuildBot): Added a regexp to match Windows 7 Release (Tests).
2509
2510         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2511         (BuildBotTest): Updated the list of builders to match the current list on build.webkit.org.
2512         Updated the core regexps to match the buildbot module. Updated the expected results to match
2513         the current set of core builders.
2514
2515 2011-03-03  Benjamin Poulain  <benjamin.poulain@nokia.com>
2516
2517         Reviewed by Andreas Kling.
2518
2519         Adding myself as a reviewer.
2520
2521         * Scripts/webkitpy/common/config/committers.py:
2522
2523 2011-03-03  Lukasz Slachciak  <l.slachciak@samsung.com>
2524
2525         Reviewed by Xan Lopez.
2526
2527         [GTK] Extended application cache database API and added unit tests file.
2528         https://bugs.webkit.org/show_bug.cgi?id=55335
2529
2530         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: removed external declaration
2531         of webkit_application_cache_set_maximum_size due to API exposal.
2532
2533 2011-03-02  Ojan Vafai  <ojan@chromium.org>
2534
2535         Reviewed by Adam Barth.
2536
2537         make webkit-patch upload work for security bugs
2538         https://bugs.webkit.org/show_bug.cgi?id=55655
2539
2540         The problem is that we shell out to prepare-ChangeLog,
2541         which does not authenticate with bugzilla. All it needs from
2542         bugzilla is the bug title though. We just pass it through from
2543         webkit-patch instead.
2544
2545         * Scripts/prepare-ChangeLog:
2546         * Scripts/webkitpy/common/net/bugzilla/bug.py:
2547         * Scripts/webkitpy/tool/steps/preparechangelog.py:
2548
2549 2011-03-01  Ojan Vafai  <ojan@chromium.org>
2550
2551         Reviewed by Tony Chang.
2552
2553         [test-dashboard] make gtest JSON match layout-tests JSON
2554         https://bugs.webkit.org/show_bug.cgi?id=55556
2555
2556         http://trac.webkit.org/changeset/80090 stopped converting time_ms to t.
2557         Make this code match.
2558
2559         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2560
2561 2011-03-02  Dirk Pranke  <dpranke@chromium.org>
2562
2563         Reviewed by Tony Chang.
2564
2565         NRWT - implement Linux Hardy 64-bit port support. This involves
2566         adding support for non-'x86' architectures and updating the
2567         "deduplicate_tests" script to correctly understand that
2568         port.name() is not always equal to basename(port.baseline_path()).
2569
2570         This change introduces two new port names: 'chromium-linux-x86'
2571         and 'chromium-linux-x86_64'. Using the prior 'chromium-linux'
2572         flag will cause the code to determine which one to use at
2573         runtime, just like we currently do with 'chromium-win'.
2574
2575         https://bugs.webkit.org/show_bug.cgi?id=55535
2576
2577         * Scripts/webkitpy/common/system/executive_mock.py:
2578           Handle 'return_stderr' keyword arg to run_command()
2579         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
2580         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
2581         * Scripts/webkitpy/layout_tests/port/base.py:
2582         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2583         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
2584         * Scripts/webkitpy/layout_tests/port/factory.py:
2585         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
2586
2587 2011-03-02  Kevin Ollivier  <kevino@theolliviers.com>
2588
2589         [wx] Build fix, make sure we put the wxWebKit dylib in the right directory and
2590         update symlinks accordingly.
2591
2592         * wx/packaging/build-mac-installer.py:
2593
2594 2011-03-02  Sheriff Bot  <webkit.review.bot@gmail.com>
2595
2596         Unreviewed, rolling out r80139.
2597         http://trac.webkit.org/changeset/80139
2598         https://bugs.webkit.org/show_bug.cgi?id=55620
2599
2600         failing and crashing tests on Snow Leopard bot (Requested by
2601         mihaip1 on #webkit).
2602
2603         * DumpRenderTree/LayoutTestController.cpp:
2604         (LayoutTestController::staticFunctions):
2605         * DumpRenderTree/LayoutTestController.h:
2606         * DumpRenderTree/chromium/LayoutTestController.cpp:
2607         (LayoutTestController::LayoutTestController):
2608         * DumpRenderTree/chromium/LayoutTestController.h:
2609         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2610         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2611         * DumpRenderTree/mac/UIDelegate.h:
2612         * DumpRenderTree/mac/UIDelegate.mm:
2613         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2614         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2615         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2616         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2617
2618 2011-03-02  Adam Roben  <aroben@apple.com>
2619
2620         Wait for force a paint in WebKitTestRunner until we're actually ready to dump the output
2621
2622         This matches DumpRenderTree on Windows.
2623
2624         Fixes <http://webkit.org/b/55469> <rdar://problem/9068539> REGRESSION (r79863): Lots of
2625         dom/html/level2/html/HTMLFrameElement*.html tests crashing in FrameView::paintOverhangAreas
2626         in WebKit2
2627
2628         Reviewed by Beth Dakin.
2629
2630         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2631         (WTR::InjectedBundlePage::dump): Moved code to force a paint here...
2632         (WTR::InjectedBundlePage::didFinishLoadForFrame): ...from here.
2633
2634 2011-03-02  Daniel Cheng  <dcheng@chromium.org>
2635
2636         Reviewed by David Levin.
2637
2638         Add feature define for data transfer items
2639         https://bugs.webkit.org/show_bug.cgi?id=55510
2640
2641         * Scripts/build-webkit:
2642
2643 2011-03-02  Adam Roben  <aroben@apple.com>
2644
2645         Look in the new-to-SnowLeopard location for crash logs on SnowLeopard and newer
2646
2647         ReportCrash saves logs to ~/Library/Logs/CrashReporter on Leopard, but to
2648         ~/Library/Logs/DiagnosticReports on SnowLeopard. old-run-webkit-tests was only looking in
2649         the former location, but was getting lucky on some SnowLeopard machines because symlinks
2650         were being created there pointing into DiagnosticReports. For machines without these
2651         symlinks, crash logs were not getting captured.
2652
2653         Fixes <http://webkit.org/b/55607> old-run-webkit-tests doesn't capture crash logs on some
2654         SnowLeopard machines
2655
2656         Reviewed by Eric Seidel.
2657
2658         * Scripts/old-run-webkit-tests:
2659         (captureSavedCrashLog): Look in ~/Library/Logs/DiagnosticReports on SnowLeopard and newer.
2660
2661 2011-03-02  Adam Roben  <aroben@apple.com>
2662
2663         Don't try to capture crash logs on platforms that haven't implemented that feature
2664
2665         Fixes <http://webkit.org/b/55504> Use of uninitialized value in numeric lt (<) at
2666         Tools/Scripts/old-run-webkit-tests line 1778 seen on Qt bots after a crash
2667
2668         Reviewed by Joseph Pecoraro.
2669
2670         * Scripts/old-run-webkit-tests:
2671         (captureSavedCrashLog): Bail if we don't have a crash log glob.
2672         (findNewestFileMatchingGlob): Fix a buggy test for when no paths match the glob. This isn't
2673         strictly required to fix bug 55504, but seems worthwhile.
2674
2675 2011-01-26  John Knottenbelt  <jknotten@chromium.org>
2676
2677         Reviewed by Dmitry Titov.
2678
2679         Detach Geolocation from Frame when Page destroyed.
2680         https://bugs.webkit.org/show_bug.cgi?id=52877
2681
2682         Extend the layout test controller to expose the number of pending
2683         geolocation requests, so that we can test that the requests have
2684         been cancelled on page close.
2685
2686         * DumpRenderTree/LayoutTestController.cpp:
2687         (numberOfPendingGeolocationPermissionRequestsCallback):
2688         (LayoutTestController::staticFunctions):
2689         * DumpRenderTree/LayoutTestController.h:
2690         * DumpRenderTree/chromium/LayoutTestController.cpp:
2691         (LayoutTestController::LayoutTestController):
2692         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2693         * DumpRenderTree/chromium/LayoutTestController.h:
2694         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2695         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2696         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2697         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2698         * DumpRenderTree/mac/UIDelegate.h:
2699         * DumpRenderTree/mac/UIDelegate.mm:
2700         (-[UIDelegate numberOfPendingGeolocationPermissionRequests]):
2701         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2702         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2703         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2704         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2705         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2706         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2707         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2708
2709
2710 2011-03-01  Kent Tamura  <tkent@chromium.org>
2711
2712         Reviewed by Dimitri Glazkov.
2713
2714         Assertion fails when a form validation bubble appears
2715         https://bugs.webkit.org/show_bug.cgi?id=55550
2716
2717         Test: fast/forms/interactive-validation-attach-assertion.html
2718
2719         * DumpRenderTree/chromium/WebPreferences.cpp:
2720         (WebPreferences::applyTo): Enable the interactive validation feature by
2721           default. This matches to Chromium browser.
2722
2723 2011-03-01  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2724
2725         Reviewed by Kent Tamura.
2726
2727         Remove efl port style exception of Webcore/JavaScriptCore
2728         https://bugs.webkit.org/show_bug.cgi?id=55549
2729
2730         WebCore and JavaScriptCore need to adhere WebKit coding style.
2731
2732         * Scripts/webkitpy/style/checker.py:
2733
2734 2011-03-01  Tony Chang  <tony@chromium.org>
2735
2736         Reviewed by Ojan Vafai.
2737
2738         [chromium] clean up temp files on chromium-mac builder too
2739         https://bugs.webkit.org/show_bug.cgi?id=55525
2740
2741         * BuildSlaveSupport/chromium/remove-crash-logs:
2742
2743 2011-02-28  Ojan Vafai  <ojan@chromium.org>
2744
2745         Reviewed by Tony Chang.
2746
2747         wrap json in a function call to afford cross-domain loading
2748         https://bugs.webkit.org/show_bug.cgi?id=55353
2749
2750         Also delete the code that compacts the JSON. It turns out this
2751         breaks the rebaseline tool and is probably a premature optimization anyways.
2752
2753         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2754         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2755         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2756         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
2757
2758 2011-03-01  Sheriff Bot  <webkit.review.bot@gmail.com>
2759
2760         Unreviewed, rolling out r80079.
2761         http://trac.webkit.org/changeset/80079
2762         https://bugs.webkit.org/show_bug.cgi?id=55547
2763
2764         "Broke the Win debug build?" (Requested by dcheng on #webkit).
2765
2766         * Scripts/build-webkit:
2767
2768 2011-03-01  Mark Rowe  <mrowe@apple.com>
2769
2770         Reviewed by Sam Weinig.
2771
2772         Update verification scripts to handle WebKit2.
2773
2774         * Scripts/check-for-global-initializers: Skip object files that use RefCountedLeakChecker.
2775         * Scripts/check-for-inappropriate-files-in-framework: Add some inappropriate file types for
2776         WebKit2.
2777
2778 2011-03-01  Daniel Cheng  <dcheng@chromium.org>
2779
2780         Reviewed by David Levin.
2781
2782         Add feature define for data transfer items
2783         https://bugs.webkit.org/show_bug.cgi?id=55510
2784
2785         * Scripts/build-webkit:
2786
2787 2011-02-23  Joseph Pecoraro  <joepeck@webkit.org>
2788
2789         Reviewed by Timothy Hatcher.
2790
2791         All Console Messages should be passed to ChromeClients.
2792         https://bugs.webkit.org/show_bug.cgi?id=54926
2793
2794         Update DumpRenderTree's UIDelegate to use the new console message delegate.
2795
2796         * DumpRenderTree/mac/UIDelegate.mm:
2797         (-[UIDelegate webView:addMessageToConsole:withSource:]):
2798
2799 2011-03-01  Dirk Pranke  <dpranke@chromium.org>
2800
2801         Reviewed by Adam Barth.
2802
2803         Tragically, we stopped running the python unit tests
2804         on Chromium Win just as I was getting them to be green.
2805         This patch turns them back on.
2806
2807         https://bugs.webkit.org/show_bug.cgi?id=55521
2808
2809         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2810
2811 2011-03-01  Dirk Pranke  <dpranke@chromium.org>
2812
2813         Reviewed by Adam Roben.
2814
2815         Disable
2816         webkitpy.common.system.executive_unittest.ExecutiveTest.\
2817            test_kill_all fails on win until it can be properly triaged.
2818
2819         https://bugs.webkit.org/show_bug.cgi?id=54790
2820
2821         * Scripts/webkitpy/common/system/executive_unittest.py:
2822
2823     2011-03-01  Helder Correia  <helder@sencha.com>
2824
2825             Unreviewed. Add myself to committers.py.
2826
2827             * Scripts/webkitpy/common/config/committers.py:
2828
2829 2011-03-01  Adam Roben  <aroben@apple.com>
2830
2831         Give up if a crash log for the web process is taking too long to be saved on Windows
2832
2833         This should keep the bots from getting stuck while waiting for a crash log, if writing a
2834         crash log ever hangs or the UI process for some reason doesn't notice it's finished.
2835
2836         Fixes <http://webkit.org/b/55499> WebKitTestRunner can hang forever waiting for a crash log
2837         to be saved for the web process
2838
2839         Reviewed by Steve Falkenburg.
2840
2841         * WebKitTestRunner/win/TestControllerWin.cpp:
2842         (WTR::runRunLoopUntil): Moved code to run the run loop here here from platformRunUntil.
2843         Generalized the code slightly to handle the optional object to wait on.
2844         (WTR::TestController::platformRunUntil): Use the new runRunLoopUntil function, and also use
2845         it (with a timeout) when waiting for a crash log for the web process to be saved. This will
2846         prevent us from waiting forever.
2847
2848 2011-03-01  Adam Roben  <aroben@apple.com>
2849
2850         Give WebKitLauncherWin's PDB file a name different from WebKit's
2851
2852         WebKitLauncherWin (which builds WebKit.exe) and WebKit (which builds WebKit.dll) were
2853         fighting over the same PDB file, meaning that one of them was going to lose and not have
2854         symbols. WebKitLauncherWin's PDB file is now named WebKitLauncherWin.pdb.
2855
2856         Fixes <http://webkit.org/b/55495> Crashes in WebKit.dll have bad backtraces for some test
2857         runs (due to missing symbols)
2858
2859         Reviewed by David Kilzer.
2860
2861         * WebKitLauncherWin/WebKitLauncherWinCommon.vsprops: Use the project name,
2862         "WebKitLauncherWin", instead of the target name, "WebKit", when naming the PDB file.
2863
2864 2011-03-01  Adam Roben  <aroben@apple.com>
2865
2866         Count web process crashes toward the --exit-after-n-crashes-or-timeouts limit
2867
2868         Fixes <http://webkit.org/b/55492> Web process crashes aren't counted toward the
2869         --exit-after-n-crashes-or-timeouts limit
2870
2871         Reviewed by David Kilzer.
2872
2873         * Scripts/old-run-webkit-tests:
2874         (stopRunningTestsEarlyIfNeeded): Include web process crashes in the computation, and print
2875         the number of tests that caused the web process to crash when exiting early.
2876
2877 2011-03-01  Adam Roben  <aroben@apple.com>
2878
2879         Save a crash log when the web process crashes
2880
2881         On Windows, WebKitTestRunner now detects when the web process is crashing and waits to exit
2882         until it has finished crashing, which guarantees that the crash log will have had time to be
2883         saved, too. On Mac, we always wait until ReportCrash has exited before capturing the crash
2884         log, so all we have to do is choose the right crash log out of the CrashReporter directory.
2885
2886         Fixes <http://webkit.org/b/44121> <rdar://problem/8320759> When the web process crashes and
2887         a crash log is being saved, WebKitTestRunner thinks the web process has become unresponsive
2888
2889         Reviewed by Sam Weinig.
2890
2891         * Scripts/old-run-webkit-tests:
2892         (testCrashedOrTimedOut): Don't kill WebKitTestRunner when the web process crashes. It will
2893         kill itself. On Windows, this will cause us to wait until the crash log has been saved. On
2894         Mac, it should have no effect. Capture saved crash logs for web process crashes, too.
2895         (captureSavedCrashLog): Added $webProcessCrashed argument. On Mac, look for
2896         WebProces_*.crash files when the web process crashes.
2897
2898         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2899         (WTR::InjectedBundle::initialize): Added an initializationUserData argument. Updated for
2900         initializePlatformDefaults -> platformInitialize rename. Pass the initializationUserData
2901         along to platformInitialize.
2902
2903         * WebKitTestRunner/InjectedBundle/InjectedBundle.h: See above.
2904
2905         * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp:
2906         (WKBundleInitialize): Pass along the initializationUserData to the InjectedBundle.
2907
2908         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
2909         (WTR::InjectedBundle::platformInitialize):
2910         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
2911         (WTR::InjectedBundle::platformInitialize):
2912         Updated function signature.
2913
2914         * WebKitTestRunner/InjectedBundle/win/InjectedBundleWin.cpp:
2915         (WTR::exceptionFilter): Added. Tells the UI process we're crashing by signaling the
2916         webProcessCrashingEvent, then lets the crash continue as normal.
2917
2918         (WTR::InjectedBundle::platformInitialize): Hook up exceptionFilter. Retrieve the name of the
2919         event we should use to tell the UI process we're crashing from the initializationUserData,
2920         and get a handle to that event.
2921
2922         * WebKitTestRunner/TestController.cpp:
2923         (WTR::TestController::TestController): Initialize new members.
2924         (WTR::TestController::processDidCrash): Removed unnecessary WKPageRef argument. Changed to
2925         only print the "#CRASHED - WebProcess" message once, since this can be called more than once
2926         when a crash log is being saved on Windows. Exit right away if specified. (This is the
2927         default.)
2928
2929         * WebKitTestRunner/TestController.h: Added new members.
2930
2931         * WebKitTestRunner/win/TestControllerWin.cpp:
2932         (WTR::TestController::platformInitialize): Set up the event the web process will use to tell
2933         us it's crashing.
2934         (WTR::TestController::platformRunUntil): Pass MWMO_INPUTAVAILABLE to
2935         ::MsgWaitForMultipleObjectsEx so we'll process messages that have already been seen by
2936         ::PeekMessage. (This is unrelated to the bug fix.) Notice when the webProcessCrashingEvent
2937         has been signaled. When this happens, print the "#CRASHED - WebProcess" message right away
2938         so the test harness will know the web process has crashed and not try to kill us, then wait
2939         for the web process to finish crashing so a crash log will have time to be saved.
2940         (WTR::toWK): Simple hepler function.
2941         (WTR::TestController::platformInitializeContext): Pass along the name of the event the web
2942         process should use to tell us it is crashing in the context's initialization user data.
2943
2944 2011-03-01  Dimitri Glazkov  <dglazkov@chromium.org>
2945
2946         Reviewed by Tony Gentilcore.
2947
2948         Move the checks to exclude Python/Perl tests for Chromium Win build to the right place.
2949         https://bugs.webkit.org/show_bug.cgi?id=55476
2950
2951         Chromium Win uses BuildAndTestFactory, not TestFactory.
2952
2953         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Moved to the right place.
2954
2955 2011-03-01  Adam Roben  <aroben@apple.com>
2956
2957         Test that the WebKit2 responsiveness timer doesn't fire too early
2958
2959         Test for <http://webkit.org/b/55417> <rdar://problem/9065287> RunLoop::Timer fires 1000x too
2960         early on Windows
2961
2962         Reviewed by Anders Carlsson.
2963
2964         * TestWebKitAPI/PlatformUtilities.h: Added sleep().
2965
2966         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly.cpp: Added.
2967         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
2968         (TestWebKitAPI::didFinishLoadForFrame):
2969         (TestWebKitAPI::processDidBecomeUnresponsive):
2970         (TestWebKitAPI::setInjectedBundleClient):
2971         (TestWebKitAPI::setPageLoaderClient):
2972         Simple helper functions.
2973
2974         (TestWebKitAPI::TEST): Load an HTML file to make sure the web process is initialized. Then
2975         tell the web process to pause and press the spacebar key. The spacebar keypress should cause
2976         the responsiveness timer to start, but the web process should unpause before it has a chance
2977         to fire. Run until the web process has unpaused, and assert that the timer didn't fire.
2978
2979         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly_Bundle.cpp: Added.
2980         (TestWebKitAPI::ResponsivenessTimerDoesntFireEarlyTest::ResponsivenessTimerDoesntFireEarlyTest):
2981         Call up to the base class.
2982         (TestWebKitAPI::ResponsivenessTimerDoesntFireEarlyTest::didReceiveMessage): When asked to
2983         pause, sleep for 0.5 seconds, then send back a message saying we paused.
2984
2985         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
2986         (TestWebKitAPI::Util::sleep): Added. Calls through to usleep.
2987         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
2988         (TestWebKitAPI::Util::sleep): Added. Calls through to ::Sleep.
2989
2990         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2991         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2992         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
2993         Added new files.
2994
2995 2011-03-01  Andras Becsi  <abecsi@webkit.org>
2996
2997         Reviewed by Csaba Osztrogonác.
2998
2999         [Qt] Clean up the project files and move common options to WebKit.pri.
3000
3001         * WebKitTestRunner/qt/WebKitTestRunner.pro: Deduplicate.
3002
3003
3004 2011-03-01  Adam Roben  <aroben@apple.com>
3005
3006         Skip another multiprocessing test on Windows
3007
3008         It is sometimes failing (and may be leaving child Python processes around).
3009         <http://webkit.org/b/55087> tracks the failure.
3010
3011         * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker_unittest.py:
3012         (FuncitonTests.test_get__processes): Skip this test on Windows.
3013
3014 2011-03-01  Ilya Tikhonovsky  <loislo@chromium.org>
3015
3016         Reviewed by Pavel Feldman.
3017
3018         Web Inspector: reduce inspector tests flakiness.
3019         https://bugs.webkit.org/show_bug.cgi?id=55401
3020
3021         * DumpRenderTree/chromium/TestShell.cpp:
3022         (TestShell::runFileTest):
3023         * DumpRenderTree/chromium/WebPreferences.cpp:
3024         (WebPreferences::reset):
3025
3026 2011-02-28  Mihai Parparita  <mihaip@chromium.org>
3027
3028         Reviewed by James Robinson.
3029
3030         NRWT should still upload results when it exits early due to too many failures
3031         https://bugs.webkit.org/show_bug.cgi?id=55432
3032         
3033         Only keyboard interrupts should prevent results from being uploaded.
3034
3035         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
3036         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3037
3038 2011-02-28  Alice Liu  <alice.liu@apple.com>
3039
3040         Reviewed by Adam Roben and Gavin Barraclough.
3041
3042         Test for https://bugs.webkit.org/show_bug.cgi?id=54898
3043         InjectedBundleNodeHandle dies too early in WKBundleHitTestResultGetNodeHandle.
3044
3045         * TestWebKitAPI/InjectedBundleController.h:
3046         (TestWebKitAPI::InjectedBundleController::bundle):
3047         * TestWebKitAPI/PlatformWebView.h:
3048         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp: Added.
3049         (TestWebKitAPI::didFinishLoadForFrame):
3050         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
3051         (TestWebKitAPI::setPageLoaderClient):
3052         (TestWebKitAPI::TEST):
3053         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle_Bundle.cpp: Added.
3054         (TestWebKitAPI::HitTestResultNodeHandleTest::HitTestResultNodeHandleTest):
3055         (TestWebKitAPI::HitTestResultNodeHandleTest::getContextMenuFromDefaultMenu):
3056         (TestWebKitAPI::HitTestResultNodeHandleTest::didCreatePage):
3057         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
3058         (TestWebKitAPI::PlatformWebView::simulateRightClick):
3059         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
3060         (TestWebKitAPI::PlatformWebView::simulateRightClick):
3061         
3062         Added files to:
3063         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3064         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3065         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
3066
3067 2011-02-28  Adam Roben  <aroben@apple.com>
3068
3069         Start running InjectedBundle API tests on Windows
3070
3071         A new project, TestWebKitAPIInjectedBundle, builds the injected bundle DLL.
3072
3073         Fixes <http://webkit.org/b/55420> run-api-tests doesn't run injected bundle tests on Windows
3074
3075         Reviewed by Darin Adler.
3076
3077         * TestWebKitAPI/Configurations/TestWebKitAPIDebug.vsprops: Added.
3078         * TestWebKitAPI/Configurations/TestWebKitAPIDebugAll.vsprops: Added.
3079         * TestWebKitAPI/Configurations/TestWebKitAPIDebugCairoCFLite.vsprops: Added.
3080         * TestWebKitAPI/Configurations/TestWebKitAPIRelease.vsprops: Added.
3081         * TestWebKitAPI/Configurations/TestWebKitAPIReleaseCairoCFLite.vsprops: Added.
3082         These are just extracted from TestWebKitAPI.vcproj.
3083
3084         * TestWebKitAPI/Configurations/TestWebKitAPIInjectedBundleCommon.vsprops: Added. Just sets
3085         up the DLL's filename.
3086
3087         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp: Fixed DLL name.
3088         (TestWebKitAPI::Util::createInjectedBundlePath): Changed to use kCFAllocatorNull instead of
3089         0 (== kCFAllocatorDefault) so that CF won't try to deallocate our C string.
3090
3091         * TestWebKitAPI/win/TestWebKitAPI.sln: Added TestWebKitAPIInjectedBundle. Removed the bogus
3092         "all" configuration.
3093
3094         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Changed to use the new .vsprops files. Added
3095         injected bundle tests. Let VS resort things.
3096
3097         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj: Copied from Tools/TestWebKitAPI/win/TestWebKitAPI.vcproj.
3098
3099 2011-02-28  Adam Roben  <aroben@apple.com>
3100
3101         Add a test for the paint rect passed via WM_PAINT to windowless plugins
3102
3103         Test for <http://webkit.org/b/55365> <rdar://problem/9031089> REGRESSION (r79040): WebKit2:
3104         Large portions of pages with plugins paint black
3105
3106         Reviewed by Anders Carlsson.
3107
3108         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
3109         (PluginTest::NPP_HandleEvent):
3110         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
3111         Added NPP_HandleEvent. Just returns 0 at this level.
3112
3113         * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowlessPaintRectCoordinates.cpp: Added.
3114         (WindowlessPaintRectCoordinates::WindowlessPaintRectCoordinates): Call up to the base class.
3115         (WindowlessPaintRectCoordinates::NPP_New): Mark ourselves as windowless.
3116         (WindowlessPaintRectCoordinates::NPP_HandleEvent): Check that the paint rect passed via
3117         WM_PAINT has the expected coordinates.
3118
3119         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3120         (NPP_HandleEvent): Give the PluginTest a chance to handle the event before doing anything
3121         else.
3122
3123         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Added new file, let VS
3124         resort things.
3125
3126         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3127         (WTR::InjectedBundlePage::didFinishLoadForFrame): Added a call to WKBundlePageForceRepaint.
3128         This is roughly equivalent to the call to -[WebView displayIfNeeded] in -[FrameLoadDelegate
3129         webView:didFinishLoadForFrame:] in DumpRenderTree.
3130
3131         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3132         (WTR::PlatformWebView::PlatformWebView): Tell the WKView it's in a window so that plugins
3133         can start running.
3134
3135 2011-02-28  Adam Roben  <aroben@apple.com>
3136
3137         Tell MiniBrowser's WKViews that they're in a window
3138
3139         Fixes <http://webkit.org/b/55364> Plugins don't work in MiniBrowser on Windows
3140
3141         Reviewed by Anders Carlsson.
3142
3143         * MiniBrowser/win/BrowserView.cpp:
3144         (BrowserView::create): Call WKViewSetIsInWindow after creating the view.
3145
3146 2011-02-28  Alexis Menard  <alexis.menard@openbossa.org>
3147
3148         Reviewed by Csaba Osztrogonác.
3149
3150         The new QML tests require QML_IMPORT_PATH variable to be set in order to
3151         load the proper plugin.
3152
3153         * Scripts/run-qtwebkit-tests:
3154
3155 2011-02-28  Joone Hur  <joone.hur@collabora.co.uk>
3156
3157         Unreviewed, fix spelling mistake.
3158
3159         hardware-accelated => hardware-accelerated.
3160
3161         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3162
3163 2011-02-28  Kristian Amlie  <kristian.amlie@nokia.com>
3164
3165         Reviewed by Andreas Kling.
3166
3167         Made sure that the build-webkit --qmake argument is always respected.
3168
3169         Previously, it would be respected during the build, but not during
3170         the early feature detection. The build would also fail if qmake was
3171         not in your path, even if you specified --qmake with a valid qmake
3172         binary.
3173
3174         [Qt] WebKit patches required to work with a modularized version of Qt
3175         https://bugs.webkit.org/show_bug.cgi?id=53916
3176
3177         * Scripts/build-webkit:
3178         * Scripts/webkitdirs.pm:
3179
3180 2011-02-27  Ojan Vafai  <ojan@chromium.org>
3181
3182         Fix failing tests from http://trac.webkit.org/changeset/79837.
3183
3184         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
3185         This was just a mistake that would break if someone tried printing with this configuration.
3186         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
3187         Method signature changed. Didn't notice that this method was being calling in a unittest.
3188
3189 2011-02-24  Hayato Ito  <hayato@chromium.org>
3190
3191         Reviewed by Eric Seidel.
3192
3193         [NRWT] Remove test_types/* classes.
3194
3195         This is the last patch in the series of efforts which tried to remove test_types classes.
3196         A single_test_runner module will take over responsibilities of test_type classes.
3197
3198         From this patch, we won't display statistics per test_type even if a '--verbose' option is given.
3199
3200         https://bugs.webkit.org/show_bug.cgi?id=55123
3201
3202         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
3203         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
3204         * Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py:
3205         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
3206         * Scripts/webkitpy/layout_tests/layout_package/worker_mixin.py:
3207         * Scripts/webkitpy/layout_tests/test_types/__init__.py: Removed.
3208         * Scripts/webkitpy/layout_tests/test_types/image_diff.py: Removed.
3209         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py: Removed.
3210         * Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py: Removed.
3211         * Scripts/webkitpy/layout_tests/test_types/text_diff.py: Removed.
3212
3213 2011-02-25  Ojan Vafai  <ojan@chromium.org>
3214
3215         Reviewed by Tony Chang.
3216
3217         Change results.json format to the one used by unexpected_results.json
3218         https://bugs.webkit.org/show_bug.cgi?id=52267
3219
3220         Also add runtimes in milliseconds to the JSON and make the output format more compact.
3221         Named the file full_results.json to avoid conflicting with the results.json
3222         file the test-results server currently serves up.
3223
3224         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
3225         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3226         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
3227         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
3228         * Scripts/webkitpy/layout_tests/layout_package/result_summary.py:
3229         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
3230
3231 2011-02-27  Adam Roben  <aroben@apple.com>
3232
3233         Followup fix to r79827
3234
3235         * DumpRenderTree/win/UIDelegate.cpp:
3236         (UIDelegate::webViewAddMessageToConsole): Replaced call to urlSuitableForTestResult with
3237         lastPathComponent. This matches what we did here before r79827, and matches Mac.
3238
3239 2011-02-27  Dan Bernstein  <mitz@apple.com>
3240
3241         Reviewed by Adam Roben.
3242
3243         Make bisect-builds print a trac link for the regression range
3244         https://bugs.webkit.org/show_bug.cgi?id=55331
3245
3246         * Scripts/bisect-builds:
3247
3248 2011-02-27  Adam Roben  <aroben@apple.com>
3249
3250         Use iswalpha instead of isalpha when dealing with wchar_ts in EditingDelegate
3251
3252         Fixes <http://webkit.org/b/55062> <rdar://problem/9059907> Crash beneath
3253         EditingDelegate::checkSpellingOfString when running fast/forms/input-text-maxlength.html or
3254         fast/forms/input-text-paste-maxlength.html on Windows with full page heap enabled
3255
3256         Reviewed by Anders Carlsson.
3257
3258         * DumpRenderTree/win/EditingDelegate.cpp:
3259         (indexOfFirstWordCharacter):
3260         (wordLength):
3261         Use iswalpha instead of isalpha, since TCHAR is really just wchar_t.
3262
3263 2011-02-27  Adam Roben  <aroben@apple.com>
3264
3265         Make ResourceLoadDelegate print URLs relative to the main resource on Windows
3266
3267         This matches Mac. (In fact, the code was ported from Mac!)
3268
3269         Fixes <http://webkit.org/b/55328> URLs printed by ResourceLoadDelegate on Windows don't
3270         match Mac
3271
3272         Reviewed by Anders Carlsson.
3273
3274         * DumpRenderTree/win/DumpRenderTree.cpp:
3275         (substringFromIndex): Added. Emulates -[NSString substringFromIndex:].
3276         (urlSuitableForTestResult): Ported code from -[NSURL(DRTExtras)
3277         _drt_descriptionSuitableForTestResult].
3278         (cfStringRefToWString): Moved here from LayoutTestControllerWin.cpp.
3279
3280         * DumpRenderTree/win/DumpRenderTreeWin.h: Added declaration of cfStringRefToWString.
3281
3282         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Moved cfStringRefToWString to
3283         DumpRenderTree.cpp.
3284
3285 2011-02-27  Adam Roben  <aroben@apple.com>
3286
3287         Change the order of Chang Shu's email addresses so the first one is their Bugzilla username
3288
3289         This makes Bugzilla autocompletion work correctly.
3290
3291         * Scripts/webkitpy/common/config/committers.py:
3292
3293 2011-02-27  Patrick Gansterer  <paroga@webkit.org>
3294
3295         Reviewed by Andreas Kling.
3296
3297         [Qt] fast/loader/user-stylesheet-fast-path.html fails
3298         https://bugs.webkit.org/show_bug.cgi?id=50911
3299
3300         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3301         (LayoutTestController::setUserStyleSheetLocation):
3302         Use QUrl::fromEncoded since the passed string is already encoded.
3303
3304 2011-02-27  Adam Roben  <aroben@apple.com>
3305
3306         Ensure $testResultsDirectory is an absolute path before setting up Windows crash log saving
3307
3308         Windows 7 (and maybe Vista?) launches the post-mortem debugger with a working directory that
3309         is different from old-run-webkit-test's. Because of this, the path to the crash log file
3310         (which is relative to $testResultsDirectory) must be an absolute path. See the bug for more
3311         details.
3312
3313         Fixes <http://webkit.org/b/55318> Crash logs aren't saved on Windows 7 when a relative
3314         --results-directory path is used (like on the test slaves)
3315
3316         Reviewed by Dan Bernstein.
3317
3318         * Scripts/old-run-webkit-tests: Moved the call to setUpWindowsCrashLogSaving after we've
3319         made $testResultsDirectory an absolute path.
3320
3321 2011-02-26  Dominic Mazzoni  <dmazzoni@google.com>
3322
3323         Reviewed by Adam Barth.
3324
3325         m_dumpAccessibilityNotifications should be initialized.
3326         https://bugs.webkit.org/show_bug.cgi?id=54874
3327
3328         * DumpRenderTree/chromium/AccessibilityController.cpp:
3329         (AccessibilityController::AccessibilityController):
3330
3331 2011-02-26  Vsevolod Vlasov  <vsevik@chromium.org>
3332
3333         Reviewed by Pavel Feldman.
3334
3335         DumpRenderTree should reset frame opener between tests.
3336         https://bugs.webkit.org/show_bug.cgi?id=54874
3337
3338         Added clearOpener() calls between tests.
3339         Some tests are using window.open() to change current window location.
3340         This changes window.opener property whose nullity is checked before
3341         showing xml viewer.
3342
3343         * DumpRenderTree/chromium/TestShell.cpp:
3344         (TestShell::resetTestController):
3345         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3346         (resetDefaultsToConsistentValues):
3347         * DumpRenderTree/mac/DumpRenderTree.mm:
3348         (resetWebViewToConsistentStateBeforeTesting):
3349         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3350         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
3351         * DumpRenderTree/win/DumpRenderTree.cpp:
3352         (resetWebViewToConsistentStateBeforeTesting):
3353         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3354         (WTR::InjectedBundlePage::reset):
3355
3356 2011-02-26  Yael Aharon  <yael.aharon@nokia.com>
3357
3358         Reviewed by Andreas Kling.
3359
3360         [Qt] Fix the focus in MiniBrowser.
3361         https://bugs.webkit.org/show_bug.cgi?id=55288
3362
3363         Give focus to the web view when a load starts.
3364
3365         * MiniBrowser/qt/BrowserWindow.cpp:
3366         (BrowserWindow::urlChanged):
3367
3368 2011-02-26  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3369
3370         Reviewed by Adam Barth.
3371
3372         [EFL] Add coding style exceptions for EFL port
3373         https://bugs.webkit.org/show_bug.cgi?id=54733
3374
3375         The EFL APIs use EFL naming style, which includes both lower-cased and camel-cased,
3376         underscore-sparated values. But, style checking rule have found parameter_name errors
3377         in efl directories so far.
3378
3379         * Scripts/webkitpy/style/checker.py: Add prameter_name rule's exception and efl directories.
3380
3381 2011-02-26  David Levin  <levin@chromium.org>
3382
3383         Reviewed by Darin Adler.
3384
3385         check-webkit-style should check for spaces after periods in comments
3386         https://bugs.webkit.org/show_bug.cgi?id=55253
3387
3388         * Scripts/webkitpy/style/checkers/cpp.py: Added the check.
3389         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests
3390           and fixed the name of one related test.
3391
3392 2011-02-26  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3393
3394         Reviewed by Andreas Kling.
3395
3396         Make it possible to test the targetdensity-dpi support
3397         https://bugs.webkit.org/show_bug.cgi?id=55142
3398
3399         Test the viewport meta tag feature targetdensity-dpi by
3400         adding extra arguments to dumpConfigurationForViewport
3401
3402         Add the new arguments to the shared header and all
3403         implementation.
3404
3405         * DumpRenderTree/LayoutTestController.cpp:
3406         (dumpConfigurationForViewportCallback):
3407         * DumpRenderTree/LayoutTestController.h:
3408         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3409         (LayoutTestController::dumpConfigurationForViewport):
3410         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3411         (LayoutTestController::dumpConfigurationForViewport):
3412         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3413         (LayoutTestController::dumpConfigurationForViewport):
3414         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3415         (LayoutTestController::dumpConfigurationForViewport):
3416         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3417         (LayoutTestController::dumpConfigurationForViewport):
3418         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3419
3420 2011-02-26  Sheriff Bot  <webkit.review.bot@gmail.com>
3421
3422         Unreviewed, rolling out r79764.
3423         http://trac.webkit.org/changeset/79764
3424         https://bugs.webkit.org/show_bug.cgi?id=55295
3425
3426         "broke Chromium builds" (Requested by rniwa on #webkit).
3427
3428         * DumpRenderTree/chromium/TestShell.cpp:
3429         (TestShell::resetTestController):
3430         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3431         (resetDefaultsToConsistentValues):
3432         * DumpRenderTree/mac/DumpRenderTree.mm:
3433         (resetWebViewToConsistentStateBeforeTesting):
3434         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3435         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
3436         * DumpRenderTree/win/DumpRenderTree.cpp:
3437         (resetWebViewToConsistentStateBeforeTesting):
3438         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3439         (WTR::InjectedBundlePage::reset):
3440
3441 2011-02-26  Yongjun Zhang  <yongjun_zhang@apple.com>
3442
3443         Reviewed by David Kilzer.
3444
3445         https://bugs.webkit.org/show_bug.cgi?id=48781
3446
3447         Add a resource load delegate method to query if WebCore should paint the default broken image for failed images.
3448
3449         Add a new resource load client method (shouldPaintBrokenImage).  WebKit client can decide if WebCore
3450         should paint the default broken image when an image fails to load or decode.
3451
3452         * DumpRenderTree/LayoutTestController.cpp:
3453         (LayoutTestController::LayoutTestController):
3454         (setShouldPaintBrokenImageCallback):
3455         (LayoutTestController::staticFunctions):
3456         (LayoutTestController::setShouldPaintBrokenImage):
3457         * DumpRenderTree/LayoutTestController.h:
3458         (LayoutTestController::shouldPaintBrokenImage):
3459         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
3460         (-[ResourceLoadDelegate webView:shouldPaintBrokenImageForURL:]):
3461
3462 2011-02-26  Vsevolod Vlasov  <vsevik@chromium.org>
3463
3464         Reviewed by Pavel Feldman.
3465
3466         DumpRenderTree should reset frame opener between tests.
3467         https://bugs.webkit.org/show_bug.cgi?id=54874
3468
3469         Added clearOpener() calls between tests.
3470         Some tests are using window.open() to change current window location.
3471         This changes window.opener property whose nullity is checked before
3472         showing xml viewer.
3473
3474         * DumpRenderTree/chromium/TestShell.cpp:
3475         (TestShell::resetTestController):
3476         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3477         (resetDefaultsToConsistentValues):
3478         * DumpRenderTree/mac/DumpRenderTree.mm:
3479         (resetWebViewToConsistentStateBeforeTesting):
3480         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3481         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
3482         * DumpRenderTree/win/DumpRenderTree.cpp:
3483         (resetWebViewToConsistentStateBeforeTesting):
3484         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3485         (WTR::InjectedBundlePage::reset):
3486
3487 2011-02-25  Lukasz Slachciak  <l.slachciak@samsung.com>
3488
3489         Reviewed by Kenneth Rohde Christiansen.
3490
3491         [EFL] Added EWebLauncher command line option to turn on/off frame flattening
3492         https://bugs.webkit.org/show_bug.cgi?id=54809
3493
3494         * EWebLauncher/main.c: Handling -f option added.
3495         (on_key_down):
3496         (browserCreate):
3497         (main):
3498
3499 2011-02-25  Sheriff Bot  <webkit.review.bot@gmail.com>
3500
3501         Unreviewed, rolling out r79324.
3502         http://trac.webkit.org/changeset/79324
3503         https://bugs.webkit.org/show_bug.cgi?id=55260
3504
3505         Leopard Debug is once again running out of address space while
3506         linking (Requested by aroben on #webkit).
3507
3508         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
3509         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3510
3511 2011-02-25  Tony Chang  <tony@chromium.org>
3512
3513         Reviewed by James Robinson.
3514
3515         Clean up temp files left by crashing DRTs on chromium-win
3516         https://bugs.webkit.org/show_bug.cgi?id=55182
3517
3518         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3519         * BuildSlaveSupport/chromium/remove-crash-logs: Added.
3520
3521 2011-02-25  Adam Roben  <aroben@apple.com>
3522
3523         Double-check that modifying the registry worked
3524
3525         On Windows Vista/7 with UAC enabled, regtool will fail to modify the registry, but it will
3526         still return a successful exit code. So we double-check here that the value we tried to
3527         write to the registry was really written.
3528
3529         Fixes <http://webkit.org/b/55227> old-run-webkit-tests falsely claims to be saving crash
3530         logs on Windows Vista/7
3531
3532         Reviewed by Darin Adler.
3533
3534         * Scripts/old-run-webkit-tests:
3535         (writeRegistryString): After trying to write the string value, check that it was really
3536         written.
3537
3538 2011-02-25  Adam Roben  <aroben@apple.com>
3539
3540         Set the 32-bit post-mortem debugger on 64-bit OSes
3541
3542         The post-mortem debugger is controlled by some registry values in
3543         HKLM\SOFTWARE\Microsoft\Windows NT\CurrentVersion\AeDebug. On 64-bit OSes, you can either
3544         set the values in that key, which will be used for 64-bit apps, or in the equivalent key
3545         under Wow6432Node, which will be used for 32-bit apps. Since DumpRenderTree and
3546         WebKitTestRunner are 32-bit, we want to use the latter location.
3547
3548         Fixes <http://webkit.org/b/55225> old-run-webkit-tests sets the post-mortem debugger for
3549         64-bit apps, but should set it for 32-bit apps instead
3550
3551         Reviewed by Darin Adler.
3552
3553         * Scripts/old-run-webkit-tests:
3554         (readRegistryString):
3555         (writeRegistryString):
3556         Pass --wow32 to regtool so it will get/set values beneath Wow6432Node, which is where
3557         Windows looks for the post-mortem debugger values when a 32-bit app crashes on a 64-bit OS.
3558         Passing --wow32 on a 32-bit OS will not have any effect.
3559
3560 2011-02-25  Adam Roben  <aroben@apple.com>
3561
3562         Clean up code to set up crash log saving on Windows
3563
3564         Fixes <http://webkit.org/b/55224> old-run-webkit-test's Windows registry code is ugly
3565
3566         Reviewed by David Kilzer.
3567
3568         * Scripts/old-run-webkit-tests:
3569         (readRegistryString):
3570         (writeRegistryString):
3571         Moved code to read strings from and write strings to the registry here...
3572
3573         (setUpWindowsCrashLogSaving): ...from here.
3574
3575 2011-02-25  Adam Roben  <aroben@apple.com>
3576
3577         Work around Cygwin's crash-suppression behavior
3578
3579         Cygwin calls ::SetErrorMode(SEM_FAILCRITICALERRORS), which any processes it launches will
3580         inherit. This is bad for testing/debugging, as it causes the post-mortem debugger not to be
3581         invoked. (Cygwin does this because it makes crashes more UNIX-y.) We reset the error mode
3582         when our test apps launch to work around Cygwin's behavior.
3583
3584         Fixes <http://webkit.org/b/55222> Test apps crash silently (without invoking post-mortem
3585         debugger) when launched from Cygwin 1.7
3586
3587         Reviewed by Darin Adler.
3588
3589         * DumpRenderTree/win/DumpRenderTree.cpp:
3590         (main):
3591         * TestWebKitAPI/win/main.cpp:
3592         (main):
3593         * WebKitAPITest/main.cpp:
3594         (main):
3595         * WebKitTestRunner/win/TestControllerWin.cpp:
3596         (WTR::TestController::platformInitialize):
3597         Call ::SetErrorMode(0) to undo Cygwin's folly.
3598
3599 2011-02-24  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
3600
3601         Reviewed by Andreas Kling.
3602
3603         [Qt] Revert the support for QNAM affined to a different thread.
3604         https://bugs.webkit.org/show_bug.cgi?id=55149
3605
3606         Qt 4.8 will have QNAM use its own thread internally by default,
3607         no need to keep this complexity in WebKit.
3608
3609         This mainly reverts:
3610         http://trac.webkit.org/changeset/73710
3611         http://trac.webkit.org/changeset/73712
3612
3613         * QtTestBrowser/launcherwindow.cpp:
3614         (LauncherWindow::~LauncherWindow):
3615         (LauncherWindow::initializeView):
3616         (LauncherWindow::createChrome):
3617         * QtTestBrowser/launcherwindow.h:
3618         (WindowOptions::WindowOptions):
3619         * QtTestBrowser/webpage.cpp:
3620         (WebPage::WebPage):
3621         * QtTestBrowser/webpage.h:
3622
3623 2011-02-24  Adam Barth  <abarth@webkit.org>
3624
3625         Reviewed by Eric Seidel.
3626
3627         Add a script for creating gypi files
3628         https://bugs.webkit.org/show_bug.cgi?id=55113
3629
3630         This is a trivial script to create gypi files from the source code in
3631         the current directory.
3632
3633         * Scripts/make-gypi: Added.
3634
3635 2011-02-24  Sheriff Bot  <webkit.review.bot@gmail.com>
3636
3637         Unreviewed, rolling out r79628.
3638         http://trac.webkit.org/changeset/79628
3639         https://bugs.webkit.org/show_bug.cgi?id=55195
3640
3641         "broke chromium win tests" (Requested by dpranke on #webkit).
3642
3643         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3644         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
3645
3646 2011-02-24  Dirk Pranke  <dpranke@chromium.org>
3647
3648         Reviewed by Mihai Parparita.
3649
3650         rebaseline-chromium-webkit-tests can't handle GPU variants
3651         https://bugs.webkit.org/show_bug.cgi?id=55002
3652
3653         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
3654         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
3655
3656 2011-02-24  Dirk Pranke  <dpranke@chromium.org>
3657
3658         Reviewed by Mihai Parparita.
3659
3660         nrwt: log command used to start web server to --verbose
3661
3662         https://bugs.webkit.org/show_bug.cgi?id=55188
3663
3664         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
3665         * Scripts/webkitpy/layout_tests/port/http_server.py:
3666
3667 2011-02-24  Victoria Kirst  <vrk@google.com>
3668
3669         Reviewed by Mihai Parparita.
3670
3671         [chromium] Move media-file.js and video-test.js back to media/ for UILayoutTests
3672         https://bugs.webkit.org/show_bug.cgi?id=55089
3673
3674         This adds an alias into the media/ directory so that http/tests/media
3675         tests can access the media resources when running in an httpd process.
3676
3677         * Scripts/webkitperl/httpd.pm:
3678         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
3679         * Scripts/webkitpy/layout_tests/port/http_server.py:
3680
3681 2011-02-24  Dirk Pranke  <dpranke@chromium.org>
3682
3683         Reviewed by Mihai Parparita.
3684
3685         nrwt: enable multiple processes by default on Chromium Win.
3686
3687         https://bugs.webkit.org/show_bug.cgi?id=55163
3688
3689         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3690         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
3691
3692 2011-02-24  Sam Weinig  <sam@webkit.org>
3693
3694         Attempt to fix Qt.
3695
3696         * WebKitTestRunner/TestInvocation.cpp:
3697
3698 2011-02-24  James Robinson  <jamesr@chromium.org>
3699
3700         Unreviewed, rolling out r79598.
3701         http://trac.webkit.org/changeset/79598
3702         https://bugs.webkit.org/show_bug.cgi?id=55089
3703
3704         Appears to be causing trouble with httpd on windows
3705
3706         * Scripts/webkitperl/httpd.pm:
3707         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
3708         * Scripts/webkitpy/layout_tests/port/http_server.py:
3709
3710 2011-02-24  Sam Weinig  <sam@webkit.org>
3711
3712         Reviewed by Darin Adler.
3713
3714         Add basic pixel testing support to WebKitTestRunner
3715         https://bugs.webkit.org/show_bug.cgi?id=55161
3716
3717         * Scripts/old-run-webkit-tests:
3718         Don't print color space information when using WebKitTestRunner since
3719         we don't need to change the screen.
3720
3721         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3722         (WTR::InjectedBundle::initialize):
3723         Add call to initializePlatformDefaults.
3724         
3725         (WTR::InjectedBundle::done):
3726         Return a dictionary on completion with both the text output and pixel dump override.
3727
3728         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3729         Add declaration for initializePlatformDefaults.
3730
3731         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3732         (WTR::LayoutTestController::LayoutTestController):
3733         (WTR::LayoutTestController::dumpAsText):