c6c5c461e8a5b8adc6a7cdac7b3bd25062a21938
[WebKit.git] / Tools / ChangeLog
1 2011-02-04  Adam Roben  <aroben@apple.com>
2
3         Link to Mac crash logs from results.html
4
5         Fixes <http://webkit.org/b/14861> run-webkit-tests should link to Mac crash logs in
6         results.html
7
8         Reviewed by David Kilzer.
9
10         * Scripts/old-run-webkit-tests:
11         (captureSavedCrashLog): Added a case for Apple's Mac port. We get the crash log out of
12         ~/Library/Logs/CrashReporter, and wait for ReportCrash to exit before trying to get the log.
13
14 2011-02-03  Maciej Stachowiak  <mjs@apple.com>
15
16         Reviewed by Dan Bernstein.
17
18         WebKit2: Need WebKit2 equivalent of WebResourceLoadDelegate::willSendRequest in the Bundle
19         https://bugs.webkit.org/show_bug.cgi?id=52897
20         <rdar://problem/8898294>
21
22         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
23         (WTR::InjectedBundlePage::InjectedBundlePage):
24         (WTR::InjectedBundlePage::willSendRequestForFrame):
25         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
26
27 2011-02-03  Ivan Krstić  <ike@apple.com>
28
29         Unreviewed.
30
31         Adding myself to committers.py.
32
33         * Scripts/webkitpy/common/config/committers.py:
34
35 2011-02-03  James Kozianski  <koz@chromium.org>
36
37         Reviewed by Dimitri Glazkov.
38
39         Add navigator.registerProtocolHandler behind a flag.
40         https://bugs.webkit.org/show_bug.cgi?id=52609
41
42         * Scripts/build-webkit:
43
44 2011-02-03  Hayato Ito  <hayato@chromium.org>
45
46         Reviewed by Eric Seidel.
47
48         [NRWT] Remove TestArgs class, which is wrongly used.
49
50         https://bugs.webkit.org/show_bug.cgi?id=53063
51
52         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
53         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
54         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
55         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
56         * Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py:
57         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
58
59 2011-02-03  Andrew Wason  <rectalogic@rectalogic.com>
60
61         Reviewed by Kenneth Russell.
62
63         Change ENABLE_3D_CANVAS to ENABLE_WEBGL
64         https://bugs.webkit.org/show_bug.cgi?id=53714
65
66         * Scripts/build-webkit: change --3d-canvas build option
67           to set ENABLE_WEBGL
68
69 2011-02-03  Hayato Ito  <hayato@chromium.org>
70
71         Reviewed by Tony Chang.
72
73         [NRWT] Introduces Input/Output class used by base.Driver into port/base.py and
74         move _run_single_test() and _process_output() functions from
75         dump_render_tree_thread.py to a single_test_runner.py as an individual module.
76
77         This is clean up and acts as a preparation for elimination of test_types/*
78         classes. These classes will move to the single_test_runner module introduced
79         in this patch.
80
81         https://bugs.webkit.org/show_bug.cgi?id=53004
82
83         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
84         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py: Added.
85         * Scripts/webkitpy/layout_tests/layout_package/test_input.py:
86         * Scripts/webkitpy/layout_tests/layout_package/test_output.py: Removed.
87         * Scripts/webkitpy/layout_tests/port/base.py:
88         * Scripts/webkitpy/layout_tests/port/chromium.py:
89         * Scripts/webkitpy/layout_tests/port/dryrun.py:
90         * Scripts/webkitpy/layout_tests/port/test.py:
91         * Scripts/webkitpy/layout_tests/port/webkit.py:
92         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
93         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
94         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
95
96 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
97
98         Unreviewed, build fix.
99
100         Delete a line that was accidentally missed in r77586; without it
101         there is still a race between the two threads.
102
103         https://bugs.webkit.org/show_bug.cgi?id=51572
104
105         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
106
107 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
108
109         Reviewed by Tony Chang.
110
111         nrwt: handle "broken pipe" notifications from DRT more cleanly.
112
113         https://bugs.webkit.org/show_bug.cgi?id=52927
114
115         * Scripts/webkitpy/layout_tests/port/server_process.py:
116         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
117
118 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
119
120         Reviewed by Kenneth Russell.
121
122         Update, resubmit change to bug 51572. I think the race that was
123         fixed in r76703 caused the hang that caused us to roll this
124         patch out before, so I'd like to try again.
125
126         https://bugs.webkit.org/show_bug.cgi?id=51572
127
128         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
129         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
130
131 2011-02-03  Daniel Cheng  <dcheng@chromium.org>
132
133         Unreviewed.
134
135         Adding myself to committers.py.
136
137         * Scripts/webkitpy/common/config/committers.py:
138
139 2011-02-03  Adam Roben  <aroben@apple.com>
140
141         Include the crashing function in the link to a crash log
142
143         Fixes <http://webkit.org/b/53739> Crash log links in results.html should include the
144         function that crashed
145
146         Reviewed by David Kilzer.
147
148         * Scripts/old-run-webkit-tests:
149         (crashLocation): Added. Returns the location of the crash.
150         (linksForErrorTest): Include the crash location in the link text for the crash log, if one
151         could be determined.
152
153 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
154
155         Unreviewed, build fix.
156
157         Actually make the changes suggested by Mihai in his review
158         of bug 53720 :(
159
160         https://bugs.webkit.org/show_bug.cgi?id=53720
161
162         * Scripts/webkitpy/layout_tests/port/test_files.py:
163         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
164
165 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
166
167         Reviewed by Mihai Parparita.
168
169         new-run-webkit-tests: Fix bug introduced in r77434 that was
170         causing us to run the canvas GPU tests on the Mac GPU port. This
171         bug revealed that we were not setting the port.name() field
172         properly in many cases, so I've cleaned up all of that code, and
173         removed a few comments about "version-specific" GPU ports that
174         don't exist and just confused things.
175
176         Testing also revealed that port.abspath_for_test() wasn't
177         normalizing paths on Windows properly, so I fixed that as well.
178
179         https://bugs.webkit.org/show_bug.cgi?id=53719
180
181         * Scripts/webkitpy/layout_tests/port/base.py:
182         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
183         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
184
185 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
186
187         Reviewed by Mihai Parparita.
188
189         new-run-webkit-tests: fix normalization of paths on windows when gathering files
190
191         r77434 introduced a bug that was causing the test expectations
192         for the GPU ports to not be treated properly. It turns out that
193         when we gathered the list of test files on Windows, we would
194         return paths of the form "c:\LayoutTests/fast/canvas", and the
195         mixture of backslashes and forward slashes was confusing things.
196
197         This patch normalizes all of the filenames returned from
198         test_files.find(), and adds better tests for this (fixing a
199         couple of other bugs found in the meantime).
200
201         https://bugs.webkit.org/show_bug.cgi?id=53720
202
203         * Scripts/webkitpy/layout_tests/port/test.py:
204         * Scripts/webkitpy/layout_tests/port/test_files.py:
205         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
206
207 2011-02-03  Adam Roben  <aroben@apple.com>
208
209         Add links to Windows crash logs in results.html
210
211         Fixes <http://webkit.org/b/53718> run-webkit-tests should link to Windows crash logs in
212         results.html
213
214         Reviewed by David Kilzer.
215
216         * Scripts/old-run-webkit-tests:
217         (top level): Added $crashLogTag and $windowsCrashLogFilePrefix (which came from
218         createDebuggerCommandFile).
219         (testCrashedOrTimedOut): If the test crashed, capture any saved crash log after the dump
220         tool has exited.
221         (captureSavedCrashLog): Added. Finds the crash log for the test that just crashed and moves
222         it into the test results directory tree. Only implemented for Cygwin currently.
223         (findNewestFileMatchingGlob): Added. Does what it says.
224         (htmlForResultsSection): Only link to files that exist.
225         (linksForErrorTest): Add a link to the crash log.
226         (deleteExpectedAndActualResults): Delete any old crash log for this test.
227         (createDebuggerCommandFile): Use the new $windowsCrashLogFilePrefix constant instead of
228         hardcoding it here.
229
230 2011-02-03  Adam Roben  <aroben@apple.com>
231
232         Tell the debugger the path to the WebKit source tree when saving a crash log
233
234         This allows the debugger to include the crashing line of code in the log.
235
236         Fixes <http://webkit.org/b/53678> Crash logs from buildslaves don't show the crashing line
237         of code
238
239         Reviewed by Sam Weinig.
240
241         * Scripts/old-run-webkit-tests:
242         (createDebuggerCommandFile): Added. Saves commands that we'd like the debugger to run to a
243         file and returns the path to that file. The commands we pass came from
244         setUpWindowsCrashLogSaving, but I've added a .srcpath command to tell the debugger where the
245         WebKit source code lives.
246         (setUpWindowsCrashLogSaving): Instead of specifying the commands directly on the command
247         line using -c, save them to a file and specify the path to that file using -cf. This works
248         around what is presumably a bug in Windows's command line parsing, where having multiple
249         quoted paths in the debugger commands causes the post-mortem debugger not to be invoked at
250         all. Also pulled the options we pass to the debugger out into a list that is then join()ed
251         together to make them easier to modify in the future.
252
253 2011-02-02  Sam Weinig  <sam@webkit.org>
254
255         Reviewed by Anders Carlsson.
256
257         Add notification of the end of a rubber band.
258         <rdar://problem/8940648>
259
260         * MiniBrowser/mac/BrowserWindowController.m:
261         (-[BrowserWindowController awakeFromNib]):
262         * WebKitTestRunner/TestController.cpp:
263         (WTR::TestController::createOtherPage):
264         (WTR::TestController::initialize):
265         Stub out the new WKUIClient function.
266
267 2011-02-03  Gabor Rapcsanyi  <rgabor@webkit.org>
268
269         Unreviewed.
270
271         Adding myself to committers.py.
272
273         * Scripts/webkitpy/common/config/committers.py:
274
275 2011-02-03  Balazs Kelemen  <kbalazs@webkit.org>
276
277         Reviewed by Csaba Osztrogonác.
278
279         [Qt][WK2] MiniBrowser's window size should be 800x600
280         https://bugs.webkit.org/show_bug.cgi?id=53670
281
282         Make layout test failure debugging easier.
283         * MiniBrowser/qt/BrowserWindow.cpp:
284         (BrowserWindow::BrowserWindow):
285
286 2011-02-02  Andy Estes  <aestes@apple.com>
287
288         Reviewed by Mark Rowe.
289
290         'update-webkit' should handle OpenSource and Internal using different
291         VCSs.
292
293         * Scripts/update-webkit: Re-check the VCS type when updating Apple's
294         Internal directory.
295
296 2011-02-02  Dirk Pranke  <dpranke@chromium.org>
297
298         Reviewed by Mihai Parparita.
299
300         new-run-webkit-tests: hardcode the directories to scan for tests
301         for GPU bots instead of SKIPping them. See bug 53562 for some
302         context, but we will now hard-code the list of directories to
303         use by default instead of skipping over directories in the
304         expectations file. We do this so that we will be able to merge
305         the expectations files without getting conflicting SKIP
306         directives. Note that this change will reduce the # of tests
307         being run on the Mac GPU bots, because we're accidentally
308         including some today.
309
310         https://bugs.webkit.org/show_bug.cgi?id=53631
311
312         * Scripts/webkitpy/layout_tests/port/base.py:
313         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
314         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
315
316 2011-02-02  Sam Weinig  <sam@webkit.org>
317
318         Reviewed by Beth Dakin.
319
320         Add ChromeClient function to paint custom overhang areas.
321         https://bugs.webkit.org/show_bug.cgi?id=53639
322
323         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
324         (WTR::InjectedBundlePage::InjectedBundlePage):
325         Stub out new callback.
326
327 2011-02-02  Dirk Pranke  <dpranke@chromium.org>
328
329         Reviewed by Tony Chang.
330
331         new-run-webkit-tests: support chromium code paths in mock_drt
332
333         https://bugs.webkit.org/show_bug.cgi?id=53471
334
335         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
336         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
337
338 2011-02-02  Adam Klein  <adamk@chromium.org>
339
340         Reviewed by Tony Chang.
341
342         Update new-run-webkit-tests --chromium to put output under Source/...
343         https://bugs.webkit.org/show_bug.cgi?id=53612
344
345         * BuildSlaveSupport/test-result-archive:
346         * Scripts/webkitpy/layout_tests/port/chromium.py:
347
348 2011-01-28  Tony Chang  <tony@chromium.org>
349
350         Reviewed by Eric Seidel.
351
352         [chromium] remove --use-test-shell from NRWT
353         https://bugs.webkit.org/show_bug.cgi?id=53346
354
355         I've already started removing some of the bindings like eventSender so
356         this already doesn't work isn't useful.  Also updated some comments to
357         refer to DRT instead of test_shell.
358
359         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
360         * Scripts/webkitpy/layout_tests/port/chromium.py:
361         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
362         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
363         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
364         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
365         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
366         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
367
368 2011-02-02  Steve Lacey  <sjl@chromium.org>
369
370         Reviewed by Eric Carlson.
371
372         Implement basic media statistics on media elements.
373         https://bugs.webkit.org/show_bug.cgi?id=53322
374
375         * Scripts/build-webkit:
376
377 2011-02-02  Kevin Ollivier  <kevino@theolliviers.com>
378
379         [wx] Build fixes for wxWebKit.
380
381         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
382         (LayoutTestController::setSerializeHTTPLoads):
383         * wx/browser/wscript:
384         * wx/build/build_utils.py:
385         * wx/build/settings.py:
386
387 2011-02-01  Dirk Pranke  <dpranke@chromium.org>
388
389         Reviewed by Mihai Parparita.
390
391         new-run-webkit-tests: stop skipping so many tests
392
393         r77163 introduced a regression where we weren't resetting test
394         expectations properly and were skipping too many tests as a
395         result. This patch fixes that and adds a test for it.
396
397         https://bugs.webkit.org/show_bug.cgi?id=53551
398
399         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
400         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
401
402 2011-02-01  Dirk Pranke  <dpranke@chromium.org>
403
404         Reviewed by Tony Chang.
405
406         new-run-webkit-tests: add first stub of test_runner2. This
407         will add support for the 'inline', 'threads', and 'processes'
408         flags to --worker-model, but for now the implementatios just
409         fall back on the old ones.
410
411         https://bugs.webkit.org/show_bug.cgi?id=53157
412
413         * Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
414         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
415
416 2011-02-01  Mihai Parparita  <mihaip@chromium.org>
417
418         Reviewed by James Robinson.
419
420         [Chromium] run-chromium-webkit-unit-tests looks for binaries in the wrong place
421         https://bugs.webkit.org/show_bug.cgi?id=53522
422
423         * Scripts/run-chromium-webkit-unit-tests:
424
425 2011-02-01  Adam Barth  <abarth@webkit.org>
426
427         Reviewed by Mihai Parparita.
428
429         Using Control-C to cancel webkit-patch or other python tools causes
430         unpleasant traceback console spew
431         https://bugs.webkit.org/show_bug.cgi?id=53462
432
433         Catch the exception and don't print the stack trace.
434
435         * Scripts/webkit-patch:
436
437 2011-02-01  Scott Cameron  <sccameron@rim.com>
438
439         Reviewed by Daniel Bates.
440
441         Use Windows format for MinGW HTTPD path.
442         https://bugs.webkit.org/show_bug.cgi?id=53503
443
444         * Scripts/webkitperl/httpd.pm:
445           - Use single-quotes around MySys value for $httpdPath in getHTTPDPath()
446             so that we don't have to escape the space characters in the path. Also,
447             changed path to Windows-style path and removed FIXME comment.
448
449 2011-02-01  Balazs Kelemen  <kbalazs@webkit.org>
450
451         Reviewed by Andreas Kling.
452
453         [Qt][WK2] Add a way to use shared process model in MiniBrowser
454         https://bugs.webkit.org/show_bug.cgi?id=53090
455
456         * MiniBrowser/qt/BrowserView.cpp:
457         (BrowserView::BrowserView): Removed the m_context member.
458         From now the context is guaranteed to be non-null and we
459         don't need to store that in the object.
460         * MiniBrowser/qt/BrowserView.h:
461         * MiniBrowser/qt/BrowserWindow.cpp:
462         Added static bool to determine that new windows need to be
463         created with their own context or not. Use the same context
464         and web process by default to be inilne with the other ports.
465         (BrowserWindow::BrowserWindow):
466         (BrowserWindow::newWindow):
467         * MiniBrowser/qt/BrowserWindow.h:
468         * MiniBrowser/qt/main.cpp:
469         (main): Added command line switch to be able to use the
470         non-shared process model. Simplify the handling of the command line
471         switches a little bit.
472
473 2011-02-01  Zoltan Horvath  <zoltan@webkit.org>
474
475         Reviewed by Andreas Kling.
476
477         [Qt] Add Window menu and Toggle FullScreen action to MiniBrowser.
478         https://bugs.webkit.org/show_bug.cgi?id=53491
479
480         * MiniBrowser/qt/BrowserWindow.cpp:
481         (BrowserWindow::BrowserWindow):
482         (BrowserWindow::toggleFullScreenMode):
483         * MiniBrowser/qt/BrowserWindow.h:
484
485 2011-02-01  Zoltan Horvath  <zoltan@webkit.org>
486
487         Reviewed by Andreas Kling.
488
489         [Qt] Add Toggle Frame Flattening, Auto Load Images and Disable JavaScript actions to MiniBrowser.
490         https://bugs.webkit.org/show_bug.cgi?id=53489
491
492         Add Toggle Frame Flattening action to Develop menu. Add Auto Load Images and Disable JavaScript actions
493         to Settings menu.
494
495         * MiniBrowser/qt/BrowserWindow.cpp:
496         (BrowserWindow::BrowserWindow):
497         (BrowserWindow::toggleFrameFlattening):
498         (BrowserWindow::toggleDisableJavaScript):
499         (BrowserWindow::toggleAutoLoadImages):
500         * MiniBrowser/qt/BrowserWindow.h:
501
502 2011-01-31  Mihai Parparita  <mihaip@chromium.org>
503
504         Reviewed by Tony Chang.
505
506         [Chromium] Switch chromium-mac to use ChromiumDriver
507         https://bugs.webkit.org/show_bug.cgi?id=53461
508         
509         For the sake of consistency with the other Chromium platforms (and so
510         that chromium-mac picks up special flags like --enable-hardware-gpu),
511         switch chromium-mac from the WebKitDriver to ChromiumDriver.
512
513         * Scripts/webkitpy/layout_tests/port/chromium.py:
514
515 2011-01-31  Dirk Pranke  <dpranke@chromium.org>
516
517         Reviewed by Mihai Parparita.
518
519         The current modifier parsing code in test_expectations is
520         fragile and hard-coded, so it's not easy to understand the logic
521         or easily add new types of modifiers (like GPU vs. CPU testing
522         for graphics tests, or 32-bit vs. 64-bit differences).
523
524         This is the first of two patches that will add in more generic
525         support and then eliminate the GPU-specific test expectations
526         files for Chromium.
527
528         This patch adds two standalone objects for handling modifiers. The
529         rules for interpreting modifiers, precedence, and conflicts are
530         given in the docstring to the ModifierMatcher class, which
531         returns ModifierMatchResult objects.
532         
533         This patch also adds routines to the Port interface and a
534         default set of values in the base object, in order to obtain the
535         values needed on a given test run. These values are then passed
536         to the expectation parser. This also allows us to clean up the
537         logic used to lint all of the different configurations in a
538         single test_expectations.txt file.
539
540         The next patch will merge in the separate GPU expectations file.
541
542         https://bugs.webkit.org/show_bug.cgi?id=51222
543
544         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
545         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
546         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
547         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
548         * Scripts/webkitpy/layout_tests/port/base.py:
549         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
550         * Scripts/webkitpy/layout_tests/port/chromium.py:
551         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
552         * Scripts/webkitpy/layout_tests/port/test.py:
553         * Scripts/webkitpy/layout_tests/port/webkit.py:
554         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
555         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
556         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
557         * Tools/Scripts/webkitpy/style/checkers/test_expectations.py:
558         * Tools/Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
559
560 2011-01-31  Scott Cameron  <sccameron@rim.com>
561
562         Reviewed by Daniel Bates.
563
564         update run-webkit-httpd to be able to launch Apache2.2 in a MSYS environment
565         https://bugs.webkit.org/show_bug.cgi?id=50036
566
567         This will add an Apache2.2 configuration file and modifies scripts to allow
568         running an httpd server in an MSYS environment.
569
570         The default Apache2.2 installation path has been preserved and PHP5 modules disabled
571         in order to allow for simple installation/execution.  Simply install the latest
572         Apache2.2 version with OpenSSL from http://httpd.apache.org/download.cgi#apache22 to
573         be able to execute run-webkit-httpd.
574         
575
576         * Scripts/run-webkit-httpd:
577         * Scripts/webkitperl/httpd.pm:
578
579 2011-01-31  Tony Chang  <tony@chromium.org>
580
581         Reviewed by Eric Seidel.
582
583         mac DRT should report RTL scroll offset relative to top right corner
584         https://bugs.webkit.org/show_bug.cgi?id=53324
585
586         * DumpRenderTree/mac/DumpRenderTree.mm:
587         (dumpFrameScrollPosition):
588
589 2011-01-31  Zoltan Horvath  <zoltan@webkit.org>
590
591         Reviewed by Andreas Kling.
592
593         [Qt] Add Take Screen Shot action to MiniBrowser
594         https://bugs.webkit.org/show_bug.cgi?id=53422
595
596         Add Take Screen Shot action to MiniBrowser's view menu.
597
598         * MiniBrowser/qt/BrowserWindow.cpp:
599         (BrowserWindow::BrowserWindow):
600         (BrowserWindow::screenshot):
601         * MiniBrowser/qt/BrowserWindow.h:
602
603 2011-01-31  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
604
605         Reviewed by Xan Lopez.
606
607         [GTK] REGRESSION:  http/tests/media/video-{cookie,referer}.html failing
608         https://bugs.webkit.org/show_bug.cgi?id=53379
609
610         Remove left over #ifdef's. I thought all of the conditional code
611         had been freed from the condition, but I forgot to check DRT.
612
613         * DumpRenderTree/gtk/DumpRenderTree.cpp:
614         (resetDefaultsToConsistentValues):
615         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
616         (LayoutTestController::setAlwaysAcceptCookies):
617
618 2011-01-30  Dirk Pranke  <dpranke@chromium.org>
619
620         Unreviewed, build fix.
621
622         Fix regression introduced in r77093 - path.rsplit() doesn't
623         take keyword arguments.
624
625         https://bugs.webkit.org/show_bug.cgi?id=53326
626
627         * Scripts/webkitpy/common/system/filesystem_mock.py:
628
629 2011-01-30  Dirk Pranke  <dpranke@chromium.org>
630
631         Reviewed by Mihai Parparita.
632
633         Add more unit tests for rebaseline-chromium-webkit-tests. This
634         change involves restructuring a bunch of r-c-w-t code to make it
635         more testable as well. We also add wrapper classes for handling
636         testing zip files and fetching URLs.
637
638         https://bugs.webkit.org/show_bug.cgi?id=53040
639
640         * Scripts/webkitpy/common/system/urlfetcher.py:
641         * Scripts/webkitpy/common/system/urlfetcher_mock.py:
642         * Scripts/webkitpy/common/system/zipfileset_mock.py:
643         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
644         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
645         * Scripts/webkitpy/tool/mocktool.py:
646
647 2011-01-30  Dirk Pranke  <dpranke@chromium.org>
648
649         Reviewed by Eric Seidel.
650
651         Clean up of the filesystem-related modules used in webkitpy.
652         I've added relpath() to the filesystem interface, modified
653         ospath.relpath() so that it could work with the filesystem
654         interface, and modified the fileset* routines to use the
655         filesystem interface consistently.
656
657         This patch also adds a close() routine to the fileset routines
658         to indicate that the caller is done with the fileset. This
659         allows zipfileset to clean up after itself when it creates
660         tempfiles to store downloads.
661
662         https://bugs.webkit.org/show_bug.cgi?id=53326
663
664         * Scripts/webkitpy/common/system/directoryfileset.py:
665         * Scripts/webkitpy/common/system/fileset.py:
666         * Scripts/webkitpy/common/system/filesystem.py:
667         * Scripts/webkitpy/common/system/filesystem_mock.py:
668         * Scripts/webkitpy/common/system/filesystem_unittest.py:
669         * Scripts/webkitpy/common/system/ospath.py:
670         * Scripts/webkitpy/common/system/zipfileset.py:
671         * Scripts/webkitpy/common/system/zipfileset_unittest.py:
672
673 2011-01-30  Balazs Kelemen  <kbalazs@webkit.org>
674
675         Reviewed by Csaba Osztrogonác.
676
677         [Qt][WK2]REGRESSION (r76991): Fix build errors
678         https://bugs.webkit.org/show_bug.cgi?id=53400
679
680         Revert the temporary build fix (http://trac.webkit.org/changeset/77088)
681         and remove WebKit2Prefix.h from the build.
682         * MiniBrowser/qt/MiniBrowser.pro:
683
684 2011-01-30  Csaba Osztrogonác  <ossy@webkit.org>
685
686         Unreviewed.
687
688         [Qt][WK2] Buildfix.
689
690         * MiniBrowser/qt/MiniBrowser.pro:
691
692 2011-01-28  Simon Fraser  <simon.fraser@apple.com>
693
694         Reviewed by Adam Roben.
695         
696         define NOMINMAX when building ImageDiff, as we do elsewhere.
697
698         Add various clampToInt() methods to MathExtras.h
699         https://bugs.webkit.org/show_bug.cgi?id=52910
700
701         * DumpRenderTree/win/ImageDiffCommon.vsprops:
702
703 2011-01-28  Maciej Stachowiak  <mjs@apple.com>
704
705         Reviewed by Darin Adler.
706
707         WebKitTestRunner needs layoutTestController.setPOSIXLocale
708         https://bugs.webkit.org/show_bug.cgi?id=42682
709
710         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
711         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
712         (WTR::InjectedBundle::resetLocalSettings):
713         (WTR::InjectedBundle::didReceiveMessage):
714         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
715         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
716         (WTR::LayoutTestController::setPOSIXLocale):
717         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
718
719 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
720  
721          Reviewed by Mihai Parparita.
722  
723          test-webkitpy: fix webkitpy.layout_tests.port.mac_unittest.MacTest.test_skipped_file_paths
724  
725          This patch re-enables this test and changes it to
726          handle all of the mac platform versions, not just the one
727          it is running on.
728  
729          https://bugs.webkit.org/show_bug.cgi?id=53356
730  
731          * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
732  
733 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
734
735         Unreviewed, build fix.
736
737         Take two. The fix in 77023 didn't work, because we were
738         still calling path.abspath_to_uri, which calls _cygpath under
739         the covers, and it appears the cygpath on the bots does
740         something different than it does on my machine. This patch
741         removes the calls to path.abspath_to_uri, so it should be safe.
742         If it doesn't work, I'll roll it out along with r76982 and 77023.
743
744         https://bugs.webkit.org/show_bug.cgi?id=53126
745
746         * Scripts/webkitpy/layout_tests/port/test.py:
747
748 2011-01-28  David Kilzer  <ddkilzer@apple.com>
749
750         <rdar://problem/8930699> build-webkit gives a bogus warning with newer versions of Xcode 
751         <http://webkit.org/b/53353>
752
753         Reviewed by Mark Rowe.
754
755         * Scripts/webkitdirs.pm:
756         (checkRequiredSystemConfig): Check the Xcode marketing version
757         in addition to the DevCoreTools build version before complaining
758         about an old version of Xcode.  Also make the Mac OS X version
759         check use Perl's built-in version string comparitor.
760
761 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
762
763         Unreviewed, build fix.
764
765         Work around breakage on Win 7 Release bot caused by r76982
766         and the fact that windows ports use "file:////" instead of
767         "file:///". Ideally the test code should be isolated from
768         this, but it isn't yet. Will fix properly in a bit.
769
770         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
771
772 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
773
774         Reviewed by Tony Chang.
775
776         new-run-webkit-tests: change worker model values to
777         "old-inline", "old-threads" in preparation for test_runner2 /
778         multiprocessing changes.
779
780         https://bugs.webkit.org/show_bug.cgi?id=53156
781
782         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
783         * Scripts/webkitpy/layout_tests/port/base.py:
784         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
785         * Scripts/webkitpy/layout_tests/port/mac.py:
786         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
787
788 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
789
790         Reviewed by Tony Chang.
791
792         committers.py - add an IRC nickname for dpranke
793         https://bugs.webkit.org/show_bug.cgi?id=53335
794
795         * Scripts/webkitpy/common/config/committers.py:
796
797 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
798
799         Reviewed by Tony Chang.
800
801         new-run-webkit-tests: add a "mock DRT" port implementation
802         and a separate class that emulates what we expect the
803         DumpRenderTree behavior to be.
804
805         This will eventually replace port/dryrun.py and allow us to get
806         better test coverage of the new-run-webkit-tests code as well as
807         a reference for what new-run-webkit-tests expects from DRT.
808
809         This is the first attempt at this, and it is pretty bare-boned. It
810         really only has been tested on the 'mac' port (and a little on
811         the 'chromium-mac' port.
812
813         https://bugs.webkit.org/show_bug.cgi?id=53126
814
815         * Scripts/webkitpy/common/system/filesystem_mock.py:
816         * Scripts/webkitpy/layout_tests/port/dryrun.py:
817         * Scripts/webkitpy/layout_tests/port/factory.py:
818         * Scripts/webkitpy/layout_tests/port/mock_drt.py: Added.
819         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Added.
820         * Scripts/webkitpy/layout_tests/port/test.py:
821
822 2011-01-28  Pratik Solanki  <psolanki@apple.com>
823
824         Unreviewed. Removing .swp file checked in by mistake.
825
826         * Scripts/.webkitdirs.pm.swp: Removed.
827
828 2011-01-28  Pratik Solanki  <psolanki@apple.com>
829
830         Reviewed by David Kilzer.
831
832         Space not necessary for undefined feature
833         https://bugs.webkit.org/show_bug.cgi?id=53317
834
835         * Scripts/build-webkit:
836
837 2011-01-28  Chang Shu  <chang.shu@nokia.com>
838
839         Reviewed by Andreas Kling.
840
841         Reset NetworkAccessManager to clean up credentials from previous tests.
842         This change causes no performance overhead either.
843         https://bugs.webkit.org/show_bug.cgi?id=36688
844
845         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
846         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
847         (WebCore::DumpRenderTree::open):
848         * DumpRenderTree/qt/DumpRenderTreeQt.h:
849
850 2011-01-28  Zoltan Horvath  <zoltan@webkit.org>
851
852         Reviewed by Andreas Kling.
853
854         [Qt] Add Zoom Text Only action to MiniBrowser
855         https://bugs.webkit.org/show_bug.cgi?id=53297
856
857         Add Zoom Text Only action to MiniBrowser's view menu, change zoom levels to avoid unnecessary divides.
858
859         * MiniBrowser/qt/BrowserWindow.cpp:
860         (BrowserWindow::BrowserWindow):
861         (BrowserWindow::zoomIn):
862         (BrowserWindow::zoomOut):
863         (BrowserWindow::resetZoom):
864         (BrowserWindow::toggleZoomTextOnly):
865         (BrowserWindow::applyZoom):
866         * MiniBrowser/qt/BrowserWindow.h:
867
868 2011-01-28  Adam Barth  <abarth@webkit.org>
869
870         Reviewed by Eric Seidel.
871
872         Add webkit-patch roll-chromium-deps
873         https://bugs.webkit.org/show_bug.cgi?id=53288
874
875         This command updates the Source/WebKit/chromium/DEPS file with the
876         last-known good revision of Chromium (or a revision specified on the
877         command line).  I'd eventually like to turn this into a SheriffBot
878         command, but this is the first step.
879
880         This patch somewhat sprawled because I needed to move a bunch of code
881         out of ChangeLog that should never have been there in the first place.
882         Also, I had to fix a bug in MockUser in order to test the new command.
883
884         * Scripts/webkitpy/common/checkout/api.py:
885         * Scripts/webkitpy/common/checkout/changelog.py:
886         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
887         * Scripts/webkitpy/common/checkout/deps.py: Added.
888         * Scripts/webkitpy/common/config/urls.py:
889         * Scripts/webkitpy/tool/commands/__init__.py:
890         * Scripts/webkitpy/tool/commands/download_unittest.py:
891         * Scripts/webkitpy/tool/commands/roll.py: Added.
892         * Scripts/webkitpy/tool/commands/roll_unittest.py: Added.
893         * Scripts/webkitpy/tool/commands/upload_unittest.py:
894         * Scripts/webkitpy/tool/mocktool.py:
895         * Scripts/webkitpy/tool/steps/__init__.py:
896         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py: Added.
897         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
898         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py: Added.
899         * Scripts/webkitpy/tool/steps/suggestreviewers_unittest.py:
900         * Scripts/webkitpy/tool/steps/updatechromiumdeps.py: Added.
901         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
902
903 2011-01-27  Greg Coletta  <greg.coletta@nokia.com>
904
905         Reviewed by Laszlo Gombos.
906
907         Get rid of prefix header dependency for WebKit2 build system
908         https://bugs.webkit.org/show_bug.cgi?id=50174
909
910         Change the style checker so that it enforces config.h include for
911         WebKit2.
912
913         * Scripts/webkitpy/style/checker.py:
914
915 2011-01-27  Maciej Stachowiak  <mjs@apple.com>
916
917         Reviewed by Darin Adler.
918
919         execCommand("Paste") doesn't work in WebKitTestRunner
920         https://bugs.webkit.org/show_bug.cgi?id=52785
921
922         Enable both of the settings needed to allow paste.
923         
924         * WebKitTestRunner/TestController.cpp:
925         (WTR::TestController::resetStateToConsistentValues):
926
927 2011-01-27  Jacob Dinu  <dinu.jacob@nokia.com>
928
929         Reviewed by Andreas Kling.
930
931         [Qt] QtTestBrowser: User input lost when toggling use of QGraphicsView
932         https://bugs.webkit.org/show_bug.cgi?id=48440
933
934         Preserve user input when toggling use of QGraphicsView
935
936         * QtTestBrowser/launcherwindow.cpp:
937         (LauncherWindow::initializeView):
938         (LauncherWindow::loadFinished):
939         * QtTestBrowser/launcherwindow.h:
940         * QtTestBrowser/mainwindow.cpp:
941         (MainWindow::addressUrl):
942         * QtTestBrowser/mainwindow.h:
943
944 2011-01-27  Dirk Pranke  <dpranke@chromium.org>
945
946         Reviewed by Mihai Parparita.
947
948         new-run-webkit-tests: turn off pixel tests correctly by default
949         for webkit-based ports. r70013 (bug 47510) used
950         port.set_option_default() to attempt to set default values, but
951         that didn't work correctly. I have removed set_option_default
952         for now since it was only being used in two places and in three
953         useless unit tests. There is a separate bug open to fix the
954         option parsing (48095), so this workaround is fine for now.
955
956         https://bugs.webkit.org/show_bug.cgi?id=53217
957
958         * Scripts/webkitpy/layout_tests/port/webkit.py:
959         * Scripts/webkitpy/layout_tests/port/base.py:
960         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
961
962 2011-01-27  Balazs Kelemen  <kbalazs@webkit.org>
963
964         Rubber-stamped by Ariya Hidayat.
965
966         Trivial crash fix in WTR.
967
968         * WebKitTestRunner/TestController.cpp:
969         (WTR::TestController::initialize): Increase the size
970         of the vector by one to be able to store the null character.
971
972 2011-01-27  Balazs Kelemen  <kbalazs@webkit.org>
973
974         Reviewed by Csaba Osztrogonác.
975
976         [Qt][WK2] WTR should be initialized in the same way as DRT
977         https://bugs.webkit.org/show_bug.cgi?id=53240
978
979         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
980         (WTR::activateFonts): Added missing initialization steps.
981
982 2011-01-27  Joone Hur <joone.hur@collabora.co.uk>
983
984         Unreviewed. 
985
986         Adding myself to committers.py.
987
988         * Scripts/webkitpy/common/config/committers.py:
989
990 2011-01-27  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
991
992         Reviewed by Csaba Osztrogonác.
993
994         [Qt] [Symbian] Move project files into Source
995         https://bugs.webkit.org/show_bug.cgi?id=52891
996
997         Fix the Symbian build after the project files
998         are moved to Source directory. On Symbian qmake
999         needs to run in the same directory where the main
1000         pro files (WebKit.pro, Tools.pro) are located.
1001
1002         * Scripts/webkitdirs.pm: Change to the directory where the pro file
1003         is located before running qmake for Symbian. Qmake on Symbian
1004         does not properly honor the "-o" option, work it around by setting
1005         the name of the Makefile to bld.inf.
1006
1007 2011-01-27  Zoltan Horvath  <zoltan@webkit.org>
1008
1009         Reviewed by Andreas Kling.
1010
1011         [Qt] Add simple zooming features to MiniBrowser
1012         https://bugs.webkit.org/show_bug.cgi?id=53231
1013
1014         Add View menu and Zoom In, Zoom Out, Zoom Reset actions to MiniBrowser.
1015
1016         * MiniBrowser/qt/BrowserWindow.cpp:
1017         (BrowserWindow::BrowserWindow):
1018         (BrowserWindow::zoomIn):
1019         (BrowserWindow::zoomOut):
1020         (BrowserWindow::resetZoom):
1021         (BrowserWindow::updateUserAgentList):
1022         (BrowserWindow::applyZoom):
1023         * MiniBrowser/qt/BrowserWindow.h:
1024
1025 2011-01-26  Maciej Stachowiak  <mjs@apple.com>
1026
1027         Reviewed by Dan Bernstein.
1028
1029         WebKitTestRunner needs to support layoutTestController.evaluateInWebInspector
1030         https://bugs.webkit.org/show_bug.cgi?id=42319
1031         
1032         Add evaluateInWebInspector and other APIs needed for inspector tests to run.
1033
1034         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1035         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1036         (WTR::LayoutTestController::showWebInspector):
1037         (WTR::LayoutTestController::closeWebInspector):
1038         (WTR::LayoutTestController::evaluateInWebInspector):
1039         (WTR::LayoutTestController::setTimelineProfilingEnabled):
1040         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1041         * WebKitTestRunner/TestInvocation.cpp:
1042         (WTR::shouldOpenWebInspector):
1043         (WTR::TestInvocation::invoke):
1044         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
1045
1046 2011-01-26  Martin Robinson  <mrobinson@igalia.com>
1047
1048         Reviewed by Xan Lopez.
1049
1050         [GTK] Pixel dumps do not include scrollbars in output images
1051         https://bugs.webkit.org/show_bug.cgi?id=53216
1052
1053         Show scrollbars in pixel dumps. This will fix pixel dumps for tests
1054         that have scrollbars.
1055
1056         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
1057         (createBitmapContextFromWebView): Take the snapshot of the containing GtkScrolledWindow
1058         instead of the web view itself.
1059
1060 2011-01-26  Dirk Pranke  <dpranke@chromium.org>
1061
1062         Reviewed by Mihai Parparita.
1063
1064         Fix regression introduced in r76322 ... new-run-webkit-tests
1065         was attempting to save the image diff output as a UTF-8-encoded
1066         file.
1067
1068         https://bugs.webkit.org/show_bug.cgi?id=53210
1069
1070         * Scripts/webkitpy/layout_tests/port/webkit.py:
1071
1072 2011-01-26  Sheriff Bot  <webkit.review.bot@gmail.com>
1073
1074         Unreviewed, rolling out r76709.
1075         http://trac.webkit.org/changeset/76709
1076         https://bugs.webkit.org/show_bug.cgi?id=53194
1077
1078         "broke python tests on non-snowleopard platforms" (Requested
1079         by dpranke on #webkit).
1080
1081         * Scripts/webkitpy/layout_tests/port/factory.py:
1082         * Scripts/webkitpy/layout_tests/port/mock_drt.py: Removed.
1083         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Removed.
1084
1085 2011-01-26  Dirk Pranke  <dpranke@chromium.org>
1086
1087         Reviewed by Tony Chang.
1088
1089         new-run-webkit-tests: add a "mock DRT" port implementation
1090         and a separate class that emulates what we expect the
1091         DumpRenderTree behavior to be.
1092
1093         This will eventually replace port/dryrun.py and allow us to get
1094         better test coverage of the new-run-webkit-tests code as well as
1095         a reference for what new-run-webkit-tests expects from DRT.
1096
1097         This is the first attempt at this, and it is pretty bare-boned. It
1098         really only has been tested on the 'mac' port (and a little on
1099         the 'chromium-mac' port.
1100
1101         https://bugs.webkit.org/show_bug.cgi?id=53126
1102
1103         * Scripts/webkitpy/layout_tests/port/mock_drt.py: Added.
1104         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Added.
1105         * Scripts/webkitpy/layout_tests/port/factory.py:
1106
1107 2011-01-26  Xianzhu Wang  <wangxianzhu@google.com>
1108
1109         Reviewed by Tony Chang.
1110
1111         Add '--no-timeout' option to Chromium DRT to ease debugging.
1112         https://bugs.webkit.org/show_bug.cgi?id=52873
1113
1114         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1115         (main):
1116
1117 2011-01-26  Csaba Osztrogonác  <ossy@webkit.org>
1118
1119         Reviewed by Andreas Kling.
1120
1121         [Qt] Fix qt_minimal build
1122         https://bugs.webkit.org/show_bug.cgi?id=53172
1123
1124         * QtTestBrowser/locationedit.h:
1125
1126 2011-01-26  Mansi Mithal  <mansi.mithal@nokia.com>
1127
1128         Reviewed by Antonio Gomes.
1129
1130         QtTestBrowser should have a UI Setting to disable plugins
1131         https://bugs.webkit.org/show_bug.cgi?id=52408
1132         
1133         Added a new action item named "Disable Plugins"
1134         under the "Settings" menu. 
1135
1136         * QtTestBrowser/launcherwindow.cpp:
1137         (LauncherWindow::createChrome):
1138         (LauncherWindow::togglePlugins):
1139         * QtTestBrowser/launcherwindow.h:
1140
1141 2011-01-25  Patrick Gansterer  <paroga@webkit.org>
1142
1143         Reviewed by Adam Barth.
1144
1145         Move main CMakeLists.txt into Source directory
1146         https://bugs.webkit.org/show_bug.cgi?id=52888
1147
1148         * Scripts/webkitdirs.pm:
1149
1150 2011-01-25  Patrick Gansterer  <paroga@webkit.org>
1151
1152         Reviewed by Eric Seidel.
1153
1154         Improve label text in submit-to-ews
1155         https://bugs.webkit.org/show_bug.cgi?id=53130
1156
1157         * QueueStatusServer/templates/submittoews.html:
1158
1159 2011-01-25  Mansi Mithal  <mansi.mithal@nokia.com>
1160
1161         Reviewed by Antonio Gomes.
1162
1163         QtTestBrowser should have a UI Settings to prevent loading images
1164         https://bugs.webkit.org/show_bug.cgi?id=52409
1165         
1166         Added a new action item named "DisableAutoLoadImages"
1167         under the "Settings" menu 
1168
1169         * QtTestBrowser/launcherwindow.cpp:
1170         (LauncherWindow::createChrome):
1171         (LauncherWindow::toggleAutoLoadImages):
1172         * QtTestBrowser/launcherwindow.h:
1173
1174 2011-01-25  Dirk Pranke  <dpranke@chromium.org>
1175
1176         Reviewed by Tony Chang.
1177
1178         Minor bug fixes and cleanup for filesystem wrappers, port/* test
1179         classes, test_expectations.py. This change adds "test-win" and
1180         "test-mac" variants to the test port so that we can better test
1181         rebaselining, and adds a MockUser() object for reuse in testing.
1182
1183         https://bugs.webkit.org/show_bug.cgi?id=53036
1184
1185         * Scripts/webkitpy/common/system/filesystem.py:
1186         * Scripts/webkitpy/common/system/filesystem_mock.py:
1187         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1188         * Scripts/webkitpy/layout_tests/port/factory.py:
1189         * Scripts/webkitpy/layout_tests/port/base.py:
1190         * Scripts/webkitpy/layout_tests/port/test.py:
1191         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1192         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
1193         * Scripts/webkitpy/tool/mocktool.py:
1194
1195 2011-01-25  Tony Chang  <tony@chromium.org>
1196
1197         Reviewed by Dimitri Glazkov.
1198
1199         [chromium] remove unused layoutTestController callback
1200         https://bugs.webkit.org/show_bug.cgi?id=53103
1201
1202         This method is used by a test_shell_test, but not needed by DRT.
1203
1204         * DumpRenderTree/chromium/LayoutTestController.cpp:
1205         (LayoutTestController::LayoutTestController):
1206         * DumpRenderTree/chromium/LayoutTestController.h:
1207
1208 2011-01-25  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1209
1210         Reviewed by Andreas Kling.
1211
1212         [GTK] Remove 64 bits release bot from the buildbot master
1213         https://bugs.webkit.org/show_bug.cgi?id=52899
1214
1215         Removes the 64 bits release slave from the buildbot configuration,
1216         so that we can use it as an EWS.
1217
1218         * BuildSlaveSupport/build.webkit.org-config/config.json:
1219
1220 2011-01-24  Maciej Stachowiak  <mjs@apple.com>
1221
1222         Reviewed by Dan Bernstein.
1223
1224         Implement database quota callback to fix storage tests on WebKit2 bot
1225         https://bugs.webkit.org/show_bug.cgi?id=53064
1226
1227         * WebKitTestRunner/TestController.cpp:
1228         (WTR::exceededDatabaseQuota):
1229         (WTR::TestController::createOtherPage):
1230         (WTR::TestController::initialize):
1231
1232 2011-01-24  Maciej Stachowiak  <mjs@apple.com>
1233
1234         Reviewed by Anders Carlsson.
1235
1236         Use designated temp directory for the database for WebKit2
1237         https://bugs.webkit.org/show_bug.cgi?id=53052
1238         
1239         Adopt the new WK2 API for this.
1240
1241         * WebKitTestRunner/TestController.cpp:
1242         (WTR::TestController::libraryPathForTesting):
1243         (WTR::TestController::initialize):
1244         * WebKitTestRunner/TestController.h:
1245         * WebKitTestRunner/mac/TestControllerMac.mm:
1246         (WTR::TestController::platformLibraryPathForTesting):
1247         * WebKitTestRunner/qt/TestControllerQt.cpp:
1248         (WTR::TestController::platformLibraryPathForTesting):
1249         * WebKitTestRunner/win/TestControllerWin.cpp:
1250         (WTR::TestController::platformLibraryPathForTesting):
1251
1252 2011-01-24  Lucas Forschler  <lforschler@apple.com>
1253
1254         Reviewed by Stephanie Lewis.
1255
1256         Add a new Leopard test bot.
1257
1258         * BuildSlaveSupport/build.webkit.org-config/config.json:
1259
1260 2011-01-24  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1261
1262         Reviewed by Adam Barth.
1263
1264         Add EFL Builder to core waterfall
1265         https://bugs.webkit.org/show_bug.cgi?id=52704
1266
1267         Add EFL Builder to the core waterfall again.
1268
1269         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1270         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1271
1272 2011-01-24  Xianzhu Wang  <wangxianzhu@google.com>
1273
1274         Reviewed by Tony Chang.
1275
1276         new-run-webkit-tests fails to start HTTP server if there are proxy settings
1277         https://bugs.webkit.org/show_bug.cgi?id=52872
1278
1279         Force disabling proxy to resolve the problem.
1280
1281         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
1282         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
1283
1284 2011-01-24  Andreas Kling  <kling@webkit.org>
1285
1286         Reviewed by Darin Adler.
1287
1288         check-webkit-style: Update exemptions following Source/ move.
1289         https://bugs.webkit.org/show_bug.cgi?id=53017
1290
1291         * Scripts/webkitpy/style/checker.py:
1292         * Scripts/webkitpy/style/checker_unittest.py:
1293
1294 2011-01-24  Andras Becsi  <abecsi@webkit.org>
1295
1296         Rubber-stamped by Csaba Osztrogonác.
1297
1298         [Qt] Move project files into Source
1299         https://bugs.webkit.org/show_bug.cgi?id=52891
1300
1301         * DumpRenderTree/qt/ImageDiff.pro: Add missing "Source" to WebKit.pri path
1302
1303 2011-01-24  Mikhail Naganov  <mnaganov@chromium.org>
1304
1305         Reviewed by Yury Semikhatsky.
1306
1307         Web Inspector: Find duplicate strings in localizedStrings.js
1308
1309         https://bugs.webkit.org/show_bug.cgi?id=53005
1310
1311         * Scripts/check-inspector-strings:
1312
1313 2011-01-24  Zoltan Horvath  <zoltan@webkit.org>
1314
1315         Reviewed by Andreas Kling.
1316
1317         [Qt] Regroup MiniBrowser's menubar and add open file action
1318         https://bugs.webkit.org/show_bug.cgi?id=53000
1319
1320         Add File and Develop menu to MiniBrowser's menubar and add open file action to File menu.
1321
1322         * MiniBrowser/qt/BrowserWindow.cpp:
1323         (BrowserWindow::BrowserWindow):
1324         (BrowserWindow::openFile):
1325         (BrowserWindow::~BrowserWindow):
1326         * MiniBrowser/qt/BrowserWindow.h:
1327
1328 2011-01-24  Csaba Osztrogonác  <ossy@webkit.org>
1329
1330         Unreviewed fix after r76496
1331
1332         [Qt] Move project files into Source
1333         https://bugs.webkit.org/show_bug.cgi?id=52891
1334
1335         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Remove unnecessary "Source" from the path.
1336         * BuildSlaveSupport/built-product-archive: Remove unnecessary "Source" from the path.
1337         * Scripts/webkitdirs.pm: Add the accidentally removed slash to the path.
1338
1339 2011-01-24  Andras Becsi  <abecsi@webkit.org>
1340
1341         Reviewed by Csaba Osztrogonác.
1342
1343         [Qt] Move project files into Source
1344         https://bugs.webkit.org/show_bug.cgi?id=52891
1345
1346         * DerivedSources.pro: Renamed from DerivedSources.pro.
1347         * DumpRenderTree/qt/DumpRenderTree.pro:
1348         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1349         * MiniBrowser/DerivedSources.pro:
1350         * MiniBrowser/qt/MiniBrowser.pro:
1351         * QtTestBrowser/QtTestBrowser.pro:
1352         * Scripts/webkitdirs.pm:
1353         * Tools.pro: Added.
1354         * WebKitTestRunner/DerivedSources.pro:
1355         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1356         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1357
1358 2011-01-22  Geoffrey Garen  <ggaren@apple.com>
1359
1360         Reviewed by Dan Bernstein.
1361
1362         Beefed up --threaded mode to catch even more kinds of errors.
1363         https://bugs.webkit.org/show_bug.cgi?id=52971
1364
1365         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Use a shared
1366         context group to force JSC to mark multiple threads. (This used to be
1367         the default, but it changed in SnowLeopard.)
1368         (runJavaScriptThread): Do more locking and unlocking, and more allocation,
1369         to give threading mistakes more chances to show themselves.
1370         (startJavaScriptThreads):
1371         (stopJavaScriptThreads):
1372
1373 2011-01-22  Robert Hogan  <robert@webkit.org>
1374
1375         Reviewed by Andreas Kling.
1376
1377         [Qt] Support layoutTestController.addURLToRedirect()
1378         https://bugs.webkit.org/show_bug.cgi?id=52956
1379
1380         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1381         (LayoutTestController::addURLToRedirect):
1382         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1383
1384 2011-01-22  Robert Hogan  <robert@webkit.org>
1385
1386         Reviewed by Kenneth Rohde Christiansen.
1387
1388         [Qt] REGRESSION (r72360): http/tests/security/aboutBlank/xss-DENIED-* tests fail
1389         https://bugs.webkit.org/show_bug.cgi?id=49802
1390
1391         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1392         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1393         (WebCore::DumpRenderTree::open):
1394
1395 2011-01-21  Adam Barth  <abarth@webkit.org>
1396
1397         Reviewed by Maciej Stachowiak.
1398
1399         Disable mac_unittest.py that fails on some of the Mac bots
1400         https://bugs.webkit.org/show_bug.cgi?id=52947
1401
1402         As noted in the comment, this test does not appear to be correct
1403         because the function this test is testing returns different results
1404         depending on which flavor of Mac the test is run on.  This patch
1405         disable the test.  Hopefully we can re-enable the test once we've
1406         probably insulated the test from its environment.
1407
1408         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1409
1410 2011-01-21  Dirk Pranke  <dpranke@chromium.org>
1411
1412         Reviewed by Mihai Parparita.
1413
1414         Fix bug introduced in r76322 that caused NRWT to not actually
1415         read the Skipped files properly.
1416
1417         https://bugs.webkit.org/show_bug.cgi?id=52771
1418
1419         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1420         * Scripts/webkitpy/layout_tests/port/webkit.py:
1421         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1422
1423 2011-01-21  Sam Weinig  <sam@webkit.org>
1424
1425         Reviewed by Geoffrey Sean Garen and Mark Rowe.
1426
1427         WebKitTestRunner needs the HOME environment variable to be set.
1428         <rdar://problem/8896573>
1429
1430         * Scripts/old-run-webkit-tests: Set the HOME environment variable if
1431         it exists.
1432
1433 2011-01-21  Dirk Pranke  <dpranke@chromium.org>
1434
1435         Reviewed by Eric Seidel.
1436
1437         Suppress a few remaining integration tests so that none of the
1438         layout_test unit tests ever read from the filesystem or launch
1439         subprocesses that aren't part of the unit tests.
1440
1441         Also fix a minor bug in the printing unit tests that was
1442         incorrectly relying on sys.argv.
1443
1444         https://bugs.webkit.org/show_bug.cgi?id=52863
1445
1446         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1447         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1448         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1449
1450 2011-01-21  Darin Adler  <darin@apple.com>
1451
1452        Fix Mac build.
1453
1454         * MiniBrowser/mac/BrowserWindowController.m:
1455         (-[BrowserWindowController awakeFromNib]): Pass 0 for runModal function.
1456
1457 2011-01-20  Darin Adler  <darin@apple.com>
1458
1459         Reviewed by Dan Bernstein.
1460
1461         WebKit2: Implement showModalDialog
1462         https://bugs.webkit.org/show_bug.cgi?id=52855
1463
1464         This fixes WebKitTestRunner to compile, but more work is probably
1465         needed to get it to pass the tests.
1466
1467         * WebKitTestRunner/TestController.cpp:
1468         (WTR::TestController::runModal): Added. Calls through to the
1469         platform-specific version of runModal.
1470         (WTR::TestController::createOtherPage): Changed to be a private
1471         static member function so it can refer to runModal, which is
1472         a private static member function.
1473         (WTR::TestController::initialize): Pass 0 for the runModal
1474         function since we don't need to run the main window modal.
1475         I suspect this is wrong and will need to change.
1476         * WebKitTestRunner/TestController.h: Added declarations for
1477         the functions added above.
1478         * WebKitTestRunner/mac/TestControllerMac.mm:
1479         (WTR::TestController::runModal): Added. Untested implementation.
1480         * WebKitTestRunner/qt/TestControllerQt.cpp:
1481         (WTR::TestController::runModal): Added.
1482         * WebKitTestRunner/win/TestControllerWin.cpp:
1483         (WTR::TestController::runModal): Added.
1484
1485 2011-01-21  Eric Seidel  <eric@webkit.org>
1486
1487         Reviewed by Adam Barth.
1488
1489         Split Host object off from WebKitPatch for easier re-use
1490         https://bugs.webkit.org/show_bug.cgi?id=52284
1491
1492         new-run-webkit-tests and other tools are eventually going to want one of these.
1493         Basically you need to inherit from this class if you want to pretend to be a
1494         self.tool object for Steps/Commands.
1495
1496         * Scripts/webkitpy/common/host.py: Added.
1497         * Scripts/webkitpy/tool/main.py:
1498
1499 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1500
1501         Reviewed by Adam Barth.
1502
1503         Disable the tests that start and stop the http server and web
1504         server, so that we don't have to worry about port collisions on
1505         the bots.
1506
1507         https://bugs.webkit.org/show_bug.cgi?id=52861
1508
1509         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1510
1511 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1512
1513         Reviewed by Eric Seidel.
1514
1515         nrwt: rewrite google_chrome_unittest to use mock filesystem.
1516         
1517         https://bugs.webkit.org/show_bug.cgi?id=52772
1518         
1519         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
1520
1521 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1522
1523         Reviewed by Eric Siedel.
1524
1525         nrwt: clean up almost all remaining port references, remove
1526         unnecessary import clauses. The only remaining references are
1527         in places where a mock filesystem makes no sense or can't be
1528         used, and in one routine in port/google_chrome_unittest that
1529         I'll rewrite in a separate patch.
1530
1531         https://bugs.webkit.org/show_bug.cgi?id=52771
1532
1533         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1534         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1535         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1536         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1537         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1538         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1539         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1540         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
1541         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
1542         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
1543         * Scripts/webkitpy/layout_tests/port/gtk.py:
1544         * Scripts/webkitpy/layout_tests/port/mac.py:
1545         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1546         * Scripts/webkitpy/layout_tests/port/qt.py:
1547         * Scripts/webkitpy/layout_tests/port/webkit.py:
1548         * Scripts/webkitpy/layout_tests/port/win.py:
1549         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
1550
1551 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1552
1553         Reviewed by Mihai Parparita.
1554
1555         remove fs refs from run_webkit_tests, rebaseline_chromium_webkit_tests
1556
1557         https://bugs.webkit.org/show_bug.cgi?id=52762
1558
1559         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1560         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1561
1562 2011-01-20  Tony Chang  <tony@chromium.org>
1563
1564         Reviewed by Ojan Vafai.
1565
1566         [chromium] fix the paths used for the rebaseline tool
1567         https://bugs.webkit.org/show_bug.cgi?id=52857
1568
1569         Some of the bots were renamed so the path to grab the results zip
1570         file has changed.
1571
1572         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1573
1574 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1575
1576         Reviewed by Tony Chang.
1577
1578         Fix bug introduced in r72688 / bug 52768 that broke the
1579         generation of the output filename links in the results.html
1580         output. Apparently none of the unit tests actually checked to
1581         make sure the generated links were correct :(
1582
1583         https://bugs.webkit.org/show_bug.cgi?id=52854
1584
1585         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1586         * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
1587
1588 2011-01-20  Alexey Proskuryakov  <ap@apple.com>
1589
1590         Reviewed by Darin Adler.
1591
1592         https://bugs.webkit.org/show_bug.cgi?id=52849
1593         Make window.print work with WebKit2
1594
1595         * MiniBrowser/mac/BrowserWindowController.m:
1596         (-[BrowserWindowController awakeFromNib]):
1597         * WebKitTestRunner/TestController.cpp:
1598         (WTR::createOtherPage):
1599         (WTR::TestController::initialize):
1600         Added zeroes to WKPageUIClient structures to avoid build failures.
1601
1602 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1603
1604         Reviewed by Eric Seidel.
1605
1606         nrwt: remove fs refs from printing, test_failures, test_expectations, text_diff
1607
1608         https://bugs.webkit.org/show_bug.cgi?id=52756
1609
1610         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1611         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1612         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1613         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
1614         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1615         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
1616
1617 2011-01-20  Mansi Mithal  <mansi.mithal@nokia.com>
1618
1619         Reviewed by Antonio Gomes.
1620
1621         QtTestBrowser should have a seperate menu for Settings
1622         https://bugs.webkit.org/show_bug.cgi?id=52817
1623         
1624         Added a new menu item named "Settings"
1625         and moved the "Enable interrupting js scripts" and "Enable js pop up windows" under the "Settings" menu 
1626
1627         * QtTestBrowser/launcherwindow.cpp:
1628         (LauncherWindow::createChrome):
1629
1630 2011-01-20  Sam Weinig  <sam@webkit.org>
1631
1632         Reviewed by John Sullivan.
1633
1634         Update update-webkit-localizable-strings with new path to WebKit.
1635
1636         * Scripts/update-webkit-localizable-strings:
1637
1638 2011-01-20  James Robinson  <jamesr@chromium.org>
1639
1640         Reviewed by Darin Fisher.
1641
1642         Implement mozilla's requestAnimationFrame API
1643         https://bugs.webkit.org/show_bug.cgi?id=51218
1644
1645         Chromium DumpRenderTree support for window.webkitRequestAnimationFrame.
1646
1647         * DumpRenderTree/chromium/WebViewHost.cpp:
1648         (invokeScheduleComposite):
1649         (WebViewHost::scheduleAnimation):
1650         (WebViewHost::paintInvalidatedRegion):
1651         * DumpRenderTree/chromium/WebViewHost.h:
1652
1653 2011-01-20  Maciej Stachowiak  <mjs@apple.com>
1654
1655         Reviewed by Adam Roben.
1656
1657         WebKitTestRunner needs to support layoutTestController.evaluateScriptInIsolatedWorld
1658         https://bugs.webkit.org/show_bug.cgi?id=42327
1659
1660         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm: Add support
1661         for methods that take their normal arguments but also a JSContextRef.
1662         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: IDL definition
1663         for evaluateScriptInIsolatedWorld.
1664         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1665         (WTR::InjectedBundlePage::didClearWindowForFrame): Set a magic variable only if
1666         this call is for an isolated world.
1667         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1668         (WTR::worldMap): Helper to create a world map.
1669         (WTR::LayoutTestController::worldIDForWorld): Map from an ID to a world.
1670         (WTR::LayoutTestController::evaluateScriptInIsolatedWorld): The newly
1671         added LayoutTestController API.
1672         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1673
1674 2011-01-19  Adam Roben  <aroben@apple.com>
1675
1676         Convert paths in environment variables back to msys-style inside commit-log-editor
1677
1678         When this script gets run from inside git commit, msys-style paths in the environment will
1679         have been turned into Windows-style paths with forward slashes. This screws up functions
1680         like File::Spec->rel2abs, which seem to rely on $PWD having an msys-style path. We convert
1681         the paths back to msys-style before doing anything else.
1682
1683         Fixes <http://webkit.org/b/48527> commit-log-editor uses full paths for section headers when
1684         using msysgit's Perl and multiple ChangeLogs have been edited
1685
1686         Reviewed by David Kilzer.
1687
1688         * Scripts/commit-log-editor: Call fixEnvironment before doing anything else.
1689         (fixEnvironment): Added. When run in msys in conjunction with git (i.e., when invoked from
1690         inside git commit), convert Windows-style paths in the environment back to msys-style paths.
1691
1692 2011-01-20  Zoltan Horvath  <zoltan@webkit.org>
1693
1694         [Win] Unreviewed build fix after r76248.
1695
1696         * DumpRenderTree/ForwardingHeaders/wtf/FastAllocBase.h: Added.
1697
1698 2011-01-20  Zoltan Horvath  <zoltan@webkit.org>
1699
1700         Reviewed by Csaba Osztrogonác.
1701
1702         Refactoring of the custom allocation framework
1703         https://bugs.webkit.org/show_bug.cgi?id=49897
1704
1705         Inheriting from FastAllocBase can result in objects getting larger (bug #33896, #46589).
1706         The modification replaces Noncopyable and FastAllocBase classes and these inherits with their
1707         equivalent macro implementation at the necessary places.
1708 2011-01-20  Yi Shen  <yi.4.shen@nokia.com>
1709
1710         Unreviewed. 
1711
1712         Adding myself to committers.py.
1713
1714         * Scripts/webkitpy/common/config/committers.py:
1715
1716 2011-01-20  Adam Barth  <abarth@webkit.org>
1717
1718         Reviewed by Tony Chang.
1719
1720         Chromium builders don't delete unversioned directories when DEPS change
1721         https://bugs.webkit.org/show_bug.cgi?id=52745
1722
1723         If we pass this option to gclient sync, gclient will delete directories
1724         that are no longer part of DEPS instead of leaving them around to
1725         confuse us later.  Apparently, the downstream buildbots use this option
1726         already.
1727
1728         * Scripts/update-webkit-chromium:
1729
1730 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1731
1732         Unreviewed, build fix - I pulled this patch in to fix an issue
1733         revealed by r76195 running on some new bots). Also fix a couple
1734         of other issues revealed in testing.
1735
1736         nrwt: remove fs refs from layout_package/json*
1737
1738         https://bugs.webkit.org/show_bug.cgi?id=52754
1739
1740         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1741         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1742         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
1743         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1744         * Scripts/webkitpy/layout_tests/port/base.py:
1745
1746 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1747
1748         Unreviewed, build fix.
1749
1750         Fix a couple of minor bugs discovered while bringing up new bots
1751         for testing.
1752
1753         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1754         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1755
1756 2011-01-19  James Robinson  <jamesr@chromium.org>
1757
1758         Unreviewed, rolling out r76194.
1759         http://trac.webkit.org/changeset/76194
1760         https://bugs.webkit.org/show_bug.cgi?id=51218
1761
1762         Caused mysterious compile failure on the chromium win
1763         build.webkit.org bots
1764
1765         * DumpRenderTree/chromium/WebViewHost.cpp:
1766         (WebViewHost::paintInvalidatedRegion):
1767         * DumpRenderTree/chromium/WebViewHost.h:
1768
1769 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1770
1771         Reviewed by Mihai Parparita.
1772
1773         remove fs refs from test_runner, dump_render_tree_thread
1774
1775         https://bugs.webkit.org/show_bug.cgi?id=52753
1776
1777         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1778         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1779         * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
1780         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1781
1782 2011-01-19  James Robinson  <jamesr@chromium.org>
1783
1784         Reviewed by Darin Fisher.
1785
1786         Implement mozilla's requestAnimationFrame API
1787         https://bugs.webkit.org/show_bug.cgi?id=51218
1788
1789         Chromium DumpRenderTree support for window.webkitRequestAnimationFrame.
1790
1791         * DumpRenderTree/chromium/WebViewHost.cpp:
1792         (invokeScheduleComposite):
1793         (WebViewHost::scheduleAnimation):
1794         (WebViewHost::paintInvalidatedRegion):
1795         * DumpRenderTree/chromium/WebViewHost.h:
1796
1797 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1798
1799         Unreviewed, build fix.
1800
1801         Fix a few incorrect "self._filesystem" references introduced in
1802         r76184.
1803
1804         * Scripts/webkitpy/layout_tests/port/chromium.py:
1805         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1806
1807 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1808
1809         Reviewed by Mihai Parparita.
1810
1811         add a .sep property, abspath(), isabs(), mtime(), and
1812         open_text_file_for_writing() to filesystem modules. Some of
1813         these properties are not needed in this patch but will be needed
1814         in subsequent patches (I'm doing this to avoid having to track
1815         multiple versions of a single file).
1816
1817         Also, change most of the port/* modules to use the filesystem
1818         objects instead of referencing the filesystem directly.
1819
1820         https://bugs.webkit.org/show_bug.cgi?id=52748
1821
1822         * Scripts/webkitpy/common/system/filesystem.py:
1823         * Scripts/webkitpy/common/system/filesystem_mock.py:
1824         * Scripts/webkitpy/layout_tests/port/__init__.py:
1825         * Scripts/webkitpy/layout_tests/port/base.py:
1826         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1827         * Scripts/webkitpy/layout_tests/port/chromium.py:
1828         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1829         * Scripts/webkitpy/layout_tests/port/config.py:
1830         * Scripts/webkitpy/layout_tests/port/test.py:
1831         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
1832
1833 2011-01-19  Maciej Stachowiak  <mjs@apple.com>
1834
1835         Reviewed by Anders Carlsson.
1836
1837         If resetting between tests times out, treat it as a WebProcess crash
1838         https://bugs.webkit.org/show_bug.cgi?id=52757
1839
1840         * WebKitTestRunner/TestController.cpp:
1841         (WTR::TestController::runTest):
1842
1843 2011-01-19  Alexey Proskuryakov  <ap@apple.com>
1844
1845         Reviewed by Darin Adler.
1846
1847         https://bugs.webkit.org/show_bug.cgi?id=52739
1848         Make it possible for a WebKit2 client to print headers and footers
1849
1850         Added dummy implementations for new printing UIClient calls.
1851
1852         * MiniBrowser/mac/BrowserWindowController.m:
1853         (-[BrowserWindowController awakeFromNib]):
1854         * WebKitTestRunner/TestController.cpp:
1855         (WTR::createOtherPage):
1856         (WTR::TestController::initialize):
1857
1858 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1859
1860         Reviewed by Ojan Vafai.
1861
1862         Change webkitpy/layout_tests/port/test.py to use the
1863         in-memory filesystem for cleaner unit testing. This
1864         change allows us to kill a lot of code that was
1865         specific to the test port, at the cost of being a
1866         little less clear about how things would work if
1867         you didn't have a filesystem.
1868
1869         https://bugs.webkit.org/show_bug.cgi?id=52605
1870
1871         * Scripts/webkitpy/layout_tests/port/test.py:
1872
1873 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1874
1875         Unreviewed, build fix.
1876
1877         Fix test failure caused by committing attachment 79368 instead
1878         of attachment 79461 on bug 52604.
1879
1880         * Scripts/webkitpy/common/system/filesystem_mock.py:
1881
1882 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1883
1884         Reviewed by Mihai Parparita.
1885
1886         new-run-webkit-tests: remove use of os.walk, use mock filesystem for better
1887         unit testing. os.walk() is too much of a hassle to implement on
1888         top of the in-memory mock filesystem and adding the necessary
1889         interface to files_under() gives clients a cleaner API anyway
1890         (for this particular usage model).
1891
1892         https://bugs.webkit.org/show_bug.cgi?id=52691
1893
1894         * Scripts/webkitpy/common/system/filesystem.py:
1895         * Scripts/webkitpy/common/system/filesystem_mock.py:
1896         * Scripts/webkitpy/layout_tests/port/test_files.py:
1897         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
1898
1899 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1900
1901         Reviewed by Tony Chang.
1902
1903         Change more modules in the layout-tests code to use the
1904         filesystem wrapper for cleaner unit testing.
1905
1906         This patch also adds the glob() wrapper to the filesystem
1907         abstraction.
1908         
1909         https://bugs.webkit.org/show_bug.cgi?id=52604
1910
1911         * Scripts/webkitpy/layout_tests/port/test_files.py:
1912         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
1913         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
1914         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1915         * Scripts/webkitpy/common/system/filesystem.py:
1916         * Scripts/webkitpy/common/system/filesystem_mock.py:
1917
1918 2011-01-19  Levi Weintraub  <leviw@chromium.org>
1919
1920         Unreviewed.
1921
1922         Updating my email addresses and irc nick.
1923
1924         * Scripts/webkitpy/common/config/committers.py:
1925
1926 2011-01-19  Tony Chang  <tony@chromium.org>
1927
1928         Reviewed by Mihai Parparita.
1929
1930         [chromium] [linux] if check-sys-deps fails, output the failure reason
1931         https://bugs.webkit.org/show_bug.cgi?id=52671
1932
1933         * Scripts/webkitpy/common/system/executive_mock.py: Add support for
1934             error handler functions.
1935         * Scripts/webkitpy/layout_tests/port/chromium.py:
1936             output the error text from --check-sys-deps
1937         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1938
1939 2011-01-19  Aparna Nandyal  <aparna.nand@wipro.com>
1940
1941         Reviewed by Andreas Kling.
1942
1943         [Qt] QtTestBrowser crashes when closing if Facebook is opened
1944         https://bugs.webkit.org/show_bug.cgi?id=52554
1945         
1946         QtNetworkAccessManager is created in a thread and set as
1947         member variable in QWebPage. When the thread is destroyed
1948         the object is still used. So fix will set the object to
1949         NULL once the thread is destroyed.
1950
1951         * QtTestBrowser/launcherwindow.cpp:
1952         (LauncherWindow::~LauncherWindow):
1953
1954 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
1955
1956         Rubber stamped by Csaba Osztrogonac
1957
1958         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: Removed unncessary inculde of WKStringCF.h
1959
1960 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
1961
1962         Reviewed by Tony Chang.
1963
1964         new-run-webkit-tests: add a --build-directory command line argument
1965
1966         Official Google Chrome builds use a non-standard build directory
1967         location. This patch adds a --build-directory argument that
1968         allows that location to be specified on the command line. Only
1969         Chromium-based builds will use this flag for now, but anyone can
1970         in the future.
1971
1972         There are no unit tests for this since it's difficult to test
1973         until mock filesystems are fully supported in the code. This was
1974         tested by hand for now.
1975
1976         https://bugs.webkit.org/show_bug.cgi?id=52694
1977
1978         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1979         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1980         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1981         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1982
1983 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
1984
1985         Not reviewed. Bot fix.
1986
1987         Remove an inadvertently committed debugging print.
1988
1989         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1990         (LayoutTestController::notifyDone):
1991
1992 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
1993
1994         Reviewed by Sam Weinig.
1995
1996         WebKitTestRunner should track loading more like DumpRenderTree
1997         https://bugs.webkit.org/show_bug.cgi?id=52692
1998
1999         Change load tracking to track the current top loading frame, in the manner of DumpRenderTree.
2000         This makes some tests that call notifyDone multiple times pass.
2001         
2002         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2003         (WTR::InjectedBundle::InjectedBundle):
2004         (WTR::InjectedBundle::done):
2005         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2006         (WTR::InjectedBundle::topLoadingFrame):
2007         (WTR::InjectedBundle::setTopLoadingFrame):
2008         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2009         (WTR::InjectedBundlePage::InjectedBundlePage):
2010         (WTR::InjectedBundlePage::stopLoading):
2011         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
2012         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
2013         (WTR::InjectedBundlePage::didFinishLoadForFrame):
2014         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
2015         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2016         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2017         (WTR::LayoutTestController::notifyDone):
2018         * WebKitTestRunner/TestController.cpp:
2019         (WTR::TestController::didReceiveMessageFromInjectedBundle):
2020
2021 2011-01-18  Mihai Parparita  <mihaip@chromium.org>
2022
2023         Reviewed by Kent Tamura.
2024
2025         [Chromium] NRWT looking for DRT binary in the wrong path on Mac
2026         https://bugs.webkit.org/show_bug.cgi?id=52678
2027         
2028         Update path now that WebKit is inside Source.
2029
2030         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2031
2032 2011-01-18  Robert Hogan  <robert@webkit.org>
2033
2034         Reviewed by Simon Hausmann.
2035
2036         [Qt] http/tests/incremental/slow-utf8-text.pl fails
2037         https://bugs.webkit.org/show_bug.cgi?id=44282
2038
2039         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2040         (WebCore::DumpRenderTree::dump):
2041
2042 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
2043
2044         Reviewed by Mihai Parparita.
2045
2046         Fix a small race condition that could cause the unit tests for
2047         new-run-webkit-tests to fail in a multithreaded environment.
2048         There was a small window in the code where one thread would
2049         check to see if a thread had raised an exception, do something,
2050         and then check to see if the thread was alive. If the other
2051         thread raised an exception and exited in between these two
2052         steps, the exception would be lost. Flipping the order of the
2053         two checks fixes the race, since we will now always check for an
2054         exception on the thread before exiting.
2055
2056         https://bugs.webkit.org/show_bug.cgi?id=51579
2057
2058         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
2059
2060 2011-01-18  Eric Seidel  <eric@webkit.org>
2061
2062         Reviewed by Adam Barth.
2063
2064         commit-queue dies when test archiving fails
2065         https://bugs.webkit.org/show_bug.cgi?id=52617
2066
2067         I looked at the machine and it had 10 archives already
2068         thus find_unused_name was returning None.  I've upped
2069         the limit to 100 (per bug) and tested the case where
2070         find_unused_name returns None (making archive return None).
2071
2072         * Scripts/webkitpy/common/system/workspace.py:
2073         * Scripts/webkitpy/common/system/workspace_unittest.py:
2074         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2075         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2076         * Scripts/webkitpy/tool/commands/queues.py:
2077
2078 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
2079
2080         Reviewed by Ojan Vafai.
2081
2082         Update rebaseline-chromium-webkit-tests unit tests to use a mock
2083         filesystem. Also fix a couple of "with" statements missed by
2084         r76050.
2085
2086         https://bugs.webkit.org/show_bug.cgi?id=52487
2087
2088         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
2089
2090 2011-01-18  Sergio Villar Senin  <svillar@igalia.com>
2091
2092         Reviewed by Martin Robinson.
2093
2094         [Gtk] Build fixes for gtk3 build
2095         https://bugs.webkit.org/show_bug.cgi?id=52648
2096
2097         * DumpRenderTree/gtk/EventSender.cpp:
2098         (beginDragWithFilesCallback):
2099
2100 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
2101
2102         Reviewed by Mihai Parparita.
2103
2104         Update rebaseline-chromium-webkit-tests to use filesystem objects
2105         instead of direct references to os.path, shutil, tempfile, etc.
2106
2107         This patch doesn't change anything, but will allow subsequent
2108         patches to change the unit tests to no longer use the real
2109         filesystem.
2110
2111         This patch adds a bunch more methods to the filesystem object as
2112         well.
2113
2114         https://bugs.webkit.org/show_bug.cgi?id=52482
2115
2116         * Scripts/webkitpy/common/system/filesystem.py:
2117         * Scripts/webkitpy/common/system/filesystem_mock.py:
2118         * Scripts/webkitpy/tool/commands/queues.py:
2119         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2120         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
2121
2122 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
2123
2124         Reviewed by Mihai Parparita.
2125
2126         new-run-webkit-tests shouldn't crash when you try to run a
2127         directory containing only skipped files.
2128
2129         https://bugs.webkit.org/show_bug.cgi?id=52478
2130         
2131         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2132         * Scripts/webkitpy/layout_tests/port/test.py:
2133         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2134
2135 2011-01-18  Adam Bergkvist  <adam.bergkvist@ericsson.com> and Martin Robinson  <mrobinson@igalia.com>
2136
2137         Reviewed by Gustavo Noronha Silva.
2138
2139         [GTK] The GTK+ EventSender needs support for beginDragWithFiles
2140         https://bugs.webkit.org/show_bug.cgi?id=40833
2141
2142         * DumpRenderTree/gtk/EventSender.cpp: Add a beginDragWithFiles implementation for the
2143         GTK+ event sender.
2144         (dragWithFilesDragDataGetCallback): Added.
2145         (dragWithFilesDragEndCallback): Added.
2146         (beginDragWithFilesCallback): Added.
2147
2148 2011-01-18  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2149
2150         Reviewed by Adam Barth.
2151
2152         ews: Add additional watcher to efl ews
2153         https://bugs.webkit.org/show_bug.cgi?id=52613
2154
2155         Add gyuyoung.kim@samsung.com to watcher list of efl-ews.
2156
2157         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2158
2159 2011-01-17  Tony Gentilcore  <tonyg@chromium.org>
2160
2161         Reviewed by Alexey Proskuryakov.
2162
2163         Fix some headers with missing or misspelled #ifndef guards
2164         https://bugs.webkit.org/show_bug.cgi?id=52545
2165
2166         * DumpRenderTree/chromium/TestEventPrinter.h:
2167         * DumpRenderTree/chromium/WebPreferences.h:
2168
2169 2011-01-17  Jessie Berlin  <jberlin@apple.com>
2170
2171         Reviewed by Anders Carlsson.
2172
2173         REGRESSION: Assertion failure in FrameLoader::continueLoadAfterWillSubmitForm() when
2174         navigating back to an unreachable URL
2175         https://bugs.webkit.org/show_bug.cgi?id=52388
2176
2177         Add a third parameter (unreachableURL) to queueLoadHTMLString.
2178
2179         * DumpRenderTree/LayoutTestController.cpp:
2180         (queueLoadHTMLStringCallback):
2181         (LayoutTestController::queueLoadHTMLString):
2182         (LayoutTestController::queueLoadAlternateHTMLString):
2183         * DumpRenderTree/LayoutTestController.h:
2184
2185         * DumpRenderTree/WorkQueueItem.h:
2186         (LoadHTMLStringItem::LoadHTMLStringItem):
2187
2188         * DumpRenderTree/chromium/LayoutTestController.cpp:
2189         (WorkItemLoadHTMLString::WorkItemLoadHTMLString):
2190         (WorkItemLoadHTMLString::run):
2191         (LayoutTestController::queueLoadHTMLString):
2192
2193         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
2194         (LoadHTMLStringItem::invoke):
2195         * DumpRenderTree/mac/WorkQueueItemMac.mm:
2196         (LoadHTMLStringItem::invoke):
2197         * DumpRenderTree/win/WorkQueueItemWin.cpp:
2198         (LoadHTMLStringItem::invoke):
2199
2200 2011-01-17  Dan Bernstein  <mitz@apple.com>
2201
2202         Rubber-stamped by Mark Rowe.
2203
2204         Update xcodeproj svn:ignore to include xcuserdata.
2205
2206         * DumpRenderTree/DumpRenderTree.xcodeproj: Modified property svn:ignore.
2207         * MiniBrowser/MiniBrowser.xcodeproj: Modified property svn:ignore.
2208         * TestWebKitAPI/TestWebKitAPI.xcodeproj: Modified property svn:ignore.
2209         * WebKitLauncher/WebKitLauncher.xcodeproj: Modified property svn:ignore.
2210         * WebKitTestRunner/WebKitTestRunner.xcodeproj: Modified property svn:ignore.
2211
2212 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
2213
2214         Unreviewed fix after r75908.
2215
2216         Move WebKit into Source
2217         https://bugs.webkit.org/show_bug.cgi?id=52530
2218
2219         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add Source to the path for Qt API tests.
2220
2221 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
2222
2223         Unreviewed.
2224
2225         Remove accidentally committed debug printing after r75908.
2226
2227         * Scripts/webkitdirs.pm:
2228
2229 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
2230
2231         Unreviewed.
2232
2233         Add myself to committers list
2234         https://bugs.webkit.org/show_bug.cgi?id=52566
2235
2236         * Scripts/webkitpy/common/config/committers.py:
2237
2238 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
2239
2240         Reviewed by Jeremy Orlow.
2241
2242         GeolocationController should call stopUpdating on destruction
2243         https://bugs.webkit.org/show_bug.cgi?id=52216
2244
2245         fast/dom/Geolocation/window-close-crash.html requires that a
2246         Geolocation watch be started in a secondary window. Consequently,
2247         we need to allow geolocation permission and provide a mock
2248         geolocation position for the secondary window's
2249         GeolocationClientMock.
2250
2251         * DumpRenderTree/chromium/LayoutTestController.cpp:
2252         (LayoutTestController::setGeolocationPermission):
2253         (LayoutTestController::setMockGeolocationPosition):
2254         (LayoutTestController::setMockGeolocationError):
2255         * DumpRenderTree/chromium/TestShell.h:
2256         (TestShell::windowList):
2257
2258 2011-01-16  Adam Barth  <abarth@webkit.org>
2259
2260         Update more include paths to reflect WebKit move.
2261
2262         * DumpRenderTree/chromium/EventSender.cpp:
2263         (EventSender::keyDown):
2264         (EventSender::needsShiftModifier):
2265         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
2266         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
2267
2268 2011-01-16  Kent Tamura  <tkent@chromium.org>
2269
2270         Unreviewed, Chromium build fix.
2271
2272         * Scripts/update-webkit-chromium: Webkit/chromium -> Source/WebKit/chromium
2273
2274 2011-01-16  Martin Robinson  <mrobinson@igalia.com>
2275
2276         Build fix for GTK+ after source directory movement.
2277
2278         * GNUmakefile.am: Correct include paths.
2279
2280 2011-01-16  Adam Barth  <abarth@webkit.org>
2281
2282         Teach svn-apply about WebKit move.
2283
2284         * Scripts/VCSUtils.pm:
2285
2286 2011-01-16  Adam Barth  <abarth@webkit.org>
2287
2288         Rubber-stamped by Eric Seidel.
2289
2290         Move WebKit into Source
2291         https://bugs.webkit.org/show_bug.cgi?id=52530
2292
2293         * DumpRenderTree/mac/InternalHeaders/WebKit/WebTypesInternal.h:
2294         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2295         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2296         * DumpRenderTree/qt/GCControllerQt.cpp:
2297         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2298         * DumpRenderTree/qt/PlainTextControllerQt.cpp:
2299         * DumpRenderTree/qt/TextInputControllerQt.cpp:
2300         * DumpRenderTree/wscript:
2301         * QtTestBrowser/launcherwindow.h:
2302         * Scripts/build-webkit:
2303         * Scripts/webkitdirs.pm:
2304
2305 2011-01-15  Adam Barth  <abarth@webkit.org>
2306
2307         Teach svn-apply about WebKit2 move.
2308
2309         * Scripts/VCSUtils.pm:
2310
2311 2011-01-15  Adam Barth  <abarth@webkit.org>
2312
2313         Rubber-stamped by Eric Seidel.
2314
2315         Move WebKit2 into Source
2316         https://bugs.webkit.org/show_bug.cgi?id=52438
2317
2318         * MiniBrowser/qt/MiniBrowser.pro:
2319         * Scripts/build-webkit:
2320         * Scripts/do-file-rename:
2321         * Scripts/do-webcore-rename:
2322         * Scripts/test-webkitpy:
2323         * Scripts/webkitdirs.pm:
2324         * Scripts/webkitpy/style/checker.py:
2325         * WebKitTestRunner/DerivedSources.pro:
2326         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2327         * WebKitTestRunner/qt/WebKitTestRunner.pro:
2328
2329 2011-01-15  Jochen Eisinger  <jochen@chromium.org>
2330
2331         Reviewed by David Levin.
2332
2333         [chromium] remove obsolete createView method
2334         https://bugs.webkit.org/show_bug.cgi?id=52437
2335
2336         * DumpRenderTree/chromium/WebViewHost.cpp:
2337         (WebViewHost::createView):
2338         * DumpRenderTree/chromium/WebViewHost.h:
2339
2340 2011-01-14  Brian Weinstein  <bweinstein@apple.com>
2341
2342         Reviewed by Geoff Garen.
2343
2344         ShouldLoadResourceForFrame should use strings, not URLs.
2345         https://bugs.webkit.org/show_bug.cgi?id=52476
2346
2347         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2348         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Update to use a WKStringRef.
2349         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2350
2351 2011-01-14  Tony Gentilcore  <tonyg@chromium.org>
2352
2353         Reviewed by David Levin.
2354
2355         Add Tony Gentilcore as a reviewer
2356         https://bugs.webkit.org/show_bug.cgi?id=52480
2357
2358         * Scripts/webkitpy/common/config/committers.py:
2359
2360 2011-01-14  David Levin  <levin@chromium.org>
2361
2362         Reviewed by Eric Seidel.
2363
2364         check-webkit-style: _FunctionState should keep track of where the function name starts.
2365         https://bugs.webkit.org/show_bug.cgi?id=52454
2366
2367         * Scripts/webkitpy/style/checkers/cpp.py: Added function_name_start_position to
2368         _FunctionState and logic for setting it correctly.
2369         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests.
2370
2371 2011-01-14  Vincent Scheib  <scheib@chromium.org>
2372
2373         Reviewed by David Levin.
2374
2375         Add support to DumpRenderTree to use the GPU rather than software renderer
2376         https://bugs.webkit.org/show_bug.cgi?id=52333
2377
2378         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2379         (main):
2380         * Scripts/webkitpy/layout_tests/port/chromium.py:
2381         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2382
2383 2011-01-14  Tony Chang  <tony@chromium.org>
2384
2385         Reviewed by Kent Tamura.
2386
2387         [chromium] update fonts.conf to fix 6 linux tests in drt
2388         https://bugs.webkit.org/show_bug.cgi?id=52411
2389
2390         * DumpRenderTree/chromium/fonts.conf: Update to match the copy in
2391             chromium's src/webkit/tools/test_shell/resources/fonts.conf
2392
2393 2011-01-14  Eric Seidel  <eric@webkit.org>
2394
2395         Original patch from Peter Gal  <galpater@inf.u-szeged.hu>
2396
2397         Reviewed by Adam Barth.
2398
2399         Fix when running Tools/Scripts/check-webkit-style without arguments.
2400         https://bugs.webkit.org/show_bug.cgi?id=52261#c16
2401
2402         * Scripts/webkitpy/common/checkout/scm.py: Handle None for changed_files argument better in Git.create_patch method.
2403         * Scripts/webkitpy/common/checkout/scm_unittest.py:
2404
2405 2011-01-04  Jochen Eisinger  <jochen@chromium.org>
2406
2407         Reviewed by David Levin.
2408
2409         Store the tempdir object in a variable so it doesn't get deleted too early.
2410         https://bugs.webkit.org/show_bug.cgi?id=51875
2411
2412         * Scripts/update-webkit-auxiliary-libs:
2413         * Scripts/update-webkit-support-libs:
2414
2415 2011-01-14  Eric Seidel  <eric@webkit.org>
2416
2417         Unreviewed.  Make it work in python 2.5.
2418
2419         webkit-patch suggest-reviewers dies when ChangeLogs are missing
2420         https://bugs.webkit.org/show_bug.cgi?id=49158
2421
2422         * Scripts/webkitpy/common/checkout/api_unittest.py:
2423
2424 2011-01-14  Sheriff Bot  <webkit.review.bot@gmail.com>
2425
2426         Unreviewed, rolling out r75774.
2427         http://trac.webkit.org/changeset/75774
2428         https://bugs.webkit.org/show_bug.cgi?id=52431
2429
2430         gtk builds were broken (Requested by loislo2 on #webkit).
2431
2432         * Scripts/webkitpy/common/checkout/scm.py:
2433
2434 2011-01-14  David Levin  <levin@chromium.org>
2435
2436         Reviewed by Shinichiro Hamaji.
2437
2438         check-webkit-style: _FunctionState should detect pure functions.
2439         https://bugs.webkit.org/show_bug.cgi?id=52428
2440
2441         * Scripts/webkitpy/style/checkers/cpp.py: Added detection for if a function declaration
2442         is a pure virtual function.
2443         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests for verifying that pure
2444         virtual functions are correctly detected.
2445
2446 2011-01-13  Ilya Tikhonovsky  <loislo@chromium.org>
2447
2448         Reviewed by Yury Semikhatsky.
2449
2450         Just small fix for problem with check-webkit-style.
2451         It just didn't work for this patch.
2452         Old code can't concatenate a list of strings with None.
2453
2454         * Scripts/webkitpy/common/checkout/scm.py:
2455
2456 2011-01-13  David Levin  <levin@chromium.org>
2457
2458         Reviewed by Shinichiro Hamaji.
2459
2460         check-webkit-style: _FunctionState should use Position to know where items are.
2461         https://bugs.webkit.org/show_bug.cgi?id=52424
2462
2463         * Scripts/webkitpy/style/checkers/cpp.py:
2464         (_FunctionState.*): Changed _FunctionState to use Position instead of line numbers.
2465         (detect_functions): Changed to pass Position's to _FunctionState.begin and
2466         did some minor clean-up.
2467         (*): Other changes are simply about converting to use the Position's in_FunctionState
2468         instead of line numbers.
2469         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Changed the test code
2470         to verify the positions stored in _FunctionState.
2471
2472 2011-01-13  Eric Seidel  <eric@webkit.org>
2473
2474         Reviewed by David Levin.
2475
2476         webkit-patch suggest-reviewers dies when ChangeLogs are missing
2477         https://bugs.webkit.org/show_bug.cgi?id=49158
2478
2479         This is not the most elegant, but it is a very safe fix to this bug.
2480         One advantage of catching ScriptError like this instead of adding a
2481         new added_or_modified_files or fixing all changed_files callers
2482         to use a more specific change_files variant, is that we catch
2483         all kinds of ScriptErrors which might cause our (non-essential)
2484         suggest-reviewers code to fail out.  This should make passing
2485         --suggest-reviewers to webkit-patch upload much more robust
2486         and may even make it possible for us to make it default.
2487
2488         The root of the problem here is that SCM.changed_files includes
2489         deleted ChangeLog paths (from moves, etc) which then when we ask
2490         SVN/Git for the contents of the file at that revision, the command
2491         errors out and Executive.run_command raises a ScriptError.
2492
2493         In the future we might fix this differently by making all current
2494         callers of chagned_files use a more specific method for requesting
2495         what types of changes they're interested in (adds, modifies, deletes, etc.)
2496
2497         * Scripts/webkitpy/common/checkout/api.py:
2498         * Scripts/webkitpy/common/checkout/api_unittest.py:
2499
2500 2011-01-13  Dan Bernstein  <mitz@apple.com>
2501
2502         Reviewed by Alexey Proskuryakov.
2503
2504         <rdar://problem/8827065> REGRESSION (r71884): Cross-origin XHR fails if willSendRequest changes the URL
2505         https://bugs.webkit.org/show_bug.cgi?id=52419
2506
2507         Allow to further control the behavior of the willSendRequest delegate callback by making it
2508         set a different URL in the new request.
2509
2510         * DumpRenderTree/LayoutTestController.cpp:
2511         (addURLToRedirectCallback): Added.
2512         (LayoutTestController::staticFunctions): Added addURLToRedirect.
2513         (LayoutTestController::addURLToRedirect): Added. Adds the redirection to the map.
2514         (LayoutTestController::redirectionDestinationForURL): Added this getter.
2515         * DumpRenderTree/LayoutTestController.h:
2516         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2517         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]): Check
2518         if there is a redirection for the request’s URL, established by addURLToRedirect(), and if so,
2519         change the URL in the new request to the redirect destination.
2520
2521 2011-01-13  Eric Seidel  <eric@webkit.org>
2522
2523         Reviewed by Mihai Parparita.
2524
2525         webkit-patch suggest-reviewers fails due to invalid utf8 in ChangeLog files
2526         https://bugs.webkit.org/show_bug.cgi?id=52416
2527
2528         Example: webkit-patch suggest-reviewers -g ca3890fe74d94d85d6bfa48f9ea497b094d8e717 
2529         UnicodeDecodeError: 'utf8' codec can't decode bytes in position 536-538: invalid data
2530
2531         I also added FIXMEs about the changed_files returning deleted files problem
2532         which is causing the other most common exception for suggest-reviewers
2533         (and is probably breaking sheriff-bots blame detection).
2534
2535         * Scripts/webkitpy/common/checkout/api.py:
2536         * Scripts/webkitpy/common/checkout/api_unittest.py:
2537         * Scripts/webkitpy/common/checkout/scm.py:
2538
2539 2011-01-13  Eric Seidel  <eric@webkit.org>
2540
2541         Reviewed by Adam Barth.
2542
2543         results archives from commit-queue are too large to upload
2544         https://bugs.webkit.org/show_bug.cgi?id=52405
2545
2546         * Scripts/webkitpy/common/system/filesystem.py:
2547         * Scripts/webkitpy/common/system/filesystem_mock.py:
2548         * Scripts/webkitpy/tool/commands/queues.py:
2549
2550 2011-01-13  Alejandro G. Castro  <alex@igalia.com>
2551
2552         Reviewed by Martin Robinson.
2553
2554         [gtk] Zero-sized font does not yet work
2555         https://bugs.webkit.org/show_bug.cgi?id=49793
2556
2557         Set minimum-font-size to 0 for the DRT.
2558
2559         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2560         (resetDefaultsToConsistentValues):
2561
2562 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
2563
2564         Reviewed by Darin Adler.
2565
2566         Make old-run-webkit-tests more robust on buildbots
2567         https://bugs.webkit.org/show_bug.cgi?id=52364
2568
2569         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Pass --exit-after-n-failures 500 to old-run-webkit-tests script.
2570
2571 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
2572
2573         Reviewed by Darin Adler.
2574
2575         Make old-run-webkit-tests more robust on buildbots
2576         https://bugs.webkit.org/show_bug.cgi?id=52364
2577
2578         * Scripts/old-run-webkit-tests: Ensure that testResultsDirectory is empty.
2579
2580 2011-01-13  Tony Chang  <tony@chromium.org>
2581
2582         Reviewed by Kent Tamura.
2583
2584         [chromium] fix plugins/plugin-javascript-access.html on Linux and Mac
2585         https://bugs.webkit.org/show_bug.cgi?id=52332
2586
2587         Forked Info.plist is not longer needed.
2588
2589         * DumpRenderTree/chromium/TestNetscapePlugIn/Info.plist: Removed.
2590
2591 2011-01-13  Mikhail Naganov  <mnaganov@chromium.org>
2592
2593         Reviewed by Timothy Hatcher.
2594
2595         Web Inspector: Cleanup after r75613 -- make all UI-facing strings
2596         to be passed directly to WebInspector.UIString
2597
2598         https://bugs.webkit.org/show_bug.cgi?id=52365
2599
2600         * Scripts/check-inspector-strings:
2601
2602 2011-01-13  Sheriff Bot  <webkit.review.bot@gmail.com>
2603
2604         Unreviewed, rolling out r74881.
2605         http://trac.webkit.org/changeset/74881
2606         https://bugs.webkit.org/show_bug.cgi?id=52357
2607
2608         The EFL builder has been red for days (Requested by abarth on
2609         #webkit).
2610
2611         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2612         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2613
2614 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
2615
2616         Reviewed by David Levin.
2617
2618         Add beforeunload support to WebKitTestRunner
2619         https://bugs.webkit.org/show_bug.cgi?id=52353
2620         
2621         This makes a number of currently failing tests pass.
2622
2623         * WebKitTestRunner/TestController.cpp:
2624         (WTR::runBeforeUnloadConfirmPanel):
2625         (WTR::createOtherPage):
2626         (WTR::TestController::initialize):
2627
2628 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
2629
2630         Reviewed by Sam Weinig.
2631
2632         Detect, identify and recover from WebProcess crashes in run-webkit-tests
2633         https://bugs.webkit.org/show_bug.cgi?id=52330
2634
2635         * Scripts/old-run-webkit-tests: Detect when the regression test tool reports
2636         a web process crash.
2637         * WebKitTestRunner/TestController.cpp:
2638         (WTR::TestController::initialize): Set up a processDidCrash
2639         callback.
2640         (WTR::TestController::processDidCrash): Report that the Web process
2641         crashed.
2642         * WebKitTestRunner/TestController.h:
2643
2644 2011-01-12  David Levin  <levin@chromium.org>
2645
2646         Reviewed by Shinichiro Hamaji.
2647
2648         check-webkit-style -- close_expression function doesn't work correctly.
2649         https://bugs.webkit.org/show_bug.cgi?id=52272
2650
2651         * Scripts/webkitpy/style/checkers/cpp.py:
2652         (Position.__str__): Added a way to convert it to a string which is useful in tests.
2653         (Position.__cmp__): Added a way to compare Position which is useful in tests and
2654         generally useful (for upcoming code changes).
2655         (close_expression): Changed to use Position for input and output.
2656         Also, fixed many bugs such as only working correctly for parenthesis,
2657         not working correctly if given an offset in a line and not finding
2658         the real closing element if there were multiple closing elements in
2659         the same line.
2660         (detect_functions): Adjusted due to the change in arguments for
2661         close_expression.
2662         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2663         (CppStyleTestBase.assert_positions_equal): Added a way to verify that
2664         two positions are the same.
2665         (CppStyleTest.test_position): Added tests for the __str_ and __cmp__ methods.
2666         (CppStyleTest.test_close_expression): Added tests to catch the issues
2667         that were fixed.
2668
2669 2011-01-12  Sheriff Bot  <webkit.review.bot@gmail.com>
2670
2671         Unreviewed, rolling out r75576.
2672         http://trac.webkit.org/changeset/75576
2673         https://bugs.webkit.org/show_bug.cgi?id=52304
2674
2675         broke rebaseline-chromium-webkit-test (Requested by thakis on
2676         #webkit).
2677
2678         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2679         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2680         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
2681         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2682         * Scripts/webkitpy/layout_tests/port/base.py:
2683         * Scripts/webkitpy/layout_tests/port/chromium.py:
2684         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2685         * Scripts/webkitpy/layout_tests/port/test.py:
2686         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2687         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2688         * Scripts/webkitpy/style/checkers/test_expectations.py:
2689         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
2690
2691 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
2692
2693         Reviewed by Darin Adler.
2694
2695         Add a no-build option to run-webkit-tests, to avoid building DRT/WKTR
2696         https://bugs.webkit.org/show_bug.cgi?id=52307
2697
2698         * Scripts/old-run-webkit-tests:
2699
2700 2011-01-12  Koan-Sin Tan  <koansin.tan@gmail.com>
2701
2702         Reviewed by Martin Robinson.
2703
2704         [Gtk] WebKitGtk+ doesn't build on Mac OS X 10.6
2705         https://bugs.webkit.org/show_bug.cgi?id=50867
2706
2707         Fixed library extention for Mac in webkitdirs.pm and type conflict in
2708         TestNetscapePlugin.cpp 
2709
2710         * GNUmakefile.am: Don't use AppKit when compiling TestNetscapePlugin for GTK+
2711         * Scripts/webkitdirs.pm:
2712
2713 2011-01-12  Mikhail Naganov  <mnaganov@chromium.org>
2714
2715         Reviewed by Pavel Feldman.
2716
2717         Add check-inspector-strings script.
2718
2719         https://bugs.webkit.org/show_bug.cgi?id=52295
2720
2721         * Scripts/check-inspector-strings: Added.
2722
2723 2011-01-12  Adam Roben  <aroben@apple.com>
2724
2725         Advertise the .testnetscape file extension on Windows
2726
2727         Fixes <http://webkit.org/b/52298>
2728         plugins/no-mime-with-valid-extension.html fails on Windows
2729
2730         Reviewed by Dan Bernstein.
2731
2732         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Added a
2733         FileExtents field to map the .testnetscape file extension to the
2734         application/x-webkit-test-netscape MIME type, just as we do on Mac.
2735
2736 2011-01-12  Adam Barth  <abarth@webkit.org>
2737
2738         Reviewed by Eric Seidel.
2739
2740         Make webkit-patch support subdirectories for SVN checkouts
2741         https://bugs.webkit.org/show_bug.cgi?id=52261
2742
2743         os.relpath does not exist on Python 2.5, so we need to call our version
2744         of the API.
2745
2746         * Scripts/webkitpy/common/checkout/scm.py:
2747
2748 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
2749
2750         Reviewed by Eric Seidel.
2751
2752         Close additional pages opened during a test once the test completes.
2753         https://bugs.webkit.org/show_bug.cgi?id=52276
2754
2755         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2756         (WTR::InjectedBundle::done):
2757
2758 2011-01-11  David Levin  <levin@chromium.org>
2759
2760         Reviewed by Eric Seidel.
2761
2762         Errors should be separated from the command line in bot messages.
2763         https://bugs.webkit.org/show_bug.cgi?id=52275
2764
2765         * Scripts/webkitpy/common/system/executive.py:
2766         (ScriptError.message_with_output): Added a newline to separate the command
2767         line from the errors.
2768         * Scripts/webkitpy/common/system/executive_unittest.py:
2769         (ScriptErrorTest.test_message_with_output): Added tests for the various code
2770         paths in message_with_output.
2771
2772 2011-01-11  Eric Seidel  <eric@webkit.org>
2773
2774         Unreviewed.
2775
2776         commit-queue should know how to upload archived results (for test flakes or general failures)
2777         https://bugs.webkit.org/show_bug.cgi?id=52048
2778
2779         The zips are mostly empty due to forgetting -r.
2780         Expected diffs were not being pulled from the archive due
2781         to the archive having longer paths than I realized.
2782
2783         * Scripts/webkitpy/common/system/workspace.py:
2784         * Scripts/webkitpy/common/system/workspace_unittest.py:
2785         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2786         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2787
2788 2011-01-11  Dirk Pranke  <dpranke@chromium.org>
2789
2790         Reviewed by Ojan Vafai.
2791
2792         The current modifier parsing code in test_expectations is
2793         fragile and hard-coded, so it's not easy to understand the logic
2794         or easily add new types of modifiers (like GPU vs. CPU testing
2795         for graphics tests, or 32-bit vs. 64-bit differences).
2796
2797         This is the first of two patches that will add in more generic
2798         support and then eliminate the GPU-specific test expectations
2799         files for Chromium.
2800
2801         This patch adds two standalone objects for handling modifiers. The
2802         rules for interpreting modifiers, precedence, and conflicts are
2803         given in the docstring to the ModifierMatcher class, which
2804         returns ModifierMatchResult objects.
2805         
2806         This patch also adds routines to the Port interface and a
2807         default set of values in the base object, in order to obtain the
2808         values needed on a given test run. These values are then passed
2809         to the expectation parser. This also allows us to clean up the
2810         logic used to lint all of the different configurations in a
2811         single test_expectations.txt file.
2812
2813         The next patch will merge in the separate GPU expectations file.
2814
2815         https://bugs.webkit.org/show_bug.cgi?id=51222
2816
2817         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2818         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2819         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
2820         * Scripts/webkitpy/layout_tests/port/base.py:
2821         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2822         * Scripts/webkitpy/layout_tests/port/chromium.py:
2823         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2824         * Scripts/webkitpy/layout_tests/port/test.py:
2825         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2826         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2827
2828 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
2829
2830         Reviewed by Adam Barth.
2831
2832         Make webkit-patch support subdirectories for SVN checkouts
2833         https://bugs.webkit.org/show_bug.cgi?id=52261
2834
2835         * Scripts/webkitpy/common/checkout/scm.py:
2836         * Scripts/webkitpy/style_references.py:
2837         * Scripts/webkitpy/tool/main.py:
2838         * Scripts/webkitpy/tool/steps/preparechangelog.py:
2839
2840 2011-01-11  Eric Seidel  <eric@webkit.org>
2841
2842         Unreviewed.
2843
2844         commit-queue should know how to upload archived results (for test flakes or general failures)
2845         https://bugs.webkit.org/show_bug.cgi?id=52048
2846
2847         I changed the API for archive_last_layout_test_results w/o updating the implementation.  Oops.
2848         This fixes an exception seen on the commit-queue when attempting to report flaky tests.
2849
2850         * Scripts/webkitpy/common/system/workspace.py:
2851         * Scripts/webkitpy/common/system/workspace_unittest.py:
2852         * Scripts/webkitpy/tool/commands/queues.py:
2853
2854 2011-01-11  Sam Weinig  <sam@webkit.org>
2855
2856         Roll r75474 back in.
2857
2858 2011-01-11  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
2859
2860         Reviewed by Kenneth Rohde Christiansen.
2861
2862         [Qt] Remove uses of QFuture since it isn't supported on all platforms.
2863         https://bugs.webkit.org/show_bug.cgi?id=51204
2864
2865         * QtTestBrowser/webpage.h:
2866         (QtNAMThread::QtNAMThread):
2867         (QtNAMThread::networkAccessManager):
2868         (QtNAMThread::run):
2869
2870 2011-01-11  Peter Varga  <pvarga@webkit.org>
2871
2872         Unreviewed.
2873
2874         Add myself to committers' list.
2875
2876         * Scripts/webkitpy/common/config/committers.py:
2877
2878 2011-01-11  Eric Seidel  <eric@webkit.org>
2879
2880         Reviewed by Adam Barth.
2881
2882         commit-queue should know how to upload archived results (for test flakes or general failures)
2883         https://bugs.webkit.org/show_bug.cgi?id=52048
2884
2885         Now the queue will always upload results.  Either the entire zip, or just
2886         the diffs.txt in the case of text failures.
2887
2888         This should make understanding flakes much easier, and paves the way
2889         for having the EWS run layout tests (and upload failures).
2890
2891         In order to upload .zip files I had to teach bugzilla.py to autodetect
2892         mime types from the filename.  Since mimetypes.py doesn't include a mapping
2893         for .patch files, I have it add one before calling guess_type.
2894
2895         We may find that always uploading the whole zip instead of just the -diffs.txt
2896         file is preferable, but for now I'm keeping the old behavior because it makes
2897         quickly understanding text failures easy.
2898
2899         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2900         * Scripts/webkitpy/common/system/workspace.py: Added.
2901         * Scripts/webkitpy/common/system/workspace_unittest.py: Added.
2902         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2903         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2904         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2905         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2906         * Scripts/webkitpy/tool/commands/queues.py:
2907         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2908
2909 2011-01-10  Sheriff Bot  <webkit.review.bot@gmail.com>
2910
2911         Unreviewed, rolling out r75464.
2912         http://trac.webkit.org/changeset/75464
2913         https://bugs.webkit.org/show_bug.cgi?id=52193
2914
2915         Followup rollout for 75474 (Requested by Ossy on #webkit).
2916
2917         * MiniBrowser/mac/BrowserWindowController.m:
2918         (-[BrowserWindowController awakeFromNib]):
2919         * MiniBrowser/win/BrowserView.cpp:
2920         (BrowserView::create):
2921         * WebKitTestRunner/TestController.cpp:
2922         (WTR::createOtherPage):
2923         (WTR::TestController::initialize):
2924
2925 2011-01-10  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2926
2927         Reviewed by Csaba Osztrogonác.
2928
2929         [Qt] Baseline qt_minimal configuration
2930         https://bugs.webkit.org/show_bug.cgi?id=51313
2931
2932         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2933         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): Add
2934         QT_NO_UNDOSTACK guard.
2935
2936         * QtTestBrowser/launcherwindow.cpp:
2937         (LauncherWindow::createChrome): Add QT_NO_SHORTCUT and QT_NO_PRINTER
2938         guards.
2939         (LauncherWindow::applyZoom): Add QT_NO_ANIMATION guard.
2940         (LauncherWindow::screenshot): Add QT_NO_FILEDIALOG guard.
2941         (LauncherWindow::selectElements): Add QT_NO_INPUTDIALOG guard.
2942         (LauncherWindow::showUserAgentDialog): Add QT_NO_COMBOBOX guard.
2943
2944         * QtTestBrowser/launcherwindow.h:
2945         * QtTestBrowser/locationedit.cpp: Add QT_NO_INPUTDIALOG guard.
2946         * QtTestBrowser/locationedit.h: Ditto.
2947
2948         * QtTestBrowser/mainwindow.cpp:
2949         (MainWindow::buildUI): Add QT_NO_INPUTDIALOG, QT_NO_SHORTCUT and
2950         QT_NO_UNDOSTACK guards.
2951         (MainWindow::setAddressUrl): Add QT_NO_INPUTDIALOG guard.
2952         (MainWindow::changeLocation): Ditto.
2953         (MainWindow::openFile): Add QT_NO_FILEDIALOG guard.
2954         (MainWindow::openLocation): Add QT_NO_INPUTDIALOG guard.
2955
2956         * QtTestBrowser/webpage.cpp:
2957         (WebPage::openUrlInDefaultBrowser): Add QT_NO_DESKTOPSERVICES guard.
2958         (WebPage::authenticationRequired): Add QT_NO_LINEEDIT guard.
2959
2960         * QtTestBrowser/webview.cpp:
2961         (WebViewGraphicsBased::animatedFlip): Add QT_NO_ANIMATION guard.
2962         (WebViewGraphicsBased::animatedYFlip): Ditto.
2963
2964 2011-01-10  Sam Weinig  <sam@webkit.org>
2965
2966         Fix build.
2967
2968         * MiniBrowser/mac/BrowserWindowController.m:
2969         (-[BrowserWindowController awakeFromNib]):
2970         * MiniBrowser/win/BrowserView.cpp:
2971         (BrowserView::create):
2972         * WebKitTestRunner/TestController.cpp:
2973         (WTR::createOtherPage):
2974         (WTR::TestController::initialize):
2975
2976 2011-01-10  Eric Seidel  <eric@webkit.org>
2977
2978         Reviewed by Ojan Vafai.
2979
2980         style-queue messages are way too long for big patches
2981         https://bugs.webkit.org/show_bug.cgi?id=52161
2982
2983         We definitely could build much fancier list-to-string-with-limit functions
2984         but this should be sufficient for our needs at the moment.
2985
2986         * Scripts/webkitpy/common/system/executive.py:
2987         * Scripts/webkitpy/common/system/executive_unittest.py:
2988
2989 2011-01-10  Tony Chang  <tony@chromium.org>
2990
2991         Unreviewed, rolling out r75398.
2992         http://trac.webkit.org/changeset/75398
2993         https://bugs.webkit.org/show_bug.cgi?id=52008
2994
2995         Some layout tests are crashing on Chromium Win.
2996
2997         * DumpRenderTree/chromium/WebViewHost.cpp:
2998         (WebViewHost::updatePaintRect):
2999         * DumpRenderTree/chromium/WebViewHost.h:
3000
3001 2011-01-10  Adam Roben  <aroben@apple.com>
3002
3003         Roll out r75392
3004
3005         It isn't needed now that r75289 has been rolled out.
3006
3007         * Scripts/run-javascriptcore-tests:
3008
3009 2011-01-10  Maciej Stachowiak  <mjs@apple.com>
3010
3011         Reviewed by Anders Carlsson.
3012
3013         WebKitTestRunner uses crazy amounts of CPU, making layout tests slow and flaky
3014         https://bugs.webkit.org/show_bug.cgi?id=52160
3015
3016         * WebKitTestRunner/mac/TestControllerMac.mm:
3017         (WTR::TestController::platformRunUntil): Instead of busy-looping, wait for the timeout.
3018         Anything that can make runUntil() conditions turn true will happen on a run loop cycle
3019         anyway.
3020
3021 2011-01-10  Tony Chang  <tony@chromium.org>
3022
3023         Reviewed by Mihai Parparita.
3024
3025         [chromium] fix for animated gif layout tests
3026         https://bugs.webkit.org/show_bug.cgi?id=52008
3027
3028         * DumpRenderTree/chromium/WebViewHost.cpp: Schedule a paint when we update the paint rect
3029             to trigger gif animations.
3030         (WebViewHostPaintTask::WebViewHostPaintTask):
3031         (WebViewHostPaintTask::runIfValid):
3032         (WebViewHost::updatePaintRect):
3033         * DumpRenderTree/chromium/WebViewHost.h:
3034         (WebViewHost::taskList):
3035
3036 2011-01-10  Alejandro G. Castro  <alex@igalia.com>
3037
3038         Reviewed by Xan Lopez.
3039
3040         [GTK] Fix gtk2 compilation for master
3041         https://bugs.webkit.org/show_bug.cgi?id=51885
3042
3043         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
3044         (createBitmapContextFromWebView): Replaced the old
3045         gdk_drawable_get_size with gdk_pixmap_get_size.
3046
3047 2011-01-10  Patrick Gansterer  <paroga@webkit.org>
3048
3049         Reviewed by Laszlo Gombos.
3050
3051         [WINCE] Reenable NPAPI after r75203
3052         https://bugs.webkit.org/show_bug.cgi?id=52109
3053
3054         Remove the !isWinCE() check for ENABLE_NETSCAPE_PLUGIN_API and replace
3055         it with !isEfl(), because EFL port does not support NPAPI (yet).
3056
3057         * Scripts/build-webkit:
3058
3059 2011-01-10  Adam Roben  <aroben@apple.com>
3060
3061         Skip some asserting JS tests
3062
3063         See <http://webkit.org/b/52156>.
3064
3065         * Scripts/run-javascriptcore-tests:
3066
3067 2011-01-10  Martin Robinson  <mrobinson@igalia.com>
3068
3069         Reviewed by Xan Lopez.
3070
3071         [GTK] build-webkit disable Blob support via arguments passed to automake
3072         https://bugs.webkit.org/show_bug.cgi?id=52097
3073
3074         * Scripts/build-webkit: Enable Blob support when building WebKitGTK+ via
3075         build-webkit.
3076
3077 2011-01-10  Adam Roben  <aroben@apple.com>
3078
3079         Use the same name and description for TestNetscapePlugin on Windows and
3080         Mac
3081
3082         Fixes <http://webkit.org/b/52151>
3083         fast/frames/iframe-reparenting-plugins.html fails on Windows
3084
3085         Reviewed by Steve Falkenburg.
3086
3087         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Copied
3088         the name and description from Mac's Info.plist.
3089
3090 2011-01-10  Siddharth Mathur <siddharth.mathur@nokia.com>
3091
3092         Reviewed by Laszlo Gombos.
3093
3094         [Qt][WK2] Guard gcc-specific syntax
3095
3096         Non-gcc based compliers choke on the "-include"
3097         syntax for preinclude, place guard around it.
3098
3099         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3100         * WebKitTestRunner/qt/WebKitTestRunner.pro:
3101
3102 2011-01-10  Andreas Kling  <kling@webkit.org>
3103
3104         Reviewed by Simon Hausmann.
3105
3106         [Qt] [WK2] MiniBrowser does not load pages opened in new windows
3107         https://bugs.webkit.org/show_bug.cgi?id=52111
3108
3109         When getting a createNewPage() callback from QWKPage, create the
3110         new page with the same QWKContext as the page that is passed to
3111         the callback.
3112
3113         * MiniBrowser/qt/BrowserView.h:
3114         * MiniBrowser/qt/BrowserWindow.cpp:
3115         (newPageFunction):
3116         (BrowserWindow::BrowserWindow):
3117         * MiniBrowser/qt/BrowserWindow.h:
3118
3119 2011-01-10  Andreas Kling  <kling@webkit.org>
3120
3121         Reviewed by Kenneth Rohde Christiansen.
3122
3123         [Qt] MiniBrowser: Remove superfluous createNewPage() callback
3124
3125         BrowserView set its own useless createNewPage() callback on QWKPage.
3126         This was immediately overridden by BrowserWindow anyway, so remove
3127         the BrowserView one.
3128
3129         * MiniBrowser/qt/BrowserView.cpp:
3130         (BrowserView::BrowserView):
3131
3132 2011-01-10  John Knottenbelt  <jknotten@chromium.org>
3133
3134         Reviewed by Jeremy Orlow.
3135
3136         [Chromium] Remove non-client-based Geolocation code
3137         https://bugs.webkit.org/show_bug.cgi?id=50921
3138
3139         * DumpRenderTree/chromium/LayoutTestController.cpp:
3140         (LayoutTestController::setGeolocationPermission):
3141         (LayoutTestController::setMockGeolocationPosition):
3142         (LayoutTestController::setMockGeolocationError):
3143         * DumpRenderTree/chromium/WebViewHost.cpp:
3144         (WebViewHost::geolocationClientMock):
3145         (WebViewHost::reset):
3146         * DumpRenderTree/chromium/WebViewHost.h:
3147
3148 2011-01-10  Eric Seidel  <eric@webkit.org>
3149
3150         Reviewed by Adam Barth.
3151
3152         Commit bot tried to land r? cq+ patch
3153         https://bugs.webkit.org/show_bug.cgi?id=36638
3154
3155         It should now be possible to post a patch with r? and cq+ and the
3156         commit-queue will correctly wait for the r+ before attempting to land the patch.
3157         (This was a feature requested by several users.)
3158
3159         One caveat: We don't actually reject r-, cq+ patches from the queue
3160         (we just ignore them), but I think that's OK for now.
3161
3162         I also noticed that setting r- once a commit-queue node had grabbed
3163         a patch would not properly cancel the landing.  That's fixed and
3164         tested in this patch.
3165
3166         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3167         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3168         * Scripts/webkitpy/tool/bot/feeders.py:
3169         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
3170
3171 2011-01-08  Benjamin Poulain  <benjamin.poulain@nokia.com>
3172
3173         Reviewed by Kenneth Rohde Christiansen.
3174
3175         [Qt] QtWebKit crashes when using XMLHttpRequest from the unload event
3176         https://bugs.webkit.org/show_bug.cgi?id=51934
3177
3178         When accessing the network from the destructor of QWebPage, the network access manager
3179         was already deleted because the object WebPage was already destructed.
3180
3181         This solve the problem by linking the lifetime of the network access manager to WebPage's QObject.
3182         The object is now destructed in the destructor of QObject.
3183
3184         * QtTestBrowser/webpage.cpp:
3185         (WebPage::WebPage):
3186         (WebPage::setQnamThreaded):
3187         * QtTestBrowser/webpage.h:
3188         (QtNAMThread::QtNAMThread):
3189
3190 2011-01-08  Eric Seidel  <eric@webkit.org>
3191
3192         Reviewed by Ojan Vafai.
3193
3194         test_failures.py should not mention TestShell (long live DumpRenderTree!)
3195         https://bugs.webkit.org/show_bug.cgi?id=52067
3196
3197         I ran test-webkitpy, but didn't bother adding a unit test for this string change.
3198         https://bugs.webkit.org/show_bug.cgi?id=51138#c3 is an example of why this is needed.
3199
3200         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
3201
3202 2011-01-08  Eric Seidel  <eric@webkit.org>
3203
3204         Reviewed by Mihai Parparita.
3205
3206         commit-queue hangs when the ChangeLog diff is bad
3207         https://bugs.webkit.org/show_bug.cgi?id=52072
3208
3209         * Scripts/webkitpy/tool/steps/validatechangelogs.py:
3210         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
3211
3212 2011-01-08  Adam Barth  <abarth@webkit.org>
3213
3214         Teach svn-apply how to re-write WebCore to Source/WebCore.
3215
3216         * Scripts/VCSUtils.pm:
3217
3218 2011-01-07  Adam Barth  <abarth@webkit.org>
3219
3220         Rubber-stamped by Eric Seidel.
3221
3222         Move WebCore to Source
3223         https://bugs.webkit.org/show_bug.cgi?id=52050
3224
3225         Update the tools to understand WebCore's new location.
3226
3227         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3228         * DumpRenderTree/wscript:
3229         * GNUmakefile.am:
3230         * Scripts/build-webkit:
3231         * Scripts/do-file-rename:
3232         * Scripts/do-webcore-rename:
3233         * Scripts/generate-qt-inspector-resource:
3234         * Scripts/prepare-ChangeLog:
3235         * Scripts/run-bindings-tests:
3236         * Scripts/update-iexploder-cssproperties:
3237         * Scripts/update-sources-list.py:
3238         * Scripts/update-webkit-localizable-strings:
3239         * Scripts/webkitdirs.pm:
3240         * Scripts/webkitpy/common/config/build.py:
3241         * Scripts/webkitpy/common/config/build_unittest.py:
3242         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
3243         * Scripts/webkitpy/style/checker.py:
3244         * Scripts/webkitpy/style/checker_unittest.py:
3245         * WebKitTestRunner/DerivedSources.pro:
3246         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3247         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh:
3248         * wx/browser/wscript:
3249         * wx/build/settings.py:
3250
3251 2011-01-07  Maciej Stachowiak  <mjs@apple.com>
3252
3253         Reviewed by Sam Weinig.
3254
3255         Make WebKitTestRunner rest between loads more robust to avoid test crashes
3256         https://bugs.webkit.org/show_bug.cgi?id=52086
3257
3258         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3259         (WTR::InjectedBundle::didReceiveMessage):
3260         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3261         (WTR::LayoutTestController::notifyDone):
3262         * WebKitTestRunner/TestController.cpp:
3263         (WTR::TestController::resetStateToConsistentValues):
3264         (WTR::TestController::run):
3265
3266 2011-01-07  James Robinson  <jamesr@chromium.org>
3267
3268         Revert "Implement mozilla's animationTime property"
3269         https://bugs.webkit.org/show_bug.cgi?id=51952
3270
3271         This approach isn't quite right.
3272
3273         * DumpRenderTree/chromium/WebViewHost.cpp:
3274         (WebViewHost::paintInvalidatedRegion):
3275
3276 2011-01-07  Adam Roben  <aroben@apple.com>
3277
3278         Build master fix
3279
3280         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3281         (RunWebKitTests.start): Don't try to concatenate a list and a string.
3282
3283 2011-01-07  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>
3284
3285         Reviewed by Csaba Osztrogonác.
3286
3287         run-qtwebkit-tests should be able to kill a testsuite.
3288
3289         Add new option in the script that can setup a timeout for a test.
3290         If the test execution takes more then specified time then the test
3291         would be terminated.
3292
3293         [Qt] run-qtwebkit-tests needs timeout
3294         https://bugs.webkit.org/show_bug.cgi?id=51894
3295
3296         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3297         * Scripts/run-qtwebkit-tests:
3298
3299 2011-01-07  Csaba Osztrogonác  <ossy@webkit.org>
3300
3301         Unreviewed fix after r75233.
3302
3303         Based on idea from Eric Seidel.
3304
3305         Add remote zip file handling to webkitpy.
3306         https://bugs.webkit.org/show_bug.cgi?id=50901
3307
3308         * Scripts/webkitpy/common/system/fileset.py: Make python 2.5 happy.
3309
3310 2011-01-07  Shane Stephens  <shanestephens@google.com>
3311
3312         Reviewed by Eric Seidel.
3313
3314         svn-apply: should support git binary delta diffs
3315         https://bugs.webkit.org/show_bug.cgi?id=38864
3316
3317         * Scripts/VCSUtils.pm:
3318         * Scripts/svn-apply:
3319
3320 2011-01-06  Julie Parent  <jparent@chromium.org>
3321
3322         Reviewed by Eric Seidel.
3323
3324         Test Result Server not removing old results.
3325         https://bugs.webkit.org/show_bug.cgi?id=52012
3326
3327         * TestResultServer/model/jsonresults.py:
3328         Fix off-by-one: Truncate if >= num_runs, not just >.
3329         * TestResultServer/model/jsonresults_unittest.py:
3330         Add unit test to test that merging in a new result with the same value
3331         as the last result causes previous result to fall off.
3332
3333 2011-01-06  James Kozianski  <koz@chromium.org>
3334
3335         Reviewed by Mihai Parparita.
3336
3337         Add classes to provide a consistent interface to a set of files.
3338         https://bugs.webkit.org/show_bug.cgi?id=50901
3339
3340         These classes allow us to write code that is agnostic to whether a
3341         particular set of files resides in a local directory or in a zip file
3342         on a remote machine.
3343
3344         * Scripts/webkitpy/common/system/directoryfileset.py: Added.
3345         * Scripts/webkitpy/common/system/directoryfileset_unittest.py: Added.
3346         * Scripts/webkitpy/common/system/fileset.py: Added.
3347         * Scripts/webkitpy/common/system/filesystem.py:
3348         * Scripts/webkitpy/common/system/filesystem_mock.py:
3349         * Scripts/webkitpy/common/system/zipfileset.py: Added.
3350         * Scripts/webkitpy/common/system/zipfileset_unittest.py: Added.
3351
3352 2011-01-06  Eric Seidel  <eric@webkit.org>
3353
3354         Reviewed by Adam Barth.
3355
3356         NetworkTransaction should log the url it is retrying
3357         https://bugs.webkit.org/show_bug.cgi?id=52043
3358
3359         * Scripts/webkitpy/common/net/networktransaction.py:
3360         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
3361
3362 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
3363
3364         Windows build fix.
3365         Import os before using it.
3366
3367         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3368
3369 2011-01-06  Eric Seidel  <eric@webkit.org>
3370
3371         Reviewed by Adam Barth.
3372
3373         StyleQueue fails to report errors when patches have many files
3374         https://bugs.webkit.org/show_bug.cgi?id=52042
3375
3376         This is one of at least two errors preventing style error reporting at the moment.
3377         When we moved to passing the list of files to check explicitly,
3378         we started to exceed the 500 character TEXT field limit for our AppEngine model object.
3379         We could change the type of the QueueStatus.message type, or we could
3380         just teach statusserver.py how to clamp values (and warn when it does).
3381         I chose the latter path.
3382
3383         * Scripts/webkitpy/common/net/statusserver.py:
3384
3385 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
3386
3387         Reviewed by Stephanie Lewis.
3388         
3389         Fix syntax error in script.
3390
3391         Windows bots need to archive/unarchive builds to/from configuration-specific directories
3392         https://bugs.webkit.org/show_bug.cgi?id=51996
3393
3394         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3395
3396 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3397
3398         Unreviewed, fixing WinCE build after r75196.
3399
3400         WinCE port does not (yet) support NPAPI.
3401
3402         * Scripts/build-webkit:
3403
3404 2011-01-06  Xan Lopez  <xlopez@igalia.com>
3405
3406         Reviewed by Darin Adler.
3407
3408         File::Spec->rel2abs in sunspider-compare-results mangles parameters
3409         https://bugs.webkit.org/show_bug.cgi?id=52015
3410
3411         * Scripts/sunspider-compare-results: call rel2abs on our arguments
3412         after the platform has been detected, otherwise the script will
3413         mangle things like '--gtk' into '/a/path/--gtk', breaking the
3414         detection.
3415
3416 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3417
3418         Reviewed by Eric Seidel.
3419
3420         Add ENABLE_NETSCAPE_PLUGIN_API, ENABLE_ORIENTATION_EVENTS and ENABLE_TOUCH_EVENTS flags to build-webkit
3421         https://bugs.webkit.org/show_bug.cgi?id=51346
3422
3423         * Scripts/build-webkit:
3424
3425 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
3426
3427         Reviewed by Adam Roben.
3428
3429         Windows bots need to archive/unarchive builds to/from configuration-specific directories
3430         https://bugs.webkit.org/show_bug.cgi?id=51996
3431         
3432         After the configuration directory change, we were archiving the incorrect directory for
3433         build product, so we were running tests on the wrong binaries.
3434         
3435         This change archives the correct directory, and also unarchives it into a configuration-
3436         specific directory.
3437
3438         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Use a configuration-specific directory on Windows.
3439         * BuildSlaveSupport/built-product-archive: Unarchive/archive to/from proper directory.
3440
3441 2011-01-06  Eric Seidel  <eric@webkit.org>
3442
3443         Reviewed by Mihai Parparita.
3444
3445         commit-queue mentions "Text diff mismatch" 4 times instead of once per failure
3446         https://bugs.webkit.org/show_bug.cgi?id=52002
3447
3448         See an example of this here:
3449         https://bugs.webkit.org/show_bug.cgi?id=51314#c2
3450
3451         It's due to the fact that we pass around TestFailure() instance
3452         objects and yet expect them to all compare to be the same.
3453
3454         This is bad.  We should either have shared instances of these values
3455         or we should just pass around the class names.  There are already hacks
3456         in place to make TestFailure objects pass equality tests, I just added
3457         a __hash__ implementation so they can be used in sets as expected.
3458
3459         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3460         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
3461
3462 2011-01-06  Evan Martin  <evan@chromium.org>
3463
3464         Reviewed by Tony Chang.
3465
3466         [gdb] handle inaccessible memory and UChar*
3467         https://bugs.webkit.org/show_bug.cgi?id=52003
3468
3469         To pretty-print a UChar*, we just grope around in the memory
3470         looking for a terminating NUL.  We need to handle the exception
3471         that can occur when we poke into an invalid location.
3472
3473         Additionally, the logic for choosing which pretty-printer would
3474         early return before hitting the point where we'd use the UChar*
3475         printer.  (Did this ever work?  How did it regress?)
3476
3477         * gdb/webkit.py:
3478
3479 2011-01-05  Brian Weinstein  <bweinstein@apple.com>
3480
3481         Reviewed by Ada Chan.
3482
3483         WebKit2: Should be able to call into injected bundle to ask if we should allow resource loads
3484         https://bugs.webkit.org/show_bug.cgi?id=51969
3485         
3486         Add shouldLoadResourceForFrame to WTR::InjectedBundlePage.
3487
3488         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3489         (WTR::InjectedBundlePage::InjectedBundlePage):
3490         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Stub implementation.
3491         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3492
3493 2011-01-06  James Robinson  <jamesr@chromium.org>
3494
3495         Reviewed by Simon Fraser.
3496
3497         Implement mozilla's animationTime property
3498         https://bugs.webkit.org/show_bug.cgi?id=51952
3499
3500         Chromium DRT support for webkitAnimationTime.
3501
3502         * DumpRenderTree/chromium/WebViewHost.cpp:
3503         (WebViewHost::paintInvalidatedRegion):
3504
3505 2011-01-06  Julie Parent  <jparent@chromium.org>
3506
3507         Reviewed by Tony Chang.
3508
3509         Test Result Server always truncates number of results to JSON_RESULTS_MAX_BUILDS
3510         https://bugs.webkit.org/show_bug.cgi?id=51217
3511
3512         * TestResultServer/model/jsonresults.py:
3513         Pass num_runs through to _remove_items_over_max_number_of_builds, and use the value.
3514         Adds missing documentation.
3515         * TestResultServer/model/jsonresults_unittest.py:
3516         Add unit test to test that truncation happens at smaller value than JSON_RESULTS_MAX_BUILDS.
3517         Update test_merge to take a number of builds to truncate at.
3518
3519 2011-01-06  Adam Barth  <abarth@webkit.org>
3520
3521         Reviewed by Eric Seidel.
3522
3523         The EWS should log outside of the working directory
3524         https://bugs.webkit.org/show_bug.cgi?id=51986
3525
3526         This patch prepare us for using git clean -x -d -f in the EWS wrapper
3527         script, which will actually clean the working copy back to a pristine
3528         state instead of leaving untracked directories and ignored files.
3529
3530         * Scripts/webkitpy/tool/commands/queues.py:
3531         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3532
3533 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
3534
3535         Windows build fix.
3536         Back out attempted change to built-product-archive.
3537
3538         * BuildSlaveSupport/built-product-archive:
3539
3540 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
3541
3542         Windows build fix.
3543         Include configuration name when unpacking a build archive.
3544
3545         Needed, since we split Windows build results into configuration-specific directories
3546         under WebKitOutputDir.
3547
3548         * BuildSlaveSupport/built-product-archive:
3549
3550 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
3551
3552         Reviewed by Darin Adler.
3553
3554         Debug and Release builds on Windows clobber each other
3555         https://bugs.webkit.org/show_bug.cgi?id=49185
3556
3557         Changes the structure of WebKitBuild build products directory so we
3558         completely separate each build configuration into independent directories.
3559         
3560         Although we previously had per-configuration directories for obj, this change adds
3561         per-configuration directories for bin, lib, obj, and include. Each configuration's
3562         build products are stored within a directory inside of WebKitBuild.
3563         
3564         Most use of $(WebKitOutputDir) in the build files has been replaced by $(ConfigurationBuildDir),
3565         defined in common.vsprops to be $(WebKitOutputDir)\$(ConfigurationName).
3566
3567         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops:
3568         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd:
3569         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd:
3570         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
3571         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd:
3572         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd:
3573         * DumpRenderTree/win/ImageDiffCommon.vsprops:
3574         * DumpRenderTree/win/ImageDiffPostBuild.cmd:
3575         * DumpRenderTree/win/ImageDiffPreBuild.cmd:
3576         * FindSafari/FindSafari.vcproj:
3577         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
3578         * MiniBrowser/MiniBrowserPostBuild.cmd:
3579         * MiniBrowser/MiniBrowserPreBuild.cmd:
3580         * Scripts/webkitdirs.pm:
3581         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
3582         * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops:
3583         * TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd:
3584         * TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd:
3585         * TestWebKitAPI/win/copy-resources.cmd:
3586         * WebKitAPITest/WebKitAPITestCommon.vsprops:
3587         * WebKitAPITest/WebKitAPITestPostBuild.cmd:
3588         * WebKitAPITest/WebKitAPITestPreBuild.cmd:
3589         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
3590         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
3591         * WebKitTestRunner/win/InjectedBundle.vcproj:
3592         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops:
3593         * WebKitTestRunner/win/InjectedBundlePostBuild.cmd:
3594         * WebKitTestRunner/win/InjectedBundlePreBuild.cmd:
3595         * WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd:
3596         * WebKitTestRunner/win/WebKitTestRunnerPreBuild.cmd:
3597         * WinLauncher/WinLauncherCommon.vsprops:
3598         * WinLauncher/WinLauncherPostBuild.cmd:
3599         * WinLauncher/WinLauncherPreBuild.cmd:
3600
3601 2011-01-05  Jan Erik Hanssen  <jhanssen@sencha.com>
3602
3603         Reviewed by Ariya Hidayat.
3604
3605         [Qt] TestNetscapePlugin doesn't link on OS X
3606         https://bugs.webkit.org/show_bug.cgi?id=51948
3607
3608         Only add a dependency on libX11 on X11 systems
3609
3610         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3611
3612 2011-01-05  Jeff Miller  <jeffm@apple.com>
3613
3614         Reviewed by Adam Roben.
3615
3616         check-webkit-style should allow unnecessary parameter names in WebKit2 APIs because we're matching CF's header style
3617         https://bugs.webkit.org/show_bug.cgi?id=51970
3618
3619         * Scripts/webkitpy/style/checker.py:
3620         Add -readability/naming for WebKit2 C API directories.
3621
3622 2011-01-05  Eric Seidel  <eric@webkit.org>
3623
3624         Unreviewed, just fixing one more log error from my previous python patch.
3625
3626         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
3627         https://bugs.webkit.org/show_bug.cgi?id=51802
3628
3629         webkit-patch failure-reason was logging about parsing errors
3630         due to my misunderstanding of how BeautifulSoup.findAll worked.
3631
3632         Fixed, and added a unit test.
3633
3634         * Scripts/webkitpy/common/net/layouttestresults.py:
3635         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3636
3637 2011-01-05  Benjamin Poulain  <benjamin.poulain@nokia.com>
3638
3639         Reviewed by Kenneth Rohde Christiansen.
3640
3641         [Qt] [WK2] Add the possibility to open window from the WebProcess in Minibrowser
3642         https://bugs.webkit.org/show_bug.cgi?id=51951
3643
3644         Set a function to QWKPage::setCreateNewPageFunction() in Minibrowser so there is a way
3645         to create new window from WebKit.
3646
3647         * MiniBrowser/qt/BrowserWindow.cpp:
3648         (newPageFunction):
3649         (BrowserWindow::BrowserWindow):
3650         (BrowserWindow::page): Added to avoid the indirect access to QWKPage spread in the class
3651         (BrowserWindow::newWindow):
3652         (BrowserWindow::updateUserAgentList):
3653         (BrowserWindow::showUserAgentDialog):
3654         * MiniBrowser/qt/BrowserWindow.h: Add the global variable backingStoreTypeForNewWindow to
3655         define the type of the backing store used for new windows.
3656         * MiniBrowser/qt/main.cpp:
3657         (main):
3658
3659 2011-01-05  Eric Seidel  <eric@webkit.org>
3660
3661         Reviewed by Ojan Vafai.
3662
3663         commit-queue should report failure type when reporting flaky tests
3664         https://bugs.webkit.org/show_bug.cgi?id=51900
3665
3666         This patch was a ridiculous amount of plumbing.  In the end I like
3667         the NRWT-style TestResult class even less.  But now we're passing
3668         a list of TestResult objects from the queue to the FlakyTestReporter.
3669         Thus the FlakyTestReporter can more easily report what type of failure
3670         occurred.
3671
3672         In the process, I found that I was not alone in finding TestResult
3673         cumbersome to use.  A bunch of code was trying to create a TestResult
3674         object with default values.  However since the constructor didn't make
3675         this easy, some places were getting it wrong (including the TestResult unit test)!
3676         I've fixed the TestResult constructor to have default values for non-essential
3677         arguments.
3678
3679         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3680         * Scripts/webkitpy/common/net/layouttestresults.py:
3681         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3682         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3683         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3684         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
3685         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
3686         * Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py:
3687         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
3688         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3689         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3690         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3691         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3692         * Scripts/webkitpy/tool/commands/queues.py:
3693         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3694
3695 2011-01-05  Eric Seidel  <eric@webkit.org>
3696
3697         Unreviewed.
3698
3699         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
3700         https://bugs.webkit.org/show_bug.cgi?id=51802
3701
3702         Add another unit test to cover a previously missing import.
3703
3704         * Scripts/webkitpy/common/net/layouttestresults.py:
3705         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3706
3707 2011-01-05  Mihai Parparita  <mihaip@chromium.org>
3708
3709         Reviewed by David Levin.
3710
3711         Add mihaip@chromium.org as a reviewer
3712         https://bugs.webkit.org/show_bug.cgi?id=51966
3713         
3714         Add myself as a reviewer.
3715
3716         * Scripts/webkitpy/common/config/committers.py:
3717
3718 2011-01-05  James Simonsen  <simonjam@chromium.org>
3719
3720         Unreviewed. Adding myself to the list of committers.
3721
3722         * Scripts/webkitpy/common/config/committers.py:
3723
3724 2011-01-05  Eric Seidel  <eric@webkit.org>
3725
3726         Unreviewed.
3727
3728         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
3729         https://bugs.webkit.org/show_bug.cgi?id=51802
3730
3731         Fix two exceptions seen on the bots after my original commit.
3732
3733         * Scripts/webkitpy/common/net/layouttestresults.py:
3734         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3735
3736 2011-01-05  Kundu Suchismita  <suchi.kundu@nokia.com>
3737
3738         Reviewed by Andreas Kling.
3739
3740         [Qt]Add local storage settings to QtTestBrowser command line arguments 
3741         https://bugs.webkit.org/show_bug.cgi?id=51750
3742
3743         * QtTestBrowser/main.cpp:
3744         (LauncherApplication::handleUserOptions):
3745          Local storage settings can be enable form command line arguments for
3746          QtTestBrowser.
3747
3748 2011-01-05  Chris Fleizach  <cfleizach@apple.com>
3749
3750         Reviewed by Martin Robinson.
3751
3752         GTK: AX: DRT needs to use correct root object method.
3753         https://bugs.webkit.org/show_bug.cgi?id=51911
3754
3755         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
3756         (AccessibilityController::rootElement):
3757
3758 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
3759
3760         Rubber-stamped by Csaba Osztrogonác.
3761
3762         Based on idea from Péter Gál.
3763
3764         * Scripts/webkitpy/tool/bot/sheriff.py: Remove unnecessary apostrophes around revision numbers.
3765
3766 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
3767
3768         Reviewed by Adam Barth.
3769
3770         sheriff-bot should be able to do multi-revision rollouts
3771         https://bugs.webkit.org/show_bug.cgi?id=51176
3772
3773         * Scripts/webkitpy/tool/bot/irc_command.py:
3774         * Scripts/webkitpy/tool/bot/sheriff.py:
3775         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
3776
3777 2011-01-05  Eric Seidel  <eric@webkit.org>
3778
3779         Reviewed by Adam Barth.
3780
3781         queues.webkit.org should have per-bot status pages
3782         https://bugs.webkit.org/show_bug.cgi?id=51906
3783
3784         Just adds a /queue-status/QUEUE_NAME/bots/BOT_ID page to show
3785         statuses from a single queue.  Now that we have many bots servicing
3786         some queues (commit-queue, win-ews, etc.) its easy to have the messages
3787         you care about scroll off the end of the 15-message limit on the main page.
3788
3789         Eventually we should probably rename /queue-status to /queue or /queues,
3790         but that's fodder for another patch.
3791
3792         * QueueStatusServer/handlers/queuestatus.py:
3793         * QueueStatusServer/index.yaml:
3794         * QueueStatusServer/main.py:
3795         * QueueStatusServer/templates/includes/singlequeuestatus.html:
3796          - This probably should use a custom filter instead of hard-coding
3797            the URL scheme here, but I couldn't figure out how to easily
3798            create such a filter.  Most filters work with "strings" so we can't
3799            pass the status object.  We could add a method to the status
3800            object and call that, but that seemed a bit strange too.
3801         * QueueStatusServer/templates/queuestatus.html:
3802
3803 2011-01-05  Carlos Garcia Campos  <cgarcia@igalia.com>
3804
3805         Unreviewed. Adding myself to the list of committers.
3806
3807         * Scripts/webkitpy/common/config/committers.py:
3808
3809 2011-01-04  Koan-Sin Tan  <koansin.tan@gmail.com>
3810
3811         Reviewed by David Levin.
3812
3813         check-webkit-style treated some macros with parentheses after #elif as function calls
3814         https://bugs.webkit.org/show_bug.cgi?id=51695
3815
3816         Ingore function call space checking in any preprocessor directives
3817         (things starting with #). Change search() to match() because 
3818         preprocessor directives are supposed to be in the beginning of lines.
3819
3820         * Scripts/webkitpy/style/checkers/cpp.py:
3821         * Scripts/webkitpy/style/checkers/cpp_unittest.py: make sure there is no false positives for #elif cases
3822
3823 2011-01-04  Søren Gjesse  <sgjesse@chromium.org>
3824
3825         Reviewed by Tony Chang.
3826
3827         Change the --multi-load test option to --stress-opt
3828         https://bugs.webkit.org/show_bug.cgi?id=50751
3829
3830         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3831         (runTest):
3832         (main):
3833         * DumpRenderTree/chromium/TestShell.cpp:
3834         (TestShell::TestShell):
3835         * DumpRenderTree/chromium/TestShell.h:
3836         (TestShell::stressOpt):
3837         (TestShell::setStressOpt):
3838         (TestShell::stressDeopt):
3839         (TestShell::setStressDeopt):
3840         (TestShell::javaScriptFlags):
3841         (TestShell::setJavaScriptFlags):
3842         * Scripts/webkitpy/layout_tests/port/chromium.py:
3843         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3844
3845 2011-01-04  Chris Fleizach  <cfleizach@apple.com>
3846
3847         Reviewed by Sam Weinig.
3848
3849         WK2: Support Accessibility
3850         https://bugs.webkit.org/show_bug.cgi?id=51859
3851
3852         Use rootObject() method to get top of accessibility tree.
3853
3854         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
3855         (AccessibilityController::focusedElement):
3856         (AccessibilityController::rootElement):
3857
3858 2011-01-03  Martin Robinson  <mrobinson@igalia.com>
3859
3860         Reviewed by Darin Adler.
3861
3862         Remove the last non-GObject usage of PlatformRefPtr and move the code to GRefPtr
3863         https://bugs.webkit.org/show_bug.cgi?id=51846
3864
3865         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: Change usage of PlatformRefPtr
3866         back to GRefPtr.
3867
3868 2011-01-04  Zhe Su  <suzhe@chromium.org>
3869
3870         Reviewed by Kenneth Russell.
3871
3872         Fix insertText, setMarkedText and unmarkText methods of
3873         TextInputController to call corresponding methods of WebKit::WebView
3874         rather than WebKit::WebFrame. This change matches the behavior of
3875         chromium browser.
3876         insertText corresponds to WebView::confirmComposition(text)
3877         setMarkedText corresponds to WebView::setComposition(...)
3878         unmarkText corresponds to WebView::confirmComposition()
3879         https://bugs.webkit.org/show_bug.cgi?id=51693
3880
3881         * DumpRenderTree/chromium/TextInputController.cpp:
3882         (TextInputController::insertText):
3883         (TextInputController::setMarkedText):
3884         (TextInputController::unmarkText):
3885
3886 2011-01-04  Dihan Wickremasuriya  <dihan.wickremasuriya@nokia.com>
3887
3888         Reviewed by Laszlo Gombos.
3889
3890         [Qt] [Symbian] Do not remove 0 byte sized files from productDir
3891
3892         On Symbian productDir points to the source directory. Removing all the
3893         empty files from the productDir directory corrupts the svn repository.
3894
3895         * Scripts/build-webkit:
3896
3897 2011-01-03  Yi Shen  <yi.4.shen@nokia.com>
3898
3899         Reviewed by Adam Barth.
3900
3901         [Qt] Add SelectAll option to the context menu for the editor
3902         https://bugs.webkit.org/show_bug.cgi?id=50049
3903
3904         Set shortcut for the SelectAll action.
3905
3906         * QtTestBrowser/mainwindow.cpp:
3907         (MainWindow::buildUI):
3908
3909 2011-01-03  David Levin  <levin@chromium.org>
3910
3911         Reviewed by Eric Seidel.
3912
3913         check-webkit-style shouldn't consider "value" automatically to be a meaningless name.
3914         https://bugs.webkit.org/show_bug.cgi?id=51842
3915
3916         * Scripts/webkitpy/style/checkers/cpp.py: Remove the check for value.
3917         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Remove the test for value.
3918
3919 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
3920
3921         Reviewed by David Kilzer.
3922
3923         [WINCE] Adds a build slave.
3924         https://bugs.webkit.org/show_bug.cgi?id=50523
3925
3926         * BuildSlaveSupport/build.webkit.org-config/config.json: Add an
3927         entry for a release build of the WinCE port.
3928         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add platform
3929         flag to build the WinCE port.
3930
3931 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
3932
3933         Reviewed by David Kilzer.
3934
3935         Add WinCE support to build-webkit
3936         https://bugs.webkit.org/show_bug.cgi?id=51642
3937
3938         * Scripts/build-webkit:
3939         * Scripts/webkitdirs.pm:
3940
3941 2011-01-03  Eric Seidel  <eric@webkit.org>
3942
3943         Reviewed by Adam Barth.
3944
3945         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
3946         https://bugs.webkit.org/show_bug.cgi?id=51802
3947
3948         I'm not the biggest fan of the test_failures or test_results classes,
3949         but it's better to have one shared set of classes, than separate ones
3950         for new vs. old run-webkit-test result handling.
3951
3952         This moves the ORWT results class "LayoutTestResults" over to using
3953         TestResult and TestFailure classes, making it easy for us to
3954         make all our sheriff-bot and other webkitpy code NRWT ready.
3955
3956         This also makes it a trivial patch to generate results.json information
3957         from ORWT results.html files (for flaky test analysis, etc.) as well
3958         as making it a one-liner to report test failure types when the
3959         commit-queue sees flaky tests.
3960
3961         This patch tried not to add new functionality, but only to replace
3962         the guts of LayoutTestResults, while adding unit tests and hoping
3963         not to break anything.
3964
3965         I also moved callers which assumed User.prompt* were static/class methods
3966         to using them as instance methods (since we'll eventually want to make them such).
3967
3968         In the process of re-writing things, I broke the rebaseline command, so I wrote
3969         a unit test to catch my breakage were I do do so again in the future.
3970
3971         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3972         * Scripts/webkitpy/common/net/layouttestresults.py:
3973         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3974         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
3975         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
3976         * Scripts/webkitpy/tool/commands/queries.py:
3977         * Scripts/webkitpy/tool/commands/rebaseline.py:
3978         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3979         * Scripts/webkitpy/tool/mocktool.py:
3980
3981 2011-01-03  Adam Barth  <abarth@webkit.org>
3982
3983         Reviewed by Simon Fraser.
3984
3985         webkit-patch shouldn't waste time cleaning a working directory that's already clean
3986         https://bugs.webkit.org/show_bug.cgi?id=51840
3987
3988         * Scripts/webkitpy/common/checkout/scm.py:
3989
3990 2011-01-03  Adam Barth  <abarth@webkit.org>
3991
3992         Reviewed by Simon Fraser.
3993
3994         webkit-patch should only hide update output if --quiet
3995         https://bugs.webkit.org/show_bug.cgi?id=51838
3996
3997         As requested by smfr.
3998
3999         * Scripts/webkitpy/tool/steps/update.py:
4000
4001 2011-01-03  Adam Barth  <abarth@webkit.org>
4002
4003         Reviewed by David Levin.
4004
4005         commit-queue shouldn't reject patches twice if two bots process the same patch
4006         https://bugs.webkit.org/show_bug.cgi?id=51805
4007
4008         Before raising an error, we first check whether the patch is still in
4009         the commit-queue.  This check is still racy, of course, but the time
4010         window is much smaller.
4011
4012         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
4013
4014 2011-01-03  Sam Weinig  <sam@webkit.org>
4015
4016         Reviewed by Anders Carlsson.
4017
4018         Make run-api-tests less chatty.
4019         https://bugs.webkit.org/show_bug.cgi?id=51831
4020
4021         - Make script quiet by default and add --verbose option (replacing --quiet).
4022         - When not verbose, pipe stdout and stderr to devnull.
4023
4024         * Scripts/run-api-tests:
4025
4026 2011-01-03  Pratik Solanki  <psolanki@apple.com>
4027
4028         Unreviewed. Adding myself to committers.py.
4029
4030         * Scripts/webkitpy/common/config/committers.py:
4031
4032 2011-01-03  Koan-Sin Tan  <koansin.tan@gmail.com>
4033
4034         Reviewed by Xan Lopez.
4035
4036         "Tool/Scripts/run-launcher --gtk" stopped working after 74855
4037         https://bugs.webkit.org/show_bug.cgi?id=51806
4038
4039         Originally, the $libraryName is 'JavaScriptCore'. When building release 
4040         one, the $libraryDir was 'WebKitBuild/Release/JavaScriptCore/../.libs/'
4041         which doesn't exist anymore ('WebKitBuild/Release/JavaScriptCore'
4042         is 'WebKitBuild/Release/Source/JavaScriptCore' now), and 
4043         'WebKitBuild/Release/Source/JavaScriptCore/../../.libs' looks weird,
4044         so make it 'WebKitBuild/Release/.libs'
4045
4046         * Scripts/webkitdirs.pm: 
4047
4048 2011-01-02  Patrick Gansterer  <paroga@webkit.org>
4049
4050         Reviewed by Adam Barth.
4051
4052         Make EFL a core builder
4053         https://bugs.webkit.org/show_bug.cgi?id=51804
4054
4055         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
4056         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
4057
4058 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
4059
4060         [Qt] Unreviewed fix after r74855 and r74875.
4061
4062         * BuildSlaveSupport/built-product-archive:
4063          - Create directories explicitly.
4064          - Pass shell=True to subprocess.call().
4065
4066 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
4067
4068         [Qt] Unreviewed fix after r74855.
4069
4070         Move JavaScriptCore to Source
4071         https://bugs.webkit.org/show_bug.cgi?id=51604
4072
4073         * BuildSlaveSupport/built-product-archive: JavaScriptCore -> Source/JavaScriptCore
4074
4075 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
4076
4077         [Qt] Unreviewed run-javasriptcore-tests fix after r74855.
4078
4079         Move JavaScriptCore to Source
4080         https://bugs.webkit.org/show_bug.cgi?id=51604
4081
4082         * Scripts/webkitdirs.pm:
4083
4084 2011-01-02  Robert Hogan  <robert@webkit.org>
4085
4086         Unreviewed, build fix.
4087
4088         [Qt] Fix DRT build after 74855
4089
4090         * DumpRenderTree/qt/DumpRenderTree.pro:
4091
4092 2011-01-01  Adam Barth  <abarth@webkit.org>
4093
4094         Remove the assumption from the Qt and Gtk builds that every project is
4095         in the root directory.
4096
4097         * Scripts/build-webkit:
4098
4099 2011-01-01  Adam Barth  <abarth@webkit.org>
4100
4101         Reviewed by Eric Seidel.
4102
4103         Teach svn-apply how to apply patches even though JavaScriptCore has moved
4104         https://bugs.webkit.org/show_bug.cgi?id=51796
4105
4106         After this change, svn-apply will magically apply patches to
4107         JavaScriptCore/foo to Source/JavaScriptCore/foo.
4108
4109         * Scripts/VCSUtils.pm:
4110
4111 2011-01-01  Adam Barth  <abarth@webkit.org>
4112
4113         Reviewed by Eric Seidel.
4114
4115         Move JavaScriptCore to Source
4116         https://bugs.webkit.org/show_bug.cgi?id=51604
4117
4118         Update references to JavaScriptCore to point to the new location.
4119
4120         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
4121         * DumpRenderTree/qt/DumpRenderTree.pro:
4122         * DumpRenderTree/qt/ImageDiff.pro:
4123         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
4124         * DumpRenderTree/wscript:
4125         * Scripts/build-jsc:
4126         * Scripts/build-webkit:
4127         * Scripts/do-file-rename:
4128         * Scripts/do-webcore-rename:
4129         * Scripts/run-javascriptcore-tests:
4130         * Scripts/update-javascriptcore-test-results:
4131         * Scripts/webkitdirs.pm:
4132         * Scripts/webkitpy/common/config/build_unittest.py:
4133         * Scripts/webkitpy/style/checker.py:
4134         * Scripts/webkitpy/style/checker_unittest.py:
4135         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
4136         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
4137         * WebKitTestRunner/qt/WebKitTestRunner.pro:
4138         * wx/build/settings.py:
4139
4140 2011-01-01  Adam Barth  <abarth@webkit.org>
4141
4142         Reviewed by Eric Seidel.
4143
4144         Move Sources to Source
4145         https://bugs.webkit.org/show_bug.cgi?id=51794
4146
4147         Update scripts to point to the new location.
4148
4149         * Scripts/build-webkit:
4150         * Scripts/do-file-rename:
4151         * Scripts/do-webcore-rename:
4152         * Scripts/webkitpy/common/config/build.py:
4153         * Scripts/webkitpy/common/config/build_unittest.py:
4154
4155 2010-12-31  Kent Tamura  <tkent@chromium.org>
4156
4157         Reviewed by Eric Seidel.
4158
4159         [DRT/Chromium] Enable mock spell checker on non-OSX
4160         https://bugs.webkit.org/show_bug.cgi?id=51401
4161
4162         * DumpRenderTree/chromium/WebViewHost.cpp:
4163         (WebViewHost::spellCheck):
4164
4165 2010-12-31  Adam Barth  <abarth@webkit.org>
4166
4167         Reviewed by Ariya Hidayat.
4168
4169         Remove Tools/Scripts/wkstyle
4170         https://bugs.webkit.org/show_bug.cgi?id=51774
4171
4172         This script appears to not have been touched in a while and seems to
4173         have been replaced by check-webkit-style.
4174
4175         * Scripts/wkstyle: Removed.
4176
4177 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
4178
4179         Unreviewed. Coding style fix.
4180
4181         * DumpRenderTree/chromium/TestShell.h:
4182
4183 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
4184
4185         Reviewed by Pavel Feldman.
4186
4187         Web Inspector: [Chromium] Inspector's tests are very slow on Win(Dbg).
4188
4189         It was a problem with Chromium DRT. DevToolsAgent object instance was
4190         attached not only to the inspected page but to the DevTools window too.
4191         As result all the inspector files were interpreted as a content of inspected page
4192         and were transfered to the DevTools scripts panel for debugging etc.
4193
4194         https://bugs.webkit.org/show_bug.cgi?id=51735
4195
4196         * DumpRenderTree/chromium/TestShell.cpp:
4197         (TestShell::TestShell):
4198         (TestShell::bindJSObjectsToWindow):
4199         (TestShell::createNewWindow):
4200         * DumpRenderTree/chromium/TestShell.h:
4201
4202 2010-12-31  Adam Barth  <abarth@webkit.org>
4203
4204         Rubber-stamped by Eric Seidel.
4205
4206         Move PageLoadTests to PerformanceTests/PageLoad
4207         https://bugs.webkit.org/show_bug.cgi?id=51771
4208
4209         Update references to PageLoadTests to point to the new location.
4210
4211         * Scripts/run-pageloadtest:
4212         * Scripts/webkitpy/common/config/build.py:
4213
4214 2010-12-31  Adam Barth  <abarth@webkit.org>
4215
4216         Rubber-stamped by Eric Seidel.
4217
4218         Move SunSpider into PerformanceTests
4219         https://bugs.webkit.org/show_bug.cgi?id=51769
4220
4221         Update these scripts to point to the new location.
4222
4223         * Scripts/run-sunspider:
4224         * Scripts/sunspider-compare-results:
4225
4226 2010-12-30  Mihai Parparita  <mihaip@chromium.org>
4227
4228         Reviewed by Kent Tamura.
4229
4230         [Chromium] Add WebThemeEngineDRTMac so that Chromium DRT scrollbar rendering can match the Mac port's
4231         https://bugs.webkit.org/show_bug.cgi?id=51728
4232         
4233         Add implementation of the Mac WebThemeEngine that uses an NSScroller
4234         to render top-level scrollbars. This makes them match the Mac port's
4235         use of an NSScrollView, which means that we'll be able to share more
4236         pixel baselines.
4237         
4238         The new rendering code will not be activated until the 
4239         USE_WEB_THEME_ENGINE_TO_PAINT_THUMB #define is fliped in
4240         ScrollbarThemeChromiumMac.
4241
4242         * DumpRenderTree/DumpRenderTree.gypi:
4243         * DumpRenderTree/chromium/TestShellMac.mm:
4244         (platformInit):
4245         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Added.
4246         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Added.
4247         (+[FakeActiveWindow alwaysActiveWindow]):
4248         (+[FakeActiveWindow alwaysInactiveWindow]):
4249         (-[FakeActiveWindow initWithActiveControls:]):
4250         (-[FakeActiveWindow _hasActiveControls]):
4251         (WebThemeEngineDRTMac::paintScrollbarThumb):
4252         (stateToHIEnableState):
4253         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
4254         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
4255
4256 2010-12-30  Konstantin Tokarev  <annulen@yandex.ru>
4257
4258         Reviewed by David Kilzer.
4259
4260         [Qt] Don't build wtf/TCSystemAlloc.cpp if --system-malloc option is
4261         used
4262         https://bugs.webkit.org/show_bug.cgi?id=51672
4263
4264         * DumpRenderTree/qt/DumpRenderTree.pro: Replaced USE_SYSTEM_MALLOC
4265         with USE_SYSTEM_MALLOC=1
4266         * WebKitTestRunner/qt/WebKitTestRunner.pro: Replaced USE_SYSTEM_MALLOC
4267         with USE_SYSTEM_MALLOC=1
4268
4269 2010-12-30  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
4270
4271         Reviewed by David Kilzer.
4272
4273         [Qt] [Symbian] Fix build-webkit script for Symbian
4274         https://bugs.webkit.org/show_bug.cgi?id=51509
4275
4276         Set the OUTPUT_DIR for Symbian to be the same as the source
4277         directory.
4278
4279         * Scripts/webkitdirs.pm:
4280
4281 2010-12-30  Martin Robinson  <mrobinson@igalia.com>
4282
4283         Reviewed by Darin Adler.
4284
4285         check-webkit-style should ignore NULL usage in calls to gtk_widget_style_get
4286         https://bugs.webkit.org/show_bug.cgi?id=51758
4287
4288         Add a check-webkit-style exception for gtk_widget_style_get and NULL usage.
4289
4290         * Scripts/webkitpy/style/checkers/cpp.py: Add the exception.
4291         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Add some tests for this.
4292
4293 2010-12-29  Patrick Gansterer  <paroga@webkit.org>
4294
4295         Unreviewed WinCE buildfix.
4296
4297         * WinCELauncher/main.cpp: Add missing include.
4298
4299 2010-12-29  Daniel Bates  <dbates@rim.com>
4300
4301         Reviewed by Darin Adler.
4302
4303         svn-apply updates date of wrong change log entry for a change log diff that
4304         contains two consecutive entries with the same author and date
4305         https://bugs.webkit.org/show_bug.cgi?id=46061
4306
4307         Fixes an issue where the date of the wrong change log entry may be modified.
4308         Moreover, changes fixChangeLogPatch() to move entries inserted earlier
4309         in a ChangeLog file to the top of the file.
4310
4311         Currently, fixChangeLogPatch() explicitly bails out and returns an unchanged
4312         diff when it detects that the diff inserts a change log entry earlier in a
4313         ChangeLog. It is unusual to land a patch that has such a deliberate ChangeLog
4314         change. With the advent of the commit-queue this functionality of bailing out
4315         and hence landing the patch as-is is harmful to the accuracy of the ChangeLog.
4316         Instead, we should always move the change log entry to the top of the ChangeLog file.
4317
4318         A side-effect of this change is that setChangeLogDateAndReviewer() now updates
4319         the date line of the correct change log entry in a ChangeLog diff.
4320
4321         * Scripts/VCSUtils.pm: Modified fixChangeLogPatch() to move entries inserted earlier to the top.
4322
4323         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
4324           Updated the following unit tests now that we move entries inserted earlier to the top:
4325           - "fixChangeLogPatch: New entry inserted in middle."
4326             (formerly named "fixChangeLogPatch: [no change] New entry inserted in middle.")
4327
4328           - "fixChangeLogPatch: New entry inserted earlier in the file, but after an entry with the same author and date."
4329             (formerly named "fixChangeLogPatch: [no change] New entry inserted earlier in the file, but after an entry with the same author and date.")
4330
4331         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatchThenSetChangeLogDateAndReviewer.pl: Added.
4332
4333 2010-12-29  Konstantin Tokarev  <annulen@yandex.ru>
4334
4335         Reviewed by Eric Seidel.
4336
4337         [Qt] Fixed compatibility with gold linker on X11 platforms
4338         https://bugs.webkit.org/show_bug.cgi?id=51700
4339
4340         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
4341         Linked TestNetscapePlugin with libX11 on Unix platforms
4342
4343 2010-12-29  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>
4344
4345         Reviewed by Darin Adler.
4346
4347         Circular dependency in webkitpy.common.checkout.changelog module
4348         https://bugs.webkit.org/show_bug.cgi?id=50475
4349
4350         Remove automatic import of api.Checkout module when any checkout/
4351         submodule is imported (e.g.: when checkout.scm.Git is imported).
4352
4353         * Scripts/webkitpy/common/checkout/__init__.py:
4354
4355 2010-12-29  Martin Robinson  <mrobinson@igalia.com>
4356
4357         Reviewed by Ojan Vafai.
4358
4359         prepare-ChangeLog should support the -g option for specifying the git-commit
4360         https://bugs.webkit.org/show_bug.cgi?id=51708
4361
4362         Add a -g shortcut for the --git-commit prepare-ChangeLog option. This matches
4363         webkit-patch, though the exact meaning of the two options remain different.
4364
4365         * Scripts/prepare-ChangeLog: Add -g.
4366
4367 2010-12-29  Kent Hansen  <kent.hansen@nokia.com>
4368
4369         Reviewed by Simon Hausmann.
4370
4371         [Qt] Fix compilation with Qt in namespace
4372         https://bugs.webkit.org/show_bug.cgi?id=51701
4373
4374         * QtTestBrowser/webview.h:
4375
4376 2010-12-28  Daniel Bates  <dbates@rim.com>
4377
4378         Reviewed by Sam Weinig.
4379
4380         Substitute // MARK: for compiler-specific #pragma mark
4381         https://bugs.webkit.org/show_bug.cgi?id=51657
4382
4383         Fix future compilation warnings about "#pragma mark" on GTK+ bots by
4384         substituting  "// MARK:" for "#pragma mark", which provides
4385         analogous code-bookmarking functionality under Xcode.
4386
4387         Also, for consistency, we should substitute "// MARK:" for compiler-
4388         specific "#pragma mark" in the source files for the Mac port.
4389
4390         * DumpRenderTree/AccessibilityTextMarker.cpp:
4391         * DumpRenderTree/cf/WebArchiveDumpSupport.h:
4392         * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm:
4393         * DumpRenderTree/mac/ObjCController.m:
4394         * MiniBrowser/mac/AppDelegate.m:
4395         * MiniBrowser/mac/BrowserWindowController.m:
4396
4397 2010-12-28  Xan Lopez  <xlopez@igalia.com>
4398
4399         Reviewed by Eric Seidel.
4400
4401         Add --no-build option to run-sunspider
4402         https://bugs.webkit.org/show_bug.cgi?id=51658
4403
4404         * Scripts/run-sunspider: add --no-build flag to skip building
4405         phase.
4406
4407 2010-12-27  Daniel Bates  <dbates@rim.com>
4408
4409         Rubber-stamped by Martin Robinson.
4410
4411         Append the directory Tools/DumpRenderTree to the list of directories that
4412         do-webcore-rename should search so that it can rename DRT files and
4413         source code.
4414
4415         * Scripts/do-webcore-rename:
4416
4417 2010-12-27  Eric Seidel  <eric@webkit.org>
4418
4419         Reviewed by Adam Barth.
4420
4421         build-webkit should detect missing Java SDK and explain how to install it
4422         https://bugs.webkit.org/show_bug.cgi?id=51651
4423
4424         * Scripts/build-webkit:
4425
4426 2010-12-26  Martin Robinson  <mrobinson@igalia.com>
4427
4428         Reviewed by Daniel Bates.
4429
4430         [GTK] Add support for build-jsc
4431         https://bugs.webkit.org/show_bug.cgi?id=51625
4432
4433         Add GTK+ support to build-jsc now that building the jsc executable as
4434         a standalone target is easy.
4435
4436         * Scripts/build-jsc: Call buildGtkProject for the GTK+ case now.
4437         * Scripts/build-webkit: Pass in the proper target name to buildGtkProject.
4438         * Scripts/webkitdirs.pm: Actually process the project parameter in buildGtkProject
4439         and pass it along to buildAutotoolsProject.
4440
4441 2010-12-27  David Levin  <levin@chromium.org>
4442
4443         Reviewed by Eric Seidel.
4444
4445         check-webkit-style check for meaningless variable names in function declarations.
4446         https://bugs.webkit.org/show_bug.cgi?id=51523
4447
4448         * Scripts/webkitpy/style/checker.py: Exempted JavaScriptCore/jit/JITStubs.cpp
4449         from the new check and whitespace/parens because the syntax is unusual and
4450         produced a fair number of positives for these checks.
4451         * Scripts/webkitpy/style/checkers/cpp.py:
4452         (_convert_to_lower_with_underscores): Used as a canonical form for type names
4453         and parameter names when determining if the parameter name is useless.
4454         (_create_acronym): Used to check for redundant variable names in cases like "ExceptionCode ec"
4455         (Parameter.lower_with_underscores_name): Gives back the parameter name in a lower_with_underscore
4456         format.
4457         (_check_parameter_name_against_text):  Checks to see if the parameter name is in the
4458         text or an acronym of it.
4459         (check_function_definition): Checks function definitions for meaningless variable names.
4460         (process_line): Added call to check_function_definition.
4461         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
4462         (CppFunctionsTest.test_convert_to_lower_with_underscores): Test for _convert_to_lower_with_underscores.
4463         (CppFunctionsTest.test_create_acronym): Test for _create_acronym.
4464         (CppFunctionsTest.test_check_parameter_against_text): Test for _check_parameter_against_text.
4465         (CppStyleTestBase.perform_single_line_lint): Removed the parameter name check
4466         because when only checking a snippet, there are a lot of bogus functions.
4467         (CppStyleTestBase.perform_multi_line_lint): Ditto and removed a bogus filter
4468         that I put there previously and just noticed.
4469         (WebKitStyleTest.test_parameter_names): Tests for the functionality -- both
4470         check_function_definition and process_line.
4471
4472 2010-12-27  Carlos Garcia Campos  <cgarcia@igalia.com>
4473
4474         Reviewed by Martin Robinson.
4475
4476         [GTK] Disable flash plugin in GtkLauncher when using gtk3
4477         https://bugs.webkit.org/show_bug.cgi?id=51591
4478
4479         Flash plugin uses gtk2 that is incompatible with gtk3 making
4480         webkit crash when it's built with gtk3.
4481
4482         * GtkLauncher/main.c:
4483         (main):
4484
4485 2010-12-25  Adam Barth  <abarth@webkit.org>
4486
4487         Reviewed by Eric Seidel.
4488
4489         Move ANGLE to Sources/ThirdParty
4490         https://bugs.webkit.org/show_bug.cgi?id=51605
4491
4492         * Scripts/build-webkit:
4493           - Point to the new ANGLE location.
4494
4495 2010-12-26  David Levin  <levin@chromium.org>
4496
4497         Reviewed by Eric Seidel.
4498
4499         check-webkit-style should be able to parse function declaration parameters.
4500         https://bugs.webkit.org/show_bug.cgi?id=51451
4501
4502         * Scripts/webkitpy/style/checkers/cpp.py:
4503         (Position.__init__): Holds simple position information (row, column).
4504         (Parameter.__init__): Holds information about a parameter.
4505         (SingleLineView.__init): Converts multiple lines into a single line for simpler searches.
4506         (SingleLineView.convert_column_to_row): Returns the original row given a column.