[WebRTC] getStats does not support legacy callback
[WebKit.git] / Tools / ChangeLog
1 2017-01-30  Alexey Proskuryakov  <ap@apple.com>
2
3         Commit queue fails to look at real name aliases for the reviewer
4         https://bugs.webkit.org/show_bug.cgi?id=167422
5
6         Reviewed by Joseph Pecoraro.
7
8         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
9         (test_has_valid_reviewer): Added tests.
10
11         * Scripts/webkitpy/common/config/committers.py:
12         (CommitterList._name_to_contributor_map):
13         Made _name_to_contributor_map include alias names.
14
15         * Scripts/webkitpy/common/config/committers_unittest.py:
16         (CommittersTest.test_contributors_by_fuzzy_match):
17         Removed subtests that are now obsolete, as these matches are strict. It is not
18         obvious if distance based fuzzy matching for names is useful at all, but we can
19         look into that some other time.
20
21 2017-01-30  Aakash Jain  <aakash_jain@apple.com>
22
23         QueueStatusServer should have an explicit timeout for _fetch_url
24         https://bugs.webkit.org/show_bug.cgi?id=167467
25
26         Reviewed by Alexey Proskuryakov.
27
28         * Scripts/webkitpy/common/net/statusserver.py:
29         (StatusServer._fetch_url): Add an explicit timeout of 300s.
30
31 2017-01-30  Kocsen Chung  <kocsen_chung@apple.com>
32
33         Add support for Trac instances that host multiple projects.
34         https://bugs.webkit.org/show_bug.cgi?id=167524
35
36         Reviewed by Alexey Proskuryakov.
37
38         When multiple projects are hosted on a single Trac instance, the current
39         behavior will retrieve changesets from all tracked projects.
40         This patch teaches Trac.js to get project-specific changesets from Trac.
41         We do this by replacing the parameter `changeset=on` to `repo-projectname=on`
42         when querying the Trac timeline.
43
44         To tell Trac to be aware of multi-project instances we leverage the 
45         `options` parameter when creating a new instance: 
46
47             new Trac("https://mytrac.com/", { projectIdentifier: "tracProjectName" });
48
49         If this option is not provided, the original behaviour will prevail.
50         Additionally, add corresponding tests.
51
52         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
53         (Trac): Reason about new optional parameter 'projectIdentifier'.
54         (Trac.prototype.revisionURL): Given a projectIdentifier, append it to the end of the URL.
55         (Trac.prototype._xmlTimelineURL): Given a projectIdentifier,
56         replace default parameter `changeset=on` with `repo-projectname=on`.
57         (Trac.prototype._convertCommitInfoElementToObject): Fix missing ';'.
58         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockTrac.js:
59         (MockTrac): Add support for instantiating Trac with a projectIdentifier.
60         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/tests.js:
61         (setup): Provide a multiple-project MockTrac instance to all test cases for testing.
62         Add the following tests:
63             test("revisionURL")
64             test("revisionURL with Trac Identifier")
65             test("_xmlTimelineURL")
66             test("_xmlTimelineURL with Trac Identifier")
67         (this.view._latestProductiveIteration): Fix missing ';'.
68
69 2017-01-30  Myles C. Maxfield  <mmaxfield@apple.com>
70
71         Correct spacing regression on inter-element complex path shaping on some fonts
72         https://bugs.webkit.org/show_bug.cgi?id=166013
73
74         Reviewed by Simon Fraser.
75
76         Unskip existing tests and make some new tests:
77         - Testing complex text with no origins
78         - Testing initial expansions
79         - Testing the sign of vertical advances
80
81         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
82         (TestWebKitAPI::TEST_F):
83
84 2017-01-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
85
86         [GTK][EFL] Avoid using a thin directory to create the built product on the archive-built-product step.
87         https://bugs.webkit.org/show_bug.cgi?id=167596
88
89         Reviewed by Daniel Bates.
90
91         We avoid needing a thin directory by invoking the zip program with
92         the list of directories from the build directory to be zipped,
93         and by using the zip feature to exclude files matching a pattern.
94
95         * BuildSlaveSupport/built-product-archive:
96         (copyBuildFiles):
97         (createZipFromList):
98         (archiveBuiltProduct):
99
100 2017-01-30  Jonathan Bedard  <jbedard@apple.com>
101
102         Use simctl instead of LayoutTestRelay
103         https://bugs.webkit.org/show_bug.cgi?id=165927
104
105         Reviewed by Daniel Bates.
106
107         Part 1
108
109         LayoutTestRelay uses SPI, since recent versions of the iOS SDK allow for installing apps on
110         simulators through simctl (iOS 10 and later), use this functionality instead.
111
112         * Scripts/webkitpy/port/base.py:
113         (Port.__init__): Added _test_runner_process_constructor.
114         * Scripts/webkitpy/port/darwin.py:
115         (DarwinPort.app_identifier_from_bundle): Added function to extract bundle ID from plist.
116         * Scripts/webkitpy/port/driver.py:
117         (Driver._start): Pass worker_number to server_process so we can look up the correct simulator device to use.
118         (IOSSimulatorDriver): Deleted.
119         * Scripts/webkitpy/port/driver_unittest.py:
120         (DriverTest.test_stop_cleans_up_properly): Set _test_runner_process_constructor for testing.
121         (DriverTest.test_two_starts_cleans_up_properly): Ditto.
122         (DriverTest.test_start_actually_starts): Ditto.
123         * Scripts/webkitpy/port/ios.py:
124         (IOSSimulatorPort): Remove relay_name.
125         (IOSSimulatorPort.__init__): Set _test_runner_process_constructor to SimulatorProcess for IOSSimulatorPort.
126         (IOSSimulatorPort._create_simulators): Formatting change.
127         (IOSSimulatorPort.relay_path): Deleted.
128         (IOSSimulatorPort._check_relay): Deleted.
129         (IOSSimulatorPort._check_port_build): Deleted. Use base class implementation
130         (IOSSimulatorPort._build_relay): Deleted.
131         (IOSSimulatorPort._build_driver): Deleted. Use base class implementation
132         (IOSSimulatorPort._driver_class): Deleted. Use base class implementation
133         * Scripts/webkitpy/port/ios_unittest.py:
134         (iosTest.test_32bit): Update test.
135         (iosTest.test_64bit): Update test.
136         * Scripts/webkitpy/port/server_process.py:
137         (ServerProcess.__init__): Added argument worker_number. This class does not make use of it. We will make use of this argument in SimulatorProcess to lookup the associated simulator device.
138         (ServerProcess._set_file_nonblocking): Added to share common code.
139         * Scripts/webkitpy/port/server_process_mock.py:
140         (MockServerProcess.__init__): Added argument worker_number.
141         * Scripts/webkitpy/port/simulator_process.py: Added.
142         (SimulatorProcess): Added.
143         (SimulatorProcess.Popen): Added.
144         (SimulatorProcess.Popen.__init__): Added. Initialize Popen structure with stdin, stdout, stderr and pid.
145         (SimulatorProcess.Popen.poll): Added. Check if the process is running.
146         (SimulatorProcess.Popen.wait): Added. Wait for process to close.
147         (SimulatorProcess.__init__): Added. Install app to device specified through port and worker_number.
148         (SimulatorProcess._reset): Added. Unlink fifos.
149         (SimulatorProcess._start): Added. Launch app on simulator, link fifos.
150         (SimulatorProcess._kill): Added. Shutdown app on simulator.
151         * Scripts/webkitpy/xcode/simulator.py:
152         (Device.__init__): Accept host to run install/launch/terminate.
153         (Device.install_app): Install app to target Device.
154         (Device.launch_app): Launch app on target Device.
155         (Device.terminate_app): Shutdown app on target Device.
156         (Simulator._parse_devices): Pass host to Device.
157
158 2017-01-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
159
160         [GTK] pixman fails to compile on Raspberry Pi (GCC crash)
161         https://bugs.webkit.org/show_bug.cgi?id=167411
162
163         Reviewed by Michael Catanzaro.
164
165         Disable the ARM iwMMXt fast path for pixman, because it triggers
166         a GCC bug on the RPi with Raspbian/PIXEL causing a build failure.
167
168         * gtk/jhbuild.modules:
169
170 2017-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
171
172         [GTK] Add API to handle the accelerated compositing policy
173         https://bugs.webkit.org/show_bug.cgi?id=167509
174
175         Reviewed by Michael Catanzaro.
176
177         Handle new setting in MiniBrowser. The settings dialog doesn't support enum settings so it needs to be handled
178         as a special case. Also add test cases to the get/set API.
179
180         * MiniBrowser/gtk/BrowserSettingsDialog.c:
181         (hardwareAccelerationPolicyToString):
182         (stringToHardwareAccelerationPolicy):
183         (cellRendererChanged):
184         (browserSettingsDialogConstructed):
185         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
186         (testWebKitSettings):
187
188 2017-01-29  Andy Estes  <aestes@apple.com>
189
190         [QuickLook] Add a WebPreference to enable saving QuickLook documents in WebKitLegacy
191         https://bugs.webkit.org/show_bug.cgi?id=167563
192         <rdar://problem/30253207>
193
194         Reviewed by Andreas Kling.
195
196         * TestWebKitAPI/Tests/WebKit2Cocoa/QuickLook.mm:
197         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
198         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
199         (runTest):
200         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
201         (TEST):
202
203 2017-01-29  Dan Bernstein  <mitz@apple.com>
204
205         [iOS] Expose WebCore::DataDetection::detectContentInRange WKWebProcessPlugInRangeHandle
206         https://bugs.webkit.org/show_bug.cgi?id=167565
207
208         Reviewed by Sam Weinig.
209
210         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
211         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandle.mm: Added.
212         (-[BundleRangeHandleRemoteObject textFromBodyRange:]):
213         (-[BundleRangeHandleRemoteObject bodyInnerHTMLAfterDetectingData:]):
214         (TEST):
215         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandlePlugIn.mm: Added.
216         (-[BundleRangeHandlePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
217         (-[BundleRangeHandlePlugIn webProcessPlugInBrowserContextController:didFinishDocumentLoadForFrame:]):
218         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandleProtocol.h: Added.
219
220 2017-01-28  Yoav Weiss  <yoav@yoav.ws>
221
222         Add Link Preload as an off-by-default experimental feature menu item.
223         https://bugs.webkit.org/show_bug.cgi?id=167201
224
225         Reviewed by Ryosuke Niwa.
226
227         * DumpRenderTree/mac/DumpRenderTree.mm:
228         (resetWebPreferencesToConsistentValues):
229         * DumpRenderTree/win/DumpRenderTree.cpp:
230         (resetWebPreferencesToConsistentValues):
231
232 2017-01-28  Joseph Pecoraro  <pecoraro@apple.com>
233
234         Add User Timing Experimental Feature
235         https://bugs.webkit.org/show_bug.cgi?id=167542
236         <rdar://problem/22746307>
237
238         Reviewed by Ryosuke Niwa.
239
240         * DumpRenderTree/mac/DumpRenderTree.mm:
241         (enableExperimentalFeatures):
242         (resetWebPreferencesToConsistentValues):
243         * DumpRenderTree/win/DumpRenderTree.cpp:
244         (enableExperimentalFeatures):
245
246 2017-01-28  Joseph Pecoraro  <pecoraro@apple.com>
247
248         Patch Review: EWS Bubbles wrap to multiple lines but can fit on one line
249         https://bugs.webkit.org/show_bug.cgi?id=167519
250
251         Reviewed by Ryosuke Niwa.
252
253         * QueueStatusServer/templates/statusbubble.html:
254         To measure the bubbleContainer's width, it must not be wrapping based
255         on its parent container. So when measuring the width temporarily set
256         the parent to a very large width so as to not artificially wrap us.
257         Restore the parent's width after measuring.
258
259 2017-01-27  Andy Estes  <aestes@apple.com>
260
261         [iOS] Add a test for _WKNSFileManagerExtras
262         https://bugs.webkit.org/show_bug.cgi?id=167478
263
264         Reviewed by Andreas Kling.
265
266         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
267         * TestWebKitAPI/Tests/WebKit2Cocoa/NSFileManagerExtras.mm: Added.
268         (expectAttributes):
269         (TEST):
270
271 2017-01-27  Keith Miller  <keith_miller@apple.com>
272
273         run-benchmarks should make sure it passes the test url to the right application
274         https://bugs.webkit.org/show_bug.cgi?id=167533
275
276         Reviewed by Joseph Pecoraro.
277
278         This fixes an issue when trying to run-benchmark script with the
279         system default browser set to STP. Previously, it would run
280         the test in STP rather than the provided build. Now, it should run
281         in the provided build.
282
283         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
284         (OSXSafariDriver.launch_url):
285
286 2017-01-27  Myles C. Maxfield  <mmaxfield@apple.com>
287
288         [Cocoa] Prepare ComplexTextController for unit testing
289         https://bugs.webkit.org/show_bug.cgi?id=167493
290
291         Reviewed by Simon Fraser.
292
293         Addressing post-review comments from Simon Fraser.
294
295         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
296         (TestWebKitAPI::TEST_F):
297
298 2017-01-27  Myles C. Maxfield  <mmaxfield@apple.com>
299
300         [Cocoa] Prepare ComplexTextController for unit testing
301         https://bugs.webkit.org/show_bug.cgi?id=167493
302
303         Reviewed by Dean Jackson.
304
305         Create four unit tests.
306
307         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
308         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp: Added.
309         (TestWebKitAPI::ComplexTextControllerTest::SetUp):
310         (TestWebKitAPI::TEST_F):
311
312 2017-01-26  Chris Dumez  <cdumez@apple.com>
313
314         Crash when navigating back to a page in PacheCache when one of its frames has been removed
315         https://bugs.webkit.org/show_bug.cgi?id=167421
316         <rdar://problem/30188490>
317
318         Reviewed by Darin Adler.
319
320         Add a new setting allowing layout tests to enable PageCache in a window
321         that has an opener, for convenience.
322
323         * DumpRenderTree/mac/DumpRenderTree.mm:
324         (resetWebPreferencesToConsistentValues):
325         * DumpRenderTree/win/DumpRenderTree.cpp:
326         (resetWebPreferencesToConsistentValues):
327         * WebKitTestRunner/TestController.cpp:
328         (WTR::TestController::resetPreferencesToConsistentValues):
329
330 2017-01-26  Keith Miller  <keith_miller@apple.com>
331
332         classInfo should take a VM so it is not materialized from the object on each call
333         https://bugs.webkit.org/show_bug.cgi?id=167424
334
335         Rubber Stamped by Michael Saboff.
336
337         Previously, classInfo() would get the VM from the target's
338         MarkedBlock.  Most callers already have a VM on hand, so it is
339         wasteful to compute the VM from the marked block every time. This
340         patch refactors some of the most common callers of classInfo(),
341         jsDynamicCast and inherits to take a VM as well.
342
343         * DumpRenderTree/TestRunner.cpp:
344         (setAudioResultCallback):
345
346 2017-01-26  Jer Noble  <jer.noble@apple.com>
347
348         Autoplay muted videos stop playback of any streaming app in the background
349         https://bugs.webkit.org/show_bug.cgi?id=163993
350         <rdar://problem/29020431>
351
352         Reviewed by Eric Carlson.
353
354         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
355         * TestWebKitAPI/Tests/WebKit/ios/AudioSessionCategoryIOS.mm:
356         (TestWebKitAPI::TEST):
357         * TestWebKitAPI/Tests/WebKit/ios/video-with-muted-audio-and-webaudio.html: Added.
358
359 2017-01-26  Ryan Haddad  <ryanhaddad@apple.com>
360
361         Disable API test WebKit2.WebsitePoliciesPlayAfterPreventedAutoplay.
362         https://bugs.webkit.org/show_bug.cgi?id=167466
363
364         Unreviewed test gardening.
365
366         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
367         (TEST):
368
369 2017-01-26  Matt Rajca  <mrajca@apple.com>
370
371         Notify clients when the user plays media otherwise prevented from autoplaying
372         https://bugs.webkit.org/show_bug.cgi?id=167390
373
374         Reviewed by Alex Christensen.
375
376         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
377         * TestWebKitAPI/Tests/WebKit2/autoplay-with-controls.html: Added.
378         * TestWebKitAPI/Tests/WebKit2/js-play-with-controls.html: Added.
379         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
380         (didPlayMediaPreventedFromPlayingWithoutUserGesture):
381         (TEST):
382         * TestWebKitAPI/cocoa/TestWKWebView.h:
383         * TestWebKitAPI/cocoa/TestWKWebView.mm:
384         (-[TestWKWebViewHostWindow _mouseUpAtPoint:]):
385         (-[TestWKWebView waitForLoad]):
386         (-[TestWKWebView mouseUpAtPoint:]):
387         * WebKitTestRunner/TestController.cpp:
388         (WTR::TestController::createOtherPage):
389         (WTR::TestController::createWebViewWithOptions):
390
391 2017-01-26  Per Arne Vollan  <pvollan@apple.com>
392
393         Crash when setting custom scale factor.
394         https://bugs.webkit.org/show_bug.cgi?id=167369
395
396         Reviewed by Sam Weinig.
397
398         Added API test.
399
400         * TestWebKitAPI/PlatformWin.cmake:
401         * TestWebKitAPI/Tests/WebKit/win/ScaleWebView.cpp: Added.
402         (TestWebKitAPI::WebKitCreateInstance):
403         (TestWebKitAPI::ScaleWebView::SetUp):
404         (TestWebKitAPI::ScaleWebView::TearDown):
405         (TestWebKitAPI::TEST_F):
406
407 2017-01-25  Ryosuke Niwa  <rniwa@webkit.org>
408
409         run-benchmark nests MotionMark results by the suite name twice
410         https://bugs.webkit.org/show_bug.cgi?id=164948
411
412         Reviewed by Said Abou-Hallawa.
413
414         Use a single level MotionMark now that this is the name of the benchmark,
415         and we no longer have tests that aren't part of the MotionMark suite.
416
417         * Scripts/webkitpy/benchmark_runner/data/patches/MotionMark.patch:
418
419 2017-01-25  Ryan Haddad  <ryanhaddad@apple.com>
420
421         Unreviewed, rolling out r211193.
422
423         This change broke internal builds.
424
425         Reverted changeset:
426
427         "Notify clients when the user plays media otherwise prevented
428         from autoplaying"
429         https://bugs.webkit.org/show_bug.cgi?id=167390
430         http://trac.webkit.org/changeset/211193
431
432 2017-01-25  Matt Rajca  <mrajca@apple.com>
433
434         Notify clients when the user plays media otherwise prevented from autoplaying
435         https://bugs.webkit.org/show_bug.cgi?id=167390
436
437         Reviewed by Alex Christensen.
438
439         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
440         * TestWebKitAPI/Tests/WebKit2/autoplay-with-controls.html: Added.
441         * TestWebKitAPI/Tests/WebKit2/js-play-with-controls.html: Added.
442         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
443         (didPlayMediaPreventedFromPlayingWithoutUserGesture):
444         (TEST):
445         * TestWebKitAPI/cocoa/TestWKWebView.h:
446         * TestWebKitAPI/cocoa/TestWKWebView.mm:
447         (-[TestWKWebViewHostWindow _mouseUpAtPoint:]):
448         (-[TestWKWebView waitForLoad]):
449         (-[TestWKWebView mouseUpAtPoint:]):
450         * WebKitTestRunner/TestController.cpp:
451         (WTR::TestController::createOtherPage):
452         (WTR::TestController::createWebViewWithOptions):
453
454 2017-01-25  Matt Rajca  <mrajca@apple.com>
455
456         [ios-simulator] API test WebKit2.WebsitePoliciesAutoplayEnabled timing out
457         https://bugs.webkit.org/show_bug.cgi?id=167385
458
459         Reviewed by Alex Christensen.
460
461         * TestWebKitAPI/Tests/WebKit2/autoplay-check.html: Avoid arbitrary timeouts in favor of promises.
462         * TestWebKitAPI/Tests/WebKit2/autoplay-no-audio-check.html:
463         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
464         (TEST): Allow inline (rather than full screen) media playback on iOS.
465
466 2017-01-25  Carlos Garcia Campos  <cgarcia@igalia.com>
467
468         [GTK] Icon Database should be in private browsing mode for ephemeral web views
469         https://bugs.webkit.org/show_bug.cgi?id=167414
470
471         Reviewed by Michael Catanzaro.
472
473         Add a test case to check ephemeral web views don't write favicons to the database.
474
475         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:
476         (ephemeralViewLoadChanged):
477         (testPrivateBrowsing):
478         (testFaviconDatabase):
479
480 2017-01-25  Carlos Garcia Campos  <cgarcia@igalia.com>
481
482         [GTK] Add a private browsing mode to MiniBrowser
483         https://bugs.webkit.org/show_bug.cgi?id=167413
484
485         Reviewed by Michael Catanzaro.
486
487         Add -p/--private command line option to create a private instance. Also add CTRL+SHIFT+P shortcut to create
488         private windows, even on non-private instances.
489
490         * MiniBrowser/gtk/BrowserWindow.c:
491         (webViewTitleChanged): Add [Private] to title window for private windows.
492         (webViewCreate): Pass web context to browser_window_new.
493         (openPrivateWindow): Create a new ephemeral web view and add it to a new window.
494         (browserWindowFinalize): Disconnect web context signal handlers.
495         (browser_window_init): Add shortcut for opening private window.
496         (browser_window_new): It now receives the context and connect to download-started here.
497         (browser_window_get_web_context): Return the context.
498         * MiniBrowser/gtk/BrowserWindow.h:
499         * MiniBrowser/gtk/main.c:
500         (createBrowserTab): Create the web view for the window web context.
501         (aboutDataScriptMessageReceivedCallback): Do not use the default web context, but the window one.
502         (aboutDataHandleRequest): Ditto.
503         (aboutURISchemeRequestCallback): Ditto.
504         (main): Create ephemeral web context if private command line option is used.
505
506 2017-01-25  Ryosuke Niwa  <rniwa@webkit.org>
507
508         collectMatchingElementsInFlatTree should not find elements inside an user agent shadow tree
509         https://bugs.webkit.org/show_bug.cgi?id=167409
510
511         Reviewed by Antti Koivisto.
512
513         Added a test case for collectMatchingElementsInFlatTree not finding elements inside an user agent shadow tree
514         as well as tests for the newly added matchingElementInFlatTree.
515
516         * TestWebKitAPI/Tests/WebKit2/InjectedBundleMakeAllShadowRootsOpen.cpp:
517         (TestWebKitAPI::runJavaScriptAlert):
518         * TestWebKitAPI/Tests/WebKit2/InjectedBundleMakeAllShadowRootsOpen_Bundle.cpp:
519         (TestWebKitAPI::InjectedBundleMakeAllShadowRootOpenTest::initialize):
520         * TestWebKitAPI/Tests/WebKit2/closed-shadow-tree-test.html:
521
522 2017-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
523
524         [GTK] Add API to create ephemeral web views and deprecate the private browsing setting
525         https://bugs.webkit.org/show_bug.cgi?id=167370
526
527         Reviewed by Michael Catanzaro.
528
529         Add several test cases of ephemeral web views.
530
531         * TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp:
532         (testWebViewAuthenticationStorage):
533         * TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp:
534         (ephemeralViewloadChanged):
535         (testCookieManagerEphemeral):
536         (beforeAll):
537         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
538         (testWebKitSettings):
539         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
540         (testWebContextEphemeral):
541         (ephemeralViewloadChanged):
542         (testWebContextProxySettings):
543         (beforeAll):
544         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
545         (ephemeralViewloadChanged):
546         (testWebViewEphemeral):
547         (beforeAll):
548         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebsiteData.cpp:
549         (ephemeralViewloadChanged):
550         (testWebsiteDataEphemeral):
551         (beforeAll):
552
553 2017-01-24  Alex Christensen  <achristensen@webkit.org>
554
555         REGRESSION (r208902): URLWithUserTypedString returns nil with file URLs
556         https://bugs.webkit.org/show_bug.cgi?id=167402
557
558         Reviewed by Ryosuke Niwa.
559
560         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm:
561         (TestWebKitAPI::TEST):
562
563 2017-01-24  Zalan Bujtas  <zalan@apple.com>
564
565         Add simple line layout toggle to MiniBrowser
566         https://bugs.webkit.org/show_bug.cgi?id=167405
567
568         Reviewed by Andreas Kling.
569
570         * MiniBrowser/mac/SettingsController.h:
571         * MiniBrowser/mac/SettingsController.m:
572         (-[SettingsController _populateMenu]):
573         (-[SettingsController validateMenuItem:]):
574         (-[SettingsController toggleSimpleLineLayoutEnabled:]):
575         (-[SettingsController simpleLineLayoutEnabled]):
576         * MiniBrowser/mac/WK1BrowserWindowController.m:
577         (-[WK1BrowserWindowController didChangeSettings]):
578         * MiniBrowser/mac/WK2BrowserWindowController.m:
579         (-[WK2BrowserWindowController didChangeSettings]):
580
581 2017-01-24  Joseph Pecoraro  <pecoraro@apple.com>
582
583         WKR does not include my nick when commit-queue lands my patch
584         https://bugs.webkit.org/show_bug.cgi?id=167388
585
586         Reviewed by Ryosuke Niwa.
587
588         * Scripts/webkitpy/tool/commands/newcommitbot.py:
589         (NewCommitBot._summarize_commit_log):
590         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py:
591         Perform nickname insertion before grabbing "Patch by" details.
592         This way we can include the nickname with the full name.
593
594 2017-01-24  Joseph Pecoraro  <pecoraro@apple.com>
595
596         Fold USER_TIMING into WEB_TIMING and make it a RuntimeEnabledFeature
597         https://bugs.webkit.org/show_bug.cgi?id=167394
598
599         Reviewed by Ryosuke Niwa.
600
601         * Scripts/webkitperl/FeatureList.pm:
602         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
603
604 2017-01-24  Youenn Fablet  <youenn@apple.com>
605
606         [WebRTC] Use HAVE_PTHREAD_COND_TIMEDWAIT_RELATIVE for libwebrtc
607         https://bugs.webkit.org/show_bug.cgi?id=167353
608
609         Reviewed by Alex Christensen.
610
611         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
612         (CMakeGenerator.initialize_targets):
613
614 2017-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
615
616         WKR should not confuse Miguel Gomez with Andres Gomez
617         https://bugs.webkit.org/show_bug.cgi?id=167389
618
619         Reviewed by Lucas Forschler.
620
621         Andres's email is a substring of Miguel's, causing WKR to credit Miguel's commits to
622         "mAndres Gomez". Fix this.
623
624         * Scripts/webkitpy/tool/commands/newcommitbot.py:
625         (NewCommitBot._summarize_commit_log): Be stricter about matching emails. SVN logs include a
626         space on each side of the email address, so expect both spaces to be there before
627         considering the email for replacement.
628         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py: Add a test.
629
630 2017-01-24  Matt Rajca  <mrajca@apple.com>
631
632         Pass down website autoplay policies to media elements
633         https://bugs.webkit.org/show_bug.cgi?id=167355
634
635         Reviewed by Alex Christensen.
636
637         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
638         * TestWebKitAPI/Tests/WebKit2/autoplay-check.html: Renamed from Tools/TestWebKitAPI/Tests/WebKit2/autoplayCheck.html to match our naming conventions.
639         * TestWebKitAPI/Tests/WebKit2/autoplay-no-audio-check.html: Added.
640         * TestWebKitAPI/Tests/WebKit2/test-without-audio-track.mp4: Added.
641         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
642         (-[AutoplayPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
643         (TEST):
644
645 2017-01-24  Nan Wang  <n_wang@apple.com>
646
647         AX: Speak Selection does not work in an iframe
648         https://bugs.webkit.org/show_bug.cgi?id=166794
649         <rdar://problem/29913013>
650
651         Reviewed by Chris Fleizach.
652
653         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
654         (WTR::UIScriptController::retrieveSpeakSelectionContent):
655         (WTR::UIScriptController::accessibilitySpeakSelectionContent):
656         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
657         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
658         (WTR::UIScriptController::retrieveSpeakSelectionContent):
659         (WTR::UIScriptController::accessibilitySpeakSelectionContent):
660         * TestRunnerShared/UIScriptContext/UIScriptController.h:
661         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
662         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
663         (-[TestRunnerWKWebView dealloc]):
664         (-[TestRunnerWKWebView _accessibilityDidGetSpeakSelectionContent:]):
665         (-[TestRunnerWKWebView accessibilityRetrieveSpeakSelectionContentWithCompletionHandler:]):
666         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
667         (WTR::UIScriptController::retrieveSpeakSelectionContent):
668         (WTR::UIScriptController::accessibilitySpeakSelectionContent):
669
670 2017-01-24  Daniel Bates  <dabates@apple.com>
671
672         StringView.split() should use an iterator design pattern instead of allocating a Vector
673         https://bugs.webkit.org/show_bug.cgi?id=163225
674
675         Reviewed by Darin Adler.
676
677         Add unit tests for StringView.split().
678
679         * TestWebKitAPI/Tests/WTF/StringView.cpp:
680         (TestWebKitAPI::stringViewFromLiteral): Moved to the top of the file so that it can be
681         used in the StringView.split() unit tests.
682         (TestWebKitAPI::stringViewFromUTF8): Ditto.
683         (TestWebKitAPI::vectorFromSplitResult): Convenience function to convert a StringView::SplitResult
684         object to a Vector of String objects.
685         (TestWebKitAPI::TEST): Added the following tests:
686             - WTF.StringViewSplitEmptyAndNullStrings
687             - WTF.StringViewSplitBasic
688             - WTF.StringViewSplitWithConsecutiveSeparators
689
690 2017-01-23  Anders Carlsson  <andersca@apple.com>
691
692         The Score Esports crashes on launch
693         https://bugs.webkit.org/show_bug.cgi?id=167338
694         rdar://problem/29948645
695
696         Reviewed by Dan Bernstein.
697
698         * TestWebKitAPI/Tests/WebKit2Cocoa/WKObject.mm:
699         (TestWebKitAPI::TEST):
700         Add a test.
701
702 2017-01-23  Carlos Garcia Campos  <cgarcia@igalia.com>
703
704         [GTK] Add API to WebKitWebsiteDataManager to handle website data
705         https://bugs.webkit.org/show_bug.cgi?id=146589
706
707         Reviewed by Michael Catanzaro.
708
709         Add about:data handler to MiniBrowser to manually test the website data API. Also add unit tests to test all the
710         new API, moving the WebKitWebsiteDataManager configuration API to the new file too.
711
712         * MiniBrowser/gtk/BrowserWindow.c:
713         (webViewDecidePolicy):
714         (newTabCallback):
715         * MiniBrowser/gtk/main.c:
716         (createBrowserTab):
717         (aboutDataRequestFree):
718         (aboutDataRequestNew):
719         (aboutDataRequestForView):
720         (websiteDataRemovedCallback):
721         (websiteDataClearedCallback):
722         (aboutDataScriptMessageReceivedCallback):
723         (domainListFree):
724         (aboutDataFillTable):
725         (gotWebsiteDataCallback):
726         (aboutDataHandleRequest):
727         (aboutURISchemeRequestCallback):
728         (main):
729         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
730         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
731         (serverCallback):
732         (beforeAll):
733         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebsiteData.cpp: Added.
734         (serverCallback):
735         (WebsiteDataTest::WebsiteDataTest):
736         (WebsiteDataTest::~WebsiteDataTest):
737         (WebsiteDataTest::fetch):
738         (WebsiteDataTest::remove):
739         (WebsiteDataTest::clear):
740         (testWebsiteDataConfiguration):
741         (testWebsiteDataCache):
742         (testWebsiteDataStorage):
743         (testWebsiteDataDatabases):
744         (testWebsiteDataAppcache):
745         (beforeAll):
746         (afterAll):
747
748 2017-01-23  Commit Queue  <commit-queue@webkit.org>
749
750         Unreviewed, rolling out r211062.
751         https://bugs.webkit.org/show_bug.cgi?id=167354
752
753         broke API tests (Requested by alexchristensen on #webkit).
754
755         Reverted changeset:
756
757         "Pass down website autoplay policies to media elements"
758         https://bugs.webkit.org/show_bug.cgi?id=167132
759         http://trac.webkit.org/changeset/211062
760
761 2017-01-23  Alex Christensen  <achristensen@webkit.org>
762
763         URLParser should fail to parse percent-encoded invalid UTF-8 sequences
764         https://bugs.webkit.org/show_bug.cgi?id=167330
765
766         Reviewed by Tim Horton.
767
768         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
769         (TestWebKitAPI::TEST_F):
770
771 2017-01-23  Alex Christensen  <achristensen@webkit.org>
772
773         Make URLs with non-special schemes and a query or fragment but no slash after the host more compatible
774         https://bugs.webkit.org/show_bug.cgi?id=167317
775
776         Reviewed by Sam Weinig.
777
778         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
779         (TestWebKitAPI::TEST_F):
780
781 2017-01-23  Jonathan Bedard  <jbedard@apple.com>
782
783         svn-create-patch should emit properties when files are moved or copied
784         https://bugs.webkit.org/show_bug.cgi?id=167264
785
786         Reviewed by Daniel Bates.
787
788         * Scripts/svn-create-patch:
789         (manufacturePatchForAdditionWithHistory): Diff the source file against nothing to get properties.
790
791 2017-01-23  Youenn Fablet  <youenn@apple.com>
792
793         [WebRTC] Filter libwebrtc link flags
794         https://bugs.webkit.org/show_bug.cgi?id=167287
795
796         Reviewed by Alex Christensen.
797
798         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
799         (CMakeGenerator._compute_link_flags):
800         (CMakeGenerator._compute_link_flags.keep_flag):
801         (CMakeGenerator._generate_compile_target_options):
802
803 2017-01-23  Youenn Fablet  <youennf@gmail.com>
804
805         [WebRTC] Make VP8 optional in libwebrtc
806         https://bugs.webkit.org/show_bug.cgi?id=167257
807
808         Reviewed by Darin Adler.
809
810         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
811         (CMakeGenerator.remove_libvpx): Adding vp8_noop.cc to the build system.
812
813 2017-01-23  Jer Noble  <jer.noble@apple.com>
814
815         Video details does not apear and missing scrubber in Control Center
816         https://bugs.webkit.org/show_bug.cgi?id=167233
817
818         Reviewed by Alex Christensen.
819
820         Refactor TestWKWebViewMac to work on PLATFORM(IOS). Add a new test to
821         NowPlayingControlTests for iOS.
822
823         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
824         * TestWebKitAPI/Tests/WebKit2Cocoa/NowPlayingControlsTests.mm:
825         (-[NowPlayingTestWebView setWindowVisible:]):
826         (TestWebKitAPI::TEST):
827         * TestWebKitAPI/Tests/WebKit2Cocoa/SnapshotStore.mm:
828         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
829         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewCandidateTests.mm:
830         * TestWebKitAPI/cocoa/TestWKWebView.h: Renamed from Tools/TestWebKitAPI/mac/TestWKWebViewMac.h.
831         * TestWebKitAPI/cocoa/TestWKWebView.mm: Renamed from Tools/TestWebKitAPI/mac/TestWKWebViewMac.mm.
832         (SOFT_LINK_CLASS):
833         (-[TestMessageHandler addMessage:withHandler:]):
834         (-[TestMessageHandler userContentController:didReceiveScriptMessage:]):
835         (__simulated_forceClickAssociatedEventsMask):
836         (-[TestWKWebViewHostWindow _mouseDownAtPoint:simulatePressure:]):
837         (-[TestWKWebViewHostWindow isKeyWindow]):
838         (-[TestWKWebViewHostWindow makeKeyWindow]):
839         (-[TestWKWebViewHostWindow resignKeyWindow]):
840         (-[TestWKWebView initWithFrame:]):
841         (-[TestWKWebView initWithFrame:configuration:]):
842         (-[TestWKWebView _setUpTestWindow:]):
843         (-[TestWKWebView performAfterReceivingMessage:action:]):
844         (-[TestWKWebView loadTestPageNamed:]):
845         (-[TestWKWebView synchronouslyLoadTestPageNamed:]):
846         (-[TestWKWebView stringByEvaluatingJavaScript:]):
847         (-[TestWKWebView waitForMessage:]):
848         (-[TestWKWebView performAfterLoading:]):
849         (-[TestWKWebView mouseDownAtPoint:simulatePressure:]):
850         (-[TestWKWebView typeCharacter:]):
851
852 2017-01-21  Carlos Garcia Campos  <cgarcia@igalia.com>
853
854         Unreviewed. Bring back gtk-doc error messages after r209981.
855
856         Since r209981, if gtk-doc shows warnings the build fails but those warnings are not printed to stdout so it's
857         impossible to know what's wrong.
858
859         * gtk/gtkdoc.py:
860         (GTKDoc._run_command): Make print_output True by default again and use debug instead of info to log "Running" messages.
861
862 2017-01-20  Youenn Fablet  <youennf@gmail.com>
863
864         [WebRTC] Update build system to make G711 optional in libwebrtc
865         https://bugs.webkit.org/show_bug.cgi?id=167256
866
867         Reviewed by Alex Christensen.
868
869         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
870         (CMakeGenerator.remove_webrtc_g711): Adding a missing file to the build system as this file includes generic pcm encoder functions.
871
872 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
873
874         Cleanup RuntimeEnabledFeatures
875         https://bugs.webkit.org/show_bug.cgi?id=167228
876
877         Reviewed by Simon Fraser.
878
879         * DumpRenderTree/mac/DumpRenderTree.mm:
880         (enableExperimentalFeatures):
881         (resetWebPreferencesToConsistentValues):
882         (setWebPreferencesForTestOptions):
883         (resetWebViewToConsistentStateBeforeTesting):
884         * DumpRenderTree/win/DumpRenderTree.cpp:
885         (enableExperimentalFeatures):
886         (resetWebPreferencesToConsistentValues):
887         More closely match WebKitTestRunner initialization of preferences
888         for experimental features.
889
890 2017-01-20  Alex Christensen  <achristensen@webkit.org>
891
892         Build Fix for Windows DumpRenderTree after r210976
893         https://bugs.webkit.org/show_bug.cgi?id=167115
894
895         * DumpRenderTree/win/DumpRenderTree.cpp:
896         (resetWebPreferencesToConsistentValues):
897
898 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
899
900         Remove outdated ENABLE(CSP_NEXT) build flag
901         https://bugs.webkit.org/show_bug.cgi?id=167252
902
903         Reviewed by Brent Fulgham.
904
905         * Scripts/webkitperl/FeatureList.pm:
906         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
907
908 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
909
910         Build Fix for Windows DumpRenderTree after r210976
911
912         * DumpRenderTree/win/DumpRenderTree.cpp:
913         (resetWebPreferencesToConsistentValues):
914
915 2017-01-20  Antoine Quint  <graouts@apple.com>
916
917         Web Animations should be off by default and enabled as an experimental feature
918         https://bugs.webkit.org/show_bug.cgi?id=167115
919         <rdar://problem/30048963>
920
921         Reviewed by Joseph Pecoraro.
922
923         Turn Web Animations on in DRT.
924
925         * DumpRenderTree/mac/DumpRenderTree.mm:
926         (resetWebPreferencesToConsistentValues):
927         * DumpRenderTree/win/DumpRenderTree.cpp:
928         (resetWebPreferencesToConsistentValues):
929
930 2017-01-20  Youenn Fablet  <youenn@apple.com>
931
932         [WebRTC] Add libwebrtc build infrastructure
933         https://bugs.webkit.org/show_bug.cgi?id=167207
934
935         Reviewed by Alex Christensen.
936
937         Adding a script doing the libwebrtc project json to CMake file conversion.
938
939         * Scripts/generate-libwebrtc-cmake: Added.
940         * Scripts/webkitpy/libwebrtc/__init__.py: Added.
941         * Scripts/webkitpy/libwebrtc/generate_cmake.py: Added.
942
943 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
944
945         Mini Browser: Show tooltip for Experimental Features
946         https://bugs.webkit.org/show_bug.cgi?id=167225
947
948         Reviewed by Alex Christensen.
949
950         * MiniBrowser/mac/SettingsController.m:
951         (-[SettingsController _populateMenu]):
952         Include the full details string as a tooltip.
953
954 2017-01-20  Per Arne Vollan  <pvollan@apple.com>
955
956         [Win] Test output results should not be written twice.
957         https://bugs.webkit.org/show_bug.cgi?id=167197
958
959         Reviewed by Brent Fulgham.
960
961         Prevent test output from being written twice by returning early from
962         the dump() function, if it already has been called.
963         This patch also adds a missing newline to a test output line. 
964         
965         * DumpRenderTree/win/DumpRenderTree.cpp:
966         (dump):
967
968 2017-01-20  Antoine Quint  <graouts@apple.com>
969
970         [Modern Media Controls] Turn modern media controls on by default
971         https://bugs.webkit.org/show_bug.cgi?id=165668
972
973         Reviewed by Dean Jackson.
974
975         Enabled modern media controls by default in test runners.
976
977         * DumpRenderTree/TestOptions.h:
978         * WebKitTestRunner/TestOptions.h:
979
980 2017-01-19  Chris Dumez  <cdumez@apple.com>
981
982         iterable<> should be enabled on WK1
983         https://bugs.webkit.org/show_bug.cgi?id=167221
984         <rdar://problem/30108531>
985
986         Reviewed by Youenn Fablet.
987
988         * DumpRenderTree/mac/DumpRenderTree.mm:
989         (resetWebPreferencesToConsistentValues):
990         * DumpRenderTree/win/DumpRenderTree.cpp:
991         (resetWebPreferencesToConsistentValues):
992         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
993         (WTR::InjectedBundle::beginTesting):
994         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
995         (WTR::TestRunner::setDOMIteratorEnabled): Deleted.
996         * WebKitTestRunner/InjectedBundle/TestRunner.h:
997
998 2017-01-19  Aakash Jain  <aakash_jain@apple.com>
999
1000         Ensure status server logs go to log file
1001         https://bugs.webkit.org/show_bug.cgi?id=167210
1002
1003         Reviewed by Alexey Proskuryakov.
1004
1005         * Scripts/webkitpy/common/net/statusserver.py:
1006         (StatusServer.next_work_item): Change log level from debug to info in
1007         order to facilitate deubgging issues.
1008         (StatusServer.update_work_items): Same.
1009
1010 2017-01-19  Megan Gardner  <megan_gardner@apple.com>
1011
1012         Additional selection tests and interpolation fix
1013         https://bugs.webkit.org/show_bug.cgi?id=167171
1014
1015         Reviewed by Simon Fraser.
1016
1017         We weren't adding the final event when interpolating event streams.
1018
1019         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1020         (-[HIDEventGenerator interpolatedEvents:]):
1021
1022 2017-01-19  Myles C. Maxfield  <mmaxfield@apple.com>
1023
1024         [Cocoa] Variation fonts are erroneously disabled on iOS
1025         https://bugs.webkit.org/show_bug.cgi?id=167172
1026
1027         Reviewed by Simon Fraser.
1028
1029         OpenSource builders don't seem to understand sdk=embedded*.
1030
1031         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1032
1033 2017-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
1034
1035         Unreviewed. Fix GTK+ unit tests failing since r210531.
1036
1037         Avoid using paths to files that don't actually exist.
1038
1039         * TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp:
1040         (testWebKitConsoleMessageNetworkError):
1041         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
1042         (testContextMenuDefaultMenu):
1043         * TestWebKitAPI/Tests/WebKit2Gtk/resources/silence.mpg: Added.
1044         * TestWebKitAPI/Tests/WebKit2Gtk/resources/simple.json: Added.
1045         * TestWebKitAPI/Tests/WebKit2Gtk/resources/tracks.ogg: Added.
1046
1047 2017-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
1048
1049         [GTK] Provide API to set proxy settings
1050         https://bugs.webkit.org/show_bug.cgi?id=128674
1051
1052         Reviewed by Michael Catanzaro.
1053
1054         Add tests for new proxy settings API.
1055
1056         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
1057         (serverCallback):
1058         (ProxyTest::ProxyTest):
1059         (ProxyTest::~ProxyTest):
1060         (ProxyTest::loadURIAndGetMainResourceData):
1061         (ProxyTest::proxyServerPortAsString):
1062         (testWebContextProxySettings):
1063         (beforeAll):
1064
1065 2017-01-19  Timothy Hatcher  <timothy@hatcher.name>
1066
1067         Add back my old email address so old commits will still match it.
1068
1069         * Scripts/webkitpy/common/config/contributors.json:
1070
1071 2017-01-19  Timothy Hatcher  <timothy@hatcher.name>
1072
1073         Remove my old email address from contributors.json and watchlist.
1074
1075         * Scripts/validate-committer-lists:
1076         (CommitterListFromGit): Change the mapping to the correct email.
1077         * Scripts/webkitpy/common/config/contributors.json:
1078         * Scripts/webkitpy/common/config/watchlist:
1079
1080 2017-01-18  Ryan Haddad  <ryanhaddad@apple.com>
1081
1082         Unreviewed, rolling out r210848.
1083
1084         This change introduced media-related LayoutTest failures and
1085         crashes on macOS.
1086
1087         Reverted changeset:
1088
1089         "[Modern Media Controls] Turn modern media controls on by
1090         default"
1091         https://bugs.webkit.org/show_bug.cgi?id=165668
1092         http://trac.webkit.org/changeset/210848
1093
1094 2017-01-18  Andreas Kling  <akling@apple.com>
1095
1096         Document::securityOrigin() should return a reference.
1097         <https://webkit.org/b/167124>
1098
1099         Reviewed by Sam Weinig.
1100
1101         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
1102         (TestWebKitAPI::TEST_F):
1103
1104 2017-01-18  Per Arne Vollan  <pvollan@apple.com>
1105
1106         [Win] Clipboard tests are flaky.
1107         https://bugs.webkit.org/show_bug.cgi?id=167088
1108
1109         Reviewed by Brent Fulgham.
1110
1111         Tests involving the clipboard are flaky when running with multiple DRTs, since the clipboard is global. 
1112         We can fix this by assigning each DRT a separate window station (each window station has its own clipboard).
1113
1114         * DumpRenderTree/win/DumpRenderTree.cpp:
1115         (main):
1116
1117 2017-01-18  Antoine Quint  <graouts@apple.com>
1118
1119         [Modern Media Controls] Turn modern media controls on by default
1120         https://bugs.webkit.org/show_bug.cgi?id=165668
1121
1122         Reviewed by Dean Jackson.
1123
1124         Enabled modern media controls by default in test runners. 
1125
1126         * DumpRenderTree/TestOptions.h:
1127         * WebKitTestRunner/TestOptions.h:
1128
1129 2017-01-17  Michael Catanzaro  <mcatanzaro@igalia.com>
1130
1131         Unreviewed, rolling out r210834
1132         https://bugs.webkit.org/show_bug.cgi?id=165668
1133
1134         It introduced dozens of test timeouts.
1135
1136         Reverted changeset:
1137         "[Modern Media Controls] Turn modern media controls on by default"
1138         https://bugs.webkit.org/show_bug.cgi?id=165668
1139         http://trac.webkit.org/changeset/210834
1140
1141 2017-01-17  Antoine Quint  <graouts@apple.com>
1142
1143         [Modern Media Controls] Turn modern media controls on by default
1144         https://bugs.webkit.org/show_bug.cgi?id=165668
1145
1146         Reviewed by Dean Jackson.
1147
1148         Enabled modern media controls by default in test runners. 
1149
1150         * DumpRenderTree/TestOptions.h:
1151         * WebKitTestRunner/TestOptions.h:
1152
1153 2017-01-17  Chris Dumez  <cdumez@apple.com>
1154
1155         Document title changed twice when setting document.title
1156         https://bugs.webkit.org/show_bug.cgi?id=167065
1157
1158         Reviewed by Darin Adler.
1159
1160         Add WebKit2GTK API test that was written by Michael Catanzaro.
1161
1162         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1163         (testWebViewTitleChange):
1164         (beforeAll):
1165
1166 2017-01-17  Joseph Pecoraro  <pecoraro@apple.com>
1167
1168         ENABLE(USER_TIMING) Not Defined for Apple Windows or OS X Ports
1169         https://bugs.webkit.org/show_bug.cgi?id=116551
1170         <rdar://problem/13949830>
1171
1172         Reviewed by Alex Christensen.
1173
1174         * Scripts/webkitperl/FeatureList.pm:
1175         Remove stale RESOURCE_TIMING references which are now a runtime enabled feature
1176         that is part of the existing WEB_TIMING feature.
1177
1178         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1179
1180 2017-01-17  Jonathan Bedard  <jbedard@apple.com>
1181
1182         'webkit-patch post' no longer works with moved/copied files
1183         https://bugs.webkit.org/show_bug.cgi?id=166914
1184         <rdar://problem/29979707>
1185
1186         Reviewed by Daniel Bates.
1187
1188         SVN 1.9 has a bug where when a file has been moved or copied, the svn diff of the new
1189         file outputs only the "Index:" line with an empty body.  This workaround
1190         ignores such output from svn diff.  A issue has been filed with SVN, a link to the
1191         public email list tracking this bug is below.
1192         http://mail-archives.apache.org/mod_mbox/subversion-users/201701.mbox/%3cCF9BDE0A-7454-4405-8259-1120C6B76A03@apple.com%3e
1193         
1194
1195         * Scripts/svn-create-patch:
1196         (generateDiff): Ignore an "Index:" line with an empty body.
1197
1198 2017-01-16  Joseph Pecoraro  <pecoraro@apple.com>
1199
1200         Remove the REQUEST_ANIMATION_FRAME flag
1201         https://bugs.webkit.org/show_bug.cgi?id=156980
1202         <rdar://problem/25906849>
1203
1204         Reviewed by Simon Fraser.
1205
1206         * Scripts/webkitperl/FeatureList.pm:
1207         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1208
1209 2017-01-15  Sam Weinig  <sam@webkit.org>
1210
1211         Add the ability to use numbers in makeString()
1212         https://bugs.webkit.org/show_bug.cgi?id=167087
1213
1214         Reviewed by Darin Adler.
1215
1216         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1217         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Added.
1218         Add tests for StringConcatenate, focusing on new numeric additions.
1219
1220 2017-01-15  Michael Catanzaro  <mcatanzaro@igalia.com>
1221
1222         Unreviewed, remove stale comment.
1223
1224         This test was fixed by r163173.
1225
1226         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
1227
1228 2017-01-14  Yusuke Suzuki  <utatane.tea@gmail.com>
1229
1230         Annotate large string tests with largeHeap
1231         https://bugs.webkit.org/show_bug.cgi?id=167054
1232
1233         Reviewed by Filip Pizlo.
1234
1235         * Scripts/run-javascriptcore-tests:
1236         * Scripts/run-jsc-stress-tests:
1237
1238 2017-01-14  Joseph Pecoraro  <pecoraro@apple.com>
1239
1240         Remove stale references to ENABLE_ES6_GENERATORS and ENABLE_PROMISES
1241         https://bugs.webkit.org/show_bug.cgi?id=167043
1242
1243         Reviewed by Darin Adler.
1244
1245         * Scripts/webkitperl/FeatureList.pm:
1246
1247 2017-01-13  Joseph Pecoraro  <pecoraro@apple.com>
1248
1249         Remove ENABLE(DETAILS_ELEMENT) guards
1250         https://bugs.webkit.org/show_bug.cgi?id=167042
1251
1252         Reviewed by Alex Christensen.
1253
1254         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1255
1256 2017-01-13  Said Abou-Hallawa  <sabouhallawa@apple.com>
1257
1258         26 MotionMark performance tests failing
1259         https://bugs.webkit.org/show_bug.cgi?id=166854
1260
1261         Reviewed by Ryosuke Niwa.
1262
1263         Unrelated change. This is the last place that we need to rename Animometer
1264         to MotionMark.
1265
1266         * Scripts/webkitpy/common/config/watchlist:
1267
1268 2017-01-13  Yusuke Suzuki  <utatane.tea@gmail.com>
1269
1270         run-jsc-benchmarks' echo should have -e option
1271         https://bugs.webkit.org/show_bug.cgi?id=167009
1272
1273         Reviewed by Sam Weinig.
1274
1275         echo requires `-e` option to use escape sequence.
1276         Without it, in some environment (in my Fedora 25), the escape sequence is not
1277         recognized and just dumped as `\c` etc.
1278
1279         * Scripts/run-jsc-benchmarks:
1280
1281 2017-01-12  Chris Dumez  <cdumez@apple.com>
1282
1283         Add KEYBOARD_KEY_ATTRIBUTE / KEYBOARD_CODE_ATTRIBUTE to FeatureDefines.xcconfig
1284         https://bugs.webkit.org/show_bug.cgi?id=166995
1285
1286         Reviewed by Jer Noble.
1287
1288         Add KEYBOARD_KEY_ATTRIBUTE / KEYBOARD_CODE_ATTRIBUTE to FeatureDefines.xcconfig
1289         as some people are having trouble building without it.
1290
1291         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1292
1293 2017-01-12  Sam Weinig  <sam@webkit.org>
1294
1295         Add the ability to filter the set of bindings tests you want to run
1296         https://bugs.webkit.org/show_bug.cgi?id=166977
1297
1298         Reviewed by Tim Horton.
1299
1300         Allows doing things like:
1301             run-bindings-tests TestObj* TestCEReactions*
1302         
1303         to run only those tests that match the patterns.
1304
1305         * Scripts/run-bindings-tests:
1306         (main):
1307         Switch to using optparse and pass the remaining args as the filters.
1308
1309         * Scripts/webkitpy/bindings/main.py:
1310         (BindingsTests.__init__):
1311         Store the pattens.
1312
1313         (BindingsTests.test_matches_patterns):
1314         Add helper predicate to determine if a test should be run. When no
1315         patterns are present, all tests should run.
1316
1317         (BindingsTests.run_tests):
1318         Filter tests using the passed in patterns.
1319
1320 2017-01-12  Per Arne Vollan  <pvollan@apple.com>
1321
1322         Followup fix after r210503.
1323         https://bugs.webkit.org/show_bug.cgi?id=166887
1324
1325         Reviewed by Alex Christensen.
1326
1327         After <http://trac.webkit.org/changeset/210503>, test results are written to a
1328         duplicated file handle on Windows. This patch fixes the remaining call sites.
1329
1330         * DumpRenderTree/PixelDumpSupport.cpp:
1331         * DumpRenderTree/TestRunner.cpp:
1332         (TestRunner::waitToDumpWatchdogTimerFired):
1333         * DumpRenderTree/TestRunner.h:
1334         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
1335         * DumpRenderTree/win/DumpRenderTree.cpp:
1336         * DumpRenderTree/win/DumpRenderTreeWin.h:
1337         * DumpRenderTree/win/TestRunnerWin.cpp:
1338         (TestRunner::setSpellCheckerLoggingEnabled):
1339
1340 2017-01-11  Megan Gardner  <megan_gardner@apple.com>
1341
1342         Add committer status for Megan
1343         https://bugs.webkit.org/show_bug.cgi?id=166954
1344
1345         Reviewed by Tim Horton.
1346
1347         Add committer status for Megan Gardner
1348
1349         * Scripts/webkitpy/common/config/contributors.json:
1350
1351 2017-01-11  Brent Fulgham  <bfulgham@apple.com>
1352
1353         Unreviewed test fix after r210599.
1354
1355         * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp:
1356         (TestWebKitAPI::TEST): Remove debugging code that was causing a timeout.
1357
1358 2017-01-11  Brent Fulgham  <bfulgham@apple.com>
1359
1360         Unreviewed build fix after r210599.
1361
1362         Add missing files.
1363
1364         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
1365         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
1366
1367 2017-01-11  Brent Fulgham  <bfulgham@apple.com>
1368
1369         File scheme should not allow access of a resource on a different volume.
1370         https://bugs.webkit.org/show_bug.cgi?id=158552
1371         <rdar://problem/15307582>
1372
1373         Reviewed by Alex Christensen.
1374
1375         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
1376         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
1377         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
1378
1379 2017-01-11  Ryan Haddad  <ryanhaddad@apple.com>
1380
1381         Unreviewed, rolling out r210571.
1382
1383         This change broke the 32-bit macOS build and caused LayoutTest
1384         failures.
1385
1386         Reverted changeset:
1387
1388         "File scheme should not allow access of a resource on a
1389         different volume."
1390         https://bugs.webkit.org/show_bug.cgi?id=158552
1391         http://trac.webkit.org/changeset/210571
1392
1393 2017-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1394
1395         [GTK] install-dependencies script misses gdb
1396         https://bugs.webkit.org/show_bug.cgi?id=166917
1397
1398         Reviewed by Michael Catanzaro.
1399
1400         gdb is needed for generating the crash logs.
1401
1402         * gtk/install-dependencies:
1403
1404 2017-01-10  Michael Catanzaro  <mcatanzaro@igalia.com>
1405
1406         [GTK] No way for applications to set notification permissions without waiting for permission request
1407         https://bugs.webkit.org/show_bug.cgi?id=163366
1408
1409         Reviewed by Carlos Garcia Campos.
1410
1411         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1412         (testWebViewNotification):
1413         (setInitialNotificationPermissionsAllowedCallback):
1414         (setInitialNotificationPermissionsDisallowedCallback):
1415         (testWebViewNotificationInitialPermissionAllowed):
1416         (testWebViewNotificationInitialPermissionDisallowed):
1417         (beforeAll):
1418         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
1419         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
1420         (WebViewTest::WebViewTest):
1421         (WebViewTest::initializeWebView):
1422         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
1423
1424 2017-01-10  Tim Horton  <timothy_horton@apple.com>
1425
1426         MobileMiniBrowser tests don't work by default
1427         https://bugs.webkit.org/show_bug.cgi?id=166910
1428
1429         Reviewed by Alex Christensen.
1430
1431         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/xcshareddata/xcschemes/MobileMiniBrowserUITests.xcscheme: Added.
1432         Add a shared scheme; the Makefile depends on the MobileMiniBrowserUITests scheme existing, at the very least.
1433
1434 2017-01-10  Brent Fulgham  <bfulgham@apple.com>
1435
1436         File scheme should not allow access of a resource on a different volume.
1437         https://bugs.webkit.org/show_bug.cgi?id=158552
1438         <rdar://problem/15307582>
1439
1440         Reviewed by Alex Christensen.
1441
1442         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
1443         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
1444         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
1445
1446 2017-01-10  Mark Lam  <mark.lam@apple.com>
1447
1448         Reverting run-jsc-stress-tests' $buildType to use string values.
1449         https://bugs.webkit.org/show_bug.cgi?id=166912
1450
1451         Rubber stamped by Filip Pizlo.
1452
1453         This is so that we can test for it in the tests e.g.
1454         //@ if $buildType == "debug" then runDefault("--maxSingleAllocationSize=1048576") else skip end
1455
1456         * Scripts/run-jsc-stress-tests:
1457
1458 2017-01-10  Ryosuke Niwa  <rniwa@webkit.org>
1459
1460         Temporarily add back the file removed in r210463 to unbreak internal bots.
1461
1462         * Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch: Copied from Tools/Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch.
1463
1464 2017-01-10  Jonathan Bedard  <jbedard@apple.com>
1465
1466         svn-apply failed to apply a patch (deleting file with svn property)
1467         https://bugs.webkit.org/show_bug.cgi?id=165953
1468
1469         Reviewed by Daniel Bates.
1470
1471         * Scripts/VCSUtils.pm:
1472         (parseSvnPropertyValue): The beginning of a diff will cause an early exit in the case of no empty newlines.
1473         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl: Add tests without break between diffs for properties.
1474
1475 2017-01-10  Ryan Haddad  <ryanhaddad@apple.com>
1476
1477         Update flakiness dashboard configuration.
1478         https://bugs.webkit.org/show_bug.cgi?id=166869
1479
1480         Reviewed by Alexey Proskuryakov.
1481
1482         * TestResultServer/static-dashboards/builders.jsonp:
1483         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1484
1485 2017-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1486
1487         [GTK] Stop honoring the environment variable USE_NATIVE_XDISPLAY
1488         https://bugs.webkit.org/show_bug.cgi?id=165232
1489
1490         Unreviewed follow-up patch after r210539 and r210523.
1491
1492         Instead of using that environment variable, the argument
1493         --display-server=xorg should be passed now.
1494
1495         The GTK+ performance bot was the only bot using this, and is
1496         already passing --display-server=xorg after r210539.
1497
1498         * Scripts/webkitpy/port/gtk.py:
1499         (GtkPort._driver_class):
1500
1501 2017-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1502
1503         [GTK] Add a new release test bot for Wayland and pass --display-server=xorg to the GTK Perf bot.
1504         https://bugs.webkit.org/show_bug.cgi?id=166872
1505
1506         Reviewed by Michael Catanzaro.
1507
1508         Add the new wayland release test bot as a test-only bot. It will download the built product from the release build-only bot.
1509         Define the required "--display-server=driver" in the bot additionalArguments config entry.
1510         Implement support for honoring additionalArguments on the RunGtkAPITests and RunAndUploadPerfTests steps.
1511         The step RunWebKitTests already has support for it.
1512
1513         * BuildSlaveSupport/build.webkit.org-config/config.json:
1514         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1515         (RunGtkAPITests.start):
1516         (RunAndUploadPerfTests.start):
1517         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1518
1519 2017-01-09  Ryan Haddad  <ryanhaddad@apple.com>
1520
1521         Unreviewed, rolling out r210531.
1522
1523         This change broke the 32-bit macOS build and caused LayoutTest
1524         failures.
1525
1526         Reverted changeset:
1527
1528         "File scheme should not allow access of a resource on a
1529         different volume."
1530         https://bugs.webkit.org/show_bug.cgi?id=158552
1531         http://trac.webkit.org/changeset/210531
1532
1533 2017-01-09  Brent Fulgham  <bfulgham@apple.com>
1534
1535         File scheme should not allow access of a resource on a different volume.
1536         https://bugs.webkit.org/show_bug.cgi?id=158552
1537         <rdar://problem/15307582>
1538
1539         Reviewed by Alex Christensen.
1540
1541         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
1542         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
1543         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
1544
1545 2017-01-09  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1546
1547         [GTK][Wayland] Allow running the layout tests under a native Wayland environment.
1548         https://bugs.webkit.org/show_bug.cgi?id=165232
1549
1550         Reviewed by Michael Catanzaro.
1551
1552         Add a new WaylandDriver to run the tests in the user current wayland session.
1553
1554         Also merge all the configuration options for selecting the display server inside one
1555         switch --display-server=xvfb/xorg/wayland/weston (defaulting to xvfb).
1556
1557         This switch is supported on the scripts: run-gtk-tests, run-perf-tests and run-webkit-tests.
1558
1559         * Scripts/run-gtk-tests: Add missing logging.basicConfig() initialization for the error logger.
1560         (TestRunner._create_driver):
1561         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1562         (parse_args):
1563         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1564         (PerfTestsRunner._parse_args):
1565         * Scripts/webkitpy/port/gtk.py:
1566         (GtkPort.__init__):
1567         (GtkPort._driver_class):
1568         (GtkPort._search_paths):
1569         * Scripts/webkitpy/port/waylanddriver.py: Added.
1570         (WaylandDriver):
1571         (WaylandDriver.check_driver):
1572         (WaylandDriver._setup_environ_for_test):
1573         (WaylandDriver._start):
1574
1575 2017-01-09  Andy Estes  <aestes@apple.com>
1576
1577         [QuickLook] Add a layout test for webkit.org/b/135651
1578         https://bugs.webkit.org/show_bug.cgi?id=166855
1579
1580         Reviewed by Andreas Kling.
1581
1582         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1583         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]): Added output for
1584         errors with code WebKitErrorCannotShowURL.
1585         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1586         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame): Made the error output
1587         not specific to WebKit2 error codes.
1588
1589 2017-01-09  Antoine Quint  <graouts@apple.com>
1590
1591         Support webkit-test-runner key-value pairs in http tests in DumpRenderTree
1592         https://bugs.webkit.org/show_bug.cgi?id=166837
1593
1594         Reviewed by Alex Christensen.
1595
1596         We now correctly handle the --absolutePath argument in DumpRenderTree and use
1597         the provided value when trying to determine the path to the test file. Failing
1598         that, we use the computed URL or the raw path provided to cover all cases.
1599         
1600         This was tested in the context of https://bugs.webkit.org/show_bug.cgi?id=165668
1601         by applying this patch and seeing the number test failures dramatically reduced
1602         with WK1 due to the option to turn modern media controls off for older media controls
1603         tests.
1604
1605         * DumpRenderTree/DumpRenderTree.h:
1606         * DumpRenderTree/DumpRenderTreeCommon.cpp:
1607         (parseInputLine):
1608         * DumpRenderTree/TestOptions.h:
1609         * DumpRenderTree/TestOptions.mm:
1610         (TestOptions::TestOptions):
1611         * DumpRenderTree/mac/DumpRenderTree.mm:
1612         (runTest):
1613
1614 2017-01-09  Milan Crha  <mcrha@redhat.com>
1615
1616         prepare-ChangeLog: Correct help string for --style option
1617         https://bugs.webkit.org/show_bug.cgi?id=166725
1618
1619         Reviewed by Alexey Proskuryakov.
1620
1621         * Scripts/prepare-ChangeLog:
1622         (main):
1623
1624 2017-01-09  Lucas Forschler  <lforschler@apple.com>
1625
1626         https://bugs.webkit.org/show_bug.cgi?id=166839
1627         Add php7 support for macOS.
1628         Mirror the debian logic to look for a php7 module on disk, and return the appropriate apache config file.
1629
1630         Reviewed by Alexey Proskuryakov.
1631
1632         * Scripts/webkitpy/port/base.py:
1633         (Port._is_darwin_php_version_7):
1634         (Port._debian_php_version):
1635         (Port):
1636         (Port._darwin_php_version):
1637         (Port._apache_config_file_name_for_platform):
1638
1639 2017-01-06  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1640
1641         [GTK] Should support key and code properties on keyboard events
1642         https://bugs.webkit.org/show_bug.cgi?id=166759
1643
1644         Reviewed by Carlos Garcia Campos.
1645
1646         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
1647         (WTR::getGDKKeySymForKeyRef): add missing modifier keys which were being reported as 'l' and 'r' only
1648         on tests.
1649
1650 2017-01-06  Per Arne Vollan  <pvollan@apple.com>
1651
1652         [Win] Some tests are flaky because certain DLLs are writing to stdout.
1653         https://bugs.webkit.org/show_bug.cgi?id=166760
1654
1655         Reviewed by Darin Adler.
1656
1657         Some tests are flaky because certain DLLs are writing to stdout, giving incorrect test results.
1658         We can work around that by duplicating and redirecting stdout.
1659
1660         * DumpRenderTree/PixelDumpSupport.cpp:
1661         (dumpWebViewAsPixelsAndCompareWithExpected):
1662         (printPNG):
1663         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
1664         (logEventProc):
1665         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
1666         (DRTDesktopNotificationPresenter::showDesktopNotification):
1667         (DRTDesktopNotificationPresenter::cancelDesktopNotification):
1668         (DRTDesktopNotificationPresenter::requestNotificationPermission):
1669         * DumpRenderTree/win/DumpRenderTree.cpp:
1670         (dumpFrameScrollPosition):
1671         (dumpHistoryItem):
1672         (dumpBackForwardList):
1673         (dump):
1674         (runTest):
1675         (main):
1676         * DumpRenderTree/win/DumpRenderTreeWin.h:
1677         * DumpRenderTree/win/EditingDelegate.cpp:
1678         (EditingDelegate::shouldBeginEditingInDOMRange):
1679         (EditingDelegate::shouldEndEditingInDOMRange):
1680         (EditingDelegate::shouldInsertNode):
1681         (EditingDelegate::shouldInsertText):
1682         (EditingDelegate::shouldDeleteDOMRange):
1683         (EditingDelegate::shouldChangeSelectedDOMRange):
1684         (EditingDelegate::shouldApplyStyle):
1685         (EditingDelegate::shouldChangeTypingStyle):
1686         (EditingDelegate::doPlatformCommand):
1687         (EditingDelegate::webViewDidBeginEditing):
1688         (EditingDelegate::webViewDidChange):
1689         (EditingDelegate::webViewDidEndEditing):
1690         (EditingDelegate::webViewDidChangeTypingStyle):
1691         (EditingDelegate::webViewDidChangeSelection):
1692         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1693         (FrameLoadDelegate::didStartProvisionalLoadForFrame):
1694         (FrameLoadDelegate::didReceiveServerRedirectForProvisionalLoadForFrame):
1695         (FrameLoadDelegate::didChangeLocationWithinPageForFrame):
1696         (FrameLoadDelegate::didFailProvisionalLoadWithError):
1697         (FrameLoadDelegate::didCommitLoadForFrame):
1698         (FrameLoadDelegate::didReceiveTitle):
1699         (FrameLoadDelegate::didFinishLoadForFrame):
1700         (FrameLoadDelegate::didFailLoadWithError):
1701         (FrameLoadDelegate::willPerformClientRedirectToURL):
1702         (FrameLoadDelegate::didCancelClientRedirectForFrame):
1703         (FrameLoadDelegate::windowScriptObjectAvailable):
1704         (FrameLoadDelegate::didFinishDocumentLoadForFrame):
1705         (FrameLoadDelegate::didHandleOnloadEventsForFrame):
1706         (FrameLoadDelegate::didDisplayInsecureContent):
1707         (FrameLoadDelegate::didRunInsecureContent):
1708         (FrameLoadDelegate::webViewProgressFinishedNotification):
1709         * DumpRenderTree/win/HistoryDelegate.cpp:
1710         (HistoryDelegate::didNavigateWithNavigationData):
1711         (HistoryDelegate::didPerformClientRedirectFromURL):
1712         (HistoryDelegate::didPerformServerRedirectFromURL):
1713         (HistoryDelegate::updateHistoryTitle):
1714         (HistoryDelegate::populateVisitedLinksForWebView):
1715         * DumpRenderTree/win/PolicyDelegate.cpp:
1716         (PolicyDelegate::decidePolicyForNavigationAction):
1717         (PolicyDelegate::unableToImplementPolicyWithError):
1718         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
1719         (ResourceLoadDelegate::willSendRequest):
1720         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
1721         (ResourceLoadDelegate::didReceiveResponse):
1722         (ResourceLoadDelegate::didFinishLoadingFromDataSource):
1723         (ResourceLoadDelegate::didFailLoadingWithError):
1724         * DumpRenderTree/win/TestRunnerWin.cpp:
1725         (TestRunner::addDisallowedURL):
1726         (TestRunner::originsWithApplicationCache):
1727         (TestRunner::setStorageDatabaseIdleInterval):
1728         (TestRunner::closeIdleLocalStorageDatabases):
1729         (TestRunner::copyDecodedHostName):
1730         (TestRunner::copyEncodedHostName):
1731         (TestRunner::numberOfPendingGeolocationPermissionRequests):
1732         (TestRunner::isGeolocationProviderActive):
1733         (TestRunner::pathToLocalResource):
1734         (TestRunner::setMockDeviceOrientation):
1735         (TestRunner::setMockGeolocationPosition):
1736         (TestRunner::setMockGeolocationPositionUnavailableError):
1737         (TestRunner::setSpatialNavigationEnabled):
1738         (TestRunner::setAutomaticLinkDetectionEnabled):
1739         (TestRunner::isCommandEnabled):
1740         (TestRunner::authenticateSession):
1741         (TestRunner::addChromeInputField):
1742         (TestRunner::removeChromeInputField):
1743         (TestRunner::focusWebView):
1744         (TestRunner::grantWebNotificationPermission):
1745         (TestRunner::denyWebNotificationPermission):
1746         (TestRunner::removeAllWebNotificationPermissions):
1747         (TestRunner::simulateWebNotificationClick):
1748         (TestRunner::imageCountInGeneralPasteboard):
1749         * DumpRenderTree/win/UIDelegate.cpp:
1750         (UIDelegate::runJavaScriptAlertPanelWithMessage):
1751         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
1752         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
1753         (UIDelegate::runBeforeUnloadConfirmPanelWithMessage):
1754         (UIDelegate::webViewAddMessageToConsole):
1755         (UIDelegate::exceededDatabaseQuota):
1756         (UIDelegate::setStatusText):
1757         (UIDelegate::didPressMissingPluginButton):
1758
1759 2017-01-07  Tim Horton  <timothy_horton@apple.com>
1760
1761         Add a setting to create editable MiniBrowser windows by default
1762         https://bugs.webkit.org/show_bug.cgi?id=166806
1763
1764         Reviewed by Beth Dakin.
1765
1766         * MiniBrowser/mac/AppDelegate.m:
1767         (-[BrowserAppDelegate createBrowserWindowController:]):
1768         (-[BrowserAppDelegate applicationDidFinishLaunching:]):
1769         (-[BrowserAppDelegate _updateNewWindowKeyEquivalents]):
1770         * MiniBrowser/mac/SettingsController.h:
1771         * MiniBrowser/mac/SettingsController.m:
1772         (-[SettingsController _populateMenu]):
1773         (-[SettingsController validateMenuItem:]):
1774         (-[SettingsController toggleCreateEditorByDefault:]):
1775         (-[SettingsController createEditorByDefault]):
1776         Add a setting and update the key equivalents accordingly.
1777         Also make sure to make the right kind of window on launch.
1778
1779 2017-01-07  Tim Horton  <timothy_horton@apple.com>
1780
1781         Fix the 32-bit build.
1782
1783         * MiniBrowser/mac/BrowserWindowController.h:
1784         * MiniBrowser/mac/BrowserWindowController.m:
1785
1786 2017-01-07  Tim Horton  <timothy_horton@apple.com>
1787
1788         Fix the 32-bit build.
1789
1790         * MiniBrowser/mac/BrowserWindowController.m:
1791
1792 2017-01-07  Tim Horton  <timothy_horton@apple.com>
1793
1794         Make it possible to drop HTML files on the MiniBrowser icon
1795         https://bugs.webkit.org/show_bug.cgi?id=166802
1796
1797         Reviewed by Simon Fraser.
1798
1799         * MiniBrowser/mac/AppDelegate.m:
1800         (-[BrowserAppDelegate application:openFile:]):
1801         * MiniBrowser/mac/Info.plist:
1802         If you're using an editable window, the usual trick of dropping on the
1803         window doesn't work anymore (it makes an <attachment> instead).
1804
1805 2017-01-07  Tim Horton  <timothy_horton@apple.com>
1806
1807         MiniBrowser window gets smaller each time it is instantiated
1808         https://bugs.webkit.org/show_bug.cgi?id=166807
1809
1810         Reviewed by Andy Estes.
1811
1812         * MiniBrowser/mac/BrowserWindowController.m:
1813         (-[BrowserWindowController windowDidLoad]):
1814         * MiniBrowser/mac/BrowserWindow.xib:
1815         Turn on full-window content view support with IB, instead of waiting
1816         until after the views have been loaded. This seems to resolve the
1817         longstanding ever-shrinking-window problem.
1818
1819 2017-01-07  Tim Horton  <timothy_horton@apple.com>
1820
1821         Add indent/outdent items to MiniBrowser's new format menu
1822         https://bugs.webkit.org/show_bug.cgi?id=166805
1823
1824         Reviewed by Dan Bernstein.
1825
1826         * MiniBrowser/mac/MainMenu.xib:
1827
1828 2017-01-07  Tim Horton  <timothy_horton@apple.com>
1829
1830         Add a stock Format menu to MiniBrowser
1831         https://bugs.webkit.org/show_bug.cgi?id=166804
1832
1833         Reviewed by Andy Estes.
1834
1835         * MiniBrowser/mac/MainMenu.xib:
1836         Many of the features automatically work with editable web views.
1837         However, this seems to expose a bug where none of the font-related features
1838         (Cmd-B, for example) work until the first time the font panel is shown,
1839         per process, which will need to be investigated separately.
1840
1841 2017-01-07  Tim Horton  <timothy_horton@apple.com>
1842
1843         Remove unused applicationWillTerminate methods from MiniBrowser
1844         https://bugs.webkit.org/show_bug.cgi?id=166803
1845
1846         Reviewed by Andy Estes.
1847
1848         * MiniBrowser/mac/AppDelegate.m:
1849         (-[BrowserAppDelegate applicationWillTerminate:]): Deleted.
1850         * MiniBrowser/mac/BrowserWindowController.h:
1851         * MiniBrowser/mac/BrowserWindowController.m:
1852         (-[BrowserWindowController applicationTerminating]): Deleted.
1853         * MiniBrowser/mac/WK1BrowserWindowController.m:
1854         (-[WK1BrowserWindowController applicationTerminating]): Deleted.
1855         * MiniBrowser/mac/WK2BrowserWindowController.m:
1856         (-[WK2BrowserWindowController applicationTerminating]): Deleted.
1857
1858 2017-01-07  Tim Horton  <timothy_horton@apple.com>
1859
1860         Add the ability to create empty contentEditable windows in MiniBrowser
1861         https://bugs.webkit.org/show_bug.cgi?id=166801
1862
1863         Reviewed by Wenson Hsieh.
1864
1865         * MiniBrowser/mac/AppDelegate.h:
1866         * MiniBrowser/mac/AppDelegate.m:
1867         (-[BrowserAppDelegate createBrowserWindowController:]):
1868         (-[BrowserAppDelegate newWindow:]):
1869         (-[BrowserAppDelegate newEditorWindow:]):
1870         (-[BrowserAppDelegate openDocument:]):
1871         (-[BrowserAppDelegate _updateNewWindowKeyEquivalents]):
1872         * MiniBrowser/mac/BrowserWindowController.h:
1873         * MiniBrowser/mac/BrowserWindowController.m:
1874         (-[BrowserWindowController loadHTMLString:]):
1875         (-[BrowserWindowController toggleEditable:]):
1876         * MiniBrowser/mac/MainMenu.xib:
1877         * MiniBrowser/mac/WK1BrowserWindowController.m:
1878         (-[WK1BrowserWindowController awakeFromNib]):
1879         (-[WK1BrowserWindowController loadHTMLString:]):
1880         (-[WK1BrowserWindowController validateMenuItem:]):
1881         (-[WK1BrowserWindowController setEditable:]):
1882         (-[WK1BrowserWindowController updateTitle:]):
1883         * MiniBrowser/mac/WK2BrowserWindowController.m:
1884         (-[WK2BrowserWindowController awakeFromNib]):
1885         (-[WK2BrowserWindowController validateMenuItem:]):
1886         (-[WK2BrowserWindowController setEditable:]):
1887         (-[WK2BrowserWindowController updateTitle:]):
1888         (-[WK2BrowserWindowController loadHTMLString:]):
1889         Merge more functionality from WebEditingTester.
1890         Add two menu items for creating empty editable WebKit1/2 windows.
1891         Add a menu item to the Edit menu to toggle editability on any window.
1892
1893 2017-01-07  Tim Horton  <timothy_horton@apple.com>
1894
1895         Implement find-in-page in MiniBrowser
1896         https://bugs.webkit.org/show_bug.cgi?id=166799
1897
1898         Reviewed by Andy Estes.
1899
1900         * MiniBrowser/mac/BrowserWindow.xib:
1901         * MiniBrowser/mac/BrowserWindowController.h:
1902         * MiniBrowser/mac/BrowserWindowController.m:
1903         (-[BrowserWindowController find:]): Deleted.
1904         * MiniBrowser/mac/MainMenu.xib:
1905         * MiniBrowser/mac/WK1BrowserWindowController.m:
1906         (-[WK1BrowserWindowController toggleShrinkToFit:]):
1907         (-[WK1BrowserWindowController find:]): Deleted.
1908         * MiniBrowser/mac/WK2BrowserWindowController.m:
1909         (-[WK2BrowserWindowController awakeFromNib]):
1910         (-[WK2BrowserWindowController dealloc]):
1911         (-[WK2BrowserWindowController validateMenuItem:]):
1912         (-[WK2BrowserWindowController performTextFinderAction:]):
1913         (-[WK2BrowserWindowController findBarView]):
1914         (-[WK2BrowserWindowController setFindBarView:]):
1915         (-[WK2BrowserWindowController isFindBarVisible]):
1916         (-[WK2BrowserWindowController setFindBarVisible:]):
1917         (-[WK2BrowserWindowController contentView]):
1918         (-[WK2BrowserWindowController findBarViewDidChangeHeight]):
1919         (-[WK2BrowserWindowController performFindPanelAction:]): Deleted.
1920         (-[WK2BrowserWindowController find:]): Deleted.
1921         Implement find-in-page using WKWebView's conformance to the NSTextFinderClient
1922         protocol. At first glance, it's pretty broken, but vaguely works.
1923
1924 2017-01-07  Tim Horton  <timothy_horton@apple.com>
1925
1926         Share the implementation of MiniBrowser view hiding functionality
1927         https://bugs.webkit.org/show_bug.cgi?id=166800
1928
1929         Reviewed by Andy Estes.
1930
1931         * MiniBrowser/mac/BrowserWindowController.m:
1932         (-[BrowserWindowController showHideWebView:]):
1933         (-[BrowserWindowController removeReinsertWebView:]):
1934         * MiniBrowser/mac/WK1BrowserWindowController.m:
1935         (-[WK1BrowserWindowController showHideWebView:]): Deleted.
1936         (-[WK1BrowserWindowController removeReinsertWebView:]): Deleted.
1937         * MiniBrowser/mac/WK2BrowserWindowController.m:
1938         (-[WK2BrowserWindowController showHideWebView:]): Deleted.
1939         (-[WK2BrowserWindowController removeReinsertWebView:]): Deleted.
1940         Move the implementation of these two things to the shared superclass,
1941         since they don't depend on WebKit-specific things.
1942         Also, there was no reason to retain the (WK)WebView while it was unparented,
1943         as the BrowserWindowController maintains a reference the entire time.
1944
1945 2017-01-06  Andy Estes  <aestes@apple.com>
1946
1947         [Cocoa] Consolidate duplicate copies of WebArchiveDumpSupport in DRT and WKTR into WebCoreTestSupport
1948         https://bugs.webkit.org/show_bug.cgi?id=166789
1949
1950         Reviewed by Alex Christensen.
1951
1952         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1953         * DumpRenderTree/PlatformMac.cmake:
1954         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp: Removed.
1955         * DumpRenderTree/cf/WebArchiveDumpSupport.h: Removed.
1956         * DumpRenderTree/mac/DumpRenderTree.mm:
1957         Called WebCoreTestSupport::createXMLStringFromWebArchiveData() instead of
1958         createXMLStringFromWebArchiveData().
1959         * DumpRenderTree/mac/WebArchiveDumpSupportMac.mm: Removed.
1960         * WebKitTestRunner/Configurations/Base.xcconfig:
1961         Added $(BUILT_PRODUCTS_DIR)/WebCoreTestSupport to HEADER_SEARCH_PATHS.
1962         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1963         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
1964         Called WebCoreTestSupport::createXMLStringFromWebArchiveData() instead of
1965         createXMLStringFromWebArchiveData().
1966         * WebKitTestRunner/InjectedBundle/cocoa/WebArchiveDumpSupportCocoa.mm: Removed.
1967         * WebKitTestRunner/PlatformMac.cmake:
1968         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1969         * WebKitTestRunner/cf/WebArchiveDumpSupport.h: Removed.
1970
1971 2017-01-06  Tim Horton  <timothy_horton@apple.com>
1972
1973         Minor cleanups to IndentOutdentCommand and related code
1974         https://bugs.webkit.org/show_bug.cgi?id=166791
1975
1976         Reviewed by Simon Fraser.
1977
1978         * WebEditingTester/EditingOperations.m:
1979         (editingOperations):
1980         Add the outdent operation to WebEditingTester.
1981
1982 2017-01-06  Said Abou-Hallawa  <sabouhallawa@apple.com>
1983
1984         Create a plan and a patch files for MotionMark and delete the Animometer's ones
1985         https://bugs.webkit.org/show_bug.cgi?id=166785
1986
1987         Reviewed by Ryosuke Niwa.
1988
1989         * Scripts/webkitpy/benchmark_runner/data/patches/MotionMark.patch: Renamed from Tools/Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch.
1990         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark.plan: Renamed from Tools/Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan.
1991
1992 2017-01-06  Antoine Quint  <graouts@apple.com>
1993
1994         Support webkit-test-runner key-value pairs in http tests
1995         https://bugs.webkit.org/show_bug.cgi?id=149812
1996
1997         Reviewed by Alex Christensen.
1998
1999         We pass the absolute path for a test through to WKTR so that we can parse
2000         tests that are running as URLs for webkit-test-runner options.
2001
2002         * DumpRenderTree/DumpRenderTreeCommon.cpp:
2003         (parseInputLine):
2004
2005         Explicitly skip the --absolute-path option in DRT or else we'd crash.
2006
2007         * Scripts/webkitpy/port/driver.py:
2008         (Driver._command_from_driver_input):
2009
2010         Pass the absolute path to the file through the CLI.
2011
2012         * WebKitTestRunner/TestController.cpp:
2013         (WTR::updateTestOptionsFromTestHeader):
2014         (WTR::TestController::testOptionsForTest):
2015         (WTR::parseInputLine):
2016         (WTR::TestController::runTest):
2017         * WebKitTestRunner/TestController.h:
2018
2019 2017-01-06  Tim Horton  <timothy_horton@apple.com>
2020
2021         Warning about unconnectable outlets when opening a MiniBrowser window
2022         https://bugs.webkit.org/show_bug.cgi?id=166756
2023
2024         Reviewed by Dan Bernstein.
2025
2026         * MiniBrowser/mac/BrowserWindow.xib:
2027         When launching MiniBrowser, it says:
2028         Failed to connect (Share) outlet from (WK1BrowserWindowController) to
2029             (MBToolbarItem): missing setter or instance variable
2030         Failed to connect (shareButton) outlet from (WK1BrowserWindowController) to
2031             (NSButtonCell): missing setter or instance variable.
2032
2033         It looks like someone added the connection from the share button
2034         to the BrowserWindowController three times; only one of the connections
2035         is valid. Remove the other two.
2036
2037 2017-01-05  Keith Rollin  <krollin@apple.com>
2038
2039         Add WebCore::URL::protocolHostAndPort
2040         https://bugs.webkit.org/show_bug.cgi?id=166426
2041
2042         Reviewed by Alex Christensen.
2043
2044         Add test for protocolHostAndPort.
2045
2046         * TestWebKitAPI/Tests/WebCore/URL.cpp:
2047         (TestWebKitAPI::TEST_F):
2048
2049 2017-01-05  Per Arne Vollan  <pvollan@apple.com>
2050
2051         [Win] Archive test result is failing.
2052         https://bugs.webkit.org/show_bug.cgi?id=166720
2053
2054         Reviewed by Alex Christensen.
2055
2056         Deleting the layout test result folder is sometimes failing
2057         on Windows. This is not a critical error.
2058
2059         * BuildSlaveSupport/test-result-archive:
2060         (archiveTestResults):
2061
2062 2017-01-04  Tomas Popela  <tpopela@redhat.com>
2063
2064         [GTK] Minibrowser: Add printing support
2065         https://bugs.webkit.org/show_bug.cgi?id=165298
2066
2067         Open a print dialog when the Ctrl + P shortcut is pressed. If there is
2068         an error during the print, it's printed on the console.
2069
2070         Reviewed by Michael Catanzaro.
2071
2072         * MiniBrowser/gtk/BrowserWindow.c:
2073         (webKitPrintOperationFailedCallback):
2074         (printPage):
2075         (browser_window_init):
2076
2077 2017-01-04  Manuel Rego Casasnovas  <rego@igalia.com>
2078
2079         [css-grid] Fix crash clamping grid lines
2080         https://bugs.webkit.org/show_bug.cgi?id=166637
2081
2082         Reviewed by Darin Adler.
2083
2084         Creates new unit test to verify that the maximum tracks limit
2085         is used in GridPosition too.
2086
2087         * TestWebKitAPI/PlatformEfl.cmake:
2088         * TestWebKitAPI/PlatformGTK.cmake:
2089         * TestWebKitAPI/PlatformWin.cmake:
2090         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2091         * TestWebKitAPI/Tests/WebCore/GridPosition.cpp: Added.
2092         (TestWebKitAPI::TEST):
2093
2094 2017-01-04  Wenson Hsieh  <wenson_hsieh@apple.com>
2095
2096         Move editing history scripts to WebCore PrivateHeaders
2097         https://bugs.webkit.org/show_bug.cgi?id=166709
2098         <rdar://problem/29876612>
2099
2100         Reviewed by Dan Bernstein.
2101
2102         Update references to editing script files in WebCore that were moved.
2103
2104         * EditingHistory/EditingHistory.xcodeproj/project.pbxproj:
2105
2106 2017-01-04  Yusuke Suzuki  <utatane.tea@gmail.com>
2107
2108         Unreviewed, build fix after r210313 part 2
2109         https://bugs.webkit.org/show_bug.cgi?id=166676
2110
2111         Add 'U' suffix.
2112
2113         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2114         (TestWebKitAPI::TEST):
2115         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
2116         (TestWebKitAPI::TEST):
2117
2118 2017-01-04  Yusuke Suzuki  <utatane.tea@gmail.com>
2119
2120         Limit thread name appropriately
2121         https://bugs.webkit.org/show_bug.cgi?id=166676
2122
2123         Reviewed by Sam Weinig.
2124
2125         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2126         (TestWebKitAPI::TEST):
2127         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
2128         (TestWebKitAPI::TEST):
2129
2130 2017-01-04  Andy Estes  <aestes@apple.com>
2131
2132         [Cocoa] Teach SharedBuffer to return an NSArray of data segments to avoid flattening
2133         https://bugs.webkit.org/show_bug.cgi?id=166696
2134
2135         Reviewed by Tim Horton.
2136
2137         * TestWebKitAPI/PlatformGTK.cmake:
2138         * TestWebKitAPI/PlatformWin.cmake:
2139         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2140         * TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp: Moved class SharedBufferTest to SharedBufferTest.{cpp,h}.
2141         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.cpp: Moved class SharedBufferTest from SharedBuffer.cpp.
2142         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.h: Ditto.
2143         * TestWebKitAPI/Tests/WebCore/cocoa/SharedBuffer.mm: Added.
2144         (TestWebKitAPI::expectDataArraysEqual): Added a helper to assert that two NSArrays of NSData are equal.
2145         (TestWebKitAPI::TEST_F): Added a test for createNSDataArray.
2146
2147 2017-01-03  Brian Burg  <bburg@apple.com>
2148
2149         Web Inspector: teach the protocol generator about platform-specific types, events, and commands
2150         https://bugs.webkit.org/show_bug.cgi?id=166003
2151         <rdar://problem/28718990>
2152
2153         Reviewed by Joseph Pecoraro.
2154
2155         Teach run-inspector-generator-tests to generate test output using the platform name
2156         derived from the directory that the test is in. For example, tests in the /generic/
2157         subdirectory will pass `--platform generic` to generate-inspector-protocol-bindings.py.
2158
2159         * Scripts/webkitpy/inspector/main.py:
2160         (InspectorGeneratorTests.generate_from_json):
2161         (InspectorGeneratorTests.run_tests):
2162         (InspectorGeneratorTests.main):
2163
2164 2017-01-04  Csaba Osztrogonác  <ossy@webkit.org>
2165
2166         Unreviewed cmake buildfix after r210266.
2167
2168         * DumpRenderTree/PlatformMac.cmake:
2169
2170 2017-01-04  Tim Horton  <timothy_horton@apple.com>
2171
2172         Provide a setting for clients to always prefer low-power WebGL
2173         https://bugs.webkit.org/show_bug.cgi?id=166675
2174         <rdar://problem/29834093>
2175
2176         Reviewed by Dan Bernstein.
2177
2178         * MiniBrowser/mac/Info.plist:
2179         Have MiniBrowser claim to be a modern app that supports
2180         automatic graphics switching. WebKit needs to support automatic
2181         graphics switching, so our test app might as well. Without this
2182         Info.plist parameter, this change has no effect, and bringing up
2183         a WebGL context still brings up the discrete GPU (also true of the
2184         existing web-exposed preferLowPowerToHighPerformance API).
2185
2186 2017-01-03  Yusuke Suzuki  <utatane.tea@gmail.com>
2187
2188         WorkQueueGeneric's platformInvalidate() can deadlock when called on the RunLoop's thread
2189         https://bugs.webkit.org/show_bug.cgi?id=166645
2190
2191         Reviewed by Carlos Garcia Campos.
2192
2193         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
2194         (TestWebKitAPI::TEST):
2195
2196 2017-01-03  Andy Estes  <aestes@apple.com>
2197
2198         Place all the Cocoa WebCore API tests in the same directory
2199         https://bugs.webkit.org/show_bug.cgi?id=166673
2200
2201         Reviewed by Michael Catanzaro.
2202
2203         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2204         * TestWebKitAPI/Tests/WebCore/cocoa/SerializedCryptoKeyWrap.mm: Renamed from Tools/TestWebKitAPI/Tests/WebCore/SerializedCryptoKeyWrap.mm.
2205         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm: Renamed from Tools/TestWebKitAPI/Tests/Cocoa/URLExtras.mm.
2206         * TestWebKitAPI/Tests/WebCore/cocoa/WebCoreNSURLSession.mm: Renamed from Tools/TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm.
2207
2208 2017-01-03  Tim Horton  <timothy_horton@apple.com>
2209
2210         NSSpellChecker's recordResponse isn't called for unseen automatic corrections
2211         https://bugs.webkit.org/show_bug.cgi?id=166450
2212         <rdar://problem/29447824>
2213
2214         Reviewed by Darin Adler.
2215
2216         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2217         * DumpRenderTree/TestRunner.cpp:
2218         (TestRunner::staticFunctions):
2219         * DumpRenderTree/mac/TestRunnerMac.mm:
2220         (setSpellCheckerLoggingEnabledCallback):
2221         * DumpRenderTree/win/TestRunnerWin.cpp:
2222         (setSpellCheckerLoggingEnabledCallback):
2223         * DumpRenderTree/mac/DumpRenderTree.mm:
2224         (resetWebViewToConsistentStateBeforeTesting):
2225         * DumpRenderTree/mac/DumpRenderTreeSpellChecker.h: Added.
2226         * DumpRenderTree/mac/DumpRenderTreeSpellChecker.mm: Added.
2227         (stringForCorrectionResponse):
2228         (drt_NSSpellChecker_recordResponseToCorrection):
2229         (swizzleNSSpellCheckerMethodsIfNeeded):
2230         (setSpellCheckerLoggingEnabled):
2231         Add a new testRunner method, setSpellCheckerLoggingEnabled, which, when
2232         set to true, logs to stdout (which ends up in the test result) whenever
2233         NSSpellChecker recordResponse:toCorrection:forWord:language:inSpellDocumentWithTag:
2234         is called, and then calls the original method. It is reset to false between tests.
2235
2236 2017-01-03  Sam Weinig  <sam@webkit.org>
2237
2238         Make WTF::Expected support Ref template parameters
2239         https://bugs.webkit.org/show_bug.cgi?id=166662
2240
2241         Reviewed by Alex Christensen.
2242
2243         * TestWebKitAPI/Tests/WTF/Expected.cpp:
2244         (TestWebKitAPI::TEST):
2245         Add tests for using Ref with Expected.
2246
2247 2017-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
2248
2249         [GTK] Expose WebKitSecurityOrigin API
2250         https://bugs.webkit.org/show_bug.cgi?id=166632
2251
2252         Reviewed by Carlos Garcia Campos.
2253
2254         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
2255         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSecurityOrigin.cpp: Added.
2256         (testSecurityOriginBasicConstructor):
2257         (testSecurityOriginURIConstructor):
2258         (testSecurityOriginDefaultPort):
2259         (testSecurityOriginFileURI):
2260         (testSecurityOriginDataURI):
2261         (beforeAll):
2262         (afterAll):
2263
2264 2017-01-03  Carlos Garcia Campos  <cgarcia@igalia.com>
2265
2266         [GTK] HTTP auth layout tests are flaky
2267         https://bugs.webkit.org/show_bug.cgi?id=158919
2268
2269         Reviewed by Michael Catanzaro.
2270
2271         * gtk/jhbuild.modules: Update libsoup to version 2.57.1.
2272         * gtk/jhbuildrc: Stop passing --enable-introspection unconditionally to all modules. We don't really need
2273         introspection for the dependencies in the internal build, and it makes newer libsoup build fail because of
2274         missing valac in the bots.
2275
2276 2017-01-03  Carlos Garcia Campos  <cgarcia@igalia.com>
2277
2278         REGRESSION(r173753): [GTK] Source/WebKit is distributed in tarballs
2279         https://bugs.webkit.org/show_bug.cgi?id=165797
2280
2281         Reviewed by Michael Catanzaro.
2282
2283         Move directory ruleset after all exclude rules of Source rulset.
2284
2285         * gtk/manifest.txt.in:
2286
2287 2017-01-02  Yusuke Suzuki  <utatane.tea@gmail.com>
2288
2289         Leverage Substring to create new AtomicStringImpl for StaticStringImpl and SymbolImpl
2290         https://bugs.webkit.org/show_bug.cgi?id=166636
2291
2292         Reviewed by Darin Adler.
2293
2294         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
2295         (TestWebKitAPI::TEST):
2296
2297 2017-01-02  Manuel Rego Casasnovas  <rego@igalia.com>
2298
2299         [GTK] WebCore/CSSParser unit test is not being built
2300         https://bugs.webkit.org/show_bug.cgi?id=166492
2301
2302         Reviewed by Michael Catanzaro.
2303
2304         This test was introduced in r175930, but we were not building
2305         it on GTK+ port since r176015.
2306         This patch marks the test to be built again on GTK+.
2307         JFTR, the test is passing right now.
2308
2309         * TestWebKitAPI/PlatformGTK.cmake: Add CSSParser.cpp test file and use
2310         ADD_WHOLE_ARCHIVE_TO_LIBRARIES to avoid linking errors.
2311
2312 2017-01-02  Chris Fleizach  <cfleizach@apple.com>
2313
2314         AX: Expose block quote level to iOS API
2315         https://bugs.webkit.org/show_bug.cgi?id=166629
2316         <rdar://problem/29834793>
2317
2318         Reviewed by Darin Adler.
2319
2320         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2321         (AccessibilityUIElement::numberAttributeValue):
2322         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2323         (WTR::AccessibilityUIElement::numberAttributeValue):
2324
2325 2016-12-31  Michael Catanzaro  <mcatanzaro@igalia.com>
2326
2327         SecurityOrigin::create triplet constructor does not canonicalize port
2328         https://bugs.webkit.org/show_bug.cgi?id=166624
2329
2330         Reviewed by Daniel Bates.
2331
2332         * TestWebKitAPI/PlatformGTK.cmake:
2333         * TestWebKitAPI/PlatformWin.cmake:
2334         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2335         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp: Added.
2336         (TestWebKitAPI::SecurityOriginTest::SetUp):
2337         (TestWebKitAPI::TEST_F):
2338
2339 2016-12-30  Michael Catanzaro  <mcatanzaro@igalia.com>
2340
2341         [GTK] Improve user agent construction
2342         https://bugs.webkit.org/show_bug.cgi?id=142074
2343
2344         Reviewed by Carlos Garcia Campos.
2345
2346         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
2347         (TestWebKitAPI::assertUserAgentForURLHasChromeBrowserQuirk):
2348         (TestWebKitAPI::assertUserAgentForURLHasFirefoxBrowserQuirk):
2349         (TestWebKitAPI::assertUserAgentForURLHasLinuxPlatformQuirk):
2350         (TestWebKitAPI::assertUserAgentForURLHasMacPlatformQuirk):
2351         (TestWebKitAPI::TEST):
2352
2353 2016-12-27  Michael Catanzaro  <mcatanzaro@igalia.com>
2354
2355         [GTK] Improve user agent construction
2356         https://bugs.webkit.org/show_bug.cgi?id=142074
2357
2358         Reviewed by Carlos Garcia Campos.
2359
2360         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
2361         (TestWebKitAPI::TEST):
2362
2363 2016-12-23  Simon Fraser  <simon.fraser@apple.com>
2364
2365         REGRESSION (r209299): Selection is broken when you zoom in webpage using trackpad
2366         https://bugs.webkit.org/show_bug.cgi?id=166472
2367         rdar://problem/29675551
2368
2369         Reviewed by Tim Horton.
2370
2371         These changes are necessary to allow the mouse to leave the WTR window while
2372         drag-scrolling, to test autoscroll. Previously, we were never calling -mouseDragged
2373         (which DRT does); we'd always go through mouseMoved, which hits an early return
2374         in WebViewImpl::mouseMoved() when the point is outside the view.
2375
2376         * WebKitTestRunner/mac/EventSenderProxy.mm:
2377         (WTR::EventSenderProxy::mouseMoveTo):
2378
2379 2016-12-23  Andy Estes  <aestes@apple.com>
2380
2381         [iOS] Fix some crashing webarchive tests
2382         https://bugs.webkit.org/show_bug.cgi?id=166470
2383
2384         Reviewed by Andreas Kling.
2385
2386         Tests that use TestRunner.dumpDOMAsWebArchive() crashed on iOS due to a stub implementation
2387         of WebArchiveDumpSupport in WebKitTestRunner. The Mac implementation works fine on iOS too,
2388         so this change uses that on both platforms.
2389
2390         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig: Removed
2391         WebArchiveDumpSupportMac.mm from EXCLUDED_SOURCE_FILE_NAMES.
2392         * WebKitTestRunner/InjectedBundle/cocoa/WebArchiveDumpSupportCocoa.mm: Renamed from
2393         Tools/WebKitTestRunner/mac/WebArchiveDumpSupportMac.mm.
2394         * WebKitTestRunner/PlatformMac.cmake:
2395         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2396         * WebKitTestRunner/ios/WebArchiveDumpSupportIOS.mm: Removed.
2397
2398 2016-12-22  Saam Barati  <sbarati@apple.com>
2399
2400         WebAssembly: Silence the output of the spec-tests
2401         https://bugs.webkit.org/show_bug.cgi?id=166417
2402
2403         Reviewed by Mark Lam.
2404
2405         * Scripts/run-jsc-stress-tests:
2406
2407 2016-12-22  Zhuo Li  <zachli@apple.com>
2408
2409         [Cocoa] SPI for setloadsImagesAutomatically.
2410         https://bugs.webkit.org/show_bug.cgi?id=166401.
2411
2412         Reviewed by Darin Adler.
2413
2414         * TestWebKitAPI/Tests/WebKit2Cocoa/Preferences.mm:
2415         (TEST): Test the _setLoadsImagesAutomatically SPI. By default,
2416         _loadsImagesAutomatically returns YES.
2417
2418 2016-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
2419
2420         fast/events/ios/viewport-shrink-to-fit-allows-double-tap.html is flaky/order dependent
2421         https://bugs.webkit.org/show_bug.cgi?id=161328
2422         <rdar://problem/28475977>
2423
2424         Reviewed by Darin Adler.
2425
2426         Running a test that scales the viewport and listens to a didEndZooming callback (such as
2427         viewport-shrink-to-fit-allows-double-tap.html) immediately after a test that may begin to trigger viewport
2428         scaling as the test completes (such as viewport-device-width-at-initial-scale-fast-clicks.html) may result in
2429         the didEndZooming callback of the latter test being fired early due to the previous test triggering a zoom
2430         animation. Ideally, -[WKScrollView _stopScrollingAndZoomingAnimations], which is called when committing the page
2431         load, should prevent this from happening, but from reading documentation and code inspection, this is not
2432         intended to fire any associated delegate methods or notifications of the UIScrollView, instead deferring them
2433         for later. Instead, what we need in this case is to clear out any started but not yet completed animations after
2434         we finish running a test and before we load the next test.
2435
2436         One way to do this is to remove all animations from the WKScrollView's layer, and the layers of its children,
2437         recursively. Doing so causes scrollViewDidEndZooming:withView:atScale: to fire at the end of the runloop if the
2438         previous test started zooming and then finished before zooming completed. Since this happens before the next
2439         test has a chance to run UI-side scripts, we won't end up firing this callback prematurely during the next test.
2440
2441         * WebKitTestRunner/ios/TestControllerIOS.mm:
2442         (WTR::TestController::platformResetStateToConsistentValues):
2443
2444 2016-12-22  Jer Noble  <jer.noble@apple.com>
2445
2446         Muted media element playback should not interrupt other audio playback
2447         https://bugs.webkit.org/show_bug.cgi?id=166347
2448
2449         Reviewed by Eric Carlson.
2450
2451         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2452         * TestWebKitAPI/Tests/WebKit/ios/AudioSessionCategoryIOS.mm:
2453         (TestWebKitAPI::TEST):
2454         * TestWebKitAPI/Tests/WebKit/ios/video-with-muted-audio.html: Added.
2455
2456 2016-12-22  Alejandro G. Castro  <alex@igalia.com>
2457
2458         [WebRTC] Add support for runtime PeeConnection setting, required after r209757
2459         https://bugs.webkit.org/show_bug.cgi?id=166346
2460
2461         Reviewed by Carlos Garcia Campos.
2462
2463         Enable WebRTC by default to simplify testing.
2464
2465         * MiniBrowser/gtk/main.c:
2466         (main):
2467
2468 2016-12-21  Alexey Proskuryakov  <ap@apple.com>
2469
2470         REGRESSION: API test failure: WKWebView.LocalStorageClear
2471         https://bugs.webkit.org/show_bug.cgi?id=166032
2472         <rdar://problem/29758423>
2473
2474         Reviewed by Simon Fraser.
2475
2476         Add an @autoreleasepool around the code that allocates then clears the WKWebView, 
2477         to ensure that the view is destroyed before the callback fires.
2478
2479         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
2480         (TEST):
2481
2482 2016-12-21  Saam Barati  <sbarati@apple.com>
2483
2484         WebAssembly: Import spec tests
2485         https://bugs.webkit.org/show_bug.cgi?id=166395
2486
2487         Rubber stamped by Keith Miller.
2488
2489         * Scripts/run-jsc-stress-tests:
2490
2491 2016-12-21  Alexey Proskuryakov  <ap@apple.com>
2492
2493         REGRESSION: API test failure: _WKDownload.OriginatingWebView
2494         https://bugs.webkit.org/show_bug.cgi?id=166033
2495         <rdar://problem/29758428>
2496
2497         Reviewed by Simon Fraser.
2498
2499         Add an @autoreleasepool around the code that allocates the WKWebView, 
2500         so that it can be destroyed by removing the last reference in _downloadDidStart.
2501
2502         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2503         (TEST):
2504
2505 2016-12-21  Daniel Bates  <dabates@apple.com>
2506
2507         WebKitTestRunner: Add comment to TestRunner::setCanOpenWindows()
2508         https://bugs.webkit.org/show_bug.cgi?id=166356
2509
2510         Add comment in TestRunner::setCanOpenWindows() to elaborate further on its purpose
2511         as a means to allow a test to explicit allow an embedding client to open a new windows
2512         such that the default behavior is for the embedding client to forbid such an action.
2513         The test plugins/get-url-with-blank-target.html assumes this default behavior though
2514         it is currently skipped on WebKit2 because questions were raised in the patch for
2515         <https://bugs.webkit.org/show_bug.cgi?id=43389> about its correctness and usefulness.
2516         We will need to implement TestRunner::setCanOpenWindows() should we decide to unskip
2517         this test.
2518
2519         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2520         (WTR::TestRunner::setCanOpenWindows):
2521
2522 2016-12-20  Simon Fraser  <simon.fraser@apple.com>
2523
2524         REGRESSION: API test failure: WKWebView.EvaluateJavaScriptBlockCrash
2525         https://bugs.webkit.org/show_bug.cgi?id=166031
2526
2527         Reviewed by Tim Horton.
2528         
2529         Add an @autoreleasepool around the code that allocates then clears the WKWebView, 
2530         to ensure that the view is destroyed before the callback fires.
2531
2532         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewEvaluateJavaScript.mm:
2533
2534 2016-12-20  Megan Gardner  <megan_gardner@apple.com>
2535
2536         Throw Exception when test doesn't clean up HID Events properly
2537         https://bugs.webkit.org/show_bug.cgi?id=166271
2538
2539         Reviewed by Simon Fraser.
2540
2541         Add in a check when UIScriptController is deleted to make sure that the HID event
2542         callback dictionary is empty. If it is not, and a HID event is hit, this will cause
2543         the program to crash without any good information. Crashes are race-y, and will still
2544         happen with malformed test, but the information will be much more helpful. 
2545
2546         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2547         (WTR::UIScriptController::checkForClean):
2548         * TestRunnerShared/UIScriptContext/UIScriptContext.cpp:
2549         (UIScriptContext::~UIScriptContext):
2550         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2551         (WTR::UIScriptController::checkForClean):
2552         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2553         * WebKitTestRunner/ios/HIDEventGenerator.h:
2554         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2555         (-[HIDEventGenerator checkHIDCallbacksClear]):
2556         * WebKitTestRunner/ios/TestControllerIOS.mm:
2557         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2558         (WTR::UIScriptController::checkForClean):
2559
2560 2016-12-20  Andy Estes  <aestes@apple.com>
2561
2562         [Cocoa] REGRESSION (r209558): Calling decisionHandler multiple times in webView:decidePolicyForNavigationAction:decisionHandler: leads to a crash
2563         https://bugs.webkit.org/show_bug.cgi?id=165992
2564
2565         Reviewed by Brady Eidson.
2566
2567         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2568         * TestWebKitAPI/Tests/WebKit2Cocoa/DuplicateCompletionHandlerCalls.mm: Added.
2569         (expectException):
2570         (-[DuplicateCompletionHandlerCallsDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2571         (-[DuplicateCompletionHandlerCallsDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
2572         (-[DuplicateCompletionHandlerCallsDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
2573         (-[DuplicateCompletionHandlerCallsDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
2574         (-[DuplicateCompletionHandlerCallsDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:completionHandler:]):
2575         (-[DuplicateCompletionHandlerCallsDelegate _webView:decideDatabaseQuotaForSecurityOrigin:currentQuota:currentOriginUsage:currentDatabaseUsage:expectedUsage:decisionHandler:]):
2576         (-[DuplicateCompletionHandlerCallsDelegate _webView:willSubmitFormValues:userObject:submissionHandler:]):
2577         (TEST):
2578         * TestWebKitAPI/Tests/WebKit2Cocoa/duplicate-completion-handler-calls.html: Added.
2579
2580 2016-12-20  Dean Jackson  <dino@apple.com>
2581
2582         Remove INDIE_UI
2583         https://bugs.webkit.org/show_bug.cgi?id=165881
2584         <rdar://problem/29672532>
2585
2586         Reviewed by Simon Fraser.
2587
2588         The Indie UI work has been discontinued.
2589
2590         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2591
2592 2016-12-19  Yusuke Suzuki  <utatane.tea@gmail.com>
2593
2594         [ES6] Enable ES6 Modules
2595         https://bugs.webkit.org/show_bug.cgi?id=165849
2596
2597         Reviewed by Geoffrey Garen.
2598
2599         * DumpRenderTree/mac/DumpRenderTree.mm:
2600         (resetWebPreferencesToConsistentValues):
2601         * DumpRenderTree/win/DumpRenderTree.cpp:
2602         (resetWebPreferencesToConsistentValues):
2603         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2604         (WTR::InjectedBundle::beginTesting):
2605         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2606         (WTR::TestRunner::setES6ModulesEnabled): Deleted.
2607         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2608
2609 2016-12-19  Ryan Haddad  <ryanhaddad@apple.com>
2610
2611         Repurpose bots and clean up dashboard.
2612         https://bugs.webkit.org/show_bug.cgi?id=166045
2613
2614         Reviewed by Lucas Forschler.
2615
2616         * BuildSlaveSupport/build.webkit.org-config/config.json:
2617         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
2618         (BubbleQueueServer):
2619         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
2620         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2621         (WebKitBuildbot):
2622         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2623         (table.queue-grid tr.platform.mac-os-x-yosemite img.logo): Deleted.
2624
2625 2016-12-19  Michael Catanzaro  <mcatanzaro@igalia.com>
2626
2627         [CMake] TestWebKitAPIBase links to itself
2628         https://bugs.webkit.org/show_bug.cgi?id=165985
2629
2630         Reviewed by Alex Christensen.
2631
2632         Fix CMake warning about a target linking to itself, which makes no sense.
2633
2634         * TestWebKitAPI/CMakeLists.txt:
2635
2636 2016-12-19  Michael Catanzaro  <mcatanzaro@igalia.com>
2637
2638         [GTK] GtkDoc build should be quieter
2639         https://bugs.webkit.org/show_bug.cgi?id=165994
2640
2641         Reviewed by Carlos Garcia Campos.
2642
2643         Make it not print by default.
2644
2645         * gtk/generate-gtkdoc:
2646         (get_generator_for_config):
2647         (generate_doc):
2648         * gtk/gtkdoc.py:
2649         (GTKDoc._run_command):
2650         (GTKDoc._copy_doc_files_to_output_dir):
2651
2652 2016-12-18  Simon Fraser  <simon.fraser@apple.com>
2653
2654         Expose a way for MiniBrowser to simulate header and footer banners
2655         https://bugs.webkit.org/show_bug.cgi?id=166005
2656
2657         Reviewed by Wenson Hsieh.
2658         
2659         Add a MiniBrowser menu item and setting to toggle adding space for header and footer
2660         banners. This only works in WebKit2.
2661         
2662         We need to reset these on each navigation, since newly created FrameViews
2663         don't re-fetch the header and footer height stored on Page.
2664         
2665         Also fix the signature of webView:didFinishNavigation: to follow API changes,
2666         as well as fixing webViewWebContentProcessDidTerminate:
2667
2668         * MiniBrowser/mac/SettingsController.h:
2669         * MiniBrowser/mac/SettingsController.m:
2670         (-[SettingsController _populateMenu]):
2671         (-[SettingsController validateMenuItem:]):
2672         (-[SettingsController toggleReserveSpaceForBanners:]):
2673         (-[SettingsController isSpaceReservedForBanners]):
2674         * MiniBrowser/mac/WK2BrowserWindowController.m:
2675         (-[WK2BrowserWindowController didChangeSettings]):
2676         (-[WK2BrowserWindowController webView:didFinishNavigation:]):
2677         (-[WK2BrowserWindowController webViewWebContentProcessDidTerminate:]):
2678         (-[WK2BrowserWindowController webView:didFinishLoadingNavigation:]): Deleted.
2679         (-[WK2BrowserWindowController _webViewWebProcessDidCrash:]): Deleted.
2680
2681 2016-12-17  Simon Fraser  <simon.fraser@apple.com>
2682
2683         Fix iOS test results after r209967.
2684         
2685         Subtracting out the status bar height was erroneously happening for all tests,
2686         not just for flexible viewport tests.
2687         
2688         Fix by plumbing WebViewSizingMode through resizeTo() and setWindowFrame().
2689
2690         * WebKitTestRunner/PlatformWebView.h:
2691         * WebKitTestRunner/TestController.cpp:
2692         (WTR::TestController::resetStateToConsistentValues):
2693         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2694         (WTR::PlatformWebView::resizeTo):
2695         (WTR::PlatformWebView::setWindowFrame):
2696         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
2697         (WTR::PlatformWebView::resizeTo):
2698         (WTR::PlatformWebView::setWindowFrame):
2699         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2700         (WTR::PlatformWebView::resizeTo):
2701         (WTR::PlatformWebView::setWindowFrame):
2702         * WebKitTestRunner/ios/TestControllerIOS.mm:
2703         (WTR::TestController::platformConfigureViewForTest):
2704         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2705         (WTR::PlatformWebView::resizeTo):
2706         (WTR::PlatformWebView::setWindowFrame):
2707
2708 2016-12-17  Joonghun Park  <jh718.park@samsung.com>
2709
2710         [EFL] bump EFL version to 1.18.4
2711         https://bugs.webkit.org/show_bug.cgi?id=166004
2712
2713         Reviewed by Gyuyoung Kim.
2714
2715         * efl/jhbuild.modules: Use efl-1.18.4 instead of 1.18.1.
2716
2717 2016-12-17  Wenson Hsieh  <wenson_hsieh@apple.com>
2718
2719         Visual viewports: bottom fixed elements disappear behind the keyboard
2720         https://bugs.webkit.org/show_bug.cgi?id=165983
2721         <rdar://problem/29409852>
2722
2723         Reviewed by Simon Fraser.
2724
2725         Add support for UIScriptController.inputViewBounds, which UI-side scripts may use to fetch the bounding rect of
2726         the keyboard when it is up.
2727
2728         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2729         (WTR::UIScriptController::inputViewBounds):
2730         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2731         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2732         (WTR::UIScriptController::inputViewBounds):
2733         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2734         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2735         (WTR::viewRectForWindowRect):
2736
2737         Previously, we accounted for the status bar height by translating the entire web view down by the height of the
2738         status bar. However, we did not shrink the height of the web view itself, which means that for tests which
2739         involve scrolling past the end of the document, the bottom strip of the web view is out of bounds of the window.
2740
2741         (WTR::PlatformWebView::PlatformWebView):
2742         (WTR::PlatformWebView::setWindowFrame):
2743         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2744         (WTR::UIScriptController::inputViewBounds):
2745
2746 2016-12-16  Ryosuke Niwa  <rniwa@webkit.org>
2747
2748         Deleting a character converted from pinyin after an image causes a Safari crash
2749         https://bugs.webkit.org/show_bug.cgi?id=165839
2750         <rdar://problem/27951933>
2751
2752         Reviewed by Wenson Hsieh.
2753
2754         Add a WebKit API test to call attributedSubstringForProposedRange on a WKWebView
2755         while the proposed range contains an image. This should not cause a WebProcess to crash
2756         or send an invalid message to the UIProcess.
2757
2758         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2759         * TestWebKitAPI/Tests/WebKit2/chinese-character-with-image.html: Added.
2760         * TestWebKitAPI/Tests/WebKit2/mac/AttributedSubstringForProposedRangeWithImage.mm: Added.
2761         (TestWebKitAPI::didFinishLoadForFrame):
2762         (TestWebKitAPI::processDidCrash):
2763         (TestWebKitAPI::invalidMessageFunction):
2764         (TestWebKitAPI::WebKit2.AttributedSubstringForProposedRangeWithImage):
2765
2766 2016-12-16  Wenson Hsieh  <wenson_hsieh@apple.com>
2767
2768         Visual viewports: carets and selection UI are incorrectly positioned when editing fixed elements
2769         https://bugs.webkit.org/show_bug.cgi?id=165767
2770         <rdar://problem/29602382>
2771
2772         Reviewed by Simon Fraser.
2773
2774         Introduces two new UIScriptController methods: doAfterWebPageIsInStableState and textSelectionCaretRect. See
2775         WebKit2 ChangeLog for more details.
2776
2777         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2778         (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
2779         (WTR::UIScriptController::textSelectionCaretRect):
2780         * DumpRenderTree/mac/UIScriptControllerMac.mm:
2781         (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
2782         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2783         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2784         (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
2785         (WTR::UIScriptController::textSelectionCaretRect):
2786         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2787         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2788         (-[TestRunnerWKWebView _setStableStateOverride:]):
2789
2790         Force the WKWebView to update its visible content rects when changing the stable state override.
2791
2792         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2793         (WTR::toNSDictionary):
2794         (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
2795         (WTR::UIScriptController::selectionRangeViewRects):
2796         (WTR::UIScriptController::textSelectionCaretRect):
2797         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
2798         (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
2799
2800 2016-12-15  Brent Fulgham  <bfulgham@apple.com>
2801
2802         Arguments called in wrong order
2803         https://bugs.webkit.org/show_bug.cgi?id=165923
2804
2805         Reviewed by Simon Fraser.
2806
2807         The 'audioDeviceUIDs' array is being passed to the argument that expects video devices,
2808         and the 'videoDeviceUIDs' array is being passed to the audo device argument. Fix this.
2809
2810         * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp:
2811         (TestWebKitAPI::decidePolicyForUserMediaPermissionRequestCallBack): The
2812         order of arguments to WKUserMediaPermissionRequestAllow are flipped.
2813
2814 2016-12-16  Hunseop Jeong  <hs85.jeong@samsung.com>
2815
2816         [EFL] Disable non-srcdir builds for failing libraries
2817         https://bugs.webkit.org/show_bug.cgi?id=165896
2818
2819         Reviewed by Gyuyoung Kim.
2820
2821         * efl/jhbuild.modules: Set non srcdir builds to no
2822
2823 2016-12-15  Daniel Bates  <dabates@apple.com>
2824
2825         check-style should not complain about code in icu directories
2826         https://bugs.webkit.org/show_bug.cgi?id=53929
2827
2828         Reviewed by Darin Adler.
2829
2830         Skip style checking of imported ICU headers to avoid a deluge of style issues
2831         as they do not conform to the WebKit Code Style guideline. We want to preserve
2832         the formatting of these headers so as to make it straightforward to merge
2833         changes to them, if necessary.
2834
2835         * Scripts/webkitpy/style/checker.py:
2836
2837 2016-12-15  Alexey Proskuryakov  <ap@apple.com>
2838
2839         Move JSC testers from Yosemite to Sierra
2840         https://bugs.webkit.org/show_bug.cgi?id=165925
2841
2842         Reviewed by Lucas Forschler.
2843
2844         * BuildSlaveSupport/build.webkit.org-config/config.json:
2845         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2846         (WebKitBuildbot):
2847
2848 2016-12-15  Megan Gardner  <megan_gardner@apple.com>
2849
2850         Add coordinate space to event streams and streamline tests
2851         https://bugs.webkit.org/show_bug.cgi?id=165119
2852
2853         Reviewed by Simon Fraser.
2854
2855         Update event streams to allow for both content and global coordinate space.
2856         Update example script to more accurately show all the available options.
2857
2858         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2859         * WebKitTestRunner/ios/HIDEventGenerator.h:
2860         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2861         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2862         (WTR::convertCoordinates):
2863         (WTR::UIScriptController::sendEventStream):
2864
2865 2016-12-15  Claudio Saavedra  <csaavedra@igalia.com>
2866
2867         [GTK] Ensure gst* docs are not built with update-webkitgtk-libs
2868         https://bugs.webkit.org/show_bug.cgi?id=165855
2869
2870         Reviewed by Philippe Normand.
2871
2872         GStreamer's autogen.sh enables gtk-doc always so we end up building
2873         docs even if we disable them. Use the configure script instead, since
2874         we build from packages and these include it already.
2875
2876         * gtk/jhbuild.modules: Use shipped configure instead of autogen.sh for
2877         upstream gstreamer packages.
2878
2879 2016-12-15  Alex Christensen  <achristensen@webkit.org>
2880
2881         REGRESSION (r208902) Null pointer dereference in wkIsPublicSuffix
2882         https://bugs.webkit.org/show_bug.cgi?id=165885
2883         <rdar://problem/29476917>
2884
2885         Reviewed by Darin Adler.
2886
2887         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2888         (TestWebKitAPI::utf16String): Deleted.
2889         * TestWebKitAPI/Tests/mac/PublicSuffix.mm:
2890         (TestWebKitAPI::TEST_F):
2891         * TestWebKitAPI/WTFStringUtilities.h:
2892         (utf16String):
2893         Moved from URLParser to share with other tests.
2894
2895 2016-12-14  Ryosuke Niwa  <rniwa@webkit.org>
2896
2897         iOS: An element with tabindex is not focusable unless there is no mouse event handler
2898         https://bugs.webkit.org/show_bug.cgi?id=165843
2899
2900         Reviewed by Antti Koivisto.
2901
2902         Add testRunner.isWebKit2 which is always true in WebKitTestRunner.
2903         Without this, it's really hard to reliably differentiate DumpRenderTree and WebKitTestRunner,
2904         and DumpRenderTree's runUIScript would hit an assertion :(
2905
2906         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2907         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2908         (WTR::TestRunner::isWebKit2):
2909
2910 2016-12-14  Brady Eidson  <beidson@apple.com>
2911
2912         IndexedDB 2.0: Massively speedup IDBIndex.get().
2913         https://bugs.webkit.org/show_bug.cgi?id=165802
2914
2915         Reviewed by Alex Christensen.
2916
2917         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2918         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBIndexUpgradeToV2.html: Added.
2919         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBIndexUpgradeToV2.mm: Added.
2920         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexUpgrade.blob: Added.
2921         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexUpgrade.sqlite3: Added.
2922
2923 2016-12-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2924
2925         [GTK][EFL] Update the JHBuild version.
2926         https://bugs.webkit.org/show_bug.cgi?id=165838
2927
2928         Reviewed by Michael Catanzaro.
2929
2930         * jhbuild/jhbuild-wrapper: This new version fixes a bug with the
2931         usage of the JHBUILD_MIRROR feature with git repositories.
2932
2933 2016-12-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2934
2935         [GTK] Yasm is needed for building the JHBuild after r208940
2936         https://bugs.webkit.org/show_bug.cgi?id=165837
2937
2938         Reviewed by Alejandro G. Castro.
2939
2940         * gtk/install-dependencies: Yasm is needed for building libvpx.
2941
2942 2016-12-14  Youenn Fablet  <youenn@apple.com>
2943
2944         Test infrastructure should allow to filter out text output before doing a comparison with the baseline
2945         https://bugs.webkit.org/show_bug.cgi?id=161310
2946
2947         Reviewed by Ryosuke Niwa.
2948
2949         Adding --dump-jsconsolelog-in-stderr test option for DRT and WTR.
2950         When set, WTR and DRT output JS console log in the stderr and not the test output.
2951         This allows removing potentially flaky information while still being able to read it for investigation.
2952
2953         Updated webkitpy infrastructure to use this test option in case of DumpJSConsoleLogInStdErr modifier.
2954
2955         Changes are covered by updating a fetch test to output console log and set its option to --dump-jsconsolelog-in-stderr in TestExpectations.
2956         This test should have this option when fetch API will start logging resource loader errors.
2957
2958         * DumpRenderTree/DumpRenderTree.h:
2959         (TestCommand::TestCommand): Deleted.
2960         * DumpRenderTree/DumpRenderTreeCommon.cpp:
2961         (parseInputLine):
2962         * DumpRenderTree/TestRunner.h:
2963         (TestRunner::setDumpJSConsoleLogInStdErr):
2964         (TestRunner::dumpJSConsoleLogInStdErr):
2965         * DumpRenderTree/mac/DumpRenderTree.mm:
2966         (runTest):
2967         * DumpRenderTree/mac/UIDelegate.mm:
2968         (-[UIDelegate webView:addMessageToConsole:withSource:]):
2969         * DumpRenderTree/win/DumpRenderTree.cpp:
2970         (runTest):
2971         * DumpRenderTree/win/UIDelegate.cpp:
2972         (UIDelegate::webViewAddMessageToConsole):
2973         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2974         (TestExpectationParser._tokenize_line):
2975         * Scripts/webkitpy/port/driver.py:
2976         (Driver._command_from_driver_input):
2977         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2978         (WTR::InjectedBundle::didReceiveMessageToPage):
2979         (WTR::InjectedBundle::dumpToStdErr):
2980         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2981         (WTR::InjectedBundle::dumpJSConsoleLogInStdErr):
2982         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2983         (WTR::InjectedBundlePage::willAddMessageToConsole):
2984         * WebKitTestRunner/TestController.cpp:
2985         (WTR::parseInputLine):
2986         (WTR::TestController::runTest):
2987         (WTR::TestCommand::TestCommand): Deleted.
2988         * WebKitTestRunner/TestInvocation.cpp:
2989         (WTR::TestInvocation::invoke):
2990         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2991         * WebKitTestRunner/TestInvocation.h:
2992         (WTR::TestInvocation::setDumpJSConsoleLogInStdErr):
2993
2994
2995 2016-12-14  Enrique Ocaña González  <eocanha@igalia.com>
2996
2997         REGRESSION(r207879-207891): [GStreamer] Introduced many layout test failures and crashes, bots exiting early
2998         https://bugs.webkit.org/show_bug.cgi?id=164022
2999
3000         Reviewed by Xabier Rodriguez-Calvar.
3001
3002         * Scripts/webkitperl/FeatureList.pm:
3003           Re-enable MEDIA_SOURCE for the GTK+ port.
3004
3005 2016-12-13  Alex Christensen  <achristensen@webkit.org>
3006
3007         Fix CMake build.
3008
3009         * DumpRenderTree/PlatformMac.cmake:
3010         Define NS_RETURNS_RETAINED as nothing for now.
3011
3012 2016-12-13  Jer Noble  <jer.noble@apple.com>
3013
3014         Fullscreen in WebKit2 does not restore topContentInset upon exiting; leaves top of page not visible
3015         https://bugs.webkit.org/show_bug.cgi?id=165697
3016
3017         Reviewed by Tim Horton.
3018
3019         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenTopContentInset.mm:
3020         (TestWebKitAPI::TEST):
3021
3022 2016-12-13  Andy Estes  <aestes@apple.com>
3023
3024         [Cocoa] Implement -shouldInsertText: on WKWebProcessPlugInEditingDelegate
3025         https://bugs.webkit.org/show_bug.cgi?id=165785
3026         <rdar://problem/26929398>
3027
3028         Reviewed by Darin Adler.
3029
3030         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegate.mm:
3031         (-[BundleEditingDelegateRemoteObject shouldInsertText:replacingRange:givenAction:]): Added
3032         expectations for the text, range, and action.
3033         (TEST): Set the "EditingDelegateShouldInsertText" bundle parameter to NO so that the plug-in
3034         will return NO in -_webProcessPlugInBrowserContextController:willInsertText:. Added a
3035         plain-text string to the pasteboard, executed a paste action, and verified that the selected
3036         text in the web view did not change.
3037         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegatePlugIn.mm:
3038         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]): Set
3039         _editingDelegateShouldInsertText according to the "EditingDelegateShouldInsertText" bundle
3040         parameter.
3041         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:shouldInsertText:replacingRange:givenAction:]):
3042         Added. Called -shouldInsertText:replacingRange:givenAction: on the remote object proxy
3043         and returned the value of _editingDelegateShouldInsertText.
3044         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegateProtocol.h: Declared
3045         -shouldInsertText:replacingRange:givenAction:.
3046
3047 2016-12-13  Chris Dumez  <cdumez@apple.com>
3048
3049         Unreviewed, rolling out r209544.
3050
3051         Looks like r209489 did not cause the performance regression
3052         after all
3053
3054         Reverted changeset:
3055
3056         "Unreviewed, rolling out r209489."
3057         https://bugs.webkit.org/show_bug.cgi?id=165550
3058         http://trac.webkit.org/changeset/209544
3059
3060 2016-12-12  Sam Weinig  <sam@webkit.org>
3061
3062         [WebIDL] Remove use of Dictionary in ApplePaySession
3063         https://bugs.webkit.org/show_bug.cgi?id=165787
3064
3065         Reviewed by Anders Carlsson.
3066
3067         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3068         (WTR::initializeWebViewConfiguration):
3069         (WTR::TestController::platformCreateWebView):
3070         Enable ApplePay for the tests (where supported).
3071
3072 2016-12-13  Eric Carlson  <eric.carlson@apple.com>
3073
3074         Annotate MediaStream and WebRTC idl with EnabledAtRuntime flag
3075         https://bugs.webkit.org/show_bug.cgi?id=165251
3076
3077         Reviewed by Youenn Fablet.
3078
3079         * TestWebKitAPI/Tests/WebKit2/EnumerateMediaDevices.cpp:
3080         (TestWebKitAPI::TEST): Enable MediaStream, create web view from the page group upon which
3081         the preferences have been set.
3082
3083 2016-12-08  Antti Koivisto  <antti@apple.com>
3084
3085         Enable network cache speculative revalidation in MiniBrowser
3086         https://bugs.webkit.org/show_bug.cgi?id=165616
3087
3088         Reviewed by Darin Adler.
3089
3090         Match Safari. Also add a menu item to disable it.
3091
3092         * MiniBrowser/mac/AppDelegate.m:
3093         (defaultConfiguration):
3094         * MiniBrowser/mac/SettingsController.h:
3095         * MiniBrowser/mac/SettingsController.m:
3096         (-[SettingsController _populateMenu]):
3097         (-[SettingsController validateMenuItem:]):
3098         (-[SettingsController networkCacheSpeculativeRevalidationDisabled]):
3099         (-[SettingsController toggleNetworkCacheSpeculativeRevalidationDisabled:]):
3100
3101 2016-12-12  Alexey Proskuryakov  <ap@apple.com>
3102
3103         ChangeLogs become readonly after resolving a conflict
3104         https://bugs.webkit.org/show_bug.cgi?id=165440
3105         rdar://problem/29491002
3106
3107         Reviewed by Darin Adler.
3108
3109         * Scripts/resolve-ChangeLogs: (resolveChangeLog): Set correct permissions when
3110         moving the file.
3111
3112 2016-12-12  Filip Pizlo  <fpizlo@apple.com>
3113
3114         Re-enable collectContinuously since it doesn't crash anymore
3115
3116         Rubber stamped by Michael Saboff.
3117
3118         * Scripts/run-jsc-stress-tests:
3119
3120 2016-12-11  Konstantin Tokarev  <annulen@yandex.ru>
3121
3122         Unreviewed attempt to fix EFL and Mac/cmake builds after r209665.
3123         https://bugs.webkit.org/show_bug.cgi?id=165686
3124
3125         * DumpRenderTree/CMakeLists.txt: WebKit2 should precede other target
3126         so that right config.h comes first in include path.
3127
3128 2016-12-11  Dave Hyatt  <hyatt@apple.com>
3129
3130         [CSS Parser] Make sure content extensions initialize AtomicString
3131         https://bugs.webkit.org/show_bug.cgi?id=165737
3132
3133         Reviewed by Darin Adler.
3134
3135         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3136         (TestWebKitAPI::makeBackend):
3137
3138 2016-12-08  Dave Hyatt  <hyatt@apple.com>
3139
3140         [CSS Parser] Remove the old CSS Parser
3141         https://bugs.webkit.org/show_bug.cgi?id=165645
3142
3143         Reviewed by Daniel Bates.
3144
3145         * TestWebKitAPI/Tests/WebCore/CSSParser.cpp:
3146         (TestWebKitAPI::TEST):
3147
3148 2016-12-10  Konstantin Tokarev  <annulen@yandex.ru>
3149
3150         [cmake] Include WTF, JSC, and WebCore headers automatically to targers using them
3151         https://bugs.webkit.org/show_bug.cgi?id=165686
3152
3153         Reviewed by Michael Catanzaro.
3154
3155         This change reduces duplication of include path lists between modules,
3156         and reduces future need for fixes like r209605 (broken build because of
3157         WebCore header suddenly becoming used in WebKit2).
3158
3159         * DumpRenderTree/CMakeLists.txt:
3160         * DumpRenderTree/PlatformMac.cmake:
3161         * ImageDiff/CMakeLists.txt:
3162         * MiniBrowser/gtk/CMakeLists.txt:
3163         * MiniBrowser/mac/CMakeLists.txt:
3164         * MiniBrowser/win/CMakeLists.txt:
3165         * TestWebKitAPI/CMakeLists.txt:
3166         * TestWebKitAPI/PlatformEfl.cmake:
3167         * TestWebKitAPI/PlatformJSCOnly.cmake:
3168         * TestWebKitAPI/PlatformMac.cmake:
3169         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
3170         * WebKitTestRunner/CMakeLists.txt:
3171         * WebKitTestRunner/PlatformGTK.cmake:
3172         * WebKitTestRunner/PlatformMac.cmake:
3173
3174 2016-12-09  Csaba Osztrogonác  <ossy@webkit.org>
3175
3176         Unreviewed buildfix after r209630.
3177
3178         * Scripts/build-jsc: Remove building the non-existing testWASM.
3179
3180 2016-12-09  Eric Carlson  <eric.carlson@apple.com>
3181
3182         Annotate MediaStream and WebRTC idl with EnabledAtRuntime flag
3183         https://bugs.webkit.org/show_bug.cgi?id=165251
3184
3185         Reviewed by Dean Jackson.
3186
3187         Based on a patch by Dr Alex Gouaillard <agouaillard@gmail.com>
3188
3189         * DumpRenderTree/mac/DumpRenderTree.mm:
3190         (resetWebPreferencesToConsistentValues): Enable MediaStream and PeerConnection.
3191
3192         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3193         (WTR::InjectedBundle::beginTesting): Ditto.
3194
3195         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3196         (WTR::TestRunner::setMediaStreamEnabled): New.
3197         (WTR::TestRunner::setPeerConnectionEnabled): New.
3198         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3199
3200 2016-12-09  Brady Eidson  <beidson@apple.com> 
3201  
3202         Re-landing:
3203         Add _WKIconLoadingDelegate SPI. 
3204         https://bugs.webkit.org/show_bug.cgi?id=164894 
3205  
3206         Reviewed by Alex Christensen. 
3207         
3208         Add MiniBrowser support for this new SPI, configurable with a setting. 
3209  
3210         * MiniBrowser/mac/SettingsController.h: 
3211         * MiniBrowser/mac/SettingsController.m: 
3212         (-[SettingsController _populateMenu]): 
3213         (-[SettingsController validateMenuItem:]): 
3214         (-[SettingsController loadsAllSiteIcons]): 
3215         (-[SettingsController toggleLoadsAllSiteIcons:]): 
3216         * MiniBrowser/mac/WK2BrowserWindowController.m: 
3217         (-[WK2BrowserWindowController awakeFromNib]): 
3218         (-[WK2BrowserWindowController webView:shouldLoadIconWithParameters:completionHandler:]): 
3219
3220 2016-12-09  Ryan Haddad  <ryanhaddad@apple.com>
3221
3222         Fix the 32-bit build.
3223
3224         Unreviewed build fix.
3225
3226         * MiniBrowser/mac/SettingsController.h:
3227
3228 2016-12-09  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
3229
3230         Fedora also needs a PHP7 config file alternative
3231         https://bugs.webkit.org/show_bug.cgi?id=165606
3232
3233         Reviewed by Michael Catanzaro.
3234
3235         * Scripts/webkitpy/port/base.py:
3236         (Port._is_fedora_php_version_7): check for the php7 library.
3237         (Port._fedora_php_version): get the appropriate filename for Fedora.
3238         (Port._apache_config_file_name_for_platform):
3239
3240 2016-12-09  Ryan Haddad  <ryanhaddad@apple.com>
3241
3242         Complete the revert of r208865.
3243         https://bugs.webkit.org/show_bug.cgi?id=164894
3244
3245         Unreviewed build fix.
3246
3247         * MiniBrowser/mac/SettingsController.h:
3248         * MiniBrowser/mac/SettingsController.m:
3249         (-[SettingsController _populateMenu]):
3250         (-[SettingsController validateMenuItem:]):
3251         (-[SettingsController loadsAllSiteIcons]): Deleted.
3252         (-[SettingsController toggleLoadsAllSiteIcons:]): Deleted.
3253         * MiniBrowser/mac/WK2BrowserWindowController.m:
3254         (-[WK2BrowserWindowController awakeFromNib]):
3255         (-[WK2BrowserWindowController webView:shouldLoadIconWithParameters:completionHandler:]): Deleted.
3256
3257 2016-12-09  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
3258
3259         [GTK] Force GDK backend to x11 when running with XvfbDriver
3260         https://bugs.webkit.org/show_bug.cgi?id=165612
3261
3262         Reviewed by Michael Catanzaro.
3263
3264         When the developer is running a Wayland session, GDK may get confused
3265         and try to use its Wayland backend (which is higher priority) instead.
3266         This ensures it will use the appropriate backend when running under
3267         Xvfb.
3268
3269         * Scripts/webkitpy/port/gtk.py:
3270         (GtkPort.setup_environ_for_server): when running with XvfbDriver,
3271         force GDK_BACKEND to x11.
3272
3273 2016-12-08  Keith Miller  <keith_miller@apple.com>
3274
3275         Add 64-bit signed LEB decode method
3276         https://bugs.webkit.org/show_bug.cgi?id=165630
3277
3278         Reviewed by Ryosuke Niwa.
3279
3280         Add tests for LEB int64 and uint64 decode since I guess
3281         I forgot to add tests before.
3282
3283         * TestWebKitAPI/Tests/WTF/LEBDecoder.cpp:
3284         (TestWebKitAPI::testUInt32LEBDecode):
3285         (TestWebKitAPI::TEST):
3286         (TestWebKitAPI::testUInt64LEBDecode):
3287         (TestWebKitAPI::testInt32LEBDecode):
3288         (TestWebKitAPI::testInt64LEBDecode):
3289         (TestWebKitAPI::testUnsignedLEBDecode): Deleted.
3290
3291 2016-12-08  Filip Pizlo  <fpizlo@apple.com>
3292
3293         Make it easy to enable --force-collectContinuously
3294         https://bugs.webkit.org/show_bug.cgi?id=165638
3295
3296         Reviewed by Keith Miller.
3297
3298         * Scripts/run-javascriptcore-tests:
3299         (runJSCStressTests):
3300
3301 2016-12-08  Filip Pizlo  <fpizlo@apple.com>
3302
3303         Disable the collectContinuously mode until I investigate failures.
3304
3305         Rubber stamped by Keith Miller.
3306         
3307         I'm seeing collectContinuously crashes on some platforms. Disabling that testing mode
3308         while I investigate.
3309
3310         * Scripts/run-jsc-stress-tests:
3311
3312 2016-12-08  Alex Christensen  <achristensen@webkit.org>
3313
3314         REGRESSION (URL parser): Relative URLs aren’t resolved correctly when the base URL is an applewebdata: URL
3315         https://bugs.webkit.org/show_bug.cgi?id=165621
3316
3317         Reviewed by Dan Bernstein.
3318
3319         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3320         (TestWebKitAPI::TEST_F):
3321
3322 2016-12-06  Filip Pizlo  <fpizlo@apple.com>
3323
3324         Concurrent GC should be stable enough to land enabled
3325         https://bugs.webkit.org/show_bug.cgi?id=164990
3326
3327         Reviewed by Geoffrey Garen.
3328         
3329         Add a new mode that runs GC continuously. Also made eager modes run GC continuously.
3330         
3331         It's clear that this works just fine in release, but I'm still trying to figure out if it's
3332         safe for debug. It might be too slow for debug.
3333
3334         * Scripts/run-jsc-stress-tests:
3335
3336 2016-12-08  Alex Christensen  <achristensen@webkit.org>
3337
3338         Add SPI for sending WebsiteSettings to WebProcess during navigation
3339         https://bugs.webkit.org/show_bug.cgi?id=165517
3340         <rdar://29341068>
3341
3342         Reviewed by Anders Carlsson.
3343
3344         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3345         * TestWebKitAPI/Tests/WebKit2/contentBlockerCheck.html: Added.
3346         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm: Added.
3347         (-[WebsitePoliciesDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3348         (-[WebsitePoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
3349         (-[WebsitePoliciesDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
3350         (TEST):
3351
3352 2016-12-08  Chris Dumez  <cdumez@apple.com>
3353
3354         Unreviewed, rolling out r209489.
3355
3356         Likely caused large regressions on JetStream, Sunspider and
3357         Speedometer
3358
3359         Reverted changeset:
3360
3361         "Add system trace points for JavaScript VM entry/exit"
3362         https://bugs.webkit.org/show_bug.cgi?id=165550
3363         http://trac.webkit.org/changeset/209489
3364
3365 2016-12-08  Keith Miller  <keith_miller@apple.com>
3366
3367         Move LEB tests to API tests
3368         https://bugs.webkit.org/show_bug.cgi?id=165586
3369
3370         Reviewed by Saam Barati.
3371
3372         Move the tests from testWasm.cpp and make them functions
3373         rather than macros.
3374
3375         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3376         * TestWebKitAPI/Tests/WTF/LEBDecoder.cpp: Added.
3377         (TestWebKitAPI::testUnsignedLEBDecode):
3378         (TestWebKitAPI::TEST):
3379         (TestWebKitAPI::testInt32LEBDecode):
3380
3381 2016-12-08  Chris Dumez  <cdumez@apple.com>
3382
3383         Support running the layout tests offline
3384         https://bugs.webkit.org/show_bug.cgi?id=165534
3385
3386         Reviewed by Ryosuke Niwa.
3387
3388         * Scripts/webkitpy/common/system/autoinstall.py:
3389         (AutoInstaller._download_to_stream):
3390         getcode() returns None for file URLs so handle this.
3391
3392         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
3393         (WebPlatformTestServer._install_modules):
3394         Deal with local path in the json file and resolve them into file URLs
3395         before using AutoInstall.
3396
3397 2016-12-08  Alex Christensen  <achristensen@webkit.org>
3398
3399         Fix CMake build.
3400
3401         * DumpRenderTree/PlatformMac.cmake:
3402         Remove CheckedMalloc.cpp after r209516.
3403
3404 2016-12-07  Mark Lam  <mark.lam@apple.com>
3405
3406         DumpRenderTree should stop using CheckedMalloc.
3407         https://bugs.webkit.org/show_bug.cgi?id=165563
3408         <rdar://problem/28945820>
3409
3410         Reviewed by Geoffrey Garen.
3411
3412         1. WebKitTestRunner does not have equivalent behavior to that which is implemented
3413            in CheckedMalloc.
3414         2. bmalloc does not honor the settings of CheckedMalloc.
3415
3416         The only time CheckedMalloc comes into play is when DRT uses gmalloc or system
3417         malloc.  As a result, DRT exhibits different behavior from the normal way we run
3418         our tests.  We should obsolete CheckedMalloc and make DRT behave consistently
3419         with WKTR.
3420
3421         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3422         * DumpRenderTree/mac/CheckedMalloc.cpp: Removed.
3423         * DumpRenderTree/mac/CheckedMalloc.h: Removed.
3424         * DumpRenderTree/mac/DumpRenderTree.mm:
3425         (prepareConsistentTestingEnvironment):
3426
3427 2016-12-07  Dean Jackson  <dino@apple.com>
3428
3429         Remove runtime toggle for pointer-lock
3430         https://bugs.webkit.org/show_bug.cgi?id=165577
3431         <rdar://problems/29566996>
3432
3433         Reviewed by Jon Lee.
3434
3435         Remove any runtime calls to check if pointer-lock is enabled. It's
3436         either compiled in or out.
3437
3438         * DumpRenderTree/mac/DumpRenderTree.mm:
3439         (resetWebPreferencesToConsistentValues):
3440         * WebKitTestRunner/TestController.cpp:
3441         (WTR::TestController::resetPreferencesToConsistentValues):
3442
3443 2016-12-07  Eric Carlson  <eric.carlson@apple.com>
3444
3445         [MediaStream][Mac] Revoke sandbox extensions when capture ends
3446         https://bugs.webkit.org/show_bug.cgi?id=165476
3447
3448         Reviewed by Brady Eidson.
3449         
3450         Add a test which loads a page that calls navigator.mediaDevices.enumerateDevices, kills the
3451         page, and loads the same page again to ensure that the WK2 UserMediaPermissionRequestManagerProxy
3452         is reset and recreated when a web page exits and is reloaded.
3453
3454         * TestWebKitAPI/PlatformGTK.cmake:
3455         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3456         * TestWebKitAPI/Tests/WebKit2/EnumerateMediaDevices.cpp: Added.
3457         (TestWebKitAPI::checkUserMediaPermissionCallback):
3458         (TestWebKitAPI::TEST):
3459         * TestWebKitAPI/Tests/WebKit2/enumerateMediaDevices.html: Added.
3460
3461 2016-12-07  Jeremy Jones  <jeremyj@apple.com>
3462
3463         One esc to exit fullscreen and pointer lock
3464         https://bugs.webkit.org/show_bug.cgi?id=165416
3465         rdar://problem/29430711
3466
3467         Reviewed by Jer Noble.
3468
3469         Implement WKPageUIClientV8 for pointer lock support.
3470         Add "escape" key support in EventSenderProxy.
3471
3472         * WebKitTestRunner/TestController.cpp:
3473         (WTR::requestPointerLock):
3474         (WTR::TestController::createOtherPage):
3475         (WTR::TestController::createWebViewWithOptions):
3476         * WebKitTestRunner/mac/EventSenderProxy.mm:
3477         (WTR::EventSenderProxy::keyDown):
3478
3479 2016-12-07  Simon Fraser  <simon.fraser@apple.com>
3480
3481         Add system trace points for JavaScript VM entry/exit
3482         https://bugs.webkit.org/show_bug.cgi?id=165550
3483
3484         Reviewed by Tim Horton.
3485
3486         Add trace points for entry/exit into/out of the JS VM.
3487
3488         * Tracing/SystemTracePoints.plist:
3489
3490 2016-12-07  ChangSeok Oh  <changseok@webkit.org>
3491
3492         [GTK] Cannot build GTK+ with CUPS 2.* versions
3493         https://bugs.webkit.org/show_bug.cgi?id=163591
3494
3495         Reviewed by Michael Catanzaro.
3496
3497         GTK+ build has failed on the system which CUPS 2.x is installed in. GTK+ 3.16.4
3498         does not assume to use the recent CUPS thus it fails to detect the CUPS in configuration.
3499         GTK+ upstream fixed this issue but it is not easy to apply the original patch to our
3500         old gtk+ since it requires not only bumping up glib accordingly and its consequence
3501         causes many printing test failures. So, I propose to fix the configuration issue by
3502         applying the change to the configure file directly. By doing this, we don't need to
3503         upgrade glib and worry about any test failures as a consequence of the upgraded glib.
3504
3505         * gtk/jhbuild.modules:
3506         * gtk/patches/gtk+-configure-fix-detecting-CUPS-2.x.patch: Added.
3507
3508 2016-12-07  Simon Fraser  <simon.fraser@apple.com>
3509
3510         Fix use of enum in a WK2 C SPI header.
3511         rdar://problem/28725583
3512
3513         Followup to correctly prefix the enum values.
3514
3515         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3516         (WTR::InjectedBundlePage::prepare):
3517
3518 2016-12-07  Simon Fraser  <simon.fraser@apple.com>
3519
3520         Fix use of enum in a WK2 C SPI header.
3521         rdar://problem/28725583
3522
3523         Reviewed by Dan Bernstein.
3524
3525         Use correct enum style for a C SPI header and fix the callers.
3526
3527         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3528         (WTR::InjectedBundlePage::prepare):
3529
3530 2016-12-07  Wenson Hsieh  <wenson_hsieh@apple.com>
3531
3532         Add a new project for recording and playing back editing commands in editable web content
3533         https://bugs.webkit.org/show_bug.cgi?id=165114
3534         <rdar://problem/29408135>
3535
3536         Reviewed by Beth Dakin.
3537
3538         Adds a new Xcode project containing work towards rewinding and playing back editing commands. This work is
3539         wrapped in an Xcode project to take advantage of the XCTest framework. To manually test recording, open the
3540         capture test harness, edit the contenteditable body, and then hit cmd-S. This downloads a .json file which may
3541         then be dragged into the playback test harness.
3542
3543         Also adds 3 new unit tests in EditingHistoryTests/RewindAndPlaybackTests.m. These tests carry out the following
3544         steps:
3545
3546         1. Load the capture harness and perform test-specific editing on the web view.
3547         2. Let originalState be a dump of the DOM at this point in time.
3548         3. Extract the JSON-serialized editing history data and load the playback harness with this data.
3549         4. Rewind all editing to the beginning.
3550         5. Playback all editing to the end.
3551         6. Dump the state of the DOM. This should be identical to originalState.
3552
3553         * EditingHistory/EditingHistory.xcodeproj/project.pbxproj: Added.
3554         * EditingHistory/EditingHistory/Info.plist: Added.
3555         * EditingHistory/EditingHistory/Resources/CaptureHarness.html: Added.
3556         * EditingHistory/EditingHistory/Resources/DOMTestingUtil.js: Added.
3557         * EditingHistory/EditingHistory/Resources/PlaybackHarness.html: Added.
3558         * EditingHistory/EditingHistory/TestRunner.h: Added.
3559         * EditingHistory/EditingHistory/TestRunner.m: Added.
3560         (injectedMessageEventHandlerScript):
3561         (-[TestRunner init]):
3562         (-[TestRunner deleteBackwards:]):
3563         (-[TestRunner typeString:]):
3564         (-[TestRunner bodyElementSubtree]):
3565         (-[TestRunner bodyTextContent]):
3566         (-[TestRunner editingHistoryJSON]):
3567         (-[TestRunner loadPlaybackTestHarnessWithJSON:]):
3568         (-[TestRunner numberOfUpdates]):
3569         (-[TestRunner jumpToUpdateIndex:]):
3570         (-[TestRunner expectEvents:afterPerforming:]):
3571         (-[TestRunner loadCaptureTestHarness]):
3572         (-[TestRunner setTextObfuscationEnabled:]):
3573         (-[TestRunner isDoneWaitingForPendingEvents]):
3574         (-[TestRunner userContentController:didReceiveScriptMessage:]):
3575
3576         The TestRunner provides utilities that a unit test should use to drive the test forward (e.g. loading harnesses)
3577         or inspect the state of the loaded page (e.g. extracting JSON editing history data from the capture harness).
3578
3579         * EditingHistory/EditingHistory/TestUtil.h: Added.
3580         * EditingHistory/EditingHistory/TestUtil.m: Added.
3581         (waitUntilWithTimeout):
3582         (waitUntil):
3583
3584         Provides utilities for running tests. For now, this is just spinning the runloop on a given condition.
3585
3586         * EditingHistory/EditingHistory/WKWebViewAdditions.h: Added.
3587         * EditingHistory/EditingHistory/WKWebViewAdditions.m: Added.
3588         (-[WKWebView loadPageFromBundleNamed:]):
3589         (-[WKWebView typeCharacter:]):
3590         (-[WKWebView keyPressWithCharacters:keyCode:]):
3591         (-[WKWebView stringByEvaluatingJavaScriptFromString:]):
3592
3593         Provides utilities for simulating interaction in a web view.
3594
3595         * EditingHistory/EditingHistory/main.m: Added.
3596         (main):
3597         * EditingHistory/EditingHistoryTests/Info.plist: Added.
3598         * EditingHistory/EditingHistoryTests/RewindAndPlaybackTests.m: Added.
3599         (-[RewindAndPlaybackTests setUp]):
3600         (-[RewindAndPlaybackTests tearDown]):
3601         (-[RewindAndPlaybackTests testTypingSingleLineOfText]):
3602         (-[RewindAndPlaybackTests testTypingMultipleLinesOfText]):
3603         (-[RewindAndPlaybackTests testTypingAndDeletingText]):
3604         (-[RewindAndPlaybackTests rewindAndPlaybackEditingInPlaybackTestHarness]):
3605         (-[RewindAndPlaybackTests originalBodySubtree:isEqualToFinalSubtree:]):
3606
3607 2016-12-07  Philippe Normand  <pnormand@igalia.com>
3608
3609         [GTK][jhbuild] missing dependency on libvpx in gst-plugins-good
3610         https://bugs.webkit.org/show_bug.cgi?id=165525
3611
3612         Reviewed by Carlos Garcia Campos.
3613
3614         * gtk/jhbuild.modules: gst-plugins-good should depend on the
3615         libvpx package built within jhbuild.
3616
3617 2016-12-07  Philippe Normand  <pnormand@igalia.com>
3618
3619         [GTK][jhbuild] gst-plugins-bad fails to build with OpenSSL 1.1.0
3620         https://bugs.webkit.org/show_bug.cgi?id=165520
3621
3622         Reviewed by Carlos Garcia Campos.
3623
3624         * gtk/jhbuild.modules: Added missing dependency on openh264 in
3625         gst-plugins-bad, along with 2 upstream patches fixing the build
3626         against OpenSSL 1.1.0.
3627         * gtk/patches/gst-plugins-bad-0001-dtls-port-to-OpenSSL-1.1.0.patch: Added.
3628         * gtk/patches/gst-plugins-bad-0002-dtlscertificate-Fix-error-checking-in-RSA_generate_k.patch: Added.
3629
3630 2016-12-06  Alexey Proskuryakov  <ap@apple.com>
3631
3632         Correct SDKROOT values in xcconfig files
3633         https://bugs.webkit.org/show_bug.cgi?id=165487
3634         rdar://problem/29539209
3635
3636         Reviewed by Dan Bernstein.
3637
3638         Fix suggested by Dan Bernstein.
3639
3640         * ContentExtensionTester/Configurations/DebugRelease.xcconfig:
3641         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
3642         * MiniBrowser/Configurations/DebugRelease.xcconfig:
3643         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
3644         * WebEditingTester/Configurations/DebugRelease.xcconfig:
3645         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
3646
3647 2016-12-06  Daniel Bates  <dabates@apple.com>
3648
3649         WebKitTestRunner: Plugins are disabled in new windows
3650         https://bugs.webkit.org/show_bug.cgi?id=165410
3651
3652         Reviewed by Alex Christensen.
3653
3654         Currently WebKitTestRunner only enables plugins in the main window. So, a test that opens
3655         a new window and loads a plugin will fail. We should enable plugins in all windows by
3656         default. Moreover toggling testRunner.setPluginsEnabled() should effect all windows.
3657
3658         Making these changes is a step towards running plugins/open-and-close-window-with-plugin.html
3659         in WebKitTestRunner (we still need to fix <https://bugs.webkit.org/show_bug.cgi?id=46714>) and
3660         will make the behavior of WebKitTestRunner more closely match the behavior DumpRenderTree.
3661
3662         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3663         (WTR::InjectedBundle::beginTesting): Call TestRunner::setPluginsEnabled() instead of
3664         WKBundleSetPluginsEnabled().
3665         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3666         (WTR::TestRunner::setPluginsEnabled): Take a similar approach as TestRunner::setXSSAuditorEnabled()
3667         and make use of WKBundleOverrideBoolPreferenceForTestRunner().
3668
3669 2016-12-05  Dean Jackson  <dino@apple.com>
3670
3671         pointer lock needs to be feature detectable
3672         https://bugs.webkit.org/show_bug.cgi?id=165426
3673         <rdar://problem/29486715>
3674
3675         Reviewed by Antoine Quint.
3676
3677         Expose the comment line to turn on/off pointer lock.
3678
3679         * DumpRenderTree/TestOptions.h:
3680         * DumpRenderTree/TestOptions.mm:
3681         (TestOptions::TestOptions):
3682         * DumpRenderTree/mac/DumpRenderTree.mm:
3683         (resetWebPreferencesToConsistentValues):
3684         * WebKitTestRunner/TestController.cpp:
3685         (WTR::TestController::resetPreferencesToConsistentValues):
3686         (WTR::updateTestOptionsFromTestHeader):
3687         * WebKitTestRunner/TestOptions.h:
3688         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3689         (WTR::PlatformWebView::viewSupportsOptions):
3690         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3691         (WTR::PlatformWebView::viewSupportsOptions):
3692
3693 2016-12-05  Jonathan Bedard  <jbedard@apple.com>
3694
3695         Make it possible to use an existing simulator instance for one-off testing
3696         https://bugs.webkit.org/show_bug.cgi?id=164568
3697         <rdar://problem/29189133>
3698
3699         Reviewed by Daniel Bates.
3700
3701         With this patch, if a simulator is currently running on the machine and
3702         '--dedicated-simulators' is not passed into the application, only one simulator
3703         instance will be used, and this instance will be the existing instance.
3704         If no simulator is running or '--dedicated-simulators' is passed to the script,
3705         previous behavior will be used.
3706
3707         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3708         (parse_args):
3709         * Scripts/webkitpy/port/ios.py:
3710         (IOSSimulatorPort.__init__): Logic for enabling usage of currently running simulator.
3711         (IOSSimulatorPort._create_simulators): Only create simulators when needed, don't reset already running simulators.
3712         (IOSSimulatorPort.setup_test_run): Don't open already running simulators.
3713         (IOSSimulatorPort._quit_ios_simulator): Only quit simulators if we manage them.
3714         (IOSSimulatorPort.clean_up_test_run): Only clean up simulators if we manage them. 
3715         (IOSSimulatorPort._using_dedicated_simulators): True if simulators need to be managed, false if using an existing instance.
3716         (IOSSimulatorPort.device_id_for_worker_number): Access currently running simulator if not managing devices.
3717         * Scripts/webkitpy/xcode/simulator.py:
3718         (Simulator.refresh): Check if xcode_simctl_list returned None instead of a generator.
3719         (Simulator.current_device): Get currently running device.
3720
3721 2016-12-05  Dan Bernstein  <mitz@apple.com>
3722
3723         Disable a crashing test on iOS.
3724
3725         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegate.mm:
3726
3727 2016-12-04  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3728
3729         Fix a build break on EFL since r209303.
3730
3731         Unreviewed build fix.
3732
3733         * Scripts/webkitperl/FeatureList.pm: Disable SS Device Adaptation temporarily.
3734
3735 2016-12-03  Yusuke Suzuki  <utatane.tea@gmail.com>
3736
3737         Refactor SymbolImpl layout
3738         https://bugs.webkit.org/show_bug.cgi?id=165247
<