2011-02-06 Maciej Stachowiak <mjs@apple.com>
[WebKit.git] / Tools / ChangeLog
1 2011-02-06  Maciej Stachowiak  <mjs@apple.com>
2
3         Reviewed by David Levin.
4
5         Add WebKit2 test bot to core builders
6         https://bugs.webkit.org/show_bug.cgi?id=53901
7
8         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
9
10 2011-02-06  Ryosuke Niwa  <rniwa@webkit.org>
11
12         Another unreviewed Chromium build fix.
13
14         * DumpRenderTree/chromium/LayoutTestController.cpp:
15         (LayoutTestController::pathToLocalResource):
16
17 2011-02-06  Ryosuke Niwa  <rniwa@webkit.org>
18
19         Unreviewed Chromium build fix.
20
21         * DumpRenderTree/chromium/LayoutTestController.cpp:
22         (LayoutTestController::pathToLocalResource):
23
24 2011-02-06  Ryosuke Niwa  <rniwa@webkit.org>
25
26         Reviewed by Darin Adler.
27
28         OwnArraryPtr.h uses deleteOwnedPtr but doesn’t include OwnPtrCommon.h
29         https://bugs.webkit.org/show_bug.cgi?id=52867
30
31         * DumpRenderTree/chromium/ImageDiff.cpp:
32         (Image::craeteFromStdin): Call adoptArrayPtr.
33
34 2011-02-06  James Kozianski  <koz@chromium.org>
35
36         Reviewed by Ojan Vafai.
37
38         Add classes for representing test outputs.
39         https://bugs.webkit.org/show_bug.cgi?id=52136
40
41         These classes will make it easier to write scripts that deal with test
42         outputs such as rebaselining and deduping scripts. The intent is that
43         eventually we will be have buildbot return TestOutputs for a
44         particular build which can be compared with TestOutputs derived from a
45         local LayoutTests directory.
46
47         * Scripts/webkitpy/common/net/testoutput.py: Added.
48         * Scripts/webkitpy/common/net/testoutput_unittest.py: Added.
49         * Scripts/webkitpy/common/net/testoutputset.py: Added.
50         * Scripts/webkitpy/common/net/testoutputset_unittest.py: Added.
51         * Scripts/webkitpy/common/system/zip_mock.py: Added.
52
53 2011-02-06  Robert Hogan  <robert@webkit.org>
54
55         Reviewed by Andreas Kling.
56
57         [Qt] Clear page's groupName even when not in DRT
58         https://bugs.webkit.org/show_bug.cgi?id=53874
59
60         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
61         (WebCore::DumpRenderTree::windowCloseRequested):
62
63 2011-02-06  Patrick Gansterer  <paroga@webkit.org>
64
65         Reviewed by Andreas Kling.
66
67         [CMake] Add dependencies for Visual Studio projects
68         https://bugs.webkit.org/show_bug.cgi?id=53773
69
70         Add a WebKit dependecy to WinCELauncher, so CMake can 
71         generate the correct build order for the solution.
72
73         * CMakeListsWinCE.txt:
74
75 2011-02-06  Andreas Kling  <kling@webkit.org>
76
77         Reviewed by Antonio Gomes.
78
79         [Qt] MiniBrowser: Clean up handling of titleChanged() signal
80         https://bugs.webkit.org/show_bug.cgi?id=53869
81
82         * MiniBrowser/qt/BrowserView.cpp:
83         (BrowserView::BrowserView): Remove unnecessary titleChanged() handling.
84         * MiniBrowser/qt/BrowserWindow.cpp:
85         (BrowserWindow::BrowserWindow): Connect titleChanged() directly to setWindowTitle().
86         * MiniBrowser/qt/BrowserWindow.h:
87
88 2011-02-06  Maciej Stachowiak  <mjs@apple.com>
89
90         Reviewed by Dan Bernstein.
91
92         WebKitTestRunner needs layoutTestController.setWillSendRequestReturnsNull
93         https://bugs.webkit.org/show_bug.cgi?id=42690
94         <rdar://problem/8213851>
95
96         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
97         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
98         (WTR::InjectedBundlePage::willSendRequestForFrame):
99         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
100         (WTR::LayoutTestController::LayoutTestController):
101         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
102         (WTR::LayoutTestController::willSendRequestReturnsNull):
103         (WTR::LayoutTestController::setWillSendRequestReturnsNull):
104
105 2011-02-05  Sheriff Bot  <webkit.review.bot@gmail.com>
106
107         Unreviewed, rolling out r77720.
108         http://trac.webkit.org/changeset/77720
109         https://bugs.webkit.org/show_bug.cgi?id=53854
110
111         "Broke nrwt on Chromium win." (Requested by dglazkov|away on
112         #webkit).
113
114         * Scripts/webkitpy/common/system/executive.py:
115
116 2011-02-05  Sheriff Bot  <webkit.review.bot@gmail.com>
117
118         Unreviewed, rolling out r77725.
119         http://trac.webkit.org/changeset/77725
120         https://bugs.webkit.org/show_bug.cgi?id=53844
121
122         It broke Qt minimal build (Requested by Ossy_ on #webkit).
123
124         * QtTestBrowser/launcherwindow.cpp:
125         (LauncherWindow::createChrome):
126         * QtTestBrowser/launcherwindow.h:
127         (WindowOptions::WindowOptions):
128         * QtTestBrowser/main.cpp:
129         (LauncherApplication::handleUserOptions):
130
131 2011-02-04  Martin Robinson  <mrobinson@igalia.com>
132
133         Reviewed by Adam Barth.
134
135         [GTK] plugins/plugin-document-back-forward.html fails
136         https://bugs.webkit.org/show_bug.cgi?id=53833
137
138         Add the new "alert on load" functionality for the Unix version of the
139         test plugin. This functionality was originally introduced in r77706.
140
141         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
142         (webkit_test_plugin_new_instance): Add new plugin fuctionality.
143
144 2011-02-04  Kundu Suchismita  <suchi.kundu@nokia.com>
145
146         Reviewed by Andreas Kling.
147
148         Local Storage settings can be enable/disable from "Develop" menu
149         https://bugs.webkit.org/show_bug.cgi?id=52296
150
151         * QtTestBrowser/launcherwindow.cpp:
152         (LauncherWindow::createChrome):
153         (LauncherWindow::toggleLocalStorage):
154         (LauncherWindow::toggleOfflineStorageDatabase):
155         (LauncherWindow::toggleOfflineWebApplicationCache):
156         (LauncherWindow::setOfflineStorageDefaultQuota):
157         * QtTestBrowser/launcherwindow.h:
158         (WindowOptions::WindowOptions):
159         * QtTestBrowser/main.cpp:
160         (LauncherApplication::handleUserOptions):
161
162 2011-02-04  Tony Chang  <tony@chromium.org>
163
164         Reviewed by Eric Seidel.
165
166         get test-webkitpy running on win32 python
167         https://bugs.webkit.org/show_bug.cgi?id=53822
168
169         The test harness crashes with a WindowsError because it can't find
170         'svn' when using subprocess.Popen.  This gets us past the error
171         so we can see the failing tests on the Chromium Win Release Tests
172         bot.
173
174         * Scripts/webkitpy/common/system/executive.py:
175
176 2011-02-04  Martin Robinson  <mrobinson@igalia.com>
177
178         Reviewed by Gustavo Noronha Silva.
179
180         [GTK] fast/events/pagehide-timeout.html fails
181         https://bugs.webkit.org/show_bug.cgi?id=53771
182
183         Add knowledge of the document browser cache model the DRT. When resetting
184         WebKit settings to consistent values between tests, default to the document
185         browser cache model.
186
187         * DumpRenderTree/gtk/DumpRenderTree.cpp:
188         (resetDefaultsToConsistentValues): Reset the cache model to the document browser
189         cache model between tests.
190         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
191         (LayoutTestController::setCacheModel): An int value of 2 here corresponds to the
192         document browser cache model.
193
194 2011-02-04  Adam Barth  <abarth@webkit.org>
195
196         Reviewed by Eric Seidel.
197
198         PluginDocuments don't create widgets for plugins on back/forward
199         https://bugs.webkit.org/show_bug.cgi?id=53474
200
201         Teach the test plugin how to call alert on load.
202
203         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
204         (NPP_New):
205
206 2011-02-04  Adam Roben  <aroben@apple.com>
207
208         Add a test case for encode/decode of FormData/FormDataElement
209
210         If the fix made in r77401 is broken, this new test will crash.
211
212         Fixes <http://webkit.org/b/53616> <rdar://problem/8949883>.
213
214         Reviewed by Sam Weinig.
215
216         * TestWebKitAPI/Test.h: Moved the bulk of TEST_ASSERT into a new _TEST_ASSERT_HELPER macro.
217         Added a new TEST_ASSERT_RETURN macro that can be used in functions with a return value.
218
219         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp: Added.
220         (TestWebKitAPI::didFinishLoadForFrame): Record that the load is finished.
221         (TestWebKitAPI::setPageLoaderClient): Hook up the loader client.
222         (TestWebKitAPI::createSessionStateContainingFormData): Load simple-form.html, submit the
223         form, an return the session state data.
224         (TestWebKitAPI::TEST): Create some session state that contains form data from one WKPage,
225         and restore it into another WKPage.
226
227         * TestWebKitAPI/Tests/WebKit2/simple-form.html: Added.
228
229         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
230         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
231         * TestWebKitAPI/win/copy-resources.cmd:
232         Added new files.
233
234 2011-02-04  Adam Roben  <aroben@apple.com>
235
236         Move code to run JavaScript tests into its own files
237
238         This will allow other tests to use this mechanism.
239
240         Fixes <http://webkit.org/b/53806> SpacebarScrolling should share its JavaScript-fu with the
241         world
242
243         Reviewed by Sam Weinig.
244
245         * TestWebKitAPI/JavaScriptTest.cpp: Added.
246         * TestWebKitAPI/JavaScriptTest.h: Added.
247         Moved code here...
248
249         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp: ...from here.
250
251         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
252         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
253         Added the new files.
254
255 2011-02-04  Dirk Pranke  <dpranke@chromium.org>
256
257         Reviewed by Mihai Parparita.
258
259         merge test expectations for chromium, chromium-gpu. The
260         chromium-gpu port will no longer maintain its own
261         test expectations file.
262
263         Also add in a graphics_type() call on the port object to
264         determine what graphics type to use in the test configuration,
265         and log the configuration as a config setting.
266
267         https://bugs.webkit.org/show_bug.cgi?id=53562
268
269         * Scripts/webkitpy/layout_tests/port/base.py:
270         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
271         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
272         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
273
274 2011-02-04  Mikhail Naganov  <mnaganov@chromium.org>
275
276         Reviewed by Pavel Feldman.
277
278         Web Inspector: fix processing Unicode literals from .js sources in check-inspector-strings.
279         https://bugs.webkit.org/show_bug.cgi?id=53781
280
281         * Scripts/check-inspector-strings:
282
283 2011-02-04  Adam Roben  <aroben@apple.com>
284
285         Include the crashing function in the link to a crash log on Mac
286
287         Fixes <http://webkit.org/b/53780> Crash log links in results.html should include the
288         function that crashed on Mac
289
290         Reviewed by David Kilzer.
291
292         * Scripts/old-run-webkit-tests:
293         (crashLocation): Moved all the Windows code inside an if instead of using an early return,
294         but didn't otherwise change it. Added an if for Mac that parses the crashing function out of
295         the crash log.
296
297 2011-02-04  Adam Roben  <aroben@apple.com>
298
299         Link to Mac crash logs from results.html
300
301         Fixes <http://webkit.org/b/14861> run-webkit-tests should link to Mac crash logs in
302         results.html
303
304         Reviewed by David Kilzer.
305
306         * Scripts/old-run-webkit-tests:
307         (captureSavedCrashLog): Added a case for Apple's Mac port. We get the crash log out of
308         ~/Library/Logs/CrashReporter, and wait for ReportCrash to exit before trying to get the log.
309
310 2011-02-03  Maciej Stachowiak  <mjs@apple.com>
311
312         Reviewed by Dan Bernstein.
313
314         WebKit2: Need WebKit2 equivalent of WebResourceLoadDelegate::willSendRequest in the Bundle
315         https://bugs.webkit.org/show_bug.cgi?id=52897
316         <rdar://problem/8898294>
317
318         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
319         (WTR::InjectedBundlePage::InjectedBundlePage):
320         (WTR::InjectedBundlePage::willSendRequestForFrame):
321         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
322
323 2011-02-03  Ivan Krstić  <ike@apple.com>
324
325         Unreviewed.
326
327         Adding myself to committers.py.
328
329         * Scripts/webkitpy/common/config/committers.py:
330
331 2011-02-03  James Kozianski  <koz@chromium.org>
332
333         Reviewed by Dimitri Glazkov.
334
335         Add navigator.registerProtocolHandler behind a flag.
336         https://bugs.webkit.org/show_bug.cgi?id=52609
337
338         * Scripts/build-webkit:
339
340 2011-02-03  Hayato Ito  <hayato@chromium.org>
341
342         Reviewed by Eric Seidel.
343
344         [NRWT] Remove TestArgs class, which is wrongly used.
345
346         https://bugs.webkit.org/show_bug.cgi?id=53063
347
348         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
349         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
350         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
351         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
352         * Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py:
353         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
354
355 2011-02-03  Andrew Wason  <rectalogic@rectalogic.com>
356
357         Reviewed by Kenneth Russell.
358
359         Change ENABLE_3D_CANVAS to ENABLE_WEBGL
360         https://bugs.webkit.org/show_bug.cgi?id=53714
361
362         * Scripts/build-webkit: change --3d-canvas build option
363           to set ENABLE_WEBGL
364
365 2011-02-03  Hayato Ito  <hayato@chromium.org>
366
367         Reviewed by Tony Chang.
368
369         [NRWT] Introduces Input/Output class used by base.Driver into port/base.py and
370         move _run_single_test() and _process_output() functions from
371         dump_render_tree_thread.py to a single_test_runner.py as an individual module.
372
373         This is clean up and acts as a preparation for elimination of test_types/*
374         classes. These classes will move to the single_test_runner module introduced
375         in this patch.
376
377         https://bugs.webkit.org/show_bug.cgi?id=53004
378
379         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
380         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py: Added.
381         * Scripts/webkitpy/layout_tests/layout_package/test_input.py:
382         * Scripts/webkitpy/layout_tests/layout_package/test_output.py: Removed.
383         * Scripts/webkitpy/layout_tests/port/base.py:
384         * Scripts/webkitpy/layout_tests/port/chromium.py:
385         * Scripts/webkitpy/layout_tests/port/dryrun.py:
386         * Scripts/webkitpy/layout_tests/port/test.py:
387         * Scripts/webkitpy/layout_tests/port/webkit.py:
388         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
389         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
390         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
391
392 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
393
394         Unreviewed, build fix.
395
396         Delete a line that was accidentally missed in r77586; without it
397         there is still a race between the two threads.
398
399         https://bugs.webkit.org/show_bug.cgi?id=51572
400
401         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
402
403 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
404
405         Reviewed by Tony Chang.
406
407         nrwt: handle "broken pipe" notifications from DRT more cleanly.
408
409         https://bugs.webkit.org/show_bug.cgi?id=52927
410
411         * Scripts/webkitpy/layout_tests/port/server_process.py:
412         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
413
414 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
415
416         Reviewed by Kenneth Russell.
417
418         Update, resubmit change to bug 51572. I think the race that was
419         fixed in r76703 caused the hang that caused us to roll this
420         patch out before, so I'd like to try again.
421
422         https://bugs.webkit.org/show_bug.cgi?id=51572
423
424         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
425         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
426
427 2011-02-03  Daniel Cheng  <dcheng@chromium.org>
428
429         Unreviewed.
430
431         Adding myself to committers.py.
432
433         * Scripts/webkitpy/common/config/committers.py:
434
435 2011-02-03  Adam Roben  <aroben@apple.com>
436
437         Include the crashing function in the link to a crash log
438
439         Fixes <http://webkit.org/b/53739> Crash log links in results.html should include the
440         function that crashed
441
442         Reviewed by David Kilzer.
443
444         * Scripts/old-run-webkit-tests:
445         (crashLocation): Added. Returns the location of the crash.
446         (linksForErrorTest): Include the crash location in the link text for the crash log, if one
447         could be determined.
448
449 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
450
451         Unreviewed, build fix.
452
453         Actually make the changes suggested by Mihai in his review
454         of bug 53720 :(
455
456         https://bugs.webkit.org/show_bug.cgi?id=53720
457
458         * Scripts/webkitpy/layout_tests/port/test_files.py:
459         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
460
461 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
462
463         Reviewed by Mihai Parparita.
464
465         new-run-webkit-tests: Fix bug introduced in r77434 that was
466         causing us to run the canvas GPU tests on the Mac GPU port. This
467         bug revealed that we were not setting the port.name() field
468         properly in many cases, so I've cleaned up all of that code, and
469         removed a few comments about "version-specific" GPU ports that
470         don't exist and just confused things.
471
472         Testing also revealed that port.abspath_for_test() wasn't
473         normalizing paths on Windows properly, so I fixed that as well.
474
475         https://bugs.webkit.org/show_bug.cgi?id=53719
476
477         * Scripts/webkitpy/layout_tests/port/base.py:
478         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
479         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
480
481 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
482
483         Reviewed by Mihai Parparita.
484
485         new-run-webkit-tests: fix normalization of paths on windows when gathering files
486
487         r77434 introduced a bug that was causing the test expectations
488         for the GPU ports to not be treated properly. It turns out that
489         when we gathered the list of test files on Windows, we would
490         return paths of the form "c:\LayoutTests/fast/canvas", and the
491         mixture of backslashes and forward slashes was confusing things.
492
493         This patch normalizes all of the filenames returned from
494         test_files.find(), and adds better tests for this (fixing a
495         couple of other bugs found in the meantime).
496
497         https://bugs.webkit.org/show_bug.cgi?id=53720
498
499         * Scripts/webkitpy/layout_tests/port/test.py:
500         * Scripts/webkitpy/layout_tests/port/test_files.py:
501         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
502
503 2011-02-03  Adam Roben  <aroben@apple.com>
504
505         Add links to Windows crash logs in results.html
506
507         Fixes <http://webkit.org/b/53718> run-webkit-tests should link to Windows crash logs in
508         results.html
509
510         Reviewed by David Kilzer.
511
512         * Scripts/old-run-webkit-tests:
513         (top level): Added $crashLogTag and $windowsCrashLogFilePrefix (which came from
514         createDebuggerCommandFile).
515         (testCrashedOrTimedOut): If the test crashed, capture any saved crash log after the dump
516         tool has exited.
517         (captureSavedCrashLog): Added. Finds the crash log for the test that just crashed and moves
518         it into the test results directory tree. Only implemented for Cygwin currently.
519         (findNewestFileMatchingGlob): Added. Does what it says.
520         (htmlForResultsSection): Only link to files that exist.
521         (linksForErrorTest): Add a link to the crash log.
522         (deleteExpectedAndActualResults): Delete any old crash log for this test.
523         (createDebuggerCommandFile): Use the new $windowsCrashLogFilePrefix constant instead of
524         hardcoding it here.
525
526 2011-02-03  Adam Roben  <aroben@apple.com>
527
528         Tell the debugger the path to the WebKit source tree when saving a crash log
529
530         This allows the debugger to include the crashing line of code in the log.
531
532         Fixes <http://webkit.org/b/53678> Crash logs from buildslaves don't show the crashing line
533         of code
534
535         Reviewed by Sam Weinig.
536
537         * Scripts/old-run-webkit-tests:
538         (createDebuggerCommandFile): Added. Saves commands that we'd like the debugger to run to a
539         file and returns the path to that file. The commands we pass came from
540         setUpWindowsCrashLogSaving, but I've added a .srcpath command to tell the debugger where the
541         WebKit source code lives.
542         (setUpWindowsCrashLogSaving): Instead of specifying the commands directly on the command
543         line using -c, save them to a file and specify the path to that file using -cf. This works
544         around what is presumably a bug in Windows's command line parsing, where having multiple
545         quoted paths in the debugger commands causes the post-mortem debugger not to be invoked at
546         all. Also pulled the options we pass to the debugger out into a list that is then join()ed
547         together to make them easier to modify in the future.
548
549 2011-02-02  Sam Weinig  <sam@webkit.org>
550
551         Reviewed by Anders Carlsson.
552
553         Add notification of the end of a rubber band.
554         <rdar://problem/8940648>
555
556         * MiniBrowser/mac/BrowserWindowController.m:
557         (-[BrowserWindowController awakeFromNib]):
558         * WebKitTestRunner/TestController.cpp:
559         (WTR::TestController::createOtherPage):
560         (WTR::TestController::initialize):
561         Stub out the new WKUIClient function.
562
563 2011-02-03  Gabor Rapcsanyi  <rgabor@webkit.org>
564
565         Unreviewed.
566
567         Adding myself to committers.py.
568
569         * Scripts/webkitpy/common/config/committers.py:
570
571 2011-02-03  Balazs Kelemen  <kbalazs@webkit.org>
572
573         Reviewed by Csaba Osztrogonác.
574
575         [Qt][WK2] MiniBrowser's window size should be 800x600
576         https://bugs.webkit.org/show_bug.cgi?id=53670
577
578         Make layout test failure debugging easier.
579         * MiniBrowser/qt/BrowserWindow.cpp:
580         (BrowserWindow::BrowserWindow):
581
582 2011-02-02  Andy Estes  <aestes@apple.com>
583
584         Reviewed by Mark Rowe.
585
586         'update-webkit' should handle OpenSource and Internal using different
587         VCSs.
588
589         * Scripts/update-webkit: Re-check the VCS type when updating Apple's
590         Internal directory.
591
592 2011-02-02  Dirk Pranke  <dpranke@chromium.org>
593
594         Reviewed by Mihai Parparita.
595
596         new-run-webkit-tests: hardcode the directories to scan for tests
597         for GPU bots instead of SKIPping them. See bug 53562 for some
598         context, but we will now hard-code the list of directories to
599         use by default instead of skipping over directories in the
600         expectations file. We do this so that we will be able to merge
601         the expectations files without getting conflicting SKIP
602         directives. Note that this change will reduce the # of tests
603         being run on the Mac GPU bots, because we're accidentally
604         including some today.
605
606         https://bugs.webkit.org/show_bug.cgi?id=53631
607
608         * Scripts/webkitpy/layout_tests/port/base.py:
609         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
610         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
611
612 2011-02-02  Sam Weinig  <sam@webkit.org>
613
614         Reviewed by Beth Dakin.
615
616         Add ChromeClient function to paint custom overhang areas.
617         https://bugs.webkit.org/show_bug.cgi?id=53639
618
619         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
620         (WTR::InjectedBundlePage::InjectedBundlePage):
621         Stub out new callback.
622
623 2011-02-02  Dirk Pranke  <dpranke@chromium.org>
624
625         Reviewed by Tony Chang.
626
627         new-run-webkit-tests: support chromium code paths in mock_drt
628
629         https://bugs.webkit.org/show_bug.cgi?id=53471
630
631         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
632         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
633
634 2011-02-02  Adam Klein  <adamk@chromium.org>
635
636         Reviewed by Tony Chang.
637
638         Update new-run-webkit-tests --chromium to put output under Source/...
639         https://bugs.webkit.org/show_bug.cgi?id=53612
640
641         * BuildSlaveSupport/test-result-archive:
642         * Scripts/webkitpy/layout_tests/port/chromium.py:
643
644 2011-01-28  Tony Chang  <tony@chromium.org>
645
646         Reviewed by Eric Seidel.
647
648         [chromium] remove --use-test-shell from NRWT
649         https://bugs.webkit.org/show_bug.cgi?id=53346
650
651         I've already started removing some of the bindings like eventSender so
652         this already doesn't work isn't useful.  Also updated some comments to
653         refer to DRT instead of test_shell.
654
655         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
656         * Scripts/webkitpy/layout_tests/port/chromium.py:
657         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
658         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
659         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
660         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
661         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
662         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
663
664 2011-02-02  Steve Lacey  <sjl@chromium.org>
665
666         Reviewed by Eric Carlson.
667
668         Implement basic media statistics on media elements.
669         https://bugs.webkit.org/show_bug.cgi?id=53322
670
671         * Scripts/build-webkit:
672
673 2011-02-02  Kevin Ollivier  <kevino@theolliviers.com>
674
675         [wx] Build fixes for wxWebKit.
676
677         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
678         (LayoutTestController::setSerializeHTTPLoads):
679         * wx/browser/wscript:
680         * wx/build/build_utils.py:
681         * wx/build/settings.py:
682
683 2011-02-01  Dirk Pranke  <dpranke@chromium.org>
684
685         Reviewed by Mihai Parparita.
686
687         new-run-webkit-tests: stop skipping so many tests
688
689         r77163 introduced a regression where we weren't resetting test
690         expectations properly and were skipping too many tests as a
691         result. This patch fixes that and adds a test for it.
692
693         https://bugs.webkit.org/show_bug.cgi?id=53551
694
695         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
696         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
697
698 2011-02-01  Dirk Pranke  <dpranke@chromium.org>
699
700         Reviewed by Tony Chang.
701
702         new-run-webkit-tests: add first stub of test_runner2. This
703         will add support for the 'inline', 'threads', and 'processes'
704         flags to --worker-model, but for now the implementatios just
705         fall back on the old ones.
706
707         https://bugs.webkit.org/show_bug.cgi?id=53157
708
709         * Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
710         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
711
712 2011-02-01  Mihai Parparita  <mihaip@chromium.org>
713
714         Reviewed by James Robinson.
715
716         [Chromium] run-chromium-webkit-unit-tests looks for binaries in the wrong place
717         https://bugs.webkit.org/show_bug.cgi?id=53522
718
719         * Scripts/run-chromium-webkit-unit-tests:
720
721 2011-02-01  Adam Barth  <abarth@webkit.org>
722
723         Reviewed by Mihai Parparita.
724
725         Using Control-C to cancel webkit-patch or other python tools causes
726         unpleasant traceback console spew
727         https://bugs.webkit.org/show_bug.cgi?id=53462
728
729         Catch the exception and don't print the stack trace.
730
731         * Scripts/webkit-patch:
732
733 2011-02-01  Scott Cameron  <sccameron@rim.com>
734
735         Reviewed by Daniel Bates.
736
737         Use Windows format for MinGW HTTPD path.
738         https://bugs.webkit.org/show_bug.cgi?id=53503
739
740         * Scripts/webkitperl/httpd.pm:
741           - Use single-quotes around MySys value for $httpdPath in getHTTPDPath()
742             so that we don't have to escape the space characters in the path. Also,
743             changed path to Windows-style path and removed FIXME comment.
744
745 2011-02-01  Balazs Kelemen  <kbalazs@webkit.org>
746
747         Reviewed by Andreas Kling.
748
749         [Qt][WK2] Add a way to use shared process model in MiniBrowser
750         https://bugs.webkit.org/show_bug.cgi?id=53090
751
752         * MiniBrowser/qt/BrowserView.cpp:
753         (BrowserView::BrowserView): Removed the m_context member.
754         From now the context is guaranteed to be non-null and we
755         don't need to store that in the object.
756         * MiniBrowser/qt/BrowserView.h:
757         * MiniBrowser/qt/BrowserWindow.cpp:
758         Added static bool to determine that new windows need to be
759         created with their own context or not. Use the same context
760         and web process by default to be inilne with the other ports.
761         (BrowserWindow::BrowserWindow):
762         (BrowserWindow::newWindow):
763         * MiniBrowser/qt/BrowserWindow.h:
764         * MiniBrowser/qt/main.cpp:
765         (main): Added command line switch to be able to use the
766         non-shared process model. Simplify the handling of the command line
767         switches a little bit.
768
769 2011-02-01  Zoltan Horvath  <zoltan@webkit.org>
770
771         Reviewed by Andreas Kling.
772
773         [Qt] Add Window menu and Toggle FullScreen action to MiniBrowser.
774         https://bugs.webkit.org/show_bug.cgi?id=53491
775
776         * MiniBrowser/qt/BrowserWindow.cpp:
777         (BrowserWindow::BrowserWindow):
778         (BrowserWindow::toggleFullScreenMode):
779         * MiniBrowser/qt/BrowserWindow.h:
780
781 2011-02-01  Zoltan Horvath  <zoltan@webkit.org>
782
783         Reviewed by Andreas Kling.
784
785         [Qt] Add Toggle Frame Flattening, Auto Load Images and Disable JavaScript actions to MiniBrowser.
786         https://bugs.webkit.org/show_bug.cgi?id=53489
787
788         Add Toggle Frame Flattening action to Develop menu. Add Auto Load Images and Disable JavaScript actions
789         to Settings menu.
790
791         * MiniBrowser/qt/BrowserWindow.cpp:
792         (BrowserWindow::BrowserWindow):
793         (BrowserWindow::toggleFrameFlattening):
794         (BrowserWindow::toggleDisableJavaScript):
795         (BrowserWindow::toggleAutoLoadImages):
796         * MiniBrowser/qt/BrowserWindow.h:
797
798 2011-01-31  Mihai Parparita  <mihaip@chromium.org>
799
800         Reviewed by Tony Chang.
801
802         [Chromium] Switch chromium-mac to use ChromiumDriver
803         https://bugs.webkit.org/show_bug.cgi?id=53461
804         
805         For the sake of consistency with the other Chromium platforms (and so
806         that chromium-mac picks up special flags like --enable-hardware-gpu),
807         switch chromium-mac from the WebKitDriver to ChromiumDriver.
808
809         * Scripts/webkitpy/layout_tests/port/chromium.py:
810
811 2011-01-31  Dirk Pranke  <dpranke@chromium.org>
812
813         Reviewed by Mihai Parparita.
814
815         The current modifier parsing code in test_expectations is
816         fragile and hard-coded, so it's not easy to understand the logic
817         or easily add new types of modifiers (like GPU vs. CPU testing
818         for graphics tests, or 32-bit vs. 64-bit differences).
819
820         This is the first of two patches that will add in more generic
821         support and then eliminate the GPU-specific test expectations
822         files for Chromium.
823
824         This patch adds two standalone objects for handling modifiers. The
825         rules for interpreting modifiers, precedence, and conflicts are
826         given in the docstring to the ModifierMatcher class, which
827         returns ModifierMatchResult objects.
828         
829         This patch also adds routines to the Port interface and a
830         default set of values in the base object, in order to obtain the
831         values needed on a given test run. These values are then passed
832         to the expectation parser. This also allows us to clean up the
833         logic used to lint all of the different configurations in a
834         single test_expectations.txt file.
835
836         The next patch will merge in the separate GPU expectations file.
837
838         https://bugs.webkit.org/show_bug.cgi?id=51222
839
840         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
841         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
842         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
843         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
844         * Scripts/webkitpy/layout_tests/port/base.py:
845         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
846         * Scripts/webkitpy/layout_tests/port/chromium.py:
847         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
848         * Scripts/webkitpy/layout_tests/port/test.py:
849         * Scripts/webkitpy/layout_tests/port/webkit.py:
850         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
851         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
852         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
853         * Tools/Scripts/webkitpy/style/checkers/test_expectations.py:
854         * Tools/Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
855
856 2011-01-31  Scott Cameron  <sccameron@rim.com>
857
858         Reviewed by Daniel Bates.
859
860         update run-webkit-httpd to be able to launch Apache2.2 in a MSYS environment
861         https://bugs.webkit.org/show_bug.cgi?id=50036
862
863         This will add an Apache2.2 configuration file and modifies scripts to allow
864         running an httpd server in an MSYS environment.
865
866         The default Apache2.2 installation path has been preserved and PHP5 modules disabled
867         in order to allow for simple installation/execution.  Simply install the latest
868         Apache2.2 version with OpenSSL from http://httpd.apache.org/download.cgi#apache22 to
869         be able to execute run-webkit-httpd.
870         
871
872         * Scripts/run-webkit-httpd:
873         * Scripts/webkitperl/httpd.pm:
874
875 2011-01-31  Tony Chang  <tony@chromium.org>
876
877         Reviewed by Eric Seidel.
878
879         mac DRT should report RTL scroll offset relative to top right corner
880         https://bugs.webkit.org/show_bug.cgi?id=53324
881
882         * DumpRenderTree/mac/DumpRenderTree.mm:
883         (dumpFrameScrollPosition):
884
885 2011-01-31  Zoltan Horvath  <zoltan@webkit.org>
886
887         Reviewed by Andreas Kling.
888
889         [Qt] Add Take Screen Shot action to MiniBrowser
890         https://bugs.webkit.org/show_bug.cgi?id=53422
891
892         Add Take Screen Shot action to MiniBrowser's view menu.
893
894         * MiniBrowser/qt/BrowserWindow.cpp:
895         (BrowserWindow::BrowserWindow):
896         (BrowserWindow::screenshot):
897         * MiniBrowser/qt/BrowserWindow.h:
898
899 2011-01-31  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
900
901         Reviewed by Xan Lopez.
902
903         [GTK] REGRESSION:  http/tests/media/video-{cookie,referer}.html failing
904         https://bugs.webkit.org/show_bug.cgi?id=53379
905
906         Remove left over #ifdef's. I thought all of the conditional code
907         had been freed from the condition, but I forgot to check DRT.
908
909         * DumpRenderTree/gtk/DumpRenderTree.cpp:
910         (resetDefaultsToConsistentValues):
911         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
912         (LayoutTestController::setAlwaysAcceptCookies):
913
914 2011-01-30  Dirk Pranke  <dpranke@chromium.org>
915
916         Unreviewed, build fix.
917
918         Fix regression introduced in r77093 - path.rsplit() doesn't
919         take keyword arguments.
920
921         https://bugs.webkit.org/show_bug.cgi?id=53326
922
923         * Scripts/webkitpy/common/system/filesystem_mock.py:
924
925 2011-01-30  Dirk Pranke  <dpranke@chromium.org>
926
927         Reviewed by Mihai Parparita.
928
929         Add more unit tests for rebaseline-chromium-webkit-tests. This
930         change involves restructuring a bunch of r-c-w-t code to make it
931         more testable as well. We also add wrapper classes for handling
932         testing zip files and fetching URLs.
933
934         https://bugs.webkit.org/show_bug.cgi?id=53040
935
936         * Scripts/webkitpy/common/system/urlfetcher.py:
937         * Scripts/webkitpy/common/system/urlfetcher_mock.py:
938         * Scripts/webkitpy/common/system/zipfileset_mock.py:
939         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
940         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
941         * Scripts/webkitpy/tool/mocktool.py:
942
943 2011-01-30  Dirk Pranke  <dpranke@chromium.org>
944
945         Reviewed by Eric Seidel.
946
947         Clean up of the filesystem-related modules used in webkitpy.
948         I've added relpath() to the filesystem interface, modified
949         ospath.relpath() so that it could work with the filesystem
950         interface, and modified the fileset* routines to use the
951         filesystem interface consistently.
952
953         This patch also adds a close() routine to the fileset routines
954         to indicate that the caller is done with the fileset. This
955         allows zipfileset to clean up after itself when it creates
956         tempfiles to store downloads.
957
958         https://bugs.webkit.org/show_bug.cgi?id=53326
959
960         * Scripts/webkitpy/common/system/directoryfileset.py:
961         * Scripts/webkitpy/common/system/fileset.py:
962         * Scripts/webkitpy/common/system/filesystem.py:
963         * Scripts/webkitpy/common/system/filesystem_mock.py:
964         * Scripts/webkitpy/common/system/filesystem_unittest.py:
965         * Scripts/webkitpy/common/system/ospath.py:
966         * Scripts/webkitpy/common/system/zipfileset.py:
967         * Scripts/webkitpy/common/system/zipfileset_unittest.py:
968
969 2011-01-30  Balazs Kelemen  <kbalazs@webkit.org>
970
971         Reviewed by Csaba Osztrogonác.
972
973         [Qt][WK2]REGRESSION (r76991): Fix build errors
974         https://bugs.webkit.org/show_bug.cgi?id=53400
975
976         Revert the temporary build fix (http://trac.webkit.org/changeset/77088)
977         and remove WebKit2Prefix.h from the build.
978         * MiniBrowser/qt/MiniBrowser.pro:
979
980 2011-01-30  Csaba Osztrogonác  <ossy@webkit.org>
981
982         Unreviewed.
983
984         [Qt][WK2] Buildfix.
985
986         * MiniBrowser/qt/MiniBrowser.pro:
987
988 2011-01-28  Simon Fraser  <simon.fraser@apple.com>
989
990         Reviewed by Adam Roben.
991         
992         define NOMINMAX when building ImageDiff, as we do elsewhere.
993
994         Add various clampToInt() methods to MathExtras.h
995         https://bugs.webkit.org/show_bug.cgi?id=52910
996
997         * DumpRenderTree/win/ImageDiffCommon.vsprops:
998
999 2011-01-28  Maciej Stachowiak  <mjs@apple.com>
1000
1001         Reviewed by Darin Adler.
1002
1003         WebKitTestRunner needs layoutTestController.setPOSIXLocale
1004         https://bugs.webkit.org/show_bug.cgi?id=42682
1005
1006         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1007         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1008         (WTR::InjectedBundle::resetLocalSettings):
1009         (WTR::InjectedBundle::didReceiveMessage):
1010         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1011         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1012         (WTR::LayoutTestController::setPOSIXLocale):
1013         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1014
1015 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
1016  
1017          Reviewed by Mihai Parparita.
1018  
1019          test-webkitpy: fix webkitpy.layout_tests.port.mac_unittest.MacTest.test_skipped_file_paths
1020  
1021          This patch re-enables this test and changes it to
1022          handle all of the mac platform versions, not just the one
1023          it is running on.
1024  
1025          https://bugs.webkit.org/show_bug.cgi?id=53356
1026  
1027          * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1028  
1029 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
1030
1031         Unreviewed, build fix.
1032
1033         Take two. The fix in 77023 didn't work, because we were
1034         still calling path.abspath_to_uri, which calls _cygpath under
1035         the covers, and it appears the cygpath on the bots does
1036         something different than it does on my machine. This patch
1037         removes the calls to path.abspath_to_uri, so it should be safe.
1038         If it doesn't work, I'll roll it out along with r76982 and 77023.
1039
1040         https://bugs.webkit.org/show_bug.cgi?id=53126
1041
1042         * Scripts/webkitpy/layout_tests/port/test.py:
1043
1044 2011-01-28  David Kilzer  <ddkilzer@apple.com>
1045
1046         <rdar://problem/8930699> build-webkit gives a bogus warning with newer versions of Xcode 
1047         <http://webkit.org/b/53353>
1048
1049         Reviewed by Mark Rowe.
1050
1051         * Scripts/webkitdirs.pm:
1052         (checkRequiredSystemConfig): Check the Xcode marketing version
1053         in addition to the DevCoreTools build version before complaining
1054         about an old version of Xcode.  Also make the Mac OS X version
1055         check use Perl's built-in version string comparitor.
1056
1057 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
1058
1059         Unreviewed, build fix.
1060
1061         Work around breakage on Win 7 Release bot caused by r76982
1062         and the fact that windows ports use "file:////" instead of
1063         "file:///". Ideally the test code should be isolated from
1064         this, but it isn't yet. Will fix properly in a bit.
1065
1066         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
1067
1068 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
1069
1070         Reviewed by Tony Chang.
1071
1072         new-run-webkit-tests: change worker model values to
1073         "old-inline", "old-threads" in preparation for test_runner2 /
1074         multiprocessing changes.
1075
1076         https://bugs.webkit.org/show_bug.cgi?id=53156
1077
1078         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1079         * Scripts/webkitpy/layout_tests/port/base.py:
1080         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1081         * Scripts/webkitpy/layout_tests/port/mac.py:
1082         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1083
1084 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
1085
1086         Reviewed by Tony Chang.
1087
1088         committers.py - add an IRC nickname for dpranke
1089         https://bugs.webkit.org/show_bug.cgi?id=53335
1090
1091         * Scripts/webkitpy/common/config/committers.py:
1092
1093 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
1094
1095         Reviewed by Tony Chang.
1096
1097         new-run-webkit-tests: add a "mock DRT" port implementation
1098         and a separate class that emulates what we expect the
1099         DumpRenderTree behavior to be.
1100
1101         This will eventually replace port/dryrun.py and allow us to get
1102         better test coverage of the new-run-webkit-tests code as well as
1103         a reference for what new-run-webkit-tests expects from DRT.
1104
1105         This is the first attempt at this, and it is pretty bare-boned. It
1106         really only has been tested on the 'mac' port (and a little on
1107         the 'chromium-mac' port.
1108
1109         https://bugs.webkit.org/show_bug.cgi?id=53126
1110
1111         * Scripts/webkitpy/common/system/filesystem_mock.py:
1112         * Scripts/webkitpy/layout_tests/port/dryrun.py:
1113         * Scripts/webkitpy/layout_tests/port/factory.py:
1114         * Scripts/webkitpy/layout_tests/port/mock_drt.py: Added.
1115         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Added.
1116         * Scripts/webkitpy/layout_tests/port/test.py:
1117
1118 2011-01-28  Pratik Solanki  <psolanki@apple.com>
1119
1120         Unreviewed. Removing .swp file checked in by mistake.
1121
1122         * Scripts/.webkitdirs.pm.swp: Removed.
1123
1124 2011-01-28  Pratik Solanki  <psolanki@apple.com>
1125
1126         Reviewed by David Kilzer.
1127
1128         Space not necessary for undefined feature
1129         https://bugs.webkit.org/show_bug.cgi?id=53317
1130
1131         * Scripts/build-webkit:
1132
1133 2011-01-28  Chang Shu  <chang.shu@nokia.com>
1134
1135         Reviewed by Andreas Kling.
1136
1137         Reset NetworkAccessManager to clean up credentials from previous tests.
1138         This change causes no performance overhead either.
1139         https://bugs.webkit.org/show_bug.cgi?id=36688
1140
1141         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1142         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1143         (WebCore::DumpRenderTree::open):
1144         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1145
1146 2011-01-28  Zoltan Horvath  <zoltan@webkit.org>
1147
1148         Reviewed by Andreas Kling.
1149
1150         [Qt] Add Zoom Text Only action to MiniBrowser
1151         https://bugs.webkit.org/show_bug.cgi?id=53297
1152
1153         Add Zoom Text Only action to MiniBrowser's view menu, change zoom levels to avoid unnecessary divides.
1154
1155         * MiniBrowser/qt/BrowserWindow.cpp:
1156         (BrowserWindow::BrowserWindow):
1157         (BrowserWindow::zoomIn):
1158         (BrowserWindow::zoomOut):
1159         (BrowserWindow::resetZoom):
1160         (BrowserWindow::toggleZoomTextOnly):
1161         (BrowserWindow::applyZoom):
1162         * MiniBrowser/qt/BrowserWindow.h:
1163
1164 2011-01-28  Adam Barth  <abarth@webkit.org>
1165
1166         Reviewed by Eric Seidel.
1167
1168         Add webkit-patch roll-chromium-deps
1169         https://bugs.webkit.org/show_bug.cgi?id=53288
1170
1171         This command updates the Source/WebKit/chromium/DEPS file with the
1172         last-known good revision of Chromium (or a revision specified on the
1173         command line).  I'd eventually like to turn this into a SheriffBot
1174         command, but this is the first step.
1175
1176         This patch somewhat sprawled because I needed to move a bunch of code
1177         out of ChangeLog that should never have been there in the first place.
1178         Also, I had to fix a bug in MockUser in order to test the new command.
1179
1180         * Scripts/webkitpy/common/checkout/api.py:
1181         * Scripts/webkitpy/common/checkout/changelog.py:
1182         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1183         * Scripts/webkitpy/common/checkout/deps.py: Added.
1184         * Scripts/webkitpy/common/config/urls.py:
1185         * Scripts/webkitpy/tool/commands/__init__.py:
1186         * Scripts/webkitpy/tool/commands/download_unittest.py:
1187         * Scripts/webkitpy/tool/commands/roll.py: Added.
1188         * Scripts/webkitpy/tool/commands/roll_unittest.py: Added.
1189         * Scripts/webkitpy/tool/commands/upload_unittest.py:
1190         * Scripts/webkitpy/tool/mocktool.py:
1191         * Scripts/webkitpy/tool/steps/__init__.py:
1192         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py: Added.
1193         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
1194         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py: Added.
1195         * Scripts/webkitpy/tool/steps/suggestreviewers_unittest.py:
1196         * Scripts/webkitpy/tool/steps/updatechromiumdeps.py: Added.
1197         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
1198
1199 2011-01-27  Greg Coletta  <greg.coletta@nokia.com>
1200
1201         Reviewed by Laszlo Gombos.
1202
1203         Get rid of prefix header dependency for WebKit2 build system
1204         https://bugs.webkit.org/show_bug.cgi?id=50174
1205
1206         Change the style checker so that it enforces config.h include for
1207         WebKit2.
1208
1209         * Scripts/webkitpy/style/checker.py:
1210
1211 2011-01-27  Maciej Stachowiak  <mjs@apple.com>
1212
1213         Reviewed by Darin Adler.
1214
1215         execCommand("Paste") doesn't work in WebKitTestRunner
1216         https://bugs.webkit.org/show_bug.cgi?id=52785
1217
1218         Enable both of the settings needed to allow paste.
1219         
1220         * WebKitTestRunner/TestController.cpp:
1221         (WTR::TestController::resetStateToConsistentValues):
1222
1223 2011-01-27  Jacob Dinu  <dinu.jacob@nokia.com>
1224
1225         Reviewed by Andreas Kling.
1226
1227         [Qt] QtTestBrowser: User input lost when toggling use of QGraphicsView
1228         https://bugs.webkit.org/show_bug.cgi?id=48440
1229
1230         Preserve user input when toggling use of QGraphicsView
1231
1232         * QtTestBrowser/launcherwindow.cpp:
1233         (LauncherWindow::initializeView):
1234         (LauncherWindow::loadFinished):
1235         * QtTestBrowser/launcherwindow.h:
1236         * QtTestBrowser/mainwindow.cpp:
1237         (MainWindow::addressUrl):
1238         * QtTestBrowser/mainwindow.h:
1239
1240 2011-01-27  Dirk Pranke  <dpranke@chromium.org>
1241
1242         Reviewed by Mihai Parparita.
1243
1244         new-run-webkit-tests: turn off pixel tests correctly by default
1245         for webkit-based ports. r70013 (bug 47510) used
1246         port.set_option_default() to attempt to set default values, but
1247         that didn't work correctly. I have removed set_option_default
1248         for now since it was only being used in two places and in three
1249         useless unit tests. There is a separate bug open to fix the
1250         option parsing (48095), so this workaround is fine for now.
1251
1252         https://bugs.webkit.org/show_bug.cgi?id=53217
1253
1254         * Scripts/webkitpy/layout_tests/port/webkit.py:
1255         * Scripts/webkitpy/layout_tests/port/base.py:
1256         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1257
1258 2011-01-27  Balazs Kelemen  <kbalazs@webkit.org>
1259
1260         Rubber-stamped by Ariya Hidayat.
1261
1262         Trivial crash fix in WTR.
1263
1264         * WebKitTestRunner/TestController.cpp:
1265         (WTR::TestController::initialize): Increase the size
1266         of the vector by one to be able to store the null character.
1267
1268 2011-01-27  Balazs Kelemen  <kbalazs@webkit.org>
1269
1270         Reviewed by Csaba Osztrogonác.
1271
1272         [Qt][WK2] WTR should be initialized in the same way as DRT
1273         https://bugs.webkit.org/show_bug.cgi?id=53240
1274
1275         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
1276         (WTR::activateFonts): Added missing initialization steps.
1277
1278 2011-01-27  Joone Hur <joone.hur@collabora.co.uk>
1279
1280         Unreviewed. 
1281
1282         Adding myself to committers.py.
1283
1284         * Scripts/webkitpy/common/config/committers.py:
1285
1286 2011-01-27  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1287
1288         Reviewed by Csaba Osztrogonác.
1289
1290         [Qt] [Symbian] Move project files into Source
1291         https://bugs.webkit.org/show_bug.cgi?id=52891
1292
1293         Fix the Symbian build after the project files
1294         are moved to Source directory. On Symbian qmake
1295         needs to run in the same directory where the main
1296         pro files (WebKit.pro, Tools.pro) are located.
1297
1298         * Scripts/webkitdirs.pm: Change to the directory where the pro file
1299         is located before running qmake for Symbian. Qmake on Symbian
1300         does not properly honor the "-o" option, work it around by setting
1301         the name of the Makefile to bld.inf.
1302
1303 2011-01-27  Zoltan Horvath  <zoltan@webkit.org>
1304
1305         Reviewed by Andreas Kling.
1306
1307         [Qt] Add simple zooming features to MiniBrowser
1308         https://bugs.webkit.org/show_bug.cgi?id=53231
1309
1310         Add View menu and Zoom In, Zoom Out, Zoom Reset actions to MiniBrowser.
1311
1312         * MiniBrowser/qt/BrowserWindow.cpp:
1313         (BrowserWindow::BrowserWindow):
1314         (BrowserWindow::zoomIn):
1315         (BrowserWindow::zoomOut):
1316         (BrowserWindow::resetZoom):
1317         (BrowserWindow::updateUserAgentList):
1318         (BrowserWindow::applyZoom):
1319         * MiniBrowser/qt/BrowserWindow.h:
1320
1321 2011-01-26  Maciej Stachowiak  <mjs@apple.com>
1322
1323         Reviewed by Dan Bernstein.
1324
1325         WebKitTestRunner needs to support layoutTestController.evaluateInWebInspector
1326         https://bugs.webkit.org/show_bug.cgi?id=42319
1327         
1328         Add evaluateInWebInspector and other APIs needed for inspector tests to run.
1329
1330         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1331         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1332         (WTR::LayoutTestController::showWebInspector):
1333         (WTR::LayoutTestController::closeWebInspector):
1334         (WTR::LayoutTestController::evaluateInWebInspector):
1335         (WTR::LayoutTestController::setTimelineProfilingEnabled):
1336         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1337         * WebKitTestRunner/TestInvocation.cpp:
1338         (WTR::shouldOpenWebInspector):
1339         (WTR::TestInvocation::invoke):
1340         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
1341
1342 2011-01-26  Martin Robinson  <mrobinson@igalia.com>
1343
1344         Reviewed by Xan Lopez.
1345
1346         [GTK] Pixel dumps do not include scrollbars in output images
1347         https://bugs.webkit.org/show_bug.cgi?id=53216
1348
1349         Show scrollbars in pixel dumps. This will fix pixel dumps for tests
1350         that have scrollbars.
1351
1352         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
1353         (createBitmapContextFromWebView): Take the snapshot of the containing GtkScrolledWindow
1354         instead of the web view itself.
1355
1356 2011-01-26  Dirk Pranke  <dpranke@chromium.org>
1357
1358         Reviewed by Mihai Parparita.
1359
1360         Fix regression introduced in r76322 ... new-run-webkit-tests
1361         was attempting to save the image diff output as a UTF-8-encoded
1362         file.
1363
1364         https://bugs.webkit.org/show_bug.cgi?id=53210
1365
1366         * Scripts/webkitpy/layout_tests/port/webkit.py:
1367
1368 2011-01-26  Sheriff Bot  <webkit.review.bot@gmail.com>
1369
1370         Unreviewed, rolling out r76709.
1371         http://trac.webkit.org/changeset/76709
1372         https://bugs.webkit.org/show_bug.cgi?id=53194
1373
1374         "broke python tests on non-snowleopard platforms" (Requested
1375         by dpranke on #webkit).
1376
1377         * Scripts/webkitpy/layout_tests/port/factory.py:
1378         * Scripts/webkitpy/layout_tests/port/mock_drt.py: Removed.
1379         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Removed.
1380
1381 2011-01-26  Dirk Pranke  <dpranke@chromium.org>
1382
1383         Reviewed by Tony Chang.
1384
1385         new-run-webkit-tests: add a "mock DRT" port implementation
1386         and a separate class that emulates what we expect the
1387         DumpRenderTree behavior to be.
1388
1389         This will eventually replace port/dryrun.py and allow us to get
1390         better test coverage of the new-run-webkit-tests code as well as
1391         a reference for what new-run-webkit-tests expects from DRT.
1392
1393         This is the first attempt at this, and it is pretty bare-boned. It
1394         really only has been tested on the 'mac' port (and a little on
1395         the 'chromium-mac' port.
1396
1397         https://bugs.webkit.org/show_bug.cgi?id=53126
1398
1399         * Scripts/webkitpy/layout_tests/port/mock_drt.py: Added.
1400         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Added.
1401         * Scripts/webkitpy/layout_tests/port/factory.py:
1402
1403 2011-01-26  Xianzhu Wang  <wangxianzhu@google.com>
1404
1405         Reviewed by Tony Chang.
1406
1407         Add '--no-timeout' option to Chromium DRT to ease debugging.
1408         https://bugs.webkit.org/show_bug.cgi?id=52873
1409
1410         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1411         (main):
1412
1413 2011-01-26  Csaba Osztrogonác  <ossy@webkit.org>
1414
1415         Reviewed by Andreas Kling.
1416
1417         [Qt] Fix qt_minimal build
1418         https://bugs.webkit.org/show_bug.cgi?id=53172
1419
1420         * QtTestBrowser/locationedit.h:
1421
1422 2011-01-26  Mansi Mithal  <mansi.mithal@nokia.com>
1423
1424         Reviewed by Antonio Gomes.
1425
1426         QtTestBrowser should have a UI Setting to disable plugins
1427         https://bugs.webkit.org/show_bug.cgi?id=52408
1428         
1429         Added a new action item named "Disable Plugins"
1430         under the "Settings" menu. 
1431
1432         * QtTestBrowser/launcherwindow.cpp:
1433         (LauncherWindow::createChrome):
1434         (LauncherWindow::togglePlugins):
1435         * QtTestBrowser/launcherwindow.h:
1436
1437 2011-01-25  Patrick Gansterer  <paroga@webkit.org>
1438
1439         Reviewed by Adam Barth.
1440
1441         Move main CMakeLists.txt into Source directory
1442         https://bugs.webkit.org/show_bug.cgi?id=52888
1443
1444         * Scripts/webkitdirs.pm:
1445
1446 2011-01-25  Patrick Gansterer  <paroga@webkit.org>
1447
1448         Reviewed by Eric Seidel.
1449
1450         Improve label text in submit-to-ews
1451         https://bugs.webkit.org/show_bug.cgi?id=53130
1452
1453         * QueueStatusServer/templates/submittoews.html:
1454
1455 2011-01-25  Mansi Mithal  <mansi.mithal@nokia.com>
1456
1457         Reviewed by Antonio Gomes.
1458
1459         QtTestBrowser should have a UI Settings to prevent loading images
1460         https://bugs.webkit.org/show_bug.cgi?id=52409
1461         
1462         Added a new action item named "DisableAutoLoadImages"
1463         under the "Settings" menu 
1464
1465         * QtTestBrowser/launcherwindow.cpp:
1466         (LauncherWindow::createChrome):
1467         (LauncherWindow::toggleAutoLoadImages):
1468         * QtTestBrowser/launcherwindow.h:
1469
1470 2011-01-25  Dirk Pranke  <dpranke@chromium.org>
1471
1472         Reviewed by Tony Chang.
1473
1474         Minor bug fixes and cleanup for filesystem wrappers, port/* test
1475         classes, test_expectations.py. This change adds "test-win" and
1476         "test-mac" variants to the test port so that we can better test
1477         rebaselining, and adds a MockUser() object for reuse in testing.
1478
1479         https://bugs.webkit.org/show_bug.cgi?id=53036
1480
1481         * Scripts/webkitpy/common/system/filesystem.py:
1482         * Scripts/webkitpy/common/system/filesystem_mock.py:
1483         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1484         * Scripts/webkitpy/layout_tests/port/factory.py:
1485         * Scripts/webkitpy/layout_tests/port/base.py:
1486         * Scripts/webkitpy/layout_tests/port/test.py:
1487         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1488         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
1489         * Scripts/webkitpy/tool/mocktool.py:
1490
1491 2011-01-25  Tony Chang  <tony@chromium.org>
1492
1493         Reviewed by Dimitri Glazkov.
1494
1495         [chromium] remove unused layoutTestController callback
1496         https://bugs.webkit.org/show_bug.cgi?id=53103
1497
1498         This method is used by a test_shell_test, but not needed by DRT.
1499
1500         * DumpRenderTree/chromium/LayoutTestController.cpp:
1501         (LayoutTestController::LayoutTestController):
1502         * DumpRenderTree/chromium/LayoutTestController.h:
1503
1504 2011-01-25  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1505
1506         Reviewed by Andreas Kling.
1507
1508         [GTK] Remove 64 bits release bot from the buildbot master
1509         https://bugs.webkit.org/show_bug.cgi?id=52899
1510
1511         Removes the 64 bits release slave from the buildbot configuration,
1512         so that we can use it as an EWS.
1513
1514         * BuildSlaveSupport/build.webkit.org-config/config.json:
1515
1516 2011-01-24  Maciej Stachowiak  <mjs@apple.com>
1517
1518         Reviewed by Dan Bernstein.
1519
1520         Implement database quota callback to fix storage tests on WebKit2 bot
1521         https://bugs.webkit.org/show_bug.cgi?id=53064
1522
1523         * WebKitTestRunner/TestController.cpp:
1524         (WTR::exceededDatabaseQuota):
1525         (WTR::TestController::createOtherPage):
1526         (WTR::TestController::initialize):
1527
1528 2011-01-24  Maciej Stachowiak  <mjs@apple.com>
1529
1530         Reviewed by Anders Carlsson.
1531
1532         Use designated temp directory for the database for WebKit2
1533         https://bugs.webkit.org/show_bug.cgi?id=53052
1534         
1535         Adopt the new WK2 API for this.
1536
1537         * WebKitTestRunner/TestController.cpp:
1538         (WTR::TestController::libraryPathForTesting):
1539         (WTR::TestController::initialize):
1540         * WebKitTestRunner/TestController.h:
1541         * WebKitTestRunner/mac/TestControllerMac.mm:
1542         (WTR::TestController::platformLibraryPathForTesting):
1543         * WebKitTestRunner/qt/TestControllerQt.cpp:
1544         (WTR::TestController::platformLibraryPathForTesting):
1545         * WebKitTestRunner/win/TestControllerWin.cpp:
1546         (WTR::TestController::platformLibraryPathForTesting):
1547
1548 2011-01-24  Lucas Forschler  <lforschler@apple.com>
1549
1550         Reviewed by Stephanie Lewis.
1551
1552         Add a new Leopard test bot.
1553
1554         * BuildSlaveSupport/build.webkit.org-config/config.json:
1555
1556 2011-01-24  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1557
1558         Reviewed by Adam Barth.
1559
1560         Add EFL Builder to core waterfall
1561         https://bugs.webkit.org/show_bug.cgi?id=52704
1562
1563         Add EFL Builder to the core waterfall again.
1564
1565         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1566         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1567
1568 2011-01-24  Xianzhu Wang  <wangxianzhu@google.com>
1569
1570         Reviewed by Tony Chang.
1571
1572         new-run-webkit-tests fails to start HTTP server if there are proxy settings
1573         https://bugs.webkit.org/show_bug.cgi?id=52872
1574
1575         Force disabling proxy to resolve the problem.
1576
1577         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
1578         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
1579
1580 2011-01-24  Andreas Kling  <kling@webkit.org>
1581
1582         Reviewed by Darin Adler.
1583
1584         check-webkit-style: Update exemptions following Source/ move.
1585         https://bugs.webkit.org/show_bug.cgi?id=53017
1586
1587         * Scripts/webkitpy/style/checker.py:
1588         * Scripts/webkitpy/style/checker_unittest.py:
1589
1590 2011-01-24  Andras Becsi  <abecsi@webkit.org>
1591
1592         Rubber-stamped by Csaba Osztrogonác.
1593
1594         [Qt] Move project files into Source
1595         https://bugs.webkit.org/show_bug.cgi?id=52891
1596
1597         * DumpRenderTree/qt/ImageDiff.pro: Add missing "Source" to WebKit.pri path
1598
1599 2011-01-24  Mikhail Naganov  <mnaganov@chromium.org>
1600
1601         Reviewed by Yury Semikhatsky.
1602
1603         Web Inspector: Find duplicate strings in localizedStrings.js
1604
1605         https://bugs.webkit.org/show_bug.cgi?id=53005
1606
1607         * Scripts/check-inspector-strings:
1608
1609 2011-01-24  Zoltan Horvath  <zoltan@webkit.org>
1610
1611         Reviewed by Andreas Kling.
1612
1613         [Qt] Regroup MiniBrowser's menubar and add open file action
1614         https://bugs.webkit.org/show_bug.cgi?id=53000
1615
1616         Add File and Develop menu to MiniBrowser's menubar and add open file action to File menu.
1617
1618         * MiniBrowser/qt/BrowserWindow.cpp:
1619         (BrowserWindow::BrowserWindow):
1620         (BrowserWindow::openFile):
1621         (BrowserWindow::~BrowserWindow):
1622         * MiniBrowser/qt/BrowserWindow.h:
1623
1624 2011-01-24  Csaba Osztrogonác  <ossy@webkit.org>
1625
1626         Unreviewed fix after r76496
1627
1628         [Qt] Move project files into Source
1629         https://bugs.webkit.org/show_bug.cgi?id=52891
1630
1631         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Remove unnecessary "Source" from the path.
1632         * BuildSlaveSupport/built-product-archive: Remove unnecessary "Source" from the path.
1633         * Scripts/webkitdirs.pm: Add the accidentally removed slash to the path.
1634
1635 2011-01-24  Andras Becsi  <abecsi@webkit.org>
1636
1637         Reviewed by Csaba Osztrogonác.
1638
1639         [Qt] Move project files into Source
1640         https://bugs.webkit.org/show_bug.cgi?id=52891
1641
1642         * DerivedSources.pro: Renamed from DerivedSources.pro.
1643         * DumpRenderTree/qt/DumpRenderTree.pro:
1644         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1645         * MiniBrowser/DerivedSources.pro:
1646         * MiniBrowser/qt/MiniBrowser.pro:
1647         * QtTestBrowser/QtTestBrowser.pro:
1648         * Scripts/webkitdirs.pm:
1649         * Tools.pro: Added.
1650         * WebKitTestRunner/DerivedSources.pro:
1651         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1652         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1653
1654 2011-01-22  Geoffrey Garen  <ggaren@apple.com>
1655
1656         Reviewed by Dan Bernstein.
1657
1658         Beefed up --threaded mode to catch even more kinds of errors.
1659         https://bugs.webkit.org/show_bug.cgi?id=52971
1660
1661         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Use a shared
1662         context group to force JSC to mark multiple threads. (This used to be
1663         the default, but it changed in SnowLeopard.)
1664         (runJavaScriptThread): Do more locking and unlocking, and more allocation,
1665         to give threading mistakes more chances to show themselves.
1666         (startJavaScriptThreads):
1667         (stopJavaScriptThreads):
1668
1669 2011-01-22  Robert Hogan  <robert@webkit.org>
1670
1671         Reviewed by Andreas Kling.
1672
1673         [Qt] Support layoutTestController.addURLToRedirect()
1674         https://bugs.webkit.org/show_bug.cgi?id=52956
1675
1676         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1677         (LayoutTestController::addURLToRedirect):
1678         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1679
1680 2011-01-22  Robert Hogan  <robert@webkit.org>
1681
1682         Reviewed by Kenneth Rohde Christiansen.
1683
1684         [Qt] REGRESSION (r72360): http/tests/security/aboutBlank/xss-DENIED-* tests fail
1685         https://bugs.webkit.org/show_bug.cgi?id=49802
1686
1687         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1688         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1689         (WebCore::DumpRenderTree::open):
1690
1691 2011-01-21  Adam Barth  <abarth@webkit.org>
1692
1693         Reviewed by Maciej Stachowiak.
1694
1695         Disable mac_unittest.py that fails on some of the Mac bots
1696         https://bugs.webkit.org/show_bug.cgi?id=52947
1697
1698         As noted in the comment, this test does not appear to be correct
1699         because the function this test is testing returns different results
1700         depending on which flavor of Mac the test is run on.  This patch
1701         disable the test.  Hopefully we can re-enable the test once we've
1702         probably insulated the test from its environment.
1703
1704         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1705
1706 2011-01-21  Dirk Pranke  <dpranke@chromium.org>
1707
1708         Reviewed by Mihai Parparita.
1709
1710         Fix bug introduced in r76322 that caused NRWT to not actually
1711         read the Skipped files properly.
1712
1713         https://bugs.webkit.org/show_bug.cgi?id=52771
1714
1715         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1716         * Scripts/webkitpy/layout_tests/port/webkit.py:
1717         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1718
1719 2011-01-21  Sam Weinig  <sam@webkit.org>
1720
1721         Reviewed by Geoffrey Sean Garen and Mark Rowe.
1722
1723         WebKitTestRunner needs the HOME environment variable to be set.
1724         <rdar://problem/8896573>
1725
1726         * Scripts/old-run-webkit-tests: Set the HOME environment variable if
1727         it exists.
1728
1729 2011-01-21  Dirk Pranke  <dpranke@chromium.org>
1730
1731         Reviewed by Eric Seidel.
1732
1733         Suppress a few remaining integration tests so that none of the
1734         layout_test unit tests ever read from the filesystem or launch
1735         subprocesses that aren't part of the unit tests.
1736
1737         Also fix a minor bug in the printing unit tests that was
1738         incorrectly relying on sys.argv.
1739
1740         https://bugs.webkit.org/show_bug.cgi?id=52863
1741
1742         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1743         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1744         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1745
1746 2011-01-21  Darin Adler  <darin@apple.com>
1747
1748        Fix Mac build.
1749
1750         * MiniBrowser/mac/BrowserWindowController.m:
1751         (-[BrowserWindowController awakeFromNib]): Pass 0 for runModal function.
1752
1753 2011-01-20  Darin Adler  <darin@apple.com>
1754
1755         Reviewed by Dan Bernstein.
1756
1757         WebKit2: Implement showModalDialog
1758         https://bugs.webkit.org/show_bug.cgi?id=52855
1759
1760         This fixes WebKitTestRunner to compile, but more work is probably
1761         needed to get it to pass the tests.
1762
1763         * WebKitTestRunner/TestController.cpp:
1764         (WTR::TestController::runModal): Added. Calls through to the
1765         platform-specific version of runModal.
1766         (WTR::TestController::createOtherPage): Changed to be a private
1767         static member function so it can refer to runModal, which is
1768         a private static member function.
1769         (WTR::TestController::initialize): Pass 0 for the runModal
1770         function since we don't need to run the main window modal.
1771         I suspect this is wrong and will need to change.
1772         * WebKitTestRunner/TestController.h: Added declarations for
1773         the functions added above.
1774         * WebKitTestRunner/mac/TestControllerMac.mm:
1775         (WTR::TestController::runModal): Added. Untested implementation.
1776         * WebKitTestRunner/qt/TestControllerQt.cpp:
1777         (WTR::TestController::runModal): Added.
1778         * WebKitTestRunner/win/TestControllerWin.cpp:
1779         (WTR::TestController::runModal): Added.
1780
1781 2011-01-21  Eric Seidel  <eric@webkit.org>
1782
1783         Reviewed by Adam Barth.
1784
1785         Split Host object off from WebKitPatch for easier re-use
1786         https://bugs.webkit.org/show_bug.cgi?id=52284
1787
1788         new-run-webkit-tests and other tools are eventually going to want one of these.
1789         Basically you need to inherit from this class if you want to pretend to be a
1790         self.tool object for Steps/Commands.
1791
1792         * Scripts/webkitpy/common/host.py: Added.
1793         * Scripts/webkitpy/tool/main.py:
1794
1795 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1796
1797         Reviewed by Adam Barth.
1798
1799         Disable the tests that start and stop the http server and web
1800         server, so that we don't have to worry about port collisions on
1801         the bots.
1802
1803         https://bugs.webkit.org/show_bug.cgi?id=52861
1804
1805         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1806
1807 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1808
1809         Reviewed by Eric Seidel.
1810
1811         nrwt: rewrite google_chrome_unittest to use mock filesystem.
1812         
1813         https://bugs.webkit.org/show_bug.cgi?id=52772
1814         
1815         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
1816
1817 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1818
1819         Reviewed by Eric Siedel.
1820
1821         nrwt: clean up almost all remaining port references, remove
1822         unnecessary import clauses. The only remaining references are
1823         in places where a mock filesystem makes no sense or can't be
1824         used, and in one routine in port/google_chrome_unittest that
1825         I'll rewrite in a separate patch.
1826
1827         https://bugs.webkit.org/show_bug.cgi?id=52771
1828
1829         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1830         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1831         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1832         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1833         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1834         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1835         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1836         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
1837         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
1838         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
1839         * Scripts/webkitpy/layout_tests/port/gtk.py:
1840         * Scripts/webkitpy/layout_tests/port/mac.py:
1841         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1842         * Scripts/webkitpy/layout_tests/port/qt.py:
1843         * Scripts/webkitpy/layout_tests/port/webkit.py:
1844         * Scripts/webkitpy/layout_tests/port/win.py:
1845         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
1846
1847 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1848
1849         Reviewed by Mihai Parparita.
1850
1851         remove fs refs from run_webkit_tests, rebaseline_chromium_webkit_tests
1852
1853         https://bugs.webkit.org/show_bug.cgi?id=52762
1854
1855         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1856         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1857
1858 2011-01-20  Tony Chang  <tony@chromium.org>
1859
1860         Reviewed by Ojan Vafai.
1861
1862         [chromium] fix the paths used for the rebaseline tool
1863         https://bugs.webkit.org/show_bug.cgi?id=52857
1864
1865         Some of the bots were renamed so the path to grab the results zip
1866         file has changed.
1867
1868         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1869
1870 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1871
1872         Reviewed by Tony Chang.
1873
1874         Fix bug introduced in r72688 / bug 52768 that broke the
1875         generation of the output filename links in the results.html
1876         output. Apparently none of the unit tests actually checked to
1877         make sure the generated links were correct :(
1878
1879         https://bugs.webkit.org/show_bug.cgi?id=52854
1880
1881         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1882         * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
1883
1884 2011-01-20  Alexey Proskuryakov  <ap@apple.com>
1885
1886         Reviewed by Darin Adler.
1887
1888         https://bugs.webkit.org/show_bug.cgi?id=52849
1889         Make window.print work with WebKit2
1890
1891         * MiniBrowser/mac/BrowserWindowController.m:
1892         (-[BrowserWindowController awakeFromNib]):
1893         * WebKitTestRunner/TestController.cpp:
1894         (WTR::createOtherPage):
1895         (WTR::TestController::initialize):
1896         Added zeroes to WKPageUIClient structures to avoid build failures.
1897
1898 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1899
1900         Reviewed by Eric Seidel.
1901
1902         nrwt: remove fs refs from printing, test_failures, test_expectations, text_diff
1903
1904         https://bugs.webkit.org/show_bug.cgi?id=52756
1905
1906         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1907         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1908         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1909         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
1910         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1911         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
1912
1913 2011-01-20  Mansi Mithal  <mansi.mithal@nokia.com>
1914
1915         Reviewed by Antonio Gomes.
1916
1917         QtTestBrowser should have a seperate menu for Settings
1918         https://bugs.webkit.org/show_bug.cgi?id=52817
1919         
1920         Added a new menu item named "Settings"
1921         and moved the "Enable interrupting js scripts" and "Enable js pop up windows" under the "Settings" menu 
1922
1923         * QtTestBrowser/launcherwindow.cpp:
1924         (LauncherWindow::createChrome):
1925
1926 2011-01-20  Sam Weinig  <sam@webkit.org>
1927
1928         Reviewed by John Sullivan.
1929
1930         Update update-webkit-localizable-strings with new path to WebKit.
1931
1932         * Scripts/update-webkit-localizable-strings:
1933
1934 2011-01-20  James Robinson  <jamesr@chromium.org>
1935
1936         Reviewed by Darin Fisher.
1937
1938         Implement mozilla's requestAnimationFrame API
1939         https://bugs.webkit.org/show_bug.cgi?id=51218
1940
1941         Chromium DumpRenderTree support for window.webkitRequestAnimationFrame.
1942
1943         * DumpRenderTree/chromium/WebViewHost.cpp:
1944         (invokeScheduleComposite):
1945         (WebViewHost::scheduleAnimation):
1946         (WebViewHost::paintInvalidatedRegion):
1947         * DumpRenderTree/chromium/WebViewHost.h:
1948
1949 2011-01-20  Maciej Stachowiak  <mjs@apple.com>
1950
1951         Reviewed by Adam Roben.
1952
1953         WebKitTestRunner needs to support layoutTestController.evaluateScriptInIsolatedWorld
1954         https://bugs.webkit.org/show_bug.cgi?id=42327
1955
1956         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm: Add support
1957         for methods that take their normal arguments but also a JSContextRef.
1958         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: IDL definition
1959         for evaluateScriptInIsolatedWorld.
1960         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1961         (WTR::InjectedBundlePage::didClearWindowForFrame): Set a magic variable only if
1962         this call is for an isolated world.
1963         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1964         (WTR::worldMap): Helper to create a world map.
1965         (WTR::LayoutTestController::worldIDForWorld): Map from an ID to a world.
1966         (WTR::LayoutTestController::evaluateScriptInIsolatedWorld): The newly
1967         added LayoutTestController API.
1968         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1969
1970 2011-01-19  Adam Roben  <aroben@apple.com>
1971
1972         Convert paths in environment variables back to msys-style inside commit-log-editor
1973
1974         When this script gets run from inside git commit, msys-style paths in the environment will
1975         have been turned into Windows-style paths with forward slashes. This screws up functions
1976         like File::Spec->rel2abs, which seem to rely on $PWD having an msys-style path. We convert
1977         the paths back to msys-style before doing anything else.
1978
1979         Fixes <http://webkit.org/b/48527> commit-log-editor uses full paths for section headers when
1980         using msysgit's Perl and multiple ChangeLogs have been edited
1981
1982         Reviewed by David Kilzer.
1983
1984         * Scripts/commit-log-editor: Call fixEnvironment before doing anything else.
1985         (fixEnvironment): Added. When run in msys in conjunction with git (i.e., when invoked from
1986         inside git commit), convert Windows-style paths in the environment back to msys-style paths.
1987
1988 2011-01-20  Zoltan Horvath  <zoltan@webkit.org>
1989
1990         [Win] Unreviewed build fix after r76248.
1991
1992         * DumpRenderTree/ForwardingHeaders/wtf/FastAllocBase.h: Added.
1993
1994 2011-01-20  Zoltan Horvath  <zoltan@webkit.org>
1995
1996         Reviewed by Csaba Osztrogonác.
1997
1998         Refactoring of the custom allocation framework
1999         https://bugs.webkit.org/show_bug.cgi?id=49897
2000
2001         Inheriting from FastAllocBase can result in objects getting larger (bug #33896, #46589).
2002         The modification replaces Noncopyable and FastAllocBase classes and these inherits with their
2003         equivalent macro implementation at the necessary places.
2004 2011-01-20  Yi Shen  <yi.4.shen@nokia.com>
2005
2006         Unreviewed. 
2007
2008         Adding myself to committers.py.
2009
2010         * Scripts/webkitpy/common/config/committers.py:
2011
2012 2011-01-20  Adam Barth  <abarth@webkit.org>
2013
2014         Reviewed by Tony Chang.
2015
2016         Chromium builders don't delete unversioned directories when DEPS change
2017         https://bugs.webkit.org/show_bug.cgi?id=52745
2018
2019         If we pass this option to gclient sync, gclient will delete directories
2020         that are no longer part of DEPS instead of leaving them around to
2021         confuse us later.  Apparently, the downstream buildbots use this option
2022         already.
2023
2024         * Scripts/update-webkit-chromium:
2025
2026 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2027
2028         Unreviewed, build fix - I pulled this patch in to fix an issue
2029         revealed by r76195 running on some new bots). Also fix a couple
2030         of other issues revealed in testing.
2031
2032         nrwt: remove fs refs from layout_package/json*
2033
2034         https://bugs.webkit.org/show_bug.cgi?id=52754
2035
2036         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2037         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
2038         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
2039         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2040         * Scripts/webkitpy/layout_tests/port/base.py:
2041
2042 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2043
2044         Unreviewed, build fix.
2045
2046         Fix a couple of minor bugs discovered while bringing up new bots
2047         for testing.
2048
2049         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2050         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2051
2052 2011-01-19  James Robinson  <jamesr@chromium.org>
2053
2054         Unreviewed, rolling out r76194.
2055         http://trac.webkit.org/changeset/76194
2056         https://bugs.webkit.org/show_bug.cgi?id=51218
2057
2058         Caused mysterious compile failure on the chromium win
2059         build.webkit.org bots
2060
2061         * DumpRenderTree/chromium/WebViewHost.cpp:
2062         (WebViewHost::paintInvalidatedRegion):
2063         * DumpRenderTree/chromium/WebViewHost.h:
2064
2065 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2066
2067         Reviewed by Mihai Parparita.
2068
2069         remove fs refs from test_runner, dump_render_tree_thread
2070
2071         https://bugs.webkit.org/show_bug.cgi?id=52753
2072
2073         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2074         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2075         * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
2076         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2077
2078 2011-01-19  James Robinson  <jamesr@chromium.org>
2079
2080         Reviewed by Darin Fisher.
2081
2082         Implement mozilla's requestAnimationFrame API
2083         https://bugs.webkit.org/show_bug.cgi?id=51218
2084
2085         Chromium DumpRenderTree support for window.webkitRequestAnimationFrame.
2086
2087         * DumpRenderTree/chromium/WebViewHost.cpp:
2088         (invokeScheduleComposite):
2089         (WebViewHost::scheduleAnimation):
2090         (WebViewHost::paintInvalidatedRegion):
2091         * DumpRenderTree/chromium/WebViewHost.h:
2092
2093 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2094
2095         Unreviewed, build fix.
2096
2097         Fix a few incorrect "self._filesystem" references introduced in
2098         r76184.
2099
2100         * Scripts/webkitpy/layout_tests/port/chromium.py:
2101         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2102
2103 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2104
2105         Reviewed by Mihai Parparita.
2106
2107         add a .sep property, abspath(), isabs(), mtime(), and
2108         open_text_file_for_writing() to filesystem modules. Some of
2109         these properties are not needed in this patch but will be needed
2110         in subsequent patches (I'm doing this to avoid having to track
2111         multiple versions of a single file).
2112
2113         Also, change most of the port/* modules to use the filesystem
2114         objects instead of referencing the filesystem directly.
2115
2116         https://bugs.webkit.org/show_bug.cgi?id=52748
2117
2118         * Scripts/webkitpy/common/system/filesystem.py:
2119         * Scripts/webkitpy/common/system/filesystem_mock.py:
2120         * Scripts/webkitpy/layout_tests/port/__init__.py:
2121         * Scripts/webkitpy/layout_tests/port/base.py:
2122         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2123         * Scripts/webkitpy/layout_tests/port/chromium.py:
2124         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2125         * Scripts/webkitpy/layout_tests/port/config.py:
2126         * Scripts/webkitpy/layout_tests/port/test.py:
2127         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
2128
2129 2011-01-19  Maciej Stachowiak  <mjs@apple.com>
2130
2131         Reviewed by Anders Carlsson.
2132
2133         If resetting between tests times out, treat it as a WebProcess crash
2134         https://bugs.webkit.org/show_bug.cgi?id=52757
2135
2136         * WebKitTestRunner/TestController.cpp:
2137         (WTR::TestController::runTest):
2138
2139 2011-01-19  Alexey Proskuryakov  <ap@apple.com>
2140
2141         Reviewed by Darin Adler.
2142
2143         https://bugs.webkit.org/show_bug.cgi?id=52739
2144         Make it possible for a WebKit2 client to print headers and footers
2145
2146         Added dummy implementations for new printing UIClient calls.
2147
2148         * MiniBrowser/mac/BrowserWindowController.m:
2149         (-[BrowserWindowController awakeFromNib]):
2150         * WebKitTestRunner/TestController.cpp:
2151         (WTR::createOtherPage):
2152         (WTR::TestController::initialize):
2153
2154 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2155
2156         Reviewed by Ojan Vafai.
2157
2158         Change webkitpy/layout_tests/port/test.py to use the
2159         in-memory filesystem for cleaner unit testing. This
2160         change allows us to kill a lot of code that was
2161         specific to the test port, at the cost of being a
2162         little less clear about how things would work if
2163         you didn't have a filesystem.
2164
2165         https://bugs.webkit.org/show_bug.cgi?id=52605
2166
2167         * Scripts/webkitpy/layout_tests/port/test.py:
2168
2169 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2170
2171         Unreviewed, build fix.
2172
2173         Fix test failure caused by committing attachment 79368 instead
2174         of attachment 79461 on bug 52604.
2175
2176         * Scripts/webkitpy/common/system/filesystem_mock.py:
2177
2178 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2179
2180         Reviewed by Mihai Parparita.
2181
2182         new-run-webkit-tests: remove use of os.walk, use mock filesystem for better
2183         unit testing. os.walk() is too much of a hassle to implement on
2184         top of the in-memory mock filesystem and adding the necessary
2185         interface to files_under() gives clients a cleaner API anyway
2186         (for this particular usage model).
2187
2188         https://bugs.webkit.org/show_bug.cgi?id=52691
2189
2190         * Scripts/webkitpy/common/system/filesystem.py:
2191         * Scripts/webkitpy/common/system/filesystem_mock.py:
2192         * Scripts/webkitpy/layout_tests/port/test_files.py:
2193         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
2194
2195 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2196
2197         Reviewed by Tony Chang.
2198
2199         Change more modules in the layout-tests code to use the
2200         filesystem wrapper for cleaner unit testing.
2201
2202         This patch also adds the glob() wrapper to the filesystem
2203         abstraction.
2204         
2205         https://bugs.webkit.org/show_bug.cgi?id=52604
2206
2207         * Scripts/webkitpy/layout_tests/port/test_files.py:
2208         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
2209         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
2210         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2211         * Scripts/webkitpy/common/system/filesystem.py:
2212         * Scripts/webkitpy/common/system/filesystem_mock.py:
2213
2214 2011-01-19  Levi Weintraub  <leviw@chromium.org>
2215
2216         Unreviewed.
2217
2218         Updating my email addresses and irc nick.
2219
2220         * Scripts/webkitpy/common/config/committers.py:
2221
2222 2011-01-19  Tony Chang  <tony@chromium.org>
2223
2224         Reviewed by Mihai Parparita.
2225
2226         [chromium] [linux] if check-sys-deps fails, output the failure reason
2227         https://bugs.webkit.org/show_bug.cgi?id=52671
2228
2229         * Scripts/webkitpy/common/system/executive_mock.py: Add support for
2230             error handler functions.
2231         * Scripts/webkitpy/layout_tests/port/chromium.py:
2232             output the error text from --check-sys-deps
2233         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2234
2235 2011-01-19  Aparna Nandyal  <aparna.nand@wipro.com>
2236
2237         Reviewed by Andreas Kling.
2238
2239         [Qt] QtTestBrowser crashes when closing if Facebook is opened
2240         https://bugs.webkit.org/show_bug.cgi?id=52554
2241         
2242         QtNetworkAccessManager is created in a thread and set as
2243         member variable in QWebPage. When the thread is destroyed
2244         the object is still used. So fix will set the object to
2245         NULL once the thread is destroyed.
2246
2247         * QtTestBrowser/launcherwindow.cpp:
2248         (LauncherWindow::~LauncherWindow):
2249
2250 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
2251
2252         Rubber stamped by Csaba Osztrogonac
2253
2254         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: Removed unncessary inculde of WKStringCF.h
2255
2256 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
2257
2258         Reviewed by Tony Chang.
2259
2260         new-run-webkit-tests: add a --build-directory command line argument
2261
2262         Official Google Chrome builds use a non-standard build directory
2263         location. This patch adds a --build-directory argument that
2264         allows that location to be specified on the command line. Only
2265         Chromium-based builds will use this flag for now, but anyone can
2266         in the future.
2267
2268         There are no unit tests for this since it's difficult to test
2269         until mock filesystems are fully supported in the code. This was
2270         tested by hand for now.
2271
2272         https://bugs.webkit.org/show_bug.cgi?id=52694
2273
2274         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2275         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2276         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2277         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2278
2279 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
2280
2281         Not reviewed. Bot fix.
2282
2283         Remove an inadvertently committed debugging print.
2284
2285         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2286         (LayoutTestController::notifyDone):
2287
2288 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
2289
2290         Reviewed by Sam Weinig.
2291
2292         WebKitTestRunner should track loading more like DumpRenderTree
2293         https://bugs.webkit.org/show_bug.cgi?id=52692
2294
2295         Change load tracking to track the current top loading frame, in the manner of DumpRenderTree.
2296         This makes some tests that call notifyDone multiple times pass.
2297         
2298         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2299         (WTR::InjectedBundle::InjectedBundle):
2300         (WTR::InjectedBundle::done):
2301         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2302         (WTR::InjectedBundle::topLoadingFrame):
2303         (WTR::InjectedBundle::setTopLoadingFrame):
2304         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2305         (WTR::InjectedBundlePage::InjectedBundlePage):
2306         (WTR::InjectedBundlePage::stopLoading):
2307         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
2308         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
2309         (WTR::InjectedBundlePage::didFinishLoadForFrame):
2310         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
2311         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2312         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2313         (WTR::LayoutTestController::notifyDone):
2314         * WebKitTestRunner/TestController.cpp:
2315         (WTR::TestController::didReceiveMessageFromInjectedBundle):
2316
2317 2011-01-18  Mihai Parparita  <mihaip@chromium.org>
2318
2319         Reviewed by Kent Tamura.
2320
2321         [Chromium] NRWT looking for DRT binary in the wrong path on Mac
2322         https://bugs.webkit.org/show_bug.cgi?id=52678
2323         
2324         Update path now that WebKit is inside Source.
2325
2326         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2327
2328 2011-01-18  Robert Hogan  <robert@webkit.org>
2329
2330         Reviewed by Simon Hausmann.
2331
2332         [Qt] http/tests/incremental/slow-utf8-text.pl fails
2333         https://bugs.webkit.org/show_bug.cgi?id=44282
2334
2335         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2336         (WebCore::DumpRenderTree::dump):
2337
2338 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
2339
2340         Reviewed by Mihai Parparita.
2341
2342         Fix a small race condition that could cause the unit tests for
2343         new-run-webkit-tests to fail in a multithreaded environment.
2344         There was a small window in the code where one thread would
2345         check to see if a thread had raised an exception, do something,
2346         and then check to see if the thread was alive. If the other
2347         thread raised an exception and exited in between these two
2348         steps, the exception would be lost. Flipping the order of the
2349         two checks fixes the race, since we will now always check for an
2350         exception on the thread before exiting.
2351
2352         https://bugs.webkit.org/show_bug.cgi?id=51579
2353
2354         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
2355
2356 2011-01-18  Eric Seidel  <eric@webkit.org>
2357
2358         Reviewed by Adam Barth.
2359
2360         commit-queue dies when test archiving fails
2361         https://bugs.webkit.org/show_bug.cgi?id=52617
2362
2363         I looked at the machine and it had 10 archives already
2364         thus find_unused_name was returning None.  I've upped
2365         the limit to 100 (per bug) and tested the case where
2366         find_unused_name returns None (making archive return None).
2367
2368         * Scripts/webkitpy/common/system/workspace.py:
2369         * Scripts/webkitpy/common/system/workspace_unittest.py:
2370         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2371         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2372         * Scripts/webkitpy/tool/commands/queues.py:
2373
2374 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
2375
2376         Reviewed by Ojan Vafai.
2377
2378         Update rebaseline-chromium-webkit-tests unit tests to use a mock
2379         filesystem. Also fix a couple of "with" statements missed by
2380         r76050.
2381
2382         https://bugs.webkit.org/show_bug.cgi?id=52487
2383
2384         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
2385
2386 2011-01-18  Sergio Villar Senin  <svillar@igalia.com>
2387
2388         Reviewed by Martin Robinson.
2389
2390         [Gtk] Build fixes for gtk3 build
2391         https://bugs.webkit.org/show_bug.cgi?id=52648
2392
2393         * DumpRenderTree/gtk/EventSender.cpp:
2394         (beginDragWithFilesCallback):
2395
2396 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
2397
2398         Reviewed by Mihai Parparita.
2399
2400         Update rebaseline-chromium-webkit-tests to use filesystem objects
2401         instead of direct references to os.path, shutil, tempfile, etc.
2402
2403         This patch doesn't change anything, but will allow subsequent
2404         patches to change the unit tests to no longer use the real
2405         filesystem.
2406
2407         This patch adds a bunch more methods to the filesystem object as
2408         well.
2409
2410         https://bugs.webkit.org/show_bug.cgi?id=52482
2411
2412         * Scripts/webkitpy/common/system/filesystem.py:
2413         * Scripts/webkitpy/common/system/filesystem_mock.py:
2414         * Scripts/webkitpy/tool/commands/queues.py:
2415         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2416         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
2417
2418 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
2419
2420         Reviewed by Mihai Parparita.
2421
2422         new-run-webkit-tests shouldn't crash when you try to run a
2423         directory containing only skipped files.
2424
2425         https://bugs.webkit.org/show_bug.cgi?id=52478
2426         
2427         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2428         * Scripts/webkitpy/layout_tests/port/test.py:
2429         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2430
2431 2011-01-18  Adam Bergkvist  <adam.bergkvist@ericsson.com> and Martin Robinson  <mrobinson@igalia.com>
2432
2433         Reviewed by Gustavo Noronha Silva.
2434
2435         [GTK] The GTK+ EventSender needs support for beginDragWithFiles
2436         https://bugs.webkit.org/show_bug.cgi?id=40833
2437
2438         * DumpRenderTree/gtk/EventSender.cpp: Add a beginDragWithFiles implementation for the
2439         GTK+ event sender.
2440         (dragWithFilesDragDataGetCallback): Added.
2441         (dragWithFilesDragEndCallback): Added.
2442         (beginDragWithFilesCallback): Added.
2443
2444 2011-01-18  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2445
2446         Reviewed by Adam Barth.
2447
2448         ews: Add additional watcher to efl ews
2449         https://bugs.webkit.org/show_bug.cgi?id=52613
2450
2451         Add gyuyoung.kim@samsung.com to watcher list of efl-ews.
2452
2453         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2454
2455 2011-01-17  Tony Gentilcore  <tonyg@chromium.org>
2456
2457         Reviewed by Alexey Proskuryakov.
2458
2459         Fix some headers with missing or misspelled #ifndef guards
2460         https://bugs.webkit.org/show_bug.cgi?id=52545
2461
2462         * DumpRenderTree/chromium/TestEventPrinter.h:
2463         * DumpRenderTree/chromium/WebPreferences.h:
2464
2465 2011-01-17  Jessie Berlin  <jberlin@apple.com>
2466
2467         Reviewed by Anders Carlsson.
2468
2469         REGRESSION: Assertion failure in FrameLoader::continueLoadAfterWillSubmitForm() when
2470         navigating back to an unreachable URL
2471         https://bugs.webkit.org/show_bug.cgi?id=52388
2472
2473         Add a third parameter (unreachableURL) to queueLoadHTMLString.
2474
2475         * DumpRenderTree/LayoutTestController.cpp:
2476         (queueLoadHTMLStringCallback):
2477         (LayoutTestController::queueLoadHTMLString):
2478         (LayoutTestController::queueLoadAlternateHTMLString):
2479         * DumpRenderTree/LayoutTestController.h:
2480
2481         * DumpRenderTree/WorkQueueItem.h:
2482         (LoadHTMLStringItem::LoadHTMLStringItem):
2483
2484         * DumpRenderTree/chromium/LayoutTestController.cpp:
2485         (WorkItemLoadHTMLString::WorkItemLoadHTMLString):
2486         (WorkItemLoadHTMLString::run):
2487         (LayoutTestController::queueLoadHTMLString):
2488
2489         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
2490         (LoadHTMLStringItem::invoke):
2491         * DumpRenderTree/mac/WorkQueueItemMac.mm:
2492         (LoadHTMLStringItem::invoke):
2493         * DumpRenderTree/win/WorkQueueItemWin.cpp:
2494         (LoadHTMLStringItem::invoke):
2495
2496 2011-01-17  Dan Bernstein  <mitz@apple.com>
2497
2498         Rubber-stamped by Mark Rowe.
2499
2500         Update xcodeproj svn:ignore to include xcuserdata.
2501
2502         * DumpRenderTree/DumpRenderTree.xcodeproj: Modified property svn:ignore.
2503         * MiniBrowser/MiniBrowser.xcodeproj: Modified property svn:ignore.
2504         * TestWebKitAPI/TestWebKitAPI.xcodeproj: Modified property svn:ignore.
2505         * WebKitLauncher/WebKitLauncher.xcodeproj: Modified property svn:ignore.
2506         * WebKitTestRunner/WebKitTestRunner.xcodeproj: Modified property svn:ignore.
2507
2508 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
2509
2510         Unreviewed fix after r75908.
2511
2512         Move WebKit into Source
2513         https://bugs.webkit.org/show_bug.cgi?id=52530
2514
2515         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add Source to the path for Qt API tests.
2516
2517 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
2518
2519         Unreviewed.
2520
2521         Remove accidentally committed debug printing after r75908.
2522
2523         * Scripts/webkitdirs.pm:
2524
2525 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
2526
2527         Unreviewed.
2528
2529         Add myself to committers list
2530         https://bugs.webkit.org/show_bug.cgi?id=52566
2531
2532         * Scripts/webkitpy/common/config/committers.py:
2533
2534 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
2535
2536         Reviewed by Jeremy Orlow.
2537
2538         GeolocationController should call stopUpdating on destruction
2539         https://bugs.webkit.org/show_bug.cgi?id=52216
2540
2541         fast/dom/Geolocation/window-close-crash.html requires that a
2542         Geolocation watch be started in a secondary window. Consequently,
2543         we need to allow geolocation permission and provide a mock
2544         geolocation position for the secondary window's
2545         GeolocationClientMock.
2546
2547         * DumpRenderTree/chromium/LayoutTestController.cpp:
2548         (LayoutTestController::setGeolocationPermission):
2549         (LayoutTestController::setMockGeolocationPosition):
2550         (LayoutTestController::setMockGeolocationError):
2551         * DumpRenderTree/chromium/TestShell.h:
2552         (TestShell::windowList):
2553
2554 2011-01-16  Adam Barth  <abarth@webkit.org>
2555
2556         Update more include paths to reflect WebKit move.
2557
2558         * DumpRenderTree/chromium/EventSender.cpp:
2559         (EventSender::keyDown):
2560         (EventSender::needsShiftModifier):
2561         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
2562         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
2563
2564 2011-01-16  Kent Tamura  <tkent@chromium.org>
2565
2566         Unreviewed, Chromium build fix.
2567
2568         * Scripts/update-webkit-chromium: Webkit/chromium -> Source/WebKit/chromium
2569
2570 2011-01-16  Martin Robinson  <mrobinson@igalia.com>
2571
2572         Build fix for GTK+ after source directory movement.
2573
2574         * GNUmakefile.am: Correct include paths.
2575
2576 2011-01-16  Adam Barth  <abarth@webkit.org>
2577
2578         Teach svn-apply about WebKit move.
2579
2580         * Scripts/VCSUtils.pm:
2581
2582 2011-01-16  Adam Barth  <abarth@webkit.org>
2583
2584         Rubber-stamped by Eric Seidel.
2585
2586         Move WebKit into Source
2587         https://bugs.webkit.org/show_bug.cgi?id=52530
2588
2589         * DumpRenderTree/mac/InternalHeaders/WebKit/WebTypesInternal.h:
2590         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2591         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2592         * DumpRenderTree/qt/GCControllerQt.cpp:
2593         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2594         * DumpRenderTree/qt/PlainTextControllerQt.cpp:
2595         * DumpRenderTree/qt/TextInputControllerQt.cpp:
2596         * DumpRenderTree/wscript:
2597         * QtTestBrowser/launcherwindow.h:
2598         * Scripts/build-webkit:
2599         * Scripts/webkitdirs.pm:
2600
2601 2011-01-15  Adam Barth  <abarth@webkit.org>
2602
2603         Teach svn-apply about WebKit2 move.
2604
2605         * Scripts/VCSUtils.pm:
2606
2607 2011-01-15  Adam Barth  <abarth@webkit.org>
2608
2609         Rubber-stamped by Eric Seidel.
2610
2611         Move WebKit2 into Source
2612         https://bugs.webkit.org/show_bug.cgi?id=52438
2613
2614         * MiniBrowser/qt/MiniBrowser.pro:
2615         * Scripts/build-webkit:
2616         * Scripts/do-file-rename:
2617         * Scripts/do-webcore-rename:
2618         * Scripts/test-webkitpy:
2619         * Scripts/webkitdirs.pm:
2620         * Scripts/webkitpy/style/checker.py:
2621         * WebKitTestRunner/DerivedSources.pro:
2622         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2623         * WebKitTestRunner/qt/WebKitTestRunner.pro:
2624
2625 2011-01-15  Jochen Eisinger  <jochen@chromium.org>
2626
2627         Reviewed by David Levin.
2628
2629         [chromium] remove obsolete createView method
2630         https://bugs.webkit.org/show_bug.cgi?id=52437
2631
2632         * DumpRenderTree/chromium/WebViewHost.cpp:
2633         (WebViewHost::createView):
2634         * DumpRenderTree/chromium/WebViewHost.h:
2635
2636 2011-01-14  Brian Weinstein  <bweinstein@apple.com>
2637
2638         Reviewed by Geoff Garen.
2639
2640         ShouldLoadResourceForFrame should use strings, not URLs.
2641         https://bugs.webkit.org/show_bug.cgi?id=52476
2642
2643         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2644         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Update to use a WKStringRef.
2645         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2646
2647 2011-01-14  Tony Gentilcore  <tonyg@chromium.org>
2648
2649         Reviewed by David Levin.
2650
2651         Add Tony Gentilcore as a reviewer
2652         https://bugs.webkit.org/show_bug.cgi?id=52480
2653
2654         * Scripts/webkitpy/common/config/committers.py:
2655
2656 2011-01-14  David Levin  <levin@chromium.org>
2657
2658         Reviewed by Eric Seidel.
2659
2660         check-webkit-style: _FunctionState should keep track of where the function name starts.
2661         https://bugs.webkit.org/show_bug.cgi?id=52454
2662
2663         * Scripts/webkitpy/style/checkers/cpp.py: Added function_name_start_position to
2664         _FunctionState and logic for setting it correctly.
2665         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests.
2666
2667 2011-01-14  Vincent Scheib  <scheib@chromium.org>
2668
2669         Reviewed by David Levin.
2670
2671         Add support to DumpRenderTree to use the GPU rather than software renderer
2672         https://bugs.webkit.org/show_bug.cgi?id=52333
2673
2674         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2675         (main):
2676         * Scripts/webkitpy/layout_tests/port/chromium.py:
2677         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2678
2679 2011-01-14  Tony Chang  <tony@chromium.org>
2680
2681         Reviewed by Kent Tamura.
2682
2683         [chromium] update fonts.conf to fix 6 linux tests in drt
2684         https://bugs.webkit.org/show_bug.cgi?id=52411
2685
2686         * DumpRenderTree/chromium/fonts.conf: Update to match the copy in
2687             chromium's src/webkit/tools/test_shell/resources/fonts.conf
2688
2689 2011-01-14  Eric Seidel  <eric@webkit.org>
2690
2691         Original patch from Peter Gal  <galpater@inf.u-szeged.hu>
2692
2693         Reviewed by Adam Barth.
2694
2695         Fix when running Tools/Scripts/check-webkit-style without arguments.
2696         https://bugs.webkit.org/show_bug.cgi?id=52261#c16
2697
2698         * Scripts/webkitpy/common/checkout/scm.py: Handle None for changed_files argument better in Git.create_patch method.
2699         * Scripts/webkitpy/common/checkout/scm_unittest.py:
2700
2701 2011-01-04  Jochen Eisinger  <jochen@chromium.org>
2702
2703         Reviewed by David Levin.
2704
2705         Store the tempdir object in a variable so it doesn't get deleted too early.
2706         https://bugs.webkit.org/show_bug.cgi?id=51875
2707
2708         * Scripts/update-webkit-auxiliary-libs:
2709         * Scripts/update-webkit-support-libs:
2710
2711 2011-01-14  Eric Seidel  <eric@webkit.org>
2712
2713         Unreviewed.  Make it work in python 2.5.
2714
2715         webkit-patch suggest-reviewers dies when ChangeLogs are missing
2716         https://bugs.webkit.org/show_bug.cgi?id=49158
2717
2718         * Scripts/webkitpy/common/checkout/api_unittest.py:
2719
2720 2011-01-14  Sheriff Bot  <webkit.review.bot@gmail.com>
2721
2722         Unreviewed, rolling out r75774.
2723         http://trac.webkit.org/changeset/75774
2724         https://bugs.webkit.org/show_bug.cgi?id=52431
2725
2726         gtk builds were broken (Requested by loislo2 on #webkit).
2727
2728         * Scripts/webkitpy/common/checkout/scm.py:
2729
2730 2011-01-14  David Levin  <levin@chromium.org>
2731
2732         Reviewed by Shinichiro Hamaji.
2733
2734         check-webkit-style: _FunctionState should detect pure functions.
2735         https://bugs.webkit.org/show_bug.cgi?id=52428
2736
2737         * Scripts/webkitpy/style/checkers/cpp.py: Added detection for if a function declaration
2738         is a pure virtual function.
2739         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests for verifying that pure
2740         virtual functions are correctly detected.
2741
2742 2011-01-13  Ilya Tikhonovsky  <loislo@chromium.org>
2743
2744         Reviewed by Yury Semikhatsky.
2745
2746         Just small fix for problem with check-webkit-style.
2747         It just didn't work for this patch.
2748         Old code can't concatenate a list of strings with None.
2749
2750         * Scripts/webkitpy/common/checkout/scm.py:
2751
2752 2011-01-13  David Levin  <levin@chromium.org>
2753
2754         Reviewed by Shinichiro Hamaji.
2755
2756         check-webkit-style: _FunctionState should use Position to know where items are.
2757         https://bugs.webkit.org/show_bug.cgi?id=52424
2758
2759         * Scripts/webkitpy/style/checkers/cpp.py:
2760         (_FunctionState.*): Changed _FunctionState to use Position instead of line numbers.
2761         (detect_functions): Changed to pass Position's to _FunctionState.begin and
2762         did some minor clean-up.
2763         (*): Other changes are simply about converting to use the Position's in_FunctionState
2764         instead of line numbers.
2765         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Changed the test code
2766         to verify the positions stored in _FunctionState.
2767
2768 2011-01-13  Eric Seidel  <eric@webkit.org>
2769
2770         Reviewed by David Levin.
2771
2772         webkit-patch suggest-reviewers dies when ChangeLogs are missing
2773         https://bugs.webkit.org/show_bug.cgi?id=49158
2774
2775         This is not the most elegant, but it is a very safe fix to this bug.
2776         One advantage of catching ScriptError like this instead of adding a
2777         new added_or_modified_files or fixing all changed_files callers
2778         to use a more specific change_files variant, is that we catch
2779         all kinds of ScriptErrors which might cause our (non-essential)
2780         suggest-reviewers code to fail out.  This should make passing
2781         --suggest-reviewers to webkit-patch upload much more robust
2782         and may even make it possible for us to make it default.
2783
2784         The root of the problem here is that SCM.changed_files includes
2785         deleted ChangeLog paths (from moves, etc) which then when we ask
2786         SVN/Git for the contents of the file at that revision, the command
2787         errors out and Executive.run_command raises a ScriptError.
2788
2789         In the future we might fix this differently by making all current
2790         callers of chagned_files use a more specific method for requesting
2791         what types of changes they're interested in (adds, modifies, deletes, etc.)
2792
2793         * Scripts/webkitpy/common/checkout/api.py:
2794         * Scripts/webkitpy/common/checkout/api_unittest.py:
2795
2796 2011-01-13  Dan Bernstein  <mitz@apple.com>
2797
2798         Reviewed by Alexey Proskuryakov.
2799
2800         <rdar://problem/8827065> REGRESSION (r71884): Cross-origin XHR fails if willSendRequest changes the URL
2801         https://bugs.webkit.org/show_bug.cgi?id=52419
2802
2803         Allow to further control the behavior of the willSendRequest delegate callback by making it
2804         set a different URL in the new request.
2805
2806         * DumpRenderTree/LayoutTestController.cpp:
2807         (addURLToRedirectCallback): Added.
2808         (LayoutTestController::staticFunctions): Added addURLToRedirect.
2809         (LayoutTestController::addURLToRedirect): Added. Adds the redirection to the map.
2810         (LayoutTestController::redirectionDestinationForURL): Added this getter.
2811         * DumpRenderTree/LayoutTestController.h:
2812         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2813         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]): Check
2814         if there is a redirection for the request’s URL, established by addURLToRedirect(), and if so,
2815         change the URL in the new request to the redirect destination.
2816
2817 2011-01-13  Eric Seidel  <eric@webkit.org>
2818
2819         Reviewed by Mihai Parparita.
2820
2821         webkit-patch suggest-reviewers fails due to invalid utf8 in ChangeLog files
2822         https://bugs.webkit.org/show_bug.cgi?id=52416
2823
2824         Example: webkit-patch suggest-reviewers -g ca3890fe74d94d85d6bfa48f9ea497b094d8e717 
2825         UnicodeDecodeError: 'utf8' codec can't decode bytes in position 536-538: invalid data
2826
2827         I also added FIXMEs about the changed_files returning deleted files problem
2828         which is causing the other most common exception for suggest-reviewers
2829         (and is probably breaking sheriff-bots blame detection).
2830
2831         * Scripts/webkitpy/common/checkout/api.py:
2832         * Scripts/webkitpy/common/checkout/api_unittest.py:
2833         * Scripts/webkitpy/common/checkout/scm.py:
2834
2835 2011-01-13  Eric Seidel  <eric@webkit.org>
2836
2837         Reviewed by Adam Barth.
2838
2839         results archives from commit-queue are too large to upload
2840         https://bugs.webkit.org/show_bug.cgi?id=52405
2841
2842         * Scripts/webkitpy/common/system/filesystem.py:
2843         * Scripts/webkitpy/common/system/filesystem_mock.py:
2844         * Scripts/webkitpy/tool/commands/queues.py:
2845
2846 2011-01-13  Alejandro G. Castro  <alex@igalia.com>
2847
2848         Reviewed by Martin Robinson.
2849
2850         [gtk] Zero-sized font does not yet work
2851         https://bugs.webkit.org/show_bug.cgi?id=49793
2852
2853         Set minimum-font-size to 0 for the DRT.
2854
2855         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2856         (resetDefaultsToConsistentValues):
2857
2858 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
2859
2860         Reviewed by Darin Adler.
2861
2862         Make old-run-webkit-tests more robust on buildbots
2863         https://bugs.webkit.org/show_bug.cgi?id=52364
2864
2865         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Pass --exit-after-n-failures 500 to old-run-webkit-tests script.
2866
2867 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
2868
2869         Reviewed by Darin Adler.
2870
2871         Make old-run-webkit-tests more robust on buildbots
2872         https://bugs.webkit.org/show_bug.cgi?id=52364
2873
2874         * Scripts/old-run-webkit-tests: Ensure that testResultsDirectory is empty.
2875
2876 2011-01-13  Tony Chang  <tony@chromium.org>
2877
2878         Reviewed by Kent Tamura.
2879
2880         [chromium] fix plugins/plugin-javascript-access.html on Linux and Mac
2881         https://bugs.webkit.org/show_bug.cgi?id=52332
2882
2883         Forked Info.plist is not longer needed.
2884
2885         * DumpRenderTree/chromium/TestNetscapePlugIn/Info.plist: Removed.
2886
2887 2011-01-13  Mikhail Naganov  <mnaganov@chromium.org>
2888
2889         Reviewed by Timothy Hatcher.
2890
2891         Web Inspector: Cleanup after r75613 -- make all UI-facing strings
2892         to be passed directly to WebInspector.UIString
2893
2894         https://bugs.webkit.org/show_bug.cgi?id=52365
2895
2896         * Scripts/check-inspector-strings:
2897
2898 2011-01-13  Sheriff Bot  <webkit.review.bot@gmail.com>
2899
2900         Unreviewed, rolling out r74881.
2901         http://trac.webkit.org/changeset/74881
2902         https://bugs.webkit.org/show_bug.cgi?id=52357
2903
2904         The EFL builder has been red for days (Requested by abarth on
2905         #webkit).
2906
2907         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2908         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2909
2910 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
2911
2912         Reviewed by David Levin.
2913
2914         Add beforeunload support to WebKitTestRunner
2915         https://bugs.webkit.org/show_bug.cgi?id=52353
2916         
2917         This makes a number of currently failing tests pass.
2918
2919         * WebKitTestRunner/TestController.cpp:
2920         (WTR::runBeforeUnloadConfirmPanel):
2921         (WTR::createOtherPage):
2922         (WTR::TestController::initialize):
2923
2924 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
2925
2926         Reviewed by Sam Weinig.
2927
2928         Detect, identify and recover from WebProcess crashes in run-webkit-tests
2929         https://bugs.webkit.org/show_bug.cgi?id=52330
2930
2931         * Scripts/old-run-webkit-tests: Detect when the regression test tool reports
2932         a web process crash.
2933         * WebKitTestRunner/TestController.cpp:
2934         (WTR::TestController::initialize): Set up a processDidCrash
2935         callback.
2936         (WTR::TestController::processDidCrash): Report that the Web process
2937         crashed.
2938         * WebKitTestRunner/TestController.h:
2939
2940 2011-01-12  David Levin  <levin@chromium.org>
2941
2942         Reviewed by Shinichiro Hamaji.
2943
2944         check-webkit-style -- close_expression function doesn't work correctly.
2945         https://bugs.webkit.org/show_bug.cgi?id=52272
2946
2947         * Scripts/webkitpy/style/checkers/cpp.py:
2948         (Position.__str__): Added a way to convert it to a string which is useful in tests.
2949         (Position.__cmp__): Added a way to compare Position which is useful in tests and
2950         generally useful (for upcoming code changes).
2951         (close_expression): Changed to use Position for input and output.
2952         Also, fixed many bugs such as only working correctly for parenthesis,
2953         not working correctly if given an offset in a line and not finding
2954         the real closing element if there were multiple closing elements in
2955         the same line.
2956         (detect_functions): Adjusted due to the change in arguments for
2957         close_expression.
2958         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2959         (CppStyleTestBase.assert_positions_equal): Added a way to verify that
2960         two positions are the same.
2961         (CppStyleTest.test_position): Added tests for the __str_ and __cmp__ methods.
2962         (CppStyleTest.test_close_expression): Added tests to catch the issues
2963         that were fixed.
2964
2965 2011-01-12  Sheriff Bot  <webkit.review.bot@gmail.com>
2966
2967         Unreviewed, rolling out r75576.
2968         http://trac.webkit.org/changeset/75576
2969         https://bugs.webkit.org/show_bug.cgi?id=52304
2970
2971         broke rebaseline-chromium-webkit-test (Requested by thakis on
2972         #webkit).
2973
2974         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2975         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2976         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
2977         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2978         * Scripts/webkitpy/layout_tests/port/base.py:
2979         * Scripts/webkitpy/layout_tests/port/chromium.py:
2980         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2981         * Scripts/webkitpy/layout_tests/port/test.py:
2982         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2983         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2984         * Scripts/webkitpy/style/checkers/test_expectations.py:
2985         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
2986
2987 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
2988
2989         Reviewed by Darin Adler.
2990
2991         Add a no-build option to run-webkit-tests, to avoid building DRT/WKTR
2992         https://bugs.webkit.org/show_bug.cgi?id=52307
2993
2994         * Scripts/old-run-webkit-tests:
2995
2996 2011-01-12  Koan-Sin Tan  <koansin.tan@gmail.com>
2997
2998         Reviewed by Martin Robinson.
2999
3000         [Gtk] WebKitGtk+ doesn't build on Mac OS X 10.6
3001         https://bugs.webkit.org/show_bug.cgi?id=50867
3002
3003         Fixed library extention for Mac in webkitdirs.pm and type conflict in
3004         TestNetscapePlugin.cpp 
3005
3006         * GNUmakefile.am: Don't use AppKit when compiling TestNetscapePlugin for GTK+
3007         * Scripts/webkitdirs.pm:
3008
3009 2011-01-12  Mikhail Naganov  <mnaganov@chromium.org>
3010
3011         Reviewed by Pavel Feldman.
3012
3013         Add check-inspector-strings script.
3014
3015         https://bugs.webkit.org/show_bug.cgi?id=52295
3016
3017         * Scripts/check-inspector-strings: Added.
3018
3019 2011-01-12  Adam Roben  <aroben@apple.com>
3020
3021         Advertise the .testnetscape file extension on Windows
3022
3023         Fixes <http://webkit.org/b/52298>
3024         plugins/no-mime-with-valid-extension.html fails on Windows
3025
3026         Reviewed by Dan Bernstein.
3027
3028         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Added a
3029         FileExtents field to map the .testnetscape file extension to the
3030         application/x-webkit-test-netscape MIME type, just as we do on Mac.
3031
3032 2011-01-12  Adam Barth  <abarth@webkit.org>
3033
3034         Reviewed by Eric Seidel.
3035
3036         Make webkit-patch support subdirectories for SVN checkouts
3037         https://bugs.webkit.org/show_bug.cgi?id=52261
3038
3039         os.relpath does not exist on Python 2.5, so we need to call our version
3040         of the API.
3041
3042         * Scripts/webkitpy/common/checkout/scm.py:
3043
3044 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
3045
3046         Reviewed by Eric Seidel.
3047
3048         Close additional pages opened during a test once the test completes.
3049         https://bugs.webkit.org/show_bug.cgi?id=52276
3050
3051         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3052         (WTR::InjectedBundle::done):
3053
3054 2011-01-11  David Levin  <levin@chromium.org>
3055
3056         Reviewed by Eric Seidel.
3057
3058         Errors should be separated from the command line in bot messages.
3059         https://bugs.webkit.org/show_bug.cgi?id=52275
3060
3061         * Scripts/webkitpy/common/system/executive.py:
3062         (ScriptError.message_with_output): Added a newline to separate the command
3063         line from the errors.
3064         * Scripts/webkitpy/common/system/executive_unittest.py:
3065         (ScriptErrorTest.test_message_with_output): Added tests for the various code
3066         paths in message_with_output.
3067
3068 2011-01-11  Eric Seidel  <eric@webkit.org>
3069
3070         Unreviewed.
3071
3072         commit-queue should know how to upload archived results (for test flakes or general failures)
3073         https://bugs.webkit.org/show_bug.cgi?id=52048
3074
3075         The zips are mostly empty due to forgetting -r.
3076         Expected diffs were not being pulled from the archive due
3077         to the archive having longer paths than I realized.
3078
3079         * Scripts/webkitpy/common/system/workspace.py:
3080         * Scripts/webkitpy/common/system/workspace_unittest.py:
3081         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3082         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3083
3084 2011-01-11  Dirk Pranke  <dpranke@chromium.org>
3085
3086         Reviewed by Ojan Vafai.
3087
3088         The current modifier parsing code in test_expectations is
3089         fragile and hard-coded, so it's not easy to understand the logic
3090         or easily add new types of modifiers (like GPU vs. CPU testing
3091         for graphics tests, or 32-bit vs. 64-bit differences).
3092
3093         This is the first of two patches that will add in more generic
3094         support and then eliminate the GPU-specific test expectations
3095         files for Chromium.
3096
3097         This patch adds two standalone objects for handling modifiers. The
3098         rules for interpreting modifiers, precedence, and conflicts are
3099         given in the docstring to the ModifierMatcher class, which
3100         returns ModifierMatchResult objects.
3101         
3102         This patch also adds routines to the Port interface and a
3103         default set of values in the base object, in order to obtain the
3104         values needed on a given test run. These values are then passed
3105         to the expectation parser. This also allows us to clean up the
3106         logic used to lint all of the different configurations in a
3107         single test_expectations.txt file.
3108
3109         The next patch will merge in the separate GPU expectations file.
3110
3111         https://bugs.webkit.org/show_bug.cgi?id=51222
3112
3113         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
3114         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
3115         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
3116         * Scripts/webkitpy/layout_tests/port/base.py:
3117         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3118         * Scripts/webkitpy/layout_tests/port/chromium.py:
3119         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3120         * Scripts/webkitpy/layout_tests/port/test.py:
3121         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3122         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3123
3124 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
3125
3126         Reviewed by Adam Barth.
3127
3128         Make webkit-patch support subdirectories for SVN checkouts
3129         https://bugs.webkit.org/show_bug.cgi?id=52261
3130
3131         * Scripts/webkitpy/common/checkout/scm.py:
3132         * Scripts/webkitpy/style_references.py:
3133         * Scripts/webkitpy/tool/main.py:
3134         * Scripts/webkitpy/tool/steps/preparechangelog.py:
3135
3136 2011-01-11  Eric Seidel  <eric@webkit.org>
3137
3138         Unreviewed.
3139
3140         commit-queue should know how to upload archived results (for test flakes or general failures)
3141         https://bugs.webkit.org/show_bug.cgi?id=52048
3142
3143         I changed the API for archive_last_layout_test_results w/o updating the implementation.  Oops.
3144         This fixes an exception seen on the commit-queue when attempting to report flaky tests.
3145
3146         * Scripts/webkitpy/common/system/workspace.py:
3147         * Scripts/webkitpy/common/system/workspace_unittest.py:
3148         * Scripts/webkitpy/tool/commands/queues.py:
3149
3150 2011-01-11  Sam Weinig  <sam@webkit.org>
3151
3152         Roll r75474 back in.
3153
3154 2011-01-11  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
3155
3156         Reviewed by Kenneth Rohde Christiansen.
3157
3158         [Qt] Remove uses of QFuture since it isn't supported on all platforms.
3159         https://bugs.webkit.org/show_bug.cgi?id=51204
3160
3161         * QtTestBrowser/webpage.h:
3162         (QtNAMThread::QtNAMThread):
3163         (QtNAMThread::networkAccessManager):
3164         (QtNAMThread::run):
3165
3166 2011-01-11  Peter Varga  <pvarga@webkit.org>
3167
3168         Unreviewed.
3169
3170         Add myself to committers' list.
3171
3172         * Scripts/webkitpy/common/config/committers.py:
3173
3174 2011-01-11  Eric Seidel  <eric@webkit.org>
3175
3176         Reviewed by Adam Barth.
3177
3178         commit-queue should know how to upload archived results (for test flakes or general failures)
3179         https://bugs.webkit.org/show_bug.cgi?id=52048
3180
3181         Now the queue will always upload results.  Either the entire zip, or just
3182         the diffs.txt in the case of text failures.
3183
3184         This should make understanding flakes much easier, and paves the way
3185         for having the EWS run layout tests (and upload failures).
3186
3187         In order to upload .zip files I had to teach bugzilla.py to autodetect
3188         mime types from the filename.  Since mimetypes.py doesn't include a mapping
3189         for .patch files, I have it add one before calling guess_type.
3190
3191         We may find that always uploading the whole zip instead of just the -diffs.txt
3192         file is preferable, but for now I'm keeping the old behavior because it makes
3193         quickly understanding text failures easy.
3194
3195         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3196         * Scripts/webkitpy/common/system/workspace.py: Added.
3197         * Scripts/webkitpy/common/system/workspace_unittest.py: Added.
3198         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3199         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3200         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3201         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3202         * Scripts/webkitpy/tool/commands/queues.py:
3203         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3204
3205 2011-01-10  Sheriff Bot  <webkit.review.bot@gmail.com>
3206
3207         Unreviewed, rolling out r75464.
3208         http://trac.webkit.org/changeset/75464
3209         https://bugs.webkit.org/show_bug.cgi?id=52193
3210
3211         Followup rollout for 75474 (Requested by Ossy on #webkit).
3212
3213         * MiniBrowser/mac/BrowserWindowController.m:
3214         (-[BrowserWindowController awakeFromNib]):
3215         * MiniBrowser/win/BrowserView.cpp:
3216         (BrowserView::create):
3217         * WebKitTestRunner/TestController.cpp:
3218         (WTR::createOtherPage):
3219         (WTR::TestController::initialize):
3220
3221 2011-01-10  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3222
3223         Reviewed by Csaba Osztrogonác.
3224
3225         [Qt] Baseline qt_minimal configuration
3226         https://bugs.webkit.org/show_bug.cgi?id=51313
3227
3228         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3229         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): Add
3230         QT_NO_UNDOSTACK guard.
3231
3232         * QtTestBrowser/launcherwindow.cpp:
3233         (LauncherWindow::createChrome): Add QT_NO_SHORTCUT and QT_NO_PRINTER
3234         guards.
3235         (LauncherWindow::applyZoom): Add QT_NO_ANIMATION guard.
3236         (LauncherWindow::screenshot): Add QT_NO_FILEDIALOG guard.
3237         (LauncherWindow::selectElements): Add QT_NO_INPUTDIALOG guard.
3238         (LauncherWindow::showUserAgentDialog): Add QT_NO_COMBOBOX guard.
3239
3240         * QtTestBrowser/launcherwindow.h:
3241         * QtTestBrowser/locationedit.cpp: Add QT_NO_INPUTDIALOG guard.
3242         * QtTestBrowser/locationedit.h: Ditto.
3243
3244         * QtTestBrowser/mainwindow.cpp:
3245         (MainWindow::buildUI): Add QT_NO_INPUTDIALOG, QT_NO_SHORTCUT and
3246         QT_NO_UNDOSTACK guards.
3247         (MainWindow::setAddressUrl): Add QT_NO_INPUTDIALOG guard.
3248         (MainWindow::changeLocation): Ditto.
3249         (MainWindow::openFile): Add QT_NO_FILEDIALOG guard.
3250         (MainWindow::openLocation): Add QT_NO_INPUTDIALOG guard.
3251
3252         * QtTestBrowser/webpage.cpp:
3253         (WebPage::openUrlInDefaultBrowser): Add QT_NO_DESKTOPSERVICES guard.
3254         (WebPage::authenticationRequired): Add QT_NO_LINEEDIT guard.
3255
3256         * QtTestBrowser/webview.cpp:
3257         (WebViewGraphicsBased::animatedFlip): Add QT_NO_ANIMATION guard.
3258         (WebViewGraphicsBased::animatedYFlip): Ditto.
3259
3260 2011-01-10  Sam Weinig  <sam@webkit.org>
3261
3262         Fix build.
3263
3264         * MiniBrowser/mac/BrowserWindowController.m:
3265         (-[BrowserWindowController awakeFromNib]):
3266         * MiniBrowser/win/BrowserView.cpp:
3267         (BrowserView::create):
3268         * WebKitTestRunner/TestController.cpp:
3269         (WTR::createOtherPage):
3270         (WTR::TestController::initialize):
3271
3272 2011-01-10  Eric Seidel  <eric@webkit.org>
3273
3274         Reviewed by Ojan Vafai.
3275
3276         style-queue messages are way too long for big patches
3277         https://bugs.webkit.org/show_bug.cgi?id=52161
3278
3279         We definitely could build much fancier list-to-string-with-limit functions
3280         but this should be sufficient for our needs at the moment.
3281
3282         * Scripts/webkitpy/common/system/executive.py:
3283         * Scripts/webkitpy/common/system/executive_unittest.py:
3284
3285 2011-01-10  Tony Chang  <tony@chromium.org>
3286
3287         Unreviewed, rolling out r75398.
3288         http://trac.webkit.org/changeset/75398
3289         https://bugs.webkit.org/show_bug.cgi?id=52008
3290
3291         Some layout tests are crashing on Chromium Win.
3292
3293         * DumpRenderTree/chromium/WebViewHost.cpp:
3294         (WebViewHost::updatePaintRect):
3295         * DumpRenderTree/chromium/WebViewHost.h:
3296
3297 2011-01-10  Adam Roben  <aroben@apple.com>
3298
3299         Roll out r75392
3300
3301         It isn't needed now that r75289 has been rolled out.
3302
3303         * Scripts/run-javascriptcore-tests:
3304
3305 2011-01-10  Maciej Stachowiak  <mjs@apple.com>
3306
3307         Reviewed by Anders Carlsson.
3308
3309         WebKitTestRunner uses crazy amounts of CPU, making layout tests slow and flaky
3310         https://bugs.webkit.org/show_bug.cgi?id=52160
3311
3312         * WebKitTestRunner/mac/TestControllerMac.mm:
3313         (WTR::TestController::platformRunUntil): Instead of busy-looping, wait for the timeout.
3314         Anything that can make runUntil() conditions turn true will happen on a run loop cycle
3315         anyway.
3316
3317 2011-01-10  Tony Chang  <tony@chromium.org>
3318
3319         Reviewed by Mihai Parparita.
3320
3321         [chromium] fix for animated gif layout tests
3322         https://bugs.webkit.org/show_bug.cgi?id=52008
3323
3324         * DumpRenderTree/chromium/WebViewHost.cpp: Schedule a paint when we update the paint rect
3325             to trigger gif animations.
3326         (WebViewHostPaintTask::WebViewHostPaintTask):
3327         (WebViewHostPaintTask::runIfValid):
3328         (WebViewHost::updatePaintRect):
3329         * DumpRenderTree/chromium/WebViewHost.h:
3330         (WebViewHost::taskList):
3331
3332 2011-01-10  Alejandro G. Castro  <alex@igalia.com>
3333
3334         Reviewed by Xan Lopez.
3335
3336         [GTK] Fix gtk2 compilation for master
3337         https://bugs.webkit.org/show_bug.cgi?id=51885
3338
3339         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
3340         (createBitmapContextFromWebView): Replaced the old
3341         gdk_drawable_get_size with gdk_pixmap_get_size.
3342
3343 2011-01-10  Patrick Gansterer  <paroga@webkit.org>
3344
3345         Reviewed by Laszlo Gombos.
3346
3347         [WINCE] Reenable NPAPI after r75203
3348         https://bugs.webkit.org/show_bug.cgi?id=52109
3349
3350         Remove the !isWinCE() check for ENABLE_NETSCAPE_PLUGIN_API and replace
3351         it with !isEfl(), because EFL port does not support NPAPI (yet).
3352
3353         * Scripts/build-webkit:
3354
3355 2011-01-10  Adam Roben  <aroben@apple.com>
3356
3357         Skip some asserting JS tests
3358
3359         See <http://webkit.org/b/52156>.
3360
3361         * Scripts/run-javascriptcore-tests:
3362
3363 2011-01-10  Martin Robinson  <mrobinson@igalia.com>
3364
3365         Reviewed by Xan Lopez.
3366
3367         [GTK] build-webkit disable Blob support via arguments passed to automake
3368         https://bugs.webkit.org/show_bug.cgi?id=52097
3369
3370         * Scripts/build-webkit: Enable Blob support when building WebKitGTK+ via
3371         build-webkit.
3372
3373 2011-01-10  Adam Roben  <aroben@apple.com>
3374
3375         Use the same name and description for TestNetscapePlugin on Windows and
3376         Mac
3377
3378         Fixes <http://webkit.org/b/52151>
3379         fast/frames/iframe-reparenting-plugins.html fails on Windows
3380
3381         Reviewed by Steve Falkenburg.
3382
3383         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Copied
3384         the name and description from Mac's Info.plist.
3385
3386 2011-01-10  Siddharth Mathur <siddharth.mathur@nokia.com>
3387
3388         Reviewed by Laszlo Gombos.
3389
3390         [Qt][WK2] Guard gcc-specific syntax
3391
3392         Non-gcc based compliers choke on the "-include"
3393         syntax for preinclude, place guard around it.
3394
3395         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3396         * WebKitTestRunner/qt/WebKitTestRunner.pro:
3397
3398 2011-01-10  Andreas Kling  <kling@webkit.org>
3399
3400         Reviewed by Simon Hausmann.
3401
3402         [Qt] [WK2] MiniBrowser does not load pages opened in new windows
3403         https://bugs.webkit.org/show_bug.cgi?id=52111
3404
3405         When getting a createNewPage() callback from QWKPage, create the
3406         new page with the same QWKContext as the page that is passed to
3407         the callback.
3408
3409         * MiniBrowser/qt/BrowserView.h:
3410         * MiniBrowser/qt/BrowserWindow.cpp:
3411         (newPageFunction):
3412         (BrowserWindow::BrowserWindow):
3413         * MiniBrowser/qt/BrowserWindow.h:
3414
3415 2011-01-10  Andreas Kling  <kling@webkit.org>
3416
3417         Reviewed by Kenneth Rohde Christiansen.
3418
3419         [Qt] MiniBrowser: Remove superfluous createNewPage() callback
3420
3421         BrowserView set its own useless createNewPage() callback on QWKPage.
3422         This was immediately overridden by BrowserWindow anyway, so remove
3423         the BrowserView one.
3424
3425         * MiniBrowser/qt/BrowserView.cpp:
3426         (BrowserView::BrowserView):
3427
3428 2011-01-10  John Knottenbelt  <jknotten@chromium.org>
3429
3430         Reviewed by Jeremy Orlow.
3431
3432         [Chromium] Remove non-client-based Geolocation code
3433         https://bugs.webkit.org/show_bug.cgi?id=50921
3434
3435         * DumpRenderTree/chromium/LayoutTestController.cpp:
3436         (LayoutTestController::setGeolocationPermission):
3437         (LayoutTestController::setMockGeolocationPosition):
3438         (LayoutTestController::setMockGeolocationError):
3439         * DumpRenderTree/chromium/WebViewHost.cpp:
3440         (WebViewHost::geolocationClientMock):
3441         (WebViewHost::reset):
3442         * DumpRenderTree/chromium/WebViewHost.h:
3443
3444 2011-01-10  Eric Seidel  <eric@webkit.org>
3445
3446         Reviewed by Adam Barth.
3447
3448         Commit bot tried to land r? cq+ patch
3449         https://bugs.webkit.org/show_bug.cgi?id=36638
3450
3451         It should now be possible to post a patch with r? and cq+ and the
3452         commit-queue will correctly wait for the r+ before attempting to land the patch.
3453         (This was a feature requested by several users.)
3454
3455         One caveat: We don't actually reject r-, cq+ patches from the queue
3456         (we just ignore them), but I think that's OK for now.
3457
3458         I also noticed that setting r- once a commit-queue node had grabbed
3459         a patch would not properly cancel the landing.  That's fixed and
3460         tested in this patch.
3461
3462         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3463         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3464         * Scripts/webkitpy/tool/bot/feeders.py:
3465         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
3466
3467 2011-01-08  Benjamin Poulain  <benjamin.poulain@nokia.com>
3468
3469         Reviewed by Kenneth Rohde Christiansen.
3470
3471         [Qt] QtWebKit crashes when using XMLHttpRequest from the unload event
3472         https://bugs.webkit.org/show_bug.cgi?id=51934
3473
3474         When accessing the network from the destructor of QWebPage, the network access manager
3475         was already deleted because the object WebPage was already destructed.
3476
3477         This solve the problem by linking the lifetime of the network access manager to WebPage's QObject.
3478         The object is now destructed in the destructor of QObject.
3479
3480         * QtTestBrowser/webpage.cpp:
3481         (WebPage::WebPage):
3482         (WebPage::setQnamThreaded):
3483         * QtTestBrowser/webpage.h:
3484         (QtNAMThread::QtNAMThread):
3485
3486 2011-01-08  Eric Seidel  <eric@webkit.org>
3487
3488         Reviewed by Ojan Vafai.
3489
3490         test_failures.py should not mention TestShell (long live DumpRenderTree!)
3491         https://bugs.webkit.org/show_bug.cgi?id=52067
3492
3493         I ran test-webkitpy, but didn't bother adding a unit test for this string change.
3494         https://bugs.webkit.org/show_bug.cgi?id=51138#c3 is an example of why this is needed.
3495
3496         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
3497
3498 2011-01-08  Eric Seidel  <eric@webkit.org>
3499
3500         Reviewed by Mihai Parparita.
3501
3502         commit-queue hangs when the ChangeLog diff is bad
3503         https://bugs.webkit.org/show_bug.cgi?id=52072
3504
3505         * Scripts/webkitpy/tool/steps/validatechangelogs.py:
3506         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
3507
3508 2011-01-08  Adam Barth  <abarth@webkit.org>
3509
3510         Teach svn-apply how to re-write WebCore to Source/WebCore.
3511
3512         * Scripts/VCSUtils.pm:
3513
3514 2011-01-07  Adam Barth  <abarth@webkit.org>
3515
3516         Rubber-stamped by Eric Seidel.
3517
3518         Move WebCore to Source
3519         https://bugs.webkit.org/show_bug.cgi?id=52050
3520
3521         Update the tools to understand WebCore's new location.
3522
3523         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3524         * DumpRenderTree/wscript:
3525         * GNUmakefile.am:
3526         * Scripts/build-webkit:
3527         * Scripts/do-file-rename:
3528         * Scripts/do-webcore-rename:
3529         * Scripts/generate-qt-inspector-resource:
3530         * Scripts/prepare-ChangeLog:
3531         * Scripts/run-bindings-tests:
3532         * Scripts/update-iexploder-cssproperties:
3533         * Scripts/update-sources-list.py:
3534         * Scripts/update-webkit-localizable-strings:
3535         * Scripts/webkitdirs.pm:
3536         * Scripts/webkitpy/common/config/build.py:
3537         * Scripts/webkitpy/common/config/build_unittest.py:
3538         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
3539         * Scripts/webkitpy/style/checker.py:
3540         * Scripts/webkitpy/style/checker_unittest.py:
3541         * WebKitTestRunner/DerivedSources.pro:
3542         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3543         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh:
3544         * wx/browser/wscript:
3545         * wx/build/settings.py:
3546
3547 2011-01-07  Maciej Stachowiak  <mjs@apple.com>
3548
3549         Reviewed by Sam Weinig.
3550
3551         Make WebKitTestRunner rest between loads more robust to avoid test crashes
3552         https://bugs.webkit.org/show_bug.cgi?id=52086
3553
3554         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3555         (WTR::InjectedBundle::didReceiveMessage):
3556         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3557         (WTR::LayoutTestController::notifyDone):
3558         * WebKitTestRunner/TestController.cpp:
3559         (WTR::TestController::resetStateToConsistentValues):
3560         (WTR::TestController::run):
3561
3562 2011-01-07  James Robinson  <jamesr@chromium.org>
3563
3564         Revert "Implement mozilla's animationTime property"
3565         https://bugs.webkit.org/show_bug.cgi?id=51952
3566
3567         This approach isn't quite right.
3568
3569         * DumpRenderTree/chromium/WebViewHost.cpp:
3570         (WebViewHost::paintInvalidatedRegion):
3571
3572 2011-01-07  Adam Roben  <aroben@apple.com>
3573
3574         Build master fix
3575
3576         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3577         (RunWebKitTests.start): Don't try to concatenate a list and a string.
3578
3579 2011-01-07  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>
3580
3581         Reviewed by Csaba Osztrogonác.
3582
3583         run-qtwebkit-tests should be able to kill a testsuite.
3584
3585         Add new option in the script that can setup a timeout for a test.
3586         If the test execution takes more then specified time then the test
3587         would be terminated.
3588
3589         [Qt] run-qtwebkit-tests needs timeout
3590         https://bugs.webkit.org/show_bug.cgi?id=51894
3591
3592         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3593         * Scripts/run-qtwebkit-tests:
3594
3595 2011-01-07  Csaba Osztrogonác  <ossy@webkit.org>
3596
3597         Unreviewed fix after r75233.
3598
3599         Based on idea from Eric Seidel.
3600
3601         Add remote zip file handling to webkitpy.
3602         https://bugs.webkit.org/show_bug.cgi?id=50901
3603
3604         * Scripts/webkitpy/common/system/fileset.py: Make python 2.5 happy.
3605
3606 2011-01-07  Shane Stephens  <shanestephens@google.com>
3607
3608         Reviewed by Eric Seidel.
3609
3610         svn-apply: should support git binary delta diffs
3611         https://bugs.webkit.org/show_bug.cgi?id=38864
3612
3613         * Scripts/VCSUtils.pm:
3614         * Scripts/svn-apply:
3615
3616 2011-01-06  Julie Parent  <jparent@chromium.org>
3617
3618         Reviewed by Eric Seidel.
3619
3620         Test Result Server not removing old results.
3621         https://bugs.webkit.org/show_bug.cgi?id=52012
3622
3623         * TestResultServer/model/jsonresults.py:
3624         Fix off-by-one: Truncate if >= num_runs, not just >.
3625         * TestResultServer/model/jsonresults_unittest.py:
3626         Add unit test to test that merging in a new result with the same value
3627         as the last result causes previous result to fall off.
3628
3629 2011-01-06  James Kozianski  <koz@chromium.org>
3630
3631         Reviewed by Mihai Parparita.
3632
3633         Add classes to provide a consistent interface to a set of files.
3634         https://bugs.webkit.org/show_bug.cgi?id=50901
3635
3636         These classes allow us to write code that is agnostic to whether a
3637         particular set of files resides in a local directory or in a zip file
3638         on a remote machine.
3639
3640         * Scripts/webkitpy/common/system/directoryfileset.py: Added.
3641         * Scripts/webkitpy/common/system/directoryfileset_unittest.py: Added.
3642         * Scripts/webkitpy/common/system/fileset.py: Added.
3643         * Scripts/webkitpy/common/system/filesystem.py:
3644         * Scripts/webkitpy/common/system/filesystem_mock.py:
3645         * Scripts/webkitpy/common/system/zipfileset.py: Added.
3646         * Scripts/webkitpy/common/system/zipfileset_unittest.py: Added.
3647
3648 2011-01-06  Eric Seidel  <eric@webkit.org>
3649
3650         Reviewed by Adam Barth.
3651
3652         NetworkTransaction should log the url it is retrying
3653         https://bugs.webkit.org/show_bug.cgi?id=52043
3654
3655         * Scripts/webkitpy/common/net/networktransaction.py:
3656         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
3657
3658 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
3659
3660         Windows build fix.
3661         Import os before using it.
3662
3663         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3664
3665 2011-01-06  Eric Seidel  <eric@webkit.org>
3666
3667         Reviewed by Adam Barth.
3668
3669         StyleQueue fails to report errors when patches have many files
3670         https://bugs.webkit.org/show_bug.cgi?id=52042
3671
3672         This is one of at least two errors preventing style error reporting at the moment.
3673         When we moved to passing the list of files to check explicitly,
3674         we started to exceed the 500 character TEXT field limit for our AppEngine model object.
3675         We could change the type of the QueueStatus.message type, or we could
3676         just teach statusserver.py how to clamp values (and warn when it does).
3677         I chose the latter path.
3678
3679         * Scripts/webkitpy/common/net/statusserver.py:
3680
3681 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
3682
3683         Reviewed by Stephanie Lewis.
3684         
3685         Fix syntax error in script.
3686
3687         Windows bots need to archive/unarchive builds to/from configuration-specific directories
3688         https://bugs.webkit.org/show_bug.cgi?id=51996
3689
3690         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3691
3692 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3693
3694         Unreviewed, fixing WinCE build after r75196.
3695
3696         WinCE port does not (yet) support NPAPI.
3697
3698         * Scripts/build-webkit:
3699
3700 2011-01-06  Xan Lopez  <xlopez@igalia.com>
3701
3702         Reviewed by Darin Adler.
3703
3704         File::Spec->rel2abs in sunspider-compare-results mangles parameters
3705         https://bugs.webkit.org/show_bug.cgi?id=52015
3706
3707         * Scripts/sunspider-compare-results: call rel2abs on our arguments
3708         after the platform has been detected, otherwise the script will
3709         mangle things like '--gtk' into '/a/path/--gtk', breaking the
3710         detection.
3711
3712 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3713
3714         Reviewed by Eric Seidel.
3715
3716         Add ENABLE_NETSCAPE_PLUGIN_API, ENABLE_ORIENTATION_EVENTS and ENABLE_TOUCH_EVENTS flags to build-webkit
3717         https://bugs.webkit.org/show_bug.cgi?id=51346
3718
3719         * Scripts/build-webkit:
3720
3721 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
3722
3723         Reviewed by Adam Roben.
3724
3725         Windows bots need to archive/unarchive builds to/from configuration-specific directories
3726         https://bugs.webkit.org/show_bug.cgi?id=51996
3727         
3728         After the configuration directory change, we were archiving the incorrect directory for
3729         build product, so we were running tests on the wrong binaries.
3730         
3731         This change archives the correct directory, and also unarchives it into a configuration-
3732         specific directory.
3733
3734         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Use a configuration-specific directory on Windows.
3735         * BuildSlaveSupport/built-product-archive: Unarchive/archive to/from proper directory.
3736
3737 2011-01-06  Eric Seidel  <eric@webkit.org>
3738
3739         Reviewed by Mihai Parparita.
3740
3741         commit-queue mentions "Text diff mismatch" 4 times instead of once per failure
3742         https://bugs.webkit.org/show_bug.cgi?id=52002
3743
3744         See an example of this here:
3745         https://bugs.webkit.org/show_bug.cgi?id=51314#c2
3746
3747         It's due to the fact that we pass around TestFailure() instance
3748         objects and yet expect them to all compare to be the same.
3749
3750         This is bad.  We should either have shared instances of these values
3751         or we should just pass around the class names.  There are already hacks
3752         in place to make TestFailure objects pass equality tests, I just added
3753         a __hash__ implementation so they can be used in sets as expected.
3754
3755         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3756         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
3757
3758 2011-01-06  Evan Martin  <evan@chromium.org>
3759
3760         Reviewed by Tony Chang.
3761
3762         [gdb] handle inaccessible memory and UChar*
3763         https://bugs.webkit.org/show_bug.cgi?id=52003
3764
3765         To pretty-print a UChar*, we just grope around in the memory
3766         looking for a terminating NUL.  We need to handle the exception
3767         that can occur when we poke into an invalid location.
3768
3769         Additionally, the logic for choosing which pretty-printer would
3770         early return before hitting the point where we'd use the UChar*
3771         printer.  (Did this ever work?  How did it regress?)
3772
3773         * gdb/webkit.py:
3774
3775 2011-01-05  Brian Weinstein  <bweinstein@apple.com>
3776
3777         Reviewed by Ada Chan.
3778
3779         WebKit2: Should be able to call into injected bundle to ask if we should allow resource loads
3780         https://bugs.webkit.org/show_bug.cgi?id=51969
3781         
3782         Add shouldLoadResourceForFrame to WTR::InjectedBundlePage.
3783
3784         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3785         (WTR::InjectedBundlePage::InjectedBundlePage):
3786         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Stub implementation.
3787         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3788
3789 2011-01-06  James Robinson  <jamesr@chromium.org>
3790
3791         Reviewed by Simon Fraser.
3792
3793         Implement mozilla's animationTime property
3794         https://bugs.webkit.org/show_bug.cgi?id=51952
3795