c2e680c01e46b3ae2dfb696a845d7d0a042cdc32
[WebKit.git] / Tools / ChangeLog
1 2010-12-20  Cosmin Truta  <ctruta@chromium.org>
2
3         Reviewed by James Robinson.
4
5         new-run-webkit-tests ignores trailing EOL differences in text tests
6         https://bugs.webkit.org/show_bug.cgi?id=36983
7
8         Changed the handling of new-line characters within new-run-webkit-tests
9         to match old-run-webkit-tests.  Differences in leading and trailing empty
10         lines in text expectation files are no longer ignored.
11
12         * Scripts/webkitpy/layout_tests/port/base.py:
13         * Scripts/webkitpy/layout_tests/port/test.py:
14         Added unit tests.  Removed old duplicate unit test entries.
15         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
16
17 2010-12-20  David Levin  <levin@chromium.org>
18
19         Reviewed by Shinichiro Hamaji.
20
21         check-webkit-style should detect function declarations (and trivial functions).
22         https://bugs.webkit.org/show_bug.cgi?id=51303
23
24         * Scripts/webkitpy/style/checkers/cpp.py:
25         (_FunctionState.begin): Add is_declaration and changed the line count
26         start to begin at -1 (which will keep the results consistent, since
27         the starting line number passed in is one less in this change).
28         (detect_functions): changed function detection to now catch trivial
29         functions and declarations.
30         (check_pass_ptr_usage): Don't check for Pass*Ptr on the first line
31         of the function as this may look at return values (when processing
32         a declaration).
33         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
34         (FunctionDetectionTest.perform_function_detection): Basic mechanics
35         of testing the function detection.
36         (FunctionDetectionTest.test_basic_function_detection): Test a simple
37         function.
38         (FunctionDetectionTest.test_function_declaration_detection): Test a
39         declaration.
40         (FunctionDetectionTest.test_non_functions): A test case for a case
41         that caused the code to fail due to the { being in quotes.
42         (PassPtrTest.test_pass_ref_ptr_return_value): Added some more test
43         cases to help catch false alarms for return values.
44         (PassPtrTest.test_pass_ref_ptr_member_variable): Ensure that
45         we don't get false alarms for member variables either.
46
47 2010-12-20  Ryuan Choi  <ryuan.choi@samsung.com>
48
49         Reviewed by Antonio Gomes.
50
51         [CMAKE] Rename WEBKITTOOLS_DIR to TOOLS_DIR
52         https://bugs.webkit.org/show_bug.cgi?id=51319
53
54         * CMakeListsEfl.txt:
55
56 2010-12-18  Adam Barth  <abarth@webkit.org>
57
58         Reviewed by Sam Weinig.
59
60         Move WebKitExamplePlugins to Examples
61         https://bugs.webkit.org/show_bug.cgi?id=51291
62
63         * Scripts/webkitpy/common/config/build.py:
64
65 2010-12-17  Csaba Osztrogonác  <ossy@webkit.org>
66
67         Unreviewed Qt buildfix after r74301.
68
69         Rename WebKitTools to Tools
70         https://bugs.webkit.org/show_bug.cgi?id=49861
71
72         * MiniBrowser/DerivedSources.pro:
73         * MiniBrowser/qt/MiniBrowser.pro:
74
75 2010-12-17  Dan Bernstein  <mitz@apple.com>
76
77         Reviewed by Simon Fraser.
78
79         Rename WebKitTools to Tools
80         https://bugs.webkit.org/show_bug.cgi?id=49861
81
82         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
83         * CodeCoverage/README:
84         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
85         (WebCore::DumpRenderTree::initializeFonts):
86         * EWSTools/start-commit-queue.sh:
87         * EWSTools/start-queue.sh:
88         * GNUmakefile.am:
89         * MIDLWrapper/MIDLWrapper.cpp:
90         (wmain):
91         * MiniBrowser/qt/MiniBrowser.pro:
92         * Scripts/build-api-tests:
93         * Scripts/build-dumprendertree:
94         * Scripts/build-webkit:
95         * Scripts/build-webkittestrunner:
96         * Scripts/generate-coverage-data:
97         * Scripts/old-run-webkit-tests:
98         * Scripts/run-api-tests:
99         * Scripts/run-iexploder-tests:
100         * Scripts/run-javascriptcore-tests:
101         * Scripts/run-mangleme-tests:
102         * Scripts/run-sunspider:
103         * Scripts/run-webkit-websocketserver:
104         * Scripts/sunspider-compare-results:
105         * Scripts/test-webkitperl:
106         * Scripts/test-webkitpy:
107         * Scripts/update-iexploder-cssproperties:
108         * Scripts/update-webkit:
109         * Scripts/update-webkit-localizable-strings:
110         * Scripts/webkitdirs.pm:
111         * Scripts/webkitpy/common/checkout/scm.py:
112         * Scripts/webkitpy/common/checkout/scm_unittest.py:
113         * Scripts/webkitpy/common/config/committervalidator.py:
114         * Scripts/webkitpy/common/config/committervalidator_unittest.py:
115         * Scripts/webkitpy/common/config/ports.py:
116         * Scripts/webkitpy/common/config/ports_unittest.py:
117         * Scripts/webkitpy/common/system/logutils_unittest.py:
118         * Scripts/webkitpy/common/system/ospath_unittest.py:
119         * Scripts/webkitpy/layout_tests/port/chromium.py:
120         * Scripts/webkitpy/layout_tests/port/config.py:
121         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
122         * Scripts/webkitpy/layout_tests/port/http_server.py:
123         * Scripts/webkitpy/layout_tests/port/test.py:
124         * Scripts/webkitpy/style/checker.py:
125         * Scripts/webkitpy/style/checker_unittest.py:
126         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
127         * Scripts/webkitpy/tool/commands/queues_unittest.py:
128         * Scripts/webkitpy/tool/steps/steps_unittest.py:
129         * WebKitTestRunner/DerivedSources.pro:
130         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
131         (WTR::activateFonts):
132         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
133         * wx/build/build_utils.py:
134
135 2010-12-16  Antonio Gomes  <agomes@rim.com>
136
137         Reviewed by Martin Robinson.
138
139         Settings::editingBehaviorType() incorrectly returns mac for the gtk build when running tests
140         https://bugs.webkit.org/show_bug.cgi?id=51163
141
142         Since GTK+'s default editing behavior was changed to UNIX in r70975 (see webkitwebsettings.cpp),
143         GTK+'s DRT should also reset to UNIX after each test execution.
144
145         * DumpRenderTree/gtk/DumpRenderTree.cpp:
146         (resetDefaultsToConsistentValues):
147
148 2010-12-17  David Levin  <levin@chromium.org>
149
150         Reviewed by Eric Seidel.
151
152         check-webkit-style should understand WTF #include guards
153         https://bugs.webkit.org/show_bug.cgi?id=44911
154
155         * Scripts/webkitpy/style/checkers/cpp.py:
156         (get_header_guard_cpp_variable): modify to suggest the WTF style
157         of header guard when appropriate.
158         (check_for_header_guard): handle multiple return values from
159         get_header_guard_cpp_variable
160         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
161         (CppStyleTest.test_build_header_guard): Added tests for the WTF
162         header style.
163
164 2010-12-16  David Levin  <levin@chromium.org>
165
166         Reviewed by Eric Seidel.
167
168         test-webkitpy: unittest for the xml.py checker displays a decprecation warning.
169         https://bugs.webkit.org/show_bug.cgi?id=51210
170
171         The error only shows up when using python 2.6 or later.
172
173         * Scripts/webkitpy/style/checkers/xml.py: Replace the usage of
174         the decprecated field error,message with something equivalent.
175
176 2010-12-16  Mihai Parparita  <mihaip@chromium.org>
177
178         Reviewed by Eric Seidel.
179
180         Add --exit-after-n-failures/crashes to NRWT
181         https://bugs.webkit.org/show_bug.cgi?id=51160
182         
183         Abort test run (in a similar way to how control-C is handled) when
184         --exit-after-n-failures/crashes-or-timeouts are passed and we've reached
185         that number of unexpected failures/crashes/timeouts.
186
187         * Scripts/webkitpy/layout_tests/port/test.py:
188         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
189         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
190
191 2010-12-16  David Levin  <levin@chromium.org>
192
193         Reviewed by Shinichiro Hamaji.
194
195         check-webkit-style unit tests has some duplicate boilerplate code.
196         https://bugs.webkit.org/show_bug.cgi?id=49519
197
198         * Scripts/webkitpy/style/checkers/cpp.py:
199         (update_include_state): Replaced the "io" parameter with the global
200         configuration _unit_test_config. This allowed not calling into
201         functions at a low level and also not plumbing through the injection
202         information through many levels of code.
203         (check_for_include_what_you_use): Ditto.
204         (process_file_data): Added the ability to set up the unit test config
205         to allow for injection.
206         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
207         (ErrorCollector.__init__): Added support for having a filter for errors.
208         (ErrorCollector.__call__): Ditto.
209         (CppStyleTestBase.process_file_data): Added the ability to set unit_test_config.
210         (CppStyleTestBase.perform_lint): Consolidated logic for the perform functions.
211         (CppStyleTestBase.perform_single_line_lint): Replace specific calls to
212         functions in the cpp.py with generic processing and a filter that
213         indicates what errors should be kept.
214         (CppStyleTestBase.perform_multi_line_lint): Ditto.
215         (CppStyleTestBase.perform_language_rules_check): Ditto.
216         (CppStyleTestBase.perform_function_lengths_check): Ditto.
217         (CppStyleTestBase.perform_pass_ptr_check): Ditto.
218         (CppStyleTestBase.perform_include_what_you_use): Ditto.
219         (CppStyleTest.test_multi_line_comments): Added another
220         error message which applies to the test case.
221         (CppStyleTest.test_spacing_for_binary_ops): Fixed test
222         to not have config.h, since it is processed as a header file.
223         (CppStyleTest.test_static_or_global_stlstrings): Fixed variable name
224         style and indentation in checked code.
225         (OrderOfIncludesTest.test_check_preprocessor_in_include_section):
226         Fixed line number.
227         (NoNonVirtualDestructorsTest.test_multi_line_declaration_with_error):
228         Ditto.
229
230 2010-12-15  Sheriff Bot  <webkit.review.bot@gmail.com>
231
232         Unreviewed, rolling out r74136.
233         http://trac.webkit.org/changeset/74136
234         https://bugs.webkit.org/show_bug.cgi?id=51135
235
236         r74136 breaks chromium canary bots because some tests are not
237         rebaselined correctly to resolve EOL differences (Requested by
238         jianli on #webkit).
239
240         * Scripts/webkitpy/layout_tests/port/base.py:
241         * Scripts/webkitpy/layout_tests/port/test.py:
242         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
243
244 2010-12-15  Adam Roben  <aroben@apple.com>
245
246         Teach check-webkit-style to check .vcproj and .vsprops files for XML
247         syntax errors
248
249         Fixes <http://webkit.org/b/51103> check-webkit-style should check for
250         XML syntax errors in .vcproj/.vsprops files
251
252         Reviewed by Dave Levin.
253
254         * Scripts/webkitpy/style/checker.py: Added lists of file extensions
255         that should be treated as XML and that should be allowed to contain
256         carriage returns. (These lists happen to be identical currently.)
257         (FileType): Added a new XML type.
258         (CheckerDispatcher.should_check_and_strip_carriage_returns): Added.
259         Just does a simple file extension check.
260         (CheckerDispatcher._file_type): Added a case for XML files.
261         (CheckerDispatcher._create_checker): Ditto. We use XMLChecker for XML
262         files (surprise!).
263         (StyleProcessor.process): Ask the dispatcher whether we should pass the
264         lines through the carriage checker.
265
266         * Scripts/webkitpy/style/checker_unittest.py:
267         (CheckerDispatcherCarriageReturnTest.test_should_check_and_strip_carriage_returns):
268         Added. Checks a few file names to see if carriage returns are allowed
269         or not.
270         (CheckerDispatcherDispatchTest.assert_checker_xml): Added. Similar to
271         other assert_checker_* functions.
272         (CheckerDispatcherDispatchTest.test_xml_paths): Added. Similar to other
273         test_*_paths functions.
274         (CheckerDispatcherDispatchTest.test_xml_paths): Added. Similar to other
275         test_*_paths functions.
276         (CheckerDispatcherDispatchTest.test_none_paths): Removed the vcproj
277         file from this test case, as vcproj files now have a type.
278         (StyleProcessor_CodeCoverageTest.MockDispatcher.should_check_and_strip_carriage_returns):
279         Added. Similar to the other should_* functions.
280         (StyleProcessor_CodeCoverageTest.test_process__carriage_returns_not_stripped):
281         Added. Checks that carriage returns aren't checked for or stripped for
282         allowed files.
283
284         * Scripts/webkitpy/style/checkers/xml.py: Added.
285         (XMLChecker.__init__): Simple init method.
286         (XMLChecker.check): Pass each line through the expat parser, and record
287         a style error for any errors thrown by the parser.
288
289         * Scripts/webkitpy/style/checkers/xml_unittest.py: Added.
290         (XMLCheckerTest.assert_no_error): Checks that the given XML does not
291         produce a style error.
292         (XMLCheckerTest.assert_error): Checks that the given XML produces an
293         error of the given category on the given line.
294         (XMLCheckerTest.mock_handle_style_error): Does nothing. Used for
295         checking that the XMLChecker constructor works properly.
296         (XMLCheckerTest.test_conflict_marker): Tests that conflict markers
297         cause a style error (see, e.g., r73887).
298         (XMLCheckerTest.test_extra_closing_tag): Tests that extra closing tags
299         cause a style error (see, e.g., r73773).
300         (XMLCheckerTest.test_init): Tests that the XMLChecker constructor works
301         properly.
302         (XMLCheckerTest.test_missing_closing_tag): Tests that missing closing
303         tags cause a style error (see, e.g., r72795).
304         (XMLCheckerTest.test_no_error): Tests that valid XML does not cause a
305         style error.
306
307 2010-12-15  Lucas Forschler  <lforschler@apple.com>
308
309         Reviewed by Stephanie Lewis.
310
311         https://bugs.webkit.org/show_bug.cgi?id=51117
312         Add a new leopard test bot
313         really really commit to trunk this time.
314
315         * BuildSlaveSupport/build.webkit.org-config/config.json:
316
317 2010-12-15  Sam Weinig  <sam@webkit.org>
318
319         Reviewed by Anders Carlsson.
320
321         WebKit2: Can't add files to an <input type=file>
322         https://bugs.webkit.org/show_bug.cgi?id=51087
323
324         * MiniBrowser/mac/BrowserWindowController.m:
325         (runOpenPanel):
326         (-[BrowserWindowController awakeFromNib]):
327         Add simple implementation of runOpenPanel callback.
328
329         * MiniBrowser/win/BrowserView.cpp:
330         (BrowserView::create):
331         * WebKitTestRunner/TestController.cpp:
332         (WTR::createOtherPage):
333         (WTR::TestController::initialize):
334         Stub out runOpenPanel callback. 
335
336 2010-12-14  Eric Seidel  <eric@webkit.org>
337
338         Reviewed by Adam Barth.
339
340         commit-queue should upload failure diffs when tests flake
341         https://bugs.webkit.org/show_bug.cgi?id=51051
342
343         To make this testable I needed to pipe FileSystem down onto tool.
344         We've wanted it there for a long time anyway.
345
346         This patch is kinda a big hack.  But we don't have a nice
347         way to read results.html files.  I think this will need further
348         revision before this code actually feels clean.
349
350         As part of testing this change, I had to make MockBugzilla.create_bug
351         actually return an id (like it should) which required updating
352         a few other unit test results (for the better).
353
354         The results_matching_keys change in layouttestresults/rebasline
355         was an alternate path which I decided not to use in the end, but
356         I left the change as it seemed an improvement.
357
358         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
359         * Scripts/webkitpy/common/net/layouttestresults.py:
360         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
361         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
362         * Scripts/webkitpy/tool/commands/queues.py:
363         * Scripts/webkitpy/tool/commands/rebaseline.py:
364         * Scripts/webkitpy/tool/main.py:
365         * Scripts/webkitpy/tool/mocktool.py:
366
367 2010-12-15  Cosmin Truta  <ctruta@chromium.org>
368
369         Reviewed by James Robinson.
370
371         new-run-webkit-tests ignores trailing EOL differences in text tests
372         https://bugs.webkit.org/show_bug.cgi?id=36983
373
374         Changed the handling of new-line characters within new-run-webkit-tests
375         to match old-run-webkit-tests.  Differences in leading and trailing empty
376         lines in text expectation files are no longer ignored.
377
378         * Scripts/webkitpy/layout_tests/port/base.py:
379         * Scripts/webkitpy/layout_tests/port/test.py:
380         Added unit tests.  Removed old duplicate unit test entries.
381         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
382
383 2010-12-15  Ojan Vafai  <ojan@chromium.org>
384
385         Reviewed by Adam Barth.
386
387         make status-bubble white-space:nowrap so we can measure it's width without wrapping
388         https://bugs.webkit.org/show_bug.cgi?id=51149
389
390         * QueueStatusServer/templates/statusbubble.html:
391
392 2010-12-15  Ojan Vafai  <ojan@chromium.org>
393
394         Reviewed by Adam Barth.
395
396         have the statusbubble postMessage it's metrics so that embedders can properly size the iframe
397         https://bugs.webkit.org/show_bug.cgi?id=51125
398
399         * QueueStatusServer/templates/statusbubble.html:
400
401 2010-12-15  Darin Adler  <darin@apple.com>
402
403         * Scripts/webkitpy/common/net/buildbot: Added property svn:ignore.
404
405 2010-12-15  Sheriff Bot  <webkit.review.bot@gmail.com>
406
407         Unreviewed, rolling out r74117.
408         http://trac.webkit.org/changeset/74117
409         https://bugs.webkit.org/show_bug.cgi?id=51113
410
411         This broke the GTK1 build. (Requested by mrobinson on
412         #webkit).
413
414         * Scripts/webkitdirs.pm:
415
416 2010-12-15  Amruth Raj  <amruthraj@motorola.com> and Ravi Kasibhatla  <ravi.kasibhatla@motorola.com>
417
418         Reviewed by Martin Robinson.
419
420         Change generate-forwarding-headers.pl for GTK port usage 
421         (https://bugs.webkit.org/show_bug.cgi?id=37369)
422
423         * Scripts/webkitdirs.pm: Added changes to build webkit2 for GTK port using build-webkit script.
424
425 2010-12-14  Kent Tamura  <tkent@chromium.org>
426
427         Reviewed by Jian Li.
428
429         [DRT/Chromium] Remove another unnecessary error message
430         https://bugs.webkit.org/show_bug.cgi?id=51083
431
432         * DumpRenderTree/chromium/WebViewHost.cpp:
433         (WebViewHost::didInvalidateRect):
434
435 2010-12-14  Lucas Forschler  <lforschler@apple.com>
436
437         Reviewed by Stephanie Lewis.
438
439         Add a new Leopard Debug Test WK2 Bot
440
441         * BuildSlaveSupport/build.webkit.org-config/config.json:
442
443 2010-12-14  Ojan Vafai  <ojan@chromium.org>
444
445         Fix python unittests after http://trac.webkit.org/changeset/74070.
446
447         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
448
449 2010-12-14  Kent Tamura  <tkent@chromium.org>
450
451         Reviewed by Jian Li.
452
453         [DRT/Chromium] Remove a unnecessary error message
454         https://bugs.webkit.org/show_bug.cgi?id=51069
455
456         * DumpRenderTree/chromium/WebViewHost.cpp:
457         (WebViewHost::paintInvalidatedRegion):
458
459 2010-12-14  Benjamin Kalman  <kalman@chromium.org>
460
461         Reviewed by Ojan Vafai.
462
463         Using BUG/BUGWK in test_expectations is error prone, should use BUGCR/BUGWK
464         https://bugs.webkit.org/show_bug.cgi?id=48926
465
466         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
467         Add presubmit check that BUG isn't used, either BUGCR/BUGWK/BUGV8_.
468
469 2010-12-14  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
470
471         Reviewed by Eric Seidel.
472
473         [Qt] [Symbian] Do not use pkg-config on Symbian as it is not supported
474         https://bugs.webkit.org/show_bug.cgi?id=50231
475
476         Guard CONFIG+=link_pkgconfig with !symbian.
477
478         * DumpRenderTree/qt/DumpRenderTree.pro:
479         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
480         * WebKitTestRunner/qt/WebKitTestRunner.pro:
481
482 2010-12-14  Philippe Normand  <pnormand@igalia.com>
483
484         Reviewed by Ojan Vafai.
485
486         [new-run-webkit-tests] expectations parsing is slow
487         https://bugs.webkit.org/show_bug.cgi?id=50635
488
489         Avoid expensive iteration of all the tests when checking if a test
490         file is to be skipped or not.
491
492         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
493         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
494         * Scripts/webkitpy/layout_tests/port/test.py:
495
496 2010-12-14  Mario Sanchez Prada  <msanchez@igalia.com>
497
498         Reviewed by Xan Lopez.
499
500         [Gtk] Implement STATE_FOCUSED, STATE_FOCUSABLE, and corresponding events for text objects
501         https://bugs.webkit.org/show_bug.cgi?id=27048
502
503         Add support in DRT for checking whether an accessibility UI
504         element is focusable and/or focused. Implemented for GTK.
505
506         * DumpRenderTree/AccessibilityUIElement.cpp:
507         (getIsFocusedCallback): New.
508         (getIsFocusableCallback): New.
509         (AccessibilityUIElement::getJSClass): Add the new available
510         callbacks for isFocused and isFocusable.
511         * DumpRenderTree/AccessibilityUIElement.h:
512         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
513         (AccessibilityUIElement::isFocused): New, implemented by checking
514         whether the related AtkState value is in the object's state set.
515         (AccessibilityUIElement::isFocusable): Ditto.
516         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
517         (AccessibilityUIElement::isFocused): New, dummy implementation.
518         (AccessibilityUIElement::isFocusable): Ditto.
519         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
520         (AccessibilityUIElement::isFocused): Ditto.
521         (AccessibilityUIElement::isFocusable): Ditto.
522
523 2010-12-14  Eric Seidel  <eric@webkit.org>
524
525         Reviewed by Ojan Vafai.
526
527         webkit-patch should warn users when they're using a 32-bit git on a 64-bit system
528         https://bugs.webkit.org/show_bug.cgi?id=50715
529
530         This patch makes webkit-patch print the following:
531
532         Warning: This machine is 64-bit, but the git binary (/usr/local/git/bin/git) does not support 64-bit.
533         Install a 64-bit git for better performance, see:
534         https://lists.webkit.org/pipermail/webkit-dev/2010-December/015249.html
535
536         I wrote this mostly because I have approximately 8 machines that I use
537         and making sure each one is using a good Git install seemed folly.
538         webkit-patch makes a lot of git calls, so using a fast git can shave
539         several seconds in every invocation.  See the webkit-dev thread for more info.
540
541         This message will print twice during 'webkit-patch upload',
542         once from webkit-patch and once from check-webkit-style.
543
544         Unfortunately there is no good way to test this due to how machine-dependent
545         the code is.  I considered writing a test for the log message, but it seemed not worth it.
546
547         * Scripts/webkitpy/common/checkout/scm.py:
548
549 2010-12-13  Eric Seidel  <eric@webkit.org>
550
551         Reviewed by Adam Barth.
552
553         FlakyTestReporter doesn't understand bots running from multiple email addresses
554         https://bugs.webkit.org/show_bug.cgi?id=50960
555
556         This explains at least one of the dupes of:
557         https://bugs.webkit.org/show_bug.cgi?id=50863
558         that we saw filed by the commit-queue this morning.
559         I think the other one was explained by my previous fix to result counting code.
560
561         Since this is really hard to test with a unit test, instead I
562         create a new (possibly useful in the future) command
563         which given a layout test path will return you
564         the one bug which our tools would assume it the flaky test bug.
565         If some other script wants to use bug-for-test we'll
566         need to extend it with some options like --create-if-missing or similar.
567
568         * Scripts/webkitpy/common/net/bugzilla/bug.py:
569         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
570         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
571         * Scripts/webkitpy/tool/commands/__init__.py:
572         * Scripts/webkitpy/tool/commands/bugfortest.py: Added.
573
574 2010-12-13  Mihai Parparita  <mihaip@chromium.org>
575
576         Reviewed by James Robinson.
577
578         Add option to build-webkit to not build WebKit2
579         https://bugs.webkit.org/show_bug.cgi?id=50988
580         
581         Add support for a --no-webkit2 option to build-webkit. It seems to save
582         ~1 minute from clean builds and ~10 seconds from no-op builds.
583
584         * Scripts/build-webkit:
585
586 2010-12-13  Lucas Forschler  <lforschler@apple.com>
587
588         Reviewed by Dave Kilzer.
589
590         Update iexploder from 1.3.2 to 1.7.2
591         Move 1.3.2 into its own subdir
592         Add 1.7.2 into its own subdir
593         update scripts to point to new 1.3.2 location (avoid breaking existing scripts)
594
595         * Scripts/run-iexploder-tests:
596         * Scripts/update-iexploder-cssproperties:
597         * iExploder/CHANGELOG.txt: Removed.
598         * iExploder/LICENSE.txt: Removed.
599         * iExploder/README.txt: Removed.
600         * iExploder/htdocs: Removed.
601         * iExploder/iexploder-1.3.2: Added.
602         * iExploder/iexploder-1.3.2/CHANGELOG.txt: Copied from iExploder/CHANGELOG.txt.
603         * iExploder/iexploder-1.3.2/LICENSE.txt: Copied from iExploder/LICENSE.txt.
604         * iExploder/iexploder-1.3.2/README.txt: Copied from iExploder/README.txt.
605         * iExploder/iexploder-1.3.2/htdocs: Added.
606         * iExploder/iexploder-1.3.2/htdocs/config.rb: Copied from iExploder/htdocs/config.rb.
607         * iExploder/iexploder-1.3.2/htdocs/cssproperties.in: Copied from iExploder/htdocs/cssproperties.in.
608         * iExploder/iexploder-1.3.2/htdocs/cssvalues.in: Copied from iExploder/htdocs/cssvalues.in.
609         * iExploder/iexploder-1.3.2/htdocs/htmlattrs.in: Copied from iExploder/htdocs/htmlattrs.in.
610         * iExploder/iexploder-1.3.2/htdocs/htmltags.in: Copied from iExploder/htdocs/htmltags.in.
611         * iExploder/iexploder-1.3.2/htdocs/htmlvalues.in: Copied from iExploder/htdocs/htmlvalues.in.
612         * iExploder/iexploder-1.3.2/htdocs/iexploder.cgi: Copied from iExploder/htdocs/iexploder.cgi.
613         * iExploder/iexploder-1.3.2/htdocs/iexploder.rb: Copied from iExploder/htdocs/iexploder.rb.
614         * iExploder/iexploder-1.3.2/htdocs/index.html: Copied from iExploder/htdocs/index.html.
615         * iExploder/iexploder-1.3.2/htdocs/webserver.rb: Copied from iExploder/htdocs/webserver.rb.
616         * iExploder/iexploder-1.3.2/tools: Added.
617         * iExploder/iexploder-1.3.2/tools/lasthit.rb: Copied from iExploder/tools/lasthit.rb.
618         * iExploder/iexploder-1.3.2/tools/osx_last_crash.rb: Copied from iExploder/tools/osx_last_crash.rb.
619         * iExploder/iexploder-1.3.2/tools/showtest.rb: Copied from iExploder/tools/showtest.rb.
620         * iExploder/iexploder-1.7.2: Added.
621         * iExploder/iexploder-1.7.2/ChangeLog.txt: Added.
622         * iExploder/iexploder-1.7.2/LICENSE.txt: Added.
623         * iExploder/iexploder-1.7.2/README.txt: Added.
624         * iExploder/iexploder-1.7.2/output: Added.
625         * iExploder/iexploder-1.7.2/src: Added.
626         * iExploder/iexploder-1.7.2/src/browser_harness.rb: Added.
627         * iExploder/iexploder-1.7.2/src/config.yaml: Added.
628         * iExploder/iexploder-1.7.2/src/css-atrules: Added.
629         * iExploder/iexploder-1.7.2/src/css-atrules/mozilla: Added.
630         * iExploder/iexploder-1.7.2/src/css-atrules/webkit: Added.
631         * iExploder/iexploder-1.7.2/src/css-properties: Added.
632         * iExploder/iexploder-1.7.2/src/css-properties/dillo: Added.
633         * iExploder/iexploder-1.7.2/src/css-properties/gtkhtml: Added.
634         * iExploder/iexploder-1.7.2/src/css-properties/internet_explorer6: Added.
635         * iExploder/iexploder-1.7.2/src/css-properties/mozilla: Added.
636         * iExploder/iexploder-1.7.2/src/css-properties/webkit: Added.
637         * iExploder/iexploder-1.7.2/src/css-pseudo: Added.
638         * iExploder/iexploder-1.7.2/src/css-pseudo/mozilla: Added.
639         * iExploder/iexploder-1.7.2/src/css-pseudo/webkit: Added.
640         * iExploder/iexploder-1.7.2/src/css-values: Added.
641         * iExploder/iexploder-1.7.2/src/css-values/dillo: Added.
642         * iExploder/iexploder-1.7.2/src/css-values/gtkhtml: Added.
643         * iExploder/iexploder-1.7.2/src/css-values/mozilla: Added.
644         * iExploder/iexploder-1.7.2/src/css-values/other: Added.
645         * iExploder/iexploder-1.7.2/src/css-values/webkit: Added.
646         * iExploder/iexploder-1.7.2/src/headers: Added.
647         * iExploder/iexploder-1.7.2/src/headers/dillo: Added.
648         * iExploder/iexploder-1.7.2/src/headers/gtkhtml: Added.
649         * iExploder/iexploder-1.7.2/src/headers/mozilla: Added.
650         * iExploder/iexploder-1.7.2/src/headers/webkit: Added.
651         * iExploder/iexploder-1.7.2/src/html-attrs: Added.
652         * iExploder/iexploder-1.7.2/src/html-attrs/dillo: Added.
653         * iExploder/iexploder-1.7.2/src/html-attrs/gtkhtml: Added.
654         * iExploder/iexploder-1.7.2/src/html-attrs/internet_explorer6: Added.
655         * iExploder/iexploder-1.7.2/src/html-attrs/mozilla: Added.
656         * iExploder/iexploder-1.7.2/src/html-attrs/other: Added.
657         * iExploder/iexploder-1.7.2/src/html-attrs/webkit: Added.
658         * iExploder/iexploder-1.7.2/src/html-tags: Added.
659         * iExploder/iexploder-1.7.2/src/html-tags/dillo: Added.
660         * iExploder/iexploder-1.7.2/src/html-tags/gtkhtml: Added.
661         * iExploder/iexploder-1.7.2/src/html-tags/mozilla: Added.
662         * iExploder/iexploder-1.7.2/src/html-tags/other: Added.
663         * iExploder/iexploder-1.7.2/src/html-tags/webkit: Added.
664         * iExploder/iexploder-1.7.2/src/html-values: Added.
665         * iExploder/iexploder-1.7.2/src/html-values/dillo: Added.
666         * iExploder/iexploder-1.7.2/src/html-values/gtkhtml: Added.
667         * iExploder/iexploder-1.7.2/src/html-values/mozilla: Added.
668         * iExploder/iexploder-1.7.2/src/html-values/other: Added.
669         * iExploder/iexploder-1.7.2/src/html-values/webkit: Added.
670         * iExploder/iexploder-1.7.2/src/iexploder.cgi: Added.
671         * iExploder/iexploder-1.7.2/src/iexploder.rb: Added.
672         * iExploder/iexploder-1.7.2/src/index.html: Added.
673         * iExploder/iexploder-1.7.2/src/media: Added.
674         * iExploder/iexploder-1.7.2/src/media/blank.ogg: Added.
675         * iExploder/iexploder-1.7.2/src/media/blank.snd: Added.
676         * iExploder/iexploder-1.7.2/src/media/blank.wav: Added.
677         * iExploder/iexploder-1.7.2/src/media/bug.bmp: Added.
678         * iExploder/iexploder-1.7.2/src/media/bug.gif: Added.
679         * iExploder/iexploder-1.7.2/src/media/bug.ico: Added.
680         * iExploder/iexploder-1.7.2/src/media/bug.jng: Added.
681         * iExploder/iexploder-1.7.2/src/media/bug.jpg: Added.
682         * iExploder/iexploder-1.7.2/src/media/bug.png: Added.
683         * iExploder/iexploder-1.7.2/src/media/bug.svg: Added.
684         * iExploder/iexploder-1.7.2/src/media/bug.tiff: Added.
685         * iExploder/iexploder-1.7.2/src/media/bug.xbm: Added.
686         * iExploder/iexploder-1.7.2/src/media/bug.xpm: Added.
687         * iExploder/iexploder-1.7.2/src/mime-types: Added.
688         * iExploder/iexploder-1.7.2/src/mime-types/dillo: Added.
689         * iExploder/iexploder-1.7.2/src/mime-types/mozilla: Added.
690         * iExploder/iexploder-1.7.2/src/mime-types/webkit: Added.
691         * iExploder/iexploder-1.7.2/src/protocols: Added.
692         * iExploder/iexploder-1.7.2/src/protocols/dillo: Added.
693         * iExploder/iexploder-1.7.2/src/protocols/gtkhtml: Added.
694         * iExploder/iexploder-1.7.2/src/protocols/mozilla: Added.
695         * iExploder/iexploder-1.7.2/src/protocols/webkit: Added.
696         * iExploder/iexploder-1.7.2/src/scanner.rb: Added.
697         * iExploder/iexploder-1.7.2/src/version.rb: Added.
698         * iExploder/iexploder-1.7.2/src/webserver.rb: Added.
699         * iExploder/iexploder-1.7.2/testcases: Added.
700         * iExploder/iexploder-1.7.2/testcases/testcase-Linux_x86_64_rv2.0b6pre_Gecko-20100904_Firefox-4.0b6pre-TEST-8375-1_59.html: Added.
701         * iExploder/iexploder-1.7.2/testcases/testcase-Opera-9.80_Linux_x86_64_en_Presto-2.6.30_Version-10.61-16704-3_108,3.html: Added.
702         * iExploder/iexploder-1.7.2/testcases/testcase-U_Intel_Mac_OS_X_10_6_4_en-US_AppleWebKit-534.8_Chrome-7.0.529.0-TEST-611-3_36,9.html: Added.
703         * iExploder/iexploder-1.7.2/testcases/testcase-U_Intel_Mac_OS_X_10_6_4_en-US_AppleWebKit-534.8_hrome-7.0.529.0-TEST-55313622206-3_6,0.html: Added.
704         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.6_Chrome-7.0.503.1-TEST-120813-8_72,56,24,8,0.html: Added.
705         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.6_Chrome-7.0.503.1-TEST-121240-3_81,3.html: Added.
706         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.7_Chrome-7.0.513.0-4800-5_80,65,15.html: Added.
707         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.7_Chrome-7.0.513.0-TEST-23583190347-3_15,12.html: Added.
708         * iExploder/iexploder-1.7.2/tools: Added.
709         * iExploder/iexploder-1.7.2/tools/lasthit.rb: Added.
710         * iExploder/iexploder-1.7.2/tools/osx_last_crash.rb: Added.
711         * iExploder/iexploder-1.7.2/tools/release_src.sh: Added.
712         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh: Added.
713         * iExploder/tools: Removed.
714
715 2010-12-13  Sam Weinig  <sam@webkit.org>
716
717         Reviewed by Anders Carlsson.
718
719         Remove associated page concept from WKView constructor
720         https://bugs.webkit.org/show_bug.cgi?id=50983
721
722         Step 1: Remove associate page constructors from WKView and make
723         all views use the shared namespace for the context.
724
725         * TestWebKitAPI/PlatformWebView.h:
726         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
727         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
728         * WebKitTestRunner/PlatformWebView.h:
729         * WebKitTestRunner/TestController.cpp:
730         (WTR::createOtherPage):
731         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
732         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
733         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
734
735 2010-12-13  Sam Weinig  <sam@webkit.org>
736
737         Reviewed by Anders Carlsson.
738
739         Change the WebKit2 public API so there is no explicit WKPageNamespace object
740         https://bugs.webkit.org/show_bug.cgi?id=50898
741
742         * MiniBrowser/mac/AppDelegate.h:
743         * MiniBrowser/mac/AppDelegate.m:
744         * MiniBrowser/mac/BrowserWindowController.h:
745         * MiniBrowser/mac/BrowserWindowController.m:
746         * MiniBrowser/win/BrowserView.cpp:
747         Convert MiniBrowser to not use PageNamespaces.
748
749         * TestWebKitAPI/PlatformWebView.h:
750         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
751         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
752         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
753         * TestWebKitAPI/Tests/WebKit2/Find.cpp:
754         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
755         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
756         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
757         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
758         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
759         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
760         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
761         * TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp:
762         * TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp:
763         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
764         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
765         Convert TestWebKitAPI to not use PageNamespaces.
766
767         * WebKitTestRunner/PlatformWebView.h:
768         * WebKitTestRunner/TestController.cpp:
769         * WebKitTestRunner/TestController.h:
770         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
771         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
772         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
773         Convert WebKitTestRunner to not use PageNamespaces.
774
775 2010-12-13  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
776
777         Reviewed by Eric Seidel.
778
779         webkit-patch rollout should be able to do multi-revision rollouts
780         https://bugs.webkit.org/show_bug.cgi?id=33336
781
782         Make it possible to pass more than one revision to webkit-patch.
783
784         * Scripts/webkitpy/common/checkout/api.py:
785         * Scripts/webkitpy/common/checkout/changelog.py:
786         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
787         * Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:
788         * Scripts/webkitpy/tool/commands/download.py:
789         * Scripts/webkitpy/tool/commands/download_unittest.py:
790         * Scripts/webkitpy/tool/mocktool.py:
791         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
792         * Scripts/webkitpy/tool/steps/revertrevision.py:
793
794 2010-12-13  Eric Seidel  <eric@webkit.org>
795
796         Unreviewed.
797
798         Teach webkit-patch how to search bugzilla
799         https://bugs.webkit.org/show_bug.cgi?id=50500
800
801         webkit-patch bug-search fails when there is only one result.
802         Turns out we needed a bit more logic in our result count parsing code.
803
804         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
805         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
806
807 2010-12-13  Antti Koivisto  <antti@apple.com>
808
809         Reviewed by Alexey Proskuryakov.
810
811         Add setSerializeHTTPLoads function to allow testing resource load order on OS X.
812         https://bugs.webkit.org/show_bug.cgi?id=50758
813
814         * DumpRenderTree/LayoutTestController.cpp:
815         (setSerializeHTTPLoadsCallback):
816         (LayoutTestController::staticFunctions):
817         * DumpRenderTree/LayoutTestController.h:
818         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
819         (LayoutTestController::setSerializeHTTPLoads):
820         * DumpRenderTree/mac/DumpRenderTree.mm:
821         (resetDefaultsToConsistentValues):
822         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
823         (LayoutTestController::setSerializeHTTPLoads):
824         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
825         (LayoutTestController::setSerializeHTTPLoads):
826
827 2010-12-13  Dimitri Glazkov  <dglazkov@chromium.org>
828
829         Reviewed by Ojan Vafai.
830
831         Remove "use-drt" option from test step command line, since the option was removed in r73748.
832         https://bugs.webkit.org/show_bug.cgi?id=50936
833
834         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Removed the option.
835
836 2010-12-13  Patrick Gansterer  <paroga@webkit.org>
837
838         Reviewed by Csaba Osztrogonác.
839
840         Add revlink to BuildBot status
841         https://bugs.webkit.org/show_bug.cgi?id=50914
842
843         This adds a hyperlink to trac changeset on the revision numbers. 
844
845         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
846
847 2010-12-13  Andras Becsi  <abecsi@webkit.org>
848
849         Reviewed by Csaba Osztrogonác.
850
851         [Qt][WK2] Fix build if WebKitTools are not available
852         https://bugs.webkit.org/show_bug.cgi?id=50242
853
854         * MiniBrowser/qt/MiniBrowser.pro: Correct the comment.
855         * Scripts/webkitdirs.pm: Added WebKitTools/MiniBrowser to $subdirs.
856         * MiniBrowser/DerivedSources.pro: Added.
857
858 2010-12-13  Eric Seidel  <eric@webkit.org>
859
860         Reviewed by Adam Barth.
861
862         EWS Queues should remove orpahned pyc files before starting
863         https://bugs.webkit.org/show_bug.cgi?id=50904
864
865         A previous check added a platform.py which caused
866         EWS bots on some platforms to hit an import exception.
867         The platform.py file was removed in a subsequent commit, but
868         the EWS bots in question stayed stuck.  This change will
869         fix those bots once restarted (and prevent this in the future).
870
871         I also went ahead and unified start-queue and start-commit-queue
872         since they were nearly identical.  I also added bot_id support
873         to both force all EWSes to have bot ids as well as get rid of the one
874         remaining reason why I had my own copies of these scripts.
875         Hopefully this will be enough to get all the other bot admins
876         (ahem, Adam, ahem) to move to using these checked in copies as well.
877
878         * EWSTools/start-commit-queue.sh: Removed.
879         * EWSTools/start-queue.sh:
880
881 2010-10-28  MORITA Hajime  <morrita@google.com>
882
883         Reviewed by Ojan Vafai.
884
885         spellcheck does not check pasted text
886         https://bugs.webkit.org/show_bug.cgi?id=40092
887
888         Added LayoutTestController::setAsynchronousSpellCheckingEnabled()
889         to control the setting.
890
891         * DumpRenderTree/LayoutTestController.cpp:
892         (setAsynchronousSpellCheckingEnabledCallback):
893         (LayoutTestController::staticFunctions):
894         * DumpRenderTree/LayoutTestController.h:
895         * DumpRenderTree/chromium/LayoutTestController.h:
896         * DumpRenderTree/chromium/LayoutTestController.cpp:
897         (LayoutTestController::LayoutTestController):
898         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
899         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
900         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
901         * DumpRenderTree/mac/DumpRenderTree.mm:
902         (resetDefaultsToConsistentValues):
903         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
904         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
905         * DumpRenderTree/qt/LayoutTestControllerQt.h:
906         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
907         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
908         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
909         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
910         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
911         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
912
913 2010-12-12  Sam Weinig  <sam@webkit.org>
914
915         Reviewed by Anders Carlsson.
916
917         Fix failing API test. It turns out that a pop-state event
918         is sent before every fragment navigation, so we have to test
919         for it in addition in PageLoadDidChangeLocationWithinPageForFrame.
920
921         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
922         (TestWebKitAPI::didSameDocumentNavigationForFrame):
923
924 2010-12-12  Alejandro G. Castro  <alex@igalia.com>
925
926         Reviewed by Eric Seidel.
927
928         [GTK] Add new-run-webkit-tests support to gtk
929         https://bugs.webkit.org/show_bug.cgi?id=50681
930
931         Adding the basic support to run the new-run-webkit-tests.
932
933         * Scripts/webkitpy/layout_tests/port/gtk.py:
934
935 2010-10-11  Diego Gonzalez  <diegohcg@webkit.org>
936
937         Reviewed by Kenneth Rohde Christiansen.
938
939         [Qt] Mock DeviceOrientation client for DRT
940         https://bugs.webkit.org/show_bug.cgi?id=47490
941
942         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
943         (WebCore::DumpRenderTree::DumpRenderTree):
944         (WebCore::DumpRenderTree::~DumpRenderTree):
945         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
946         (LayoutTestController::setMockDeviceOrientation):
947
948 2010-12-11  Philippe Normand  <pnormand@igalia.com>
949
950         Reviewed by Gustavo Noronha Silva.
951
952         [GTK] launcher: disable the Mozilla-style fullscreen API
953         https://bugs.webkit.org/show_bug.cgi?id=50874
954
955         Disabling the fullscreen API until its implementation for GTK is
956         mature enough. The webview setting for it is already FALSE by
957         default.
958
959         * GtkLauncher/main.c:
960         (createWindow):
961
962 2010-12-10  Eric Seidel  <eric@webkit.org>
963
964         Reviewed by Adam Barth.
965
966         commit-queue flaky test messages show cryptic version information for mac os x
967         https://bugs.webkit.org/show_bug.cgi?id=50864
968
969         Turns out platform.platform() returns kernel version information
970         which isn't helpful, and just plain confusing on Mac
971         (OS X 10.6.5 uses Darwin Kernel 10.5.0).
972
973         So I've updated PlatformInfo.display_name() to special case
974         mac.  I also found a bad use of sys.platform in the process
975         and fixed that.  (sys.platform always returns 'darwin' on mac).
976
977         * Scripts/webkitpy/common/system/platforminfo.py:
978         * Scripts/webkitpy/common/system/user.py:
979         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
980         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
981         * Scripts/webkitpy/tool/commands/queues_unittest.py:
982
983 2010-12-10  Eric Seidel  <eric@webkit.org>
984
985         Unreviewed.
986
987         Exception seen while reporting flaky test with commit-queue.
988         Just a missing include.
989
990         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
991         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
992
993 2010-12-10  Kinuko Yasuda  <kinuko@chromium.org>
994
995         Reviewed by Eric Seidel.
996
997         [Chromium] Remove old JSONResultsGenerator script that existed for backward-compatibility
998         https://bugs.webkit.org/show_bug.cgi?id=50796
999
1000         Also updating the test code to use JSONResultsGeneratorBase and
1001         to improve test coverage for incremental cases.
1002
1003         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1004         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
1005
1006 2010-12-10  Joseph Pecoraro  <joepeck@webkit.org>
1007
1008         Reviewed by Darin Adler.
1009
1010         prepare-ChangeLog --help doesn't mention --bug shorthand -b
1011         https://bugs.webkit.org/show_bug.cgi?id=50835
1012
1013         * Scripts/prepare-ChangeLog: be more explicit about -b and match file style.
1014
1015 2010-12-10  Eric Seidel  <eric@webkit.org>
1016
1017         Reviewed by Adam Barth.
1018
1019         Bugs created by the commit-queue should all block on a master bug
1020         https://bugs.webkit.org/show_bug.cgi?id=50857
1021
1022         This makes all bugs created by the commit-queue block on:
1023         https://bugs.webkit.org/show_bug.cgi?id=50856
1024
1025         In the process of testing this, I found that the existing
1026         create_bug code was wrong.  I also found that existing
1027         unit tests for create-rollout used invalid values
1028         for options.blocks.  I fixed both issues and tested.
1029
1030         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1031         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1032         * Scripts/webkitpy/tool/commands/commandtest.py:
1033         * Scripts/webkitpy/tool/commands/download_unittest.py:
1034         * Scripts/webkitpy/tool/commands/upload_unittest.py:
1035         * Scripts/webkitpy/tool/mocktool.py:
1036         * Scripts/webkitpy/tool/steps/options.py:
1037
1038 2010-12-10  Eric Seidel  <eric@webkit.org>
1039
1040         Reviewed by Adam Barth.
1041
1042         Teach webkitpy how to follow duplicate chains when posting comments on flake bugs
1043         https://bugs.webkit.org/show_bug.cgi?id=50853
1044
1045         I also discovered when doing this that the code was posting
1046         the comment on the wrong bug, but that's fixed here too.
1047
1048         * Scripts/webkitpy/common/net/bugzilla/bug.py:
1049         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1050         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1051         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1052         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1053         * Scripts/webkitpy/tool/mocktool.py:
1054
1055 2010-12-10  Anders Carlsson  <andersca@apple.com>
1056
1057         Reviewed by John Sullivan.
1058
1059         Make WKContextGetStatistics gather global statistics
1060         https://bugs.webkit.org/show_bug.cgi?id=50850
1061
1062         Remove the code that gets the statistics and fills in the per context
1063         statistics information for now.
1064
1065         * MiniBrowser/mac/BrowserStatisticsWindowController.m:
1066         (-[BrowserStatisticsWindowController refreshStatistics:]):
1067
1068 2010-12-10  Eric Seidel  <eric@webkit.org>
1069
1070         Unreviewed.
1071
1072         commit-queue should report port/platform information when commenting on flaky test bugs
1073         https://bugs.webkit.org/show_bug.cgi?id=50839
1074
1075         Renamed platform.py to platforminfo.py.  This broke import platform in executive.py
1076         which was only used by new run webkit tests (and clearly not unit tested).
1077
1078         * Scripts/webkitpy/common/system/platforminfo.py: Renamed from WebKitTools/Scripts/webkitpy/common/system/platform.py.
1079         * Scripts/webkitpy/tool/main.py:
1080         * Scripts/webkitpy/tool/mocktool.py:
1081
1082 2010-12-10  Eric Seidel  <eric@webkit.org>
1083
1084         Reviewed by Tony Chang.
1085
1086         commit-queue should report port/platform information when commenting on flaky test bugs
1087         https://bugs.webkit.org/show_bug.cgi?id=50839
1088
1089         This was a suggestion from Tony Chang this morning.
1090         I added a platform.py class so I could easily mock the platform call,
1091         but that may not be the final solution for this mocking.
1092         We'll try it and see.
1093
1094         * Scripts/webkitpy/common/system/platform.py: Added.
1095         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1096         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1097         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1098         * Scripts/webkitpy/tool/main.py:
1099         * Scripts/webkitpy/tool/mocktool.py:
1100
1101 2010-12-10  Krithigassree Sambamurthy  <krithigassree.sambamurthy@nokia.com>
1102
1103         Reviewed by Joseph Pecoraro.
1104
1105         Bug 43455 - [Qt]: Implement Application Cache Quotas
1106         https://bugs.webkit.org/show_bug.cgi?id=43455
1107
1108         Introduce functions to allow new appcache layout test origin-quota.html
1109         to work correctly under Qt.
1110
1111         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1112         (WebCore::DumpRenderTree::DumpRenderTree):
1113         (WebCore::DumpRenderTree::dumpApplicationCacheQuota):
1114         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1115
1116         Introduce functions to allow new appcache layout test origin-quota.html
1117         to be successful under qt. Changes required because LayoutTestControllerQt
1118         does not inherit from LayoutController.
1119
1120         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1121         (LayoutTestController::reset):
1122         (LayoutTestController::clearAllApplicationCaches):
1123         (LayoutTestController::setApplicationCacheOriginQuota):
1124         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1125         (LayoutTestController::shouldDumpApplicationCacheDelegateCallbacks):
1126         (LayoutTestController::dumpApplicationCacheDelegateCallbacks):
1127
1128 2010-12-10  Eric Seidel  <eric@webkit.org>
1129
1130         Reviewed by Adam Barth.
1131
1132         Move buildbot.py into its own module so we can split it out into one-file-per-class
1133         https://bugs.webkit.org/show_bug.cgi?id=50806
1134
1135         We're adding more buildbot logic these days, so it makes sense
1136         to give buildbot its own module.
1137
1138         * Scripts/webkitpy/common/net/buildbot/__init__.py: Added.
1139         * Scripts/webkitpy/common/net/buildbot/buildbot.py: Renamed from WebKitTools/Scripts/webkitpy/common/net/buildbot.py.
1140         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py: Renamed from WebKitTools/Scripts/webkitpy/common/net/buildbot_unittest.py.
1141         * Scripts/webkitpy/common/net/failuremap.py:
1142         * Scripts/webkitpy/common/net/regressionwindow.py:
1143         * Scripts/webkitpy/tool/commands/rebaseline.py:
1144
1145 2010-12-10  Tony Chang  <tony@chromium.org>
1146
1147         Reviewed by Eric Seidel.
1148
1149         Use FileSystem::remove when cleaning up http lock files
1150         https://bugs.webkit.org/show_bug.cgi?id=50830
1151
1152         * Scripts/webkitpy/layout_tests/port/http_lock.py:
1153
1154 2010-12-10  Joone Hur  <joone@kldp.org>
1155
1156         Reviewed by Martin Robinson.
1157
1158         [GTK] DRT needs layoutTestController.setCacheModel
1159         https://bugs.webkit.org/show_bug.cgi?id=50705
1160         
1161         webkit_set_cache_mode() is called to set the cache model.
1162         
1163         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1164         (LayoutTestController::setCacheModel): Set the cache model. 
1165
1166 2010-12-10  Tony Chang  <tony@chromium.org>
1167
1168         Reviewed by Ojan Vafai.
1169
1170         [chromium] remove --use-drt and add --use-test-shell
1171         https://bugs.webkit.org/show_bug.cgi?id=50701
1172
1173         * Scripts/webkitpy/common/config/ports.py:
1174         * Scripts/webkitpy/common/config/ports_unittest.py:
1175         * Scripts/webkitpy/layout_tests/port/chromium.py:
1176         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1177         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1178         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1179         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1180         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1181         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1182         * Scripts/webkitpy/layout_tests/port/webkit.py:
1183         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1184         * Scripts/webkitpy/style/checkers/test_expectations.py:
1185         * Scripts/webkitpy/tool/commands/queries.py:
1186
1187 2010-12-10  John Knottenbelt  <jknotten@chromium.org>
1188
1189         Reviewed by Steve Block.
1190
1191         [Chromium] Implement mocks for client-based geolocation
1192         https://bugs.webkit.org/show_bug.cgi?id=46895
1193
1194         * DumpRenderTree/chromium/LayoutTestController.cpp:
1195         (LayoutTestController::setGeolocationPermission):
1196         (LayoutTestController::setMockGeolocationPosition):
1197         (LayoutTestController::setMockGeolocationError):
1198         * DumpRenderTree/chromium/LayoutTestController.h:
1199         * DumpRenderTree/chromium/WebViewHost.cpp:
1200         (WebViewHost::geolocationClient):
1201         (WebViewHost::geolocationClientMock):
1202         (WebViewHost::reset):
1203         * DumpRenderTree/chromium/WebViewHost.h:
1204
1205 2010-12-10  Alejandro G. Castro  <alex@igalia.com>
1206
1207         Reviewed by Martin Robinson.
1208
1209         [GTK] Add hasSpellingMarker support to the DRT
1210         https://bugs.webkit.org/show_bug.cgi?id=50739
1211
1212         Implemented the hasSpellingMarker to support spelling tests.
1213
1214         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1215         (LayoutTestController::hasSpellingMarker):
1216
1217 2010-12-10  Eric Seidel  <eric@webkit.org>
1218
1219         Reviewed by Ojan Vafai.
1220
1221         webkit-patch: not possible to use build-and-test with local commits
1222         https://bugs.webkit.org/show_bug.cgi?id=33378
1223
1224         Make --no-clean not even check if we have local commits.
1225         It's unclear to me why the code was originally written this way.
1226         I was unable to dig up a reason from svn history.
1227
1228         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
1229         * Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py: Copied from WebKitTools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.
1230
1231 2010-12-10  Mario Sanchez Prada  <msanchez@igalia.com>
1232
1233         Reviewed by Martin Robinson.
1234
1235         [GTK] AX: implement isEnabled in DRT
1236         https://bugs.webkit.org/show_bug.cgi?id=50814
1237
1238         Implement AccessibilityUIElement::isEnabled() for GTK.
1239
1240         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1241         (checkElementState): New function to refactor common code.
1242         (AccessibilityUIElement::isEnabled): Implement this by checking
1243         the current state of the AtkObject.
1244         (AccessibilityUIElement::isSelected): Use the new
1245         checkElementState function.
1246
1247 2010-12-10  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
1248
1249         Reviewed by Kenneth Rohde Christiansen.
1250
1251         [Qt][WK2] Add the QWKContext API class to wrap the WebContext.
1252         https://bugs.webkit.org/show_bug.cgi?id=50750
1253
1254         * MiniBrowser/qt/BrowserView.cpp:
1255         (BrowserView::BrowserView):
1256         * MiniBrowser/qt/BrowserView.h:
1257         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1258         (WTR::WebView::WebView):
1259
1260 2010-12-10  Joone Hur  <joone@kldp.org>
1261
1262         Reviewed by Xan Lopez.
1263
1264         [GTK] Unskipping some test cases in userscripts dependent on addUserStyleSheet
1265         https://bugs.webkit.org/show_bug.cgi?id=50808
1266
1267         Unskipping the following test cases:
1268         userscripts/mixed-case-stylesheet.html
1269         userscripts/simple-stylesheet.html
1270         userscripts/user-style-all-frames.html
1271
1272         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1273         (LayoutTestController::addUserStyleSheet):
1274
1275 2010-12-10  Joone Hur  <joone@kldp.org>
1276
1277         Reviewed by Eric Seidel.
1278
1279         [GTK] Add DRT support for pageProperty, isPageBoxVisible, pageSizeAndMarginsInPixels, and addUserStyleSheet
1280         https://bugs.webkit.org/show_bug.cgi?id=50783
1281
1282         This patch allows to unskip the following test cases:
1283         printing/page-rule-selection.html
1284         printing/page-format-data.html
1285
1286         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1287         (LayoutTestController::pageProperty): Added.
1288         (LayoutTestController::isPageBoxVisible): Ditto.
1289         (LayoutTestController::pageSizeAndMarginsInPixels): Ditto.
1290         (LayoutTestController::addUserStyleSheet): Ditto.
1291
1292 2010-12-10  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
1293
1294         Reviewed by Kenneth Rohde Christiansen.
1295
1296         [Qt] Make QtTestBrowser spawn QNAM in a secondary thread.
1297
1298         A menu allows to switch QNAM back to the same thread.
1299
1300         * QtTestBrowser/launcherwindow.cpp:
1301         (LauncherWindow::initializeView):
1302         (LauncherWindow::createChrome):
1303         (LauncherWindow::toggleThreadedQnam):
1304         * QtTestBrowser/launcherwindow.h:
1305         (WindowOptions::WindowOptions):
1306         * QtTestBrowser/webpage.cpp:
1307         (WebPage::WebPage):
1308         (WebPage::setQnamThreaded):
1309         * QtTestBrowser/webpage.h:
1310         (QnamThread::QnamThread):
1311         (QnamThread::~QnamThread):
1312         (QnamThread::networkAccessManager):
1313         (QnamThread::run):
1314
1315 2010-12-10  Martin Robinson  <mrobinson@igalia.com>
1316
1317         Reviewed by Xan Lopez.
1318
1319         [Gtk] style="font-family: courier" makes text disappear
1320         https://bugs.webkit.org/show_bug.cgi?id=47452
1321
1322         Add a test that verifies that fonts without valid charmaps are
1323         never selected.
1324
1325         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1326         (initializeFonts): Initialize DRT with our font (derived from Ahem)
1327         that has no valid charmap.
1328         * DumpRenderTree/gtk/fonts/FontWithNoValidEncoding.fon: Added.
1329         * DumpRenderTree/gtk/fonts/fonts.conf: Updated settings to override users'
1330         settings which may disable selection of bitmap fonts.
1331
1332 2010-12-10  Eric Seidel  <eric@webkit.org>
1333
1334         Unreviewed.
1335
1336         The commit-queue should file bugs about flaky tests it encounters
1337         https://bugs.webkit.org/show_bug.cgi?id=50803
1338
1339         create_bug_for_flaky_test was insufficiently tested, thus buggy.
1340         Now it's tested.
1341
1342         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1343         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1344
1345 2010-12-10  Eric Seidel  <eric@webkit.org>
1346
1347         Unreviewed.  Somehow this last-minute edit didn't quite get committed.
1348
1349         The commit-queue should file bugs about flaky tests it encounters
1350         https://bugs.webkit.org/show_bug.cgi?id=50803
1351
1352         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1353
1354 2010-12-09  Eric Seidel  <eric@webkit.org>
1355
1356         Reviewed by Adam Barth.
1357
1358         The commit-queue should file bugs about flaky tests it encounters
1359         https://bugs.webkit.org/show_bug.cgi?id=50803
1360
1361         This change got a bit big.  I also added a new config.urls file
1362         because I needed to share the view_source_url code with committervalidator.py.
1363
1364         This adds a new class FlakyTestReporter which holds all the logic about
1365         reporting flaky tests to bugzilla.
1366
1367         Right now this code knows how to look up bugs for flaky tests.
1368         If it can't find a bug filed from the commit-queue, it will open a new
1369         one, ccing the relevant people and adding information about the failure.
1370
1371         It is not yet smart enough to chase down duplicate chains, or to include
1372         the actual failure diff.  But those can be added in later iterations.
1373
1374         * Scripts/webkitpy/common/checkout/api.py:
1375         * Scripts/webkitpy/common/checkout/changelog.py:
1376         * Scripts/webkitpy/common/checkout/commitinfo.py:
1377         * Scripts/webkitpy/common/config/committervalidator.py:
1378         * Scripts/webkitpy/common/config/urls.py: Copied from WebKitTools/Scripts/webkitpy/tool/comments.py.
1379         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1380         * Scripts/webkitpy/tool/bot/flakytestreporter.py: Added.
1381         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py: Copied from WebKitTools/Scripts/webkitpy/tool/comments.py.
1382         * Scripts/webkitpy/tool/bot/irc_command.py:
1383         * Scripts/webkitpy/tool/bot/sheriff.py:
1384         * Scripts/webkitpy/tool/commands/download.py:
1385         * Scripts/webkitpy/tool/commands/queues.py:
1386         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1387         * Scripts/webkitpy/tool/comments.py:
1388         * Scripts/webkitpy/tool/mocktool.py:
1389         * Scripts/webkitpy/tool/steps/commit.py:
1390
1391 2010-12-09  Eric Seidel  <eric@webkit.org>
1392
1393         Reviewed by Adam Barth.
1394
1395         Teach webkit-patch how to search bugzilla
1396         https://bugs.webkit.org/show_bug.cgi?id=50500
1397
1398         This is a step towards teaching webkitpy how to file
1399         new bugs for flaky tests and update them when new flakes occur.
1400
1401         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1402         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
1403         * Scripts/webkitpy/tool/commands/__init__.py:
1404         * Scripts/webkitpy/tool/commands/bugsearch.py: Added.
1405
1406 2010-12-09  Adam Barth  <abarth@webkit.org>
1407
1408         Reviewed by Ojan Vafai.
1409
1410         commit-queue errors out due to local commits
1411         https://bugs.webkit.org/show_bug.cgi?id=50766
1412
1413         We seem to be tripping over having local commits in the working copy a
1414         lot recently.  I don't quite fully understand what the issue is, but
1415         this patch attempts to solve the problem by adding an explicit clean
1416         step before processing a patch.  Previously, we did the cleaning as
1417         part of the apply-attachment step, so this might not actually fix the
1418         problem.
1419
1420         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1421         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1422         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1423
1424 2010-12-09  Dirk Pranke  <dpranke@chromium.org>
1425
1426         Reviewed by Ojan Vafai.
1427
1428         Make new-run-webkit-tests --lint-test-files log slightly better
1429         messages and return -1 if lint fails. Remove the
1430         'suppress_errors' keyword param to the TestExpectationsFile
1431         class, and clean up logging and exception raising for error
1432         handling. Also add more unit tests and clean up the unit test code a bit.
1433
1434         https://bugs.webkit.org/show_bug.cgi?id=50205
1435
1436         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1437         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1438         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py
1439         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py
1440         * Scripts/webkitpy/layout_tests/port/chromium.py:
1441         * Scripts/webkitpy/style/checkers/test_expectations.py:
1442         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1443
1444 2010-12-09  Tony Chang  <tony@chromium.org>
1445
1446         Unreviewed, fix for windows code.  We were catching the wrong
1447         exception in Windows.
1448
1449         * Scripts/webkitpy/common/system/filesystem.py:
1450
1451 2010-12-09  Antonio Gomes  <agomes@rim.com>
1452
1453         Reviewed by Martin Robinson.
1454
1455         [Gtk] Populate DumpRenderTreeSupportGtk (part IV)
1456         https://bugs.webkit.org/show_bug.cgi?id=48429
1457
1458         Adjust call sites of webkit_thread_count to use the DumpRenderTreeSupportGtk version now.
1459
1460         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1461         (LayoutTestController::workerThreadCount):
1462
1463 2010-12-06  Philippe Normand  <pnormand@igalia.com>
1464
1465         Reviewed by Martin Robinson.
1466
1467         [GTK] Support the Mozilla-style Fullscreen Javascript API
1468         https://bugs.webkit.org/show_bug.cgi?id=50572
1469
1470         Enable the Javascript Fullscreen support in the GtkLauncher. Also
1471         make DRT update the Chrome when the WebView settings have been
1472         reset to consistent values.
1473
1474         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1475         (resetDefaultsToConsistentValues):
1476         * GtkLauncher/main.c:
1477         (create_window):
1478         * Scripts/build-webkit:
1479
1480 2010-12-09  Koan-Sin Tan  <koansin.tan@gmail.com>
1481
1482         Reviewed by Tor Arne Vestbø
1483
1484         [Qt] run-launcher doesn't start the browser on Mac OS X 10.6
1485         https://bugs.webkit.org/show_bug.cgi?id=50742
1486
1487         check not only QtWebKit.framework/QtWebKit but also libQtWebKit.dylib
1488
1489         * Scripts/webkitdirs.pm:
1490
1491 2010-12-09  Joone Hur  <joone@kldp.org>
1492
1493          Reviewed by Martin Robinson.
1494
1495          [GTK] Support for viewport meta tag
1496          https://bugs.webkit.org/show_bug.cgi?id=45443
1497
1498          Add support for testing the viewport properties for WebKitGtk.
1499
1500          * DumpRenderTree/LayoutTestController.cpp:
1501          (dumpConfigurationForViewportCallback): Added this JS callback to set the size of the visible viewport.
1502          (LayoutTestController::staticFunctions):
1503          * DumpRenderTree/LayoutTestController.h:
1504          * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1505          (LayoutTestController::dumpConfigurationForViewport): Added this function to test the viewport properties.
1506          * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1507          (LayoutTestController::dumpConfigurationForViewport): Ditto.
1508          * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1509          (LayoutTestController::dumpConfigurationForViewport): Ditto.
1510          * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1511          (LayoutTestController::dumpConfigurationForViewport): Ditto.
1512          * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1513          (LayoutTestController::dumpConfigurationForViewport): Ditto.
1514
1515 2010-12-08  William Siegrist <wsiegrist@apple.com>
1516
1517         Reviewed by Eric Seidel.
1518
1519         Migrate buildbot.py from xmlrpc to json.
1520         https://bugs.webkit.org/show_bug.cgi?id=50647
1521
1522         * Scripts/webkitpy/common/net/buildbot.py:
1523
1524 2010-12-08  Tony Chang  <tony@chromium.org>
1525
1526         Reviewed by Eric Seidel.
1527
1528         make starting the websocket server more reliable on windows
1529         https://bugs.webkit.org/show_bug.cgi?id=50712
1530
1531         * Scripts/webkitpy/common/system/filesystem.py:
1532         (remove): Substitute method for os.remove to retry on error on Windows
1533         * Scripts/webkitpy/common/system/filesystem_unittest.py:
1534         * Scripts/webkitpy/layout_tests/port/http_server_base.py: Use FileSystem.remove
1535
1536 2010-12-08  Jessie Berlin  <jberlin@apple.com>
1537
1538         Reviewed by Adam Roben.
1539
1540         WebKit2: Implement WebChromeClient::exceededDatabaseQuota
1541         https://bugs.webkit.org/show_bug.cgi?id=50656
1542
1543         * MiniBrowser/mac/BrowserWindowController.m:
1544         (-[BrowserWindowController awakeFromNib]):
1545         Indicate that exceededDatabaseQuota is not implemented.
1546         * MiniBrowser/win/BrowserView.cpp:
1547         (BrowserView::create):
1548         Ditto.
1549         * WebKitTestRunner/TestController.cpp:
1550         (WTR::createOtherPage):
1551         Ditto.
1552         (WTR::TestController::initialize):
1553         Ditto.
1554
1555 2010-12-08  Antonio Gomes  <agomes@rim.com>
1556
1557         Reviewed by Martin Robinson.
1558
1559         [Gtk] Populate DumpRenderTreeSupportGtk (part III)
1560         https://bugs.webkit.org/show_bug.cgi?id=48429
1561
1562         Moved the following methods from webkitprivate.h to DumpRenderTreeSupportGtk.cpp|h:
1563         * webkit_gc_collect_javascript_objects;
1564         * webkit_gc_collect_javascript_objects_on_alternate_thread;
1565         * webkit_gc_count_javascript_objects;
1566         * webkit_web_frame_layout.
1567
1568         These were all only used by GTK+ DRT.
1569
1570         * DumpRenderTree/gtk/EventSender.cpp:
1571         (dispatchEvent):
1572         * DumpRenderTree/gtk/GCControllerGtk.cpp:
1573         (GCController::collect):
1574         (GCController::collectOnAlternateThread):
1575         (GCController::getJSObjectCount):
1576
1577 2010-12-07  Tony Chang  <tony@chromium.org>
1578
1579         Reviewed by Ojan Vafai.
1580
1581         [chromium] force NRWT to use DRT
1582         https://bugs.webkit.org/show_bug.cgi?id=50359
1583
1584         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1585
1586 2010-12-06  Sam Weinig  <sam@webkit.org>
1587
1588         Reviewed by Anders Carlsson.
1589
1590         Generalize didChangeLocationWithinPageForFrame for all same document navigations
1591         https://bugs.webkit.org/show_bug.cgi?id=50584
1592
1593         * MiniBrowser/mac/BrowserWindowController.m:
1594         (didSameDocumentNavigationForFrame):
1595         (-[BrowserWindowController awakeFromNib]):
1596         (-[BrowserWindowController didSameDocumentNavigationForFrame:]):
1597         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
1598         (TestWebKitAPI::didSameDocumentNavigationForFrame):
1599         (TestWebKitAPI::TEST):
1600         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1601         (WTR::InjectedBundlePage::InjectedBundlePage):
1602         (WTR::InjectedBundlePage::didSameDocumentNavigationForFrame):
1603         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1604         * WebKitTestRunner/TestController.cpp:
1605         (WTR::TestController::initialize):
1606
1607 2010-12-06  Kinuko Yasuda  <kinuko@chromium.org>
1608
1609         Reviewed by Ojan Vafai.
1610
1611         Make TestResultsServer return 404 for non-existing results files.
1612         https://bugs.webkit.org/show_bug.cgi?id=50581
1613
1614         * TestResultServer/handlers/testfilehandler.py:
1615
1616 2010-12-06  Tony Chang  <tony@chromium.org>
1617
1618         Reviewed by Ojan Vafai.
1619
1620         [chromium] fix an assert hit in DRT
1621         https://bugs.webkit.org/show_bug.cgi?id=50575
1622
1623         This class uses WTF's RefPtr, but expects chrome's base::RefPtr
1624         semantics.
1625
1626         Otherwise, we hit ASSERTION FAILED: !m_adoptionIsRequired
1627         (third_party/WebKit/JavaScriptCore/wtf/RefCounted.h:37 void
1628         WTF::RefCountedBase::ref()).
1629
1630         * DumpRenderTree/chromium/TestWebWorker.h:
1631         (TestWebWorker::TestWebWorker):
1632
1633 2010-12-02  Ojan Vafai  <ojan@chromium.org>
1634
1635         Reviewed by Eric Seidel.
1636
1637         make webkit-patch command work when the git branch is not synced to the remote svn branch
1638         https://bugs.webkit.org/show_bug.cgi?id=50424
1639
1640         * Scripts/webkitpy/common/checkout/scm.py:
1641         * Scripts/webkitpy/common/checkout/scm_unittest.py:
1642
1643 2010-12-06  Patrick Gansterer  <paroga@webkit.org>
1644
1645         Reviewed by Andreas Kling.
1646
1647         [WINCE] Add build system
1648         https://bugs.webkit.org/show_bug.cgi?id=50522
1649
1650         * CMakeListsWinCE.txt: Added.
1651
1652 2010-12-03  Mihai Parparita  <mihaip@chromium.org>
1653
1654         Reviewed by Tony Chang.
1655
1656         Allow the Chromium port to have Leopard-specific baselines
1657         https://bugs.webkit.org/show_bug.cgi?id=50506
1658
1659         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1660
1661 2010-12-03  Tony Chang  <tony@chromium.org>
1662
1663         Reviewed by Kent Tamura.
1664
1665         [chromium] fix 2 bugs with inspector tests in DRT
1666         https://bugs.webkit.org/show_bug.cgi?id=50492
1667
1668         Tasks can outlive the tasklist (even when canceled) so this was
1669         causing a crash when ~WebTask() ran.  Avoid this by unregistering
1670         when a task is canceled.
1671
1672         Also fix an assert when closing devtool windows by copying some
1673         logic from test_shell.
1674
1675         * DumpRenderTree/chromium/Task.cpp:
1676         (WebTask::~WebTask):
1677         (TaskList::revokeAll):
1678         * DumpRenderTree/chromium/Task.h: Canceling a task now removes it from
1679             the tasklist (since the task can outlive the tasklist).
1680         * DumpRenderTree/chromium/TestShell.h:
1681         (TestShell::devToolsWebView):
1682         * DumpRenderTree/chromium/WebViewHost.cpp:
1683         (WebViewHost::~WebViewHost): Don't load about:blank when closing
1684             a window if the window has devtools loaded.  This avoids an
1685             ASSERT and matches test_shell.
1686
1687 2010-12-06  Alejandro G. Castro  <alex@igalia.com>
1688
1689         Reviewed by Martin Robinson.
1690
1691         [GTK] Fix GtkLauncher.c style, use webkit style
1692         https://bugs.webkit.org/show_bug.cgi?id=50542
1693
1694         * GtkLauncher/main.c:
1695         (activateUriEntryCb):
1696         (updateTitle):
1697         (linkHoverCb):
1698         (notifyTitleCb):
1699         (notifyLoadStatusCb):
1700         (notifyProgressCb):
1701         (destroyCb):
1702         (goBackCb):
1703         (goForwardCb):
1704         (create_webViewCb):
1705         (webViewReadyCb):
1706         (closeWebViewCb):
1707         (createBrowser):
1708         (createStatusbar):
1709         (createToolbar):
1710         (createWindow):
1711         (main):
1712
1713 2010-12-04  Antonio Gomes  <agomes@rim.com>
1714
1715         Reviewed by Martin Robinson.
1716
1717         [Gtk] Populate DumpRenderTreeSupportGtk (Part II)
1718         https://bugs.webkit.org/show_bug.cgi?id=48429
1719
1720         Moved more private method declared with WEBKIT_API to
1721         DumpRenderTreeSupportGtk, since they were only being used by DRT.
1722
1723         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1724         (resetDefaultsToConsistentValues):
1725         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1726         (LayoutTestController::addOriginAccessWhitelistEntry):
1727         (LayoutTestController::execCommand):
1728         (LayoutTestController::isCommandEnabled):
1729
1730 2010-12-04  Antonio Gomes  <agomes@rim.com>
1731
1732         Reviewed by Andreas Kling.
1733
1734         Removed extern webkit_web_view_set_group_name from gtk/DumpRenderTree.cpp
1735
1736         Method was removed by http://trac.webkit.org/changeset/71604
1737
1738         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1739
1740 2010-12-05  Alejandro G. Castro  <alex@igalia.com>
1741
1742         Reviewed by Xan Lopez.
1743
1744         [GTK] Fix compilation warnings reported by clang
1745         https://bugs.webkit.org/show_bug.cgi?id=50252
1746
1747         * GtkLauncher/main.c:
1748         (create_window): The create_statusbar function does not have
1749         parameters.
1750
1751 2010-12-05  Robert Hogan  <robert@webkit.org>
1752
1753         Reviewed by Andreas Kling.
1754
1755         [Qt] Zero-sized font does not yet work
1756
1757         Fix fast/text/font-size-zero.html
1758
1759         Copy other ports by setting minimumFontSize to 0 for DRT runs.
1760
1761         https://bugs.webkit.org/show_bug.cgi?id=49759
1762
1763         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1764         (WebCore::WebPage::WebPage):
1765
1766 2010-12-04  Sam Weinig  <sam@webkit.org>
1767
1768         Reviewed by Jon Honeycutt.
1769
1770         WebKit2: Need client functions to notify app when the url changes due to a fragment navigation
1771         https://bugs.webkit.org/show_bug.cgi?id=50511
1772
1773         Update tools for new didChangeLocationWithinPageForFrame client function (and changed bundle
1774         signature) and added a test for the functionality (PageLoadDidChangeLocationWithinPageForFrame.cpp)
1775
1776         * MiniBrowser/mac/BrowserWindowController.m:
1777         (didChangeLocationWithinPageForFrame):
1778         (-[BrowserWindowController awakeFromNib]):
1779         (-[BrowserWindowController didChangeLocationWithinPageForFrame:]):
1780         * TestWebKitAPI/PlatformUtilities.cpp:
1781         (TestWebKitAPI::Util::toWK):
1782         * TestWebKitAPI/PlatformUtilities.h:
1783         (TestWebKitAPI::Util::adoptWK):
1784         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1785         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp: Added.
1786         (TestWebKitAPI::nullJavaScriptCallback):
1787         (TestWebKitAPI::didFinishLoadForFrame):
1788         (TestWebKitAPI::didChangeLocationWithinPageForFrame):
1789         (TestWebKitAPI::TEST):
1790         * TestWebKitAPI/Tests/WebKit2/file-with-anchor.html: Added.
1791         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1792         * TestWebKitAPI/win/copy-resources.cmd:
1793         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1794         (WTR::InjectedBundlePage::InjectedBundlePage):
1795         (WTR::InjectedBundlePage::didChangeLocationWithinPageForFrame):
1796         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1797         * WebKitTestRunner/TestController.cpp:
1798         (WTR::TestController::initialize):
1799
1800 2010-11-08  Antonio Gomes  <agomes@rim.com>
1801
1802         Reviewed by Martin Robinson.
1803
1804         [Gtk] Populate DumpRenderTreeSupportGtk
1805         https://bugs.webkit.org/show_bug.cgi?id=48429
1806
1807         Made the previous calls to webkit_web_frame* functions defined as private
1808         APIs in webkitprivate.h go through DRTSupportGtk.
1809
1810         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
1811         (AccessibilityController::focusedElement):
1812         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1813         (dumpFramesAsText):
1814         (resetDefaultsToConsistentValues):
1815         (dump):
1816         (webViewDocumentLoadFinished):
1817         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1818         (LayoutTestController::counterValueForElementById):
1819         (LayoutTestController::pageNumberForElementById):
1820         (LayoutTestController::numberOfPages):
1821         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
1822         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
1823         (LayoutTestController::sampleSVGAnimationForElementAtTime):
1824         (LayoutTestController::numberOfActiveAnimations):
1825         (LayoutTestController::suspendAnimations):
1826         (LayoutTestController::resumeAnimations):
1827         (LayoutTestController::markerTextForListItem):
1828
1829 2010-12-03  Mihai Parparita  <mihaip@chromium.org>
1830
1831         Reviewed by Tony Chang.
1832
1833         Rebaseline server: use pretty text diff output
1834         https://bugs.webkit.org/show_bug.cgi?id=50484
1835         
1836         Serve *-pretty-diff.html for text diff output.
1837
1838         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
1839         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
1840         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
1841         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
1842
1843 2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
1844
1845         Unreviewed, rolling out r73302.
1846         http://trac.webkit.org/changeset/73302
1847         https://bugs.webkit.org/show_bug.cgi?id=50499
1848
1849         Causes crashes in debug LayoutTests (Requested by xan_ on
1850         #webkit).
1851
1852         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
1853         (AccessibilityUIElement::AccessibilityUIElement):
1854         (AccessibilityUIElement::parentElementCallback):
1855         * DumpRenderTree/chromium/AccessibilityUIElement.h:
1856         * DumpRenderTree/chromium/CppBoundClass.cpp:
1857         * DumpRenderTree/chromium/CppBoundClass.h:
1858
1859 2010-12-03  Sam Weinig  <sam@webkit.org>
1860
1861         Reviewed by Maciej Stachowiak.
1862
1863         Enable <a ping> for Mac/Windows/WebKit2 builds
1864         <rdar://problem/8504473>
1865         https://bugs.webkit.org/show_bug.cgi?id=50488
1866
1867         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
1868         (TestWebKitAPI::TEST): Test that the default value of
1869         WKPreferencesGetHyperlinkAuditingEnabled is true.
1870
1871 2010-12-03  Chris Guillory  <chris.guillory@google.com>
1872
1873         Reviewed by Chris Fleizach.
1874
1875         Include the FrameView widget of a RenderWidget in the accessibility tree.
1876         https://bugs.webkit.org/show_bug.cgi?id=49106
1877
1878         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
1879         (AccessibilityUIElement::AccessibilityUIElement):
1880         (AccessibilityUIElement::parentElementCallback):
1881         (AccessibilityUIElement::isEqualCallback):
1882         * DumpRenderTree/chromium/AccessibilityUIElement.h:
1883         * DumpRenderTree/chromium/CppBoundClass.cpp:
1884         (CppBoundClass::getFromCppVariant):
1885         * DumpRenderTree/chromium/CppBoundClass.h:
1886
1887 2010-12-03  Mihai Parparita  <mihaip@chromium.org>
1888
1889         Reviewed by Tony Chang.
1890
1891         Rebaseline server: organize tests by state, add dry run mode
1892         https://bugs.webkit.org/show_bug.cgi?id=50473
1893         
1894         Group tests in the menu by state, so that it's easier to see after
1895         processing the queue which failed.
1896         
1897         Add support for the --dry-run flag so that it's easier to test changes
1898         such as this (stubs out filesystem and SCM operations).
1899
1900         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
1901         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js:
1902         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
1903
1904 2010-12-03  Brady Eidson  <beidson@apple.com>
1905
1906         Reviewed by Anders Carlsson.
1907
1908         Groundwork for <rdar://problem/7660733> and https://bugs.webkit.org/show_bug.cgi?id=50191
1909         WebKit2 Authentication Support
1910
1911         Keep these builds working:
1912         * MiniBrowser/mac/BrowserWindowController.m:
1913         (-[BrowserWindowController awakeFromNib]):
1914
1915         * WebKitTestRunner/TestController.cpp:
1916         (WTR::TestController::initialize):
1917
1918 2010-12-02  Mihai Parparita  <mihaip@chromium.org>
1919
1920         Reviewed by Tony Chang.
1921
1922         Rebaseline server: move existing baselines
1923         https://bugs.webkit.org/show_bug.cgi?id=50421
1924         
1925         Implement moving of existing baselines: move all files that are about
1926         to be overwriten by update baselines.
1927         
1928         Also fix a typo in the UI JS.
1929
1930         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js:
1931         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
1932         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py:
1933
1934 2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
1935
1936         Unreviewed, rolling out r73211.
1937         http://trac.webkit.org/changeset/73211
1938         https://bugs.webkit.org/show_bug.cgi?id=50450
1939
1940         Broke Chromium's "Webkit Win (dbg)(2)" bot. (Requested by
1941         yutak on #webkit).
1942
1943         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1944
1945 2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
1946
1947         Unreviewed, rolling out r73222.
1948         http://trac.webkit.org/changeset/73222
1949         https://bugs.webkit.org/show_bug.cgi?id=50449
1950
1951         r73211 seemed to break Chromium's "Webkit Win (dbg)(2)" bot.
1952         (Requested by yutak on #webkit).
1953
1954         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1955         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
1956         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
1957         * Scripts/webkitpy/layout_tests/port/base.py:
1958         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1959         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1960
1961 2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
1962
1963         Unreviewed, rolling out r73228.
1964         http://trac.webkit.org/changeset/73228
1965         https://bugs.webkit.org/show_bug.cgi?id=50448
1966
1967         r73211 seemed to break Chromium's "Webkit Win (dbg)(2)" bot.
1968         (Requested by yutak on #webkit).
1969
1970         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1971         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
1972         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
1973         * Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py:
1974         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
1975
1976 2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
1977
1978         Unreviewed, rolling out r73231.
1979         http://trac.webkit.org/changeset/73231
1980         https://bugs.webkit.org/show_bug.cgi?id=50443
1981
1982         r73211 seemed to broke Chromium's "Webkit Win (dbg)(2)" bot.
1983         (Requested by yutak on #webkit).
1984
1985         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
1986         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
1987         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1988         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1989
1990 2010-12-03  David Levin  <levin@chromium.org>
1991
1992         Reviewed by Shinichiro Hamaji.
1993
1994         check-webkit-style: false positive reported for #if macro
1995         https://bugs.webkit.org/show_bug.cgi?id=48242
1996
1997         * Scripts/webkitpy/style/checkers/cpp.py: Adjusted check to avoid
1998           all preprocessor commands.
1999         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added test.
2000
2001 2010-12-02  Eric Seidel  <eric@webkit.org>
2002
2003         Reviewed by Adam Barth.
2004
2005         Update the EWSTools scripts to use modern-style git repos
2006         https://bugs.webkit.org/show_bug.cgi?id=50402
2007
2008         * EWSTools/create-webkit-git:
2009         * EWSTools/start-commit-queue.sh:
2010         * EWSTools/start-queue.sh:
2011
2012 2010-12-02  Simon Fraser  <simon.fraser@apple.com>
2013
2014         Fix Chromium Linux plugin tests by not logging
2015         unconditionally from the event handling code.
2016
2017         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2018         (handleEventX11):
2019
2020 2010-12-02  Dirk Pranke  <dpranke@chromium.org>
2021
2022         Reviewed by Tony Chang.
2023
2024         nrwt multiprocessing - move logic back into run_webkit_tests
2025
2026         This change moves a bunch of logic that I had put into
2027         message_broker back into run_webkit_tests, in a slightly
2028         different format. WorkerMessageBroker needed to become less aware of
2029         the logic the TestRunner class uses, and more generic.
2030         Eventually the MessageBroker will only do generic messaging and
2031         thread/process-pooling, and (almost) all of the
2032         run-webkit-tests-specific logic will be moved to
2033         run_webkit_tests.py and dump_render_tree_thread.py.
2034         
2035         The biggest changes are that the Broker can now start a single
2036         worker, but the responsibility for starting all of them is pushed
2037         back to the TestRunner (Manager), and the logic for checking if
2038         the threads are done or wedged is moved back to TestRunner. We
2039         also remove WorkerMessageBroker.cleanup (not needed) and
2040         cancel_workers (they have to be cancelled individually).
2041         
2042         The  message_broker is now encapsulated inside
2043         TestRunner._run_tests(); it only needs to exist while actually
2044         running the tests.
2045
2046         Also, delete a bunch of tests in message_broker_unittest that no
2047         longer make much sense.
2048
2049         This patch depends on bug 50372.
2050
2051         https://bugs.webkit.org/show_bug.cgi?id=50374
2052
2053         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2054         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
2055         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
2056         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2057         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2058
2059 2010-12-02  Hayato Ito  <hayato@chromium.org>
2060
2061         Reviewed by Eric Seidel.
2062
2063         Refactor test_types's compare_output() method so that it takes a
2064         TestInput object.
2065
2066         compare_output() will need additional information included in a TestInput
2067         object to support reftests. This change is a pre-requirement of that.
2068
2069         https://bugs.webkit.org/show_bug.cgi?id=50362
2070
2071         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2072         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
2073         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
2074         * Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py:
2075         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
2076
2077 2010-12-02  Simon Fraser  <simon.fraser@apple.com>
2078
2079         Reviewed by Anders Carlsson.
2080
2081         Add the ability to run script on 'new' and 'paint' in the test plugin
2082         https://bugs.webkit.org/show_bug.cgi?id=50425
2083         
2084         Add "onnew" and "onpaintevent" attributes to the test plugin,
2085         so that tests can run JS at these times.
2086
2087         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
2088         (pluginAllocate):
2089         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
2090         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2091         (NPP_New):
2092         (NPP_Destroy):
2093         (handleEventCarbon):
2094         (handleEventCocoa):
2095         (NPP_HandleEvent):
2096
2097 2010-12-02  Sam Weinig  <sam@webkit.org>
2098
2099         Fix Qt build.
2100
2101         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2102         (WTR::PlatformWebView::PlatformWebView):
2103
2104 2010-12-02  Sam Weinig  <sam@webkit.org>
2105
2106         Reviewed by Anders Carlsson.
2107
2108         WebKit2 Preferences should be held off the PageGroup, not the Context
2109         https://bugs.webkit.org/show_bug.cgi?id=50414
2110
2111         Update for API changes.
2112
2113         * WebKitTestRunner/PlatformWebView.h:
2114         * WebKitTestRunner/TestController.cpp:
2115         (WTR::createOtherPage):
2116         (WTR::TestController::initialize):
2117         (WTR::TestController::resetStateToConsistentValues):
2118         * WebKitTestRunner/TestController.h:
2119         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2120         (WTR::PlatformWebView::PlatformWebView):
2121         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2122         (WTR::PlatformWebView::PlatformWebView):
2123
2124 2010-12-02  Dirk Pranke  <dpranke@chromium.org>
2125
2126         Reviewed by Tony Chang.
2127
2128         new-run-webkit-tests: minor cleanup for multiprocessing work
2129
2130         This change:
2131         * moves worker naming into TestShellThread, eliminating a
2132           parameter to the constructor and putting the responsibility in
2133           the correct place.
2134         * eliminates the _WorkerState() class in message_broker, because
2135           it turns out that state really needs to be in run_webkit_tests
2136         * renames the Broker classes to be module-private.
2137         * fixes a bunch of minor commenting and whitespace issues to
2138           make subsequent patches a bit clearer.
2139         * Adds a Port hook for default_worker_model() so that we can
2140           accomodate the potential for different worker models on
2141           different ports.
2142         * merge in the fix from 50420 for the brokenness introduced in
2143           bug 50367.
2144
2145         This patch depends on bug 50367.
2146
2147         https://bugs.webkit.org/show_bug.cgi?id=50372
2148
2149         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2150         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
2151         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
2152         * Scripts/webkitpy/layout_tests/port/base.py:
2153         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2154         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2155
2156 2010-12-02  Dirk Pranke  <dpranke@chromium.org>
2157
2158         Reviewed by Tony Chang.
2159
2160         This change is a bunch of cleanup / refactoring of the file
2161         below. It moves a bunch of free functions to methods on the
2162         TestShellThread class, and restructures other methods to be
2163         closer to the structure we'll need for the multiprocessing
2164         rewrite.
2165
2166         It also makes the logic of --run-singly a *lot* easier to follow
2167         by nestling all of the separate-thread logic into a single
2168         routine.
2169
2170         There should be no semantic changes in this patch, just cleanup.
2171
2172         https://bugs.webkit.org/show_bug.cgi?id=50367
2173
2174         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2175
2176 2010-12-02  Tony Chang  <tony@chromium.org>
2177
2178         Unreviewed, rolling out r73164.
2179         http://trac.webkit.org/changeset/73164
2180         https://bugs.webkit.org/show_bug.cgi?id=50359
2181
2182         broke debugger tests on win
2183
2184         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2185
2186 2010-11-30  Mihai Parparita  <mihaip@chromium.org>
2187
2188         Reviewed by Tony Chang.
2189
2190         Rebaseline server: add updating of baselines
2191         https://bugs.webkit.org/show_bug.cgi?id=50305
2192         
2193         Implements updating of baselines, where we copy -actual.* files over
2194         the current -expected.* files. To do this, we need a
2195         _get_actual_result_files method to get test results files and a
2196         _rebaseline_test method to actually do the file copy and SCM operation.
2197         _rebaseline_test logs output into a buffer, this is useful for both
2198         showing result in the UI and for unit tests.
2199         
2200         To make passing around of the various test environment properties
2201         (results directory, filesystem, SCM, etc) easier, add a TestConfig
2202         class for them.
2203         
2204         Moving of existing baselines is not implemented yet, this patch is big
2205         enough as it is.
2206
2207         * Scripts/webkitpy/common/system/filesystem.py:
2208         * Scripts/webkitpy/common/system/filesystem_mock.py:
2209         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js:
2210         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
2211         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py:
2212         * Scripts/webkitpy/tool/mocktool.py:
2213
2214 2010-12-02  Brent Fulgham  <bfulgham@webkit.org>
2215
2216         Unreviewed build fix after vcproj updates.
2217
2218         * DumpRenderTree/win/DumpRenderTreeCairo.vsprops: Make sure
2219         that WIN_CAIRO is defined for this build.
2220         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd: Update file
2221         to reflect new 'Debug_Cairo_CFLite' and 'Release_Cairo_CFLite'
2222         (these were previously 'Debug_Cairo' and 'Release_Cairo'
2223
2224 2010-12-02  Sam Weinig  <sam@webkit.org>
2225
2226         Reviewed by Anders Carlsson.
2227
2228         WebKit2 needs API to turn on popup blocking
2229         https://bugs.webkit.org/show_bug.cgi?id=50407
2230
2231         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
2232         (TestWebKitAPI::TEST):
2233         * WebKitTestRunner/TestController.cpp:
2234         (WTR::TestController::resetStateToConsistentValues):
2235
2236 2010-12-01  Tony Chang  <tony@chromium.org>
2237
2238         Reviewed by Ojan Vafai.
2239
2240         [chromium] force NRWT to use DRT
2241         https://bugs.webkit.org/show_bug.cgi?id=50359
2242
2243         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2244
2245 2010-12-02  Martin Robinson  <mrobinson@igalia.com>
2246
2247         Reviewed by Xan Lopez.
2248
2249         [GTK] DumpRenderTree has two copies of JavaScriptCore
2250         https://bugs.webkit.org/show_bug.cgi?id=49877
2251
2252         * GNUmakefile.am: Remove the second copy of JavaScriptCore from the
2253         LDADD list for DumpRenderTree.
2254
2255 2010-12-02  Sergio Villar Senin  <svillar@igalia.com>
2256
2257         Unreviewed: Added myself to list of Committers.
2258
2259         * Scripts/webkitpy/common/config/committers.py:
2260
2261 2010-12-01  Mihai Parparita  <mihaip@chromium.org>
2262
2263         Reviewed by Adam Barth.
2264
2265         build-webkit --chromium always updates DEPS and re-generates project files
2266         https://bugs.webkit.org/show_bug.cgi?id=50340
2267         
2268         Make build-webkit --chromium invoke update-webkit-chromium only when
2269         --update-chromium is passed in, so that we don't add 20 seconds to all
2270         builds.
2271         
2272         Making all invocations update was added with r61883, with the goal of
2273         making EWS bots always update. The bots will switch to using this flag
2274         (as will all other webkit-patch build steps) so nothing should change
2275         for them.
2276
2277         * Scripts/webkitdirs.pm:
2278         * Scripts/webkitpy/common/config/ports.py:
2279         * Scripts/webkitpy/common/config/ports_unittest.py:
2280
2281 2010-12-01  Dirk Pranke  <dpranke@chromium.org>
2282
2283         Reviewed by Tony Chang.
2284
2285         new-run-webkit-tests: add a --dry-run / -n flag
2286         https://bugs.webkit.org/show_bug.cgi?id=50045
2287
2288         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2289         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2290
2291 2010-12-01  Steve Falkenburg  <sfalken@apple.com>
2292
2293         Reviewed by Adam Roben.
2294
2295         WinCairo build should not use link-time code generation (LTCG)
2296         https://bugs.webkit.org/show_bug.cgi?id=50353
2297
2298         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2299         * DumpRenderTree/win/DumpRenderTree.vcproj:
2300         * DumpRenderTree/win/ImageDiff.vcproj:
2301         * FindSafari/FindSafari.vcproj:
2302         * MiniBrowser/MiniBrowser.vcproj:
2303         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2304         * WebKitAPITest/WebKitAPITest.vcproj:
2305         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
2306         * WebKitTestRunner/win/InjectedBundle.vcproj:
2307         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
2308         * WinLauncher/WinLauncher.vcproj:
2309         * record-memory-win/record-memory-win.vcproj:
2310
2311 2010-12-01  Martin Robinson  <mrobinson@igalia.com>
2312
2313         Touch GetUserAgentWithNullNPPFromNPPNew.cpp in an effort to force
2314         a rebuild of TestNetscapePlugin.la on GTK+. It seems that simply
2315         adding the file to the sources list was not enough to force the rebuild.
2316
2317         * DumpRenderTree/TestNetscapePlugIn/Tests/GetUserAgentWithNullNPPFromNPPNew.cpp:
2318         Remove an empty line at the end of this file to force a rebuild.
2319
2320 2010-12-01  Sam Weinig  <sam@webkit.org>
2321
2322         Fix windows build.
2323
2324         * MiniBrowser/win/BrowserView.cpp:
2325         (BrowserView::create):
2326
2327 2010-12-01  Martin Robinson  <mrobinson@igalia.com>
2328
2329         Add missing file to the TestNetscapePlugin sources list after r73057.
2330
2331         * GNUmakefile.am: Add missing file.
2332
2333 2010-12-01  Sam Weinig  <sam@webkit.org>
2334
2335         Reviewed by Anders Carlsson.
2336
2337         Add PageGrouping to WebKit2 API
2338         https://bugs.webkit.org/show_bug.cgi?id=50332
2339
2340         - Update testing harnesses to deal with new PageGroup API.
2341
2342         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
2343         (WKBundleInitialize):
2344         * TestWebKitAPI/InjectedBundleController.cpp:
2345         (TestWebKitAPI::InjectedBundleController::initialize):
2346         (TestWebKitAPI::InjectedBundleController::didInitializePageGroup):
2347         (TestWebKitAPI::InjectedBundleController::initializeTestNamed):
2348         * TestWebKitAPI/InjectedBundleController.h:
2349         * TestWebKitAPI/InjectedBundleTest.h:
2350         (TestWebKitAPI::InjectedBundleTest::initialize):
2351         (TestWebKitAPI::InjectedBundleTest::didInitializePageGroup):
2352         * TestWebKitAPI/PlatformUtilities.cpp:
2353         (TestWebKitAPI::Util::createContextForInjectedBundleTest):
2354         * TestWebKitAPI/PlatformUtilities.h:
2355         * TestWebKitAPI/PlatformWebView.h:
2356         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
2357         (TestWebKitAPI::TEST):
2358         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp:
2359         (TestWebKitAPI::DocumentStartUserScriptAlertCrashTest::initialize):
2360         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
2361         (TestWebKitAPI::PlatformWebView::PlatformWebView):
2362         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
2363         (TestWebKitAPI::PlatformWebView::PlatformWebView):
2364         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2365         (WTR::InjectedBundle::didInitializePageGroup):
2366         (WTR::InjectedBundle::initialize):
2367         (WTR::InjectedBundle::beginTesting):
2368         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2369         (WTR::InjectedBundle::pageGroup):
2370         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2371         (WTR::LayoutTestController::addUserScript):
2372         (WTR::LayoutTestController::addUserStyleSheet):
2373         (WTR::LayoutTestController::setXSSAuditorEnabled):
2374         * WebKitTestRunner/TestController.cpp:
2375         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2376         (WTR::PlatformWebView::PlatformWebView):
2377
2378 2010-12-01  Steve Falkenburg  <sfalken@apple.com>
2379
2380         Reviewed by Adam Roben.
2381
2382         vcproj changes can't be applied cleanly by the Windows EWS bot
2383         https://bugs.webkit.org/show_bug.cgi?id=50328
2384
2385         * CLWrapper/CLWrapper.sln: Modified property svn:eol-style.
2386         * CLWrapper/CLWrapper.vcproj: Modified property svn:eol-style.
2387         * DumpRenderTree/DumpRenderTree.sln: Modified property svn:eol-style.
2388         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops: Added property svn:eol-style.
2389         * DumpRenderTree/win/DumpRenderTree.vcproj: Modified property svn:eol-style.
2390         * DumpRenderTree/win/DumpRenderTreeApple.vsprops: Added property svn:eol-style.
2391         * DumpRenderTree/win/DumpRenderTreeCFLite.vsprops: Added property svn:eol-style.
2392         * DumpRenderTree/win/DumpRenderTreeCairo.vsprops: Added property svn:eol-style.
2393         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops: Added property svn:eol-style.
2394         * DumpRenderTree/win/ImageDiff.vcproj: Modified property svn:eol-style.
2395         * DumpRenderTree/win/ImageDiffCommon.vsprops: Added property svn:eol-style.
2396         * FindSafari/FindSafari.vcproj: Modified property svn:eol-style.
2397         * FindSafari/FindSafariCommon.vsprops: Added property svn:eol-style.
2398         * MIDLWrapper/MIDLWrapper.sln: Modified property svn:eol-style.
2399         * MIDLWrapper/MIDLWrapper.vcproj: Modified property svn:eol-style.
2400         * MiniBrowser/Configurations/MiniBrowserCFLite.vsprops: Added property svn:eol-style.
2401         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops: Added property svn:eol-style.
2402         * MiniBrowser/Configurations/MiniBrowserCoreFoundation.vsprops: Added property svn:eol-style.
2403         * MiniBrowser/MiniBrowser.vcproj: Added property svn:eol-style.
2404         * TestWebKitAPI/Configurations/TestWebKitAPICFLite.vsprops: Added property svn:eol-style.
2405         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops: Added property svn:eol-style.
2406         * TestWebKitAPI/Configurations/TestWebKitAPICoreFoundation.vsprops: Added property svn:eol-style.
2407         * TestWebKitAPI/win/TestWebKitAPI.sln: Added property svn:eol-style.
2408         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Added property svn:eol-style.
2409         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj: Added property svn:eol-style.
2410         * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops: Added property svn:eol-style.
2411         * WebKitAPITest/WebKitAPITest.vcproj: Added property svn:eol-style.
2412         * WebKitAPITest/WebKitAPITestCommon.vsprops: Added property svn:eol-style.
2413         * WebKitLauncherWin/WebKitLauncherWin.vcproj: Modified property svn:eol-style.
2414         * WebKitLauncherWin/WebKitLauncherWinCommon.vsprops: Added property svn:eol-style.
2415         * WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops: Added property svn:eol-style.
2416         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops: Added property svn:eol-style.
2417         * WebKitTestRunner/Configurations/InjectedBundleCoreFoundation.vsprops: Added property svn:eol-style.
2418         * WebKitTestRunner/Configurations/WebKitTestRunnerCFLite.vsprops: Added property svn:eol-style.
2419         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops: Added property svn:eol-style.
2420         * WebKitTestRunner/Configurations/WebKitTestRunnerCoreFoundation.vsprops: Added property svn:eol-style.
2421         * WebKitTestRunner/WebKitTestRunner.sln: Added property svn:eol-style.
2422         * WebKitTestRunner/win/InjectedBundle.vcproj: Added property svn:eol-style.
2423         * WebKitTestRunner/win/InjectedBundleGenerated.vcproj: Added property svn:eol-style.
2424         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops: Added property svn:eol-style.
2425         * WebKitTestRunner/win/WebKitTestRunner.vcproj: Added property svn:eol-style.
2426         * WinLauncher/WinLauncher.vcproj: Modified property svn:eol-style.
2427         * WinLauncher/WinLauncherCommon.vsprops: Added property svn:eol-style.
2428         * record-memory-win/record-memory-win-common.vsprops: Added property svn:eol-style.
2429         * record-memory-win/record-memory-win.vcproj: Modified property svn:eol-style.
2430
2431 2010-12-01  Anders Carlsson  <andersca@apple.com>
2432
2433         Reviewed by Darin Adler.
2434
2435         Return a correct user agent if NPN_UserAgent is called with a null NPP from NPP_New.
2436         https://bugs.webkit.org/show_bug.cgi?id=50336
2437
2438         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2439         Add new test.
2440
2441         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
2442         (PluginTest::NPP_New):
2443         Add default implementation/
2444
2445         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
2446         * DumpRenderTree/TestNetscapePlugIn/Tests/GetUserAgentWithNullNPPFromNPPNew.cpp: Added.
2447         (GetUserAgentWithNullNPPFromNPPNew::GetUserAgentWithNullNPPFromNPPNew):
2448         (GetUserAgentWithNullNPPFromNPPNew::NPP_New):
2449         Get the user agent.
2450
2451         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2452         (NPP_New):
2453         Call PluginTest::NPP_New.
2454
2455         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2456         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2457         Add new files.
2458
2459         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2460         (webkit_test_plugin_new_instance):
2461         Call PluginTest::NPP_New.
2462
2463 2010-12-01  Kevin Ollivier  <kevino@theolliviers.com>
2464
2465         [wx] Build fixes after recent trunk changes.
2466
2467         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2468         (LayoutTestController::findString):
2469         * wx/build/settings.py:
2470
2471 2010-12-01  Dan Bernstein  <mitz@apple.com>
2472
2473         Reviewed by Darin Adler.
2474
2475         WebKitTestRunner needs layoutTestController.findString
2476         https://bugs.webkit.org/show_bug.cgi?id=50238
2477
2478         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Added findString().
2479         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2480         (WTR::LayoutTestController::findString): Updated signature for autogenerated bindings.
2481         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Ditto.
2482
2483 2010-12-01  Steve Falkenburg  <sfalken@apple.com>
2484
2485         Try using svn:eol-style native on a vcproj file.
2486
2487         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Modified property svn:eol-style.
2488
2489 2010-12-01  Patrick Gansterer  <paroga@webkit.org>
2490
2491         Reviewed by Adam Roben.
2492
2493         [WINCE] Add WinCELauncher
2494         https://bugs.webkit.org/show_bug.cgi?id=50217
2495
2496         * WinCELauncher/main.cpp: Added.
2497
2498 2010-11-30  Benjamin Poulain  <benjamin.poulain@nokia.com>
2499
2500         Reviewed by Kenneth Rohde Christiansen.
2501
2502         [Qt] Implement layoutTestController.findString
2503         https://bugs.webkit.org/show_bug.cgi?id=50236
2504
2505         Add the missing function to the LayoutTestController.
2506
2507         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2508         (LayoutTestController::findString):
2509         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2510
2511 2010-11-30  Tony Chang  <tony@chromium.org>
2512
2513         Reviewed by Adam Barth.
2514
2515         [chromium] fix get-int-identifier-special-values.html using TestNetscapePlugIn
2516         https://bugs.webkit.org/show_bug.cgi?id=49036
2517
2518         * DumpRenderTree/chromium/LayoutTestController.cpp: Use IsNumber instead of IsInt32
2519             for CppVariants.
2520         (LayoutTestController::cppVariantToBool):
2521         (LayoutTestController::cppVariantToInt32):
2522         (LayoutTestController::setDatabaseQuota):
2523         (LayoutTestController::evaluateInWebInspector):
2524         (LayoutTestController::setMockGeolocationError):
2525
2526 2010-11-30  Eric Seidel  <eric@webkit.org>
2527
2528         Reviewed by Tony Chang.
2529
2530         update-webkit should call git fetch before git svn rebase
2531         https://bugs.webkit.org/show_bug.cgi?id=50273
2532
2533         After discussion on webkit-dev, we've decided to move the "default"
2534         git setup to pulling updates from git.webkit.org in preference
2535         to rebuilding the local svn index using git svn fetch every time.
2536
2537         This change should have no effect on people using the "old" git setup
2538         and should dramatically increase the speed of updates for those using
2539         the "new" git setup along with update-webkit.  I'm about to move the
2540         EWS and other queues over to this setup once this lands.
2541
2542         * Scripts/update-webkit:
2543
2544 2010-11-30  Mario Sanchez Prada  <msanchez@igalia.com>
2545
2546         Reviewed by Xan Lopez.
2547
2548         GTK: AX: implement press in DRT
2549         https://bugs.webkit.org/show_bug.cgi?id=36146
2550
2551         Implement AccessibilityUIElement::press() for GTK.
2552
2553         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2554         (AccessibilityUIElement::press): Implemented.
2555
2556 2010-11-29  Mihai Parparita  <mihaip@chromium.org>
2557
2558         Reviewed by Tony Chang.
2559
2560         config.webkit_base_dir returns a path with a trailing slash
2561         https://bugs.webkit.org/show_bug.cgi?id=50197
2562         
2563         config.webkit_base_dir() should return a path without a trailing slash,
2564         like all the other methods that return paths.
2565         
2566         Undoes MockFileSytem changes by r72640, since they're no longer
2567         necessary for GetBaselinesTest to pass.
2568
2569         * Scripts/webkitpy/common/system/filesystem_mock.py:
2570         * Scripts/webkitpy/layout_tests/port/base.py:
2571         * Scripts/webkitpy/layout_tests/port/config.py:
2572         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
2573
2574 2010-11-30  Mihai Parparita  <mihaip@chromium.org>
2575
2576         Reviewed by Tony Chang.
2577
2578         Rebaseline server: baseline display tweaks
2579         https://bugs.webkit.org/show_bug.cgi?id=50207
2580         
2581         Determine which baselines were used when running the tests and highlight
2582         them in the UI. Sort platform names alphabetically.
2583         
2584         Also makes the server URL be launched in the user's browser
2585         automatically.
2586
2587         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
2588         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
2589         * Scripts/webkitpy/tool/commands/data/rebaselineserver/util.js:
2590         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
2591         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py:
2592
2593 2010-11-30  Dan Bernstein  <mitz@apple.com>
2594
2595         Reviewed by Anders Carlsson.
2596
2597         <rdar://problem/8710645> WebKitTestRunner needs layoutTestController.findString
2598         https://bugs.webkit.org/show_bug.cgi?id=50238
2599
2600         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2601         (WTR::LayoutTestController::findString): Added.
2602         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2603
2604 2010-11-30  Steve Falkenburg  <sfalken@apple.com>
2605
2606         Reviewed by Adam Roben.
2607
2608         All projects on Windows should use cmd files for build events
2609         https://bugs.webkit.org/show_bug.cgi?id=50213
2610
2611         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops:
2612         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd: Added.
2613         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd: Added.
2614         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
2615         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd: Added.
2616         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd: Added.
2617         * DumpRenderTree/win/ImageDiffCommon.vsprops:
2618         * DumpRenderTree/win/ImageDiffPostBuild.cmd: Added.
2619         * DumpRenderTree/win/ImageDiffPreBuild.cmd: Added.
2620         * MiniBrowser/Configurations/MiniBrowserCFLite.vsprops:
2621         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
2622         * MiniBrowser/Configurations/MiniBrowserCoreFoundation.vsprops:
2623         * MiniBrowser/MiniBrowserPostBuild.cmd: Added.
2624         * MiniBrowser/MiniBrowserPreBuild.cmd: Added.
2625         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
2626         * TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd: Added.
2627         * TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd: Added.
2628         * WebKitAPITest/WebKitAPITestCommon.vsprops:
2629         * WebKitAPITest/WebKitAPITestPostBuild.cmd: Added.
2630         * WebKitAPITest/WebKitAPITestPreBuild.cmd: Added.
2631         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
2632         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
2633         * WebKitTestRunner/win/InjectedBundlePostBuild.cmd: Added.
2634         * WebKitTestRunner/win/InjectedBundlePreBuild.cmd: Added.
2635         * WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd: Added.
2636         * WebKitTestRunner/win/WebKitTestRunnerPreBuild.cmd: Added.
2637         * WinLauncher/WinLauncherCommon.vsprops:
2638         * WinLauncher/WinLauncherPostBuild.cmd: Added.
2639         * WinLauncher/WinLauncherPreBuild.cmd: Added.
2640
2641 2010-11-29  Dan Bernstein  <mitz@apple.com>
2642
2643         GTK DumpRenderTree build fix after r72887.
2644
2645         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2646         (LayoutTestController::findString):
2647
2648 2010-11-29  Dan Bernstein  <mitz@apple.com>
2649
2650         Windows DumpRenderTree build fix after r72887.
2651
2652         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2653         (LayoutTestController::findString): Added empty implementation.
2654
2655 2010-11-29  Dan Bernstein  <mitz@apple.com>
2656
2657         Reviewed by Darin Adler.
2658
2659         DumpRenderTree changes for testing the text search API.
2660         https://bugs.webkit.org/show_bug.cgi?id=50038
2661
2662         * DumpRenderTree/LayoutTestController.cpp:
2663         (findStringCallback):
2664         (LayoutTestController::staticFunctions):
2665         * DumpRenderTree/LayoutTestController.h:
2666         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2667         (LayoutTestController::findString):
2668         * MiniBrowser/mac/BrowserWindowController.m:
2669         (-[BrowserWindowController find:]):
2670
2671 2010-11-29  Johnny Ding  <jnd@chromium.org>
2672
2673         Unreviewed: Add myself to the list of Committers.
2674
2675         * Scripts/webkitpy/common/config/committers.py:
2676
2677 2010-11-29  Mark Rowe  <mrowe@apple.com>
2678
2679         Reviewed by Adele Peterson.
2680
2681         <rdar://problem/8694997> DumpRenderTree fails to build.
2682
2683         * DumpRenderTree/mac/PerlSupport/Makefile: Skip generating wrappers.
2684
2685 2010-11-29  Mark Rowe  <mrowe@apple.com>
2686
2687         Reviewed by Adele Peterson.
2688
2689         <rdar://problem/8694997> DumpRenderTree fails to build.
2690
2691         * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupportPregenerated.pm: Renamed from WebKitTools/DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupportTiger.pm.
2692         * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport_wrapPregenerated.c: Renamed from WebKitTools/DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport_wrapTiger.c.
2693         * DumpRenderTree/mac/PerlSupport/Makefile:
2694
2695 2010-11-29  Mario Sanchez Prada  <msanchez@igalia.com>
2696
2697         Reviewed by Martin Robinson.
2698
2699         [GTK] Null-check needed in DRT's AccessibilityUIElement::allAtributes()
2700         https://bugs.webkit.org/show_bug.cgi?id=50154
2701
2702         Added missing checks to allAttributes().
2703
2704         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2705         (AccessibilityUIElement::allAttributes): Added missing checks.
2706
2707 2010-11-29  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2708
2709         Reviewed by Kenneth Rohde Christiansen.
2710
2711         [Qt] Allow pre-generation for package builds for WebKit2
2712         https://bugs.webkit.org/show_bug.cgi?id=50139
2713
2714         Use a build variable for the generated directory path and set the
2715         value based on CONFIG just like for WebKit1.
2716
2717         For non-package builds use a relative base path for the
2718         genrated directory just like for WebKit1.
2719
2720         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2721         * WebKitTestRunner/qt/WebKitTestRunner.pro:
2722
2723 2010-11-28  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2724
2725         Reviewed by Kenneth Rohde Christiansen.
2726
2727         [Qt] Move some build logic from Qt to platform independent code
2728         https://bugs.webkit.org/show_bug.cgi?id=50134
2729
2730         Create target directories inside generate-forwarding-headers.pl.
2731
2732         * Scripts/generate-forwarding-headers.pl:
2733
2734 2010-11-24  Nicolas Dufresne  <nicolas.dufresne@collabora.co.uk>
2735
2736         Reviewed by Martin Robinson.
2737
2738         [GTK] Windowless plugins gets broken key input
2739         https://bugs.webkit.org/show_bug.cgi?id=49927
2740
2741         Convert the XEvent::keycode to ASCII before printing it. Not
2742         doing this was causing false positive in 
2743         plugins/keyboard-events.html.
2744
2745         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2746         (keycode_to_char):
2747         (webkit_test_plugin_handle_event):
2748
2749 2010-11-24  Jan Erik Hanssen  <jhanssen@sencha.com>
2750
2751         Reviewed by Antonio Gomes.
2752
2753         [Qt] Html autofocus not working with QGraphicsWebView
2754         https://bugs.webkit.org/show_bug.cgi?id=43169
2755
2756         Tell the scene to set the webview item as the currently
2757         focused item. This makes the input field with autofocus get
2758         focus as it should.
2759
2760         * QtTestBrowser/webview.cpp:
2761         (WebViewGraphicsBased::WebViewGraphicsBased):
2762
2763 2010-11-24  Dirk Pranke  <dpranke@chromium.org>
2764
2765         Reviewed by Tony Chang.
2766
2767         nrwt - clean up create_driver interface and print out the
2768         command line used for DumpRenderTree/TestShell.
2769
2770         This patch adds a driver_cmd_line() call to the Port class in
2771         order to retrive the command line to print it out (as part of
2772         --print config).
2773
2774         In addition, this patch cleans up the Port.create_driver()
2775         signature and the Driver constructor interface to take a worker
2776         number and no longer require the image_path argument (Chromium's
2777         drivers now synthesize the image_path from the worker number
2778         internally).
2779
2780         https://bugs.webkit.org/show_bug.cgi?id=49934
2781
2782         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2783         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
2784         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2785         * Scripts/webkitpy/layout_tests/port/base.py:
2786         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2787         * Scripts/webkitpy/layout_tests/port/chromium.py:
2788         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2789         * Scripts/webkitpy/layout_tests/port/dryrun.py:
2790         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2791         * Scripts/webkitpy/layout_tests/port/test.py:
2792         * Scripts/webkitpy/layout_tests/port/webkit.py:
2793         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2794         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2795
2796 2010-11-24  Ojan Vafai  <ojan@chromium.org>
2797
2798         Reviewed by Tony Chang.
2799
2800         [chromium] improve memory usage for test results server and store fewer runs
2801         https://bugs.webkit.org/show_bug.cgi?id=50035
2802
2803         Store fewer runs and don't pass full files around when we only need bools.
2804         Greatly improves error rates on test-results.appspot.com.
2805
2806         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2807         * TestResultServer/handlers/testfilehandler.py:
2808         * TestResultServer/model/dashboardfile.py:
2809         * TestResultServer/model/jsonresults.py:
2810
2811 2010-11-24  Dirk Pranke  <dpranke@chromium.org>
2812
2813         Reviewed by Tony Chang.
2814
2815         This patch implements the first part of the manager side of the
2816         Broker objects - it handles creating threads, waiting for them
2817         to complete, and running a single-threaded loop as well.
2818
2819         https://bugs.webkit.org/show_bug.cgi?id=49779
2820
2821         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
2822         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
2823         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2824         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2825
2826 2010-11-24  Mihai Parparita  <mihaip@chromium.org>
2827
2828         Reviewed by David Levin.
2829
2830         DRT should not generate pixel output for text/plain tests
2831         https://bugs.webkit.org/show_bug.cgi?id=50002
2832         
2833         Modify Mac, Windows and GTK DRT implementations to disable pixel output
2834         when encountering a text/plain response (the Chromium one already does
2835         this, and none of the other ports special-case text/plain output in
2836         the first place).
2837
2838         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2839         (dump):
2840         * DumpRenderTree/mac/DumpRenderTree.mm:
2841         (dump):
2842         * DumpRenderTree/win/DumpRenderTree.cpp:
2843         (dump):
2844
2845 2010-11-24  Andras Becsi  <abecsi@inf.u-szeged.hu>
2846
2847         Unreviewed.
2848
2849         Add my other email address to committers.py.
2850
2851         * Scripts/webkitpy/common/config/committers.py:
2852
2853 2010-11-24  Andras Becsi  <abecsi@inf.u-szeged.hu>
2854
2855         Reviewed by Csaba Osztrogonác.
2856
2857         Make build-webkit --minimal build with ENABLE_INSPECTOR=0
2858         https://bugs.webkit.org/show_bug.cgi?id=49975
2859
2860         * Scripts/build-webkit: Add ENABLE_INSPECTOR define to features,
2861         to enable the script to define it 0 in case of a minimal build.
2862
2863 2010-11-24  Martin Robinson  <mrobinson@igalia.com>
2864
2865         Reviewed by Xan Lopez.
2866
2867         [GTK] The WebKitWebView should expose a set of signals encapsulating the behavior of the EditorClient
2868         https://bugs.webkit.org/show_bug.cgi?id=49143
2869
2870         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2871         (createWebView): Call the new connectEditingCallbacks function.
2872         * DumpRenderTree/gtk/EditingCallbacks.cpp: Added.
2873         (dumpNodePath):
2874         (dumpRange):
2875         (insertActionString):
2876         (selectionAffinityString):
2877         (shouldBeginEditing):
2878         (shouldEndEditing):
2879         (shouldInsertNode):
2880         (shouldInsertText):
2881         (shouldDeleteRange):
2882         (shouldShowDeleteInterfaceForElement):
2883         (shouldChangeSelectedRange):
2884         (shouldApplyStyle):
2885         (editingBegan):
2886         (userChangedContents):
2887         (editingEnded):
2888         (selectionChanged):
2889         (connectEditingCallbacks):
2890         * DumpRenderTree/gtk/EditingCallbacks.h: Added.
2891         * GNUmakefile.am: Added EditingCallbacks.{h,cpp} to the source list.
2892
2893 2010-11-24  Yi Shen  <yi.4.shen@nokia.com>
2894
2895         Reviewed by Andreas Kling.
2896
2897         [Qt] Make QtTestBrowser remember the selected user agent
2898         https://bugs.webkit.org/show_bug.cgi?id=50021
2899
2900         Set user agent for a new page by using the old page's
2901
2902         * QtTestBrowser/mainwindow.cpp:
2903         (MainWindow::setPage):
2904
2905 2010-11-24 Patrick Gansterer <paroga@webkit.org>
2906
2907         Reviewed by Csaba Osztrogonác.
2908
2909         Remove Bakefile build system files
2910         https://bugs.webkit.org/show_bug.cgi?id=49983
2911
2912         r53757 only removed the content, but not the files.
2913         This patch removes that empty files.
2914
2915         * DumpRenderTree/wx/DumpRenderTree.bkl: Removed.
2916         * wx/browser/browser.bkl: Removed.
2917         * wx/build-wxwebkit: Removed.
2918
2919 2010-11-23  Dirk Pranke  <dpranke@chromium.org>
2920
2921         Reviewed by Tony Chang.
2922
2923         This patch cleans up the logic used to shard tests into groups a
2924         bit and adds the --worker-model flag to NRWT. The flag is only
2925         used at the moment to control whether to run single-threaded or
2926         not, but eventually will also allow toggling between threads and
2927         processes.
2928
2929         Also add a minor cleanup with _test_is_slow(), which just
2930         eliminates some repetition and gives slightly better encapsulation.
2931
2932         https://bugs.webkit.org/show_bug.cgi?id=49773
2933
2934         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2935         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2936
2937 2010-11-23  Mihai Parparita  <mihaip@chromium.org>
2938
2939         Reviewed by Tony Chang.
2940
2941         Rebaseline server: list current baselines and platforms
2942         https://bugs.webkit.org/show_bug.cgi?id=49991
2943         
2944         List existing baselines (with Trac links) for tests.
2945         
2946         Add dropdowns for choosing with platform baselines to target (and what
2947         to do with existing ones).
2948
2949         Also fix MockFileSystem.join to behave more like os.path.join (unit
2950         test was ending up with two consecutive slashes in a layout test
2951         path).        
2952
2953         * Scripts/webkitpy/common/system/filesystem_mock.py:
2954         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
2955         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
2956         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
2957         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js:
2958         * Scripts/webkitpy/tool/commands/data/rebaselineserver/util.js:
2959         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
2960         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py: Added.
2961
2962 2010-11-23  Ojan Vafai  <ojan@chromium.org>
2963
2964         Reviewed by Tony Chang.
2965
2966         remove timeout argument to urlopen
2967         https://bugs.webkit.org/show_bug.cgi?id=49995
2968
2969         Apparently the version of python we have on the bots doesn't accept a timeout argument.
2970
2971         * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py:
2972
2973 2010-11-23  Sheriff Bot  <webkit.review.bot@gmail.com>
2974
2975         Unreviewed, rolling out r72628.
2976         http://trac.webkit.org/changeset/72628
2977         https://bugs.webkit.org/show_bug.cgi?id=49994
2978
2979         This patch is causing layout-test failtures on GTK Linux
2980         64-bit Debug (Requested by ctguil on #webkit).
2981
2982         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
2983         (AccessibilityUIElement::AccessibilityUIElement):
2984         (AccessibilityUIElement::parentElementCallback):
2985         * DumpRenderTree/chromium/AccessibilityUIElement.h:
2986         * DumpRenderTree/chromium/CppBoundClass.cpp:
2987         * DumpRenderTree/chromium/CppBoundClass.h:
2988
2989 2010-11-22  Ojan Vafai  <ojan@chromium.org>
2990
2991         Reviewed by Tony Chang.
2992
2993         speculative fix for upload errors: stop using mechanize to upload to test-results.appspot.com
2994         https://bugs.webkit.org/show_bug.cgi?id=49944
2995
2996         * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py:
2997
2998 2010-11-23  Chris Guillory  <chris.guillory@google.com>
2999
3000         Reviewed by Dimitri Glazkov.
3001
3002         Include the FrameView widget of a RenderWidget in the accessibility tree.
3003         https://bugs.webkit.org/show_bug.cgi?id=49106
3004
3005         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
3006         (AccessibilityUIElement::AccessibilityUIElement):
3007         (AccessibilityUIElement::parentElementCallback):
3008         (AccessibilityUIElement::isEqualCallback):
3009         * DumpRenderTree/chromium/AccessibilityUIElement.h:
3010         * DumpRenderTree/chromium/CppBoundClass.cpp:
3011         (CppBoundClass::getFromCppVariant):
3012         * DumpRenderTree/chromium/CppBoundClass.h:
3013
3014 2010-11-23  Alex Grilo  <abgrilo@profusion.mobi>
3015
3016         Reviewed by Kenneth Rohde Christiansen.
3017
3018         [EFL] Add tiled backing store to EWebLauncher
3019         https://bugs.webkit.org/show_bug.cgi?id=45777
3020
3021         Allow EWebLauncher to choose between single and tiled backing store
3022
3023         * EWebLauncher/main.c:
3024         (on_key_down):
3025         (browserCreate):
3026         (main):
3027
3028 2010-11-23  Simon Hausmann  <simon.hausmann@nokia.com>
3029
3030         Reviewed by Tor Arne Vestbø.
3031
3032         [Qt] Review the setUserPermission & friends API
3033         https://bugs.webkit.org/show_bug.cgi?id=46810
3034
3035         Renamed requestPermissionFromUser to featurePermissionRequested
3036         and cancelRequestsForPermission to featurePermissionRequestCanceled.
3037
3038         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3039         (WebCore::WebPage::WebPage):
3040         * QtTestBrowser/webpage.cpp:
3041         (WebPage::WebPage):
3042         (WebPage::featurePermissionRequestCanceled):
3043         * QtTestBrowser/webpage.h:
3044
3045 2010-11-23  Simon Hausmann  <simon.hausmann@nokia.com>
3046
3047         Reviewed by Tor Arne Vestbø.
3048
3049         [Qt] Review the setUserPermission & friends API
3050         https://bugs.webkit.org/show_bug.cgi?id=46810
3051
3052         Rename setUserPermission to setFeaturePermission
3053
3054         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3055         (WebCore::WebPage::requestPermission):
3056         (WebCore::WebPage::permissionSet):
3057         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3058         (LayoutTestController::grantDesktopNotificationPermission):
3059         * QtTestBrowser/webpage.cpp:
3060         (WebPage::requestPermission):
3061
3062 2010-11-23  Simon Hausmann  <simon.hausmann@nokia.com>
3063
3064         Reviewed by Tor Arne Vestbø.
3065
3066         [Qt] Review the setUserPermission & friends API
3067         https://bugs.webkit.org/show_bug.cgi?id=46810
3068
3069         Rename PermissionDomain to Feature, NotificationsPermissionDomain to Notifications
3070         and GeolocationPermissionDomain to Geolocation.
3071
3072         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3073         (WebCore::WebPage::WebPage):
3074         (WebCore::WebPage::requestPermission):
3075         (WebCore::WebPage::cancelPermission):
3076         (WebCore::WebPage::permissionSet):
3077         (WebCore::DumpRenderTree::geolocationPermissionSet):
3078         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3079         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3080         (LayoutTestController::grantDesktopNotificationPermission):
3081         * QtTestBrowser/webpage.cpp:
3082         (WebPage::WebPage):
3083         (WebPage::requestPermission):
3084         (WebPage::cancelRequestsForPermission):
3085         * QtTestBrowser/webpage.h:
3086
3087 2010-11-23  Simon Hausmann  <simon.hausmann@nokia.com>
3088
3089         Reviewed by Tor Arne Vestbø.
3090
3091         [Qt] Review the setUserPermission & friends API
3092         https://bugs.webkit.org/show_bug.cgi?id=46810
3093
3094         Add a ByUser suffix to PermissionGranted/Denied. In the future
3095         we can add PermissionGrantedByDefault.
3096
3097
3098         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3099         (WebCore::WebPage::requestPermission):
3100         (WebCore::WebPage::permissionSet):
3101         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3102         (LayoutTestController::grantDesktopNotificationPermission):
3103         * QtTestBrowser/webpage.cpp:
3104         (WebPage::requestPermission):
3105
3106 2010-11-18  Satish Sampath  <satish@chromium.org>
3107
3108         Reviewed by Jeremy Orlow.
3109
3110         For speech input event, send an event object containing all the recognition results and metadata.
3111         https://bugs.webkit.org/show_bug.cgi?id=49736
3112
3113         Updated DRT by renaming the mock result method on all platforms to the new signature.
3114
3115         * DumpRenderTree/LayoutTestController.cpp:
3116         (addMockSpeechInputResultCallback):
3117         (LayoutTestController::staticFunctions):
3118         * DumpRenderTree/LayoutTestController.h:
3119         * DumpRenderTree/chromium/LayoutTestController.cpp:
3120         (LayoutTestController::LayoutTestController):
3121         (LayoutTestController::addMockSpeechInputResult):
3122         * DumpRenderTree/chromium/LayoutTestController.h:
3123         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3124         (LayoutTestController::addMockSpeechInputResult):
3125         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3126         (LayoutTestController::addMockSpeechInputResult):
3127         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3128         (LayoutTestController::addMockSpeechInputResult):
3129         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3130         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3131         (LayoutTestController::addMockSpeechInputResult):
3132         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3133         (LayoutTestController::addMockSpeechInputResult):
3134
3135 2010-11-22  Dirk Pranke  <dpranke@chromium.org>
3136
3137         Reviewed by Tony Chang.
3138
3139         Fix some spacing issues with log messages with
3140         new-run-webkit-tests --verbose.
3141
3142         https://bugs.webkit.org/show_bug.cgi?id=49936
3143
3144         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
3145
3146 2010-11-22  Ojan Vafai  <ojan@chromium.org>
3147
3148         Reviewed by Adam Barth.
3149
3150         update scm to work with different remote branches
3151         https://bugs.webkit.org/show_bug.cgi?id=49949
3152
3153         This works if there are multiple svn tracking branches
3154         and/or if the tracking branch is refs/remots/origin/master
3155         instead of refs/remotes/trunk which is the direction we're trying
3156         to head since that makes fetches faster.
3157
3158         * Scripts/webkitpy/common/checkout/scm.py:
3159         * Scripts/webkitpy/common/checkout/scm_unittest.py:
3160
3161 2010-11-22  Hayato Ito  <hayato@chromium.org>
3162
3163         Reviewed by Shinichiro Hamaji.
3164
3165         Ignore reference files which will be used by reftests when collecting
3166         test cases.
3167         https://bugs.webkit.org/show_bug.cgi?id=49835
3168
3169         * Scripts/webkitpy/layout_tests/port/test_files.py:
3170         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
3171
3172 2010-11-22  Adam Roben  <aroben@apple.com>
3173
3174         Use paths relative to $WebKitVSPropsRedirectionDir to access shared .vsprops files
3175
3176         Apple's Windows build allows placing header files and import libraries for WebKit's
3177         dependencies (CoreGraphics, CFNetwork, SQLite, etc.) outside the source tree via the
3178         $WebKitLibrariesDir environment variable. This is both required for production builds and
3179         convenient for Apple-internal developer builds. Apple's production builds also require that
3180         WebKit's shared .vsprops files be accessed relative to $WebKitLibrariesDir. In production
3181         builds, the files are copied into that directory tree by the
3182         WebKitLibraries/win/tools/WinTools.make file. In Apple-internal developer builds, the
3183         copying is done by
3184         JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make.
3185
3186         This .vsprops copying is problematic in one very important case: when a developer updates
3187         their source tree and then tries to build. Visual Studio only reads .vsprops files when a
3188         project is first loaded. So, when Visual Studio is first opened after the .vsprops files are
3189         updated, it reads in the old files that were already residing in $WebKitLibrariesDir. When a
3190         build is started, JavaScriptCoreGenerated.make copies the new .vsprops files into
3191         $WebKitLibrariesDir, but Visual Studio will not pick up the changes.  The rest of the build
3192         will proceed with out-of-date .vsprops files, which will likely result in a build failure.
3193
3194         To fix this, we now use normal relative paths to access the .vsprops files in the source
3195         tree rather than in $WebKitLibrariesDir, but prefix those paths with a new environment
3196         variable, $WebKitVSPropsRedirectionDir. In developer builds, this environment variable is
3197         unset, so the normal relative paths are used to read the .vsprops files out of the source
3198         tree directly. In production builds, this environment variable is set to a fake directory
3199         that will cause the .vsprops files in $WebKitLibrariesDir to be found when the relative path
3200         is resolved.
3201         
3202         For example, JavaScriptCore.vcproj uses this path for FeatureDefines.vsprops:
3203
3204         $(WebKitVSPropsRedirectionDir)..\..\..\WebKitLibraries\win\tools\vsprops\FeatureDefines.vsprops
3205
3206         In developer builds, where $WebKitVSPropsRedirectionDir is unset, this will point to the
3207         files in WebKitLibraries\win\tools\vsprops in the source tree. In production builds,
3208         JavaScriptCore.make sets $WebKitVSPropsRedirectionDir to
3209         "$(SRCROOT)\AppleInternal\tools\vsprops\OpenSource\1\2\3\", so the full path for
3210         FeatureDefines.vsprops becomes:
3211
3212         $(SRCROOT)\AppleInternal\tools\vsprops\OpenSource\1\2\3\..\..\..\WebKitLibraries\win\tools\vsprops\FeatureDefines.vsprops
3213
3214         which resolves to:
3215
3216         $(SRCROOT)\AppleInternal\tools\vsprops\OpenSource\WebKitLibraries\win\tools\vsprops\FeatureDefines.vsprops
3217
3218         (We rely on the fact that Windows doesn't care whether the directories "1", "2", and "3"
3219         actually exist since they are matched by an equal number of ".." path components.)
3220
3221         Note that Visual Studio still won't pick up changes made to .vsprops files while Visual
3222         Studio is open, but that problem hasn't seemed to cause developers many headaches so far.
3223
3224         Fixes <http://webkit.org/b/49181> Windows build fails mysteriously when .vsprops files are
3225         updated
3226
3227         Reviewed by Dave Hyatt.
3228
3229         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3230         * DumpRenderTree/win/DumpRenderTree.vcproj:
3231         * DumpRenderTree/win/ImageDiff.vcproj:
3232         * FindSafari/FindSafari.vcproj:
3233         * MiniBrowser/MiniBrowser.vcproj:
3234         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3235         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj:
3236         * WebKitAPITest/WebKitAPITest.vcproj:
3237         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
3238         * WebKitTestRunner/win/InjectedBundle.vcproj:
3239         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
3240         * WinLauncher/WinLauncher.vcproj:
3241         * record-memory-win/record-memory-win.vcproj:
3242         Changed to use paths relative to $WebKitVSPropsRedirectionDir to access shared .vsprops
3243         files.
3244
3245 2010-11-22  Adam Roben  <aroben@apple.com>
3246
3247         Make it possible to run tests on Windows without Visual Studio or VC++
3248         Express installed
3249
3250         webkitdir.pm::setupCygwinEnv dies when Visual Studio and VC++ Express
3251         are not installed. But this function doesn't need to be called when we
3252         already have a build available and are just trying to run the tests.
3253
3254         Fixes <http://webkit.org/b/49932> New Windows 7 bot can't run tests
3255         because Visual Studio/VC++ Express aren't installed
3256
3257         Reviewed by Dave Hyatt.
3258
3259         * Scripts/webkitdirs.pm:
3260         (determineConfigurationForVisualStudio): Don't call setupCygwinEnv, as
3261         it is not needed by this function. Also added a FIXME.
3262
3263         (usingVisualStudioExpress): Call setupCygwinEnv directly rather than
3264         relying on determineConfigurationForVisualStudio doing it.
3265
3266 2010-11-19  Hayato Ito  <hayato@chromium.org>
3267
3268         Reviewed by Shinichiro Hamaji.
3269
3270         Simplify Driver.run_test() so that it takes only one parameter, TestInput.
3271
3272         https://bugs.webkit.org/show_bug.cgi?id=49812
3273
3274         * Scripts/webkitpy/layout_tests/driver_test.py:
3275         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3276         * Scripts/webkitpy/layout_tests/port/base.py:
3277         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3278         * Scripts/webkitpy/layout_tests/port/chromium.py:
3279         * Scripts/webkitpy/layout_tests/port/dryrun.py:
3280         * Scripts/webkitpy/layout_tests/port/test.py:
3281         * Scripts/webkitpy/layout_tests/port/webkit.py:
3282         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3283         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3284
3285 2010-11-22  Hayato Ito  <hayato@chromium.org>
3286
3287         Reviewed by Tony Chang.
3288
3289         [NRWT] Retry a few times in reading a png image to avoid a race condition.
3290
3291         https://bugs.webkit.org/show_bug.cgi?id=49924
3292
3293         * Scripts/webkitpy/layout_tests/port/chromium.py:
3294
3295 2010-11-22  João Paulo Rechi Vita  <jprvita@profusion.mobi>
3296
3297         Reviewed by Kenneth Rohde Christiansen.
3298
3299         Fix EWebLauncher zoom discretization
3300         https://bugs.webkit.org/show_bug.cgi?id=49810
3301
3302         * EWebLauncher/main.c:
3303         (nearest_zoom_level_get):
3304         (zoom_level_set):
3305         (on_load_finished):
3306         (on_key_down):
3307
3308 2010-11-21  Sam Weinig  <sam@webkit.org>
3309
3310         Rubber-stamped by Dan Bernstein.
3311
3312         Fix ~300 WebKit2 tests by enabling developer extras preference.
3313
3314         * WebKitTestRunner/TestController.cpp:
3315         (WTR::TestController::resetStateToConsistentValues):
3316
3317 2010-11-21  Sam Weinig  <sam@webkit.org>
3318
3319         Reviewed by Dan Bernstein.
3320
3321         Textareas should be resizable by default
3322         https://bugs.webkit.org/show_bug.cgi?id=49892
3323
3324         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3325         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp: Added.
3326         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3327         Add preferences test.
3328
3329 2010-11-19  Mihai Parparita  <mihaip@chromium.org>
3330
3331         Reviewed by Tony Chang.
3332
3333         Rebaseline server: checksum-only differences and prefetching
3334         https://bugs.webkit.org/show_bug.cgi?id=49841
3335         
3336         Add support for image test results where the only difference is in the
3337         checksum.
3338         
3339         Add prefetching of the image results from the next test.
3340         
3341         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
3342         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
3343         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
3344
3345 2010-11-19  Dirk Pranke  <dpranke@chromium.org>
3346
3347         Reviewed by Tony Chang.
3348
3349         nrwt multiprocessing - add 'worker number' concept, move stuff to worker thread
3350
3351         Add the 'worker number' and 'worker name' concepts to the 
3352         TestShellThread objects, and move test_types and test_args from
3353         the TestRunner to the TestShellThread.
3354
3355         https://bugs.webkit.org/show_bug.cgi?id=49768
3356
3357         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3358         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3359
3360 2010-11-19  Dirk Pranke  <dpranke@chromium.org>
3361
3362         Reviewed by Ojan Vafai.
3363
3364         Do some minor cleanup and bug fixing.
3365
3366         https://bugs.webkit.org/show_bug.cgi?id=49777
3367
3368         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3369         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3370
3371 2010-11-19  Dirk Pranke  <dpranke@chromium.org>
3372
3373         Reviewed by Ojan Vafai.
3374
3375         nrwt - config.build_directory() is busted
3376
3377         Fixes a typo that was causing us to usually return the top level
3378         directory WebKitBuild instead of WebKitBuild/{Debug,Release}. The
3379         bug was hidden by test stubs that were too simplistic :(.
3380
3381         https://bugs.webkit.org/show_bug.cgi?id=49815
3382
3383         * Scripts/webkitpy/common/system/executive_mock.py:
3384         * Scripts/webkitpy/layout_tests/port/config.py:
3385         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
3386
3387 2010-11-19  Steve Falkenburg  <sfalken@apple.com>
3388
3389         Reviewed by Adam Roben.
3390
3391         Add Debug_Cairo_CFLite and Release_Cairo_CFLite configurations for all vcproj files
3392         https://bugs.webkit.org/show_bug.cgi?id=49819
3393
3394         * DumpRenderTree/DumpRenderTree.sln:
3395         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3396         * DumpRenderTree/win/DumpRenderTree.vcproj:
3397         * DumpRenderTree/win/ImageDiff.vcproj:
3398         * FindSafari/FindSafari.vcproj:
3399         * MiniBrowser/MiniBrowser.vcproj:
3400         * TestWebKitAPI/win/TestWebKitAPI.sln:
3401         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3402         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj:
3403         * WebKitAPITest/WebKitAPITest.vcproj:
3404         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
3405         * WebKitTestRunner/win/InjectedBundle.vcproj:
3406         * WebKitTestRunner/win/InjectedBundleGenerated.vcproj:
3407         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
3408         * WinLauncher/WinLauncher.vcproj:
3409         * record-memory-win/record-memory-win.vcproj:
3410
3411 2010-11-19  Adam Roben  <aroben@apple.com>
3412
3413         Add some more Windows slaves
3414
3415         This is probably more than we will be using in the immediate future,
3416         but having some extra slave names makes experimenting with different
3417         configurations easier.
3418
3419         Reviewed by Jon Honeycutt.
3420
3421         * BuildSlaveSupport/build.webkit.org-config/config.json: Added 5 more
3422         Windows slaves and distributed them among the three different Test
3423         builders.
3424
3425 2010-11-19  Kinuko Yasuda  <kinuko@chromium.org>
3426
3427         Reviewed by Ojan Vafai.
3428
3429         [Chromium] REGRESSION: Record actual test results in the JSON result summary for non-layout tests
3430         https://bugs.webkit.org/show_bug.cgi?id=49702
3431
3432         Re-landing r72357 with a test fix.
3433
3434         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
3435         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3436         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
3437
3438 2010-11-19  Avi Drissman  <avi@google.com>
3439
3440         Reviewed by Antonio Gomes.
3441
3442         Complete support for Unix editing mode
3443         https://bugs.webkit.org/show_bug.cgi?id=49757
3444
3445         * DumpRenderTree/LayoutTestController.cpp:
3446         (setEditingBehaviorCallback):
3447         * DumpRenderTree/chromium/LayoutTestController.cpp:
3448         (LayoutTestController::setEditingBehavior):
3449
3450 2010-11-19  Adam Roben  <aroben@apple.com>
3451
3452         Fix run-javascriptcore-tests when there's a space in the path to
3453         testapi
3454
3455         Reviewed by Sam Weinig.
3456
3457         * Scripts/run-javascriptcore-tests: Use an indirect object when calling
3458         system() to force it to interpret spaces in the path correctly.
3459
3460 2010-11-19  Adam Roben  <aroben@apple.com>
3461
3462         Update scripts for .exe name changes after r72327
3463
3464         As of r72327, the "_debug" suffix is only used in Debug_All builds.
3465
3466         Reviewed by Sam Weinig.
3467
3468         * Scripts/run-javascriptcore-tests:
3469         (testapiPath):
3470
3471         * Scripts/sunspider-compare-results:
3472         (pathToBuiltJSC):
3473
3474         * Scripts/webkitdirs.pm:
3475         (jscPath):
3476         (safariPath):
3477
3478 2010-11-19  Steve Falkenburg  <sfalken@apple.com>
3479
3480         Reviewed by Darin Adler.
3481
3482         Normalize Cairo/CFLite project/solution configuration names
3483         https://bugs.webkit.org/show_bug.cgi?id=49818
3484
3485         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3486         * DumpRenderTree/win/DumpRenderTree.vcproj:
3487         * DumpRenderTree/win/ImageDiff.vcproj:
3488         * MiniBrowser/MiniBrowser.vcproj:
3489         * TestWebKitAPI/win/TestWebKitAPI.sln:
3490         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3491         * WebKitAPITest/WebKitAPITest.vcproj:
3492         * WebKitTestRunner/win/InjectedBundle.vcproj:
3493         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
3494         * WinLauncher/WinLauncher.vcproj:
3495         * Scripts/webkitdirs.pm: Updated cairo build configs.
3496
3497 2010-11-18  Steve Falkenburg  <sfalken@apple.com>
3498
3499         Reviewed by Adam Roben.
3500
3501         Windows vcproj configuration names should be normalized across projects
3502         https://bugs.webkit.org/show_bug.cgi?id=49776
3503
3504         * DumpRenderTree/DumpRenderTree.sln:
3505         * FindSafari/FindSafari.vcproj:
3506         * TestWebKitAPI/win/TestWebKitAPI.sln:
3507         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj:
3508         * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops: Added.
3509         * WebKitAPITest/WebKitAPITest.vcproj:
3510         * WebKitAPITest/WebKitAPITestCommon.vsprops:
3511         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
3512         * WebKitTestRunner/WebKitTestRunner.sln:
3513         * WebKitTestRunner/win/InjectedBundleGenerated.vcproj:
3514         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops: Added.
3515         * record-memory-win/record-memory-win.vcproj:
3516
3517 2010-11-18  Gavin Barraclough  <barraclough@apple.com>
3518
3519         Build fix - as per DRT-mac, always enabled developer extras,
3520         in win/qt/gtk DRT.
3521
3522         This is necessary to enable rich exception messages to be generated
3523         following https://bugs.webkit.org/show_bug.cgi?id=49708.
3524
3525         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3526         (shouldEnableDeveloperExtras):
3527         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3528         (WebCore::shouldEnableDeveloperExtras):
3529         * DumpRenderTree/win/DumpRenderTree.cpp:
3530         (shouldEnableDeveloperExtras):
3531
3532 2010-11-18  Sheriff Bot  <webkit.review.bot@gmail.com>
3533
3534         Unreviewed, rolling out r72357.
3535         http://trac.webkit.org/changeset/72357
3536         https://bugs.webkit.org/show_bug.cgi?id=49784
3537
3538         It broke test-webkitpy tests since the patch didn't have the
3539         corresponding test update (Requested by kinuko on #webkit).
3540
3541         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
3542         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3543
3544 2010-11-18  Mihai Parparita  <mihaip@chromium.org>
3545
3546         Reviewed by Tony Chang.
3547
3548         Rebaseline server: add rebaseline queue
3549         https://bugs.webkit.org/show_bug.cgi?id=49763
3550         
3551         Add a UI queue (a multi-item <select>) where tests to be baselined
3552         can be enqueued (also supports basic removal). A queue is used instead
3553         of immediately doing rebaselines since SCM operations can take a while.
3554         It's better to go through lots of tests quickly to mark them as
3555         needing rebaselining and then batch the SCM operations.
3556         
3557         Also adds a simple log where results can be displayed.
3558
3559         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
3560         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
3561         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
3562         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js: Added.
3563         * Scripts/webkitpy/tool/commands/data/rebaselineserver/util.js:
3564         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
3565
3566 2010-11-18  Gavin Barraclough  <barraclough@apple.com>
3567
3568         Reviewed by Oliver Hunt.
3569
3570         Bug 49708 - Stop recompiling functions to regenerate exception info.
3571
3572         Instead only hold info as necessary – keep divot info is the inspector
3573         is enabled, line number info is debugging or profiling, and handler
3574         info for functions with try/catch.
3575
3576         * DumpRenderTree/mac/DumpRenderTree.mm:
3577         (shouldEnableDeveloperExtras):
3578             - always enable the developer tools from DRT, to ensure we
3579               produce rich error messages on JavaScript exceptions.
3580
3581 2010-11-18  Kinuko Yasuda  <kinuko@chromium.org>
3582
3583         Reviewed by Ojan Vafai.
3584
3585         [Chromium] REGRESSION: Record actual test results in the JSON result summary for non-layout tests
3586         https://bugs.webkit.org/show_bug.cgi?id=49702
3587
3588         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
3589         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3590
3591 2010-11-18  Dirk Pranke  <dpranke@chromium.org>
3592
3593         Reviewed by Tony Chang.
3594
3595         new-run-webkit-tests: create first part of 'message_broker' class for multiprocessing fixes
3596
3597         Create the first version of the 'message_broker' package. This
3598         class will encapsulate all of the threading/multiprocessing and
3599         message-sending details for the communication between the
3600         'manager' object and the 'worker' objects. For the moment, it
3601         just holds some routines and tests for logging thread stacks.
3602
3603         There should be no functional changes in this patch, just moving stuff
3604         around.
3605
3606         https://bugs.webkit.org/show_bug.cgi?id=49707
3607
3608         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3609         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread_unittest.py: Removed.
3610         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py: Added.
3611         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py: Added.
3612         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3613         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3614
3615 2010-11-18  Steve Falkenburg  <sfalken@apple.com>
3616
3617         Reviewed by Adam Roben.
3618
3619         Remove leftover Windows Debug_Internal configurations
3620         https://bugs.webkit.org/show_bug.cgi?id=49758
3621
3622         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3623         * DumpRenderTree/win/DumpRenderTree.vcproj:
3624         * DumpRenderTree/win/ImageDiff.vcproj:
3625         * MiniBrowser/MiniBrowser.vcproj:
3626         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3627         * WebKitAPITest/WebKitAPITest.vcproj:
3628         * WebKitTestRunner/win/InjectedBundle.vcproj:
3629         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
3630         * WinLauncher/WinLauncher.vcproj:
3631
3632 2010-11-18  Adam Roben  <aroben@apple.com>
3633
3634         Add three new Windows XP build slaves
3635
3636         Reviewed by Steve Falkenburg.
3637
3638         * BuildSlaveSupport/build.webkit.org-config/config.json: Added three
3639         new slaves, and added them to the Windows XP Debug (Tests) builder.
3640
3641 2010-11-18  Daniel Bates  <dbates@rim.com>
3642
3643         Reviewed by Adam Roben.
3644
3645         update-webkit-support-libs should fall back to existing
3646         WebKitSupportLibrary version if there is no internet connectivity
3647         https://bugs.webkit.org/show_bug.cgi?id=49503
3648
3649         Fall back to existing support libraries (if present) when there is
3650         no internet connection.
3651
3652         Currently, update-webkit-support-libs dies with an "out-of-date"
3653         error when there is no internet connection because it cannot
3654         retrieve versioning information from developer.apple.com. Because
3655         update-webkit-support-libs fails, build-webkit fails. Instead,
3656         if there is no internet connection and the support libraries are
3657         present then we should warn the user and exit() with success so
3658         that build-webkit can work without an internet connection.
3659
3660         * Scripts/update-webkit-support-libs:
3661
3662 2010-11-18  Steve Falkenburg  <sfalken@apple.com>
3663
3664         Reviewed by Adam Roben.
3665
3666         Debug_Internal Windows configuration is unnecessary, should be removed
3667         https://bugs.webkit.org/show_bug.cgi?id=49753
3668
3669         * DumpRenderTree/win/DumpRenderTree.cpp:
3670         * MiniBrowser/win/stdafx.h:
3671         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
3672         * WebKitTestRunner/win/TestControllerWin.cpp:
3673
3674 2010-11-18  Steve Falkenburg  <sfalken@apple.com>
3675
3676         Reviewed by Adam Roben.
3677
3678         Clean up vcproj errors
3679         https://bugs.webkit.org/show_bug.cgi?id=49741
3680
3681         * MiniBrowser/MiniBrowser.vcproj:
3682         * WebKitAPITest/WebKitAPITest.vcproj:
3683         * WebKitTestRunner/win/InjectedBundle.vcproj:
3684         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
3685
3686 2010-11-18  Hayato Ito  <hayato@chromium.org>
3687
3688         Reviewed by Shinichiro Hamaji.
3689
3690         [NRWT] Fix a break of '--new-baseline' feature in pixel_test
3691         which is caused by r72249.
3692
3693         https://bugs.webkit.org/show_bug.cgi?id=49751
3694
3695         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
3696
3697 2010-11-18  Adam Roben  <aroben@apple.com>
3698
3699         Implement layoutTestController.waitForPolicyDelegate on Windows
3700
3701         Fixes <http://webkit.org/b/25038> <rdar://problem/6790213>.
3702
3703         Reviewed by Simon Fraser.
3704
3705         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3706         (LayoutTestController::waitForPolicyDelegate): Implemented by porting
3707         code from LayoutTestControllerMac.mm.
3708
3709 2010-11-18  Hayato Ito  <hayato@chromium.org>
3710
3711         Reviewed by Shinichiro Hamaji.
3712
3713         [NRWT] Fix a break of '--new-baseline' feature which is caused by r72249.
3714
3715         https://bugs.webkit.org/show_bug.cgi?id=49740
3716
3717         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
3718
3719 2010-11-18  Tony Chang  <tony@chromium.org>
3720
3721         Reviewed by Adam Barth.
3722
3723         run platform/chromium/plugins/refcount-leaks.html on all platforms
3724         https://bugs.webkit.org/show_bug.cgi?id=49485
3725
3726         Add PluginObject.testObjectCount which returns the number of allocated
3727         TestObjects. Add PluginObject.testCreateTestObject which allocates
3728         and returns a TestObject.
3729
3730         Add TestObject.refCount which returns the number of refs on the
3731         TestObject.
3732
3733         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
3734         (pluginGetProperty):
3735         (pluginInvoke):
3736         * DumpRenderTree/TestNetscapePlugIn/TestObject.cpp:
3737         (getTestObjectCount):
3738         (testAllocate):
3739         (testDeallocate):
3740         (testGetProperty):
3741         (testScriptObjectInvoke): Release a ref to a plugin object that was
3742             previously leaked.
3743         * DumpRenderTree/TestNetscapePlugIn/TestObject.h:
3744
3745 2010-11-17  Steve Falkenburg  <sfalken@apple.com>
3746
3747         Reviewed by Adam Roben.
3748
3749         WebKitTools projects (WebKitTestRunner, record-memory-win) should use vsprops for common build settings
3750         https://bugs.webkit.org/show_bug.cgi?id=49711
3751
3752         * WebKitTestRunner/Configurations/WebKitTestRunnerCFLite.vsprops: Added.
3753         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops: Added.
3754         * WebKitTestRunner/Configurations/WebKitTestRunnerCoreFoundation.vsprops: Added.
3755         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
3756         * record-memory-win/record-memory-win-common.vsprops: Added.
3757         * record-memory-win/record-memory-win.vcproj:
3758
3759 2010-11-18  Andras Becsi  <abecsi@inf.u-szeged.hu>
3760
3761         Reviewed by Csaba Osztrogonác.
3762
3763         [Qt][WK2] Only add user agent strings to the list which aren't listed yet.
3764
3765         * MiniBrowser/qt/BrowserWindow.cpp:
3766         (BrowserWindow::updateUserAgentList):
3767
3768 2010-11-17  Adam Roben  <aroben@apple.com>
3769
3770         Don't trigger Windows builds when chromium-win test results change
3771
3772         Reviewed by Mark Rowe.
3773
3774         * Scripts/webkitpy/common/config/build.py:
3775         (_should_file_trigger_build): Changed the regular expression used to
3776         search for directory names to only consider full directory names,
3777         rather than matching directory names where the string we care about is
3778         a suffix of the name.
3779
3780         * Scripts/webkitpy/common/config/build_unittest.py:
3781         (ShouldBuildTest): Added a test.
3782
3783 2010-11-17  Hayato Ito  <hayato@chromium.org>
3784
3785         Reviewed by Shinichiro Hamaji.
3786
3787         Remove a uri member from TestInput class.
3788
3789         https://bugs.webkit.org/show_bug.cgi?id=49691
3790
3791         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3792         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3793
3794 2010-11-17  Adam Roben  <aroben@apple.com>
3795
3796         Move FindSafari's settings into a vsprops file
3797
3798         Fixes <http://webkit.org/b/49699> FindSafari should use a vsprops file
3799
3800         Reviewed by Steve Falkenburg.
3801
3802         * FindSafari/FindSafari.vcproj:
3803         * FindSafari/FindSafariCommon.vsprops: Added.
3804
3805 2010-11-17  Adam Roben  <aroben@apple.com>
3806
3807         Use a minimum font size of 0 in DRT on Windows
3808
3809         This is the Windows equivalent of r72164.
3810
3811         Rubber-stamped by Dave Hyatt.
3812
3813         * DumpRenderTree/win/DumpRenderTree.cpp:
3814         (resetDefaultsToConsistentValues):
3815
3816 2010-11-17  Dirk Pranke  <dpranke@chromium.org>
3817
3818         Reviewed by Andreas Kling.
3819
3820         webkit-patch pretty-diff shouldn't need to be run from a checkout root in git
3821         https://bugs.webkit.org/show_bug.cgi?id=49639
3822
3823         * Scripts/webkitpy/common/checkout/scm.py:
3824
3825 2010-11-17  Mihai Parparita  <mihaip@chromium.org>
3826
3827         Reviewed by Tony Chang.
3828
3829         Rebaseline server: add loupe for image diffs
3830         https://bugs.webkit.org/show_bug.cgi?id=49692
3831         
3832         Add a loupe (magnifiying glass) for inspecting image diffs. Shows an
3833         enlarged area of the expected, actual and diff images side by side.
3834
3835         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
3836         * Scripts/webkitpy/tool/commands/data/rebaselineserver/loupe.js: Added.
3837         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
3838         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
3839
3840 2010-11-17  Steve Falkenburg  <sfalken@apple.com>
3841
3842         Reviewed by Adam Roben.
3843
3844         WebKitLauncherWin should use vsprops for shared build settings
3845         https://bugs.webkit.org/show_bug.cgi?id=49696
3846
3847         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
3848         * WebKitLauncherWin/WebKitLauncherWinCommon.vsprops: Added.
3849
3850 2010-11-17  Steve Falkenburg  <sfalken@apple.com>
3851
3852         Reviewed by Adam Roben.
3853
3854         WinLauncher should use vsprops for shared build settings
3855         https://bugs.webkit.org/show_bug.cgi?id=49695
3856
3857         * WinLauncher/WinLauncher.cpp:
3858         (_tWinMain):
3859         (PrintView):
3860         (WndProc):
3861         (MyEditProc):
3862         * WinLauncher/WinLauncher.vcproj:
3863         * WinLauncher/WinLauncherCommon.vsprops: Added.
3864
3865 2010-11-17  Steve Falkenburg  <sfalken@apple.com>
3866
3867         Delete unused file unintentionally added in last change.
3868
3869         * DumpRenderTree/win/DumpRenderTreeCURL.vsprops: Removed.
3870
3871 2010-11-17  Steve Falkenburg  <sfalken@apple.com>
3872
3873         Reviewed by Adam Roben.
3874
3875         DumpRenderTree on Windows should use a vsprops file for shared project settings
3876         https://bugs.webkit.org/show_bug.cgi?id=49690
3877
3878         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3879         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops: Added.
3880         * DumpRenderTree/win/DumpRenderTree.vcproj:
3881         * DumpRenderTree/win/DumpRenderTreeApple.vsprops: Added.
3882         * DumpRenderTree/win/DumpRenderTreeCFLite.vsprops: Added.
3883         * DumpRenderTree/win/DumpRenderTreeCURL.vsprops: Added.
3884         * DumpRenderTree/win/DumpRenderTreeCairo.vsprops: Added.
3885         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops: Added.
3886         * DumpRenderTree/win/ImageDiff.vcproj:
3887         * DumpRenderTree/win/ImageDiffCommon.vsprops: Added.
3888
3889 2010-11-17  Hayato Ito  <hayato@chromium.org>
3890
3891         Refactor TestTypeBase.compare_output().
3892
3893         Introduce a TestOutput class and update compare_output() of each test
3894         types so that they can take both actual and expected TestOutput objects.
3895
3896         https://bugs.webkit.org/show_bug.cgi?id=49431
3897
3898         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3899         * Scripts/webkitpy/layout_tests/layout_package/test_output.py: Added.
3900         * Scripts/webkitpy/layout_tests/port/base.py:
3901         * Scripts/webkitpy/layout_tests/port/chromium.py:
3902         * Scripts/webkitpy/layout_tests/port/dryrun.py:
3903         * Scripts/webkitpy/layout_tests/port/test.py:
3904         * Scripts/webkitpy/layout_tests/port/webkit.py:
3905         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3906         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
3907         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
3908         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
3909
3910 2010-11-17  Adam Roben  <aroben@apple.com>
3911
3912         Make each Windows Test builder use the same OS for all its slaves
3913
3914         Currently each WebKit1 Windows Test builder has one Windows XP slave
3915         and one Windows 7 slave. Having different OSes in a single builder
3916         meant that the builders would alternate between red and green when
3917         there were OS-specific failures.
3918
3919         Fixes <http://webkit.org/b/49688> Windows Test builders alternate
3920         between red and green because of multiple OS versions
3921
3922         Reviewed by Mark Rowe.
3923
3924         * BuildSlaveSupport/build.webkit.org-config/config.json: Renamed
3925         "Windows Release (Tests)" to "Windows 7 Release (Tests)", "Windows
3926         Debug (Tests)" to "Windows XP Debug (Tests)", and "Windows Release
3927         (WebKit2 Tests)" to "Windows 7 Release (WebKit2 Tests)". Updated the
3928         builders for the two WebKit1 builders so that they would all use the
3929         appropriate OS.
3930
3931 2010-11-17  James Robinson  <jamesr@chromium.org>
3932
3933         Reviewed by Dan Bernstein.
3934
3935         [chromium] Set minimum font size to 0 for DRT
3936         https://bugs.webkit.org/show_bug.cgi?id=49677
3937
3938         Followup for http://trac.webkit.org/changeset/72141.
3939
3940         Test: http/tests/misc/acid3.html
3941
3942         * DumpRenderTree/chromium/WebPreferences.cpp:
3943         (WebPreferences::reset):
3944
3945 2010-11-17  Andras Becsi  <abecsi@webkit.org>
3946
3947         Unreviewed build fix.
3948
3949         [Qt] Add missing file I forgot in r72220.
3950
3951         * MiniBrowser/MiniBrowser.qrc: Added.
3952
3953 2010-11-17  Andras Becsi  <abecsi@webkit.org>
3954
3955         Reviewed by Andreas Kling.
3956
3957         [Qt][WK2] Make it possible to set custom user agent strings in MiniBrowser.
3958         https://bugs.webkit.org/show_bug.cgi?id=49627
3959
3960         Add a user agent dialog and a resource file for useragentlist.txt to MiniBrowser.
3961
3962         * MiniBrowser/MiniBrowser.qrc: Added.
3963         Add it here to prevent qmake from detecting it
3964         since it needs to be copied to the build directory.
3965         * MiniBrowser/qt/BrowserWindow.cpp:
3966         (BrowserWindow::BrowserWindow):
3967         (BrowserWindow::updateUserAgentList):
3968         (BrowserWindow::showUserAgentDialog):
3969         * MiniBrowser/qt/BrowserWindow.h:
3970         * MiniBrowser/qt/MiniBrowser.pro:
3971
3972 2010-11-17  Adam Roben  <aroben@apple.com>
3973
3974         Make changes to the Mac WebKit2 Skipped file trigger Windows builds
3975
3976         We use that file on Windows!
3977
3978         Fixes <http://webkit.org/b/49643> Changes to
3979         LayoutTests/platform/mac-wk2 should trigger a Windows build, but don't
3980
3981         Reviewed by Steve Falkenburg.
3982
3983         * Scripts/webkitpy/common/config/build.py:
3984         (_should_file_trigger_build): Added the mac-wk2 directory and make it
3985         trigger builds on SnowLeopard and Windows.
3986
3987         * Scripts/webkitpy/common/config/build_unittest.py:
3988         (ShouldBuildTest.test_should_build): Added a test.
3989
3990 2010-11-17  Satish Sampath  <satish@chromium.org>
3991
3992         Reviewed by Jeremy Orlow.
3993
3994         Clear the speech input mock explicitly before each test.
3995         https://bugs.webkit.org/show_bug.cgi?id=49660
3996
3997         * DumpRenderTree/chromium/LayoutTestController.cpp:
3998         (LayoutTestController::setMockSpeechInputResult):
3999         * DumpRenderTree/chromium/LayoutTestController.h:
4000         * DumpRenderTree/chromium/WebViewHost.cpp:
4001         (WebViewHost::speechInputController):
4002         (WebViewHost::reset): Invoke speech input mock's clearResults method.
4003         * DumpRenderTree/chromium/WebViewHost.h:
4004         (WebViewHost::speechInputControllerMock): Moved mock from LayoutTestController.
4005
4006 2010-11-17  Alexander Pavlov  <apavlov@chromium.org>
4007
4008         Unreviewed, specify IRC nickname in committers.py.
4009
4010         * Scripts/webkitpy/common/config/committers.py:
4011
4012 2010-11-17  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
4013
4014         Reviewed by Tony Chang.
4015
4016         [NRWT] Make http locking similar to perl implementation
4017         https://bugs.webkit.org/show_bug.cgi?id=49187
4018
4019         * Scripts/webkitpy/common/system/file_lock.py: Added.
4020         * Scripts/webkitpy/common/system/file_lock_unittest.py: Added.
4021         * Scripts/webkitpy/layout_tests/port/http_lock.py:
4022
4023 2010-11-17  MORITA Hajime  <morrita@google.com>
4024
4025         Reviewed by Kent Tamura.
4026
4027         [Chromium][DRT] EventSender.contextClick() should aware spellchecking
4028         https://bugs.webkit.org/show_bug.cgi?id=49366
4029
4030         - EvenSender: Checked WebContextMenuData.misspelledWord and added extra context menu entries
4031           according to the spellchecker suggestion
4032         - MockSpellCheck: add fillSuggestionList to provide fake suggestions.
4033
4034         test_expectations.txt will be changed after this change is ported to test_shell.
4035         
4036         * DumpRenderTree/chromium/EventSender.cpp:
4037         (makeMenuItemStringsFor):
4038         (EventSender::contextClick):
4039         * DumpRenderTree/chromium/MockSpellCheck.cpp:
4040         (MockSpellCheck::fillSuggestionList):
4041         (MockSpellCheck::initializeIfNeeded):
4042         * DumpRenderTree/chromium/MockSpellCheck.h:
4043         * DumpRenderTree/chromium/WebViewHost.cpp:
4044         (WebViewHost::mockSpellCheck):
4045         * DumpRenderTree/chromium/WebViewHost.h:
4046
4047 2010-11-16  Dave Hyatt  <hyatt@apple.com>
4048
4049         Reviewed by Sam Weinig.
4050
4051         Make sure the pref for minimum font size is just explicitly set to 0 every time,
4052         since the bots have 1 stuck in their plist otherwise.
4053
4054         * DumpRenderTree/mac/DumpRenderTree.mm:
4055         (resetDefaultsToConsistentValues):
4056
4057 2010-11-16  Mihai Parparita  <mihaip@chromium.org>
4058
4059         Reviewed by Tony Chang.
4060
4061         Rebaseline server: compute diffs client-side
4062         https://bugs.webkit.org/show_bug.cgi?id=49640
4063         
4064         The image diff output from the DRT is pretty bad on some ports (at
4065         least the Mac one), so it's better to compute diffs on the client by
4066         using <canvas>.
4067
4068         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
4069         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
4070         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
4071
4072 2010-11-16  Mihai Parparita  <mihaip@chromium.org>
4073
4074         Reviewed by Tony Chang.
4075
4076         Rebaseline server: display test results
4077         https://bugs.webkit.org/show_bug.cgi?id=49626
4078         
4079         Adds basic result display to the rebaseline server. On the Python side
4080         this involves:
4081         - Parsing the unexpected_results.json into a dictionary.
4082         - Serving it as JSON under /results.json.
4083         (the JSON -> dict -> JSON transform isn't strictly necessary right now,
4084         but I'll need to have access to the parsed results on the Python side
4085         for follow-up changes).
4086         
4087         On the web UI side this adds:
4088         - Markup for display image and text results (expected, actual, diff),
4089           and JS for populating it.
4090         - Markup for breaking down test results by failure type and directory,
4091           and JS for populating it.
4092
4093         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
4094         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
4095         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
4096         * Scripts/webkitpy/tool/commands/data/rebaselineserver/util.js: Added.
4097         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
4098
4099 2010-11-16  Dirk Pranke  <dpranke@chromium.org>
4100
4101         Reviewed by Ojan Vafai.
4102
4103         See Chromium issue http://codereview.chromium.org/5133001/ - we
4104         are modifying the build bots to pass in the builder name with
4105         the "GPU" string appended instead of appending it in the code.
4106
4107         https://bugs.webkit.org/show_bug.cgi?id=49636
4108
4109         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
4110
4111 2010-11-16  Steve Falkenburg  <sfalken@apple.com>
4112
4113         Reviewed by Adam Roben.
4114
4115         Disable LTCG for Windows Release builds. Add new Release_LTCG configuration.
4116         https://bugs.webkit.org/show_bug.cgi?id=49632
4117
4118         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
4119         * DumpRenderTree/win/DumpRenderTree.vcproj:
4120         * DumpRenderTree/win/ImageDiff.vcproj:
4121         * MiniBrowser/MiniBrowser.vcproj:
4122         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
4123         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
4124         * WebKitTestRunner/win/InjectedBundle.vcproj:
4125         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
4126         * WinLauncher/WinLauncher.vcproj:
4127         * record-memory-win/record-memory-win.vcproj:
4128
4129 2010-11-16  Dirk Pranke  <dpranke@chromium.org>
4130
4131         Reviewed by Ojan Vafai.
4132
4133         new-run-webkit-tests: rename TestInfo to TestInput, move image hash to work thread
4134
4135         Rename the TestInfo class to TestInput to be clearer about its
4136         function, and move the checksum-reading code into dump_render_tree_thread
4137         to avoid cross-thread access.
4138
4139         https://bugs.webkit.org/show_bug.cgi?id=49573
4140
4141         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
4142         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4143         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
4144
4145 2010-11-16  Dave Hyatt  <hyatt@apple.com>
4146
4147         Fix bustage. Remove the minimum font size pref setting in DumpRenderTree.
4148
4149         * DumpRenderTree/mac/DumpRenderTree.mm:
4150         (resetDefaultsToConsistentValues):
4151
4152 2010-11-16  Stephanie Lewis  <slewis@apple.com>
4153
4154         Reviewed by Geoff Garen.
4155
4156         <rdar://problem/8624267> Leak creating offscreen webview running fast/dom tests
4157
4158         Use shared DeviceOrientationProviderMock. The old allocation method created a new WebDeviceOrientationProviderMock 
4159         for every WebView, and the WebKit API doesn't support that ownership model.
4160
4161         I also fixed a leak in setMockDeviceOrientation by adding a missing release.
4162
4163         * DumpRenderTree/mac/DumpRenderTree.mm:
4164         (createWebViewAndOffscreenWindow):
4165         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
4166         (LayoutTestController::setMockDeviceOrientation):
4167
4168 2010-11-16  Dirk Pranke  <dpranke@chromium.org>
4169
4170         Reviewed by Ojan Vafai.
4171
4172         new-run-webkit-tests: log the process id in --verbose mode
4173
4174         As part of the switch to multi-process mode, we should log the
4175         process id when running w/ --verbose.
4176
4177         https://bugs.webkit.org/show_bug.cgi?id=49571
4178
4179         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
4180
4181 2010-11-16  Adam Roben  <aroben@apple.com>
4182
4183         Only trigger Windows builds when files that we actually use on Windows
4184         are changed
4185
4186         A new Scheduler subclass, PlatformSpecificScheduler, has been added.
4187         It uses the new webkitpy.common.config.build module to determine
4188         whether a particular change should trigger a build on a particular
4189         platform. The Windows builders have been switched to use a
4190         PlatformSpecificScheduler.
4191
4192         The logic to determine whether or not a particular change should
4193         trigger a build on a given platform has only been implemented/tested
4194         for Windows. I tried to make it easy to add more platforms in the
4195         future, but I don't have enough familiarity with all platforms to be
4196         able to implement it for them.
4197
4198         Fixes <http://webkit.org/b/49407> Windows builders kick off builds for
4199         lots irrelevant changes (e.g., rebaselining Chromium test results)
4200
4201         Reviewed by Eric Seidel.
4202
4203         * BuildSlaveSupport/build.webkit.org-config/config.json: Use a
4204         PlatformSpecificScheduler for the Windows builders.
4205
4206         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
4207         (PlatformSpecificScheduler.__init__): Added. Stores our platform, sets
4208         up a ChangeFilter that filters to our branch and will call through to
4209         our filter method, and calls up to our base class.
4210         (PlatformSpecificScheduler.filter): Calls through to
4211         build.should_build to find out whether we should trigger a build for
4212         this change.
4213
4214         * Scripts/webkitpy/common/net/build.py: Added.
4215         (_should_file_trigger_build): Uses a set of directories and regexp
4216         patterns to determine whether the given file should trigger a build on
4217         the given platform. As mentioned earlier, this has only been
4218         implemented for Windows, though I did try to make some guesses about
4219         other platforms.
4220         (should_build): Returns true if any of the files should trigger a
4221         build on the given platform.
4222
4223         * Scripts/webkitpy/common/net/build_unittest.py: Added.
4224         (ShouldBuildTest.test_should_build): Does some basic testing to make
4225         sure we're triggering builds for the right files. It only tests
4226         Windows for now, though I tried to make some guesses about other
4227         platforms.
4228
4229 2010-11-16  Simon Hausmann  <simon.hausmann@nokia.com>
4230
4231         Reviewed by Andreas Kling.
4232
4233         [Qt] Remove synchronous QWebPage::checkPermissions signal
4234         https://bugs.webkit.org/show_bug.cgi?id=46810
4235
4236         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
4237         (WebCore::WebPage::WebPage):
4238         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
4239         (LayoutTestController::grantDesktopNotificationPermission): When granting
4240         permission, grant it directly on the QWebPage/Frame, that will remember it.
4241         * QtTestBrowser/webpage.cpp:
4242         (WebPage::WebPage):
4243         * QtTestBrowser/webpage.h:
4244
4245
4246 2010-11-16  Andras Becsi  <abecsi@inf.u-szeged.hu>
4247
4248         Reviewed by Csaba Osztrogonác.
4249
4250         [Qt] Add isPrinting and setPrinting methods to DRT's LayoutTestController.
4251
4252         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
4253         (LayoutTestController::reset):
4254         * DumpRenderTree/qt/LayoutTestControllerQt.h:
4255         (LayoutTestController::isPrinting):
4256         (LayoutTestController::setPrinting):
4257
4258 2010-11-16  Balazs Kelemen  <kbalazs@webkit.org>
4259
4260         Reviewed by Andreas Kling.
4261
4262         [Qt][WK2] Add a way to turn on tiled backing store in MiniBrowser
4263         https://bugs.webkit.org/show_bug.cgi?id=49587
4264
4265         * MiniBrowser/qt/BrowserView.cpp:
4266         (BrowserView::BrowserView): Added BackingStoreType
4267         argument to ctor. Propagating it to the QGraphicsWKView.
4268         * MiniBrowser/qt/BrowserView.h:
4269         * MiniBrowser/qt/BrowserWindow.cpp:
4270         (BrowserWindow::BrowserWindow):
4271         (BrowserWindow::newWindow): Create the new BrowserWindow
4272         with the same BackingStoreType that this instance has.
4273         * MiniBrowser/qt/BrowserWindow.h: Added BackingStoreType member.
4274         * MiniBrowser/qt/main.cpp:
4275         (main): Use tiled backing store if got -tiled command line argument.
4276         Avoid redundant copy of command line args.
4277
4278 2010-11-16  John Knottenbelt  <jknotten@chromium.org>
4279
4280         Reviewed by Jeremy Orlow.
4281
4282         Move DeviceOrientationClientMock from LayoutTestController to WebViewHost.
4283         https://bugs.webkit.org/show_bug.cgi?id=48506
4284
4285         This ensures that there is one mock per page WebView / WebViewHost. This is a
4286         design constraint of the DeviceOrientationClientMock because the m_controller
4287         field can only store a pointer to a single instance of the corresponding
4288         DeviceOrientationController.
4289
4290         Test: fast/dom/DeviceOrientation/no-page-cache.html
4291
4292         * DumpRenderTree/chromium/LayoutTestController.cpp:
4293         (LayoutTestController::setMockDeviceOrientation):
4294         (LayoutTestController::deviceOrientationClientMock):
4295         * DumpRenderTree/chromium/LayoutTestController.h:
4296         * DumpRenderTree/chromium/WebViewHost.cpp:
4297         (WebViewHost::deviceOrientationClientMock):
4298         (WebViewHost::deviceOrientationClient):
4299         (WebViewHost::reset):
4300         * DumpRenderTree/chromium/WebViewHost.h:
4301
4302 2010-11-15  Andras Becsi  <abecsi@webkit.org>
4303
4304         Reviewed by Andreas Kling.
4305
4306         [Qt][WK2] Avoid polling in WebKitTestRunner.
4307         https://bugs.webkit.org/show_bug.cgi?id=49542
4308
4309         Make the WK2 testing session about 10-15% faster and decrease random flakiness
4310         resulting from timing skew by removing the millisecond polling from TestControllerQt.
4311
4312         * WebKitTestRunner/TestController.cpp:
4313         (WTR::TestController::didFinishLoadForFrame):
4314         * WebKitTestRunner/TestController.h:
4315         * WebKitTestRunner/TestInvocation.cpp:
4316         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
4317         * WebKitTestRunner/mac/TestControllerMac.mm:
4318         (WTR::TestController::notifyDone): Add method stub.
4319         * WebKitTestRunner/qt/TestControllerQt.cpp:
4320         (WTR::TestControllerRunLoop::instance):
4321         (WTR::TestControllerRunLoop::start):
4322         (WTR::TestControllerRunLoop::stop):
4323         (WTR::TestControllerRunLoop::TestControllerRunLoop):
4324         (WTR::TestControllerRunLoop::timerEvent):
4325         (WTR::TestController::notifyDone):
4326         (WTR::TestController::platformRunUntil):
4327         * WebKitTestRunner/win/TestControllerWin.cpp:
4328         (WTR::TestController::notifyDone): Add method stub.
4329
4330 2010-11-15  Darin Adler  <darin@apple.com>
4331
4332         * Scripts/webkitpy/common/net/bugzilla: Added property svn:ignore.
4333
4334 2010-11-15  Benjamin Poulain  <benjamin.poulain@nokia.com>
4335
4336         Reviewed by Andreas Kling.
4337
4338         [Qt] [WK2] Add Ctrl+L shortcut to Qt Minibrowser
4339         https://bugs.webkit.org/show_bug.cgi?id=49544
4340
4341         Add the shortcut to BrowserWindow.
4342
4343         * MiniBrowser/qt/BrowserWindow.cpp:
4344         (BrowserWindow::BrowserWindow):
4345         (BrowserWindow::openLocation):
4346         * MiniBrowser/qt/BrowserWindow.h:
4347
4348 2010-11-14  David Levin  <levin@chromium.org>
4349
4350         Reviewed by Daniel Bates.
4351
4352         check-webkit-style should detect PassRefPtr usage in functions.
4353         https://bugs.webkit.org/show_bug.cgi?id=49513
4354
4355         * Scripts/webkitpy/style/checkers/cpp.py:
4356         (check_for_function_lengths): Revert a comment change that I
4357          accidentally made in r71986.
4358         (check_pass_ptr_usage): Added the code to do the check.
4359         (process_line): Added the call to check_pass_ptr_usage.
4360         (CppChecker): Added the new error category.
4361         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
4362         (CppStyleTestBase::perform_pass_ptr_check): Runs the new check for
4363          testing purposes.
4364         (PassPtrTest::*): The class/functions to unit test the new
4365          functionality.
4366
4367 2010-11-14  David Levin  <levin@chromium.org>
4368
4369         Reviewed by Shinichiro Hamaji.
4370
4371         check-webkit-style function detection and the line count style checks should be separate.
4372         https://bugs.webkit.org/show_bug.cgi?id=49512
4373
4374         * Scripts/webkitpy/style/checkers/cpp.py: Do the separation.
4375         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Adjust the test to
4376           call the detection function and fix line counts in two places now that
4377           the code really only counts the lines in the body of the function.
4378
4379 2010-11-14  Andreas Kling  <kling@webkit.org>
4380
4381         Reviewed by Antonio Gomes.
4382
4383         http/tests/plugins tests print "Unhandled variable" to stderr under Qt
4384         https://bugs.webkit.org/show_bug.cgi?id=33438
4385
4386         Stifle "Unhandled variable" warning to match what the other
4387         TestNetscapePlugin does (NPP_GetValue in TestNetscapePlugIn/main.cpp
4388         simply returns NPERR_GENERIC_ERROR for unhandled variables.)
4389
4390         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
4391         (webkit_test_plugin_get_value):
4392
4393 2010-11-13  David Levin  <levin@chromium.org>
4394
4395         Reviewed by Eric Seidel.
4396
4397         check-webkit-style function detection crashes on functions in templates.
4398         https://bugs.webkit.org/show_bug.cgi?id=49504
4399
4400         For example "template <bool shouldClose(const Element*)>".
4401
4402         * Scripts/webkitpy/style/checkers/cpp.py: If not function is detected, bail out.
4403         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Modified the complex
4404           function detection test to expose this issue.
4405
4406 2010-11-12  David Levin  <levin@chromium.org>
4407
4408         Reviewed by Shinichiro Hamaji.
4409
4410         check-webkit-style function detection doesn't detect indented functions declaractions.
4411         https://bugs.webkit.org/show_bug.cgi?id=49446
4412
4413         Indented function declarations occur inside class definitions, so
4414         they are a pretty common (and worth detecting).
4415
4416         * Scripts/webkitpy/style/checkers/cpp.py:
4417           Changed regex to allow indentation.
4418           Changed the function start detection to only happen when not in a
4419           function.