2011-02-06 Maciej Stachowiak <mjs@apple.com>
[WebKit.git] / Tools / ChangeLog
1 2011-02-06  Maciej Stachowiak  <mjs@apple.com>
2
3         Reviewed by Dan Bernstein.
4
5         WebKitTestRunner needs layoutTestController.setWillSendRequestReturnsNull
6         https://bugs.webkit.org/show_bug.cgi?id=42690
7         <rdar://problem/8213851>
8
9         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
10         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
11         (WTR::InjectedBundlePage::willSendRequestForFrame):
12         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
13         (WTR::LayoutTestController::LayoutTestController):
14         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
15         (WTR::LayoutTestController::willSendRequestReturnsNull):
16         (WTR::LayoutTestController::setWillSendRequestReturnsNull):
17
18 2011-02-05  Sheriff Bot  <webkit.review.bot@gmail.com>
19
20         Unreviewed, rolling out r77720.
21         http://trac.webkit.org/changeset/77720
22         https://bugs.webkit.org/show_bug.cgi?id=53854
23
24         "Broke nrwt on Chromium win." (Requested by dglazkov|away on
25         #webkit).
26
27         * Scripts/webkitpy/common/system/executive.py:
28
29 2011-02-05  Sheriff Bot  <webkit.review.bot@gmail.com>
30
31         Unreviewed, rolling out r77725.
32         http://trac.webkit.org/changeset/77725
33         https://bugs.webkit.org/show_bug.cgi?id=53844
34
35         It broke Qt minimal build (Requested by Ossy_ on #webkit).
36
37         * QtTestBrowser/launcherwindow.cpp:
38         (LauncherWindow::createChrome):
39         * QtTestBrowser/launcherwindow.h:
40         (WindowOptions::WindowOptions):
41         * QtTestBrowser/main.cpp:
42         (LauncherApplication::handleUserOptions):
43
44 2011-02-04  Martin Robinson  <mrobinson@igalia.com>
45
46         Reviewed by Adam Barth.
47
48         [GTK] plugins/plugin-document-back-forward.html fails
49         https://bugs.webkit.org/show_bug.cgi?id=53833
50
51         Add the new "alert on load" functionality for the Unix version of the
52         test plugin. This functionality was originally introduced in r77706.
53
54         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
55         (webkit_test_plugin_new_instance): Add new plugin fuctionality.
56
57 2011-02-04  Kundu Suchismita  <suchi.kundu@nokia.com>
58
59         Reviewed by Andreas Kling.
60
61         Local Storage settings can be enable/disable from "Develop" menu
62         https://bugs.webkit.org/show_bug.cgi?id=52296
63
64         * QtTestBrowser/launcherwindow.cpp:
65         (LauncherWindow::createChrome):
66         (LauncherWindow::toggleLocalStorage):
67         (LauncherWindow::toggleOfflineStorageDatabase):
68         (LauncherWindow::toggleOfflineWebApplicationCache):
69         (LauncherWindow::setOfflineStorageDefaultQuota):
70         * QtTestBrowser/launcherwindow.h:
71         (WindowOptions::WindowOptions):
72         * QtTestBrowser/main.cpp:
73         (LauncherApplication::handleUserOptions):
74
75 2011-02-04  Tony Chang  <tony@chromium.org>
76
77         Reviewed by Eric Seidel.
78
79         get test-webkitpy running on win32 python
80         https://bugs.webkit.org/show_bug.cgi?id=53822
81
82         The test harness crashes with a WindowsError because it can't find
83         'svn' when using subprocess.Popen.  This gets us past the error
84         so we can see the failing tests on the Chromium Win Release Tests
85         bot.
86
87         * Scripts/webkitpy/common/system/executive.py:
88
89 2011-02-04  Martin Robinson  <mrobinson@igalia.com>
90
91         Reviewed by Gustavo Noronha Silva.
92
93         [GTK] fast/events/pagehide-timeout.html fails
94         https://bugs.webkit.org/show_bug.cgi?id=53771
95
96         Add knowledge of the document browser cache model the DRT. When resetting
97         WebKit settings to consistent values between tests, default to the document
98         browser cache model.
99
100         * DumpRenderTree/gtk/DumpRenderTree.cpp:
101         (resetDefaultsToConsistentValues): Reset the cache model to the document browser
102         cache model between tests.
103         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
104         (LayoutTestController::setCacheModel): An int value of 2 here corresponds to the
105         document browser cache model.
106
107 2011-02-04  Adam Barth  <abarth@webkit.org>
108
109         Reviewed by Eric Seidel.
110
111         PluginDocuments don't create widgets for plugins on back/forward
112         https://bugs.webkit.org/show_bug.cgi?id=53474
113
114         Teach the test plugin how to call alert on load.
115
116         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
117         (NPP_New):
118
119 2011-02-04  Adam Roben  <aroben@apple.com>
120
121         Add a test case for encode/decode of FormData/FormDataElement
122
123         If the fix made in r77401 is broken, this new test will crash.
124
125         Fixes <http://webkit.org/b/53616> <rdar://problem/8949883>.
126
127         Reviewed by Sam Weinig.
128
129         * TestWebKitAPI/Test.h: Moved the bulk of TEST_ASSERT into a new _TEST_ASSERT_HELPER macro.
130         Added a new TEST_ASSERT_RETURN macro that can be used in functions with a return value.
131
132         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp: Added.
133         (TestWebKitAPI::didFinishLoadForFrame): Record that the load is finished.
134         (TestWebKitAPI::setPageLoaderClient): Hook up the loader client.
135         (TestWebKitAPI::createSessionStateContainingFormData): Load simple-form.html, submit the
136         form, an return the session state data.
137         (TestWebKitAPI::TEST): Create some session state that contains form data from one WKPage,
138         and restore it into another WKPage.
139
140         * TestWebKitAPI/Tests/WebKit2/simple-form.html: Added.
141
142         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
143         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
144         * TestWebKitAPI/win/copy-resources.cmd:
145         Added new files.
146
147 2011-02-04  Adam Roben  <aroben@apple.com>
148
149         Move code to run JavaScript tests into its own files
150
151         This will allow other tests to use this mechanism.
152
153         Fixes <http://webkit.org/b/53806> SpacebarScrolling should share its JavaScript-fu with the
154         world
155
156         Reviewed by Sam Weinig.
157
158         * TestWebKitAPI/JavaScriptTest.cpp: Added.
159         * TestWebKitAPI/JavaScriptTest.h: Added.
160         Moved code here...
161
162         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp: ...from here.
163
164         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
165         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
166         Added the new files.
167
168 2011-02-04  Dirk Pranke  <dpranke@chromium.org>
169
170         Reviewed by Mihai Parparita.
171
172         merge test expectations for chromium, chromium-gpu. The
173         chromium-gpu port will no longer maintain its own
174         test expectations file.
175
176         Also add in a graphics_type() call on the port object to
177         determine what graphics type to use in the test configuration,
178         and log the configuration as a config setting.
179
180         https://bugs.webkit.org/show_bug.cgi?id=53562
181
182         * Scripts/webkitpy/layout_tests/port/base.py:
183         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
184         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
185         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
186
187 2011-02-04  Mikhail Naganov  <mnaganov@chromium.org>
188
189         Reviewed by Pavel Feldman.
190
191         Web Inspector: fix processing Unicode literals from .js sources in check-inspector-strings.
192         https://bugs.webkit.org/show_bug.cgi?id=53781
193
194         * Scripts/check-inspector-strings:
195
196 2011-02-04  Adam Roben  <aroben@apple.com>
197
198         Include the crashing function in the link to a crash log on Mac
199
200         Fixes <http://webkit.org/b/53780> Crash log links in results.html should include the
201         function that crashed on Mac
202
203         Reviewed by David Kilzer.
204
205         * Scripts/old-run-webkit-tests:
206         (crashLocation): Moved all the Windows code inside an if instead of using an early return,
207         but didn't otherwise change it. Added an if for Mac that parses the crashing function out of
208         the crash log.
209
210 2011-02-04  Adam Roben  <aroben@apple.com>
211
212         Link to Mac crash logs from results.html
213
214         Fixes <http://webkit.org/b/14861> run-webkit-tests should link to Mac crash logs in
215         results.html
216
217         Reviewed by David Kilzer.
218
219         * Scripts/old-run-webkit-tests:
220         (captureSavedCrashLog): Added a case for Apple's Mac port. We get the crash log out of
221         ~/Library/Logs/CrashReporter, and wait for ReportCrash to exit before trying to get the log.
222
223 2011-02-03  Maciej Stachowiak  <mjs@apple.com>
224
225         Reviewed by Dan Bernstein.
226
227         WebKit2: Need WebKit2 equivalent of WebResourceLoadDelegate::willSendRequest in the Bundle
228         https://bugs.webkit.org/show_bug.cgi?id=52897
229         <rdar://problem/8898294>
230
231         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
232         (WTR::InjectedBundlePage::InjectedBundlePage):
233         (WTR::InjectedBundlePage::willSendRequestForFrame):
234         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
235
236 2011-02-03  Ivan Krstić  <ike@apple.com>
237
238         Unreviewed.
239
240         Adding myself to committers.py.
241
242         * Scripts/webkitpy/common/config/committers.py:
243
244 2011-02-03  James Kozianski  <koz@chromium.org>
245
246         Reviewed by Dimitri Glazkov.
247
248         Add navigator.registerProtocolHandler behind a flag.
249         https://bugs.webkit.org/show_bug.cgi?id=52609
250
251         * Scripts/build-webkit:
252
253 2011-02-03  Hayato Ito  <hayato@chromium.org>
254
255         Reviewed by Eric Seidel.
256
257         [NRWT] Remove TestArgs class, which is wrongly used.
258
259         https://bugs.webkit.org/show_bug.cgi?id=53063
260
261         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
262         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
263         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
264         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
265         * Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py:
266         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
267
268 2011-02-03  Andrew Wason  <rectalogic@rectalogic.com>
269
270         Reviewed by Kenneth Russell.
271
272         Change ENABLE_3D_CANVAS to ENABLE_WEBGL
273         https://bugs.webkit.org/show_bug.cgi?id=53714
274
275         * Scripts/build-webkit: change --3d-canvas build option
276           to set ENABLE_WEBGL
277
278 2011-02-03  Hayato Ito  <hayato@chromium.org>
279
280         Reviewed by Tony Chang.
281
282         [NRWT] Introduces Input/Output class used by base.Driver into port/base.py and
283         move _run_single_test() and _process_output() functions from
284         dump_render_tree_thread.py to a single_test_runner.py as an individual module.
285
286         This is clean up and acts as a preparation for elimination of test_types/*
287         classes. These classes will move to the single_test_runner module introduced
288         in this patch.
289
290         https://bugs.webkit.org/show_bug.cgi?id=53004
291
292         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
293         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py: Added.
294         * Scripts/webkitpy/layout_tests/layout_package/test_input.py:
295         * Scripts/webkitpy/layout_tests/layout_package/test_output.py: Removed.
296         * Scripts/webkitpy/layout_tests/port/base.py:
297         * Scripts/webkitpy/layout_tests/port/chromium.py:
298         * Scripts/webkitpy/layout_tests/port/dryrun.py:
299         * Scripts/webkitpy/layout_tests/port/test.py:
300         * Scripts/webkitpy/layout_tests/port/webkit.py:
301         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
302         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
303         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
304
305 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
306
307         Unreviewed, build fix.
308
309         Delete a line that was accidentally missed in r77586; without it
310         there is still a race between the two threads.
311
312         https://bugs.webkit.org/show_bug.cgi?id=51572
313
314         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
315
316 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
317
318         Reviewed by Tony Chang.
319
320         nrwt: handle "broken pipe" notifications from DRT more cleanly.
321
322         https://bugs.webkit.org/show_bug.cgi?id=52927
323
324         * Scripts/webkitpy/layout_tests/port/server_process.py:
325         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
326
327 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
328
329         Reviewed by Kenneth Russell.
330
331         Update, resubmit change to bug 51572. I think the race that was
332         fixed in r76703 caused the hang that caused us to roll this
333         patch out before, so I'd like to try again.
334
335         https://bugs.webkit.org/show_bug.cgi?id=51572
336
337         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
338         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
339
340 2011-02-03  Daniel Cheng  <dcheng@chromium.org>
341
342         Unreviewed.
343
344         Adding myself to committers.py.
345
346         * Scripts/webkitpy/common/config/committers.py:
347
348 2011-02-03  Adam Roben  <aroben@apple.com>
349
350         Include the crashing function in the link to a crash log
351
352         Fixes <http://webkit.org/b/53739> Crash log links in results.html should include the
353         function that crashed
354
355         Reviewed by David Kilzer.
356
357         * Scripts/old-run-webkit-tests:
358         (crashLocation): Added. Returns the location of the crash.
359         (linksForErrorTest): Include the crash location in the link text for the crash log, if one
360         could be determined.
361
362 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
363
364         Unreviewed, build fix.
365
366         Actually make the changes suggested by Mihai in his review
367         of bug 53720 :(
368
369         https://bugs.webkit.org/show_bug.cgi?id=53720
370
371         * Scripts/webkitpy/layout_tests/port/test_files.py:
372         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
373
374 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
375
376         Reviewed by Mihai Parparita.
377
378         new-run-webkit-tests: Fix bug introduced in r77434 that was
379         causing us to run the canvas GPU tests on the Mac GPU port. This
380         bug revealed that we were not setting the port.name() field
381         properly in many cases, so I've cleaned up all of that code, and
382         removed a few comments about "version-specific" GPU ports that
383         don't exist and just confused things.
384
385         Testing also revealed that port.abspath_for_test() wasn't
386         normalizing paths on Windows properly, so I fixed that as well.
387
388         https://bugs.webkit.org/show_bug.cgi?id=53719
389
390         * Scripts/webkitpy/layout_tests/port/base.py:
391         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
392         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
393
394 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
395
396         Reviewed by Mihai Parparita.
397
398         new-run-webkit-tests: fix normalization of paths on windows when gathering files
399
400         r77434 introduced a bug that was causing the test expectations
401         for the GPU ports to not be treated properly. It turns out that
402         when we gathered the list of test files on Windows, we would
403         return paths of the form "c:\LayoutTests/fast/canvas", and the
404         mixture of backslashes and forward slashes was confusing things.
405
406         This patch normalizes all of the filenames returned from
407         test_files.find(), and adds better tests for this (fixing a
408         couple of other bugs found in the meantime).
409
410         https://bugs.webkit.org/show_bug.cgi?id=53720
411
412         * Scripts/webkitpy/layout_tests/port/test.py:
413         * Scripts/webkitpy/layout_tests/port/test_files.py:
414         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
415
416 2011-02-03  Adam Roben  <aroben@apple.com>
417
418         Add links to Windows crash logs in results.html
419
420         Fixes <http://webkit.org/b/53718> run-webkit-tests should link to Windows crash logs in
421         results.html
422
423         Reviewed by David Kilzer.
424
425         * Scripts/old-run-webkit-tests:
426         (top level): Added $crashLogTag and $windowsCrashLogFilePrefix (which came from
427         createDebuggerCommandFile).
428         (testCrashedOrTimedOut): If the test crashed, capture any saved crash log after the dump
429         tool has exited.
430         (captureSavedCrashLog): Added. Finds the crash log for the test that just crashed and moves
431         it into the test results directory tree. Only implemented for Cygwin currently.
432         (findNewestFileMatchingGlob): Added. Does what it says.
433         (htmlForResultsSection): Only link to files that exist.
434         (linksForErrorTest): Add a link to the crash log.
435         (deleteExpectedAndActualResults): Delete any old crash log for this test.
436         (createDebuggerCommandFile): Use the new $windowsCrashLogFilePrefix constant instead of
437         hardcoding it here.
438
439 2011-02-03  Adam Roben  <aroben@apple.com>
440
441         Tell the debugger the path to the WebKit source tree when saving a crash log
442
443         This allows the debugger to include the crashing line of code in the log.
444
445         Fixes <http://webkit.org/b/53678> Crash logs from buildslaves don't show the crashing line
446         of code
447
448         Reviewed by Sam Weinig.
449
450         * Scripts/old-run-webkit-tests:
451         (createDebuggerCommandFile): Added. Saves commands that we'd like the debugger to run to a
452         file and returns the path to that file. The commands we pass came from
453         setUpWindowsCrashLogSaving, but I've added a .srcpath command to tell the debugger where the
454         WebKit source code lives.
455         (setUpWindowsCrashLogSaving): Instead of specifying the commands directly on the command
456         line using -c, save them to a file and specify the path to that file using -cf. This works
457         around what is presumably a bug in Windows's command line parsing, where having multiple
458         quoted paths in the debugger commands causes the post-mortem debugger not to be invoked at
459         all. Also pulled the options we pass to the debugger out into a list that is then join()ed
460         together to make them easier to modify in the future.
461
462 2011-02-02  Sam Weinig  <sam@webkit.org>
463
464         Reviewed by Anders Carlsson.
465
466         Add notification of the end of a rubber band.
467         <rdar://problem/8940648>
468
469         * MiniBrowser/mac/BrowserWindowController.m:
470         (-[BrowserWindowController awakeFromNib]):
471         * WebKitTestRunner/TestController.cpp:
472         (WTR::TestController::createOtherPage):
473         (WTR::TestController::initialize):
474         Stub out the new WKUIClient function.
475
476 2011-02-03  Gabor Rapcsanyi  <rgabor@webkit.org>
477
478         Unreviewed.
479
480         Adding myself to committers.py.
481
482         * Scripts/webkitpy/common/config/committers.py:
483
484 2011-02-03  Balazs Kelemen  <kbalazs@webkit.org>
485
486         Reviewed by Csaba Osztrogonác.
487
488         [Qt][WK2] MiniBrowser's window size should be 800x600
489         https://bugs.webkit.org/show_bug.cgi?id=53670
490
491         Make layout test failure debugging easier.
492         * MiniBrowser/qt/BrowserWindow.cpp:
493         (BrowserWindow::BrowserWindow):
494
495 2011-02-02  Andy Estes  <aestes@apple.com>
496
497         Reviewed by Mark Rowe.
498
499         'update-webkit' should handle OpenSource and Internal using different
500         VCSs.
501
502         * Scripts/update-webkit: Re-check the VCS type when updating Apple's
503         Internal directory.
504
505 2011-02-02  Dirk Pranke  <dpranke@chromium.org>
506
507         Reviewed by Mihai Parparita.
508
509         new-run-webkit-tests: hardcode the directories to scan for tests
510         for GPU bots instead of SKIPping them. See bug 53562 for some
511         context, but we will now hard-code the list of directories to
512         use by default instead of skipping over directories in the
513         expectations file. We do this so that we will be able to merge
514         the expectations files without getting conflicting SKIP
515         directives. Note that this change will reduce the # of tests
516         being run on the Mac GPU bots, because we're accidentally
517         including some today.
518
519         https://bugs.webkit.org/show_bug.cgi?id=53631
520
521         * Scripts/webkitpy/layout_tests/port/base.py:
522         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
523         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
524
525 2011-02-02  Sam Weinig  <sam@webkit.org>
526
527         Reviewed by Beth Dakin.
528
529         Add ChromeClient function to paint custom overhang areas.
530         https://bugs.webkit.org/show_bug.cgi?id=53639
531
532         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
533         (WTR::InjectedBundlePage::InjectedBundlePage):
534         Stub out new callback.
535
536 2011-02-02  Dirk Pranke  <dpranke@chromium.org>
537
538         Reviewed by Tony Chang.
539
540         new-run-webkit-tests: support chromium code paths in mock_drt
541
542         https://bugs.webkit.org/show_bug.cgi?id=53471
543
544         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
545         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
546
547 2011-02-02  Adam Klein  <adamk@chromium.org>
548
549         Reviewed by Tony Chang.
550
551         Update new-run-webkit-tests --chromium to put output under Source/...
552         https://bugs.webkit.org/show_bug.cgi?id=53612
553
554         * BuildSlaveSupport/test-result-archive:
555         * Scripts/webkitpy/layout_tests/port/chromium.py:
556
557 2011-01-28  Tony Chang  <tony@chromium.org>
558
559         Reviewed by Eric Seidel.
560
561         [chromium] remove --use-test-shell from NRWT
562         https://bugs.webkit.org/show_bug.cgi?id=53346
563
564         I've already started removing some of the bindings like eventSender so
565         this already doesn't work isn't useful.  Also updated some comments to
566         refer to DRT instead of test_shell.
567
568         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
569         * Scripts/webkitpy/layout_tests/port/chromium.py:
570         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
571         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
572         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
573         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
574         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
575         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
576
577 2011-02-02  Steve Lacey  <sjl@chromium.org>
578
579         Reviewed by Eric Carlson.
580
581         Implement basic media statistics on media elements.
582         https://bugs.webkit.org/show_bug.cgi?id=53322
583
584         * Scripts/build-webkit:
585
586 2011-02-02  Kevin Ollivier  <kevino@theolliviers.com>
587
588         [wx] Build fixes for wxWebKit.
589
590         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
591         (LayoutTestController::setSerializeHTTPLoads):
592         * wx/browser/wscript:
593         * wx/build/build_utils.py:
594         * wx/build/settings.py:
595
596 2011-02-01  Dirk Pranke  <dpranke@chromium.org>
597
598         Reviewed by Mihai Parparita.
599
600         new-run-webkit-tests: stop skipping so many tests
601
602         r77163 introduced a regression where we weren't resetting test
603         expectations properly and were skipping too many tests as a
604         result. This patch fixes that and adds a test for it.
605
606         https://bugs.webkit.org/show_bug.cgi?id=53551
607
608         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
609         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
610
611 2011-02-01  Dirk Pranke  <dpranke@chromium.org>
612
613         Reviewed by Tony Chang.
614
615         new-run-webkit-tests: add first stub of test_runner2. This
616         will add support for the 'inline', 'threads', and 'processes'
617         flags to --worker-model, but for now the implementatios just
618         fall back on the old ones.
619
620         https://bugs.webkit.org/show_bug.cgi?id=53157
621
622         * Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
623         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
624
625 2011-02-01  Mihai Parparita  <mihaip@chromium.org>
626
627         Reviewed by James Robinson.
628
629         [Chromium] run-chromium-webkit-unit-tests looks for binaries in the wrong place
630         https://bugs.webkit.org/show_bug.cgi?id=53522
631
632         * Scripts/run-chromium-webkit-unit-tests:
633
634 2011-02-01  Adam Barth  <abarth@webkit.org>
635
636         Reviewed by Mihai Parparita.
637
638         Using Control-C to cancel webkit-patch or other python tools causes
639         unpleasant traceback console spew
640         https://bugs.webkit.org/show_bug.cgi?id=53462
641
642         Catch the exception and don't print the stack trace.
643
644         * Scripts/webkit-patch:
645
646 2011-02-01  Scott Cameron  <sccameron@rim.com>
647
648         Reviewed by Daniel Bates.
649
650         Use Windows format for MinGW HTTPD path.
651         https://bugs.webkit.org/show_bug.cgi?id=53503
652
653         * Scripts/webkitperl/httpd.pm:
654           - Use single-quotes around MySys value for $httpdPath in getHTTPDPath()
655             so that we don't have to escape the space characters in the path. Also,
656             changed path to Windows-style path and removed FIXME comment.
657
658 2011-02-01  Balazs Kelemen  <kbalazs@webkit.org>
659
660         Reviewed by Andreas Kling.
661
662         [Qt][WK2] Add a way to use shared process model in MiniBrowser
663         https://bugs.webkit.org/show_bug.cgi?id=53090
664
665         * MiniBrowser/qt/BrowserView.cpp:
666         (BrowserView::BrowserView): Removed the m_context member.
667         From now the context is guaranteed to be non-null and we
668         don't need to store that in the object.
669         * MiniBrowser/qt/BrowserView.h:
670         * MiniBrowser/qt/BrowserWindow.cpp:
671         Added static bool to determine that new windows need to be
672         created with their own context or not. Use the same context
673         and web process by default to be inilne with the other ports.
674         (BrowserWindow::BrowserWindow):
675         (BrowserWindow::newWindow):
676         * MiniBrowser/qt/BrowserWindow.h:
677         * MiniBrowser/qt/main.cpp:
678         (main): Added command line switch to be able to use the
679         non-shared process model. Simplify the handling of the command line
680         switches a little bit.
681
682 2011-02-01  Zoltan Horvath  <zoltan@webkit.org>
683
684         Reviewed by Andreas Kling.
685
686         [Qt] Add Window menu and Toggle FullScreen action to MiniBrowser.
687         https://bugs.webkit.org/show_bug.cgi?id=53491
688
689         * MiniBrowser/qt/BrowserWindow.cpp:
690         (BrowserWindow::BrowserWindow):
691         (BrowserWindow::toggleFullScreenMode):
692         * MiniBrowser/qt/BrowserWindow.h:
693
694 2011-02-01  Zoltan Horvath  <zoltan@webkit.org>
695
696         Reviewed by Andreas Kling.
697
698         [Qt] Add Toggle Frame Flattening, Auto Load Images and Disable JavaScript actions to MiniBrowser.
699         https://bugs.webkit.org/show_bug.cgi?id=53489
700
701         Add Toggle Frame Flattening action to Develop menu. Add Auto Load Images and Disable JavaScript actions
702         to Settings menu.
703
704         * MiniBrowser/qt/BrowserWindow.cpp:
705         (BrowserWindow::BrowserWindow):
706         (BrowserWindow::toggleFrameFlattening):
707         (BrowserWindow::toggleDisableJavaScript):
708         (BrowserWindow::toggleAutoLoadImages):
709         * MiniBrowser/qt/BrowserWindow.h:
710
711 2011-01-31  Mihai Parparita  <mihaip@chromium.org>
712
713         Reviewed by Tony Chang.
714
715         [Chromium] Switch chromium-mac to use ChromiumDriver
716         https://bugs.webkit.org/show_bug.cgi?id=53461
717         
718         For the sake of consistency with the other Chromium platforms (and so
719         that chromium-mac picks up special flags like --enable-hardware-gpu),
720         switch chromium-mac from the WebKitDriver to ChromiumDriver.
721
722         * Scripts/webkitpy/layout_tests/port/chromium.py:
723
724 2011-01-31  Dirk Pranke  <dpranke@chromium.org>
725
726         Reviewed by Mihai Parparita.
727
728         The current modifier parsing code in test_expectations is
729         fragile and hard-coded, so it's not easy to understand the logic
730         or easily add new types of modifiers (like GPU vs. CPU testing
731         for graphics tests, or 32-bit vs. 64-bit differences).
732
733         This is the first of two patches that will add in more generic
734         support and then eliminate the GPU-specific test expectations
735         files for Chromium.
736
737         This patch adds two standalone objects for handling modifiers. The
738         rules for interpreting modifiers, precedence, and conflicts are
739         given in the docstring to the ModifierMatcher class, which
740         returns ModifierMatchResult objects.
741         
742         This patch also adds routines to the Port interface and a
743         default set of values in the base object, in order to obtain the
744         values needed on a given test run. These values are then passed
745         to the expectation parser. This also allows us to clean up the
746         logic used to lint all of the different configurations in a
747         single test_expectations.txt file.
748
749         The next patch will merge in the separate GPU expectations file.
750
751         https://bugs.webkit.org/show_bug.cgi?id=51222
752
753         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
754         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
755         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
756         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
757         * Scripts/webkitpy/layout_tests/port/base.py:
758         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
759         * Scripts/webkitpy/layout_tests/port/chromium.py:
760         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
761         * Scripts/webkitpy/layout_tests/port/test.py:
762         * Scripts/webkitpy/layout_tests/port/webkit.py:
763         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
764         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
765         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
766         * Tools/Scripts/webkitpy/style/checkers/test_expectations.py:
767         * Tools/Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
768
769 2011-01-31  Scott Cameron  <sccameron@rim.com>
770
771         Reviewed by Daniel Bates.
772
773         update run-webkit-httpd to be able to launch Apache2.2 in a MSYS environment
774         https://bugs.webkit.org/show_bug.cgi?id=50036
775
776         This will add an Apache2.2 configuration file and modifies scripts to allow
777         running an httpd server in an MSYS environment.
778
779         The default Apache2.2 installation path has been preserved and PHP5 modules disabled
780         in order to allow for simple installation/execution.  Simply install the latest
781         Apache2.2 version with OpenSSL from http://httpd.apache.org/download.cgi#apache22 to
782         be able to execute run-webkit-httpd.
783         
784
785         * Scripts/run-webkit-httpd:
786         * Scripts/webkitperl/httpd.pm:
787
788 2011-01-31  Tony Chang  <tony@chromium.org>
789
790         Reviewed by Eric Seidel.
791
792         mac DRT should report RTL scroll offset relative to top right corner
793         https://bugs.webkit.org/show_bug.cgi?id=53324
794
795         * DumpRenderTree/mac/DumpRenderTree.mm:
796         (dumpFrameScrollPosition):
797
798 2011-01-31  Zoltan Horvath  <zoltan@webkit.org>
799
800         Reviewed by Andreas Kling.
801
802         [Qt] Add Take Screen Shot action to MiniBrowser
803         https://bugs.webkit.org/show_bug.cgi?id=53422
804
805         Add Take Screen Shot action to MiniBrowser's view menu.
806
807         * MiniBrowser/qt/BrowserWindow.cpp:
808         (BrowserWindow::BrowserWindow):
809         (BrowserWindow::screenshot):
810         * MiniBrowser/qt/BrowserWindow.h:
811
812 2011-01-31  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
813
814         Reviewed by Xan Lopez.
815
816         [GTK] REGRESSION:  http/tests/media/video-{cookie,referer}.html failing
817         https://bugs.webkit.org/show_bug.cgi?id=53379
818
819         Remove left over #ifdef's. I thought all of the conditional code
820         had been freed from the condition, but I forgot to check DRT.
821
822         * DumpRenderTree/gtk/DumpRenderTree.cpp:
823         (resetDefaultsToConsistentValues):
824         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
825         (LayoutTestController::setAlwaysAcceptCookies):
826
827 2011-01-30  Dirk Pranke  <dpranke@chromium.org>
828
829         Unreviewed, build fix.
830
831         Fix regression introduced in r77093 - path.rsplit() doesn't
832         take keyword arguments.
833
834         https://bugs.webkit.org/show_bug.cgi?id=53326
835
836         * Scripts/webkitpy/common/system/filesystem_mock.py:
837
838 2011-01-30  Dirk Pranke  <dpranke@chromium.org>
839
840         Reviewed by Mihai Parparita.
841
842         Add more unit tests for rebaseline-chromium-webkit-tests. This
843         change involves restructuring a bunch of r-c-w-t code to make it
844         more testable as well. We also add wrapper classes for handling
845         testing zip files and fetching URLs.
846
847         https://bugs.webkit.org/show_bug.cgi?id=53040
848
849         * Scripts/webkitpy/common/system/urlfetcher.py:
850         * Scripts/webkitpy/common/system/urlfetcher_mock.py:
851         * Scripts/webkitpy/common/system/zipfileset_mock.py:
852         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
853         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
854         * Scripts/webkitpy/tool/mocktool.py:
855
856 2011-01-30  Dirk Pranke  <dpranke@chromium.org>
857
858         Reviewed by Eric Seidel.
859
860         Clean up of the filesystem-related modules used in webkitpy.
861         I've added relpath() to the filesystem interface, modified
862         ospath.relpath() so that it could work with the filesystem
863         interface, and modified the fileset* routines to use the
864         filesystem interface consistently.
865
866         This patch also adds a close() routine to the fileset routines
867         to indicate that the caller is done with the fileset. This
868         allows zipfileset to clean up after itself when it creates
869         tempfiles to store downloads.
870
871         https://bugs.webkit.org/show_bug.cgi?id=53326
872
873         * Scripts/webkitpy/common/system/directoryfileset.py:
874         * Scripts/webkitpy/common/system/fileset.py:
875         * Scripts/webkitpy/common/system/filesystem.py:
876         * Scripts/webkitpy/common/system/filesystem_mock.py:
877         * Scripts/webkitpy/common/system/filesystem_unittest.py:
878         * Scripts/webkitpy/common/system/ospath.py:
879         * Scripts/webkitpy/common/system/zipfileset.py:
880         * Scripts/webkitpy/common/system/zipfileset_unittest.py:
881
882 2011-01-30  Balazs Kelemen  <kbalazs@webkit.org>
883
884         Reviewed by Csaba Osztrogonác.
885
886         [Qt][WK2]REGRESSION (r76991): Fix build errors
887         https://bugs.webkit.org/show_bug.cgi?id=53400
888
889         Revert the temporary build fix (http://trac.webkit.org/changeset/77088)
890         and remove WebKit2Prefix.h from the build.
891         * MiniBrowser/qt/MiniBrowser.pro:
892
893 2011-01-30  Csaba Osztrogonác  <ossy@webkit.org>
894
895         Unreviewed.
896
897         [Qt][WK2] Buildfix.
898
899         * MiniBrowser/qt/MiniBrowser.pro:
900
901 2011-01-28  Simon Fraser  <simon.fraser@apple.com>
902
903         Reviewed by Adam Roben.
904         
905         define NOMINMAX when building ImageDiff, as we do elsewhere.
906
907         Add various clampToInt() methods to MathExtras.h
908         https://bugs.webkit.org/show_bug.cgi?id=52910
909
910         * DumpRenderTree/win/ImageDiffCommon.vsprops:
911
912 2011-01-28  Maciej Stachowiak  <mjs@apple.com>
913
914         Reviewed by Darin Adler.
915
916         WebKitTestRunner needs layoutTestController.setPOSIXLocale
917         https://bugs.webkit.org/show_bug.cgi?id=42682
918
919         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
920         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
921         (WTR::InjectedBundle::resetLocalSettings):
922         (WTR::InjectedBundle::didReceiveMessage):
923         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
924         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
925         (WTR::LayoutTestController::setPOSIXLocale):
926         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
927
928 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
929  
930          Reviewed by Mihai Parparita.
931  
932          test-webkitpy: fix webkitpy.layout_tests.port.mac_unittest.MacTest.test_skipped_file_paths
933  
934          This patch re-enables this test and changes it to
935          handle all of the mac platform versions, not just the one
936          it is running on.
937  
938          https://bugs.webkit.org/show_bug.cgi?id=53356
939  
940          * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
941  
942 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
943
944         Unreviewed, build fix.
945
946         Take two. The fix in 77023 didn't work, because we were
947         still calling path.abspath_to_uri, which calls _cygpath under
948         the covers, and it appears the cygpath on the bots does
949         something different than it does on my machine. This patch
950         removes the calls to path.abspath_to_uri, so it should be safe.
951         If it doesn't work, I'll roll it out along with r76982 and 77023.
952
953         https://bugs.webkit.org/show_bug.cgi?id=53126
954
955         * Scripts/webkitpy/layout_tests/port/test.py:
956
957 2011-01-28  David Kilzer  <ddkilzer@apple.com>
958
959         <rdar://problem/8930699> build-webkit gives a bogus warning with newer versions of Xcode 
960         <http://webkit.org/b/53353>
961
962         Reviewed by Mark Rowe.
963
964         * Scripts/webkitdirs.pm:
965         (checkRequiredSystemConfig): Check the Xcode marketing version
966         in addition to the DevCoreTools build version before complaining
967         about an old version of Xcode.  Also make the Mac OS X version
968         check use Perl's built-in version string comparitor.
969
970 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
971
972         Unreviewed, build fix.
973
974         Work around breakage on Win 7 Release bot caused by r76982
975         and the fact that windows ports use "file:////" instead of
976         "file:///". Ideally the test code should be isolated from
977         this, but it isn't yet. Will fix properly in a bit.
978
979         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
980
981 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
982
983         Reviewed by Tony Chang.
984
985         new-run-webkit-tests: change worker model values to
986         "old-inline", "old-threads" in preparation for test_runner2 /
987         multiprocessing changes.
988
989         https://bugs.webkit.org/show_bug.cgi?id=53156
990
991         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
992         * Scripts/webkitpy/layout_tests/port/base.py:
993         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
994         * Scripts/webkitpy/layout_tests/port/mac.py:
995         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
996
997 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
998
999         Reviewed by Tony Chang.
1000
1001         committers.py - add an IRC nickname for dpranke
1002         https://bugs.webkit.org/show_bug.cgi?id=53335
1003
1004         * Scripts/webkitpy/common/config/committers.py:
1005
1006 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
1007
1008         Reviewed by Tony Chang.
1009
1010         new-run-webkit-tests: add a "mock DRT" port implementation
1011         and a separate class that emulates what we expect the
1012         DumpRenderTree behavior to be.
1013
1014         This will eventually replace port/dryrun.py and allow us to get
1015         better test coverage of the new-run-webkit-tests code as well as
1016         a reference for what new-run-webkit-tests expects from DRT.
1017
1018         This is the first attempt at this, and it is pretty bare-boned. It
1019         really only has been tested on the 'mac' port (and a little on
1020         the 'chromium-mac' port.
1021
1022         https://bugs.webkit.org/show_bug.cgi?id=53126
1023
1024         * Scripts/webkitpy/common/system/filesystem_mock.py:
1025         * Scripts/webkitpy/layout_tests/port/dryrun.py:
1026         * Scripts/webkitpy/layout_tests/port/factory.py:
1027         * Scripts/webkitpy/layout_tests/port/mock_drt.py: Added.
1028         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Added.
1029         * Scripts/webkitpy/layout_tests/port/test.py:
1030
1031 2011-01-28  Pratik Solanki  <psolanki@apple.com>
1032
1033         Unreviewed. Removing .swp file checked in by mistake.
1034
1035         * Scripts/.webkitdirs.pm.swp: Removed.
1036
1037 2011-01-28  Pratik Solanki  <psolanki@apple.com>
1038
1039         Reviewed by David Kilzer.
1040
1041         Space not necessary for undefined feature
1042         https://bugs.webkit.org/show_bug.cgi?id=53317
1043
1044         * Scripts/build-webkit:
1045
1046 2011-01-28  Chang Shu  <chang.shu@nokia.com>
1047
1048         Reviewed by Andreas Kling.
1049
1050         Reset NetworkAccessManager to clean up credentials from previous tests.
1051         This change causes no performance overhead either.
1052         https://bugs.webkit.org/show_bug.cgi?id=36688
1053
1054         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1055         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1056         (WebCore::DumpRenderTree::open):
1057         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1058
1059 2011-01-28  Zoltan Horvath  <zoltan@webkit.org>
1060
1061         Reviewed by Andreas Kling.
1062
1063         [Qt] Add Zoom Text Only action to MiniBrowser
1064         https://bugs.webkit.org/show_bug.cgi?id=53297
1065
1066         Add Zoom Text Only action to MiniBrowser's view menu, change zoom levels to avoid unnecessary divides.
1067
1068         * MiniBrowser/qt/BrowserWindow.cpp:
1069         (BrowserWindow::BrowserWindow):
1070         (BrowserWindow::zoomIn):
1071         (BrowserWindow::zoomOut):
1072         (BrowserWindow::resetZoom):
1073         (BrowserWindow::toggleZoomTextOnly):
1074         (BrowserWindow::applyZoom):
1075         * MiniBrowser/qt/BrowserWindow.h:
1076
1077 2011-01-28  Adam Barth  <abarth@webkit.org>
1078
1079         Reviewed by Eric Seidel.
1080
1081         Add webkit-patch roll-chromium-deps
1082         https://bugs.webkit.org/show_bug.cgi?id=53288
1083
1084         This command updates the Source/WebKit/chromium/DEPS file with the
1085         last-known good revision of Chromium (or a revision specified on the
1086         command line).  I'd eventually like to turn this into a SheriffBot
1087         command, but this is the first step.
1088
1089         This patch somewhat sprawled because I needed to move a bunch of code
1090         out of ChangeLog that should never have been there in the first place.
1091         Also, I had to fix a bug in MockUser in order to test the new command.
1092
1093         * Scripts/webkitpy/common/checkout/api.py:
1094         * Scripts/webkitpy/common/checkout/changelog.py:
1095         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1096         * Scripts/webkitpy/common/checkout/deps.py: Added.
1097         * Scripts/webkitpy/common/config/urls.py:
1098         * Scripts/webkitpy/tool/commands/__init__.py:
1099         * Scripts/webkitpy/tool/commands/download_unittest.py:
1100         * Scripts/webkitpy/tool/commands/roll.py: Added.
1101         * Scripts/webkitpy/tool/commands/roll_unittest.py: Added.
1102         * Scripts/webkitpy/tool/commands/upload_unittest.py:
1103         * Scripts/webkitpy/tool/mocktool.py:
1104         * Scripts/webkitpy/tool/steps/__init__.py:
1105         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py: Added.
1106         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
1107         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py: Added.
1108         * Scripts/webkitpy/tool/steps/suggestreviewers_unittest.py:
1109         * Scripts/webkitpy/tool/steps/updatechromiumdeps.py: Added.
1110         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
1111
1112 2011-01-27  Greg Coletta  <greg.coletta@nokia.com>
1113
1114         Reviewed by Laszlo Gombos.
1115
1116         Get rid of prefix header dependency for WebKit2 build system
1117         https://bugs.webkit.org/show_bug.cgi?id=50174
1118
1119         Change the style checker so that it enforces config.h include for
1120         WebKit2.
1121
1122         * Scripts/webkitpy/style/checker.py:
1123
1124 2011-01-27  Maciej Stachowiak  <mjs@apple.com>
1125
1126         Reviewed by Darin Adler.
1127
1128         execCommand("Paste") doesn't work in WebKitTestRunner
1129         https://bugs.webkit.org/show_bug.cgi?id=52785
1130
1131         Enable both of the settings needed to allow paste.
1132         
1133         * WebKitTestRunner/TestController.cpp:
1134         (WTR::TestController::resetStateToConsistentValues):
1135
1136 2011-01-27  Jacob Dinu  <dinu.jacob@nokia.com>
1137
1138         Reviewed by Andreas Kling.
1139
1140         [Qt] QtTestBrowser: User input lost when toggling use of QGraphicsView
1141         https://bugs.webkit.org/show_bug.cgi?id=48440
1142
1143         Preserve user input when toggling use of QGraphicsView
1144
1145         * QtTestBrowser/launcherwindow.cpp:
1146         (LauncherWindow::initializeView):
1147         (LauncherWindow::loadFinished):
1148         * QtTestBrowser/launcherwindow.h:
1149         * QtTestBrowser/mainwindow.cpp:
1150         (MainWindow::addressUrl):
1151         * QtTestBrowser/mainwindow.h:
1152
1153 2011-01-27  Dirk Pranke  <dpranke@chromium.org>
1154
1155         Reviewed by Mihai Parparita.
1156
1157         new-run-webkit-tests: turn off pixel tests correctly by default
1158         for webkit-based ports. r70013 (bug 47510) used
1159         port.set_option_default() to attempt to set default values, but
1160         that didn't work correctly. I have removed set_option_default
1161         for now since it was only being used in two places and in three
1162         useless unit tests. There is a separate bug open to fix the
1163         option parsing (48095), so this workaround is fine for now.
1164
1165         https://bugs.webkit.org/show_bug.cgi?id=53217
1166
1167         * Scripts/webkitpy/layout_tests/port/webkit.py:
1168         * Scripts/webkitpy/layout_tests/port/base.py:
1169         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1170
1171 2011-01-27  Balazs Kelemen  <kbalazs@webkit.org>
1172
1173         Rubber-stamped by Ariya Hidayat.
1174
1175         Trivial crash fix in WTR.
1176
1177         * WebKitTestRunner/TestController.cpp:
1178         (WTR::TestController::initialize): Increase the size
1179         of the vector by one to be able to store the null character.
1180
1181 2011-01-27  Balazs Kelemen  <kbalazs@webkit.org>
1182
1183         Reviewed by Csaba Osztrogonác.
1184
1185         [Qt][WK2] WTR should be initialized in the same way as DRT
1186         https://bugs.webkit.org/show_bug.cgi?id=53240
1187
1188         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
1189         (WTR::activateFonts): Added missing initialization steps.
1190
1191 2011-01-27  Joone Hur <joone.hur@collabora.co.uk>
1192
1193         Unreviewed. 
1194
1195         Adding myself to committers.py.
1196
1197         * Scripts/webkitpy/common/config/committers.py:
1198
1199 2011-01-27  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1200
1201         Reviewed by Csaba Osztrogonác.
1202
1203         [Qt] [Symbian] Move project files into Source
1204         https://bugs.webkit.org/show_bug.cgi?id=52891
1205
1206         Fix the Symbian build after the project files
1207         are moved to Source directory. On Symbian qmake
1208         needs to run in the same directory where the main
1209         pro files (WebKit.pro, Tools.pro) are located.
1210
1211         * Scripts/webkitdirs.pm: Change to the directory where the pro file
1212         is located before running qmake for Symbian. Qmake on Symbian
1213         does not properly honor the "-o" option, work it around by setting
1214         the name of the Makefile to bld.inf.
1215
1216 2011-01-27  Zoltan Horvath  <zoltan@webkit.org>
1217
1218         Reviewed by Andreas Kling.
1219
1220         [Qt] Add simple zooming features to MiniBrowser
1221         https://bugs.webkit.org/show_bug.cgi?id=53231
1222
1223         Add View menu and Zoom In, Zoom Out, Zoom Reset actions to MiniBrowser.
1224
1225         * MiniBrowser/qt/BrowserWindow.cpp:
1226         (BrowserWindow::BrowserWindow):
1227         (BrowserWindow::zoomIn):
1228         (BrowserWindow::zoomOut):
1229         (BrowserWindow::resetZoom):
1230         (BrowserWindow::updateUserAgentList):
1231         (BrowserWindow::applyZoom):
1232         * MiniBrowser/qt/BrowserWindow.h:
1233
1234 2011-01-26  Maciej Stachowiak  <mjs@apple.com>
1235
1236         Reviewed by Dan Bernstein.
1237
1238         WebKitTestRunner needs to support layoutTestController.evaluateInWebInspector
1239         https://bugs.webkit.org/show_bug.cgi?id=42319
1240         
1241         Add evaluateInWebInspector and other APIs needed for inspector tests to run.
1242
1243         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1244         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1245         (WTR::LayoutTestController::showWebInspector):
1246         (WTR::LayoutTestController::closeWebInspector):
1247         (WTR::LayoutTestController::evaluateInWebInspector):
1248         (WTR::LayoutTestController::setTimelineProfilingEnabled):
1249         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1250         * WebKitTestRunner/TestInvocation.cpp:
1251         (WTR::shouldOpenWebInspector):
1252         (WTR::TestInvocation::invoke):
1253         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
1254
1255 2011-01-26  Martin Robinson  <mrobinson@igalia.com>
1256
1257         Reviewed by Xan Lopez.
1258
1259         [GTK] Pixel dumps do not include scrollbars in output images
1260         https://bugs.webkit.org/show_bug.cgi?id=53216
1261
1262         Show scrollbars in pixel dumps. This will fix pixel dumps for tests
1263         that have scrollbars.
1264
1265         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
1266         (createBitmapContextFromWebView): Take the snapshot of the containing GtkScrolledWindow
1267         instead of the web view itself.
1268
1269 2011-01-26  Dirk Pranke  <dpranke@chromium.org>
1270
1271         Reviewed by Mihai Parparita.
1272
1273         Fix regression introduced in r76322 ... new-run-webkit-tests
1274         was attempting to save the image diff output as a UTF-8-encoded
1275         file.
1276
1277         https://bugs.webkit.org/show_bug.cgi?id=53210
1278
1279         * Scripts/webkitpy/layout_tests/port/webkit.py:
1280
1281 2011-01-26  Sheriff Bot  <webkit.review.bot@gmail.com>
1282
1283         Unreviewed, rolling out r76709.
1284         http://trac.webkit.org/changeset/76709
1285         https://bugs.webkit.org/show_bug.cgi?id=53194
1286
1287         "broke python tests on non-snowleopard platforms" (Requested
1288         by dpranke on #webkit).
1289
1290         * Scripts/webkitpy/layout_tests/port/factory.py:
1291         * Scripts/webkitpy/layout_tests/port/mock_drt.py: Removed.
1292         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Removed.
1293
1294 2011-01-26  Dirk Pranke  <dpranke@chromium.org>
1295
1296         Reviewed by Tony Chang.
1297
1298         new-run-webkit-tests: add a "mock DRT" port implementation
1299         and a separate class that emulates what we expect the
1300         DumpRenderTree behavior to be.
1301
1302         This will eventually replace port/dryrun.py and allow us to get
1303         better test coverage of the new-run-webkit-tests code as well as
1304         a reference for what new-run-webkit-tests expects from DRT.
1305
1306         This is the first attempt at this, and it is pretty bare-boned. It
1307         really only has been tested on the 'mac' port (and a little on
1308         the 'chromium-mac' port.
1309
1310         https://bugs.webkit.org/show_bug.cgi?id=53126
1311
1312         * Scripts/webkitpy/layout_tests/port/mock_drt.py: Added.
1313         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Added.
1314         * Scripts/webkitpy/layout_tests/port/factory.py:
1315
1316 2011-01-26  Xianzhu Wang  <wangxianzhu@google.com>
1317
1318         Reviewed by Tony Chang.
1319
1320         Add '--no-timeout' option to Chromium DRT to ease debugging.
1321         https://bugs.webkit.org/show_bug.cgi?id=52873
1322
1323         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1324         (main):
1325
1326 2011-01-26  Csaba Osztrogonác  <ossy@webkit.org>
1327
1328         Reviewed by Andreas Kling.
1329
1330         [Qt] Fix qt_minimal build
1331         https://bugs.webkit.org/show_bug.cgi?id=53172
1332
1333         * QtTestBrowser/locationedit.h:
1334
1335 2011-01-26  Mansi Mithal  <mansi.mithal@nokia.com>
1336
1337         Reviewed by Antonio Gomes.
1338
1339         QtTestBrowser should have a UI Setting to disable plugins
1340         https://bugs.webkit.org/show_bug.cgi?id=52408
1341         
1342         Added a new action item named "Disable Plugins"
1343         under the "Settings" menu. 
1344
1345         * QtTestBrowser/launcherwindow.cpp:
1346         (LauncherWindow::createChrome):
1347         (LauncherWindow::togglePlugins):
1348         * QtTestBrowser/launcherwindow.h:
1349
1350 2011-01-25  Patrick Gansterer  <paroga@webkit.org>
1351
1352         Reviewed by Adam Barth.
1353
1354         Move main CMakeLists.txt into Source directory
1355         https://bugs.webkit.org/show_bug.cgi?id=52888
1356
1357         * Scripts/webkitdirs.pm:
1358
1359 2011-01-25  Patrick Gansterer  <paroga@webkit.org>
1360
1361         Reviewed by Eric Seidel.
1362
1363         Improve label text in submit-to-ews
1364         https://bugs.webkit.org/show_bug.cgi?id=53130
1365
1366         * QueueStatusServer/templates/submittoews.html:
1367
1368 2011-01-25  Mansi Mithal  <mansi.mithal@nokia.com>
1369
1370         Reviewed by Antonio Gomes.
1371
1372         QtTestBrowser should have a UI Settings to prevent loading images
1373         https://bugs.webkit.org/show_bug.cgi?id=52409
1374         
1375         Added a new action item named "DisableAutoLoadImages"
1376         under the "Settings" menu 
1377
1378         * QtTestBrowser/launcherwindow.cpp:
1379         (LauncherWindow::createChrome):
1380         (LauncherWindow::toggleAutoLoadImages):
1381         * QtTestBrowser/launcherwindow.h:
1382
1383 2011-01-25  Dirk Pranke  <dpranke@chromium.org>
1384
1385         Reviewed by Tony Chang.
1386
1387         Minor bug fixes and cleanup for filesystem wrappers, port/* test
1388         classes, test_expectations.py. This change adds "test-win" and
1389         "test-mac" variants to the test port so that we can better test
1390         rebaselining, and adds a MockUser() object for reuse in testing.
1391
1392         https://bugs.webkit.org/show_bug.cgi?id=53036
1393
1394         * Scripts/webkitpy/common/system/filesystem.py:
1395         * Scripts/webkitpy/common/system/filesystem_mock.py:
1396         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1397         * Scripts/webkitpy/layout_tests/port/factory.py:
1398         * Scripts/webkitpy/layout_tests/port/base.py:
1399         * Scripts/webkitpy/layout_tests/port/test.py:
1400         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1401         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
1402         * Scripts/webkitpy/tool/mocktool.py:
1403
1404 2011-01-25  Tony Chang  <tony@chromium.org>
1405
1406         Reviewed by Dimitri Glazkov.
1407
1408         [chromium] remove unused layoutTestController callback
1409         https://bugs.webkit.org/show_bug.cgi?id=53103
1410
1411         This method is used by a test_shell_test, but not needed by DRT.
1412
1413         * DumpRenderTree/chromium/LayoutTestController.cpp:
1414         (LayoutTestController::LayoutTestController):
1415         * DumpRenderTree/chromium/LayoutTestController.h:
1416
1417 2011-01-25  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1418
1419         Reviewed by Andreas Kling.
1420
1421         [GTK] Remove 64 bits release bot from the buildbot master
1422         https://bugs.webkit.org/show_bug.cgi?id=52899
1423
1424         Removes the 64 bits release slave from the buildbot configuration,
1425         so that we can use it as an EWS.
1426
1427         * BuildSlaveSupport/build.webkit.org-config/config.json:
1428
1429 2011-01-24  Maciej Stachowiak  <mjs@apple.com>
1430
1431         Reviewed by Dan Bernstein.
1432
1433         Implement database quota callback to fix storage tests on WebKit2 bot
1434         https://bugs.webkit.org/show_bug.cgi?id=53064
1435
1436         * WebKitTestRunner/TestController.cpp:
1437         (WTR::exceededDatabaseQuota):
1438         (WTR::TestController::createOtherPage):
1439         (WTR::TestController::initialize):
1440
1441 2011-01-24  Maciej Stachowiak  <mjs@apple.com>
1442
1443         Reviewed by Anders Carlsson.
1444
1445         Use designated temp directory for the database for WebKit2
1446         https://bugs.webkit.org/show_bug.cgi?id=53052
1447         
1448         Adopt the new WK2 API for this.
1449
1450         * WebKitTestRunner/TestController.cpp:
1451         (WTR::TestController::libraryPathForTesting):
1452         (WTR::TestController::initialize):
1453         * WebKitTestRunner/TestController.h:
1454         * WebKitTestRunner/mac/TestControllerMac.mm:
1455         (WTR::TestController::platformLibraryPathForTesting):
1456         * WebKitTestRunner/qt/TestControllerQt.cpp:
1457         (WTR::TestController::platformLibraryPathForTesting):
1458         * WebKitTestRunner/win/TestControllerWin.cpp:
1459         (WTR::TestController::platformLibraryPathForTesting):
1460
1461 2011-01-24  Lucas Forschler  <lforschler@apple.com>
1462
1463         Reviewed by Stephanie Lewis.
1464
1465         Add a new Leopard test bot.
1466
1467         * BuildSlaveSupport/build.webkit.org-config/config.json:
1468
1469 2011-01-24  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1470
1471         Reviewed by Adam Barth.
1472
1473         Add EFL Builder to core waterfall
1474         https://bugs.webkit.org/show_bug.cgi?id=52704
1475
1476         Add EFL Builder to the core waterfall again.
1477
1478         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1479         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1480
1481 2011-01-24  Xianzhu Wang  <wangxianzhu@google.com>
1482
1483         Reviewed by Tony Chang.
1484
1485         new-run-webkit-tests fails to start HTTP server if there are proxy settings
1486         https://bugs.webkit.org/show_bug.cgi?id=52872
1487
1488         Force disabling proxy to resolve the problem.
1489
1490         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
1491         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
1492
1493 2011-01-24  Andreas Kling  <kling@webkit.org>
1494
1495         Reviewed by Darin Adler.
1496
1497         check-webkit-style: Update exemptions following Source/ move.
1498         https://bugs.webkit.org/show_bug.cgi?id=53017
1499
1500         * Scripts/webkitpy/style/checker.py:
1501         * Scripts/webkitpy/style/checker_unittest.py:
1502
1503 2011-01-24  Andras Becsi  <abecsi@webkit.org>
1504
1505         Rubber-stamped by Csaba Osztrogonác.
1506
1507         [Qt] Move project files into Source
1508         https://bugs.webkit.org/show_bug.cgi?id=52891
1509
1510         * DumpRenderTree/qt/ImageDiff.pro: Add missing "Source" to WebKit.pri path
1511
1512 2011-01-24  Mikhail Naganov  <mnaganov@chromium.org>
1513
1514         Reviewed by Yury Semikhatsky.
1515
1516         Web Inspector: Find duplicate strings in localizedStrings.js
1517
1518         https://bugs.webkit.org/show_bug.cgi?id=53005
1519
1520         * Scripts/check-inspector-strings:
1521
1522 2011-01-24  Zoltan Horvath  <zoltan@webkit.org>
1523
1524         Reviewed by Andreas Kling.
1525
1526         [Qt] Regroup MiniBrowser's menubar and add open file action
1527         https://bugs.webkit.org/show_bug.cgi?id=53000
1528
1529         Add File and Develop menu to MiniBrowser's menubar and add open file action to File menu.
1530
1531         * MiniBrowser/qt/BrowserWindow.cpp:
1532         (BrowserWindow::BrowserWindow):
1533         (BrowserWindow::openFile):
1534         (BrowserWindow::~BrowserWindow):
1535         * MiniBrowser/qt/BrowserWindow.h:
1536
1537 2011-01-24  Csaba Osztrogonác  <ossy@webkit.org>
1538
1539         Unreviewed fix after r76496
1540
1541         [Qt] Move project files into Source
1542         https://bugs.webkit.org/show_bug.cgi?id=52891
1543
1544         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Remove unnecessary "Source" from the path.
1545         * BuildSlaveSupport/built-product-archive: Remove unnecessary "Source" from the path.
1546         * Scripts/webkitdirs.pm: Add the accidentally removed slash to the path.
1547
1548 2011-01-24  Andras Becsi  <abecsi@webkit.org>
1549
1550         Reviewed by Csaba Osztrogonác.
1551
1552         [Qt] Move project files into Source
1553         https://bugs.webkit.org/show_bug.cgi?id=52891
1554
1555         * DerivedSources.pro: Renamed from DerivedSources.pro.
1556         * DumpRenderTree/qt/DumpRenderTree.pro:
1557         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1558         * MiniBrowser/DerivedSources.pro:
1559         * MiniBrowser/qt/MiniBrowser.pro:
1560         * QtTestBrowser/QtTestBrowser.pro:
1561         * Scripts/webkitdirs.pm:
1562         * Tools.pro: Added.
1563         * WebKitTestRunner/DerivedSources.pro:
1564         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1565         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1566
1567 2011-01-22  Geoffrey Garen  <ggaren@apple.com>
1568
1569         Reviewed by Dan Bernstein.
1570
1571         Beefed up --threaded mode to catch even more kinds of errors.
1572         https://bugs.webkit.org/show_bug.cgi?id=52971
1573
1574         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Use a shared
1575         context group to force JSC to mark multiple threads. (This used to be
1576         the default, but it changed in SnowLeopard.)
1577         (runJavaScriptThread): Do more locking and unlocking, and more allocation,
1578         to give threading mistakes more chances to show themselves.
1579         (startJavaScriptThreads):
1580         (stopJavaScriptThreads):
1581
1582 2011-01-22  Robert Hogan  <robert@webkit.org>
1583
1584         Reviewed by Andreas Kling.
1585
1586         [Qt] Support layoutTestController.addURLToRedirect()
1587         https://bugs.webkit.org/show_bug.cgi?id=52956
1588
1589         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1590         (LayoutTestController::addURLToRedirect):
1591         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1592
1593 2011-01-22  Robert Hogan  <robert@webkit.org>
1594
1595         Reviewed by Kenneth Rohde Christiansen.
1596
1597         [Qt] REGRESSION (r72360): http/tests/security/aboutBlank/xss-DENIED-* tests fail
1598         https://bugs.webkit.org/show_bug.cgi?id=49802
1599
1600         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1601         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1602         (WebCore::DumpRenderTree::open):
1603
1604 2011-01-21  Adam Barth  <abarth@webkit.org>
1605
1606         Reviewed by Maciej Stachowiak.
1607
1608         Disable mac_unittest.py that fails on some of the Mac bots
1609         https://bugs.webkit.org/show_bug.cgi?id=52947
1610
1611         As noted in the comment, this test does not appear to be correct
1612         because the function this test is testing returns different results
1613         depending on which flavor of Mac the test is run on.  This patch
1614         disable the test.  Hopefully we can re-enable the test once we've
1615         probably insulated the test from its environment.
1616
1617         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1618
1619 2011-01-21  Dirk Pranke  <dpranke@chromium.org>
1620
1621         Reviewed by Mihai Parparita.
1622
1623         Fix bug introduced in r76322 that caused NRWT to not actually
1624         read the Skipped files properly.
1625
1626         https://bugs.webkit.org/show_bug.cgi?id=52771
1627
1628         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1629         * Scripts/webkitpy/layout_tests/port/webkit.py:
1630         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1631
1632 2011-01-21  Sam Weinig  <sam@webkit.org>
1633
1634         Reviewed by Geoffrey Sean Garen and Mark Rowe.
1635
1636         WebKitTestRunner needs the HOME environment variable to be set.
1637         <rdar://problem/8896573>
1638
1639         * Scripts/old-run-webkit-tests: Set the HOME environment variable if
1640         it exists.
1641
1642 2011-01-21  Dirk Pranke  <dpranke@chromium.org>
1643
1644         Reviewed by Eric Seidel.
1645
1646         Suppress a few remaining integration tests so that none of the
1647         layout_test unit tests ever read from the filesystem or launch
1648         subprocesses that aren't part of the unit tests.
1649
1650         Also fix a minor bug in the printing unit tests that was
1651         incorrectly relying on sys.argv.
1652
1653         https://bugs.webkit.org/show_bug.cgi?id=52863
1654
1655         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1656         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1657         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1658
1659 2011-01-21  Darin Adler  <darin@apple.com>
1660
1661        Fix Mac build.
1662
1663         * MiniBrowser/mac/BrowserWindowController.m:
1664         (-[BrowserWindowController awakeFromNib]): Pass 0 for runModal function.
1665
1666 2011-01-20  Darin Adler  <darin@apple.com>
1667
1668         Reviewed by Dan Bernstein.
1669
1670         WebKit2: Implement showModalDialog
1671         https://bugs.webkit.org/show_bug.cgi?id=52855
1672
1673         This fixes WebKitTestRunner to compile, but more work is probably
1674         needed to get it to pass the tests.
1675
1676         * WebKitTestRunner/TestController.cpp:
1677         (WTR::TestController::runModal): Added. Calls through to the
1678         platform-specific version of runModal.
1679         (WTR::TestController::createOtherPage): Changed to be a private
1680         static member function so it can refer to runModal, which is
1681         a private static member function.
1682         (WTR::TestController::initialize): Pass 0 for the runModal
1683         function since we don't need to run the main window modal.
1684         I suspect this is wrong and will need to change.
1685         * WebKitTestRunner/TestController.h: Added declarations for
1686         the functions added above.
1687         * WebKitTestRunner/mac/TestControllerMac.mm:
1688         (WTR::TestController::runModal): Added. Untested implementation.
1689         * WebKitTestRunner/qt/TestControllerQt.cpp:
1690         (WTR::TestController::runModal): Added.
1691         * WebKitTestRunner/win/TestControllerWin.cpp:
1692         (WTR::TestController::runModal): Added.
1693
1694 2011-01-21  Eric Seidel  <eric@webkit.org>
1695
1696         Reviewed by Adam Barth.
1697
1698         Split Host object off from WebKitPatch for easier re-use
1699         https://bugs.webkit.org/show_bug.cgi?id=52284
1700
1701         new-run-webkit-tests and other tools are eventually going to want one of these.
1702         Basically you need to inherit from this class if you want to pretend to be a
1703         self.tool object for Steps/Commands.
1704
1705         * Scripts/webkitpy/common/host.py: Added.
1706         * Scripts/webkitpy/tool/main.py:
1707
1708 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1709
1710         Reviewed by Adam Barth.
1711
1712         Disable the tests that start and stop the http server and web
1713         server, so that we don't have to worry about port collisions on
1714         the bots.
1715
1716         https://bugs.webkit.org/show_bug.cgi?id=52861
1717
1718         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1719
1720 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1721
1722         Reviewed by Eric Seidel.
1723
1724         nrwt: rewrite google_chrome_unittest to use mock filesystem.
1725         
1726         https://bugs.webkit.org/show_bug.cgi?id=52772
1727         
1728         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
1729
1730 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1731
1732         Reviewed by Eric Siedel.
1733
1734         nrwt: clean up almost all remaining port references, remove
1735         unnecessary import clauses. The only remaining references are
1736         in places where a mock filesystem makes no sense or can't be
1737         used, and in one routine in port/google_chrome_unittest that
1738         I'll rewrite in a separate patch.
1739
1740         https://bugs.webkit.org/show_bug.cgi?id=52771
1741
1742         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1743         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1744         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1745         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1746         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1747         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1748         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1749         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
1750         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
1751         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
1752         * Scripts/webkitpy/layout_tests/port/gtk.py:
1753         * Scripts/webkitpy/layout_tests/port/mac.py:
1754         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1755         * Scripts/webkitpy/layout_tests/port/qt.py:
1756         * Scripts/webkitpy/layout_tests/port/webkit.py:
1757         * Scripts/webkitpy/layout_tests/port/win.py:
1758         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
1759
1760 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1761
1762         Reviewed by Mihai Parparita.
1763
1764         remove fs refs from run_webkit_tests, rebaseline_chromium_webkit_tests
1765
1766         https://bugs.webkit.org/show_bug.cgi?id=52762
1767
1768         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1769         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1770
1771 2011-01-20  Tony Chang  <tony@chromium.org>
1772
1773         Reviewed by Ojan Vafai.
1774
1775         [chromium] fix the paths used for the rebaseline tool
1776         https://bugs.webkit.org/show_bug.cgi?id=52857
1777
1778         Some of the bots were renamed so the path to grab the results zip
1779         file has changed.
1780
1781         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1782
1783 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1784
1785         Reviewed by Tony Chang.
1786
1787         Fix bug introduced in r72688 / bug 52768 that broke the
1788         generation of the output filename links in the results.html
1789         output. Apparently none of the unit tests actually checked to
1790         make sure the generated links were correct :(
1791
1792         https://bugs.webkit.org/show_bug.cgi?id=52854
1793
1794         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1795         * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
1796
1797 2011-01-20  Alexey Proskuryakov  <ap@apple.com>
1798
1799         Reviewed by Darin Adler.
1800
1801         https://bugs.webkit.org/show_bug.cgi?id=52849
1802         Make window.print work with WebKit2
1803
1804         * MiniBrowser/mac/BrowserWindowController.m:
1805         (-[BrowserWindowController awakeFromNib]):
1806         * WebKitTestRunner/TestController.cpp:
1807         (WTR::createOtherPage):
1808         (WTR::TestController::initialize):
1809         Added zeroes to WKPageUIClient structures to avoid build failures.
1810
1811 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1812
1813         Reviewed by Eric Seidel.
1814
1815         nrwt: remove fs refs from printing, test_failures, test_expectations, text_diff
1816
1817         https://bugs.webkit.org/show_bug.cgi?id=52756
1818
1819         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1820         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1821         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1822         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
1823         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1824         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
1825
1826 2011-01-20  Mansi Mithal  <mansi.mithal@nokia.com>
1827
1828         Reviewed by Antonio Gomes.
1829
1830         QtTestBrowser should have a seperate menu for Settings
1831         https://bugs.webkit.org/show_bug.cgi?id=52817
1832         
1833         Added a new menu item named "Settings"
1834         and moved the "Enable interrupting js scripts" and "Enable js pop up windows" under the "Settings" menu 
1835
1836         * QtTestBrowser/launcherwindow.cpp:
1837         (LauncherWindow::createChrome):
1838
1839 2011-01-20  Sam Weinig  <sam@webkit.org>
1840
1841         Reviewed by John Sullivan.
1842
1843         Update update-webkit-localizable-strings with new path to WebKit.
1844
1845         * Scripts/update-webkit-localizable-strings:
1846
1847 2011-01-20  James Robinson  <jamesr@chromium.org>
1848
1849         Reviewed by Darin Fisher.
1850
1851         Implement mozilla's requestAnimationFrame API
1852         https://bugs.webkit.org/show_bug.cgi?id=51218
1853
1854         Chromium DumpRenderTree support for window.webkitRequestAnimationFrame.
1855
1856         * DumpRenderTree/chromium/WebViewHost.cpp:
1857         (invokeScheduleComposite):
1858         (WebViewHost::scheduleAnimation):
1859         (WebViewHost::paintInvalidatedRegion):
1860         * DumpRenderTree/chromium/WebViewHost.h:
1861
1862 2011-01-20  Maciej Stachowiak  <mjs@apple.com>
1863
1864         Reviewed by Adam Roben.
1865
1866         WebKitTestRunner needs to support layoutTestController.evaluateScriptInIsolatedWorld
1867         https://bugs.webkit.org/show_bug.cgi?id=42327
1868
1869         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm: Add support
1870         for methods that take their normal arguments but also a JSContextRef.
1871         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: IDL definition
1872         for evaluateScriptInIsolatedWorld.
1873         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1874         (WTR::InjectedBundlePage::didClearWindowForFrame): Set a magic variable only if
1875         this call is for an isolated world.
1876         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1877         (WTR::worldMap): Helper to create a world map.
1878         (WTR::LayoutTestController::worldIDForWorld): Map from an ID to a world.
1879         (WTR::LayoutTestController::evaluateScriptInIsolatedWorld): The newly
1880         added LayoutTestController API.
1881         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1882
1883 2011-01-19  Adam Roben  <aroben@apple.com>
1884
1885         Convert paths in environment variables back to msys-style inside commit-log-editor
1886
1887         When this script gets run from inside git commit, msys-style paths in the environment will
1888         have been turned into Windows-style paths with forward slashes. This screws up functions
1889         like File::Spec->rel2abs, which seem to rely on $PWD having an msys-style path. We convert
1890         the paths back to msys-style before doing anything else.
1891
1892         Fixes <http://webkit.org/b/48527> commit-log-editor uses full paths for section headers when
1893         using msysgit's Perl and multiple ChangeLogs have been edited
1894
1895         Reviewed by David Kilzer.
1896
1897         * Scripts/commit-log-editor: Call fixEnvironment before doing anything else.
1898         (fixEnvironment): Added. When run in msys in conjunction with git (i.e., when invoked from
1899         inside git commit), convert Windows-style paths in the environment back to msys-style paths.
1900
1901 2011-01-20  Zoltan Horvath  <zoltan@webkit.org>
1902
1903         [Win] Unreviewed build fix after r76248.
1904
1905         * DumpRenderTree/ForwardingHeaders/wtf/FastAllocBase.h: Added.
1906
1907 2011-01-20  Zoltan Horvath  <zoltan@webkit.org>
1908
1909         Reviewed by Csaba Osztrogonác.
1910
1911         Refactoring of the custom allocation framework
1912         https://bugs.webkit.org/show_bug.cgi?id=49897
1913
1914         Inheriting from FastAllocBase can result in objects getting larger (bug #33896, #46589).
1915         The modification replaces Noncopyable and FastAllocBase classes and these inherits with their
1916         equivalent macro implementation at the necessary places.
1917 2011-01-20  Yi Shen  <yi.4.shen@nokia.com>
1918
1919         Unreviewed. 
1920
1921         Adding myself to committers.py.
1922
1923         * Scripts/webkitpy/common/config/committers.py:
1924
1925 2011-01-20  Adam Barth  <abarth@webkit.org>
1926
1927         Reviewed by Tony Chang.
1928
1929         Chromium builders don't delete unversioned directories when DEPS change
1930         https://bugs.webkit.org/show_bug.cgi?id=52745
1931
1932         If we pass this option to gclient sync, gclient will delete directories
1933         that are no longer part of DEPS instead of leaving them around to
1934         confuse us later.  Apparently, the downstream buildbots use this option
1935         already.
1936
1937         * Scripts/update-webkit-chromium:
1938
1939 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1940
1941         Unreviewed, build fix - I pulled this patch in to fix an issue
1942         revealed by r76195 running on some new bots). Also fix a couple
1943         of other issues revealed in testing.
1944
1945         nrwt: remove fs refs from layout_package/json*
1946
1947         https://bugs.webkit.org/show_bug.cgi?id=52754
1948
1949         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1950         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1951         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
1952         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1953         * Scripts/webkitpy/layout_tests/port/base.py:
1954
1955 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1956
1957         Unreviewed, build fix.
1958
1959         Fix a couple of minor bugs discovered while bringing up new bots
1960         for testing.
1961
1962         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1963         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1964
1965 2011-01-19  James Robinson  <jamesr@chromium.org>
1966
1967         Unreviewed, rolling out r76194.
1968         http://trac.webkit.org/changeset/76194
1969         https://bugs.webkit.org/show_bug.cgi?id=51218
1970
1971         Caused mysterious compile failure on the chromium win
1972         build.webkit.org bots
1973
1974         * DumpRenderTree/chromium/WebViewHost.cpp:
1975         (WebViewHost::paintInvalidatedRegion):
1976         * DumpRenderTree/chromium/WebViewHost.h:
1977
1978 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1979
1980         Reviewed by Mihai Parparita.
1981
1982         remove fs refs from test_runner, dump_render_tree_thread
1983
1984         https://bugs.webkit.org/show_bug.cgi?id=52753
1985
1986         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1987         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1988         * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
1989         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1990
1991 2011-01-19  James Robinson  <jamesr@chromium.org>
1992
1993         Reviewed by Darin Fisher.
1994
1995         Implement mozilla's requestAnimationFrame API
1996         https://bugs.webkit.org/show_bug.cgi?id=51218
1997
1998         Chromium DumpRenderTree support for window.webkitRequestAnimationFrame.
1999
2000         * DumpRenderTree/chromium/WebViewHost.cpp:
2001         (invokeScheduleComposite):
2002         (WebViewHost::scheduleAnimation):
2003         (WebViewHost::paintInvalidatedRegion):
2004         * DumpRenderTree/chromium/WebViewHost.h:
2005
2006 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2007
2008         Unreviewed, build fix.
2009
2010         Fix a few incorrect "self._filesystem" references introduced in
2011         r76184.
2012
2013         * Scripts/webkitpy/layout_tests/port/chromium.py:
2014         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2015
2016 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2017
2018         Reviewed by Mihai Parparita.
2019
2020         add a .sep property, abspath(), isabs(), mtime(), and
2021         open_text_file_for_writing() to filesystem modules. Some of
2022         these properties are not needed in this patch but will be needed
2023         in subsequent patches (I'm doing this to avoid having to track
2024         multiple versions of a single file).
2025
2026         Also, change most of the port/* modules to use the filesystem
2027         objects instead of referencing the filesystem directly.
2028
2029         https://bugs.webkit.org/show_bug.cgi?id=52748
2030
2031         * Scripts/webkitpy/common/system/filesystem.py:
2032         * Scripts/webkitpy/common/system/filesystem_mock.py:
2033         * Scripts/webkitpy/layout_tests/port/__init__.py:
2034         * Scripts/webkitpy/layout_tests/port/base.py:
2035         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2036         * Scripts/webkitpy/layout_tests/port/chromium.py:
2037         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2038         * Scripts/webkitpy/layout_tests/port/config.py:
2039         * Scripts/webkitpy/layout_tests/port/test.py:
2040         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
2041
2042 2011-01-19  Maciej Stachowiak  <mjs@apple.com>
2043
2044         Reviewed by Anders Carlsson.
2045
2046         If resetting between tests times out, treat it as a WebProcess crash
2047         https://bugs.webkit.org/show_bug.cgi?id=52757
2048
2049         * WebKitTestRunner/TestController.cpp:
2050         (WTR::TestController::runTest):
2051
2052 2011-01-19  Alexey Proskuryakov  <ap@apple.com>
2053
2054         Reviewed by Darin Adler.
2055
2056         https://bugs.webkit.org/show_bug.cgi?id=52739
2057         Make it possible for a WebKit2 client to print headers and footers
2058
2059         Added dummy implementations for new printing UIClient calls.
2060
2061         * MiniBrowser/mac/BrowserWindowController.m:
2062         (-[BrowserWindowController awakeFromNib]):
2063         * WebKitTestRunner/TestController.cpp:
2064         (WTR::createOtherPage):
2065         (WTR::TestController::initialize):
2066
2067 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2068
2069         Reviewed by Ojan Vafai.
2070
2071         Change webkitpy/layout_tests/port/test.py to use the
2072         in-memory filesystem for cleaner unit testing. This
2073         change allows us to kill a lot of code that was
2074         specific to the test port, at the cost of being a
2075         little less clear about how things would work if
2076         you didn't have a filesystem.
2077
2078         https://bugs.webkit.org/show_bug.cgi?id=52605
2079
2080         * Scripts/webkitpy/layout_tests/port/test.py:
2081
2082 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2083
2084         Unreviewed, build fix.
2085
2086         Fix test failure caused by committing attachment 79368 instead
2087         of attachment 79461 on bug 52604.
2088
2089         * Scripts/webkitpy/common/system/filesystem_mock.py:
2090
2091 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2092
2093         Reviewed by Mihai Parparita.
2094
2095         new-run-webkit-tests: remove use of os.walk, use mock filesystem for better
2096         unit testing. os.walk() is too much of a hassle to implement on
2097         top of the in-memory mock filesystem and adding the necessary
2098         interface to files_under() gives clients a cleaner API anyway
2099         (for this particular usage model).
2100
2101         https://bugs.webkit.org/show_bug.cgi?id=52691
2102
2103         * Scripts/webkitpy/common/system/filesystem.py:
2104         * Scripts/webkitpy/common/system/filesystem_mock.py:
2105         * Scripts/webkitpy/layout_tests/port/test_files.py:
2106         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
2107
2108 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2109
2110         Reviewed by Tony Chang.
2111
2112         Change more modules in the layout-tests code to use the
2113         filesystem wrapper for cleaner unit testing.
2114
2115         This patch also adds the glob() wrapper to the filesystem
2116         abstraction.
2117         
2118         https://bugs.webkit.org/show_bug.cgi?id=52604
2119
2120         * Scripts/webkitpy/layout_tests/port/test_files.py:
2121         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
2122         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
2123         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2124         * Scripts/webkitpy/common/system/filesystem.py:
2125         * Scripts/webkitpy/common/system/filesystem_mock.py:
2126
2127 2011-01-19  Levi Weintraub  <leviw@chromium.org>
2128
2129         Unreviewed.
2130
2131         Updating my email addresses and irc nick.
2132
2133         * Scripts/webkitpy/common/config/committers.py:
2134
2135 2011-01-19  Tony Chang  <tony@chromium.org>
2136
2137         Reviewed by Mihai Parparita.
2138
2139         [chromium] [linux] if check-sys-deps fails, output the failure reason
2140         https://bugs.webkit.org/show_bug.cgi?id=52671
2141
2142         * Scripts/webkitpy/common/system/executive_mock.py: Add support for
2143             error handler functions.
2144         * Scripts/webkitpy/layout_tests/port/chromium.py:
2145             output the error text from --check-sys-deps
2146         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2147
2148 2011-01-19  Aparna Nandyal  <aparna.nand@wipro.com>
2149
2150         Reviewed by Andreas Kling.
2151
2152         [Qt] QtTestBrowser crashes when closing if Facebook is opened
2153         https://bugs.webkit.org/show_bug.cgi?id=52554
2154         
2155         QtNetworkAccessManager is created in a thread and set as
2156         member variable in QWebPage. When the thread is destroyed
2157         the object is still used. So fix will set the object to
2158         NULL once the thread is destroyed.
2159
2160         * QtTestBrowser/launcherwindow.cpp:
2161         (LauncherWindow::~LauncherWindow):
2162
2163 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
2164
2165         Rubber stamped by Csaba Osztrogonac
2166
2167         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: Removed unncessary inculde of WKStringCF.h
2168
2169 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
2170
2171         Reviewed by Tony Chang.
2172
2173         new-run-webkit-tests: add a --build-directory command line argument
2174
2175         Official Google Chrome builds use a non-standard build directory
2176         location. This patch adds a --build-directory argument that
2177         allows that location to be specified on the command line. Only
2178         Chromium-based builds will use this flag for now, but anyone can
2179         in the future.
2180
2181         There are no unit tests for this since it's difficult to test
2182         until mock filesystems are fully supported in the code. This was
2183         tested by hand for now.
2184
2185         https://bugs.webkit.org/show_bug.cgi?id=52694
2186
2187         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2188         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2189         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2190         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2191
2192 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
2193
2194         Not reviewed. Bot fix.
2195
2196         Remove an inadvertently committed debugging print.
2197
2198         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2199         (LayoutTestController::notifyDone):
2200
2201 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
2202
2203         Reviewed by Sam Weinig.
2204
2205         WebKitTestRunner should track loading more like DumpRenderTree
2206         https://bugs.webkit.org/show_bug.cgi?id=52692
2207
2208         Change load tracking to track the current top loading frame, in the manner of DumpRenderTree.
2209         This makes some tests that call notifyDone multiple times pass.
2210         
2211         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2212         (WTR::InjectedBundle::InjectedBundle):
2213         (WTR::InjectedBundle::done):
2214         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2215         (WTR::InjectedBundle::topLoadingFrame):
2216         (WTR::InjectedBundle::setTopLoadingFrame):
2217         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2218         (WTR::InjectedBundlePage::InjectedBundlePage):
2219         (WTR::InjectedBundlePage::stopLoading):
2220         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
2221         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
2222         (WTR::InjectedBundlePage::didFinishLoadForFrame):
2223         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
2224         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2225         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2226         (WTR::LayoutTestController::notifyDone):
2227         * WebKitTestRunner/TestController.cpp:
2228         (WTR::TestController::didReceiveMessageFromInjectedBundle):
2229
2230 2011-01-18  Mihai Parparita  <mihaip@chromium.org>
2231
2232         Reviewed by Kent Tamura.
2233
2234         [Chromium] NRWT looking for DRT binary in the wrong path on Mac
2235         https://bugs.webkit.org/show_bug.cgi?id=52678
2236         
2237         Update path now that WebKit is inside Source.
2238
2239         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2240
2241 2011-01-18  Robert Hogan  <robert@webkit.org>
2242
2243         Reviewed by Simon Hausmann.
2244
2245         [Qt] http/tests/incremental/slow-utf8-text.pl fails
2246         https://bugs.webkit.org/show_bug.cgi?id=44282
2247
2248         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2249         (WebCore::DumpRenderTree::dump):
2250
2251 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
2252
2253         Reviewed by Mihai Parparita.
2254
2255         Fix a small race condition that could cause the unit tests for
2256         new-run-webkit-tests to fail in a multithreaded environment.
2257         There was a small window in the code where one thread would
2258         check to see if a thread had raised an exception, do something,
2259         and then check to see if the thread was alive. If the other
2260         thread raised an exception and exited in between these two
2261         steps, the exception would be lost. Flipping the order of the
2262         two checks fixes the race, since we will now always check for an
2263         exception on the thread before exiting.
2264
2265         https://bugs.webkit.org/show_bug.cgi?id=51579
2266
2267         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
2268
2269 2011-01-18  Eric Seidel  <eric@webkit.org>
2270
2271         Reviewed by Adam Barth.
2272
2273         commit-queue dies when test archiving fails
2274         https://bugs.webkit.org/show_bug.cgi?id=52617
2275
2276         I looked at the machine and it had 10 archives already
2277         thus find_unused_name was returning None.  I've upped
2278         the limit to 100 (per bug) and tested the case where
2279         find_unused_name returns None (making archive return None).
2280
2281         * Scripts/webkitpy/common/system/workspace.py:
2282         * Scripts/webkitpy/common/system/workspace_unittest.py:
2283         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2284         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2285         * Scripts/webkitpy/tool/commands/queues.py:
2286
2287 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
2288
2289         Reviewed by Ojan Vafai.
2290
2291         Update rebaseline-chromium-webkit-tests unit tests to use a mock
2292         filesystem. Also fix a couple of "with" statements missed by
2293         r76050.
2294
2295         https://bugs.webkit.org/show_bug.cgi?id=52487
2296
2297         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
2298
2299 2011-01-18  Sergio Villar Senin  <svillar@igalia.com>
2300
2301         Reviewed by Martin Robinson.
2302
2303         [Gtk] Build fixes for gtk3 build
2304         https://bugs.webkit.org/show_bug.cgi?id=52648
2305
2306         * DumpRenderTree/gtk/EventSender.cpp:
2307         (beginDragWithFilesCallback):
2308
2309 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
2310
2311         Reviewed by Mihai Parparita.
2312
2313         Update rebaseline-chromium-webkit-tests to use filesystem objects
2314         instead of direct references to os.path, shutil, tempfile, etc.
2315
2316         This patch doesn't change anything, but will allow subsequent
2317         patches to change the unit tests to no longer use the real
2318         filesystem.
2319
2320         This patch adds a bunch more methods to the filesystem object as
2321         well.
2322
2323         https://bugs.webkit.org/show_bug.cgi?id=52482
2324
2325         * Scripts/webkitpy/common/system/filesystem.py:
2326         * Scripts/webkitpy/common/system/filesystem_mock.py:
2327         * Scripts/webkitpy/tool/commands/queues.py:
2328         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2329         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
2330
2331 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
2332
2333         Reviewed by Mihai Parparita.
2334
2335         new-run-webkit-tests shouldn't crash when you try to run a
2336         directory containing only skipped files.
2337
2338         https://bugs.webkit.org/show_bug.cgi?id=52478
2339         
2340         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2341         * Scripts/webkitpy/layout_tests/port/test.py:
2342         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2343
2344 2011-01-18  Adam Bergkvist  <adam.bergkvist@ericsson.com> and Martin Robinson  <mrobinson@igalia.com>
2345
2346         Reviewed by Gustavo Noronha Silva.
2347
2348         [GTK] The GTK+ EventSender needs support for beginDragWithFiles
2349         https://bugs.webkit.org/show_bug.cgi?id=40833
2350
2351         * DumpRenderTree/gtk/EventSender.cpp: Add a beginDragWithFiles implementation for the
2352         GTK+ event sender.
2353         (dragWithFilesDragDataGetCallback): Added.
2354         (dragWithFilesDragEndCallback): Added.
2355         (beginDragWithFilesCallback): Added.
2356
2357 2011-01-18  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2358
2359         Reviewed by Adam Barth.
2360
2361         ews: Add additional watcher to efl ews
2362         https://bugs.webkit.org/show_bug.cgi?id=52613
2363
2364         Add gyuyoung.kim@samsung.com to watcher list of efl-ews.
2365
2366         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2367
2368 2011-01-17  Tony Gentilcore  <tonyg@chromium.org>
2369
2370         Reviewed by Alexey Proskuryakov.
2371
2372         Fix some headers with missing or misspelled #ifndef guards
2373         https://bugs.webkit.org/show_bug.cgi?id=52545
2374
2375         * DumpRenderTree/chromium/TestEventPrinter.h:
2376         * DumpRenderTree/chromium/WebPreferences.h:
2377
2378 2011-01-17  Jessie Berlin  <jberlin@apple.com>
2379
2380         Reviewed by Anders Carlsson.
2381
2382         REGRESSION: Assertion failure in FrameLoader::continueLoadAfterWillSubmitForm() when
2383         navigating back to an unreachable URL
2384         https://bugs.webkit.org/show_bug.cgi?id=52388
2385
2386         Add a third parameter (unreachableURL) to queueLoadHTMLString.
2387
2388         * DumpRenderTree/LayoutTestController.cpp:
2389         (queueLoadHTMLStringCallback):
2390         (LayoutTestController::queueLoadHTMLString):
2391         (LayoutTestController::queueLoadAlternateHTMLString):
2392         * DumpRenderTree/LayoutTestController.h:
2393
2394         * DumpRenderTree/WorkQueueItem.h:
2395         (LoadHTMLStringItem::LoadHTMLStringItem):
2396
2397         * DumpRenderTree/chromium/LayoutTestController.cpp:
2398         (WorkItemLoadHTMLString::WorkItemLoadHTMLString):
2399         (WorkItemLoadHTMLString::run):
2400         (LayoutTestController::queueLoadHTMLString):
2401
2402         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
2403         (LoadHTMLStringItem::invoke):
2404         * DumpRenderTree/mac/WorkQueueItemMac.mm:
2405         (LoadHTMLStringItem::invoke):
2406         * DumpRenderTree/win/WorkQueueItemWin.cpp:
2407         (LoadHTMLStringItem::invoke):
2408
2409 2011-01-17  Dan Bernstein  <mitz@apple.com>
2410
2411         Rubber-stamped by Mark Rowe.
2412
2413         Update xcodeproj svn:ignore to include xcuserdata.
2414
2415         * DumpRenderTree/DumpRenderTree.xcodeproj: Modified property svn:ignore.
2416         * MiniBrowser/MiniBrowser.xcodeproj: Modified property svn:ignore.
2417         * TestWebKitAPI/TestWebKitAPI.xcodeproj: Modified property svn:ignore.
2418         * WebKitLauncher/WebKitLauncher.xcodeproj: Modified property svn:ignore.
2419         * WebKitTestRunner/WebKitTestRunner.xcodeproj: Modified property svn:ignore.
2420
2421 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
2422
2423         Unreviewed fix after r75908.
2424
2425         Move WebKit into Source
2426         https://bugs.webkit.org/show_bug.cgi?id=52530
2427
2428         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add Source to the path for Qt API tests.
2429
2430 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
2431
2432         Unreviewed.
2433
2434         Remove accidentally committed debug printing after r75908.
2435
2436         * Scripts/webkitdirs.pm:
2437
2438 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
2439
2440         Unreviewed.
2441
2442         Add myself to committers list
2443         https://bugs.webkit.org/show_bug.cgi?id=52566
2444
2445         * Scripts/webkitpy/common/config/committers.py:
2446
2447 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
2448
2449         Reviewed by Jeremy Orlow.
2450
2451         GeolocationController should call stopUpdating on destruction
2452         https://bugs.webkit.org/show_bug.cgi?id=52216
2453
2454         fast/dom/Geolocation/window-close-crash.html requires that a
2455         Geolocation watch be started in a secondary window. Consequently,
2456         we need to allow geolocation permission and provide a mock
2457         geolocation position for the secondary window's
2458         GeolocationClientMock.
2459
2460         * DumpRenderTree/chromium/LayoutTestController.cpp:
2461         (LayoutTestController::setGeolocationPermission):
2462         (LayoutTestController::setMockGeolocationPosition):
2463         (LayoutTestController::setMockGeolocationError):
2464         * DumpRenderTree/chromium/TestShell.h:
2465         (TestShell::windowList):
2466
2467 2011-01-16  Adam Barth  <abarth@webkit.org>
2468
2469         Update more include paths to reflect WebKit move.
2470
2471         * DumpRenderTree/chromium/EventSender.cpp:
2472         (EventSender::keyDown):
2473         (EventSender::needsShiftModifier):
2474         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
2475         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
2476
2477 2011-01-16  Kent Tamura  <tkent@chromium.org>
2478
2479         Unreviewed, Chromium build fix.
2480
2481         * Scripts/update-webkit-chromium: Webkit/chromium -> Source/WebKit/chromium
2482
2483 2011-01-16  Martin Robinson  <mrobinson@igalia.com>
2484
2485         Build fix for GTK+ after source directory movement.
2486
2487         * GNUmakefile.am: Correct include paths.
2488
2489 2011-01-16  Adam Barth  <abarth@webkit.org>
2490
2491         Teach svn-apply about WebKit move.
2492
2493         * Scripts/VCSUtils.pm:
2494
2495 2011-01-16  Adam Barth  <abarth@webkit.org>
2496
2497         Rubber-stamped by Eric Seidel.
2498
2499         Move WebKit into Source
2500         https://bugs.webkit.org/show_bug.cgi?id=52530
2501
2502         * DumpRenderTree/mac/InternalHeaders/WebKit/WebTypesInternal.h:
2503         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2504         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2505         * DumpRenderTree/qt/GCControllerQt.cpp:
2506         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2507         * DumpRenderTree/qt/PlainTextControllerQt.cpp:
2508         * DumpRenderTree/qt/TextInputControllerQt.cpp:
2509         * DumpRenderTree/wscript:
2510         * QtTestBrowser/launcherwindow.h:
2511         * Scripts/build-webkit:
2512         * Scripts/webkitdirs.pm:
2513
2514 2011-01-15  Adam Barth  <abarth@webkit.org>
2515
2516         Teach svn-apply about WebKit2 move.
2517
2518         * Scripts/VCSUtils.pm:
2519
2520 2011-01-15  Adam Barth  <abarth@webkit.org>
2521
2522         Rubber-stamped by Eric Seidel.
2523
2524         Move WebKit2 into Source
2525         https://bugs.webkit.org/show_bug.cgi?id=52438
2526
2527         * MiniBrowser/qt/MiniBrowser.pro:
2528         * Scripts/build-webkit:
2529         * Scripts/do-file-rename:
2530         * Scripts/do-webcore-rename:
2531         * Scripts/test-webkitpy:
2532         * Scripts/webkitdirs.pm:
2533         * Scripts/webkitpy/style/checker.py:
2534         * WebKitTestRunner/DerivedSources.pro:
2535         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2536         * WebKitTestRunner/qt/WebKitTestRunner.pro:
2537
2538 2011-01-15  Jochen Eisinger  <jochen@chromium.org>
2539
2540         Reviewed by David Levin.
2541
2542         [chromium] remove obsolete createView method
2543         https://bugs.webkit.org/show_bug.cgi?id=52437
2544
2545         * DumpRenderTree/chromium/WebViewHost.cpp:
2546         (WebViewHost::createView):
2547         * DumpRenderTree/chromium/WebViewHost.h:
2548
2549 2011-01-14  Brian Weinstein  <bweinstein@apple.com>
2550
2551         Reviewed by Geoff Garen.
2552
2553         ShouldLoadResourceForFrame should use strings, not URLs.
2554         https://bugs.webkit.org/show_bug.cgi?id=52476
2555
2556         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2557         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Update to use a WKStringRef.
2558         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2559
2560 2011-01-14  Tony Gentilcore  <tonyg@chromium.org>
2561
2562         Reviewed by David Levin.
2563
2564         Add Tony Gentilcore as a reviewer
2565         https://bugs.webkit.org/show_bug.cgi?id=52480
2566
2567         * Scripts/webkitpy/common/config/committers.py:
2568
2569 2011-01-14  David Levin  <levin@chromium.org>
2570
2571         Reviewed by Eric Seidel.
2572
2573         check-webkit-style: _FunctionState should keep track of where the function name starts.
2574         https://bugs.webkit.org/show_bug.cgi?id=52454
2575
2576         * Scripts/webkitpy/style/checkers/cpp.py: Added function_name_start_position to
2577         _FunctionState and logic for setting it correctly.
2578         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests.
2579
2580 2011-01-14  Vincent Scheib  <scheib@chromium.org>
2581
2582         Reviewed by David Levin.
2583
2584         Add support to DumpRenderTree to use the GPU rather than software renderer
2585         https://bugs.webkit.org/show_bug.cgi?id=52333
2586
2587         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2588         (main):
2589         * Scripts/webkitpy/layout_tests/port/chromium.py:
2590         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2591
2592 2011-01-14  Tony Chang  <tony@chromium.org>
2593
2594         Reviewed by Kent Tamura.
2595
2596         [chromium] update fonts.conf to fix 6 linux tests in drt
2597         https://bugs.webkit.org/show_bug.cgi?id=52411
2598
2599         * DumpRenderTree/chromium/fonts.conf: Update to match the copy in
2600             chromium's src/webkit/tools/test_shell/resources/fonts.conf
2601
2602 2011-01-14  Eric Seidel  <eric@webkit.org>
2603
2604         Original patch from Peter Gal  <galpater@inf.u-szeged.hu>
2605
2606         Reviewed by Adam Barth.
2607
2608         Fix when running Tools/Scripts/check-webkit-style without arguments.
2609         https://bugs.webkit.org/show_bug.cgi?id=52261#c16
2610
2611         * Scripts/webkitpy/common/checkout/scm.py: Handle None for changed_files argument better in Git.create_patch method.
2612         * Scripts/webkitpy/common/checkout/scm_unittest.py:
2613
2614 2011-01-04  Jochen Eisinger  <jochen@chromium.org>
2615
2616         Reviewed by David Levin.
2617
2618         Store the tempdir object in a variable so it doesn't get deleted too early.
2619         https://bugs.webkit.org/show_bug.cgi?id=51875
2620
2621         * Scripts/update-webkit-auxiliary-libs:
2622         * Scripts/update-webkit-support-libs:
2623
2624 2011-01-14  Eric Seidel  <eric@webkit.org>
2625
2626         Unreviewed.  Make it work in python 2.5.
2627
2628         webkit-patch suggest-reviewers dies when ChangeLogs are missing
2629         https://bugs.webkit.org/show_bug.cgi?id=49158
2630
2631         * Scripts/webkitpy/common/checkout/api_unittest.py:
2632
2633 2011-01-14  Sheriff Bot  <webkit.review.bot@gmail.com>
2634
2635         Unreviewed, rolling out r75774.
2636         http://trac.webkit.org/changeset/75774
2637         https://bugs.webkit.org/show_bug.cgi?id=52431
2638
2639         gtk builds were broken (Requested by loislo2 on #webkit).
2640
2641         * Scripts/webkitpy/common/checkout/scm.py:
2642
2643 2011-01-14  David Levin  <levin@chromium.org>
2644
2645         Reviewed by Shinichiro Hamaji.
2646
2647         check-webkit-style: _FunctionState should detect pure functions.
2648         https://bugs.webkit.org/show_bug.cgi?id=52428
2649
2650         * Scripts/webkitpy/style/checkers/cpp.py: Added detection for if a function declaration
2651         is a pure virtual function.
2652         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests for verifying that pure
2653         virtual functions are correctly detected.
2654
2655 2011-01-13  Ilya Tikhonovsky  <loislo@chromium.org>
2656
2657         Reviewed by Yury Semikhatsky.
2658
2659         Just small fix for problem with check-webkit-style.
2660         It just didn't work for this patch.
2661         Old code can't concatenate a list of strings with None.
2662
2663         * Scripts/webkitpy/common/checkout/scm.py:
2664
2665 2011-01-13  David Levin  <levin@chromium.org>
2666
2667         Reviewed by Shinichiro Hamaji.
2668
2669         check-webkit-style: _FunctionState should use Position to know where items are.
2670         https://bugs.webkit.org/show_bug.cgi?id=52424
2671
2672         * Scripts/webkitpy/style/checkers/cpp.py:
2673         (_FunctionState.*): Changed _FunctionState to use Position instead of line numbers.
2674         (detect_functions): Changed to pass Position's to _FunctionState.begin and
2675         did some minor clean-up.
2676         (*): Other changes are simply about converting to use the Position's in_FunctionState
2677         instead of line numbers.
2678         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Changed the test code
2679         to verify the positions stored in _FunctionState.
2680
2681 2011-01-13  Eric Seidel  <eric@webkit.org>
2682
2683         Reviewed by David Levin.
2684
2685         webkit-patch suggest-reviewers dies when ChangeLogs are missing
2686         https://bugs.webkit.org/show_bug.cgi?id=49158
2687
2688         This is not the most elegant, but it is a very safe fix to this bug.
2689         One advantage of catching ScriptError like this instead of adding a
2690         new added_or_modified_files or fixing all changed_files callers
2691         to use a more specific change_files variant, is that we catch
2692         all kinds of ScriptErrors which might cause our (non-essential)
2693         suggest-reviewers code to fail out.  This should make passing
2694         --suggest-reviewers to webkit-patch upload much more robust
2695         and may even make it possible for us to make it default.
2696
2697         The root of the problem here is that SCM.changed_files includes
2698         deleted ChangeLog paths (from moves, etc) which then when we ask
2699         SVN/Git for the contents of the file at that revision, the command
2700         errors out and Executive.run_command raises a ScriptError.
2701
2702         In the future we might fix this differently by making all current
2703         callers of chagned_files use a more specific method for requesting
2704         what types of changes they're interested in (adds, modifies, deletes, etc.)
2705
2706         * Scripts/webkitpy/common/checkout/api.py:
2707         * Scripts/webkitpy/common/checkout/api_unittest.py:
2708
2709 2011-01-13  Dan Bernstein  <mitz@apple.com>
2710
2711         Reviewed by Alexey Proskuryakov.
2712
2713         <rdar://problem/8827065> REGRESSION (r71884): Cross-origin XHR fails if willSendRequest changes the URL
2714         https://bugs.webkit.org/show_bug.cgi?id=52419
2715
2716         Allow to further control the behavior of the willSendRequest delegate callback by making it
2717         set a different URL in the new request.
2718
2719         * DumpRenderTree/LayoutTestController.cpp:
2720         (addURLToRedirectCallback): Added.
2721         (LayoutTestController::staticFunctions): Added addURLToRedirect.
2722         (LayoutTestController::addURLToRedirect): Added. Adds the redirection to the map.
2723         (LayoutTestController::redirectionDestinationForURL): Added this getter.
2724         * DumpRenderTree/LayoutTestController.h:
2725         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2726         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]): Check
2727         if there is a redirection for the request’s URL, established by addURLToRedirect(), and if so,
2728         change the URL in the new request to the redirect destination.
2729
2730 2011-01-13  Eric Seidel  <eric@webkit.org>
2731
2732         Reviewed by Mihai Parparita.
2733
2734         webkit-patch suggest-reviewers fails due to invalid utf8 in ChangeLog files
2735         https://bugs.webkit.org/show_bug.cgi?id=52416
2736
2737         Example: webkit-patch suggest-reviewers -g ca3890fe74d94d85d6bfa48f9ea497b094d8e717 
2738         UnicodeDecodeError: 'utf8' codec can't decode bytes in position 536-538: invalid data
2739
2740         I also added FIXMEs about the changed_files returning deleted files problem
2741         which is causing the other most common exception for suggest-reviewers
2742         (and is probably breaking sheriff-bots blame detection).
2743
2744         * Scripts/webkitpy/common/checkout/api.py:
2745         * Scripts/webkitpy/common/checkout/api_unittest.py:
2746         * Scripts/webkitpy/common/checkout/scm.py:
2747
2748 2011-01-13  Eric Seidel  <eric@webkit.org>
2749
2750         Reviewed by Adam Barth.
2751
2752         results archives from commit-queue are too large to upload
2753         https://bugs.webkit.org/show_bug.cgi?id=52405
2754
2755         * Scripts/webkitpy/common/system/filesystem.py:
2756         * Scripts/webkitpy/common/system/filesystem_mock.py:
2757         * Scripts/webkitpy/tool/commands/queues.py:
2758
2759 2011-01-13  Alejandro G. Castro  <alex@igalia.com>
2760
2761         Reviewed by Martin Robinson.
2762
2763         [gtk] Zero-sized font does not yet work
2764         https://bugs.webkit.org/show_bug.cgi?id=49793
2765
2766         Set minimum-font-size to 0 for the DRT.
2767
2768         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2769         (resetDefaultsToConsistentValues):
2770
2771 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
2772
2773         Reviewed by Darin Adler.
2774
2775         Make old-run-webkit-tests more robust on buildbots
2776         https://bugs.webkit.org/show_bug.cgi?id=52364
2777
2778         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Pass --exit-after-n-failures 500 to old-run-webkit-tests script.
2779
2780 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
2781
2782         Reviewed by Darin Adler.
2783
2784         Make old-run-webkit-tests more robust on buildbots
2785         https://bugs.webkit.org/show_bug.cgi?id=52364
2786
2787         * Scripts/old-run-webkit-tests: Ensure that testResultsDirectory is empty.
2788
2789 2011-01-13  Tony Chang  <tony@chromium.org>
2790
2791         Reviewed by Kent Tamura.
2792
2793         [chromium] fix plugins/plugin-javascript-access.html on Linux and Mac
2794         https://bugs.webkit.org/show_bug.cgi?id=52332
2795
2796         Forked Info.plist is not longer needed.
2797
2798         * DumpRenderTree/chromium/TestNetscapePlugIn/Info.plist: Removed.
2799
2800 2011-01-13  Mikhail Naganov  <mnaganov@chromium.org>
2801
2802         Reviewed by Timothy Hatcher.
2803
2804         Web Inspector: Cleanup after r75613 -- make all UI-facing strings
2805         to be passed directly to WebInspector.UIString
2806
2807         https://bugs.webkit.org/show_bug.cgi?id=52365
2808
2809         * Scripts/check-inspector-strings:
2810
2811 2011-01-13  Sheriff Bot  <webkit.review.bot@gmail.com>
2812
2813         Unreviewed, rolling out r74881.
2814         http://trac.webkit.org/changeset/74881
2815         https://bugs.webkit.org/show_bug.cgi?id=52357
2816
2817         The EFL builder has been red for days (Requested by abarth on
2818         #webkit).
2819
2820         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2821         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2822
2823 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
2824
2825         Reviewed by David Levin.
2826
2827         Add beforeunload support to WebKitTestRunner
2828         https://bugs.webkit.org/show_bug.cgi?id=52353
2829         
2830         This makes a number of currently failing tests pass.
2831
2832         * WebKitTestRunner/TestController.cpp:
2833         (WTR::runBeforeUnloadConfirmPanel):
2834         (WTR::createOtherPage):
2835         (WTR::TestController::initialize):
2836
2837 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
2838
2839         Reviewed by Sam Weinig.
2840
2841         Detect, identify and recover from WebProcess crashes in run-webkit-tests
2842         https://bugs.webkit.org/show_bug.cgi?id=52330
2843
2844         * Scripts/old-run-webkit-tests: Detect when the regression test tool reports
2845         a web process crash.
2846         * WebKitTestRunner/TestController.cpp:
2847         (WTR::TestController::initialize): Set up a processDidCrash
2848         callback.
2849         (WTR::TestController::processDidCrash): Report that the Web process
2850         crashed.
2851         * WebKitTestRunner/TestController.h:
2852
2853 2011-01-12  David Levin  <levin@chromium.org>
2854
2855         Reviewed by Shinichiro Hamaji.
2856
2857         check-webkit-style -- close_expression function doesn't work correctly.
2858         https://bugs.webkit.org/show_bug.cgi?id=52272
2859
2860         * Scripts/webkitpy/style/checkers/cpp.py:
2861         (Position.__str__): Added a way to convert it to a string which is useful in tests.
2862         (Position.__cmp__): Added a way to compare Position which is useful in tests and
2863         generally useful (for upcoming code changes).
2864         (close_expression): Changed to use Position for input and output.
2865         Also, fixed many bugs such as only working correctly for parenthesis,
2866         not working correctly if given an offset in a line and not finding
2867         the real closing element if there were multiple closing elements in
2868         the same line.
2869         (detect_functions): Adjusted due to the change in arguments for
2870         close_expression.
2871         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2872         (CppStyleTestBase.assert_positions_equal): Added a way to verify that
2873         two positions are the same.
2874         (CppStyleTest.test_position): Added tests for the __str_ and __cmp__ methods.
2875         (CppStyleTest.test_close_expression): Added tests to catch the issues
2876         that were fixed.
2877
2878 2011-01-12  Sheriff Bot  <webkit.review.bot@gmail.com>
2879
2880         Unreviewed, rolling out r75576.
2881         http://trac.webkit.org/changeset/75576
2882         https://bugs.webkit.org/show_bug.cgi?id=52304
2883
2884         broke rebaseline-chromium-webkit-test (Requested by thakis on
2885         #webkit).
2886
2887         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2888         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2889         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
2890         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2891         * Scripts/webkitpy/layout_tests/port/base.py:
2892         * Scripts/webkitpy/layout_tests/port/chromium.py:
2893         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2894         * Scripts/webkitpy/layout_tests/port/test.py:
2895         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2896         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2897         * Scripts/webkitpy/style/checkers/test_expectations.py:
2898         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
2899
2900 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
2901
2902         Reviewed by Darin Adler.
2903
2904         Add a no-build option to run-webkit-tests, to avoid building DRT/WKTR
2905         https://bugs.webkit.org/show_bug.cgi?id=52307
2906
2907         * Scripts/old-run-webkit-tests:
2908
2909 2011-01-12  Koan-Sin Tan  <koansin.tan@gmail.com>
2910
2911         Reviewed by Martin Robinson.
2912
2913         [Gtk] WebKitGtk+ doesn't build on Mac OS X 10.6
2914         https://bugs.webkit.org/show_bug.cgi?id=50867
2915
2916         Fixed library extention for Mac in webkitdirs.pm and type conflict in
2917         TestNetscapePlugin.cpp 
2918
2919         * GNUmakefile.am: Don't use AppKit when compiling TestNetscapePlugin for GTK+
2920         * Scripts/webkitdirs.pm:
2921
2922 2011-01-12  Mikhail Naganov  <mnaganov@chromium.org>
2923
2924         Reviewed by Pavel Feldman.
2925
2926         Add check-inspector-strings script.
2927
2928         https://bugs.webkit.org/show_bug.cgi?id=52295
2929
2930         * Scripts/check-inspector-strings: Added.
2931
2932 2011-01-12  Adam Roben  <aroben@apple.com>
2933
2934         Advertise the .testnetscape file extension on Windows
2935
2936         Fixes <http://webkit.org/b/52298>
2937         plugins/no-mime-with-valid-extension.html fails on Windows
2938
2939         Reviewed by Dan Bernstein.
2940
2941         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Added a
2942         FileExtents field to map the .testnetscape file extension to the
2943         application/x-webkit-test-netscape MIME type, just as we do on Mac.
2944
2945 2011-01-12  Adam Barth  <abarth@webkit.org>
2946
2947         Reviewed by Eric Seidel.
2948
2949         Make webkit-patch support subdirectories for SVN checkouts
2950         https://bugs.webkit.org/show_bug.cgi?id=52261
2951
2952         os.relpath does not exist on Python 2.5, so we need to call our version
2953         of the API.
2954
2955         * Scripts/webkitpy/common/checkout/scm.py:
2956
2957 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
2958
2959         Reviewed by Eric Seidel.
2960
2961         Close additional pages opened during a test once the test completes.
2962         https://bugs.webkit.org/show_bug.cgi?id=52276
2963
2964         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2965         (WTR::InjectedBundle::done):
2966
2967 2011-01-11  David Levin  <levin@chromium.org>
2968
2969         Reviewed by Eric Seidel.
2970
2971         Errors should be separated from the command line in bot messages.
2972         https://bugs.webkit.org/show_bug.cgi?id=52275
2973
2974         * Scripts/webkitpy/common/system/executive.py:
2975         (ScriptError.message_with_output): Added a newline to separate the command
2976         line from the errors.
2977         * Scripts/webkitpy/common/system/executive_unittest.py:
2978         (ScriptErrorTest.test_message_with_output): Added tests for the various code
2979         paths in message_with_output.
2980
2981 2011-01-11  Eric Seidel  <eric@webkit.org>
2982
2983         Unreviewed.
2984
2985         commit-queue should know how to upload archived results (for test flakes or general failures)
2986         https://bugs.webkit.org/show_bug.cgi?id=52048
2987
2988         The zips are mostly empty due to forgetting -r.
2989         Expected diffs were not being pulled from the archive due
2990         to the archive having longer paths than I realized.
2991
2992         * Scripts/webkitpy/common/system/workspace.py:
2993         * Scripts/webkitpy/common/system/workspace_unittest.py:
2994         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2995         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2996
2997 2011-01-11  Dirk Pranke  <dpranke@chromium.org>
2998
2999         Reviewed by Ojan Vafai.
3000
3001         The current modifier parsing code in test_expectations is
3002         fragile and hard-coded, so it's not easy to understand the logic
3003         or easily add new types of modifiers (like GPU vs. CPU testing
3004         for graphics tests, or 32-bit vs. 64-bit differences).
3005
3006         This is the first of two patches that will add in more generic
3007         support and then eliminate the GPU-specific test expectations
3008         files for Chromium.
3009
3010         This patch adds two standalone objects for handling modifiers. The
3011         rules for interpreting modifiers, precedence, and conflicts are
3012         given in the docstring to the ModifierMatcher class, which
3013         returns ModifierMatchResult objects.
3014         
3015         This patch also adds routines to the Port interface and a
3016         default set of values in the base object, in order to obtain the
3017         values needed on a given test run. These values are then passed
3018         to the expectation parser. This also allows us to clean up the
3019         logic used to lint all of the different configurations in a
3020         single test_expectations.txt file.
3021
3022         The next patch will merge in the separate GPU expectations file.
3023
3024         https://bugs.webkit.org/show_bug.cgi?id=51222
3025
3026         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
3027         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
3028         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
3029         * Scripts/webkitpy/layout_tests/port/base.py:
3030         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3031         * Scripts/webkitpy/layout_tests/port/chromium.py:
3032         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3033         * Scripts/webkitpy/layout_tests/port/test.py:
3034         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3035         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3036
3037 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
3038
3039         Reviewed by Adam Barth.
3040
3041         Make webkit-patch support subdirectories for SVN checkouts
3042         https://bugs.webkit.org/show_bug.cgi?id=52261
3043
3044         * Scripts/webkitpy/common/checkout/scm.py:
3045         * Scripts/webkitpy/style_references.py:
3046         * Scripts/webkitpy/tool/main.py:
3047         * Scripts/webkitpy/tool/steps/preparechangelog.py:
3048
3049 2011-01-11  Eric Seidel  <eric@webkit.org>
3050
3051         Unreviewed.
3052
3053         commit-queue should know how to upload archived results (for test flakes or general failures)
3054         https://bugs.webkit.org/show_bug.cgi?id=52048
3055
3056         I changed the API for archive_last_layout_test_results w/o updating the implementation.  Oops.
3057         This fixes an exception seen on the commit-queue when attempting to report flaky tests.
3058
3059         * Scripts/webkitpy/common/system/workspace.py:
3060         * Scripts/webkitpy/common/system/workspace_unittest.py:
3061         * Scripts/webkitpy/tool/commands/queues.py:
3062
3063 2011-01-11  Sam Weinig  <sam@webkit.org>
3064
3065         Roll r75474 back in.
3066
3067 2011-01-11  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
3068
3069         Reviewed by Kenneth Rohde Christiansen.
3070
3071         [Qt] Remove uses of QFuture since it isn't supported on all platforms.
3072         https://bugs.webkit.org/show_bug.cgi?id=51204
3073
3074         * QtTestBrowser/webpage.h:
3075         (QtNAMThread::QtNAMThread):
3076         (QtNAMThread::networkAccessManager):
3077         (QtNAMThread::run):
3078
3079 2011-01-11  Peter Varga  <pvarga@webkit.org>
3080
3081         Unreviewed.
3082
3083         Add myself to committers' list.
3084
3085         * Scripts/webkitpy/common/config/committers.py:
3086
3087 2011-01-11  Eric Seidel  <eric@webkit.org>
3088
3089         Reviewed by Adam Barth.
3090
3091         commit-queue should know how to upload archived results (for test flakes or general failures)
3092         https://bugs.webkit.org/show_bug.cgi?id=52048
3093
3094         Now the queue will always upload results.  Either the entire zip, or just
3095         the diffs.txt in the case of text failures.
3096
3097         This should make understanding flakes much easier, and paves the way
3098         for having the EWS run layout tests (and upload failures).
3099
3100         In order to upload .zip files I had to teach bugzilla.py to autodetect
3101         mime types from the filename.  Since mimetypes.py doesn't include a mapping
3102         for .patch files, I have it add one before calling guess_type.
3103
3104         We may find that always uploading the whole zip instead of just the -diffs.txt
3105         file is preferable, but for now I'm keeping the old behavior because it makes
3106         quickly understanding text failures easy.
3107
3108         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3109         * Scripts/webkitpy/common/system/workspace.py: Added.
3110         * Scripts/webkitpy/common/system/workspace_unittest.py: Added.
3111         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3112         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3113         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3114         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3115         * Scripts/webkitpy/tool/commands/queues.py:
3116         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3117
3118 2011-01-10  Sheriff Bot  <webkit.review.bot@gmail.com>
3119
3120         Unreviewed, rolling out r75464.
3121         http://trac.webkit.org/changeset/75464
3122         https://bugs.webkit.org/show_bug.cgi?id=52193
3123
3124         Followup rollout for 75474 (Requested by Ossy on #webkit).
3125
3126         * MiniBrowser/mac/BrowserWindowController.m:
3127         (-[BrowserWindowController awakeFromNib]):
3128         * MiniBrowser/win/BrowserView.cpp:
3129         (BrowserView::create):
3130         * WebKitTestRunner/TestController.cpp:
3131         (WTR::createOtherPage):
3132         (WTR::TestController::initialize):
3133
3134 2011-01-10  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3135
3136         Reviewed by Csaba Osztrogonác.
3137
3138         [Qt] Baseline qt_minimal configuration
3139         https://bugs.webkit.org/show_bug.cgi?id=51313
3140
3141         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3142         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): Add
3143         QT_NO_UNDOSTACK guard.
3144
3145         * QtTestBrowser/launcherwindow.cpp:
3146         (LauncherWindow::createChrome): Add QT_NO_SHORTCUT and QT_NO_PRINTER
3147         guards.
3148         (LauncherWindow::applyZoom): Add QT_NO_ANIMATION guard.
3149         (LauncherWindow::screenshot): Add QT_NO_FILEDIALOG guard.
3150         (LauncherWindow::selectElements): Add QT_NO_INPUTDIALOG guard.
3151         (LauncherWindow::showUserAgentDialog): Add QT_NO_COMBOBOX guard.
3152
3153         * QtTestBrowser/launcherwindow.h:
3154         * QtTestBrowser/locationedit.cpp: Add QT_NO_INPUTDIALOG guard.
3155         * QtTestBrowser/locationedit.h: Ditto.
3156
3157         * QtTestBrowser/mainwindow.cpp:
3158         (MainWindow::buildUI): Add QT_NO_INPUTDIALOG, QT_NO_SHORTCUT and
3159         QT_NO_UNDOSTACK guards.
3160         (MainWindow::setAddressUrl): Add QT_NO_INPUTDIALOG guard.
3161         (MainWindow::changeLocation): Ditto.
3162         (MainWindow::openFile): Add QT_NO_FILEDIALOG guard.
3163         (MainWindow::openLocation): Add QT_NO_INPUTDIALOG guard.
3164
3165         * QtTestBrowser/webpage.cpp:
3166         (WebPage::openUrlInDefaultBrowser): Add QT_NO_DESKTOPSERVICES guard.
3167         (WebPage::authenticationRequired): Add QT_NO_LINEEDIT guard.
3168
3169         * QtTestBrowser/webview.cpp:
3170         (WebViewGraphicsBased::animatedFlip): Add QT_NO_ANIMATION guard.
3171         (WebViewGraphicsBased::animatedYFlip): Ditto.
3172
3173 2011-01-10  Sam Weinig  <sam@webkit.org>
3174
3175         Fix build.
3176
3177         * MiniBrowser/mac/BrowserWindowController.m:
3178         (-[BrowserWindowController awakeFromNib]):
3179         * MiniBrowser/win/BrowserView.cpp:
3180         (BrowserView::create):
3181         * WebKitTestRunner/TestController.cpp:
3182         (WTR::createOtherPage):
3183         (WTR::TestController::initialize):
3184
3185 2011-01-10  Eric Seidel  <eric@webkit.org>
3186
3187         Reviewed by Ojan Vafai.
3188
3189         style-queue messages are way too long for big patches
3190         https://bugs.webkit.org/show_bug.cgi?id=52161
3191
3192         We definitely could build much fancier list-to-string-with-limit functions
3193         but this should be sufficient for our needs at the moment.
3194
3195         * Scripts/webkitpy/common/system/executive.py:
3196         * Scripts/webkitpy/common/system/executive_unittest.py:
3197
3198 2011-01-10  Tony Chang  <tony@chromium.org>
3199
3200         Unreviewed, rolling out r75398.
3201         http://trac.webkit.org/changeset/75398
3202         https://bugs.webkit.org/show_bug.cgi?id=52008
3203
3204         Some layout tests are crashing on Chromium Win.
3205
3206         * DumpRenderTree/chromium/WebViewHost.cpp:
3207         (WebViewHost::updatePaintRect):
3208         * DumpRenderTree/chromium/WebViewHost.h:
3209
3210 2011-01-10  Adam Roben  <aroben@apple.com>
3211
3212         Roll out r75392
3213
3214         It isn't needed now that r75289 has been rolled out.
3215
3216         * Scripts/run-javascriptcore-tests:
3217
3218 2011-01-10  Maciej Stachowiak  <mjs@apple.com>
3219
3220         Reviewed by Anders Carlsson.
3221
3222         WebKitTestRunner uses crazy amounts of CPU, making layout tests slow and flaky
3223         https://bugs.webkit.org/show_bug.cgi?id=52160
3224
3225         * WebKitTestRunner/mac/TestControllerMac.mm:
3226         (WTR::TestController::platformRunUntil): Instead of busy-looping, wait for the timeout.
3227         Anything that can make runUntil() conditions turn true will happen on a run loop cycle
3228         anyway.
3229
3230 2011-01-10  Tony Chang  <tony@chromium.org>
3231
3232         Reviewed by Mihai Parparita.
3233
3234         [chromium] fix for animated gif layout tests
3235         https://bugs.webkit.org/show_bug.cgi?id=52008
3236
3237         * DumpRenderTree/chromium/WebViewHost.cpp: Schedule a paint when we update the paint rect
3238             to trigger gif animations.
3239         (WebViewHostPaintTask::WebViewHostPaintTask):
3240         (WebViewHostPaintTask::runIfValid):
3241         (WebViewHost::updatePaintRect):
3242         * DumpRenderTree/chromium/WebViewHost.h:
3243         (WebViewHost::taskList):
3244
3245 2011-01-10  Alejandro G. Castro  <alex@igalia.com>
3246
3247         Reviewed by Xan Lopez.
3248
3249         [GTK] Fix gtk2 compilation for master
3250         https://bugs.webkit.org/show_bug.cgi?id=51885
3251
3252         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
3253         (createBitmapContextFromWebView): Replaced the old
3254         gdk_drawable_get_size with gdk_pixmap_get_size.
3255
3256 2011-01-10  Patrick Gansterer  <paroga@webkit.org>
3257
3258         Reviewed by Laszlo Gombos.
3259
3260         [WINCE] Reenable NPAPI after r75203
3261         https://bugs.webkit.org/show_bug.cgi?id=52109
3262
3263         Remove the !isWinCE() check for ENABLE_NETSCAPE_PLUGIN_API and replace
3264         it with !isEfl(), because EFL port does not support NPAPI (yet).
3265
3266         * Scripts/build-webkit:
3267
3268 2011-01-10  Adam Roben  <aroben@apple.com>
3269
3270         Skip some asserting JS tests
3271
3272         See <http://webkit.org/b/52156>.
3273
3274         * Scripts/run-javascriptcore-tests:
3275
3276 2011-01-10  Martin Robinson  <mrobinson@igalia.com>
3277
3278         Reviewed by Xan Lopez.
3279
3280         [GTK] build-webkit disable Blob support via arguments passed to automake
3281         https://bugs.webkit.org/show_bug.cgi?id=52097
3282
3283         * Scripts/build-webkit: Enable Blob support when building WebKitGTK+ via
3284         build-webkit.
3285
3286 2011-01-10  Adam Roben  <aroben@apple.com>
3287
3288         Use the same name and description for TestNetscapePlugin on Windows and
3289         Mac
3290
3291         Fixes <http://webkit.org/b/52151>
3292         fast/frames/iframe-reparenting-plugins.html fails on Windows
3293
3294         Reviewed by Steve Falkenburg.
3295
3296         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Copied
3297         the name and description from Mac's Info.plist.
3298
3299 2011-01-10  Siddharth Mathur <siddharth.mathur@nokia.com>
3300
3301         Reviewed by Laszlo Gombos.
3302
3303         [Qt][WK2] Guard gcc-specific syntax
3304
3305         Non-gcc based compliers choke on the "-include"
3306         syntax for preinclude, place guard around it.
3307
3308         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3309         * WebKitTestRunner/qt/WebKitTestRunner.pro:
3310
3311 2011-01-10  Andreas Kling  <kling@webkit.org>
3312
3313         Reviewed by Simon Hausmann.
3314
3315         [Qt] [WK2] MiniBrowser does not load pages opened in new windows
3316         https://bugs.webkit.org/show_bug.cgi?id=52111
3317
3318         When getting a createNewPage() callback from QWKPage, create the
3319         new page with the same QWKContext as the page that is passed to
3320         the callback.
3321
3322         * MiniBrowser/qt/BrowserView.h:
3323         * MiniBrowser/qt/BrowserWindow.cpp:
3324         (newPageFunction):
3325         (BrowserWindow::BrowserWindow):
3326         * MiniBrowser/qt/BrowserWindow.h:
3327
3328 2011-01-10  Andreas Kling  <kling@webkit.org>
3329
3330         Reviewed by Kenneth Rohde Christiansen.
3331
3332         [Qt] MiniBrowser: Remove superfluous createNewPage() callback
3333
3334         BrowserView set its own useless createNewPage() callback on QWKPage.
3335         This was immediately overridden by BrowserWindow anyway, so remove
3336         the BrowserView one.
3337
3338         * MiniBrowser/qt/BrowserView.cpp:
3339         (BrowserView::BrowserView):
3340
3341 2011-01-10  John Knottenbelt  <jknotten@chromium.org>
3342
3343         Reviewed by Jeremy Orlow.
3344
3345         [Chromium] Remove non-client-based Geolocation code
3346         https://bugs.webkit.org/show_bug.cgi?id=50921
3347
3348         * DumpRenderTree/chromium/LayoutTestController.cpp:
3349         (LayoutTestController::setGeolocationPermission):
3350         (LayoutTestController::setMockGeolocationPosition):
3351         (LayoutTestController::setMockGeolocationError):
3352         * DumpRenderTree/chromium/WebViewHost.cpp:
3353         (WebViewHost::geolocationClientMock):
3354         (WebViewHost::reset):
3355         * DumpRenderTree/chromium/WebViewHost.h:
3356
3357 2011-01-10  Eric Seidel  <eric@webkit.org>
3358
3359         Reviewed by Adam Barth.
3360
3361         Commit bot tried to land r? cq+ patch
3362         https://bugs.webkit.org/show_bug.cgi?id=36638
3363
3364         It should now be possible to post a patch with r? and cq+ and the
3365         commit-queue will correctly wait for the r+ before attempting to land the patch.
3366         (This was a feature requested by several users.)
3367
3368         One caveat: We don't actually reject r-, cq+ patches from the queue
3369         (we just ignore them), but I think that's OK for now.
3370
3371         I also noticed that setting r- once a commit-queue node had grabbed
3372         a patch would not properly cancel the landing.  That's fixed and
3373         tested in this patch.
3374
3375         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3376         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3377         * Scripts/webkitpy/tool/bot/feeders.py:
3378         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
3379
3380 2011-01-08  Benjamin Poulain  <benjamin.poulain@nokia.com>
3381
3382         Reviewed by Kenneth Rohde Christiansen.
3383
3384         [Qt] QtWebKit crashes when using XMLHttpRequest from the unload event
3385         https://bugs.webkit.org/show_bug.cgi?id=51934
3386
3387         When accessing the network from the destructor of QWebPage, the network access manager
3388         was already deleted because the object WebPage was already destructed.
3389
3390         This solve the problem by linking the lifetime of the network access manager to WebPage's QObject.
3391         The object is now destructed in the destructor of QObject.
3392
3393         * QtTestBrowser/webpage.cpp:
3394         (WebPage::WebPage):
3395         (WebPage::setQnamThreaded):
3396         * QtTestBrowser/webpage.h:
3397         (QtNAMThread::QtNAMThread):
3398
3399 2011-01-08  Eric Seidel  <eric@webkit.org>
3400
3401         Reviewed by Ojan Vafai.
3402
3403         test_failures.py should not mention TestShell (long live DumpRenderTree!)
3404         https://bugs.webkit.org/show_bug.cgi?id=52067
3405
3406         I ran test-webkitpy, but didn't bother adding a unit test for this string change.
3407         https://bugs.webkit.org/show_bug.cgi?id=51138#c3 is an example of why this is needed.
3408
3409         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
3410
3411 2011-01-08  Eric Seidel  <eric@webkit.org>
3412
3413         Reviewed by Mihai Parparita.
3414
3415         commit-queue hangs when the ChangeLog diff is bad
3416         https://bugs.webkit.org/show_bug.cgi?id=52072
3417
3418         * Scripts/webkitpy/tool/steps/validatechangelogs.py:
3419         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
3420
3421 2011-01-08  Adam Barth  <abarth@webkit.org>
3422
3423         Teach svn-apply how to re-write WebCore to Source/WebCore.
3424
3425         * Scripts/VCSUtils.pm:
3426
3427 2011-01-07  Adam Barth  <abarth@webkit.org>
3428
3429         Rubber-stamped by Eric Seidel.
3430
3431         Move WebCore to Source
3432         https://bugs.webkit.org/show_bug.cgi?id=52050
3433
3434         Update the tools to understand WebCore's new location.
3435
3436         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3437         * DumpRenderTree/wscript:
3438         * GNUmakefile.am:
3439         * Scripts/build-webkit:
3440         * Scripts/do-file-rename:
3441         * Scripts/do-webcore-rename:
3442         * Scripts/generate-qt-inspector-resource:
3443         * Scripts/prepare-ChangeLog:
3444         * Scripts/run-bindings-tests:
3445         * Scripts/update-iexploder-cssproperties:
3446         * Scripts/update-sources-list.py:
3447         * Scripts/update-webkit-localizable-strings:
3448         * Scripts/webkitdirs.pm:
3449         * Scripts/webkitpy/common/config/build.py:
3450         * Scripts/webkitpy/common/config/build_unittest.py:
3451         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
3452         * Scripts/webkitpy/style/checker.py:
3453         * Scripts/webkitpy/style/checker_unittest.py:
3454         * WebKitTestRunner/DerivedSources.pro:
3455         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3456         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh:
3457         * wx/browser/wscript:
3458         * wx/build/settings.py:
3459
3460 2011-01-07  Maciej Stachowiak  <mjs@apple.com>
3461
3462         Reviewed by Sam Weinig.
3463
3464         Make WebKitTestRunner rest between loads more robust to avoid test crashes
3465         https://bugs.webkit.org/show_bug.cgi?id=52086
3466
3467         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3468         (WTR::InjectedBundle::didReceiveMessage):
3469         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3470         (WTR::LayoutTestController::notifyDone):
3471         * WebKitTestRunner/TestController.cpp:
3472         (WTR::TestController::resetStateToConsistentValues):
3473         (WTR::TestController::run):
3474
3475 2011-01-07  James Robinson  <jamesr@chromium.org>
3476
3477         Revert "Implement mozilla's animationTime property"
3478         https://bugs.webkit.org/show_bug.cgi?id=51952
3479
3480         This approach isn't quite right.
3481
3482         * DumpRenderTree/chromium/WebViewHost.cpp:
3483         (WebViewHost::paintInvalidatedRegion):
3484
3485 2011-01-07  Adam Roben  <aroben@apple.com>
3486
3487         Build master fix
3488
3489         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3490         (RunWebKitTests.start): Don't try to concatenate a list and a string.
3491
3492 2011-01-07  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>
3493
3494         Reviewed by Csaba Osztrogonác.
3495
3496         run-qtwebkit-tests should be able to kill a testsuite.
3497
3498         Add new option in the script that can setup a timeout for a test.
3499         If the test execution takes more then specified time then the test
3500         would be terminated.
3501
3502         [Qt] run-qtwebkit-tests needs timeout
3503         https://bugs.webkit.org/show_bug.cgi?id=51894
3504
3505         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3506         * Scripts/run-qtwebkit-tests:
3507
3508 2011-01-07  Csaba Osztrogonác  <ossy@webkit.org>
3509
3510         Unreviewed fix after r75233.
3511
3512         Based on idea from Eric Seidel.
3513
3514         Add remote zip file handling to webkitpy.
3515         https://bugs.webkit.org/show_bug.cgi?id=50901
3516
3517         * Scripts/webkitpy/common/system/fileset.py: Make python 2.5 happy.
3518
3519 2011-01-07  Shane Stephens  <shanestephens@google.com>
3520
3521         Reviewed by Eric Seidel.
3522
3523         svn-apply: should support git binary delta diffs
3524         https://bugs.webkit.org/show_bug.cgi?id=38864
3525
3526         * Scripts/VCSUtils.pm:
3527         * Scripts/svn-apply:
3528
3529 2011-01-06  Julie Parent  <jparent@chromium.org>
3530
3531         Reviewed by Eric Seidel.
3532
3533         Test Result Server not removing old results.
3534         https://bugs.webkit.org/show_bug.cgi?id=52012
3535
3536         * TestResultServer/model/jsonresults.py:
3537         Fix off-by-one: Truncate if >= num_runs, not just >.
3538         * TestResultServer/model/jsonresults_unittest.py:
3539         Add unit test to test that merging in a new result with the same value
3540         as the last result causes previous result to fall off.
3541
3542 2011-01-06  James Kozianski  <koz@chromium.org>
3543
3544         Reviewed by Mihai Parparita.
3545
3546         Add classes to provide a consistent interface to a set of files.
3547         https://bugs.webkit.org/show_bug.cgi?id=50901
3548
3549         These classes allow us to write code that is agnostic to whether a
3550         particular set of files resides in a local directory or in a zip file
3551         on a remote machine.
3552
3553         * Scripts/webkitpy/common/system/directoryfileset.py: Added.
3554         * Scripts/webkitpy/common/system/directoryfileset_unittest.py: Added.
3555         * Scripts/webkitpy/common/system/fileset.py: Added.
3556         * Scripts/webkitpy/common/system/filesystem.py:
3557         * Scripts/webkitpy/common/system/filesystem_mock.py:
3558         * Scripts/webkitpy/common/system/zipfileset.py: Added.
3559         * Scripts/webkitpy/common/system/zipfileset_unittest.py: Added.
3560
3561 2011-01-06  Eric Seidel  <eric@webkit.org>
3562
3563         Reviewed by Adam Barth.
3564
3565         NetworkTransaction should log the url it is retrying
3566         https://bugs.webkit.org/show_bug.cgi?id=52043
3567
3568         * Scripts/webkitpy/common/net/networktransaction.py:
3569         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
3570
3571 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
3572
3573         Windows build fix.
3574         Import os before using it.
3575
3576         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3577
3578 2011-01-06  Eric Seidel  <eric@webkit.org>
3579
3580         Reviewed by Adam Barth.
3581
3582         StyleQueue fails to report errors when patches have many files
3583         https://bugs.webkit.org/show_bug.cgi?id=52042
3584
3585         This is one of at least two errors preventing style error reporting at the moment.
3586         When we moved to passing the list of files to check explicitly,
3587         we started to exceed the 500 character TEXT field limit for our AppEngine model object.
3588         We could change the type of the QueueStatus.message type, or we could
3589         just teach statusserver.py how to clamp values (and warn when it does).
3590         I chose the latter path.
3591
3592         * Scripts/webkitpy/common/net/statusserver.py:
3593
3594 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
3595
3596         Reviewed by Stephanie Lewis.
3597         
3598         Fix syntax error in script.
3599
3600         Windows bots need to archive/unarchive builds to/from configuration-specific directories
3601         https://bugs.webkit.org/show_bug.cgi?id=51996
3602
3603         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3604
3605 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3606
3607         Unreviewed, fixing WinCE build after r75196.
3608
3609         WinCE port does not (yet) support NPAPI.
3610
3611         * Scripts/build-webkit:
3612
3613 2011-01-06  Xan Lopez  <xlopez@igalia.com>
3614
3615         Reviewed by Darin Adler.
3616
3617         File::Spec->rel2abs in sunspider-compare-results mangles parameters
3618         https://bugs.webkit.org/show_bug.cgi?id=52015
3619
3620         * Scripts/sunspider-compare-results: call rel2abs on our arguments
3621         after the platform has been detected, otherwise the script will
3622         mangle things like '--gtk' into '/a/path/--gtk', breaking the
3623         detection.
3624
3625 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3626
3627         Reviewed by Eric Seidel.
3628
3629         Add ENABLE_NETSCAPE_PLUGIN_API, ENABLE_ORIENTATION_EVENTS and ENABLE_TOUCH_EVENTS flags to build-webkit
3630         https://bugs.webkit.org/show_bug.cgi?id=51346
3631
3632         * Scripts/build-webkit:
3633
3634 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
3635
3636         Reviewed by Adam Roben.
3637
3638         Windows bots need to archive/unarchive builds to/from configuration-specific directories
3639         https://bugs.webkit.org/show_bug.cgi?id=51996
3640         
3641         After the configuration directory change, we were archiving the incorrect directory for
3642         build product, so we were running tests on the wrong binaries.
3643         
3644         This change archives the correct directory, and also unarchives it into a configuration-
3645         specific directory.
3646
3647         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Use a configuration-specific directory on Windows.
3648         * BuildSlaveSupport/built-product-archive: Unarchive/archive to/from proper directory.
3649
3650 2011-01-06  Eric Seidel  <eric@webkit.org>
3651
3652         Reviewed by Mihai Parparita.
3653
3654         commit-queue mentions "Text diff mismatch" 4 times instead of once per failure
3655         https://bugs.webkit.org/show_bug.cgi?id=52002
3656
3657         See an example of this here:
3658         https://bugs.webkit.org/show_bug.cgi?id=51314#c2
3659
3660         It's due to the fact that we pass around TestFailure() instance
3661         objects and yet expect them to all compare to be the same.
3662
3663         This is bad.  We should either have shared instances of these values
3664         or we should just pass around the class names.  There are already hacks
3665         in place to make TestFailure objects pass equality tests, I just added
3666         a __hash__ implementation so they can be used in sets as expected.
3667
3668         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3669         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
3670
3671 2011-01-06  Evan Martin  <evan@chromium.org>
3672
3673         Reviewed by Tony Chang.
3674
3675         [gdb] handle inaccessible memory and UChar*
3676         https://bugs.webkit.org/show_bug.cgi?id=52003
3677
3678         To pretty-print a UChar*, we just grope around in the memory
3679         looking for a terminating NUL.  We need to handle the exception
3680         that can occur when we poke into an invalid location.
3681
3682         Additionally, the logic for choosing which pretty-printer would
3683         early return before hitting the point where we'd use the UChar*
3684         printer.  (Did this ever work?  How did it regress?)
3685
3686         * gdb/webkit.py:
3687
3688 2011-01-05  Brian Weinstein  <bweinstein@apple.com>
3689
3690         Reviewed by Ada Chan.
3691
3692         WebKit2: Should be able to call into injected bundle to ask if we should allow resource loads
3693         https://bugs.webkit.org/show_bug.cgi?id=51969
3694         
3695         Add shouldLoadResourceForFrame to WTR::InjectedBundlePage.
3696
3697         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3698         (WTR::InjectedBundlePage::InjectedBundlePage):
3699         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Stub implementation.
3700         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3701
3702 2011-01-06  James Robinson  <jamesr@chromium.org>
3703
3704         Reviewed by Simon Fraser.
3705
3706         Implement mozilla's animationTime property
3707         https://bugs.webkit.org/show_bug.cgi?id=51952
3708
3709         Chromium DRT support for webkitAnimationTime.
3710
3711         * DumpRenderTree/chromium/WebViewHost.cpp:
3712         (WebViewHost::paintInvalidatedRegion):
3713
3714 2011-01-06  Julie Parent  <jparent@chromium.org>
3715
3716         Reviewed by Tony Chang.
3717
3718         Test Result Server always truncates number of results to JSON_RESULTS_MAX_BUILDS
3719         https://bugs.webkit.org/show_bug.cgi?id=51217
3720
3721         * TestResultServer/model/jsonresults.py:
3722         Pass num_runs through to _remove_items_over_max_number_of_builds, and use the value.
3723         Adds missing documentation.
3724         * TestResultServer/model/jsonresults_unittest.py:
3725         Add unit test to test that truncation happens at smaller value than JSON_RESULTS_MAX_BUILDS.
3726         Update test_merge to take a number of builds to truncate at.
3727
3728 2011-01-06  Adam Barth  <abarth@webkit.org>
3729
3730         Reviewed by Eric Seidel.
3731
3732         The EWS should log outside of the working directory
3733         https://bugs.webkit.org/show_bug.cgi?id=51986
3734
3735         This patch prepare us for using git clean -x -d -f in the EWS wrapper
3736         script, which will actually clean the working copy back to a pristine
3737         state instead of leaving untracked directories and ignored files.
3738
3739         * Scripts/webkitpy/tool/commands/queues.py:
3740         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3741
3742 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
3743
3744         Windows build fix.
3745         Back out attempted change to built-product-archive.
3746
3747         * BuildSlaveSupport/built-product-archive:
3748
3749 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
3750
3751         Windows build fix.
3752         Include configuration name when unpacking a build archive.
3753
3754         Needed, since we split Windows build results into configuration-specific directories
3755         under WebKitOutputDir.
3756
3757         * BuildSlaveSupport/built-product-archive:
3758
3759 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
3760
3761         Reviewed by Darin Adler.
3762
3763         Debug and Release builds on Windows clobber each other
3764         https://bugs.webkit.org/show_bug.cgi?id=49185
3765
3766         Changes the structure of WebKitBuild build products directory so we
3767         completely separate each build configuration into independent directories.
3768         
3769         Although we previously had per-configuration directories for obj, this change adds
3770         per-configuration directories for bin, lib, obj, and include. Each configuration's
3771         build products are stored within a directory inside of WebKitBuild.
3772         
3773         Most use of $(WebKitOutputDir) in the build files has been replaced by $(ConfigurationBuildDir),
3774         defined in common.vsprops to be $(WebKitOutputDir)\$(ConfigurationName).
3775
3776         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops:
3777         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd:
3778         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd:
3779         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
3780         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd:
3781         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd:
3782         * DumpRenderTree/win/ImageDiffCommon.vsprops:
3783         * DumpRenderTree/win/ImageDiffPostBuild.cmd:
3784         * DumpRenderTree/win/ImageDiffPreBuild.cmd:
3785         * FindSafari/FindSafari.vcproj:
3786         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
3787         * MiniBrowser/MiniBrowserPostBuild.cmd:
3788         * MiniBrowser/MiniBrowserPreBuild.cmd:
3789         * Scripts/webkitdirs.pm:
3790         * TestWebKitAPI/Configurations/TestWebK