2011-01-20 Dirk Pranke <dpranke@chromium.org>
[WebKit.git] / Tools / ChangeLog
1 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
2
3         Reviewed by Adam Barth.
4
5         Disable the tests that start and stop the http server and web
6         server, so that we don't have to worry about port collisions on
7         the bots.
8
9         https://bugs.webkit.org/show_bug.cgi?id=52861
10
11         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
12
13 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
14
15         Reviewed by Eric Seidel.
16
17         nrwt: rewrite google_chrome_unittest to use mock filesystem.
18         
19         https://bugs.webkit.org/show_bug.cgi?id=52772
20         
21         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
22
23 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
24
25         Reviewed by Eric Siedel.
26
27         nrwt: clean up almost all remaining port references, remove
28         unnecessary import clauses. The only remaining references are
29         in places where a mock filesystem makes no sense or can't be
30         used, and in one routine in port/google_chrome_unittest that
31         I'll rewrite in a separate patch.
32
33         https://bugs.webkit.org/show_bug.cgi?id=52771
34
35         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
36         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
37         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
38         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
39         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
40         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
41         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
42         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
43         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
44         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
45         * Scripts/webkitpy/layout_tests/port/gtk.py:
46         * Scripts/webkitpy/layout_tests/port/mac.py:
47         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
48         * Scripts/webkitpy/layout_tests/port/qt.py:
49         * Scripts/webkitpy/layout_tests/port/webkit.py:
50         * Scripts/webkitpy/layout_tests/port/win.py:
51         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
52
53 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
54
55         Reviewed by Mihai Parparita.
56
57         remove fs refs from run_webkit_tests, rebaseline_chromium_webkit_tests
58
59         https://bugs.webkit.org/show_bug.cgi?id=52762
60
61         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
62         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
63
64 2011-01-20  Tony Chang  <tony@chromium.org>
65
66         Reviewed by Ojan Vafai.
67
68         [chromium] fix the paths used for the rebaseline tool
69         https://bugs.webkit.org/show_bug.cgi?id=52857
70
71         Some of the bots were renamed so the path to grab the results zip
72         file has changed.
73
74         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
75
76 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
77
78         Reviewed by Tony Chang.
79
80         Fix bug introduced in r72688 / bug 52768 that broke the
81         generation of the output filename links in the results.html
82         output. Apparently none of the unit tests actually checked to
83         make sure the generated links were correct :(
84
85         https://bugs.webkit.org/show_bug.cgi?id=52854
86
87         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
88         * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
89
90 2011-01-20  Alexey Proskuryakov  <ap@apple.com>
91
92         Reviewed by Darin Adler.
93
94         https://bugs.webkit.org/show_bug.cgi?id=52849
95         Make window.print work with WebKit2
96
97         * MiniBrowser/mac/BrowserWindowController.m:
98         (-[BrowserWindowController awakeFromNib]):
99         * WebKitTestRunner/TestController.cpp:
100         (WTR::createOtherPage):
101         (WTR::TestController::initialize):
102         Added zeroes to WKPageUIClient structures to avoid build failures.
103
104 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
105
106         Reviewed by Eric Seidel.
107
108         nrwt: remove fs refs from printing, test_failures, test_expectations, text_diff
109
110         https://bugs.webkit.org/show_bug.cgi?id=52756
111
112         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
113         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
114         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
115         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
116         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
117         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
118
119 2011-01-20  Mansi Mithal  <mansi.mithal@nokia.com>
120
121         Reviewed by Antonio Gomes.
122
123         QtTestBrowser should have a seperate menu for Settings
124         https://bugs.webkit.org/show_bug.cgi?id=52817
125         
126         Added a new menu item named "Settings"
127         and moved the "Enable interrupting js scripts" and "Enable js pop up windows" under the "Settings" menu 
128
129         * QtTestBrowser/launcherwindow.cpp:
130         (LauncherWindow::createChrome):
131
132 2011-01-20  Sam Weinig  <sam@webkit.org>
133
134         Reviewed by John Sullivan.
135
136         Update update-webkit-localizable-strings with new path to WebKit.
137
138         * Scripts/update-webkit-localizable-strings:
139
140 2011-01-20  James Robinson  <jamesr@chromium.org>
141
142         Reviewed by Darin Fisher.
143
144         Implement mozilla's requestAnimationFrame API
145         https://bugs.webkit.org/show_bug.cgi?id=51218
146
147         Chromium DumpRenderTree support for window.webkitRequestAnimationFrame.
148
149         * DumpRenderTree/chromium/WebViewHost.cpp:
150         (invokeScheduleComposite):
151         (WebViewHost::scheduleAnimation):
152         (WebViewHost::paintInvalidatedRegion):
153         * DumpRenderTree/chromium/WebViewHost.h:
154
155 2011-01-20  Maciej Stachowiak  <mjs@apple.com>
156
157         Reviewed by Adam Roben.
158
159         WebKitTestRunner needs to support layoutTestController.evaluateScriptInIsolatedWorld
160         https://bugs.webkit.org/show_bug.cgi?id=42327
161
162         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm: Add support
163         for methods that take their normal arguments but also a JSContextRef.
164         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: IDL definition
165         for evaluateScriptInIsolatedWorld.
166         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
167         (WTR::InjectedBundlePage::didClearWindowForFrame): Set a magic variable only if
168         this call is for an isolated world.
169         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
170         (WTR::worldMap): Helper to create a world map.
171         (WTR::LayoutTestController::worldIDForWorld): Map from an ID to a world.
172         (WTR::LayoutTestController::evaluateScriptInIsolatedWorld): The newly
173         added LayoutTestController API.
174         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
175
176 2011-01-19  Adam Roben  <aroben@apple.com>
177
178         Convert paths in environment variables back to msys-style inside commit-log-editor
179
180         When this script gets run from inside git commit, msys-style paths in the environment will
181         have been turned into Windows-style paths with forward slashes. This screws up functions
182         like File::Spec->rel2abs, which seem to rely on $PWD having an msys-style path. We convert
183         the paths back to msys-style before doing anything else.
184
185         Fixes <http://webkit.org/b/48527> commit-log-editor uses full paths for section headers when
186         using msysgit's Perl and multiple ChangeLogs have been edited
187
188         Reviewed by David Kilzer.
189
190         * Scripts/commit-log-editor: Call fixEnvironment before doing anything else.
191         (fixEnvironment): Added. When run in msys in conjunction with git (i.e., when invoked from
192         inside git commit), convert Windows-style paths in the environment back to msys-style paths.
193
194 2011-01-20  Zoltan Horvath  <zoltan@webkit.org>
195
196         [Win] Unreviewed build fix after r76248.
197
198         * DumpRenderTree/ForwardingHeaders/wtf/FastAllocBase.h: Added.
199
200 2011-01-20  Zoltan Horvath  <zoltan@webkit.org>
201
202         Reviewed by Csaba Osztrogonác.
203
204         Refactoring of the custom allocation framework
205         https://bugs.webkit.org/show_bug.cgi?id=49897
206
207         Inheriting from FastAllocBase can result in objects getting larger (bug #33896, #46589).
208         The modification replaces Noncopyable and FastAllocBase classes and these inherits with their
209         equivalent macro implementation at the necessary places.
210 2011-01-20  Yi Shen  <yi.4.shen@nokia.com>
211
212         Unreviewed. 
213
214         Adding myself to committers.py.
215
216         * Scripts/webkitpy/common/config/committers.py:
217
218 2011-01-20  Adam Barth  <abarth@webkit.org>
219
220         Reviewed by Tony Chang.
221
222         Chromium builders don't delete unversioned directories when DEPS change
223         https://bugs.webkit.org/show_bug.cgi?id=52745
224
225         If we pass this option to gclient sync, gclient will delete directories
226         that are no longer part of DEPS instead of leaving them around to
227         confuse us later.  Apparently, the downstream buildbots use this option
228         already.
229
230         * Scripts/update-webkit-chromium:
231
232 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
233
234         Unreviewed, build fix - I pulled this patch in to fix an issue
235         revealed by r76195 running on some new bots). Also fix a couple
236         of other issues revealed in testing.
237
238         nrwt: remove fs refs from layout_package/json*
239
240         https://bugs.webkit.org/show_bug.cgi?id=52754
241
242         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
243         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
244         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
245         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
246         * Scripts/webkitpy/layout_tests/port/base.py:
247
248 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
249
250         Unreviewed, build fix.
251
252         Fix a couple of minor bugs discovered while bringing up new bots
253         for testing.
254
255         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
256         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
257
258 2011-01-19  James Robinson  <jamesr@chromium.org>
259
260         Unreviewed, rolling out r76194.
261         http://trac.webkit.org/changeset/76194
262         https://bugs.webkit.org/show_bug.cgi?id=51218
263
264         Caused mysterious compile failure on the chromium win
265         build.webkit.org bots
266
267         * DumpRenderTree/chromium/WebViewHost.cpp:
268         (WebViewHost::paintInvalidatedRegion):
269         * DumpRenderTree/chromium/WebViewHost.h:
270
271 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
272
273         Reviewed by Mihai Parparita.
274
275         remove fs refs from test_runner, dump_render_tree_thread
276
277         https://bugs.webkit.org/show_bug.cgi?id=52753
278
279         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
280         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
281         * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
282         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
283
284 2011-01-19  James Robinson  <jamesr@chromium.org>
285
286         Reviewed by Darin Fisher.
287
288         Implement mozilla's requestAnimationFrame API
289         https://bugs.webkit.org/show_bug.cgi?id=51218
290
291         Chromium DumpRenderTree support for window.webkitRequestAnimationFrame.
292
293         * DumpRenderTree/chromium/WebViewHost.cpp:
294         (invokeScheduleComposite):
295         (WebViewHost::scheduleAnimation):
296         (WebViewHost::paintInvalidatedRegion):
297         * DumpRenderTree/chromium/WebViewHost.h:
298
299 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
300
301         Unreviewed, build fix.
302
303         Fix a few incorrect "self._filesystem" references introduced in
304         r76184.
305
306         * Scripts/webkitpy/layout_tests/port/chromium.py:
307         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
308
309 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
310
311         Reviewed by Mihai Parparita.
312
313         add a .sep property, abspath(), isabs(), mtime(), and
314         open_text_file_for_writing() to filesystem modules. Some of
315         these properties are not needed in this patch but will be needed
316         in subsequent patches (I'm doing this to avoid having to track
317         multiple versions of a single file).
318
319         Also, change most of the port/* modules to use the filesystem
320         objects instead of referencing the filesystem directly.
321
322         https://bugs.webkit.org/show_bug.cgi?id=52748
323
324         * Scripts/webkitpy/common/system/filesystem.py:
325         * Scripts/webkitpy/common/system/filesystem_mock.py:
326         * Scripts/webkitpy/layout_tests/port/__init__.py:
327         * Scripts/webkitpy/layout_tests/port/base.py:
328         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
329         * Scripts/webkitpy/layout_tests/port/chromium.py:
330         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
331         * Scripts/webkitpy/layout_tests/port/config.py:
332         * Scripts/webkitpy/layout_tests/port/test.py:
333         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
334
335 2011-01-19  Maciej Stachowiak  <mjs@apple.com>
336
337         Reviewed by Anders Carlsson.
338
339         If resetting between tests times out, treat it as a WebProcess crash
340         https://bugs.webkit.org/show_bug.cgi?id=52757
341
342         * WebKitTestRunner/TestController.cpp:
343         (WTR::TestController::runTest):
344
345 2011-01-19  Alexey Proskuryakov  <ap@apple.com>
346
347         Reviewed by Darin Adler.
348
349         https://bugs.webkit.org/show_bug.cgi?id=52739
350         Make it possible for a WebKit2 client to print headers and footers
351
352         Added dummy implementations for new printing UIClient calls.
353
354         * MiniBrowser/mac/BrowserWindowController.m:
355         (-[BrowserWindowController awakeFromNib]):
356         * WebKitTestRunner/TestController.cpp:
357         (WTR::createOtherPage):
358         (WTR::TestController::initialize):
359
360 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
361
362         Reviewed by Ojan Vafai.
363
364         Change webkitpy/layout_tests/port/test.py to use the
365         in-memory filesystem for cleaner unit testing. This
366         change allows us to kill a lot of code that was
367         specific to the test port, at the cost of being a
368         little less clear about how things would work if
369         you didn't have a filesystem.
370
371         https://bugs.webkit.org/show_bug.cgi?id=52605
372
373         * Scripts/webkitpy/layout_tests/port/test.py:
374
375 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
376
377         Unreviewed, build fix.
378
379         Fix test failure caused by committing attachment 79368 instead
380         of attachment 79461 on bug 52604.
381
382         * Scripts/webkitpy/common/system/filesystem_mock.py:
383
384 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
385
386         Reviewed by Mihai Parparita.
387
388         new-run-webkit-tests: remove use of os.walk, use mock filesystem for better
389         unit testing. os.walk() is too much of a hassle to implement on
390         top of the in-memory mock filesystem and adding the necessary
391         interface to files_under() gives clients a cleaner API anyway
392         (for this particular usage model).
393
394         https://bugs.webkit.org/show_bug.cgi?id=52691
395
396         * Scripts/webkitpy/common/system/filesystem.py:
397         * Scripts/webkitpy/common/system/filesystem_mock.py:
398         * Scripts/webkitpy/layout_tests/port/test_files.py:
399         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
400
401 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
402
403         Reviewed by Tony Chang.
404
405         Change more modules in the layout-tests code to use the
406         filesystem wrapper for cleaner unit testing.
407
408         This patch also adds the glob() wrapper to the filesystem
409         abstraction.
410         
411         https://bugs.webkit.org/show_bug.cgi?id=52604
412
413         * Scripts/webkitpy/layout_tests/port/test_files.py:
414         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
415         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
416         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
417         * Scripts/webkitpy/common/system/filesystem.py:
418         * Scripts/webkitpy/common/system/filesystem_mock.py:
419
420 2011-01-19  Levi Weintraub  <leviw@chromium.org>
421
422         Unreviewed.
423
424         Updating my email addresses and irc nick.
425
426         * Scripts/webkitpy/common/config/committers.py:
427
428 2011-01-19  Tony Chang  <tony@chromium.org>
429
430         Reviewed by Mihai Parparita.
431
432         [chromium] [linux] if check-sys-deps fails, output the failure reason
433         https://bugs.webkit.org/show_bug.cgi?id=52671
434
435         * Scripts/webkitpy/common/system/executive_mock.py: Add support for
436             error handler functions.
437         * Scripts/webkitpy/layout_tests/port/chromium.py:
438             output the error text from --check-sys-deps
439         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
440
441 2011-01-19  Aparna Nandyal  <aparna.nand@wipro.com>
442
443         Reviewed by Andreas Kling.
444
445         [Qt] QtTestBrowser crashes when closing if Facebook is opened
446         https://bugs.webkit.org/show_bug.cgi?id=52554
447         
448         QtNetworkAccessManager is created in a thread and set as
449         member variable in QWebPage. When the thread is destroyed
450         the object is still used. So fix will set the object to
451         NULL once the thread is destroyed.
452
453         * QtTestBrowser/launcherwindow.cpp:
454         (LauncherWindow::~LauncherWindow):
455
456 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
457
458         Rubber stamped by Csaba Osztrogonac
459
460         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: Removed unncessary inculde of WKStringCF.h
461
462 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
463
464         Reviewed by Tony Chang.
465
466         new-run-webkit-tests: add a --build-directory command line argument
467
468         Official Google Chrome builds use a non-standard build directory
469         location. This patch adds a --build-directory argument that
470         allows that location to be specified on the command line. Only
471         Chromium-based builds will use this flag for now, but anyone can
472         in the future.
473
474         There are no unit tests for this since it's difficult to test
475         until mock filesystems are fully supported in the code. This was
476         tested by hand for now.
477
478         https://bugs.webkit.org/show_bug.cgi?id=52694
479
480         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
481         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
482         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
483         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
484
485 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
486
487         Not reviewed. Bot fix.
488
489         Remove an inadvertently committed debugging print.
490
491         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
492         (LayoutTestController::notifyDone):
493
494 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
495
496         Reviewed by Sam Weinig.
497
498         WebKitTestRunner should track loading more like DumpRenderTree
499         https://bugs.webkit.org/show_bug.cgi?id=52692
500
501         Change load tracking to track the current top loading frame, in the manner of DumpRenderTree.
502         This makes some tests that call notifyDone multiple times pass.
503         
504         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
505         (WTR::InjectedBundle::InjectedBundle):
506         (WTR::InjectedBundle::done):
507         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
508         (WTR::InjectedBundle::topLoadingFrame):
509         (WTR::InjectedBundle::setTopLoadingFrame):
510         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
511         (WTR::InjectedBundlePage::InjectedBundlePage):
512         (WTR::InjectedBundlePage::stopLoading):
513         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
514         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
515         (WTR::InjectedBundlePage::didFinishLoadForFrame):
516         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
517         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
518         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
519         (WTR::LayoutTestController::notifyDone):
520         * WebKitTestRunner/TestController.cpp:
521         (WTR::TestController::didReceiveMessageFromInjectedBundle):
522
523 2011-01-18  Mihai Parparita  <mihaip@chromium.org>
524
525         Reviewed by Kent Tamura.
526
527         [Chromium] NRWT looking for DRT binary in the wrong path on Mac
528         https://bugs.webkit.org/show_bug.cgi?id=52678
529         
530         Update path now that WebKit is inside Source.
531
532         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
533
534 2011-01-18  Robert Hogan  <robert@webkit.org>
535
536         Reviewed by Simon Hausmann.
537
538         [Qt] http/tests/incremental/slow-utf8-text.pl fails
539         https://bugs.webkit.org/show_bug.cgi?id=44282
540
541         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
542         (WebCore::DumpRenderTree::dump):
543
544 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
545
546         Reviewed by Mihai Parparita.
547
548         Fix a small race condition that could cause the unit tests for
549         new-run-webkit-tests to fail in a multithreaded environment.
550         There was a small window in the code where one thread would
551         check to see if a thread had raised an exception, do something,
552         and then check to see if the thread was alive. If the other
553         thread raised an exception and exited in between these two
554         steps, the exception would be lost. Flipping the order of the
555         two checks fixes the race, since we will now always check for an
556         exception on the thread before exiting.
557
558         https://bugs.webkit.org/show_bug.cgi?id=51579
559
560         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
561
562 2011-01-18  Eric Seidel  <eric@webkit.org>
563
564         Reviewed by Adam Barth.
565
566         commit-queue dies when test archiving fails
567         https://bugs.webkit.org/show_bug.cgi?id=52617
568
569         I looked at the machine and it had 10 archives already
570         thus find_unused_name was returning None.  I've upped
571         the limit to 100 (per bug) and tested the case where
572         find_unused_name returns None (making archive return None).
573
574         * Scripts/webkitpy/common/system/workspace.py:
575         * Scripts/webkitpy/common/system/workspace_unittest.py:
576         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
577         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
578         * Scripts/webkitpy/tool/commands/queues.py:
579
580 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
581
582         Reviewed by Ojan Vafai.
583
584         Update rebaseline-chromium-webkit-tests unit tests to use a mock
585         filesystem. Also fix a couple of "with" statements missed by
586         r76050.
587
588         https://bugs.webkit.org/show_bug.cgi?id=52487
589
590         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
591
592 2011-01-18  Sergio Villar Senin  <svillar@igalia.com>
593
594         Reviewed by Martin Robinson.
595
596         [Gtk] Build fixes for gtk3 build
597         https://bugs.webkit.org/show_bug.cgi?id=52648
598
599         * DumpRenderTree/gtk/EventSender.cpp:
600         (beginDragWithFilesCallback):
601
602 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
603
604         Reviewed by Mihai Parparita.
605
606         Update rebaseline-chromium-webkit-tests to use filesystem objects
607         instead of direct references to os.path, shutil, tempfile, etc.
608
609         This patch doesn't change anything, but will allow subsequent
610         patches to change the unit tests to no longer use the real
611         filesystem.
612
613         This patch adds a bunch more methods to the filesystem object as
614         well.
615
616         https://bugs.webkit.org/show_bug.cgi?id=52482
617
618         * Scripts/webkitpy/common/system/filesystem.py:
619         * Scripts/webkitpy/common/system/filesystem_mock.py:
620         * Scripts/webkitpy/tool/commands/queues.py:
621         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
622         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
623
624 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
625
626         Reviewed by Mihai Parparita.
627
628         new-run-webkit-tests shouldn't crash when you try to run a
629         directory containing only skipped files.
630
631         https://bugs.webkit.org/show_bug.cgi?id=52478
632         
633         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
634         * Scripts/webkitpy/layout_tests/port/test.py:
635         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
636
637 2011-01-18  Adam Bergkvist  <adam.bergkvist@ericsson.com> and Martin Robinson  <mrobinson@igalia.com>
638
639         Reviewed by Gustavo Noronha Silva.
640
641         [GTK] The GTK+ EventSender needs support for beginDragWithFiles
642         https://bugs.webkit.org/show_bug.cgi?id=40833
643
644         * DumpRenderTree/gtk/EventSender.cpp: Add a beginDragWithFiles implementation for the
645         GTK+ event sender.
646         (dragWithFilesDragDataGetCallback): Added.
647         (dragWithFilesDragEndCallback): Added.
648         (beginDragWithFilesCallback): Added.
649
650 2011-01-18  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
651
652         Reviewed by Adam Barth.
653
654         ews: Add additional watcher to efl ews
655         https://bugs.webkit.org/show_bug.cgi?id=52613
656
657         Add gyuyoung.kim@samsung.com to watcher list of efl-ews.
658
659         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
660
661 2011-01-17  Tony Gentilcore  <tonyg@chromium.org>
662
663         Reviewed by Alexey Proskuryakov.
664
665         Fix some headers with missing or misspelled #ifndef guards
666         https://bugs.webkit.org/show_bug.cgi?id=52545
667
668         * DumpRenderTree/chromium/TestEventPrinter.h:
669         * DumpRenderTree/chromium/WebPreferences.h:
670
671 2011-01-17  Jessie Berlin  <jberlin@apple.com>
672
673         Reviewed by Anders Carlsson.
674
675         REGRESSION: Assertion failure in FrameLoader::continueLoadAfterWillSubmitForm() when
676         navigating back to an unreachable URL
677         https://bugs.webkit.org/show_bug.cgi?id=52388
678
679         Add a third parameter (unreachableURL) to queueLoadHTMLString.
680
681         * DumpRenderTree/LayoutTestController.cpp:
682         (queueLoadHTMLStringCallback):
683         (LayoutTestController::queueLoadHTMLString):
684         (LayoutTestController::queueLoadAlternateHTMLString):
685         * DumpRenderTree/LayoutTestController.h:
686
687         * DumpRenderTree/WorkQueueItem.h:
688         (LoadHTMLStringItem::LoadHTMLStringItem):
689
690         * DumpRenderTree/chromium/LayoutTestController.cpp:
691         (WorkItemLoadHTMLString::WorkItemLoadHTMLString):
692         (WorkItemLoadHTMLString::run):
693         (LayoutTestController::queueLoadHTMLString):
694
695         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
696         (LoadHTMLStringItem::invoke):
697         * DumpRenderTree/mac/WorkQueueItemMac.mm:
698         (LoadHTMLStringItem::invoke):
699         * DumpRenderTree/win/WorkQueueItemWin.cpp:
700         (LoadHTMLStringItem::invoke):
701
702 2011-01-17  Dan Bernstein  <mitz@apple.com>
703
704         Rubber-stamped by Mark Rowe.
705
706         Update xcodeproj svn:ignore to include xcuserdata.
707
708         * DumpRenderTree/DumpRenderTree.xcodeproj: Modified property svn:ignore.
709         * MiniBrowser/MiniBrowser.xcodeproj: Modified property svn:ignore.
710         * TestWebKitAPI/TestWebKitAPI.xcodeproj: Modified property svn:ignore.
711         * WebKitLauncher/WebKitLauncher.xcodeproj: Modified property svn:ignore.
712         * WebKitTestRunner/WebKitTestRunner.xcodeproj: Modified property svn:ignore.
713
714 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
715
716         Unreviewed fix after r75908.
717
718         Move WebKit into Source
719         https://bugs.webkit.org/show_bug.cgi?id=52530
720
721         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add Source to the path for Qt API tests.
722
723 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
724
725         Unreviewed.
726
727         Remove accidentally committed debug printing after r75908.
728
729         * Scripts/webkitdirs.pm:
730
731 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
732
733         Unreviewed.
734
735         Add myself to committers list
736         https://bugs.webkit.org/show_bug.cgi?id=52566
737
738         * Scripts/webkitpy/common/config/committers.py:
739
740 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
741
742         Reviewed by Jeremy Orlow.
743
744         GeolocationController should call stopUpdating on destruction
745         https://bugs.webkit.org/show_bug.cgi?id=52216
746
747         fast/dom/Geolocation/window-close-crash.html requires that a
748         Geolocation watch be started in a secondary window. Consequently,
749         we need to allow geolocation permission and provide a mock
750         geolocation position for the secondary window's
751         GeolocationClientMock.
752
753         * DumpRenderTree/chromium/LayoutTestController.cpp:
754         (LayoutTestController::setGeolocationPermission):
755         (LayoutTestController::setMockGeolocationPosition):
756         (LayoutTestController::setMockGeolocationError):
757         * DumpRenderTree/chromium/TestShell.h:
758         (TestShell::windowList):
759
760 2011-01-16  Adam Barth  <abarth@webkit.org>
761
762         Update more include paths to reflect WebKit move.
763
764         * DumpRenderTree/chromium/EventSender.cpp:
765         (EventSender::keyDown):
766         (EventSender::needsShiftModifier):
767         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
768         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
769
770 2011-01-16  Kent Tamura  <tkent@chromium.org>
771
772         Unreviewed, Chromium build fix.
773
774         * Scripts/update-webkit-chromium: Webkit/chromium -> Source/WebKit/chromium
775
776 2011-01-16  Martin Robinson  <mrobinson@igalia.com>
777
778         Build fix for GTK+ after source directory movement.
779
780         * GNUmakefile.am: Correct include paths.
781
782 2011-01-16  Adam Barth  <abarth@webkit.org>
783
784         Teach svn-apply about WebKit move.
785
786         * Scripts/VCSUtils.pm:
787
788 2011-01-16  Adam Barth  <abarth@webkit.org>
789
790         Rubber-stamped by Eric Seidel.
791
792         Move WebKit into Source
793         https://bugs.webkit.org/show_bug.cgi?id=52530
794
795         * DumpRenderTree/mac/InternalHeaders/WebKit/WebTypesInternal.h:
796         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
797         * DumpRenderTree/qt/DumpRenderTreeQt.h:
798         * DumpRenderTree/qt/GCControllerQt.cpp:
799         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
800         * DumpRenderTree/qt/PlainTextControllerQt.cpp:
801         * DumpRenderTree/qt/TextInputControllerQt.cpp:
802         * DumpRenderTree/wscript:
803         * QtTestBrowser/launcherwindow.h:
804         * Scripts/build-webkit:
805         * Scripts/webkitdirs.pm:
806
807 2011-01-15  Adam Barth  <abarth@webkit.org>
808
809         Teach svn-apply about WebKit2 move.
810
811         * Scripts/VCSUtils.pm:
812
813 2011-01-15  Adam Barth  <abarth@webkit.org>
814
815         Rubber-stamped by Eric Seidel.
816
817         Move WebKit2 into Source
818         https://bugs.webkit.org/show_bug.cgi?id=52438
819
820         * MiniBrowser/qt/MiniBrowser.pro:
821         * Scripts/build-webkit:
822         * Scripts/do-file-rename:
823         * Scripts/do-webcore-rename:
824         * Scripts/test-webkitpy:
825         * Scripts/webkitdirs.pm:
826         * Scripts/webkitpy/style/checker.py:
827         * WebKitTestRunner/DerivedSources.pro:
828         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
829         * WebKitTestRunner/qt/WebKitTestRunner.pro:
830
831 2011-01-15  Jochen Eisinger  <jochen@chromium.org>
832
833         Reviewed by David Levin.
834
835         [chromium] remove obsolete createView method
836         https://bugs.webkit.org/show_bug.cgi?id=52437
837
838         * DumpRenderTree/chromium/WebViewHost.cpp:
839         (WebViewHost::createView):
840         * DumpRenderTree/chromium/WebViewHost.h:
841
842 2011-01-14  Brian Weinstein  <bweinstein@apple.com>
843
844         Reviewed by Geoff Garen.
845
846         ShouldLoadResourceForFrame should use strings, not URLs.
847         https://bugs.webkit.org/show_bug.cgi?id=52476
848
849         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
850         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Update to use a WKStringRef.
851         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
852
853 2011-01-14  Tony Gentilcore  <tonyg@chromium.org>
854
855         Reviewed by David Levin.
856
857         Add Tony Gentilcore as a reviewer
858         https://bugs.webkit.org/show_bug.cgi?id=52480
859
860         * Scripts/webkitpy/common/config/committers.py:
861
862 2011-01-14  David Levin  <levin@chromium.org>
863
864         Reviewed by Eric Seidel.
865
866         check-webkit-style: _FunctionState should keep track of where the function name starts.
867         https://bugs.webkit.org/show_bug.cgi?id=52454
868
869         * Scripts/webkitpy/style/checkers/cpp.py: Added function_name_start_position to
870         _FunctionState and logic for setting it correctly.
871         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests.
872
873 2011-01-14  Vincent Scheib  <scheib@chromium.org>
874
875         Reviewed by David Levin.
876
877         Add support to DumpRenderTree to use the GPU rather than software renderer
878         https://bugs.webkit.org/show_bug.cgi?id=52333
879
880         * DumpRenderTree/chromium/DumpRenderTree.cpp:
881         (main):
882         * Scripts/webkitpy/layout_tests/port/chromium.py:
883         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
884
885 2011-01-14  Tony Chang  <tony@chromium.org>
886
887         Reviewed by Kent Tamura.
888
889         [chromium] update fonts.conf to fix 6 linux tests in drt
890         https://bugs.webkit.org/show_bug.cgi?id=52411
891
892         * DumpRenderTree/chromium/fonts.conf: Update to match the copy in
893             chromium's src/webkit/tools/test_shell/resources/fonts.conf
894
895 2011-01-14  Eric Seidel  <eric@webkit.org>
896
897         Original patch from Peter Gal  <galpater@inf.u-szeged.hu>
898
899         Reviewed by Adam Barth.
900
901         Fix when running Tools/Scripts/check-webkit-style without arguments.
902         https://bugs.webkit.org/show_bug.cgi?id=52261#c16
903
904         * Scripts/webkitpy/common/checkout/scm.py: Handle None for changed_files argument better in Git.create_patch method.
905         * Scripts/webkitpy/common/checkout/scm_unittest.py:
906
907 2011-01-04  Jochen Eisinger  <jochen@chromium.org>
908
909         Reviewed by David Levin.
910
911         Store the tempdir object in a variable so it doesn't get deleted too early.
912         https://bugs.webkit.org/show_bug.cgi?id=51875
913
914         * Scripts/update-webkit-auxiliary-libs:
915         * Scripts/update-webkit-support-libs:
916
917 2011-01-14  Eric Seidel  <eric@webkit.org>
918
919         Unreviewed.  Make it work in python 2.5.
920
921         webkit-patch suggest-reviewers dies when ChangeLogs are missing
922         https://bugs.webkit.org/show_bug.cgi?id=49158
923
924         * Scripts/webkitpy/common/checkout/api_unittest.py:
925
926 2011-01-14  Sheriff Bot  <webkit.review.bot@gmail.com>
927
928         Unreviewed, rolling out r75774.
929         http://trac.webkit.org/changeset/75774
930         https://bugs.webkit.org/show_bug.cgi?id=52431
931
932         gtk builds were broken (Requested by loislo2 on #webkit).
933
934         * Scripts/webkitpy/common/checkout/scm.py:
935
936 2011-01-14  David Levin  <levin@chromium.org>
937
938         Reviewed by Shinichiro Hamaji.
939
940         check-webkit-style: _FunctionState should detect pure functions.
941         https://bugs.webkit.org/show_bug.cgi?id=52428
942
943         * Scripts/webkitpy/style/checkers/cpp.py: Added detection for if a function declaration
944         is a pure virtual function.
945         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests for verifying that pure
946         virtual functions are correctly detected.
947
948 2011-01-13  Ilya Tikhonovsky  <loislo@chromium.org>
949
950         Reviewed by Yury Semikhatsky.
951
952         Just small fix for problem with check-webkit-style.
953         It just didn't work for this patch.
954         Old code can't concatenate a list of strings with None.
955
956         * Scripts/webkitpy/common/checkout/scm.py:
957
958 2011-01-13  David Levin  <levin@chromium.org>
959
960         Reviewed by Shinichiro Hamaji.
961
962         check-webkit-style: _FunctionState should use Position to know where items are.
963         https://bugs.webkit.org/show_bug.cgi?id=52424
964
965         * Scripts/webkitpy/style/checkers/cpp.py:
966         (_FunctionState.*): Changed _FunctionState to use Position instead of line numbers.
967         (detect_functions): Changed to pass Position's to _FunctionState.begin and
968         did some minor clean-up.
969         (*): Other changes are simply about converting to use the Position's in_FunctionState
970         instead of line numbers.
971         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Changed the test code
972         to verify the positions stored in _FunctionState.
973
974 2011-01-13  Eric Seidel  <eric@webkit.org>
975
976         Reviewed by David Levin.
977
978         webkit-patch suggest-reviewers dies when ChangeLogs are missing
979         https://bugs.webkit.org/show_bug.cgi?id=49158
980
981         This is not the most elegant, but it is a very safe fix to this bug.
982         One advantage of catching ScriptError like this instead of adding a
983         new added_or_modified_files or fixing all changed_files callers
984         to use a more specific change_files variant, is that we catch
985         all kinds of ScriptErrors which might cause our (non-essential)
986         suggest-reviewers code to fail out.  This should make passing
987         --suggest-reviewers to webkit-patch upload much more robust
988         and may even make it possible for us to make it default.
989
990         The root of the problem here is that SCM.changed_files includes
991         deleted ChangeLog paths (from moves, etc) which then when we ask
992         SVN/Git for the contents of the file at that revision, the command
993         errors out and Executive.run_command raises a ScriptError.
994
995         In the future we might fix this differently by making all current
996         callers of chagned_files use a more specific method for requesting
997         what types of changes they're interested in (adds, modifies, deletes, etc.)
998
999         * Scripts/webkitpy/common/checkout/api.py:
1000         * Scripts/webkitpy/common/checkout/api_unittest.py:
1001
1002 2011-01-13  Dan Bernstein  <mitz@apple.com>
1003
1004         Reviewed by Alexey Proskuryakov.
1005
1006         <rdar://problem/8827065> REGRESSION (r71884): Cross-origin XHR fails if willSendRequest changes the URL
1007         https://bugs.webkit.org/show_bug.cgi?id=52419
1008
1009         Allow to further control the behavior of the willSendRequest delegate callback by making it
1010         set a different URL in the new request.
1011
1012         * DumpRenderTree/LayoutTestController.cpp:
1013         (addURLToRedirectCallback): Added.
1014         (LayoutTestController::staticFunctions): Added addURLToRedirect.
1015         (LayoutTestController::addURLToRedirect): Added. Adds the redirection to the map.
1016         (LayoutTestController::redirectionDestinationForURL): Added this getter.
1017         * DumpRenderTree/LayoutTestController.h:
1018         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1019         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]): Check
1020         if there is a redirection for the request’s URL, established by addURLToRedirect(), and if so,
1021         change the URL in the new request to the redirect destination.
1022
1023 2011-01-13  Eric Seidel  <eric@webkit.org>
1024
1025         Reviewed by Mihai Parparita.
1026
1027         webkit-patch suggest-reviewers fails due to invalid utf8 in ChangeLog files
1028         https://bugs.webkit.org/show_bug.cgi?id=52416
1029
1030         Example: webkit-patch suggest-reviewers -g ca3890fe74d94d85d6bfa48f9ea497b094d8e717 
1031         UnicodeDecodeError: 'utf8' codec can't decode bytes in position 536-538: invalid data
1032
1033         I also added FIXMEs about the changed_files returning deleted files problem
1034         which is causing the other most common exception for suggest-reviewers
1035         (and is probably breaking sheriff-bots blame detection).
1036
1037         * Scripts/webkitpy/common/checkout/api.py:
1038         * Scripts/webkitpy/common/checkout/api_unittest.py:
1039         * Scripts/webkitpy/common/checkout/scm.py:
1040
1041 2011-01-13  Eric Seidel  <eric@webkit.org>
1042
1043         Reviewed by Adam Barth.
1044
1045         results archives from commit-queue are too large to upload
1046         https://bugs.webkit.org/show_bug.cgi?id=52405
1047
1048         * Scripts/webkitpy/common/system/filesystem.py:
1049         * Scripts/webkitpy/common/system/filesystem_mock.py:
1050         * Scripts/webkitpy/tool/commands/queues.py:
1051
1052 2011-01-13  Alejandro G. Castro  <alex@igalia.com>
1053
1054         Reviewed by Martin Robinson.
1055
1056         [gtk] Zero-sized font does not yet work
1057         https://bugs.webkit.org/show_bug.cgi?id=49793
1058
1059         Set minimum-font-size to 0 for the DRT.
1060
1061         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1062         (resetDefaultsToConsistentValues):
1063
1064 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
1065
1066         Reviewed by Darin Adler.
1067
1068         Make old-run-webkit-tests more robust on buildbots
1069         https://bugs.webkit.org/show_bug.cgi?id=52364
1070
1071         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Pass --exit-after-n-failures 500 to old-run-webkit-tests script.
1072
1073 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
1074
1075         Reviewed by Darin Adler.
1076
1077         Make old-run-webkit-tests more robust on buildbots
1078         https://bugs.webkit.org/show_bug.cgi?id=52364
1079
1080         * Scripts/old-run-webkit-tests: Ensure that testResultsDirectory is empty.
1081
1082 2011-01-13  Tony Chang  <tony@chromium.org>
1083
1084         Reviewed by Kent Tamura.
1085
1086         [chromium] fix plugins/plugin-javascript-access.html on Linux and Mac
1087         https://bugs.webkit.org/show_bug.cgi?id=52332
1088
1089         Forked Info.plist is not longer needed.
1090
1091         * DumpRenderTree/chromium/TestNetscapePlugIn/Info.plist: Removed.
1092
1093 2011-01-13  Mikhail Naganov  <mnaganov@chromium.org>
1094
1095         Reviewed by Timothy Hatcher.
1096
1097         Web Inspector: Cleanup after r75613 -- make all UI-facing strings
1098         to be passed directly to WebInspector.UIString
1099
1100         https://bugs.webkit.org/show_bug.cgi?id=52365
1101
1102         * Scripts/check-inspector-strings:
1103
1104 2011-01-13  Sheriff Bot  <webkit.review.bot@gmail.com>
1105
1106         Unreviewed, rolling out r74881.
1107         http://trac.webkit.org/changeset/74881
1108         https://bugs.webkit.org/show_bug.cgi?id=52357
1109
1110         The EFL builder has been red for days (Requested by abarth on
1111         #webkit).
1112
1113         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1114         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1115
1116 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
1117
1118         Reviewed by David Levin.
1119
1120         Add beforeunload support to WebKitTestRunner
1121         https://bugs.webkit.org/show_bug.cgi?id=52353
1122         
1123         This makes a number of currently failing tests pass.
1124
1125         * WebKitTestRunner/TestController.cpp:
1126         (WTR::runBeforeUnloadConfirmPanel):
1127         (WTR::createOtherPage):
1128         (WTR::TestController::initialize):
1129
1130 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
1131
1132         Reviewed by Sam Weinig.
1133
1134         Detect, identify and recover from WebProcess crashes in run-webkit-tests
1135         https://bugs.webkit.org/show_bug.cgi?id=52330
1136
1137         * Scripts/old-run-webkit-tests: Detect when the regression test tool reports
1138         a web process crash.
1139         * WebKitTestRunner/TestController.cpp:
1140         (WTR::TestController::initialize): Set up a processDidCrash
1141         callback.
1142         (WTR::TestController::processDidCrash): Report that the Web process
1143         crashed.
1144         * WebKitTestRunner/TestController.h:
1145
1146 2011-01-12  David Levin  <levin@chromium.org>
1147
1148         Reviewed by Shinichiro Hamaji.
1149
1150         check-webkit-style -- close_expression function doesn't work correctly.
1151         https://bugs.webkit.org/show_bug.cgi?id=52272
1152
1153         * Scripts/webkitpy/style/checkers/cpp.py:
1154         (Position.__str__): Added a way to convert it to a string which is useful in tests.
1155         (Position.__cmp__): Added a way to compare Position which is useful in tests and
1156         generally useful (for upcoming code changes).
1157         (close_expression): Changed to use Position for input and output.
1158         Also, fixed many bugs such as only working correctly for parenthesis,
1159         not working correctly if given an offset in a line and not finding
1160         the real closing element if there were multiple closing elements in
1161         the same line.
1162         (detect_functions): Adjusted due to the change in arguments for
1163         close_expression.
1164         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1165         (CppStyleTestBase.assert_positions_equal): Added a way to verify that
1166         two positions are the same.
1167         (CppStyleTest.test_position): Added tests for the __str_ and __cmp__ methods.
1168         (CppStyleTest.test_close_expression): Added tests to catch the issues
1169         that were fixed.
1170
1171 2011-01-12  Sheriff Bot  <webkit.review.bot@gmail.com>
1172
1173         Unreviewed, rolling out r75576.
1174         http://trac.webkit.org/changeset/75576
1175         https://bugs.webkit.org/show_bug.cgi?id=52304
1176
1177         broke rebaseline-chromium-webkit-test (Requested by thakis on
1178         #webkit).
1179
1180         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1181         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1182         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
1183         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1184         * Scripts/webkitpy/layout_tests/port/base.py:
1185         * Scripts/webkitpy/layout_tests/port/chromium.py:
1186         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1187         * Scripts/webkitpy/layout_tests/port/test.py:
1188         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1189         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1190         * Scripts/webkitpy/style/checkers/test_expectations.py:
1191         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1192
1193 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
1194
1195         Reviewed by Darin Adler.
1196
1197         Add a no-build option to run-webkit-tests, to avoid building DRT/WKTR
1198         https://bugs.webkit.org/show_bug.cgi?id=52307
1199
1200         * Scripts/old-run-webkit-tests:
1201
1202 2011-01-12  Koan-Sin Tan  <koansin.tan@gmail.com>
1203
1204         Reviewed by Martin Robinson.
1205
1206         [Gtk] WebKitGtk+ doesn't build on Mac OS X 10.6
1207         https://bugs.webkit.org/show_bug.cgi?id=50867
1208
1209         Fixed library extention for Mac in webkitdirs.pm and type conflict in
1210         TestNetscapePlugin.cpp 
1211
1212         * GNUmakefile.am: Don't use AppKit when compiling TestNetscapePlugin for GTK+
1213         * Scripts/webkitdirs.pm:
1214
1215 2011-01-12  Mikhail Naganov  <mnaganov@chromium.org>
1216
1217         Reviewed by Pavel Feldman.
1218
1219         Add check-inspector-strings script.
1220
1221         https://bugs.webkit.org/show_bug.cgi?id=52295
1222
1223         * Scripts/check-inspector-strings: Added.
1224
1225 2011-01-12  Adam Roben  <aroben@apple.com>
1226
1227         Advertise the .testnetscape file extension on Windows
1228
1229         Fixes <http://webkit.org/b/52298>
1230         plugins/no-mime-with-valid-extension.html fails on Windows
1231
1232         Reviewed by Dan Bernstein.
1233
1234         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Added a
1235         FileExtents field to map the .testnetscape file extension to the
1236         application/x-webkit-test-netscape MIME type, just as we do on Mac.
1237
1238 2011-01-12  Adam Barth  <abarth@webkit.org>
1239
1240         Reviewed by Eric Seidel.
1241
1242         Make webkit-patch support subdirectories for SVN checkouts
1243         https://bugs.webkit.org/show_bug.cgi?id=52261
1244
1245         os.relpath does not exist on Python 2.5, so we need to call our version
1246         of the API.
1247
1248         * Scripts/webkitpy/common/checkout/scm.py:
1249
1250 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
1251
1252         Reviewed by Eric Seidel.
1253
1254         Close additional pages opened during a test once the test completes.
1255         https://bugs.webkit.org/show_bug.cgi?id=52276
1256
1257         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1258         (WTR::InjectedBundle::done):
1259
1260 2011-01-11  David Levin  <levin@chromium.org>
1261
1262         Reviewed by Eric Seidel.
1263
1264         Errors should be separated from the command line in bot messages.
1265         https://bugs.webkit.org/show_bug.cgi?id=52275
1266
1267         * Scripts/webkitpy/common/system/executive.py:
1268         (ScriptError.message_with_output): Added a newline to separate the command
1269         line from the errors.
1270         * Scripts/webkitpy/common/system/executive_unittest.py:
1271         (ScriptErrorTest.test_message_with_output): Added tests for the various code
1272         paths in message_with_output.
1273
1274 2011-01-11  Eric Seidel  <eric@webkit.org>
1275
1276         Unreviewed.
1277
1278         commit-queue should know how to upload archived results (for test flakes or general failures)
1279         https://bugs.webkit.org/show_bug.cgi?id=52048
1280
1281         The zips are mostly empty due to forgetting -r.
1282         Expected diffs were not being pulled from the archive due
1283         to the archive having longer paths than I realized.
1284
1285         * Scripts/webkitpy/common/system/workspace.py:
1286         * Scripts/webkitpy/common/system/workspace_unittest.py:
1287         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1288         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1289
1290 2011-01-11  Dirk Pranke  <dpranke@chromium.org>
1291
1292         Reviewed by Ojan Vafai.
1293
1294         The current modifier parsing code in test_expectations is
1295         fragile and hard-coded, so it's not easy to understand the logic
1296         or easily add new types of modifiers (like GPU vs. CPU testing
1297         for graphics tests, or 32-bit vs. 64-bit differences).
1298
1299         This is the first of two patches that will add in more generic
1300         support and then eliminate the GPU-specific test expectations
1301         files for Chromium.
1302
1303         This patch adds two standalone objects for handling modifiers. The
1304         rules for interpreting modifiers, precedence, and conflicts are
1305         given in the docstring to the ModifierMatcher class, which
1306         returns ModifierMatchResult objects.
1307         
1308         This patch also adds routines to the Port interface and a
1309         default set of values in the base object, in order to obtain the
1310         values needed on a given test run. These values are then passed
1311         to the expectation parser. This also allows us to clean up the
1312         logic used to lint all of the different configurations in a
1313         single test_expectations.txt file.
1314
1315         The next patch will merge in the separate GPU expectations file.
1316
1317         https://bugs.webkit.org/show_bug.cgi?id=51222
1318
1319         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1320         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1321         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
1322         * Scripts/webkitpy/layout_tests/port/base.py:
1323         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1324         * Scripts/webkitpy/layout_tests/port/chromium.py:
1325         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1326         * Scripts/webkitpy/layout_tests/port/test.py:
1327         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1328         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1329
1330 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
1331
1332         Reviewed by Adam Barth.
1333
1334         Make webkit-patch support subdirectories for SVN checkouts
1335         https://bugs.webkit.org/show_bug.cgi?id=52261
1336
1337         * Scripts/webkitpy/common/checkout/scm.py:
1338         * Scripts/webkitpy/style_references.py:
1339         * Scripts/webkitpy/tool/main.py:
1340         * Scripts/webkitpy/tool/steps/preparechangelog.py:
1341
1342 2011-01-11  Eric Seidel  <eric@webkit.org>
1343
1344         Unreviewed.
1345
1346         commit-queue should know how to upload archived results (for test flakes or general failures)
1347         https://bugs.webkit.org/show_bug.cgi?id=52048
1348
1349         I changed the API for archive_last_layout_test_results w/o updating the implementation.  Oops.
1350         This fixes an exception seen on the commit-queue when attempting to report flaky tests.
1351
1352         * Scripts/webkitpy/common/system/workspace.py:
1353         * Scripts/webkitpy/common/system/workspace_unittest.py:
1354         * Scripts/webkitpy/tool/commands/queues.py:
1355
1356 2011-01-11  Sam Weinig  <sam@webkit.org>
1357
1358         Roll r75474 back in.
1359
1360 2011-01-11  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
1361
1362         Reviewed by Kenneth Rohde Christiansen.
1363
1364         [Qt] Remove uses of QFuture since it isn't supported on all platforms.
1365         https://bugs.webkit.org/show_bug.cgi?id=51204
1366
1367         * QtTestBrowser/webpage.h:
1368         (QtNAMThread::QtNAMThread):
1369         (QtNAMThread::networkAccessManager):
1370         (QtNAMThread::run):
1371
1372 2011-01-11  Peter Varga  <pvarga@webkit.org>
1373
1374         Unreviewed.
1375
1376         Add myself to committers' list.
1377
1378         * Scripts/webkitpy/common/config/committers.py:
1379
1380 2011-01-11  Eric Seidel  <eric@webkit.org>
1381
1382         Reviewed by Adam Barth.
1383
1384         commit-queue should know how to upload archived results (for test flakes or general failures)
1385         https://bugs.webkit.org/show_bug.cgi?id=52048
1386
1387         Now the queue will always upload results.  Either the entire zip, or just
1388         the diffs.txt in the case of text failures.
1389
1390         This should make understanding flakes much easier, and paves the way
1391         for having the EWS run layout tests (and upload failures).
1392
1393         In order to upload .zip files I had to teach bugzilla.py to autodetect
1394         mime types from the filename.  Since mimetypes.py doesn't include a mapping
1395         for .patch files, I have it add one before calling guess_type.
1396
1397         We may find that always uploading the whole zip instead of just the -diffs.txt
1398         file is preferable, but for now I'm keeping the old behavior because it makes
1399         quickly understanding text failures easy.
1400
1401         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1402         * Scripts/webkitpy/common/system/workspace.py: Added.
1403         * Scripts/webkitpy/common/system/workspace_unittest.py: Added.
1404         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1405         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1406         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1407         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1408         * Scripts/webkitpy/tool/commands/queues.py:
1409         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1410
1411 2011-01-10  Sheriff Bot  <webkit.review.bot@gmail.com>
1412
1413         Unreviewed, rolling out r75464.
1414         http://trac.webkit.org/changeset/75464
1415         https://bugs.webkit.org/show_bug.cgi?id=52193
1416
1417         Followup rollout for 75474 (Requested by Ossy on #webkit).
1418
1419         * MiniBrowser/mac/BrowserWindowController.m:
1420         (-[BrowserWindowController awakeFromNib]):
1421         * MiniBrowser/win/BrowserView.cpp:
1422         (BrowserView::create):
1423         * WebKitTestRunner/TestController.cpp:
1424         (WTR::createOtherPage):
1425         (WTR::TestController::initialize):
1426
1427 2011-01-10  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1428
1429         Reviewed by Csaba Osztrogonác.
1430
1431         [Qt] Baseline qt_minimal configuration
1432         https://bugs.webkit.org/show_bug.cgi?id=51313
1433
1434         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1435         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): Add
1436         QT_NO_UNDOSTACK guard.
1437
1438         * QtTestBrowser/launcherwindow.cpp:
1439         (LauncherWindow::createChrome): Add QT_NO_SHORTCUT and QT_NO_PRINTER
1440         guards.
1441         (LauncherWindow::applyZoom): Add QT_NO_ANIMATION guard.
1442         (LauncherWindow::screenshot): Add QT_NO_FILEDIALOG guard.
1443         (LauncherWindow::selectElements): Add QT_NO_INPUTDIALOG guard.
1444         (LauncherWindow::showUserAgentDialog): Add QT_NO_COMBOBOX guard.
1445
1446         * QtTestBrowser/launcherwindow.h:
1447         * QtTestBrowser/locationedit.cpp: Add QT_NO_INPUTDIALOG guard.
1448         * QtTestBrowser/locationedit.h: Ditto.
1449
1450         * QtTestBrowser/mainwindow.cpp:
1451         (MainWindow::buildUI): Add QT_NO_INPUTDIALOG, QT_NO_SHORTCUT and
1452         QT_NO_UNDOSTACK guards.
1453         (MainWindow::setAddressUrl): Add QT_NO_INPUTDIALOG guard.
1454         (MainWindow::changeLocation): Ditto.
1455         (MainWindow::openFile): Add QT_NO_FILEDIALOG guard.
1456         (MainWindow::openLocation): Add QT_NO_INPUTDIALOG guard.
1457
1458         * QtTestBrowser/webpage.cpp:
1459         (WebPage::openUrlInDefaultBrowser): Add QT_NO_DESKTOPSERVICES guard.
1460         (WebPage::authenticationRequired): Add QT_NO_LINEEDIT guard.
1461
1462         * QtTestBrowser/webview.cpp:
1463         (WebViewGraphicsBased::animatedFlip): Add QT_NO_ANIMATION guard.
1464         (WebViewGraphicsBased::animatedYFlip): Ditto.
1465
1466 2011-01-10  Sam Weinig  <sam@webkit.org>
1467
1468         Fix build.
1469
1470         * MiniBrowser/mac/BrowserWindowController.m:
1471         (-[BrowserWindowController awakeFromNib]):
1472         * MiniBrowser/win/BrowserView.cpp:
1473         (BrowserView::create):
1474         * WebKitTestRunner/TestController.cpp:
1475         (WTR::createOtherPage):
1476         (WTR::TestController::initialize):
1477
1478 2011-01-10  Eric Seidel  <eric@webkit.org>
1479
1480         Reviewed by Ojan Vafai.
1481
1482         style-queue messages are way too long for big patches
1483         https://bugs.webkit.org/show_bug.cgi?id=52161
1484
1485         We definitely could build much fancier list-to-string-with-limit functions
1486         but this should be sufficient for our needs at the moment.
1487
1488         * Scripts/webkitpy/common/system/executive.py:
1489         * Scripts/webkitpy/common/system/executive_unittest.py:
1490
1491 2011-01-10  Tony Chang  <tony@chromium.org>
1492
1493         Unreviewed, rolling out r75398.
1494         http://trac.webkit.org/changeset/75398
1495         https://bugs.webkit.org/show_bug.cgi?id=52008
1496
1497         Some layout tests are crashing on Chromium Win.
1498
1499         * DumpRenderTree/chromium/WebViewHost.cpp:
1500         (WebViewHost::updatePaintRect):
1501         * DumpRenderTree/chromium/WebViewHost.h:
1502
1503 2011-01-10  Adam Roben  <aroben@apple.com>
1504
1505         Roll out r75392
1506
1507         It isn't needed now that r75289 has been rolled out.
1508
1509         * Scripts/run-javascriptcore-tests:
1510
1511 2011-01-10  Maciej Stachowiak  <mjs@apple.com>
1512
1513         Reviewed by Anders Carlsson.
1514
1515         WebKitTestRunner uses crazy amounts of CPU, making layout tests slow and flaky
1516         https://bugs.webkit.org/show_bug.cgi?id=52160
1517
1518         * WebKitTestRunner/mac/TestControllerMac.mm:
1519         (WTR::TestController::platformRunUntil): Instead of busy-looping, wait for the timeout.
1520         Anything that can make runUntil() conditions turn true will happen on a run loop cycle
1521         anyway.
1522
1523 2011-01-10  Tony Chang  <tony@chromium.org>
1524
1525         Reviewed by Mihai Parparita.
1526
1527         [chromium] fix for animated gif layout tests
1528         https://bugs.webkit.org/show_bug.cgi?id=52008
1529
1530         * DumpRenderTree/chromium/WebViewHost.cpp: Schedule a paint when we update the paint rect
1531             to trigger gif animations.
1532         (WebViewHostPaintTask::WebViewHostPaintTask):
1533         (WebViewHostPaintTask::runIfValid):
1534         (WebViewHost::updatePaintRect):
1535         * DumpRenderTree/chromium/WebViewHost.h:
1536         (WebViewHost::taskList):
1537
1538 2011-01-10  Alejandro G. Castro  <alex@igalia.com>
1539
1540         Reviewed by Xan Lopez.
1541
1542         [GTK] Fix gtk2 compilation for master
1543         https://bugs.webkit.org/show_bug.cgi?id=51885
1544
1545         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
1546         (createBitmapContextFromWebView): Replaced the old
1547         gdk_drawable_get_size with gdk_pixmap_get_size.
1548
1549 2011-01-10  Patrick Gansterer  <paroga@webkit.org>
1550
1551         Reviewed by Laszlo Gombos.
1552
1553         [WINCE] Reenable NPAPI after r75203
1554         https://bugs.webkit.org/show_bug.cgi?id=52109
1555
1556         Remove the !isWinCE() check for ENABLE_NETSCAPE_PLUGIN_API and replace
1557         it with !isEfl(), because EFL port does not support NPAPI (yet).
1558
1559         * Scripts/build-webkit:
1560
1561 2011-01-10  Adam Roben  <aroben@apple.com>
1562
1563         Skip some asserting JS tests
1564
1565         See <http://webkit.org/b/52156>.
1566
1567         * Scripts/run-javascriptcore-tests:
1568
1569 2011-01-10  Martin Robinson  <mrobinson@igalia.com>
1570
1571         Reviewed by Xan Lopez.
1572
1573         [GTK] build-webkit disable Blob support via arguments passed to automake
1574         https://bugs.webkit.org/show_bug.cgi?id=52097
1575
1576         * Scripts/build-webkit: Enable Blob support when building WebKitGTK+ via
1577         build-webkit.
1578
1579 2011-01-10  Adam Roben  <aroben@apple.com>
1580
1581         Use the same name and description for TestNetscapePlugin on Windows and
1582         Mac
1583
1584         Fixes <http://webkit.org/b/52151>
1585         fast/frames/iframe-reparenting-plugins.html fails on Windows
1586
1587         Reviewed by Steve Falkenburg.
1588
1589         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Copied
1590         the name and description from Mac's Info.plist.
1591
1592 2011-01-10  Siddharth Mathur <siddharth.mathur@nokia.com>
1593
1594         Reviewed by Laszlo Gombos.
1595
1596         [Qt][WK2] Guard gcc-specific syntax
1597
1598         Non-gcc based compliers choke on the "-include"
1599         syntax for preinclude, place guard around it.
1600
1601         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1602         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1603
1604 2011-01-10  Andreas Kling  <kling@webkit.org>
1605
1606         Reviewed by Simon Hausmann.
1607
1608         [Qt] [WK2] MiniBrowser does not load pages opened in new windows
1609         https://bugs.webkit.org/show_bug.cgi?id=52111
1610
1611         When getting a createNewPage() callback from QWKPage, create the
1612         new page with the same QWKContext as the page that is passed to
1613         the callback.
1614
1615         * MiniBrowser/qt/BrowserView.h:
1616         * MiniBrowser/qt/BrowserWindow.cpp:
1617         (newPageFunction):
1618         (BrowserWindow::BrowserWindow):
1619         * MiniBrowser/qt/BrowserWindow.h:
1620
1621 2011-01-10  Andreas Kling  <kling@webkit.org>
1622
1623         Reviewed by Kenneth Rohde Christiansen.
1624
1625         [Qt] MiniBrowser: Remove superfluous createNewPage() callback
1626
1627         BrowserView set its own useless createNewPage() callback on QWKPage.
1628         This was immediately overridden by BrowserWindow anyway, so remove
1629         the BrowserView one.
1630
1631         * MiniBrowser/qt/BrowserView.cpp:
1632         (BrowserView::BrowserView):
1633
1634 2011-01-10  John Knottenbelt  <jknotten@chromium.org>
1635
1636         Reviewed by Jeremy Orlow.
1637
1638         [Chromium] Remove non-client-based Geolocation code
1639         https://bugs.webkit.org/show_bug.cgi?id=50921
1640
1641         * DumpRenderTree/chromium/LayoutTestController.cpp:
1642         (LayoutTestController::setGeolocationPermission):
1643         (LayoutTestController::setMockGeolocationPosition):
1644         (LayoutTestController::setMockGeolocationError):
1645         * DumpRenderTree/chromium/WebViewHost.cpp:
1646         (WebViewHost::geolocationClientMock):
1647         (WebViewHost::reset):
1648         * DumpRenderTree/chromium/WebViewHost.h:
1649
1650 2011-01-10  Eric Seidel  <eric@webkit.org>
1651
1652         Reviewed by Adam Barth.
1653
1654         Commit bot tried to land r? cq+ patch
1655         https://bugs.webkit.org/show_bug.cgi?id=36638
1656
1657         It should now be possible to post a patch with r? and cq+ and the
1658         commit-queue will correctly wait for the r+ before attempting to land the patch.
1659         (This was a feature requested by several users.)
1660
1661         One caveat: We don't actually reject r-, cq+ patches from the queue
1662         (we just ignore them), but I think that's OK for now.
1663
1664         I also noticed that setting r- once a commit-queue node had grabbed
1665         a patch would not properly cancel the landing.  That's fixed and
1666         tested in this patch.
1667
1668         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1669         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1670         * Scripts/webkitpy/tool/bot/feeders.py:
1671         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
1672
1673 2011-01-08  Benjamin Poulain  <benjamin.poulain@nokia.com>
1674
1675         Reviewed by Kenneth Rohde Christiansen.
1676
1677         [Qt] QtWebKit crashes when using XMLHttpRequest from the unload event
1678         https://bugs.webkit.org/show_bug.cgi?id=51934
1679
1680         When accessing the network from the destructor of QWebPage, the network access manager
1681         was already deleted because the object WebPage was already destructed.
1682
1683         This solve the problem by linking the lifetime of the network access manager to WebPage's QObject.
1684         The object is now destructed in the destructor of QObject.
1685
1686         * QtTestBrowser/webpage.cpp:
1687         (WebPage::WebPage):
1688         (WebPage::setQnamThreaded):
1689         * QtTestBrowser/webpage.h:
1690         (QtNAMThread::QtNAMThread):
1691
1692 2011-01-08  Eric Seidel  <eric@webkit.org>
1693
1694         Reviewed by Ojan Vafai.
1695
1696         test_failures.py should not mention TestShell (long live DumpRenderTree!)
1697         https://bugs.webkit.org/show_bug.cgi?id=52067
1698
1699         I ran test-webkitpy, but didn't bother adding a unit test for this string change.
1700         https://bugs.webkit.org/show_bug.cgi?id=51138#c3 is an example of why this is needed.
1701
1702         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1703
1704 2011-01-08  Eric Seidel  <eric@webkit.org>
1705
1706         Reviewed by Mihai Parparita.
1707
1708         commit-queue hangs when the ChangeLog diff is bad
1709         https://bugs.webkit.org/show_bug.cgi?id=52072
1710
1711         * Scripts/webkitpy/tool/steps/validatechangelogs.py:
1712         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
1713
1714 2011-01-08  Adam Barth  <abarth@webkit.org>
1715
1716         Teach svn-apply how to re-write WebCore to Source/WebCore.
1717
1718         * Scripts/VCSUtils.pm:
1719
1720 2011-01-07  Adam Barth  <abarth@webkit.org>
1721
1722         Rubber-stamped by Eric Seidel.
1723
1724         Move WebCore to Source
1725         https://bugs.webkit.org/show_bug.cgi?id=52050
1726
1727         Update the tools to understand WebCore's new location.
1728
1729         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1730         * DumpRenderTree/wscript:
1731         * GNUmakefile.am:
1732         * Scripts/build-webkit:
1733         * Scripts/do-file-rename:
1734         * Scripts/do-webcore-rename:
1735         * Scripts/generate-qt-inspector-resource:
1736         * Scripts/prepare-ChangeLog:
1737         * Scripts/run-bindings-tests:
1738         * Scripts/update-iexploder-cssproperties:
1739         * Scripts/update-sources-list.py:
1740         * Scripts/update-webkit-localizable-strings:
1741         * Scripts/webkitdirs.pm:
1742         * Scripts/webkitpy/common/config/build.py:
1743         * Scripts/webkitpy/common/config/build_unittest.py:
1744         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
1745         * Scripts/webkitpy/style/checker.py:
1746         * Scripts/webkitpy/style/checker_unittest.py:
1747         * WebKitTestRunner/DerivedSources.pro:
1748         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1749         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh:
1750         * wx/browser/wscript:
1751         * wx/build/settings.py:
1752
1753 2011-01-07  Maciej Stachowiak  <mjs@apple.com>
1754
1755         Reviewed by Sam Weinig.
1756
1757         Make WebKitTestRunner rest between loads more robust to avoid test crashes
1758         https://bugs.webkit.org/show_bug.cgi?id=52086
1759
1760         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1761         (WTR::InjectedBundle::didReceiveMessage):
1762         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1763         (WTR::LayoutTestController::notifyDone):
1764         * WebKitTestRunner/TestController.cpp:
1765         (WTR::TestController::resetStateToConsistentValues):
1766         (WTR::TestController::run):
1767
1768 2011-01-07  James Robinson  <jamesr@chromium.org>
1769
1770         Revert "Implement mozilla's animationTime property"
1771         https://bugs.webkit.org/show_bug.cgi?id=51952
1772
1773         This approach isn't quite right.
1774
1775         * DumpRenderTree/chromium/WebViewHost.cpp:
1776         (WebViewHost::paintInvalidatedRegion):
1777
1778 2011-01-07  Adam Roben  <aroben@apple.com>
1779
1780         Build master fix
1781
1782         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1783         (RunWebKitTests.start): Don't try to concatenate a list and a string.
1784
1785 2011-01-07  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>
1786
1787         Reviewed by Csaba Osztrogonác.
1788
1789         run-qtwebkit-tests should be able to kill a testsuite.
1790
1791         Add new option in the script that can setup a timeout for a test.
1792         If the test execution takes more then specified time then the test
1793         would be terminated.
1794
1795         [Qt] run-qtwebkit-tests needs timeout
1796         https://bugs.webkit.org/show_bug.cgi?id=51894
1797
1798         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1799         * Scripts/run-qtwebkit-tests:
1800
1801 2011-01-07  Csaba Osztrogonác  <ossy@webkit.org>
1802
1803         Unreviewed fix after r75233.
1804
1805         Based on idea from Eric Seidel.
1806
1807         Add remote zip file handling to webkitpy.
1808         https://bugs.webkit.org/show_bug.cgi?id=50901
1809
1810         * Scripts/webkitpy/common/system/fileset.py: Make python 2.5 happy.
1811
1812 2011-01-07  Shane Stephens  <shanestephens@google.com>
1813
1814         Reviewed by Eric Seidel.
1815
1816         svn-apply: should support git binary delta diffs
1817         https://bugs.webkit.org/show_bug.cgi?id=38864
1818
1819         * Scripts/VCSUtils.pm:
1820         * Scripts/svn-apply:
1821
1822 2011-01-06  Julie Parent  <jparent@chromium.org>
1823
1824         Reviewed by Eric Seidel.
1825
1826         Test Result Server not removing old results.
1827         https://bugs.webkit.org/show_bug.cgi?id=52012
1828
1829         * TestResultServer/model/jsonresults.py:
1830         Fix off-by-one: Truncate if >= num_runs, not just >.
1831         * TestResultServer/model/jsonresults_unittest.py:
1832         Add unit test to test that merging in a new result with the same value
1833         as the last result causes previous result to fall off.
1834
1835 2011-01-06  James Kozianski  <koz@chromium.org>
1836
1837         Reviewed by Mihai Parparita.
1838
1839         Add classes to provide a consistent interface to a set of files.
1840         https://bugs.webkit.org/show_bug.cgi?id=50901
1841
1842         These classes allow us to write code that is agnostic to whether a
1843         particular set of files resides in a local directory or in a zip file
1844         on a remote machine.
1845
1846         * Scripts/webkitpy/common/system/directoryfileset.py: Added.
1847         * Scripts/webkitpy/common/system/directoryfileset_unittest.py: Added.
1848         * Scripts/webkitpy/common/system/fileset.py: Added.
1849         * Scripts/webkitpy/common/system/filesystem.py:
1850         * Scripts/webkitpy/common/system/filesystem_mock.py:
1851         * Scripts/webkitpy/common/system/zipfileset.py: Added.
1852         * Scripts/webkitpy/common/system/zipfileset_unittest.py: Added.
1853
1854 2011-01-06  Eric Seidel  <eric@webkit.org>
1855
1856         Reviewed by Adam Barth.
1857
1858         NetworkTransaction should log the url it is retrying
1859         https://bugs.webkit.org/show_bug.cgi?id=52043
1860
1861         * Scripts/webkitpy/common/net/networktransaction.py:
1862         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
1863
1864 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
1865
1866         Windows build fix.
1867         Import os before using it.
1868
1869         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1870
1871 2011-01-06  Eric Seidel  <eric@webkit.org>
1872
1873         Reviewed by Adam Barth.
1874
1875         StyleQueue fails to report errors when patches have many files
1876         https://bugs.webkit.org/show_bug.cgi?id=52042
1877
1878         This is one of at least two errors preventing style error reporting at the moment.
1879         When we moved to passing the list of files to check explicitly,
1880         we started to exceed the 500 character TEXT field limit for our AppEngine model object.
1881         We could change the type of the QueueStatus.message type, or we could
1882         just teach statusserver.py how to clamp values (and warn when it does).
1883         I chose the latter path.
1884
1885         * Scripts/webkitpy/common/net/statusserver.py:
1886
1887 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
1888
1889         Reviewed by Stephanie Lewis.
1890         
1891         Fix syntax error in script.
1892
1893         Windows bots need to archive/unarchive builds to/from configuration-specific directories
1894         https://bugs.webkit.org/show_bug.cgi?id=51996
1895
1896         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1897
1898 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1899
1900         Unreviewed, fixing WinCE build after r75196.
1901
1902         WinCE port does not (yet) support NPAPI.
1903
1904         * Scripts/build-webkit:
1905
1906 2011-01-06  Xan Lopez  <xlopez@igalia.com>
1907
1908         Reviewed by Darin Adler.
1909
1910         File::Spec->rel2abs in sunspider-compare-results mangles parameters
1911         https://bugs.webkit.org/show_bug.cgi?id=52015
1912
1913         * Scripts/sunspider-compare-results: call rel2abs on our arguments
1914         after the platform has been detected, otherwise the script will
1915         mangle things like '--gtk' into '/a/path/--gtk', breaking the
1916         detection.
1917
1918 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1919
1920         Reviewed by Eric Seidel.
1921
1922         Add ENABLE_NETSCAPE_PLUGIN_API, ENABLE_ORIENTATION_EVENTS and ENABLE_TOUCH_EVENTS flags to build-webkit
1923         https://bugs.webkit.org/show_bug.cgi?id=51346
1924
1925         * Scripts/build-webkit:
1926
1927 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
1928
1929         Reviewed by Adam Roben.
1930
1931         Windows bots need to archive/unarchive builds to/from configuration-specific directories
1932         https://bugs.webkit.org/show_bug.cgi?id=51996
1933         
1934         After the configuration directory change, we were archiving the incorrect directory for
1935         build product, so we were running tests on the wrong binaries.
1936         
1937         This change archives the correct directory, and also unarchives it into a configuration-
1938         specific directory.
1939
1940         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Use a configuration-specific directory on Windows.
1941         * BuildSlaveSupport/built-product-archive: Unarchive/archive to/from proper directory.
1942
1943 2011-01-06  Eric Seidel  <eric@webkit.org>
1944
1945         Reviewed by Mihai Parparita.
1946
1947         commit-queue mentions "Text diff mismatch" 4 times instead of once per failure
1948         https://bugs.webkit.org/show_bug.cgi?id=52002
1949
1950         See an example of this here:
1951         https://bugs.webkit.org/show_bug.cgi?id=51314#c2
1952
1953         It's due to the fact that we pass around TestFailure() instance
1954         objects and yet expect them to all compare to be the same.
1955
1956         This is bad.  We should either have shared instances of these values
1957         or we should just pass around the class names.  There are already hacks
1958         in place to make TestFailure objects pass equality tests, I just added
1959         a __hash__ implementation so they can be used in sets as expected.
1960
1961         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1962         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1963
1964 2011-01-06  Evan Martin  <evan@chromium.org>
1965
1966         Reviewed by Tony Chang.
1967
1968         [gdb] handle inaccessible memory and UChar*
1969         https://bugs.webkit.org/show_bug.cgi?id=52003
1970
1971         To pretty-print a UChar*, we just grope around in the memory
1972         looking for a terminating NUL.  We need to handle the exception
1973         that can occur when we poke into an invalid location.
1974
1975         Additionally, the logic for choosing which pretty-printer would
1976         early return before hitting the point where we'd use the UChar*
1977         printer.  (Did this ever work?  How did it regress?)
1978
1979         * gdb/webkit.py:
1980
1981 2011-01-05  Brian Weinstein  <bweinstein@apple.com>
1982
1983         Reviewed by Ada Chan.
1984
1985         WebKit2: Should be able to call into injected bundle to ask if we should allow resource loads
1986         https://bugs.webkit.org/show_bug.cgi?id=51969
1987         
1988         Add shouldLoadResourceForFrame to WTR::InjectedBundlePage.
1989
1990         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1991         (WTR::InjectedBundlePage::InjectedBundlePage):
1992         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Stub implementation.
1993         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1994
1995 2011-01-06  James Robinson  <jamesr@chromium.org>
1996
1997         Reviewed by Simon Fraser.
1998
1999         Implement mozilla's animationTime property
2000         https://bugs.webkit.org/show_bug.cgi?id=51952
2001
2002         Chromium DRT support for webkitAnimationTime.
2003
2004         * DumpRenderTree/chromium/WebViewHost.cpp:
2005         (WebViewHost::paintInvalidatedRegion):
2006
2007 2011-01-06  Julie Parent  <jparent@chromium.org>
2008
2009         Reviewed by Tony Chang.
2010
2011         Test Result Server always truncates number of results to JSON_RESULTS_MAX_BUILDS
2012         https://bugs.webkit.org/show_bug.cgi?id=51217
2013
2014         * TestResultServer/model/jsonresults.py:
2015         Pass num_runs through to _remove_items_over_max_number_of_builds, and use the value.
2016         Adds missing documentation.
2017         * TestResultServer/model/jsonresults_unittest.py:
2018         Add unit test to test that truncation happens at smaller value than JSON_RESULTS_MAX_BUILDS.
2019         Update test_merge to take a number of builds to truncate at.
2020
2021 2011-01-06  Adam Barth  <abarth@webkit.org>
2022
2023         Reviewed by Eric Seidel.
2024
2025         The EWS should log outside of the working directory
2026         https://bugs.webkit.org/show_bug.cgi?id=51986
2027
2028         This patch prepare us for using git clean -x -d -f in the EWS wrapper
2029         script, which will actually clean the working copy back to a pristine
2030         state instead of leaving untracked directories and ignored files.
2031
2032         * Scripts/webkitpy/tool/commands/queues.py:
2033         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2034
2035 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
2036
2037         Windows build fix.
2038         Back out attempted change to built-product-archive.
2039
2040         * BuildSlaveSupport/built-product-archive:
2041
2042 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
2043
2044         Windows build fix.
2045         Include configuration name when unpacking a build archive.
2046
2047         Needed, since we split Windows build results into configuration-specific directories
2048         under WebKitOutputDir.
2049
2050         * BuildSlaveSupport/built-product-archive:
2051
2052 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
2053
2054         Reviewed by Darin Adler.
2055
2056         Debug and Release builds on Windows clobber each other
2057         https://bugs.webkit.org/show_bug.cgi?id=49185
2058
2059         Changes the structure of WebKitBuild build products directory so we
2060         completely separate each build configuration into independent directories.
2061         
2062         Although we previously had per-configuration directories for obj, this change adds
2063         per-configuration directories for bin, lib, obj, and include. Each configuration's
2064         build products are stored within a directory inside of WebKitBuild.
2065         
2066         Most use of $(WebKitOutputDir) in the build files has been replaced by $(ConfigurationBuildDir),
2067         defined in common.vsprops to be $(WebKitOutputDir)\$(ConfigurationName).
2068
2069         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops:
2070         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd:
2071         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd:
2072         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
2073         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd:
2074         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd:
2075         * DumpRenderTree/win/ImageDiffCommon.vsprops:
2076         * DumpRenderTree/win/ImageDiffPostBuild.cmd:
2077         * DumpRenderTree/win/ImageDiffPreBuild.cmd:
2078         * FindSafari/FindSafari.vcproj:
2079         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
2080         * MiniBrowser/MiniBrowserPostBuild.cmd:
2081         * MiniBrowser/MiniBrowserPreBuild.cmd:
2082         * Scripts/webkitdirs.pm:
2083         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
2084         * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops:
2085         * TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd:
2086         * TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd:
2087         * TestWebKitAPI/win/copy-resources.cmd:
2088         * WebKitAPITest/WebKitAPITestCommon.vsprops:
2089         * WebKitAPITest/WebKitAPITestPostBuild.cmd:
2090         * WebKitAPITest/WebKitAPITestPreBuild.cmd:
2091         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
2092         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
2093         * WebKitTestRunner/win/InjectedBundle.vcproj:
2094         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops:
2095         * WebKitTestRunner/win/InjectedBundlePostBuild.cmd:
2096         * WebKitTestRunner/win/InjectedBundlePreBuild.cmd:
2097         * WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd:
2098         * WebKitTestRunner/win/WebKitTestRunnerPreBuild.cmd:
2099         * WinLauncher/WinLauncherCommon.vsprops:
2100         * WinLauncher/WinLauncherPostBuild.cmd:
2101         * WinLauncher/WinLauncherPreBuild.cmd:
2102
2103 2011-01-05  Jan Erik Hanssen  <jhanssen@sencha.com>
2104
2105         Reviewed by Ariya Hidayat.
2106
2107         [Qt] TestNetscapePlugin doesn't link on OS X
2108         https://bugs.webkit.org/show_bug.cgi?id=51948
2109
2110         Only add a dependency on libX11 on X11 systems
2111
2112         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2113
2114 2011-01-05  Jeff Miller  <jeffm@apple.com>
2115
2116         Reviewed by Adam Roben.
2117
2118         check-webkit-style should allow unnecessary parameter names in WebKit2 APIs because we're matching CF's header style
2119         https://bugs.webkit.org/show_bug.cgi?id=51970
2120
2121         * Scripts/webkitpy/style/checker.py:
2122         Add -readability/naming for WebKit2 C API directories.
2123
2124 2011-01-05  Eric Seidel  <eric@webkit.org>
2125
2126         Unreviewed, just fixing one more log error from my previous python patch.
2127
2128         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
2129         https://bugs.webkit.org/show_bug.cgi?id=51802
2130
2131         webkit-patch failure-reason was logging about parsing errors
2132         due to my misunderstanding of how BeautifulSoup.findAll worked.
2133
2134         Fixed, and added a unit test.
2135
2136         * Scripts/webkitpy/common/net/layouttestresults.py:
2137         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2138
2139 2011-01-05  Benjamin Poulain  <benjamin.poulain@nokia.com>
2140
2141         Reviewed by Kenneth Rohde Christiansen.
2142
2143         [Qt] [WK2] Add the possibility to open window from the WebProcess in Minibrowser
2144         https://bugs.webkit.org/show_bug.cgi?id=51951
2145
2146         Set a function to QWKPage::setCreateNewPageFunction() in Minibrowser so there is a way
2147         to create new window from WebKit.
2148
2149         * MiniBrowser/qt/BrowserWindow.cpp:
2150         (newPageFunction):
2151         (BrowserWindow::BrowserWindow):
2152         (BrowserWindow::page): Added to avoid the indirect access to QWKPage spread in the class
2153         (BrowserWindow::newWindow):
2154         (BrowserWindow::updateUserAgentList):
2155         (BrowserWindow::showUserAgentDialog):
2156         * MiniBrowser/qt/BrowserWindow.h: Add the global variable backingStoreTypeForNewWindow to
2157         define the type of the backing store used for new windows.
2158         * MiniBrowser/qt/main.cpp:
2159         (main):
2160
2161 2011-01-05  Eric Seidel  <eric@webkit.org>
2162
2163         Reviewed by Ojan Vafai.
2164
2165         commit-queue should report failure type when reporting flaky tests
2166         https://bugs.webkit.org/show_bug.cgi?id=51900
2167
2168         This patch was a ridiculous amount of plumbing.  In the end I like
2169         the NRWT-style TestResult class even less.  But now we're passing
2170         a list of TestResult objects from the queue to the FlakyTestReporter.
2171         Thus the FlakyTestReporter can more easily report what type of failure
2172         occurred.
2173
2174         In the process, I found that I was not alone in finding TestResult
2175         cumbersome to use.  A bunch of code was trying to create a TestResult
2176         object with default values.  However since the constructor didn't make
2177         this easy, some places were getting it wrong (including the TestResult unit test)!
2178         I've fixed the TestResult constructor to have default values for non-essential
2179         arguments.
2180
2181         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2182         * Scripts/webkitpy/common/net/layouttestresults.py:
2183         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2184         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2185         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2186         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2187         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
2188         * Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py:
2189         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2190         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2191         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2192         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2193         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2194         * Scripts/webkitpy/tool/commands/queues.py:
2195         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2196
2197 2011-01-05  Eric Seidel  <eric@webkit.org>
2198
2199         Unreviewed.
2200
2201         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
2202         https://bugs.webkit.org/show_bug.cgi?id=51802
2203
2204         Add another unit test to cover a previously missing import.
2205
2206         * Scripts/webkitpy/common/net/layouttestresults.py:
2207         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2208
2209 2011-01-05  Mihai Parparita  <mihaip@chromium.org>
2210
2211         Reviewed by David Levin.
2212
2213         Add mihaip@chromium.org as a reviewer
2214         https://bugs.webkit.org/show_bug.cgi?id=51966
2215         
2216         Add myself as a reviewer.
2217
2218         * Scripts/webkitpy/common/config/committers.py:
2219
2220 2011-01-05  James Simonsen  <simonjam@chromium.org>
2221
2222         Unreviewed. Adding myself to the list of committers.
2223
2224         * Scripts/webkitpy/common/config/committers.py:
2225
2226 2011-01-05  Eric Seidel  <eric@webkit.org>
2227
2228         Unreviewed.
2229
2230         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
2231         https://bugs.webkit.org/show_bug.cgi?id=51802
2232
2233         Fix two exceptions seen on the bots after my original commit.
2234
2235         * Scripts/webkitpy/common/net/layouttestresults.py:
2236         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2237
2238 2011-01-05  Kundu Suchismita  <suchi.kundu@nokia.com>
2239
2240         Reviewed by Andreas Kling.
2241
2242         [Qt]Add local storage settings to QtTestBrowser command line arguments 
2243         https://bugs.webkit.org/show_bug.cgi?id=51750
2244
2245         * QtTestBrowser/main.cpp:
2246         (LauncherApplication::handleUserOptions):
2247          Local storage settings can be enable form command line arguments for
2248          QtTestBrowser.
2249
2250 2011-01-05  Chris Fleizach  <cfleizach@apple.com>
2251
2252         Reviewed by Martin Robinson.
2253
2254         GTK: AX: DRT needs to use correct root object method.
2255         https://bugs.webkit.org/show_bug.cgi?id=51911
2256
2257         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
2258         (AccessibilityController::rootElement):
2259
2260 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
2261
2262         Rubber-stamped by Csaba Osztrogonác.
2263
2264         Based on idea from Péter Gál.
2265
2266         * Scripts/webkitpy/tool/bot/sheriff.py: Remove unnecessary apostrophes around revision numbers.
2267
2268 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
2269
2270         Reviewed by Adam Barth.
2271
2272         sheriff-bot should be able to do multi-revision rollouts
2273         https://bugs.webkit.org/show_bug.cgi?id=51176
2274
2275         * Scripts/webkitpy/tool/bot/irc_command.py:
2276         * Scripts/webkitpy/tool/bot/sheriff.py:
2277         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
2278
2279 2011-01-05  Eric Seidel  <eric@webkit.org>
2280
2281         Reviewed by Adam Barth.
2282
2283         queues.webkit.org should have per-bot status pages
2284         https://bugs.webkit.org/show_bug.cgi?id=51906
2285
2286         Just adds a /queue-status/QUEUE_NAME/bots/BOT_ID page to show
2287         statuses from a single queue.  Now that we have many bots servicing
2288         some queues (commit-queue, win-ews, etc.) its easy to have the messages
2289         you care about scroll off the end of the 15-message limit on the main page.
2290
2291         Eventually we should probably rename /queue-status to /queue or /queues,
2292         but that's fodder for another patch.
2293
2294         * QueueStatusServer/handlers/queuestatus.py:
2295         * QueueStatusServer/index.yaml:
2296         * QueueStatusServer/main.py:
2297         * QueueStatusServer/templates/includes/singlequeuestatus.html:
2298          - This probably should use a custom filter instead of hard-coding
2299            the URL scheme here, but I couldn't figure out how to easily
2300            create such a filter.  Most filters work with "strings" so we can't
2301            pass the status object.  We could add a method to the status
2302            object and call that, but that seemed a bit strange too.
2303         * QueueStatusServer/templates/queuestatus.html:
2304
2305 2011-01-05  Carlos Garcia Campos  <cgarcia@igalia.com>
2306
2307         Unreviewed. Adding myself to the list of committers.
2308
2309         * Scripts/webkitpy/common/config/committers.py:
2310
2311 2011-01-04  Koan-Sin Tan  <koansin.tan@gmail.com>
2312
2313         Reviewed by David Levin.
2314
2315         check-webkit-style treated some macros with parentheses after #elif as function calls
2316         https://bugs.webkit.org/show_bug.cgi?id=51695
2317
2318         Ingore function call space checking in any preprocessor directives
2319         (things starting with #). Change search() to match() because 
2320         preprocessor directives are supposed to be in the beginning of lines.
2321
2322         * Scripts/webkitpy/style/checkers/cpp.py:
2323         * Scripts/webkitpy/style/checkers/cpp_unittest.py: make sure there is no false positives for #elif cases
2324
2325 2011-01-04  Søren Gjesse  <sgjesse@chromium.org>
2326
2327         Reviewed by Tony Chang.
2328
2329         Change the --multi-load test option to --stress-opt
2330         https://bugs.webkit.org/show_bug.cgi?id=50751
2331
2332         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2333         (runTest):
2334         (main):
2335         * DumpRenderTree/chromium/TestShell.cpp:
2336         (TestShell::TestShell):
2337         * DumpRenderTree/chromium/TestShell.h:
2338         (TestShell::stressOpt):
2339         (TestShell::setStressOpt):
2340         (TestShell::stressDeopt):
2341         (TestShell::setStressDeopt):
2342         (TestShell::javaScriptFlags):
2343         (TestShell::setJavaScriptFlags):
2344         * Scripts/webkitpy/layout_tests/port/chromium.py:
2345         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2346
2347 2011-01-04  Chris Fleizach  <cfleizach@apple.com>
2348
2349         Reviewed by Sam Weinig.
2350
2351         WK2: Support Accessibility
2352         https://bugs.webkit.org/show_bug.cgi?id=51859
2353
2354         Use rootObject() method to get top of accessibility tree.
2355
2356         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
2357         (AccessibilityController::focusedElement):
2358         (AccessibilityController::rootElement):
2359
2360 2011-01-03  Martin Robinson  <mrobinson@igalia.com>
2361
2362         Reviewed by Darin Adler.
2363
2364         Remove the last non-GObject usage of PlatformRefPtr and move the code to GRefPtr
2365         https://bugs.webkit.org/show_bug.cgi?id=51846
2366
2367         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: Change usage of PlatformRefPtr
2368         back to GRefPtr.
2369
2370 2011-01-04  Zhe Su  <suzhe@chromium.org>
2371
2372         Reviewed by Kenneth Russell.
2373
2374         Fix insertText, setMarkedText and unmarkText methods of
2375         TextInputController to call corresponding methods of WebKit::WebView
2376         rather than WebKit::WebFrame. This change matches the behavior of
2377         chromium browser.
2378         insertText corresponds to WebView::confirmComposition(text)
2379         setMarkedText corresponds to WebView::setComposition(...)
2380         unmarkText corresponds to WebView::confirmComposition()
2381         https://bugs.webkit.org/show_bug.cgi?id=51693
2382
2383         * DumpRenderTree/chromium/TextInputController.cpp:
2384         (TextInputController::insertText):
2385         (TextInputController::setMarkedText):
2386         (TextInputController::unmarkText):
2387
2388 2011-01-04  Dihan Wickremasuriya  <dihan.wickremasuriya@nokia.com>
2389
2390         Reviewed by Laszlo Gombos.
2391
2392         [Qt] [Symbian] Do not remove 0 byte sized files from productDir
2393
2394         On Symbian productDir points to the source directory. Removing all the
2395         empty files from the productDir directory corrupts the svn repository.
2396
2397         * Scripts/build-webkit:
2398
2399 2011-01-03  Yi Shen  <yi.4.shen@nokia.com>
2400
2401         Reviewed by Adam Barth.
2402
2403         [Qt] Add SelectAll option to the context menu for the editor
2404         https://bugs.webkit.org/show_bug.cgi?id=50049
2405
2406         Set shortcut for the SelectAll action.
2407
2408         * QtTestBrowser/mainwindow.cpp:
2409         (MainWindow::buildUI):
2410
2411 2011-01-03  David Levin  <levin@chromium.org>
2412
2413         Reviewed by Eric Seidel.
2414
2415         check-webkit-style shouldn't consider "value" automatically to be a meaningless name.
2416         https://bugs.webkit.org/show_bug.cgi?id=51842
2417
2418         * Scripts/webkitpy/style/checkers/cpp.py: Remove the check for value.
2419         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Remove the test for value.
2420
2421 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
2422
2423         Reviewed by David Kilzer.
2424
2425         [WINCE] Adds a build slave.
2426         https://bugs.webkit.org/show_bug.cgi?id=50523
2427
2428         * BuildSlaveSupport/build.webkit.org-config/config.json: Add an
2429         entry for a release build of the WinCE port.
2430         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add platform
2431         flag to build the WinCE port.
2432
2433 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
2434
2435         Reviewed by David Kilzer.
2436
2437         Add WinCE support to build-webkit
2438         https://bugs.webkit.org/show_bug.cgi?id=51642
2439
2440         * Scripts/build-webkit:
2441         * Scripts/webkitdirs.pm:
2442
2443 2011-01-03  Eric Seidel  <eric@webkit.org>
2444
2445         Reviewed by Adam Barth.
2446
2447         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
2448         https://bugs.webkit.org/show_bug.cgi?id=51802
2449
2450         I'm not the biggest fan of the test_failures or test_results classes,
2451         but it's better to have one shared set of classes, than separate ones
2452         for new vs. old run-webkit-test result handling.
2453
2454         This moves the ORWT results class "LayoutTestResults" over to using
2455         TestResult and TestFailure classes, making it easy for us to
2456         make all our sheriff-bot and other webkitpy code NRWT ready.
2457
2458         This also makes it a trivial patch to generate results.json information
2459         from ORWT results.html files (for flaky test analysis, etc.) as well
2460         as making it a one-liner to report test failure types when the
2461         commit-queue sees flaky tests.
2462
2463         This patch tried not to add new functionality, but only to replace
2464         the guts of LayoutTestResults, while adding unit tests and hoping
2465         not to break anything.
2466
2467         I also moved callers which assumed User.prompt* were static/class methods
2468         to using them as instance methods (since we'll eventually want to make them such).
2469
2470         In the process of re-writing things, I broke the rebaseline command, so I wrote
2471         a unit test to catch my breakage were I do do so again in the future.
2472
2473         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2474         * Scripts/webkitpy/common/net/layouttestresults.py:
2475         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2476         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
2477         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
2478         * Scripts/webkitpy/tool/commands/queries.py:
2479         * Scripts/webkitpy/tool/commands/rebaseline.py:
2480         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2481         * Scripts/webkitpy/tool/mocktool.py:
2482
2483 2011-01-03  Adam Barth  <abarth@webkit.org>
2484
2485         Reviewed by Simon Fraser.
2486
2487         webkit-patch shouldn't waste time cleaning a working directory that's already clean
2488         https://bugs.webkit.org/show_bug.cgi?id=51840
2489
2490         * Scripts/webkitpy/common/checkout/scm.py:
2491
2492 2011-01-03  Adam Barth  <abarth@webkit.org>
2493
2494         Reviewed by Simon Fraser.
2495
2496         webkit-patch should only hide update output if --quiet
2497         https://bugs.webkit.org/show_bug.cgi?id=51838
2498
2499         As requested by smfr.
2500
2501         * Scripts/webkitpy/tool/steps/update.py:
2502
2503 2011-01-03  Adam Barth  <abarth@webkit.org>
2504
2505         Reviewed by David Levin.
2506
2507         commit-queue shouldn't reject patches twice if two bots process the same patch
2508         https://bugs.webkit.org/show_bug.cgi?id=51805
2509
2510         Before raising an error, we first check whether the patch is still in
2511         the commit-queue.  This check is still racy, of course, but the time
2512         window is much smaller.
2513
2514         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2515
2516 2011-01-03  Sam Weinig  <sam@webkit.org>
2517
2518         Reviewed by Anders Carlsson.
2519
2520         Make run-api-tests less chatty.
2521         https://bugs.webkit.org/show_bug.cgi?id=51831
2522
2523         - Make script quiet by default and add --verbose option (replacing --quiet).
2524         - When not verbose, pipe stdout and stderr to devnull.
2525
2526         * Scripts/run-api-tests:
2527
2528 2011-01-03  Pratik Solanki  <psolanki@apple.com>
2529
2530         Unreviewed. Adding myself to committers.py.
2531
2532         * Scripts/webkitpy/common/config/committers.py:
2533
2534 2011-01-03  Koan-Sin Tan  <koansin.tan@gmail.com>
2535
2536         Reviewed by Xan Lopez.
2537
2538         "Tool/Scripts/run-launcher --gtk" stopped working after 74855
2539         https://bugs.webkit.org/show_bug.cgi?id=51806
2540
2541         Originally, the $libraryName is 'JavaScriptCore'. When building release 
2542         one, the $libraryDir was 'WebKitBuild/Release/JavaScriptCore/../.libs/'
2543         which doesn't exist anymore ('WebKitBuild/Release/JavaScriptCore'
2544         is 'WebKitBuild/Release/Source/JavaScriptCore' now), and 
2545         'WebKitBuild/Release/Source/JavaScriptCore/../../.libs' looks weird,
2546         so make it 'WebKitBuild/Release/.libs'
2547
2548         * Scripts/webkitdirs.pm: 
2549
2550 2011-01-02  Patrick Gansterer  <paroga@webkit.org>
2551
2552         Reviewed by Adam Barth.
2553
2554         Make EFL a core builder
2555         https://bugs.webkit.org/show_bug.cgi?id=51804
2556
2557         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2558         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2559
2560 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
2561
2562         [Qt] Unreviewed fix after r74855 and r74875.
2563
2564         * BuildSlaveSupport/built-product-archive:
2565          - Create directories explicitly.
2566          - Pass shell=True to subprocess.call().
2567
2568 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
2569
2570         [Qt] Unreviewed fix after r74855.
2571
2572         Move JavaScriptCore to Source
2573         https://bugs.webkit.org/show_bug.cgi?id=51604
2574
2575         * BuildSlaveSupport/built-product-archive: JavaScriptCore -> Source/JavaScriptCore
2576
2577 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
2578
2579         [Qt] Unreviewed run-javasriptcore-tests fix after r74855.
2580
2581         Move JavaScriptCore to Source
2582         https://bugs.webkit.org/show_bug.cgi?id=51604
2583
2584         * Scripts/webkitdirs.pm:
2585
2586 2011-01-02  Robert Hogan  <robert@webkit.org>
2587
2588         Unreviewed, build fix.
2589
2590         [Qt] Fix DRT build after 74855
2591
2592         * DumpRenderTree/qt/DumpRenderTree.pro:
2593
2594 2011-01-01  Adam Barth  <abarth@webkit.org>
2595
2596         Remove the assumption from the Qt and Gtk builds that every project is
2597         in the root directory.
2598
2599         * Scripts/build-webkit:
2600
2601 2011-01-01  Adam Barth  <abarth@webkit.org>
2602
2603         Reviewed by Eric Seidel.
2604
2605         Teach svn-apply how to apply patches even though JavaScriptCore has moved
2606         https://bugs.webkit.org/show_bug.cgi?id=51796
2607
2608         After this change, svn-apply will magically apply patches to
2609         JavaScriptCore/foo to Source/JavaScriptCore/foo.
2610
2611         * Scripts/VCSUtils.pm:
2612
2613 2011-01-01  Adam Barth  <abarth@webkit.org>
2614
2615         Reviewed by Eric Seidel.
2616
2617         Move JavaScriptCore to Source
2618         https://bugs.webkit.org/show_bug.cgi?id=51604
2619
2620         Update references to JavaScriptCore to point to the new location.
2621
2622         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2623         * DumpRenderTree/qt/DumpRenderTree.pro:
2624         * DumpRenderTree/qt/ImageDiff.pro:
2625         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2626         * DumpRenderTree/wscript:
2627         * Scripts/build-jsc:
2628         * Scripts/build-webkit:
2629         * Scripts/do-file-rename:
2630         * Scripts/do-webcore-rename:
2631         * Scripts/run-javascriptcore-tests:
2632         * Scripts/update-javascriptcore-test-results:
2633         * Scripts/webkitdirs.pm:
2634         * Scripts/webkitpy/common/config/build_unittest.py:
2635         * Scripts/webkitpy/style/checker.py:
2636         * Scripts/webkitpy/style/checker_unittest.py:
2637         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2638         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2639         * WebKitTestRunner/qt/WebKitTestRunner.pro:
2640         * wx/build/settings.py:
2641
2642 2011-01-01  Adam Barth  <abarth@webkit.org>
2643
2644         Reviewed by Eric Seidel.
2645
2646         Move Sources to Source
2647         https://bugs.webkit.org/show_bug.cgi?id=51794
2648
2649         Update scripts to point to the new location.
2650
2651         * Scripts/build-webkit:
2652         * Scripts/do-file-rename:
2653         * Scripts/do-webcore-rename:
2654         * Scripts/webkitpy/common/config/build.py:
2655         * Scripts/webkitpy/common/config/build_unittest.py:
2656
2657 2010-12-31  Kent Tamura  <tkent@chromium.org>
2658
2659         Reviewed by Eric Seidel.
2660
2661         [DRT/Chromium] Enable mock spell checker on non-OSX
2662         https://bugs.webkit.org/show_bug.cgi?id=51401
2663
2664         * DumpRenderTree/chromium/WebViewHost.cpp:
2665         (WebViewHost::spellCheck):
2666
2667 2010-12-31  Adam Barth  <abarth@webkit.org>
2668
2669         Reviewed by Ariya Hidayat.
2670
2671         Remove Tools/Scripts/wkstyle
2672         https://bugs.webkit.org/show_bug.cgi?id=51774
2673
2674         This script appears to not have been touched in a while and seems to
2675         have been replaced by check-webkit-style.
2676
2677         * Scripts/wkstyle: Removed.
2678
2679 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
2680
2681         Unreviewed. Coding style fix.
2682
2683         * DumpRenderTree/chromium/TestShell.h:
2684
2685 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
2686
2687         Reviewed by Pavel Feldman.
2688
2689         Web Inspector: [Chromium] Inspector's tests are very slow on Win(Dbg).
2690
2691         It was a problem with Chromium DRT. DevToolsAgent object instance was
2692         attached not only to the inspected page but to the DevTools window too.
2693         As result all the inspector files were interpreted as a content of inspected page
2694         and were transfered to the DevTools scripts panel for debugging etc.
2695
2696         https://bugs.webkit.org/show_bug.cgi?id=51735
2697
2698         * DumpRenderTree/chromium/TestShell.cpp:
2699         (TestShell::TestShell):
2700         (TestShell::bindJSObjectsToWindow):
2701         (TestShell::createNewWindow):
2702         * DumpRenderTree/chromium/TestShell.h:
2703
2704 2010-12-31  Adam Barth  <abarth@webkit.org>
2705
2706         Rubber-stamped by Eric Seidel.
2707
2708         Move PageLoadTests to PerformanceTests/PageLoad
2709         https://bugs.webkit.org/show_bug.cgi?id=51771
2710
2711         Update references to PageLoadTests to point to the new location.
2712
2713         * Scripts/run-pageloadtest:
2714         * Scripts/webkitpy/common/config/build.py:
2715
2716 2010-12-31  Adam Barth  <abarth@webkit.org>
2717
2718         Rubber-stamped by Eric Seidel.
2719
2720         Move SunSpider into PerformanceTests
2721         https://bugs.webkit.org/show_bug.cgi?id=51769
2722
2723         Update these scripts to point to the new location.
2724
2725         * Scripts/run-sunspider:
2726         * Scripts/sunspider-compare-results:
2727
2728 2010-12-30  Mihai Parparita  <mihaip@chromium.org>
2729
2730         Reviewed by Kent Tamura.
2731
2732         [Chromium] Add WebThemeEngineDRTMac so that Chromium DRT scrollbar rendering can match the Mac port's
2733         https://bugs.webkit.org/show_bug.cgi?id=51728
2734         
2735         Add implementation of the Mac WebThemeEngine that uses an NSScroller
2736         to render top-level scrollbars. This makes them match the Mac port's
2737         use of an NSScrollView, which means that we'll be able to share more
2738         pixel baselines.
2739         
2740         The new rendering code will not be activated until the 
2741         USE_WEB_THEME_ENGINE_TO_PAINT_THUMB #define is fliped in
2742         ScrollbarThemeChromiumMac.
2743
2744         * DumpRenderTree/DumpRenderTree.gypi:
2745         * DumpRenderTree/chromium/TestShellMac.mm:
2746         (platformInit):
2747         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Added.
2748         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Added.
2749         (+[FakeActiveWindow alwaysActiveWindow]):
2750         (+[FakeActiveWindow alwaysInactiveWindow]):
2751         (-[FakeActiveWindow initWithActiveControls:]):
2752         (-[FakeActiveWindow _hasActiveControls]):
2753         (WebThemeEngineDRTMac::paintScrollbarThumb):
2754         (stateToHIEnableState):
2755         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
2756         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
2757
2758 2010-12-30  Konstantin Tokarev  <annulen@yandex.ru>
2759
2760         Reviewed by David Kilzer.
2761
2762         [Qt] Don't build wtf/TCSystemAlloc.cpp if --system-malloc option is
2763         used
2764         https://bugs.webkit.org/show_bug.cgi?id=51672
2765
2766         * DumpRenderTree/qt/DumpRenderTree.pro: Replaced USE_SYSTEM_MALLOC
2767         with USE_SYSTEM_MALLOC=1
2768         * WebKitTestRunner/qt/WebKitTestRunner.pro: Replaced USE_SYSTEM_MALLOC
2769         with USE_SYSTEM_MALLOC=1
2770
2771 2010-12-30  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2772
2773         Reviewed by David Kilzer.
2774
2775         [Qt] [Symbian] Fix build-webkit script for Symbian
2776         https://bugs.webkit.org/show_bug.cgi?id=51509
2777
2778         Set the OUTPUT_DIR for Symbian to be the same as the source
2779         directory.
2780
2781         * Scripts/webkitdirs.pm:
2782
2783 2010-12-30  Martin Robinson  <mrobinson@igalia.com>
2784
2785         Reviewed by Darin Adler.
2786
2787         check-webkit-style should ignore NULL usage in calls to gtk_widget_style_get
2788         https://bugs.webkit.org/show_bug.cgi?id=51758
2789
2790         Add a check-webkit-style exception for gtk_widget_style_get and NULL usage.
2791
2792         * Scripts/webkitpy/style/checkers/cpp.py: Add the exception.
2793         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Add some tests for this.
2794
2795 2010-12-29  Patrick Gansterer  <paroga@webkit.org>
2796
2797         Unreviewed WinCE buildfix.
2798
2799         * WinCELauncher/main.cpp: Add missing include.
2800
2801 2010-12-29  Daniel Bates  <dbates@rim.com>
2802
2803         Reviewed by Darin Adler.
2804
2805         svn-apply updates date of wrong change log entry for a change log diff that
2806         contains two consecutive entries with the same author and date
2807         https://bugs.webkit.org/show_bug.cgi?id=46061
2808
2809         Fixes an issue where the date of the wrong change log entry may be modified.
2810         Moreover, changes fixChangeLogPatch() to move entries inserted earlier
2811         in a ChangeLog file to the top of the file.
2812
2813         Currently, fixChangeLogPatch() explicitly bails out and returns an unchanged
2814         diff when it detects that the diff inserts a change log entry earlier in a
2815         ChangeLog. It is unusual to land a patch that has such a deliberate ChangeLog
2816         change. With the advent of the commit-queue this functionality of bailing out
2817         and hence landing the patch as-is is harmful to the accuracy of the ChangeLog.
2818         Instead, we should always move the change log entry to the top of the ChangeLog file.
2819
2820         A side-effect of this change is that setChangeLogDateAndReviewer() now updates
2821         the date line of the correct change log entry in a ChangeLog diff.
2822
2823         * Scripts/VCSUtils.pm: Modified fixChangeLogPatch() to move entries inserted earlier to the top.
2824
2825         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
2826           Updated the following unit tests now that we move entries inserted earlier to the top:
2827           - "fixChangeLogPatch: New entry inserted in middle."
2828             (formerly named "fixChangeLogPatch: [no change] New entry inserted in middle.")
2829
2830           - "fixChangeLogPatch: New entry inserted earlier in the file, but after an entry with the same author and date."
2831             (formerly named "fixChangeLogPatch: [no change] New entry inserted earlier in the file, but after an entry with the same author and date.")
2832
2833         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatchThenSetChangeLogDateAndReviewer.pl: Added.
2834
2835 2010-12-29  Konstantin Tokarev  <annulen@yandex.ru>
2836
2837         Reviewed by Eric Seidel.
2838
2839         [Qt] Fixed compatibility with gold linker on X11 platforms
2840         https://bugs.webkit.org/show_bug.cgi?id=51700
2841
2842         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2843         Linked TestNetscapePlugin with libX11 on Unix platforms
2844
2845 2010-12-29  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>
2846
2847         Reviewed by Darin Adler.
2848
2849         Circular dependency in webkitpy.common.checkout.changelog module
2850         https://bugs.webkit.org/show_bug.cgi?id=50475
2851
2852         Remove automatic import of api.Checkout module when any checkout/
2853         submodule is imported (e.g.: when checkout.scm.Git is imported).
2854
2855         * Scripts/webkitpy/common/checkout/__init__.py:
2856
2857 2010-12-29  Martin Robinson  <mrobinson@igalia.com>
2858
2859         Reviewed by Ojan Vafai.
2860
2861         prepare-ChangeLog should support the -g option for specifying the git-commit
2862         https://bugs.webkit.org/show_bug.cgi?id=51708
2863
2864         Add a -g shortcut for the --git-commit prepare-ChangeLog option. This matches
2865         webkit-patch, though the exact meaning of the two options remain different.
2866
2867         * Scripts/prepare-ChangeLog: Add -g.
2868
2869 2010-12-29  Kent Hansen  <kent.hansen@nokia.com>
2870
2871         Reviewed by Simon Hausmann.
2872
2873         [Qt] Fix compilation with Qt in namespace
2874         https://bugs.webkit.org/show_bug.cgi?id=51701
2875
2876         * QtTestBrowser/webview.h:
2877
2878 2010-12-28  Daniel Bates  <dbates@rim.com>
2879
2880         Reviewed by Sam Weinig.
2881
2882         Substitute // MARK: for compiler-specific #pragma mark
2883         https://bugs.webkit.org/show_bug.cgi?id=51657
2884
2885         Fix future compilation warnings about "#pragma mark" on GTK+ bots by
2886         substituting  "// MARK:" for "#pragma mark", which provides
2887         analogous code-bookmarking functionality under Xcode.
2888
2889         Also, for consistency, we should substitute "// MARK:" for compiler-
2890         specific "#pragma mark" in the source files for the Mac port.
2891
2892         * DumpRenderTree/AccessibilityTextMarker.cpp:
2893         * DumpRenderTree/cf/WebArchiveDumpSupport.h:
2894         * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm:
2895         * DumpRenderTree/mac/ObjCController.m:
2896         * MiniBrowser/mac/AppDelegate.m:
2897         * MiniBrowser/mac/BrowserWindowController.m:
2898
2899 2010-12-28  Xan Lopez  <xlopez@igalia.com>
2900
2901         Reviewed by Eric Seidel.
2902
2903         Add --no-build option to run-sunspider
2904         https://bugs.webkit.org/show_bug.cgi?id=51658
2905
2906         * Scripts/run-sunspider: add --no-build flag to skip building
2907         phase.
2908
2909 2010-12-27  Daniel Bates  <dbates@rim.com>
2910
2911         Rubber-stamped by Martin Robinson.
2912
2913         Append the directory Tools/DumpRenderTree to the list of directories that
2914         do-webcore-rename should search so that it can rename DRT files and
2915         source code.
2916
2917         * Scripts/do-webcore-rename:
2918
2919 2010-12-27  Eric Seidel  <eric@webkit.org>
2920
2921         Reviewed by Adam Barth.
2922
2923         build-webkit should detect missing Java SDK and explain how to install it
2924         https://bugs.webkit.org/show_bug.cgi?id=51651
2925
2926         * Scripts/build-webkit:
2927
2928 2010-12-26  Martin Robinson  <mrobinson@igalia.com>
2929
2930         Reviewed by Daniel Bates.
2931
2932         [GTK] Add support for build-jsc
2933         https://bugs.webkit.org/show_bug.cgi?id=51625
2934
2935         Add GTK+ support to build-jsc now that building the jsc executable as
2936         a standalone target is easy.
2937
2938         * Scripts/build-jsc: Call buildGtkProject for the GTK+ case now.
2939         * Scripts/build-webkit: Pass in the proper target name to buildGtkProject.
2940         * Scripts/webkitdirs.pm: Actually process the project parameter in buildGtkProject
2941         and pass it along to buildAutotoolsProject.
2942
2943 2010-12-27  David Levin  <levin@chromium.org>
2944
2945         Reviewed by Eric Seidel.
2946
2947         check-webkit-style check for meaningless variable names in function declarations.
2948         https://bugs.webkit.org/show_bug.cgi?id=51523
2949
2950         * Scripts/webkitpy/style/checker.py: Exempted JavaScriptCore/jit/JITStubs.cpp
2951         from the new check and whitespace/parens because the syntax is unusual and
2952         produced a fair number of positives for these checks.
2953         * Scripts/webkitpy/style/checkers/cpp.py:
2954         (_convert_to_lower_with_underscores): Used as a canonical form for type names
2955         and parameter names when determining if the parameter name is useless.
2956         (_create_acronym): Used to check for redundant variable names in cases like "ExceptionCode ec"
2957         (Parameter.lower_with_underscores_name): Gives back the parameter name in a lower_with_underscore
2958         format.
2959         (_check_parameter_name_against_text):  Checks to see if the parameter name is in the
2960         text or an acronym of it.
2961         (check_function_definition): Checks function definitions for meaningless variable names.
2962         (process_line): Added call to check_function_definition.
2963         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2964         (CppFunctionsTest.test_convert_to_lower_with_underscores): Test for _convert_to_lower_with_underscores.
2965         (CppFunctionsTest.test_create_acronym): Test for _create_acronym.
2966         (CppFunctionsTest.test_check_parameter_against_text): Test for _check_parameter_against_text.
2967         (CppStyleTestBase.perform_single_line_lint): Removed the parameter name check
2968         because when only checking a snippet, there are a lot of bogus functions.
2969         (CppStyleTestBase.perform_multi_line_lint): Ditto and removed a bogus filter
2970         that I put there previously and just noticed.
2971         (WebKitStyleTest.test_parameter_names): Tests for the functionality -- both
2972         check_function_definition and process_line.
2973
2974 2010-12-27  Carlos Garcia Campos  <cgarcia@igalia.com>
2975
2976         Reviewed by Martin Robinson.
2977
2978         [GTK] Disable flash plugin in GtkLauncher when using gtk3
2979         https://bugs.webkit.org/show_bug.cgi?id=51591
2980
2981         Flash plugin uses gtk2 that is incompatible with gtk3 making
2982         webkit crash when it's built with gtk3.
2983
2984         * GtkLauncher/main.c:
2985         (main):
2986
2987 2010-12-25  Adam Barth  <abarth@webkit.org>
2988
2989         Reviewed by Eric Seidel.
2990
2991         Move ANGLE to Sources/ThirdParty
2992         https://bugs.webkit.org/show_bug.cgi?id=51605
2993
2994         * Scripts/build-webkit:
2995           - Point to the new ANGLE location.
2996
2997 2010-12-26  David Levin  <levin@chromium.org>
2998
2999         Reviewed by Eric Seidel.
3000
3001         check-webkit-style should be able to parse function declaration parameters.
3002         https://bugs.webkit.org/show_bug.cgi?id=51451
3003
3004         * Scripts/webkitpy/style/checkers/cpp.py:
3005         (Position.__init__): Holds simple position information (row, column).
3006         (Parameter.__init__): Holds information about a parameter.
3007         (SingleLineView.__init): Converts multiple lines into a single line for simpler searches.
3008         (SingleLineView.convert_column_to_row): Returns the original row given a column.
3009         (create_skeleton_parameters): Simplifies a parameter list for easier searching.
3010         (find_parameter_name_index): Finds where the parameter name is.
3011         (parameter_list): Generates the list of parameters for a function.
3012         (_FunctionState.begin): Added information to allow determining the parameters
3013         on demand.
3014         (_FunctionState.get_parameter_list): Returns a tuple of function parameters.
3015         (detect_functions): Improve function detection for operator functions and
3016         determine where the parameters end and pass that to _FunctionState.begin.
3017         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3018         (CppFunctionsTest.test_parameter): Verifies Parameter functionality.
3019         (CppFunctionsTest.test_single_line_view): Verifies SingleLineView functionality.
3020         (CppFunctionsTest.test_create_skeleton_parameters): Verifies create_skeleton_parameters.
3021         (CppFunctionsTest.test_find_parameter_name_index): Verifies find_parameter_name_index.
3022         (CppFunctionsTest.test_parameter_list): Does some minimal verification for parameter list.
3023         Much more thorough verification is done as part of FunctionDetectionTest.test_parameter_list.
3024         (FunctionDetectionTest.perform_function_detection): Added support for verifying
3025         the parameters found.
3026         (FunctionDetectionTest.test_function_declaration_detection): Added more function
3027         detection test to verify that we catch the operator functions.
3028         (FunctionDetectionTest.test_ignore_macros): Verify that function detection ignores macros.
3029         (FunctionDetectionTest.test_parameter_list): Added tests to verify the parameter parsing.
3030         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_bad_test_doesnt_break): Removed
3031         because the error. The test is about the bad function name. Fixing the name makes the test exactly like
3032         test_function_length_check_definition_severity1_for_test.
3033
3034 2010-12-25  Patrick Gansterer  <paroga@webkit.org>
3035
3036         Unreviewed WinCE buildfix after r74334.
3037
3038         * CMakeListsWinCE.txt:
3039
3040 2010-12-24  Sheriff Bot  <webkit.review.bot@gmail.com>
3041
3042         Unreviewed, rolling out r74632.
3043         http://trac.webkit.org/changeset/74632
3044         https://bugs.webkit.org/show_bug.cgi?id=51600
3045
3046         makes test-webkitpy hang forever on GTK (Requested by philn-tp
3047         on #webkit).
3048
3049         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
3050         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
3051
3052 2010-12-24  Ryuan Choi  <ryuan.choi@samsung.com>
3053
3054         Reviewed by Kenneth Rohde Christiansen.
3055
3056         [EFL] Screen doesn't be rendered when changing size of EWebLauncher
3057         https://bugs.webkit.org/show_bug.cgi?id=43528
3058
3059         Remove on_resize because ewk_view_fixed_layout_size_set should not be
3060         called on callback of EVAS_CALLBACK_RESIZE. As it change size of
3061         FrameView, rendering was ignored when _ewk_view_smart_calculate was
3062         called.
3063
3064         * EWebLauncher/main.c:
3065         (browserCreate):
3066
3067 2010-12-24  Eric Seidel  <eric@webkit.org>
3068
3069         Reviewed by Adam Barth.
3070
3071         webkit-patch (or a pre-commit hook) needs to prevent bad ChangeLog changes
3072         https://bugs.webkit.org/show_bug.cgi?id=28291
3073
3074         This is a start.  At least now webkit-patch will prompt when your ChangeLog looks questionable.
3075         We could do more advanced things, like parsing the ChangeLog (with changelog.py) and comparing that
3076         to strings with find in the diff.
3077         Since non-interactive always returns the default, this should cause patches with bad changelogs to fail on the commit-queue.
3078
3079         * Scripts/webkitpy/common/checkout/api.py:
3080         * Scripts/webkitpy/common/checkout/diff_parser.py:
3081         * Scripts/webkitpy/tool/steps/abstractstep.py:
3082         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
3083         * Scripts/webkitpy/tool/steps/validatechangelogs.py: Copied from Tools/Scripts/webkitpy/tool/steps/validatereviewer.py.
3084         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py: Copied from Tools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.
3085         * Scripts/webkitpy/tool/steps/validatereviewer.py:
3086
3087 2010-12-24  Dirk Pranke  <dpranke@chromium.org>
3088
3089         Reviewed by Kenneth Russell.
3090
3091         Modify new-run-webkit-tests to shut up and exit when all the threads
3092         are wedged so that test runs complete faster and we don't end up
3093         w/ enormous log files.
3094
3095         https://bugs.webkit.org/show_bug.cgi?id=51572
3096
3097         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
3098         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
3099
3100 2010-12-24  Eric Seidel  <eric@webkit.org>
3101
3102         Reviewed by David Levin.
3103
3104         commit-queue should better explain how it will re-open bugs and follow duplicate chains
3105         https://bugs.webkit.org/show_bug.cgi?id=51549
3106
3107         I've had multiple people ask me about the commit-queue's behavior
3108         regarding reporting flaky tests.  I figured it would be best to just
3109         have the queue explain itself in the bugs it files.
3110
3111         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3112         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3113
3114 2010-12-24  Shinichiro Hamaji  <hamaji@chromium.org>
3115
3116         Reviewed by Eric Seidel.
3117
3118         check-webkit-style: should ignore "wrong" namings in JavaScriptCore/qt
3119         https://bugs.webkit.org/show_bug.cgi?id=51467
3120
3121         * Scripts/webkitpy/style/checker.py:
3122         * Scripts/webkitpy/style/checker_unittest.py:
3123
3124 2010-12-23  Adam Barth  <abarth@webkit.org>
3125
3126         Rubber-stamped by Eric Seidel.
3127
3128         Move JavaScriptGlue into Sources
3129         https://bugs.webkit.org/show_bug.cgi?id=51583
3130
3131         These tools refer to JavaScriptGlue and need to be updated to its new
3132         location.
3133
3134         * Scripts/build-webkit:
3135         * Scripts/do-file-rename:
3136         * Scripts/do-webcore-rename:
3137         * Scripts/webkitpy/common/config/build.py:
3138         * Scripts/webkitpy/common/config/build_unittest.py:
3139
3140 2010-12-23  Lucas Forschler  <lforschler@apple.com>
3141
3142         Reviewed by Eric Seidel.
3143
3144         Bug 51539 - update iexploder scripts to point to new location
3145
3146         * Scripts/run-iexploder-tests:
3147         * Scripts/update-iexploder-cssproperties:
3148
3149 2010-12-23  Evan Martin  <evan@chromium.org>
3150
3151         Reviewed by Ryosuke Niwa.
3152
3153         [chromium] LayoutTestController warning in float->int conversion
3154         https://bugs.webkit.org/show_bug.cgi?id=51553
3155
3156         Rather than reading an int, converting to a float, then getting a compiler
3157         warning on passing the float to something that expects an int, instead
3158         just pass around ints.
3159
3160         No tests, fixes a compiler warning.
3161
3162         * DumpRenderTree/chromium/LayoutTestController.cpp:
3163         (parsePageSizeParameters):
3164         (LayoutTestController::pageNumberForElementById):
3165         (LayoutTestController::numberOfPages):
3166
3167 2010-12-23  Lucas Forschler  <lforschler@apple.com>
3168
3169         Reviewed by Darin Adler.
3170
3171         Bug 51537 - iexploder needs cleanup
3172         
3173         * iExploder/htdocs: Removed.
3174         * iExploder/htdocs/config.rb: Removed.
3175         * iExploder/htdocs/cssproperties.in: Removed.
3176         * iExploder/htdocs/cssvalues.in: Removed.
3177         * iExploder/htdocs/htmlattrs.in: Removed.
3178         * iExploder/htdocs/htmltags.in: Removed.
3179         * iExploder/htdocs/htmlvalues.in: Removed.
3180         * iExploder/htdocs/iexploder.cgi: Removed.
3181         * iExploder/htdocs/iexploder.rb: Removed.
3182         * iExploder/htdocs/index.html: Removed.
3183         * iExploder/htdocs/webserver.rb: Removed.
3184         * iExploder/iexploder-1.7.2/output: Removed.
3185         * iExploder/tools: Removed.
3186         * iExploder/tools/lasthit.rb: Removed.
3187         * iExploder/tools/osx_last_crash.rb: Removed.
3188         * iExploder/tools/showtest.rb: Removed.
3189
3190 2010-12-23  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
3191
3192         Reviewed by Kenneth Rohde Christiansen.
3193
3194         [EFL] Make 'single' the default backing store in EWebLauncher
3195         https://bugs.webkit.org/show_bug.cgi?id=51534
3196
3197         'single' is the simplest backing store and the one intended to be the
3198         default in the test browser. By mistake the tiled backing store was
3199         left as default in r72617.
3200
3201         * EWebLauncher/main.c:
3202         (browserCreate): ditto.
3203
3204 2010-12-23  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
3205
3206         Reviewed by Kenneth Rohde Christiansen.
3207
3208         [EFL] Subject: [webkit 4/4] [EFL] Remove non-sense workaround
3209         https://bugs.webkit.org/show_bug.cgi?id=51533
3210
3211         There's no point in concatenating env("HOME") with "blah", so remove
3212         option from EWebLauncher.
3213
3214         * EWebLauncher/main.c:
3215         (main): ditto.
3216
3217 2010-12-23  Ilya Tikhonovsky  <loislo@chromium.org>
3218
3219         Reviewed by Eric Seidel.
3220
3221         Web Inspector: chromium: inspector's tests are quite slow especially at windows(Debug).
3222
3223         Almost all inspector's tests become flaky on chromium Win(dbg) after switching to DRT.
3224         I just discovered that we have two additional GC runs per each WebViewHost.
3225         Test_shell had no such calls.
3226         These gc runs eat 15% of cpu time.
3227
3228         https://bugs.webkit.org/show_bug.cgi?id=51479
3229
3230         * DumpRenderTree/chromium/WebViewHost.cpp:
3231         (WebViewHost::~WebViewHost):
3232
3233 2010-12-22  Dirk Pranke  <dpranke@chromium.org>
3234
3235         Reviewed by Ojan Vafai.
3236
3237         This change splits out the TestRunner class into its own file.
3238         When we fork the code for message passing, we will create a new
3239         TestRunner, and this change will allow that to be more modular.
3240
3241         While we're at it, split out TestInput and ResultSummary into
3242         their own files, to reduce the size of run_webkit_tests to
3243         something more managable.
3244
3245         https://bugs.webkit.org/show_bug.cgi?id=51092
3246
3247         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
3248         * Scripts/webkitpy/layout_tests/layout_package/result_summary.py:
3249         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
3250         * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
3251         * Scripts/webkitpy/layout_tests/layout_package/test_input.py:
3252         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3253         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3254
3255  2010-12-22  Dirk Pranke  <dpranke@chromium.org>
3256
3257         Reviewed by Ojan Vafai.
3258
3259         nrwt multiprocessing - start over, prepare to fork the code
3260  
3261         This code cleans up the signatures and implementation of the
3262         TestRunner class so we can easily fork it to run either the
3263         stable implementation or the new, unstable message-passing
3264         implementation. The two variants will have different
3265         implementations of the run_tests() method. We will switch
3266         between the two based on the setting for the '--worker-model'
3267         switch. We rename the two currently valid values to 'old-inline'
3268         and 'old-threads'.
3269
3270         https://bugs.webkit.org/show_bug.cgi?id=51081
3271
3272         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3273         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3274
3275 2010-12-22  Victor Wang  <victorw@chromium.org>
3276
3277         Reviewed by Darin Fisher.
3278
3279         [Chromium] Update chromium archive test result url in rebaseline script.
3280
3281         https://bugs.webkit.org/show_bug.cgi?id=51503
3282
3283         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
3284
3285 2010-12-22  Lucas Forschler  <lforschler@apple.com>
3286
3287         Reviewed by Alice Liu.
3288
3289         <rdar://problem/8633222> record-memory-win needs to record memory used by the webprocess.
3290         Verified on Chrome, Safari, and IE.
3291         With this change, we will record memory from a parent browser window and all child processes.
3292
3293         * record-memory-win/main.cpp:
3294         (ProcessArgs):
3295         (PrintUsage):
3296         (getMemoryInfo):
3297         (printProcessInfo):
3298         (evalProcesses):
3299         (UseImage):
3300         (QueryContinuously):
3301         (ElapsedTime):
3302
3303 2010-12-22  Lucas Forschler  <lforschler@apple.com>
3304
3305         Unreviewed rollout r74489, because it was missing changelog.
3306
3307         * record-memory-win/main.cpp:
3308         
3309 2010-12-22  Ryosuke Niwa  <rniwa@webkit.org>
3310
3311         Adding myself as a reviewer.
3312
3313         * Scripts/webkitpy/common/config/committers.py:
3314
3315 2010-12-22  Andrew Scherkus  <scherkus@chromium.org>
3316
3317         Unreviewed.  Adding myself to committers.py.
3318
3319         * Scripts/webkitpy/common/config/committers.py:
3320
3321 2010-12-22  Ariya Hidayat  <ariya@sencha.com>
3322
3323         Reviewed by Kenneth Rohde Christiansen.
3324
3325         TestNetscapePlugIn should use #if defined
3326         https://bugs.webkit.org/show_bug.cgi?id=51471
3327
3328         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3329         (NP_Initialize):
3330         (NPP_New):
3331
3332 2010-12-22  Ilya Tikhonovsky  <loislo@chromium.org>
3333
3334         Reviewed by Yury Semikhatsky.
3335
3336         Web Inspector: [chromium] DRT inspector layout tests are flaky in debug.
3337
3338         DevTools window should be closed explicitly because it has custom deinitialization code.
3339
3340         https://bugs.webkit.org/show_bug.cgi?id=50722
3341
3342         * DumpRenderTree/chromium/TestShell.cpp:
3343         (TestShell::closeRemainingWindows):
3344
3345 2010-12-22  David Levin  <levin@chromium.org>
3346
3347         Reviewed by Shinichiro Hamaji.
3348
3349         check-webkit-style shouldn't complaint about underscores in variables in objective C files.
3350         https://bugs.webkit.org/show_bug.cgi?id=51452
3351
3352         * Scripts/webkitpy/style/checkers/cpp.py:
3353         (_FileState.__init__): Added the information to determine if a file is C or Objective C.
3354         Using the file extension if possible but falling back to the file contents if we have a header file.
3355         (_FileState.is_objective_c): Determine if we have an Objective C by examining the file contents if needed.
3356         (_FileState.is_c_or_objective_c):
3357         (check_using_std): Changed to using _FileState to determine the file type.
3358         (check_max_min_macros): Ditto.
3359         (check_for_null): Ditto.
3360         (check_style): Changed the parameters to various calls since they now need _FileState
3361         to determine the file type.
3362         (check_language): Added the file_state parameter so it could be passed
3363         to check_identifier_name_in_declaration.
3364         (check_identifier_name_in_declaration): Don't warn about underscores in variables if
3365         this is an Objective C file.
3366         (_process_lines): Added information for the _FileState constructor (and moved the
3367         call to a place that had the information).
3368         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3369         (CppFunctionsTest.test_is_c_or_objective_c): Changed the tests to use FileState and exercise
3370         its functionality.
3371         (WebKitStyleTest.test_names): Add tests for underscores in Objective C files.
3372
3373 2010-12-21  Andy Estes  <aestes@apple.com>
3374
3375         Reviewed by Mark Rowe.
3376
3377         Do not build non-Intel architectures for WebKit2-related projects.
3378         https://bugs.webkit.org/show_bug.cgi?id=51440
3379
3380         * MiniBrowser/Configurations/Base.xcconfig: Only build for i386 and x86_64.
3381         * TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
3382         * WebKitTestRunner/Configurations/Base.xcconfig: Ditto.
3383
3384 2010-12-21  Mihai Parparita  <mihaip@chromium.org>
3385
3386         Reviewed by Darin Fisher.
3387
3388         [Chromium] Rename WebThemeEngine/ControlDRT to WebThemeEngine/ControlDRTWin
3389         https://bugs.webkit.org/show_bug.cgi?id=51406 
3390         
3391         Rename WebThemeControlDRT to WebThemeControlDRTWin and WebThemeEngineDRT
3392         to WebThemeEngineDRTWin and update references everywhere.
3393
3394         * DumpRenderTree/DumpRenderTree.gypi:
3395         * DumpRenderTree/chromium/TestShellWin.cpp:
3396         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRT.cpp.
3397         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRT.h.
3398         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRT.cpp.
3399         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRT.h.
3400
3401 2010-12-21  Anders Carlsson  <andersca@apple.com>
3402
3403         Reviewed by John Sullivan.
3404
3405         Clicking missing plug-in text does not show a sheet
3406         https://bugs.webkit.org/show_bug.cgi?id=51403
3407
3408         Update for changes to the WebPageUIClient.
3409
3410         * MiniBrowser/mac/BrowserWindowController.m:
3411         (-[BrowserWindowController awakeFromNib]):
3412         * WebKitTestRunner/TestController.cpp:
3413         (WTR::createOtherPage):
3414         (WTR::TestController::initialize):
3415
3416 2010-12-21  Eric Seidel  <eric@webkit.org>
3417
3418         Reviewed by Adam Barth.
3419
3420         commit-queue will report constant failures as flaky if other tests flake
3421         https://bugs.webkit.org/show_bug.cgi?id=51272
3422
3423         This patch just removes functionality and adds testing.
3424         Previously we attempted to report flaky tests when we had
3425         two different tests fail in a row.  However, since we stop
3426         running the tests at the first failure, our code was wrong in
3427         trying to determine flakiness from the incomplete runs.
3428
3429         Originally I posted an alternate patch:
3430         https://bug-51272-attachments.webkit.org/attachment.cgi?id=77078
3431         which fixed our flaky logic in this case, however it was decided
3432         that that patch would be too difficult to maintain, so now
3433         I'm just removing the broken logic.
3434
3435         This will dramatically cut-down on our flaky-test false positives
3436         at the (small) cost of the queues being unable to report
3437         any flakiness if the tree is very flaky.  (With at least one test
3438         flaking on every run, we'll never report failures anymore.)  I think
3439         this is a tradeoff worth making.
3440
3441         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3442         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3443
3444 2010-12-20  Eric Seidel  <eric@webkit.org>
3445
3446         Reviewed by Adam Barth.
3447
3448         commit-queue wrongly rejects patches when it can't update itself
3449         https://bugs.webkit.org/show_bug.cgi?id=46636
3450
3451         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3452         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3453         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3454
3455 2010-12-20  Adam Barth  <abarth@webkit.org>
3456
3457         Move web sites to Websites directory
3458         https://bugs.webkit.org/show_bug.cgi?id=51323
3459
3460         Update references to BugsSite to point to the new location.
3461
3462         This patch was never officially reviewed (because it was too large to
3463         upload to bugs.webkit.org), but it was discussed on webkit-dev and Mark
3464         Rowe gave me the green light.
3465
3466         * Scripts/old-run-webkit-tests:
3467         * Scripts/webkitpy/common/config/build.py:
3468         * Scripts/webkitpy/common/config/build_unittest.py:
3469         * Scripts/webkitpy/common/prettypatch.py:
3470         * Scripts/webkitpy/layout_tests/port/base.py:
3471         * Scripts/webkitpy/style/main.py:
3472
3473 2010-12-20  Adrienne Walker  <enne@google.com>
3474
3475         Unreviewed. Adding myself to the list of committers.
3476
3477         * webkitpy/common/config/committers.py:
3478
3479 2010-12-20  Mark Rowe  <mrowe@apple.com>
3480
3481         Reviewed by Dan Bernstein.
3482
3483         <rdar://problem/8757601> Don't install header files in to the Resources directory.
3484
3485         * Scripts/check-for-inappropriate-files-in-framework: Don't allow .h files in the
3486         Resources directory.
3487
3488 2010-12-20  Eric Seidel  <eric@webkit.org>
3489
3490         Reviewed by Adam Barth.
3491
3492         commit-queue should include bot id when attaching failure diffs
3493         https://bugs.webkit.org/show_bug.cgi?id=51280
3494
3495         This is a tiny change to include the bot id in the name of the attachment.
3496         Most of this diff is just changing the unit test expectations
3497         now that I hid the comment printing when the comment is None.
3498
3499         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3500         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3501         * Scripts/webkitpy/tool/commands/upload_unittest.py:
3502         * Scripts/webkitpy/tool/mocktool.py:
3503
3504 2010-12-20  Jeff Miller  <jeffm@apple.com>
3505
3506         Reviewed by Dan Bernstein.
3507
3508         Tools/vcbin/midl.exe needs to be rebuilt
3509         https://bugs.webkit.org/show_bug.cgi?id=51347
3510
3511         * vcbin/midl.exe: Rebuilt.
3512
3513 2010-12-20  David Levin  <levin@chromium.org>
3514
3515         Reviewed by Ariya Hidayat.
3516
3517         .gitignore and webkit-tools-completion.sh have references to WebKitTools that should be Tools.
3518         https://bugs.webkit.org/show_bug.cgi?id=51343
3519
3520         Follow up from the WebKitTools -> Tools rename.
3521
3522         * Scripts/webkit-tools-completion.sh:
3523
3524 2010-12-20  Cosmin Truta  <ctruta@chromium.org>
3525
3526         Reviewed by James Robinson.
3527
3528         new-run-webkit-tests ignores trailing EOL differences in text tests
3529         https://bugs.webkit.org/show_bug.cgi?id=36983
3530
3531         Changed the handling of new-line characters within new-run-webkit-tests
3532         to match old-run-webkit-tests.  Differences in leading and trailing empty
3533         lines in text expectation files are no longer ignored.
3534
3535         * Scripts/webkitpy/layout_tests/port/base.py:
3536         * Scripts/webkitpy/layout_tests/port/test.py:
3537         Added unit tests.  Removed old duplicate unit test entries.
3538         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
3539
3540 2010-12-20  David Levin  <levin@chromium.org>
3541
3542         Reviewed by Shinichiro Hamaji.
3543
3544         check-webkit-style should detect function declarations (and trivial functions).
3545         https://bugs.webkit.org/show_bug.cgi?id=51303
3546
3547         * Scripts/webkitpy/style/checkers/cpp.py:
3548         (_FunctionState.begin): Add is_declaration and changed the line count
3549         start to begin at -1 (which will keep the results consistent, since
3550         the starting line number passed in is one less in this change).
3551         (detect_functions): changed function detection to now catch trivial
3552         functions and declarations.
3553         (check_pass_ptr_usage): Don't check for Pass*Ptr on the first line
3554         of the function as this may look at return values (when processing
3555         a declaration).
3556         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3557         (FunctionDetectionTest.perform_function_detection): Basic mechanics
3558         of testing the function detection.
3559         (FunctionDetectionTest.test_basic_function_detection): Test a simple
3560         function.
3561         (FunctionDetectionTest.test_function_declaration_detection): Test a
3562         declaration.
3563         (FunctionDetectionTest.test_non_functions): A test case for a case
3564         that caused the code to fail due to the { being in quotes.
3565         (PassPtrTest.test_pass_ref_ptr_return_value): Added some more test
3566         cases to help catch false alarms for return values.
3567         (PassPtrTest.test_pass_ref_ptr_member_variable): Ensure that
3568         we don't get false alarms for member variables either.
3569
3570 2010-12-20  Ryuan Choi  <ryuan.choi@samsung.com>
3571
3572         Reviewed by Antonio Gomes.
3573
3574         [CMAKE] Rename WEBKITTOOLS_DIR to TOOLS_DIR
3575         https://bugs.webkit.org/show_bug.cgi?id=51319
3576
3577         * CMakeListsEfl.txt:
3578
3579 2010-12-18  Adam Barth  <abarth@webkit.org>
3580
3581         Reviewed by Sam Weinig.
3582
3583         Move WebKitExamplePlugins to Examples
3584         https://bugs.webkit.org/show_bug.cgi?id=51291
3585
3586         * Scripts/webkitpy/common/config/build.py:
3587
3588 2010-12-17  Csaba Osztrogonác  <ossy@webkit.org>
3589
3590         Unreviewed Qt buildfix after r74301.
3591
3592         Rename WebKitTools to Tools
3593         https://bugs.webkit.org/show_bug.cgi?id=49861
3594
3595         * MiniBrowser/DerivedSources.pro:
3596         * MiniBrowser/qt/MiniBrowser.pro:
3597
3598 2010-12-17  Dan Bernstein  <mitz@apple.com>
3599
3600         Reviewed by Simon Fraser.
3601
3602         Rename WebKitTools to Tools
3603         https://bugs.webkit.org/show_bug.cgi?id=49861
3604
3605         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3606         * CodeCoverage/README:
3607         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3608         (WebCore::DumpRenderTree::initializeFonts):
3609         * EWSTools/start-commit-queue.sh:
3610         * EWSTools/start-queue.sh:
3611         * GNUmakefile.am:
3612         * MIDLWrapper/MIDLWrapper.cpp:
3613         (wmain):
3614         * MiniBrowser/qt/MiniBrowser.pro:
3615         * Scripts/build-api-tests:
3616         * Scripts/build-dumprendertree:
3617         * Scripts/build-webkit:
3618         * Scripts/build-webkittestrunner:
3619         * Scripts/generate-coverage-data:
3620         * Scripts/old-run-webkit-tests:
3621         * Scripts/run-api-tests:
3622         * Scripts/run-iexploder-tests:
3623         * Scripts/run-javascriptcore-tests:
3624         * Scripts/run-mangleme-tests:
3625         * Scripts/run-sunspider:
3626         * Scripts/run-webkit-websocketserver:
3627         * Scripts/sunspider-compare-results:
3628         * Scripts/test-webkitperl:
3629         * Scripts/test-webkitpy:
3630         * Scripts/update-iexploder-cssproperties:
3631         * Scripts/update-webkit:
3632         * Scripts/update-webkit-localizable-strings:
3633         * Scripts/webkitdirs.pm:
3634         * Scripts/webkitpy/common/checkout/scm.py:
3635         * Scripts/webkitpy/common/checkout/scm_unittest.py:
3636         * Scripts/webkitpy/common/config/committervalidator.py:
3637         * Scripts/webkitpy/common/config/committervalidator_unittest.py:
3638         * Scripts/webkitpy/common/config/ports.py:
3639         * Scripts/webkitpy/common/config/ports_unittest.py:
3640         * Scripts/webkitpy/common/system/logutils_unittest.py:
3641         * Scripts/webkitpy/common/system/ospath_unittest.py:
3642         * Scripts/webkitpy/layout_tests/port/chromium.py:
3643         * Scripts/webkitpy/layout_tests/port/config.py:
3644         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
3645         * Scripts/webkitpy/layout_tests/port/http_server.py:
3646         * Scripts/webkitpy/layout_tests/port/test.py:
3647         * Scripts/webkitpy/style/checker.py:
3648         * Scripts/webkitpy/style/checker_unittest.py:
3649         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
3650         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3651         * Scripts/webkitpy/tool/steps/steps_unittest.py:
3652         * WebKitTestRunner/DerivedSources.pro:
3653         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
3654         (WTR::activateFonts):
3655         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3656         * wx/build/build_utils.py:
3657
3658 2010-12-16  Antonio Gomes  <agomes@rim.com>
3659
3660         Reviewed by Martin Robinson.
3661
3662         Settings::editingBehaviorType() incorrectly returns mac for the gtk build when running tests
3663         https://bugs.webkit.org/show_bug.cgi?id=51163
3664
3665         Since GTK+'s default editing behavior was changed to UNIX in r70975 (see webkitwebsettings.cpp),
3666         GTK+'s DRT should also reset to UNIX after each test execution.
3667
3668         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3669         (resetDefaultsToConsistentValues):
3670
3671 2010-12-17  David Levin  <levin@chromium.org>
3672
3673         Reviewed by Eric Seidel.
3674
3675         check-webkit-style should understand WTF #include guards
3676         https://bugs.webkit.org/show_bug.cgi?id=44911
3677
3678         * Scripts/webkitpy/style/checkers/cpp.py:
3679         (get_header_guard_cpp_variable): modify to suggest the WTF style
3680         of header guard when appropriate.
3681         (check_for_header_guard): handle multiple return values from
3682         get_header_guard_cpp_variable
3683         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3684         (CppStyleTest.test_build_header_guard): Added tests for the WTF
3685         header style.
3686
3687 2010-12-16  David Levin  <levin@chromium.org>
3688
3689         Reviewed by Eric Seidel.
3690
3691         test-webkitpy: unittest for the xml.py checker displays a decprecation warning.
3692         https://bugs.webkit.org/show_bug.cgi?id=51210
3693
3694         The error only shows up when using python 2.6 or later.
3695
3696         * Scripts/webkitpy/style/checkers/xml.py: Replace the usage of
3697         the decprecated field error,message with something equivalent.
3698
3699 2010-12-16  Mihai Parparita  <mihaip@chromium.org>
3700
3701         Reviewed by Eric Seidel.
3702
3703         Add --exit-after-n-failures/crashes to NRWT
3704         https://bugs.webkit.org/show_bug.cgi?id=51160
3705         
3706         Abort test run (in a similar way to how control-C is handled) when
3707         --exit-after-n-failures/crashes-or-timeouts are passed and we've reached
3708         that number of unexpected failures/crashes/timeouts.
3709
3710         * Scripts/webkitpy/layout_tests/port/test.py:
3711         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3712         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3713
3714 2010-12-16  David Levin  <levin@chromium.org>
3715
3716         Reviewed by Shinichiro Hamaji.
3717
3718         check-webkit-style unit tests has some duplicate boilerplate code.
3719         https://bugs.webkit.org/show_bug.cgi?id=49519
3720
3721         * Scripts/webkitpy/style/checkers/cpp.py:
3722         (update_include_state): Replaced the "io" parameter with the global
3723         configuration _unit_test_config. This allowed not calling into
3724         functions at a low level and also not plumbing through the injection
3725         information through many levels of code.
3726         (check_for_include_what_you_use): Ditto.
3727         (process_file_data): Added the ability to set up the unit test config
3728         to allow for injection.
3729         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3730         (ErrorCollector.__init__): Added support for having a filter for errors.
3731         (ErrorCollector.__call__): Ditto.
3732         (CppStyleTestBase.process_file_data): Added the ability to set unit_test_config.
3733         (CppStyleTestBase.perform_lint): Consolidated logic for the perform functions.
3734         (CppStyleTestBase.perform_single_line_lint): Replace specific calls to
3735         functions in the cpp.py with generic processing and a filter that
3736         indicates what errors should be kept.
3737         (CppStyleTestBase.perform_multi_line_lint): Ditto.
3738         (CppStyleTestBase.perform_language_rules_check): Ditto.
3739         (CppStyleTestBase.perform_function_lengths_check): Ditto.
3740         (CppStyleTestBase.perform_pass_ptr_check): Ditto.
3741         (CppStyleTestBase.perform_include_what_you_use): Ditto.
3742         (CppStyleTest.test_multi_line_comments): Added another
3743         error message which applies to the test case.
3744         (CppStyleTest.test_spacing_for_binary_ops): Fixed test
3745         to not have config.h, since it is processed as a header file.
3746         (CppStyleTest.test_static_or_global_stlstrings): Fixed variable name
3747         style and indentation in checked code.
3748         (OrderOfIncludesTest.test_check_preprocessor_in_include_section):
3749         Fixed line number.
3750         (NoNonVirtualDestructorsTest.test_multi_line_declaration_with_error):
3751         Ditto.
3752
3753 2010-12-15  Sheriff Bot  <webkit.review.bot@gmail.com>
3754
3755         Unreviewed, rolling out r74136.
3756         http://trac.webkit.org/changeset/74136
3757         https://bugs.webkit.org/show_bug.cgi?id=51135
3758
3759         r74136 breaks chromium canary bots because some tests are not
3760         rebaselined correctly to resolve EOL differences (Requested by
3761         jianli on #webkit).
3762
3763         * Scripts/webkitpy/layout_tests/port/base.py:
3764         * Scripts/webkitpy/layout_tests/port/test.py:
3765         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
3766
3767 2010-12-15  Adam Roben  <aroben@apple.com>