b6af7dada2710210c4a44a668feb52d8a284fd79
[WebKit.git] / Tools / ChangeLog
1 2011-09-14  Ada Chan  <adachan@apple.com>
2
3         Add test for WKBundleFrameCopyWebArchive().
4         https://bugs.webkit.org/show_bug.cgi?id=67857
5
6         Reviewed by Anders Carlsson.
7
8         * TestWebKitAPI/Tests/WebKit2/WebArchive.cpp: Added.
9         (TestWebKitAPI::didReceiveMessageFromInjectedBundle): Do some basic sanity checks to make sure
10         the returned data is a valid webarchive.
11         (TestWebKitAPI::setInjectedBundleClient):
12         (TestWebKitAPI::didFinishLoadForFrame):
13         (TestWebKitAPI::TEST): Load simple.html in a WebView.  Wait for it to finish loading, and then ask the
14         injected bundle for the webarchive and check the returned webarchive.
15         * TestWebKitAPI/Tests/WebKit2/WebArchive_Bundle.cpp: Added.
16         (TestWebKitAPI::WebArchiveTest::WebArchiveTest):
17         (TestWebKitAPI::WebArchiveTest::didReceiveMessage): Handle the "GetWebArchive" message and return
18         the web archive.
19
20         Add files to project.
21         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Also let Visual Studio reorder a file.
22         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
23         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
24
25 2011-09-14  Ryosuke Niwa  <rniwa@webkit.org>
26
27         committers.py should support multiple IRC nicknames
28         https://bugs.webkit.org/show_bug.cgi?id=68110
29
30         Reviewed by Eric Seidel.
31
32         Add multiple IRC nickname support to committers.py
33
34         * Scripts/webkitpy/common/config/committers.py:
35         * Scripts/webkitpy/common/config/committers_unittest.py:
36         * Scripts/webkitpy/tool/bot/irc_command.py:
37         * Scripts/webkitpy/tool/bot/sheriff.py:
38
39 2011-09-14  Jon Lee  <jonlee@apple.com>
40
41         Implement globalFlag for WebKitTestRunner
42         https://bugs.webkit.org/show_bug.cgi?id=68033
43         <rdar://problem/10119204>
44
45         Reviewed by Sam Weinig.
46
47         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Porting globalFlag from DRT
48         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
49         (WTR::LayoutTestController::LayoutTestController): initialize m_globalFlag to false
50         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: add m_globalFlag
51         (WTR::LayoutTestController::globalFlag): simple getter
52         (WTR::LayoutTestController::setGlobalFlag): simple setter
53
54 2011-09-13  Eric Seidel  <eric@webkit.org>
55
56         Remove ENABLE_SVG_USE as <use> is required by HTML5
57         https://bugs.webkit.org/show_bug.cgi?id=68019
58
59         Reviewed by Ryosuke Niwa.
60
61         * Scripts/build-webkit:
62         * waf/build/settings.py:
63
64 2011-09-14  Ryosuke Niwa  <rniwa@webkit.org>
65
66         Remove Jan Erik Hanssen (added in my r95078) from the list for now
67         since I can't confirm acceptable his committership.
68
69         * Scripts/webkitpy/common/config/committers.py:
70
71 2011-09-14  Jochen Eisinger  <jochen@chromium.org>
72
73         [chromium] Remove obsolete WebViewClient methods from DumpRenderTree.
74         https://bugs.webkit.org/show_bug.cgi?id=68066
75
76         Reviewed by Adam Barth.
77
78         * DumpRenderTree/chromium/WebViewHost.cpp:
79         * DumpRenderTree/chromium/WebViewHost.h:
80
81 2011-09-13  Ryosuke Niwa  <rniwa@webkit.org>
82
83         committers.py is missing some contributors
84         https://bugs.webkit.org/show_bug.cgi?id=68059
85
86         Reviewed by Adam Barth.
87
88         Add David Barr, Jan Erik Hanssen, and Kim Grönholm.
89
90         Also add nicks of Alejandro G. Castro, Collin Jackson, and Matt Lilek.
91
92         * Scripts/webkitpy/common/config/committers.py:
93
94 2011-09-13  Ryosuke Niwa  <rniwa@webkit.org>
95
96         Fix webkit python test after r95061.
97
98         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
99
100 2011-09-13  Xianzhu Wang  <wangxianzhu@chromium.org>
101
102         Add myself as a contributor. No review needed.
103
104         * Scripts/webkitpy/common/config/committers.py:
105
106 2011-09-13  Adam Barth  <abarth@webkit.org>
107
108         garden-o-matic has unfriendly error messages when the local server is not available
109         https://bugs.webkit.org/show_bug.cgi?id=68042
110
111         Reviewed by Dimitri Glazkov.
112
113         This patch moves us from using alert to showing the error inline in the
114         progress dialog.
115
116         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
117         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
118         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
119         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
120         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
121
122 2011-09-13  Adam Barth  <abarth@webkit.org>
123
124         FailureGrid in garden-o-matic should link to the builder's waterfall page
125         https://bugs.webkit.org/show_bug.cgi?id=68036
126
127         Reviewed by Dimitri Glazkov.
128
129         One of the users in the user study thought the configurations names in
130         the failure grid would link to the underlying bots.  That makes sense,
131         so this patch adds the behavior.
132
133         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
134         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
135         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
136         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
137
138 2011-09-13  Adam Barth  <abarth@webkit.org>
139
140         garden-o-matic should be able to mark failures as expected
141         https://bugs.webkit.org/show_bug.cgi?id=68027
142
143         Reviewed by Dimitri Glazkov.
144
145         All the back-end infrastructure exists for this operation.  This patch
146         just adds some UI to the front-end and wires that UI up to the back
147         end.  This exact UI will likely need some more polish, but this should
148         be a reasonable first cut.
149
150         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
151         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
152         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
153         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
154         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
155
156 2011-09-13  Adam Barth  <abarth@webkit.org>
157
158         garden-o-matic should tell you about the progress of your rebaseline
159         https://bugs.webkit.org/show_bug.cgi?id=67967
160
161         Reviewed by Dimitri Glazkov.
162
163         This patch adds ui.MessageBox, which is a light wrapper around jQuery
164         UI's dialog widget.  We then use ui.MessageBox to show status messages
165         about in-progress rebaselines.  As each baseline is downloaded, the
166         MessageBox updates.  This UI replaces our temporary "alert"-based UI.
167
168         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
169         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
170         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
171         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
172         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
173         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
174
175 2011-09-13  Leandro Pereira  <leandro@profusion.mobi>
176
177         GTK DumpRenderTree uses inefficient idioms to iterate over G[S]Lists
178         https://bugs.webkit.org/show_bug.cgi?id=68024
179
180         Reviewed by Gustavo Noronha Silva.
181         
182         Using g_list_count() and g_list_nth_data() together on a loop is
183         inneficient since they're both O(n). Iterate over lists in a saner
184         way.
185
186         * DumpRenderTree/gtk/DumpRenderTree.cpp:
187         (dumpHistoryItem): Reduce the scope for the 'kids' variable, and
188         iterate on it using g_list_next(). Free the list after done with it.
189         (dumpBackForwardListForWebView): Instead of appending (which is
190         expensive in GLists) history items and then iterating from the tail
191         of the itemsToPrint list, prepend items and walk forwards as usual.
192         (dumpBackForwardListForAllWebViews): Walk the list in a saner way,
193         remove the (unneeded) viewList variable.
194
195 2011-09-13  Ryosuke Niwa  <rniwa@webkit.org>
196
197         Add Eric's IRC nick.
198
199         * Scripts/webkitpy/common/config/committers.py:
200
201 2011-09-13  Anders Carlsson  <andersca@apple.com>
202
203         Disable C++ exceptions when building with clang
204         https://bugs.webkit.org/show_bug.cgi?id=68031
205         <rdar://problem/9556880>
206
207         Reviewed by Mark Rowe.
208
209         * MiniBrowser/Configurations/Base.xcconfig:
210         * TestWebKitAPI/Configurations/Base.xcconfig:
211         * WebKitTestRunner/Configurations/Base.xcconfig:
212
213 2011-09-13  Ojan Vafai  <ojan@chromium.org>
214
215         [chromium] fix flakiness dashboard for chromium interactive tests
216         https://bugs.webkit.org/show_bug.cgi?id=68029
217
218         Reviewed by Tony Chang.
219
220         * TestResultServer/static-dashboards/flakiness_dashboard.html:
221         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
222
223 2011-09-13  Ryosuke Niwa  <rniwa@webkit.org>
224
225         Add Alice and Aryeh to the list of contributors.
226
227         * Scripts/webkitpy/common/config/committers.py:
228
229 2011-09-13  Ryosuke Niwa  <rniwa@webkit.org>
230
231         sheriffbot whois should also tell us email addresses
232         https://bugs.webkit.org/show_bug.cgi?id=67975
233
234         Reviewed by Eric Seidel and David Levin.
235
236         Taught sheriffbot how to tell us contributor's email addresses.
237
238         * Scripts/webkitpy/tool/bot/irc_command.py:
239         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
240
241 2011-09-13  Eric Seidel  <eric@webkit.org>
242
243         Remove ENABLE_SVG_FOREIGN_OBJECT as it is a required part of HTML5
244         https://bugs.webkit.org/show_bug.cgi?id=68018
245
246         Reviewed by Ryosuke Niwa.
247
248         * Scripts/build-webkit:
249         * waf/build/settings.py:
250
251 2011-09-13  Chang Shu  <cshu@webkit.org>
252
253         [WK2] [Mac] Implement KeyDown function for WebKit2 EventSender.
254         https://bugs.webkit.org/show_bug.cgi?id=57515
255
256         The code change in WebKitTestRunner first sends keydown event from InjectedBundle to
257         TestController synchronously. The latter then sends simulated event to WebKit2 module,
258         which is synchronous, too.
259
260         Reviewed by Darin Adler.
261
262         * WebKitTestRunner/EventSenderProxy.h: Added.
263         (WTR::EventSenderProxy::EventSenderProxy):
264         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
265         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
266         (WTR::EventSendingController::keyDown):
267         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
268         * WebKitTestRunner/PlatformWebView.h:
269         (WTR::PlatformWebView::platformWindow):
270         * WebKitTestRunner/TestController.cpp:
271         (WTR::TestController::TestController):
272         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
273         * WebKitTestRunner/TestController.h:
274         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
275         * WebKitTestRunner/mac/EventSenderProxy.mm: Added.
276         (WTR::buildModifierFlags):
277         (WTR::EventSenderProxy::keyDown):
278
279 2011-09-12  Leandro Pereira  <leandro@profusion.mobi>
280
281         [EFL] DRT: Add DumpRenderTreeEfl.h
282         https://bugs.webkit.org/show_bug.cgi?id=63993
283
284         Reviewed by Eric Seidel.
285         
286         This header contains some global variables used by EFL's
287         DumpRenderTree implementation.
288
289         * DumpRenderTree/DumpRenderTree.h: Include DumpRenderTreeEfl.h when
290         appropriate.
291         * DumpRenderTree/efl/DumpRenderTreeEfl.h: Added.
292
293 2011-09-12  Raphael Kubo da Costa  <kubo@profusion.mobi>
294
295         [EFL] Send the right key names for PageUp and PageDown.
296         https://bugs.webkit.org/show_bug.cgi?id=67044
297
298         Reviewed by Kenneth Rohde Christiansen.
299
300         PlatformKeyboardEventEfl uses "Prior" and "Next" to refer to PageUp and
301         PageDown (which is close to the defines in WindowsKeyboardCodes.h).
302         However, EventSender was sending "Page_Up" and "Page_Down", so tests
303         such as editing/input/page-up-down-scrolls.html were timing out due to
304         the right key down events not being sent.
305
306         * DumpRenderTree/efl/EventSender.cpp:
307         (keyPadNameFromJSValue):
308         (keyNameFromJSValue):
309
310 2011-09-12  Eric Seidel  <eric@webkit.org>
311
312         sheriffbot whois is case sensitive
313         https://bugs.webkit.org/show_bug.cgi?id=67972
314
315         Reviewed by Adam Barth.
316
317         I also fixed a typo in the "More than 5 contributors" message
318         from my previous commit.
319
320         * Scripts/webkitpy/common/config/committers.py:
321         * Scripts/webkitpy/common/config/committers_unittest.py:
322         * Scripts/webkitpy/tool/bot/irc_command.py:
323         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
324
325 2011-09-12  Eric Seidel  <eric@webkit.org>
326
327         sheriffbot whois should be smarter
328         https://bugs.webkit.org/show_bug.cgi?id=67971
329
330         Reviewed by Adam Barth.
331
332         This makes sheriffbot whois basically grep the committers list
333         making it much easier to find a contributor by name.
334
335         Unfortunately the current unittests depend on the real committers.py
336         file, so as we add more eric's to the project, this unittest result will
337         change.  I think that's OK for now.  We'll fix it when it breaks.
338
339         * Scripts/webkitpy/common/config/committers.py:
340         * Scripts/webkitpy/tool/bot/irc_command.py:
341         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
342
343 2011-09-12  Sheriff Bot  <webkit.review.bot@gmail.com>
344
345         Unreviewed, rolling out r94976.
346         http://trac.webkit.org/changeset/94976
347         https://bugs.webkit.org/show_bug.cgi?id=67953
348
349         Broke a bunch of security/load& tests (Requested by rniwa on
350         #webkit).
351
352         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
353         (LayoutTestController::pathToLocalResource):
354
355 2011-09-12  Eric Seidel  <eric@webkit.org>
356
357         Rubber-stamped by Adam Barth.
358
359         Remove the "the tree is burning!" warning previously shown
360         when landing patches.  It was a dream.  But it's just noise now.
361
362         Some bots will require a restart to notice the removal of the option
363         so I've left the --ignore-builders option in for now.
364
365         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
366         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
367         * Scripts/webkitpy/tool/commands/download.py:
368         * Scripts/webkitpy/tool/commands/download_unittest.py:
369         * Scripts/webkitpy/tool/commands/queues_unittest.py:
370         * Scripts/webkitpy/tool/steps/__init__.py:
371         * Scripts/webkitpy/tool/steps/commit.py:
372         * Scripts/webkitpy/tool/steps/ensurebuildersaregreen.py: Removed.
373         * Scripts/webkitpy/tool/steps/postdiffforrevert.py:
374
375 2011-09-12  Eric Seidel  <eric@webkit.org>
376
377         [NRWT] REGRESSION: Local loader tests are failing on machines that lost /tmp/LayoutTests symlink
378         https://bugs.webkit.org/show_bug.cgi?id=65781
379
380         Reviewed by Ryosuke Niwa.
381
382         Instead of making NRWT create the symlink, I just made DumpRenderTree smart enough
383         to resolve the passed in url relative to the absolute url for the test.
384
385         I believe this is a better approach than the on used in the Qt and Chromium DRT's
386         (which resolves the path relative to the built location of the DRT executable)
387         and we should move this new code into a shared location in a follow-up patch.
388
389         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
390         (LayoutTestController::pathToLocalResource):
391
392 2011-09-12  Eric Seidel  <eric@webkit.org>
393
394         Reshuffle some code in WebKitDriver._read_block in preparation for reading stderr/stdout separately
395         https://bugs.webkit.org/show_bug.cgi?id=67530
396
397         Reviewed by Adam Barth.
398
399         I believe I've fixed the bug in the original patch which prompted the rollout.
400         The previous patch was using the wrong deadline for the initial read,
401         subtracting time.time() twice from the deadline value.
402
403         * Scripts/webkitpy/layout_tests/port/webkit.py:
404         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
405
406 2011-09-12  Balazs Kelemen  <kbalazs@webkit.org>
407
408         [Qt][WK2] WebKitTestRunner does not produce crash logs
409         https://bugs.webkit.org/show_bug.cgi?id=67714
410
411         Reviewed by Chang Shu.
412
413         Added a simple way of generating backtrace on crash
414         to the web process. The implementation is similar what
415         we have in DRT. It depends on GNU libc functionality
416         so it is only enabled where we are running in such an environment.
417
418         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
419         (WTR::printBacktrace):
420         (WTR::crashHandler):
421         (WTR::InjectedBundle::platformInitialize):
422
423 2011-09-11  Filip Pizlo  <fpizlo@apple.com>
424
425         Added my IRC nick to the committers file.
426
427         * Scripts/webkitpy/common/config/committers.py:
428
429 2011-09-01  Filip Pizlo  <fpizlo@apple.com>
430
431         The executable allocator makes it difficult to free individual
432         chunks of executable memory
433         https://bugs.webkit.org/show_bug.cgi?id=66363
434
435         Reviewed by Oliver Hunt.
436         
437         Introduced a best-fit, balanced-tree based allocator. The allocator
438         required a balanced tree that does not allocate memory and that
439         permits the removal of individual nodes directly (as opposed to by
440         key); neither AVLTree nor WebCore's PODRedBlackTree supported this.
441         Changed all references to executable code to use a reference counted
442         handle.
443
444         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
445         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp: Added.
446         (TestWebKitAPI::TEST_F):
447         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp: Added.
448         (TestWebKitAPI::Pair::findExact):
449         (TestWebKitAPI::Pair::remove):
450         (TestWebKitAPI::Pair::findLeastGreaterThanOrEqual):
451         (TestWebKitAPI::Pair::assertFoundAndRemove):
452         (TestWebKitAPI::Pair::assertEqual):
453         (TestWebKitAPI::Pair::assertSameValuesForKey):
454         (TestWebKitAPI::Pair::testDriver):
455         (TestWebKitAPI::TEST_F):
456
457 2011-09-10  Andy Estes  <aestes@apple.com>
458
459         Move myself from committers_unable_to_review to reviewers_list.
460
461         * Scripts/webkitpy/common/config/committers.py:
462
463 2011-09-10  Kevin Ollivier  <kevino@theolliviers.com>
464
465         [wx] Unreviewed build fix. MSW build fixes.
466
467         * DumpRenderTree/config.h:
468         * waf/build/wxpresets.py:
469
470 2011-09-10  Andreas Kling  <kling@webkit.org>
471
472         Crash beneath WKURLIsEqual() when reloading in MiniBrowser.
473         https://bugs.webkit.org/show_bug.cgi?id=59328
474
475         Reviewed by Kenneth Rohde Christiansen.
476
477         * MiniBrowser/mac/BrowserWindowController.m:
478         (-[BrowserWindowController updateProvisionalURLForFrame:]): Add missing null check.
479
480 2011-09-10  Adam Barth  <abarth@webkit.org>
481
482         Build fix for Android.  DumpRenderTree is a client of the WebKit API
483         and does not have access to notImplemented().
484
485         * DumpRenderTree/chromium/TestShellAndroid.cpp:
486         (openStartupDialog):
487
488 2011-09-09  Alexey Proskuryakov  <ap@apple.com>
489
490         Add a script to create a monolithic script-test
491         https://bugs.webkit.org/show_bug.cgi?id=67747
492
493         Reviewed by Darin Adler.
494
495         * Scripts/make-new-script-test: Added.
496
497 2011-09-09  Luiz Agostini  <luiz@webkit.org>
498
499         Adding myself to the reviewers list.
500
501         * Scripts/webkitpy/common/config/committers.py:
502
503 2011-09-09  Ryosuke Niwa  <rniwa@webkit.org>
504
505         Buildbot may use RunWebKitTest's evaluateCommand on bots that run nrwt
506         https://bugs.webkit.org/show_bug.cgi?id=67855
507
508         Reviewed by Dirk Pranke.
509
510         The bug was caused by the fact some ports use RunWebKitTests instead of NewRunWebKitTests to run tests,
511         and using RunWebKitTests.evaluateCommand after calling _parseNewRunWebKitTestsOutput.
512
513         Fixed the bug by merging evaluateCommand of RunWebKitTests and NewRunWebKitTests.
514
515         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
516
517 2011-09-09  Mark Hahnenberg  <mhahnenberg@apple.com>
518
519         Add myself to committers.py
520         https://bugs.webkit.org/show_bug.cgi?id=67853
521
522         Reviewed by Darin Adler.
523
524         * Scripts/webkitpy/common/config/committers.py:
525
526 2011-09-09  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
527
528         [Qt] Remove common.pri
529         https://bugs.webkit.org/show_bug.cgi?id=67814
530
531         Reviewed by Andreas Kling.
532
533         * Tools.pro:
534
535 2011-09-09  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
536
537         [NRWT] the nrwt check httpd with --no-http option
538         https://bugs.webkit.org/show_bug.cgi?id=67835
539
540         Reviewed by Tony Chang.
541
542         * Scripts/webkitpy/layout_tests/controllers/manager.py:
543         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
544
545 2011-09-09  Hao Zheng  <zhenghao@chromium.org>
546
547         [chromium] Implement DRT support for Android.
548         https://bugs.webkit.org/show_bug.cgi?id=67590
549
550         Reviewed by Tony Chang.
551
552         Add 2 mechanism to make DRT interaction more robust on Android:
553         - Send 'QUIT' to DRT to make it stop.
554         - Wait until receiving '#READY' from DRT, so that DRT won't miss any
555         input commands before it starts.
556         And LayoutTestController.cpp needs to include <cctype> for 'tolower'
557         and <clocale> for 'LC_ALL' to compile on Android.
558
559         Also change to use sigaction instead of signal for TestShellGtk.cpp,
560         as signal() man page recommends using sigaction().
561
562         * DumpRenderTree/DumpRenderTree.gypi:
563         * DumpRenderTree/chromium/DumpRenderTree.cpp:
564         (main):
565         * DumpRenderTree/chromium/LayoutTestController.cpp:
566         * DumpRenderTree/chromium/TestShellAndroid.cpp: Added.
567         (AlarmHandler):
568         (TestShell::waitTestFinished):
569         (platformInit):
570         (openStartupDialog):
571         (checkLayoutTestSystemDependencies):
572         * DumpRenderTree/chromium/TestShellGtk.cpp:
573         (AlarmHandler):
574         (TestShell::waitTestFinished):
575
576 2011-09-09  Kevin Ollivier  <kevino@theolliviers.com>
577
578         [wx] Unreviewed build fix. Add Source/JavaScriptCore/dfg directory to the build.
579
580         * waf/build/settings.py:
581
582 2011-09-09  Sheriff Bot  <webkit.review.bot@gmail.com>
583
584         Unreviewed, rolling out r94851.
585         http://trac.webkit.org/changeset/94851
586         https://bugs.webkit.org/show_bug.cgi?id=67847
587
588         It broke a webkitpy test (Requested by ossy on #webkit).
589
590         * Scripts/webkitpy/layout_tests/controllers/manager.py:
591
592 2011-09-09  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
593
594         [NRWT] the nrwt check httpd with --no-http option
595         https://bugs.webkit.org/show_bug.cgi?id=67835
596
597         Reviewed by Csaba Osztrogonác.
598
599         * Scripts/webkitpy/layout_tests/controllers/manager.py:
600
601 2011-09-08  Brian Weinstein  <bweinstein@apple.com>
602
603         WebKit2: Assertion when calling didPerform*Redirect on null source/destination URL string
604         https://bugs.webkit.org/show_bug.cgi?id=67794
605         <rdar://problem/9892024>
606         
607         Add a test that we don't send a didPerformServerRedirect when a load is cancelled from willSendRequest.
608
609         Reviewed by Brady Eidson.
610
611         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback.cpp: Added.
612         (TestWebKitAPI::didFinishLoadForFrame): Set flags on whether we've loaded the main frame, iframe, or both.
613         (TestWebKitAPI::didPerformServerRedirect): Set a flag for whether we've performed a server redirect.
614         (TestWebKitAPI::TEST): Set up a WKPageLoaderClient and WKContextHistoryClient, and load simple-iframe.html.
615             Once both frames have loaded (main frame and blocked iframe), make sure that we have never called
616             didPerformServerRedirect.
617
618         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback_Bundle.cpp: Added.
619         (TestWebKitAPI::LoadCanceledNoServerRedirectCallbackTest::LoadCanceledNoServerRedirectCallbackTest): Initialize
620             our InjectedBundleTest.
621         (TestWebKitAPI::LoadCanceledNoServerRedirectCallbackTest::willSendRequestForFrame): If we are dealing with a request
622             from the main frame (the main resource in simple-iframe.html), allow it. If not (dealing with the iframe), block
623             the request.
624         (TestWebKitAPI::LoadCanceledNoServerRedirectCallbackTest::didCreatePage): Set up the WKBundlePageResourceLoadClient.
625
626         * TestWebKitAPI/Tests/WebKit2/simple-iframe.html: Added.
627         
628         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
629         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Ditto.
630         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj: Ditto.
631         * TestWebKitAPI/win/copy-resources.cmd: Ditto.
632
633 2011-09-08  David Levin  <levin@chromium.org>
634
635         check-webkit-style: Ref|Own Ptr& should be allowed as a parameter.
636         https://bugs.webkit.org/show_bug.cgi?id=67797
637
638         Reviewed by Eric Seidel.
639
640         * Scripts/webkitpy/style/checkers/cpp.py: Allow Ref/Own Ptr when it ends with &.
641         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added test cases for this.
642
643 2011-09-08  Fady Samuel  <fsamuel@chromium.org>
644
645         Fixed Layout Mode should be adjustable from layoutTestController for testing on Chromium platforms
646         https://bugs.webkit.org/show_bug.cgi?id=67723
647
648         Reviewed by Adam Barth.
649
650         * DumpRenderTree/chromium/EventSender.h:
651         * DumpRenderTree/chromium/LayoutTestController.cpp:
652         (LayoutTestController::LayoutTestController):
653         (LayoutTestController::enableFixedLayoutMode):
654         (LayoutTestController::setFixedLayoutSize):
655         * DumpRenderTree/chromium/LayoutTestController.h:
656
657 2011-09-07  Matthew Delaney  <mdelaney@apple.com>
658
659         Add standalone script that filters the output of build-webkit to be more human-readable
660         https://bugs.webkit.org/show_bug.cgi?id=44081
661
662         Reviewed by Daniel Bates.
663
664         * Scripts/filter-build-webkit: Added. Just need to feed it the output of
665         a build script (e.g. build-webkit) and it spits out a prettier version.
666         * Scripts/VCSUtils.pm: Refactored "possiblyColored" out of run-api-tests into VCSUtils.
667         * Scripts/run-api-tests: Now includes VCSUtils to use "possiblyColored"
668
669 2011-09-07  Noel Gordon  <noel.gordon@gmail.com>
670
671         Add myself to committers.py                 
672         https://bugs.webkit.org/show_bug.cgi?id=67696
673
674         Reviewed by Kent Tamura.
675
676         * Scripts/webkitpy/common/config/committers.py:
677
678 2011-09-07  Adam Barth  <abarth@webkit.org>
679
680         rebaseline button in garden-o-matic details view should work
681         https://bugs.webkit.org/show_bug.cgi?id=67738
682
683         Reviewed by Dimitri Glazkov.
684
685         This patch wires up the rebaseline button in garden-o-matic results
686         details view.  The button is current per-test, so there isn't a way to
687         rebaseline individual bots.  This is a place to start.  If we decide we
688         want per-bot rebaselining, we'll need to think of some better UI.
689
690         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
691         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
692         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
693         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
694
695 2011-09-07  Eric Seidel  <eric@webkit.org>
696
697         Teach the PortFactory object how to pass along executive/user/filesystem to port objects (which fixes the failing rebaseline_test on bots)
698         https://bugs.webkit.org/show_bug.cgi?id=67737
699
700         Reviewed by Adam Barth.
701
702         I got a little over-eager when deprecating host.port_factory in the previous commit.
703         Turns out that Host.port_factory was already the "modern" port/factory.py
704         it was just the Module object.  I un-deprecated the variable, and changed it from
705         being the module to being an actual PortFactory, passing it a host object.
706         I also taught PortFactory how to set user/executive/filesystem in the kwargs
707         when instantiating a new Port object.
708         This magically fixed the test_rebaseline test, since its now no longer talking
709         to the real filesystem.
710
711         * Scripts/webkitpy/common/host.py:
712         * Scripts/webkitpy/layout_tests/port/factory.py:
713         * Scripts/webkitpy/tool/commands/queries.py:
714         * Scripts/webkitpy/tool/mocktool.py:
715
716 2011-09-07  Eric Seidel  <eric@webkit.org>
717
718         Add a new PortFactory class for creating new-style ports and deprecate the old PortFactory
719         https://bugs.webkit.org/show_bug.cgi?id=67734
720
721         Reviewed by Adam Barth.
722
723         Right now every place that creates a Port object has to be very careful
724         to pass in a MockSCM/MockUser/MockFilesystem when appropriate.
725         The correct fix is for port/factory.py (which creates most port objects)
726         to know how to pass these in automatically.  However, currently all port/factory.py
727         functions are free functions instead of being on an object.  This patch
728         adds a new PortFactory object and deprecates the PortFactory for the old-style Port objects.
729
730         In a follow-up patch I will add PortFactory to the Host object and teach PortFactory how to
731         pass along the proper scm/user/filesystem to the Port object.
732
733         * Scripts/webkitpy/common/host.py:
734         * Scripts/webkitpy/layout_tests/port/factory.py:
735         * Scripts/webkitpy/tool/commands/queries.py:
736         * Scripts/webkitpy/tool/mocktool.py:
737
738 2011-09-07  Sheriff Bot  <webkit.review.bot@gmail.com>
739
740         Unreviewed, rolling out r94441.
741         http://trac.webkit.org/changeset/94441
742         https://bugs.webkit.org/show_bug.cgi?id=67731
743
744         "MacEWSes are backed up due to new machines not able to reach
745         git.webkit.org.  Disabling tests for now" (Requested by
746         eseidel2 on #webkit).
747
748         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
749
750 2011-09-07  Elliot Poger  <epoger@google.com>
751
752         filter test_expectations properly for chromium-mac vs chromium-cg-mac
753         https://bugs.webkit.org/show_bug.cgi?id=67324
754
755         Reviewed by Dirk Pranke.
756
757         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
758         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
759         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
760         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
761         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
762
763 2011-09-07  Eric Boren  <borenet@gmail.com>
764
765         [Chromium] Modify WebTouchEvent structure to match WebCore::TouchEvent
766         https://bugs.webkit.org/show_bug.cgi?id=66800
767
768         Reviewed by Darin Fisher.
769
770         * DumpRenderTree/chromium/EventSender.cpp:
771         (EventSender::sendCurrentTouchEvent):
772
773 2011-09-07  Jarred Nicholls  <jarred@sencha.com>
774
775         [Qt][DRT] Normalize file:///tmp/LayoutTests in LayoutTestController::pathToLocalResource()
776         https://bugs.webkit.org/show_bug.cgi?id=67254
777
778         Reviewed by Csaba Osztrogonác.
779
780         Translate file:///tmp/LayoutTests/* urls into the repository LayoutTests directory, which is
781         derived from the running location of DumpRenderTree binary.
782
783         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
784         (LayoutTestController::pathToLocalResource):
785         (LayoutTestController::setUserStyleSheetLocation): pass the url through pathToLocalResource
786
787 2011-09-07  Csaba Osztrogonác  <ossy@webkit.org>
788
789         REGRESSION(r94288) build-webkit doesn't work on Symbian
790         https://bugs.webkit.org/show_bug.cgi?id=67706
791
792         * Scripts/webkitdirs.pm: Disable automatic clean build on Symbian, because it doesn't support shadow build.
793         (buildQMakeProject):
794
795 2011-09-07  Csaba Osztrogonác  <ossy@webkit.org>
796
797         REGRESSION(r94288) build-webkit doesn't work on Windows
798         https://bugs.webkit.org/show_bug.cgi?id=67646
799
800         Roll back r94655 with a small fix.
801
802         * Scripts/webkitdirs.pm:
803         (buildQMakeProject):
804
805 2011-09-07  Sheriff Bot  <webkit.review.bot@gmail.com>
806
807         Unreviewed, rolling out r94635.
808         http://trac.webkit.org/changeset/94635
809         https://bugs.webkit.org/show_bug.cgi?id=67704
810
811         Linux Touch build is failing to compile this change.
812         (Requested by loislo on #webkit).
813
814         * DumpRenderTree/chromium/EventSender.cpp:
815         (EventSender::sendCurrentTouchEvent):
816
817 2011-09-07  Sheriff Bot  <webkit.review.bot@gmail.com>
818
819         Unreviewed, rolling out r94655.
820         http://trac.webkit.org/changeset/94655
821         https://bugs.webkit.org/show_bug.cgi?id=67703
822
823         It broke Leopard debug bot (Requested by ossy on #webkit).
824
825         * Scripts/webkitdirs.pm:
826
827 2011-09-07  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
828
829         REGRESSION(r94288) build-webkit doesn't work on Windows
830         https://bugs.webkit.org/show_bug.cgi?id=67646
831
832         Reviewed by Csaba Osztrogonác.
833
834         * Scripts/webkitdirs.pm:
835
836 2011-09-06  Eric Boren  <borenet@gmail.com>
837
838         [Chromium] Modify WebTouchEvent structure to match WebCore::TouchEvent
839         https://bugs.webkit.org/show_bug.cgi?id=66800
840
841         Reviewed by Darin Fisher.
842
843         * DumpRenderTree/chromium/EventSender.cpp:
844         (EventSender::sendCurrentTouchEvent):
845
846 2011-09-06  Adam Barth  <abarth@webkit.org>
847
848         garden-o-matic details view should having working rebaseline and next/previous buttons
849         https://bugs.webkit.org/show_bug.cgi?id=67659
850
851         Reviewed by Dimitri Glazkov.
852
853         This patch wires up basic back/forward buttons that let you traverse
854         through the results we're examining in the details view.  This ended up
855         being more code than I expected, but I wanted to keep all the state
856         information in the DOM itself.
857
858         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
859         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
860         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
861
862 2011-09-01  Dirk Pranke  <dpranke@chromium.org>
863
864         fix MockFileSystem.glob(), refactor filesystem tests
865         https://bugs.webkit.org/show_bug.cgi?id=67462
866
867         Reviewed by Eric Seidel.
868
869         In debugging why my proposed change for MockFileSystem.glob()
870         in bug 66228 didn't work, I stumbled across two real bugs
871         that cancelled each other out for the unit tests. I fixed those
872         (glob shouldn't recurse into subdirs, and we weren't populating
873         self.dirs from self.files properly).
874
875         I have also created a "mixin" class for tests that can be shared
876         between the real filesystem and the mock filesystem - MockFileSystem
877         is being used enough it needs its own tests.
878
879         * Scripts/webkitpy/common/system/filesystem_mock.py:
880         * Scripts/webkitpy/common/system/filesystem_mock_unittest.py: Added.
881         * Scripts/webkitpy/common/system/filesystem_unittest.py:
882
883 2011-09-06  Anders Carlsson  <andersca@apple.com>
884
885         Move NPAPI headers in bridge to plugins
886         https://bugs.webkit.org/show_bug.cgi?id=67661
887
888         Update forwarding headers.
889
890         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npapi.h:
891         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npruntime.h:
892
893 2011-09-06  Tony Chang  <tony@chromium.org>
894
895         [chromium] Check in 'build' for compiled binaries first
896         https://bugs.webkit.org/show_bug.cgi?id=67549
897
898         Reviewed by Dirk Pranke.
899
900         I'm working on moving the windows build output to a common location
901         rather than relative to the sln file.  Because of that, we need to
902         check those build locations first for DumpRenderTree.exe.
903
904         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
905
906 2011-09-06  Adam Barth  <abarth@webkit.org>
907
908         Use a hierarchial structure for the garden-o-matic results view
909         https://bugs.webkit.org/show_bug.cgi?id=67620
910
911         Reviewed by Dimitri Glazkov.
912
913         This patch re-organizes the results view to use a hierachial structure
914         for selection.  At the top-level are sections for each test.  Expanding
915         the test section shows a tab selector for builders.
916
917         This structure prepares us for wiring up various actions to this view.
918
919         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
920         (.):
921         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
922         ():
923         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
924         (.):
925         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
926         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
927         (.results-view>.toolbar):
928         (.results-view>.toolbar ul.actions):
929         (.results-view>.toolbar ul.actions li):
930         (.results-grid table):
931         (.results-grid table td, .results-view table th):
932         (.results-grid table th):
933         (.results-grid .text-result):
934         (.results-grid .image-result):
935
936 2011-09-06  Adam Barth  <abarth@webkit.org>
937
938         garden-o-matic's base.probe generates spam in the JavaScript console
939         https://bugs.webkit.org/show_bug.cgi?id=67622
940
941         Reviewed by Dimitri Glazkov.
942
943         Now that we have CORS set up on the buildbot, we can use XMLHttpRequest
944         instead of HTMLScriptElement to test whether results exist.  This
945         reduces the console.log spam and saves bandwidth because we can use a
946         HEAD request instead of a GET request.
947
948         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/net.js:
949
950 2011-09-05  Adam Barth  <abarth@webkit.org>
951
952         Add a tab to garden-o-matic for viewing expected failures
953         https://bugs.webkit.org/show_bug.cgi?id=67619
954
955         Reviewed by Dimitri Glazkov.
956
957         This patch adds a basic tab to garden-o-matic that shows all the tests
958         failing on the bots, including the expected failures.  This patch
959         mostly involves refactoring existing classes to allow new subclasses.
960
961         This view is useful for when gardeners mark tests as expected to fail
962         and then rebaseline them later.
963
964         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
965         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
966         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
967         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary-mock.js:
968         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
969         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
970         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
971
972 2011-09-05  Adam Barth  <abarth@webkit.org>
973
974         Fix global variable leak in garden-o-matic
975         https://bugs.webkit.org/show_bug.cgi?id=67617
976
977         Reviewed by Dimitri Glazkov.
978
979         Caught by running the unit tests with noglobals turned on.
980
981         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
982
983 2011-09-05  Balazs Kelemen  <kbalazs@webkit.org>
984
985         [Qt][WK2] Add pixel test support
986         https://bugs.webkit.org/show_bug.cgi?id=66283
987
988         Reviewed by Andreas Kling.
989
990         Implemented pixel result generation by reusing the logic
991         that we have in DumpRenderTree.
992         * WebKitTestRunner/qt/TestInvocationQt.cpp:
993         (WTR::dumpImage):
994         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
995
996 2011-09-04  Robin Dunn  <robin@alldunn.com>
997
998         [wx] Enable wxWebKit to run using the wxGC Cairo backend on platforms other than GTK.
999         https://bugs.webkit.org/show_bug.cgi?id=67577
1000
1001         Reviewed by Kevin Ollivier.
1002
1003         * waf/build/settings.py:
1004
1005 2011-09-03  Kevin Ollivier  <kevino@theolliviers.com>
1006
1007         [wx] Unreviewed build fix. Add wtf/dtoa directory to build.
1008
1009         * waf/build/settings.py:
1010
1011 2011-09-03  Dan Bernstein  <mitz@apple.com>
1012
1013         32-bit build fix.
1014
1015         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
1016         (TestWebKitAPI::Util::toSTD):
1017
1018 2011-09-03  Dan Bernstein  <mitz@apple.com>
1019
1020         Move testStringByEvaluatingJavaScriptFromString() from DumpRenderTree to TestWebKitAPI
1021         https://bugs.webkit.org/show_bug.cgi?id=67559
1022
1023         Reviewed by Darin Adler.
1024
1025         * DumpRenderTree/mac/DumpRenderTree.mm:
1026         (dumpRenderTree): Moved testStringByEvaluatingJavaScriptFromString() from here and removed
1027         the call to it.
1028         * TestWebKitAPI/PlatformUtilities.h: Declared Util::toSTD(NSString *)
1029         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added StringByEvaluatingJavaScriptFromString.mm.
1030         * TestWebKitAPI/Tests/mac/StringByEvaluatingJavaScriptFromString.mm: Added.
1031         (TestWebKitAPI::TEST): Added. Moved testStringByEvaluatingJavaScriptFromString() to here.
1032         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
1033         (TestWebKitAPI::Util::toSTD): Added.
1034
1035 2011-09-03  Adam Barth  <abarth@webkit.org>
1036
1037         garden-o-matic results view should have a better results selector
1038         https://bugs.webkit.org/show_bug.cgi?id=67542
1039
1040         Reviewed by Dimitri Glazkov.
1041
1042         This patch adds a basic grid-based results selector to the results
1043         view.  Currently, this grid just shows how the tests fail on the
1044         various bots.  A future patch will let you select which failure to view
1045         and to mark the failures for rebaselining.
1046
1047         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
1048         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
1049           - Add some more basic functions for manipulating dictionaries.
1050         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
1051         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
1052         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
1053
1054 2011-09-03  Adam Barth  <abarth@webkit.org>
1055
1056         garden-o-matic results view should show Actual and Expected results for text failures
1057         https://bugs.webkit.org/show_bug.cgi?id=67536
1058
1059         Reviewed by Eric Seidel.
1060
1061         In the past, we didn't show actual and expected text results (we just
1062         showed the diff) because we didn't have the awesome six-by-two results
1063         grid.  Now that we do, we can move show these results.
1064
1065         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
1066         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
1067           - Fixed some typos that were preventing these unit tests from running.
1068         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
1069         (.):
1070         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
1071           - Report -actual.txt and -expected.txt as possible results URLs.
1072
1073 2011-09-03  Adam Barth  <abarth@webkit.org>
1074
1075         garden-o-matic shows "ghost" failures that are already fixed
1076         https://bugs.webkit.org/show_bug.cgi?id=67535
1077
1078         Reviewed by Eric Seidel.
1079
1080         About 10% of writes fail to stick on test-results.appspot.com.  This
1081         patch causes us to fetch the full_results.json blob directly from
1082         build.chromium.org rather than relying upon AppEngine.
1083
1084         Unforuntately, we still need to get historical information from
1085         AppEngine.  That will take several patches to fix becuase I need to
1086         change the bots to write the full_results.json file to the
1087         build-specific directory in addition to the zip file.
1088
1089         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
1090         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
1091         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
1092
1093 2011-09-03  Sheriff Bot  <webkit.review.bot@gmail.com>
1094
1095         Unreviewed, rolling out r94458.
1096         http://trac.webkit.org/changeset/94458
1097         https://bugs.webkit.org/show_bug.cgi?id=67558
1098
1099         Caused appcache test to fail on various bots (Requested by
1100         rniwa on #webkit).
1101
1102         * Scripts/webkitpy/layout_tests/port/webkit.py:
1103         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1104
1105 2011-09-03  Sheriff Bot  <webkit.review.bot@gmail.com>
1106
1107         Unreviewed, rolling out r94453.
1108         http://trac.webkit.org/changeset/94453
1109         https://bugs.webkit.org/show_bug.cgi?id=67557
1110
1111         Caused appcache test to fail on various bots (Requested by
1112         rniwa on #webkit).
1113
1114         * Scripts/webkitpy/layout_tests/port/webkit.py:
1115
1116 2011-09-02  Michael Saboff  <msaboff@apple.com>
1117
1118         Add JSC:RegExp functional tests
1119         https://bugs.webkit.org/show_bug.cgi?id=67339
1120
1121         New perl script to build JavaScriptCore and run the RegExp tests.
1122
1123         Reviewed by Gavin Barraclough.
1124
1125         * Scripts/run-regexp-tests: Added.
1126
1127 2011-09-02  Michael Saboff  <msaboff@apple.com>
1128
1129         Add JSC:RegExp functional tests
1130         https://bugs.webkit.org/show_bug.cgi?id=67339
1131
1132         New perl script to build JavaScriptCore and run the RegExp tests.
1133
1134         Reviewed by Gavin Barraclough.
1135
1136         * Scripts/run-regexp-tests: Added.
1137
1138 2011-09-02  Eric Seidel  <eric@webkit.org>
1139
1140         Reshuffle some code in WebKitDriver._read_block in preparation for reading stderr/stdout separately
1141         https://bugs.webkit.org/show_bug.cgi?id=67530
1142
1143         Unreviewed.  Fixing typo from previous commit.
1144
1145         Turns out there was *no* unittesting of WebKitDriver.  Added a basic test of _read_block
1146         which exercises the code I previously made a typo in.
1147
1148         * Scripts/webkitpy/layout_tests/port/webkit.py:
1149         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1150
1151 2011-09-02  Eric Seidel  <eric@webkit.org>
1152
1153         Reshuffle some code in WebKitDriver._read_block in preparation for reading stderr/stdout separately
1154         https://bugs.webkit.org/show_bug.cgi?id=67530
1155
1156         Reviewed by Adam Barth.
1157
1158         No functional change, just reshuffling code.
1159
1160         * Scripts/webkitpy/layout_tests/port/webkit.py:
1161
1162 2011-09-02  Darin Adler  <darin@apple.com>
1163
1164         Added Subversion ignore for .pyc generated files.
1165
1166         * Scripts/webkitpy/layout_tests/models: Added property svn:ignore.
1167         * Scripts/webkitpy/layout_tests/servers: Added property svn:ignore.
1168         * Scripts/webkitpy/tool/servers: Added property svn:ignore.
1169
1170 2011-09-02  Adam Barth  <abarth@webkit.org>
1171
1172         Enable testing on mac-ews
1173         https://bugs.webkit.org/show_bug.cgi?id=67505
1174
1175         Reviewed by Eric Seidel.
1176
1177         This patch enables testing on the Mac EWS, which should help
1178         contributors not turn the Mac bots red.
1179
1180         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1181
1182 2011-09-01  Beth Dakin  <bdakin@apple.com>
1183
1184         https://bugs.webkit.org/show_bug.cgi?id=67451
1185         Add a test for going back to a cached page after changing the device scale factor
1186
1187         Reviewed by Adam Roben.
1188
1189         New test DeviceScaleFactorOnBack.mm inherits from WebKitAgnosticTest.
1190         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1191         * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm: Added.
1192         (TestWebKitAPI::DeviceScaleFactorOnBack::url):
1193         (TestWebKitAPI::DeviceScaleFactorOnBack::didLoadURL):
1194         (TestWebKitAPI::DeviceScaleFactorOnBack::createWindow):
1195         (TestWebKitAPI::DeviceScaleFactorOnBack::initializeView):
1196         (TestWebKitAPI::DeviceScaleFactorOnBack::runTest):
1197         (TestWebKitAPI::TEST_F):
1198
1199         Added new function to WebKitAgnosticTest to goBack. Separated 
1200         waitForLoadToFinish() into its own function (instead of being a part of 
1201         loadAndWaitUntilFinished()) so that it can be called from goBack as 
1202         well. Also added initializeView() so we can set the cache model.
1203         * TestWebKitAPI/mac/WebKitAgnosticTest.h:
1204         (TestWebKitAPI::WebKitAgnosticTest::initializeView):
1205         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
1206         (TestWebKitAPI::WebKitAgnosticTest::WebKitAgnosticTest):
1207         (TestWebKitAPI::WebKitAgnosticTest::runWebKit1Test):
1208         (TestWebKitAPI::WebKitAgnosticTest::runWebKit2Test):
1209         (TestWebKitAPI::WebKitAgnosticTest::loadURL):
1210         (TestWebKitAPI::WebKitAgnosticTest::goBack):
1211         (TestWebKitAPI::WebKitAgnosticTest::waitForLoadToFinish):
1212
1213 2011-09-02  Anders Carlsson  <andersca@apple.com>
1214
1215         Build fix.
1216
1217         * DumpRenderTree/TestNetscapePlugIn/Tests/PrivateBrowsing.cpp:
1218         (PrivateBrowsing::ScriptableObject::pluginTest):
1219
1220 2011-09-02  Anders Carlsson  <andersca@apple.com>
1221
1222         Move private browsing test to a PluginTest subclass
1223         https://bugs.webkit.org/show_bug.cgi?id=67498
1224
1225         Reviewed by Darin Adler.
1226
1227         * DumpRenderTree/DumpRenderTree.gypi:
1228         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1229         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
1230         (pluginGetProperty):
1231         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
1232         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
1233         (PluginTest::NPP_SetValue):
1234         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
1235         * DumpRenderTree/TestNetscapePlugIn/Tests/PrivateBrowsing.cpp: Added.
1236         (PrivateBrowsing::PrivateBrowsing):
1237         (PrivateBrowsing::privateBrowsingEnabled):
1238         (PrivateBrowsing::cachedPrivateBrowsingEnabled):
1239         (PrivateBrowsing::ScriptableObject::hasProperty):
1240         (PrivateBrowsing::ScriptableObject::getProperty):
1241         (PrivateBrowsing::ScriptableObject::pluginTest):
1242         (PrivateBrowsing::NPP_New):
1243         (PrivateBrowsing::NPP_GetValue):
1244         (PrivateBrowsing::NPP_SetValue):
1245         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1246         (NPP_New):
1247         (NPP_SetValue):
1248         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1249         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1250         * GNUmakefile.am:
1251
1252 2011-09-02  Csaba Osztrogonác  <ossy@webkit.org>
1253
1254         [Qt] Build dependency problems
1255         https://bugs.webkit.org/show_bug.cgi?id=38054
1256
1257         Trivial fix after r94288.
1258
1259         Rubber-stamped by Andras Becsi.
1260
1261         * Scripts/webkitdirs.pm: We should read the whole defaults.txt, not only the first two lines.
1262         (buildQMakeProject):
1263
1264 2011-09-02  Andras Becsi  <andras.becsi@nokia.com>
1265
1266         Remove my old e-mail address and add my new one.
1267
1268         Rubber-stamped by Tor Arne Vestbø.
1269
1270         * Scripts/webkitpy/common/config/committers.py:
1271
1272 2011-09-02  Philippe Normand  <pnormand@igalia.com>
1273
1274         [GTK] run-gtk-tests leaves a zombie Xvfb process
1275         https://bugs.webkit.org/show_bug.cgi?id=67389
1276
1277         Reviewed by Martin Robinson.
1278
1279         * Scripts/run-gtk-tests: Properly close STDIN and STDERR on the
1280         child process instead of doing shell redirection.
1281
1282 2011-09-01  Mark Rowe  <mrowe@apple.com>
1283
1284         Fix the build by adding some more missing return types.
1285
1286         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1287         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
1288
1289 2011-09-01  Eric Seidel  <eric@webkit.org>
1290
1291         REGRESSION (NRWT): Leaks Viewer can't load leaks from test runs that used NRWT
1292         https://bugs.webkit.org/show_bug.cgi?id=66228
1293
1294         Reviewed by Dirk Pranke.
1295
1296         ORWT used $(PROCESS)$(NUMBER)-leaks.txt for leaks filenames.
1297         The LeaksViewer tool globs for all *-leaks.txt files.
1298         This patch makes NRWT output $(PROCESS)-$(PID)-leaks.txt which should match.
1299
1300         In order to test this I had to fix a limitation in our MockFileSystem.glob
1301         method.  However, doing so uncovered a typo and bug in the integration tests.
1302         I've disabled the offending integration tests.
1303
1304         * Scripts/webkitpy/common/system/filesystem_mock.py:
1305         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
1306         * Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:
1307
1308 2011-09-01  Dominic Mazzoni  <dmazzoni@google.com>
1309
1310         Adds a LayoutTestController method to make it possible to test
1311         starting speech input via an API call.
1312         https://bugs.webkit.org/show_bug.cgi?id=60170
1313
1314         Reviewed by Dimitri Glazkov.
1315
1316         * DumpRenderTree/LayoutTestController.h:
1317         * DumpRenderTree/chromium/LayoutTestController.cpp:
1318         (LayoutTestController::LayoutTestController):
1319         (LayoutTestController::startSpeechInput):
1320         * DumpRenderTree/chromium/LayoutTestController.h:
1321         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1322         (LayoutTestController::startSpeechInput):
1323         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1324         (LayoutTestController::startSpeechInput):
1325         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1326         (LayoutTestController::startSpeechInput):
1327         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1328         (LayoutTestController::startSpeechInput):
1329         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1330         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1331         (LayoutTestController::startSpeechInput):
1332         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1333         (LayoutTestController::startSpeechInput):
1334
1335 2011-09-01  Tim Horton  <hortont424@gmail.com>
1336
1337         Fix TestWebKitAPI build on clang-2.0
1338
1339         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
1340
1341 2011-09-01  Adam Barth  <abarth@webkit.org>
1342
1343         Remove unused "extension" parameter from rebaseline gardeningserver handler
1344         https://bugs.webkit.org/show_bug.cgi?id=67384
1345
1346         Reviewed by James Robinson.
1347
1348         This parameter hasn't done anything in a while.
1349
1350         * Scripts/webkitpy/tool/commands/rebaseline.py:
1351         * Scripts/webkitpy/tool/servers/gardeningserver.py:
1352         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
1353
1354 2011-09-01  Eric Seidel  <eric@webkit.org>
1355
1356         Unreviewed.
1357
1358         Fix a typo in unittests.  Unfortunately fixing it
1359         caused several assertions.  Just disabling the test
1360         instead, since it was providing no value before due to the typo.
1361
1362         * Scripts/webkitpy/layout_tests/port/test.py:
1363
1364 2011-09-01  Adam Barth  <abarth@webkit.org>
1365
1366         Add a "rebaseline" button to the garden-o-matic summary page
1367         https://bugs.webkit.org/show_bug.cgi?id=67382
1368
1369         Reviewed by Dimitri Glazkov.
1370
1371         As much as we might wish folks to not rebaseline entire test groups at
1372         once, the truth is that doing so is a common operation.  Adding a
1373         button for this operation is likely to make folks happy.
1374
1375         This patch also cleans up a bunch of plumbing surrounding failureInfo
1376         objects.
1377
1378         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
1379         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
1380         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
1381         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
1382         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
1383         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
1384         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
1385         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
1386         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
1387         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
1388
1389 2011-09-01  Adam Barth  <abarth@webkit.org>
1390
1391         garden-o-matic should let the gardener assign blame for a group of test failures
1392         https://bugs.webkit.org/show_bug.cgi?id=67379
1393
1394         Reviewed by Dimitri Glazkov.
1395
1396         If a group of test failures has a large revision range, the gardener
1397         might wish to blame a specific revision for the failure.  Currently,
1398         this only effect of assigning blame in this way is to hide the other
1399         suspect commits.
1400
1401         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
1402         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
1403         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
1404
1405 2011-09-01  Adam Barth  <abarth@webkit.org>
1406
1407         Hide garden-o-matic failure table until hover
1408         https://bugs.webkit.org/show_bug.cgi?id=67376
1409
1410         Reviewed by Dimitri Glazkov.
1411
1412         This patch removes the failure table for build failures (because it
1413         does not make sense) and hides the failure table for test groups until
1414         the user hovers over the test failure block, reducing visual noise.
1415
1416         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
1417         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
1418         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
1419
1420 2011-09-01  Adam Barth  <abarth@webkit.org>
1421
1422         Switch garden-o-matic from commitData.title to commitData.summary
1423         https://bugs.webkit.org/show_bug.cgi?id=67375
1424
1425         Reviewed by Dimitri Glazkov.
1426
1427         commitData.title is a string provided by Trac, which isn't great in all
1428         cases.  commitData.summary is my attempt to find the most important
1429         one-line summary of the commit.  This patch switches garden-o-matic
1430         over to summary.
1431
1432         Also, this patch tweaks a bunch of CSS to tighten up the summary page
1433         and reduce visual noise.
1434
1435         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
1436         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
1437         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
1438
1439 2011-09-01  Adam Barth  <abarth@webkit.org>
1440
1441         Group failing tests in garden-o-matic if there are more than three in a folder
1442         https://bugs.webkit.org/show_bug.cgi?id=67373
1443
1444         Reviewed by Dimitri Glazkov.
1445
1446         Sometimes a failure will cause many tests in a given directory to fail.
1447         When that happens, it's better to list the directory as a single item
1448         (with a count) rather than spamming all the test names.
1449
1450         (This patch also updates a bunch of unit test expected results after my last commit.)
1451
1452         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
1453         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
1454         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
1455         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
1456         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
1457
1458 2011-09-01  Adam Barth  <abarth@webkit.org>
1459
1460         Lower the visual noise from the failing builders display
1461         https://bugs.webkit.org/show_bug.cgi?id=67369
1462
1463         Reviewed by Dimitri Glazkov.
1464
1465         This patch ensures that the "Building" row in the failing builders
1466         display is always last and dims it by 50% to reduce visual noise.  This
1467         lets the gardener focus on the actual failures.
1468
1469         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
1470         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
1471         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/failures.css: Added.
1472
1473 2011-09-01  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
1474
1475         [Qt] Build dependency problems
1476         https://bugs.webkit.org/show_bug.cgi?id=38054
1477
1478         Make clean build after the defines are changed.
1479
1480         Reviewed by Csaba Osztrogonác.
1481
1482         * Scripts/webkitdirs.pm:
1483         (buildQMakeProject):
1484
1485 2011-08-31  Adam Barth  <abarth@webkit.org>
1486
1487         Move DumpRenderTree to WebKitPlatformSupport
1488         https://bugs.webkit.org/show_bug.cgi?id=67331
1489
1490         Reviewed by Darin Fisher.
1491
1492         This patch update DumpRenderTree to account for the WebKitClient =>
1493         WebKitPlatformSupport rename.
1494
1495         * DumpRenderTree/chromium/NotificationPresenter.cpp:
1496         (NotificationPresenter::show):
1497         * DumpRenderTree/chromium/Task.cpp:
1498         (postTask):
1499
1500 2011-08-31  Eric Seidel  <eric@webkit.org>
1501
1502         Add queues.webkit.org/active-bots page to make it easy to see which bots are down
1503         https://bugs.webkit.org/show_bug.cgi?id=67314
1504
1505         Reviewed by Adam Barth.
1506
1507         Very simple page.  Just lists all the bots, what queue they belong to and what we last heard from them.
1508         If we haven't heard from a bot in the last 500 messages (last day or so), then it won't show up here.
1509         This makes it very easy for me to see which of my cr-jail bots might be down at any one time.
1510
1511         I also moved a bunch of code into dashboard.css which belonged there.
1512
1513         * QueueStatusServer/handlers/activebots.py: Added.
1514         * QueueStatusServer/main.py:
1515         * QueueStatusServer/stylesheets/dashboard.css:
1516         (.queue_bubble):
1517         (.queue_name):
1518         (.last_heard_from):
1519         (.status_text):
1520         (.alive):
1521         (.behind):
1522         (.dead):
1523         * QueueStatusServer/templates/activebots.html: Added.
1524         * QueueStatusServer/templates/dashboard.html:
1525         * QueueStatusServer/templates/recentstatus.html:
1526
1527 2011-08-31  Oliver Hunt  <oliver@apple.com>
1528
1529         Move CheckedArithmeticOperations.cpp to the intended location
1530
1531         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1532         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp: Renamed from Tools/TestWebKitAPI/Tests/CheckedArithmeticOperations.cpp.
1533
1534 2011-08-31  Elliot Poger  <epoger@google.com>
1535
1536         add unittest to validate the complete set of Chromium configurations
1537         https://bugs.webkit.org/show_bug.cgi?id=67211
1538
1539         Reviewed by Adam Barth.
1540
1541         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1542
1543 2011-08-31  Nico Weber  <thakis@chromium.org>
1544
1545         Make ScrollAnimator(Chromium)?Mac check scrollAnimatorEnabled()
1546         https://bugs.webkit.org/show_bug.cgi?id=67297
1547
1548         Reviewed by Tony Chang.
1549
1550         Explicitly disable smooth scrolling in chromium's DRT.
1551
1552         * DumpRenderTree/chromium/WebPreferences.cpp:
1553         (WebPreferences::applyTo):
1554
1555 2011-08-31  Oliver Hunt  <oliver@apple.com>
1556
1557         Add Checked<> tests to windows build
1558
1559         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1560
1561 2011-08-30  Oliver Hunt  <oliver@apple.com>
1562
1563         Add support for checked arithmetic
1564         https://bugs.webkit.org/show_bug.cgi?id=67095
1565
1566         Reviewed by Sam Weinig.
1567
1568         Add test cases for Checked<>
1569
1570         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1571         * TestWebKitAPI/Tests/CheckedArithmeticOperations.cpp: Added.
1572
1573 2011-08-31  Adam Barth  <abarth@webkit.org>
1574
1575         Move summary.html to garden-o-matic.html.
1576
1577         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html.
1578         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js.
1579         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js: Removed.
1580         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Removed.
1581
1582 2011-08-31  Noel Gordon  <noel.gordon@gmail.com>
1583
1584         [chromium] DRT linux should pass nativeKeyCode to plugins
1585         https://bugs.webkit.org/show_bug.cgi?id=66679
1586
1587         Reviewed by Tony Chang.
1588
1589         * DumpRenderTree/chromium/EventSender.cpp:
1590         (EventSender::keyDown):  Call a Chromium Linux GTK helper routine that returns the
1591         (simulated) nativeKeyCode for the given input keyboard code.
1592
1593 2011-08-31  Adam Barth  <abarth@webkit.org>
1594
1595         Tighen up UI for garden-o-matic tab strip
1596         https://bugs.webkit.org/show_bug.cgi?id=67266
1597
1598         Reviewed by Dimitri Glazkov.
1599
1600         This patch add CSS to move the tab strip to the edges of the page and
1601         to remove some gratuitous border-radius.
1602
1603         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css:
1604         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:
1605
1606 2011-08-31  Adam Barth  <abarth@webkit.org>
1607
1608         garden-o-matic results view shouldn't be horrifically ugly
1609         https://bugs.webkit.org/show_bug.cgi?id=67264
1610
1611         Reviewed by Dimitri Glazkov.
1612
1613         Minor tweak to the results view CSS to make it fit in better with the new tabbed UI.
1614
1615         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
1616         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
1617         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
1618
1619 2011-08-31  Adam Barth  <abarth@webkit.org>
1620
1621         garden-o-matic needs a tabstrip
1622         https://bugs.webkit.org/show_bug.cgi?id=67263
1623
1624         Reviewed by Dimitri Glazkov.
1625
1626         This patch adds a basic tabstrip to garden-o-matic.  The results
1627         details view now opens in the "Results" tab, and the user can flip back
1628         and forth between the Summary and the Results tab quickly.  There's
1629         also a stub for a "Commits" tab, which is disabled.
1630
1631         This patch isn't the most beautiful in the world, but it gets the ball
1632         rolling on a multi-modal UI.
1633
1634         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
1635         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js:
1636         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
1637         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css:
1638         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:
1639
1640 2011-08-31  Ai Makabi  <makabi@google.com>
1641
1642         Extract reference links from reftest test file.
1643         https://bugs.webkit.org/show_bug.cgi?id=66838
1644
1645         Reviewed by Shinichiro Hamaji.
1646
1647         * Scripts/webkitpy/layout_tests/reftests/__init__.py: Added.
1648         * Scripts/webkitpy/layout_tests/reftests/extract_reference_link.py: Added.
1649         * Scripts/webkitpy/layout_tests/reftests/extract_reference_link_unittest.py: Added.
1650
1651 2011-08-03  Philippe Normand  <pnormand@igalia.com>
1652
1653         [webkitpy] missing log import in common/net/resultsjsonparser.py
1654         https://bugs.webkit.org/show_bug.cgi?id=65606
1655
1656         Reviewed by Martin Robinson.
1657
1658         * Scripts/webkitpy/common/net/resultsjsonparser.py: Import the logging module.
1659
1660 2011-08-30  Philippe Normand  <pnormand@igalia.com>
1661
1662         [stylechecker] complains about NULL usage in some gst_structure_ calls
1663         https://bugs.webkit.org/show_bug.cgi?id=67194
1664
1665         Reviewed by Martin Robinson.
1666
1667         Don't warn about NULL in some gst_structure_ calls. 0 can't be
1668         used for these, a proper sentinel is required.
1669
1670         * Scripts/webkitpy/style/checkers/cpp.py:
1671         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1672
1673 2011-08-30  Adam Barth  <abarth@webkit.org>
1674
1675         Remove old-style UI from garden-o-matic
1676         https://bugs.webkit.org/show_bug.cgi?id=67257
1677
1678         Reviewed by Dimitri Glazkov.
1679
1680         This code is nowhere near as awesome as the new hotness.  Let's remove
1681         it so it doesn't weigh us down.
1682
1683         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html: Removed.
1684         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/main.js: Removed.
1685         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
1686         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
1687         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/unexpected-passes.js: Removed.
1688         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/unexpected-passes.html: Removed.
1689
1690 2011-08-30  Takashi Toyoshima  <toyoshim@chromium.org>
1691
1692         [WebSocket] update pywebsocket to 0.6b5.
1693         https://bugs.webkit.org/show_bug.cgi?id=66924
1694
1695         Reviewed by Kent Tamura.
1696
1697         pywebsocket 0.6b2 supported minimum features of Hybi-08 specification.
1698         Now, pywebsocket 0.6b5 supports full features of Hybi-10 specification.
1699         0.6b3 or later supports a closing handshake handler and it is useful to
1700         verify client's closing handshake implementation.
1701         0.6b4 supports AbortedByUserException. It is useful to eliminate
1702         unnecessary server warning messages on intended abnormal closures.
1703         0.6b5 supports Python 2.5.1 or Mac 10.5.
1704
1705         * Scripts/webkitpy/thirdparty/__init__.py:
1706         Update download URL and directory path.
1707
1708 2011-08-30  Dan Bernstein  <mitz@apple.com>
1709
1710         Test for <rdar://problem/9281695> Add text search API for getting the DOM range of a text match
1711         https://bugs.webkit.org/show_bug.cgi?id=67230
1712
1713         Reviewed by Darin Adler.
1714
1715         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1716         * TestWebKitAPI/Tests/mac/DOMRangeOfString.html: Added.
1717         * TestWebKitAPI/Tests/mac/DOMRangeOfString.mm: Added.
1718         (-[DOMRangeOfStringFrameLoadDelegate webView:didFinishLoadForFrame:]):
1719         (TestWebKitAPI::TEST):
1720
1721 2011-08-30  Aaron Colwell  <acolwell@chromium.org>
1722
1723         Add MediaSource API to HTMLMediaElement
1724         https://bugs.webkit.org/show_bug.cgi?id=64731
1725
1726         Reviewed by Eric Carlson.
1727
1728         * Scripts/build-webkit:
1729
1730 2011-08-30  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
1731
1732         Emit last progress notification before calling dispatchDidFinishLoad
1733         https://bugs.webkit.org/show_bug.cgi?id=28851
1734
1735         Reviewed by Adam Barth.
1736
1737         Implement dumpProgressFinishedCallback() in the layoutTestController for Qt,
1738         Chromium and GTK ports. The first two were simple changes.
1739
1740         Some refactoring was needed in GTK port to assure that the dumps are emitted
1741         correctly and the processing after the page load finished is in the right place.
1742
1743         To detect the load finished, we use the callback for the "load-status" notifier
1744         signal of the top loading frame. And we use the deprecated "load-finished" signal
1745         for dumping (if enabled) the progress finished expected output.
1746
1747         * DumpRenderTree/LayoutTestController.cpp:
1748         (LayoutTestController::LayoutTestController):
1749         (dumpProgressFinishedCallbackCallback):
1750         (LayoutTestController::staticFunctions):
1751         * DumpRenderTree/LayoutTestController.h:
1752         (LayoutTestController::dumpProgressFinishedCallback):
1753         (LayoutTestController::setDumpProgressFinishedCallback):
1754         * DumpRenderTree/chromium/LayoutTestController.cpp:
1755         (LayoutTestController::LayoutTestController):
1756         (LayoutTestController::dumpProgressFinishedCallback):
1757         (LayoutTestController::reset):
1758         * DumpRenderTree/chromium/LayoutTestController.h:
1759         (LayoutTestController::shouldDumpProgressFinishedCallback):
1760         (LayoutTestController::setShouldDumpProgressFinishedCallback):
1761         * DumpRenderTree/chromium/WebViewHost.cpp:
1762         (WebViewHost::didStopLoading):
1763         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1764         (webViewLoadFinished):
1765         (topLoadingFrameLoadFinished):
1766         (webFrameLoadStatusNotified):
1767         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1768         (LayoutTestController::reset):
1769         (LayoutTestController::dumpProgressFinishedCallback):
1770         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1771
1772 2011-08-30  Filip Pizlo  <fpizlo@apple.com>
1773
1774         JavaScriptCore does not have a good mechanism for performance
1775         regression testing
1776         https://bugs.webkit.org/show_bug.cgi?id=67177
1777
1778         Reviewed by Darin Adler.
1779         
1780         Added a new script, which allows for testing one, two, or more VMs
1781         at once on SunSpider, V8, and Kraken benchmarks.  Benchmark/VM runs
1782         are interleaved at random to minimize systematics.  The results
1783         that bencher prints includes all possible relevant information about
1784         how bencher was invoked.  Bencher can be easily used to measure
1785         performance changes down to fractions of a percent.
1786         
1787         Bencher also includes experimental support for running benchmarks in
1788         a DumpRenderTree release build.  This works in SunSpider and V8, but
1789         not yet in Kraken.  Running benchmarks in DumpRenderTree more
1790         closely mimics the performance when running in browser.
1791
1792         * Scripts/bencher: Added.
1793
1794 2011-08-29  Alexey Proskuryakov  <ap@apple.com>
1795
1796         DumpRenderTree should begin each test with an empty cookie store
1797         https://bugs.webkit.org/show_bug.cgi?id=63545
1798         <rdar://problem/5666907>
1799
1800         Reviewed by Darin Adler.
1801
1802         * DumpRenderTree/mac/DumpRenderTree.mm:
1803         (resetDefaultsToConsistentValues):
1804         (setDefaultsToConsistentValuesForTesting):
1805         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1806         (LayoutTestController::setAlwaysAcceptCookies):
1807         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1808         (WTR::InjectedBundle::beginTesting):
1809         Use new SPIs to manipulate sessions.
1810
1811 2011-08-30  Sheriff Bot  <webkit.review.bot@gmail.com>
1812
1813         Unreviewed, rolling out r94055 and r94057.
1814         http://trac.webkit.org/changeset/94055
1815         http://trac.webkit.org/changeset/94057
1816         https://bugs.webkit.org/show_bug.cgi?id=67191
1817
1818         Many failures on Mac 10.5 (Requested by toyoshim on #webkit).
1819
1820         * Scripts/webkitpy/thirdparty/__init__.py:
1821
1822 2011-08-30  Adam Barth  <abarth@webkit.org>
1823
1824         Chromium Android should not be a core builder
1825         https://bugs.webkit.org/show_bug.cgi?id=67184
1826
1827         Reviewed by Ryosuke Niwa.
1828
1829         This bot hasn't been consistently green yet because it has never actually run!
1830
1831         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1832         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1833
1834 2011-08-30  Takashi Toyoshima  <toyoshim@chromium.org>
1835
1836         [WebSocket] update pywebsocket to 0.6b4.
1837         https://bugs.webkit.org/show_bug.cgi?id=66924
1838
1839         Reviewed by Kent Tamura.
1840
1841         pywebsocket 0.6b2 supported minimum features of Hybi-08 specification.
1842         Now, pywebsocket 0.6b4 supports full features of Hybi-10 specification.
1843         0.6b3 or later supports a closing handshake handler and it is useful to
1844         verify client's closing handshake implementation.
1845         0.6b4 supports AbortedByUserException. It is useful to eliminate
1846         unnecessary server warning messages on intended abnormal closures.
1847
1848         * Scripts/webkitpy/thirdparty/__init__.py:
1849         Update download URL and directory path.
1850
1851 2011-08-29  Tom Zakrajsek  <tomz@codeaurora.org>
1852
1853         sheriffbot "usage" help statements are wrong
1854         https://bugs.webkit.org/show_bug.cgi?id=67170
1855
1856         Reviewed by Adam Barth.
1857
1858         * Scripts/webkitpy/tool/bot/irc_command.py:
1859         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1860         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
1861
1862 2011-08-29  Adam Barth  <abarth@webkit.org>
1863
1864         Add support for chomium-mac (non-CoreGraphics) baselines
1865         https://bugs.webkit.org/show_bug.cgi?id=67163
1866
1867         Reviewed by Eric Seidel.
1868
1869         This patch teaches the non-CG chromium-mac bots to look at non-CG
1870         baselines.  However, the patch still leaves CG as the default set of
1871         baselines.
1872
1873         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
1874         * Scripts/webkitpy/common/config/build.py:
1875         * Scripts/webkitpy/common/config/build_unittest.py:
1876         * Scripts/webkitpy/layout_tests/port/builders.py:
1877         * Scripts/webkitpy/layout_tests/port/chromium.py:
1878         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1879         * Scripts/webkitpy/layout_tests/port/factory.py:
1880         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
1881         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
1882         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
1883         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1884
1885 2011-08-29  Shawn Singh  <shawnsingh@chromium.org>
1886
1887         Small fix in chromium port of new-run-webkit-tests.
1888         https://bugs.webkit.org/show_bug.cgi?id=67078
1889
1890         Reviewed by Dirk Pranke.
1891
1892         * Scripts/webkitpy/layout_tests/port/chromium.py:
1893
1894 2011-08-29  Sheriff Bot  <webkit.review.bot@gmail.com>
1895
1896         Unreviewed, rolling out r93987, r93992, r93995, r93998, and
1897         r93999.
1898         http://trac.webkit.org/changeset/93987
1899         http://trac.webkit.org/changeset/93992
1900         http://trac.webkit.org/changeset/93995
1901         http://trac.webkit.org/changeset/93998
1902         http://trac.webkit.org/changeset/93999
1903         https://bugs.webkit.org/show_bug.cgi?id=67147
1904
1905         Many failing tests (Requested by ap on #webkit).
1906
1907         * DumpRenderTree/mac/DumpRenderTree.mm:
1908         (setDefaultsToConsistentValuesForTesting):
1909         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1910         (WTR::InjectedBundle::beginTesting):
1911
1912 2011-08-26  Alexey Proskuryakov  <ap@apple.com>
1913
1914         DumpRenderTree should begin each test with an empty cookie store
1915         https://bugs.webkit.org/show_bug.cgi?id=63545
1916         <rdar://problem/5666907>
1917
1918         Reviewed by Darin Adler.
1919
1920         * DumpRenderTree/mac/DumpRenderTree.mm:
1921         (setDefaultsToConsistentValuesForTesting):
1922         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1923         (WTR::InjectedBundle::beginTesting):
1924         Tell WebCore to use a temporary session, starting with a clean cookie store.
1925
1926 2011-08-23  Chris Marrin  <cmarrin@apple.com>
1927
1928         [mac] requestAnimationFrame support for mac port
1929         https://bugs.webkit.org/show_bug.cgi?id=59146
1930
1931         Reviewed by Simon Fraser.
1932
1933         Add support for request-animation-callback flag
1934
1935         * Scripts/build-webkit:
1936
1937 2011-08-27  Peter Beverloo  <peter@chromium.org>
1938
1939         Add a build bot for Chromium with OS(ANDROID)
1940         https://bugs.webkit.org/show_bug.cgi?id=66687
1941
1942         Reviewed by Adam Barth.
1943
1944         * BuildSlaveSupport/build.webkit.org-config/config.json:
1945
1946 2011-08-27  Peter Beverloo  <peter@chromium.org>
1947
1948         Update the master build bot configuration script to properly
1949         deal with the --chromium-android switch.
1950         https://bugs.webkit.org/show_bug.cgi?id=66687
1951
1952         The --chromium-android switch is needed when running
1953         update-webkit-chromium and build-webkit, as it'll tell the
1954         scripts to pull in the right dependencies and cross-compile
1955         WebKit using the Android NDK.
1956
1957         Reviewed by Adam Barth.
1958
1959         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1960
1961 2011-08-27  Peter Beverloo  <peter@chromium.org>
1962
1963         Teach the update and build scripts how to handle dependencies
1964         and cross-compiling rules for the Chromium port on OS(ANDROID).
1965         https://bugs.webkit.org/show_bug.cgi?id=66687
1966
1967         Reviewed by Adam Barth.
1968
1969         * Scripts/build-webkit:
1970         * Scripts/update-webkit:
1971         * Scripts/update-webkit-chromium:
1972         * Scripts/webkitdirs.pm:
1973         (argumentsForConfiguration):
1974         (isChromium):
1975         (isChromiumAndroid):
1976         (determineIsChromiumAndroid):
1977         (buildChromium):
1978
1979 2011-08-26  Adam Barth  <abarth@webkit.org>
1980
1981         garden-o-matic should let me know that I need to run the local server
1982         https://bugs.webkit.org/show_bug.cgi?id=66985
1983
1984         Reviewed by Dimitri Glazkov.
1985
1986         The patch triggers an alert dialog whenever the user tries to use a
1987         feature that requires the local server.
1988
1989         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
1990         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
1991         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js:
1992
1993 2011-08-26  Dimitri Glazkov  <dglazkov@chromium.org>
1994
1995         garden-o-matic summary view should have pretty commit data information.
1996         https://bugs.webkit.org/show_bug.cgi?id=67069
1997
1998         Reviewed by Adam Barth.
1999
2000         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Added support for styling commit data.
2001         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Changed tests.
2002         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css: Defined global anchor color.
2003         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css: Styled commit data.
2004
2005 2011-08-26  Dimitri Glazkov  <dglazkov@chromium.org>
2006
2007         Tweak the use of Open Sans in garden-o-matic summary view to make it look decent on Windows and Linux.
2008         https://bugs.webkit.org/show_bug.cgi?id=67066
2009
2010         Reviewed by Adam Barth.
2011
2012         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary-mock.html: Tweaked.
2013         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Ditto.
2014
2015 2011-08-26  Raphael Kubo da Costa  <kubo@profusion.mobi>
2016
2017         [DRT] Include cairo.h in PixelDumpSupportCairo.h for EFL too.
2018         https://bugs.webkit.org/show_bug.cgi?id=67041
2019
2020         Reviewed by Martin Robinson.
2021
2022         This is a follow-up to r89053: EFL's PixelDumpSupportEfl.cpp includes
2023         PixelDumpSupportCairo.h, but the latter was #including cairo.h only
2024         when the GTK+ port was being built.
2025
2026         * DumpRenderTree/cairo/PixelDumpSupportCairo.h:
2027
2028 2011-08-26  Dimitri Glazkov  <dglazkov@chromium.org>
2029
2030         Clean up and line up layout in garden-o-matic summary view.
2031         https://bugs.webkit.org/show_bug.cgi?id=67057
2032
2033         1) Renamed ui.notifications.TestFailures to ui.notifications.TestsFailing to match BuildersFailing;
2034         2) Rearranged DOM structure a bit to accommodate recent changes;
2035         3) Added minimal CSS to line things up.
2036
2037         Reviewed by Adam Barth.
2038
2039         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js: Renamed TestFailures to TestsFailing.
2040         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary-mock.js: Added mocks for BuildersFailing.
2041         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js: Renamed TestFailures to TestsFailing.
2042         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js: Updated tests.
2043         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Changed DOM structure.
2044         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Updated tests.
2045         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css: Tweaked common appearance.
2046         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css: Added minimal layout/style.
2047         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary-mock.html: Added Google Web Fonts hook.
2048         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Ditto.
2049
2050 2011-08-26  Alice Liu  <alice.liu@apple.com>
2051
2052         https://bugs.webkit.org/show_bug.cgi?id=66823
2053         Add the request info to the WebPageProxy::CreateNewPage message
2054
2055         Reviewed by Anders Carlsson.
2056
2057         Update function declarations with additional parameter:
2058         * MiniBrowser/gtk/BrowserWindow.c:
2059         (createNewPage):
2060         * MiniBrowser/mac/BrowserWindowController.m:
2061         (createNewPage):
2062         * MiniBrowser/win/BrowserView.cpp:
2063         (createNewPage):
2064         * WebKitTestRunner/TestController.cpp:
2065         (WTR::TestController::createOtherPage):
2066         * WebKitTestRunner/TestController.h:
2067
2068 2011-08-26  Noel Gordon  <noel.gordon@gmail.com>
2069
2070         Make show-pretty-diff work on linux
2071         https://bugs.webkit.org/show_bug.cgi?id=67017
2072
2073         Reviewed by Adam Barth.
2074
2075         * Scripts/show-pretty-diff:
2076
2077 2011-08-25  Dimitri Glazkov  <dglazkov@chromium.org>
2078
2079         Reorganize garden-o-matic CSS files to match JS-built views.
2080         https://bugs.webkit.org/show_bug.cgi?id=66998
2081
2082         Reviewed by Adam Barth.
2083
2084         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css: Added.
2085         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css: Added.
2086         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css: Added.
2087         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/summary.css: Removed.
2088         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary-mock.html: Changed to use new CSS files.
2089         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Ditto.
2090
2091 2011-08-25  Adam Barth  <abarth@webkit.org>
2092
2093         garden-o-matic should be able to roll out patches
2094         https://bugs.webkit.org/show_bug.cgi?id=66982
2095
2096         Reviewed by Dimitri Glazkov.
2097
2098         This patch just wires the rollout event through the controller to the
2099         local server, which is already set up to perform rollouts.
2100
2101         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
2102         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
2103         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
2104         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
2105
2106 2011-08-25  Viatcheslav Ostapenko  <ostapenko.viatcheslav@nokia.com>
2107
2108         [Qt] [WK2] Assert in computeViewportAttributes when MiniBrowser started with -touch
2109         https://bugs.webkit.org/show_bug.cgi?id=66951
2110
2111         Reviewed by Andreas Kling.
2112
2113         Function computeViewportAttributes() gets called when height is still 0 because MiniBrowser sets
2114         width and height one by one and setWidth cause geometryChange event in QTouchWebView. 
2115
2116         * MiniBrowser/qt/BrowserView.cpp:
2117         (BrowserView::resizeEvent):
2118
2119 2011-08-25  Dimitri Glazkov  <dglazkov@chromium.org>
2120
2121         garden-o-matic summary view should provide information on builders still in flight.
2122         https://bugs.webkit.org/show_bug.cgi?id=66992
2123
2124         Reviewed by Adam Barth.
2125
2126         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js: Added grabbing the list of in-flight builders.
2127         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js: Added buildersInFlightForRevision.
2128         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model_unittests.js: Added tests.
2129         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Split off updating builder results to own method.
2130         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Added tests.
2131
2132 2011-08-25  Adam Barth  <abarth@webkit.org>
2133
2134         webkit-patch rebaseline-expectations don't work when run outside the root
2135         https://bugs.webkit.org/show_bug.cgi?id=66966
2136
2137         Reviewed by Eric Seidel.
2138
2139         Turns out tool.path() used to be relative, which caused problems when
2140         running webkit-patch outside the root directory.  This patch makes it
2141         absolute.  I checked all callers, and they all appear to want this
2142         behavior.
2143
2144         It was unclear to me how to test this change because we only really
2145         have a testing strategy for webkitpy, not for the main script.
2146
2147         * Scripts/webkit-patch:
2148
2149 2011-08-25  Dimitri Glazkov  <dglazkov@chromium.org>
2150
2151         garden-o-matic summary needs a mock view that could be used for working on styling
2152         https://bugs.webkit.org/show_bug.cgi?id=66971
2153
2154         Reviewed by Adam Barth.
2155
2156         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary-mock.js: Added.
2157         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary-mock.html: Added.
2158
2159 2011-08-25  Anders Carlsson  <andersca@apple.com>
2160
2161         Return the correct value for NPNVsupportsCarbonBool
2162         https://bugs.webkit.org/show_bug.cgi?id=66964
2163
2164         Add a test.
2165
2166         Reviewed by Adam Roben.
2167
2168         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2169         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Added.
2170         (SupportsCarbonEventModel::SupportsCarbonEventModel):
2171         (SupportsCarbonEventModel::testConvert):
2172         (SupportsCarbonEventModel::runTest):
2173         (SupportsCarbonEventModel::NPP_New):
2174
2175 2011-08-25  Dimitri Glazkov  <dglazkov@chromium.org>
2176
2177         garden-o-matic summary view should not be broken.
2178
2179         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/summary.css:
2180         (table.comparison): Added more specificity.
2181
2182 2011-08-25  Adam Barth  <abarth@webkit.org>
2183
2184         This command has been broken for a while.  This patch updates the
2185         callsite to the new API.
2186
2187         * Scripts/webkitpy/tool/commands/rebaseline.py:
2188
2189 2011-08-25  Dimitri Glazkov  <dglazkov@chromium.org>
2190
2191         garden-o-matic needs a way to report where and how tests are failing in the summary view.
2192         https://bugs.webkit.org/show_bug.cgi?id=66955
2193
2194         Introduce FailureGrid, your one-stop failure-indicating destination. 
2195
2196         Reviewed by Adam Barth.
2197
2198         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html: Added new scripts.
2199         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js: Added.
2200         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js: Added.
2201         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Updated to use FailureGrid.
2202         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Updated tests.
2203         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Added new scripts.
2204
2205 2011-08-25  Igor Oliveira  <igor.oliveira@openbossa.org>
2206
2207         Add myself to the committers list
2208         https://bugs.webkit.org/show_bug.cgi?id=66941
2209
2210         Reviewed by Andreas Kling.
2211
2212         * Scripts/webkitpy/common/config/committers.py:
2213
2214 2011-08-25  Sheriff Bot  <webkit.review.bot@gmail.com>
2215
2216         Unreviewed, rolling out r93767.
2217         http://trac.webkit.org/changeset/93767
2218         https://bugs.webkit.org/show_bug.cgi?id=66931
2219
2220         Broke Qt bot. (Requested by yutak on #webkit).
2221
2222         * Scripts/webkitpy/thirdparty/__init__.py:
2223
2224 2011-08-25  Takashi Toyoshima  <toyoshim@chromium.org>
2225
2226         [WebSocket] update pywebsocket to 0.6b3 which supports closing handshake test
2227         https://bugs.webkit.org/show_bug.cgi?id=66924
2228
2229         Reviewed by Kent Tamura.
2230
2231         * Scripts/webkitpy/thirdparty/__init__.py:
2232
2233 2011-08-24  Adam Barth  <abarth@webkit.org>
2234
2235         The user can't close the details view in garden-o-matic
2236         https://bugs.webkit.org/show_bug.cgi?id=66911
2237
2238         Reviewed by Dimitri Glazkov.
2239
2240         In addition to adding a close button, this patch changes the test
2241         selector to use a <select> element and refactors the test selector to
2242         share code with the builder selector.
2243
2244         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
2245         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
2246         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions_unittests.js:
2247         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
2248
2249 2011-08-24  James Robinson  <jamesr@chromium.org>
2250
2251         [chromium] Stacktrace not in test output when a test crashes
2252         https://bugs.webkit.org/show_bug.cgi?id=66806
2253
2254         Reviewed by Dirk Pranke.
2255
2256         Appends the .error and .text output when a test crashes since on chromium the .text contains the actual stack
2257         trace.
2258
2259         * Scripts/webkitpy/layout_tests/port/chromium.py:
2260
2261 2011-08-24  Adam Barth  <abarth@webkit.org>
2262
2263         Remove empty directory.
2264
2265         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui: Removed.
2266
2267 2011-08-24  Adam Barth  <abarth@webkit.org>
2268
2269         Finish writing up details-view in garden-o-matic
2270         https://bugs.webkit.org/show_bug.cgi?id=66891
2271
2272         Reviewed by Dimitri Glazkov.
2273
2274         This patch mostly just copies a bunch of CSS from main.css to
2275         summary.css.  Presumably we'll delete main.css soon.
2276
2277         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
2278         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
2279         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions_unittests.js:
2280         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/summary.css:
2281         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:
2282
2283 2011-08-24  James Robinson  <jamesr@chromium.org>
2284
2285         Some compositing LayoutTests flakily crashing on Mac 10.6
2286         https://bugs.webkit.org/show_bug.cgi?id=66740
2287
2288         Reviewed by Adam Barth.
2289
2290         Null-check obj->pluginTest before dereferencing it. This can be null in chromium if the plugin load fails, for
2291         example if the test attempts to load a PDF plugin the load will fail since we don't have such a thing in the
2292         chromium configuration.
2293
2294         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2295         (NPP_Destroy):
2296
2297 2011-08-24  Anton D'Auria  <adauria@apple.com>
2298
2299         No review necessary.
2300
2301         Adding myself to list of committers.
2302
2303         * Scripts/webkitpy/common/config/committers.py:
2304
2305 2011-08-24  Avi Drissman  <avi@google.com>
2306
2307         Crash when restoring NSGraphicsContext when running the Chromium GPU layout tests on Mac
2308         https://bugs.webkit.org/show_bug.cgi?id=66875
2309
2310         Reviewed by James Robinson.
2311
2312         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
2313         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
2314
2315 2011-08-23  Dimitri Glazkov  <dglazkov@chromium.org>
2316
2317         Make notifications appear in time order again.
2318         https://bugs.webkit.org/show_bug.cgi?id=66815
2319
2320         Reviewed by Adam Barth.
2321
2322         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Added setting index of the notification.
2323         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Updated the test.
2324
2325 2011-08-23  James Robinson  <jamesr@chromium.org>
2326
2327         [chromium] Need a way to test lost compositor context recovery
2328         https://bugs.webkit.org/show_bug.cgi?id=66820
2329
2330         Reviewed by Kenneth Russell.
2331
2332         Exposes a LayoutTestController interface in chromium to simulate a
2333         lost compositor context.
2334
2335         * DumpRenderTree/chromium/LayoutTestController.cpp:
2336         (LayoutTestController::LayoutTestController):
2337         (LayoutTestController::loseCompositorContext):
2338         * DumpRenderTree/chromium/LayoutTestController.h:
2339
2340 2011-08-23  Dimitri Glazkov  <dglazkov@chromium.org>
2341
2342         Change garden-o-matic frontend builder array to be a configuration map.
2343         https://bugs.webkit.org/show_bug.cgi?id=66816
2344
2345         Reviewed by Adam Barth.
2346
2347         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js: Made kBuilders a map, with value being a configuration object.
2348         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js: Adjusted callsites to expect a map.
2349         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/main.js: Ditto.
2350         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js: Ditto.
2351         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js: Ditto.
2352
2353 2011-08-23  Cary Clark  <caryclark@google.com>
2354
2355         Turn WebCanvas into CGContext before drawing scrollbar (DRT using Skia on Mac)
2356         https://bugs.webkit.org/show_bug.cgi?id=66803
2357
2358         This fixes the WebKit Canaries, in particular avoids a crash on tests
2359         like css1/basic/comments.html.
2360
2361         Reviewed by James Robinson.
2362
2363         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
2364         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
2365         The NSGraphicsContext call graphicsContextWithGraphicsPort takes a void*
2366         parameter, so it took a WebCanvas* (mapped to SkCanvas* in Skia-land)
2367         and treated it as if it were a CGContextRef.
2368
2369 2011-08-23  Patrick Gansterer  <paroga@webkit.org>
2370
2371         Fix mergeChangeLogs test on native windows
2372         https://bugs.webkit.org/show_bug.cgi?id=66797
2373
2374         Reviewed by Adam Roben.
2375
2376         Windows has no /tmp/ directory and the "TMPDIR" environment variable isn't set in the default setup.
2377         Add the "TEMP" environment variable as additional source for the temporary directory used in writeTempFile.
2378
2379         * Scripts/webkitperl/VCSUtils_unittest/mergeChangeLogs.pl:
2380         (writeTempFile):
2381
2382 2011-08-23  Dimitri Glazkov  <dglazkov@chromium.org>
2383
2384         garden-o-matic relative time is wrong and updates too frequently.
2385         https://bugs.webkit.org/show_bug.cgi?id=66802
2386
2387         Reviewed by Adam Barth.
2388
2389         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js: Changed to account for rounding correctly.
2390         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js: Updated tests.
2391         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js: Upped the interval to 1 minute.
2392
2393 2011-08-23  Patrick Gansterer  <paroga@webkit.org>
2394
2395         Add missing quotes around filenames in mergeChangeLogs
2396         https://bugs.webkit.org/show_bug.cgi?id=66794
2397
2398         Reviewed by Adam Roben.
2399
2400         * Scripts/VCSUtils.pm:
2401         (mergeChangeLogs):
2402
2403 2011-08-23  Patrick Gansterer  <paroga@webkit.org>
2404
2405         webkit-perl tests fail on win32 Perl due to lack of list form of pipe open implementation
2406         https://bugs.webkit.org/show_bug.cgi?id=49080
2407
2408         Reviewed by Adam Roben.
2409
2410         Use the string form of pipe open instead (like we do at all other places).
2411
2412         * Scripts/VCSUtils.pm:
2413         (mergeChangeLogs):
2414
2415 2011-08-23  Adam Barth  <abarth@webkit.org>
2416
2417         garden-o-matic summary should be able to examine failures
2418         https://bugs.webkit.org/show_bug.cgi?id=66748
2419
2420         Reviewed by Dimitri Glazkov.
2421
2422         This patch refactors a bunch of code from summary.js to independent
2423         controllers in controllers.js.  This patch also contains the first
2424         iteration of binding the "examine" event to a the behavior showing the
2425         details view for the tests.  There's more work to do here to make this
2426         work properly (and elegantly), but this patch is a start.
2427
2428         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
2429         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
2430         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
2431         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers/rebaseline.js:
2432         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js:
2433         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
2434         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
2435         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
2436         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:
2437
2438 2011-08-23  Adam Barth  <abarth@webkit.org>
2439
2440         webkitpy/common/config/build.py shouldn't mention non-existant Android directory
2441         https://bugs.webkit.org/show_bug.cgi?id=66737
2442
2443         Reviewed by Steve Block.
2444
2445         This directory doesn't exist anymore now that the Android port shares
2446         more code with Chromium.
2447
2448         * Scripts/webkitpy/common/config/build.py:
2449
2450 2011-08-22  Eric Seidel  <eric@webkit.org>
2451
2452         Hack start-queue.sh in an attempt to resurrect the cr-jail-1 cr-mac-ews bot.
2453         I won't have ssh access to the bot again for a couple days, so
2454         attempting to fix by changing this script.  If this doesn't
2455         work we'll just live with the it hung for now.
2456
2457         Unreviewed.
2458
2459         * EWSTools/start-queue.sh:
2460
2461 2011-08-22  Dimitri Glazkov  <dglazkov@chromium.org>
2462
2463         webkit-patch rebaseline-expectations command should not rearrange the entire test_expectations.txt file.
2464         https://bugs.webkit.org/show_bug.cgi?id=66727
2465
2466         Reviewed by Adam Barth.
2467
2468         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Made it possible to run TestExpectationSerializer without a TestConfigurationConverter,
2469             in which case the serializer treats all expectations as unparsed.
2470         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Added unit tests.
2471
2472 2011-08-22  Dimitri Glazkov  <dglazkov@chromium.org>
2473
2474         Update unit test expectations after r93530.
2475
2476         * Scripts/webkitpy/layout_tests/port/factory_unittest.py: Updated.
2477         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py: Ditto.
2478
2479 2011-08-22  Dimitri Glazkov  <dglazkov@chromium.org>
2480
2481         [Chromium] Expand CPU/GPU/Skia/CG into a matrix in graphics_type.
2482         https://bugs.webkit.org/show_bug.cgi?id=66705
2483
2484         Reviewed by Adam Barth.
2485
2486         * Scripts/webkitpy/layout_tests/port/chromium.py: Added plumbing for CG graphics types.
2487         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py: Adjusted unit test.
2488
2489 2011-08-22  James Robinson  <jamesr@chromium.org>
2490
2491         [chromium] Update builder names for chromium gpu bots due to CG switchover
2492         https://bugs.webkit.org/show_bug.cgi?id=66693
2493
2494         Reviewed by Dirk Pranke.
2495
2496         Update the port and builder names for the chromium mac gpu bots to
2497         account for the CG transition.
2498
2499         * Scripts/webkitpy/layout_tests/port/builders.py:
2500
2501 2011-08-22  Dirk Pranke  <dpranke@chromium.org>
2502
2503         fix the GPU bot names on the layout test dashboard
2504         https://bugs.webkit.org/show_bug.cgi?id=66697
2505
2506         Reviewed by Dimitri Glazkov.
2507
2508         * TestResultServer/static-dashboards/builders.js:
2509
2510 2011-08-22  Dimitri Glazkov  <dglazkov@chromium.org>
2511
2512         garden-o-matic's relative time display should be updated regularly.
2513         https://bugs.webkit.org/show_bug.cgi?id=66682
2514
2515         Reviewed by Adam Barth.
2516
2517         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js: Moved Time to ui.Time, added code for regular updates.
2518         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Changed to use ui.Time.
2519         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js: Added tests.
2520
2521 2011-08-22  Xianzhu Wang  <wangxianzhu@chromium.org>
2522
2523         Pass --makeargs of build-webkit to chromium linux builder
2524         https://bugs.webkit.org/show_bug.cgi?id=66361
2525
2526         Reviewed by Tony Chang.
2527
2528         * Scripts/build-webkit:
2529         * Scripts/webkitdirs.pm:
2530         (buildChromiumMakefile):
2531         (buildChromium):
2532
2533 2011-08-22  Peter Beverloo  <peter@chromium.org>
2534
2535         Add myself to the contributor list.
2536         https://bugs.webkit.org/show_bug.cgi?id=66674
2537
2538         Reviewed by Tony Gentilcore.
2539
2540         * Scripts/webkitpy/common/config/committers.py:
2541
2542 2011-08-22  Balazs Kelemen  <kbalazs@webkit.org>
2543
2544         [Qt] ImageDiff does not consider --tolerance
2545         https://bugs.webkit.org/show_bug.cgi?id=66299
2546
2547         Reviewed by Csaba Osztrogonác.
2548
2549         * DumpRenderTree/qt/ImageDiff.cpp:
2550         (main):
2551
2552 2011-08-22  Csaba Osztrogonác  <ossy@webkit.org>
2553
2554         Update contributor list.
2555
2556         Reviewed by Zoltan Herczeg.
2557
2558         * Scripts/webkitpy/common/config/committers.py:
2559
2560 2011-08-22  Kristóf Kosztyó  <Kosztyo.Kristof@stud.u-szeged.hu>
2561
2562         [ORWT] Fix --reset-results --add-platform-exceptions combo
2563         https://bugs.webkit.org/show_bug.cgi?id=65464
2564
2565         Reviewed by Csaba Osztrogonác.
2566
2567         * Scripts/old-run-webkit-tests:
2568
2569 2011-08-20  Adam Barth  <abarth@webkit.org>
2570
2571         garden-o-matic summary.html should have UI for examining failures
2572         https://bugs.webkit.org/show_bug.cgi?id=66625
2573
2574         Reviewed by Dimitri Glazkov.
2575
2576         This patch introduces the notion of UI actions and converts our
2577         existing manual <button> manipulation with this new abstraction.  The
2578         patch also adds an Examine button to failure notifications.  In a
2579         future patch, I'll add a controller that wires this button up to
2580         something useful.
2581
2582         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
2583         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
2584         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js: Added.
2585         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions_unittests.js: Added.
2586         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
2587         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
2588         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
2589         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:
2590
2591 2011-08-20  Adam Barth  <abarth@webkit.org>
2592
2593         garden-o-matic summary page should indiciate compile failures
2594         https://bugs.webkit.org/show_bug.cgi?id=66624
2595
2596         Reviewed by Dimitri Glazkov.
2597
2598         This patch creates a notification-based UI for build failures.  The new
2599         UI displays the same information that used to be displayed in the
2600         infobar.  There's lots of room for improvement in surfacing more
2601         information, but this is a start.
2602
2603         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js:
2604         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
2605         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
2606
2607 2011-08-19  James Robinson  <jamesr@chromium.org>
2608
2609         [chromium] Default to experimental-fully-parallel mode for chromium gpu port
2610         https://bugs.webkit.org/show_bug.cgi?id=66606
2611
2612         Reviewed by Dirk Pranke.
2613
2614         The chromium GPU configuration does not (currently) contain any tests
2615         incompatible with --experimental-fully-parallel, and this flag is a
2616         significan speedup because of the directory canvas/philip/tests which
2617         contains 802 tests in the same directory. Setting this option by
2618         default on this configuration is a 2x speed in release, 44s to 22s,
2619         and a 3x speedup in debug, 223s to 77s, on linux on a 16 core machine.
2620
2621         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2622         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
2623         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2624
2625 2011-08-19  Sheriff Bot  <webkit.review.bot@gmail.com>
2626
2627         Unreviewed, rolling out r93426.
2628         http://trac.webkit.org/changeset/93426
2629         https://bugs.webkit.org/show_bug.cgi?id=66607
2630
2631         Broke the Mac build by not building gtest.framework anymore
2632         (Requested by andersca on #webkit).
2633
2634         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
2635
2636 2011-08-19  James Robinson  <jamesr@chromium.org>
2637
2638         [chromium] Chromium GPU layout tests should use the normal process number selection, not force 1 worker
2639         https://bugs.webkit.org/show_bug.cgi?id=66603
2640
2641         Reviewed by Dirk Pranke.
2642
2643         The various ChromiumGpu ports should use the same child worker
2644         selection logic as other ports so they can run with full
2645         parallelization on multicore systems.
2646
2647         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2648         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
2649
2650 2011-08-19  Alok Priyadarshi  <alokp@chromium.org>
2651
2652         [chromium] Remove dependency of WebThemeControlDRTWin on skia::PlatformCanvas
2653         https://bugs.webkit.org/show_bug.cgi?id=66570
2654
2655         Reviewed by Mihai Parparita.
2656
2657         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp:
2658         (WebThemeControlDRTWin::draw):
2659         (WebThemeControlDRTWin::drawTextField):
2660         (WebThemeControlDRTWin::drawProgressBar):
2661         * DumpRenderTree/chromium/WebThemeControlDRTWin.h:
2662
2663 2011-08-18  Dmitry Lomov  <dslomov@google.com>
2664
2665         TestWebKitAPI breaks on Windows due to fast malloc incompatibility.
2666         https://bugs.webkit.org/show_bug.cgi?id=66521
2667
2668         This patch ensures that gtest uses new and delete operators that are defined in JavaScriptCore.
2669
2670         Reviewed by David Levin.
2671
2672         * TestWebKitAPI/Tests/WTF/StringOperators.cpp: Removed redefinition of JS_EXPORTDATA.
2673
2674 2011-08-19  Adam Roben  <aroben@apple.com>
2675
2676         Add project file changes I left out in r93417
2677
2678         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2679
2680 2011-08-19  Adam Roben  <aroben@apple.com>
2681
2682         Add a helper class for swizzling ObjC instance methods to TestWebKitAPI
2683
2684         Fixes <http://webkit.org/b/66565> TestWebKitAPI needs a way to override instance methods of
2685         NSScreen
2686
2687         Reviewed by Anders Carlsson.
2688
2689         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new files.
2690
2691         * TestWebKitAPI/Tests/TestWebKitAPI/mac/InstanceMethodSwizzler.mm: Added.
2692         (-[SimpleObject setValue:]): Original implementation.
2693
2694         (TestWebKitAPI::setValue2):
2695         (TestWebKitAPI::setValue3):
2696         Swizzled implementations.
2697
2698         (TestWebKitAPI::TEST): Test that we can swizzle and re-swizzle and un-swizzle an ObjC
2699         instance method.
2700
2701         * TestWebKitAPI/mac/InstanceMethodSwizzler.h: Added.
2702         * TestWebKitAPI/mac/InstanceMethodSwizzler.mm: Added.
2703         (TestWebKitAPI::InstanceMethodSwizzler::InstanceMethodSwizzler): Swizzle the method.
2704         (TestWebKitAPI::InstanceMethodSwizzler::~InstanceMethodSwizzler): Unswizzle the method.
2705
2706 2011-08-19  Tom Zakrajsek  <tomz@codeaurora.org>
2707
2708         Fix _path_to_apache() error reporting
2709         https://bugs.webkit.org/show_bug.cgi?id=66486
2710
2711         Reviewed by Ryosuke Niwa.
2712
2713         * Scripts/webkitpy/layout_tests/port/webkit.py:
2714
2715 2011-08-19  Adam Roben  <aroben@apple.com>
2716
2717         Windows build fix after r93404
2718
2719         * TestWebKitAPI/Tests/WebKit2/win/HideFindIndicator.cpp: Added missing #include.
2720
2721 2011-08-19  Tony Gentilcore  <tonyg@chromium.org>
2722
2723         Add leandrogracia to the committers list
2724         https://bugs.webkit.org/show_bug.cgi?id=66552
2725
2726         Also fix line endings in file.
2727
2728         No reviewed required.
2729
2730         * Scripts/webkitpy/common/config/committers.py:
2731
2732 2011-08-19  Amruth Raj  <amruthraj@motorola.com>
2733
2734         Fix compilation issue in WebKitTestRunner
2735         https://bugs.webkit.org/show_bug.cgi?id=66554
2736
2737         Reviewed by Martin Robinson.
2738
2739         * WebKitTestRunner/PixelDumpSupport.cpp:
2740
2741 2011-08-19  Adam Roben  <aroben@apple.com>
2742
2743         Pull some of DynamicDeviceScaleFactor's code up into a shareable base class
2744
2745         This will make it easier to write other WebKit-agnostic tests
2746
2747         Fixes <http://webkit.org/b/66558> Would like to be able to reuse DynamicDeviceScaleFactor's
2748         code in other WebKit-agnostic tests
2749
2750         Reviewed by Anders Carlsson.
2751
2752         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new files.
2753
2754         * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm: Fixed copyright. Moved a bunch of
2755         code to WebKitAgnosticTest.h/mm. Changed to inherit from WebKitAgnosticTest.
2756         (TestWebKitAPI::DynamicDeviceScaleFactor::url): Simple getter.
2757         (TestWebKitAPI::DynamicDeviceScaleFactor::didLoadURL): Calls through to runTest.
2758         (TestWebKitAPI::DynamicDeviceScaleFactor::runTest): Removed loading code which
2759         WebKitAgnosticTest handles for us.
2760         (TestWebKitAPI::TEST_F): Removed view-creation code which WebKitAgnosticTest handles for us.
2761
2762         * TestWebKitAPI/mac/WebKitAgnosticTest.h: Added. Code came from DynamicDeviceScaleFactor.
2763         (TestWebKitAPI::WebKitAgnosticTest::loadAndWaitUntilDone): Code came from
2764         DynamicDeviceScaleFactor::runTest.
2765
2766         * TestWebKitAPI/mac/WebKitAgnosticTest.mm: Copied from Tools/TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm.
2767         (TestWebKitAPI::WebKitAgnosticTest::runWebKit1Test): Code came from
2768         DynamicDeviceScaleFactor.WebKit.
2769         (TestWebKitAPI::WebKitAgnosticTest::runWebKit2Test): Code came from
2770         DynamicDeviceScaleFactor.WebKit2.
2771
2772 2011-08-19  Adam Roben  <aroben@apple.com>
2773
2774         Clean up #includes in TestWebKitAPI
2775
2776         Fixes <http://webkit.org/b/66556> TestWebKitAPI's prefix header isn't very helpful
2777
2778         Reviewed by Anders Carlsson.
2779
2780         * TestWebKitAPI/TestWebKitAPIPrefix.h: Added wtf/Platform.h. Added gtest/gtest.h for C++
2781         files and WebKit/WebKit.h for ObjC files.
2782
2783         * TestWebKitAPI/InjectedBundleController.cpp:
2784         * TestWebKitAPI/JavaScriptTest.h:
2785         * TestWebKitAPI/PlatformUtilities.h:
2786         * TestWebKitAPI/PlatformWebView.h:
2787         * TestWebKitAPI/Test.h:
2788         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
2789         * TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
2790         * TestWebKitAPI/Tests/WTF/VectorReverse.cpp:
2791         * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp:
2792         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
2793         * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp:
2794         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
2795         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp:
2796         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
2797         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
2798         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
2799         * TestWebKitAPI/Tests/WebKit2/Find.cpp:
2800         * TestWebKitAPI/Tests/WebKit2/ForceRepaint.cpp:
2801         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
2802         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
2803         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp:
2804         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle_Bundle.cpp:
2805         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
2806         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic_Bundle.cpp:
2807         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
2808         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
2809         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
2810         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
2811         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly.cpp:
2812         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp:
2813         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
2814         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
2815         * TestWebKitAPI/Tests/WebKit2/WKString.cpp:
2816         * TestWebKitAPI/Tests/WebKit2/WKStringJSString.cpp:
2817         * TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp:
2818         * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp:
2819         * TestWebKitAPI/Tests/WebKit2/win/HideFindIndicator.cpp:
2820         * TestWebKitAPI/Tests/WebKit2/win/ResizeViewWhileHidden.cpp:
2821         * TestWebKitAPI/Tests/WebKit2/win/TranslateMessageGeneratesWMChar.cpp:
2822         * TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp:
2823         * TestWebKitAPI/Tests/WebKit2/win/WMPrint.cpp:
2824         * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm:
2825         * TestWebKitAPI/TestsController.cpp:
2826         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
2827         Removed now-unnecessary #includes. Moved #includes of Test.h in with the rest of the
2828         #includes since it is no longer a special header.
2829
2830 2011-08-18  Dirk Pranke  <dpranke@chromium.org>
2831
2832         new-run-webkit-tests hung while acquiring http lock on snow leopard bots
2833         https://bugs.webkit.org/show_bug.cgi?id=64886
2834
2835         Temporarily disable the http locking to work around the issue.
2836         I'm not actually sure if this is going to work or improve things
2837         much.
2838
2839         Reviewed by Ryosuke Niwa.
2840
2841         * Scripts/webkitpy/layout_tests/port/mac.py:
2842
2843 2011-08-18  Tony Chang  <tony@chromium.org>
2844
2845         add embedded png checksums to WebKitTestRunner
2846         https://bugs.webkit.org/show_bug.cgi?id=66494
2847
2848         Looks like WebKitTestRunner has never supported embedded checksums.  This copies
2849         some code from DRT and adds it to the WebKitTestRunner.
2850
2851         Reviewed by Darin Adler.
2852
2853         * WebKitTestRunner/CyclicRedundancyCheck.cpp: Copied from Tools/DumpRenderTree
2854         * WebKitTestRunner/CyclicRedundancyCheck.h: Copied from Tools/DumpRenderTree
2855         * WebKitTestRunner/GNUmakefile.am: Add new files
2856         * WebKitTestRunner/PixelDumpSupport.cpp: Copied from Tools/DumpRenderTree
2857         * WebKitTestRunner/PixelDumpSupport.h: Copied from Tools/DumpRenderTree
2858         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Add new files
2859         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
2860         (WTR::dumpBitmap): Refactor to use PixelDumpSupport.
2861         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
2862         * WebKitTestRunner/cg/TestInvocationCG.cpp:
2863         (WTR::dumpBitmap): Refactor to use PixelDumpSupport.
2864         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
2865         * WebKitTestRunner/win/WebKitTestRunner.vcproj: Add new files
2866
2867 2011-08-18  Shawn Singh  <shawnsingh@chromium.org>
2868
2869         https://bugs.webkit.org/show_bug.cgi?id=47240
2870
2871         Fixed a cygwin path problem in the chromium port of diff_image;
2872         Also made the return values of the diff_image function more consistent.
2873
2874         Reviewed by Dirk Pranke.
2875
2876         * Scripts/webkitpy/layout_tests/port/chromium.py:
2877
2878 2011-08-17  Alejandro G. Castro  <alex@igalia.com>
2879
2880         [GTK] Fix compilation problems with deprecations in gtk+
2881         https://bugs.webkit.org/show_bug.cgi?id=66073
2882
2883         Reviewed by Martin Robinson.
2884
2885         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2886         (main): G_CONST_RETURN was deprecated
2887         * GtkLauncher/main.c:
2888         (createWindow): Added gtk_box_new conditional compilation for
2889         gtk+-3.
2890         * MiniBrowser/gtk/BrowserWindow.c:
2891         (browser_window_init): Replaced gtk_vbox_new with gtk_box_new, we
2892         are just supporting gtk+-3 for WebKit2.
2893
2894 2011-08-18  Anders Carlsson  <andersca@apple.com>
2895
2896         Fix libc++ C++0x build
2897         https://bugs.webkit.org/show_bug.cgi?id=66479
2898
2899         Reviewed by Adam Roben.
2900
2901         Add missing includes.
2902
2903         * DumpRenderTree/LayoutTestController.cpp:
2904         * DumpRenderTree/mac/CheckedMalloc.cpp:
2905
2906 2011-08-18  Adam Roben  <aroben@apple.com>
2907
2908         Test that WebKit updates style when a WebView is moved between differently-scaled windows
2909
2910         Test for <http://webkit.org/b/66412> <rdar://problem/9971958> WebKit doesn't react when a
2911         WebView is moved between windows with different backing scale factors
2912
2913         Reviewed by Anders Carlsson.
2914
2915         * TestWebKitAPI/JavaScriptTest.cpp:
2916         (TestWebKitAPI::runJSTest): Moved a little bit of code from here...
2917         (TestWebKitAPI::compareJSResult): ...to here. Also made the error message more similar to
2918         gtest's built-in error messages.
2919
2920         * TestWebKitAPI/JavaScriptTest.h: Added overloads of runJSTest that take a WebView * and
2921         WKView * for convenience on Mac. Added compareJSResult helper function for implementing
2922         those overloads.
2923
2924         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new files.
2925
2926         * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm: Added.
2927         (-[FrameLoadDelegate initWithDidFinishLoadBoolean:]): Simple initializer.
2928         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]): Record that the load finished.
2929         (TestWebKitAPI::didFinishLoadForFrame): Record that the load finished.
2930         (TestWebKitAPI::setPageLoaderClient): Set up the client.
2931         (TestWebKitAPI::DynamicDeviceScaleFactor::DynamicDeviceScaleFactor): Simple constructor.
2932         (TestWebKitAPI::DynamicDeviceScaleFactor::createWindow): Creates a
2933         SyntheticBackingScaleFactorWindow and returns it.
2934         (TestWebKitAPI::DynamicDeviceScaleFactor::runTest): Loads devicePixelRatio.html and checks
2935         that WebKit uses the correct scale factor when the WebView is not in a window, is put in a
2936         window, is moved to a differently-scaled window, and is taken out of the window.
2937         (TestWebKitAPI::DynamicDeviceScaleFactor::loadURL): Helper function with overloads for
2938         WebKit1 and WebKit2.
2939         (TestWebKitAPI::TEST_F): Runs the test, with overloads for WebKit1 and WebKit2.
2940
2941         * TestWebKitAPI/Tests/mac/devicePixelRatio.html: Added.
2942
2943         * TestWebKitAPI/mac/JavaScriptTestMac.mm: Added.
2944         (TestWebKitAPI::runJSTest): Fairly simple overloads for WebView * and WKView *.
2945
2946         * TestWebKitAPI/mac/SyntheticBackingScaleFactorWindow.h: Added.
2947         * TestWebKitAPI/mac/SyntheticBackingScaleFactorWindow.m: Added.
2948         (-[SyntheticBackingScaleFactorWindow initWithContentRect:styleMask:backing:defer:]): Simple
2949         initializer.
2950         (-[SyntheticBackingScaleFactorWindow setBackingScaleFactor:]): Simple setter.
2951
2952         (-[SyntheticBackingScaleFactorWindow backingScaleFactor]):
2953         (-[SyntheticBackingScaleFactorWindow userSpaceScaleFactor]):
2954         Overrides of NSWindow methods that WebKit uses to determine the device scale factor.
2955
2956 2011-08-18  Dmitry Lomov  <dslomov@google.com>
2957
2958         https://bugs.webkit.org/show_bug.cgi?id=66425
2959         check-webkit-style should detect incorrectly formatted file change descriptions.
2960         Description, if present, should be separated from colon with a space.
2961
2962         Reviewed by David Levin.
2963
2964         * Scripts/webkitpy/style/checkers/changelog.py: Fix.
2965         * Scripts/webkitpy/style/checkers/changelog_unittest.py: Unit tests.
2966
2967 2011-08-18  Adam Barth  <abarth@webkit.org>
2968
2969         webkit-patch pretty-diff should be shown in main help
2970         https://bugs.webkit.org/show_bug.cgi?id=66404
2971
2972         Reviewed by Dimitri Glazkov.
2973
2974         As requested by dglazkov.
2975
2976         * Scripts/webkitpy/tool/commands/prettydiff.py:
2977
2978 2011-08-17  Dmitry Lomov  <dslomov@google.com>
2979
2980         https://bugs.webkit.org/show_bug.cgi?id=66400
2981         Fix TestWebKitAPI build on Mac OS.
2982
2983         Reviewed by David Levin.
2984
2985         * TestWebKitAPI/Configurations/Base.xcconfig: Added ICU headers to the HEADER_SEARCH_PATH.
2986
2987 2011-08-17  Dimitri Glazkov  <dglazkov@chromium.org>
2988
2989         garden-o-matic spring cleaning: move scripts, styles, and images in the respective directories.
2990         https://bugs.webkit.org/show_bug.cgi?id=66427
2991
2992         Reviewed by Adam Barth.
2993
2994         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Bugzilla.js: Removed.
2995         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot.js: Removed.
2996         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot_unittests.js: Removed.
2997         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js: Removed.
2998         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js: Removed.
2999         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm.js: Removed.
3000         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm_unittests.js: Removed.
3001         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector.js: Removed.
3002         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector_unittests.js: Removed.
3003         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyTestBugForm.js: Removed.
3004         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyTestBugForm_unittests.js: Removed.
3005         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js: Removed.
3006         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js: Removed.
3007         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NRWTResultsParser.js: Removed.
3008         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NewBugForm.js: Removed.
3009         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NewBugForm_unittests.js: Removed.
3010         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ORWTResultsParser.js: Removed.
3011         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/PersistentCache.js: Removed.
3012         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css: Removed.
3013         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestRelatedBugForm.js: Removed.
3014         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestRelatedBugForm_unittests.js: Removed.
3015         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js: Removed.
3016         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js: Removed.
3017         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities_unittests.js: Removed.
3018         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js: Removed.
3019         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBugzilla.js: Removed.
3020         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBuildbot.js: Removed.
3021         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js: Removed.
3022         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js: Removed.
3023         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/bugzilla_unittests.js: Removed.
3024         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders.js: Removed.
3025         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders_unittests.js: Removed.
3026         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js: Removed.
3027         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout_unittests.js: Removed.
3028         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js: Removed.
3029         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers: Removed.
3030         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers.js: Removed.
3031         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers/rebaseline.js: Removed.
3032         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/favicon-green.png: Removed.
3033         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/favicon-red.png: Removed.
3034         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
3035         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images: Added.
3036         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images/favicon-green.png: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/favicon-green.png.
3037         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images/favicon-red.png: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/favicon-red.png.
3038         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html:
3039         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css: Removed.
3040         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js: Removed.
3041         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js: Removed.
3042         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model_unittests.js: Removed.
3043         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net.js: Removed.
3044         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net_unittests.js: Removed.
3045         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/rebaseline.html:
3046         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js: Removed.
3047         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results_unittests.js: Removed.
3048         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
3049         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Bugzilla.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Bugzilla.js.
3050         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Buildbot.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot.js.
3051         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Buildbot_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot_unittests.js.
3052         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Builder.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js.
3053         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Builder_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js.
3054         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/FailingTestsBugForm.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm.js.
3055         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/FailingTestsBugForm_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm_unittests.js.
3056         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/FlakyLayoutTestDetector.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector.js.
3057         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/FlakyLayoutTestDetector_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector_unittests.js.
3058         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/FlakyTestBugForm.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyTestBugForm.js.
3059         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/FlakyTestBugForm_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyTestBugForm_unittests.js.
3060         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/LayoutTestHistoryAnalyzer.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js.
3061         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/LayoutTestResultsLoader.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js.
3062         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/NRWTResultsParser.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NRWTResultsParser.js.
3063         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/NewBugForm.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NewBugForm.js.
3064         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/NewBugForm_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NewBugForm_unittests.js.
3065         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ORWTResultsParser.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ORWTResultsParser.js.
3066         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/PersistentCache.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/PersistentCache.js.
3067         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/TestRelatedBugForm.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestRelatedBugForm.js.
3068         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/TestRelatedBugForm_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestRelatedBugForm_unittests.js.
3069         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Trac.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js.
3070         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Utilities.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js.
3071         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Utilities_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities_unittests.js.
3072         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ViewController.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js.
3073         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/WebKitBugzilla.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBugzilla.js.
3074         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/WebKitBuildbot.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBuildbot.js.
3075         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js.
3076         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js.
3077         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/bugzilla_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/bugzilla_unittests.js.
3078         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders.js.
3079         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders_unittests.js.
3080         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js.
3081         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout_unittests.js.
3082         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js.
3083         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers.
3084         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers.js.
3085         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/main.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js.
3086         ():
3087         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js.
3088         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model_unittests.js.
3089         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/net.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net.js.
3090         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/net_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net_unittests.js.
3091         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js.
3092         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results_unittests.js.
3093         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/trac_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/trac_unittests.js.
3094         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js.
3095         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results.js.
3096         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results_unittests.js.
3097         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js.
3098         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/unexpected-passes.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/unexpected-passes.js.
3099         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/TestFailures.css: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css.
3100         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/main.css: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css.
3101         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:
3102         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/trac_unittests.js: Removed.
3103         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js: Removed.
3104         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results.js: Removed.
3105         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results_unittests.js: Removed.
3106         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js: Removed.
3107         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/unexpected-passes.html:
3108         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/unexpected-passes.js: Removed.
3109
3110 2011-08-17  Jochen Eisinger  <jochen@chromium.org>
3111
3112         Make SVNTest.test_svn_apply use the same timezone logic as VCSUtils.pm
3113         https://bugs.webkit.org/show_bug.cgi?id=65877
3114
3115         Reviewed by Eric Seidel.
3116
3117         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3118
3119 2011-08-17  Dimitri Glazkov  <dglazkov@chromium.org>
3120
3121         Remove base.keys and replace it with Object.keys.
3122         https://bugs.webkit.org/show_bug.cgi?id=66422
3123
3124         Reviewed by Adam Barth.
3125
3126         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js: Removed base.keys.
3127         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js: Removed unit tests for it.
3128         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js: Replaced with Object.keys
3129
3130 2011-08-17  Dimitri Glazkov  <dglazkov@chromium.org>
3131
3132         garden-o-matic Summary view should have items in descending chronological order.
3133         https://bugs.webkit.org/show_bug.cgi?id=66403
3134
3135         Reviewed by Adam Barth.
3136
3137         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js: Renamed "push" to "add" for clarity, cleaned up some stuff.
3138         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Rewrote add to insert DOM elements in order.
3139         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Added unit tests.
3140
3141 2011-08-17  Dimitri Glazkov  <dglazkov@chromium.org>
3142
3143         Fix a few errors in garden-o-matic frontend unit tests.
3144         https://bugs.webkit.org/show_bug.cgi?id=66421
3145
3146         Reviewed by Adam Barth.
3147
3148         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js: Changed my excellent test to view time as variable continuum.
3149         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders_unittests.js: Tweaked the test to accommodate new builder names.
3150         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Hurriedly covered up my prior sins.
3151
3152 2011-08-17  Adam Barth  <abarth@webkit.org>
3153
3154         Update Tools to account for (CG) being added to Chromium builder names
3155         https://bugs.webkit.org/show_bug.cgi?id=66410
3156
3157         Reviewed by Adam Barth.
3158
3159         Some of these names will change back once we turn on Skia bots.
3160
3161         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders_unittests.js:
3162         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js:
3163         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js:
3164         * Scripts/webkitpy/layout_tests/port/builders.py:
3165         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3166         * TestResultServer/static-dashboards/builders.js:
3167         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
3168
3169 2011-08-16  Dimitri Glazkov  <dglazkov@chromium.org>
3170
3171         Wire up relative time to garden-o-matic summary view.
3172         https://bugs.webkit.org/show_bug.cgi?id=66343
3173
3174         Reviewed by Adam Barth.
3175
3176         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js: Add time to the commitData object. 
3177         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model_unittests.js: Adjusted unit tests.
3178         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Wired up relative date.
3179         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Updated unit tests.
3180         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/trac_unittests.js: Adjusted unit tests.
3181
3182 2011-08-17  Adam Roben  <aroben@apple.com>
3183
3184         Make run-api-tests run tests in alphabetical order
3185
3186         Fixes <http://webkit.org/b/66401> run-api-tests runs tests in a semi-random order
3187
3188         Reviewed by David Kilzer.
3189
3190         * Scripts/run-api-tests:
3191         (runAllTests):
3192         (runAllTestsInSuite):
3193         Sort the lists of tests and suites before iterating over them.
3194
3195 2011-08-17  Adam Barth  <abarth@webkit.org>
3196
3197         garden-o-matic should be able to rebaseline expected failures
3198         https://bugs.webkit.org/show_bug.cgi?id=66204
3199
3200         Reviewed by Dimitri Glazkov.
3201
3202         This patch introduces a new view for displaying expect, actual, and
3203         differences between results.  The new view also has a fledgling
3204         controller that handles some basic operations.  The new view is
3205         exercised by rebaseline.html, which lets you rebaselines expected
3206         failures, but the new view is not fully integrated into
3207         garden-o-matic.html
3208
3209         More patches will be required to make this stuff fully working, but
3210         this patch was already somewhat spiraling out of control.  Hopefully
3211         this patch will serve as a good starting point for further development.
3212
3213         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers: Added.
3214         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers.js: Added.
3215         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers/rebaseline.js: Added.
3216         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
3217         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css:
3218         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
3219         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/rebaseline.html: Added.
3220         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js:
3221         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
3222         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
3223         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results.js:
3224         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results_unittests.js: Added.
3225
3226 2011-08-16  Chang Shu  <cshu@webkit.org>
3227
3228         Support reset in WebCore::Internals
3229         https://bugs.webkit.org/show_bug.cgi?id=66307
3230
3231         Reviewed by Dimitri Glazkov.
3232
3233         Added call to resetInternalsObject in DRT.
3234
3235         * DumpRenderTree/chromium/TestShell.cpp:
3236         (TestShell::resetTestController):
3237         * DumpRenderTree/mac/DumpRenderTree.mm:
3238         (resetWebViewToConsistentStateBeforeTesting):
3239         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3240         (WebCore::WebPage::resetSettings):
3241
3242 2011-08-17  Alexis Menard  <alexis.menard@openbossa.org>
3243
3244         Add a new build slave for the Qt port on Mac OS SnowLeopard.
3245         https://bugs.webkit.org/show_bug.cgi?id=66392
3246
3247         Modify the config file to include the new build slave.
3248
3249         Reviewed by Adam Roben.
3250
3251         * BuildSlaveSupport/build.webkit.org-config/config.json:
3252
3253 2011-08-17  Sam White  <samuel.white@rochester.edu>
3254
3255         AccessibilityObject levels are inconsistent
3256         https://bugs.webkit.org/show_bug.cgi?id=66180
3257         
3258         Added the ability to get numeric attribute values using numberAttributeValue. This
3259         function complements the existing stringAttributeValue and boolAttributeValue functions.
3260         The addition of numberAttributeValue was necessary because the stringAttributeValue
3261         function does a type check and will only return strings. This limitation made it
3262         impossible to get values for attributes that returned an NSNumber.
3263
3264         Reviewed by Chris Fleizach.
3265
3266         * DumpRenderTree/AccessibilityUIElement.cpp:
3267         (numberAttributeValueCallback):
3268         (AccessibilityUIElement::getJSClass):
3269         * DumpRenderTree/AccessibilityUIElement.h:
3270         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3271         (AccessibilityUIElement::numberAttributeValue):
3272         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3273         (AccessibilityUIElement::numberAttributeValue):
3274         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3275         (AccessibilityUIElement::numberAttributeValue):
3276
3277 2011-08-17  Adam Roben  <aroben@apple.com>
3278
3279         Tell Trac logs always to display all specified revisions in a single page
3280
3281         Trac imposes a default limit of 100 revisions per log page. We need to tell it to allow more
3282         revisions than that.
3283
3284         Fixes <http://webkit.org/b/66373> Links to Trac from TestFailures page don't always show all
3285         relevant revisions
3286
3287         Reviewed by Daniel Bates.
3288
3289         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js:
3290         (trac.logURL): Add a limit parameter to the log URL that allows all revisions to be seen in
3291         a single page.
3292
3293         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm_unittests.js:
3294         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/trac_unittests.js:
3295         Updated tests for the above.
3296
3297 2011-08-17  Adam Roben  <aroben@apple.com>
3298
3299         Fix TestFailures's link to file a bug about TestFailures itself
3300
3301         Fixes <http://webkit.org/b/66387> REGRESSION (r92135): TestFailures page's link to file a
3302         bug about itself is broken
3303
3304         Reviewed by Dan Bates.
3305
3306         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
3307         (ViewController.prototype._domForAuxiliaryUIElements): Added a path separator to separate
3308         the host from the path.
3309
3310 2011-08-17  Adam Roben  <aroben@apple.com>
3311
3312         Teach TestFailures to ignore unbelievably short test runs
3313
3314         Fixes <http://webkit.org/b/66385> TestFailures page thinks all tests passed in
3315         http://build.webkit.org/builders/Windows%207%20Release%20(Tests)/builds/14956
3316
3317         Reviewed by Dan Bates.
3318
3319         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
3320         (Builder.prototype.getNumberOfFailingTests): If it looks like all tests passed, but
3321         run-webkit-tests took less than 10 seconds to run, assume that some weird error occurred
3322         that caused it not to run any tests at all (as happened for a while due to
3323         <http://webkit.org/b/64988>). Bumped the cache version to evict old, buggy cached data.
3324
3325         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js:
3326         Test for the above.
3327
3328         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js:
3329         (LayoutTestResultsLoader.prototype.start): Bumped the cache version to evict old, buggy cached data.
3330
3331 2011-08-16  Adam Barth  <abarth@webkit.org>
3332
3333         Add a CG qualifier similar to the GPU qualifier
3334         https://bugs.webkit.org/show_bug.cgi?id=66359
3335
3336         Reviewed by Eric Seidel.
3337
3338         Once we have a Skia configuration on Chromium Mac, we'll use this CG
3339         qualifier to note that expectations apply only to the CG configuration.
3340
3341         * Scripts/webkitpy/layout_tests/port/chromium.py:
3342         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
3343
3344 2011-08-16  Eric Seidel  <eric@webkit.org>
3345
3346         REGRESSION(92717): WinPort needs to parse version information from port_name
3347         https://bugs.webkit.org/show_bug.cgi?id=66325
3348
3349         Unreviewed.  Fixing an exception/typo seen on the bots (and testing to make sure it works).
3350
3351         * Scripts/webkitpy/layout_tests/port/mac.py:
3352         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3353
3354 2011-08-16  Adam Barth  <abarth@webkit.org>
3355
3356         Change webkit-patch analyze-baselines to print in a more unix-friendly way
3357         https://bugs.webkit.org/show_bug.cgi?id=66349
3358
3359         Reviewed by James Robinson.
3360
3361         As requested by jamesr.
3362
3363         * Scripts/webkitpy/tool/commands/rebaseline.py:
3364
3365 2011-08-16  Eric Seidel  <eric@webkit.org>
3366
3367         REGRESSION(92717): WinPort needs to parse version information from port_name
3368         https://bugs.webkit.org/show_bug.cgi?id=66325
3369
3370         Reviewed by Adam Barth.
3371
3372         WinPort didn't have any port_name parsing logic.
3373         Seemed it was best to just share the logic from MacPort.
3374         Sharing the logic from MacPort seemed easiest with a shared superclass.
3375         Once I created ApplePort (the superclass) there was a bunch of logic to share.
3376         I found LeakDetector was just in the way when switching back and forth
3377         between win.py and mac.py so I moved it into its own file.
3378
3379         The only logic change here is that WinPort should now be
3380         able to parse port_name values like MacPort (and other ports)
3381         can.  The fact that ports do this in their constructors is
3382         wrong and a source of many bugs.  But at least now WinPort
3383         matches the status-quo.
3384
3385         * Scripts/webkitpy/layout_tests/port/apple.py: Added.
3386         * Scripts/webkitpy/layout_tests/port/leakdetector.py: Added.
3387         * Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py: Added.
3388         * Scripts/webkitpy/layout_tests/port/mac.py:
3389         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3390         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3391         * Scripts/webkitpy/layout_tests/port/win.py:
3392         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
3393
3394 2011-08-16  Adam Barth  <abarth@webkit.org>
3395
3396         Add webkit-patch analyze-baselines, as requested by jamesr.
3397
3398         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
3399         * Scripts/webkitpy/tool/commands/rebaseline.py:
3400
3401 2011-08-16  Adam Barth  <abarth@webkit.org>
3402
3403         Fold bulk-optimize-baselines into optimize-baselines
3404         https://bugs.webkit.org/show_bug.cgi?id=66345
3405
3406         Reviewed by James Robinson.
3407
3408         bulk-optimize-baselines is now a superset of optimize-baselines, so
3409         they can be combined.
3410
3411         * Scripts/webkitpy/tool/commands/rebaseline.py:
3412
3413 2011-08-16  Adam Barth  <abarth@webkit.org>
3414
3415         Move chromium-mac to chromium-cg-mac to prepare for Skia switchover
3416         https://bugs.webkit.org/show_bug.cgi?id=66334
3417
3418         Reviewed by Tony Chang.
3419
3420         This patch moves us closer to switching the Chromium port from
3421         CoreGraphics to Skia.  This patch teaches our tools that the current
3422         Chromium Mac configuration is actually chromium-cg-mac, which makes
3423         room for a future chromium-mac configuration that uses Skia.
3424
3425         Shortly after this patch lands, I'll do a server-side move of the
3426         chromium-mac and chromium-mac-leopard directories to chromium-cg-mac
3427         and chromium-cg-mac-leopard.
3428
3429         * BuildSlaveSupport/build.webkit.org-config/config.json:
3430         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
3431         * Scripts/webkitpy/common/config/build.py:
3432         * Scripts/webkitpy/common/config/build_unittest.py:
3433         * Scripts/webkitpy/layout_tests/port/base.py:
3434         * Scripts/webkitpy/layout_tests/port/builders.py:
3435         * Scripts/webkitpy/layout_tests/port/chromium.py:
3436         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3437         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
3438         * Scripts/webkitpy/layout_tests/port/dryrun.py:
3439         * Scripts/webkitpy/layout_tests/port/factory.py:
3440         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
3441         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
3442         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
3443         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
3444         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
3445         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3446         * TestResultServer/static-dashboards/flakiness_dashboard.html:
3447
3448 2011-08-16  Dimitri Glazkov  <dglazkov@chromium.org>
3449
3450         garden-o-matic frontend needs a friendly relative time description method.
3451         https://bugs.webkit.org/show_bug.cgi?id=66324
3452
3453         Reviewed by Adam Barth.
3454
3455         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js: Added base.relativizeTime method.
3456         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js: Added unit tests.
3457         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Wired up Time widget to use it.
3458
3459 2011-08-16  Dimitri Glazkov  <dglazkov@chromium.org>
3460
3461         Summary view should not add multiple entries for the same test failure.
3462         https://bugs.webkit.org/show_bug.cgi?id=66318
3463
3464         Reviewed by Adam Barth.
3465
3466         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js: Added a simplistic updating button.
3467         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Added ways to check for
3468             equality of ui.notifications.FailingTest, and whether ui.notifications.TestFailures already contains a given failure analysis.
3469         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Added tests.
3470
3471 2011-08-16  Adam Roben  <aroben@apple.com>
3472
3473         Teach TestFailures that tests that have failed or passed many times in a row are not flaky
3474
3475         The basic strategy here is that once a test has failed or passed many times in a row we
3476         never again consider it as a possibly flaky test. It's a simple strategy but seems to result
3477         in many fewer false positives than our current behavior.
3478
3479         Fixes <http://webkit.org/b/66327> TestFailures page considers far too many tests to be
3480         flaky, including tests that failed for a while but then were fixed
3481
3482         Reviewed by Dan Bates.
3483
3484         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector.js:
3485         (FlakyLayoutTestDetector): Initialize new _buildCount property, which is used to track the
3486         number of non-too-many-failure builds we've seen.
3487         (FlakyLayoutTestDetector.prototype.incorporateTestResults): Don't track tests which haven't
3488         failed in the _maximumFailOrPassCount most recent builds. For other not-yet-considered-flaky
3489         tests, keep track of how many times they have passed or failed in a row. If they pass or
3490         fail more than _maximumFailOrPassCount times, consider them to be non-flaky. (Once a test is
3491         considered flaky it doesn't matter how many times it passes or fails.)
3492
3493         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector_unittests.js:
3494         Added tests for the above.
3495
3496 2011-08-16  Dimitri Glazkov  <dglazkov@chromium.org>
3497
3498         garden-o-matic needs a summary view with actions for each problem.
3499         https://bugs.webkit.org/show_bug.cgi?id=66144
3500
3501         Reviewed by Adam Barth.
3502
3503         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html: Added notifications tests.
3504         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js: Added.
3505         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Added.
3506         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Added.
3507         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/summary.css: Added.
3508         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Added.
3509
3510 2011-08-16  Dean Jackson  <dino@apple.com>
3511
3512         Adding Ted "hober" O'Connor as a non-committing contributor.
3513
3514         * Scripts/webkitpy/common/config/committers.py:
3515
3516 2011-08-16  Adam Roben  <aroben@apple.com>
3517
3518         Teach TestFailures how to interpret unfinished test runs
3519
3520         Fixes <http://webkit.org/b/66309> TestFailures thinks all tests passed in
3521         http://build.webkit.org/builders/Lion%20Intel%20Debug%20(Tests)/builds/136
3522
3523         Reviewed by David Kilzer.
3524
3525         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
3526         (Builder.prototype.getNumberOfFailingTests): Look for "isFinished" in the layout-test step
3527         rather than "isStarted" so that we don't count builds for which the test run never finished.
3528         Bumped the cache version to evict old, buggy cached data.
3529
3530         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js:
3531         Added a test for the above, and made a somewhat synthetic test more realistic by including
3532         more of the actual JSON data from build.webkit.org.
3533
3534         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js:
3535         (LayoutTestResultsLoader.prototype.start): Bumped the cache version to evict old, buggy
3536         cached data.
3537
3538 2011-08-16  Adam Roben  <aroben@apple.com>
3539
3540         Make Apple's Windows port fall back to Lion results instead of SnowLeopard
3541
3542         Apple's Windows port now uses Lion-era versions of CoreFoundation, ICU, etc., so in theory
3543         should match Lion's behavior.
3544
3545         Fixes <http://webkit.org/b/66302> Apple's Windows port matches Lion for some test results,
3546         but doesn't use Lion results
3547
3548         Reviewed by David Kilzer.
3549
3550         * Scripts/old-run-webkit-tests:
3551         (expectedDirectoryForTest):
3552         * Scripts/webkitpy/layout_tests/port/win.py:
3553         (WinPort.baseline_search_path):
3554         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
3555         (WinPortTest.test_baseline_search_path):
3556         Replaced mac-snowleopard with mac-lion.
3557
3558         * Scripts/webkitpy/common/config/build.py:
3559         (_should_file_trigger_build): Added an entry for the LayoutTests/platform/mac-lion
3560         directory, which all Apple Mac platforms and Apple Win platforms could potentially use
3561         results from. Removed Apple Win from being affected by mac-snowleopard changes, since it
3562         will no longer look there for results.
3563
3564         * Scripts/webkitpy/common/config/build_unittest.py:
3565         (ShouldBuildTest.test_should_build): Tests for the above changes.
3566
3567 2011-08-16  Dean Jackson  <dino@apple.com>
3568
3569         Move me from contributor to reviewer.
3570
3571         * Scripts/webkitpy/common/config/committers.py:
3572
3573 2011-08-15  Dimitri Glazkov  <dglazkov@chromium.org>
3574
3575         garden-o-matic frontend needs model.commitDataForRevisionRange function.
3576         https://bugs.webkit.org/show_bug.cgi?id=66252
3577
3578         Reviewed by Adam Barth.
3579
3580         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js: Added commitDataForRevisionRange method.
3581         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model_unittests.js: Added tests.
3582
3583 2011-08-15  Dimitri Glazkov  <dglazkov@chromium.org>
3584
3585         garden-o-matic frontend needs a generic way to track updates.
3586         https://bugs.webkit.org/show_bug.cgi?id=66245
3587
3588         Reviewed by Adam Barth.
3589
3590         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js: Added UpdateTracker.
3591         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js: Added tests.
3592
3593 2011-08-15  Adam Roben  <aroben@apple.com>
3594
3595         Teach TestWebKitAPI/gtest how to print JavaScript failures nicely
3596
3597         Failures now give output of the form: foo should be bar but is baz
3598
3599         Fixes <http://webkit.org/b/66240> It's hard to tell what the actual result of a failed JS
3600         test is in TestWebKitAPI's output
3601
3602         Reviewed by David Levin.
3603
3604         * TestWebKitAPI/JavaScriptTest.cpp:
3605         (TestWebKitAPI::JavaScriptCallbackContext::JavaScriptCallbackContext): Removed now-unused
3606         members.
3607         (TestWebKitAPI::javaScriptCallback): Changed to just store the result string in the context
3608         object, rather than doing any testing of it here.
3609         (TestWebKitAPI::runJSTest): Made this function a gtest predicate-formatter. This allows us
3610         to use a pretty error message when the test fails.
3611
3612         * TestWebKitAPI/JavaScriptTest.h: Changed runJSTest to a predicate-formatter, and added nice
3613         gtest-style macros that wrap it.
3614
3615         * TestWebKitAPI/Test.h: Removed now-unused TEST_ASSERT_RETURN.
3616
3617         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
3618         (TestWebKitAPI::TEST): Changed to use the new macros.
3619
3620         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp:
3621         (TestWebKitAPI::createSessionStateContainingFormData): Ditto. Note that this function no
3622         longer returns 0 when the JS test fails. That shouldn't have any effect on whether or not
3623         the test passes, though. Returning early seems to have been an unnecessary optimization.
3624
3625         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
3626         (TestWebKitAPI::TEST): Changed to use the new macros.
3627
3628 2011-08-15  Eric Seidel  <eric@webkit.org>
3629
3630         Move the Leaks bot back to ORWT until I can fix LeaksViewer regressions filed by Adam Roben in bug 66227 and 66228.
3631
3632         Unreviewed.
3633
3634         * Scripts/run-webkit-tests:
3635         (usingLeaks):
3636         (useNewRunWebKitTests):
3637
3638 2011-08-14  Adam Barth  <abarth@webkit.org>
3639
3640         Switch results detail view over to new-style object-oriented UI widgets
3641         https://bugs.webkit.org/show_bug.cgi?id=66200
3642
3643         Reviewed by Dimitri Glazkov.
3644
3645         This patch replaces my goofy template-based UI for the results
3646         comparison screen with new object-oriented UI widgets.
3647
3648         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
3649         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css:
3650         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
3651         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
3652         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
3653         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results.js: Added.
3654         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js:
3655
3656 2011-08-13  Dimitri Glazkov  <dglazkov@chromium.org>
3657
3658         garden-o-matic's analyzeUnexpectedFailures needs a completion callback.
3659         https://bugs.webkit.org/show_bug.cgi?id=66166
3660
3661         Also changed base.RequestTracker to:
3662         a) fire callback immediately if requestsInFlight is 0;
3663         b) not barf if callback is not supplied.
3664
3665         Reviewed by Adam Barth.
3666
3667         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js: Started using completion callback.
3668         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js: Added completion callback.
3669         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js: Changed RequestTracker.
3670         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittest.js: Added unit tests.
3671
3672 2011-08-12  Mark Rowe  <mrowe@apple.com>
3673
3674         Be more forward-looking in the choice of compiler.
3675
3676         Rubber-stamped by Jon Honeycutt.
3677
3678         * DumpRenderTree/mac/Configurations/CompilerVersion.xcconfig:
3679         * MiniBrowser/Configurations/CompilerVersion.xcconfig:
3680         * TestWebKitAPI/Configurations/CompilerVersion.xcconfig:
3681         * WebKitTestRunner/Configurations/CompilerVersion.xcconfig:
3682
3683 2011-08-12  Sadrul Habib Chowdhury  <sadrul@chromium.org>
3684
3685         DRT: Add support for gesture events.
3686         https://bugs.webkit.org/show_bug.cgi?id=66105
3687
3688         Reviewed by Darin Fisher.
3689
3690         * DumpRenderTree/chromium/EventSender.cpp:
3691         (EventSender::EventSender):
3692         (EventSender::gestureScrollBegin):
3693         (EventSender::gestureScrollEnd):
3694         (EventSender::gestureTap):
3695         (EventSender::gestureEvent):
3696         * DumpRenderTree/chromium/EventSender.h:
3697
3698 2011-08-12  Andy Estes  <aestes@apple.com>
3699
3700         allowRoundingHacksCallback uses the wrong argument for 'thisObject'.
3701         https://bugs.webkit.org/show_bug.cgi?id=66158
3702
3703         Reviewed by Dan Bernstein.
3704
3705         * DumpRenderTree/LayoutTestController.cpp:
3706         (allowRoundingHacksCallback): The third argument is the 'this'
3707         JSObjectRef, not the second.
3708
3709 2011-08-12  Andy Estes  <aestes@apple.com>
3710
3711         Cancel in onbeforeunload dialog sometime causes a button to stop working.
3712         https://bugs.webkit.org/show_bug.cgi?id=26211
3713
3714         Reviewed by Alexey Proskuryakov.
3715
3716         Implement a new LayoutTestController method that a test can call to set
3717         the return value of DumpRenderTree's beforeunload UI delegate.
3718
3719         * DumpRenderTree/LayoutTestController.cpp:
3720         (LayoutTestController::LayoutTestController): Initialize
3721         m_shouldStayOnPageAfterHandlingBeforeUnload.
3722         (setShouldStayOnPageAfterHandlingBeforeUnloadCallback): Call
3723         LayoutTestController::setShouldStayOnPageAfterHandlingBeforeUnload().
3724         (LayoutTestController::staticFunctions): Register
3725         'setShouldStayOnPageAfterHandlingBeforeUnload' as a static function.
3726         * DumpRenderTree/LayoutTestController.h: 
3727         (LayoutTestController::shouldStayOnPageAfterHandlingBeforeUnload):
3728         (LayoutTestController::setShouldStayOnPageAfterHandlingBeforeUnload):
3729         * DumpRenderTree/chromium/LayoutTestController.cpp:
3730         (LayoutTestController::LayoutTestController): Initialize
3731         m_shouldStayOnPageAfterHandlingBeforeUnload and bind
3732         'setShouldStayOnPageAfterHandlingBeforeUnload' to its c++ setter.
3733         (LayoutTestController::reset): Reset
3734         m_shouldStayOnPageAfterHandlingBeforeUnload to false.
3735         (LayoutTestController::setShouldStayOnPageAfterHandlingBeforeUnload):
3736         Set m_shouldStayOnPageAfterHandlingBeforeUnload to the value passed in
3737         from JavaScript.
3738         * DumpRenderTree/chromium/LayoutTestController.h:
3739         (LayoutTestController::shouldStayOnPageAfterHandlingBeforeUnload):
3740         * DumpRenderTree/chromium/WebViewHost.cpp:
3741         (WebViewHost::runModalBeforeUnloadDialog): Add the correct logging and
3742         return the inverse of
3743         LayoutTestController::shouldStayOnPageAfterHandlingBeforeUnload().
3744         * DumpRenderTree/mac/UIDelegate.mm:
3745         (-[UIDelegate webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:]): Ditto.
3746         * DumpRenderTree/win/UIDelegate.cpp:
3747         (UIDelegate::runBeforeUnloadConfirmPanelWithMessage): Ditto.
3748         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
3749         Define setShouldStayOnPageAfterHandlingBeforeUnload().
3750         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3751         (WTR::InjectedBundle::postNewBeforeUnloadReturnValue): Post a message
3752         to the Test Controller telling it what value it should return in its
3753         onbeforeunload UI delegate.
3754         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3755         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3756         (WTR::LayoutTestController::setShouldStayOnPageAfterHandlingBeforeUnload):
3757         Call InjectedBundle::postNewBeforeUnloadReturnValue().
3758         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3759         * WebKitTestRunner/TestController.cpp:
3760         (WTR::TestController::TestController): Initialize
3761         m_beforeUnloadReturnValue to true.
3762         (WTR::runBeforeUnloadConfirmPanel): Add the correct logging and return
3763         the value of TestController::beforeUnloadReturnValue().
3764         (WTR::TestController::resetStateToConsistentValues): Reset
3765         m_beforeUnloadReturnValue to true.
3766         * WebKitTestRunner/TestController.h:
3767         (WTR::TestController::beforeUnloadReturnValue):
3768         (WTR::TestController::setBeforeUnloadReturnValue):
3769         * WebKitTestRunner/TestInvocation.cpp:
3770         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Handle the
3771         message posted from the injected bundle by retrieving the message body
3772         as a WKBoolean and calling TestController::setBeforeUnloadReturnValue().
3773
3774 2011-08-12  Sam Weinig  <sam@webkit.org>
3775
3776         Move compiler specific macros to their own header
3777         https://bugs.webkit.org/show_bug.cgi?id=66119
3778
3779         Reviewed by Anders Carlsson.
3780
3781         * DumpRenderTree/ForwardingHeaders/wtf/Compiler.h: Added.
3782
3783 2011-08-11  Dimitri Glazkov  <dglazkov@chromium.org>
3784
3785         Add a way to extend DOM objects in garden-o-matic.
3786         https://bugs.webkit.org/show_bug.cgi?id=66096
3787
3788         Reviewed by Adam Barth.
3789
3790         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js: Added base.extends.
3791         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js: Added tests.
3792
3793 2011-08-11  MORITA Hajime  <morrita@google.com>
3794
3795         [Chromium][DRT] editing/spelling/spelling-backspace-between-lines.html fails
3796         https://bugs.webkit.org/show_bug.cgi?id=45438
3797
3798         Reviewed by Kent Tamura.
3799
3800         MockSpellCheck was assuming the input of spellCheckWord() is a word.
3801         But it can be a series of word. This change made spellCheckWord()
3802         understand simple word boundary which appears in tests.
3803         
3804         * DumpRenderTree/chromium/MockSpellCheck.cpp:
3805         (MockSpellCheck::spellCheckWord):
3806
3807 2011-08-11  Mark Rowe  <mrowe@apple.com>
3808
3809         Rework some Makefile logic to remove a double-negative.
3810
3811         Reviewed by Jon Honeycutt.
3812
3813         * DumpRenderTree/mac/PerlSupport/Makefile:
3814
3815 2011-08-11  Anders Carlsson  <andersca@apple.com>
3816
3817         Add a FIXME.
3818
3819         * TestWebKitAPI/TestsController.cpp:
3820         (TestWebKitAPI::TestsController::TestsController):
3821
3822 2011-08-11  Anders Carlsson  <andersca@apple.com>
3823
3824         Initialize threading before running any tests
3825         https://bugs.webkit.org/show_bug.cgi?id=66112
3826
3827         Reviewed by Adam Barth.
3828
3829         * TestWebKitAPI/TestsController.cpp:
3830         (TestWebKitAPI::TestsController::TestsController):
3831
3832 2011-08-11  Adam Barth  <abarth@webkit.org>
3833
3834         Add unexpected-passes.html to TestFailures for marking tests as passing
3835         https://bugs.webkit.org/show_bug.cgi?id=66102
3836
3837         Reviewed by Dimitri Glazkov.
3838
3839         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
3840         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
3841             - Move some code into the library so it can be shared.
3842         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:
3843         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
3844         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js:
3845             - Add round-trip unit tests.
3846         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/unexpected-passes.html: Added.
3847         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/unexpected-passes.js: Added.
3848             - I'm not entirely sure this feature should remain a separate HTML
3849               file, but it seemed better than cluttering up the main HTML file
3850               with too much extra stuff.
3851         * Scripts/webkitpy/tool/servers/gardeningserver.py:
3852         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
3853             - The gardening server couldn't handle adding PASS expectations.  Now it can.
3854
3855 2011-08-11  Eric Seidel  <eric@webkit.org>
3856
3857         NRWT has wrong fallback order for Mac now that Lion exists
3858         https://bugs.webkit.org/show_bug.cgi?id=66093
3859
3860         Reviewed by Adam Barth.
3861
3862         ORWT used a different system for fallback orders than NRWT did.
3863         I moved win.py to match ORWT fallback orders in bug 64486.
3864         This bug moves mac.py to match ORWT fallback order
3865         and adds 'lion' as a supported OS version.
3866
3867         Because ChromiumMac shares OS version detection code with AppleMac
3868         this also added support for 'lion' to chromium mac.  Hopefully that's a good thing.
3869
3870         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3871         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
3872         * Scripts/webkitpy/layout_tests/port/mac.py:
3873         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3874         * Scripts/webkitpy/layout_tests/port/win.py:
3875
3876 2011-08-11  Adam Barth  <abarth@webkit.org>
3877
3878         Update test results now that we use absolute URLs.
3879
3880         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout_unittests.js:
3881
3882 2011-08-11  Adam Barth  <abarth@webkit.org>
3883
3884         garden-o-matic should be able to determine when tests unexpectedly pass
3885         https://bugs.webkit.org/show_bug.cgi?id=66092
3886
3887         Reviewed by Dimitri Glazkov.
3888
3889         This patch just contains the library methods for extracting this
3890         information.  I'll add some UI in a subsequent patch.
3891
3892         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js:
3893         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results_unittests.js:
3894
3895 2011-08-11  Dimitri Glazkov  <dglazkov@chromium.org>
3896
3897         New expectation entries should be placed next to existing ones.
3898         https://bugs.webkit.org/show_bug.cgi?id=66066
3899
3900         Reviewed by Adam Barth.
3901
3902         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Added the notion of insertion point,
3903             which is computed as the last found reference to the same test.
3904         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Added and adjusted unit tests.
3905
3906 2011-08-11  Dimitri Glazkov  <dglazkov@chromium.org>
3907
3908         Unreviewed, rolling out r92847.
3909         http://trac.webkit.org/changeset/92847
3910         https://bugs.webkit.org/show_bug.cgi?id=65986
3911
3912         Broke check-webkit-style
3913
3914         * Scripts/webkitpy/style/checker.py:
3915         * Scripts/webkitpy/style/checker_unittest.py:
3916
3917 2011-08-11  Dimitri Glazkov  <dglazkov@chromium.org>
3918
3919         Unreviewed, rolling out r92847.
3920         http://trac.webkit.org/changeset/92847
3921         https://bugs.webkit.org/show_bug.cgi?id=65986
3922
3923         Broke check-webkit-style
3924
3925         * Scripts/webkitpy/style/checker.py:
3926         * Scripts/webkitpy/style/checker_unittest.py:
3927
3928 2011-08-11  Pierre Rossi  <pierre.rossi@gmail.com>
3929
3930         [Qt] autotests shouldn't require config.h in the style check
3931         https://bugs.webkit.org/show_bug.cgi?id=65986
3932
3933         Remove the include rules from the style-check for Qt tests.
3934         Since for the most part it's just a matter of using the
3935         API provided by QtWebKit, enforcing the WebCore set of rules
3936         only seems to make sense in the case of MIMESniffing.
3937
3938         Reviewed by Benjamin Poulain.
3939
3940         * Scripts/webkitpy/style/checker.py:
3941         * Scripts/webkitpy/style/checker_unittest.py:
3942
3943 2011-08-11  Zsolt Fehér  <h490267@stud.u-szeged.hu>
3944
3945         [WK2] Implement waitForPolicyDelegate
3946         https://bugs.webkit.org/show_bug.cgi?id=42330
3947
3948         Reviewed by Csaba Osztrogonác.
3949
3950         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
3951         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3952         (WTR::navigationTypeToString):
3953         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
3954         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3955         (WTR::LayoutTestController::LayoutTestController):
3956         (WTR::LayoutTestController::setCustomPolicyDelegate):
3957         (WTR::LayoutTestController::waitForPolicyDelegate):
3958         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3959         (WTR::LayoutTestController::isPolicyDelegateEnabled):
3960         (WTR::LayoutTestController::isPolicyDelegatePermissive):
3961
3962 2011-08-11  Adam Barth  <abarth@webkit.org>
3963
3964         rebaseline-expectations should use the release bots, not the debug
3965         bots.  The debug bots don't all run all the tests.  Also, delay
3966         updating test_expectations a long as possible to avoid clearing out
3967         lines that we'll need for other ports.
3968
3969         * Scripts/webkitpy/layout_tests/port/builders.py:
3970         * Scripts/webkitpy/tool/commands/rebaseline.py:
3971         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3972
3973 2011-08-10  Ryosuke Niwa  <rniwa@webkit.org>
3974
3975         r92792 inadvertently removed PlatformSpecificScheduler for all Snow Leopard bots.
3976         Revert it partially so that the remaining Snow Leopard bots can fulfill their duty.
3977
3978         * BuildSlaveSupport/build.webkit.org-config/config.json:
3979
3980 2011-08-10  Eric Seidel  <eric@webkit.org>
3981
3982         new-run-webkit-test's WinPort has no fallback logic
3983         https://bugs.webkit.org/show_bug.cgi?id=64486
3984
3985         Unreviewed.
3986
3987         Turns out that we've long had a subtle bug whereby if you didn't
3988         already have DumpRenderTree built, we might end up running unsupported tests
3989         because the DumpRenderTree --print-supported-features check would silently fail.
3990
3991         When I moved the call from using popen to using Executive.run_command, this silent
3992         failure became noisy.  (Breaking some bots.)
3993
3994         This re-orders our steps so that we always build DRT before collecting expectations,
3995         as well as adds a warning message when DumpRenderTree can't be found.
3996
3997         * Scripts/webkitpy/layout_tests/port/webkit.py:
3998         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3999
4000 2011-08-10  Eric Seidel  <eric@webkit.org>
4001
4002         new-run-webkit-test's WinPort has no fallback logic
4003         https://bugs.webkit.org/show_bug.cgi?id=64486
4004
4005         Unreviewed.  Fix test-webkitpy under Python 2.5.
4006
4007         * Scripts/webkitpy/layout_tests/port/win.py:
4008
4009 2011-08-10  Benjamin Poulain  <benjamin@webkit.org>
4010
4011         [Qt][WK2] MiniBrowser is firing twice the QDesktopWebView::mousePressEvent method
4012         https://bugs.webkit.org/show_bug.cgi?id=65875
4013
4014         Reviewed by Kenneth Rohde Christiansen.
4015
4016         For some reason, QWidget send fake mouse event on some platform, under certains conditions.
4017
4018         This causes mouse events to be sent twice in some cases. We work around the problem
4019         by defining the first touch point to be a primary touch point (case which hit some
4020         weird condition in QWidget, skipping the generation of fake mouse events).
4021
4022         * MiniBrowser/qt/MiniBrowserApplication.cpp:
4023         (MiniBrowserApplication::notify):
4024
4025 2011-08-10  David Hyatt  <hyatt@apple.com>
4026
4027         https://bugs.webkit.org/show_bug.cgi?id=66004
4028
4029         Remove the regions and exclusions bots and also the flags in build-webkit, since I'm just turning
4030         the code on by default.
4031
4032         Reviewed by Adam Roben.
4033
4034         * BuildSlaveSupport/build.webkit.org-config/config.json:
4035         * Scripts/build-webkit:
4036
4037 2011-08-10  Oliver Hunt  <oliver@apple.com>
4038
4039         JSEvaluteScript does not return the correct object when given JSONP data
4040         https://bugs.webkit.org/show_bug.cgi?id=66003
4041
4042         Reviewed by Gavin Barraclough.
4043
4044         Add a test case.
4045
4046         * DumpRenderTree/mac/DumpRenderTree.mm:
4047         (testStringByEvaluatingJavaScriptFromString):
4048
4049 2011-08-10  Eric Seidel  <eric@webkit.org>
4050
4051         WIN: NRWT runs compositing tests on configurations that don't support compositing
4052         https://bugs.webkit.org/show_bug.cgi?id=64472
4053
4054         Reviewed by Adam Barth.
4055
4056         I think the code was just wrong.  It was never splitting the string
4057         into list pieces before.
4058         I've now tested the supported_features code and theoretically it
4059         should now work with Windows DRT.
4060
4061         I also made the list-lookup functions always return lists, to make
4062         it possible to clean up the list-transform code in the future
4063         (I opted not to do that cleanup in this patch, but at least now
4064         both types of feature lookup functions match return types.)
4065
4066         * Scripts/webkitpy/layout_tests/port/webkit.py:
4067         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
4068
4069 2011-08-10  Eric Seidel  <eric@webkit.org>
4070
4071         Clean up ChromiumDriver a little
4072         https://bugs.webkit.org/show_bug.cgi?id=65995
4073
4074         Unreviewed.
4075
4076         Fix NRWT for chromium.  Silly python.
4077
4078         * Scripts/webkitpy/layout_tests/port/chromium.py:
4079
4080 2011-08-10  Eric Seidel  <eric@webkit.org>
4081
4082         Clean up ChromiumDriver a little
4083         https://bugs.webkit.org/show_bug.cgi?id=65995
4084
4085         Reviewed by Adam Barth.
4086
4087         - We no longer support threading, so remove threading specific code.
4088         - Add FIXMEs about using ServerProcess instead.
4089         - Condense option-mapping if-cascade into a for loop.
4090         - Unindent long if blocks by using early return.
4091         - Unwrap lines which are needlessly wrapped.
4092
4093         There should be no functional changes here, just code cleanup/dead-code removal.
4094
4095         * Scripts/webkitpy/layout_tests/port/chromium.py:
4096
4097 2011-08-10  Dimitri Glazkov  <dglazkov@chromium.org>
4098
4099         Unmuddle construction options for TestConfiguration.
4100         https://bugs.webkit.org/show_bug.cgi?id=65988
4101
4102         The TestConfiguration instance is now constructed only using actual values.
4103         Port-based construction is split into a "from_port" class method.
4104
4105         Reviewed by Eric Seidel.
4106
4107         * Scripts/webkitpy/layout_tests/models/test_configuration.py: Added TestConfiguration.from_port
4108         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py: Adjusted code to accommodate the change.
4109         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Ditto.
4110         * Scripts/webkitpy/layout_tests/port/base.py: Ditto.
4111         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Ditto.
4112
4113 2011-08-10  Eric Seidel  <eric@webkit.org>
4114
4115         Leaks bot shows python logging prefixes as part of summary display
4116         https://bugs.webkit.org/show_bug.cgi?id=65931
4117
4118         Reviewed by Adam Barth.
4119
4120         The big part of this change is adding a unittesting system for
4121         master.cfg, so mere-mortals can make changes to build.webkit.org
4122         with greatly-reduced risk of breaking the world.
4123
4124         Turns out that in typing up my trival logging fix I made 2 typos,
4125         so hopefully the hour spent getting master.cfg to load was worth it. :)
4126
4127         I also tried to make mastercfg_unittest run as part of test-webkitpy
4128         but right now test-webkitpy requires that unittest files be located in
4129         a module-name-compatible directory.  'build.webkit.org-config' is not
4130         a valid module name.
4131
4132         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
4133          - Fixed _parseNewRunWebKitTestsOutput to strip NRWT's python formatter prefix
4134            by using a new _strip_python_logging_prefix function.
4135          - Also fixed this function to file to work with a more modern
4136            simplejson version (which returns unicode objects instead of str objects)
4137            and filed a related bug with buildbot.net due to their handling of unicode builder names.
4138         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Added.
4139          - BuildBotConfigLoader is a huge pile of code just to get master.cfg to load.
4140          - The actual tiny unittest of the new _parseNewRunWebKitTestsOutput logic.
4141         * Scripts/webkitpy/thirdparty/__init__.py:
4142          - Add autoinstallation of buildbot (and jinja2) for use by mastercfg_unittest.py
4143
4144 2011-08-09  Dimitri Glazkov  <dglazkov@chromium.org>
4145
4146         garden-o-matic should extrapolate failures given a set of known results
4147         https://bugs.webkit.org/show_bug.cgi?id=65882
4148
4149         Reviewed by Adam Barth.
4150
4151         * Scripts/webkitpy/layout_tests/models/test_configuration.py: Spuriously covered my old sins.
4152         * Scripts/webkitpy/layout_tests/port/builders.py: Augmented builders dictionary to contain build coverage specifiers,
4153             adjusted all call sites.
4154         * Scripts/webkitpy/tool/servers/gardeningserver.py: Added BuildCoverageExtrapolator, a thing that
4155             makes wider net for specific failures.
4156         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py: Added unit tests.
4157
4158 2011-08-10  Adam Barth  <abarth@webkit.org>
4159
4160         The URL we were computing for retrieving baselines was missing a slash
4161         character because our mocks had an extra slash character.  I've
4162         corrected both the code and the mock.
4163
4164         * Scripts/webkitpy/tool/commands/rebaseline.py:
4165         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
4166         * Scripts/webkitpy/tool/mocktool.py:
4167
4168 2011-08-09  Adam Barth  <abarth@webkit.org>
4169
4170         Move the quote mark to the right place.
4171
4172         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js:
4173
4174 2011-08-09  Adam Barth  <abarth@webkit.org>
4175
4176         garden-o-matic should use huerstics to narrow regression range
4177         https://bugs.webkit.org/show_bug.cgi?id=65948
4178
4179         Reviewed by Dimitri Glazkov.
4180
4181         When analyzing a regression range, if one of the commit messages
4182         mentions the test in question, we now hueristically assume that
4183         revision caused the failure.  (I'm shamelessly stealing this idea from
4184         TestFailures.)
4185
4186         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:
4187
4188 2011-07-13  Eric Seidel  <eric@webkit.org>
4189
4190         new-run-webkit-test's WinPort has no fallback logic
4191         https://bugs.webkit.org/show_bug.cgi?id=64486
4192
4193         Reviewed by Adam Roben.
4194
4195         I've tried to write a patch for bug 64439 twice now, and both times
4196         I've ended up re-writing half the port system.  So I'm breaking
4197         things up into smaller pieces, this being the first.
4198
4199         WinPort still does not have any port_name parsing, so when instantiated
4200         with the name "win-xp" (i.e. by the rebaseline server) it will just behave as the 'win' port.
4201         I'll fix this in a second pass when I standardize port_name parsing for all webkit ports.
4202
4203         Otherwise this should "just work" for windows.  I've not been able to test the
4204         version detection on my mac, but the unit tests show the code behaving as designed.
4205
4206         * Scripts/webkitpy/layout_tests/port/win.py:
4207         * Scripts/webkitpy/layout_tests/port/win_unittest.py: Added.
4208
4209 2011-08-09  Adam Barth  <abarth@webkit.org>
4210
4211         Teach build.webkit.org's garden-o-matic how to talk to the local server
4212         https://bugs.webkit.org/show_bug.cgi?id=65940
4213
4214         Reviewed by Dimitri Glazkov.
4215
4216         After this patch, the version of garden-o-matic on build.webkit.org is
4217         fully functional.  It can interact with the local server via CORS.
4218
4219         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js:
4220         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js:
4221         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
4222         * Scripts/webkitpy/tool/commands/gardenomatic.py:
4223         * Scripts/webkitpy/tool/servers/gardeningserver.py:
4224
4225 2011-08-09  Adam Barth  <abarth@webkit.org>
4226
4227         Enable CORS for garden-o-matic
4228         https://bugs.webkit.org/show_bug.cgi?id=65936
4229
4230         Reviewed by Dimitri Glazkov.
4231
4232         This patch will allow the hosted instance of garden-o-matic to
4233         communicate with the local server.
4234
4235         * Scripts/webkitpy/tool/servers/gardeningserver.py:
4236         * Scripts/webkitpy/tool/servers/reflectionhandler.py:
4237
4238 2011-08-09  Adam Barth  <abarth@webkit.org>
4239
4240         Upgrade jquery in TestFailures
4241         https://bugs.webkit.org/show_bug.cgi?id=65935
4242
4243         Reviewed by Dimitri Glazkov.
4244
4245         Upgrade to a newer version of jQuery with better support for CORS and CSP.
4246
4247         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
4248         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html:
4249         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
4250
4251 2011-08-09  Sheriff Bot  <webkit.review.bot@gmail.com>
4252
4253         Unreviewed, rolling out r92683.
4254         http://trac.webkit.org/changeset/92683
4255         https://bugs.webkit.org/show_bug.cgi?id=65921
4256
4257          "Breaks Qt --minimal build. Revert pending update of the Qt
4258         minimal configuration" (Requested by simathur on #webkit).
4259
4260         * QtTestBrowser/cookiejar.cpp:
4261         (TestBrowserCookieJar::TestBrowserCookieJar):
4262         * QtTestBrowser/launcherwindow.cpp:
4263         (LauncherWindow::createChrome):
4264         (LauncherWindow::setDiskCache):
4265         * QtTestBrowser/main.cpp:
4266         (LauncherApplication::handleUserOptions):
4267         * QtTestBrowser/webpage.cpp:
4268         (WebPage::openUrlInDefaultBrowser):
4269
4270 2011-08-09  Siddharth Mathur  <siddharth.mathur@nokia.com>
4271
4272         [Qt] Simplify code by removing QT_NO_DESKTOPSERVICES and QT_NO_NETWORKDISKCACHE
4273         https://bugs.webkit.org/show_bug.cgi?id=65880
4274
4275         Reviewed by Andreas Kling.
4276
4277         QDesktopServices and QNetworkDiskCache have been around for a while now. Kill flags which 
4278         check for their feature flags. Assume that any reasonable Qt build provides them. 
4279         * QtTestBrowser/cookiejar.cpp:
4280         (TestBrowserCookieJar::TestBrowserCookieJar):
4281         * QtTestBrowser/launcherwindow.cpp:
4282         (LauncherWindow::createChrome):
4283         (LauncherWindow::setDiskCache):
4284         * QtTestBrowser/main.cpp:
4285         (LauncherApplication::handleUserOptions):
4286         * QtTestBrowser/webpage.cpp:
4287         (WebPage::openUrlInDefaultBrowser):
4288
4289 2011-08-09  Adam Barth  <abarth@webkit.org>
4290
4291         BaselineOptimizer created the wrong baseline for fast/js/regexp-overflow.html
4292         https://bugs.webkit.org/show_bug.cgi?id=65891
4293
4294         Reviewed by Eric Seidel.
4295
4296         The problem was that platform/chromium contained a bogus expectation
4297         file that needed to be removed, but by the time we got around to
4298         removing it, we'd already moved the correct baseline into its place.
4299         After this patch, we copy the gold results into memory before
4300         reshuffling things on disk (and we delete bad things before adding good
4301         things).
4302
4303         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
4304         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
4305
4306 2011-08-08  Adam Barth  <abarth@webkit.org>
4307
4308         Chromium Windows bots can't figure out what SVN revision they're running
4309         https://bugs.webkit.org/show_bug.cgi?id=65893
4310
4311         Reviewed by Eric Seidel.
4312
4313         The comment in _engage_awesome_windows_hacks explains why we're making
4314         this change.  It's ugly and rediculous, but this approach seems better
4315         than using shell=True when calling popen.
4316
4317         * Scripts/webkitpy/common/checkout/scm/svn.py:
4318         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
4319
4320 2011-08-08  Adam Barth  <abarth@webkit.org>
4321
4322         Remove deduplicate-tests
4323         https://bugs.webkit.org/show_bug.cgi?id=65886
4324
4325         Reviewed by Tony Chang.
4326
4327         This script is redundant with "webkit-patch bulk-optimize-baselines",
4328         which can