2011-01-21 Dirk Pranke <dpranke@chromium.org>
[WebKit.git] / Tools / ChangeLog
1 2011-01-21  Dirk Pranke  <dpranke@chromium.org>
2
3         Reviewed by Mihai Parparita.
4
5         Fix bug introduced in r76322 that caused NRWT to not actually
6         read the Skipped files properly.
7
8         https://bugs.webkit.org/show_bug.cgi?id=52771
9
10         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
11         * Scripts/webkitpy/layout_tests/port/webkit.py:
12         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
13
14 2011-01-21  Sam Weinig  <sam@webkit.org>
15
16         Reviewed by Geoffrey Sean Garen and Mark Rowe.
17
18         WebKitTestRunner needs the HOME environment variable to be set.
19         <rdar://problem/8896573>
20
21         * Scripts/old-run-webkit-tests: Set the HOME environment variable if
22         it exists.
23
24 2011-01-21  Dirk Pranke  <dpranke@chromium.org>
25
26         Reviewed by Eric Seidel.
27
28         Suppress a few remaining integration tests so that none of the
29         layout_test unit tests ever read from the filesystem or launch
30         subprocesses that aren't part of the unit tests.
31
32         Also fix a minor bug in the printing unit tests that was
33         incorrectly relying on sys.argv.
34
35         https://bugs.webkit.org/show_bug.cgi?id=52863
36
37         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
38         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
39         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
40
41 2011-01-21  Darin Adler  <darin@apple.com>
42
43        Fix Mac build.
44
45         * MiniBrowser/mac/BrowserWindowController.m:
46         (-[BrowserWindowController awakeFromNib]): Pass 0 for runModal function.
47
48 2011-01-20  Darin Adler  <darin@apple.com>
49
50         Reviewed by Dan Bernstein.
51
52         WebKit2: Implement showModalDialog
53         https://bugs.webkit.org/show_bug.cgi?id=52855
54
55         This fixes WebKitTestRunner to compile, but more work is probably
56         needed to get it to pass the tests.
57
58         * WebKitTestRunner/TestController.cpp:
59         (WTR::TestController::runModal): Added. Calls through to the
60         platform-specific version of runModal.
61         (WTR::TestController::createOtherPage): Changed to be a private
62         static member function so it can refer to runModal, which is
63         a private static member function.
64         (WTR::TestController::initialize): Pass 0 for the runModal
65         function since we don't need to run the main window modal.
66         I suspect this is wrong and will need to change.
67         * WebKitTestRunner/TestController.h: Added declarations for
68         the functions added above.
69         * WebKitTestRunner/mac/TestControllerMac.mm:
70         (WTR::TestController::runModal): Added. Untested implementation.
71         * WebKitTestRunner/qt/TestControllerQt.cpp:
72         (WTR::TestController::runModal): Added.
73         * WebKitTestRunner/win/TestControllerWin.cpp:
74         (WTR::TestController::runModal): Added.
75
76 2011-01-21  Eric Seidel  <eric@webkit.org>
77
78         Reviewed by Adam Barth.
79
80         Split Host object off from WebKitPatch for easier re-use
81         https://bugs.webkit.org/show_bug.cgi?id=52284
82
83         new-run-webkit-tests and other tools are eventually going to want one of these.
84         Basically you need to inherit from this class if you want to pretend to be a
85         self.tool object for Steps/Commands.
86
87         * Scripts/webkitpy/common/host.py: Added.
88         * Scripts/webkitpy/tool/main.py:
89
90 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
91
92         Reviewed by Adam Barth.
93
94         Disable the tests that start and stop the http server and web
95         server, so that we don't have to worry about port collisions on
96         the bots.
97
98         https://bugs.webkit.org/show_bug.cgi?id=52861
99
100         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
101
102 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
103
104         Reviewed by Eric Seidel.
105
106         nrwt: rewrite google_chrome_unittest to use mock filesystem.
107         
108         https://bugs.webkit.org/show_bug.cgi?id=52772
109         
110         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
111
112 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
113
114         Reviewed by Eric Siedel.
115
116         nrwt: clean up almost all remaining port references, remove
117         unnecessary import clauses. The only remaining references are
118         in places where a mock filesystem makes no sense or can't be
119         used, and in one routine in port/google_chrome_unittest that
120         I'll rewrite in a separate patch.
121
122         https://bugs.webkit.org/show_bug.cgi?id=52771
123
124         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
125         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
126         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
127         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
128         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
129         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
130         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
131         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
132         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
133         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
134         * Scripts/webkitpy/layout_tests/port/gtk.py:
135         * Scripts/webkitpy/layout_tests/port/mac.py:
136         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
137         * Scripts/webkitpy/layout_tests/port/qt.py:
138         * Scripts/webkitpy/layout_tests/port/webkit.py:
139         * Scripts/webkitpy/layout_tests/port/win.py:
140         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
141
142 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
143
144         Reviewed by Mihai Parparita.
145
146         remove fs refs from run_webkit_tests, rebaseline_chromium_webkit_tests
147
148         https://bugs.webkit.org/show_bug.cgi?id=52762
149
150         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
151         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
152
153 2011-01-20  Tony Chang  <tony@chromium.org>
154
155         Reviewed by Ojan Vafai.
156
157         [chromium] fix the paths used for the rebaseline tool
158         https://bugs.webkit.org/show_bug.cgi?id=52857
159
160         Some of the bots were renamed so the path to grab the results zip
161         file has changed.
162
163         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
164
165 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
166
167         Reviewed by Tony Chang.
168
169         Fix bug introduced in r72688 / bug 52768 that broke the
170         generation of the output filename links in the results.html
171         output. Apparently none of the unit tests actually checked to
172         make sure the generated links were correct :(
173
174         https://bugs.webkit.org/show_bug.cgi?id=52854
175
176         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
177         * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
178
179 2011-01-20  Alexey Proskuryakov  <ap@apple.com>
180
181         Reviewed by Darin Adler.
182
183         https://bugs.webkit.org/show_bug.cgi?id=52849
184         Make window.print work with WebKit2
185
186         * MiniBrowser/mac/BrowserWindowController.m:
187         (-[BrowserWindowController awakeFromNib]):
188         * WebKitTestRunner/TestController.cpp:
189         (WTR::createOtherPage):
190         (WTR::TestController::initialize):
191         Added zeroes to WKPageUIClient structures to avoid build failures.
192
193 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
194
195         Reviewed by Eric Seidel.
196
197         nrwt: remove fs refs from printing, test_failures, test_expectations, text_diff
198
199         https://bugs.webkit.org/show_bug.cgi?id=52756
200
201         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
202         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
203         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
204         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
205         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
206         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
207
208 2011-01-20  Mansi Mithal  <mansi.mithal@nokia.com>
209
210         Reviewed by Antonio Gomes.
211
212         QtTestBrowser should have a seperate menu for Settings
213         https://bugs.webkit.org/show_bug.cgi?id=52817
214         
215         Added a new menu item named "Settings"
216         and moved the "Enable interrupting js scripts" and "Enable js pop up windows" under the "Settings" menu 
217
218         * QtTestBrowser/launcherwindow.cpp:
219         (LauncherWindow::createChrome):
220
221 2011-01-20  Sam Weinig  <sam@webkit.org>
222
223         Reviewed by John Sullivan.
224
225         Update update-webkit-localizable-strings with new path to WebKit.
226
227         * Scripts/update-webkit-localizable-strings:
228
229 2011-01-20  James Robinson  <jamesr@chromium.org>
230
231         Reviewed by Darin Fisher.
232
233         Implement mozilla's requestAnimationFrame API
234         https://bugs.webkit.org/show_bug.cgi?id=51218
235
236         Chromium DumpRenderTree support for window.webkitRequestAnimationFrame.
237
238         * DumpRenderTree/chromium/WebViewHost.cpp:
239         (invokeScheduleComposite):
240         (WebViewHost::scheduleAnimation):
241         (WebViewHost::paintInvalidatedRegion):
242         * DumpRenderTree/chromium/WebViewHost.h:
243
244 2011-01-20  Maciej Stachowiak  <mjs@apple.com>
245
246         Reviewed by Adam Roben.
247
248         WebKitTestRunner needs to support layoutTestController.evaluateScriptInIsolatedWorld
249         https://bugs.webkit.org/show_bug.cgi?id=42327
250
251         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm: Add support
252         for methods that take their normal arguments but also a JSContextRef.
253         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: IDL definition
254         for evaluateScriptInIsolatedWorld.
255         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
256         (WTR::InjectedBundlePage::didClearWindowForFrame): Set a magic variable only if
257         this call is for an isolated world.
258         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
259         (WTR::worldMap): Helper to create a world map.
260         (WTR::LayoutTestController::worldIDForWorld): Map from an ID to a world.
261         (WTR::LayoutTestController::evaluateScriptInIsolatedWorld): The newly
262         added LayoutTestController API.
263         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
264
265 2011-01-19  Adam Roben  <aroben@apple.com>
266
267         Convert paths in environment variables back to msys-style inside commit-log-editor
268
269         When this script gets run from inside git commit, msys-style paths in the environment will
270         have been turned into Windows-style paths with forward slashes. This screws up functions
271         like File::Spec->rel2abs, which seem to rely on $PWD having an msys-style path. We convert
272         the paths back to msys-style before doing anything else.
273
274         Fixes <http://webkit.org/b/48527> commit-log-editor uses full paths for section headers when
275         using msysgit's Perl and multiple ChangeLogs have been edited
276
277         Reviewed by David Kilzer.
278
279         * Scripts/commit-log-editor: Call fixEnvironment before doing anything else.
280         (fixEnvironment): Added. When run in msys in conjunction with git (i.e., when invoked from
281         inside git commit), convert Windows-style paths in the environment back to msys-style paths.
282
283 2011-01-20  Zoltan Horvath  <zoltan@webkit.org>
284
285         [Win] Unreviewed build fix after r76248.
286
287         * DumpRenderTree/ForwardingHeaders/wtf/FastAllocBase.h: Added.
288
289 2011-01-20  Zoltan Horvath  <zoltan@webkit.org>
290
291         Reviewed by Csaba Osztrogonác.
292
293         Refactoring of the custom allocation framework
294         https://bugs.webkit.org/show_bug.cgi?id=49897
295
296         Inheriting from FastAllocBase can result in objects getting larger (bug #33896, #46589).
297         The modification replaces Noncopyable and FastAllocBase classes and these inherits with their
298         equivalent macro implementation at the necessary places.
299 2011-01-20  Yi Shen  <yi.4.shen@nokia.com>
300
301         Unreviewed. 
302
303         Adding myself to committers.py.
304
305         * Scripts/webkitpy/common/config/committers.py:
306
307 2011-01-20  Adam Barth  <abarth@webkit.org>
308
309         Reviewed by Tony Chang.
310
311         Chromium builders don't delete unversioned directories when DEPS change
312         https://bugs.webkit.org/show_bug.cgi?id=52745
313
314         If we pass this option to gclient sync, gclient will delete directories
315         that are no longer part of DEPS instead of leaving them around to
316         confuse us later.  Apparently, the downstream buildbots use this option
317         already.
318
319         * Scripts/update-webkit-chromium:
320
321 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
322
323         Unreviewed, build fix - I pulled this patch in to fix an issue
324         revealed by r76195 running on some new bots). Also fix a couple
325         of other issues revealed in testing.
326
327         nrwt: remove fs refs from layout_package/json*
328
329         https://bugs.webkit.org/show_bug.cgi?id=52754
330
331         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
332         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
333         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
334         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
335         * Scripts/webkitpy/layout_tests/port/base.py:
336
337 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
338
339         Unreviewed, build fix.
340
341         Fix a couple of minor bugs discovered while bringing up new bots
342         for testing.
343
344         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
345         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
346
347 2011-01-19  James Robinson  <jamesr@chromium.org>
348
349         Unreviewed, rolling out r76194.
350         http://trac.webkit.org/changeset/76194
351         https://bugs.webkit.org/show_bug.cgi?id=51218
352
353         Caused mysterious compile failure on the chromium win
354         build.webkit.org bots
355
356         * DumpRenderTree/chromium/WebViewHost.cpp:
357         (WebViewHost::paintInvalidatedRegion):
358         * DumpRenderTree/chromium/WebViewHost.h:
359
360 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
361
362         Reviewed by Mihai Parparita.
363
364         remove fs refs from test_runner, dump_render_tree_thread
365
366         https://bugs.webkit.org/show_bug.cgi?id=52753
367
368         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
369         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
370         * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
371         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
372
373 2011-01-19  James Robinson  <jamesr@chromium.org>
374
375         Reviewed by Darin Fisher.
376
377         Implement mozilla's requestAnimationFrame API
378         https://bugs.webkit.org/show_bug.cgi?id=51218
379
380         Chromium DumpRenderTree support for window.webkitRequestAnimationFrame.
381
382         * DumpRenderTree/chromium/WebViewHost.cpp:
383         (invokeScheduleComposite):
384         (WebViewHost::scheduleAnimation):
385         (WebViewHost::paintInvalidatedRegion):
386         * DumpRenderTree/chromium/WebViewHost.h:
387
388 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
389
390         Unreviewed, build fix.
391
392         Fix a few incorrect "self._filesystem" references introduced in
393         r76184.
394
395         * Scripts/webkitpy/layout_tests/port/chromium.py:
396         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
397
398 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
399
400         Reviewed by Mihai Parparita.
401
402         add a .sep property, abspath(), isabs(), mtime(), and
403         open_text_file_for_writing() to filesystem modules. Some of
404         these properties are not needed in this patch but will be needed
405         in subsequent patches (I'm doing this to avoid having to track
406         multiple versions of a single file).
407
408         Also, change most of the port/* modules to use the filesystem
409         objects instead of referencing the filesystem directly.
410
411         https://bugs.webkit.org/show_bug.cgi?id=52748
412
413         * Scripts/webkitpy/common/system/filesystem.py:
414         * Scripts/webkitpy/common/system/filesystem_mock.py:
415         * Scripts/webkitpy/layout_tests/port/__init__.py:
416         * Scripts/webkitpy/layout_tests/port/base.py:
417         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
418         * Scripts/webkitpy/layout_tests/port/chromium.py:
419         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
420         * Scripts/webkitpy/layout_tests/port/config.py:
421         * Scripts/webkitpy/layout_tests/port/test.py:
422         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
423
424 2011-01-19  Maciej Stachowiak  <mjs@apple.com>
425
426         Reviewed by Anders Carlsson.
427
428         If resetting between tests times out, treat it as a WebProcess crash
429         https://bugs.webkit.org/show_bug.cgi?id=52757
430
431         * WebKitTestRunner/TestController.cpp:
432         (WTR::TestController::runTest):
433
434 2011-01-19  Alexey Proskuryakov  <ap@apple.com>
435
436         Reviewed by Darin Adler.
437
438         https://bugs.webkit.org/show_bug.cgi?id=52739
439         Make it possible for a WebKit2 client to print headers and footers
440
441         Added dummy implementations for new printing UIClient calls.
442
443         * MiniBrowser/mac/BrowserWindowController.m:
444         (-[BrowserWindowController awakeFromNib]):
445         * WebKitTestRunner/TestController.cpp:
446         (WTR::createOtherPage):
447         (WTR::TestController::initialize):
448
449 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
450
451         Reviewed by Ojan Vafai.
452
453         Change webkitpy/layout_tests/port/test.py to use the
454         in-memory filesystem for cleaner unit testing. This
455         change allows us to kill a lot of code that was
456         specific to the test port, at the cost of being a
457         little less clear about how things would work if
458         you didn't have a filesystem.
459
460         https://bugs.webkit.org/show_bug.cgi?id=52605
461
462         * Scripts/webkitpy/layout_tests/port/test.py:
463
464 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
465
466         Unreviewed, build fix.
467
468         Fix test failure caused by committing attachment 79368 instead
469         of attachment 79461 on bug 52604.
470
471         * Scripts/webkitpy/common/system/filesystem_mock.py:
472
473 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
474
475         Reviewed by Mihai Parparita.
476
477         new-run-webkit-tests: remove use of os.walk, use mock filesystem for better
478         unit testing. os.walk() is too much of a hassle to implement on
479         top of the in-memory mock filesystem and adding the necessary
480         interface to files_under() gives clients a cleaner API anyway
481         (for this particular usage model).
482
483         https://bugs.webkit.org/show_bug.cgi?id=52691
484
485         * Scripts/webkitpy/common/system/filesystem.py:
486         * Scripts/webkitpy/common/system/filesystem_mock.py:
487         * Scripts/webkitpy/layout_tests/port/test_files.py:
488         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
489
490 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
491
492         Reviewed by Tony Chang.
493
494         Change more modules in the layout-tests code to use the
495         filesystem wrapper for cleaner unit testing.
496
497         This patch also adds the glob() wrapper to the filesystem
498         abstraction.
499         
500         https://bugs.webkit.org/show_bug.cgi?id=52604
501
502         * Scripts/webkitpy/layout_tests/port/test_files.py:
503         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
504         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
505         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
506         * Scripts/webkitpy/common/system/filesystem.py:
507         * Scripts/webkitpy/common/system/filesystem_mock.py:
508
509 2011-01-19  Levi Weintraub  <leviw@chromium.org>
510
511         Unreviewed.
512
513         Updating my email addresses and irc nick.
514
515         * Scripts/webkitpy/common/config/committers.py:
516
517 2011-01-19  Tony Chang  <tony@chromium.org>
518
519         Reviewed by Mihai Parparita.
520
521         [chromium] [linux] if check-sys-deps fails, output the failure reason
522         https://bugs.webkit.org/show_bug.cgi?id=52671
523
524         * Scripts/webkitpy/common/system/executive_mock.py: Add support for
525             error handler functions.
526         * Scripts/webkitpy/layout_tests/port/chromium.py:
527             output the error text from --check-sys-deps
528         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
529
530 2011-01-19  Aparna Nandyal  <aparna.nand@wipro.com>
531
532         Reviewed by Andreas Kling.
533
534         [Qt] QtTestBrowser crashes when closing if Facebook is opened
535         https://bugs.webkit.org/show_bug.cgi?id=52554
536         
537         QtNetworkAccessManager is created in a thread and set as
538         member variable in QWebPage. When the thread is destroyed
539         the object is still used. So fix will set the object to
540         NULL once the thread is destroyed.
541
542         * QtTestBrowser/launcherwindow.cpp:
543         (LauncherWindow::~LauncherWindow):
544
545 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
546
547         Rubber stamped by Csaba Osztrogonac
548
549         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: Removed unncessary inculde of WKStringCF.h
550
551 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
552
553         Reviewed by Tony Chang.
554
555         new-run-webkit-tests: add a --build-directory command line argument
556
557         Official Google Chrome builds use a non-standard build directory
558         location. This patch adds a --build-directory argument that
559         allows that location to be specified on the command line. Only
560         Chromium-based builds will use this flag for now, but anyone can
561         in the future.
562
563         There are no unit tests for this since it's difficult to test
564         until mock filesystems are fully supported in the code. This was
565         tested by hand for now.
566
567         https://bugs.webkit.org/show_bug.cgi?id=52694
568
569         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
570         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
571         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
572         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
573
574 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
575
576         Not reviewed. Bot fix.
577
578         Remove an inadvertently committed debugging print.
579
580         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
581         (LayoutTestController::notifyDone):
582
583 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
584
585         Reviewed by Sam Weinig.
586
587         WebKitTestRunner should track loading more like DumpRenderTree
588         https://bugs.webkit.org/show_bug.cgi?id=52692
589
590         Change load tracking to track the current top loading frame, in the manner of DumpRenderTree.
591         This makes some tests that call notifyDone multiple times pass.
592         
593         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
594         (WTR::InjectedBundle::InjectedBundle):
595         (WTR::InjectedBundle::done):
596         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
597         (WTR::InjectedBundle::topLoadingFrame):
598         (WTR::InjectedBundle::setTopLoadingFrame):
599         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
600         (WTR::InjectedBundlePage::InjectedBundlePage):
601         (WTR::InjectedBundlePage::stopLoading):
602         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
603         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
604         (WTR::InjectedBundlePage::didFinishLoadForFrame):
605         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
606         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
607         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
608         (WTR::LayoutTestController::notifyDone):
609         * WebKitTestRunner/TestController.cpp:
610         (WTR::TestController::didReceiveMessageFromInjectedBundle):
611
612 2011-01-18  Mihai Parparita  <mihaip@chromium.org>
613
614         Reviewed by Kent Tamura.
615
616         [Chromium] NRWT looking for DRT binary in the wrong path on Mac
617         https://bugs.webkit.org/show_bug.cgi?id=52678
618         
619         Update path now that WebKit is inside Source.
620
621         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
622
623 2011-01-18  Robert Hogan  <robert@webkit.org>
624
625         Reviewed by Simon Hausmann.
626
627         [Qt] http/tests/incremental/slow-utf8-text.pl fails
628         https://bugs.webkit.org/show_bug.cgi?id=44282
629
630         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
631         (WebCore::DumpRenderTree::dump):
632
633 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
634
635         Reviewed by Mihai Parparita.
636
637         Fix a small race condition that could cause the unit tests for
638         new-run-webkit-tests to fail in a multithreaded environment.
639         There was a small window in the code where one thread would
640         check to see if a thread had raised an exception, do something,
641         and then check to see if the thread was alive. If the other
642         thread raised an exception and exited in between these two
643         steps, the exception would be lost. Flipping the order of the
644         two checks fixes the race, since we will now always check for an
645         exception on the thread before exiting.
646
647         https://bugs.webkit.org/show_bug.cgi?id=51579
648
649         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
650
651 2011-01-18  Eric Seidel  <eric@webkit.org>
652
653         Reviewed by Adam Barth.
654
655         commit-queue dies when test archiving fails
656         https://bugs.webkit.org/show_bug.cgi?id=52617
657
658         I looked at the machine and it had 10 archives already
659         thus find_unused_name was returning None.  I've upped
660         the limit to 100 (per bug) and tested the case where
661         find_unused_name returns None (making archive return None).
662
663         * Scripts/webkitpy/common/system/workspace.py:
664         * Scripts/webkitpy/common/system/workspace_unittest.py:
665         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
666         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
667         * Scripts/webkitpy/tool/commands/queues.py:
668
669 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
670
671         Reviewed by Ojan Vafai.
672
673         Update rebaseline-chromium-webkit-tests unit tests to use a mock
674         filesystem. Also fix a couple of "with" statements missed by
675         r76050.
676
677         https://bugs.webkit.org/show_bug.cgi?id=52487
678
679         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
680
681 2011-01-18  Sergio Villar Senin  <svillar@igalia.com>
682
683         Reviewed by Martin Robinson.
684
685         [Gtk] Build fixes for gtk3 build
686         https://bugs.webkit.org/show_bug.cgi?id=52648
687
688         * DumpRenderTree/gtk/EventSender.cpp:
689         (beginDragWithFilesCallback):
690
691 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
692
693         Reviewed by Mihai Parparita.
694
695         Update rebaseline-chromium-webkit-tests to use filesystem objects
696         instead of direct references to os.path, shutil, tempfile, etc.
697
698         This patch doesn't change anything, but will allow subsequent
699         patches to change the unit tests to no longer use the real
700         filesystem.
701
702         This patch adds a bunch more methods to the filesystem object as
703         well.
704
705         https://bugs.webkit.org/show_bug.cgi?id=52482
706
707         * Scripts/webkitpy/common/system/filesystem.py:
708         * Scripts/webkitpy/common/system/filesystem_mock.py:
709         * Scripts/webkitpy/tool/commands/queues.py:
710         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
711         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
712
713 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
714
715         Reviewed by Mihai Parparita.
716
717         new-run-webkit-tests shouldn't crash when you try to run a
718         directory containing only skipped files.
719
720         https://bugs.webkit.org/show_bug.cgi?id=52478
721         
722         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
723         * Scripts/webkitpy/layout_tests/port/test.py:
724         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
725
726 2011-01-18  Adam Bergkvist  <adam.bergkvist@ericsson.com> and Martin Robinson  <mrobinson@igalia.com>
727
728         Reviewed by Gustavo Noronha Silva.
729
730         [GTK] The GTK+ EventSender needs support for beginDragWithFiles
731         https://bugs.webkit.org/show_bug.cgi?id=40833
732
733         * DumpRenderTree/gtk/EventSender.cpp: Add a beginDragWithFiles implementation for the
734         GTK+ event sender.
735         (dragWithFilesDragDataGetCallback): Added.
736         (dragWithFilesDragEndCallback): Added.
737         (beginDragWithFilesCallback): Added.
738
739 2011-01-18  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
740
741         Reviewed by Adam Barth.
742
743         ews: Add additional watcher to efl ews
744         https://bugs.webkit.org/show_bug.cgi?id=52613
745
746         Add gyuyoung.kim@samsung.com to watcher list of efl-ews.
747
748         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
749
750 2011-01-17  Tony Gentilcore  <tonyg@chromium.org>
751
752         Reviewed by Alexey Proskuryakov.
753
754         Fix some headers with missing or misspelled #ifndef guards
755         https://bugs.webkit.org/show_bug.cgi?id=52545
756
757         * DumpRenderTree/chromium/TestEventPrinter.h:
758         * DumpRenderTree/chromium/WebPreferences.h:
759
760 2011-01-17  Jessie Berlin  <jberlin@apple.com>
761
762         Reviewed by Anders Carlsson.
763
764         REGRESSION: Assertion failure in FrameLoader::continueLoadAfterWillSubmitForm() when
765         navigating back to an unreachable URL
766         https://bugs.webkit.org/show_bug.cgi?id=52388
767
768         Add a third parameter (unreachableURL) to queueLoadHTMLString.
769
770         * DumpRenderTree/LayoutTestController.cpp:
771         (queueLoadHTMLStringCallback):
772         (LayoutTestController::queueLoadHTMLString):
773         (LayoutTestController::queueLoadAlternateHTMLString):
774         * DumpRenderTree/LayoutTestController.h:
775
776         * DumpRenderTree/WorkQueueItem.h:
777         (LoadHTMLStringItem::LoadHTMLStringItem):
778
779         * DumpRenderTree/chromium/LayoutTestController.cpp:
780         (WorkItemLoadHTMLString::WorkItemLoadHTMLString):
781         (WorkItemLoadHTMLString::run):
782         (LayoutTestController::queueLoadHTMLString):
783
784         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
785         (LoadHTMLStringItem::invoke):
786         * DumpRenderTree/mac/WorkQueueItemMac.mm:
787         (LoadHTMLStringItem::invoke):
788         * DumpRenderTree/win/WorkQueueItemWin.cpp:
789         (LoadHTMLStringItem::invoke):
790
791 2011-01-17  Dan Bernstein  <mitz@apple.com>
792
793         Rubber-stamped by Mark Rowe.
794
795         Update xcodeproj svn:ignore to include xcuserdata.
796
797         * DumpRenderTree/DumpRenderTree.xcodeproj: Modified property svn:ignore.
798         * MiniBrowser/MiniBrowser.xcodeproj: Modified property svn:ignore.
799         * TestWebKitAPI/TestWebKitAPI.xcodeproj: Modified property svn:ignore.
800         * WebKitLauncher/WebKitLauncher.xcodeproj: Modified property svn:ignore.
801         * WebKitTestRunner/WebKitTestRunner.xcodeproj: Modified property svn:ignore.
802
803 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
804
805         Unreviewed fix after r75908.
806
807         Move WebKit into Source
808         https://bugs.webkit.org/show_bug.cgi?id=52530
809
810         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add Source to the path for Qt API tests.
811
812 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
813
814         Unreviewed.
815
816         Remove accidentally committed debug printing after r75908.
817
818         * Scripts/webkitdirs.pm:
819
820 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
821
822         Unreviewed.
823
824         Add myself to committers list
825         https://bugs.webkit.org/show_bug.cgi?id=52566
826
827         * Scripts/webkitpy/common/config/committers.py:
828
829 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
830
831         Reviewed by Jeremy Orlow.
832
833         GeolocationController should call stopUpdating on destruction
834         https://bugs.webkit.org/show_bug.cgi?id=52216
835
836         fast/dom/Geolocation/window-close-crash.html requires that a
837         Geolocation watch be started in a secondary window. Consequently,
838         we need to allow geolocation permission and provide a mock
839         geolocation position for the secondary window's
840         GeolocationClientMock.
841
842         * DumpRenderTree/chromium/LayoutTestController.cpp:
843         (LayoutTestController::setGeolocationPermission):
844         (LayoutTestController::setMockGeolocationPosition):
845         (LayoutTestController::setMockGeolocationError):
846         * DumpRenderTree/chromium/TestShell.h:
847         (TestShell::windowList):
848
849 2011-01-16  Adam Barth  <abarth@webkit.org>
850
851         Update more include paths to reflect WebKit move.
852
853         * DumpRenderTree/chromium/EventSender.cpp:
854         (EventSender::keyDown):
855         (EventSender::needsShiftModifier):
856         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
857         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
858
859 2011-01-16  Kent Tamura  <tkent@chromium.org>
860
861         Unreviewed, Chromium build fix.
862
863         * Scripts/update-webkit-chromium: Webkit/chromium -> Source/WebKit/chromium
864
865 2011-01-16  Martin Robinson  <mrobinson@igalia.com>
866
867         Build fix for GTK+ after source directory movement.
868
869         * GNUmakefile.am: Correct include paths.
870
871 2011-01-16  Adam Barth  <abarth@webkit.org>
872
873         Teach svn-apply about WebKit move.
874
875         * Scripts/VCSUtils.pm:
876
877 2011-01-16  Adam Barth  <abarth@webkit.org>
878
879         Rubber-stamped by Eric Seidel.
880
881         Move WebKit into Source
882         https://bugs.webkit.org/show_bug.cgi?id=52530
883
884         * DumpRenderTree/mac/InternalHeaders/WebKit/WebTypesInternal.h:
885         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
886         * DumpRenderTree/qt/DumpRenderTreeQt.h:
887         * DumpRenderTree/qt/GCControllerQt.cpp:
888         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
889         * DumpRenderTree/qt/PlainTextControllerQt.cpp:
890         * DumpRenderTree/qt/TextInputControllerQt.cpp:
891         * DumpRenderTree/wscript:
892         * QtTestBrowser/launcherwindow.h:
893         * Scripts/build-webkit:
894         * Scripts/webkitdirs.pm:
895
896 2011-01-15  Adam Barth  <abarth@webkit.org>
897
898         Teach svn-apply about WebKit2 move.
899
900         * Scripts/VCSUtils.pm:
901
902 2011-01-15  Adam Barth  <abarth@webkit.org>
903
904         Rubber-stamped by Eric Seidel.
905
906         Move WebKit2 into Source
907         https://bugs.webkit.org/show_bug.cgi?id=52438
908
909         * MiniBrowser/qt/MiniBrowser.pro:
910         * Scripts/build-webkit:
911         * Scripts/do-file-rename:
912         * Scripts/do-webcore-rename:
913         * Scripts/test-webkitpy:
914         * Scripts/webkitdirs.pm:
915         * Scripts/webkitpy/style/checker.py:
916         * WebKitTestRunner/DerivedSources.pro:
917         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
918         * WebKitTestRunner/qt/WebKitTestRunner.pro:
919
920 2011-01-15  Jochen Eisinger  <jochen@chromium.org>
921
922         Reviewed by David Levin.
923
924         [chromium] remove obsolete createView method
925         https://bugs.webkit.org/show_bug.cgi?id=52437
926
927         * DumpRenderTree/chromium/WebViewHost.cpp:
928         (WebViewHost::createView):
929         * DumpRenderTree/chromium/WebViewHost.h:
930
931 2011-01-14  Brian Weinstein  <bweinstein@apple.com>
932
933         Reviewed by Geoff Garen.
934
935         ShouldLoadResourceForFrame should use strings, not URLs.
936         https://bugs.webkit.org/show_bug.cgi?id=52476
937
938         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
939         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Update to use a WKStringRef.
940         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
941
942 2011-01-14  Tony Gentilcore  <tonyg@chromium.org>
943
944         Reviewed by David Levin.
945
946         Add Tony Gentilcore as a reviewer
947         https://bugs.webkit.org/show_bug.cgi?id=52480
948
949         * Scripts/webkitpy/common/config/committers.py:
950
951 2011-01-14  David Levin  <levin@chromium.org>
952
953         Reviewed by Eric Seidel.
954
955         check-webkit-style: _FunctionState should keep track of where the function name starts.
956         https://bugs.webkit.org/show_bug.cgi?id=52454
957
958         * Scripts/webkitpy/style/checkers/cpp.py: Added function_name_start_position to
959         _FunctionState and logic for setting it correctly.
960         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests.
961
962 2011-01-14  Vincent Scheib  <scheib@chromium.org>
963
964         Reviewed by David Levin.
965
966         Add support to DumpRenderTree to use the GPU rather than software renderer
967         https://bugs.webkit.org/show_bug.cgi?id=52333
968
969         * DumpRenderTree/chromium/DumpRenderTree.cpp:
970         (main):
971         * Scripts/webkitpy/layout_tests/port/chromium.py:
972         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
973
974 2011-01-14  Tony Chang  <tony@chromium.org>
975
976         Reviewed by Kent Tamura.
977
978         [chromium] update fonts.conf to fix 6 linux tests in drt
979         https://bugs.webkit.org/show_bug.cgi?id=52411
980
981         * DumpRenderTree/chromium/fonts.conf: Update to match the copy in
982             chromium's src/webkit/tools/test_shell/resources/fonts.conf
983
984 2011-01-14  Eric Seidel  <eric@webkit.org>
985
986         Original patch from Peter Gal  <galpater@inf.u-szeged.hu>
987
988         Reviewed by Adam Barth.
989
990         Fix when running Tools/Scripts/check-webkit-style without arguments.
991         https://bugs.webkit.org/show_bug.cgi?id=52261#c16
992
993         * Scripts/webkitpy/common/checkout/scm.py: Handle None for changed_files argument better in Git.create_patch method.
994         * Scripts/webkitpy/common/checkout/scm_unittest.py:
995
996 2011-01-04  Jochen Eisinger  <jochen@chromium.org>
997
998         Reviewed by David Levin.
999
1000         Store the tempdir object in a variable so it doesn't get deleted too early.
1001         https://bugs.webkit.org/show_bug.cgi?id=51875
1002
1003         * Scripts/update-webkit-auxiliary-libs:
1004         * Scripts/update-webkit-support-libs:
1005
1006 2011-01-14  Eric Seidel  <eric@webkit.org>
1007
1008         Unreviewed.  Make it work in python 2.5.
1009
1010         webkit-patch suggest-reviewers dies when ChangeLogs are missing
1011         https://bugs.webkit.org/show_bug.cgi?id=49158
1012
1013         * Scripts/webkitpy/common/checkout/api_unittest.py:
1014
1015 2011-01-14  Sheriff Bot  <webkit.review.bot@gmail.com>
1016
1017         Unreviewed, rolling out r75774.
1018         http://trac.webkit.org/changeset/75774
1019         https://bugs.webkit.org/show_bug.cgi?id=52431
1020
1021         gtk builds were broken (Requested by loislo2 on #webkit).
1022
1023         * Scripts/webkitpy/common/checkout/scm.py:
1024
1025 2011-01-14  David Levin  <levin@chromium.org>
1026
1027         Reviewed by Shinichiro Hamaji.
1028
1029         check-webkit-style: _FunctionState should detect pure functions.
1030         https://bugs.webkit.org/show_bug.cgi?id=52428
1031
1032         * Scripts/webkitpy/style/checkers/cpp.py: Added detection for if a function declaration
1033         is a pure virtual function.
1034         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests for verifying that pure
1035         virtual functions are correctly detected.
1036
1037 2011-01-13  Ilya Tikhonovsky  <loislo@chromium.org>
1038
1039         Reviewed by Yury Semikhatsky.
1040
1041         Just small fix for problem with check-webkit-style.
1042         It just didn't work for this patch.
1043         Old code can't concatenate a list of strings with None.
1044
1045         * Scripts/webkitpy/common/checkout/scm.py:
1046
1047 2011-01-13  David Levin  <levin@chromium.org>
1048
1049         Reviewed by Shinichiro Hamaji.
1050
1051         check-webkit-style: _FunctionState should use Position to know where items are.
1052         https://bugs.webkit.org/show_bug.cgi?id=52424
1053
1054         * Scripts/webkitpy/style/checkers/cpp.py:
1055         (_FunctionState.*): Changed _FunctionState to use Position instead of line numbers.
1056         (detect_functions): Changed to pass Position's to _FunctionState.begin and
1057         did some minor clean-up.
1058         (*): Other changes are simply about converting to use the Position's in_FunctionState
1059         instead of line numbers.
1060         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Changed the test code
1061         to verify the positions stored in _FunctionState.
1062
1063 2011-01-13  Eric Seidel  <eric@webkit.org>
1064
1065         Reviewed by David Levin.
1066
1067         webkit-patch suggest-reviewers dies when ChangeLogs are missing
1068         https://bugs.webkit.org/show_bug.cgi?id=49158
1069
1070         This is not the most elegant, but it is a very safe fix to this bug.
1071         One advantage of catching ScriptError like this instead of adding a
1072         new added_or_modified_files or fixing all changed_files callers
1073         to use a more specific change_files variant, is that we catch
1074         all kinds of ScriptErrors which might cause our (non-essential)
1075         suggest-reviewers code to fail out.  This should make passing
1076         --suggest-reviewers to webkit-patch upload much more robust
1077         and may even make it possible for us to make it default.
1078
1079         The root of the problem here is that SCM.changed_files includes
1080         deleted ChangeLog paths (from moves, etc) which then when we ask
1081         SVN/Git for the contents of the file at that revision, the command
1082         errors out and Executive.run_command raises a ScriptError.
1083
1084         In the future we might fix this differently by making all current
1085         callers of chagned_files use a more specific method for requesting
1086         what types of changes they're interested in (adds, modifies, deletes, etc.)
1087
1088         * Scripts/webkitpy/common/checkout/api.py:
1089         * Scripts/webkitpy/common/checkout/api_unittest.py:
1090
1091 2011-01-13  Dan Bernstein  <mitz@apple.com>
1092
1093         Reviewed by Alexey Proskuryakov.
1094
1095         <rdar://problem/8827065> REGRESSION (r71884): Cross-origin XHR fails if willSendRequest changes the URL
1096         https://bugs.webkit.org/show_bug.cgi?id=52419
1097
1098         Allow to further control the behavior of the willSendRequest delegate callback by making it
1099         set a different URL in the new request.
1100
1101         * DumpRenderTree/LayoutTestController.cpp:
1102         (addURLToRedirectCallback): Added.
1103         (LayoutTestController::staticFunctions): Added addURLToRedirect.
1104         (LayoutTestController::addURLToRedirect): Added. Adds the redirection to the map.
1105         (LayoutTestController::redirectionDestinationForURL): Added this getter.
1106         * DumpRenderTree/LayoutTestController.h:
1107         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1108         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]): Check
1109         if there is a redirection for the request’s URL, established by addURLToRedirect(), and if so,
1110         change the URL in the new request to the redirect destination.
1111
1112 2011-01-13  Eric Seidel  <eric@webkit.org>
1113
1114         Reviewed by Mihai Parparita.
1115
1116         webkit-patch suggest-reviewers fails due to invalid utf8 in ChangeLog files
1117         https://bugs.webkit.org/show_bug.cgi?id=52416
1118
1119         Example: webkit-patch suggest-reviewers -g ca3890fe74d94d85d6bfa48f9ea497b094d8e717 
1120         UnicodeDecodeError: 'utf8' codec can't decode bytes in position 536-538: invalid data
1121
1122         I also added FIXMEs about the changed_files returning deleted files problem
1123         which is causing the other most common exception for suggest-reviewers
1124         (and is probably breaking sheriff-bots blame detection).
1125
1126         * Scripts/webkitpy/common/checkout/api.py:
1127         * Scripts/webkitpy/common/checkout/api_unittest.py:
1128         * Scripts/webkitpy/common/checkout/scm.py:
1129
1130 2011-01-13  Eric Seidel  <eric@webkit.org>
1131
1132         Reviewed by Adam Barth.
1133
1134         results archives from commit-queue are too large to upload
1135         https://bugs.webkit.org/show_bug.cgi?id=52405
1136
1137         * Scripts/webkitpy/common/system/filesystem.py:
1138         * Scripts/webkitpy/common/system/filesystem_mock.py:
1139         * Scripts/webkitpy/tool/commands/queues.py:
1140
1141 2011-01-13  Alejandro G. Castro  <alex@igalia.com>
1142
1143         Reviewed by Martin Robinson.
1144
1145         [gtk] Zero-sized font does not yet work
1146         https://bugs.webkit.org/show_bug.cgi?id=49793
1147
1148         Set minimum-font-size to 0 for the DRT.
1149
1150         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1151         (resetDefaultsToConsistentValues):
1152
1153 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
1154
1155         Reviewed by Darin Adler.
1156
1157         Make old-run-webkit-tests more robust on buildbots
1158         https://bugs.webkit.org/show_bug.cgi?id=52364
1159
1160         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Pass --exit-after-n-failures 500 to old-run-webkit-tests script.
1161
1162 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
1163
1164         Reviewed by Darin Adler.
1165
1166         Make old-run-webkit-tests more robust on buildbots
1167         https://bugs.webkit.org/show_bug.cgi?id=52364
1168
1169         * Scripts/old-run-webkit-tests: Ensure that testResultsDirectory is empty.
1170
1171 2011-01-13  Tony Chang  <tony@chromium.org>
1172
1173         Reviewed by Kent Tamura.
1174
1175         [chromium] fix plugins/plugin-javascript-access.html on Linux and Mac
1176         https://bugs.webkit.org/show_bug.cgi?id=52332
1177
1178         Forked Info.plist is not longer needed.
1179
1180         * DumpRenderTree/chromium/TestNetscapePlugIn/Info.plist: Removed.
1181
1182 2011-01-13  Mikhail Naganov  <mnaganov@chromium.org>
1183
1184         Reviewed by Timothy Hatcher.
1185
1186         Web Inspector: Cleanup after r75613 -- make all UI-facing strings
1187         to be passed directly to WebInspector.UIString
1188
1189         https://bugs.webkit.org/show_bug.cgi?id=52365
1190
1191         * Scripts/check-inspector-strings:
1192
1193 2011-01-13  Sheriff Bot  <webkit.review.bot@gmail.com>
1194
1195         Unreviewed, rolling out r74881.
1196         http://trac.webkit.org/changeset/74881
1197         https://bugs.webkit.org/show_bug.cgi?id=52357
1198
1199         The EFL builder has been red for days (Requested by abarth on
1200         #webkit).
1201
1202         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1203         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1204
1205 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
1206
1207         Reviewed by David Levin.
1208
1209         Add beforeunload support to WebKitTestRunner
1210         https://bugs.webkit.org/show_bug.cgi?id=52353
1211         
1212         This makes a number of currently failing tests pass.
1213
1214         * WebKitTestRunner/TestController.cpp:
1215         (WTR::runBeforeUnloadConfirmPanel):
1216         (WTR::createOtherPage):
1217         (WTR::TestController::initialize):
1218
1219 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
1220
1221         Reviewed by Sam Weinig.
1222
1223         Detect, identify and recover from WebProcess crashes in run-webkit-tests
1224         https://bugs.webkit.org/show_bug.cgi?id=52330
1225
1226         * Scripts/old-run-webkit-tests: Detect when the regression test tool reports
1227         a web process crash.
1228         * WebKitTestRunner/TestController.cpp:
1229         (WTR::TestController::initialize): Set up a processDidCrash
1230         callback.
1231         (WTR::TestController::processDidCrash): Report that the Web process
1232         crashed.
1233         * WebKitTestRunner/TestController.h:
1234
1235 2011-01-12  David Levin  <levin@chromium.org>
1236
1237         Reviewed by Shinichiro Hamaji.
1238
1239         check-webkit-style -- close_expression function doesn't work correctly.
1240         https://bugs.webkit.org/show_bug.cgi?id=52272
1241
1242         * Scripts/webkitpy/style/checkers/cpp.py:
1243         (Position.__str__): Added a way to convert it to a string which is useful in tests.
1244         (Position.__cmp__): Added a way to compare Position which is useful in tests and
1245         generally useful (for upcoming code changes).
1246         (close_expression): Changed to use Position for input and output.
1247         Also, fixed many bugs such as only working correctly for parenthesis,
1248         not working correctly if given an offset in a line and not finding
1249         the real closing element if there were multiple closing elements in
1250         the same line.
1251         (detect_functions): Adjusted due to the change in arguments for
1252         close_expression.
1253         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1254         (CppStyleTestBase.assert_positions_equal): Added a way to verify that
1255         two positions are the same.
1256         (CppStyleTest.test_position): Added tests for the __str_ and __cmp__ methods.
1257         (CppStyleTest.test_close_expression): Added tests to catch the issues
1258         that were fixed.
1259
1260 2011-01-12  Sheriff Bot  <webkit.review.bot@gmail.com>
1261
1262         Unreviewed, rolling out r75576.
1263         http://trac.webkit.org/changeset/75576
1264         https://bugs.webkit.org/show_bug.cgi?id=52304
1265
1266         broke rebaseline-chromium-webkit-test (Requested by thakis on
1267         #webkit).
1268
1269         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1270         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1271         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
1272         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1273         * Scripts/webkitpy/layout_tests/port/base.py:
1274         * Scripts/webkitpy/layout_tests/port/chromium.py:
1275         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1276         * Scripts/webkitpy/layout_tests/port/test.py:
1277         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1278         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1279         * Scripts/webkitpy/style/checkers/test_expectations.py:
1280         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1281
1282 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
1283
1284         Reviewed by Darin Adler.
1285
1286         Add a no-build option to run-webkit-tests, to avoid building DRT/WKTR
1287         https://bugs.webkit.org/show_bug.cgi?id=52307
1288
1289         * Scripts/old-run-webkit-tests:
1290
1291 2011-01-12  Koan-Sin Tan  <koansin.tan@gmail.com>
1292
1293         Reviewed by Martin Robinson.
1294
1295         [Gtk] WebKitGtk+ doesn't build on Mac OS X 10.6
1296         https://bugs.webkit.org/show_bug.cgi?id=50867
1297
1298         Fixed library extention for Mac in webkitdirs.pm and type conflict in
1299         TestNetscapePlugin.cpp 
1300
1301         * GNUmakefile.am: Don't use AppKit when compiling TestNetscapePlugin for GTK+
1302         * Scripts/webkitdirs.pm:
1303
1304 2011-01-12  Mikhail Naganov  <mnaganov@chromium.org>
1305
1306         Reviewed by Pavel Feldman.
1307
1308         Add check-inspector-strings script.
1309
1310         https://bugs.webkit.org/show_bug.cgi?id=52295
1311
1312         * Scripts/check-inspector-strings: Added.
1313
1314 2011-01-12  Adam Roben  <aroben@apple.com>
1315
1316         Advertise the .testnetscape file extension on Windows
1317
1318         Fixes <http://webkit.org/b/52298>
1319         plugins/no-mime-with-valid-extension.html fails on Windows
1320
1321         Reviewed by Dan Bernstein.
1322
1323         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Added a
1324         FileExtents field to map the .testnetscape file extension to the
1325         application/x-webkit-test-netscape MIME type, just as we do on Mac.
1326
1327 2011-01-12  Adam Barth  <abarth@webkit.org>
1328
1329         Reviewed by Eric Seidel.
1330
1331         Make webkit-patch support subdirectories for SVN checkouts
1332         https://bugs.webkit.org/show_bug.cgi?id=52261
1333
1334         os.relpath does not exist on Python 2.5, so we need to call our version
1335         of the API.
1336
1337         * Scripts/webkitpy/common/checkout/scm.py:
1338
1339 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
1340
1341         Reviewed by Eric Seidel.
1342
1343         Close additional pages opened during a test once the test completes.
1344         https://bugs.webkit.org/show_bug.cgi?id=52276
1345
1346         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1347         (WTR::InjectedBundle::done):
1348
1349 2011-01-11  David Levin  <levin@chromium.org>
1350
1351         Reviewed by Eric Seidel.
1352
1353         Errors should be separated from the command line in bot messages.
1354         https://bugs.webkit.org/show_bug.cgi?id=52275
1355
1356         * Scripts/webkitpy/common/system/executive.py:
1357         (ScriptError.message_with_output): Added a newline to separate the command
1358         line from the errors.
1359         * Scripts/webkitpy/common/system/executive_unittest.py:
1360         (ScriptErrorTest.test_message_with_output): Added tests for the various code
1361         paths in message_with_output.
1362
1363 2011-01-11  Eric Seidel  <eric@webkit.org>
1364
1365         Unreviewed.
1366
1367         commit-queue should know how to upload archived results (for test flakes or general failures)
1368         https://bugs.webkit.org/show_bug.cgi?id=52048
1369
1370         The zips are mostly empty due to forgetting -r.
1371         Expected diffs were not being pulled from the archive due
1372         to the archive having longer paths than I realized.
1373
1374         * Scripts/webkitpy/common/system/workspace.py:
1375         * Scripts/webkitpy/common/system/workspace_unittest.py:
1376         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1377         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1378
1379 2011-01-11  Dirk Pranke  <dpranke@chromium.org>
1380
1381         Reviewed by Ojan Vafai.
1382
1383         The current modifier parsing code in test_expectations is
1384         fragile and hard-coded, so it's not easy to understand the logic
1385         or easily add new types of modifiers (like GPU vs. CPU testing
1386         for graphics tests, or 32-bit vs. 64-bit differences).
1387
1388         This is the first of two patches that will add in more generic
1389         support and then eliminate the GPU-specific test expectations
1390         files for Chromium.
1391
1392         This patch adds two standalone objects for handling modifiers. The
1393         rules for interpreting modifiers, precedence, and conflicts are
1394         given in the docstring to the ModifierMatcher class, which
1395         returns ModifierMatchResult objects.
1396         
1397         This patch also adds routines to the Port interface and a
1398         default set of values in the base object, in order to obtain the
1399         values needed on a given test run. These values are then passed
1400         to the expectation parser. This also allows us to clean up the
1401         logic used to lint all of the different configurations in a
1402         single test_expectations.txt file.
1403
1404         The next patch will merge in the separate GPU expectations file.
1405
1406         https://bugs.webkit.org/show_bug.cgi?id=51222
1407
1408         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1409         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1410         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
1411         * Scripts/webkitpy/layout_tests/port/base.py:
1412         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1413         * Scripts/webkitpy/layout_tests/port/chromium.py:
1414         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1415         * Scripts/webkitpy/layout_tests/port/test.py:
1416         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1417         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1418
1419 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
1420
1421         Reviewed by Adam Barth.
1422
1423         Make webkit-patch support subdirectories for SVN checkouts
1424         https://bugs.webkit.org/show_bug.cgi?id=52261
1425
1426         * Scripts/webkitpy/common/checkout/scm.py:
1427         * Scripts/webkitpy/style_references.py:
1428         * Scripts/webkitpy/tool/main.py:
1429         * Scripts/webkitpy/tool/steps/preparechangelog.py:
1430
1431 2011-01-11  Eric Seidel  <eric@webkit.org>
1432
1433         Unreviewed.
1434
1435         commit-queue should know how to upload archived results (for test flakes or general failures)
1436         https://bugs.webkit.org/show_bug.cgi?id=52048
1437
1438         I changed the API for archive_last_layout_test_results w/o updating the implementation.  Oops.
1439         This fixes an exception seen on the commit-queue when attempting to report flaky tests.
1440
1441         * Scripts/webkitpy/common/system/workspace.py:
1442         * Scripts/webkitpy/common/system/workspace_unittest.py:
1443         * Scripts/webkitpy/tool/commands/queues.py:
1444
1445 2011-01-11  Sam Weinig  <sam@webkit.org>
1446
1447         Roll r75474 back in.
1448
1449 2011-01-11  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
1450
1451         Reviewed by Kenneth Rohde Christiansen.
1452
1453         [Qt] Remove uses of QFuture since it isn't supported on all platforms.
1454         https://bugs.webkit.org/show_bug.cgi?id=51204
1455
1456         * QtTestBrowser/webpage.h:
1457         (QtNAMThread::QtNAMThread):
1458         (QtNAMThread::networkAccessManager):
1459         (QtNAMThread::run):
1460
1461 2011-01-11  Peter Varga  <pvarga@webkit.org>
1462
1463         Unreviewed.
1464
1465         Add myself to committers' list.
1466
1467         * Scripts/webkitpy/common/config/committers.py:
1468
1469 2011-01-11  Eric Seidel  <eric@webkit.org>
1470
1471         Reviewed by Adam Barth.
1472
1473         commit-queue should know how to upload archived results (for test flakes or general failures)
1474         https://bugs.webkit.org/show_bug.cgi?id=52048
1475
1476         Now the queue will always upload results.  Either the entire zip, or just
1477         the diffs.txt in the case of text failures.
1478
1479         This should make understanding flakes much easier, and paves the way
1480         for having the EWS run layout tests (and upload failures).
1481
1482         In order to upload .zip files I had to teach bugzilla.py to autodetect
1483         mime types from the filename.  Since mimetypes.py doesn't include a mapping
1484         for .patch files, I have it add one before calling guess_type.
1485
1486         We may find that always uploading the whole zip instead of just the -diffs.txt
1487         file is preferable, but for now I'm keeping the old behavior because it makes
1488         quickly understanding text failures easy.
1489
1490         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1491         * Scripts/webkitpy/common/system/workspace.py: Added.
1492         * Scripts/webkitpy/common/system/workspace_unittest.py: Added.
1493         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1494         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1495         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1496         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1497         * Scripts/webkitpy/tool/commands/queues.py:
1498         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1499
1500 2011-01-10  Sheriff Bot  <webkit.review.bot@gmail.com>
1501
1502         Unreviewed, rolling out r75464.
1503         http://trac.webkit.org/changeset/75464
1504         https://bugs.webkit.org/show_bug.cgi?id=52193
1505
1506         Followup rollout for 75474 (Requested by Ossy on #webkit).
1507
1508         * MiniBrowser/mac/BrowserWindowController.m:
1509         (-[BrowserWindowController awakeFromNib]):
1510         * MiniBrowser/win/BrowserView.cpp:
1511         (BrowserView::create):
1512         * WebKitTestRunner/TestController.cpp:
1513         (WTR::createOtherPage):
1514         (WTR::TestController::initialize):
1515
1516 2011-01-10  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1517
1518         Reviewed by Csaba Osztrogonác.
1519
1520         [Qt] Baseline qt_minimal configuration
1521         https://bugs.webkit.org/show_bug.cgi?id=51313
1522
1523         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1524         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): Add
1525         QT_NO_UNDOSTACK guard.
1526
1527         * QtTestBrowser/launcherwindow.cpp:
1528         (LauncherWindow::createChrome): Add QT_NO_SHORTCUT and QT_NO_PRINTER
1529         guards.
1530         (LauncherWindow::applyZoom): Add QT_NO_ANIMATION guard.
1531         (LauncherWindow::screenshot): Add QT_NO_FILEDIALOG guard.
1532         (LauncherWindow::selectElements): Add QT_NO_INPUTDIALOG guard.
1533         (LauncherWindow::showUserAgentDialog): Add QT_NO_COMBOBOX guard.
1534
1535         * QtTestBrowser/launcherwindow.h:
1536         * QtTestBrowser/locationedit.cpp: Add QT_NO_INPUTDIALOG guard.
1537         * QtTestBrowser/locationedit.h: Ditto.
1538
1539         * QtTestBrowser/mainwindow.cpp:
1540         (MainWindow::buildUI): Add QT_NO_INPUTDIALOG, QT_NO_SHORTCUT and
1541         QT_NO_UNDOSTACK guards.
1542         (MainWindow::setAddressUrl): Add QT_NO_INPUTDIALOG guard.
1543         (MainWindow::changeLocation): Ditto.
1544         (MainWindow::openFile): Add QT_NO_FILEDIALOG guard.
1545         (MainWindow::openLocation): Add QT_NO_INPUTDIALOG guard.
1546
1547         * QtTestBrowser/webpage.cpp:
1548         (WebPage::openUrlInDefaultBrowser): Add QT_NO_DESKTOPSERVICES guard.
1549         (WebPage::authenticationRequired): Add QT_NO_LINEEDIT guard.
1550
1551         * QtTestBrowser/webview.cpp:
1552         (WebViewGraphicsBased::animatedFlip): Add QT_NO_ANIMATION guard.
1553         (WebViewGraphicsBased::animatedYFlip): Ditto.
1554
1555 2011-01-10  Sam Weinig  <sam@webkit.org>
1556
1557         Fix build.
1558
1559         * MiniBrowser/mac/BrowserWindowController.m:
1560         (-[BrowserWindowController awakeFromNib]):
1561         * MiniBrowser/win/BrowserView.cpp:
1562         (BrowserView::create):
1563         * WebKitTestRunner/TestController.cpp:
1564         (WTR::createOtherPage):
1565         (WTR::TestController::initialize):
1566
1567 2011-01-10  Eric Seidel  <eric@webkit.org>
1568
1569         Reviewed by Ojan Vafai.
1570
1571         style-queue messages are way too long for big patches
1572         https://bugs.webkit.org/show_bug.cgi?id=52161
1573
1574         We definitely could build much fancier list-to-string-with-limit functions
1575         but this should be sufficient for our needs at the moment.
1576
1577         * Scripts/webkitpy/common/system/executive.py:
1578         * Scripts/webkitpy/common/system/executive_unittest.py:
1579
1580 2011-01-10  Tony Chang  <tony@chromium.org>
1581
1582         Unreviewed, rolling out r75398.
1583         http://trac.webkit.org/changeset/75398
1584         https://bugs.webkit.org/show_bug.cgi?id=52008
1585
1586         Some layout tests are crashing on Chromium Win.
1587
1588         * DumpRenderTree/chromium/WebViewHost.cpp:
1589         (WebViewHost::updatePaintRect):
1590         * DumpRenderTree/chromium/WebViewHost.h:
1591
1592 2011-01-10  Adam Roben  <aroben@apple.com>
1593
1594         Roll out r75392
1595
1596         It isn't needed now that r75289 has been rolled out.
1597
1598         * Scripts/run-javascriptcore-tests:
1599
1600 2011-01-10  Maciej Stachowiak  <mjs@apple.com>
1601
1602         Reviewed by Anders Carlsson.
1603
1604         WebKitTestRunner uses crazy amounts of CPU, making layout tests slow and flaky
1605         https://bugs.webkit.org/show_bug.cgi?id=52160
1606
1607         * WebKitTestRunner/mac/TestControllerMac.mm:
1608         (WTR::TestController::platformRunUntil): Instead of busy-looping, wait for the timeout.
1609         Anything that can make runUntil() conditions turn true will happen on a run loop cycle
1610         anyway.
1611
1612 2011-01-10  Tony Chang  <tony@chromium.org>
1613
1614         Reviewed by Mihai Parparita.
1615
1616         [chromium] fix for animated gif layout tests
1617         https://bugs.webkit.org/show_bug.cgi?id=52008
1618
1619         * DumpRenderTree/chromium/WebViewHost.cpp: Schedule a paint when we update the paint rect
1620             to trigger gif animations.
1621         (WebViewHostPaintTask::WebViewHostPaintTask):
1622         (WebViewHostPaintTask::runIfValid):
1623         (WebViewHost::updatePaintRect):
1624         * DumpRenderTree/chromium/WebViewHost.h:
1625         (WebViewHost::taskList):
1626
1627 2011-01-10  Alejandro G. Castro  <alex@igalia.com>
1628
1629         Reviewed by Xan Lopez.
1630
1631         [GTK] Fix gtk2 compilation for master
1632         https://bugs.webkit.org/show_bug.cgi?id=51885
1633
1634         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
1635         (createBitmapContextFromWebView): Replaced the old
1636         gdk_drawable_get_size with gdk_pixmap_get_size.
1637
1638 2011-01-10  Patrick Gansterer  <paroga@webkit.org>
1639
1640         Reviewed by Laszlo Gombos.
1641
1642         [WINCE] Reenable NPAPI after r75203
1643         https://bugs.webkit.org/show_bug.cgi?id=52109
1644
1645         Remove the !isWinCE() check for ENABLE_NETSCAPE_PLUGIN_API and replace
1646         it with !isEfl(), because EFL port does not support NPAPI (yet).
1647
1648         * Scripts/build-webkit:
1649
1650 2011-01-10  Adam Roben  <aroben@apple.com>
1651
1652         Skip some asserting JS tests
1653
1654         See <http://webkit.org/b/52156>.
1655
1656         * Scripts/run-javascriptcore-tests:
1657
1658 2011-01-10  Martin Robinson  <mrobinson@igalia.com>
1659
1660         Reviewed by Xan Lopez.
1661
1662         [GTK] build-webkit disable Blob support via arguments passed to automake
1663         https://bugs.webkit.org/show_bug.cgi?id=52097
1664
1665         * Scripts/build-webkit: Enable Blob support when building WebKitGTK+ via
1666         build-webkit.
1667
1668 2011-01-10  Adam Roben  <aroben@apple.com>
1669
1670         Use the same name and description for TestNetscapePlugin on Windows and
1671         Mac
1672
1673         Fixes <http://webkit.org/b/52151>
1674         fast/frames/iframe-reparenting-plugins.html fails on Windows
1675
1676         Reviewed by Steve Falkenburg.
1677
1678         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Copied
1679         the name and description from Mac's Info.plist.
1680
1681 2011-01-10  Siddharth Mathur <siddharth.mathur@nokia.com>
1682
1683         Reviewed by Laszlo Gombos.
1684
1685         [Qt][WK2] Guard gcc-specific syntax
1686
1687         Non-gcc based compliers choke on the "-include"
1688         syntax for preinclude, place guard around it.
1689
1690         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1691         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1692
1693 2011-01-10  Andreas Kling  <kling@webkit.org>
1694
1695         Reviewed by Simon Hausmann.
1696
1697         [Qt] [WK2] MiniBrowser does not load pages opened in new windows
1698         https://bugs.webkit.org/show_bug.cgi?id=52111
1699
1700         When getting a createNewPage() callback from QWKPage, create the
1701         new page with the same QWKContext as the page that is passed to
1702         the callback.
1703
1704         * MiniBrowser/qt/BrowserView.h:
1705         * MiniBrowser/qt/BrowserWindow.cpp:
1706         (newPageFunction):
1707         (BrowserWindow::BrowserWindow):
1708         * MiniBrowser/qt/BrowserWindow.h:
1709
1710 2011-01-10  Andreas Kling  <kling@webkit.org>
1711
1712         Reviewed by Kenneth Rohde Christiansen.
1713
1714         [Qt] MiniBrowser: Remove superfluous createNewPage() callback
1715
1716         BrowserView set its own useless createNewPage() callback on QWKPage.
1717         This was immediately overridden by BrowserWindow anyway, so remove
1718         the BrowserView one.
1719
1720         * MiniBrowser/qt/BrowserView.cpp:
1721         (BrowserView::BrowserView):
1722
1723 2011-01-10  John Knottenbelt  <jknotten@chromium.org>
1724
1725         Reviewed by Jeremy Orlow.
1726
1727         [Chromium] Remove non-client-based Geolocation code
1728         https://bugs.webkit.org/show_bug.cgi?id=50921
1729
1730         * DumpRenderTree/chromium/LayoutTestController.cpp:
1731         (LayoutTestController::setGeolocationPermission):
1732         (LayoutTestController::setMockGeolocationPosition):
1733         (LayoutTestController::setMockGeolocationError):
1734         * DumpRenderTree/chromium/WebViewHost.cpp:
1735         (WebViewHost::geolocationClientMock):
1736         (WebViewHost::reset):
1737         * DumpRenderTree/chromium/WebViewHost.h:
1738
1739 2011-01-10  Eric Seidel  <eric@webkit.org>
1740
1741         Reviewed by Adam Barth.
1742
1743         Commit bot tried to land r? cq+ patch
1744         https://bugs.webkit.org/show_bug.cgi?id=36638
1745
1746         It should now be possible to post a patch with r? and cq+ and the
1747         commit-queue will correctly wait for the r+ before attempting to land the patch.
1748         (This was a feature requested by several users.)
1749
1750         One caveat: We don't actually reject r-, cq+ patches from the queue
1751         (we just ignore them), but I think that's OK for now.
1752
1753         I also noticed that setting r- once a commit-queue node had grabbed
1754         a patch would not properly cancel the landing.  That's fixed and
1755         tested in this patch.
1756
1757         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1758         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1759         * Scripts/webkitpy/tool/bot/feeders.py:
1760         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
1761
1762 2011-01-08  Benjamin Poulain  <benjamin.poulain@nokia.com>
1763
1764         Reviewed by Kenneth Rohde Christiansen.
1765
1766         [Qt] QtWebKit crashes when using XMLHttpRequest from the unload event
1767         https://bugs.webkit.org/show_bug.cgi?id=51934
1768
1769         When accessing the network from the destructor of QWebPage, the network access manager
1770         was already deleted because the object WebPage was already destructed.
1771
1772         This solve the problem by linking the lifetime of the network access manager to WebPage's QObject.
1773         The object is now destructed in the destructor of QObject.
1774
1775         * QtTestBrowser/webpage.cpp:
1776         (WebPage::WebPage):
1777         (WebPage::setQnamThreaded):
1778         * QtTestBrowser/webpage.h:
1779         (QtNAMThread::QtNAMThread):
1780
1781 2011-01-08  Eric Seidel  <eric@webkit.org>
1782
1783         Reviewed by Ojan Vafai.
1784
1785         test_failures.py should not mention TestShell (long live DumpRenderTree!)
1786         https://bugs.webkit.org/show_bug.cgi?id=52067
1787
1788         I ran test-webkitpy, but didn't bother adding a unit test for this string change.
1789         https://bugs.webkit.org/show_bug.cgi?id=51138#c3 is an example of why this is needed.
1790
1791         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1792
1793 2011-01-08  Eric Seidel  <eric@webkit.org>
1794
1795         Reviewed by Mihai Parparita.
1796
1797         commit-queue hangs when the ChangeLog diff is bad
1798         https://bugs.webkit.org/show_bug.cgi?id=52072
1799
1800         * Scripts/webkitpy/tool/steps/validatechangelogs.py:
1801         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
1802
1803 2011-01-08  Adam Barth  <abarth@webkit.org>
1804
1805         Teach svn-apply how to re-write WebCore to Source/WebCore.
1806
1807         * Scripts/VCSUtils.pm:
1808
1809 2011-01-07  Adam Barth  <abarth@webkit.org>
1810
1811         Rubber-stamped by Eric Seidel.
1812
1813         Move WebCore to Source
1814         https://bugs.webkit.org/show_bug.cgi?id=52050
1815
1816         Update the tools to understand WebCore's new location.
1817
1818         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1819         * DumpRenderTree/wscript:
1820         * GNUmakefile.am:
1821         * Scripts/build-webkit:
1822         * Scripts/do-file-rename:
1823         * Scripts/do-webcore-rename:
1824         * Scripts/generate-qt-inspector-resource:
1825         * Scripts/prepare-ChangeLog:
1826         * Scripts/run-bindings-tests:
1827         * Scripts/update-iexploder-cssproperties:
1828         * Scripts/update-sources-list.py:
1829         * Scripts/update-webkit-localizable-strings:
1830         * Scripts/webkitdirs.pm:
1831         * Scripts/webkitpy/common/config/build.py:
1832         * Scripts/webkitpy/common/config/build_unittest.py:
1833         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
1834         * Scripts/webkitpy/style/checker.py:
1835         * Scripts/webkitpy/style/checker_unittest.py:
1836         * WebKitTestRunner/DerivedSources.pro:
1837         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1838         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh:
1839         * wx/browser/wscript:
1840         * wx/build/settings.py:
1841
1842 2011-01-07  Maciej Stachowiak  <mjs@apple.com>
1843
1844         Reviewed by Sam Weinig.
1845
1846         Make WebKitTestRunner rest between loads more robust to avoid test crashes
1847         https://bugs.webkit.org/show_bug.cgi?id=52086
1848
1849         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1850         (WTR::InjectedBundle::didReceiveMessage):
1851         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1852         (WTR::LayoutTestController::notifyDone):
1853         * WebKitTestRunner/TestController.cpp:
1854         (WTR::TestController::resetStateToConsistentValues):
1855         (WTR::TestController::run):
1856
1857 2011-01-07  James Robinson  <jamesr@chromium.org>
1858
1859         Revert "Implement mozilla's animationTime property"
1860         https://bugs.webkit.org/show_bug.cgi?id=51952
1861
1862         This approach isn't quite right.
1863
1864         * DumpRenderTree/chromium/WebViewHost.cpp:
1865         (WebViewHost::paintInvalidatedRegion):
1866
1867 2011-01-07  Adam Roben  <aroben@apple.com>
1868
1869         Build master fix
1870
1871         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1872         (RunWebKitTests.start): Don't try to concatenate a list and a string.
1873
1874 2011-01-07  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>
1875
1876         Reviewed by Csaba Osztrogonác.
1877
1878         run-qtwebkit-tests should be able to kill a testsuite.
1879
1880         Add new option in the script that can setup a timeout for a test.
1881         If the test execution takes more then specified time then the test
1882         would be terminated.
1883
1884         [Qt] run-qtwebkit-tests needs timeout
1885         https://bugs.webkit.org/show_bug.cgi?id=51894
1886
1887         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1888         * Scripts/run-qtwebkit-tests:
1889
1890 2011-01-07  Csaba Osztrogonác  <ossy@webkit.org>
1891
1892         Unreviewed fix after r75233.
1893
1894         Based on idea from Eric Seidel.
1895
1896         Add remote zip file handling to webkitpy.
1897         https://bugs.webkit.org/show_bug.cgi?id=50901
1898
1899         * Scripts/webkitpy/common/system/fileset.py: Make python 2.5 happy.
1900
1901 2011-01-07  Shane Stephens  <shanestephens@google.com>
1902
1903         Reviewed by Eric Seidel.
1904
1905         svn-apply: should support git binary delta diffs
1906         https://bugs.webkit.org/show_bug.cgi?id=38864
1907
1908         * Scripts/VCSUtils.pm:
1909         * Scripts/svn-apply:
1910
1911 2011-01-06  Julie Parent  <jparent@chromium.org>
1912
1913         Reviewed by Eric Seidel.
1914
1915         Test Result Server not removing old results.
1916         https://bugs.webkit.org/show_bug.cgi?id=52012
1917
1918         * TestResultServer/model/jsonresults.py:
1919         Fix off-by-one: Truncate if >= num_runs, not just >.
1920         * TestResultServer/model/jsonresults_unittest.py:
1921         Add unit test to test that merging in a new result with the same value
1922         as the last result causes previous result to fall off.
1923
1924 2011-01-06  James Kozianski  <koz@chromium.org>
1925
1926         Reviewed by Mihai Parparita.
1927
1928         Add classes to provide a consistent interface to a set of files.
1929         https://bugs.webkit.org/show_bug.cgi?id=50901
1930
1931         These classes allow us to write code that is agnostic to whether a
1932         particular set of files resides in a local directory or in a zip file
1933         on a remote machine.
1934
1935         * Scripts/webkitpy/common/system/directoryfileset.py: Added.
1936         * Scripts/webkitpy/common/system/directoryfileset_unittest.py: Added.
1937         * Scripts/webkitpy/common/system/fileset.py: Added.
1938         * Scripts/webkitpy/common/system/filesystem.py:
1939         * Scripts/webkitpy/common/system/filesystem_mock.py:
1940         * Scripts/webkitpy/common/system/zipfileset.py: Added.
1941         * Scripts/webkitpy/common/system/zipfileset_unittest.py: Added.
1942
1943 2011-01-06  Eric Seidel  <eric@webkit.org>
1944
1945         Reviewed by Adam Barth.
1946
1947         NetworkTransaction should log the url it is retrying
1948         https://bugs.webkit.org/show_bug.cgi?id=52043
1949
1950         * Scripts/webkitpy/common/net/networktransaction.py:
1951         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
1952
1953 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
1954
1955         Windows build fix.
1956         Import os before using it.
1957
1958         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1959
1960 2011-01-06  Eric Seidel  <eric@webkit.org>
1961
1962         Reviewed by Adam Barth.
1963
1964         StyleQueue fails to report errors when patches have many files
1965         https://bugs.webkit.org/show_bug.cgi?id=52042
1966
1967         This is one of at least two errors preventing style error reporting at the moment.
1968         When we moved to passing the list of files to check explicitly,
1969         we started to exceed the 500 character TEXT field limit for our AppEngine model object.
1970         We could change the type of the QueueStatus.message type, or we could
1971         just teach statusserver.py how to clamp values (and warn when it does).
1972         I chose the latter path.
1973
1974         * Scripts/webkitpy/common/net/statusserver.py:
1975
1976 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
1977
1978         Reviewed by Stephanie Lewis.
1979         
1980         Fix syntax error in script.
1981
1982         Windows bots need to archive/unarchive builds to/from configuration-specific directories
1983         https://bugs.webkit.org/show_bug.cgi?id=51996
1984
1985         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1986
1987 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1988
1989         Unreviewed, fixing WinCE build after r75196.
1990
1991         WinCE port does not (yet) support NPAPI.
1992
1993         * Scripts/build-webkit:
1994
1995 2011-01-06  Xan Lopez  <xlopez@igalia.com>
1996
1997         Reviewed by Darin Adler.
1998
1999         File::Spec->rel2abs in sunspider-compare-results mangles parameters
2000         https://bugs.webkit.org/show_bug.cgi?id=52015
2001
2002         * Scripts/sunspider-compare-results: call rel2abs on our arguments
2003         after the platform has been detected, otherwise the script will
2004         mangle things like '--gtk' into '/a/path/--gtk', breaking the
2005         detection.
2006
2007 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2008
2009         Reviewed by Eric Seidel.
2010
2011         Add ENABLE_NETSCAPE_PLUGIN_API, ENABLE_ORIENTATION_EVENTS and ENABLE_TOUCH_EVENTS flags to build-webkit
2012         https://bugs.webkit.org/show_bug.cgi?id=51346
2013
2014         * Scripts/build-webkit:
2015
2016 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
2017
2018         Reviewed by Adam Roben.
2019
2020         Windows bots need to archive/unarchive builds to/from configuration-specific directories
2021         https://bugs.webkit.org/show_bug.cgi?id=51996
2022         
2023         After the configuration directory change, we were archiving the incorrect directory for
2024         build product, so we were running tests on the wrong binaries.
2025         
2026         This change archives the correct directory, and also unarchives it into a configuration-
2027         specific directory.
2028
2029         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Use a configuration-specific directory on Windows.
2030         * BuildSlaveSupport/built-product-archive: Unarchive/archive to/from proper directory.
2031
2032 2011-01-06  Eric Seidel  <eric@webkit.org>
2033
2034         Reviewed by Mihai Parparita.
2035
2036         commit-queue mentions "Text diff mismatch" 4 times instead of once per failure
2037         https://bugs.webkit.org/show_bug.cgi?id=52002
2038
2039         See an example of this here:
2040         https://bugs.webkit.org/show_bug.cgi?id=51314#c2
2041
2042         It's due to the fact that we pass around TestFailure() instance
2043         objects and yet expect them to all compare to be the same.
2044
2045         This is bad.  We should either have shared instances of these values
2046         or we should just pass around the class names.  There are already hacks
2047         in place to make TestFailure objects pass equality tests, I just added
2048         a __hash__ implementation so they can be used in sets as expected.
2049
2050         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2051         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
2052
2053 2011-01-06  Evan Martin  <evan@chromium.org>
2054
2055         Reviewed by Tony Chang.
2056
2057         [gdb] handle inaccessible memory and UChar*
2058         https://bugs.webkit.org/show_bug.cgi?id=52003
2059
2060         To pretty-print a UChar*, we just grope around in the memory
2061         looking for a terminating NUL.  We need to handle the exception
2062         that can occur when we poke into an invalid location.
2063
2064         Additionally, the logic for choosing which pretty-printer would
2065         early return before hitting the point where we'd use the UChar*
2066         printer.  (Did this ever work?  How did it regress?)
2067
2068         * gdb/webkit.py:
2069
2070 2011-01-05  Brian Weinstein  <bweinstein@apple.com>
2071
2072         Reviewed by Ada Chan.
2073
2074         WebKit2: Should be able to call into injected bundle to ask if we should allow resource loads
2075         https://bugs.webkit.org/show_bug.cgi?id=51969
2076         
2077         Add shouldLoadResourceForFrame to WTR::InjectedBundlePage.
2078
2079         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2080         (WTR::InjectedBundlePage::InjectedBundlePage):
2081         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Stub implementation.
2082         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2083
2084 2011-01-06  James Robinson  <jamesr@chromium.org>
2085
2086         Reviewed by Simon Fraser.
2087
2088         Implement mozilla's animationTime property
2089         https://bugs.webkit.org/show_bug.cgi?id=51952
2090
2091         Chromium DRT support for webkitAnimationTime.
2092
2093         * DumpRenderTree/chromium/WebViewHost.cpp:
2094         (WebViewHost::paintInvalidatedRegion):
2095
2096 2011-01-06  Julie Parent  <jparent@chromium.org>
2097
2098         Reviewed by Tony Chang.
2099
2100         Test Result Server always truncates number of results to JSON_RESULTS_MAX_BUILDS
2101         https://bugs.webkit.org/show_bug.cgi?id=51217
2102
2103         * TestResultServer/model/jsonresults.py:
2104         Pass num_runs through to _remove_items_over_max_number_of_builds, and use the value.
2105         Adds missing documentation.
2106         * TestResultServer/model/jsonresults_unittest.py:
2107         Add unit test to test that truncation happens at smaller value than JSON_RESULTS_MAX_BUILDS.
2108         Update test_merge to take a number of builds to truncate at.
2109
2110 2011-01-06  Adam Barth  <abarth@webkit.org>
2111
2112         Reviewed by Eric Seidel.
2113
2114         The EWS should log outside of the working directory
2115         https://bugs.webkit.org/show_bug.cgi?id=51986
2116
2117         This patch prepare us for using git clean -x -d -f in the EWS wrapper
2118         script, which will actually clean the working copy back to a pristine
2119         state instead of leaving untracked directories and ignored files.
2120
2121         * Scripts/webkitpy/tool/commands/queues.py:
2122         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2123
2124 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
2125
2126         Windows build fix.
2127         Back out attempted change to built-product-archive.
2128
2129         * BuildSlaveSupport/built-product-archive:
2130
2131 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
2132
2133         Windows build fix.
2134         Include configuration name when unpacking a build archive.
2135
2136         Needed, since we split Windows build results into configuration-specific directories
2137         under WebKitOutputDir.
2138
2139         * BuildSlaveSupport/built-product-archive:
2140
2141 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
2142
2143         Reviewed by Darin Adler.
2144
2145         Debug and Release builds on Windows clobber each other
2146         https://bugs.webkit.org/show_bug.cgi?id=49185
2147
2148         Changes the structure of WebKitBuild build products directory so we
2149         completely separate each build configuration into independent directories.
2150         
2151         Although we previously had per-configuration directories for obj, this change adds
2152         per-configuration directories for bin, lib, obj, and include. Each configuration's
2153         build products are stored within a directory inside of WebKitBuild.
2154         
2155         Most use of $(WebKitOutputDir) in the build files has been replaced by $(ConfigurationBuildDir),
2156         defined in common.vsprops to be $(WebKitOutputDir)\$(ConfigurationName).
2157
2158         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops:
2159         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd:
2160         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd:
2161         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
2162         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd:
2163         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd:
2164         * DumpRenderTree/win/ImageDiffCommon.vsprops:
2165         * DumpRenderTree/win/ImageDiffPostBuild.cmd:
2166         * DumpRenderTree/win/ImageDiffPreBuild.cmd:
2167         * FindSafari/FindSafari.vcproj:
2168         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
2169         * MiniBrowser/MiniBrowserPostBuild.cmd:
2170         * MiniBrowser/MiniBrowserPreBuild.cmd:
2171         * Scripts/webkitdirs.pm:
2172         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
2173         * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops:
2174         * TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd:
2175         * TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd:
2176         * TestWebKitAPI/win/copy-resources.cmd:
2177         * WebKitAPITest/WebKitAPITestCommon.vsprops:
2178         * WebKitAPITest/WebKitAPITestPostBuild.cmd:
2179         * WebKitAPITest/WebKitAPITestPreBuild.cmd:
2180         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
2181         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
2182         * WebKitTestRunner/win/InjectedBundle.vcproj:
2183         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops:
2184         * WebKitTestRunner/win/InjectedBundlePostBuild.cmd:
2185         * WebKitTestRunner/win/InjectedBundlePreBuild.cmd:
2186         * WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd:
2187         * WebKitTestRunner/win/WebKitTestRunnerPreBuild.cmd:
2188         * WinLauncher/WinLauncherCommon.vsprops:
2189         * WinLauncher/WinLauncherPostBuild.cmd:
2190         * WinLauncher/WinLauncherPreBuild.cmd:
2191
2192 2011-01-05  Jan Erik Hanssen  <jhanssen@sencha.com>
2193
2194         Reviewed by Ariya Hidayat.
2195
2196         [Qt] TestNetscapePlugin doesn't link on OS X
2197         https://bugs.webkit.org/show_bug.cgi?id=51948
2198
2199         Only add a dependency on libX11 on X11 systems
2200
2201         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2202
2203 2011-01-05  Jeff Miller  <jeffm@apple.com>
2204
2205         Reviewed by Adam Roben.
2206
2207         check-webkit-style should allow unnecessary parameter names in WebKit2 APIs because we're matching CF's header style
2208         https://bugs.webkit.org/show_bug.cgi?id=51970
2209
2210         * Scripts/webkitpy/style/checker.py:
2211         Add -readability/naming for WebKit2 C API directories.
2212
2213 2011-01-05  Eric Seidel  <eric@webkit.org>
2214
2215         Unreviewed, just fixing one more log error from my previous python patch.
2216
2217         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
2218         https://bugs.webkit.org/show_bug.cgi?id=51802
2219
2220         webkit-patch failure-reason was logging about parsing errors
2221         due to my misunderstanding of how BeautifulSoup.findAll worked.
2222
2223         Fixed, and added a unit test.
2224
2225         * Scripts/webkitpy/common/net/layouttestresults.py:
2226         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2227
2228 2011-01-05  Benjamin Poulain  <benjamin.poulain@nokia.com>
2229
2230         Reviewed by Kenneth Rohde Christiansen.
2231
2232         [Qt] [WK2] Add the possibility to open window from the WebProcess in Minibrowser
2233         https://bugs.webkit.org/show_bug.cgi?id=51951
2234
2235         Set a function to QWKPage::setCreateNewPageFunction() in Minibrowser so there is a way
2236         to create new window from WebKit.
2237
2238         * MiniBrowser/qt/BrowserWindow.cpp:
2239         (newPageFunction):
2240         (BrowserWindow::BrowserWindow):
2241         (BrowserWindow::page): Added to avoid the indirect access to QWKPage spread in the class
2242         (BrowserWindow::newWindow):
2243         (BrowserWindow::updateUserAgentList):
2244         (BrowserWindow::showUserAgentDialog):
2245         * MiniBrowser/qt/BrowserWindow.h: Add the global variable backingStoreTypeForNewWindow to
2246         define the type of the backing store used for new windows.
2247         * MiniBrowser/qt/main.cpp:
2248         (main):
2249
2250 2011-01-05  Eric Seidel  <eric@webkit.org>
2251
2252         Reviewed by Ojan Vafai.
2253
2254         commit-queue should report failure type when reporting flaky tests
2255         https://bugs.webkit.org/show_bug.cgi?id=51900
2256
2257         This patch was a ridiculous amount of plumbing.  In the end I like
2258         the NRWT-style TestResult class even less.  But now we're passing
2259         a list of TestResult objects from the queue to the FlakyTestReporter.
2260         Thus the FlakyTestReporter can more easily report what type of failure
2261         occurred.
2262
2263         In the process, I found that I was not alone in finding TestResult
2264         cumbersome to use.  A bunch of code was trying to create a TestResult
2265         object with default values.  However since the constructor didn't make
2266         this easy, some places were getting it wrong (including the TestResult unit test)!
2267         I've fixed the TestResult constructor to have default values for non-essential
2268         arguments.
2269
2270         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2271         * Scripts/webkitpy/common/net/layouttestresults.py:
2272         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2273         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2274         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2275         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2276         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
2277         * Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py:
2278         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2279         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2280         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2281         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2282         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2283         * Scripts/webkitpy/tool/commands/queues.py:
2284         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2285
2286 2011-01-05  Eric Seidel  <eric@webkit.org>
2287
2288         Unreviewed.
2289
2290         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
2291         https://bugs.webkit.org/show_bug.cgi?id=51802
2292
2293         Add another unit test to cover a previously missing import.
2294
2295         * Scripts/webkitpy/common/net/layouttestresults.py:
2296         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2297
2298 2011-01-05  Mihai Parparita  <mihaip@chromium.org>
2299
2300         Reviewed by David Levin.
2301
2302         Add mihaip@chromium.org as a reviewer
2303         https://bugs.webkit.org/show_bug.cgi?id=51966
2304         
2305         Add myself as a reviewer.
2306
2307         * Scripts/webkitpy/common/config/committers.py:
2308
2309 2011-01-05  James Simonsen  <simonjam@chromium.org>
2310
2311         Unreviewed. Adding myself to the list of committers.
2312
2313         * Scripts/webkitpy/common/config/committers.py:
2314
2315 2011-01-05  Eric Seidel  <eric@webkit.org>
2316
2317         Unreviewed.
2318
2319         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
2320         https://bugs.webkit.org/show_bug.cgi?id=51802
2321
2322         Fix two exceptions seen on the bots after my original commit.
2323
2324         * Scripts/webkitpy/common/net/layouttestresults.py:
2325         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2326
2327 2011-01-05  Kundu Suchismita  <suchi.kundu@nokia.com>
2328
2329         Reviewed by Andreas Kling.
2330
2331         [Qt]Add local storage settings to QtTestBrowser command line arguments 
2332         https://bugs.webkit.org/show_bug.cgi?id=51750
2333
2334         * QtTestBrowser/main.cpp:
2335         (LauncherApplication::handleUserOptions):
2336          Local storage settings can be enable form command line arguments for
2337          QtTestBrowser.
2338
2339 2011-01-05  Chris Fleizach  <cfleizach@apple.com>
2340
2341         Reviewed by Martin Robinson.
2342
2343         GTK: AX: DRT needs to use correct root object method.
2344         https://bugs.webkit.org/show_bug.cgi?id=51911
2345
2346         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
2347         (AccessibilityController::rootElement):
2348
2349 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
2350
2351         Rubber-stamped by Csaba Osztrogonác.
2352
2353         Based on idea from Péter Gál.
2354
2355         * Scripts/webkitpy/tool/bot/sheriff.py: Remove unnecessary apostrophes around revision numbers.
2356
2357 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
2358
2359         Reviewed by Adam Barth.
2360
2361         sheriff-bot should be able to do multi-revision rollouts
2362         https://bugs.webkit.org/show_bug.cgi?id=51176
2363
2364         * Scripts/webkitpy/tool/bot/irc_command.py:
2365         * Scripts/webkitpy/tool/bot/sheriff.py:
2366         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
2367
2368 2011-01-05  Eric Seidel  <eric@webkit.org>
2369
2370         Reviewed by Adam Barth.
2371
2372         queues.webkit.org should have per-bot status pages
2373         https://bugs.webkit.org/show_bug.cgi?id=51906
2374
2375         Just adds a /queue-status/QUEUE_NAME/bots/BOT_ID page to show
2376         statuses from a single queue.  Now that we have many bots servicing
2377         some queues (commit-queue, win-ews, etc.) its easy to have the messages
2378         you care about scroll off the end of the 15-message limit on the main page.
2379
2380         Eventually we should probably rename /queue-status to /queue or /queues,
2381         but that's fodder for another patch.
2382
2383         * QueueStatusServer/handlers/queuestatus.py:
2384         * QueueStatusServer/index.yaml:
2385         * QueueStatusServer/main.py:
2386         * QueueStatusServer/templates/includes/singlequeuestatus.html:
2387          - This probably should use a custom filter instead of hard-coding
2388            the URL scheme here, but I couldn't figure out how to easily
2389            create such a filter.  Most filters work with "strings" so we can't
2390            pass the status object.  We could add a method to the status
2391            object and call that, but that seemed a bit strange too.
2392         * QueueStatusServer/templates/queuestatus.html:
2393
2394 2011-01-05  Carlos Garcia Campos  <cgarcia@igalia.com>
2395
2396         Unreviewed. Adding myself to the list of committers.
2397
2398         * Scripts/webkitpy/common/config/committers.py:
2399
2400 2011-01-04  Koan-Sin Tan  <koansin.tan@gmail.com>
2401
2402         Reviewed by David Levin.
2403
2404         check-webkit-style treated some macros with parentheses after #elif as function calls
2405         https://bugs.webkit.org/show_bug.cgi?id=51695
2406
2407         Ingore function call space checking in any preprocessor directives
2408         (things starting with #). Change search() to match() because 
2409         preprocessor directives are supposed to be in the beginning of lines.
2410
2411         * Scripts/webkitpy/style/checkers/cpp.py:
2412         * Scripts/webkitpy/style/checkers/cpp_unittest.py: make sure there is no false positives for #elif cases
2413
2414 2011-01-04  Søren Gjesse  <sgjesse@chromium.org>
2415
2416         Reviewed by Tony Chang.
2417
2418         Change the --multi-load test option to --stress-opt
2419         https://bugs.webkit.org/show_bug.cgi?id=50751
2420
2421         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2422         (runTest):
2423         (main):
2424         * DumpRenderTree/chromium/TestShell.cpp:
2425         (TestShell::TestShell):
2426         * DumpRenderTree/chromium/TestShell.h:
2427         (TestShell::stressOpt):
2428         (TestShell::setStressOpt):
2429         (TestShell::stressDeopt):
2430         (TestShell::setStressDeopt):
2431         (TestShell::javaScriptFlags):
2432         (TestShell::setJavaScriptFlags):
2433         * Scripts/webkitpy/layout_tests/port/chromium.py:
2434         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2435
2436 2011-01-04  Chris Fleizach  <cfleizach@apple.com>
2437
2438         Reviewed by Sam Weinig.
2439
2440         WK2: Support Accessibility
2441         https://bugs.webkit.org/show_bug.cgi?id=51859
2442
2443         Use rootObject() method to get top of accessibility tree.
2444
2445         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
2446         (AccessibilityController::focusedElement):
2447         (AccessibilityController::rootElement):
2448
2449 2011-01-03  Martin Robinson  <mrobinson@igalia.com>
2450
2451         Reviewed by Darin Adler.
2452
2453         Remove the last non-GObject usage of PlatformRefPtr and move the code to GRefPtr
2454         https://bugs.webkit.org/show_bug.cgi?id=51846
2455
2456         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: Change usage of PlatformRefPtr
2457         back to GRefPtr.
2458
2459 2011-01-04  Zhe Su  <suzhe@chromium.org>
2460
2461         Reviewed by Kenneth Russell.
2462
2463         Fix insertText, setMarkedText and unmarkText methods of
2464         TextInputController to call corresponding methods of WebKit::WebView
2465         rather than WebKit::WebFrame. This change matches the behavior of
2466         chromium browser.
2467         insertText corresponds to WebView::confirmComposition(text)
2468         setMarkedText corresponds to WebView::setComposition(...)
2469         unmarkText corresponds to WebView::confirmComposition()
2470         https://bugs.webkit.org/show_bug.cgi?id=51693
2471
2472         * DumpRenderTree/chromium/TextInputController.cpp:
2473         (TextInputController::insertText):
2474         (TextInputController::setMarkedText):
2475         (TextInputController::unmarkText):
2476
2477 2011-01-04  Dihan Wickremasuriya  <dihan.wickremasuriya@nokia.com>
2478
2479         Reviewed by Laszlo Gombos.
2480
2481         [Qt] [Symbian] Do not remove 0 byte sized files from productDir
2482
2483         On Symbian productDir points to the source directory. Removing all the
2484         empty files from the productDir directory corrupts the svn repository.
2485
2486         * Scripts/build-webkit:
2487
2488 2011-01-03  Yi Shen  <yi.4.shen@nokia.com>
2489
2490         Reviewed by Adam Barth.
2491
2492         [Qt] Add SelectAll option to the context menu for the editor
2493         https://bugs.webkit.org/show_bug.cgi?id=50049
2494
2495         Set shortcut for the SelectAll action.
2496
2497         * QtTestBrowser/mainwindow.cpp:
2498         (MainWindow::buildUI):
2499
2500 2011-01-03  David Levin  <levin@chromium.org>
2501
2502         Reviewed by Eric Seidel.
2503
2504         check-webkit-style shouldn't consider "value" automatically to be a meaningless name.
2505         https://bugs.webkit.org/show_bug.cgi?id=51842
2506
2507         * Scripts/webkitpy/style/checkers/cpp.py: Remove the check for value.
2508         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Remove the test for value.
2509
2510 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
2511
2512         Reviewed by David Kilzer.
2513
2514         [WINCE] Adds a build slave.
2515         https://bugs.webkit.org/show_bug.cgi?id=50523
2516
2517         * BuildSlaveSupport/build.webkit.org-config/config.json: Add an
2518         entry for a release build of the WinCE port.
2519         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add platform
2520         flag to build the WinCE port.
2521
2522 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
2523
2524         Reviewed by David Kilzer.
2525
2526         Add WinCE support to build-webkit
2527         https://bugs.webkit.org/show_bug.cgi?id=51642
2528
2529         * Scripts/build-webkit:
2530         * Scripts/webkitdirs.pm:
2531
2532 2011-01-03  Eric Seidel  <eric@webkit.org>
2533
2534         Reviewed by Adam Barth.
2535
2536         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
2537         https://bugs.webkit.org/show_bug.cgi?id=51802
2538
2539         I'm not the biggest fan of the test_failures or test_results classes,
2540         but it's better to have one shared set of classes, than separate ones
2541         for new vs. old run-webkit-test result handling.
2542
2543         This moves the ORWT results class "LayoutTestResults" over to using
2544         TestResult and TestFailure classes, making it easy for us to
2545         make all our sheriff-bot and other webkitpy code NRWT ready.
2546
2547         This also makes it a trivial patch to generate results.json information
2548         from ORWT results.html files (for flaky test analysis, etc.) as well
2549         as making it a one-liner to report test failure types when the
2550         commit-queue sees flaky tests.
2551
2552         This patch tried not to add new functionality, but only to replace
2553         the guts of LayoutTestResults, while adding unit tests and hoping
2554         not to break anything.
2555
2556         I also moved callers which assumed User.prompt* were static/class methods
2557         to using them as instance methods (since we'll eventually want to make them such).
2558
2559         In the process of re-writing things, I broke the rebaseline command, so I wrote
2560         a unit test to catch my breakage were I do do so again in the future.
2561
2562         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2563         * Scripts/webkitpy/common/net/layouttestresults.py:
2564         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2565         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
2566         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
2567         * Scripts/webkitpy/tool/commands/queries.py:
2568         * Scripts/webkitpy/tool/commands/rebaseline.py:
2569         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2570         * Scripts/webkitpy/tool/mocktool.py:
2571
2572 2011-01-03  Adam Barth  <abarth@webkit.org>
2573
2574         Reviewed by Simon Fraser.
2575
2576         webkit-patch shouldn't waste time cleaning a working directory that's already clean
2577         https://bugs.webkit.org/show_bug.cgi?id=51840
2578
2579         * Scripts/webkitpy/common/checkout/scm.py:
2580
2581 2011-01-03  Adam Barth  <abarth@webkit.org>
2582
2583         Reviewed by Simon Fraser.
2584
2585         webkit-patch should only hide update output if --quiet
2586         https://bugs.webkit.org/show_bug.cgi?id=51838
2587
2588         As requested by smfr.
2589
2590         * Scripts/webkitpy/tool/steps/update.py:
2591
2592 2011-01-03  Adam Barth  <abarth@webkit.org>
2593
2594         Reviewed by David Levin.
2595
2596         commit-queue shouldn't reject patches twice if two bots process the same patch
2597         https://bugs.webkit.org/show_bug.cgi?id=51805
2598
2599         Before raising an error, we first check whether the patch is still in
2600         the commit-queue.  This check is still racy, of course, but the time
2601         window is much smaller.
2602
2603         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2604
2605 2011-01-03  Sam Weinig  <sam@webkit.org>
2606
2607         Reviewed by Anders Carlsson.
2608
2609         Make run-api-tests less chatty.
2610         https://bugs.webkit.org/show_bug.cgi?id=51831
2611
2612         - Make script quiet by default and add --verbose option (replacing --quiet).
2613         - When not verbose, pipe stdout and stderr to devnull.
2614
2615         * Scripts/run-api-tests:
2616
2617 2011-01-03  Pratik Solanki  <psolanki@apple.com>
2618
2619         Unreviewed. Adding myself to committers.py.
2620
2621         * Scripts/webkitpy/common/config/committers.py:
2622
2623 2011-01-03  Koan-Sin Tan  <koansin.tan@gmail.com>
2624
2625         Reviewed by Xan Lopez.
2626
2627         "Tool/Scripts/run-launcher --gtk" stopped working after 74855
2628         https://bugs.webkit.org/show_bug.cgi?id=51806
2629
2630         Originally, the $libraryName is 'JavaScriptCore'. When building release 
2631         one, the $libraryDir was 'WebKitBuild/Release/JavaScriptCore/../.libs/'
2632         which doesn't exist anymore ('WebKitBuild/Release/JavaScriptCore'
2633         is 'WebKitBuild/Release/Source/JavaScriptCore' now), and 
2634         'WebKitBuild/Release/Source/JavaScriptCore/../../.libs' looks weird,
2635         so make it 'WebKitBuild/Release/.libs'
2636
2637         * Scripts/webkitdirs.pm: 
2638
2639 2011-01-02  Patrick Gansterer  <paroga@webkit.org>
2640
2641         Reviewed by Adam Barth.
2642
2643         Make EFL a core builder
2644         https://bugs.webkit.org/show_bug.cgi?id=51804
2645
2646         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2647         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2648
2649 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
2650
2651         [Qt] Unreviewed fix after r74855 and r74875.
2652
2653         * BuildSlaveSupport/built-product-archive:
2654          - Create directories explicitly.
2655          - Pass shell=True to subprocess.call().
2656
2657 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
2658
2659         [Qt] Unreviewed fix after r74855.
2660
2661         Move JavaScriptCore to Source
2662         https://bugs.webkit.org/show_bug.cgi?id=51604
2663
2664         * BuildSlaveSupport/built-product-archive: JavaScriptCore -> Source/JavaScriptCore
2665
2666 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
2667
2668         [Qt] Unreviewed run-javasriptcore-tests fix after r74855.
2669
2670         Move JavaScriptCore to Source
2671         https://bugs.webkit.org/show_bug.cgi?id=51604
2672
2673         * Scripts/webkitdirs.pm:
2674
2675 2011-01-02  Robert Hogan  <robert@webkit.org>
2676
2677         Unreviewed, build fix.
2678
2679         [Qt] Fix DRT build after 74855
2680
2681         * DumpRenderTree/qt/DumpRenderTree.pro:
2682
2683 2011-01-01  Adam Barth  <abarth@webkit.org>
2684
2685         Remove the assumption from the Qt and Gtk builds that every project is
2686         in the root directory.
2687
2688         * Scripts/build-webkit:
2689
2690 2011-01-01  Adam Barth  <abarth@webkit.org>
2691
2692         Reviewed by Eric Seidel.
2693
2694         Teach svn-apply how to apply patches even though JavaScriptCore has moved
2695         https://bugs.webkit.org/show_bug.cgi?id=51796
2696
2697         After this change, svn-apply will magically apply patches to
2698         JavaScriptCore/foo to Source/JavaScriptCore/foo.
2699
2700         * Scripts/VCSUtils.pm:
2701
2702 2011-01-01  Adam Barth  <abarth@webkit.org>
2703
2704         Reviewed by Eric Seidel.
2705
2706         Move JavaScriptCore to Source
2707         https://bugs.webkit.org/show_bug.cgi?id=51604
2708
2709         Update references to JavaScriptCore to point to the new location.
2710
2711         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2712         * DumpRenderTree/qt/DumpRenderTree.pro:
2713         * DumpRenderTree/qt/ImageDiff.pro:
2714         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2715         * DumpRenderTree/wscript:
2716         * Scripts/build-jsc:
2717         * Scripts/build-webkit:
2718         * Scripts/do-file-rename:
2719         * Scripts/do-webcore-rename:
2720         * Scripts/run-javascriptcore-tests:
2721         * Scripts/update-javascriptcore-test-results:
2722         * Scripts/webkitdirs.pm:
2723         * Scripts/webkitpy/common/config/build_unittest.py:
2724         * Scripts/webkitpy/style/checker.py:
2725         * Scripts/webkitpy/style/checker_unittest.py:
2726         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2727         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2728         * WebKitTestRunner/qt/WebKitTestRunner.pro:
2729         * wx/build/settings.py:
2730
2731 2011-01-01  Adam Barth  <abarth@webkit.org>
2732
2733         Reviewed by Eric Seidel.
2734
2735         Move Sources to Source
2736         https://bugs.webkit.org/show_bug.cgi?id=51794
2737
2738         Update scripts to point to the new location.
2739
2740         * Scripts/build-webkit:
2741         * Scripts/do-file-rename:
2742         * Scripts/do-webcore-rename:
2743         * Scripts/webkitpy/common/config/build.py:
2744         * Scripts/webkitpy/common/config/build_unittest.py:
2745
2746 2010-12-31  Kent Tamura  <tkent@chromium.org>
2747
2748         Reviewed by Eric Seidel.
2749
2750         [DRT/Chromium] Enable mock spell checker on non-OSX
2751         https://bugs.webkit.org/show_bug.cgi?id=51401
2752
2753         * DumpRenderTree/chromium/WebViewHost.cpp:
2754         (WebViewHost::spellCheck):
2755
2756 2010-12-31  Adam Barth  <abarth@webkit.org>
2757
2758         Reviewed by Ariya Hidayat.
2759
2760         Remove Tools/Scripts/wkstyle
2761         https://bugs.webkit.org/show_bug.cgi?id=51774
2762
2763         This script appears to not have been touched in a while and seems to
2764         have been replaced by check-webkit-style.
2765
2766         * Scripts/wkstyle: Removed.
2767
2768 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
2769
2770         Unreviewed. Coding style fix.
2771
2772         * DumpRenderTree/chromium/TestShell.h:
2773
2774 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
2775
2776         Reviewed by Pavel Feldman.
2777
2778         Web Inspector: [Chromium] Inspector's tests are very slow on Win(Dbg).
2779
2780         It was a problem with Chromium DRT. DevToolsAgent object instance was
2781         attached not only to the inspected page but to the DevTools window too.
2782         As result all the inspector files were interpreted as a content of inspected page
2783         and were transfered to the DevTools scripts panel for debugging etc.
2784
2785         https://bugs.webkit.org/show_bug.cgi?id=51735
2786
2787         * DumpRenderTree/chromium/TestShell.cpp:
2788         (TestShell::TestShell):
2789         (TestShell::bindJSObjectsToWindow):
2790         (TestShell::createNewWindow):
2791         * DumpRenderTree/chromium/TestShell.h:
2792
2793 2010-12-31  Adam Barth  <abarth@webkit.org>
2794
2795         Rubber-stamped by Eric Seidel.
2796
2797         Move PageLoadTests to PerformanceTests/PageLoad
2798         https://bugs.webkit.org/show_bug.cgi?id=51771
2799
2800         Update references to PageLoadTests to point to the new location.
2801
2802         * Scripts/run-pageloadtest:
2803         * Scripts/webkitpy/common/config/build.py:
2804
2805 2010-12-31  Adam Barth  <abarth@webkit.org>
2806
2807         Rubber-stamped by Eric Seidel.
2808
2809         Move SunSpider into PerformanceTests
2810         https://bugs.webkit.org/show_bug.cgi?id=51769
2811
2812         Update these scripts to point to the new location.
2813
2814         * Scripts/run-sunspider:
2815         * Scripts/sunspider-compare-results:
2816
2817 2010-12-30  Mihai Parparita  <mihaip@chromium.org>
2818
2819         Reviewed by Kent Tamura.
2820
2821         [Chromium] Add WebThemeEngineDRTMac so that Chromium DRT scrollbar rendering can match the Mac port's
2822         https://bugs.webkit.org/show_bug.cgi?id=51728
2823         
2824         Add implementation of the Mac WebThemeEngine that uses an NSScroller
2825         to render top-level scrollbars. This makes them match the Mac port's
2826         use of an NSScrollView, which means that we'll be able to share more
2827         pixel baselines.
2828         
2829         The new rendering code will not be activated until the 
2830         USE_WEB_THEME_ENGINE_TO_PAINT_THUMB #define is fliped in
2831         ScrollbarThemeChromiumMac.
2832
2833         * DumpRenderTree/DumpRenderTree.gypi:
2834         * DumpRenderTree/chromium/TestShellMac.mm:
2835         (platformInit):
2836         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Added.
2837         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Added.
2838         (+[FakeActiveWindow alwaysActiveWindow]):
2839         (+[FakeActiveWindow alwaysInactiveWindow]):
2840         (-[FakeActiveWindow initWithActiveControls:]):
2841         (-[FakeActiveWindow _hasActiveControls]):
2842         (WebThemeEngineDRTMac::paintScrollbarThumb):
2843         (stateToHIEnableState):
2844         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
2845         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
2846
2847 2010-12-30  Konstantin Tokarev  <annulen@yandex.ru>
2848
2849         Reviewed by David Kilzer.
2850
2851         [Qt] Don't build wtf/TCSystemAlloc.cpp if --system-malloc option is
2852         used
2853         https://bugs.webkit.org/show_bug.cgi?id=51672
2854
2855         * DumpRenderTree/qt/DumpRenderTree.pro: Replaced USE_SYSTEM_MALLOC
2856         with USE_SYSTEM_MALLOC=1
2857         * WebKitTestRunner/qt/WebKitTestRunner.pro: Replaced USE_SYSTEM_MALLOC
2858         with USE_SYSTEM_MALLOC=1
2859
2860 2010-12-30  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2861
2862         Reviewed by David Kilzer.
2863
2864         [Qt] [Symbian] Fix build-webkit script for Symbian
2865         https://bugs.webkit.org/show_bug.cgi?id=51509
2866
2867         Set the OUTPUT_DIR for Symbian to be the same as the source
2868         directory.
2869
2870         * Scripts/webkitdirs.pm:
2871
2872 2010-12-30  Martin Robinson  <mrobinson@igalia.com>
2873
2874         Reviewed by Darin Adler.
2875
2876         check-webkit-style should ignore NULL usage in calls to gtk_widget_style_get
2877         https://bugs.webkit.org/show_bug.cgi?id=51758
2878
2879         Add a check-webkit-style exception for gtk_widget_style_get and NULL usage.
2880
2881         * Scripts/webkitpy/style/checkers/cpp.py: Add the exception.
2882         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Add some tests for this.
2883
2884 2010-12-29  Patrick Gansterer  <paroga@webkit.org>
2885
2886         Unreviewed WinCE buildfix.
2887
2888         * WinCELauncher/main.cpp: Add missing include.
2889
2890 2010-12-29  Daniel Bates  <dbates@rim.com>
2891
2892         Reviewed by Darin Adler.
2893
2894         svn-apply updates date of wrong change log entry for a change log diff that
2895         contains two consecutive entries with the same author and date
2896         https://bugs.webkit.org/show_bug.cgi?id=46061
2897
2898         Fixes an issue where the date of the wrong change log entry may be modified.
2899         Moreover, changes fixChangeLogPatch() to move entries inserted earlier
2900         in a ChangeLog file to the top of the file.
2901
2902         Currently, fixChangeLogPatch() explicitly bails out and returns an unchanged
2903         diff when it detects that the diff inserts a change log entry earlier in a
2904         ChangeLog. It is unusual to land a patch that has such a deliberate ChangeLog
2905         change. With the advent of the commit-queue this functionality of bailing out
2906         and hence landing the patch as-is is harmful to the accuracy of the ChangeLog.
2907         Instead, we should always move the change log entry to the top of the ChangeLog file.
2908
2909         A side-effect of this change is that setChangeLogDateAndReviewer() now updates
2910         the date line of the correct change log entry in a ChangeLog diff.
2911
2912         * Scripts/VCSUtils.pm: Modified fixChangeLogPatch() to move entries inserted earlier to the top.
2913
2914         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
2915           Updated the following unit tests now that we move entries inserted earlier to the top:
2916           - "fixChangeLogPatch: New entry inserted in middle."
2917             (formerly named "fixChangeLogPatch: [no change] New entry inserted in middle.")
2918
2919           - "fixChangeLogPatch: New entry inserted earlier in the file, but after an entry with the same author and date."
2920             (formerly named "fixChangeLogPatch: [no change] New entry inserted earlier in the file, but after an entry with the same author and date.")
2921
2922         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatchThenSetChangeLogDateAndReviewer.pl: Added.
2923
2924 2010-12-29  Konstantin Tokarev  <annulen@yandex.ru>
2925
2926         Reviewed by Eric Seidel.
2927
2928         [Qt] Fixed compatibility with gold linker on X11 platforms
2929         https://bugs.webkit.org/show_bug.cgi?id=51700
2930
2931         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2932         Linked TestNetscapePlugin with libX11 on Unix platforms
2933
2934 2010-12-29  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>
2935
2936         Reviewed by Darin Adler.
2937
2938         Circular dependency in webkitpy.common.checkout.changelog module
2939         https://bugs.webkit.org/show_bug.cgi?id=50475
2940
2941         Remove automatic import of api.Checkout module when any checkout/
2942         submodule is imported (e.g.: when checkout.scm.Git is imported).
2943
2944         * Scripts/webkitpy/common/checkout/__init__.py:
2945
2946 2010-12-29  Martin Robinson  <mrobinson@igalia.com>
2947
2948         Reviewed by Ojan Vafai.
2949
2950         prepare-ChangeLog should support the -g option for specifying the git-commit
2951         https://bugs.webkit.org/show_bug.cgi?id=51708
2952
2953         Add a -g shortcut for the --git-commit prepare-ChangeLog option. This matches
2954         webkit-patch, though the exact meaning of the two options remain different.
2955
2956         * Scripts/prepare-ChangeLog: Add -g.
2957
2958 2010-12-29  Kent Hansen  <kent.hansen@nokia.com>
2959
2960         Reviewed by Simon Hausmann.
2961
2962         [Qt] Fix compilation with Qt in namespace
2963         https://bugs.webkit.org/show_bug.cgi?id=51701
2964
2965         * QtTestBrowser/webview.h:
2966
2967 2010-12-28  Daniel Bates  <dbates@rim.com>
2968
2969         Reviewed by Sam Weinig.
2970
2971         Substitute // MARK: for compiler-specific #pragma mark
2972         https://bugs.webkit.org/show_bug.cgi?id=51657
2973
2974         Fix future compilation warnings about "#pragma mark" on GTK+ bots by
2975         substituting  "// MARK:" for "#pragma mark", which provides
2976         analogous code-bookmarking functionality under Xcode.
2977
2978         Also, for consistency, we should substitute "// MARK:" for compiler-
2979         specific "#pragma mark" in the source files for the Mac port.
2980
2981         * DumpRenderTree/AccessibilityTextMarker.cpp:
2982         * DumpRenderTree/cf/WebArchiveDumpSupport.h:
2983         * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm:
2984         * DumpRenderTree/mac/ObjCController.m:
2985         * MiniBrowser/mac/AppDelegate.m:
2986         * MiniBrowser/mac/BrowserWindowController.m:
2987
2988 2010-12-28  Xan Lopez  <xlopez@igalia.com>
2989
2990         Reviewed by Eric Seidel.
2991
2992         Add --no-build option to run-sunspider
2993         https://bugs.webkit.org/show_bug.cgi?id=51658
2994
2995         * Scripts/run-sunspider: add --no-build flag to skip building
2996         phase.
2997
2998 2010-12-27  Daniel Bates  <dbates@rim.com>
2999
3000         Rubber-stamped by Martin Robinson.
3001
3002         Append the directory Tools/DumpRenderTree to the list of directories that
3003         do-webcore-rename should search so that it can rename DRT files and
3004         source code.
3005
3006         * Scripts/do-webcore-rename:
3007
3008 2010-12-27  Eric Seidel  <eric@webkit.org>
3009
3010         Reviewed by Adam Barth.
3011
3012         build-webkit should detect missing Java SDK and explain how to install it
3013         https://bugs.webkit.org/show_bug.cgi?id=51651
3014
3015         * Scripts/build-webkit:
3016
3017 2010-12-26  Martin Robinson  <mrobinson@igalia.com>
3018
3019         Reviewed by Daniel Bates.
3020
3021         [GTK] Add support for build-jsc
3022         https://bugs.webkit.org/show_bug.cgi?id=51625
3023
3024         Add GTK+ support to build-jsc now that building the jsc executable as
3025         a standalone target is easy.
3026
3027         * Scripts/build-jsc: Call buildGtkProject for the GTK+ case now.
3028         * Scripts/build-webkit: Pass in the proper target name to buildGtkProject.
3029         * Scripts/webkitdirs.pm: Actually process the project parameter in buildGtkProject
3030         and pass it along to buildAutotoolsProject.
3031
3032 2010-12-27  David Levin  <levin@chromium.org>
3033
3034         Reviewed by Eric Seidel.
3035
3036         check-webkit-style check for meaningless variable names in function declarations.
3037         https://bugs.webkit.org/show_bug.cgi?id=51523
3038
3039         * Scripts/webkitpy/style/checker.py: Exempted JavaScriptCore/jit/JITStubs.cpp
3040         from the new check and whitespace/parens because the syntax is unusual and
3041         produced a fair number of positives for these checks.
3042         * Scripts/webkitpy/style/checkers/cpp.py:
3043         (_convert_to_lower_with_underscores): Used as a canonical form for type names
3044         and parameter names when determining if the parameter name is useless.
3045         (_create_acronym): Used to check for redundant variable names in cases like "ExceptionCode ec"
3046         (Parameter.lower_with_underscores_name): Gives back the parameter name in a lower_with_underscore
3047         format.
3048         (_check_parameter_name_against_text):  Checks to see if the parameter name is in the
3049         text or an acronym of it.
3050         (check_function_definition): Checks function definitions for meaningless variable names.
3051         (process_line): Added call to check_function_definition.
3052         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3053         (CppFunctionsTest.test_convert_to_lower_with_underscores): Test for _convert_to_lower_with_underscores.
3054         (CppFunctionsTest.test_create_acronym): Test for _create_acronym.
3055         (CppFunctionsTest.test_check_parameter_against_text): Test for _check_parameter_against_text.
3056         (CppStyleTestBase.perform_single_line_lint): Removed the parameter name check
3057         because when only checking a snippet, there are a lot of bogus functions.
3058         (CppStyleTestBase.perform_multi_line_lint): Ditto and removed a bogus filter
3059         that I put there previously and just noticed.
3060         (WebKitStyleTest.test_parameter_names): Tests for the functionality -- both
3061         check_function_definition and process_line.
3062
3063 2010-12-27  Carlos Garcia Campos  <cgarcia@igalia.com>
3064
3065         Reviewed by Martin Robinson.
3066
3067         [GTK] Disable flash plugin in GtkLauncher when using gtk3
3068         https://bugs.webkit.org/show_bug.cgi?id=51591
3069
3070         Flash plugin uses gtk2 that is incompatible with gtk3 making
3071         webkit crash when it's built with gtk3.
3072
3073         * GtkLauncher/main.c:
3074         (main):
3075
3076 2010-12-25  Adam Barth  <abarth@webkit.org>
3077
3078         Reviewed by Eric Seidel.
3079
3080         Move ANGLE to Sources/ThirdParty
3081         https://bugs.webkit.org/show_bug.cgi?id=51605
3082
3083         * Scripts/build-webkit:
3084           - Point to the new ANGLE location.
3085
3086 2010-12-26  David Levin  <levin@chromium.org>
3087
3088         Reviewed by Eric Seidel.
3089
3090         check-webkit-style should be able to parse function declaration parameters.
3091         https://bugs.webkit.org/show_bug.cgi?id=51451
3092
3093         * Scripts/webkitpy/style/checkers/cpp.py:
3094         (Position.__init__): Holds simple position information (row, column).
3095         (Parameter.__init__): Holds information about a parameter.
3096         (SingleLineView.__init): Converts multiple lines into a single line for simpler searches.
3097         (SingleLineView.convert_column_to_row): Returns the original row given a column.
3098         (create_skeleton_parameters): Simplifies a parameter list for easier searching.
3099         (find_parameter_name_index): Finds where the parameter name is.
3100         (parameter_list): Generates the list of parameters for a function.
3101         (_FunctionState.begin): Added information to allow determining the parameters
3102         on demand.
3103         (_FunctionState.get_parameter_list): Returns a tuple of function parameters.
3104         (detect_functions): Improve function detection for operator functions and
3105         determine where the parameters end and pass that to _FunctionState.begin.
3106         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3107         (CppFunctionsTest.test_parameter): Verifies Parameter functionality.
3108         (CppFunctionsTest.test_single_line_view): Verifies SingleLineView functionality.
3109         (CppFunctionsTest.test_create_skeleton_parameters): Verifies create_skeleton_parameters.
3110         (CppFunctionsTest.test_find_parameter_name_index): Verifies find_parameter_name_index.
3111         (CppFunctionsTest.test_parameter_list): Does some minimal verification for parameter list.
3112         Much more thorough verification is done as part of FunctionDetectionTest.test_parameter_list.
3113         (FunctionDetectionTest.perform_function_detection): Added support for verifying
3114         the parameters found.
3115         (FunctionDetectionTest.test_function_declaration_detection): Added more function
3116         detection test to verify that we catch the operator functions.
3117         (FunctionDetectionTest.test_ignore_macros): Verify that function detection ignores macros.
3118         (FunctionDetectionTest.test_parameter_list): Added tests to verify the parameter parsing.
3119         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_bad_test_doesnt_break): Removed
3120         because the error. The test is about the bad function name. Fixing the name makes the test exactly like
3121         test_function_length_check_definition_severity1_for_test.
3122
3123 2010-12-25  Patrick Gansterer  <paroga@webkit.org>
3124
3125         Unreviewed WinCE buildfix after r74334.
3126
3127         * CMakeListsWinCE.txt:
3128
3129 2010-12-24  Sheriff Bot  <webkit.review.bot@gmail.com>
3130
3131         Unreviewed, rolling out r74632.
3132         http://trac.webkit.org/changeset/74632
3133         https://bugs.webkit.org/show_bug.cgi?id=51600
3134
3135         makes test-webkitpy hang forever on GTK (Requested by philn-tp
3136         on #webkit).
3137
3138         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
3139         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
3140
3141 2010-12-24  Ryuan Choi  <ryuan.choi@samsung.com>
3142
3143         Reviewed by Kenneth Rohde Christiansen.
3144
3145         [EFL] Screen doesn't be rendered when changing size of EWebLauncher
3146         https://bugs.webkit.org/show_bug.cgi?id=43528
3147
3148         Remove on_resize because ewk_view_fixed_layout_size_set should not be
3149         called on callback of EVAS_CALLBACK_RESIZE. As it change size of
3150         FrameView, rendering was ignored when _ewk_view_smart_calculate was
3151         called.
3152
3153         * EWebLauncher/main.c:
3154         (browserCreate):
3155
3156 2010-12-24  Eric Seidel  <eric@webkit.org>
3157
3158         Reviewed by Adam Barth.
3159
3160         webkit-patch (or a pre-commit hook) needs to prevent bad ChangeLog changes
3161         https://bugs.webkit.org/show_bug.cgi?id=28291
3162
3163         This is a start.  At least now webkit-patch will prompt when your ChangeLog looks questionable.
3164         We could do more advanced things, like parsing the ChangeLog (with changelog.py) and comparing that
3165         to strings with find in the diff.
3166         Since non-interactive always returns the default, this should cause patches with bad changelogs to fail on the commit-queue.
3167
3168         * Scripts/webkitpy/common/checkout/api.py:
3169         * Scripts/webkitpy/common/checkout/diff_parser.py:
3170         * Scripts/webkitpy/tool/steps/abstractstep.py:
3171         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
3172         * Scripts/webkitpy/tool/steps/validatechangelogs.py: Copied from Tools/Scripts/webkitpy/tool/steps/validatereviewer.py.
3173         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py: Copied from Tools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.
3174         * Scripts/webkitpy/tool/steps/validatereviewer.py:
3175
3176 2010-12-24  Dirk Pranke  <dpranke@chromium.org>
3177
3178         Reviewed by Kenneth Russell.
3179
3180         Modify new-run-webkit-tests to shut up and exit when all the threads
3181         are wedged so that test runs complete faster and we don't end up
3182         w/ enormous log files.
3183
3184         https://bugs.webkit.org/show_bug.cgi?id=51572
3185
3186         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
3187         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
3188
3189 2010-12-24  Eric Seidel  <eric@webkit.org>
3190
3191         Reviewed by David Levin.
3192
3193         commit-queue should better explain how it will re-open bugs and follow duplicate chains
3194         https://bugs.webkit.org/show_bug.cgi?id=51549
3195
3196         I've had multiple people ask me about the commit-queue's behavior
3197         regarding reporting flaky tests.  I figured it would be best to just
3198         have the queue explain itself in the bugs it files.
3199
3200         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3201         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3202
3203 2010-12-24  Shinichiro Hamaji  <hamaji@chromium.org>
3204
3205         Reviewed by Eric Seidel.
3206
3207         check-webkit-style: should ignore "wrong" namings in JavaScriptCore/qt
3208         https://bugs.webkit.org/show_bug.cgi?id=51467
3209
3210         * Scripts/webkitpy/style/checker.py:
3211         * Scripts/webkitpy/style/checker_unittest.py:
3212
3213 2010-12-23  Adam Barth  <abarth@webkit.org>
3214
3215         Rubber-stamped by Eric Seidel.
3216
3217         Move JavaScriptGlue into Sources
3218         https://bugs.webkit.org/show_bug.cgi?id=51583
3219
3220         These tools refer to JavaScriptGlue and need to be updated to its new
3221         location.
3222
3223         * Scripts/build-webkit:
3224         * Scripts/do-file-rename:
3225         * Scripts/do-webcore-rename:
3226         * Scripts/webkitpy/common/config/build.py:
3227         * Scripts/webkitpy/common/config/build_unittest.py:
3228
3229 2010-12-23  Lucas Forschler  <lforschler@apple.com>
3230
3231         Reviewed by Eric Seidel.
3232
3233         Bug 51539 - update iexploder scripts to point to new location
3234
3235         * Scripts/run-iexploder-tests:
3236         * Scripts/update-iexploder-cssproperties:
3237
3238 2010-12-23  Evan Martin  <evan@chromium.org>
3239
3240         Reviewed by Ryosuke Niwa.
3241
3242         [chromium] LayoutTestController warning in float->int conversion
3243         https://bugs.webkit.org/show_bug.cgi?id=51553
3244
3245         Rather than reading an int, converting to a float, then getting a compiler
3246         warning on passing the float to something that expects an int, instead
3247         just pass around ints.
3248
3249         No tests, fixes a compiler warning.
3250
3251         * DumpRenderTree/chromium/LayoutTestController.cpp:
3252         (parsePageSizeParameters):
3253         (LayoutTestController::pageNumberForElementById):
3254         (LayoutTestController::numberOfPages):
3255
3256 2010-12-23  Lucas Forschler  <lforschler@apple.com>
3257
3258         Reviewed by Darin Adler.
3259
3260         Bug 51537 - iexploder needs cleanup
3261         
3262         * iExploder/htdocs: Removed.
3263         * iExploder/htdocs/config.rb: Removed.
3264         * iExploder/htdocs/cssproperties.in: Removed.
3265         * iExploder/htdocs/cssvalues.in: Removed.
3266         * iExploder/htdocs/htmlattrs.in: Removed.
3267         * iExploder/htdocs/htmltags.in: Removed.
3268         * iExploder/htdocs/htmlvalues.in: Removed.
3269         * iExploder/htdocs/iexploder.cgi: Removed.
3270         * iExploder/htdocs/iexploder.rb: Removed.
3271         * iExploder/htdocs/index.html: Removed.
3272         * iExploder/htdocs/webserver.rb: Removed.
3273         * iExploder/iexploder-1.7.2/output: Removed.
3274         * iExploder/tools: Removed.
3275         * iExploder/tools/lasthit.rb: Removed.
3276         * iExploder/tools/osx_last_crash.rb: Removed.
3277         * iExploder/tools/showtest.rb: Removed.
3278
3279 2010-12-23  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
3280
3281         Reviewed by Kenneth Rohde Christiansen.
3282
3283         [EFL] Make 'single' the default backing store in EWebLauncher
3284         https://bugs.webkit.org/show_bug.cgi?id=51534
3285
3286         'single' is the simplest backing store and the one intended to be the
3287         default in the test browser. By mistake the tiled backing store was
3288         left as default in r72617.
3289
3290         * EWebLauncher/main.c:
3291         (browserCreate): ditto.
3292
3293 2010-12-23  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
3294
3295         Reviewed by Kenneth Rohde Christiansen.
3296
3297         [EFL] Subject: [webkit 4/4] [EFL] Remove non-sense workaround
3298         https://bugs.webkit.org/show_bug.cgi?id=51533
3299
3300         There's no point in concatenating env("HOME") with "blah", so remove
3301         option from EWebLauncher.
3302
3303         * EWebLauncher/main.c:
3304         (main): ditto.
3305
3306 2010-12-23  Ilya Tikhonovsky  <loislo@chromium.org>
3307
3308         Reviewed by Eric Seidel.
3309
3310         Web Inspector: chromium: inspector's tests are quite slow especially at windows(Debug).
3311
3312         Almost all inspector's tests become flaky on chromium Win(dbg) after switching to DRT.
3313         I just discovered that we have two additional GC runs per each WebViewHost.
3314         Test_shell had no such calls.
3315         These gc runs eat 15% of cpu time.
3316
3317         https://bugs.webkit.org/show_bug.cgi?id=51479
3318
3319         * DumpRenderTree/chromium/WebViewHost.cpp:
3320         (WebViewHost::~WebViewHost):
3321
3322 2010-12-22  Dirk Pranke  <dpranke@chromium.org>
3323
3324         Reviewed by Ojan Vafai.
3325
3326         This change splits out the TestRunner class into its own file.
3327         When we fork the code for message passing, we will create a new
3328         TestRunner, and this change will allow that to be more modular.
3329
3330         While we're at it, split out TestInput and ResultSummary into
3331         their own files, to reduce the size of run_webkit_tests to
3332         something more managable.
3333
3334         https://bugs.webkit.org/show_bug.cgi?id=51092
3335
3336         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
3337         * Scripts/webkitpy/layout_tests/layout_package/result_summary.py:
3338         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
3339         * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
3340         * Scripts/webkitpy/layout_tests/layout_package/test_input.py:
3341         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3342         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3343
3344  2010-12-22  Dirk Pranke  <dpranke@chromium.org>
3345
3346         Reviewed by Ojan Vafai.
3347
3348         nrwt multiprocessing - start over, prepare to fork the code
3349  
3350         This code cleans up the signatures and implementation of the
3351         TestRunner class so we can easily fork it to run either the
3352         stable implementation or the new, unstable message-passing
3353         implementation. The two variants will have different
3354         implementations of the run_tests() method. We will switch
3355         between the two based on the setting for the '--worker-model'
3356         switch. We rename the two currently valid values to 'old-inline'
3357         and 'old-threads'.
3358
3359         https://bugs.webkit.org/show_bug.cgi?id=51081
3360
3361         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3362         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3363
3364 2010-12-22  Victor Wang  <victorw@chromium.org>
3365
3366         Reviewed by Darin Fisher.
3367
3368         [Chromium] Update chromium archive test result url in rebaseline script.
3369
3370         https://bugs.webkit.org/show_bug.cgi?id=51503
3371
3372         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
3373
3374 2010-12-22  Lucas Forschler  <lforschler@apple.com>
3375
3376         Reviewed by Alice Liu.
3377
3378         <rdar://problem/8633222> record-memory-win needs to record memory used by the webprocess.
3379         Verified on Chrome, Safari, and IE.
3380         With this change, we will record memory from a parent browser window and all child processes.
3381
3382         * record-memory-win/main.cpp:
3383         (ProcessArgs):
3384         (PrintUsage):
3385         (getMemoryInfo):
3386         (printProcessInfo):
3387         (evalProcesses):
3388         (UseImage):
3389         (QueryContinuously):
3390         (ElapsedTime):
3391
3392 2010-12-22  Lucas Forschler  <lforschler@apple.com>
3393
3394         Unreviewed rollout r74489, because it was missing changelog.
3395
3396         * record-memory-win/main.cpp:
3397         
3398 2010-12-22  Ryosuke Niwa  <rniwa@webkit.org>
3399
3400         Adding myself as a reviewer.
3401
3402         * Scripts/webkitpy/common/config/committers.py:
3403
3404 2010-12-22  Andrew Scherkus  <scherkus@chromium.org>
3405
3406         Unreviewed.  Adding myself to committers.py.
3407
3408         * Scripts/webkitpy/common/config/committers.py:
3409
3410 2010-12-22  Ariya Hidayat  <ariya@sencha.com>
3411
3412         Reviewed by Kenneth Rohde Christiansen.
3413
3414         TestNetscapePlugIn should use #if defined
3415         https://bugs.webkit.org/show_bug.cgi?id=51471
3416
3417         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3418         (NP_Initialize):
3419         (NPP_New):
3420
3421 2010-12-22  Ilya Tikhonovsky  <loislo@chromium.org>
3422
3423         Reviewed by Yury Semikhatsky.
3424
3425         Web Inspector: [chromium] DRT inspector layout tests are flaky in debug.
3426
3427         DevTools window should be closed explicitly because it has custom deinitialization code.
3428
3429         https://bugs.webkit.org/show_bug.cgi?id=50722
3430
3431         * DumpRenderTree/chromium/TestShell.cpp:
3432         (TestShell::closeRemainingWindows):
3433
3434 2010-12-22  David Levin  <levin@chromium.org>
3435
3436         Reviewed by Shinichiro Hamaji.
3437
3438         check-webkit-style shouldn't complaint about underscores in variables in objective C files.
3439         https://bugs.webkit.org/show_bug.cgi?id=51452
3440
3441         * Scripts/webkitpy/style/checkers/cpp.py:
3442         (_FileState.__init__): Added the information to determine if a file is C or Objective C.
3443         Using the file extension if possible but falling back to the file contents if we have a header file.
3444         (_FileState.is_objective_c): Determine if we have an Objective C by examining the file contents if needed.
3445         (_FileState.is_c_or_objective_c):
3446         (check_using_std): Changed to using _FileState to determine the file type.
3447         (check_max_min_macros): Ditto.
3448         (check_for_null): Ditto.
3449         (check_style): Changed the parameters to various calls since they now need _FileState
3450         to determine the file type.
3451         (check_language): Added the file_state parameter so it could be passed
3452         to check_identifier_name_in_declaration.
3453         (check_identifier_name_in_declaration): Don't warn about underscores in variables if
3454         this is an Objective C file.
3455         (_process_lines): Added information for the _FileState constructor (and moved the
3456         call to a place that had the information).
3457         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3458         (CppFunctionsTest.test_is_c_or_objective_c): Changed the tests to use FileState and exercise
3459         its functionality.
3460         (WebKitStyleTest.test_names): Add tests for underscores in Objective C files.
3461
3462 2010-12-21  Andy Estes  <aestes@apple.com>
3463
3464         Reviewed by Mark Rowe.
3465
3466         Do not build non-Intel architectures for WebKit2-related projects.
3467         https://bugs.webkit.org/show_bug.cgi?id=51440
3468
3469         * MiniBrowser/Configurations/Base.xcconfig: Only build for i386 and x86_64.
3470         * TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
3471         * WebKitTestRunner/Configurations/Base.xcconfig: Ditto.
3472
3473 2010-12-21  Mihai Parparita  <mihaip@chromium.org>
3474
3475         Reviewed by Darin Fisher.
3476
3477         [Chromium] Rename WebThemeEngine/ControlDRT to WebThemeEngine/ControlDRTWin
3478         https://bugs.webkit.org/show_bug.cgi?id=51406 
3479         
3480         Rename WebThemeControlDRT to WebThemeControlDRTWin and WebThemeEngineDRT
3481         to WebThemeEngineDRTWin and update references everywhere.
3482
3483         * DumpRenderTree/DumpRenderTree.gypi:
3484         * DumpRenderTree/chromium/TestShellWin.cpp:
3485         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRT.cpp.
3486         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRT.h.
3487         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRT.cpp.
3488         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRT.h.
3489
3490 2010-12-21  Anders Carlsson  <andersca@apple.com>
3491
3492         Reviewed by John Sullivan.
3493
3494         Clicking missing plug-in text does not show a sheet
3495         https://bugs.webkit.org/show_bug.cgi?id=51403
3496
3497         Update for changes to the WebPageUIClient.
3498
3499         * MiniBrowser/mac/BrowserWindowController.m:
3500         (-[BrowserWindowController awakeFromNib]):
3501         * WebKitTestRunner/TestController.cpp:
3502         (WTR::createOtherPage):
3503         (WTR::TestController::initialize):
3504
3505 2010-12-21  Eric Seidel  <eric@webkit.org>
3506
3507         Reviewed by Adam Barth.
3508
3509         commit-queue will report constant failures as flaky if other tests flake
3510         https://bugs.webkit.org/show_bug.cgi?id=51272
3511
3512         This patch just removes functionality and adds testing.
3513         Previously we attempted to report flaky tests when we had
3514         two different tests fail in a row.  However, since we stop
3515         running the tests at the first failure, our code was wrong in
3516         trying to determine flakiness from the incomplete runs.
3517
3518         Originally I posted an alternate patch:
3519         https://bug-51272-attachments.webkit.org/attachment.cgi?id=77078
3520         which fixed our flaky logic in this case, however it was decided
3521         that that patch would be too difficult to maintain, so now
3522         I'm just removing the broken logic.
3523
3524         This will dramatically cut-down on our flaky-test false positives
3525         at the (small) cost of the queues being unable to report
3526         any flakiness if the tree is very flaky.  (With at least one test
3527         flaking on every run, we'll never report failures anymore.)  I think
3528         this is a tradeoff worth making.
3529
3530         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3531         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3532
3533 2010-12-20  Eric Seidel  <eric@webkit.org>
3534
3535         Reviewed by Adam Barth.
3536
3537         commit-queue wrongly rejects patches when it can't update itself
3538         https://bugs.webkit.org/show_bug.cgi?id=46636
3539
3540         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3541         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3542         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3543
3544 2010-12-20  Adam Barth  <abarth@webkit.org>
3545
3546         Move web sites to Websites directory
3547         https://bugs.webkit.org/show_bug.cgi?id=51323
3548
3549         Update references to BugsSite to point to the new location.
3550
3551         This patch was never officially reviewed (because it was too large to
3552         upload to bugs.webkit.org), but it was discussed on webkit-dev and Mark
3553         Rowe gave me the green light.
3554
3555         * Scripts/old-run-webkit-tests:
3556         * Scripts/webkitpy/common/config/build.py:
3557         * Scripts/webkitpy/common/config/build_unittest.py:
3558         * Scripts/webkitpy/common/prettypatch.py:
3559         * Scripts/webkitpy/layout_tests/port/base.py:
3560         * Scripts/webkitpy/style/main.py:
3561
3562 2010-12-20  Adrienne Walker  <enne@google.com>
3563
3564         Unreviewed. Adding myself to the list of committers.
3565
3566         * webkitpy/common/config/committers.py:
3567
3568 2010-12-20  Mark Rowe  <mrowe@apple.com>
3569
3570         Reviewed by Dan Bernstein.
3571
3572         <rdar://problem/8757601> Don't install header files in to the Resources directory.
3573
3574         * Scripts/check-for-inappropriate-files-in-framework: Don't allow .h files in the
3575         Resources directory.
3576
3577 2010-12-20  Eric Seidel  <eric@webkit.org>
3578
3579         Reviewed by Adam Barth.
3580
3581         commit-queue should include bot id when attaching failure diffs
3582         https://bugs.webkit.org/show_bug.cgi?id=51280
3583
3584         This is a tiny change to include the bot id in the name of the attachment.
3585         Most of this diff is just changing the unit test expectations
3586         now that I hid the comment printing when the comment is None.
3587
3588         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3589         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3590         * Scripts/webkitpy/tool/commands/upload_unittest.py:
3591         * Scripts/webkitpy/tool/mocktool.py:
3592
3593 2010-12-20  Jeff Miller  <jeffm@apple.com>
3594
3595         Reviewed by Dan Bernstein.
3596
3597         Tools/vcbin/midl.exe needs to be rebuilt
3598         https://bugs.webkit.org/show_bug.cgi?id=51347
3599
3600         * vcbin/midl.exe: Rebuilt.
3601
3602 2010-12-20  David Levin  <levin@chromium.org>
3603
3604         Reviewed by Ariya Hidayat.
3605
3606         .gitignore and webkit-tools-completion.sh have references to WebKitTools that should be Tools.
3607         https://bugs.webkit.org/show_bug.cgi?id=51343
3608
3609         Follow up from the WebKitTools -> Tools rename.
3610
3611         * Scripts/webkit-tools-completion.sh:
3612
3613 2010-12-20  Cosmin Truta  <ctruta@chromium.org>
3614
3615         Reviewed by James Robinson.
3616
3617         new-run-webkit-tests ignores trailing EOL differences in text tests
3618         https://bugs.webkit.org/show_bug.cgi?id=36983
3619
3620         Changed the handling of new-line characters within new-run-webkit-tests
3621         to match old-run-webkit-tests.  Differences in leading and trailing empty
3622         lines in text expectation files are no longer ignored.
3623
3624         * Scripts/webkitpy/layout_tests/port/base.py:
3625         * Scripts/webkitpy/layout_tests/port/test.py:
3626         Added unit tests.  Removed old duplicate unit test entries.
3627         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
3628
3629 2010-12-20  David Levin  <levin@chromium.org>
3630
3631         Reviewed by Shinichiro Hamaji.
3632
3633         check-webkit-style should detect function declarations (and trivial functions).
3634         https://bugs.webkit.org/show_bug.cgi?id=51303
3635
3636         * Scripts/webkitpy/style/checkers/cpp.py:
3637         (_FunctionState.begin): Add is_declaration and changed the line count
3638         start to begin at -1 (which will keep the results consistent, since
3639         the starting line number passed in is one less in this change).
3640         (detect_functions): changed function detection to now catch trivial
3641         functions and declarations.
3642         (check_pass_ptr_usage): Don't check for Pass*Ptr on the first line
3643         of the function as this may look at return values (when processing
3644         a declaration).
3645         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3646         (FunctionDetectionTest.perform_function_detection): Basic mechanics
3647         of testing the function detection.
3648         (FunctionDetectionTest.test_basic_function_detection): Test a simple
3649         function.
3650         (FunctionDetectionTest.test_function_declaration_detection): Test a
3651         declaration.
3652         (FunctionDetectionTest.test_non_functions): A test case for a case
3653         that caused the code to fail due to the { being in quotes.
3654         (PassPtrTest.test_pass_ref_ptr_return_value): Added some more test
3655         cases to help catch false alarms for return values.
3656         (PassPtrTest.test_pass_ref_ptr_member_variable): Ensure that
3657         we don't get false alarms for member variables either.
3658
3659 2010-12-20  Ryuan Choi  <ryuan.choi@samsung.com>
3660
3661         Reviewed by Antonio Gomes.
3662
3663         [CMAKE] Rename WEBKITTOOLS_DIR to TOOLS_DIR
3664         https://bugs.webkit.org/show_bug.cgi?id=51319
3665
3666         * CMakeListsEfl.txt:
3667
3668 2010-12-18  Adam Barth  <abarth@webkit.org>
3669
3670         Reviewed by Sam Weinig.
3671
3672         Move WebKitExamplePlugins to Examples
3673         https://bugs.webkit.org/show_bug.cgi?id=51291
3674
3675         * Scripts/webkitpy/common/config/build.py:
3676
3677 2010-12-17  Csaba Osztrogonác  <ossy@webkit.org>
3678
3679         Unreviewed Qt buildfix after r74301.
3680
3681         Rename WebKitTools to Tools
3682         https://bugs.webkit.org/show_bug.cgi?id=49861
3683
3684         * MiniBrowser/DerivedSources.pro:
3685         * MiniBrowser/qt/MiniBrowser.pro:
3686
3687 2010-12-17  Dan Bernstein  <mitz@apple.com>
3688
3689         Reviewed by Simon Fraser.
3690
3691         Rename WebKitTools to Tools
3692         https://bugs.webkit.org/show_bug.cgi?id=49861
3693
3694         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3695         * CodeCoverage/README:
3696         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3697         (WebCore::DumpRenderTree::initializeFonts):
3698         * EWSTools/start-commit-queue.sh:
3699         * EWSTools/start-queue.sh:
3700         * GNUmakefile.am:
3701         * MIDLWrapper/MIDLWrapper.cpp:
3702         (wmain):
3703         * MiniBrowser/qt/MiniBrowser.pro:
3704         * Scripts/build-api-tests:
3705         * Scripts/build-dumprendertree:
3706         * Scripts/build-webkit:
3707         * Scripts/build-webkittestrunner:
3708         * Scripts/generate-coverage-data:
3709         * Scripts/old-run-webkit-tests:
3710         * Scripts/run-api-tests:
3711         * Scripts/run-iexploder-tests:
3712         * Scripts/run-javascriptcore-tests:
3713         * Scripts/run-mangleme-tests:
3714         * Scripts/run-sunspider:
3715         * Scripts/run-webkit-websocketserver:
3716         * Scripts/sunspider-compare-results:
3717         * Scripts/test-webkitperl:
3718         * Scripts/test-webkitpy:
3719         * Scripts/update-iexploder-cssproperties:
3720         * Scripts/update-webkit:
3721         * Scripts/update-webkit-localizable-strings:
3722         * Scripts/webkitdirs.pm:
3723         * Scripts/webkitpy/common/checkout/scm.py:
3724         * Scripts/webkitpy/common/checkout/scm_unittest.py:
3725         * Scripts/webkitpy/common/config/committervalidator.py:
3726         * Scripts/webkitpy/common/config/committervalidator_unittest.py:
3727         * Scripts/webkitpy/common/config/ports.py:
3728         * Scripts/webkitpy/common/config/ports_unittest.py:
3729         * Scripts/webkitpy/common/system/logutils_unittest.py:
3730         * Scripts/webkitpy/common/system/ospath_unittest.py:
3731         * Scripts/webkitpy/layout_tests/port/chromium.py:
3732         * Scripts/webkitpy/layout_tests/port/config.py:
3733         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
3734         * Scripts/webkitpy/layout_tests/port/http_server.py:
3735         * Scripts/webkitpy/layout_tests/port/test.py:
3736         * Scripts/webkitpy/style/checker.py:
3737         * Scripts/webkitpy/style/checker_unittest.py:
3738         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
3739         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3740         * Scripts/webkitpy/tool/steps/steps_unittest.py:
3741         * WebKitTestRunner/DerivedSources.pro:
3742         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
3743         (WTR::activateFonts):
3744         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3745         * wx/build/build_utils.py:
3746
3747 2010-12-16  Antonio Gomes  <agomes@rim.com>
3748
3749         Reviewed by Martin Robinson.
3750
3751         Settings::editingBehaviorType() incorrectly returns mac for the gtk build when running tests
3752         https://bugs.webkit.org/show_bug.cgi?id=51163
3753
3754         Since GTK+'s default editing behavior was changed to UNIX in r70975 (see webkitwebsettings.cpp),
3755         GTK+'s DRT should also reset to UNIX after each test execution.
3756
3757         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3758         (resetDefaultsToConsistentValues):
3759
3760 2010-12-17  David Levin  <levin@chromium.org>
3761
3762         Reviewed by Eric Seidel.
3763
3764         check-webkit-style should understand WTF #include guards
3765         https://bugs.webkit.org/show_bug.cgi?id=44911
3766
3767         * Scripts/webkitpy/style/checkers/cpp.py:
3768         (get_header_guard_cpp_variable): modify to suggest the WTF style
3769         of header guard when appropriate.
3770         (check_for_header_guard): handle multiple return values from
3771         get_header_gua