* WebProcess/WebPage/WebPage.cpp: Add #if to try to fix non-Mac builds.
[WebKit.git] / Tools / ChangeLog
1 2010-12-22  Victor Wang  <victorw@chromium.org>
2
3         Reviewed by Darin Fisher.
4
5         [Chromium] Update chromium archive test result url in rebaseline script.
6
7         https://bugs.webkit.org/show_bug.cgi?id=51503
8
9         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
10
11 2010-12-22  Lucas Forschler  <lforschler@apple.com>
12
13         Reviewed by Alice Liu.
14
15         <rdar://problem/8633222> record-memory-win needs to record memory used by the webprocess.
16         Verified on Chrome, Safari, and IE.
17         With this change, we will record memory from a parent browser window and all child processes.
18
19         * record-memory-win/main.cpp:
20         (ProcessArgs):
21         (PrintUsage):
22         (getMemoryInfo):
23         (printProcessInfo):
24         (evalProcesses):
25         (UseImage):
26         (QueryContinuously):
27         (ElapsedTime):
28
29 2010-12-22  Lucas Forschler  <lforschler@apple.com>
30
31         Unreviewed rollout r74489, because it was missing changelog.
32
33         * record-memory-win/main.cpp:
34         
35 2010-12-22  Ryosuke Niwa  <rniwa@webkit.org>
36
37         Adding myself as a reviewer.
38
39         * Scripts/webkitpy/common/config/committers.py:
40
41 2010-12-22  Andrew Scherkus  <scherkus@chromium.org>
42
43         Unreviewed.  Adding myself to committers.py.
44
45         * Scripts/webkitpy/common/config/committers.py:
46
47 2010-12-22  Ariya Hidayat  <ariya@sencha.com>
48
49         Reviewed by Kenneth Rohde Christiansen.
50
51         TestNetscapePlugIn should use #if defined
52         https://bugs.webkit.org/show_bug.cgi?id=51471
53
54         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
55         (NP_Initialize):
56         (NPP_New):
57
58 2010-12-22  Ilya Tikhonovsky  <loislo@chromium.org>
59
60         Reviewed by Yury Semikhatsky.
61
62         Web Inspector: [chromium] DRT inspector layout tests are flaky in debug.
63
64         DevTools window should be closed explicitly because it has custom deinitialization code.
65
66         https://bugs.webkit.org/show_bug.cgi?id=50722
67
68         * DumpRenderTree/chromium/TestShell.cpp:
69         (TestShell::closeRemainingWindows):
70
71 2010-12-22  David Levin  <levin@chromium.org>
72
73         Reviewed by Shinichiro Hamaji.
74
75         check-webkit-style shouldn't complaint about underscores in variables in objective C files.
76         https://bugs.webkit.org/show_bug.cgi?id=51452
77
78         * Scripts/webkitpy/style/checkers/cpp.py:
79         (_FileState.__init__): Added the information to determine if a file is C or Objective C.
80         Using the file extension if possible but falling back to the file contents if we have a header file.
81         (_FileState.is_objective_c): Determine if we have an Objective C by examining the file contents if needed.
82         (_FileState.is_c_or_objective_c):
83         (check_using_std): Changed to using _FileState to determine the file type.
84         (check_max_min_macros): Ditto.
85         (check_for_null): Ditto.
86         (check_style): Changed the parameters to various calls since they now need _FileState
87         to determine the file type.
88         (check_language): Added the file_state parameter so it could be passed
89         to check_identifier_name_in_declaration.
90         (check_identifier_name_in_declaration): Don't warn about underscores in variables if
91         this is an Objective C file.
92         (_process_lines): Added information for the _FileState constructor (and moved the
93         call to a place that had the information).
94         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
95         (CppFunctionsTest.test_is_c_or_objective_c): Changed the tests to use FileState and exercise
96         its functionality.
97         (WebKitStyleTest.test_names): Add tests for underscores in Objective C files.
98
99 2010-12-21  Andy Estes  <aestes@apple.com>
100
101         Reviewed by Mark Rowe.
102
103         Do not build non-Intel architectures for WebKit2-related projects.
104         https://bugs.webkit.org/show_bug.cgi?id=51440
105
106         * MiniBrowser/Configurations/Base.xcconfig: Only build for i386 and x86_64.
107         * TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
108         * WebKitTestRunner/Configurations/Base.xcconfig: Ditto.
109
110 2010-12-21  Mihai Parparita  <mihaip@chromium.org>
111
112         Reviewed by Darin Fisher.
113
114         [Chromium] Rename WebThemeEngine/ControlDRT to WebThemeEngine/ControlDRTWin
115         https://bugs.webkit.org/show_bug.cgi?id=51406 
116         
117         Rename WebThemeControlDRT to WebThemeControlDRTWin and WebThemeEngineDRT
118         to WebThemeEngineDRTWin and update references everywhere.
119
120         * DumpRenderTree/DumpRenderTree.gypi:
121         * DumpRenderTree/chromium/TestShellWin.cpp:
122         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRT.cpp.
123         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRT.h.
124         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRT.cpp.
125         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRT.h.
126
127 2010-12-21  Anders Carlsson  <andersca@apple.com>
128
129         Reviewed by John Sullivan.
130
131         Clicking missing plug-in text does not show a sheet
132         https://bugs.webkit.org/show_bug.cgi?id=51403
133
134         Update for changes to the WebPageUIClient.
135
136         * MiniBrowser/mac/BrowserWindowController.m:
137         (-[BrowserWindowController awakeFromNib]):
138         * WebKitTestRunner/TestController.cpp:
139         (WTR::createOtherPage):
140         (WTR::TestController::initialize):
141
142 2010-12-21  Eric Seidel  <eric@webkit.org>
143
144         Reviewed by Adam Barth.
145
146         commit-queue will report constant failures as flaky if other tests flake
147         https://bugs.webkit.org/show_bug.cgi?id=51272
148
149         This patch just removes functionality and adds testing.
150         Previously we attempted to report flaky tests when we had
151         two different tests fail in a row.  However, since we stop
152         running the tests at the first failure, our code was wrong in
153         trying to determine flakiness from the incomplete runs.
154
155         Originally I posted an alternate patch:
156         https://bug-51272-attachments.webkit.org/attachment.cgi?id=77078
157         which fixed our flaky logic in this case, however it was decided
158         that that patch would be too difficult to maintain, so now
159         I'm just removing the broken logic.
160
161         This will dramatically cut-down on our flaky-test false positives
162         at the (small) cost of the queues being unable to report
163         any flakiness if the tree is very flaky.  (With at least one test
164         flaking on every run, we'll never report failures anymore.)  I think
165         this is a tradeoff worth making.
166
167         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
168         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
169
170 2010-12-20  Eric Seidel  <eric@webkit.org>
171
172         Reviewed by Adam Barth.
173
174         commit-queue wrongly rejects patches when it can't update itself
175         https://bugs.webkit.org/show_bug.cgi?id=46636
176
177         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
178         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
179         * Scripts/webkitpy/tool/commands/queues_unittest.py:
180
181 2010-12-20  Adam Barth  <abarth@webkit.org>
182
183         Move web sites to Websites directory
184         https://bugs.webkit.org/show_bug.cgi?id=51323
185
186         Update references to BugsSite to point to the new location.
187
188         This patch was never officially reviewed (because it was too large to
189         upload to bugs.webkit.org), but it was discussed on webkit-dev and Mark
190         Rowe gave me the green light.
191
192         * Scripts/old-run-webkit-tests:
193         * Scripts/webkitpy/common/config/build.py:
194         * Scripts/webkitpy/common/config/build_unittest.py:
195         * Scripts/webkitpy/common/prettypatch.py:
196         * Scripts/webkitpy/layout_tests/port/base.py:
197         * Scripts/webkitpy/style/main.py:
198
199 2010-12-20  Adrienne Walker  <enne@google.com>
200
201         Unreviewed. Adding myself to the list of committers.
202
203         * webkitpy/common/config/committers.py:
204
205 2010-12-20  Mark Rowe  <mrowe@apple.com>
206
207         Reviewed by Dan Bernstein.
208
209         <rdar://problem/8757601> Don't install header files in to the Resources directory.
210
211         * Scripts/check-for-inappropriate-files-in-framework: Don't allow .h files in the
212         Resources directory.
213
214 2010-12-20  Eric Seidel  <eric@webkit.org>
215
216         Reviewed by Adam Barth.
217
218         commit-queue should include bot id when attaching failure diffs
219         https://bugs.webkit.org/show_bug.cgi?id=51280
220
221         This is a tiny change to include the bot id in the name of the attachment.
222         Most of this diff is just changing the unit test expectations
223         now that I hid the comment printing when the comment is None.
224
225         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
226         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
227         * Scripts/webkitpy/tool/commands/upload_unittest.py:
228         * Scripts/webkitpy/tool/mocktool.py:
229
230 2010-12-20  Jeff Miller  <jeffm@apple.com>
231
232         Reviewed by Dan Bernstein.
233
234         Tools/vcbin/midl.exe needs to be rebuilt
235         https://bugs.webkit.org/show_bug.cgi?id=51347
236
237         * vcbin/midl.exe: Rebuilt.
238
239 2010-12-20  David Levin  <levin@chromium.org>
240
241         Reviewed by Ariya Hidayat.
242
243         .gitignore and webkit-tools-completion.sh have references to WebKitTools that should be Tools.
244         https://bugs.webkit.org/show_bug.cgi?id=51343
245
246         Follow up from the WebKitTools -> Tools rename.
247
248         * Scripts/webkit-tools-completion.sh:
249
250 2010-12-20  Cosmin Truta  <ctruta@chromium.org>
251
252         Reviewed by James Robinson.
253
254         new-run-webkit-tests ignores trailing EOL differences in text tests
255         https://bugs.webkit.org/show_bug.cgi?id=36983
256
257         Changed the handling of new-line characters within new-run-webkit-tests
258         to match old-run-webkit-tests.  Differences in leading and trailing empty
259         lines in text expectation files are no longer ignored.
260
261         * Scripts/webkitpy/layout_tests/port/base.py:
262         * Scripts/webkitpy/layout_tests/port/test.py:
263         Added unit tests.  Removed old duplicate unit test entries.
264         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
265
266 2010-12-20  David Levin  <levin@chromium.org>
267
268         Reviewed by Shinichiro Hamaji.
269
270         check-webkit-style should detect function declarations (and trivial functions).
271         https://bugs.webkit.org/show_bug.cgi?id=51303
272
273         * Scripts/webkitpy/style/checkers/cpp.py:
274         (_FunctionState.begin): Add is_declaration and changed the line count
275         start to begin at -1 (which will keep the results consistent, since
276         the starting line number passed in is one less in this change).
277         (detect_functions): changed function detection to now catch trivial
278         functions and declarations.
279         (check_pass_ptr_usage): Don't check for Pass*Ptr on the first line
280         of the function as this may look at return values (when processing
281         a declaration).
282         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
283         (FunctionDetectionTest.perform_function_detection): Basic mechanics
284         of testing the function detection.
285         (FunctionDetectionTest.test_basic_function_detection): Test a simple
286         function.
287         (FunctionDetectionTest.test_function_declaration_detection): Test a
288         declaration.
289         (FunctionDetectionTest.test_non_functions): A test case for a case
290         that caused the code to fail due to the { being in quotes.
291         (PassPtrTest.test_pass_ref_ptr_return_value): Added some more test
292         cases to help catch false alarms for return values.
293         (PassPtrTest.test_pass_ref_ptr_member_variable): Ensure that
294         we don't get false alarms for member variables either.
295
296 2010-12-20  Ryuan Choi  <ryuan.choi@samsung.com>
297
298         Reviewed by Antonio Gomes.
299
300         [CMAKE] Rename WEBKITTOOLS_DIR to TOOLS_DIR
301         https://bugs.webkit.org/show_bug.cgi?id=51319
302
303         * CMakeListsEfl.txt:
304
305 2010-12-18  Adam Barth  <abarth@webkit.org>
306
307         Reviewed by Sam Weinig.
308
309         Move WebKitExamplePlugins to Examples
310         https://bugs.webkit.org/show_bug.cgi?id=51291
311
312         * Scripts/webkitpy/common/config/build.py:
313
314 2010-12-17  Csaba Osztrogonác  <ossy@webkit.org>
315
316         Unreviewed Qt buildfix after r74301.
317
318         Rename WebKitTools to Tools
319         https://bugs.webkit.org/show_bug.cgi?id=49861
320
321         * MiniBrowser/DerivedSources.pro:
322         * MiniBrowser/qt/MiniBrowser.pro:
323
324 2010-12-17  Dan Bernstein  <mitz@apple.com>
325
326         Reviewed by Simon Fraser.
327
328         Rename WebKitTools to Tools
329         https://bugs.webkit.org/show_bug.cgi?id=49861
330
331         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
332         * CodeCoverage/README:
333         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
334         (WebCore::DumpRenderTree::initializeFonts):
335         * EWSTools/start-commit-queue.sh:
336         * EWSTools/start-queue.sh:
337         * GNUmakefile.am:
338         * MIDLWrapper/MIDLWrapper.cpp:
339         (wmain):
340         * MiniBrowser/qt/MiniBrowser.pro:
341         * Scripts/build-api-tests:
342         * Scripts/build-dumprendertree:
343         * Scripts/build-webkit:
344         * Scripts/build-webkittestrunner:
345         * Scripts/generate-coverage-data:
346         * Scripts/old-run-webkit-tests:
347         * Scripts/run-api-tests:
348         * Scripts/run-iexploder-tests:
349         * Scripts/run-javascriptcore-tests:
350         * Scripts/run-mangleme-tests:
351         * Scripts/run-sunspider:
352         * Scripts/run-webkit-websocketserver:
353         * Scripts/sunspider-compare-results:
354         * Scripts/test-webkitperl:
355         * Scripts/test-webkitpy:
356         * Scripts/update-iexploder-cssproperties:
357         * Scripts/update-webkit:
358         * Scripts/update-webkit-localizable-strings:
359         * Scripts/webkitdirs.pm:
360         * Scripts/webkitpy/common/checkout/scm.py:
361         * Scripts/webkitpy/common/checkout/scm_unittest.py:
362         * Scripts/webkitpy/common/config/committervalidator.py:
363         * Scripts/webkitpy/common/config/committervalidator_unittest.py:
364         * Scripts/webkitpy/common/config/ports.py:
365         * Scripts/webkitpy/common/config/ports_unittest.py:
366         * Scripts/webkitpy/common/system/logutils_unittest.py:
367         * Scripts/webkitpy/common/system/ospath_unittest.py:
368         * Scripts/webkitpy/layout_tests/port/chromium.py:
369         * Scripts/webkitpy/layout_tests/port/config.py:
370         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
371         * Scripts/webkitpy/layout_tests/port/http_server.py:
372         * Scripts/webkitpy/layout_tests/port/test.py:
373         * Scripts/webkitpy/style/checker.py:
374         * Scripts/webkitpy/style/checker_unittest.py:
375         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
376         * Scripts/webkitpy/tool/commands/queues_unittest.py:
377         * Scripts/webkitpy/tool/steps/steps_unittest.py:
378         * WebKitTestRunner/DerivedSources.pro:
379         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
380         (WTR::activateFonts):
381         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
382         * wx/build/build_utils.py:
383
384 2010-12-16  Antonio Gomes  <agomes@rim.com>
385
386         Reviewed by Martin Robinson.
387
388         Settings::editingBehaviorType() incorrectly returns mac for the gtk build when running tests
389         https://bugs.webkit.org/show_bug.cgi?id=51163
390
391         Since GTK+'s default editing behavior was changed to UNIX in r70975 (see webkitwebsettings.cpp),
392         GTK+'s DRT should also reset to UNIX after each test execution.
393
394         * DumpRenderTree/gtk/DumpRenderTree.cpp:
395         (resetDefaultsToConsistentValues):
396
397 2010-12-17  David Levin  <levin@chromium.org>
398
399         Reviewed by Eric Seidel.
400
401         check-webkit-style should understand WTF #include guards
402         https://bugs.webkit.org/show_bug.cgi?id=44911
403
404         * Scripts/webkitpy/style/checkers/cpp.py:
405         (get_header_guard_cpp_variable): modify to suggest the WTF style
406         of header guard when appropriate.
407         (check_for_header_guard): handle multiple return values from
408         get_header_guard_cpp_variable
409         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
410         (CppStyleTest.test_build_header_guard): Added tests for the WTF
411         header style.
412
413 2010-12-16  David Levin  <levin@chromium.org>
414
415         Reviewed by Eric Seidel.
416
417         test-webkitpy: unittest for the xml.py checker displays a decprecation warning.
418         https://bugs.webkit.org/show_bug.cgi?id=51210
419
420         The error only shows up when using python 2.6 or later.
421
422         * Scripts/webkitpy/style/checkers/xml.py: Replace the usage of
423         the decprecated field error,message with something equivalent.
424
425 2010-12-16  Mihai Parparita  <mihaip@chromium.org>
426
427         Reviewed by Eric Seidel.
428
429         Add --exit-after-n-failures/crashes to NRWT
430         https://bugs.webkit.org/show_bug.cgi?id=51160
431         
432         Abort test run (in a similar way to how control-C is handled) when
433         --exit-after-n-failures/crashes-or-timeouts are passed and we've reached
434         that number of unexpected failures/crashes/timeouts.
435
436         * Scripts/webkitpy/layout_tests/port/test.py:
437         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
438         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
439
440 2010-12-16  David Levin  <levin@chromium.org>
441
442         Reviewed by Shinichiro Hamaji.
443
444         check-webkit-style unit tests has some duplicate boilerplate code.
445         https://bugs.webkit.org/show_bug.cgi?id=49519
446
447         * Scripts/webkitpy/style/checkers/cpp.py:
448         (update_include_state): Replaced the "io" parameter with the global
449         configuration _unit_test_config. This allowed not calling into
450         functions at a low level and also not plumbing through the injection
451         information through many levels of code.
452         (check_for_include_what_you_use): Ditto.
453         (process_file_data): Added the ability to set up the unit test config
454         to allow for injection.
455         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
456         (ErrorCollector.__init__): Added support for having a filter for errors.
457         (ErrorCollector.__call__): Ditto.
458         (CppStyleTestBase.process_file_data): Added the ability to set unit_test_config.
459         (CppStyleTestBase.perform_lint): Consolidated logic for the perform functions.
460         (CppStyleTestBase.perform_single_line_lint): Replace specific calls to
461         functions in the cpp.py with generic processing and a filter that
462         indicates what errors should be kept.
463         (CppStyleTestBase.perform_multi_line_lint): Ditto.
464         (CppStyleTestBase.perform_language_rules_check): Ditto.
465         (CppStyleTestBase.perform_function_lengths_check): Ditto.
466         (CppStyleTestBase.perform_pass_ptr_check): Ditto.
467         (CppStyleTestBase.perform_include_what_you_use): Ditto.
468         (CppStyleTest.test_multi_line_comments): Added another
469         error message which applies to the test case.
470         (CppStyleTest.test_spacing_for_binary_ops): Fixed test
471         to not have config.h, since it is processed as a header file.
472         (CppStyleTest.test_static_or_global_stlstrings): Fixed variable name
473         style and indentation in checked code.
474         (OrderOfIncludesTest.test_check_preprocessor_in_include_section):
475         Fixed line number.
476         (NoNonVirtualDestructorsTest.test_multi_line_declaration_with_error):
477         Ditto.
478
479 2010-12-15  Sheriff Bot  <webkit.review.bot@gmail.com>
480
481         Unreviewed, rolling out r74136.
482         http://trac.webkit.org/changeset/74136
483         https://bugs.webkit.org/show_bug.cgi?id=51135
484
485         r74136 breaks chromium canary bots because some tests are not
486         rebaselined correctly to resolve EOL differences (Requested by
487         jianli on #webkit).
488
489         * Scripts/webkitpy/layout_tests/port/base.py:
490         * Scripts/webkitpy/layout_tests/port/test.py:
491         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
492
493 2010-12-15  Adam Roben  <aroben@apple.com>
494
495         Teach check-webkit-style to check .vcproj and .vsprops files for XML
496         syntax errors
497
498         Fixes <http://webkit.org/b/51103> check-webkit-style should check for
499         XML syntax errors in .vcproj/.vsprops files
500
501         Reviewed by Dave Levin.
502
503         * Scripts/webkitpy/style/checker.py: Added lists of file extensions
504         that should be treated as XML and that should be allowed to contain
505         carriage returns. (These lists happen to be identical currently.)
506         (FileType): Added a new XML type.
507         (CheckerDispatcher.should_check_and_strip_carriage_returns): Added.
508         Just does a simple file extension check.
509         (CheckerDispatcher._file_type): Added a case for XML files.
510         (CheckerDispatcher._create_checker): Ditto. We use XMLChecker for XML
511         files (surprise!).
512         (StyleProcessor.process): Ask the dispatcher whether we should pass the
513         lines through the carriage checker.
514
515         * Scripts/webkitpy/style/checker_unittest.py:
516         (CheckerDispatcherCarriageReturnTest.test_should_check_and_strip_carriage_returns):
517         Added. Checks a few file names to see if carriage returns are allowed
518         or not.
519         (CheckerDispatcherDispatchTest.assert_checker_xml): Added. Similar to
520         other assert_checker_* functions.
521         (CheckerDispatcherDispatchTest.test_xml_paths): Added. Similar to other
522         test_*_paths functions.
523         (CheckerDispatcherDispatchTest.test_xml_paths): Added. Similar to other
524         test_*_paths functions.
525         (CheckerDispatcherDispatchTest.test_none_paths): Removed the vcproj
526         file from this test case, as vcproj files now have a type.
527         (StyleProcessor_CodeCoverageTest.MockDispatcher.should_check_and_strip_carriage_returns):
528         Added. Similar to the other should_* functions.
529         (StyleProcessor_CodeCoverageTest.test_process__carriage_returns_not_stripped):
530         Added. Checks that carriage returns aren't checked for or stripped for
531         allowed files.
532
533         * Scripts/webkitpy/style/checkers/xml.py: Added.
534         (XMLChecker.__init__): Simple init method.
535         (XMLChecker.check): Pass each line through the expat parser, and record
536         a style error for any errors thrown by the parser.
537
538         * Scripts/webkitpy/style/checkers/xml_unittest.py: Added.
539         (XMLCheckerTest.assert_no_error): Checks that the given XML does not
540         produce a style error.
541         (XMLCheckerTest.assert_error): Checks that the given XML produces an
542         error of the given category on the given line.
543         (XMLCheckerTest.mock_handle_style_error): Does nothing. Used for
544         checking that the XMLChecker constructor works properly.
545         (XMLCheckerTest.test_conflict_marker): Tests that conflict markers
546         cause a style error (see, e.g., r73887).
547         (XMLCheckerTest.test_extra_closing_tag): Tests that extra closing tags
548         cause a style error (see, e.g., r73773).
549         (XMLCheckerTest.test_init): Tests that the XMLChecker constructor works
550         properly.
551         (XMLCheckerTest.test_missing_closing_tag): Tests that missing closing
552         tags cause a style error (see, e.g., r72795).
553         (XMLCheckerTest.test_no_error): Tests that valid XML does not cause a
554         style error.
555
556 2010-12-15  Lucas Forschler  <lforschler@apple.com>
557
558         Reviewed by Stephanie Lewis.
559
560         https://bugs.webkit.org/show_bug.cgi?id=51117
561         Add a new leopard test bot
562         really really commit to trunk this time.
563
564         * BuildSlaveSupport/build.webkit.org-config/config.json:
565
566 2010-12-15  Sam Weinig  <sam@webkit.org>
567
568         Reviewed by Anders Carlsson.
569
570         WebKit2: Can't add files to an <input type=file>
571         https://bugs.webkit.org/show_bug.cgi?id=51087
572
573         * MiniBrowser/mac/BrowserWindowController.m:
574         (runOpenPanel):
575         (-[BrowserWindowController awakeFromNib]):
576         Add simple implementation of runOpenPanel callback.
577
578         * MiniBrowser/win/BrowserView.cpp:
579         (BrowserView::create):
580         * WebKitTestRunner/TestController.cpp:
581         (WTR::createOtherPage):
582         (WTR::TestController::initialize):
583         Stub out runOpenPanel callback. 
584
585 2010-12-14  Eric Seidel  <eric@webkit.org>
586
587         Reviewed by Adam Barth.
588
589         commit-queue should upload failure diffs when tests flake
590         https://bugs.webkit.org/show_bug.cgi?id=51051
591
592         To make this testable I needed to pipe FileSystem down onto tool.
593         We've wanted it there for a long time anyway.
594
595         This patch is kinda a big hack.  But we don't have a nice
596         way to read results.html files.  I think this will need further
597         revision before this code actually feels clean.
598
599         As part of testing this change, I had to make MockBugzilla.create_bug
600         actually return an id (like it should) which required updating
601         a few other unit test results (for the better).
602
603         The results_matching_keys change in layouttestresults/rebasline
604         was an alternate path which I decided not to use in the end, but
605         I left the change as it seemed an improvement.
606
607         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
608         * Scripts/webkitpy/common/net/layouttestresults.py:
609         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
610         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
611         * Scripts/webkitpy/tool/commands/queues.py:
612         * Scripts/webkitpy/tool/commands/rebaseline.py:
613         * Scripts/webkitpy/tool/main.py:
614         * Scripts/webkitpy/tool/mocktool.py:
615
616 2010-12-15  Cosmin Truta  <ctruta@chromium.org>
617
618         Reviewed by James Robinson.
619
620         new-run-webkit-tests ignores trailing EOL differences in text tests
621         https://bugs.webkit.org/show_bug.cgi?id=36983
622
623         Changed the handling of new-line characters within new-run-webkit-tests
624         to match old-run-webkit-tests.  Differences in leading and trailing empty
625         lines in text expectation files are no longer ignored.
626
627         * Scripts/webkitpy/layout_tests/port/base.py:
628         * Scripts/webkitpy/layout_tests/port/test.py:
629         Added unit tests.  Removed old duplicate unit test entries.
630         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
631
632 2010-12-15  Ojan Vafai  <ojan@chromium.org>
633
634         Reviewed by Adam Barth.
635
636         make status-bubble white-space:nowrap so we can measure it's width without wrapping
637         https://bugs.webkit.org/show_bug.cgi?id=51149
638
639         * QueueStatusServer/templates/statusbubble.html:
640
641 2010-12-15  Ojan Vafai  <ojan@chromium.org>
642
643         Reviewed by Adam Barth.
644
645         have the statusbubble postMessage it's metrics so that embedders can properly size the iframe
646         https://bugs.webkit.org/show_bug.cgi?id=51125
647
648         * QueueStatusServer/templates/statusbubble.html:
649
650 2010-12-15  Darin Adler  <darin@apple.com>
651
652         * Scripts/webkitpy/common/net/buildbot: Added property svn:ignore.
653
654 2010-12-15  Sheriff Bot  <webkit.review.bot@gmail.com>
655
656         Unreviewed, rolling out r74117.
657         http://trac.webkit.org/changeset/74117
658         https://bugs.webkit.org/show_bug.cgi?id=51113
659
660         This broke the GTK1 build. (Requested by mrobinson on
661         #webkit).
662
663         * Scripts/webkitdirs.pm:
664
665 2010-12-15  Amruth Raj  <amruthraj@motorola.com> and Ravi Kasibhatla  <ravi.kasibhatla@motorola.com>
666
667         Reviewed by Martin Robinson.
668
669         Change generate-forwarding-headers.pl for GTK port usage 
670         (https://bugs.webkit.org/show_bug.cgi?id=37369)
671
672         * Scripts/webkitdirs.pm: Added changes to build webkit2 for GTK port using build-webkit script.
673
674 2010-12-14  Kent Tamura  <tkent@chromium.org>
675
676         Reviewed by Jian Li.
677
678         [DRT/Chromium] Remove another unnecessary error message
679         https://bugs.webkit.org/show_bug.cgi?id=51083
680
681         * DumpRenderTree/chromium/WebViewHost.cpp:
682         (WebViewHost::didInvalidateRect):
683
684 2010-12-14  Lucas Forschler  <lforschler@apple.com>
685
686         Reviewed by Stephanie Lewis.
687
688         Add a new Leopard Debug Test WK2 Bot
689
690         * BuildSlaveSupport/build.webkit.org-config/config.json:
691
692 2010-12-14  Ojan Vafai  <ojan@chromium.org>
693
694         Fix python unittests after http://trac.webkit.org/changeset/74070.
695
696         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
697
698 2010-12-14  Kent Tamura  <tkent@chromium.org>
699
700         Reviewed by Jian Li.
701
702         [DRT/Chromium] Remove a unnecessary error message
703         https://bugs.webkit.org/show_bug.cgi?id=51069
704
705         * DumpRenderTree/chromium/WebViewHost.cpp:
706         (WebViewHost::paintInvalidatedRegion):
707
708 2010-12-14  Benjamin Kalman  <kalman@chromium.org>
709
710         Reviewed by Ojan Vafai.
711
712         Using BUG/BUGWK in test_expectations is error prone, should use BUGCR/BUGWK
713         https://bugs.webkit.org/show_bug.cgi?id=48926
714
715         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
716         Add presubmit check that BUG isn't used, either BUGCR/BUGWK/BUGV8_.
717
718 2010-12-14  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
719
720         Reviewed by Eric Seidel.
721
722         [Qt] [Symbian] Do not use pkg-config on Symbian as it is not supported
723         https://bugs.webkit.org/show_bug.cgi?id=50231
724
725         Guard CONFIG+=link_pkgconfig with !symbian.
726
727         * DumpRenderTree/qt/DumpRenderTree.pro:
728         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
729         * WebKitTestRunner/qt/WebKitTestRunner.pro:
730
731 2010-12-14  Philippe Normand  <pnormand@igalia.com>
732
733         Reviewed by Ojan Vafai.
734
735         [new-run-webkit-tests] expectations parsing is slow
736         https://bugs.webkit.org/show_bug.cgi?id=50635
737
738         Avoid expensive iteration of all the tests when checking if a test
739         file is to be skipped or not.
740
741         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
742         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
743         * Scripts/webkitpy/layout_tests/port/test.py:
744
745 2010-12-14  Mario Sanchez Prada  <msanchez@igalia.com>
746
747         Reviewed by Xan Lopez.
748
749         [Gtk] Implement STATE_FOCUSED, STATE_FOCUSABLE, and corresponding events for text objects
750         https://bugs.webkit.org/show_bug.cgi?id=27048
751
752         Add support in DRT for checking whether an accessibility UI
753         element is focusable and/or focused. Implemented for GTK.
754
755         * DumpRenderTree/AccessibilityUIElement.cpp:
756         (getIsFocusedCallback): New.
757         (getIsFocusableCallback): New.
758         (AccessibilityUIElement::getJSClass): Add the new available
759         callbacks for isFocused and isFocusable.
760         * DumpRenderTree/AccessibilityUIElement.h:
761         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
762         (AccessibilityUIElement::isFocused): New, implemented by checking
763         whether the related AtkState value is in the object's state set.
764         (AccessibilityUIElement::isFocusable): Ditto.
765         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
766         (AccessibilityUIElement::isFocused): New, dummy implementation.
767         (AccessibilityUIElement::isFocusable): Ditto.
768         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
769         (AccessibilityUIElement::isFocused): Ditto.
770         (AccessibilityUIElement::isFocusable): Ditto.
771
772 2010-12-14  Eric Seidel  <eric@webkit.org>
773
774         Reviewed by Ojan Vafai.
775
776         webkit-patch should warn users when they're using a 32-bit git on a 64-bit system
777         https://bugs.webkit.org/show_bug.cgi?id=50715
778
779         This patch makes webkit-patch print the following:
780
781         Warning: This machine is 64-bit, but the git binary (/usr/local/git/bin/git) does not support 64-bit.
782         Install a 64-bit git for better performance, see:
783         https://lists.webkit.org/pipermail/webkit-dev/2010-December/015249.html
784
785         I wrote this mostly because I have approximately 8 machines that I use
786         and making sure each one is using a good Git install seemed folly.
787         webkit-patch makes a lot of git calls, so using a fast git can shave
788         several seconds in every invocation.  See the webkit-dev thread for more info.
789
790         This message will print twice during 'webkit-patch upload',
791         once from webkit-patch and once from check-webkit-style.
792
793         Unfortunately there is no good way to test this due to how machine-dependent
794         the code is.  I considered writing a test for the log message, but it seemed not worth it.
795
796         * Scripts/webkitpy/common/checkout/scm.py:
797
798 2010-12-13  Eric Seidel  <eric@webkit.org>
799
800         Reviewed by Adam Barth.
801
802         FlakyTestReporter doesn't understand bots running from multiple email addresses
803         https://bugs.webkit.org/show_bug.cgi?id=50960
804
805         This explains at least one of the dupes of:
806         https://bugs.webkit.org/show_bug.cgi?id=50863
807         that we saw filed by the commit-queue this morning.
808         I think the other one was explained by my previous fix to result counting code.
809
810         Since this is really hard to test with a unit test, instead I
811         create a new (possibly useful in the future) command
812         which given a layout test path will return you
813         the one bug which our tools would assume it the flaky test bug.
814         If some other script wants to use bug-for-test we'll
815         need to extend it with some options like --create-if-missing or similar.
816
817         * Scripts/webkitpy/common/net/bugzilla/bug.py:
818         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
819         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
820         * Scripts/webkitpy/tool/commands/__init__.py:
821         * Scripts/webkitpy/tool/commands/bugfortest.py: Added.
822
823 2010-12-13  Mihai Parparita  <mihaip@chromium.org>
824
825         Reviewed by James Robinson.
826
827         Add option to build-webkit to not build WebKit2
828         https://bugs.webkit.org/show_bug.cgi?id=50988
829         
830         Add support for a --no-webkit2 option to build-webkit. It seems to save
831         ~1 minute from clean builds and ~10 seconds from no-op builds.
832
833         * Scripts/build-webkit:
834
835 2010-12-13  Lucas Forschler  <lforschler@apple.com>
836
837         Reviewed by Dave Kilzer.
838
839         Update iexploder from 1.3.2 to 1.7.2
840         Move 1.3.2 into its own subdir
841         Add 1.7.2 into its own subdir
842         update scripts to point to new 1.3.2 location (avoid breaking existing scripts)
843
844         * Scripts/run-iexploder-tests:
845         * Scripts/update-iexploder-cssproperties:
846         * iExploder/CHANGELOG.txt: Removed.
847         * iExploder/LICENSE.txt: Removed.
848         * iExploder/README.txt: Removed.
849         * iExploder/htdocs: Removed.
850         * iExploder/iexploder-1.3.2: Added.
851         * iExploder/iexploder-1.3.2/CHANGELOG.txt: Copied from iExploder/CHANGELOG.txt.
852         * iExploder/iexploder-1.3.2/LICENSE.txt: Copied from iExploder/LICENSE.txt.
853         * iExploder/iexploder-1.3.2/README.txt: Copied from iExploder/README.txt.
854         * iExploder/iexploder-1.3.2/htdocs: Added.
855         * iExploder/iexploder-1.3.2/htdocs/config.rb: Copied from iExploder/htdocs/config.rb.
856         * iExploder/iexploder-1.3.2/htdocs/cssproperties.in: Copied from iExploder/htdocs/cssproperties.in.
857         * iExploder/iexploder-1.3.2/htdocs/cssvalues.in: Copied from iExploder/htdocs/cssvalues.in.
858         * iExploder/iexploder-1.3.2/htdocs/htmlattrs.in: Copied from iExploder/htdocs/htmlattrs.in.
859         * iExploder/iexploder-1.3.2/htdocs/htmltags.in: Copied from iExploder/htdocs/htmltags.in.
860         * iExploder/iexploder-1.3.2/htdocs/htmlvalues.in: Copied from iExploder/htdocs/htmlvalues.in.
861         * iExploder/iexploder-1.3.2/htdocs/iexploder.cgi: Copied from iExploder/htdocs/iexploder.cgi.
862         * iExploder/iexploder-1.3.2/htdocs/iexploder.rb: Copied from iExploder/htdocs/iexploder.rb.
863         * iExploder/iexploder-1.3.2/htdocs/index.html: Copied from iExploder/htdocs/index.html.
864         * iExploder/iexploder-1.3.2/htdocs/webserver.rb: Copied from iExploder/htdocs/webserver.rb.
865         * iExploder/iexploder-1.3.2/tools: Added.
866         * iExploder/iexploder-1.3.2/tools/lasthit.rb: Copied from iExploder/tools/lasthit.rb.
867         * iExploder/iexploder-1.3.2/tools/osx_last_crash.rb: Copied from iExploder/tools/osx_last_crash.rb.
868         * iExploder/iexploder-1.3.2/tools/showtest.rb: Copied from iExploder/tools/showtest.rb.
869         * iExploder/iexploder-1.7.2: Added.
870         * iExploder/iexploder-1.7.2/ChangeLog.txt: Added.
871         * iExploder/iexploder-1.7.2/LICENSE.txt: Added.
872         * iExploder/iexploder-1.7.2/README.txt: Added.
873         * iExploder/iexploder-1.7.2/output: Added.
874         * iExploder/iexploder-1.7.2/src: Added.
875         * iExploder/iexploder-1.7.2/src/browser_harness.rb: Added.
876         * iExploder/iexploder-1.7.2/src/config.yaml: Added.
877         * iExploder/iexploder-1.7.2/src/css-atrules: Added.
878         * iExploder/iexploder-1.7.2/src/css-atrules/mozilla: Added.
879         * iExploder/iexploder-1.7.2/src/css-atrules/webkit: Added.
880         * iExploder/iexploder-1.7.2/src/css-properties: Added.
881         * iExploder/iexploder-1.7.2/src/css-properties/dillo: Added.
882         * iExploder/iexploder-1.7.2/src/css-properties/gtkhtml: Added.
883         * iExploder/iexploder-1.7.2/src/css-properties/internet_explorer6: Added.
884         * iExploder/iexploder-1.7.2/src/css-properties/mozilla: Added.
885         * iExploder/iexploder-1.7.2/src/css-properties/webkit: Added.
886         * iExploder/iexploder-1.7.2/src/css-pseudo: Added.
887         * iExploder/iexploder-1.7.2/src/css-pseudo/mozilla: Added.
888         * iExploder/iexploder-1.7.2/src/css-pseudo/webkit: Added.
889         * iExploder/iexploder-1.7.2/src/css-values: Added.
890         * iExploder/iexploder-1.7.2/src/css-values/dillo: Added.
891         * iExploder/iexploder-1.7.2/src/css-values/gtkhtml: Added.
892         * iExploder/iexploder-1.7.2/src/css-values/mozilla: Added.
893         * iExploder/iexploder-1.7.2/src/css-values/other: Added.
894         * iExploder/iexploder-1.7.2/src/css-values/webkit: Added.
895         * iExploder/iexploder-1.7.2/src/headers: Added.
896         * iExploder/iexploder-1.7.2/src/headers/dillo: Added.
897         * iExploder/iexploder-1.7.2/src/headers/gtkhtml: Added.
898         * iExploder/iexploder-1.7.2/src/headers/mozilla: Added.
899         * iExploder/iexploder-1.7.2/src/headers/webkit: Added.
900         * iExploder/iexploder-1.7.2/src/html-attrs: Added.
901         * iExploder/iexploder-1.7.2/src/html-attrs/dillo: Added.
902         * iExploder/iexploder-1.7.2/src/html-attrs/gtkhtml: Added.
903         * iExploder/iexploder-1.7.2/src/html-attrs/internet_explorer6: Added.
904         * iExploder/iexploder-1.7.2/src/html-attrs/mozilla: Added.
905         * iExploder/iexploder-1.7.2/src/html-attrs/other: Added.
906         * iExploder/iexploder-1.7.2/src/html-attrs/webkit: Added.
907         * iExploder/iexploder-1.7.2/src/html-tags: Added.
908         * iExploder/iexploder-1.7.2/src/html-tags/dillo: Added.
909         * iExploder/iexploder-1.7.2/src/html-tags/gtkhtml: Added.
910         * iExploder/iexploder-1.7.2/src/html-tags/mozilla: Added.
911         * iExploder/iexploder-1.7.2/src/html-tags/other: Added.
912         * iExploder/iexploder-1.7.2/src/html-tags/webkit: Added.
913         * iExploder/iexploder-1.7.2/src/html-values: Added.
914         * iExploder/iexploder-1.7.2/src/html-values/dillo: Added.
915         * iExploder/iexploder-1.7.2/src/html-values/gtkhtml: Added.
916         * iExploder/iexploder-1.7.2/src/html-values/mozilla: Added.
917         * iExploder/iexploder-1.7.2/src/html-values/other: Added.
918         * iExploder/iexploder-1.7.2/src/html-values/webkit: Added.
919         * iExploder/iexploder-1.7.2/src/iexploder.cgi: Added.
920         * iExploder/iexploder-1.7.2/src/iexploder.rb: Added.
921         * iExploder/iexploder-1.7.2/src/index.html: Added.
922         * iExploder/iexploder-1.7.2/src/media: Added.
923         * iExploder/iexploder-1.7.2/src/media/blank.ogg: Added.
924         * iExploder/iexploder-1.7.2/src/media/blank.snd: Added.
925         * iExploder/iexploder-1.7.2/src/media/blank.wav: Added.
926         * iExploder/iexploder-1.7.2/src/media/bug.bmp: Added.
927         * iExploder/iexploder-1.7.2/src/media/bug.gif: Added.
928         * iExploder/iexploder-1.7.2/src/media/bug.ico: Added.
929         * iExploder/iexploder-1.7.2/src/media/bug.jng: Added.
930         * iExploder/iexploder-1.7.2/src/media/bug.jpg: Added.
931         * iExploder/iexploder-1.7.2/src/media/bug.png: Added.
932         * iExploder/iexploder-1.7.2/src/media/bug.svg: Added.
933         * iExploder/iexploder-1.7.2/src/media/bug.tiff: Added.
934         * iExploder/iexploder-1.7.2/src/media/bug.xbm: Added.
935         * iExploder/iexploder-1.7.2/src/media/bug.xpm: Added.
936         * iExploder/iexploder-1.7.2/src/mime-types: Added.
937         * iExploder/iexploder-1.7.2/src/mime-types/dillo: Added.
938         * iExploder/iexploder-1.7.2/src/mime-types/mozilla: Added.
939         * iExploder/iexploder-1.7.2/src/mime-types/webkit: Added.
940         * iExploder/iexploder-1.7.2/src/protocols: Added.
941         * iExploder/iexploder-1.7.2/src/protocols/dillo: Added.
942         * iExploder/iexploder-1.7.2/src/protocols/gtkhtml: Added.
943         * iExploder/iexploder-1.7.2/src/protocols/mozilla: Added.
944         * iExploder/iexploder-1.7.2/src/protocols/webkit: Added.
945         * iExploder/iexploder-1.7.2/src/scanner.rb: Added.
946         * iExploder/iexploder-1.7.2/src/version.rb: Added.
947         * iExploder/iexploder-1.7.2/src/webserver.rb: Added.
948         * iExploder/iexploder-1.7.2/testcases: Added.
949         * iExploder/iexploder-1.7.2/testcases/testcase-Linux_x86_64_rv2.0b6pre_Gecko-20100904_Firefox-4.0b6pre-TEST-8375-1_59.html: Added.
950         * iExploder/iexploder-1.7.2/testcases/testcase-Opera-9.80_Linux_x86_64_en_Presto-2.6.30_Version-10.61-16704-3_108,3.html: Added.
951         * iExploder/iexploder-1.7.2/testcases/testcase-U_Intel_Mac_OS_X_10_6_4_en-US_AppleWebKit-534.8_Chrome-7.0.529.0-TEST-611-3_36,9.html: Added.
952         * iExploder/iexploder-1.7.2/testcases/testcase-U_Intel_Mac_OS_X_10_6_4_en-US_AppleWebKit-534.8_hrome-7.0.529.0-TEST-55313622206-3_6,0.html: Added.
953         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.6_Chrome-7.0.503.1-TEST-120813-8_72,56,24,8,0.html: Added.
954         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.6_Chrome-7.0.503.1-TEST-121240-3_81,3.html: Added.
955         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.7_Chrome-7.0.513.0-4800-5_80,65,15.html: Added.
956         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.7_Chrome-7.0.513.0-TEST-23583190347-3_15,12.html: Added.
957         * iExploder/iexploder-1.7.2/tools: Added.
958         * iExploder/iexploder-1.7.2/tools/lasthit.rb: Added.
959         * iExploder/iexploder-1.7.2/tools/osx_last_crash.rb: Added.
960         * iExploder/iexploder-1.7.2/tools/release_src.sh: Added.
961         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh: Added.
962         * iExploder/tools: Removed.
963
964 2010-12-13  Sam Weinig  <sam@webkit.org>
965
966         Reviewed by Anders Carlsson.
967
968         Remove associated page concept from WKView constructor
969         https://bugs.webkit.org/show_bug.cgi?id=50983
970
971         Step 1: Remove associate page constructors from WKView and make
972         all views use the shared namespace for the context.
973
974         * TestWebKitAPI/PlatformWebView.h:
975         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
976         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
977         * WebKitTestRunner/PlatformWebView.h:
978         * WebKitTestRunner/TestController.cpp:
979         (WTR::createOtherPage):
980         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
981         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
982         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
983
984 2010-12-13  Sam Weinig  <sam@webkit.org>
985
986         Reviewed by Anders Carlsson.
987
988         Change the WebKit2 public API so there is no explicit WKPageNamespace object
989         https://bugs.webkit.org/show_bug.cgi?id=50898
990
991         * MiniBrowser/mac/AppDelegate.h:
992         * MiniBrowser/mac/AppDelegate.m:
993         * MiniBrowser/mac/BrowserWindowController.h:
994         * MiniBrowser/mac/BrowserWindowController.m:
995         * MiniBrowser/win/BrowserView.cpp:
996         Convert MiniBrowser to not use PageNamespaces.
997
998         * TestWebKitAPI/PlatformWebView.h:
999         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
1000         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
1001         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
1002         * TestWebKitAPI/Tests/WebKit2/Find.cpp:
1003         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
1004         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
1005         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
1006         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
1007         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
1008         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
1009         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
1010         * TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp:
1011         * TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp:
1012         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
1013         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
1014         Convert TestWebKitAPI to not use PageNamespaces.
1015
1016         * WebKitTestRunner/PlatformWebView.h:
1017         * WebKitTestRunner/TestController.cpp:
1018         * WebKitTestRunner/TestController.h:
1019         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1020         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1021         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
1022         Convert WebKitTestRunner to not use PageNamespaces.
1023
1024 2010-12-13  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
1025
1026         Reviewed by Eric Seidel.
1027
1028         webkit-patch rollout should be able to do multi-revision rollouts
1029         https://bugs.webkit.org/show_bug.cgi?id=33336
1030
1031         Make it possible to pass more than one revision to webkit-patch.
1032
1033         * Scripts/webkitpy/common/checkout/api.py:
1034         * Scripts/webkitpy/common/checkout/changelog.py:
1035         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1036         * Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:
1037         * Scripts/webkitpy/tool/commands/download.py:
1038         * Scripts/webkitpy/tool/commands/download_unittest.py:
1039         * Scripts/webkitpy/tool/mocktool.py:
1040         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
1041         * Scripts/webkitpy/tool/steps/revertrevision.py:
1042
1043 2010-12-13  Eric Seidel  <eric@webkit.org>
1044
1045         Unreviewed.
1046
1047         Teach webkit-patch how to search bugzilla
1048         https://bugs.webkit.org/show_bug.cgi?id=50500
1049
1050         webkit-patch bug-search fails when there is only one result.
1051         Turns out we needed a bit more logic in our result count parsing code.
1052
1053         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1054         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
1055
1056 2010-12-13  Antti Koivisto  <antti@apple.com>
1057
1058         Reviewed by Alexey Proskuryakov.
1059
1060         Add setSerializeHTTPLoads function to allow testing resource load order on OS X.
1061         https://bugs.webkit.org/show_bug.cgi?id=50758
1062
1063         * DumpRenderTree/LayoutTestController.cpp:
1064         (setSerializeHTTPLoadsCallback):
1065         (LayoutTestController::staticFunctions):
1066         * DumpRenderTree/LayoutTestController.h:
1067         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1068         (LayoutTestController::setSerializeHTTPLoads):
1069         * DumpRenderTree/mac/DumpRenderTree.mm:
1070         (resetDefaultsToConsistentValues):
1071         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1072         (LayoutTestController::setSerializeHTTPLoads):
1073         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1074         (LayoutTestController::setSerializeHTTPLoads):
1075
1076 2010-12-13  Dimitri Glazkov  <dglazkov@chromium.org>
1077
1078         Reviewed by Ojan Vafai.
1079
1080         Remove "use-drt" option from test step command line, since the option was removed in r73748.
1081         https://bugs.webkit.org/show_bug.cgi?id=50936
1082
1083         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Removed the option.
1084
1085 2010-12-13  Patrick Gansterer  <paroga@webkit.org>
1086
1087         Reviewed by Csaba Osztrogonác.
1088
1089         Add revlink to BuildBot status
1090         https://bugs.webkit.org/show_bug.cgi?id=50914
1091
1092         This adds a hyperlink to trac changeset on the revision numbers. 
1093
1094         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1095
1096 2010-12-13  Andras Becsi  <abecsi@webkit.org>
1097
1098         Reviewed by Csaba Osztrogonác.
1099
1100         [Qt][WK2] Fix build if WebKitTools are not available
1101         https://bugs.webkit.org/show_bug.cgi?id=50242
1102
1103         * MiniBrowser/qt/MiniBrowser.pro: Correct the comment.
1104         * Scripts/webkitdirs.pm: Added WebKitTools/MiniBrowser to $subdirs.
1105         * MiniBrowser/DerivedSources.pro: Added.
1106
1107 2010-12-13  Eric Seidel  <eric@webkit.org>
1108
1109         Reviewed by Adam Barth.
1110
1111         EWS Queues should remove orpahned pyc files before starting
1112         https://bugs.webkit.org/show_bug.cgi?id=50904
1113
1114         A previous check added a platform.py which caused
1115         EWS bots on some platforms to hit an import exception.
1116         The platform.py file was removed in a subsequent commit, but
1117         the EWS bots in question stayed stuck.  This change will
1118         fix those bots once restarted (and prevent this in the future).
1119
1120         I also went ahead and unified start-queue and start-commit-queue
1121         since they were nearly identical.  I also added bot_id support
1122         to both force all EWSes to have bot ids as well as get rid of the one
1123         remaining reason why I had my own copies of these scripts.
1124         Hopefully this will be enough to get all the other bot admins
1125         (ahem, Adam, ahem) to move to using these checked in copies as well.
1126
1127         * EWSTools/start-commit-queue.sh: Removed.
1128         * EWSTools/start-queue.sh:
1129
1130 2010-10-28  MORITA Hajime  <morrita@google.com>
1131
1132         Reviewed by Ojan Vafai.
1133
1134         spellcheck does not check pasted text
1135         https://bugs.webkit.org/show_bug.cgi?id=40092
1136
1137         Added LayoutTestController::setAsynchronousSpellCheckingEnabled()
1138         to control the setting.
1139
1140         * DumpRenderTree/LayoutTestController.cpp:
1141         (setAsynchronousSpellCheckingEnabledCallback):
1142         (LayoutTestController::staticFunctions):
1143         * DumpRenderTree/LayoutTestController.h:
1144         * DumpRenderTree/chromium/LayoutTestController.h:
1145         * DumpRenderTree/chromium/LayoutTestController.cpp:
1146         (LayoutTestController::LayoutTestController):
1147         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
1148         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1149         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
1150         * DumpRenderTree/mac/DumpRenderTree.mm:
1151         (resetDefaultsToConsistentValues):
1152         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1153         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
1154         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1155         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1156         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
1157         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1158         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
1159         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1160         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
1161
1162 2010-12-12  Sam Weinig  <sam@webkit.org>
1163
1164         Reviewed by Anders Carlsson.
1165
1166         Fix failing API test. It turns out that a pop-state event
1167         is sent before every fragment navigation, so we have to test
1168         for it in addition in PageLoadDidChangeLocationWithinPageForFrame.
1169
1170         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
1171         (TestWebKitAPI::didSameDocumentNavigationForFrame):
1172
1173 2010-12-12  Alejandro G. Castro  <alex@igalia.com>
1174
1175         Reviewed by Eric Seidel.
1176
1177         [GTK] Add new-run-webkit-tests support to gtk
1178         https://bugs.webkit.org/show_bug.cgi?id=50681
1179
1180         Adding the basic support to run the new-run-webkit-tests.
1181
1182         * Scripts/webkitpy/layout_tests/port/gtk.py:
1183
1184 2010-10-11  Diego Gonzalez  <diegohcg@webkit.org>
1185
1186         Reviewed by Kenneth Rohde Christiansen.
1187
1188         [Qt] Mock DeviceOrientation client for DRT
1189         https://bugs.webkit.org/show_bug.cgi?id=47490
1190
1191         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1192         (WebCore::DumpRenderTree::DumpRenderTree):
1193         (WebCore::DumpRenderTree::~DumpRenderTree):
1194         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1195         (LayoutTestController::setMockDeviceOrientation):
1196
1197 2010-12-11  Philippe Normand  <pnormand@igalia.com>
1198
1199         Reviewed by Gustavo Noronha Silva.
1200
1201         [GTK] launcher: disable the Mozilla-style fullscreen API
1202         https://bugs.webkit.org/show_bug.cgi?id=50874
1203
1204         Disabling the fullscreen API until its implementation for GTK is
1205         mature enough. The webview setting for it is already FALSE by
1206         default.
1207
1208         * GtkLauncher/main.c:
1209         (createWindow):
1210
1211 2010-12-10  Eric Seidel  <eric@webkit.org>
1212
1213         Reviewed by Adam Barth.
1214
1215         commit-queue flaky test messages show cryptic version information for mac os x
1216         https://bugs.webkit.org/show_bug.cgi?id=50864
1217
1218         Turns out platform.platform() returns kernel version information
1219         which isn't helpful, and just plain confusing on Mac
1220         (OS X 10.6.5 uses Darwin Kernel 10.5.0).
1221
1222         So I've updated PlatformInfo.display_name() to special case
1223         mac.  I also found a bad use of sys.platform in the process
1224         and fixed that.  (sys.platform always returns 'darwin' on mac).
1225
1226         * Scripts/webkitpy/common/system/platforminfo.py:
1227         * Scripts/webkitpy/common/system/user.py:
1228         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1229         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1230         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1231
1232 2010-12-10  Eric Seidel  <eric@webkit.org>
1233
1234         Unreviewed.
1235
1236         Exception seen while reporting flaky test with commit-queue.
1237         Just a missing include.
1238
1239         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1240         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1241
1242 2010-12-10  Kinuko Yasuda  <kinuko@chromium.org>
1243
1244         Reviewed by Eric Seidel.
1245
1246         [Chromium] Remove old JSONResultsGenerator script that existed for backward-compatibility
1247         https://bugs.webkit.org/show_bug.cgi?id=50796
1248
1249         Also updating the test code to use JSONResultsGeneratorBase and
1250         to improve test coverage for incremental cases.
1251
1252         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1253         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
1254
1255 2010-12-10  Joseph Pecoraro  <joepeck@webkit.org>
1256
1257         Reviewed by Darin Adler.
1258
1259         prepare-ChangeLog --help doesn't mention --bug shorthand -b
1260         https://bugs.webkit.org/show_bug.cgi?id=50835
1261
1262         * Scripts/prepare-ChangeLog: be more explicit about -b and match file style.
1263
1264 2010-12-10  Eric Seidel  <eric@webkit.org>
1265
1266         Reviewed by Adam Barth.
1267
1268         Bugs created by the commit-queue should all block on a master bug
1269         https://bugs.webkit.org/show_bug.cgi?id=50857
1270
1271         This makes all bugs created by the commit-queue block on:
1272         https://bugs.webkit.org/show_bug.cgi?id=50856
1273
1274         In the process of testing this, I found that the existing
1275         create_bug code was wrong.  I also found that existing
1276         unit tests for create-rollout used invalid values
1277         for options.blocks.  I fixed both issues and tested.
1278
1279         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1280         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1281         * Scripts/webkitpy/tool/commands/commandtest.py:
1282         * Scripts/webkitpy/tool/commands/download_unittest.py:
1283         * Scripts/webkitpy/tool/commands/upload_unittest.py:
1284         * Scripts/webkitpy/tool/mocktool.py:
1285         * Scripts/webkitpy/tool/steps/options.py:
1286
1287 2010-12-10  Eric Seidel  <eric@webkit.org>
1288
1289         Reviewed by Adam Barth.
1290
1291         Teach webkitpy how to follow duplicate chains when posting comments on flake bugs
1292         https://bugs.webkit.org/show_bug.cgi?id=50853
1293
1294         I also discovered when doing this that the code was posting
1295         the comment on the wrong bug, but that's fixed here too.
1296
1297         * Scripts/webkitpy/common/net/bugzilla/bug.py:
1298         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1299         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1300         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1301         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1302         * Scripts/webkitpy/tool/mocktool.py:
1303
1304 2010-12-10  Anders Carlsson  <andersca@apple.com>
1305
1306         Reviewed by John Sullivan.
1307
1308         Make WKContextGetStatistics gather global statistics
1309         https://bugs.webkit.org/show_bug.cgi?id=50850
1310
1311         Remove the code that gets the statistics and fills in the per context
1312         statistics information for now.
1313
1314         * MiniBrowser/mac/BrowserStatisticsWindowController.m:
1315         (-[BrowserStatisticsWindowController refreshStatistics:]):
1316
1317 2010-12-10  Eric Seidel  <eric@webkit.org>
1318
1319         Unreviewed.
1320
1321         commit-queue should report port/platform information when commenting on flaky test bugs
1322         https://bugs.webkit.org/show_bug.cgi?id=50839
1323
1324         Renamed platform.py to platforminfo.py.  This broke import platform in executive.py
1325         which was only used by new run webkit tests (and clearly not unit tested).
1326
1327         * Scripts/webkitpy/common/system/platforminfo.py: Renamed from WebKitTools/Scripts/webkitpy/common/system/platform.py.
1328         * Scripts/webkitpy/tool/main.py:
1329         * Scripts/webkitpy/tool/mocktool.py:
1330
1331 2010-12-10  Eric Seidel  <eric@webkit.org>
1332
1333         Reviewed by Tony Chang.
1334
1335         commit-queue should report port/platform information when commenting on flaky test bugs
1336         https://bugs.webkit.org/show_bug.cgi?id=50839
1337
1338         This was a suggestion from Tony Chang this morning.
1339         I added a platform.py class so I could easily mock the platform call,
1340         but that may not be the final solution for this mocking.
1341         We'll try it and see.
1342
1343         * Scripts/webkitpy/common/system/platform.py: Added.
1344         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1345         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1346         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1347         * Scripts/webkitpy/tool/main.py:
1348         * Scripts/webkitpy/tool/mocktool.py:
1349
1350 2010-12-10  Krithigassree Sambamurthy  <krithigassree.sambamurthy@nokia.com>
1351
1352         Reviewed by Joseph Pecoraro.
1353
1354         Bug 43455 - [Qt]: Implement Application Cache Quotas
1355         https://bugs.webkit.org/show_bug.cgi?id=43455
1356
1357         Introduce functions to allow new appcache layout test origin-quota.html
1358         to work correctly under Qt.
1359
1360         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1361         (WebCore::DumpRenderTree::DumpRenderTree):
1362         (WebCore::DumpRenderTree::dumpApplicationCacheQuota):
1363         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1364
1365         Introduce functions to allow new appcache layout test origin-quota.html
1366         to be successful under qt. Changes required because LayoutTestControllerQt
1367         does not inherit from LayoutController.
1368
1369         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1370         (LayoutTestController::reset):
1371         (LayoutTestController::clearAllApplicationCaches):
1372         (LayoutTestController::setApplicationCacheOriginQuota):
1373         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1374         (LayoutTestController::shouldDumpApplicationCacheDelegateCallbacks):
1375         (LayoutTestController::dumpApplicationCacheDelegateCallbacks):
1376
1377 2010-12-10  Eric Seidel  <eric@webkit.org>
1378
1379         Reviewed by Adam Barth.
1380
1381         Move buildbot.py into its own module so we can split it out into one-file-per-class
1382         https://bugs.webkit.org/show_bug.cgi?id=50806
1383
1384         We're adding more buildbot logic these days, so it makes sense
1385         to give buildbot its own module.
1386
1387         * Scripts/webkitpy/common/net/buildbot/__init__.py: Added.
1388         * Scripts/webkitpy/common/net/buildbot/buildbot.py: Renamed from WebKitTools/Scripts/webkitpy/common/net/buildbot.py.
1389         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py: Renamed from WebKitTools/Scripts/webkitpy/common/net/buildbot_unittest.py.
1390         * Scripts/webkitpy/common/net/failuremap.py:
1391         * Scripts/webkitpy/common/net/regressionwindow.py:
1392         * Scripts/webkitpy/tool/commands/rebaseline.py:
1393
1394 2010-12-10  Tony Chang  <tony@chromium.org>
1395
1396         Reviewed by Eric Seidel.
1397
1398         Use FileSystem::remove when cleaning up http lock files
1399         https://bugs.webkit.org/show_bug.cgi?id=50830
1400
1401         * Scripts/webkitpy/layout_tests/port/http_lock.py:
1402
1403 2010-12-10  Joone Hur  <joone@kldp.org>
1404
1405         Reviewed by Martin Robinson.
1406
1407         [GTK] DRT needs layoutTestController.setCacheModel
1408         https://bugs.webkit.org/show_bug.cgi?id=50705
1409         
1410         webkit_set_cache_mode() is called to set the cache model.
1411         
1412         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1413         (LayoutTestController::setCacheModel): Set the cache model. 
1414
1415 2010-12-10  Tony Chang  <tony@chromium.org>
1416
1417         Reviewed by Ojan Vafai.
1418
1419         [chromium] remove --use-drt and add --use-test-shell
1420         https://bugs.webkit.org/show_bug.cgi?id=50701
1421
1422         * Scripts/webkitpy/common/config/ports.py:
1423         * Scripts/webkitpy/common/config/ports_unittest.py:
1424         * Scripts/webkitpy/layout_tests/port/chromium.py:
1425         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1426         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1427         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1428         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1429         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1430         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1431         * Scripts/webkitpy/layout_tests/port/webkit.py:
1432         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1433         * Scripts/webkitpy/style/checkers/test_expectations.py:
1434         * Scripts/webkitpy/tool/commands/queries.py:
1435
1436 2010-12-10  John Knottenbelt  <jknotten@chromium.org>
1437
1438         Reviewed by Steve Block.
1439
1440         [Chromium] Implement mocks for client-based geolocation
1441         https://bugs.webkit.org/show_bug.cgi?id=46895
1442
1443         * DumpRenderTree/chromium/LayoutTestController.cpp:
1444         (LayoutTestController::setGeolocationPermission):
1445         (LayoutTestController::setMockGeolocationPosition):
1446         (LayoutTestController::setMockGeolocationError):
1447         * DumpRenderTree/chromium/LayoutTestController.h:
1448         * DumpRenderTree/chromium/WebViewHost.cpp:
1449         (WebViewHost::geolocationClient):
1450         (WebViewHost::geolocationClientMock):
1451         (WebViewHost::reset):
1452         * DumpRenderTree/chromium/WebViewHost.h:
1453
1454 2010-12-10  Alejandro G. Castro  <alex@igalia.com>
1455
1456         Reviewed by Martin Robinson.
1457
1458         [GTK] Add hasSpellingMarker support to the DRT
1459         https://bugs.webkit.org/show_bug.cgi?id=50739
1460
1461         Implemented the hasSpellingMarker to support spelling tests.
1462
1463         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1464         (LayoutTestController::hasSpellingMarker):
1465
1466 2010-12-10  Eric Seidel  <eric@webkit.org>
1467
1468         Reviewed by Ojan Vafai.
1469
1470         webkit-patch: not possible to use build-and-test with local commits
1471         https://bugs.webkit.org/show_bug.cgi?id=33378
1472
1473         Make --no-clean not even check if we have local commits.
1474         It's unclear to me why the code was originally written this way.
1475         I was unable to dig up a reason from svn history.
1476
1477         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
1478         * Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py: Copied from WebKitTools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.
1479
1480 2010-12-10  Mario Sanchez Prada  <msanchez@igalia.com>
1481
1482         Reviewed by Martin Robinson.
1483
1484         [GTK] AX: implement isEnabled in DRT
1485         https://bugs.webkit.org/show_bug.cgi?id=50814
1486
1487         Implement AccessibilityUIElement::isEnabled() for GTK.
1488
1489         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1490         (checkElementState): New function to refactor common code.
1491         (AccessibilityUIElement::isEnabled): Implement this by checking
1492         the current state of the AtkObject.
1493         (AccessibilityUIElement::isSelected): Use the new
1494         checkElementState function.
1495
1496 2010-12-10  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
1497
1498         Reviewed by Kenneth Rohde Christiansen.
1499
1500         [Qt][WK2] Add the QWKContext API class to wrap the WebContext.
1501         https://bugs.webkit.org/show_bug.cgi?id=50750
1502
1503         * MiniBrowser/qt/BrowserView.cpp:
1504         (BrowserView::BrowserView):
1505         * MiniBrowser/qt/BrowserView.h:
1506         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1507         (WTR::WebView::WebView):
1508
1509 2010-12-10  Joone Hur  <joone@kldp.org>
1510
1511         Reviewed by Xan Lopez.
1512
1513         [GTK] Unskipping some test cases in userscripts dependent on addUserStyleSheet
1514         https://bugs.webkit.org/show_bug.cgi?id=50808
1515
1516         Unskipping the following test cases:
1517         userscripts/mixed-case-stylesheet.html
1518         userscripts/simple-stylesheet.html
1519         userscripts/user-style-all-frames.html
1520
1521         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1522         (LayoutTestController::addUserStyleSheet):
1523
1524 2010-12-10  Joone Hur  <joone@kldp.org>
1525
1526         Reviewed by Eric Seidel.
1527
1528         [GTK] Add DRT support for pageProperty, isPageBoxVisible, pageSizeAndMarginsInPixels, and addUserStyleSheet
1529         https://bugs.webkit.org/show_bug.cgi?id=50783
1530
1531         This patch allows to unskip the following test cases:
1532         printing/page-rule-selection.html
1533         printing/page-format-data.html
1534
1535         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1536         (LayoutTestController::pageProperty): Added.
1537         (LayoutTestController::isPageBoxVisible): Ditto.
1538         (LayoutTestController::pageSizeAndMarginsInPixels): Ditto.
1539         (LayoutTestController::addUserStyleSheet): Ditto.
1540
1541 2010-12-10  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
1542
1543         Reviewed by Kenneth Rohde Christiansen.
1544
1545         [Qt] Make QtTestBrowser spawn QNAM in a secondary thread.
1546
1547         A menu allows to switch QNAM back to the same thread.
1548
1549         * QtTestBrowser/launcherwindow.cpp:
1550         (LauncherWindow::initializeView):
1551         (LauncherWindow::createChrome):
1552         (LauncherWindow::toggleThreadedQnam):
1553         * QtTestBrowser/launcherwindow.h:
1554         (WindowOptions::WindowOptions):
1555         * QtTestBrowser/webpage.cpp:
1556         (WebPage::WebPage):
1557         (WebPage::setQnamThreaded):
1558         * QtTestBrowser/webpage.h:
1559         (QnamThread::QnamThread):
1560         (QnamThread::~QnamThread):
1561         (QnamThread::networkAccessManager):
1562         (QnamThread::run):
1563
1564 2010-12-10  Martin Robinson  <mrobinson@igalia.com>
1565
1566         Reviewed by Xan Lopez.
1567
1568         [Gtk] style="font-family: courier" makes text disappear
1569         https://bugs.webkit.org/show_bug.cgi?id=47452
1570
1571         Add a test that verifies that fonts without valid charmaps are
1572         never selected.
1573
1574         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1575         (initializeFonts): Initialize DRT with our font (derived from Ahem)
1576         that has no valid charmap.
1577         * DumpRenderTree/gtk/fonts/FontWithNoValidEncoding.fon: Added.
1578         * DumpRenderTree/gtk/fonts/fonts.conf: Updated settings to override users'
1579         settings which may disable selection of bitmap fonts.
1580
1581 2010-12-10  Eric Seidel  <eric@webkit.org>
1582
1583         Unreviewed.
1584
1585         The commit-queue should file bugs about flaky tests it encounters
1586         https://bugs.webkit.org/show_bug.cgi?id=50803
1587
1588         create_bug_for_flaky_test was insufficiently tested, thus buggy.
1589         Now it's tested.
1590
1591         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1592         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1593
1594 2010-12-10  Eric Seidel  <eric@webkit.org>
1595
1596         Unreviewed.  Somehow this last-minute edit didn't quite get committed.
1597
1598         The commit-queue should file bugs about flaky tests it encounters
1599         https://bugs.webkit.org/show_bug.cgi?id=50803
1600
1601         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1602
1603 2010-12-09  Eric Seidel  <eric@webkit.org>
1604
1605         Reviewed by Adam Barth.
1606
1607         The commit-queue should file bugs about flaky tests it encounters
1608         https://bugs.webkit.org/show_bug.cgi?id=50803
1609
1610         This change got a bit big.  I also added a new config.urls file
1611         because I needed to share the view_source_url code with committervalidator.py.
1612
1613         This adds a new class FlakyTestReporter which holds all the logic about
1614         reporting flaky tests to bugzilla.
1615
1616         Right now this code knows how to look up bugs for flaky tests.
1617         If it can't find a bug filed from the commit-queue, it will open a new
1618         one, ccing the relevant people and adding information about the failure.
1619
1620         It is not yet smart enough to chase down duplicate chains, or to include
1621         the actual failure diff.  But those can be added in later iterations.
1622
1623         * Scripts/webkitpy/common/checkout/api.py:
1624         * Scripts/webkitpy/common/checkout/changelog.py:
1625         * Scripts/webkitpy/common/checkout/commitinfo.py:
1626         * Scripts/webkitpy/common/config/committervalidator.py:
1627         * Scripts/webkitpy/common/config/urls.py: Copied from WebKitTools/Scripts/webkitpy/tool/comments.py.
1628         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1629         * Scripts/webkitpy/tool/bot/flakytestreporter.py: Added.
1630         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py: Copied from WebKitTools/Scripts/webkitpy/tool/comments.py.
1631         * Scripts/webkitpy/tool/bot/irc_command.py:
1632         * Scripts/webkitpy/tool/bot/sheriff.py:
1633         * Scripts/webkitpy/tool/commands/download.py:
1634         * Scripts/webkitpy/tool/commands/queues.py:
1635         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1636         * Scripts/webkitpy/tool/comments.py:
1637         * Scripts/webkitpy/tool/mocktool.py:
1638         * Scripts/webkitpy/tool/steps/commit.py:
1639
1640 2010-12-09  Eric Seidel  <eric@webkit.org>
1641
1642         Reviewed by Adam Barth.
1643
1644         Teach webkit-patch how to search bugzilla
1645         https://bugs.webkit.org/show_bug.cgi?id=50500
1646
1647         This is a step towards teaching webkitpy how to file
1648         new bugs for flaky tests and update them when new flakes occur.
1649
1650         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1651         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
1652         * Scripts/webkitpy/tool/commands/__init__.py:
1653         * Scripts/webkitpy/tool/commands/bugsearch.py: Added.
1654
1655 2010-12-09  Adam Barth  <abarth@webkit.org>
1656
1657         Reviewed by Ojan Vafai.
1658
1659         commit-queue errors out due to local commits
1660         https://bugs.webkit.org/show_bug.cgi?id=50766
1661
1662         We seem to be tripping over having local commits in the working copy a
1663         lot recently.  I don't quite fully understand what the issue is, but
1664         this patch attempts to solve the problem by adding an explicit clean
1665         step before processing a patch.  Previously, we did the cleaning as
1666         part of the apply-attachment step, so this might not actually fix the
1667         problem.
1668
1669         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1670         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1671         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1672
1673 2010-12-09  Dirk Pranke  <dpranke@chromium.org>
1674
1675         Reviewed by Ojan Vafai.
1676
1677         Make new-run-webkit-tests --lint-test-files log slightly better
1678         messages and return -1 if lint fails. Remove the
1679         'suppress_errors' keyword param to the TestExpectationsFile
1680         class, and clean up logging and exception raising for error
1681         handling. Also add more unit tests and clean up the unit test code a bit.
1682
1683         https://bugs.webkit.org/show_bug.cgi?id=50205
1684
1685         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1686         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1687         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py
1688         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py
1689         * Scripts/webkitpy/layout_tests/port/chromium.py:
1690         * Scripts/webkitpy/style/checkers/test_expectations.py:
1691         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1692
1693 2010-12-09  Tony Chang  <tony@chromium.org>
1694
1695         Unreviewed, fix for windows code.  We were catching the wrong
1696         exception in Windows.
1697
1698         * Scripts/webkitpy/common/system/filesystem.py:
1699
1700 2010-12-09  Antonio Gomes  <agomes@rim.com>
1701
1702         Reviewed by Martin Robinson.
1703
1704         [Gtk] Populate DumpRenderTreeSupportGtk (part IV)
1705         https://bugs.webkit.org/show_bug.cgi?id=48429
1706
1707         Adjust call sites of webkit_thread_count to use the DumpRenderTreeSupportGtk version now.
1708
1709         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1710         (LayoutTestController::workerThreadCount):
1711
1712 2010-12-06  Philippe Normand  <pnormand@igalia.com>
1713
1714         Reviewed by Martin Robinson.
1715
1716         [GTK] Support the Mozilla-style Fullscreen Javascript API
1717         https://bugs.webkit.org/show_bug.cgi?id=50572
1718
1719         Enable the Javascript Fullscreen support in the GtkLauncher. Also
1720         make DRT update the Chrome when the WebView settings have been
1721         reset to consistent values.
1722
1723         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1724         (resetDefaultsToConsistentValues):
1725         * GtkLauncher/main.c:
1726         (create_window):
1727         * Scripts/build-webkit:
1728
1729 2010-12-09  Koan-Sin Tan  <koansin.tan@gmail.com>
1730
1731         Reviewed by Tor Arne Vestbø
1732
1733         [Qt] run-launcher doesn't start the browser on Mac OS X 10.6
1734         https://bugs.webkit.org/show_bug.cgi?id=50742
1735
1736         check not only QtWebKit.framework/QtWebKit but also libQtWebKit.dylib
1737
1738         * Scripts/webkitdirs.pm:
1739
1740 2010-12-09  Joone Hur  <joone@kldp.org>
1741
1742          Reviewed by Martin Robinson.
1743
1744          [GTK] Support for viewport meta tag
1745          https://bugs.webkit.org/show_bug.cgi?id=45443
1746
1747          Add support for testing the viewport properties for WebKitGtk.
1748
1749          * DumpRenderTree/LayoutTestController.cpp:
1750          (dumpConfigurationForViewportCallback): Added this JS callback to set the size of the visible viewport.
1751          (LayoutTestController::staticFunctions):
1752          * DumpRenderTree/LayoutTestController.h:
1753          * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1754          (LayoutTestController::dumpConfigurationForViewport): Added this function to test the viewport properties.
1755          * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1756          (LayoutTestController::dumpConfigurationForViewport): Ditto.
1757          * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1758          (LayoutTestController::dumpConfigurationForViewport): Ditto.
1759          * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1760          (LayoutTestController::dumpConfigurationForViewport): Ditto.
1761          * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1762          (LayoutTestController::dumpConfigurationForViewport): Ditto.
1763
1764 2010-12-08  William Siegrist <wsiegrist@apple.com>
1765
1766         Reviewed by Eric Seidel.
1767
1768         Migrate buildbot.py from xmlrpc to json.
1769         https://bugs.webkit.org/show_bug.cgi?id=50647
1770
1771         * Scripts/webkitpy/common/net/buildbot.py:
1772
1773 2010-12-08  Tony Chang  <tony@chromium.org>
1774
1775         Reviewed by Eric Seidel.
1776
1777         make starting the websocket server more reliable on windows
1778         https://bugs.webkit.org/show_bug.cgi?id=50712
1779
1780         * Scripts/webkitpy/common/system/filesystem.py:
1781         (remove): Substitute method for os.remove to retry on error on Windows
1782         * Scripts/webkitpy/common/system/filesystem_unittest.py:
1783         * Scripts/webkitpy/layout_tests/port/http_server_base.py: Use FileSystem.remove
1784
1785 2010-12-08  Jessie Berlin  <jberlin@apple.com>
1786
1787         Reviewed by Adam Roben.
1788
1789         WebKit2: Implement WebChromeClient::exceededDatabaseQuota
1790         https://bugs.webkit.org/show_bug.cgi?id=50656
1791
1792         * MiniBrowser/mac/BrowserWindowController.m:
1793         (-[BrowserWindowController awakeFromNib]):
1794         Indicate that exceededDatabaseQuota is not implemented.
1795         * MiniBrowser/win/BrowserView.cpp:
1796         (BrowserView::create):
1797         Ditto.
1798         * WebKitTestRunner/TestController.cpp:
1799         (WTR::createOtherPage):
1800         Ditto.
1801         (WTR::TestController::initialize):
1802         Ditto.
1803
1804 2010-12-08  Antonio Gomes  <agomes@rim.com>
1805
1806         Reviewed by Martin Robinson.
1807
1808         [Gtk] Populate DumpRenderTreeSupportGtk (part III)
1809         https://bugs.webkit.org/show_bug.cgi?id=48429
1810
1811         Moved the following methods from webkitprivate.h to DumpRenderTreeSupportGtk.cpp|h:
1812         * webkit_gc_collect_javascript_objects;
1813         * webkit_gc_collect_javascript_objects_on_alternate_thread;
1814         * webkit_gc_count_javascript_objects;
1815         * webkit_web_frame_layout.
1816
1817         These were all only used by GTK+ DRT.
1818
1819         * DumpRenderTree/gtk/EventSender.cpp:
1820         (dispatchEvent):
1821         * DumpRenderTree/gtk/GCControllerGtk.cpp:
1822         (GCController::collect):
1823         (GCController::collectOnAlternateThread):
1824         (GCController::getJSObjectCount):
1825
1826 2010-12-07  Tony Chang  <tony@chromium.org>
1827
1828         Reviewed by Ojan Vafai.
1829
1830         [chromium] force NRWT to use DRT
1831         https://bugs.webkit.org/show_bug.cgi?id=50359
1832
1833         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1834
1835 2010-12-06  Sam Weinig  <sam@webkit.org>
1836
1837         Reviewed by Anders Carlsson.
1838
1839         Generalize didChangeLocationWithinPageForFrame for all same document navigations
1840         https://bugs.webkit.org/show_bug.cgi?id=50584
1841
1842         * MiniBrowser/mac/BrowserWindowController.m:
1843         (didSameDocumentNavigationForFrame):
1844         (-[BrowserWindowController awakeFromNib]):
1845         (-[BrowserWindowController didSameDocumentNavigationForFrame:]):
1846         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
1847         (TestWebKitAPI::didSameDocumentNavigationForFrame):
1848         (TestWebKitAPI::TEST):
1849         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1850         (WTR::InjectedBundlePage::InjectedBundlePage):
1851         (WTR::InjectedBundlePage::didSameDocumentNavigationForFrame):
1852         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1853         * WebKitTestRunner/TestController.cpp:
1854         (WTR::TestController::initialize):
1855
1856 2010-12-06  Kinuko Yasuda  <kinuko@chromium.org>
1857
1858         Reviewed by Ojan Vafai.
1859
1860         Make TestResultsServer return 404 for non-existing results files.
1861         https://bugs.webkit.org/show_bug.cgi?id=50581
1862
1863         * TestResultServer/handlers/testfilehandler.py:
1864
1865 2010-12-06  Tony Chang  <tony@chromium.org>
1866
1867         Reviewed by Ojan Vafai.
1868
1869         [chromium] fix an assert hit in DRT
1870         https://bugs.webkit.org/show_bug.cgi?id=50575
1871
1872         This class uses WTF's RefPtr, but expects chrome's base::RefPtr
1873         semantics.
1874
1875         Otherwise, we hit ASSERTION FAILED: !m_adoptionIsRequired
1876         (third_party/WebKit/JavaScriptCore/wtf/RefCounted.h:37 void
1877         WTF::RefCountedBase::ref()).
1878
1879         * DumpRenderTree/chromium/TestWebWorker.h:
1880         (TestWebWorker::TestWebWorker):
1881
1882 2010-12-02  Ojan Vafai  <ojan@chromium.org>
1883
1884         Reviewed by Eric Seidel.
1885
1886         make webkit-patch command work when the git branch is not synced to the remote svn branch
1887         https://bugs.webkit.org/show_bug.cgi?id=50424
1888
1889         * Scripts/webkitpy/common/checkout/scm.py:
1890         * Scripts/webkitpy/common/checkout/scm_unittest.py:
1891
1892 2010-12-06  Patrick Gansterer  <paroga@webkit.org>
1893
1894         Reviewed by Andreas Kling.
1895
1896         [WINCE] Add build system
1897         https://bugs.webkit.org/show_bug.cgi?id=50522
1898
1899         * CMakeListsWinCE.txt: Added.
1900
1901 2010-12-03  Mihai Parparita  <mihaip@chromium.org>
1902
1903         Reviewed by Tony Chang.
1904
1905         Allow the Chromium port to have Leopard-specific baselines
1906         https://bugs.webkit.org/show_bug.cgi?id=50506
1907
1908         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1909
1910 2010-12-03  Tony Chang  <tony@chromium.org>
1911
1912         Reviewed by Kent Tamura.
1913
1914         [chromium] fix 2 bugs with inspector tests in DRT
1915         https://bugs.webkit.org/show_bug.cgi?id=50492
1916
1917         Tasks can outlive the tasklist (even when canceled) so this was
1918         causing a crash when ~WebTask() ran.  Avoid this by unregistering
1919         when a task is canceled.
1920
1921         Also fix an assert when closing devtool windows by copying some
1922         logic from test_shell.
1923
1924         * DumpRenderTree/chromium/Task.cpp:
1925         (WebTask::~WebTask):
1926         (TaskList::revokeAll):
1927         * DumpRenderTree/chromium/Task.h: Canceling a task now removes it from
1928             the tasklist (since the task can outlive the tasklist).
1929         * DumpRenderTree/chromium/TestShell.h:
1930         (TestShell::devToolsWebView):
1931         * DumpRenderTree/chromium/WebViewHost.cpp:
1932         (WebViewHost::~WebViewHost): Don't load about:blank when closing
1933             a window if the window has devtools loaded.  This avoids an
1934             ASSERT and matches test_shell.
1935
1936 2010-12-06  Alejandro G. Castro  <alex@igalia.com>
1937
1938         Reviewed by Martin Robinson.
1939
1940         [GTK] Fix GtkLauncher.c style, use webkit style
1941         https://bugs.webkit.org/show_bug.cgi?id=50542
1942
1943         * GtkLauncher/main.c:
1944         (activateUriEntryCb):
1945         (updateTitle):
1946         (linkHoverCb):
1947         (notifyTitleCb):
1948         (notifyLoadStatusCb):
1949         (notifyProgressCb):
1950         (destroyCb):
1951         (goBackCb):
1952         (goForwardCb):
1953         (create_webViewCb):
1954         (webViewReadyCb):
1955         (closeWebViewCb):
1956         (createBrowser):
1957         (createStatusbar):
1958         (createToolbar):
1959         (createWindow):
1960         (main):
1961
1962 2010-12-04  Antonio Gomes  <agomes@rim.com>
1963
1964         Reviewed by Martin Robinson.
1965
1966         [Gtk] Populate DumpRenderTreeSupportGtk (Part II)
1967         https://bugs.webkit.org/show_bug.cgi?id=48429
1968
1969         Moved more private method declared with WEBKIT_API to
1970         DumpRenderTreeSupportGtk, since they were only being used by DRT.
1971
1972         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1973         (resetDefaultsToConsistentValues):
1974         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1975         (LayoutTestController::addOriginAccessWhitelistEntry):
1976         (LayoutTestController::execCommand):
1977         (LayoutTestController::isCommandEnabled):
1978
1979 2010-12-04  Antonio Gomes  <agomes@rim.com>
1980
1981         Reviewed by Andreas Kling.
1982
1983         Removed extern webkit_web_view_set_group_name from gtk/DumpRenderTree.cpp
1984
1985         Method was removed by http://trac.webkit.org/changeset/71604
1986
1987         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1988
1989 2010-12-05  Alejandro G. Castro  <alex@igalia.com>
1990
1991         Reviewed by Xan Lopez.
1992
1993         [GTK] Fix compilation warnings reported by clang
1994         https://bugs.webkit.org/show_bug.cgi?id=50252
1995
1996         * GtkLauncher/main.c:
1997         (create_window): The create_statusbar function does not have
1998         parameters.
1999
2000 2010-12-05  Robert Hogan  <robert@webkit.org>
2001
2002         Reviewed by Andreas Kling.
2003
2004         [Qt] Zero-sized font does not yet work
2005
2006         Fix fast/text/font-size-zero.html
2007
2008         Copy other ports by setting minimumFontSize to 0 for DRT runs.
2009
2010         https://bugs.webkit.org/show_bug.cgi?id=49759
2011
2012         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2013         (WebCore::WebPage::WebPage):
2014
2015 2010-12-04  Sam Weinig  <sam@webkit.org>
2016
2017         Reviewed by Jon Honeycutt.
2018
2019         WebKit2: Need client functions to notify app when the url changes due to a fragment navigation
2020         https://bugs.webkit.org/show_bug.cgi?id=50511
2021
2022         Update tools for new didChangeLocationWithinPageForFrame client function (and changed bundle
2023         signature) and added a test for the functionality (PageLoadDidChangeLocationWithinPageForFrame.cpp)
2024
2025         * MiniBrowser/mac/BrowserWindowController.m:
2026         (didChangeLocationWithinPageForFrame):
2027         (-[BrowserWindowController awakeFromNib]):
2028         (-[BrowserWindowController didChangeLocationWithinPageForFrame:]):
2029         * TestWebKitAPI/PlatformUtilities.cpp:
2030         (TestWebKitAPI::Util::toWK):
2031         * TestWebKitAPI/PlatformUtilities.h:
2032         (TestWebKitAPI::Util::adoptWK):
2033         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2034         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp: Added.
2035         (TestWebKitAPI::nullJavaScriptCallback):
2036         (TestWebKitAPI::didFinishLoadForFrame):
2037         (TestWebKitAPI::didChangeLocationWithinPageForFrame):
2038         (TestWebKitAPI::TEST):
2039         * TestWebKitAPI/Tests/WebKit2/file-with-anchor.html: Added.
2040         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2041         * TestWebKitAPI/win/copy-resources.cmd:
2042         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2043         (WTR::InjectedBundlePage::InjectedBundlePage):
2044         (WTR::InjectedBundlePage::didChangeLocationWithinPageForFrame):
2045         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2046         * WebKitTestRunner/TestController.cpp:
2047         (WTR::TestController::initialize):
2048
2049 2010-11-08  Antonio Gomes  <agomes@rim.com>
2050
2051         Reviewed by Martin Robinson.
2052
2053         [Gtk] Populate DumpRenderTreeSupportGtk
2054         https://bugs.webkit.org/show_bug.cgi?id=48429
2055
2056         Made the previous calls to webkit_web_frame* functions defined as private
2057         APIs in webkitprivate.h go through DRTSupportGtk.
2058
2059         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
2060         (AccessibilityController::focusedElement):
2061         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2062         (dumpFramesAsText):
2063         (resetDefaultsToConsistentValues):
2064         (dump):
2065         (webViewDocumentLoadFinished):
2066         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2067         (LayoutTestController::counterValueForElementById):
2068         (LayoutTestController::pageNumberForElementById):
2069         (LayoutTestController::numberOfPages):
2070         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
2071         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
2072         (LayoutTestController::sampleSVGAnimationForElementAtTime):
2073         (LayoutTestController::numberOfActiveAnimations):
2074         (LayoutTestController::suspendAnimations):
2075         (LayoutTestController::resumeAnimations):
2076         (LayoutTestController::markerTextForListItem):
2077
2078 2010-12-03  Mihai Parparita  <mihaip@chromium.org>
2079
2080         Reviewed by Tony Chang.
2081
2082         Rebaseline server: use pretty text diff output
2083         https://bugs.webkit.org/show_bug.cgi?id=50484
2084         
2085         Serve *-pretty-diff.html for text diff output.
2086
2087         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
2088         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
2089         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
2090         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
2091
2092 2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
2093
2094         Unreviewed, rolling out r73302.
2095         http://trac.webkit.org/changeset/73302
2096         https://bugs.webkit.org/show_bug.cgi?id=50499
2097
2098         Causes crashes in debug LayoutTests (Requested by xan_ on
2099         #webkit).
2100
2101         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
2102         (AccessibilityUIElement::AccessibilityUIElement):
2103         (AccessibilityUIElement::parentElementCallback):
2104         * DumpRenderTree/chromium/AccessibilityUIElement.h:
2105         * DumpRenderTree/chromium/CppBoundClass.cpp:
2106         * DumpRenderTree/chromium/CppBoundClass.h:
2107
2108 2010-12-03  Sam Weinig  <sam@webkit.org>
2109
2110         Reviewed by Maciej Stachowiak.
2111
2112         Enable <a ping> for Mac/Windows/WebKit2 builds
2113         <rdar://problem/8504473>
2114         https://bugs.webkit.org/show_bug.cgi?id=50488
2115
2116         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
2117         (TestWebKitAPI::TEST): Test that the default value of
2118         WKPreferencesGetHyperlinkAuditingEnabled is true.
2119
2120 2010-12-03  Chris Guillory  <chris.guillory@google.com>
2121
2122         Reviewed by Chris Fleizach.
2123
2124         Include the FrameView widget of a RenderWidget in the accessibility tree.
2125         https://bugs.webkit.org/show_bug.cgi?id=49106
2126
2127         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
2128         (AccessibilityUIElement::AccessibilityUIElement):
2129         (AccessibilityUIElement::parentElementCallback):
2130         (AccessibilityUIElement::isEqualCallback):
2131         * DumpRenderTree/chromium/AccessibilityUIElement.h:
2132         * DumpRenderTree/chromium/CppBoundClass.cpp:
2133         (CppBoundClass::getFromCppVariant):
2134         * DumpRenderTree/chromium/CppBoundClass.h:
2135
2136 2010-12-03  Mihai Parparita  <mihaip@chromium.org>
2137
2138         Reviewed by Tony Chang.
2139
2140         Rebaseline server: organize tests by state, add dry run mode
2141         https://bugs.webkit.org/show_bug.cgi?id=50473
2142         
2143         Group tests in the menu by state, so that it's easier to see after
2144         processing the queue which failed.
2145         
2146         Add support for the --dry-run flag so that it's easier to test changes
2147         such as this (stubs out filesystem and SCM operations).
2148
2149         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
2150         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js:
2151         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
2152
2153 2010-12-03  Brady Eidson  <beidson@apple.com>
2154
2155         Reviewed by Anders Carlsson.
2156
2157         Groundwork for <rdar://problem/7660733> and https://bugs.webkit.org/show_bug.cgi?id=50191
2158         WebKit2 Authentication Support
2159
2160         Keep these builds working:
2161         * MiniBrowser/mac/BrowserWindowController.m:
2162         (-[BrowserWindowController awakeFromNib]):
2163
2164         * WebKitTestRunner/TestController.cpp:
2165         (WTR::TestController::initialize):
2166
2167 2010-12-02  Mihai Parparita  <mihaip@chromium.org>
2168
2169         Reviewed by Tony Chang.
2170
2171         Rebaseline server: move existing baselines
2172         https://bugs.webkit.org/show_bug.cgi?id=50421
2173         
2174         Implement moving of existing baselines: move all files that are about
2175         to be overwriten by update baselines.
2176         
2177         Also fix a typo in the UI JS.
2178
2179         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js:
2180         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
2181         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py:
2182
2183 2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
2184
2185         Unreviewed, rolling out r73211.
2186         http://trac.webkit.org/changeset/73211
2187         https://bugs.webkit.org/show_bug.cgi?id=50450
2188
2189         Broke Chromium's "Webkit Win (dbg)(2)" bot. (Requested by
2190         yutak on #webkit).
2191
2192         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2193
2194 2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
2195
2196         Unreviewed, rolling out r73222.
2197         http://trac.webkit.org/changeset/73222
2198         https://bugs.webkit.org/show_bug.cgi?id=50449
2199
2200         r73211 seemed to break Chromium's "Webkit Win (dbg)(2)" bot.
2201         (Requested by yutak on #webkit).
2202
2203         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2204         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
2205         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
2206         * Scripts/webkitpy/layout_tests/port/base.py:
2207         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2208         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2209
2210 2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
2211
2212         Unreviewed, rolling out r73228.
2213         http://trac.webkit.org/changeset/73228
2214         https://bugs.webkit.org/show_bug.cgi?id=50448
2215
2216         r73211 seemed to break Chromium's "Webkit Win (dbg)(2)" bot.
2217         (Requested by yutak on #webkit).
2218
2219         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2220         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
2221         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
2222         * Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py:
2223         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
2224
2225 2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
2226
2227         Unreviewed, rolling out r73231.
2228         http://trac.webkit.org/changeset/73231
2229         https://bugs.webkit.org/show_bug.cgi?id=50443
2230
2231         r73211 seemed to broke Chromium's "Webkit Win (dbg)(2)" bot.
2232         (Requested by yutak on #webkit).
2233
2234         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
2235         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
2236         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2237         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2238
2239 2010-12-03  David Levin  <levin@chromium.org>
2240
2241         Reviewed by Shinichiro Hamaji.
2242
2243         check-webkit-style: false positive reported for #if macro
2244         https://bugs.webkit.org/show_bug.cgi?id=48242
2245
2246         * Scripts/webkitpy/style/checkers/cpp.py: Adjusted check to avoid
2247           all preprocessor commands.
2248         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added test.
2249
2250 2010-12-02  Eric Seidel  <eric@webkit.org>
2251
2252         Reviewed by Adam Barth.
2253
2254         Update the EWSTools scripts to use modern-style git repos
2255         https://bugs.webkit.org/show_bug.cgi?id=50402
2256
2257         * EWSTools/create-webkit-git:
2258         * EWSTools/start-commit-queue.sh:
2259         * EWSTools/start-queue.sh:
2260
2261 2010-12-02  Simon Fraser  <simon.fraser@apple.com>
2262
2263         Fix Chromium Linux plugin tests by not logging
2264         unconditionally from the event handling code.
2265
2266         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2267         (handleEventX11):
2268
2269 2010-12-02  Dirk Pranke  <dpranke@chromium.org>
2270
2271         Reviewed by Tony Chang.
2272
2273         nrwt multiprocessing - move logic back into run_webkit_tests
2274
2275         This change moves a bunch of logic that I had put into
2276         message_broker back into run_webkit_tests, in a slightly
2277         different format. WorkerMessageBroker needed to become less aware of
2278         the logic the TestRunner class uses, and more generic.
2279         Eventually the MessageBroker will only do generic messaging and
2280         thread/process-pooling, and (almost) all of the
2281         run-webkit-tests-specific logic will be moved to
2282         run_webkit_tests.py and dump_render_tree_thread.py.
2283         
2284         The biggest changes are that the Broker can now start a single
2285         worker, but the responsibility for starting all of them is pushed
2286         back to the TestRunner (Manager), and the logic for checking if
2287         the threads are done or wedged is moved back to TestRunner. We
2288         also remove WorkerMessageBroker.cleanup (not needed) and
2289         cancel_workers (they have to be cancelled individually).
2290         
2291         The  message_broker is now encapsulated inside
2292         TestRunner._run_tests(); it only needs to exist while actually
2293         running the tests.
2294
2295         Also, delete a bunch of tests in message_broker_unittest that no
2296         longer make much sense.
2297
2298         This patch depends on bug 50372.
2299
2300         https://bugs.webkit.org/show_bug.cgi?id=50374
2301
2302         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2303         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
2304         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
2305         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2306         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2307
2308 2010-12-02  Hayato Ito  <hayato@chromium.org>
2309
2310         Reviewed by Eric Seidel.
2311
2312         Refactor test_types's compare_output() method so that it takes a
2313         TestInput object.
2314
2315         compare_output() will need additional information included in a TestInput
2316         object to support reftests. This change is a pre-requirement of that.
2317
2318         https://bugs.webkit.org/show_bug.cgi?id=50362
2319
2320         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2321         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
2322         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
2323         * Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py:
2324         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
2325
2326 2010-12-02  Simon Fraser  <simon.fraser@apple.com>
2327
2328         Reviewed by Anders Carlsson.
2329
2330         Add the ability to run script on 'new' and 'paint' in the test plugin
2331         https://bugs.webkit.org/show_bug.cgi?id=50425
2332         
2333         Add "onnew" and "onpaintevent" attributes to the test plugin,
2334         so that tests can run JS at these times.
2335
2336         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
2337         (pluginAllocate):
2338         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
2339         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2340         (NPP_New):
2341         (NPP_Destroy):
2342         (handleEventCarbon):
2343         (handleEventCocoa):
2344         (NPP_HandleEvent):
2345
2346 2010-12-02  Sam Weinig  <sam@webkit.org>
2347
2348         Fix Qt build.
2349
2350         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2351         (WTR::PlatformWebView::PlatformWebView):
2352
2353 2010-12-02  Sam Weinig  <sam@webkit.org>
2354
2355         Reviewed by Anders Carlsson.
2356
2357         WebKit2 Preferences should be held off the PageGroup, not the Context
2358         https://bugs.webkit.org/show_bug.cgi?id=50414
2359
2360         Update for API changes.
2361
2362         * WebKitTestRunner/PlatformWebView.h:
2363         * WebKitTestRunner/TestController.cpp:
2364         (WTR::createOtherPage):
2365         (WTR::TestController::initialize):
2366         (WTR::TestController::resetStateToConsistentValues):
2367         * WebKitTestRunner/TestController.h:
2368         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2369         (WTR::PlatformWebView::PlatformWebView):
2370         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2371         (WTR::PlatformWebView::PlatformWebView):
2372
2373 2010-12-02  Dirk Pranke  <dpranke@chromium.org>
2374
2375         Reviewed by Tony Chang.
2376
2377         new-run-webkit-tests: minor cleanup for multiprocessing work
2378
2379         This change:
2380         * moves worker naming into TestShellThread, eliminating a
2381           parameter to the constructor and putting the responsibility in
2382           the correct place.
2383         * eliminates the _WorkerState() class in message_broker, because
2384           it turns out that state really needs to be in run_webkit_tests
2385         * renames the Broker classes to be module-private.
2386         * fixes a bunch of minor commenting and whitespace issues to
2387           make subsequent patches a bit clearer.
2388         * Adds a Port hook for default_worker_model() so that we can
2389           accomodate the potential for different worker models on
2390           different ports.
2391         * merge in the fix from 50420 for the brokenness introduced in
2392           bug 50367.
2393
2394         This patch depends on bug 50367.
2395
2396         https://bugs.webkit.org/show_bug.cgi?id=50372
2397
2398         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2399         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
2400         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
2401         * Scripts/webkitpy/layout_tests/port/base.py:
2402         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2403         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2404
2405 2010-12-02  Dirk Pranke  <dpranke@chromium.org>
2406
2407         Reviewed by Tony Chang.
2408
2409         This change is a bunch of cleanup / refactoring of the file
2410         below. It moves a bunch of free functions to methods on the
2411         TestShellThread class, and restructures other methods to be
2412         closer to the structure we'll need for the multiprocessing
2413         rewrite.
2414
2415         It also makes the logic of --run-singly a *lot* easier to follow
2416         by nestling all of the separate-thread logic into a single
2417         routine.
2418
2419         There should be no semantic changes in this patch, just cleanup.
2420
2421         https://bugs.webkit.org/show_bug.cgi?id=50367
2422
2423         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2424
2425 2010-12-02  Tony Chang  <tony@chromium.org>
2426
2427         Unreviewed, rolling out r73164.
2428         http://trac.webkit.org/changeset/73164
2429         https://bugs.webkit.org/show_bug.cgi?id=50359
2430
2431         broke debugger tests on win
2432
2433         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2434
2435 2010-11-30  Mihai Parparita  <mihaip@chromium.org>
2436
2437         Reviewed by Tony Chang.
2438
2439         Rebaseline server: add updating of baselines
2440         https://bugs.webkit.org/show_bug.cgi?id=50305
2441         
2442         Implements updating of baselines, where we copy -actual.* files over
2443         the current -expected.* files. To do this, we need a
2444         _get_actual_result_files method to get test results files and a
2445         _rebaseline_test method to actually do the file copy and SCM operation.
2446         _rebaseline_test logs output into a buffer, this is useful for both
2447         showing result in the UI and for unit tests.
2448         
2449         To make passing around of the various test environment properties
2450         (results directory, filesystem, SCM, etc) easier, add a TestConfig
2451         class for them.
2452         
2453         Moving of existing baselines is not implemented yet, this patch is big
2454         enough as it is.
2455
2456         * Scripts/webkitpy/common/system/filesystem.py:
2457         * Scripts/webkitpy/common/system/filesystem_mock.py:
2458         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js:
2459         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
2460         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py:
2461         * Scripts/webkitpy/tool/mocktool.py:
2462
2463 2010-12-02  Brent Fulgham  <bfulgham@webkit.org>
2464
2465         Unreviewed build fix after vcproj updates.
2466
2467         * DumpRenderTree/win/DumpRenderTreeCairo.vsprops: Make sure
2468         that WIN_CAIRO is defined for this build.
2469         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd: Update file
2470         to reflect new 'Debug_Cairo_CFLite' and 'Release_Cairo_CFLite'
2471         (these were previously 'Debug_Cairo' and 'Release_Cairo'
2472
2473 2010-12-02  Sam Weinig  <sam@webkit.org>
2474
2475         Reviewed by Anders Carlsson.
2476
2477         WebKit2 needs API to turn on popup blocking
2478         https://bugs.webkit.org/show_bug.cgi?id=50407
2479
2480         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
2481         (TestWebKitAPI::TEST):
2482         * WebKitTestRunner/TestController.cpp:
2483         (WTR::TestController::resetStateToConsistentValues):
2484
2485 2010-12-01  Tony Chang  <tony@chromium.org>
2486
2487         Reviewed by Ojan Vafai.
2488
2489         [chromium] force NRWT to use DRT
2490         https://bugs.webkit.org/show_bug.cgi?id=50359
2491
2492         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2493
2494 2010-12-02  Martin Robinson  <mrobinson@igalia.com>
2495
2496         Reviewed by Xan Lopez.
2497
2498         [GTK] DumpRenderTree has two copies of JavaScriptCore
2499         https://bugs.webkit.org/show_bug.cgi?id=49877
2500
2501         * GNUmakefile.am: Remove the second copy of JavaScriptCore from the
2502         LDADD list for DumpRenderTree.
2503
2504 2010-12-02  Sergio Villar Senin  <svillar@igalia.com>
2505
2506         Unreviewed: Added myself to list of Committers.
2507
2508         * Scripts/webkitpy/common/config/committers.py:
2509
2510 2010-12-01  Mihai Parparita  <mihaip@chromium.org>
2511
2512         Reviewed by Adam Barth.
2513
2514         build-webkit --chromium always updates DEPS and re-generates project files
2515         https://bugs.webkit.org/show_bug.cgi?id=50340
2516         
2517         Make build-webkit --chromium invoke update-webkit-chromium only when
2518         --update-chromium is passed in, so that we don't add 20 seconds to all
2519         builds.
2520         
2521         Making all invocations update was added with r61883, with the goal of
2522         making EWS bots always update. The bots will switch to using this flag
2523         (as will all other webkit-patch build steps) so nothing should change
2524         for them.
2525
2526         * Scripts/webkitdirs.pm:
2527         * Scripts/webkitpy/common/config/ports.py:
2528         * Scripts/webkitpy/common/config/ports_unittest.py:
2529
2530 2010-12-01  Dirk Pranke  <dpranke@chromium.org>
2531
2532         Reviewed by Tony Chang.
2533
2534         new-run-webkit-tests: add a --dry-run / -n flag
2535         https://bugs.webkit.org/show_bug.cgi?id=50045
2536
2537         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2538         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2539
2540 2010-12-01  Steve Falkenburg  <sfalken@apple.com>
2541
2542         Reviewed by Adam Roben.
2543
2544         WinCairo build should not use link-time code generation (LTCG)
2545         https://bugs.webkit.org/show_bug.cgi?id=50353
2546
2547         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2548         * DumpRenderTree/win/DumpRenderTree.vcproj:
2549         * DumpRenderTree/win/ImageDiff.vcproj:
2550         * FindSafari/FindSafari.vcproj:
2551         * MiniBrowser/MiniBrowser.vcproj:
2552         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2553         * WebKitAPITest/WebKitAPITest.vcproj:
2554         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
2555         * WebKitTestRunner/win/InjectedBundle.vcproj:
2556         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
2557         * WinLauncher/WinLauncher.vcproj:
2558         * record-memory-win/record-memory-win.vcproj:
2559
2560 2010-12-01  Martin Robinson  <mrobinson@igalia.com>
2561
2562         Touch GetUserAgentWithNullNPPFromNPPNew.cpp in an effort to force
2563         a rebuild of TestNetscapePlugin.la on GTK+. It seems that simply
2564         adding the file to the sources list was not enough to force the rebuild.
2565
2566         * DumpRenderTree/TestNetscapePlugIn/Tests/GetUserAgentWithNullNPPFromNPPNew.cpp:
2567         Remove an empty line at the end of this file to force a rebuild.
2568
2569 2010-12-01  Sam Weinig  <sam@webkit.org>
2570
2571         Fix windows build.
2572
2573         * MiniBrowser/win/BrowserView.cpp:
2574         (BrowserView::create):
2575
2576 2010-12-01  Martin Robinson  <mrobinson@igalia.com>
2577
2578         Add missing file to the TestNetscapePlugin sources list after r73057.
2579
2580         * GNUmakefile.am: Add missing file.
2581
2582 2010-12-01  Sam Weinig  <sam@webkit.org>
2583
2584         Reviewed by Anders Carlsson.
2585
2586         Add PageGrouping to WebKit2 API
2587         https://bugs.webkit.org/show_bug.cgi?id=50332
2588
2589         - Update testing harnesses to deal with new PageGroup API.
2590
2591         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
2592         (WKBundleInitialize):
2593         * TestWebKitAPI/InjectedBundleController.cpp:
2594         (TestWebKitAPI::InjectedBundleController::initialize):
2595         (TestWebKitAPI::InjectedBundleController::didInitializePageGroup):
2596         (TestWebKitAPI::InjectedBundleController::initializeTestNamed):
2597         * TestWebKitAPI/InjectedBundleController.h:
2598         * TestWebKitAPI/InjectedBundleTest.h:
2599         (TestWebKitAPI::InjectedBundleTest::initialize):
2600         (TestWebKitAPI::InjectedBundleTest::didInitializePageGroup):
2601         * TestWebKitAPI/PlatformUtilities.cpp:
2602         (TestWebKitAPI::Util::createContextForInjectedBundleTest):
2603         * TestWebKitAPI/PlatformUtilities.h:
2604         * TestWebKitAPI/PlatformWebView.h:
2605         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
2606         (TestWebKitAPI::TEST):
2607         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp:
2608         (TestWebKitAPI::DocumentStartUserScriptAlertCrashTest::initialize):
2609         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
2610         (TestWebKitAPI::PlatformWebView::PlatformWebView):
2611         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
2612         (TestWebKitAPI::PlatformWebView::PlatformWebView):
2613         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2614         (WTR::InjectedBundle::didInitializePageGroup):
2615         (WTR::InjectedBundle::initialize):
2616         (WTR::InjectedBundle::beginTesting):
2617         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2618         (WTR::InjectedBundle::pageGroup):
2619         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2620         (WTR::LayoutTestController::addUserScript):
2621         (WTR::LayoutTestController::addUserStyleSheet):
2622         (WTR::LayoutTestController::setXSSAuditorEnabled):
2623         * WebKitTestRunner/TestController.cpp:
2624         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2625         (WTR::PlatformWebView::PlatformWebView):
2626
2627 2010-12-01  Steve Falkenburg  <sfalken@apple.com>
2628
2629         Reviewed by Adam Roben.
2630
2631         vcproj changes can't be applied cleanly by the Windows EWS bot
2632         https://bugs.webkit.org/show_bug.cgi?id=50328
2633
2634         * CLWrapper/CLWrapper.sln: Modified property svn:eol-style.
2635         * CLWrapper/CLWrapper.vcproj: Modified property svn:eol-style.
2636         * DumpRenderTree/DumpRenderTree.sln: Modified property svn:eol-style.
2637         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops: Added property svn:eol-style.
2638         * DumpRenderTree/win/DumpRenderTree.vcproj: Modified property svn:eol-style.
2639         * DumpRenderTree/win/DumpRenderTreeApple.vsprops: Added property svn:eol-style.
2640         * DumpRenderTree/win/DumpRenderTreeCFLite.vsprops: Added property svn:eol-style.
2641         * DumpRenderTree/win/DumpRenderTreeCairo.vsprops: Added property svn:eol-style.
2642         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops: Added property svn:eol-style.
2643         * DumpRenderTree/win/ImageDiff.vcproj: Modified property svn:eol-style.
2644         * DumpRenderTree/win/ImageDiffCommon.vsprops: Added property svn:eol-style.
2645         * FindSafari/FindSafari.vcproj: Modified property svn:eol-style.
2646         * FindSafari/FindSafariCommon.vsprops: Added property svn:eol-style.
2647         * MIDLWrapper/MIDLWrapper.sln: Modified property svn:eol-style.
2648         * MIDLWrapper/MIDLWrapper.vcproj: Modified property svn:eol-style.
2649         * MiniBrowser/Configurations/MiniBrowserCFLite.vsprops: Added property svn:eol-style.
2650         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops: Added property svn:eol-style.
2651         * MiniBrowser/Configurations/MiniBrowserCoreFoundation.vsprops: Added property svn:eol-style.
2652         * MiniBrowser/MiniBrowser.vcproj: Added property svn:eol-style.
2653         * TestWebKitAPI/Configurations/TestWebKitAPICFLite.vsprops: Added property svn:eol-style.
2654         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops: Added property svn:eol-style.
2655         * TestWebKitAPI/Configurations/TestWebKitAPICoreFoundation.vsprops: Added property svn:eol-style.
2656         * TestWebKitAPI/win/TestWebKitAPI.sln: Added property svn:eol-style.
2657         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Added property svn:eol-style.
2658         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj: Added property svn:eol-style.
2659         * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops: Added property svn:eol-style.
2660         * WebKitAPITest/WebKitAPITest.vcproj: Added property svn:eol-style.
2661         * WebKitAPITest/WebKitAPITestCommon.vsprops: Added property svn:eol-style.
2662         * WebKitLauncherWin/WebKitLauncherWin.vcproj: Modified property svn:eol-style.
2663         * WebKitLauncherWin/WebKitLauncherWinCommon.vsprops: Added property svn:eol-style.
2664         * WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops: Added property svn:eol-style.
2665         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops: Added property svn:eol-style.
2666         * WebKitTestRunner/Configurations/InjectedBundleCoreFoundation.vsprops: Added property svn:eol-style.
2667         * WebKitTestRunner/Configurations/WebKitTestRunnerCFLite.vsprops: Added property svn:eol-style.
2668         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops: Added property svn:eol-style.
2669         * WebKitTestRunner/Configurations/WebKitTestRunnerCoreFoundation.vsprops: Added property svn:eol-style.
2670         * WebKitTestRunner/WebKitTestRunner.sln: Added property svn:eol-style.
2671         * WebKitTestRunner/win/InjectedBundle.vcproj: Added property svn:eol-style.
2672         * WebKitTestRunner/win/InjectedBundleGenerated.vcproj: Added property svn:eol-style.
2673         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops: Added property svn:eol-style.
2674         * WebKitTestRunner/win/WebKitTestRunner.vcproj: Added property svn:eol-style.
2675         * WinLauncher/WinLauncher.vcproj: Modified property svn:eol-style.
2676         * WinLauncher/WinLauncherCommon.vsprops: Added property svn:eol-style.
2677         * record-memory-win/record-memory-win-common.vsprops: Added property svn:eol-style.
2678         * record-memory-win/record-memory-win.vcproj: Modified property svn:eol-style.
2679
2680 2010-12-01  Anders Carlsson  <andersca@apple.com>
2681
2682         Reviewed by Darin Adler.
2683
2684         Return a correct user agent if NPN_UserAgent is called with a null NPP from NPP_New.
2685         https://bugs.webkit.org/show_bug.cgi?id=50336
2686
2687         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2688         Add new test.
2689
2690         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
2691         (PluginTest::NPP_New):
2692         Add default implementation/
2693
2694         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
2695         * DumpRenderTree/TestNetscapePlugIn/Tests/GetUserAgentWithNullNPPFromNPPNew.cpp: Added.
2696         (GetUserAgentWithNullNPPFromNPPNew::GetUserAgentWithNullNPPFromNPPNew):
2697         (GetUserAgentWithNullNPPFromNPPNew::NPP_New):
2698         Get the user agent.
2699
2700         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2701         (NPP_New):
2702         Call PluginTest::NPP_New.
2703
2704         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2705         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2706         Add new files.
2707
2708         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2709         (webkit_test_plugin_new_instance):
2710         Call PluginTest::NPP_New.
2711
2712 2010-12-01  Kevin Ollivier  <kevino@theolliviers.com>
2713
2714         [wx] Build fixes after recent trunk changes.
2715
2716         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2717         (LayoutTestController::findString):
2718         * wx/build/settings.py:
2719
2720 2010-12-01  Dan Bernstein  <mitz@apple.com>
2721
2722         Reviewed by Darin Adler.
2723
2724         WebKitTestRunner needs layoutTestController.findString
2725         https://bugs.webkit.org/show_bug.cgi?id=50238
2726
2727         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Added findString().
2728         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2729         (WTR::LayoutTestController::findString): Updated signature for autogenerated bindings.
2730         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Ditto.
2731
2732 2010-12-01  Steve Falkenburg  <sfalken@apple.com>
2733
2734         Try using svn:eol-style native on a vcproj file.
2735
2736         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Modified property svn:eol-style.
2737
2738 2010-12-01  Patrick Gansterer  <paroga@webkit.org>
2739
2740         Reviewed by Adam Roben.
2741
2742         [WINCE] Add WinCELauncher
2743         https://bugs.webkit.org/show_bug.cgi?id=50217
2744
2745         * WinCELauncher/main.cpp: Added.
2746
2747 2010-11-30  Benjamin Poulain  <benjamin.poulain@nokia.com>
2748
2749         Reviewed by Kenneth Rohde Christiansen.
2750
2751         [Qt] Implement layoutTestController.findString
2752         https://bugs.webkit.org/show_bug.cgi?id=50236
2753
2754         Add the missing function to the LayoutTestController.
2755
2756         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2757         (LayoutTestController::findString):
2758         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2759
2760 2010-11-30  Tony Chang  <tony@chromium.org>
2761
2762         Reviewed by Adam Barth.
2763
2764         [chromium] fix get-int-identifier-special-values.html using TestNetscapePlugIn
2765         https://bugs.webkit.org/show_bug.cgi?id=49036
2766
2767         * DumpRenderTree/chromium/LayoutTestController.cpp: Use IsNumber instead of IsInt32
2768             for CppVariants.
2769         (LayoutTestController::cppVariantToBool):
2770         (LayoutTestController::cppVariantToInt32):
2771         (LayoutTestController::setDatabaseQuota):
2772         (LayoutTestController::evaluateInWebInspector):
2773         (LayoutTestController::setMockGeolocationError):
2774
2775 2010-11-30  Eric Seidel  <eric@webkit.org>
2776
2777         Reviewed by Tony Chang.
2778
2779         update-webkit should call git fetch before git svn rebase
2780         https://bugs.webkit.org/show_bug.cgi?id=50273
2781
2782         After discussion on webkit-dev, we've decided to move the "default"
2783         git setup to pulling updates from git.webkit.org in preference
2784         to rebuilding the local svn index using git svn fetch every time.
2785
2786         This change should have no effect on people using the "old" git setup
2787         and should dramatically increase the speed of updates for those using
2788         the "new" git setup along with update-webkit.  I'm about to move the
2789         EWS and other queues over to this setup once this lands.
2790
2791         * Scripts/update-webkit:
2792
2793 2010-11-30  Mario Sanchez Prada  <msanchez@igalia.com>
2794
2795         Reviewed by Xan Lopez.
2796
2797         GTK: AX: implement press in DRT
2798         https://bugs.webkit.org/show_bug.cgi?id=36146
2799
2800         Implement AccessibilityUIElement::press() for GTK.
2801
2802         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2803         (AccessibilityUIElement::press): Implemented.
2804
2805 2010-11-29  Mihai Parparita  <mihaip@chromium.org>
2806
2807         Reviewed by Tony Chang.
2808
2809         config.webkit_base_dir returns a path with a trailing slash
2810         https://bugs.webkit.org/show_bug.cgi?id=50197
2811         
2812         config.webkit_base_dir() should return a path without a trailing slash,
2813         like all the other methods that return paths.
2814         
2815         Undoes MockFileSytem changes by r72640, since they're no longer
2816         necessary for GetBaselinesTest to pass.
2817
2818         * Scripts/webkitpy/common/system/filesystem_mock.py:
2819         * Scripts/webkitpy/layout_tests/port/base.py:
2820         * Scripts/webkitpy/layout_tests/port/config.py:
2821         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
2822
2823 2010-11-30  Mihai Parparita  <mihaip@chromium.org>
2824
2825         Reviewed by Tony Chang.
2826
2827         Rebaseline server: baseline display tweaks
2828         https://bugs.webkit.org/show_bug.cgi?id=50207
2829         
2830         Determine which baselines were used when running the tests and highlight
2831         them in the UI. Sort platform names alphabetically.
2832         
2833         Also makes the server URL be launched in the user's browser
2834         automatically.
2835
2836         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
2837         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
2838         * Scripts/webkitpy/tool/commands/data/rebaselineserver/util.js:
2839         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
2840         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py:
2841
2842 2010-11-30  Dan Bernstein  <mitz@apple.com>
2843
2844         Reviewed by Anders Carlsson.
2845
2846         <rdar://problem/8710645> WebKitTestRunner needs layoutTestController.findString
2847         https://bugs.webkit.org/show_bug.cgi?id=50238
2848
2849         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2850         (WTR::LayoutTestController::findString): Added.
2851         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2852
2853 2010-11-30  Steve Falkenburg  <sfalken@apple.com>
2854
2855         Reviewed by Adam Roben.
2856
2857         All projects on Windows should use cmd files for build events
2858         https://bugs.webkit.org/show_bug.cgi?id=50213
2859
2860         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops:
2861         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd: Added.
2862         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd: Added.
2863         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
2864         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd: Added.
2865         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd: Added.
2866         * DumpRenderTree/win/ImageDiffCommon.vsprops:
2867         * DumpRenderTree/win/ImageDiffPostBuild.cmd: Added.
2868         * DumpRenderTree/win/ImageDiffPreBuild.cmd: Added.
2869         * MiniBrowser/Configurations/MiniBrowserCFLite.vsprops:
2870         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
2871         * MiniBrowser/Configurations/MiniBrowserCoreFoundation.vsprops:
2872         * MiniBrowser/MiniBrowserPostBuild.cmd: Added.
2873         * MiniBrowser/MiniBrowserPreBuild.cmd: Added.
2874         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
2875         * TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd: Added.
2876         * TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd: Added.
2877         * WebKitAPITest/WebKitAPITestCommon.vsprops:
2878         * WebKitAPITest/WebKitAPITestPostBuild.cmd: Added.
2879         * WebKitAPITest/WebKitAPITestPreBuild.cmd: Added.
2880         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
2881         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
2882         * WebKitTestRunner/win/InjectedBundlePostBuild.cmd: Added.
2883         * WebKitTestRunner/win/InjectedBundlePreBuild.cmd: Added.
2884         * WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd: Added.
2885         * WebKitTestRunner/win/WebKitTestRunnerPreBuild.cmd: Added.
2886         * WinLauncher/WinLauncherCommon.vsprops:
2887         * WinLauncher/WinLauncherPostBuild.cmd: Added.
2888         * WinLauncher/WinLauncherPreBuild.cmd: Added.
2889
2890 2010-11-29  Dan Bernstein  <mitz@apple.com>
2891
2892         GTK DumpRenderTree build fix after r72887.
2893
2894         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2895         (LayoutTestController::findString):
2896
2897 2010-11-29  Dan Bernstein  <mitz@apple.com>
2898
2899         Windows DumpRenderTree build fix after r72887.
2900
2901         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2902         (LayoutTestController::findString): Added empty implementation.
2903
2904 2010-11-29  Dan Bernstein  <mitz@apple.com>
2905
2906         Reviewed by Darin Adler.
2907
2908         DumpRenderTree changes for testing the text search API.
2909         https://bugs.webkit.org/show_bug.cgi?id=50038
2910
2911         * DumpRenderTree/LayoutTestController.cpp:
2912         (findStringCallback):
2913         (LayoutTestController::staticFunctions):
2914         * DumpRenderTree/LayoutTestController.h:
2915         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2916         (LayoutTestController::findString):
2917         * MiniBrowser/mac/BrowserWindowController.m:
2918         (-[BrowserWindowController find:]):
2919
2920 2010-11-29  Johnny Ding  <jnd@chromium.org>
2921
2922         Unreviewed: Add myself to the list of Committers.
2923
2924         * Scripts/webkitpy/common/config/committers.py:
2925
2926 2010-11-29  Mark Rowe  <mrowe@apple.com>
2927
2928         Reviewed by Adele Peterson.
2929
2930         <rdar://problem/8694997> DumpRenderTree fails to build.
2931
2932         * DumpRenderTree/mac/PerlSupport/Makefile: Skip generating wrappers.
2933
2934 2010-11-29  Mark Rowe  <mrowe@apple.com>
2935
2936         Reviewed by Adele Peterson.
2937
2938         <rdar://problem/8694997> DumpRenderTree fails to build.
2939
2940         * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupportPregenerated.pm: Renamed from WebKitTools/DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupportTiger.pm.
2941         * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport_wrapPregenerated.c: Renamed from WebKitTools/DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport_wrapTiger.c.
2942         * DumpRenderTree/mac/PerlSupport/Makefile:
2943
2944 2010-11-29  Mario Sanchez Prada  <msanchez@igalia.com>
2945
2946         Reviewed by Martin Robinson.
2947
2948         [GTK] Null-check needed in DRT's AccessibilityUIElement::allAtributes()
2949         https://bugs.webkit.org/show_bug.cgi?id=50154
2950
2951         Added missing checks to allAttributes().
2952
2953         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2954         (AccessibilityUIElement::allAttributes): Added missing checks.
2955
2956 2010-11-29  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2957
2958         Reviewed by Kenneth Rohde Christiansen.
2959
2960         [Qt] Allow pre-generation for package builds for WebKit2
2961         https://bugs.webkit.org/show_bug.cgi?id=50139
2962
2963         Use a build variable for the generated directory path and set the
2964         value based on CONFIG just like for WebKit1.
2965
2966         For non-package builds use a relative base path for the
2967         genrated directory just like for WebKit1.
2968
2969         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2970         * WebKitTestRunner/qt/WebKitTestRunner.pro:
2971
2972 2010-11-28  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2973
2974         Reviewed by Kenneth Rohde Christiansen.
2975
2976         [Qt] Move some build logic from Qt to platform independent code
2977         https://bugs.webkit.org/show_bug.cgi?id=50134
2978
2979         Create target directories inside generate-forwarding-headers.pl.
2980
2981         * Scripts/generate-forwarding-headers.pl:
2982
2983 2010-11-24  Nicolas Dufresne  <nicolas.dufresne@collabora.co.uk>
2984
2985         Reviewed by Martin Robinson.
2986
2987         [GTK] Windowless plugins gets broken key input
2988         https://bugs.webkit.org/show_bug.cgi?id=49927
2989
2990         Convert the XEvent::keycode to ASCII before printing it. Not
2991         doing this was causing false positive in 
2992         plugins/keyboard-events.html.
2993
2994         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2995         (keycode_to_char):
2996         (webkit_test_plugin_handle_event):
2997
2998 2010-11-24  Jan Erik Hanssen  <jhanssen@sencha.com>
2999
3000         Reviewed by Antonio Gomes.
3001
3002         [Qt] Html autofocus not working with QGraphicsWebView
3003         https://bugs.webkit.org/show_bug.cgi?id=43169
3004
3005         Tell the scene to set the webview item as the currently
3006         focused item. This makes the input field with autofocus get
3007         focus as it should.
3008
3009         * QtTestBrowser/webview.cpp:
3010         (WebViewGraphicsBased::WebViewGraphicsBased):
3011
3012 2010-11-24  Dirk Pranke  <dpranke@chromium.org>
3013
3014         Reviewed by Tony Chang.
3015
3016         nrwt - clean up create_driver interface and print out the
3017         command line used for DumpRenderTree/TestShell.
3018
3019         This patch adds a driver_cmd_line() call to the Port class in
3020         order to retrive the command line to print it out (as part of
3021         --print config).
3022
3023         In addition, this patch cleans up the Port.create_driver()
3024         signature and the Driver constructor interface to take a worker
3025         number and no longer require the image_path argument (Chromium's
3026         drivers now synthesize the image_path from the worker number
3027         internally).
3028
3029         https://bugs.webkit.org/show_bug.cgi?id=49934
3030
3031         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3032         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
3033         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
3034         * Scripts/webkitpy/layout_tests/port/base.py:
3035         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3036         * Scripts/webkitpy/layout_tests/port/chromium.py:
3037         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3038         * Scripts/webkitpy/layout_tests/port/dryrun.py:
3039         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3040         * Scripts/webkitpy/layout_tests/port/test.py:
3041         * Scripts/webkitpy/layout_tests/port/webkit.py:
3042         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3043         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3044
3045 2010-11-24  Ojan Vafai  <ojan@chromium.org>
3046
3047         Reviewed by Tony Chang.
3048
3049         [chromium] improve memory usage for test results server and store fewer runs
3050         https://bugs.webkit.org/show_bug.cgi?id=50035
3051
3052         Store fewer runs and don't pass full files around when we only need bools.
3053         Greatly improves error rates on test-results.appspot.com.
3054
3055         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3056         * TestResultServer/handlers/testfilehandler.py:
3057         * TestResultServer/model/dashboardfile.py:
3058         * TestResultServer/model/jsonresults.py:
3059
3060 2010-11-24  Dirk Pranke  <dpranke@chromium.org>
3061
3062         Reviewed by Tony Chang.
3063
3064         This patch implements the first part of the manager side of the
3065         Broker objects - it handles creating threads, waiting for them
3066         to complete, and running a single-threaded loop as well.
3067
3068         https://bugs.webkit.org/show_bug.cgi?id=49779
3069
3070         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
3071         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
3072         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3073         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3074
3075 2010-11-24  Mihai Parparita  <mihaip@chromium.org>
3076
3077         Reviewed by David Levin.
3078
3079         DRT should not generate pixel output for text/plain tests
3080         https://bugs.webkit.org/show_bug.cgi?id=50002
3081         
3082         Modify Mac, Windows and GTK DRT implementations to disable pixel output
3083         when encountering a text/plain response (the Chromium one already does
3084         this, and none of the other ports special-case text/plain output in
3085         the first place).
3086
3087         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3088         (dump):
3089         * DumpRenderTree/mac/DumpRenderTree.mm:
3090         (dump):
3091         * DumpRenderTree/win/DumpRenderTree.cpp:
3092         (dump):
3093
3094 2010-11-24  Andras Becsi  <abecsi@inf.u-szeged.hu>
3095
3096         Unreviewed.
3097
3098         Add my other email address to committers.py.
3099
3100         * Scripts/webkitpy/common/config/committers.py:
3101
3102 2010-11-24  Andras Becsi  <abecsi@inf.u-szeged.hu>
3103
3104         Reviewed by Csaba Osztrogonác.
3105
3106         Make build-webkit --minimal build with ENABLE_INSPECTOR=0
3107         https://bugs.webkit.org/show_bug.cgi?id=49975
3108
3109         * Scripts/build-webkit: Add ENABLE_INSPECTOR define to features,
3110         to enable the script to define it 0 in case of a minimal build.
3111
3112 2010-11-24  Martin Robinson  <mrobinson@igalia.com>
3113
3114         Reviewed by Xan Lopez.
3115
3116         [GTK] The WebKitWebView should expose a set of signals encapsulating the behavior of the EditorClient
3117         https://bugs.webkit.org/show_bug.cgi?id=49143
3118
3119         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3120         (createWebView): Call the new connectEditingCallbacks function.
3121         * DumpRenderTree/gtk/EditingCallbacks.cpp: Added.
3122         (dumpNodePath):
3123         (dumpRange):
3124         (insertActionString):
3125         (selectionAffinityString):
3126         (shouldBeginEditing):
3127         (shouldEndEditing):
3128         (shouldInsertNode):
3129         (shouldInsertText):
3130         (shouldDeleteRange):
3131         (shouldShowDeleteInterfaceForElement):
3132         (shouldChangeSelectedRange):
3133         (shouldApplyStyle):
3134         (editingBegan):
3135         (userChangedContents):
3136         (editingEnded):
3137         (selectionChanged):
3138         (connectEditingCallbacks):
3139         * DumpRenderTree/gtk/EditingCallbacks.h: Added.
3140         * GNUmakefile.am: Added EditingCallbacks.{h,cpp} to the source list.
3141
3142 2010-11-24  Yi Shen  <yi.4.shen@nokia.com>
3143
3144         Reviewed by Andreas Kling.
3145
3146         [Qt] Make QtTestBrowser remember the selected user agent
3147         https://bugs.webkit.org/show_bug.cgi?id=50021
3148
3149         Set user agent for a new page by using the old page's
3150
3151         * QtTestBrowser/mainwindow.cpp:
3152         (MainWindow::setPage):
3153
3154 2010-11-24 Patrick Gansterer <paroga@webkit.org>
3155
3156         Reviewed by Csaba Osztrogonác.
3157
3158         Remove Bakefile build system files
3159         https://bugs.webkit.org/show_bug.cgi?id=49983
3160
3161         r53757 only removed the content, but not the files.
3162         This patch removes that empty files.
3163
3164         * DumpRenderTree/wx/DumpRenderTree.bkl: Removed.
3165         * wx/browser/browser.bkl: Removed.
3166         * wx/build-wxwebkit: Removed.
3167
3168 2010-11-23  Dirk Pranke  <dpranke@chromium.org>
3169
3170         Reviewed by Tony Chang.
3171
3172         This patch cleans up the logic used to shard tests into groups a
3173         bit and adds the --worker-model flag to NRWT. The flag is only
3174         used at the moment to control whether to run single-threaded or
3175         not, but eventually will also allow toggling between threads and
3176         processes.
3177
3178         Also add a minor cleanup with _test_is_slow(), which just
3179         eliminates some repetition and gives slightly better encapsulation.
3180
3181         https://bugs.webkit.org/show_bug.cgi?id=49773
3182
3183         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3184         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3185
3186 2010-11-23  Mihai Parparita  <mihaip@chromium.org>
3187
3188         Reviewed by Tony Chang.
3189
3190         Rebaseline server: list current baselines and platforms
3191         https://bugs.webkit.org/show_bug.cgi?id=49991
3192         
3193         List existing baselines (with Trac links) for tests.
3194         
3195         Add dropdowns for choosing with platform baselines to target (and what
3196         to do with existing ones).
3197
3198         Also fix MockFileSystem.join to behave more like os.path.join (unit
3199         test was ending up with two consecutive slashes in a layout test
3200         path).        
3201
3202         * Scripts/webkitpy/common/system/filesystem_mock.py:
3203         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
3204         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
3205         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
3206         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js:
3207         * Scripts/webkitpy/tool/commands/data/rebaselineserver/util.js:
3208         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
3209         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py: Added.
3210
3211 2010-11-23  Ojan Vafai  <ojan@chromium.org>
3212
3213         Reviewed by Tony Chang.
3214
3215         remove timeout argument to urlopen
3216         https://bugs.webkit.org/show_bug.cgi?id=49995
3217
3218         Apparently the version of python we have on the bots doesn't accept a timeout argument.
3219
3220         * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py:
3221
3222 2010-11-23  Sheriff Bot  <webkit.review.bot@gmail.com>
3223
3224         Unreviewed, rolling out r72628.
3225         http://trac.webkit.org/changeset/72628
3226         https://bugs.webkit.org/show_bug.cgi?id=49994
3227
3228         This patch is causing layout-test failtures on GTK Linux
3229         64-bit Debug (Requested by ctguil on #webkit).
3230
3231         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
3232         (AccessibilityUIElement::AccessibilityUIElement):
3233         (AccessibilityUIElement::parentElementCallback):
3234         * DumpRenderTree/chromium/AccessibilityUIElement.h:
3235         * DumpRenderTree/chromium/CppBoundClass.cpp:
3236         * DumpRenderTree/chromium/CppBoundClass.h:
3237
3238 2010-11-22  Ojan Vafai  <ojan@chromium.org>
3239
3240         Reviewed by Tony Chang.
3241
3242         speculative fix for upload errors: stop using mechanize to upload to test-results.appspot.com
3243         https://bugs.webkit.org/show_bug.cgi?id=49944
3244
3245         * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py:
3246
3247 2010-11-23  Chris Guillory  <chris.guillory@google.com>
3248
3249         Reviewed by Dimitri Glazkov.
3250
3251         Include the FrameView widget of a RenderWidget in the accessibility tree.
3252         https://bugs.webkit.org/show_bug.cgi?id=49106
3253
3254         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
3255         (AccessibilityUIElement::AccessibilityUIElement):
3256         (AccessibilityUIElement::parentElementCallback):
3257         (AccessibilityUIElement::isEqualCallback):
3258         * DumpRenderTree/chromium/AccessibilityUIElement.h:
3259         * DumpRenderTree/chromium/CppBoundClass.cpp:
3260         (CppBoundClass::getFromCppVariant):
3261         * DumpRenderTree/chromium/CppBoundClass.h:
3262
3263 2010-11-23  Alex Grilo  <abgrilo@profusion.mobi>
3264
3265         Reviewed by Kenneth Rohde Christiansen.
3266
3267         [EFL] Add tiled backing store to EWebLauncher
3268         https://bugs.webkit.org/show_bug.cgi?id=45777
3269
3270         Allow EWebLauncher to choose between single and tiled backing store
3271
3272         * EWebLauncher/main.c:
3273         (on_key_down):
3274         (browserCreate):
3275         (main):
3276
3277 2010-11-23  Simon Hausmann  <simon.hausmann@nokia.com>
3278
3279         Reviewed by Tor Arne Vestbø.
3280
3281         [Qt] Review the setUserPermission & friends API
3282         https://bugs.webkit.org/show_bug.cgi?id=46810
3283
3284         Renamed requestPermissionFromUser to featurePermissionRequested
3285         and cancelRequestsForPermission to featurePermissionRequestCanceled.
3286
3287         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3288         (WebCore::WebPage::WebPage):
3289         * QtTestBrowser/webpage.cpp:
3290         (WebPage::WebPage):
3291         (WebPage::featurePermissionRequestCanceled):
3292         * QtTestBrowser/webpage.h:
3293
3294 2010-11-23  Simon Hausmann  <simon.hausmann@nokia.com>
3295
3296         Reviewed by Tor Arne Vestbø.
3297
3298         [Qt] Review the setUserPermission & friends API
3299         https://bugs.webkit.org/show_bug.cgi?id=46810
3300
3301         Rename setUserPermission to setFeaturePermission
3302
3303         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3304         (WebCore::WebPage::requestPermission):
3305         (WebCore::WebPage::permissionSet):
3306         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3307         (LayoutTestController::grantDesktopNotificationPermission):
3308         * QtTestBrowser/webpage.cpp:
3309         (WebPage::requestPermission):
3310
3311 2010-11-23  Simon Hausmann  <simon.hausmann@nokia.com>
3312
3313         Reviewed by Tor Arne Vestbø.
3314
3315         [Qt] Review the setUserPermission & friends API
3316         https://bugs.webkit.org/show_bug.cgi?id=46810
3317
3318         Rename PermissionDomain to Feature, NotificationsPermissionDomain to Notifications
3319         and GeolocationPermissionDomain to Geolocation.
3320
3321         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3322         (WebCore::WebPage::WebPage):
3323         (WebCore::WebPage::requestPermission):
3324         (WebCore::WebPage::cancelPermission):
3325         (WebCore::WebPage::permissionSet):
3326         (WebCore::DumpRenderTree::geolocationPermissionSet):
3327         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3328         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3329         (LayoutTestController::grantDesktopNotificationPermission):
3330         * QtTestBrowser/webpage.cpp:
3331         (WebPage::WebPage):
3332         (WebPage::requestPermission):
3333         (WebPage::cancelRequestsForPermission):
3334         * QtTestBrowser/webpage.h:
3335
3336 2010-11-23  Simon Hausmann  <simon.hausmann@nokia.com>
3337
3338         Reviewed by Tor Arne Vestbø.
3339
3340         [Qt] Review the setUserPermission & friends API
3341         https://bugs.webkit.org/show_bug.cgi?id=46810
3342
3343         Add a ByUser suffix to PermissionGranted/Denied. In the future
3344         we can add PermissionGrantedByDefault.
3345
3346
3347         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3348         (WebCore::WebPage::requestPermission):
3349         (WebCore::WebPage::permissionSet):
3350         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3351         (LayoutTestController::grantDesktopNotificationPermission):
3352         * QtTestBrowser/webpage.cpp:
3353         (WebPage::requestPermission):
3354
3355 2010-11-18  Satish Sampath  <satish@chromium.org>
3356
3357         Reviewed by Jeremy Orlow.
3358
3359         For speech input event, send an event object containing all the recognition results and metadata.
3360         https://bugs.webkit.org/show_bug.cgi?id=49736
3361
3362         Updated DRT by renaming the mock result method on all platforms to the new signature.
3363
3364         * DumpRenderTree/LayoutTestController.cpp:
3365         (addMockSpeechInputResultCallback):
3366         (LayoutTestController::staticFunctions):
3367         * DumpRenderTree/LayoutTestController.h:
3368         * DumpRenderTree/chromium/LayoutTestController.cpp:
3369         (LayoutTestController::LayoutTestController):
3370         (LayoutTestController::addMockSpeechInputResult):
3371         * DumpRenderTree/chromium/LayoutTestController.h:
3372         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3373         (LayoutTestController::addMockSpeechInputResult):
3374         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3375         (LayoutTestController::addMockSpeechInputResult):
3376         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3377         (LayoutTestController::addMockSpeechInputResult):
3378         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3379         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3380         (LayoutTestController::addMockSpeechInputResult):
3381         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3382         (LayoutTestController::addMockSpeechInputResult):
3383
3384 2010-11-22  Dirk Pranke  <dpranke@chromium.org>
3385
3386         Reviewed by Tony Chang.
3387
3388         Fix some spacing issues with log messages with
3389         new-run-webkit-tests --verbose.
3390
3391         https://bugs.webkit.org/show_bug.cgi?id=49936
3392
3393         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
3394
3395 2010-11-22  Ojan Vafai  <ojan@chromium.org>
3396
3397         Reviewed by Adam Barth.
3398
3399         update scm to work with different remote branches
3400         https://bugs.webkit.org/show_bug.cgi?id=49949
3401
3402         This works if there are multiple svn tracking branches
3403         and/or if the tracking branch is refs/remots/origin/master
3404         instead of refs/remotes/trunk which is the direction we're trying
3405         to head since that makes fetches faster.
3406
3407         * Scripts/webkitpy/common/checkout/scm.py:
3408         * Scripts/webkitpy/common/checkout/scm_unittest.py:
3409
3410 2010-11-22  Hayato Ito  <hayato@chromium.org>
3411
3412         Reviewed by Shinichiro Hamaji.
3413
3414         Ignore reference files which will be used by reftests when collecting
3415         test cases.
3416         https://bugs.webkit.org/show_bug.cgi?id=49835
3417
3418         * Scripts/webkitpy/layout_tests/port/test_files.py:
3419         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
3420
3421 2010-11-22  Adam Roben  <aroben@apple.com>
3422
3423         Use paths relative to $WebKitVSPropsRedirectionDir to access shared .vsprops files
3424
3425         Apple's Windows build allows placing header files and import libraries for WebKit's
3426         dependencies (CoreGraphics, CFNetwork, SQLite, etc.) outside the source tree via the
3427         $WebKitLibrariesDir environment variable. This is both required for production builds and
3428         convenient for Apple-internal developer builds. Apple's production builds also require that
3429         WebKit's shared .vsprops files be accessed relative to $WebKitLibrariesDir. In production
3430         builds, the files are copied into that directory tree by the
3431         WebKitLibraries/win/tools/WinTools.make file. In Apple-internal developer builds, the
3432         copying is done by
3433         JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make.
3434
3435         This .vsprops copying is problematic in one very important case: when a developer updates
3436         their source tree and then tries to build. Visual Studio only reads .vsprops files when a
3437         project is first loaded. So, when Visual Studio is first opened after the .vsprops files are
3438         updated, it reads in the old files that were already residing in $WebKitLibrariesDir. When a
3439         build is started, JavaScriptCoreGenerated.make copies the new .vsprops files into
3440         $WebKitLibrariesDir, but Visual Studio will not pick up the changes.  The rest of the build
3441         will proceed with out-of-date .vsprops files, which will likely result in a build failure.
3442
3443         To fix this, we now use normal relative paths to access the .vsprops files in the source
3444         tree rather than in $WebKitLibrariesDir, but prefix those paths with a new environment
3445         variable, $WebKitVSPropsRedirectionDir. In developer builds, this environment variable is
3446         unset, so the normal relative paths are used to read the .vsprops files out of the source
3447         tree directly. In production builds, this environment variable is set to a fake directory
3448         that will cause the .vsprops files in $WebKitLibrariesDir to be found when the relative path
3449         is resolved.
3450         
3451         For example, JavaScriptCore.vcproj uses this path for FeatureDefines.vsprops:
3452
3453         $(WebKitVSPropsRedirectionDir)..\..\..\WebKitLibraries\win\tools\vsprops\FeatureDefines.vsprops
3454
3455         In developer builds, where $WebKitVSPropsRedirectionDir is unset, this will point to the
3456         files in WebKitLibraries\win\tools\vsprops in the source tree. In production builds,
3457         JavaScriptCore.make sets $WebKitVSPropsRedirectionDir to
3458         "$(SRCROOT)\AppleInternal\tools\vsprops\OpenSource\1\2\3\", so the full path for
3459         FeatureDefines.vsprops becomes:
3460
3461         $(SRCROOT)\AppleInternal\tools\vsprops\OpenSource\1\2\3\..\..\..\WebKitLibraries\win\tools\vsprops\FeatureDefines.vsprops
3462
3463         which resolves to:
3464
3465         $(SRCROOT)\AppleInternal\tools\vsprops\OpenSource\WebKitLibraries\win\tools\vsprops\FeatureDefines.vsprops
3466
3467         (We rely on the fact that Windows doesn't care whether the directories "1", "2", and "3"
3468         actually exist since they are matched by an equal number of ".." path components.)
3469
3470         Note that Visual Studio still won't pick up changes made to .vsprops files while Visual
3471         Studio is open, but that problem hasn't seemed to cause developers many headaches so far.
3472
3473         Fixes <http://webkit.org/b/49181> Windows build fails mysteriously when .vsprops files are
3474         updated
3475
3476         Reviewed by Dave Hyatt.
3477
3478         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3479         * DumpRenderTree/win/DumpRenderTree.vcproj:
3480         * DumpRenderTree/win/ImageDiff.vcproj:
3481         * FindSafari/FindSafari.vcproj:
3482         * MiniBrowser/MiniBrowser.vcproj:
3483         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3484         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj:
3485         * WebKitAPITest/WebKitAPITest.vcproj:
3486         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
3487         * WebKitTestRunner/win/InjectedBundle.vcproj:
3488         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
3489         * WinLauncher/WinLauncher.vcproj:
3490         * record-memory-win/record-memory-win.vcproj:
3491         Changed to use paths relative to $WebKitVSPropsRedirectionDir to access shared .vsprops
3492         files.
3493
3494 2010-11-22  Adam Roben  <aroben@apple.com>
3495
3496         Make it possible to run tests on Windows without Visual Studio or VC++
3497         Express installed
3498
3499         webkitdir.pm::setupCygwinEnv dies when Visual Studio and VC++ Express
3500         are not installed. But this function doesn't need to be called when we
3501         already have a build available and are just trying to run the tests.
3502
3503         Fixes <http://webkit.org/b/49932> New Windows 7 bot can't run tests
3504         because Visual Studio/VC++ Express aren't installed
3505
3506         Reviewed by Dave Hyatt.
3507
3508         * Scripts/webkitdirs.pm:
3509         (determineConfigurationForVisualStudio): Don't call setupCygwinEnv, as
3510         it is not needed by this function. Also added a FIXME.
3511
3512         (usingVisualStudioExpress): Call setupCygwinEnv directly rather than
3513         relying on determineConfigurationForVisualStudio doing it.
3514
3515 2010-11-19  Hayato Ito  <hayato@chromium.org>
3516
3517         Reviewed by Shinichiro Hamaji.
3518
3519         Simplify Driver.run_test() so that it takes only one parameter, TestInput.
3520
3521         https://bugs.webkit.org/show_bug.cgi?id=49812
3522
3523         * Scripts/webkitpy/layout_tests/driver_test.py:
3524         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3525         * Scripts/webkitpy/layout_tests/port/base.py:
3526         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3527         * Scripts/webkitpy/layout_tests/port/chromium.py:
3528         * Scripts/webkitpy/layout_tests/port/dryrun.py:
3529         * Scripts/webkitpy/layout_tests/port/test.py:
3530         * Scripts/webkitpy/layout_tests/port/webkit.py:
3531         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3532         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3533
3534 2010-11-22  Hayato Ito  <hayato@chromium.org>
3535
3536         Reviewed by Tony Chang.
3537
3538         [NRWT] Retry a few times in reading a png image to avoid a race condition.
3539
3540         https://bugs.webkit.org/show_bug.cgi?id=49924
3541
3542         * Scripts/webkitpy/layout_tests/port/chromium.py:
3543
3544 2010-11-22  João Paulo Rechi Vita  <jprvita@profusion.mobi>
3545
3546         Reviewed by Kenneth Rohde Christiansen.
3547
3548         Fix EWebLauncher zoom discretization
3549         https://bugs.webkit.org/show_bug.cgi?id=49810
3550
3551         * EWebLauncher/main.c:
3552         (nearest_zoom_level_get):
3553         (zoom_level_set):
3554         (on_load_finished):
3555         (on_key_down):
3556
3557 2010-11-21  Sam Weinig  <sam@webkit.org>
3558
3559         Rubber-stamped by Dan Bernstein.
3560
3561         Fix ~300 WebKit2 tests by enabling developer extras preference.
3562
3563         * WebKitTestRunner/TestController.cpp:
3564         (WTR::TestController::resetStateToConsistentValues):
3565
3566 2010-11-21  Sam Weinig  <sam@webkit.org>
3567
3568         Reviewed by Dan Bernstein.
3569
3570         Textareas should be resizable by default
3571         https://bugs.webkit.org/show_bug.cgi?id=49892
3572
3573         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3574         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp: Added.
3575         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3576         Add preferences test.
3577
3578 2010-11-19  Mihai Parparita  <mihaip@chromium.org>
3579
3580         Reviewed by Tony Chang.
3581
3582         Rebaseline server: checksum-only differences and prefetching
3583         https://bugs.webkit.org/show_bug.cgi?id=49841
3584         
3585         Add support for image test results where the only difference is in the
3586         checksum.
3587         
3588         Add prefetching of the image results from the next test.
3589         
3590         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
3591         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
3592         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
3593
3594 2010-11-19  Dirk Pranke  <dpranke@chromium.org>
3595
3596         Reviewed by Tony Chang.
3597
3598         nrwt multiprocessing - add 'worker number' concept, move stuff to worker thread
3599
3600         Add the 'worker number' and 'worker name' concepts to the 
3601         TestShellThread objects, and move test_types and test_args from
3602         the TestRunner to the TestShellThread.
3603
3604         https://bugs.webkit.org/show_bug.cgi?id=49768
3605
3606         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3607         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3608
3609 2010-11-19  Dirk Pranke  <dpranke@chromium.org>
3610
3611         Reviewed by Ojan Vafai.
3612
3613         Do some minor cleanup and bug fixing.
3614
3615         https://bugs.webkit.org/show_bug.cgi?id=49777
3616
3617         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3618         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3619
3620 2010-11-19  Dirk Pranke  <dpranke@chromium.org>
3621
3622         Reviewed by Ojan Vafai.
3623
3624         nrwt - config.build_directory() is busted
3625
3626         Fixes a typo that was causing us to usually return the top level
3627         directory WebKitBuild instead of WebKitBuild/{Debug,Release}. The
3628         bug was hidden by test stubs that were too simplistic :(.
3629
3630         https://bugs.webkit.org/show_bug.cgi?id=49815
3631
3632         * Scripts/webkitpy/common/system/executive_mock.py:
3633         * Scripts/webkitpy/layout_tests/port/config.py:
3634         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
3635
3636 2010-11-19  Steve Falkenburg  <sfalken@apple.com>
3637
3638         Reviewed by Adam Roben.
3639
3640         Add Debug_Cairo_CFLite and Release_Cairo_CFLite configurations for all vcproj files
3641         https://bugs.webkit.org/show_bug.cgi?id=49819
3642
3643         * DumpRenderTree/DumpRenderTree.sln:
3644         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3645         * DumpRenderTree/win/DumpRenderTree.vcproj:
3646         * DumpRenderTree/win/ImageDiff.vcproj:
3647         * FindSafari/FindSafari.vcproj:
3648         * MiniBrowser/MiniBrowser.vcproj:
3649         * TestWebKitAPI/win/TestWebKitAPI.sln:
3650         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3651         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj:
3652         * WebKitAPITest/WebKitAPITest.vcproj:
3653         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
3654         * WebKitTestRunner/win/InjectedBundle.vcproj:
3655         * WebKitTestRunner/win/InjectedBundleGenerated.vcproj:
3656         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
3657         * WinLauncher/WinLauncher.vcproj:
3658         * record-memory-win/record-memory-win.vcproj:
3659
3660 2010-11-19  Adam Roben  <aroben@apple.com>
3661
3662         Add some more Windows slaves
3663
3664         This is probably more than we will be using in the immediate future,
3665         but having some extra slave names makes experimenting with different
3666         configurations easier.
3667
3668         Reviewed by Jon Honeycutt.
3669
3670         * BuildSlaveSupport/build.webkit.org-config/config.json: Added 5 more
3671         Windows slaves and distributed them among the three different Test
3672         builders.
3673
3674 2010-11-19  Kinuko Yasuda  <kinuko@chromium.org>
3675
3676         Reviewed by Ojan Vafai.
3677
3678         [Chromium] REGRESSION: Record actual test results in the JSON result summary for non-layout tests
3679         https://bugs.webkit.org/show_bug.cgi?id=49702
3680
3681         Re-landing r72357 with a test fix.
3682
3683         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
3684         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3685         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
3686
3687 2010-11-19  Avi Drissman  <avi@google.com>
3688
3689         Reviewed by Antonio Gomes.
3690
3691         Complete support for Unix editing mode
3692         https://bugs.webkit.org/show_bug.cgi?id=49757
3693
3694         * DumpRenderTree/LayoutTestController.cpp:
3695         (setEditingBehaviorCallback):
3696         * DumpRenderTree/chromium/LayoutTestController.cpp:
3697         (LayoutTestController::setEditingBehavior):
3698
3699 2010-11-19  Adam Roben  <aroben@apple.com>
3700
3701         Fix run-javascriptcore-tests when there's a space in the path to
3702         testapi
3703
3704         Reviewed by Sam Weinig.
3705
3706         * Scripts/run-javascriptcore-tests: Use an indirect object when calling
3707         system() to force it to interpret spaces in the path correctly.
3708
3709 2010-11-19  Adam Roben  <aroben@apple.com>
3710
3711         Update scripts for .exe name changes after r72327
3712
3713         As of r72327, the "_debug" suffix is only used in Debug_All builds.
3714
3715         Reviewed by Sam Weinig.
3716
3717         * Scripts/run-javascriptcore-tests:
3718         (testapiPath):
3719
3720         * Scripts/sunspider-compare-results: