[chromium] extract normalization of LayoutTests URLs to a method of TestShell
[WebKit.git] / Tools / ChangeLog
1 2011-09-15  Jochen Eisinger  <jochen@chromium.org>
2
3         [chromium] extract normalization of LayoutTests URLs to a method of TestShell
4         https://bugs.webkit.org/show_bug.cgi?id=68145
5
6         This will allow for other classes in DumpRenderTree to reuse this functionality
7
8         Reviewed by David Levin.
9
10         * DumpRenderTree/chromium/TestShell.cpp:
11         (normalizeLayoutTestURLInternal):
12         (dumpHistoryItem):
13         (TestShell::normalizeLayoutTestURL):
14         * DumpRenderTree/chromium/TestShell.h:
15
16 2011-09-14  Ada Chan  <adachan@apple.com>
17
18         Add test for WKBundleFrameCopyWebArchive().
19         https://bugs.webkit.org/show_bug.cgi?id=67857
20
21         Reviewed by Anders Carlsson.
22
23         * TestWebKitAPI/Tests/WebKit2/WebArchive.cpp: Added.
24         (TestWebKitAPI::didReceiveMessageFromInjectedBundle): Do some basic sanity checks to make sure
25         the returned data is a valid webarchive.
26         (TestWebKitAPI::setInjectedBundleClient):
27         (TestWebKitAPI::didFinishLoadForFrame):
28         (TestWebKitAPI::TEST): Load simple.html in a WebView.  Wait for it to finish loading, and then ask the
29         injected bundle for the webarchive and check the returned webarchive.
30         * TestWebKitAPI/Tests/WebKit2/WebArchive_Bundle.cpp: Added.
31         (TestWebKitAPI::WebArchiveTest::WebArchiveTest):
32         (TestWebKitAPI::WebArchiveTest::didReceiveMessage): Handle the "GetWebArchive" message and return
33         the web archive.
34
35         Add files to project.
36         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Also let Visual Studio reorder a file.
37         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
38         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
39
40 2011-09-14  Ryosuke Niwa  <rniwa@webkit.org>
41
42         committers.py should support multiple IRC nicknames
43         https://bugs.webkit.org/show_bug.cgi?id=68110
44
45         Reviewed by Eric Seidel.
46
47         Add multiple IRC nickname support to committers.py
48
49         * Scripts/webkitpy/common/config/committers.py:
50         * Scripts/webkitpy/common/config/committers_unittest.py:
51         * Scripts/webkitpy/tool/bot/irc_command.py:
52         * Scripts/webkitpy/tool/bot/sheriff.py:
53
54 2011-09-14  Jon Lee  <jonlee@apple.com>
55
56         Implement globalFlag for WebKitTestRunner
57         https://bugs.webkit.org/show_bug.cgi?id=68033
58         <rdar://problem/10119204>
59
60         Reviewed by Sam Weinig.
61
62         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Porting globalFlag from DRT
63         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
64         (WTR::LayoutTestController::LayoutTestController): initialize m_globalFlag to false
65         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: add m_globalFlag
66         (WTR::LayoutTestController::globalFlag): simple getter
67         (WTR::LayoutTestController::setGlobalFlag): simple setter
68
69 2011-09-13  Eric Seidel  <eric@webkit.org>
70
71         Remove ENABLE_SVG_USE as <use> is required by HTML5
72         https://bugs.webkit.org/show_bug.cgi?id=68019
73
74         Reviewed by Ryosuke Niwa.
75
76         * Scripts/build-webkit:
77         * waf/build/settings.py:
78
79 2011-09-14  Ryosuke Niwa  <rniwa@webkit.org>
80
81         Remove Jan Erik Hanssen (added in my r95078) from the list for now
82         since I can't confirm acceptable his committership.
83
84         * Scripts/webkitpy/common/config/committers.py:
85
86 2011-09-14  Jochen Eisinger  <jochen@chromium.org>
87
88         [chromium] Remove obsolete WebViewClient methods from DumpRenderTree.
89         https://bugs.webkit.org/show_bug.cgi?id=68066
90
91         Reviewed by Adam Barth.
92
93         * DumpRenderTree/chromium/WebViewHost.cpp:
94         * DumpRenderTree/chromium/WebViewHost.h:
95
96 2011-09-13  Ryosuke Niwa  <rniwa@webkit.org>
97
98         committers.py is missing some contributors
99         https://bugs.webkit.org/show_bug.cgi?id=68059
100
101         Reviewed by Adam Barth.
102
103         Add David Barr, Jan Erik Hanssen, and Kim Grönholm.
104
105         Also add nicks of Alejandro G. Castro, Collin Jackson, and Matt Lilek.
106
107         * Scripts/webkitpy/common/config/committers.py:
108
109 2011-09-13  Ryosuke Niwa  <rniwa@webkit.org>
110
111         Fix webkit python test after r95061.
112
113         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
114
115 2011-09-13  Xianzhu Wang  <wangxianzhu@chromium.org>
116
117         Add myself as a contributor. No review needed.
118
119         * Scripts/webkitpy/common/config/committers.py:
120
121 2011-09-13  Adam Barth  <abarth@webkit.org>
122
123         garden-o-matic has unfriendly error messages when the local server is not available
124         https://bugs.webkit.org/show_bug.cgi?id=68042
125
126         Reviewed by Dimitri Glazkov.
127
128         This patch moves us from using alert to showing the error inline in the
129         progress dialog.
130
131         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
132         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
133         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
134         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
135         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
136
137 2011-09-13  Adam Barth  <abarth@webkit.org>
138
139         FailureGrid in garden-o-matic should link to the builder's waterfall page
140         https://bugs.webkit.org/show_bug.cgi?id=68036
141
142         Reviewed by Dimitri Glazkov.
143
144         One of the users in the user study thought the configurations names in
145         the failure grid would link to the underlying bots.  That makes sense,
146         so this patch adds the behavior.
147
148         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
149         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
150         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
151         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
152
153 2011-09-13  Adam Barth  <abarth@webkit.org>
154
155         garden-o-matic should be able to mark failures as expected
156         https://bugs.webkit.org/show_bug.cgi?id=68027
157
158         Reviewed by Dimitri Glazkov.
159
160         All the back-end infrastructure exists for this operation.  This patch
161         just adds some UI to the front-end and wires that UI up to the back
162         end.  This exact UI will likely need some more polish, but this should
163         be a reasonable first cut.
164
165         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
166         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
167         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
168         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
169         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
170
171 2011-09-13  Adam Barth  <abarth@webkit.org>
172
173         garden-o-matic should tell you about the progress of your rebaseline
174         https://bugs.webkit.org/show_bug.cgi?id=67967
175
176         Reviewed by Dimitri Glazkov.
177
178         This patch adds ui.MessageBox, which is a light wrapper around jQuery
179         UI's dialog widget.  We then use ui.MessageBox to show status messages
180         about in-progress rebaselines.  As each baseline is downloaded, the
181         MessageBox updates.  This UI replaces our temporary "alert"-based UI.
182
183         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
184         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
185         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
186         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
187         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
188         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
189
190 2011-09-13  Leandro Pereira  <leandro@profusion.mobi>
191
192         GTK DumpRenderTree uses inefficient idioms to iterate over G[S]Lists
193         https://bugs.webkit.org/show_bug.cgi?id=68024
194
195         Reviewed by Gustavo Noronha Silva.
196         
197         Using g_list_count() and g_list_nth_data() together on a loop is
198         inneficient since they're both O(n). Iterate over lists in a saner
199         way.
200
201         * DumpRenderTree/gtk/DumpRenderTree.cpp:
202         (dumpHistoryItem): Reduce the scope for the 'kids' variable, and
203         iterate on it using g_list_next(). Free the list after done with it.
204         (dumpBackForwardListForWebView): Instead of appending (which is
205         expensive in GLists) history items and then iterating from the tail
206         of the itemsToPrint list, prepend items and walk forwards as usual.
207         (dumpBackForwardListForAllWebViews): Walk the list in a saner way,
208         remove the (unneeded) viewList variable.
209
210 2011-09-13  Ryosuke Niwa  <rniwa@webkit.org>
211
212         Add Eric's IRC nick.
213
214         * Scripts/webkitpy/common/config/committers.py:
215
216 2011-09-13  Anders Carlsson  <andersca@apple.com>
217
218         Disable C++ exceptions when building with clang
219         https://bugs.webkit.org/show_bug.cgi?id=68031
220         <rdar://problem/9556880>
221
222         Reviewed by Mark Rowe.
223
224         * MiniBrowser/Configurations/Base.xcconfig:
225         * TestWebKitAPI/Configurations/Base.xcconfig:
226         * WebKitTestRunner/Configurations/Base.xcconfig:
227
228 2011-09-13  Ojan Vafai  <ojan@chromium.org>
229
230         [chromium] fix flakiness dashboard for chromium interactive tests
231         https://bugs.webkit.org/show_bug.cgi?id=68029
232
233         Reviewed by Tony Chang.
234
235         * TestResultServer/static-dashboards/flakiness_dashboard.html:
236         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
237
238 2011-09-13  Ryosuke Niwa  <rniwa@webkit.org>
239
240         Add Alice and Aryeh to the list of contributors.
241
242         * Scripts/webkitpy/common/config/committers.py:
243
244 2011-09-13  Ryosuke Niwa  <rniwa@webkit.org>
245
246         sheriffbot whois should also tell us email addresses
247         https://bugs.webkit.org/show_bug.cgi?id=67975
248
249         Reviewed by Eric Seidel and David Levin.
250
251         Taught sheriffbot how to tell us contributor's email addresses.
252
253         * Scripts/webkitpy/tool/bot/irc_command.py:
254         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
255
256 2011-09-13  Eric Seidel  <eric@webkit.org>
257
258         Remove ENABLE_SVG_FOREIGN_OBJECT as it is a required part of HTML5
259         https://bugs.webkit.org/show_bug.cgi?id=68018
260
261         Reviewed by Ryosuke Niwa.
262
263         * Scripts/build-webkit:
264         * waf/build/settings.py:
265
266 2011-09-13  Chang Shu  <cshu@webkit.org>
267
268         [WK2] [Mac] Implement KeyDown function for WebKit2 EventSender.
269         https://bugs.webkit.org/show_bug.cgi?id=57515
270
271         The code change in WebKitTestRunner first sends keydown event from InjectedBundle to
272         TestController synchronously. The latter then sends simulated event to WebKit2 module,
273         which is synchronous, too.
274
275         Reviewed by Darin Adler.
276
277         * WebKitTestRunner/EventSenderProxy.h: Added.
278         (WTR::EventSenderProxy::EventSenderProxy):
279         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
280         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
281         (WTR::EventSendingController::keyDown):
282         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
283         * WebKitTestRunner/PlatformWebView.h:
284         (WTR::PlatformWebView::platformWindow):
285         * WebKitTestRunner/TestController.cpp:
286         (WTR::TestController::TestController):
287         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
288         * WebKitTestRunner/TestController.h:
289         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
290         * WebKitTestRunner/mac/EventSenderProxy.mm: Added.
291         (WTR::buildModifierFlags):
292         (WTR::EventSenderProxy::keyDown):
293
294 2011-09-12  Leandro Pereira  <leandro@profusion.mobi>
295
296         [EFL] DRT: Add DumpRenderTreeEfl.h
297         https://bugs.webkit.org/show_bug.cgi?id=63993
298
299         Reviewed by Eric Seidel.
300         
301         This header contains some global variables used by EFL's
302         DumpRenderTree implementation.
303
304         * DumpRenderTree/DumpRenderTree.h: Include DumpRenderTreeEfl.h when
305         appropriate.
306         * DumpRenderTree/efl/DumpRenderTreeEfl.h: Added.
307
308 2011-09-12  Raphael Kubo da Costa  <kubo@profusion.mobi>
309
310         [EFL] Send the right key names for PageUp and PageDown.
311         https://bugs.webkit.org/show_bug.cgi?id=67044
312
313         Reviewed by Kenneth Rohde Christiansen.
314
315         PlatformKeyboardEventEfl uses "Prior" and "Next" to refer to PageUp and
316         PageDown (which is close to the defines in WindowsKeyboardCodes.h).
317         However, EventSender was sending "Page_Up" and "Page_Down", so tests
318         such as editing/input/page-up-down-scrolls.html were timing out due to
319         the right key down events not being sent.
320
321         * DumpRenderTree/efl/EventSender.cpp:
322         (keyPadNameFromJSValue):
323         (keyNameFromJSValue):
324
325 2011-09-12  Eric Seidel  <eric@webkit.org>
326
327         sheriffbot whois is case sensitive
328         https://bugs.webkit.org/show_bug.cgi?id=67972
329
330         Reviewed by Adam Barth.
331
332         I also fixed a typo in the "More than 5 contributors" message
333         from my previous commit.
334
335         * Scripts/webkitpy/common/config/committers.py:
336         * Scripts/webkitpy/common/config/committers_unittest.py:
337         * Scripts/webkitpy/tool/bot/irc_command.py:
338         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
339
340 2011-09-12  Eric Seidel  <eric@webkit.org>
341
342         sheriffbot whois should be smarter
343         https://bugs.webkit.org/show_bug.cgi?id=67971
344
345         Reviewed by Adam Barth.
346
347         This makes sheriffbot whois basically grep the committers list
348         making it much easier to find a contributor by name.
349
350         Unfortunately the current unittests depend on the real committers.py
351         file, so as we add more eric's to the project, this unittest result will
352         change.  I think that's OK for now.  We'll fix it when it breaks.
353
354         * Scripts/webkitpy/common/config/committers.py:
355         * Scripts/webkitpy/tool/bot/irc_command.py:
356         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
357
358 2011-09-12  Sheriff Bot  <webkit.review.bot@gmail.com>
359
360         Unreviewed, rolling out r94976.
361         http://trac.webkit.org/changeset/94976
362         https://bugs.webkit.org/show_bug.cgi?id=67953
363
364         Broke a bunch of security/load& tests (Requested by rniwa on
365         #webkit).
366
367         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
368         (LayoutTestController::pathToLocalResource):
369
370 2011-09-12  Eric Seidel  <eric@webkit.org>
371
372         Rubber-stamped by Adam Barth.
373
374         Remove the "the tree is burning!" warning previously shown
375         when landing patches.  It was a dream.  But it's just noise now.
376
377         Some bots will require a restart to notice the removal of the option
378         so I've left the --ignore-builders option in for now.
379
380         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
381         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
382         * Scripts/webkitpy/tool/commands/download.py:
383         * Scripts/webkitpy/tool/commands/download_unittest.py:
384         * Scripts/webkitpy/tool/commands/queues_unittest.py:
385         * Scripts/webkitpy/tool/steps/__init__.py:
386         * Scripts/webkitpy/tool/steps/commit.py:
387         * Scripts/webkitpy/tool/steps/ensurebuildersaregreen.py: Removed.
388         * Scripts/webkitpy/tool/steps/postdiffforrevert.py:
389
390 2011-09-12  Eric Seidel  <eric@webkit.org>
391
392         [NRWT] REGRESSION: Local loader tests are failing on machines that lost /tmp/LayoutTests symlink
393         https://bugs.webkit.org/show_bug.cgi?id=65781
394
395         Reviewed by Ryosuke Niwa.
396
397         Instead of making NRWT create the symlink, I just made DumpRenderTree smart enough
398         to resolve the passed in url relative to the absolute url for the test.
399
400         I believe this is a better approach than the on used in the Qt and Chromium DRT's
401         (which resolves the path relative to the built location of the DRT executable)
402         and we should move this new code into a shared location in a follow-up patch.
403
404         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
405         (LayoutTestController::pathToLocalResource):
406
407 2011-09-12  Eric Seidel  <eric@webkit.org>
408
409         Reshuffle some code in WebKitDriver._read_block in preparation for reading stderr/stdout separately
410         https://bugs.webkit.org/show_bug.cgi?id=67530
411
412         Reviewed by Adam Barth.
413
414         I believe I've fixed the bug in the original patch which prompted the rollout.
415         The previous patch was using the wrong deadline for the initial read,
416         subtracting time.time() twice from the deadline value.
417
418         * Scripts/webkitpy/layout_tests/port/webkit.py:
419         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
420
421 2011-09-12  Balazs Kelemen  <kbalazs@webkit.org>
422
423         [Qt][WK2] WebKitTestRunner does not produce crash logs
424         https://bugs.webkit.org/show_bug.cgi?id=67714
425
426         Reviewed by Chang Shu.
427
428         Added a simple way of generating backtrace on crash
429         to the web process. The implementation is similar what
430         we have in DRT. It depends on GNU libc functionality
431         so it is only enabled where we are running in such an environment.
432
433         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
434         (WTR::printBacktrace):
435         (WTR::crashHandler):
436         (WTR::InjectedBundle::platformInitialize):
437
438 2011-09-11  Filip Pizlo  <fpizlo@apple.com>
439
440         Added my IRC nick to the committers file.
441
442         * Scripts/webkitpy/common/config/committers.py:
443
444 2011-09-01  Filip Pizlo  <fpizlo@apple.com>
445
446         The executable allocator makes it difficult to free individual
447         chunks of executable memory
448         https://bugs.webkit.org/show_bug.cgi?id=66363
449
450         Reviewed by Oliver Hunt.
451         
452         Introduced a best-fit, balanced-tree based allocator. The allocator
453         required a balanced tree that does not allocate memory and that
454         permits the removal of individual nodes directly (as opposed to by
455         key); neither AVLTree nor WebCore's PODRedBlackTree supported this.
456         Changed all references to executable code to use a reference counted
457         handle.
458
459         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
460         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp: Added.
461         (TestWebKitAPI::TEST_F):
462         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp: Added.
463         (TestWebKitAPI::Pair::findExact):
464         (TestWebKitAPI::Pair::remove):
465         (TestWebKitAPI::Pair::findLeastGreaterThanOrEqual):
466         (TestWebKitAPI::Pair::assertFoundAndRemove):
467         (TestWebKitAPI::Pair::assertEqual):
468         (TestWebKitAPI::Pair::assertSameValuesForKey):
469         (TestWebKitAPI::Pair::testDriver):
470         (TestWebKitAPI::TEST_F):
471
472 2011-09-10  Andy Estes  <aestes@apple.com>
473
474         Move myself from committers_unable_to_review to reviewers_list.
475
476         * Scripts/webkitpy/common/config/committers.py:
477
478 2011-09-10  Kevin Ollivier  <kevino@theolliviers.com>
479
480         [wx] Unreviewed build fix. MSW build fixes.
481
482         * DumpRenderTree/config.h:
483         * waf/build/wxpresets.py:
484
485 2011-09-10  Andreas Kling  <kling@webkit.org>
486
487         Crash beneath WKURLIsEqual() when reloading in MiniBrowser.
488         https://bugs.webkit.org/show_bug.cgi?id=59328
489
490         Reviewed by Kenneth Rohde Christiansen.
491
492         * MiniBrowser/mac/BrowserWindowController.m:
493         (-[BrowserWindowController updateProvisionalURLForFrame:]): Add missing null check.
494
495 2011-09-10  Adam Barth  <abarth@webkit.org>
496
497         Build fix for Android.  DumpRenderTree is a client of the WebKit API
498         and does not have access to notImplemented().
499
500         * DumpRenderTree/chromium/TestShellAndroid.cpp:
501         (openStartupDialog):
502
503 2011-09-09  Alexey Proskuryakov  <ap@apple.com>
504
505         Add a script to create a monolithic script-test
506         https://bugs.webkit.org/show_bug.cgi?id=67747
507
508         Reviewed by Darin Adler.
509
510         * Scripts/make-new-script-test: Added.
511
512 2011-09-09  Luiz Agostini  <luiz@webkit.org>
513
514         Adding myself to the reviewers list.
515
516         * Scripts/webkitpy/common/config/committers.py:
517
518 2011-09-09  Ryosuke Niwa  <rniwa@webkit.org>
519
520         Buildbot may use RunWebKitTest's evaluateCommand on bots that run nrwt
521         https://bugs.webkit.org/show_bug.cgi?id=67855
522
523         Reviewed by Dirk Pranke.
524
525         The bug was caused by the fact some ports use RunWebKitTests instead of NewRunWebKitTests to run tests,
526         and using RunWebKitTests.evaluateCommand after calling _parseNewRunWebKitTestsOutput.
527
528         Fixed the bug by merging evaluateCommand of RunWebKitTests and NewRunWebKitTests.
529
530         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
531
532 2011-09-09  Mark Hahnenberg  <mhahnenberg@apple.com>
533
534         Add myself to committers.py
535         https://bugs.webkit.org/show_bug.cgi?id=67853
536
537         Reviewed by Darin Adler.
538
539         * Scripts/webkitpy/common/config/committers.py:
540
541 2011-09-09  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
542
543         [Qt] Remove common.pri
544         https://bugs.webkit.org/show_bug.cgi?id=67814
545
546         Reviewed by Andreas Kling.
547
548         * Tools.pro:
549
550 2011-09-09  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
551
552         [NRWT] the nrwt check httpd with --no-http option
553         https://bugs.webkit.org/show_bug.cgi?id=67835
554
555         Reviewed by Tony Chang.
556
557         * Scripts/webkitpy/layout_tests/controllers/manager.py:
558         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
559
560 2011-09-09  Hao Zheng  <zhenghao@chromium.org>
561
562         [chromium] Implement DRT support for Android.
563         https://bugs.webkit.org/show_bug.cgi?id=67590
564
565         Reviewed by Tony Chang.
566
567         Add 2 mechanism to make DRT interaction more robust on Android:
568         - Send 'QUIT' to DRT to make it stop.
569         - Wait until receiving '#READY' from DRT, so that DRT won't miss any
570         input commands before it starts.
571         And LayoutTestController.cpp needs to include <cctype> for 'tolower'
572         and <clocale> for 'LC_ALL' to compile on Android.
573
574         Also change to use sigaction instead of signal for TestShellGtk.cpp,
575         as signal() man page recommends using sigaction().
576
577         * DumpRenderTree/DumpRenderTree.gypi:
578         * DumpRenderTree/chromium/DumpRenderTree.cpp:
579         (main):
580         * DumpRenderTree/chromium/LayoutTestController.cpp:
581         * DumpRenderTree/chromium/TestShellAndroid.cpp: Added.
582         (AlarmHandler):
583         (TestShell::waitTestFinished):
584         (platformInit):
585         (openStartupDialog):
586         (checkLayoutTestSystemDependencies):
587         * DumpRenderTree/chromium/TestShellGtk.cpp:
588         (AlarmHandler):
589         (TestShell::waitTestFinished):
590
591 2011-09-09  Kevin Ollivier  <kevino@theolliviers.com>
592
593         [wx] Unreviewed build fix. Add Source/JavaScriptCore/dfg directory to the build.
594
595         * waf/build/settings.py:
596
597 2011-09-09  Sheriff Bot  <webkit.review.bot@gmail.com>
598
599         Unreviewed, rolling out r94851.
600         http://trac.webkit.org/changeset/94851
601         https://bugs.webkit.org/show_bug.cgi?id=67847
602
603         It broke a webkitpy test (Requested by ossy on #webkit).
604
605         * Scripts/webkitpy/layout_tests/controllers/manager.py:
606
607 2011-09-09  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
608
609         [NRWT] the nrwt check httpd with --no-http option
610         https://bugs.webkit.org/show_bug.cgi?id=67835
611
612         Reviewed by Csaba Osztrogonác.
613
614         * Scripts/webkitpy/layout_tests/controllers/manager.py:
615
616 2011-09-08  Brian Weinstein  <bweinstein@apple.com>
617
618         WebKit2: Assertion when calling didPerform*Redirect on null source/destination URL string
619         https://bugs.webkit.org/show_bug.cgi?id=67794
620         <rdar://problem/9892024>
621         
622         Add a test that we don't send a didPerformServerRedirect when a load is cancelled from willSendRequest.
623
624         Reviewed by Brady Eidson.
625
626         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback.cpp: Added.
627         (TestWebKitAPI::didFinishLoadForFrame): Set flags on whether we've loaded the main frame, iframe, or both.
628         (TestWebKitAPI::didPerformServerRedirect): Set a flag for whether we've performed a server redirect.
629         (TestWebKitAPI::TEST): Set up a WKPageLoaderClient and WKContextHistoryClient, and load simple-iframe.html.
630             Once both frames have loaded (main frame and blocked iframe), make sure that we have never called
631             didPerformServerRedirect.
632
633         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback_Bundle.cpp: Added.
634         (TestWebKitAPI::LoadCanceledNoServerRedirectCallbackTest::LoadCanceledNoServerRedirectCallbackTest): Initialize
635             our InjectedBundleTest.
636         (TestWebKitAPI::LoadCanceledNoServerRedirectCallbackTest::willSendRequestForFrame): If we are dealing with a request
637             from the main frame (the main resource in simple-iframe.html), allow it. If not (dealing with the iframe), block
638             the request.
639         (TestWebKitAPI::LoadCanceledNoServerRedirectCallbackTest::didCreatePage): Set up the WKBundlePageResourceLoadClient.
640
641         * TestWebKitAPI/Tests/WebKit2/simple-iframe.html: Added.
642         
643         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
644         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Ditto.
645         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj: Ditto.
646         * TestWebKitAPI/win/copy-resources.cmd: Ditto.
647
648 2011-09-08  David Levin  <levin@chromium.org>
649
650         check-webkit-style: Ref|Own Ptr& should be allowed as a parameter.
651         https://bugs.webkit.org/show_bug.cgi?id=67797
652
653         Reviewed by Eric Seidel.
654
655         * Scripts/webkitpy/style/checkers/cpp.py: Allow Ref/Own Ptr when it ends with &.
656         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added test cases for this.
657
658 2011-09-08  Fady Samuel  <fsamuel@chromium.org>
659
660         Fixed Layout Mode should be adjustable from layoutTestController for testing on Chromium platforms
661         https://bugs.webkit.org/show_bug.cgi?id=67723
662
663         Reviewed by Adam Barth.
664
665         * DumpRenderTree/chromium/EventSender.h:
666         * DumpRenderTree/chromium/LayoutTestController.cpp:
667         (LayoutTestController::LayoutTestController):
668         (LayoutTestController::enableFixedLayoutMode):
669         (LayoutTestController::setFixedLayoutSize):
670         * DumpRenderTree/chromium/LayoutTestController.h:
671
672 2011-09-07  Matthew Delaney  <mdelaney@apple.com>
673
674         Add standalone script that filters the output of build-webkit to be more human-readable
675         https://bugs.webkit.org/show_bug.cgi?id=44081
676
677         Reviewed by Daniel Bates.
678
679         * Scripts/filter-build-webkit: Added. Just need to feed it the output of
680         a build script (e.g. build-webkit) and it spits out a prettier version.
681         * Scripts/VCSUtils.pm: Refactored "possiblyColored" out of run-api-tests into VCSUtils.
682         * Scripts/run-api-tests: Now includes VCSUtils to use "possiblyColored"
683
684 2011-09-07  Noel Gordon  <noel.gordon@gmail.com>
685
686         Add myself to committers.py                 
687         https://bugs.webkit.org/show_bug.cgi?id=67696
688
689         Reviewed by Kent Tamura.
690
691         * Scripts/webkitpy/common/config/committers.py:
692
693 2011-09-07  Adam Barth  <abarth@webkit.org>
694
695         rebaseline button in garden-o-matic details view should work
696         https://bugs.webkit.org/show_bug.cgi?id=67738
697
698         Reviewed by Dimitri Glazkov.
699
700         This patch wires up the rebaseline button in garden-o-matic results
701         details view.  The button is current per-test, so there isn't a way to
702         rebaseline individual bots.  This is a place to start.  If we decide we
703         want per-bot rebaselining, we'll need to think of some better UI.
704
705         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
706         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
707         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
708         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
709
710 2011-09-07  Eric Seidel  <eric@webkit.org>
711
712         Teach the PortFactory object how to pass along executive/user/filesystem to port objects (which fixes the failing rebaseline_test on bots)
713         https://bugs.webkit.org/show_bug.cgi?id=67737
714
715         Reviewed by Adam Barth.
716
717         I got a little over-eager when deprecating host.port_factory in the previous commit.
718         Turns out that Host.port_factory was already the "modern" port/factory.py
719         it was just the Module object.  I un-deprecated the variable, and changed it from
720         being the module to being an actual PortFactory, passing it a host object.
721         I also taught PortFactory how to set user/executive/filesystem in the kwargs
722         when instantiating a new Port object.
723         This magically fixed the test_rebaseline test, since its now no longer talking
724         to the real filesystem.
725
726         * Scripts/webkitpy/common/host.py:
727         * Scripts/webkitpy/layout_tests/port/factory.py:
728         * Scripts/webkitpy/tool/commands/queries.py:
729         * Scripts/webkitpy/tool/mocktool.py:
730
731 2011-09-07  Eric Seidel  <eric@webkit.org>
732
733         Add a new PortFactory class for creating new-style ports and deprecate the old PortFactory
734         https://bugs.webkit.org/show_bug.cgi?id=67734
735
736         Reviewed by Adam Barth.
737
738         Right now every place that creates a Port object has to be very careful
739         to pass in a MockSCM/MockUser/MockFilesystem when appropriate.
740         The correct fix is for port/factory.py (which creates most port objects)
741         to know how to pass these in automatically.  However, currently all port/factory.py
742         functions are free functions instead of being on an object.  This patch
743         adds a new PortFactory object and deprecates the PortFactory for the old-style Port objects.
744
745         In a follow-up patch I will add PortFactory to the Host object and teach PortFactory how to
746         pass along the proper scm/user/filesystem to the Port object.
747
748         * Scripts/webkitpy/common/host.py:
749         * Scripts/webkitpy/layout_tests/port/factory.py:
750         * Scripts/webkitpy/tool/commands/queries.py:
751         * Scripts/webkitpy/tool/mocktool.py:
752
753 2011-09-07  Sheriff Bot  <webkit.review.bot@gmail.com>
754
755         Unreviewed, rolling out r94441.
756         http://trac.webkit.org/changeset/94441
757         https://bugs.webkit.org/show_bug.cgi?id=67731
758
759         "MacEWSes are backed up due to new machines not able to reach
760         git.webkit.org.  Disabling tests for now" (Requested by
761         eseidel2 on #webkit).
762
763         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
764
765 2011-09-07  Elliot Poger  <epoger@google.com>
766
767         filter test_expectations properly for chromium-mac vs chromium-cg-mac
768         https://bugs.webkit.org/show_bug.cgi?id=67324
769
770         Reviewed by Dirk Pranke.
771
772         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
773         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
774         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
775         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
776         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
777
778 2011-09-07  Eric Boren  <borenet@gmail.com>
779
780         [Chromium] Modify WebTouchEvent structure to match WebCore::TouchEvent
781         https://bugs.webkit.org/show_bug.cgi?id=66800
782
783         Reviewed by Darin Fisher.
784
785         * DumpRenderTree/chromium/EventSender.cpp:
786         (EventSender::sendCurrentTouchEvent):
787
788 2011-09-07  Jarred Nicholls  <jarred@sencha.com>
789
790         [Qt][DRT] Normalize file:///tmp/LayoutTests in LayoutTestController::pathToLocalResource()
791         https://bugs.webkit.org/show_bug.cgi?id=67254
792
793         Reviewed by Csaba Osztrogonác.
794
795         Translate file:///tmp/LayoutTests/* urls into the repository LayoutTests directory, which is
796         derived from the running location of DumpRenderTree binary.
797
798         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
799         (LayoutTestController::pathToLocalResource):
800         (LayoutTestController::setUserStyleSheetLocation): pass the url through pathToLocalResource
801
802 2011-09-07  Csaba Osztrogonác  <ossy@webkit.org>
803
804         REGRESSION(r94288) build-webkit doesn't work on Symbian
805         https://bugs.webkit.org/show_bug.cgi?id=67706
806
807         * Scripts/webkitdirs.pm: Disable automatic clean build on Symbian, because it doesn't support shadow build.
808         (buildQMakeProject):
809
810 2011-09-07  Csaba Osztrogonác  <ossy@webkit.org>
811
812         REGRESSION(r94288) build-webkit doesn't work on Windows
813         https://bugs.webkit.org/show_bug.cgi?id=67646
814
815         Roll back r94655 with a small fix.
816
817         * Scripts/webkitdirs.pm:
818         (buildQMakeProject):
819
820 2011-09-07  Sheriff Bot  <webkit.review.bot@gmail.com>
821
822         Unreviewed, rolling out r94635.
823         http://trac.webkit.org/changeset/94635
824         https://bugs.webkit.org/show_bug.cgi?id=67704
825
826         Linux Touch build is failing to compile this change.
827         (Requested by loislo on #webkit).
828
829         * DumpRenderTree/chromium/EventSender.cpp:
830         (EventSender::sendCurrentTouchEvent):
831
832 2011-09-07  Sheriff Bot  <webkit.review.bot@gmail.com>
833
834         Unreviewed, rolling out r94655.
835         http://trac.webkit.org/changeset/94655
836         https://bugs.webkit.org/show_bug.cgi?id=67703
837
838         It broke Leopard debug bot (Requested by ossy on #webkit).
839
840         * Scripts/webkitdirs.pm:
841
842 2011-09-07  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
843
844         REGRESSION(r94288) build-webkit doesn't work on Windows
845         https://bugs.webkit.org/show_bug.cgi?id=67646
846
847         Reviewed by Csaba Osztrogonác.
848
849         * Scripts/webkitdirs.pm:
850
851 2011-09-06  Eric Boren  <borenet@gmail.com>
852
853         [Chromium] Modify WebTouchEvent structure to match WebCore::TouchEvent
854         https://bugs.webkit.org/show_bug.cgi?id=66800
855
856         Reviewed by Darin Fisher.
857
858         * DumpRenderTree/chromium/EventSender.cpp:
859         (EventSender::sendCurrentTouchEvent):
860
861 2011-09-06  Adam Barth  <abarth@webkit.org>
862
863         garden-o-matic details view should having working rebaseline and next/previous buttons
864         https://bugs.webkit.org/show_bug.cgi?id=67659
865
866         Reviewed by Dimitri Glazkov.
867
868         This patch wires up basic back/forward buttons that let you traverse
869         through the results we're examining in the details view.  This ended up
870         being more code than I expected, but I wanted to keep all the state
871         information in the DOM itself.
872
873         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
874         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
875         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
876
877 2011-09-01  Dirk Pranke  <dpranke@chromium.org>
878
879         fix MockFileSystem.glob(), refactor filesystem tests
880         https://bugs.webkit.org/show_bug.cgi?id=67462
881
882         Reviewed by Eric Seidel.
883
884         In debugging why my proposed change for MockFileSystem.glob()
885         in bug 66228 didn't work, I stumbled across two real bugs
886         that cancelled each other out for the unit tests. I fixed those
887         (glob shouldn't recurse into subdirs, and we weren't populating
888         self.dirs from self.files properly).
889
890         I have also created a "mixin" class for tests that can be shared
891         between the real filesystem and the mock filesystem - MockFileSystem
892         is being used enough it needs its own tests.
893
894         * Scripts/webkitpy/common/system/filesystem_mock.py:
895         * Scripts/webkitpy/common/system/filesystem_mock_unittest.py: Added.
896         * Scripts/webkitpy/common/system/filesystem_unittest.py:
897
898 2011-09-06  Anders Carlsson  <andersca@apple.com>
899
900         Move NPAPI headers in bridge to plugins
901         https://bugs.webkit.org/show_bug.cgi?id=67661
902
903         Update forwarding headers.
904
905         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npapi.h:
906         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npruntime.h:
907
908 2011-09-06  Tony Chang  <tony@chromium.org>
909
910         [chromium] Check in 'build' for compiled binaries first
911         https://bugs.webkit.org/show_bug.cgi?id=67549
912
913         Reviewed by Dirk Pranke.
914
915         I'm working on moving the windows build output to a common location
916         rather than relative to the sln file.  Because of that, we need to
917         check those build locations first for DumpRenderTree.exe.
918
919         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
920
921 2011-09-06  Adam Barth  <abarth@webkit.org>
922
923         Use a hierarchial structure for the garden-o-matic results view
924         https://bugs.webkit.org/show_bug.cgi?id=67620
925
926         Reviewed by Dimitri Glazkov.
927
928         This patch re-organizes the results view to use a hierachial structure
929         for selection.  At the top-level are sections for each test.  Expanding
930         the test section shows a tab selector for builders.
931
932         This structure prepares us for wiring up various actions to this view.
933
934         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
935         (.):
936         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
937         ():
938         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
939         (.):
940         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
941         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
942         (.results-view>.toolbar):
943         (.results-view>.toolbar ul.actions):
944         (.results-view>.toolbar ul.actions li):
945         (.results-grid table):
946         (.results-grid table td, .results-view table th):
947         (.results-grid table th):
948         (.results-grid .text-result):
949         (.results-grid .image-result):
950
951 2011-09-06  Adam Barth  <abarth@webkit.org>
952
953         garden-o-matic's base.probe generates spam in the JavaScript console
954         https://bugs.webkit.org/show_bug.cgi?id=67622
955
956         Reviewed by Dimitri Glazkov.
957
958         Now that we have CORS set up on the buildbot, we can use XMLHttpRequest
959         instead of HTMLScriptElement to test whether results exist.  This
960         reduces the console.log spam and saves bandwidth because we can use a
961         HEAD request instead of a GET request.
962
963         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/net.js:
964
965 2011-09-05  Adam Barth  <abarth@webkit.org>
966
967         Add a tab to garden-o-matic for viewing expected failures
968         https://bugs.webkit.org/show_bug.cgi?id=67619
969
970         Reviewed by Dimitri Glazkov.
971
972         This patch adds a basic tab to garden-o-matic that shows all the tests
973         failing on the bots, including the expected failures.  This patch
974         mostly involves refactoring existing classes to allow new subclasses.
975
976         This view is useful for when gardeners mark tests as expected to fail
977         and then rebaseline them later.
978
979         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
980         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
981         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
982         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary-mock.js:
983         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
984         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
985         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
986
987 2011-09-05  Adam Barth  <abarth@webkit.org>
988
989         Fix global variable leak in garden-o-matic
990         https://bugs.webkit.org/show_bug.cgi?id=67617
991
992         Reviewed by Dimitri Glazkov.
993
994         Caught by running the unit tests with noglobals turned on.
995
996         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
997
998 2011-09-05  Balazs Kelemen  <kbalazs@webkit.org>
999
1000         [Qt][WK2] Add pixel test support
1001         https://bugs.webkit.org/show_bug.cgi?id=66283
1002
1003         Reviewed by Andreas Kling.
1004
1005         Implemented pixel result generation by reusing the logic
1006         that we have in DumpRenderTree.
1007         * WebKitTestRunner/qt/TestInvocationQt.cpp:
1008         (WTR::dumpImage):
1009         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
1010
1011 2011-09-04  Robin Dunn  <robin@alldunn.com>
1012
1013         [wx] Enable wxWebKit to run using the wxGC Cairo backend on platforms other than GTK.
1014         https://bugs.webkit.org/show_bug.cgi?id=67577
1015
1016         Reviewed by Kevin Ollivier.
1017
1018         * waf/build/settings.py:
1019
1020 2011-09-03  Kevin Ollivier  <kevino@theolliviers.com>
1021
1022         [wx] Unreviewed build fix. Add wtf/dtoa directory to build.
1023
1024         * waf/build/settings.py:
1025
1026 2011-09-03  Dan Bernstein  <mitz@apple.com>
1027
1028         32-bit build fix.
1029
1030         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
1031         (TestWebKitAPI::Util::toSTD):
1032
1033 2011-09-03  Dan Bernstein  <mitz@apple.com>
1034
1035         Move testStringByEvaluatingJavaScriptFromString() from DumpRenderTree to TestWebKitAPI
1036         https://bugs.webkit.org/show_bug.cgi?id=67559
1037
1038         Reviewed by Darin Adler.
1039
1040         * DumpRenderTree/mac/DumpRenderTree.mm:
1041         (dumpRenderTree): Moved testStringByEvaluatingJavaScriptFromString() from here and removed
1042         the call to it.
1043         * TestWebKitAPI/PlatformUtilities.h: Declared Util::toSTD(NSString *)
1044         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added StringByEvaluatingJavaScriptFromString.mm.
1045         * TestWebKitAPI/Tests/mac/StringByEvaluatingJavaScriptFromString.mm: Added.
1046         (TestWebKitAPI::TEST): Added. Moved testStringByEvaluatingJavaScriptFromString() to here.
1047         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
1048         (TestWebKitAPI::Util::toSTD): Added.
1049
1050 2011-09-03  Adam Barth  <abarth@webkit.org>
1051
1052         garden-o-matic results view should have a better results selector
1053         https://bugs.webkit.org/show_bug.cgi?id=67542
1054
1055         Reviewed by Dimitri Glazkov.
1056
1057         This patch adds a basic grid-based results selector to the results
1058         view.  Currently, this grid just shows how the tests fail on the
1059         various bots.  A future patch will let you select which failure to view
1060         and to mark the failures for rebaselining.
1061
1062         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
1063         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
1064           - Add some more basic functions for manipulating dictionaries.
1065         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
1066         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
1067         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
1068
1069 2011-09-03  Adam Barth  <abarth@webkit.org>
1070
1071         garden-o-matic results view should show Actual and Expected results for text failures
1072         https://bugs.webkit.org/show_bug.cgi?id=67536
1073
1074         Reviewed by Eric Seidel.
1075
1076         In the past, we didn't show actual and expected text results (we just
1077         showed the diff) because we didn't have the awesome six-by-two results
1078         grid.  Now that we do, we can move show these results.
1079
1080         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
1081         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
1082           - Fixed some typos that were preventing these unit tests from running.
1083         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
1084         (.):
1085         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
1086           - Report -actual.txt and -expected.txt as possible results URLs.
1087
1088 2011-09-03  Adam Barth  <abarth@webkit.org>
1089
1090         garden-o-matic shows "ghost" failures that are already fixed
1091         https://bugs.webkit.org/show_bug.cgi?id=67535
1092
1093         Reviewed by Eric Seidel.
1094
1095         About 10% of writes fail to stick on test-results.appspot.com.  This
1096         patch causes us to fetch the full_results.json blob directly from
1097         build.chromium.org rather than relying upon AppEngine.
1098
1099         Unforuntately, we still need to get historical information from
1100         AppEngine.  That will take several patches to fix becuase I need to
1101         change the bots to write the full_results.json file to the
1102         build-specific directory in addition to the zip file.
1103
1104         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
1105         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
1106         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
1107
1108 2011-09-03  Sheriff Bot  <webkit.review.bot@gmail.com>
1109
1110         Unreviewed, rolling out r94458.
1111         http://trac.webkit.org/changeset/94458
1112         https://bugs.webkit.org/show_bug.cgi?id=67558
1113
1114         Caused appcache test to fail on various bots (Requested by
1115         rniwa on #webkit).
1116
1117         * Scripts/webkitpy/layout_tests/port/webkit.py:
1118         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1119
1120 2011-09-03  Sheriff Bot  <webkit.review.bot@gmail.com>
1121
1122         Unreviewed, rolling out r94453.
1123         http://trac.webkit.org/changeset/94453
1124         https://bugs.webkit.org/show_bug.cgi?id=67557
1125
1126         Caused appcache test to fail on various bots (Requested by
1127         rniwa on #webkit).
1128
1129         * Scripts/webkitpy/layout_tests/port/webkit.py:
1130
1131 2011-09-02  Michael Saboff  <msaboff@apple.com>
1132
1133         Add JSC:RegExp functional tests
1134         https://bugs.webkit.org/show_bug.cgi?id=67339
1135
1136         New perl script to build JavaScriptCore and run the RegExp tests.
1137
1138         Reviewed by Gavin Barraclough.
1139
1140         * Scripts/run-regexp-tests: Added.
1141
1142 2011-09-02  Michael Saboff  <msaboff@apple.com>
1143
1144         Add JSC:RegExp functional tests
1145         https://bugs.webkit.org/show_bug.cgi?id=67339
1146
1147         New perl script to build JavaScriptCore and run the RegExp tests.
1148
1149         Reviewed by Gavin Barraclough.
1150
1151         * Scripts/run-regexp-tests: Added.
1152
1153 2011-09-02  Eric Seidel  <eric@webkit.org>
1154
1155         Reshuffle some code in WebKitDriver._read_block in preparation for reading stderr/stdout separately
1156         https://bugs.webkit.org/show_bug.cgi?id=67530
1157
1158         Unreviewed.  Fixing typo from previous commit.
1159
1160         Turns out there was *no* unittesting of WebKitDriver.  Added a basic test of _read_block
1161         which exercises the code I previously made a typo in.
1162
1163         * Scripts/webkitpy/layout_tests/port/webkit.py:
1164         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1165
1166 2011-09-02  Eric Seidel  <eric@webkit.org>
1167
1168         Reshuffle some code in WebKitDriver._read_block in preparation for reading stderr/stdout separately
1169         https://bugs.webkit.org/show_bug.cgi?id=67530
1170
1171         Reviewed by Adam Barth.
1172
1173         No functional change, just reshuffling code.
1174
1175         * Scripts/webkitpy/layout_tests/port/webkit.py:
1176
1177 2011-09-02  Darin Adler  <darin@apple.com>
1178
1179         Added Subversion ignore for .pyc generated files.
1180
1181         * Scripts/webkitpy/layout_tests/models: Added property svn:ignore.
1182         * Scripts/webkitpy/layout_tests/servers: Added property svn:ignore.
1183         * Scripts/webkitpy/tool/servers: Added property svn:ignore.
1184
1185 2011-09-02  Adam Barth  <abarth@webkit.org>
1186
1187         Enable testing on mac-ews
1188         https://bugs.webkit.org/show_bug.cgi?id=67505
1189
1190         Reviewed by Eric Seidel.
1191
1192         This patch enables testing on the Mac EWS, which should help
1193         contributors not turn the Mac bots red.
1194
1195         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1196
1197 2011-09-01  Beth Dakin  <bdakin@apple.com>
1198
1199         https://bugs.webkit.org/show_bug.cgi?id=67451
1200         Add a test for going back to a cached page after changing the device scale factor
1201
1202         Reviewed by Adam Roben.
1203
1204         New test DeviceScaleFactorOnBack.mm inherits from WebKitAgnosticTest.
1205         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1206         * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm: Added.
1207         (TestWebKitAPI::DeviceScaleFactorOnBack::url):
1208         (TestWebKitAPI::DeviceScaleFactorOnBack::didLoadURL):
1209         (TestWebKitAPI::DeviceScaleFactorOnBack::createWindow):
1210         (TestWebKitAPI::DeviceScaleFactorOnBack::initializeView):
1211         (TestWebKitAPI::DeviceScaleFactorOnBack::runTest):
1212         (TestWebKitAPI::TEST_F):
1213
1214         Added new function to WebKitAgnosticTest to goBack. Separated 
1215         waitForLoadToFinish() into its own function (instead of being a part of 
1216         loadAndWaitUntilFinished()) so that it can be called from goBack as 
1217         well. Also added initializeView() so we can set the cache model.
1218         * TestWebKitAPI/mac/WebKitAgnosticTest.h:
1219         (TestWebKitAPI::WebKitAgnosticTest::initializeView):
1220         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
1221         (TestWebKitAPI::WebKitAgnosticTest::WebKitAgnosticTest):
1222         (TestWebKitAPI::WebKitAgnosticTest::runWebKit1Test):
1223         (TestWebKitAPI::WebKitAgnosticTest::runWebKit2Test):
1224         (TestWebKitAPI::WebKitAgnosticTest::loadURL):
1225         (TestWebKitAPI::WebKitAgnosticTest::goBack):
1226         (TestWebKitAPI::WebKitAgnosticTest::waitForLoadToFinish):
1227
1228 2011-09-02  Anders Carlsson  <andersca@apple.com>
1229
1230         Build fix.
1231
1232         * DumpRenderTree/TestNetscapePlugIn/Tests/PrivateBrowsing.cpp:
1233         (PrivateBrowsing::ScriptableObject::pluginTest):
1234
1235 2011-09-02  Anders Carlsson  <andersca@apple.com>
1236
1237         Move private browsing test to a PluginTest subclass
1238         https://bugs.webkit.org/show_bug.cgi?id=67498
1239
1240         Reviewed by Darin Adler.
1241
1242         * DumpRenderTree/DumpRenderTree.gypi:
1243         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1244         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
1245         (pluginGetProperty):
1246         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
1247         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
1248         (PluginTest::NPP_SetValue):
1249         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
1250         * DumpRenderTree/TestNetscapePlugIn/Tests/PrivateBrowsing.cpp: Added.
1251         (PrivateBrowsing::PrivateBrowsing):
1252         (PrivateBrowsing::privateBrowsingEnabled):
1253         (PrivateBrowsing::cachedPrivateBrowsingEnabled):
1254         (PrivateBrowsing::ScriptableObject::hasProperty):
1255         (PrivateBrowsing::ScriptableObject::getProperty):
1256         (PrivateBrowsing::ScriptableObject::pluginTest):
1257         (PrivateBrowsing::NPP_New):
1258         (PrivateBrowsing::NPP_GetValue):
1259         (PrivateBrowsing::NPP_SetValue):
1260         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1261         (NPP_New):
1262         (NPP_SetValue):
1263         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1264         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1265         * GNUmakefile.am:
1266
1267 2011-09-02  Csaba Osztrogonác  <ossy@webkit.org>
1268
1269         [Qt] Build dependency problems
1270         https://bugs.webkit.org/show_bug.cgi?id=38054
1271
1272         Trivial fix after r94288.
1273
1274         Rubber-stamped by Andras Becsi.
1275
1276         * Scripts/webkitdirs.pm: We should read the whole defaults.txt, not only the first two lines.
1277         (buildQMakeProject):
1278
1279 2011-09-02  Andras Becsi  <andras.becsi@nokia.com>
1280
1281         Remove my old e-mail address and add my new one.
1282
1283         Rubber-stamped by Tor Arne Vestbø.
1284
1285         * Scripts/webkitpy/common/config/committers.py:
1286
1287 2011-09-02  Philippe Normand  <pnormand@igalia.com>
1288
1289         [GTK] run-gtk-tests leaves a zombie Xvfb process
1290         https://bugs.webkit.org/show_bug.cgi?id=67389
1291
1292         Reviewed by Martin Robinson.
1293
1294         * Scripts/run-gtk-tests: Properly close STDIN and STDERR on the
1295         child process instead of doing shell redirection.
1296
1297 2011-09-01  Mark Rowe  <mrowe@apple.com>
1298
1299         Fix the build by adding some more missing return types.
1300
1301         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1302         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
1303
1304 2011-09-01  Eric Seidel  <eric@webkit.org>
1305
1306         REGRESSION (NRWT): Leaks Viewer can't load leaks from test runs that used NRWT
1307         https://bugs.webkit.org/show_bug.cgi?id=66228
1308
1309         Reviewed by Dirk Pranke.
1310
1311         ORWT used $(PROCESS)$(NUMBER)-leaks.txt for leaks filenames.
1312         The LeaksViewer tool globs for all *-leaks.txt files.
1313         This patch makes NRWT output $(PROCESS)-$(PID)-leaks.txt which should match.
1314
1315         In order to test this I had to fix a limitation in our MockFileSystem.glob
1316         method.  However, doing so uncovered a typo and bug in the integration tests.
1317         I've disabled the offending integration tests.
1318
1319         * Scripts/webkitpy/common/system/filesystem_mock.py:
1320         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
1321         * Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:
1322
1323 2011-09-01  Dominic Mazzoni  <dmazzoni@google.com>
1324
1325         Adds a LayoutTestController method to make it possible to test
1326         starting speech input via an API call.
1327         https://bugs.webkit.org/show_bug.cgi?id=60170
1328
1329         Reviewed by Dimitri Glazkov.
1330
1331         * DumpRenderTree/LayoutTestController.h:
1332         * DumpRenderTree/chromium/LayoutTestController.cpp:
1333         (LayoutTestController::LayoutTestController):
1334         (LayoutTestController::startSpeechInput):
1335         * DumpRenderTree/chromium/LayoutTestController.h:
1336         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1337         (LayoutTestController::startSpeechInput):
1338         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1339         (LayoutTestController::startSpeechInput):
1340         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1341         (LayoutTestController::startSpeechInput):
1342         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1343         (LayoutTestController::startSpeechInput):
1344         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1345         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1346         (LayoutTestController::startSpeechInput):
1347         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1348         (LayoutTestController::startSpeechInput):
1349
1350 2011-09-01  Tim Horton  <hortont424@gmail.com>
1351
1352         Fix TestWebKitAPI build on clang-2.0
1353
1354         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
1355
1356 2011-09-01  Adam Barth  <abarth@webkit.org>
1357
1358         Remove unused "extension" parameter from rebaseline gardeningserver handler
1359         https://bugs.webkit.org/show_bug.cgi?id=67384
1360
1361         Reviewed by James Robinson.
1362
1363         This parameter hasn't done anything in a while.
1364
1365         * Scripts/webkitpy/tool/commands/rebaseline.py:
1366         * Scripts/webkitpy/tool/servers/gardeningserver.py:
1367         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
1368
1369 2011-09-01  Eric Seidel  <eric@webkit.org>
1370
1371         Unreviewed.
1372
1373         Fix a typo in unittests.  Unfortunately fixing it
1374         caused several assertions.  Just disabling the test
1375         instead, since it was providing no value before due to the typo.
1376
1377         * Scripts/webkitpy/layout_tests/port/test.py:
1378
1379 2011-09-01  Adam Barth  <abarth@webkit.org>
1380
1381         Add a "rebaseline" button to the garden-o-matic summary page
1382         https://bugs.webkit.org/show_bug.cgi?id=67382
1383
1384         Reviewed by Dimitri Glazkov.
1385
1386         As much as we might wish folks to not rebaseline entire test groups at
1387         once, the truth is that doing so is a common operation.  Adding a
1388         button for this operation is likely to make folks happy.
1389
1390         This patch also cleans up a bunch of plumbing surrounding failureInfo
1391         objects.
1392
1393         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
1394         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
1395         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
1396         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
1397         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
1398         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
1399         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
1400         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
1401         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
1402         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
1403
1404 2011-09-01  Adam Barth  <abarth@webkit.org>
1405
1406         garden-o-matic should let the gardener assign blame for a group of test failures
1407         https://bugs.webkit.org/show_bug.cgi?id=67379
1408
1409         Reviewed by Dimitri Glazkov.
1410
1411         If a group of test failures has a large revision range, the gardener
1412         might wish to blame a specific revision for the failure.  Currently,
1413         this only effect of assigning blame in this way is to hide the other
1414         suspect commits.
1415
1416         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
1417         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
1418         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
1419
1420 2011-09-01  Adam Barth  <abarth@webkit.org>
1421
1422         Hide garden-o-matic failure table until hover
1423         https://bugs.webkit.org/show_bug.cgi?id=67376
1424
1425         Reviewed by Dimitri Glazkov.
1426
1427         This patch removes the failure table for build failures (because it
1428         does not make sense) and hides the failure table for test groups until
1429         the user hovers over the test failure block, reducing visual noise.
1430
1431         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
1432         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
1433         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
1434
1435 2011-09-01  Adam Barth  <abarth@webkit.org>
1436
1437         Switch garden-o-matic from commitData.title to commitData.summary
1438         https://bugs.webkit.org/show_bug.cgi?id=67375
1439
1440         Reviewed by Dimitri Glazkov.
1441
1442         commitData.title is a string provided by Trac, which isn't great in all
1443         cases.  commitData.summary is my attempt to find the most important
1444         one-line summary of the commit.  This patch switches garden-o-matic
1445         over to summary.
1446
1447         Also, this patch tweaks a bunch of CSS to tighten up the summary page
1448         and reduce visual noise.
1449
1450         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
1451         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
1452         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
1453
1454 2011-09-01  Adam Barth  <abarth@webkit.org>
1455
1456         Group failing tests in garden-o-matic if there are more than three in a folder
1457         https://bugs.webkit.org/show_bug.cgi?id=67373
1458
1459         Reviewed by Dimitri Glazkov.
1460
1461         Sometimes a failure will cause many tests in a given directory to fail.
1462         When that happens, it's better to list the directory as a single item
1463         (with a count) rather than spamming all the test names.
1464
1465         (This patch also updates a bunch of unit test expected results after my last commit.)
1466
1467         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
1468         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
1469         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
1470         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
1471         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
1472
1473 2011-09-01  Adam Barth  <abarth@webkit.org>
1474
1475         Lower the visual noise from the failing builders display
1476         https://bugs.webkit.org/show_bug.cgi?id=67369
1477
1478         Reviewed by Dimitri Glazkov.
1479
1480         This patch ensures that the "Building" row in the failing builders
1481         display is always last and dims it by 50% to reduce visual noise.  This
1482         lets the gardener focus on the actual failures.
1483
1484         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
1485         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
1486         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/failures.css: Added.
1487
1488 2011-09-01  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
1489
1490         [Qt] Build dependency problems
1491         https://bugs.webkit.org/show_bug.cgi?id=38054
1492
1493         Make clean build after the defines are changed.
1494
1495         Reviewed by Csaba Osztrogonác.
1496
1497         * Scripts/webkitdirs.pm:
1498         (buildQMakeProject):
1499
1500 2011-08-31  Adam Barth  <abarth@webkit.org>
1501
1502         Move DumpRenderTree to WebKitPlatformSupport
1503         https://bugs.webkit.org/show_bug.cgi?id=67331
1504
1505         Reviewed by Darin Fisher.
1506
1507         This patch update DumpRenderTree to account for the WebKitClient =>
1508         WebKitPlatformSupport rename.
1509
1510         * DumpRenderTree/chromium/NotificationPresenter.cpp:
1511         (NotificationPresenter::show):
1512         * DumpRenderTree/chromium/Task.cpp:
1513         (postTask):
1514
1515 2011-08-31  Eric Seidel  <eric@webkit.org>
1516
1517         Add queues.webkit.org/active-bots page to make it easy to see which bots are down
1518         https://bugs.webkit.org/show_bug.cgi?id=67314
1519
1520         Reviewed by Adam Barth.
1521
1522         Very simple page.  Just lists all the bots, what queue they belong to and what we last heard from them.
1523         If we haven't heard from a bot in the last 500 messages (last day or so), then it won't show up here.
1524         This makes it very easy for me to see which of my cr-jail bots might be down at any one time.
1525
1526         I also moved a bunch of code into dashboard.css which belonged there.
1527
1528         * QueueStatusServer/handlers/activebots.py: Added.
1529         * QueueStatusServer/main.py:
1530         * QueueStatusServer/stylesheets/dashboard.css:
1531         (.queue_bubble):
1532         (.queue_name):
1533         (.last_heard_from):
1534         (.status_text):
1535         (.alive):
1536         (.behind):
1537         (.dead):
1538         * QueueStatusServer/templates/activebots.html: Added.
1539         * QueueStatusServer/templates/dashboard.html:
1540         * QueueStatusServer/templates/recentstatus.html:
1541
1542 2011-08-31  Oliver Hunt  <oliver@apple.com>
1543
1544         Move CheckedArithmeticOperations.cpp to the intended location
1545
1546         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1547         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp: Renamed from Tools/TestWebKitAPI/Tests/CheckedArithmeticOperations.cpp.
1548
1549 2011-08-31  Elliot Poger  <epoger@google.com>
1550
1551         add unittest to validate the complete set of Chromium configurations
1552         https://bugs.webkit.org/show_bug.cgi?id=67211
1553
1554         Reviewed by Adam Barth.
1555
1556         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1557
1558 2011-08-31  Nico Weber  <thakis@chromium.org>
1559
1560         Make ScrollAnimator(Chromium)?Mac check scrollAnimatorEnabled()
1561         https://bugs.webkit.org/show_bug.cgi?id=67297
1562
1563         Reviewed by Tony Chang.
1564
1565         Explicitly disable smooth scrolling in chromium's DRT.
1566
1567         * DumpRenderTree/chromium/WebPreferences.cpp:
1568         (WebPreferences::applyTo):
1569
1570 2011-08-31  Oliver Hunt  <oliver@apple.com>
1571
1572         Add Checked<> tests to windows build
1573
1574         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1575
1576 2011-08-30  Oliver Hunt  <oliver@apple.com>
1577
1578         Add support for checked arithmetic
1579         https://bugs.webkit.org/show_bug.cgi?id=67095
1580
1581         Reviewed by Sam Weinig.
1582
1583         Add test cases for Checked<>
1584
1585         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1586         * TestWebKitAPI/Tests/CheckedArithmeticOperations.cpp: Added.
1587
1588 2011-08-31  Adam Barth  <abarth@webkit.org>
1589
1590         Move summary.html to garden-o-matic.html.
1591
1592         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html.
1593         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js.
1594         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js: Removed.
1595         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Removed.
1596
1597 2011-08-31  Noel Gordon  <noel.gordon@gmail.com>
1598
1599         [chromium] DRT linux should pass nativeKeyCode to plugins
1600         https://bugs.webkit.org/show_bug.cgi?id=66679
1601
1602         Reviewed by Tony Chang.
1603
1604         * DumpRenderTree/chromium/EventSender.cpp:
1605         (EventSender::keyDown):  Call a Chromium Linux GTK helper routine that returns the
1606         (simulated) nativeKeyCode for the given input keyboard code.
1607
1608 2011-08-31  Adam Barth  <abarth@webkit.org>
1609
1610         Tighen up UI for garden-o-matic tab strip
1611         https://bugs.webkit.org/show_bug.cgi?id=67266
1612
1613         Reviewed by Dimitri Glazkov.
1614
1615         This patch add CSS to move the tab strip to the edges of the page and
1616         to remove some gratuitous border-radius.
1617
1618         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css:
1619         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:
1620
1621 2011-08-31  Adam Barth  <abarth@webkit.org>
1622
1623         garden-o-matic results view shouldn't be horrifically ugly
1624         https://bugs.webkit.org/show_bug.cgi?id=67264
1625
1626         Reviewed by Dimitri Glazkov.
1627
1628         Minor tweak to the results view CSS to make it fit in better with the new tabbed UI.
1629
1630         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
1631         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
1632         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
1633
1634 2011-08-31  Adam Barth  <abarth@webkit.org>
1635
1636         garden-o-matic needs a tabstrip
1637         https://bugs.webkit.org/show_bug.cgi?id=67263
1638
1639         Reviewed by Dimitri Glazkov.
1640
1641         This patch adds a basic tabstrip to garden-o-matic.  The results
1642         details view now opens in the "Results" tab, and the user can flip back
1643         and forth between the Summary and the Results tab quickly.  There's
1644         also a stub for a "Commits" tab, which is disabled.
1645
1646         This patch isn't the most beautiful in the world, but it gets the ball
1647         rolling on a multi-modal UI.
1648
1649         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
1650         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js:
1651         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
1652         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css:
1653         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:
1654
1655 2011-08-31  Ai Makabi  <makabi@google.com>
1656
1657         Extract reference links from reftest test file.
1658         https://bugs.webkit.org/show_bug.cgi?id=66838
1659
1660         Reviewed by Shinichiro Hamaji.
1661
1662         * Scripts/webkitpy/layout_tests/reftests/__init__.py: Added.
1663         * Scripts/webkitpy/layout_tests/reftests/extract_reference_link.py: Added.
1664         * Scripts/webkitpy/layout_tests/reftests/extract_reference_link_unittest.py: Added.
1665
1666 2011-08-03  Philippe Normand  <pnormand@igalia.com>
1667
1668         [webkitpy] missing log import in common/net/resultsjsonparser.py
1669         https://bugs.webkit.org/show_bug.cgi?id=65606
1670
1671         Reviewed by Martin Robinson.
1672
1673         * Scripts/webkitpy/common/net/resultsjsonparser.py: Import the logging module.
1674
1675 2011-08-30  Philippe Normand  <pnormand@igalia.com>
1676
1677         [stylechecker] complains about NULL usage in some gst_structure_ calls
1678         https://bugs.webkit.org/show_bug.cgi?id=67194
1679
1680         Reviewed by Martin Robinson.
1681
1682         Don't warn about NULL in some gst_structure_ calls. 0 can't be
1683         used for these, a proper sentinel is required.
1684
1685         * Scripts/webkitpy/style/checkers/cpp.py:
1686         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1687
1688 2011-08-30  Adam Barth  <abarth@webkit.org>
1689
1690         Remove old-style UI from garden-o-matic
1691         https://bugs.webkit.org/show_bug.cgi?id=67257
1692
1693         Reviewed by Dimitri Glazkov.
1694
1695         This code is nowhere near as awesome as the new hotness.  Let's remove
1696         it so it doesn't weigh us down.
1697
1698         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html: Removed.
1699         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/main.js: Removed.
1700         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
1701         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
1702         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/unexpected-passes.js: Removed.
1703         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/unexpected-passes.html: Removed.
1704
1705 2011-08-30  Takashi Toyoshima  <toyoshim@chromium.org>
1706
1707         [WebSocket] update pywebsocket to 0.6b5.
1708         https://bugs.webkit.org/show_bug.cgi?id=66924
1709
1710         Reviewed by Kent Tamura.
1711
1712         pywebsocket 0.6b2 supported minimum features of Hybi-08 specification.
1713         Now, pywebsocket 0.6b5 supports full features of Hybi-10 specification.
1714         0.6b3 or later supports a closing handshake handler and it is useful to
1715         verify client's closing handshake implementation.
1716         0.6b4 supports AbortedByUserException. It is useful to eliminate
1717         unnecessary server warning messages on intended abnormal closures.
1718         0.6b5 supports Python 2.5.1 or Mac 10.5.
1719
1720         * Scripts/webkitpy/thirdparty/__init__.py:
1721         Update download URL and directory path.
1722
1723 2011-08-30  Dan Bernstein  <mitz@apple.com>
1724
1725         Test for <rdar://problem/9281695> Add text search API for getting the DOM range of a text match
1726         https://bugs.webkit.org/show_bug.cgi?id=67230
1727
1728         Reviewed by Darin Adler.
1729
1730         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1731         * TestWebKitAPI/Tests/mac/DOMRangeOfString.html: Added.
1732         * TestWebKitAPI/Tests/mac/DOMRangeOfString.mm: Added.
1733         (-[DOMRangeOfStringFrameLoadDelegate webView:didFinishLoadForFrame:]):
1734         (TestWebKitAPI::TEST):
1735
1736 2011-08-30  Aaron Colwell  <acolwell@chromium.org>
1737
1738         Add MediaSource API to HTMLMediaElement
1739         https://bugs.webkit.org/show_bug.cgi?id=64731
1740
1741         Reviewed by Eric Carlson.
1742
1743         * Scripts/build-webkit:
1744
1745 2011-08-30  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
1746
1747         Emit last progress notification before calling dispatchDidFinishLoad
1748         https://bugs.webkit.org/show_bug.cgi?id=28851
1749
1750         Reviewed by Adam Barth.
1751
1752         Implement dumpProgressFinishedCallback() in the layoutTestController for Qt,
1753         Chromium and GTK ports. The first two were simple changes.
1754
1755         Some refactoring was needed in GTK port to assure that the dumps are emitted
1756         correctly and the processing after the page load finished is in the right place.
1757
1758         To detect the load finished, we use the callback for the "load-status" notifier
1759         signal of the top loading frame. And we use the deprecated "load-finished" signal
1760         for dumping (if enabled) the progress finished expected output.
1761
1762         * DumpRenderTree/LayoutTestController.cpp:
1763         (LayoutTestController::LayoutTestController):
1764         (dumpProgressFinishedCallbackCallback):
1765         (LayoutTestController::staticFunctions):
1766         * DumpRenderTree/LayoutTestController.h:
1767         (LayoutTestController::dumpProgressFinishedCallback):
1768         (LayoutTestController::setDumpProgressFinishedCallback):
1769         * DumpRenderTree/chromium/LayoutTestController.cpp:
1770         (LayoutTestController::LayoutTestController):
1771         (LayoutTestController::dumpProgressFinishedCallback):
1772         (LayoutTestController::reset):
1773         * DumpRenderTree/chromium/LayoutTestController.h:
1774         (LayoutTestController::shouldDumpProgressFinishedCallback):
1775         (LayoutTestController::setShouldDumpProgressFinishedCallback):
1776         * DumpRenderTree/chromium/WebViewHost.cpp:
1777         (WebViewHost::didStopLoading):
1778         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1779         (webViewLoadFinished):
1780         (topLoadingFrameLoadFinished):
1781         (webFrameLoadStatusNotified):
1782         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1783         (LayoutTestController::reset):
1784         (LayoutTestController::dumpProgressFinishedCallback):
1785         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1786
1787 2011-08-30  Filip Pizlo  <fpizlo@apple.com>
1788
1789         JavaScriptCore does not have a good mechanism for performance
1790         regression testing
1791         https://bugs.webkit.org/show_bug.cgi?id=67177
1792
1793         Reviewed by Darin Adler.
1794         
1795         Added a new script, which allows for testing one, two, or more VMs
1796         at once on SunSpider, V8, and Kraken benchmarks.  Benchmark/VM runs
1797         are interleaved at random to minimize systematics.  The results
1798         that bencher prints includes all possible relevant information about
1799         how bencher was invoked.  Bencher can be easily used to measure
1800         performance changes down to fractions of a percent.
1801         
1802         Bencher also includes experimental support for running benchmarks in
1803         a DumpRenderTree release build.  This works in SunSpider and V8, but
1804         not yet in Kraken.  Running benchmarks in DumpRenderTree more
1805         closely mimics the performance when running in browser.
1806
1807         * Scripts/bencher: Added.
1808
1809 2011-08-29  Alexey Proskuryakov  <ap@apple.com>
1810
1811         DumpRenderTree should begin each test with an empty cookie store
1812         https://bugs.webkit.org/show_bug.cgi?id=63545
1813         <rdar://problem/5666907>
1814
1815         Reviewed by Darin Adler.
1816
1817         * DumpRenderTree/mac/DumpRenderTree.mm:
1818         (resetDefaultsToConsistentValues):
1819         (setDefaultsToConsistentValuesForTesting):
1820         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1821         (LayoutTestController::setAlwaysAcceptCookies):
1822         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1823         (WTR::InjectedBundle::beginTesting):
1824         Use new SPIs to manipulate sessions.
1825
1826 2011-08-30  Sheriff Bot  <webkit.review.bot@gmail.com>
1827
1828         Unreviewed, rolling out r94055 and r94057.
1829         http://trac.webkit.org/changeset/94055
1830         http://trac.webkit.org/changeset/94057
1831         https://bugs.webkit.org/show_bug.cgi?id=67191
1832
1833         Many failures on Mac 10.5 (Requested by toyoshim on #webkit).
1834
1835         * Scripts/webkitpy/thirdparty/__init__.py:
1836
1837 2011-08-30  Adam Barth  <abarth@webkit.org>
1838
1839         Chromium Android should not be a core builder
1840         https://bugs.webkit.org/show_bug.cgi?id=67184
1841
1842         Reviewed by Ryosuke Niwa.
1843
1844         This bot hasn't been consistently green yet because it has never actually run!
1845
1846         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1847         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1848
1849 2011-08-30  Takashi Toyoshima  <toyoshim@chromium.org>
1850
1851         [WebSocket] update pywebsocket to 0.6b4.
1852         https://bugs.webkit.org/show_bug.cgi?id=66924
1853
1854         Reviewed by Kent Tamura.
1855
1856         pywebsocket 0.6b2 supported minimum features of Hybi-08 specification.
1857         Now, pywebsocket 0.6b4 supports full features of Hybi-10 specification.
1858         0.6b3 or later supports a closing handshake handler and it is useful to
1859         verify client's closing handshake implementation.
1860         0.6b4 supports AbortedByUserException. It is useful to eliminate
1861         unnecessary server warning messages on intended abnormal closures.
1862
1863         * Scripts/webkitpy/thirdparty/__init__.py:
1864         Update download URL and directory path.
1865
1866 2011-08-29  Tom Zakrajsek  <tomz@codeaurora.org>
1867
1868         sheriffbot "usage" help statements are wrong
1869         https://bugs.webkit.org/show_bug.cgi?id=67170
1870
1871         Reviewed by Adam Barth.
1872
1873         * Scripts/webkitpy/tool/bot/irc_command.py:
1874         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1875         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
1876
1877 2011-08-29  Adam Barth  <abarth@webkit.org>
1878
1879         Add support for chomium-mac (non-CoreGraphics) baselines
1880         https://bugs.webkit.org/show_bug.cgi?id=67163
1881
1882         Reviewed by Eric Seidel.
1883
1884         This patch teaches the non-CG chromium-mac bots to look at non-CG
1885         baselines.  However, the patch still leaves CG as the default set of
1886         baselines.
1887
1888         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
1889         * Scripts/webkitpy/common/config/build.py:
1890         * Scripts/webkitpy/common/config/build_unittest.py:
1891         * Scripts/webkitpy/layout_tests/port/builders.py:
1892         * Scripts/webkitpy/layout_tests/port/chromium.py:
1893         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1894         * Scripts/webkitpy/layout_tests/port/factory.py:
1895         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
1896         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
1897         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
1898         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1899
1900 2011-08-29  Shawn Singh  <shawnsingh@chromium.org>
1901
1902         Small fix in chromium port of new-run-webkit-tests.
1903         https://bugs.webkit.org/show_bug.cgi?id=67078
1904
1905         Reviewed by Dirk Pranke.
1906
1907         * Scripts/webkitpy/layout_tests/port/chromium.py:
1908
1909 2011-08-29  Sheriff Bot  <webkit.review.bot@gmail.com>
1910
1911         Unreviewed, rolling out r93987, r93992, r93995, r93998, and
1912         r93999.
1913         http://trac.webkit.org/changeset/93987
1914         http://trac.webkit.org/changeset/93992
1915         http://trac.webkit.org/changeset/93995
1916         http://trac.webkit.org/changeset/93998
1917         http://trac.webkit.org/changeset/93999
1918         https://bugs.webkit.org/show_bug.cgi?id=67147
1919
1920         Many failing tests (Requested by ap on #webkit).
1921
1922         * DumpRenderTree/mac/DumpRenderTree.mm:
1923         (setDefaultsToConsistentValuesForTesting):
1924         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1925         (WTR::InjectedBundle::beginTesting):
1926
1927 2011-08-26  Alexey Proskuryakov  <ap@apple.com>
1928
1929         DumpRenderTree should begin each test with an empty cookie store
1930         https://bugs.webkit.org/show_bug.cgi?id=63545
1931         <rdar://problem/5666907>
1932
1933         Reviewed by Darin Adler.
1934
1935         * DumpRenderTree/mac/DumpRenderTree.mm:
1936         (setDefaultsToConsistentValuesForTesting):
1937         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1938         (WTR::InjectedBundle::beginTesting):
1939         Tell WebCore to use a temporary session, starting with a clean cookie store.
1940
1941 2011-08-23  Chris Marrin  <cmarrin@apple.com>
1942
1943         [mac] requestAnimationFrame support for mac port
1944         https://bugs.webkit.org/show_bug.cgi?id=59146
1945
1946         Reviewed by Simon Fraser.
1947
1948         Add support for request-animation-callback flag
1949
1950         * Scripts/build-webkit:
1951
1952 2011-08-27  Peter Beverloo  <peter@chromium.org>
1953
1954         Add a build bot for Chromium with OS(ANDROID)
1955         https://bugs.webkit.org/show_bug.cgi?id=66687
1956
1957         Reviewed by Adam Barth.
1958
1959         * BuildSlaveSupport/build.webkit.org-config/config.json:
1960
1961 2011-08-27  Peter Beverloo  <peter@chromium.org>
1962
1963         Update the master build bot configuration script to properly
1964         deal with the --chromium-android switch.
1965         https://bugs.webkit.org/show_bug.cgi?id=66687
1966
1967         The --chromium-android switch is needed when running
1968         update-webkit-chromium and build-webkit, as it'll tell the
1969         scripts to pull in the right dependencies and cross-compile
1970         WebKit using the Android NDK.
1971
1972         Reviewed by Adam Barth.
1973
1974         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1975
1976 2011-08-27  Peter Beverloo  <peter@chromium.org>
1977
1978         Teach the update and build scripts how to handle dependencies
1979         and cross-compiling rules for the Chromium port on OS(ANDROID).
1980         https://bugs.webkit.org/show_bug.cgi?id=66687
1981
1982         Reviewed by Adam Barth.
1983
1984         * Scripts/build-webkit:
1985         * Scripts/update-webkit:
1986         * Scripts/update-webkit-chromium:
1987         * Scripts/webkitdirs.pm:
1988         (argumentsForConfiguration):
1989         (isChromium):
1990         (isChromiumAndroid):
1991         (determineIsChromiumAndroid):
1992         (buildChromium):
1993
1994 2011-08-26  Adam Barth  <abarth@webkit.org>
1995
1996         garden-o-matic should let me know that I need to run the local server
1997         https://bugs.webkit.org/show_bug.cgi?id=66985
1998
1999         Reviewed by Dimitri Glazkov.
2000
2001         The patch triggers an alert dialog whenever the user tries to use a
2002         feature that requires the local server.
2003
2004         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
2005         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
2006         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js:
2007
2008 2011-08-26  Dimitri Glazkov  <dglazkov@chromium.org>
2009
2010         garden-o-matic summary view should have pretty commit data information.
2011         https://bugs.webkit.org/show_bug.cgi?id=67069
2012
2013         Reviewed by Adam Barth.
2014
2015         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Added support for styling commit data.
2016         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Changed tests.
2017         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css: Defined global anchor color.
2018         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css: Styled commit data.
2019
2020 2011-08-26  Dimitri Glazkov  <dglazkov@chromium.org>
2021
2022         Tweak the use of Open Sans in garden-o-matic summary view to make it look decent on Windows and Linux.
2023         https://bugs.webkit.org/show_bug.cgi?id=67066
2024
2025         Reviewed by Adam Barth.
2026
2027         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary-mock.html: Tweaked.
2028         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Ditto.
2029
2030 2011-08-26  Raphael Kubo da Costa  <kubo@profusion.mobi>
2031
2032         [DRT] Include cairo.h in PixelDumpSupportCairo.h for EFL too.
2033         https://bugs.webkit.org/show_bug.cgi?id=67041
2034
2035         Reviewed by Martin Robinson.
2036
2037         This is a follow-up to r89053: EFL's PixelDumpSupportEfl.cpp includes
2038         PixelDumpSupportCairo.h, but the latter was #including cairo.h only
2039         when the GTK+ port was being built.
2040
2041         * DumpRenderTree/cairo/PixelDumpSupportCairo.h:
2042
2043 2011-08-26  Dimitri Glazkov  <dglazkov@chromium.org>
2044
2045         Clean up and line up layout in garden-o-matic summary view.
2046         https://bugs.webkit.org/show_bug.cgi?id=67057
2047
2048         1) Renamed ui.notifications.TestFailures to ui.notifications.TestsFailing to match BuildersFailing;
2049         2) Rearranged DOM structure a bit to accommodate recent changes;
2050         3) Added minimal CSS to line things up.
2051
2052         Reviewed by Adam Barth.
2053
2054         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js: Renamed TestFailures to TestsFailing.
2055         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary-mock.js: Added mocks for BuildersFailing.
2056         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js: Renamed TestFailures to TestsFailing.
2057         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js: Updated tests.
2058         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Changed DOM structure.
2059         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Updated tests.
2060         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css: Tweaked common appearance.
2061         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css: Added minimal layout/style.
2062         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary-mock.html: Added Google Web Fonts hook.
2063         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Ditto.
2064
2065 2011-08-26  Alice Liu  <alice.liu@apple.com>
2066
2067         https://bugs.webkit.org/show_bug.cgi?id=66823
2068         Add the request info to the WebPageProxy::CreateNewPage message
2069
2070         Reviewed by Anders Carlsson.
2071
2072         Update function declarations with additional parameter:
2073         * MiniBrowser/gtk/BrowserWindow.c:
2074         (createNewPage):
2075         * MiniBrowser/mac/BrowserWindowController.m:
2076         (createNewPage):
2077         * MiniBrowser/win/BrowserView.cpp:
2078         (createNewPage):
2079         * WebKitTestRunner/TestController.cpp:
2080         (WTR::TestController::createOtherPage):
2081         * WebKitTestRunner/TestController.h:
2082
2083 2011-08-26  Noel Gordon  <noel.gordon@gmail.com>
2084
2085         Make show-pretty-diff work on linux
2086         https://bugs.webkit.org/show_bug.cgi?id=67017
2087
2088         Reviewed by Adam Barth.
2089
2090         * Scripts/show-pretty-diff:
2091
2092 2011-08-25  Dimitri Glazkov  <dglazkov@chromium.org>
2093
2094         Reorganize garden-o-matic CSS files to match JS-built views.
2095         https://bugs.webkit.org/show_bug.cgi?id=66998
2096
2097         Reviewed by Adam Barth.
2098
2099         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css: Added.
2100         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css: Added.
2101         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css: Added.
2102         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/summary.css: Removed.
2103         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary-mock.html: Changed to use new CSS files.
2104         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Ditto.
2105
2106 2011-08-25  Adam Barth  <abarth@webkit.org>
2107
2108         garden-o-matic should be able to roll out patches
2109         https://bugs.webkit.org/show_bug.cgi?id=66982
2110
2111         Reviewed by Dimitri Glazkov.
2112
2113         This patch just wires the rollout event through the controller to the
2114         local server, which is already set up to perform rollouts.
2115
2116         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
2117         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
2118         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
2119         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
2120
2121 2011-08-25  Viatcheslav Ostapenko  <ostapenko.viatcheslav@nokia.com>
2122
2123         [Qt] [WK2] Assert in computeViewportAttributes when MiniBrowser started with -touch
2124         https://bugs.webkit.org/show_bug.cgi?id=66951
2125
2126         Reviewed by Andreas Kling.
2127
2128         Function computeViewportAttributes() gets called when height is still 0 because MiniBrowser sets
2129         width and height one by one and setWidth cause geometryChange event in QTouchWebView. 
2130
2131         * MiniBrowser/qt/BrowserView.cpp:
2132         (BrowserView::resizeEvent):
2133
2134 2011-08-25  Dimitri Glazkov  <dglazkov@chromium.org>
2135
2136         garden-o-matic summary view should provide information on builders still in flight.
2137         https://bugs.webkit.org/show_bug.cgi?id=66992
2138
2139         Reviewed by Adam Barth.
2140
2141         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js: Added grabbing the list of in-flight builders.
2142         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js: Added buildersInFlightForRevision.
2143         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model_unittests.js: Added tests.
2144         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Split off updating builder results to own method.
2145         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Added tests.
2146
2147 2011-08-25  Adam Barth  <abarth@webkit.org>
2148
2149         webkit-patch rebaseline-expectations don't work when run outside the root
2150         https://bugs.webkit.org/show_bug.cgi?id=66966
2151
2152         Reviewed by Eric Seidel.
2153
2154         Turns out tool.path() used to be relative, which caused problems when
2155         running webkit-patch outside the root directory.  This patch makes it
2156         absolute.  I checked all callers, and they all appear to want this
2157         behavior.
2158
2159         It was unclear to me how to test this change because we only really
2160         have a testing strategy for webkitpy, not for the main script.
2161
2162         * Scripts/webkit-patch:
2163
2164 2011-08-25  Dimitri Glazkov  <dglazkov@chromium.org>
2165
2166         garden-o-matic summary needs a mock view that could be used for working on styling
2167         https://bugs.webkit.org/show_bug.cgi?id=66971
2168
2169         Reviewed by Adam Barth.
2170
2171         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary-mock.js: Added.
2172         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary-mock.html: Added.
2173
2174 2011-08-25  Anders Carlsson  <andersca@apple.com>
2175
2176         Return the correct value for NPNVsupportsCarbonBool
2177         https://bugs.webkit.org/show_bug.cgi?id=66964
2178
2179         Add a test.
2180
2181         Reviewed by Adam Roben.
2182
2183         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2184         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Added.
2185         (SupportsCarbonEventModel::SupportsCarbonEventModel):
2186         (SupportsCarbonEventModel::testConvert):
2187         (SupportsCarbonEventModel::runTest):
2188         (SupportsCarbonEventModel::NPP_New):
2189
2190 2011-08-25  Dimitri Glazkov  <dglazkov@chromium.org>
2191
2192         garden-o-matic summary view should not be broken.
2193
2194         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/summary.css:
2195         (table.comparison): Added more specificity.
2196
2197 2011-08-25  Adam Barth  <abarth@webkit.org>
2198
2199         This command has been broken for a while.  This patch updates the
2200         callsite to the new API.
2201
2202         * Scripts/webkitpy/tool/commands/rebaseline.py:
2203
2204 2011-08-25  Dimitri Glazkov  <dglazkov@chromium.org>
2205
2206         garden-o-matic needs a way to report where and how tests are failing in the summary view.
2207         https://bugs.webkit.org/show_bug.cgi?id=66955
2208
2209         Introduce FailureGrid, your one-stop failure-indicating destination. 
2210
2211         Reviewed by Adam Barth.
2212
2213         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html: Added new scripts.
2214         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js: Added.
2215         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js: Added.
2216         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Updated to use FailureGrid.
2217         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Updated tests.
2218         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Added new scripts.
2219
2220 2011-08-25  Igor Oliveira  <igor.oliveira@openbossa.org>
2221
2222         Add myself to the committers list
2223         https://bugs.webkit.org/show_bug.cgi?id=66941
2224
2225         Reviewed by Andreas Kling.
2226
2227         * Scripts/webkitpy/common/config/committers.py:
2228
2229 2011-08-25  Sheriff Bot  <webkit.review.bot@gmail.com>
2230
2231         Unreviewed, rolling out r93767.
2232         http://trac.webkit.org/changeset/93767
2233         https://bugs.webkit.org/show_bug.cgi?id=66931
2234
2235         Broke Qt bot. (Requested by yutak on #webkit).
2236
2237         * Scripts/webkitpy/thirdparty/__init__.py:
2238
2239 2011-08-25  Takashi Toyoshima  <toyoshim@chromium.org>
2240
2241         [WebSocket] update pywebsocket to 0.6b3 which supports closing handshake test
2242         https://bugs.webkit.org/show_bug.cgi?id=66924
2243
2244         Reviewed by Kent Tamura.
2245
2246         * Scripts/webkitpy/thirdparty/__init__.py:
2247
2248 2011-08-24  Adam Barth  <abarth@webkit.org>
2249
2250         The user can't close the details view in garden-o-matic
2251         https://bugs.webkit.org/show_bug.cgi?id=66911
2252
2253         Reviewed by Dimitri Glazkov.
2254
2255         In addition to adding a close button, this patch changes the test
2256         selector to use a <select> element and refactors the test selector to
2257         share code with the builder selector.
2258
2259         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
2260         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
2261         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions_unittests.js:
2262         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
2263
2264 2011-08-24  James Robinson  <jamesr@chromium.org>
2265
2266         [chromium] Stacktrace not in test output when a test crashes
2267         https://bugs.webkit.org/show_bug.cgi?id=66806
2268
2269         Reviewed by Dirk Pranke.
2270
2271         Appends the .error and .text output when a test crashes since on chromium the .text contains the actual stack
2272         trace.
2273
2274         * Scripts/webkitpy/layout_tests/port/chromium.py:
2275
2276 2011-08-24  Adam Barth  <abarth@webkit.org>
2277
2278         Remove empty directory.
2279
2280         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui: Removed.
2281
2282 2011-08-24  Adam Barth  <abarth@webkit.org>
2283
2284         Finish writing up details-view in garden-o-matic
2285         https://bugs.webkit.org/show_bug.cgi?id=66891
2286
2287         Reviewed by Dimitri Glazkov.
2288
2289         This patch mostly just copies a bunch of CSS from main.css to
2290         summary.css.  Presumably we'll delete main.css soon.
2291
2292         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
2293         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
2294         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions_unittests.js:
2295         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/summary.css:
2296         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:
2297
2298 2011-08-24  James Robinson  <jamesr@chromium.org>
2299
2300         Some compositing LayoutTests flakily crashing on Mac 10.6
2301         https://bugs.webkit.org/show_bug.cgi?id=66740
2302
2303         Reviewed by Adam Barth.
2304
2305         Null-check obj->pluginTest before dereferencing it. This can be null in chromium if the plugin load fails, for
2306         example if the test attempts to load a PDF plugin the load will fail since we don't have such a thing in the
2307         chromium configuration.
2308
2309         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2310         (NPP_Destroy):
2311
2312 2011-08-24  Anton D'Auria  <adauria@apple.com>
2313
2314         No review necessary.
2315
2316         Adding myself to list of committers.
2317
2318         * Scripts/webkitpy/common/config/committers.py:
2319
2320 2011-08-24  Avi Drissman  <avi@google.com>
2321
2322         Crash when restoring NSGraphicsContext when running the Chromium GPU layout tests on Mac
2323         https://bugs.webkit.org/show_bug.cgi?id=66875
2324
2325         Reviewed by James Robinson.
2326
2327         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
2328         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
2329
2330 2011-08-23  Dimitri Glazkov  <dglazkov@chromium.org>
2331
2332         Make notifications appear in time order again.
2333         https://bugs.webkit.org/show_bug.cgi?id=66815
2334
2335         Reviewed by Adam Barth.
2336
2337         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Added setting index of the notification.
2338         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Updated the test.
2339
2340 2011-08-23  James Robinson  <jamesr@chromium.org>
2341
2342         [chromium] Need a way to test lost compositor context recovery
2343         https://bugs.webkit.org/show_bug.cgi?id=66820
2344
2345         Reviewed by Kenneth Russell.
2346
2347         Exposes a LayoutTestController interface in chromium to simulate a
2348         lost compositor context.
2349
2350         * DumpRenderTree/chromium/LayoutTestController.cpp:
2351         (LayoutTestController::LayoutTestController):
2352         (LayoutTestController::loseCompositorContext):
2353         * DumpRenderTree/chromium/LayoutTestController.h:
2354
2355 2011-08-23  Dimitri Glazkov  <dglazkov@chromium.org>
2356
2357         Change garden-o-matic frontend builder array to be a configuration map.
2358         https://bugs.webkit.org/show_bug.cgi?id=66816
2359
2360         Reviewed by Adam Barth.
2361
2362         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js: Made kBuilders a map, with value being a configuration object.
2363         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js: Adjusted callsites to expect a map.
2364         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/main.js: Ditto.
2365         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js: Ditto.
2366         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js: Ditto.
2367
2368 2011-08-23  Cary Clark  <caryclark@google.com>
2369
2370         Turn WebCanvas into CGContext before drawing scrollbar (DRT using Skia on Mac)
2371         https://bugs.webkit.org/show_bug.cgi?id=66803
2372
2373         This fixes the WebKit Canaries, in particular avoids a crash on tests
2374         like css1/basic/comments.html.
2375
2376         Reviewed by James Robinson.
2377
2378         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
2379         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
2380         The NSGraphicsContext call graphicsContextWithGraphicsPort takes a void*
2381         parameter, so it took a WebCanvas* (mapped to SkCanvas* in Skia-land)
2382         and treated it as if it were a CGContextRef.
2383
2384 2011-08-23  Patrick Gansterer  <paroga@webkit.org>
2385
2386         Fix mergeChangeLogs test on native windows
2387         https://bugs.webkit.org/show_bug.cgi?id=66797
2388
2389         Reviewed by Adam Roben.
2390
2391         Windows has no /tmp/ directory and the "TMPDIR" environment variable isn't set in the default setup.
2392         Add the "TEMP" environment variable as additional source for the temporary directory used in writeTempFile.
2393
2394         * Scripts/webkitperl/VCSUtils_unittest/mergeChangeLogs.pl:
2395         (writeTempFile):
2396
2397 2011-08-23  Dimitri Glazkov  <dglazkov@chromium.org>
2398
2399         garden-o-matic relative time is wrong and updates too frequently.
2400         https://bugs.webkit.org/show_bug.cgi?id=66802
2401
2402         Reviewed by Adam Barth.
2403
2404         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js: Changed to account for rounding correctly.
2405         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js: Updated tests.
2406         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js: Upped the interval to 1 minute.
2407
2408 2011-08-23  Patrick Gansterer  <paroga@webkit.org>
2409
2410         Add missing quotes around filenames in mergeChangeLogs
2411         https://bugs.webkit.org/show_bug.cgi?id=66794
2412
2413         Reviewed by Adam Roben.
2414
2415         * Scripts/VCSUtils.pm:
2416         (mergeChangeLogs):
2417
2418 2011-08-23  Patrick Gansterer  <paroga@webkit.org>
2419
2420         webkit-perl tests fail on win32 Perl due to lack of list form of pipe open implementation
2421         https://bugs.webkit.org/show_bug.cgi?id=49080
2422
2423         Reviewed by Adam Roben.
2424
2425         Use the string form of pipe open instead (like we do at all other places).
2426
2427         * Scripts/VCSUtils.pm:
2428         (mergeChangeLogs):
2429
2430 2011-08-23  Adam Barth  <abarth@webkit.org>
2431
2432         garden-o-matic summary should be able to examine failures
2433         https://bugs.webkit.org/show_bug.cgi?id=66748
2434
2435         Reviewed by Dimitri Glazkov.
2436
2437         This patch refactors a bunch of code from summary.js to independent
2438         controllers in controllers.js.  This patch also contains the first
2439         iteration of binding the "examine" event to a the behavior showing the
2440         details view for the tests.  There's more work to do here to make this
2441         work properly (and elegantly), but this patch is a start.
2442
2443         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
2444         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
2445         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
2446         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers/rebaseline.js:
2447         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js:
2448         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
2449         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
2450         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
2451         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:
2452
2453 2011-08-23  Adam Barth  <abarth@webkit.org>
2454
2455         webkitpy/common/config/build.py shouldn't mention non-existant Android directory
2456         https://bugs.webkit.org/show_bug.cgi?id=66737
2457
2458         Reviewed by Steve Block.
2459
2460         This directory doesn't exist anymore now that the Android port shares
2461         more code with Chromium.
2462
2463         * Scripts/webkitpy/common/config/build.py:
2464
2465 2011-08-22  Eric Seidel  <eric@webkit.org>
2466
2467         Hack start-queue.sh in an attempt to resurrect the cr-jail-1 cr-mac-ews bot.
2468         I won't have ssh access to the bot again for a couple days, so
2469         attempting to fix by changing this script.  If this doesn't
2470         work we'll just live with the it hung for now.
2471
2472         Unreviewed.
2473
2474         * EWSTools/start-queue.sh:
2475
2476 2011-08-22  Dimitri Glazkov  <dglazkov@chromium.org>
2477
2478         webkit-patch rebaseline-expectations command should not rearrange the entire test_expectations.txt file.
2479         https://bugs.webkit.org/show_bug.cgi?id=66727
2480
2481         Reviewed by Adam Barth.
2482
2483         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Made it possible to run TestExpectationSerializer without a TestConfigurationConverter,
2484             in which case the serializer treats all expectations as unparsed.
2485         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Added unit tests.
2486
2487 2011-08-22  Dimitri Glazkov  <dglazkov@chromium.org>
2488
2489         Update unit test expectations after r93530.
2490
2491         * Scripts/webkitpy/layout_tests/port/factory_unittest.py: Updated.
2492         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py: Ditto.
2493
2494 2011-08-22  Dimitri Glazkov  <dglazkov@chromium.org>
2495
2496         [Chromium] Expand CPU/GPU/Skia/CG into a matrix in graphics_type.
2497         https://bugs.webkit.org/show_bug.cgi?id=66705
2498
2499         Reviewed by Adam Barth.
2500
2501         * Scripts/webkitpy/layout_tests/port/chromium.py: Added plumbing for CG graphics types.
2502         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py: Adjusted unit test.
2503
2504 2011-08-22  James Robinson  <jamesr@chromium.org>
2505
2506         [chromium] Update builder names for chromium gpu bots due to CG switchover
2507         https://bugs.webkit.org/show_bug.cgi?id=66693
2508
2509         Reviewed by Dirk Pranke.
2510
2511         Update the port and builder names for the chromium mac gpu bots to
2512         account for the CG transition.
2513
2514         * Scripts/webkitpy/layout_tests/port/builders.py:
2515
2516 2011-08-22  Dirk Pranke  <dpranke@chromium.org>
2517
2518         fix the GPU bot names on the layout test dashboard
2519         https://bugs.webkit.org/show_bug.cgi?id=66697
2520
2521         Reviewed by Dimitri Glazkov.
2522
2523         * TestResultServer/static-dashboards/builders.js:
2524
2525 2011-08-22  Dimitri Glazkov  <dglazkov@chromium.org>
2526
2527         garden-o-matic's relative time display should be updated regularly.
2528         https://bugs.webkit.org/show_bug.cgi?id=66682
2529
2530         Reviewed by Adam Barth.
2531
2532         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js: Moved Time to ui.Time, added code for regular updates.
2533         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Changed to use ui.Time.
2534         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js: Added tests.
2535
2536 2011-08-22  Xianzhu Wang  <wangxianzhu@chromium.org>
2537
2538         Pass --makeargs of build-webkit to chromium linux builder
2539         https://bugs.webkit.org/show_bug.cgi?id=66361
2540
2541         Reviewed by Tony Chang.
2542
2543         * Scripts/build-webkit:
2544         * Scripts/webkitdirs.pm:
2545         (buildChromiumMakefile):
2546         (buildChromium):
2547
2548 2011-08-22  Peter Beverloo  <peter@chromium.org>
2549
2550         Add myself to the contributor list.
2551         https://bugs.webkit.org/show_bug.cgi?id=66674
2552
2553         Reviewed by Tony Gentilcore.
2554
2555         * Scripts/webkitpy/common/config/committers.py:
2556
2557 2011-08-22  Balazs Kelemen  <kbalazs@webkit.org>
2558
2559         [Qt] ImageDiff does not consider --tolerance
2560         https://bugs.webkit.org/show_bug.cgi?id=66299
2561
2562         Reviewed by Csaba Osztrogonác.
2563
2564         * DumpRenderTree/qt/ImageDiff.cpp:
2565         (main):
2566
2567 2011-08-22  Csaba Osztrogonác  <ossy@webkit.org>
2568
2569         Update contributor list.
2570
2571         Reviewed by Zoltan Herczeg.
2572
2573         * Scripts/webkitpy/common/config/committers.py:
2574
2575 2011-08-22  Kristóf Kosztyó  <Kosztyo.Kristof@stud.u-szeged.hu>
2576
2577         [ORWT] Fix --reset-results --add-platform-exceptions combo
2578         https://bugs.webkit.org/show_bug.cgi?id=65464
2579
2580         Reviewed by Csaba Osztrogonác.
2581
2582         * Scripts/old-run-webkit-tests:
2583
2584 2011-08-20  Adam Barth  <abarth@webkit.org>
2585
2586         garden-o-matic summary.html should have UI for examining failures
2587         https://bugs.webkit.org/show_bug.cgi?id=66625
2588
2589         Reviewed by Dimitri Glazkov.
2590
2591         This patch introduces the notion of UI actions and converts our
2592         existing manual <button> manipulation with this new abstraction.  The
2593         patch also adds an Examine button to failure notifications.  In a
2594         future patch, I'll add a controller that wires this button up to
2595         something useful.
2596
2597         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
2598         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
2599         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js: Added.
2600         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions_unittests.js: Added.
2601         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
2602         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
2603         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
2604         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:
2605
2606 2011-08-20  Adam Barth  <abarth@webkit.org>
2607
2608         garden-o-matic summary page should indiciate compile failures
2609         https://bugs.webkit.org/show_bug.cgi?id=66624
2610
2611         Reviewed by Dimitri Glazkov.
2612
2613         This patch creates a notification-based UI for build failures.  The new
2614         UI displays the same information that used to be displayed in the
2615         infobar.  There's lots of room for improvement in surfacing more
2616         information, but this is a start.
2617
2618         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js:
2619         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
2620         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
2621
2622 2011-08-19  James Robinson  <jamesr@chromium.org>
2623
2624         [chromium] Default to experimental-fully-parallel mode for chromium gpu port
2625         https://bugs.webkit.org/show_bug.cgi?id=66606
2626
2627         Reviewed by Dirk Pranke.
2628
2629         The chromium GPU configuration does not (currently) contain any tests
2630         incompatible with --experimental-fully-parallel, and this flag is a
2631         significan speedup because of the directory canvas/philip/tests which
2632         contains 802 tests in the same directory. Setting this option by
2633         default on this configuration is a 2x speed in release, 44s to 22s,
2634         and a 3x speedup in debug, 223s to 77s, on linux on a 16 core machine.
2635
2636         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2637         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
2638         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2639
2640 2011-08-19  Sheriff Bot  <webkit.review.bot@gmail.com>
2641
2642         Unreviewed, rolling out r93426.
2643         http://trac.webkit.org/changeset/93426
2644         https://bugs.webkit.org/show_bug.cgi?id=66607
2645
2646         Broke the Mac build by not building gtest.framework anymore
2647         (Requested by andersca on #webkit).
2648
2649         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
2650
2651 2011-08-19  James Robinson  <jamesr@chromium.org>
2652
2653         [chromium] Chromium GPU layout tests should use the normal process number selection, not force 1 worker
2654         https://bugs.webkit.org/show_bug.cgi?id=66603
2655
2656         Reviewed by Dirk Pranke.
2657
2658         The various ChromiumGpu ports should use the same child worker
2659         selection logic as other ports so they can run with full
2660         parallelization on multicore systems.
2661
2662         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2663         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
2664
2665 2011-08-19  Alok Priyadarshi  <alokp@chromium.org>
2666
2667         [chromium] Remove dependency of WebThemeControlDRTWin on skia::PlatformCanvas
2668         https://bugs.webkit.org/show_bug.cgi?id=66570
2669
2670         Reviewed by Mihai Parparita.
2671
2672         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp:
2673         (WebThemeControlDRTWin::draw):
2674         (WebThemeControlDRTWin::drawTextField):
2675         (WebThemeControlDRTWin::drawProgressBar):
2676         * DumpRenderTree/chromium/WebThemeControlDRTWin.h:
2677
2678 2011-08-18  Dmitry Lomov  <dslomov@google.com>
2679
2680         TestWebKitAPI breaks on Windows due to fast malloc incompatibility.
2681         https://bugs.webkit.org/show_bug.cgi?id=66521
2682
2683         This patch ensures that gtest uses new and delete operators that are defined in JavaScriptCore.
2684
2685         Reviewed by David Levin.
2686
2687         * TestWebKitAPI/Tests/WTF/StringOperators.cpp: Removed redefinition of JS_EXPORTDATA.
2688
2689 2011-08-19  Adam Roben  <aroben@apple.com>
2690
2691         Add project file changes I left out in r93417
2692
2693         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2694
2695 2011-08-19  Adam Roben  <aroben@apple.com>
2696
2697         Add a helper class for swizzling ObjC instance methods to TestWebKitAPI
2698
2699         Fixes <http://webkit.org/b/66565> TestWebKitAPI needs a way to override instance methods of
2700         NSScreen
2701
2702         Reviewed by Anders Carlsson.
2703
2704         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new files.
2705
2706         * TestWebKitAPI/Tests/TestWebKitAPI/mac/InstanceMethodSwizzler.mm: Added.
2707         (-[SimpleObject setValue:]): Original implementation.
2708
2709         (TestWebKitAPI::setValue2):
2710         (TestWebKitAPI::setValue3):
2711         Swizzled implementations.
2712
2713         (TestWebKitAPI::TEST): Test that we can swizzle and re-swizzle and un-swizzle an ObjC
2714         instance method.
2715
2716         * TestWebKitAPI/mac/InstanceMethodSwizzler.h: Added.
2717         * TestWebKitAPI/mac/InstanceMethodSwizzler.mm: Added.
2718         (TestWebKitAPI::InstanceMethodSwizzler::InstanceMethodSwizzler): Swizzle the method.
2719         (TestWebKitAPI::InstanceMethodSwizzler::~InstanceMethodSwizzler): Unswizzle the method.
2720
2721 2011-08-19  Tom Zakrajsek  <tomz@codeaurora.org>
2722
2723         Fix _path_to_apache() error reporting
2724         https://bugs.webkit.org/show_bug.cgi?id=66486
2725
2726         Reviewed by Ryosuke Niwa.
2727
2728         * Scripts/webkitpy/layout_tests/port/webkit.py:
2729
2730 2011-08-19  Adam Roben  <aroben@apple.com>
2731
2732         Windows build fix after r93404
2733
2734         * TestWebKitAPI/Tests/WebKit2/win/HideFindIndicator.cpp: Added missing #include.
2735
2736 2011-08-19  Tony Gentilcore  <tonyg@chromium.org>
2737
2738         Add leandrogracia to the committers list
2739         https://bugs.webkit.org/show_bug.cgi?id=66552
2740
2741         Also fix line endings in file.
2742
2743         No reviewed required.
2744
2745         * Scripts/webkitpy/common/config/committers.py:
2746
2747 2011-08-19  Amruth Raj  <amruthraj@motorola.com>
2748
2749         Fix compilation issue in WebKitTestRunner
2750         https://bugs.webkit.org/show_bug.cgi?id=66554
2751
2752         Reviewed by Martin Robinson.
2753
2754         * WebKitTestRunner/PixelDumpSupport.cpp:
2755
2756 2011-08-19  Adam Roben  <aroben@apple.com>
2757
2758         Pull some of DynamicDeviceScaleFactor's code up into a shareable base class
2759
2760         This will make it easier to write other WebKit-agnostic tests
2761
2762         Fixes <http://webkit.org/b/66558> Would like to be able to reuse DynamicDeviceScaleFactor's
2763         code in other WebKit-agnostic tests
2764
2765         Reviewed by Anders Carlsson.
2766
2767         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new files.
2768
2769         * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm: Fixed copyright. Moved a bunch of
2770         code to WebKitAgnosticTest.h/mm. Changed to inherit from WebKitAgnosticTest.
2771         (TestWebKitAPI::DynamicDeviceScaleFactor::url): Simple getter.
2772         (TestWebKitAPI::DynamicDeviceScaleFactor::didLoadURL): Calls through to runTest.
2773         (TestWebKitAPI::DynamicDeviceScaleFactor::runTest): Removed loading code which
2774         WebKitAgnosticTest handles for us.
2775         (TestWebKitAPI::TEST_F): Removed view-creation code which WebKitAgnosticTest handles for us.
2776
2777         * TestWebKitAPI/mac/WebKitAgnosticTest.h: Added. Code came from DynamicDeviceScaleFactor.
2778         (TestWebKitAPI::WebKitAgnosticTest::loadAndWaitUntilDone): Code came from
2779         DynamicDeviceScaleFactor::runTest.
2780
2781         * TestWebKitAPI/mac/WebKitAgnosticTest.mm: Copied from Tools/TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm.
2782         (TestWebKitAPI::WebKitAgnosticTest::runWebKit1Test): Code came from
2783         DynamicDeviceScaleFactor.WebKit.
2784         (TestWebKitAPI::WebKitAgnosticTest::runWebKit2Test): Code came from
2785         DynamicDeviceScaleFactor.WebKit2.
2786
2787 2011-08-19  Adam Roben  <aroben@apple.com>
2788
2789         Clean up #includes in TestWebKitAPI
2790
2791         Fixes <http://webkit.org/b/66556> TestWebKitAPI's prefix header isn't very helpful
2792
2793         Reviewed by Anders Carlsson.
2794
2795         * TestWebKitAPI/TestWebKitAPIPrefix.h: Added wtf/Platform.h. Added gtest/gtest.h for C++
2796         files and WebKit/WebKit.h for ObjC files.
2797
2798         * TestWebKitAPI/InjectedBundleController.cpp:
2799         * TestWebKitAPI/JavaScriptTest.h:
2800         * TestWebKitAPI/PlatformUtilities.h:
2801         * TestWebKitAPI/PlatformWebView.h:
2802         * TestWebKitAPI/Test.h:
2803         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
2804         * TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
2805         * TestWebKitAPI/Tests/WTF/VectorReverse.cpp:
2806         * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp:
2807         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
2808         * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp:
2809         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
2810         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp:
2811         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
2812         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
2813         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
2814         * TestWebKitAPI/Tests/WebKit2/Find.cpp:
2815         * TestWebKitAPI/Tests/WebKit2/ForceRepaint.cpp:
2816         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
2817         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
2818         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp:
2819         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle_Bundle.cpp:
2820         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
2821         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic_Bundle.cpp:
2822         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
2823         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
2824         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
2825         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
2826         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly.cpp:
2827         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp:
2828         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
2829         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
2830         * TestWebKitAPI/Tests/WebKit2/WKString.cpp:
2831         * TestWebKitAPI/Tests/WebKit2/WKStringJSString.cpp:
2832         * TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp:
2833         * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp:
2834         * TestWebKitAPI/Tests/WebKit2/win/HideFindIndicator.cpp:
2835         * TestWebKitAPI/Tests/WebKit2/win/ResizeViewWhileHidden.cpp:
2836         * TestWebKitAPI/Tests/WebKit2/win/TranslateMessageGeneratesWMChar.cpp:
2837         * TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp:
2838         * TestWebKitAPI/Tests/WebKit2/win/WMPrint.cpp:
2839         * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm:
2840         * TestWebKitAPI/TestsController.cpp:
2841         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
2842         Removed now-unnecessary #includes. Moved #includes of Test.h in with the rest of the
2843         #includes since it is no longer a special header.
2844
2845 2011-08-18  Dirk Pranke  <dpranke@chromium.org>
2846
2847         new-run-webkit-tests hung while acquiring http lock on snow leopard bots
2848         https://bugs.webkit.org/show_bug.cgi?id=64886
2849
2850         Temporarily disable the http locking to work around the issue.
2851         I'm not actually sure if this is going to work or improve things
2852         much.
2853
2854         Reviewed by Ryosuke Niwa.
2855
2856         * Scripts/webkitpy/layout_tests/port/mac.py:
2857
2858 2011-08-18  Tony Chang  <tony@chromium.org>
2859
2860         add embedded png checksums to WebKitTestRunner
2861         https://bugs.webkit.org/show_bug.cgi?id=66494
2862
2863         Looks like WebKitTestRunner has never supported embedded checksums.  This copies
2864         some code from DRT and adds it to the WebKitTestRunner.
2865
2866         Reviewed by Darin Adler.
2867
2868         * WebKitTestRunner/CyclicRedundancyCheck.cpp: Copied from Tools/DumpRenderTree
2869         * WebKitTestRunner/CyclicRedundancyCheck.h: Copied from Tools/DumpRenderTree
2870         * WebKitTestRunner/GNUmakefile.am: Add new files
2871         * WebKitTestRunner/PixelDumpSupport.cpp: Copied from Tools/DumpRenderTree
2872         * WebKitTestRunner/PixelDumpSupport.h: Copied from Tools/DumpRenderTree
2873         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Add new files
2874         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
2875         (WTR::dumpBitmap): Refactor to use PixelDumpSupport.
2876         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
2877         * WebKitTestRunner/cg/TestInvocationCG.cpp:
2878         (WTR::dumpBitmap): Refactor to use PixelDumpSupport.
2879         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
2880         * WebKitTestRunner/win/WebKitTestRunner.vcproj: Add new files
2881
2882 2011-08-18  Shawn Singh  <shawnsingh@chromium.org>
2883
2884         https://bugs.webkit.org/show_bug.cgi?id=47240
2885
2886         Fixed a cygwin path problem in the chromium port of diff_image;
2887         Also made the return values of the diff_image function more consistent.
2888
2889         Reviewed by Dirk Pranke.
2890
2891         * Scripts/webkitpy/layout_tests/port/chromium.py:
2892
2893 2011-08-17  Alejandro G. Castro  <alex@igalia.com>
2894
2895         [GTK] Fix compilation problems with deprecations in gtk+
2896         https://bugs.webkit.org/show_bug.cgi?id=66073
2897
2898         Reviewed by Martin Robinson.
2899
2900         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2901         (main): G_CONST_RETURN was deprecated
2902         * GtkLauncher/main.c:
2903         (createWindow): Added gtk_box_new conditional compilation for
2904         gtk+-3.
2905         * MiniBrowser/gtk/BrowserWindow.c:
2906         (browser_window_init): Replaced gtk_vbox_new with gtk_box_new, we
2907         are just supporting gtk+-3 for WebKit2.
2908
2909 2011-08-18  Anders Carlsson  <andersca@apple.com>
2910
2911         Fix libc++ C++0x build
2912         https://bugs.webkit.org/show_bug.cgi?id=66479
2913
2914         Reviewed by Adam Roben.
2915
2916         Add missing includes.
2917
2918         * DumpRenderTree/LayoutTestController.cpp:
2919         * DumpRenderTree/mac/CheckedMalloc.cpp:
2920
2921 2011-08-18  Adam Roben  <aroben@apple.com>
2922
2923         Test that WebKit updates style when a WebView is moved between differently-scaled windows
2924
2925         Test for <http://webkit.org/b/66412> <rdar://problem/9971958> WebKit doesn't react when a
2926         WebView is moved between windows with different backing scale factors
2927
2928         Reviewed by Anders Carlsson.
2929
2930         * TestWebKitAPI/JavaScriptTest.cpp:
2931         (TestWebKitAPI::runJSTest): Moved a little bit of code from here...
2932         (TestWebKitAPI::compareJSResult): ...to here. Also made the error message more similar to
2933         gtest's built-in error messages.
2934
2935         * TestWebKitAPI/JavaScriptTest.h: Added overloads of runJSTest that take a WebView * and
2936         WKView * for convenience on Mac. Added compareJSResult helper function for implementing
2937         those overloads.
2938
2939         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new files.
2940
2941         * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm: Added.
2942         (-[FrameLoadDelegate initWithDidFinishLoadBoolean:]): Simple initializer.
2943         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]): Record that the load finished.
2944         (TestWebKitAPI::didFinishLoadForFrame): Record that the load finished.
2945         (TestWebKitAPI::setPageLoaderClient): Set up the client.
2946         (TestWebKitAPI::DynamicDeviceScaleFactor::DynamicDeviceScaleFactor): Simple constructor.
2947         (TestWebKitAPI::DynamicDeviceScaleFactor::createWindow): Creates a
2948         SyntheticBackingScaleFactorWindow and returns it.
2949         (TestWebKitAPI::DynamicDeviceScaleFactor::runTest): Loads devicePixelRatio.html and checks
2950         that WebKit uses the correct scale factor when the WebView is not in a window, is put in a
2951         window, is moved to a differently-scaled window, and is taken out of the window.
2952         (TestWebKitAPI::DynamicDeviceScaleFactor::loadURL): Helper function with overloads for
2953         WebKit1 and WebKit2.
2954         (TestWebKitAPI::TEST_F): Runs the test, with overloads for WebKit1 and WebKit2.
2955
2956         * TestWebKitAPI/Tests/mac/devicePixelRatio.html: Added.
2957
2958         * TestWebKitAPI/mac/JavaScriptTestMac.mm: Added.
2959         (TestWebKitAPI::runJSTest): Fairly simple overloads for WebView * and WKView *.
2960
2961         * TestWebKitAPI/mac/SyntheticBackingScaleFactorWindow.h: Added.
2962         * TestWebKitAPI/mac/SyntheticBackingScaleFactorWindow.m: Added.
2963         (-[SyntheticBackingScaleFactorWindow initWithContentRect:styleMask:backing:defer:]): Simple
2964         initializer.
2965         (-[SyntheticBackingScaleFactorWindow setBackingScaleFactor:]): Simple setter.
2966
2967         (-[SyntheticBackingScaleFactorWindow backingScaleFactor]):
2968         (-[SyntheticBackingScaleFactorWindow userSpaceScaleFactor]):
2969         Overrides of NSWindow methods that WebKit uses to determine the device scale factor.
2970
2971 2011-08-18  Dmitry Lomov  <dslomov@google.com>
2972
2973         https://bugs.webkit.org/show_bug.cgi?id=66425
2974         check-webkit-style should detect incorrectly formatted file change descriptions.
2975         Description, if present, should be separated from colon with a space.
2976
2977         Reviewed by David Levin.
2978
2979         * Scripts/webkitpy/style/checkers/changelog.py: Fix.
2980         * Scripts/webkitpy/style/checkers/changelog_unittest.py: Unit tests.
2981
2982 2011-08-18  Adam Barth  <abarth@webkit.org>
2983
2984         webkit-patch pretty-diff should be shown in main help
2985         https://bugs.webkit.org/show_bug.cgi?id=66404
2986
2987         Reviewed by Dimitri Glazkov.
2988
2989         As requested by dglazkov.
2990
2991         * Scripts/webkitpy/tool/commands/prettydiff.py:
2992
2993 2011-08-17  Dmitry Lomov  <dslomov@google.com>
2994
2995         https://bugs.webkit.org/show_bug.cgi?id=66400
2996         Fix TestWebKitAPI build on Mac OS.
2997
2998         Reviewed by David Levin.
2999
3000         * TestWebKitAPI/Configurations/Base.xcconfig: Added ICU headers to the HEADER_SEARCH_PATH.
3001
3002 2011-08-17  Dimitri Glazkov  <dglazkov@chromium.org>
3003
3004         garden-o-matic spring cleaning: move scripts, styles, and images in the respective directories.
3005         https://bugs.webkit.org/show_bug.cgi?id=66427
3006
3007         Reviewed by Adam Barth.
3008
3009         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Bugzilla.js: Removed.
3010         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot.js: Removed.
3011         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot_unittests.js: Removed.
3012         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js: Removed.
3013         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js: Removed.
3014         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm.js: Removed.
3015         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm_unittests.js: Removed.
3016         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector.js: Removed.
3017         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector_unittests.js: Removed.
3018         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyTestBugForm.js: Removed.
3019         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyTestBugForm_unittests.js: Removed.
3020         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js: Removed.
3021         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js: Removed.
3022         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NRWTResultsParser.js: Removed.
3023         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NewBugForm.js: Removed.
3024         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NewBugForm_unittests.js: Removed.
3025         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ORWTResultsParser.js: Removed.
3026         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/PersistentCache.js: Removed.
3027         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css: Removed.
3028         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestRelatedBugForm.js: Removed.
3029         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestRelatedBugForm_unittests.js: Removed.
3030         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js: Removed.
3031         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js: Removed.
3032         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities_unittests.js: Removed.
3033         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js: Removed.
3034         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBugzilla.js: Removed.
3035         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBuildbot.js: Removed.
3036         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js: Removed.
3037         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js: Removed.
3038         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/bugzilla_unittests.js: Removed.
3039         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders.js: Removed.
3040         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders_unittests.js: Removed.
3041         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js: Removed.
3042         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout_unittests.js: Removed.
3043         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js: Removed.
3044         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers: Removed.
3045         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers.js: Removed.
3046         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers/rebaseline.js: Removed.
3047         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/favicon-green.png: Removed.
3048         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/favicon-red.png: Removed.
3049         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
3050         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images: Added.
3051         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images/favicon-green.png: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/favicon-green.png.
3052         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images/favicon-red.png: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/favicon-red.png.
3053         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html:
3054         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css: Removed.
3055         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js: Removed.
3056         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js: Removed.
3057         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model_unittests.js: Removed.
3058         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net.js: Removed.
3059         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net_unittests.js: Removed.
3060         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/rebaseline.html:
3061         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js: Removed.
3062         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results_unittests.js: Removed.
3063         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
3064         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Bugzilla.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Bugzilla.js.
3065         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Buildbot.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot.js.
3066         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Buildbot_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot_unittests.js.
3067         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Builder.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js.
3068         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Builder_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js.
3069         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/FailingTestsBugForm.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm.js.
3070         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/FailingTestsBugForm_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm_unittests.js.
3071         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/FlakyLayoutTestDetector.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector.js.
3072         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/FlakyLayoutTestDetector_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector_unittests.js.
3073         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/FlakyTestBugForm.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyTestBugForm.js.
3074         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/FlakyTestBugForm_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyTestBugForm_unittests.js.
3075         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/LayoutTestHistoryAnalyzer.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js.
3076         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/LayoutTestResultsLoader.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js.
3077         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/NRWTResultsParser.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NRWTResultsParser.js.
3078         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/NewBugForm.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NewBugForm.js.
3079         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/NewBugForm_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NewBugForm_unittests.js.
3080         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ORWTResultsParser.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ORWTResultsParser.js.
3081         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/PersistentCache.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/PersistentCache.js.
3082         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/TestRelatedBugForm.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestRelatedBugForm.js.
3083         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/TestRelatedBugForm_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestRelatedBugForm_unittests.js.
3084         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Trac.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js.
3085         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Utilities.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js.
3086         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Utilities_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities_unittests.js.
3087         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ViewController.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js.
3088         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/WebKitBugzilla.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBugzilla.js.
3089         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/WebKitBuildbot.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBuildbot.js.
3090         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js.
3091         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js.
3092         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/bugzilla_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/bugzilla_unittests.js.
3093         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders.js.
3094         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders_unittests.js.
3095         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js.
3096         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout_unittests.js.
3097         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js.
3098         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers.
3099         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers.js.
3100         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/main.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js.
3101         ():
3102         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js.
3103         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model_unittests.js.
3104         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/net.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net.js.
3105         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/net_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net_unittests.js.
3106         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js.
3107         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results_unittests.js.
3108         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/trac_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/trac_unittests.js.
3109         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js.
3110         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results.js.
3111         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results_unittests.js.
3112         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js.
3113         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/unexpected-passes.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/unexpected-passes.js.
3114         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/TestFailures.css: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css.
3115         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/main.css: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css.
3116         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:
3117         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/trac_unittests.js: Removed.
3118         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js: Removed.
3119         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results.js: Removed.
3120         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results_unittests.js: Removed.
3121         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js: Removed.
3122         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/unexpected-passes.html:
3123         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/unexpected-passes.js: Removed.
3124
3125 2011-08-17  Jochen Eisinger  <jochen@chromium.org>
3126
3127         Make SVNTest.test_svn_apply use the same timezone logic as VCSUtils.pm
3128         https://bugs.webkit.org/show_bug.cgi?id=65877
3129
3130         Reviewed by Eric Seidel.
3131
3132         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3133
3134 2011-08-17  Dimitri Glazkov  <dglazkov@chromium.org>
3135
3136         Remove base.keys and replace it with Object.keys.
3137         https://bugs.webkit.org/show_bug.cgi?id=66422
3138
3139         Reviewed by Adam Barth.
3140
3141         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js: Removed base.keys.
3142         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js: Removed unit tests for it.
3143         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js: Replaced with Object.keys
3144
3145 2011-08-17  Dimitri Glazkov  <dglazkov@chromium.org>
3146
3147         garden-o-matic Summary view should have items in descending chronological order.
3148         https://bugs.webkit.org/show_bug.cgi?id=66403
3149
3150         Reviewed by Adam Barth.
3151
3152         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js: Renamed "push" to "add" for clarity, cleaned up some stuff.
3153         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Rewrote add to insert DOM elements in order.
3154         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Added unit tests.
3155
3156 2011-08-17  Dimitri Glazkov  <dglazkov@chromium.org>
3157
3158         Fix a few errors in garden-o-matic frontend unit tests.
3159         https://bugs.webkit.org/show_bug.cgi?id=66421
3160
3161         Reviewed by Adam Barth.
3162
3163         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js: Changed my excellent test to view time as variable continuum.
3164         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders_unittests.js: Tweaked the test to accommodate new builder names.
3165         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Hurriedly covered up my prior sins.
3166
3167 2011-08-17  Adam Barth  <abarth@webkit.org>
3168
3169         Update Tools to account for (CG) being added to Chromium builder names
3170         https://bugs.webkit.org/show_bug.cgi?id=66410
3171
3172         Reviewed by Adam Barth.
3173
3174         Some of these names will change back once we turn on Skia bots.
3175
3176         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders_unittests.js:
3177         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js:
3178         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js:
3179         * Scripts/webkitpy/layout_tests/port/builders.py:
3180         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3181         * TestResultServer/static-dashboards/builders.js:
3182         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
3183
3184 2011-08-16  Dimitri Glazkov  <dglazkov@chromium.org>
3185
3186         Wire up relative time to garden-o-matic summary view.
3187         https://bugs.webkit.org/show_bug.cgi?id=66343
3188
3189         Reviewed by Adam Barth.
3190
3191         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js: Add time to the commitData object. 
3192         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model_unittests.js: Adjusted unit tests.
3193         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Wired up relative date.
3194         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Updated unit tests.
3195         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/trac_unittests.js: Adjusted unit tests.
3196
3197 2011-08-17  Adam Roben  <aroben@apple.com>
3198
3199         Make run-api-tests run tests in alphabetical order
3200
3201         Fixes <http://webkit.org/b/66401> run-api-tests runs tests in a semi-random order
3202
3203         Reviewed by David Kilzer.
3204
3205         * Scripts/run-api-tests:
3206         (runAllTests):
3207         (runAllTestsInSuite):
3208         Sort the lists of tests and suites before iterating over them.
3209
3210 2011-08-17  Adam Barth  <abarth@webkit.org>
3211
3212         garden-o-matic should be able to rebaseline expected failures
3213         https://bugs.webkit.org/show_bug.cgi?id=66204
3214
3215         Reviewed by Dimitri Glazkov.
3216
3217         This patch introduces a new view for displaying expect, actual, and
3218         differences between results.  The new view also has a fledgling
3219         controller that handles some basic operations.  The new view is
3220         exercised by rebaseline.html, which lets you rebaselines expected
3221         failures, but the new view is not fully integrated into
3222         garden-o-matic.html
3223
3224         More patches will be required to make this stuff fully working, but
3225         this patch was already somewhat spiraling out of control.  Hopefully
3226         this patch will serve as a good starting point for further development.
3227
3228         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers: Added.
3229         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers.js: Added.
3230         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers/rebaseline.js: Added.
3231         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
3232         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css:
3233         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
3234         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/rebaseline.html: Added.
3235         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js:
3236         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
3237         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
3238         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results.js:
3239         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results_unittests.js: Added.
3240
3241 2011-08-16  Chang Shu  <cshu@webkit.org>
3242
3243         Support reset in WebCore::Internals
3244         https://bugs.webkit.org/show_bug.cgi?id=66307
3245
3246         Reviewed by Dimitri Glazkov.
3247
3248         Added call to resetInternalsObject in DRT.
3249
3250         * DumpRenderTree/chromium/TestShell.cpp:
3251         (TestShell::resetTestController):
3252         * DumpRenderTree/mac/DumpRenderTree.mm:
3253         (resetWebViewToConsistentStateBeforeTesting):
3254         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3255         (WebCore::WebPage::resetSettings):
3256
3257 2011-08-17  Alexis Menard  <alexis.menard@openbossa.org>
3258
3259         Add a new build slave for the Qt port on Mac OS SnowLeopard.
3260         https://bugs.webkit.org/show_bug.cgi?id=66392
3261
3262         Modify the config file to include the new build slave.
3263
3264         Reviewed by Adam Roben.
3265
3266         * BuildSlaveSupport/build.webkit.org-config/config.json:
3267
3268 2011-08-17  Sam White  <samuel.white@rochester.edu>
3269
3270         AccessibilityObject levels are inconsistent
3271         https://bugs.webkit.org/show_bug.cgi?id=66180
3272         
3273         Added the ability to get numeric attribute values using numberAttributeValue. This
3274         function complements the existing stringAttributeValue and boolAttributeValue functions.
3275         The addition of numberAttributeValue was necessary because the stringAttributeValue
3276         function does a type check and will only return strings. This limitation made it
3277         impossible to get values for attributes that returned an NSNumber.
3278
3279         Reviewed by Chris Fleizach.
3280
3281         * DumpRenderTree/AccessibilityUIElement.cpp:
3282         (numberAttributeValueCallback):
3283         (AccessibilityUIElement::getJSClass):
3284         * DumpRenderTree/AccessibilityUIElement.h:
3285         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3286         (AccessibilityUIElement::numberAttributeValue):
3287         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3288         (AccessibilityUIElement::numberAttributeValue):
3289         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3290         (AccessibilityUIElement::numberAttributeValue):
3291
3292 2011-08-17  Adam Roben  <aroben@apple.com>
3293
3294         Tell Trac logs always to display all specified revisions in a single page
3295
3296         Trac imposes a default limit of 100 revisions per log page. We need to tell it to allow more
3297         revisions than that.
3298
3299         Fixes <http://webkit.org/b/66373> Links to Trac from TestFailures page don't always show all
3300         relevant revisions
3301
3302         Reviewed by Daniel Bates.
3303
3304         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js:
3305         (trac.logURL): Add a limit parameter to the log URL that allows all revisions to be seen in
3306         a single page.
3307
3308         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm_unittests.js:
3309         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/trac_unittests.js:
3310         Updated tests for the above.
3311
3312 2011-08-17  Adam Roben  <aroben@apple.com>
3313
3314         Fix TestFailures's link to file a bug about TestFailures itself
3315
3316         Fixes <http://webkit.org/b/66387> REGRESSION (r92135): TestFailures page's link to file a
3317         bug about itself is broken
3318
3319         Reviewed by Dan Bates.
3320
3321         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
3322         (ViewController.prototype._domForAuxiliaryUIElements): Added a path separator to separate
3323         the host from the path.
3324
3325 2011-08-17  Adam Roben  <aroben@apple.com>
3326
3327         Teach TestFailures to ignore unbelievably short test runs
3328
3329         Fixes <http://webkit.org/b/66385> TestFailures page thinks all tests passed in
3330         http://build.webkit.org/builders/Windows%207%20Release%20(Tests)/builds/14956
3331
3332         Reviewed by Dan Bates.
3333
3334         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
3335         (Builder.prototype.getNumberOfFailingTests): If it looks like all tests passed, but
3336         run-webkit-tests took less than 10 seconds to run, assume that some weird error occurred
3337         that caused it not to run any tests at all (as happened for a while due to
3338         <http://webkit.org/b/64988>). Bumped the cache version to evict old, buggy cached data.
3339
3340         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js:
3341         Test for the above.
3342
3343         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js:
3344         (LayoutTestResultsLoader.prototype.start): Bumped the cache version to evict old, buggy cached data.
3345
3346 2011-08-16  Adam Barth  <abarth@webkit.org>
3347
3348         Add a CG qualifier similar to the GPU qualifier
3349         https://bugs.webkit.org/show_bug.cgi?id=66359
3350
3351         Reviewed by Eric Seidel.
3352
3353         Once we have a Skia configuration on Chromium Mac, we'll use this CG
3354         qualifier to note that expectations apply only to the CG configuration.
3355
3356         * Scripts/webkitpy/layout_tests/port/chromium.py:
3357         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
3358
3359 2011-08-16  Eric Seidel  <eric@webkit.org>
3360
3361         REGRESSION(92717): WinPort needs to parse version information from port_name
3362         https://bugs.webkit.org/show_bug.cgi?id=66325
3363
3364         Unreviewed.  Fixing an exception/typo seen on the bots (and testing to make sure it works).
3365
3366         * Scripts/webkitpy/layout_tests/port/mac.py:
3367         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3368
3369 2011-08-16  Adam Barth  <abarth@webkit.org>
3370
3371         Change webkit-patch analyze-baselines to print in a more unix-friendly way
3372         https://bugs.webkit.org/show_bug.cgi?id=66349
3373
3374         Reviewed by James Robinson.
3375
3376         As requested by jamesr.
3377
3378         * Scripts/webkitpy/tool/commands/rebaseline.py:
3379
3380 2011-08-16  Eric Seidel  <eric@webkit.org>
3381
3382         REGRESSION(92717): WinPort needs to parse version information from port_name
3383         https://bugs.webkit.org/show_bug.cgi?id=66325
3384
3385         Reviewed by Adam Barth.
3386
3387         WinPort didn't have any port_name parsing logic.
3388         Seemed it was best to just share the logic from MacPort.
3389         Sharing the logic from MacPort seemed easiest with a shared superclass.
3390         Once I created ApplePort (the superclass) there was a bunch of logic to share.
3391         I found LeakDetector was just in the way when switching back and forth
3392         between win.py and mac.py so I moved it into its own file.
3393
3394         The only logic change here is that WinPort should now be
3395         able to parse port_name values like MacPort (and other ports)
3396         can.  The fact that ports do this in their constructors is
3397         wrong and a source of many bugs.  But at least now WinPort
3398         matches the status-quo.
3399
3400         * Scripts/webkitpy/layout_tests/port/apple.py: Added.
3401         * Scripts/webkitpy/layout_tests/port/leakdetector.py: Added.
3402         * Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py: Added.
3403         * Scripts/webkitpy/layout_tests/port/mac.py:
3404         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3405         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3406         * Scripts/webkitpy/layout_tests/port/win.py:
3407         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
3408
3409 2011-08-16  Adam Barth  <abarth@webkit.org>
3410
3411         Add webkit-patch analyze-baselines, as requested by jamesr.
3412
3413         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
3414         * Scripts/webkitpy/tool/commands/rebaseline.py:
3415
3416 2011-08-16  Adam Barth  <abarth@webkit.org>
3417
3418         Fold bulk-optimize-baselines into optimize-baselines
3419         https://bugs.webkit.org/show_bug.cgi?id=66345
3420
3421         Reviewed by James Robinson.
3422
3423         bulk-optimize-baselines is now a superset of optimize-baselines, so
3424         they can be combined.
3425
3426         * Scripts/webkitpy/tool/commands/rebaseline.py:
3427
3428 2011-08-16  Adam Barth  <abarth@webkit.org>
3429
3430         Move chromium-mac to chromium-cg-mac to prepare for Skia switchover
3431         https://bugs.webkit.org/show_bug.cgi?id=66334
3432
3433         Reviewed by Tony Chang.
3434
3435         This patch moves us closer to switching the Chromium port from
3436         CoreGraphics to Skia.  This patch teaches our tools that the current
3437         Chromium Mac configuration is actually chromium-cg-mac, which makes
3438         room for a future chromium-mac configuration that uses Skia.
3439
3440         Shortly after this patch lands, I'll do a server-side move of the
3441         chromium-mac and chromium-mac-leopard directories to chromium-cg-mac
3442         and chromium-cg-mac-leopard.
3443
3444         * BuildSlaveSupport/build.webkit.org-config/config.json:
3445         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
3446         * Scripts/webkitpy/common/config/build.py:
3447         * Scripts/webkitpy/common/config/build_unittest.py:
3448         * Scripts/webkitpy/layout_tests/port/base.py:
3449         * Scripts/webkitpy/layout_tests/port/builders.py:
3450         * Scripts/webkitpy/layout_tests/port/chromium.py:
3451         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3452         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
3453         * Scripts/webkitpy/layout_tests/port/dryrun.py:
3454         * Scripts/webkitpy/layout_tests/port/factory.py:
3455         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
3456         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
3457         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
3458         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
3459         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
3460         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3461         * TestResultServer/static-dashboards/flakiness_dashboard.html:
3462
3463 2011-08-16  Dimitri Glazkov  <dglazkov@chromium.org>
3464
3465         garden-o-matic frontend needs a friendly relative time description method.
3466         https://bugs.webkit.org/show_bug.cgi?id=66324
3467
3468         Reviewed by Adam Barth.
3469
3470         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js: Added base.relativizeTime method.
3471         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js: Added unit tests.
3472         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Wired up Time widget to use it.
3473
3474 2011-08-16  Dimitri Glazkov  <dglazkov@chromium.org>
3475
3476         Summary view should not add multiple entries for the same test failure.
3477         https://bugs.webkit.org/show_bug.cgi?id=66318
3478
3479         Reviewed by Adam Barth.
3480
3481         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js: Added a simplistic updating button.
3482         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Added ways to check for
3483             equality of ui.notifications.FailingTest, and whether ui.notifications.TestFailures already contains a given failure analysis.
3484         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Added tests.
3485
3486 2011-08-16  Adam Roben  <aroben@apple.com>
3487
3488         Teach TestFailures that tests that have failed or passed many times in a row are not flaky
3489
3490         The basic strategy here is that once a test has failed or passed many times in a row we
3491         never again consider it as a possibly flaky test. It's a simple strategy but seems to result
3492         in many fewer false positives than our current behavior.
3493
3494         Fixes <http://webkit.org/b/66327> TestFailures page considers far too many tests to be
3495         flaky, including tests that failed for a while but then were fixed
3496
3497         Reviewed by Dan Bates.
3498
3499         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector.js:
3500         (FlakyLayoutTestDetector): Initialize new _buildCount property, which is used to track the
3501         number of non-too-many-failure builds we've seen.
3502         (FlakyLayoutTestDetector.prototype.incorporateTestResults): Don't track tests which haven't
3503         failed in the _maximumFailOrPassCount most recent builds. For other not-yet-considered-flaky
3504         tests, keep track of how many times they have passed or failed in a row. If they pass or
3505         fail more than _maximumFailOrPassCount times, consider them to be non-flaky. (Once a test is
3506         considered flaky it doesn't matter how many times it passes or fails.)
3507
3508         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector_unittests.js:
3509         Added tests for the above.
3510
3511 2011-08-16  Dimitri Glazkov  <dglazkov@chromium.org>
3512
3513         garden-o-matic needs a summary view with actions for each problem.
3514         https://bugs.webkit.org/show_bug.cgi?id=66144
3515
3516         Reviewed by Adam Barth.
3517
3518         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html: Added notifications tests.
3519         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js: Added.
3520         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Added.
3521         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Added.
3522         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/summary.css: Added.
3523         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Added.
3524
3525 2011-08-16  Dean Jackson  <dino@apple.com>
3526
3527         Adding Ted "hober" O'Connor as a non-committing contributor.
3528
3529         * Scripts/webkitpy/common/config/committers.py:
3530
3531 2011-08-16  Adam Roben  <aroben@apple.com>
3532
3533         Teach TestFailures how to interpret unfinished test runs
3534
3535         Fixes <http://webkit.org/b/66309> TestFailures thinks all tests passed in
3536         http://build.webkit.org/builders/Lion%20Intel%20Debug%20(Tests)/builds/136
3537
3538         Reviewed by David Kilzer.
3539
3540         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
3541         (Builder.prototype.getNumberOfFailingTests): Look for "isFinished" in the layout-test step
3542         rather than "isStarted" so that we don't count builds for which the test run never finished.
3543         Bumped the cache version to evict old, buggy cached data.
3544
3545         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js:
3546         Added a test for the above, and made a somewhat synthetic test more realistic by including
3547         more of the actual JSON data from build.webkit.org.
3548
3549         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js:
3550         (LayoutTestResultsLoader.prototype.start): Bumped the cache version to evict old, buggy
3551         cached data.
3552
3553 2011-08-16  Adam Roben  <aroben@apple.com>
3554
3555         Make Apple's Windows port fall back to Lion results instead of SnowLeopard
3556
3557         Apple's Windows port now uses Lion-era versions of CoreFoundation, ICU, etc., so in theory
3558         should match Lion's behavior.
3559
3560         Fixes <http://webkit.org/b/66302> Apple's Windows port matches Lion for some test results,
3561         but doesn't use Lion results
3562
3563         Reviewed by David Kilzer.
3564
3565         * Scripts/old-run-webkit-tests:
3566         (expectedDirectoryForTest):
3567         * Scripts/webkitpy/layout_tests/port/win.py:
3568         (WinPort.baseline_search_path):
3569         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
3570         (WinPortTest.test_baseline_search_path):
3571         Replaced mac-snowleopard with mac-lion.
3572
3573         * Scripts/webkitpy/common/config/build.py:
3574         (_should_file_trigger_build): Added an entry for the LayoutTests/platform/mac-lion
3575         directory, which all Apple Mac platforms and Apple Win platforms could potentially use
3576         results from. Removed Apple Win from being affected by mac-snowleopard changes, since it
3577         will no longer look there for results.
3578
3579         * Scripts/webkitpy/common/config/build_unittest.py:
3580         (ShouldBuildTest.test_should_build): Tests for the above changes.
3581
3582 2011-08-16  Dean Jackson  <dino@apple.com>
3583
3584         Move me from contributor to reviewer.
3585
3586         * Scripts/webkitpy/common/config/committers.py:
3587
3588 2011-08-15  Dimitri Glazkov  <dglazkov@chromium.org>
3589
3590         garden-o-matic frontend needs model.commitDataForRevisionRange function.
3591         https://bugs.webkit.org/show_bug.cgi?id=66252
3592
3593         Reviewed by Adam Barth.
3594
3595         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js: Added commitDataForRevisionRange method.
3596         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model_unittests.js: Added tests.
3597
3598 2011-08-15  Dimitri Glazkov  <dglazkov@chromium.org>
3599
3600         garden-o-matic frontend needs a generic way to track updates.
3601         https://bugs.webkit.org/show_bug.cgi?id=66245
3602
3603         Reviewed by Adam Barth.
3604
3605         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js: Added UpdateTracker.
3606         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js: Added tests.
3607
3608 2011-08-15  Adam Roben  <aroben@apple.com>
3609
3610         Teach TestWebKitAPI/gtest how to print JavaScript failures nicely
3611
3612         Failures now give output of the form: foo should be bar but is baz
3613
3614         Fixes <http://webkit.org/b/66240> It's hard to tell what the actual result of a failed JS
3615         test is in TestWebKitAPI's output
3616
3617         Reviewed by David Levin.
3618
3619         * TestWebKitAPI/JavaScriptTest.cpp:
3620         (TestWebKitAPI::JavaScriptCallbackContext::JavaScriptCallbackContext): Removed now-unused
3621         members.
3622         (TestWebKitAPI::javaScriptCallback): Changed to just store the result string in the context
3623         object, rather than doing any testing of it here.
3624         (TestWebKitAPI::runJSTest): Made this function a gtest predicate-formatter. This allows us
3625         to use a pretty error message when the test fails.
3626
3627         * TestWebKitAPI/JavaScriptTest.h: Changed runJSTest to a predicate-formatter, and added nice
3628         gtest-style macros that wrap it.
3629
3630         * TestWebKitAPI/Test.h: Removed now-unused TEST_ASSERT_RETURN.
3631
3632         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
3633         (TestWebKitAPI::TEST): Changed to use the new macros.
3634
3635         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp:
3636         (TestWebKitAPI::createSessionStateContainingFormData): Ditto. Note that this function no
3637         longer returns 0 when the JS test fails. That shouldn't have any effect on whether or not
3638         the test passes, though. Returning early seems to have been an unnecessary optimization.
3639
3640         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
3641         (TestWebKitAPI::TEST): Changed to use the new macros.
3642
3643 2011-08-15  Eric Seidel  <eric@webkit.org>
3644
3645         Move the Leaks bot back to ORWT until I can fix LeaksViewer regressions filed by Adam Roben in bug 66227 and 66228.
3646
3647         Unreviewed.
3648
3649         * Scripts/run-webkit-tests:
3650         (usingLeaks):
3651         (useNewRunWebKitTests):
3652
3653 2011-08-14  Adam Barth  <abarth@webkit.org>
3654
3655         Switch results detail view over to new-style object-oriented UI widgets