ab395092bfb7dd2cd85729f907650b2e8b4d0372
[WebKit.git] / Tools / ChangeLog
1 2011-01-11  Eric Seidel  <eric@webkit.org>
2
3         Reviewed by Adam Barth.
4
5         commit-queue should know how to upload archived results (for test flakes or general failures)
6         https://bugs.webkit.org/show_bug.cgi?id=52048
7
8         Now the queue will always upload results.  Either the entire zip, or just
9         the diffs.txt in the case of text failures.
10
11         This should make understanding flakes much easier, and paves the way
12         for having the EWS run layout tests (and upload failures).
13
14         In order to upload .zip files I had to teach bugzilla.py to autodetect
15         mime types from the filename.  Since mimetypes.py doesn't include a mapping
16         for .patch files, I have it add one before calling guess_type.
17
18         We may find that always uploading the whole zip instead of just the -diffs.txt
19         file is preferable, but for now I'm keeping the old behavior because it makes
20         quickly understanding text failures easy.
21
22         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
23         * Scripts/webkitpy/common/system/workspace.py: Added.
24         * Scripts/webkitpy/common/system/workspace_unittest.py: Added.
25         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
26         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
27         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
28         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
29         * Scripts/webkitpy/tool/commands/queues.py:
30         * Scripts/webkitpy/tool/commands/queues_unittest.py:
31
32 2011-01-10  Sheriff Bot  <webkit.review.bot@gmail.com>
33
34         Unreviewed, rolling out r75464.
35         http://trac.webkit.org/changeset/75464
36         https://bugs.webkit.org/show_bug.cgi?id=52193
37
38         Followup rollout for 75474 (Requested by Ossy on #webkit).
39
40         * MiniBrowser/mac/BrowserWindowController.m:
41         (-[BrowserWindowController awakeFromNib]):
42         * MiniBrowser/win/BrowserView.cpp:
43         (BrowserView::create):
44         * WebKitTestRunner/TestController.cpp:
45         (WTR::createOtherPage):
46         (WTR::TestController::initialize):
47
48 2011-01-10  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
49
50         Reviewed by Csaba Osztrogonác.
51
52         [Qt] Baseline qt_minimal configuration
53         https://bugs.webkit.org/show_bug.cgi?id=51313
54
55         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
56         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): Add
57         QT_NO_UNDOSTACK guard.
58
59         * QtTestBrowser/launcherwindow.cpp:
60         (LauncherWindow::createChrome): Add QT_NO_SHORTCUT and QT_NO_PRINTER
61         guards.
62         (LauncherWindow::applyZoom): Add QT_NO_ANIMATION guard.
63         (LauncherWindow::screenshot): Add QT_NO_FILEDIALOG guard.
64         (LauncherWindow::selectElements): Add QT_NO_INPUTDIALOG guard.
65         (LauncherWindow::showUserAgentDialog): Add QT_NO_COMBOBOX guard.
66
67         * QtTestBrowser/launcherwindow.h:
68         * QtTestBrowser/locationedit.cpp: Add QT_NO_INPUTDIALOG guard.
69         * QtTestBrowser/locationedit.h: Ditto.
70
71         * QtTestBrowser/mainwindow.cpp:
72         (MainWindow::buildUI): Add QT_NO_INPUTDIALOG, QT_NO_SHORTCUT and
73         QT_NO_UNDOSTACK guards.
74         (MainWindow::setAddressUrl): Add QT_NO_INPUTDIALOG guard.
75         (MainWindow::changeLocation): Ditto.
76         (MainWindow::openFile): Add QT_NO_FILEDIALOG guard.
77         (MainWindow::openLocation): Add QT_NO_INPUTDIALOG guard.
78
79         * QtTestBrowser/webpage.cpp:
80         (WebPage::openUrlInDefaultBrowser): Add QT_NO_DESKTOPSERVICES guard.
81         (WebPage::authenticationRequired): Add QT_NO_LINEEDIT guard.
82
83         * QtTestBrowser/webview.cpp:
84         (WebViewGraphicsBased::animatedFlip): Add QT_NO_ANIMATION guard.
85         (WebViewGraphicsBased::animatedYFlip): Ditto.
86
87 2011-01-10  Sam Weinig  <sam@webkit.org>
88
89         Fix build.
90
91         * MiniBrowser/mac/BrowserWindowController.m:
92         (-[BrowserWindowController awakeFromNib]):
93         * MiniBrowser/win/BrowserView.cpp:
94         (BrowserView::create):
95         * WebKitTestRunner/TestController.cpp:
96         (WTR::createOtherPage):
97         (WTR::TestController::initialize):
98
99 2011-01-10  Eric Seidel  <eric@webkit.org>
100
101         Reviewed by Ojan Vafai.
102
103         style-queue messages are way too long for big patches
104         https://bugs.webkit.org/show_bug.cgi?id=52161
105
106         We definitely could build much fancier list-to-string-with-limit functions
107         but this should be sufficient for our needs at the moment.
108
109         * Scripts/webkitpy/common/system/executive.py:
110         * Scripts/webkitpy/common/system/executive_unittest.py:
111
112 2011-01-10  Tony Chang  <tony@chromium.org>
113
114         Unreviewed, rolling out r75398.
115         http://trac.webkit.org/changeset/75398
116         https://bugs.webkit.org/show_bug.cgi?id=52008
117
118         Some layout tests are crashing on Chromium Win.
119
120         * DumpRenderTree/chromium/WebViewHost.cpp:
121         (WebViewHost::updatePaintRect):
122         * DumpRenderTree/chromium/WebViewHost.h:
123
124 2011-01-10  Adam Roben  <aroben@apple.com>
125
126         Roll out r75392
127
128         It isn't needed now that r75289 has been rolled out.
129
130         * Scripts/run-javascriptcore-tests:
131
132 2011-01-10  Maciej Stachowiak  <mjs@apple.com>
133
134         Reviewed by Anders Carlsson.
135
136         WebKitTestRunner uses crazy amounts of CPU, making layout tests slow and flaky
137         https://bugs.webkit.org/show_bug.cgi?id=52160
138
139         * WebKitTestRunner/mac/TestControllerMac.mm:
140         (WTR::TestController::platformRunUntil): Instead of busy-looping, wait for the timeout.
141         Anything that can make runUntil() conditions turn true will happen on a run loop cycle
142         anyway.
143
144 2011-01-10  Tony Chang  <tony@chromium.org>
145
146         Reviewed by Mihai Parparita.
147
148         [chromium] fix for animated gif layout tests
149         https://bugs.webkit.org/show_bug.cgi?id=52008
150
151         * DumpRenderTree/chromium/WebViewHost.cpp: Schedule a paint when we update the paint rect
152             to trigger gif animations.
153         (WebViewHostPaintTask::WebViewHostPaintTask):
154         (WebViewHostPaintTask::runIfValid):
155         (WebViewHost::updatePaintRect):
156         * DumpRenderTree/chromium/WebViewHost.h:
157         (WebViewHost::taskList):
158
159 2011-01-10  Alejandro G. Castro  <alex@igalia.com>
160
161         Reviewed by Xan Lopez.
162
163         [GTK] Fix gtk2 compilation for master
164         https://bugs.webkit.org/show_bug.cgi?id=51885
165
166         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
167         (createBitmapContextFromWebView): Replaced the old
168         gdk_drawable_get_size with gdk_pixmap_get_size.
169
170 2011-01-10  Patrick Gansterer  <paroga@webkit.org>
171
172         Reviewed by Laszlo Gombos.
173
174         [WINCE] Reenable NPAPI after r75203
175         https://bugs.webkit.org/show_bug.cgi?id=52109
176
177         Remove the !isWinCE() check for ENABLE_NETSCAPE_PLUGIN_API and replace
178         it with !isEfl(), because EFL port does not support NPAPI (yet).
179
180         * Scripts/build-webkit:
181
182 2011-01-10  Adam Roben  <aroben@apple.com>
183
184         Skip some asserting JS tests
185
186         See <http://webkit.org/b/52156>.
187
188         * Scripts/run-javascriptcore-tests:
189
190 2011-01-10  Martin Robinson  <mrobinson@igalia.com>
191
192         Reviewed by Xan Lopez.
193
194         [GTK] build-webkit disable Blob support via arguments passed to automake
195         https://bugs.webkit.org/show_bug.cgi?id=52097
196
197         * Scripts/build-webkit: Enable Blob support when building WebKitGTK+ via
198         build-webkit.
199
200 2011-01-10  Adam Roben  <aroben@apple.com>
201
202         Use the same name and description for TestNetscapePlugin on Windows and
203         Mac
204
205         Fixes <http://webkit.org/b/52151>
206         fast/frames/iframe-reparenting-plugins.html fails on Windows
207
208         Reviewed by Steve Falkenburg.
209
210         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Copied
211         the name and description from Mac's Info.plist.
212
213 2011-01-10  Siddharth Mathur <siddharth.mathur@nokia.com>
214
215         Reviewed by Laszlo Gombos.
216
217         [Qt][WK2] Guard gcc-specific syntax
218
219         Non-gcc based compliers choke on the "-include"
220         syntax for preinclude, place guard around it.
221
222         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
223         * WebKitTestRunner/qt/WebKitTestRunner.pro:
224
225 2011-01-10  Andreas Kling  <kling@webkit.org>
226
227         Reviewed by Simon Hausmann.
228
229         [Qt] [WK2] MiniBrowser does not load pages opened in new windows
230         https://bugs.webkit.org/show_bug.cgi?id=52111
231
232         When getting a createNewPage() callback from QWKPage, create the
233         new page with the same QWKContext as the page that is passed to
234         the callback.
235
236         * MiniBrowser/qt/BrowserView.h:
237         * MiniBrowser/qt/BrowserWindow.cpp:
238         (newPageFunction):
239         (BrowserWindow::BrowserWindow):
240         * MiniBrowser/qt/BrowserWindow.h:
241
242 2011-01-10  Andreas Kling  <kling@webkit.org>
243
244         Reviewed by Kenneth Rohde Christiansen.
245
246         [Qt] MiniBrowser: Remove superfluous createNewPage() callback
247
248         BrowserView set its own useless createNewPage() callback on QWKPage.
249         This was immediately overridden by BrowserWindow anyway, so remove
250         the BrowserView one.
251
252         * MiniBrowser/qt/BrowserView.cpp:
253         (BrowserView::BrowserView):
254
255 2011-01-10  John Knottenbelt  <jknotten@chromium.org>
256
257         Reviewed by Jeremy Orlow.
258
259         [Chromium] Remove non-client-based Geolocation code
260         https://bugs.webkit.org/show_bug.cgi?id=50921
261
262         * DumpRenderTree/chromium/LayoutTestController.cpp:
263         (LayoutTestController::setGeolocationPermission):
264         (LayoutTestController::setMockGeolocationPosition):
265         (LayoutTestController::setMockGeolocationError):
266         * DumpRenderTree/chromium/WebViewHost.cpp:
267         (WebViewHost::geolocationClientMock):
268         (WebViewHost::reset):
269         * DumpRenderTree/chromium/WebViewHost.h:
270
271 2011-01-10  Eric Seidel  <eric@webkit.org>
272
273         Reviewed by Adam Barth.
274
275         Commit bot tried to land r? cq+ patch
276         https://bugs.webkit.org/show_bug.cgi?id=36638
277
278         It should now be possible to post a patch with r? and cq+ and the
279         commit-queue will correctly wait for the r+ before attempting to land the patch.
280         (This was a feature requested by several users.)
281
282         One caveat: We don't actually reject r-, cq+ patches from the queue
283         (we just ignore them), but I think that's OK for now.
284
285         I also noticed that setting r- once a commit-queue node had grabbed
286         a patch would not properly cancel the landing.  That's fixed and
287         tested in this patch.
288
289         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
290         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
291         * Scripts/webkitpy/tool/bot/feeders.py:
292         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
293
294 2011-01-08  Benjamin Poulain  <benjamin.poulain@nokia.com>
295
296         Reviewed by Kenneth Rohde Christiansen.
297
298         [Qt] QtWebKit crashes when using XMLHttpRequest from the unload event
299         https://bugs.webkit.org/show_bug.cgi?id=51934
300
301         When accessing the network from the destructor of QWebPage, the network access manager
302         was already deleted because the object WebPage was already destructed.
303
304         This solve the problem by linking the lifetime of the network access manager to WebPage's QObject.
305         The object is now destructed in the destructor of QObject.
306
307         * QtTestBrowser/webpage.cpp:
308         (WebPage::WebPage):
309         (WebPage::setQnamThreaded):
310         * QtTestBrowser/webpage.h:
311         (QtNAMThread::QtNAMThread):
312
313 2011-01-08  Eric Seidel  <eric@webkit.org>
314
315         Reviewed by Ojan Vafai.
316
317         test_failures.py should not mention TestShell (long live DumpRenderTree!)
318         https://bugs.webkit.org/show_bug.cgi?id=52067
319
320         I ran test-webkitpy, but didn't bother adding a unit test for this string change.
321         https://bugs.webkit.org/show_bug.cgi?id=51138#c3 is an example of why this is needed.
322
323         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
324
325 2011-01-08  Eric Seidel  <eric@webkit.org>
326
327         Reviewed by Mihai Parparita.
328
329         commit-queue hangs when the ChangeLog diff is bad
330         https://bugs.webkit.org/show_bug.cgi?id=52072
331
332         * Scripts/webkitpy/tool/steps/validatechangelogs.py:
333         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
334
335 2011-01-08  Adam Barth  <abarth@webkit.org>
336
337         Teach svn-apply how to re-write WebCore to Source/WebCore.
338
339         * Scripts/VCSUtils.pm:
340
341 2011-01-07  Adam Barth  <abarth@webkit.org>
342
343         Rubber-stamped by Eric Seidel.
344
345         Move WebCore to Source
346         https://bugs.webkit.org/show_bug.cgi?id=52050
347
348         Update the tools to understand WebCore's new location.
349
350         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
351         * DumpRenderTree/wscript:
352         * GNUmakefile.am:
353         * Scripts/build-webkit:
354         * Scripts/do-file-rename:
355         * Scripts/do-webcore-rename:
356         * Scripts/generate-qt-inspector-resource:
357         * Scripts/prepare-ChangeLog:
358         * Scripts/run-bindings-tests:
359         * Scripts/update-iexploder-cssproperties:
360         * Scripts/update-sources-list.py:
361         * Scripts/update-webkit-localizable-strings:
362         * Scripts/webkitdirs.pm:
363         * Scripts/webkitpy/common/config/build.py:
364         * Scripts/webkitpy/common/config/build_unittest.py:
365         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
366         * Scripts/webkitpy/style/checker.py:
367         * Scripts/webkitpy/style/checker_unittest.py:
368         * WebKitTestRunner/DerivedSources.pro:
369         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
370         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh:
371         * wx/browser/wscript:
372         * wx/build/settings.py:
373
374 2011-01-07  Maciej Stachowiak  <mjs@apple.com>
375
376         Reviewed by Sam Weinig.
377
378         Make WebKitTestRunner rest between loads more robust to avoid test crashes
379         https://bugs.webkit.org/show_bug.cgi?id=52086
380
381         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
382         (WTR::InjectedBundle::didReceiveMessage):
383         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
384         (WTR::LayoutTestController::notifyDone):
385         * WebKitTestRunner/TestController.cpp:
386         (WTR::TestController::resetStateToConsistentValues):
387         (WTR::TestController::run):
388
389 2011-01-07  James Robinson  <jamesr@chromium.org>
390
391         Revert "Implement mozilla's animationTime property"
392         https://bugs.webkit.org/show_bug.cgi?id=51952
393
394         This approach isn't quite right.
395
396         * DumpRenderTree/chromium/WebViewHost.cpp:
397         (WebViewHost::paintInvalidatedRegion):
398
399 2011-01-07  Adam Roben  <aroben@apple.com>
400
401         Build master fix
402
403         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
404         (RunWebKitTests.start): Don't try to concatenate a list and a string.
405
406 2011-01-07  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>
407
408         Reviewed by Csaba Osztrogonác.
409
410         run-qtwebkit-tests should be able to kill a testsuite.
411
412         Add new option in the script that can setup a timeout for a test.
413         If the test execution takes more then specified time then the test
414         would be terminated.
415
416         [Qt] run-qtwebkit-tests needs timeout
417         https://bugs.webkit.org/show_bug.cgi?id=51894
418
419         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
420         * Scripts/run-qtwebkit-tests:
421
422 2011-01-07  Csaba Osztrogonác  <ossy@webkit.org>
423
424         Unreviewed fix after r75233.
425
426         Based on idea from Eric Seidel.
427
428         Add remote zip file handling to webkitpy.
429         https://bugs.webkit.org/show_bug.cgi?id=50901
430
431         * Scripts/webkitpy/common/system/fileset.py: Make python 2.5 happy.
432
433 2011-01-07  Shane Stephens  <shanestephens@google.com>
434
435         Reviewed by Eric Seidel.
436
437         svn-apply: should support git binary delta diffs
438         https://bugs.webkit.org/show_bug.cgi?id=38864
439
440         * Scripts/VCSUtils.pm:
441         * Scripts/svn-apply:
442
443 2011-01-06  Julie Parent  <jparent@chromium.org>
444
445         Reviewed by Eric Seidel.
446
447         Test Result Server not removing old results.
448         https://bugs.webkit.org/show_bug.cgi?id=52012
449
450         * TestResultServer/model/jsonresults.py:
451         Fix off-by-one: Truncate if >= num_runs, not just >.
452         * TestResultServer/model/jsonresults_unittest.py:
453         Add unit test to test that merging in a new result with the same value
454         as the last result causes previous result to fall off.
455
456 2011-01-06  James Kozianski  <koz@chromium.org>
457
458         Reviewed by Mihai Parparita.
459
460         Add classes to provide a consistent interface to a set of files.
461         https://bugs.webkit.org/show_bug.cgi?id=50901
462
463         These classes allow us to write code that is agnostic to whether a
464         particular set of files resides in a local directory or in a zip file
465         on a remote machine.
466
467         * Scripts/webkitpy/common/system/directoryfileset.py: Added.
468         * Scripts/webkitpy/common/system/directoryfileset_unittest.py: Added.
469         * Scripts/webkitpy/common/system/fileset.py: Added.
470         * Scripts/webkitpy/common/system/filesystem.py:
471         * Scripts/webkitpy/common/system/filesystem_mock.py:
472         * Scripts/webkitpy/common/system/zipfileset.py: Added.
473         * Scripts/webkitpy/common/system/zipfileset_unittest.py: Added.
474
475 2011-01-06  Eric Seidel  <eric@webkit.org>
476
477         Reviewed by Adam Barth.
478
479         NetworkTransaction should log the url it is retrying
480         https://bugs.webkit.org/show_bug.cgi?id=52043
481
482         * Scripts/webkitpy/common/net/networktransaction.py:
483         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
484
485 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
486
487         Windows build fix.
488         Import os before using it.
489
490         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
491
492 2011-01-06  Eric Seidel  <eric@webkit.org>
493
494         Reviewed by Adam Barth.
495
496         StyleQueue fails to report errors when patches have many files
497         https://bugs.webkit.org/show_bug.cgi?id=52042
498
499         This is one of at least two errors preventing style error reporting at the moment.
500         When we moved to passing the list of files to check explicitly,
501         we started to exceed the 500 character TEXT field limit for our AppEngine model object.
502         We could change the type of the QueueStatus.message type, or we could
503         just teach statusserver.py how to clamp values (and warn when it does).
504         I chose the latter path.
505
506         * Scripts/webkitpy/common/net/statusserver.py:
507
508 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
509
510         Reviewed by Stephanie Lewis.
511         
512         Fix syntax error in script.
513
514         Windows bots need to archive/unarchive builds to/from configuration-specific directories
515         https://bugs.webkit.org/show_bug.cgi?id=51996
516
517         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
518
519 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
520
521         Unreviewed, fixing WinCE build after r75196.
522
523         WinCE port does not (yet) support NPAPI.
524
525         * Scripts/build-webkit:
526
527 2011-01-06  Xan Lopez  <xlopez@igalia.com>
528
529         Reviewed by Darin Adler.
530
531         File::Spec->rel2abs in sunspider-compare-results mangles parameters
532         https://bugs.webkit.org/show_bug.cgi?id=52015
533
534         * Scripts/sunspider-compare-results: call rel2abs on our arguments
535         after the platform has been detected, otherwise the script will
536         mangle things like '--gtk' into '/a/path/--gtk', breaking the
537         detection.
538
539 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
540
541         Reviewed by Eric Seidel.
542
543         Add ENABLE_NETSCAPE_PLUGIN_API, ENABLE_ORIENTATION_EVENTS and ENABLE_TOUCH_EVENTS flags to build-webkit
544         https://bugs.webkit.org/show_bug.cgi?id=51346
545
546         * Scripts/build-webkit:
547
548 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
549
550         Reviewed by Adam Roben.
551
552         Windows bots need to archive/unarchive builds to/from configuration-specific directories
553         https://bugs.webkit.org/show_bug.cgi?id=51996
554         
555         After the configuration directory change, we were archiving the incorrect directory for
556         build product, so we were running tests on the wrong binaries.
557         
558         This change archives the correct directory, and also unarchives it into a configuration-
559         specific directory.
560
561         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Use a configuration-specific directory on Windows.
562         * BuildSlaveSupport/built-product-archive: Unarchive/archive to/from proper directory.
563
564 2011-01-06  Eric Seidel  <eric@webkit.org>
565
566         Reviewed by Mihai Parparita.
567
568         commit-queue mentions "Text diff mismatch" 4 times instead of once per failure
569         https://bugs.webkit.org/show_bug.cgi?id=52002
570
571         See an example of this here:
572         https://bugs.webkit.org/show_bug.cgi?id=51314#c2
573
574         It's due to the fact that we pass around TestFailure() instance
575         objects and yet expect them to all compare to be the same.
576
577         This is bad.  We should either have shared instances of these values
578         or we should just pass around the class names.  There are already hacks
579         in place to make TestFailure objects pass equality tests, I just added
580         a __hash__ implementation so they can be used in sets as expected.
581
582         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
583         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
584
585 2011-01-06  Evan Martin  <evan@chromium.org>
586
587         Reviewed by Tony Chang.
588
589         [gdb] handle inaccessible memory and UChar*
590         https://bugs.webkit.org/show_bug.cgi?id=52003
591
592         To pretty-print a UChar*, we just grope around in the memory
593         looking for a terminating NUL.  We need to handle the exception
594         that can occur when we poke into an invalid location.
595
596         Additionally, the logic for choosing which pretty-printer would
597         early return before hitting the point where we'd use the UChar*
598         printer.  (Did this ever work?  How did it regress?)
599
600         * gdb/webkit.py:
601
602 2011-01-05  Brian Weinstein  <bweinstein@apple.com>
603
604         Reviewed by Ada Chan.
605
606         WebKit2: Should be able to call into injected bundle to ask if we should allow resource loads
607         https://bugs.webkit.org/show_bug.cgi?id=51969
608         
609         Add shouldLoadResourceForFrame to WTR::InjectedBundlePage.
610
611         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
612         (WTR::InjectedBundlePage::InjectedBundlePage):
613         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Stub implementation.
614         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
615
616 2011-01-06  James Robinson  <jamesr@chromium.org>
617
618         Reviewed by Simon Fraser.
619
620         Implement mozilla's animationTime property
621         https://bugs.webkit.org/show_bug.cgi?id=51952
622
623         Chromium DRT support for webkitAnimationTime.
624
625         * DumpRenderTree/chromium/WebViewHost.cpp:
626         (WebViewHost::paintInvalidatedRegion):
627
628 2011-01-06  Julie Parent  <jparent@chromium.org>
629
630         Reviewed by Tony Chang.
631
632         Test Result Server always truncates number of results to JSON_RESULTS_MAX_BUILDS
633         https://bugs.webkit.org/show_bug.cgi?id=51217
634
635         * TestResultServer/model/jsonresults.py:
636         Pass num_runs through to _remove_items_over_max_number_of_builds, and use the value.
637         Adds missing documentation.
638         * TestResultServer/model/jsonresults_unittest.py:
639         Add unit test to test that truncation happens at smaller value than JSON_RESULTS_MAX_BUILDS.
640         Update test_merge to take a number of builds to truncate at.
641
642 2011-01-06  Adam Barth  <abarth@webkit.org>
643
644         Reviewed by Eric Seidel.
645
646         The EWS should log outside of the working directory
647         https://bugs.webkit.org/show_bug.cgi?id=51986
648
649         This patch prepare us for using git clean -x -d -f in the EWS wrapper
650         script, which will actually clean the working copy back to a pristine
651         state instead of leaving untracked directories and ignored files.
652
653         * Scripts/webkitpy/tool/commands/queues.py:
654         * Scripts/webkitpy/tool/commands/queues_unittest.py:
655
656 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
657
658         Windows build fix.
659         Back out attempted change to built-product-archive.
660
661         * BuildSlaveSupport/built-product-archive:
662
663 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
664
665         Windows build fix.
666         Include configuration name when unpacking a build archive.
667
668         Needed, since we split Windows build results into configuration-specific directories
669         under WebKitOutputDir.
670
671         * BuildSlaveSupport/built-product-archive:
672
673 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
674
675         Reviewed by Darin Adler.
676
677         Debug and Release builds on Windows clobber each other
678         https://bugs.webkit.org/show_bug.cgi?id=49185
679
680         Changes the structure of WebKitBuild build products directory so we
681         completely separate each build configuration into independent directories.
682         
683         Although we previously had per-configuration directories for obj, this change adds
684         per-configuration directories for bin, lib, obj, and include. Each configuration's
685         build products are stored within a directory inside of WebKitBuild.
686         
687         Most use of $(WebKitOutputDir) in the build files has been replaced by $(ConfigurationBuildDir),
688         defined in common.vsprops to be $(WebKitOutputDir)\$(ConfigurationName).
689
690         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops:
691         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd:
692         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd:
693         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
694         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd:
695         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd:
696         * DumpRenderTree/win/ImageDiffCommon.vsprops:
697         * DumpRenderTree/win/ImageDiffPostBuild.cmd:
698         * DumpRenderTree/win/ImageDiffPreBuild.cmd:
699         * FindSafari/FindSafari.vcproj:
700         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
701         * MiniBrowser/MiniBrowserPostBuild.cmd:
702         * MiniBrowser/MiniBrowserPreBuild.cmd:
703         * Scripts/webkitdirs.pm:
704         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
705         * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops:
706         * TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd:
707         * TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd:
708         * TestWebKitAPI/win/copy-resources.cmd:
709         * WebKitAPITest/WebKitAPITestCommon.vsprops:
710         * WebKitAPITest/WebKitAPITestPostBuild.cmd:
711         * WebKitAPITest/WebKitAPITestPreBuild.cmd:
712         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
713         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
714         * WebKitTestRunner/win/InjectedBundle.vcproj:
715         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops:
716         * WebKitTestRunner/win/InjectedBundlePostBuild.cmd:
717         * WebKitTestRunner/win/InjectedBundlePreBuild.cmd:
718         * WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd:
719         * WebKitTestRunner/win/WebKitTestRunnerPreBuild.cmd:
720         * WinLauncher/WinLauncherCommon.vsprops:
721         * WinLauncher/WinLauncherPostBuild.cmd:
722         * WinLauncher/WinLauncherPreBuild.cmd:
723
724 2011-01-05  Jan Erik Hanssen  <jhanssen@sencha.com>
725
726         Reviewed by Ariya Hidayat.
727
728         [Qt] TestNetscapePlugin doesn't link on OS X
729         https://bugs.webkit.org/show_bug.cgi?id=51948
730
731         Only add a dependency on libX11 on X11 systems
732
733         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
734
735 2011-01-05  Jeff Miller  <jeffm@apple.com>
736
737         Reviewed by Adam Roben.
738
739         check-webkit-style should allow unnecessary parameter names in WebKit2 APIs because we're matching CF's header style
740         https://bugs.webkit.org/show_bug.cgi?id=51970
741
742         * Scripts/webkitpy/style/checker.py:
743         Add -readability/naming for WebKit2 C API directories.
744
745 2011-01-05  Eric Seidel  <eric@webkit.org>
746
747         Unreviewed, just fixing one more log error from my previous python patch.
748
749         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
750         https://bugs.webkit.org/show_bug.cgi?id=51802
751
752         webkit-patch failure-reason was logging about parsing errors
753         due to my misunderstanding of how BeautifulSoup.findAll worked.
754
755         Fixed, and added a unit test.
756
757         * Scripts/webkitpy/common/net/layouttestresults.py:
758         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
759
760 2011-01-05  Benjamin Poulain  <benjamin.poulain@nokia.com>
761
762         Reviewed by Kenneth Rohde Christiansen.
763
764         [Qt] [WK2] Add the possibility to open window from the WebProcess in Minibrowser
765         https://bugs.webkit.org/show_bug.cgi?id=51951
766
767         Set a function to QWKPage::setCreateNewPageFunction() in Minibrowser so there is a way
768         to create new window from WebKit.
769
770         * MiniBrowser/qt/BrowserWindow.cpp:
771         (newPageFunction):
772         (BrowserWindow::BrowserWindow):
773         (BrowserWindow::page): Added to avoid the indirect access to QWKPage spread in the class
774         (BrowserWindow::newWindow):
775         (BrowserWindow::updateUserAgentList):
776         (BrowserWindow::showUserAgentDialog):
777         * MiniBrowser/qt/BrowserWindow.h: Add the global variable backingStoreTypeForNewWindow to
778         define the type of the backing store used for new windows.
779         * MiniBrowser/qt/main.cpp:
780         (main):
781
782 2011-01-05  Eric Seidel  <eric@webkit.org>
783
784         Reviewed by Ojan Vafai.
785
786         commit-queue should report failure type when reporting flaky tests
787         https://bugs.webkit.org/show_bug.cgi?id=51900
788
789         This patch was a ridiculous amount of plumbing.  In the end I like
790         the NRWT-style TestResult class even less.  But now we're passing
791         a list of TestResult objects from the queue to the FlakyTestReporter.
792         Thus the FlakyTestReporter can more easily report what type of failure
793         occurred.
794
795         In the process, I found that I was not alone in finding TestResult
796         cumbersome to use.  A bunch of code was trying to create a TestResult
797         object with default values.  However since the constructor didn't make
798         this easy, some places were getting it wrong (including the TestResult unit test)!
799         I've fixed the TestResult constructor to have default values for non-essential
800         arguments.
801
802         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
803         * Scripts/webkitpy/common/net/layouttestresults.py:
804         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
805         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
806         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
807         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
808         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
809         * Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py:
810         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
811         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
812         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
813         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
814         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
815         * Scripts/webkitpy/tool/commands/queues.py:
816         * Scripts/webkitpy/tool/commands/queues_unittest.py:
817
818 2011-01-05  Eric Seidel  <eric@webkit.org>
819
820         Unreviewed.
821
822         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
823         https://bugs.webkit.org/show_bug.cgi?id=51802
824
825         Add another unit test to cover a previously missing import.
826
827         * Scripts/webkitpy/common/net/layouttestresults.py:
828         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
829
830 2011-01-05  Mihai Parparita  <mihaip@chromium.org>
831
832         Reviewed by David Levin.
833
834         Add mihaip@chromium.org as a reviewer
835         https://bugs.webkit.org/show_bug.cgi?id=51966
836         
837         Add myself as a reviewer.
838
839         * Scripts/webkitpy/common/config/committers.py:
840
841 2011-01-05  James Simonsen  <simonjam@chromium.org>
842
843         Unreviewed. Adding myself to the list of committers.
844
845         * Scripts/webkitpy/common/config/committers.py:
846
847 2011-01-05  Eric Seidel  <eric@webkit.org>
848
849         Unreviewed.
850
851         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
852         https://bugs.webkit.org/show_bug.cgi?id=51802
853
854         Fix two exceptions seen on the bots after my original commit.
855
856         * Scripts/webkitpy/common/net/layouttestresults.py:
857         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
858
859 2011-01-05  Kundu Suchismita  <suchi.kundu@nokia.com>
860
861         Reviewed by Andreas Kling.
862
863         [Qt]Add local storage settings to QtTestBrowser command line arguments 
864         https://bugs.webkit.org/show_bug.cgi?id=51750
865
866         * QtTestBrowser/main.cpp:
867         (LauncherApplication::handleUserOptions):
868          Local storage settings can be enable form command line arguments for
869          QtTestBrowser.
870
871 2011-01-05  Chris Fleizach  <cfleizach@apple.com>
872
873         Reviewed by Martin Robinson.
874
875         GTK: AX: DRT needs to use correct root object method.
876         https://bugs.webkit.org/show_bug.cgi?id=51911
877
878         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
879         (AccessibilityController::rootElement):
880
881 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
882
883         Rubber-stamped by Csaba Osztrogonác.
884
885         Based on idea from Péter Gál.
886
887         * Scripts/webkitpy/tool/bot/sheriff.py: Remove unnecessary apostrophes around revision numbers.
888
889 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
890
891         Reviewed by Adam Barth.
892
893         sheriff-bot should be able to do multi-revision rollouts
894         https://bugs.webkit.org/show_bug.cgi?id=51176
895
896         * Scripts/webkitpy/tool/bot/irc_command.py:
897         * Scripts/webkitpy/tool/bot/sheriff.py:
898         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
899
900 2011-01-05  Eric Seidel  <eric@webkit.org>
901
902         Reviewed by Adam Barth.
903
904         queues.webkit.org should have per-bot status pages
905         https://bugs.webkit.org/show_bug.cgi?id=51906
906
907         Just adds a /queue-status/QUEUE_NAME/bots/BOT_ID page to show
908         statuses from a single queue.  Now that we have many bots servicing
909         some queues (commit-queue, win-ews, etc.) its easy to have the messages
910         you care about scroll off the end of the 15-message limit on the main page.
911
912         Eventually we should probably rename /queue-status to /queue or /queues,
913         but that's fodder for another patch.
914
915         * QueueStatusServer/handlers/queuestatus.py:
916         * QueueStatusServer/index.yaml:
917         * QueueStatusServer/main.py:
918         * QueueStatusServer/templates/includes/singlequeuestatus.html:
919          - This probably should use a custom filter instead of hard-coding
920            the URL scheme here, but I couldn't figure out how to easily
921            create such a filter.  Most filters work with "strings" so we can't
922            pass the status object.  We could add a method to the status
923            object and call that, but that seemed a bit strange too.
924         * QueueStatusServer/templates/queuestatus.html:
925
926 2011-01-05  Carlos Garcia Campos  <cgarcia@igalia.com>
927
928         Unreviewed. Adding myself to the list of committers.
929
930         * Scripts/webkitpy/common/config/committers.py:
931
932 2011-01-04  Koan-Sin Tan  <koansin.tan@gmail.com>
933
934         Reviewed by David Levin.
935
936         check-webkit-style treated some macros with parentheses after #elif as function calls
937         https://bugs.webkit.org/show_bug.cgi?id=51695
938
939         Ingore function call space checking in any preprocessor directives
940         (things starting with #). Change search() to match() because 
941         preprocessor directives are supposed to be in the beginning of lines.
942
943         * Scripts/webkitpy/style/checkers/cpp.py:
944         * Scripts/webkitpy/style/checkers/cpp_unittest.py: make sure there is no false positives for #elif cases
945
946 2011-01-04  Søren Gjesse  <sgjesse@chromium.org>
947
948         Reviewed by Tony Chang.
949
950         Change the --multi-load test option to --stress-opt
951         https://bugs.webkit.org/show_bug.cgi?id=50751
952
953         * DumpRenderTree/chromium/DumpRenderTree.cpp:
954         (runTest):
955         (main):
956         * DumpRenderTree/chromium/TestShell.cpp:
957         (TestShell::TestShell):
958         * DumpRenderTree/chromium/TestShell.h:
959         (TestShell::stressOpt):
960         (TestShell::setStressOpt):
961         (TestShell::stressDeopt):
962         (TestShell::setStressDeopt):
963         (TestShell::javaScriptFlags):
964         (TestShell::setJavaScriptFlags):
965         * Scripts/webkitpy/layout_tests/port/chromium.py:
966         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
967
968 2011-01-04  Chris Fleizach  <cfleizach@apple.com>
969
970         Reviewed by Sam Weinig.
971
972         WK2: Support Accessibility
973         https://bugs.webkit.org/show_bug.cgi?id=51859
974
975         Use rootObject() method to get top of accessibility tree.
976
977         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
978         (AccessibilityController::focusedElement):
979         (AccessibilityController::rootElement):
980
981 2011-01-03  Martin Robinson  <mrobinson@igalia.com>
982
983         Reviewed by Darin Adler.
984
985         Remove the last non-GObject usage of PlatformRefPtr and move the code to GRefPtr
986         https://bugs.webkit.org/show_bug.cgi?id=51846
987
988         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: Change usage of PlatformRefPtr
989         back to GRefPtr.
990
991 2011-01-04  Zhe Su  <suzhe@chromium.org>
992
993         Reviewed by Kenneth Russell.
994
995         Fix insertText, setMarkedText and unmarkText methods of
996         TextInputController to call corresponding methods of WebKit::WebView
997         rather than WebKit::WebFrame. This change matches the behavior of
998         chromium browser.
999         insertText corresponds to WebView::confirmComposition(text)
1000         setMarkedText corresponds to WebView::setComposition(...)
1001         unmarkText corresponds to WebView::confirmComposition()
1002         https://bugs.webkit.org/show_bug.cgi?id=51693
1003
1004         * DumpRenderTree/chromium/TextInputController.cpp:
1005         (TextInputController::insertText):
1006         (TextInputController::setMarkedText):
1007         (TextInputController::unmarkText):
1008
1009 2011-01-04  Dihan Wickremasuriya  <dihan.wickremasuriya@nokia.com>
1010
1011         Reviewed by Laszlo Gombos.
1012
1013         [Qt] [Symbian] Do not remove 0 byte sized files from productDir
1014
1015         On Symbian productDir points to the source directory. Removing all the
1016         empty files from the productDir directory corrupts the svn repository.
1017
1018         * Scripts/build-webkit:
1019
1020 2011-01-03  Yi Shen  <yi.4.shen@nokia.com>
1021
1022         Reviewed by Adam Barth.
1023
1024         [Qt] Add SelectAll option to the context menu for the editor
1025         https://bugs.webkit.org/show_bug.cgi?id=50049
1026
1027         Set shortcut for the SelectAll action.
1028
1029         * QtTestBrowser/mainwindow.cpp:
1030         (MainWindow::buildUI):
1031
1032 2011-01-03  David Levin  <levin@chromium.org>
1033
1034         Reviewed by Eric Seidel.
1035
1036         check-webkit-style shouldn't consider "value" automatically to be a meaningless name.
1037         https://bugs.webkit.org/show_bug.cgi?id=51842
1038
1039         * Scripts/webkitpy/style/checkers/cpp.py: Remove the check for value.
1040         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Remove the test for value.
1041
1042 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
1043
1044         Reviewed by David Kilzer.
1045
1046         [WINCE] Adds a build slave.
1047         https://bugs.webkit.org/show_bug.cgi?id=50523
1048
1049         * BuildSlaveSupport/build.webkit.org-config/config.json: Add an
1050         entry for a release build of the WinCE port.
1051         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add platform
1052         flag to build the WinCE port.
1053
1054 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
1055
1056         Reviewed by David Kilzer.
1057
1058         Add WinCE support to build-webkit
1059         https://bugs.webkit.org/show_bug.cgi?id=51642
1060
1061         * Scripts/build-webkit:
1062         * Scripts/webkitdirs.pm:
1063
1064 2011-01-03  Eric Seidel  <eric@webkit.org>
1065
1066         Reviewed by Adam Barth.
1067
1068         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
1069         https://bugs.webkit.org/show_bug.cgi?id=51802
1070
1071         I'm not the biggest fan of the test_failures or test_results classes,
1072         but it's better to have one shared set of classes, than separate ones
1073         for new vs. old run-webkit-test result handling.
1074
1075         This moves the ORWT results class "LayoutTestResults" over to using
1076         TestResult and TestFailure classes, making it easy for us to
1077         make all our sheriff-bot and other webkitpy code NRWT ready.
1078
1079         This also makes it a trivial patch to generate results.json information
1080         from ORWT results.html files (for flaky test analysis, etc.) as well
1081         as making it a one-liner to report test failure types when the
1082         commit-queue sees flaky tests.
1083
1084         This patch tried not to add new functionality, but only to replace
1085         the guts of LayoutTestResults, while adding unit tests and hoping
1086         not to break anything.
1087
1088         I also moved callers which assumed User.prompt* were static/class methods
1089         to using them as instance methods (since we'll eventually want to make them such).
1090
1091         In the process of re-writing things, I broke the rebaseline command, so I wrote
1092         a unit test to catch my breakage were I do do so again in the future.
1093
1094         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1095         * Scripts/webkitpy/common/net/layouttestresults.py:
1096         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1097         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1098         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
1099         * Scripts/webkitpy/tool/commands/queries.py:
1100         * Scripts/webkitpy/tool/commands/rebaseline.py:
1101         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1102         * Scripts/webkitpy/tool/mocktool.py:
1103
1104 2011-01-03  Adam Barth  <abarth@webkit.org>
1105
1106         Reviewed by Simon Fraser.
1107
1108         webkit-patch shouldn't waste time cleaning a working directory that's already clean
1109         https://bugs.webkit.org/show_bug.cgi?id=51840
1110
1111         * Scripts/webkitpy/common/checkout/scm.py:
1112
1113 2011-01-03  Adam Barth  <abarth@webkit.org>
1114
1115         Reviewed by Simon Fraser.
1116
1117         webkit-patch should only hide update output if --quiet
1118         https://bugs.webkit.org/show_bug.cgi?id=51838
1119
1120         As requested by smfr.
1121
1122         * Scripts/webkitpy/tool/steps/update.py:
1123
1124 2011-01-03  Adam Barth  <abarth@webkit.org>
1125
1126         Reviewed by David Levin.
1127
1128         commit-queue shouldn't reject patches twice if two bots process the same patch
1129         https://bugs.webkit.org/show_bug.cgi?id=51805
1130
1131         Before raising an error, we first check whether the patch is still in
1132         the commit-queue.  This check is still racy, of course, but the time
1133         window is much smaller.
1134
1135         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1136
1137 2011-01-03  Sam Weinig  <sam@webkit.org>
1138
1139         Reviewed by Anders Carlsson.
1140
1141         Make run-api-tests less chatty.
1142         https://bugs.webkit.org/show_bug.cgi?id=51831
1143
1144         - Make script quiet by default and add --verbose option (replacing --quiet).
1145         - When not verbose, pipe stdout and stderr to devnull.
1146
1147         * Scripts/run-api-tests:
1148
1149 2011-01-03  Pratik Solanki  <psolanki@apple.com>
1150
1151         Unreviewed. Adding myself to committers.py.
1152
1153         * Scripts/webkitpy/common/config/committers.py:
1154
1155 2011-01-03  Koan-Sin Tan  <koansin.tan@gmail.com>
1156
1157         Reviewed by Xan Lopez.
1158
1159         "Tool/Scripts/run-launcher --gtk" stopped working after 74855
1160         https://bugs.webkit.org/show_bug.cgi?id=51806
1161
1162         Originally, the $libraryName is 'JavaScriptCore'. When building release 
1163         one, the $libraryDir was 'WebKitBuild/Release/JavaScriptCore/../.libs/'
1164         which doesn't exist anymore ('WebKitBuild/Release/JavaScriptCore'
1165         is 'WebKitBuild/Release/Source/JavaScriptCore' now), and 
1166         'WebKitBuild/Release/Source/JavaScriptCore/../../.libs' looks weird,
1167         so make it 'WebKitBuild/Release/.libs'
1168
1169         * Scripts/webkitdirs.pm: 
1170
1171 2011-01-02  Patrick Gansterer  <paroga@webkit.org>
1172
1173         Reviewed by Adam Barth.
1174
1175         Make EFL a core builder
1176         https://bugs.webkit.org/show_bug.cgi?id=51804
1177
1178         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1179         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1180
1181 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
1182
1183         [Qt] Unreviewed fix after r74855 and r74875.
1184
1185         * BuildSlaveSupport/built-product-archive:
1186          - Create directories explicitly.
1187          - Pass shell=True to subprocess.call().
1188
1189 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
1190
1191         [Qt] Unreviewed fix after r74855.
1192
1193         Move JavaScriptCore to Source
1194         https://bugs.webkit.org/show_bug.cgi?id=51604
1195
1196         * BuildSlaveSupport/built-product-archive: JavaScriptCore -> Source/JavaScriptCore
1197
1198 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
1199
1200         [Qt] Unreviewed run-javasriptcore-tests fix after r74855.
1201
1202         Move JavaScriptCore to Source
1203         https://bugs.webkit.org/show_bug.cgi?id=51604
1204
1205         * Scripts/webkitdirs.pm:
1206
1207 2011-01-02  Robert Hogan  <robert@webkit.org>
1208
1209         Unreviewed, build fix.
1210
1211         [Qt] Fix DRT build after 74855
1212
1213         * DumpRenderTree/qt/DumpRenderTree.pro:
1214
1215 2011-01-01  Adam Barth  <abarth@webkit.org>
1216
1217         Remove the assumption from the Qt and Gtk builds that every project is
1218         in the root directory.
1219
1220         * Scripts/build-webkit:
1221
1222 2011-01-01  Adam Barth  <abarth@webkit.org>
1223
1224         Reviewed by Eric Seidel.
1225
1226         Teach svn-apply how to apply patches even though JavaScriptCore has moved
1227         https://bugs.webkit.org/show_bug.cgi?id=51796
1228
1229         After this change, svn-apply will magically apply patches to
1230         JavaScriptCore/foo to Source/JavaScriptCore/foo.
1231
1232         * Scripts/VCSUtils.pm:
1233
1234 2011-01-01  Adam Barth  <abarth@webkit.org>
1235
1236         Reviewed by Eric Seidel.
1237
1238         Move JavaScriptCore to Source
1239         https://bugs.webkit.org/show_bug.cgi?id=51604
1240
1241         Update references to JavaScriptCore to point to the new location.
1242
1243         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1244         * DumpRenderTree/qt/DumpRenderTree.pro:
1245         * DumpRenderTree/qt/ImageDiff.pro:
1246         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1247         * DumpRenderTree/wscript:
1248         * Scripts/build-jsc:
1249         * Scripts/build-webkit:
1250         * Scripts/do-file-rename:
1251         * Scripts/do-webcore-rename:
1252         * Scripts/run-javascriptcore-tests:
1253         * Scripts/update-javascriptcore-test-results:
1254         * Scripts/webkitdirs.pm:
1255         * Scripts/webkitpy/common/config/build_unittest.py:
1256         * Scripts/webkitpy/style/checker.py:
1257         * Scripts/webkitpy/style/checker_unittest.py:
1258         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1259         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1260         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1261         * wx/build/settings.py:
1262
1263 2011-01-01  Adam Barth  <abarth@webkit.org>
1264
1265         Reviewed by Eric Seidel.
1266
1267         Move Sources to Source
1268         https://bugs.webkit.org/show_bug.cgi?id=51794
1269
1270         Update scripts to point to the new location.
1271
1272         * Scripts/build-webkit:
1273         * Scripts/do-file-rename:
1274         * Scripts/do-webcore-rename:
1275         * Scripts/webkitpy/common/config/build.py:
1276         * Scripts/webkitpy/common/config/build_unittest.py:
1277
1278 2010-12-31  Kent Tamura  <tkent@chromium.org>
1279
1280         Reviewed by Eric Seidel.
1281
1282         [DRT/Chromium] Enable mock spell checker on non-OSX
1283         https://bugs.webkit.org/show_bug.cgi?id=51401
1284
1285         * DumpRenderTree/chromium/WebViewHost.cpp:
1286         (WebViewHost::spellCheck):
1287
1288 2010-12-31  Adam Barth  <abarth@webkit.org>
1289
1290         Reviewed by Ariya Hidayat.
1291
1292         Remove Tools/Scripts/wkstyle
1293         https://bugs.webkit.org/show_bug.cgi?id=51774
1294
1295         This script appears to not have been touched in a while and seems to
1296         have been replaced by check-webkit-style.
1297
1298         * Scripts/wkstyle: Removed.
1299
1300 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
1301
1302         Unreviewed. Coding style fix.
1303
1304         * DumpRenderTree/chromium/TestShell.h:
1305
1306 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
1307
1308         Reviewed by Pavel Feldman.
1309
1310         Web Inspector: [Chromium] Inspector's tests are very slow on Win(Dbg).
1311
1312         It was a problem with Chromium DRT. DevToolsAgent object instance was
1313         attached not only to the inspected page but to the DevTools window too.
1314         As result all the inspector files were interpreted as a content of inspected page
1315         and were transfered to the DevTools scripts panel for debugging etc.
1316
1317         https://bugs.webkit.org/show_bug.cgi?id=51735
1318
1319         * DumpRenderTree/chromium/TestShell.cpp:
1320         (TestShell::TestShell):
1321         (TestShell::bindJSObjectsToWindow):
1322         (TestShell::createNewWindow):
1323         * DumpRenderTree/chromium/TestShell.h:
1324
1325 2010-12-31  Adam Barth  <abarth@webkit.org>
1326
1327         Rubber-stamped by Eric Seidel.
1328
1329         Move PageLoadTests to PerformanceTests/PageLoad
1330         https://bugs.webkit.org/show_bug.cgi?id=51771
1331
1332         Update references to PageLoadTests to point to the new location.
1333
1334         * Scripts/run-pageloadtest:
1335         * Scripts/webkitpy/common/config/build.py:
1336
1337 2010-12-31  Adam Barth  <abarth@webkit.org>
1338
1339         Rubber-stamped by Eric Seidel.
1340
1341         Move SunSpider into PerformanceTests
1342         https://bugs.webkit.org/show_bug.cgi?id=51769
1343
1344         Update these scripts to point to the new location.
1345
1346         * Scripts/run-sunspider:
1347         * Scripts/sunspider-compare-results:
1348
1349 2010-12-30  Mihai Parparita  <mihaip@chromium.org>
1350
1351         Reviewed by Kent Tamura.
1352
1353         [Chromium] Add WebThemeEngineDRTMac so that Chromium DRT scrollbar rendering can match the Mac port's
1354         https://bugs.webkit.org/show_bug.cgi?id=51728
1355         
1356         Add implementation of the Mac WebThemeEngine that uses an NSScroller
1357         to render top-level scrollbars. This makes them match the Mac port's
1358         use of an NSScrollView, which means that we'll be able to share more
1359         pixel baselines.
1360         
1361         The new rendering code will not be activated until the 
1362         USE_WEB_THEME_ENGINE_TO_PAINT_THUMB #define is fliped in
1363         ScrollbarThemeChromiumMac.
1364
1365         * DumpRenderTree/DumpRenderTree.gypi:
1366         * DumpRenderTree/chromium/TestShellMac.mm:
1367         (platformInit):
1368         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Added.
1369         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Added.
1370         (+[FakeActiveWindow alwaysActiveWindow]):
1371         (+[FakeActiveWindow alwaysInactiveWindow]):
1372         (-[FakeActiveWindow initWithActiveControls:]):
1373         (-[FakeActiveWindow _hasActiveControls]):
1374         (WebThemeEngineDRTMac::paintScrollbarThumb):
1375         (stateToHIEnableState):
1376         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
1377         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
1378
1379 2010-12-30  Konstantin Tokarev  <annulen@yandex.ru>
1380
1381         Reviewed by David Kilzer.
1382
1383         [Qt] Don't build wtf/TCSystemAlloc.cpp if --system-malloc option is
1384         used
1385         https://bugs.webkit.org/show_bug.cgi?id=51672
1386
1387         * DumpRenderTree/qt/DumpRenderTree.pro: Replaced USE_SYSTEM_MALLOC
1388         with USE_SYSTEM_MALLOC=1
1389         * WebKitTestRunner/qt/WebKitTestRunner.pro: Replaced USE_SYSTEM_MALLOC
1390         with USE_SYSTEM_MALLOC=1
1391
1392 2010-12-30  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1393
1394         Reviewed by David Kilzer.
1395
1396         [Qt] [Symbian] Fix build-webkit script for Symbian
1397         https://bugs.webkit.org/show_bug.cgi?id=51509
1398
1399         Set the OUTPUT_DIR for Symbian to be the same as the source
1400         directory.
1401
1402         * Scripts/webkitdirs.pm:
1403
1404 2010-12-30  Martin Robinson  <mrobinson@igalia.com>
1405
1406         Reviewed by Darin Adler.
1407
1408         check-webkit-style should ignore NULL usage in calls to gtk_widget_style_get
1409         https://bugs.webkit.org/show_bug.cgi?id=51758
1410
1411         Add a check-webkit-style exception for gtk_widget_style_get and NULL usage.
1412
1413         * Scripts/webkitpy/style/checkers/cpp.py: Add the exception.
1414         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Add some tests for this.
1415
1416 2010-12-29  Patrick Gansterer  <paroga@webkit.org>
1417
1418         Unreviewed WinCE buildfix.
1419
1420         * WinCELauncher/main.cpp: Add missing include.
1421
1422 2010-12-29  Daniel Bates  <dbates@rim.com>
1423
1424         Reviewed by Darin Adler.
1425
1426         svn-apply updates date of wrong change log entry for a change log diff that
1427         contains two consecutive entries with the same author and date
1428         https://bugs.webkit.org/show_bug.cgi?id=46061
1429
1430         Fixes an issue where the date of the wrong change log entry may be modified.
1431         Moreover, changes fixChangeLogPatch() to move entries inserted earlier
1432         in a ChangeLog file to the top of the file.
1433
1434         Currently, fixChangeLogPatch() explicitly bails out and returns an unchanged
1435         diff when it detects that the diff inserts a change log entry earlier in a
1436         ChangeLog. It is unusual to land a patch that has such a deliberate ChangeLog
1437         change. With the advent of the commit-queue this functionality of bailing out
1438         and hence landing the patch as-is is harmful to the accuracy of the ChangeLog.
1439         Instead, we should always move the change log entry to the top of the ChangeLog file.
1440
1441         A side-effect of this change is that setChangeLogDateAndReviewer() now updates
1442         the date line of the correct change log entry in a ChangeLog diff.
1443
1444         * Scripts/VCSUtils.pm: Modified fixChangeLogPatch() to move entries inserted earlier to the top.
1445
1446         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
1447           Updated the following unit tests now that we move entries inserted earlier to the top:
1448           - "fixChangeLogPatch: New entry inserted in middle."
1449             (formerly named "fixChangeLogPatch: [no change] New entry inserted in middle.")
1450
1451           - "fixChangeLogPatch: New entry inserted earlier in the file, but after an entry with the same author and date."
1452             (formerly named "fixChangeLogPatch: [no change] New entry inserted earlier in the file, but after an entry with the same author and date.")
1453
1454         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatchThenSetChangeLogDateAndReviewer.pl: Added.
1455
1456 2010-12-29  Konstantin Tokarev  <annulen@yandex.ru>
1457
1458         Reviewed by Eric Seidel.
1459
1460         [Qt] Fixed compatibility with gold linker on X11 platforms
1461         https://bugs.webkit.org/show_bug.cgi?id=51700
1462
1463         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1464         Linked TestNetscapePlugin with libX11 on Unix platforms
1465
1466 2010-12-29  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>
1467
1468         Reviewed by Darin Adler.
1469
1470         Circular dependency in webkitpy.common.checkout.changelog module
1471         https://bugs.webkit.org/show_bug.cgi?id=50475
1472
1473         Remove automatic import of api.Checkout module when any checkout/
1474         submodule is imported (e.g.: when checkout.scm.Git is imported).
1475
1476         * Scripts/webkitpy/common/checkout/__init__.py:
1477
1478 2010-12-29  Martin Robinson  <mrobinson@igalia.com>
1479
1480         Reviewed by Ojan Vafai.
1481
1482         prepare-ChangeLog should support the -g option for specifying the git-commit
1483         https://bugs.webkit.org/show_bug.cgi?id=51708
1484
1485         Add a -g shortcut for the --git-commit prepare-ChangeLog option. This matches
1486         webkit-patch, though the exact meaning of the two options remain different.
1487
1488         * Scripts/prepare-ChangeLog: Add -g.
1489
1490 2010-12-29  Kent Hansen  <kent.hansen@nokia.com>
1491
1492         Reviewed by Simon Hausmann.
1493
1494         [Qt] Fix compilation with Qt in namespace
1495         https://bugs.webkit.org/show_bug.cgi?id=51701
1496
1497         * QtTestBrowser/webview.h:
1498
1499 2010-12-28  Daniel Bates  <dbates@rim.com>
1500
1501         Reviewed by Sam Weinig.
1502
1503         Substitute // MARK: for compiler-specific #pragma mark
1504         https://bugs.webkit.org/show_bug.cgi?id=51657
1505
1506         Fix future compilation warnings about "#pragma mark" on GTK+ bots by
1507         substituting  "// MARK:" for "#pragma mark", which provides
1508         analogous code-bookmarking functionality under Xcode.
1509
1510         Also, for consistency, we should substitute "// MARK:" for compiler-
1511         specific "#pragma mark" in the source files for the Mac port.
1512
1513         * DumpRenderTree/AccessibilityTextMarker.cpp:
1514         * DumpRenderTree/cf/WebArchiveDumpSupport.h:
1515         * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm:
1516         * DumpRenderTree/mac/ObjCController.m:
1517         * MiniBrowser/mac/AppDelegate.m:
1518         * MiniBrowser/mac/BrowserWindowController.m:
1519
1520 2010-12-28  Xan Lopez  <xlopez@igalia.com>
1521
1522         Reviewed by Eric Seidel.
1523
1524         Add --no-build option to run-sunspider
1525         https://bugs.webkit.org/show_bug.cgi?id=51658
1526
1527         * Scripts/run-sunspider: add --no-build flag to skip building
1528         phase.
1529
1530 2010-12-27  Daniel Bates  <dbates@rim.com>
1531
1532         Rubber-stamped by Martin Robinson.
1533
1534         Append the directory Tools/DumpRenderTree to the list of directories that
1535         do-webcore-rename should search so that it can rename DRT files and
1536         source code.
1537
1538         * Scripts/do-webcore-rename:
1539
1540 2010-12-27  Eric Seidel  <eric@webkit.org>
1541
1542         Reviewed by Adam Barth.
1543
1544         build-webkit should detect missing Java SDK and explain how to install it
1545         https://bugs.webkit.org/show_bug.cgi?id=51651
1546
1547         * Scripts/build-webkit:
1548
1549 2010-12-26  Martin Robinson  <mrobinson@igalia.com>
1550
1551         Reviewed by Daniel Bates.
1552
1553         [GTK] Add support for build-jsc
1554         https://bugs.webkit.org/show_bug.cgi?id=51625
1555
1556         Add GTK+ support to build-jsc now that building the jsc executable as
1557         a standalone target is easy.
1558
1559         * Scripts/build-jsc: Call buildGtkProject for the GTK+ case now.
1560         * Scripts/build-webkit: Pass in the proper target name to buildGtkProject.
1561         * Scripts/webkitdirs.pm: Actually process the project parameter in buildGtkProject
1562         and pass it along to buildAutotoolsProject.
1563
1564 2010-12-27  David Levin  <levin@chromium.org>
1565
1566         Reviewed by Eric Seidel.
1567
1568         check-webkit-style check for meaningless variable names in function declarations.
1569         https://bugs.webkit.org/show_bug.cgi?id=51523
1570
1571         * Scripts/webkitpy/style/checker.py: Exempted JavaScriptCore/jit/JITStubs.cpp
1572         from the new check and whitespace/parens because the syntax is unusual and
1573         produced a fair number of positives for these checks.
1574         * Scripts/webkitpy/style/checkers/cpp.py:
1575         (_convert_to_lower_with_underscores): Used as a canonical form for type names
1576         and parameter names when determining if the parameter name is useless.
1577         (_create_acronym): Used to check for redundant variable names in cases like "ExceptionCode ec"
1578         (Parameter.lower_with_underscores_name): Gives back the parameter name in a lower_with_underscore
1579         format.
1580         (_check_parameter_name_against_text):  Checks to see if the parameter name is in the
1581         text or an acronym of it.
1582         (check_function_definition): Checks function definitions for meaningless variable names.
1583         (process_line): Added call to check_function_definition.
1584         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1585         (CppFunctionsTest.test_convert_to_lower_with_underscores): Test for _convert_to_lower_with_underscores.
1586         (CppFunctionsTest.test_create_acronym): Test for _create_acronym.
1587         (CppFunctionsTest.test_check_parameter_against_text): Test for _check_parameter_against_text.
1588         (CppStyleTestBase.perform_single_line_lint): Removed the parameter name check
1589         because when only checking a snippet, there are a lot of bogus functions.
1590         (CppStyleTestBase.perform_multi_line_lint): Ditto and removed a bogus filter
1591         that I put there previously and just noticed.
1592         (WebKitStyleTest.test_parameter_names): Tests for the functionality -- both
1593         check_function_definition and process_line.
1594
1595 2010-12-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1596
1597         Reviewed by Martin Robinson.
1598
1599         [GTK] Disable flash plugin in GtkLauncher when using gtk3
1600         https://bugs.webkit.org/show_bug.cgi?id=51591
1601
1602         Flash plugin uses gtk2 that is incompatible with gtk3 making
1603         webkit crash when it's built with gtk3.
1604
1605         * GtkLauncher/main.c:
1606         (main):
1607
1608 2010-12-25  Adam Barth  <abarth@webkit.org>
1609
1610         Reviewed by Eric Seidel.
1611
1612         Move ANGLE to Sources/ThirdParty
1613         https://bugs.webkit.org/show_bug.cgi?id=51605
1614
1615         * Scripts/build-webkit:
1616           - Point to the new ANGLE location.
1617
1618 2010-12-26  David Levin  <levin@chromium.org>
1619
1620         Reviewed by Eric Seidel.
1621
1622         check-webkit-style should be able to parse function declaration parameters.
1623         https://bugs.webkit.org/show_bug.cgi?id=51451
1624
1625         * Scripts/webkitpy/style/checkers/cpp.py:
1626         (Position.__init__): Holds simple position information (row, column).
1627         (Parameter.__init__): Holds information about a parameter.
1628         (SingleLineView.__init): Converts multiple lines into a single line for simpler searches.
1629         (SingleLineView.convert_column_to_row): Returns the original row given a column.
1630         (create_skeleton_parameters): Simplifies a parameter list for easier searching.
1631         (find_parameter_name_index): Finds where the parameter name is.
1632         (parameter_list): Generates the list of parameters for a function.
1633         (_FunctionState.begin): Added information to allow determining the parameters
1634         on demand.
1635         (_FunctionState.get_parameter_list): Returns a tuple of function parameters.
1636         (detect_functions): Improve function detection for operator functions and
1637         determine where the parameters end and pass that to _FunctionState.begin.
1638         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1639         (CppFunctionsTest.test_parameter): Verifies Parameter functionality.
1640         (CppFunctionsTest.test_single_line_view): Verifies SingleLineView functionality.
1641         (CppFunctionsTest.test_create_skeleton_parameters): Verifies create_skeleton_parameters.
1642         (CppFunctionsTest.test_find_parameter_name_index): Verifies find_parameter_name_index.
1643         (CppFunctionsTest.test_parameter_list): Does some minimal verification for parameter list.
1644         Much more thorough verification is done as part of FunctionDetectionTest.test_parameter_list.
1645         (FunctionDetectionTest.perform_function_detection): Added support for verifying
1646         the parameters found.
1647         (FunctionDetectionTest.test_function_declaration_detection): Added more function
1648         detection test to verify that we catch the operator functions.
1649         (FunctionDetectionTest.test_ignore_macros): Verify that function detection ignores macros.
1650         (FunctionDetectionTest.test_parameter_list): Added tests to verify the parameter parsing.
1651         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_bad_test_doesnt_break): Removed
1652         because the error. The test is about the bad function name. Fixing the name makes the test exactly like
1653         test_function_length_check_definition_severity1_for_test.
1654
1655 2010-12-25  Patrick Gansterer  <paroga@webkit.org>
1656
1657         Unreviewed WinCE buildfix after r74334.
1658
1659         * CMakeListsWinCE.txt:
1660
1661 2010-12-24  Sheriff Bot  <webkit.review.bot@gmail.com>
1662
1663         Unreviewed, rolling out r74632.
1664         http://trac.webkit.org/changeset/74632
1665         https://bugs.webkit.org/show_bug.cgi?id=51600
1666
1667         makes test-webkitpy hang forever on GTK (Requested by philn-tp
1668         on #webkit).
1669
1670         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
1671         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
1672
1673 2010-12-24  Ryuan Choi  <ryuan.choi@samsung.com>
1674
1675         Reviewed by Kenneth Rohde Christiansen.
1676
1677         [EFL] Screen doesn't be rendered when changing size of EWebLauncher
1678         https://bugs.webkit.org/show_bug.cgi?id=43528
1679
1680         Remove on_resize because ewk_view_fixed_layout_size_set should not be
1681         called on callback of EVAS_CALLBACK_RESIZE. As it change size of
1682         FrameView, rendering was ignored when _ewk_view_smart_calculate was
1683         called.
1684
1685         * EWebLauncher/main.c:
1686         (browserCreate):
1687
1688 2010-12-24  Eric Seidel  <eric@webkit.org>
1689
1690         Reviewed by Adam Barth.
1691
1692         webkit-patch (or a pre-commit hook) needs to prevent bad ChangeLog changes
1693         https://bugs.webkit.org/show_bug.cgi?id=28291
1694
1695         This is a start.  At least now webkit-patch will prompt when your ChangeLog looks questionable.
1696         We could do more advanced things, like parsing the ChangeLog (with changelog.py) and comparing that
1697         to strings with find in the diff.
1698         Since non-interactive always returns the default, this should cause patches with bad changelogs to fail on the commit-queue.
1699
1700         * Scripts/webkitpy/common/checkout/api.py:
1701         * Scripts/webkitpy/common/checkout/diff_parser.py:
1702         * Scripts/webkitpy/tool/steps/abstractstep.py:
1703         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
1704         * Scripts/webkitpy/tool/steps/validatechangelogs.py: Copied from Tools/Scripts/webkitpy/tool/steps/validatereviewer.py.
1705         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py: Copied from Tools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.
1706         * Scripts/webkitpy/tool/steps/validatereviewer.py:
1707
1708 2010-12-24  Dirk Pranke  <dpranke@chromium.org>
1709
1710         Reviewed by Kenneth Russell.
1711
1712         Modify new-run-webkit-tests to shut up and exit when all the threads
1713         are wedged so that test runs complete faster and we don't end up
1714         w/ enormous log files.
1715
1716         https://bugs.webkit.org/show_bug.cgi?id=51572
1717
1718         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
1719         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
1720
1721 2010-12-24  Eric Seidel  <eric@webkit.org>
1722
1723         Reviewed by David Levin.
1724
1725         commit-queue should better explain how it will re-open bugs and follow duplicate chains
1726         https://bugs.webkit.org/show_bug.cgi?id=51549
1727
1728         I've had multiple people ask me about the commit-queue's behavior
1729         regarding reporting flaky tests.  I figured it would be best to just
1730         have the queue explain itself in the bugs it files.
1731
1732         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1733         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1734
1735 2010-12-24  Shinichiro Hamaji  <hamaji@chromium.org>
1736
1737         Reviewed by Eric Seidel.
1738
1739         check-webkit-style: should ignore "wrong" namings in JavaScriptCore/qt
1740         https://bugs.webkit.org/show_bug.cgi?id=51467
1741
1742         * Scripts/webkitpy/style/checker.py:
1743         * Scripts/webkitpy/style/checker_unittest.py:
1744
1745 2010-12-23  Adam Barth  <abarth@webkit.org>
1746
1747         Rubber-stamped by Eric Seidel.
1748
1749         Move JavaScriptGlue into Sources
1750         https://bugs.webkit.org/show_bug.cgi?id=51583
1751
1752         These tools refer to JavaScriptGlue and need to be updated to its new
1753         location.
1754
1755         * Scripts/build-webkit:
1756         * Scripts/do-file-rename:
1757         * Scripts/do-webcore-rename:
1758         * Scripts/webkitpy/common/config/build.py:
1759         * Scripts/webkitpy/common/config/build_unittest.py:
1760
1761 2010-12-23  Lucas Forschler  <lforschler@apple.com>
1762
1763         Reviewed by Eric Seidel.
1764
1765         Bug 51539 - update iexploder scripts to point to new location
1766
1767         * Scripts/run-iexploder-tests:
1768         * Scripts/update-iexploder-cssproperties:
1769
1770 2010-12-23  Evan Martin  <evan@chromium.org>
1771
1772         Reviewed by Ryosuke Niwa.
1773
1774         [chromium] LayoutTestController warning in float->int conversion
1775         https://bugs.webkit.org/show_bug.cgi?id=51553
1776
1777         Rather than reading an int, converting to a float, then getting a compiler
1778         warning on passing the float to something that expects an int, instead
1779         just pass around ints.
1780
1781         No tests, fixes a compiler warning.
1782
1783         * DumpRenderTree/chromium/LayoutTestController.cpp:
1784         (parsePageSizeParameters):
1785         (LayoutTestController::pageNumberForElementById):
1786         (LayoutTestController::numberOfPages):
1787
1788 2010-12-23  Lucas Forschler  <lforschler@apple.com>
1789
1790         Reviewed by Darin Adler.
1791
1792         Bug 51537 - iexploder needs cleanup
1793         
1794         * iExploder/htdocs: Removed.
1795         * iExploder/htdocs/config.rb: Removed.
1796         * iExploder/htdocs/cssproperties.in: Removed.
1797         * iExploder/htdocs/cssvalues.in: Removed.
1798         * iExploder/htdocs/htmlattrs.in: Removed.
1799         * iExploder/htdocs/htmltags.in: Removed.
1800         * iExploder/htdocs/htmlvalues.in: Removed.
1801         * iExploder/htdocs/iexploder.cgi: Removed.
1802         * iExploder/htdocs/iexploder.rb: Removed.
1803         * iExploder/htdocs/index.html: Removed.
1804         * iExploder/htdocs/webserver.rb: Removed.
1805         * iExploder/iexploder-1.7.2/output: Removed.
1806         * iExploder/tools: Removed.
1807         * iExploder/tools/lasthit.rb: Removed.
1808         * iExploder/tools/osx_last_crash.rb: Removed.
1809         * iExploder/tools/showtest.rb: Removed.
1810
1811 2010-12-23  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
1812
1813         Reviewed by Kenneth Rohde Christiansen.
1814
1815         [EFL] Make 'single' the default backing store in EWebLauncher
1816         https://bugs.webkit.org/show_bug.cgi?id=51534
1817
1818         'single' is the simplest backing store and the one intended to be the
1819         default in the test browser. By mistake the tiled backing store was
1820         left as default in r72617.
1821
1822         * EWebLauncher/main.c:
1823         (browserCreate): ditto.
1824
1825 2010-12-23  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
1826
1827         Reviewed by Kenneth Rohde Christiansen.
1828
1829         [EFL] Subject: [webkit 4/4] [EFL] Remove non-sense workaround
1830         https://bugs.webkit.org/show_bug.cgi?id=51533
1831
1832         There's no point in concatenating env("HOME") with "blah", so remove
1833         option from EWebLauncher.
1834
1835         * EWebLauncher/main.c:
1836         (main): ditto.
1837
1838 2010-12-23  Ilya Tikhonovsky  <loislo@chromium.org>
1839
1840         Reviewed by Eric Seidel.
1841
1842         Web Inspector: chromium: inspector's tests are quite slow especially at windows(Debug).
1843
1844         Almost all inspector's tests become flaky on chromium Win(dbg) after switching to DRT.
1845         I just discovered that we have two additional GC runs per each WebViewHost.
1846         Test_shell had no such calls.
1847         These gc runs eat 15% of cpu time.
1848
1849         https://bugs.webkit.org/show_bug.cgi?id=51479
1850
1851         * DumpRenderTree/chromium/WebViewHost.cpp:
1852         (WebViewHost::~WebViewHost):
1853
1854 2010-12-22  Dirk Pranke  <dpranke@chromium.org>
1855
1856         Reviewed by Ojan Vafai.
1857
1858         This change splits out the TestRunner class into its own file.
1859         When we fork the code for message passing, we will create a new
1860         TestRunner, and this change will allow that to be more modular.
1861
1862         While we're at it, split out TestInput and ResultSummary into
1863         their own files, to reduce the size of run_webkit_tests to
1864         something more managable.
1865
1866         https://bugs.webkit.org/show_bug.cgi?id=51092
1867
1868         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1869         * Scripts/webkitpy/layout_tests/layout_package/result_summary.py:
1870         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1871         * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
1872         * Scripts/webkitpy/layout_tests/layout_package/test_input.py:
1873         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1874         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1875
1876  2010-12-22  Dirk Pranke  <dpranke@chromium.org>
1877
1878         Reviewed by Ojan Vafai.
1879
1880         nrwt multiprocessing - start over, prepare to fork the code
1881  
1882         This code cleans up the signatures and implementation of the
1883         TestRunner class so we can easily fork it to run either the
1884         stable implementation or the new, unstable message-passing
1885         implementation. The two variants will have different
1886         implementations of the run_tests() method. We will switch
1887         between the two based on the setting for the '--worker-model'
1888         switch. We rename the two currently valid values to 'old-inline'
1889         and 'old-threads'.
1890
1891         https://bugs.webkit.org/show_bug.cgi?id=51081
1892
1893         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1894         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1895
1896 2010-12-22  Victor Wang  <victorw@chromium.org>
1897
1898         Reviewed by Darin Fisher.
1899
1900         [Chromium] Update chromium archive test result url in rebaseline script.
1901
1902         https://bugs.webkit.org/show_bug.cgi?id=51503
1903
1904         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1905
1906 2010-12-22  Lucas Forschler  <lforschler@apple.com>
1907
1908         Reviewed by Alice Liu.
1909
1910         <rdar://problem/8633222> record-memory-win needs to record memory used by the webprocess.
1911         Verified on Chrome, Safari, and IE.
1912         With this change, we will record memory from a parent browser window and all child processes.
1913
1914         * record-memory-win/main.cpp:
1915         (ProcessArgs):
1916         (PrintUsage):
1917         (getMemoryInfo):
1918         (printProcessInfo):
1919         (evalProcesses):
1920         (UseImage):
1921         (QueryContinuously):
1922         (ElapsedTime):
1923
1924 2010-12-22  Lucas Forschler  <lforschler@apple.com>
1925
1926         Unreviewed rollout r74489, because it was missing changelog.
1927
1928         * record-memory-win/main.cpp:
1929         
1930 2010-12-22  Ryosuke Niwa  <rniwa@webkit.org>
1931
1932         Adding myself as a reviewer.
1933
1934         * Scripts/webkitpy/common/config/committers.py:
1935
1936 2010-12-22  Andrew Scherkus  <scherkus@chromium.org>
1937
1938         Unreviewed.  Adding myself to committers.py.
1939
1940         * Scripts/webkitpy/common/config/committers.py:
1941
1942 2010-12-22  Ariya Hidayat  <ariya@sencha.com>
1943
1944         Reviewed by Kenneth Rohde Christiansen.
1945
1946         TestNetscapePlugIn should use #if defined
1947         https://bugs.webkit.org/show_bug.cgi?id=51471
1948
1949         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1950         (NP_Initialize):
1951         (NPP_New):
1952
1953 2010-12-22  Ilya Tikhonovsky  <loislo@chromium.org>
1954
1955         Reviewed by Yury Semikhatsky.
1956
1957         Web Inspector: [chromium] DRT inspector layout tests are flaky in debug.
1958
1959         DevTools window should be closed explicitly because it has custom deinitialization code.
1960
1961         https://bugs.webkit.org/show_bug.cgi?id=50722
1962
1963         * DumpRenderTree/chromium/TestShell.cpp:
1964         (TestShell::closeRemainingWindows):
1965
1966 2010-12-22  David Levin  <levin@chromium.org>
1967
1968         Reviewed by Shinichiro Hamaji.
1969
1970         check-webkit-style shouldn't complaint about underscores in variables in objective C files.
1971         https://bugs.webkit.org/show_bug.cgi?id=51452
1972
1973         * Scripts/webkitpy/style/checkers/cpp.py:
1974         (_FileState.__init__): Added the information to determine if a file is C or Objective C.
1975         Using the file extension if possible but falling back to the file contents if we have a header file.
1976         (_FileState.is_objective_c): Determine if we have an Objective C by examining the file contents if needed.
1977         (_FileState.is_c_or_objective_c):
1978         (check_using_std): Changed to using _FileState to determine the file type.
1979         (check_max_min_macros): Ditto.
1980         (check_for_null): Ditto.
1981         (check_style): Changed the parameters to various calls since they now need _FileState
1982         to determine the file type.
1983         (check_language): Added the file_state parameter so it could be passed
1984         to check_identifier_name_in_declaration.
1985         (check_identifier_name_in_declaration): Don't warn about underscores in variables if
1986         this is an Objective C file.
1987         (_process_lines): Added information for the _FileState constructor (and moved the
1988         call to a place that had the information).
1989         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1990         (CppFunctionsTest.test_is_c_or_objective_c): Changed the tests to use FileState and exercise
1991         its functionality.
1992         (WebKitStyleTest.test_names): Add tests for underscores in Objective C files.
1993
1994 2010-12-21  Andy Estes  <aestes@apple.com>
1995
1996         Reviewed by Mark Rowe.
1997
1998         Do not build non-Intel architectures for WebKit2-related projects.
1999         https://bugs.webkit.org/show_bug.cgi?id=51440
2000
2001         * MiniBrowser/Configurations/Base.xcconfig: Only build for i386 and x86_64.
2002         * TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
2003         * WebKitTestRunner/Configurations/Base.xcconfig: Ditto.
2004
2005 2010-12-21  Mihai Parparita  <mihaip@chromium.org>
2006
2007         Reviewed by Darin Fisher.
2008
2009         [Chromium] Rename WebThemeEngine/ControlDRT to WebThemeEngine/ControlDRTWin
2010         https://bugs.webkit.org/show_bug.cgi?id=51406 
2011         
2012         Rename WebThemeControlDRT to WebThemeControlDRTWin and WebThemeEngineDRT
2013         to WebThemeEngineDRTWin and update references everywhere.
2014
2015         * DumpRenderTree/DumpRenderTree.gypi:
2016         * DumpRenderTree/chromium/TestShellWin.cpp:
2017         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRT.cpp.
2018         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRT.h.
2019         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRT.cpp.
2020         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRT.h.
2021
2022 2010-12-21  Anders Carlsson  <andersca@apple.com>
2023
2024         Reviewed by John Sullivan.
2025
2026         Clicking missing plug-in text does not show a sheet
2027         https://bugs.webkit.org/show_bug.cgi?id=51403
2028
2029         Update for changes to the WebPageUIClient.
2030
2031         * MiniBrowser/mac/BrowserWindowController.m:
2032         (-[BrowserWindowController awakeFromNib]):
2033         * WebKitTestRunner/TestController.cpp:
2034         (WTR::createOtherPage):
2035         (WTR::TestController::initialize):
2036
2037 2010-12-21  Eric Seidel  <eric@webkit.org>
2038
2039         Reviewed by Adam Barth.
2040
2041         commit-queue will report constant failures as flaky if other tests flake
2042         https://bugs.webkit.org/show_bug.cgi?id=51272
2043
2044         This patch just removes functionality and adds testing.
2045         Previously we attempted to report flaky tests when we had
2046         two different tests fail in a row.  However, since we stop
2047         running the tests at the first failure, our code was wrong in
2048         trying to determine flakiness from the incomplete runs.
2049
2050         Originally I posted an alternate patch:
2051         https://bug-51272-attachments.webkit.org/attachment.cgi?id=77078
2052         which fixed our flaky logic in this case, however it was decided
2053         that that patch would be too difficult to maintain, so now
2054         I'm just removing the broken logic.
2055
2056         This will dramatically cut-down on our flaky-test false positives
2057         at the (small) cost of the queues being unable to report
2058         any flakiness if the tree is very flaky.  (With at least one test
2059         flaking on every run, we'll never report failures anymore.)  I think
2060         this is a tradeoff worth making.
2061
2062         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2063         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2064
2065 2010-12-20  Eric Seidel  <eric@webkit.org>
2066
2067         Reviewed by Adam Barth.
2068
2069         commit-queue wrongly rejects patches when it can't update itself
2070         https://bugs.webkit.org/show_bug.cgi?id=46636
2071
2072         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2073         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2074         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2075
2076 2010-12-20  Adam Barth  <abarth@webkit.org>
2077
2078         Move web sites to Websites directory
2079         https://bugs.webkit.org/show_bug.cgi?id=51323
2080
2081         Update references to BugsSite to point to the new location.
2082
2083         This patch was never officially reviewed (because it was too large to
2084         upload to bugs.webkit.org), but it was discussed on webkit-dev and Mark
2085         Rowe gave me the green light.
2086
2087         * Scripts/old-run-webkit-tests:
2088         * Scripts/webkitpy/common/config/build.py:
2089         * Scripts/webkitpy/common/config/build_unittest.py:
2090         * Scripts/webkitpy/common/prettypatch.py:
2091         * Scripts/webkitpy/layout_tests/port/base.py:
2092         * Scripts/webkitpy/style/main.py:
2093
2094 2010-12-20  Adrienne Walker  <enne@google.com>
2095
2096         Unreviewed. Adding myself to the list of committers.
2097
2098         * webkitpy/common/config/committers.py:
2099
2100 2010-12-20  Mark Rowe  <mrowe@apple.com>
2101
2102         Reviewed by Dan Bernstein.
2103
2104         <rdar://problem/8757601> Don't install header files in to the Resources directory.
2105
2106         * Scripts/check-for-inappropriate-files-in-framework: Don't allow .h files in the
2107         Resources directory.
2108
2109 2010-12-20  Eric Seidel  <eric@webkit.org>
2110
2111         Reviewed by Adam Barth.
2112
2113         commit-queue should include bot id when attaching failure diffs
2114         https://bugs.webkit.org/show_bug.cgi?id=51280
2115
2116         This is a tiny change to include the bot id in the name of the attachment.
2117         Most of this diff is just changing the unit test expectations
2118         now that I hid the comment printing when the comment is None.
2119
2120         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2121         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2122         * Scripts/webkitpy/tool/commands/upload_unittest.py:
2123         * Scripts/webkitpy/tool/mocktool.py:
2124
2125 2010-12-20  Jeff Miller  <jeffm@apple.com>
2126
2127         Reviewed by Dan Bernstein.
2128
2129         Tools/vcbin/midl.exe needs to be rebuilt
2130         https://bugs.webkit.org/show_bug.cgi?id=51347
2131
2132         * vcbin/midl.exe: Rebuilt.
2133
2134 2010-12-20  David Levin  <levin@chromium.org>
2135
2136         Reviewed by Ariya Hidayat.
2137
2138         .gitignore and webkit-tools-completion.sh have references to WebKitTools that should be Tools.
2139         https://bugs.webkit.org/show_bug.cgi?id=51343
2140
2141         Follow up from the WebKitTools -> Tools rename.
2142
2143         * Scripts/webkit-tools-completion.sh:
2144
2145 2010-12-20  Cosmin Truta  <ctruta@chromium.org>
2146
2147         Reviewed by James Robinson.
2148
2149         new-run-webkit-tests ignores trailing EOL differences in text tests
2150         https://bugs.webkit.org/show_bug.cgi?id=36983
2151
2152         Changed the handling of new-line characters within new-run-webkit-tests
2153         to match old-run-webkit-tests.  Differences in leading and trailing empty
2154         lines in text expectation files are no longer ignored.
2155
2156         * Scripts/webkitpy/layout_tests/port/base.py:
2157         * Scripts/webkitpy/layout_tests/port/test.py:
2158         Added unit tests.  Removed old duplicate unit test entries.
2159         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
2160
2161 2010-12-20  David Levin  <levin@chromium.org>
2162
2163         Reviewed by Shinichiro Hamaji.
2164
2165         check-webkit-style should detect function declarations (and trivial functions).
2166         https://bugs.webkit.org/show_bug.cgi?id=51303
2167
2168         * Scripts/webkitpy/style/checkers/cpp.py:
2169         (_FunctionState.begin): Add is_declaration and changed the line count
2170         start to begin at -1 (which will keep the results consistent, since
2171         the starting line number passed in is one less in this change).
2172         (detect_functions): changed function detection to now catch trivial
2173         functions and declarations.
2174         (check_pass_ptr_usage): Don't check for Pass*Ptr on the first line
2175         of the function as this may look at return values (when processing
2176         a declaration).
2177         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2178         (FunctionDetectionTest.perform_function_detection): Basic mechanics
2179         of testing the function detection.
2180         (FunctionDetectionTest.test_basic_function_detection): Test a simple
2181         function.
2182         (FunctionDetectionTest.test_function_declaration_detection): Test a
2183         declaration.
2184         (FunctionDetectionTest.test_non_functions): A test case for a case
2185         that caused the code to fail due to the { being in quotes.
2186         (PassPtrTest.test_pass_ref_ptr_return_value): Added some more test
2187         cases to help catch false alarms for return values.
2188         (PassPtrTest.test_pass_ref_ptr_member_variable): Ensure that
2189         we don't get false alarms for member variables either.
2190
2191 2010-12-20  Ryuan Choi  <ryuan.choi@samsung.com>
2192
2193         Reviewed by Antonio Gomes.
2194
2195         [CMAKE] Rename WEBKITTOOLS_DIR to TOOLS_DIR
2196         https://bugs.webkit.org/show_bug.cgi?id=51319
2197
2198         * CMakeListsEfl.txt:
2199
2200 2010-12-18  Adam Barth  <abarth@webkit.org>
2201
2202         Reviewed by Sam Weinig.
2203
2204         Move WebKitExamplePlugins to Examples
2205         https://bugs.webkit.org/show_bug.cgi?id=51291
2206
2207         * Scripts/webkitpy/common/config/build.py:
2208
2209 2010-12-17  Csaba Osztrogonác  <ossy@webkit.org>
2210
2211         Unreviewed Qt buildfix after r74301.
2212
2213         Rename WebKitTools to Tools
2214         https://bugs.webkit.org/show_bug.cgi?id=49861
2215
2216         * MiniBrowser/DerivedSources.pro:
2217         * MiniBrowser/qt/MiniBrowser.pro:
2218
2219 2010-12-17  Dan Bernstein  <mitz@apple.com>
2220
2221         Reviewed by Simon Fraser.
2222
2223         Rename WebKitTools to Tools
2224         https://bugs.webkit.org/show_bug.cgi?id=49861
2225
2226         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2227         * CodeCoverage/README:
2228         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2229         (WebCore::DumpRenderTree::initializeFonts):
2230         * EWSTools/start-commit-queue.sh:
2231         * EWSTools/start-queue.sh:
2232         * GNUmakefile.am:
2233         * MIDLWrapper/MIDLWrapper.cpp:
2234         (wmain):
2235         * MiniBrowser/qt/MiniBrowser.pro:
2236         * Scripts/build-api-tests:
2237         * Scripts/build-dumprendertree:
2238         * Scripts/build-webkit:
2239         * Scripts/build-webkittestrunner:
2240         * Scripts/generate-coverage-data:
2241         * Scripts/old-run-webkit-tests:
2242         * Scripts/run-api-tests:
2243         * Scripts/run-iexploder-tests:
2244         * Scripts/run-javascriptcore-tests:
2245         * Scripts/run-mangleme-tests:
2246         * Scripts/run-sunspider:
2247         * Scripts/run-webkit-websocketserver:
2248         * Scripts/sunspider-compare-results:
2249         * Scripts/test-webkitperl:
2250         * Scripts/test-webkitpy:
2251         * Scripts/update-iexploder-cssproperties:
2252         * Scripts/update-webkit:
2253         * Scripts/update-webkit-localizable-strings:
2254         * Scripts/webkitdirs.pm:
2255         * Scripts/webkitpy/common/checkout/scm.py:
2256         * Scripts/webkitpy/common/checkout/scm_unittest.py:
2257         * Scripts/webkitpy/common/config/committervalidator.py:
2258         * Scripts/webkitpy/common/config/committervalidator_unittest.py:
2259         * Scripts/webkitpy/common/config/ports.py:
2260         * Scripts/webkitpy/common/config/ports_unittest.py:
2261         * Scripts/webkitpy/common/system/logutils_unittest.py:
2262         * Scripts/webkitpy/common/system/ospath_unittest.py:
2263         * Scripts/webkitpy/layout_tests/port/chromium.py:
2264         * Scripts/webkitpy/layout_tests/port/config.py:
2265         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
2266         * Scripts/webkitpy/layout_tests/port/http_server.py:
2267         * Scripts/webkitpy/layout_tests/port/test.py:
2268         * Scripts/webkitpy/style/checker.py:
2269         * Scripts/webkitpy/style/checker_unittest.py:
2270         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
2271         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2272         * Scripts/webkitpy/tool/steps/steps_unittest.py:
2273         * WebKitTestRunner/DerivedSources.pro:
2274         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
2275         (WTR::activateFonts):
2276         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2277         * wx/build/build_utils.py:
2278
2279 2010-12-16  Antonio Gomes  <agomes@rim.com>
2280
2281         Reviewed by Martin Robinson.
2282
2283         Settings::editingBehaviorType() incorrectly returns mac for the gtk build when running tests
2284         https://bugs.webkit.org/show_bug.cgi?id=51163
2285
2286         Since GTK+'s default editing behavior was changed to UNIX in r70975 (see webkitwebsettings.cpp),
2287         GTK+'s DRT should also reset to UNIX after each test execution.
2288
2289         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2290         (resetDefaultsToConsistentValues):
2291
2292 2010-12-17  David Levin  <levin@chromium.org>
2293
2294         Reviewed by Eric Seidel.
2295
2296         check-webkit-style should understand WTF #include guards
2297         https://bugs.webkit.org/show_bug.cgi?id=44911
2298
2299         * Scripts/webkitpy/style/checkers/cpp.py:
2300         (get_header_guard_cpp_variable): modify to suggest the WTF style
2301         of header guard when appropriate.
2302         (check_for_header_guard): handle multiple return values from
2303         get_header_guard_cpp_variable
2304         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2305         (CppStyleTest.test_build_header_guard): Added tests for the WTF
2306         header style.
2307
2308 2010-12-16  David Levin  <levin@chromium.org>
2309
2310         Reviewed by Eric Seidel.
2311
2312         test-webkitpy: unittest for the xml.py checker displays a decprecation warning.
2313         https://bugs.webkit.org/show_bug.cgi?id=51210
2314
2315         The error only shows up when using python 2.6 or later.
2316
2317         * Scripts/webkitpy/style/checkers/xml.py: Replace the usage of
2318         the decprecated field error,message with something equivalent.
2319
2320 2010-12-16  Mihai Parparita  <mihaip@chromium.org>
2321
2322         Reviewed by Eric Seidel.
2323
2324         Add --exit-after-n-failures/crashes to NRWT
2325         https://bugs.webkit.org/show_bug.cgi?id=51160
2326         
2327         Abort test run (in a similar way to how control-C is handled) when
2328         --exit-after-n-failures/crashes-or-timeouts are passed and we've reached
2329         that number of unexpected failures/crashes/timeouts.
2330
2331         * Scripts/webkitpy/layout_tests/port/test.py:
2332         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2333         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2334
2335 2010-12-16  David Levin  <levin@chromium.org>
2336
2337         Reviewed by Shinichiro Hamaji.
2338
2339         check-webkit-style unit tests has some duplicate boilerplate code.
2340         https://bugs.webkit.org/show_bug.cgi?id=49519
2341
2342         * Scripts/webkitpy/style/checkers/cpp.py:
2343         (update_include_state): Replaced the "io" parameter with the global
2344         configuration _unit_test_config. This allowed not calling into
2345         functions at a low level and also not plumbing through the injection
2346         information through many levels of code.
2347         (check_for_include_what_you_use): Ditto.
2348         (process_file_data): Added the ability to set up the unit test config
2349         to allow for injection.
2350         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2351         (ErrorCollector.__init__): Added support for having a filter for errors.
2352         (ErrorCollector.__call__): Ditto.
2353         (CppStyleTestBase.process_file_data): Added the ability to set unit_test_config.
2354         (CppStyleTestBase.perform_lint): Consolidated logic for the perform functions.
2355         (CppStyleTestBase.perform_single_line_lint): Replace specific calls to
2356         functions in the cpp.py with generic processing and a filter that
2357         indicates what errors should be kept.
2358         (CppStyleTestBase.perform_multi_line_lint): Ditto.
2359         (CppStyleTestBase.perform_language_rules_check): Ditto.
2360         (CppStyleTestBase.perform_function_lengths_check): Ditto.
2361         (CppStyleTestBase.perform_pass_ptr_check): Ditto.
2362         (CppStyleTestBase.perform_include_what_you_use): Ditto.
2363         (CppStyleTest.test_multi_line_comments): Added another
2364         error message which applies to the test case.
2365         (CppStyleTest.test_spacing_for_binary_ops): Fixed test
2366         to not have config.h, since it is processed as a header file.
2367         (CppStyleTest.test_static_or_global_stlstrings): Fixed variable name
2368         style and indentation in checked code.
2369         (OrderOfIncludesTest.test_check_preprocessor_in_include_section):
2370         Fixed line number.
2371         (NoNonVirtualDestructorsTest.test_multi_line_declaration_with_error):
2372         Ditto.
2373
2374 2010-12-15  Sheriff Bot  <webkit.review.bot@gmail.com>
2375
2376         Unreviewed, rolling out r74136.
2377         http://trac.webkit.org/changeset/74136
2378         https://bugs.webkit.org/show_bug.cgi?id=51135
2379
2380         r74136 breaks chromium canary bots because some tests are not
2381         rebaselined correctly to resolve EOL differences (Requested by
2382         jianli on #webkit).
2383
2384         * Scripts/webkitpy/layout_tests/port/base.py:
2385         * Scripts/webkitpy/layout_tests/port/test.py:
2386         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
2387
2388 2010-12-15  Adam Roben  <aroben@apple.com>
2389
2390         Teach check-webkit-style to check .vcproj and .vsprops files for XML
2391         syntax errors
2392
2393         Fixes <http://webkit.org/b/51103> check-webkit-style should check for
2394         XML syntax errors in .vcproj/.vsprops files
2395
2396         Reviewed by Dave Levin.
2397
2398         * Scripts/webkitpy/style/checker.py: Added lists of file extensions
2399         that should be treated as XML and that should be allowed to contain
2400         carriage returns. (These lists happen to be identical currently.)
2401         (FileType): Added a new XML type.
2402         (CheckerDispatcher.should_check_and_strip_carriage_returns): Added.
2403         Just does a simple file extension check.
2404         (CheckerDispatcher._file_type): Added a case for XML files.
2405         (CheckerDispatcher._create_checker): Ditto. We use XMLChecker for XML
2406         files (surprise!).
2407         (StyleProcessor.process): Ask the dispatcher whether we should pass the
2408         lines through the carriage checker.
2409
2410         * Scripts/webkitpy/style/checker_unittest.py:
2411         (CheckerDispatcherCarriageReturnTest.test_should_check_and_strip_carriage_returns):
2412         Added. Checks a few file names to see if carriage returns are allowed
2413         or not.
2414         (CheckerDispatcherDispatchTest.assert_checker_xml): Added. Similar to
2415         other assert_checker_* functions.
2416         (CheckerDispatcherDispatchTest.test_xml_paths): Added. Similar to other
2417         test_*_paths functions.
2418         (CheckerDispatcherDispatchTest.test_xml_paths): Added. Similar to other
2419         test_*_paths functions.
2420         (CheckerDispatcherDispatchTest.test_none_paths): Removed the vcproj
2421         file from this test case, as vcproj files now have a type.
2422         (StyleProcessor_CodeCoverageTest.MockDispatcher.should_check_and_strip_carriage_returns):
2423         Added. Similar to the other should_* functions.
2424         (StyleProcessor_CodeCoverageTest.test_process__carriage_returns_not_stripped):
2425         Added. Checks that carriage returns aren't checked for or stripped for
2426         allowed files.
2427
2428         * Scripts/webkitpy/style/checkers/xml.py: Added.
2429         (XMLChecker.__init__): Simple init method.
2430         (XMLChecker.check): Pass each line through the expat parser, and record
2431         a style error for any errors thrown by the parser.
2432
2433         * Scripts/webkitpy/style/checkers/xml_unittest.py: Added.
2434         (XMLCheckerTest.assert_no_error): Checks that the given XML does not
2435         produce a style error.
2436         (XMLCheckerTest.assert_error): Checks that the given XML produces an
2437         error of the given category on the given line.
2438         (XMLCheckerTest.mock_handle_style_error): Does nothing. Used for
2439         checking that the XMLChecker constructor works properly.
2440         (XMLCheckerTest.test_conflict_marker): Tests that conflict markers
2441         cause a style error (see, e.g., r73887).
2442         (XMLCheckerTest.test_extra_closing_tag): Tests that extra closing tags
2443         cause a style error (see, e.g., r73773).
2444         (XMLCheckerTest.test_init): Tests that the XMLChecker constructor works
2445         properly.
2446         (XMLCheckerTest.test_missing_closing_tag): Tests that missing closing
2447         tags cause a style error (see, e.g., r72795).
2448         (XMLCheckerTest.test_no_error): Tests that valid XML does not cause a
2449         style error.
2450
2451 2010-12-15  Lucas Forschler  <lforschler@apple.com>
2452
2453         Reviewed by Stephanie Lewis.
2454
2455         https://bugs.webkit.org/show_bug.cgi?id=51117
2456         Add a new leopard test bot
2457         really really commit to trunk this time.
2458
2459         * BuildSlaveSupport/build.webkit.org-config/config.json:
2460
2461 2010-12-15  Sam Weinig  <sam@webkit.org>
2462
2463         Reviewed by Anders Carlsson.
2464
2465         WebKit2: Can't add files to an <input type=file>
2466         https://bugs.webkit.org/show_bug.cgi?id=51087
2467
2468         * MiniBrowser/mac/BrowserWindowController.m:
2469         (runOpenPanel):
2470         (-[BrowserWindowController awakeFromNib]):
2471         Add simple implementation of runOpenPanel callback.
2472
2473         * MiniBrowser/win/BrowserView.cpp:
2474         (BrowserView::create):
2475         * WebKitTestRunner/TestController.cpp:
2476         (WTR::createOtherPage):
2477         (WTR::TestController::initialize):
2478         Stub out runOpenPanel callback. 
2479
2480 2010-12-14  Eric Seidel  <eric@webkit.org>
2481
2482         Reviewed by Adam Barth.
2483
2484         commit-queue should upload failure diffs when tests flake
2485         https://bugs.webkit.org/show_bug.cgi?id=51051
2486
2487         To make this testable I needed to pipe FileSystem down onto tool.
2488         We've wanted it there for a long time anyway.
2489
2490         This patch is kinda a big hack.  But we don't have a nice
2491         way to read results.html files.  I think this will need further
2492         revision before this code actually feels clean.
2493
2494         As part of testing this change, I had to make MockBugzilla.create_bug
2495         actually return an id (like it should) which required updating
2496         a few other unit test results (for the better).
2497
2498         The results_matching_keys change in layouttestresults/rebasline
2499         was an alternate path which I decided not to use in the end, but
2500         I left the change as it seemed an improvement.
2501
2502         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2503         * Scripts/webkitpy/common/net/layouttestresults.py:
2504         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2505         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2506         * Scripts/webkitpy/tool/commands/queues.py:
2507         * Scripts/webkitpy/tool/commands/rebaseline.py:
2508         * Scripts/webkitpy/tool/main.py:
2509         * Scripts/webkitpy/tool/mocktool.py:
2510
2511 2010-12-15  Cosmin Truta  <ctruta@chromium.org>
2512
2513         Reviewed by James Robinson.
2514
2515         new-run-webkit-tests ignores trailing EOL differences in text tests
2516         https://bugs.webkit.org/show_bug.cgi?id=36983
2517
2518         Changed the handling of new-line characters within new-run-webkit-tests
2519         to match old-run-webkit-tests.  Differences in leading and trailing empty
2520         lines in text expectation files are no longer ignored.
2521
2522         * Scripts/webkitpy/layout_tests/port/base.py:
2523         * Scripts/webkitpy/layout_tests/port/test.py:
2524         Added unit tests.  Removed old duplicate unit test entries.
2525         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
2526
2527 2010-12-15  Ojan Vafai  <ojan@chromium.org>
2528
2529         Reviewed by Adam Barth.
2530
2531         make status-bubble white-space:nowrap so we can measure it's width without wrapping
2532         https://bugs.webkit.org/show_bug.cgi?id=51149
2533
2534         * QueueStatusServer/templates/statusbubble.html:
2535
2536 2010-12-15  Ojan Vafai  <ojan@chromium.org>
2537
2538         Reviewed by Adam Barth.
2539
2540         have the statusbubble postMessage it's metrics so that embedders can properly size the iframe
2541         https://bugs.webkit.org/show_bug.cgi?id=51125
2542
2543         * QueueStatusServer/templates/statusbubble.html:
2544
2545 2010-12-15  Darin Adler  <darin@apple.com>
2546
2547         * Scripts/webkitpy/common/net/buildbot: Added property svn:ignore.
2548
2549 2010-12-15  Sheriff Bot  <webkit.review.bot@gmail.com>
2550
2551         Unreviewed, rolling out r74117.
2552         http://trac.webkit.org/changeset/74117
2553         https://bugs.webkit.org/show_bug.cgi?id=51113
2554
2555         This broke the GTK1 build. (Requested by mrobinson on
2556         #webkit).
2557
2558         * Scripts/webkitdirs.pm:
2559
2560 2010-12-15  Amruth Raj  <amruthraj@motorola.com> and Ravi Kasibhatla  <ravi.kasibhatla@motorola.com>
2561
2562         Reviewed by Martin Robinson.
2563
2564         Change generate-forwarding-headers.pl for GTK port usage 
2565         (https://bugs.webkit.org/show_bug.cgi?id=37369)
2566
2567         * Scripts/webkitdirs.pm: Added changes to build webkit2 for GTK port using build-webkit script.
2568
2569 2010-12-14  Kent Tamura  <tkent@chromium.org>
2570
2571         Reviewed by Jian Li.
2572
2573         [DRT/Chromium] Remove another unnecessary error message
2574         https://bugs.webkit.org/show_bug.cgi?id=51083
2575
2576         * DumpRenderTree/chromium/WebViewHost.cpp:
2577         (WebViewHost::didInvalidateRect):
2578
2579 2010-12-14  Lucas Forschler  <lforschler@apple.com>
2580
2581         Reviewed by Stephanie Lewis.
2582
2583         Add a new Leopard Debug Test WK2 Bot
2584
2585         * BuildSlaveSupport/build.webkit.org-config/config.json:
2586
2587 2010-12-14  Ojan Vafai  <ojan@chromium.org>
2588
2589         Fix python unittests after http://trac.webkit.org/changeset/74070.
2590
2591         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
2592
2593 2010-12-14  Kent Tamura  <tkent@chromium.org>
2594
2595         Reviewed by Jian Li.
2596
2597         [DRT/Chromium] Remove a unnecessary error message
2598         https://bugs.webkit.org/show_bug.cgi?id=51069
2599
2600         * DumpRenderTree/chromium/WebViewHost.cpp:
2601         (WebViewHost::paintInvalidatedRegion):
2602
2603 2010-12-14  Benjamin Kalman  <kalman@chromium.org>
2604
2605         Reviewed by Ojan Vafai.
2606
2607         Using BUG/BUGWK in test_expectations is error prone, should use BUGCR/BUGWK
2608         https://bugs.webkit.org/show_bug.cgi?id=48926
2609
2610         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2611         Add presubmit check that BUG isn't used, either BUGCR/BUGWK/BUGV8_.
2612
2613 2010-12-14  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2614
2615         Reviewed by Eric Seidel.
2616
2617         [Qt] [Symbian] Do not use pkg-config on Symbian as it is not supported
2618         https://bugs.webkit.org/show_bug.cgi?id=50231
2619
2620         Guard CONFIG+=link_pkgconfig with !symbian.
2621
2622         * DumpRenderTree/qt/DumpRenderTree.pro:
2623         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2624         * WebKitTestRunner/qt/WebKitTestRunner.pro:
2625
2626 2010-12-14  Philippe Normand  <pnormand@igalia.com>
2627
2628         Reviewed by Ojan Vafai.
2629
2630         [new-run-webkit-tests] expectations parsing is slow
2631         https://bugs.webkit.org/show_bug.cgi?id=50635
2632
2633         Avoid expensive iteration of all the tests when checking if a test
2634         file is to be skipped or not.
2635
2636         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2637         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
2638         * Scripts/webkitpy/layout_tests/port/test.py:
2639
2640 2010-12-14  Mario Sanchez Prada  <msanchez@igalia.com>
2641
2642         Reviewed by Xan Lopez.
2643
2644         [Gtk] Implement STATE_FOCUSED, STATE_FOCUSABLE, and corresponding events for text objects
2645         https://bugs.webkit.org/show_bug.cgi?id=27048
2646
2647         Add support in DRT for checking whether an accessibility UI
2648         element is focusable and/or focused. Implemented for GTK.
2649
2650         * DumpRenderTree/AccessibilityUIElement.cpp:
2651         (getIsFocusedCallback): New.
2652         (getIsFocusableCallback): New.
2653         (AccessibilityUIElement::getJSClass): Add the new available
2654         callbacks for isFocused and isFocusable.
2655         * DumpRenderTree/AccessibilityUIElement.h:
2656         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2657         (AccessibilityUIElement::isFocused): New, implemented by checking
2658         whether the related AtkState value is in the object's state set.
2659         (AccessibilityUIElement::isFocusable): Ditto.
2660         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2661         (AccessibilityUIElement::isFocused): New, dummy implementation.
2662         (AccessibilityUIElement::isFocusable): Ditto.
2663         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2664         (AccessibilityUIElement::isFocused): Ditto.
2665         (AccessibilityUIElement::isFocusable): Ditto.
2666
2667 2010-12-14  Eric Seidel  <eric@webkit.org>
2668
2669         Reviewed by Ojan Vafai.
2670
2671         webkit-patch should warn users when they're using a 32-bit git on a 64-bit system
2672         https://bugs.webkit.org/show_bug.cgi?id=50715
2673
2674         This patch makes webkit-patch print the following:
2675
2676         Warning: This machine is 64-bit, but the git binary (/usr/local/git/bin/git) does not support 64-bit.
2677         Install a 64-bit git for better performance, see:
2678         https://lists.webkit.org/pipermail/webkit-dev/2010-December/015249.html
2679
2680         I wrote this mostly because I have approximately 8 machines that I use
2681         and making sure each one is using a good Git install seemed folly.
2682         webkit-patch makes a lot of git calls, so using a fast git can shave
2683         several seconds in every invocation.  See the webkit-dev thread for more info.
2684
2685         This message will print twice during 'webkit-patch upload',
2686         once from webkit-patch and once from check-webkit-style.
2687
2688         Unfortunately there is no good way to test this due to how machine-dependent
2689         the code is.  I considered writing a test for the log message, but it seemed not worth it.
2690
2691         * Scripts/webkitpy/common/checkout/scm.py:
2692
2693 2010-12-13  Eric Seidel  <eric@webkit.org>
2694
2695         Reviewed by Adam Barth.
2696
2697         FlakyTestReporter doesn't understand bots running from multiple email addresses
2698         https://bugs.webkit.org/show_bug.cgi?id=50960
2699
2700         This explains at least one of the dupes of:
2701         https://bugs.webkit.org/show_bug.cgi?id=50863
2702         that we saw filed by the commit-queue this morning.
2703         I think the other one was explained by my previous fix to result counting code.
2704
2705         Since this is really hard to test with a unit test, instead I
2706         create a new (possibly useful in the future) command
2707         which given a layout test path will return you
2708         the one bug which our tools would assume it the flaky test bug.
2709         If some other script wants to use bug-for-test we'll
2710         need to extend it with some options like --create-if-missing or similar.
2711
2712         * Scripts/webkitpy/common/net/bugzilla/bug.py:
2713         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2714         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2715         * Scripts/webkitpy/tool/commands/__init__.py:
2716         * Scripts/webkitpy/tool/commands/bugfortest.py: Added.
2717
2718 2010-12-13  Mihai Parparita  <mihaip@chromium.org>
2719
2720         Reviewed by James Robinson.
2721
2722         Add option to build-webkit to not build WebKit2
2723         https://bugs.webkit.org/show_bug.cgi?id=50988
2724         
2725         Add support for a --no-webkit2 option to build-webkit. It seems to save
2726         ~1 minute from clean builds and ~10 seconds from no-op builds.
2727
2728         * Scripts/build-webkit:
2729
2730 2010-12-13  Lucas Forschler  <lforschler@apple.com>
2731
2732         Reviewed by Dave Kilzer.
2733
2734         Update iexploder from 1.3.2 to 1.7.2
2735         Move 1.3.2 into its own subdir
2736         Add 1.7.2 into its own subdir
2737         update scripts to point to new 1.3.2 location (avoid breaking existing scripts)
2738
2739         * Scripts/run-iexploder-tests:
2740         * Scripts/update-iexploder-cssproperties:
2741         * iExploder/CHANGELOG.txt: Removed.
2742         * iExploder/LICENSE.txt: Removed.
2743         * iExploder/README.txt: Removed.
2744         * iExploder/htdocs: Removed.
2745         * iExploder/iexploder-1.3.2: Added.
2746         * iExploder/iexploder-1.3.2/CHANGELOG.txt: Copied from iExploder/CHANGELOG.txt.
2747         * iExploder/iexploder-1.3.2/LICENSE.txt: Copied from iExploder/LICENSE.txt.
2748         * iExploder/iexploder-1.3.2/README.txt: Copied from iExploder/README.txt.
2749         * iExploder/iexploder-1.3.2/htdocs: Added.
2750         * iExploder/iexploder-1.3.2/htdocs/config.rb: Copied from iExploder/htdocs/config.rb.
2751         * iExploder/iexploder-1.3.2/htdocs/cssproperties.in: Copied from iExploder/htdocs/cssproperties.in.
2752         * iExploder/iexploder-1.3.2/htdocs/cssvalues.in: Copied from iExploder/htdocs/cssvalues.in.
2753         * iExploder/iexploder-1.3.2/htdocs/htmlattrs.in: Copied from iExploder/htdocs/htmlattrs.in.
2754         * iExploder/iexploder-1.3.2/htdocs/htmltags.in: Copied from iExploder/htdocs/htmltags.in.
2755         * iExploder/iexploder-1.3.2/htdocs/htmlvalues.in: Copied from iExploder/htdocs/htmlvalues.in.
2756         * iExploder/iexploder-1.3.2/htdocs/iexploder.cgi: Copied from iExploder/htdocs/iexploder.cgi.
2757         * iExploder/iexploder-1.3.2/htdocs/iexploder.rb: Copied from iExploder/htdocs/iexploder.rb.
2758         * iExploder/iexploder-1.3.2/htdocs/index.html: Copied from iExploder/htdocs/index.html.
2759         * iExploder/iexploder-1.3.2/htdocs/webserver.rb: Copied from iExploder/htdocs/webserver.rb.
2760         * iExploder/iexploder-1.3.2/tools: Added.
2761         * iExploder/iexploder-1.3.2/tools/lasthit.rb: Copied from iExploder/tools/lasthit.rb.
2762         * iExploder/iexploder-1.3.2/tools/osx_last_crash.rb: Copied from iExploder/tools/osx_last_crash.rb.
2763         * iExploder/iexploder-1.3.2/tools/showtest.rb: Copied from iExploder/tools/showtest.rb.
2764         * iExploder/iexploder-1.7.2: Added.
2765         * iExploder/iexploder-1.7.2/ChangeLog.txt: Added.
2766         * iExploder/iexploder-1.7.2/LICENSE.txt: Added.
2767         * iExploder/iexploder-1.7.2/README.txt: Added.
2768         * iExploder/iexploder-1.7.2/output: Added.
2769         * iExploder/iexploder-1.7.2/src: Added.
2770         * iExploder/iexploder-1.7.2/src/browser_harness.rb: Added.
2771         * iExploder/iexploder-1.7.2/src/config.yaml: Added.
2772         * iExploder/iexploder-1.7.2/src/css-atrules: Added.
2773         * iExploder/iexploder-1.7.2/src/css-atrules/mozilla: Added.
2774         * iExploder/iexploder-1.7.2/src/css-atrules/webkit: Added.
2775         * iExploder/iexploder-1.7.2/src/css-properties: Added.
2776         * iExploder/iexploder-1.7.2/src/css-properties/dillo: Added.
2777         * iExploder/iexploder-1.7.2/src/css-properties/gtkhtml: Added.
2778         * iExploder/iexploder-1.7.2/src/css-properties/internet_explorer6: Added.
2779         * iExploder/iexploder-1.7.2/src/css-properties/mozilla: Added.
2780         * iExploder/iexploder-1.7.2/src/css-properties/webkit: Added.
2781         * iExploder/iexploder-1.7.2/src/css-pseudo: Added.
2782         * iExploder/iexploder-1.7.2/src/css-pseudo/mozilla: Added.
2783         * iExploder/iexploder-1.7.2/src/css-pseudo/webkit: Added.
2784         * iExploder/iexploder-1.7.2/src/css-values: Added.
2785         * iExploder/iexploder-1.7.2/src/css-values/dillo: Added.
2786         * iExploder/iexploder-1.7.2/src/css-values/gtkhtml: Added.
2787         * iExploder/iexploder-1.7.2/src/css-values/mozilla: Added.
2788         * iExploder/iexploder-1.7.2/src/css-values/other: Added.
2789         * iExploder/iexploder-1.7.2/src/css-values/webkit: Added.
2790         * iExploder/iexploder-1.7.2/src/headers: Added.
2791         * iExploder/iexploder-1.7.2/src/headers/dillo: Added.
2792         * iExploder/iexploder-1.7.2/src/headers/gtkhtml: Added.
2793         * iExploder/iexploder-1.7.2/src/headers/mozilla: Added.
2794         * iExploder/iexploder-1.7.2/src/headers/webkit: Added.
2795         * iExploder/iexploder-1.7.2/src/html-attrs: Added.
2796         * iExploder/iexploder-1.7.2/src/html-attrs/dillo: Added.
2797         * iExploder/iexploder-1.7.2/src/html-attrs/gtkhtml: Added.
2798         * iExploder/iexploder-1.7.2/src/html-attrs/internet_explorer6: Added.
2799         * iExploder/iexploder-1.7.2/src/html-attrs/mozilla: Added.
2800         * iExploder/iexploder-1.7.2/src/html-attrs/other: Added.
2801         * iExploder/iexploder-1.7.2/src/html-attrs/webkit: Added.
2802         * iExploder/iexploder-1.7.2/src/html-tags: Added.
2803         * iExploder/iexploder-1.7.2/src/html-tags/dillo: Added.
2804         * iExploder/iexploder-1.7.2/src/html-tags/gtkhtml: Added.
2805         * iExploder/iexploder-1.7.2/src/html-tags/mozilla: Added.
2806         * iExploder/iexploder-1.7.2/src/html-tags/other: Added.
2807         * iExploder/iexploder-1.7.2/src/html-tags/webkit: Added.
2808         * iExploder/iexploder-1.7.2/src/html-values: Added.
2809         * iExploder/iexploder-1.7.2/src/html-values/dillo: Added.
2810         * iExploder/iexploder-1.7.2/src/html-values/gtkhtml: Added.
2811         * iExploder/iexploder-1.7.2/src/html-values/mozilla: Added.
2812         * iExploder/iexploder-1.7.2/src/html-values/other: Added.
2813         * iExploder/iexploder-1.7.2/src/html-values/webkit: Added.
2814         * iExploder/iexploder-1.7.2/src/iexploder.cgi: Added.
2815         * iExploder/iexploder-1.7.2/src/iexploder.rb: Added.
2816         * iExploder/iexploder-1.7.2/src/index.html: Added.
2817         * iExploder/iexploder-1.7.2/src/media: Added.
2818         * iExploder/iexploder-1.7.2/src/media/blank.ogg: Added.
2819         * iExploder/iexploder-1.7.2/src/media/blank.snd: Added.
2820         * iExploder/iexploder-1.7.2/src/media/blank.wav: Added.
2821         * iExploder/iexploder-1.7.2/src/media/bug.bmp: Added.
2822         * iExploder/iexploder-1.7.2/src/media/bug.gif: Added.
2823         * iExploder/iexploder-1.7.2/src/media/bug.ico: Added.
2824         * iExploder/iexploder-1.7.2/src/media/bug.jng: Added.
2825         * iExploder/iexploder-1.7.2/src/media/bug.jpg: Added.
2826         * iExploder/iexploder-1.7.2/src/media/bug.png: Added.
2827         * iExploder/iexploder-1.7.2/src/media/bug.svg: Added.
2828         * iExploder/iexploder-1.7.2/src/media/bug.tiff: Added.
2829         * iExploder/iexploder-1.7.2/src/media/bug.xbm: Added.
2830         * iExploder/iexploder-1.7.2/src/media/bug.xpm: Added.
2831         * iExploder/iexploder-1.7.2/src/mime-types: Added.
2832         * iExploder/iexploder-1.7.2/src/mime-types/dillo: Added.
2833         * iExploder/iexploder-1.7.2/src/mime-types/mozilla: Added.
2834         * iExploder/iexploder-1.7.2/src/mime-types/webkit: Added.
2835         * iExploder/iexploder-1.7.2/src/protocols: Added.
2836         * iExploder/iexploder-1.7.2/src/protocols/dillo: Added.
2837         * iExploder/iexploder-1.7.2/src/protocols/gtkhtml: Added.
2838         * iExploder/iexploder-1.7.2/src/protocols/mozilla: Added.
2839         * iExploder/iexploder-1.7.2/src/protocols/webkit: Added.
2840         * iExploder/iexploder-1.7.2/src/scanner.rb: Added.
2841         * iExploder/iexploder-1.7.2/src/version.rb: Added.
2842         * iExploder/iexploder-1.7.2/src/webserver.rb: Added.
2843         * iExploder/iexploder-1.7.2/testcases: Added.
2844         * iExploder/iexploder-1.7.2/testcases/testcase-Linux_x86_64_rv2.0b6pre_Gecko-20100904_Firefox-4.0b6pre-TEST-8375-1_59.html: Added.
2845         * iExploder/iexploder-1.7.2/testcases/testcase-Opera-9.80_Linux_x86_64_en_Presto-2.6.30_Version-10.61-16704-3_108,3.html: Added.
2846         * iExploder/iexploder-1.7.2/testcases/testcase-U_Intel_Mac_OS_X_10_6_4_en-US_AppleWebKit-534.8_Chrome-7.0.529.0-TEST-611-3_36,9.html: Added.
2847         * iExploder/iexploder-1.7.2/testcases/testcase-U_Intel_Mac_OS_X_10_6_4_en-US_AppleWebKit-534.8_hrome-7.0.529.0-TEST-55313622206-3_6,0.html: Added.
2848         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.6_Chrome-7.0.503.1-TEST-120813-8_72,56,24,8,0.html: Added.
2849         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.6_Chrome-7.0.503.1-TEST-121240-3_81,3.html: Added.
2850         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.7_Chrome-7.0.513.0-4800-5_80,65,15.html: Added.
2851         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.7_Chrome-7.0.513.0-TEST-23583190347-3_15,12.html: Added.
2852         * iExploder/iexploder-1.7.2/tools: Added.
2853         * iExploder/iexploder-1.7.2/tools/lasthit.rb: Added.
2854         * iExploder/iexploder-1.7.2/tools/osx_last_crash.rb: Added.
2855         * iExploder/iexploder-1.7.2/tools/release_src.sh: Added.
2856         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh: Added.
2857         * iExploder/tools: Removed.
2858
2859 2010-12-13  Sam Weinig  <sam@webkit.org>
2860
2861         Reviewed by Anders Carlsson.
2862
2863         Remove associated page concept from WKView constructor
2864         https://bugs.webkit.org/show_bug.cgi?id=50983
2865
2866         Step 1: Remove associate page constructors from WKView and make
2867         all views use the shared namespace for the context.
2868
2869         * TestWebKitAPI/PlatformWebView.h:
2870         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
2871         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
2872         * WebKitTestRunner/PlatformWebView.h:
2873         * WebKitTestRunner/TestController.cpp:
2874         (WTR::createOtherPage):
2875         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2876         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2877         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2878
2879 2010-12-13  Sam Weinig  <sam@webkit.org>
2880
2881         Reviewed by Anders Carlsson.
2882
2883         Change the WebKit2 public API so there is no explicit WKPageNamespace object
2884         https://bugs.webkit.org/show_bug.cgi?id=50898
2885
2886         * MiniBrowser/mac/AppDelegate.h:
2887         * MiniBrowser/mac/AppDelegate.m:
2888         * MiniBrowser/mac/BrowserWindowController.h:
2889         * MiniBrowser/mac/BrowserWindowController.m:
2890         * MiniBrowser/win/BrowserView.cpp:
2891         Convert MiniBrowser to not use PageNamespaces.
2892
2893         * TestWebKitAPI/PlatformWebView.h:
2894         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
2895         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
2896         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
2897         * TestWebKitAPI/Tests/WebKit2/Find.cpp:
2898         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
2899         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
2900         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
2901         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
2902         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
2903         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
2904         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
2905         * TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp:
2906         * TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp:
2907         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
2908         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
2909         Convert TestWebKitAPI to not use PageNamespaces.
2910
2911         * WebKitTestRunner/PlatformWebView.h:
2912         * WebKitTestRunner/TestController.cpp:
2913         * WebKitTestRunner/TestController.h:
2914         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2915         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2916         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2917         Convert WebKitTestRunner to not use PageNamespaces.
2918
2919 2010-12-13  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
2920
2921         Reviewed by Eric Seidel.
2922
2923         webkit-patch rollout should be able to do multi-revision rollouts
2924         https://bugs.webkit.org/show_bug.cgi?id=33336
2925
2926         Make it possible to pass more than one revision to webkit-patch.
2927
2928         * Scripts/webkitpy/common/checkout/api.py:
2929         * Scripts/webkitpy/common/checkout/changelog.py:
2930         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2931         * Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:
2932         * Scripts/webkitpy/tool/commands/download.py:
2933         * Scripts/webkitpy/tool/commands/download_unittest.py:
2934         * Scripts/webkitpy/tool/mocktool.py:
2935         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
2936         * Scripts/webkitpy/tool/steps/revertrevision.py:
2937
2938 2010-12-13  Eric Seidel  <eric@webkit.org>
2939
2940         Unreviewed.
2941
2942         Teach webkit-patch how to search bugzilla
2943         https://bugs.webkit.org/show_bug.cgi?id=50500
2944
2945         webkit-patch bug-search fails when there is only one result.
2946         Turns out we needed a bit more logic in our result count parsing code.
2947
2948         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2949         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
2950
2951 2010-12-13  Antti Koivisto  <antti@apple.com>
2952
2953         Reviewed by Alexey Proskuryakov.
2954
2955         Add setSerializeHTTPLoads function to allow testing resource load order on OS X.
2956         https://bugs.webkit.org/show_bug.cgi?id=50758
2957
2958         * DumpRenderTree/LayoutTestController.cpp:
2959         (setSerializeHTTPLoadsCallback):
2960         (LayoutTestController::staticFunctions):
2961         * DumpRenderTree/LayoutTestController.h:
2962         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2963         (LayoutTestController::setSerializeHTTPLoads):
2964         * DumpRenderTree/mac/DumpRenderTree.mm:
2965         (resetDefaultsToConsistentValues):
2966         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2967         (LayoutTestController::setSerializeHTTPLoads):
2968         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2969         (LayoutTestController::setSerializeHTTPLoads):
2970
2971 2010-12-13  Dimitri Glazkov  <dglazkov@chromium.org>
2972
2973         Reviewed by Ojan Vafai.
2974
2975         Remove "use-drt" option from test step command line, since the option was removed in r73748.
2976         https://bugs.webkit.org/show_bug.cgi?id=50936
2977
2978         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Removed the option.
2979
2980 2010-12-13  Patrick Gansterer  <paroga@webkit.org>
2981
2982         Reviewed by Csaba Osztrogonác.
2983
2984         Add revlink to BuildBot status
2985         https://bugs.webkit.org/show_bug.cgi?id=50914
2986
2987         This adds a hyperlink to trac changeset on the revision numbers. 
2988
2989         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2990
2991 2010-12-13  Andras Becsi  <abecsi@webkit.org>
2992
2993         Reviewed by Csaba Osztrogonác.
2994
2995         [Qt][WK2] Fix build if WebKitTools are not available
2996         https://bugs.webkit.org/show_bug.cgi?id=50242
2997
2998         * MiniBrowser/qt/MiniBrowser.pro: Correct the comment.
2999         * Scripts/webkitdirs.pm: Added WebKitTools/MiniBrowser to $subdirs.
3000         * MiniBrowser/DerivedSources.pro: Added.
3001
3002 2010-12-13  Eric Seidel  <eric@webkit.org>
3003
3004         Reviewed by Adam Barth.
3005
3006         EWS Queues should remove orpahned pyc files before starting
3007         https://bugs.webkit.org/show_bug.cgi?id=50904
3008
3009         A previous check added a platform.py which caused
3010         EWS bots on some platforms to hit an import exception.
3011         The platform.py file was removed in a subsequent commit, but
3012         the EWS bots in question stayed stuck.  This change will
3013         fix those bots once restarted (and prevent this in the future).
3014
3015         I also went ahead and unified start-queue and start-commit-queue
3016         since they were nearly identical.  I also added bot_id support
3017         to both force all EWSes to have bot ids as well as get rid of the one
3018         remaining reason why I had my own copies of these scripts.
3019         Hopefully this will be enough to get all the other bot admins
3020         (ahem, Adam, ahem) to move to using these checked in copies as well.
3021
3022         * EWSTools/start-commit-queue.sh: Removed.
3023         * EWSTools/start-queue.sh:
3024
3025 2010-10-28  MORITA Hajime  <morrita@google.com>
3026
3027         Reviewed by Ojan Vafai.
3028
3029         spellcheck does not check pasted text
3030         https://bugs.webkit.org/show_bug.cgi?id=40092
3031
3032         Added LayoutTestController::setAsynchronousSpellCheckingEnabled()
3033         to control the setting.
3034
3035         * DumpRenderTree/LayoutTestController.cpp:
3036         (setAsynchronousSpellCheckingEnabledCallback):
3037         (LayoutTestController::staticFunctions):
3038         * DumpRenderTree/LayoutTestController.h:
3039         * DumpRenderTree/chromium/LayoutTestController.h:
3040         * DumpRenderTree/chromium/LayoutTestController.cpp:
3041         (LayoutTestController::LayoutTestController):
3042         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
3043         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3044         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
3045         * DumpRenderTree/mac/DumpRenderTree.mm:
3046         (resetDefaultsToConsistentValues):
3047         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3048         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
3049         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3050         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3051         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
3052         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3053         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
3054         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3055         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
3056
3057 2010-12-12  Sam Weinig  <sam@webkit.org>
3058
3059         Reviewed by Anders Carlsson.
3060
3061         Fix failing API test. It turns out that a pop-state event
3062         is sent before every fragment navigation, so we have to test
3063         for it in addition in PageLoadDidChangeLocationWithinPageForFrame.
3064
3065         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
3066         (TestWebKitAPI::didSameDocumentNavigationForFrame):
3067
3068 2010-12-12  Alejandro G. Castro  <alex@igalia.com>
3069
3070         Reviewed by Eric Seidel.
3071
3072         [GTK] Add new-run-webkit-tests support to gtk
3073         https://bugs.webkit.org/show_bug.cgi?id=50681
3074
3075         Adding the basic support to run the new-run-webkit-tests.
3076
3077         * Scripts/webkitpy/layout_tests/port/gtk.py:
3078
3079 2010-10-11  Diego Gonzalez  <diegohcg@webkit.org>
3080
3081         Reviewed by Kenneth Rohde Christiansen.
3082
3083         [Qt] Mock DeviceOrientation client for DRT
3084         https://bugs.webkit.org/show_bug.cgi?id=47490
3085
3086         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3087         (WebCore::DumpRenderTree::DumpRenderTree):
3088         (WebCore::DumpRenderTree::~DumpRenderTree):
3089         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3090         (LayoutTestController::setMockDeviceOrientation):
3091
3092 2010-12-11  Philippe Normand  <pnormand@igalia.com>
3093
3094         Reviewed by Gustavo Noronha Silva.
3095
3096         [GTK] launcher: disable the Mozilla-style fullscreen API
3097         https://bugs.webkit.org/show_bug.cgi?id=50874
3098
3099         Disabling the fullscreen API until its implementation for GTK is
3100         mature enough. The webview setting for it is already FALSE by
3101         default.
3102
3103         * GtkLauncher/main.c:
3104         (createWindow):
3105
3106 2010-12-10  Eric Seidel  <eric@webkit.org>
3107
3108         Reviewed by Adam Barth.
3109
3110         commit-queue flaky test messages show cryptic version information for mac os x
3111         https://bugs.webkit.org/show_bug.cgi?id=50864
3112
3113         Turns out platform.platform() returns kernel version information
3114         which isn't helpful, and just plain confusing on Mac
3115         (OS X 10.6.5 uses Darwin Kernel 10.5.0).
3116
3117         So I've updated PlatformInfo.display_name() to special case
3118         mac.  I also found a bad use of sys.platform in the process
3119         and fixed that.  (sys.platform always returns 'darwin' on mac).
3120
3121         * Scripts/webkitpy/common/system/platforminfo.py:
3122         * Scripts/webkitpy/common/system/user.py:
3123         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3124         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3125         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3126
3127 2010-12-10  Eric Seidel  <eric@webkit.org>
3128
3129         Unreviewed.
3130
3131         Exception seen while reporting flaky test with commit-queue.
3132         Just a missing include.
3133
3134         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3135         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3136
3137 2010-12-10  Kinuko Yasuda  <kinuko@chromium.org>
3138
3139         Reviewed by Eric Seidel.
3140
3141         [Chromium] Remove old JSONResultsGenerator script that existed for backward-compatibility
3142         https://bugs.webkit.org/show_bug.cgi?id=50796
3143
3144         Also updating the test code to use JSONResultsGeneratorBase and
3145         to improve test coverage for incremental cases.
3146
3147         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3148         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
3149
3150 2010-12-10  Joseph Pecoraro  <joepeck@webkit.org>
3151
3152         Reviewed by Darin Adler.
3153
3154         prepare-ChangeLog --help doesn't mention --bug shorthand -b
3155         https://bugs.webkit.org/show_bug.cgi?id=50835
3156
3157         * Scripts/prepare-ChangeLog: be more explicit about -b and match file style.
3158
3159 2010-12-10  Eric Seidel  <eric@webkit.org>
3160
3161         Reviewed by Adam Barth.
3162
3163         Bugs created by the commit-queue should all block on a master bug
3164         https://bugs.webkit.org/show_bug.cgi?id=50857
3165
3166         This makes all bugs created by the commit-queue block on:
3167         https://bugs.webkit.org/show_bug.cgi?id=50856
3168
3169         In the process of testing this, I found that the existing
3170         create_bug code was wrong.  I also found that existing
3171         unit tests for create-rollout used invalid values
3172         for options.blocks.  I fixed both issues and tested.
3173
3174         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3175         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3176         * Scripts/webkitpy/tool/commands/commandtest.py:
3177         * Scripts/webkitpy/tool/commands/download_unittest.py:
3178         * Scripts/webkitpy/tool/commands/upload_unittest.py:
3179         * Scripts/webkitpy/tool/mocktool.py:
3180         * Scripts/webkitpy/tool/steps/options.py:
3181
3182 2010-12-10  Eric Seidel  <eric@webkit.org>
3183
3184         Reviewed by Adam Barth.
3185
3186         Teach webkitpy how to follow duplicate chains when posting comments on flake bugs
3187         https://bugs.webkit.org/show_bug.cgi?id=50853
3188
3189         I also discovered when doing this that the code was posting
3190         the comment on the wrong bug, but that's fixed here too.
3191
3192         * Scripts/webkitpy/common/net/bugzilla/bug.py:
3193         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3194         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3195         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3196         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3197         * Scripts/webkitpy/tool/mocktool.py:
3198
3199 2010-12-10  Anders Carlsson  <andersca@apple.com>
3200
3201         Reviewed by John Sullivan.
3202
3203         Make WKContextGetStatistics gather global statistics
3204         https://bugs.webkit.org/show_bug.cgi?id=50850
3205
3206         Remove the code that gets the statistics and fills in the per context
3207         statistics information for now.
3208
3209         * MiniBrowser/mac/BrowserStatisticsWindowController.m:
3210         (-[BrowserStatisticsWindowController refreshStatistics:]):
3211
3212 2010-12-10  Eric Seidel  <eric@webkit.org>
3213
3214         Unreviewed.
3215
3216         commit-queue should report port/platform information when commenting on flaky test bugs
3217         https://bugs.webkit.org/show_bug.cgi?id=50839
3218
3219         Renamed platform.py to platforminfo.py.  This broke import platform in executive.py
3220         which was only used by new run webkit tests (and clearly not unit tested).
3221
3222         * Scripts/webkitpy/common/system/platforminfo.py: Renamed from WebKitTools/Scripts/webkitpy/common/system/platform.py.
3223         * Scripts/webkitpy/tool/main.py:
3224         * Scripts/webkitpy/tool/mocktool.py:
3225
3226 2010-12-10  Eric Seidel  <eric@webkit.org>
3227
3228         Reviewed by Tony Chang.
3229
3230         commit-queue should report port/platform information when commenting on flaky test bugs
3231         https://bugs.webkit.org/show_bug.cgi?id=50839
3232
3233         This was a suggestion from Tony Chang this morning.
3234         I added a platform.py class so I could easily mock the platform call,
3235         but that may not be the final solution for this mocking.
3236         We'll try it and see.
3237
3238         * Scripts/webkitpy/common/system/platform.py: Added.
3239         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3240         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3241         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3242         * Scripts/webkitpy/tool/main.py:
3243         * Scripts/webkitpy/tool/mocktool.py:
3244
3245 2010-12-10  Krithigassree Sambamurthy  <krithigassree.sambamurthy@nokia.com>
3246
3247         Reviewed by Joseph Pecoraro.
3248
3249         Bug 43455 - [Qt]: Implement Application Cache Quotas
3250         https://bugs.webkit.org/show_bug.cgi?id=43455
3251
3252         Introduce functions to allow new appcache layout test origin-quota.html
3253         to work correctly under Qt.
3254
3255         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3256         (WebCore::DumpRenderTree::DumpRenderTree):
3257         (WebCore::DumpRenderTree::dumpApplicationCacheQuota):
3258         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3259
3260         Introduce functions to allow new appcache layout test origin-quota.html
3261         to be successful under qt. Changes required because LayoutTestControllerQt
3262         does not inherit from LayoutController.
3263
3264         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3265         (LayoutTestController::reset):
3266         (LayoutTestController::clearAllApplicationCaches):
3267         (LayoutTestController::setApplicationCacheOriginQuota):
3268         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3269         (LayoutTestController::shouldDumpApplicationCacheDelegateCallbacks):
3270         (LayoutTestController::dumpApplicationCacheDelegateCallbacks):
3271
3272 2010-12-10  Eric Seidel  <eric@webkit.org>
3273
3274         Reviewed by Adam Barth.
3275
3276         Move buildbot.py into its own module so we can split it out into one-file-per-class
3277         https://bugs.webkit.org/show_bug.cgi?id=50806
3278
3279         We're adding more buildbot logic these days, so it makes sense
3280         to give buildbot its own module.
3281
3282         * Scripts/webkitpy/common/net/buildbot/__init__.py: Added.
3283         * Scripts/webkitpy/common/net/buildbot/buildbot.py: Renamed from WebKitTools/Scripts/webkitpy/common/net/buildbot.py.
3284         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py: Renamed from WebKitTools/Scripts/webkitpy/common/net/buildbot_unittest.py.
3285         * Scripts/webkitpy/common/net/failuremap.py:
3286         * Scripts/webkitpy/common/net/regressionwindow.py:
3287         * Scripts/webkitpy/tool/commands/rebaseline.py:
3288
3289 2010-12-10  Tony Chang  <tony@chromium.org>
3290
3291         Reviewed by Eric Seidel.
3292
3293         Use FileSystem::remove when cleaning up http lock files
3294         https://bugs.webkit.org/show_bug.cgi?id=50830
3295
3296         * Scripts/webkitpy/layout_tests/port/http_lock.py:
3297
3298 2010-12-10  Joone Hur  <joone@kldp.org>
3299
3300         Reviewed by Martin Robinson.
3301
3302         [GTK] DRT needs layoutTestController.setCacheModel
3303         https://bugs.webkit.org/show_bug.cgi?id=50705
3304         
3305         webkit_set_cache_mode() is called to set the cache model.
3306         
3307         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3308         (LayoutTestController::setCacheModel): Set the cache model. 
3309
3310 2010-12-10  Tony Chang  <tony@chromium.org>
3311
3312         Reviewed by Ojan Vafai.
3313
3314         [chromium] remove --use-drt and add --use-test-shell
3315         https://bugs.webkit.org/show_bug.cgi?id=50701
3316
3317         * Scripts/webkitpy/common/config/ports.py:
3318         * Scripts/webkitpy/common/config/ports_unittest.py:
3319         * Scripts/webkitpy/layout_tests/port/chromium.py:
3320         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
3321         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
3322         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3323         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3324         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3325         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3326         * Scripts/webkitpy/layout_tests/port/webkit.py:
3327         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3328         * Scripts/webkitpy/style/checkers/test_expectations.py:
3329         * Scripts/webkitpy/tool/commands/queries.py:
3330
3331 2010-12-10  John Knottenbelt  <jknotten@chromium.org>
3332
3333         Reviewed by Steve Block.
3334
3335         [Chromium] Implement mocks for client-based geolocation
3336         https://bugs.webkit.org/show_bug.cgi?id=46895
3337
3338         * DumpRenderTree/chromium/LayoutTestController.cpp:
3339         (LayoutTestController::setGeolocationPermission):
3340         (LayoutTestController::setMockGeolocationPosition):
3341         (LayoutTestController::setMockGeolocationError):
3342         * DumpRenderTree/chromium/LayoutTestController.h:
3343         * DumpRenderTree/chromium/WebViewHost.cpp:
3344         (WebViewHost::geolocationClient):
3345         (WebViewHost::geolocationClientMock):
3346         (WebViewHost::reset):
3347         * DumpRenderTree/chromium/WebViewHost.h:
3348
3349 2010-12-10  Alejandro G. Castro  <alex@igalia.com>
3350
3351         Reviewed by Martin Robinson.
3352
3353         [GTK] Add hasSpellingMarker support to the DRT
3354         https://bugs.webkit.org/show_bug.cgi?id=50739
3355
3356         Implemented the hasSpellingMarker to support spelling tests.
3357
3358         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3359         (LayoutTestController::hasSpellingMarker):
3360
3361 2010-12-10  Eric Seidel  <eric@webkit.org>
3362
3363         Reviewed by Ojan Vafai.
3364
3365         webkit-patch: not possible to use build-and-test with local commits
3366         https://bugs.webkit.org/show_bug.cgi?id=33378
3367
3368         Make --no-clean not even check if we have local commits.
3369         It's unclear to me why the code was originally written this way.
3370         I was unable to dig up a reason from svn history.
3371
3372         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
3373         * Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py: Copied from WebKitTools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.
3374
3375 2010-12-10  Mario Sanchez Prada  <msanchez@igalia.com>
3376
3377         Reviewed by Martin Robinson.
3378
3379         [GTK] AX: implement isEnabled in DRT
3380         https://bugs.webkit.org/show_bug.cgi?id=50814
3381
3382         Implement AccessibilityUIElement::isEnabled() for GTK.
3383
3384         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3385         (checkElementState): New function to refactor common code.
3386         (AccessibilityUIElement::isEnabled): Implement this by checking
3387         the current state of the AtkObject.
3388         (AccessibilityUIElement::isSelected): Use the new
3389         checkElementState function.
3390
3391 2010-12-10  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
3392
3393         Reviewed by Kenneth Rohde Christiansen.
3394
3395         [Qt][WK2] Add the QWKContext API class to wrap the WebContext.
3396         https://bugs.webkit.org/show_bug.cgi?id=50750
3397
3398         * MiniBrowser/qt/BrowserView.cpp:
3399         (BrowserView::BrowserView):
3400         * MiniBrowser/qt/BrowserView.h:
3401         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3402         (WTR::WebView::WebView):
3403
3404 2010-12-10  Joone Hur  <joone@kldp.org>
3405
3406         Reviewed by Xan Lopez.
3407
3408         [GTK] Unskipping some test cases in userscripts dependent on addUserStyleSheet
3409         https://bugs.webkit.org/show_bug.cgi?id=50808
3410
3411         Unskipping the following test cases:
3412         userscripts/mixed-case-stylesheet.html
3413         userscripts/simple-stylesheet.html
3414         userscripts/user-style-all-frames.html
3415
3416         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3417         (LayoutTestController::addUserStyleSheet):
3418
3419 2010-12-10  Joone Hur  <joone@kldp.org>
3420
3421         Reviewed by Eric Seidel.
3422
3423         [GTK] Add DRT support for pageProperty, isPageBoxVisible, pageSizeAndMarginsInPixels, and addUserStyleSheet
3424         https://bugs.webkit.org/show_bug.cgi?id=50783
3425
3426         This patch allows to unskip the following test cases:
3427         printing/page-rule-selection.html
3428         printing/page-format-data.html
3429
3430         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3431         (LayoutTestController::pageProperty): Added.
3432         (LayoutTestController::isPageBoxVisible): Ditto.
3433         (LayoutTestController::pageSizeAndMarginsInPixels): Ditto.
3434         (LayoutTestController::addUserStyleSheet): Ditto.
3435
3436 2010-12-10  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
3437
3438         Reviewed by Kenneth Rohde Christiansen.
3439
3440         [Qt] Make QtTestBrowser spawn QNAM in a secondary thread.
3441
3442         A menu allows to switch QNAM back to the same thread.
3443
3444         * QtTestBrowser/launcherwindow.cpp:
3445         (LauncherWindow::initializeView):
3446         (LauncherWindow::createChrome):
3447         (LauncherWindow::toggleThreadedQnam):
3448         * QtTestBrowser/launcherwindow.h:
3449         (WindowOptions::WindowOptions):
3450         * QtTestBrowser/webpage.cpp:
3451         (WebPage::WebPage):
3452         (WebPage::setQnamThreaded):
3453         * QtTestBrowser/webpage.h:
3454         (QnamThread::QnamThread):
3455         (QnamThread::~QnamThread):
3456         (QnamThread::networkAccessManager):
3457         (QnamThread::run):
3458
3459 2010-12-10  Martin Robinson  <mrobinson@igalia.com>
3460
3461         Reviewed by Xan Lopez.
3462
3463         [Gtk] style="font-family: courier" makes text disappear
3464         https://bugs.webkit.org/show_bug.cgi?id=47452
3465
3466         Add a test that verifies that fonts without valid charmaps are
3467         never selected.
3468
3469         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3470         (initializeFonts): Initialize DRT with our font (derived from Ahem)
3471         that has no valid charmap.
3472         * DumpRenderTree/gtk/fonts/FontWithNoValidEncoding.fon: Added.
3473         * DumpRenderTree/gtk/fonts/fonts.conf: Updated settings to override users'
3474         settings which may disable selection of bitmap fonts.
3475
3476 2010-12-10  Eric Seidel  <eric@webkit.org>
3477
3478         Unreviewed.
3479
3480         The commit-queue should file bugs about flaky tests it encounters
3481         https://bugs.webkit.org/show_bug.cgi?id=50803
3482
3483         create_bug_for_flaky_test was insufficiently tested, thus buggy.
3484         Now it's tested.
3485
3486         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3487         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3488
3489 2010-12-10  Eric Seidel  <eric@webkit.org>
3490
3491         Unreviewed.  Somehow this last-minute edit didn't quite get committed.
3492
3493         The commit-queue should file bugs about flaky tests it encounters
3494         https://bugs.webkit.org/show_bug.cgi?id=50803
3495
3496         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3497
3498 2010-12-09  Eric Seidel  <eric@webkit.org>
3499
3500         Reviewed by Adam Barth.
3501
3502         The commit-queue should file bugs about flaky tests it encounters
3503         https://bugs.webkit.org/show_bug.cgi?id=50803
3504
3505         This change got a bit big.  I also added a new config.urls file
3506         because I needed to share the view_source_url code with committervalidator.py.
3507
3508         This adds a new class FlakyTestReporter which holds all the logic about
3509         reporting flaky tests to bugzilla.
3510
3511         Right now this code knows how to look up bugs for flaky tests.
3512         If it can't find a bug filed from the commit-queue, it will open a new
3513         one, ccing the relevant people and adding information about the failure.
3514
3515         It is not yet smart enough to chase down duplicate chains, or to include
3516         the actual failure diff.  But those can be added in later iterations.
3517
3518         * Scripts/webkitpy/common/checkout/api.py:
3519         * Scripts/webkitpy/common/checkout/changelog.py:
3520         * Scripts/webkitpy/common/checkout/commitinfo.py:
3521         * Scripts/webkitpy/common/config/committervalidator.py:
3522         * Scripts/webkitpy/common/config/urls.py: Copied from WebKitTools/Scripts/webkitpy/tool/comments.py.
3523         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3524         * Scripts/webkitpy/tool/bot/flakytestreporter.py: Added.
3525         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py: Copied from WebKitTools/Scripts/webkitpy/tool/comments.py.
3526         * Scripts/webkitpy/tool/bot/irc_command.py:
3527         * Scripts/webkitpy/tool/bot/sheriff.py:
3528         * Scripts/webkitpy/tool/commands/download.py:
3529         * Scripts/webkitpy/tool/commands/queues.py:
3530         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3531         * Scripts/webkitpy/tool/comments.py:
3532         * Scripts/webkitpy/tool/mocktool.py:
3533         * Scripts/webkitpy/tool/steps/commit.py:
3534
3535 2010-12-09  Eric Seidel  <eric@webkit.org>
3536
3537         Reviewed by Adam Barth.
3538
3539         Teach webkit-patch how to search bugzilla
3540         https://bugs.webkit.org/show_bug.cgi?id=50500
3541
3542         This is a step towards teaching webkitpy how to file
3543         new bugs for flaky tests and update them when new flakes occur.
3544
3545         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3546         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
3547         * Scripts/webkitpy/tool/commands/__init__.py:
3548         * Scripts/webkitpy/tool/commands/bugsearch.py: Added.
3549
3550 2010-12-09  Adam Barth  <abarth@webkit.org>
3551
3552         Reviewed by Ojan Vafai.
3553
3554         commit-queue errors out due to local commits
3555         https://bugs.webkit.org/show_bug.cgi?id=50766
3556
3557         We seem to be tripping over having local commits in the working copy a
3558         lot recently.  I don't quite fully understand what the issue is, but
3559         this patch attempts to solve the problem by adding an explicit clean
3560         step before processing a patch.  Previously, we did the cleaning as
3561         part of the apply-attachment step, so this might not actually fix the
3562         problem.
3563
3564         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3565         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3566         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3567
3568 2010-12-09  Dirk Pranke  <dpranke@chromium.org>
3569
3570         Reviewed by Ojan Vafai.
3571
3572         Make new-run-webkit-tests --lint-test-files log slightly better
3573         messages and return -1 if lint fails. Remove the
3574         'suppress_errors' keyword param to the TestExpectationsFile
3575         class, and clean up logging and exception raising for error
3576         handling. Also add more unit tests and clean up the unit test code a bit.
3577
3578         https://bugs.webkit.org/show_bug.cgi?id=50205
3579
3580         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3581         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3582         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py
3583         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py
3584         * Scripts/webkitpy/layout_tests/port/chromium.py:
3585         * Scripts/webkitpy/style/checkers/test_expectations.py:
3586         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
3587
3588 2010-12-09  Tony Chang  <tony@chromium.org>
3589
3590         Unreviewed, fix for windows code.  We were catching the wrong
3591         exception in Windows.
3592
3593         * Scripts/webkitpy/common/system/filesystem.py:
3594
3595 2010-12-09  Antonio Gomes  <agomes@rim.com>
3596
3597         Reviewed by Martin Robinson.
3598
3599         [Gtk] Populate DumpRenderTreeSupportGtk (part IV)
3600         https://bugs.webkit.org/show_bug.cgi?id=48429
3601
3602         Adjust call sites of webkit_thread_count to use the DumpRenderTreeSupportGtk version now.
3603
3604         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3605         (LayoutTestController::workerThreadCount):
3606
3607 2010-12-06  Philippe Normand  <pnormand@igalia.com>
3608
3609         Reviewed by Martin Robinson.
3610
3611         [GTK] Support the Mozilla-style Fullscreen Javascript API
3612         https://bugs.webkit.org/show_bug.cgi?id=50572
3613
3614         Enable the Javascript Fullscreen support in the GtkLauncher. Also
3615         make DRT update the Chrome when the WebView settings have been
3616         reset to consistent values.
3617
3618         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3619         (resetDefaultsToConsistentValues):
3620         * GtkLauncher/main.c:
3621         (create_window):
3622         * Scripts/build-webkit:
3623
3624 2010-12-09  Koan-Sin Tan  <koansin.tan@gmail.com>
3625
3626         Reviewed by Tor Arne Vestbø
3627
3628         [Qt] run-launcher doesn't start the browser on Mac OS X 10.6
3629         https://bugs.webkit.org/show_bug.cgi?id=50742
3630
3631         check not only QtWebKit.framework/QtWebKit but also libQtWebKit.dylib
3632
3633         * Scripts/webkitdirs.pm:
3634
3635 2010-12-09  Joone Hur  <joone@kldp.org>
3636
3637          Reviewed by Martin Robinson.
3638
3639          [GTK] Support for viewport meta tag
3640          https://bugs.webkit.org/show_bug.cgi?id=45443
3641
3642          Add support for testing the viewport properties for WebKitGtk.
3643
3644          * DumpRenderTree/LayoutTestController.cpp:
3645          (dumpConfigurationForViewportCallback): Added this JS callback to set the size of the visible viewport.
3646          (LayoutTestController::staticFunctions):
3647          * DumpRenderTree/LayoutTestController.h:
3648          * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3649          (LayoutTestController::dumpConfigurationForViewport): Added this function to test the viewport properties.
3650          * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3651          (LayoutTestController::dumpConfigurationForViewport): Ditto.
3652          * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3653          (LayoutTestController::dumpConfigurationForViewport): Ditto.
3654          * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3655          (LayoutTestController::dumpConfigurationForViewport): Ditto.
3656          * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3657          (LayoutTestController::dumpConfigurationForViewport): Ditto.
3658
3659 2010-12-08  William Siegrist <wsiegrist@apple.com>
3660
3661         Reviewed by Eric Seidel.
3662
3663         Migrate buildbot.py from xmlrpc to json.
3664         https://bugs.webkit.org/show_bug.cgi?id=50647
3665
3666         * Scripts/webkitpy/common/net/buildbot.py:
3667
3668 2010-12-08  Tony Chang  <tony@chromium.org>
3669
3670         Reviewed by Eric Seidel.
3671
3672         make starting the websocket server more reliable on windows
3673         https://bugs.webkit.org/show_bug.cgi?id=50712
3674
3675         * Scripts/webkitpy/common/system/filesystem.py:
3676         (remove): Substitute method for os.remove to retry on error on Windows
3677         * Scripts/webkitpy/common/system/filesystem_unittest.py:
3678         * Scripts/webkitpy/layout_tests/port/http_server_base.py: Use FileSystem.remove
3679
3680 2010-12-08  Jessie Berlin  <jberlin@apple.com>
3681
3682         Reviewed by Adam Roben.
3683
3684         WebKit2: Implement WebChromeClient::exceededDatabaseQuota
3685         https://bugs.webkit.org/show_bug.cgi?id=50656
3686
3687         * MiniBrowser/mac/BrowserWindowController.m:
3688         (-[BrowserWindowController awakeFromNib]):
3689         Indicate that exceededDatabaseQuota is not implemented.
3690         * MiniBrowser/win/BrowserView.cpp:
3691         (BrowserView::create):
3692         Ditto.
3693         * WebKitTestRunner/TestController.cpp:
3694         (WTR::createOtherPage):
3695         Ditto.
3696         (WTR::TestController::initialize):
3697         Ditto.
3698
3699 2010-12-08  Antonio Gomes  <agomes@rim.com>
3700
3701         Reviewed by Martin Robinson.
3702
3703         [Gtk] Populate DumpRenderTreeSupportGtk (part III)
3704         https://bugs.webkit.org/show_bug.cgi?id=48429
3705
3706         Moved the following methods from webkitprivate.h to DumpRenderTreeSupportGtk.cpp|h:
3707         * webkit_gc_collect_javascript_objects;
3708         * webkit_gc_collect_javascript_objects_on_alternate_thread;
3709         * webkit_gc_count_javascript_objects;
3710         * webkit_web_frame_layout.
3711
3712         These were all only used by GTK+ DRT.
3713
3714         * DumpRenderTree/gtk/EventSender.cpp:
3715         (dispatchEvent):
3716         * DumpRenderTree/gtk/GCControllerGtk.cpp:
3717         (GCController::collect):
3718         (GCController::collectOnAlternateThread):
3719         (GCController::getJSObjectCount):
3720
3721 2010-12-07  Tony Chang  <tony@chromium.org>
3722
3723         Reviewed by Ojan Vafai.
3724
3725         [chromium] force NRWT to use DRT
3726         https://bugs.webkit.org/show_bug.cgi?id=50359
3727
3728         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3729
3730 2010-12-06  Sam Weinig  <sam@webkit.org>
3731
3732         Reviewed by Anders Carlsson.
3733
3734         Generalize didChangeLocationWithinPageForFrame for all same document navigations
3735         https://bugs.webkit.org/show_bug.cgi?id=50584
3736
3737         * MiniBrowser/mac/BrowserWindowController.m:
3738         (didSameDocumentNavigationForFrame):
3739         (-[BrowserWindowController awakeFromNib]):
3740         (-[BrowserWindowController didSameDocumentNavigationForFrame:]):
3741         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
3742         (TestWebKitAPI::didSameDocumentNavigationForFrame):
3743         (TestWebKitAPI::TEST):
3744         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3745         (WTR::InjectedBundlePage::InjectedBundlePage):
3746         (WTR::InjectedBundlePage::didSameDocumentNavigationForFrame):
3747         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3748         * WebKitTestRunner/TestController.cpp:
3749         (WTR::TestController::initialize):
3750
3751 2010-12-06  Kinuko Yasuda  <kinuko@chromium.org>
3752
3753         Reviewed by Ojan Vafai.
3754
3755         Make TestResultsServer return 404 for non-existing results files.
3756         https://bugs.webkit.org/show_bug.cgi?id=50581
3757
3758         * TestResultServer/handlers/testfilehandler.py:
3759
3760 2010-12-06  Tony Chang  <tony@chromium.org>
3761
3762         Reviewed by Ojan Vafai.
3763
3764         [chromium] fix an assert hit in DRT
3765         https://bugs.webkit.org/show_bug.cgi?id=50575
3766
3767         This class uses WTF's RefPtr, but expects chrome's base::RefPtr
3768         semantics.
3769
3770         Otherwise, we hit ASSERTION FAILED: !m_adoptionIsRequired
3771         (third_party/WebKit/JavaScriptCore/wtf/RefCounted.h:37 void
3772         WTF::RefCountedBase::ref()).
3773
3774         * DumpRenderTree/chromium/TestWebWorker.h:
3775         (TestWebWorker::TestWebWorker):
3776
3777 2010-12-02  Ojan Vafai  <ojan@chromium.org>
3778
3779         Reviewed by Eric Seidel.
3780
3781         make webkit-patch command work when the git branch is not synced to the remote svn branch
3782         https://bugs.webkit.org/show_bug.cgi?id=50424
3783
3784         * Scripts/webkitpy/common/checkout/scm.py:
3785         * Scripts/webkitpy/common/checkout/scm_unittest.py:
3786
3787 2010-12-06  Patrick Gansterer  <paroga@webkit.org>
3788
3789         Reviewed by Andreas Kling.
3790
3791         [WINCE] Add build system
3792         https://bugs.webkit.org/show_bug.cgi?id=50522
3793
3794         * CMakeListsWinCE.txt: Added.
3795
3796 2010-12-03  Mihai Parparita  <mihaip@chromium.org>
3797
3798         Reviewed by Tony Chang.
3799
3800         Allow the Chromium port to have Leopard-specific baselines
3801         https://bugs.webkit.org/show_bug.cgi?id=50506
3802
3803         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3804
3805 2010-12-03  Tony Chang  <tony@chromium.org>
3806
3807         Reviewed by Kent Tamura.
3808
3809         [chromium] fix 2 bugs with inspector tests in DRT
3810         https://bugs.webkit.org/show_bug.cgi?id=50492
3811
3812         Tasks can outlive the tasklist (even when canceled) so this was
3813         causing a crash when ~WebTask() ran.  Avoid this by unregistering
3814         when a task is canceled.
3815
3816         Also fix an assert when closing devtool windows by copying some
3817         logic from test_shell.
3818
3819         * DumpRenderTree/chromium/Task.cpp:
3820         (WebTask::~WebTask):
3821         (TaskList::revokeAll):
3822         * DumpRenderTree/chromium/Task.h: Canceling a task now removes it from
3823             the tasklist (since the task can outlive the tasklist).
3824         * DumpRenderTree/chromium/TestShell.h:
3825         (TestShell::devToolsWebView):
3826         * DumpRenderTree/chromium/WebViewHost.cpp:
3827         (WebViewHost::~WebViewHost): Don't load about:blank when closing
3828             a window if the window has devtools loaded.  This avoids an
3829             ASSERT and matches test_shell.
3830
3831 2010-12-06  Alejandro G. Castro  <alex@igalia.com>
3832
3833         Reviewed by Martin Robinson.
3834
3835         [GTK] Fix GtkLauncher.c style, use webkit style
3836         https://bugs.webkit.org/show_bug.cgi?id=50542
3837
3838         * GtkLauncher/main.c:
3839         (activateUriEntryCb):
3840         (updateTitle):
3841         (linkHoverCb):
3842         (notifyTitleCb):
3843         (notifyLoadStatusCb):
3844         (notifyProgressCb):
3845         (destroyCb):
3846         (goBackCb):
3847         (goForwardCb):
3848         (create_webViewCb):
3849         (webViewReadyCb):
3850         (closeWebViewCb):
3851         (createBrowser):
3852         (createStatusbar):
3853         (createToolbar):
3854         (createWindow):
3855         (main):
3856
3857 2010-12-04  Antonio Gomes  <agomes@rim.com>
3858
3859         Reviewed by Martin Robinson.
3860
3861         [Gtk] Populate DumpRenderTreeSupportGtk (Part II)
3862         https://bugs.webkit.org/show_bug.cgi?id=48429
3863
3864         Moved more private method declared with WEBKIT_API to
3865         DumpRenderTreeSupportGtk, since they were only being used by DRT.
3866
3867         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3868         (resetDefaultsToConsistentValues):
3869         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3870         (LayoutTestController::addOriginAccessWhitelistEntry):
3871         (LayoutTestController::execCommand):
3872         (LayoutTestController::isCommandEnabled):
3873
3874 2010-12-04  Antonio Gomes  <agomes@rim.com>
3875
3876         Reviewed by Andreas Kling.
3877
3878         Removed extern webkit_web_view_set_group_name from gtk/DumpRenderTree.cpp
3879
3880         Method was removed by http://trac.webkit.org/changeset/71604
3881
3882         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3883
3884 2010-12-05  Alejandro G. Castro  <alex@igalia.com>
3885
3886         Reviewed by Xan Lopez.
3887
3888         [GTK] Fix compilation warnings reported by clang
3889         https://bugs.webkit.org/show_bug.cgi?id=50252
3890
3891         * GtkLauncher/main.c:
3892         (create_window): The create_statusbar function does not have
3893         parameters.
3894
3895 2010-12-05  Robert Hogan  <robert@webkit.org>
3896
3897         Reviewed by Andreas Kling.
3898
3899         [Qt] Zero-sized font does not yet work
3900
3901         Fix fast/text/font-size-zero.html
3902
3903         Copy other ports by setting minimumFontSize to 0 for DRT runs.
3904
3905         https://bugs.webkit.org/show_bug.cgi?id=49759
3906
3907         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3908         (WebCore::WebPage::WebPage):
3909
3910 2010-12-04  Sam Weinig  <sam@webkit.org>
3911
3912         Reviewed by Jon Honeycutt.
3913
3914         WebKit2: Need client functions to notify app when the url changes due to a fragment navigation
3915         https://bugs.webkit.org/show_bug.cgi?id=50511
3916
3917         Update tools for new didChangeLocationWithinPageForFrame client function (and changed bundle
3918         signature) and added a test for the functionality (PageLoadDidChangeLocationWithinPageForFrame.cpp)
3919
3920         * MiniBrowser/mac/BrowserWindowController.m:
3921         (didChangeLocationWithinPageForFrame):
3922         (-[BrowserWindowController awakeFromNib]):
3923         (-[BrowserWindowController didChangeLocationWithinPageForFrame:]):
3924         * TestWebKitAPI/PlatformUtilities.cpp:
3925         (TestWebKitAPI::Util::toWK):
3926         * TestWebKitAPI/PlatformUtilities.h:
3927         (TestWebKitAPI::Util::adoptWK):
3928         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3929         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp: Added.
3930         (TestWebKitAPI::nullJavaScriptCallback):
3931         (TestWebKitAPI::didFinishLoadForFrame):
3932         (TestWebKitAPI::didChangeLocationWithinPageForFrame):
3933         (TestWebKitAPI::TEST):
3934         * TestWebKitAPI/Tests/WebKit2/file-with-anchor.html: Added.
3935         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3936         * TestWebKitAPI/win/copy-resources.cmd:
3937         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3938         (WTR::InjectedBundlePage::InjectedBundlePage):
3939         (WTR::InjectedBundlePage::didChangeLocationWithinPageForFrame):
3940         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3941         * WebKitTestRunner/TestController.cpp:
3942         (WTR::TestController::initialize):
3943
3944 2010-11-08  Antonio Gomes  <agomes@rim.com>
3945
3946         Reviewed by Martin Robinson.
3947
3948         [Gtk] Populate DumpRenderTreeSupportGtk
3949         https://bugs.webkit.org/show_bug.cgi?id=48429
3950
3951         Made the previous calls to webkit_web_frame* functions defined as private
3952         APIs in webkitprivate.h go through DRTSupportGtk.
3953
3954         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
3955         (AccessibilityController::focusedElement):
3956         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3957         (dumpFramesAsText):
3958         (resetDefaultsToConsistentValues):
3959         (dump):
3960         (webViewDocumentLoadFinished):
3961         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3962         (LayoutTestController::counterValueForElementById):
3963         (LayoutTestController::pageNumberForElementById):
3964         (LayoutTestController::numberOfPages):
3965         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
3966         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
3967         (LayoutTestController::sampleSVGAnimationForElementAtTime):
3968         (LayoutTestController::numberOfActiveAnimations):
3969         (LayoutTestController::suspendAnimations):
3970         (LayoutTestController::resumeAnimations):
3971         (LayoutTestController::markerTextForListItem):
3972
3973 2010-12-03  Mihai Parparita  <mihaip@chromium.org>
3974
3975         Reviewed by Tony Chang.
3976
3977         Rebaseline server: use pretty text diff output
3978         https://bugs.webkit.org/show_bug.cgi?id=50484
3979         
3980         Serve *-pretty-diff.html for text diff output.
3981
3982         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
3983         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
3984         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
3985         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
3986
3987 2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
3988
3989         Unreviewed, rolling out r73302.
3990         http://trac.webkit.org/changeset/73302
3991         https://bugs.webkit.org/show_bug.cgi?id=50499
3992
3993         Causes crashes in debug LayoutTests (Requested by xan_ on
3994         #webkit).
3995
3996         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
3997         (AccessibilityUIElement::AccessibilityUIElement):
3998         (AccessibilityUIElement::parentElementCallback):
3999         * DumpRenderTree/chromium/AccessibilityUIElement.h:
4000         * DumpRenderTree/chromium/CppBoundClass.cpp:
4001         * DumpRenderTree/chromium/CppBoundClass.h:
4002
4003 2010-12-03  Sam Weinig  <sam@webkit.org>
4004
4005         Reviewed by Maciej Stachowiak.
4006
4007         Enable <a ping> for Mac/Windows/WebKit2 builds
4008         <rdar://problem/8504473>
4009         https://bugs.webkit.org/show_bug.cgi?id=50488
4010
4011         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
4012         (TestWebKitAPI::TEST): Test that the default value of
4013         WKPreferencesGetHyperlinkAuditingEnabled is true.
4014
4015 2010-12-03  Chris Guillory  <chris.guillory@google.com>
4016
4017         Reviewed by Chris Fleizach.
4018
4019         Include the FrameView widget of a RenderWidget in the accessibility tree.
4020         https://bugs.webkit.org/show_bug.cgi?id=49106
4021
4022         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
4023         (AccessibilityUIElement::AccessibilityUIElement):
4024         (AccessibilityUIElement::parentElementCallback):
4025         (AccessibilityUIElement::isEqualCallback):
4026         * DumpRenderTree/chromium/AccessibilityUIElement.h:
4027         * DumpRenderTree/chromium/CppBoundClass.cpp:
4028         (CppBoundClass::getFromCppVariant):
4029         * DumpRenderTree/chromium/CppBoundClass.h:
4030
4031 2010-12-03  Mihai Parparita  <mihaip@chromium.org>
4032
4033         Reviewed by Tony Chang.
4034
4035         Rebaseline server: organize tests by state, add dry run mode
4036         https://bugs.webkit.org/show_bug.cgi?id=50473
4037         
4038         Group tests in the menu by state, so that it's easier to see after
4039         processing the queue which failed.
4040         
4041         Add support for the --dry-run flag so that it's easier to test changes
4042         such as this (stubs out filesystem and SCM operations).
4043
4044         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
4045         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js:
4046         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
4047
4048 2010-12-03  Brady Eidson  <beidson@apple.com>
4049
4050         Reviewed by Anders Carlsson.
4051
4052         Groundwork for <rdar://problem/7660733> and https://bugs.webkit.org/show_bug.cgi?id=50191
4053         WebKit2 Authentication Support
4054
4055         Keep these builds working:
4056         * MiniBrowser/mac/BrowserWindowController.m:
4057         (-[BrowserWindowController awakeFromNib]):
4058
4059         * WebKitTestRunner/TestController.cpp:
4060         (WTR::TestController::initialize):
4061
4062 2010-12-02  Mihai Parparita  <mihaip@chromium.org>
4063
4064         Reviewed by Tony Chang.
4065
4066         Rebaseline server: move existing baselines
4067         https://bugs.webkit.org/show_bug.cgi?id=50421
4068         
4069         Implement moving of existing baselines: move all files that are about
4070         to be overwriten by update baselines.
4071         
4072         Also fix a typo in the UI JS.
4073
4074         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js:
4075         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
4076         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py:
4077
4078 2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
4079
4080         Unreviewed, rolling out r73211.
4081         http://trac.webkit.org/changeset/73211
4082         https://bugs.webkit.org/show_bug.cgi?id=50450
4083
4084         Broke Chromium's "Webkit Win (dbg)(2)" bot. (Requested by
4085         yutak on #webkit).
4086
4087         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
4088
4089 2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
4090
4091         Unreviewed, rolling out r73222.
4092         http://trac.webkit.org/changeset/73222
4093         https://bugs.webkit.org/show_bug.cgi?id=50449
4094
4095         r73211 seemed to break Chromium's "Webkit Win (dbg)(2)" bot.
4096         (Requested by yutak on #webkit).
4097
4098         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
4099         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
4100         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
4101         * Scripts/webkitpy/layout_tests/port/base.py:
4102         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4103         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
4104
4105 2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
4106
4107         Unreviewed, rolling out r73228.
4108         http://trac.webkit.org/changeset/73228
4109         https://bugs.webkit.org/show_bug.cgi?id=50448
4110
4111         r73211 seemed to break Chromium's "Webkit Win (dbg)(2)" bot.
4112         (Requested by yutak on #webkit).
4113
4114         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
4115         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
4116         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
4117         * Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py:
4118         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
4119
4120 2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
4121
4122         Unreviewed, rolling out r73231.
4123         http://trac.webkit.org/changeset/73231
4124         https://bugs.webkit.org/show_bug.cgi?id=50443
4125
4126         r73211 seemed to broke Chromium's "Webkit Win (dbg)(2)" bot.
4127         (Requested by yutak on #webkit).
4128
4129         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
4130         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
4131         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4132         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
4133
4134 2010-12-03  David Levin  <levin@chromium.org>
4135
4136         Reviewed by Shinichiro Hamaji.
4137
4138         check-webkit-style: false positive reported for #if macro
4139         https://bugs.webkit.org/show_bug.cgi?id=48242
4140
4141         * Scripts/webkitpy/style/checkers/cpp.py: Adjusted check to avoid
4142           all preprocessor commands.
4143         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added test.
4144
4145 2010-12-02  Eric Seidel  <eric@webkit.org>
4146
4147         Reviewed by Adam Barth.
4148
4149         Update the EWSTools scripts to use modern-style git repos
4150         https://bugs.webkit.org/show_bug.cgi?id=50402
4151
4152         * EWSTools/create-webkit-git:
4153         * EWSTools/start-commit-queue.sh:
4154         * EWSTools/start-queue.sh:
4155
4156 2010-12-02  Simon Fraser  <simon.fraser@apple.com>
4157
4158         Fix Chromium Linux plugin tests by not logging
4159         unconditionally from the event handling code.
4160
4161         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
4162         (handleEventX11):
4163
4164 2010-12-02  Dirk Pranke  <dpranke@chromium.org>
4165
4166         Reviewed by Tony Chang.
4167
4168         nrwt multiprocessing - move logic back into run_webkit_tests
4169
4170         This change moves a bunch of logic that I had put into
4171         message_broker back into run_webkit_tests, in a slightly
4172         different format. WorkerMessageBroker needed to become less aware of
4173         the logic the TestRunner class uses, and more generic.
4174         Eventually the MessageBroker will only do generic messaging and
4175         thread/process-pooling, and (almost) all of the
4176         run-webkit-tests-specific logic will be moved to
4177         run_webkit_tests.py and dump_render_tree_thread.py.
4178         
4179         The biggest changes are that the Broker can now start a single
4180         worker, but the responsibility for starting all of them is pushed
4181         back to the TestRunner (Manager), and the logic for checking if
4182         the threads are done or wedged is moved back to TestRunner. We
4183         also remove WorkerMessageBroker.cleanup (not needed) and
4184         cancel_workers (they have to be cancelled individually).
4185         
4186         The  message_broker is now encapsulated inside
4187         TestRunner._run_tests(); it only needs to exist while actually
4188         running the tests.
4189
4190         Also, delete a bunch of tests in message_broker_unittest that no
4191         longer make much sense.
4192
4193         This patch depends on bug 50372.
4194
4195         https://bugs.webkit.org/show_bug.cgi?id=50374
4196
4197         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
4198         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
4199         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
4200         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4201         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
4202
4203 2010-12-02  Hayato Ito  <hayato@chromium.org>
4204
4205         Reviewed by Eric Seidel.
4206
4207         Refactor test_types's compare_output() method so that it takes a
4208         TestInput object.
4209
4210         compare_output() will need additional information included in a TestInput
4211         object to support reftests. This change is a pre-requirement of that.
4212
4213         https://bugs.webkit.org/show_bug.cgi?id=50362
4214
4215         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
4216         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
4217         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
4218         * Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py:
4219         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
4220
4221 2010-12-02  Simon Fraser  <simon.fraser@apple.com>
4222
4223         Reviewed by Anders Carlsson.
4224
4225         Add the ability to run script on 'new' and 'paint' in the test plugin
4226         https://bugs.webkit.org/show_bug.cgi?id=50425
4227         
4228         Add "onnew" and "onpaintevent" attributes to the test plugin,
4229         so that tests can run JS at these times.
4230
4231         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
4232         (pluginAllocate):
4233         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
4234         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
4235         (NPP_New):
4236         (NPP_Destroy):
4237         (handleEventCarbon):
4238         (handleEventCocoa):
4239         (NPP_HandleEvent):
4240
4241 2010-12-02  Sam Weinig  <sam@webkit.org>
4242
4243         Fix Qt build.
4244
4245         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
4246         (WTR::PlatformWebView::PlatformWebView):
4247
4248 2010-12-02  Sam Weinig  <sam@webkit.org>
4249
4250         Reviewed by Anders Carlsson.
4251
4252         WebKit2 Preferences should be held off the PageGroup, not the Context
4253         https://bugs.webkit.org/show_bug.cgi?id=50414
4254
4255         Update for API changes.
4256
4257         * WebKitTestRunner/PlatformWebView.h:
4258         * WebKitTestRunner/TestController.cpp:
4259         (WTR::createOtherPage):
4260         (WTR::TestController::initialize):
4261         (WTR::TestController::resetStateToConsistentValues):
4262         * WebKitTestRunner/TestController.h:
4263         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
4264         (WTR::PlatformWebView::PlatformWebView):
4265         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
4266         (WTR::PlatformWebView::PlatformWebView):
4267
4268 2010-12-02  Dirk Pranke  <dpranke@chromium.org>
4269
4270         Reviewed by Tony Chang.
4271
4272         new-run-webkit-tests: minor cleanup for multiprocessing work
4273
4274         This change:
4275         * moves worker naming into TestShellThread, eliminating a
4276           parameter to the constructor and putting the responsibility in
4277           the correct place.
4278         * eliminates the _WorkerState() class in message_broker, because
4279           it turns out that state really needs to be in run_webkit_tests
4280         * renames the Broker classes to be module-private.
4281         * fixes a bunch of minor commenting and whitespace issues to
4282           make subsequent patches a bit clearer.
4283         * Adds a Port hook for default_worker_model() so that we can
4284           accomodate the potential for different worker models on
4285           different ports.
4286         * merge in the fix from 50420 for the brokenness introduced in
4287           bug 50367.
4288
4289         This patch depends on bug 50367.
4290
4291         https://bugs.webkit.org/show_bug.cgi?id=50372
4292
4293         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
4294         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
4295         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
4296         * Scripts/webkitpy/layout_tests/port/base.py:
4297         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4298         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
4299
4300 2010-12-02  Dirk Pranke  <dpranke@chromium.org>
4301
4302         Reviewed by Tony Chang.
4303
4304         This change is a bunch of cleanup / refactoring of the file
4305         below. It moves a bunch of free functions to methods on the
4306         TestShellThread class, and restructures other methods to be
4307         closer to the structure we'll need for the multiprocessing
4308         rewrite.
4309
4310         It also makes the logic of --run-singly a *lot* easier to follow
4311         by nestling all of the separate-thread logic into a single
4312         routine.
4313
4314         There should be no semantic changes in this patch, just cleanup.
4315
4316         https://bugs.webkit.org/show_bug.cgi?id=50367
4317
4318         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
4319
4320 2010-12-02  Tony Chang  <tony@chromium.org>
4321
4322         Unreviewed, rolling out r73164.
4323         http://trac.webkit.org/changeset/73164
4324         https://bugs.webkit.org/show_bug.cgi?id=50359
4325
4326         broke debugger tests on win
4327
4328         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4329
4330 2010-11-30  Mihai Parparita  <mihaip@chromium.org>
4331
4332         Reviewed by Tony Chang.
4333
4334         Rebaseline server: add updating of baselines
4335         https://bugs.webkit.org/show_bug.cgi?id=50305
4336         
4337         Implements updating of baselines, where we copy -actual.* files over
4338         the current -expected.* files. To do this, we need a
4339         _get_actual_result_files method to get test results files and a
4340         _rebaseline_test method to actually do the file copy and SCM operation.
4341         _rebaseline_test logs output into a buffer, this is useful for both
4342         showing result in the UI and for unit tests.
4343         
4344         To make passing around of the various test environment properties
4345         (results directory, filesystem, SCM, etc) easier, add a TestConfig
4346         class for them.
4347         
4348         Moving of existing baselines is not implemented yet, this patch is big
4349         enough as it is.
4350
4351         * Scripts/webkitpy/common/system/filesystem.py:
4352         * Scripts/webkitpy/common/system/filesystem_mock.py:
4353         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js:
4354         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
4355         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py:
4356         * Scripts/webkitpy/tool/mocktool.py:
4357
4358 2010-12-02  Brent Fulgham  <bfulgham@webkit.org>
4359
4360         Unreviewed build fix after vcproj updates.
4361
4362         * DumpRenderTree/win/DumpRenderTreeCairo.vsprops: Make sure
4363         that WIN_CAIRO is defined for this build.
4364         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd: Update file
4365         to reflect new 'Debug_Cairo_CFLite' and 'Release_Cairo_CFLite'
4366         (these were previously 'Debug_Cairo' and 'Release_Cairo'
4367
4368 2010-12-02  Sam Weinig  <sam@webkit.org>
4369
4370         Reviewed by Anders Carlsson.
4371
4372         WebKit2 needs API to turn on popup blocking
4373         https://bugs.webkit.org/show_bug.cgi?id=50407
4374
4375         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
4376         (TestWebKitAPI::TEST):
4377         * WebKitTestRunner/TestController.cpp:
4378         (WTR::TestController::resetStateToConsistentValues):
4379
4380 2010-12-01  Tony Chang  <tony@chromium.org>
4381
4382         Reviewed by Ojan Vafai.
4383
4384         [chromium] force NRWT to use DRT
4385         https://bugs.webkit.org/show_bug.cgi?id=50359
4386
4387         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4388
4389 2010-12-02  Martin Robinson  <mrobinson@igalia.com>
4390
4391         Reviewed by Xan Lopez.
4392
4393         [GTK] DumpRenderTree has two copies of JavaScriptCore
4394         https://bugs.webkit.org/show_bug.cgi?id=49877
4395
4396         * GNUmakefile.am: Remove the second copy of JavaScriptCore from the
4397         LDADD list for DumpRenderTree.
4398
4399 2010-12-02  Sergio Villar Senin  <svillar@igalia.com>
4400
4401         Unreviewed: Added myself to list of Committers.
4402
4403         * Scripts/webkitpy/common/config/committers.py:
4404
4405 2010-12-01  Mihai Parparita  <mihaip@chromium.org>
4406
4407         Reviewed by Adam Barth.
4408
4409         build-webkit --chromium always updates DEPS and re-generates project files
4410         https://bugs.webkit.org/show_bug.cgi?id=50340
4411         
4412         Make build-webkit --chromium invoke update-webkit-chromium only when
4413         --update-chromium is passed in, so that we don't add 20 seconds to all
4414         builds.
4415         
4416         Making all invocations update was added with r61883, with the goal of
4417         making EWS bots always update. The bots will switch to using this flag
4418         (as will all other webkit-patch build steps) so nothing should change
4419         for them.
4420
4421         * Scripts/webkitdirs.pm:
4422         * Scripts/webkitpy/common/config/ports.py:
4423         * Scripts/webkitpy/common/config/ports_unittest.py:
4424
4425 2010-12-01  Dirk Pranke  <dpranke@chromium.org>
4426
4427         Reviewed by Tony Chang.
4428
4429         new-run-webkit-tests: add a --dry-run / -n flag
4430         https://bugs.webkit.org/show_bug.cgi?id=50045
4431
4432         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4433         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
4434
4435 2010-12-01  Steve Falkenburg  <sfalken@apple.com>
4436