2011-01-28 Dirk Pranke <dpranke@chromium.org>
[WebKit.git] / Tools / ChangeLog
1 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
2
3         Unreviewed, build fix.
4
5         Take two. The fix in 77023 didn't work, because we were
6         still calling path.abspath_to_uri, which calls _cygpath under
7         the covers, and it appears the cygpath on the bots does
8         something different than it does on my machine. This patch
9         removes the calls to path.abspath_to_uri, so it should be safe.
10         If it doesn't work, I'll roll it out along with r76982 and 77023.
11
12         https://bugs.webkit.org/show_bug.cgi?id=53126
13
14         * Scripts/webkitpy/layout_tests/port/test.py:
15
16 2011-01-28  David Kilzer  <ddkilzer@apple.com>
17
18         <rdar://problem/8930699> build-webkit gives a bogus warning with newer versions of Xcode 
19         <http://webkit.org/b/53353>
20
21         Reviewed by Mark Rowe.
22
23         * Scripts/webkitdirs.pm:
24         (checkRequiredSystemConfig): Check the Xcode marketing version
25         in addition to the DevCoreTools build version before complaining
26         about an old version of Xcode.  Also make the Mac OS X version
27         check use Perl's built-in version string comparitor.
28
29 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
30
31         Unreviewed, build fix.
32
33         Work around breakage on Win 7 Release bot caused by r76982
34         and the fact that windows ports use "file:////" instead of
35         "file:///". Ideally the test code should be isolated from
36         this, but it isn't yet. Will fix properly in a bit.
37
38         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
39
40 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
41
42         Reviewed by Tony Chang.
43
44         new-run-webkit-tests: change worker model values to
45         "old-inline", "old-threads" in preparation for test_runner2 /
46         multiprocessing changes.
47
48         https://bugs.webkit.org/show_bug.cgi?id=53156
49
50         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
51         * Scripts/webkitpy/layout_tests/port/base.py:
52         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
53         * Scripts/webkitpy/layout_tests/port/mac.py:
54         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
55
56 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
57
58         Reviewed by Tony Chang.
59
60         committers.py - add an IRC nickname for dpranke
61         https://bugs.webkit.org/show_bug.cgi?id=53335
62
63         * Scripts/webkitpy/common/config/committers.py:
64
65 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
66
67         Reviewed by Tony Chang.
68
69         new-run-webkit-tests: add a "mock DRT" port implementation
70         and a separate class that emulates what we expect the
71         DumpRenderTree behavior to be.
72
73         This will eventually replace port/dryrun.py and allow us to get
74         better test coverage of the new-run-webkit-tests code as well as
75         a reference for what new-run-webkit-tests expects from DRT.
76
77         This is the first attempt at this, and it is pretty bare-boned. It
78         really only has been tested on the 'mac' port (and a little on
79         the 'chromium-mac' port.
80
81         https://bugs.webkit.org/show_bug.cgi?id=53126
82
83         * Scripts/webkitpy/common/system/filesystem_mock.py:
84         * Scripts/webkitpy/layout_tests/port/dryrun.py:
85         * Scripts/webkitpy/layout_tests/port/factory.py:
86         * Scripts/webkitpy/layout_tests/port/mock_drt.py: Added.
87         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Added.
88         * Scripts/webkitpy/layout_tests/port/test.py:
89
90 2011-01-28  Pratik Solanki  <psolanki@apple.com>
91
92         Unreviewed. Removing .swp file checked in by mistake.
93
94         * Scripts/.webkitdirs.pm.swp: Removed.
95
96 2011-01-28  Pratik Solanki  <psolanki@apple.com>
97
98         Reviewed by David Kilzer.
99
100         Space not necessary for undefined feature
101         https://bugs.webkit.org/show_bug.cgi?id=53317
102
103         * Scripts/build-webkit:
104
105 2011-01-28  Chang Shu  <chang.shu@nokia.com>
106
107         Reviewed by Andreas Kling.
108
109         Reset NetworkAccessManager to clean up credentials from previous tests.
110         This change causes no performance overhead either.
111         https://bugs.webkit.org/show_bug.cgi?id=36688
112
113         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
114         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
115         (WebCore::DumpRenderTree::open):
116         * DumpRenderTree/qt/DumpRenderTreeQt.h:
117
118 2011-01-28  Zoltan Horvath  <zoltan@webkit.org>
119
120         Reviewed by Andreas Kling.
121
122         [Qt] Add Zoom Text Only action to MiniBrowser
123         https://bugs.webkit.org/show_bug.cgi?id=53297
124
125         Add Zoom Text Only action to MiniBrowser's view menu, change zoom levels to avoid unnecessary divides.
126
127         * MiniBrowser/qt/BrowserWindow.cpp:
128         (BrowserWindow::BrowserWindow):
129         (BrowserWindow::zoomIn):
130         (BrowserWindow::zoomOut):
131         (BrowserWindow::resetZoom):
132         (BrowserWindow::toggleZoomTextOnly):
133         (BrowserWindow::applyZoom):
134         * MiniBrowser/qt/BrowserWindow.h:
135
136 2011-01-28  Adam Barth  <abarth@webkit.org>
137
138         Reviewed by Eric Seidel.
139
140         Add webkit-patch roll-chromium-deps
141         https://bugs.webkit.org/show_bug.cgi?id=53288
142
143         This command updates the Source/WebKit/chromium/DEPS file with the
144         last-known good revision of Chromium (or a revision specified on the
145         command line).  I'd eventually like to turn this into a SheriffBot
146         command, but this is the first step.
147
148         This patch somewhat sprawled because I needed to move a bunch of code
149         out of ChangeLog that should never have been there in the first place.
150         Also, I had to fix a bug in MockUser in order to test the new command.
151
152         * Scripts/webkitpy/common/checkout/api.py:
153         * Scripts/webkitpy/common/checkout/changelog.py:
154         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
155         * Scripts/webkitpy/common/checkout/deps.py: Added.
156         * Scripts/webkitpy/common/config/urls.py:
157         * Scripts/webkitpy/tool/commands/__init__.py:
158         * Scripts/webkitpy/tool/commands/download_unittest.py:
159         * Scripts/webkitpy/tool/commands/roll.py: Added.
160         * Scripts/webkitpy/tool/commands/roll_unittest.py: Added.
161         * Scripts/webkitpy/tool/commands/upload_unittest.py:
162         * Scripts/webkitpy/tool/mocktool.py:
163         * Scripts/webkitpy/tool/steps/__init__.py:
164         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py: Added.
165         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
166         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py: Added.
167         * Scripts/webkitpy/tool/steps/suggestreviewers_unittest.py:
168         * Scripts/webkitpy/tool/steps/updatechromiumdeps.py: Added.
169         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
170
171 2011-01-27  Greg Coletta  <greg.coletta@nokia.com>
172
173         Reviewed by Laszlo Gombos.
174
175         Get rid of prefix header dependency for WebKit2 build system
176         https://bugs.webkit.org/show_bug.cgi?id=50174
177
178         Change the style checker so that it enforces config.h include for
179         WebKit2.
180
181         * Scripts/webkitpy/style/checker.py:
182
183 2011-01-27  Maciej Stachowiak  <mjs@apple.com>
184
185         Reviewed by Darin Adler.
186
187         execCommand("Paste") doesn't work in WebKitTestRunner
188         https://bugs.webkit.org/show_bug.cgi?id=52785
189
190         Enable both of the settings needed to allow paste.
191         
192         * WebKitTestRunner/TestController.cpp:
193         (WTR::TestController::resetStateToConsistentValues):
194
195 2011-01-27  Jacob Dinu  <dinu.jacob@nokia.com>
196
197         Reviewed by Andreas Kling.
198
199         [Qt] QtTestBrowser: User input lost when toggling use of QGraphicsView
200         https://bugs.webkit.org/show_bug.cgi?id=48440
201
202         Preserve user input when toggling use of QGraphicsView
203
204         * QtTestBrowser/launcherwindow.cpp:
205         (LauncherWindow::initializeView):
206         (LauncherWindow::loadFinished):
207         * QtTestBrowser/launcherwindow.h:
208         * QtTestBrowser/mainwindow.cpp:
209         (MainWindow::addressUrl):
210         * QtTestBrowser/mainwindow.h:
211
212 2011-01-27  Dirk Pranke  <dpranke@chromium.org>
213
214         Reviewed by Mihai Parparita.
215
216         new-run-webkit-tests: turn off pixel tests correctly by default
217         for webkit-based ports. r70013 (bug 47510) used
218         port.set_option_default() to attempt to set default values, but
219         that didn't work correctly. I have removed set_option_default
220         for now since it was only being used in two places and in three
221         useless unit tests. There is a separate bug open to fix the
222         option parsing (48095), so this workaround is fine for now.
223
224         https://bugs.webkit.org/show_bug.cgi?id=53217
225
226         * Scripts/webkitpy/layout_tests/port/webkit.py:
227         * Scripts/webkitpy/layout_tests/port/base.py:
228         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
229
230 2011-01-27  Balazs Kelemen  <kbalazs@webkit.org>
231
232         Rubber-stamped by Ariya Hidayat.
233
234         Trivial crash fix in WTR.
235
236         * WebKitTestRunner/TestController.cpp:
237         (WTR::TestController::initialize): Increase the size
238         of the vector by one to be able to store the null character.
239
240 2011-01-27  Balazs Kelemen  <kbalazs@webkit.org>
241
242         Reviewed by Csaba Osztrogonác.
243
244         [Qt][WK2] WTR should be initialized in the same way as DRT
245         https://bugs.webkit.org/show_bug.cgi?id=53240
246
247         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
248         (WTR::activateFonts): Added missing initialization steps.
249
250 2011-01-27  Joone Hur <joone.hur@collabora.co.uk>
251
252         Unreviewed. 
253
254         Adding myself to committers.py.
255
256         * Scripts/webkitpy/common/config/committers.py:
257
258 2011-01-27  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
259
260         Reviewed by Csaba Osztrogonác.
261
262         [Qt] [Symbian] Move project files into Source
263         https://bugs.webkit.org/show_bug.cgi?id=52891
264
265         Fix the Symbian build after the project files
266         are moved to Source directory. On Symbian qmake
267         needs to run in the same directory where the main
268         pro files (WebKit.pro, Tools.pro) are located.
269
270         * Scripts/webkitdirs.pm: Change to the directory where the pro file
271         is located before running qmake for Symbian. Qmake on Symbian
272         does not properly honor the "-o" option, work it around by setting
273         the name of the Makefile to bld.inf.
274
275 2011-01-27  Zoltan Horvath  <zoltan@webkit.org>
276
277         Reviewed by Andreas Kling.
278
279         [Qt] Add simple zooming features to MiniBrowser
280         https://bugs.webkit.org/show_bug.cgi?id=53231
281
282         Add View menu and Zoom In, Zoom Out, Zoom Reset actions to MiniBrowser.
283
284         * MiniBrowser/qt/BrowserWindow.cpp:
285         (BrowserWindow::BrowserWindow):
286         (BrowserWindow::zoomIn):
287         (BrowserWindow::zoomOut):
288         (BrowserWindow::resetZoom):
289         (BrowserWindow::updateUserAgentList):
290         (BrowserWindow::applyZoom):
291         * MiniBrowser/qt/BrowserWindow.h:
292
293 2011-01-26  Maciej Stachowiak  <mjs@apple.com>
294
295         Reviewed by Dan Bernstein.
296
297         WebKitTestRunner needs to support layoutTestController.evaluateInWebInspector
298         https://bugs.webkit.org/show_bug.cgi?id=42319
299         
300         Add evaluateInWebInspector and other APIs needed for inspector tests to run.
301
302         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
303         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
304         (WTR::LayoutTestController::showWebInspector):
305         (WTR::LayoutTestController::closeWebInspector):
306         (WTR::LayoutTestController::evaluateInWebInspector):
307         (WTR::LayoutTestController::setTimelineProfilingEnabled):
308         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
309         * WebKitTestRunner/TestInvocation.cpp:
310         (WTR::shouldOpenWebInspector):
311         (WTR::TestInvocation::invoke):
312         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
313
314 2011-01-26  Martin Robinson  <mrobinson@igalia.com>
315
316         Reviewed by Xan Lopez.
317
318         [GTK] Pixel dumps do not include scrollbars in output images
319         https://bugs.webkit.org/show_bug.cgi?id=53216
320
321         Show scrollbars in pixel dumps. This will fix pixel dumps for tests
322         that have scrollbars.
323
324         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
325         (createBitmapContextFromWebView): Take the snapshot of the containing GtkScrolledWindow
326         instead of the web view itself.
327
328 2011-01-26  Dirk Pranke  <dpranke@chromium.org>
329
330         Reviewed by Mihai Parparita.
331
332         Fix regression introduced in r76322 ... new-run-webkit-tests
333         was attempting to save the image diff output as a UTF-8-encoded
334         file.
335
336         https://bugs.webkit.org/show_bug.cgi?id=53210
337
338         * Scripts/webkitpy/layout_tests/port/webkit.py:
339
340 2011-01-26  Sheriff Bot  <webkit.review.bot@gmail.com>
341
342         Unreviewed, rolling out r76709.
343         http://trac.webkit.org/changeset/76709
344         https://bugs.webkit.org/show_bug.cgi?id=53194
345
346         "broke python tests on non-snowleopard platforms" (Requested
347         by dpranke on #webkit).
348
349         * Scripts/webkitpy/layout_tests/port/factory.py:
350         * Scripts/webkitpy/layout_tests/port/mock_drt.py: Removed.
351         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Removed.
352
353 2011-01-26  Dirk Pranke  <dpranke@chromium.org>
354
355         Reviewed by Tony Chang.
356
357         new-run-webkit-tests: add a "mock DRT" port implementation
358         and a separate class that emulates what we expect the
359         DumpRenderTree behavior to be.
360
361         This will eventually replace port/dryrun.py and allow us to get
362         better test coverage of the new-run-webkit-tests code as well as
363         a reference for what new-run-webkit-tests expects from DRT.
364
365         This is the first attempt at this, and it is pretty bare-boned. It
366         really only has been tested on the 'mac' port (and a little on
367         the 'chromium-mac' port.
368
369         https://bugs.webkit.org/show_bug.cgi?id=53126
370
371         * Scripts/webkitpy/layout_tests/port/mock_drt.py: Added.
372         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Added.
373         * Scripts/webkitpy/layout_tests/port/factory.py:
374
375 2011-01-26  Xianzhu Wang  <wangxianzhu@google.com>
376
377         Reviewed by Tony Chang.
378
379         Add '--no-timeout' option to Chromium DRT to ease debugging.
380         https://bugs.webkit.org/show_bug.cgi?id=52873
381
382         * DumpRenderTree/chromium/DumpRenderTree.cpp:
383         (main):
384
385 2011-01-26  Csaba Osztrogonác  <ossy@webkit.org>
386
387         Reviewed by Andreas Kling.
388
389         [Qt] Fix qt_minimal build
390         https://bugs.webkit.org/show_bug.cgi?id=53172
391
392         * QtTestBrowser/locationedit.h:
393
394 2011-01-26  Mansi Mithal  <mansi.mithal@nokia.com>
395
396         Reviewed by Antonio Gomes.
397
398         QtTestBrowser should have a UI Setting to disable plugins
399         https://bugs.webkit.org/show_bug.cgi?id=52408
400         
401         Added a new action item named "Disable Plugins"
402         under the "Settings" menu. 
403
404         * QtTestBrowser/launcherwindow.cpp:
405         (LauncherWindow::createChrome):
406         (LauncherWindow::togglePlugins):
407         * QtTestBrowser/launcherwindow.h:
408
409 2011-01-25  Patrick Gansterer  <paroga@webkit.org>
410
411         Reviewed by Adam Barth.
412
413         Move main CMakeLists.txt into Source directory
414         https://bugs.webkit.org/show_bug.cgi?id=52888
415
416         * Scripts/webkitdirs.pm:
417
418 2011-01-25  Patrick Gansterer  <paroga@webkit.org>
419
420         Reviewed by Eric Seidel.
421
422         Improve label text in submit-to-ews
423         https://bugs.webkit.org/show_bug.cgi?id=53130
424
425         * QueueStatusServer/templates/submittoews.html:
426
427 2011-01-25  Mansi Mithal  <mansi.mithal@nokia.com>
428
429         Reviewed by Antonio Gomes.
430
431         QtTestBrowser should have a UI Settings to prevent loading images
432         https://bugs.webkit.org/show_bug.cgi?id=52409
433         
434         Added a new action item named "DisableAutoLoadImages"
435         under the "Settings" menu 
436
437         * QtTestBrowser/launcherwindow.cpp:
438         (LauncherWindow::createChrome):
439         (LauncherWindow::toggleAutoLoadImages):
440         * QtTestBrowser/launcherwindow.h:
441
442 2011-01-25  Dirk Pranke  <dpranke@chromium.org>
443
444         Reviewed by Tony Chang.
445
446         Minor bug fixes and cleanup for filesystem wrappers, port/* test
447         classes, test_expectations.py. This change adds "test-win" and
448         "test-mac" variants to the test port so that we can better test
449         rebaselining, and adds a MockUser() object for reuse in testing.
450
451         https://bugs.webkit.org/show_bug.cgi?id=53036
452
453         * Scripts/webkitpy/common/system/filesystem.py:
454         * Scripts/webkitpy/common/system/filesystem_mock.py:
455         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
456         * Scripts/webkitpy/layout_tests/port/factory.py:
457         * Scripts/webkitpy/layout_tests/port/base.py:
458         * Scripts/webkitpy/layout_tests/port/test.py:
459         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
460         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
461         * Scripts/webkitpy/tool/mocktool.py:
462
463 2011-01-25  Tony Chang  <tony@chromium.org>
464
465         Reviewed by Dimitri Glazkov.
466
467         [chromium] remove unused layoutTestController callback
468         https://bugs.webkit.org/show_bug.cgi?id=53103
469
470         This method is used by a test_shell_test, but not needed by DRT.
471
472         * DumpRenderTree/chromium/LayoutTestController.cpp:
473         (LayoutTestController::LayoutTestController):
474         * DumpRenderTree/chromium/LayoutTestController.h:
475
476 2011-01-25  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
477
478         Reviewed by Andreas Kling.
479
480         [GTK] Remove 64 bits release bot from the buildbot master
481         https://bugs.webkit.org/show_bug.cgi?id=52899
482
483         Removes the 64 bits release slave from the buildbot configuration,
484         so that we can use it as an EWS.
485
486         * BuildSlaveSupport/build.webkit.org-config/config.json:
487
488 2011-01-24  Maciej Stachowiak  <mjs@apple.com>
489
490         Reviewed by Dan Bernstein.
491
492         Implement database quota callback to fix storage tests on WebKit2 bot
493         https://bugs.webkit.org/show_bug.cgi?id=53064
494
495         * WebKitTestRunner/TestController.cpp:
496         (WTR::exceededDatabaseQuota):
497         (WTR::TestController::createOtherPage):
498         (WTR::TestController::initialize):
499
500 2011-01-24  Maciej Stachowiak  <mjs@apple.com>
501
502         Reviewed by Anders Carlsson.
503
504         Use designated temp directory for the database for WebKit2
505         https://bugs.webkit.org/show_bug.cgi?id=53052
506         
507         Adopt the new WK2 API for this.
508
509         * WebKitTestRunner/TestController.cpp:
510         (WTR::TestController::libraryPathForTesting):
511         (WTR::TestController::initialize):
512         * WebKitTestRunner/TestController.h:
513         * WebKitTestRunner/mac/TestControllerMac.mm:
514         (WTR::TestController::platformLibraryPathForTesting):
515         * WebKitTestRunner/qt/TestControllerQt.cpp:
516         (WTR::TestController::platformLibraryPathForTesting):
517         * WebKitTestRunner/win/TestControllerWin.cpp:
518         (WTR::TestController::platformLibraryPathForTesting):
519
520 2011-01-24  Lucas Forschler  <lforschler@apple.com>
521
522         Reviewed by Stephanie Lewis.
523
524         Add a new Leopard test bot.
525
526         * BuildSlaveSupport/build.webkit.org-config/config.json:
527
528 2011-01-24  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
529
530         Reviewed by Adam Barth.
531
532         Add EFL Builder to core waterfall
533         https://bugs.webkit.org/show_bug.cgi?id=52704
534
535         Add EFL Builder to the core waterfall again.
536
537         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
538         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
539
540 2011-01-24  Xianzhu Wang  <wangxianzhu@google.com>
541
542         Reviewed by Tony Chang.
543
544         new-run-webkit-tests fails to start HTTP server if there are proxy settings
545         https://bugs.webkit.org/show_bug.cgi?id=52872
546
547         Force disabling proxy to resolve the problem.
548
549         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
550         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
551
552 2011-01-24  Andreas Kling  <kling@webkit.org>
553
554         Reviewed by Darin Adler.
555
556         check-webkit-style: Update exemptions following Source/ move.
557         https://bugs.webkit.org/show_bug.cgi?id=53017
558
559         * Scripts/webkitpy/style/checker.py:
560         * Scripts/webkitpy/style/checker_unittest.py:
561
562 2011-01-24  Andras Becsi  <abecsi@webkit.org>
563
564         Rubber-stamped by Csaba Osztrogonác.
565
566         [Qt] Move project files into Source
567         https://bugs.webkit.org/show_bug.cgi?id=52891
568
569         * DumpRenderTree/qt/ImageDiff.pro: Add missing "Source" to WebKit.pri path
570
571 2011-01-24  Mikhail Naganov  <mnaganov@chromium.org>
572
573         Reviewed by Yury Semikhatsky.
574
575         Web Inspector: Find duplicate strings in localizedStrings.js
576
577         https://bugs.webkit.org/show_bug.cgi?id=53005
578
579         * Scripts/check-inspector-strings:
580
581 2011-01-24  Zoltan Horvath  <zoltan@webkit.org>
582
583         Reviewed by Andreas Kling.
584
585         [Qt] Regroup MiniBrowser's menubar and add open file action
586         https://bugs.webkit.org/show_bug.cgi?id=53000
587
588         Add File and Develop menu to MiniBrowser's menubar and add open file action to File menu.
589
590         * MiniBrowser/qt/BrowserWindow.cpp:
591         (BrowserWindow::BrowserWindow):
592         (BrowserWindow::openFile):
593         (BrowserWindow::~BrowserWindow):
594         * MiniBrowser/qt/BrowserWindow.h:
595
596 2011-01-24  Csaba Osztrogonác  <ossy@webkit.org>
597
598         Unreviewed fix after r76496
599
600         [Qt] Move project files into Source
601         https://bugs.webkit.org/show_bug.cgi?id=52891
602
603         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Remove unnecessary "Source" from the path.
604         * BuildSlaveSupport/built-product-archive: Remove unnecessary "Source" from the path.
605         * Scripts/webkitdirs.pm: Add the accidentally removed slash to the path.
606
607 2011-01-24  Andras Becsi  <abecsi@webkit.org>
608
609         Reviewed by Csaba Osztrogonác.
610
611         [Qt] Move project files into Source
612         https://bugs.webkit.org/show_bug.cgi?id=52891
613
614         * DerivedSources.pro: Renamed from DerivedSources.pro.
615         * DumpRenderTree/qt/DumpRenderTree.pro:
616         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
617         * MiniBrowser/DerivedSources.pro:
618         * MiniBrowser/qt/MiniBrowser.pro:
619         * QtTestBrowser/QtTestBrowser.pro:
620         * Scripts/webkitdirs.pm:
621         * Tools.pro: Added.
622         * WebKitTestRunner/DerivedSources.pro:
623         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
624         * WebKitTestRunner/qt/WebKitTestRunner.pro:
625
626 2011-01-22  Geoffrey Garen  <ggaren@apple.com>
627
628         Reviewed by Dan Bernstein.
629
630         Beefed up --threaded mode to catch even more kinds of errors.
631         https://bugs.webkit.org/show_bug.cgi?id=52971
632
633         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Use a shared
634         context group to force JSC to mark multiple threads. (This used to be
635         the default, but it changed in SnowLeopard.)
636         (runJavaScriptThread): Do more locking and unlocking, and more allocation,
637         to give threading mistakes more chances to show themselves.
638         (startJavaScriptThreads):
639         (stopJavaScriptThreads):
640
641 2011-01-22  Robert Hogan  <robert@webkit.org>
642
643         Reviewed by Andreas Kling.
644
645         [Qt] Support layoutTestController.addURLToRedirect()
646         https://bugs.webkit.org/show_bug.cgi?id=52956
647
648         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
649         (LayoutTestController::addURLToRedirect):
650         * DumpRenderTree/qt/LayoutTestControllerQt.h:
651
652 2011-01-22  Robert Hogan  <robert@webkit.org>
653
654         Reviewed by Kenneth Rohde Christiansen.
655
656         [Qt] REGRESSION (r72360): http/tests/security/aboutBlank/xss-DENIED-* tests fail
657         https://bugs.webkit.org/show_bug.cgi?id=49802
658
659         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
660         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
661         (WebCore::DumpRenderTree::open):
662
663 2011-01-21  Adam Barth  <abarth@webkit.org>
664
665         Reviewed by Maciej Stachowiak.
666
667         Disable mac_unittest.py that fails on some of the Mac bots
668         https://bugs.webkit.org/show_bug.cgi?id=52947
669
670         As noted in the comment, this test does not appear to be correct
671         because the function this test is testing returns different results
672         depending on which flavor of Mac the test is run on.  This patch
673         disable the test.  Hopefully we can re-enable the test once we've
674         probably insulated the test from its environment.
675
676         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
677
678 2011-01-21  Dirk Pranke  <dpranke@chromium.org>
679
680         Reviewed by Mihai Parparita.
681
682         Fix bug introduced in r76322 that caused NRWT to not actually
683         read the Skipped files properly.
684
685         https://bugs.webkit.org/show_bug.cgi?id=52771
686
687         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
688         * Scripts/webkitpy/layout_tests/port/webkit.py:
689         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
690
691 2011-01-21  Sam Weinig  <sam@webkit.org>
692
693         Reviewed by Geoffrey Sean Garen and Mark Rowe.
694
695         WebKitTestRunner needs the HOME environment variable to be set.
696         <rdar://problem/8896573>
697
698         * Scripts/old-run-webkit-tests: Set the HOME environment variable if
699         it exists.
700
701 2011-01-21  Dirk Pranke  <dpranke@chromium.org>
702
703         Reviewed by Eric Seidel.
704
705         Suppress a few remaining integration tests so that none of the
706         layout_test unit tests ever read from the filesystem or launch
707         subprocesses that aren't part of the unit tests.
708
709         Also fix a minor bug in the printing unit tests that was
710         incorrectly relying on sys.argv.
711
712         https://bugs.webkit.org/show_bug.cgi?id=52863
713
714         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
715         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
716         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
717
718 2011-01-21  Darin Adler  <darin@apple.com>
719
720        Fix Mac build.
721
722         * MiniBrowser/mac/BrowserWindowController.m:
723         (-[BrowserWindowController awakeFromNib]): Pass 0 for runModal function.
724
725 2011-01-20  Darin Adler  <darin@apple.com>
726
727         Reviewed by Dan Bernstein.
728
729         WebKit2: Implement showModalDialog
730         https://bugs.webkit.org/show_bug.cgi?id=52855
731
732         This fixes WebKitTestRunner to compile, but more work is probably
733         needed to get it to pass the tests.
734
735         * WebKitTestRunner/TestController.cpp:
736         (WTR::TestController::runModal): Added. Calls through to the
737         platform-specific version of runModal.
738         (WTR::TestController::createOtherPage): Changed to be a private
739         static member function so it can refer to runModal, which is
740         a private static member function.
741         (WTR::TestController::initialize): Pass 0 for the runModal
742         function since we don't need to run the main window modal.
743         I suspect this is wrong and will need to change.
744         * WebKitTestRunner/TestController.h: Added declarations for
745         the functions added above.
746         * WebKitTestRunner/mac/TestControllerMac.mm:
747         (WTR::TestController::runModal): Added. Untested implementation.
748         * WebKitTestRunner/qt/TestControllerQt.cpp:
749         (WTR::TestController::runModal): Added.
750         * WebKitTestRunner/win/TestControllerWin.cpp:
751         (WTR::TestController::runModal): Added.
752
753 2011-01-21  Eric Seidel  <eric@webkit.org>
754
755         Reviewed by Adam Barth.
756
757         Split Host object off from WebKitPatch for easier re-use
758         https://bugs.webkit.org/show_bug.cgi?id=52284
759
760         new-run-webkit-tests and other tools are eventually going to want one of these.
761         Basically you need to inherit from this class if you want to pretend to be a
762         self.tool object for Steps/Commands.
763
764         * Scripts/webkitpy/common/host.py: Added.
765         * Scripts/webkitpy/tool/main.py:
766
767 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
768
769         Reviewed by Adam Barth.
770
771         Disable the tests that start and stop the http server and web
772         server, so that we don't have to worry about port collisions on
773         the bots.
774
775         https://bugs.webkit.org/show_bug.cgi?id=52861
776
777         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
778
779 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
780
781         Reviewed by Eric Seidel.
782
783         nrwt: rewrite google_chrome_unittest to use mock filesystem.
784         
785         https://bugs.webkit.org/show_bug.cgi?id=52772
786         
787         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
788
789 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
790
791         Reviewed by Eric Siedel.
792
793         nrwt: clean up almost all remaining port references, remove
794         unnecessary import clauses. The only remaining references are
795         in places where a mock filesystem makes no sense or can't be
796         used, and in one routine in port/google_chrome_unittest that
797         I'll rewrite in a separate patch.
798
799         https://bugs.webkit.org/show_bug.cgi?id=52771
800
801         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
802         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
803         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
804         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
805         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
806         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
807         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
808         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
809         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
810         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
811         * Scripts/webkitpy/layout_tests/port/gtk.py:
812         * Scripts/webkitpy/layout_tests/port/mac.py:
813         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
814         * Scripts/webkitpy/layout_tests/port/qt.py:
815         * Scripts/webkitpy/layout_tests/port/webkit.py:
816         * Scripts/webkitpy/layout_tests/port/win.py:
817         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
818
819 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
820
821         Reviewed by Mihai Parparita.
822
823         remove fs refs from run_webkit_tests, rebaseline_chromium_webkit_tests
824
825         https://bugs.webkit.org/show_bug.cgi?id=52762
826
827         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
828         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
829
830 2011-01-20  Tony Chang  <tony@chromium.org>
831
832         Reviewed by Ojan Vafai.
833
834         [chromium] fix the paths used for the rebaseline tool
835         https://bugs.webkit.org/show_bug.cgi?id=52857
836
837         Some of the bots were renamed so the path to grab the results zip
838         file has changed.
839
840         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
841
842 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
843
844         Reviewed by Tony Chang.
845
846         Fix bug introduced in r72688 / bug 52768 that broke the
847         generation of the output filename links in the results.html
848         output. Apparently none of the unit tests actually checked to
849         make sure the generated links were correct :(
850
851         https://bugs.webkit.org/show_bug.cgi?id=52854
852
853         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
854         * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
855
856 2011-01-20  Alexey Proskuryakov  <ap@apple.com>
857
858         Reviewed by Darin Adler.
859
860         https://bugs.webkit.org/show_bug.cgi?id=52849
861         Make window.print work with WebKit2
862
863         * MiniBrowser/mac/BrowserWindowController.m:
864         (-[BrowserWindowController awakeFromNib]):
865         * WebKitTestRunner/TestController.cpp:
866         (WTR::createOtherPage):
867         (WTR::TestController::initialize):
868         Added zeroes to WKPageUIClient structures to avoid build failures.
869
870 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
871
872         Reviewed by Eric Seidel.
873
874         nrwt: remove fs refs from printing, test_failures, test_expectations, text_diff
875
876         https://bugs.webkit.org/show_bug.cgi?id=52756
877
878         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
879         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
880         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
881         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
882         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
883         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
884
885 2011-01-20  Mansi Mithal  <mansi.mithal@nokia.com>
886
887         Reviewed by Antonio Gomes.
888
889         QtTestBrowser should have a seperate menu for Settings
890         https://bugs.webkit.org/show_bug.cgi?id=52817
891         
892         Added a new menu item named "Settings"
893         and moved the "Enable interrupting js scripts" and "Enable js pop up windows" under the "Settings" menu 
894
895         * QtTestBrowser/launcherwindow.cpp:
896         (LauncherWindow::createChrome):
897
898 2011-01-20  Sam Weinig  <sam@webkit.org>
899
900         Reviewed by John Sullivan.
901
902         Update update-webkit-localizable-strings with new path to WebKit.
903
904         * Scripts/update-webkit-localizable-strings:
905
906 2011-01-20  James Robinson  <jamesr@chromium.org>
907
908         Reviewed by Darin Fisher.
909
910         Implement mozilla's requestAnimationFrame API
911         https://bugs.webkit.org/show_bug.cgi?id=51218
912
913         Chromium DumpRenderTree support for window.webkitRequestAnimationFrame.
914
915         * DumpRenderTree/chromium/WebViewHost.cpp:
916         (invokeScheduleComposite):
917         (WebViewHost::scheduleAnimation):
918         (WebViewHost::paintInvalidatedRegion):
919         * DumpRenderTree/chromium/WebViewHost.h:
920
921 2011-01-20  Maciej Stachowiak  <mjs@apple.com>
922
923         Reviewed by Adam Roben.
924
925         WebKitTestRunner needs to support layoutTestController.evaluateScriptInIsolatedWorld
926         https://bugs.webkit.org/show_bug.cgi?id=42327
927
928         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm: Add support
929         for methods that take their normal arguments but also a JSContextRef.
930         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: IDL definition
931         for evaluateScriptInIsolatedWorld.
932         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
933         (WTR::InjectedBundlePage::didClearWindowForFrame): Set a magic variable only if
934         this call is for an isolated world.
935         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
936         (WTR::worldMap): Helper to create a world map.
937         (WTR::LayoutTestController::worldIDForWorld): Map from an ID to a world.
938         (WTR::LayoutTestController::evaluateScriptInIsolatedWorld): The newly
939         added LayoutTestController API.
940         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
941
942 2011-01-19  Adam Roben  <aroben@apple.com>
943
944         Convert paths in environment variables back to msys-style inside commit-log-editor
945
946         When this script gets run from inside git commit, msys-style paths in the environment will
947         have been turned into Windows-style paths with forward slashes. This screws up functions
948         like File::Spec->rel2abs, which seem to rely on $PWD having an msys-style path. We convert
949         the paths back to msys-style before doing anything else.
950
951         Fixes <http://webkit.org/b/48527> commit-log-editor uses full paths for section headers when
952         using msysgit's Perl and multiple ChangeLogs have been edited
953
954         Reviewed by David Kilzer.
955
956         * Scripts/commit-log-editor: Call fixEnvironment before doing anything else.
957         (fixEnvironment): Added. When run in msys in conjunction with git (i.e., when invoked from
958         inside git commit), convert Windows-style paths in the environment back to msys-style paths.
959
960 2011-01-20  Zoltan Horvath  <zoltan@webkit.org>
961
962         [Win] Unreviewed build fix after r76248.
963
964         * DumpRenderTree/ForwardingHeaders/wtf/FastAllocBase.h: Added.
965
966 2011-01-20  Zoltan Horvath  <zoltan@webkit.org>
967
968         Reviewed by Csaba Osztrogonác.
969
970         Refactoring of the custom allocation framework
971         https://bugs.webkit.org/show_bug.cgi?id=49897
972
973         Inheriting from FastAllocBase can result in objects getting larger (bug #33896, #46589).
974         The modification replaces Noncopyable and FastAllocBase classes and these inherits with their
975         equivalent macro implementation at the necessary places.
976 2011-01-20  Yi Shen  <yi.4.shen@nokia.com>
977
978         Unreviewed. 
979
980         Adding myself to committers.py.
981
982         * Scripts/webkitpy/common/config/committers.py:
983
984 2011-01-20  Adam Barth  <abarth@webkit.org>
985
986         Reviewed by Tony Chang.
987
988         Chromium builders don't delete unversioned directories when DEPS change
989         https://bugs.webkit.org/show_bug.cgi?id=52745
990
991         If we pass this option to gclient sync, gclient will delete directories
992         that are no longer part of DEPS instead of leaving them around to
993         confuse us later.  Apparently, the downstream buildbots use this option
994         already.
995
996         * Scripts/update-webkit-chromium:
997
998 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
999
1000         Unreviewed, build fix - I pulled this patch in to fix an issue
1001         revealed by r76195 running on some new bots). Also fix a couple
1002         of other issues revealed in testing.
1003
1004         nrwt: remove fs refs from layout_package/json*
1005
1006         https://bugs.webkit.org/show_bug.cgi?id=52754
1007
1008         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1009         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1010         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
1011         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1012         * Scripts/webkitpy/layout_tests/port/base.py:
1013
1014 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1015
1016         Unreviewed, build fix.
1017
1018         Fix a couple of minor bugs discovered while bringing up new bots
1019         for testing.
1020
1021         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1022         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1023
1024 2011-01-19  James Robinson  <jamesr@chromium.org>
1025
1026         Unreviewed, rolling out r76194.
1027         http://trac.webkit.org/changeset/76194
1028         https://bugs.webkit.org/show_bug.cgi?id=51218
1029
1030         Caused mysterious compile failure on the chromium win
1031         build.webkit.org bots
1032
1033         * DumpRenderTree/chromium/WebViewHost.cpp:
1034         (WebViewHost::paintInvalidatedRegion):
1035         * DumpRenderTree/chromium/WebViewHost.h:
1036
1037 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1038
1039         Reviewed by Mihai Parparita.
1040
1041         remove fs refs from test_runner, dump_render_tree_thread
1042
1043         https://bugs.webkit.org/show_bug.cgi?id=52753
1044
1045         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1046         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1047         * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
1048         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1049
1050 2011-01-19  James Robinson  <jamesr@chromium.org>
1051
1052         Reviewed by Darin Fisher.
1053
1054         Implement mozilla's requestAnimationFrame API
1055         https://bugs.webkit.org/show_bug.cgi?id=51218
1056
1057         Chromium DumpRenderTree support for window.webkitRequestAnimationFrame.
1058
1059         * DumpRenderTree/chromium/WebViewHost.cpp:
1060         (invokeScheduleComposite):
1061         (WebViewHost::scheduleAnimation):
1062         (WebViewHost::paintInvalidatedRegion):
1063         * DumpRenderTree/chromium/WebViewHost.h:
1064
1065 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1066
1067         Unreviewed, build fix.
1068
1069         Fix a few incorrect "self._filesystem" references introduced in
1070         r76184.
1071
1072         * Scripts/webkitpy/layout_tests/port/chromium.py:
1073         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1074
1075 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1076
1077         Reviewed by Mihai Parparita.
1078
1079         add a .sep property, abspath(), isabs(), mtime(), and
1080         open_text_file_for_writing() to filesystem modules. Some of
1081         these properties are not needed in this patch but will be needed
1082         in subsequent patches (I'm doing this to avoid having to track
1083         multiple versions of a single file).
1084
1085         Also, change most of the port/* modules to use the filesystem
1086         objects instead of referencing the filesystem directly.
1087
1088         https://bugs.webkit.org/show_bug.cgi?id=52748
1089
1090         * Scripts/webkitpy/common/system/filesystem.py:
1091         * Scripts/webkitpy/common/system/filesystem_mock.py:
1092         * Scripts/webkitpy/layout_tests/port/__init__.py:
1093         * Scripts/webkitpy/layout_tests/port/base.py:
1094         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1095         * Scripts/webkitpy/layout_tests/port/chromium.py:
1096         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1097         * Scripts/webkitpy/layout_tests/port/config.py:
1098         * Scripts/webkitpy/layout_tests/port/test.py:
1099         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
1100
1101 2011-01-19  Maciej Stachowiak  <mjs@apple.com>
1102
1103         Reviewed by Anders Carlsson.
1104
1105         If resetting between tests times out, treat it as a WebProcess crash
1106         https://bugs.webkit.org/show_bug.cgi?id=52757
1107
1108         * WebKitTestRunner/TestController.cpp:
1109         (WTR::TestController::runTest):
1110
1111 2011-01-19  Alexey Proskuryakov  <ap@apple.com>
1112
1113         Reviewed by Darin Adler.
1114
1115         https://bugs.webkit.org/show_bug.cgi?id=52739
1116         Make it possible for a WebKit2 client to print headers and footers
1117
1118         Added dummy implementations for new printing UIClient calls.
1119
1120         * MiniBrowser/mac/BrowserWindowController.m:
1121         (-[BrowserWindowController awakeFromNib]):
1122         * WebKitTestRunner/TestController.cpp:
1123         (WTR::createOtherPage):
1124         (WTR::TestController::initialize):
1125
1126 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1127
1128         Reviewed by Ojan Vafai.
1129
1130         Change webkitpy/layout_tests/port/test.py to use the
1131         in-memory filesystem for cleaner unit testing. This
1132         change allows us to kill a lot of code that was
1133         specific to the test port, at the cost of being a
1134         little less clear about how things would work if
1135         you didn't have a filesystem.
1136
1137         https://bugs.webkit.org/show_bug.cgi?id=52605
1138
1139         * Scripts/webkitpy/layout_tests/port/test.py:
1140
1141 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1142
1143         Unreviewed, build fix.
1144
1145         Fix test failure caused by committing attachment 79368 instead
1146         of attachment 79461 on bug 52604.
1147
1148         * Scripts/webkitpy/common/system/filesystem_mock.py:
1149
1150 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1151
1152         Reviewed by Mihai Parparita.
1153
1154         new-run-webkit-tests: remove use of os.walk, use mock filesystem for better
1155         unit testing. os.walk() is too much of a hassle to implement on
1156         top of the in-memory mock filesystem and adding the necessary
1157         interface to files_under() gives clients a cleaner API anyway
1158         (for this particular usage model).
1159
1160         https://bugs.webkit.org/show_bug.cgi?id=52691
1161
1162         * Scripts/webkitpy/common/system/filesystem.py:
1163         * Scripts/webkitpy/common/system/filesystem_mock.py:
1164         * Scripts/webkitpy/layout_tests/port/test_files.py:
1165         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
1166
1167 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1168
1169         Reviewed by Tony Chang.
1170
1171         Change more modules in the layout-tests code to use the
1172         filesystem wrapper for cleaner unit testing.
1173
1174         This patch also adds the glob() wrapper to the filesystem
1175         abstraction.
1176         
1177         https://bugs.webkit.org/show_bug.cgi?id=52604
1178
1179         * Scripts/webkitpy/layout_tests/port/test_files.py:
1180         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
1181         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
1182         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1183         * Scripts/webkitpy/common/system/filesystem.py:
1184         * Scripts/webkitpy/common/system/filesystem_mock.py:
1185
1186 2011-01-19  Levi Weintraub  <leviw@chromium.org>
1187
1188         Unreviewed.
1189
1190         Updating my email addresses and irc nick.
1191
1192         * Scripts/webkitpy/common/config/committers.py:
1193
1194 2011-01-19  Tony Chang  <tony@chromium.org>
1195
1196         Reviewed by Mihai Parparita.
1197
1198         [chromium] [linux] if check-sys-deps fails, output the failure reason
1199         https://bugs.webkit.org/show_bug.cgi?id=52671
1200
1201         * Scripts/webkitpy/common/system/executive_mock.py: Add support for
1202             error handler functions.
1203         * Scripts/webkitpy/layout_tests/port/chromium.py:
1204             output the error text from --check-sys-deps
1205         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1206
1207 2011-01-19  Aparna Nandyal  <aparna.nand@wipro.com>
1208
1209         Reviewed by Andreas Kling.
1210
1211         [Qt] QtTestBrowser crashes when closing if Facebook is opened
1212         https://bugs.webkit.org/show_bug.cgi?id=52554
1213         
1214         QtNetworkAccessManager is created in a thread and set as
1215         member variable in QWebPage. When the thread is destroyed
1216         the object is still used. So fix will set the object to
1217         NULL once the thread is destroyed.
1218
1219         * QtTestBrowser/launcherwindow.cpp:
1220         (LauncherWindow::~LauncherWindow):
1221
1222 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
1223
1224         Rubber stamped by Csaba Osztrogonac
1225
1226         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: Removed unncessary inculde of WKStringCF.h
1227
1228 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
1229
1230         Reviewed by Tony Chang.
1231
1232         new-run-webkit-tests: add a --build-directory command line argument
1233
1234         Official Google Chrome builds use a non-standard build directory
1235         location. This patch adds a --build-directory argument that
1236         allows that location to be specified on the command line. Only
1237         Chromium-based builds will use this flag for now, but anyone can
1238         in the future.
1239
1240         There are no unit tests for this since it's difficult to test
1241         until mock filesystems are fully supported in the code. This was
1242         tested by hand for now.
1243
1244         https://bugs.webkit.org/show_bug.cgi?id=52694
1245
1246         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1247         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1248         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1249         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1250
1251 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
1252
1253         Not reviewed. Bot fix.
1254
1255         Remove an inadvertently committed debugging print.
1256
1257         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1258         (LayoutTestController::notifyDone):
1259
1260 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
1261
1262         Reviewed by Sam Weinig.
1263
1264         WebKitTestRunner should track loading more like DumpRenderTree
1265         https://bugs.webkit.org/show_bug.cgi?id=52692
1266
1267         Change load tracking to track the current top loading frame, in the manner of DumpRenderTree.
1268         This makes some tests that call notifyDone multiple times pass.
1269         
1270         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1271         (WTR::InjectedBundle::InjectedBundle):
1272         (WTR::InjectedBundle::done):
1273         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1274         (WTR::InjectedBundle::topLoadingFrame):
1275         (WTR::InjectedBundle::setTopLoadingFrame):
1276         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1277         (WTR::InjectedBundlePage::InjectedBundlePage):
1278         (WTR::InjectedBundlePage::stopLoading):
1279         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
1280         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
1281         (WTR::InjectedBundlePage::didFinishLoadForFrame):
1282         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
1283         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1284         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1285         (WTR::LayoutTestController::notifyDone):
1286         * WebKitTestRunner/TestController.cpp:
1287         (WTR::TestController::didReceiveMessageFromInjectedBundle):
1288
1289 2011-01-18  Mihai Parparita  <mihaip@chromium.org>
1290
1291         Reviewed by Kent Tamura.
1292
1293         [Chromium] NRWT looking for DRT binary in the wrong path on Mac
1294         https://bugs.webkit.org/show_bug.cgi?id=52678
1295         
1296         Update path now that WebKit is inside Source.
1297
1298         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1299
1300 2011-01-18  Robert Hogan  <robert@webkit.org>
1301
1302         Reviewed by Simon Hausmann.
1303
1304         [Qt] http/tests/incremental/slow-utf8-text.pl fails
1305         https://bugs.webkit.org/show_bug.cgi?id=44282
1306
1307         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1308         (WebCore::DumpRenderTree::dump):
1309
1310 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
1311
1312         Reviewed by Mihai Parparita.
1313
1314         Fix a small race condition that could cause the unit tests for
1315         new-run-webkit-tests to fail in a multithreaded environment.
1316         There was a small window in the code where one thread would
1317         check to see if a thread had raised an exception, do something,
1318         and then check to see if the thread was alive. If the other
1319         thread raised an exception and exited in between these two
1320         steps, the exception would be lost. Flipping the order of the
1321         two checks fixes the race, since we will now always check for an
1322         exception on the thread before exiting.
1323
1324         https://bugs.webkit.org/show_bug.cgi?id=51579
1325
1326         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
1327
1328 2011-01-18  Eric Seidel  <eric@webkit.org>
1329
1330         Reviewed by Adam Barth.
1331
1332         commit-queue dies when test archiving fails
1333         https://bugs.webkit.org/show_bug.cgi?id=52617
1334
1335         I looked at the machine and it had 10 archives already
1336         thus find_unused_name was returning None.  I've upped
1337         the limit to 100 (per bug) and tested the case where
1338         find_unused_name returns None (making archive return None).
1339
1340         * Scripts/webkitpy/common/system/workspace.py:
1341         * Scripts/webkitpy/common/system/workspace_unittest.py:
1342         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1343         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1344         * Scripts/webkitpy/tool/commands/queues.py:
1345
1346 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
1347
1348         Reviewed by Ojan Vafai.
1349
1350         Update rebaseline-chromium-webkit-tests unit tests to use a mock
1351         filesystem. Also fix a couple of "with" statements missed by
1352         r76050.
1353
1354         https://bugs.webkit.org/show_bug.cgi?id=52487
1355
1356         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
1357
1358 2011-01-18  Sergio Villar Senin  <svillar@igalia.com>
1359
1360         Reviewed by Martin Robinson.
1361
1362         [Gtk] Build fixes for gtk3 build
1363         https://bugs.webkit.org/show_bug.cgi?id=52648
1364
1365         * DumpRenderTree/gtk/EventSender.cpp:
1366         (beginDragWithFilesCallback):
1367
1368 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
1369
1370         Reviewed by Mihai Parparita.
1371
1372         Update rebaseline-chromium-webkit-tests to use filesystem objects
1373         instead of direct references to os.path, shutil, tempfile, etc.
1374
1375         This patch doesn't change anything, but will allow subsequent
1376         patches to change the unit tests to no longer use the real
1377         filesystem.
1378
1379         This patch adds a bunch more methods to the filesystem object as
1380         well.
1381
1382         https://bugs.webkit.org/show_bug.cgi?id=52482
1383
1384         * Scripts/webkitpy/common/system/filesystem.py:
1385         * Scripts/webkitpy/common/system/filesystem_mock.py:
1386         * Scripts/webkitpy/tool/commands/queues.py:
1387         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1388         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
1389
1390 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
1391
1392         Reviewed by Mihai Parparita.
1393
1394         new-run-webkit-tests shouldn't crash when you try to run a
1395         directory containing only skipped files.
1396
1397         https://bugs.webkit.org/show_bug.cgi?id=52478
1398         
1399         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1400         * Scripts/webkitpy/layout_tests/port/test.py:
1401         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1402
1403 2011-01-18  Adam Bergkvist  <adam.bergkvist@ericsson.com> and Martin Robinson  <mrobinson@igalia.com>
1404
1405         Reviewed by Gustavo Noronha Silva.
1406
1407         [GTK] The GTK+ EventSender needs support for beginDragWithFiles
1408         https://bugs.webkit.org/show_bug.cgi?id=40833
1409
1410         * DumpRenderTree/gtk/EventSender.cpp: Add a beginDragWithFiles implementation for the
1411         GTK+ event sender.
1412         (dragWithFilesDragDataGetCallback): Added.
1413         (dragWithFilesDragEndCallback): Added.
1414         (beginDragWithFilesCallback): Added.
1415
1416 2011-01-18  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1417
1418         Reviewed by Adam Barth.
1419
1420         ews: Add additional watcher to efl ews
1421         https://bugs.webkit.org/show_bug.cgi?id=52613
1422
1423         Add gyuyoung.kim@samsung.com to watcher list of efl-ews.
1424
1425         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1426
1427 2011-01-17  Tony Gentilcore  <tonyg@chromium.org>
1428
1429         Reviewed by Alexey Proskuryakov.
1430
1431         Fix some headers with missing or misspelled #ifndef guards
1432         https://bugs.webkit.org/show_bug.cgi?id=52545
1433
1434         * DumpRenderTree/chromium/TestEventPrinter.h:
1435         * DumpRenderTree/chromium/WebPreferences.h:
1436
1437 2011-01-17  Jessie Berlin  <jberlin@apple.com>
1438
1439         Reviewed by Anders Carlsson.
1440
1441         REGRESSION: Assertion failure in FrameLoader::continueLoadAfterWillSubmitForm() when
1442         navigating back to an unreachable URL
1443         https://bugs.webkit.org/show_bug.cgi?id=52388
1444
1445         Add a third parameter (unreachableURL) to queueLoadHTMLString.
1446
1447         * DumpRenderTree/LayoutTestController.cpp:
1448         (queueLoadHTMLStringCallback):
1449         (LayoutTestController::queueLoadHTMLString):
1450         (LayoutTestController::queueLoadAlternateHTMLString):
1451         * DumpRenderTree/LayoutTestController.h:
1452
1453         * DumpRenderTree/WorkQueueItem.h:
1454         (LoadHTMLStringItem::LoadHTMLStringItem):
1455
1456         * DumpRenderTree/chromium/LayoutTestController.cpp:
1457         (WorkItemLoadHTMLString::WorkItemLoadHTMLString):
1458         (WorkItemLoadHTMLString::run):
1459         (LayoutTestController::queueLoadHTMLString):
1460
1461         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
1462         (LoadHTMLStringItem::invoke):
1463         * DumpRenderTree/mac/WorkQueueItemMac.mm:
1464         (LoadHTMLStringItem::invoke):
1465         * DumpRenderTree/win/WorkQueueItemWin.cpp:
1466         (LoadHTMLStringItem::invoke):
1467
1468 2011-01-17  Dan Bernstein  <mitz@apple.com>
1469
1470         Rubber-stamped by Mark Rowe.
1471
1472         Update xcodeproj svn:ignore to include xcuserdata.
1473
1474         * DumpRenderTree/DumpRenderTree.xcodeproj: Modified property svn:ignore.
1475         * MiniBrowser/MiniBrowser.xcodeproj: Modified property svn:ignore.
1476         * TestWebKitAPI/TestWebKitAPI.xcodeproj: Modified property svn:ignore.
1477         * WebKitLauncher/WebKitLauncher.xcodeproj: Modified property svn:ignore.
1478         * WebKitTestRunner/WebKitTestRunner.xcodeproj: Modified property svn:ignore.
1479
1480 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
1481
1482         Unreviewed fix after r75908.
1483
1484         Move WebKit into Source
1485         https://bugs.webkit.org/show_bug.cgi?id=52530
1486
1487         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add Source to the path for Qt API tests.
1488
1489 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
1490
1491         Unreviewed.
1492
1493         Remove accidentally committed debug printing after r75908.
1494
1495         * Scripts/webkitdirs.pm:
1496
1497 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
1498
1499         Unreviewed.
1500
1501         Add myself to committers list
1502         https://bugs.webkit.org/show_bug.cgi?id=52566
1503
1504         * Scripts/webkitpy/common/config/committers.py:
1505
1506 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
1507
1508         Reviewed by Jeremy Orlow.
1509
1510         GeolocationController should call stopUpdating on destruction
1511         https://bugs.webkit.org/show_bug.cgi?id=52216
1512
1513         fast/dom/Geolocation/window-close-crash.html requires that a
1514         Geolocation watch be started in a secondary window. Consequently,
1515         we need to allow geolocation permission and provide a mock
1516         geolocation position for the secondary window's
1517         GeolocationClientMock.
1518
1519         * DumpRenderTree/chromium/LayoutTestController.cpp:
1520         (LayoutTestController::setGeolocationPermission):
1521         (LayoutTestController::setMockGeolocationPosition):
1522         (LayoutTestController::setMockGeolocationError):
1523         * DumpRenderTree/chromium/TestShell.h:
1524         (TestShell::windowList):
1525
1526 2011-01-16  Adam Barth  <abarth@webkit.org>
1527
1528         Update more include paths to reflect WebKit move.
1529
1530         * DumpRenderTree/chromium/EventSender.cpp:
1531         (EventSender::keyDown):
1532         (EventSender::needsShiftModifier):
1533         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
1534         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
1535
1536 2011-01-16  Kent Tamura  <tkent@chromium.org>
1537
1538         Unreviewed, Chromium build fix.
1539
1540         * Scripts/update-webkit-chromium: Webkit/chromium -> Source/WebKit/chromium
1541
1542 2011-01-16  Martin Robinson  <mrobinson@igalia.com>
1543
1544         Build fix for GTK+ after source directory movement.
1545
1546         * GNUmakefile.am: Correct include paths.
1547
1548 2011-01-16  Adam Barth  <abarth@webkit.org>
1549
1550         Teach svn-apply about WebKit move.
1551
1552         * Scripts/VCSUtils.pm:
1553
1554 2011-01-16  Adam Barth  <abarth@webkit.org>
1555
1556         Rubber-stamped by Eric Seidel.
1557
1558         Move WebKit into Source
1559         https://bugs.webkit.org/show_bug.cgi?id=52530
1560
1561         * DumpRenderTree/mac/InternalHeaders/WebKit/WebTypesInternal.h:
1562         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1563         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1564         * DumpRenderTree/qt/GCControllerQt.cpp:
1565         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1566         * DumpRenderTree/qt/PlainTextControllerQt.cpp:
1567         * DumpRenderTree/qt/TextInputControllerQt.cpp:
1568         * DumpRenderTree/wscript:
1569         * QtTestBrowser/launcherwindow.h:
1570         * Scripts/build-webkit:
1571         * Scripts/webkitdirs.pm:
1572
1573 2011-01-15  Adam Barth  <abarth@webkit.org>
1574
1575         Teach svn-apply about WebKit2 move.
1576
1577         * Scripts/VCSUtils.pm:
1578
1579 2011-01-15  Adam Barth  <abarth@webkit.org>
1580
1581         Rubber-stamped by Eric Seidel.
1582
1583         Move WebKit2 into Source
1584         https://bugs.webkit.org/show_bug.cgi?id=52438
1585
1586         * MiniBrowser/qt/MiniBrowser.pro:
1587         * Scripts/build-webkit:
1588         * Scripts/do-file-rename:
1589         * Scripts/do-webcore-rename:
1590         * Scripts/test-webkitpy:
1591         * Scripts/webkitdirs.pm:
1592         * Scripts/webkitpy/style/checker.py:
1593         * WebKitTestRunner/DerivedSources.pro:
1594         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1595         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1596
1597 2011-01-15  Jochen Eisinger  <jochen@chromium.org>
1598
1599         Reviewed by David Levin.
1600
1601         [chromium] remove obsolete createView method
1602         https://bugs.webkit.org/show_bug.cgi?id=52437
1603
1604         * DumpRenderTree/chromium/WebViewHost.cpp:
1605         (WebViewHost::createView):
1606         * DumpRenderTree/chromium/WebViewHost.h:
1607
1608 2011-01-14  Brian Weinstein  <bweinstein@apple.com>
1609
1610         Reviewed by Geoff Garen.
1611
1612         ShouldLoadResourceForFrame should use strings, not URLs.
1613         https://bugs.webkit.org/show_bug.cgi?id=52476
1614
1615         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1616         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Update to use a WKStringRef.
1617         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1618
1619 2011-01-14  Tony Gentilcore  <tonyg@chromium.org>
1620
1621         Reviewed by David Levin.
1622
1623         Add Tony Gentilcore as a reviewer
1624         https://bugs.webkit.org/show_bug.cgi?id=52480
1625
1626         * Scripts/webkitpy/common/config/committers.py:
1627
1628 2011-01-14  David Levin  <levin@chromium.org>
1629
1630         Reviewed by Eric Seidel.
1631
1632         check-webkit-style: _FunctionState should keep track of where the function name starts.
1633         https://bugs.webkit.org/show_bug.cgi?id=52454
1634
1635         * Scripts/webkitpy/style/checkers/cpp.py: Added function_name_start_position to
1636         _FunctionState and logic for setting it correctly.
1637         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests.
1638
1639 2011-01-14  Vincent Scheib  <scheib@chromium.org>
1640
1641         Reviewed by David Levin.
1642
1643         Add support to DumpRenderTree to use the GPU rather than software renderer
1644         https://bugs.webkit.org/show_bug.cgi?id=52333
1645
1646         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1647         (main):
1648         * Scripts/webkitpy/layout_tests/port/chromium.py:
1649         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1650
1651 2011-01-14  Tony Chang  <tony@chromium.org>
1652
1653         Reviewed by Kent Tamura.
1654
1655         [chromium] update fonts.conf to fix 6 linux tests in drt
1656         https://bugs.webkit.org/show_bug.cgi?id=52411
1657
1658         * DumpRenderTree/chromium/fonts.conf: Update to match the copy in
1659             chromium's src/webkit/tools/test_shell/resources/fonts.conf
1660
1661 2011-01-14  Eric Seidel  <eric@webkit.org>
1662
1663         Original patch from Peter Gal  <galpater@inf.u-szeged.hu>
1664
1665         Reviewed by Adam Barth.
1666
1667         Fix when running Tools/Scripts/check-webkit-style without arguments.
1668         https://bugs.webkit.org/show_bug.cgi?id=52261#c16
1669
1670         * Scripts/webkitpy/common/checkout/scm.py: Handle None for changed_files argument better in Git.create_patch method.
1671         * Scripts/webkitpy/common/checkout/scm_unittest.py:
1672
1673 2011-01-04  Jochen Eisinger  <jochen@chromium.org>
1674
1675         Reviewed by David Levin.
1676
1677         Store the tempdir object in a variable so it doesn't get deleted too early.
1678         https://bugs.webkit.org/show_bug.cgi?id=51875
1679
1680         * Scripts/update-webkit-auxiliary-libs:
1681         * Scripts/update-webkit-support-libs:
1682
1683 2011-01-14  Eric Seidel  <eric@webkit.org>
1684
1685         Unreviewed.  Make it work in python 2.5.
1686
1687         webkit-patch suggest-reviewers dies when ChangeLogs are missing
1688         https://bugs.webkit.org/show_bug.cgi?id=49158
1689
1690         * Scripts/webkitpy/common/checkout/api_unittest.py:
1691
1692 2011-01-14  Sheriff Bot  <webkit.review.bot@gmail.com>
1693
1694         Unreviewed, rolling out r75774.
1695         http://trac.webkit.org/changeset/75774
1696         https://bugs.webkit.org/show_bug.cgi?id=52431
1697
1698         gtk builds were broken (Requested by loislo2 on #webkit).
1699
1700         * Scripts/webkitpy/common/checkout/scm.py:
1701
1702 2011-01-14  David Levin  <levin@chromium.org>
1703
1704         Reviewed by Shinichiro Hamaji.
1705
1706         check-webkit-style: _FunctionState should detect pure functions.
1707         https://bugs.webkit.org/show_bug.cgi?id=52428
1708
1709         * Scripts/webkitpy/style/checkers/cpp.py: Added detection for if a function declaration
1710         is a pure virtual function.
1711         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests for verifying that pure
1712         virtual functions are correctly detected.
1713
1714 2011-01-13  Ilya Tikhonovsky  <loislo@chromium.org>
1715
1716         Reviewed by Yury Semikhatsky.
1717
1718         Just small fix for problem with check-webkit-style.
1719         It just didn't work for this patch.
1720         Old code can't concatenate a list of strings with None.
1721
1722         * Scripts/webkitpy/common/checkout/scm.py:
1723
1724 2011-01-13  David Levin  <levin@chromium.org>
1725
1726         Reviewed by Shinichiro Hamaji.
1727
1728         check-webkit-style: _FunctionState should use Position to know where items are.
1729         https://bugs.webkit.org/show_bug.cgi?id=52424
1730
1731         * Scripts/webkitpy/style/checkers/cpp.py:
1732         (_FunctionState.*): Changed _FunctionState to use Position instead of line numbers.
1733         (detect_functions): Changed to pass Position's to _FunctionState.begin and
1734         did some minor clean-up.
1735         (*): Other changes are simply about converting to use the Position's in_FunctionState
1736         instead of line numbers.
1737         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Changed the test code
1738         to verify the positions stored in _FunctionState.
1739
1740 2011-01-13  Eric Seidel  <eric@webkit.org>
1741
1742         Reviewed by David Levin.
1743
1744         webkit-patch suggest-reviewers dies when ChangeLogs are missing
1745         https://bugs.webkit.org/show_bug.cgi?id=49158
1746
1747         This is not the most elegant, but it is a very safe fix to this bug.
1748         One advantage of catching ScriptError like this instead of adding a
1749         new added_or_modified_files or fixing all changed_files callers
1750         to use a more specific change_files variant, is that we catch
1751         all kinds of ScriptErrors which might cause our (non-essential)
1752         suggest-reviewers code to fail out.  This should make passing
1753         --suggest-reviewers to webkit-patch upload much more robust
1754         and may even make it possible for us to make it default.
1755
1756         The root of the problem here is that SCM.changed_files includes
1757         deleted ChangeLog paths (from moves, etc) which then when we ask
1758         SVN/Git for the contents of the file at that revision, the command
1759         errors out and Executive.run_command raises a ScriptError.
1760
1761         In the future we might fix this differently by making all current
1762         callers of chagned_files use a more specific method for requesting
1763         what types of changes they're interested in (adds, modifies, deletes, etc.)
1764
1765         * Scripts/webkitpy/common/checkout/api.py:
1766         * Scripts/webkitpy/common/checkout/api_unittest.py:
1767
1768 2011-01-13  Dan Bernstein  <mitz@apple.com>
1769
1770         Reviewed by Alexey Proskuryakov.
1771
1772         <rdar://problem/8827065> REGRESSION (r71884): Cross-origin XHR fails if willSendRequest changes the URL
1773         https://bugs.webkit.org/show_bug.cgi?id=52419
1774
1775         Allow to further control the behavior of the willSendRequest delegate callback by making it
1776         set a different URL in the new request.
1777
1778         * DumpRenderTree/LayoutTestController.cpp:
1779         (addURLToRedirectCallback): Added.
1780         (LayoutTestController::staticFunctions): Added addURLToRedirect.
1781         (LayoutTestController::addURLToRedirect): Added. Adds the redirection to the map.
1782         (LayoutTestController::redirectionDestinationForURL): Added this getter.
1783         * DumpRenderTree/LayoutTestController.h:
1784         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1785         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]): Check
1786         if there is a redirection for the request’s URL, established by addURLToRedirect(), and if so,
1787         change the URL in the new request to the redirect destination.
1788
1789 2011-01-13  Eric Seidel  <eric@webkit.org>
1790
1791         Reviewed by Mihai Parparita.
1792
1793         webkit-patch suggest-reviewers fails due to invalid utf8 in ChangeLog files
1794         https://bugs.webkit.org/show_bug.cgi?id=52416
1795
1796         Example: webkit-patch suggest-reviewers -g ca3890fe74d94d85d6bfa48f9ea497b094d8e717 
1797         UnicodeDecodeError: 'utf8' codec can't decode bytes in position 536-538: invalid data
1798
1799         I also added FIXMEs about the changed_files returning deleted files problem
1800         which is causing the other most common exception for suggest-reviewers
1801         (and is probably breaking sheriff-bots blame detection).
1802
1803         * Scripts/webkitpy/common/checkout/api.py:
1804         * Scripts/webkitpy/common/checkout/api_unittest.py:
1805         * Scripts/webkitpy/common/checkout/scm.py:
1806
1807 2011-01-13  Eric Seidel  <eric@webkit.org>
1808
1809         Reviewed by Adam Barth.
1810
1811         results archives from commit-queue are too large to upload
1812         https://bugs.webkit.org/show_bug.cgi?id=52405
1813
1814         * Scripts/webkitpy/common/system/filesystem.py:
1815         * Scripts/webkitpy/common/system/filesystem_mock.py:
1816         * Scripts/webkitpy/tool/commands/queues.py:
1817
1818 2011-01-13  Alejandro G. Castro  <alex@igalia.com>
1819
1820         Reviewed by Martin Robinson.
1821
1822         [gtk] Zero-sized font does not yet work
1823         https://bugs.webkit.org/show_bug.cgi?id=49793
1824
1825         Set minimum-font-size to 0 for the DRT.
1826
1827         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1828         (resetDefaultsToConsistentValues):
1829
1830 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
1831
1832         Reviewed by Darin Adler.
1833
1834         Make old-run-webkit-tests more robust on buildbots
1835         https://bugs.webkit.org/show_bug.cgi?id=52364
1836
1837         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Pass --exit-after-n-failures 500 to old-run-webkit-tests script.
1838
1839 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
1840
1841         Reviewed by Darin Adler.
1842
1843         Make old-run-webkit-tests more robust on buildbots
1844         https://bugs.webkit.org/show_bug.cgi?id=52364
1845
1846         * Scripts/old-run-webkit-tests: Ensure that testResultsDirectory is empty.
1847
1848 2011-01-13  Tony Chang  <tony@chromium.org>
1849
1850         Reviewed by Kent Tamura.
1851
1852         [chromium] fix plugins/plugin-javascript-access.html on Linux and Mac
1853         https://bugs.webkit.org/show_bug.cgi?id=52332
1854
1855         Forked Info.plist is not longer needed.
1856
1857         * DumpRenderTree/chromium/TestNetscapePlugIn/Info.plist: Removed.
1858
1859 2011-01-13  Mikhail Naganov  <mnaganov@chromium.org>
1860
1861         Reviewed by Timothy Hatcher.
1862
1863         Web Inspector: Cleanup after r75613 -- make all UI-facing strings
1864         to be passed directly to WebInspector.UIString
1865
1866         https://bugs.webkit.org/show_bug.cgi?id=52365
1867
1868         * Scripts/check-inspector-strings:
1869
1870 2011-01-13  Sheriff Bot  <webkit.review.bot@gmail.com>
1871
1872         Unreviewed, rolling out r74881.
1873         http://trac.webkit.org/changeset/74881
1874         https://bugs.webkit.org/show_bug.cgi?id=52357
1875
1876         The EFL builder has been red for days (Requested by abarth on
1877         #webkit).
1878
1879         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1880         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1881
1882 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
1883
1884         Reviewed by David Levin.
1885
1886         Add beforeunload support to WebKitTestRunner
1887         https://bugs.webkit.org/show_bug.cgi?id=52353
1888         
1889         This makes a number of currently failing tests pass.
1890
1891         * WebKitTestRunner/TestController.cpp:
1892         (WTR::runBeforeUnloadConfirmPanel):
1893         (WTR::createOtherPage):
1894         (WTR::TestController::initialize):
1895
1896 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
1897
1898         Reviewed by Sam Weinig.
1899
1900         Detect, identify and recover from WebProcess crashes in run-webkit-tests
1901         https://bugs.webkit.org/show_bug.cgi?id=52330
1902
1903         * Scripts/old-run-webkit-tests: Detect when the regression test tool reports
1904         a web process crash.
1905         * WebKitTestRunner/TestController.cpp:
1906         (WTR::TestController::initialize): Set up a processDidCrash
1907         callback.
1908         (WTR::TestController::processDidCrash): Report that the Web process
1909         crashed.
1910         * WebKitTestRunner/TestController.h:
1911
1912 2011-01-12  David Levin  <levin@chromium.org>
1913
1914         Reviewed by Shinichiro Hamaji.
1915
1916         check-webkit-style -- close_expression function doesn't work correctly.
1917         https://bugs.webkit.org/show_bug.cgi?id=52272
1918
1919         * Scripts/webkitpy/style/checkers/cpp.py:
1920         (Position.__str__): Added a way to convert it to a string which is useful in tests.
1921         (Position.__cmp__): Added a way to compare Position which is useful in tests and
1922         generally useful (for upcoming code changes).
1923         (close_expression): Changed to use Position for input and output.
1924         Also, fixed many bugs such as only working correctly for parenthesis,
1925         not working correctly if given an offset in a line and not finding
1926         the real closing element if there were multiple closing elements in
1927         the same line.
1928         (detect_functions): Adjusted due to the change in arguments for
1929         close_expression.
1930         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1931         (CppStyleTestBase.assert_positions_equal): Added a way to verify that
1932         two positions are the same.
1933         (CppStyleTest.test_position): Added tests for the __str_ and __cmp__ methods.
1934         (CppStyleTest.test_close_expression): Added tests to catch the issues
1935         that were fixed.
1936
1937 2011-01-12  Sheriff Bot  <webkit.review.bot@gmail.com>
1938
1939         Unreviewed, rolling out r75576.
1940         http://trac.webkit.org/changeset/75576
1941         https://bugs.webkit.org/show_bug.cgi?id=52304
1942
1943         broke rebaseline-chromium-webkit-test (Requested by thakis on
1944         #webkit).
1945
1946         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1947         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1948         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
1949         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1950         * Scripts/webkitpy/layout_tests/port/base.py:
1951         * Scripts/webkitpy/layout_tests/port/chromium.py:
1952         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1953         * Scripts/webkitpy/layout_tests/port/test.py:
1954         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1955         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1956         * Scripts/webkitpy/style/checkers/test_expectations.py:
1957         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1958
1959 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
1960
1961         Reviewed by Darin Adler.
1962
1963         Add a no-build option to run-webkit-tests, to avoid building DRT/WKTR
1964         https://bugs.webkit.org/show_bug.cgi?id=52307
1965
1966         * Scripts/old-run-webkit-tests:
1967
1968 2011-01-12  Koan-Sin Tan  <koansin.tan@gmail.com>
1969
1970         Reviewed by Martin Robinson.
1971
1972         [Gtk] WebKitGtk+ doesn't build on Mac OS X 10.6
1973         https://bugs.webkit.org/show_bug.cgi?id=50867
1974
1975         Fixed library extention for Mac in webkitdirs.pm and type conflict in
1976         TestNetscapePlugin.cpp 
1977
1978         * GNUmakefile.am: Don't use AppKit when compiling TestNetscapePlugin for GTK+
1979         * Scripts/webkitdirs.pm:
1980
1981 2011-01-12  Mikhail Naganov  <mnaganov@chromium.org>
1982
1983         Reviewed by Pavel Feldman.
1984
1985         Add check-inspector-strings script.
1986
1987         https://bugs.webkit.org/show_bug.cgi?id=52295
1988
1989         * Scripts/check-inspector-strings: Added.
1990
1991 2011-01-12  Adam Roben  <aroben@apple.com>
1992
1993         Advertise the .testnetscape file extension on Windows
1994
1995         Fixes <http://webkit.org/b/52298>
1996         plugins/no-mime-with-valid-extension.html fails on Windows
1997
1998         Reviewed by Dan Bernstein.
1999
2000         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Added a
2001         FileExtents field to map the .testnetscape file extension to the
2002         application/x-webkit-test-netscape MIME type, just as we do on Mac.
2003
2004 2011-01-12  Adam Barth  <abarth@webkit.org>
2005
2006         Reviewed by Eric Seidel.
2007
2008         Make webkit-patch support subdirectories for SVN checkouts
2009         https://bugs.webkit.org/show_bug.cgi?id=52261
2010
2011         os.relpath does not exist on Python 2.5, so we need to call our version
2012         of the API.
2013
2014         * Scripts/webkitpy/common/checkout/scm.py:
2015
2016 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
2017
2018         Reviewed by Eric Seidel.
2019
2020         Close additional pages opened during a test once the test completes.
2021         https://bugs.webkit.org/show_bug.cgi?id=52276
2022
2023         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2024         (WTR::InjectedBundle::done):
2025
2026 2011-01-11  David Levin  <levin@chromium.org>
2027
2028         Reviewed by Eric Seidel.
2029
2030         Errors should be separated from the command line in bot messages.
2031         https://bugs.webkit.org/show_bug.cgi?id=52275
2032
2033         * Scripts/webkitpy/common/system/executive.py:
2034         (ScriptError.message_with_output): Added a newline to separate the command
2035         line from the errors.
2036         * Scripts/webkitpy/common/system/executive_unittest.py:
2037         (ScriptErrorTest.test_message_with_output): Added tests for the various code
2038         paths in message_with_output.
2039
2040 2011-01-11  Eric Seidel  <eric@webkit.org>
2041
2042         Unreviewed.
2043
2044         commit-queue should know how to upload archived results (for test flakes or general failures)
2045         https://bugs.webkit.org/show_bug.cgi?id=52048
2046
2047         The zips are mostly empty due to forgetting -r.
2048         Expected diffs were not being pulled from the archive due
2049         to the archive having longer paths than I realized.
2050
2051         * Scripts/webkitpy/common/system/workspace.py:
2052         * Scripts/webkitpy/common/system/workspace_unittest.py:
2053         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2054         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2055
2056 2011-01-11  Dirk Pranke  <dpranke@chromium.org>
2057
2058         Reviewed by Ojan Vafai.
2059
2060         The current modifier parsing code in test_expectations is
2061         fragile and hard-coded, so it's not easy to understand the logic
2062         or easily add new types of modifiers (like GPU vs. CPU testing
2063         for graphics tests, or 32-bit vs. 64-bit differences).
2064
2065         This is the first of two patches that will add in more generic
2066         support and then eliminate the GPU-specific test expectations
2067         files for Chromium.
2068
2069         This patch adds two standalone objects for handling modifiers. The
2070         rules for interpreting modifiers, precedence, and conflicts are
2071         given in the docstring to the ModifierMatcher class, which
2072         returns ModifierMatchResult objects.
2073         
2074         This patch also adds routines to the Port interface and a
2075         default set of values in the base object, in order to obtain the
2076         values needed on a given test run. These values are then passed
2077         to the expectation parser. This also allows us to clean up the
2078         logic used to lint all of the different configurations in a
2079         single test_expectations.txt file.
2080
2081         The next patch will merge in the separate GPU expectations file.
2082
2083         https://bugs.webkit.org/show_bug.cgi?id=51222
2084
2085         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2086         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2087         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
2088         * Scripts/webkitpy/layout_tests/port/base.py:
2089         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2090         * Scripts/webkitpy/layout_tests/port/chromium.py:
2091         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2092         * Scripts/webkitpy/layout_tests/port/test.py:
2093         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2094         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2095
2096 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
2097
2098         Reviewed by Adam Barth.
2099
2100         Make webkit-patch support subdirectories for SVN checkouts
2101         https://bugs.webkit.org/show_bug.cgi?id=52261
2102
2103         * Scripts/webkitpy/common/checkout/scm.py:
2104         * Scripts/webkitpy/style_references.py:
2105         * Scripts/webkitpy/tool/main.py:
2106         * Scripts/webkitpy/tool/steps/preparechangelog.py:
2107
2108 2011-01-11  Eric Seidel  <eric@webkit.org>
2109
2110         Unreviewed.
2111
2112         commit-queue should know how to upload archived results (for test flakes or general failures)
2113         https://bugs.webkit.org/show_bug.cgi?id=52048
2114
2115         I changed the API for archive_last_layout_test_results w/o updating the implementation.  Oops.
2116         This fixes an exception seen on the commit-queue when attempting to report flaky tests.
2117
2118         * Scripts/webkitpy/common/system/workspace.py:
2119         * Scripts/webkitpy/common/system/workspace_unittest.py:
2120         * Scripts/webkitpy/tool/commands/queues.py:
2121
2122 2011-01-11  Sam Weinig  <sam@webkit.org>
2123
2124         Roll r75474 back in.
2125
2126 2011-01-11  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
2127
2128         Reviewed by Kenneth Rohde Christiansen.
2129
2130         [Qt] Remove uses of QFuture since it isn't supported on all platforms.
2131         https://bugs.webkit.org/show_bug.cgi?id=51204
2132
2133         * QtTestBrowser/webpage.h:
2134         (QtNAMThread::QtNAMThread):
2135         (QtNAMThread::networkAccessManager):
2136         (QtNAMThread::run):
2137
2138 2011-01-11  Peter Varga  <pvarga@webkit.org>
2139
2140         Unreviewed.
2141
2142         Add myself to committers' list.
2143
2144         * Scripts/webkitpy/common/config/committers.py:
2145
2146 2011-01-11  Eric Seidel  <eric@webkit.org>
2147
2148         Reviewed by Adam Barth.
2149
2150         commit-queue should know how to upload archived results (for test flakes or general failures)
2151         https://bugs.webkit.org/show_bug.cgi?id=52048
2152
2153         Now the queue will always upload results.  Either the entire zip, or just
2154         the diffs.txt in the case of text failures.
2155
2156         This should make understanding flakes much easier, and paves the way
2157         for having the EWS run layout tests (and upload failures).
2158
2159         In order to upload .zip files I had to teach bugzilla.py to autodetect
2160         mime types from the filename.  Since mimetypes.py doesn't include a mapping
2161         for .patch files, I have it add one before calling guess_type.
2162
2163         We may find that always uploading the whole zip instead of just the -diffs.txt
2164         file is preferable, but for now I'm keeping the old behavior because it makes
2165         quickly understanding text failures easy.
2166
2167         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2168         * Scripts/webkitpy/common/system/workspace.py: Added.
2169         * Scripts/webkitpy/common/system/workspace_unittest.py: Added.
2170         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2171         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2172         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2173         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2174         * Scripts/webkitpy/tool/commands/queues.py:
2175         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2176
2177 2011-01-10  Sheriff Bot  <webkit.review.bot@gmail.com>
2178
2179         Unreviewed, rolling out r75464.
2180         http://trac.webkit.org/changeset/75464
2181         https://bugs.webkit.org/show_bug.cgi?id=52193
2182
2183         Followup rollout for 75474 (Requested by Ossy on #webkit).
2184
2185         * MiniBrowser/mac/BrowserWindowController.m:
2186         (-[BrowserWindowController awakeFromNib]):
2187         * MiniBrowser/win/BrowserView.cpp:
2188         (BrowserView::create):
2189         * WebKitTestRunner/TestController.cpp:
2190         (WTR::createOtherPage):
2191         (WTR::TestController::initialize):
2192
2193 2011-01-10  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2194
2195         Reviewed by Csaba Osztrogonác.
2196
2197         [Qt] Baseline qt_minimal configuration
2198         https://bugs.webkit.org/show_bug.cgi?id=51313
2199
2200         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2201         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): Add
2202         QT_NO_UNDOSTACK guard.
2203
2204         * QtTestBrowser/launcherwindow.cpp:
2205         (LauncherWindow::createChrome): Add QT_NO_SHORTCUT and QT_NO_PRINTER
2206         guards.
2207         (LauncherWindow::applyZoom): Add QT_NO_ANIMATION guard.
2208         (LauncherWindow::screenshot): Add QT_NO_FILEDIALOG guard.
2209         (LauncherWindow::selectElements): Add QT_NO_INPUTDIALOG guard.
2210         (LauncherWindow::showUserAgentDialog): Add QT_NO_COMBOBOX guard.
2211
2212         * QtTestBrowser/launcherwindow.h:
2213         * QtTestBrowser/locationedit.cpp: Add QT_NO_INPUTDIALOG guard.
2214         * QtTestBrowser/locationedit.h: Ditto.
2215
2216         * QtTestBrowser/mainwindow.cpp:
2217         (MainWindow::buildUI): Add QT_NO_INPUTDIALOG, QT_NO_SHORTCUT and
2218         QT_NO_UNDOSTACK guards.
2219         (MainWindow::setAddressUrl): Add QT_NO_INPUTDIALOG guard.
2220         (MainWindow::changeLocation): Ditto.
2221         (MainWindow::openFile): Add QT_NO_FILEDIALOG guard.
2222         (MainWindow::openLocation): Add QT_NO_INPUTDIALOG guard.
2223
2224         * QtTestBrowser/webpage.cpp:
2225         (WebPage::openUrlInDefaultBrowser): Add QT_NO_DESKTOPSERVICES guard.
2226         (WebPage::authenticationRequired): Add QT_NO_LINEEDIT guard.
2227
2228         * QtTestBrowser/webview.cpp:
2229         (WebViewGraphicsBased::animatedFlip): Add QT_NO_ANIMATION guard.
2230         (WebViewGraphicsBased::animatedYFlip): Ditto.
2231
2232 2011-01-10  Sam Weinig  <sam@webkit.org>
2233
2234         Fix build.
2235
2236         * MiniBrowser/mac/BrowserWindowController.m:
2237         (-[BrowserWindowController awakeFromNib]):
2238         * MiniBrowser/win/BrowserView.cpp:
2239         (BrowserView::create):
2240         * WebKitTestRunner/TestController.cpp:
2241         (WTR::createOtherPage):
2242         (WTR::TestController::initialize):
2243
2244 2011-01-10  Eric Seidel  <eric@webkit.org>
2245
2246         Reviewed by Ojan Vafai.
2247
2248         style-queue messages are way too long for big patches
2249         https://bugs.webkit.org/show_bug.cgi?id=52161
2250
2251         We definitely could build much fancier list-to-string-with-limit functions
2252         but this should be sufficient for our needs at the moment.
2253
2254         * Scripts/webkitpy/common/system/executive.py:
2255         * Scripts/webkitpy/common/system/executive_unittest.py:
2256
2257 2011-01-10  Tony Chang  <tony@chromium.org>
2258
2259         Unreviewed, rolling out r75398.
2260         http://trac.webkit.org/changeset/75398
2261         https://bugs.webkit.org/show_bug.cgi?id=52008
2262
2263         Some layout tests are crashing on Chromium Win.
2264
2265         * DumpRenderTree/chromium/WebViewHost.cpp:
2266         (WebViewHost::updatePaintRect):
2267         * DumpRenderTree/chromium/WebViewHost.h:
2268
2269 2011-01-10  Adam Roben  <aroben@apple.com>
2270
2271         Roll out r75392
2272
2273         It isn't needed now that r75289 has been rolled out.
2274
2275         * Scripts/run-javascriptcore-tests:
2276
2277 2011-01-10  Maciej Stachowiak  <mjs@apple.com>
2278
2279         Reviewed by Anders Carlsson.
2280
2281         WebKitTestRunner uses crazy amounts of CPU, making layout tests slow and flaky
2282         https://bugs.webkit.org/show_bug.cgi?id=52160
2283
2284         * WebKitTestRunner/mac/TestControllerMac.mm:
2285         (WTR::TestController::platformRunUntil): Instead of busy-looping, wait for the timeout.
2286         Anything that can make runUntil() conditions turn true will happen on a run loop cycle
2287         anyway.
2288
2289 2011-01-10  Tony Chang  <tony@chromium.org>
2290
2291         Reviewed by Mihai Parparita.
2292
2293         [chromium] fix for animated gif layout tests
2294         https://bugs.webkit.org/show_bug.cgi?id=52008
2295
2296         * DumpRenderTree/chromium/WebViewHost.cpp: Schedule a paint when we update the paint rect
2297             to trigger gif animations.
2298         (WebViewHostPaintTask::WebViewHostPaintTask):
2299         (WebViewHostPaintTask::runIfValid):
2300         (WebViewHost::updatePaintRect):
2301         * DumpRenderTree/chromium/WebViewHost.h:
2302         (WebViewHost::taskList):
2303
2304 2011-01-10  Alejandro G. Castro  <alex@igalia.com>
2305
2306         Reviewed by Xan Lopez.
2307
2308         [GTK] Fix gtk2 compilation for master
2309         https://bugs.webkit.org/show_bug.cgi?id=51885
2310
2311         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
2312         (createBitmapContextFromWebView): Replaced the old
2313         gdk_drawable_get_size with gdk_pixmap_get_size.
2314
2315 2011-01-10  Patrick Gansterer  <paroga@webkit.org>
2316
2317         Reviewed by Laszlo Gombos.
2318
2319         [WINCE] Reenable NPAPI after r75203
2320         https://bugs.webkit.org/show_bug.cgi?id=52109
2321
2322         Remove the !isWinCE() check for ENABLE_NETSCAPE_PLUGIN_API and replace
2323         it with !isEfl(), because EFL port does not support NPAPI (yet).
2324
2325         * Scripts/build-webkit:
2326
2327 2011-01-10  Adam Roben  <aroben@apple.com>
2328
2329         Skip some asserting JS tests
2330
2331         See <http://webkit.org/b/52156>.
2332
2333         * Scripts/run-javascriptcore-tests:
2334
2335 2011-01-10  Martin Robinson  <mrobinson@igalia.com>
2336
2337         Reviewed by Xan Lopez.
2338
2339         [GTK] build-webkit disable Blob support via arguments passed to automake
2340         https://bugs.webkit.org/show_bug.cgi?id=52097
2341
2342         * Scripts/build-webkit: Enable Blob support when building WebKitGTK+ via
2343         build-webkit.
2344
2345 2011-01-10  Adam Roben  <aroben@apple.com>
2346
2347         Use the same name and description for TestNetscapePlugin on Windows and
2348         Mac
2349
2350         Fixes <http://webkit.org/b/52151>
2351         fast/frames/iframe-reparenting-plugins.html fails on Windows
2352
2353         Reviewed by Steve Falkenburg.
2354
2355         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Copied
2356         the name and description from Mac's Info.plist.
2357
2358 2011-01-10  Siddharth Mathur <siddharth.mathur@nokia.com>
2359
2360         Reviewed by Laszlo Gombos.
2361
2362         [Qt][WK2] Guard gcc-specific syntax
2363
2364         Non-gcc based compliers choke on the "-include"
2365         syntax for preinclude, place guard around it.
2366
2367         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2368         * WebKitTestRunner/qt/WebKitTestRunner.pro:
2369
2370 2011-01-10  Andreas Kling  <kling@webkit.org>
2371
2372         Reviewed by Simon Hausmann.
2373
2374         [Qt] [WK2] MiniBrowser does not load pages opened in new windows
2375         https://bugs.webkit.org/show_bug.cgi?id=52111
2376
2377         When getting a createNewPage() callback from QWKPage, create the
2378         new page with the same QWKContext as the page that is passed to
2379         the callback.
2380
2381         * MiniBrowser/qt/BrowserView.h:
2382         * MiniBrowser/qt/BrowserWindow.cpp:
2383         (newPageFunction):
2384         (BrowserWindow::BrowserWindow):
2385         * MiniBrowser/qt/BrowserWindow.h:
2386
2387 2011-01-10  Andreas Kling  <kling@webkit.org>
2388
2389         Reviewed by Kenneth Rohde Christiansen.
2390
2391         [Qt] MiniBrowser: Remove superfluous createNewPage() callback
2392
2393         BrowserView set its own useless createNewPage() callback on QWKPage.
2394         This was immediately overridden by BrowserWindow anyway, so remove
2395         the BrowserView one.
2396
2397         * MiniBrowser/qt/BrowserView.cpp:
2398         (BrowserView::BrowserView):
2399
2400 2011-01-10  John Knottenbelt  <jknotten@chromium.org>
2401
2402         Reviewed by Jeremy Orlow.
2403
2404         [Chromium] Remove non-client-based Geolocation code
2405         https://bugs.webkit.org/show_bug.cgi?id=50921
2406
2407         * DumpRenderTree/chromium/LayoutTestController.cpp:
2408         (LayoutTestController::setGeolocationPermission):
2409         (LayoutTestController::setMockGeolocationPosition):
2410         (LayoutTestController::setMockGeolocationError):
2411         * DumpRenderTree/chromium/WebViewHost.cpp:
2412         (WebViewHost::geolocationClientMock):
2413         (WebViewHost::reset):
2414         * DumpRenderTree/chromium/WebViewHost.h:
2415
2416 2011-01-10  Eric Seidel  <eric@webkit.org>
2417
2418         Reviewed by Adam Barth.
2419
2420         Commit bot tried to land r? cq+ patch
2421         https://bugs.webkit.org/show_bug.cgi?id=36638
2422
2423         It should now be possible to post a patch with r? and cq+ and the
2424         commit-queue will correctly wait for the r+ before attempting to land the patch.
2425         (This was a feature requested by several users.)
2426
2427         One caveat: We don't actually reject r-, cq+ patches from the queue
2428         (we just ignore them), but I think that's OK for now.
2429
2430         I also noticed that setting r- once a commit-queue node had grabbed
2431         a patch would not properly cancel the landing.  That's fixed and
2432         tested in this patch.
2433
2434         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2435         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2436         * Scripts/webkitpy/tool/bot/feeders.py:
2437         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
2438
2439 2011-01-08  Benjamin Poulain  <benjamin.poulain@nokia.com>
2440
2441         Reviewed by Kenneth Rohde Christiansen.
2442
2443         [Qt] QtWebKit crashes when using XMLHttpRequest from the unload event
2444         https://bugs.webkit.org/show_bug.cgi?id=51934
2445
2446         When accessing the network from the destructor of QWebPage, the network access manager
2447         was already deleted because the object WebPage was already destructed.
2448
2449         This solve the problem by linking the lifetime of the network access manager to WebPage's QObject.
2450         The object is now destructed in the destructor of QObject.
2451
2452         * QtTestBrowser/webpage.cpp:
2453         (WebPage::WebPage):
2454         (WebPage::setQnamThreaded):
2455         * QtTestBrowser/webpage.h:
2456         (QtNAMThread::QtNAMThread):
2457
2458 2011-01-08  Eric Seidel  <eric@webkit.org>
2459
2460         Reviewed by Ojan Vafai.
2461
2462         test_failures.py should not mention TestShell (long live DumpRenderTree!)
2463         https://bugs.webkit.org/show_bug.cgi?id=52067
2464
2465         I ran test-webkitpy, but didn't bother adding a unit test for this string change.
2466         https://bugs.webkit.org/show_bug.cgi?id=51138#c3 is an example of why this is needed.
2467
2468         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
2469
2470 2011-01-08  Eric Seidel  <eric@webkit.org>
2471
2472         Reviewed by Mihai Parparita.
2473
2474         commit-queue hangs when the ChangeLog diff is bad
2475         https://bugs.webkit.org/show_bug.cgi?id=52072
2476
2477         * Scripts/webkitpy/tool/steps/validatechangelogs.py:
2478         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
2479
2480 2011-01-08  Adam Barth  <abarth@webkit.org>
2481
2482         Teach svn-apply how to re-write WebCore to Source/WebCore.
2483
2484         * Scripts/VCSUtils.pm:
2485
2486 2011-01-07  Adam Barth  <abarth@webkit.org>
2487
2488         Rubber-stamped by Eric Seidel.
2489
2490         Move WebCore to Source
2491         https://bugs.webkit.org/show_bug.cgi?id=52050
2492
2493         Update the tools to understand WebCore's new location.
2494
2495         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2496         * DumpRenderTree/wscript:
2497         * GNUmakefile.am:
2498         * Scripts/build-webkit:
2499         * Scripts/do-file-rename:
2500         * Scripts/do-webcore-rename:
2501         * Scripts/generate-qt-inspector-resource:
2502         * Scripts/prepare-ChangeLog:
2503         * Scripts/run-bindings-tests:
2504         * Scripts/update-iexploder-cssproperties:
2505         * Scripts/update-sources-list.py:
2506         * Scripts/update-webkit-localizable-strings:
2507         * Scripts/webkitdirs.pm:
2508         * Scripts/webkitpy/common/config/build.py:
2509         * Scripts/webkitpy/common/config/build_unittest.py:
2510         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
2511         * Scripts/webkitpy/style/checker.py:
2512         * Scripts/webkitpy/style/checker_unittest.py:
2513         * WebKitTestRunner/DerivedSources.pro:
2514         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2515         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh:
2516         * wx/browser/wscript:
2517         * wx/build/settings.py:
2518
2519 2011-01-07  Maciej Stachowiak  <mjs@apple.com>
2520
2521         Reviewed by Sam Weinig.
2522
2523         Make WebKitTestRunner rest between loads more robust to avoid test crashes
2524         https://bugs.webkit.org/show_bug.cgi?id=52086
2525
2526         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2527         (WTR::InjectedBundle::didReceiveMessage):
2528         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2529         (WTR::LayoutTestController::notifyDone):
2530         * WebKitTestRunner/TestController.cpp:
2531         (WTR::TestController::resetStateToConsistentValues):
2532         (WTR::TestController::run):
2533
2534 2011-01-07  James Robinson  <jamesr@chromium.org>
2535
2536         Revert "Implement mozilla's animationTime property"
2537         https://bugs.webkit.org/show_bug.cgi?id=51952
2538
2539         This approach isn't quite right.
2540
2541         * DumpRenderTree/chromium/WebViewHost.cpp:
2542         (WebViewHost::paintInvalidatedRegion):
2543
2544 2011-01-07  Adam Roben  <aroben@apple.com>
2545
2546         Build master fix
2547
2548         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2549         (RunWebKitTests.start): Don't try to concatenate a list and a string.
2550
2551 2011-01-07  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>
2552
2553         Reviewed by Csaba Osztrogonác.
2554
2555         run-qtwebkit-tests should be able to kill a testsuite.
2556
2557         Add new option in the script that can setup a timeout for a test.
2558         If the test execution takes more then specified time then the test
2559         would be terminated.
2560
2561         [Qt] run-qtwebkit-tests needs timeout
2562         https://bugs.webkit.org/show_bug.cgi?id=51894
2563
2564         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2565         * Scripts/run-qtwebkit-tests:
2566
2567 2011-01-07  Csaba Osztrogonác  <ossy@webkit.org>
2568
2569         Unreviewed fix after r75233.
2570
2571         Based on idea from Eric Seidel.
2572
2573         Add remote zip file handling to webkitpy.
2574         https://bugs.webkit.org/show_bug.cgi?id=50901
2575
2576         * Scripts/webkitpy/common/system/fileset.py: Make python 2.5 happy.
2577
2578 2011-01-07  Shane Stephens  <shanestephens@google.com>
2579
2580         Reviewed by Eric Seidel.
2581
2582         svn-apply: should support git binary delta diffs
2583         https://bugs.webkit.org/show_bug.cgi?id=38864
2584
2585         * Scripts/VCSUtils.pm:
2586         * Scripts/svn-apply:
2587
2588 2011-01-06  Julie Parent  <jparent@chromium.org>
2589
2590         Reviewed by Eric Seidel.
2591
2592         Test Result Server not removing old results.
2593         https://bugs.webkit.org/show_bug.cgi?id=52012
2594
2595         * TestResultServer/model/jsonresults.py:
2596         Fix off-by-one: Truncate if >= num_runs, not just >.
2597         * TestResultServer/model/jsonresults_unittest.py:
2598         Add unit test to test that merging in a new result with the same value
2599         as the last result causes previous result to fall off.
2600
2601 2011-01-06  James Kozianski  <koz@chromium.org>
2602
2603         Reviewed by Mihai Parparita.
2604
2605         Add classes to provide a consistent interface to a set of files.
2606         https://bugs.webkit.org/show_bug.cgi?id=50901
2607
2608         These classes allow us to write code that is agnostic to whether a
2609         particular set of files resides in a local directory or in a zip file
2610         on a remote machine.
2611
2612         * Scripts/webkitpy/common/system/directoryfileset.py: Added.
2613         * Scripts/webkitpy/common/system/directoryfileset_unittest.py: Added.
2614         * Scripts/webkitpy/common/system/fileset.py: Added.
2615         * Scripts/webkitpy/common/system/filesystem.py:
2616         * Scripts/webkitpy/common/system/filesystem_mock.py:
2617         * Scripts/webkitpy/common/system/zipfileset.py: Added.
2618         * Scripts/webkitpy/common/system/zipfileset_unittest.py: Added.
2619
2620 2011-01-06  Eric Seidel  <eric@webkit.org>
2621
2622         Reviewed by Adam Barth.
2623
2624         NetworkTransaction should log the url it is retrying
2625         https://bugs.webkit.org/show_bug.cgi?id=52043
2626
2627         * Scripts/webkitpy/common/net/networktransaction.py:
2628         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
2629
2630 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
2631
2632         Windows build fix.
2633         Import os before using it.
2634
2635         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2636
2637 2011-01-06  Eric Seidel  <eric@webkit.org>
2638
2639         Reviewed by Adam Barth.
2640
2641         StyleQueue fails to report errors when patches have many files
2642         https://bugs.webkit.org/show_bug.cgi?id=52042
2643
2644         This is one of at least two errors preventing style error reporting at the moment.
2645         When we moved to passing the list of files to check explicitly,
2646         we started to exceed the 500 character TEXT field limit for our AppEngine model object.
2647         We could change the type of the QueueStatus.message type, or we could
2648         just teach statusserver.py how to clamp values (and warn when it does).
2649         I chose the latter path.
2650
2651         * Scripts/webkitpy/common/net/statusserver.py:
2652
2653 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
2654
2655         Reviewed by Stephanie Lewis.
2656         
2657         Fix syntax error in script.
2658
2659         Windows bots need to archive/unarchive builds to/from configuration-specific directories
2660         https://bugs.webkit.org/show_bug.cgi?id=51996
2661
2662         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2663
2664 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2665
2666         Unreviewed, fixing WinCE build after r75196.
2667
2668         WinCE port does not (yet) support NPAPI.
2669
2670         * Scripts/build-webkit:
2671
2672 2011-01-06  Xan Lopez  <xlopez@igalia.com>
2673
2674         Reviewed by Darin Adler.
2675
2676         File::Spec->rel2abs in sunspider-compare-results mangles parameters
2677         https://bugs.webkit.org/show_bug.cgi?id=52015
2678
2679         * Scripts/sunspider-compare-results: call rel2abs on our arguments
2680         after the platform has been detected, otherwise the script will
2681         mangle things like '--gtk' into '/a/path/--gtk', breaking the
2682         detection.
2683
2684 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2685
2686         Reviewed by Eric Seidel.
2687
2688         Add ENABLE_NETSCAPE_PLUGIN_API, ENABLE_ORIENTATION_EVENTS and ENABLE_TOUCH_EVENTS flags to build-webkit
2689         https://bugs.webkit.org/show_bug.cgi?id=51346
2690
2691         * Scripts/build-webkit:
2692
2693 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
2694
2695         Reviewed by Adam Roben.
2696
2697         Windows bots need to archive/unarchive builds to/from configuration-specific directories
2698         https://bugs.webkit.org/show_bug.cgi?id=51996
2699         
2700         After the configuration directory change, we were archiving the incorrect directory for
2701         build product, so we were running tests on the wrong binaries.
2702         
2703         This change archives the correct directory, and also unarchives it into a configuration-
2704         specific directory.
2705
2706         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Use a configuration-specific directory on Windows.
2707         * BuildSlaveSupport/built-product-archive: Unarchive/archive to/from proper directory.
2708
2709 2011-01-06  Eric Seidel  <eric@webkit.org>
2710
2711         Reviewed by Mihai Parparita.
2712
2713         commit-queue mentions "Text diff mismatch" 4 times instead of once per failure
2714         https://bugs.webkit.org/show_bug.cgi?id=52002
2715
2716         See an example of this here:
2717         https://bugs.webkit.org/show_bug.cgi?id=51314#c2
2718
2719         It's due to the fact that we pass around TestFailure() instance
2720         objects and yet expect them to all compare to be the same.
2721
2722         This is bad.  We should either have shared instances of these values
2723         or we should just pass around the class names.  There are already hacks
2724         in place to make TestFailure objects pass equality tests, I just added
2725         a __hash__ implementation so they can be used in sets as expected.
2726
2727         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2728         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
2729
2730 2011-01-06  Evan Martin  <evan@chromium.org>
2731
2732         Reviewed by Tony Chang.
2733
2734         [gdb] handle inaccessible memory and UChar*
2735         https://bugs.webkit.org/show_bug.cgi?id=52003
2736
2737         To pretty-print a UChar*, we just grope around in the memory
2738         looking for a terminating NUL.  We need to handle the exception
2739         that can occur when we poke into an invalid location.
2740
2741         Additionally, the logic for choosing which pretty-printer would
2742         early return before hitting the point where we'd use the UChar*
2743         printer.  (Did this ever work?  How did it regress?)
2744
2745         * gdb/webkit.py:
2746
2747 2011-01-05  Brian Weinstein  <bweinstein@apple.com>
2748
2749         Reviewed by Ada Chan.
2750
2751         WebKit2: Should be able to call into injected bundle to ask if we should allow resource loads
2752         https://bugs.webkit.org/show_bug.cgi?id=51969
2753         
2754         Add shouldLoadResourceForFrame to WTR::InjectedBundlePage.
2755
2756         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2757         (WTR::InjectedBundlePage::InjectedBundlePage):
2758         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Stub implementation.
2759         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2760
2761 2011-01-06  James Robinson  <jamesr@chromium.org>
2762
2763         Reviewed by Simon Fraser.
2764
2765         Implement mozilla's animationTime property
2766         https://bugs.webkit.org/show_bug.cgi?id=51952
2767
2768         Chromium DRT support for webkitAnimationTime.
2769
2770         * DumpRenderTree/chromium/WebViewHost.cpp:
2771         (WebViewHost::paintInvalidatedRegion):
2772
2773 2011-01-06  Julie Parent  <jparent@chromium.org>
2774
2775         Reviewed by Tony Chang.
2776
2777         Test Result Server always truncates number of results to JSON_RESULTS_MAX_BUILDS
2778         https://bugs.webkit.org/show_bug.cgi?id=51217
2779
2780         * TestResultServer/model/jsonresults.py:
2781         Pass num_runs through to _remove_items_over_max_number_of_builds, and use the value.
2782         Adds missing documentation.
2783         * TestResultServer/model/jsonresults_unittest.py:
2784         Add unit test to test that truncation happens at smaller value than JSON_RESULTS_MAX_BUILDS.
2785         Update test_merge to take a number of builds to truncate at.
2786
2787 2011-01-06  Adam Barth  <abarth@webkit.org>
2788
2789         Reviewed by Eric Seidel.
2790
2791         The EWS should log outside of the working directory
2792         https://bugs.webkit.org/show_bug.cgi?id=51986
2793
2794         This patch prepare us for using git clean -x -d -f in the EWS wrapper
2795         script, which will actually clean the working copy back to a pristine
2796         state instead of leaving untracked directories and ignored files.
2797
2798         * Scripts/webkitpy/tool/commands/queues.py:
2799         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2800
2801 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
2802
2803         Windows build fix.
2804         Back out attempted change to built-product-archive.
2805
2806         * BuildSlaveSupport/built-product-archive:
2807
2808 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
2809
2810         Windows build fix.
2811         Include configuration name when unpacking a build archive.
2812
2813         Needed, since we split Windows build results into configuration-specific directories
2814         under WebKitOutputDir.
2815
2816         * BuildSlaveSupport/built-product-archive:
2817
2818 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
2819
2820         Reviewed by Darin Adler.
2821
2822         Debug and Release builds on Windows clobber each other
2823         https://bugs.webkit.org/show_bug.cgi?id=49185
2824
2825         Changes the structure of WebKitBuild build products directory so we
2826         completely separate each build configuration into independent directories.
2827         
2828         Although we previously had per-configuration directories for obj, this change adds
2829         per-configuration directories for bin, lib, obj, and include. Each configuration's
2830         build products are stored within a directory inside of WebKitBuild.
2831         
2832         Most use of $(WebKitOutputDir) in the build files has been replaced by $(ConfigurationBuildDir),
2833         defined in common.vsprops to be $(WebKitOutputDir)\$(ConfigurationName).
2834
2835         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops:
2836         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd:
2837         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd:
2838         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
2839         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd:
2840         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd:
2841         * DumpRenderTree/win/ImageDiffCommon.vsprops:
2842         * DumpRenderTree/win/ImageDiffPostBuild.cmd:
2843         * DumpRenderTree/win/ImageDiffPreBuild.cmd:
2844         * FindSafari/FindSafari.vcproj:
2845         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
2846         * MiniBrowser/MiniBrowserPostBuild.cmd:
2847         * MiniBrowser/MiniBrowserPreBuild.cmd:
2848         * Scripts/webkitdirs.pm:
2849         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
2850         * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops:
2851         * TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd:
2852         * TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd:
2853         * TestWebKitAPI/win/copy-resources.cmd:
2854         * WebKitAPITest/WebKitAPITestCommon.vsprops:
2855         * WebKitAPITest/WebKitAPITestPostBuild.cmd:
2856         * WebKitAPITest/WebKitAPITestPreBuild.cmd:
2857         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
2858         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
2859         * WebKitTestRunner/win/InjectedBundle.vcproj:
2860         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops:
2861         * WebKitTestRunner/win/InjectedBundlePostBuild.cmd:
2862         * WebKitTestRunner/win/InjectedBundlePreBuild.cmd:
2863         * WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd:
2864         * WebKitTestRunner/win/WebKitTestRunnerPreBuild.cmd:
2865         * WinLauncher/WinLauncherCommon.vsprops:
2866         * WinLauncher/WinLauncherPostBuild.cmd:
2867         * WinLauncher/WinLauncherPreBuild.cmd:
2868
2869 2011-01-05  Jan Erik Hanssen  <jhanssen@sencha.com>
2870
2871         Reviewed by Ariya Hidayat.
2872
2873         [Qt] TestNetscapePlugin doesn't link on OS X
2874         https://bugs.webkit.org/show_bug.cgi?id=51948
2875
2876         Only add a dependency on libX11 on X11 systems
2877
2878         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2879
2880 2011-01-05  Jeff Miller  <jeffm@apple.com>
2881
2882         Reviewed by Adam Roben.
2883
2884         check-webkit-style should allow unnecessary parameter names in WebKit2 APIs because we're matching CF's header style
2885         https://bugs.webkit.org/show_bug.cgi?id=51970
2886
2887         * Scripts/webkitpy/style/checker.py:
2888         Add -readability/naming for WebKit2 C API directories.
2889
2890 2011-01-05  Eric Seidel  <eric@webkit.org>
2891
2892         Unreviewed, just fixing one more log error from my previous python patch.
2893
2894         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
2895         https://bugs.webkit.org/show_bug.cgi?id=51802
2896
2897         webkit-patch failure-reason was logging about parsing errors
2898         due to my misunderstanding of how BeautifulSoup.findAll worked.
2899
2900         Fixed, and added a unit test.
2901
2902         * Scripts/webkitpy/common/net/layouttestresults.py:
2903         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2904
2905 2011-01-05  Benjamin Poulain  <benjamin.poulain@nokia.com>
2906
2907         Reviewed by Kenneth Rohde Christiansen.
2908
2909         [Qt] [WK2] Add the possibility to open window from the WebProcess in Minibrowser
2910         https://bugs.webkit.org/show_bug.cgi?id=51951
2911
2912         Set a function to QWKPage::setCreateNewPageFunction() in Minibrowser so there is a way
2913         to create new window from WebKit.
2914
2915         * MiniBrowser/qt/BrowserWindow.cpp:
2916         (newPageFunction):
2917         (BrowserWindow::BrowserWindow):
2918         (BrowserWindow::page): Added to avoid the indirect access to QWKPage spread in the class
2919         (BrowserWindow::newWindow):
2920         (BrowserWindow::updateUserAgentList):
2921         (BrowserWindow::showUserAgentDialog):
2922         * MiniBrowser/qt/BrowserWindow.h: Add the global variable backingStoreTypeForNewWindow to
2923         define the type of the backing store used for new windows.
2924         * MiniBrowser/qt/main.cpp:
2925         (main):
2926
2927 2011-01-05  Eric Seidel  <eric@webkit.org>
2928
2929         Reviewed by Ojan Vafai.
2930
2931         commit-queue should report failure type when reporting flaky tests
2932         https://bugs.webkit.org/show_bug.cgi?id=51900
2933
2934         This patch was a ridiculous amount of plumbing.  In the end I like
2935         the NRWT-style TestResult class even less.  But now we're passing
2936         a list of TestResult objects from the queue to the FlakyTestReporter.
2937         Thus the FlakyTestReporter can more easily report what type of failure
2938         occurred.
2939
2940         In the process, I found that I was not alone in finding TestResult
2941         cumbersome to use.  A bunch of code was trying to create a TestResult
2942         object with default values.  However since the constructor didn't make
2943         this easy, some places were getting it wrong (including the TestResult unit test)!
2944         I've fixed the TestResult constructor to have default values for non-essential
2945         arguments.
2946
2947         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2948         * Scripts/webkitpy/common/net/layouttestresults.py:
2949         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2950         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2951         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2952         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2953         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
2954         * Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py:
2955         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2956         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2957         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2958         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2959         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2960         * Scripts/webkitpy/tool/commands/queues.py:
2961         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2962
2963 2011-01-05  Eric Seidel  <eric@webkit.org>
2964
2965         Unreviewed.
2966
2967         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
2968         https://bugs.webkit.org/show_bug.cgi?id=51802
2969
2970         Add another unit test to cover a previously missing import.
2971
2972         * Scripts/webkitpy/common/net/layouttestresults.py:
2973         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2974
2975 2011-01-05  Mihai Parparita  <mihaip@chromium.org>
2976
2977         Reviewed by David Levin.
2978
2979         Add mihaip@chromium.org as a reviewer
2980         https://bugs.webkit.org/show_bug.cgi?id=51966
2981         
2982         Add myself as a reviewer.
2983
2984         * Scripts/webkitpy/common/config/committers.py:
2985
2986 2011-01-05  James Simonsen  <simonjam@chromium.org>
2987
2988         Unreviewed. Adding myself to the list of committers.
2989
2990         * Scripts/webkitpy/common/config/committers.py:
2991
2992 2011-01-05  Eric Seidel  <eric@webkit.org>
2993
2994         Unreviewed.
2995
2996         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
2997         https://bugs.webkit.org/show_bug.cgi?id=51802
2998
2999         Fix two exceptions seen on the bots after my original commit.
3000
3001         * Scripts/webkitpy/common/net/layouttestresults.py:
3002         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3003
3004 2011-01-05  Kundu Suchismita  <suchi.kundu@nokia.com>
3005
3006         Reviewed by Andreas Kling.
3007
3008         [Qt]Add local storage settings to QtTestBrowser command line arguments 
3009         https://bugs.webkit.org/show_bug.cgi?id=51750
3010
3011         * QtTestBrowser/main.cpp:
3012         (LauncherApplication::handleUserOptions):
3013          Local storage settings can be enable form command line arguments for
3014          QtTestBrowser.
3015
3016 2011-01-05  Chris Fleizach  <cfleizach@apple.com>
3017
3018         Reviewed by Martin Robinson.
3019
3020         GTK: AX: DRT needs to use correct root object method.
3021         https://bugs.webkit.org/show_bug.cgi?id=51911
3022
3023         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
3024         (AccessibilityController::rootElement):
3025
3026 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
3027
3028         Rubber-stamped by Csaba Osztrogonác.
3029
3030         Based on idea from Péter Gál.
3031
3032         * Scripts/webkitpy/tool/bot/sheriff.py: Remove unnecessary apostrophes around revision numbers.
3033
3034 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
3035
3036         Reviewed by Adam Barth.
3037
3038         sheriff-bot should be able to do multi-revision rollouts
3039         https://bugs.webkit.org/show_bug.cgi?id=51176
3040
3041         * Scripts/webkitpy/tool/bot/irc_command.py:
3042         * Scripts/webkitpy/tool/bot/sheriff.py:
3043         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
3044
3045 2011-01-05  Eric Seidel  <eric@webkit.org>
3046
3047         Reviewed by Adam Barth.
3048
3049         queues.webkit.org should have per-bot status pages
3050         https://bugs.webkit.org/show_bug.cgi?id=51906
3051
3052         Just adds a /queue-status/QUEUE_NAME/bots/BOT_ID page to show
3053         statuses from a single queue.  Now that we have many bots servicing
3054         some queues (commit-queue, win-ews, etc.) its easy to have the messages
3055         you care about scroll off the end of the 15-message limit on the main page.
3056
3057         Eventually we should probably rename /queue-status to /queue or /queues,
3058         but that's fodder for another patch.
3059
3060         * QueueStatusServer/handlers/queuestatus.py:
3061         * QueueStatusServer/index.yaml:
3062         * QueueStatusServer/main.py:
3063         * QueueStatusServer/templates/includes/singlequeuestatus.html:
3064          - This probably should use a custom filter instead of hard-coding
3065            the URL scheme here, but I couldn't figure out how to easily
3066            create such a filter.  Most filters work with "strings" so we can't
3067            pass the status object.  We could add a method to the status
3068            object and call that, but that seemed a bit strange too.
3069         * QueueStatusServer/templates/queuestatus.html:
3070
3071 2011-01-05  Carlos Garcia Campos  <cgarcia@igalia.com>
3072
3073         Unreviewed. Adding myself to the list of committers.
3074
3075         * Scripts/webkitpy/common/config/committers.py:
3076
3077 2011-01-04  Koan-Sin Tan  <koansin.tan@gmail.com>
3078
3079         Reviewed by David Levin.
3080
3081         check-webkit-style treated some macros with parentheses after #elif as function calls
3082         https://bugs.webkit.org/show_bug.cgi?id=51695
3083
3084         Ingore function call space checking in any preprocessor directives
3085         (things starting with #). Change search() to match() because 
3086         preprocessor directives are supposed to be in the beginning of lines.
3087
3088         * Scripts/webkitpy/style/checkers/cpp.py:
3089         * Scripts/webkitpy/style/checkers/cpp_unittest.py: make sure there is no false positives for #elif cases
3090
3091 2011-01-04  Søren Gjesse  <sgjesse@chromium.org>
3092
3093         Reviewed by Tony Chang.
3094
3095         Change the --multi-load test option to --stress-opt
3096         https://bugs.webkit.org/show_bug.cgi?id=50751
3097
3098         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3099         (runTest):
3100         (main):
3101         * DumpRenderTree/chromium/TestShell.cpp:
3102         (TestShell::TestShell):
3103         * DumpRenderTree/chromium/TestShell.h:
3104         (TestShell::stressOpt):
3105         (TestShell::setStressOpt):
3106         (TestShell::stressDeopt):
3107         (TestShell::setStressDeopt):
3108         (TestShell::javaScriptFlags):
3109         (TestShell::setJavaScriptFlags):
3110         * Scripts/webkitpy/layout_tests/port/chromium.py:
3111         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3112
3113 2011-01-04  Chris Fleizach  <cfleizach@apple.com>
3114
3115         Reviewed by Sam Weinig.
3116
3117         WK2: Support Accessibility
3118         https://bugs.webkit.org/show_bug.cgi?id=51859
3119
3120         Use rootObject() method to get top of accessibility tree.
3121
3122         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
3123         (AccessibilityController::focusedElement):
3124         (AccessibilityController::rootElement):
3125
3126 2011-01-03  Martin Robinson  <mrobinson@igalia.com>
3127
3128         Reviewed by Darin Adler.
3129
3130         Remove the last non-GObject usage of PlatformRefPtr and move the code to GRefPtr
3131         https://bugs.webkit.org/show_bug.cgi?id=51846
3132
3133         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: Change usage of PlatformRefPtr
3134         back to GRefPtr.
3135
3136 2011-01-04  Zhe Su  <suzhe@chromium.org>
3137
3138         Reviewed by Kenneth Russell.
3139
3140         Fix insertText, setMarkedText and unmarkText methods of
3141         TextInputController to call corresponding methods of WebKit::WebView
3142         rather than WebKit::WebFrame. This change matches the behavior of
3143         chromium browser.
3144         insertText corresponds to WebView::confirmComposition(text)
3145         setMarkedText corresponds to WebView::setComposition(...)
3146         unmarkText corresponds to WebView::confirmComposition()
3147         https://bugs.webkit.org/show_bug.cgi?id=51693
3148
3149         * DumpRenderTree/chromium/TextInputController.cpp:
3150         (TextInputController::insertText):
3151         (TextInputController::setMarkedText):
3152         (TextInputController::unmarkText):
3153
3154 2011-01-04  Dihan Wickremasuriya  <dihan.wickremasuriya@nokia.com>
3155
3156         Reviewed by Laszlo Gombos.
3157
3158         [Qt] [Symbian] Do not remove 0 byte sized files from productDir
3159
3160         On Symbian productDir points to the source directory. Removing all the
3161         empty files from the productDir directory corrupts the svn repository.
3162
3163         * Scripts/build-webkit:
3164
3165 2011-01-03  Yi Shen  <yi.4.shen@nokia.com>
3166
3167         Reviewed by Adam Barth.
3168
3169         [Qt] Add SelectAll option to the context menu for the editor
3170         https://bugs.webkit.org/show_bug.cgi?id=50049
3171
3172         Set shortcut for the SelectAll action.
3173
3174         * QtTestBrowser/mainwindow.cpp:
3175         (MainWindow::buildUI):
3176
3177 2011-01-03  David Levin  <levin@chromium.org>
3178
3179         Reviewed by Eric Seidel.
3180
3181         check-webkit-style shouldn't consider "value" automatically to be a meaningless name.
3182         https://bugs.webkit.org/show_bug.cgi?id=51842
3183
3184         * Scripts/webkitpy/style/checkers/cpp.py: Remove the check for value.
3185         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Remove the test for value.
3186
3187 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
3188
3189         Reviewed by David Kilzer.
3190
3191         [WINCE] Adds a build slave.
3192         https://bugs.webkit.org/show_bug.cgi?id=50523
3193
3194         * BuildSlaveSupport/build.webkit.org-config/config.json: Add an
3195         entry for a release build of the WinCE port.
3196         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add platform
3197         flag to build the WinCE port.
3198
3199 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
3200
3201         Reviewed by David Kilzer.
3202
3203         Add WinCE support to build-webkit
3204         https://bugs.webkit.org/show_bug.cgi?id=51642
3205
3206         * Scripts/build-webkit:
3207         * Scripts/webkitdirs.pm:
3208
3209 2011-01-03  Eric Seidel  <eric@webkit.org>
3210
3211         Reviewed by Adam Barth.
3212
3213         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
3214         https://bugs.webkit.org/show_bug.cgi?id=51802
3215
3216         I'm not the biggest fan of the test_failures or test_results classes,
3217         but it's better to have one shared set of classes, than separate ones
3218         for new vs. old run-webkit-test result handling.
3219
3220         This moves the ORWT results class "LayoutTestResults" over to using
3221         TestResult and TestFailure classes, making it easy for us to
3222         make all our sheriff-bot and other webkitpy code NRWT ready.
3223
3224         This also makes it a trivial patch to generate results.json information
3225         from ORWT results.html files (for flaky test analysis, etc.) as well
3226         as making it a one-liner to report test failure types when the
3227         commit-queue sees flaky tests.
3228
3229         This patch tried not to add new functionality, but only to replace
3230         the guts of LayoutTestResults, while adding unit tests and hoping
3231         not to break anything.
3232
3233         I also moved callers which assumed User.prompt* were static/class methods
3234         to using them as instance methods (since we'll eventually want to make them such).
3235
3236         In the process of re-writing things, I broke the rebaseline command, so I wrote
3237         a unit test to catch my breakage were I do do so again in the future.
3238
3239         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3240         * Scripts/webkitpy/common/net/layouttestresults.py:
3241         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3242         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
3243         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
3244         * Scripts/webkitpy/tool/commands/queries.py:
3245         * Scripts/webkitpy/tool/commands/rebaseline.py:
3246         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3247         * Scripts/webkitpy/tool/mocktool.py:
3248
3249 2011-01-03  Adam Barth  <abarth@webkit.org>
3250
3251         Reviewed by Simon Fraser.
3252
3253         webkit-patch shouldn't waste time cleaning a working directory that's already clean
3254         https://bugs.webkit.org/show_bug.cgi?id=51840
3255
3256         * Scripts/webkitpy/common/checkout/scm.py:
3257
3258 2011-01-03  Adam Barth  <abarth@webkit.org>
3259
3260         Reviewed by Simon Fraser.
3261
3262         webkit-patch should only hide update output if --quiet
3263         https://bugs.webkit.org/show_bug.cgi?id=51838
3264
3265         As requested by smfr.
3266
3267         * Scripts/webkitpy/tool/steps/update.py:
3268
3269 2011-01-03  Adam Barth  <abarth@webkit.org>
3270
3271         Reviewed by David Levin.
3272
3273         commit-queue shouldn't reject patches twice if two bots process the same patch
3274         https://bugs.webkit.org/show_bug.cgi?id=51805
3275
3276         Before raising an error, we first check whether the patch is still in
3277         the commit-queue.  This check is still racy, of course, but the time
3278         window is much smaller.
3279
3280         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3281
3282 2011-01-03  Sam Weinig  <sam@webkit.org>
3283
3284         Reviewed by Anders Carlsson.
3285
3286         Make run-api-tests less chatty.
3287         https://bugs.webkit.org/show_bug.cgi?id=51831
3288
3289         - Make script quiet by default and add --verbose option (replacing --quiet).
3290         - When not verbose, pipe stdout and stderr to devnull.
3291
3292         * Scripts/run-api-tests:
3293
3294 2011-01-03  Pratik Solanki  <psolanki@apple.com>
3295
3296         Unreviewed. Adding myself to committers.py.
3297
3298         * Scripts/webkitpy/common/config/committers.py:
3299
3300 2011-01-03  Koan-Sin Tan  <koansin.tan@gmail.com>
3301
3302         Reviewed by Xan Lopez.
3303
3304         "Tool/Scripts/run-launcher --gtk" stopped working after 74855
3305         https://bugs.webkit.org/show_bug.cgi?id=51806
3306
3307         Originally, the $libraryName is 'JavaScriptCore'. When building release 
3308         one, the $libraryDir was 'WebKitBuild/Release/JavaScriptCore/../.libs/'
3309         which doesn't exist anymore ('WebKitBuild/Release/JavaScriptCore'
3310         is 'WebKitBuild/Release/Source/JavaScriptCore' now), and 
3311         'WebKitBuild/Release/Source/JavaScriptCore/../../.libs' looks weird,
3312         so make it 'WebKitBuild/Release/.libs'
3313
3314         * Scripts/webkitdirs.pm: 
3315
3316 2011-01-02  Patrick Gansterer  <paroga@webkit.org>
3317
3318         Reviewed by Adam Barth.
3319
3320         Make EFL a core builder
3321         https://bugs.webkit.org/show_bug.cgi?id=51804
3322
3323         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
3324         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3325
3326 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
3327
3328         [Qt] Unreviewed fix after r74855 and r74875.
3329
3330         * BuildSlaveSupport/built-product-archive:
3331          - Create directories explicitly.
3332          - Pass shell=True to subprocess.call().
3333
3334 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
3335
3336         [Qt] Unreviewed fix after r74855.
3337
3338         Move JavaScriptCore to Source
3339         https://bugs.webkit.org/show_bug.cgi?id=51604
3340
3341         * BuildSlaveSupport/built-product-archive: JavaScriptCore -> Source/JavaScriptCore
3342
3343 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
3344
3345         [Qt] Unreviewed run-javasriptcore-tests fix after r74855.
3346
3347         Move JavaScriptCore to Source
3348         https://bugs.webkit.org/show_bug.cgi?id=51604
3349
3350         * Scripts/webkitdirs.pm:
3351
3352 2011-01-02  Robert Hogan  <robert@webkit.org>
3353
3354         Unreviewed, build fix.
3355
3356         [Qt] Fix DRT build after 74855
3357
3358         * DumpRenderTree/qt/DumpRenderTree.pro:
3359
3360 2011-01-01  Adam Barth  <abarth@webkit.org>
3361
3362         Remove the assumption from the Qt and Gtk builds that every project is
3363         in the root directory.
3364
3365         * Scripts/build-webkit:
3366
3367 2011-01-01  Adam Barth  <abarth@webkit.org>
3368
3369         Reviewed by Eric Seidel.
3370
3371         Teach svn-apply how to apply patches even though JavaScriptCore has moved
3372         https://bugs.webkit.org/show_bug.cgi?id=51796
3373
3374         After this change, svn-apply will magically apply patches to
3375         JavaScriptCore/foo to Source/JavaScriptCore/foo.
3376
3377         * Scripts/VCSUtils.pm:
3378
3379 2011-01-01  Adam Barth  <abarth@webkit.org>
3380
3381         Reviewed by Eric Seidel.
3382
3383         Move JavaScriptCore to Source
3384         https://bugs.webkit.org/show_bug.cgi?id=51604
3385
3386         Update references to JavaScriptCore to point to the new location.
3387
3388         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3389         * DumpRenderTree/qt/DumpRenderTree.pro:
3390         * DumpRenderTree/qt/ImageDiff.pro:
3391         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3392         * DumpRenderTree/wscript:
3393         * Scripts/build-jsc:
3394         * Scripts/build-webkit:
3395         * Scripts/do-file-rename:
3396         * Scripts/do-webcore-rename:
3397         * Scripts/run-javascriptcore-tests:
3398         * Scripts/update-javascriptcore-test-results:
3399         * Scripts/webkitdirs.pm:
3400         * Scripts/webkitpy/common/config/build_unittest.py:
3401         * Scripts/webkitpy/style/checker.py:
3402         * Scripts/webkitpy/style/checker_unittest.py:
3403         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3404         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3405         * WebKitTestRunner/qt/WebKitTestRunner.pro:
3406         * wx/build/settings.py:
3407
3408 2011-01-01  Adam Barth  <abarth@webkit.org>
3409
3410         Reviewed by Eric Seidel.
3411
3412         Move Sources to Source
3413         https://bugs.webkit.org/show_bug.cgi?id=51794
3414
3415         Update scripts to point to the new location.
3416
3417         * Scripts/build-webkit:
3418         * Scripts/do-file-rename:
3419         * Scripts/do-webcore-rename:
3420         * Scripts/webkitpy/common/config/build.py:
3421         * Scripts/webkitpy/common/config/build_unittest.py:
3422
3423 2010-12-31  Kent Tamura  <tkent@chromium.org>
3424
3425         Reviewed by Eric Seidel.
3426
3427         [DRT/Chromium] Enable mock spell checker on non-OSX
3428         https://bugs.webkit.org/show_bug.cgi?id=51401
3429
3430         * DumpRenderTree/chromium/WebViewHost.cpp:
3431         (WebViewHost::spellCheck):
3432
3433 2010-12-31  Adam Barth  <abarth@webkit.org>
3434
3435         Reviewed by Ariya Hidayat.
3436
3437         Remove Tools/Scripts/wkstyle
3438         https://bugs.webkit.org/show_bug.cgi?id=51774
3439
3440         This script appears to not have been touched in a while and seems to
3441         have been replaced by check-webkit-style.
3442
3443         * Scripts/wkstyle: Removed.
3444
3445 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
3446
3447         Unreviewed. Coding style fix.
3448
3449         * DumpRenderTree/chromium/TestShell.h:
3450
3451 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
3452
3453         Reviewed by Pavel Feldman.
3454
3455         Web Inspector: [Chromium] Inspector's tests are very slow on Win(Dbg).
3456
3457         It was a problem with Chromium DRT. DevToolsAgent object instance was
3458         attached not only to the inspected page but to the DevTools window too.
3459         As result all the inspector files were interpreted as a content of inspected page
3460         and were transfered to the DevTools scripts panel for debugging etc.
3461
3462         https://bugs.webkit.org/show_bug.cgi?id=51735
3463
3464         * DumpRenderTree/chromium/TestShell.cpp:
3465         (TestShell::TestShell):
3466         (TestShell::bindJSObjectsToWindow):
3467         (TestShell::createNewWindow):
3468         * DumpRenderTree/chromium/TestShell.h:
3469
3470 2010-12-31  Adam Barth  <abarth@webkit.org>
3471
3472         Rubber-stamped by Eric Seidel.
3473
3474         Move PageLoadTests to PerformanceTests/PageLoad
3475         https://bugs.webkit.org/show_bug.cgi?id=51771
3476
3477         Update references to PageLoadTests to point to the new location.
3478
3479         * Scripts/run-pageloadtest:
3480         * Scripts/webkitpy/common/config/build.py:
3481
3482 2010-12-31  Adam Barth  <abarth@webkit.org>
3483
3484         Rubber-stamped by Eric Seidel.
3485
3486         Move SunSpider into PerformanceTests
3487         https://bugs.webkit.org/show_bug.cgi?id=51769
3488
3489         Update these scripts to point to the new location.
3490
3491         * Scripts/run-sunspider:
3492         * Scripts/sunspider-compare-results:
3493
3494 2010-12-30  Mihai Parparita  <mihaip@chromium.org>
3495
3496         Reviewed by Kent Tamura.
3497
3498         [Chromium] Add WebThemeEngineDRTMac so that Chromium DRT scrollbar rendering can match the Mac port's
3499         https://bugs.webkit.org/show_bug.cgi?id=51728
3500         
3501         Add implementation of the Mac WebThemeEngine that uses an NSScroller
3502         to render top-level scrollbars. This makes them match the Mac port's
3503         use of an NSScrollView, which means that we'll be able to share more
3504         pixel baselines.
3505         
3506         The new rendering code will not be activated until the 
3507         USE_WEB_THEME_ENGINE_TO_PAINT_THUMB #define is fliped in
3508         ScrollbarThemeChromiumMac.
3509
3510         * DumpRenderTree/DumpRenderTree.gypi:
3511         * DumpRenderTree/chromium/TestShellMac.mm:
3512         (platformInit):
3513         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Added.
3514         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Added.
3515         (+[FakeActiveWindow alwaysActiveWindow]):
3516         (+[FakeActiveWindow alwaysInactiveWindow]):
3517         (-[FakeActiveWindow initWithActiveControls:]):
3518         (-[FakeActiveWindow _hasActiveControls]):
3519         (WebThemeEngineDRTMac::paintScrollbarThumb):
3520         (stateToHIEnableState):
3521         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
3522         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
3523
3524 2010-12-30  Konstantin Tokarev  <annulen@yandex.ru>
3525
3526         Reviewed by David Kilzer.
3527
3528         [Qt] Don't build wtf/TCSystemAlloc.cpp if --system-malloc option is
3529         used
3530         https://bugs.webkit.org/show_bug.cgi?id=51672
3531
3532         * DumpRenderTree/qt/DumpRenderTree.pro: Replaced USE_SYSTEM_MALLOC
3533         with USE_SYSTEM_MALLOC=1
3534         * WebKitTestRunner/qt/WebKitTestRunner.pro: Replaced USE_SYSTEM_MALLOC
3535         with USE_SYSTEM_MALLOC=1
3536
3537 2010-12-30  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3538
3539         Reviewed by David Kilzer.
3540
3541         [Qt] [Symbian] Fix build-webkit script for Symbian
3542         https://bugs.webkit.org/show_bug.cgi?id=51509
3543
3544         Set the OUTPUT_DIR for Symbian to be the same as the source
3545         directory.
3546
3547         * Scripts/webkitdirs.pm:
3548
3549 2010-12-30  Martin Robinson  <mrobinson@igalia.com>
3550
3551         Reviewed by Darin Adler.
3552
3553         check-webkit-style should ignore NULL usage in calls to gtk_widget_style_get
3554         https://bugs.webkit.org/show_bug.cgi?id=51758
3555
3556         Add a check-webkit-style exception for gtk_widget_style_get and NULL usage.
3557
3558         * Scripts/webkitpy/style/checkers/cpp.py: Add the exception.
3559         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Add some tests for this.
3560
3561 2010-12-29  Patrick Gansterer  <paroga@webkit.org>
3562
3563         Unreviewed WinCE buildfix.
3564
3565         * WinCELauncher/main.cpp: Add missing include.
3566
3567 2010-12-29  Daniel Bates  <dbates@rim.com>
3568
3569         Reviewed by Darin Adler.
3570
3571         svn-apply updates date of wrong change log entry for a change log diff that
3572         contains two consecutive entries with the same author and date
3573         https://bugs.webkit.org/show_bug.cgi?id=46061
3574
3575         Fixes an issue where the date of the wrong change log entry may be modified.
3576         Moreover, changes fixChangeLogPatch() to move entries inserted earlier
3577         in a ChangeLog file to the top of the file.
3578
3579         Currently, fixChangeLogPatch() explicitly bails out and returns an unchanged
3580         diff when it detects that the diff inserts a change log entry earlier in a
3581         ChangeLog. It is unusual to land a patch that has such a deliberate ChangeLog
3582         change. With the advent of the commit-queue this functionality of bailing out
3583         and hence landing the patch as-is is harmful to the accuracy of the ChangeLog.
3584         Instead, we should always move the change log entry to the top of the ChangeLog file.
3585
3586         A side-effect of this change is that setChangeLogDateAndReviewer() now updates
3587         the date line of the correct change log entry in a ChangeLog diff.
3588
3589         * Scripts/VCSUtils.pm: Modified fixChangeLogPatch() to move entries inserted earlier to the top.
3590
3591         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
3592           Updated the following unit tests now that we move entries inserted earlier to the top:
3593           - "fixChangeLogPatch: New entry inserted in middle."
3594             (formerly named "fixChangeLogPatch: [no change] New entry inserted in middle.")
3595
3596           - "fixChangeLogPatch: New entry inserted earlier in the file, but after an entry with the same author and date."
3597             (formerly named "fixChangeLogPatch: [no change] New entry inserted earlier in the file, but after an entry with the same author and date.")
3598
3599         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatchThenSetChangeLogDateAndReviewer.pl: Added.
3600
3601 2010-12-29  Konstantin Tokarev  <annulen@yandex.ru>
3602
3603         Reviewed by Eric Seidel.
3604
3605         [Qt] Fixed compatibility with gold linker on X11 platforms
3606         https://bugs.webkit.org/show_bug.cgi?id=51700
3607
3608         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3609         Linked TestNetscapePlugin with libX11 on Unix platforms
3610
3611 2010-12-29  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>
3612
3613         Reviewed by Darin Adler.
3614
3615         Circular dependency in webkitpy.common.checkout.changelog module
3616         https://bugs.webkit.org/show_bug.cgi?id=50475
3617
3618         Remove automatic import of api.Checkout module when any checkout/
3619         submodule is imported (e.g.: when checkout.scm.Git is imported).
3620
3621         * Scripts/webkitpy/common/checkout/__init__.py:
3622
3623 2010-12-29  Martin Robinson  <mrobinson@igalia.com>
3624
3625         Reviewed by Ojan Vafai.
3626
3627         prepare-ChangeLog should support the -g option for specifying the git-commit
3628         https://bugs.webkit.org/show_bug.cgi?id=51708
3629
3630         Add a -g shortcut for the --git-commit prepare-ChangeLog option. This matches
3631         webkit-patch, though the exact meaning of the two options remain different.
3632
3633         * Scripts/prepare-ChangeLog: Add -g.
3634
3635 2010-12-29  Kent Hansen  <kent.hansen@nokia.com>
3636
3637         Reviewed by Simon Hausmann.
3638
3639         [Qt] Fix compilation with Qt in namespace
3640         https://bugs.webkit.org/show_bug.cgi?id=51701
3641
3642         * QtTestBrowser/webview.h:
3643
3644 2010-12-28  Daniel Bates  <dbates@rim.com>
3645
3646         Reviewed by Sam Weinig.
3647
3648         Substitute // MARK: for compiler-specific #pragma mark
3649         https://bugs.webkit.org/show_bug.cgi?id=51657
3650
3651         Fix future compilation warnings about "#pragma mark" on GTK+ bots by
3652         substituting  "// MARK:" for "#pragma mark", which provides
3653         analogous code-bookmarking functionality under Xcode.
3654
3655         Also, for consistency, we should substitute "// MARK:" for compiler-
3656         specific "#pragma mark" in the source files for the Mac port.
3657
3658         * DumpRenderTree/AccessibilityTextMarker.cpp:
3659         * DumpRenderTree/cf/WebArchiveDumpSupport.h:
3660         * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm:
3661         * DumpRenderTree/mac/ObjCController.m:
3662         * MiniBrowser/mac/AppDelegate.m:
3663         * MiniBrowser/mac/BrowserWindowController.m:
3664
3665 2010-12-28  Xan Lopez  <xlopez@igalia.com>
3666
3667         Reviewed by Eric Seidel.
3668
3669         Add --no-build option to run-sunspider
3670         https://bugs.webkit.org/show_bug.cgi?id=51658
3671
3672         * Scripts/run-sunspider: add --no-build flag to skip building
3673         phase.
3674
3675 2010-12-27  Daniel Bates  <dbates@rim.com>
3676
3677         Rubber-stamped by Martin Robinson.
3678
3679         Append the directory Tools/DumpRenderTree to the list of directories that
3680         do-webcore-rename should search so that it can rename DRT files and
3681         source code.
3682
3683         * Scripts/do-webcore-rename:
3684
3685 2010-12-27  Eric Seidel  <eric@webkit.org>
3686
3687         Reviewed by Adam Barth.
3688
3689         build-webkit should detect missing Java SDK and explain how to install it
3690         https://bugs.webkit.org/show_bug.cgi?id=51651
3691
3692         * Scripts/build-webkit:
3693
3694 2010-12-26  Martin Robinson  <mrobinson@igalia.com>
3695
3696         Reviewed by Daniel Bates.
3697
3698         [GTK] Add support for build-jsc
3699         https://bugs.webkit.org/show_bug.cgi?id=51625
3700
3701         Add GTK+ support to build-jsc now that building the jsc executable as
3702         a standalone target is easy.
3703
3704         * Scripts/build-jsc: Call buildGtkProject for the GTK+ case now.
3705         * Scripts/build-webkit: Pass in the proper target name to buildGtkProject.
3706         * Scripts/webkitdirs.pm: Actually process the project parameter in buildGtkProject
3707         and pass it along to buildAutotoolsProject.
3708
3709 2010-12-27  David Levin  <levin@chromium.org>
3710
3711         Reviewed by Eric Seidel.
3712
3713         check-webkit-style check for meaningless variable names in function declarations.
3714         https://bugs.webkit.org/show_bug.cgi?id=51523
3715
3716         * Scripts/webkitpy/style/checker.py: Exempted JavaScriptCore/jit/JITStubs.cpp
3717         from the new check and whitespace/parens because the syntax is unusual and
3718         produced a fair number of positives for these checks.
3719         * Scripts/webkitpy/style/checkers/cpp.py:
3720         (_convert_to_lower_with_underscores): Used as a canonical form for type names
3721         and parameter names when determining if the parameter name is useless.
3722         (_create_acronym): Used to check for redundant variable names in cases like "ExceptionCode ec"
3723         (Parameter.lower_with_underscores_name): Gives back the parameter name in a lower_with_underscore
3724         format.
3725         (_check_parameter_name_against_text):  Checks to see if the parameter name is in the
3726         text or an acronym of it.
3727         (check_function_definition): Checks function definitions for meaningless variable names.
3728         (process_line): Added call to check_function_definition.
3729         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3730         (CppFunctionsTest.test_convert_to_lower_with_underscores): Test for _convert_to_lower_with_underscores.
3731         (CppFunctionsTest.test_create_acronym): Test for _create_acronym.
3732         (CppFunctionsTest.test_check_parameter_against_text): Test for _check_parameter_against_text.
3733         (CppStyleTestBase.perform_single_line_lint): Removed the parameter name check
3734         because when only checking a snippet, there are a lot of bogus functions.
3735         (CppStyleTestBase.perform_multi_line_lint): Ditto and removed a bogus filter
3736         that I put there previously and just noticed.
3737         (WebKitStyleTest.test_parameter_names): Tests for the functionality -- both
3738         check_function_definition and process_line.
3739
3740 2010-12-27  Carlos Garcia Campos  <cgarcia@igalia.com>
3741
3742         Reviewed by Martin Robinson.
3743
3744         [GTK] Disable flash plugin in GtkLauncher when using gtk3
3745         https://bugs.webkit.org/show_bug.cgi?id=51591
3746
3747         Flash plugin uses gtk2 that is incompatible with gtk3 making
3748         webkit crash when it's built with gtk3.
3749
3750         * GtkLauncher/main.c:
3751         (main):
3752
3753 2010-12-25  Adam Barth  <abarth@webkit.org>
3754
3755         Reviewed by Eric Seidel.
3756
3757         Move ANGLE to Sources/ThirdParty
3758         https://bugs.webkit.org/show_bug.cgi?id=51605
3759
3760         * Scripts/build-webkit:
3761           - Point to the new ANGLE location.
3762
3763 2010-12-26  David Levin  <levin@chromium.org>
3764
3765         Reviewed by Eric Seidel.
3766
3767         check-webkit-style should be able to parse function declaration parameters.
3768         https://bugs.webkit.org/show_bug.cgi?id=51451
3769
3770         * Scripts/webkitpy/style/checkers/cpp.py:
3771         (Position.__init__): Holds simple position information (row, column).
3772         (Parameter.__init__): Holds information about a parameter.
3773         (SingleLineView.__init): Converts multiple lines into a single line for simpler searches.
3774         (SingleLineView.convert_column_to_row): Returns the original row given a column.
3775         (create_skeleton_parameters): Simplifies a parameter list for easier searching.
3776         (find_parameter_name_index): Finds where the parameter name is.
3777         (parameter_list): Generates the list of parameters for a function.
3778         (_FunctionState.begin): Added information to allow determining the parameters
3779         on demand.
3780         (_FunctionState.get_parameter_list): Returns a tuple of function parameters.
3781         (detect_functions): Improve function detection for operator functions and
3782         determine where the parameters end and pass that to _FunctionState.begin.
3783         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3784         (CppFunctionsTest.test_parameter): Verifies Parameter functionality.
3785         (CppFunctionsTest.test_single_line_view): Verifies SingleLineView functionality.
3786         (CppFunctionsTest.test_create_skeleton_parameters): Verifies create_skeleton_parameters.
3787         (CppFunctionsTest.test_find_parameter_name_index): Verifies find_parameter_name_index.