a8857b16a450aeb7406be5a31452724a64add42e
[WebKit.git] / Tools / ChangeLog
1 2011-02-05  Sheriff Bot  <webkit.review.bot@gmail.com>
2
3         Unreviewed, rolling out r77720.
4         http://trac.webkit.org/changeset/77720
5         https://bugs.webkit.org/show_bug.cgi?id=53854
6
7         "Broke nrwt on Chromium win." (Requested by dglazkov|away on
8         #webkit).
9
10         * Scripts/webkitpy/common/system/executive.py:
11
12 2011-02-05  Sheriff Bot  <webkit.review.bot@gmail.com>
13
14         Unreviewed, rolling out r77725.
15         http://trac.webkit.org/changeset/77725
16         https://bugs.webkit.org/show_bug.cgi?id=53844
17
18         It broke Qt minimal build (Requested by Ossy_ on #webkit).
19
20         * QtTestBrowser/launcherwindow.cpp:
21         (LauncherWindow::createChrome):
22         * QtTestBrowser/launcherwindow.h:
23         (WindowOptions::WindowOptions):
24         * QtTestBrowser/main.cpp:
25         (LauncherApplication::handleUserOptions):
26
27 2011-02-04  Martin Robinson  <mrobinson@igalia.com>
28
29         Reviewed by Adam Barth.
30
31         [GTK] plugins/plugin-document-back-forward.html fails
32         https://bugs.webkit.org/show_bug.cgi?id=53833
33
34         Add the new "alert on load" functionality for the Unix version of the
35         test plugin. This functionality was originally introduced in r77706.
36
37         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
38         (webkit_test_plugin_new_instance): Add new plugin fuctionality.
39
40 2011-02-04  Kundu Suchismita  <suchi.kundu@nokia.com>
41
42         Reviewed by Andreas Kling.
43
44         Local Storage settings can be enable/disable from "Develop" menu
45         https://bugs.webkit.org/show_bug.cgi?id=52296
46
47         * QtTestBrowser/launcherwindow.cpp:
48         (LauncherWindow::createChrome):
49         (LauncherWindow::toggleLocalStorage):
50         (LauncherWindow::toggleOfflineStorageDatabase):
51         (LauncherWindow::toggleOfflineWebApplicationCache):
52         (LauncherWindow::setOfflineStorageDefaultQuota):
53         * QtTestBrowser/launcherwindow.h:
54         (WindowOptions::WindowOptions):
55         * QtTestBrowser/main.cpp:
56         (LauncherApplication::handleUserOptions):
57
58 2011-02-04  Tony Chang  <tony@chromium.org>
59
60         Reviewed by Eric Seidel.
61
62         get test-webkitpy running on win32 python
63         https://bugs.webkit.org/show_bug.cgi?id=53822
64
65         The test harness crashes with a WindowsError because it can't find
66         'svn' when using subprocess.Popen.  This gets us past the error
67         so we can see the failing tests on the Chromium Win Release Tests
68         bot.
69
70         * Scripts/webkitpy/common/system/executive.py:
71
72 2011-02-04  Martin Robinson  <mrobinson@igalia.com>
73
74         Reviewed by Gustavo Noronha Silva.
75
76         [GTK] fast/events/pagehide-timeout.html fails
77         https://bugs.webkit.org/show_bug.cgi?id=53771
78
79         Add knowledge of the document browser cache model the DRT. When resetting
80         WebKit settings to consistent values between tests, default to the document
81         browser cache model.
82
83         * DumpRenderTree/gtk/DumpRenderTree.cpp:
84         (resetDefaultsToConsistentValues): Reset the cache model to the document browser
85         cache model between tests.
86         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
87         (LayoutTestController::setCacheModel): An int value of 2 here corresponds to the
88         document browser cache model.
89
90 2011-02-04  Adam Barth  <abarth@webkit.org>
91
92         Reviewed by Eric Seidel.
93
94         PluginDocuments don't create widgets for plugins on back/forward
95         https://bugs.webkit.org/show_bug.cgi?id=53474
96
97         Teach the test plugin how to call alert on load.
98
99         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
100         (NPP_New):
101
102 2011-02-04  Adam Roben  <aroben@apple.com>
103
104         Add a test case for encode/decode of FormData/FormDataElement
105
106         If the fix made in r77401 is broken, this new test will crash.
107
108         Fixes <http://webkit.org/b/53616> <rdar://problem/8949883>.
109
110         Reviewed by Sam Weinig.
111
112         * TestWebKitAPI/Test.h: Moved the bulk of TEST_ASSERT into a new _TEST_ASSERT_HELPER macro.
113         Added a new TEST_ASSERT_RETURN macro that can be used in functions with a return value.
114
115         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp: Added.
116         (TestWebKitAPI::didFinishLoadForFrame): Record that the load is finished.
117         (TestWebKitAPI::setPageLoaderClient): Hook up the loader client.
118         (TestWebKitAPI::createSessionStateContainingFormData): Load simple-form.html, submit the
119         form, an return the session state data.
120         (TestWebKitAPI::TEST): Create some session state that contains form data from one WKPage,
121         and restore it into another WKPage.
122
123         * TestWebKitAPI/Tests/WebKit2/simple-form.html: Added.
124
125         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
126         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
127         * TestWebKitAPI/win/copy-resources.cmd:
128         Added new files.
129
130 2011-02-04  Adam Roben  <aroben@apple.com>
131
132         Move code to run JavaScript tests into its own files
133
134         This will allow other tests to use this mechanism.
135
136         Fixes <http://webkit.org/b/53806> SpacebarScrolling should share its JavaScript-fu with the
137         world
138
139         Reviewed by Sam Weinig.
140
141         * TestWebKitAPI/JavaScriptTest.cpp: Added.
142         * TestWebKitAPI/JavaScriptTest.h: Added.
143         Moved code here...
144
145         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp: ...from here.
146
147         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
148         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
149         Added the new files.
150
151 2011-02-04  Dirk Pranke  <dpranke@chromium.org>
152
153         Reviewed by Mihai Parparita.
154
155         merge test expectations for chromium, chromium-gpu. The
156         chromium-gpu port will no longer maintain its own
157         test expectations file.
158
159         Also add in a graphics_type() call on the port object to
160         determine what graphics type to use in the test configuration,
161         and log the configuration as a config setting.
162
163         https://bugs.webkit.org/show_bug.cgi?id=53562
164
165         * Scripts/webkitpy/layout_tests/port/base.py:
166         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
167         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
168         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
169
170 2011-02-04  Mikhail Naganov  <mnaganov@chromium.org>
171
172         Reviewed by Pavel Feldman.
173
174         Web Inspector: fix processing Unicode literals from .js sources in check-inspector-strings.
175         https://bugs.webkit.org/show_bug.cgi?id=53781
176
177         * Scripts/check-inspector-strings:
178
179 2011-02-04  Adam Roben  <aroben@apple.com>
180
181         Include the crashing function in the link to a crash log on Mac
182
183         Fixes <http://webkit.org/b/53780> Crash log links in results.html should include the
184         function that crashed on Mac
185
186         Reviewed by David Kilzer.
187
188         * Scripts/old-run-webkit-tests:
189         (crashLocation): Moved all the Windows code inside an if instead of using an early return,
190         but didn't otherwise change it. Added an if for Mac that parses the crashing function out of
191         the crash log.
192
193 2011-02-04  Adam Roben  <aroben@apple.com>
194
195         Link to Mac crash logs from results.html
196
197         Fixes <http://webkit.org/b/14861> run-webkit-tests should link to Mac crash logs in
198         results.html
199
200         Reviewed by David Kilzer.
201
202         * Scripts/old-run-webkit-tests:
203         (captureSavedCrashLog): Added a case for Apple's Mac port. We get the crash log out of
204         ~/Library/Logs/CrashReporter, and wait for ReportCrash to exit before trying to get the log.
205
206 2011-02-03  Maciej Stachowiak  <mjs@apple.com>
207
208         Reviewed by Dan Bernstein.
209
210         WebKit2: Need WebKit2 equivalent of WebResourceLoadDelegate::willSendRequest in the Bundle
211         https://bugs.webkit.org/show_bug.cgi?id=52897
212         <rdar://problem/8898294>
213
214         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
215         (WTR::InjectedBundlePage::InjectedBundlePage):
216         (WTR::InjectedBundlePage::willSendRequestForFrame):
217         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
218
219 2011-02-03  Ivan Krstić  <ike@apple.com>
220
221         Unreviewed.
222
223         Adding myself to committers.py.
224
225         * Scripts/webkitpy/common/config/committers.py:
226
227 2011-02-03  James Kozianski  <koz@chromium.org>
228
229         Reviewed by Dimitri Glazkov.
230
231         Add navigator.registerProtocolHandler behind a flag.
232         https://bugs.webkit.org/show_bug.cgi?id=52609
233
234         * Scripts/build-webkit:
235
236 2011-02-03  Hayato Ito  <hayato@chromium.org>
237
238         Reviewed by Eric Seidel.
239
240         [NRWT] Remove TestArgs class, which is wrongly used.
241
242         https://bugs.webkit.org/show_bug.cgi?id=53063
243
244         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
245         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
246         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
247         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
248         * Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py:
249         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
250
251 2011-02-03  Andrew Wason  <rectalogic@rectalogic.com>
252
253         Reviewed by Kenneth Russell.
254
255         Change ENABLE_3D_CANVAS to ENABLE_WEBGL
256         https://bugs.webkit.org/show_bug.cgi?id=53714
257
258         * Scripts/build-webkit: change --3d-canvas build option
259           to set ENABLE_WEBGL
260
261 2011-02-03  Hayato Ito  <hayato@chromium.org>
262
263         Reviewed by Tony Chang.
264
265         [NRWT] Introduces Input/Output class used by base.Driver into port/base.py and
266         move _run_single_test() and _process_output() functions from
267         dump_render_tree_thread.py to a single_test_runner.py as an individual module.
268
269         This is clean up and acts as a preparation for elimination of test_types/*
270         classes. These classes will move to the single_test_runner module introduced
271         in this patch.
272
273         https://bugs.webkit.org/show_bug.cgi?id=53004
274
275         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
276         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py: Added.
277         * Scripts/webkitpy/layout_tests/layout_package/test_input.py:
278         * Scripts/webkitpy/layout_tests/layout_package/test_output.py: Removed.
279         * Scripts/webkitpy/layout_tests/port/base.py:
280         * Scripts/webkitpy/layout_tests/port/chromium.py:
281         * Scripts/webkitpy/layout_tests/port/dryrun.py:
282         * Scripts/webkitpy/layout_tests/port/test.py:
283         * Scripts/webkitpy/layout_tests/port/webkit.py:
284         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
285         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
286         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
287
288 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
289
290         Unreviewed, build fix.
291
292         Delete a line that was accidentally missed in r77586; without it
293         there is still a race between the two threads.
294
295         https://bugs.webkit.org/show_bug.cgi?id=51572
296
297         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
298
299 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
300
301         Reviewed by Tony Chang.
302
303         nrwt: handle "broken pipe" notifications from DRT more cleanly.
304
305         https://bugs.webkit.org/show_bug.cgi?id=52927
306
307         * Scripts/webkitpy/layout_tests/port/server_process.py:
308         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
309
310 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
311
312         Reviewed by Kenneth Russell.
313
314         Update, resubmit change to bug 51572. I think the race that was
315         fixed in r76703 caused the hang that caused us to roll this
316         patch out before, so I'd like to try again.
317
318         https://bugs.webkit.org/show_bug.cgi?id=51572
319
320         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
321         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
322
323 2011-02-03  Daniel Cheng  <dcheng@chromium.org>
324
325         Unreviewed.
326
327         Adding myself to committers.py.
328
329         * Scripts/webkitpy/common/config/committers.py:
330
331 2011-02-03  Adam Roben  <aroben@apple.com>
332
333         Include the crashing function in the link to a crash log
334
335         Fixes <http://webkit.org/b/53739> Crash log links in results.html should include the
336         function that crashed
337
338         Reviewed by David Kilzer.
339
340         * Scripts/old-run-webkit-tests:
341         (crashLocation): Added. Returns the location of the crash.
342         (linksForErrorTest): Include the crash location in the link text for the crash log, if one
343         could be determined.
344
345 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
346
347         Unreviewed, build fix.
348
349         Actually make the changes suggested by Mihai in his review
350         of bug 53720 :(
351
352         https://bugs.webkit.org/show_bug.cgi?id=53720
353
354         * Scripts/webkitpy/layout_tests/port/test_files.py:
355         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
356
357 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
358
359         Reviewed by Mihai Parparita.
360
361         new-run-webkit-tests: Fix bug introduced in r77434 that was
362         causing us to run the canvas GPU tests on the Mac GPU port. This
363         bug revealed that we were not setting the port.name() field
364         properly in many cases, so I've cleaned up all of that code, and
365         removed a few comments about "version-specific" GPU ports that
366         don't exist and just confused things.
367
368         Testing also revealed that port.abspath_for_test() wasn't
369         normalizing paths on Windows properly, so I fixed that as well.
370
371         https://bugs.webkit.org/show_bug.cgi?id=53719
372
373         * Scripts/webkitpy/layout_tests/port/base.py:
374         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
375         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
376
377 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
378
379         Reviewed by Mihai Parparita.
380
381         new-run-webkit-tests: fix normalization of paths on windows when gathering files
382
383         r77434 introduced a bug that was causing the test expectations
384         for the GPU ports to not be treated properly. It turns out that
385         when we gathered the list of test files on Windows, we would
386         return paths of the form "c:\LayoutTests/fast/canvas", and the
387         mixture of backslashes and forward slashes was confusing things.
388
389         This patch normalizes all of the filenames returned from
390         test_files.find(), and adds better tests for this (fixing a
391         couple of other bugs found in the meantime).
392
393         https://bugs.webkit.org/show_bug.cgi?id=53720
394
395         * Scripts/webkitpy/layout_tests/port/test.py:
396         * Scripts/webkitpy/layout_tests/port/test_files.py:
397         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
398
399 2011-02-03  Adam Roben  <aroben@apple.com>
400
401         Add links to Windows crash logs in results.html
402
403         Fixes <http://webkit.org/b/53718> run-webkit-tests should link to Windows crash logs in
404         results.html
405
406         Reviewed by David Kilzer.
407
408         * Scripts/old-run-webkit-tests:
409         (top level): Added $crashLogTag and $windowsCrashLogFilePrefix (which came from
410         createDebuggerCommandFile).
411         (testCrashedOrTimedOut): If the test crashed, capture any saved crash log after the dump
412         tool has exited.
413         (captureSavedCrashLog): Added. Finds the crash log for the test that just crashed and moves
414         it into the test results directory tree. Only implemented for Cygwin currently.
415         (findNewestFileMatchingGlob): Added. Does what it says.
416         (htmlForResultsSection): Only link to files that exist.
417         (linksForErrorTest): Add a link to the crash log.
418         (deleteExpectedAndActualResults): Delete any old crash log for this test.
419         (createDebuggerCommandFile): Use the new $windowsCrashLogFilePrefix constant instead of
420         hardcoding it here.
421
422 2011-02-03  Adam Roben  <aroben@apple.com>
423
424         Tell the debugger the path to the WebKit source tree when saving a crash log
425
426         This allows the debugger to include the crashing line of code in the log.
427
428         Fixes <http://webkit.org/b/53678> Crash logs from buildslaves don't show the crashing line
429         of code
430
431         Reviewed by Sam Weinig.
432
433         * Scripts/old-run-webkit-tests:
434         (createDebuggerCommandFile): Added. Saves commands that we'd like the debugger to run to a
435         file and returns the path to that file. The commands we pass came from
436         setUpWindowsCrashLogSaving, but I've added a .srcpath command to tell the debugger where the
437         WebKit source code lives.
438         (setUpWindowsCrashLogSaving): Instead of specifying the commands directly on the command
439         line using -c, save them to a file and specify the path to that file using -cf. This works
440         around what is presumably a bug in Windows's command line parsing, where having multiple
441         quoted paths in the debugger commands causes the post-mortem debugger not to be invoked at
442         all. Also pulled the options we pass to the debugger out into a list that is then join()ed
443         together to make them easier to modify in the future.
444
445 2011-02-02  Sam Weinig  <sam@webkit.org>
446
447         Reviewed by Anders Carlsson.
448
449         Add notification of the end of a rubber band.
450         <rdar://problem/8940648>
451
452         * MiniBrowser/mac/BrowserWindowController.m:
453         (-[BrowserWindowController awakeFromNib]):
454         * WebKitTestRunner/TestController.cpp:
455         (WTR::TestController::createOtherPage):
456         (WTR::TestController::initialize):
457         Stub out the new WKUIClient function.
458
459 2011-02-03  Gabor Rapcsanyi  <rgabor@webkit.org>
460
461         Unreviewed.
462
463         Adding myself to committers.py.
464
465         * Scripts/webkitpy/common/config/committers.py:
466
467 2011-02-03  Balazs Kelemen  <kbalazs@webkit.org>
468
469         Reviewed by Csaba Osztrogonác.
470
471         [Qt][WK2] MiniBrowser's window size should be 800x600
472         https://bugs.webkit.org/show_bug.cgi?id=53670
473
474         Make layout test failure debugging easier.
475         * MiniBrowser/qt/BrowserWindow.cpp:
476         (BrowserWindow::BrowserWindow):
477
478 2011-02-02  Andy Estes  <aestes@apple.com>
479
480         Reviewed by Mark Rowe.
481
482         'update-webkit' should handle OpenSource and Internal using different
483         VCSs.
484
485         * Scripts/update-webkit: Re-check the VCS type when updating Apple's
486         Internal directory.
487
488 2011-02-02  Dirk Pranke  <dpranke@chromium.org>
489
490         Reviewed by Mihai Parparita.
491
492         new-run-webkit-tests: hardcode the directories to scan for tests
493         for GPU bots instead of SKIPping them. See bug 53562 for some
494         context, but we will now hard-code the list of directories to
495         use by default instead of skipping over directories in the
496         expectations file. We do this so that we will be able to merge
497         the expectations files without getting conflicting SKIP
498         directives. Note that this change will reduce the # of tests
499         being run on the Mac GPU bots, because we're accidentally
500         including some today.
501
502         https://bugs.webkit.org/show_bug.cgi?id=53631
503
504         * Scripts/webkitpy/layout_tests/port/base.py:
505         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
506         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
507
508 2011-02-02  Sam Weinig  <sam@webkit.org>
509
510         Reviewed by Beth Dakin.
511
512         Add ChromeClient function to paint custom overhang areas.
513         https://bugs.webkit.org/show_bug.cgi?id=53639
514
515         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
516         (WTR::InjectedBundlePage::InjectedBundlePage):
517         Stub out new callback.
518
519 2011-02-02  Dirk Pranke  <dpranke@chromium.org>
520
521         Reviewed by Tony Chang.
522
523         new-run-webkit-tests: support chromium code paths in mock_drt
524
525         https://bugs.webkit.org/show_bug.cgi?id=53471
526
527         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
528         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
529
530 2011-02-02  Adam Klein  <adamk@chromium.org>
531
532         Reviewed by Tony Chang.
533
534         Update new-run-webkit-tests --chromium to put output under Source/...
535         https://bugs.webkit.org/show_bug.cgi?id=53612
536
537         * BuildSlaveSupport/test-result-archive:
538         * Scripts/webkitpy/layout_tests/port/chromium.py:
539
540 2011-01-28  Tony Chang  <tony@chromium.org>
541
542         Reviewed by Eric Seidel.
543
544         [chromium] remove --use-test-shell from NRWT
545         https://bugs.webkit.org/show_bug.cgi?id=53346
546
547         I've already started removing some of the bindings like eventSender so
548         this already doesn't work isn't useful.  Also updated some comments to
549         refer to DRT instead of test_shell.
550
551         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
552         * Scripts/webkitpy/layout_tests/port/chromium.py:
553         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
554         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
555         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
556         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
557         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
558         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
559
560 2011-02-02  Steve Lacey  <sjl@chromium.org>
561
562         Reviewed by Eric Carlson.
563
564         Implement basic media statistics on media elements.
565         https://bugs.webkit.org/show_bug.cgi?id=53322
566
567         * Scripts/build-webkit:
568
569 2011-02-02  Kevin Ollivier  <kevino@theolliviers.com>
570
571         [wx] Build fixes for wxWebKit.
572
573         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
574         (LayoutTestController::setSerializeHTTPLoads):
575         * wx/browser/wscript:
576         * wx/build/build_utils.py:
577         * wx/build/settings.py:
578
579 2011-02-01  Dirk Pranke  <dpranke@chromium.org>
580
581         Reviewed by Mihai Parparita.
582
583         new-run-webkit-tests: stop skipping so many tests
584
585         r77163 introduced a regression where we weren't resetting test
586         expectations properly and were skipping too many tests as a
587         result. This patch fixes that and adds a test for it.
588
589         https://bugs.webkit.org/show_bug.cgi?id=53551
590
591         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
592         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
593
594 2011-02-01  Dirk Pranke  <dpranke@chromium.org>
595
596         Reviewed by Tony Chang.
597
598         new-run-webkit-tests: add first stub of test_runner2. This
599         will add support for the 'inline', 'threads', and 'processes'
600         flags to --worker-model, but for now the implementatios just
601         fall back on the old ones.
602
603         https://bugs.webkit.org/show_bug.cgi?id=53157
604
605         * Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
606         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
607
608 2011-02-01  Mihai Parparita  <mihaip@chromium.org>
609
610         Reviewed by James Robinson.
611
612         [Chromium] run-chromium-webkit-unit-tests looks for binaries in the wrong place
613         https://bugs.webkit.org/show_bug.cgi?id=53522
614
615         * Scripts/run-chromium-webkit-unit-tests:
616
617 2011-02-01  Adam Barth  <abarth@webkit.org>
618
619         Reviewed by Mihai Parparita.
620
621         Using Control-C to cancel webkit-patch or other python tools causes
622         unpleasant traceback console spew
623         https://bugs.webkit.org/show_bug.cgi?id=53462
624
625         Catch the exception and don't print the stack trace.
626
627         * Scripts/webkit-patch:
628
629 2011-02-01  Scott Cameron  <sccameron@rim.com>
630
631         Reviewed by Daniel Bates.
632
633         Use Windows format for MinGW HTTPD path.
634         https://bugs.webkit.org/show_bug.cgi?id=53503
635
636         * Scripts/webkitperl/httpd.pm:
637           - Use single-quotes around MySys value for $httpdPath in getHTTPDPath()
638             so that we don't have to escape the space characters in the path. Also,
639             changed path to Windows-style path and removed FIXME comment.
640
641 2011-02-01  Balazs Kelemen  <kbalazs@webkit.org>
642
643         Reviewed by Andreas Kling.
644
645         [Qt][WK2] Add a way to use shared process model in MiniBrowser
646         https://bugs.webkit.org/show_bug.cgi?id=53090
647
648         * MiniBrowser/qt/BrowserView.cpp:
649         (BrowserView::BrowserView): Removed the m_context member.
650         From now the context is guaranteed to be non-null and we
651         don't need to store that in the object.
652         * MiniBrowser/qt/BrowserView.h:
653         * MiniBrowser/qt/BrowserWindow.cpp:
654         Added static bool to determine that new windows need to be
655         created with their own context or not. Use the same context
656         and web process by default to be inilne with the other ports.
657         (BrowserWindow::BrowserWindow):
658         (BrowserWindow::newWindow):
659         * MiniBrowser/qt/BrowserWindow.h:
660         * MiniBrowser/qt/main.cpp:
661         (main): Added command line switch to be able to use the
662         non-shared process model. Simplify the handling of the command line
663         switches a little bit.
664
665 2011-02-01  Zoltan Horvath  <zoltan@webkit.org>
666
667         Reviewed by Andreas Kling.
668
669         [Qt] Add Window menu and Toggle FullScreen action to MiniBrowser.
670         https://bugs.webkit.org/show_bug.cgi?id=53491
671
672         * MiniBrowser/qt/BrowserWindow.cpp:
673         (BrowserWindow::BrowserWindow):
674         (BrowserWindow::toggleFullScreenMode):
675         * MiniBrowser/qt/BrowserWindow.h:
676
677 2011-02-01  Zoltan Horvath  <zoltan@webkit.org>
678
679         Reviewed by Andreas Kling.
680
681         [Qt] Add Toggle Frame Flattening, Auto Load Images and Disable JavaScript actions to MiniBrowser.
682         https://bugs.webkit.org/show_bug.cgi?id=53489
683
684         Add Toggle Frame Flattening action to Develop menu. Add Auto Load Images and Disable JavaScript actions
685         to Settings menu.
686
687         * MiniBrowser/qt/BrowserWindow.cpp:
688         (BrowserWindow::BrowserWindow):
689         (BrowserWindow::toggleFrameFlattening):
690         (BrowserWindow::toggleDisableJavaScript):
691         (BrowserWindow::toggleAutoLoadImages):
692         * MiniBrowser/qt/BrowserWindow.h:
693
694 2011-01-31  Mihai Parparita  <mihaip@chromium.org>
695
696         Reviewed by Tony Chang.
697
698         [Chromium] Switch chromium-mac to use ChromiumDriver
699         https://bugs.webkit.org/show_bug.cgi?id=53461
700         
701         For the sake of consistency with the other Chromium platforms (and so
702         that chromium-mac picks up special flags like --enable-hardware-gpu),
703         switch chromium-mac from the WebKitDriver to ChromiumDriver.
704
705         * Scripts/webkitpy/layout_tests/port/chromium.py:
706
707 2011-01-31  Dirk Pranke  <dpranke@chromium.org>
708
709         Reviewed by Mihai Parparita.
710
711         The current modifier parsing code in test_expectations is
712         fragile and hard-coded, so it's not easy to understand the logic
713         or easily add new types of modifiers (like GPU vs. CPU testing
714         for graphics tests, or 32-bit vs. 64-bit differences).
715
716         This is the first of two patches that will add in more generic
717         support and then eliminate the GPU-specific test expectations
718         files for Chromium.
719
720         This patch adds two standalone objects for handling modifiers. The
721         rules for interpreting modifiers, precedence, and conflicts are
722         given in the docstring to the ModifierMatcher class, which
723         returns ModifierMatchResult objects.
724         
725         This patch also adds routines to the Port interface and a
726         default set of values in the base object, in order to obtain the
727         values needed on a given test run. These values are then passed
728         to the expectation parser. This also allows us to clean up the
729         logic used to lint all of the different configurations in a
730         single test_expectations.txt file.
731
732         The next patch will merge in the separate GPU expectations file.
733
734         https://bugs.webkit.org/show_bug.cgi?id=51222
735
736         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
737         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
738         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
739         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
740         * Scripts/webkitpy/layout_tests/port/base.py:
741         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
742         * Scripts/webkitpy/layout_tests/port/chromium.py:
743         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
744         * Scripts/webkitpy/layout_tests/port/test.py:
745         * Scripts/webkitpy/layout_tests/port/webkit.py:
746         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
747         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
748         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
749         * Tools/Scripts/webkitpy/style/checkers/test_expectations.py:
750         * Tools/Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
751
752 2011-01-31  Scott Cameron  <sccameron@rim.com>
753
754         Reviewed by Daniel Bates.
755
756         update run-webkit-httpd to be able to launch Apache2.2 in a MSYS environment
757         https://bugs.webkit.org/show_bug.cgi?id=50036
758
759         This will add an Apache2.2 configuration file and modifies scripts to allow
760         running an httpd server in an MSYS environment.
761
762         The default Apache2.2 installation path has been preserved and PHP5 modules disabled
763         in order to allow for simple installation/execution.  Simply install the latest
764         Apache2.2 version with OpenSSL from http://httpd.apache.org/download.cgi#apache22 to
765         be able to execute run-webkit-httpd.
766         
767
768         * Scripts/run-webkit-httpd:
769         * Scripts/webkitperl/httpd.pm:
770
771 2011-01-31  Tony Chang  <tony@chromium.org>
772
773         Reviewed by Eric Seidel.
774
775         mac DRT should report RTL scroll offset relative to top right corner
776         https://bugs.webkit.org/show_bug.cgi?id=53324
777
778         * DumpRenderTree/mac/DumpRenderTree.mm:
779         (dumpFrameScrollPosition):
780
781 2011-01-31  Zoltan Horvath  <zoltan@webkit.org>
782
783         Reviewed by Andreas Kling.
784
785         [Qt] Add Take Screen Shot action to MiniBrowser
786         https://bugs.webkit.org/show_bug.cgi?id=53422
787
788         Add Take Screen Shot action to MiniBrowser's view menu.
789
790         * MiniBrowser/qt/BrowserWindow.cpp:
791         (BrowserWindow::BrowserWindow):
792         (BrowserWindow::screenshot):
793         * MiniBrowser/qt/BrowserWindow.h:
794
795 2011-01-31  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
796
797         Reviewed by Xan Lopez.
798
799         [GTK] REGRESSION:  http/tests/media/video-{cookie,referer}.html failing
800         https://bugs.webkit.org/show_bug.cgi?id=53379
801
802         Remove left over #ifdef's. I thought all of the conditional code
803         had been freed from the condition, but I forgot to check DRT.
804
805         * DumpRenderTree/gtk/DumpRenderTree.cpp:
806         (resetDefaultsToConsistentValues):
807         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
808         (LayoutTestController::setAlwaysAcceptCookies):
809
810 2011-01-30  Dirk Pranke  <dpranke@chromium.org>
811
812         Unreviewed, build fix.
813
814         Fix regression introduced in r77093 - path.rsplit() doesn't
815         take keyword arguments.
816
817         https://bugs.webkit.org/show_bug.cgi?id=53326
818
819         * Scripts/webkitpy/common/system/filesystem_mock.py:
820
821 2011-01-30  Dirk Pranke  <dpranke@chromium.org>
822
823         Reviewed by Mihai Parparita.
824
825         Add more unit tests for rebaseline-chromium-webkit-tests. This
826         change involves restructuring a bunch of r-c-w-t code to make it
827         more testable as well. We also add wrapper classes for handling
828         testing zip files and fetching URLs.
829
830         https://bugs.webkit.org/show_bug.cgi?id=53040
831
832         * Scripts/webkitpy/common/system/urlfetcher.py:
833         * Scripts/webkitpy/common/system/urlfetcher_mock.py:
834         * Scripts/webkitpy/common/system/zipfileset_mock.py:
835         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
836         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
837         * Scripts/webkitpy/tool/mocktool.py:
838
839 2011-01-30  Dirk Pranke  <dpranke@chromium.org>
840
841         Reviewed by Eric Seidel.
842
843         Clean up of the filesystem-related modules used in webkitpy.
844         I've added relpath() to the filesystem interface, modified
845         ospath.relpath() so that it could work with the filesystem
846         interface, and modified the fileset* routines to use the
847         filesystem interface consistently.
848
849         This patch also adds a close() routine to the fileset routines
850         to indicate that the caller is done with the fileset. This
851         allows zipfileset to clean up after itself when it creates
852         tempfiles to store downloads.
853
854         https://bugs.webkit.org/show_bug.cgi?id=53326
855
856         * Scripts/webkitpy/common/system/directoryfileset.py:
857         * Scripts/webkitpy/common/system/fileset.py:
858         * Scripts/webkitpy/common/system/filesystem.py:
859         * Scripts/webkitpy/common/system/filesystem_mock.py:
860         * Scripts/webkitpy/common/system/filesystem_unittest.py:
861         * Scripts/webkitpy/common/system/ospath.py:
862         * Scripts/webkitpy/common/system/zipfileset.py:
863         * Scripts/webkitpy/common/system/zipfileset_unittest.py:
864
865 2011-01-30  Balazs Kelemen  <kbalazs@webkit.org>
866
867         Reviewed by Csaba Osztrogonác.
868
869         [Qt][WK2]REGRESSION (r76991): Fix build errors
870         https://bugs.webkit.org/show_bug.cgi?id=53400
871
872         Revert the temporary build fix (http://trac.webkit.org/changeset/77088)
873         and remove WebKit2Prefix.h from the build.
874         * MiniBrowser/qt/MiniBrowser.pro:
875
876 2011-01-30  Csaba Osztrogonác  <ossy@webkit.org>
877
878         Unreviewed.
879
880         [Qt][WK2] Buildfix.
881
882         * MiniBrowser/qt/MiniBrowser.pro:
883
884 2011-01-28  Simon Fraser  <simon.fraser@apple.com>
885
886         Reviewed by Adam Roben.
887         
888         define NOMINMAX when building ImageDiff, as we do elsewhere.
889
890         Add various clampToInt() methods to MathExtras.h
891         https://bugs.webkit.org/show_bug.cgi?id=52910
892
893         * DumpRenderTree/win/ImageDiffCommon.vsprops:
894
895 2011-01-28  Maciej Stachowiak  <mjs@apple.com>
896
897         Reviewed by Darin Adler.
898
899         WebKitTestRunner needs layoutTestController.setPOSIXLocale
900         https://bugs.webkit.org/show_bug.cgi?id=42682
901
902         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
903         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
904         (WTR::InjectedBundle::resetLocalSettings):
905         (WTR::InjectedBundle::didReceiveMessage):
906         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
907         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
908         (WTR::LayoutTestController::setPOSIXLocale):
909         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
910
911 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
912  
913          Reviewed by Mihai Parparita.
914  
915          test-webkitpy: fix webkitpy.layout_tests.port.mac_unittest.MacTest.test_skipped_file_paths
916  
917          This patch re-enables this test and changes it to
918          handle all of the mac platform versions, not just the one
919          it is running on.
920  
921          https://bugs.webkit.org/show_bug.cgi?id=53356
922  
923          * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
924  
925 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
926
927         Unreviewed, build fix.
928
929         Take two. The fix in 77023 didn't work, because we were
930         still calling path.abspath_to_uri, which calls _cygpath under
931         the covers, and it appears the cygpath on the bots does
932         something different than it does on my machine. This patch
933         removes the calls to path.abspath_to_uri, so it should be safe.
934         If it doesn't work, I'll roll it out along with r76982 and 77023.
935
936         https://bugs.webkit.org/show_bug.cgi?id=53126
937
938         * Scripts/webkitpy/layout_tests/port/test.py:
939
940 2011-01-28  David Kilzer  <ddkilzer@apple.com>
941
942         <rdar://problem/8930699> build-webkit gives a bogus warning with newer versions of Xcode 
943         <http://webkit.org/b/53353>
944
945         Reviewed by Mark Rowe.
946
947         * Scripts/webkitdirs.pm:
948         (checkRequiredSystemConfig): Check the Xcode marketing version
949         in addition to the DevCoreTools build version before complaining
950         about an old version of Xcode.  Also make the Mac OS X version
951         check use Perl's built-in version string comparitor.
952
953 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
954
955         Unreviewed, build fix.
956
957         Work around breakage on Win 7 Release bot caused by r76982
958         and the fact that windows ports use "file:////" instead of
959         "file:///". Ideally the test code should be isolated from
960         this, but it isn't yet. Will fix properly in a bit.
961
962         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
963
964 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
965
966         Reviewed by Tony Chang.
967
968         new-run-webkit-tests: change worker model values to
969         "old-inline", "old-threads" in preparation for test_runner2 /
970         multiprocessing changes.
971
972         https://bugs.webkit.org/show_bug.cgi?id=53156
973
974         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
975         * Scripts/webkitpy/layout_tests/port/base.py:
976         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
977         * Scripts/webkitpy/layout_tests/port/mac.py:
978         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
979
980 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
981
982         Reviewed by Tony Chang.
983
984         committers.py - add an IRC nickname for dpranke
985         https://bugs.webkit.org/show_bug.cgi?id=53335
986
987         * Scripts/webkitpy/common/config/committers.py:
988
989 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
990
991         Reviewed by Tony Chang.
992
993         new-run-webkit-tests: add a "mock DRT" port implementation
994         and a separate class that emulates what we expect the
995         DumpRenderTree behavior to be.
996
997         This will eventually replace port/dryrun.py and allow us to get
998         better test coverage of the new-run-webkit-tests code as well as
999         a reference for what new-run-webkit-tests expects from DRT.
1000
1001         This is the first attempt at this, and it is pretty bare-boned. It
1002         really only has been tested on the 'mac' port (and a little on
1003         the 'chromium-mac' port.
1004
1005         https://bugs.webkit.org/show_bug.cgi?id=53126
1006
1007         * Scripts/webkitpy/common/system/filesystem_mock.py:
1008         * Scripts/webkitpy/layout_tests/port/dryrun.py:
1009         * Scripts/webkitpy/layout_tests/port/factory.py:
1010         * Scripts/webkitpy/layout_tests/port/mock_drt.py: Added.
1011         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Added.
1012         * Scripts/webkitpy/layout_tests/port/test.py:
1013
1014 2011-01-28  Pratik Solanki  <psolanki@apple.com>
1015
1016         Unreviewed. Removing .swp file checked in by mistake.
1017
1018         * Scripts/.webkitdirs.pm.swp: Removed.
1019
1020 2011-01-28  Pratik Solanki  <psolanki@apple.com>
1021
1022         Reviewed by David Kilzer.
1023
1024         Space not necessary for undefined feature
1025         https://bugs.webkit.org/show_bug.cgi?id=53317
1026
1027         * Scripts/build-webkit:
1028
1029 2011-01-28  Chang Shu  <chang.shu@nokia.com>
1030
1031         Reviewed by Andreas Kling.
1032
1033         Reset NetworkAccessManager to clean up credentials from previous tests.
1034         This change causes no performance overhead either.
1035         https://bugs.webkit.org/show_bug.cgi?id=36688
1036
1037         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1038         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1039         (WebCore::DumpRenderTree::open):
1040         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1041
1042 2011-01-28  Zoltan Horvath  <zoltan@webkit.org>
1043
1044         Reviewed by Andreas Kling.
1045
1046         [Qt] Add Zoom Text Only action to MiniBrowser
1047         https://bugs.webkit.org/show_bug.cgi?id=53297
1048
1049         Add Zoom Text Only action to MiniBrowser's view menu, change zoom levels to avoid unnecessary divides.
1050
1051         * MiniBrowser/qt/BrowserWindow.cpp:
1052         (BrowserWindow::BrowserWindow):
1053         (BrowserWindow::zoomIn):
1054         (BrowserWindow::zoomOut):
1055         (BrowserWindow::resetZoom):
1056         (BrowserWindow::toggleZoomTextOnly):
1057         (BrowserWindow::applyZoom):
1058         * MiniBrowser/qt/BrowserWindow.h:
1059
1060 2011-01-28  Adam Barth  <abarth@webkit.org>
1061
1062         Reviewed by Eric Seidel.
1063
1064         Add webkit-patch roll-chromium-deps
1065         https://bugs.webkit.org/show_bug.cgi?id=53288
1066
1067         This command updates the Source/WebKit/chromium/DEPS file with the
1068         last-known good revision of Chromium (or a revision specified on the
1069         command line).  I'd eventually like to turn this into a SheriffBot
1070         command, but this is the first step.
1071
1072         This patch somewhat sprawled because I needed to move a bunch of code
1073         out of ChangeLog that should never have been there in the first place.
1074         Also, I had to fix a bug in MockUser in order to test the new command.
1075
1076         * Scripts/webkitpy/common/checkout/api.py:
1077         * Scripts/webkitpy/common/checkout/changelog.py:
1078         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1079         * Scripts/webkitpy/common/checkout/deps.py: Added.
1080         * Scripts/webkitpy/common/config/urls.py:
1081         * Scripts/webkitpy/tool/commands/__init__.py:
1082         * Scripts/webkitpy/tool/commands/download_unittest.py:
1083         * Scripts/webkitpy/tool/commands/roll.py: Added.
1084         * Scripts/webkitpy/tool/commands/roll_unittest.py: Added.
1085         * Scripts/webkitpy/tool/commands/upload_unittest.py:
1086         * Scripts/webkitpy/tool/mocktool.py:
1087         * Scripts/webkitpy/tool/steps/__init__.py:
1088         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py: Added.
1089         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
1090         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py: Added.
1091         * Scripts/webkitpy/tool/steps/suggestreviewers_unittest.py:
1092         * Scripts/webkitpy/tool/steps/updatechromiumdeps.py: Added.
1093         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
1094
1095 2011-01-27  Greg Coletta  <greg.coletta@nokia.com>
1096
1097         Reviewed by Laszlo Gombos.
1098
1099         Get rid of prefix header dependency for WebKit2 build system
1100         https://bugs.webkit.org/show_bug.cgi?id=50174
1101
1102         Change the style checker so that it enforces config.h include for
1103         WebKit2.
1104
1105         * Scripts/webkitpy/style/checker.py:
1106
1107 2011-01-27  Maciej Stachowiak  <mjs@apple.com>
1108
1109         Reviewed by Darin Adler.
1110
1111         execCommand("Paste") doesn't work in WebKitTestRunner
1112         https://bugs.webkit.org/show_bug.cgi?id=52785
1113
1114         Enable both of the settings needed to allow paste.
1115         
1116         * WebKitTestRunner/TestController.cpp:
1117         (WTR::TestController::resetStateToConsistentValues):
1118
1119 2011-01-27  Jacob Dinu  <dinu.jacob@nokia.com>
1120
1121         Reviewed by Andreas Kling.
1122
1123         [Qt] QtTestBrowser: User input lost when toggling use of QGraphicsView
1124         https://bugs.webkit.org/show_bug.cgi?id=48440
1125
1126         Preserve user input when toggling use of QGraphicsView
1127
1128         * QtTestBrowser/launcherwindow.cpp:
1129         (LauncherWindow::initializeView):
1130         (LauncherWindow::loadFinished):
1131         * QtTestBrowser/launcherwindow.h:
1132         * QtTestBrowser/mainwindow.cpp:
1133         (MainWindow::addressUrl):
1134         * QtTestBrowser/mainwindow.h:
1135
1136 2011-01-27  Dirk Pranke  <dpranke@chromium.org>
1137
1138         Reviewed by Mihai Parparita.
1139
1140         new-run-webkit-tests: turn off pixel tests correctly by default
1141         for webkit-based ports. r70013 (bug 47510) used
1142         port.set_option_default() to attempt to set default values, but
1143         that didn't work correctly. I have removed set_option_default
1144         for now since it was only being used in two places and in three
1145         useless unit tests. There is a separate bug open to fix the
1146         option parsing (48095), so this workaround is fine for now.
1147
1148         https://bugs.webkit.org/show_bug.cgi?id=53217
1149
1150         * Scripts/webkitpy/layout_tests/port/webkit.py:
1151         * Scripts/webkitpy/layout_tests/port/base.py:
1152         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1153
1154 2011-01-27  Balazs Kelemen  <kbalazs@webkit.org>
1155
1156         Rubber-stamped by Ariya Hidayat.
1157
1158         Trivial crash fix in WTR.
1159
1160         * WebKitTestRunner/TestController.cpp:
1161         (WTR::TestController::initialize): Increase the size
1162         of the vector by one to be able to store the null character.
1163
1164 2011-01-27  Balazs Kelemen  <kbalazs@webkit.org>
1165
1166         Reviewed by Csaba Osztrogonác.
1167
1168         [Qt][WK2] WTR should be initialized in the same way as DRT
1169         https://bugs.webkit.org/show_bug.cgi?id=53240
1170
1171         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
1172         (WTR::activateFonts): Added missing initialization steps.
1173
1174 2011-01-27  Joone Hur <joone.hur@collabora.co.uk>
1175
1176         Unreviewed. 
1177
1178         Adding myself to committers.py.
1179
1180         * Scripts/webkitpy/common/config/committers.py:
1181
1182 2011-01-27  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1183
1184         Reviewed by Csaba Osztrogonác.
1185
1186         [Qt] [Symbian] Move project files into Source
1187         https://bugs.webkit.org/show_bug.cgi?id=52891
1188
1189         Fix the Symbian build after the project files
1190         are moved to Source directory. On Symbian qmake
1191         needs to run in the same directory where the main
1192         pro files (WebKit.pro, Tools.pro) are located.
1193
1194         * Scripts/webkitdirs.pm: Change to the directory where the pro file
1195         is located before running qmake for Symbian. Qmake on Symbian
1196         does not properly honor the "-o" option, work it around by setting
1197         the name of the Makefile to bld.inf.
1198
1199 2011-01-27  Zoltan Horvath  <zoltan@webkit.org>
1200
1201         Reviewed by Andreas Kling.
1202
1203         [Qt] Add simple zooming features to MiniBrowser
1204         https://bugs.webkit.org/show_bug.cgi?id=53231
1205
1206         Add View menu and Zoom In, Zoom Out, Zoom Reset actions to MiniBrowser.
1207
1208         * MiniBrowser/qt/BrowserWindow.cpp:
1209         (BrowserWindow::BrowserWindow):
1210         (BrowserWindow::zoomIn):
1211         (BrowserWindow::zoomOut):
1212         (BrowserWindow::resetZoom):
1213         (BrowserWindow::updateUserAgentList):
1214         (BrowserWindow::applyZoom):
1215         * MiniBrowser/qt/BrowserWindow.h:
1216
1217 2011-01-26  Maciej Stachowiak  <mjs@apple.com>
1218
1219         Reviewed by Dan Bernstein.
1220
1221         WebKitTestRunner needs to support layoutTestController.evaluateInWebInspector
1222         https://bugs.webkit.org/show_bug.cgi?id=42319
1223         
1224         Add evaluateInWebInspector and other APIs needed for inspector tests to run.
1225
1226         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1227         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1228         (WTR::LayoutTestController::showWebInspector):
1229         (WTR::LayoutTestController::closeWebInspector):
1230         (WTR::LayoutTestController::evaluateInWebInspector):
1231         (WTR::LayoutTestController::setTimelineProfilingEnabled):
1232         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1233         * WebKitTestRunner/TestInvocation.cpp:
1234         (WTR::shouldOpenWebInspector):
1235         (WTR::TestInvocation::invoke):
1236         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
1237
1238 2011-01-26  Martin Robinson  <mrobinson@igalia.com>
1239
1240         Reviewed by Xan Lopez.
1241
1242         [GTK] Pixel dumps do not include scrollbars in output images
1243         https://bugs.webkit.org/show_bug.cgi?id=53216
1244
1245         Show scrollbars in pixel dumps. This will fix pixel dumps for tests
1246         that have scrollbars.
1247
1248         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
1249         (createBitmapContextFromWebView): Take the snapshot of the containing GtkScrolledWindow
1250         instead of the web view itself.
1251
1252 2011-01-26  Dirk Pranke  <dpranke@chromium.org>
1253
1254         Reviewed by Mihai Parparita.
1255
1256         Fix regression introduced in r76322 ... new-run-webkit-tests
1257         was attempting to save the image diff output as a UTF-8-encoded
1258         file.
1259
1260         https://bugs.webkit.org/show_bug.cgi?id=53210
1261
1262         * Scripts/webkitpy/layout_tests/port/webkit.py:
1263
1264 2011-01-26  Sheriff Bot  <webkit.review.bot@gmail.com>
1265
1266         Unreviewed, rolling out r76709.
1267         http://trac.webkit.org/changeset/76709
1268         https://bugs.webkit.org/show_bug.cgi?id=53194
1269
1270         "broke python tests on non-snowleopard platforms" (Requested
1271         by dpranke on #webkit).
1272
1273         * Scripts/webkitpy/layout_tests/port/factory.py:
1274         * Scripts/webkitpy/layout_tests/port/mock_drt.py: Removed.
1275         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Removed.
1276
1277 2011-01-26  Dirk Pranke  <dpranke@chromium.org>
1278
1279         Reviewed by Tony Chang.
1280
1281         new-run-webkit-tests: add a "mock DRT" port implementation
1282         and a separate class that emulates what we expect the
1283         DumpRenderTree behavior to be.
1284
1285         This will eventually replace port/dryrun.py and allow us to get
1286         better test coverage of the new-run-webkit-tests code as well as
1287         a reference for what new-run-webkit-tests expects from DRT.
1288
1289         This is the first attempt at this, and it is pretty bare-boned. It
1290         really only has been tested on the 'mac' port (and a little on
1291         the 'chromium-mac' port.
1292
1293         https://bugs.webkit.org/show_bug.cgi?id=53126
1294
1295         * Scripts/webkitpy/layout_tests/port/mock_drt.py: Added.
1296         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Added.
1297         * Scripts/webkitpy/layout_tests/port/factory.py:
1298
1299 2011-01-26  Xianzhu Wang  <wangxianzhu@google.com>
1300
1301         Reviewed by Tony Chang.
1302
1303         Add '--no-timeout' option to Chromium DRT to ease debugging.
1304         https://bugs.webkit.org/show_bug.cgi?id=52873
1305
1306         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1307         (main):
1308
1309 2011-01-26  Csaba Osztrogonác  <ossy@webkit.org>
1310
1311         Reviewed by Andreas Kling.
1312
1313         [Qt] Fix qt_minimal build
1314         https://bugs.webkit.org/show_bug.cgi?id=53172
1315
1316         * QtTestBrowser/locationedit.h:
1317
1318 2011-01-26  Mansi Mithal  <mansi.mithal@nokia.com>
1319
1320         Reviewed by Antonio Gomes.
1321
1322         QtTestBrowser should have a UI Setting to disable plugins
1323         https://bugs.webkit.org/show_bug.cgi?id=52408
1324         
1325         Added a new action item named "Disable Plugins"
1326         under the "Settings" menu. 
1327
1328         * QtTestBrowser/launcherwindow.cpp:
1329         (LauncherWindow::createChrome):
1330         (LauncherWindow::togglePlugins):
1331         * QtTestBrowser/launcherwindow.h:
1332
1333 2011-01-25  Patrick Gansterer  <paroga@webkit.org>
1334
1335         Reviewed by Adam Barth.
1336
1337         Move main CMakeLists.txt into Source directory
1338         https://bugs.webkit.org/show_bug.cgi?id=52888
1339
1340         * Scripts/webkitdirs.pm:
1341
1342 2011-01-25  Patrick Gansterer  <paroga@webkit.org>
1343
1344         Reviewed by Eric Seidel.
1345
1346         Improve label text in submit-to-ews
1347         https://bugs.webkit.org/show_bug.cgi?id=53130
1348
1349         * QueueStatusServer/templates/submittoews.html:
1350
1351 2011-01-25  Mansi Mithal  <mansi.mithal@nokia.com>
1352
1353         Reviewed by Antonio Gomes.
1354
1355         QtTestBrowser should have a UI Settings to prevent loading images
1356         https://bugs.webkit.org/show_bug.cgi?id=52409
1357         
1358         Added a new action item named "DisableAutoLoadImages"
1359         under the "Settings" menu 
1360
1361         * QtTestBrowser/launcherwindow.cpp:
1362         (LauncherWindow::createChrome):
1363         (LauncherWindow::toggleAutoLoadImages):
1364         * QtTestBrowser/launcherwindow.h:
1365
1366 2011-01-25  Dirk Pranke  <dpranke@chromium.org>
1367
1368         Reviewed by Tony Chang.
1369
1370         Minor bug fixes and cleanup for filesystem wrappers, port/* test
1371         classes, test_expectations.py. This change adds "test-win" and
1372         "test-mac" variants to the test port so that we can better test
1373         rebaselining, and adds a MockUser() object for reuse in testing.
1374
1375         https://bugs.webkit.org/show_bug.cgi?id=53036
1376
1377         * Scripts/webkitpy/common/system/filesystem.py:
1378         * Scripts/webkitpy/common/system/filesystem_mock.py:
1379         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1380         * Scripts/webkitpy/layout_tests/port/factory.py:
1381         * Scripts/webkitpy/layout_tests/port/base.py:
1382         * Scripts/webkitpy/layout_tests/port/test.py:
1383         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1384         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
1385         * Scripts/webkitpy/tool/mocktool.py:
1386
1387 2011-01-25  Tony Chang  <tony@chromium.org>
1388
1389         Reviewed by Dimitri Glazkov.
1390
1391         [chromium] remove unused layoutTestController callback
1392         https://bugs.webkit.org/show_bug.cgi?id=53103
1393
1394         This method is used by a test_shell_test, but not needed by DRT.
1395
1396         * DumpRenderTree/chromium/LayoutTestController.cpp:
1397         (LayoutTestController::LayoutTestController):
1398         * DumpRenderTree/chromium/LayoutTestController.h:
1399
1400 2011-01-25  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1401
1402         Reviewed by Andreas Kling.
1403
1404         [GTK] Remove 64 bits release bot from the buildbot master
1405         https://bugs.webkit.org/show_bug.cgi?id=52899
1406
1407         Removes the 64 bits release slave from the buildbot configuration,
1408         so that we can use it as an EWS.
1409
1410         * BuildSlaveSupport/build.webkit.org-config/config.json:
1411
1412 2011-01-24  Maciej Stachowiak  <mjs@apple.com>
1413
1414         Reviewed by Dan Bernstein.
1415
1416         Implement database quota callback to fix storage tests on WebKit2 bot
1417         https://bugs.webkit.org/show_bug.cgi?id=53064
1418
1419         * WebKitTestRunner/TestController.cpp:
1420         (WTR::exceededDatabaseQuota):
1421         (WTR::TestController::createOtherPage):
1422         (WTR::TestController::initialize):
1423
1424 2011-01-24  Maciej Stachowiak  <mjs@apple.com>
1425
1426         Reviewed by Anders Carlsson.
1427
1428         Use designated temp directory for the database for WebKit2
1429         https://bugs.webkit.org/show_bug.cgi?id=53052
1430         
1431         Adopt the new WK2 API for this.
1432
1433         * WebKitTestRunner/TestController.cpp:
1434         (WTR::TestController::libraryPathForTesting):
1435         (WTR::TestController::initialize):
1436         * WebKitTestRunner/TestController.h:
1437         * WebKitTestRunner/mac/TestControllerMac.mm:
1438         (WTR::TestController::platformLibraryPathForTesting):
1439         * WebKitTestRunner/qt/TestControllerQt.cpp:
1440         (WTR::TestController::platformLibraryPathForTesting):
1441         * WebKitTestRunner/win/TestControllerWin.cpp:
1442         (WTR::TestController::platformLibraryPathForTesting):
1443
1444 2011-01-24  Lucas Forschler  <lforschler@apple.com>
1445
1446         Reviewed by Stephanie Lewis.
1447
1448         Add a new Leopard test bot.
1449
1450         * BuildSlaveSupport/build.webkit.org-config/config.json:
1451
1452 2011-01-24  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1453
1454         Reviewed by Adam Barth.
1455
1456         Add EFL Builder to core waterfall
1457         https://bugs.webkit.org/show_bug.cgi?id=52704
1458
1459         Add EFL Builder to the core waterfall again.
1460
1461         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1462         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1463
1464 2011-01-24  Xianzhu Wang  <wangxianzhu@google.com>
1465
1466         Reviewed by Tony Chang.
1467
1468         new-run-webkit-tests fails to start HTTP server if there are proxy settings
1469         https://bugs.webkit.org/show_bug.cgi?id=52872
1470
1471         Force disabling proxy to resolve the problem.
1472
1473         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
1474         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
1475
1476 2011-01-24  Andreas Kling  <kling@webkit.org>
1477
1478         Reviewed by Darin Adler.
1479
1480         check-webkit-style: Update exemptions following Source/ move.
1481         https://bugs.webkit.org/show_bug.cgi?id=53017
1482
1483         * Scripts/webkitpy/style/checker.py:
1484         * Scripts/webkitpy/style/checker_unittest.py:
1485
1486 2011-01-24  Andras Becsi  <abecsi@webkit.org>
1487
1488         Rubber-stamped by Csaba Osztrogonác.
1489
1490         [Qt] Move project files into Source
1491         https://bugs.webkit.org/show_bug.cgi?id=52891
1492
1493         * DumpRenderTree/qt/ImageDiff.pro: Add missing "Source" to WebKit.pri path
1494
1495 2011-01-24  Mikhail Naganov  <mnaganov@chromium.org>
1496
1497         Reviewed by Yury Semikhatsky.
1498
1499         Web Inspector: Find duplicate strings in localizedStrings.js
1500
1501         https://bugs.webkit.org/show_bug.cgi?id=53005
1502
1503         * Scripts/check-inspector-strings:
1504
1505 2011-01-24  Zoltan Horvath  <zoltan@webkit.org>
1506
1507         Reviewed by Andreas Kling.
1508
1509         [Qt] Regroup MiniBrowser's menubar and add open file action
1510         https://bugs.webkit.org/show_bug.cgi?id=53000
1511
1512         Add File and Develop menu to MiniBrowser's menubar and add open file action to File menu.
1513
1514         * MiniBrowser/qt/BrowserWindow.cpp:
1515         (BrowserWindow::BrowserWindow):
1516         (BrowserWindow::openFile):
1517         (BrowserWindow::~BrowserWindow):
1518         * MiniBrowser/qt/BrowserWindow.h:
1519
1520 2011-01-24  Csaba Osztrogonác  <ossy@webkit.org>
1521
1522         Unreviewed fix after r76496
1523
1524         [Qt] Move project files into Source
1525         https://bugs.webkit.org/show_bug.cgi?id=52891
1526
1527         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Remove unnecessary "Source" from the path.
1528         * BuildSlaveSupport/built-product-archive: Remove unnecessary "Source" from the path.
1529         * Scripts/webkitdirs.pm: Add the accidentally removed slash to the path.
1530
1531 2011-01-24  Andras Becsi  <abecsi@webkit.org>
1532
1533         Reviewed by Csaba Osztrogonác.
1534
1535         [Qt] Move project files into Source
1536         https://bugs.webkit.org/show_bug.cgi?id=52891
1537
1538         * DerivedSources.pro: Renamed from DerivedSources.pro.
1539         * DumpRenderTree/qt/DumpRenderTree.pro:
1540         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1541         * MiniBrowser/DerivedSources.pro:
1542         * MiniBrowser/qt/MiniBrowser.pro:
1543         * QtTestBrowser/QtTestBrowser.pro:
1544         * Scripts/webkitdirs.pm:
1545         * Tools.pro: Added.
1546         * WebKitTestRunner/DerivedSources.pro:
1547         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1548         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1549
1550 2011-01-22  Geoffrey Garen  <ggaren@apple.com>
1551
1552         Reviewed by Dan Bernstein.
1553
1554         Beefed up --threaded mode to catch even more kinds of errors.
1555         https://bugs.webkit.org/show_bug.cgi?id=52971
1556
1557         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Use a shared
1558         context group to force JSC to mark multiple threads. (This used to be
1559         the default, but it changed in SnowLeopard.)
1560         (runJavaScriptThread): Do more locking and unlocking, and more allocation,
1561         to give threading mistakes more chances to show themselves.
1562         (startJavaScriptThreads):
1563         (stopJavaScriptThreads):
1564
1565 2011-01-22  Robert Hogan  <robert@webkit.org>
1566
1567         Reviewed by Andreas Kling.
1568
1569         [Qt] Support layoutTestController.addURLToRedirect()
1570         https://bugs.webkit.org/show_bug.cgi?id=52956
1571
1572         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1573         (LayoutTestController::addURLToRedirect):
1574         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1575
1576 2011-01-22  Robert Hogan  <robert@webkit.org>
1577
1578         Reviewed by Kenneth Rohde Christiansen.
1579
1580         [Qt] REGRESSION (r72360): http/tests/security/aboutBlank/xss-DENIED-* tests fail
1581         https://bugs.webkit.org/show_bug.cgi?id=49802
1582
1583         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1584         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1585         (WebCore::DumpRenderTree::open):
1586
1587 2011-01-21  Adam Barth  <abarth@webkit.org>
1588
1589         Reviewed by Maciej Stachowiak.
1590
1591         Disable mac_unittest.py that fails on some of the Mac bots
1592         https://bugs.webkit.org/show_bug.cgi?id=52947
1593
1594         As noted in the comment, this test does not appear to be correct
1595         because the function this test is testing returns different results
1596         depending on which flavor of Mac the test is run on.  This patch
1597         disable the test.  Hopefully we can re-enable the test once we've
1598         probably insulated the test from its environment.
1599
1600         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1601
1602 2011-01-21  Dirk Pranke  <dpranke@chromium.org>
1603
1604         Reviewed by Mihai Parparita.
1605
1606         Fix bug introduced in r76322 that caused NRWT to not actually
1607         read the Skipped files properly.
1608
1609         https://bugs.webkit.org/show_bug.cgi?id=52771
1610
1611         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1612         * Scripts/webkitpy/layout_tests/port/webkit.py:
1613         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1614
1615 2011-01-21  Sam Weinig  <sam@webkit.org>
1616
1617         Reviewed by Geoffrey Sean Garen and Mark Rowe.
1618
1619         WebKitTestRunner needs the HOME environment variable to be set.
1620         <rdar://problem/8896573>
1621
1622         * Scripts/old-run-webkit-tests: Set the HOME environment variable if
1623         it exists.
1624
1625 2011-01-21  Dirk Pranke  <dpranke@chromium.org>
1626
1627         Reviewed by Eric Seidel.
1628
1629         Suppress a few remaining integration tests so that none of the
1630         layout_test unit tests ever read from the filesystem or launch
1631         subprocesses that aren't part of the unit tests.
1632
1633         Also fix a minor bug in the printing unit tests that was
1634         incorrectly relying on sys.argv.
1635
1636         https://bugs.webkit.org/show_bug.cgi?id=52863
1637
1638         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1639         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1640         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1641
1642 2011-01-21  Darin Adler  <darin@apple.com>
1643
1644        Fix Mac build.
1645
1646         * MiniBrowser/mac/BrowserWindowController.m:
1647         (-[BrowserWindowController awakeFromNib]): Pass 0 for runModal function.
1648
1649 2011-01-20  Darin Adler  <darin@apple.com>
1650
1651         Reviewed by Dan Bernstein.
1652
1653         WebKit2: Implement showModalDialog
1654         https://bugs.webkit.org/show_bug.cgi?id=52855
1655
1656         This fixes WebKitTestRunner to compile, but more work is probably
1657         needed to get it to pass the tests.
1658
1659         * WebKitTestRunner/TestController.cpp:
1660         (WTR::TestController::runModal): Added. Calls through to the
1661         platform-specific version of runModal.
1662         (WTR::TestController::createOtherPage): Changed to be a private
1663         static member function so it can refer to runModal, which is
1664         a private static member function.
1665         (WTR::TestController::initialize): Pass 0 for the runModal
1666         function since we don't need to run the main window modal.
1667         I suspect this is wrong and will need to change.
1668         * WebKitTestRunner/TestController.h: Added declarations for
1669         the functions added above.
1670         * WebKitTestRunner/mac/TestControllerMac.mm:
1671         (WTR::TestController::runModal): Added. Untested implementation.
1672         * WebKitTestRunner/qt/TestControllerQt.cpp:
1673         (WTR::TestController::runModal): Added.
1674         * WebKitTestRunner/win/TestControllerWin.cpp:
1675         (WTR::TestController::runModal): Added.
1676
1677 2011-01-21  Eric Seidel  <eric@webkit.org>
1678
1679         Reviewed by Adam Barth.
1680
1681         Split Host object off from WebKitPatch for easier re-use
1682         https://bugs.webkit.org/show_bug.cgi?id=52284
1683
1684         new-run-webkit-tests and other tools are eventually going to want one of these.
1685         Basically you need to inherit from this class if you want to pretend to be a
1686         self.tool object for Steps/Commands.
1687
1688         * Scripts/webkitpy/common/host.py: Added.
1689         * Scripts/webkitpy/tool/main.py:
1690
1691 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1692
1693         Reviewed by Adam Barth.
1694
1695         Disable the tests that start and stop the http server and web
1696         server, so that we don't have to worry about port collisions on
1697         the bots.
1698
1699         https://bugs.webkit.org/show_bug.cgi?id=52861
1700
1701         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1702
1703 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1704
1705         Reviewed by Eric Seidel.
1706
1707         nrwt: rewrite google_chrome_unittest to use mock filesystem.
1708         
1709         https://bugs.webkit.org/show_bug.cgi?id=52772
1710         
1711         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
1712
1713 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1714
1715         Reviewed by Eric Siedel.
1716
1717         nrwt: clean up almost all remaining port references, remove
1718         unnecessary import clauses. The only remaining references are
1719         in places where a mock filesystem makes no sense or can't be
1720         used, and in one routine in port/google_chrome_unittest that
1721         I'll rewrite in a separate patch.
1722
1723         https://bugs.webkit.org/show_bug.cgi?id=52771
1724
1725         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1726         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1727         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1728         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1729         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1730         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1731         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1732         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
1733         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
1734         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
1735         * Scripts/webkitpy/layout_tests/port/gtk.py:
1736         * Scripts/webkitpy/layout_tests/port/mac.py:
1737         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1738         * Scripts/webkitpy/layout_tests/port/qt.py:
1739         * Scripts/webkitpy/layout_tests/port/webkit.py:
1740         * Scripts/webkitpy/layout_tests/port/win.py:
1741         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
1742
1743 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1744
1745         Reviewed by Mihai Parparita.
1746
1747         remove fs refs from run_webkit_tests, rebaseline_chromium_webkit_tests
1748
1749         https://bugs.webkit.org/show_bug.cgi?id=52762
1750
1751         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1752         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1753
1754 2011-01-20  Tony Chang  <tony@chromium.org>
1755
1756         Reviewed by Ojan Vafai.
1757
1758         [chromium] fix the paths used for the rebaseline tool
1759         https://bugs.webkit.org/show_bug.cgi?id=52857
1760
1761         Some of the bots were renamed so the path to grab the results zip
1762         file has changed.
1763
1764         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1765
1766 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1767
1768         Reviewed by Tony Chang.
1769
1770         Fix bug introduced in r72688 / bug 52768 that broke the
1771         generation of the output filename links in the results.html
1772         output. Apparently none of the unit tests actually checked to
1773         make sure the generated links were correct :(
1774
1775         https://bugs.webkit.org/show_bug.cgi?id=52854
1776
1777         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1778         * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
1779
1780 2011-01-20  Alexey Proskuryakov  <ap@apple.com>
1781
1782         Reviewed by Darin Adler.
1783
1784         https://bugs.webkit.org/show_bug.cgi?id=52849
1785         Make window.print work with WebKit2
1786
1787         * MiniBrowser/mac/BrowserWindowController.m:
1788         (-[BrowserWindowController awakeFromNib]):
1789         * WebKitTestRunner/TestController.cpp:
1790         (WTR::createOtherPage):
1791         (WTR::TestController::initialize):
1792         Added zeroes to WKPageUIClient structures to avoid build failures.
1793
1794 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1795
1796         Reviewed by Eric Seidel.
1797
1798         nrwt: remove fs refs from printing, test_failures, test_expectations, text_diff
1799
1800         https://bugs.webkit.org/show_bug.cgi?id=52756
1801
1802         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1803         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1804         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1805         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
1806         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1807         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
1808
1809 2011-01-20  Mansi Mithal  <mansi.mithal@nokia.com>
1810
1811         Reviewed by Antonio Gomes.
1812
1813         QtTestBrowser should have a seperate menu for Settings
1814         https://bugs.webkit.org/show_bug.cgi?id=52817
1815         
1816         Added a new menu item named "Settings"
1817         and moved the "Enable interrupting js scripts" and "Enable js pop up windows" under the "Settings" menu 
1818
1819         * QtTestBrowser/launcherwindow.cpp:
1820         (LauncherWindow::createChrome):
1821
1822 2011-01-20  Sam Weinig  <sam@webkit.org>
1823
1824         Reviewed by John Sullivan.
1825
1826         Update update-webkit-localizable-strings with new path to WebKit.
1827
1828         * Scripts/update-webkit-localizable-strings:
1829
1830 2011-01-20  James Robinson  <jamesr@chromium.org>
1831
1832         Reviewed by Darin Fisher.
1833
1834         Implement mozilla's requestAnimationFrame API
1835         https://bugs.webkit.org/show_bug.cgi?id=51218
1836
1837         Chromium DumpRenderTree support for window.webkitRequestAnimationFrame.
1838
1839         * DumpRenderTree/chromium/WebViewHost.cpp:
1840         (invokeScheduleComposite):
1841         (WebViewHost::scheduleAnimation):
1842         (WebViewHost::paintInvalidatedRegion):
1843         * DumpRenderTree/chromium/WebViewHost.h:
1844
1845 2011-01-20  Maciej Stachowiak  <mjs@apple.com>
1846
1847         Reviewed by Adam Roben.
1848
1849         WebKitTestRunner needs to support layoutTestController.evaluateScriptInIsolatedWorld
1850         https://bugs.webkit.org/show_bug.cgi?id=42327
1851
1852         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm: Add support
1853         for methods that take their normal arguments but also a JSContextRef.
1854         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: IDL definition
1855         for evaluateScriptInIsolatedWorld.
1856         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1857         (WTR::InjectedBundlePage::didClearWindowForFrame): Set a magic variable only if
1858         this call is for an isolated world.
1859         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1860         (WTR::worldMap): Helper to create a world map.
1861         (WTR::LayoutTestController::worldIDForWorld): Map from an ID to a world.
1862         (WTR::LayoutTestController::evaluateScriptInIsolatedWorld): The newly
1863         added LayoutTestController API.
1864         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1865
1866 2011-01-19  Adam Roben  <aroben@apple.com>
1867
1868         Convert paths in environment variables back to msys-style inside commit-log-editor
1869
1870         When this script gets run from inside git commit, msys-style paths in the environment will
1871         have been turned into Windows-style paths with forward slashes. This screws up functions
1872         like File::Spec->rel2abs, which seem to rely on $PWD having an msys-style path. We convert
1873         the paths back to msys-style before doing anything else.
1874
1875         Fixes <http://webkit.org/b/48527> commit-log-editor uses full paths for section headers when
1876         using msysgit's Perl and multiple ChangeLogs have been edited
1877
1878         Reviewed by David Kilzer.
1879
1880         * Scripts/commit-log-editor: Call fixEnvironment before doing anything else.
1881         (fixEnvironment): Added. When run in msys in conjunction with git (i.e., when invoked from
1882         inside git commit), convert Windows-style paths in the environment back to msys-style paths.
1883
1884 2011-01-20  Zoltan Horvath  <zoltan@webkit.org>
1885
1886         [Win] Unreviewed build fix after r76248.
1887
1888         * DumpRenderTree/ForwardingHeaders/wtf/FastAllocBase.h: Added.
1889
1890 2011-01-20  Zoltan Horvath  <zoltan@webkit.org>
1891
1892         Reviewed by Csaba Osztrogonác.
1893
1894         Refactoring of the custom allocation framework
1895         https://bugs.webkit.org/show_bug.cgi?id=49897
1896
1897         Inheriting from FastAllocBase can result in objects getting larger (bug #33896, #46589).
1898         The modification replaces Noncopyable and FastAllocBase classes and these inherits with their
1899         equivalent macro implementation at the necessary places.
1900 2011-01-20  Yi Shen  <yi.4.shen@nokia.com>
1901
1902         Unreviewed. 
1903
1904         Adding myself to committers.py.
1905
1906         * Scripts/webkitpy/common/config/committers.py:
1907
1908 2011-01-20  Adam Barth  <abarth@webkit.org>
1909
1910         Reviewed by Tony Chang.
1911
1912         Chromium builders don't delete unversioned directories when DEPS change
1913         https://bugs.webkit.org/show_bug.cgi?id=52745
1914
1915         If we pass this option to gclient sync, gclient will delete directories
1916         that are no longer part of DEPS instead of leaving them around to
1917         confuse us later.  Apparently, the downstream buildbots use this option
1918         already.
1919
1920         * Scripts/update-webkit-chromium:
1921
1922 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1923
1924         Unreviewed, build fix - I pulled this patch in to fix an issue
1925         revealed by r76195 running on some new bots). Also fix a couple
1926         of other issues revealed in testing.
1927
1928         nrwt: remove fs refs from layout_package/json*
1929
1930         https://bugs.webkit.org/show_bug.cgi?id=52754
1931
1932         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1933         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1934         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
1935         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1936         * Scripts/webkitpy/layout_tests/port/base.py:
1937
1938 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1939
1940         Unreviewed, build fix.
1941
1942         Fix a couple of minor bugs discovered while bringing up new bots
1943         for testing.
1944
1945         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1946         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1947
1948 2011-01-19  James Robinson  <jamesr@chromium.org>
1949
1950         Unreviewed, rolling out r76194.
1951         http://trac.webkit.org/changeset/76194
1952         https://bugs.webkit.org/show_bug.cgi?id=51218
1953
1954         Caused mysterious compile failure on the chromium win
1955         build.webkit.org bots
1956
1957         * DumpRenderTree/chromium/WebViewHost.cpp:
1958         (WebViewHost::paintInvalidatedRegion):
1959         * DumpRenderTree/chromium/WebViewHost.h:
1960
1961 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1962
1963         Reviewed by Mihai Parparita.
1964
1965         remove fs refs from test_runner, dump_render_tree_thread
1966
1967         https://bugs.webkit.org/show_bug.cgi?id=52753
1968
1969         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1970         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1971         * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
1972         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1973
1974 2011-01-19  James Robinson  <jamesr@chromium.org>
1975
1976         Reviewed by Darin Fisher.
1977
1978         Implement mozilla's requestAnimationFrame API
1979         https://bugs.webkit.org/show_bug.cgi?id=51218
1980
1981         Chromium DumpRenderTree support for window.webkitRequestAnimationFrame.
1982
1983         * DumpRenderTree/chromium/WebViewHost.cpp:
1984         (invokeScheduleComposite):
1985         (WebViewHost::scheduleAnimation):
1986         (WebViewHost::paintInvalidatedRegion):
1987         * DumpRenderTree/chromium/WebViewHost.h:
1988
1989 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1990
1991         Unreviewed, build fix.
1992
1993         Fix a few incorrect "self._filesystem" references introduced in
1994         r76184.
1995
1996         * Scripts/webkitpy/layout_tests/port/chromium.py:
1997         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1998
1999 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2000
2001         Reviewed by Mihai Parparita.
2002
2003         add a .sep property, abspath(), isabs(), mtime(), and
2004         open_text_file_for_writing() to filesystem modules. Some of
2005         these properties are not needed in this patch but will be needed
2006         in subsequent patches (I'm doing this to avoid having to track
2007         multiple versions of a single file).
2008
2009         Also, change most of the port/* modules to use the filesystem
2010         objects instead of referencing the filesystem directly.
2011
2012         https://bugs.webkit.org/show_bug.cgi?id=52748
2013
2014         * Scripts/webkitpy/common/system/filesystem.py:
2015         * Scripts/webkitpy/common/system/filesystem_mock.py:
2016         * Scripts/webkitpy/layout_tests/port/__init__.py:
2017         * Scripts/webkitpy/layout_tests/port/base.py:
2018         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2019         * Scripts/webkitpy/layout_tests/port/chromium.py:
2020         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2021         * Scripts/webkitpy/layout_tests/port/config.py:
2022         * Scripts/webkitpy/layout_tests/port/test.py:
2023         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
2024
2025 2011-01-19  Maciej Stachowiak  <mjs@apple.com>
2026
2027         Reviewed by Anders Carlsson.
2028
2029         If resetting between tests times out, treat it as a WebProcess crash
2030         https://bugs.webkit.org/show_bug.cgi?id=52757
2031
2032         * WebKitTestRunner/TestController.cpp:
2033         (WTR::TestController::runTest):
2034
2035 2011-01-19  Alexey Proskuryakov  <ap@apple.com>
2036
2037         Reviewed by Darin Adler.
2038
2039         https://bugs.webkit.org/show_bug.cgi?id=52739
2040         Make it possible for a WebKit2 client to print headers and footers
2041
2042         Added dummy implementations for new printing UIClient calls.
2043
2044         * MiniBrowser/mac/BrowserWindowController.m:
2045         (-[BrowserWindowController awakeFromNib]):
2046         * WebKitTestRunner/TestController.cpp:
2047         (WTR::createOtherPage):
2048         (WTR::TestController::initialize):
2049
2050 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2051
2052         Reviewed by Ojan Vafai.
2053
2054         Change webkitpy/layout_tests/port/test.py to use the
2055         in-memory filesystem for cleaner unit testing. This
2056         change allows us to kill a lot of code that was
2057         specific to the test port, at the cost of being a
2058         little less clear about how things would work if
2059         you didn't have a filesystem.
2060
2061         https://bugs.webkit.org/show_bug.cgi?id=52605
2062
2063         * Scripts/webkitpy/layout_tests/port/test.py:
2064
2065 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2066
2067         Unreviewed, build fix.
2068
2069         Fix test failure caused by committing attachment 79368 instead
2070         of attachment 79461 on bug 52604.
2071
2072         * Scripts/webkitpy/common/system/filesystem_mock.py:
2073
2074 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2075
2076         Reviewed by Mihai Parparita.
2077
2078         new-run-webkit-tests: remove use of os.walk, use mock filesystem for better
2079         unit testing. os.walk() is too much of a hassle to implement on
2080         top of the in-memory mock filesystem and adding the necessary
2081         interface to files_under() gives clients a cleaner API anyway
2082         (for this particular usage model).
2083
2084         https://bugs.webkit.org/show_bug.cgi?id=52691
2085
2086         * Scripts/webkitpy/common/system/filesystem.py:
2087         * Scripts/webkitpy/common/system/filesystem_mock.py:
2088         * Scripts/webkitpy/layout_tests/port/test_files.py:
2089         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
2090
2091 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2092
2093         Reviewed by Tony Chang.
2094
2095         Change more modules in the layout-tests code to use the
2096         filesystem wrapper for cleaner unit testing.
2097
2098         This patch also adds the glob() wrapper to the filesystem
2099         abstraction.
2100         
2101         https://bugs.webkit.org/show_bug.cgi?id=52604
2102
2103         * Scripts/webkitpy/layout_tests/port/test_files.py:
2104         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
2105         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
2106         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2107         * Scripts/webkitpy/common/system/filesystem.py:
2108         * Scripts/webkitpy/common/system/filesystem_mock.py:
2109
2110 2011-01-19  Levi Weintraub  <leviw@chromium.org>
2111
2112         Unreviewed.
2113
2114         Updating my email addresses and irc nick.
2115
2116         * Scripts/webkitpy/common/config/committers.py:
2117
2118 2011-01-19  Tony Chang  <tony@chromium.org>
2119
2120         Reviewed by Mihai Parparita.
2121
2122         [chromium] [linux] if check-sys-deps fails, output the failure reason
2123         https://bugs.webkit.org/show_bug.cgi?id=52671
2124
2125         * Scripts/webkitpy/common/system/executive_mock.py: Add support for
2126             error handler functions.
2127         * Scripts/webkitpy/layout_tests/port/chromium.py:
2128             output the error text from --check-sys-deps
2129         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2130
2131 2011-01-19  Aparna Nandyal  <aparna.nand@wipro.com>
2132
2133         Reviewed by Andreas Kling.
2134
2135         [Qt] QtTestBrowser crashes when closing if Facebook is opened
2136         https://bugs.webkit.org/show_bug.cgi?id=52554
2137         
2138         QtNetworkAccessManager is created in a thread and set as
2139         member variable in QWebPage. When the thread is destroyed
2140         the object is still used. So fix will set the object to
2141         NULL once the thread is destroyed.
2142
2143         * QtTestBrowser/launcherwindow.cpp:
2144         (LauncherWindow::~LauncherWindow):
2145
2146 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
2147
2148         Rubber stamped by Csaba Osztrogonac
2149
2150         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: Removed unncessary inculde of WKStringCF.h
2151
2152 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
2153
2154         Reviewed by Tony Chang.
2155
2156         new-run-webkit-tests: add a --build-directory command line argument
2157
2158         Official Google Chrome builds use a non-standard build directory
2159         location. This patch adds a --build-directory argument that
2160         allows that location to be specified on the command line. Only
2161         Chromium-based builds will use this flag for now, but anyone can
2162         in the future.
2163
2164         There are no unit tests for this since it's difficult to test
2165         until mock filesystems are fully supported in the code. This was
2166         tested by hand for now.
2167
2168         https://bugs.webkit.org/show_bug.cgi?id=52694
2169
2170         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2171         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2172         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2173         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2174
2175 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
2176
2177         Not reviewed. Bot fix.
2178
2179         Remove an inadvertently committed debugging print.
2180
2181         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2182         (LayoutTestController::notifyDone):
2183
2184 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
2185
2186         Reviewed by Sam Weinig.
2187
2188         WebKitTestRunner should track loading more like DumpRenderTree
2189         https://bugs.webkit.org/show_bug.cgi?id=52692
2190
2191         Change load tracking to track the current top loading frame, in the manner of DumpRenderTree.
2192         This makes some tests that call notifyDone multiple times pass.
2193         
2194         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2195         (WTR::InjectedBundle::InjectedBundle):
2196         (WTR::InjectedBundle::done):
2197         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2198         (WTR::InjectedBundle::topLoadingFrame):
2199         (WTR::InjectedBundle::setTopLoadingFrame):
2200         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2201         (WTR::InjectedBundlePage::InjectedBundlePage):
2202         (WTR::InjectedBundlePage::stopLoading):
2203         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
2204         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
2205         (WTR::InjectedBundlePage::didFinishLoadForFrame):
2206         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
2207         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2208         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2209         (WTR::LayoutTestController::notifyDone):
2210         * WebKitTestRunner/TestController.cpp:
2211         (WTR::TestController::didReceiveMessageFromInjectedBundle):
2212
2213 2011-01-18  Mihai Parparita  <mihaip@chromium.org>
2214
2215         Reviewed by Kent Tamura.
2216
2217         [Chromium] NRWT looking for DRT binary in the wrong path on Mac
2218         https://bugs.webkit.org/show_bug.cgi?id=52678
2219         
2220         Update path now that WebKit is inside Source.
2221
2222         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2223
2224 2011-01-18  Robert Hogan  <robert@webkit.org>
2225
2226         Reviewed by Simon Hausmann.
2227
2228         [Qt] http/tests/incremental/slow-utf8-text.pl fails
2229         https://bugs.webkit.org/show_bug.cgi?id=44282
2230
2231         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2232         (WebCore::DumpRenderTree::dump):
2233
2234 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
2235
2236         Reviewed by Mihai Parparita.
2237
2238         Fix a small race condition that could cause the unit tests for
2239         new-run-webkit-tests to fail in a multithreaded environment.
2240         There was a small window in the code where one thread would
2241         check to see if a thread had raised an exception, do something,
2242         and then check to see if the thread was alive. If the other
2243         thread raised an exception and exited in between these two
2244         steps, the exception would be lost. Flipping the order of the
2245         two checks fixes the race, since we will now always check for an
2246         exception on the thread before exiting.
2247
2248         https://bugs.webkit.org/show_bug.cgi?id=51579
2249
2250         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
2251
2252 2011-01-18  Eric Seidel  <eric@webkit.org>
2253
2254         Reviewed by Adam Barth.
2255
2256         commit-queue dies when test archiving fails
2257         https://bugs.webkit.org/show_bug.cgi?id=52617
2258
2259         I looked at the machine and it had 10 archives already
2260         thus find_unused_name was returning None.  I've upped
2261         the limit to 100 (per bug) and tested the case where
2262         find_unused_name returns None (making archive return None).
2263
2264         * Scripts/webkitpy/common/system/workspace.py:
2265         * Scripts/webkitpy/common/system/workspace_unittest.py:
2266         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2267         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2268         * Scripts/webkitpy/tool/commands/queues.py:
2269
2270 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
2271
2272         Reviewed by Ojan Vafai.
2273
2274         Update rebaseline-chromium-webkit-tests unit tests to use a mock
2275         filesystem. Also fix a couple of "with" statements missed by
2276         r76050.
2277
2278         https://bugs.webkit.org/show_bug.cgi?id=52487
2279
2280         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
2281
2282 2011-01-18  Sergio Villar Senin  <svillar@igalia.com>
2283
2284         Reviewed by Martin Robinson.
2285
2286         [Gtk] Build fixes for gtk3 build
2287         https://bugs.webkit.org/show_bug.cgi?id=52648
2288
2289         * DumpRenderTree/gtk/EventSender.cpp:
2290         (beginDragWithFilesCallback):
2291
2292 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
2293
2294         Reviewed by Mihai Parparita.
2295
2296         Update rebaseline-chromium-webkit-tests to use filesystem objects
2297         instead of direct references to os.path, shutil, tempfile, etc.
2298
2299         This patch doesn't change anything, but will allow subsequent
2300         patches to change the unit tests to no longer use the real
2301         filesystem.
2302
2303         This patch adds a bunch more methods to the filesystem object as
2304         well.
2305
2306         https://bugs.webkit.org/show_bug.cgi?id=52482
2307
2308         * Scripts/webkitpy/common/system/filesystem.py:
2309         * Scripts/webkitpy/common/system/filesystem_mock.py:
2310         * Scripts/webkitpy/tool/commands/queues.py:
2311         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2312         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
2313
2314 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
2315
2316         Reviewed by Mihai Parparita.
2317
2318         new-run-webkit-tests shouldn't crash when you try to run a
2319         directory containing only skipped files.
2320
2321         https://bugs.webkit.org/show_bug.cgi?id=52478
2322         
2323         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2324         * Scripts/webkitpy/layout_tests/port/test.py:
2325         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2326
2327 2011-01-18  Adam Bergkvist  <adam.bergkvist@ericsson.com> and Martin Robinson  <mrobinson@igalia.com>
2328
2329         Reviewed by Gustavo Noronha Silva.
2330
2331         [GTK] The GTK+ EventSender needs support for beginDragWithFiles
2332         https://bugs.webkit.org/show_bug.cgi?id=40833
2333
2334         * DumpRenderTree/gtk/EventSender.cpp: Add a beginDragWithFiles implementation for the
2335         GTK+ event sender.
2336         (dragWithFilesDragDataGetCallback): Added.
2337         (dragWithFilesDragEndCallback): Added.
2338         (beginDragWithFilesCallback): Added.
2339
2340 2011-01-18  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2341
2342         Reviewed by Adam Barth.
2343
2344         ews: Add additional watcher to efl ews
2345         https://bugs.webkit.org/show_bug.cgi?id=52613
2346
2347         Add gyuyoung.kim@samsung.com to watcher list of efl-ews.
2348
2349         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2350
2351 2011-01-17  Tony Gentilcore  <tonyg@chromium.org>
2352
2353         Reviewed by Alexey Proskuryakov.
2354
2355         Fix some headers with missing or misspelled #ifndef guards
2356         https://bugs.webkit.org/show_bug.cgi?id=52545
2357
2358         * DumpRenderTree/chromium/TestEventPrinter.h:
2359         * DumpRenderTree/chromium/WebPreferences.h:
2360
2361 2011-01-17  Jessie Berlin  <jberlin@apple.com>
2362
2363         Reviewed by Anders Carlsson.
2364
2365         REGRESSION: Assertion failure in FrameLoader::continueLoadAfterWillSubmitForm() when
2366         navigating back to an unreachable URL
2367         https://bugs.webkit.org/show_bug.cgi?id=52388
2368
2369         Add a third parameter (unreachableURL) to queueLoadHTMLString.
2370
2371         * DumpRenderTree/LayoutTestController.cpp:
2372         (queueLoadHTMLStringCallback):
2373         (LayoutTestController::queueLoadHTMLString):
2374         (LayoutTestController::queueLoadAlternateHTMLString):
2375         * DumpRenderTree/LayoutTestController.h:
2376
2377         * DumpRenderTree/WorkQueueItem.h:
2378         (LoadHTMLStringItem::LoadHTMLStringItem):
2379
2380         * DumpRenderTree/chromium/LayoutTestController.cpp:
2381         (WorkItemLoadHTMLString::WorkItemLoadHTMLString):
2382         (WorkItemLoadHTMLString::run):
2383         (LayoutTestController::queueLoadHTMLString):
2384
2385         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
2386         (LoadHTMLStringItem::invoke):
2387         * DumpRenderTree/mac/WorkQueueItemMac.mm:
2388         (LoadHTMLStringItem::invoke):
2389         * DumpRenderTree/win/WorkQueueItemWin.cpp:
2390         (LoadHTMLStringItem::invoke):
2391
2392 2011-01-17  Dan Bernstein  <mitz@apple.com>
2393
2394         Rubber-stamped by Mark Rowe.
2395
2396         Update xcodeproj svn:ignore to include xcuserdata.
2397
2398         * DumpRenderTree/DumpRenderTree.xcodeproj: Modified property svn:ignore.
2399         * MiniBrowser/MiniBrowser.xcodeproj: Modified property svn:ignore.
2400         * TestWebKitAPI/TestWebKitAPI.xcodeproj: Modified property svn:ignore.
2401         * WebKitLauncher/WebKitLauncher.xcodeproj: Modified property svn:ignore.
2402         * WebKitTestRunner/WebKitTestRunner.xcodeproj: Modified property svn:ignore.
2403
2404 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
2405
2406         Unreviewed fix after r75908.
2407
2408         Move WebKit into Source
2409         https://bugs.webkit.org/show_bug.cgi?id=52530
2410
2411         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add Source to the path for Qt API tests.
2412
2413 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
2414
2415         Unreviewed.
2416
2417         Remove accidentally committed debug printing after r75908.
2418
2419         * Scripts/webkitdirs.pm:
2420
2421 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
2422
2423         Unreviewed.
2424
2425         Add myself to committers list
2426         https://bugs.webkit.org/show_bug.cgi?id=52566
2427
2428         * Scripts/webkitpy/common/config/committers.py:
2429
2430 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
2431
2432         Reviewed by Jeremy Orlow.
2433
2434         GeolocationController should call stopUpdating on destruction
2435         https://bugs.webkit.org/show_bug.cgi?id=52216
2436
2437         fast/dom/Geolocation/window-close-crash.html requires that a
2438         Geolocation watch be started in a secondary window. Consequently,
2439         we need to allow geolocation permission and provide a mock
2440         geolocation position for the secondary window's
2441         GeolocationClientMock.
2442
2443         * DumpRenderTree/chromium/LayoutTestController.cpp:
2444         (LayoutTestController::setGeolocationPermission):
2445         (LayoutTestController::setMockGeolocationPosition):
2446         (LayoutTestController::setMockGeolocationError):
2447         * DumpRenderTree/chromium/TestShell.h:
2448         (TestShell::windowList):
2449
2450 2011-01-16  Adam Barth  <abarth@webkit.org>
2451
2452         Update more include paths to reflect WebKit move.
2453
2454         * DumpRenderTree/chromium/EventSender.cpp:
2455         (EventSender::keyDown):
2456         (EventSender::needsShiftModifier):
2457         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
2458         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
2459
2460 2011-01-16  Kent Tamura  <tkent@chromium.org>
2461
2462         Unreviewed, Chromium build fix.
2463
2464         * Scripts/update-webkit-chromium: Webkit/chromium -> Source/WebKit/chromium
2465
2466 2011-01-16  Martin Robinson  <mrobinson@igalia.com>
2467
2468         Build fix for GTK+ after source directory movement.
2469
2470         * GNUmakefile.am: Correct include paths.
2471
2472 2011-01-16  Adam Barth  <abarth@webkit.org>
2473
2474         Teach svn-apply about WebKit move.
2475
2476         * Scripts/VCSUtils.pm:
2477
2478 2011-01-16  Adam Barth  <abarth@webkit.org>
2479
2480         Rubber-stamped by Eric Seidel.
2481
2482         Move WebKit into Source
2483         https://bugs.webkit.org/show_bug.cgi?id=52530
2484
2485         * DumpRenderTree/mac/InternalHeaders/WebKit/WebTypesInternal.h:
2486         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2487         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2488         * DumpRenderTree/qt/GCControllerQt.cpp:
2489         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2490         * DumpRenderTree/qt/PlainTextControllerQt.cpp:
2491         * DumpRenderTree/qt/TextInputControllerQt.cpp:
2492         * DumpRenderTree/wscript:
2493         * QtTestBrowser/launcherwindow.h:
2494         * Scripts/build-webkit:
2495         * Scripts/webkitdirs.pm:
2496
2497 2011-01-15  Adam Barth  <abarth@webkit.org>
2498
2499         Teach svn-apply about WebKit2 move.
2500
2501         * Scripts/VCSUtils.pm:
2502
2503 2011-01-15  Adam Barth  <abarth@webkit.org>
2504
2505         Rubber-stamped by Eric Seidel.
2506
2507         Move WebKit2 into Source
2508         https://bugs.webkit.org/show_bug.cgi?id=52438
2509
2510         * MiniBrowser/qt/MiniBrowser.pro:
2511         * Scripts/build-webkit:
2512         * Scripts/do-file-rename:
2513         * Scripts/do-webcore-rename:
2514         * Scripts/test-webkitpy:
2515         * Scripts/webkitdirs.pm:
2516         * Scripts/webkitpy/style/checker.py:
2517         * WebKitTestRunner/DerivedSources.pro:
2518         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2519         * WebKitTestRunner/qt/WebKitTestRunner.pro:
2520
2521 2011-01-15  Jochen Eisinger  <jochen@chromium.org>
2522
2523         Reviewed by David Levin.
2524
2525         [chromium] remove obsolete createView method
2526         https://bugs.webkit.org/show_bug.cgi?id=52437
2527
2528         * DumpRenderTree/chromium/WebViewHost.cpp:
2529         (WebViewHost::createView):
2530         * DumpRenderTree/chromium/WebViewHost.h:
2531
2532 2011-01-14  Brian Weinstein  <bweinstein@apple.com>
2533
2534         Reviewed by Geoff Garen.
2535
2536         ShouldLoadResourceForFrame should use strings, not URLs.
2537         https://bugs.webkit.org/show_bug.cgi?id=52476
2538
2539         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2540         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Update to use a WKStringRef.
2541         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2542
2543 2011-01-14  Tony Gentilcore  <tonyg@chromium.org>
2544
2545         Reviewed by David Levin.
2546
2547         Add Tony Gentilcore as a reviewer
2548         https://bugs.webkit.org/show_bug.cgi?id=52480
2549
2550         * Scripts/webkitpy/common/config/committers.py:
2551
2552 2011-01-14  David Levin  <levin@chromium.org>
2553
2554         Reviewed by Eric Seidel.
2555
2556         check-webkit-style: _FunctionState should keep track of where the function name starts.
2557         https://bugs.webkit.org/show_bug.cgi?id=52454
2558
2559         * Scripts/webkitpy/style/checkers/cpp.py: Added function_name_start_position to
2560         _FunctionState and logic for setting it correctly.
2561         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests.
2562
2563 2011-01-14  Vincent Scheib  <scheib@chromium.org>
2564
2565         Reviewed by David Levin.
2566
2567         Add support to DumpRenderTree to use the GPU rather than software renderer
2568         https://bugs.webkit.org/show_bug.cgi?id=52333
2569
2570         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2571         (main):
2572         * Scripts/webkitpy/layout_tests/port/chromium.py:
2573         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2574
2575 2011-01-14  Tony Chang  <tony@chromium.org>
2576
2577         Reviewed by Kent Tamura.
2578
2579         [chromium] update fonts.conf to fix 6 linux tests in drt
2580         https://bugs.webkit.org/show_bug.cgi?id=52411
2581
2582         * DumpRenderTree/chromium/fonts.conf: Update to match the copy in
2583             chromium's src/webkit/tools/test_shell/resources/fonts.conf
2584
2585 2011-01-14  Eric Seidel  <eric@webkit.org>
2586
2587         Original patch from Peter Gal  <galpater@inf.u-szeged.hu>
2588
2589         Reviewed by Adam Barth.
2590
2591         Fix when running Tools/Scripts/check-webkit-style without arguments.
2592         https://bugs.webkit.org/show_bug.cgi?id=52261#c16
2593
2594         * Scripts/webkitpy/common/checkout/scm.py: Handle None for changed_files argument better in Git.create_patch method.
2595         * Scripts/webkitpy/common/checkout/scm_unittest.py:
2596
2597 2011-01-04  Jochen Eisinger  <jochen@chromium.org>
2598
2599         Reviewed by David Levin.
2600
2601         Store the tempdir object in a variable so it doesn't get deleted too early.
2602         https://bugs.webkit.org/show_bug.cgi?id=51875
2603
2604         * Scripts/update-webkit-auxiliary-libs:
2605         * Scripts/update-webkit-support-libs:
2606
2607 2011-01-14  Eric Seidel  <eric@webkit.org>
2608
2609         Unreviewed.  Make it work in python 2.5.
2610
2611         webkit-patch suggest-reviewers dies when ChangeLogs are missing
2612         https://bugs.webkit.org/show_bug.cgi?id=49158
2613
2614         * Scripts/webkitpy/common/checkout/api_unittest.py:
2615
2616 2011-01-14  Sheriff Bot  <webkit.review.bot@gmail.com>
2617
2618         Unreviewed, rolling out r75774.
2619         http://trac.webkit.org/changeset/75774
2620         https://bugs.webkit.org/show_bug.cgi?id=52431
2621
2622         gtk builds were broken (Requested by loislo2 on #webkit).
2623
2624         * Scripts/webkitpy/common/checkout/scm.py:
2625
2626 2011-01-14  David Levin  <levin@chromium.org>
2627
2628         Reviewed by Shinichiro Hamaji.
2629
2630         check-webkit-style: _FunctionState should detect pure functions.
2631         https://bugs.webkit.org/show_bug.cgi?id=52428
2632
2633         * Scripts/webkitpy/style/checkers/cpp.py: Added detection for if a function declaration
2634         is a pure virtual function.
2635         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests for verifying that pure
2636         virtual functions are correctly detected.
2637
2638 2011-01-13  Ilya Tikhonovsky  <loislo@chromium.org>
2639
2640         Reviewed by Yury Semikhatsky.
2641
2642         Just small fix for problem with check-webkit-style.
2643         It just didn't work for this patch.
2644         Old code can't concatenate a list of strings with None.
2645
2646         * Scripts/webkitpy/common/checkout/scm.py:
2647
2648 2011-01-13  David Levin  <levin@chromium.org>
2649
2650         Reviewed by Shinichiro Hamaji.
2651
2652         check-webkit-style: _FunctionState should use Position to know where items are.
2653         https://bugs.webkit.org/show_bug.cgi?id=52424
2654
2655         * Scripts/webkitpy/style/checkers/cpp.py:
2656         (_FunctionState.*): Changed _FunctionState to use Position instead of line numbers.
2657         (detect_functions): Changed to pass Position's to _FunctionState.begin and
2658         did some minor clean-up.
2659         (*): Other changes are simply about converting to use the Position's in_FunctionState
2660         instead of line numbers.
2661         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Changed the test code
2662         to verify the positions stored in _FunctionState.
2663
2664 2011-01-13  Eric Seidel  <eric@webkit.org>
2665
2666         Reviewed by David Levin.
2667
2668         webkit-patch suggest-reviewers dies when ChangeLogs are missing
2669         https://bugs.webkit.org/show_bug.cgi?id=49158
2670
2671         This is not the most elegant, but it is a very safe fix to this bug.
2672         One advantage of catching ScriptError like this instead of adding a
2673         new added_or_modified_files or fixing all changed_files callers
2674         to use a more specific change_files variant, is that we catch
2675         all kinds of ScriptErrors which might cause our (non-essential)
2676         suggest-reviewers code to fail out.  This should make passing
2677         --suggest-reviewers to webkit-patch upload much more robust
2678         and may even make it possible for us to make it default.
2679
2680         The root of the problem here is that SCM.changed_files includes
2681         deleted ChangeLog paths (from moves, etc) which then when we ask
2682         SVN/Git for the contents of the file at that revision, the command
2683         errors out and Executive.run_command raises a ScriptError.
2684
2685         In the future we might fix this differently by making all current
2686         callers of chagned_files use a more specific method for requesting
2687         what types of changes they're interested in (adds, modifies, deletes, etc.)
2688
2689         * Scripts/webkitpy/common/checkout/api.py:
2690         * Scripts/webkitpy/common/checkout/api_unittest.py:
2691
2692 2011-01-13  Dan Bernstein  <mitz@apple.com>
2693
2694         Reviewed by Alexey Proskuryakov.
2695
2696         <rdar://problem/8827065> REGRESSION (r71884): Cross-origin XHR fails if willSendRequest changes the URL
2697         https://bugs.webkit.org/show_bug.cgi?id=52419
2698
2699         Allow to further control the behavior of the willSendRequest delegate callback by making it
2700         set a different URL in the new request.
2701
2702         * DumpRenderTree/LayoutTestController.cpp:
2703         (addURLToRedirectCallback): Added.
2704         (LayoutTestController::staticFunctions): Added addURLToRedirect.
2705         (LayoutTestController::addURLToRedirect): Added. Adds the redirection to the map.
2706         (LayoutTestController::redirectionDestinationForURL): Added this getter.
2707         * DumpRenderTree/LayoutTestController.h:
2708         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2709         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]): Check
2710         if there is a redirection for the request’s URL, established by addURLToRedirect(), and if so,
2711         change the URL in the new request to the redirect destination.
2712
2713 2011-01-13  Eric Seidel  <eric@webkit.org>
2714
2715         Reviewed by Mihai Parparita.
2716
2717         webkit-patch suggest-reviewers fails due to invalid utf8 in ChangeLog files
2718         https://bugs.webkit.org/show_bug.cgi?id=52416
2719
2720         Example: webkit-patch suggest-reviewers -g ca3890fe74d94d85d6bfa48f9ea497b094d8e717 
2721         UnicodeDecodeError: 'utf8' codec can't decode bytes in position 536-538: invalid data
2722
2723         I also added FIXMEs about the changed_files returning deleted files problem
2724         which is causing the other most common exception for suggest-reviewers
2725         (and is probably breaking sheriff-bots blame detection).
2726
2727         * Scripts/webkitpy/common/checkout/api.py:
2728         * Scripts/webkitpy/common/checkout/api_unittest.py:
2729         * Scripts/webkitpy/common/checkout/scm.py:
2730
2731 2011-01-13  Eric Seidel  <eric@webkit.org>
2732
2733         Reviewed by Adam Barth.
2734
2735         results archives from commit-queue are too large to upload
2736         https://bugs.webkit.org/show_bug.cgi?id=52405
2737
2738         * Scripts/webkitpy/common/system/filesystem.py:
2739         * Scripts/webkitpy/common/system/filesystem_mock.py:
2740         * Scripts/webkitpy/tool/commands/queues.py:
2741
2742 2011-01-13  Alejandro G. Castro  <alex@igalia.com>
2743
2744         Reviewed by Martin Robinson.
2745
2746         [gtk] Zero-sized font does not yet work
2747         https://bugs.webkit.org/show_bug.cgi?id=49793
2748
2749         Set minimum-font-size to 0 for the DRT.
2750
2751         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2752         (resetDefaultsToConsistentValues):
2753
2754 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
2755
2756         Reviewed by Darin Adler.
2757
2758         Make old-run-webkit-tests more robust on buildbots
2759         https://bugs.webkit.org/show_bug.cgi?id=52364
2760
2761         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Pass --exit-after-n-failures 500 to old-run-webkit-tests script.
2762
2763 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
2764
2765         Reviewed by Darin Adler.
2766
2767         Make old-run-webkit-tests more robust on buildbots
2768         https://bugs.webkit.org/show_bug.cgi?id=52364
2769
2770         * Scripts/old-run-webkit-tests: Ensure that testResultsDirectory is empty.
2771
2772 2011-01-13  Tony Chang  <tony@chromium.org>
2773
2774         Reviewed by Kent Tamura.
2775
2776         [chromium] fix plugins/plugin-javascript-access.html on Linux and Mac
2777         https://bugs.webkit.org/show_bug.cgi?id=52332
2778
2779         Forked Info.plist is not longer needed.
2780
2781         * DumpRenderTree/chromium/TestNetscapePlugIn/Info.plist: Removed.
2782
2783 2011-01-13  Mikhail Naganov  <mnaganov@chromium.org>
2784
2785         Reviewed by Timothy Hatcher.
2786
2787         Web Inspector: Cleanup after r75613 -- make all UI-facing strings
2788         to be passed directly to WebInspector.UIString
2789
2790         https://bugs.webkit.org/show_bug.cgi?id=52365
2791
2792         * Scripts/check-inspector-strings:
2793
2794 2011-01-13  Sheriff Bot  <webkit.review.bot@gmail.com>
2795
2796         Unreviewed, rolling out r74881.
2797         http://trac.webkit.org/changeset/74881
2798         https://bugs.webkit.org/show_bug.cgi?id=52357
2799
2800         The EFL builder has been red for days (Requested by abarth on
2801         #webkit).
2802
2803         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2804         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2805
2806 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
2807
2808         Reviewed by David Levin.
2809
2810         Add beforeunload support to WebKitTestRunner
2811         https://bugs.webkit.org/show_bug.cgi?id=52353
2812         
2813         This makes a number of currently failing tests pass.
2814
2815         * WebKitTestRunner/TestController.cpp:
2816         (WTR::runBeforeUnloadConfirmPanel):
2817         (WTR::createOtherPage):
2818         (WTR::TestController::initialize):
2819
2820 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
2821
2822         Reviewed by Sam Weinig.
2823
2824         Detect, identify and recover from WebProcess crashes in run-webkit-tests
2825         https://bugs.webkit.org/show_bug.cgi?id=52330
2826
2827         * Scripts/old-run-webkit-tests: Detect when the regression test tool reports
2828         a web process crash.
2829         * WebKitTestRunner/TestController.cpp:
2830         (WTR::TestController::initialize): Set up a processDidCrash
2831         callback.
2832         (WTR::TestController::processDidCrash): Report that the Web process
2833         crashed.
2834         * WebKitTestRunner/TestController.h:
2835
2836 2011-01-12  David Levin  <levin@chromium.org>
2837
2838         Reviewed by Shinichiro Hamaji.
2839
2840         check-webkit-style -- close_expression function doesn't work correctly.
2841         https://bugs.webkit.org/show_bug.cgi?id=52272
2842
2843         * Scripts/webkitpy/style/checkers/cpp.py:
2844         (Position.__str__): Added a way to convert it to a string which is useful in tests.
2845         (Position.__cmp__): Added a way to compare Position which is useful in tests and
2846         generally useful (for upcoming code changes).
2847         (close_expression): Changed to use Position for input and output.
2848         Also, fixed many bugs such as only working correctly for parenthesis,
2849         not working correctly if given an offset in a line and not finding
2850         the real closing element if there were multiple closing elements in
2851         the same line.
2852         (detect_functions): Adjusted due to the change in arguments for
2853         close_expression.
2854         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2855         (CppStyleTestBase.assert_positions_equal): Added a way to verify that
2856         two positions are the same.
2857         (CppStyleTest.test_position): Added tests for the __str_ and __cmp__ methods.
2858         (CppStyleTest.test_close_expression): Added tests to catch the issues
2859         that were fixed.
2860
2861 2011-01-12  Sheriff Bot  <webkit.review.bot@gmail.com>
2862
2863         Unreviewed, rolling out r75576.
2864         http://trac.webkit.org/changeset/75576
2865         https://bugs.webkit.org/show_bug.cgi?id=52304
2866
2867         broke rebaseline-chromium-webkit-test (Requested by thakis on
2868         #webkit).
2869
2870         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2871         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2872         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
2873         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2874         * Scripts/webkitpy/layout_tests/port/base.py:
2875         * Scripts/webkitpy/layout_tests/port/chromium.py:
2876         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2877         * Scripts/webkitpy/layout_tests/port/test.py:
2878         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2879         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2880         * Scripts/webkitpy/style/checkers/test_expectations.py:
2881         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
2882
2883 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
2884
2885         Reviewed by Darin Adler.
2886
2887         Add a no-build option to run-webkit-tests, to avoid building DRT/WKTR
2888         https://bugs.webkit.org/show_bug.cgi?id=52307
2889
2890         * Scripts/old-run-webkit-tests:
2891
2892 2011-01-12  Koan-Sin Tan  <koansin.tan@gmail.com>
2893
2894         Reviewed by Martin Robinson.
2895
2896         [Gtk] WebKitGtk+ doesn't build on Mac OS X 10.6
2897         https://bugs.webkit.org/show_bug.cgi?id=50867
2898
2899         Fixed library extention for Mac in webkitdirs.pm and type conflict in
2900         TestNetscapePlugin.cpp 
2901
2902         * GNUmakefile.am: Don't use AppKit when compiling TestNetscapePlugin for GTK+
2903         * Scripts/webkitdirs.pm:
2904
2905 2011-01-12  Mikhail Naganov  <mnaganov@chromium.org>
2906
2907         Reviewed by Pavel Feldman.
2908
2909         Add check-inspector-strings script.
2910
2911         https://bugs.webkit.org/show_bug.cgi?id=52295
2912
2913         * Scripts/check-inspector-strings: Added.
2914
2915 2011-01-12  Adam Roben  <aroben@apple.com>
2916
2917         Advertise the .testnetscape file extension on Windows
2918
2919         Fixes <http://webkit.org/b/52298>
2920         plugins/no-mime-with-valid-extension.html fails on Windows
2921
2922         Reviewed by Dan Bernstein.
2923
2924         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Added a
2925         FileExtents field to map the .testnetscape file extension to the
2926         application/x-webkit-test-netscape MIME type, just as we do on Mac.
2927
2928 2011-01-12  Adam Barth  <abarth@webkit.org>
2929
2930         Reviewed by Eric Seidel.
2931
2932         Make webkit-patch support subdirectories for SVN checkouts
2933         https://bugs.webkit.org/show_bug.cgi?id=52261
2934
2935         os.relpath does not exist on Python 2.5, so we need to call our version
2936         of the API.
2937
2938         * Scripts/webkitpy/common/checkout/scm.py:
2939
2940 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
2941
2942         Reviewed by Eric Seidel.
2943
2944         Close additional pages opened during a test once the test completes.
2945         https://bugs.webkit.org/show_bug.cgi?id=52276
2946
2947         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2948         (WTR::InjectedBundle::done):
2949
2950 2011-01-11  David Levin  <levin@chromium.org>
2951
2952         Reviewed by Eric Seidel.
2953
2954         Errors should be separated from the command line in bot messages.
2955         https://bugs.webkit.org/show_bug.cgi?id=52275
2956
2957         * Scripts/webkitpy/common/system/executive.py:
2958         (ScriptError.message_with_output): Added a newline to separate the command
2959         line from the errors.
2960         * Scripts/webkitpy/common/system/executive_unittest.py:
2961         (ScriptErrorTest.test_message_with_output): Added tests for the various code
2962         paths in message_with_output.
2963
2964 2011-01-11  Eric Seidel  <eric@webkit.org>
2965
2966         Unreviewed.
2967
2968         commit-queue should know how to upload archived results (for test flakes or general failures)
2969         https://bugs.webkit.org/show_bug.cgi?id=52048
2970
2971         The zips are mostly empty due to forgetting -r.
2972         Expected diffs were not being pulled from the archive due
2973         to the archive having longer paths than I realized.
2974
2975         * Scripts/webkitpy/common/system/workspace.py:
2976         * Scripts/webkitpy/common/system/workspace_unittest.py:
2977         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2978         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2979
2980 2011-01-11  Dirk Pranke  <dpranke@chromium.org>
2981
2982         Reviewed by Ojan Vafai.
2983
2984         The current modifier parsing code in test_expectations is
2985         fragile and hard-coded, so it's not easy to understand the logic
2986         or easily add new types of modifiers (like GPU vs. CPU testing
2987         for graphics tests, or 32-bit vs. 64-bit differences).
2988
2989         This is the first of two patches that will add in more generic
2990         support and then eliminate the GPU-specific test expectations
2991         files for Chromium.
2992
2993         This patch adds two standalone objects for handling modifiers. The
2994         rules for interpreting modifiers, precedence, and conflicts are
2995         given in the docstring to the ModifierMatcher class, which
2996         returns ModifierMatchResult objects.
2997         
2998         This patch also adds routines to the Port interface and a
2999         default set of values in the base object, in order to obtain the
3000         values needed on a given test run. These values are then passed
3001         to the expectation parser. This also allows us to clean up the
3002         logic used to lint all of the different configurations in a
3003         single test_expectations.txt file.
3004
3005         The next patch will merge in the separate GPU expectations file.
3006
3007         https://bugs.webkit.org/show_bug.cgi?id=51222
3008
3009         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
3010         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
3011         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
3012         * Scripts/webkitpy/layout_tests/port/base.py:
3013         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3014         * Scripts/webkitpy/layout_tests/port/chromium.py:
3015         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3016         * Scripts/webkitpy/layout_tests/port/test.py:
3017         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3018         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3019
3020 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
3021
3022         Reviewed by Adam Barth.
3023
3024         Make webkit-patch support subdirectories for SVN checkouts
3025         https://bugs.webkit.org/show_bug.cgi?id=52261
3026
3027         * Scripts/webkitpy/common/checkout/scm.py:
3028         * Scripts/webkitpy/style_references.py:
3029         * Scripts/webkitpy/tool/main.py:
3030         * Scripts/webkitpy/tool/steps/preparechangelog.py:
3031
3032 2011-01-11  Eric Seidel  <eric@webkit.org>
3033
3034         Unreviewed.
3035
3036         commit-queue should know how to upload archived results (for test flakes or general failures)
3037         https://bugs.webkit.org/show_bug.cgi?id=52048
3038
3039         I changed the API for archive_last_layout_test_results w/o updating the implementation.  Oops.
3040         This fixes an exception seen on the commit-queue when attempting to report flaky tests.
3041
3042         * Scripts/webkitpy/common/system/workspace.py:
3043         * Scripts/webkitpy/common/system/workspace_unittest.py:
3044         * Scripts/webkitpy/tool/commands/queues.py:
3045
3046 2011-01-11  Sam Weinig  <sam@webkit.org>
3047
3048         Roll r75474 back in.
3049
3050 2011-01-11  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
3051
3052         Reviewed by Kenneth Rohde Christiansen.
3053
3054         [Qt] Remove uses of QFuture since it isn't supported on all platforms.
3055         https://bugs.webkit.org/show_bug.cgi?id=51204
3056
3057         * QtTestBrowser/webpage.h:
3058         (QtNAMThread::QtNAMThread):
3059         (QtNAMThread::networkAccessManager):
3060         (QtNAMThread::run):
3061
3062 2011-01-11  Peter Varga  <pvarga@webkit.org>
3063
3064         Unreviewed.
3065
3066         Add myself to committers' list.
3067
3068         * Scripts/webkitpy/common/config/committers.py:
3069
3070 2011-01-11  Eric Seidel  <eric@webkit.org>
3071
3072         Reviewed by Adam Barth.
3073
3074         commit-queue should know how to upload archived results (for test flakes or general failures)
3075         https://bugs.webkit.org/show_bug.cgi?id=52048
3076
3077         Now the queue will always upload results.  Either the entire zip, or just
3078         the diffs.txt in the case of text failures.
3079
3080         This should make understanding flakes much easier, and paves the way
3081         for having the EWS run layout tests (and upload failures).
3082
3083         In order to upload .zip files I had to teach bugzilla.py to autodetect
3084         mime types from the filename.  Since mimetypes.py doesn't include a mapping
3085         for .patch files, I have it add one before calling guess_type.
3086
3087         We may find that always uploading the whole zip instead of just the -diffs.txt
3088         file is preferable, but for now I'm keeping the old behavior because it makes
3089         quickly understanding text failures easy.
3090
3091         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3092         * Scripts/webkitpy/common/system/workspace.py: Added.
3093         * Scripts/webkitpy/common/system/workspace_unittest.py: Added.
3094         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3095         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3096         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3097         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3098         * Scripts/webkitpy/tool/commands/queues.py:
3099         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3100
3101 2011-01-10  Sheriff Bot  <webkit.review.bot@gmail.com>
3102
3103         Unreviewed, rolling out r75464.
3104         http://trac.webkit.org/changeset/75464
3105         https://bugs.webkit.org/show_bug.cgi?id=52193
3106
3107         Followup rollout for 75474 (Requested by Ossy on #webkit).
3108
3109         * MiniBrowser/mac/BrowserWindowController.m:
3110         (-[BrowserWindowController awakeFromNib]):
3111         * MiniBrowser/win/BrowserView.cpp:
3112         (BrowserView::create):
3113         * WebKitTestRunner/TestController.cpp:
3114         (WTR::createOtherPage):
3115         (WTR::TestController::initialize):
3116
3117 2011-01-10  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3118
3119         Reviewed by Csaba Osztrogonác.
3120
3121         [Qt] Baseline qt_minimal configuration
3122         https://bugs.webkit.org/show_bug.cgi?id=51313
3123
3124         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3125         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): Add
3126         QT_NO_UNDOSTACK guard.
3127
3128         * QtTestBrowser/launcherwindow.cpp:
3129         (LauncherWindow::createChrome): Add QT_NO_SHORTCUT and QT_NO_PRINTER
3130         guards.
3131         (LauncherWindow::applyZoom): Add QT_NO_ANIMATION guard.
3132         (LauncherWindow::screenshot): Add QT_NO_FILEDIALOG guard.
3133         (LauncherWindow::selectElements): Add QT_NO_INPUTDIALOG guard.
3134         (LauncherWindow::showUserAgentDialog): Add QT_NO_COMBOBOX guard.
3135
3136         * QtTestBrowser/launcherwindow.h:
3137         * QtTestBrowser/locationedit.cpp: Add QT_NO_INPUTDIALOG guard.
3138         * QtTestBrowser/locationedit.h: Ditto.
3139
3140         * QtTestBrowser/mainwindow.cpp:
3141         (MainWindow::buildUI): Add QT_NO_INPUTDIALOG, QT_NO_SHORTCUT and
3142         QT_NO_UNDOSTACK guards.
3143         (MainWindow::setAddressUrl): Add QT_NO_INPUTDIALOG guard.
3144         (MainWindow::changeLocation): Ditto.
3145         (MainWindow::openFile): Add QT_NO_FILEDIALOG guard.
3146         (MainWindow::openLocation): Add QT_NO_INPUTDIALOG guard.
3147
3148         * QtTestBrowser/webpage.cpp:
3149         (WebPage::openUrlInDefaultBrowser): Add QT_NO_DESKTOPSERVICES guard.
3150         (WebPage::authenticationRequired): Add QT_NO_LINEEDIT guard.
3151
3152         * QtTestBrowser/webview.cpp:
3153         (WebViewGraphicsBased::animatedFlip): Add QT_NO_ANIMATION guard.
3154         (WebViewGraphicsBased::animatedYFlip): Ditto.
3155
3156 2011-01-10  Sam Weinig  <sam@webkit.org>
3157
3158         Fix build.
3159
3160         * MiniBrowser/mac/BrowserWindowController.m:
3161         (-[BrowserWindowController awakeFromNib]):
3162         * MiniBrowser/win/BrowserView.cpp:
3163         (BrowserView::create):
3164         * WebKitTestRunner/TestController.cpp:
3165         (WTR::createOtherPage):
3166         (WTR::TestController::initialize):
3167
3168 2011-01-10  Eric Seidel  <eric@webkit.org>
3169
3170         Reviewed by Ojan Vafai.
3171
3172         style-queue messages are way too long for big patches
3173         https://bugs.webkit.org/show_bug.cgi?id=52161
3174
3175         We definitely could build much fancier list-to-string-with-limit functions
3176         but this should be sufficient for our needs at the moment.
3177
3178         * Scripts/webkitpy/common/system/executive.py:
3179         * Scripts/webkitpy/common/system/executive_unittest.py:
3180
3181 2011-01-10  Tony Chang  <tony@chromium.org>
3182
3183         Unreviewed, rolling out r75398.
3184         http://trac.webkit.org/changeset/75398
3185         https://bugs.webkit.org/show_bug.cgi?id=52008
3186
3187         Some layout tests are crashing on Chromium Win.
3188
3189         * DumpRenderTree/chromium/WebViewHost.cpp:
3190         (WebViewHost::updatePaintRect):
3191         * DumpRenderTree/chromium/WebViewHost.h:
3192
3193 2011-01-10  Adam Roben  <aroben@apple.com>
3194
3195         Roll out r75392
3196
3197         It isn't needed now that r75289 has been rolled out.
3198
3199         * Scripts/run-javascriptcore-tests:
3200
3201 2011-01-10  Maciej Stachowiak  <mjs@apple.com>
3202
3203         Reviewed by Anders Carlsson.
3204
3205         WebKitTestRunner uses crazy amounts of CPU, making layout tests slow and flaky
3206         https://bugs.webkit.org/show_bug.cgi?id=52160
3207
3208         * WebKitTestRunner/mac/TestControllerMac.mm:
3209         (WTR::TestController::platformRunUntil): Instead of busy-looping, wait for the timeout.
3210         Anything that can make runUntil() conditions turn true will happen on a run loop cycle
3211         anyway.
3212
3213 2011-01-10  Tony Chang  <tony@chromium.org>
3214
3215         Reviewed by Mihai Parparita.
3216
3217         [chromium] fix for animated gif layout tests
3218         https://bugs.webkit.org/show_bug.cgi?id=52008
3219
3220         * DumpRenderTree/chromium/WebViewHost.cpp: Schedule a paint when we update the paint rect
3221             to trigger gif animations.
3222         (WebViewHostPaintTask::WebViewHostPaintTask):
3223         (WebViewHostPaintTask::runIfValid):
3224         (WebViewHost::updatePaintRect):
3225         * DumpRenderTree/chromium/WebViewHost.h:
3226         (WebViewHost::taskList):
3227
3228 2011-01-10  Alejandro G. Castro  <alex@igalia.com>
3229
3230         Reviewed by Xan Lopez.
3231
3232         [GTK] Fix gtk2 compilation for master
3233         https://bugs.webkit.org/show_bug.cgi?id=51885
3234
3235         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
3236         (createBitmapContextFromWebView): Replaced the old
3237         gdk_drawable_get_size with gdk_pixmap_get_size.
3238
3239 2011-01-10  Patrick Gansterer  <paroga@webkit.org>
3240
3241         Reviewed by Laszlo Gombos.
3242
3243         [WINCE] Reenable NPAPI after r75203
3244         https://bugs.webkit.org/show_bug.cgi?id=52109
3245
3246         Remove the !isWinCE() check for ENABLE_NETSCAPE_PLUGIN_API and replace
3247         it with !isEfl(), because EFL port does not support NPAPI (yet).
3248
3249         * Scripts/build-webkit:
3250
3251 2011-01-10  Adam Roben  <aroben@apple.com>
3252
3253         Skip some asserting JS tests
3254
3255         See <http://webkit.org/b/52156>.
3256
3257         * Scripts/run-javascriptcore-tests:
3258
3259 2011-01-10  Martin Robinson  <mrobinson@igalia.com>
3260
3261         Reviewed by Xan Lopez.
3262
3263         [GTK] build-webkit disable Blob support via arguments passed to automake
3264         https://bugs.webkit.org/show_bug.cgi?id=52097
3265
3266         * Scripts/build-webkit: Enable Blob support when building WebKitGTK+ via
3267         build-webkit.
3268
3269 2011-01-10  Adam Roben  <aroben@apple.com>
3270
3271         Use the same name and description for TestNetscapePlugin on Windows and
3272         Mac
3273
3274         Fixes <http://webkit.org/b/52151>
3275         fast/frames/iframe-reparenting-plugins.html fails on Windows
3276
3277         Reviewed by Steve Falkenburg.
3278
3279         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Copied
3280         the name and description from Mac's Info.plist.
3281
3282 2011-01-10  Siddharth Mathur <siddharth.mathur@nokia.com>
3283
3284         Reviewed by Laszlo Gombos.
3285
3286         [Qt][WK2] Guard gcc-specific syntax
3287
3288         Non-gcc based compliers choke on the "-include"
3289         syntax for preinclude, place guard around it.
3290
3291         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3292         * WebKitTestRunner/qt/WebKitTestRunner.pro:
3293
3294 2011-01-10  Andreas Kling  <kling@webkit.org>
3295
3296         Reviewed by Simon Hausmann.
3297
3298         [Qt] [WK2] MiniBrowser does not load pages opened in new windows
3299         https://bugs.webkit.org/show_bug.cgi?id=52111
3300
3301         When getting a createNewPage() callback from QWKPage, create the
3302         new page with the same QWKContext as the page that is passed to
3303         the callback.
3304
3305         * MiniBrowser/qt/BrowserView.h:
3306         * MiniBrowser/qt/BrowserWindow.cpp:
3307         (newPageFunction):
3308         (BrowserWindow::BrowserWindow):
3309         * MiniBrowser/qt/BrowserWindow.h:
3310
3311 2011-01-10  Andreas Kling  <kling@webkit.org>
3312
3313         Reviewed by Kenneth Rohde Christiansen.
3314
3315         [Qt] MiniBrowser: Remove superfluous createNewPage() callback
3316
3317         BrowserView set its own useless createNewPage() callback on QWKPage.
3318         This was immediately overridden by BrowserWindow anyway, so remove
3319         the BrowserView one.
3320
3321         * MiniBrowser/qt/BrowserView.cpp:
3322         (BrowserView::BrowserView):
3323
3324 2011-01-10  John Knottenbelt  <jknotten@chromium.org>
3325
3326         Reviewed by Jeremy Orlow.
3327
3328         [Chromium] Remove non-client-based Geolocation code
3329         https://bugs.webkit.org/show_bug.cgi?id=50921
3330
3331         * DumpRenderTree/chromium/LayoutTestController.cpp:
3332         (LayoutTestController::setGeolocationPermission):
3333         (LayoutTestController::setMockGeolocationPosition):
3334         (LayoutTestController::setMockGeolocationError):
3335         * DumpRenderTree/chromium/WebViewHost.cpp:
3336         (WebViewHost::geolocationClientMock):
3337         (WebViewHost::reset):
3338         * DumpRenderTree/chromium/WebViewHost.h:
3339
3340 2011-01-10  Eric Seidel  <eric@webkit.org>
3341
3342         Reviewed by Adam Barth.
3343
3344         Commit bot tried to land r? cq+ patch
3345         https://bugs.webkit.org/show_bug.cgi?id=36638
3346
3347         It should now be possible to post a patch with r? and cq+ and the
3348         commit-queue will correctly wait for the r+ before attempting to land the patch.
3349         (This was a feature requested by several users.)
3350
3351         One caveat: We don't actually reject r-, cq+ patches from the queue
3352         (we just ignore them), but I think that's OK for now.
3353
3354         I also noticed that setting r- once a commit-queue node had grabbed
3355         a patch would not properly cancel the landing.  That's fixed and
3356         tested in this patch.
3357
3358         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3359         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3360         * Scripts/webkitpy/tool/bot/feeders.py:
3361         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
3362
3363 2011-01-08  Benjamin Poulain  <benjamin.poulain@nokia.com>
3364
3365         Reviewed by Kenneth Rohde Christiansen.
3366
3367         [Qt] QtWebKit crashes when using XMLHttpRequest from the unload event
3368         https://bugs.webkit.org/show_bug.cgi?id=51934
3369
3370         When accessing the network from the destructor of QWebPage, the network access manager
3371         was already deleted because the object WebPage was already destructed.
3372
3373         This solve the problem by linking the lifetime of the network access manager to WebPage's QObject.
3374         The object is now destructed in the destructor of QObject.
3375
3376         * QtTestBrowser/webpage.cpp:
3377         (WebPage::WebPage):
3378         (WebPage::setQnamThreaded):
3379         * QtTestBrowser/webpage.h:
3380         (QtNAMThread::QtNAMThread):
3381
3382 2011-01-08  Eric Seidel  <eric@webkit.org>
3383
3384         Reviewed by Ojan Vafai.
3385
3386         test_failures.py should not mention TestShell (long live DumpRenderTree!)
3387         https://bugs.webkit.org/show_bug.cgi?id=52067
3388
3389         I ran test-webkitpy, but didn't bother adding a unit test for this string change.
3390         https://bugs.webkit.org/show_bug.cgi?id=51138#c3 is an example of why this is needed.
3391
3392         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
3393
3394 2011-01-08  Eric Seidel  <eric@webkit.org>
3395
3396         Reviewed by Mihai Parparita.
3397
3398         commit-queue hangs when the ChangeLog diff is bad
3399         https://bugs.webkit.org/show_bug.cgi?id=52072
3400
3401         * Scripts/webkitpy/tool/steps/validatechangelogs.py:
3402         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
3403
3404 2011-01-08  Adam Barth  <abarth@webkit.org>
3405
3406         Teach svn-apply how to re-write WebCore to Source/WebCore.
3407
3408         * Scripts/VCSUtils.pm:
3409
3410 2011-01-07  Adam Barth  <abarth@webkit.org>
3411
3412         Rubber-stamped by Eric Seidel.
3413
3414         Move WebCore to Source
3415         https://bugs.webkit.org/show_bug.cgi?id=52050
3416
3417         Update the tools to understand WebCore's new location.
3418
3419         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3420         * DumpRenderTree/wscript:
3421         * GNUmakefile.am:
3422         * Scripts/build-webkit:
3423         * Scripts/do-file-rename:
3424         * Scripts/do-webcore-rename:
3425         * Scripts/generate-qt-inspector-resource:
3426         * Scripts/prepare-ChangeLog:
3427         * Scripts/run-bindings-tests:
3428         * Scripts/update-iexploder-cssproperties:
3429         * Scripts/update-sources-list.py:
3430         * Scripts/update-webkit-localizable-strings:
3431         * Scripts/webkitdirs.pm:
3432         * Scripts/webkitpy/common/config/build.py:
3433         * Scripts/webkitpy/common/config/build_unittest.py:
3434         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
3435         * Scripts/webkitpy/style/checker.py:
3436         * Scripts/webkitpy/style/checker_unittest.py:
3437         * WebKitTestRunner/DerivedSources.pro:
3438         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3439         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh:
3440         * wx/browser/wscript:
3441         * wx/build/settings.py:
3442
3443 2011-01-07  Maciej Stachowiak  <mjs@apple.com>
3444
3445         Reviewed by Sam Weinig.
3446
3447         Make WebKitTestRunner rest between loads more robust to avoid test crashes
3448         https://bugs.webkit.org/show_bug.cgi?id=52086
3449
3450         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3451         (WTR::InjectedBundle::didReceiveMessage):
3452         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3453         (WTR::LayoutTestController::notifyDone):
3454         * WebKitTestRunner/TestController.cpp:
3455         (WTR::TestController::resetStateToConsistentValues):
3456         (WTR::TestController::run):
3457
3458 2011-01-07  James Robinson  <jamesr@chromium.org>
3459
3460         Revert "Implement mozilla's animationTime property"
3461         https://bugs.webkit.org/show_bug.cgi?id=51952
3462
3463         This approach isn't quite right.
3464
3465         * DumpRenderTree/chromium/WebViewHost.cpp:
3466         (WebViewHost::paintInvalidatedRegion):
3467
3468 2011-01-07  Adam Roben  <aroben@apple.com>
3469
3470         Build master fix
3471
3472         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3473         (RunWebKitTests.start): Don't try to concatenate a list and a string.
3474
3475 2011-01-07  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>
3476
3477         Reviewed by Csaba Osztrogonác.
3478
3479         run-qtwebkit-tests should be able to kill a testsuite.
3480
3481         Add new option in the script that can setup a timeout for a test.
3482         If the test execution takes more then specified time then the test
3483         would be terminated.
3484
3485         [Qt] run-qtwebkit-tests needs timeout
3486         https://bugs.webkit.org/show_bug.cgi?id=51894
3487
3488         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3489         * Scripts/run-qtwebkit-tests:
3490
3491 2011-01-07  Csaba Osztrogonác  <ossy@webkit.org>
3492
3493         Unreviewed fix after r75233.
3494
3495         Based on idea from Eric Seidel.
3496
3497         Add remote zip file handling to webkitpy.
3498         https://bugs.webkit.org/show_bug.cgi?id=50901
3499
3500         * Scripts/webkitpy/common/system/fileset.py: Make python 2.5 happy.
3501
3502 2011-01-07  Shane Stephens  <shanestephens@google.com>
3503
3504         Reviewed by Eric Seidel.
3505
3506         svn-apply: should support git binary delta diffs
3507         https://bugs.webkit.org/show_bug.cgi?id=38864
3508
3509         * Scripts/VCSUtils.pm:
3510         * Scripts/svn-apply:
3511
3512 2011-01-06  Julie Parent  <jparent@chromium.org>
3513
3514         Reviewed by Eric Seidel.
3515
3516         Test Result Server not removing old results.
3517         https://bugs.webkit.org/show_bug.cgi?id=52012
3518
3519         * TestResultServer/model/jsonresults.py:
3520         Fix off-by-one: Truncate if >= num_runs, not just >.
3521         * TestResultServer/model/jsonresults_unittest.py:
3522         Add unit test to test that merging in a new result with the same value
3523         as the last result causes previous result to fall off.
3524
3525 2011-01-06  James Kozianski  <koz@chromium.org>
3526
3527         Reviewed by Mihai Parparita.
3528
3529         Add classes to provide a consistent interface to a set of files.
3530         https://bugs.webkit.org/show_bug.cgi?id=50901
3531
3532         These classes allow us to write code that is agnostic to whether a
3533         particular set of files resides in a local directory or in a zip file
3534         on a remote machine.
3535
3536         * Scripts/webkitpy/common/system/directoryfileset.py: Added.
3537         * Scripts/webkitpy/common/system/directoryfileset_unittest.py: Added.
3538         * Scripts/webkitpy/common/system/fileset.py: Added.
3539         * Scripts/webkitpy/common/system/filesystem.py:
3540         * Scripts/webkitpy/common/system/filesystem_mock.py:
3541         * Scripts/webkitpy/common/system/zipfileset.py: Added.
3542         * Scripts/webkitpy/common/system/zipfileset_unittest.py: Added.
3543
3544 2011-01-06  Eric Seidel  <eric@webkit.org>
3545
3546         Reviewed by Adam Barth.
3547
3548         NetworkTransaction should log the url it is retrying
3549         https://bugs.webkit.org/show_bug.cgi?id=52043
3550
3551         * Scripts/webkitpy/common/net/networktransaction.py:
3552         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
3553
3554 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
3555
3556         Windows build fix.
3557         Import os before using it.
3558
3559         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3560
3561 2011-01-06  Eric Seidel  <eric@webkit.org>
3562
3563         Reviewed by Adam Barth.
3564
3565         StyleQueue fails to report errors when patches have many files
3566         https://bugs.webkit.org/show_bug.cgi?id=52042
3567
3568         This is one of at least two errors preventing style error reporting at the moment.
3569         When we moved to passing the list of files to check explicitly,
3570         we started to exceed the 500 character TEXT field limit for our AppEngine model object.
3571         We could change the type of the QueueStatus.message type, or we could
3572         just teach statusserver.py how to clamp values (and warn when it does).
3573         I chose the latter path.
3574
3575         * Scripts/webkitpy/common/net/statusserver.py:
3576
3577 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
3578
3579         Reviewed by Stephanie Lewis.
3580         
3581         Fix syntax error in script.
3582
3583         Windows bots need to archive/unarchive builds to/from configuration-specific directories
3584         https://bugs.webkit.org/show_bug.cgi?id=51996
3585
3586         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3587
3588 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3589
3590         Unreviewed, fixing WinCE build after r75196.
3591
3592         WinCE port does not (yet) support NPAPI.
3593
3594         * Scripts/build-webkit:
3595
3596 2011-01-06  Xan Lopez  <xlopez@igalia.com>
3597
3598         Reviewed by Darin Adler.
3599
3600         File::Spec->rel2abs in sunspider-compare-results mangles parameters
3601         https://bugs.webkit.org/show_bug.cgi?id=52015
3602
3603         * Scripts/sunspider-compare-results: call rel2abs on our arguments
3604         after the platform has been detected, otherwise the script will
3605         mangle things like '--gtk' into '/a/path/--gtk', breaking the
3606         detection.
3607
3608 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3609
3610         Reviewed by Eric Seidel.
3611
3612         Add ENABLE_NETSCAPE_PLUGIN_API, ENABLE_ORIENTATION_EVENTS and ENABLE_TOUCH_EVENTS flags to build-webkit
3613         https://bugs.webkit.org/show_bug.cgi?id=51346
3614
3615         * Scripts/build-webkit:
3616
3617 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
3618
3619         Reviewed by Adam Roben.
3620
3621         Windows bots need to archive/unarchive builds to/from configuration-specific directories
3622         https://bugs.webkit.org/show_bug.cgi?id=51996
3623         
3624         After the configuration directory change, we were archiving the incorrect directory for
3625         build product, so we were running tests on the wrong binaries.
3626         
3627         This change archives the correct directory, and also unarchives it into a configuration-
3628         specific directory.
3629
3630         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Use a configuration-specific directory on Windows.
3631         * BuildSlaveSupport/built-product-archive: Unarchive/archive to/from proper directory.
3632
3633 2011-01-06  Eric Seidel  <eric@webkit.org>
3634
3635         Reviewed by Mihai Parparita.
3636
3637         commit-queue mentions "Text diff mismatch" 4 times instead of once per failure
3638         https://bugs.webkit.org/show_bug.cgi?id=52002
3639
3640         See an example of this here:
3641         https://bugs.webkit.org/show_bug.cgi?id=51314#c2
3642
3643         It's due to the fact that we pass around TestFailure() instance
3644         objects and yet expect them to all compare to be the same.
3645
3646         This is bad.  We should either have shared instances of these values
3647         or we should just pass around the class names.  There are already hacks
3648         in place to make TestFailure objects pass equality tests, I just added
3649         a __hash__ implementation so they can be used in sets as expected.
3650
3651         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3652         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
3653
3654 2011-01-06  Evan Martin  <evan@chromium.org>
3655
3656         Reviewed by Tony Chang.
3657
3658         [gdb] handle inaccessible memory and UChar*
3659         https://bugs.webkit.org/show_bug.cgi?id=52003
3660
3661         To pretty-print a UChar*, we just grope around in the memory
3662         looking for a terminating NUL.  We need to handle the exception
3663         that can occur when we poke into an invalid location.
3664
3665         Additionally, the logic for choosing which pretty-printer would
3666         early return before hitting the point where we'd use the UChar*
3667         printer.  (Did this ever work?  How did it regress?)
3668
3669         * gdb/webkit.py:
3670
3671 2011-01-05  Brian Weinstein  <bweinstein@apple.com>
3672
3673         Reviewed by Ada Chan.
3674
3675         WebKit2: Should be able to call into injected bundle to ask if we should allow resource loads
3676         https://bugs.webkit.org/show_bug.cgi?id=51969
3677         
3678         Add shouldLoadResourceForFrame to WTR::InjectedBundlePage.
3679
3680         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3681         (WTR::InjectedBundlePage::InjectedBundlePage):
3682         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Stub implementation.
3683         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3684
3685 2011-01-06  James Robinson  <jamesr@chromium.org>
3686
3687         Reviewed by Simon Fraser.
3688
3689         Implement mozilla's animationTime property
3690         https://bugs.webkit.org/show_bug.cgi?id=51952
3691
3692         Chromium DRT support for webkitAnimationTime.
3693
3694         * DumpRenderTree/chromium/WebViewHost.cpp:
3695         (WebViewHost::paintInvalidatedRegion):
3696
3697 2011-01-06  Julie Parent  <jparent@chromium.org>
3698
3699         Reviewed by Tony Chang.
3700
3701         Test Result Server always truncates number of results to JSON_RESULTS_MAX_BUILDS
3702         https://bugs.webkit.org/show_bug.cgi?id=51217
3703
3704         * TestResultServer/model/jsonresults.py:
3705         Pass num_runs through to _remove_items_over_max_number_of_builds, and use the value.
3706         Adds missing documentation.
3707         * TestResultServer/model/jsonresults_unittest.py:
3708         Add unit test to test that truncation happens at smaller value than JSON_RESULTS_MAX_BUILDS.
3709         Update test_merge to take a number of builds to truncate at.
3710
3711 2011-01-06  Adam Barth  <abarth@webkit.org>
3712
3713         Reviewed by Eric Seidel.
3714
3715         The EWS should log outside of the working directory
3716         https://bugs.webkit.org/show_bug.cgi?id=51986
3717
3718         This patch prepare us for using git clean -x -d -f in the EWS wrapper
3719         script, which will actually clean the working copy back to a pristine
3720         state instead of leaving untracked directories and ignored files.
3721
3722         * Scripts/webkitpy/tool/commands/queues.py:
3723         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3724
3725 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
3726
3727         Windows build fix.
3728         Back out attempted change to built-product-archive.
3729
3730         * BuildSlaveSupport/built-product-archive:
3731
3732 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
3733
3734         Windows build fix.
3735         Include configuration name when unpacking a build archive.
3736
3737         Needed, since we split Windows build results into configuration-specific directories
3738         under WebKitOutputDir.
3739
3740         * BuildSlaveSupport/built-product-archive:
3741
3742 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
3743
3744         Reviewed by Darin Adler.
3745
3746         Debug and Release builds on Windows clobber each other
3747         https://bugs.webkit.org/show_bug.cgi?id=49185
3748
3749         Changes the structure of WebKitBuild build products directory so we
3750         completely separate each build configuration into independent directories.
3751         
3752         Although we previously had per-configuration directories for obj, this change adds
3753         per-configuration directories for bin, lib, obj, and include. Each configuration's
3754         build products are stored within a directory inside of WebKitBuild.
3755         
3756         Most use of $(WebKitOutputDir) in the build files has been replaced by $(ConfigurationBuildDir),
3757         defined in common.vsprops to be $(WebKitOutputDir)\$(ConfigurationName).
3758
3759         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops:
3760         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd:
3761         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd:
3762         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
3763         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd:
3764         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd:
3765         * DumpRenderTree/win/ImageDiffCommon.vsprops:
3766         * DumpRenderTree/win/ImageDiffPostBuild.cmd:
3767         * DumpRenderTree/win/ImageDiffPreBuild.cmd:
3768         * FindSafari/FindSafari.vcproj:
3769         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
3770         * MiniBrowser/MiniBrowserPostBuild.cmd:
3771         * MiniBrowser/MiniBrowserPreBuild.cmd:
3772         * Scripts/webkitdirs.pm:
3773         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
3774         * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops:
3775         * TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd:
3776         * TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd:
3777         * TestWebKitAPI/win/copy-resources.cmd:
3778         * WebKitAPITest/WebKitAPITestCommon.vsprops:
3779         * WebKitAPITest/WebKitAPITestPostBuild.cmd:
3780         * WebKitAPITest/WebKitAPITestPreBuild.cmd:
3781         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
3782         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
3783         * WebKitTestRunner/win/InjectedBundle.vcproj:
3784         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops:
3785         * WebKitTestRunner/win/InjectedBundlePostBuild.cmd:
3786         * WebKitTestRunner/win/InjectedBundlePreBuild.cmd:
3787         * WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd:
3788         * WebKitTestRunner/win/WebKitTestRunnerPreBuild.cmd:
3789         * WinLauncher/WinLauncherCommon.vsprops:
3790         * WinLauncher/WinLauncherPostBuild.cmd:
3791         * WinLauncher/WinLauncherPreBuild.cmd:
3792
3793 2011-01-05  Jan Erik Hanssen  <jhanssen@sencha.com>
3794
3795         Reviewed by Ariya Hidayat.
3796
3797         [Qt] TestNetscapePlugin doesn't link on OS X
3798         https://bugs.webkit.org/show_bug.cgi?id=51948
3799
3800         Only add a dependency on libX11 on X11 systems
3801
3802         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3803
3804 2011-01-05  Jeff Miller  <jeffm@apple.com>
3805
3806         Reviewed by Adam Roben.
3807
3808         check-webkit-style should allow unnecessary parameter names in WebKit2 APIs because we're matching CF's header style
3809         https://bugs.webkit.org/show_bug.cgi?id=51970
3810
3811         * Scripts/webkitpy/style/checker.py:
3812         Add -readability/naming for WebKit2 C API directories.
3813
3814 2011-01-05  Eric Seidel  <eric@webkit.org>
3815
3816         Unreviewed, just fixing one more log error from my previous python patch.
3817
3818         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
3819         https://bugs.webkit.org/show_bug.cgi?id=51802
3820
3821         webkit-patch failure-reason was logging about parsing errors
3822         due to my misunderstanding of how BeautifulSoup.findAll worked.
3823
3824         Fixed, and added a unit test.
3825
3826         * Scripts/webkitpy/common/net/layouttestresults.py:
3827         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3828
3829 2011-01-05  Benjamin Poulain  <benjamin.poulain@nokia.com>
3830
3831         Reviewed by Kenneth Rohde Christiansen.
3832
3833         [Qt] [WK2] Add the possibility to open window from the WebProcess in Minibrowser
3834         https://bugs.webkit.org/show_bug.cgi?id=51951
3835
3836         Set a function to QWKPage::setCreateNewPageFunction() in Minibrowser so there is a way
3837         to create new window from WebKit.
3838
3839         * MiniBrowser/qt/BrowserWindow.cpp:
3840         (newPageFunction):
3841         (BrowserWindow::BrowserWindow):
3842         (BrowserWindow::page): Added to avoid the indirect access to QWKPage spread in the class
3843         (BrowserWindow::newWindow):
3844         (BrowserWindow::updateUserAgentList):
3845         (BrowserWindow::showUserAgentDialog):
3846         * MiniBrowser/qt/BrowserWindow.h: Add the global variable backingStoreTypeForNewWindow to
3847         define the type of the backing store used for new windows.
3848         * MiniBrowser/qt/main.cpp:
3849         (main):
3850
3851 2011-01-05  Eric Seidel  <eric@webkit.org>
3852
3853         Reviewed by Ojan Vafai.
3854
3855         commit-queue should report failure type when reporting flaky tests
3856         https://bugs.webkit.org/show_bug.cgi?id=51900
3857
3858         This patch was a ridiculous amount of plumbing.  In the end I like
3859         the NRWT-style TestResult class even less.  But now we're passing
3860         a list of TestResult objects from the queue to the FlakyTestReporter.
3861         Thus the FlakyTestReporter can more easily report what type of failure
3862         occurred.
3863
3864         In the process, I found that I was not alone in finding TestResult
3865         cumbersome to use.  A bunch of code was trying to create a TestResult
3866         object with default values.  However since the constructor didn't make
3867         this easy, some places were getting it wrong (including the TestResult unit test)!
3868         I've fixed the TestResult constructor to have default values for non-essential
3869         arguments.
3870
3871         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3872         * Scripts/webkitpy/common/net/layouttestresults.py:
3873         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3874         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3875         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3876         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
3877         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
3878         * Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py:
3879         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
3880         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3881         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3882         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3883         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3884         * Scripts/webkitpy/tool/commands/queues.py:
3885         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3886
3887 2011-01-05  Eric Seidel  <eric@webkit.org>
3888
3889         Unreviewed.
3890
3891         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
3892         https://bugs.webkit.org/show_bug.cgi?id=51802
3893
3894         Add another unit test to cover a previously missing import.
3895
3896         * Scripts/webkitpy/common/net/layouttestresults.py:
3897         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3898
3899 2011-01-05  Mihai Parparita  <mihaip@chromium.org>
3900
3901         Reviewed by David Levin.
3902
3903         Add mihaip@chromium.org as a reviewer
3904         https://bugs.webkit.org/show_bug.cgi?id=51966
3905         
3906         Add myself as a reviewer.
3907
3908         * Scripts/webkitpy/common/config/committers.py:
3909
3910 2011-01-05  James Simonsen  <simonjam@chromium.org>
3911
3912         Unreviewed. Adding myself to the list of committers.
3913
3914         * Scripts/webkitpy/common/config/committers.py:
3915
3916 2011-01-05  Eric Seidel  <eric@webkit.org>
3917
3918         Unreviewed.
3919
3920         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
3921         https://bugs.webkit.org/show_bug.cgi?id=51802
3922
3923         Fix two exceptions seen on the bots after my original commit.
3924
3925         * Scripts/webkitpy/common/net/layouttestresults.py:
3926         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3927
3928 2011-01-05  Kundu Suchismita  <suchi.kundu@nokia.com>
3929
3930         Reviewed by Andreas Kling.
3931
3932         [Qt]Add local storage settings to QtTestBrowser command line arguments 
3933         https://bugs.webkit.org/show_bug.cgi?id=51750
3934
3935         * QtTestBrowser/main.cpp:
3936         (LauncherApplication::handleUserOptions):
3937          Local storage settings can be enable form command line arguments for
3938          QtTestBrowser.
3939
3940 2011-01-05  Chris Fleizach  <cfleizach@apple.com>
3941
3942         Reviewed by Martin Robinson.
3943
3944         GTK: AX: DRT needs to use correct root object method.
3945         https://bugs.webkit.org/show_bug.cgi?id=51911
3946
3947         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
3948         (AccessibilityController::rootElement):
3949
3950 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
3951
3952         Rubber-stamped by Csaba Osztrogonác.
3953
3954         Based on idea from Péter Gál.
3955
3956         * Scripts/webkitpy/tool/bot/sheriff.py: Remove unnecessary apostrophes around revision numbers.
3957
3958 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
3959
3960         Reviewed by Adam Barth.
3961
3962         sheriff-bot should be able to do multi-revision rollouts
3963         https://bugs.webkit.org/show_bug.cgi?id=51176
3964
3965         * Scripts/webkitpy/tool/bot/irc_command.py:
3966         * Scripts/webkitpy/tool/bot/sheriff.py:
3967         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
3968
3969 2011-01-05  Eric Seidel  <eric@webkit.org>
3970
3971         Reviewed by Adam Barth.
3972
3973         queues.webkit.org should have per-bot status pages
3974         https://bugs.webkit.org/show_bug.cgi?id=51906
3975
3976         Just adds a /queue-status/QUEUE_NAME/bots/BOT_ID page to show
3977         statuses from a single queue.  Now that we have many bots servicing
3978         some queues (commit-queue, win-ews, etc.) its easy to have the messages
3979         you care about scroll off the end of the 15-message limit on the main page.
3980
3981         Eventually we should probably rename /queue-status to /queue or /queues,
3982         but that's fodder for another patch.
3983
3984         * QueueStatusServer/handlers/queuestatus.py:
3985         * QueueStatusServer/index.yaml:
3986         * QueueStatusServer/main.py:
3987         * QueueStatusServer/templates/includes/singlequeuestatus.html:
3988          - This probably should use a custom filter instead of hard-coding
3989            the URL scheme here, but I couldn't figure out how to easily
3990            create such a filter.  Most filters work with "strings" so we can't
3991            pass the status object.  We could add a method to the status
3992            object and call that, but that seemed a bit strange too.
3993         * QueueStatusServer/templates/queuestatus.html:
3994
3995 2011-01-05  Carlos Garcia Campos  <cgarcia@igalia.com>
3996
3997         Unreviewed. Adding myself to the list of committers.
3998
3999         * Scripts/webkitpy/common/config/committers.py:
4000
4001 2011-01-04  Koan-Sin Tan  <koansin.tan@gmail.com>
4002
4003         Reviewed by David Levin.
4004
4005         check-webkit-style treated some macros with parentheses after #elif as function calls
4006         https://bugs.webkit.org/show_bug.cgi?id=51695
4007
4008         Ingore function call space checking in any preprocessor directives
4009         (things starting with #). Change search() to match() because 
4010         preprocessor directives are supposed to be in the beginning of lines.
4011
4012         * Scripts/webkitpy/style/checkers/cpp.py:
4013         * Scripts/webkitpy/style/checkers/cpp_unittest.py: make sure there is no false positives for #elif cases
4014
4015 2011-01-04  Søren Gjesse  <sgjesse@chromium.org>
4016
4017         Reviewed by Tony Chang.
4018
4019         Change the --multi-load test option to --stress-opt
4020         https://bugs.webkit.org/show_bug.cgi?id=50751
4021
4022         * DumpRenderTree/chromium/DumpRenderTree.cpp:
4023         (runTest):
4024         (main):
4025         * DumpRenderTree/chromium/TestShell.cpp:
4026         (TestShell::TestShell):
4027         * DumpRenderTree/chromium/TestShell.h:
4028         (TestShell::stressOpt):
4029         (TestShell::setStressOpt):
4030         (TestShell::stressDeopt):
4031         (TestShell::setStressDeopt):
4032         (TestShell::javaScriptFlags):
4033         (TestShell::setJavaScriptFlags):
4034         * Scripts/webkitpy/layout_tests/port/chromium.py:
4035         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4036
4037 2011-01-04  Chris Fleizach  <cfleizach@apple.com>
4038
4039         Reviewed by Sam Weinig.
4040
4041         WK2: Support Accessibility
4042         https://bugs.webkit.org/show_bug.cgi?id=51859
4043
4044         Use rootObject() method to get top of accessibility tree.
4045
4046         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
4047         (AccessibilityController::focusedElement):
4048         (AccessibilityController::rootElement):
4049
4050 2011-01-03  Martin Robinson  <mrobinson@igalia.com>
4051
4052         Reviewed by Darin Adler.
4053
4054         Remove the last non-GObject usage of PlatformRefPtr and move the code to GRefPtr
4055         https://bugs.webkit.org/show_bug.cgi?id=51846
4056
4057         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: Change usage of PlatformRefPtr
4058         back to GRefPtr.
4059
4060 2011-01-04  Zhe Su  <suzhe@chromium.org>
4061
4062         Reviewed by Kenneth Russell.
4063
4064         Fix insertText, setMarkedText and unmarkText methods of
4065         TextInputController to call corresponding methods of WebKit::WebView
4066         rather than WebKit::WebFrame. This change matches the behavior of
4067         chromium browser.
4068         insertText corresponds to WebView::confirmComposition(text)
4069         setMarkedText corresponds to WebView::setComposition(...)
4070         unmarkText corresponds to WebView::confirmComposition()
4071         https://bugs.webkit.org/show_bug.cgi?id=51693
4072
4073         * DumpRenderTree/chromium/TextInputController.cpp:
4074         (TextInputController::insertText):
4075         (TextInputController::setMarkedText):
4076         (TextInputController::unmarkText):
4077
4078 2011-01-04  Dihan Wickremasuriya  <dihan.wickremasuriya@nokia.com>
4079
4080         Reviewed by Laszlo Gombos.
4081
4082         [Qt] [Symbian] Do not remove 0 byte sized files from productDir
4083
4084         On Symbian productDir points to the source directory. Removing all the
4085         empty files from the productDir directory corrupts the svn repository.
4086
4087         * Scripts/build-webkit:
4088
4089 2011-01-03  Yi Shen  <yi.4.shen@nokia.com>
4090
4091         Reviewed by Adam Barth.
4092
4093         [Qt] Add SelectAll option to the context menu for the editor
4094         https://bugs.webkit.org/show_bug.cgi?id=50049
4095
4096         Set shortcut for the SelectAll action.
4097
4098         * QtTestBrowser/mainwindow.cpp:
4099         (MainWindow::buildUI):
4100
4101 2011-01-03  David Levin  <levin@chromium.org>
4102
4103         Reviewed by Eric Seidel.
4104
4105         check-webkit-style shouldn't consider "value" automatically to be a meaningless name.
4106         https://bugs.webkit.org/show_bug.cgi?id=51842
4107
4108         * Scripts/webkitpy/style/checkers/cpp.py: Remove the check for value.
4109         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Remove the test for value.
4110
4111 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
4112
4113         Reviewed by David Kilzer.
4114
4115         [WINCE] Adds a build slave.
4116         https://bugs.webkit.org/show_bug.cgi?id=50523
4117
4118         * BuildSlaveSupport/build.webkit.org-config/config.json: Add an
4119         entry for a release build of the WinCE port.
4120         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add platform
4121         flag to build the WinCE port.
4122
4123 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
4124
4125         Reviewed by David Kilzer.
4126
4127         Add WinCE support to build-webkit
4128         https://bugs.webkit.org/show_bug.cgi?id=51642
4129
4130         * Scripts/build-webkit:
4131         * Scripts/webkitdirs.pm:
4132
4133 2011-01-03  Eric Seidel  <eric@webkit.org>
4134
4135         Reviewed by Adam Barth.
4136
4137         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
4138         https://bugs.webkit.org/show_bug.cgi?id=51802
4139
4140         I'm not the biggest fan of the test_failures or test_results classes,
4141         but it's better to have one shared set of classes, than separate ones
4142         for new vs. old run-webkit-test result handling.
4143
4144         This moves the ORWT results class "LayoutTestResults" over to using
4145         TestResult and TestFailure classes, making it easy for us to
4146         make all our sheriff-bot and other webkitpy code NRWT ready.
4147
4148         This also makes it a trivial patch to generate results.json information
4149         from ORWT results.html files (for flaky test analysis, etc.) as well
4150         as making it a one-liner to report test failure types when the
4151         commit-queue sees flaky tests.
4152
4153         This patch tried not to add new functionality, but only to replace
4154         the guts of LayoutTestResults, while adding unit tests and hoping
4155         not to break anything.
4156
4157         I also moved callers which assumed User.prompt* were static/class methods
4158         to using them as instance methods (since we'll eventually want to make them such).
4159
4160         In the process of re-writing things, I broke the rebaseline command, so I wrote
4161         a unit test to catch my breakage were I do do so again in the future.
4162
4163         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
4164         * Scripts/webkitpy/common/net/layouttestresults.py:
4165         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
4166         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
4167         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
4168         * Scripts/webkitpy/tool/commands/queries.py:
4169         * Scripts/webkitpy/tool/commands/rebaseline.py:
4170         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
4171         * Scripts/webkitpy/tool/mocktool.py:
4172
4173 2011-01-03  Adam Barth  <abarth@webkit.org>
4174
4175         Reviewed by Simon Fraser.
4176
4177         webkit-patch shouldn't waste time cleaning a working directory that's already clean
4178         https://bugs.webkit.org/show_bug.cgi?id=51840
4179
4180         * Scripts/webkitpy/common/checkout/scm.py:
4181
4182 2011-01-03  Adam Barth  <abarth@webkit.org>
4183
4184         Reviewed by Simon Fraser.
4185
4186         webkit-patch should only hide update output if --quiet
4187         https://bugs.webkit.org/show_bug.cgi?id=51838
4188
4189         As requested by smfr.
4190
4191         * Scripts/webkitpy/tool/steps/update.py:
4192
4193 2011-01-03  Adam Barth  <abarth@webkit.org>
4194
4195         Reviewed by David Levin.
4196
4197         commit-queue shouldn't reject patches twice if two bots process the same patch
4198         https://bugs.webkit.org/show_bug.cgi?id=51805
4199
4200         Before raising an error, we first check whether the patch is still in
4201         the commit-queue.  This check is still racy, of course, but the time
4202         window is much smaller.
4203
4204         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
4205
4206 2011-01-03  Sam Weinig  <sam@webkit.org>
4207
4208         Reviewed by Anders Carlsson.
4209
4210         Make run-api-tests less chatty.
4211         https://bugs.webkit.org/show_bug.cgi?id=51831
4212
4213         - Make script quiet by default and add --verbose option (replacing --quiet).
4214         - When not verbose, pipe stdout and stderr to devnull.
4215
4216         * Scripts/run-api-tests:
4217
4218 2011-01-03  Pratik Solanki  <psolanki@apple.com>
4219
4220         Unreviewed. Adding myself to committers.py.
4221
4222         * Scripts/webkitpy/common/config/committers.py:
4223
4224 2011-01-03  Koan-Sin Tan  <koansin.tan@gmail.com>
4225
4226         Reviewed by Xan Lopez.
4227
4228         "Tool/Scripts/run-launcher --gtk" stopped working after 74855
4229         https://bugs.webkit.org/show_bug.cgi?id=51806
4230
4231         Originally, the $libraryName is 'JavaScriptCore'. When building release 
4232         one, the $libraryDir was 'WebKitBuild/Release/JavaScriptCore/../.libs/'
4233         which doesn't exist anymore ('WebKitBuild/Release/JavaScriptCore'
4234         is 'WebKitBuild/Release/Source/JavaScriptCore' now), and 
4235         'WebKitBuild/Release/Source/JavaScriptCore/../../.libs' looks weird,
4236         so make it 'WebKitBuild/Release/.libs'
4237
4238         * Scripts/webkitdirs.pm: 
4239
4240 2011-01-02  Patrick Gansterer  <paroga@webkit.org>
4241
4242         Reviewed by Adam Barth.
4243
4244         Make EFL a core builder
4245         https://bugs.webkit.org/show_bug.cgi?id=51804
4246
4247         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
4248         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
4249
4250 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
4251
4252         [Qt] Unreviewed fix after r74855 and r74875.
4253
4254         * BuildSlaveSupport/built-product-archive:
4255          - Create directories explicitly.
4256          - Pass shell=True to subprocess.call().
4257
4258 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
4259
4260         [Qt] Unreviewed fix after r74855.
4261
4262         Move JavaScriptCore to Source
4263         https://bugs.webkit.org/show_bug.cgi?id=51604
4264
4265         * BuildSlaveSupport/built-product-archive: JavaScriptCore -> Source/JavaScriptCore
4266
4267 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
4268
4269         [Qt] Unreviewed run-javasriptcore-tests fix after r74855.
4270
4271         Move JavaScriptCore to Source
4272         https://bugs.webkit.org/show_bug.cgi?id=51604
4273
4274         * Scripts/webkitdirs.pm:
4275
4276 2011-01-02  Robert Hogan  <robert@webkit.org>
4277
4278         Unreviewed, build fix.
4279
4280         [Qt] Fix DRT build after 74855
4281
4282         * DumpRenderTree/qt/DumpRenderTree.pro:
4283
4284 2011-01-01  Adam Barth  <abarth@webkit.org>
4285
4286         Remove the assumption from the Qt and Gtk builds that every project is
4287         in the root directory.
4288
4289         * Scripts/build-webkit:
4290
4291 2011-01-01  Adam Barth  <abarth@webkit.org>
4292
4293         Reviewed by Eric Seidel.
4294
4295         Teach svn-apply how to apply patches even though JavaScriptCore has moved
4296         https://bugs.webkit.org/show_bug.cgi?id=51796
4297
4298         After this change, svn-apply will magically apply patches to
4299         JavaScriptCore/foo to Source/JavaScriptCore/foo.
4300
4301         * Scripts/VCSUtils.pm:
4302
4303 2011-01-01  Adam Barth  <abarth@webkit.org>
4304
4305         Reviewed by Eric Seidel.
4306
4307         Move JavaScriptCore to Source
4308         https://bugs.webkit.org/show_bug.cgi?id=51604
4309
4310         Update references to JavaScriptCore to point to the new location.
4311
4312         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
4313         * DumpRenderTree/qt/DumpRenderTree.pro:
4314         * DumpRenderTree/qt/ImageDiff.pro:
4315         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
4316         * DumpRenderTree/wscript:
4317         * Scripts/build-jsc:
4318         * Scripts/build-webkit:
4319         * Scripts/do-file-rename:
4320         * Scripts/do-webcore-rename:
4321         * Scripts/run-javascriptcore-tests:
4322         * Scripts/update-javascriptcore-test-results:
4323         * Scripts/webkitdirs.pm:
4324         * Scripts/webkitpy/common/config/build_unittest.py:
4325         * Scripts/webkitpy/style/checker.py:
4326         * Scripts/webkitpy/style/checker_unittest.py:
4327         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
4328         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
4329         * WebKitTestRunner/qt/WebKitTestRunner.pro:
4330         * wx/build/settings.py:
4331
4332 2011-01-01  Adam Barth  <abarth@webkit.org>
4333
4334         Reviewed by Eric Seidel.
4335
4336         Move Sources to Source
4337         https://bugs.webkit.org/show_bug.cgi?id=51794
4338
4339         Update scripts to point to the new location.
4340
4341         * Scripts/build-webkit:
4342         * Scripts/do-file-rename:
4343         * Scripts/do-webcore-rename:
4344         * Scripts/webkitpy/common/config/build.py:
4345         * Scripts/webkitpy/common/config/build_unittest.py:
4346
4347 2010-12-31  Kent Tamura  <tkent@chromium.org>
4348
4349         Reviewed by Eric Seidel.
4350
4351         [DRT/Chromium] Enable mock spell checker on non-OSX
4352         https://bugs.webkit.org/show_bug.cgi?id=51401
4353
4354         * DumpRenderTree/chromium/WebViewHost.cpp:
4355         (WebViewHost::spellCheck):
4356
4357 2010-12-31  Adam Barth  <abarth@webkit.org>
4358
4359         Reviewed by Ariya Hidayat.
4360
4361         Remove Tools/Scripts/wkstyle
4362         https://bugs.webkit.org/show_bug.cgi?id=51774
4363
4364         This script appears to not have been touched in a while and seems to
4365         have been replaced by check-webkit-style.
4366
4367         * Scripts/wkstyle: Removed.
4368
4369 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
4370
4371         Unreviewed. Coding style fix.
4372
4373         * DumpRenderTree/chromium/TestShell.h:
4374
4375 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
4376
4377         Reviewed by Pavel Feldman.
4378
4379         Web Inspector: [Chromium] Inspector's tests are very slow on Win(Dbg).
4380
4381         It was a problem with Chromium DRT. DevToolsAgent object instance was
4382         attached not only to the inspected page but to the DevTools window too.
4383         As result all the inspector files were interpreted as a content of inspected page
4384         and were transfered to the DevTools scripts panel for debugging etc.
4385
4386         https://bugs.webkit.org/show_bug.cgi?id=51735
4387
4388         * DumpRenderTree/chromium/TestShell.cpp:
4389         (TestShell::TestShell):
4390         (TestShell::bindJSObjectsToWindow):
4391         (TestShell::createNewWindow):
4392         * DumpRenderTree/chromium/TestShell.h:
4393
4394 2010-12-31  Adam Barth  <abarth@webkit.org>
4395
4396         Rubber-stamped by Eric Seidel.
4397
4398         Move PageLoadTests to PerformanceTests/PageLoad
4399         https://bugs.webkit.org/show_bug.cgi?id=51771
4400
4401         Update references to PageLoadTests to point to the new location.
4402
4403         * Scripts/run-pageloadtest:
4404         * Scripts/webkitpy/common/config/build.py:
4405
4406 2010-12-31  Adam Barth  <abarth@webkit.org>
4407
4408         Rubber-stamped by Eric Seidel.
4409
4410         Move SunSpider into PerformanceTests
4411         https://bugs.webkit.org/show_bug.cgi?id=51769
4412
4413         Update these scripts to point to the new location.
4414
4415         * Scripts/run-sunspider:
4416         * Scripts/sunspider-compare-results:
4417
4418 2010-12-30  Mihai Parparita  <mihaip@chromium.org>
4419
4420         Reviewed by Kent Tamura.
4421
4422         [Chromium] Add WebThemeEngineDRTMac so that Chromium DRT scrollbar rendering can match the Mac port's
4423         https://bugs.webkit.org/show_bug.cgi?id=51728
4424         
4425         Add implementation of the Mac WebThemeEngine that uses an NSScroller
4426         to render top-level scrollbars. This makes them match the Mac port's
4427         use of an NSScrollView, which means that we'll be able to share more
4428         pixel baselines.
4429         
4430         The new rendering code will not be activated until the 
4431         USE_WEB_THEME_ENGINE_TO_PAINT_THUMB #define is fliped in
4432         ScrollbarThemeChromiumMac.
4433
4434         * DumpRenderTree/DumpRenderTree.gypi:
4435         * DumpRenderTree/chromium/TestShellMac.mm:
4436         (platformInit):
4437         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Added.
4438         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Added.
4439         (+[FakeActiveWindow alwaysActiveWindow]):
4440         (+[FakeActiveWindow alwaysInactiveWindow]):
4441         (-[FakeActiveWindow initWithActiveControls:]):
4442         (-[FakeActiveWindow _hasActiveControls]):
4443         (WebThemeEngineDRTMac::paintScrollbarThumb):
4444         (stateToHIEnableState):
4445         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
4446         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
4447
4448 2010-12-30  Konstantin Tokarev  <annulen@yandex.ru>
4449
4450         Reviewed by David Kilzer.
4451
4452         [Qt] Don't build wtf/TCSystemAlloc.cpp if --system-malloc option is
4453         used
4454         https://bugs.webkit.org/show_bug.cgi?id=51672
4455
4456         * DumpRenderTree/qt/DumpRenderTree.pro: Replaced USE_SYSTEM_MALLOC
4457         with USE_SYSTEM_MALLOC=1
4458         * WebKitTestRunner/qt/WebKitTestRunner.pro: Replaced USE_SYSTEM_MALLOC
4459         with USE_SYSTEM_MALLOC=1
4460
4461 2010-12-30  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
4462
4463         Reviewed by David Kilzer.
4464
4465         [Qt] [Symbian] Fix build-webkit script for Symbian
4466         https://bugs.webkit.org/show_bug.cgi?id=51509
4467
4468         Set the OUTPUT_DIR for Symbian to be the same as the source
4469         directory.
4470
4471         * Scripts/webkitdirs.pm:
4472
4473 2010-12-30  Martin Robinson  <mrobinson@igalia.com>
4474
4475         Reviewed by Darin Adler.
4476
4477         check-webkit-style should ignore NULL usage in calls to gtk_widget_style_get
4478         https://bugs.webkit.org/show_bug.cgi?id=51758
4479
4480         Add a check-webkit-style exception for gtk_widget_style_get and NULL usage.
4481
4482         * Scripts/webkitpy/style/checkers/cpp.py: Add the exception.
4483         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Add some tests for this.
4484
4485 2010-12-29  Patrick Gansterer  <paroga@webkit.org>
4486
4487         Unreviewed WinCE buildfix.
4488
4489         * WinCELauncher/main.cpp: Add missing include.
4490
4491 2010-12-29  Daniel Bates  <dbates@rim.com>
4492
4493         Reviewed by Darin Adler.
4494
4495         svn-apply updates date of wrong change log entry for a change log diff that
4496         contains two consecutive entries with the same author and date
4497         https://bugs.webkit.org/show_bug.cgi?id=46061
4498
4499         Fixes an issue where the date of the wrong change log entry may be modified.
4500         Moreover, changes fixChangeLogPatch() to move entries inserted earlier
4501         in a ChangeLog file to the top of the file.
4502
4503         Currently, fixChangeLogPatch() explicitly bails out and returns an unchanged
4504         diff when it detects that the diff inserts a change log entry earlier in a
4505         ChangeLog. It is unusual to land a patch that has such a deliberate ChangeLog
4506         change. With the advent of the commit-queue this functionality of bailing out
4507         and hence landing the patch as-is is harmful to the accuracy of the ChangeLog.
4508         Instead, we should always move the change log entry to the top of the ChangeLog file.
4509
4510         A side-effect of this change is that setChangeLogDateAndReviewer() now updates
4511         the date line of the correct change log entry in a ChangeLog diff.
4512
4513         * Scripts/VCSUtils.pm: Modified fixChangeLogPa