[EFL] [WK2] fast/dom/vertical-scrollbar-in-rtl.html makes fast/regions tests flaky
[WebKit.git] / Tools / ChangeLog
1 2012-12-06  Yael Aharon  <yael.aharon@intel.com>
2
3         [EFL] [WK2] fast/dom/vertical-scrollbar-in-rtl.html makes fast/regions tests flaky
4         https://bugs.webkit.org/show_bug.cgi?id=104139
5
6         Reviewed by Kenneth Rohde Christiansen.
7
8         Resize the window back to 800x600 between tests.
9         This should be a no-op if the test did not resize the window.
10
11         * WebKitTestRunner/TestController.cpp:
12         (WTR::TestController::resetStateToConsistentValues):
13
14 2012-12-06  Sheriff Bot  <webkit.review.bot@gmail.com>
15
16         Unreviewed, rolling out r136784 and r136802.
17         http://trac.webkit.org/changeset/136784
18         http://trac.webkit.org/changeset/136802
19         https://bugs.webkit.org/show_bug.cgi?id=104231
20
21         breaks chromium canary (Requested by morrita on #webkit).
22
23         * Scripts/webkitpy/common/config/build_unittest.py:
24         (ShouldBuildTest):
25
26 2012-12-05  Ryosuke Niwa  <rniwa@webkit.org>
27
28         Add myself to watch changes in PerformanceTests/*.
29
30         * Scripts/webkitpy/common/config/watchlist:
31
32 2012-12-05  Shinya Kawanaka  <shinyak@chromium.org>
33
34         [Chromium] DRT on Windows crashes when a testcase has a progress element in indeterminate state
35         https://bugs.webkit.org/show_bug.cgi?id=102459
36
37         Reviewed by Dimitri Glazkov.
38
39         Since WebThemeControlDRTWin::markState does not consider indeterminate state, DRT caused a crash.
40
41         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp:
42         (WebThemeControlDRTWin::markState):
43
44 2012-12-05  Filip Pizlo  <fpizlo@apple.com>
45
46         DFG profiler should be able to display where a code block was inlined into, and what it inlined
47         https://bugs.webkit.org/show_bug.cgi?id=104216
48
49         Reviewed by Oliver Hunt.
50
51         Added an "inlines" command that shows the inline stacks that a code block participated
52         in. Also cleaned up some of the ways we print compilation units.
53
54         * Scripts/display-profiler-output:
55
56 2012-12-05  Halton Huo  <halton.huo@intel.com>
57
58         [CMake] Unify coding style for CMake files
59         https://bugs.webkit.org/show_bug.cgi?id=103605
60
61         Reviewed by Laszlo Gombos.
62
63         Update cmake files(.cmake, CMakeLists.txt) with following style rules:
64         1. Indentation
65         1.1 Use spaces, not tabs.
66         1.2 Four spaces as indent.
67         2. Spacing
68         2.1 Place one space between control statements and their parentheses.
69             For eg, if (), else (), elseif (), endif (), foreach (),
70             endforeach (), while (), endwhile (), break ().
71         2.2 Do not place spaces between function and macro statements and
72             their parentheses. For eg, macro(), endmacro(), function(),
73             endfunction().
74         2.3 Do not place spaces between a command or function or macro and its
75             parentheses, or between a parenthesis and its content. For eg,
76             message("testing") not message( "testing") or message ("testing" )
77         2.4 No space at line ending.
78         3. Lowercase when call commands macros and functions. For eg,
79            add_executable() not ADD_EXECUTABLE(), set() not SET().
80
81         * CMakeLists.txt:
82         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
83         * DumpRenderTree/efl/CMakeLists.txt:
84         * EWebLauncher/CMakeLists.txt:
85         * EWebLauncher/ControlTheme/CMakeLists.txt:
86         * MiniBrowser/efl/CMakeLists.txt:
87         * TestWebKitAPI/CMakeLists.txt:
88         * TestWebKitAPI/PlatformEfl.cmake:
89         * WebKitTestRunner/CMakeLists.txt:
90         * WebKitTestRunner/PlatformEfl.cmake:
91         * WinCELauncher/CMakeLists.txt:
92         * clang/ReportMemoryUsagePlugin/CMakeLists.txt:
93
94 2012-12-05  Scott Violet  <sky@chromium.org>
95
96         [chromium] Remove linux theme related files and switch to default
97         https://bugs.webkit.org/show_bug.cgi?id=103897
98
99         Reviewed by Tony Chang.
100
101         * Scripts/webkitpy/common/config/build_unittest.py:
102         (ShouldBuildTest): linux->default
103
104 2012-12-05  Dirk Pranke  <dpranke@chromium.org>
105
106         nrwt: run_webkit_tests_integrationtest.py depends on being able to share a port w/ between master and worker
107         https://bugs.webkit.org/show_bug.cgi?id=78168
108
109         Reviewed by Ojan Vafai.
110
111         This patch adds a single ordered list to ResultSummary that contains
112         the results of every test run in order of result received, and
113         modifies the TestResults class to contain the list of references used
114         for each test as well as the pid of the driver; this allows us to stop
115         having to override the test drivers to record the tests, and makes the
116         integration tests that test rdering, retries, restarts, etc. black-box
117         tests.
118
119         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
120         (SingleTestRunner._run_rebaseline):
121         (SingleTestRunner._compare_output):
122         (SingleTestRunner._run_reftest):
123         (SingleTestRunner._compare_output_with_reference):
124         * Scripts/webkitpy/layout_tests/models/result_summary.py:
125         (ResultSummary.__init__):
126         (ResultSummary.add):
127         * Scripts/webkitpy/layout_tests/models/test_results.py:
128         (TestResult.__init__):
129         * Scripts/webkitpy/layout_tests/port/driver.py:
130         (DriverOutput.__init__):
131         (Driver.run_test):
132         * Scripts/webkitpy/layout_tests/port/test.py:
133         (TestDriver):
134         (TestDriver.__init__):
135         (TestDriver.run_test):
136         (TestDriver.stop):
137         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
138         (get_tests_run):
139         (get_test_batches):
140         (get_test_results):
141         (MainTest.test_batch_size):
142         (MainTest.test_dryrun):
143         (MainTest.test_natural_order):
144         (MainTest.test_natural_order_test_specified_multiple_times):
145         (MainTest.test_random_order):
146         (MainTest.test_random_order_test_specified_multiple_times):
147         (MainTest.test_no_order):
148         (MainTest.test_no_order_test_specified_multiple_times):
149         (MainTest.test_no_order_with_directory_entries_in_natural_order):
150         (MainTest.test_repeat_each):
151         (MainTest.test_ignore_flag):
152         (MainTest.test_skipped_flag):
153         (MainTest.test_iterations):
154         (MainTest.test_run_chunk):
155         (MainTest.test_run_part):
156         (MainTest.test_run_singly):
157         (MainTest.test_skip_failing_tests):
158         (MainTest.test_single_file):
159         (MainTest.test_single_file_with_prefix):
160         (MainTest.test_single_skipped_file):
161         (MainTest.test_test_list):
162         (MainTest.test_test_list_with_prefix):
163         (MainTest.test_exit_after_n_failures):
164         (MainTest.test_exit_after_n_crashes):
165         (MainTest.test_run_order__inline):
166         (MainTest.test_reftest_run):
167         (MainTest.test_reftest_run_reftests_if_pixel_tests_are_disabled):
168         (MainTest.test_reftest_skip_reftests_if_no_ref_tests):
169         (MainTest.test_reftest_expected_html_should_be_ignored):
170         (MainTest.test_reftest_driver_should_run_expected_html):
171         (MainTest.test_reftest_driver_should_run_expected_mismatch_html):
172         (MainTest.test_no_http_tests):
173         (MainTest.test_platform_tests_are_found):
174
175 2012-12-05  Dana Jansens  <danakj@chromium.org>
176
177         [chromium] Make WebCompositorOutputSurface an empty class when USE_CC_OUTPUT_SURFACE is defined.
178         https://bugs.webkit.org/show_bug.cgi?id=103967
179
180         Reviewed by James Robinson.
181
182         Use the WebCompositorSupport methods to create an OutputSurface. If they
183         fail, then fall back to the WebViewHost methods.
184
185         Once the chromium side lands, the WebCompositorSupport methods will stop
186         failing, and will replace the WebViewHost ones.
187
188         * DumpRenderTree/chromium/WebViewHost.cpp:
189         (WebViewHost::createOutputSurface):
190
191 2012-12-05  Dirk Pranke  <dpranke@chromium.org>
192
193         nrwt: split all of the buildbot-specific output into its own file
194         https://bugs.webkit.org/show_bug.cgi?id=104165
195
196         Reviewed by Ojan Vafai.
197
198         Now that we have the RunDetails object we can move all of the
199         buildbot-specific knowledge out of the core test-running code
200         and into the outermost run_webkit_tests layer.
201
202         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
203         (run):
204         (main):
205         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
206         (passing_run):
207         (logging_run):
208         (run_and_capture):
209         (MainTest.test_all):
210         (MainTest.test_max_locked_shards):
211         (MainTest.test_child_processes_2):
212         (MainTest.test_child_processes_min):
213         (MainTest.test_full_results_html):
214         (MainTest.test_hung_thread):
215         (MainTest.test_keyboard_interrupt):
216         (MainTest.test_no_tests_found):
217         (MainTest.test_no_tests_found_2):
218         (MainTest.test_repeat_each_iterations_num_tests):
219         (MainTest.test_run_singly_actually_runs_tests):
220         (MainTest.test_test_list):
221         (MainTest.test_unexpected_failures):
222         (MainTest.test_missing_and_unexpected_results):
223         (MainTest.test_pixel_test_directories):
224         (MainTest.test_missing_and_unexpected_results_with_custom_exit_code):
225         (MainTest.test_crash_with_stderr):
226         (MainTest.test_no_image_failure_with_image_diff):
227         (MainTest.test_crash_log):
228         (MainTest.test_web_process_crash_log):
229         (MainTest.test_exit_after_n_failures_upload):
230         (MainTest.test_results_directory_absolute):
231         (MainTest.test_results_directory_default):
232         (MainTest.test_results_directory_relative):
233         (MainTest.test_retrying_and_flaky_tests):
234         (MainTest.test_reftest_should_not_use_naming_convention_if_not_listed_in_reftestlist):
235         (MainTest.test_output_diffs):
236         (MainTest.test_unsupported_platform):
237         (MainTest.test_verbose_in_child_processes):
238         (EndToEndTest.test_end_to_end):
239         (EndToEndTest.test_reftest_with_two_notrefs):
240         (RebaselineTest.test_reset_results):
241         (RebaselineTest.test_missing_results):
242         (RebaselineTest.test_new_baseline):
243         * Scripts/webkitpy/layout_tests/views/buildbot_results.py: Added.
244         (BuildBotPrinter):
245         (BuildBotPrinter.__init__):
246         (BuildBotPrinter.print_results):
247         (BuildBotPrinter._print):
248         (BuildBotPrinter.print_result_summary):
249         (BuildBotPrinter._print_result_summary_entry):
250         (BuildBotPrinter.print_unexpected_results):
251         (BuildBotPrinter.print_unexpected_results.add_to_dict_of_lists):
252         (BuildBotPrinter.print_unexpected_results.add_result):
253         * Scripts/webkitpy/layout_tests/views/buildbot_results_unittest.py: Added.
254         (BuildBotPrinterTests):
255         (BuildBotPrinterTests.assertEmpty):
256         (BuildBotPrinterTests.assertNotEmpty):
257         (BuildBotPrinterTests.get_printer):
258         (BuildBotPrinterTests.get_result):
259         (BuildBotPrinterTests.get_result_summary):
260         (BuildBotPrinterTests.test_print_unexpected_results):
261         (BuildBotPrinterTests.test_print_unexpected_results.get_unexpected_results):
262         * Scripts/webkitpy/layout_tests/views/printing.py:
263         (Printer):
264         (Printer.__init__):
265         (Printer.print_results):
266         (Printer._print_statistics_for_test_timings):
267         (Printer._print_baseline):
268         (Printer._print_debug):
269         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
270         (Testprinter.get_printer):
271         (Testprinter.get_result):
272         (Testprinter.test_configure_and_cleanup):
273         (Testprinter.test_print_config):
274         (Testprinter.test_print_one_line_summary):
275         (Testprinter.test_test_status_line):
276         (Testprinter.test_details):
277
278 2012-12-05  Dirk Pranke  <dpranke@chromium.org>
279
280         nrwt: collect all of the information about a run into a new RunDetails class
281         https://bugs.webkit.org/show_bug.cgi?id=104158
282
283         Reviewed by Ojan Vafai.
284
285         This patch collects the information from both test passes (the
286         main one and the retries) as well as the summarized results and
287         the exit code into a RunDetails class, so that the integration
288         tests can more easily tell what happened.
289
290         Also, change the way the --lint-test-files works slightly so that
291         we don't need to create a printer object (and hence we need to
292         rework the tests that are testing logging).
293
294         * Scripts/webkitpy/layout_tests/controllers/manager.py:
295         (RunDetails):
296         (RunDetails.__init__):
297         (Manager.run):
298         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
299         (run):
300         (main):
301         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
302         (passing_run):
303         (run_and_capture):
304         (LintTest.test_lint_test_files):
305         (LintTest.test_lint_test_files__errors):
306         (MainTest.test_verbose_in_child_processes):
307
308 2012-12-05  Dirk Pranke  <dpranke@chromium.org>
309
310         nrwt: remove --no-record-results
311         https://bugs.webkit.org/show_bug.cgi?id=104072
312
313         Reviewed by Ojan Vafai.
314
315         The command line flag was only being used in the unit tests and
316         wasn't really needed once we started using a mock filesystem.
317
318         Also, reformat a bunch of long lines ...
319
320         * Scripts/webkitpy/layout_tests/controllers/manager.py:
321         (Manager.run):
322         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
323         (parse_args):
324         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
325         (parse_args):
326         (passing_run):
327         (logging_run):
328         (MainTest.test_repeat_each_iterations_num_tests):
329         (MainTest.test_test_list):
330         (MainTest.test_missing_and_unexpected_results):
331         (MainTest.test_pixel_test_directories):
332         (MainTest.test_missing_and_unexpected_results_with_custom_exit_code):
333         (MainTest.test_crash_with_stderr):
334         (MainTest.test_no_image_failure_with_image_diff):
335         (MainTest.test_crash_log):
336         (MainTest.test_web_process_crash_log):
337         (MainTest.test_exit_after_n_failures_upload):
338         (MainTest.test_results_directory_absolute):
339         (MainTest.test_results_directory_relative):
340         (MainTest.test_reftest_should_not_use_naming_convention_if_not_listed_in_reftestlist):
341         (MainTest.test_additional_expectations):
342         (MainTest.test_output_diffs):
343         (EndToEndTest.test_end_to_end):
344         (EndToEndTest.test_reftest_with_two_notrefs):
345         (RebaselineTest.test_reset_results):
346         (RebaselineTest.test_missing_results):
347         (RebaselineTest.test_new_baseline):
348
349 2012-12-05  Dirk Pranke  <dpranke@chromium.org>
350
351         nrwt: only summarize the results one way
352         https://bugs.webkit.org/show_bug.cgi?id=104064
353
354         Reviewed by Ojan Vafai.
355
356         Change manager.summarize_results so that we always (and only)
357         include both expected and unexpected results. Previously we
358         would summarize the results twice, once with expected results
359         and once without. This made the code much more confusing than
360         it needed to be.
361
362         * Scripts/webkitpy/layout_tests/controllers/manager.py:
363         (summarize_results):
364         (Manager.run):
365         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
366         (ResultSummaryTest.summarized_results):
367         (ResultSummaryTest.test_no_svn_revision):
368         (ResultSummaryTest.test_svn_revision):
369         (ResultSummaryTest.test_summarized_results_wontfix):
370         * Scripts/webkitpy/layout_tests/views/printing.py:
371         (Printer.print_results):
372         (Printer._print_unexpected_results):
373         (Printer._print_unexpected_results.add_result):
374         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
375         (Testprinter.test_print_unexpected_results.get_unexpected_results):
376         (Testprinter):
377
378 2012-12-05  Filip Pizlo  <fpizlo@apple.com>
379
380         DFG profiler should display more information
381         https://bugs.webkit.org/show_bug.cgi?id=104163
382
383         Reviewed by Gavin Barraclough.
384
385         Added the following:
386         
387         - Distinguish between source counts and bytecode counts.
388         
389         - Add a "full" summary view that shows both kinds of counts, plus inline counts.
390         
391         - Add a "source" command to see the source.
392         
393         - Add a "bytecode" command to see the bytecode and counts.
394
395         * Scripts/display-profiler-output:
396
397 2012-12-05  Yong Li  <yoli@rim.com>
398
399         [BlackBerry] Build with libjpegturbo
400         https://bugs.webkit.org/show_bug.cgi?id=104152
401
402         Reviewed by Rob Buis.
403
404         RIM PR# 196975.
405         Make sure the right include path for libjpeg is included.
406
407         * Scripts/webkitdirs.pm:
408         (blackberryCMakeArguments):
409
410 2012-12-05  Joseph Pecoraro  <pecoraro@apple.com>
411
412         Remove stale check in check-for-webkit-framework-include-consistency
413         https://bugs.webkit.org/show_bug.cgi?id=103775
414
415         Reviewed by David Kilzer.
416
417         The underlying issue was fixed in r81173.
418
419         * Scripts/check-for-webkit-framework-include-consistency:
420
421 2012-12-05  Dirk Pranke  <dpranke@chromium.org>
422
423         nrwt: simplify the finding of tests to retry
424         https://bugs.webkit.org/show_bug.cgi?id=104067
425
426         Reviewed by Ryosuke Niwa.
427
428         I think this makes the code a little clearer; note that
429         we were no longer using the include_missing flag.
430
431         * Scripts/webkitpy/layout_tests/controllers/manager.py:
432         (Manager.run):
433         (Manager._failed_test_names):
434
435 2012-12-05  Dirk Pranke  <dpranke@chromium.org>
436
437         nrwt: remove two unused parameters from a function
438         https://bugs.webkit.org/show_bug.cgi?id=104059
439
440         Reviewed by Ryosuke Niwa.
441
442         Also remove an old, stale FIXME.
443
444         * Scripts/webkitpy/layout_tests/controllers/manager.py:
445         (interpret_test_failures):
446         (summarize_results):
447         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
448         (ResultSummaryTest.test_interpret_test_failures):
449
450 2012-12-05  Dirk Pranke  <dpranke@chromium.org>
451
452         nrwt: return result_summaries from LayoutTestRunner.run_tests()
453         https://bugs.webkit.org/show_bug.cgi?id=104051
454
455         Reviewed by Ojan Vafai.
456
457         This patch completes the refactoring that makes the result summary      
458         an object returned from the layout test runner, rather than having      
459         it passed in and modified. This makes the split of duties between       
460         the manager and runner clearer and makes the data flow more             
461         functionally.                                                           
462
463         Also clean up some minor lint issues.
464
465         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
466         (LayoutTestRunner.__init__):
467         (LayoutTestRunner.run_tests):
468         (LayoutTestRunner._mark_interrupted_tests_as_skipped):
469         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
470         (FakePrinter.print_expected):
471         (LockCheckingRunner.__init__):
472         (LayoutTestRunnerTests._runner):
473         (LayoutTestRunnerTests._run_tests):
474         (LayoutTestRunnerTests.test_interrupt_if_at_failure_limits):
475         * Scripts/webkitpy/layout_tests/controllers/manager.py:
476         (Manager.__init__):
477         (Manager.run):
478         (Manager._run_tests):
479
480 2012-12-05  Dirk Pranke  <dpranke@chromium.org>
481
482         nrwt: move creation of the resultsummary objects into Manager._run_tests()
483         https://bugs.webkit.org/show_bug.cgi?id=104048
484
485         Reviewed by Ojan Vafai.
486
487         This is a preparatory step to making the resultsummary just get
488         returned from the layout_test_runner; this does most of manager-side
489         changes.
490
491         * Scripts/webkitpy/layout_tests/controllers/manager.py:
492         (Manager._prepare_lists):
493         (Manager.run):
494         (Manager._run_tests):
495
496 2012-12-05  Leo Yang  <leoyang@rim.com>
497
498         [BlackBerry] Enable CSS_IMAGE_RESOLUTION
499         https://bugs.webkit.org/show_bug.cgi?id=104132
500
501         Reviewed by Yong Li.
502
503         * Scripts/webkitperl/FeatureList.pm:
504
505 2012-12-05  Filip Pizlo  <fpizlo@apple.com>
506
507         JSC profiler should not count executions of op_call_put_result because doing so changes DFG codegen
508         https://bugs.webkit.org/show_bug.cgi?id=104102
509
510         Reviewed by Oliver Hunt.
511
512         Modify the profiler to not output counts for op_call_put_result, since there
513         won't be any. Also fix a few weird bugs, like providing better error reporting
514         when you type something incorrectly and not reporting counts for slow paths
515         in the old JIT since those counts are actually not what you think they are
516         (we don't actually count slow path executions separately).
517
518         * Scripts/display-profiler-output:
519
520 2012-12-05  Andras Becsi  <andras.becsi@digia.com>
521
522         Fix compilation for Qt5.0.0 stable branch.
523         https://bugs.webkit.org/show_bug.cgi?id=103870
524
525         Reviewed by Simon Hausmann.
526
527         Fix the use of renamed QWindow functions.
528         Patch by Andras Becsi <andras.becsi@digia.com>
529
530         * MiniBrowser/qt/BrowserWindow.cpp:
531         (BrowserWindow::BrowserWindow):
532         (BrowserWindow::onTitleChanged):
533         * MiniBrowser/qt/raw/View.cpp:
534         (View::View):
535
536 2012-12-05  Jussi Kukkonen  <jussi.kukkonen@intel.com>
537
538         [WK2] InjectedBundle should check Intent url for null
539         https://bugs.webkit.org/show_bug.cgi?id=104117
540
541         Reviewed by Kenneth Rohde Christiansen.
542
543         WKIntentServiceInfoCopyHref() can return null, we need to check
544         for that in InjectedBundlePage::registerIntentServiceForFrame()
545         to avoid crashing.
546
547         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
548         (WTR::InjectedBundlePage::registerIntentServiceForFrame):
549
550 2012-12-04  Jonathan Dong  <jonathan.dong@torchmobile.com.cn>
551
552         Change email address of Jonathan Dong
553         https://bugs.webkit.org/show_bug.cgi?id=103976
554
555         Unreviewed, change my email address from jonathan.dong@torchmobile.com.cn
556         to jonathan.dong.webkit@gmail.com in committers list.
557
558         * Scripts/webkitpy/common/config/committers.py:
559
560 2012-12-04  Xiaobo Wang  <xbwang@torchmobile.com.cn>
561
562         [BlackBerry] DRT - Tests under "dumpAsText" directory should be dumped as text
563         https://bugs.webkit.org/show_bug.cgi?id=103986
564
565         Reviewed by Rob Buis.
566
567         Also move declaration of webSettingTransaction to before any WebSettings
568         ::setXXX() calls so that it works as expected (commit only once in the
569         function scope).
570
571         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
572         (shouldDumpAsText):
573         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
574
575 2012-12-04  Filip Pizlo  <fpizlo@apple.com>
576
577         display-profiler-output should be able to show source code
578         https://bugs.webkit.org/show_bug.cgi?id=104073
579
580         Reviewed by Oliver Hunt.
581
582         Display source code in the summary, using a one-line shortening.
583
584         * Scripts/display-profiler-output:
585
586 2012-12-04  Filip Pizlo  <fpizlo@apple.com>
587
588         display-profiler-output should not use reflective infocation to resolve command names
589
590         Rubber stamped by Mark Hahnenberg.
591
592         Reflection is amazing, but here it was just kind of a bit much.
593
594         * Scripts/display-profiler-output:
595
596 2012-12-02  Filip Pizlo  <fpizlo@apple.com>
597
598         JSC should be able to report profiling data associated with the IR dumps and disassembly
599         https://bugs.webkit.org/show_bug.cgi?id=102999
600
601         Reviewed by Gavin Barraclough.
602
603         Added a tool that allows you to grok the output from JSC's new profiler. Currently,
604         this still gets confused a bit about the execution counts of a method running
605         standalone versus a method running inlined, but other than that, it's pretty cool.
606         See the attached "sampling profiling session" attached to the bug to see it in
607         action.
608         
609         Also had to feed EFL's build system.
610
611         * DumpRenderTree/efl/CMakeLists.txt:
612         * Scripts/display-profiler-output: Added.
613
614 2012-12-04  Dirk Pranke  <dpranke@chromium.org>
615
616         nrwt: fix total number of tests computed in the result summary
617         https://bugs.webkit.org/show_bug.cgi?id=104061
618
619         Unreviewed, build fix.
620
621         One of the recent changes to the resultsummary refactoring caused
622         us to not include the number of skipped tests in the total number
623         of tests, throwing off the totals printed in print_one_line_summary().
624
625         Unfortunately, given the current state of the code it is difficult
626         to construct an accurate unit test for this. I have verified the
627         fix by hand, and will write a test once the remaining refactoring
628         patches land, at which point it will be trivial to test it.
629
630         * Scripts/webkitpy/layout_tests/controllers/manager.py:
631         (Manager._prepare_lists):
632
633 2012-12-04  Dirk Pranke  <dpranke@chromium.org>
634
635         nrwt is not returning the exit status properly
636         https://bugs.webkit.org/show_bug.cgi?id=103830
637
638         Unreviewed, build fix.
639
640         The fix in r136474 wasn't quite right either, and would return
641         the correct exceptional status, but not the correct failing status.
642
643         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
644
645 2012-12-04  Dirk Pranke  <dpranke@chromium.org>
646
647         nrwt: make paths and test_names passed arguments in Manager._prepare_lists et al
648         https://bugs.webkit.org/show_bug.cgi?id=104047
649
650         Reviewed by Eric Seidel.
651
652         The code becomes cleaner if we are just passing values around rather
653         than hanging them off the manager object, helps move _prepare_lists()
654         to a pure function, and is needed to eventually make the
655         result_summary object something returned from runner.run_tests()
656         (note that two more patches are needed for that to happen).
657
658         * Scripts/webkitpy/layout_tests/controllers/manager.py:
659         (Manager.__init__):
660         (Manager._http_tests):
661         (Manager._prepare_lists):
662         (Manager.needs_servers):
663         (Manager._set_up_run):
664         (Manager.run):
665         (Manager._run_tests):
666         (Manager._upload_json_files):
667         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
668         (ManagerTest.test_needs_servers.get_manager):
669         (ManagerTest.test_needs_servers):
670         (ManagerTest.integration_test_needs_servers.get_manager):
671         (ManagerTest.integration_test_needs_servers):
672         (ManagerTest.test_look_for_new_crash_logs.get_manager):
673         (ManagerTest):
674         (ManagerTest.test_look_for_new_crash_logs):
675         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
676         (JSONLayoutResultsGenerator.__init__):
677         (JSONLayoutResultsGenerator._get_modifier_char):
678
679 2012-12-04  Adam Barth  <abarth@webkit.org>
680
681         commit-queue can get stuck with a local commit
682         https://bugs.webkit.org/show_bug.cgi?id=104032
683
684         Reviewed by Dirk Pranke.
685
686         Previously the commit-queue would only clean down to HEAD. If the
687         commit-queue gets interrupted in the middle of a commit (e.g., after
688         the local commit but before the dcommit), then it can end up with a
689         patch locally committed. That patch will then prevent the commit-queue
690         from functioning.
691
692         This patch teaches the commit-queue to clean down to the merge base,
693         which will remove any local commits.
694
695         * Scripts/webkitpy/common/checkout/scm/git.py:
696         (Git.working_directory_is_clean):
697         (Git.clean_working_directory):
698         * Scripts/webkitpy/tool/commands/roll_unittest.py:
699         * Scripts/webkitpy/tool/steps/commit.py:
700         (Commit._commit_warning):
701         (Commit.run):
702
703 2012-12-04  Dirk Pranke  <dpranke@chromium.org>
704
705         nrwt: store only the total number of tests in the result summary
706         https://bugs.webkit.org/show_bug.cgi?id=103963
707
708         Reviewed by Ryosuke Niwa.
709
710         The result summary only needs the total number of tests that will
711         be run (including repetitions) in order to provide the correct stats;
712         it doesn't actually need to know how many unique tests there are, or
713         or how many repetitions there are.
714
715         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
716         (LayoutTestRunnerTests._result_summary):
717         (LayoutTestRunnerTests.test_update_summary_with_result):
718         * Scripts/webkitpy/layout_tests/controllers/manager.py:
719         (Manager._prepare_lists):
720         (Manager.run):
721         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
722         (ManagerTest.test_look_for_new_crash_logs):
723         (ResultSummaryTest.get_result_summary):
724         * Scripts/webkitpy/layout_tests/models/result_summary.py:
725         (ResultSummary.__init__):
726         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
727         (Testprinter.get_result_summary):
728
729 2012-12-04  Dirk Pranke  <dpranke@chromium.org>
730
731         nrwt: do less work when ctrl-c'ed
732         https://bugs.webkit.org/show_bug.cgi?id=103961
733
734         Reviewed by Ryosuke Niwa.
735
736         Do less work when we are ctrl-c'ed, because the statistics aren't
737         that useful anyway. While we're at it, modify summarize_results
738         to be aware that we don't always retry results (instead of pretending
739         that the retry produced the same results the initial run did).
740
741         * Scripts/webkitpy/layout_tests/controllers/manager.py:
742         (summarize_results):
743         (Manager.run):
744
745 2012-12-04  Dirk Pranke  <dpranke@chromium.org>
746
747         nrwt: result summaries should not require a list of tests to skip
748         https://bugs.webkit.org/show_bug.cgi?id=103951
749
750         Reviewed by Ryosuke Niwa.
751
752         We shouldn't really be passing a list of tests to skip to the
753         ResultSummary objects; they should be handled like any other
754         test result as much as possible.
755
756         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
757         (LayoutTestRunnerTests._result_summary):
758         (LayoutTestRunnerTests.test_update_summary_with_result):
759         * Scripts/webkitpy/layout_tests/controllers/manager.py:
760         (Manager._prepare_lists):
761         (Manager.run):
762         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
763         (ManagerTest.test_look_for_new_crash_logs):
764         (ResultSummaryTest.get_result_summary):
765         * Scripts/webkitpy/layout_tests/models/result_summary.py:
766         (ResultSummary.__init__):
767         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
768         (TestExpectations):
769         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
770         (Testprinter.get_result_summary):
771
772 2012-12-04  Dirk Pranke  <dpranke@chromium.org>
773
774         nrwt: derive per-thread, per-worker stats from result summaries
775         https://bugs.webkit.org/show_bug.cgi?id=103943
776
777         Reviewed by Ojan Vafai.
778
779         This patch changes the manager and printing code to pull more           
780         information from the ResultSummary object rather than tracking          
781         additional statistics on the side. This allows us to consolidate        
782         a bunch of logic and remove a bunch of free-floating lists and dicts of 
783         of values. We add the shard_name and worker_name to each TestResult,    
784         and then modify print_timing_statistics() and upload_json_files()       
785         to just need the result summaries.                                      
786
787         Note that this patch also changes the timing statistics slightly
788         so that the individual test times are the times to run just the
789         tests themselves (TestResult.test_run_time) and do not include the
790         times taken to run the ref tests, compute diffs, etc. The aggregated
791         per-worker and per-shard statistics still use the total time to
792         process each test (TestResult.total_run_time).
793
794         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
795         (LayoutTestRunner.__init__):
796         (LayoutTestRunner.run_tests):
797         (LayoutTestRunner._handle_finished_test_list):
798         (LayoutTestRunner._handle_finished_test):
799         (Worker.handle):
800         (Worker._run_test):
801         * Scripts/webkitpy/layout_tests/controllers/manager.py:
802         (summarize_results):
803         (Manager.run):
804         (Manager._upload_json_files):
805         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
806         (ResultSummaryTest.summarized_results):
807         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
808         (JSONLayoutResultsGenerator.__init__):
809         (JSONLayoutResultsGenerator._get_test_timing):
810         * Scripts/webkitpy/layout_tests/models/test_results.py:
811         (TestResult.__init__):
812         * Scripts/webkitpy/layout_tests/views/printing.py:
813         (Printer.print_results):
814         (Printer._print_timing_statistics):
815         (Printer):
816         (Printer._print_worker_statistics):
817         (Printer._print_aggregate_test_statistics):
818         (Printer._print_individual_test_times):
819         (Printer._print_directory_timings):
820         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
821         (Testprinter.test_print_unexpected_results.get_unexpected_results):
822         (Testprinter):
823
824 2012-12-04  Adam Barth  <abarth@webkit.org>
825
826         Remove obsolete code from webkitpy
827         https://bugs.webkit.org/show_bug.cgi?id=104029
828
829         Reviewed by Eric Seidel.
830
831         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
832         (CommitQueueTask.run):
833         * Scripts/webkitpy/tool/steps/commit.py:
834         (Commit.options):
835         * Scripts/webkitpy/tool/steps/options.py:
836         (Options):
837
838 2012-12-04  Jochen Eisinger  <jochen@chromium.org>
839
840         [chromium] move WebPreferences and methods for modifying them to the TestRunner library
841         https://bugs.webkit.org/show_bug.cgi?id=103841
842
843         Reviewed by Darin Fisher.
844
845         * DumpRenderTree/DumpRenderTree.gypi:
846         * DumpRenderTree/chromium/DRTTestRunner.cpp:
847         (DRTTestRunner::DRTTestRunner):
848         (DRTTestRunner::reset):
849         * DumpRenderTree/chromium/DRTTestRunner.h:
850         (DRTTestRunner):
851         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h: Renamed from Tools/DumpRenderTree/chromium/WebPreferences.h.
852         (WebKit):
853         (WebTestRunner):
854         (WebPreferences):
855         (WebTestRunner::WebPreferences::WebPreferences):
856         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
857         (WebTestRunner):
858         (WebTestDelegate):
859         (WebTestRunner::WebTestDelegate::localFileToDataURL):
860         (WebTestRunner::WebTestDelegate::rewriteLayoutTestsURL):
861         (WebTestRunner::WebTestDelegate::preferences):
862         (WebTestRunner::WebTestDelegate::applyPreferences):
863         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
864         (WebTestRunner::TestRunner::TestRunner):
865         (WebTestRunner::TestRunner::reset):
866         (WebTestRunner::TestRunner::setUserStyleSheetEnabled):
867         (WebTestRunner):
868         (WebTestRunner::TestRunner::setUserStyleSheetLocation):
869         (WebTestRunner::TestRunner::setAuthorAndUserStylesEnabled):
870         (WebTestRunner::TestRunner::setPopupBlockingEnabled):
871         (WebTestRunner::TestRunner::setJavaScriptCanAccessClipboard):
872         (WebTestRunner::TestRunner::setXSSAuditorEnabled):
873         (WebTestRunner::TestRunner::setAllowUniversalAccessFromFileURLs):
874         (WebTestRunner::TestRunner::setAllowFileAccessFromFileURLs):
875         (WebTestRunner::TestRunner::overridePreference):
876         (WebTestRunner::TestRunner::setPluginsEnabled):
877         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
878         (TestRunner):
879         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp: Renamed from Tools/DumpRenderTree/chromium/WebPreferences.cpp.
880         (WebTestRunner::WebPreferences::reset):
881         (WebTestRunner):
882         (WebTestRunner::WebPreferences::applyTo):
883         * DumpRenderTree/chromium/TestShell.h:
884         (TestShell::preferences):
885         (TestShell):
886         * DumpRenderTree/chromium/WebViewHost.cpp:
887         (WebViewHost::localFileToDataURL):
888         (WebViewHost::rewriteLayoutTestsURL):
889         (WebViewHost::preferences):
890         (WebViewHost::applyPreferences):
891         * DumpRenderTree/chromium/WebViewHost.h:
892         (WebViewHost):
893
894 2012-12-04  Zan Dobersek  <zandobersek@gmail.com>
895
896         Many webkitpy unit tests can be run standalone, are executable
897         https://bugs.webkit.org/show_bug.cgi?id=103900
898
899         Reviewed by Eric Seidel.
900
901         There's no need anymore to run unit tests in standalone mode as they
902         are now handled by test-webkitpy in a formidable fashion. This makes
903         it possible for this patch to remove the following unnecessary bits:
904         - remove shebang lines from unit test files,
905         - remove calls to unittest.main(),
906         - make unit test files non-executable.
907
908         * Scripts/webkitpy/common/checkout/diff_parser_unittest.py:
909         (DiffParserTest.test_git_mnemonicprefix):
910         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
911         (GitTestWithMock.test_push_local_commits_to_server_without_username_and_with_password):
912         * Scripts/webkitpy/common/config/build_unittest.py:
913         (ShouldBuildTest.test_should_build):
914         * Scripts/webkitpy/common/config/ports_unittest.py:
915         (DeprecatedPortTest.test_chromium_xvfb_port):
916         * Scripts/webkitpy/common/find_files_unittest.py:
917         (TestWinNormalize.test_win):
918         * Scripts/webkitpy/common/lru_cache_unittest.py:
919         (LRUCacheTest.test_set_again):
920         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
921         (test_results_zip_url):
922         * Scripts/webkitpy/common/net/credentials_unittest.py:
923         (test_keyring_without_git_repo_nor_keychain):
924         * Scripts/webkitpy/common/net/omahaproxy_unittest.py:
925         (OmahaProxyTest.test_get_revisions):
926         * Scripts/webkitpy/common/net/unittestresults_unittest.py:
927         * Scripts/webkitpy/common/newstringio_unittest.py:
928         (NewStringIOTest.test_with):
929         * Scripts/webkitpy/common/read_checksum_from_png_unittest.py:
930         (ReadChecksumFromPngTest.test_read_checksum):
931         * Scripts/webkitpy/common/system/file_lock_integrationtest.py:
932         * Scripts/webkitpy/common/system/filesystem_mock_unittest.py:
933         (MockFileSystemTest.test_normpath):
934         * Scripts/webkitpy/common/system/filesystem_unittest.py:
935         (RealFileSystemTest.test_sep):
936         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
937         (TestPlatformInfo.test_total_bytes_memory):
938         * Scripts/webkitpy/common/system/zipfileset_unittest.py:
939         (ZipFileSetTest.test_namelist):
940         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
941         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
942         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
943         (TestResultWriterTest.test_reftest_diff_image):
944         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
945         (JSONGeneratorTest.test_test_timings_trie):
946         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
947         (TestExpectationSerializationTests.test_string_whitespace_stripping):
948         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
949         (KeyCompareTest.test_test_key):
950         * Scripts/webkitpy/layout_tests/port/builders_unittest.py:
951         (BuildersTest.test_path_from_name):
952         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
953         (ChromiumAndroidTwoPortsTest.test_options_with_two_ports):
954         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
955         (ChromiumLinuxPortTest.test_path_to_image_diff):
956         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
957         (ChromiumMacPortTest.test_path_to_image_diff):
958         * Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py:
959         (ChromiumPortLoggingTest.test_check_sys_deps):
960         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
961         (ChromiumPortLoggingTest.test_check_sys_deps):
962         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
963         (ConfigTest.test_default_configuration__scripterror):
964         * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
965         (DriverTest.test_start_actually_starts):
966         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
967         (FactoryTest.test_get_from_builder_name):
968         * Scripts/webkitpy/layout_tests/port/http_lock_unittest.py:
969         * Scripts/webkitpy/layout_tests/port/image_diff_unittest.py:
970         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
971         * Scripts/webkitpy/layout_tests/reftests/extract_reference_link_unittest.py:
972         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
973         (PortTest.disabled_test_mac_lion):
974         * Scripts/webkitpy/layout_tests/servers/http_server_integrationtest.py:
975         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
976         (VerboseTest.test_log_args):
977         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
978         (test_details):
979         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
980         (TestPerfTestFactory.test_inspector_test):
981         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
982         (test_parse_args):
983         * Scripts/webkitpy/style/checker_unittest.py:
984         * Scripts/webkitpy/style/checkers/changelog_unittest.py:
985         (ChangeLogCheckerTest.test_no_error):
986         * Scripts/webkitpy/style/checkers/common_unittest.py:
987         (TabCheckerTest.test_tab):
988         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
989         (CppCheckerTest.test_ne):
990         * Scripts/webkitpy/style/checkers/jsonchecker_unittest.py:
991         * Scripts/webkitpy/style/checkers/png_unittest.py:
992         (PNGCheckerTest.test_check):
993         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
994         * Scripts/webkitpy/style/checkers/text_unittest.py:
995         (TextCheckerTest.test_init):
996         * Scripts/webkitpy/style/checkers/watchlist_unittest.py:
997         * Scripts/webkitpy/style/checkers/xcodeproj_unittest.py:
998         (XcodeProjectFileCheckerTest.test_detect_development_region):
999         * Scripts/webkitpy/style/checkers/xml_unittest.py:
1000         (XMLCheckerTest.test_no_error):
1001         * Scripts/webkitpy/style/patchreader_unittest.py:
1002         * Scripts/webkitpy/test/finder_unittest.py:
1003         (FinderTest.test_paths):
1004         * Scripts/webkitpy/test/runner_unittest.py:
1005         (RunnerTest.test_run):
1006         * Scripts/webkitpy/test/skip_unittest.py:
1007         (SkipTest.test_skip_if_true):
1008         * Scripts/webkitpy/thirdparty/__init___unittest.py:
1009         (ThirdpartyTest.test_imports):
1010         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests_unittest.py:
1011         (TestTranslation.test_include_rewriting):
1012         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
1013         (QueueEngineTest.tearDown):
1014         * Scripts/webkitpy/tool/grammar_unittest.py:
1015         (GrammarTest.test_join_with_separators):
1016         * Scripts/webkitpy/tool/mocktool_unittest.py:
1017         (MockOptionsTest.test_kwarg__set):
1018         * Scripts/webkitpy/tool/multicommandtool_unittest.py:
1019         (test_command_help):
1020
1021 2012-12-04  Zan Dobersek  <zandobersek@gmail.com>
1022
1023         Many webkitpy module files are executable, have shebang line
1024         https://bugs.webkit.org/show_bug.cgi?id=103985
1025
1026         Reviewed by Dirk Pranke.
1027
1028         Remove the executable bit from webkitpy module files that are
1029         unnecessarily executable. Remove the shebang line from webkitpy
1030         module files, they are of no use. Only non-third-party files are
1031         changed.
1032
1033         * Scripts/webkitpy/bindings/main.py:
1034         * Scripts/webkitpy/common/config/watchlist:
1035         * Scripts/webkitpy/common/find_files.py:
1036         * Scripts/webkitpy/common/lru_cache.py:
1037         * Scripts/webkitpy/common/multiprocessing_bootstrap.py:
1038         * Scripts/webkitpy/common/net/file_uploader.py:
1039         * Scripts/webkitpy/common/newstringio.py:
1040         * Scripts/webkitpy/common/read_checksum_from_png.py:
1041         * Scripts/webkitpy/common/system/autoinstall.py:
1042         * Scripts/webkitpy/common/system/file_lock.py:
1043         * Scripts/webkitpy/common/system/file_lock_mock.py:
1044         * Scripts/webkitpy/common/version_check.py:
1045         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1046         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1047         * Scripts/webkitpy/layout_tests/models/test_failures.py:
1048         * Scripts/webkitpy/layout_tests/models/test_input.py:
1049         * Scripts/webkitpy/layout_tests/port/__init__.py:
1050         * Scripts/webkitpy/layout_tests/port/base.py:
1051         * Scripts/webkitpy/layout_tests/port/builders.py:
1052         * Scripts/webkitpy/layout_tests/port/chromium.py:
1053         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1054         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1055         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1056         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1057         * Scripts/webkitpy/layout_tests/port/config.py:
1058         * Scripts/webkitpy/layout_tests/port/factory.py:
1059         * Scripts/webkitpy/layout_tests/port/http_lock.py:
1060         * Scripts/webkitpy/layout_tests/port/image_diff.py:
1061         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
1062         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1063         * Scripts/webkitpy/layout_tests/port/server_process.py:
1064         * Scripts/webkitpy/layout_tests/port/test.py:
1065         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1066         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
1067         * Scripts/webkitpy/layout_tests/servers/http_server.py:
1068         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
1069         * Scripts/webkitpy/layout_tests/servers/websocket_server.py:
1070         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
1071         * Scripts/webkitpy/layout_tests/views/printing.py:
1072         * Scripts/webkitpy/performance_tests/perftest.py:
1073         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1074         * Scripts/webkitpy/style/checkers/changelog.py:
1075         * Scripts/webkitpy/style/checkers/cpp.py:
1076         * Scripts/webkitpy/style/checkers/xcodeproj.py:
1077         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py:
1078         (main): There's no need to run this module in standalone because
1079         it's wrapped by the Tools/Scripts/update-webgl-conformance-tests script.
1080         * Scripts/webkitpy/tool/commands/upload.py:
1081         * Scripts/webkitpy/tool/comments.py:
1082         * Scripts/webkitpy/tool/main.py:
1083
1084 2012-12-04  Ryosuke Niwa  <rniwa@webkit.org>
1085
1086         Add a Chromium Android Release (Perf) to the list of perf. bots.
1087
1088         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
1089
1090 2012-12-04  Zan Dobersek  <zandobersek@gmail.com>
1091
1092         [GTK] Insert the jhbuild wrapper command at the beginning of the command list
1093         https://bugs.webkit.org/show_bug.cgi?id=103991
1094
1095         Reviewed by Martin Robinson.
1096
1097         Insert the Tools/gtk/run-with-jhbuild wrapper at the beginning of the
1098         command that's being formed in multiprocessing bootstrap. The wrapper is
1099         an executable Python script while the command being wrapped perhaps isn't
1100         and therefore requires the Python interpreter to be listed at the beginning
1101         of the command sublist that is then executed by the wrapper.
1102
1103         Specifically, the webkitpy/layout_tests/run_webkit_tests.py module file
1104         is about to lose the executable bit and the Python-signaling shebang line.
1105         The Jhbuild wrapper simply executes the command that's passed, but that errs
1106         in this case unless the Python executable is executed and the module file
1107         is passed to it as an argument.
1108
1109         * Scripts/webkitpy/common/multiprocessing_bootstrap.py:
1110         (run):
1111
1112 2012-12-04  Peter Beverloo  <peter@chromium.org>
1113
1114         Add the Chromium Android Release (Perf) bot
1115         https://bugs.webkit.org/show_bug.cgi?id=103891
1116
1117         Reviewed by Eric Seidel.
1118
1119         Add configuration for the bot itself. It will be triggered by the Chromium
1120         Android Release builder. When running for Android, the DownloadAndPerfTest
1121         factory will also add the OutputAndroidDeviceStatus step.
1122
1123         * BuildSlaveSupport/build.webkit.org-config/config.json:
1124         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1125         (DownloadAndPerfTestFactory.__init__):
1126
1127 2012-12-04  Peter Beverloo  <peter@chromium.org>
1128
1129         [Chromium] The ChromiumAndroidDriver constructor should not rely on adb being available
1130         https://bugs.webkit.org/show_bug.cgi?id=103758
1131
1132         Reviewed by Eric Seidel.
1133
1134         Lazily initialize the adb command parameters rather than initializing it in the
1135         constructor now that there is an assert if adb is not available on the system and
1136         we're not in a Chromium Android checkout.
1137
1138         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1139         (ChromiumAndroidDriver.__init__):
1140         (ChromiumAndroidDriver._push_file_if_needed):
1141         (ChromiumAndroidDriver._run_adb_command):
1142         (ChromiumAndroidDriver.cmd_line):
1143         (ChromiumAndroidDriver._start_once):
1144         (ChromiumAndroidDriver._read_prompt):
1145         (ChromiumAndroidDriver):
1146         (ChromiumAndroidDriver._adb_command):
1147
1148 2012-12-03  Ryosuke Niwa  <rniwa@webkit.org>
1149
1150         Dromaeo should report individual test result
1151         https://bugs.webkit.org/show_bug.cgi?id=99800
1152
1153         Reviewed by Eric Seidel.
1154
1155         Ignore subtest results spit out by Dromaeo tests.
1156
1157         * Scripts/webkitpy/performance_tests/perftest.py:
1158         (PerfTest): Added a line to ignore.
1159         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
1160         (MainTest.test_parse_output_with_subtests): Added.
1161
1162 2012-12-03  Zan Dobersek  <zandobersek@gmail.com>
1163
1164         Unreviewed, functionality fix after r136437.
1165
1166         Calling sys.exit actually raises a SystemExit exception that
1167         is then handled in the second block and causes the script to
1168         return an 'exceptional' exit code rather than the code presenting
1169         the number of failed tests.
1170
1171         This is just a temporary fix to get the faultless bots green while
1172         they are unnecessarily red at the moment. The problem and a proper
1173         fix will be properly addressed.
1174
1175         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1176
1177 2012-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
1178
1179         Unreviewed, rolling out r136460.
1180         http://trac.webkit.org/changeset/136460
1181         https://bugs.webkit.org/show_bug.cgi?id=103958
1182
1183         This patch caused compile error when building DumpRenderTree
1184         (Requested by tasak on #webkit).
1185
1186         * Scripts/webkitpy/common/config/build_unittest.py:
1187         (ShouldBuildTest):
1188
1189 2012-12-03  Scott Violet  <sky@chromium.org>
1190
1191         [chromium] Remove linux theme related files and switch to default
1192         https://bugs.webkit.org/show_bug.cgi?id=103897
1193
1194         Reviewed by Darin Fisher.
1195
1196         * Scripts/webkitpy/common/config/build_unittest.py:
1197         (ShouldBuildTest): linux->default
1198
1199 2012-12-03  Roger Fong  <roger_fong@apple.com>
1200
1201         Disable WebKit2 API tests on Apple Windows port.
1202         https://bugs.webkit.org/show_bug.cgi?id=103929.
1203
1204         Reviewed by Timothy Horton.
1205
1206         * Scripts/run-api-tests:
1207         (runTestsBySuite):
1208
1209 2012-12-03  Dirk Pranke  <dpranke@chromium.org>
1210
1211         webkitpy's run_webkit_tests should initialize the printer earlier on
1212         https://bugs.webkit.org/show_bug.cgi?id=103661
1213
1214         Reviewed by Eric Seidel.
1215
1216         Initialize the printer before computing the derived options
1217         from the command line arguments, so that we can safely log from
1218         port methods.
1219
1220         Also clean up a few miscellaneous lint warnings.
1221
1222         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1223         (ChromiumAndroidPort.path_to_adb):
1224         * Scripts/webkitpy/layout_tests/port/mac.py:
1225         (MacPort.default_child_processes):
1226         (MacPort.sample_process):
1227         (MacPort.start_helper):
1228         (MacPort.stop_helper):
1229         (MacPort.nm_command):
1230         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1231         (test_default_child_processes):
1232         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1233         (run):
1234         (_set_up_derived_options):
1235
1236 2012-12-03  Dirk Pranke  <dpranke@chromium.org>
1237
1238         webkitpy: autoinstaller is failing on windows
1239         https://bugs.webkit.org/show_bug.cgi?id=103699
1240
1241         Reviewed by Tony Chang.
1242
1243         Attempt to fix the python autoinstaller to work for pylint on win32
1244         again ... it turns out one of the dependent packages contains
1245         a write-protected test file and windows will choke when it tries to move
1246         it into place. Fortunately we can just delete the file prior to
1247         installing it in the final location, but we have to jump through
1248         a couple of hoops to do so.
1249
1250         Also, make sure that we're flattening nested module names like
1251         "logilab/common" into either safe basenames (logilab_common) or
1252         host-specific subdirs (logilab\common) as needed.
1253
1254         * Scripts/webkitpy/common/system/autoinstall.py:
1255         (AutoInstaller._url_downloaded_path):
1256         (AutoInstaller._install):
1257         (AutoInstaller.install):
1258         * Scripts/webkitpy/thirdparty/__init__.py:
1259         (AutoinstallImportHook._install_pylint):
1260
1261 2012-12-03  Dirk Pranke  <dpranke@chromium.org>
1262
1263         nrwt: clean up exception propagation / handling for interrupts and early exits
1264         https://bugs.webkit.org/show_bug.cgi?id=103830
1265
1266         Reviewed by Ojan Vafai.
1267
1268         The code for propagating early exits out of the test run was
1269         convoluted and hard to follow. By adjusting the WorkerException to
1270         derive from BaseException rather than Exception (which is a fair
1271         way of representing an error that was really unexpected/unrecoverable
1272         anyway) and pushing the TestRunInterruptedException into the
1273         ResultSummary (which is also fair since it was more of a result
1274         than an exception) this allows us to consolidate and clean up
1275         a bunch of the try/catch logic and pass fewer state flags around.
1276
1277         There are no real functional changes to this patch; there's an
1278         API change in that we stop exporting TestRunInterruptedException
1279         and WorkerException out of the Manager, and the existence of the
1280         MessagePool is now completely hidden.
1281
1282         * Scripts/webkitpy/common/message_pool.py:
1283         (WorkerException):
1284         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
1285         (LayoutTestRunner.run_tests):
1286         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1287         (summarize_results):
1288         (Manager.run):
1289         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1290         (ResultSummaryTest.summarized_results):
1291         * Scripts/webkitpy/layout_tests/models/result_summary.py:
1292         (ResultSummary.__init__):
1293         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1294         (run):
1295         (main):
1296         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1297         (MainTest.test_exception_raised.of):
1298         (MainTest.test_exception_raised):
1299         (MainTest.test_run_force):
1300         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
1301         (Testprinter.test_print_unexpected_results.get_unexpected_results):
1302         (Testprinter):
1303
1304 2012-12-03  Julien BRIANCEAU   <jbrianceau@nds.com>
1305
1306         Add Qt/SH4 build slave to build.webkit.org
1307         https://bugs.webkit.org/show_bug.cgi?id=103384
1308
1309         Reviewed by Csaba Osztrogonác.
1310
1311         * BuildSlaveSupport/build.webkit.org-config/config.json:
1312
1313 2012-12-03  Alexis Menard  <alexis@webkit.org>
1314
1315         Enable CSS3 background-position offset by default
1316         https://bugs.webkit.org/show_bug.cgi?id=103917
1317
1318         Reviewed by Benjamin Poulain.
1319
1320         Even though each port may enable or not the feature we still need
1321         to pass it at configure time otherwise it will be disabled.
1322
1323         * Scripts/webkitperl/FeatureList.pm:
1324
1325 2012-12-03  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
1326
1327         Unreviewed. Adding myself to committers.py.
1328
1329         * Scripts/webkitpy/common/config/committers.py:
1330
1331 2012-12-03  Laszlo Gombos  <l.gombos@samsung.com>
1332
1333         [CMake] Enable building WebKit2-only build for the EFL port
1334         https://bugs.webkit.org/show_bug.cgi?id=103820
1335
1336         Reviewed by Gyuyoung Kim.
1337
1338         Set ENABLE_WEBKIT2 to OFF if build-webkit was run with --no-webkit2.
1339         Never set ENABLE_WEBKIT in build-webkit. This will simplyfy invoking
1340         cmake directly. Initialize $cmakeArgs to avoid potential
1341         warnings when running the script.
1342
1343         * Scripts/build-webkit:
1344
1345 2012-12-03  Tommy Widenflycht  <tommyw@google.com>
1346
1347         Speech Recognition API: Update SpeechRecognitionEvent to match the specification
1348         https://bugs.webkit.org/show_bug.cgi?id=103407
1349
1350         Reviewed by Kentaro Hara.
1351
1352         Changing the mock to use the new results delivery API.
1353
1354         * DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp:
1355
1356 2012-12-03  Alexis Menard  <alexis@webkit.org>
1357
1358         [Qt] Enable CSS3 background-position offsets by default.
1359         https://bugs.webkit.org/show_bug.cgi?id=103877
1360
1361         Reviewed by Tor Arne Vestbø.
1362
1363         Enable by default CSS3 background-position offsets.
1364
1365         * qmake/mkspecs/features/features.pri:
1366
1367 2012-12-03  KyungTae Kim  <ktf.kim@samsung.com>
1368
1369         [EFL][WK2] Use float variable for zoom levels for MiniBrowser
1370         https://bugs.webkit.org/show_bug.cgi?id=103863
1371
1372         Reviewed by Gyuyoung Kim.
1373
1374         Use float instead of int for zoomLevels variables for a clearer expression
1375
1376         * MiniBrowser/efl/main.c:
1377         (on_key_down):
1378
1379 2012-12-02  KyungTae Kim  <ktf.kim@samsung.com>
1380
1381         [EFL][WK2] Add support for a zoom level setting to MiniBrowser
1382         https://bugs.webkit.org/show_bug.cgi?id=99285
1383
1384         Reviewed by Gyuyoung Kim.
1385
1386          Add support for a zoom level setting to MiniBrowser.
1387          Shortcuts for setting operations are same as common browsers:
1388          Ctrl + '+' to zoom in, Ctrl + '-' to zoom out and Ctrl + '0' to zoom to default.
1389
1390         * MiniBrowser/efl/main.c:
1391         (on_key_down):
1392
1393 2012-12-02  KyungTae Kim  <ktf.kim@samsung.com>
1394
1395         [EFL][WK2] ECORE_GETOPT_VALUE_BOOL need to be used for Eina_Bool
1396         https://bugs.webkit.org/show_bug.cgi?id=103835
1397
1398         Reviewed by Kentaro Hara.
1399
1400         Because legacy_behavior_enabled is Eina_Bool, ECORE_GETOPT_VALUE_BOOL need to be used
1401
1402         * MiniBrowser/efl/main.c:
1403         (elm_main):
1404
1405 2012-12-02  Mike West  <mkwst@chromium.org>
1406
1407         Garden-o-matic shouldn't die when blank JSON results are received.
1408         https://bugs.webkit.org/show_bug.cgi?id=103838
1409
1410         Reviewed by Adam Barth.
1411
1412         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
1413             If the JSONP string doesn't contain '(' or ')', return an empty object.
1414         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
1415             Check that this behavior stays in place.
1416
1417 2012-12-02  Eric Seidel  <eric@webkit.org>
1418
1419         run-perf-tests --profile should use iprofiler instead of instruments on Mac
1420         https://bugs.webkit.org/show_bug.cgi?id=103765
1421
1422         Unreviewed.  Updating the unittests after my previous change.
1423
1424         * Scripts/webkitpy/common/system/profiler_unittest.py:
1425         (ProfilerFactoryTest.test_basic):
1426
1427 2012-12-02  Julie Parent  <jparent@chromium.org>
1428
1429         Remove dead code in flakiness dashboard for obsolete buildDir option
1430         https://bugs.webkit.org/show_bug.cgi?id=103792
1431
1432         Reviewed by Dirk Pranke.
1433
1434         * TestResultServer/static-dashboards/dashboard_base.js:
1435         (initBuilders):
1436
1437 2012-12-02  Dirk Pranke  <dpranke@chromium.org>
1438
1439         nrwt: clean up logic for retrying failed tests a bit
1440         https://bugs.webkit.org/show_bug.cgi?id=103829
1441
1442         Reviewed by Ojan Vafai.
1443
1444         The code for determining when to retry test failures and
1445         show the results.html file was awkward and could stand some
1446         cleaning up. This patch should have no functional changes.
1447
1448         The routine called _get_failures() returned a dict of test names
1449         to failure types, but we only ever used the names, so I've converted
1450         it to return a list (and renamed it); also, the show_results_html()
1451         file was calling that routine to figure out if anything failed, when
1452         the information was already in the result_summary (as either
1453         unexpected_results or total_failures), so we were doing unnecessary work.
1454
1455         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1456         (Manager.__init__):
1457         (Manager.run):
1458         (Manager._run_tests):
1459         (Manager._failed_test_names):
1460         (Manager._copy_results_html_file):
1461
1462 2012-12-02  Dirk Pranke  <dpranke@chromium.org>
1463
1464         nrwt: remove unused methods in manager.py
1465         https://bugs.webkit.org/show_bug.cgi?id=103828
1466
1467         Reviewed by Eric Seidel.
1468
1469         These two methods weren't being called by anything and were no
1470         longer needed.
1471
1472         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1473         (Manager._get_failures):
1474         (Manager._upload_json_files):
1475
1476 2012-12-02  Laszlo Gombos  <l.gombos@samsung.com>
1477
1478         Correct the spelling of the cmakeargs argument
1479         https://bugs.webkit.org/show_bug.cgi?id=103814
1480
1481         Reviewed by Darin Adler.
1482
1483         The script expects cmakeargs (plural), so lets get the
1484         documentation of the script report the same.
1485
1486         * Scripts/build-webkit:
1487
1488 2012-12-02  Mike West  <mkwst@chromium.org>
1489
1490         [gtk] Enable the CSP_NEXT runtime flag.
1491         https://bugs.webkit.org/show_bug.cgi?id=103810
1492
1493         Reviewed by Adam Barth.
1494
1495         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1496         (resetDefaultsToConsistentValues):
1497             Turn on the CSP_NEXT runtime flag when running tests under GTK.
1498
1499 2012-12-02  Eric Seidel  <eric@webkit.org>
1500
1501         run-perf-tests --profile should use iprofiler instead of instruments on Mac
1502         https://bugs.webkit.org/show_bug.cgi?id=103765
1503
1504         Reviewed by Ryosuke Niwa.
1505
1506         Stephanie pointed out that iprofiler is the newer command-line interface
1507         to replace /usr/bin/instruments in Instruments 4 (which according to the
1508         interblags is supported on everything since 10.6.6), so I've moved --profile
1509         to use iprofiler on Mac.
1510
1511         I also made the IProfiler class wait for iprofiler to complete so that
1512         iprofiler won't continue running after run-perf-tests is complete (and
1513         spam over the top of your shell output).
1514
1515         There are a couple of "got-chas" to this approach:
1516         1.  iprofiler will ask for your password the first time you run it, which may
1517             cause your first test to fail.  /usr/bin/instruments doesn't seem to do that.
1518         2.  iprofiler has nice (but kinda awkward for our purposes) support for separate
1519             directory and basename arguments, making IProfiler a somewhat awkward
1520             baseclass of SingleFileOutputProfiler
1521
1522         I suspect we'll iterate from here.  It does seem slightly faster than
1523         /usr/bin/instruments was.
1524
1525         * Scripts/webkitpy/common/system/profiler.py:
1526         (ProfilerFactory.create_profiler):
1527         (IProfiler):
1528         (IProfiler.__init__):
1529         (IProfiler.attach_to_pid):
1530
1531 2012-12-02  Yongjun Zhang  <yongjun_zhang@apple.com>
1532
1533         Need a method to close all idle localstorage databases immediately.
1534         https://bugs.webkit.org/show_bug.cgi?id=103469
1535
1536         Reviewed by David Kilzer.
1537
1538         Add an JS method to TestRunner, to enable testing closing idle local storage databases in
1539         DumpRenderTree layout tests.
1540
1541         * DumpRenderTree/TestRunner.cpp:
1542         (closeIdleLocalStorageDatabasesCallback):
1543         (TestRunner::staticFunctions):
1544         * DumpRenderTree/TestRunner.h:
1545         (TestRunner):
1546         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
1547         (TestRunner::closeIdleLocalStorageDatabases):
1548         * DumpRenderTree/efl/TestRunnerEfl.cpp:
1549         (TestRunner::closeIdleLocalStorageDatabases):
1550         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
1551         (TestRunner::closeIdleLocalStorageDatabases):
1552         * DumpRenderTree/mac/TestRunnerMac.mm:
1553         (TestRunner::closeIdleLocalStorageDatabases):
1554         * DumpRenderTree/win/TestRunnerWin.cpp:
1555         (TestRunner::closeIdleLocalStorageDatabases):
1556         * DumpRenderTree/wx/TestRunnerWx.cpp:
1557         (TestRunner::closeIdleLocalStorageDatabases):
1558
1559 2012-12-02  Yael Aharon  <yael.aharon@intel.com>
1560
1561         [EFL][WK2] MiniBrowser should have a legacy mode
1562         https://bugs.webkit.org/show_bug.cgi?id=103679
1563
1564         Reviewed by Kenneth Rohde Christiansen.
1565
1566         Add an option to start MiniBrowser in legacy mode.
1567
1568         * MiniBrowser/efl/main.c:
1569         (window_create):
1570         (elm_main):
1571
1572 2012-12-02  Sheriff Bot  <webkit.review.bot@gmail.com>
1573
1574         Unreviewed, rolling out r136236.
1575         http://trac.webkit.org/changeset/136236
1576         https://bugs.webkit.org/show_bug.cgi?id=103833
1577
1578         [chromium] Flakey crashes in SpeechRecognitionEvent::emma
1579         during GC. (Requested by mkwst on #webkit).
1580
1581         * DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp:
1582
1583 2012-12-01  Zan Dobersek  <zandobersek@gmail.com>
1584
1585         [XvfbDriver] XvfbDriverTest.test_next_free_display is flaky on builders using XvfbDriver
1586         https://bugs.webkit.org/show_bug.cgi?id=103806
1587
1588         Reviewed by Dirk Pranke.
1589
1590         There are occasional mishaps on builders where XvfbDriver doesn't properly
1591         clean up the Xvfb instance it was managing so the related guard lock files
1592         are still existing when the webkitpy unit tests are run. This can cause failures
1593         in XvfbDriverTest.test_next_free_display as the test tries to acquire displays
1594         with a specific number but is unable to due to the stale locks.
1595
1596         The solution to this is to use MockFileLock when inside unit test. This is achievable
1597         by creating a file lock through the SystemHost instance connected to the Port object,
1598         the latter available to the Driver.
1599
1600         * Scripts/webkitpy/common/system/file_lock_mock.py:
1601         (MockFileLock.acquire_lock): Return True to signal lock acquiring succeeded.
1602         (MockFileLock.release_lock): Return True to signal lock releasing succeeded.
1603         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
1604         (XvfbDriver._next_free_display): Create the file lock through a mockable way.
1605         * Scripts/webkitpy/layout_tests/port/xvfbdriver_unittest.py:
1606         (XvfbDriverTest.test_next_free_display): Enable back the unit test.
1607
1608 2012-12-01  Zan Dobersek  <zandobersek@gmail.com>
1609
1610         [GTK] A11y tests in WK2 report badly-formatted AX roles
1611         https://bugs.webkit.org/show_bug.cgi?id=102947
1612
1613         Reviewed by Xan Lopez.
1614
1615         As in DRT, convert the ATK accessibility roles to corresponding AXRoles.
1616         These are expected in both tests and their baselines.
1617
1618         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1619         (WTR::roleToString):
1620         (WTR):
1621         (WTR::AccessibilityUIElement::role):
1622
1623 2012-11-30  Mike West  <mkwst@chromium.org>
1624
1625         CSP 1.1: Make the CSP_NEXT flag runtime enabled.
1626         https://bugs.webkit.org/show_bug.cgi?id=103652
1627
1628         Reviewed by Adam Barth.
1629
1630         Ensures that the new SecurityPolicy runtime flag is enabled for Chromium's tests.
1631
1632         * DumpRenderTree/chromium/TestShell.cpp:
1633         (TestShell::TestShell):
1634
1635 2012-11-30  Roger Fong  <roger_fong@apple.com>
1636
1637         Unreviewed. Removed temporary debugging change from DRT (r136300).
1638
1639         * DumpRenderTree/win/DumpRenderTree.cpp:
1640         (dump):
1641
1642 2012-11-30  Roger Fong  <roger_fong@apple.com>
1643
1644         Unreviewed. Temporary change to DRT for debugging purposes.
1645
1646         * DumpRenderTree/win/DumpRenderTree.cpp:
1647         (dump):
1648
1649 2012-11-29  Tommy Widenflycht  <tommyw@google.com>
1650
1651         Speech Recognition API: Update SpeechRecognitionEvent to match the specification
1652         https://bugs.webkit.org/show_bug.cgi?id=103407
1653
1654         Reviewed by Adam Barth.
1655
1656         Changing the mock to use the new results delivery API.
1657
1658         * DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp:
1659
1660 2012-11-30  Simon Hausmann  <simon.hausmann@digia.com>, Pierre Rossi  <pierre.rossi@digia.com>
1661
1662         [Qt] Separate Qt WebKit into Qt WebKit and Qt WebKit Widgets
1663         https://bugs.webkit.org/show_bug.cgi?id=99314
1664
1665         Reviewed by Tor Arne Vestbø.
1666
1667         This big change separates QtWebKit into QtWebKit and QtWebKitWidgets as
1668         shared libraries.
1669
1670         It's a big refactoring that mostly involves moving WebCore dependent
1671         code into QtWebKit and accessing it through exported QWebFrameAdapter
1672         and QWebPageAdapter classes.
1673
1674         * DumpRenderTree/qt/DumpRenderTree.pro:
1675         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1676         (WebCore::DumpRenderTree::dump): Adapt to internal API changes.
1677         * MiniBrowser/qt/MiniBrowser.pro:
1678         * Scripts/webkitpy/style/checker.py: Adapt Qt exceptions to new paths.
1679         * Scripts/webkitpy/style/checker_unittest.py:
1680         (GlobalVariablesTest.test_path_rules_specifier):
1681         * WebKitTestRunner/InjectedBundle/Target.pri:
1682         * qmake/mkspecs/features/default_post.prf:
1683         * qmake/mkspecs/features/webkit_modules.prf:
1684         * qmake/mkspecs/modules/webkitwidgets.prf: Removed.
1685
1686 2012-11-30  Csaba Osztrogonác  <ossy@webkit.org>
1687
1688         [Qt] Unreviewed trivial fix.
1689
1690         Add empty.cpp back, it was removed accidentally by r129092.
1691
1692         * qmake/config.tests/gccdepends/empty.cpp: Added.
1693
1694 2012-11-30  Tor Arne Vestbø  <tor.arne.vestbo@digia.com>
1695
1696         [Qt] Add support for prepare_docs and generate_docs
1697
1698         Follow-up to changes in Qt in how documentation is built.
1699
1700         Reviewed by Simon Hausmann.
1701
1702         * qmake/mkspecs/features/default_post.prf:
1703
1704 2012-11-30  Zan Dobersek  <zandobersek@gmail.com>
1705
1706         Finally remove webkitpy.common.system.deprecated_logging
1707         https://bugs.webkit.org/show_bug.cgi?id=103624
1708
1709         Reviewed by Adam Barth.
1710
1711         Remove the deprecated logging module and its unit tests now that such logging is not
1712         used anymore in webkitpy.
1713
1714         The tee and OutputTee classes are moved into a new module, webkitpy.common.system.outputtee.
1715         The tee class is renamed to Tee to conform with the usual guidelines.
1716
1717         Only unit test for the Tee class is currently provided as the OutputTee is not currently
1718         using the webkitpy Filesystem abstraction that would make its functionality testable.
1719
1720         * Scripts/webkitpy/common/system/executive.py: tee (now Tee) is now in a new module.
1721         (Executive.run_and_throw_if_fail):
1722         * Scripts/webkitpy/common/system/outputtee.py: Renamed from Tools/Scripts/webkitpy/common/system/deprecated_logging.py.
1723         (Tee):
1724         (Tee.__init__):
1725         (Tee.write):
1726         (OutputTee):
1727         (OutputTee.__init__):
1728         (OutputTee.add_log):
1729         (OutputTee.remove_log):
1730         (OutputTee._open_log_file):
1731         (OutputTee._tee_outputs_to_files):
1732         * Scripts/webkitpy/common/system/outputtee_unittest.py: Renamed from Tools/Scripts/webkitpy/common/system/deprecated_logging_unittest.py.
1733         (SimpleTeeTest):
1734         (SimpleTeeTest.test_simple_tee):
1735         * Scripts/webkitpy/tool/bot/queueengine.py: OutputTee is now in a new module.
1736         * Scripts/webkitpy/webkitpy.pyproj: Remove the deprecated_logging module and related unit test file.
1737
1738 2012-11-30  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
1739
1740         [EFL][WK2] Add support for PlatformWebView::simulateRightClick() in TestWebKitAPI
1741         https://bugs.webkit.org/show_bug.cgi?id=103634
1742
1743         Reviewed by Gyuyoung Kim.
1744
1745         Add support for PlatformWebView::simulateRightClick() and enable
1746         WebKit2 API test HitTestResultNodeHandle.
1747
1748         * TestWebKitAPI/PlatformEfl.cmake:
1749         * TestWebKitAPI/efl/PlatformWebView.cpp:
1750         (TestWebKitAPI::PlatformWebView::simulateRightClick):
1751         (TestWebKitAPI):
1752
1753 2012-11-30  Mihai Maerean  <mmaerean@adobe.com>
1754
1755         [CSSRegions] when WebKit uses V8, there should be a single variable to store if the CSS Regions feature is enabled
1756         https://bugs.webkit.org/show_bug.cgi?id=101192
1757
1758         Reviewed by Hajime Morita.
1759
1760         Removed the CSS Regions flag in Settings and switched to using the new flag I have added in RuntimeEnabledFeatures.
1761
1762         Tests: No new tests because there is no functional change.
1763
1764         * DumpRenderTree/chromium/WebPreferences.cpp:
1765         (WebPreferences::applyTo):
1766
1767 2012-11-29  Rafael Weinstein  <rafaelw@chromium.org>
1768
1769         [HTMLTemplateElement] Add feature flag
1770         https://bugs.webkit.org/show_bug.cgi?id=103694
1771
1772         Reviewed by Adam Barth.
1773
1774         This flag will guard the implementation of the HTMLTemplateElement.
1775         http://dvcs.w3.org/hg/webcomponents/raw-file/tip/spec/templates/index.html
1776
1777         * Scripts/webkitperl/FeatureList.pm:
1778
1779 2012-11-29  Dirk Pranke  <dpranke@chromium.org>
1780
1781         Ignore errors when removing directories on win32 during autoinstall
1782         https://bugs.webkit.org/show_bug.cgi?id=103699
1783
1784         Unreviewed, build fix.
1785
1786         I think this will work on win32; if not, I'll have to actually
1787         reproduce this :). The problem is that the logilab files
1788         appear to contain a write-protected file, and deleting those
1789         is problematic on windows.
1790
1791         * Scripts/webkitpy/common/system/autoinstall.py:
1792         (AutoInstaller._install):
1793         (AutoInstaller.install):
1794
1795 2012-11-29  Dirk Pranke  <dpranke@chromium.org>
1796
1797         webkitpy: autoinstaller is failing on windows
1798         https://bugs.webkit.org/show_bug.cgi?id=103699
1799
1800         Unreviewed, build fix.
1801
1802         We're attempting to create directories with forward slashes in them;
1803         this is a no-no on windows.
1804
1805         * Scripts/webkitpy/common/system/autoinstall.py:
1806         (AutoInstaller._create_scratch_directory_inner):
1807
1808 2012-11-29  Dirk Pranke  <dpranke@chromium.org>
1809
1810         Fix python unit tests after r136158 (android port tests failing)
1811         https://bugs.webkit.org/show_bug.cgi?id=103581
1812
1813         Unreviewed, build fix.
1814
1815         The unit tests apparently weren't ran for this patch; we failed
1816         to update the mock executive calls out to adb to determine various
1817         aspects of the environment, and were failing to create drivers.
1818
1819         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
1820         (MockRunCommand.mock_run_command_fn):
1821
1822 2012-11-29  Sheriff Bot  <webkit.review.bot@gmail.com>
1823
1824         Unreviewed, rolling out r136175 and r136177.
1825         http://trac.webkit.org/changeset/136175
1826         http://trac.webkit.org/changeset/136177
1827         https://bugs.webkit.org/show_bug.cgi?id=103683
1828
1829         Changes did not correct Windows build. (Requested by bfulgham
1830         on #webkit).
1831
1832         * TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp:
1833
1834 2012-11-29  Brent Fulgham  <bfulgham@webkit.org>
1835
1836         [Windows, WinCairo] Unreviewed build correction. Correct debug
1837         build case on build machine.
1838
1839         * TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp:
1840
1841 2012-11-29  Brent Fulgham  <bfulgham@webkit.org>
1842
1843         [Windows, WinCairo] Unreviewed build correction. Hide the
1844         unexported 'notSolidColor' symbol when testing against
1845         the BitmapImage class to avoid having to deal with a
1846         debug-only symbol in the Windows export definition file.
1847
1848         * TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp: 
1849
1850 2012-11-29  Peter Beverloo  <peter@chromium.org>
1851
1852         run-perf-tests --chromium-android should not require adb in my path
1853         https://bugs.webkit.org/show_bug.cgi?id=103581
1854
1855         Reviewed by Eric Seidel.
1856
1857         Remove the need to have "adb" available in the path for Layout and Performance
1858         tests. We'll determine the versions of the "adb" version in path (if any) and
1859         the one provided in the Chromium Android checkout. Unless the "adb" available
1860         in the path is newer, the provided version will be used.
1861
1862         Some other minor nits addressed:
1863         - The path_to_forwarder/path_to_md5sum should not be in the "private overrides"
1864           section, as they're not overriding anything and are used by the driver.
1865         - Make _restart_adb_as_root slightly more robust by waiting for the device
1866           to come back online regardless of the output.
1867
1868         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1869         (ChromiumAndroidPort.__init__):
1870         (ChromiumAndroidPort.check_build):
1871         (ChromiumAndroidPort.path_to_adb):
1872         (ChromiumAndroidPort):
1873         (ChromiumAndroidPort.path_to_forwarder):
1874         (ChromiumAndroidPort.path_to_md5sum):
1875         (ChromiumAndroidPort._path_to_helper):
1876         (ChromiumAndroidPort._determine_adb_version):
1877         (ChromiumAndroidPort._get_devices):
1878         (ChromiumAndroidDriver.__init__):
1879         (ChromiumAndroidDriver._setup_md5sum_and_push_data_if_needed):
1880         (ChromiumAndroidDriver._push_executable):
1881         (ChromiumAndroidDriver._restart_adb_as_root):
1882
1883 2012-11-29  Martin Robinson  <mrobinson@igalia.com>
1884
1885         [GTK] [WebKit2] Embed the HTTP authentication dialog into the WebView
1886         https://bugs.webkit.org/show_bug.cgi?id=103277
1887
1888         Reviewed by Carlos Garcia Campos.
1889
1890         Skip the new WebKit2GtkAuthenticationDialog files so that they are not processed
1891         during gtkdoc generation.
1892
1893         * gtk/generate-gtkdoc:
1894         (get_webkit2_options):
1895
1896 2012-11-29  Eric Seidel  <eric@webkit.org>
1897
1898         run-perf-tests --chromium-android fails due to Skia INFO logging
1899         https://bugs.webkit.org/show_bug.cgi?id=103585
1900
1901         Reviewed by Adam Barth.
1902
1903         Ignore all INFO logging from Chromium code.
1904         Also added some basic testing of the ignored-stderr lines code.
1905
1906         * Scripts/webkitpy/performance_tests/perftest.py:
1907         (PerfTest):
1908         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
1909         (MainTest.test_ignored_stderr_lines):
1910
1911 2012-11-29  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
1912
1913         [EFL][WK2] Add support for PlatformWebView::simulateMouseMove() in TestWebKitAPI
1914         https://bugs.webkit.org/show_bug.cgi?id=103252
1915
1916         Reviewed by Kenneth Rohde Christiansen.
1917
1918         Add support for PlatformWebView::simulateMouseMove() and enable
1919         WebKit2 API test MouseMoveAfterCrash.
1920
1921         * TestWebKitAPI/PlatformEfl.cmake: Enable MouseMoveAfterCrash API
1922         test.
1923         * TestWebKitAPI/efl/PlatformWebView.cpp:
1924         (TestWebKitAPI::onWebProcessCrashed): Handle 'webprocess,crashed' signal
1925         to prevent loading an error page since the test case is reloading actual
1926         page after web process has terminated and recovered.
1927         (TestWebKitAPI):
1928         (TestWebKitAPI::PlatformWebView::PlatformWebView):
1929         (TestWebKitAPI::PlatformWebView::simulateMouseMove): Implemented.
1930
1931 2012-11-29  Andras Becsi  <andras.becsi@digia.com>
1932
1933         [Qt] Fix installation of QtWebProcess binary
1934         https://bugs.webkit.org/show_bug.cgi?id=101735
1935
1936         Reviewed by Simon Hausmann.
1937
1938         Add config test to detect the availability of support
1939         for "program executables" in Qt (libexec).
1940
1941         This test can be removed after the Qt5 release.
1942
1943         * Tools.pro:
1944         * qmake/mkspecs/features/features.prf:
1945         * qmake/config.tests/libexecdir/libexecdir.cpp:
1946         * qmake/config.tests/libexecdir/libexecdir.pro:
1947
1948 2012-11-29  Eric Seidel  <eric@webkit.org>
1949
1950         run-perf-tests does not work when the layout test directory does not exist
1951         https://bugs.webkit.org/show_bug.cgi?id=103572
1952
1953         Reviewed by Ryosuke Niwa.
1954
1955         Make sure that Profiler() calls maybe_make_directory for the output_dir
1956         before ever using it.  It's a little awkward to create the directory
1957         from the constructor, but its simplest that way as the various subclasses
1958         all use the directory at different times.
1959
1960         Since this required having a filesystem in Profiler (and I didn't want
1961         to grab inside Workspace to get one), I just made Profiler expect a
1962         SystemHost instead of a separate filesystem, executive and workspace.
1963
1964         * Scripts/webkitpy/common/system/profiler.py:
1965         (ProfilerFactory.create_profiler):
1966         (Profiler.__init__):
1967         (SingleFileOutputProfiler.__init__):
1968         (GooglePProf.__init__):
1969         (GooglePProf.profile_after_exit):
1970         (Instruments.__init__):
1971         (Instruments.attach_to_pid):
1972         * Scripts/webkitpy/common/system/profiler_unittest.py:
1973         (ProfilerFactoryTest.test_basic):
1974
1975 2012-11-28  Vivek Galatage  <vivek.vg@samsung.com>
1976
1977         Adding secondary email id
1978         https://bugs.webkit.org/show_bug.cgi?id=103594
1979
1980         Unreviewed. Adding secondary email.
1981
1982         * Scripts/webkitpy/common/config/committers.py:
1983
1984 2012-11-28  Kent Tamura  <tkent@chromium.org>
1985
1986         garden-o-matic: Use indeterminate <progress> in the status area
1987         https://bugs.webkit.org/show_bug.cgi?id=103494
1988
1989         Reviewed by Adam Barth.
1990
1991         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
1992         Wrap the "Processing..." message with an indeterminate progress bar.
1993         We keep the message as a fallback content.
1994         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
1995         Follow the above change.
1996
1997 2012-11-28  Nima Ghanavatian  <nghanavatian@rim.com>
1998
1999         Adding Nima Ghanavatian to committers.py
2000         https://bugs.webkit.org/show_bug.cgi?id=103533
2001
2002         Reviewed by Rob Buis.
2003
2004         Adding myself to committers.py as a Committer.
2005
2006         * Scripts/webkitpy/common/config/committers.py:
2007
2008 2012-11-28  peavo@outlook.com  <peavo@outlook.com>
2009
2010         [WinCairo] Crash when requesting favicon.
2011         https://bugs.webkit.org/show_bug.cgi?id=102689
2012
2013         Reviewed by Brent Fulgham.
2014
2015         * TestWebKitAPI/Tests/WebCore/win: Added.
2016         * TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp: Added.
2017         (TestWebKitAPI::BitmapImageTest::BitmapImageTest): Allocate frame in constructor.
2018         (TestWebKitAPI::BitmapImageTest::frameCount): Override frameCount() method.
2019         (TestWebKitAPI::TEST): Added new test.
2020         * TestWebKitAPI/config.h: Make sure defines are correct for WinCairo.
2021        * TestWebKitAPI/win/TestWebKitAPI.vcproj: Added new test.
2022
2023 2012-11-28  Eric Seidel  <eric@webkit.org>
2024
2025         run-perf-tests should have a --profile option for easy profiling
2026         https://bugs.webkit.org/show_bug.cgi?id=99517
2027
2028         Reviewed by Adam Barth.
2029
2030         This is a very basic implementation which works on Mac and Linux
2031         and makes it trivial for anyone to profile a PerformanceTest.
2032
2033         Currently it's not "hard" to profile a PerformanceTest
2034         but lowering the barriers to entry here allows all of us to focus
2035         less on the tools and more on the code.
2036
2037         This also paves the way for adding easy mobile-profiling (e.g. chromium-android)
2038         which is actually "hard", and this option will make much easier.
2039
2040         * Scripts/webkitpy/common/system/profiler.py: Added.
2041         (ProfilerFactory):
2042         (ProfilerFactory.create_profiler):
2043         (Profiler):
2044         (Profiler.__init__):
2045         (Profiler.adjusted_environment):
2046         (Profiler.attach_to_pid):
2047         (Profiler.did_stop):
2048         (SingleFileOutputProfiler):
2049         (SingleFileOutputProfiler.__init__):
2050         (GooglePProf):
2051         (GooglePProf.__init__):
2052         (GooglePProf.adjusted_environment):
2053         (GooglePProf.did_stop):
2054         (Instruments):
2055         (Instruments.__init__):
2056         (Instruments.attach_to_pid):
2057         * Scripts/webkitpy/common/system/profiler_unittest.py: Added.
2058         (ProfilerFactoryTest):
2059         (ProfilerFactoryTest.test_basic):
2060         * Scripts/webkitpy/layout_tests/port/driver.py:
2061         (Driver.__init__):
2062         (Driver._start):
2063         (Driver.stop):
2064         (Driver.cmd_line):
2065         * Scripts/webkitpy/performance_tests/perftest.py:
2066         (PerfTest.parse_output):
2067         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
2068         (MainTest.test_parse_output):
2069         (MainTest.test_parse_output_with_failing_line):
2070         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2071         (PerfTestsRunner._parse_args):
2072         (PerfTestsRunner.run):
2073
2074 2012-11-28  Zan Dobersek  <zandobersek@gmail.com>
2075
2076         Remove deprecated logging usage from QueueEngine
2077         https://bugs.webkit.org/show_bug.cgi?id=103532
2078
2079         Reviewed by Dirk Pranke.
2080
2081         Replace usage of deprecated logging in webkitpy.tool.bot.queueengine with
2082         logging through the Logger object. The unit test is modified to reflect
2083         these changes.
2084
2085         After these changes the deprecated logging (i.e. logging to stderr) is not
2086         used anymore through webkitpy and can be removed.
2087
2088         * Scripts/webkitpy/tool/bot/queueengine.py:
2089         (QueueEngine.exit_after_handled_error):
2090         (QueueEngine.run):
2091         (QueueEngine._stopping):
2092         (QueueEngine._sleep):
2093         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
2094         (QueueEngineTest._run_engine):
2095
2096 2012-11-28  Nate Chapin  <japhet@chromium.org>
2097
2098         Move empty loading to DocumentLoader, simplify FrameLoader::init()
2099         https://bugs.webkit.org/show_bug.cgi?id=101512
2100
2101         Reviewed by Adam Barth.
2102
2103         * DumpRenderTree/chromium/WebViewHost.cpp:
2104         (WebViewHost::updateForCommittedLoad): This function doesn't play nicely with empty urls and incorrectly
2105             interprets them as a non-empty load. This change is required for
2106              http/tests/navigation/new-window-redirect-history.html to continue to pass in chromium.
2107         * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp: This test relies on a callback that no longer
2108              is sent for about:blank loads.  Hook into didFinishLoadForFrame() instead.
2109         (TestWebKitAPI::didFinishLoadForFrame):
2110         (TestWebKitAPI::TEST):
2111
2112 2012-11-28  Sadrul Habib Chowdhury  <sadrul@chromium.org>
2113
2114         [chromium] Allow plugins to opt-in to receive synthetic mouse events out of touch events.
2115         https://bugs.webkit.org/show_bug.cgi?id=103092
2116
2117         Reviewed by Tony Chang.
2118
2119         Update the test web-plugin to be able to opt-in to receive synthesized mouse events created
2120         from touch events.
2121
2122         * DumpRenderTree/chromium/TestWebPlugin.cpp:
2123         (parseTouchEventRequestType):
2124         (TestWebPlugin::TestWebPlugin):
2125         (TestWebPlugin::initialize):
2126         * DumpRenderTree/chromium/TestWebPlugin.h:
2127         (TestWebPlugin):
2128
2129 2012-11-28  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
2130
2131         [EFL][WK2] Add support for PlatformWebView::simulateSpacebarKeyPress() in TestWebKitAPI
2132         https://bugs.webkit.org/show_bug.cgi?id=103123
2133
2134         Reviewed by Laszlo Gombos.
2135
2136         Add support for PlatformWebView::simulateSpacebarKeyPress().
2137         This functionality is needed by WebKit2 API test MouseMoveAfterCrash
2138         which is going to be unskipped in bug #103252.
2139
2140         * TestWebKitAPI/efl/PlatformUtilities.cpp:
2141         (TestWebKitAPI::Util::sleep):
2142         * TestWebKitAPI/efl/PlatformWebView.cpp: Use usleep() instead of
2143         sleep().
2144         (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress):
2145         (TestWebKitAPI):
2146
2147 2012-11-28  Yael Aharon  <yael.aharon@intel.com>
2148
2149         Minor cleanup in TestInvocation
2150         https://bugs.webkit.org/show_bug.cgi?id=103512
2151
2152         Reviewed by Kenneth Rohde Christiansen.
2153
2154         Remove a function declaration that is not defined and not used.
2155         Fix spelling error in m_webProcessIsUnresponsive.
2156
2157         * WebKitTestRunner/TestInvocation.cpp:
2158         (WTR::TestInvocation::TestInvocation):
2159         (WTR::TestInvocation::invoke):
2160         * WebKitTestRunner/TestInvocation.h:
2161         (TestInvocation):
2162         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
2163         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
2164         * WebKitTestRunner/qt/TestInvocationQt.cpp:
2165         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
2166
2167 2012-11-28  Thiago Marcos P. Santos  <thiago.santos@intel.com>
2168
2169         Unreviewed. Use my personal email as bugzilla email.
2170
2171         * Scripts/webkitpy/common/config/committers.py:
2172
2173 2012-11-28  Thiago Marcos P. Santos  <thiago.santos@intel.com>
2174
2175         Unreviewed. Adding myself to committers.py.
2176
2177         * Scripts/webkitpy/common/config/committers.py:
2178
2179 2012-11-26  Andrey Adaikin  <aandrey@chromium.org>
2180
2181         Unreviewed. Adding myself to committers.py.
2182
2183         * Scripts/webkitpy/common/config/committers.py:
2184
2185 2012-11-28  Tommy Widenflycht  <tommyw@google.com>
2186
2187         Add basic implementation for MediaStreamAudioDestinationNode
2188         https://bugs.webkit.org/show_bug.cgi?id=101815
2189
2190         Reviewed by Chris Rogers.
2191
2192         Adds a bit of code that exercises the WebKit API.
2193
2194         * DumpRenderTree/chromium/MockWebMediaStreamCenter.cpp:
2195         (MockWebMediaStreamSourceConsumer):
2196         (MockWebMediaStreamSourceConsumer::~MockWebMediaStreamSourceConsumer):
2197         (MockWebMediaStreamCenter::didCreateMediaStream):
2198
2199 2012-11-28  Matt Falkenhagen  <falken@chromium.org>
2200
2201         Unreviewed. Adding myself to committers list.
2202
2203         * Scripts/webkitpy/common/config/committers.py:
2204
2205 2012-11-27  Li Yin  <li.yin@intel.com>
2206
2207         Unreviewed. Adding myself to committers list.
2208
2209         * Scripts/webkitpy/common/config/committers.py:
2210
2211 2012-11-27  Christophe Dumez  <christophe.dumez@intel.com>
2212
2213         Unreviewed. Adding myself to committers.py.
2214
2215         * Scripts/webkitpy/common/config/committers.py:
2216
2217 2012-11-27  Vivek Galatage  <vivek.vg@samsung.com>
2218
2219         Unreviewd. Adding myself to committers list.
2220
2221         * Scripts/webkitpy/common/config/committers.py:
2222
2223 2012-11-27  Tony Chang  <tony@chromium.org>
2224
2225         Bring back partytime!
2226         https://bugs.webkit.org/show_bug.cgi?id=103466
2227
2228         Reviewed by Adam Barth.
2229
2230         "code 404, message Unknown function images/partytime_gif" since we didn't
2231         allow .gif or .png files to be served.
2232
2233         * Scripts/webkitpy/tool/servers/gardeningserver.py:
2234         (GardeningHTTPRequestHandler):
2235
2236 2012-11-27  Adam Barth  <abarth@webkit.org>
2237
2238         run-perf-tests fails on Android because of stderr output
2239         https://bugs.webkit.org/show_bug.cgi?id=103462
2240
2241         Reviewed by Ryosuke Niwa.
2242
2243         The chromium-android port produces some stderr output that causes
2244         run-perf-tests to get sad and not record the results of the performance
2245         test. This patch teaches run-perf-test to ignore this output much in
2246         the same way that it currently ignores some stdout messages.
2247
2248         * Scripts/webkitpy/performance_tests/perftest.py:
2249         (PerfTest.run):
2250         (PerfTest._should_ignore_line):
2251         (PerfTest):
2252         (PerfTest._should_ignore_line_in_stderr):
2253         (PerfTest._filter_stderr):
2254         (PerfTest._should_ignore_line_in_parser_test_result):
2255
2256 2012-11-27  Tony Chang  <tony@chromium.org>
2257
2258         Fix garden-o-matic for non-chromium ports
2259         https://bugs.webkit.org/show_bug.cgi?id=103458
2260
2261         Reviewed by Adam Barth.
2262
2263         I was getting a 403 error when trying to select any non-chromium port.
2264
2265         * Scripts/webkitpy/tool/servers/reflectionhandler.py:
2266         (ReflectionHandler._handle_request): Use the path without query params.
2267
2268 2012-11-27  Yael Aharon  <yael.aharon@intel.com>
2269
2270         [EFL][WK2] 3D pixel tests are failing
2271         https://bugs.webkit.org/show_bug.cgi?id=102833
2272
2273         Reviewed by Kenneth Rohde Christiansen.
2274
2275         Generate a snapshot of the view in the UI process instead of the web process.
2276         We have to use Texture Mapper in order to correctly paint 3D transforms etc.
2277
2278         * WebKitTestRunner/TestInvocation.h:
2279         (TestInvocation):
2280         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
2281         (WTR::writeFunction):
2282         (WTR::paintRepaintRectOverlay):
2283         (WTR):
2284         (WTR::TestInvocation::forceRepaintDoneCallback):
2285         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
2286         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2287         (WTR::PlatformWebView::windowSnapshotImage):
2288
2289 2012-11-27  Adam Barth  <abarth@webkit.org>
2290
2291         Make it possible to run performance tests on Chromium Android
2292         https://bugs.webkit.org/show_bug.cgi?id=103268
2293
2294         Reviewed by Ryosuke Niwa.
2295
2296         Based on a patch by Peter Beverloo.
2297
2298         This patch (almost) makes it possible to run WebKit performance tests
2299         on the Chromium port for Android. There are a few things I had to do
2300         in order to make this happen:
2301
2302         1) The worker number when creating a driver for a port is zero-based
2303            for layout tests and elsewhere. Android uses this to determine
2304            which device it has to run on, so make it zero based for performance
2305            tests as well.
2306
2307         2) Tests aren't available on the Android device, so we start an HTTP
2308            server that serves the tests to the device or emulator.
2309
2310         The one shortcoming of this patch is that chromium-android produces
2311         some stderr output that confuses run-perf-tests. I'll address that
2312         issue in a subsequent CL. This patch also depends on
2313         https://codereview.chromium.org/11416182 in order to work.
2314
2315         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2316         (ChromiumAndroidPort.start_http_server):
2317         (ChromiumAndroidDriver._command_from_driver_input):
2318         * Scripts/webkitpy/performance_tests/perftest.py:
2319         (ReplayPerfTest.prepare):
2320         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2321         (PerfTestsRunner.__init__):
2322         (PerfTestsRunner._parse_args):
2323         (PerfTestsRunner._start_servers):
2324         (PerfTestsRunner):
2325         (PerfTestsRunner._stop_servers):
2326         (PerfTestsRunner.run):
2327         (PerfTestsRunner._run_tests_set):
2328
2329 2012-11-27  Zan Dobersek  <zandobersek@gmail.com>
2330
2331         Remove use of deprecated logging from webkitpy.common and webkitpy.layout_tests
2332         https://bugs.webkit.org/show_bug.cgi?id=103408
2333
2334         Reviewed by Dirk Pranke.
2335
2336         Remove the use of the deprecated log and error methods by replacing them with
2337         logging through Python's logging.Logger objects.
2338
2339         This patch covers such changes in webkitpy.common and webkitpy.layout_tests and also
2340         updates any affected unit test.
2341
2342         * Scripts/webkitpy/common/checkout/changelog.py:
2343         (ChangeLogEntry._parse_entry):
2344         * Scripts/webkitpy/common/checkout/checkout.py:
2345         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
2346         (CheckoutTest.test_apply_patch):
2347         * Scripts/webkitpy/common/checkout/deps_mock.py:
2348         (MockDEPS.write_variable):
2349         * Scripts/webkitpy/common/checkout/scm/detection.py:
2350         (SCMDetector.default_scm):
2351         * Scripts/webkitpy/common/checkout/scm/detection_unittest.py:
2352         (SCMDetectorTest.test_detect_scm_system):
2353         * Scripts/webkitpy/common/checkout/scm/git.py:
2354         (Git._check_git_architecture):
2355         (Git._commit_on_branch):
2356         * Scripts/webkitpy/common/checkout/scm/scm.py:
2357         (SCM.ensure_clean_working_directory):
2358         (SCM.ensure_no_local_commits):
2359         (SCM.will.commit_locally_with_message):
2360         * Scripts/webkitpy/common/checkout/scm/svn.py:
2361         (SVN.apply_reverse_diff):
2362         * Scripts/webkitpy/common/net/bugzilla/attachment.py:
2363         (Attachment._validate_flag_value):
2364         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2365         (Bugzilla._fetch_bug_page):
2366         (Bugzilla.bug_id_for_attachment_id):
2367         (Bugzilla.authenticate):
2368         (Bugzilla._commit_queue_flag):
2369         (Bugzilla.add_attachment_to_bug):
2370         (Bugzilla.add_patch_to_bug):
2371         (Bugzilla.create_bug):
2372         (Bugzilla.clear_attachment_flags):
2373         (Bugzilla.set_flag_on_attachment):
2374         (Bugzilla.obsolete_attachment):
2375         (Bugzilla.add_cc_to_bug):
2376         (Bugzilla.post_comment_to_bug):
2377         (Bugzilla.close_bug_as_fixed):
2378         (Bugzilla.reassign_bug):
2379         (reopen_bug):
2380         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
2381         (MockBugzilla.create_bug):
2382         (MockBugzilla.reassign_bug):
2383         (MockBugzilla.set_flag_on_attachment):
2384         (MockBugzilla.post_comment_to_bug):
2385         (MockBugzilla.add_attachment_to_bug):
2386         (MockBugzilla.add_patch_to_bug):
2387         (MockBugzilla.reopen_bug):
2388         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
2389         (test_add_cc_to_bug):
2390         (_assert_reopen):
2391         (test_reopen_bug):
2392         * Scripts/webkitpy/common/net/buildbot/buildbot_mock.py:
2393         (MockBuilder.force_build):
2394         * Scripts/webkitpy/common/net/credentials.py:
2395         (Credentials._run_security_tool):
2396         * Scripts/webkitpy/common/net/credentials_unittest.py:
2397         (_assert_security_call):
2398         * Scripts/webkitpy/common/net/irc/irc_mock.py:
2399         (MockIRC.post):
2400         (MockIRC.disconnect):
2401         * Scripts/webkitpy/common/net/irc/ircproxy.py:
2402         (IRCProxy.__init__):
2403         (IRCProxy.disconnect):
2404         * Scripts/webkitpy/common/net/irc/ircproxy_unittest.py:
2405         (IRCProxyTest.test_trivial):
2406         * Scripts/webkitpy/common/net/layouttestresults.py:
2407         (ORWTResultsHTMLParser._failures_from_fail_row):
2408         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2409         (test_failures_from_fail_row):
2410         * Scripts/webkitpy/common/net/networktransaction.py:
2411         * Scripts/webkitpy/common/net/resultsjsonparser.py:
2412         (JSONTestResult._tokenize):
2413         (JSONTestResult._failure_types_from_actual_result):
2414         * Scripts/webkitpy/common/net/statusserver.py:
2415         (StatusServer.update_status):
2416         (StatusServer.update_svn_revision):
2417         * Scripts/webkitpy/common/net/statusserver_mock.py:
2418         (MockStatusServer.release_work_item):
2419         (MockStatusServer.update_work_items):
2420         (MockStatusServer.submit_to_ews):
2421         (MockStatusServer.update_status):
2422         * Scripts/webkitpy/common/net/unittestresults.py:
2423         (UnitTestResults.results_from_string):
2424         * Scripts/webkitpy/common/system/executive_mock.py:
2425         (MockExecutive.running_pids):
2426         (MockExecutive.run_and_throw_if_fail):
2427         (MockExecutive.run_command):
2428         (MockExecutive.popen):
2429         * Scripts/webkitpy/common/system/user_mock.py:
2430         (MockUser.confirm):
2431         (MockUser.open_url):
2432         * Scripts/webkitpy/common/system/workspace_unittest.py:
2433         (WorkspaceTest.test_create_zip):
2434         (WorkspaceTest.test_create_zip_exception):
2435         * Scripts/webkitpy/common/watchlist/watchlist_mock.py:
2436         (MockWatchList.determine_cc_and_messages):
2437         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
2438         (ChromiumWinTest.test_setup_environ_for_server_register_cygwin):
2439         * Scripts/webkitpy/layout_tests/port/efl_unittest.py:
2440         (EflPortTest.test_show_results_html_file):
2441         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
2442         (GtkPortTest.test_show_results_html_file):
2443         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2444         (test_show_results_html_file):
2445         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2446         (test_build_driver):
2447         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
2448         (QtPortTest.test_show_results_html_file):
2449         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
2450         (WinPortTest.test_show_results_html_file):
2451         * Scripts/webkitpy/layout_tests/port/xvfbdriver_unittest.py:
2452         (XvfbDriverTest.assertDriverStartSuccessful):
2453         (XvfbDriverTest.test_start_no_pixel_tests):
2454         (XvfbDriverTest.test_start_pixel_tests):
2455         (XvfbDriverTest.test_start_arbitrary_worker_number):
2456         (XvfbDriverTest.test_start_next_worker):
2457         (XvfbDriverTest.test_stop):
2458         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
2459         (TestLayoutTestApacheHttpd.test_start_cmd):
2460         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2461         (test_run_test_pause_before_testing):
2462         (test_run_memory_test):
2463         (_test_run_with_json_output):
2464         (test_run_respects_no_results):
2465         (test_run_generates_and_show_results_page):
2466         (test_run_respects_no_show_results):
2467         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
2468         (FeedersTest.test_commit_queue_feeder):
2469         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2470         (FlakyTestReporterTest.test_create_bug_for_flaky_test):
2471         (test_report_flaky_tests_creating_bug):
2472         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2473         (IRCCommandTest.test_rollout_updates_working_copy):
2474         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
2475         (IRCBotTest.test_exception_during_command):
2476         (IRCBotTest.test_hi):
2477         (IRCBotTest.test_help):
2478         (IRCBotTest.test_restart):
2479         (IRCBotTest.test_rollout):
2480         (IRCBotTest.test_revert):
2481         (IRCBotTest.test_roll_chromium_deps):
2482         (IRCBotTest.test_roll_chromium_deps_to_lkgr):
2483         (IRCBotTest.test_multi_rollout):
2484         (IRCBotTest.test_rollout_with_r_in_svn_revision):
2485         (IRCBotTest.test_multi_rollout_with_r_in_svn_revision):
2486         (IRCBotTest.test_rollout_bananas):
2487         (IRCBotTest.test_rollout_invalidate_revision):
2488         (IRCBotTest.test_rollout_invalidate_reason):
2489         (test_multi_rollout_invalidate_reason):
2490         (test_rollout_no_reason):
2491         (test_multi_rollout_no_reason):
2492         * Scripts/webkitpy/tool/bot/sheriff_unittest.py:
2493         (SheriffTest.test_post_blame_comment_on_bug):
2494         * Scripts/webkitpy/tool/commands/applywatchlistlocal_unittest.py:
2495         (ApplyWatchListLocalTest.test_args_parsing):
2496         (test_args_parsing_with_bug):
2497         * Scripts/webkitpy/tool/commands/download_unittest.py:
2498         (test_land_cowboy):
2499         (test_check_style):
2500         (test_create_rollout):
2501         (test_create_rollout_resolved):
2502         (test_rollout):
2503         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2504         (AbstractEarlyWarningSystemTest.test_failing_tests_message):
2505         (EarlyWarningSytemTest._default_expected_logs):
2506         (EarlyWarningSytemTest._test_builder_ews):
2507         (EarlyWarningSytemTest._test_testing_ews):
2508         * Scripts/webkitpy/tool/commands/openbugs_unittest.py:
2509         (OpenBugsTest.test_args_parsing):
2510         * Scripts/webkitpy/tool/commands/queries_unittest.py:
2511         (QueryCommandsTest.test_bugs_to_commit):
2512         (QueryCommandsTest.test_patches_in_commit_queue):
2513         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2514         (FeederQueueTest.test_feeder_queue):
2515         (AbstractPatchQueueTest.test_next_patch):
2516         (AbstractPatchQueueTest.test_upload_results_archive_for_patch):
2517         (CommitQueueTest.test_commit_queue):
2518         (test_commit_queue_failure):
2519         (test_commit_queue_failure_with_failing_tests):
2520         (test_rollout):
2521         (test_rollout_lands):
2522         (test_auto_retry):
2523         (test_manual_reject_during_processing):
2524         (test_report_flaky_tests):
2525         (StyleQueueTest.test_style_queue_with_style_exception):
2526         (test_style_queue_with_watch_list_exception):
2527         * Scripts/webkitpy/tool/commands/queuestest.py:
2528         (QueuesTest._default_begin_work_queue_logs):
2529         * Scripts/webkitpy/tool/commands/roll_unittest.py:
2530         (RollCommandsTest.test_update_chromium_deps):
2531         * Scripts/webkitpy/tool/commands/upload_unittest.py:
2532         (UploadCommandsTest.test_assign_to_committer):
2533         (test_post):
2534         (test_attach_to_bug):
2535         (test_attach_to_bug_no_description_or_comment):
2536         (test_land_safely):
2537         (test_prepare):
2538         (test_upload):
2539         (test_mark_bug_fixed):
2540         * Scripts/webkitpy/tool/steps/applywatchlist_unittest.py:
2541         (ApplyWatchListTest.test_apply_watch_list_local):
2542         * Scripts/webkitpy/tool/steps/commit_unittest.py:
2543         (CommitTest._test_check_test_expectations):
2544         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
2545         (RunTestsTest.test_webkit_run_unit_tests):
2546         * Scripts/webkitpy/tool/steps/steps_unittest.py:
2547         (StepsTest._assert_step_output_with_bug):
2548         (StepsTest._assert_post_diff_output_for_bug):
2549         (StepsTest.test_post_diff):
2550         (StepsTest.test_post_diff_for_commit):
2551         (StepsTest.test_ensure_bug_is_open_and_assigned):
2552         (StepsTest.test_runtests_args):
2553         * Scripts/webkitpy/tool/steps/suggestreviewers_unittest.py:
2554         (SuggestReviewersTest.test_basic):
2555         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
2556         (ValidateChangeLogsTest._assert_start_line_produces_output):
2557
2558 2012-11-27  Pratik Solanki  <psolanki@apple.com>
2559
2560         objc/objc-runtime.h does not exist on all PLATFORM(MAC)
2561         https://bugs.webkit.org/show_bug.cgi?id=101780
2562
2563         Reviewed by Brent Fulgham.
2564
2565         Clean up header includes so we don't include objc/objc-runtime.h.
2566
2567         * DumpRenderTree/mac/DumpRenderTree.mm:
2568         * DumpRenderTree/mac/ObjCPlugin.m:
2569         * TestWebKitAPI/mac/InstanceMethodSwizzler.h:
2570         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
2571
2572 2012-11-27  Marja Hölttä  <marja@chromium.org>
2573
2574         Add callbacks to the FrameLoaderClient when a resource is requested
2575         https://bugs.webkit.org/show_bug.cgi?id=92761
2576
2577         Reviewed by Adam Barth.
2578
2579         In Chromium, when an extension script cancels a network
2580         request (which happens out of process), we'd like to
2581         notify content scripts running on the current page about
2582         which elements failed to load because the requests were
2583         cancelled (as opposed to e.g. the network request just
2584         didn't work). Since the resource request itself does not
2585         carry any information what DOM element is was made for,
2586         currently a content script has to search the DOM tree and
2587         guess which requests will be cancelled by its counter
2588         part. By adding these callbacks, the embedder can make
2589         this connection explictly.
2590
2591         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2592         (DRTTestRunner::DRTTestRunner):
2593         (DRTTestRunner::dumpResourceRequestCallbacks):
2594         (DRTTestRunner::reset):
2595         * DumpRenderTree/chromium/DRTTestRunner.h:
2596         (DRTTestRunner):
2597         (DRTTestRunner::setShouldDumpResourceRequestCallbacks):
2598         (DRTTestRunner::shouldDumpResourceRequestCallbacks):
2599         * DumpRenderTree/chromium/TestShell.h:
2600         (TestShell::shouldDumpResourceRequestCallbacks):
2601         * DumpRenderTree/chromium/WebViewHost.cpp:
2602         (WebViewHost::willRequestResource):
2603         * DumpRenderTree/chromium/WebViewHost.h:
2604         (WebViewHost):
2605
2606 2012-11-27  Víctor Manuel Jáquez Leal  <vjaquez@igalia.com>
2607
2608         [GStreamer] Verify if GStreamer was previously initialized
2609         https://bugs.webkit.org/show_bug.cgi?id=103151
2610
2611         Reviewed by Philippe Normand.
2612
2613         This patch adds the gst_init() in GtkLauncher, so we can add the
2614         GStreamer options in the command line through
2615         gst_init_get_option_group().
2616
2617         This approach is not valid for MiniBrowser because it uses WebKit2,
2618         where the GStreamer backend lives in the web process, which is
2619         different from the UI process.
2620
2621         * GNUmakefile.am:
2622         * GtkLauncher/main.c:
2623         (main):
2624
2625 2012-11-27  Andras Becsi  <andras.becsi@digia.com>
2626
2627         [Qt] Fix the build with new Qt5 hash
2628         https://bugs.webkit.org/show_bug.cgi?id=103406
2629
2630         Reviewed by Csaba Osztrogonác.
2631
2632         Remove references to deprecated QApplication::GuiServer which
2633         has been removed, and use QStyleFactory::create instead of
2634         instantiating a QWindowsStyle directly since it is about to
2635         become an internal class.
2636
2637         * DumpRenderTree/qt/DumpRenderTreeMain.cpp:
2638         (main):
2639         * QtTestBrowser/qttestbrowser.cpp:
2640         (LauncherApplication::LauncherApplication):
2641         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
2642         (WTR::InjectedBundle::platformInitialize):
2643
2644 2012-11-27  Sadrul Habib Chowdhury  <sadrul@chromium.org>
2645
2646         [style] Add a style-check for enum-member names
2647         https://bugs.webkit.org/show_bug.cgi?id=103157
2648
2649         Reviewed by Daniel Bates.
2650
2651         * Scripts/webkitpy/style/checkers/cpp.py:
2652         (_EnumState):
2653         (_EnumState.__init__):
2654         (_EnumState.process_clean_line):
2655         (check_enum_casing):
2656         (check_style):
2657         (process_line):
2658         (_process_lines):
2659         (CppChecker):
2660         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2661         (NoNonVirtualDestructorsTest.test_enum_casing):
2662         (NoNonVirtualDestructorsTest.test_internal_braces.Foo):
2663
2664 2012-11-26  Ryuan Choi  <ryuan.choi@gmail.com>
2665
2666         [EFL][jhbuild] Disable unnecessary options of elementary module
2667         https://bugs.webkit.org/show_bug.cgi?id=103360
2668
2669         Reviewed by Gyuyoung Kim.
2670
2671         When jhbuild configures elementary, unnecessary options may be enabled by
2672         user installed modules and it causes build break.
2673
2674         * efl/jhbuild.modules:
2675         Added --disable-emap --disable-ethumb --disable-eweather to elementary.
2676
2677 2012-11-26  Varun Jain  <varunjain@chromium.org>
2678
2679         LongPress and LongTap gestures should start drag/drop and open context menu respectively.
2680         https://bugs.webkit.org/show_bug.cgi?id=101545
2681
2682         Reviewed by Antonio Gomes.
2683
2684         For LongPress, we simulate drag by sending a mouse down and mouse drag
2685         events. If a drag is not started (because maybe there is no draggable
2686         element), then we show context menu instead (which is the current
2687         behavior for LongPress). For LongTap, we use the existing functions that
2688         LongPress uses to summon the context menu. LongPress initiated drag and
2689         drop can be enabled/disabled by the platform using the Setting
2690         touchDragDropEnabled which is disabled by default.
2691
2692         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
2693         (WebTestRunner):
2694         (WebTestRunner::EventSender::EventSender):
2695         (WebTestRunner::EventSender::gestureLongTap):
2696         (WebTestRunner::EventSender::gestureEvent):
2697         * DumpRenderTree/chromium/TestRunner/src/EventSender.h:
2698         (EventSender):
2699         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2700         (WebTestRunner::TestRunner::TestRunner):
2701         (WebTestRunner::TestRunner::setTouchDragDropEnabled):
2702         (WebTestRunner):
2703         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2704         (TestRunner):
2705
2706 2012-11-26  Christophe Dumez  <christophe.dumez@intel.com>
2707
2708         [EFL][WK2] Add setting to enable / disable HTML5 local storage functionality
2709         https://bugs.webkit.org/show_bug.cgi?id=103224
2710
2711         Reviewed by Laszlo Gombos.
2712
2713         Add --local-storage command line argument to MiniBrowser to
2714         explicitely disable HTML5 local storage functionality. This
2715         is useful for testing purposes.
2716
2717         * MiniBrowser/efl/main.c:
2718         (window_create):
2719         (elm_main):
2720
2721 2012-11-26  Zan Dobersek  <zandobersek@gmail.com>
2722
2723         Remove use of deprecated logging from most of webkitpy.tool
2724         https://bugs.webkit.org/show_bug.cgi?id=103180
2725
2726         Reviewed by Dirk Pranke.
2727
2728         Remove calls to log and error methods of the deprecated_logging module, replacing them
2729         by using Python's Logger objects. This patch covers the switch in all of webkitpy.tool
2730         except the QueueEngine.
2731
2732         Unit tests are adjusted for these changes, moving output from expected stderr to expected logs.
2733
2734         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2735         (MockCommitQueue.run_command):
2736         (MockCommitQueue.command_passed):
2737         (MockCommitQueue.command_failed):
2738         (MockCommitQueue.report_flaky_tests):
2739         (MockCommitQueue.archive_last_test_results):
2740         (CommitQueueTaskTest._run_through_task):
2741         (CommitQueueTaskTest.test_success_case):
2742         (test_fast_success_case):
2743         (test_clean_failure):
2744         (test_update_failure):
2745         (test_apply_failure):
2746         (test_validate_changelog_failure):
2747         (test_build_failure):
2748         (test_red_build_failure):
2749         (test_flaky_test_failure):
2750         (test_failed_archive):
2751         (test_double_flaky_test_failure):
2752         (test_test_failure):
2753         (test_red_test_failure):
2754         (test_very_red_tree_retry):
2755         (test_red_tree_patch_rejection):
2756         (test_land_failure):
2757         * Scripts/webkitpy/tool/bot/feeders.py:
2758         (CommitQueueFeeder._update_work_items):
2759         (EWSFeeder.feed):
2760         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
2761         * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
2762         (LayoutTestResultsReader.archive):
2763         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
2764         (test_archive_last_layout_test_results):
2765         * Scripts/webkitpy/tool/bot/sheriff.py:
2766         * Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:
2767         (AbstractSequencedCommand.execute):
2768         * Scripts/webkitpy/tool/commands/commandtest.py:
2769         (CommandsTest.assert_execute_outputs):
2770         * Scripts/webkitpy/tool/commands/download.py:
2771         (AbstractPatchProcessingCommand._process_patch.execute):
2772         (ProcessBugsMixin._fetch_list_of_patches_to_process):
2773         (ProcessURLsMixin._fetch_list_of_patches_to_process):
2774         (AbstractRolloutPrepCommand._commit_info):
2775         * Scripts/webkitpy/tool/commands/download_unittest.py:
2776         (AbstractRolloutPrepCommandTest.test_commit_info):
2777         (DownloadCommandsTest.test_build):
2778         (DownloadCommandsTest.test_build_and_test):
2779         (test_apply_attachment):
2780         (test_apply_from_bug):
2781         (test_apply_watch_list):
2782         (test_land):
2783         (test_land_red_builders):
2784         (test_check_style):
2785         (test_build_attachment):
2786         (test_land_attachment):
2787         (test_land_from_bug):
2788         (test_land_from_url):
2789         (test_prepare_rollout):
2790         (test_create_rollout):
2791         (test_create_rollout_resolved):
2792         (test_rollout):
2793         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2794         (AbstractEarlyWarningSystem.handle_script_error.does):
2795         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2796         (EarlyWarningSytemTest._default_expected_stderr):
2797         (EarlyWarningSytemTest._default_expected_logs):
2798         (EarlyWarningSytemTest._test_testing_ews):
2799         * Scripts/webkitpy/tool/commands/openbugs.py:
2800         (OpenBugs.execute):
2801         * Scripts/webkitpy/tool/commands/openbugs_unittest.py:
2802         (OpenBugsTest.test_args_parsing):
2803         * Scripts/webkitpy/tool/commands/perfalizer.py:
2804         (Perfalizer.handle_unexpected_error):
2805         * Scripts/webkitpy/tool/commands/queries.py:
2806         (PatchesInCommitQueue.execute):
2807         (PatchesToCommitQueue._needs_commit_queue):
2808         * Scripts/webkitpy/tool/commands/queries_unittest.py:
2809         (QueryCommandsTest.test_bugs_to_commit):
2810         (QueryCommandsTest.test_patches_in_commit_queue):
2811         (QueryCommandsTest.test_patches_to_commit_queue):
2812         * Scripts/webkitpy/tool/commands/queues.py:
2813         (AbstractQueue._cc_watchers):
2814         (AbstractQueue.begin_work_queue):
2815         (FeederQueue.handle_unexpected_error):
2816         (CommitQueue.handle_script_error):
2817         (AbstractReviewQueue.handle_unexpected_error):
2818         (AbstractReviewQueue.handle_script_error):
2819         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2820         (test_auto_retry):
2821         * Scripts/webkitpy/tool/commands/queuestest.py:
2822         (QueuesTest.assert_outputs):
2823         (QueuesTest._default_begin_work_queue_stderr):
2824         (QueuesTest):
2825         (QueuesTest._default_begin_work_queue_logs):
2826         (QueuesTest.assert_queue_outputs):
2827         * Scripts/webkitpy/tool/commands/roll_unittest.py:
2828         (RollCommandsTest.test_update_chromium_deps):
2829         (test_update_chromium_deps_older_revision):
2830         * Scripts/webkitpy/tool/commands/sheriffbot.py:
2831         (SheriffBot.handle_unexpected_error):
2832         * Scripts/webkitpy/tool/commands/stepsequence.py:
2833         (StepSequence.run_and_handle_errors):
2834         * Scripts/webkitpy/tool/commands/upload.py:
2835         (AssignToCommitter._assign_bug_to_last_patch_attacher):
2836         (AbstractPatchUploadingCommand._prepare_state):
2837         (PostCommits.execute):
2838         (MarkBugFixed._determine_bug_id_and_svn_revision):
2839         (MarkBugFixed.execute):
2840         (CreateBug.create_bug_from_commit):
2841         (CreateBug.execute):
2842         * Scripts/webkitpy/tool/commands/upload_unittest.py:
2843         (test_obsolete_attachments):
2844         (test_land_safely):
2845         (test_mark_bug_fixed):
2846         * Scripts/webkitpy/tool/multicommandtool.py:
2847         (Command.check_arguments_and_execute):
2848         (MultiCommandTool.main):
2849         * Scripts/webkitpy/tool/multicommandtool_unittest.py:
2850         (CommandTest.test_required_arguments):
2851         * Scripts/webkitpy/tool/steps/addsvnmimetypeforpng.py:
2852         (AddSvnMimetypeForPng.run):
2853         * Scripts/webkitpy/tool/steps/applypatch.py:
2854         (ApplyPatch.run):
2855         * Scripts/webkitpy/tool/steps/build.py:
2856         (Build.run):
2857         * Scripts/webkitpy/tool/steps/checkstyle.py:
2858         * Scripts/webkitpy/tool/steps/closebug.py:
2859         (CloseBug.run):
2860         * Scripts/webkitpy/tool/steps/closebugforlanddiff.py:
2861         (CloseBugForLandDiff.run):
2862         * Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
2863         (CloseBugForLandDiffTest.test_empty_state):
2864         * Scripts/webkitpy/tool/steps/commit.py:
2865         (Commit.run):
2866         * Scripts/webkitpy/tool/steps/commit_unittest.py:
2867         (CommitTest._test_check_test_expectations):
2868         * Scripts/webkitpy/tool/steps/ensurelocalcommitifneeded.py:
2869         (EnsureLocalCommitIfNeeded.run):
2870         * Scripts/webkitpy/tool/steps/obsoletepatches.py:
2871         (ObsoletePatches.run):
2872         * Scripts/webkitpy/tool/steps/preparechangelog.py:
2873         (PrepareChangeLog.run):
2874         * Scripts/webkitpy/tool/steps/reopenbugafterrollout.py:
2875         (ReopenBugAfterRollout.run):
2876         * Scripts/webkitpy/tool/steps/runtests.py:
2877         (RunTests.run):
2878         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
2879         (RunTestsTest.test_webkit_run_unit_tests):
2880         * Scripts/webkitpy/tool/steps/steps_unittest.py:
2881         (StepsTest.test_update_step):
2882         (StepsTest.test_runtests_args):
2883         * Scripts/webkitpy/tool/steps/update.py:
2884         (Update.run):
2885         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
2886         (UpdateChangeLogsWithReviewerTest.test_guess_reviewer_from_bug):
2887         (UpdateChangeLogsWithReviewerTest.test_guess_reviewer_from_multipatch_bug):
2888         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
2889         (UpdateChangeLogsWithReviewer._guess_reviewer_from_bug):
2890         (UpdateChangeLogsWithReviewer.run):
2891         * Scripts/webkitpy/tool/steps/updatechromiumdeps.py:
2892         (UpdateChromiumDEPS._validate_revisions):
2893         (UpdateChromiumDEPS.run):
2894         * Scripts/webkitpy/tool/steps/validatechangelogs.py:
2895         (ValidateChangeLogs._check_changelog_diff):
2896         (ValidateChangeLogs.run):
2897         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
2898         (ValidateChangeLogsTest._assert_start_line_produces_output):
2899         * Scripts/webkitpy/tool/steps/validatereviewer.py:
2900         (ValidateReviewer.run):
2901
2902 2012-11-26  Zan Dobersek  <zandobersek@gmail.com>
2903
2904         Coverage testing in webkitpy should omit some paths
2905         https://bugs.webkit.org/show_bug.cgi?id=103267
2906
2907         Reviewed by Dirk Pranke.
2908
2909         Omit testing coverage of any file under /usr directory and any file
2910         that is of third party origin and was autoinstalled.
2911
2912         * Scripts/webkitpy/test/main.py:
2913         (Tester._run_tests):
2914
2915 2012-11-26  Jaehun Lim  <ljaehun.lim@samsung.com>
2916
2917         Text Autosizing: Add Text Autosizing APIs for WK2
2918         https://bugs.webkit.org/show_bug.cgi?id=100633
2919
2920         Reviewed by Sam Weinig.
2921
2922         Add test cases for Text Autosizing in WKPreferences.
2923
2924         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
2925         (TestWebKitAPI::TEST):
2926
2927 2012-11-26  Pierre Rossi  <pierre.rossi@gmail.com>
2928
2929         [Qt] REGRESSION(r135575): It made all tests assert
2930         https://bugs.webkit.org/show_bug.cgi?id=103169
2931
2932         Reviewed by Simon Hausmann.
2933
2934         This fixes another regression introduced in r135515:
2935         initializeWebKitQt shouldn't implicitely call initializeWebCoreQt
2936         since it can be called from WebKit2 to initialize QStyle for testing.
2937         This would then lead to things such as PlatformStrategies being
2938         initialized twice.
2939
2940         * DumpRenderTree/qt/DumpRenderTreeQt.cpp: Also propagate the change to DRT this time.
2941         (WebCore::DumpRenderTree::DumpRenderTree):
2942
2943 2012-11-24  Zan Dobersek  <zandobersek@gmail.com>
2944
2945         Add the --order option to NRWT
2946         https://bugs.webkit.org/show_bug.cgi?id=102229
2947
2948         Reviewed by Dirk Pranke.
2949
2950         The --order option controls in what order the gathered tests will be run.
2951         There are 3 options:
2952         - natural, the tests are sorted in natural order,
2953         - random, the tests are sorted in random order,
2954         - none, the tests are kept in the order in which they were specified through
2955         arguments or the test list.
2956
2957         The natural option is the default one and maintains the current behavior.
2958
2959         The none option is primarily intended to be used with the --test-list option,
2960         with the test list file expected to list specific test names.
2961         When a directory is specified as one of the paths from under which tests should
2962         be gathered and the none option is used, that path will expand to all the tests
2963         under it, with these tests sorted in the natural order.
2964
2965         Using --order=random duplicated the behavior of the --randomize-order option, so
2966         the latter is removed.
2967
2968         This patch also incorporates the change with which makes it is possible to specify
2969         a test via arguments or the test list multiple tests and then have the test run
2970         that many times.
2971
2972         * Scripts/webkitpy/common/find_files.py:
2973         (find): Accept an optional sorting key that is used to sort files found in the directories
2974         that the given paths specify.
2975         (_normalized_find): Both paths that are then searched for the tests and the tests that
2976         were found are now kept in lists. This makes it possible to run a test multiple times
2977         by specifying it multiple times through arguments or the test list file.
2978         (_normalized_find.sort_by_directory_key):
2979         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
2980         (LayoutTestFinder.find_tests): Keep the paths where we should search for tests in a list.
2981         (LayoutTestFinder.skip_tests): Subtracting from a set of paths is necessary.
2982         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
2983         (LayoutTestRunner.__init__): The Sharder class no longer needs a test path separator.
2984         (Sharder.__init__): Ditto.
2985         (Sharder._resize_shards):
2986         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
2987         (SharderTests.get_shards): Modify the Shader initializing as required.
2988         (SharderTests.test_multiple_locked_shards): The natural sorting and test name key unit tests
2989         are now moved to the base Port unit tests.
2990         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2991         (Manager._prepare_lists): Keep the test names in a list. Order that list as specified by
2992         the new --order option.
2993         * Scripts/webkitpy/layout_tests/port/base.py:
2994         (Port.tests): This method should now return a list of all the tests found in the specified
2995         paths.
2996         (Port._real_tests): A list is required, so no conversion to a set is made.
2997         (Port):
2998         (Port.test_key): Place this method here for now, but it should really move into a separate
2999         module.
3000         (Port._natural_sort_key): Ditto.
3001         (Port._natural_sort_key.tryint):
3002         (Port._virtual_tests): A list is required, so the function now operates on that rather than
3003         on a set.
3004         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3005         (PortTest.test_find_with_skipped_directories_2): Adjust the test case to check for an empty
3006         list rather than an empty set.
3007         (PortTest.test_dont_require_http_server):
3008         (NaturalCompareTest): The natural sorting unit tests are placed here for now.
3009         (NaturalCompareTest.assert_cmp):
3010         (NaturalCompareTest.test_natural_compare):
3011         (KeyCompareTest): The test name key unit tests are placed here for now.
3012         (KeyCompareTest.assert_cmp):
3013         (KeyCompareTest.test_test_key):
3014         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3015         (parse_args): Remove the --randomize-order option, it's now possible to replicate its behavior
3016         by using --order=random.
3017         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: Add unit tests covering
3018         various aspects of this change.
3019         (MainTest.test_natural_order):
3020         (MainTest):
3021         (MainTest.test_natural_order_test_specified_multiple_times):
3022         (MainTest.test_random_order):
3023         (MainTest.test_random_order_test_specified_multiple_times):
3024         (MainTest.test_no_order):
3025         (MainTest.test_no_order_test_specified_multiple_times):
3026         (MainTest.test_no_order_with_directory_entries_in_natural_order):
3027         * Scripts/webkitpy/tool/commands/queries.py:
3028         (PrintExpectations.execute): Operate on a set of tests when printing out expectations.
3029
3030 2012-11-24  Sheriff Bot  <webkit.review.bot@gmail.com>
3031
3032         Unreviewed, rolling out r135600.
3033         http://trac.webkit.org/changeset/135600
3034         https://bugs.webkit.org/show_bug.cgi?id=103173
3035
3036         It made EFL API test is failed (Requested by gyuyoung_mbp on
3037         #webkit).
3038
3039         * TestWebKitAPI/PlatformEfl.cmake:
3040         * TestWebKitAPI/efl/PlatformUtilities.cpp:
3041         (TestWebKitAPI::Util::sleep):
3042         * TestWebKitAPI/efl/PlatformWebView.cpp:
3043
3044 2012-11-23  Alexis Menard  <alexis@webkit.org>
3045
3046         [CSS3 Backgrounds and Borders] Implement new CSS3 background-position parsing.
3047         https://bugs.webkit.org/show_bug.cgi?id=102104
3048
3049         Reviewed by Julien Chaffraix.
3050
3051         Protect the new feature behind a feature flag.
3052
3053         * Scripts/webkitperl/FeatureList.pm:
3054         * qmake/mkspecs/features/features.pri:
3055
3056 2012-11-23  Mario Sanchez Prada  <mario@webkit.org>
3057
3058         Unreviewed. Update my e-mail address.
3059
3060         * Scripts/webkitpy/common/config/committers.py:
3061
3062 2012-11-23  Mateusz Leszko  <m.leszko@samsung.com>
3063
3064         [EFL][GTK] Adapt accessibility feature to WebKitTestRunner.
3065         https://bugs.webkit.org/show_bug.cgi?id=100757
3066
3067         Reviewed by Laszlo Gombos.
3068
3069         Allow to build accessibility feature in WebkitTestRunner for EFL Platform.
3070         Updating CMake files due to changes from Bug 99011.
3071
3072         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
3073         (WTR::AccessibilityController::AccessibilityController):
3074         (WTR):
3075         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
3076         (AccessibilityController):
3077         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3078         (WTR):
3079         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3080         (AccessibilityUIElement):
3081         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp: - Removed gtk/gtk.h dependency.
3082         * WebKitTestRunner/PlatformEfl.cmake: - Adding atk includes.
3083
3084 2012-11-16  Yury Semikhatsky  <yurys@chromium.org>
3085
3086         Memory instrumentation: extract MemoryObjectInfo declaration into a separate file
3087         https://bugs.webkit.org/show_bug.cgi?id=102510
3088
3089         Reviewed by Pavel Feldman.
3090
3091         Added missing includes.
3092
3093         * TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp:
3094
3095 2012-11-23  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
3096
3097         [EFL][WK2] Add support for PlatformWebView::simulateSpacebarKeyPress() in TestWebKitAPI
3098         https://bugs.webkit.org/show_bug.cgi?id=103123
3099
3100         Reviewed by Kenneth Rohde Christiansen.
3101
3102         Add support for PlatformWebView::simulateSpacebarKeyPress() and enable
3103         WebKit2 API test ResponsivenessTimerDoesntFireEarly.
3104
3105         * TestWebKitAPI/PlatformEfl.cmake: Enable ResponsivenessTimerDoesntFireEarly
3106         test.
3107         * TestWebKitAPI/efl/PlatformUtilities.cpp:
3108         (TestWebKitAPI::Util::sleep): Use usleep() instead of sleep since the
3109         test case is passing 0.5 seconds to sleep.
3110         * TestWebKitAPI/efl/PlatformWebView.cpp:
3111         (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress): Implemented.
3112         (TestWebKitAPI):
3113
3114 2012-11-23  Wojciech Bielawski  <w.bielawski@samsung.com>
3115
3116         [WK2][WKTR] WebKitTestRunner needs eventSender.contextClick()
3117         https://bugs.webkit.org/show_bug.cgi?id=86881
3118
3119         Reviewed by Kenneth Rohde Christiansen.
3120
3121         eventSender object extended with contextClick() method in WebKitTestRunner.
3122         contextClick() method returns an array of menu items objects with field 'title' containing title of single
3123         context menu entry. According to some tests menu items objects shall also support 'click()' method, but it's not
3124         delivered in this patch.
3125
3126         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
3127         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3128         (WTR::EventSendingController::contextClick):
3129         (WTR):
3130         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
3131         (EventSendingController):
3132
3133 2012-11-23  Simon Hausmann  <simon.hausmann@digia.com>
3134
3135         [Qt] Compiling against QtWebkit API requires QT_DLL to be defined
3136         https://bugs.webkit.org/show_bug.cgi?id=102942
3137
3138         Reviewed by Tor Arne Vestbø.
3139
3140         Remove the requirement of having QT_DLL defined in order for the QWEBKIT_EXPORT
3141         macro to be defined as Q_DECL_IMPORT. Instead unify the export macro definition
3142         to follow the same rules as other Qt 5 modules, with the exception that instead of
3143         QT_BUILD_WEBKIT_LIB we continue to use BUILDING_WEBKIT, because that's used also
3144         in other cross-platform header files to determine the correct meaning of export
3145         macros.
3146
3147         * qmake/mkspecs/features/default_post.prf:
3148         * qmake/mkspecs/features/win32/default_post.prf:
3149
3150 2012-11-23  Simon Hausmann  <simon.hausmann@digia.com>
3151
3152         [Qt] QWebPage::shouldInterruptJavaScript should be virtual in Qt 5
3153         https://bugs.webkit.org/show_bug.cgi?id=103111
3154
3155         Reviewed by Kenneth Rohde Christiansen.
3156
3157         This function was added as a slot during Qt 4.x times because adding
3158         virtual functions breaks binary compatibility. This constraint is gone
3159         with the initial release of WebKit with Qt 5, and therefore we can
3160         make it virtual now.
3161
3162         The change is fully source compatible as existing "re-implementations"
3163         as slots will now be called through it being a virtual function. They
3164         become unused slots.
3165
3166         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3167         (WebCore::WebPage::shouldInterruptJavaScript):
3168         (WebPage):
3169         * QtTestBrowser/webpage.h:
3170         (WebPage):
3171
3172 2012-11-22  Peter Beverloo  <peter@chromium.org>
3173
3174         [Chromium] Return an accurate exit code when running Android suites, and wait after restarting adb as root
3175         https://bugs.webkit.org/show_bug.cgi?id=103065
3176
3177         Reviewed by Dirk Pranke.
3178
3179         This addresses two further reliability issues in the Android test running
3180         scripts. Firstly, the run_tests.py script needs to have the --exit_code
3181         argument passed in order to return non-zero codes, which we need for the
3182         build master to distinguish failures from successful runs.
3183
3184         Secondly, it modifies the layout test runner to briefly wait (through
3185         the wait-for-device command) after requesting a device to switch to root
3186         mode. Without this waiting period, commands might get lost and thereby
3187         unexpectedly fail.
3188
3189         * Scripts/run-api-tests:
3190         * Scripts/run-chromium-webkit-unit-tests:
3191         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3192         (ChromiumAndroidDriver._setup_test):
3193         (ChromiumAndroidDriver._restart_adb_as_root):
3194
3195 2012-11-22  Simon Hausmann  <simon.hausmann@digia.com>, Pierre Rossi <pierre.rossi@digia.com>
3196
3197         [Qt] Separate QWidget dependant code into separate WebKitWidgets static library
3198         https://bugs.webkit.org/show_bug.cgi?id=102800
3199
3200         Reviewed by Tor Arne Vestbø.
3201
3202         This patch separates code that needs to use QWidget related APIs in
3203         WebKit/qt/WebCoreSupport and Api from code that doesn't. This means for
3204         example FrameLoaderClientQt.cpp remains in the WebKit1 static library,
3205         while qwebpage.cpp and qwebframe.cpp become part of the WebKitWidgets
3206         static library. WebKit1 is compiled without QT += widgets and therefore
3207         any widget related dependency has been moved "up" and out of WebKit1 into
3208         the WebKitWidgets library.
3209
3210         Between the code in WebKit.a and WebKitWidgets.a new adapters and
3211         interfaces have been introduced, such as QWebPageAdapter and
3212         QWebFrameAdapter. QWebPageAdapter, when used from WebKit1, is a way to
3213         call out into the API layer, implemented by QWebPage (QWebPagePrivate).
3214         The other way around if QWebPage wants to access WebCore or
3215         WebCoreSupport related functionality, it will go through
3216         QWebPageAdapater (as base class). The separation in the direction up
3217         into the API layer is complete with this patch, no code in WebKit1
3218         depends on QtWidgets. The separation the other way around, code in the
3219         API layer not using any WebCore types, is not complete yet.
3220
3221         Some classes such as QWebSettings, QWebElement or
3222         DumpRenderTreeSupportQt remain in WebKit1. While they are API layer,
3223         they do not depend on widget related Qt APIs and they make much more
3224         use of WebCore internal APIs and therefore are easier to keep in
3225         WebKit1.
3226
3227         In the future we plan to place a real shared library boundary between
3228         WebKit1 and WebKitWidgets, by keeping the WebKit1 static library as
3229         part of the QtWebKit shared library and by turning the WebKitWidgets
3230         static library into a shared one.
3231
3232         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3233         (WebCore::WebPage::resetSettings):
3234         (WebCore::WebPage::createWindow):
3235         (WebCore::DumpRenderTree::DumpRenderTree):
3236         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
3237         (WebCore::DumpRenderTree::initJSObjects):
3238         (WebCore::DumpRenderTree::dumpFrameScrollPosition):
3239         (WebCore::DumpRenderTree::dumpFramesAsText):
3240         (WebCore::DumpRenderTree::dump):
3241         (WebCore::DumpRenderTree::createWindow):
3242         (WebCore::DumpRenderTree::pageAdapter):
3243         (WebCore):
3244         (WebCore::DumpRenderTree::mainFrameAdapter):
3245         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3246         (DumpRenderTree):
3247         * DumpRenderTree/qt/EventSenderQt.cpp:
3248         (EventSender::contextClick):
3249         (EventSender::scalePageBy):
3250         * DumpRenderTree/qt/TestRunnerQt.cpp:
3251         (TestRunner::reset):
3252         (TestRunner::display):
3253         (TestRunner::closeWebInspector):
3254         (TestRunner::showWebInspector):
3255         (TestRunner::evaluateInWebInspector):
3256         (TestRunner::setFrameFlatteningEnabled):
3257         (TestRunner::goBack):
3258         (TestRunner::setDefersLoading):
3259         (TestRunner::pauseAnimationAtTimeOnElementWithId):
3260         (TestRunner::pauseTransitionAtTimeOnElementWithId):
3261         (TestRunner::numberOfActiveAnimations):
3262         (TestRunner::setCaretBrowsingEnabled):
3263         (TestRunner::setAuthorAndUserStylesEnabled):
3264         (TestRunner::callShouldCloseOnWebView):
3265         (TestRunner::setSmartInsertDeleteEnabled):
3266         (TestRunner::setSelectTrailingWhitespaceEnabled):
3267         (TestRunner::execCommand):
3268         (TestRunner::isCommandEnabled):
3269         (TestRunner::findString):
3270         (TestRunner::elementDoesAutoCompleteForElementWithId):
3271         (TestRunner::setMockDeviceOrientation):
3272         (TestRunner::setGeolocationPermission):
3273         (TestRunner::numberOfPendingGeolocationPermissionRequests):
3274         (TestRunner::setMockGeolocationPositionUnavailableError):
3275         (TestRunner::setMockGeolocationPosition):
3276         (TestRunner::evaluateScriptInIsolatedWorld):
3277         (TestRunner::addUserStyleSheet):
3278         (TestRunner::setMinimumTimerInterval):
3279         * DumpRenderTree/qt/TextInputControllerQt.cpp:
3280         (TextInputController::selectedRange):
3281         (TextInputController::firstRectForCharacterRange):
3282         (TextInputController::unmarkText):
3283         * DumpRenderTree/qt/WorkQueueItemQt.cpp:
3284         (LoadAlternateHTMLStringItem::invoke):
3285         * qmake/mkspecs/features/default_post.prf:
3286         * qmake/mkspecs/features/production_build.prf:
3287         * qmake/mkspecs/features/webkit_modules.prf:
3288         * qmake/mkspecs/modules/webkitwidgets.prf: Added.
3289
3290 2012-11-22  Christophe Dumez  <christophe.dumez@intel.com>
3291
3292         WebKitTestRunner needs layoutTestController.setCacheModel
3293         https://bugs.webkit.org/show_bug.cgi?id=42684
3294
3295         Reviewed by Kenneth Rohde Christiansen.
3296
3297         Add support for testRunner.setCacheModel to WebKitTestRunner.
3298
3299         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3300         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3301         (WTR::InjectedBundle::beginTesting):
3302         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3303         (WTR::TestRunner::setCacheModel):
3304         (WTR):
3305         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3306         (TestRunner):
3307
3308 2012-11-22  Balazs Kelemen  <kbalazs@webkit.org>
3309
3310         [Qt][WTR] TestController::platformRunUntil should not do busy waiting
3311         https://bugs.webkit.org/show_bug.cgi?id=101327
3312
3313         Reviewed by Simon Hausmann.
3314
3315         Avoid busy waiting for events in platformRunUntil while making
3316         sure we don't change the behavior of modal event loops.
3317
3318         * WebKitTestRunner/TestController.cpp:
3319         (WTR::TestController::~TestController):
3320         * WebKitTestRunner/TestController.h:
3321         (TestController):
3322         * WebKitTestRunner/efl/TestControllerEfl.cpp:
3323         (WTR::TestController::platformDestroy):
3324         (WTR):
3325         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
3326         (WTR::TestController::platformDestroy):
3327         (WTR):
3328         * WebKitTestRunner/mac/TestControllerMac.mm:
3329         (WTR::TestController::platformDestroy):
3330         (WTR):
3331         * WebKitTestRunner/qt/TestControllerQt.cpp:
3332         (TestController::RunLoop): Helper class to handle
3333         the event loop logic
3334         (WTR):
3335         (WTR::TestController::RunLoop::RunLoop):
3336         (WTR::TestController::RunLoop::runUntil): Use QEventLoop to implement
3337         the run loop. This is the appropriate API to push the WaitForMoreEvents
3338         flag to QCoreApplication::processEvents and also being able to exit the
3339         loop if we have timed out.
3340         (WTR::TestController::RunLoop::notifyDone):
3341         (WTR::TestController::RunLoop::timerFired):
3342         (WTR::TestController::RunLoop::runModal):
3343         (WTR::TestController::notifyDone):
3344         (WTR::TestController::platformInitialize):
3345         (WTR::TestController::platformDestroy):
3346         (WTR::TestController::platformRunUntil):
3347         (WTR::TestController::runModal):
3348         * WebKitTestRunner/win/TestControllerWin.cpp:
3349         (WTR::TestController::platformDestroy):
3350         (WTR):
3351
3352 2012-11-22  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
3353
3354         [EFL][WK2] Enable WKPreferences and AboutBlankLoad API tests
3355         https://bugs.webkit.org/show_bug.cgi?id=102926
3356
3357         Reviewed by Kenneth Rohde Christiansen.
3358
3359         Add missing bits needed by WKPreferences and AboutBlankLoad API
3360         tests in the test harness and enable these tests on EFL port.
3361
3362         * TestWebKitAPI/PlatformEfl.cmake:
3363         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
3364         (TestWebKitAPI::TEST):
3365         * TestWebKitAPI/efl/PlatformUtilities.cpp:
3366         (TestWebKitAPI::Util::MIMETypeForWKURLResponse):
3367         (Util):
3368
3369 2012-11-21  Zan Dobersek  <zandobersek@gmail.com>
3370
3371         [GTK][WTR] Implement AccessibilityUIElement::stringValue
3372         https://bugs.webkit.org/show_bug.cgi?id=102951
3373
3374         Reviewed by Martin Robinson.
3375
3376         Implement AccessibilityUIElement::stringValue in the ATK backend
3377         in the same manner it is implemented in DumpRenderTree.
3378
3379         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3380         (WTR::replaceCharactersForResults):
3381         (WTR):
3382         (WTR::AccessibilityUIElement::stringValue):
3383
3384 2012-11-21  Vineet Chaudhary  <rgf748@motorola.com>
3385
3386         Unreviewed. Adding myself to committers.py.
3387
3388         * Scripts/webkitpy/common/config/committers.py:
3389
3390 2012-11-21  Tien-Ren Chen  <trchen@chromium.org>
3391
3392         [chromium] Device scale factor should be no-op when applyDeviceScaleFactorInCompositor == 0
3393         https://bugs.webkit.org/show_bug.cgi?id=100061
3394
3395         Reviewed by Adam Barth.
3396
3397         On Android we're using a different pixel scaling implementation
3398         (WebCore::Settings::applyDefaultDeviceScaleFactorInCompositor() == 0) than other
3399         platforms. In this mode, we don't make use of device-independent pixels. Device
3400         scale factor is provided to WebKit and get merged into page scale factor. Other
3401         than that device scale factor should have no effects on rendering.
3402
3403         * DumpRenderTree/chromium/WebPreferences.cpp:
3404         (WebPreferences::applyTo):
3405
3406 2012-11-21  Fady Samuel  <fsamuel@chromium.org>
3407
3408         Clear MousePressed state on context menu to avoid initiating a drag
3409         https://bugs.webkit.org/show_bug.cgi?id=101786
3410
3411         Reviewed by Ojan Vafai.
3412
3413         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
3414         (WebTestRunner):
3415         (WebTestRunner::EventSender::EventSender):
3416         (WebTestRunner::EventSender::contextClick):
3417         Only send a MouseUp on Windows. Keep the current mouse pressed state when
3418         calling up a context menu.
3419
3420 2012-11-21  Thiago Marcos P. Santos  <thiago.santos@intel.com>
3421
3422         [EFL] KURL unit test crashing when tiled backing store is enabled on Release Bots
3423         https://bugs.webkit.org/show_bug.cgi?id=102895
3424
3425         Reviewed by Gyuyoung Kim.
3426
3427         Change the link order so it wont override the new operator on gtest.
3428         Looks like it was crashing because an allocator mismatch (using libc's
3429         new and later fastMalloc delete. Thanks to Kangil Han for hinting on
3430         the fastMalloc issue.
3431
3432         * TestWebKitAPI/CMakeLists.txt:
3433
3434 2012-11-21  Kentaro Hara  <haraken@chromium.org>
3435
3436         Unreviewed, rolling out r135340.
3437         http://trac.webkit.org/changeset/135340
3438         https://bugs.webkit.org/show_bug.cgi?id=102492
3439
3440         It broke Safari's internal build
3441
3442         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
3443         (new):
3444         (GenerateModule):
3445         (GenerateInterface):
3446         (finish):
3447
3448 2012-11-21  Yael Aharon  <yael.aharon@intel.com>, Gyuyoung Kim <gyuyoung.kim@samsung.com>
3449
3450         [EFL] Turn on WTF_USE_TILED_BACKING_STORE by default
3451         https://bugs.webkit.org/show_bug.cgi?id=101526
3452
3453         Reviewed by Kenneth Rohde Christiansen.
3454
3455         Turn on WTF_USE_TILED_BACKING_STORE for EFL port.
3456
3457         * Scripts/webkitperl/FeatureList.pm:
3458         * TestWebKitAPI/CMakeLists.txt: No include KURL.cpp because of API test crash.
3459
3460 2012-11-21  Jongseok Yang  <js45.yang@samsung.com>
3461
3462         [EFL][WK2] Rename ewk_view_setting_encoding_custom_XXX to ewk_view_custom_encoding_XXX
3463         https://bugs.webkit.org/show_bug.cgi?id=102867
3464
3465         Reviewed by Gyuyoung Kim.
3466
3467         Rename ewk_view_setting_encoding_custom_XXX to ewk_view_custom_encoding_XXX.
3468
3469         ewk_view_setting_encoding_custom_XXX APIs might be misunderstanded as the "setting" word
3470         because ewk_view_setting_encoding_custom_set triggers the "reload" operation.
3471         And ewk_view_setting_XXX is not correct because there is ewk_settings object for settings.
3472
3473         * MiniBrowser/efl/main.c:
3474         (on_key_down):
3475
3476 2012-11-20  Sheriff Bot  <webkit.review.bot@gmail.com>
3477
3478         Unreviewed, rolling out r133859.
3479         http://trac.webkit.org/changeset/133859
3480         https://bugs.webkit.org/show_bug.cgi?id=102875
3481
3482         This patch makes API test broken (Requested by gyuyoung on
3483         #webkit).
3484
3485         * Scripts/webkitperl/FeatureList.pm:
3486
3487 2012-11-20  Jinwoo Song  <jinwoo7.song@samsung.com>
3488
3489         [EFL][WK2] Add Ewk_Window_Features API and related UI callbacks
3490         https://bugs.webkit.org/show_bug.cgi?id=99114
3491
3492         Reviewed by Gyuyoung Kim.
3493
3494         Implemented window_create and window_close smartcallback functions.
3495
3496         * MiniBrowser/efl/main.c:
3497         (on_window_create):
3498         (on_window_close):
3499         (window_create):
3500
3501 2012-11-20  Ojan Vafai  <ojan@chromium.org>
3502
3503         Simplify builder filters now that we have lists of which builders run which tests
3504         https://bugs.webkit.org/show_bug.cgi?id=102849
3505
3506         Reviewed by Dirk Pranke.
3507
3508         We only need filters when we load the same master for multiple groups in the
3509         same test type, i.e. when we need to only include some of the builders that run
3510         a given test suite on a given master.
3511
3512         Also, get rid of the DEFAULT_BUILDER enum. We were always using the first builder anyways.
3513         Now just make it a method on BuilderGroup.
3514
3515         * TestResultServer/static-dashboards/builders.js:
3516         (BuilderGroup.prototype.append):
3517         (BuilderGroup.prototype.setup):
3518         (BuilderGroup.prototype._defaultBuilder):
3519         (BuilderGroup.prototype.master):
3520         (requestBuilderList):
3521         (isChromiumWebkitTipOfTreeTestRunner):
3522         (isChromiumWebkitDepsTestRunner):
3523         (loadBuildersList):
3524         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
3525         (test):
3526
3527 2012-11-20  Ojan Vafai  <ojan@chromium.org>
3528
3529         Remove perfav master for webkit_unit_tests and test_shell_tests.
3530         There are no bots on this master that run these tests.
3531         * TestResultServer/static-dashboards/builders.js:
3532
3533 2012-11-20  Ojan Vafai  <ojan@chromium.org>
3534
3535         Remove special case for layout tests when builders fail to load
3536         https://bugs.webkit.org/show_bug.cgi?id=102842
3537
3538         Reviewed by Tony Chang.
3539
3540         Now that we load only builders that actually run the given test
3541         type, we can reliably show errors to the users because it
3542         represents a broken bot.
3543         * TestResultServer/static-dashboards/loader.js:
3544
3545 2012-11-15  Ojan Vafai  <ojan@chromium.org>
3546
3547         Generate a list of builders/test suites from the buildbot json
3548         https://bugs.webkit.org/show_bug.cgi?id=102443
3549
3550         Reviewed by Dirk Pranke.
3551
3552         Instead of the cludgy things we do now to track which bots run which tests,
3553         we generate all that data from the buildbots' json files.
3554         This is the minimal amount to keep everything working. Once this lands,
3555         we can also do a bunch of followup cleanup.
3556
3557         For now we commit the generated data. In theory, in the future, we could
3558         have the test results server generate the data on the fly.
3559
3560         For the sake of easily understanding what changes when we run the generate script,
3561         also checkin a pretty printed version of the output. The pretty printed version
3562         is too large to serve as part of the flakiness dashboard though.
3563
3564         This also has the benefit of making the dashboard load much faster since
3565         we no longer ever need to block on requests to buildbot.
3566
3567         * TestResultServer/generate_builders_json.py: Added.
3568         (master_json_url):
3569         (builder_json_url):
3570         (cached_build_json_url):
3571         (fetch_json):
3572         (insert_builder_and_test_data):
3573         (main):
3574         * TestResultServer/generate_builders_json_unittest.py: Added.
3575         (GenerateBuildersJsonTest):
3576         (GenerateBuildersJsonTest.test_master_json_url):
3577         (GenerateBuildersJsonTest.test_builder_json_url):
3578         (GenerateBuildersJsonTest.test_cached_build_json_url):
3579         (GenerateBuildersJsonTest.test_generate_json_data):
3580         (GenerateBuildersJsonTest.test_generate_json_data.dummy_fetch_json):
3581         * TestResultServer/static-dashboards/builders-pretty.jsonp: Added.
3582         * TestResultServer/static-dashboards/builders.js:
3583         (LOAD_BUILDBOT_DATA):
3584         (BuilderGroup):
3585         (BuilderGroup.prototype.append):
3586         (BuilderGroup.prototype.master):
3587         (requestBuilderList):
3588         * TestResultServer/static-dashboards/builders.jsonp: Added.
3589         * TestResultServer/static-dashboards/builders_unittests.js: Added.
3590         * TestResultServer/static-dashboards/dashboard_base.js:
3591         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3592         (showPopupForBuild):
3593         (htmlForTestResults):
3594         (htmlForIndividualTestOnAllBuildersWithResultsLinks):
3595         (loadExpectationsLayoutTests):
3596         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
3597         (resetGlobals):
3598         (test):
3599         * TestResultServer/static-dashboards/loader.js:
3600         * TestResultServer/static-dashboards/loader_unittests.js:
3601         * TestResultServer/static-dashboards/run-embedded-unittests.html:
3602         * TestResultServer/static-dashboards/run-unittests.html:
3603         * TestResultServer/static-dashboards/timeline_explorer.html:
3604
3605 2012-11-20  Thiago Marcos P. Santos  <thiago.santos@intel.com>
3606
3607         [WTR][Qt] Enable fixedLayout when needed by the test
3608         https://bugs.webkit.org/show_bug.cgi?id=102811
3609
3610         Reviewed by Kenneth Rohde Christiansen.
3611
3612         Create a flickable view for CSS Device Adaptation tests. This is
3613         crucial for testing them since they will change the size of the
3614         viewport.
3615
3616         * WebKitTestRunner/PlatformWebView.h:
3617         (PlatformWebView):
3618         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3619         (WTR::PlatformWebView::PlatformWebView):
3620         (WTR::PlatformWebView::viewSupportsOptions):
3621         (WTR):
3622         * WebKitTestRunner/qt/main.cpp:
3623         (main):
3624
3625 2012-11-20  Thiago Marcos P. Santos  <thiago.santos@intel.com>
3626
3627         [WTR] WebKitTestRunner should be able to run tests using fixed layout
3628         https://bugs.webkit.org/show_bug.cgi?id=102517
3629
3630         Reviewed by Kenneth Rohde Christiansen.
3631
3632         WTR will now request the creation of a view that has a page using
3633         fixed layout for CSS Device Adaptation tests, but this feature might
3634         be used in the future by any other test that requires a mobile-like type
3635         of viewport (i.e. Viewport META tests should be ported).
3636
3637         The viewport type of the other tests remains unchanged and is restored
3638         when the runner leaves the device-adapt/ folder.
3639
3640         * WebKitTestRunner/PlatformWebView.h:
3641         (PlatformWebView):
3642         * WebKitTestRunner/TestInvocation.cpp:
3643         (WTR):
3644         (WTR::shouldUseFixedLayout):
3645         (WTR::updateLayoutType):
3646         (WTR::TestInvocation::invoke):
3647         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
3648         (WTR::PlatformWebView::PlatformWebView):
3649         (WTR::PlatformWebView::viewSupportsOptions):
3650         (WTR):
3651
3652 2012-11-20  Csaba Osztrogonác  <ossy@webkit.org>
3653
3654         [Qt] REGRESSION(r128174): Fast build path doesn't work now
3655         https://bugs.webkit.org/show_bug.cgi?id=100360
3656
3657         Reviewed by Tor Arne Vestbø.
3658
3659         Use a separated .builtRevisions.cache file instead of .qmake.cache to cache built SVN revisions.
3660
3661         * Scripts/webkitdirs.pm:
3662         (buildQMakeProjects):
3663
3664 2012-11-20  Mateusz Leszko  <m.leszko@samsung.com>
3665
3666         [EFL][GTK]Sharing accessibility support in WebKitTestRunner.
3667         https://bugs.webkit.org/show_bug.cgi?id=99011
3668
3669         Reviewed by Martin Robinson.
3670
3671         Accessibility files from gtk folder are moved to atk folder due to common implementation. Event Type naming changed to default, from Gtk to ATK.
3672
3673         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp: Renamed from Tools/WebKitTestRunner/InjectedBundle/gtk/AccessibilityControllerGtk.cpp.
3674         (WTR::AccessibilityController::logAccessibilityEvents):
3675         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp: Renamed from Tools/WebKitTestRunner/InjectedBundle/gtk/AccessibilityUIElementGtk.cpp.
3676
3677 2012-11-20  Zan Dobersek  <zandobersek@gmail.com>
3678
3679         webkitpy unit tests should run serially when checking code coverage
3680         https://bugs.webkit.org/show_bug.cgi?id=102693
3681
3682         Reviewed by Dirk Pranke.
3683
3684         When checking code coverage, the unit tests should not be run in parallel
3685         as this causes the tracing functions (set via sys.settrace in the cover