a2f857d2624dfe835a2ee587989e6534b0aba613
[WebKit.git] / Tools / ChangeLog
1 2011-02-06  Ryosuke Niwa  <rniwa@webkit.org>
2
3         Reviewed by Darin Adler.
4
5         OwnArraryPtr.h uses deleteOwnedPtr but doesn’t include OwnPtrCommon.h
6         https://bugs.webkit.org/show_bug.cgi?id=52867
7
8         * DumpRenderTree/chromium/ImageDiff.cpp:
9         (Image::craeteFromStdin): Call adoptArrayPtr.
10
11 2011-02-06  James Kozianski  <koz@chromium.org>
12
13         Reviewed by Ojan Vafai.
14
15         Add classes for representing test outputs.
16         https://bugs.webkit.org/show_bug.cgi?id=52136
17
18         These classes will make it easier to write scripts that deal with test
19         outputs such as rebaselining and deduping scripts. The intent is that
20         eventually we will be have buildbot return TestOutputs for a
21         particular build which can be compared with TestOutputs derived from a
22         local LayoutTests directory.
23
24         * Scripts/webkitpy/common/net/testoutput.py: Added.
25         * Scripts/webkitpy/common/net/testoutput_unittest.py: Added.
26         * Scripts/webkitpy/common/net/testoutputset.py: Added.
27         * Scripts/webkitpy/common/net/testoutputset_unittest.py: Added.
28         * Scripts/webkitpy/common/system/zip_mock.py: Added.
29
30 2011-02-06  Robert Hogan  <robert@webkit.org>
31
32         Reviewed by Andreas Kling.
33
34         [Qt] Clear page's groupName even when not in DRT
35         https://bugs.webkit.org/show_bug.cgi?id=53874
36
37         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
38         (WebCore::DumpRenderTree::windowCloseRequested):
39
40 2011-02-06  Patrick Gansterer  <paroga@webkit.org>
41
42         Reviewed by Andreas Kling.
43
44         [CMake] Add dependencies for Visual Studio projects
45         https://bugs.webkit.org/show_bug.cgi?id=53773
46
47         Add a WebKit dependecy to WinCELauncher, so CMake can 
48         generate the correct build order for the solution.
49
50         * CMakeListsWinCE.txt:
51
52 2011-02-06  Andreas Kling  <kling@webkit.org>
53
54         Reviewed by Antonio Gomes.
55
56         [Qt] MiniBrowser: Clean up handling of titleChanged() signal
57         https://bugs.webkit.org/show_bug.cgi?id=53869
58
59         * MiniBrowser/qt/BrowserView.cpp:
60         (BrowserView::BrowserView): Remove unnecessary titleChanged() handling.
61         * MiniBrowser/qt/BrowserWindow.cpp:
62         (BrowserWindow::BrowserWindow): Connect titleChanged() directly to setWindowTitle().
63         * MiniBrowser/qt/BrowserWindow.h:
64
65 2011-02-06  Maciej Stachowiak  <mjs@apple.com>
66
67         Reviewed by Dan Bernstein.
68
69         WebKitTestRunner needs layoutTestController.setWillSendRequestReturnsNull
70         https://bugs.webkit.org/show_bug.cgi?id=42690
71         <rdar://problem/8213851>
72
73         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
74         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
75         (WTR::InjectedBundlePage::willSendRequestForFrame):
76         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
77         (WTR::LayoutTestController::LayoutTestController):
78         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
79         (WTR::LayoutTestController::willSendRequestReturnsNull):
80         (WTR::LayoutTestController::setWillSendRequestReturnsNull):
81
82 2011-02-05  Sheriff Bot  <webkit.review.bot@gmail.com>
83
84         Unreviewed, rolling out r77720.
85         http://trac.webkit.org/changeset/77720
86         https://bugs.webkit.org/show_bug.cgi?id=53854
87
88         "Broke nrwt on Chromium win." (Requested by dglazkov|away on
89         #webkit).
90
91         * Scripts/webkitpy/common/system/executive.py:
92
93 2011-02-05  Sheriff Bot  <webkit.review.bot@gmail.com>
94
95         Unreviewed, rolling out r77725.
96         http://trac.webkit.org/changeset/77725
97         https://bugs.webkit.org/show_bug.cgi?id=53844
98
99         It broke Qt minimal build (Requested by Ossy_ on #webkit).
100
101         * QtTestBrowser/launcherwindow.cpp:
102         (LauncherWindow::createChrome):
103         * QtTestBrowser/launcherwindow.h:
104         (WindowOptions::WindowOptions):
105         * QtTestBrowser/main.cpp:
106         (LauncherApplication::handleUserOptions):
107
108 2011-02-04  Martin Robinson  <mrobinson@igalia.com>
109
110         Reviewed by Adam Barth.
111
112         [GTK] plugins/plugin-document-back-forward.html fails
113         https://bugs.webkit.org/show_bug.cgi?id=53833
114
115         Add the new "alert on load" functionality for the Unix version of the
116         test plugin. This functionality was originally introduced in r77706.
117
118         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
119         (webkit_test_plugin_new_instance): Add new plugin fuctionality.
120
121 2011-02-04  Kundu Suchismita  <suchi.kundu@nokia.com>
122
123         Reviewed by Andreas Kling.
124
125         Local Storage settings can be enable/disable from "Develop" menu
126         https://bugs.webkit.org/show_bug.cgi?id=52296
127
128         * QtTestBrowser/launcherwindow.cpp:
129         (LauncherWindow::createChrome):
130         (LauncherWindow::toggleLocalStorage):
131         (LauncherWindow::toggleOfflineStorageDatabase):
132         (LauncherWindow::toggleOfflineWebApplicationCache):
133         (LauncherWindow::setOfflineStorageDefaultQuota):
134         * QtTestBrowser/launcherwindow.h:
135         (WindowOptions::WindowOptions):
136         * QtTestBrowser/main.cpp:
137         (LauncherApplication::handleUserOptions):
138
139 2011-02-04  Tony Chang  <tony@chromium.org>
140
141         Reviewed by Eric Seidel.
142
143         get test-webkitpy running on win32 python
144         https://bugs.webkit.org/show_bug.cgi?id=53822
145
146         The test harness crashes with a WindowsError because it can't find
147         'svn' when using subprocess.Popen.  This gets us past the error
148         so we can see the failing tests on the Chromium Win Release Tests
149         bot.
150
151         * Scripts/webkitpy/common/system/executive.py:
152
153 2011-02-04  Martin Robinson  <mrobinson@igalia.com>
154
155         Reviewed by Gustavo Noronha Silva.
156
157         [GTK] fast/events/pagehide-timeout.html fails
158         https://bugs.webkit.org/show_bug.cgi?id=53771
159
160         Add knowledge of the document browser cache model the DRT. When resetting
161         WebKit settings to consistent values between tests, default to the document
162         browser cache model.
163
164         * DumpRenderTree/gtk/DumpRenderTree.cpp:
165         (resetDefaultsToConsistentValues): Reset the cache model to the document browser
166         cache model between tests.
167         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
168         (LayoutTestController::setCacheModel): An int value of 2 here corresponds to the
169         document browser cache model.
170
171 2011-02-04  Adam Barth  <abarth@webkit.org>
172
173         Reviewed by Eric Seidel.
174
175         PluginDocuments don't create widgets for plugins on back/forward
176         https://bugs.webkit.org/show_bug.cgi?id=53474
177
178         Teach the test plugin how to call alert on load.
179
180         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
181         (NPP_New):
182
183 2011-02-04  Adam Roben  <aroben@apple.com>
184
185         Add a test case for encode/decode of FormData/FormDataElement
186
187         If the fix made in r77401 is broken, this new test will crash.
188
189         Fixes <http://webkit.org/b/53616> <rdar://problem/8949883>.
190
191         Reviewed by Sam Weinig.
192
193         * TestWebKitAPI/Test.h: Moved the bulk of TEST_ASSERT into a new _TEST_ASSERT_HELPER macro.
194         Added a new TEST_ASSERT_RETURN macro that can be used in functions with a return value.
195
196         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp: Added.
197         (TestWebKitAPI::didFinishLoadForFrame): Record that the load is finished.
198         (TestWebKitAPI::setPageLoaderClient): Hook up the loader client.
199         (TestWebKitAPI::createSessionStateContainingFormData): Load simple-form.html, submit the
200         form, an return the session state data.
201         (TestWebKitAPI::TEST): Create some session state that contains form data from one WKPage,
202         and restore it into another WKPage.
203
204         * TestWebKitAPI/Tests/WebKit2/simple-form.html: Added.
205
206         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
207         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
208         * TestWebKitAPI/win/copy-resources.cmd:
209         Added new files.
210
211 2011-02-04  Adam Roben  <aroben@apple.com>
212
213         Move code to run JavaScript tests into its own files
214
215         This will allow other tests to use this mechanism.
216
217         Fixes <http://webkit.org/b/53806> SpacebarScrolling should share its JavaScript-fu with the
218         world
219
220         Reviewed by Sam Weinig.
221
222         * TestWebKitAPI/JavaScriptTest.cpp: Added.
223         * TestWebKitAPI/JavaScriptTest.h: Added.
224         Moved code here...
225
226         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp: ...from here.
227
228         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
229         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
230         Added the new files.
231
232 2011-02-04  Dirk Pranke  <dpranke@chromium.org>
233
234         Reviewed by Mihai Parparita.
235
236         merge test expectations for chromium, chromium-gpu. The
237         chromium-gpu port will no longer maintain its own
238         test expectations file.
239
240         Also add in a graphics_type() call on the port object to
241         determine what graphics type to use in the test configuration,
242         and log the configuration as a config setting.
243
244         https://bugs.webkit.org/show_bug.cgi?id=53562
245
246         * Scripts/webkitpy/layout_tests/port/base.py:
247         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
248         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
249         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
250
251 2011-02-04  Mikhail Naganov  <mnaganov@chromium.org>
252
253         Reviewed by Pavel Feldman.
254
255         Web Inspector: fix processing Unicode literals from .js sources in check-inspector-strings.
256         https://bugs.webkit.org/show_bug.cgi?id=53781
257
258         * Scripts/check-inspector-strings:
259
260 2011-02-04  Adam Roben  <aroben@apple.com>
261
262         Include the crashing function in the link to a crash log on Mac
263
264         Fixes <http://webkit.org/b/53780> Crash log links in results.html should include the
265         function that crashed on Mac
266
267         Reviewed by David Kilzer.
268
269         * Scripts/old-run-webkit-tests:
270         (crashLocation): Moved all the Windows code inside an if instead of using an early return,
271         but didn't otherwise change it. Added an if for Mac that parses the crashing function out of
272         the crash log.
273
274 2011-02-04  Adam Roben  <aroben@apple.com>
275
276         Link to Mac crash logs from results.html
277
278         Fixes <http://webkit.org/b/14861> run-webkit-tests should link to Mac crash logs in
279         results.html
280
281         Reviewed by David Kilzer.
282
283         * Scripts/old-run-webkit-tests:
284         (captureSavedCrashLog): Added a case for Apple's Mac port. We get the crash log out of
285         ~/Library/Logs/CrashReporter, and wait for ReportCrash to exit before trying to get the log.
286
287 2011-02-03  Maciej Stachowiak  <mjs@apple.com>
288
289         Reviewed by Dan Bernstein.
290
291         WebKit2: Need WebKit2 equivalent of WebResourceLoadDelegate::willSendRequest in the Bundle
292         https://bugs.webkit.org/show_bug.cgi?id=52897
293         <rdar://problem/8898294>
294
295         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
296         (WTR::InjectedBundlePage::InjectedBundlePage):
297         (WTR::InjectedBundlePage::willSendRequestForFrame):
298         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
299
300 2011-02-03  Ivan Krstić  <ike@apple.com>
301
302         Unreviewed.
303
304         Adding myself to committers.py.
305
306         * Scripts/webkitpy/common/config/committers.py:
307
308 2011-02-03  James Kozianski  <koz@chromium.org>
309
310         Reviewed by Dimitri Glazkov.
311
312         Add navigator.registerProtocolHandler behind a flag.
313         https://bugs.webkit.org/show_bug.cgi?id=52609
314
315         * Scripts/build-webkit:
316
317 2011-02-03  Hayato Ito  <hayato@chromium.org>
318
319         Reviewed by Eric Seidel.
320
321         [NRWT] Remove TestArgs class, which is wrongly used.
322
323         https://bugs.webkit.org/show_bug.cgi?id=53063
324
325         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
326         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
327         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
328         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
329         * Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py:
330         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
331
332 2011-02-03  Andrew Wason  <rectalogic@rectalogic.com>
333
334         Reviewed by Kenneth Russell.
335
336         Change ENABLE_3D_CANVAS to ENABLE_WEBGL
337         https://bugs.webkit.org/show_bug.cgi?id=53714
338
339         * Scripts/build-webkit: change --3d-canvas build option
340           to set ENABLE_WEBGL
341
342 2011-02-03  Hayato Ito  <hayato@chromium.org>
343
344         Reviewed by Tony Chang.
345
346         [NRWT] Introduces Input/Output class used by base.Driver into port/base.py and
347         move _run_single_test() and _process_output() functions from
348         dump_render_tree_thread.py to a single_test_runner.py as an individual module.
349
350         This is clean up and acts as a preparation for elimination of test_types/*
351         classes. These classes will move to the single_test_runner module introduced
352         in this patch.
353
354         https://bugs.webkit.org/show_bug.cgi?id=53004
355
356         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
357         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py: Added.
358         * Scripts/webkitpy/layout_tests/layout_package/test_input.py:
359         * Scripts/webkitpy/layout_tests/layout_package/test_output.py: Removed.
360         * Scripts/webkitpy/layout_tests/port/base.py:
361         * Scripts/webkitpy/layout_tests/port/chromium.py:
362         * Scripts/webkitpy/layout_tests/port/dryrun.py:
363         * Scripts/webkitpy/layout_tests/port/test.py:
364         * Scripts/webkitpy/layout_tests/port/webkit.py:
365         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
366         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
367         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
368
369 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
370
371         Unreviewed, build fix.
372
373         Delete a line that was accidentally missed in r77586; without it
374         there is still a race between the two threads.
375
376         https://bugs.webkit.org/show_bug.cgi?id=51572
377
378         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
379
380 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
381
382         Reviewed by Tony Chang.
383
384         nrwt: handle "broken pipe" notifications from DRT more cleanly.
385
386         https://bugs.webkit.org/show_bug.cgi?id=52927
387
388         * Scripts/webkitpy/layout_tests/port/server_process.py:
389         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
390
391 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
392
393         Reviewed by Kenneth Russell.
394
395         Update, resubmit change to bug 51572. I think the race that was
396         fixed in r76703 caused the hang that caused us to roll this
397         patch out before, so I'd like to try again.
398
399         https://bugs.webkit.org/show_bug.cgi?id=51572
400
401         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
402         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
403
404 2011-02-03  Daniel Cheng  <dcheng@chromium.org>
405
406         Unreviewed.
407
408         Adding myself to committers.py.
409
410         * Scripts/webkitpy/common/config/committers.py:
411
412 2011-02-03  Adam Roben  <aroben@apple.com>
413
414         Include the crashing function in the link to a crash log
415
416         Fixes <http://webkit.org/b/53739> Crash log links in results.html should include the
417         function that crashed
418
419         Reviewed by David Kilzer.
420
421         * Scripts/old-run-webkit-tests:
422         (crashLocation): Added. Returns the location of the crash.
423         (linksForErrorTest): Include the crash location in the link text for the crash log, if one
424         could be determined.
425
426 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
427
428         Unreviewed, build fix.
429
430         Actually make the changes suggested by Mihai in his review
431         of bug 53720 :(
432
433         https://bugs.webkit.org/show_bug.cgi?id=53720
434
435         * Scripts/webkitpy/layout_tests/port/test_files.py:
436         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
437
438 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
439
440         Reviewed by Mihai Parparita.
441
442         new-run-webkit-tests: Fix bug introduced in r77434 that was
443         causing us to run the canvas GPU tests on the Mac GPU port. This
444         bug revealed that we were not setting the port.name() field
445         properly in many cases, so I've cleaned up all of that code, and
446         removed a few comments about "version-specific" GPU ports that
447         don't exist and just confused things.
448
449         Testing also revealed that port.abspath_for_test() wasn't
450         normalizing paths on Windows properly, so I fixed that as well.
451
452         https://bugs.webkit.org/show_bug.cgi?id=53719
453
454         * Scripts/webkitpy/layout_tests/port/base.py:
455         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
456         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
457
458 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
459
460         Reviewed by Mihai Parparita.
461
462         new-run-webkit-tests: fix normalization of paths on windows when gathering files
463
464         r77434 introduced a bug that was causing the test expectations
465         for the GPU ports to not be treated properly. It turns out that
466         when we gathered the list of test files on Windows, we would
467         return paths of the form "c:\LayoutTests/fast/canvas", and the
468         mixture of backslashes and forward slashes was confusing things.
469
470         This patch normalizes all of the filenames returned from
471         test_files.find(), and adds better tests for this (fixing a
472         couple of other bugs found in the meantime).
473
474         https://bugs.webkit.org/show_bug.cgi?id=53720
475
476         * Scripts/webkitpy/layout_tests/port/test.py:
477         * Scripts/webkitpy/layout_tests/port/test_files.py:
478         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
479
480 2011-02-03  Adam Roben  <aroben@apple.com>
481
482         Add links to Windows crash logs in results.html
483
484         Fixes <http://webkit.org/b/53718> run-webkit-tests should link to Windows crash logs in
485         results.html
486
487         Reviewed by David Kilzer.
488
489         * Scripts/old-run-webkit-tests:
490         (top level): Added $crashLogTag and $windowsCrashLogFilePrefix (which came from
491         createDebuggerCommandFile).
492         (testCrashedOrTimedOut): If the test crashed, capture any saved crash log after the dump
493         tool has exited.
494         (captureSavedCrashLog): Added. Finds the crash log for the test that just crashed and moves
495         it into the test results directory tree. Only implemented for Cygwin currently.
496         (findNewestFileMatchingGlob): Added. Does what it says.
497         (htmlForResultsSection): Only link to files that exist.
498         (linksForErrorTest): Add a link to the crash log.
499         (deleteExpectedAndActualResults): Delete any old crash log for this test.
500         (createDebuggerCommandFile): Use the new $windowsCrashLogFilePrefix constant instead of
501         hardcoding it here.
502
503 2011-02-03  Adam Roben  <aroben@apple.com>
504
505         Tell the debugger the path to the WebKit source tree when saving a crash log
506
507         This allows the debugger to include the crashing line of code in the log.
508
509         Fixes <http://webkit.org/b/53678> Crash logs from buildslaves don't show the crashing line
510         of code
511
512         Reviewed by Sam Weinig.
513
514         * Scripts/old-run-webkit-tests:
515         (createDebuggerCommandFile): Added. Saves commands that we'd like the debugger to run to a
516         file and returns the path to that file. The commands we pass came from
517         setUpWindowsCrashLogSaving, but I've added a .srcpath command to tell the debugger where the
518         WebKit source code lives.
519         (setUpWindowsCrashLogSaving): Instead of specifying the commands directly on the command
520         line using -c, save them to a file and specify the path to that file using -cf. This works
521         around what is presumably a bug in Windows's command line parsing, where having multiple
522         quoted paths in the debugger commands causes the post-mortem debugger not to be invoked at
523         all. Also pulled the options we pass to the debugger out into a list that is then join()ed
524         together to make them easier to modify in the future.
525
526 2011-02-02  Sam Weinig  <sam@webkit.org>
527
528         Reviewed by Anders Carlsson.
529
530         Add notification of the end of a rubber band.
531         <rdar://problem/8940648>
532
533         * MiniBrowser/mac/BrowserWindowController.m:
534         (-[BrowserWindowController awakeFromNib]):
535         * WebKitTestRunner/TestController.cpp:
536         (WTR::TestController::createOtherPage):
537         (WTR::TestController::initialize):
538         Stub out the new WKUIClient function.
539
540 2011-02-03  Gabor Rapcsanyi  <rgabor@webkit.org>
541
542         Unreviewed.
543
544         Adding myself to committers.py.
545
546         * Scripts/webkitpy/common/config/committers.py:
547
548 2011-02-03  Balazs Kelemen  <kbalazs@webkit.org>
549
550         Reviewed by Csaba Osztrogonác.
551
552         [Qt][WK2] MiniBrowser's window size should be 800x600
553         https://bugs.webkit.org/show_bug.cgi?id=53670
554
555         Make layout test failure debugging easier.
556         * MiniBrowser/qt/BrowserWindow.cpp:
557         (BrowserWindow::BrowserWindow):
558
559 2011-02-02  Andy Estes  <aestes@apple.com>
560
561         Reviewed by Mark Rowe.
562
563         'update-webkit' should handle OpenSource and Internal using different
564         VCSs.
565
566         * Scripts/update-webkit: Re-check the VCS type when updating Apple's
567         Internal directory.
568
569 2011-02-02  Dirk Pranke  <dpranke@chromium.org>
570
571         Reviewed by Mihai Parparita.
572
573         new-run-webkit-tests: hardcode the directories to scan for tests
574         for GPU bots instead of SKIPping them. See bug 53562 for some
575         context, but we will now hard-code the list of directories to
576         use by default instead of skipping over directories in the
577         expectations file. We do this so that we will be able to merge
578         the expectations files without getting conflicting SKIP
579         directives. Note that this change will reduce the # of tests
580         being run on the Mac GPU bots, because we're accidentally
581         including some today.
582
583         https://bugs.webkit.org/show_bug.cgi?id=53631
584
585         * Scripts/webkitpy/layout_tests/port/base.py:
586         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
587         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
588
589 2011-02-02  Sam Weinig  <sam@webkit.org>
590
591         Reviewed by Beth Dakin.
592
593         Add ChromeClient function to paint custom overhang areas.
594         https://bugs.webkit.org/show_bug.cgi?id=53639
595
596         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
597         (WTR::InjectedBundlePage::InjectedBundlePage):
598         Stub out new callback.
599
600 2011-02-02  Dirk Pranke  <dpranke@chromium.org>
601
602         Reviewed by Tony Chang.
603
604         new-run-webkit-tests: support chromium code paths in mock_drt
605
606         https://bugs.webkit.org/show_bug.cgi?id=53471
607
608         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
609         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
610
611 2011-02-02  Adam Klein  <adamk@chromium.org>
612
613         Reviewed by Tony Chang.
614
615         Update new-run-webkit-tests --chromium to put output under Source/...
616         https://bugs.webkit.org/show_bug.cgi?id=53612
617
618         * BuildSlaveSupport/test-result-archive:
619         * Scripts/webkitpy/layout_tests/port/chromium.py:
620
621 2011-01-28  Tony Chang  <tony@chromium.org>
622
623         Reviewed by Eric Seidel.
624
625         [chromium] remove --use-test-shell from NRWT
626         https://bugs.webkit.org/show_bug.cgi?id=53346
627
628         I've already started removing some of the bindings like eventSender so
629         this already doesn't work isn't useful.  Also updated some comments to
630         refer to DRT instead of test_shell.
631
632         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
633         * Scripts/webkitpy/layout_tests/port/chromium.py:
634         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
635         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
636         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
637         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
638         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
639         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
640
641 2011-02-02  Steve Lacey  <sjl@chromium.org>
642
643         Reviewed by Eric Carlson.
644
645         Implement basic media statistics on media elements.
646         https://bugs.webkit.org/show_bug.cgi?id=53322
647
648         * Scripts/build-webkit:
649
650 2011-02-02  Kevin Ollivier  <kevino@theolliviers.com>
651
652         [wx] Build fixes for wxWebKit.
653
654         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
655         (LayoutTestController::setSerializeHTTPLoads):
656         * wx/browser/wscript:
657         * wx/build/build_utils.py:
658         * wx/build/settings.py:
659
660 2011-02-01  Dirk Pranke  <dpranke@chromium.org>
661
662         Reviewed by Mihai Parparita.
663
664         new-run-webkit-tests: stop skipping so many tests
665
666         r77163 introduced a regression where we weren't resetting test
667         expectations properly and were skipping too many tests as a
668         result. This patch fixes that and adds a test for it.
669
670         https://bugs.webkit.org/show_bug.cgi?id=53551
671
672         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
673         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
674
675 2011-02-01  Dirk Pranke  <dpranke@chromium.org>
676
677         Reviewed by Tony Chang.
678
679         new-run-webkit-tests: add first stub of test_runner2. This
680         will add support for the 'inline', 'threads', and 'processes'
681         flags to --worker-model, but for now the implementatios just
682         fall back on the old ones.
683
684         https://bugs.webkit.org/show_bug.cgi?id=53157
685
686         * Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
687         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
688
689 2011-02-01  Mihai Parparita  <mihaip@chromium.org>
690
691         Reviewed by James Robinson.
692
693         [Chromium] run-chromium-webkit-unit-tests looks for binaries in the wrong place
694         https://bugs.webkit.org/show_bug.cgi?id=53522
695
696         * Scripts/run-chromium-webkit-unit-tests:
697
698 2011-02-01  Adam Barth  <abarth@webkit.org>
699
700         Reviewed by Mihai Parparita.
701
702         Using Control-C to cancel webkit-patch or other python tools causes
703         unpleasant traceback console spew
704         https://bugs.webkit.org/show_bug.cgi?id=53462
705
706         Catch the exception and don't print the stack trace.
707
708         * Scripts/webkit-patch:
709
710 2011-02-01  Scott Cameron  <sccameron@rim.com>
711
712         Reviewed by Daniel Bates.
713
714         Use Windows format for MinGW HTTPD path.
715         https://bugs.webkit.org/show_bug.cgi?id=53503
716
717         * Scripts/webkitperl/httpd.pm:
718           - Use single-quotes around MySys value for $httpdPath in getHTTPDPath()
719             so that we don't have to escape the space characters in the path. Also,
720             changed path to Windows-style path and removed FIXME comment.
721
722 2011-02-01  Balazs Kelemen  <kbalazs@webkit.org>
723
724         Reviewed by Andreas Kling.
725
726         [Qt][WK2] Add a way to use shared process model in MiniBrowser
727         https://bugs.webkit.org/show_bug.cgi?id=53090
728
729         * MiniBrowser/qt/BrowserView.cpp:
730         (BrowserView::BrowserView): Removed the m_context member.
731         From now the context is guaranteed to be non-null and we
732         don't need to store that in the object.
733         * MiniBrowser/qt/BrowserView.h:
734         * MiniBrowser/qt/BrowserWindow.cpp:
735         Added static bool to determine that new windows need to be
736         created with their own context or not. Use the same context
737         and web process by default to be inilne with the other ports.
738         (BrowserWindow::BrowserWindow):
739         (BrowserWindow::newWindow):
740         * MiniBrowser/qt/BrowserWindow.h:
741         * MiniBrowser/qt/main.cpp:
742         (main): Added command line switch to be able to use the
743         non-shared process model. Simplify the handling of the command line
744         switches a little bit.
745
746 2011-02-01  Zoltan Horvath  <zoltan@webkit.org>
747
748         Reviewed by Andreas Kling.
749
750         [Qt] Add Window menu and Toggle FullScreen action to MiniBrowser.
751         https://bugs.webkit.org/show_bug.cgi?id=53491
752
753         * MiniBrowser/qt/BrowserWindow.cpp:
754         (BrowserWindow::BrowserWindow):
755         (BrowserWindow::toggleFullScreenMode):
756         * MiniBrowser/qt/BrowserWindow.h:
757
758 2011-02-01  Zoltan Horvath  <zoltan@webkit.org>
759
760         Reviewed by Andreas Kling.
761
762         [Qt] Add Toggle Frame Flattening, Auto Load Images and Disable JavaScript actions to MiniBrowser.
763         https://bugs.webkit.org/show_bug.cgi?id=53489
764
765         Add Toggle Frame Flattening action to Develop menu. Add Auto Load Images and Disable JavaScript actions
766         to Settings menu.
767
768         * MiniBrowser/qt/BrowserWindow.cpp:
769         (BrowserWindow::BrowserWindow):
770         (BrowserWindow::toggleFrameFlattening):
771         (BrowserWindow::toggleDisableJavaScript):
772         (BrowserWindow::toggleAutoLoadImages):
773         * MiniBrowser/qt/BrowserWindow.h:
774
775 2011-01-31  Mihai Parparita  <mihaip@chromium.org>
776
777         Reviewed by Tony Chang.
778
779         [Chromium] Switch chromium-mac to use ChromiumDriver
780         https://bugs.webkit.org/show_bug.cgi?id=53461
781         
782         For the sake of consistency with the other Chromium platforms (and so
783         that chromium-mac picks up special flags like --enable-hardware-gpu),
784         switch chromium-mac from the WebKitDriver to ChromiumDriver.
785
786         * Scripts/webkitpy/layout_tests/port/chromium.py:
787
788 2011-01-31  Dirk Pranke  <dpranke@chromium.org>
789
790         Reviewed by Mihai Parparita.
791
792         The current modifier parsing code in test_expectations is
793         fragile and hard-coded, so it's not easy to understand the logic
794         or easily add new types of modifiers (like GPU vs. CPU testing
795         for graphics tests, or 32-bit vs. 64-bit differences).
796
797         This is the first of two patches that will add in more generic
798         support and then eliminate the GPU-specific test expectations
799         files for Chromium.
800
801         This patch adds two standalone objects for handling modifiers. The
802         rules for interpreting modifiers, precedence, and conflicts are
803         given in the docstring to the ModifierMatcher class, which
804         returns ModifierMatchResult objects.
805         
806         This patch also adds routines to the Port interface and a
807         default set of values in the base object, in order to obtain the
808         values needed on a given test run. These values are then passed
809         to the expectation parser. This also allows us to clean up the
810         logic used to lint all of the different configurations in a
811         single test_expectations.txt file.
812
813         The next patch will merge in the separate GPU expectations file.
814
815         https://bugs.webkit.org/show_bug.cgi?id=51222
816
817         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
818         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
819         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
820         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
821         * Scripts/webkitpy/layout_tests/port/base.py:
822         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
823         * Scripts/webkitpy/layout_tests/port/chromium.py:
824         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
825         * Scripts/webkitpy/layout_tests/port/test.py:
826         * Scripts/webkitpy/layout_tests/port/webkit.py:
827         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
828         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
829         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
830         * Tools/Scripts/webkitpy/style/checkers/test_expectations.py:
831         * Tools/Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
832
833 2011-01-31  Scott Cameron  <sccameron@rim.com>
834
835         Reviewed by Daniel Bates.
836
837         update run-webkit-httpd to be able to launch Apache2.2 in a MSYS environment
838         https://bugs.webkit.org/show_bug.cgi?id=50036
839
840         This will add an Apache2.2 configuration file and modifies scripts to allow
841         running an httpd server in an MSYS environment.
842
843         The default Apache2.2 installation path has been preserved and PHP5 modules disabled
844         in order to allow for simple installation/execution.  Simply install the latest
845         Apache2.2 version with OpenSSL from http://httpd.apache.org/download.cgi#apache22 to
846         be able to execute run-webkit-httpd.
847         
848
849         * Scripts/run-webkit-httpd:
850         * Scripts/webkitperl/httpd.pm:
851
852 2011-01-31  Tony Chang  <tony@chromium.org>
853
854         Reviewed by Eric Seidel.
855
856         mac DRT should report RTL scroll offset relative to top right corner
857         https://bugs.webkit.org/show_bug.cgi?id=53324
858
859         * DumpRenderTree/mac/DumpRenderTree.mm:
860         (dumpFrameScrollPosition):
861
862 2011-01-31  Zoltan Horvath  <zoltan@webkit.org>
863
864         Reviewed by Andreas Kling.
865
866         [Qt] Add Take Screen Shot action to MiniBrowser
867         https://bugs.webkit.org/show_bug.cgi?id=53422
868
869         Add Take Screen Shot action to MiniBrowser's view menu.
870
871         * MiniBrowser/qt/BrowserWindow.cpp:
872         (BrowserWindow::BrowserWindow):
873         (BrowserWindow::screenshot):
874         * MiniBrowser/qt/BrowserWindow.h:
875
876 2011-01-31  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
877
878         Reviewed by Xan Lopez.
879
880         [GTK] REGRESSION:  http/tests/media/video-{cookie,referer}.html failing
881         https://bugs.webkit.org/show_bug.cgi?id=53379
882
883         Remove left over #ifdef's. I thought all of the conditional code
884         had been freed from the condition, but I forgot to check DRT.
885
886         * DumpRenderTree/gtk/DumpRenderTree.cpp:
887         (resetDefaultsToConsistentValues):
888         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
889         (LayoutTestController::setAlwaysAcceptCookies):
890
891 2011-01-30  Dirk Pranke  <dpranke@chromium.org>
892
893         Unreviewed, build fix.
894
895         Fix regression introduced in r77093 - path.rsplit() doesn't
896         take keyword arguments.
897
898         https://bugs.webkit.org/show_bug.cgi?id=53326
899
900         * Scripts/webkitpy/common/system/filesystem_mock.py:
901
902 2011-01-30  Dirk Pranke  <dpranke@chromium.org>
903
904         Reviewed by Mihai Parparita.
905
906         Add more unit tests for rebaseline-chromium-webkit-tests. This
907         change involves restructuring a bunch of r-c-w-t code to make it
908         more testable as well. We also add wrapper classes for handling
909         testing zip files and fetching URLs.
910
911         https://bugs.webkit.org/show_bug.cgi?id=53040
912
913         * Scripts/webkitpy/common/system/urlfetcher.py:
914         * Scripts/webkitpy/common/system/urlfetcher_mock.py:
915         * Scripts/webkitpy/common/system/zipfileset_mock.py:
916         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
917         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
918         * Scripts/webkitpy/tool/mocktool.py:
919
920 2011-01-30  Dirk Pranke  <dpranke@chromium.org>
921
922         Reviewed by Eric Seidel.
923
924         Clean up of the filesystem-related modules used in webkitpy.
925         I've added relpath() to the filesystem interface, modified
926         ospath.relpath() so that it could work with the filesystem
927         interface, and modified the fileset* routines to use the
928         filesystem interface consistently.
929
930         This patch also adds a close() routine to the fileset routines
931         to indicate that the caller is done with the fileset. This
932         allows zipfileset to clean up after itself when it creates
933         tempfiles to store downloads.
934
935         https://bugs.webkit.org/show_bug.cgi?id=53326
936
937         * Scripts/webkitpy/common/system/directoryfileset.py:
938         * Scripts/webkitpy/common/system/fileset.py:
939         * Scripts/webkitpy/common/system/filesystem.py:
940         * Scripts/webkitpy/common/system/filesystem_mock.py:
941         * Scripts/webkitpy/common/system/filesystem_unittest.py:
942         * Scripts/webkitpy/common/system/ospath.py:
943         * Scripts/webkitpy/common/system/zipfileset.py:
944         * Scripts/webkitpy/common/system/zipfileset_unittest.py:
945
946 2011-01-30  Balazs Kelemen  <kbalazs@webkit.org>
947
948         Reviewed by Csaba Osztrogonác.
949
950         [Qt][WK2]REGRESSION (r76991): Fix build errors
951         https://bugs.webkit.org/show_bug.cgi?id=53400
952
953         Revert the temporary build fix (http://trac.webkit.org/changeset/77088)
954         and remove WebKit2Prefix.h from the build.
955         * MiniBrowser/qt/MiniBrowser.pro:
956
957 2011-01-30  Csaba Osztrogonác  <ossy@webkit.org>
958
959         Unreviewed.
960
961         [Qt][WK2] Buildfix.
962
963         * MiniBrowser/qt/MiniBrowser.pro:
964
965 2011-01-28  Simon Fraser  <simon.fraser@apple.com>
966
967         Reviewed by Adam Roben.
968         
969         define NOMINMAX when building ImageDiff, as we do elsewhere.
970
971         Add various clampToInt() methods to MathExtras.h
972         https://bugs.webkit.org/show_bug.cgi?id=52910
973
974         * DumpRenderTree/win/ImageDiffCommon.vsprops:
975
976 2011-01-28  Maciej Stachowiak  <mjs@apple.com>
977
978         Reviewed by Darin Adler.
979
980         WebKitTestRunner needs layoutTestController.setPOSIXLocale
981         https://bugs.webkit.org/show_bug.cgi?id=42682
982
983         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
984         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
985         (WTR::InjectedBundle::resetLocalSettings):
986         (WTR::InjectedBundle::didReceiveMessage):
987         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
988         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
989         (WTR::LayoutTestController::setPOSIXLocale):
990         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
991
992 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
993  
994          Reviewed by Mihai Parparita.
995  
996          test-webkitpy: fix webkitpy.layout_tests.port.mac_unittest.MacTest.test_skipped_file_paths
997  
998          This patch re-enables this test and changes it to
999          handle all of the mac platform versions, not just the one
1000          it is running on.
1001  
1002          https://bugs.webkit.org/show_bug.cgi?id=53356
1003  
1004          * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1005  
1006 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
1007
1008         Unreviewed, build fix.
1009
1010         Take two. The fix in 77023 didn't work, because we were
1011         still calling path.abspath_to_uri, which calls _cygpath under
1012         the covers, and it appears the cygpath on the bots does
1013         something different than it does on my machine. This patch
1014         removes the calls to path.abspath_to_uri, so it should be safe.
1015         If it doesn't work, I'll roll it out along with r76982 and 77023.
1016
1017         https://bugs.webkit.org/show_bug.cgi?id=53126
1018
1019         * Scripts/webkitpy/layout_tests/port/test.py:
1020
1021 2011-01-28  David Kilzer  <ddkilzer@apple.com>
1022
1023         <rdar://problem/8930699> build-webkit gives a bogus warning with newer versions of Xcode 
1024         <http://webkit.org/b/53353>
1025
1026         Reviewed by Mark Rowe.
1027
1028         * Scripts/webkitdirs.pm:
1029         (checkRequiredSystemConfig): Check the Xcode marketing version
1030         in addition to the DevCoreTools build version before complaining
1031         about an old version of Xcode.  Also make the Mac OS X version
1032         check use Perl's built-in version string comparitor.
1033
1034 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
1035
1036         Unreviewed, build fix.
1037
1038         Work around breakage on Win 7 Release bot caused by r76982
1039         and the fact that windows ports use "file:////" instead of
1040         "file:///". Ideally the test code should be isolated from
1041         this, but it isn't yet. Will fix properly in a bit.
1042
1043         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
1044
1045 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
1046
1047         Reviewed by Tony Chang.
1048
1049         new-run-webkit-tests: change worker model values to
1050         "old-inline", "old-threads" in preparation for test_runner2 /
1051         multiprocessing changes.
1052
1053         https://bugs.webkit.org/show_bug.cgi?id=53156
1054
1055         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1056         * Scripts/webkitpy/layout_tests/port/base.py:
1057         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1058         * Scripts/webkitpy/layout_tests/port/mac.py:
1059         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1060
1061 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
1062
1063         Reviewed by Tony Chang.
1064
1065         committers.py - add an IRC nickname for dpranke
1066         https://bugs.webkit.org/show_bug.cgi?id=53335
1067
1068         * Scripts/webkitpy/common/config/committers.py:
1069
1070 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
1071
1072         Reviewed by Tony Chang.
1073
1074         new-run-webkit-tests: add a "mock DRT" port implementation
1075         and a separate class that emulates what we expect the
1076         DumpRenderTree behavior to be.
1077
1078         This will eventually replace port/dryrun.py and allow us to get
1079         better test coverage of the new-run-webkit-tests code as well as
1080         a reference for what new-run-webkit-tests expects from DRT.
1081
1082         This is the first attempt at this, and it is pretty bare-boned. It
1083         really only has been tested on the 'mac' port (and a little on
1084         the 'chromium-mac' port.
1085
1086         https://bugs.webkit.org/show_bug.cgi?id=53126
1087
1088         * Scripts/webkitpy/common/system/filesystem_mock.py:
1089         * Scripts/webkitpy/layout_tests/port/dryrun.py:
1090         * Scripts/webkitpy/layout_tests/port/factory.py:
1091         * Scripts/webkitpy/layout_tests/port/mock_drt.py: Added.
1092         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Added.
1093         * Scripts/webkitpy/layout_tests/port/test.py:
1094
1095 2011-01-28  Pratik Solanki  <psolanki@apple.com>
1096
1097         Unreviewed. Removing .swp file checked in by mistake.
1098
1099         * Scripts/.webkitdirs.pm.swp: Removed.
1100
1101 2011-01-28  Pratik Solanki  <psolanki@apple.com>
1102
1103         Reviewed by David Kilzer.
1104
1105         Space not necessary for undefined feature
1106         https://bugs.webkit.org/show_bug.cgi?id=53317
1107
1108         * Scripts/build-webkit:
1109
1110 2011-01-28  Chang Shu  <chang.shu@nokia.com>
1111
1112         Reviewed by Andreas Kling.
1113
1114         Reset NetworkAccessManager to clean up credentials from previous tests.
1115         This change causes no performance overhead either.
1116         https://bugs.webkit.org/show_bug.cgi?id=36688
1117
1118         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1119         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1120         (WebCore::DumpRenderTree::open):
1121         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1122
1123 2011-01-28  Zoltan Horvath  <zoltan@webkit.org>
1124
1125         Reviewed by Andreas Kling.
1126
1127         [Qt] Add Zoom Text Only action to MiniBrowser
1128         https://bugs.webkit.org/show_bug.cgi?id=53297
1129
1130         Add Zoom Text Only action to MiniBrowser's view menu, change zoom levels to avoid unnecessary divides.
1131
1132         * MiniBrowser/qt/BrowserWindow.cpp:
1133         (BrowserWindow::BrowserWindow):
1134         (BrowserWindow::zoomIn):
1135         (BrowserWindow::zoomOut):
1136         (BrowserWindow::resetZoom):
1137         (BrowserWindow::toggleZoomTextOnly):
1138         (BrowserWindow::applyZoom):
1139         * MiniBrowser/qt/BrowserWindow.h:
1140
1141 2011-01-28  Adam Barth  <abarth@webkit.org>
1142
1143         Reviewed by Eric Seidel.
1144
1145         Add webkit-patch roll-chromium-deps
1146         https://bugs.webkit.org/show_bug.cgi?id=53288
1147
1148         This command updates the Source/WebKit/chromium/DEPS file with the
1149         last-known good revision of Chromium (or a revision specified on the
1150         command line).  I'd eventually like to turn this into a SheriffBot
1151         command, but this is the first step.
1152
1153         This patch somewhat sprawled because I needed to move a bunch of code
1154         out of ChangeLog that should never have been there in the first place.
1155         Also, I had to fix a bug in MockUser in order to test the new command.
1156
1157         * Scripts/webkitpy/common/checkout/api.py:
1158         * Scripts/webkitpy/common/checkout/changelog.py:
1159         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1160         * Scripts/webkitpy/common/checkout/deps.py: Added.
1161         * Scripts/webkitpy/common/config/urls.py:
1162         * Scripts/webkitpy/tool/commands/__init__.py:
1163         * Scripts/webkitpy/tool/commands/download_unittest.py:
1164         * Scripts/webkitpy/tool/commands/roll.py: Added.
1165         * Scripts/webkitpy/tool/commands/roll_unittest.py: Added.
1166         * Scripts/webkitpy/tool/commands/upload_unittest.py:
1167         * Scripts/webkitpy/tool/mocktool.py:
1168         * Scripts/webkitpy/tool/steps/__init__.py:
1169         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py: Added.
1170         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
1171         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py: Added.
1172         * Scripts/webkitpy/tool/steps/suggestreviewers_unittest.py:
1173         * Scripts/webkitpy/tool/steps/updatechromiumdeps.py: Added.
1174         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
1175
1176 2011-01-27  Greg Coletta  <greg.coletta@nokia.com>
1177
1178         Reviewed by Laszlo Gombos.
1179
1180         Get rid of prefix header dependency for WebKit2 build system
1181         https://bugs.webkit.org/show_bug.cgi?id=50174
1182
1183         Change the style checker so that it enforces config.h include for
1184         WebKit2.
1185
1186         * Scripts/webkitpy/style/checker.py:
1187
1188 2011-01-27  Maciej Stachowiak  <mjs@apple.com>
1189
1190         Reviewed by Darin Adler.
1191
1192         execCommand("Paste") doesn't work in WebKitTestRunner
1193         https://bugs.webkit.org/show_bug.cgi?id=52785
1194
1195         Enable both of the settings needed to allow paste.
1196         
1197         * WebKitTestRunner/TestController.cpp:
1198         (WTR::TestController::resetStateToConsistentValues):
1199
1200 2011-01-27  Jacob Dinu  <dinu.jacob@nokia.com>
1201
1202         Reviewed by Andreas Kling.
1203
1204         [Qt] QtTestBrowser: User input lost when toggling use of QGraphicsView
1205         https://bugs.webkit.org/show_bug.cgi?id=48440
1206
1207         Preserve user input when toggling use of QGraphicsView
1208
1209         * QtTestBrowser/launcherwindow.cpp:
1210         (LauncherWindow::initializeView):
1211         (LauncherWindow::loadFinished):
1212         * QtTestBrowser/launcherwindow.h:
1213         * QtTestBrowser/mainwindow.cpp:
1214         (MainWindow::addressUrl):
1215         * QtTestBrowser/mainwindow.h:
1216
1217 2011-01-27  Dirk Pranke  <dpranke@chromium.org>
1218
1219         Reviewed by Mihai Parparita.
1220
1221         new-run-webkit-tests: turn off pixel tests correctly by default
1222         for webkit-based ports. r70013 (bug 47510) used
1223         port.set_option_default() to attempt to set default values, but
1224         that didn't work correctly. I have removed set_option_default
1225         for now since it was only being used in two places and in three
1226         useless unit tests. There is a separate bug open to fix the
1227         option parsing (48095), so this workaround is fine for now.
1228
1229         https://bugs.webkit.org/show_bug.cgi?id=53217
1230
1231         * Scripts/webkitpy/layout_tests/port/webkit.py:
1232         * Scripts/webkitpy/layout_tests/port/base.py:
1233         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1234
1235 2011-01-27  Balazs Kelemen  <kbalazs@webkit.org>
1236
1237         Rubber-stamped by Ariya Hidayat.
1238
1239         Trivial crash fix in WTR.
1240
1241         * WebKitTestRunner/TestController.cpp:
1242         (WTR::TestController::initialize): Increase the size
1243         of the vector by one to be able to store the null character.
1244
1245 2011-01-27  Balazs Kelemen  <kbalazs@webkit.org>
1246
1247         Reviewed by Csaba Osztrogonác.
1248
1249         [Qt][WK2] WTR should be initialized in the same way as DRT
1250         https://bugs.webkit.org/show_bug.cgi?id=53240
1251
1252         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
1253         (WTR::activateFonts): Added missing initialization steps.
1254
1255 2011-01-27  Joone Hur <joone.hur@collabora.co.uk>
1256
1257         Unreviewed. 
1258
1259         Adding myself to committers.py.
1260
1261         * Scripts/webkitpy/common/config/committers.py:
1262
1263 2011-01-27  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1264
1265         Reviewed by Csaba Osztrogonác.
1266
1267         [Qt] [Symbian] Move project files into Source
1268         https://bugs.webkit.org/show_bug.cgi?id=52891
1269
1270         Fix the Symbian build after the project files
1271         are moved to Source directory. On Symbian qmake
1272         needs to run in the same directory where the main
1273         pro files (WebKit.pro, Tools.pro) are located.
1274
1275         * Scripts/webkitdirs.pm: Change to the directory where the pro file
1276         is located before running qmake for Symbian. Qmake on Symbian
1277         does not properly honor the "-o" option, work it around by setting
1278         the name of the Makefile to bld.inf.
1279
1280 2011-01-27  Zoltan Horvath  <zoltan@webkit.org>
1281
1282         Reviewed by Andreas Kling.
1283
1284         [Qt] Add simple zooming features to MiniBrowser
1285         https://bugs.webkit.org/show_bug.cgi?id=53231
1286
1287         Add View menu and Zoom In, Zoom Out, Zoom Reset actions to MiniBrowser.
1288
1289         * MiniBrowser/qt/BrowserWindow.cpp:
1290         (BrowserWindow::BrowserWindow):
1291         (BrowserWindow::zoomIn):
1292         (BrowserWindow::zoomOut):
1293         (BrowserWindow::resetZoom):
1294         (BrowserWindow::updateUserAgentList):
1295         (BrowserWindow::applyZoom):
1296         * MiniBrowser/qt/BrowserWindow.h:
1297
1298 2011-01-26  Maciej Stachowiak  <mjs@apple.com>
1299
1300         Reviewed by Dan Bernstein.
1301
1302         WebKitTestRunner needs to support layoutTestController.evaluateInWebInspector
1303         https://bugs.webkit.org/show_bug.cgi?id=42319
1304         
1305         Add evaluateInWebInspector and other APIs needed for inspector tests to run.
1306
1307         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1308         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1309         (WTR::LayoutTestController::showWebInspector):
1310         (WTR::LayoutTestController::closeWebInspector):
1311         (WTR::LayoutTestController::evaluateInWebInspector):
1312         (WTR::LayoutTestController::setTimelineProfilingEnabled):
1313         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1314         * WebKitTestRunner/TestInvocation.cpp:
1315         (WTR::shouldOpenWebInspector):
1316         (WTR::TestInvocation::invoke):
1317         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
1318
1319 2011-01-26  Martin Robinson  <mrobinson@igalia.com>
1320
1321         Reviewed by Xan Lopez.
1322
1323         [GTK] Pixel dumps do not include scrollbars in output images
1324         https://bugs.webkit.org/show_bug.cgi?id=53216
1325
1326         Show scrollbars in pixel dumps. This will fix pixel dumps for tests
1327         that have scrollbars.
1328
1329         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
1330         (createBitmapContextFromWebView): Take the snapshot of the containing GtkScrolledWindow
1331         instead of the web view itself.
1332
1333 2011-01-26  Dirk Pranke  <dpranke@chromium.org>
1334
1335         Reviewed by Mihai Parparita.
1336
1337         Fix regression introduced in r76322 ... new-run-webkit-tests
1338         was attempting to save the image diff output as a UTF-8-encoded
1339         file.
1340
1341         https://bugs.webkit.org/show_bug.cgi?id=53210
1342
1343         * Scripts/webkitpy/layout_tests/port/webkit.py:
1344
1345 2011-01-26  Sheriff Bot  <webkit.review.bot@gmail.com>
1346
1347         Unreviewed, rolling out r76709.
1348         http://trac.webkit.org/changeset/76709
1349         https://bugs.webkit.org/show_bug.cgi?id=53194
1350
1351         "broke python tests on non-snowleopard platforms" (Requested
1352         by dpranke on #webkit).
1353
1354         * Scripts/webkitpy/layout_tests/port/factory.py:
1355         * Scripts/webkitpy/layout_tests/port/mock_drt.py: Removed.
1356         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Removed.
1357
1358 2011-01-26  Dirk Pranke  <dpranke@chromium.org>
1359
1360         Reviewed by Tony Chang.
1361
1362         new-run-webkit-tests: add a "mock DRT" port implementation
1363         and a separate class that emulates what we expect the
1364         DumpRenderTree behavior to be.
1365
1366         This will eventually replace port/dryrun.py and allow us to get
1367         better test coverage of the new-run-webkit-tests code as well as
1368         a reference for what new-run-webkit-tests expects from DRT.
1369
1370         This is the first attempt at this, and it is pretty bare-boned. It
1371         really only has been tested on the 'mac' port (and a little on
1372         the 'chromium-mac' port.
1373
1374         https://bugs.webkit.org/show_bug.cgi?id=53126
1375
1376         * Scripts/webkitpy/layout_tests/port/mock_drt.py: Added.
1377         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Added.
1378         * Scripts/webkitpy/layout_tests/port/factory.py:
1379
1380 2011-01-26  Xianzhu Wang  <wangxianzhu@google.com>
1381
1382         Reviewed by Tony Chang.
1383
1384         Add '--no-timeout' option to Chromium DRT to ease debugging.
1385         https://bugs.webkit.org/show_bug.cgi?id=52873
1386
1387         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1388         (main):
1389
1390 2011-01-26  Csaba Osztrogonác  <ossy@webkit.org>
1391
1392         Reviewed by Andreas Kling.
1393
1394         [Qt] Fix qt_minimal build
1395         https://bugs.webkit.org/show_bug.cgi?id=53172
1396
1397         * QtTestBrowser/locationedit.h:
1398
1399 2011-01-26  Mansi Mithal  <mansi.mithal@nokia.com>
1400
1401         Reviewed by Antonio Gomes.
1402
1403         QtTestBrowser should have a UI Setting to disable plugins
1404         https://bugs.webkit.org/show_bug.cgi?id=52408
1405         
1406         Added a new action item named "Disable Plugins"
1407         under the "Settings" menu. 
1408
1409         * QtTestBrowser/launcherwindow.cpp:
1410         (LauncherWindow::createChrome):
1411         (LauncherWindow::togglePlugins):
1412         * QtTestBrowser/launcherwindow.h:
1413
1414 2011-01-25  Patrick Gansterer  <paroga@webkit.org>
1415
1416         Reviewed by Adam Barth.
1417
1418         Move main CMakeLists.txt into Source directory
1419         https://bugs.webkit.org/show_bug.cgi?id=52888
1420
1421         * Scripts/webkitdirs.pm:
1422
1423 2011-01-25  Patrick Gansterer  <paroga@webkit.org>
1424
1425         Reviewed by Eric Seidel.
1426
1427         Improve label text in submit-to-ews
1428         https://bugs.webkit.org/show_bug.cgi?id=53130
1429
1430         * QueueStatusServer/templates/submittoews.html:
1431
1432 2011-01-25  Mansi Mithal  <mansi.mithal@nokia.com>
1433
1434         Reviewed by Antonio Gomes.
1435
1436         QtTestBrowser should have a UI Settings to prevent loading images
1437         https://bugs.webkit.org/show_bug.cgi?id=52409
1438         
1439         Added a new action item named "DisableAutoLoadImages"
1440         under the "Settings" menu 
1441
1442         * QtTestBrowser/launcherwindow.cpp:
1443         (LauncherWindow::createChrome):
1444         (LauncherWindow::toggleAutoLoadImages):
1445         * QtTestBrowser/launcherwindow.h:
1446
1447 2011-01-25  Dirk Pranke  <dpranke@chromium.org>
1448
1449         Reviewed by Tony Chang.
1450
1451         Minor bug fixes and cleanup for filesystem wrappers, port/* test
1452         classes, test_expectations.py. This change adds "test-win" and
1453         "test-mac" variants to the test port so that we can better test
1454         rebaselining, and adds a MockUser() object for reuse in testing.
1455
1456         https://bugs.webkit.org/show_bug.cgi?id=53036
1457
1458         * Scripts/webkitpy/common/system/filesystem.py:
1459         * Scripts/webkitpy/common/system/filesystem_mock.py:
1460         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1461         * Scripts/webkitpy/layout_tests/port/factory.py:
1462         * Scripts/webkitpy/layout_tests/port/base.py:
1463         * Scripts/webkitpy/layout_tests/port/test.py:
1464         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1465         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
1466         * Scripts/webkitpy/tool/mocktool.py:
1467
1468 2011-01-25  Tony Chang  <tony@chromium.org>
1469
1470         Reviewed by Dimitri Glazkov.
1471
1472         [chromium] remove unused layoutTestController callback
1473         https://bugs.webkit.org/show_bug.cgi?id=53103
1474
1475         This method is used by a test_shell_test, but not needed by DRT.
1476
1477         * DumpRenderTree/chromium/LayoutTestController.cpp:
1478         (LayoutTestController::LayoutTestController):
1479         * DumpRenderTree/chromium/LayoutTestController.h:
1480
1481 2011-01-25  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1482
1483         Reviewed by Andreas Kling.
1484
1485         [GTK] Remove 64 bits release bot from the buildbot master
1486         https://bugs.webkit.org/show_bug.cgi?id=52899
1487
1488         Removes the 64 bits release slave from the buildbot configuration,
1489         so that we can use it as an EWS.
1490
1491         * BuildSlaveSupport/build.webkit.org-config/config.json:
1492
1493 2011-01-24  Maciej Stachowiak  <mjs@apple.com>
1494
1495         Reviewed by Dan Bernstein.
1496
1497         Implement database quota callback to fix storage tests on WebKit2 bot
1498         https://bugs.webkit.org/show_bug.cgi?id=53064
1499
1500         * WebKitTestRunner/TestController.cpp:
1501         (WTR::exceededDatabaseQuota):
1502         (WTR::TestController::createOtherPage):
1503         (WTR::TestController::initialize):
1504
1505 2011-01-24  Maciej Stachowiak  <mjs@apple.com>
1506
1507         Reviewed by Anders Carlsson.
1508
1509         Use designated temp directory for the database for WebKit2
1510         https://bugs.webkit.org/show_bug.cgi?id=53052
1511         
1512         Adopt the new WK2 API for this.
1513
1514         * WebKitTestRunner/TestController.cpp:
1515         (WTR::TestController::libraryPathForTesting):
1516         (WTR::TestController::initialize):
1517         * WebKitTestRunner/TestController.h:
1518         * WebKitTestRunner/mac/TestControllerMac.mm:
1519         (WTR::TestController::platformLibraryPathForTesting):
1520         * WebKitTestRunner/qt/TestControllerQt.cpp:
1521         (WTR::TestController::platformLibraryPathForTesting):
1522         * WebKitTestRunner/win/TestControllerWin.cpp:
1523         (WTR::TestController::platformLibraryPathForTesting):
1524
1525 2011-01-24  Lucas Forschler  <lforschler@apple.com>
1526
1527         Reviewed by Stephanie Lewis.
1528
1529         Add a new Leopard test bot.
1530
1531         * BuildSlaveSupport/build.webkit.org-config/config.json:
1532
1533 2011-01-24  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1534
1535         Reviewed by Adam Barth.
1536
1537         Add EFL Builder to core waterfall
1538         https://bugs.webkit.org/show_bug.cgi?id=52704
1539
1540         Add EFL Builder to the core waterfall again.
1541
1542         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1543         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1544
1545 2011-01-24  Xianzhu Wang  <wangxianzhu@google.com>
1546
1547         Reviewed by Tony Chang.
1548
1549         new-run-webkit-tests fails to start HTTP server if there are proxy settings
1550         https://bugs.webkit.org/show_bug.cgi?id=52872
1551
1552         Force disabling proxy to resolve the problem.
1553
1554         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
1555         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
1556
1557 2011-01-24  Andreas Kling  <kling@webkit.org>
1558
1559         Reviewed by Darin Adler.
1560
1561         check-webkit-style: Update exemptions following Source/ move.
1562         https://bugs.webkit.org/show_bug.cgi?id=53017
1563
1564         * Scripts/webkitpy/style/checker.py:
1565         * Scripts/webkitpy/style/checker_unittest.py:
1566
1567 2011-01-24  Andras Becsi  <abecsi@webkit.org>
1568
1569         Rubber-stamped by Csaba Osztrogonác.
1570
1571         [Qt] Move project files into Source
1572         https://bugs.webkit.org/show_bug.cgi?id=52891
1573
1574         * DumpRenderTree/qt/ImageDiff.pro: Add missing "Source" to WebKit.pri path
1575
1576 2011-01-24  Mikhail Naganov  <mnaganov@chromium.org>
1577
1578         Reviewed by Yury Semikhatsky.
1579
1580         Web Inspector: Find duplicate strings in localizedStrings.js
1581
1582         https://bugs.webkit.org/show_bug.cgi?id=53005
1583
1584         * Scripts/check-inspector-strings:
1585
1586 2011-01-24  Zoltan Horvath  <zoltan@webkit.org>
1587
1588         Reviewed by Andreas Kling.
1589
1590         [Qt] Regroup MiniBrowser's menubar and add open file action
1591         https://bugs.webkit.org/show_bug.cgi?id=53000
1592
1593         Add File and Develop menu to MiniBrowser's menubar and add open file action to File menu.
1594
1595         * MiniBrowser/qt/BrowserWindow.cpp:
1596         (BrowserWindow::BrowserWindow):
1597         (BrowserWindow::openFile):
1598         (BrowserWindow::~BrowserWindow):
1599         * MiniBrowser/qt/BrowserWindow.h:
1600
1601 2011-01-24  Csaba Osztrogonác  <ossy@webkit.org>
1602
1603         Unreviewed fix after r76496
1604
1605         [Qt] Move project files into Source
1606         https://bugs.webkit.org/show_bug.cgi?id=52891
1607
1608         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Remove unnecessary "Source" from the path.
1609         * BuildSlaveSupport/built-product-archive: Remove unnecessary "Source" from the path.
1610         * Scripts/webkitdirs.pm: Add the accidentally removed slash to the path.
1611
1612 2011-01-24  Andras Becsi  <abecsi@webkit.org>
1613
1614         Reviewed by Csaba Osztrogonác.
1615
1616         [Qt] Move project files into Source
1617         https://bugs.webkit.org/show_bug.cgi?id=52891
1618
1619         * DerivedSources.pro: Renamed from DerivedSources.pro.
1620         * DumpRenderTree/qt/DumpRenderTree.pro:
1621         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1622         * MiniBrowser/DerivedSources.pro:
1623         * MiniBrowser/qt/MiniBrowser.pro:
1624         * QtTestBrowser/QtTestBrowser.pro:
1625         * Scripts/webkitdirs.pm:
1626         * Tools.pro: Added.
1627         * WebKitTestRunner/DerivedSources.pro:
1628         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1629         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1630
1631 2011-01-22  Geoffrey Garen  <ggaren@apple.com>
1632
1633         Reviewed by Dan Bernstein.
1634
1635         Beefed up --threaded mode to catch even more kinds of errors.
1636         https://bugs.webkit.org/show_bug.cgi?id=52971
1637
1638         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Use a shared
1639         context group to force JSC to mark multiple threads. (This used to be
1640         the default, but it changed in SnowLeopard.)
1641         (runJavaScriptThread): Do more locking and unlocking, and more allocation,
1642         to give threading mistakes more chances to show themselves.
1643         (startJavaScriptThreads):
1644         (stopJavaScriptThreads):
1645
1646 2011-01-22  Robert Hogan  <robert@webkit.org>
1647
1648         Reviewed by Andreas Kling.
1649
1650         [Qt] Support layoutTestController.addURLToRedirect()
1651         https://bugs.webkit.org/show_bug.cgi?id=52956
1652
1653         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1654         (LayoutTestController::addURLToRedirect):
1655         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1656
1657 2011-01-22  Robert Hogan  <robert@webkit.org>
1658
1659         Reviewed by Kenneth Rohde Christiansen.
1660
1661         [Qt] REGRESSION (r72360): http/tests/security/aboutBlank/xss-DENIED-* tests fail
1662         https://bugs.webkit.org/show_bug.cgi?id=49802
1663
1664         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1665         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1666         (WebCore::DumpRenderTree::open):
1667
1668 2011-01-21  Adam Barth  <abarth@webkit.org>
1669
1670         Reviewed by Maciej Stachowiak.
1671
1672         Disable mac_unittest.py that fails on some of the Mac bots
1673         https://bugs.webkit.org/show_bug.cgi?id=52947
1674
1675         As noted in the comment, this test does not appear to be correct
1676         because the function this test is testing returns different results
1677         depending on which flavor of Mac the test is run on.  This patch
1678         disable the test.  Hopefully we can re-enable the test once we've
1679         probably insulated the test from its environment.
1680
1681         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1682
1683 2011-01-21  Dirk Pranke  <dpranke@chromium.org>
1684
1685         Reviewed by Mihai Parparita.
1686
1687         Fix bug introduced in r76322 that caused NRWT to not actually
1688         read the Skipped files properly.
1689
1690         https://bugs.webkit.org/show_bug.cgi?id=52771
1691
1692         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1693         * Scripts/webkitpy/layout_tests/port/webkit.py:
1694         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1695
1696 2011-01-21  Sam Weinig  <sam@webkit.org>
1697
1698         Reviewed by Geoffrey Sean Garen and Mark Rowe.
1699
1700         WebKitTestRunner needs the HOME environment variable to be set.
1701         <rdar://problem/8896573>
1702
1703         * Scripts/old-run-webkit-tests: Set the HOME environment variable if
1704         it exists.
1705
1706 2011-01-21  Dirk Pranke  <dpranke@chromium.org>
1707
1708         Reviewed by Eric Seidel.
1709
1710         Suppress a few remaining integration tests so that none of the
1711         layout_test unit tests ever read from the filesystem or launch
1712         subprocesses that aren't part of the unit tests.
1713
1714         Also fix a minor bug in the printing unit tests that was
1715         incorrectly relying on sys.argv.
1716
1717         https://bugs.webkit.org/show_bug.cgi?id=52863
1718
1719         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1720         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1721         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1722
1723 2011-01-21  Darin Adler  <darin@apple.com>
1724
1725        Fix Mac build.
1726
1727         * MiniBrowser/mac/BrowserWindowController.m:
1728         (-[BrowserWindowController awakeFromNib]): Pass 0 for runModal function.
1729
1730 2011-01-20  Darin Adler  <darin@apple.com>
1731
1732         Reviewed by Dan Bernstein.
1733
1734         WebKit2: Implement showModalDialog
1735         https://bugs.webkit.org/show_bug.cgi?id=52855
1736
1737         This fixes WebKitTestRunner to compile, but more work is probably
1738         needed to get it to pass the tests.
1739
1740         * WebKitTestRunner/TestController.cpp:
1741         (WTR::TestController::runModal): Added. Calls through to the
1742         platform-specific version of runModal.
1743         (WTR::TestController::createOtherPage): Changed to be a private
1744         static member function so it can refer to runModal, which is
1745         a private static member function.
1746         (WTR::TestController::initialize): Pass 0 for the runModal
1747         function since we don't need to run the main window modal.
1748         I suspect this is wrong and will need to change.
1749         * WebKitTestRunner/TestController.h: Added declarations for
1750         the functions added above.
1751         * WebKitTestRunner/mac/TestControllerMac.mm:
1752         (WTR::TestController::runModal): Added. Untested implementation.
1753         * WebKitTestRunner/qt/TestControllerQt.cpp:
1754         (WTR::TestController::runModal): Added.
1755         * WebKitTestRunner/win/TestControllerWin.cpp:
1756         (WTR::TestController::runModal): Added.
1757
1758 2011-01-21  Eric Seidel  <eric@webkit.org>
1759
1760         Reviewed by Adam Barth.
1761
1762         Split Host object off from WebKitPatch for easier re-use
1763         https://bugs.webkit.org/show_bug.cgi?id=52284
1764
1765         new-run-webkit-tests and other tools are eventually going to want one of these.
1766         Basically you need to inherit from this class if you want to pretend to be a
1767         self.tool object for Steps/Commands.
1768
1769         * Scripts/webkitpy/common/host.py: Added.
1770         * Scripts/webkitpy/tool/main.py:
1771
1772 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1773
1774         Reviewed by Adam Barth.
1775
1776         Disable the tests that start and stop the http server and web
1777         server, so that we don't have to worry about port collisions on
1778         the bots.
1779
1780         https://bugs.webkit.org/show_bug.cgi?id=52861
1781
1782         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1783
1784 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1785
1786         Reviewed by Eric Seidel.
1787
1788         nrwt: rewrite google_chrome_unittest to use mock filesystem.
1789         
1790         https://bugs.webkit.org/show_bug.cgi?id=52772
1791         
1792         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
1793
1794 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1795
1796         Reviewed by Eric Siedel.
1797
1798         nrwt: clean up almost all remaining port references, remove
1799         unnecessary import clauses. The only remaining references are
1800         in places where a mock filesystem makes no sense or can't be
1801         used, and in one routine in port/google_chrome_unittest that
1802         I'll rewrite in a separate patch.
1803
1804         https://bugs.webkit.org/show_bug.cgi?id=52771
1805
1806         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1807         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1808         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1809         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1810         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1811         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1812         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1813         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
1814         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
1815         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
1816         * Scripts/webkitpy/layout_tests/port/gtk.py:
1817         * Scripts/webkitpy/layout_tests/port/mac.py:
1818         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1819         * Scripts/webkitpy/layout_tests/port/qt.py:
1820         * Scripts/webkitpy/layout_tests/port/webkit.py:
1821         * Scripts/webkitpy/layout_tests/port/win.py:
1822         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
1823
1824 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1825
1826         Reviewed by Mihai Parparita.
1827
1828         remove fs refs from run_webkit_tests, rebaseline_chromium_webkit_tests
1829
1830         https://bugs.webkit.org/show_bug.cgi?id=52762
1831
1832         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1833         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1834
1835 2011-01-20  Tony Chang  <tony@chromium.org>
1836
1837         Reviewed by Ojan Vafai.
1838
1839         [chromium] fix the paths used for the rebaseline tool
1840         https://bugs.webkit.org/show_bug.cgi?id=52857
1841
1842         Some of the bots were renamed so the path to grab the results zip
1843         file has changed.
1844
1845         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1846
1847 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1848
1849         Reviewed by Tony Chang.
1850
1851         Fix bug introduced in r72688 / bug 52768 that broke the
1852         generation of the output filename links in the results.html
1853         output. Apparently none of the unit tests actually checked to
1854         make sure the generated links were correct :(
1855
1856         https://bugs.webkit.org/show_bug.cgi?id=52854
1857
1858         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1859         * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
1860
1861 2011-01-20  Alexey Proskuryakov  <ap@apple.com>
1862
1863         Reviewed by Darin Adler.
1864
1865         https://bugs.webkit.org/show_bug.cgi?id=52849
1866         Make window.print work with WebKit2
1867
1868         * MiniBrowser/mac/BrowserWindowController.m:
1869         (-[BrowserWindowController awakeFromNib]):
1870         * WebKitTestRunner/TestController.cpp:
1871         (WTR::createOtherPage):
1872         (WTR::TestController::initialize):
1873         Added zeroes to WKPageUIClient structures to avoid build failures.
1874
1875 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1876
1877         Reviewed by Eric Seidel.
1878
1879         nrwt: remove fs refs from printing, test_failures, test_expectations, text_diff
1880
1881         https://bugs.webkit.org/show_bug.cgi?id=52756
1882
1883         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1884         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1885         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1886         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
1887         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1888         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
1889
1890 2011-01-20  Mansi Mithal  <mansi.mithal@nokia.com>
1891
1892         Reviewed by Antonio Gomes.
1893
1894         QtTestBrowser should have a seperate menu for Settings
1895         https://bugs.webkit.org/show_bug.cgi?id=52817
1896         
1897         Added a new menu item named "Settings"
1898         and moved the "Enable interrupting js scripts" and "Enable js pop up windows" under the "Settings" menu 
1899
1900         * QtTestBrowser/launcherwindow.cpp:
1901         (LauncherWindow::createChrome):
1902
1903 2011-01-20  Sam Weinig  <sam@webkit.org>
1904
1905         Reviewed by John Sullivan.
1906
1907         Update update-webkit-localizable-strings with new path to WebKit.
1908
1909         * Scripts/update-webkit-localizable-strings:
1910
1911 2011-01-20  James Robinson  <jamesr@chromium.org>
1912
1913         Reviewed by Darin Fisher.
1914
1915         Implement mozilla's requestAnimationFrame API
1916         https://bugs.webkit.org/show_bug.cgi?id=51218
1917
1918         Chromium DumpRenderTree support for window.webkitRequestAnimationFrame.
1919
1920         * DumpRenderTree/chromium/WebViewHost.cpp:
1921         (invokeScheduleComposite):
1922         (WebViewHost::scheduleAnimation):
1923         (WebViewHost::paintInvalidatedRegion):
1924         * DumpRenderTree/chromium/WebViewHost.h:
1925
1926 2011-01-20  Maciej Stachowiak  <mjs@apple.com>
1927
1928         Reviewed by Adam Roben.
1929
1930         WebKitTestRunner needs to support layoutTestController.evaluateScriptInIsolatedWorld
1931         https://bugs.webkit.org/show_bug.cgi?id=42327
1932
1933         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm: Add support
1934         for methods that take their normal arguments but also a JSContextRef.
1935         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: IDL definition
1936         for evaluateScriptInIsolatedWorld.
1937         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1938         (WTR::InjectedBundlePage::didClearWindowForFrame): Set a magic variable only if
1939         this call is for an isolated world.
1940         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1941         (WTR::worldMap): Helper to create a world map.
1942         (WTR::LayoutTestController::worldIDForWorld): Map from an ID to a world.
1943         (WTR::LayoutTestController::evaluateScriptInIsolatedWorld): The newly
1944         added LayoutTestController API.
1945         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1946
1947 2011-01-19  Adam Roben  <aroben@apple.com>
1948
1949         Convert paths in environment variables back to msys-style inside commit-log-editor
1950
1951         When this script gets run from inside git commit, msys-style paths in the environment will
1952         have been turned into Windows-style paths with forward slashes. This screws up functions
1953         like File::Spec->rel2abs, which seem to rely on $PWD having an msys-style path. We convert
1954         the paths back to msys-style before doing anything else.
1955
1956         Fixes <http://webkit.org/b/48527> commit-log-editor uses full paths for section headers when
1957         using msysgit's Perl and multiple ChangeLogs have been edited
1958
1959         Reviewed by David Kilzer.
1960
1961         * Scripts/commit-log-editor: Call fixEnvironment before doing anything else.
1962         (fixEnvironment): Added. When run in msys in conjunction with git (i.e., when invoked from
1963         inside git commit), convert Windows-style paths in the environment back to msys-style paths.
1964
1965 2011-01-20  Zoltan Horvath  <zoltan@webkit.org>
1966
1967         [Win] Unreviewed build fix after r76248.
1968
1969         * DumpRenderTree/ForwardingHeaders/wtf/FastAllocBase.h: Added.
1970
1971 2011-01-20  Zoltan Horvath  <zoltan@webkit.org>
1972
1973         Reviewed by Csaba Osztrogonác.
1974
1975         Refactoring of the custom allocation framework
1976         https://bugs.webkit.org/show_bug.cgi?id=49897
1977
1978         Inheriting from FastAllocBase can result in objects getting larger (bug #33896, #46589).
1979         The modification replaces Noncopyable and FastAllocBase classes and these inherits with their
1980         equivalent macro implementation at the necessary places.
1981 2011-01-20  Yi Shen  <yi.4.shen@nokia.com>
1982
1983         Unreviewed. 
1984
1985         Adding myself to committers.py.
1986
1987         * Scripts/webkitpy/common/config/committers.py:
1988
1989 2011-01-20  Adam Barth  <abarth@webkit.org>
1990
1991         Reviewed by Tony Chang.
1992
1993         Chromium builders don't delete unversioned directories when DEPS change
1994         https://bugs.webkit.org/show_bug.cgi?id=52745
1995
1996         If we pass this option to gclient sync, gclient will delete directories
1997         that are no longer part of DEPS instead of leaving them around to
1998         confuse us later.  Apparently, the downstream buildbots use this option
1999         already.
2000
2001         * Scripts/update-webkit-chromium:
2002
2003 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2004
2005         Unreviewed, build fix - I pulled this patch in to fix an issue
2006         revealed by r76195 running on some new bots). Also fix a couple
2007         of other issues revealed in testing.
2008
2009         nrwt: remove fs refs from layout_package/json*
2010
2011         https://bugs.webkit.org/show_bug.cgi?id=52754
2012
2013         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2014         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
2015         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
2016         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2017         * Scripts/webkitpy/layout_tests/port/base.py:
2018
2019 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2020
2021         Unreviewed, build fix.
2022
2023         Fix a couple of minor bugs discovered while bringing up new bots
2024         for testing.
2025
2026         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2027         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2028
2029 2011-01-19  James Robinson  <jamesr@chromium.org>
2030
2031         Unreviewed, rolling out r76194.
2032         http://trac.webkit.org/changeset/76194
2033         https://bugs.webkit.org/show_bug.cgi?id=51218
2034
2035         Caused mysterious compile failure on the chromium win
2036         build.webkit.org bots
2037
2038         * DumpRenderTree/chromium/WebViewHost.cpp:
2039         (WebViewHost::paintInvalidatedRegion):
2040         * DumpRenderTree/chromium/WebViewHost.h:
2041
2042 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2043
2044         Reviewed by Mihai Parparita.
2045
2046         remove fs refs from test_runner, dump_render_tree_thread
2047
2048         https://bugs.webkit.org/show_bug.cgi?id=52753
2049
2050         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2051         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2052         * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
2053         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2054
2055 2011-01-19  James Robinson  <jamesr@chromium.org>
2056
2057         Reviewed by Darin Fisher.
2058
2059         Implement mozilla's requestAnimationFrame API
2060         https://bugs.webkit.org/show_bug.cgi?id=51218
2061
2062         Chromium DumpRenderTree support for window.webkitRequestAnimationFrame.
2063
2064         * DumpRenderTree/chromium/WebViewHost.cpp:
2065         (invokeScheduleComposite):
2066         (WebViewHost::scheduleAnimation):
2067         (WebViewHost::paintInvalidatedRegion):
2068         * DumpRenderTree/chromium/WebViewHost.h:
2069
2070 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2071
2072         Unreviewed, build fix.
2073
2074         Fix a few incorrect "self._filesystem" references introduced in
2075         r76184.
2076
2077         * Scripts/webkitpy/layout_tests/port/chromium.py:
2078         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2079
2080 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2081
2082         Reviewed by Mihai Parparita.
2083
2084         add a .sep property, abspath(), isabs(), mtime(), and
2085         open_text_file_for_writing() to filesystem modules. Some of
2086         these properties are not needed in this patch but will be needed
2087         in subsequent patches (I'm doing this to avoid having to track
2088         multiple versions of a single file).
2089
2090         Also, change most of the port/* modules to use the filesystem
2091         objects instead of referencing the filesystem directly.
2092
2093         https://bugs.webkit.org/show_bug.cgi?id=52748
2094
2095         * Scripts/webkitpy/common/system/filesystem.py:
2096         * Scripts/webkitpy/common/system/filesystem_mock.py:
2097         * Scripts/webkitpy/layout_tests/port/__init__.py:
2098         * Scripts/webkitpy/layout_tests/port/base.py:
2099         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2100         * Scripts/webkitpy/layout_tests/port/chromium.py:
2101         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2102         * Scripts/webkitpy/layout_tests/port/config.py:
2103         * Scripts/webkitpy/layout_tests/port/test.py:
2104         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
2105
2106 2011-01-19  Maciej Stachowiak  <mjs@apple.com>
2107
2108         Reviewed by Anders Carlsson.
2109
2110         If resetting between tests times out, treat it as a WebProcess crash
2111         https://bugs.webkit.org/show_bug.cgi?id=52757
2112
2113         * WebKitTestRunner/TestController.cpp:
2114         (WTR::TestController::runTest):
2115
2116 2011-01-19  Alexey Proskuryakov  <ap@apple.com>
2117
2118         Reviewed by Darin Adler.
2119
2120         https://bugs.webkit.org/show_bug.cgi?id=52739
2121         Make it possible for a WebKit2 client to print headers and footers
2122
2123         Added dummy implementations for new printing UIClient calls.
2124
2125         * MiniBrowser/mac/BrowserWindowController.m:
2126         (-[BrowserWindowController awakeFromNib]):
2127         * WebKitTestRunner/TestController.cpp:
2128         (WTR::createOtherPage):
2129         (WTR::TestController::initialize):
2130
2131 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2132
2133         Reviewed by Ojan Vafai.
2134
2135         Change webkitpy/layout_tests/port/test.py to use the
2136         in-memory filesystem for cleaner unit testing. This
2137         change allows us to kill a lot of code that was
2138         specific to the test port, at the cost of being a
2139         little less clear about how things would work if
2140         you didn't have a filesystem.
2141
2142         https://bugs.webkit.org/show_bug.cgi?id=52605
2143
2144         * Scripts/webkitpy/layout_tests/port/test.py:
2145
2146 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2147
2148         Unreviewed, build fix.
2149
2150         Fix test failure caused by committing attachment 79368 instead
2151         of attachment 79461 on bug 52604.
2152
2153         * Scripts/webkitpy/common/system/filesystem_mock.py:
2154
2155 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2156
2157         Reviewed by Mihai Parparita.
2158
2159         new-run-webkit-tests: remove use of os.walk, use mock filesystem for better
2160         unit testing. os.walk() is too much of a hassle to implement on
2161         top of the in-memory mock filesystem and adding the necessary
2162         interface to files_under() gives clients a cleaner API anyway
2163         (for this particular usage model).
2164
2165         https://bugs.webkit.org/show_bug.cgi?id=52691
2166
2167         * Scripts/webkitpy/common/system/filesystem.py:
2168         * Scripts/webkitpy/common/system/filesystem_mock.py:
2169         * Scripts/webkitpy/layout_tests/port/test_files.py:
2170         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
2171
2172 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2173
2174         Reviewed by Tony Chang.
2175
2176         Change more modules in the layout-tests code to use the
2177         filesystem wrapper for cleaner unit testing.
2178
2179         This patch also adds the glob() wrapper to the filesystem
2180         abstraction.
2181         
2182         https://bugs.webkit.org/show_bug.cgi?id=52604
2183
2184         * Scripts/webkitpy/layout_tests/port/test_files.py:
2185         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
2186         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
2187         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2188         * Scripts/webkitpy/common/system/filesystem.py:
2189         * Scripts/webkitpy/common/system/filesystem_mock.py:
2190
2191 2011-01-19  Levi Weintraub  <leviw@chromium.org>
2192
2193         Unreviewed.
2194
2195         Updating my email addresses and irc nick.
2196
2197         * Scripts/webkitpy/common/config/committers.py:
2198
2199 2011-01-19  Tony Chang  <tony@chromium.org>
2200
2201         Reviewed by Mihai Parparita.
2202
2203         [chromium] [linux] if check-sys-deps fails, output the failure reason
2204         https://bugs.webkit.org/show_bug.cgi?id=52671
2205
2206         * Scripts/webkitpy/common/system/executive_mock.py: Add support for
2207             error handler functions.
2208         * Scripts/webkitpy/layout_tests/port/chromium.py:
2209             output the error text from --check-sys-deps
2210         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2211
2212 2011-01-19  Aparna Nandyal  <aparna.nand@wipro.com>
2213
2214         Reviewed by Andreas Kling.
2215
2216         [Qt] QtTestBrowser crashes when closing if Facebook is opened
2217         https://bugs.webkit.org/show_bug.cgi?id=52554
2218         
2219         QtNetworkAccessManager is created in a thread and set as
2220         member variable in QWebPage. When the thread is destroyed
2221         the object is still used. So fix will set the object to
2222         NULL once the thread is destroyed.
2223
2224         * QtTestBrowser/launcherwindow.cpp:
2225         (LauncherWindow::~LauncherWindow):
2226
2227 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
2228
2229         Rubber stamped by Csaba Osztrogonac
2230
2231         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: Removed unncessary inculde of WKStringCF.h
2232
2233 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
2234
2235         Reviewed by Tony Chang.
2236
2237         new-run-webkit-tests: add a --build-directory command line argument
2238
2239         Official Google Chrome builds use a non-standard build directory
2240         location. This patch adds a --build-directory argument that
2241         allows that location to be specified on the command line. Only
2242         Chromium-based builds will use this flag for now, but anyone can
2243         in the future.
2244
2245         There are no unit tests for this since it's difficult to test
2246         until mock filesystems are fully supported in the code. This was
2247         tested by hand for now.
2248
2249         https://bugs.webkit.org/show_bug.cgi?id=52694
2250
2251         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2252         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2253         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2254         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2255
2256 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
2257
2258         Not reviewed. Bot fix.
2259
2260         Remove an inadvertently committed debugging print.
2261
2262         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2263         (LayoutTestController::notifyDone):
2264
2265 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
2266
2267         Reviewed by Sam Weinig.
2268
2269         WebKitTestRunner should track loading more like DumpRenderTree
2270         https://bugs.webkit.org/show_bug.cgi?id=52692
2271
2272         Change load tracking to track the current top loading frame, in the manner of DumpRenderTree.
2273         This makes some tests that call notifyDone multiple times pass.
2274         
2275         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2276         (WTR::InjectedBundle::InjectedBundle):
2277         (WTR::InjectedBundle::done):
2278         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2279         (WTR::InjectedBundle::topLoadingFrame):
2280         (WTR::InjectedBundle::setTopLoadingFrame):
2281         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2282         (WTR::InjectedBundlePage::InjectedBundlePage):
2283         (WTR::InjectedBundlePage::stopLoading):
2284         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
2285         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
2286         (WTR::InjectedBundlePage::didFinishLoadForFrame):
2287         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
2288         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2289         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2290         (WTR::LayoutTestController::notifyDone):
2291         * WebKitTestRunner/TestController.cpp:
2292         (WTR::TestController::didReceiveMessageFromInjectedBundle):
2293
2294 2011-01-18  Mihai Parparita  <mihaip@chromium.org>
2295
2296         Reviewed by Kent Tamura.
2297
2298         [Chromium] NRWT looking for DRT binary in the wrong path on Mac
2299         https://bugs.webkit.org/show_bug.cgi?id=52678
2300         
2301         Update path now that WebKit is inside Source.
2302
2303         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2304
2305 2011-01-18  Robert Hogan  <robert@webkit.org>
2306
2307         Reviewed by Simon Hausmann.
2308
2309         [Qt] http/tests/incremental/slow-utf8-text.pl fails
2310         https://bugs.webkit.org/show_bug.cgi?id=44282
2311
2312         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2313         (WebCore::DumpRenderTree::dump):
2314
2315 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
2316
2317         Reviewed by Mihai Parparita.
2318
2319         Fix a small race condition that could cause the unit tests for
2320         new-run-webkit-tests to fail in a multithreaded environment.
2321         There was a small window in the code where one thread would
2322         check to see if a thread had raised an exception, do something,
2323         and then check to see if the thread was alive. If the other
2324         thread raised an exception and exited in between these two
2325         steps, the exception would be lost. Flipping the order of the
2326         two checks fixes the race, since we will now always check for an
2327         exception on the thread before exiting.
2328
2329         https://bugs.webkit.org/show_bug.cgi?id=51579
2330
2331         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
2332
2333 2011-01-18  Eric Seidel  <eric@webkit.org>
2334
2335         Reviewed by Adam Barth.
2336
2337         commit-queue dies when test archiving fails
2338         https://bugs.webkit.org/show_bug.cgi?id=52617
2339
2340         I looked at the machine and it had 10 archives already
2341         thus find_unused_name was returning None.  I've upped
2342         the limit to 100 (per bug) and tested the case where
2343         find_unused_name returns None (making archive return None).
2344
2345         * Scripts/webkitpy/common/system/workspace.py:
2346         * Scripts/webkitpy/common/system/workspace_unittest.py:
2347         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2348         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2349         * Scripts/webkitpy/tool/commands/queues.py:
2350
2351 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
2352
2353         Reviewed by Ojan Vafai.
2354
2355         Update rebaseline-chromium-webkit-tests unit tests to use a mock
2356         filesystem. Also fix a couple of "with" statements missed by
2357         r76050.
2358
2359         https://bugs.webkit.org/show_bug.cgi?id=52487
2360
2361         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
2362
2363 2011-01-18  Sergio Villar Senin  <svillar@igalia.com>
2364
2365         Reviewed by Martin Robinson.
2366
2367         [Gtk] Build fixes for gtk3 build
2368         https://bugs.webkit.org/show_bug.cgi?id=52648
2369
2370         * DumpRenderTree/gtk/EventSender.cpp:
2371         (beginDragWithFilesCallback):
2372
2373 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
2374
2375         Reviewed by Mihai Parparita.
2376
2377         Update rebaseline-chromium-webkit-tests to use filesystem objects
2378         instead of direct references to os.path, shutil, tempfile, etc.
2379
2380         This patch doesn't change anything, but will allow subsequent
2381         patches to change the unit tests to no longer use the real
2382         filesystem.
2383
2384         This patch adds a bunch more methods to the filesystem object as
2385         well.
2386
2387         https://bugs.webkit.org/show_bug.cgi?id=52482
2388
2389         * Scripts/webkitpy/common/system/filesystem.py:
2390         * Scripts/webkitpy/common/system/filesystem_mock.py:
2391         * Scripts/webkitpy/tool/commands/queues.py:
2392         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2393         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
2394
2395 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
2396
2397         Reviewed by Mihai Parparita.
2398
2399         new-run-webkit-tests shouldn't crash when you try to run a
2400         directory containing only skipped files.
2401
2402         https://bugs.webkit.org/show_bug.cgi?id=52478
2403         
2404         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2405         * Scripts/webkitpy/layout_tests/port/test.py:
2406         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2407
2408 2011-01-18  Adam Bergkvist  <adam.bergkvist@ericsson.com> and Martin Robinson  <mrobinson@igalia.com>
2409
2410         Reviewed by Gustavo Noronha Silva.
2411
2412         [GTK] The GTK+ EventSender needs support for beginDragWithFiles
2413         https://bugs.webkit.org/show_bug.cgi?id=40833
2414
2415         * DumpRenderTree/gtk/EventSender.cpp: Add a beginDragWithFiles implementation for the
2416         GTK+ event sender.
2417         (dragWithFilesDragDataGetCallback): Added.
2418         (dragWithFilesDragEndCallback): Added.
2419         (beginDragWithFilesCallback): Added.
2420
2421 2011-01-18  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2422
2423         Reviewed by Adam Barth.
2424
2425         ews: Add additional watcher to efl ews
2426         https://bugs.webkit.org/show_bug.cgi?id=52613
2427
2428         Add gyuyoung.kim@samsung.com to watcher list of efl-ews.
2429
2430         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2431
2432 2011-01-17  Tony Gentilcore  <tonyg@chromium.org>
2433
2434         Reviewed by Alexey Proskuryakov.
2435
2436         Fix some headers with missing or misspelled #ifndef guards
2437         https://bugs.webkit.org/show_bug.cgi?id=52545
2438
2439         * DumpRenderTree/chromium/TestEventPrinter.h:
2440         * DumpRenderTree/chromium/WebPreferences.h:
2441
2442 2011-01-17  Jessie Berlin  <jberlin@apple.com>
2443
2444         Reviewed by Anders Carlsson.
2445
2446         REGRESSION: Assertion failure in FrameLoader::continueLoadAfterWillSubmitForm() when
2447         navigating back to an unreachable URL
2448         https://bugs.webkit.org/show_bug.cgi?id=52388
2449
2450         Add a third parameter (unreachableURL) to queueLoadHTMLString.
2451
2452         * DumpRenderTree/LayoutTestController.cpp:
2453         (queueLoadHTMLStringCallback):
2454         (LayoutTestController::queueLoadHTMLString):
2455         (LayoutTestController::queueLoadAlternateHTMLString):
2456         * DumpRenderTree/LayoutTestController.h:
2457
2458         * DumpRenderTree/WorkQueueItem.h:
2459         (LoadHTMLStringItem::LoadHTMLStringItem):
2460
2461         * DumpRenderTree/chromium/LayoutTestController.cpp:
2462         (WorkItemLoadHTMLString::WorkItemLoadHTMLString):
2463         (WorkItemLoadHTMLString::run):
2464         (LayoutTestController::queueLoadHTMLString):
2465
2466         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
2467         (LoadHTMLStringItem::invoke):
2468         * DumpRenderTree/mac/WorkQueueItemMac.mm:
2469         (LoadHTMLStringItem::invoke):
2470         * DumpRenderTree/win/WorkQueueItemWin.cpp:
2471         (LoadHTMLStringItem::invoke):
2472
2473 2011-01-17  Dan Bernstein  <mitz@apple.com>
2474
2475         Rubber-stamped by Mark Rowe.
2476
2477         Update xcodeproj svn:ignore to include xcuserdata.
2478
2479         * DumpRenderTree/DumpRenderTree.xcodeproj: Modified property svn:ignore.
2480         * MiniBrowser/MiniBrowser.xcodeproj: Modified property svn:ignore.
2481         * TestWebKitAPI/TestWebKitAPI.xcodeproj: Modified property svn:ignore.
2482         * WebKitLauncher/WebKitLauncher.xcodeproj: Modified property svn:ignore.
2483         * WebKitTestRunner/WebKitTestRunner.xcodeproj: Modified property svn:ignore.
2484
2485 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
2486
2487         Unreviewed fix after r75908.
2488
2489         Move WebKit into Source
2490         https://bugs.webkit.org/show_bug.cgi?id=52530
2491
2492         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add Source to the path for Qt API tests.
2493
2494 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
2495
2496         Unreviewed.
2497
2498         Remove accidentally committed debug printing after r75908.
2499
2500         * Scripts/webkitdirs.pm:
2501
2502 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
2503
2504         Unreviewed.
2505
2506         Add myself to committers list
2507         https://bugs.webkit.org/show_bug.cgi?id=52566
2508
2509         * Scripts/webkitpy/common/config/committers.py:
2510
2511 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
2512
2513         Reviewed by Jeremy Orlow.
2514
2515         GeolocationController should call stopUpdating on destruction
2516         https://bugs.webkit.org/show_bug.cgi?id=52216
2517
2518         fast/dom/Geolocation/window-close-crash.html requires that a
2519         Geolocation watch be started in a secondary window. Consequently,
2520         we need to allow geolocation permission and provide a mock
2521         geolocation position for the secondary window's
2522         GeolocationClientMock.
2523
2524         * DumpRenderTree/chromium/LayoutTestController.cpp:
2525         (LayoutTestController::setGeolocationPermission):
2526         (LayoutTestController::setMockGeolocationPosition):
2527         (LayoutTestController::setMockGeolocationError):
2528         * DumpRenderTree/chromium/TestShell.h:
2529         (TestShell::windowList):
2530
2531 2011-01-16  Adam Barth  <abarth@webkit.org>
2532
2533         Update more include paths to reflect WebKit move.
2534
2535         * DumpRenderTree/chromium/EventSender.cpp:
2536         (EventSender::keyDown):
2537         (EventSender::needsShiftModifier):
2538         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
2539         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
2540
2541 2011-01-16  Kent Tamura  <tkent@chromium.org>
2542
2543         Unreviewed, Chromium build fix.
2544
2545         * Scripts/update-webkit-chromium: Webkit/chromium -> Source/WebKit/chromium
2546
2547 2011-01-16  Martin Robinson  <mrobinson@igalia.com>
2548
2549         Build fix for GTK+ after source directory movement.
2550
2551         * GNUmakefile.am: Correct include paths.
2552
2553 2011-01-16  Adam Barth  <abarth@webkit.org>
2554
2555         Teach svn-apply about WebKit move.
2556
2557         * Scripts/VCSUtils.pm:
2558
2559 2011-01-16  Adam Barth  <abarth@webkit.org>
2560
2561         Rubber-stamped by Eric Seidel.
2562
2563         Move WebKit into Source
2564         https://bugs.webkit.org/show_bug.cgi?id=52530
2565
2566         * DumpRenderTree/mac/InternalHeaders/WebKit/WebTypesInternal.h:
2567         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2568         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2569         * DumpRenderTree/qt/GCControllerQt.cpp:
2570         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2571         * DumpRenderTree/qt/PlainTextControllerQt.cpp:
2572         * DumpRenderTree/qt/TextInputControllerQt.cpp:
2573         * DumpRenderTree/wscript:
2574         * QtTestBrowser/launcherwindow.h:
2575         * Scripts/build-webkit:
2576         * Scripts/webkitdirs.pm:
2577
2578 2011-01-15  Adam Barth  <abarth@webkit.org>
2579
2580         Teach svn-apply about WebKit2 move.
2581
2582         * Scripts/VCSUtils.pm:
2583
2584 2011-01-15  Adam Barth  <abarth@webkit.org>
2585
2586         Rubber-stamped by Eric Seidel.
2587
2588         Move WebKit2 into Source
2589         https://bugs.webkit.org/show_bug.cgi?id=52438
2590
2591         * MiniBrowser/qt/MiniBrowser.pro:
2592         * Scripts/build-webkit:
2593         * Scripts/do-file-rename:
2594         * Scripts/do-webcore-rename:
2595         * Scripts/test-webkitpy:
2596         * Scripts/webkitdirs.pm:
2597         * Scripts/webkitpy/style/checker.py:
2598         * WebKitTestRunner/DerivedSources.pro:
2599         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2600         * WebKitTestRunner/qt/WebKitTestRunner.pro:
2601
2602 2011-01-15  Jochen Eisinger  <jochen@chromium.org>
2603
2604         Reviewed by David Levin.
2605
2606         [chromium] remove obsolete createView method
2607         https://bugs.webkit.org/show_bug.cgi?id=52437
2608
2609         * DumpRenderTree/chromium/WebViewHost.cpp:
2610         (WebViewHost::createView):
2611         * DumpRenderTree/chromium/WebViewHost.h:
2612
2613 2011-01-14  Brian Weinstein  <bweinstein@apple.com>
2614
2615         Reviewed by Geoff Garen.
2616
2617         ShouldLoadResourceForFrame should use strings, not URLs.
2618         https://bugs.webkit.org/show_bug.cgi?id=52476
2619
2620         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2621         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Update to use a WKStringRef.
2622         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2623
2624 2011-01-14  Tony Gentilcore  <tonyg@chromium.org>
2625
2626         Reviewed by David Levin.
2627
2628         Add Tony Gentilcore as a reviewer
2629         https://bugs.webkit.org/show_bug.cgi?id=52480
2630
2631         * Scripts/webkitpy/common/config/committers.py:
2632
2633 2011-01-14  David Levin  <levin@chromium.org>
2634
2635         Reviewed by Eric Seidel.
2636
2637         check-webkit-style: _FunctionState should keep track of where the function name starts.
2638         https://bugs.webkit.org/show_bug.cgi?id=52454
2639
2640         * Scripts/webkitpy/style/checkers/cpp.py: Added function_name_start_position to
2641         _FunctionState and logic for setting it correctly.
2642         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests.
2643
2644 2011-01-14  Vincent Scheib  <scheib@chromium.org>
2645
2646         Reviewed by David Levin.
2647
2648         Add support to DumpRenderTree to use the GPU rather than software renderer
2649         https://bugs.webkit.org/show_bug.cgi?id=52333
2650
2651         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2652         (main):
2653         * Scripts/webkitpy/layout_tests/port/chromium.py:
2654         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2655
2656 2011-01-14  Tony Chang  <tony@chromium.org>
2657
2658         Reviewed by Kent Tamura.
2659
2660         [chromium] update fonts.conf to fix 6 linux tests in drt
2661         https://bugs.webkit.org/show_bug.cgi?id=52411
2662
2663         * DumpRenderTree/chromium/fonts.conf: Update to match the copy in
2664             chromium's src/webkit/tools/test_shell/resources/fonts.conf
2665
2666 2011-01-14  Eric Seidel  <eric@webkit.org>
2667
2668         Original patch from Peter Gal  <galpater@inf.u-szeged.hu>
2669
2670         Reviewed by Adam Barth.
2671
2672         Fix when running Tools/Scripts/check-webkit-style without arguments.
2673         https://bugs.webkit.org/show_bug.cgi?id=52261#c16
2674
2675         * Scripts/webkitpy/common/checkout/scm.py: Handle None for changed_files argument better in Git.create_patch method.
2676         * Scripts/webkitpy/common/checkout/scm_unittest.py:
2677
2678 2011-01-04  Jochen Eisinger  <jochen@chromium.org>
2679
2680         Reviewed by David Levin.
2681
2682         Store the tempdir object in a variable so it doesn't get deleted too early.
2683         https://bugs.webkit.org/show_bug.cgi?id=51875
2684
2685         * Scripts/update-webkit-auxiliary-libs:
2686         * Scripts/update-webkit-support-libs:
2687
2688 2011-01-14  Eric Seidel  <eric@webkit.org>
2689
2690         Unreviewed.  Make it work in python 2.5.
2691
2692         webkit-patch suggest-reviewers dies when ChangeLogs are missing
2693         https://bugs.webkit.org/show_bug.cgi?id=49158
2694
2695         * Scripts/webkitpy/common/checkout/api_unittest.py:
2696
2697 2011-01-14  Sheriff Bot  <webkit.review.bot@gmail.com>
2698
2699         Unreviewed, rolling out r75774.
2700         http://trac.webkit.org/changeset/75774
2701         https://bugs.webkit.org/show_bug.cgi?id=52431
2702
2703         gtk builds were broken (Requested by loislo2 on #webkit).
2704
2705         * Scripts/webkitpy/common/checkout/scm.py:
2706
2707 2011-01-14  David Levin  <levin@chromium.org>
2708
2709         Reviewed by Shinichiro Hamaji.
2710
2711         check-webkit-style: _FunctionState should detect pure functions.
2712         https://bugs.webkit.org/show_bug.cgi?id=52428
2713
2714         * Scripts/webkitpy/style/checkers/cpp.py: Added detection for if a function declaration
2715         is a pure virtual function.
2716         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests for verifying that pure
2717         virtual functions are correctly detected.
2718
2719 2011-01-13  Ilya Tikhonovsky  <loislo@chromium.org>
2720
2721         Reviewed by Yury Semikhatsky.
2722
2723         Just small fix for problem with check-webkit-style.
2724         It just didn't work for this patch.
2725         Old code can't concatenate a list of strings with None.
2726
2727         * Scripts/webkitpy/common/checkout/scm.py:
2728
2729 2011-01-13  David Levin  <levin@chromium.org>
2730
2731         Reviewed by Shinichiro Hamaji.
2732
2733         check-webkit-style: _FunctionState should use Position to know where items are.
2734         https://bugs.webkit.org/show_bug.cgi?id=52424
2735
2736         * Scripts/webkitpy/style/checkers/cpp.py:
2737         (_FunctionState.*): Changed _FunctionState to use Position instead of line numbers.
2738         (detect_functions): Changed to pass Position's to _FunctionState.begin and
2739         did some minor clean-up.
2740         (*): Other changes are simply about converting to use the Position's in_FunctionState
2741         instead of line numbers.
2742         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Changed the test code
2743         to verify the positions stored in _FunctionState.
2744
2745 2011-01-13  Eric Seidel  <eric@webkit.org>
2746
2747         Reviewed by David Levin.
2748
2749         webkit-patch suggest-reviewers dies when ChangeLogs are missing
2750         https://bugs.webkit.org/show_bug.cgi?id=49158
2751
2752         This is not the most elegant, but it is a very safe fix to this bug.
2753         One advantage of catching ScriptError like this instead of adding a
2754         new added_or_modified_files or fixing all changed_files callers
2755         to use a more specific change_files variant, is that we catch
2756         all kinds of ScriptErrors which might cause our (non-essential)
2757         suggest-reviewers code to fail out.  This should make passing
2758         --suggest-reviewers to webkit-patch upload much more robust
2759         and may even make it possible for us to make it default.
2760
2761         The root of the problem here is that SCM.changed_files includes
2762         deleted ChangeLog paths (from moves, etc) which then when we ask
2763         SVN/Git for the contents of the file at that revision, the command
2764         errors out and Executive.run_command raises a ScriptError.
2765
2766         In the future we might fix this differently by making all current
2767         callers of chagned_files use a more specific method for requesting
2768         what types of changes they're interested in (adds, modifies, deletes, etc.)
2769
2770         * Scripts/webkitpy/common/checkout/api.py:
2771         * Scripts/webkitpy/common/checkout/api_unittest.py:
2772
2773 2011-01-13  Dan Bernstein  <mitz@apple.com>
2774
2775         Reviewed by Alexey Proskuryakov.
2776
2777         <rdar://problem/8827065> REGRESSION (r71884): Cross-origin XHR fails if willSendRequest changes the URL
2778         https://bugs.webkit.org/show_bug.cgi?id=52419
2779
2780         Allow to further control the behavior of the willSendRequest delegate callback by making it
2781         set a different URL in the new request.
2782
2783         * DumpRenderTree/LayoutTestController.cpp:
2784         (addURLToRedirectCallback): Added.
2785         (LayoutTestController::staticFunctions): Added addURLToRedirect.
2786         (LayoutTestController::addURLToRedirect): Added. Adds the redirection to the map.
2787         (LayoutTestController::redirectionDestinationForURL): Added this getter.
2788         * DumpRenderTree/LayoutTestController.h:
2789         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2790         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]): Check
2791         if there is a redirection for the request’s URL, established by addURLToRedirect(), and if so,
2792         change the URL in the new request to the redirect destination.
2793
2794 2011-01-13  Eric Seidel  <eric@webkit.org>
2795
2796         Reviewed by Mihai Parparita.
2797
2798         webkit-patch suggest-reviewers fails due to invalid utf8 in ChangeLog files
2799         https://bugs.webkit.org/show_bug.cgi?id=52416
2800
2801         Example: webkit-patch suggest-reviewers -g ca3890fe74d94d85d6bfa48f9ea497b094d8e717 
2802         UnicodeDecodeError: 'utf8' codec can't decode bytes in position 536-538: invalid data
2803
2804         I also added FIXMEs about the changed_files returning deleted files problem
2805         which is causing the other most common exception for suggest-reviewers
2806         (and is probably breaking sheriff-bots blame detection).
2807
2808         * Scripts/webkitpy/common/checkout/api.py:
2809         * Scripts/webkitpy/common/checkout/api_unittest.py:
2810         * Scripts/webkitpy/common/checkout/scm.py:
2811
2812 2011-01-13  Eric Seidel  <eric@webkit.org>
2813
2814         Reviewed by Adam Barth.
2815
2816         results archives from commit-queue are too large to upload
2817         https://bugs.webkit.org/show_bug.cgi?id=52405
2818
2819         * Scripts/webkitpy/common/system/filesystem.py:
2820         * Scripts/webkitpy/common/system/filesystem_mock.py:
2821         * Scripts/webkitpy/tool/commands/queues.py:
2822
2823 2011-01-13  Alejandro G. Castro  <alex@igalia.com>
2824
2825         Reviewed by Martin Robinson.
2826
2827         [gtk] Zero-sized font does not yet work
2828         https://bugs.webkit.org/show_bug.cgi?id=49793
2829
2830         Set minimum-font-size to 0 for the DRT.
2831
2832         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2833         (resetDefaultsToConsistentValues):
2834
2835 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
2836
2837         Reviewed by Darin Adler.
2838
2839         Make old-run-webkit-tests more robust on buildbots
2840         https://bugs.webkit.org/show_bug.cgi?id=52364
2841
2842         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Pass --exit-after-n-failures 500 to old-run-webkit-tests script.
2843
2844 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
2845
2846         Reviewed by Darin Adler.
2847
2848         Make old-run-webkit-tests more robust on buildbots
2849         https://bugs.webkit.org/show_bug.cgi?id=52364
2850
2851         * Scripts/old-run-webkit-tests: Ensure that testResultsDirectory is empty.
2852
2853 2011-01-13  Tony Chang  <tony@chromium.org>
2854
2855         Reviewed by Kent Tamura.
2856
2857         [chromium] fix plugins/plugin-javascript-access.html on Linux and Mac
2858         https://bugs.webkit.org/show_bug.cgi?id=52332
2859
2860         Forked Info.plist is not longer needed.
2861
2862         * DumpRenderTree/chromium/TestNetscapePlugIn/Info.plist: Removed.
2863
2864 2011-01-13  Mikhail Naganov  <mnaganov@chromium.org>
2865
2866         Reviewed by Timothy Hatcher.
2867
2868         Web Inspector: Cleanup after r75613 -- make all UI-facing strings
2869         to be passed directly to WebInspector.UIString
2870
2871         https://bugs.webkit.org/show_bug.cgi?id=52365
2872
2873         * Scripts/check-inspector-strings:
2874
2875 2011-01-13  Sheriff Bot  <webkit.review.bot@gmail.com>
2876
2877         Unreviewed, rolling out r74881.
2878         http://trac.webkit.org/changeset/74881
2879         https://bugs.webkit.org/show_bug.cgi?id=52357
2880
2881         The EFL builder has been red for days (Requested by abarth on
2882         #webkit).
2883
2884         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2885         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2886
2887 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
2888
2889         Reviewed by David Levin.
2890
2891         Add beforeunload support to WebKitTestRunner
2892         https://bugs.webkit.org/show_bug.cgi?id=52353
2893         
2894         This makes a number of currently failing tests pass.
2895
2896         * WebKitTestRunner/TestController.cpp:
2897         (WTR::runBeforeUnloadConfirmPanel):
2898         (WTR::createOtherPage):
2899         (WTR::TestController::initialize):
2900
2901 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
2902
2903         Reviewed by Sam Weinig.
2904
2905         Detect, identify and recover from WebProcess crashes in run-webkit-tests
2906         https://bugs.webkit.org/show_bug.cgi?id=52330
2907
2908         * Scripts/old-run-webkit-tests: Detect when the regression test tool reports
2909         a web process crash.
2910         * WebKitTestRunner/TestController.cpp:
2911         (WTR::TestController::initialize): Set up a processDidCrash
2912         callback.
2913         (WTR::TestController::processDidCrash): Report that the Web process
2914         crashed.
2915         * WebKitTestRunner/TestController.h:
2916
2917 2011-01-12  David Levin  <levin@chromium.org>
2918
2919         Reviewed by Shinichiro Hamaji.
2920
2921         check-webkit-style -- close_expression function doesn't work correctly.
2922         https://bugs.webkit.org/show_bug.cgi?id=52272
2923
2924         * Scripts/webkitpy/style/checkers/cpp.py:
2925         (Position.__str__): Added a way to convert it to a string which is useful in tests.
2926         (Position.__cmp__): Added a way to compare Position which is useful in tests and
2927         generally useful (for upcoming code changes).
2928         (close_expression): Changed to use Position for input and output.
2929         Also, fixed many bugs such as only working correctly for parenthesis,
2930         not working correctly if given an offset in a line and not finding
2931         the real closing element if there were multiple closing elements in
2932         the same line.
2933         (detect_functions): Adjusted due to the change in arguments for
2934         close_expression.
2935         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2936         (CppStyleTestBase.assert_positions_equal): Added a way to verify that
2937         two positions are the same.
2938         (CppStyleTest.test_position): Added tests for the __str_ and __cmp__ methods.
2939         (CppStyleTest.test_close_expression): Added tests to catch the issues
2940         that were fixed.
2941
2942 2011-01-12  Sheriff Bot  <webkit.review.bot@gmail.com>
2943
2944         Unreviewed, rolling out r75576.
2945         http://trac.webkit.org/changeset/75576
2946         https://bugs.webkit.org/show_bug.cgi?id=52304
2947
2948         broke rebaseline-chromium-webkit-test (Requested by thakis on
2949         #webkit).
2950
2951         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2952         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2953         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
2954         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2955         * Scripts/webkitpy/layout_tests/port/base.py:
2956         * Scripts/webkitpy/layout_tests/port/chromium.py:
2957         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2958         * Scripts/webkitpy/layout_tests/port/test.py:
2959         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2960         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2961         * Scripts/webkitpy/style/checkers/test_expectations.py:
2962         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
2963
2964 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
2965
2966         Reviewed by Darin Adler.
2967
2968         Add a no-build option to run-webkit-tests, to avoid building DRT/WKTR
2969         https://bugs.webkit.org/show_bug.cgi?id=52307
2970
2971         * Scripts/old-run-webkit-tests:
2972
2973 2011-01-12  Koan-Sin Tan  <koansin.tan@gmail.com>
2974
2975         Reviewed by Martin Robinson.
2976
2977         [Gtk] WebKitGtk+ doesn't build on Mac OS X 10.6
2978         https://bugs.webkit.org/show_bug.cgi?id=50867
2979
2980         Fixed library extention for Mac in webkitdirs.pm and type conflict in
2981         TestNetscapePlugin.cpp 
2982
2983         * GNUmakefile.am: Don't use AppKit when compiling TestNetscapePlugin for GTK+
2984         * Scripts/webkitdirs.pm:
2985
2986 2011-01-12  Mikhail Naganov  <mnaganov@chromium.org>
2987
2988         Reviewed by Pavel Feldman.
2989
2990         Add check-inspector-strings script.
2991
2992         https://bugs.webkit.org/show_bug.cgi?id=52295
2993
2994         * Scripts/check-inspector-strings: Added.
2995
2996 2011-01-12  Adam Roben  <aroben@apple.com>
2997
2998         Advertise the .testnetscape file extension on Windows
2999
3000         Fixes <http://webkit.org/b/52298>
3001         plugins/no-mime-with-valid-extension.html fails on Windows
3002
3003         Reviewed by Dan Bernstein.
3004
3005         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Added a
3006         FileExtents field to map the .testnetscape file extension to the
3007         application/x-webkit-test-netscape MIME type, just as we do on Mac.
3008
3009 2011-01-12  Adam Barth  <abarth@webkit.org>
3010
3011         Reviewed by Eric Seidel.
3012
3013         Make webkit-patch support subdirectories for SVN checkouts
3014         https://bugs.webkit.org/show_bug.cgi?id=52261
3015
3016         os.relpath does not exist on Python 2.5, so we need to call our version
3017         of the API.
3018
3019         * Scripts/webkitpy/common/checkout/scm.py:
3020
3021 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
3022
3023         Reviewed by Eric Seidel.
3024
3025         Close additional pages opened during a test once the test completes.
3026         https://bugs.webkit.org/show_bug.cgi?id=52276
3027
3028         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3029         (WTR::InjectedBundle::done):
3030
3031 2011-01-11  David Levin  <levin@chromium.org>
3032
3033         Reviewed by Eric Seidel.
3034
3035         Errors should be separated from the command line in bot messages.
3036         https://bugs.webkit.org/show_bug.cgi?id=52275
3037
3038         * Scripts/webkitpy/common/system/executive.py:
3039         (ScriptError.message_with_output): Added a newline to separate the command
3040         line from the errors.
3041         * Scripts/webkitpy/common/system/executive_unittest.py:
3042         (ScriptErrorTest.test_message_with_output): Added tests for the various code
3043         paths in message_with_output.
3044
3045 2011-01-11  Eric Seidel  <eric@webkit.org>
3046
3047         Unreviewed.
3048
3049         commit-queue should know how to upload archived results (for test flakes or general failures)
3050         https://bugs.webkit.org/show_bug.cgi?id=52048
3051
3052         The zips are mostly empty due to forgetting -r.
3053         Expected diffs were not being pulled from the archive due
3054         to the archive having longer paths than I realized.
3055
3056         * Scripts/webkitpy/common/system/workspace.py:
3057         * Scripts/webkitpy/common/system/workspace_unittest.py:
3058         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3059         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3060
3061 2011-01-11  Dirk Pranke  <dpranke@chromium.org>
3062
3063         Reviewed by Ojan Vafai.
3064
3065         The current modifier parsing code in test_expectations is
3066         fragile and hard-coded, so it's not easy to understand the logic
3067         or easily add new types of modifiers (like GPU vs. CPU testing
3068         for graphics tests, or 32-bit vs. 64-bit differences).
3069
3070         This is the first of two patches that will add in more generic
3071         support and then eliminate the GPU-specific test expectations
3072         files for Chromium.
3073
3074         This patch adds two standalone objects for handling modifiers. The
3075         rules for interpreting modifiers, precedence, and conflicts are
3076         given in the docstring to the ModifierMatcher class, which
3077         returns ModifierMatchResult objects.
3078         
3079         This patch also adds routines to the Port interface and a
3080         default set of values in the base object, in order to obtain the
3081         values needed on a given test run. These values are then passed
3082         to the expectation parser. This also allows us to clean up the
3083         logic used to lint all of the different configurations in a
3084         single test_expectations.txt file.
3085
3086         The next patch will merge in the separate GPU expectations file.
3087
3088         https://bugs.webkit.org/show_bug.cgi?id=51222
3089
3090         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
3091         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
3092         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
3093         * Scripts/webkitpy/layout_tests/port/base.py:
3094         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3095         * Scripts/webkitpy/layout_tests/port/chromium.py:
3096         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3097         * Scripts/webkitpy/layout_tests/port/test.py:
3098         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3099         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3100
3101 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
3102
3103         Reviewed by Adam Barth.
3104
3105         Make webkit-patch support subdirectories for SVN checkouts
3106         https://bugs.webkit.org/show_bug.cgi?id=52261
3107
3108         * Scripts/webkitpy/common/checkout/scm.py:
3109         * Scripts/webkitpy/style_references.py:
3110         * Scripts/webkitpy/tool/main.py:
3111         * Scripts/webkitpy/tool/steps/preparechangelog.py:
3112
3113 2011-01-11  Eric Seidel  <eric@webkit.org>
3114
3115         Unreviewed.
3116
3117         commit-queue should know how to upload archived results (for test flakes or general failures)
3118         https://bugs.webkit.org/show_bug.cgi?id=52048
3119
3120         I changed the API for archive_last_layout_test_results w/o updating the implementation.  Oops.
3121         This fixes an exception seen on the commit-queue when attempting to report flaky tests.
3122
3123         * Scripts/webkitpy/common/system/workspace.py:
3124         * Scripts/webkitpy/common/system/workspace_unittest.py:
3125         * Scripts/webkitpy/tool/commands/queues.py:
3126
3127 2011-01-11  Sam Weinig  <sam@webkit.org>
3128
3129         Roll r75474 back in.
3130
3131 2011-01-11  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
3132
3133         Reviewed by Kenneth Rohde Christiansen.
3134
3135         [Qt] Remove uses of QFuture since it isn't supported on all platforms.
3136         https://bugs.webkit.org/show_bug.cgi?id=51204
3137
3138         * QtTestBrowser/webpage.h:
3139         (QtNAMThread::QtNAMThread):
3140         (QtNAMThread::networkAccessManager):
3141         (QtNAMThread::run):
3142
3143 2011-01-11  Peter Varga  <pvarga@webkit.org>
3144
3145         Unreviewed.
3146
3147         Add myself to committers' list.
3148
3149         * Scripts/webkitpy/common/config/committers.py:
3150
3151 2011-01-11  Eric Seidel  <eric@webkit.org>
3152
3153         Reviewed by Adam Barth.
3154
3155         commit-queue should know how to upload archived results (for test flakes or general failures)
3156         https://bugs.webkit.org/show_bug.cgi?id=52048
3157
3158         Now the queue will always upload results.  Either the entire zip, or just
3159         the diffs.txt in the case of text failures.
3160
3161         This should make understanding flakes much easier, and paves the way
3162         for having the EWS run layout tests (and upload failures).
3163
3164         In order to upload .zip files I had to teach bugzilla.py to autodetect
3165         mime types from the filename.  Since mimetypes.py doesn't include a mapping
3166         for .patch files, I have it add one before calling guess_type.
3167
3168         We may find that always uploading the whole zip instead of just the -diffs.txt
3169         file is preferable, but for now I'm keeping the old behavior because it makes
3170         quickly understanding text failures easy.
3171
3172         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3173         * Scripts/webkitpy/common/system/workspace.py: Added.
3174         * Scripts/webkitpy/common/system/workspace_unittest.py: Added.
3175         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3176         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3177         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3178         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3179         * Scripts/webkitpy/tool/commands/queues.py:
3180         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3181
3182 2011-01-10  Sheriff Bot  <webkit.review.bot@gmail.com>
3183
3184         Unreviewed, rolling out r75464.
3185         http://trac.webkit.org/changeset/75464
3186         https://bugs.webkit.org/show_bug.cgi?id=52193
3187
3188         Followup rollout for 75474 (Requested by Ossy on #webkit).
3189
3190         * MiniBrowser/mac/BrowserWindowController.m:
3191         (-[BrowserWindowController awakeFromNib]):
3192         * MiniBrowser/win/BrowserView.cpp:
3193         (BrowserView::create):
3194         * WebKitTestRunner/TestController.cpp:
3195         (WTR::createOtherPage):
3196         (WTR::TestController::initialize):
3197
3198 2011-01-10  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3199
3200         Reviewed by Csaba Osztrogonác.
3201
3202         [Qt] Baseline qt_minimal configuration
3203         https://bugs.webkit.org/show_bug.cgi?id=51313
3204
3205         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3206         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): Add
3207         QT_NO_UNDOSTACK guard.
3208
3209         * QtTestBrowser/launcherwindow.cpp:
3210         (LauncherWindow::createChrome): Add QT_NO_SHORTCUT and QT_NO_PRINTER
3211         guards.
3212         (LauncherWindow::applyZoom): Add QT_NO_ANIMATION guard.
3213         (LauncherWindow::screenshot): Add QT_NO_FILEDIALOG guard.
3214         (LauncherWindow::selectElements): Add QT_NO_INPUTDIALOG guard.
3215         (LauncherWindow::showUserAgentDialog): Add QT_NO_COMBOBOX guard.
3216
3217         * QtTestBrowser/launcherwindow.h:
3218         * QtTestBrowser/locationedit.cpp: Add QT_NO_INPUTDIALOG guard.
3219         * QtTestBrowser/locationedit.h: Ditto.
3220
3221         * QtTestBrowser/mainwindow.cpp:
3222         (MainWindow::buildUI): Add QT_NO_INPUTDIALOG, QT_NO_SHORTCUT and
3223         QT_NO_UNDOSTACK guards.
3224         (MainWindow::setAddressUrl): Add QT_NO_INPUTDIALOG guard.
3225         (MainWindow::changeLocation): Ditto.
3226         (MainWindow::openFile): Add QT_NO_FILEDIALOG guard.
3227         (MainWindow::openLocation): Add QT_NO_INPUTDIALOG guard.
3228
3229         * QtTestBrowser/webpage.cpp:
3230         (WebPage::openUrlInDefaultBrowser): Add QT_NO_DESKTOPSERVICES guard.
3231         (WebPage::authenticationRequired): Add QT_NO_LINEEDIT guard.
3232
3233         * QtTestBrowser/webview.cpp:
3234         (WebViewGraphicsBased::animatedFlip): Add QT_NO_ANIMATION guard.
3235         (WebViewGraphicsBased::animatedYFlip): Ditto.
3236
3237 2011-01-10  Sam Weinig  <sam@webkit.org>
3238
3239         Fix build.
3240
3241         * MiniBrowser/mac/BrowserWindowController.m:
3242         (-[BrowserWindowController awakeFromNib]):
3243         * MiniBrowser/win/BrowserView.cpp:
3244         (BrowserView::create):
3245         * WebKitTestRunner/TestController.cpp:
3246         (WTR::createOtherPage):
3247         (WTR::TestController::initialize):
3248
3249 2011-01-10  Eric Seidel  <eric@webkit.org>
3250
3251         Reviewed by Ojan Vafai.
3252
3253         style-queue messages are way too long for big patches
3254         https://bugs.webkit.org/show_bug.cgi?id=52161
3255
3256         We definitely could build much fancier list-to-string-with-limit functions
3257         but this should be sufficient for our needs at the moment.
3258
3259         * Scripts/webkitpy/common/system/executive.py:
3260         * Scripts/webkitpy/common/system/executive_unittest.py:
3261
3262 2011-01-10  Tony Chang  <tony@chromium.org>
3263
3264         Unreviewed, rolling out r75398.
3265         http://trac.webkit.org/changeset/75398
3266         https://bugs.webkit.org/show_bug.cgi?id=52008
3267
3268         Some layout tests are crashing on Chromium Win.
3269
3270         * DumpRenderTree/chromium/WebViewHost.cpp:
3271         (WebViewHost::updatePaintRect):
3272         * DumpRenderTree/chromium/WebViewHost.h:
3273
3274 2011-01-10  Adam Roben  <aroben@apple.com>
3275
3276         Roll out r75392
3277
3278         It isn't needed now that r75289 has been rolled out.
3279
3280         * Scripts/run-javascriptcore-tests:
3281
3282 2011-01-10  Maciej Stachowiak  <mjs@apple.com>
3283
3284         Reviewed by Anders Carlsson.
3285
3286         WebKitTestRunner uses crazy amounts of CPU, making layout tests slow and flaky
3287         https://bugs.webkit.org/show_bug.cgi?id=52160
3288
3289         * WebKitTestRunner/mac/TestControllerMac.mm:
3290         (WTR::TestController::platformRunUntil): Instead of busy-looping, wait for the timeout.
3291         Anything that can make runUntil() conditions turn true will happen on a run loop cycle
3292         anyway.
3293
3294 2011-01-10  Tony Chang  <tony@chromium.org>
3295
3296         Reviewed by Mihai Parparita.
3297
3298         [chromium] fix for animated gif layout tests
3299         https://bugs.webkit.org/show_bug.cgi?id=52008
3300
3301         * DumpRenderTree/chromium/WebViewHost.cpp: Schedule a paint when we update the paint rect
3302             to trigger gif animations.
3303         (WebViewHostPaintTask::WebViewHostPaintTask):
3304         (WebViewHostPaintTask::runIfValid):
3305         (WebViewHost::updatePaintRect):
3306         * DumpRenderTree/chromium/WebViewHost.h:
3307         (WebViewHost::taskList):
3308
3309 2011-01-10  Alejandro G. Castro  <alex@igalia.com>
3310
3311         Reviewed by Xan Lopez.
3312
3313         [GTK] Fix gtk2 compilation for master
3314         https://bugs.webkit.org/show_bug.cgi?id=51885
3315
3316         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
3317         (createBitmapContextFromWebView): Replaced the old
3318         gdk_drawable_get_size with gdk_pixmap_get_size.
3319
3320 2011-01-10  Patrick Gansterer  <paroga@webkit.org>
3321
3322         Reviewed by Laszlo Gombos.
3323
3324         [WINCE] Reenable NPAPI after r75203
3325         https://bugs.webkit.org/show_bug.cgi?id=52109
3326
3327         Remove the !isWinCE() check for ENABLE_NETSCAPE_PLUGIN_API and replace
3328         it with !isEfl(), because EFL port does not support NPAPI (yet).
3329
3330         * Scripts/build-webkit:
3331
3332 2011-01-10  Adam Roben  <aroben@apple.com>
3333
3334         Skip some asserting JS tests
3335
3336         See <http://webkit.org/b/52156>.
3337
3338         * Scripts/run-javascriptcore-tests:
3339
3340 2011-01-10  Martin Robinson  <mrobinson@igalia.com>
3341
3342         Reviewed by Xan Lopez.
3343
3344         [GTK] build-webkit disable Blob support via arguments passed to automake
3345         https://bugs.webkit.org/show_bug.cgi?id=52097
3346
3347         * Scripts/build-webkit: Enable Blob support when building WebKitGTK+ via
3348         build-webkit.
3349
3350 2011-01-10  Adam Roben  <aroben@apple.com>
3351
3352         Use the same name and description for TestNetscapePlugin on Windows and
3353         Mac
3354
3355         Fixes <http://webkit.org/b/52151>
3356         fast/frames/iframe-reparenting-plugins.html fails on Windows
3357
3358         Reviewed by Steve Falkenburg.
3359
3360         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Copied
3361         the name and description from Mac's Info.plist.
3362
3363 2011-01-10  Siddharth Mathur <siddharth.mathur@nokia.com>
3364
3365         Reviewed by Laszlo Gombos.
3366
3367         [Qt][WK2] Guard gcc-specific syntax
3368
3369         Non-gcc based compliers choke on the "-include"
3370         syntax for preinclude, place guard around it.
3371
3372         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3373         * WebKitTestRunner/qt/WebKitTestRunner.pro:
3374
3375 2011-01-10  Andreas Kling  <kling@webkit.org>
3376
3377         Reviewed by Simon Hausmann.
3378
3379         [Qt] [WK2] MiniBrowser does not load pages opened in new windows
3380         https://bugs.webkit.org/show_bug.cgi?id=52111
3381
3382         When getting a createNewPage() callback from QWKPage, create the
3383         new page with the same QWKContext as the page that is passed to
3384         the callback.
3385
3386         * MiniBrowser/qt/BrowserView.h:
3387         * MiniBrowser/qt/BrowserWindow.cpp:
3388         (newPageFunction):
3389         (BrowserWindow::BrowserWindow):
3390         * MiniBrowser/qt/BrowserWindow.h:
3391
3392 2011-01-10  Andreas Kling  <kling@webkit.org>
3393
3394         Reviewed by Kenneth Rohde Christiansen.
3395
3396         [Qt] MiniBrowser: Remove superfluous createNewPage() callback
3397
3398         BrowserView set its own useless createNewPage() callback on QWKPage.
3399         This was immediately overridden by BrowserWindow anyway, so remove
3400         the BrowserView one.
3401
3402         * MiniBrowser/qt/BrowserView.cpp:
3403         (BrowserView::BrowserView):
3404
3405 2011-01-10  John Knottenbelt  <jknotten@chromium.org>
3406
3407         Reviewed by Jeremy Orlow.
3408
3409         [Chromium] Remove non-client-based Geolocation code
3410         https://bugs.webkit.org/show_bug.cgi?id=50921
3411
3412         * DumpRenderTree/chromium/LayoutTestController.cpp:
3413         (LayoutTestController::setGeolocationPermission):
3414         (LayoutTestController::setMockGeolocationPosition):
3415         (LayoutTestController::setMockGeolocationError):
3416         * DumpRenderTree/chromium/WebViewHost.cpp:
3417         (WebViewHost::geolocationClientMock):
3418         (WebViewHost::reset):
3419         * DumpRenderTree/chromium/WebViewHost.h:
3420
3421 2011-01-10  Eric Seidel  <eric@webkit.org>
3422
3423         Reviewed by Adam Barth.
3424
3425         Commit bot tried to land r? cq+ patch
3426         https://bugs.webkit.org/show_bug.cgi?id=36638
3427
3428         It should now be possible to post a patch with r? and cq+ and the
3429         commit-queue will correctly wait for the r+ before attempting to land the patch.
3430         (This was a feature requested by several users.)
3431
3432         One caveat: We don't actually reject r-, cq+ patches from the queue
3433         (we just ignore them), but I think that's OK for now.
3434
3435         I also noticed that setting r- once a commit-queue node had grabbed
3436         a patch would not properly cancel the landing.  That's fixed and
3437         tested in this patch.
3438
3439         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3440         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3441         * Scripts/webkitpy/tool/bot/feeders.py:
3442         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
3443
3444 2011-01-08  Benjamin Poulain  <benjamin.poulain@nokia.com>
3445
3446         Reviewed by Kenneth Rohde Christiansen.
3447
3448         [Qt] QtWebKit crashes when using XMLHttpRequest from the unload event
3449         https://bugs.webkit.org/show_bug.cgi?id=51934
3450
3451         When accessing the network from the destructor of QWebPage, the network access manager
3452         was already deleted because the object WebPage was already destructed.
3453
3454         This solve the problem by linking the lifetime of the network access manager to WebPage's QObject.
3455         The object is now destructed in the destructor of QObject.
3456
3457         * QtTestBrowser/webpage.cpp:
3458         (WebPage::WebPage):
3459         (WebPage::setQnamThreaded):
3460         * QtTestBrowser/webpage.h:
3461         (QtNAMThread::QtNAMThread):
3462
3463 2011-01-08  Eric Seidel  <eric@webkit.org>
3464
3465         Reviewed by Ojan Vafai.
3466
3467         test_failures.py should not mention TestShell (long live DumpRenderTree!)
3468         https://bugs.webkit.org/show_bug.cgi?id=52067
3469
3470         I ran test-webkitpy, but didn't bother adding a unit test for this string change.
3471         https://bugs.webkit.org/show_bug.cgi?id=51138#c3 is an example of why this is needed.
3472
3473         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
3474
3475 2011-01-08  Eric Seidel  <eric@webkit.org>
3476
3477         Reviewed by Mihai Parparita.
3478
3479         commit-queue hangs when the ChangeLog diff is bad
3480         https://bugs.webkit.org/show_bug.cgi?id=52072
3481
3482         * Scripts/webkitpy/tool/steps/validatechangelogs.py:
3483         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
3484
3485 2011-01-08  Adam Barth  <abarth@webkit.org>
3486
3487         Teach svn-apply how to re-write WebCore to Source/WebCore.
3488
3489         * Scripts/VCSUtils.pm:
3490
3491 2011-01-07  Adam Barth  <abarth@webkit.org>
3492
3493         Rubber-stamped by Eric Seidel.
3494
3495         Move WebCore to Source
3496         https://bugs.webkit.org/show_bug.cgi?id=52050
3497
3498         Update the tools to understand WebCore's new location.
3499
3500         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3501         * DumpRenderTree/wscript:
3502         * GNUmakefile.am:
3503         * Scripts/build-webkit:
3504         * Scripts/do-file-rename:
3505         * Scripts/do-webcore-rename:
3506         * Scripts/generate-qt-inspector-resource:
3507         * Scripts/prepare-ChangeLog:
3508         * Scripts/run-bindings-tests:
3509         * Scripts/update-iexploder-cssproperties:
3510         * Scripts/update-sources-list.py:
3511         * Scripts/update-webkit-localizable-strings:
3512         * Scripts/webkitdirs.pm:
3513         * Scripts/webkitpy/common/config/build.py:
3514         * Scripts/webkitpy/common/config/build_unittest.py:
3515         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
3516         * Scripts/webkitpy/style/checker.py:
3517         * Scripts/webkitpy/style/checker_unittest.py:
3518         * WebKitTestRunner/DerivedSources.pro:
3519         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3520         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh:
3521         * wx/browser/wscript:
3522         * wx/build/settings.py:
3523
3524 2011-01-07  Maciej Stachowiak  <mjs@apple.com>
3525
3526         Reviewed by Sam Weinig.
3527
3528         Make WebKitTestRunner rest between loads more robust to avoid test crashes
3529         https://bugs.webkit.org/show_bug.cgi?id=52086
3530
3531         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3532         (WTR::InjectedBundle::didReceiveMessage):
3533         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3534         (WTR::LayoutTestController::notifyDone):
3535         * WebKitTestRunner/TestController.cpp:
3536         (WTR::TestController::resetStateToConsistentValues):
3537         (WTR::TestController::run):
3538
3539 2011-01-07  James Robinson  <jamesr@chromium.org>
3540
3541         Revert "Implement mozilla's animationTime property"
3542         https://bugs.webkit.org/show_bug.cgi?id=51952
3543
3544         This approach isn't quite right.
3545
3546         * DumpRenderTree/chromium/WebViewHost.cpp:
3547         (WebViewHost::paintInvalidatedRegion):
3548
3549 2011-01-07  Adam Roben  <aroben@apple.com>
3550
3551         Build master fix
3552
3553         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3554         (RunWebKitTests.start): Don't try to concatenate a list and a string.
3555
3556 2011-01-07  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>
3557
3558         Reviewed by Csaba Osztrogonác.
3559
3560         run-qtwebkit-tests should be able to kill a testsuite.
3561
3562         Add new option in the script that can setup a timeout for a test.
3563         If the test execution takes more then specified time then the test
3564         would be terminated.
3565
3566         [Qt] run-qtwebkit-tests needs timeout
3567         https://bugs.webkit.org/show_bug.cgi?id=51894
3568
3569         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3570         * Scripts/run-qtwebkit-tests:
3571
3572 2011-01-07  Csaba Osztrogonác  <ossy@webkit.org>
3573
3574         Unreviewed fix after r75233.
3575
3576         Based on idea from Eric Seidel.
3577
3578         Add remote zip file handling to webkitpy.
3579         https://bugs.webkit.org/show_bug.cgi?id=50901
3580
3581         * Scripts/webkitpy/common/system/fileset.py: Make python 2.5 happy.
3582
3583 2011-01-07  Shane Stephens  <shanestephens@google.com>
3584
3585         Reviewed by Eric Seidel.
3586
3587         svn-apply: should support git binary delta diffs
3588         https://bugs.webkit.org/show_bug.cgi?id=38864
3589
3590         * Scripts/VCSUtils.pm:
3591         * Scripts/svn-apply:
3592
3593 2011-01-06  Julie Parent  <jparent@chromium.org>
3594
3595         Reviewed by Eric Seidel.
3596
3597         Test Result Server not removing old results.
3598         https://bugs.webkit.org/show_bug.cgi?id=52012
3599
3600         * TestResultServer/model/jsonresults.py:
3601         Fix off-by-one: Truncate if >= num_runs, not just >.
3602         * TestResultServer/model/jsonresults_unittest.py:
3603         Add unit test to test that merging in a new result with the same value
3604         as the last result causes previous result to fall off.
3605
3606 2011-01-06  James Kozianski  <koz@chromium.org>
3607
3608         Reviewed by Mihai Parparita.
3609
3610         Add classes to provide a consistent interface to a set of files.
3611         https://bugs.webkit.org/show_bug.cgi?id=50901
3612
3613         These classes allow us to write code that is agnostic to whether a
3614         particular set of files resides in a local directory or in a zip file
3615         on a remote machine.
3616
3617         * Scripts/webkitpy/common/system/directoryfileset.py: Added.
3618         * Scripts/webkitpy/common/system/directoryfileset_unittest.py: Added.
3619         * Scripts/webkitpy/common/system/fileset.py: Added.
3620         * Scripts/webkitpy/common/system/filesystem.py:
3621         * Scripts/webkitpy/common/system/filesystem_mock.py:
3622         * Scripts/webkitpy/common/system/zipfileset.py: Added.
3623         * Scripts/webkitpy/common/system/zipfileset_unittest.py: Added.
3624
3625 2011-01-06  Eric Seidel  <eric@webkit.org>
3626
3627         Reviewed by Adam Barth.
3628
3629         NetworkTransaction should log the url it is retrying
3630         https://bugs.webkit.org/show_bug.cgi?id=52043
3631
3632         * Scripts/webkitpy/common/net/networktransaction.py:
3633         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
3634
3635 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
3636
3637         Windows build fix.
3638         Import os before using it.
3639
3640         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3641
3642 2011-01-06  Eric Seidel  <eric@webkit.org>
3643
3644         Reviewed by Adam Barth.
3645
3646         StyleQueue fails to report errors when patches have many files
3647         https://bugs.webkit.org/show_bug.cgi?id=52042
3648
3649         This is one of at least two errors preventing style error reporting at the moment.
3650         When we moved to passing the list of files to check explicitly,
3651         we started to exceed the 500 character TEXT field limit for our AppEngine model object.
3652         We could change the type of the QueueStatus.message type, or we could
3653         just teach statusserver.py how to clamp values (and warn when it does).
3654         I chose the latter path.
3655
3656         * Scripts/webkitpy/common/net/statusserver.py:
3657
3658 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
3659
3660         Reviewed by Stephanie Lewis.
3661         
3662         Fix syntax error in script.
3663
3664         Windows bots need to archive/unarchive builds to/from configuration-specific directories
3665         https://bugs.webkit.org/show_bug.cgi?id=51996
3666
3667         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3668
3669 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3670
3671         Unreviewed, fixing WinCE build after r75196.
3672
3673         WinCE port does not (yet) support NPAPI.
3674
3675         * Scripts/build-webkit:
3676
3677 2011-01-06  Xan Lopez  <xlopez@igalia.com>
3678
3679         Reviewed by Darin Adler.
3680
3681         File::Spec->rel2abs in sunspider-compare-results mangles parameters
3682         https://bugs.webkit.org/show_bug.cgi?id=52015
3683
3684         * Scripts/sunspider-compare-results: call rel2abs on our arguments
3685         after the platform has been detected, otherwise the script will
3686         mangle things like '--gtk' into '/a/path/--gtk', breaking the
3687         detection.
3688
3689 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3690
3691         Reviewed by Eric Seidel.
3692
3693         Add ENABLE_NETSCAPE_PLUGIN_API, ENABLE_ORIENTATION_EVENTS and ENABLE_TOUCH_EVENTS flags to build-webkit
3694         https://bugs.webkit.org/show_bug.cgi?id=51346
3695
3696         * Scripts/build-webkit:
3697
3698 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
3699
3700         Reviewed by Adam Roben.
3701
3702         Windows bots need to archive/unarchive builds to/from configuration-specific directories
3703         https://bugs.webkit.org/show_bug.cgi?id=51996
3704         
3705         After the configuration directory change, we were archiving the incorrect directory for
3706         build product, so we were running tests on the wrong binaries.
3707         
3708         This change archives the correct directory, and also unarchives it into a configuration-
3709         specific directory.
3710
3711         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Use a configuration-specific directory on Windows.
3712         * BuildSlaveSupport/built-product-archive: Unarchive/archive to/from proper directory.
3713
3714 2011-01-06  Eric Seidel  <eric@webkit.org>
3715
3716         Reviewed by Mihai Parparita.
3717
3718         commit-queue mentions "Text diff mismatch" 4 times instead of once per failure
3719         https://bugs.webkit.org/show_bug.cgi?id=52002
3720
3721         See an example of this here:
3722         https://bugs.webkit.org/show_bug.cgi?id=51314#c2
3723
3724         It's due to the fact that we pass around TestFailure() instance
3725         objects and yet expect them to all compare to be the same.
3726
3727         This is bad.  We should either have shared instances of these values
3728         or we should just pass around the class names.  There are already hacks
3729         in place to make TestFailure objects pass equality tests, I just added
3730         a __hash__ implementation so they can be used in sets as expected.
3731
3732         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3733         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
3734
3735 2011-01-06  Evan Martin  <evan@chromium.org>
3736
3737         Reviewed by Tony Chang.
3738
3739         [gdb] handle inaccessible memory and UChar*
3740         https://bugs.webkit.org/show_bug.cgi?id=52003
3741
3742         To pretty-print a UChar*, we just grope around in the memory
3743         looking for a terminating NUL.  We need to handle the exception
3744         that can occur when we poke into an invalid location.
3745
3746         Additionally, the logic for choosing which pretty-printer would
3747         early return before hitting the point where we'd use the UChar*
3748         printer.  (Did this ever work?  How did it regress?)
3749
3750         * gdb/webkit.py:
3751
3752 2011-01-05  Brian Weinstein  <bweinstein@apple.com>
3753
3754         Reviewed by Ada Chan.
3755
3756         WebKit2: Should be able to call into injected bundle to ask if we should allow resource loads
3757         https://bugs.webkit.org/show_bug.cgi?id=51969
3758         
3759         Add shouldLoadResourceForFrame to WTR::InjectedBundlePage.
3760
3761         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3762         (WTR::InjectedBundlePage::InjectedBundlePage):
3763         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Stub implementation.
3764         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3765
3766 2011-01-06  James Robinson  <jamesr@chromium.org>
3767
3768         Reviewed by Simon Fraser.
3769
3770         Implement mozilla's animationTime property
3771         https://bugs.webkit.org/show_bug.cgi?id=51952
3772
3773         Chromium DRT support for webkitAnimationTime.
3774
3775         * DumpRenderTree/chromium/WebViewHost.cpp:
3776         (WebViewHost::paintInvalidatedRegion):
3777
3778 2011-01-06  Julie Parent  <jparent@chromium.org>
3779
3780         Reviewed by Tony Chang.
3781
3782         Test Result Server always truncates number of results to JSON_RESULTS_MAX_BUILDS
3783         https://bugs.webkit.org/show_bug.cgi?id=51217
3784
3785         * TestResultServer/model/jsonresults.py:
3786         Pass num_runs through to _remove_items_over_max_number_of_builds, and use the value.
3787         Adds missing documentation.
3788         * TestResultServer/model/jsonresults_unittest.py:
3789         Add unit test to test that truncation happens at smaller value than JSON_RESULTS_MAX_BUILDS.
3790         Update test_merge to take a number of builds to truncate at.
3791
3792 2011-01-06  Adam Barth  <abarth@webkit.org>
3793
3794         Reviewed by Eric Seidel.
3795
3796         The EWS should log outside of the working directory
3797         https://bugs.webkit.org/show_bug.cgi?id=51986
3798
3799         This patch prepare us for using git clean -x -d -f in the EWS wrapper
3800         script, which will actually clean the working copy back to a pristine
3801         state instead of leaving untracked directories and ignored files.
3802
3803         * Scripts/webkitpy/tool/commands/queues.py:
3804         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3805
3806 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
3807
3808         Windows build fix.
3809         Back out attempted change to built-product-archive.
3810
3811         * BuildSlaveSupport/built-product-archive:
3812
3813 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
3814
3815         Windows build fix.
3816         Include configuration name when unpacking a build archive.
3817
3818         Needed, since we split Windows build results into configuration-specific directories
3819         under WebKitOutputDir.
3820
3821         * BuildSlaveSupport/built-product-archive:
3822
3823 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
3824
3825         Reviewed by Darin Adler.
3826
3827         Debug and Release builds on Windows clobber each other
3828         https://bugs.webkit.org/show_bug.cgi?id=49185
3829
3830         Changes the structure of WebKitBuild build products directory so we
3831         completely separate each build configuration into independent directories.
3832         
3833         Although we previously had per-configuration directories for obj, this change adds
3834         per-configuration directories for bin, lib, obj, and include. Each configuration's
3835         build products are stored within a directory inside of WebKitBuild.
3836         
3837         Most use of $(WebKitOutputDir) in the build files has been replaced by $(ConfigurationBuildDir),
3838         defined in common.vsprops to be $(WebKitOutputDir)\$(ConfigurationName).
3839
3840         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops:
3841         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd:
3842         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd:
3843         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
3844         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd:
3845         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd:
3846         * DumpRenderTree/win/ImageDiffCommon.vsprops:
3847         * DumpRenderTree/win/ImageDiffPostBuild.cmd:
3848         * DumpRenderTree/win/ImageDiffPreBuild.cmd:
3849         * FindSafari/FindSafari.vcproj:
3850         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
3851         * MiniBrowser/MiniBrowserPostBuild.cmd:
3852         * MiniBrowser/MiniBrowserPreBuild.cmd:
3853         * Scripts/webkitdirs.pm:
3854         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
3855         * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops:
3856         * TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd:
3857         * TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd:
3858         * TestWebKitAPI/win/copy-resources.cmd:
3859         * WebKitAPITest/WebKitAPITestCommon.vsprops:
3860         * WebKitAPITest/WebKitAPITestPostBuild.cmd:
3861         * WebKitAPITest/WebKitAPITestPreBuild.cmd:
3862         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
3863         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
3864         * WebKitTestRunner/win/InjectedBundle.vcproj:
3865         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops:
3866         * WebKitTestRunner/win/InjectedBundlePostBuild.cmd:
3867         * WebKitTestRunner/win/InjectedBundlePreBuild.cmd:
3868         * WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd:
3869         * WebKitTestRunner/win/WebKitTestRunnerPreBuild.cmd:
3870         * WinLauncher/WinLauncherCommon.vsprops:
3871         * WinLauncher/WinLauncherPostBuild.cmd:
3872         * WinLauncher/WinLauncherPreBuild.cmd:
3873
3874 2011-01-05  Jan Erik Hanssen  <jhanssen@sencha.com>
3875
3876         Reviewed by Ariya Hidayat.
3877
3878         [Qt] TestNetscapePlugin doesn't link on OS X
3879         https://bugs.webkit.org/show_bug.cgi?id=51948
3880
3881         Only add a dependency on libX11 on X11 systems
3882
3883         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3884
3885 2011-01-05  Jeff Miller  <jeffm@apple.com>
3886
3887         Reviewed by Adam Roben.
3888
3889         check-webkit-style should allow unnecessary parameter names in WebKit2 APIs because we're matching CF's header style
3890         https://bugs.webkit.org/show_bug.cgi?id=51970
3891
3892         * Scripts/webkitpy/style/checker.py:
3893         Add -readability/naming for WebKit2 C API directories.
3894
3895 2011-01-05  Eric Seidel  <eric@webkit.org>
3896
3897         Unreviewed, just fixing one more log error from my previous python patch.
3898
3899         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
3900         https://bugs.webkit.org/show_bug.cgi?id=51802
3901
3902         webkit-patch failure-reason was logging about parsing errors
3903         due to my misunderstanding of how BeautifulSoup.findAll worked.
3904
3905         Fixed, and added a unit test.
3906
3907         * Scripts/webkitpy/common/net/layouttestresults.py:
3908         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3909
3910 2011-01-05  Benjamin Poulain  <benjamin.poulain@nokia.com>
3911
3912         Reviewed by Kenneth Rohde Christiansen.
3913
3914         [Qt] [WK2] Add the possibility to open window from the WebProcess in Minibrowser
3915         https://bugs.webkit.org/show_bug.cgi?id=51951
3916
3917         Set a function to QWKPage::setCreateNewPageFunction() in Minibrowser so there is a way
3918         to create new window from WebKit.
3919
3920         * MiniBrowser/qt/BrowserWindow.cpp:
3921         (newPageFunction):
3922         (BrowserWindow::BrowserWindow):
3923         (BrowserWindow::page): Added to avoid the indirect access to QWKPage spread in the class
3924         (BrowserWindow::newWindow):
3925         (BrowserWindow::updateUserAgentList):
3926         (BrowserWindow::showUserAgentDialog):
3927         * MiniBrowser/qt/BrowserWindow.h: Add the global variable backingStoreTypeForNewWindow to
3928         define the type of the backing store used for new windows.
3929         * MiniBrowser/qt/main.cpp:
3930         (main):
3931
3932 2011-01-05  Eric Seidel  <eric@webkit.org>
3933
3934         Reviewed by Ojan Vafai.
3935
3936         commit-queue should report failure type when reporting flaky tests
3937         https://bugs.webkit.org/show_bug.cgi?id=51900
3938
3939         This patch was a ridiculous amount of plumbing.  In the end I like
3940         the NRWT-style TestResult class even less.  But now we're passing
3941         a list of TestResult objects from the queue to the FlakyTestReporter.
3942         Thus the FlakyTestReporter can more easily report what type of failure
3943         occurred.
3944
3945         In the process, I found that I was not alone in finding TestResult
3946         cumbersome to use.  A bunch of code was trying to create a TestResult
3947         object with default values.  However since the constructor didn't make
3948         this easy, some places were getting it wrong (including the TestResult unit test)!
3949         I've fixed the TestResult constructor to have default values for non-essential
3950         arguments.
3951
3952         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3953         * Scripts/webkitpy/common/net/layouttestresults.py:
3954         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3955         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3956         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3957         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
3958         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
3959         * Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py:
3960         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
3961         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3962         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3963         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3964         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3965         * Scripts/webkitpy/tool/commands/queues.py:
3966         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3967
3968 2011-01-05  Eric Seidel  <eric@webkit.org>
3969
3970         Unreviewed.
3971
3972         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
3973         https://bugs.webkit.org/show_bug.cgi?id=51802
3974
3975         Add another unit test to cover a previously missing import.
3976
3977         * Scripts/webkitpy/common/net/layouttestresults.py:
3978         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3979
3980 2011-01-05  Mihai Parparita  <mihaip@chromium.org>
3981
3982         Reviewed by David Levin.
3983
3984         Add mihaip@chromium.org as a reviewer
3985         https://bugs.webkit.org/show_bug.cgi?id=51966
3986         
3987         Add myself as a reviewer.
3988
3989         * Scripts/webkitpy/common/config/committers.py:
3990
3991 2011-01-05  James Simonsen  <simonjam@chromium.org>
3992
3993         Unreviewed. Adding myself to the list of committers.
3994
3995         * Scripts/webkitpy/common/config/committers.py:
3996
3997 2011-01-05  Eric Seidel  <eric@webkit.org>
3998
3999         Unreviewed.
4000
4001         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
4002         https://bugs.webkit.org/show_bug.cgi?id=51802
4003
4004         Fix two exceptions seen on the bots after my original commit.
4005
4006         * Scripts/webkitpy/common/net/layouttestresults.py:
4007         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
4008
4009 2011-01-05  Kundu Suchismita  <suchi.kundu@nokia.com>
4010
4011         Reviewed by Andreas Kling.
4012
4013         [Qt]Add local storage settings to QtTestBrowser command line arguments 
4014         https://bugs.webkit.org/show_bug.cgi?id=51750
4015
4016         * QtTestBrowser/main.cpp:
4017         (LauncherApplication::handleUserOptions):
4018          Local storage settings can be enable form command line arguments for
4019          QtTestBrowser.
4020
4021 2011-01-05  Chris Fleizach  <cfleizach@apple.com>
4022
4023         Reviewed by Martin Robinson.
4024
4025         GTK: AX: DRT needs to use correct root object method.
4026         https://bugs.webkit.org/show_bug.cgi?id=51911
4027
4028         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
4029         (AccessibilityController::rootElement):
4030
4031 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
4032
4033         Rubber-stamped by Csaba Osztrogonác.
4034
4035         Based on idea from Péter Gál.
4036
4037         * Scripts/webkitpy/tool/bot/sheriff.py: Remove unnecessary apostrophes around revision numbers.
4038
4039 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
4040
4041         Reviewed by Adam Barth.
4042
4043         sheriff-bot should be able to do multi-revision rollouts
4044         https://bugs.webkit.org/show_bug.cgi?id=51176
4045
4046         * Scripts/webkitpy/tool/bot/irc_command.py:
4047         * Scripts/webkitpy/tool/bot/sheriff.py:
4048         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
4049
4050 2011-01-05  Eric Seidel  <eric@webkit.org>
4051
4052         Reviewed by Adam Barth.
4053
4054         queues.webkit.org should have per-bot status pages
4055         https://bugs.webkit.org/show_bug.cgi?id=51906
4056
4057         Just adds a /queue-status/QUEUE_NAME/bots/BOT_ID page to show
4058         statuses from a single queue.  Now that we have many bots servicing
4059         some queues (commit-queue, win-ews, etc.) its easy to have the messages
4060         you care about scroll off the end of the 15-message limit on the main page.
4061
4062         Eventually we should probably rename /queue-status to /queue or /queues,
4063         but that's fodder for another patch.
4064
4065         * QueueStatusServer/handlers/queuestatus.py:
4066         * QueueStatusServer/index.yaml:
4067         * QueueStatusServer/main.py:
4068         * QueueStatusServer/templates/includes/singlequeuestatus.html:
4069          - This probably should use a custom filter instead of hard-coding
4070            the URL scheme here, but I couldn't figure out how to easily
4071            create such a filter.  Most filters work with "strings" so we can't
4072            pass the status object.  We could add a method to the status
4073            object and call that, but that seemed a bit strange too.
4074         * QueueStatusServer/templates/queuestatus.html:
4075
4076 2011-01-05  Carlos Garcia Campos  <cgarcia@igalia.com>
4077
4078         Unreviewed. Adding myself to the list of committers.
4079
4080         * Scripts/webkitpy/common/config/committers.py:
4081
4082 2011-01-04  Koan-Sin Tan  <koansin.tan@gmail.com>
4083
4084         Reviewed by David Levin.
4085
4086         check-webkit-style treated some macros with parentheses after #elif as function calls
4087         https://bugs.webkit.org/show_bug.cgi?id=51695
4088
4089         Ingore function call space checking in any preprocessor directives
4090         (things starting with #). Change search() to match() because 
4091         preprocessor directives are supposed to be in the beginning of lines.
4092
4093         * Scripts/webkitpy/style/checkers/cpp.py:
4094         * Scripts/webkitpy/style/checkers/cpp_unittest.py: make sure there is no false positives for #elif cases
4095
4096 2011-01-04  Søren Gjesse  <sgjesse@chromium.org>
4097
4098         Reviewed by Tony Chang.
4099
4100         Change the --multi-load test option to --stress-opt
4101         https://bugs.webkit.org/show_bug.cgi?id=50751
4102
4103         * DumpRenderTree/chromium/DumpRenderTree.cpp:
4104         (runTest):
4105         (main):
4106         * DumpRenderTree/chromium/TestShell.cpp:
4107         (TestShell::TestShell):
4108         * DumpRenderTree/chromium/TestShell.h:
4109         (TestShell::stressOpt):
4110         (TestShell::setStressOpt):
4111         (TestShell::stressDeopt):
4112         (TestShell::setStressDeopt):
4113         (TestShell::javaScriptFlags):
4114         (TestShell::setJavaScriptFlags):
4115         * Scripts/webkitpy/layout_tests/port/chromium.py:
4116         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4117
4118 2011-01-04  Chris Fleizach  <cfleizach@apple.com>
4119
4120         Reviewed by Sam Weinig.
4121
4122         WK2: Support Accessibility
4123         https://bugs.webkit.org/show_bug.cgi?id=51859
4124
4125         Use rootObject() method to get top of accessibility tree.
4126
4127         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
4128         (AccessibilityController::focusedElement):
4129         (AccessibilityController::rootElement):
4130
4131 2011-01-03  Martin Robinson  <mrobinson@igalia.com>
4132
4133         Reviewed by Darin Adler.
4134
4135         Remove the last non-GObject usage of PlatformRefPtr and move the code to GRefPtr
4136         https://bugs.webkit.org/show_bug.cgi?id=51846
4137
4138         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: Change usage of PlatformRefPtr
4139         back to GRefPtr.
4140
4141 2011-01-04  Zhe Su  <suzhe@chromium.org>
4142
4143         Reviewed by Kenneth Russell.
4144
4145         Fix insertText, setMarkedText and unmarkText methods of
4146         TextInputController to call corresponding methods of WebKit::WebView
4147         rather than WebKit::WebFrame. This change matches the behavior of
4148         chromium browser.
4149         insertText corresponds to WebView::confirmComposition(text)
4150         setMarkedText corresponds to WebView::setComposition(...)
4151         unmarkText corresponds to WebView::confirmComposition()
4152         https://bugs.webkit.org/show_bug.cgi?id=51693
4153
4154         * DumpRenderTree/chromium/TextInputController.cpp:
4155         (TextInputController::insertText):
4156         (TextInputController::setMarkedText):
4157         (TextInputController::unmarkText):
4158
4159 2011-01-04  Dihan Wickremasuriya  <dihan.wickremasuriya@nokia.com>
4160
4161         Reviewed by Laszlo Gombos.
4162
4163         [Qt] [Symbian] Do not remove 0 byte sized files from productDir
4164
4165         On Symbian productDir points to the source directory. Removing all the
4166         empty files from the productDir directory corrupts the svn repository.
4167
4168         * Scripts/build-webkit:
4169
4170 2011-01-03  Yi Shen  <yi.4.shen@nokia.com>
4171
4172         Reviewed by Adam Barth.
4173
4174         [Qt] Add SelectAll option to the context menu for the editor
4175         https://bugs.webkit.org/show_bug.cgi?id=50049
4176
4177         Set shortcut for the SelectAll action.
4178
4179         * QtTestBrowser/mainwindow.cpp:
4180         (MainWindow::buildUI):
4181
4182 2011-01-03  David Levin  <levin@chromium.org>
4183
4184         Reviewed by Eric Seidel.
4185
4186         check-webkit-style shouldn't consider "value" automatically to be a meaningless name.
4187         https://bugs.webkit.org/show_bug.cgi?id=51842
4188
4189         * Scripts/webkitpy/style/checkers/cpp.py: Remove the check for value.
4190         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Remove the test for value.
4191
4192 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
4193
4194         Reviewed by David Kilzer.
4195
4196         [WINCE] Adds a build slave.
4197         https://bugs.webkit.org/show_bug.cgi?id=50523
4198
4199         * BuildSlaveSupport/build.webkit.org-config/config.json: Add an
4200         entry for a release build of the WinCE port.
4201         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add platform
4202         flag to build the WinCE port.
4203
4204 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
4205
4206         Reviewed by David Kilzer.
4207
4208         Add WinCE support to build-webkit
4209         https://bugs.webkit.org/show_bug.cgi?id=51642
4210
4211         * Scripts/build-webkit:
4212         * Scripts/webkitdirs.pm:
4213
4214 2011-01-03  Eric Seidel  <eric@webkit.org>
4215
4216         Reviewed by Adam Barth.
4217
4218         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
4219         https://bugs.webkit.org/show_bug.cgi?id=51802
4220
4221         I'm not the biggest fan of the test_failures or test_results classes,
4222         but it's better to have one shared set of classes, than separate ones
4223         for new vs. old run-webkit-test result handling.
4224
4225         This moves the ORWT results class "LayoutTestResults" over to using
4226         TestResult and TestFailure classes, making it easy for us to
4227         make all our sheriff-bot and other webkitpy code NRWT ready.
4228
4229         This also makes it a trivial patch to generate results.json information
4230         from ORWT results.html files (for flaky test analysis, etc.) as well
4231         as making it a one-liner to report test failure types when the
4232         commit-queue sees flaky tests.
4233
4234         This patch tried not to add new functionality, but only to replace
4235         the guts of LayoutTestResults, while adding unit tests and hoping
4236         not to break anything.
4237
4238         I also moved callers which assumed User.prompt* were static/class methods
4239         to using them as instance methods (since we'll eventually want to make them such).
4240
4241         In the process of re-writing things, I broke the rebaseline command, so I wrote
4242         a unit test to catch my breakage were I do do so again in the future.
4243
4244         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
4245         * Scripts/webkitpy/common/net/layouttestresults.py:
4246         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
4247         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
4248         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
4249         * Scripts/webkitpy/tool/commands/queries.py:
4250         * Scripts/webkitpy/tool/commands/rebaseline.py:
4251         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
4252         * Scripts/webkitpy/tool/mocktool.py:
4253
4254 2011-01-03  Adam Barth  <abarth@webkit.org>
4255
4256         Reviewed by Simon Fraser.
4257
4258         webkit-patch shouldn't waste time cleaning a working directory that's already clean
4259         https://bugs.webkit.org/show_bug.cgi?id=51840
4260
4261         * Scripts/webkitpy/common/checkout/scm.py:
4262
4263 2011-01-03  Adam Barth  <abarth@webkit.org>
4264
4265         Reviewed by Simon Fraser.
4266
4267         webkit-patch should only hide update output if --quiet
4268         https://bugs.webkit.org/show_bug.cgi?id=51838
4269
4270         As requested by smfr.
4271
4272         * Scripts/webkitpy/tool/steps/update.py:
4273
4274 2011-01-03  Adam Barth  <abarth@webkit.org>
4275
4276         Reviewed by David Levin.
4277
4278         commit-queue shouldn't reject patches twice if two bots process the same patch
4279         https://bugs.webkit.org/show_bug.cgi?id=51805
4280
4281         Before raising an error, we first check whether the patch is still in
4282         the commit-queue.  This check is still racy, of course, but the time
4283         window is much smaller.
4284
4285         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
4286
4287 2011-01-03  Sam Weinig  <sam@webkit.org>
4288
4289         Reviewed by Anders Carlsson.
4290
4291         Make run-api-tests less chatty.
4292         https://bugs.webkit.org/show_bug.cgi?id=51831
4293
4294         - Make script quiet by default and add --verbose option (replacing --quiet).
4295         - When not verbose, pipe stdout and stderr to devnull.
4296
4297         * Scripts/run-api-tests:
4298
4299 2011-01-03  Pratik Solanki  <psolanki@apple.com>
4300
4301         Unreviewed. Adding myself to committers.py.
4302
4303         * Scripts/webkitpy/common/config/committers.py:
4304
4305 2011-01-03  Koan-Sin Tan  <koansin.tan@gmail.com>
4306
4307         Reviewed by Xan Lopez.
4308
4309         "Tool/Scripts/run-launcher --gtk" stopped working after 74855
4310         https://bugs.webkit.org/show_bug.cgi?id=51806
4311
4312         Originally, the $libraryName is 'JavaScriptCore'. When building release 
4313         one, the $libraryDir was 'WebKitBuild/Release/JavaScriptCore/../.libs/'
4314         which doesn't exist anymore ('WebKitBuild/Release/JavaScriptCore'
4315         is 'WebKitBuild/Release/Source/JavaScriptCore' now), and 
4316         'WebKitBuild/Release/Source/JavaScriptCore/../../.libs' looks weird,
4317         so make it 'WebKitBuild/Release/.libs'
4318
4319         * Scripts/webkitdirs.pm: 
4320
4321 2011-01-02  Patrick Gansterer  <paroga@webkit.org>
4322
4323         Reviewed by Adam Barth.
4324
4325         Make EFL a core builder
4326         https://bugs.webkit.org/show_bug.cgi?id=51804
4327
4328         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
4329         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
4330
4331 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
4332
4333         [Qt] Unreviewed fix after r74855 and r74875.
4334
4335         * BuildSlaveSupport/built-product-archive:
4336          - Create directories explicitly.
4337          - Pass shell=True to subprocess.call().
4338
4339 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
4340
4341         [Qt] Unreviewed fix after r74855.
4342
4343         Move JavaScriptCore to Source
4344         https://bugs.webkit.org/show_bug.cgi?id=51604
4345
4346         * BuildSlaveSupport/built-product-archive: JavaScriptCore -> Source/JavaScriptCore
4347
4348 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
4349
4350         [Qt] Unreviewed run-javasriptcore-tests fix after r74855.
4351
4352         Move JavaScriptCore to Source
4353         https://bugs.webkit.org/show_bug.cgi?id=51604
4354
4355         * Scripts/webkitdirs.pm:
4356
4357 2011-01-02  Robert Hogan  <robert@webkit.org>
4358
4359         Unreviewed, build fix.
4360
4361         [Qt] Fix DRT build after 74855
4362
4363         * DumpRenderTree/qt/DumpRenderTree.pro:
4364
4365 2011-01-01  Adam Barth  <abarth@webkit.org>
4366
4367         Remove the assumption from the Qt and Gtk builds that every project is
4368         in the root directory.
4369
4370         * Scripts/build-webkit:
4371
4372 2011-01-01  Adam Barth  <abarth@webkit.org>
4373
4374         Reviewed by Eric Seidel.
4375
4376         Teach svn-apply how to apply patches even though JavaScriptCore has moved
4377         https://bugs.webkit.org/show_bug.cgi?id=51796
4378
4379         After this change, svn-apply will magically apply patches to
4380         JavaScriptCore/foo to Source/JavaScriptCore/foo.
4381
4382         * Scripts/VCSUtils.pm:
4383
4384 2011-01-01  Adam Barth  <abarth@webkit.org>
4385
4386         Reviewed by Eric Seidel.
4387
4388         Move JavaScriptCore to Source
4389         https://bugs.webkit.org/show_bug.cgi?id=51604
4390
4391         Update references to JavaScriptCore to point to the new location.
4392
4393         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
4394         * DumpRenderTree/qt/DumpRenderTree.pro:
4395         * DumpRenderTree/qt/ImageDiff.pro:
4396         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
4397         * DumpRenderTree/wscript:
4398         * Scripts/build-jsc:
4399         * Scripts/build-webkit:
4400         * Scripts/do-file-rename:
4401         * Scripts/do-webcore-rename:
4402         * Scripts/run-javascriptcore-tests:
4403         * Scripts/update-javascriptcore-test-results:
4404         * Scripts/webkitdirs.pm:
4405         * Scripts/webkitpy/common/config/build_unittest.py:
4406         * Scripts/webkitpy/style/checker.py:
4407         * Scripts/webkitpy/style/checker_unittest.py:
4408         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
4409         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
4410         * WebKitTestRunner/qt/WebKitTestRunner.pro:
4411         * wx/build/settings.py:
4412
4413 2011-01-01  Adam Barth  <abarth@webkit.org>
4414
4415         Reviewed by Eric Seidel.
4416
4417         Move Sources to Source
4418         https://bugs.webkit.org/show_bug.cgi?id=51794
4419
4420         Update scripts to point to the new location.
4421
4422         * Scripts/build-webkit:
4423         * Scripts/do-file-rename:
4424         * Scripts/do-webcore-rename:
4425         * Scripts/webkitpy/common/config/build.py:
4426         * Scripts/webkitpy/common/config/build_unittest.py:
4427
4428 2010-12-31  Kent Tamura  <tkent@chromium.org>
4429
4430         Reviewed by Eric Seidel.
4431
4432         [DRT/Chromium] Enable mock spell checker on non-OSX
4433         https://bugs.webkit.org/show_bug.cgi?id=51401
4434
4435         * DumpRenderTree/chromium/WebViewHost.cpp:
4436         (WebViewHost::spellCheck):
4437
4438 2010-12-31  Adam Barth  <abarth@webkit.org>
4439
4440         Reviewed by Ariya Hidayat.
4441
4442         Remove Tools/Scripts/wkstyle
4443         https://bugs.webkit.org/show_bug.cgi?id=51774
4444
4445         This script appears to not have been touched in a while and seems to
4446         have been replaced by check-webkit-style.
4447
4448         * Scripts/wkstyle: Removed.
4449
4450 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
4451
4452         Unreviewed. Coding style fix.
4453
4454         * DumpRenderTree/chromium/TestShell.h:
4455
4456 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
4457
4458         Reviewed by Pavel Feldman.
4459
4460         Web Inspector: [Chromium] Inspector's tests are very slow on Win(Dbg).
4461
4462         It was a problem with Chromium DRT. DevToolsAgent object instance was
4463         attached not only to the inspected page but to the DevTools window too.
4464         As result all the inspector files were interpreted as a content of inspected page
4465         and were transfered to the DevTools scripts panel for debugging etc.
4466
4467         https://bugs.webkit.org/show_bug.cgi?id=51735
4468
4469         * DumpRenderTree/chromium/TestShell.cpp:
4470         (TestShell::TestShell):
4471         (TestShell::bindJSObjectsToWindow):
4472         (TestShell::createNewWindow):
4473         * DumpRenderTree/chromium/TestShell.h:
4474
4475 2010-12-31  Adam Barth  <abarth@webkit.org>
4476
4477         Rubber-stamped by Eric Seidel.
4478
4479         Move PageLoadTests to PerformanceTests/PageLoad
4480         https://bugs.webkit.org/show_bug.cgi?id=51771
4481
4482         Update references to PageLoadTests to point to the new location.
4483
4484         * Scripts/run-pageloadtest:
4485         * Scripts/webkitpy/common/config/build.py:
4486
4487 2010-12-31  Adam Barth  <abarth@webkit.org>
4488
4489         Rubber-stamped by Eric Seidel.
4490
4491         Move SunSpider into PerformanceTests
4492         https://bugs.webkit.org/show_bug.cgi?id=51769
4493
4494         Update these scripts to point to the new location.
4495
4496         * Scripts/run-sunspider:
4497         * Scripts/sunspider-compare-results:
4498
4499 2010-12-30  Mihai Parparita  <mihaip@chromium.org>
4500
4501         Reviewed by Kent Tamura.
4502
4503         [Chromium] Add WebThemeEngineDRTMac so that Chromium DRT scrollbar rendering can match the Mac port's
4504         https://bugs.webkit.org/show_bug.cgi?id=51728
4505         
4506         Add implementation of the Mac WebThemeEngine that uses an NSScroller
4507         to render top-level scrollbars. This makes them match the Mac port's
4508         use of an NSScrollView, which means that we'll be able to share more
4509         pixel baselines.
4510         
4511         The new rendering code will not be activated until the 
4512         USE_WEB_THEME_ENGINE_TO_PAINT_THUMB #define is fliped in
4513         ScrollbarThemeChromiumMac.
4514
4515         * DumpRenderTree/DumpRenderTree.gypi:
4516         * DumpRenderTree/chromium/TestShellMac.mm: