a2cf5a4c0b358f816b6c2c1d2da50affe695ddee
[WebKit.git] / Tools / ChangeLog
1 2019-09-12  Mark Lam  <mark.lam@apple.com>
2
3         Harden JSC against the abuse of runtime options.
4         https://bugs.webkit.org/show_bug.cgi?id=201597
5         <rdar://problem/55167068>
6
7         Reviewed by Filip Pizlo.
8
9         Linux parts contributed by Carlos Garcia Campos <cgarcia@igalia.com>.
10         Windows parts contributed by Fujii Hironori <Hironori.Fujii@sony.com>.
11
12         Call JSC::Config::configureForTesting() in test harnesses or at the top of tests
13         to disable the hardening on test runs.  Tests rely on setting options to enable
14         test features.
15
16         * DumpRenderTree/mac/DumpRenderTree.mm:
17         (dumpRenderTree):
18         * DumpRenderTree/win/DumpRenderTree.cpp:
19         (initialize):
20         * TestWebKitAPI/PlatformUtilities.cpp:
21         (TestWebKitAPI::Util::createContextWithInjectedBundle):
22         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
23         (main):
24         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm:
25         (TestWebKitAPI::TEST):
26         (TestWebKitAPI::runActiveSessionTest):
27         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewDiagnosticLogging.mm:
28         (TEST):
29         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
30         (TEST):
31         * TestWebKitAPI/Tests/mac/MediaPlaybackSleepAssertion.mm:
32         (TestWebKitAPI::TEST):
33         * TestWebKitAPI/WKWebViewConfigurationExtras.h:
34         * TestWebKitAPI/WKWebViewConfigurationExtras.mm:
35         (+[WKWebViewConfiguration _test_configurationWithTestPlugInClassName:]):
36         (+[WKWebViewConfiguration _test_configurationWithTestPlugInClassName:configureJSCForTesting:]):
37         * WebKitTestRunner/TestController.cpp:
38         (WTR::TestController::generateContextConfiguration const):
39
40 2019-09-12  Keith Rollin  <krollin@apple.com>
41
42         Fix PDFKit references in TestWebKitAPI
43         https://bugs.webkit.org/show_bug.cgi?id=201700
44         <rdar://problem/55279539>
45
46         Reviewed by Youenn Fablet.
47
48         These references fail in watchOS and tvOS, so remove them on those
49         platforms.
50
51         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
52         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
53         * TestWebKitAPI/Tests/WebKitCocoa/PDFSnapshot.mm:
54         * TestWebKitAPI/cocoa/TestPDFDocument.h:
55         * TestWebKitAPI/cocoa/TestPDFDocument.mm:
56         * TestWebKitAPI/config.h:
57
58 2019-09-11  Fujii Hironori  <Hironori.Fujii@sony.com>
59
60         [Win][MiniBrowser] Select all text in the URL bar by clicking it
61         https://bugs.webkit.org/show_bug.cgi?id=201677
62
63         Reviewed by Don Olmstead.
64
65         * MiniBrowser/win/MainWindow.cpp:
66         (EditProc): Post EM_SETSEL in WM_SETFOCUS to select all text.
67
68 2019-09-11  Carlos Garcia Campos  <cgarcia@igalia.com>
69
70         [GTK][WPE] Stop using the session bus in the unit tests
71         https://bugs.webkit.org/show_bug.cgi?id=201636
72
73         Reviewed by Žan Doberšek.
74
75         We are actually using GTestDBus, not the actual session bus of the user session, but it would still be better to
76         use a private p2p DBus connection. This is also the way we encourage apps to implement the communication with
77         the web process extension. This patch removes the WebKitTestBus class and starts a DBus server before every
78         test. The server address is passed to the web extension as initialization parameter to connect directly to
79         it. We keep a global list of connections to the server and a HashMap to get the current active connection for
80         a WebKitWebView.
81
82         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
83         (beforeAll):
84         (afterAll):
85         * TestWebKitAPI/Tests/WebKitGLib/TestMultiprocess.cpp:
86         (testProcessPerWebView):
87         (beforeAll):
88         (afterAll):
89         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
90         (testWebExtensionGetTitle):
91         (testWebExtensionInputElementIsUserEdited):
92         (testDocumentLoadedSignal):
93         (testWebKitWebViewProcessCrashed):
94         (testWebExtensionIsolatedWorld):
95         (testInstallMissingPluginsPermissionRequest):
96         (testWebExtensionFormControlsAssociated):
97         (FormSubmissionTest::FormSubmissionTest):
98         (beforeAll):
99         (afterAll):
100         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
101         (DelayedSignal::DelayedSignal):
102         (emitPageCreated):
103         (pageCreatedCallback):
104         (webkit_web_extension_initialize_with_user_data):
105         * TestWebKitAPI/Tests/WebKitGtk/AccessibilityTestServer.cpp:
106         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
107         (AccessibilityTest::AccessibilityTest):
108         (AccessibilityTest::ensureProxy):
109         (beforeAll):
110         (afterAll):
111         * TestWebKitAPI/glib/CMakeLists.txt:
112         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
113         (dbusConnectionClosed):
114         (dbusServerConnection):
115         (startDBusServer):
116         (stopDBusServer):
117         (main):
118         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
119         (Test::initializeWebExtensions):
120         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp: Removed.
121         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.h: Removed.
122         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:
123         (WebViewTest::~WebViewTest):
124         (WebViewTest::extensionProxy):
125         * TestWebKitAPI/glib/WebKitGLib/WebViewTest.h:
126
127 2019-09-10  Dean Jackson  <dino@apple.com>
128
129         setup-git-clone is using http not https
130         https://bugs.webkit.org/show_bug.cgi?id=201658
131
132         Reviewed by Sam Weinig.
133
134         * Scripts/webkitpy/tool/commands/setupgitclone.py:
135         (SetupGitClone.execute):
136
137 2019-09-10  Matt Lewis  <jlewis3@apple.com>
138
139         run-webkit-test: Allow results to be uploaded without scm checkout
140         https://bugs.webkit.org/show_bug.cgi?id=200787
141
142         Reviewed by Jonathan Bedard.
143
144         * Scripts/webkitpy/common/checkout/scm/detection.py:
145         (SCMDetector.detect_scm_system): Added in detection of stub repository.
146         * Scripts/webkitpy/common/checkout/scm/stub_repository.py: Added.
147         (StubRepository):
148         (StubRepository.__init__):
149         (StubRepository._find_parent_path_matching_callback_condition): Checks up the path given to
150         find the directory containing the checkout_information.json of the stub repository.
151         (StubRepository.in_working_directory): Required functions to be implemented.
152         (StubRepository.svn_revision): Required functions to be implemented.
153         (StubRepository.native_revision): Required functions to be implemented.
154         (StubRepository.native_branch): Required functions to be implemented.
155         (StubRepository._decode_json): Decodes checkout_information.json.
156         (StubRepository.find_checkout_root): Required functions to be implemented.
157         * Scripts/webkitpy/common/checkout/scm/stub_repository_unittest.py: Added.
158         (StubRepositoryTest): Unit test for stub_repository SCM.
159         (StubRepositoryTest.mock_host_for_stub_repository):
160         (StubRepositoryTest.test_in_working_directory):
161         (StubRepositoryTest.test_native_revision):
162         (StubRepositoryTest.test_native_branch):
163         (StubRepositoryTest.test_svn_revision):
164         (StubRepositoryTest.test_find_checkout_root):
165         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
166         (JSONResultsGenerator._get_svn_revision): Removed unnecessary scm initialization.
167         * Scripts/webkitpy/port/base.py:
168         (Port.commits_for_upload): Removed unnecessary scm initialization.
169
170 2019-09-10  Brady Eidson  <beidson@apple.com>
171
172         Add SPI to save a PDF from the contents of a WKWebView.
173         <rdar://problem/48955900> and https://bugs.webkit.org/show_bug.cgi?id=195765
174
175         Reviewed by Tim Horton.
176
177         -Add an "Export to PDF..." menu option to MiniBrowser.
178         -Add API tests for the API itself.
179
180         * MiniBrowser/MiniBrowser.entitlements:
181
182         * MiniBrowser/mac/BrowserWindowController.h:
183         * MiniBrowser/mac/BrowserWindowController.m:
184         (-[BrowserWindowController forceRepaint:]):
185         (-[BrowserWindowController saveAsPDF:]):
186
187         * MiniBrowser/mac/MainMenu.xib:
188
189         * MiniBrowser/mac/WK1BrowserWindowController.m:
190         (-[WK1BrowserWindowController validateMenuItem:]):
191         * MiniBrowser/mac/WK2BrowserWindowController.m:
192         (-[WK2BrowserWindowController validateMenuItem:]):
193         (-[WK2BrowserWindowController saveAsPDF:]):
194
195         * TestWebKitAPI/Configurations/Base.xcconfig:
196         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
197         * TestWebKitAPI/Tests/WebKitCocoa/PDFSnapshot.mm: Added.
198         (TestWebKitAPI::TEST):
199         * TestWebKitAPI/cocoa/TestPDFDocument.h: Added.
200         * TestWebKitAPI/cocoa/TestPDFDocument.mm: Added.
201         (TestWebKitAPI::toCGRect):
202         (TestWebKitAPI::toPlatformPoint):
203         (TestWebKitAPI::TestPDFAnnotation::TestPDFAnnotation):
204         (TestWebKitAPI::TestPDFAnnotation::isLink const):
205         (TestWebKitAPI::TestPDFAnnotation::bounds const):
206         (TestWebKitAPI::TestPDFAnnotation::linkURL const):
207         (TestWebKitAPI::TestPDFPage::create):
208         (TestWebKitAPI::TestPDFPage::TestPDFPage):
209         (TestWebKitAPI::TestPDFPage::annotations):
210         (TestWebKitAPI::TestPDFPage::characterCount const):
211         (TestWebKitAPI::TestPDFPage::text const):
212         (TestWebKitAPI::TestPDFPage::rectForCharacterAtIndex const):
213         (TestWebKitAPI::TestPDFPage::characterIndexAtPoint const):
214         (TestWebKitAPI::TestPDFPage::bounds const):
215         (TestWebKitAPI::TestPDFPage::colorAtPoint const):
216         (TestWebKitAPI::TestPDFDocument::createFromData):
217         (TestWebKitAPI::TestPDFDocument::TestPDFDocument):
218         (TestWebKitAPI::TestPDFDocument::pageCount const):
219         (TestWebKitAPI::TestPDFDocument::page):
220
221 2019-09-10  Keith Rollin  <krollin@apple.com>
222
223         Remove SSL-based TLSDeprecation.mm contents
224         https://bugs.webkit.org/show_bug.cgi?id=201657
225         <rdar://problem/55237678>
226
227         Reviewed by Alex Christensen.
228
229         This file does not build on watchOS due to references to SSL
230         facilities. Conditionalize out the contents on HAVE_SSL.
231
232         * TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:
233
234 2019-09-10  Michael Catanzaro  <mcatanzaro@igalia.com>
235
236         Unreviewed, remove myself from watchlists
237
238         * Scripts/webkitpy/common/config/watchlist:
239
240 2019-09-09  Alex Christensen  <achristensen@webkit.org>
241
242         Rebase API test after r249675
243         https://bugs.webkit.org/show_bug.cgi?id=201596
244
245         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
246         (-[WebsitePoliciesWebsiteDataStoreDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
247         We removed the restriction on WebsitePolicies with non-default persistent sessions.
248         We needed to change the expectations of the test that exercised that code path.
249
250 2019-09-09  Alex Christensen  <achristensen@webkit.org>
251
252         Fix iOS API tests after r249684
253         https://bugs.webkit.org/show_bug.cgi?id=201573
254
255         * TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:
256         (TestWebKitAPI::getWebSocketEventWebKitLegacy):
257         (TestWebKitAPI::TEST):
258         The web thread still exists :(
259         That makes iOS immediate failure results more like WK2, which is fine.
260         The point is that the connection fails somehow and the server sees a TLS failure, which the test verifies.
261
262 2019-09-09  Chris Dumez  <cdumez@apple.com>
263
264         REGRESSION: http/tests/resourceLoadStatistics/do-not-capture-statistics-for-simple-top-navigations.html is frequently timing out on iOS EWS bots
265         https://bugs.webkit.org/show_bug.cgi?id=201550
266
267         Reviewed by Alex Christensen.
268
269         Update testRunner.statisticsNotifyObserver() to return a boolean indicating if it did
270         anything or not.
271
272         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
273         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
274         (WTR::InjectedBundle::statisticsNotifyObserver):
275         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
276         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
277         (WTR::TestRunner::statisticsNotifyObserver):
278         * WebKitTestRunner/InjectedBundle/TestRunner.h:
279
280 2019-09-09  Timothy Hatcher  <timothy@apple.com>
281
282         Tap and hold on Facebook sometimes creates a tall empty selection.
283         https://bugs.webkit.org/show_bug.cgi?id=201618
284         rdar://53630145
285
286         Reviewed by Megan Gardner.
287
288         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
289         * TestWebKitAPI/Tests/ios/SelectionByWord.mm: Added.
290
291 2019-09-09  Aakash Jain  <aakash_jain@apple.com>
292
293         [EWS] Watchlist doesn't work sometimes
294         https://bugs.webkit.org/show_bug.cgi?id=201433
295
296         Reviewed by Michael Catanzaro.
297
298         * Scripts/webkitpy/common/config/watchlist: Updated the email addresses to the one associated with
299         corresponding Bugzilla accounts.
300
301 2019-09-09  Alex Christensen  <achristensen@webkit.org>
302
303         Disable TLS 1.0 and 1.1 in WebSockets
304         https://bugs.webkit.org/show_bug.cgi?id=201573
305
306         Reviewed by Youenn Fablet.
307
308         * TestWebKitAPI/SourcesCocoa.txt:
309         * TestWebKitAPI/TCPServer.cpp:
310         (sk_CRYPTO_BUFFER_num):
311         (sk_CRYPTO_BUFFER_value):
312         (TestWebKitAPI::deleter<CRYPTO_BUFFER>::operator()):
313         (TestWebKitAPI::TCPServer::TCPServer):
314         (TestWebKitAPI::TCPServer::listenForConnections):
315         (TestWebKitAPI::deleter<X509>::operator()): Deleted.
316         (TestWebKitAPI::deleter<uint8_t::operator()): Deleted.
317         * TestWebKitAPI/TCPServer.h:
318         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
319         * TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm: Added.
320         (-[WebSocketDelegate waitForMessage]):
321         (-[WebSocketDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
322         (TestWebKitAPI::TEST):
323         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
324         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
325         (-[TestNavigationDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
326         (-[TestNavigationDelegate waitForDidFailProvisionalNavigation]):
327
328 2019-09-09  Fujii Hironori  <Hironori.Fujii@sony.com>
329
330         [Win][MiniBrowser] WebKitLegacyBrowserWindow is leaked by circular references
331         https://bugs.webkit.org/show_bug.cgi?id=201600
332
333         Reviewed by Brent Fulgham.
334
335         There were some circular references between
336         WebKitLegacyBrowserWindow and its delegation classes. For
337         example, WebKitLegacyBrowserWindow has a reference of
338         WebDownloadDelegate, and WebDownloadDelegate shares the ref
339         counter with WebKitLegacyBrowserWindow.
340
341         WebNotificationObserver was leaked because it wasn't unregistered
342         from the default notification center by using
343         IWebNotificationCenter::removeObserver.
344
345         If a new legacy window was created by mouse right click a link,
346         WebView was released twice because
347         PrintWebUIDelegate::createWebViewWithRequest didn't AddRef the
348         WebView.
349
350         This change does:
351         1. Make delegation classes have own ref-counter to avoid circular references
352         2. Do removeObserver notification observers
353         3. AddRef WebView in PrintWebUIDelegate::createWebViewWithRequest
354
355         * MiniBrowser/win/AccessibilityDelegate.cpp:
356         (AccessibilityDelegate::AddRef):
357         (AccessibilityDelegate::Release):
358         * MiniBrowser/win/AccessibilityDelegate.h: Added m_refCount.
359         * MiniBrowser/win/MiniBrowserWebHost.cpp:
360         (MiniBrowserWebHost::QueryInterface):
361         (MiniBrowserWebHost::AddRef):
362         (MiniBrowserWebHost::Release):
363         * MiniBrowser/win/MiniBrowserWebHost.h: Added m_refCount.
364         * MiniBrowser/win/PrintWebUIDelegate.cpp:
365         (PrintWebUIDelegate::createWebViewWithRequest): Do AddRef for the returned IWebView.
366         (PrintWebUIDelegate::AddRef):
367         (PrintWebUIDelegate::Release):
368         * MiniBrowser/win/PrintWebUIDelegate.h: Added m_refCount.
369         * MiniBrowser/win/ResourceLoadDelegate.cpp:
370         (ResourceLoadDelegate::AddRef):
371         (ResourceLoadDelegate::Release):
372         * MiniBrowser/win/ResourceLoadDelegate.h: Added m_refCount.
373         * MiniBrowser/win/WebDownloadDelegate.cpp:
374         (WebDownloadDelegate::AddRef):
375         (WebDownloadDelegate::Release):
376         * MiniBrowser/win/WebDownloadDelegate.h: Added m_refCount.
377         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
378         (WebKitLegacyBrowserWindow::~WebKitLegacyBrowserWindow): Do removeObserver notification observers.
379         (WebKitLegacyBrowserWindow::init):
380         (WebKitLegacyBrowserWindow::setUIDelegate):
381         (WebKitLegacyBrowserWindow::setAccessibilityDelegate):
382         (WebKitLegacyBrowserWindow::setResourceLoadDelegate):
383         (WebKitLegacyBrowserWindow::setDownloadDelegate):
384         (WebKitLegacyBrowserWindow::AddRef): Deleted.
385         (WebKitLegacyBrowserWindow::Release): Deleted.
386         (WebKitLegacyBrowserWindow::setFrameLoadDelegate): Deleted.
387         (WebKitLegacyBrowserWindow::setFrameLoadDelegatePrivate): Deleted.
388         * MiniBrowser/win/WebKitLegacyBrowserWindow.h:
389
390 2019-09-09  Chris Dumez  <cdumez@apple.com>
391
392         Stop using testRunner.setPrivateBrowsingEnabled_DEPRECATED() in http/tests/adClickAttribution/conversion-disabled-in-ephemeral-session.html
393         https://bugs.webkit.org/show_bug.cgi?id=201596
394
395         Reviewed by Alex Christensen.
396
397         Add new testRunner.setShouldSwapToEphemeralSessionOnNextNavigation() / testRunner.setShouldSwapToDefaultSessionOnNextNavigation()
398         test functions to support dynamic switching between ephemeral and default/persistent session in layout tests. The new methods
399         do the right thing for WebKit2 and truly switch session, unlike setPrivateBrowsingEnabled_DEPRECATED() which was merely making
400         the WebCore::Document think it changed session.
401
402         * DumpRenderTree/TestRunner.cpp:
403         (setShouldSwapToEphemeralSessionOnNextNavigationCallback):
404         (setShouldSwapToDefaultSessionOnNextNavigationCallback):
405         (TestRunner::staticFunctions):
406         (TestRunner::willNavigate):
407         * DumpRenderTree/TestRunner.h:
408         (TestRunner::setShouldSwapToEphemeralSessionOnNextNavigation):
409         (TestRunner::setShouldSwapToDefaultSessionOnNextNavigation):
410         * DumpRenderTree/mac/FrameLoadDelegate.mm:
411         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
412         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
413         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
414         (WTR::TestRunner::setShouldSwapToEphemeralSessionOnNextNavigation):
415         (WTR::TestRunner::setShouldSwapToDefaultSessionOnNextNavigation):
416         * WebKitTestRunner/InjectedBundle/TestRunner.h:
417         * WebKitTestRunner/TestController.cpp:
418         (WTR::TestController::decidePolicyForNavigationAction):
419         * WebKitTestRunner/TestController.h:
420         (WTR::TestController::setShouldSwapToEphemeralSessionOnNextNavigation):
421         (WTR::TestController::setShouldSwapToDefaultSessionOnNextNavigation):
422         * WebKitTestRunner/TestInvocation.cpp:
423         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
424
425 2019-09-09  Aakash Jain  <aakash_jain@apple.com>
426
427         EWS testtube emoji doesn't exist on macOS Mojave
428         https://bugs.webkit.org/show_bug.cgi?id=201532
429
430         Reviewed by Simon Fraser.
431
432         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
433         (StatusBubble): Change the emoji to microscope emoji.
434
435 2019-09-09  Aakash Jain  <aakash_jain@apple.com>
436
437         [EWS] API testers can go in an infinite RETRY loop when there is build failure in trunk
438         https://bugs.webkit.org/show_bug.cgi?id=201607
439
440         Reviewed by Jonathan Bedard.
441
442         * BuildSlaveSupport/ews-build/steps.py:
443         (AnalyzeAPITestsResults.analyzeResults): Do not RETRY when clean_tree_results are missing.
444         (AnalyzeAPITestsResults.analyzeResults.getAPITestFailures): Gracefully handle None result.
445
446 2019-09-07  Keith Miller  <keith_miller@apple.com>
447
448         OSR entry into wasm misses some contexts
449         https://bugs.webkit.org/show_bug.cgi?id=201569
450
451         Reviewed by Yusuke Suzuki.
452
453         Add new test harness mode for tests created from wast files.
454
455         * Scripts/run-jsc-stress-tests:
456
457 2019-09-09  Daniel Bates  <dabates@apple.com>
458
459         Remove all selection view animations before dumping results
460         https://bugs.webkit.org/show_bug.cgi?id=199241
461
462         Reviewed by Wenson Hsieh.
463
464         On iOS the selection UI uses a few animations, including fading in the grabbers. We have many
465         historical tests that were written for Mac and expect Mac's lack of animations that we run on
466         iOS and are flaky. Let's try to remove all selection view animations before dumping results and
467         see if this makes tests on iOS less flaky. A future enhancement to this is to expose a uiController
468         API for a test to remove selection animations at any time during the run.
469
470         * WebKitTestRunner/ios/TestControllerIOS.mm:
471         (WTR::TestController::notifyDone):
472
473 2019-09-09  Jonathan Bedard  <jbedard@apple.com>
474
475         run-webkit-tests: Report results archive to results.webkit.org
476         https://bugs.webkit.org/show_bug.cgi?id=201321
477
478         Reviewed by Aakash Jain.
479
480         * Scripts/webkitpy/layout_tests/controllers/manager.py:
481         (Manager.run): After all tests are finish, upload the results archive for each
482         configuration.
483         * Scripts/webkitpy/results/upload.py:
484         (Upload):
485         (Upload.__init__): Automatically define timestamp.
486         (Upload.upload_archive): Upload an archive associated with the test run.
487         * Scripts/webkitpy/results/upload_unittest.py:
488         (UploadTest.test_buildbot):
489         (UploadTest):
490         (UploadTest.test_archive_upload):
491
492 2019-09-09  Chris Dumez  <cdumez@apple.com>
493
494         Stop using testRunner.setPrivateBrowsingEnabled_DEPRECATED() in http/tests/workers/service/basic-register.html
495         https://bugs.webkit.org/show_bug.cgi?id=201590
496
497         Reviewed by Youenn Fablet.
498
499         Add a new API test to check that if the default session registers a service worker, the
500         hasServiceWorkerRegistration flag is still false in an ephemeral session.
501
502         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
503
504 2019-09-09  Jonathan Bedard  <jbedard@apple.com>
505
506         results.webkit.org: mobile-sidebar-control should override button
507         https://bugs.webkit.org/show_bug.cgi?id=201566
508
509         Rubber-stamped by Aakash Jain.
510
511         * resultsdbpy/resultsdbpy/view/static/library/css/webkit.css:
512         (@media screen and (min-width: 600px)):
513         (.mobile-sidebar-control):
514         (.mobile-sidebar-control.display):
515
516 2019-09-07  Chris Dumez  <cdumez@apple.com>
517
518         Rewrite http/tests/workers/service/serviceworker-private-browsing.https.html as an API test
519         https://bugs.webkit.org/show_bug.cgi?id=201574
520
521         Reviewed by Alex Christensen.
522
523         Rewrite http/tests/workers/service/serviceworker-private-browsing.https.html as an API test so that
524         we truly test private browsing. testRunner.setPrivateBrowsingEnabled_DEPRECATED() is a hack which
525         does not work well for WK2.
526
527         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
528
529 2019-09-07  Chris Dumez  <cdumez@apple.com>
530
531         Rewrite storage/domstorage/localstorage/private-browsing-affects-storage.html as an API test
532         https://bugs.webkit.org/show_bug.cgi?id=201547
533
534         Reviewed by Alex Christensen.
535
536         Rewrite storage/domstorage/localstorage/private-browsing-affects-storage.html as an API test so
537         it can use a true ephemeral session instead of the testRunner.setPrivateBrowsingEnabled_DEPRECATED()
538         hack.
539
540         * TestWebKitAPI/Tests/WebKitCocoa/LocalStoragePersistence.mm:
541         (-[LocalStorageNavigationDelegate webView:decidePolicyForNavigationAction:preferences:decisionHandler:]):
542         (-[LocalStorageNavigationDelegate webView:didFinishNavigation:]):
543         (TEST):
544
545 2019-09-07  Alex Christensen  <achristensen@webkit.org>
546
547         Remove WebsiteDataStore::legacyDefaultDataStoreConfiguration
548         https://bugs.webkit.org/show_bug.cgi?id=200054
549
550         Reviewed by Carlos Garcia Campos.
551
552         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
553         This test relied on the default data store having been instantiated.
554
555 2019-09-07  Alex Christensen  <achristensen@webkit.org>
556
557         Remove calls to WKContextGetWebsiteDataStore missed in r249614
558         https://bugs.webkit.org/show_bug.cgi?id=200050
559
560         * WebKitTestRunner/TestController.cpp:
561         (WTR::TestController::resetPreferencesToConsistentValues):
562         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
563         * WebKitTestRunner/TestInvocation.cpp:
564         (WTR::TestInvocation::invoke):
565
566 2019-09-07  Alex Christensen  <achristensen@webkit.org>
567
568         Remove invalid assertion added in r249614
569         https://bugs.webkit.org/show_bug.cgi?id=200050
570
571         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
572         (WTR::TestController::cocoaResetStateToConsistentValues):
573         Something is instantiating the default data store, which is no problem right now.
574
575 2019-09-07  Ryan Haddad  <ryanhaddad@apple.com>
576
577         Unreviewed, rolling out r249353.
578
579         The test for this change is a flaky failure.
580
581         Reverted changeset:
582
583         "Add support for postMessage buffering between the service
584         worker and window"
585         https://bugs.webkit.org/show_bug.cgi?id=201169
586         https://trac.webkit.org/changeset/249353
587
588 2019-09-07  Alex Christensen  <achristensen@webkit.org>
589
590         Deprecate WKContextGetWebsiteDataStore
591         https://bugs.webkit.org/show_bug.cgi?id=200050
592
593         Reviewed by Geoff Garen.
594
595         * MiniBrowser/win/WebKitBrowserWindow.cpp:
596         (WebKitBrowserWindow::updateProxySettings):
597         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
598         * WebKitTestRunner/TestController.cpp:
599         (WTR::TestController::generateContextConfiguration const):
600         (WTR::TestController::websiteDataStore):
601         (WTR::TestController::generatePageConfiguration):
602         (WTR::TestController::resetStateToConsistentValues):
603         (WTR::TestController::platformAdjustContext):
604         (WTR::TestController::clearServiceWorkerRegistrations):
605         (WTR::TestController::clearDOMCache):
606         (WTR::TestController::clearDOMCaches):
607         (WTR::TestController::ClearIndexedDatabases):
608         (WTR::TestController::hasDOMCache):
609         (WTR::TestController::domCacheSize):
610         (WTR::TestController::setStatisticsDebugMode):
611         (WTR::TestController::setStatisticsPrevalentResourceForDebugMode):
612         (WTR::TestController::setStatisticsLastSeen):
613         (WTR::TestController::setStatisticsPrevalentResource):
614         (WTR::TestController::setStatisticsVeryPrevalentResource):
615         (WTR::TestController::dumpResourceLoadStatistics):
616         (WTR::TestController::isStatisticsPrevalentResource):
617         (WTR::TestController::isStatisticsVeryPrevalentResource):
618         (WTR::TestController::isStatisticsRegisteredAsSubresourceUnder):
619         (WTR::TestController::isStatisticsRegisteredAsSubFrameUnder):
620         (WTR::TestController::isStatisticsRegisteredAsRedirectingTo):
621         (WTR::TestController::setStatisticsHasHadUserInteraction):
622         (WTR::TestController::isStatisticsHasHadUserInteraction):
623         (WTR::TestController::setStatisticsGrandfathered):
624         (WTR::TestController::isStatisticsGrandfathered):
625         (WTR::TestController::setStatisticsSubframeUnderTopFrameOrigin):
626         (WTR::TestController::setStatisticsSubresourceUnderTopFrameOrigin):
627         (WTR::TestController::setStatisticsSubresourceUniqueRedirectTo):
628         (WTR::TestController::setStatisticsSubresourceUniqueRedirectFrom):
629         (WTR::TestController::setStatisticsTopFrameUniqueRedirectTo):
630         (WTR::TestController::setStatisticsTopFrameUniqueRedirectFrom):
631         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
632         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
633         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
634         (WTR::TestController::statisticsUpdateCookieBlocking):
635         (WTR::TestController::statisticsSubmitTelemetry):
636         (WTR::TestController::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
637         (WTR::TestController::setStatisticsIsRunningTest):
638         (WTR::TestController::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
639         (WTR::TestController::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
640         (WTR::TestController::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
641         (WTR::TestController::setStatisticsGrandfatheringTime):
642         (WTR::TestController::setStatisticsMaxStatisticsEntries):
643         (WTR::TestController::setStatisticsPruneEntriesDownTo):
644         (WTR::TestController::statisticsClearInMemoryAndPersistentStore):
645         (WTR::TestController::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
646         (WTR::TestController::statisticsClearThroughWebsiteDataRemoval):
647         (WTR::TestController::statisticsDeleteCookiesForHost):
648         (WTR::TestController::isStatisticsHasLocalStorage):
649         (WTR::TestController::setStatisticsCacheMaxAgeCap):
650         (WTR::TestController::statisticsResetToConsistentState):
651         (WTR::TestController::setWebAuthenticationMockConfiguration):
652         (WTR::TestController::clearAdClickAttributionsThroughWebsiteDataRemoval):
653         * WebKitTestRunner/TestController.h:
654         * WebKitTestRunner/TestInvocation.cpp:
655         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
656         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
657         (WTR::initializeWebViewConfiguration):
658
659 2019-09-06  Wenson Hsieh  <wenson_hsieh@apple.com>
660
661         Incorrect selection rect revealed after pasting images in a contenteditable element
662         https://bugs.webkit.org/show_bug.cgi?id=201549
663         <rdar://problem/50956429>
664
665         Reviewed by Simon Fraser.
666
667         Add an API test to exercise the scenario where we scroll to reveal the selection after pasting an image that was
668         directly written to the pasteboard.
669
670         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
671
672 2019-09-06  Matt Lewis  <jlewis3@apple.com>
673
674         Unreviewed, rolling out r249582.
675
676         This caused results.html fail to be created on internal
677         testers.
678
679         Reverted changeset:
680
681         "run-webkit-test: Allow results to be uploaded without scm
682         checkout"
683         https://bugs.webkit.org/show_bug.cgi?id=200787
684         https://trac.webkit.org/changeset/249582
685
686 2019-09-06  Aakash Jain  <aakash_jain@apple.com>
687
688         [ews-app] Status bubble should only display important messages in pop-over - part 2
689         https://bugs.webkit.org/show_bug.cgi?id=201557
690
691         Reviewed by Jonathan Bedard.
692
693         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
694         (StatusBubble): Add few more strings to STEPS_TO_HIDE.
695
696 2019-09-06  Alex Christensen  <achristensen@webkit.org>
697
698         Deprecate all WKCookieManagerRef functions
699         https://bugs.webkit.org/show_bug.cgi?id=201473
700
701         Reviewed by Chris Dumez.
702
703         Adopt replacement C API in WebKitTestRunner.
704
705         * TestWebKitAPI/CMakeLists.txt:
706         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
707         * TestWebKitAPI/Tests/WebKit/CookieManager.cpp: Removed, because the functions it tests were removed.
708         * WebKitTestRunner/TestController.cpp:
709         (WTR::TestController::resetPreferencesToConsistentValues):
710         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
711         * WebKitTestRunner/TestInvocation.cpp:
712         (WTR::TestInvocation::invoke):
713         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
714         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
715         (WTR::initializeWebViewConfiguration):
716
717 2019-09-06  Tim Horton  <timothy_horton@apple.com>
718
719         Marking up a note on iOS results in a PDF with no contents
720         https://bugs.webkit.org/show_bug.cgi?id=201530
721         <rdar://problem/53686019>
722
723         Reviewed by Andy Estes.
724
725         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
726         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewPrintFormatter.mm:
727         Add some tests for WKWebViewPrintFormatter; specifically that it is
728         possible to _recalcPageCount twice in quick succession, and that
729         we don't hang if we start painting the printed content immediately
730         after a Web Content process crash.
731
732 2019-09-06  Matt Lewis  <jlewis3@apple.com>
733
734         run-webkit-test: Allow results to be uploaded without scm checkout
735         https://bugs.webkit.org/show_bug.cgi?id=200787
736
737         Reviewed by Jonathan Bedard.
738
739         * Scripts/webkitpy/common/checkout/scm/detection.py:
740         (SCMDetector.detect_scm_system): Added in detection of stub repository.
741         * Scripts/webkitpy/common/checkout/scm/stub_repository.py: Added.
742         (StubRepository):
743         (StubRepository.__init__):
744         (StubRepository._find_parent_path_matching_callback_condition): Checks up the path given to
745         find the directory containing the checkout_information.json of the stub repository.
746         (StubRepository.in_working_directory): Required functions to be implemented.
747         (StubRepository.svn_revision): Required functions to be implemented.
748         (StubRepository.native_revision): Required functions to be implemented.
749         (StubRepository.native_branch): Required functions to be implemented.
750         (StubRepository._decode_json): Decodes checkout_information.json.
751         (StubRepository.find_checkout_root): Required functions to be implemented.
752         * Scripts/webkitpy/common/checkout/scm/stub_repository_unittest.py: Added.
753         (StubRepositoryTest): Unit test for stub_repository SCM.
754         (StubRepositoryTest.mock_host_for_stub_repository):
755         (StubRepositoryTest.test_in_working_directory):
756         (StubRepositoryTest.test_native_revision):
757         (StubRepositoryTest.test_native_branch):
758         (StubRepositoryTest.test_svn_revision):
759         (StubRepositoryTest.test_find_checkout_root):
760         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
761         (JSONResultsGenerator._get_svn_revision): Removed unnecessary scm initialization.
762         * Scripts/webkitpy/port/base.py:
763         (Port.commits_for_upload): Removed unnecessary scm initialization.
764
765 2019-09-06  Alex Christensen  <achristensen@webkit.org>
766
767         When disabling legacy private browsing for testing, change the SessionID back to what it was, not the defaultSessionID
768         https://bugs.webkit.org/show_bug.cgi?id=201480
769
770         Reviewed by Youenn Fablet.
771
772         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
773         (WTR::InjectedBundle::beginTesting):
774         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
775         (WTR::TestRunner::setPrivateBrowsingEnabled):
776
777 2019-09-06  Rob Buis  <rbuis@igalia.com>
778
779         Add runtime flag for lazy image loading
780         https://bugs.webkit.org/show_bug.cgi?id=199794
781
782         Reviewed by Frédéric Wang.
783
784         Remove parts of r248409 that were meant for WK1 since
785         lazy image loading is WK2 only.
786
787         * DumpRenderTree/TestOptions.cpp:
788         (TestOptions::TestOptions):
789         * DumpRenderTree/TestOptions.h:
790         * DumpRenderTree/mac/DumpRenderTree.mm:
791         (enableExperimentalFeatures):
792         (setWebPreferencesForTestOptions):
793         * DumpRenderTree/win/DumpRenderTree.cpp:
794         (enableExperimentalFeatures):
795
796 2019-09-05  Chris Dumez  <cdumez@apple.com>
797
798         Stop using testRunner.setPrivateBrowsingEnabled_DEPRECATED() in imported/w3c/IndexedDB-private-browsing
799         https://bugs.webkit.org/show_bug.cgi?id=201519
800
801         Reviewed by Alex Christensen.
802
803         Stop using testRunner.setPrivateBrowsingEnabled_DEPRECATED() in imported/w3c/IndexedDB-private-browsing
804         as it does not truly enable private browsing for WebKit2. Instead, have WKTR / DRT set the
805         TestOption::useEphemeralSession flag based on the test folder.
806
807         * DumpRenderTree/mac/DumpRenderTree.mm:
808         (shouldUseEphemeralSession):
809         (runTest):
810         * WebKitTestRunner/TestOptions.cpp:
811         (WTR::shouldUseEphemeralSession):
812         (WTR::TestOptions::TestOptions):
813
814 2019-09-05  Fujii Hironori  <Hironori.Fujii@sony.com>
815
816         [Win] Support Per-Monitor (V2) DPI Awareness
817         https://bugs.webkit.org/show_bug.cgi?id=201450
818
819         Reviewed by Don Olmstead.
820
821         * MiniBrowser/win/MainWindow.cpp:
822         (MainWindow::WndProc): Set the window position suggested by WM_DPICHANGED.
823         * MiniBrowser/win/WinMain.cpp:
824         (wWinMain): Call SetProcessDpiAwarenessContext by using soft linking.
825
826 2019-09-05  Chris Dumez  <cdumez@apple.com>
827
828         REGRESSION: http/tests/adClickAttribution/second-attribution-converted-with-higher-priority.html and http/tests/adClickAttribution/second-attribution-converted-with-lower-priority.html are flaky timeouts
829         https://bugs.webkit.org/show_bug.cgi?id=201440
830         <rdar://problem/54998427>
831
832         Reviewed by Alex Christensen.
833
834         Since r249350, it is now possible for a WebContent process to have a suspended WebPage for the current web view.
835         This was confusing InjectedBundle::page() in WebKitTestRunner which was assuming that the WebPage that was first
836         created in the WebContent process is the one that is currently running the test and that we want to talk to.
837         Update InjectedBundle::page() to ignore suspended WebPages in order to address the issue.
838
839         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
840         (WTR::InjectedBundle::page const):
841
842 2019-09-05  Jonathan Bedard  <jbedard@apple.com>
843
844         results.webkit.org: Assign notifyRerender before calling
845         https://bugs.webkit.org/show_bug.cgi?id=201510
846
847         Reviewed by Aakash Jain.
848
849         Timelines should define notifyRerender to an empty function,
850         rename notifiyRerender to notifyRerender.
851
852         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
853         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
854         * resultsdbpy/resultsdbpy/view/templates/search.html:
855         * resultsdbpy/resultsdbpy/view/templates/suite_results.html:
856
857 2019-09-05  Jonathan Bedard  <jbedard@apple.com>
858
859         results.webkit.org: Fix prepending search result on empty list 
860         https://bugs.webkit.org/show_bug.cgi?id=201512
861
862         Reviewed by Aakash Jain.
863
864         * resultsdbpy/resultsdbpy/view/templates/search.html:
865
866 2019-09-05  Jonathan Bedard  <jbedard@apple.com>
867
868         results.webkit.org: Retain certain parameters when following menu links
869         https://bugs.webkit.org/show_bug.cgi?id=201463
870
871         Rubber-stamped by Aakash Jain.
872
873         * resultsdbpy/resultsdbpy/view/site_menu.py:
874         (SiteMenu.add_endpoint): Allow added endpoints to define parameters to be retained.
875         * resultsdbpy/resultsdbpy/view/templates/base.html: When clicking on a site-menu link,
876         retain the specified parameters
877         * resultsdbpy/resultsdbpy/view/view_routes.py:
878         (ViewRoutes.__init__):
879
880 2019-09-05  Chris Dumez  <cdumez@apple.com>
881
882         [WK2] Add proper layout test support for ephemeral sessions
883         https://bugs.webkit.org/show_bug.cgi?id=201475
884
885         Reviewed by Antti Koivisto.
886
887         Add proper layout test support for ephemeral sessions via:
888         <!-- webkit-test-runner [ useEphemeralSession=true ] -->
889
890         This actually creates a new WebView using an ephemeral data store to load the test which
891         is *true* private browsing.
892
893         testRunner.setPrivateBrowsingEnabled() merely overrides the Page's sessionID in the WebContent
894         process, which is a hack and does not truly enable private browsing because the UIProcess and
895         the NetworkProcess are not properly updated on WK2. This patch renames testRunner.setPrivateBrowsingEnabled()
896         to testRunner.setPrivateBrowsingEnabled_DEPRECATED() to discourage its use since I am try to
897         get rid of it.
898
899         Note that WK2 does not support using a WebContent process for different sessions / data stores.
900         Each WebContent process has a single associated data store and testRunner.setPrivateBrowsingEnabled()
901         is currently the only exception to that. This leads to additional complexity in our code base (e.g. in ITP),
902         simply to support testRunner.setPrivateBrowsingEnabled().
903
904         * DumpRenderTree/TestOptions.cpp:
905         (TestOptions::TestOptions):
906         * DumpRenderTree/TestOptions.h:
907         * DumpRenderTree/TestRunner.cpp:
908         (TestRunner::staticFunctions):
909         * DumpRenderTree/mac/DumpRenderTree.mm:
910         (setWebPreferencesForTestOptions):
911         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
912         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
913         (WTR::TestRunner::setPrivateBrowsingEnabled_DEPRECATED):
914         * WebKitTestRunner/InjectedBundle/TestRunner.h:
915         * WebKitTestRunner/TestController.cpp:
916         (WTR::TestController::generatePageConfiguration):
917         (WTR::updateTestOptionsFromTestHeader):
918         * WebKitTestRunner/TestOptions.h:
919         (WTR::TestOptions::hasSameInitializationOptions const):
920         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
921         (WTR::TestController::platformCreateWebView):
922
923 2019-09-05  Ryosuke Niwa  <rniwa@webkit.org>
924
925         REGRESSION (iOS 13): Bulleted list copied from Notes to Mail results in Times New Roman
926         https://bugs.webkit.org/show_bug.cgi?id=201490
927
928         Reviewed by Daniel Bates.
929
930         Added a test.
931
932         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
933         * TestWebKitAPI/Tests/WebKitCocoa/PasteHTML.mm:
934         * TestWebKitAPI/Tests/WebKitCocoa/cocoa-writer-markup-with-lists.html: Added.
935
936 2019-09-05  Ryosuke Niwa  <rniwa@webkit.org>
937
938         Remove unused SPI that accesses MemoryCache directly
939         https://bugs.webkit.org/show_bug.cgi?id=201468
940
941         Reviewed by Youenn Fablet.
942
943         Removed the API test.
944
945         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
946         * TestWebKitAPI/Tests/ios/MemoryCacheAddImageToCacheIOS.mm: Removed.
947
948 2019-09-04  Timothy Hatcher  <timothy@apple.com>
949
950         Mail appears to be double inverting code copied from Notes, Xcode, or Terminal.
951         https://bugs.webkit.org/show_bug.cgi?id=201368
952         rdar://problem/40529867
953
954         Reviewed by Ryosuke Niwa.
955
956         Added Tests: PasteHTML.TransformColorsOfDarkContent, PasteHTML.DoesNotTransformColorsOfLightContent,
957             PasteRTFD.TransformColorsOfDarkContent, PasteRTFD.DoesNotTransformColorsOfLightContent
958
959         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
960         * TestWebKitAPI/Tests/WebKitCocoa/PasteHTML.mm:
961         (createWebViewWithCustomPasteboardDataSetting): Added argument to enable color filter.
962         * TestWebKitAPI/Tests/WebKitCocoa/PasteRTFD.mm:
963         (createWebViewWithCustomPasteboardDataEnabled): Added argument to enable color filter.
964         * TestWebKitAPI/Tests/WebKitCocoa/rich-color-filtered.html: Added.
965         * TestWebKitAPI/cocoa/TestWKWebView.h:
966         * TestWebKitAPI/cocoa/TestWKWebView.mm:
967         (-[TestWKWebView forceDarkMode]):
968
969 2019-09-04  Wenson Hsieh  <wenson_hsieh@apple.com>
970
971         MobileSafari may crash when invoking the C++ lambda in -[WKContentView _shareForWebView:]
972         https://bugs.webkit.org/show_bug.cgi?id=201479
973         <rdar://problem/51511834>
974
975         Reviewed by Tim Horton.
976
977         Add a test to verify that the UI process doesn't crash when invoking `_share:` while there's no selection.
978
979         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
980         * TestWebKitAPI/ios/UIKitSPI.h:
981
982 2019-09-04  Wenson Hsieh  <wenson_hsieh@apple.com>
983
984         -[WKContentView selectedText] returns an empty string when selecting more than 200 characters
985         https://bugs.webkit.org/show_bug.cgi?id=201471
986         <rdar://problem/55039227>
987
988         Reviewed by Tim Horton.
989
990         Add an API test to ensure that -selectedText is non-empty in the case where more than 200 characters are
991         selected.
992
993         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
994         (TestWebKitAPI::TEST):
995         * TestWebKitAPI/ios/UIKitSPI.h:
996
997 2019-09-04  Jonathan Bedard  <jbedard@apple.com>
998
999         results.webkit.org: Fix mobile vs desktop mode
1000         https://bugs.webkit.org/show_bug.cgi?id=201441
1001
1002         Rubber-stamped by Aakash Jain.
1003
1004         We should unconditionally use desktop mode if the device screen-width
1005         is large enough.
1006
1007         * resultsdbpy/resultsdbpy/view/static/library/css/webkit.css:
1008
1009 2019-09-04  Jonathan Bedard  <jbedard@apple.com>
1010
1011         run-api-tests: Add support for specifying additional environment variables
1012         https://bugs.webkit.org/show_bug.cgi?id=201311
1013         <rdar://problem/54852698>
1014
1015         Reviewed by Daniel Bates.
1016
1017         * Scripts/webkitpy/api_tests/run_api_tests.py:
1018         (parse_args): Add --additional-env-var flag.
1019         * Scripts/webkitpy/port/base.py:
1020         (Port._append_value_colon_separated): Use os.pathsep instead of ':'.
1021         (Port.environment_for_api_tests): Add the values from --additional-env-var to the
1022         environment.
1023
1024 2019-09-04  Aakash Jain  <aakash_jain@apple.com>
1025
1026         EWS bubbles should indicate builder vs tester
1027         https://bugs.webkit.org/show_bug.cgi?id=201253
1028
1029         Reviewed by Jonathan Bedard.
1030
1031         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1032         (StatusBubble._build_bubble): Add icons to the bubbles appropriately.
1033         (StatusBubble._is_tester_queue): Method to determine if the queue is tester queue.
1034         (StatusBubble._is_builder_queue): Method to determine if the queue is builder queue.
1035         (StatusBubble.get):
1036         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
1037         (Buildbot.fetch_config): Method to fetch the config from Buildbot server.
1038         (Buildbot.update_icons_for_queues_mapping): Method to update the icons for queues mapping.
1039         * BuildSlaveSupport/ews-app/ews/fetcher.py:
1040         (FetchLoop.run): Update the icons for queues mapping.
1041         * BuildSlaveSupport/ews-build/config.json: Add icon information for the queues.
1042         * BuildSlaveSupport/ews-build/loadConfig.py: Remove 'icon' key from builder before passing it to Buildbot.
1043         * BuildSlaveSupport/ews-build/loadConfig_unittest.py: .
1044         (test_builder_keys): Update unit-test accordingly. Also minor drive-by fix to improve failure string formatting.
1045
1046 2019-09-03  Yusuke Suzuki  <ysuzuki@apple.com>
1047
1048         [bmalloc] IsoTLSLayout and AllIsoHeaps registration is racy with derived class initialization with virtual functions
1049         https://bugs.webkit.org/show_bug.cgi?id=201448
1050
1051         Reviewed by Mark Lam.
1052
1053         * TestWebKitAPI/Tests/WTF/bmalloc/IsoHeap.cpp:
1054         (TEST):
1055
1056 2019-09-03  Dean Jackson  <dino@apple.com>
1057
1058         Test for ContextMenus with images
1059         https://bugs.webkit.org/show_bug.cgi?id=201437
1060
1061         Reviewed by Wenson Hsieh.
1062
1063         Add a test for ContextMenus that trigger on images, and make
1064         sure that they ask for alternate URLs (added in r249171).
1065
1066         * TestWebKitAPI/Tests/WebKitCocoa/ContextMenus.mm:
1067         (contextMenuWebViewDriver):
1068         (-[TestContextMenuImageUIDelegate _webView:contextMenuConfigurationForElement:completionHandler:]):
1069         (-[TestContextMenuImageUIDelegate _webView:alternateURLFromImage:userInfo:]):
1070         (-[TestContextMenuImageUIDelegate webView:contextMenuWillPresentForElement:]):
1071         (-[TestContextMenuImageUIDelegate webView:contextMenuForElement:willCommitWithAnimator:]):
1072         (-[TestContextMenuImageUIDelegate webView:contextMenuDidEndForElement:]):
1073         (TEST):
1074
1075 2019-09-03  Jonathan Bedard  <jbedard@apple.com>
1076
1077         results.webkit.org: Move legend into sidebar
1078         https://bugs.webkit.org/show_bug.cgi?id=201258
1079
1080         Rubber-stamped by Aakash Jain.
1081
1082         * resultsdbpy/resultsdbpy/view/static/js/timeline.js: 
1083         (Legend): Make the legend vertical instead of horizontal, add ToolTip to dots in the legend.
1084         * resultsdbpy/resultsdbpy/view/static/js/tooltip.css: Add left and right tooltip arrows.
1085         * resultsdbpy/resultsdbpy/view/static/js/tooltip.js:
1086         (isPointInElement): Make bound check include borders.
1087         (_ToolTip.toString): Add left/right cases.
1088         (_ToolTip.prototype.setByElement): Set the tooltip location given an element.
1089         * resultsdbpy/resultsdbpy/view/templates/search.html: Put the legend into the sidebar.
1090         * resultsdbpy/resultsdbpy/view/templates/suite_results.html: Ditto.
1091
1092 2019-09-03  Jonathan Bedard  <jbedard@apple.com>
1093
1094         results.webkit.org: Increase default limit for LimitSlider
1095         https://bugs.webkit.org/show_bug.cgi?id=201424
1096
1097         Reviewed by Aakash Jain.
1098
1099         * resultsdbpy/resultsdbpy/view/static/js/drawer.js:
1100         (LimitSlider): Increase the default limit, make limit slider linear instead of logarithmic.
1101
1102 2019-09-03  Antoine Quint  <graouts@apple.com>
1103
1104         [iOS] Treat a two-finger single tap as if the user tapped with the Cmd key pressed
1105         https://bugs.webkit.org/show_bug.cgi?id=201420
1106         <rdar://problem/53207786>
1107
1108         Reviewed by Simon Fraser.
1109
1110         Add a new twoFingerSingleTapAtPoint() method to UIScriptController, which just calls into the existing (but unused)
1111         -[HIDEventGenerator twoFingerTap:completionBlock:].
1112
1113         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1114         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1115         (WTR::UIScriptController::twoFingerSingleTapAtPoint):
1116         * WebKitTestRunner/ios/UIScriptControllerIOS.h:
1117         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1118         (WTR::UIScriptControllerIOS::twoFingerSingleTapAtPoint):
1119
1120 2019-09-03  Zan Dobersek  <zdobersek@igalia.com>
1121
1122         [WPE] MiniBrowser should handle the WebKitWebView::create signal
1123         https://bugs.webkit.org/show_bug.cgi?id=201417
1124
1125         Reviewed by Carlos Garcia Campos.
1126
1127         WPE's MiniBrowser should connect to and handle the
1128         WebKitWebView::create signal, constructing a new bit related
1129         WebKitWebView object upon invocation.
1130
1131         * MiniBrowser/wpe/main.cpp:
1132         (webViewClose):
1133         (createWebView):
1134         (main):
1135
1136 2019-09-03  Zan Dobersek  <zdobersek@igalia.com>
1137
1138         [WPE] Make view backends multi-view-friendly
1139         https://bugs.webkit.org/show_bug.cgi?id=201415
1140
1141         Reviewed by Carlos Garcia Campos.
1142
1143         Have the Wayland EGL connection for WindowViewBackend instances managed
1144         through a per-process singleton, allowing multiple backend objects
1145         use it for different views. HeadlessViewBackend already does this, but
1146         the code there is refurbished into a singleton structure.
1147
1148         The ViewBackend classes are adjusted to work with the backend-specific
1149         EGLDisplay objects (as constructed through the backend-specific EGL
1150         connection approach).
1151
1152         * wpe/backends/HeadlessViewBackend.cpp:
1153         (WPEToolingBackends::HeadlessEGLConnection::singleton):
1154         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend):
1155         (WPEToolingBackends::HeadlessViewBackend::~HeadlessViewBackend):
1156         (WPEToolingBackends::HeadlessViewBackend::createSnapshot):
1157         (WPEToolingBackends::getEGLDisplay): Deleted.
1158         * wpe/backends/ViewBackend.cpp:
1159         (WPEToolingBackends::ViewBackend::initialize):
1160         (WPEToolingBackends::ViewBackend::deinitialize):
1161         (WPEToolingBackends::ViewBackend::~ViewBackend): Deleted.
1162         * wpe/backends/ViewBackend.h:
1163         * wpe/backends/WindowViewBackend.cpp:
1164         (WPEToolingBackends::WaylandEGLConnection::singleton):
1165         (WPEToolingBackends::WindowViewBackend::WindowViewBackend):
1166         (WPEToolingBackends::WindowViewBackend::~WindowViewBackend):
1167         (WPEToolingBackends::WindowViewBackend::displayBuffer):
1168
1169 2019-09-03  Carlos Garcia Campos  <cgarcia@igalia.com>
1170
1171         [WPE][GTK] Deprecate nonfunctional process limit APIs
1172         https://bugs.webkit.org/show_bug.cgi?id=193749
1173
1174         Reviewed by Žan Doberšek.
1175
1176         * MiniBrowser/gtk/main.c:
1177         (main):
1178         * TestWebKitAPI/Tests/WebKitGLib/TestMultiprocess.cpp:
1179         (beforeAll):
1180         (testWebProcessLimit): Deleted.
1181
1182 2019-09-02  Zan Dobersek  <zdobersek@igalia.com>
1183
1184         [WPE] WindowBackend should do resizing properly
1185         https://bugs.webkit.org/show_bug.cgi?id=201386
1186
1187         Reviewed by Carlos Garcia Campos.
1188
1189         The WindowBackend implementation is resized via the XDG protocol. The
1190         initial size is stored for the object's lifetime and fallen back to when
1191         the XDG protocol reports (0,0) configuration size.
1192
1193         Upon each resize, we have to recreate the texture. We also have to size
1194         the GL viewport accordingly.
1195
1196         * wpe/backends/WindowViewBackend.cpp:
1197         (WPEToolingBackends::WindowViewBackend::WindowViewBackend):
1198         (WPEToolingBackends::WindowViewBackend::createViewTexture):
1199         (WPEToolingBackends::WindowViewBackend::resize):
1200         (WPEToolingBackends::WindowViewBackend::displayBuffer):
1201         * wpe/backends/WindowViewBackend.h:
1202
1203 2019-09-01  Fujii Hironori  <Hironori.Fujii@sony.com>
1204
1205         Unreviewed, rolling out r249366.
1206
1207         WinCairo WebKit2 crashes in some websites and the device scale
1208         factor is not correct in high DPI.
1209
1210         Reverted changeset:
1211
1212         "[WinCairo, FTW] Properly handle device scale factor"
1213         https://bugs.webkit.org/show_bug.cgi?id=201361
1214         https://trac.webkit.org/changeset/249366
1215
1216 2019-09-01  Wenson Hsieh  <wenson_hsieh@apple.com>
1217
1218         Long presses that interrupt accelerated scrolling dispatch clicks on apps linked against iOS 12 or earlier
1219         https://bugs.webkit.org/show_bug.cgi?id=201346
1220         <rdar://problem/54885784>
1221
1222         Reviewed by Dean Jackson.
1223
1224         Add a new test option to allow tests to disable link previews.
1225
1226         * WebKitTestRunner/TestController.cpp:
1227         (WTR::updateTestOptionsFromTestHeader):
1228         * WebKitTestRunner/TestOptions.h:
1229
1230         Drive-by fix: also check enableLazyImageLoading when determining whether two TestOptions are the same.
1231
1232         (WTR::TestOptions::hasSameInitializationOptions const):
1233         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1234         (WTR::TestController::platformCreateWebView):
1235
1236 2019-08-30  Brent Fulgham  <bfulgham@apple.com>
1237
1238         [WinCairo, FTW] Properly handle device scale factor
1239         https://bugs.webkit.org/show_bug.cgi?id=201361
1240
1241         Reviewed by Don Olmstead.
1242
1243         Reset zoom to 1.0; device scale is handled elsewhere.
1244
1245         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1246         (WebKitBrowserWindow::resetZoom):
1247
1248 2019-08-30  Zhifei Fang  <zhifei_fang@apple.com>
1249
1250         [results.webkit.org Timeline] Add notify rerender API for timeline
1251         https://bugs.webkit.org/show_bug.cgi?id=201363
1252
1253         Reviewed by Jonathan Bedard.
1254
1255         * resultsdbpy/resultsdbpy/view/static/js/timeline.js: Export notifyRerender API to timeline class
1256         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
1257         (XScrollableCanvasProvider): Add an event stream to receive notification that it will need to render 
1258         (prototype.ExpandableSeriesComponent): Notify the rerender when expanded, because this may change the layout.
1259         (prototype.Timeline.CanvasContainer):
1260
1261 2019-08-30  Aakash Jain  <aakash_jain@apple.com>
1262
1263         [ews-build] 're-run-layout-tests' step on macOS-High-Sierra-Debug-WK1-Tests-EWS runs WK2 tests
1264         https://bugs.webkit.org/show_bug.cgi?id=201350
1265
1266         Reviewed by Jonathan Bedard.
1267
1268         * BuildSlaveSupport/ews-build/steps.py:
1269         (RunWebKit1Tests.start): Set build property to use dump-render-tree.
1270         (RunWebKitTests.start): Use dump-render-tree whenever the corresponding build property is set.
1271
1272 2019-08-30  Jonathan Bedard  <jbedard@apple.com>
1273
1274         results.webkit.org: Add endpoints to upload and download archives
1275         https://bugs.webkit.org/show_bug.cgi?id=201100
1276
1277         Reviewed by Aakash Jain.
1278
1279         Add the endpoint to upload and download a zip archive associated with a test run.
1280
1281         * resultsdbpy/resultsdbpy/controller/api_routes.py:
1282         (APIRoutes.__init__): Add archive endpoint.
1283         * resultsdbpy/resultsdbpy/controller/archive_controller.py: Added.
1284         (ArchiveController):
1285         (ArchiveController.__init__):
1286         (ArchiveController.endpoint):
1287         (ArchiveController.download):
1288         (ArchiveController.upload):
1289         * resultsdbpy/resultsdbpy/controller/archive_controller_unittest.py: Added.
1290         (ArchiveControllerUnittest):
1291         * resultsdbpy/resultsdbpy/model/configuration_context.py:
1292         (ClusteredByConfiguration.register_configuration): Make error message more clear.
1293
1294 2019-08-30  Simon Fraser  <simon.fraser@apple.com>
1295
1296         Add system tracing points for compositing updates, and touch-event dispatching
1297         https://bugs.webkit.org/show_bug.cgi?id=201327
1298
1299         Reviewed by Alex Christensen.
1300
1301         * Tracing/SystemTracePoints.plist:
1302
1303 2019-08-30  Keith Rollin  <krollin@apple.com>
1304
1305         Simplify PLATFORM expression
1306         https://bugs.webkit.org/show_bug.cgi?id=201286
1307         <rdar://problem/54822347>
1308
1309         Reviewed by Alexey Proskuryakov.
1310
1311         The preprocessor expression conditionalizing the inclusion of the body
1312         of ExitFullscreenOnEnterPiP.mm evolved into:
1313
1314             #if PLATFORM(MAC) || (PLATFORM(IOS_FAMILY) && !PLATFORM(IOS_FAMILY_SIMULATOR))
1315
1316         Simplify this to just:
1317
1318             #if !PLATFORM(IOS_FAMILY_SIMULATOR)
1319
1320         * TestWebKitAPI/Tests/WebKitCocoa/ExitFullscreenOnEnterPiP.mm:
1321
1322 2019-08-30  Keith Rollin  <krollin@apple.com>
1323
1324         Remove AppKitCompatibilityDeclarations.h
1325         https://bugs.webkit.org/show_bug.cgi?id=201283
1326         <rdar://problem/54822042>
1327
1328         Reviewed by Alexey Proskuryakov.
1329
1330         The two copies of these files -- on in WTF, one in MiniBrowser -- are
1331         empty and can be removed.
1332
1333         * DumpRenderTree/mac/EventSendingController.mm:
1334         * DumpRenderTree/mac/TextInputControllerMac.m:
1335         * MiniBrowser/AppKitCompatibilityDeclarations.h: Removed.
1336         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
1337         * MiniBrowser/mac/SettingsController.m:
1338         * MiniBrowser/mac/WK1BrowserWindowController.m:
1339         * MiniBrowser/mac/WK2BrowserWindowController.m:
1340         * TestWebKitAPI/Tests/WebKit/mac/ContextMenuImgWithVideo.mm:
1341         * TestWebKitAPI/Tests/WebKitCocoa/CommandBackForward.mm:
1342         * TestWebKitAPI/Tests/WebKitCocoa/DecidePolicyForNavigationAction.mm:
1343         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm:
1344         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenLayoutConstraints.mm:
1345         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenTopContentInset.mm:
1346         * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
1347         * TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
1348         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
1349         * TestWebKitAPI/Tests/WebKitCocoa/UserInitiatedActionInNavigationAction.mm:
1350         * TestWebKitAPI/Tests/mac/AcceptsFirstMouse.mm:
1351         * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.mm:
1352         * TestWebKitAPI/Tests/mac/ContextMenuDefaultItemsHaveTags.mm:
1353         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
1354         * TestWebKitAPI/Tests/mac/MediaPlaybackSleepAssertion.mm:
1355         * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm:
1356         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1357         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
1358         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
1359         * WebKitTestRunner/mac/EventSenderProxy.mm:
1360         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1361         * WebKitTestRunner/mac/TestControllerMac.mm:
1362
1363 2019-08-30  Adrian Perez de Castro  <aperez@igalia.com>
1364
1365         [WPE][GTK] New API to remove a filter from an user content manager given its identifier
1366         https://bugs.webkit.org/show_bug.cgi?id=200479
1367
1368         Reviewed by Carlos Garcia Campos.
1369
1370         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
1371         (testUserContentManagerContentFilter): Test also the new
1372         webkit_user_content_manager_remove_filter_by_id() public API function.
1373
1374 2019-08-30  Philippe Normand  <pnormand@igalia.com>
1375
1376         [WPE][Qt] loadingChanged signal parameter is unusable
1377         https://bugs.webkit.org/show_bug.cgi?id=201301
1378
1379         Reviewed by Carlos Garcia Campos.
1380
1381         * MiniBrowser/wpe/qt/main.qml: Add a basic loadingChange signal handler.
1382         * Scripts/webkitpy/style/checker.py: White-list WPEQtView.h for
1383         readablity/parameter_name code styl checker rule.
1384
1385 2019-08-29  Keith Rollin  <krollin@apple.com>
1386
1387         Update .xcconfig symbols to reflect the current set of past and future product versions.
1388         https://bugs.webkit.org/show_bug.cgi?id=200720
1389         <rdar://problem/54305032>
1390
1391         Reviewed by Alex Christensen.
1392
1393         Remove version symbols related to old OS's we no longer support,
1394         ensure that version symbols are defined for OS's we do support.
1395
1396         * ContentExtensionTester/Configurations/Base.xcconfig:
1397         * ContentExtensionTester/Configurations/DebugRelease.xcconfig:
1398         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1399         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1400         * ImageDiff/cg/Configurations/Base.xcconfig:
1401         * ImageDiff/cg/Configurations/DebugRelease.xcconfig:
1402         * MiniBrowser/Configurations/Base.xcconfig:
1403         * MiniBrowser/Configurations/DebugRelease.xcconfig:
1404         * TestWebKitAPI/Configurations/Base.xcconfig:
1405         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
1406         * WebEditingTester/Configurations/Base.xcconfig:
1407         * WebEditingTester/Configurations/DebugRelease.xcconfig:
1408         * WebKitTestRunner/Configurations/Base.xcconfig:
1409         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1410         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
1411         * lldb/lldbWebKitTester/Configurations/DebugRelease.xcconfig:
1412
1413 2019-08-29  Keith Rollin  <krollin@apple.com>
1414
1415         Remove empty FontCache.cpp file in TestWebKitAPI
1416         https://bugs.webkit.org/show_bug.cgi?id=201277
1417         <rdar://problem/54820726>
1418
1419         Reviewed by Alex Christensen.
1420
1421         Bug 200694 emptied out the contents of FontCache.cpp. This patch
1422         removes the file from the project.
1423
1424         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1425         * TestWebKitAPI/Tests/WebCore/FontCache.cpp: Removed.
1426
1427 2019-08-29  Aakash Jain  <aakash_jain@apple.com>
1428
1429         [ews-app] Status bubble should only display important messages in pop-over
1430         https://bugs.webkit.org/show_bug.cgi?id=201308
1431
1432         Reviewed by Jonathan Bedard.
1433
1434         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py: Added various build-steps which are of low interest
1435         to end-users in STEPS_TO_HIDE. If any of these steps fail, it will not be hidden.
1436
1437 2019-08-29  Keith Rollin  <krollin@apple.com>
1438
1439         Remove support for macOS < 10.13 (part 3)
1440         https://bugs.webkit.org/show_bug.cgi?id=201224
1441         <rdar://problem/54795934>
1442
1443         Reviewed by Darin Adler.
1444
1445         Remove symbols in WebKitTargetConditionals.xcconfig related to macOS
1446         10.13, including WK_MACOS_1013 and WK_MACOS_BEFORE_1013, and suffixes
1447         like _MACOS_SINCE_1013.
1448
1449         Also added some macOS target numbers.
1450
1451         * TestWebKitAPI/Configurations/WebKitTargetConditionals.xcconfig:
1452
1453 2019-08-29  Jonathan Bedard  <jbedard@apple.com>
1454
1455         results.webkit.org: Remove border from tooltip
1456         https://bugs.webkit.org/show_bug.cgi?id=201239
1457
1458         Reviewed by Alex Christensen.
1459
1460         * resultsdbpy/resultsdbpy/view/static/css/tooltip.css:
1461         (.tooltip-content): Remove border.
1462
1463 2019-08-28  Fujii Hironori  <Hironori.Fujii@sony.com>
1464
1465         [Win] MiniBrowser crashes in WKURLCopyString if WKPageCopyActiveURL returns null
1466         https://bugs.webkit.org/show_bug.cgi?id=201215
1467
1468         Reviewed by Don Olmstead.
1469
1470         MiniBrowser crashed if it was going to go to a unreachable page
1471         because WKPageCopyActiveURL returned a nullptr.
1472
1473         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1474         (createString): Added null checking of the argument.
1475
1476 2019-08-28  Tim Horton  <timothy_horton@apple.com>
1477
1478         Reloading a web view with a fixed-width viewport and variable content width restores the previous page scale, shouldn't
1479         https://bugs.webkit.org/show_bug.cgi?id=201256
1480         <rdar://problem/54809509>
1481
1482         Reviewed by Simon Fraser.
1483
1484         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1485         * TestWebKitAPI/Tests/WebKit/long-email-viewport.html: Added.
1486         * TestWebKitAPI/Tests/WebKitCocoa/ReloadWithDifferingInitialScale.mm: Added.
1487         (TestWebKitAPI::TEST):
1488         Add a test. I left many comments because I had a great deal of trouble
1489         writing this test and wanted to document my findings.
1490
1491 2019-08-28  Jonathan Bedard  <jbedard@apple.com>
1492
1493         results.webkit.org: Do not display branch selector if only one branches available
1494         https://bugs.webkit.org/show_bug.cgi?id=201244
1495
1496         Rubber-stamped by Aakash Jain.
1497
1498         * resultsdbpy/resultsdbpy/view/static/js/drawer.js: Hide the branch selector's
1499         container if there aren't multiple branches to choose from.
1500
1501 2019-08-28  Wenson Hsieh  <wenson_hsieh@apple.com>
1502
1503         WKAttachmentTests.DropFolderAsAttachmentAndMoveByDragging fails in some iOS simulator configurations
1504         https://bugs.webkit.org/show_bug.cgi?id=201241
1505         <rdar://problem/54317588>
1506
1507         Reviewed by Tim Horton.
1508
1509         For reasons that are still unknown, it's possible for iOS 13 simulators to get into a state where the IPC
1510         communication delay between the web and UI processes can become extraordinarily long. Under these circumstances,
1511         the drag and drop harness fails to simulate a drop, since it ends up firing all scheduled calls to
1512         -dropInteraction:sessionDidUpdate: before the first response from the web process arrives in the UI process, so
1513         it believes that the web view has rejected the drop from being handled.
1514
1515         Instead, make the drag and drop simulator robust by ensuring a presentation update between drop session updates,
1516         to make sure that the web process has had time to send a response after each update.
1517
1518         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1519         (-[DragAndDropSimulator _advanceProgress]):
1520
1521 2019-08-28  Megan Gardner  <megan_gardner@apple.com>
1522
1523         Null check webFrame when creating a print preview to prevent a crash.
1524         https://bugs.webkit.org/show_bug.cgi?id=201237
1525         <rdar://problem/51618863>
1526
1527         Reviewed by Tim Horton.
1528
1529         Test to verify that if we don't have the WebPageProxy, we will not crash when making a print preview.
1530
1531         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
1532         (TEST):
1533
1534 2019-08-28  Jonathan Bedard  <jbedard@apple.com>
1535
1536         results.webkit.org: Move drawer to the right, open by default
1537         https://bugs.webkit.org/show_bug.cgi?id=200977
1538
1539         Rubber-stamped by Aakash Jain.
1540
1541         The drawer was both unpopular and not discoverable. After feedback from bot watchers,
1542         moving the drawer to the right side of the screen, opening it by default and have it displace
1543         instead of hide the main content.
1544
1545         * resultsdbpy/resultsdbpy/view/commit_view_unittest.py:
1546         (CommitViewUnittest.test_drawer): Support new drawer style.
1547         (CommitViewUnittest.test_range_slider): Ditto.
1548         (CommitViewUnittest.test_one_line_switch): Ditto.
1549         (CommitViewUnittest.test_branch_selection): Ditto.
1550         * resultsdbpy/resultsdbpy/view/static/css/drawer.css: Removed.
1551         * resultsdbpy/resultsdbpy/view/static/js/drawer.js:
1552         (setEnableRecursive): Disable all elements underneath this one 
1553         (Drawer): Make drawer a sidebar.
1554         * resultsdbpy/resultsdbpy/view/static/library/css/webkit.css:
1555         (.header>.title, .topbar>.title): Overflow of titles should be hidden.
1556         (:root): Move boldInverseColor into webkit.css.
1557         (@media (prefers-color-scheme: dark)):
1558         (.sidebar): Sidebars on mobile should behave like drawers.
1559         (.sidebar.hidden): Add concept of hidden sidebar.
1560         (.mobile-sidebar-control): Add a control to collapse sidebar that only exists on mobile.
1561         (.mobile-sidebar-control.display):
1562         (.main.under-topbar-with-actions):
1563         (@media screen and (min-width: 600px) and (orientation: landscape)):
1564         (.sidebar.left.hidden):
1565         (.sidebar.right.hidden):
1566         (.main.right.hidden):
1567         (.main.left.hidden):
1568         (@media screen and (min-width: 768px) and (orientation: landscape)):
1569         (.sidebar.right):
1570         (a.disabled): Add ability to disable a link.
1571         (.desktop-control): Add a control which only exists on desktop.
1572         * resultsdbpy/resultsdbpy/view/templates/base.html: Add hamburger drawer-button for mobile.
1573         * resultsdbpy/resultsdbpy/view/templates/commits.html: Use main since Drawer is now a sidebar.
1574         * resultsdbpy/resultsdbpy/view/templates/documentation.html: Ditto.
1575         * resultsdbpy/resultsdbpy/view/templates/search.html: Ditto.
1576         * resultsdbpy/resultsdbpy/view/templates/suite_results.html: Ditto.
1577         * resultsdbpy/resultsdbpy/view/view_routes_unittest.py:
1578         (WebSiteTestCase.toggle_drawer): Support new drawer style.
1579         (WebSiteTestCase.find_input_with_name): Ditto.
1580
1581 2019-08-28  Keith Rollin  <krollin@apple.com>
1582
1583         Remove support for macOS < 10.13 (part 2)
1584         https://bugs.webkit.org/show_bug.cgi?id=201197
1585         <rdar://problem/54759985>
1586
1587         Reviewed by Darin Adler.
1588
1589         Update conditionals that reference WK_MACOS_1013 and suffixes like
1590         _MACOS_SINCE_1013, assuming that we're always building on 10.13 or
1591         later and that these conditionals are always True or False.
1592
1593         See Bug 200694 for earlier changes in this area.
1594
1595         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1596
1597 2019-08-28  Alicia Boya García  <aboya@igalia.com>
1598
1599         [MSE][GStreamer] WebKitMediaSrc rework
1600         https://bugs.webkit.org/show_bug.cgi?id=199719
1601
1602         Reviewed by Xabier Rodriguez-Calvar.
1603
1604         Added WebKitMediaSourceGStreamer.cpp to the GStreamer-style coding
1605         whitelist.
1606
1607         * Scripts/webkitpy/style/checker.py:
1608
1609 2019-08-28  Alexey Proskuryakov  <ap@apple.com>
1610
1611         Updating inactive contributors in contributors.json.
1612
1613         * Scripts/webkitpy/common/config/contributors.json:
1614
1615 2019-08-28  Jonathan Bedard  <jbedard@apple.com>
1616
1617         results.webkit.org: Auto-expand single configurations
1618         https://bugs.webkit.org/show_bug.cgi?id=201218
1619
1620         Rubber-stamped by Aakash Jain.
1621
1622         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
1623         (TimelineFromEndpoint.toString): Automatically expand timeline when only one
1624         configuration has been specified.
1625         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
1626         (prototype.ExpandableSeriesComponent): Add options so that the caller can set whether a timeline
1627         is expanded or collapsed by default.
1628
1629 2019-08-28  Jonathan Bedard  <jbedard@apple.com>
1630
1631         results.webkit.org: Sanitize all commit arguments on upload
1632         https://bugs.webkit.org/show_bug.cgi?id=201189
1633         <rdar://problem/54564837>
1634
1635         Reviewed by Aakash Jain.
1636
1637         * resultsdbpy/resultsdbpy/controller/commit.py:
1638         (Commit.__init__): Only allow commits to be constructed with valid values.
1639         * resultsdbpy/resultsdbpy/controller/commit_controller.py:
1640         (CommitController.register): Strip potential API key.
1641         * resultsdbpy/resultsdbpy/controller/commit_unittest.py:
1642         (CommitUnittest.test_invalid): Test that commits which contain html inside the
1643         repository_id, branch or commit id are rejected.
1644
1645 2019-08-02  Claudio Saavedra  <csaavedra@igalia.com>
1646
1647         [GTK][WPE] Implement HSTS for the soup network backend
1648         https://bugs.webkit.org/show_bug.cgi?id=192074
1649
1650         Reviewed by Carlos Garcia Campos.
1651
1652         libsoup 2.67.1 introduced HSTS support via a SoupSessionFeature.
1653         Add support to the soup network backend by adding the feature to
1654         SoupNetworkSession and handling HSTS protocol upgrades, by
1655         propagating the scheme change further to clients. This patch adds
1656         the HSTS feature unconditionally, but it still possible to add
1657         a boolean property to the web context class if desired.
1658
1659         Additionally, add API to the WebKitWebsiteDataManager to specify
1660         the directory where the HSTS database is saved. If the directory
1661         is not set or if the data manager is ephemeral, use a
1662         non-persistent, memory only HSTS enforcer.
1663
1664         Implement as well the methods needed to clean-up and delete HSTS
1665         policies from the storage and expose the feature in GTK+
1666         MiniBrowser's about:data.
1667
1668         * MiniBrowser/gtk/main.c:
1669         (gotWebsiteDataCallback):
1670         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
1671         (serverCallback):
1672         (testWebsiteDataConfiguration):
1673         (testWebsiteDataEphemeral):
1674         (prepopulateHstsData):
1675         (testWebsiteDataHsts):
1676         (beforeAll):
1677         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
1678         (Test::Test):
1679         * gtk/jhbuild.modules: Bump libsoup to 2.67.91 for the new APIs
1680         * wpe/jhbuild.modules: Ditto
1681         * MiniBrowser/gtk/main.c:
1682         (gotWebsiteDataCallback):
1683
1684 2019-08-27  James Darpinian  <jdarpinian@google.com>
1685
1686         Fix applying diffs that only change file mode
1687         https://bugs.webkit.org/show_bug.cgi?id=201191
1688
1689         Reviewed by Daniel Bates.
1690
1691         * Scripts/svn-apply:
1692         (patch): Handle case of file mode change without content change
1693
1694 2019-08-27  Aakash Jain  <aakash_jain@apple.com>
1695
1696         [ews] Status bubble should be red for CANCELLED builds
1697         https://bugs.webkit.org/show_bug.cgi?id=201204
1698
1699         Reviewed by Jonathan Bedard.
1700
1701         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1702         (StatusBubble._build_bubble):
1703
1704 2019-08-27  Zhifei Fang  <zhifei_fang@apple.com>
1705
1706         [results.webkit.org Webkit.css] Center the legend symbols
1707         https://bugs.webkit.org/show_bug.cgi?id=201187
1708
1709         Reviewed by Jonathan Bedard.
1710
1711         * resultsdbpy/resultsdbpy/view/static/library/css/webkit.css:
1712         (.lengend>.item .dot .text): center the dot symbol vertically
1713
1714 2019-08-27  Jonathan Bedard  <jbedard@apple.com>
1715
1716         run-webkit-tests: Use -noBulkSymbolication when calling spindump (Follow-up fix)
1717         https://bugs.webkit.org/show_bug.cgi?id=201000
1718         <rdar://problem/53778938>
1719
1720         Unreviewed follow-up fix.
1721
1722         * Scripts/webkitpy/port/darwin.py:
1723         (DarwinPort.sample_process): Run spindump without -noBulkSymbolication if previous
1724         spindump call failed.
1725         * Scripts/webkitpy/port/darwin_testcase.py:
1726         * Scripts/webkitpy/port/ios_device_unittest.py:
1727
1728 2019-08-27  Aakash Jain  <aakash_jain@apple.com>
1729
1730         [ews-build] Use update-webkit script in Apply-WatchList EWS
1731         https://bugs.webkit.org/show_bug.cgi?id=201179
1732
1733         Reviewed by Jonathan Bedard.
1734
1735         * BuildSlaveSupport/ews-build/factories.py:
1736         (WatchListFactory): Updated to use CheckOutSource step as well.
1737
1738 2019-08-27  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1739
1740         W3C test importer should be able to handle expected references with an absolute path.
1741         https://bugs.webkit.org/show_bug.cgi?id=200717
1742
1743         Reviewed by Youenn Fablet.
1744
1745         This patch implements the logic to resolve test references with absolute paths
1746         when importing w3c tests (like web-platform-tests).
1747         When an absolute path is found for a test reference, the parser now
1748         tries to find the right file by looking for a relative path inside
1749         the root directory of the source test repository.
1750         It works when the tool is run in download-mode as well as when the
1751         tool is run to import the tests from a local directory.
1752
1753         This fixes the import of test references for tests like
1754         web-platform-tests/css/css-images/multiple-position-color-stop-linear-2.html
1755
1756         * Scripts/webkitpy/w3c/test_importer.py:
1757         (TestImporter._source_root_directory_for_path):
1758         (TestImporter.find_importable_tests):
1759         * Scripts/webkitpy/w3c/test_importer_unittest.py:
1760         (TestImporterTest.import_directory):
1761         (test_webkit_test_runner_options):
1762         (test_webkit_test_runner_import_reftests_with_absolute_paths_download):
1763         (test_webkit_test_runner_import_reftests_with_absolute_paths_from_source_dir):
1764         * Scripts/webkitpy/w3c/test_parser.py:
1765         (TestParser.__init__):
1766         (TestParser.analyze_test):
1767
1768 2019-08-26  Wenson Hsieh  <wenson_hsieh@apple.com>
1769
1770         Remove UIHelper.activateElementAtHumanSpeed
1771         https://bugs.webkit.org/show_bug.cgi?id=201147
1772
1773         Reviewed by Tim Horton.
1774
1775         Add plumbing for a new script controller hook to wait for the double tap delay to pass. On non-iOS, this
1776         resolves immediately; on iOS, we inspect the content view for tap gestures that require more than one tap, and
1777         find the value of the maximum double tap delay. We then delay for this amount of time before resolving.
1778
1779         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1780         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1781         (WTR::UIScriptController::doAfterDoubleTapDelay):
1782         * WebKitTestRunner/ios/UIScriptControllerIOS.h:
1783         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1784         (WTR::UIScriptControllerIOS::doAfterDoubleTapDelay):
1785
1786 2019-08-26  Zhifei Fang  <zhifei_fang@apple.com>
1787
1788         [results.webkit.org Timline] Add symbols to the timeline dot
1789         https://bugs.webkit.org/show_bug.cgi?id=201105
1790
1791         Reviewed by Jonathan Bedard.
1792
1793         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
1794         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
1795         (Timeline.CanvasSeriesComponent): Modify the drawDot api to provide user ability to add symbol to the dots, it supports unicode symbol
1796         * resultsdbpy/resultsdbpy/view/templates/base.html: Add the encoding UTF-8 for the page, so that we can add unicode symbol to the dots
1797
1798 2019-08-26  Yusuke Suzuki  <ysuzuki@apple.com>
1799
1800         Unreviewed, remove useMaximalFlushInsertionPhase use
1801         https://bugs.webkit.org/show_bug.cgi?id=201036
1802
1803         * Scripts/run-jsc-stress-tests:
1804
1805 2019-08-26  David Kilzer  <ddkilzer@apple.com>
1806
1807         Don't compute upconverted characters twice in buildQuery() in DataDetection.mm
1808         <https://webkit.org/b/201144>
1809         <rdar://problem/54689399>
1810
1811         Reviewed by Brent Fulgham.
1812
1813         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add
1814         DataDetectorsTestIOS.mm to the project.
1815         * TestWebKitAPI/Tests/ios/DataDetectorsTestIOS.mm: Add a new
1816         test for Data Detectors for phone numbers.
1817
1818 2019-08-26  Wenson Hsieh  <wenson_hsieh@apple.com>
1819
1820         REGRESSION (iOS 13): Tests that simulate multiple back-to-back single taps fail or time out
1821         https://bugs.webkit.org/show_bug.cgi?id=201129
1822         <rdar://problem/51857277>
1823
1824         Reviewed by Tim Horton.
1825
1826         The tests in editing/pasteboard/ios were timing out on iOS 13 before this change. This is because they simulate
1827         back-to-back single taps; while this is recognized as two single taps on iOS 12 and prior, only the first single
1828         tap is recognized on iOS 13 (and the second is simply dropped on the floor). This occurs because the synthetic
1829         single tap gesture is reset slightly later on iOS 13 compared to iOS 12, so when the second tap is dispatched,
1830         the gesture recognizer is still in "ended" state after the first tap on iOS 13, which means the gesture isn't
1831         capable of recognizing further touches yet.
1832
1833         In UIKit, a gesture recognizer is only reset once its UIGestureEnvironment's containing dependency subgraph no
1834         longer contains gestures that are active. In iOS 12, the synthetic click gesture is a part of a dependency
1835         subgraph that contains only itself and the normal (blocking) double tap gesture which requires the click to fail
1836         before it can be recognized; immediately after simulating the tap, both these gestures are inactive, which
1837         allows both of them to be reset.
1838
1839         However, in iOS 13, the synthetic click gesture is part of a gesture dependency graph that contains the double
1840         tap for double click gesture, as well as the non-blocking double tap gesture, both of which are still active
1841         immediately after sending the first tap. This change in dependencies is caused by the introduction of
1842         UIUndoGestureInteraction's single and double three-finger tap gestures, which (in -[UIUndoGestureInteraction
1843         gestureRecognizer:shouldBeRequiredToFailByGestureRecognizer:]) explicitly add all other taps as failure
1844         requirements. This effectively links the synthetic single tap gesture to most of the other gestures in
1845         WKContentView's dependency graph by way of these tap gestures for the undo interaction.
1846
1847         All this means that there is now a short (~50 ms) delay after the synthetic single tap gestures is recognized,
1848         before it can be recognized again. To account for this new delay in our test infrastructure, simply wait for
1849         single tap gestures that have ended to reset before attempting to send subsequent single taps. We do this by
1850         introducing WebKit testing SPI to invoke a completion handler after resetting the synthetic click gesture (only
1851         if necessary - i.e., if the gesture is in ended state when we are about to begin simulating the tap). This
1852         allows calls to `UIScriptController::singleTapAtPoint` to be reliably recognized as single taps without
1853         requiring arbitrary 120 ms "human speed" delays.
1854
1855         This fixes a number of flaky or failing layout tests, including the tests in editing/pasteboard/ios.
1856
1857         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1858         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1859         (WTR::UIScriptController::doubleTapAtPoint):
1860
1861         Add a `delay` parameter to `doubleTapAtPoint`. A number of layout tests were actually simulating double click
1862         gestures by simulating two back-to-back single taps; this is done for the purposes of being able to add a "human
1863         speed" delay prior to the second single tap gesture. After the change to wait for the single tap gesture to
1864         reset before attempting to simulate the next tap, this strategy no longer works, since the second gesture is
1865         recognized only as a single tap instead of a double tap.
1866
1867         Instead, we add a delay parameter to `UIScriptController::doubleTapAtPoint`, which the "human speed" double tap
1868         gestures use instead to wait after simulating the first tap.
1869
1870         * WebKitTestRunner/ios/HIDEventGenerator.h:
1871         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1872         (-[HIDEventGenerator _waitFor:]):
1873         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:delay:completionBlock:]):
1874
1875         Plumb the tap gesture delay through to this helper method.
1876
1877         (-[HIDEventGenerator tap:completionBlock:]):
1878         (-[HIDEventGenerator doubleTap:delay:completionBlock:]):
1879         (-[HIDEventGenerator twoFingerTap:completionBlock:]):
1880         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]): Deleted.
1881         (-[HIDEventGenerator doubleTap:completionBlock:]): Deleted.
1882         * WebKitTestRunner/ios/UIScriptControllerIOS.h:
1883         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1884         (WTR::UIScriptControllerIOS::waitForSingleTapToReset const):
1885
1886         Add a new helper to wait for the content view's single tap gesture to reset if needed; call this before
1887         attempting to simulate single taps (either using a stylus, or with a regular touch).
1888
1889         (WTR::UIScriptControllerIOS::singleTapAtPointWithModifiers):
1890         (WTR::UIScriptControllerIOS::doubleTapAtPoint):
1891         (WTR::UIScriptControllerIOS::stylusTapAtPointWithModifiers):
1892
1893 2019-08-26  Jonathan Bedard  <jbedard@apple.com>
1894
1895         results.webkit.org: Allow clicking on the tooltip arrow
1896         https://bugs.webkit.org/show_bug.cgi?id=201103
1897
1898         Rubber-stamped by Aakash Jain.
1899
1900         By design, the arrow sits above the canvas and intercepts mouse events from it.
1901         This will often make an element that has a tooltip unclickable.
1902
1903         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
1904         (xAxisFromScale):
1905         (TimelineFromEndpoint.prototype.render.onDotEnterFactory):
1906         (TimelineFromEndpoint.prototype.render):
1907         * resultsdbpy/resultsdbpy/view/static/js/tooltip.js:
1908         (_ToolTip):
1909         (_ToolTip.prototype.toString): Trigger onClick callback when the arrow is clicked.
1910         (_ToolTip.prototype.set): Set the onClick callback.
1911
1912 2019-08-26  Aakash Jain  <aakash_jain@apple.com>
1913
1914         [EWS] Do not append additional '(failure)' string at the end of custom failure message in EWS Buildbot
1915         https://bugs.webkit.org/show_bug.cgi?id=201140
1916
1917         Reviewed by Jonathan Bedard.
1918
1919         * BuildSlaveSupport/ews-build/steps.py:
1920         (TestWithFailureCount.getResultSummary): Do not append (failure) when in case of custom status.
1921         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests accordingly.
1922
1923 2019-08-26  Jonathan Bedard  <jbedard@apple.com>
1924
1925         run-webkit-tests: Cap the number of automatically booted simulators at 12
1926         https://bugs.webkit.org/show_bug.cgi?id=201139
1927
1928         Reviewed by Aakash Jain.
1929
1930         To make local development with simulators more pleasant, machines should
1931         never automatically boot more than 12 simulators.
1932
1933         * Scripts/webkitpy/xcode/simulated_device.py:
1934         (SimulatedDeviceManager.max_supported_simulators):
1935
1936 2019-08-26  Aakash Jain  <aakash_jain@apple.com>
1937
1938         [ews] Add EWS queue for applying watchlist
1939         https://bugs.webkit.org/show_bug.cgi?id=201072
1940
1941         Reviewed by Jonathan Bedard.
1942
1943         * BuildSlaveSupport/ews-build/steps.py:
1944         (ApplyWatchList): Build step to apply watchlist.
1945         (ApplyWatchList.__init__): Set logEnviron to False.
1946         (ApplyWatchList.getResultSummary): Updated the description in case of failure.
1947         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
1948         * BuildSlaveSupport/ews-build/factories.py:
1949         (WatchListFactory): Build factory for WatchList.
1950         * BuildSlaveSupport/ews-build/loadConfig.py:
1951         * BuildSlaveSupport/ews-build/config.json:
1952
1953 2019-08-26  Youenn Fablet  <youenn@apple.com>
1954
1955         Add a WebsiteDataStore delegate to handle AuthenticationChallenge that do not come from pages
1956         https://bugs.webkit.org/show_bug.cgi?id=196870
1957
1958         Reviewed by Alex Christensen.
1959
1960         Implement the new delegate by respecting the value set by testRunner.setAllowsAnySSLCertificate
1961         Accept any server certificate by default.
1962
1963         * WebKitTestRunner/TestController.cpp:
1964         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1965         (WTR::TestController::cocoaResetStateToConsistentValues):
1966         (WTR::TestController::setAllowsAnySSLCertificate):
1967         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.h:
1968         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
1969         (-[TestWebsiteDataStoreDelegate didReceiveAuthenticationChallenge:completionHandler:]):
1970         (-[TestWebsiteDataStoreDelegate setAllowAnySSLCertificate:]):
1971
1972 2019-08-23  Aakash Jain  <aakash_jain@apple.com>
1973
1974         Increase log level for watchlist result
1975         https://bugs.webkit.org/show_bug.cgi?id=201081
1976
1977         Reviewed by Jonathan Bedard.
1978
1979         * Scripts/webkitpy/tool/steps/applywatchlist.py: Increased log level.
1980         * Scripts/webkitpy/tool/steps/applywatchlist_unittest.py: Updated unit-tests.
1981         * Scripts/webkitpy/tool/commands/applywatchlistlocal_unittest.py: Ditto.
1982
1983 2019-08-23  Chris Dumez  <cdumez@apple.com>
1984
1985         [geolocation] Rename interfaces and remove [NoInterfaceObject]
1986         https://bugs.webkit.org/show_bug.cgi?id=200885
1987
1988         Reviewed by Alex Christensen.
1989
1990         * DumpRenderTree/mac/TestRunnerMac.mm:
1991         (TestRunner::setMockGeolocationPosition):
1992
1993 2019-08-23  Ryan Haddad  <ryanhaddad@apple.com>
1994
1995         Unreviewed, rolling out r249001.
1996
1997         Caused one layout test to fail on all configurations and
1998         another to time out on Catalina / iOS 13.
1999
2000         Reverted changeset:
2001
2002         "Add a WebsiteDataStore delegate to handle
2003         AuthenticationChallenge that do not come from pages"
2004         https://bugs.webkit.org/show_bug.cgi?id=196870
2005         https://trac.webkit.org/changeset/249001
2006
2007 2019-08-23  Jonathan Bedard  <jbedard@apple.com>
2008
2009         results.webkit.org: Escape html in changelog
2010         https://bugs.webkit.org/show_bug.cgi?id=201025
2011         <rdar://problem/54564837>
2012
2013         Reviewed by Darin Adler.
2014
2015         * resultsdbpy/resultsdbpy/view/commit_view.py:
2016         (CommitView.commit): Output a dictionary instead of a JSON encoded string.
2017         * resultsdbpy/resultsdbpy/view/templates/commit.html: Unpack commits dictionary
2018         directly into a JavaScript dictionary.
2019
2020 2019-08-20  Jiewen Tan  <jiewen_tan@apple.com>
2021
2022         [WebAuthn] Support NFC authenticators for iOS
2023         https://bugs.webkit.org/show_bug.cgi?id=188624
2024         <rdar://problem/43354214>
2025
2026         Reviewed by Chris Dumez.
2027
2028         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2029         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
2030         Setup NFC mock testing configuration.
2031
2032 2019-08-23  Aakash Jain  <aakash_jain@apple.com>
2033
2034         [ews] Enable Style queue on new EWS
2035         https://bugs.webkit.org/show_bug.cgi?id=201071
2036
2037         Reviewed by Jonathan Bedard.
2038
2039         * BuildSlaveSupport/ews-build/config.json: Enabled the scheduler for Style queue.
2040         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py: Enabled style queue bubble on new EWS.
2041         * QueueStatusServer/config/queues.py: Removed style queue from old EWS.
2042         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
2043         (BubbleQueueServer): Removed style queue from bot-watcher's dashboard.
2044
2045 2019-08-22  Fujii Hironori  <Hironori.Fujii@sony.com>
2046
2047         [Win][MiniBrowser] URL bar should be updated for in-page navigations
2048         https://bugs.webkit.org/show_bug.cgi?id=201032
2049
2050         Reviewed by Darin Adler.
2051
2052         * MiniBrowser/win/BrowserWindow.h: Added activeURLChanged to BrowserWindowClient interface.
2053         * MiniBrowser/win/MainWindow.cpp:
2054         (MainWindow::init):
2055         (MainWindow::activeURLChanged): Added.
2056         * MiniBrowser/win/MainWindow.h:
2057         * MiniBrowser/win/MiniBrowserWebHost.cpp:
2058         (MiniBrowserWebHost::didCommitLoadForFrame):
2059         (MiniBrowserWebHost::didChangeLocationWithinPageForFrame): Added.
2060         (MiniBrowserWebHost::updateAddressBar): Deleted.
2061         (MiniBrowserWebHost::loadURL): Deleted.
2062         * MiniBrowser/win/MiniBrowserWebHost.h:
2063         (MiniBrowserWebHost::MiniBrowserWebHost):
2064         (MiniBrowserWebHost::didCommitLoadForFrame): Deleted.
2065         (MiniBrowserWebHost::didChangeLocationWithinPageForFrame): Deleted.
2066         * MiniBrowser/win/PrintWebUIDelegate.cpp:
2067         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2068         (WebKitBrowserWindow::create):
2069         (WebKitBrowserWindow::WebKitBrowserWindow):
2070         (WebKitBrowserWindow::didChangeIsLoading): Removed an unused variable.
2071         (WebKitBrowserWindow::didChangeActiveURL): Added.
2072         (WebKitBrowserWindow::createNewPage):
2073         (WebKitBrowserWindow::didCommitNavigation): Deleted.
2074         * MiniBrowser/win/WebKitBrowserWindow.h: Removed m_urlBarWnd.
2075         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
2076         (WebKitLegacyBrowserWindow::create):
2077         (WebKitLegacyBrowserWindow::WebKitLegacyBrowserWindow):
2078         (WebKitLegacyBrowserWindow::init):
2079         (WebKitLegacyBrowserWindow::navigateToHistory):
2080         * MiniBrowser/win/WebKitLegacyBrowserWindow.h: Removed m_urlBarWnd.
2081
2082 2019-08-22  Andy Estes  <aestes@apple.com>
2083
2084         [watchOS] Disable Content Filtering in the simulator build
2085         https://bugs.webkit.org/show_bug.cgi?id=201047
2086
2087         Reviewed by Tim Horton.
2088
2089         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2090
2091 2019-08-22  Chris Dumez  <cdumez@apple.com>
2092
2093         Try to recover nicely when getting an unexpected schema in the service workers database
2094         https://bugs.webkit.org/show_bug.cgi?id=201002
2095         <rdar://problem/54574991>
2096
2097         Reviewed by Youenn Fablet.
2098
2099         Add API test coverage.
2100
2101         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2102         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2103
2104 2019-08-22  Keith Rollin  <krollin@apple.com>
2105
2106         Remove support for tvOS < 13.0
2107         https://bugs.webkit.org/show_bug.cgi?id=200963
2108         <rdar://problem/54541355>
2109
2110         Reviewed by Tim Horton.
2111
2112         Update conditionals that reference __TV_OS_VERSION_MIN_REQUIRED and
2113         __TV_OS_VERSION_MAX_ALLOWED, assuming that they both have values >=
2114         130000. This means that expressions like "__TV_OS_VERSION_MIN_REQUIRED
2115         < 130000" are always False and "__TV_OS_VERSION_MIN_REQUIRED >=
2116         130000" are always True.
2117
2118         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm:
2119         (TestWebKitAPI::TEST):
2120
2121 2019-08-22  Daniel Bates  <dabates@apple.com>
2122
2123         [lldb-webkit] OptionSet summary shows size 0 sometimes for non-empty set
2124         https://bugs.webkit.org/show_bug.cgi?id=200742
2125
2126         Reviewed by Simon Fraser.
2127
2128         The OptionSet synthetic provider must respond to requests for the value of m_storage
2129         (i.e. GetChildMemberWithName('m_storage')) to avoid interfering with the computation
2130         of the type summary.
2131
2132         Synthetic providers substitute alternative debug information (children) for the default
2133         information for a variable. The OptionSet type summary is implemented in terms of the
2134         OptionSet synthetic provider to maximize code reuse. If LLDB instantiates the provider
2135         before invoking the type summary handler then evaluating GetChildMemberWithName() on
2136         the SBValue passed to the type summary handler will access the substitute information
2137         instead of the original debug information. As a result OptionSet's synthetic provider's
2138         get_child_index('m_storage') returns None hence SBValue.GetChildMemberWithName('m_storage')
2139         returned an invalid value; => WTFOptionSetProvider._bitmask() returns 0; => the size
2140         reported in the type summary for the OptionSet is 0. Instead get_child_index('m_storage')
2141         should return a valid value.
2142
2143         * lldb/lldb_webkit.py:
2144         (FlagEnumerationProvider.__init__):
2145         (FlagEnumerationProvider):
2146         (FlagEnumerationProvider._get_child_index): Added. WTFOptionSetProvider will override.
2147         (FlagEnumerationProvider._get_child_at_index): Added. WTFOptionSetProvider will override.
2148         (FlagEnumerationProvider.size): Added.
2149         (FlagEnumerationProvider.get_child_index): Modified to call _get_child_index().
2150         (FlagEnumerationProvider.get_child_at_index): Modified to call _get_child_at_index().
2151         (FlagEnumerationProvider.update): Moved initialization of self._elements to the constructor
2152         and removed self.size. For the latter we can just expose a getter that returns the size of
2153         the list self._elements.
2154         (WTFOptionSetProvider._get_child_index): Added. Return the index for LLDB to query for the
2155         value of m_storage.
2156         (WTFOptionSetProvider):
2157         (WTFOptionSetProvider._get_child_at_index): Added. Return the value for m_storage if it
2158         matches the specified index.
2159         * lldb/lldb_webkit_unittest.py:
2160         (TestSummaryProviders.serial_test_WTFOptionSetProvider_empty): Update expected result now
2161         that we return the value of m_storage as the last synthetic child.
2162
2163 2019-08-22  Jonathan Bedard  <jbedard@apple.com>
2164
2165         results.webkit.org: Remove branch and repository information from commit tooltip
2166         https://bugs.webkit.org/show_bug.cgi?id=201035
2167
2168         Reviewed by Aakash Jain.
2169
2170         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
2171         (xAxisFromScale): Remove branch and repository information from tooltip.
2172
2173 2019-08-22  Jonathan Bedard  <jbedard@apple.com>
2174
2175         run-webkit-tests: Use -noBulkSymbolication when calling spindump
2176         https://bugs.webkit.org/show_bug.cgi?id=201000
2177         <rdar://problem/53778938>
2178
2179         Reviewed by Alexey Proskuryakov.
2180
2181         * Scripts/webkitpy/port/darwin.py:
2182         (DarwinPort.sample_process): Attempt to symbolicate with -noBulkSymbolication first.
2183         * Scripts/webkitpy/port/darwin_testcase.py:
2184         (DarwinTest.test_tailspin):
2185         (DarwinTest.test_get_crash_log): Deleted.
2186         * Scripts/webkitpy/port/ios_device_unittest.py:
2187         (IOSDeviceTest.test_tailspin):
2188
2189 2019-08-22  Zhifei Fang  <zhifei_fang@apple.com>
2190
2191         [results.webkit.org Webkit.css] Change input's disable style
2192         The disable input style will always show the label like it has a value 
2193         https://bugs.webkit.org/show_bug.cgi?id=200998
2194
2195         Reviewed by Jonathan Bedard.
2196
2197         * resultsdbpy/resultsdbpy/view/static/library/css/docs.yaml: Adding a new example for disabled input that already has a value
2198         *resultsdbpy/resultsdbpy/view/static/library/css/generate-webkit-css-docs:
2199         * resultsdbpy/resultsdbpy/view/static/library/css/index.html:
2200         * resultsdbpy/resultsdbpy/view/static/library/css/webkit.css:
2201         (.input>input[type="text"][required][disabled],.input>input[type="number"][required][disabled],):When disabling a text input element even without a value, the style should match the style of a text input element with a value
2202         (.input>input[type="text"][required][disabled]~label, .input>input[type="number"][required][disabled]~label,):
2203         (@media (prefers-color-scheme: dark)):
2204
2205 2019-08-17  Darin Adler  <darin@apple.com>
2206
2207         Use makeString and multi-argument StringBuilder::append instead of less efficient multiple appends
2208         https://bugs.webkit.org/show_bug.cgi?id=200862
2209
2210         Reviewed by Ryosuke Niwa.
2211
2212         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2213         (WTR::TestRunner::statisticsDidRunTelemetryCallback): Use makeString.
2214         * WebKitTestRunner/TestController.cpp:
2215         (WTR::TestController::findAndDumpWebKitProcessIdentifiers): Ditto.
2216         (WTR::TestController::downloadDidReceiveServerRedirectToURL): Ditto.
2217         (WTR::TestController::downloadDidFail): Ditto.
2218
2219 2019-08-22  clopez@igalia.com  <clopez@igalia.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
2220
2221         [GTK][WPE] Support for command "--version" on the MiniBrowser (follow-up fix)
2222         https://bugs.webkit.org/show_bug.cgi?id=200978
2223
2224         Unreviewed follow-up fix.
2225
2226         Update the string format specifier for unsigned it.
2227
2228         * MiniBrowser/gtk/main.c:
2229         (main):
2230         * MiniBrowser/wpe/main.cpp:
2231         (main):
2232
2233 2019-08-22  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2234
2235         [GTK][WPE] Support for command "--version" on the MiniBrowser
2236         https://bugs.webkit.org/show_bug.cgi?id=200978
2237
2238         Reviewed by Žan Doberšek.
2239
2240         Printing the engine version used from the MiniBrowser is useful.
2241         For example, the test scripts on WPT can use this info to better
2242         tag the generated results.
2243
2244         * MiniBrowser/gtk/main.c: Print the engine version when called with --version or -v.
2245         (main):
2246         * MiniBrowser/wpe/main.cpp: Ditto.
2247         (main):
2248
2249 2019-08-22  Youenn Fablet  <youenn@apple.com>
2250
2251         Add a WebsiteDataStore delegate to handle AuthenticationChallenge that do not come from pages
2252         https://bugs.webkit.org/show_bug.cgi?id=196870
2253
2254         Reviewed by Alex Christensen.
2255
2256         Implement the new delegate by respecting the value set by testRunner.setAllowsAnySSLCertificate
2257         Accept any server certificate by default.
2258
2259         * WebKitTestRunner/TestController.cpp:
2260         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2261         (WTR::TestController::cocoaResetStateToConsistentValues):
2262         (WTR::TestController::setAllowsAnySSLCertificate):
2263         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.h:
2264         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
2265         (-[TestWebsiteDataStoreDelegate didReceiveAuthenticationChallenge:completionHandler:]):
2266         (-[TestWebsiteDataStoreDelegate setAllowAnySSLCertificate:]):
2267
2268 2019-08-21  Jonathan Bedard  <jbedard@apple.com>
2269
2270         results.webkit.org: Fix drawer style
2271         https://bugs.webkit.org/show_bug.cgi?id=200988
2272
2273         Rubber-stamped by Aakash Jain.
2274
2275         * resultsdbpy/resultsdbpy/view/static/js/drawer.js:
2276         (Drawer): Nothing in the drawer should be selectable.
2277         (ConfigurationSelectors): Standardize text size, remove underscore from expanders.
2278         * resultsdbpy/resultsdbpy/view/static/library/css/webkit.css:
2279         (.action:hover): Disable underline on 'links' which are actually actions
2280         (.unselectable): Make a div unselectable.
2281         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
2282         (Timeline.ExpandableSeriesWithHeaderExpanderComponent): Remove underscore from expanders.
2283
2284 2019-08-21  Fujii Hironori  <Hironori.Fujii@sony.com>
2285
2286         [Win][MiniBrowser] Add a progress indicator to the main window
2287         https://bugs.webkit.org/show_bug.cgi?id=200970
2288
2289         Reviewed by Alex Christensen.
2290
2291         * MiniBrowser/win/BrowserWindow.h: Added BrowserWindowClient class.
2292         * MiniBrowser/win/MainWindow.cpp:
2293         (MainWindow::init):
2294         (MainWindow::resizeSubViews):
2295         (MainWindow::progressChanged):
2296         (MainWindow::progressFinished):
2297         * MiniBrowser/win/MainWindow.h: Inherited BrowserWindowClient.
2298         Added m_hProgressIndicator.
2299         (MainWindow::hwnd const): Deleted.
2300         (MainWindow::browserWindow const): Deleted.
2301         (): Deleted.
2302         * MiniBrowser/win/MiniBrowserWebHost.cpp:
2303         (MiniBrowserWebHost::onNotify):
2304         * MiniBrowser/win/MiniBrowserWebHost.h:
2305         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2306         (WebKitBrowserWindow::create):
2307         (WebKitBrowserWindow::WebKitBrowserWindow):
2308         (WebKitBrowserWindow::didChangeIsLoading):
2309         (WebKitBrowserWindow::didChangeEstimatedProgress):
2310         (WebKitBrowserWindow::createNewPage):
2311         * MiniBrowser/win/WebKitBrowserWindow.h:
2312         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
2313         (WebKitLegacyBrowserWindow::create):
2314         (WebKitLegacyBrowserWindow::WebKitLegacyBrowserWindow):
2315         (WebKitLegacyBrowserWindow::init):
2316         * MiniBrowser/win/WebKitLegacyBrowserWindow.h:
2317
2318 2019-08-21  Ryan Haddad  <ryanhaddad@apple.com>
2319
2320         Unreviewed, rolling out r248970.
2321
2322         Caused
2323         lldb_webkit_unittest.TestSummaryProviders.serial_test_WTFOptionSetProvider_empty
2324         to fail.
2325
2326         Reverted changeset:
2327
2328         "[lldb-webkit] OptionSet summary shows size 0 sometimes for
2329         non-empty set"
2330         https://bugs.webkit.org/show_bug.cgi?id=200742
2331         https://trac.webkit.org/changeset/248970
2332
2333 2019-08-21  Jonathan Bedard  <jbedard@apple.com>
2334
2335         results.webkit.org: Add database table to save zip archives to
2336         https://bugs.webkit.org/show_bug.cgi?id=200718
2337
2338         Rubber-stamped by Aakash Jain.
2339
2340         * resultsdbpy/resultsdbpy/model/archive_context.py: Added.
2341         (ArchiveContext):
2342         (ArchiveContext.ArchivesByCommit): Store archives to be retrieved by commit and configuration.
2343         (ArchiveContext.ArchivesByCommit.unpack):
2344         (ArchiveContext.assert_zipfile):
2345         (ArchiveContext.open_zipfile):
2346         (ArchiveContext.__init__):
2347         (ArchiveContext.__enter__):
2348         (ArchiveContext.__exit__):
2349         (ArchiveContext.register): Save the provided archive to Cassandra.
2350         (ArchiveContext.find_archive): Find all archives matching the specified criteria.
2351         (ArchiveContext._files_for_archive):
2352         (ArchiveContext.ls): List all files in the matching archives.
2353         (ArchiveContext.file): Extract a file from the matching archives.
2354         * resultsdbpy/resultsdbpy/model/archive_context_unittest.py: Added.
2355         (ArchiveContextTest):
2356         * resultsdbpy/resultsdbpy/model/mock_model_factory.py:
2357         (MockModelFactory):
2358         (MockModelFactory.process_results):
2359         (MockModelFactory.add_mock_archives):
2360         * resultsdbpy/resultsdbpy/model/model.py:
2361         (Model.__init__): Add an ArchiveContext to the model.
2362
2363 2019-08-21  Aakash Jain  <aakash_jain@apple.com>
2364
2365         [ews-build] view layout test results option should be displayed next to layout-test build step
2366         https://bugs.webkit.org/show_bug.cgi?id=200048
2367
2368         Reviewed by Jonathan Bedard.
2369
2370         * BuildSlaveSupport/ews-build/steps.py:
2371         (ExtractTestResults.getLastBuildStepByName): Method to return the last build-step matching the step name.
2372         (ExtractTestResults.addCustomURLs): Add urls to corresponding layout-test step.
2373
2374 2019-08-21  Aakash Jain  <aakash_jain@apple.com>
2375
2376         [ews] Fix capitalization in Found x new Test failure message
2377         https://bugs.webkit.org/show_bug.cgi?id=201004
2378
2379         Reviewed by Alexey Proskuryakov.
2380
2381         * BuildSlaveSupport/ews-build/steps.py:
2382         (AnalyzeLayoutTestsResults.report_failure):
2383         (AnalyzeAPITestsResults.analyzeResults):
2384         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests accordingly.
2385
2386 2019-08-21  Aakash Jain  <aakash_jain@apple.com>
2387
2388         Assign ews117 to EWS High-Sierra Debug queues
2389         https://bugs.webkit.org/show_bug.cgi?id=200993
2390
2391         Reviewed by Jonathan Bedard.
2392
2393         * BuildSlaveSupport/ews-build/config.json:
2394
2395 2019-08-21  Daniel Bates  <dabates@apple.com>
2396
2397         [lldb-webkit] OptionSet summary shows size 0 sometimes for non-empty set
2398         https://bugs.webkit.org/show_bug.cgi?id=200742
2399
2400         Reviewed by Simon Fraser.
2401
2402         The OptionSet synthetic provider must respond to requests for the value of m_storage
2403         (i.e. GetChildMemberWithName('m_storage')) to avoid interfering with the computation
2404         of the type summary.
2405
2406         Synthetic providers substitute alternative debug information (children) for the default
2407         information for a variable. The OptionSet type summary is implemented in terms of the
2408         OptionSet synthetic provider to maximize code reuse. If LLDB instantiates the provider
2409         before invoking the type summary handler then evaluating GetChildMemberWithName() on
2410         the SBValue passed to the type summary handler will access the substitute information
2411         instead of the original debug information. As a result OptionSet's synthetic provider's
2412         get_child_index('m_storage') returns None hence SBValue.GetChildMemberWithName('m_storage')
2413         returned an invalid value; => WTFOptionSetProvider._bitmask() returns 0; => the size
2414         reported in the type summary for the OptionSet is 0. Instead get_child_index('m_storage')
2415         should return a valid value.
2416
2417         * lldb/lldb_webkit.py:
2418         (FlagEnumerationProvider.__init__):
2419         (FlagEnumerationProvider):
2420         (FlagEnumerationProvider._get_child_index): Added. WTFOptionSetProvider will override.
2421         (FlagEnumerationProvider._get_child_at_index): Added. WTFOptionSetProvider will override.
2422         (FlagEnumerationProvider.size): Added.
2423         (FlagEnumerationProvider.get_child_index): Modified to call _get_child_index().
2424         (FlagEnumerationProvider.get_child_at_index): Modified to call _get_child_at_index().
2425         (FlagEnumerationProvider.update): Moved initialization of self._elements to the constructor
2426         and removed self.size. For the latter we can just expose a getter that returns the size of
2427         the list self._elements.
2428         (WTFOptionSetProvider._get_child_index): Added. Return the index for LLDB to query for the
2429         value of m_storage.
2430         (WTFOptionSetProvider):
2431         (WTFOptionSetProvider._get_child_at_index): Added. Return the value for m_storage if it
2432         matches the specified index.
2433
2434 2019-08-21  Alex Christensen  <achristensen@webkit.org>
2435
2436         Disabling text autosizing should prevent text autosizing
2437         https://bugs.webkit.org/show_bug.cgi?id=200955
2438         <rdar://problem/48095374>
2439
2440         Reviewed by Simon Fraser.
2441
2442         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2443         * TestWebKitAPI/Tests/WebKitCocoa/TextSize.mm: Added.
2444         (TEST):
2445
2446 2019-08-21  Adrian Perez de Castro  <aperez@igalia.com>
2447
2448         [GTK][WPE] Make debug-test-runner work
2449         https://bugs.webkit.org/show_bug.cgi?id=193576
2450
2451         Reviewed by Michael Catanzaro.
2452
2453         * Scripts/webkitdirs.pm:
2454         (wrapperPrefixIfNeeded): Only add the wrapper prefix when not running inside a Flatpak sandbox.
2455         (setupUnixWebKitEnvironment): Added, sets TEST_RUNNER_INJECTED_BUNDLE_FILENAME and
2456         TEST_RUNNER_TEST_PLUGIN_PATH in the environment.
2457         (execUnixAppForDebugging): Added.
2458         (debugWebKitTestRunner): Alternatively, use execUnixAppForDebugging() for the WPE and GTK+ ports.
2459
2460 2019-08-20  Ryosuke Niwa  <rniwa@webkit.org>
2461
2462         Put keygen element behind a runtime flag and disable it by default
2463         https://bugs.webkit.org/show_bug.cgi?id=200850
2464
2465         Reviewed by Antti Koivisto.
2466
2467         Added the support for enableKeygenElement test runner option, which enables keygen element in layout tests.
2468
2469         * DumpRenderTree/TestOptions.cpp:
2470         (TestOptions::TestOptions):
2471         * DumpRenderTree/TestOptions.h:
2472         * DumpRenderTree/mac/DumpRenderTree.mm:
2473         (setWebPreferencesForTestOptions):
2474         * DumpRenderTree/win/DumpRenderTree.cpp:
2475         (setWebPreferencesForTestOptions):
2476         * WebKitTestRunner/TestController.cpp:
2477         (WTR::TestController::resetPreferencesToConsistentValues):
2478         (WTR::updateTestOptionsFromTestHeader):
2479         * WebKitTestRunner/TestOptions.h:
2480         (WTR::TestOptions::hasSameInitializationOptions const):
2481
2482 2019-08-21  Chris Dumez  <cdumez@apple.com>
2483
2484         Add internal setting to disable SecureContext checks
2485         https://bugs.webkit.org/show_bug.cgi?id=200980
2486         <rdar://problem/54438512>
2487
2488         Reviewed by Alex Christensen.
2489
2490         Add API test coverage.
2491
2492         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm:
2493         (log):
2494         (requestPermission):
2495
2496 2019-08-21  Keith Rollin  <krollin@apple.com>
2497
2498         Remove support for watchOS < 6.0
2499         https://bugs.webkit.org/show_bug.cgi?id=200937
2500         <rdar://problem/54524009>
2501
2502         Reviewed by Darin Adler.
2503
2504         Update conditionals that reference __WATCH_OS_VERSION_MIN_REQUIRED and
2505         __WATCH_OS_VERSION_MAX_ALLOWED, assuming that they both have values >=
2506         60000. This means that expressions like
2507         "__WATCH_OS_VERSION_MIN_REQUIRED < 60000" are always False and
2508         "__WATCH_OS_VERSION_MIN_REQUIRED >= 60000" are always True.
2509
2510         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm:
2511         (TestWebKitAPI::TEST):
2512
2513 2019-08-20  Zhifei Fang  <zhifei_fang@apple.com>
2514
2515         [results.webkit.org Webkit.css] Add right sidebar
2516         https://bugs.webkit.org/show_bug.cgi?id=200946
2517
2518         Reviewed by Jonathan Bedard.
2519
2520         * resultsdbpy/resultsdbpy/view/static/library/css/webkit.css:
2521         (@media screen and (min-width: 600px) and (orientation: landscape)):
2522         (.main.left):
2523         (@media screen and (min-width: 768px) and (orientation: landscape)):
2524         (.sidebar.right):
2525
2526 2019-08-20  Jonathan Bedard  <jbedard@apple.com>
2527
2528         results.webkit.org: Add ToolTips
2529         https://bugs.webkit.org/show_bug.cgi?id=200801
2530
2531         Rubber-stamped by Aakash Jain.
2532
2533         When dots or scale labels are hovered over, we should display a tool tip with additional information about
2534         The specific element.
2535
2536         * resultsdbpy/resultsdbpy/view/static/css/tooltip.css: Added.
2537         (.tooltip): Add class for ToolTip text box.
2538         (.tooltip-arrow-up): Add class for ToolTip arrow pointing up.
2539         (.tooltip-arrow-down): Add class for ToolTip arrow pointing down.
2540         * resultsdbpy/resultsdbpy/view/static/js/commit.js:
2541         (_CommitBank.prototype.commitsDuringUuid): Return a list of commits which were the trunk of their respective
2542         repositories at a given time.
2543         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
2544         (xAxisFromScale): Add callbacks triggered when the mouse enters or leaves elements in the scale canvas.
2545         (TimelineFromEndpoint.render): Add callbacks triggered when the mouse enters or leaves dot elements.
2546         * resultsdbpy/resultsdbpy/view/static/js/tooltip.js: Added.
2547         (isPointInElement): Given an element and a point, return true if that point is within the bounds of the element.
2548         (_ToolTip):
2549         (_ToolTip.prototype.set): Set the content and location of the ToolTip.
2550         (_ToolTip.prototype.toString): Return the html needed to render the ToolTip.
2551         (_ToolTip.prototype.unset): Clear and hide the ToolTip.
2552         (_ToolTip.prototype.isIn): Check if a given point is contained within the ToolTip.
2553         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
2554         (Timeline.CanvasSeriesComponent): Convert onHover events to onEnter/onLeave events. Add toolTips points to both
2555         dot and scale elements.
2556         * resultsdbpy/resultsdbpy/view/templates/search.html: Add ToolTip.
2557         * resultsdbpy/resultsdbpy/view/templates/suite_results.html: Ditto.
2558
2559 2019-08-20  Justin Michaud  <justin_michaud@apple.com>
2560
2561         Fix InBounds speculation of typed array PutByVal and add extra step to integer range optimization to search for equality relationships on the RHS value
2562         https://bugs.webkit.org/show_bug.cgi?id=200782
2563
2564         Reviewed by Saam Barati.
2565
2566         * Scripts/run-jsc-stress-tests:
2567
2568 2019-08-20  Darin Adler  <darin@apple.com>
2569
2570         Variadic StringBuilder::append does not handle upconverting from 8-bit to 16-bit correctly
2571         https://bugs.webkit.org/show_bug.cgi?id=200921
2572
2573         Reviewed by Saam Barati.
2574
2575         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
2576         Changed tests to use EXPECT macros instead of ASSERT macros since we don't
2577         need to abort after the first failure. Added three new tests to the VariadicAppend
2578         test to cover various cases of upconverting from 8-bit to 16-bit strings.
2579
2580 2019-08-20  Dean Jackson  <dino@apple.com>
2581
2582         REGRESSION: Open in New Tab is missing from context menu
2583         https://bugs.webkit.org/show_bug.cgi?id=200909
2584         <rdar://problem/54476169>
2585
2586         Reviewed by Simon Fraser.
2587
2588         Add a new test that runs through the legacy context menu
2589         flow, and verifies that it will be called if there aren't
2590         appropriate delegates for the new API.
2591
2592         * TestWebKitAPI/Tests/WebKitCocoa/ContextMenus.mm:
2593         (contextMenuWebViewDriver):
2594         (-[TestContextMenuUIDelegate webView:contextMenuConfigurationForElement:completionHandler:]):
2595         (TEST):
2596         (-[LegacyPreviewViewController previewActionItems]):
2597         (-[LegacyContextMenuUIDelegate webView:shouldPreviewElement:]):
2598         (-[LegacyContextMenuUIDelegate webView:previewingViewControllerForElement:defaultActions:]):
2599         (-[LegacyContextMenuUIDelegate webView:contextMenuWillPresentForElement:]):
2600         (-[LegacyContextMenuUIDelegate _webView:contextMenuDidEndForElement:]):
2601         * TestWebKitAPI/cocoa/TestContextMenuDriver.h:
2602
2603 2019-08-19  Yusuke Suzuki  <ysuzuki@apple.com>
2604
2605         [JSC] OSR entry to Wasm OMG
2606         https://bugs.webkit.org/show_bug.cgi?id=200362
2607
2608         Reviewed by Michael Saboff.
2609
2610         * Scripts/run-jsc-stress-tests:
2611
2612 2019-08-19  Zhifei Fang  <zhifei_fang@apple.com>
2613
2614         [results.webkit.org Timeline] Disable back gesture
2615         https://bugs.webkit.org/show_bug.cgi?id=200839
2616
2617         Reviewed by Jonathan Bedard.
2618
2619         * resultsdbpy/resultsdbpy/view/static/library/js/Utils.js:
2620         * resultsdbpy/resultsdbpy/view/templates/base.html:
2621
2622 2019-08-19  Jonathan Bedard  <jbedard@apple.com>
2623
2624         results-webkit.org: Add timeout to Redis locks
2625         https://bugs.webkit.org/show_bug.cgi?id=200890
2626
2627         Reviewed by Aakash Jain.
2628
2629         * resultsdbpy/resultsdbpy/model/upload_context.py:
2630         (UploadContext._find_job_with_attempts): Add timeout to Redis lock.
2631
2632 2019-08-19  Sihui Liu  <sihui_liu@apple.com>
2633
2634         Remove IDB-specific quota
2635         https://bugs.webkit.org/show_bug.cgi?id=196545
2636         <rdar://problem/54201783>
2637
2638         Reviewed by Youenn Fablet.
2639
2640         * DumpRenderTree/TestRunner.cpp:
2641         (TestRunner::staticFunctions):
2642         (setIDBPerOriginQuotaCallback): Deleted.
2643         * DumpRenderTree/TestRunner.h:
2644         * DumpRenderTree/mac/DumpRenderTree.mm:
2645         (runTest):
2646         * DumpRenderTree/mac/TestRunnerMac.mm:
2647         (TestRunner::setIDBPerOriginQuota): Deleted.
2648         * DumpRenderTree/win/TestRunnerWin.cpp:
2649         (TestRunner::setIDBPerOriginQuota): Deleted.
2650         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2651         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2652         (WTR::TestRunner::setIDBPerOriginQuota): Deleted.
2653         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2654         * WebKitTestRunner/TestController.cpp:
2655         (WTR::TestController::resetStateToConsistentValues):
2656         (WTR::TestController::setIDBPerOriginQuota): Deleted.
2657         * WebKitTestRunner/TestController.h:
2658         * WebKitTestRunner/TestInvocation.cpp:
2659         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2660
2661 2019-08-19  Yusuke Suzuki  <ysuzuki@apple.com>
2662
2663         [WTF] Style checker should tell errors when it finds std::make_unique
2664         https://bugs.webkit.org/show_bug.cgi?id=200878
2665
2666         Reviewed by Ross Kirsling.
2667
2668         * Scripts/webkitpy/style/checkers/cpp.py:
2669         (check_wtf_make_unique):
2670         (check_style):
2671         (CppChecker):
2672
2673 2019-08-18  Yusuke Suzuki  <ysuzuki@apple.com>
2674
2675         [WTF] Add makeUnique<T>, which ensures T is fast-allocated, makeUnique / makeUniqueWithoutFastMallocCheck part
2676         https://bugs.webkit.org/show_bug.cgi?id=200620
2677
2678         Reviewed by Geoffrey Garen.
2679
2680         * DumpRenderTree/TestRunner.cpp:
2681         (addURLToRedirectCallback):
2682         (setWillSendRequestClearHeaderCallback):
2683         (TestRunner::setAccummulateLogsForChannel):
2684         (TestRunner::runUIScript):
2685         (TestRunner::setOpenPanelFiles):
2686         * DumpRenderTree/mac/DumpRenderTree.mm:
2687         (dumpFramesAsText):
2688         * DumpRenderTree/mac/EventSendingController.mm:
2689         (eventPressedMouseButtonsSwizzlerForViewAndEvent):
2690         * DumpRenderTree/win/DRTDataObject.cpp:
2691         (DRTDataObject::SetData):
2692         * DumpRenderTree/win/FrameLoadDelegate.cpp:
2693         (FrameLoadDelegate::FrameLoadDelegate):
2694         * DumpRenderTree/win/UIDelegate.cpp:
2695         (DRTUndoManager::DRTUndoManager):
2696         (UIDelegate::UIDelegate):
2697         (UIDelegate::resetUndoManager):
2698         * TestWebKitAPI/JavaScriptTest.cpp:
2699         (TestWebKitAPI::runJSTest):
2700         * TestWebKitAPI/PlatformUtilities.cpp:
2701         (TestWebKitAPI::Util::toSTD):
2702         * TestWebKitAPI/Tests/WTF/Expected.cpp:
2703         (TestWebKitAPI::TEST):
2704         * TestWebKitAPI/Tests/WTF/HashCountedSet.cpp:
2705         (TestWebKitAPI::TEST):
2706         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
2707         (TestWebKitAPI::TEST):
2708         (TestWebKitAPI::testMovingUsingEnsure):
2709         (TestWebKitAPI::testMovingUsingAdd):
2710         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
2711         (TestWebKitAPI::TEST):
2712         * TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
2713         (TestWebKitAPI::TEST):
2714         * TestWebKitAPI/Tests/WTF/Lock.cpp:
2715         (TestWebKitAPI::runLockTest):
2716         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
2717         * TestWebKitAPI/Tests/WTF/RefCounter.cpp:
2718         (TestWebKitAPI::TEST):
2719         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp:
2720         (TestWebKitAPI::TEST):
2721         * TestWebKitAPI/Tests/WTF/Variant.cpp:
2722         (TestWebKitAPI::TEST):
2723         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
2724         (TestWebKitAPI::TEST):
2725         * TestWebKitAPI/Tests/WebCore/CARingBuffer.cpp:
2726         (TestWebKitAPI::CARingBufferTest::SetUp):
2727         * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp:
2728         (TestWebKitAPI::createTestValue):
2729         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
2730         (TestWebKitAPI::TEST):
2731         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
2732         (TestWebKitAPI::TEST_F):
2733         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
2734         * TestWebKitAPI/Tests/WebKit/CloseFromWithinCreatePage.cpp:
2735         (TestWebKitAPI::createNewPage):
2736         * TestWebKitAPI/Tests/WebKit/ModalAlertsSPI.cpp:
2737         (TestWebKitAPI::createNewPage):
2738         * TestWebKitAPI/Tests/WebKit/TextFieldDidBeginAndEndEditing.cpp:
2739         * TestWebKitAPI/Tests/WebKit/UserMessage.cpp:
2740         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::SetUp):
2741         * TestWebKitAPI/Tests/WebKit/WillLoad.cpp:
2742         (TestWebKitAPI::WebKit2WillLoadTest::SetUp):
2743         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle_Bundle.mm:
2744         (TestWebKitAPI::ForceLightAppearanceInBundleTest::didReceiveMessage):
2745         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp:
2746         (serverCallback):
2747         (testWebViewAuthenticationProxyHTTPS):
2748         * TestWebKitAPI/Tests/WebKitGtk/DOMDOMWindowTest.cpp:
2749         (WebKitDOMDOMWindowTest::create):
2750         * TestWebKitAPI/cocoa/PlatformUtilitiesCocoa.mm:
2751         (TestWebKitAPI::Util::toSTD):
2752         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2753         (applyWorkaroundToAllowWritingAttributedStringsToItemProviders):
2754         (-[TestWKWebView initWithFrame:configuration:addToWindow:]):
2755         * TestWebKitAPI/mac/TestFontOptions.mm:
2756         (-[TestFontOptions initWithFontOptions:]):
2757         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2758         (WTR::EventSendingController::callAfterScrollingCompletes):
2759         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2760         (WTR::InjectedBundle::didCreatePage):
2761         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2762         (WTR::TestRunner::setOpenPanelFiles):
2763         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2764         * WebKitTestRunner/StringFunctions.h:
2765         (WTR::toSTD):
2766         (WTR::toWTFString):
2767         * WebKitTestRunner/TestController.cpp:
2768         (WTR::TestController::initialize):
2769         (WTR::TestController::generatePageConfiguration):
2770         (WTR::TestController::resetStateToConsistentValues):
2771         (WTR::createTestURL):
2772         (WTR::TestController::runTest):
2773         (WTR::TestController::platformCreateWebView):
2774         * WebKitTestRunner/TestInvocation.cpp:
2775         (WTR::TestInvocation::runUISideScript):
2776         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2777         (WTR::TestController::platformCreateWebView):
2778         (WTR::TestController::setDefaultCalendarType):
2779         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
2780         (WTR::getGDKKeySymForKeyRef):
2781         * WebKitTestRunner/ios/TestControllerIOS.mm:
2782         (WTR::TestController::platformResetStateToConsistentValues):
2783         (WTR::TestController::setKeyboardInputModeIdentifier):
2784         * WebKitTestRunner/mac/EventSenderProxy.mm:
2785         (WTR::EventSenderProxy::mouseDown):
2786         (WTR::EventSenderProxy::mouseUp):
2787         (WTR::EventSenderProxy::mouseMoveTo):
2788         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
2789         (WTR::wpeKeySymForKeyRef):
2790
2791 2019-08-17  Ross Kirsling  <ross.kirsling@sony.com>
2792
2793         [ESNext] Implement optional chaining
2794         https://bugs.webkit.org/show_bug.cgi?id=200199
2795
2796         Reviewed by Yusuke Suzuki.
2797
2798         * Scripts/run-jsc-stress-tests:
2799
2800 2019-08-17  Tim Horton  <timothy_horton@apple.com>
2801
2802         Layout tests that call resizeTo() crash when run on iOS with IOSurface support enabled
2803         https://bugs.webkit.org/show_bug.cgi?id=200866
2804         <rdar://problem/50254021>
2805
2806         Reviewed by Simon Fraser.
2807
2808         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2809         (WTR::PlatformWebView::windowSnapshotImage):
2810         Replace some logging with release assertions that we are snapshotting a reasonable
2811         view and get a reasonable snapshot back. Failing to snapshot is a big deal, and
2812         "silently" failing with just a log that will be ignored is not helpful.
2813
2814 2019-08-17  Yusuke Suzuki  <ysuzuki@apple.com>
2815
2816         [WTF] ThreadGroupRemove test is flaky
2817         https://bugs.webkit.org/show_bug.cgi?id=200763
2818
2819         Reviewed by Mark Lam.
2820
2821         ThreadGroup.ThreadGroupRemove test is flaky since its `threadRunning` modification and check in Thread are racy.
2822         It can lead to infinite wait on waitForCompletion. We should do more idiomatic to avoid race: When notifying condition
2823         variables, we should first take a lock, modify the condition shared and notify the condition change while taking a lock,
2824         and releasing the lock after that.
2825
2826         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp:
2827         (TestWebKitAPI::TEST):
2828
2829 2019-08-17  Eric Liang  <ericliang@apple.com>
2830
2831         Tested that accessibility WebProcessLoader bundle is loaded for the correct path.
2832         https://bugs.webkit.org/show_bug.cgi?id=200367
2833
2834         Reviewed by Darin Adler.
2835
2836         Added AccessibilityTestPlugin on the web process to report whether a bundle is loaded and its path, so that it can be tested on WKContentView. 
2837
2838         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2839         * TestWebKitAPI/Tests/WebKitCocoa/AccessibilityTestPlugin.mm: Added.
2840         (-[AccessibilityTestPlugin webProcessPlugIn:didCreateBrowserContextController:]):
2841         (-[AccessibilityTestPlugin checkAccessibilityWebProcessLoaderBundleIsLoaded:]):
2842         * TestWebKitAPI/Tests/WebKitCocoa/AccessibilityTestSupportProtocol.h: Added.
2843         * TestWebKitAPI/Tests/ios/AccessibilityTestsIOS.mm:
2844         (TestWebKitAPI::TEST):
2845
2846 2019-08-17  Sam Weinig  <weinig@apple.com>
2847
2848         Rename StringBuilder::flexibleAppend(...) to StringBuilder::append(...)
2849         https://bugs.webkit.org/show_bug.cgi?id=200756
2850
2851         Reviewed by Darin Adler.
2852
2853         Update call sites for rename from StringBuilder::flexibleAppend(...) to 
2854         StringBuilder::append(...).
2855
2856         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
2857         (TestWebKitAPI::TEST):
2858
2859 2019-08-17  Simon Fraser  <simon.fraser@apple.com>
2860
2861         [iOS WK2] Scroll indicators disappear sometimes
2862         https://bugs.webkit.org/show_bug.cgi?id=200791
2863
2864         Reviewed by Tim Horton.
2865
2866         Tests that test that scroll indicators survive subview replacement, and that
2867         a custom view also survives subview replacement.
2868
2869         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2870         * TestWebKitAPI/Tests/ios/OverflowScrollViewTests.mm: Added.
2871         (TestWebKitAPI::TEST):
2872         * TestWebKitAPI/cocoa/TestWKWebView.h:
2873         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2874         (-[TestWKWebView performAfterLoading:]):
2875         (-[UIView wkFirstSubviewWithClass:]):
2876         (-[UIView wkFirstSubviewWithBoundsSize:]):
2877         * TestWebKitAPI/ios/composited.html: Added.
2878         * TestWebKitAPI/ios/overflow-scroll.html: Added.
2879
2880 2019-08-16  John Wilander  <wilander@apple.com>
2881
2882         Add John Wilander as WebKit Reviewer
2883         https://bugs.webkit.org/show_bug.cgi?id=200837
2884
2885         Unreviewed update to contributors.json to change my status to reviewer.
2886         See email on reviewers mailing list for proof of granted privileges.
2887
2888         * Scripts/webkitpy/common/config/contributors.json:
2889
2890 2019-08-16  Timothy Hatcher  <timothy@apple.com>
2891
2892         REGRESSION (r248436): WKWebView doesn’t respect isOpaque setting in NIB.
2893         https://bugs.webkit.org/show_bug.cgi?id=200802
2894         rdar://problem/54357818
2895
2896         Reviewed by Tim Horton.
2897
2898         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added WKWebViewOpaque.mm.
2899         * TestWebKitAPI/Tests/ios/WKWebViewOpaque.mm: Added.
2900         (-[OpaqueTestWKWebView isOpaque]): Added.
2901         (-[NonOpaqueTestWKWebView isOpaque]): Added.
2902         (isOpaque): Added.
2903         (TEST): Added WKWebView.IsOpaqueDefault, WKWebView.SetOpaqueYes, WKWebView.SetOpaqueNo, WKWebView.IsOpaqueYesSubclassOverridden,
2904         WKWebView.IsOpaqueNoSubclassOverridden, WKWebView.IsOpaqueYesDecodedFromArchive, WKWebView.IsOpaqueNoDecodedFromArchive,
2905         WKWebView.IsOpaqueDrawsBackgroundYesConfiguration, WKWebView.IsOpaqueDrawsBackgroundNoConfiguration.
2906
2907 2019-08-16  Aakash Jain  <aakash_jain@apple.com>
2908
2909         [ews] Add build steps for Windows Factory
2910         https://bugs.webkit.org/show_bug.cgi?id=200813
2911
2912         Reviewed by Jonathan Bedard.
2913
2914         * BuildSlaveSupport/ews-build/factories.py:
2915         (WindowsFactory.__init__):
2916
2917 2019-08-16  Aakash Jain  <aakash_jain@apple.com>
2918
2919         [ews] Report machine uptime in PrintConfiguration
2920         https://bugs.webkit.org/show_bug.cgi?id=200812
2921
2922         Reviewed by Jonathan Bedard.
2923
2924         * BuildSlaveSupport/ews-build/steps.py:
2925         (PrintConfiguration): Added uptime command.
2926         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.
2927
2928 2019-08-16  Chris Lord  <clord@igalia.com>
2929
2930         Add shared-mime-info to WPE WebKit jhbuild
2931         https://bugs.webkit.org/show_bug.cgi?id=200768
2932
2933         Reviewed by Carlos Alberto Lopez Perez.
2934
2935         * wpe/jhbuild.modules:
2936
2937 2019-08-15  Yusuke Suzuki  <ysuzuki@apple.com>
2938
2939         [WTF] Add makeUnique<T>, which ensures T is fast-allocated, WTF_MAKE_FAST_ALLOCATED annotation part
2940         https://bugs.webkit.org/show_bug.cgi?id=200620
2941
2942         Reviewed by Geoffrey Garen.
2943
2944         * DumpRenderTree/AccessibilityController.h:
2945         * DumpRenderTree/GCController.h:
2946         * DumpRenderTree/win/DRTDataObject.cpp:
2947         * DumpRenderTree/win/DRTDataObject.h:
2948         * DumpRenderTree/win/DRTDesktopNotificationPresenter.h:
2949         * DumpRenderTree/win/DRTDropSource.h:
2950         * DumpRenderTree/win/DraggingInfo.h:
2951         * DumpRenderTree/win/EditingDelegate.h:
2952         * DumpRenderTree/win/EventSender.cpp:
2953         * DumpRenderTree/win/FrameLoadDelegate.h:
2954         * DumpRenderTree/win/HistoryDelegate.h:
2955         * DumpRenderTree/win/MD5.h:
2956         * DumpRenderTree/win/PolicyDelegate.h:
2957         * DumpRenderTree/win/ResourceLoadDelegate.h:
2958         * DumpRenderTree/win/TextInputController.h:
2959         * DumpRenderTree/win/UIDelegate.cpp:
2960         * DumpRenderTree/win/UIDelegate.h:
2961         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
2962         * TestRunnerShared/cocoa/ClassMethodSwizzler.h:
2963         * TestRunnerShared/cocoa/InstanceMethodSwizzler.h:
2964         * TestWebKitAPI/Counters.h:
2965         * TestWebKitAPI/PlatformWebView.h:
2966         * TestWebKitAPI/Tests/WTF/Expected.cpp:
2967         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
2968         (TestWebKitAPI::DerefObserver::ref):
2969         (TestWebKitAPI::DerefObserver::deref):
2970         (TestWebKitAPI::TEST):
2971         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
2972         (TestWebKitAPI::DerefObserver::ref):
2973         (TestWebKitAPI::DerefObserver::deref):
2974         (TestWebKitAPI::TEST):
2975         * TestWebKitAPI/Tests/WTF/UniqueRef.cpp:
2976         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
2977         * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp:
2978         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp:
2979         * TestWebKitAPI/Tests/WebKitGLib/WebProcessTest.h:
2980         * TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.h:
2981         * WebKitTestRunner/EventSenderProxy.h:
2982         * WebKitTestRunner/GeolocationProviderMock.h:
2983         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
2984         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2985         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2986         * WebKitTestRunner/PlatformWebView.h:
2987         * WebKitTestRunner/TestInvocation.h:
2988
2989 2019-08-15  Sihui Liu  <sihui_liu@apple.com>
2990
2991         Some improvements on web storage
2992         https://bugs.webkit.org/show_bug.cgi?id=200373
2993
2994         Reviewed by Geoffrey Garen.
2995
2996         * TestWebKitAPI/Tests/WebKitCocoa/LocalStoragePersistence.mm:
2997         (TEST): update expectation for behavior change.
2998
2999         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: new SPI to synchronously flush localStorage to 
3000         database file.
3001         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3002         (WTR::TestRunner::syncLocalStorage):
3003         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3004
3005         * WebKitTestRunner/TestController.cpp: clear local storage between test runs to make each test isolated.
3006         (WTR::TestController::resetStateToConsistentValues):
3007         (WTR::StorageVoidCallbackContext::StorageVoidCallbackContext):
3008         (WTR::StorageVoidCallback):
3009         (WTR::TestController::clearIndexedDatabases):
3010         (WTR::TestController::clearLocalStorage):
3011         (WTR::TestController::syncLocalStorage):
3012         (WTR::RemoveAllIndexedDatabasesCallbackContext::RemoveAllIndexedDatabasesCallbackContext): Deleted. Replaced
3013         with StorageVoidCallbackContext for general usage.
3014         (WTR::RemoveAllIndexedDatabasesCallback): Deleted. Replaced with StorageVoidCallback.
3015         (WTR::TestController::ClearIndexedDatabases): Deleted. Use lowercase for consistent style.
3016         * WebKitTestRunner/TestController.h:
3017
3018         * WebKitTestRunner/TestInvocation.cpp:
3019         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle): add handler for new message 
3020         SyncLocalStorage.
3021
3022 2019-08-15  Jonathan Bedard  <jbedard@apple.com>
3023
3024         results.webkit.org: Add content hook to FlaskRequestsResponse
3025         https://bugs.webkit.org/show_bug.cgi?id=200721
3026
3027         Rubber-stamped by Aakash Jain.
3028
3029         * resultsdbpy/resultsdbpy/flask_support/flask_testcase.py:
3030         (FlaskRequestsResponse):
3031         (FlaskRequestsResponse.content): Return the encoded raw bytes value of the
3032         Response, conforming to request's API.
3033
3034 2019-08-15  Alex Christensen  <achristensen@webkit.org>
3035
3036         WKUIDelegate's webView:contextMenuDidEndForElement: should be called when context menus end
3037         https://bugs.webkit.org/show_bug.cgi?id=200750
3038         <rdar://problem/54232261> and <rdar://problem/52355829>
3039
3040         Reviewed by Tim Horton.
3041
3042         * TestWebKitAPI/Tests/WebKitCocoa/ContextMenus.mm:
3043         (-[TestContextMenuUIDelegate webView:contextMenuConfigurationForElement:completionHandler:]):
3044         (-[TestContextMenuUIDelegate webView:contextMenuForElement:willCommitWithAnimator:]):
3045         (-[TestContextMenuUIDelegate webView:contextMenuDidEndForElement:]):
3046         (contextMenuWebViewDriver):
3047         (TEST):
3048
3049 2019-08-14  Said Abou-Hallawa  <sabouhallawa@apple.com>
3050
3051         [iOS](REGRESSION: r200487): WebKit.RequestActivatedElementInfoForRotatedImage fails on iOS 13
3052         https://bugs.webkit.org/show_bug.cgi?id=200726
3053
3054         Reviewed by Simon Fraser.
3055
3056         To get the pixels as an array of colors, draw the image into a memory
3057         context. The backing memory buffer can then be accessed to get the image
3058         pixels' colors.
3059
3060         * TestWebKitAPI/Tests/WebKitCocoa/WKRequestActivatedElementInfo.mm:
3061         (TestWebKitAPI::TEST):
3062
3063 2019-08-14  Ryan Haddad  <ryanhaddad@apple.com>
3064
3065         Unreviewed, rolling out r248526.
3066
3067         Caused two IndexedDB perf tests to fail
3068
3069         Reverted changeset:
3070
3071         "Remove IDB-specific quota"
3072         https://bugs.webkit.org/show_bug.cgi?id=196545
3073         https://trac.webkit.org/changeset/248526
3074
3075 2019-08-14  Keith Rollin  <krollin@apple.com>
3076
3077         Remove support for macOS < 10.13
3078         https://bugs.webkit.org/show_bug.cgi?id=200694
3079         <rdar://problem/54278851>
3080
3081         Reviewed by Youenn Fablet.
3082
3083         Update conditionals that reference __MAC_OS_X_VERSION_MIN_REQUIRED and
3084         __MAC_OS_X_VERSION_MAX_ALLOWED, assuming that they both have values >=
3085         101300. This means that expressions like
3086         "__MAC_OS_X_VERSION_MIN_REQUIRED < 101300" are always False and
3087         "__MAC_OS_X_VERSION_MIN_REQUIRED >= 101300" are always True.
3088
3089         * MiniBrowser/AppKitCompatibilityDeclarations.h:
3090         * MiniBrowser/mac/SettingsController.m:
3091         (-[SettingsController init]):
3092         * TestWebKitAPI/Tests/WebCore/FontCache.cpp:
3093         (TestWebKitAPI::FontCacheTest::SetUp): Deleted.
3094         (TestWebKitAPI::createPlatformFont): Deleted.
3095         (TestWebKitAPI::compareFonts): Deleted.
3096         (TestWebKitAPI::TEST_F): Deleted.
3097         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm:
3098         (TestWebKitAPI::TEST):
3099         * TestWebKitAPI/Tests/WebKitCocoa/ExitFullscreenOnEnterPiP.mm:
3100         * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
3101         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3102         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3103         (runWebsiteDataStoreCustomPaths):
3104         * TestWebKitAPI/mac/NSFontPanelTesting.mm:
3105
3106 2019-08-14  Yusuke Suzuki  <ysuzuki@apple.com>
3107
3108         [JSC] Less contended MetaAllocator
3109         https://bugs.webkit.org/show_bug.cgi?id=200278
3110
3111         Reviewed by Mark Lam.
3112
3113         Update the interface.
3114
3115         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
3116
3117 2019-08-14  Jonathan Bedard  <jbedard@apple.com>
3118
3119         results.webkit.org: 500 errors on API endpoints don't return JSON
3120         https://bugs.webkit.org/show_bug.cgi?id=200722
3121
3122         Reviewed by Aakash Jain.
3123
3124         * resultsdbpy/resultsdbpy/controller/api_routes.py:
3125         (APIRoutes.response_500): We should return the response, instead of abort.
3126
3127 2019-08-14  Jonathan Bedard  <jbedard@apple.com>
3128
3129         results.webkit.org: Don't save configuration multiple times in upload
3130         https://bugs.webkit.org/show_bug.cgi?id=200719
3131
3132         Reviewed by Aakash Jain.
3133
3134         * resultsdbpy/resultsdbpy/model/upload_context.py:
3135         (UploadContext.upload_test_results): Move registering of the configuration out
3136         of the branch loop.
3137
3138 2019-08-14  Youenn Fablet  <youenn@apple.com>
3139
3140         Reenable Update ContentFiltering.LazilyLoadPlatformFrameworks test for NetworkExtension
3141         https://bugs.webkit.org/show_bug.cgi?id=200706
3142
3143         Reviewed by Alex Christensen.
3144
3145         Libwebrtc is now soft-linked so we can reenable this test.
3146
3147         * TestWebKitAPI/Tests/WebKitCocoa/ContentFiltering.mm:
3148         (-[LazilyLoadPlatformFrameworksController expectParentalControlsLoaded:networkExtensionLoaded:]):
3149
3150 2019-08-13  Sam Weinig  <weinig@apple.com>
3151
3152         Rename StringBuilder::append(UChar32) to StringBuilder::appendCharacter(UChar32) to avoid accidental change in behavior when replacing append with flexibleAppend
3153         https://bugs.webkit.org/show_bug.cgi?id=200675
3154
3155         Reviewed by Darin Adler.
3156
3157         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
3158         (TestWebKitAPI::TEST):
3159         Update for rename from StringBuilder::append(UChar32) to StringBuilder::appendCharacter(UChar32).
3160
3161 2019-08-13  Zhifei Fang  <zhifei_fang@apple.com>
3162
3163         [results.webkit.org Timeline] Performance improvement - Skip render offscreen canvas
3164         https://bugs.webkit.org/show_bug.cgi?id=200456
3165
3166         Reviewed by Jonathan Bedard.
3167
3168         This patch disable use the new batch draw method to render canvas directly without any caches, this will save a lot of memory, so that we won't go into the "low memory mode".
3169
3170         This patch also change the axis label collision detact box from a rect to polygon, so that we can dectact click more accurate.
3171
3172         * resultsdbpy/resultsdbpy/view/static/library/js/Utils.js:
3173         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
3174         (pointPolygonCollisionDetect): Detact
3175         (pointRightRayLineSegmentCollisionDetect):
3176         (ColorBatchRender):
3177         (ColorBatchRender.prototype.lazyCreateColorSeqs):
3178         (ColorBatchRender.prototype.addSeq):
3179         (ColorBatchRender.prototype.batchRender):
3180         (ColorBatchRender.prototype.clear):
3181         (xScrollStreamRenderFactory):
3182         (Timeline.CanvasSeriesComponent):
3183         (offscreenCachedRenderFactory): Deleted.
3184
3185 2019-08-13  John Wilander  <wilander@apple.com>
3186
3187         Resource Load Statistics: Switch NSURLSession on top navigation to prevalent resource with user interaction
3188         https://bugs.webkit.org/show_bug.cgi?id=200642
3189         <rdar://problem/53962073>
3190
3191         Reviewed by Alex Christensen.
3192
3193         This patch adds test infrastructure to query whether an origin has an
3194         isolated NSURLSession or not.
3195
3196         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3197         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3198         (WTR::TestRunner::hasStatisticsIsolatedSession):
3199         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3200         * WebKitTestRunner/TestController.cpp:
3201         (WTR::TestController::hasStatisticsIsolatedSession):
3202         * WebKitTestRunner/TestController.h:
3203         * WebKitTestRunner/TestInvocation.cpp:
3204         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3205
3206 2019-08-13  Zhifei Fang  <zhifei_fang@apple.com>
3207
3208         Update my status in contributors.json to committer.
3209
3210         Reviewed by Unreviewed
3211
3212         * Scripts/webkitpy/common/config/contributors.json:
3213
3214 2019-08-12  Jiewen Tan  <jiewen_tan@apple.com>
3215
3216         Adds WebAuthn and AppSSO into watchlist
3217         https://bugs.webkit.org/show_bug.cgi?id=200647
3218
3219         Reviewed by Dewei Zhu.
3220
3221         * Scripts/webkitpy/common/config/watchlist:
3222
3223 2019-08-13  Chris Dumez  <cdumez@apple.com>
3224
3225         Crash under IPC::Connection::markCurrentlyDispatchedMessageAsInvalid()
3226         https://bugs.webkit.org/show_bug.cgi?id=200674
3227         <rdar://problem/50692748>
3228
3229         Reviewed by Geoff Garen.
3230
3231         Add API test coverage.
3232
3233         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3234
3235 2019-08-12  Takashi Komori  <Takashi.Komori@sony.com>
3236
3237         [WTF] Thread::removeFromThreadGroup leaks weak pointers.
3238         https://bugs.webkit.org/show_bug.cgi?id=199857
3239
3240         Reviewed by Yusuke Suzuki.
3241
3242         * TestWebKitAPI/Tests/WTF/ThreadGroup.cpp:
3243         (TestWebKitAPI::countThreadGroups):
3244         (TestWebKitAPI::TEST):
3245
3246 2019-08-12  Alexey Shvayka  <shvaikalesh@gmail.com>
3247
3248         AX: Homebrew is not allowed to run any script under sudo.
3249         https://bugs.webkit.org/show_bug.cgi?id=173801
3250
3251         Reviewed by Carlos Alberto Lopez Perez.
3252
3253         Latest versions of Homebrew throw an error when run as root.
3254         Dependencies are successfully installed w/o `sudo` on macOS, so skip it.
3255
3256         * gtk/install-dependencies:
3257
3258 2019-08-12  Jonathan Bedard  <jbedard@apple.com>
3259
3260         [REGRESSION] run-webkit-tests: No PID defined when searching for simulator crashlogs
3261         https://bugs.webkit.org/show_bug.cgi?id=200644
3262
3263         Reviewed by Aakash Jain.
3264
3265         * Scripts/webkitpy/port/simulator_process.py:
3266         (SimulatorProcess._start): Define system PID after launching app.
3267
3268 2019-08-12  Sam Weinig  <weinig@apple.com>
3269
3270         Replace multiparameter overloads of append() in StringBuilder as a first step toward standardizinging on the flexibleAppend() implementation
3271         https://bugs.webkit.org/show_bug.cgi?id=200614
3272
3273         Reviewed by Darin Adler.
3274
3275         Renames StringBuilder::append(const LChar*, unsigned), StringBuilder::append(const UChar*, unsigned) and 
3276         StringBuilder::append(const char*, unsigned) to StringBuilder::appendCharacters(...).
3277         
3278         Renames StringBuilder::append(const String& string, unsigned offset, unsigned length) to 
3279         StringBuilder::appendSubstring(...).
3280
3281         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
3282         (TestWebKitAPI::TEST):
3283         Update for renames.
3284
3285 2019-08-12  Megan Gardner  <megan_gardner@apple.com>
3286
3287         Fix Crash in Mail Search
3288         https://bugs.webkit.org/show_bug.cgi?id=200589
3289
3290         Reviewed by Tim Horton.
3291
3292         If you search backwards first in mail, we would crash,
3293         this tests that codepath.
3294
3295         * TestWebKitAPI/Tests/WebKitCocoa/FindInPage.mm:
3296         (TEST):
3297
3298 2019-08-12  Wenson Hsieh  <wenson_hsieh@apple.com>
3299
3300         [iPadOS] Web pages sometimes load at half width in Safari
3301         https://bugs.webkit.org/show_bug.cgi?id=200624
3302         <rdar://problem/52694257>
3303
3304         Reviewed by Simon Fraser.
3305
3306         Add an API test to verify that after performing an animated resize and killing the web process, the subsequent
3307         web page is created using the post-animated-resize web view dimensions, rather than the original layout
3308         dimensions.
3309
3310         * TestWebKitAPI/Tests/WebKitCocoa/AnimatedResize.mm:
3311
3312 2019-08-12  Daniel Bates  <dabates@apple.com>
3313
3314         Add a test to ensure that we dispatch keydown and keyup events when multiple keys are pressed at the same time
3315         https://bugs.webkit.org/show_bug.cgi?id=200548
3316
3317         Reviewed by Darin Adler.
3318
3319         Expose infrastructure to simulate a literal raw key down and a literal key up event.
3320
3321         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3322         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3323         (WTR::UIScriptController::rawKeyDown):
3324         (WTR::UIScriptController::rawKeyUp):
3325         * WebKitTestRunner/ios/UIScriptControllerIOS.h:
3326         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3327         (WTR::UIScriptControllerIOS::rawKeyDown):
3328         (WTR::UIScriptControllerIOS::rawKeyUp):
3329
3330 2019-08-12  Thibault Saunier  <tsaunier@igalia.com>
3331
3332         [GStreamer][WebRTC] Handle broken data in the libwebrtc GStreamer decoders
3333         https://bugs.webkit.org/show_bug.cgi?id=200584
3334
3335         Reviewed by Philippe Normand.
3336
3337         Added a h264parse patch to post WARNING on the bus when a broken frame is detected.
3338         Ignore style libwebrtc optionnal 'style issue'
3339
3340         * Scripts/webkitpy/style/checker.py:
3341         * gstreamer/jhbuild.modules:
3342         * gstreamer/patches/gst-plugins-bad-0001-h264parse-Post-a-WARNING-when-data-is-broken.patch: Added.
3343
3344 2019-08-12  Youenn Fablet  <youenn@apple.com>
3345
3346         Remove IDB-specific quota
3347         https://bugs.webkit.org/show_bug.cgi?id=196545
3348
3349         Reviewed by Alex Christensen.
3350
3351         * DumpRenderTree/TestRunner.cpp:
3352         (TestRunner::staticFunctions):
3353         (setIDBPerOriginQuotaCallback): Deleted.
3354         * DumpRenderTree/TestRunner.h:
3355         * DumpRenderTree/mac/DumpRenderTree.mm:
3356         (runTest):
3357         * DumpRenderTree/mac/TestRunnerMac.mm:
3358         (TestRunner::setIDBPerOriginQuota): Deleted.
3359         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3360         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3361         (WTR::TestRunner::setIDBPerOriginQuota): Deleted.
3362         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3363         * WebKitTestRunner/TestController.cpp:
3364         (WTR::TestController::resetStateToConsistentValues):
3365         (WTR::TestController::setIDBPerOriginQuota): Deleted.
3366         * WebKitTestRunner/TestController.h:
3367         * WebKitTestRunner/TestInvocation.cpp:
3368         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3369
3370 2019-08-10  Alexey Proskuryakov  <ap@apple.com>
3371
3372         WebKitTestRunner's InjectedBundle has too aggressive stripping, resulting in non-symbolicated crash logs
3373         https://bugs.webkit.org/show_bug.cgi?id=200621
3374
3375         Reviewed by Dan Bernstein.
3376
3377         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
3378
3379 2019-08-09  Wenson Hsieh  <wenson_hsieh@apple.com>
3380
3381         KeyboardInputTests.CaretSelectionRectAfterRestoringFirstResponder API tests time out on iPad
3382         https://bugs.webkit.org/show_bug.cgi?id=200604
3383         <rdar://problem/51273130>
3384
3385         Reviewed by Megan Gardner.
3386
3387         Tweak some API tests so that they work on iPad simulator. These tests checked that the final caret rect was
3388         {{16, 13}, {2, 15}}; however, this is only correct behavior on iPhone, where we will scale the page so that the
3389         focused element's font size is legible. Note that when the page is scaled, we scale the height but not the
3390         width of the caret, which is why the width of the caret (in content coordinates) decreases while the height
3391         remains the same.
3392
3393         We don't have the same behavior on iPad, so the expected caret rect is {{16, 13}, {3, 15}}, which is equal to
3394         the caret rect at initial scale 1.
3395
3396         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
3397
3398 2019-08-09  Ali Juma  <ajuma@chromium.org>
3399
3400         Don't allow cross-origin iframes to autofocus
3401         https://bugs.webkit.org/show_bug.cgi?id=200515
3402         <rdar://problem/54092988>
3403
3404         Reviewed by Ryosuke Niwa.
3405
3406         Make WebKit.FocusedFrameAfterCrash use same-origin iframes instead
3407         of cross-origin iframes, since it depends on focusing one of the
3408         frames.
3409
3410         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3411         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
3412         (TestWebKitAPI::TEST):
3413         * TestWebKitAPI/Tests/WebKit/many-same-origin-iframes.html: Added.
3414
3415 2019-08-09  Wenson Hsieh  <wenson_hsieh@apple.com>
3416
3417         [iOS 13] Google Docs/Slides/Sheets: paste often doesn't work and sometimes produces an error
3418         https://bugs.webkit.org/show_bug.cgi?id=200591
3419         <rdar://problem/54102238>
3420
3421         Reviewed by Ryosuke Niwa and Tim Horton.
3422
3423         Add a new API test to exercise -supportsImagePaste.
3424
3425         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
3426         (TestWebKitAPI::TEST):
3427         * TestWebKitAPI/ios/UIKitSPI.h:
3428
3429 2019-08-09  Aakash Jain  <aakash_jain@apple.com>
3430
3431         Follow-up commit to r248474 as webkit-patch did not commit the svn property changes.
3432         [ews-build] Set svn:ignore to various EWS Buildbot files
3433         https://bugs.webkit.org/show_bug.cgi?id=200581
3434
3435         Reviewed by Jonathan Bedard.
3436
3437         * BuildSlaveSupport/ews-build: Added property svn:ignore.
3438
3439 2019-08-09  Aakash Jain  <aakash_jain@apple.com>
3440
3441         [ews-build] Set svn:ignore to various EWS Buildbot files
3442         https://bugs.webkit.org/show_bug.cgi?id=200581
3443
3444         Reviewed by Jonathan Bedard.
3445
3446         * BuildSlaveSupport/ews-build: Added property svn:ignore.
3447
3448 2019-08-09  Aakash Jain  <aakash_jain@apple.com>
3449
3450         [ews] Add buildbot.tac to repository
3451         https://bugs.webkit.org/show_bug.cgi?id=200580
3452
3453         Reviewed by Jonathan Bedard.
3454
3455         * BuildSlaveSupport/ews-build/buildbot.tac: Added.
3456
3457 2019-08-09  Claudio Saavedra  <csaavedra@igalia.com>
3458
3459         [GTK] Add missing spellchecking packages to dependencies script
3460         https://bugs.webkit.org/show_bug.cgi?id=200574
3461
3462         Reviewed by Philippe Normand.
3463
3464         These are needed for the spellchecking test in WebContext API tests.
3465
3466         * gtk/install-dependencies:
3467
3468 2019-08-08  Jon Lee  <jonlee@apple.com>
3469
3470         Unreviewed. Get rid of extraneous whitespace in ChangeLog.
3471
3472 2019-08-08  Jonathan Bedard  <jbedard@apple.com>
3473
3474         webkitpy: Disable shared clipboard between Simulators
3475         https://bugs.webkit.org/show_bug.cgi?id=200546
3476
3477         Reviewed by Aakash Jain.
3478
3479         * Scripts/webkitpy/xcode/simulated_device.py:
3480         (SimulatedDeviceManager.initialize_devices): Disable PasteboardAutomaticSync in Simulator.app
3481         managed by run-webkit-tests.
3482
3483 2019-08-08  Brent Fulgham  <bfulgham@apple.com>
3484
3485         [FTW] Get WebKit, WebKit2, and MiniBrowser building and executing
3486         https://bugs.webkit.org/show_bug.cgi?id=200539
3487         <rdar://problem/54082550>
3488
3489         Reviewed by Dean Jackson.
3490
3491         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
3492         * PlatformFTW.cmake: Added.
3493
3494 2019-08-08  Said Abou-Hallawa  <sabouhallawa@apple.com>
3495
3496         [iOS] Position image information should respect the image orientation
3497         https://bugs.webkit.org/show_bug.cgi?id=200487
3498
3499         Reviewed by Simon Fraser.
3500
3501         Add an API test to verify the position image information is drawn rotated
3502         because of respecting its image orientation.
3503
3504         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3505         * TestWebKitAPI/Tests/WebKitCocoa/WKRequestActivatedElementInfo.mm:
3506         (TestWebKitAPI::TEST):
3507         * TestWebKitAPI/Tests/WebKitCocoa/exif-orientation-8-llo.jpg: Added.
3508         * TestWebKitAPI/Tests/WebKitCocoa/img-with-rotated-image.html: Added.
3509
3510 2019-08-08  Claudio Saavedra  <csaavedra@igalia.com>
3511
3512         [GTK] Fix WebContext languages test
3513         https://bugs.webkit.org/show_bug.cgi?id=200538
3514
3515         Reviewed by Alex Christensen.
3516
3517         This test broke after the format of Accepted-Languages
3518         was changed in r238236, update.
3519
3520         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebContext.cpp:
3521         (testWebContextLanguages):
3522
3523 2019-08-08  Claudio Saavedra  <csaavedra@igalia.com>
3524
3525         [GTK] Fix /webkit/WebKitWebsiteData/databases failure
3526         https://bugs.webkit.org/show_bug.cgi?id=200536
3527
3528         Reviewed by Carlos Alberto Lopez Perez.
3529
3530         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
3531         (testWebsiteDataDatabases): Databases take a moment to be written,
3532         wait before fetching the data as it's done in other tests.
3533
3534 2019-08-08  Jonathan Bedard  <jbedard@apple.com>
3535
3536         results.webkit.org: Use canvas for timeline
3537         https://bugs.webkit.org/show_bug.cgi?id=200172
3538
3539         Rubber-stamped by Aakash Jain.
3540
3541         * resultsdbpy/resultsdbpy/view/static/js/commit.js:
3542         (Commit.constructor): Make uuid a member variable instead of a member function for efficiency.
3543         (Commit.compare): Ditto.
3544         (_CommitBank.commitByUuid): Ditto.
3545         (_CommitBank._loadSiblings): Ditto.
3546         (_CommitBank._load): Ditto.
3547         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
3548         (tickForCommit): Deleted.
3549         (minimumUuidForResults): Given a dictionary of result lists, determine the minimum UUID
3550         which encompasses all results. Crucially, this function must exclude an UUIDs which may
3551         refer to results excluded because of the limit argument.
3552         (renderTimeline): Deleted.
3553         (commitsForResults): Given a dictionary of result lists, return a list of commits associated
3554         with those results.
3555         (scaleForCommits): Given a list of commits, generate a scale to be consumed by the canvas Timeline.
3556         (repositoriesForCommits): Given a list of commits, return a sorted list of associated repository ids.
3557         (xAxisFromScale): Create a canvas-based x-axis based on the provided scale and a repository id.
3558         (inPlaceCombine): Combine result objects together.
3559         (statsForSingleResult): Turn a single result into a stat object.
3560         (combineResults): Given lists of results, combine these lists while keeping the original lists unchanged.
3561         (Dot): Deleted.
3562         (TimelineFromEndpoint): Renamed from Timeline.
3563         (TimelineFromEndpoint.constructor): Canvas Timeline manages expansion and collapsing of nested timelines.
3564         (TimelineFromEndpoint.teardown): Detach callbacks from CommitBank.
3565         (TimelineFromEndpoint.update): Update with any new commit information, force a re-draw of the current
3566         cache contents.
3567         (TimelineFromEndpoint.reload): Remove management of nested timelines.
3568         (TimelineFromEndpoint.render): Use canvas Timeline instead of html timeline to visualize results.
3569         * resultsdbpy/resultsdbpy/view/templates/search.html: Use TimelineFromEndpoint class.
3570         * resultsdbpy/resultsdbpy/view/templates/suite_results.html: Ditto.
3571
3572 2019-08-08  Brady Eidson  <beidson@apple.com>
3573
3574         Do not allow navigations of frames about to get replaced by the result of evaluating javascript: URLs
3575         <rdar://problem/53788893> and https://bugs.webkit.org/show_bug.cgi?id=198786
3576
3577         Reviewed by Geoff Garen.
3578
3579         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3580         * TestWebKitAPI/Tests/mac/JavascriptURLNavigation.mm: Added.
3581
3582 2019-08-08  Rob Buis  <rbuis@igalia.com>
3583
3584         Add runtime flag for lazy image loading
3585         https://bugs.webkit.org/show_bug.cgi?id=199794
3586
3587         Reviewed by Darin Adler.
3588
3589         Set lazyImageLoading preference as part of experimental features. Add
3590         TestOption for lazy image loading.
3591
3592         * DumpRenderTree/TestOptions.cpp:
3593         (TestOptions::TestOptions):
3594         * DumpRenderTree/TestOptions.h:
3595         * DumpRenderTree/mac/DumpRenderTree.mm:
3596         (enableExperimentalFeatures):
3597         (setWebPreferencesForTestOptions):
3598         * DumpRenderTree/win/DumpRenderTree.cpp:
3599         (enableExperimentalFeatures):
3600
3601 2019-08-08  Rob Buis  <rbuis@igalia.com>
3602
3603         Import lazy loading WPT tests
3604         https://bugs.webkit.org/show_bug.cgi?id=199795
3605
3606         Reviewed by Darin Adler.
3607
3608         Only do loading/ exception for WebKit specific, non WPT tests.
3609
3610         * DumpRenderTree/mac/DumpRenderTree.mm:
3611         (shouldLogFrameLoadDelegates):
3612         * WebKitTestRunner/TestInvocation.cpp:
3613         (WTR::TestInvocation::TestInvocation):
3614
3615 2019-08-07  Fujii Hironori  <Hironori.Fujii@sony.com>
3616
3617         [Win][MiniBrowser] Add key accelerators for reload and close window
3618         https://bugs.webkit.org/show_bug.cgi?id=200497
3619
3620         Reviewed by Brent Fulgham.
3621
3622         Added short cuts Ctrl-W to close window, Ctrl-R to reload.
3623
3624         * MiniBrowser/win/MainWindow.cpp:
3625         (MainWindow::WndProc): Added IDM_CLOSE_WINDOW case.
3626         * MiniBrowser/win/MiniBrowserLib.rc: Added "Close" menu item. Added accelerators.
3627         * MiniBrowser/win/MiniBrowserLibResource.h: Added IDM_CLOSE_WINDOW.
3628
3629 2019-08-07  Myles C. Maxfield  <mmaxfield@apple.com>
3630
3631         Add WHLSL and WebGPU to the watchlist file
3632         https://bugs.webkit.org/show_bug.cgi?id=200509
3633
3634         Reviewed by Robin Morisset.
3635
3636         * Scripts/webkitpy/common/config/watchlist:
3637
3638 2019-08-07  Keith Rollin  <krollin@apple.com>
3639
3640         Unreviewed build fix after r248317 -- disable XCBuild because it
3641         breaks incremental builds.
3642
3643         * Scripts/webkitdirs.pm:
3644         (canUseXCBuild):
3645
3646 2019-08-06  Fujii Hironori  <Hironori.Fujii@sony.com>
3647
3648         ASSERTION FAILED: m_observers.isEmpty() if WKPageSetPageStateClient is used
3649         https://bugs.webkit.org/show_bug.cgi?id=200465
3650
3651         Reviewed by Alex Christensen.
3652
3653         * TestWebKitAPI/Tests/WebKit/PageLoadState.cpp:
3654         (TestWebKitAPI::WebKit.PageLoadState): Set PageStateClient before
3655         finishing the test.
3656         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
3657         (TestWebKitAPI::PlatformWebView::~PlatformWebView): Release m_view.
3658
3659 2019-08-06  Jiewen Tan  <jiewen_tan@apple.com>
3660
3661         Unreviewed, a build fix after r248308
3662
3663         Don't use WK_ENGINEERING_CODE_SIGN_IDENTITY for Production build.
3664
3665         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
3666
3667 2019-08-06  Jiewen Tan  <jiewen_tan@apple.com>
3668
3669         Unreviewed, a build fix after r248319
3670
3671         Use HAVE(DATA_PROTECTION_KEYCHAIN) instead of HAVE_DATA_PROTECTION_KEYCHAIN.
3672
3673         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
3674         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3675         (WTR::TestController::addTestKeyToKeychain):
3676         (WTR::TestController::cleanUpKeychain):
3677         (WTR::TestController::keyExistsInKeychain):
3678
3679 2019-08-06  Jiewen Tan  <jiewen_tan@apple.com>
3680
3681         Unreviewed, a build fix after r248308
3682
3683         Use kSecUseDataProtectionKeychain for iOS 13 and macOS Catalina or newer.
3684
3685         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3686         (WTR::TestController::addTestKeyToKeychain):
3687         (WTR::TestController::cleanUpKeychain):
3688         (WTR::TestController::keyExistsInKeychain):
3689
3690 2019-08-06  Keith Rollin  <krollin@apple.com>
3691
3692         Enable XCBuild for `make` and `build-webkit` builds
3693         https://bugs.webkit.org/show_bug.cgi?id=200476
3694         <rdar://problem/50771065>
3695
3696         Reviewed by Jonathan Bedard.
3697
3698         All projects have now been tested under XCBuild and successfully
3699         build. Enable the use of XCBuild when performing builds with `make` or
3700         `build-webkit` and when using a sufficient version of Xcode. We set
3701         this version to Xcode 11 since Xcode 10 -- even though it supports
3702         XCBuild -- does not support a build facility needed to build WebKit
3703         (Bug 197072, Bug 197116, Bug 197340).
3704
3705         Do not enable XCBuild in the Xcode projects themselves since these
3706         projects may need to be used under older versions of Xcode and there's
3707         no way to make those project changes sensitive to the version of Xcode
3708         being used. This means that builds performed in the Xcode IDE will not
3709         use XCBuild.
3710
3711         * Scripts/webkitdirs.pm:
3712         (canUseXCBuild):
3713
3714 2019-08-06  Chris Dumez  <cdumez@apple.com>
3715
3716         Fix inefficiency in HTTPHeaderMap::set(CFStringRef, const String&)
3717         https://bugs.webkit.org/show_bug.cgi?id=200475
3718
3719         Reviewed by Darin Adler.
3720
3721         * TestWebKitAPI/Tests/WTF/StringView.cpp:
3722         (TestWebKitAPI::stringViewFromLiteral):
3723         (TestWebKitAPI::stringViewFromUTF8):
3724
3725 2019-08-06  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3726
3727         Update my status in contributors.json to reviewer.
3728
3729         Regained the status after following the procedure for inactive contributors.
3730         See r247136 for further explanation.
3731
3732         * Scripts/webkitpy/common/config/contributors.json:
3733
3734 2019-08-06  Jiewen Tan  <jiewen_tan@apple.com>
3735
3736         [WebAuthN] Enable LocalAuthenticator for macOS
3737         https://bugs.webkit.org/show_bug.cgi?id=182772
3738         <rdar://problem/43347920>
3739
3740         Reviewed by Brent Fulgham.
3741
3742         Add an entitlement file to WebKitTestRunner such that it can access
3743         the modern macOS keychain.
3744
3745         * WebKitTestRunner/Configurations/WebKitTestRunner.entitlements: Added.
3746         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
3747         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3748         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3749         (WTR::TestController::addTestKeyToKeychain):
3750         (WTR::TestController::cleanUpKeychain):
3751         (WTR::TestController::keyExistsInKeychain):
3752
3753 2019-08-06  Zhifei Fang  <zhifei_fang@apple.com>
3754
3755         [results.webkit.org Timeline] Performance improvements
3756         https://bugs.webkit.org/show_bug.cgi?id=200406
3757
3758         Reviewed by Jonathan Bedard.
3759
3760         1. Unhook the scroll event when a series/axis have been removed from the container
3761         2. Fix the axis's cache data structure out of sync.
3762         3. Use position:sticky to reduce the scrolling blink when update the presenter's transform
3763         4. Use intersection observer to detect if the canvas on screen or not, if a canvas is not on the screen, we do nothing, this will eliminate render requests we send out.
3764
3765
3766         * resultsdbpy/resultsdbpy/view/static/library/js/Ref.js:
3767         (Signal.prototype.removeListener):
3768         (prototype.stopAction): Unregsiter an action handler
3769         (Ref):
3770         (Ref.prototype.apply):
3771         (Ref.prototype.destory):
3772         * resultsdbpy/resultsdbpy/view/static/library/js/components/BaseComponents.js:
3773         (ApplyNewChildren):
3774         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
3775         (Timeline.CanvasSeriesComponent):
3776
3777 2019-08-06  Jer Noble  <jer.noble@apple.com>
3778
3779         Add test for behavior introduced in r248174
3780         https://bugs.webkit.org/show_bug.cgi?id=200446
3781
3782         Reviewed by Eric Carlson.
3783
3784         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3785         * TestWebKitAPI/Tests/ios/FullscreenTouchSecheuristicTests.cpp: Added.
3786         (WebKit::configureSecheuristic):
3787         (WebKit::TEST):
3788
3789 2019-08-05  Fujii Hironori  <Hironori.Fujii@sony.com>
3790
3791         [MiniBrowser][WK2] Unhandled key events should be bubbled up to the parent window
3792         https://bugs.webkit.org/show_bug.cgi?id=200464
3793
3794         Reviewed by Ross Kirsling.
3795
3796         When WK2 WebView is focused, short cut keys (e.g. Alt-F to open File
3797         menu, Alt-F4 to close window, and etc) don't work.
3798
3799         WK1 WebView doesn't have this issue because it processes key events
3800         properly.
3801
3802         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3803         (WebKitBrowserWindow::WebKitBrowserWindow):
3804         (WebKitBrowserWindow::didNotHandleKeyEvent): Added. Send the
3805         unhandled key events to the main window.
3806         * MiniBrowser/win/WebKitBrowserWindow.h:
3807
3808 2019-08-05  Simon Fraser  <simon.fraser@apple.com>
3809
3810         iOS 13: Overflow:hidden on body prevents PDF scroll
3811         https://bugs.webkit.org/show_bug.cgi?id=200435
3812         rdar://problem/53942888
3813
3814         Reviewed by Tim Horton.
3815
3816         When we navigate from an overflow:hidden HTML page to a custom view (like PDF), we need
3817         to make sure that the scroll view is scrollable.
3818
3819         * TestWebKitAPI/Tests/ios/ScrollViewScrollabilityTests.mm:
3820         (TestWebKitAPI::TEST):
3821
3822 2019-08-05  Aakash Jain  <aakash_jain@apple.com>
3823
3824         New EWS:mac-wk2 status-bubble shows waiting to run tests for all recent bugs
3825         https://bugs.webkit.org/show_bug.cgi?id=200400
3826
3827         Reviewed by Jonathan Bedard.
3828
3829         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3830         (StatusBubble._build_bubble):
3831         (StatusBubble._queue_position):
3832
3833 2019-08-05  Jonathan Bedard  <jbedard@apple.com>
3834
3835         run-webkit-tests asserts when the iPhone XR simulator is running
3836         https://bugs.webkit.org/show_bug.cgi?id=200404
3837         <rdar://problem/53878739>
3838
3839         Reviewed by Dean Jackson.
3840
3841         Support unicode in all logging statements tied to device model.
3842
3843         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3844         (Manager.run):
3845         * Scripts/webkitpy/layout_tests/views/printing.py:
3846         (Printer.print_baseline_search_path):
3847         * Scripts/webkitpy/port/device.py:
3848         (Device.__repr__):
3849         * Scripts/webkitpy/port/device_port.py:
3850         (DevicePort._install):
3851         (DevicePort.setup_test_run):
3852         (DevicePort.clean_up_test_run):
3853         (DevicePort.configuration_for_upload):
3854         * Scripts/webkitpy/port/ios.py:
3855         (IOSPort.default_baseline_search_path):
3856         * Scripts/webkitpy/xcode/device_type.py:
3857         (DeviceType.__str__):
3858         * Scripts/webkitpy/xcode/simulated_device.py:
3859         (SimulatedDeviceManager.populate_available_devices):
3860         (SimulatedDeviceManager._find_available_name):
3861         (SimulatedDeviceManager._get_device_identifier_for_type):
3862         (SimulatedDeviceManager._create_or_find_device_for_request):
3863         (SimulatedDeviceManager._does_fulfill_request):
3864         (SimulatedDeviceManager._wait_until_device_in_state):
3865         (SimulatedDeviceManager._wait_until_device_is_usable):
3866         (SimulatedDeviceManager._boot_device):
3867         (SimulatedDeviceManager.initialize_devices):
3868         (SimulatedDeviceManager.max_supported_simulators):
3869         (SimulatedDeviceManager.swap):
3870         (SimulatedDevice.is_usable):
3871         (SimulatedDevice._shut_down):
3872         (SimulatedDevice._delete):
3873         (SimulatedDevice.launch_app):
3874         (SimulatedDevice.__repr__):
3875
3876 2019-08-04  Chris Dumez  <cdumez@apple.com>
3877
3878         Ping loads should not prevent page caching
3879         https://bugs.webkit.org/show_bug.cgi?id=200418
3880         <rdar://problem/53901632>
3881
3882         Reviewed by Darin Adler.
3883
3884         Add TestOption to enable PageCache at UIProcess-level so that we can test
3885         page caching when navigating cross-origin with PSON enabled.
3886
3887         * WebKitTestRunner/TestController.cpp:
3888         (WTR::TestController::resetPreferencesToConsistentValues):
3889         (WTR::updateTestOptionsFromTestHeader):
3890         * WebKitTestRunner/TestOptions.h:
3891         (WTR::TestOptions::hasSameInitializationOptions const):
3892
3893 2019-08-02  Keith Rollin  <krollin@apple.com>
3894
3895         Consistently use Obj-C boolean literals
3896         https://bugs.webkit.org/show_bug.cgi?id=200405
3897         <rdar://problem/53880043>
3898
3899         Reviewed by Simon Fraser, Joseph Pecoraro.
3900
3901         There are places where we use equivalent but different expressions for
3902         Obj-C boolean objects. For example, we use both [NSNumber
3903         numberWithBool:YES] and @YES. There are places where both are used in
3904         the same function, such as -[WebPreferences initialize]. The boolean
3905         literal is in greater use and is more succinct, so standardize on
3906         that. Also, change @(YES/NO) to @YES/NO.
3907
3908         * DumpRenderTree/mac/ObjCController.m:
3909         (-[ObjCController objectOfClass:]):
3910         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegate.mm:
3911         (TEST):
3912         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
3913         (overrideAddObserverForName):
3914         * TestWebKitAPI/ios/mainIOS.mm:
3915         (main):
3916         * TestWebKitAPI/mac/InjectedBundleControllerMac.mm:
3917         (TestWebKitAPI::InjectedBundleController::platformInitialize):
3918         * TestWebKitAPI/mac/mainMac.mm:
3919         (main):
3920         * WebKitLauncher/WebKitNightlyEnabler.m:
3921         (enableWebKitNightlyBehaviour):
3922
3923 2019-08-02  Wenson Hsieh  <wenson_hsieh@apple.com>
3924
3925         TextAutosizingBoost.ChangeAutosizingBoostAtRuntime fails on iPad Simulator
3926         https://bugs.webkit.org/show_bug.cgi?id=200402
3927         <rdar://problem/53823368>
3928
3929         Reviewed by Tim Horton.
3930
3931         Make it possible to run this test using the iPad simulator.
3932
3933         * TestWebKitAPI/Tests/ios/TextAutosizingBoost.mm:
3934
3935         Two adjustments: (1) override the screen size to be 320 by 568 (so that the legacy text autosizing heuristic
3936         doesn't avoid boosting this text), and (2) force text autosizing on, but disable idempotent text autosizing,
3937         since this would result in differently sized text.
3938
3939         (mainScreenReferenceBoundsOverride):
3940         * TestWebKitAPI/ios/UIKitSPI.h:
3941
3942 2019-08-02  Sihui Liu  <sihui_liu@apple.com>
3943
3944         API tests using permanent credentials should clear credentials left by previous tests
3945         https://bugs.webkit.org/show_bug.cgi?id=199729
3946
3947         Reviewed by Alex Christensen.
3948
3949         We used to clear the permanent credentials created by API tests at the end of the API tests, to ensure those
3950         credentials will not affect tests running after. There is a case where permanent credentials were left on the
3951         system, so those API tests were timing out themselves before reaching to the cleanup, which caused cascading
3952         failure. To prevent this from happening again, add cleanup at the begining of the tests.
3953
3954         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
3955         (TEST):
3956         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
3957         (TestWebKitAPI::TEST):
3958
3959 2019-08-02  Andres Gonzalez  <andresg_22@apple.com>
3960
3961         Add accessibility object method to determine whether an element is inside a table cell. Needed for iOS accessibility client.
3962         https://bugs.webkit.org/show_bug.cgi?id=200394
3963         <rdar://problem/52914964>
3964
3965         Reviewed by Chris Fleizach.
3966
3967         Glue code to exercise new method [WebAccessibilityObjectWrapper _accessibilityIsInTableCell].
3968
3969         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3970         (WTR::AccessibilityUIElement::isInTableCell const):
3971         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3972         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3973         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3974         (WTR::AccessibilityUIElement::isInTableCell const):
3975
3976 2019-08-02  Zhifei Fang  <zhifei_fang@apple.com>
3977
3978         [results.webkit.org Timeline] Using transform matrix to calculate the tag rotation position
3979         https://bugs.webkit.org/show_bug.cgi?id=200397
3980
3981         Reviewed by Jonathan Bedard.
3982
3983         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
3984
3985 2019-08-02  Wenson Hsieh  <wenson_hsieh@apple.com>
3986
3987         [macOS 10.15] Image dragged from Safari does not appear in Notes
3988         https://bugs.webkit.org/show_bug.cgi?id=188490
3989         <rdar://problem/39462717>
3990
3991         Reviewed by Andy Estes.
3992
3993         Add a test to verify that promised image data can be delivered to multiple pasteboards when performing a drop.
3994
3995         * TestWebKitAPI/Tests/mac/DragAndDropTestsMac.mm:
3996
3997 2019-08-02  Alex Christensen  <achristensen@webkit.org>
3998
3999         Fix API test after r248139
4000         https://bugs.webkit.org/show_bug.cgi?id=200102
4001
4002         * TestWebKitAPI/Tests/WebKitCocoa/AdditionalReadAccessAllowedURLsPlugin.mm:
4003         (-[AdditionalReadAccessAllowedURLsPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
4004         This was supposed to be removed as part of reverting r245322.
4005
4006 2019-08-01  Zhifei Fang  <zhifei_fang@apple.com>
4007
4008         results.webkit.org: Force update cache when timeline updated
4009         https://bugs.webkit.org/show_bug.cgi?id=200363
4010
4011         Reviewed by Jonathan Bedard.
4012
4013         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
4014         (offscreenCachedRenderFactory): Add ability to force the redraw.
4015         (Timeline.CanvasSeriesComponent): Force redraw when scales or dots are updated.
4016         (Timeline.CanvasXAxisComponent): Force redraw when scales are updated. Add missing exporter for export scales update API
4017
4018 2019-08-01  Alex Christensen  <achristensen@webkit.org>
4019
4020         Do not send NetworkProcessProxy::LogTestingEvent message if we are not testing
4021         https://bugs.webkit.org/show_bug.cgi?id=200360
4022
4023         Reviewed by Tim Horton.
4024
4025         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
4026         (cleanupITPDatabase):
4027         (TEST):
4028
4029 2019-08-01  Alex Christensen  <achristensen@webkit.org>
4030
4031         Move FormData zip file generation to NetworkProcess and enable it for all WebKit clients for uploading directories
4032         https://bugs.webkit.org/show_bug.cgi?id=200102
4033         <rdar://problem/53275114>
4034
4035         Reviewed by Darin Adler.
4036
4037         Add an API test that is Mac-only right now because runOpenPanelWithParameters is only supported on Mac for some reason
4038         and because clicking on a TestWKWebView only works on Mac.
4039
4040         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4041         * TestWebKitAPI/Tests/WebKitCocoa/UploadDirectory.mm: Added.
4042         (-[UploadDelegate initWithDirectory:]):
4043         (-[UploadDelegate webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:]):
4044         (-[UploadDelegate sentDirectory]):
4045         (TEST):
4046         * TestWebKitAPI/cocoa/TestWKWebView.h:
4047         * TestWebKitAPI/cocoa/TestWKWebView.mm:
4048         (-[TestWKWebView sendClickAtPoint:]):
4049
4050 2019-08-01  Zhifei Fang  <zhifei_fang@apple.com>
4051
4052         [results.webkit.org] Timeline.CanvasXAxisComponent height should be defined by option
4053         https://bugs.webkit.org/show_bug.cgi?id=200321
4054
4055         Reviewed by Jonathan Bedard.
4056
4057         *resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
4058         Let the axis' height be defined in the option. Timeine component will use this value as
4059         padding-top for headers which allows headers start in the right position, even with multiple
4060         top axises.
4061         (Timeline.CanvasSeriesComponent):
4062         (prototype.Timeline.CanvasContainer):
4063
4064 2019-08-01  Zhifei Fang  <zhifei_fang@apple.com>
4065
4066         results.webkit.org: Collision detection for dots is off by 2 * dotMargin
4067         https://bugs.webkit.org/show_bug.cgi?id=200347
4068
4069         Reviewed by Jonathan Bedard.
4070
4071         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
4072         (Timeline.CanvasSeriesComponent): Need to change it to dotMargin + radius other than use a fixed 3 * radius, which is for the old wide timeline
4073
4074 2019-08-01  Jiewen Tan  <jiewen_tan@apple.com>
4075
4076         Improve flakiness of SOAuthorizationRedirect tests
4077         https://bugs.webkit.org/show_bug.cgi?id=200320
4078         <rdar://problem/53767057>
4079
4080         Reviewed by Alex Christensen.
4081
4082         This patch replaces Util::sleep(0.5) in tests that expect a SOAuthorization session to wait when the corresponding WKWebView
4083         is out of the window with a more precise boolean indicator: navigationPolicyDecided. The new boolean indicator is working and
4084         better because the authorizationPerformed should be set in the same runloop when NavigationState::decidePolicyForNavigationAction
4085         is executed.
4086
4087         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
4088         (-[TestSOAuthorizationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
4089         (resetState):
4090         (TestWebKitAPI::TEST):
4091
4092 2019-08-01  Keith Rollin  <krollin@apple.com>
4093
4094         Update TestWebKitAPI for XCBuild
4095         https://bugs.webkit.org/show_bug.cgi?id=200311
4096         <rdar://problem/53773804>
4097
4098         Reviewed by Alex Christensen.
4099
4100         Bug 199728 (svn 247402) updated TestWebKitAPI to use the unified-build
4101         technique. Now update WebKitLegacy to build under XCBuild after those
4102         changes. This work involves adding an "Apply Configuration to
4103         XCFileLists" build target, adding a check-xcfilelists.sh script,
4104         adding a "Check xcfilelists" build phase that calls that script,
4105         adding knowledge of the project to the generate-xcfilelists script,
4106         creating new .xcfilelist files, and adding those to the project.
4107
4108         * Scripts/webkitpy/generate_xcfilelists_lib/application.py:
4109         (Application.__init__):
4110         * Scripts/webkitpy/generate_xcfilelists_lib/generators.py:
4111         (WebKitTestRunnerGenerator._get_generate_derived_sources_script):
4112         (TestWebKitAPIGenerator):
4113         (TestWebKitAPIGenerator._get_project_file_path):
4114         (TestWebKitAPIGenerator._get_generate_unified_sources_script):
4115         * TestWebKitAPI/Scripts/check-xcfilelists.sh: Added.
4116         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4117         * TestWebKitAPI/UnifiedSources-output.xcfilelist: Added.
4118
4119 2019-08-01  Youenn Fablet  <youenn@apple.com>
4120
4121         UserMediaPermissionRequestManagerProxy should not use audio+video denied requests to deny audio-only or video-only requests
4122         https://bugs.webkit.org/show_bug.cgi?id=200317
4123
4124         Reviewed by Eric Carlson.
4125
4126         * TestWebKitAPI/Tests/WebKit/getUserMediaAudioVideoCapture.html: Added
4127         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4128         * TestWebKitAPI/Tests/WebKit/GetUserMediaReprompt.mm:
4129         (-[GetUserMediaOnlyAudioUIDelegate _webView:requestMediaCaptureAuthorization:decisionHandler:]):
4130         (-[GetUserMediaOnlyAudioUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
4131         (TestWebKitAPI::TEST):
4132
4133 2019-08-01  Aakash Jain  <aakash_jain@apple.com>
4134
4135         New EWS: Cannot see build status page when patch is waiting for tester
4136         https://bugs.webkit.org/show_bug.cgi?id=200333
4137
4138         Reviewed by Jonathan Bedard.
4139
4140         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4141         (StatusBubble): While patch hasn't started processing on tester queue, display build information from builder queue.
4142
4143 2019-08-01  Carlos Garcia Campos  <cgarcia@igalia.com>
4144
4145         [SOUP] Switch to use libsoup WebSockets API
4146         https://bugs.webkit.org/show_bug.cgi?id=200162
4147
4148         Reviewed by Michael Catanzaro.
4149
4150         Update libsoup version to 2.67.90.
4151
4152         * gtk/jhbuild.modules:
4153         * wpe/jhbuild.modules:
4154
4155 2019-07-31  Andy Estes  <aestes@apple.com>
4156
4157         REGRESSION (r240942): first visually non-empty layout milestone is not reached in media documents until after the video finishes loading
4158         https://bugs.webkit.org/show_bug.cgi?id=200293
4159         <rdar://problem/52937749>
4160
4161         Reviewed by Alex Christensen.
4162
4163         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4164         * TestWebKitAPI/Tests/WebKitCocoa/FirstVisuallyNonEmptyMilestone.mm: Renamed from Tools/TestWebKitAPI/Tests/WebKit/FirstVisuallyNonEmptyMilestoneWithDeferredScript.mm.
4165         (-[FirstPaintMessageHandler userContentController:didReceiveScriptMessage:]):
4166         (-[RenderingProgressNavigationDelegate _webView:renderingProgressDidChange:]):
4167         (-[RenderingProgressNavigationDelegate webView:didFinishNavigation:]):
4168         (TEST):
4169
4170 2019-07-31  Aakash Jain  <aakash_jain@apple.com>
4171
4172         [ews-build] Enable all macOS queues on new EWS
4173         https://bugs.webkit.org/show_bug.cgi?id=199944
4174
4175         Reviewed by Jonathan Bedard.
4176
4177         * BuildSlaveSupport/ews-build/config.json: Enabled the triggers for macOS queues.
4178         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4179         (StatusBubble): Enabled status-bubbles for mac queues, separated builders and testers bubbles in separate lines. Also
4180         removed mac-32bit and mac-32bit-wk2 bubbles, these queues were removed from Buildbot configuration previously.
4181         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js: Removed mac queues from bot-watcher's dashboard.
4182         * QueueStatusServer/config/queues.py: Removed mac queues from old EWS.
4183
4184 2019-07-31  Ryan Haddad  <ryanhaddad@apple.com>
4185
4186         Unreviewed test gardening, disable failing test for rdar://51752593.
4187
4188         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
4189
4190 2019-07-31  Jonathan Bedard  <jbedard@apple.com>
4191
4192         results.webkit.og: Timeline in canvas painting with wrong colors, cannot customize scale
4193         https://bugs.webkit.org/show_bug.cgi?id=200318
4194
4195         Reviewed by Aakash Jain.
4196
4197         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
4198         (Timeline.CanvasSeriesComponent): Reset draw context between dots.
4199         (Timeline.CanvasXAxisComponent): Use getLabel function.
4200
4201 2019-07-31  Loïc Yhuel  <loic.yhuel@softathome.com>
4202
4203         [GTK][WPE] Fix gtkdoc build with "build-webkit --32-bit" on 64-bit hosts
4204         https://bugs.webkit.org/show_bug.cgi?id=200306
4205
4206         Reviewed by Michael Catanzaro.
4207
4208         gtkdoc-scangobj calls scangobj.py, which only uses LDFLAGS on link (when producing
4209         jsc-glib-4.0-scan for example).
4210
4211         * Scripts/webkitdirs.pm:
4212         (generateBuildSystemFromCMakeProject):
4213
4214 2019-07-31  Ryan Haddad  <ryanhaddad@apple.com>
4215
4216         Unreviewed test gardening, disable failing test for rdar://52355829.
4217
4218         * TestWebKitAPI/Tests/WebKitCocoa/ContextMenus.mm:
4219         (TEST):
4220
4221 2019-07-31  Keith Rollin  <krollin@apple.com>
4222
4223         Update WebKitLegacy for XCBuild
4224         https://bugs.webkit.org/show_bug.cgi?id=200310
4225         <rdar://problem/53773708>
4226
4227         Reviewed by Alex Christensen.
4228
4229         Bug 199771 (svn r247570) updated WebKitLegacy to use the unified-build
4230         technique. Now update WebKitLegacy to build under XCBuild after those
4231         changes. This work involves adding an "Apply Configuration to
4232         XCFileLists" build target, adding a check-xcfilelists.sh script,
4233         adding a "Check xcfilelists" build phase that calls that script,
4234         adding knowledge of the project to the generate-xcfilelists script,
4235         creating new .xcfilelist files, and adding those to the project.
4236
4237         * Scripts/webkitpy/generate_xcfilelists_lib/application.py:
4238         (Application.__init__):
4239         * Scripts/webkitpy/generate_xcfilelists_lib/generators.py:
4240         (JavaScriptCoreGenerator):
4241         (WebCoreGenerator):
4242         (WebKitGenerator):
4243         (WebKitGenerator._get_generate_unified_sources_script):
4244         (WebKitLegacyGenerator):
4245         (WebKitLegacyGenerator._get_project_file_path):
4246         (WebKitLegacyGenerator._get_generate_unified_sources_script):
4247
4248 2019-07-31  Chris Dumez  <cdumez@apple.com>
4249
4250         REGRESSION (r247486?): Flaky API Test TestWebKitAPI.WKWebView.LocalStorageProcessSuspends
4251         https://bugs.webkit.org/show_bug.cgi?id=200086
4252         <rdar://problem/53501721>
4253
4254         Reviewed by Alex Christensen.
4255
4256         re-enable the API test.
4257
4258         * TestWebKitAPI/Tests/WebKitCocoa/LocalStoragePersistence.mm:
4259         (TEST):
4260
4261 2019-07-31  Wenson Hsieh  <wenson_hsieh@apple.com>
4262
4263         [iOS 13] Safari crashes when closing a tab with a focused element if the unified field has focus
4264         https://bugs.webkit.org/show_bug.cgi?id=200291
4265         <rdar://problem/53717946>
4266
4267         Reviewed by Megan Gardner.
4268
4269         Add an API test to exercise the scenario of synchronously requesting the autocorrection context immediately
4270         after closing the web view, while the web view's content view isn't the first responder.
4271
4272         * TestWebKitAPI/Tests/ios/AutocorrectionTestsIOS.mm:
4273         * TestWebKitAPI/ios/UIKitSPI.h:
4274
4275 2019-07-31  Carlos Garcia Campos  <cgarcia@igalia.com>
4276
4277         [GTK] Datalist element support for TextFieldInputType
4278         https://bugs.webkit.org/show_bug.cgi?id=98934
4279
4280         Reviewed by Michael Catanzaro.
4281
4282         Implement UIScriptControllerGtk::isShowingDataListSuggestions.
4283
4284         * WebKitTestRunner/gtk/UIScriptControllerGtk.cpp:
4285         (WTR::UIScriptControllerGtk::isShowingDataListSuggestions const):
4286         * WebKitTestRunner/gtk/UIScriptControllerGtk.h:
4287
4288 2019-07-30  Tim Horton  <timothy_horton@apple.com>
4289
4290         Remove some needless comments that snuck into the tree
4291
4292         * TestRunnerShared/UIScriptContext/UIScriptController.h:
4293         (WTR::UIScriptController::setHardwareKeyboardAttached):
4294         (WTR::UIScriptController::playBackEventStream):
4295
4296 2019-07-30  Fujii Hironori  <Hironori.Fujii@sony.com>
4297
4298         [WebKit] Add PageLoadState::Observer C API
4299         https://bugs.webkit.org/show_bug.cgi?id=199848
4300
4301         Reviewed by Alex Christensen.
4302
4303         * MiniBrowser/win/WebKitBrowserWindow.cpp:
4304         (WebKitBrowserWindow::WebKitBrowserWindow):
4305         (WebKitBrowserWindow::didChangeTitle):
4306         (WebKitBrowserWindow::didFinishNavigation): Deleted.
4307         * MiniBrowser/win/WebKitBrowserWindow.h:
4308         * TestWebKitAPI/CMakeLists.txt:
4309         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4310         * TestWebKitAPI/Tests/WebKit/PageLoadState.cpp: Added.
4311         (TestWebKitAPI::PageLoadTestState::PageLoadTestState):
4312         (TestWebKitAPI::didChangeActiveURL):
4313         (TestWebKitAPI::didChangeCanGoBack):
4314         (TestWebKitAPI::didChangeCanGoForward):
4315         (TestWebKitAPI::didChangeCertificateInfo):
4316         (TestWebKitAPI::didChangeEstimatedProgress):
4317         (TestWebKitAPI::didChangeHasOnlySecureContent):
4318         (TestWebKitAPI::didChangeIsLoading):
4319         (TestWebKitAPI::didChangeNetworkRequestsInProgress):
4320         (TestWebKitAPI::didChangeTitle):
4321         (TestWebKitAPI::didChangeWebProcessIsResponsive):
4322         (TestWebKitAPI::didSwapWebProcesses):
4323         (TestWebKitAPI::willChangeActiveURL):
4324         (TestWebKitAPI::willChangeCanGoBack):
4325         (TestWebKitAPI::willChangeCanGoForward):
4326         (TestWebKitAPI::willChangeCertificateInfo):
4327         (TestWebKitAPI::willChangeEstimatedProgress):
4328         (TestWebKitAPI::willChangeHasOnlySecureContent):
4329         (TestWebKitAPI::willChangeIsLoading):
4330         (TestWebKitAPI::willChangeNetworkRequestsInProgress):
4331         (TestWebKitAPI::willChangeTitle):
4332         (TestWebKitAPI::willChangeWebProcessIsResponsive):
4333         (TestWebKitAPI::didFinishNavigation):
4334         (TestWebKitAPI::TEST):
4335
4336 2019-07-30  Jonathan Bedard  <jbedard@apple.com>
4337
4338         DumpRenderTree.app: Add CFBundleShortVersionString
4339         https://bugs.webkit.org/show_bug.cgi?id=200269
4340         <rdar://problem/53412596>
4341
4342         Rubber-stamped by Aakash Jain.
4343
4344         * DumpRenderTree/ios/Info.plist:
4345
4346 2019-07-29  Wenson Hsieh  <wenson_hsieh@apple.com>
4347
4348         Add layout test coverage for <https://webkit.org/b/200215>
4349         https://bugs.webkit.org/show_bug.cgi?id=200245
4350         <rdar://problem/52976965>
4351
4352         Reviewed by Tim Horton.
4353
4354         Add new testing infrastructure. See below for more details.
4355
4356         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
4357         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
4358         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
4359         (WTR::UIScriptController::setWillCreateNewPageCallback):
4360         (WTR::UIScriptController::willCreateNewPageCallback const):
4361
4362         Add platform-agnostic UIScriptController callback hooks to notify a test when