Rubberstamped by Eric Seidel.
[WebKit.git] / Tools / ChangeLog
1 2011-04-26  Kevin Ollivier  <kevino@theolliviers.com>
2
3         Rubberstamped by Eric Seidel.
4
5         Enable waf to be used to build other ports
6         https://bugs.webkit.org/show_bug.cgi?id=58213
7
8         * Scripts/build-webkit:
9         * Scripts/webkitdirs.pm:
10         * waf: Added.
11         * waf/build: Added.
12         * waf/build/build_utils.py: Added.
13         * waf/build/settings.py: Added.
14         * waf/build/waf_extensions.py: Added.
15         * waf/build/wxpresets.py: Added.
16
17 2011-04-26  Sam Weinig  <sam@webkit.org>
18
19         Reviewed by David Hyatt.
20
21         Remove Datagrid from the tree
22         https://bugs.webkit.org/show_bug.cgi?id=59543
23
24         * Scripts/build-webkit:
25         Remove feature.
26
27         * iExploder/iexploder-1.3.2/htdocs/htmltags.in:
28         * iExploder/iexploder-1.7.2/src/html-tags/webkit:
29         Remove from fuzzer.
30
31 2011-04-26  Brent Fulgham  <bfulgham@webkit.org>
32
33         Reviewed by Adam Roben.
34
35         Update WinLauncher with command-line arguments to allow the
36         transparency to be tested.  Use --transparent to create a
37         transparent view.  Use --desktop to have the view fill the
38         desktop area of the screen.
39         https://bugs.webkit.org/show_bug.cgi?id=58300
40
41         * WinLauncher/WinLauncher.cpp:
42         (usesLayeredWebView): New method to indicate that the
43         program is running with layered windows (alpha-blended
44         transparent windows).
45         (shouldUseFullDesktop): New method to indicate that the
46         program is running across the full desktop (less any
47         task bars.)
48         (resizeSubViews): Layered window mode doesn't have any
49         winapi child windows, so this routine is exited early
50         for that case.
51         (subclassForLayeredWindow): Subclass the window so we can
52         override its defaut message loop.
53         (computeFullDesktopFrame): Convenience function to get the
54         desktop region and update the frame dimensions appropriately.
55         (_tWinMain): Updated to accept the new '--transparent' and
56         '--desktop' arguments.
57         (InitInstance): Modified to exit early for the transparent
58         background case.  WebKit will construct our primary window (with
59         appropriate settings) so we don't need to create one ourselves.
60         (WndProc): 
61         (TransparentWndProc): New message loop for transparent windows,
62         since they need special handling to support dragging.
63
64 2011-04-26  Alexandre MAzari  <amazari@igalia.com>
65
66         Reviewed by Xan Lopez.
67
68         [Gtk] Implement LayoutTestController::setPluginsEnabled
69         https://bugs.webkit.org/show_bug.cgi?id=59184
70
71         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
72         (LayoutTestController::setPluginsEnabled):
73
74 2011-04-26  Chang Shu  <cshu@webkit.org>
75
76         Reviewed by Laszlo Gombos.
77
78         WebKitTestRunner needs layoutTestController.setAllowFileAccessFromFileURLs
79         https://bugs.webkit.org/show_bug.cgi?id=57572
80
81         Remove the unnecessary code that updates preference.
82
83         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
84         (WTR::InjectedBundle::beginTesting):
85         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
86         (WTR::LayoutTestController::setAllowUniversalAccessFromFileURLs):
87
88 2011-04-26  Mario Sanchez Prada  <msanchez@igalia.com>
89
90         Reviewed by Eric Seidel.
91
92         [GTK] accessibility/aria-combobox-expected.txt
93         https://bugs.webkit.org/show_bug.cgi?id=59399
94
95         Implement isExpanded(), as it's used in the layout test.
96
97         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
98         (AccessibilityUIElement::isExpanded): Implemented.
99
100 2011-04-26  Adrienne Walker  <enne@google.com>
101
102         Reviewed by Kent Tamura.
103
104         [chromium] Fix memory leak in DRT due to OwnPtr<T*>
105         https://bugs.webkit.org/show_bug.cgi?id=59489
106
107         * DumpRenderTree/chromium/WebViewHost.h:
108
109 2011-04-26  Mario Sanchez Prada  <msanchez@igalia.com>
110
111         Reviewed by Eric Seidel.
112
113         [GTK] Implement isChecked in DRT
114         https://bugs.webkit.org/show_bug.cgi?id=59385
115
116         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
117         (AccessibilityUIElement::isChecked): Implemented.
118
119 2011-04-26  Alejandro G. Castro  <alex@igalia.com>
120
121         Unreviewed, rolling out r84949.
122         http://trac.webkit.org/changeset/84949
123         https://bugs.webkit.org/show_bug.cgi?id=58852
124
125         Broke GTK+ compilation
126
127         * GtkLauncher/main.c:
128         (main):
129
130 2011-04-26  Eric Seidel  <eric@webkit.org>
131
132         Reviewed by Mihai Parparita.
133
134         sheriff-bot should have a create-bug command
135         https://bugs.webkit.org/show_bug.cgi?id=59491
136
137         This patch has some stderr unittest spew, but I will
138         fix it after my live demo.
139
140         * Scripts/webkitpy/tool/bot/irc_command.py:
141         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
142         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
143
144 2011-04-26  Ryuan Choi  <ryuan.choi@samsung.com>
145
146         Reviewed by Martin Robinson.
147
148         [GTK] Add proxy support to GtkLauncher
149         https://bugs.webkit.org/show_bug.cgi?id=58852
150
151         Add SOUP_TYPE_PROXY_RESOLVER_DEFAULT feature or set SOUP_SESSION_PROXY_URI for developers behind proxy.
152
153         * GtkLauncher/main.c:
154         (main):
155
156 2011-04-26  Dan Bernstein  <mitz@apple.com>
157
158         Reviewed by Mark Rowe.
159
160         Choose the compiler based on the Xcode version for Snow Leopard debug builds.
161
162         * DumpRenderTree/mac/Configurations/Base.xcconfig:
163         * DumpRenderTree/mac/Configurations/CompilerVersion.xcconfig: Added.
164         * MiniBrowser/Configurations/Base.xcconfig:
165         * MiniBrowser/Configurations/CompilerVersion.xcconfig: Added.
166         * TestWebKitAPI/Configurations/Base.xcconfig:
167         * TestWebKitAPI/Configurations/CompilerVersion.xcconfig: Added.
168         * WebKitTestRunner/Configurations/Base.xcconfig:
169         * WebKitTestRunner/Configurations/CompilerVersion.xcconfig: Added.
170
171 2011-04-26  Finnur Thorarinsson  <finnur.webkit@gmail.com>
172
173         Reviewed by David Levin.
174
175         Adding myself as a Chromium contributors to committers.py.
176
177         https://bugs.webkit.org/show_bug.cgi?id=59444
178
179         * Scripts/webkitpy/common/config/committers.py:
180
181 2011-04-26  Adam Barth  <abarth@webkit.org>
182
183         Reviewed by Eric Seidel.
184
185         DumpRenderTree/chromium should play nice with strict OwnPtrs
186         https://bugs.webkit.org/show_bug.cgi?id=59458
187
188         All these changes are pretty straight forward.
189
190         * DumpRenderTree/chromium/CppBoundClass.cpp:
191         (GetterPropertyCallback::GetterPropertyCallback):
192         (CppBoundClass::bindGetterCallback):
193         * DumpRenderTree/chromium/CppBoundClass.h:
194         (CppBoundClass::bindProperty):
195         (CppBoundClass::bindFallbackCallback):
196         (CppBoundClass::bindFallbackMethod):
197         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
198         (DRTDevToolsClient::DRTDevToolsClient):
199         * DumpRenderTree/chromium/TestEventPrinter.cpp:
200         (TestEventPrinter::createDRTPrinter):
201         (TestEventPrinter::createTestShellPrinter):
202         * DumpRenderTree/chromium/TestEventPrinter.h:
203         * DumpRenderTree/chromium/TestShell.cpp:
204         (TestShell::TestShell):
205         (TestShell::createMainWindow):
206         (TestShell::createDRTDevToolsClient):
207         * DumpRenderTree/chromium/WebViewHost.cpp:
208         (WebViewHost::geolocationClientMock):
209         (WebViewHost::speechInputController):
210         (WebViewHost::deviceOrientationClientMock):
211         (WebViewHost::reset):
212         (WebViewHost::navigate):
213         (WebViewHost::setPendingExtraData):
214         (WebViewHost::canvas):
215         * DumpRenderTree/chromium/WebViewHost.h:
216
217 2011-04-26  Adam Roben  <aroben@apple.com>
218
219         Make DRT/win log loading errors the same way DRT/mac does
220
221         Fixes <http://webkit.org/b/59303> [Windows WebKit1 Tests]
222         http/tests/misc/will-send-request-returns-null-on-redirect.html failing since r84742
223
224         Reviewed by Alexey Proskuryakov.
225
226         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
227         (ResourceLoadDelegate::descriptionSuitableForTestResult): Removed the workaround for
228         <rdar://problem/5064234>, which has long since been fixed, and then made this function match
229         -[NSError(DRTExtras) _drt_descriptionSuitableForTestResult] more closely.
230
231 2011-04-26  Dan Bernstein  <mitz@apple.com>
232
233         REGRESSION (84876): build-webkit produces an error message
234         https://bugs.webkit.org/show_bug.cgi?id=59460
235
236         * Scripts/webkitdirs.pm:
237
238 2011-04-26  Mihai Parparita  <mihaip@chromium.org>
239
240         Reviewed by Eric Seidel.
241
242         Fix timestamp comparison in check-for-weak-vtables-and-externals
243         https://bugs.webkit.org/show_bug.cgi?id=59416
244         
245         We should only re-run the check-for-weak-vtables-and-externals script
246         if the executable is more recent than the last run.
247
248         * Scripts/check-for-weak-vtables-and-externals:
249
250 2011-04-26  Kristóf Kosztyó  <Kosztyo.Kristof@stud.u-szeged.hu>
251
252         Reviewed by Csaba Osztrogonác.
253
254         [Qt] Implement LayoutTestController::setAutofilled
255         https://bugs.webkit.org/show_bug.cgi?id=59439
256
257         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
258         (LayoutTestController::setAutofilled):
259         * DumpRenderTree/qt/LayoutTestControllerQt.h:
260
261 2011-04-25  Dan Bernstein  <mitz@apple.com>
262
263         Reviewed by Mark Rowe.
264
265         Teach build-webkit where newer Xcode versions store the application-wide build settings user default.
266
267         * Scripts/webkitdirs.pm:
268
269 2011-04-25  Sam Weinig  <sam@webkit.org>
270
271         Reviewed by Adam Roben.
272
273         Leaks Viewer throws "Cannot post cyclic structures" in Safari 5
274         https://bugs.webkit.org/show_bug.cgi?id=56090
275
276         Make LeaksViewer work with versions of browsers that don't support message
277         passing of cyclic structures.
278
279         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParser.js:
280         (LeaksParser.this._worker.onmessage):
281         (LeaksParser):
282         (LeaksParser.prototype.addLeaksFile):
283         Use LeaksParserImpl directly if we don't support passing cyclic structures.
284
285         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserImpl.js: Copied from BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js.
286         (LeaksParserImpl):
287         (LeaksParserImpl.prototype.addLeaksFile):
288         (LeaksParserImpl.prototype._incorporateLeaks):
289         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js:
290         (onmessage):
291         Factor out LeaksParser implementation into LeaksParserImpl.js.
292
293         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Utilities.js:
294         (workersSupportCyclicStructures):
295         Add function to detect if workers support passing cyclic structures.
296
297         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html:
298         Add LeaksParserImpl.js include.
299
300 2011-04-25  Jeff Miller  <jeffm@apple.com>
301
302         Reviewed by Timothy Hatcher.
303
304         Treat strings defined with UI_STRING_LOCALIZE_LATER_KEY() as debugging strings in extract-localizable-strings
305         https://bugs.webkit.org/show_bug.cgi?id=59373
306
307         * Scripts/extract-localizable-strings: Add UI_STRING_LOCALIZE_LATER_KEY() to isDebugMacro var.
308
309 2011-04-25  Andrew Scherkus  <scherkus@chromium.org>
310
311         Reviewed by Dimitri Glazkov.
312
313         Adding a few Chromium contributors to committers.py.
314
315         https://bugs.webkit.org/show_bug.cgi?id=59327
316
317         * Scripts/webkitpy/common/config/committers.py:
318
319 2011-04-23  Dominic Cooney  <dominicc@chromium.org>
320
321         Reviewed by Dimitri Glazkov.
322
323         [V8] Nodes in shadow DOM should not be GCed while their hosts are alive
324         https://bugs.webkit.org/show_bug.cgi?id=59284
325
326         Chromium DRT over-refcounted the NPObject wrappers it used to
327         marshal shadowRoot nodes back to tests (WebBindings::makeNode
328         births NPObjects with referenceCount == 1). This masked the GC bug
329         59284 in tests by making shadowRoot nodes live forever.
330
331         * DumpRenderTree/chromium/LayoutTestController.cpp:
332         (LayoutTestController::shadowRoot):
333         (LayoutTestController::ensureShadowRoot):
334
335 2011-04-23  Kevin Ollivier  <kevino@theolliviers.com>
336
337         [wx] Unreviewed build fixes. Add new methods to wx LayoutTestController,
338         and update the URL for downloading waf.
339         
340         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
341         (LayoutTestController::ensureShadowRoot):
342         (LayoutTestController::removeShadowRoot):
343         * Scripts/webkitdirs.pm:
344
345 2011-04-22  Sheriff Bot  <webkit.review.bot@gmail.com>
346
347         Unreviewed, rolling out r84627.
348         http://trac.webkit.org/changeset/84627
349         https://bugs.webkit.org/show_bug.cgi?id=59271
350
351         It broke Symbian build (Requested by Ossy on #webkit).
352
353         * Scripts/webkitpy/style/checker.py:
354         * Scripts/webkitpy/style/checker_unittest.py:
355
356 2011-04-22  Dirk Pranke  <dpranke@chromium.org>
357
358         Reviewed by Adam Barth.
359
360         rebaseline-chromium-webkit-tests: clean up output
361         https://bugs.webkit.org/show_bug.cgi?id=59240
362
363         This change dramatically changes the output the tool provides
364         by default. The previous output (more or less) is still there
365         in -v / verbose / debug mode, but the default output is
366         way terser and more readable. It mostly says which files are
367         updated, which are duplicates, and which are not found in an
368         archive. Feedback desired :).
369
370         This change also adds a scm.exists() method to the SCM object
371         so that we can cleanly figure out what we're doing while
372         rebaselining.
373
374         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
375         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
376         * Scripts/webkitpy/common/system/filesystem_mock.py:
377         * Scripts/webkitpy/common/checkout/scm.py:
378         * Scripts/webkitpy/common/checkout/scm_unittest.py:
379
380 2011-04-22  Ilya Sherman  <isherman@chromium.org>
381
382         Reviewed by Alexey Proskuryakov.
383
384         Add Ilya Sherman (isherman@chromium.org) to the list of contributors
385         https://bugs.webkit.org/show_bug.cgi?id=59231
386
387         * Scripts/webkitpy/common/config/committers.py:
388
389 2011-04-22  Yuta Kitamura  <yutak@chromium.org>
390
391         Reviewed by Ojan Vafai.
392
393         new-run-webkit-tests: Exception raised when stderr contains binary data
394         https://bugs.webkit.org/show_bug.cgi?id=59083
395
396         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
397         Use write_binary_file() instead of write_text_file().
398
399 2011-04-22  Chang Shu  <cshu@webkit.org>
400
401         Reviewed by Kenneth Rohde Christiansen.
402
403         WebKitTestRunner needs layoutTestController.setFrameFlatteningEnabled
404         https://bugs.webkit.org/show_bug.cgi?id=42536
405
406         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
407         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
408         (WTR::LayoutTestController::setFrameFlatteningEnabled):
409         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
410
411 2011-04-22  Adam Barth  <abarth@webkit.org>
412
413         Reviewed by Eric Seidel.
414
415         CommitQueue should remember the expected failures from patch to patch
416         https://bugs.webkit.org/show_bug.cgi?id=59253
417
418         Previously, we stored the set of expected failures on the task object,
419         which meant the commit-queue forgot about them after each patch.  This
420         patch moves them to the CommitQueue object so they will have a longer
421         lifetime.
422
423         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
424         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
425         * Scripts/webkitpy/tool/commands/queues.py:
426
427 2011-04-22  Sam Weinig  <sam@webkit.org>
428
429         Reviewed by Brian Weinstein.
430
431         WebKit2: Implement JavaScript unresponsiveness timer/callbacks
432         https://bugs.webkit.org/show_bug.cgi?id=59248
433
434         Stub out shouldInterruptJavaScript callbacks.
435
436         * MiniBrowser/mac/BrowserWindowController.m:
437         (-[BrowserWindowController awakeFromNib]):
438         * MiniBrowser/win/BrowserView.cpp:
439         (BrowserView::create):
440         * WebKitTestRunner/TestController.cpp:
441         (WTR::TestController::createOtherPage):
442         (WTR::TestController::initialize):
443
444 2011-04-22  Daniel Bates  <dbates@webkit.org>
445
446         Reviewed by Csaba Osztrogonác.
447
448         webkit-patch land hangs if svn prompts for credentials
449         https://bugs.webkit.org/show_bug.cgi?id=31500
450
451         Make has_authorization_for_realm() return True only if there exists a credentials file
452         that contains either the word "password" or "passtype". We assume that these words don't
453         coincide with the actual credential data (e.g. a person's username is "password").
454
455         * Scripts/webkitpy/common/checkout/scm.py:
456         * Scripts/webkitpy/common/checkout/scm_unittest.py:
457           - Added test cases:
458             test_has_authorization_for_realm_using_credentials_with_passtype(),
459             test_has_authorization_for_realm_using_credentials_with_password(),
460             test_not_have_authorization_for_realm_with_credentials_missing_password_and_passtype()
461           - Renamed test_not_have_authorization_for_realm() to test_not_have_authorization_for_realm_when_missing_credentials_file()
462             to better describe what it's testing.
463           - Repurposed test_has_authorization_for_realm() to take realm and credential data to use
464             and return the result of calling has_authorization_for_realm() so that the caller can
465             assert the result; Renamed to _test_has_authorization_for_realm_using_credentials() to
466             better reflect its new purpose.
467
468 2011-04-22  Adam Barth  <abarth@webkit.org>
469
470         Remove double-negative.  (Sorry this was bugging me.)
471
472         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
473
474 2011-04-22  Adam Barth  <abarth@webkit.org>
475
476         Reviewed by Eric Seidel.
477
478         Factor LayoutTestResultsReader out of CommitQueue
479         https://bugs.webkit.org/show_bug.cgi?id=59244
480
481         This code will be shared with the EWS when they start running tests.
482
483         * Scripts/webkitpy/tool/bot/layouttestresultsreader.py: Added.
484         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py: Added.
485         * Scripts/webkitpy/tool/commands/queues.py:
486         * Scripts/webkitpy/tool/commands/queues_unittest.py:
487
488 2011-04-22  Eric Seidel  <eric@webkit.org>
489
490         Reviewed by Dimitri Glazkov.
491
492         webkit-patch rebaseline is broken
493         https://bugs.webkit.org/show_bug.cgi?id=59207
494
495         My recent changes to how LayoutTestResults.results_from_string
496         uncovered a bug in our use of urllib2.
497         We now are treating the return value from _fetch_results_html()
498         (which returns urllib2.openurl()) as a string.  That's incorrect,
499         the return value is a file-like object (which auto-converts to a
500         string in most cases).
501
502         I've updated our urllib2-using code to correctly call .read() on the
503         resulting object before treating it like a string.
504         Unfortunately there is no easy way to test this mis-understanding
505         of the openurl() semantics.
506
507         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
508
509 2011-04-22  Adam Barth  <abarth@webkit.org>
510
511         Reviewed by Eric Seidel.
512
513         Factor PatchAnalysis task out of CommitQueueTask
514         https://bugs.webkit.org/show_bug.cgi?id=59220
515
516         This is a first step towards teaching the EWS to run tests.
517
518         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
519         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
520         * Scripts/webkitpy/tool/bot/patchanalysistask.py: Added.
521
522 2011-04-22  Philippe Normand  <pnormand@igalia.com>
523
524         Reviewed by Martin Robinson.
525
526         [GTK] DRT: implement eventSender.scalePageBy
527         https://bugs.webkit.org/show_bug.cgi?id=59082
528
529         * DumpRenderTree/gtk/EventSender.cpp:
530         (scalePageByCallback): scalePageBy() support.
531
532 2011-04-21  Eric Seidel  <eric@webkit.org>
533
534         Reviewed by Adam Barth.
535
536         LayoutTestResults should know how to handle NRWT json files
537         https://bugs.webkit.org/show_bug.cgi?id=59168
538
539         LayoutTestResults was originally created to be a parallel
540         to existing NRWT architecture for dealing with results files.
541         But then it turns out that NRWT has no such architecture. :(
542         So this patch writes the necessary code to handle reading
543         full_results.json and unexpected_results.json files from
544         NRWT layout-test-results directories.
545
546         LayoutTestResults has thus morphed from being ORWT-only to
547         supporting both ORWT and NRWT.  It's possible at some future
548         point that other pieces of the NRWT architecture will learn
549         how to read JSON files in which case this can go away.
550
551         This is all done for making it possible for the commit-queue
552         to run the tests using NWRT and be able to understand the results
553         (for flaky test reporting, etc.)
554
555         * Scripts/webkitpy/common/net/layouttestresults.py:
556         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
557         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
558         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
559         * Scripts/webkitpy/common/net/resultsjsonparser.py: Added.
560         * Scripts/webkitpy/common/net/resultsjsonparser_unittest.py: Added.
561
562 2011-04-22  Yi Shen  <yi.4.shen@nokia.com>
563
564         Reviewed by Kenneth Rohde Christiansen.
565
566         [Qt] Upstream Symbian platform plugin
567         https://bugs.webkit.org/show_bug.cgi?id=58435
568
569         Exempting directory WebKit/qt/symbian/platformplugin from style guide.
570
571         * Scripts/webkitpy/style/checker.py:
572         * Scripts/webkitpy/style/checker_unittest.py:
573
574 2011-04-22  Balazs Kelemen  <kbalazs@webkit.org>
575
576         Reviewed by Csaba Osztrogonác.
577
578         [Qt][WK2] Qt should use the mac-wk2 skipped list
579         https://bugs.webkit.org/show_bug.cgi?id=58536
580
581         * Scripts/old-run-webkit-tests:
582
583 2011-04-21  Tony Chang  <tony@chromium.org>
584
585         Reviewed by Mihai Parparita.
586
587         Remove find-mismatched-layout-test-results since it's not needed in a
588         checksum free world.
589         https://bugs.webkit.org/show_bug.cgi?id=59156
590
591         * Scripts/find-mismatched-layout-test-results: Removed.
592
593 2011-04-21  Brent Fulgham  <bfulgham@webkit.org>
594
595         Reviewed by Martin Robinson.
596
597         Teach build-webkit and update-webkit that the WinCairo port does
598         not need the non-redistributable WebKitSupportLibraries.zip file.
599         Also append the _Cairo_CFLite label to the build target for the
600         default (no argument) case when building with '--wincairo'
601     
602         https://bugs.webkit.org/show_bug.cgi?id=58801
603
604         * Scripts/build-webkit: Don't die if WebKitSupportLibraries.zip
605           doesn't exist.
606         * Scripts/webkitdirs.pm: Append '_Cairo_CFLite' to the default
607           'Release' build target when passed the '--wincairo' flag.
608         * Scripts/update-webkit: Don't die if WebKitSupportLibraries.zip
609           doesn't exist.
610
611 2011-04-21  Dirk Pranke  <dpranke@chromium.org>
612
613         Reviewed by Eric Seidel.
614
615         new-run-webkit-tests: obsolete old code, part 5: rename message_broker2 to message_broker
616         https://bugs.webkit.org/show_bug.cgi?id=58758
617
618         Since worker_mixin is now only used by worker, there's no point
619         in having it split across two files.
620
621         * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:
622         * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker_unittest.py:
623         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py: Added
624         * Scripts/webkitpy/layout_tests/layout_package/message_broker2.py: Removed.
625         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py: * Added
626         * Scripts/webkitpy/layout_tests/layout_package/message_broker2_unittest.py: Removed.
627
628 2011-04-21  Dirk Pranke  <dpranke@chromium.org>
629
630         Reviewed by Tony Chang.
631
632         new-run-webkit-tests: obsolete old code, part 4: merge worker_mixin into worker
633         https://bugs.webkit.org/show_bug.cgi?id=58756
634
635         Since worker_mixin is now only used by worker, there's no point
636         in having it split across two files.
637
638         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
639         * Scripts/webkitpy/layout_tests/layout_package/worker_mixin.py: Removed.
640
641 2011-04-21  Dirk Pranke  <dpranke@chromium.org>
642
643         Reviewed by Tony Chang.
644
645         new-run-webkit-tests: obsolete old code, part 3 - rename test_runner to manager
646         https://bugs.webkit.org/show_bug.cgi?id=58754
647
648         test_runner hasn't been a great name for some time, since all of
649         the test running is actually done in worker and
650         single_test_runner. Rename to manager to match the terminology
651         elsewhere.
652
653         * Scripts/webkitpy/layout_tests/layout_package/manager.py: Added.
654         * Scripts/webkitpy/layout_tests/layout_package/manager_unittest.py: Added.
655         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
656         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py: Removed.
657         * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py: Removed.
658         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
659
660 2011-04-21  Dirk Pranke  <dpranke@chromium.org>
661
662         Reviewed by Tony Chang.
663
664         new-run-webkit-tests: obsolete old threading code, part 2
665         https://bugs.webkit.org/show_bug.cgi?id=58753
666
667         This merges the test_runner2 code back into test_runner since
668         there's only a single type of test runner now.
669
670         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
671         * Scripts/webkitpy/layout_tests/layout_package/test_runner2.py: Removed.
672         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
673
674 2011-04-21  Maciej Stachowiak  <mjs@apple.com>
675
676         Reviewed by Adam Roben.
677
678         Add a feature define to allow <details> and <summary> to be disabled
679         https://bugs.webkit.org/show_bug.cgi?id=59118
680         <rdar://problem/9257045>
681
682         * Scripts/build-webkit:
683         * Tools.pro:
684
685 2011-04-21  Adam Barth  <abarth@webkit.org>
686
687         Reviewed by Eric Seidel.
688
689         webkit-patch upload should assign the bug to you
690         https://bugs.webkit.org/show_bug.cgi?id=33699
691
692         This patch only re-assigns the bug if it is currently unassigned.  We
693         can be more aggressive in the future if people want us to be more
694         agressive.
695
696         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
697         * Scripts/webkitpy/tool/commands/upload_unittest.py:
698         * Scripts/webkitpy/tool/mocktool.py:
699         * Scripts/webkitpy/tool/steps/postdiff.py:
700
701 2011-04-21  Ojan Vafai  <ojan@chromium.org>
702
703         Reviewed by Tony Chang.
704
705         move json_results.html over to LayoutTests/fast/harness
706         https://bugs.webkit.org/show_bug.cgi?id=59154
707
708         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
709
710 2011-04-21  Adam Barth  <abarth@webkit.org>
711
712         Reviewed by Eric Seidel.
713
714         ValidateChangeLogs doesn't work on SVN
715         https://bugs.webkit.org/show_bug.cgi?id=59115
716
717         svn-create-patch lies about the diff in the working copy by moving
718         ChangeLog entries to the top of the diff.  That's fine on most cases,
719         but causes problems for ValidateChangeLogs, which is trying validate
720         the where the ChangeLog entry appears.
721
722         I haven't added a test for this change because I couldn't figure out
723         how to write one.  The issue is more of an integration issue, which
724         we're not really set up to test in our unit testing framework.  If this
725         patch had worked around the output from svn-create-patch, then I could
726         have tested that we behave correctly on sample svn-create-patch output,
727         but, in this case, I've removed the dependency on svn-create-patch.  I
728         could test that we behave correctly on "svn diff" output, but we
729         already have those tests.
730
731         * Scripts/webkitpy/tool/commands/download_unittest.py:
732         * Scripts/webkitpy/tool/mocktool.py:
733         * Scripts/webkitpy/tool/steps/validatechangelogs.py:
734
735 2011-04-21  Tony Chang  <tony@chromium.org>
736
737         Reviewed by Ojan Vafai.
738
739         old-run-webkit-tests/new-run-webkit-tests shouldn't read or write .checksum files
740         https://bugs.webkit.org/show_bug.cgi?id=58402
741
742         * Scripts/old-run-webkit-tests: Don't read or write .checksum files.
743         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py: Don't write .checksum files.
744         * Scripts/webkitpy/layout_tests/port/base.py: Don't read .checksum files.
745         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
746         * Scripts/webkitpy/layout_tests/port/test.py: Update passing pngs to include a checksum.
747         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
748
749 2011-04-21  Ojan Vafai  <ojan@chromium.org>
750
751         Reviewed by Tony Chang.
752
753         final tests for results.html file
754         https://bugs.webkit.org/show_bug.cgi?id=59150
755
756         This gets us close to 100% code coverage. Once this is
757         checked in, I'll move this file over to LayoutTests/fast/harness
758         and make it a proper layout test.
759
760         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
761         * Scripts/webkitpy/layout_tests/layout_package/json_results_test.js:
762
763 2011-04-21  Ojan Vafai  <ojan@chromium.org>
764
765         Reviewed by Tony Chang.
766
767         only expand visible rows
768         https://bugs.webkit.org/show_bug.cgi?id=59130
769
770         For the chromium port, where there are many expected failures,
771         expanding all of them is quite slow. Only expand the visible ones.
772         This makes the default case. Also, make the expanding async to
773         avoid totally killing the process.
774
775         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
776         * Scripts/webkitpy/layout_tests/layout_package/json_results_test.js:
777
778 2011-04-21  Martin Robinson  <mrobinson@igalia.com>
779
780         [GTK] DRT: implement eventSender.scalePageBy
781         https://bugs.webkit.org/show_bug.cgi?id=59082
782
783         Rolling out r84507 since it broke many GTK+ tests.
784
785         * DumpRenderTree/gtk/EventSender.cpp:
786
787 2011-04-21  Sam Weinig  <sam@webkit.org>
788
789         Reviewed by Simon Fraser.
790
791         Add way to garbage collect between each test when running layout tests
792         https://bugs.webkit.org/show_bug.cgi?id=59126
793
794         * DumpRenderTree/mac/DumpRenderTree.mm:
795         (initializeGlobalsFromCommandLineOptions):
796         (runTest):
797         * Scripts/old-run-webkit-tests:
798         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
799         (WTR::InjectedBundle::didReceiveMessage):
800         * WebKitTestRunner/TestController.cpp:
801         (WTR::TestController::TestController):
802         (WTR::TestController::initialize):
803         (WTR::TestController::resetStateToConsistentValues):
804         * WebKitTestRunner/TestController.h:
805
806 2011-04-21  Ojan Vafai  <ojan@chromium.org>
807
808         Reviewed by Mihai Parparita.
809
810         fix another innocuous JS error in expand/collapseAllExpectations
811         https://bugs.webkit.org/show_bug.cgi?id=59122
812
813         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
814         * Scripts/webkitpy/layout_tests/layout_package/json_results_test.js:
815
816 2011-04-20  Ojan Vafai  <ojan@chromium.org>
817
818         Reviewed by Tony Chang.
819
820         put unexpected passes into their own table
821         https://bugs.webkit.org/show_bug.cgi?id=59016
822
823         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
824
825 2011-04-20  Ojan Vafai  <ojan@chromium.org>
826
827         Reviewed by Tony Chang.
828
829         initial set of tests for new results.html file
830         https://bugs.webkit.org/show_bug.cgi?id=59031
831
832         Also, fix the bugs (mostly innocuous JS errors) the tests found.
833
834         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
835         * Scripts/webkitpy/layout_tests/layout_package/json_results_test.js: Added.
836
837 2011-04-21  Philippe Normand  <pnormand@igalia.com>
838
839         Reviewed by Martin Robinson.
840
841         [GTK] missing LayoutTestController::callShouldCloseOnWebView()
842         https://bugs.webkit.org/show_bug.cgi?id=59086
843
844         callShouldCloseOnWebView() implementation.
845
846         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
847         (LayoutTestController::callShouldCloseOnWebView):
848
849 2011-04-21  Philippe Normand  <pnormand@igalia.com>
850
851         Reviewed by Martin Robinson.
852
853         [GTK] DRT: implement eventSender.scalePageBy
854         https://bugs.webkit.org/show_bug.cgi?id=59082
855
856         * DumpRenderTree/gtk/EventSender.cpp:
857         (scalePageByCallback): scalePageBy() support.
858
859 2011-04-20  Dominic Cooney  <dominicc@chromium.org>
860
861         Reviewed by Dimitri Glazkov.
862
863         layoutTestController can create and destroy shadow DOM
864         https://bugs.webkit.org/show_bug.cgi?id=59058
865
866         Chromium, Mac, GTK and Qt DRT; and WK2 test runner.
867
868         * DumpRenderTree/LayoutTestController.cpp:
869         (ensureShadowRootCallback):
870         (removeShadowRootCallback):
871         (LayoutTestController::staticFunctions):
872         * DumpRenderTree/LayoutTestController.h:
873         * DumpRenderTree/chromium/LayoutTestController.cpp:
874         (LayoutTestController::LayoutTestController):
875         (LayoutTestController::ensureShadowRoot):
876         (LayoutTestController::removeShadowRoot):
877         * DumpRenderTree/chromium/LayoutTestController.h:
878         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
879         (LayoutTestController::ensureShadowRoot):
880         (LayoutTestController::removeShadowRoot):
881         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
882         (LayoutTestController::shadowRoot):
883         (LayoutTestController::ensureShadowRoot):
884         (LayoutTestController::removeShadowRoot):
885         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
886         (LayoutTestController::ensureShadowRoot):
887         (LayoutTestController::removeShadowRoot):
888         * DumpRenderTree/qt/LayoutTestControllerQt.h:
889         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
890         (LayoutTestController::ensureShadowRoot):
891         (LayoutTestController::removeShadowRoot):
892         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
893         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
894         (WTR::LayoutTestController::shadowRoot):
895         (WTR::LayoutTestController::ensureShadowRoot):
896         (WTR::LayoutTestController::removeShadowRoot):
897         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
898
899 2011-04-20  Dirk Pranke  <dpranke@chromium.org>
900
901         Reviewed by Eric Seidel.
902
903         new-run-webkit-tests: handle ctrl-c more cleanly
904         https://bugs.webkit.org/show_bug.cgi?id=58849
905
906         * Scripts/new-run-webkit-tests:
907         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
908
909 2011-04-20  Sheriff Bot  <webkit.review.bot@gmail.com>
910
911         Unreviewed, rolling out r84431.
912         http://trac.webkit.org/changeset/84431
913         https://bugs.webkit.org/show_bug.cgi?id=59061
914
915         Breaks for folks who don't have editbugs (Requested by abarth
916         on #webkit).
917
918         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
919         * Scripts/webkitpy/tool/commands/upload_unittest.py:
920         * Scripts/webkitpy/tool/mocktool.py:
921         * Scripts/webkitpy/tool/steps/postdiff.py:
922
923 2011-04-20  Leo Yang  <leo.yang@torchmobile.com.cn>
924
925         Unreviewed.
926
927         Adding myself to committers.py.
928
929         * Scripts/webkitpy/common/config/committers.py:
930
931 2011-04-20  Adam Barth  <abarth@webkit.org>
932
933         Reviewed by Eric Seidel.
934
935         webkit-patch upload should assign the bug to you
936         https://bugs.webkit.org/show_bug.cgi?id=33699
937
938         This patch only re-assigns the bug if it is currently unassigned.  We
939         can be more aggressive in the future if people want us to be more
940         agressive.
941
942         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
943         * Scripts/webkitpy/tool/commands/upload_unittest.py:
944         * Scripts/webkitpy/tool/mocktool.py:
945         * Scripts/webkitpy/tool/steps/postdiff.py:
946
947 2011-04-20 Peter Gal <galpeter@inf.u-szeged.hu>
948
949         Reviewed by Csaba Osztrogonác.
950
951         Modify builder.html template to allow easy access
952         to list more builds on the builder's page.
953
954         https://bugs.webkit.org/show_bug.cgi?id=59008
955
956         * BuildSlaveSupport/build.webkit.org-config/templates/builder.html:
957
958 2011-04-20  Peter Gal  <galpeter@inf.u-szeged.hu>
959
960         Reviewed by Csaba Osztrogonác.
961
962         Add the default template for builder page.
963
964         https://bugs.webkit.org/show_bug.cgi?id=59008
965
966         * BuildSlaveSupport/build.webkit.org-config/templates/builder.html: Added.
967
968 2011-04-20  Ojan Vafai  <ojan@chromium.org>
969
970         Reviewed by Eric Seidel.
971
972         move page generation into a single function
973         https://bugs.webkit.org/show_bug.cgi?id=59027
974
975         Now executing the script doesn't create any state. We should then
976         be able to write tests for this by setting custom results data.
977
978         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
979
980 2011-04-20  Ojan Vafai  <ojan@chromium.org>
981
982         Reviewed by Eric Seidel.
983
984         move global state into a shared object
985         https://bugs.webkit.org/show_bug.cgi?id=59023
986
987         This makes the code more testable.
988
989         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
990
991 2011-04-20  Ojan Vafai  <ojan@chromium.org>
992
993         Reviewed by Tony Chang.
994
995         move global state into a shared object
996         https://bugs.webkit.org/show_bug.cgi?id=59023
997
998         This makes the code more testable.
999
1000         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
1001
1002 2011-04-20  Ojan Vafai  <ojan@chromium.org>
1003
1004         Reviewed by Eric Seidel.
1005
1006         add expandAll/collapseAll links
1007         https://bugs.webkit.org/show_bug.cgi?id=59011
1008
1009         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
1010
1011 2011-04-20  Kevin Ollivier  <kevino@theolliviers.com>
1012
1013         [wx] Unreviewed build fixes for wx 2.9.1, Cocoa and 64-bit builds.
1014
1015         * Scripts/webkitdirs.pm:
1016         * wx/build/build_utils.py:
1017         * wx/build/settings.py:
1018         * wx/install-unix-extras:
1019         * wx/packaging/build-mac-installer.py:
1020         * wx/packaging/build-win-installer.py:
1021
1022 2011-04-20  Adam Roben  <aroben@apple.com>
1023
1024         Replace old-run-webkit-tests's win-7 platform with win-7sp0
1025
1026         It was an error that we had a win-7 platform to begin with. Windows 7 was the most recent
1027         version of Windows we cared about, so its results should just go in win. But now that
1028         Windows 7 SP1 exists (and has different results for some tests), we need a place to store
1029         results for Windows 7 without SP1 (and older versions of Windows).
1030
1031         Part of <http://webkit.org/b/56617> Several tests fail on Windows 7 SP1 due to font
1032         differences from Windows 7 "SP0"
1033
1034         Reviewed by David Kilzer.
1035
1036         * Scripts/old-run-webkit-tests: Replaced win-7 with win-7sp0. Newer versions of Windows 7
1037         will just use "win".
1038
1039         * Scripts/webkitdirs.pm:
1040         (isWindows7SP0): Added. Replaces isWindows7, because that function had no remaining callers.
1041
1042 2011-04-20  Adam Roben  <aroben@apple.com>
1043
1044         Teach webkitdirs::winVersion about build numbers
1045
1046         The build number isn't currently used, but soon will be.
1047
1048         As a bonus, winVersion now works on non-Cygwin variants of Perl!
1049
1050         Fixes <http://webkit.org/b/58991> Need a way to distinguish between Windows 7 and Windows 7
1051         SP1
1052
1053         Reviewed by Anders Carlsson.
1054
1055         * Scripts/webkitdirs.pm:
1056         (isAnyWindows): Added. Returns true if we're running on any Windows-ish Perl.
1057         (determineWinVersion): Use `cmd /c ver` to get the version number, including the build
1058         number. Parse the version number into a hash, similar to how osXVersion() works.
1059
1060         (isWindows7):
1061         (isWindowsVista):
1062         (isWindowsXP):
1063         Updated for changes to winVersion().
1064
1065 2011-04-20  W. James MacLean  <wjmaclean@chromium.org>
1066
1067         Reviewed by Kenneth Russell.
1068
1069         Add support for composite-to-texture to DumpRenderTree.
1070         https://bugs.webkit.org/show_bug.cgi?id=58675
1071
1072         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1073         (main):
1074         * DumpRenderTree/chromium/TestShell.cpp:
1075         (TestShell::TestShell):
1076         (TestShell::resetWebSettings):
1077         * DumpRenderTree/chromium/TestShell.h:
1078         (TestShell::setCompositeToTexture):
1079         * DumpRenderTree/chromium/WebPreferences.cpp:
1080         (WebPreferences::reset):
1081         (WebPreferences::applyTo):
1082         * DumpRenderTree/chromium/WebPreferences.h:
1083
1084 2011-04-19  Eric Seidel  <eric@webkit.org>
1085
1086         Reviewed by Adam Barth.
1087
1088         The commit-queue is confused when non-layout tests fail
1089         https://bugs.webkit.org/show_bug.cgi?id=58955
1090
1091         As seen in http://queues.webkit.org/results/8474435
1092
1093         It fails to create an archive of the layout test results
1094         and then throws an exception.
1095
1096         I've fixed this by making it catch the exception as well
1097         as made it so it never calls that path in the common case.
1098
1099         I've updated MockFileSystem to understand rmtree's affect on
1100         directories as well as files.
1101
1102         * Scripts/webkitpy/common/system/filesystem_mock.py:
1103         * Scripts/webkitpy/common/system/workspace.py:
1104         * Scripts/webkitpy/tool/commands/queues.py:
1105         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1106         * Scripts/webkitpy/tool/mocktool.py:
1107
1108 2011-04-19  Ojan Vafai  <ojan@chromium.org>
1109
1110         Fix check for whether a failure is expected to deal with
1111         flaky tests and FAIL expectations.
1112         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
1113
1114 2011-04-19  Ojan Vafai  <ojan@chromium.org>
1115
1116         Reviewed by Eric Seidel.
1117
1118         don't show missing text results for tests that only dump image results
1119         https://bugs.webkit.org/show_bug.cgi?id=58931
1120
1121         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
1122         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1123
1124 2011-04-19  Ojan Vafai  <ojan@chromium.org>
1125
1126         Reviewed by Eric Seidel.
1127
1128         don't show failures table if there are only new tests
1129         https://bugs.webkit.org/show_bug.cgi?id=58929
1130
1131         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
1132
1133 2011-04-19  Ojan Vafai  <ojan@chromium.org>
1134
1135         Reviewed by Eric Seidel.
1136
1137         don't show failures table if there are only new tests
1138         https://bugs.webkit.org/show_bug.cgi?id=58929
1139
1140         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
1141
1142 2011-04-19  Ojan Vafai  <ojan@chromium.org>
1143
1144         Fix unittest failures from http://trac.webkit.org/changeset/84294.
1145
1146         * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
1147         * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
1148
1149 2011-04-18  Ojan Vafai  <ojan@chromium.org>
1150
1151         Reviewed by Eric Seidel.
1152
1153         switch new-run-webkit-tests to using the new results file
1154         https://bugs.webkit.org/show_bug.cgi?id=58861
1155
1156         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1157         * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
1158         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1159
1160 2011-04-19  Renata Hodovan  <reni@webkit.org>
1161
1162         Reviewed by Eric Seidel.
1163
1164         Move the alignment related macros from Vector.h to new Alignment.h.
1165         https://bugs.webkit.org/show_bug.cgi?id=56000
1166
1167         Adding the new file to the forwarding headers of Tools.
1168
1169         * DumpRenderTree/ForwardingHeaders/wtf/Alignment.h: Added.
1170
1171 2011-04-19  Kevin Ollivier  <kevino@theolliviers.com>
1172
1173         [wx] Unreviewed build fix for Win / wx 2.9 wxPython installation.
1174
1175         * wx/packaging/build-win-installer.py:
1176         * wx/packaging/wxWebKitInstaller.iss.in:
1177
1178 2011-04-19  Adam Roben  <aroben@apple.com>
1179
1180         Skip another accelerated-compositing-sensitive test when accelerated compositing is disabled
1181
1182         * Scripts/old-run-webkit-tests: Skip media/controls-without-preload.html on Windows when
1183         accelerated compositing is disabled.
1184
1185 2011-04-19  Ojan Vafai  <ojan@chromium.org>
1186
1187         Remove accidentally committed debug code.
1188         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1189
1190 2011-04-19  Brent Fulgham  <bfulgham@webkit.org>
1191
1192         Unreviewed build correction.
1193
1194         Avoid duplicate stub implementation of test routine
1195         for WinCairo build.
1196
1197         * WebKitTestRunner/win/TestInvocationWin.cpp: Exclude
1198         WinCairo from using this stub.
1199
1200 2011-04-18  Ojan Vafai  <ojan@chromium.org>
1201
1202         Reviewed by Eric Seidel.
1203
1204         make results file work with audio and reftests
1205         https://bugs.webkit.org/show_bug.cgi?id=58860
1206
1207         Also fix bug with timeout tests and store a bit in the JSON
1208         for new image tests instead of loading the image result to check if it's there.
1209
1210         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
1211         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1212
1213 2011-04-19  Jer Noble  <jer.noble@apple.com>
1214
1215         Reviewed by Adam Roben.
1216
1217         REGRESSION (r84206): 50 tests failing on SnowLeopard Intel Release (WebKit2 Tests) due to extra "supportsFullScreen() == true" output
1218         https://bugs.webkit.org/show_bug.cgi?id=58890
1219
1220         Add a layoutTestController flag which controls when full screen callbacks are written to stdout.
1221         Defaults to false.
1222
1223         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Added dumpFullScreenCallbacks().
1224         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1225         (WTR::InjectedBundlePage::supportsFullScreen): Only write to stdout if shouldDumpFullScreenCallbacks is set.
1226         (WTR::InjectedBundlePage::enterFullScreenForElement): Ditto.
1227         (WTR::InjectedBundlePage::exitFullScreenForElement): Ditto.
1228         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1229         (WTR::LayoutTestController::LayoutTestController): Initialize new ivar.
1230         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1231         (WTR::LayoutTestController::dumpFullScreenCallbacks): Added.
1232         (WTR::LayoutTestController::shouldDumpFullScreenCallbacks): Added.
1233
1234 2011-04-19  Kristóf Kosztyó  <Kosztyo.Kristof@stud.u-szeged.hu>
1235
1236         Reviewed by Andreas Kling.
1237
1238         [Qt] fast/xmlhttprequest/xmlhttprequest-nonexistent-file.html fails (DRT sideeffect)
1239         https://bugs.webkit.org/show_bug.cgi?id=35086
1240
1241         fast/xmlhttprequest/xmlhttprequest-no-file-access.html caused
1242         a DRT sideeffect problem, because the resetSettings didn't set
1243         the default value of LocalContentCanAccessFileUrls.
1244
1245         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1246         (WebCore::WebPage::resetSettings):
1247
1248 2011-04-18  Zan Dobersek  <zandobersek@gmail.com>
1249
1250         Reviewed by Martin Robinson.
1251
1252         [GTK] Need support for dumping focus rectangles in pixel results
1253         https://bugs.webkit.org/show_bug.cgi?id=53647
1254
1255         Dump the selection rect if it has been requested.
1256
1257         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
1258         (createBitmapContextFromWebView):
1259
1260 2011-04-18  Eric Seidel  <eric@webkit.org>
1261
1262         Reviewed by Adam Barth.
1263
1264         test-webkitpy should run the ActiveWorkItems tests
1265         https://bugs.webkit.org/show_bug.cgi?id=58859
1266
1267         Also make the unit tests pass. :)
1268
1269         * QueueStatusServer/model/activeworkitems.py:
1270         * QueueStatusServer/model/queue.py:
1271         * QueueStatusServer/model/workitems.py:
1272
1273 2011-04-18  Eric Seidel  <eric@webkit.org>
1274
1275         Reviewed by Adam Barth.
1276
1277         queues.webkit.org should show trailing-days pass counts for queues
1278         https://bugs.webkit.org/show_bug.cgi?id=58812
1279
1280         This lets us see if each bot is pulling its own weight or not.
1281         Before I wrote this patch our suspicious was that one of the
1282         cq bots was doing most of the work.  Turns out they're actually
1283         pretty even in their recent pass counts.
1284
1285         * QueueStatusServer/handlers/queuestatus.py:
1286         * QueueStatusServer/index.yaml:
1287         * QueueStatusServer/templates/queuestatus.html:
1288
1289 2011-04-18  Dirk Pranke  <dpranke@chromium.org>
1290
1291         Reviewed by Eric Seidel.
1292
1293         new-run-webkit-tests: obsolete old threading code, part 1
1294         https://bugs.webkit.org/show_bug.cgi?id=58752
1295
1296         This patch removes support for the 'old-inline' and
1297         'old-threads' worker models, and deletes the corresponding code.
1298         Now that the new code is stable, this stuff is no longer
1299         necessary.
1300
1301         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py: Removed.
1302         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py: Removed.
1303         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py: Removed.
1304         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1305         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1306         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1307
1308 2011-04-18  Dirk Pranke  <dpranke@chromium.org>
1309
1310         Reviewed by Eric Seidel.
1311
1312         new-run-webkit-tests: add an --additional-drt-flag option
1313         https://bugs.webkit.org/show_bug.cgi?id=58680
1314
1315         NRWT has a bunch of command line flags that exist to pass
1316         custom flags to DRT, especially on chromium. It would be nice
1317         if there was a generic mechanism to pass through flags so we
1318         didn't have all the custom ones.
1319
1320         * Scripts/webkitpy/layout_tests/port/chromium.py:
1321         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
1322         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1323         * Scripts/webkitpy/layout_tests/port/test.py:
1324         * Scripts/webkitpy/layout_tests/port/webkit.py:
1325         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1326
1327 2011-04-05  Jer Noble  <jer.noble@apple.com>
1328
1329         Reviewed by Sam Weinig.
1330
1331         WebKit2: WKTR should support WebKit2 full screen APIs
1332         https://bugs.webkit.org/show_bug.cgi?id=56318
1333
1334         Respond to enterFullScreenForElement() and exitFullScreenForElement(), allowing 
1335         WKTR to test the LayoutTest/fullscreen/ tests.
1336
1337         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1338         (WTR::InjectedBundlePage::InjectedBundlePage): Add support for WKBundlePageFullScreenClient.
1339         (WTR::InjectedBundlePage::supportsFullScreen): Added.
1340         (WTR::InjectedBundlePage::enterFullScreenForElement): Added.
1341         (WTR::InjectedBundlePage::exitFullScreenForElement): Added.
1342         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1343         * WebKitTestRunner/TestController.cpp:
1344         (WTR::TestController::resetStateToConsistentValues): Enable the full screen preference.
1345
1346 2011-04-18  Dirk Pranke  <dpranke@chromium.org>
1347
1348         Reviewed by Tony Chang.
1349
1350         new-run-webkit-tests: remove chromium-specific relpath hack for --results-directory
1351         https://bugs.webkit.org/show_bug.cgi?id=58388
1352
1353         * Scripts/webkitpy/layout_tests/port/chromium.py:
1354
1355 2011-04-18  Evan Martin  <evan@chromium.org>
1356
1357         Reviewed by Eric Seidel.
1358
1359         [chromium] expose title direction to webkit client
1360         https://bugs.webkit.org/show_bug.cgi?id=58823
1361
1362         * DumpRenderTree/chromium/LayoutTestController.cpp:
1363         (LayoutTestController::LayoutTestController):
1364         (LayoutTestController::reset):
1365         * DumpRenderTree/chromium/LayoutTestController.h:
1366         (LayoutTestController::setTitleTextDirection):
1367         Add member and setter to let us stash the title direction at load time.
1368
1369         * DumpRenderTree/chromium/WebViewHost.cpp:
1370         (WebViewHost::didReceiveTitle):
1371         * DumpRenderTree/chromium/WebViewHost.h:
1372         Adapt to new API; push the title into layoutTestController when we
1373         receive it.
1374
1375 2011-04-18  Dirk Pranke  <dpranke@chromium.org>
1376
1377         Unreviewed.
1378
1379         Re-land r84112. It was rolled out in r84127 but it didn't need
1380         to be. Only r84111 actually broke things.
1381
1382         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
1383         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1384
1385 2011-04-18  Dirk Pranke  <dpranke@chromium.org>
1386
1387         Reviewed by Tony Chang.
1388
1389         new-run-webkit-tests: don't run more processes than necessary
1390         https://bugs.webkit.org/show_bug.cgi?id=58751
1391
1392         Previously NRWT would start up 1 process for each processor on
1393         the machine by default, which was a waste if we were only
1394         running a few shards of tests.
1395
1396         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1397         * Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
1398         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1399
1400 2011-04-18  Ojan Vafai  <ojan@chromium.org>
1401
1402         Reviewed by Eric Seidel.
1403
1404         include links to actual.png files for new pixel tests
1405         https://bugs.webkit.org/show_bug.cgi?id=58831
1406
1407         Load image elements to confirm whether the files exist.
1408         Image elements will load without being appended to the DOM.
1409
1410         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
1411
1412 2011-04-18  Ojan Vafai  <ojan@chromium.org>
1413
1414         Reviewed by Eric Seidel.
1415
1416         add a zoomed view for pixel results to the new results html file
1417         https://bugs.webkit.org/show_bug.cgi?id=58827
1418
1419         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
1420
1421 2011-04-18  Ojan Vafai  <ojan@chromium.org>
1422
1423         Reviewed by Eric Seidel.
1424
1425         add labels to results html page
1426         https://bugs.webkit.org/show_bug.cgi?id=58803
1427
1428         -fix iframe size to be the size of the png results
1429         -fix a bunch of aesthetic nits
1430         -fix some incorrectly styled code
1431
1432         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
1433
1434 2011-04-18  Chang Shu  <cshu@webkit.org>
1435
1436         Reviewed by Eric Seidel.
1437
1438         WebKitTestRunner needs layoutTestController.pathToLocalResource
1439         https://bugs.webkit.org/show_bug.cgi?id=42541
1440
1441         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1442         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1443         * WebKitTestRunner/InjectedBundle/mac/LayoutTestControllerMac.mm:
1444         (WTR::LayoutTestController::pathToLocalResource):
1445         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
1446         (WTR::LayoutTestController::pathToLocalResource):
1447         * WebKitTestRunner/InjectedBundle/win/LayoutTestControllerWin.cpp:
1448         (WTR::LayoutTestController::pathToLocalResource):
1449
1450 2011-04-18  Timothy Hatcher  <timothy@apple.com>
1451
1452         Make update-webkit-localizable-strings put WebKit/win strings in WebCore
1453         now that all localized strings in WebKit/win use WEB_UI_STRING.
1454
1455         https://webkit.org/b/58747
1456
1457         Reviewed by Dan Bernstein.
1458
1459         * Scripts/update-webkit-localizable-strings: Remove the code that updated WebKit/win differently.
1460
1461 2011-04-18  Patrick Gansterer  <paroga@webkit.org>
1462
1463         Reviewed by Adam Roben.
1464
1465         [WIN] Use WCHAR instead of TCHAR
1466         https://bugs.webkit.org/show_bug.cgi?id=58755
1467
1468         We always use the UNICODE versions of windows functions, so
1469         the usage of TCHAR makes no sense and mixing them is bad style.
1470
1471         * WinLauncher/PrintWebUIDelegate.cpp:
1472           Also fix various style issues (including indentation and removal of ugly C-casts).
1473         * WinLauncher/WinLauncher.cpp:
1474
1475 2011-04-18  Dominic Cooney  <dominicc@chromium.org>
1476
1477         Reviewed by Andreas Kling.
1478
1479         Add layoutTestController.shadowRoot to Qt DRT.
1480         https://bugs.webkit.org/show_bug.cgi?id=58759
1481
1482         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1483         (LayoutTestController::shadowRoot): Added.
1484         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1485
1486 2011-04-18  Sheriff Bot  <webkit.review.bot@gmail.com>
1487
1488         Unreviewed, rolling out r84111.
1489         http://trac.webkit.org/changeset/84111
1490         https://bugs.webkit.org/show_bug.cgi?id=58771
1491
1492         Chromium linux layout tests are broken. (Requested by loislo2
1493         on #webkit).
1494
1495         * Scripts/webkitpy/layout_tests/port/chromium.py:
1496         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1497         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
1498
1499 2011-04-18  Sheriff Bot  <webkit.review.bot@gmail.com>
1500
1501         Unreviewed, rolling out r84112.
1502         http://trac.webkit.org/changeset/84112
1503         https://bugs.webkit.org/show_bug.cgi?id=58770
1504
1505         Chromium linux layout tests are broken. (Requested by loislo2
1506         on #webkit).
1507
1508         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
1509         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1510
1511 2011-04-17  Daniel Bates  <dbates@webkit.org>
1512
1513         Reviewed by Eric Seidel and Adam Barth.
1514
1515         webkit-patch land hangs if svn prompts for credentials
1516         https://bugs.webkit.org/show_bug.cgi?id=31500
1517
1518         Prompt for username and password when using git-svn and there aren't cached SVN credentials.
1519
1520         * Scripts/webkitpy/common/checkout/scm.py:
1521           - Added mixin class SVNRepository and made both class SVN and Git inherit from it.
1522           - Moved SVN.has_authorization_for_realm() to class SVNRepository and removed default value
1523             for argument realm; modified call sites as needed.
1524           - Modified AuthenticationError constructor to take optional prompt_for_password argument.
1525           - Modified {SCM, SVN, Git}.commit_with_message() to take optional password argument.
1526           - Modified Git._commit_on_branch() to take optional username and password argument.
1527           - Modified Git.push_local_commits_to_server() to take optional username and password
1528             argument and to call has_authorization_for_realm().
1529         * Scripts/webkitpy/common/checkout/scm_unittest.py:
1530           - Modified SVNTest.test_commit_without_authorization() to take dummy realm argument.
1531           - Modified SVNTest.test_not_have_authorization_for_realm() to pass realm argument to
1532             SVN.has_authorization_for_realm().
1533         * Scripts/webkitpy/common/net/credentials.py:
1534           - Modified Credentials.read_credentials() to call User.prompt_password() instead
1535             of using getpass.getpass() directly.
1536         * Scripts/webkitpy/common/system/user.py:
1537           - Added User.prompt_password().
1538         * Scripts/webkitpy/tool/steps/commit.py:
1539           - Modified Commit.run() to prompt for a password if needed.
1540
1541 2011-04-17  Dirk Pranke  <dpranke@chromium.org>
1542
1543         Reviewed by Ojan Vafai.
1544
1545         new-run-webkit-tests: save stderr into the layout-test-results dir
1546         https://bugs.webkit.org/show_bug.cgi?id=58690
1547
1548         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
1549         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1550
1551 2011-04-17  Dirk Pranke  <dpranke@chromium.org>
1552
1553         Reviewed by Ojan Vafai.
1554
1555         new-run-webkit-tests: read stderr from chromium DRT separately
1556         https://bugs.webkit.org/show_bug.cgi?id=58708
1557
1558         * Scripts/webkitpy/layout_tests/port/chromium.py:
1559         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1560         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
1561
1562 2011-04-17  Patrick Gansterer  <paroga@webkit.org>
1563
1564         Reviewed by Adam Barth.
1565
1566         Rename PLATFORM(CA) to USE(CA)
1567         https://bugs.webkit.org/show_bug.cgi?id=58742
1568
1569         * DumpRenderTree/mac/DumpRenderTree.mm:
1570         (resetDefaultsToConsistentValues):
1571
1572 2011-04-17  Patrick Gansterer  <paroga@webkit.org>
1573
1574         Reviewed by Adam Barth.
1575
1576         Rename PLATFORM(CG) to USE(CG)
1577         https://bugs.webkit.org/show_bug.cgi?id=58729
1578
1579         * DumpRenderTree/PixelDumpSupport.cpp:
1580         * DumpRenderTree/chromium/WebViewHost.cpp:
1581         (WebViewHost::paintRect):
1582         * DumpRenderTree/config.h:
1583         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
1584         (createBitmapContextFromWebView):
1585         * TestWebKitAPI/PlatformWebView.h:
1586         * WebKitTestRunner/config.h:
1587         * WebKitTestRunner/win/TestInvocationWin.cpp:
1588
1589 2011-04-16  Patrick Gansterer  <paroga@webkit.org>
1590
1591         Reviewed by Eric Seidel.
1592
1593         Rename PLATFORM(CAIRO) to USE(CAIRO)
1594         https://bugs.webkit.org/show_bug.cgi?id=55192
1595
1596         * DumpRenderTree/PixelDumpSupport.cpp:
1597         * DumpRenderTree/config.h:
1598         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
1599         (createBitmapContextFromWebView):
1600         * WebKitTestRunner/config.h:
1601
1602 2011-04-16  Ojan Vafai  <ojan@chromium.org>
1603
1604         Reviewed by Eric Seidel.
1605
1606         show diffs+test inline in the results page
1607         https://bugs.webkit.org/show_bug.cgi?id=58723
1608         
1609         Put each row in it's own tbody and sort based on tbodies. That way
1610         we can append the results to the tbody inline as another table row.
1611
1612         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
1613
1614 2011-04-16  Ojan Vafai  <ojan@chromium.org>
1615
1616         Reviewed by Eric Seidel.
1617
1618         handle new tests in the new results html file
1619         https://bugs.webkit.org/show_bug.cgi?id=58715
1620
1621         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
1622
1623 2011-04-15  Dirk Pranke  <dpranke@chromium.org>
1624
1625         Reviewed by Ojan Vafai.
1626
1627         old-run-webkit-tests: save the list of tests actually run to a file
1628         https://bugs.webkit.org/show_bug.cgi?id=58692
1629
1630         * Scripts/old-run-webkit-tests:
1631
1632 2011-04-15  Dirk Pranke  <dpranke@chromium.org>
1633
1634         Reviewed by Ojan Vafai.
1635
1636         fix MockFileSystem.abspath() on windows
1637         https://bugs.webkit.org/show_bug.cgi?id=58713
1638
1639         The existing code was borked on Windows if a path was passed
1640         in using a drive letter (e.g., "d:\foo.txt"), and would go
1641         into an infinite recursive loop. While win paths shouldn't
1642         normally be passed into the mock filesystem, this just
1643         bulletproofs things a bit (note that "/foo.txt" is considered
1644         an absolute path on windows python as well.
1645
1646         * Scripts/webkitpy/common/system/filesystem_mock.py:
1647
1648 2011-04-15  Ojan Vafai  <ojan@chromium.org>
1649
1650         Reviewed by Eric Seidel.
1651
1652         show stderr files and httpd log files
1653         https://bugs.webkit.org/show_bug.cgi?id=58714
1654
1655         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
1656         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1657
1658 2011-04-15  Shishir Agrawal  <shishir@chromium.org>
1659
1660         Reviewed by James Robinson.
1661
1662         Add a flag to guard Page Visibility API changes.
1663         https://bugs.webkit.org/show_bug.cgi?id=58464
1664
1665         * Scripts/build-webkit:
1666
1667 2011-04-15  Chang Shu  <cshu@webkit.org>
1668
1669         Reviewed by Alexey Proskuryakov.
1670
1671         When a message with url embedded is added to console, the "file:" scheme
1672         and path should be stripped.
1673         https://bugs.webkit.org/show_bug.cgi?id=58665
1674
1675         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1676         (WTR::lastFileURLPathComponent):
1677         (WTR::InjectedBundlePage::willAddMessageToConsole):
1678
1679 2011-04-15  Jeff Miller  <jeffm@apple.com>
1680
1681         Reviewed by Sam Weinig.
1682
1683         Add takeFocus callback to WKPageUIClient
1684         https://bugs.webkit.org/show_bug.cgi?id=58686
1685
1686         Add empty WKPageUIClient entries for the takeFocus callback in the MiniBrowser and WebKitTestRunner.
1687
1688         * MiniBrowser/mac/BrowserWindowController.m:
1689         (-[BrowserWindowController awakeFromNib]): Added empty takeFocus entry.
1690         * MiniBrowser/win/BrowserView.cpp:
1691         (BrowserView::create): Added empty takeFocus entry.
1692         * WebKitTestRunner/TestController.cpp:
1693         (WTR::TestController::createOtherPage): Added empty takeFocus entry.
1694         (WTR::TestController::initialize): Added empty takeFocus entry.
1695
1696 2011-04-15  Ojan Vafai  <ojan@chromium.org>
1697
1698         Reviewed by Eric Seidel.
1699
1700         only show pretty-diff/wdiff if they were generated
1701         https://bugs.webkit.org/show_bug.cgi?id=58682
1702
1703         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
1704         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1705         * Scripts/webkitpy/layout_tests/port/base.py:
1706
1707 2011-04-15  Andreas Kling  <kling@webkit.org>
1708
1709         Reviewed by Antonio Gomes.
1710
1711         [Qt] DRT: Default custom policy delegate decision should be Ignore.
1712
1713         If layoutTestController.setCustomPolicyDelegate() is called with only
1714         one argument, the second ("permissive") should default to false.
1715
1716         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1717
1718 2011-04-15  Ojan Vafai  <ojan@chromium.org>
1719
1720         Reviewed by Eric Seidel.
1721
1722         fix path to layout test in new results file
1723         https://bugs.webkit.org/show_bug.cgi?id=58618
1724
1725         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
1726         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1727
1728 2011-04-15  Ojan Vafai  <ojan@chromium.org>
1729
1730         Reviewed by Eric Seidel.
1731
1732         fix sorting in new results file
1733         https://bugs.webkit.org/show_bug.cgi?id=58616
1734
1735         -Fix the custom sort to return -1, 0, 1 instead of true/false.
1736         -Secondary sort by test name when sort values are equal.
1737         -Sort by test name by default.
1738
1739         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
1740
1741 2011-04-15  Dmitry Lomov  <dslomov@google.com>
1742
1743         Reviewed by David Levin.
1744
1745         check-webkit-style shouldn't complain about not including a primary header file 
1746         if none exists
1747         https://bugs.webkit.org/show_bug.cgi?id=39514
1748
1749         * Scripts/webkitpy/style/checkers/cpp.py:
1750         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1751
1752 2011-04-15  Eric Seidel  <eric@webkit.org>
1753
1754         Reviewed by Mihai Parparita.
1755
1756         queues.webkit.org should display when a bot last rebooted
1757         https://bugs.webkit.org/show_bug.cgi?id=58562
1758
1759         There is more repeated code here than I would like.  I fear
1760         my django-fu isn't quite up to snuff.
1761
1762         * QueueStatusServer/handlers/queuestatus.py:
1763         * QueueStatusServer/templates/queuestatus.html:
1764
1765 2011-04-14  Alok Priyadarshi  <alokp@chromium.org>
1766
1767         Reviewed by Adam Barth.
1768
1769         Remove dependency on chromium skia::PlatformCanvas
1770         https://bugs.webkit.org/show_bug.cgi?id=57563
1771         
1772         Fixed compile error on Mac when using Core Graphics.
1773
1774         * DumpRenderTree/chromium/WebViewHost.cpp:
1775         (WebViewHost::paintRect):
1776
1777 2011-04-14  Alok Priyadarshi  <alokp@chromium.org>
1778
1779         Reviewed by James Robinson.
1780
1781         Remove dependency on chromium skia::PlatformCanvas
1782         https://bugs.webkit.org/show_bug.cgi?id=57563
1783
1784         * DumpRenderTree/chromium/TestShell.cpp:
1785         (makeCanvasOpaque):
1786         (TestShell::dumpImage):
1787         * DumpRenderTree/chromium/TestShell.h:
1788         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp:
1789         (WebThemeControlDRTWin::WebThemeControlDRTWin):
1790         (WebThemeControlDRTWin::draw):
1791         (WebThemeControlDRTWin::drawTextField):
1792         (WebThemeControlDRTWin::drawProgressBar):
1793         * DumpRenderTree/chromium/WebThemeControlDRTWin.h:
1794         * DumpRenderTree/chromium/WebViewHost.cpp:
1795         (WebViewHost::canvas):
1796         * DumpRenderTree/chromium/WebViewHost.h:
1797
1798 2011-04-14  Keith Kyzivat  <keith.kyzivat@nokia.com>
1799
1800         Reviewed by Laszlo Gombos.
1801
1802         [Qt] Add -maximize flag to QtTestBrowser and MiniBrowser
1803         https://bugs.webkit.org/show_bug.cgi?id=58007
1804
1805         Adds flag to start the test browsers maximized.
1806         Symbian started maximized on QtTestBrowser - made MiniBrowser follow
1807         suit.
1808         Also fixes some ToggleFullScreen issues so that prior window state is
1809         restored.
1810
1811         * MiniBrowser/qt/BrowserWindow.cpp:
1812         (BrowserWindow::BrowserWindow):
1813         (BrowserWindow::toggleFullScreenMode):
1814         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1815         (MiniBrowserApplication::handleUserOptions):
1816         * MiniBrowser/qt/MiniBrowserApplication.h:
1817         (WindowOptions::WindowOptions):
1818         * QtTestBrowser/launcherwindow.cpp:
1819         (LauncherWindow::init):
1820         (LauncherWindow::toggleFullScreenMode):
1821         * QtTestBrowser/launcherwindow.h:
1822         (WindowOptions::WindowOptions):
1823         * QtTestBrowser/main.cpp:
1824         (LauncherApplication::handleUserOptions):
1825
1826 2011-04-14  Ojan Vafai  <ojan@chromium.org>
1827
1828         Reviewed by Eric Seidel.
1829
1830         add checkbox to only show unexpected results to new results file
1831         https://bugs.webkit.org/show_bug.cgi?id=58606
1832
1833         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
1834
1835 2011-04-13  Brent Fulgham  <bfulgham@webkit.org>
1836
1837         Reviewed by Martin Robinson.
1838
1839         [WinCairo] Implement ImageDiff Logic.
1840         http://bugs.webkit.org/show_bug.cgi?id=58486
1841
1842         * DumpRenderTree/win/ImageDiffCairo.cpp: Added.
1843         (strtof):
1844         (readFromData):
1845         (createImageFromStdin):
1846         (releaseMallocBuffer):
1847         (createDifferenceImage):
1848         (imageHasAlpha):
1849         (writeToData):
1850         (main):
1851         * DumpRenderTree/win/ImageDiff.vcproj: Updated for new
1852           ImageDiffCairo.cpp (excluding from Apple builds).
1853         * DumpRenderTree/win/ImageDiffDebugCairoCFLite.vsprops: Use
1854           new ImageDiffWinCairoCommon.vsprops file.
1855         * DumpRenderTree/win/ImageDiffReleaseCairoCFLite.vsprops: Use
1856           new ImageDiffWinCairoCommon.vsprops file.
1857         * DumpRenderTree/win/ImageDiffWinCairoCommon.vsprops: Added.
1858         * Scripts/old-run-webkit-tests: Make sure proper executable
1859           is built and executed for WinCairo port.
1860
1861 2011-04-14  Ojan Vafai  <ojan@chromium.org>
1862
1863         Reviewed by Eric Seidel.
1864
1865         only show expected failure type for ports that use an expectations file
1866         https://bugs.webkit.org/show_bug.cgi?id=58588
1867
1868         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
1869         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1870
1871 2011-04-14  Eric Seidel  <eric@webkit.org>
1872
1873         Reviewed by Adam Barth.
1874
1875         commit-queue fails to catch IOError when results.html is missing
1876         https://bugs.webkit.org/show_bug.cgi?id=58589
1877
1878         * Scripts/webkitpy/tool/commands/queues.py:
1879         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1880
1881 2011-04-14  Kevin Ollivier  <kevino@theolliviers.com>
1882
1883         [wx] Unreviewed build fix for Mac installation script.
1884
1885         * wx/packaging/build-mac-installer.py:
1886
1887 2011-04-14  Ojan Vafai  <ojan@chromium.org>
1888
1889         Reviewed by Tony Chang.
1890
1891         sort columns in the new json_results.html file
1892         https://bugs.webkit.org/show_bug.cgi?id=58581
1893
1894         Also fix padding on TDs and the path to layout tests.
1895
1896         * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
1897
1898 2011-04-14  Eric Seidel  <eric@webkit.org>
1899
1900         Reviewed by Dimitri Glazkov.
1901
1902         queues.webkit.org should display when a bot last passed a patch
1903         https://bugs.webkit.org/show_bug.cgi?id=58546
1904
1905         I am suspicious that some of our commit-queue instances are never
1906         actually passing anything.
1907
1908         This will let us know if those bots are never passing patches.
1909
1910         * QueueStatusServer/handlers/queuestatus.py:
1911         * QueueStatusServer/index.yaml:
1912         * QueueStatusServer/templates/queuestatus.html:
1913
1914 2011-04-14  Dirk Pranke  <dpranke@chromium.org>
1915
1916         Reviewed by Adam Roben.
1917
1918         REGRESSION (r83764): webkitpy.layout_tests.port.chromium_win_unittest.ChromiumWinTest.test_default_worker_model fails on apple-windows-13
1919         https://bugs.webkit.org/show_bug.cgi?id=58545
1920
1921         Remove platform-specific overrides; the default behavior should
1922         be working everywhere now, I think.
1923
1924         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1925         * Scripts/webkitpy/layout_tests/port/mac.py:
1926
1927 2011-04-14  Eric Seidel  <eric@webkit.org>
1928
1929         Reviewed by Adam Barth.
1930
1931         commit-queues are hitting an exception trying to land when the tree is red
1932         https://bugs.webkit.org/show_bug.cgi?id=58558
1933
1934         Just an un-tested (and thus broken) code path from yesterday's changes.
1935
1936         * Scripts/webkitpy/common/net/layouttestresults.py:
1937         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1938         * Scripts/webkitpy/tool/commands/queues.py:
1939         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1940
1941 2011-04-14  Kevin Ollivier  <kevino@theolliviers.com>
1942
1943         [wx] Unreviewed build fixes for wxMSW and wx 2.9.1.1.
1944
1945         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1946         (LayoutTestController::shadowRoot):
1947         * wx/build/wxpresets.py:
1948
1949 2011-04-14  Victoria Kirst  <vrk@google.com>
1950
1951         Reviewed by James Robinson.
1952
1953         [chromium] Failing GPU video tests
1954         https://bugs.webkit.org/show_bug.cgi?id=57926
1955
1956         Added/updated GPU directory names for rebaseline tool.
1957
1958         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1959
1960 2011-04-13  Daniel Bates  <dbates@rim.com>
1961
1962         Reviewed by Adam Barth.
1963
1964         Perl unit test removeEOL.pl should print test case name on failure
1965         https://bugs.webkit.org/show_bug.cgi?id=58513
1966
1967         * Scripts/webkitperl/VCSUtils_unittest/removeEOL.pl: Pass $title as
1968           second argument of Test::Simple::ok().
1969
1970 2011-04-13  Kent Tamura  <tkent@chromium.org>
1971
1972         Reviewed by Eric Seidel.
1973
1974         gdb-safari should pass arguments to safari.
1975         https://bugs.webkit.org/show_bug.cgi?id=58439
1976
1977         We can do:
1978           gdb-safari --debug LayoutTests/.../foo.html
1979
1980         * Scripts/gdb-safari: Passing @ARGV to Safari via gdb --arg.
1981
1982 2011-04-13  Dirk Pranke  <dpranke@chromium.org>
1983
1984         Unreviewed, build fix.
1985         https://bugs.webkit.org/show_bug.cgi?id=52763
1986
1987         r83799 broke test-webkitpy because it assumed we always have
1988         access to a real filesystem (we don't during the unit tests).
1989         Stubbing out the copy for now but we might need a better
1990         solution at some point.
1991
1992         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1993
1994 2011-04-13  Dirk Pranke  <dpranke@chromium.org>
1995
1996         Reviewed by Tony Chang.
1997
1998         new-run-webkit-tests --run-singly option is busted
1999         https://bugs.webkit.org/show_bug.cgi?id=55909
2000
2001         Python's broken lexical scoping strikes again :(.
2002
2003         * Scripts/webkitpy/layout_tests/layout_package/worker_mixin.py:
2004         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2005
2006 2011-04-13  Ojan Vafai  <ojan@chromium.org>
2007
2008         Reviewed by Eric Seidel.
2009
2010         generated unexpected_results.html from unexpected_results.json
2011         https://bugs.webkit.org/show_bug.cgi?id=52763
2012
2013         Eventually, we'll merge this with results.html and have a single richer results page.
2014         For now, I just want to get something checked in that we can iterate on.
2015
2016         * Scripts/webkitpy/layout_tests/layout_package/json_results.html: Added.
2017         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2018
2019 2011-04-13  Eric Seidel  <eric@webkit.org>
2020
2021         Reviewed by Adam Barth.
2022
2023         Up the failure limit to allow the commit-queue to actually land when the tree is red
2024         https://bugs.webkit.org/show_bug.cgi?id=58499
2025
2026         This change increases the --exit-after-N-failures limit used by the commit-queue
2027         from 1 to 10.  This will cause the code added in bug 58494 to actually get
2028         exercised and the queues should start being able to land when the trees are red.
2029
2030         When testing I found that test_runtests_leopard_commit_queue_hack_command was the
2031         only unit test to actually detect this change!  Since we don't actually
2032         run on leopard anymore, I removed the hack code and repurposed the test.
2033
2034         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2035         * Scripts/webkitpy/tool/steps/runtests.py:
2036         * Scripts/webkitpy/tool/steps/steps_unittest.py:
2037
2038 2011-04-13  Eric Seidel  <eric@webkit.org>
2039
2040         Reviewed by Adam Barth.
2041
2042         commit-queue should be able to land when tree is red
2043         https://bugs.webkit.org/show_bug.cgi?id=58494
2044
2045         There is some yak hair on my hands, I will admit.
2046
2047         This change is mostly about adding an ExpectedFailures
2048         class to track when the bots are red and we should be
2049         ignoring failures when landing from the commit-queue.
2050
2051         However, to make intelligent decisions about patches we
2052         need to know whether the run hit the --exit-after-N-failures limit
2053         or not.  Right now that information is not saved off in results.html
2054         so we have to pull the information from RunTests.
2055
2056         I've plumbed the --exit-after-N-failures information into
2057         LayoutTestResults for now to make the ExpectedFailures code cleaner.
2058
2059         As a result of adding all these additional calls to delegate.layout_test_results()
2060         I broke some of our flaky test detection tests and had to re-write them
2061         to not depend on the number of layout_test_results code.
2062
2063         At the same time I updated the commit-queue to use the newer filesystem
2064         API (to allow us to use MockFileSystem) which required further changes
2065         to the layout tests.  Changes were required in either case, since
2066         we're now calling layout_test_results() in more cases, which previously
2067         would try and hit the disk (until I moved it to use tool.filesystem).
2068
2069         I should note that *all* of this code is disabled for now, since our
2070         --exit-after-N-failures limit is currently 1!  (Thus were always in the
2071         case where we can't actually tell if the layout test results are legit.)
2072         I will up that limit in a second patch (which may require a couple more unit test tweaks).
2073
2074         * Scripts/webkitpy/common/net/layouttestresults.py:
2075         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2076         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2077         * Scripts/webkitpy/tool/bot/expectedfailures.py: Added.
2078         * Scripts/webkitpy/tool/bot/expectedfailures_unittest.py: Added.
2079         * Scripts/webkitpy/tool/commands/queues.py:
2080         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2081         * Scripts/webkitpy/tool/commands/queuestest.py:
2082         * Scripts/webkitpy/tool/steps/runtests.py:
2083
2084 2011-04-13  Brent Fulgham  <bfulgham@webkit.org>
2085
2086         Unreviewed build correction.
2087
2088         * TestWebKitAPI/PlatformWebView.h: Limit include of
2089           <CoreGraphics/CGGeometry> to PLATFORM(CG) users.
2090
2091 2011-04-13  Mihai Parparita  <mihaip@chromium.org>
2092
2093         Reviewed by Eric Seidel.
2094
2095         [NRWT] Rename --baseline-search-patch to --additional-platform-directory to match ORWT
2096         https://bugs.webkit.org/show_bug.cgi?id=58489
2097         
2098         r83743 added --additional-platform-directory to old-run-webkit-tests,
2099         rename the equivalent flag in new-run-webkit-tests to be consistent.
2100
2101         * Scripts/webkitpy/layout_tests/port/base.py:
2102         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2103         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2104         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2105
2106 2011-04-13  Mihai Parparita  <mihaip@chromium.org>
2107
2108         Reviewed by Eric Seidel.
2109
2110         Rebaseline queue server
2111         https://bugs.webkit.org/show_bug.cgi?id=57891
2112
2113         Adds a simple rebaseline queue server (meant to run at
2114         http://rebaseline-queue.appspot.com/). It presents a list of all (NRWT)
2115         builders and their failing tests, and allows those tests to be added to
2116         a per-builer rebaseline queue.
2117
2118         A subsequent change will add a mode to NRWT (and/or a wrapper script)
2119         for pulling the tests to be rebaselined from the server and running them
2120         with --reset-results (the initial use-case is for the GPU hardware bots,
2121         which do not have checked-in baselines, therefore there is no need for a
2122         check-in step yet).
2123
2124         * RebaselineQueueServer/app.yaml: Added.
2125         * RebaselineQueueServer/handlers/__init__.py: Added.
2126         * RebaselineQueueServer/handlers/builderqueue.py: Added.
2127         * RebaselineQueueServer/handlers/pages.py: Added.
2128         * RebaselineQueueServer/index.yaml: Added.
2129         * RebaselineQueueServer/main.py: Added.
2130         * RebaselineQueueServer/model/__init__.py: Added.
2131         * RebaselineQueueServer/model/queueentry.py: Added.
2132         * RebaselineQueueServer/static/builder-frame-empty.html: Added.
2133         * RebaselineQueueServer/static/styles.css: Added.
2134         * RebaselineQueueServer/templates/builder-picker.html: Added.
2135         * RebaselineQueueServer/templates/builder-queue-edit.html: Added.
2136         * RebaselineQueueServer/templates/builder-queue-list.html: Added.
2137         * RebaselineQueueServer/templates/home.html: Added.
2138
2139 2011-04-13  Dirk Pranke  <dpranke@chromium.org>
2140
2141         Reviewed by Mihai Parparita.
2142
2143         nrwt: enable multiple processes by default on Chromium Win.
2144         https://bugs.webkit.org/show_bug.cgi?id=55163
2145
2146         Re-land r79268; it should be more stable now and will hopefully
2147         work.
2148
2149         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2150         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
2151
2152 2011-04-13  Dirk Pranke  <dpranke@chromium.org>
2153
2154         Reviewed by Ojan Vafai.
2155
2156         new-run-webkit-tests: configure logging in child processes properly
2157         https://bugs.webkit.org/show_bug.cgi?id=58296
2158
2159         Logging propagated properly from manager to worker processes on
2160         Unix but not on Windows; this fixes that.
2161
2162         * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:
2163         * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker_unittest.py:
2164
2165 2011-04-13  Dirk Pranke  <dpranke@chromium.org>
2166
2167         Reviewed by Ojan Vafai.
2168
2169         new-run-webkit-tests: suppress extraneous pretty patch warnings
2170         https://bugs.webkit.org/show_bug.cgi?id=58295
2171
2172         NRWT wasn't being careful about when it logged messages from
2173         PrettyPatch not being available; it should only log during
2174         check_build(), and be silent otherwise. This was causing us to
2175         get multiple errors at runtime, which was confusing.
2176
2177         * Scripts/webkitpy/layout_tests/port/base.py:
2178         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2179         * Scripts/webkitpy/layout_tests/port/chromium.py:
2180
2181 2011-04-13  Dirk Pranke  <dpranke@chromium.org>
2182
2183         Reviewed by Jian Li.
2184
2185         add chromium-linux-x86_64 to rebaseline-chromium-webkit-tests
2186         https://bugs.webkit.org/show_bug.cgi?id=58461
2187
2188         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2189
2190 2011-04-13  Tony Chang  <tony@chromium.org>
2191
2192         Unreviewed, fix NRWT.  Stack:
2193
2194             return super(ChromiumPort, self).results_directory(self)
2195         TypeError: results_directory() takes exactly 1 argument (2 given)
2196
2197         * Scripts/webkitpy/layout_tests/port/chromium.py:
2198
2199 2011-04-13  Adam Roben  <aroben@apple.com>
2200
2201         Teach ORWT about extra platform-specific directories to be searched before the default ones
2202
2203         Fixes <http://webkit.org/b/58446> ORWT needs a way to look in a user-specified directory for
2204         platform-specific results
2205
2206         Reviewed by Anders Carlsson.
2207
2208         * Scripts/old-run-webkit-tests:
2209         (top-level): Added @additionalPlatformDirectories and hooked up
2210         --additional-platform-directories to populate it.
2211         (buildPlatformResultHierarchy): Prepend the additional platform directories to the default
2212         list (after filtering out any of the additional directories that don't exist).
2213
2214 2011-04-13  Lucas Forschler  <lforschler@apple.com>
2215
2216         Reviewed by Adam Roben.
2217
2218         Add the /T command to taskkill.exe.
2219         This will kill spawned child processes.
2220         
2221         * BuildSlaveSupport/win/kill-old-processes:
2222
2223 2011-04-13  Lucas Forschler  <lforschler@apple.com>
2224
2225         Reviewed by Adam Roben.
2226
2227         Sort kill list alphabeticaly.
2228         Fixed capitalization on VcBuildHelper.  
2229
2230         * BuildSlaveSupport/win/kill-old-processes:
2231
2232 2011-04-13  Lucas Forschler  <lforschler@apple.com>
2233
2234         Reviewed by Adam Roben.
2235
2236         https://bugs.webkit.org/show_bug.cgi?id=58384
2237         Update kill-old-processes to include a few new ones.
2238         
2239         * BuildSlaveSupport/win/kill-old-processes:
2240
2241 2011-04-13  Gustavo Noronha Silva  <gns@gnome.org>
2242
2243         Reviewed by Martin Robinson.
2244
2245         [GTK] PluginPackage should check whether a plugin mixes GTK+ 2 and 3 symbols itself
2246         https://bugs.webkit.org/show_bug.cgi?id=58297
2247
2248         Do not disable flash specifically when built with GTK+ 3 -
2249         PluginPackage should do the right thing while loading plugins.
2250
2251         * GtkLauncher/main.c:
2252         (main):
2253
2254 2011-04-12  Kent Tamura  <tkent@chromium.org>
2255
2256         Reviewed by Dimitri Glazkov.
2257
2258         [Chromium] Add WebSettings::setValidationMessageTimerMagnification()
2259         https://bugs.webkit.org/show_bug.cgi?id=57426
2260
2261         * DumpRenderTree/chromium/WebPreferences.cpp:
2262         (WebPreferences::applyTo): Disable the validation message timer.
2263
2264 2011-04-12  James Kozianski  <koz@chromium.org>
2265
2266         Unreviewed.
2267
2268         Adding myself to committers.py.
2269
2270         * Scripts/webkitpy/common/config/committers.py:
2271
2272 2011-04-12  Brent Fulgham  <bfulgham@webkit.org>
2273
2274         Unreviewed build correction for WinCairo bot after r83639.
2275         https://bugs.webkit.org/show_bug.cgi?id=51790
2276
2277         Correct typo for the new "update-webkit-wincairo-libs" script.
2278
2279         * Scripts/build-webkit: Incorrectly calling the
2280           update-webkit-cairo-libs which does not exist.
2281
2282 2011-04-12  Alice Liu  <alice.liu@apple.com>
2283
2284         Reviewed by Jon Honeycutt.
2285
2286         A change that should have been part of http://trac.webkit.org/changeset/83628
2287
2288         * DumpRenderTree/win/DumpRenderTree.cpp:
2289         (resetDefaultsToConsistentValues): Setting should be off for most tests. Reset to false.
2290
2291 2011-04-12  Dirk Pranke  <dpranke@chromium.org>
2292
2293         Reviewed by Tony Chang.
2294
2295         new-run-webkit-tests: --results-directory is relative to builddir, not $PWD
2296         https://bugs.webkit.org/show_bug.cgi?id=58272
2297
2298         NRWT was interpreting the --results-directory cmd line arg as
2299         relative to the build directory, not the current working
2300         directory (ORWT uses the latter, which is much more intuitive).
2301         
2302         This patch fixes the base case, but includes an override for
2303         Chromium that is needed until the bots can be updated.
2304
2305         * Scripts/webkitpy/layout_tests/port/base.py:
2306         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2307         * Scripts/webkitpy/layout_tests/port/chromium.py:
2308         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2309         * Scripts/webkitpy/layout_tests/port/test.py:
2310         * Scripts/webkitpy/layout_tests/port/webkit.py:
2311         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2312         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2313
2314 2011-04-12  Philippe Normand  <pnormand@igalia.com>
2315
2316         Unreviewed, roll out r83621 as it broke the GTK build.
2317
2318         [GTK] arguments passed to build-jsc and build-webkit scripts are not taken into account
2319         https://bugs.webkit.org/show_bug.cgi?id=58333
2320
2321         * Scripts/build-jsc:
2322         * Scripts/build-webkit:
2323
2324 2011-04-12  Carl Lobo  <carllobo@gmail.com> and Brent Fulgham <bfulgham@webkit.org>
2325
2326         Reviewed by Adam Roben.
2327
2328         Patch to download the WinCairo dependancies as part of build-webkit.
2329         https://bugs.webkit.org/show_bug.cgi?id=51790
2330
2331         This patch downloads the dependancies from 
2332             http://idisk.mac.com/bfulgham-Public/WinCairoRequirements.zip 
2333         checking the modification timestamp etc. 
2334
2335         * Tools/Scripts/build-webkit
2336         * Tools/Scripts/update-webkit: Modified to understand the --wincairo
2337           flag, and to update WinCairo dependencies when used.
2338         * Tools/Scripts/update-webkit-cairo-libs: added
2339         * Tools/Scripts/update-webkit-dependency: added
2340         * Tools/Scripts/update-webkit-auxiliary-libs
2341
2342 2011-04-12  Jeff Miller  <jeffm@apple.com>
2343
2344         Reviewed by Adam Roben.
2345
2346         WebKit2: Pressing Tab in Web Inspector's console does not cycle through completion options
2347         https://bugs.webkit.org/show_bug.cgi?id=56020
2348
2349         Don't call TranslateMessage() in the MiniBrowser or TestWebKitAPI for key messages destined for a WebKit2 view,
2350         since WebKit will do this for us.  If we didn't do this, TranslateMessage() would be called twice,
2351         which would generate two characters for every keypress (for example).  I didn't bother doing this for
2352         WebKitTestRunner, since it doesn't get any WM_KEYDOWN events.
2353         
2354         Add new WebKit2/TranslateMessageGeneratesWMChar test to test expected TranslateMessage() behavior.
2355
2356         * MiniBrowser/win/main.cpp:
2357         (shouldTranslateMessage): Added.
2358         (_tWinMain): Don't call TranslateMessage() unless shouldTranslateMessage() says to.
2359         * TestWebKitAPI/PlatformUtilities.h: Added shouldTranslateMessage() on Windows.
2360         * TestWebKitAPI/PlatformWebView.h: Added simulateAKeyDown().
2361         * TestWebKitAPI/Tests/WebKit2/win/TranslateMessageGeneratesWMChar.cpp: Added.
2362         (TestWebKitAPI::didNotHandleKeyEventCallback): Added.
2363         (TestWebKitAPI::runAndWatchForWMChar): Added.
2364         (TestWebKitAPI::TEST): Added.
2365         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
2366         (TestWebKitAPI::Util::run): Don't call TranslateMessage() unless shouldTranslateMessage() says to.
2367         (TestWebKitAPI::Util::shouldTranslateMessage): Added.
2368         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
2369         (TestWebKitAPI::PlatformWebView::simulateAKeyDown): Added.
2370         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Added TranslateMessageGeneratesWMChar.cpp.
2371
2372 2011-04-12  Dirk Pranke  <dpranke@chromium.org>
2373
2374         Reviewed by Tony Chang.
2375
2376         new-run-webkit-tests: update code to use port.results_directory() instead of options.results_directory
2377         https://bugs.webkit.org/show_bug.cgi?id=58290
2378
2379         This is some preliminary refactoring for bug 58272.
2380
2381         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
2382         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
2383         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2384         * Scripts/webkitpy/layout_tests/layout_package/worker_mixin.py:
2385         * Scripts/webkitpy/layout_tests/port/test.py:
2386         * Scripts/webkitpy/layout_tests/port/chromium.py:
2387         * Scripts/webkitpy/layout_tests/port/base.py:
2388         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2389
2390 2011-04-12  Dirk Pranke  <dpranke@chromium.org>
2391
2392         Reviewed by Eric Seidel.
2393
2394         webkitpy: fix mock_filesystem abspath to handle relative paths
2395         and add filesystem.chdir() and filesystem.getcwd() to be able
2396         to test this and mock it out.
2397
2398         https://bugs.webkit.org/show_bug.cgi?id=58288
2399
2400         * Scripts/webkitpy/common/system/filesystem.py:
2401         * Scripts/webkitpy/common/system/filesystem_mock.py:
2402         * Scripts/webkitpy/common/system/filesystem_unittest.py:
2403
2404 2011-04-12  Alice Liu  <alice.liu@apple.com>
2405
2406         Reviewed by Sam Weinig.
2407
2408         https://bugs.webkit.org/show_bug.cgi?id=58292
2409         Provide new setting to allow site icon loading despite disabling automatic image loading in general.
2410
2411         * DumpRenderTree/mac/DumpRenderTree.mm:
2412         (resetDefaultsToConsistentValues): Setting should be off for most tests. Reset to false.
2413
2414 2011-04-12  Thouraya ANDOLSI  <thouraya.andolsi@st.com>
2415
2416         Reviewed by Eric Seidel.
2417
2418         [Qt] Enable JIT build for SH4 platforms.
2419         https://bugs.webkit.org/show_bug.cgi?id=58317
2420
2421
2422         * DumpRenderTree/qt/DumpRenderTree.pro:
2423         * QtTestBrowser/QtTestBrowser.pro:
2424         * Scripts/webkitdirs.pm:
2425
2426 2011-04-12  Tony Chang  <tony@chromium.org>
2427
2428         Reviewed by Andreas Kling.
2429
2430         [Qt] embed checksums in PNGs written by Qt-DRT
2431         https://bugs.webkit.org/show_bug.cgi?id=58173
2432
2433         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2434         (WebCore::DumpRenderTree::dump):
2435
2436 2011-04-12  Eric Seidel  <eric@webkit.org>
2437
2438         Reviewed by Adam Barth.
2439
2440         commit-queue should upload failure diffs when tests fail
2441         https://bugs.webkit.org/show_bug.cgi?id=58348
2442
2443         This change was mostly just plumbing.  We were already saving
2444         this information for flaky test reporting.  I just made it possible
2445         for normal failures to report archives as well.
2446
2447         I did a little abstraction work to try and share some code between
2448         flakytestreporter.py and this new code.  There is still more we could do.
2449
2450         In making this change I also went through and updated the various
2451         places we have urls hard-coded in our python and pointed them at
2452         common.config.urls.
2453
2454         * Scripts/webkitpy/common/checkout/scm.py:
2455         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2456         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2457         * Scripts/webkitpy/common/net/statusserver.py:
2458         * Scripts/webkitpy/layout_tests/port/base.py:
2459         * Scripts/webkitpy/tool/bot/botinfo.py: Added.
2460         * Scripts/webkitpy/tool/bot/botinfo_unittest.py: Added.
2461         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2462         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2463         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2464         * Scripts/webkitpy/tool/commands/queues.py:
2465
2466 2011-04-12  Daniel Bates  <dbates@rim.com>
2467
2468         Rubber-stamped by Eric Seidel.
2469
2470         svn-apply and/or patch(1) has trouble applying patches that makes changes to files
2471         with Windows line endings
2472         https://bugs.webkit.org/show_bug.cgi?id=53625
2473
2474         Fixes an issue where a patch made on a SCM checkout on a Unix file system cannot be
2475         applied to an SCM checkout on a Windows file system and vice-versa.
2476
2477         This issue manifests itself due to custom SCM settings as well as differences in
2478         gitattributes support in older versions of Git (e.g. 1.7.0.3). We implement support
2479         into svn-apply/unapply to compensate for differences in line endings by converting
2480         the line endings in a patch to match the line endings in the target file (if it exists).
2481
2482         * Scripts/VCSUtils.pm:
2483           - Added parseFirstEOL(), which returns the first end-of-line character(s) that appear in the
2484             content read from the specified file handle. Obviously, this heuristic will not work
2485             for files with mixed line endings, but I don't envision such files to be the norm. If
2486             this turns out to be an issue then we can improve the heuristic.
2487           - Added firstEOLInFile().
2488           - Modified parsePatch() and parseDiff() to take an optional hash reference to an options hash.
2489             In particular, added the hash key shouldNotUseIndexPathEOL to control whether to use the line
2490             endings in the diff instead of the line endings in the target file.
2491           - Extracted local variable $chunkRangeRegEx from fixChangeLogPatch() so that it can be
2492             re-used in parseDiff().
2493         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl: Modified to pass {shouldNotUseIndexPathEOL => 1}
2494           to parsePatch() since these unit tests don't create mock files. Instead, created unit tests that use
2495           mock files in file VCSUtils_unittest/parseDiffWithMockFiles.pl.
2496         * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl: Added.
2497         * Scripts/webkitperl/VCSUtils_unittest/parseFirstEOL.pl: Added.
2498
2499 2011-04-12  Sam Weinig  <sam@webkit.org>
2500
2501         Reviewed by Adam Roben.
2502
2503         REGRESSION (r83550): Multiple http tests crashing in the web process in SQLite beneath CFNetwork on Windows 7 Release (WebKit2 Tests)
2504         https://bugs.webkit.org/show_bug.cgi?id=58336
2505
2506         * WebKitTestRunner/TestController.cpp:
2507         (WTR::TestController::resetStateToConsistentValues):
2508         Remove cache clearing as that is causing tests to crash on Windows 7.
2509
2510 2011-04-11  Sam Weinig  <sam@webkit.org>
2511
2512         Reviewed by Anders Carlsson.
2513
2514         REGRESSION(r77974): http/tests/security/aboutBlank/security-context-window-open.html is failing
2515         <rdar://problem/8981346>
2516         https://bugs.webkit.org/show_bug.cgi?id=54159
2517
2518         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2519         (WTR::InjectedBundlePage::InjectedBundlePage):
2520         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
2521         (WTR::InjectedBundlePage::decidePolicyForNewWindowAction):
2522         (WTR::InjectedBundlePage::decidePolicyForResponse):
2523         (WTR::InjectedBundlePage::unableToImplementPolicy):
2524         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2525         Add short-circuited policy client which matches WebKit1.
2526
2527         * WebKitTestRunner/TestController.cpp:
2528         (WTR::TestController::resetStateToConsistentValues):
2529         Clear the cache between tests to ensure consistent results.
2530
2531 2011-04-11  George Guo  <George.Guo@nokia.com>
2532
2533         Reviewed by Eric Seidel.
2534
2535         prepare-ChangeLog support email input but -h did not show the option
2536         https://bugs.webkit.org/show_bug.cgi?id=58164
2537
2538         Add email option to -h to improve the usability
2539
2540         * Scripts/prepare-ChangeLog:
2541
2542 2011-04-11  Dimitri Glazkov  <dglazkov@chromium.org>
2543
2544         Reviewed by Eric Carlson.
2545
2546         Rename MediaControls to MediaControlRootElement.
2547         https://bugs.webkit.org/show_bug.cgi?id=58250
2548
2549         * Scripts/do-webcore-rename: Documented the renaming.
2550
2551 2011-04-11  Sam Weinig  <sam@webkit.org>
2552
2553         Fix Windows build.
2554
2555         * MiniBrowser/win/BrowserView.cpp:
2556         (BrowserView::create):
2557
2558 2011-04-11  Sam Weinig  <sam@webkit.org>
2559
2560         Reviewed by Anders Carlsson.
2561
2562         Move focus management out of WebKit via  the UIClient
2563         <rdar://problem/8784068>
2564         https://bugs.webkit.org/show_bug.cgi?id=58278
2565
2566         * MiniBrowser/mac/BrowserWindowController.m:
2567         (-[BrowserWindowController awakeFromNib]):
2568         * WebKitTestRunner/TestController.cpp:
2569         (WTR::TestController::createOtherPage):
2570         (WTR::TestController::initialize):
2571         Add stubs for new UIClient functions.
2572
2573 2011-02-03  Martin Robinson  <mrobinson@igalia.com>
2574
2575         Reviewed by Eric Seidel.
2576
2577         [GTK] The GTK+ DRT needs an implementation of the PlainTextController
2578         https://bugs.webkit.org/show_bug.cgi?id=53605
2579
2580         Add an implementation of the PlainTextController for the GTK+ DRT.
2581
2582         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2583         (addControllerToWindow): Added this helper method.
2584         (webViewWindowObjectCleared): Use the new helper to add EventSender
2585         and the PlainTextController to the window object.
2586         * GNUmakefile.am: Added PlainTextController source files.
2587         * DumpRenderTree/gtk/PlainTextController.cpp: Added. This will rely
2588         on DumpRenderTreeSupportGtk to convert a JSValueRef into a WebKitDOMRange
2589         until that functionality exists somewhere in the WebKitGTK+ stack.
2590         * DumpRenderTree/gtk/PlainTextController.h: Added.
2591
2592 2011-04-11  Yael Aharon  <yael.aharon@nokia.com>
2593
2594         Unreviewed.
2595
2596         Adding my IRC nick.
2597
2598         * Scripts/webkitpy/common/config/committers.py:
2599
2600 2011-04-11  Dirk Pranke  <dpranke@chromium.org>
2601
2602         Reviewed by Adam Roben.
2603
2604         new-run-webkit-tests: fix crash when running under windows cmd.exe
2605         https://bugs.webkit.org/show_bug.cgi?id=58197
2606
2607         We would intermittently crash when running NRWT directly under
2608         cmd.exe on windows because we were sharing the stdin file
2609         descriptor between the python process and the http server.
2610         cmd.exe really didn't like that, and there was no reason to
2611         share the descriptor, so we now use a PIPE instead.
2612
2613         * Scripts/webkitpy/layout_tests/port/http_server.py:
2614
2615 2011-04-11  Dirk Pranke  <dpranke@chromium.org>
2616
2617         Reviewed by Ojan Vafai.
2618
2619         new-run-webkit-tests: add unit tests for Port.diff_image()
2620         https://bugs.webkit.org/show_bug.cgi?id=58196
2621
2622         Add the unit tests for the fix in bug 58195.
2623
2624         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2625         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2626         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2627
2628 2011-04-11  Dirk Pranke  <dpranke@chromium.org>
2629
2630         Reviewed by Tony Chang.
2631
2632         new-run-webkit-tests: implement support for audio, take two
2633         https://bugs.webkit.org/show_bug.cgi?id=58195
2634
2635         Attempt to re-land the fix for bug 58101 (which was initially
2636         landed in r83330, but rolled out). This is the same patch but
2637         fixes crashes in Port.diff_image() caused by the change for
2638         empty image files being None instead of ''.
2639
2640         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
2641         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
2642         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2643         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
2644         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
2645         * Scripts/webkitpy/layout_tests/port/base.py:
2646         * Scripts/webkitpy/layout_tests/port/chromium.py:
2647         * Scripts/webkitpy/layout_tests/port/dryrun.py:
2648         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
2649         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
2650         * Scripts/webkitpy/layout_tests/port/test.py:
2651         * Scripts/webkitpy/layout_tests/port/webkit.py:
2652
2653 2011-04-11  Mario Sanchez Prada  <msanchez@igalia.com>
2654
2655         Reviewed by Xan Lopez.
2656
2657         [GTK] Implement AccessibilityUIElement::{row|column}IndexRange in DRT
2658         https://bugs.webkit.org/show_bug.cgi?id=57854
2659
2660         Implement missing features in GTK's DRT.
2661
2662         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2663         (indexRangeInTable): New helper function to get the range string
2664         for the current cell inside the parent table, either from the
2665         point of view of rows or columns.
2666         (AccessibilityUIElement::rowIndexRange): Implemented by relying on
2667         the new helper function indexRangeInTable().
2668         (AccessibilityUIElement::columnIndexRange): Ditto.
2669
2670 2011-04-11  Mario Sanchez Prada  <msanchez@igalia.com>
2671
2672         Reviewed by Chris Fleizach.
2673
2674         [GTK] Implement AccessibilityUIElement::cellForColumnAndRow in DRT
2675         https://bugs.webkit.org/show_bug.cgi?id=57826
2676
2677         Implement missing feature in GTK's DRT.
2678
2679         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2680         (AccessibilityUIElement::cellForColumnAndRow): Implemented, by
2681         relying on the analogous function from the AtkTable interface.
2682
2683 2011-04-05  Timothy Hatcher  <timothy@apple.com>
2684
2685         Fix the extract-localizable-strings script errors that started after
2686         WEB_UI_STRING was added to LocalizedStrings.h in WebCore.
2687
2688         * Scripts/extract-localizable-strings: Skip LocalizedStrings.h.
2689
2690 2011-04-11  Tony Chang  <tony@chromium.org>
2691
2692         Reviewed by Eric Seidel.
2693
2694         fix crc computation on 64 bit machines
2695         https://bugs.webkit.org/show_bug.cgi?id=58243
2696
2697         unsigned long is dependenct on CPU architecture, so use unsigned which is always 32 bits
2698
2699         * DumpRenderTree/CyclicRedundancyCheck.cpp:
2700         (makeCrcTable):
2701         (computeCrc):
2702         * DumpRenderTree/CyclicRedundancyCheck.h:
2703         * DumpRenderTree/PixelDumpSupport.cpp:
2704         (appendIntToVector):
2705         (convertChecksumToPNGComment):
2706
2707 2011-04-10  Kimmo Kinnunen  <kimmo.t.kinnunen@nokia.com>
2708
2709         Reviewed by Eric Seidel.
2710
2711         Require no undefined symbols during compilation.
2712
2713         [Qt] [WK2] WebKitTestRunner, QtWebProcess and WTRInjectBundle should fail to compile when there's undefined symbols
2714         https://bugs.webkit.org/show_bug.cgi?id=54896
2715
2716         Add -Wl,--no-undefined to catch missing symbols early.
2717
2718         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2719         * WebKitTestRunner/qt/WebKitTestRunner.pro:
2720
2721 2011-04-10  Kevin Ollivier  <kevino@theolliviers.com>
2722
2723         [wx] Unreviewed build fix. Remove collector dirs from the list of build dirs.
2724
2725         * wx/build/settings.py:
2726
2727 2011-04-10  Kevin Ollivier  <kevino@theolliviers.com>
2728
2729         [wx] Unreviewed build fix. Add Source/JavaScriptCore/heap to the list of directories.
2730
2731         * wx/build/settings.py:
2732
2733 2011-04-10  David Levin  <levin@chromium.org>
2734
2735         Reviewed by Dimitri Glazkov.
2736
2737         REGRESSION(r83384): Change to chromium.py is resulting in failures of the test framework on linux.
2738         https://bugs.webkit.org/show_bug.cgi?id=58201
2739
2740         * Scripts/webkitpy/layout_tests/port/chromium.py: Commented out the assert for now,
2741         and filed bug 58202.
2742
2743 2011-04-09  David Levin  <levin@chromium.org>
2744
2745         Unreviewed, rolling out r83394.
2746         http://trac.webkit.org/changeset/83394
2747         https://bugs.webkit.org/show_bug.cgi?id=53625
2748
2749         Patch was incorrect as noted in the bug.
2750
2751         * Scripts/svn-apply:
2752
2753 2011-04-09  David Levin  <levin@chromium.org>
2754
2755         Reviewed by Adam Barth.
2756
2757         svn-apply and/or patch(1) has trouble applying patches that makes changes to files with Windows line endings
2758         https://bugs.webkit.org/show_bug.cgi?id=53625
2759
2760         * Scripts/svn-apply: Ensure that the portions of patches
2761         which are for vcproj/vsprops files has DOS line endings.
2762
2763 2011-04-09  Dirk Pranke  <dpranke@chromium.org>
2764
2765         Reviewed by Tony Chang.
2766
2767         It looks like NRWT has not been stopping DRT/TestShell
2768         instances properly on windows, probably for a long time.
2769         This would go a long way to explaining why we often have
2770         processes lying around :)
2771
2772         https://bugs.webkit.org/show_bug.cgi?id=57807
2773
2774         * Scripts/webkitpy/layout_tests/port/chromium.py:
2775         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2776
2777 2011-04-09  Keith Kyzivat  <keith.kyzivat@nokia.com>
2778
2779         Reviewed by Laszlo Gombos.
2780
2781         [Qt] Don't link against fontconfig or X11 if embedded
2782         https://bugs.webkit.org/show_bug.cgi?id=58104
2783
2784         * DumpRenderTree/qt/DumpRenderTree.pro: fontconfig !included in embedded
2785         * QtTestBrowser/QtTestBrowser.pro: ditto
2786         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: ditto
2787         * WebKitTestRunner/qt/WebKitTestRunner.pro: ditto
2788
2789 2011-04-08  Jon Honeycutt  <jhoneycutt@apple.com>
2790
2791         http/tests/loading/preload-append-scan.php is failing on Windows
2792         https://bugs.webkit.org/show_bug.cgi?id=58178
2793
2794         Reviewed by Brian Weinstein.
2795
2796         * DumpRenderTree/win/DumpRenderTree.cpp:
2797         (lastPathComponent):
2798         Use CFURL API to find the last path component, rather than
2799         PathFindFileName(), because the latter will include the query string.
2800
2801 2011-04-08  Jian Li  <jianli@chromium.org>
2802
2803         Unreviewed, rolling out r83327, r83330 since these patches are very
2804         likely to break chromium webkit mac10.6 builders.
2805
2806         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
2807         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
2808         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2809         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
2810         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
2811         * Scripts/webkitpy/layout_tests/port/base.py:
2812         * Scripts/webkitpy/layout_tests/port/chromium.py:
2813         * Scripts/webkitpy/layout_tests/port/dryrun.py:
2814         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
2815         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
2816         * Scripts/webkitpy/layout_tests/port/test.py:
2817         * Scripts/webkitpy/layout_tests/port/webkit.py:
2818
2819 2011-04-08  Vincent Scheib  <scheib@chromium.org>
2820
2821         Reviewed by Eric Seidel.
2822
2823         add chromium-gpu-linux-x86_64 to the recognized list of ports
2824         https://bugs.webkit.org/show_bug.cgi?id=58099
2825
2826         Add chromium-gpu-linux-x86_64 to fix assert.
2827
2828         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2829
2830 2011-04-08  Alpha Lam  <hclam@chromium.org>
2831
2832         Unreviewed, rolling out r83335.
2833         http://trac.webkit.org/changeset/83335
2834         https://bugs.webkit.org/show_bug.cgi?id=53556
2835
2836         GTK and QT bots are broken
2837
2838         * Scripts/build-webkit:
2839
2840 2011-04-07  Anna Cavender  <annacc@chromium.org>
2841
2842         Reviewed by Eric Carlson.
2843
2844         Setup ENABLE(TRACK) feature define
2845         https://bugs.webkit.org/show_bug.cgi?id=53556
2846
2847         * Scripts/build-webkit:
2848
2849 2011-04-08  Dirk Pranke  <dpranke@chromium.org>
2850
2851         Reviewed by Adam Roben.
2852
2853         new-run-webkit-tests: configure a NRWT test bot for Mac SL
2854         https://bugs.webkit.org/show_bug.cgi?id=58114
2855
2856         This change removes the old new-run-webkit-tests entry and
2857         updates it for a new test-only bot.
2858
2859         * BuildSlaveSupport/build.webkit.org-config/config.json:
2860
2861 2011-04-08  Dominic Cooney  <dominicc@google.com>
2862
2863         Reviewed by Adam Roben.
2864
2865         Make layoutTestController.shadowRoot return null, not undefined,
2866         when its argument is invalid.
2867         https://bugs.webkit.org/show_bug.cgi?id=58121
2868
2869         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2870         (LayoutTestController::shadowRoot):
2871         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2872         (WTR::LayoutTestController::shadowRoot):
2873
2874 2011-04-08  Pere Martir  <pere.martir4@gmail.com>
2875
2876         Reviewed by Adam Roben.
2877
2878         Locate NSTD.EXE in 64-bit Windows
2879         https://bugs.webkit.org/show_bug.cgi?id=57847
2880
2881         * Scripts/old-run-webkit-tests:
2882
2883 2011-04-08  Adam Roben  <aroben@apple.com>
2884
2885         Qt build fix
2886
2887         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h: Pull in stdarg.h for va_list.
2888
2889 2011-04-07  Adam Roben  <aroben@apple.com>
2890
2891         Test that NPP_SetWindow is passed a null window handle during plugin destruction on non-Mac platforms
2892
2893         Test for <http://webkit.org/b/47009> WebKit2 needs to call NPP_SetWindow when destroying a
2894         plugin
2895
2896         Reviewed by Anders Carlsson.
2897
2898         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
2899         (pluginLogWithArguments): Moved code to format and log the message here...
2900         (pluginLog): ...from here.
2901
2902         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h: Added pluginLogWithArguments.
2903
2904         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
2905         (PluginTest::log): Added. Calls through to pluginLogWithArguments.
2906
2907         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h: Added log.
2908
2909         * DumpRenderTree/TestNetscapePlugIn/Tests/NPPSetWindowCalledDuringDestruction.cpp: Added.
2910         (NPPSetWindowCalledDuringDestruction::setWillBeDestroyed): Records that destruction is about
2911         to begin.
2912         (NPPSetWindowCalledDuringDestruction::NPPSetWindowCalledDuringDestruction): Simple
2913         constructor.
2914         (NPPSetWindowCalledDuringDestruction::NPP_GetValue): Creates and returns a ScriptObject that
2915         can be used to invoke our setWillBeDestroyed function.
2916         (NPPSetWindowCalledDuringDestruction::NPP_SetWindow): Records what has happened (and logs if
2917         anything unexpected happens).
2918         (NPPSetWindowCalledDuringDestruction::NPP_Destroy): On Mac, logs a failure message if
2919         NPP_SetWindow was called during destruction. On other platforms, logs a failure message if
2920         NPP_SetWindow was *not* called during destruction.
2921         (NPPSetWindowCalledDuringDestruction::ScriptObject::hasMethod): Return true for our only
2922         method, setWillBeDestroyed.
2923         (NPPSetWindowCalledDuringDestruction::ScriptObject::invoke): Call through to the PluginTest
2924         object.
2925
2926         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2927         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2928         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2929         * GNUmakefile.am:
2930         Added new test.
2931
2932         * Scripts/old-run-webkit-tests: Skip the new test when using out-of-process plugins with
2933         WebKit1 on Mac, since it can't work properly due to <http://webkit.org/b/58077>.
2934
2935 2011-04-08  Mario Sanchez Prada  <msanchez@igalia.com>
2936
2937         Reviewed by Martin Robinson.
2938
2939         [GTK] Implement increment() and decrement() functions in DRT's AccessibilityUIElement
2940         https://bugs.webkit.org/show_bug.cgi?id=58039
2941
2942         Implement missing functions in GTK's DRT.
2943
2944         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2945         (AccessibilityUIElement::increment): Implemented.
2946         (AccessibilityUIElement::decrement): Implemented.
2947
2948 2011-04-08  Dominic Cooney  <dominicc@google.com>
2949
2950         Reviewed by Kent Tamura.
2951
2952         Make WK2 layoutTestController.shadowRoot return undefined, not
2953         null, when its argument is not an element.
2954         https://bugs.webkit.org/show_bug.cgi?id=58121
2955
2956         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2957         (WTR::LayoutTestController::shadowRoot):
2958
2959 2011-04-07  Dirk Pranke  <dpranke@chromium.org>
2960
2961         Reviewed by Mihai Parparita.
2962
2963         Change reference port for Mac GPU baselines from
2964         Leopard to SnowLeopard, XP to Win7, and Linux-x86
2965         to Linux x86-64.
2966
2967         https://bugs.webkit.org/show_bug.cgi?id=58099
2968
2969         * Scripts/webkitpy/layout_tests/port/chromium.py:
2970
2971 2011-04-07  Andrew Scherkus  <scherkus@chromium.org>
2972
2973         Revert ENABLE_TRACK patch due to compile failures.
2974
2975         * Scripts/build-webkit:
2976
2977 2011-04-07  Tony Chang  <tony@chromium.org>
2978
2979         Reviewed by Eric Seidel.
2980
2981         update DRT to embed checksums in png files
2982         https://bugs.webkit.org/show_bug.cgi?id=57871
2983
2984         We insert the bytes for the comment in printPNG rather than at encode
2985         time because each platform does its own PNG encoding (either using CG
2986         or cairo).  Putting this in pringPNG avoids having to duplicate this
2987         code, although it's not as clean as doing it at encoding time.
2988
2989         We insert the comment right after the IHDR chunk of the PNG.
2990
2991         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2992         * DumpRenderTree/CyclicRedundancyCheck.cpp: Added.
2993         (makeCrcTable): Ported from LayoutTests/fast/canvas/webgl/resources/pnglib.js
2994         (computeCrc): Ported from LayoutTests/fast/canvas/webgl/resources/pnglib.js
2995         * DumpRenderTree/CyclicRedundancyCheck.h: Added.
2996         * DumpRenderTree/PixelDumpSupport.cpp:
2997         (dumpWebViewAsPixelsAndCompareWithExpected):
2998         (convertChecksumToPNGComment): Generate the bytes to insert.
2999         (printPNG): Insert the png comment before the first IDAT section.
3000         * DumpRenderTree/PixelDumpSupport.h:
3001         * DumpRenderTree/cairo/PixelDumpSupportCairo.cpp:
3002         (printPNG):
3003         (dumpBitmap):
3004         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
3005         (printPNG):
3006         (dumpBitmap):
3007         * DumpRenderTree/win/DumpRenderTree.vcproj:
3008         * GNUmakefile.am:
3009
3010 2011-04-07  Jeff Miller  <jeffm@apple.com>
3011
3012         Reviewed by Adam Roben.
3013
3014         Replace WKStringGetCharactersPtr() with WKStringGetCharacters()
3015         https://bugs.webkit.org/show_bug.cgi?id=58058
3016
3017         * TestWebKitAPI/Tests/WebKit2/WKString.cpp:
3018         (TestWebKitAPI::TEST): Add tests for  WKStringGetLength() and WKStringGetCharactersPtr().
3019
3020 2011-04-07  Chang Shu  <cshu@webkit.org>
3021
3022         Reviewed by Darin Adler.
3023
3024         WebKitTestRunner needs layoutTestController.isPageBoxVisible
3025         https://bugs.webkit.org/show_bug.cgi?id=42695
3026
3027         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
3028         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3029         (WTR::LayoutTestController::isPageBoxVisible):
3030         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3031
3032 2011-04-07  Adam Roben  <aroben@apple.com>
3033
3034         Build fix
3035
3036         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Added a missing import.
3037
3038 2011-04-07  Adam Roben  <aroben@apple.com>
3039
3040         Move ExtractTestResults[AndLeaks]'s summarizing code back from commandComplete() to finished()
3041
3042         commandComplete() is never called for MasterShellCommands like ExtractTestResults[AndLeaks].
3043         (Unfortunately the buildbot documentation does not make this clear.) finished() is the only
3044         hook we have, so we have to do our work there. I added a new addCustomURLs method which can
3045         be overridden by subclasses to provide extra URLs before we call up to the base class (after
3046         which adding more URLs is no longer possible).
3047
3048         Really hopefully fixes <http://webkit.org/b/56032> Leaks viewer should be linked from leaks
3049         bot results page
3050
3051         Reviewed by John Sullivan.
3052
3053         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3054         (ExtractTestResults.addCustomURLs): Moved code to add the "view results" URL here...
3055         (ExtractTestResults.finished): ...from here. This replaces commandComplete, since that
3056         method is never called for MasterShellCommands.
3057         (ExtractTestResultsAndLeaks.addCustomURLs): Replaced commandComplete (which is never called)
3058         with this method (which is).
3059
3060 2011-04-07  Adam Roben  <aroben@apple.com>
3061
3062         Move ExtractTestResults[AndLeaks]'s summarizing code from finished() to commandComplete()
3063
3064         This matches how most of our other build steps work, so is good just for improving
3065         consistency between build steps. It should also make it possible for
3066         ExtractTestResultsAndLeaks to successfully add a URL to Leaks Viewer. (Previously we were
3067         trying to do this in finished() after we had called up to the base class, but that was
3068         apparently too late to add more URLs.)
3069
3070         Hopefully fixes <http://webkit.org/b/56032> Leaks viewer should be linked from leaks bot
3071         results page
3072
3073         Reviewed by John Sullivan.
3074
3075         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3076         (ExtractTestResults): Added a descriptionDone property so that we don't have to manually
3077         call setText to get the right text to show up for this step. This matches how most of our
3078         other build steps work.
3079         (ExtractTestResults.commandComplete): Replaced our override of finished with this function.
3080         This is how most of our other build steps work.
3081         (ExtractTestResultsAndLeaks.commandComplete): Replaced our override of finished with this
3082         function, to match the base class.
3083
3084 2011-04-07  Adam Barth  <abarth@webkit.org>
3085
3086         Reviewed by Maciej Stachowiak.
3087
3088         webkit-patch shouldn't state the whole working copy when calling check-webkit-style
3089         https://bugs.webkit.org/show_bug.cgi?id=58022
3090
3091         Previously, we were ignoring the args variable!  This patch fixes the
3092         regression introduced in http://trac.webkit.org/changeset/82771.
3093
3094         * Scripts/webkitpy/tool/commands/download_unittest.py:
3095         * Scripts/webkitpy/tool/mocktool.py:
3096         * Scripts/webkitpy/tool/steps/checkstyle.py:
3097
3098 2011-04-07  Maciej Stachowiak  <mjs@apple.com>
3099
3100         Reviewed by Adam Barth.
3101
3102         REGRESSION: "webkit-patch land" doesn't work correctly in SVN subdirectories
3103         https://bugs.webkit.org/show_bug.cgi?id=58017
3104
3105         * Scripts/webkitpy/common/checkout/scm.py:
3106         * Scripts/webkitpy/common/checkout/scm_unittest.py:
3107
3108 2011-04-06  Chang Shu  <cshu@webkit.org>
3109
3110         Reviewed by Darin Adler.
3111
3112         WebKitTestRunner needs layoutTestController.pageSizeAndMarginsInPixels
3113         https://bugs.webkit.org/show_bug.cgi?id=57984
3114
3115         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
3116         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3117         (WTR::LayoutTestController::pageSizeAndMarginsInPixels):
3118         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3119
3120 2011-04-06  Chris Rogers  <crogers@google.com>
3121
3122         Reviewed by Tony Chang.
3123
3124         Add web audio support to DumpRenderTree (mac port)
3125         https://bugs.webkit.org/show_bug.cgi?id=57969
3126
3127         * DumpRenderTree/LayoutTestController.cpp:
3128         (LayoutTestController::LayoutTestController):
3129         (setEncodedAudioDataCallback):
3130         (LayoutTestController::staticFunctions):
3131         * DumpRenderTree/LayoutTestController.h:
3132         (LayoutTestController::dumpAsAudio):
3133         (LayoutTestController::setDumpAsAudio):
3134         (LayoutTestController::encodedAudioData):
3135         (LayoutTestController::setEncodedAudioData):
3136         * DumpRenderTree/mac/DumpRenderTree.mm:
3137         (dumpAudio):
3138         (dump):
3139
3140 2011-04-06  Benjamin Poulain  <benjamin.poulain@nokia.com>
3141
3142         Reviewed by Kenneth Rohde Christiansen.
3143
3144         [Qt] LayoutTestController needs to implement numberOfPendingGeolocationPermissionRequests
3145         https://bugs.webkit.org/show_bug.cgi?id=56086
3146
3147         Add the missing method.
3148
3149         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3150         (WebCore::DumpRenderTree::getAllPages): Add a method to return all the pages allocated for the current test.
3151         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3152         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3153         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
3154
3155 2011-04-06  Dai Mikurube  <dmikurube@chromium.org>
3156
3157         Reviewed by David Levin.
3158
3159         Add QUOTA build flag for unified quota API
3160         https://bugs.webkit.org/show_bug.cgi?id=57918
3161
3162         * Scripts/build-webkit: Added QUOTA build flag
3163
3164 2011-04-06  Dirk Pranke  <dpranke@chromium.org>
3165
3166         Reviewed by Tony Chang.
3167
3168         Adjust the apple webkit port's default timeout to match
3169         old-run-webkit-tests at 35 seconds.
3170
3171         https://bugs.webkit.org/show_bug.cgi?id=37738
3172
3173         * Scripts/webkitpy/layout_tests/port/mac.py:
3174
3175 2011-04-06  Scott Cameron  <sccameron@rim.com>
3176
3177         Reviewed by Eric Seidel.
3178
3179         Remove global variable $httpdPath and replace with the return value of
3180         getHTTPDPath().  Also remove unnecessary calls to getHTTPDPath().
3181         https://bugs.webkit.org/show_bug.cgi?id=53499
3182
3183         * Scripts/run-iexploder-tests:
3184         * Scripts/webkitperl/httpd.pm:
3185
3186 2011-04-06  Kevin Ollivier  <kevino@theolliviers.com>
3187
3188         Reviewed by Darin Adler.
3189
3190         Make sure JS_EXPORT_PRIVATE is an empty define when we aren't using the export macros.
3191         
3192         https://bugs.webkit.org/show_bug.cgi?id=27551
3193         
3194         * DumpRenderTree/config.h:
3195         * WebKitAPITest/config.h:
3196         * WebKitTestRunner/config.h:
3197
3198 2011-04-06  Tony Chang  <tony@chromium.org>
3199
3200         Reviewed by Darin Adler.
3201
3202         teach run-webkit-tests to read checksums from png files
3203         https://bugs.webkit.org/show_bug.cgi?id=57993
3204
3205         * Scripts/old-run-webkit-tests: Read the first 2k of a .png if there's
3206           no .checksum and look for the checksum in there.
3207
3208 2011-04-06  David Dorwin  <ddorwin@chromium.org>
3209
3210         Reviewed by David Levin.
3211
3212         Enable fullscreen layout tests for Chromium
3213         https://bugs.webkit.org/show_bug.cgi?id=55726
3214
3215         Make DumpRenderTree always run with fullscreen enabled (equivalent of --enable-fullscreen).
3216
3217         * DumpRenderTree/chromium/WebPreferences.cpp:
3218         (WebPreferences::applyTo):
3219
3220 2011-04-06  Adam Roben  <aroben@apple.com>
3221
3222         Add a "view leaks" link to builds on SnowLeopard Intel Leaks
3223
3224         Fixes <http://webkit.org/b/56032> Leaks viewer should be linked from leaks bot results page
3225
3226         Reviewed by David Kilzer.
3227
3228         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3229         (ExtractTestResults.resultDirectoryURL): Added. Moved code to calculate the URL for the
3230         build's results directory here...
3231         (ExtractTestResults.finished): ...from here.
3232         (ExtractTestResultsAndLeaks): New class that's used by the leaks builder
3233         (ExtractTestResultsAndLeaks.finished): Calls up to the base class, but also adds a "view
3234         leaks" link to point to Leaks Viewer for this build.
3235         (TestFactory): Added ExtractTestResultsClass abstraction. This isn't overridden anywhere,
3236         but it seemed good to add for consistency with BuildAndTestFactory.
3237         (BuildAndTestFactory): Added ExtractTestResultsClass abstraction.
3238         (BuildAndTestLeaksFactory): Use ExtractTestResultsAndLeaks as our ExtractTestResultsClass so
3239         that we'll get a "view leaks" link.
3240
3241 2011-04-06  Zan Dobersek  <zandobersek@gmail.com>
3242
3243         Reviewed by Eric Seidel.
3244
3245         [Gtk] plugins/set-status.html fails
3246         https://bugs.webkit.org/show_bug.cgi?id=57844
3247
3248         Allow an empty status text to be dumped.
3249
3250         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3251         (webViewStatusBarTextChanged):
3252
3253 2011-04-06  Chang Shu  <cshu@webkit.org>
3254
3255         Reviewed by Darin Adler.
3256
3257         WebKitTestRunner needs layoutTestController.pageNumberForElementById
3258         https://bugs.webkit.org/show_bug.cgi?id=42329
3259
3260         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
3261         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3262         (WTR::LayoutTestController::pageNumberForElementById):
3263         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3264
3265 2011-04-06  Sergio Villar Senin  <svillar@igalia.com>
3266
3267         Reviewed by Martin Robinson.
3268
3269         [GTK] DumpRenderTree: do not try to free NULL SoupURIs
3270         https://bugs.webkit.org/show_bug.cgi?id=57932
3271
3272         Some Layout tests have invalid URIs that do not generate valid
3273         SoupURI instances. Do not try to free those NULL SoupURIs.
3274
3275         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3276         (willSendRequestCallback):
3277
3278 2011-04-06  Csaba Osztrogonác  <ossy@webkit.org>
3279
3280         Reviewed by Andreas Kling.
3281
3282         ORWT shouldn't generate diff files for tests without expected files
3283         https://bugs.webkit.org/show_bug.cgi?id=57846
3284
3285         * Scripts/old-run-webkit-tests:
3286
3287 2011-04-05  Kevin Ollivier  <kevino@theolliviers.com>
3288
3289         [wx] Mac build fix. Handle cases where 10.4 SDK is not installed, and also add x86_64 arch
3290         to deps.
3291
3292         * wx/install-unix-extras:
3293
3294 2011-04-05  Sheriff Bot  <webkit.review.bot@gmail.com>
3295
3296         Unreviewed, rolling out r82978, r82999, and r83001.
3297         http://trac.webkit.org/changeset/82978
3298         http://trac.webkit.org/changeset/82999
3299         http://trac.webkit.org/changeset/83001
3300         https://bugs.webkit.org/show_bug.cgi?id=57913
3301
3302         Does not work in Python 2.5 (Requested by abarth on #webkit).
3303
3304         * Scripts/webkitpy/common/system/executive.py:
3305         * Scripts/webkitpy/common/system/executive_unittest.py:
3306
3307 2011-04-05  Chang Shu  <cshu@webkit.org>
3308
3309         Reviewed by Darin Adler.
3310
3311         WebKitTestRunner needs layoutTestController.numberOfPages
3312         https://bugs.webkit.org/show_bug.cgi?id=42694
3313
3314         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
3315         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3316         (WTR::LayoutTestController::numberOfPages):
3317         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3318
3319 2011-04-05  Tony Chang  <tony@chromium.org>
3320
3321         Reviewed by Mihai Parparita.
3322
3323         [chromium] stop putting results downloaded from WebKit Linux in chromium-linux-x86_64
3324         https://bugs.webkit.org/show_bug.cgi?id=57889
3325
3326         * Scripts/webkitpy/layout_tests/port/chromium.py:
3327         * Scripts/webkitpy/layout_tests/port/test.py:
3328         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
3329
3330 2011-04-05  Adam Barth  <abarth@webkit.org>
3331
3332         Silly with statement, from the future!
3333
3334         * Scripts/webkitpy/common/system/executive.py:
3335
3336 2011-04-05  Adam Barth  <abarth@webkit.org>
3337
3338         Reviewed by Tony Chang.
3339
3340         Don't use Exception.message because it's deprecated
3341         https://bugs.webkit.org/show_bug.cgi?id=57892
3342
3343         Suppress the warning for now.  When we move to Python 3, we might need
3344         to something more dramatic.
3345
3346         * Scripts/webkitpy/common/system/executive.py:
3347
3348 2011-04-05  Mihai Parparita  <mihaip@chromium.org>
3349
3350         Reviewed by Ojan Vafai.
3351
3352         Add builders.js to dashboard file list
3353         https://bugs.webkit.org/show_bug.cgi?id=57899
3354
3355         Add file added by http://crrev.com/80538 to dashboard file list.
3356
3357         * TestResultServer/handlers/dashboardhandler.py:
3358
3359 2011-04-05  MORITA Hajime  <morrita@google.com>
3360
3361         Reviewed by Adam Barth.
3362
3363         webkit-patch should print git's stderr when git svn dcommit fail
3364         http://webkit.org/b/57861
3365
3366         * Scripts/webkitpy/common/checkout/scm.py:
3367
3368 2011-04-05  Mihai Parparita  <mihaip@chromium.org>
3369
3370         Reviewed by Tony Chang.
3371
3372         Add --baseline-search-path to NRWT
3373         https://bugs.webkit.org/show_bug.cgi?id=56233
3374         
3375         Add NRWT option to specify additional directories to look for baselines
3376         (will be used by hardware GPU bots which will have local per-bot
3377         expectations for some tests)
3378
3379         * Scripts/webkitpy/common/system/filesystem_mock.py:
3380         * Scripts/webkitpy/layout_tests/port/base.py:
3381         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3382         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3383
3384 2011-04-05  Adam Roben  <aroben@apple.com>
3385
3386         Strip off /results.html from results URLs before trying to load leaks files from them
3387
3388         r82734 changed build.webkit.org's "view results" URLs to point straight to the results.html
3389         files, rather than pointing to the directory that contains them. This is more convenient for
3390         people browsing build.webkit.org, but confused Leaks Viewer.
3391
3392         Fixes <http://webkit.org/b/57869> REGRESSION (r82734): Links in Leaks Viewer's Recent Builds
3393         list don't work
3394
3395         Reviewed by Joseph Pecoraro.
3396
3397         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
3398         (RecentBuildsLoader.prototype.start): Strip off "/results.html" from the results URL.
3399
3400 2011-04-05  Carol Szabo  <carol@webkit.org>
3401
3402         Unreviewed.
3403
3404         Updated my info in committers.py
3405
3406         Scripts\webkitpy\common\config\committers.py 
3407
3408 2011-04-05  Csaba Osztrogonác  <ossy@webkit.org>
3409
3410         Reviewed by Laszlo Gombos.
3411
3412         [Qt] Make WebKitLibraries optional for building QtWebKit
3413         https://bugs.webkit.org/show_bug.cgi?id=57542
3414
3415         * Scripts/build-webkit:
3416
3417 2011-04-05  Chang Shu  <cshu@webkit.org>
3418
3419         Reviewed by Laszlo Gombos.
3420
3421         [Qt] MiniBrowser defaultUrl does not work
3422         https://bugs.webkit.org/show_bug.cgi?id=57021
3423
3424         Match the behavior and coding of MiniBrowser to QtTestBrowser.
3425         * MiniBrowser/qt/main.cpp:
3426         (main):
3427
3428 2011-04-05  Jade Han  <jade.han@nokia.com>
3429
3430         Reviewed by Laszlo Gombos.
3431
3432         [Qt] [Symbian] Disable WebKitTestRunner for Symbian
3433         https://bugs.webkit.org/show_bug.cgi?id=54977
3434
3435         This change is a preparation to enable building webkit2 for Symbian.
3436         Bug 57834 is filed to fix and enable WebKitTestRunner for Symbian.
3437
3438         * Tools.pro:
3439
3440 2011-04-05  Zoltan Horvath  <zoltan@webkit.org>
3441
3442         Reviewed by Andreas Kling.
3443
3444         [Qt] Fix timeoutTimer of MiniBrowser's UrlLoader
3445         https://bugs.webkit.org/show_bug.cgi?id=57832
3446
3447         Only QWKPage has loadFinished signal so connect to it instead of BrowserWindow.
3448
3449         * MiniBrowser/qt/UrlLoader.cpp:
3450         (UrlLoader::UrlLoader):
3451
3452 2011-04-05  Zoltan Horvath  <zoltan@webkit.org>
3453
3454         [Qt] Linux Release minimal build fix after r82919.
3455
3456         * MiniBrowser/qt/BrowserWindow.cpp:
3457         (BrowserWindow::loadURLListFromFile):
3458         * QtTestBrowser/launcherwindow.cpp:
3459         (LauncherWindow::loadURLListFromFile):
3460
3461 2011-04-05  Zoltan Horvath  <zoltan@webkit.org>
3462
3463         Reviewed by Andreas Kling.
3464
3465         [Qt] Make URL loader accessible from testbrowser's menus
3466         https://bugs.webkit.org/show_bug.cgi?id=57823
3467
3468         Add "Load URLs from file" to QtTestBrowser's and to MiniBrowser's menu.
3469
3470         * MiniBrowser/qt/BrowserWindow.cpp:
3471         (BrowserWindow::BrowserWindow):
3472         (BrowserWindow::loadURLListFromFile):
3473         (BrowserWindow::~BrowserWindow):
3474         * MiniBrowser/qt/BrowserWindow.h:
3475         * QtTestBrowser/launcherwindow.cpp:
3476         (LauncherWindow::LauncherWindow):
3477         (LauncherWindow::~LauncherWindow):
3478         (LauncherWindow::createChrome):
3479         (LauncherWindow::loadURLListFromFile):
3480         * QtTestBrowser/launcherwindow.h:
3481
3482 2011-04-04  Sam Weinig  <sam@webkit.org>
3483
3484         Reviewed by Brian Weinstein.
3485
3486         Remove duplicate API from WKContext
3487         <rdar://problem/8727879>
3488         https://bugs.webkit.org/show_bug.cgi?id=57815
3489
3490         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3491         * TestWebKitAPI/Tests/WebKit2/SendingMessagesToTheWebProcessBeforeItIsValid.cpp: Removed.
3492         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3493         Remove SendingMessagesToTheWebProcessBeforeItIsValid since the API it was testing is now removed.
3494
3495 2011-04-04  Tony Chang  <tony@chromium.org>
3496
3497         Reviewed by Ojan Vafai.
3498
3499         [chromium] don't write .checksum files if a fallback platform has an embedded checksum
3500         https://bugs.webkit.org/show_bug.cgi?id=57783
3501
3502         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
3503         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
3504
3505 2011-04-04  Kevin Ollivier  <kevino@theolliviers.com>
3506
3507         [wx] Unreviewed build fix, run uninstall when cleaning to remove built files
3508         from WebKitBuild.
3509
3510         * Scripts/webkitdirs.pm:
3511
3512 2011-04-04  Martin Robinson  <mrobinson@igalia.com>
3513
3514         Reviewed by Gustavo Noronha Silva.
3515
3516         [GTK] WebGL support
3517         https://bugs.webkit.org/show_bug.cgi?id=31517
3518
3519         Add support to the DRT for turning on WebGL when a layout tests requests it.
3520
3521         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3522         (LayoutTestController::overridePreference): Allow turning on WebGL from tests.
3523
3524 2011-04-04  Chang Shu  <cshu@webkit.org>
3525
3526         Reviewed by Darin Adler.
3527
3528         WebKitTestRunner needs layoutTestController.setAllowFileAccessFromFileURLs
3529         https://bugs.webkit.org/show_bug.cgi?id=57572
3530
3531         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
3532         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3533         (WTR::LayoutTestController::setAllowFileAccessFromFileURLs):
3534         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3535
3536 2011-04-04  Keith Kyzivat  <keith.kyzivat@nokia.com>
3537
3538         Reviewed by Csaba Osztrogonác.
3539
3540         [Qt] DumpRenderTree breaks compilation in some uClibc environments
3541         https://bugs.webkit.org/show_bug.cgi?id=57602
3542
3543         * DumpRenderTree/qt/main.cpp:
3544         (get_backtrace):
3545
3546 2011-04-04  Kevin Ollivier  <kevino@theolliviers.com>
3547
3548         [wx] Unreviewed build fix, add new LayoutTestController method stub to wx.
3549
3550         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3551         (LayoutTestController::shadowRoot):
3552
3553 2011-04-04  Pavel Podivilov  <podivilov@chromium.org>
3554
3555         Unreviewed, fix exception in rebaseline tool.
3556
3557         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
3558
3559 2011-04-02  Beth Dakin  <bdakin@apple.com>
3560
3561         Rubber-stamped by Geoff Garen.
3562
3563         For Dan!
3564         * DumpRenderTree/mac/DumpRenderTree.mm:
3565         (resetWebViewToConsistentStateBeforeTesting):
3566
3567 2011-04-02  Beth Dakin  <bdakin@apple.com>
3568
3569         Rubber-stamped by Geoff Garen.
3570
3571         Need to reset the scale, much like zoom.
3572         * DumpRenderTree/mac/DumpRenderTree.mm:
3573         (resetWebViewToConsistentStateBeforeTesting):
3574
3575 2011-04-02  Sam Weinig  <sam@webkit.org>
3576
3577         Reviewed by Beth Dakin.
3578
3579         https://bugs.webkit.org/show_bug.cgi?id=57605
3580         Frame::pageScaleFactor() should not affect getBoundingClientRect() or 
3581         getClientRects()
3582         -and corresponding-
3583         <rdar://problem/9194541>
3584
3585         Add DRT support for the scaleWebView SPI.
3586         * DumpRenderTree/mac/EventSendingController.mm:
3587         (+[EventSendingController isSelectorExcludedFromWebScript:]):
3588         (+[EventSendingController webScriptNameForSelector:]):
3589         (-[EventSendingController scalePageBy:atX:andY:]):
3590         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
3591         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3592         (WTR::EventSendingController::scalePageBy):
3593         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
3594         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3595         (WTR::InjectedBundlePage::reset):
3596
3597 2011-04-02  Dominic Cooney  <dominicc@google.com>
3598
3599         Reviewed by Martin Robinson.
3600
3601         Add layoutTestController.shadowRoot to GTK DumpRenderTree.
3602         https://bugs.webkit.org/show_bug.cgi?id=57551
3603
3604         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3605         (LayoutTestController::shadowRoot):
3606
3607 2011-04-02  Patrick Gansterer  <paroga@webkit.org>
3608
3609         Reviewed by Eric Seidel.
3610
3611         Remove AbstractStep._run_script and move script names to ports.py
3612         https://bugs.webkit.org/show_bug.cgi?id=57704
3613
3614         Replace deprecated _run_script with _tool.executive.run_and_throw_if_fail.
3615
3616         * Scripts/webkitpy/common/config/ports.py:
3617         * Scripts/webkitpy/tool/commands/download_unittest.py:
3618         * Scripts/webkitpy/tool/commands/roll_unittest.py:
3619         * Scripts/webkitpy/tool/commands/upload_unittest.py:
3620         * Scripts/webkitpy/tool/steps/abstractstep.py:
3621         * Scripts/webkitpy/tool/steps/checkstyle.py:
3622         * Scripts/webkitpy/tool/steps/preparechangelog.py:
3623         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py:
3624         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
3625
3626 2011-04-02  Patrick Gansterer  <paroga@webkit.org>
3627
3628         Reviewed by Eric Seidel.
3629
3630         Emulate shebang on Win32
3631         https://bugs.webkit.org/show_bug.cgi?id=55927
3632
3633         Scripts on Windows work only if they are called with the explicit interpreter.
3634         Read the first line of scripts to detect the correct executable.
3635
3636         * Scripts/webkitpy/common/config/ports.py:
3637         * Scripts/webkitpy/common/system/executive.py: Added interpreter_for_script().
3638         * Scripts/webkitpy/common/system/executive_unittest.py:
3639
3640 2011-04-01  Adam Barth  <abarth@webkit.org>
3641
3642         Reviewed by Eric Seidel.
3643
3644         apos entities shouldn't show up in ChangeLogs when using webkit-patch
3645         https://bugs.webkit.org/show_bug.cgi?id=57692
3646
3647         Previously, we were using BeautifulSoup to process XML from
3648         bugs.webkit.org, but that's incorrect.  We should be using
3649         BeautifulStoneSoup to process the XML.  We were getting the &apos;
3650         entity wrong because &apos; is an XML entity but not an HTML entity.
3651
3652         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3653         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
3654
3655 2011-04-01  Sheriff Bot  <webkit.review.bot@gmail.com>
3656
3657         Unreviewed, rolling out r82721.
3658         http://trac.webkit.org/changeset/82721
3659         https://bugs.webkit.org/show_bug.cgi?id=57687
3660
3661         This patch introduced assertion failures on the GTK+ bots.
3662         (Requested by mrobinson on #webkit).
3663
3664         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3665         (LayoutTestController::shadowRoot):
3666
3667 2011-04-01  Csaba Osztrogonác  <ossy@webkit.org>
3668
3669         Unreviewed buildfix.
3670
3671         [Qt][WK2] Build Webkit2 using "-2" option on Qt
3672         https://bugs.webkit.org/show_bug.cgi?id=55074
3673
3674         * Scripts/build-webkit: Ensure that "-2" isn't passed to qmake.
3675         (The isWK2() function removes it from @ARGV, but not from @options.)
3676
3677 2011-04-01  Keith Kyzivat  <keith.kyzivat@nokia.com>
3678
3679         Reviewed by Csaba Osztrogonác.
3680
3681         [Qt] [WK2] MiniBrowser.qrc not found - regression from rev 82671
3682         https://bugs.webkit.org/show_bug.cgi?id=57666
3683
3684         * MiniBrowser/qt/MiniBrowser.qrc: Renamed from Tools/MiniBrowser/MiniBrowser.qrc.
3685
3686 2011-04-01  Dirk Pranke  <dpranke@chromium.org>
3687
3688         Reviewed by Adam Barth.
3689
3690         new-run-webkit-tests: fix feature detection, skipped platform lists on mac
3691
3692         We apparently never implemented the code to skip tests based on
3693         what was compiled into DRT. Also, change the logic used to skip
3694         platform directories to match what old-run-webkit-tests does: 
3695         skip every test not in a directory in the baseline search path.
3696
3697         https://bugs.webkit.org/show_bug.cgi?id=57662
3698
3699         * Scripts/webkitpy/layout_tests/port/mac.py:
3700         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3701         * Scripts/webkitpy/layout_tests/port/webkit.py:
3702
3703 2011-03-29  Mark Rowe  <mrowe@apple.com>
3704
3705         Reviewed by Jon Honeycutt.
3706
3707         <http://webkit.org/b/56730> new-run-webkit-tests fails on Lion seed
3708
3709         Teach new-run-webkit-tests about the concept of an unreleased version of Mac OS X.
3710
3711         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3712         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
3713         * Scripts/webkitpy/layout_tests/port/mac.py:
3714         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3715
3716 2011-04-01  Chang Shu  <cshu@webkit.org>
3717
3718         Reviewed by Csaba Osztrogonác.
3719
3720         [Qt][WK2] Build Webkit2 using "-2" option on Qt
3721         https://bugs.webkit.org/show_bug.cgi?id=55074
3722
3723         * Scripts/build-webkit:
3724
3725 2011-04-01  Dirk Pranke  <dpranke@chromium.org>
3726
3727         Reviewed by Tony Chang.
3728
3729         new-run-webkit-tests: remove spurious port version override in webkit.py
3730         base.py provides a default implementation so this is just
3731         breaking things.
3732
3733         https://bugs.webkit.org/show_bug.cgi?id=57667
3734
3735         * Scripts/webkitpy/layout_tests/port/webkit.py:
3736         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3737
3738 2011-04-01  Csaba Osztrogonác  <ossy@webkit.org>
3739
3740         Reviewed by Adam Roben.
3741
3742         Make view results on waterfall direct link to results.html
3743         https://bugs.webkit.org/show_bug.cgi?id=57671
3744
3745         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add "/results.html" to the URL.
3746         * Scripts/old-run-webkit-tests: Add links to httpd access and error logs.
3747
3748 2011-04-01  Sam Weinig  <sam@webkit.org>
3749
3750         Fix windows build.
3751
3752         * TestWebKitAPI/Tests/WebKit2/win/HideFindIndicator.cpp:
3753         (TestWebKitAPI::TEST):
3754         * TestWebKitAPI/Tests/WebKit2/win/ResizeViewWhileHidden.cpp:
3755         (TestWebKitAPI::flushMessages):
3756
3757 2011-04-01  Sam Weinig  <sam@webkit.org>
3758
3759         Reviewed by Adam Roben.
3760
3761         Add adoptWK to WKRetainPtr.h
3762         https://bugs.webkit.org/show_bug.cgi?id=57670
3763
3764         * TestWebKitAPI/PlatformUtilities.h:
3765         * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp:
3766         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
3767         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest_Bundle.cpp:
3768         * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp:
3769         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp:
3770         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
3771         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly.cpp:
3772         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp:
3773         (TestWebKitAPI::createSessionStateContainingFormData):
3774         * WebKitTestRunner/StringFunctions.h:
3775         Replace custom versions of adoptWK with the API on in WebKit2/WKRetainPtr.h.
3776
3777 2011-04-01  Sam Weinig  <sam@webkit.org>
3778
3779         Reviewed by Adam Roben.
3780
3781         Fix leak noticed by Adam Roben in LayoutTestController::shadowRoot.
3782
3783         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3784         (WTR::LayoutTestController::shadowRoot):
3785         Make judicious use of adoptWK().
3786
3787 2011-04-01  Sam Weinig  <sam@webkit.org>
3788
3789         Reviewed by Timothy Hatcher.
3790
3791         Fix extract-localizable-strings for macro change from UI_STRING -> WEB_UI_STRING.