a205f2e8372ae423bd36eaf7a887d50128a69d39
[WebKit.git] / Tools / ChangeLog
1 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
2
3         Unreviewed, build fix.
4
5         Actually make the changes suggested by Mihai in his review
6         of bug 53720 :(
7
8         https://bugs.webkit.org/show_bug.cgi?id=53720
9
10         * Scripts/webkitpy/layout_tests/port/test_files.py:
11         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
12
13 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
14
15         Reviewed by Mihai Parparita.
16
17         new-run-webkit-tests: Fix bug introduced in r77434 that was
18         causing us to run the canvas GPU tests on the Mac GPU port. This
19         bug revealed that we were not setting the port.name() field
20         properly in many cases, so I've cleaned up all of that code, and
21         removed a few comments about "version-specific" GPU ports that
22         don't exist and just confused things.
23
24         Testing also revealed that port.abspath_for_test() wasn't
25         normalizing paths on Windows properly, so I fixed that as well.
26
27         https://bugs.webkit.org/show_bug.cgi?id=53719
28
29         * Scripts/webkitpy/layout_tests/port/base.py:
30         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
31         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
32
33 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
34
35         Reviewed by Mihai Parparita.
36
37         new-run-webkit-tests: fix normalization of paths on windows when gathering files
38
39         r77434 introduced a bug that was causing the test expectations
40         for the GPU ports to not be treated properly. It turns out that
41         when we gathered the list of test files on Windows, we would
42         return paths of the form "c:\LayoutTests/fast/canvas", and the
43         mixture of backslashes and forward slashes was confusing things.
44
45         This patch normalizes all of the filenames returned from
46         test_files.find(), and adds better tests for this (fixing a
47         couple of other bugs found in the meantime).
48
49         https://bugs.webkit.org/show_bug.cgi?id=53720
50
51         * Scripts/webkitpy/layout_tests/port/test.py:
52         * Scripts/webkitpy/layout_tests/port/test_files.py:
53         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
54
55 2011-02-03  Adam Roben  <aroben@apple.com>
56
57         Add links to Windows crash logs in results.html
58
59         Fixes <http://webkit.org/b/53718> run-webkit-tests should link to Windows crash logs in
60         results.html
61
62         Reviewed by David Kilzer.
63
64         * Scripts/old-run-webkit-tests:
65         (top level): Added $crashLogTag and $windowsCrashLogFilePrefix (which came from
66         createDebuggerCommandFile).
67         (testCrashedOrTimedOut): If the test crashed, capture any saved crash log after the dump
68         tool has exited.
69         (captureSavedCrashLog): Added. Finds the crash log for the test that just crashed and moves
70         it into the test results directory tree. Only implemented for Cygwin currently.
71         (findNewestFileMatchingGlob): Added. Does what it says.
72         (htmlForResultsSection): Only link to files that exist.
73         (linksForErrorTest): Add a link to the crash log.
74         (deleteExpectedAndActualResults): Delete any old crash log for this test.
75         (createDebuggerCommandFile): Use the new $windowsCrashLogFilePrefix constant instead of
76         hardcoding it here.
77
78 2011-02-03  Adam Roben  <aroben@apple.com>
79
80         Tell the debugger the path to the WebKit source tree when saving a crash log
81
82         This allows the debugger to include the crashing line of code in the log.
83
84         Fixes <http://webkit.org/b/53678> Crash logs from buildslaves don't show the crashing line
85         of code
86
87         Reviewed by Sam Weinig.
88
89         * Scripts/old-run-webkit-tests:
90         (createDebuggerCommandFile): Added. Saves commands that we'd like the debugger to run to a
91         file and returns the path to that file. The commands we pass came from
92         setUpWindowsCrashLogSaving, but I've added a .srcpath command to tell the debugger where the
93         WebKit source code lives.
94         (setUpWindowsCrashLogSaving): Instead of specifying the commands directly on the command
95         line using -c, save them to a file and specify the path to that file using -cf. This works
96         around what is presumably a bug in Windows's command line parsing, where having multiple
97         quoted paths in the debugger commands causes the post-mortem debugger not to be invoked at
98         all. Also pulled the options we pass to the debugger out into a list that is then join()ed
99         together to make them easier to modify in the future.
100
101 2011-02-02  Sam Weinig  <sam@webkit.org>
102
103         Reviewed by Anders Carlsson.
104
105         Add notification of the end of a rubber band.
106         <rdar://problem/8940648>
107
108         * MiniBrowser/mac/BrowserWindowController.m:
109         (-[BrowserWindowController awakeFromNib]):
110         * WebKitTestRunner/TestController.cpp:
111         (WTR::TestController::createOtherPage):
112         (WTR::TestController::initialize):
113         Stub out the new WKUIClient function.
114
115 2011-02-03  Gabor Rapcsanyi  <rgabor@webkit.org>
116
117         Unreviewed.
118
119         Adding myself to committers.py.
120
121         * Scripts/webkitpy/common/config/committers.py:
122
123 2011-02-03  Balazs Kelemen  <kbalazs@webkit.org>
124
125         Reviewed by Csaba Osztrogonác.
126
127         [Qt][WK2] MiniBrowser's window size should be 800x600
128         https://bugs.webkit.org/show_bug.cgi?id=53670
129
130         Make layout test failure debugging easier.
131         * MiniBrowser/qt/BrowserWindow.cpp:
132         (BrowserWindow::BrowserWindow):
133
134 2011-02-02  Andy Estes  <aestes@apple.com>
135
136         Reviewed by Mark Rowe.
137
138         'update-webkit' should handle OpenSource and Internal using different
139         VCSs.
140
141         * Scripts/update-webkit: Re-check the VCS type when updating Apple's
142         Internal directory.
143
144 2011-02-02  Dirk Pranke  <dpranke@chromium.org>
145
146         Reviewed by Mihai Parparita.
147
148         new-run-webkit-tests: hardcode the directories to scan for tests
149         for GPU bots instead of SKIPping them. See bug 53562 for some
150         context, but we will now hard-code the list of directories to
151         use by default instead of skipping over directories in the
152         expectations file. We do this so that we will be able to merge
153         the expectations files without getting conflicting SKIP
154         directives. Note that this change will reduce the # of tests
155         being run on the Mac GPU bots, because we're accidentally
156         including some today.
157
158         https://bugs.webkit.org/show_bug.cgi?id=53631
159
160         * Scripts/webkitpy/layout_tests/port/base.py:
161         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
162         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
163
164 2011-02-02  Sam Weinig  <sam@webkit.org>
165
166         Reviewed by Beth Dakin.
167
168         Add ChromeClient function to paint custom overhang areas.
169         https://bugs.webkit.org/show_bug.cgi?id=53639
170
171         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
172         (WTR::InjectedBundlePage::InjectedBundlePage):
173         Stub out new callback.
174
175 2011-02-02  Dirk Pranke  <dpranke@chromium.org>
176
177         Reviewed by Tony Chang.
178
179         new-run-webkit-tests: support chromium code paths in mock_drt
180
181         https://bugs.webkit.org/show_bug.cgi?id=53471
182
183         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
184         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
185
186 2011-02-02  Adam Klein  <adamk@chromium.org>
187
188         Reviewed by Tony Chang.
189
190         Update new-run-webkit-tests --chromium to put output under Source/...
191         https://bugs.webkit.org/show_bug.cgi?id=53612
192
193         * BuildSlaveSupport/test-result-archive:
194         * Scripts/webkitpy/layout_tests/port/chromium.py:
195
196 2011-01-28  Tony Chang  <tony@chromium.org>
197
198         Reviewed by Eric Seidel.
199
200         [chromium] remove --use-test-shell from NRWT
201         https://bugs.webkit.org/show_bug.cgi?id=53346
202
203         I've already started removing some of the bindings like eventSender so
204         this already doesn't work isn't useful.  Also updated some comments to
205         refer to DRT instead of test_shell.
206
207         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
208         * Scripts/webkitpy/layout_tests/port/chromium.py:
209         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
210         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
211         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
212         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
213         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
214         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
215
216 2011-02-02  Steve Lacey  <sjl@chromium.org>
217
218         Reviewed by Eric Carlson.
219
220         Implement basic media statistics on media elements.
221         https://bugs.webkit.org/show_bug.cgi?id=53322
222
223         * Scripts/build-webkit:
224
225 2011-02-02  Kevin Ollivier  <kevino@theolliviers.com>
226
227         [wx] Build fixes for wxWebKit.
228
229         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
230         (LayoutTestController::setSerializeHTTPLoads):
231         * wx/browser/wscript:
232         * wx/build/build_utils.py:
233         * wx/build/settings.py:
234
235 2011-02-01  Dirk Pranke  <dpranke@chromium.org>
236
237         Reviewed by Mihai Parparita.
238
239         new-run-webkit-tests: stop skipping so many tests
240
241         r77163 introduced a regression where we weren't resetting test
242         expectations properly and were skipping too many tests as a
243         result. This patch fixes that and adds a test for it.
244
245         https://bugs.webkit.org/show_bug.cgi?id=53551
246
247         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
248         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
249
250 2011-02-01  Dirk Pranke  <dpranke@chromium.org>
251
252         Reviewed by Tony Chang.
253
254         new-run-webkit-tests: add first stub of test_runner2. This
255         will add support for the 'inline', 'threads', and 'processes'
256         flags to --worker-model, but for now the implementatios just
257         fall back on the old ones.
258
259         https://bugs.webkit.org/show_bug.cgi?id=53157
260
261         * Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
262         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
263
264 2011-02-01  Mihai Parparita  <mihaip@chromium.org>
265
266         Reviewed by James Robinson.
267
268         [Chromium] run-chromium-webkit-unit-tests looks for binaries in the wrong place
269         https://bugs.webkit.org/show_bug.cgi?id=53522
270
271         * Scripts/run-chromium-webkit-unit-tests:
272
273 2011-02-01  Adam Barth  <abarth@webkit.org>
274
275         Reviewed by Mihai Parparita.
276
277         Using Control-C to cancel webkit-patch or other python tools causes
278         unpleasant traceback console spew
279         https://bugs.webkit.org/show_bug.cgi?id=53462
280
281         Catch the exception and don't print the stack trace.
282
283         * Scripts/webkit-patch:
284
285 2011-02-01  Scott Cameron  <sccameron@rim.com>
286
287         Reviewed by Daniel Bates.
288
289         Use Windows format for MinGW HTTPD path.
290         https://bugs.webkit.org/show_bug.cgi?id=53503
291
292         * Scripts/webkitperl/httpd.pm:
293           - Use single-quotes around MySys value for $httpdPath in getHTTPDPath()
294             so that we don't have to escape the space characters in the path. Also,
295             changed path to Windows-style path and removed FIXME comment.
296
297 2011-02-01  Balazs Kelemen  <kbalazs@webkit.org>
298
299         Reviewed by Andreas Kling.
300
301         [Qt][WK2] Add a way to use shared process model in MiniBrowser
302         https://bugs.webkit.org/show_bug.cgi?id=53090
303
304         * MiniBrowser/qt/BrowserView.cpp:
305         (BrowserView::BrowserView): Removed the m_context member.
306         From now the context is guaranteed to be non-null and we
307         don't need to store that in the object.
308         * MiniBrowser/qt/BrowserView.h:
309         * MiniBrowser/qt/BrowserWindow.cpp:
310         Added static bool to determine that new windows need to be
311         created with their own context or not. Use the same context
312         and web process by default to be inilne with the other ports.
313         (BrowserWindow::BrowserWindow):
314         (BrowserWindow::newWindow):
315         * MiniBrowser/qt/BrowserWindow.h:
316         * MiniBrowser/qt/main.cpp:
317         (main): Added command line switch to be able to use the
318         non-shared process model. Simplify the handling of the command line
319         switches a little bit.
320
321 2011-02-01  Zoltan Horvath  <zoltan@webkit.org>
322
323         Reviewed by Andreas Kling.
324
325         [Qt] Add Window menu and Toggle FullScreen action to MiniBrowser.
326         https://bugs.webkit.org/show_bug.cgi?id=53491
327
328         * MiniBrowser/qt/BrowserWindow.cpp:
329         (BrowserWindow::BrowserWindow):
330         (BrowserWindow::toggleFullScreenMode):
331         * MiniBrowser/qt/BrowserWindow.h:
332
333 2011-02-01  Zoltan Horvath  <zoltan@webkit.org>
334
335         Reviewed by Andreas Kling.
336
337         [Qt] Add Toggle Frame Flattening, Auto Load Images and Disable JavaScript actions to MiniBrowser.
338         https://bugs.webkit.org/show_bug.cgi?id=53489
339
340         Add Toggle Frame Flattening action to Develop menu. Add Auto Load Images and Disable JavaScript actions
341         to Settings menu.
342
343         * MiniBrowser/qt/BrowserWindow.cpp:
344         (BrowserWindow::BrowserWindow):
345         (BrowserWindow::toggleFrameFlattening):
346         (BrowserWindow::toggleDisableJavaScript):
347         (BrowserWindow::toggleAutoLoadImages):
348         * MiniBrowser/qt/BrowserWindow.h:
349
350 2011-01-31  Mihai Parparita  <mihaip@chromium.org>
351
352         Reviewed by Tony Chang.
353
354         [Chromium] Switch chromium-mac to use ChromiumDriver
355         https://bugs.webkit.org/show_bug.cgi?id=53461
356         
357         For the sake of consistency with the other Chromium platforms (and so
358         that chromium-mac picks up special flags like --enable-hardware-gpu),
359         switch chromium-mac from the WebKitDriver to ChromiumDriver.
360
361         * Scripts/webkitpy/layout_tests/port/chromium.py:
362
363 2011-01-31  Dirk Pranke  <dpranke@chromium.org>
364
365         Reviewed by Mihai Parparita.
366
367         The current modifier parsing code in test_expectations is
368         fragile and hard-coded, so it's not easy to understand the logic
369         or easily add new types of modifiers (like GPU vs. CPU testing
370         for graphics tests, or 32-bit vs. 64-bit differences).
371
372         This is the first of two patches that will add in more generic
373         support and then eliminate the GPU-specific test expectations
374         files for Chromium.
375
376         This patch adds two standalone objects for handling modifiers. The
377         rules for interpreting modifiers, precedence, and conflicts are
378         given in the docstring to the ModifierMatcher class, which
379         returns ModifierMatchResult objects.
380         
381         This patch also adds routines to the Port interface and a
382         default set of values in the base object, in order to obtain the
383         values needed on a given test run. These values are then passed
384         to the expectation parser. This also allows us to clean up the
385         logic used to lint all of the different configurations in a
386         single test_expectations.txt file.
387
388         The next patch will merge in the separate GPU expectations file.
389
390         https://bugs.webkit.org/show_bug.cgi?id=51222
391
392         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
393         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
394         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
395         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
396         * Scripts/webkitpy/layout_tests/port/base.py:
397         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
398         * Scripts/webkitpy/layout_tests/port/chromium.py:
399         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
400         * Scripts/webkitpy/layout_tests/port/test.py:
401         * Scripts/webkitpy/layout_tests/port/webkit.py:
402         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
403         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
404         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
405         * Tools/Scripts/webkitpy/style/checkers/test_expectations.py:
406         * Tools/Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
407
408 2011-01-31  Scott Cameron  <sccameron@rim.com>
409
410         Reviewed by Daniel Bates.
411
412         update run-webkit-httpd to be able to launch Apache2.2 in a MSYS environment
413         https://bugs.webkit.org/show_bug.cgi?id=50036
414
415         This will add an Apache2.2 configuration file and modifies scripts to allow
416         running an httpd server in an MSYS environment.
417
418         The default Apache2.2 installation path has been preserved and PHP5 modules disabled
419         in order to allow for simple installation/execution.  Simply install the latest
420         Apache2.2 version with OpenSSL from http://httpd.apache.org/download.cgi#apache22 to
421         be able to execute run-webkit-httpd.
422         
423
424         * Scripts/run-webkit-httpd:
425         * Scripts/webkitperl/httpd.pm:
426
427 2011-01-31  Tony Chang  <tony@chromium.org>
428
429         Reviewed by Eric Seidel.
430
431         mac DRT should report RTL scroll offset relative to top right corner
432         https://bugs.webkit.org/show_bug.cgi?id=53324
433
434         * DumpRenderTree/mac/DumpRenderTree.mm:
435         (dumpFrameScrollPosition):
436
437 2011-01-31  Zoltan Horvath  <zoltan@webkit.org>
438
439         Reviewed by Andreas Kling.
440
441         [Qt] Add Take Screen Shot action to MiniBrowser
442         https://bugs.webkit.org/show_bug.cgi?id=53422
443
444         Add Take Screen Shot action to MiniBrowser's view menu.
445
446         * MiniBrowser/qt/BrowserWindow.cpp:
447         (BrowserWindow::BrowserWindow):
448         (BrowserWindow::screenshot):
449         * MiniBrowser/qt/BrowserWindow.h:
450
451 2011-01-31  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
452
453         Reviewed by Xan Lopez.
454
455         [GTK] REGRESSION:  http/tests/media/video-{cookie,referer}.html failing
456         https://bugs.webkit.org/show_bug.cgi?id=53379
457
458         Remove left over #ifdef's. I thought all of the conditional code
459         had been freed from the condition, but I forgot to check DRT.
460
461         * DumpRenderTree/gtk/DumpRenderTree.cpp:
462         (resetDefaultsToConsistentValues):
463         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
464         (LayoutTestController::setAlwaysAcceptCookies):
465
466 2011-01-30  Dirk Pranke  <dpranke@chromium.org>
467
468         Unreviewed, build fix.
469
470         Fix regression introduced in r77093 - path.rsplit() doesn't
471         take keyword arguments.
472
473         https://bugs.webkit.org/show_bug.cgi?id=53326
474
475         * Scripts/webkitpy/common/system/filesystem_mock.py:
476
477 2011-01-30  Dirk Pranke  <dpranke@chromium.org>
478
479         Reviewed by Mihai Parparita.
480
481         Add more unit tests for rebaseline-chromium-webkit-tests. This
482         change involves restructuring a bunch of r-c-w-t code to make it
483         more testable as well. We also add wrapper classes for handling
484         testing zip files and fetching URLs.
485
486         https://bugs.webkit.org/show_bug.cgi?id=53040
487
488         * Scripts/webkitpy/common/system/urlfetcher.py:
489         * Scripts/webkitpy/common/system/urlfetcher_mock.py:
490         * Scripts/webkitpy/common/system/zipfileset_mock.py:
491         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
492         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
493         * Scripts/webkitpy/tool/mocktool.py:
494
495 2011-01-30  Dirk Pranke  <dpranke@chromium.org>
496
497         Reviewed by Eric Seidel.
498
499         Clean up of the filesystem-related modules used in webkitpy.
500         I've added relpath() to the filesystem interface, modified
501         ospath.relpath() so that it could work with the filesystem
502         interface, and modified the fileset* routines to use the
503         filesystem interface consistently.
504
505         This patch also adds a close() routine to the fileset routines
506         to indicate that the caller is done with the fileset. This
507         allows zipfileset to clean up after itself when it creates
508         tempfiles to store downloads.
509
510         https://bugs.webkit.org/show_bug.cgi?id=53326
511
512         * Scripts/webkitpy/common/system/directoryfileset.py:
513         * Scripts/webkitpy/common/system/fileset.py:
514         * Scripts/webkitpy/common/system/filesystem.py:
515         * Scripts/webkitpy/common/system/filesystem_mock.py:
516         * Scripts/webkitpy/common/system/filesystem_unittest.py:
517         * Scripts/webkitpy/common/system/ospath.py:
518         * Scripts/webkitpy/common/system/zipfileset.py:
519         * Scripts/webkitpy/common/system/zipfileset_unittest.py:
520
521 2011-01-30  Balazs Kelemen  <kbalazs@webkit.org>
522
523         Reviewed by Csaba Osztrogonác.
524
525         [Qt][WK2]REGRESSION (r76991): Fix build errors
526         https://bugs.webkit.org/show_bug.cgi?id=53400
527
528         Revert the temporary build fix (http://trac.webkit.org/changeset/77088)
529         and remove WebKit2Prefix.h from the build.
530         * MiniBrowser/qt/MiniBrowser.pro:
531
532 2011-01-30  Csaba Osztrogonác  <ossy@webkit.org>
533
534         Unreviewed.
535
536         [Qt][WK2] Buildfix.
537
538         * MiniBrowser/qt/MiniBrowser.pro:
539
540 2011-01-28  Simon Fraser  <simon.fraser@apple.com>
541
542         Reviewed by Adam Roben.
543         
544         define NOMINMAX when building ImageDiff, as we do elsewhere.
545
546         Add various clampToInt() methods to MathExtras.h
547         https://bugs.webkit.org/show_bug.cgi?id=52910
548
549         * DumpRenderTree/win/ImageDiffCommon.vsprops:
550
551 2011-01-28  Maciej Stachowiak  <mjs@apple.com>
552
553         Reviewed by Darin Adler.
554
555         WebKitTestRunner needs layoutTestController.setPOSIXLocale
556         https://bugs.webkit.org/show_bug.cgi?id=42682
557
558         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
559         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
560         (WTR::InjectedBundle::resetLocalSettings):
561         (WTR::InjectedBundle::didReceiveMessage):
562         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
563         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
564         (WTR::LayoutTestController::setPOSIXLocale):
565         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
566
567 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
568  
569          Reviewed by Mihai Parparita.
570  
571          test-webkitpy: fix webkitpy.layout_tests.port.mac_unittest.MacTest.test_skipped_file_paths
572  
573          This patch re-enables this test and changes it to
574          handle all of the mac platform versions, not just the one
575          it is running on.
576  
577          https://bugs.webkit.org/show_bug.cgi?id=53356
578  
579          * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
580  
581 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
582
583         Unreviewed, build fix.
584
585         Take two. The fix in 77023 didn't work, because we were
586         still calling path.abspath_to_uri, which calls _cygpath under
587         the covers, and it appears the cygpath on the bots does
588         something different than it does on my machine. This patch
589         removes the calls to path.abspath_to_uri, so it should be safe.
590         If it doesn't work, I'll roll it out along with r76982 and 77023.
591
592         https://bugs.webkit.org/show_bug.cgi?id=53126
593
594         * Scripts/webkitpy/layout_tests/port/test.py:
595
596 2011-01-28  David Kilzer  <ddkilzer@apple.com>
597
598         <rdar://problem/8930699> build-webkit gives a bogus warning with newer versions of Xcode 
599         <http://webkit.org/b/53353>
600
601         Reviewed by Mark Rowe.
602
603         * Scripts/webkitdirs.pm:
604         (checkRequiredSystemConfig): Check the Xcode marketing version
605         in addition to the DevCoreTools build version before complaining
606         about an old version of Xcode.  Also make the Mac OS X version
607         check use Perl's built-in version string comparitor.
608
609 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
610
611         Unreviewed, build fix.
612
613         Work around breakage on Win 7 Release bot caused by r76982
614         and the fact that windows ports use "file:////" instead of
615         "file:///". Ideally the test code should be isolated from
616         this, but it isn't yet. Will fix properly in a bit.
617
618         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
619
620 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
621
622         Reviewed by Tony Chang.
623
624         new-run-webkit-tests: change worker model values to
625         "old-inline", "old-threads" in preparation for test_runner2 /
626         multiprocessing changes.
627
628         https://bugs.webkit.org/show_bug.cgi?id=53156
629
630         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
631         * Scripts/webkitpy/layout_tests/port/base.py:
632         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
633         * Scripts/webkitpy/layout_tests/port/mac.py:
634         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
635
636 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
637
638         Reviewed by Tony Chang.
639
640         committers.py - add an IRC nickname for dpranke
641         https://bugs.webkit.org/show_bug.cgi?id=53335
642
643         * Scripts/webkitpy/common/config/committers.py:
644
645 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
646
647         Reviewed by Tony Chang.
648
649         new-run-webkit-tests: add a "mock DRT" port implementation
650         and a separate class that emulates what we expect the
651         DumpRenderTree behavior to be.
652
653         This will eventually replace port/dryrun.py and allow us to get
654         better test coverage of the new-run-webkit-tests code as well as
655         a reference for what new-run-webkit-tests expects from DRT.
656
657         This is the first attempt at this, and it is pretty bare-boned. It
658         really only has been tested on the 'mac' port (and a little on
659         the 'chromium-mac' port.
660
661         https://bugs.webkit.org/show_bug.cgi?id=53126
662
663         * Scripts/webkitpy/common/system/filesystem_mock.py:
664         * Scripts/webkitpy/layout_tests/port/dryrun.py:
665         * Scripts/webkitpy/layout_tests/port/factory.py:
666         * Scripts/webkitpy/layout_tests/port/mock_drt.py: Added.
667         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Added.
668         * Scripts/webkitpy/layout_tests/port/test.py:
669
670 2011-01-28  Pratik Solanki  <psolanki@apple.com>
671
672         Unreviewed. Removing .swp file checked in by mistake.
673
674         * Scripts/.webkitdirs.pm.swp: Removed.
675
676 2011-01-28  Pratik Solanki  <psolanki@apple.com>
677
678         Reviewed by David Kilzer.
679
680         Space not necessary for undefined feature
681         https://bugs.webkit.org/show_bug.cgi?id=53317
682
683         * Scripts/build-webkit:
684
685 2011-01-28  Chang Shu  <chang.shu@nokia.com>
686
687         Reviewed by Andreas Kling.
688
689         Reset NetworkAccessManager to clean up credentials from previous tests.
690         This change causes no performance overhead either.
691         https://bugs.webkit.org/show_bug.cgi?id=36688
692
693         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
694         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
695         (WebCore::DumpRenderTree::open):
696         * DumpRenderTree/qt/DumpRenderTreeQt.h:
697
698 2011-01-28  Zoltan Horvath  <zoltan@webkit.org>
699
700         Reviewed by Andreas Kling.
701
702         [Qt] Add Zoom Text Only action to MiniBrowser
703         https://bugs.webkit.org/show_bug.cgi?id=53297
704
705         Add Zoom Text Only action to MiniBrowser's view menu, change zoom levels to avoid unnecessary divides.
706
707         * MiniBrowser/qt/BrowserWindow.cpp:
708         (BrowserWindow::BrowserWindow):
709         (BrowserWindow::zoomIn):
710         (BrowserWindow::zoomOut):
711         (BrowserWindow::resetZoom):
712         (BrowserWindow::toggleZoomTextOnly):
713         (BrowserWindow::applyZoom):
714         * MiniBrowser/qt/BrowserWindow.h:
715
716 2011-01-28  Adam Barth  <abarth@webkit.org>
717
718         Reviewed by Eric Seidel.
719
720         Add webkit-patch roll-chromium-deps
721         https://bugs.webkit.org/show_bug.cgi?id=53288
722
723         This command updates the Source/WebKit/chromium/DEPS file with the
724         last-known good revision of Chromium (or a revision specified on the
725         command line).  I'd eventually like to turn this into a SheriffBot
726         command, but this is the first step.
727
728         This patch somewhat sprawled because I needed to move a bunch of code
729         out of ChangeLog that should never have been there in the first place.
730         Also, I had to fix a bug in MockUser in order to test the new command.
731
732         * Scripts/webkitpy/common/checkout/api.py:
733         * Scripts/webkitpy/common/checkout/changelog.py:
734         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
735         * Scripts/webkitpy/common/checkout/deps.py: Added.
736         * Scripts/webkitpy/common/config/urls.py:
737         * Scripts/webkitpy/tool/commands/__init__.py:
738         * Scripts/webkitpy/tool/commands/download_unittest.py:
739         * Scripts/webkitpy/tool/commands/roll.py: Added.
740         * Scripts/webkitpy/tool/commands/roll_unittest.py: Added.
741         * Scripts/webkitpy/tool/commands/upload_unittest.py:
742         * Scripts/webkitpy/tool/mocktool.py:
743         * Scripts/webkitpy/tool/steps/__init__.py:
744         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py: Added.
745         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
746         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py: Added.
747         * Scripts/webkitpy/tool/steps/suggestreviewers_unittest.py:
748         * Scripts/webkitpy/tool/steps/updatechromiumdeps.py: Added.
749         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
750
751 2011-01-27  Greg Coletta  <greg.coletta@nokia.com>
752
753         Reviewed by Laszlo Gombos.
754
755         Get rid of prefix header dependency for WebKit2 build system
756         https://bugs.webkit.org/show_bug.cgi?id=50174
757
758         Change the style checker so that it enforces config.h include for
759         WebKit2.
760
761         * Scripts/webkitpy/style/checker.py:
762
763 2011-01-27  Maciej Stachowiak  <mjs@apple.com>
764
765         Reviewed by Darin Adler.
766
767         execCommand("Paste") doesn't work in WebKitTestRunner
768         https://bugs.webkit.org/show_bug.cgi?id=52785
769
770         Enable both of the settings needed to allow paste.
771         
772         * WebKitTestRunner/TestController.cpp:
773         (WTR::TestController::resetStateToConsistentValues):
774
775 2011-01-27  Jacob Dinu  <dinu.jacob@nokia.com>
776
777         Reviewed by Andreas Kling.
778
779         [Qt] QtTestBrowser: User input lost when toggling use of QGraphicsView
780         https://bugs.webkit.org/show_bug.cgi?id=48440
781
782         Preserve user input when toggling use of QGraphicsView
783
784         * QtTestBrowser/launcherwindow.cpp:
785         (LauncherWindow::initializeView):
786         (LauncherWindow::loadFinished):
787         * QtTestBrowser/launcherwindow.h:
788         * QtTestBrowser/mainwindow.cpp:
789         (MainWindow::addressUrl):
790         * QtTestBrowser/mainwindow.h:
791
792 2011-01-27  Dirk Pranke  <dpranke@chromium.org>
793
794         Reviewed by Mihai Parparita.
795
796         new-run-webkit-tests: turn off pixel tests correctly by default
797         for webkit-based ports. r70013 (bug 47510) used
798         port.set_option_default() to attempt to set default values, but
799         that didn't work correctly. I have removed set_option_default
800         for now since it was only being used in two places and in three
801         useless unit tests. There is a separate bug open to fix the
802         option parsing (48095), so this workaround is fine for now.
803
804         https://bugs.webkit.org/show_bug.cgi?id=53217
805
806         * Scripts/webkitpy/layout_tests/port/webkit.py:
807         * Scripts/webkitpy/layout_tests/port/base.py:
808         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
809
810 2011-01-27  Balazs Kelemen  <kbalazs@webkit.org>
811
812         Rubber-stamped by Ariya Hidayat.
813
814         Trivial crash fix in WTR.
815
816         * WebKitTestRunner/TestController.cpp:
817         (WTR::TestController::initialize): Increase the size
818         of the vector by one to be able to store the null character.
819
820 2011-01-27  Balazs Kelemen  <kbalazs@webkit.org>
821
822         Reviewed by Csaba Osztrogonác.
823
824         [Qt][WK2] WTR should be initialized in the same way as DRT
825         https://bugs.webkit.org/show_bug.cgi?id=53240
826
827         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
828         (WTR::activateFonts): Added missing initialization steps.
829
830 2011-01-27  Joone Hur <joone.hur@collabora.co.uk>
831
832         Unreviewed. 
833
834         Adding myself to committers.py.
835
836         * Scripts/webkitpy/common/config/committers.py:
837
838 2011-01-27  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
839
840         Reviewed by Csaba Osztrogonác.
841
842         [Qt] [Symbian] Move project files into Source
843         https://bugs.webkit.org/show_bug.cgi?id=52891
844
845         Fix the Symbian build after the project files
846         are moved to Source directory. On Symbian qmake
847         needs to run in the same directory where the main
848         pro files (WebKit.pro, Tools.pro) are located.
849
850         * Scripts/webkitdirs.pm: Change to the directory where the pro file
851         is located before running qmake for Symbian. Qmake on Symbian
852         does not properly honor the "-o" option, work it around by setting
853         the name of the Makefile to bld.inf.
854
855 2011-01-27  Zoltan Horvath  <zoltan@webkit.org>
856
857         Reviewed by Andreas Kling.
858
859         [Qt] Add simple zooming features to MiniBrowser
860         https://bugs.webkit.org/show_bug.cgi?id=53231
861
862         Add View menu and Zoom In, Zoom Out, Zoom Reset actions to MiniBrowser.
863
864         * MiniBrowser/qt/BrowserWindow.cpp:
865         (BrowserWindow::BrowserWindow):
866         (BrowserWindow::zoomIn):
867         (BrowserWindow::zoomOut):
868         (BrowserWindow::resetZoom):
869         (BrowserWindow::updateUserAgentList):
870         (BrowserWindow::applyZoom):
871         * MiniBrowser/qt/BrowserWindow.h:
872
873 2011-01-26  Maciej Stachowiak  <mjs@apple.com>
874
875         Reviewed by Dan Bernstein.
876
877         WebKitTestRunner needs to support layoutTestController.evaluateInWebInspector
878         https://bugs.webkit.org/show_bug.cgi?id=42319
879         
880         Add evaluateInWebInspector and other APIs needed for inspector tests to run.
881
882         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
883         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
884         (WTR::LayoutTestController::showWebInspector):
885         (WTR::LayoutTestController::closeWebInspector):
886         (WTR::LayoutTestController::evaluateInWebInspector):
887         (WTR::LayoutTestController::setTimelineProfilingEnabled):
888         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
889         * WebKitTestRunner/TestInvocation.cpp:
890         (WTR::shouldOpenWebInspector):
891         (WTR::TestInvocation::invoke):
892         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
893
894 2011-01-26  Martin Robinson  <mrobinson@igalia.com>
895
896         Reviewed by Xan Lopez.
897
898         [GTK] Pixel dumps do not include scrollbars in output images
899         https://bugs.webkit.org/show_bug.cgi?id=53216
900
901         Show scrollbars in pixel dumps. This will fix pixel dumps for tests
902         that have scrollbars.
903
904         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
905         (createBitmapContextFromWebView): Take the snapshot of the containing GtkScrolledWindow
906         instead of the web view itself.
907
908 2011-01-26  Dirk Pranke  <dpranke@chromium.org>
909
910         Reviewed by Mihai Parparita.
911
912         Fix regression introduced in r76322 ... new-run-webkit-tests
913         was attempting to save the image diff output as a UTF-8-encoded
914         file.
915
916         https://bugs.webkit.org/show_bug.cgi?id=53210
917
918         * Scripts/webkitpy/layout_tests/port/webkit.py:
919
920 2011-01-26  Sheriff Bot  <webkit.review.bot@gmail.com>
921
922         Unreviewed, rolling out r76709.
923         http://trac.webkit.org/changeset/76709
924         https://bugs.webkit.org/show_bug.cgi?id=53194
925
926         "broke python tests on non-snowleopard platforms" (Requested
927         by dpranke on #webkit).
928
929         * Scripts/webkitpy/layout_tests/port/factory.py:
930         * Scripts/webkitpy/layout_tests/port/mock_drt.py: Removed.
931         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Removed.
932
933 2011-01-26  Dirk Pranke  <dpranke@chromium.org>
934
935         Reviewed by Tony Chang.
936
937         new-run-webkit-tests: add a "mock DRT" port implementation
938         and a separate class that emulates what we expect the
939         DumpRenderTree behavior to be.
940
941         This will eventually replace port/dryrun.py and allow us to get
942         better test coverage of the new-run-webkit-tests code as well as
943         a reference for what new-run-webkit-tests expects from DRT.
944
945         This is the first attempt at this, and it is pretty bare-boned. It
946         really only has been tested on the 'mac' port (and a little on
947         the 'chromium-mac' port.
948
949         https://bugs.webkit.org/show_bug.cgi?id=53126
950
951         * Scripts/webkitpy/layout_tests/port/mock_drt.py: Added.
952         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Added.
953         * Scripts/webkitpy/layout_tests/port/factory.py:
954
955 2011-01-26  Xianzhu Wang  <wangxianzhu@google.com>
956
957         Reviewed by Tony Chang.
958
959         Add '--no-timeout' option to Chromium DRT to ease debugging.
960         https://bugs.webkit.org/show_bug.cgi?id=52873
961
962         * DumpRenderTree/chromium/DumpRenderTree.cpp:
963         (main):
964
965 2011-01-26  Csaba Osztrogonác  <ossy@webkit.org>
966
967         Reviewed by Andreas Kling.
968
969         [Qt] Fix qt_minimal build
970         https://bugs.webkit.org/show_bug.cgi?id=53172
971
972         * QtTestBrowser/locationedit.h:
973
974 2011-01-26  Mansi Mithal  <mansi.mithal@nokia.com>
975
976         Reviewed by Antonio Gomes.
977
978         QtTestBrowser should have a UI Setting to disable plugins
979         https://bugs.webkit.org/show_bug.cgi?id=52408
980         
981         Added a new action item named "Disable Plugins"
982         under the "Settings" menu. 
983
984         * QtTestBrowser/launcherwindow.cpp:
985         (LauncherWindow::createChrome):
986         (LauncherWindow::togglePlugins):
987         * QtTestBrowser/launcherwindow.h:
988
989 2011-01-25  Patrick Gansterer  <paroga@webkit.org>
990
991         Reviewed by Adam Barth.
992
993         Move main CMakeLists.txt into Source directory
994         https://bugs.webkit.org/show_bug.cgi?id=52888
995
996         * Scripts/webkitdirs.pm:
997
998 2011-01-25  Patrick Gansterer  <paroga@webkit.org>
999
1000         Reviewed by Eric Seidel.
1001
1002         Improve label text in submit-to-ews
1003         https://bugs.webkit.org/show_bug.cgi?id=53130
1004
1005         * QueueStatusServer/templates/submittoews.html:
1006
1007 2011-01-25  Mansi Mithal  <mansi.mithal@nokia.com>
1008
1009         Reviewed by Antonio Gomes.
1010
1011         QtTestBrowser should have a UI Settings to prevent loading images
1012         https://bugs.webkit.org/show_bug.cgi?id=52409
1013         
1014         Added a new action item named "DisableAutoLoadImages"
1015         under the "Settings" menu 
1016
1017         * QtTestBrowser/launcherwindow.cpp:
1018         (LauncherWindow::createChrome):
1019         (LauncherWindow::toggleAutoLoadImages):
1020         * QtTestBrowser/launcherwindow.h:
1021
1022 2011-01-25  Dirk Pranke  <dpranke@chromium.org>
1023
1024         Reviewed by Tony Chang.
1025
1026         Minor bug fixes and cleanup for filesystem wrappers, port/* test
1027         classes, test_expectations.py. This change adds "test-win" and
1028         "test-mac" variants to the test port so that we can better test
1029         rebaselining, and adds a MockUser() object for reuse in testing.
1030
1031         https://bugs.webkit.org/show_bug.cgi?id=53036
1032
1033         * Scripts/webkitpy/common/system/filesystem.py:
1034         * Scripts/webkitpy/common/system/filesystem_mock.py:
1035         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1036         * Scripts/webkitpy/layout_tests/port/factory.py:
1037         * Scripts/webkitpy/layout_tests/port/base.py:
1038         * Scripts/webkitpy/layout_tests/port/test.py:
1039         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1040         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
1041         * Scripts/webkitpy/tool/mocktool.py:
1042
1043 2011-01-25  Tony Chang  <tony@chromium.org>
1044
1045         Reviewed by Dimitri Glazkov.
1046
1047         [chromium] remove unused layoutTestController callback
1048         https://bugs.webkit.org/show_bug.cgi?id=53103
1049
1050         This method is used by a test_shell_test, but not needed by DRT.
1051
1052         * DumpRenderTree/chromium/LayoutTestController.cpp:
1053         (LayoutTestController::LayoutTestController):
1054         * DumpRenderTree/chromium/LayoutTestController.h:
1055
1056 2011-01-25  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1057
1058         Reviewed by Andreas Kling.
1059
1060         [GTK] Remove 64 bits release bot from the buildbot master
1061         https://bugs.webkit.org/show_bug.cgi?id=52899
1062
1063         Removes the 64 bits release slave from the buildbot configuration,
1064         so that we can use it as an EWS.
1065
1066         * BuildSlaveSupport/build.webkit.org-config/config.json:
1067
1068 2011-01-24  Maciej Stachowiak  <mjs@apple.com>
1069
1070         Reviewed by Dan Bernstein.
1071
1072         Implement database quota callback to fix storage tests on WebKit2 bot
1073         https://bugs.webkit.org/show_bug.cgi?id=53064
1074
1075         * WebKitTestRunner/TestController.cpp:
1076         (WTR::exceededDatabaseQuota):
1077         (WTR::TestController::createOtherPage):
1078         (WTR::TestController::initialize):
1079
1080 2011-01-24  Maciej Stachowiak  <mjs@apple.com>
1081
1082         Reviewed by Anders Carlsson.
1083
1084         Use designated temp directory for the database for WebKit2
1085         https://bugs.webkit.org/show_bug.cgi?id=53052
1086         
1087         Adopt the new WK2 API for this.
1088
1089         * WebKitTestRunner/TestController.cpp:
1090         (WTR::TestController::libraryPathForTesting):
1091         (WTR::TestController::initialize):
1092         * WebKitTestRunner/TestController.h:
1093         * WebKitTestRunner/mac/TestControllerMac.mm:
1094         (WTR::TestController::platformLibraryPathForTesting):
1095         * WebKitTestRunner/qt/TestControllerQt.cpp:
1096         (WTR::TestController::platformLibraryPathForTesting):
1097         * WebKitTestRunner/win/TestControllerWin.cpp:
1098         (WTR::TestController::platformLibraryPathForTesting):
1099
1100 2011-01-24  Lucas Forschler  <lforschler@apple.com>
1101
1102         Reviewed by Stephanie Lewis.
1103
1104         Add a new Leopard test bot.
1105
1106         * BuildSlaveSupport/build.webkit.org-config/config.json:
1107
1108 2011-01-24  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1109
1110         Reviewed by Adam Barth.
1111
1112         Add EFL Builder to core waterfall
1113         https://bugs.webkit.org/show_bug.cgi?id=52704
1114
1115         Add EFL Builder to the core waterfall again.
1116
1117         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1118         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1119
1120 2011-01-24  Xianzhu Wang  <wangxianzhu@google.com>
1121
1122         Reviewed by Tony Chang.
1123
1124         new-run-webkit-tests fails to start HTTP server if there are proxy settings
1125         https://bugs.webkit.org/show_bug.cgi?id=52872
1126
1127         Force disabling proxy to resolve the problem.
1128
1129         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
1130         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
1131
1132 2011-01-24  Andreas Kling  <kling@webkit.org>
1133
1134         Reviewed by Darin Adler.
1135
1136         check-webkit-style: Update exemptions following Source/ move.
1137         https://bugs.webkit.org/show_bug.cgi?id=53017
1138
1139         * Scripts/webkitpy/style/checker.py:
1140         * Scripts/webkitpy/style/checker_unittest.py:
1141
1142 2011-01-24  Andras Becsi  <abecsi@webkit.org>
1143
1144         Rubber-stamped by Csaba Osztrogonác.
1145
1146         [Qt] Move project files into Source
1147         https://bugs.webkit.org/show_bug.cgi?id=52891
1148
1149         * DumpRenderTree/qt/ImageDiff.pro: Add missing "Source" to WebKit.pri path
1150
1151 2011-01-24  Mikhail Naganov  <mnaganov@chromium.org>
1152
1153         Reviewed by Yury Semikhatsky.
1154
1155         Web Inspector: Find duplicate strings in localizedStrings.js
1156
1157         https://bugs.webkit.org/show_bug.cgi?id=53005
1158
1159         * Scripts/check-inspector-strings:
1160
1161 2011-01-24  Zoltan Horvath  <zoltan@webkit.org>
1162
1163         Reviewed by Andreas Kling.
1164
1165         [Qt] Regroup MiniBrowser's menubar and add open file action
1166         https://bugs.webkit.org/show_bug.cgi?id=53000
1167
1168         Add File and Develop menu to MiniBrowser's menubar and add open file action to File menu.
1169
1170         * MiniBrowser/qt/BrowserWindow.cpp:
1171         (BrowserWindow::BrowserWindow):
1172         (BrowserWindow::openFile):
1173         (BrowserWindow::~BrowserWindow):
1174         * MiniBrowser/qt/BrowserWindow.h:
1175
1176 2011-01-24  Csaba Osztrogonác  <ossy@webkit.org>
1177
1178         Unreviewed fix after r76496
1179
1180         [Qt] Move project files into Source
1181         https://bugs.webkit.org/show_bug.cgi?id=52891
1182
1183         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Remove unnecessary "Source" from the path.
1184         * BuildSlaveSupport/built-product-archive: Remove unnecessary "Source" from the path.
1185         * Scripts/webkitdirs.pm: Add the accidentally removed slash to the path.
1186
1187 2011-01-24  Andras Becsi  <abecsi@webkit.org>
1188
1189         Reviewed by Csaba Osztrogonác.
1190
1191         [Qt] Move project files into Source
1192         https://bugs.webkit.org/show_bug.cgi?id=52891
1193
1194         * DerivedSources.pro: Renamed from DerivedSources.pro.
1195         * DumpRenderTree/qt/DumpRenderTree.pro:
1196         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1197         * MiniBrowser/DerivedSources.pro:
1198         * MiniBrowser/qt/MiniBrowser.pro:
1199         * QtTestBrowser/QtTestBrowser.pro:
1200         * Scripts/webkitdirs.pm:
1201         * Tools.pro: Added.
1202         * WebKitTestRunner/DerivedSources.pro:
1203         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1204         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1205
1206 2011-01-22  Geoffrey Garen  <ggaren@apple.com>
1207
1208         Reviewed by Dan Bernstein.
1209
1210         Beefed up --threaded mode to catch even more kinds of errors.
1211         https://bugs.webkit.org/show_bug.cgi?id=52971
1212
1213         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Use a shared
1214         context group to force JSC to mark multiple threads. (This used to be
1215         the default, but it changed in SnowLeopard.)
1216         (runJavaScriptThread): Do more locking and unlocking, and more allocation,
1217         to give threading mistakes more chances to show themselves.
1218         (startJavaScriptThreads):
1219         (stopJavaScriptThreads):
1220
1221 2011-01-22  Robert Hogan  <robert@webkit.org>
1222
1223         Reviewed by Andreas Kling.
1224
1225         [Qt] Support layoutTestController.addURLToRedirect()
1226         https://bugs.webkit.org/show_bug.cgi?id=52956
1227
1228         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1229         (LayoutTestController::addURLToRedirect):
1230         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1231
1232 2011-01-22  Robert Hogan  <robert@webkit.org>
1233
1234         Reviewed by Kenneth Rohde Christiansen.
1235
1236         [Qt] REGRESSION (r72360): http/tests/security/aboutBlank/xss-DENIED-* tests fail
1237         https://bugs.webkit.org/show_bug.cgi?id=49802
1238
1239         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1240         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1241         (WebCore::DumpRenderTree::open):
1242
1243 2011-01-21  Adam Barth  <abarth@webkit.org>
1244
1245         Reviewed by Maciej Stachowiak.
1246
1247         Disable mac_unittest.py that fails on some of the Mac bots
1248         https://bugs.webkit.org/show_bug.cgi?id=52947
1249
1250         As noted in the comment, this test does not appear to be correct
1251         because the function this test is testing returns different results
1252         depending on which flavor of Mac the test is run on.  This patch
1253         disable the test.  Hopefully we can re-enable the test once we've
1254         probably insulated the test from its environment.
1255
1256         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1257
1258 2011-01-21  Dirk Pranke  <dpranke@chromium.org>
1259
1260         Reviewed by Mihai Parparita.
1261
1262         Fix bug introduced in r76322 that caused NRWT to not actually
1263         read the Skipped files properly.
1264
1265         https://bugs.webkit.org/show_bug.cgi?id=52771
1266
1267         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1268         * Scripts/webkitpy/layout_tests/port/webkit.py:
1269         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1270
1271 2011-01-21  Sam Weinig  <sam@webkit.org>
1272
1273         Reviewed by Geoffrey Sean Garen and Mark Rowe.
1274
1275         WebKitTestRunner needs the HOME environment variable to be set.
1276         <rdar://problem/8896573>
1277
1278         * Scripts/old-run-webkit-tests: Set the HOME environment variable if
1279         it exists.
1280
1281 2011-01-21  Dirk Pranke  <dpranke@chromium.org>
1282
1283         Reviewed by Eric Seidel.
1284
1285         Suppress a few remaining integration tests so that none of the
1286         layout_test unit tests ever read from the filesystem or launch
1287         subprocesses that aren't part of the unit tests.
1288
1289         Also fix a minor bug in the printing unit tests that was
1290         incorrectly relying on sys.argv.
1291
1292         https://bugs.webkit.org/show_bug.cgi?id=52863
1293
1294         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1295         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1296         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1297
1298 2011-01-21  Darin Adler  <darin@apple.com>
1299
1300        Fix Mac build.
1301
1302         * MiniBrowser/mac/BrowserWindowController.m:
1303         (-[BrowserWindowController awakeFromNib]): Pass 0 for runModal function.
1304
1305 2011-01-20  Darin Adler  <darin@apple.com>
1306
1307         Reviewed by Dan Bernstein.
1308
1309         WebKit2: Implement showModalDialog
1310         https://bugs.webkit.org/show_bug.cgi?id=52855
1311
1312         This fixes WebKitTestRunner to compile, but more work is probably
1313         needed to get it to pass the tests.
1314
1315         * WebKitTestRunner/TestController.cpp:
1316         (WTR::TestController::runModal): Added. Calls through to the
1317         platform-specific version of runModal.
1318         (WTR::TestController::createOtherPage): Changed to be a private
1319         static member function so it can refer to runModal, which is
1320         a private static member function.
1321         (WTR::TestController::initialize): Pass 0 for the runModal
1322         function since we don't need to run the main window modal.
1323         I suspect this is wrong and will need to change.
1324         * WebKitTestRunner/TestController.h: Added declarations for
1325         the functions added above.
1326         * WebKitTestRunner/mac/TestControllerMac.mm:
1327         (WTR::TestController::runModal): Added. Untested implementation.
1328         * WebKitTestRunner/qt/TestControllerQt.cpp:
1329         (WTR::TestController::runModal): Added.
1330         * WebKitTestRunner/win/TestControllerWin.cpp:
1331         (WTR::TestController::runModal): Added.
1332
1333 2011-01-21  Eric Seidel  <eric@webkit.org>
1334
1335         Reviewed by Adam Barth.
1336
1337         Split Host object off from WebKitPatch for easier re-use
1338         https://bugs.webkit.org/show_bug.cgi?id=52284
1339
1340         new-run-webkit-tests and other tools are eventually going to want one of these.
1341         Basically you need to inherit from this class if you want to pretend to be a
1342         self.tool object for Steps/Commands.
1343
1344         * Scripts/webkitpy/common/host.py: Added.
1345         * Scripts/webkitpy/tool/main.py:
1346
1347 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1348
1349         Reviewed by Adam Barth.
1350
1351         Disable the tests that start and stop the http server and web
1352         server, so that we don't have to worry about port collisions on
1353         the bots.
1354
1355         https://bugs.webkit.org/show_bug.cgi?id=52861
1356
1357         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1358
1359 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1360
1361         Reviewed by Eric Seidel.
1362
1363         nrwt: rewrite google_chrome_unittest to use mock filesystem.
1364         
1365         https://bugs.webkit.org/show_bug.cgi?id=52772
1366         
1367         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
1368
1369 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1370
1371         Reviewed by Eric Siedel.
1372
1373         nrwt: clean up almost all remaining port references, remove
1374         unnecessary import clauses. The only remaining references are
1375         in places where a mock filesystem makes no sense or can't be
1376         used, and in one routine in port/google_chrome_unittest that
1377         I'll rewrite in a separate patch.
1378
1379         https://bugs.webkit.org/show_bug.cgi?id=52771
1380
1381         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1382         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1383         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1384         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1385         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1386         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1387         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1388         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
1389         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
1390         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
1391         * Scripts/webkitpy/layout_tests/port/gtk.py:
1392         * Scripts/webkitpy/layout_tests/port/mac.py:
1393         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1394         * Scripts/webkitpy/layout_tests/port/qt.py:
1395         * Scripts/webkitpy/layout_tests/port/webkit.py:
1396         * Scripts/webkitpy/layout_tests/port/win.py:
1397         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
1398
1399 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1400
1401         Reviewed by Mihai Parparita.
1402
1403         remove fs refs from run_webkit_tests, rebaseline_chromium_webkit_tests
1404
1405         https://bugs.webkit.org/show_bug.cgi?id=52762
1406
1407         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1408         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1409
1410 2011-01-20  Tony Chang  <tony@chromium.org>
1411
1412         Reviewed by Ojan Vafai.
1413
1414         [chromium] fix the paths used for the rebaseline tool
1415         https://bugs.webkit.org/show_bug.cgi?id=52857
1416
1417         Some of the bots were renamed so the path to grab the results zip
1418         file has changed.
1419
1420         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1421
1422 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1423
1424         Reviewed by Tony Chang.
1425
1426         Fix bug introduced in r72688 / bug 52768 that broke the
1427         generation of the output filename links in the results.html
1428         output. Apparently none of the unit tests actually checked to
1429         make sure the generated links were correct :(
1430
1431         https://bugs.webkit.org/show_bug.cgi?id=52854
1432
1433         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1434         * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
1435
1436 2011-01-20  Alexey Proskuryakov  <ap@apple.com>
1437
1438         Reviewed by Darin Adler.
1439
1440         https://bugs.webkit.org/show_bug.cgi?id=52849
1441         Make window.print work with WebKit2
1442
1443         * MiniBrowser/mac/BrowserWindowController.m:
1444         (-[BrowserWindowController awakeFromNib]):
1445         * WebKitTestRunner/TestController.cpp:
1446         (WTR::createOtherPage):
1447         (WTR::TestController::initialize):
1448         Added zeroes to WKPageUIClient structures to avoid build failures.
1449
1450 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1451
1452         Reviewed by Eric Seidel.
1453
1454         nrwt: remove fs refs from printing, test_failures, test_expectations, text_diff
1455
1456         https://bugs.webkit.org/show_bug.cgi?id=52756
1457
1458         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1459         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1460         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1461         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
1462         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1463         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
1464
1465 2011-01-20  Mansi Mithal  <mansi.mithal@nokia.com>
1466
1467         Reviewed by Antonio Gomes.
1468
1469         QtTestBrowser should have a seperate menu for Settings
1470         https://bugs.webkit.org/show_bug.cgi?id=52817
1471         
1472         Added a new menu item named "Settings"
1473         and moved the "Enable interrupting js scripts" and "Enable js pop up windows" under the "Settings" menu 
1474
1475         * QtTestBrowser/launcherwindow.cpp:
1476         (LauncherWindow::createChrome):
1477
1478 2011-01-20  Sam Weinig  <sam@webkit.org>
1479
1480         Reviewed by John Sullivan.
1481
1482         Update update-webkit-localizable-strings with new path to WebKit.
1483
1484         * Scripts/update-webkit-localizable-strings:
1485
1486 2011-01-20  James Robinson  <jamesr@chromium.org>
1487
1488         Reviewed by Darin Fisher.
1489
1490         Implement mozilla's requestAnimationFrame API
1491         https://bugs.webkit.org/show_bug.cgi?id=51218
1492
1493         Chromium DumpRenderTree support for window.webkitRequestAnimationFrame.
1494
1495         * DumpRenderTree/chromium/WebViewHost.cpp:
1496         (invokeScheduleComposite):
1497         (WebViewHost::scheduleAnimation):
1498         (WebViewHost::paintInvalidatedRegion):
1499         * DumpRenderTree/chromium/WebViewHost.h:
1500
1501 2011-01-20  Maciej Stachowiak  <mjs@apple.com>
1502
1503         Reviewed by Adam Roben.
1504
1505         WebKitTestRunner needs to support layoutTestController.evaluateScriptInIsolatedWorld
1506         https://bugs.webkit.org/show_bug.cgi?id=42327
1507
1508         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm: Add support
1509         for methods that take their normal arguments but also a JSContextRef.
1510         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: IDL definition
1511         for evaluateScriptInIsolatedWorld.
1512         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1513         (WTR::InjectedBundlePage::didClearWindowForFrame): Set a magic variable only if
1514         this call is for an isolated world.
1515         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1516         (WTR::worldMap): Helper to create a world map.
1517         (WTR::LayoutTestController::worldIDForWorld): Map from an ID to a world.
1518         (WTR::LayoutTestController::evaluateScriptInIsolatedWorld): The newly
1519         added LayoutTestController API.
1520         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1521
1522 2011-01-19  Adam Roben  <aroben@apple.com>
1523
1524         Convert paths in environment variables back to msys-style inside commit-log-editor
1525
1526         When this script gets run from inside git commit, msys-style paths in the environment will
1527         have been turned into Windows-style paths with forward slashes. This screws up functions
1528         like File::Spec->rel2abs, which seem to rely on $PWD having an msys-style path. We convert
1529         the paths back to msys-style before doing anything else.
1530
1531         Fixes <http://webkit.org/b/48527> commit-log-editor uses full paths for section headers when
1532         using msysgit's Perl and multiple ChangeLogs have been edited
1533
1534         Reviewed by David Kilzer.
1535
1536         * Scripts/commit-log-editor: Call fixEnvironment before doing anything else.
1537         (fixEnvironment): Added. When run in msys in conjunction with git (i.e., when invoked from
1538         inside git commit), convert Windows-style paths in the environment back to msys-style paths.
1539
1540 2011-01-20  Zoltan Horvath  <zoltan@webkit.org>
1541
1542         [Win] Unreviewed build fix after r76248.
1543
1544         * DumpRenderTree/ForwardingHeaders/wtf/FastAllocBase.h: Added.
1545
1546 2011-01-20  Zoltan Horvath  <zoltan@webkit.org>
1547
1548         Reviewed by Csaba Osztrogonác.
1549
1550         Refactoring of the custom allocation framework
1551         https://bugs.webkit.org/show_bug.cgi?id=49897
1552
1553         Inheriting from FastAllocBase can result in objects getting larger (bug #33896, #46589).
1554         The modification replaces Noncopyable and FastAllocBase classes and these inherits with their
1555         equivalent macro implementation at the necessary places.
1556 2011-01-20  Yi Shen  <yi.4.shen@nokia.com>
1557
1558         Unreviewed. 
1559
1560         Adding myself to committers.py.
1561
1562         * Scripts/webkitpy/common/config/committers.py:
1563
1564 2011-01-20  Adam Barth  <abarth@webkit.org>
1565
1566         Reviewed by Tony Chang.
1567
1568         Chromium builders don't delete unversioned directories when DEPS change
1569         https://bugs.webkit.org/show_bug.cgi?id=52745
1570
1571         If we pass this option to gclient sync, gclient will delete directories
1572         that are no longer part of DEPS instead of leaving them around to
1573         confuse us later.  Apparently, the downstream buildbots use this option
1574         already.
1575
1576         * Scripts/update-webkit-chromium:
1577
1578 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1579
1580         Unreviewed, build fix - I pulled this patch in to fix an issue
1581         revealed by r76195 running on some new bots). Also fix a couple
1582         of other issues revealed in testing.
1583
1584         nrwt: remove fs refs from layout_package/json*
1585
1586         https://bugs.webkit.org/show_bug.cgi?id=52754
1587
1588         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1589         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1590         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
1591         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1592         * Scripts/webkitpy/layout_tests/port/base.py:
1593
1594 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1595
1596         Unreviewed, build fix.
1597
1598         Fix a couple of minor bugs discovered while bringing up new bots
1599         for testing.
1600
1601         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1602         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1603
1604 2011-01-19  James Robinson  <jamesr@chromium.org>
1605
1606         Unreviewed, rolling out r76194.
1607         http://trac.webkit.org/changeset/76194
1608         https://bugs.webkit.org/show_bug.cgi?id=51218
1609
1610         Caused mysterious compile failure on the chromium win
1611         build.webkit.org bots
1612
1613         * DumpRenderTree/chromium/WebViewHost.cpp:
1614         (WebViewHost::paintInvalidatedRegion):
1615         * DumpRenderTree/chromium/WebViewHost.h:
1616
1617 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1618
1619         Reviewed by Mihai Parparita.
1620
1621         remove fs refs from test_runner, dump_render_tree_thread
1622
1623         https://bugs.webkit.org/show_bug.cgi?id=52753
1624
1625         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1626         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1627         * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
1628         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1629
1630 2011-01-19  James Robinson  <jamesr@chromium.org>
1631
1632         Reviewed by Darin Fisher.
1633
1634         Implement mozilla's requestAnimationFrame API
1635         https://bugs.webkit.org/show_bug.cgi?id=51218
1636
1637         Chromium DumpRenderTree support for window.webkitRequestAnimationFrame.
1638
1639         * DumpRenderTree/chromium/WebViewHost.cpp:
1640         (invokeScheduleComposite):
1641         (WebViewHost::scheduleAnimation):
1642         (WebViewHost::paintInvalidatedRegion):
1643         * DumpRenderTree/chromium/WebViewHost.h:
1644
1645 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1646
1647         Unreviewed, build fix.
1648
1649         Fix a few incorrect "self._filesystem" references introduced in
1650         r76184.
1651
1652         * Scripts/webkitpy/layout_tests/port/chromium.py:
1653         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1654
1655 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1656
1657         Reviewed by Mihai Parparita.
1658
1659         add a .sep property, abspath(), isabs(), mtime(), and
1660         open_text_file_for_writing() to filesystem modules. Some of
1661         these properties are not needed in this patch but will be needed
1662         in subsequent patches (I'm doing this to avoid having to track
1663         multiple versions of a single file).
1664
1665         Also, change most of the port/* modules to use the filesystem
1666         objects instead of referencing the filesystem directly.
1667
1668         https://bugs.webkit.org/show_bug.cgi?id=52748
1669
1670         * Scripts/webkitpy/common/system/filesystem.py:
1671         * Scripts/webkitpy/common/system/filesystem_mock.py:
1672         * Scripts/webkitpy/layout_tests/port/__init__.py:
1673         * Scripts/webkitpy/layout_tests/port/base.py:
1674         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1675         * Scripts/webkitpy/layout_tests/port/chromium.py:
1676         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1677         * Scripts/webkitpy/layout_tests/port/config.py:
1678         * Scripts/webkitpy/layout_tests/port/test.py:
1679         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
1680
1681 2011-01-19  Maciej Stachowiak  <mjs@apple.com>
1682
1683         Reviewed by Anders Carlsson.
1684
1685         If resetting between tests times out, treat it as a WebProcess crash
1686         https://bugs.webkit.org/show_bug.cgi?id=52757
1687
1688         * WebKitTestRunner/TestController.cpp:
1689         (WTR::TestController::runTest):
1690
1691 2011-01-19  Alexey Proskuryakov  <ap@apple.com>
1692
1693         Reviewed by Darin Adler.
1694
1695         https://bugs.webkit.org/show_bug.cgi?id=52739
1696         Make it possible for a WebKit2 client to print headers and footers
1697
1698         Added dummy implementations for new printing UIClient calls.
1699
1700         * MiniBrowser/mac/BrowserWindowController.m:
1701         (-[BrowserWindowController awakeFromNib]):
1702         * WebKitTestRunner/TestController.cpp:
1703         (WTR::createOtherPage):
1704         (WTR::TestController::initialize):
1705
1706 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1707
1708         Reviewed by Ojan Vafai.
1709
1710         Change webkitpy/layout_tests/port/test.py to use the
1711         in-memory filesystem for cleaner unit testing. This
1712         change allows us to kill a lot of code that was
1713         specific to the test port, at the cost of being a
1714         little less clear about how things would work if
1715         you didn't have a filesystem.
1716
1717         https://bugs.webkit.org/show_bug.cgi?id=52605
1718
1719         * Scripts/webkitpy/layout_tests/port/test.py:
1720
1721 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1722
1723         Unreviewed, build fix.
1724
1725         Fix test failure caused by committing attachment 79368 instead
1726         of attachment 79461 on bug 52604.
1727
1728         * Scripts/webkitpy/common/system/filesystem_mock.py:
1729
1730 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1731
1732         Reviewed by Mihai Parparita.
1733
1734         new-run-webkit-tests: remove use of os.walk, use mock filesystem for better
1735         unit testing. os.walk() is too much of a hassle to implement on
1736         top of the in-memory mock filesystem and adding the necessary
1737         interface to files_under() gives clients a cleaner API anyway
1738         (for this particular usage model).
1739
1740         https://bugs.webkit.org/show_bug.cgi?id=52691
1741
1742         * Scripts/webkitpy/common/system/filesystem.py:
1743         * Scripts/webkitpy/common/system/filesystem_mock.py:
1744         * Scripts/webkitpy/layout_tests/port/test_files.py:
1745         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
1746
1747 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1748
1749         Reviewed by Tony Chang.
1750
1751         Change more modules in the layout-tests code to use the
1752         filesystem wrapper for cleaner unit testing.
1753
1754         This patch also adds the glob() wrapper to the filesystem
1755         abstraction.
1756         
1757         https://bugs.webkit.org/show_bug.cgi?id=52604
1758
1759         * Scripts/webkitpy/layout_tests/port/test_files.py:
1760         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
1761         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
1762         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1763         * Scripts/webkitpy/common/system/filesystem.py:
1764         * Scripts/webkitpy/common/system/filesystem_mock.py:
1765
1766 2011-01-19  Levi Weintraub  <leviw@chromium.org>
1767
1768         Unreviewed.
1769
1770         Updating my email addresses and irc nick.
1771
1772         * Scripts/webkitpy/common/config/committers.py:
1773
1774 2011-01-19  Tony Chang  <tony@chromium.org>
1775
1776         Reviewed by Mihai Parparita.
1777
1778         [chromium] [linux] if check-sys-deps fails, output the failure reason
1779         https://bugs.webkit.org/show_bug.cgi?id=52671
1780
1781         * Scripts/webkitpy/common/system/executive_mock.py: Add support for
1782             error handler functions.
1783         * Scripts/webkitpy/layout_tests/port/chromium.py:
1784             output the error text from --check-sys-deps
1785         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1786
1787 2011-01-19  Aparna Nandyal  <aparna.nand@wipro.com>
1788
1789         Reviewed by Andreas Kling.
1790
1791         [Qt] QtTestBrowser crashes when closing if Facebook is opened
1792         https://bugs.webkit.org/show_bug.cgi?id=52554
1793         
1794         QtNetworkAccessManager is created in a thread and set as
1795         member variable in QWebPage. When the thread is destroyed
1796         the object is still used. So fix will set the object to
1797         NULL once the thread is destroyed.
1798
1799         * QtTestBrowser/launcherwindow.cpp:
1800         (LauncherWindow::~LauncherWindow):
1801
1802 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
1803
1804         Rubber stamped by Csaba Osztrogonac
1805
1806         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: Removed unncessary inculde of WKStringCF.h
1807
1808 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
1809
1810         Reviewed by Tony Chang.
1811
1812         new-run-webkit-tests: add a --build-directory command line argument
1813
1814         Official Google Chrome builds use a non-standard build directory
1815         location. This patch adds a --build-directory argument that
1816         allows that location to be specified on the command line. Only
1817         Chromium-based builds will use this flag for now, but anyone can
1818         in the future.
1819
1820         There are no unit tests for this since it's difficult to test
1821         until mock filesystems are fully supported in the code. This was
1822         tested by hand for now.
1823
1824         https://bugs.webkit.org/show_bug.cgi?id=52694
1825
1826         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1827         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1828         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1829         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1830
1831 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
1832
1833         Not reviewed. Bot fix.
1834
1835         Remove an inadvertently committed debugging print.
1836
1837         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1838         (LayoutTestController::notifyDone):
1839
1840 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
1841
1842         Reviewed by Sam Weinig.
1843
1844         WebKitTestRunner should track loading more like DumpRenderTree
1845         https://bugs.webkit.org/show_bug.cgi?id=52692
1846
1847         Change load tracking to track the current top loading frame, in the manner of DumpRenderTree.
1848         This makes some tests that call notifyDone multiple times pass.
1849         
1850         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1851         (WTR::InjectedBundle::InjectedBundle):
1852         (WTR::InjectedBundle::done):
1853         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1854         (WTR::InjectedBundle::topLoadingFrame):
1855         (WTR::InjectedBundle::setTopLoadingFrame):
1856         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1857         (WTR::InjectedBundlePage::InjectedBundlePage):
1858         (WTR::InjectedBundlePage::stopLoading):
1859         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
1860         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
1861         (WTR::InjectedBundlePage::didFinishLoadForFrame):
1862         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
1863         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1864         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1865         (WTR::LayoutTestController::notifyDone):
1866         * WebKitTestRunner/TestController.cpp:
1867         (WTR::TestController::didReceiveMessageFromInjectedBundle):
1868
1869 2011-01-18  Mihai Parparita  <mihaip@chromium.org>
1870
1871         Reviewed by Kent Tamura.
1872
1873         [Chromium] NRWT looking for DRT binary in the wrong path on Mac
1874         https://bugs.webkit.org/show_bug.cgi?id=52678
1875         
1876         Update path now that WebKit is inside Source.
1877
1878         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1879
1880 2011-01-18  Robert Hogan  <robert@webkit.org>
1881
1882         Reviewed by Simon Hausmann.
1883
1884         [Qt] http/tests/incremental/slow-utf8-text.pl fails
1885         https://bugs.webkit.org/show_bug.cgi?id=44282
1886
1887         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1888         (WebCore::DumpRenderTree::dump):
1889
1890 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
1891
1892         Reviewed by Mihai Parparita.
1893
1894         Fix a small race condition that could cause the unit tests for
1895         new-run-webkit-tests to fail in a multithreaded environment.
1896         There was a small window in the code where one thread would
1897         check to see if a thread had raised an exception, do something,
1898         and then check to see if the thread was alive. If the other
1899         thread raised an exception and exited in between these two
1900         steps, the exception would be lost. Flipping the order of the
1901         two checks fixes the race, since we will now always check for an
1902         exception on the thread before exiting.
1903
1904         https://bugs.webkit.org/show_bug.cgi?id=51579
1905
1906         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
1907
1908 2011-01-18  Eric Seidel  <eric@webkit.org>
1909
1910         Reviewed by Adam Barth.
1911
1912         commit-queue dies when test archiving fails
1913         https://bugs.webkit.org/show_bug.cgi?id=52617
1914
1915         I looked at the machine and it had 10 archives already
1916         thus find_unused_name was returning None.  I've upped
1917         the limit to 100 (per bug) and tested the case where
1918         find_unused_name returns None (making archive return None).
1919
1920         * Scripts/webkitpy/common/system/workspace.py:
1921         * Scripts/webkitpy/common/system/workspace_unittest.py:
1922         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1923         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1924         * Scripts/webkitpy/tool/commands/queues.py:
1925
1926 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
1927
1928         Reviewed by Ojan Vafai.
1929
1930         Update rebaseline-chromium-webkit-tests unit tests to use a mock
1931         filesystem. Also fix a couple of "with" statements missed by
1932         r76050.
1933
1934         https://bugs.webkit.org/show_bug.cgi?id=52487
1935
1936         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
1937
1938 2011-01-18  Sergio Villar Senin  <svillar@igalia.com>
1939
1940         Reviewed by Martin Robinson.
1941
1942         [Gtk] Build fixes for gtk3 build
1943         https://bugs.webkit.org/show_bug.cgi?id=52648
1944
1945         * DumpRenderTree/gtk/EventSender.cpp:
1946         (beginDragWithFilesCallback):
1947
1948 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
1949
1950         Reviewed by Mihai Parparita.
1951
1952         Update rebaseline-chromium-webkit-tests to use filesystem objects
1953         instead of direct references to os.path, shutil, tempfile, etc.
1954
1955         This patch doesn't change anything, but will allow subsequent
1956         patches to change the unit tests to no longer use the real
1957         filesystem.
1958
1959         This patch adds a bunch more methods to the filesystem object as
1960         well.
1961
1962         https://bugs.webkit.org/show_bug.cgi?id=52482
1963
1964         * Scripts/webkitpy/common/system/filesystem.py:
1965         * Scripts/webkitpy/common/system/filesystem_mock.py:
1966         * Scripts/webkitpy/tool/commands/queues.py:
1967         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1968         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
1969
1970 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
1971
1972         Reviewed by Mihai Parparita.
1973
1974         new-run-webkit-tests shouldn't crash when you try to run a
1975         directory containing only skipped files.
1976
1977         https://bugs.webkit.org/show_bug.cgi?id=52478
1978         
1979         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1980         * Scripts/webkitpy/layout_tests/port/test.py:
1981         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1982
1983 2011-01-18  Adam Bergkvist  <adam.bergkvist@ericsson.com> and Martin Robinson  <mrobinson@igalia.com>
1984
1985         Reviewed by Gustavo Noronha Silva.
1986
1987         [GTK] The GTK+ EventSender needs support for beginDragWithFiles
1988         https://bugs.webkit.org/show_bug.cgi?id=40833
1989
1990         * DumpRenderTree/gtk/EventSender.cpp: Add a beginDragWithFiles implementation for the
1991         GTK+ event sender.
1992         (dragWithFilesDragDataGetCallback): Added.
1993         (dragWithFilesDragEndCallback): Added.
1994         (beginDragWithFilesCallback): Added.
1995
1996 2011-01-18  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1997
1998         Reviewed by Adam Barth.
1999
2000         ews: Add additional watcher to efl ews
2001         https://bugs.webkit.org/show_bug.cgi?id=52613
2002
2003         Add gyuyoung.kim@samsung.com to watcher list of efl-ews.
2004
2005         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2006
2007 2011-01-17  Tony Gentilcore  <tonyg@chromium.org>
2008
2009         Reviewed by Alexey Proskuryakov.
2010
2011         Fix some headers with missing or misspelled #ifndef guards
2012         https://bugs.webkit.org/show_bug.cgi?id=52545
2013
2014         * DumpRenderTree/chromium/TestEventPrinter.h:
2015         * DumpRenderTree/chromium/WebPreferences.h:
2016
2017 2011-01-17  Jessie Berlin  <jberlin@apple.com>
2018
2019         Reviewed by Anders Carlsson.
2020
2021         REGRESSION: Assertion failure in FrameLoader::continueLoadAfterWillSubmitForm() when
2022         navigating back to an unreachable URL
2023         https://bugs.webkit.org/show_bug.cgi?id=52388
2024
2025         Add a third parameter (unreachableURL) to queueLoadHTMLString.
2026
2027         * DumpRenderTree/LayoutTestController.cpp:
2028         (queueLoadHTMLStringCallback):
2029         (LayoutTestController::queueLoadHTMLString):
2030         (LayoutTestController::queueLoadAlternateHTMLString):
2031         * DumpRenderTree/LayoutTestController.h:
2032
2033         * DumpRenderTree/WorkQueueItem.h:
2034         (LoadHTMLStringItem::LoadHTMLStringItem):
2035
2036         * DumpRenderTree/chromium/LayoutTestController.cpp:
2037         (WorkItemLoadHTMLString::WorkItemLoadHTMLString):
2038         (WorkItemLoadHTMLString::run):
2039         (LayoutTestController::queueLoadHTMLString):
2040
2041         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
2042         (LoadHTMLStringItem::invoke):
2043         * DumpRenderTree/mac/WorkQueueItemMac.mm:
2044         (LoadHTMLStringItem::invoke):
2045         * DumpRenderTree/win/WorkQueueItemWin.cpp:
2046         (LoadHTMLStringItem::invoke):
2047
2048 2011-01-17  Dan Bernstein  <mitz@apple.com>
2049
2050         Rubber-stamped by Mark Rowe.
2051
2052         Update xcodeproj svn:ignore to include xcuserdata.
2053
2054         * DumpRenderTree/DumpRenderTree.xcodeproj: Modified property svn:ignore.
2055         * MiniBrowser/MiniBrowser.xcodeproj: Modified property svn:ignore.
2056         * TestWebKitAPI/TestWebKitAPI.xcodeproj: Modified property svn:ignore.
2057         * WebKitLauncher/WebKitLauncher.xcodeproj: Modified property svn:ignore.
2058         * WebKitTestRunner/WebKitTestRunner.xcodeproj: Modified property svn:ignore.
2059
2060 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
2061
2062         Unreviewed fix after r75908.
2063
2064         Move WebKit into Source
2065         https://bugs.webkit.org/show_bug.cgi?id=52530
2066
2067         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add Source to the path for Qt API tests.
2068
2069 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
2070
2071         Unreviewed.
2072
2073         Remove accidentally committed debug printing after r75908.
2074
2075         * Scripts/webkitdirs.pm:
2076
2077 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
2078
2079         Unreviewed.
2080
2081         Add myself to committers list
2082         https://bugs.webkit.org/show_bug.cgi?id=52566
2083
2084         * Scripts/webkitpy/common/config/committers.py:
2085
2086 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
2087
2088         Reviewed by Jeremy Orlow.
2089
2090         GeolocationController should call stopUpdating on destruction
2091         https://bugs.webkit.org/show_bug.cgi?id=52216
2092
2093         fast/dom/Geolocation/window-close-crash.html requires that a
2094         Geolocation watch be started in a secondary window. Consequently,
2095         we need to allow geolocation permission and provide a mock
2096         geolocation position for the secondary window's
2097         GeolocationClientMock.
2098
2099         * DumpRenderTree/chromium/LayoutTestController.cpp:
2100         (LayoutTestController::setGeolocationPermission):
2101         (LayoutTestController::setMockGeolocationPosition):
2102         (LayoutTestController::setMockGeolocationError):
2103         * DumpRenderTree/chromium/TestShell.h:
2104         (TestShell::windowList):
2105
2106 2011-01-16  Adam Barth  <abarth@webkit.org>
2107
2108         Update more include paths to reflect WebKit move.
2109
2110         * DumpRenderTree/chromium/EventSender.cpp:
2111         (EventSender::keyDown):
2112         (EventSender::needsShiftModifier):
2113         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
2114         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
2115
2116 2011-01-16  Kent Tamura  <tkent@chromium.org>
2117
2118         Unreviewed, Chromium build fix.
2119
2120         * Scripts/update-webkit-chromium: Webkit/chromium -> Source/WebKit/chromium
2121
2122 2011-01-16  Martin Robinson  <mrobinson@igalia.com>
2123
2124         Build fix for GTK+ after source directory movement.
2125
2126         * GNUmakefile.am: Correct include paths.
2127
2128 2011-01-16  Adam Barth  <abarth@webkit.org>
2129
2130         Teach svn-apply about WebKit move.
2131
2132         * Scripts/VCSUtils.pm:
2133
2134 2011-01-16  Adam Barth  <abarth@webkit.org>
2135
2136         Rubber-stamped by Eric Seidel.
2137
2138         Move WebKit into Source
2139         https://bugs.webkit.org/show_bug.cgi?id=52530
2140
2141         * DumpRenderTree/mac/InternalHeaders/WebKit/WebTypesInternal.h:
2142         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2143         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2144         * DumpRenderTree/qt/GCControllerQt.cpp:
2145         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2146         * DumpRenderTree/qt/PlainTextControllerQt.cpp:
2147         * DumpRenderTree/qt/TextInputControllerQt.cpp:
2148         * DumpRenderTree/wscript:
2149         * QtTestBrowser/launcherwindow.h:
2150         * Scripts/build-webkit:
2151         * Scripts/webkitdirs.pm:
2152
2153 2011-01-15  Adam Barth  <abarth@webkit.org>
2154
2155         Teach svn-apply about WebKit2 move.
2156
2157         * Scripts/VCSUtils.pm:
2158
2159 2011-01-15  Adam Barth  <abarth@webkit.org>
2160
2161         Rubber-stamped by Eric Seidel.
2162
2163         Move WebKit2 into Source
2164         https://bugs.webkit.org/show_bug.cgi?id=52438
2165
2166         * MiniBrowser/qt/MiniBrowser.pro:
2167         * Scripts/build-webkit:
2168         * Scripts/do-file-rename:
2169         * Scripts/do-webcore-rename:
2170         * Scripts/test-webkitpy:
2171         * Scripts/webkitdirs.pm:
2172         * Scripts/webkitpy/style/checker.py:
2173         * WebKitTestRunner/DerivedSources.pro:
2174         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2175         * WebKitTestRunner/qt/WebKitTestRunner.pro:
2176
2177 2011-01-15  Jochen Eisinger  <jochen@chromium.org>
2178
2179         Reviewed by David Levin.
2180
2181         [chromium] remove obsolete createView method
2182         https://bugs.webkit.org/show_bug.cgi?id=52437
2183
2184         * DumpRenderTree/chromium/WebViewHost.cpp:
2185         (WebViewHost::createView):
2186         * DumpRenderTree/chromium/WebViewHost.h:
2187
2188 2011-01-14  Brian Weinstein  <bweinstein@apple.com>
2189
2190         Reviewed by Geoff Garen.
2191
2192         ShouldLoadResourceForFrame should use strings, not URLs.
2193         https://bugs.webkit.org/show_bug.cgi?id=52476
2194
2195         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2196         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Update to use a WKStringRef.
2197         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2198
2199 2011-01-14  Tony Gentilcore  <tonyg@chromium.org>
2200
2201         Reviewed by David Levin.
2202
2203         Add Tony Gentilcore as a reviewer
2204         https://bugs.webkit.org/show_bug.cgi?id=52480
2205
2206         * Scripts/webkitpy/common/config/committers.py:
2207
2208 2011-01-14  David Levin  <levin@chromium.org>
2209
2210         Reviewed by Eric Seidel.
2211
2212         check-webkit-style: _FunctionState should keep track of where the function name starts.
2213         https://bugs.webkit.org/show_bug.cgi?id=52454
2214
2215         * Scripts/webkitpy/style/checkers/cpp.py: Added function_name_start_position to
2216         _FunctionState and logic for setting it correctly.
2217         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests.
2218
2219 2011-01-14  Vincent Scheib  <scheib@chromium.org>
2220
2221         Reviewed by David Levin.
2222
2223         Add support to DumpRenderTree to use the GPU rather than software renderer
2224         https://bugs.webkit.org/show_bug.cgi?id=52333
2225
2226         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2227         (main):
2228         * Scripts/webkitpy/layout_tests/port/chromium.py:
2229         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2230
2231 2011-01-14  Tony Chang  <tony@chromium.org>
2232
2233         Reviewed by Kent Tamura.
2234
2235         [chromium] update fonts.conf to fix 6 linux tests in drt
2236         https://bugs.webkit.org/show_bug.cgi?id=52411
2237
2238         * DumpRenderTree/chromium/fonts.conf: Update to match the copy in
2239             chromium's src/webkit/tools/test_shell/resources/fonts.conf
2240
2241 2011-01-14  Eric Seidel  <eric@webkit.org>
2242
2243         Original patch from Peter Gal  <galpater@inf.u-szeged.hu>
2244
2245         Reviewed by Adam Barth.
2246
2247         Fix when running Tools/Scripts/check-webkit-style without arguments.
2248         https://bugs.webkit.org/show_bug.cgi?id=52261#c16
2249
2250         * Scripts/webkitpy/common/checkout/scm.py: Handle None for changed_files argument better in Git.create_patch method.
2251         * Scripts/webkitpy/common/checkout/scm_unittest.py:
2252
2253 2011-01-04  Jochen Eisinger  <jochen@chromium.org>
2254
2255         Reviewed by David Levin.
2256
2257         Store the tempdir object in a variable so it doesn't get deleted too early.
2258         https://bugs.webkit.org/show_bug.cgi?id=51875
2259
2260         * Scripts/update-webkit-auxiliary-libs:
2261         * Scripts/update-webkit-support-libs:
2262
2263 2011-01-14  Eric Seidel  <eric@webkit.org>
2264
2265         Unreviewed.  Make it work in python 2.5.
2266
2267         webkit-patch suggest-reviewers dies when ChangeLogs are missing
2268         https://bugs.webkit.org/show_bug.cgi?id=49158
2269
2270         * Scripts/webkitpy/common/checkout/api_unittest.py:
2271
2272 2011-01-14  Sheriff Bot  <webkit.review.bot@gmail.com>
2273
2274         Unreviewed, rolling out r75774.
2275         http://trac.webkit.org/changeset/75774
2276         https://bugs.webkit.org/show_bug.cgi?id=52431
2277
2278         gtk builds were broken (Requested by loislo2 on #webkit).
2279
2280         * Scripts/webkitpy/common/checkout/scm.py:
2281
2282 2011-01-14  David Levin  <levin@chromium.org>
2283
2284         Reviewed by Shinichiro Hamaji.
2285
2286         check-webkit-style: _FunctionState should detect pure functions.
2287         https://bugs.webkit.org/show_bug.cgi?id=52428
2288
2289         * Scripts/webkitpy/style/checkers/cpp.py: Added detection for if a function declaration
2290         is a pure virtual function.
2291         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests for verifying that pure
2292         virtual functions are correctly detected.
2293
2294 2011-01-13  Ilya Tikhonovsky  <loislo@chromium.org>
2295
2296         Reviewed by Yury Semikhatsky.
2297
2298         Just small fix for problem with check-webkit-style.
2299         It just didn't work for this patch.
2300         Old code can't concatenate a list of strings with None.
2301
2302         * Scripts/webkitpy/common/checkout/scm.py:
2303
2304 2011-01-13  David Levin  <levin@chromium.org>
2305
2306         Reviewed by Shinichiro Hamaji.
2307
2308         check-webkit-style: _FunctionState should use Position to know where items are.
2309         https://bugs.webkit.org/show_bug.cgi?id=52424
2310
2311         * Scripts/webkitpy/style/checkers/cpp.py:
2312         (_FunctionState.*): Changed _FunctionState to use Position instead of line numbers.
2313         (detect_functions): Changed to pass Position's to _FunctionState.begin and
2314         did some minor clean-up.
2315         (*): Other changes are simply about converting to use the Position's in_FunctionState
2316         instead of line numbers.
2317         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Changed the test code
2318         to verify the positions stored in _FunctionState.
2319
2320 2011-01-13  Eric Seidel  <eric@webkit.org>
2321
2322         Reviewed by David Levin.
2323
2324         webkit-patch suggest-reviewers dies when ChangeLogs are missing
2325         https://bugs.webkit.org/show_bug.cgi?id=49158
2326
2327         This is not the most elegant, but it is a very safe fix to this bug.
2328         One advantage of catching ScriptError like this instead of adding a
2329         new added_or_modified_files or fixing all changed_files callers
2330         to use a more specific change_files variant, is that we catch
2331         all kinds of ScriptErrors which might cause our (non-essential)
2332         suggest-reviewers code to fail out.  This should make passing
2333         --suggest-reviewers to webkit-patch upload much more robust
2334         and may even make it possible for us to make it default.
2335
2336         The root of the problem here is that SCM.changed_files includes
2337         deleted ChangeLog paths (from moves, etc) which then when we ask
2338         SVN/Git for the contents of the file at that revision, the command
2339         errors out and Executive.run_command raises a ScriptError.
2340
2341         In the future we might fix this differently by making all current
2342         callers of chagned_files use a more specific method for requesting
2343         what types of changes they're interested in (adds, modifies, deletes, etc.)
2344
2345         * Scripts/webkitpy/common/checkout/api.py:
2346         * Scripts/webkitpy/common/checkout/api_unittest.py:
2347
2348 2011-01-13  Dan Bernstein  <mitz@apple.com>
2349
2350         Reviewed by Alexey Proskuryakov.
2351
2352         <rdar://problem/8827065> REGRESSION (r71884): Cross-origin XHR fails if willSendRequest changes the URL
2353         https://bugs.webkit.org/show_bug.cgi?id=52419
2354
2355         Allow to further control the behavior of the willSendRequest delegate callback by making it
2356         set a different URL in the new request.
2357
2358         * DumpRenderTree/LayoutTestController.cpp:
2359         (addURLToRedirectCallback): Added.
2360         (LayoutTestController::staticFunctions): Added addURLToRedirect.
2361         (LayoutTestController::addURLToRedirect): Added. Adds the redirection to the map.
2362         (LayoutTestController::redirectionDestinationForURL): Added this getter.
2363         * DumpRenderTree/LayoutTestController.h:
2364         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2365         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]): Check
2366         if there is a redirection for the request’s URL, established by addURLToRedirect(), and if so,
2367         change the URL in the new request to the redirect destination.
2368
2369 2011-01-13  Eric Seidel  <eric@webkit.org>
2370
2371         Reviewed by Mihai Parparita.
2372
2373         webkit-patch suggest-reviewers fails due to invalid utf8 in ChangeLog files
2374         https://bugs.webkit.org/show_bug.cgi?id=52416
2375
2376         Example: webkit-patch suggest-reviewers -g ca3890fe74d94d85d6bfa48f9ea497b094d8e717 
2377         UnicodeDecodeError: 'utf8' codec can't decode bytes in position 536-538: invalid data
2378
2379         I also added FIXMEs about the changed_files returning deleted files problem
2380         which is causing the other most common exception for suggest-reviewers
2381         (and is probably breaking sheriff-bots blame detection).
2382
2383         * Scripts/webkitpy/common/checkout/api.py:
2384         * Scripts/webkitpy/common/checkout/api_unittest.py:
2385         * Scripts/webkitpy/common/checkout/scm.py:
2386
2387 2011-01-13  Eric Seidel  <eric@webkit.org>
2388
2389         Reviewed by Adam Barth.
2390
2391         results archives from commit-queue are too large to upload
2392         https://bugs.webkit.org/show_bug.cgi?id=52405
2393
2394         * Scripts/webkitpy/common/system/filesystem.py:
2395         * Scripts/webkitpy/common/system/filesystem_mock.py:
2396         * Scripts/webkitpy/tool/commands/queues.py:
2397
2398 2011-01-13  Alejandro G. Castro  <alex@igalia.com>
2399
2400         Reviewed by Martin Robinson.
2401
2402         [gtk] Zero-sized font does not yet work
2403         https://bugs.webkit.org/show_bug.cgi?id=49793
2404
2405         Set minimum-font-size to 0 for the DRT.
2406
2407         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2408         (resetDefaultsToConsistentValues):
2409
2410 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
2411
2412         Reviewed by Darin Adler.
2413
2414         Make old-run-webkit-tests more robust on buildbots
2415         https://bugs.webkit.org/show_bug.cgi?id=52364
2416
2417         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Pass --exit-after-n-failures 500 to old-run-webkit-tests script.
2418
2419 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
2420
2421         Reviewed by Darin Adler.
2422
2423         Make old-run-webkit-tests more robust on buildbots
2424         https://bugs.webkit.org/show_bug.cgi?id=52364
2425
2426         * Scripts/old-run-webkit-tests: Ensure that testResultsDirectory is empty.
2427
2428 2011-01-13  Tony Chang  <tony@chromium.org>
2429
2430         Reviewed by Kent Tamura.
2431
2432         [chromium] fix plugins/plugin-javascript-access.html on Linux and Mac
2433         https://bugs.webkit.org/show_bug.cgi?id=52332
2434
2435         Forked Info.plist is not longer needed.
2436
2437         * DumpRenderTree/chromium/TestNetscapePlugIn/Info.plist: Removed.
2438
2439 2011-01-13  Mikhail Naganov  <mnaganov@chromium.org>
2440
2441         Reviewed by Timothy Hatcher.
2442
2443         Web Inspector: Cleanup after r75613 -- make all UI-facing strings
2444         to be passed directly to WebInspector.UIString
2445
2446         https://bugs.webkit.org/show_bug.cgi?id=52365
2447
2448         * Scripts/check-inspector-strings:
2449
2450 2011-01-13  Sheriff Bot  <webkit.review.bot@gmail.com>
2451
2452         Unreviewed, rolling out r74881.
2453         http://trac.webkit.org/changeset/74881
2454         https://bugs.webkit.org/show_bug.cgi?id=52357
2455
2456         The EFL builder has been red for days (Requested by abarth on
2457         #webkit).
2458
2459         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2460         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2461
2462 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
2463
2464         Reviewed by David Levin.
2465
2466         Add beforeunload support to WebKitTestRunner
2467         https://bugs.webkit.org/show_bug.cgi?id=52353
2468         
2469         This makes a number of currently failing tests pass.
2470
2471         * WebKitTestRunner/TestController.cpp:
2472         (WTR::runBeforeUnloadConfirmPanel):
2473         (WTR::createOtherPage):
2474         (WTR::TestController::initialize):
2475
2476 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
2477
2478         Reviewed by Sam Weinig.
2479
2480         Detect, identify and recover from WebProcess crashes in run-webkit-tests
2481         https://bugs.webkit.org/show_bug.cgi?id=52330
2482
2483         * Scripts/old-run-webkit-tests: Detect when the regression test tool reports
2484         a web process crash.
2485         * WebKitTestRunner/TestController.cpp:
2486         (WTR::TestController::initialize): Set up a processDidCrash
2487         callback.
2488         (WTR::TestController::processDidCrash): Report that the Web process
2489         crashed.
2490         * WebKitTestRunner/TestController.h:
2491
2492 2011-01-12  David Levin  <levin@chromium.org>
2493
2494         Reviewed by Shinichiro Hamaji.
2495
2496         check-webkit-style -- close_expression function doesn't work correctly.
2497         https://bugs.webkit.org/show_bug.cgi?id=52272
2498
2499         * Scripts/webkitpy/style/checkers/cpp.py:
2500         (Position.__str__): Added a way to convert it to a string which is useful in tests.
2501         (Position.__cmp__): Added a way to compare Position which is useful in tests and
2502         generally useful (for upcoming code changes).
2503         (close_expression): Changed to use Position for input and output.
2504         Also, fixed many bugs such as only working correctly for parenthesis,
2505         not working correctly if given an offset in a line and not finding
2506         the real closing element if there were multiple closing elements in
2507         the same line.
2508         (detect_functions): Adjusted due to the change in arguments for
2509         close_expression.
2510         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2511         (CppStyleTestBase.assert_positions_equal): Added a way to verify that
2512         two positions are the same.
2513         (CppStyleTest.test_position): Added tests for the __str_ and __cmp__ methods.
2514         (CppStyleTest.test_close_expression): Added tests to catch the issues
2515         that were fixed.
2516
2517 2011-01-12  Sheriff Bot  <webkit.review.bot@gmail.com>
2518
2519         Unreviewed, rolling out r75576.
2520         http://trac.webkit.org/changeset/75576
2521         https://bugs.webkit.org/show_bug.cgi?id=52304
2522
2523         broke rebaseline-chromium-webkit-test (Requested by thakis on
2524         #webkit).
2525
2526         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2527         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2528         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
2529         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2530         * Scripts/webkitpy/layout_tests/port/base.py:
2531         * Scripts/webkitpy/layout_tests/port/chromium.py:
2532         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2533         * Scripts/webkitpy/layout_tests/port/test.py:
2534         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2535         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2536         * Scripts/webkitpy/style/checkers/test_expectations.py:
2537         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
2538
2539 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
2540
2541         Reviewed by Darin Adler.
2542
2543         Add a no-build option to run-webkit-tests, to avoid building DRT/WKTR
2544         https://bugs.webkit.org/show_bug.cgi?id=52307
2545
2546         * Scripts/old-run-webkit-tests:
2547
2548 2011-01-12  Koan-Sin Tan  <koansin.tan@gmail.com>
2549
2550         Reviewed by Martin Robinson.
2551
2552         [Gtk] WebKitGtk+ doesn't build on Mac OS X 10.6
2553         https://bugs.webkit.org/show_bug.cgi?id=50867
2554
2555         Fixed library extention for Mac in webkitdirs.pm and type conflict in
2556         TestNetscapePlugin.cpp 
2557
2558         * GNUmakefile.am: Don't use AppKit when compiling TestNetscapePlugin for GTK+
2559         * Scripts/webkitdirs.pm:
2560
2561 2011-01-12  Mikhail Naganov  <mnaganov@chromium.org>
2562
2563         Reviewed by Pavel Feldman.
2564
2565         Add check-inspector-strings script.
2566
2567         https://bugs.webkit.org/show_bug.cgi?id=52295
2568
2569         * Scripts/check-inspector-strings: Added.
2570
2571 2011-01-12  Adam Roben  <aroben@apple.com>
2572
2573         Advertise the .testnetscape file extension on Windows
2574
2575         Fixes <http://webkit.org/b/52298>
2576         plugins/no-mime-with-valid-extension.html fails on Windows
2577
2578         Reviewed by Dan Bernstein.
2579
2580         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Added a
2581         FileExtents field to map the .testnetscape file extension to the
2582         application/x-webkit-test-netscape MIME type, just as we do on Mac.
2583
2584 2011-01-12  Adam Barth  <abarth@webkit.org>
2585
2586         Reviewed by Eric Seidel.
2587
2588         Make webkit-patch support subdirectories for SVN checkouts
2589         https://bugs.webkit.org/show_bug.cgi?id=52261
2590
2591         os.relpath does not exist on Python 2.5, so we need to call our version
2592         of the API.
2593
2594         * Scripts/webkitpy/common/checkout/scm.py:
2595
2596 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
2597
2598         Reviewed by Eric Seidel.
2599
2600         Close additional pages opened during a test once the test completes.
2601         https://bugs.webkit.org/show_bug.cgi?id=52276
2602
2603         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2604         (WTR::InjectedBundle::done):
2605
2606 2011-01-11  David Levin  <levin@chromium.org>
2607
2608         Reviewed by Eric Seidel.
2609
2610         Errors should be separated from the command line in bot messages.
2611         https://bugs.webkit.org/show_bug.cgi?id=52275
2612
2613         * Scripts/webkitpy/common/system/executive.py:
2614         (ScriptError.message_with_output): Added a newline to separate the command
2615         line from the errors.
2616         * Scripts/webkitpy/common/system/executive_unittest.py:
2617         (ScriptErrorTest.test_message_with_output): Added tests for the various code
2618         paths in message_with_output.
2619
2620 2011-01-11  Eric Seidel  <eric@webkit.org>
2621
2622         Unreviewed.
2623
2624         commit-queue should know how to upload archived results (for test flakes or general failures)
2625         https://bugs.webkit.org/show_bug.cgi?id=52048
2626
2627         The zips are mostly empty due to forgetting -r.
2628         Expected diffs were not being pulled from the archive due
2629         to the archive having longer paths than I realized.
2630
2631         * Scripts/webkitpy/common/system/workspace.py:
2632         * Scripts/webkitpy/common/system/workspace_unittest.py:
2633         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2634         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2635
2636 2011-01-11  Dirk Pranke  <dpranke@chromium.org>
2637
2638         Reviewed by Ojan Vafai.
2639
2640         The current modifier parsing code in test_expectations is
2641         fragile and hard-coded, so it's not easy to understand the logic
2642         or easily add new types of modifiers (like GPU vs. CPU testing
2643         for graphics tests, or 32-bit vs. 64-bit differences).
2644
2645         This is the first of two patches that will add in more generic
2646         support and then eliminate the GPU-specific test expectations
2647         files for Chromium.
2648
2649         This patch adds two standalone objects for handling modifiers. The
2650         rules for interpreting modifiers, precedence, and conflicts are
2651         given in the docstring to the ModifierMatcher class, which
2652         returns ModifierMatchResult objects.
2653         
2654         This patch also adds routines to the Port interface and a
2655         default set of values in the base object, in order to obtain the
2656         values needed on a given test run. These values are then passed
2657         to the expectation parser. This also allows us to clean up the
2658         logic used to lint all of the different configurations in a
2659         single test_expectations.txt file.
2660
2661         The next patch will merge in the separate GPU expectations file.
2662
2663         https://bugs.webkit.org/show_bug.cgi?id=51222
2664
2665         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2666         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2667         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
2668         * Scripts/webkitpy/layout_tests/port/base.py:
2669         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2670         * Scripts/webkitpy/layout_tests/port/chromium.py:
2671         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2672         * Scripts/webkitpy/layout_tests/port/test.py:
2673         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2674         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2675
2676 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
2677
2678         Reviewed by Adam Barth.
2679
2680         Make webkit-patch support subdirectories for SVN checkouts
2681         https://bugs.webkit.org/show_bug.cgi?id=52261
2682
2683         * Scripts/webkitpy/common/checkout/scm.py:
2684         * Scripts/webkitpy/style_references.py:
2685         * Scripts/webkitpy/tool/main.py:
2686         * Scripts/webkitpy/tool/steps/preparechangelog.py:
2687
2688 2011-01-11  Eric Seidel  <eric@webkit.org>
2689
2690         Unreviewed.
2691
2692         commit-queue should know how to upload archived results (for test flakes or general failures)
2693         https://bugs.webkit.org/show_bug.cgi?id=52048
2694
2695         I changed the API for archive_last_layout_test_results w/o updating the implementation.  Oops.
2696         This fixes an exception seen on the commit-queue when attempting to report flaky tests.
2697
2698         * Scripts/webkitpy/common/system/workspace.py:
2699         * Scripts/webkitpy/common/system/workspace_unittest.py:
2700         * Scripts/webkitpy/tool/commands/queues.py:
2701
2702 2011-01-11  Sam Weinig  <sam@webkit.org>
2703
2704         Roll r75474 back in.
2705
2706 2011-01-11  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
2707
2708         Reviewed by Kenneth Rohde Christiansen.
2709
2710         [Qt] Remove uses of QFuture since it isn't supported on all platforms.
2711         https://bugs.webkit.org/show_bug.cgi?id=51204
2712
2713         * QtTestBrowser/webpage.h:
2714         (QtNAMThread::QtNAMThread):
2715         (QtNAMThread::networkAccessManager):
2716         (QtNAMThread::run):
2717
2718 2011-01-11  Peter Varga  <pvarga@webkit.org>
2719
2720         Unreviewed.
2721
2722         Add myself to committers' list.
2723
2724         * Scripts/webkitpy/common/config/committers.py:
2725
2726 2011-01-11  Eric Seidel  <eric@webkit.org>
2727
2728         Reviewed by Adam Barth.
2729
2730         commit-queue should know how to upload archived results (for test flakes or general failures)
2731         https://bugs.webkit.org/show_bug.cgi?id=52048
2732
2733         Now the queue will always upload results.  Either the entire zip, or just
2734         the diffs.txt in the case of text failures.
2735
2736         This should make understanding flakes much easier, and paves the way
2737         for having the EWS run layout tests (and upload failures).
2738
2739         In order to upload .zip files I had to teach bugzilla.py to autodetect
2740         mime types from the filename.  Since mimetypes.py doesn't include a mapping
2741         for .patch files, I have it add one before calling guess_type.
2742
2743         We may find that always uploading the whole zip instead of just the -diffs.txt
2744         file is preferable, but for now I'm keeping the old behavior because it makes
2745         quickly understanding text failures easy.
2746
2747         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2748         * Scripts/webkitpy/common/system/workspace.py: Added.
2749         * Scripts/webkitpy/common/system/workspace_unittest.py: Added.
2750         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2751         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2752         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2753         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2754         * Scripts/webkitpy/tool/commands/queues.py:
2755         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2756
2757 2011-01-10  Sheriff Bot  <webkit.review.bot@gmail.com>
2758
2759         Unreviewed, rolling out r75464.
2760         http://trac.webkit.org/changeset/75464
2761         https://bugs.webkit.org/show_bug.cgi?id=52193
2762
2763         Followup rollout for 75474 (Requested by Ossy on #webkit).
2764
2765         * MiniBrowser/mac/BrowserWindowController.m:
2766         (-[BrowserWindowController awakeFromNib]):
2767         * MiniBrowser/win/BrowserView.cpp:
2768         (BrowserView::create):
2769         * WebKitTestRunner/TestController.cpp:
2770         (WTR::createOtherPage):
2771         (WTR::TestController::initialize):
2772
2773 2011-01-10  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2774
2775         Reviewed by Csaba Osztrogonác.
2776
2777         [Qt] Baseline qt_minimal configuration
2778         https://bugs.webkit.org/show_bug.cgi?id=51313
2779
2780         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2781         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): Add
2782         QT_NO_UNDOSTACK guard.
2783
2784         * QtTestBrowser/launcherwindow.cpp:
2785         (LauncherWindow::createChrome): Add QT_NO_SHORTCUT and QT_NO_PRINTER
2786         guards.
2787         (LauncherWindow::applyZoom): Add QT_NO_ANIMATION guard.
2788         (LauncherWindow::screenshot): Add QT_NO_FILEDIALOG guard.
2789         (LauncherWindow::selectElements): Add QT_NO_INPUTDIALOG guard.
2790         (LauncherWindow::showUserAgentDialog): Add QT_NO_COMBOBOX guard.
2791
2792         * QtTestBrowser/launcherwindow.h:
2793         * QtTestBrowser/locationedit.cpp: Add QT_NO_INPUTDIALOG guard.
2794         * QtTestBrowser/locationedit.h: Ditto.
2795
2796         * QtTestBrowser/mainwindow.cpp:
2797         (MainWindow::buildUI): Add QT_NO_INPUTDIALOG, QT_NO_SHORTCUT and
2798         QT_NO_UNDOSTACK guards.
2799         (MainWindow::setAddressUrl): Add QT_NO_INPUTDIALOG guard.
2800         (MainWindow::changeLocation): Ditto.
2801         (MainWindow::openFile): Add QT_NO_FILEDIALOG guard.
2802         (MainWindow::openLocation): Add QT_NO_INPUTDIALOG guard.
2803
2804         * QtTestBrowser/webpage.cpp:
2805         (WebPage::openUrlInDefaultBrowser): Add QT_NO_DESKTOPSERVICES guard.
2806         (WebPage::authenticationRequired): Add QT_NO_LINEEDIT guard.
2807
2808         * QtTestBrowser/webview.cpp:
2809         (WebViewGraphicsBased::animatedFlip): Add QT_NO_ANIMATION guard.
2810         (WebViewGraphicsBased::animatedYFlip): Ditto.
2811
2812 2011-01-10  Sam Weinig  <sam@webkit.org>
2813
2814         Fix build.
2815
2816         * MiniBrowser/mac/BrowserWindowController.m:
2817         (-[BrowserWindowController awakeFromNib]):
2818         * MiniBrowser/win/BrowserView.cpp:
2819         (BrowserView::create):
2820         * WebKitTestRunner/TestController.cpp:
2821         (WTR::createOtherPage):
2822         (WTR::TestController::initialize):
2823
2824 2011-01-10  Eric Seidel  <eric@webkit.org>
2825
2826         Reviewed by Ojan Vafai.
2827
2828         style-queue messages are way too long for big patches
2829         https://bugs.webkit.org/show_bug.cgi?id=52161
2830
2831         We definitely could build much fancier list-to-string-with-limit functions
2832         but this should be sufficient for our needs at the moment.
2833
2834         * Scripts/webkitpy/common/system/executive.py:
2835         * Scripts/webkitpy/common/system/executive_unittest.py:
2836
2837 2011-01-10  Tony Chang  <tony@chromium.org>
2838
2839         Unreviewed, rolling out r75398.
2840         http://trac.webkit.org/changeset/75398
2841         https://bugs.webkit.org/show_bug.cgi?id=52008
2842
2843         Some layout tests are crashing on Chromium Win.
2844
2845         * DumpRenderTree/chromium/WebViewHost.cpp:
2846         (WebViewHost::updatePaintRect):
2847         * DumpRenderTree/chromium/WebViewHost.h:
2848
2849 2011-01-10  Adam Roben  <aroben@apple.com>
2850
2851         Roll out r75392
2852
2853         It isn't needed now that r75289 has been rolled out.
2854
2855         * Scripts/run-javascriptcore-tests:
2856
2857 2011-01-10  Maciej Stachowiak  <mjs@apple.com>
2858
2859         Reviewed by Anders Carlsson.
2860
2861         WebKitTestRunner uses crazy amounts of CPU, making layout tests slow and flaky
2862         https://bugs.webkit.org/show_bug.cgi?id=52160
2863
2864         * WebKitTestRunner/mac/TestControllerMac.mm:
2865         (WTR::TestController::platformRunUntil): Instead of busy-looping, wait for the timeout.
2866         Anything that can make runUntil() conditions turn true will happen on a run loop cycle
2867         anyway.
2868
2869 2011-01-10  Tony Chang  <tony@chromium.org>
2870
2871         Reviewed by Mihai Parparita.
2872
2873         [chromium] fix for animated gif layout tests
2874         https://bugs.webkit.org/show_bug.cgi?id=52008
2875
2876         * DumpRenderTree/chromium/WebViewHost.cpp: Schedule a paint when we update the paint rect
2877             to trigger gif animations.
2878         (WebViewHostPaintTask::WebViewHostPaintTask):
2879         (WebViewHostPaintTask::runIfValid):
2880         (WebViewHost::updatePaintRect):
2881         * DumpRenderTree/chromium/WebViewHost.h:
2882         (WebViewHost::taskList):
2883
2884 2011-01-10  Alejandro G. Castro  <alex@igalia.com>
2885
2886         Reviewed by Xan Lopez.
2887
2888         [GTK] Fix gtk2 compilation for master
2889         https://bugs.webkit.org/show_bug.cgi?id=51885
2890
2891         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
2892         (createBitmapContextFromWebView): Replaced the old
2893         gdk_drawable_get_size with gdk_pixmap_get_size.
2894
2895 2011-01-10  Patrick Gansterer  <paroga@webkit.org>
2896
2897         Reviewed by Laszlo Gombos.
2898
2899         [WINCE] Reenable NPAPI after r75203
2900         https://bugs.webkit.org/show_bug.cgi?id=52109
2901
2902         Remove the !isWinCE() check for ENABLE_NETSCAPE_PLUGIN_API and replace
2903         it with !isEfl(), because EFL port does not support NPAPI (yet).
2904
2905         * Scripts/build-webkit:
2906
2907 2011-01-10  Adam Roben  <aroben@apple.com>
2908
2909         Skip some asserting JS tests
2910
2911         See <http://webkit.org/b/52156>.
2912
2913         * Scripts/run-javascriptcore-tests:
2914
2915 2011-01-10  Martin Robinson  <mrobinson@igalia.com>
2916
2917         Reviewed by Xan Lopez.
2918
2919         [GTK] build-webkit disable Blob support via arguments passed to automake
2920         https://bugs.webkit.org/show_bug.cgi?id=52097
2921
2922         * Scripts/build-webkit: Enable Blob support when building WebKitGTK+ via
2923         build-webkit.
2924
2925 2011-01-10  Adam Roben  <aroben@apple.com>
2926
2927         Use the same name and description for TestNetscapePlugin on Windows and
2928         Mac
2929
2930         Fixes <http://webkit.org/b/52151>
2931         fast/frames/iframe-reparenting-plugins.html fails on Windows
2932
2933         Reviewed by Steve Falkenburg.
2934
2935         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Copied
2936         the name and description from Mac's Info.plist.
2937
2938 2011-01-10  Siddharth Mathur <siddharth.mathur@nokia.com>
2939
2940         Reviewed by Laszlo Gombos.
2941
2942         [Qt][WK2] Guard gcc-specific syntax
2943
2944         Non-gcc based compliers choke on the "-include"
2945         syntax for preinclude, place guard around it.
2946
2947         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2948         * WebKitTestRunner/qt/WebKitTestRunner.pro:
2949
2950 2011-01-10  Andreas Kling  <kling@webkit.org>
2951
2952         Reviewed by Simon Hausmann.
2953
2954         [Qt] [WK2] MiniBrowser does not load pages opened in new windows
2955         https://bugs.webkit.org/show_bug.cgi?id=52111
2956
2957         When getting a createNewPage() callback from QWKPage, create the
2958         new page with the same QWKContext as the page that is passed to
2959         the callback.
2960
2961         * MiniBrowser/qt/BrowserView.h:
2962         * MiniBrowser/qt/BrowserWindow.cpp:
2963         (newPageFunction):
2964         (BrowserWindow::BrowserWindow):
2965         * MiniBrowser/qt/BrowserWindow.h:
2966
2967 2011-01-10  Andreas Kling  <kling@webkit.org>
2968
2969         Reviewed by Kenneth Rohde Christiansen.
2970
2971         [Qt] MiniBrowser: Remove superfluous createNewPage() callback
2972
2973         BrowserView set its own useless createNewPage() callback on QWKPage.
2974         This was immediately overridden by BrowserWindow anyway, so remove
2975         the BrowserView one.
2976
2977         * MiniBrowser/qt/BrowserView.cpp:
2978         (BrowserView::BrowserView):
2979
2980 2011-01-10  John Knottenbelt  <jknotten@chromium.org>
2981
2982         Reviewed by Jeremy Orlow.
2983
2984         [Chromium] Remove non-client-based Geolocation code
2985         https://bugs.webkit.org/show_bug.cgi?id=50921
2986
2987         * DumpRenderTree/chromium/LayoutTestController.cpp:
2988         (LayoutTestController::setGeolocationPermission):
2989         (LayoutTestController::setMockGeolocationPosition):
2990         (LayoutTestController::setMockGeolocationError):
2991         * DumpRenderTree/chromium/WebViewHost.cpp:
2992         (WebViewHost::geolocationClientMock):
2993         (WebViewHost::reset):
2994         * DumpRenderTree/chromium/WebViewHost.h:
2995
2996 2011-01-10  Eric Seidel  <eric@webkit.org>
2997
2998         Reviewed by Adam Barth.
2999
3000         Commit bot tried to land r? cq+ patch
3001         https://bugs.webkit.org/show_bug.cgi?id=36638
3002
3003         It should now be possible to post a patch with r? and cq+ and the
3004         commit-queue will correctly wait for the r+ before attempting to land the patch.
3005         (This was a feature requested by several users.)
3006
3007         One caveat: We don't actually reject r-, cq+ patches from the queue
3008         (we just ignore them), but I think that's OK for now.
3009
3010         I also noticed that setting r- once a commit-queue node had grabbed
3011         a patch would not properly cancel the landing.  That's fixed and
3012         tested in this patch.
3013
3014         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3015         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3016         * Scripts/webkitpy/tool/bot/feeders.py:
3017         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
3018
3019 2011-01-08  Benjamin Poulain  <benjamin.poulain@nokia.com>
3020
3021         Reviewed by Kenneth Rohde Christiansen.
3022
3023         [Qt] QtWebKit crashes when using XMLHttpRequest from the unload event
3024         https://bugs.webkit.org/show_bug.cgi?id=51934
3025
3026         When accessing the network from the destructor of QWebPage, the network access manager
3027         was already deleted because the object WebPage was already destructed.
3028
3029         This solve the problem by linking the lifetime of the network access manager to WebPage's QObject.
3030         The object is now destructed in the destructor of QObject.
3031
3032         * QtTestBrowser/webpage.cpp:
3033         (WebPage::WebPage):
3034         (WebPage::setQnamThreaded):
3035         * QtTestBrowser/webpage.h:
3036         (QtNAMThread::QtNAMThread):
3037
3038 2011-01-08  Eric Seidel  <eric@webkit.org>
3039
3040         Reviewed by Ojan Vafai.
3041
3042         test_failures.py should not mention TestShell (long live DumpRenderTree!)
3043         https://bugs.webkit.org/show_bug.cgi?id=52067
3044
3045         I ran test-webkitpy, but didn't bother adding a unit test for this string change.
3046         https://bugs.webkit.org/show_bug.cgi?id=51138#c3 is an example of why this is needed.
3047
3048         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
3049
3050 2011-01-08  Eric Seidel  <eric@webkit.org>
3051
3052         Reviewed by Mihai Parparita.
3053
3054         commit-queue hangs when the ChangeLog diff is bad
3055         https://bugs.webkit.org/show_bug.cgi?id=52072
3056
3057         * Scripts/webkitpy/tool/steps/validatechangelogs.py:
3058         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
3059
3060 2011-01-08  Adam Barth  <abarth@webkit.org>
3061
3062         Teach svn-apply how to re-write WebCore to Source/WebCore.
3063
3064         * Scripts/VCSUtils.pm:
3065
3066 2011-01-07  Adam Barth  <abarth@webkit.org>
3067
3068         Rubber-stamped by Eric Seidel.
3069
3070         Move WebCore to Source
3071         https://bugs.webkit.org/show_bug.cgi?id=52050
3072
3073         Update the tools to understand WebCore's new location.
3074
3075         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3076         * DumpRenderTree/wscript:
3077         * GNUmakefile.am:
3078         * Scripts/build-webkit:
3079         * Scripts/do-file-rename:
3080         * Scripts/do-webcore-rename:
3081         * Scripts/generate-qt-inspector-resource:
3082         * Scripts/prepare-ChangeLog:
3083         * Scripts/run-bindings-tests:
3084         * Scripts/update-iexploder-cssproperties:
3085         * Scripts/update-sources-list.py:
3086         * Scripts/update-webkit-localizable-strings:
3087         * Scripts/webkitdirs.pm:
3088         * Scripts/webkitpy/common/config/build.py:
3089         * Scripts/webkitpy/common/config/build_unittest.py:
3090         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
3091         * Scripts/webkitpy/style/checker.py:
3092         * Scripts/webkitpy/style/checker_unittest.py:
3093         * WebKitTestRunner/DerivedSources.pro:
3094         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3095         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh:
3096         * wx/browser/wscript:
3097         * wx/build/settings.py:
3098
3099 2011-01-07  Maciej Stachowiak  <mjs@apple.com>
3100
3101         Reviewed by Sam Weinig.
3102
3103         Make WebKitTestRunner rest between loads more robust to avoid test crashes
3104         https://bugs.webkit.org/show_bug.cgi?id=52086
3105
3106         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3107         (WTR::InjectedBundle::didReceiveMessage):
3108         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3109         (WTR::LayoutTestController::notifyDone):
3110         * WebKitTestRunner/TestController.cpp:
3111         (WTR::TestController::resetStateToConsistentValues):
3112         (WTR::TestController::run):
3113
3114 2011-01-07  James Robinson  <jamesr@chromium.org>
3115
3116         Revert "Implement mozilla's animationTime property"
3117         https://bugs.webkit.org/show_bug.cgi?id=51952
3118
3119         This approach isn't quite right.
3120
3121         * DumpRenderTree/chromium/WebViewHost.cpp:
3122         (WebViewHost::paintInvalidatedRegion):
3123
3124 2011-01-07  Adam Roben  <aroben@apple.com>
3125
3126         Build master fix
3127
3128         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3129         (RunWebKitTests.start): Don't try to concatenate a list and a string.
3130
3131 2011-01-07  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>
3132
3133         Reviewed by Csaba Osztrogonác.
3134
3135         run-qtwebkit-tests should be able to kill a testsuite.
3136
3137         Add new option in the script that can setup a timeout for a test.
3138         If the test execution takes more then specified time then the test
3139         would be terminated.
3140
3141         [Qt] run-qtwebkit-tests needs timeout
3142         https://bugs.webkit.org/show_bug.cgi?id=51894
3143
3144         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3145         * Scripts/run-qtwebkit-tests:
3146
3147 2011-01-07  Csaba Osztrogonác  <ossy@webkit.org>
3148
3149         Unreviewed fix after r75233.
3150
3151         Based on idea from Eric Seidel.
3152
3153         Add remote zip file handling to webkitpy.
3154         https://bugs.webkit.org/show_bug.cgi?id=50901
3155
3156         * Scripts/webkitpy/common/system/fileset.py: Make python 2.5 happy.
3157
3158 2011-01-07  Shane Stephens  <shanestephens@google.com>
3159
3160         Reviewed by Eric Seidel.
3161
3162         svn-apply: should support git binary delta diffs
3163         https://bugs.webkit.org/show_bug.cgi?id=38864
3164
3165         * Scripts/VCSUtils.pm:
3166         * Scripts/svn-apply:
3167
3168 2011-01-06  Julie Parent  <jparent@chromium.org>
3169
3170         Reviewed by Eric Seidel.
3171
3172         Test Result Server not removing old results.
3173         https://bugs.webkit.org/show_bug.cgi?id=52012
3174
3175         * TestResultServer/model/jsonresults.py:
3176         Fix off-by-one: Truncate if >= num_runs, not just >.
3177         * TestResultServer/model/jsonresults_unittest.py:
3178         Add unit test to test that merging in a new result with the same value
3179         as the last result causes previous result to fall off.
3180
3181 2011-01-06  James Kozianski  <koz@chromium.org>
3182
3183         Reviewed by Mihai Parparita.
3184
3185         Add classes to provide a consistent interface to a set of files.
3186         https://bugs.webkit.org/show_bug.cgi?id=50901
3187
3188         These classes allow us to write code that is agnostic to whether a
3189         particular set of files resides in a local directory or in a zip file
3190         on a remote machine.
3191
3192         * Scripts/webkitpy/common/system/directoryfileset.py: Added.
3193         * Scripts/webkitpy/common/system/directoryfileset_unittest.py: Added.
3194         * Scripts/webkitpy/common/system/fileset.py: Added.
3195         * Scripts/webkitpy/common/system/filesystem.py:
3196         * Scripts/webkitpy/common/system/filesystem_mock.py:
3197         * Scripts/webkitpy/common/system/zipfileset.py: Added.
3198         * Scripts/webkitpy/common/system/zipfileset_unittest.py: Added.
3199
3200 2011-01-06  Eric Seidel  <eric@webkit.org>
3201
3202         Reviewed by Adam Barth.
3203
3204         NetworkTransaction should log the url it is retrying
3205         https://bugs.webkit.org/show_bug.cgi?id=52043
3206
3207         * Scripts/webkitpy/common/net/networktransaction.py:
3208         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
3209
3210 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
3211
3212         Windows build fix.
3213         Import os before using it.
3214
3215         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3216
3217 2011-01-06  Eric Seidel  <eric@webkit.org>
3218
3219         Reviewed by Adam Barth.
3220
3221         StyleQueue fails to report errors when patches have many files
3222         https://bugs.webkit.org/show_bug.cgi?id=52042
3223
3224         This is one of at least two errors preventing style error reporting at the moment.
3225         When we moved to passing the list of files to check explicitly,
3226         we started to exceed the 500 character TEXT field limit for our AppEngine model object.
3227         We could change the type of the QueueStatus.message type, or we could
3228         just teach statusserver.py how to clamp values (and warn when it does).
3229         I chose the latter path.
3230
3231         * Scripts/webkitpy/common/net/statusserver.py:
3232
3233 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
3234
3235         Reviewed by Stephanie Lewis.
3236         
3237         Fix syntax error in script.
3238
3239         Windows bots need to archive/unarchive builds to/from configuration-specific directories
3240         https://bugs.webkit.org/show_bug.cgi?id=51996
3241
3242         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3243
3244 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3245
3246         Unreviewed, fixing WinCE build after r75196.
3247
3248         WinCE port does not (yet) support NPAPI.
3249
3250         * Scripts/build-webkit:
3251
3252 2011-01-06  Xan Lopez  <xlopez@igalia.com>
3253
3254         Reviewed by Darin Adler.
3255
3256         File::Spec->rel2abs in sunspider-compare-results mangles parameters
3257         https://bugs.webkit.org/show_bug.cgi?id=52015
3258
3259         * Scripts/sunspider-compare-results: call rel2abs on our arguments
3260         after the platform has been detected, otherwise the script will
3261         mangle things like '--gtk' into '/a/path/--gtk', breaking the
3262         detection.
3263
3264 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3265
3266         Reviewed by Eric Seidel.
3267
3268         Add ENABLE_NETSCAPE_PLUGIN_API, ENABLE_ORIENTATION_EVENTS and ENABLE_TOUCH_EVENTS flags to build-webkit
3269         https://bugs.webkit.org/show_bug.cgi?id=51346
3270
3271         * Scripts/build-webkit:
3272
3273 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
3274
3275         Reviewed by Adam Roben.
3276
3277         Windows bots need to archive/unarchive builds to/from configuration-specific directories
3278         https://bugs.webkit.org/show_bug.cgi?id=51996
3279         
3280         After the configuration directory change, we were archiving the incorrect directory for
3281         build product, so we were running tests on the wrong binaries.
3282         
3283         This change archives the correct directory, and also unarchives it into a configuration-
3284         specific directory.
3285
3286         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Use a configuration-specific directory on Windows.
3287         * BuildSlaveSupport/built-product-archive: Unarchive/archive to/from proper directory.
3288
3289 2011-01-06  Eric Seidel  <eric@webkit.org>
3290
3291         Reviewed by Mihai Parparita.
3292
3293         commit-queue mentions "Text diff mismatch" 4 times instead of once per failure
3294         https://bugs.webkit.org/show_bug.cgi?id=52002
3295
3296         See an example of this here:
3297         https://bugs.webkit.org/show_bug.cgi?id=51314#c2
3298
3299         It's due to the fact that we pass around TestFailure() instance
3300         objects and yet expect them to all compare to be the same.
3301
3302         This is bad.  We should either have shared instances of these values
3303         or we should just pass around the class names.  There are already hacks
3304         in place to make TestFailure objects pass equality tests, I just added
3305         a __hash__ implementation so they can be used in sets as expected.
3306
3307         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3308         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
3309
3310 2011-01-06  Evan Martin  <evan@chromium.org>
3311
3312         Reviewed by Tony Chang.
3313
3314         [gdb] handle inaccessible memory and UChar*
3315         https://bugs.webkit.org/show_bug.cgi?id=52003
3316
3317         To pretty-print a UChar*, we just grope around in the memory
3318         looking for a terminating NUL.  We need to handle the exception
3319         that can occur when we poke into an invalid location.
3320
3321         Additionally, the logic for choosing which pretty-printer would
3322         early return before hitting the point where we'd use the UChar*
3323         printer.  (Did this ever work?  How did it regress?)
3324
3325         * gdb/webkit.py:
3326
3327 2011-01-05  Brian Weinstein  <bweinstein@apple.com>
3328
3329         Reviewed by Ada Chan.
3330
3331         WebKit2: Should be able to call into injected bundle to ask if we should allow resource loads
3332         https://bugs.webkit.org/show_bug.cgi?id=51969
3333         
3334         Add shouldLoadResourceForFrame to WTR::InjectedBundlePage.
3335
3336         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3337         (WTR::InjectedBundlePage::InjectedBundlePage):
3338         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Stub implementation.
3339         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3340
3341 2011-01-06  James Robinson  <jamesr@chromium.org>
3342
3343         Reviewed by Simon Fraser.
3344
3345         Implement mozilla's animationTime property
3346         https://bugs.webkit.org/show_bug.cgi?id=51952
3347
3348         Chromium DRT support for webkitAnimationTime.
3349
3350         * DumpRenderTree/chromium/WebViewHost.cpp:
3351         (WebViewHost::paintInvalidatedRegion):
3352
3353 2011-01-06  Julie Parent  <jparent@chromium.org>
3354
3355         Reviewed by Tony Chang.
3356
3357         Test Result Server always truncates number of results to JSON_RESULTS_MAX_BUILDS
3358         https://bugs.webkit.org/show_bug.cgi?id=51217
3359
3360         * TestResultServer/model/jsonresults.py:
3361         Pass num_runs through to _remove_items_over_max_number_of_builds, and use the value.
3362         Adds missing documentation.
3363         * TestResultServer/model/jsonresults_unittest.py:
3364         Add unit test to test that truncation happens at smaller value than JSON_RESULTS_MAX_BUILDS.
3365         Update test_merge to take a number of builds to truncate at.
3366
3367 2011-01-06  Adam Barth  <abarth@webkit.org>
3368
3369         Reviewed by Eric Seidel.
3370
3371         The EWS should log outside of the working directory
3372         https://bugs.webkit.org/show_bug.cgi?id=51986
3373
3374         This patch prepare us for using git clean -x -d -f in the EWS wrapper
3375         script, which will actually clean the working copy back to a pristine
3376         state instead of leaving untracked directories and ignored files.
3377
3378         * Scripts/webkitpy/tool/commands/queues.py:
3379         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3380
3381 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
3382
3383         Windows build fix.
3384         Back out attempted change to built-product-archive.
3385
3386         * BuildSlaveSupport/built-product-archive:
3387
3388 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
3389
3390         Windows build fix.
3391         Include configuration name when unpacking a build archive.
3392
3393         Needed, since we split Windows build results into configuration-specific directories
3394         under WebKitOutputDir.
3395
3396         * BuildSlaveSupport/built-product-archive:
3397
3398 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
3399
3400         Reviewed by Darin Adler.
3401
3402         Debug and Release builds on Windows clobber each other
3403         https://bugs.webkit.org/show_bug.cgi?id=49185
3404
3405         Changes the structure of WebKitBuild build products directory so we
3406         completely separate each build configuration into independent directories.
3407         
3408         Although we previously had per-configuration directories for obj, this change adds
3409         per-configuration directories for bin, lib, obj, and include. Each configuration's
3410         build products are stored within a directory inside of WebKitBuild.
3411         
3412         Most use of $(WebKitOutputDir) in the build files has been replaced by $(ConfigurationBuildDir),
3413         defined in common.vsprops to be $(WebKitOutputDir)\$(ConfigurationName).
3414
3415         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops:
3416         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd:
3417         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd:
3418         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
3419         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd:
3420         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd:
3421         * DumpRenderTree/win/ImageDiffCommon.vsprops:
3422         * DumpRenderTree/win/ImageDiffPostBuild.cmd:
3423         * DumpRenderTree/win/ImageDiffPreBuild.cmd:
3424         * FindSafari/FindSafari.vcproj:
3425         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
3426         * MiniBrowser/MiniBrowserPostBuild.cmd:
3427         * MiniBrowser/MiniBrowserPreBuild.cmd:
3428         * Scripts/webkitdirs.pm:
3429         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
3430         * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops:
3431         * TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd:
3432         * TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd:
3433         * TestWebKitAPI/win/copy-resources.cmd:
3434         * WebKitAPITest/WebKitAPITestCommon.vsprops:
3435         * WebKitAPITest/WebKitAPITestPostBuild.cmd:
3436         * WebKitAPITest/WebKitAPITestPreBuild.cmd:
3437         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
3438         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
3439         * WebKitTestRunner/win/InjectedBundle.vcproj:
3440         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops:
3441         * WebKitTestRunner/win/InjectedBundlePostBuild.cmd:
3442         * WebKitTestRunner/win/InjectedBundlePreBuild.cmd:
3443         * WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd:
3444         * WebKitTestRunner/win/WebKitTestRunnerPreBuild.cmd:
3445         * WinLauncher/WinLauncherCommon.vsprops:
3446         * WinLauncher/WinLauncherPostBuild.cmd:
3447         * WinLauncher/WinLauncherPreBuild.cmd:
3448
3449 2011-01-05  Jan Erik Hanssen  <jhanssen@sencha.com>
3450
3451         Reviewed by Ariya Hidayat.
3452
3453         [Qt] TestNetscapePlugin doesn't link on OS X
3454         https://bugs.webkit.org/show_bug.cgi?id=51948
3455
3456         Only add a dependency on libX11 on X11 systems
3457
3458         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3459
3460 2011-01-05  Jeff Miller  <jeffm@apple.com>
3461
3462         Reviewed by Adam Roben.
3463
3464         check-webkit-style should allow unnecessary parameter names in WebKit2 APIs because we're matching CF's header style
3465         https://bugs.webkit.org/show_bug.cgi?id=51970
3466
3467         * Scripts/webkitpy/style/checker.py:
3468         Add -readability/naming for WebKit2 C API directories.
3469
3470 2011-01-05  Eric Seidel  <eric@webkit.org>
3471
3472         Unreviewed, just fixing one more log error from my previous python patch.
3473
3474         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
3475         https://bugs.webkit.org/show_bug.cgi?id=51802
3476
3477         webkit-patch failure-reason was logging about parsing errors
3478         due to my misunderstanding of how BeautifulSoup.findAll worked.
3479
3480         Fixed, and added a unit test.
3481
3482         * Scripts/webkitpy/common/net/layouttestresults.py:
3483         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3484
3485 2011-01-05  Benjamin Poulain  <benjamin.poulain@nokia.com>
3486
3487         Reviewed by Kenneth Rohde Christiansen.
3488
3489         [Qt] [WK2] Add the possibility to open window from the WebProcess in Minibrowser
3490         https://bugs.webkit.org/show_bug.cgi?id=51951
3491
3492         Set a function to QWKPage::setCreateNewPageFunction() in Minibrowser so there is a way
3493         to create new window from WebKit.
3494
3495         * MiniBrowser/qt/BrowserWindow.cpp:
3496         (newPageFunction):
3497         (BrowserWindow::BrowserWindow):
3498         (BrowserWindow::page): Added to avoid the indirect access to QWKPage spread in the class
3499         (BrowserWindow::newWindow):
3500         (BrowserWindow::updateUserAgentList):
3501         (BrowserWindow::showUserAgentDialog):
3502         * MiniBrowser/qt/BrowserWindow.h: Add the global variable backingStoreTypeForNewWindow to
3503         define the type of the backing store used for new windows.
3504         * MiniBrowser/qt/main.cpp:
3505         (main):
3506
3507 2011-01-05  Eric Seidel  <eric@webkit.org>
3508
3509         Reviewed by Ojan Vafai.
3510
3511         commit-queue should report failure type when reporting flaky tests
3512         https://bugs.webkit.org/show_bug.cgi?id=51900
3513
3514         This patch was a ridiculous amount of plumbing.  In the end I like
3515         the NRWT-style TestResult class even less.  But now we're passing
3516         a list of TestResult objects from the queue to the FlakyTestReporter.
3517         Thus the FlakyTestReporter can more easily report what type of failure
3518         occurred.
3519
3520         In the process, I found that I was not alone in finding TestResult
3521         cumbersome to use.  A bunch of code was trying to create a TestResult
3522         object with default values.  However since the constructor didn't make
3523         this easy, some places were getting it wrong (including the TestResult unit test)!
3524         I've fixed the TestResult constructor to have default values for non-essential
3525         arguments.
3526
3527         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3528         * Scripts/webkitpy/common/net/layouttestresults.py:
3529         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3530         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3531         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3532         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
3533         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
3534         * Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py:
3535         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
3536         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3537         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3538         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3539         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3540         * Scripts/webkitpy/tool/commands/queues.py:
3541         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3542
3543 2011-01-05  Eric Seidel  <eric@webkit.org>
3544
3545         Unreviewed.
3546
3547         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
3548         https://bugs.webkit.org/show_bug.cgi?id=51802
3549
3550         Add another unit test to cover a previously missing import.
3551
3552         * Scripts/webkitpy/common/net/layouttestresults.py:
3553         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3554
3555 2011-01-05  Mihai Parparita  <mihaip@chromium.org>
3556
3557         Reviewed by David Levin.
3558
3559         Add mihaip@chromium.org as a reviewer
3560         https://bugs.webkit.org/show_bug.cgi?id=51966
3561         
3562         Add myself as a reviewer.
3563
3564         * Scripts/webkitpy/common/config/committers.py:
3565
3566 2011-01-05  James Simonsen  <simonjam@chromium.org>
3567
3568         Unreviewed. Adding myself to the list of committers.
3569
3570         * Scripts/webkitpy/common/config/committers.py:
3571
3572 2011-01-05  Eric Seidel  <eric@webkit.org>
3573
3574         Unreviewed.
3575
3576         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
3577         https://bugs.webkit.org/show_bug.cgi?id=51802
3578
3579         Fix two exceptions seen on the bots after my original commit.
3580
3581         * Scripts/webkitpy/common/net/layouttestresults.py:
3582         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3583
3584 2011-01-05  Kundu Suchismita  <suchi.kundu@nokia.com>
3585
3586         Reviewed by Andreas Kling.
3587
3588         [Qt]Add local storage settings to QtTestBrowser command line arguments 
3589         https://bugs.webkit.org/show_bug.cgi?id=51750
3590
3591         * QtTestBrowser/main.cpp:
3592         (LauncherApplication::handleUserOptions):
3593          Local storage settings can be enable form command line arguments for
3594          QtTestBrowser.
3595
3596 2011-01-05  Chris Fleizach  <cfleizach@apple.com>
3597
3598         Reviewed by Martin Robinson.
3599
3600         GTK: AX: DRT needs to use correct root object method.
3601         https://bugs.webkit.org/show_bug.cgi?id=51911
3602
3603         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
3604         (AccessibilityController::rootElement):
3605
3606 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
3607
3608         Rubber-stamped by Csaba Osztrogonác.
3609
3610         Based on idea from Péter Gál.
3611
3612         * Scripts/webkitpy/tool/bot/sheriff.py: Remove unnecessary apostrophes around revision numbers.
3613
3614 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
3615
3616         Reviewed by Adam Barth.
3617
3618         sheriff-bot should be able to do multi-revision rollouts
3619         https://bugs.webkit.org/show_bug.cgi?id=51176
3620
3621         * Scripts/webkitpy/tool/bot/irc_command.py:
3622         * Scripts/webkitpy/tool/bot/sheriff.py:
3623         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
3624
3625 2011-01-05  Eric Seidel  <eric@webkit.org>
3626
3627         Reviewed by Adam Barth.
3628
3629         queues.webkit.org should have per-bot status pages
3630         https://bugs.webkit.org/show_bug.cgi?id=51906
3631
3632         Just adds a /queue-status/QUEUE_NAME/bots/BOT_ID page to show
3633         statuses from a single queue.  Now that we have many bots servicing
3634         some queues (commit-queue, win-ews, etc.) its easy to have the messages
3635         you care about scroll off the end of the 15-message limit on the main page.
3636
3637         Eventually we should probably rename /queue-status to /queue or /queues,
3638         but that's fodder for another patch.
3639
3640         * QueueStatusServer/handlers/queuestatus.py:
3641         * QueueStatusServer/index.yaml:
3642         * QueueStatusServer/main.py:
3643         * QueueStatusServer/templates/includes/singlequeuestatus.html:
3644          - This probably should use a custom filter instead of hard-coding
3645            the URL scheme here, but I couldn't figure out how to easily
3646            create such a filter.  Most filters work with "strings" so we can't
3647            pass the status object.  We could add a method to the status
3648            object and call that, but that seemed a bit strange too.
3649         * QueueStatusServer/templates/queuestatus.html:
3650
3651 2011-01-05  Carlos Garcia Campos  <cgarcia@igalia.com>
3652
3653         Unreviewed. Adding myself to the list of committers.
3654
3655         * Scripts/webkitpy/common/config/committers.py:
3656
3657 2011-01-04  Koan-Sin Tan  <koansin.tan@gmail.com>
3658
3659         Reviewed by David Levin.
3660
3661         check-webkit-style treated some macros with parentheses after #elif as function calls
3662         https://bugs.webkit.org/show_bug.cgi?id=51695
3663
3664         Ingore function call space checking in any preprocessor directives
3665         (things starting with #). Change search() to match() because 
3666         preprocessor directives are supposed to be in the beginning of lines.
3667
3668         * Scripts/webkitpy/style/checkers/cpp.py:
3669         * Scripts/webkitpy/style/checkers/cpp_unittest.py: make sure there is no false positives for #elif cases
3670
3671 2011-01-04  Søren Gjesse  <sgjesse@chromium.org>
3672
3673         Reviewed by Tony Chang.
3674
3675         Change the --multi-load test option to --stress-opt
3676         https://bugs.webkit.org/show_bug.cgi?id=50751
3677
3678         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3679         (runTest):
3680         (main):
3681         * DumpRenderTree/chromium/TestShell.cpp:
3682         (TestShell::TestShell):
3683         * DumpRenderTree/chromium/TestShell.h:
3684         (TestShell::stressOpt):
3685         (TestShell::setStressOpt):
3686         (TestShell::stressDeopt):
3687         (TestShell::setStressDeopt):
3688         (TestShell::javaScriptFlags):
3689         (TestShell::setJavaScriptFlags):
3690         * Scripts/webkitpy/layout_tests/port/chromium.py:
3691         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3692
3693 2011-01-04  Chris Fleizach  <cfleizach@apple.com>
3694
3695         Reviewed by Sam Weinig.
3696
3697         WK2: Support Accessibility
3698         https://bugs.webkit.org/show_bug.cgi?id=51859
3699
3700         Use rootObject() method to get top of accessibility tree.
3701
3702         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
3703         (AccessibilityController::focusedElement):
3704         (AccessibilityController::rootElement):
3705
3706 2011-01-03  Martin Robinson  <mrobinson@igalia.com>
3707
3708         Reviewed by Darin Adler.
3709
3710         Remove the last non-GObject usage of PlatformRefPtr and move the code to GRefPtr
3711         https://bugs.webkit.org/show_bug.cgi?id=51846
3712
3713         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: Change usage of PlatformRefPtr
3714         back to GRefPtr.
3715
3716 2011-01-04  Zhe Su  <suzhe@chromium.org>
3717
3718         Reviewed by Kenneth Russell.
3719
3720         Fix insertText, setMarkedText and unmarkText methods of
3721         TextInputController to call corresponding methods of WebKit::WebView
3722         rather than WebKit::WebFrame. This change matches the behavior of
3723         chromium browser.
3724         insertText corresponds to WebView::confirmComposition(text)
3725         setMarkedText corresponds to WebView::setComposition(...)
3726         unmarkText corresponds to WebView::confirmComposition()
3727         https://bugs.webkit.org/show_bug.cgi?id=51693
3728
3729         * DumpRenderTree/chromium/TextInputController.cpp:
3730         (TextInputController::insertText):
3731         (TextInputController::setMarkedText):
3732         (TextInputController::unmarkText):
3733
3734 2011-01-04  Dihan Wickremasuriya  <dihan.wickremasuriya@nokia.com>
3735
3736         Reviewed by Laszlo Gombos.
3737
3738         [Qt] [Symbian] Do not remove 0 byte sized files from productDir
3739
3740         On Symbian productDir points to the source directory. Removing all the
3741         empty files from the productDir directory corrupts the svn repository.
3742
3743         * Scripts/build-webkit:
3744
3745 2011-01-03  Yi Shen  <yi.4.shen@nokia.com>
3746
3747         Reviewed by Adam Barth.
3748
3749         [Qt] Add SelectAll option to the context menu for the editor
3750         https://bugs.webkit.org/show_bug.cgi?id=50049
3751
3752         Set shortcut for the SelectAll action.
3753
3754         * QtTestBrowser/mainwindow.cpp:
3755         (MainWindow::buildUI):
3756
3757 2011-01-03  David Levin  <levin@chromium.org>
3758
3759         Reviewed by Eric Seidel.
3760
3761         check-webkit-style shouldn't consider "value" automatically to be a meaningless name.
3762         https://bugs.webkit.org/show_bug.cgi?id=51842
3763
3764         * Scripts/webkitpy/style/checkers/cpp.py: Remove the check for value.
3765         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Remove the test for value.
3766
3767 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
3768
3769         Reviewed by David Kilzer.
3770
3771         [WINCE] Adds a build slave.
3772         https://bugs.webkit.org/show_bug.cgi?id=50523
3773
3774         * BuildSlaveSupport/build.webkit.org-config/config.json: Add an
3775         entry for a release build of the WinCE port.
3776         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add platform
3777         flag to build the WinCE port.
3778
3779 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
3780
3781         Reviewed by David Kilzer.
3782
3783         Add WinCE support to build-webkit
3784         https://bugs.webkit.org/show_bug.cgi?id=51642
3785
3786         * Scripts/build-webkit:
3787         * Scripts/webkitdirs.pm:
3788
3789 2011-01-03  Eric Seidel  <eric@webkit.org>
3790
3791         Reviewed by Adam Barth.
3792
3793         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
3794         https://bugs.webkit.org/show_bug.cgi?id=51802
3795
3796         I'm not the biggest fan of the test_failures or test_results classes,
3797         but it's better to have one shared set of classes, than separate ones
3798         for new vs. old run-webkit-test result handling.
3799
3800         This moves the ORWT results class "LayoutTestResults" over to using
3801         TestResult and TestFailure classes, making it easy for us to
3802         make all our sheriff-bot and other webkitpy code NRWT ready.
3803
3804         This also makes it a trivial patch to generate results.json information
3805         from ORWT results.html files (for flaky test analysis, etc.) as well
3806         as making it a one-liner to report test failure types when the
3807         commit-queue sees flaky tests.
3808
3809         This patch tried not to add new functionality, but only to replace
3810         the guts of LayoutTestResults, while adding unit tests and hoping
3811         not to break anything.
3812
3813         I also moved callers which assumed User.prompt* were static/class methods
3814         to using them as instance methods (since we'll eventually want to make them such).
3815
3816         In the process of re-writing things, I broke the rebaseline command, so I wrote
3817         a unit test to catch my breakage were I do do so again in the future.
3818
3819         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3820         * Scripts/webkitpy/common/net/layouttestresults.py:
3821         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3822         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
3823         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
3824         * Scripts/webkitpy/tool/commands/queries.py:
3825         * Scripts/webkitpy/tool/commands/rebaseline.py:
3826         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3827         * Scripts/webkitpy/tool/mocktool.py:
3828
3829 2011-01-03  Adam Barth  <abarth@webkit.org>
3830
3831         Reviewed by Simon Fraser.
3832
3833         webkit-patch shouldn't waste time cleaning a working directory that's already clean
3834         https://bugs.webkit.org/show_bug.cgi?id=51840
3835
3836         * Scripts/webkitpy/common/checkout/scm.py:
3837
3838 2011-01-03  Adam Barth  <abarth@webkit.org>
3839
3840         Reviewed by Simon Fraser.
3841
3842         webkit-patch should only hide update output if --quiet
3843         https://bugs.webkit.org/show_bug.cgi?id=51838
3844
3845         As requested by smfr.
3846
3847         * Scripts/webkitpy/tool/steps/update.py:
3848
3849 2011-01-03  Adam Barth  <abarth@webkit.org>
3850
3851         Reviewed by David Levin.
3852
3853         commit-queue shouldn't reject patches twice if two bots process the same patch
3854         https://bugs.webkit.org/show_bug.cgi?id=51805
3855
3856         Before raising an error, we first check whether the patch is still in
3857         the commit-queue.  This check is still racy, of course, but the time
3858         window is much smaller.
3859
3860         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3861
3862 2011-01-03  Sam Weinig  <sam@webkit.org>
3863
3864         Reviewed by Anders Carlsson.
3865
3866         Make run-api-tests less chatty.
3867         https://bugs.webkit.org/show_bug.cgi?id=51831
3868
3869         - Make script quiet by default and add --verbose option (replacing --quiet).
3870         - When not verbose, pipe stdout and stderr to devnull.
3871
3872         * Scripts/run-api-tests:
3873
3874 2011-01-03  Pratik Solanki  <psolanki@apple.com>
3875
3876         Unreviewed. Adding myself to committers.py.
3877
3878         * Scripts/webkitpy/common/config/committers.py:
3879
3880 2011-01-03  Koan-Sin Tan  <koansin.tan@gmail.com>
3881
3882         Reviewed by Xan Lopez.
3883
3884         "Tool/Scripts/run-launcher --gtk" stopped working after 74855
3885         https://bugs.webkit.org/show_bug.cgi?id=51806
3886
3887         Originally, the $libraryName is 'JavaScriptCore'. When building release 
3888         one, the $libraryDir was 'WebKitBuild/Release/JavaScriptCore/../.libs/'
3889         which doesn't exist anymore ('WebKitBuild/Release/JavaScriptCore'
3890         is 'WebKitBuild/Release/Source/JavaScriptCore' now), and 
3891         'WebKitBuild/Release/Source/JavaScriptCore/../../.libs' looks weird,
3892         so make it 'WebKitBuild/Release/.libs'
3893
3894         * Scripts/webkitdirs.pm: 
3895
3896 2011-01-02  Patrick Gansterer  <paroga@webkit.org>
3897
3898         Reviewed by Adam Barth.
3899
3900         Make EFL a core builder
3901         https://bugs.webkit.org/show_bug.cgi?id=51804
3902
3903         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
3904         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3905
3906 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
3907
3908         [Qt] Unreviewed fix after r74855 and r74875.
3909
3910         * BuildSlaveSupport/built-product-archive:
3911          - Create directories explicitly.
3912          - Pass shell=True to subprocess.call().
3913
3914 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
3915
3916         [Qt] Unreviewed fix after r74855.
3917
3918         Move JavaScriptCore to Source
3919         https://bugs.webkit.org/show_bug.cgi?id=51604
3920
3921         * BuildSlaveSupport/built-product-archive: JavaScriptCore -> Source/JavaScriptCore
3922
3923 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
3924
3925         [Qt] Unreviewed run-javasriptcore-tests fix after r74855.
3926
3927         Move JavaScriptCore to Source
3928         https://bugs.webkit.org/show_bug.cgi?id=51604
3929
3930         * Scripts/webkitdirs.pm:
3931
3932 2011-01-02  Robert Hogan  <robert@webkit.org>
3933
3934         Unreviewed, build fix.
3935
3936         [Qt] Fix DRT build after 74855
3937
3938         * DumpRenderTree/qt/DumpRenderTree.pro:
3939
3940 2011-01-01  Adam Barth  <abarth@webkit.org>
3941
3942         Remove the assumption from the Qt and Gtk builds that every project is
3943         in the root directory.
3944
3945         * Scripts/build-webkit:
3946
3947 2011-01-01  Adam Barth  <abarth@webkit.org>
3948
3949         Reviewed by Eric Seidel.
3950
3951         Teach svn-apply how to apply patches even though JavaScriptCore has moved
3952         https://bugs.webkit.org/show_bug.cgi?id=51796
3953
3954         After this change, svn-apply will magically apply patches to
3955         JavaScriptCore/foo to Source/JavaScriptCore/foo.
3956
3957         * Scripts/VCSUtils.pm:
3958
3959 2011-01-01  Adam Barth  <abarth@webkit.org>
3960
3961         Reviewed by Eric Seidel.
3962
3963         Move JavaScriptCore to Source
3964         https://bugs.webkit.org/show_bug.cgi?id=51604
3965
3966         Update references to JavaScriptCore to point to the new location.
3967
3968         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3969         * DumpRenderTree/qt/DumpRenderTree.pro:
3970         * DumpRenderTree/qt/ImageDiff.pro:
3971         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3972         * DumpRenderTree/wscript:
3973         * Scripts/build-jsc:
3974         * Scripts/build-webkit:
3975         * Scripts/do-file-rename:
3976         * Scripts/do-webcore-rename:
3977         * Scripts/run-javascriptcore-tests:
3978         * Scripts/update-javascriptcore-test-results:
3979         * Scripts/webkitdirs.pm:
3980         * Scripts/webkitpy/common/config/build_unittest.py:
3981         * Scripts/webkitpy/style/checker.py:
3982         * Scripts/webkitpy/style/checker_unittest.py:
3983         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3984         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3985         * WebKitTestRunner/qt/WebKitTestRunner.pro:
3986         * wx/build/settings.py:
3987
3988 2011-01-01  Adam Barth  <abarth@webkit.org>
3989
3990         Reviewed by Eric Seidel.
3991
3992         Move Sources to Source
3993         https://bugs.webkit.org/show_bug.cgi?id=51794
3994
3995         Update scripts to point to the new location.
3996
3997         * Scripts/build-webkit:
3998         * Scripts/do-file-rename:
3999         * Scripts/do-webcore-rename:
4000         * Scripts/webkitpy/common/config/build.py:
4001         * Scripts/webkitpy/common/config/build_unittest.py:
4002
4003 2010-12-31  Kent Tamura  <tkent@chromium.org>
4004
4005         Reviewed by Eric Seidel.
4006
4007         [DRT/Chromium] Enable mock spell checker on non-OSX
4008         https://bugs.webkit.org/show_bug.cgi?id=51401
4009
4010         * DumpRenderTree/chromium/WebViewHost.cpp:
4011         (WebViewHost::spellCheck):
4012
4013 2010-12-31  Adam Barth  <abarth@webkit.org>
4014
4015         Reviewed by Ariya Hidayat.
4016
4017         Remove Tools/Scripts/wkstyle
4018         https://bugs.webkit.org/show_bug.cgi?id=51774
4019
4020         This script appears to not have been touched in a while and seems to
4021         have been replaced by check-webkit-style.
4022
4023         * Scripts/wkstyle: Removed.
4024
4025 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
4026
4027         Unreviewed. Coding style fix.
4028
4029         * DumpRenderTree/chromium/TestShell.h:
4030
4031 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
4032
4033         Reviewed by Pavel Feldman.
4034
4035         Web Inspector: [Chromium] Inspector's tests are very slow on Win(Dbg).
4036
4037         It was a problem with Chromium DRT. DevToolsAgent object instance was
4038         attached not only to the inspected page but to the DevTools window too.
4039         As result all the inspector files were interpreted as a content of inspected page
4040         and were transfered to the DevTools scripts panel for debugging etc.
4041
4042         https://bugs.webkit.org/show_bug.cgi?id=51735
4043
4044         * DumpRenderTree/chromium/TestShell.cpp:
4045         (TestShell::TestShell):
4046         (TestShell::bindJSObjectsToWindow):
4047         (TestShell::createNewWindow):
4048         * DumpRenderTree/chromium/TestShell.h:
4049
4050 2010-12-31  Adam Barth  <abarth@webkit.org>
4051
4052         Rubber-stamped by Eric Seidel.
4053
4054         Move PageLoadTests to PerformanceTests/PageLoad
4055         https://bugs.webkit.org/show_bug.cgi?id=51771
4056
4057         Update references to PageLoadTests to point to the new location.
4058
4059         * Scripts/run-pageloadtest:
4060         * Scripts/webkitpy/common/config/build.py:
4061
4062 2010-12-31  Adam Barth  <abarth@webkit.org>
4063
4064         Rubber-stamped by Eric Seidel.
4065
4066         Move SunSpider into PerformanceTests
4067         https://bugs.webkit.org/show_bug.cgi?id=51769
4068
4069         Update these scripts to point to the new location.
4070
4071         * Scripts/run-sunspider:
4072         * Scripts/sunspider-compare-results:
4073
4074 2010-12-30  Mihai Parparita  <mihaip@chromium.org>
4075
4076         Reviewed by Kent Tamura.
4077
4078         [Chromium] Add WebThemeEngineDRTMac so that Chromium DRT scrollbar rendering can match the Mac port's
4079         https://bugs.webkit.org/show_bug.cgi?id=51728
4080         
4081         Add implementation of the Mac WebThemeEngine that uses an NSScroller
4082         to render top-level scrollbars. This makes them match the Mac port's
4083         use of an NSScrollView, which means that we'll be able to share more
4084         pixel baselines.
4085         
4086         The new rendering code will not be activated until the 
4087         USE_WEB_THEME_ENGINE_TO_PAINT_THUMB #define is fliped in
4088         ScrollbarThemeChromiumMac.
4089
4090         * DumpRenderTree/DumpRenderTree.gypi:
4091         * DumpRenderTree/chromium/TestShellMac.mm:
4092         (platformInit):
4093         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Added.
4094         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Added.
4095         (+[FakeActiveWindow alwaysActiveWindow]):
4096         (+[FakeActiveWindow alwaysInactiveWindow]):
4097         (-[FakeActiveWindow initWithActiveControls:]):
4098         (-[FakeActiveWindow _hasActiveControls]):
4099         (WebThemeEngineDRTMac::paintScrollbarThumb):
4100         (stateToHIEnableState):
4101         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
4102         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
4103
4104 2010-12-30  Konstantin Tokarev  <annulen@yandex.ru>
4105
4106         Reviewed by David Kilzer.
4107
4108         [Qt] Don't build wtf/TCSystemAlloc.cpp if --system-malloc option is
4109         used
4110         https://bugs.webkit.org/show_bug.cgi?id=51672
4111
4112         * DumpRenderTree/qt/DumpRenderTree.pro: Replaced USE_SYSTEM_MALLOC
4113         with USE_SYSTEM_MALLOC=1
4114         * WebKitTestRunner/qt/WebKitTestRunner.pro: Replaced USE_SYSTEM_MALLOC
4115         with USE_SYSTEM_MALLOC=1
4116
4117 2010-12-30  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
4118
4119         Reviewed by David Kilzer.
4120
4121         [Qt] [Symbian] Fix build-webkit script for Symbian
4122         https://bugs.webkit.org/show_bug.cgi?id=51509
4123
4124         Set the OUTPUT_DIR for Symbian to be the same as the source
4125         directory.
4126
4127         * Scripts/webkitdirs.pm:
4128
4129 2010-12-30  Martin Robinson  <mrobinson@igalia.com>
4130
4131         Reviewed by Darin Adler.
4132
4133         check-webkit-style should ignore NULL usage in calls to gtk_widget_style_get
4134         https://bugs.webkit.org/show_bug.cgi?id=51758
4135
4136         Add a check-webkit-style exception for gtk_widget_style_get and NULL usage.
4137
4138         * Scripts/webkitpy/style/checkers/cpp.py: Add the exception.
4139         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Add some tests for this.
4140
4141 2010-12-29  Patrick Gansterer  <paroga@webkit.org>
4142
4143         Unreviewed WinCE buildfix.
4144
4145         * WinCELauncher/main.cpp: Add missing include.
4146
4147 2010-12-29  Daniel Bates  <dbates@rim.com>
4148
4149         Reviewed by Darin Adler.
4150
4151         svn-apply updates date of wrong change log entry for a change log diff that
4152         contains two consecutive entries with the same author and date
4153         https://bugs.webkit.org/show_bug.cgi?id=46061
4154
4155         Fixes an issue where the date of the wrong change log entry may be modified.
4156         Moreover, changes fixChangeLogPatch() to move entries inserted earlier
4157         in a ChangeLog file to the top of the file.
4158
4159         Currently, fixChangeLogPatch() explicitly bails out and returns an unchanged
4160         diff when it detects that the diff inserts a change log entry earlier in a
4161         ChangeLog. It is unusual to land a patch that has such a deliberate ChangeLog
4162         change. With the advent of the commit-queue this functionality of bailing out
4163         and hence landing the patch as-is is harmful to the accuracy of the ChangeLog.
4164         Instead, we should always move the change log entry to the top of the ChangeLog file.
4165
4166         A side-effect of this change is that setChangeLogDateAndReviewer() now updates
4167         the date line of the correct change log entry in a ChangeLog diff.
4168
4169         * Scripts/VCSUtils.pm: Modified fixChangeLogPatch() to move entries inserted earlier to the top.
4170
4171         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
4172           Updated the following unit tests now that we move entries inserted earlier to the top:
4173           - "fixChangeLogPatch: New entry inserted in middle."
4174             (formerly named "fixChangeLogPatch: [no change] New entry inserted in middle.")
4175
4176           - "fixChangeLogPatch: New entry inserted earlier in the file, but after an entry with the same author and date."
4177             (formerly named "fixChangeLogPatch: [no change] New entry inserted earlier in the file, but after an entry with the same author and date.")
4178
4179         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatchThenSetChangeLogDateAndReviewer.pl: Added.
4180
4181 2010-12-29  Konstantin Tokarev  <annulen@yandex.ru>
4182
4183         Reviewed by Eric Seidel.
4184
4185         [Qt] Fixed compatibility with gold linker on X11 platforms
4186         https://bugs.webkit.org/show_bug.cgi?id=51700
4187
4188         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
4189         Linked TestNetscapePlugin with libX11 on Unix platforms
4190
4191 2010-12-29  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>
4192
4193         Reviewed by Darin Adler.
4194
4195         Circular dependency in webkitpy.common.checkout.changelog module
4196         https://bugs.webkit.org/show_bug.cgi?id=50475
4197
4198         Remove automatic import of api.Checkout module when any checkout/
4199         submodule is imported (e.g.: when checkout.scm.Git is imported).
4200
4201         * Scripts/webkitpy/common/checkout/__init__.py:
4202
4203 2010-12-29  Martin Robinson  <mrobinson@igalia.com>
4204
4205         Reviewed by Ojan Vafai.
4206
4207         prepare-ChangeLog should support the -g option for specifying the git-commit
4208         https://bugs.webkit.org/show_bug.cgi?id=51708
4209
4210         Add a -g shortcut for the --git-commit prepare-ChangeLog option. This matches
4211         webkit-patch, though the exact meaning of the two options remain different.
4212
4213         * Scripts/prepare-ChangeLog: Add -g.
4214
4215 2010-12-29  Kent Hansen  <kent.hansen@nokia.com>
4216
4217         Reviewed by Simon Hausmann.
4218
4219         [Qt] Fix compilation with Qt in namespace
4220         https://bugs.webkit.org/show_bug.cgi?id=51701
4221
4222         * QtTestBrowser/webview.h:
4223
4224 2010-12-28  Daniel Bates  <dbates@rim.com>
4225
4226         Reviewed by Sam Weinig.
4227
4228         Substitute // MARK: for compiler-specific #pragma mark
4229         https://bugs.webkit.org/show_bug.cgi?id=51657
4230
4231         Fix future compilation warnings about "#pragma mark" on GTK+ bots by
4232         substituting  "// MARK:" for "#pragma mark", which provides
4233         analogous code-bookmarking functionality under Xcode.
4234
4235         Also, for consistency, we should substitute "// MARK:" for compiler-
4236         specific "#pragma mark" in the source files for the Mac port.
4237
4238         * DumpRenderTree/AccessibilityTextMarker.cpp:
4239         * DumpRenderTree/cf/WebArchiveDumpSupport.h:
4240         * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm:
4241         * DumpRenderTree/mac/ObjCController.m:
4242         * MiniBrowser/mac/AppDelegate.m:
4243         * MiniBrowser/mac/BrowserWindowController.m:
4244
4245 2010-12-28  Xan Lopez  <xlopez@igalia.com>
4246
4247         Reviewed by Eric Seidel.
4248
4249         Add --no-build option to run-sunspider
4250         https://bugs.webkit.org/show_bug.cgi?id=51658
4251
4252         * Scripts/run-sunspider: add --no-build flag to skip building
4253         phase.
4254
4255 2010-12-27  Daniel Bates  <dbates@rim.com>
4256
4257         Rubber-stamped by Martin Robinson.
4258
4259         Append the directory Tools/DumpRenderTree to the list of directories that
4260         do-webcore-rename should search so that it can rename DRT files and
4261         source code.
4262
4263         * Scripts/do-webcore-rename:
4264
4265 2010-12-27  Eric Seidel  <eric@webkit.org>
4266
4267         Reviewed by Adam Barth.
4268
4269         build-webkit should detect missing Java SDK and explain how to install it
4270         https://bugs.webkit.org/show_bug.cgi?id=51651
4271
4272         * Scripts/build-webkit:
4273
4274 2010-12-26  Martin Robinson  <mrobinson@igalia.com>
4275
4276         Reviewed by Daniel Bates.
4277
4278         [GTK] Add support for build-jsc
4279         https://bugs.webkit.org/show_bug.cgi?id=51625
4280
4281         Add GTK+ support to build-jsc now that building the jsc executable as
4282         a standalone target is easy.
4283
4284         * Scripts/build-jsc: Call buildGtkProject for the GTK+ case now.
4285         * Scripts/build-webkit: Pass in the proper target name to buildGtkProject.
4286         * Scripts/webkitdirs.pm: Actually process the project parameter in buildGtkProject
4287         and pass it along to buildAutotoolsProject.
4288
4289 2010-12-27  David Levin  <levin@chromium.org>
4290
4291         Reviewed by Eric Seidel.
4292
4293         check-webkit-style check for meaningless variable names in function declarations.
4294         https://bugs.webkit.org/show_bug.cgi?id=51523
4295
4296         * Scripts/webkitpy/style/checker.py: Exempted JavaScriptCore/jit/JITStubs.cpp
4297         from the new check and whitespace/parens because the syntax is unusual and
4298         produced a fair number of positives for these checks.
4299         * Scripts/webkitpy/style/checkers/cpp.py:
4300         (_convert_to_lower_with_underscores): Used as a canonical form for type names
4301         and parameter names when determining if the parameter name is useless.
4302         (_create_acronym): Used to check for redundant variable names in cases like "ExceptionCode ec"
4303         (Parameter.lower_with_underscores_name): Gives back the parameter name in a lower_with_underscore
4304         format.
4305         (_check_parameter_name_against_text):  Checks to see if the parameter name is in the
4306         text or an acronym of it.
4307         (check_function_definition): Checks function definitions for meaningless variable names.
4308         (process_line): Added call to check_function_definition.
4309         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
4310         (CppFunctionsTest.test_convert_to_lower_with_underscores): Test for _convert_to_lower_with_underscores.
4311         (CppFunctionsTest.test_create_acronym): Test for _create_acronym.
4312         (CppFunctionsTest.test_check_parameter_against_text): Test for _check_parameter_against_text.
4313         (CppStyleTestBase.perform_single_line_lint): Removed the parameter name check
4314         because when only checking a snippet, there are a lot of bogus functions.
4315         (CppStyleTestBase.perform_multi_line_lint): Ditto and removed a bogus filter
4316         that I put there previously and just noticed.
4317         (WebKitStyleTest.test_parameter_names): Tests for the functionality -- both
4318         check_function_definition and process_line.
4319
4320 2010-12-27  Carlos Garcia Campos  <cgarcia@igalia.com>
4321
4322         Reviewed by Martin Robinson.
4323
4324         [GTK] Disable flash plugin in GtkLauncher when using gtk3
4325         https://bugs.webkit.org/show_bug.cgi?id=51591
4326
4327         Flash plugin uses gtk2 that is incompatible with gtk3 making
4328         webkit crash when it's built with gtk3.
4329
4330         * GtkLauncher/main.c:
4331         (main):
4332
4333 2010-12-25  Adam Barth  <abarth@webkit.org>
4334
4335         Reviewed by Eric Seidel.
4336
4337         Move ANGLE to Sources/ThirdParty
4338         https://bugs.webkit.org/show_bug.cgi?id=51605
4339
4340         * Scripts/build-webkit:
4341           - Point to the new ANGLE location.
4342
4343 2010-12-26  David Levin  <levin@chromium.org>
4344
4345         Reviewed by Eric Seidel.
4346
4347         check-webkit-style should be able to parse function declaration parameters.
4348         https://bugs.webkit.org/show_bug.cgi?id=51451
4349
4350         * Scripts/webkitpy/style/checkers/cpp.py:
4351         (Position.__init__): Holds simple position information (row, column).
4352         (Parameter.__init__): Holds information about a parameter.
4353         (SingleLineView.__init): Converts multiple lines into a single line for simpler searches.
4354         (SingleLineView.convert_column_to_row): Returns the original row given a column.
4355         (create_skeleton_parameters): Simplifies a parameter list for easier searching.
4356         (find_parameter_name_index): Finds where the parameter name is.
4357         (parameter_list): Generates the list of parameters for a function.
4358         (_FunctionState.begin): Added information to allow determining the parameters
4359         on demand.
4360         (_FunctionState.get_parameter_list): Returns a tuple of function parameters.
4361         (detect_functions): Improve function detection for operator functions and
4362         determine where the parameters end and pass that to _FunctionState.begin.
4363         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
4364         (CppFunctionsTest.test_parameter): Verifies Parameter functionality.
4365         (CppFunctionsTest.test_single_line_view): Verifies SingleLineView functionality.
4366         (CppFunctionsTest.test_create_skeleton_parameters): Verifies create_skeleton_parameters.
4367         (CppFunctionsTest.test_find_parameter_name_index): Verifies find_parameter_name_index.
4368         (CppFunctionsTest.test_parameter_list): Does some minimal verification for parameter list.
4369         Much more thorough verification is done as part of FunctionDetectionTest.test_parameter_list.
4370         (FunctionDetectionTest.perform_function_detection): Added support for verifying
4371         the parameters found.
4372         (FunctionDetectionTest.test_function_declaration_detection): Added more function
4373         detection test to verify that we catch the operator functions.
4374         (FunctionDetectionTest.test_ignore_macros): Verify that function detection ignores macros.
4375         (FunctionDetectionTest.test_parameter_list): Added tests to verify the parameter parsing.
4376         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_bad_test_doesnt_break): Removed
4377         because the error. The test is about the bad function name. Fixing the name makes the test exactly like
4378         test_function_length_check_definition_severity1_for_test.
4379
4380 2010-12-25  Patrick Gansterer  <paroga@webkit.org>
4381
4382         Unreviewed WinCE buildfix after r74334.
4383
4384         * CMakeListsWinCE.txt:
4385
4386 2010-12-24  Sheriff Bot  <webkit.review.bot@gmail.com>
4387
4388         Unreviewed, rolling out r74632.
4389         http://trac.webkit.org/changeset/74632
4390         https://bugs.webkit.org/show_bug.cgi?id=51600
4391
4392         makes test-webkitpy hang forever on GTK (Requested by philn-tp
4393         on #webkit).
4394
4395         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
4396         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
4397
4398 2010-12-24  Ryuan Choi  <ryuan.choi@samsung.com>
4399
4400         Reviewed by Kenneth Rohde Christiansen.
4401
4402         [EFL] Screen doesn't be rendered when changing size of EWebLauncher
4403         https://bugs.webkit.org/show_bug.cgi?id=43528
4404
4405         Remove on_resize because ewk_view_fixed_layout_size_set should not be
4406         called on callback of EVAS_CALLBACK_RESIZE. As it change size of
4407         FrameView, rendering was ignored when _ewk_view_smart_calculate was
4408         called.
4409
4410         * EWebLauncher/main.c:
4411         (browserCreate):
4412
4413 2010-12-24  Eric Seidel  <eric@webkit.org>
4414
4415         Reviewed by Adam Barth.
4416
4417         webkit-patch (or a pre-commit hook) needs to prevent bad ChangeLog changes
4418         https://bugs.webkit.org/show_bug.cgi?id=28291
4419
4420         This is a start.  At least now webkit-patch will prompt when your ChangeLog looks questionable.
4421         We could do more advanced things, like parsing the ChangeLog (with changelog.py) and comparing that
4422         to strings with find in the diff.
4423         Since non-interactive always returns the default, this should cause patches with bad changelogs to fail on the commit-queue.
4424
4425         * Scripts/webkitpy/common/checkout/api.py:
4426         * Scripts/webkitpy/common/checkout/diff_parser.py:
4427         * Scripts/webkitpy/tool/steps/abstractstep.py:
4428         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
4429         * Scripts/webkitpy/tool/steps/validatechangelogs.py: Copied from Tools/Scripts/webkitpy/tool/steps/validatereviewer.py.
4430         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py: Copied from Tools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.
4431         * Scripts/webkitpy/tool/steps/validatereviewer.py:
4432
4433 2010-12-24  Dirk Pranke  <dpranke@chromium.org>
4434
4435         Reviewed by Kenneth Russell.
4436
4437         Modify new-run-webkit-tests to shut up and exit when all the threads
4438         are wedged so that test runs complete faster and we don't end up
4439         w/ enormous log files.
4440
4441         https://bugs.webkit.org/show_bug.cgi?id=51572
4442
4443         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
4444         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
4445
4446 2010-12-24  Eric Seidel  <eric@webkit.org>
4447
4448         Reviewed by David Levin.
4449
4450         commit-queue should better explain how it will re-open bugs and follow duplicate chains
4451         https://bugs.webkit.org/show_bug.cgi?id=51549
4452
4453         I've had multiple people ask me about the commit-queue's behavior
4454         regarding reporting flaky tests.  I figured it would be best to just
4455         have the queue explain itself in the bugs it files.
4456
4457         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
4458         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
4459
4460 2010-12-24  Shinichiro Hamaji  <hamaji@chromium.org>
4461
4462         Reviewed by Eric Seidel.
4463
4464         check-webkit-style: should ignore "wrong" namings in JavaScriptCore/qt
4465         https://bugs.webkit.org/show_bug.cgi?id=51467
4466
4467         * Scripts/webkitpy/style/checker.py:
4468         * Scripts/webkitpy/style/checker_unittest.py:
4469
4470 2010-12-23  Adam Barth  <abarth@webkit.org>
4471
4472         Rubber-stamped by Eric Seidel.
4473
4474         Move JavaScriptGlue into Sources
4475         https://bugs.webkit.org/show_bug.cgi?id=51583
4476
4477         These tools refer to JavaScriptGlue and need to be updated to its new
4478         location.
4479
4480         * Scripts/build-webkit:
4481         * Scripts/do-file-rename:
4482         * Scripts/do-webcore-rename:
4483         * Scripts/webkitpy/common/config/build.py:
4484         * Scripts/webkitpy/common/config/build_unittest.py:
4485
4486 2010-12-23  Lucas Forschler  <lforschler@apple.com>
4487
4488         Reviewed by Eric Seidel.
4489
4490         Bug 51539 - update iexploder scripts to point to new location
4491
4492         * Scripts/run-iexploder-tests:
4493         * Scripts/update-iexploder-cssproperties:
4494
4495 2010-12-23  Evan Martin  <evan@chromium.org>
4496
4497</