9e83431c83986a2886d32c1dda33fb5eeb8a4312
[WebKit.git] / Tools / ChangeLog
1 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
2
3         Reviewed by Sam Weinig.
4
5         WebKitTestRunner should track loading more like DumpRenderTree
6         https://bugs.webkit.org/show_bug.cgi?id=52692
7
8         Change load tracking to track the current top loading frame, in the manner of DumpRenderTree.
9         This makes some tests that call notifyDone multiple times pass.
10         
11         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
12         (WTR::InjectedBundle::InjectedBundle):
13         (WTR::InjectedBundle::done):
14         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
15         (WTR::InjectedBundle::topLoadingFrame):
16         (WTR::InjectedBundle::setTopLoadingFrame):
17         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
18         (WTR::InjectedBundlePage::InjectedBundlePage):
19         (WTR::InjectedBundlePage::stopLoading):
20         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
21         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
22         (WTR::InjectedBundlePage::didFinishLoadForFrame):
23         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
24         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
25         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
26         (WTR::LayoutTestController::notifyDone):
27         * WebKitTestRunner/TestController.cpp:
28         (WTR::TestController::didReceiveMessageFromInjectedBundle):
29
30 2011-01-18  Mihai Parparita  <mihaip@chromium.org>
31
32         Reviewed by Kent Tamura.
33
34         [Chromium] NRWT looking for DRT binary in the wrong path on Mac
35         https://bugs.webkit.org/show_bug.cgi?id=52678
36         
37         Update path now that WebKit is inside Source.
38
39         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
40
41 2011-01-18  Robert Hogan  <robert@webkit.org>
42
43         Reviewed by Simon Hausmann.
44
45         [Qt] http/tests/incremental/slow-utf8-text.pl fails
46         https://bugs.webkit.org/show_bug.cgi?id=44282
47
48         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
49         (WebCore::DumpRenderTree::dump):
50
51 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
52
53         Reviewed by Mihai Parparita.
54
55         Fix a small race condition that could cause the unit tests for
56         new-run-webkit-tests to fail in a multithreaded environment.
57         There was a small window in the code where one thread would
58         check to see if a thread had raised an exception, do something,
59         and then check to see if the thread was alive. If the other
60         thread raised an exception and exited in between these two
61         steps, the exception would be lost. Flipping the order of the
62         two checks fixes the race, since we will now always check for an
63         exception on the thread before exiting.
64
65         https://bugs.webkit.org/show_bug.cgi?id=51579
66
67         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
68
69 2011-01-18  Eric Seidel  <eric@webkit.org>
70
71         Reviewed by Adam Barth.
72
73         commit-queue dies when test archiving fails
74         https://bugs.webkit.org/show_bug.cgi?id=52617
75
76         I looked at the machine and it had 10 archives already
77         thus find_unused_name was returning None.  I've upped
78         the limit to 100 (per bug) and tested the case where
79         find_unused_name returns None (making archive return None).
80
81         * Scripts/webkitpy/common/system/workspace.py:
82         * Scripts/webkitpy/common/system/workspace_unittest.py:
83         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
84         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
85         * Scripts/webkitpy/tool/commands/queues.py:
86
87 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
88
89         Reviewed by Ojan Vafai.
90
91         Update rebaseline-chromium-webkit-tests unit tests to use a mock
92         filesystem. Also fix a couple of "with" statements missed by
93         r76050.
94
95         https://bugs.webkit.org/show_bug.cgi?id=52487
96
97         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
98
99 2011-01-18  Sergio Villar Senin  <svillar@igalia.com>
100
101         Reviewed by Martin Robinson.
102
103         [Gtk] Build fixes for gtk3 build
104         https://bugs.webkit.org/show_bug.cgi?id=52648
105
106         * DumpRenderTree/gtk/EventSender.cpp:
107         (beginDragWithFilesCallback):
108
109 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
110
111         Reviewed by Mihai Parparita.
112
113         Update rebaseline-chromium-webkit-tests to use filesystem objects
114         instead of direct references to os.path, shutil, tempfile, etc.
115
116         This patch doesn't change anything, but will allow subsequent
117         patches to change the unit tests to no longer use the real
118         filesystem.
119
120         This patch adds a bunch more methods to the filesystem object as
121         well.
122
123         https://bugs.webkit.org/show_bug.cgi?id=52482
124
125         * Scripts/webkitpy/common/system/filesystem.py:
126         * Scripts/webkitpy/common/system/filesystem_mock.py:
127         * Scripts/webkitpy/tool/commands/queues.py:
128         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
129         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
130
131 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
132
133         Reviewed by Mihai Parparita.
134
135         new-run-webkit-tests shouldn't crash when you try to run a
136         directory containing only skipped files.
137
138         https://bugs.webkit.org/show_bug.cgi?id=52478
139         
140         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
141         * Scripts/webkitpy/layout_tests/port/test.py:
142         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
143
144 2011-01-18  Adam Bergkvist  <adam.bergkvist@ericsson.com> and Martin Robinson  <mrobinson@igalia.com>
145
146         Reviewed by Gustavo Noronha Silva.
147
148         [GTK] The GTK+ EventSender needs support for beginDragWithFiles
149         https://bugs.webkit.org/show_bug.cgi?id=40833
150
151         * DumpRenderTree/gtk/EventSender.cpp: Add a beginDragWithFiles implementation for the
152         GTK+ event sender.
153         (dragWithFilesDragDataGetCallback): Added.
154         (dragWithFilesDragEndCallback): Added.
155         (beginDragWithFilesCallback): Added.
156
157 2011-01-18  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
158
159         Reviewed by Adam Barth.
160
161         ews: Add additional watcher to efl ews
162         https://bugs.webkit.org/show_bug.cgi?id=52613
163
164         Add gyuyoung.kim@samsung.com to watcher list of efl-ews.
165
166         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
167
168 2011-01-17  Tony Gentilcore  <tonyg@chromium.org>
169
170         Reviewed by Alexey Proskuryakov.
171
172         Fix some headers with missing or misspelled #ifndef guards
173         https://bugs.webkit.org/show_bug.cgi?id=52545
174
175         * DumpRenderTree/chromium/TestEventPrinter.h:
176         * DumpRenderTree/chromium/WebPreferences.h:
177
178 2011-01-17  Jessie Berlin  <jberlin@apple.com>
179
180         Reviewed by Anders Carlsson.
181
182         REGRESSION: Assertion failure in FrameLoader::continueLoadAfterWillSubmitForm() when
183         navigating back to an unreachable URL
184         https://bugs.webkit.org/show_bug.cgi?id=52388
185
186         Add a third parameter (unreachableURL) to queueLoadHTMLString.
187
188         * DumpRenderTree/LayoutTestController.cpp:
189         (queueLoadHTMLStringCallback):
190         (LayoutTestController::queueLoadHTMLString):
191         (LayoutTestController::queueLoadAlternateHTMLString):
192         * DumpRenderTree/LayoutTestController.h:
193
194         * DumpRenderTree/WorkQueueItem.h:
195         (LoadHTMLStringItem::LoadHTMLStringItem):
196
197         * DumpRenderTree/chromium/LayoutTestController.cpp:
198         (WorkItemLoadHTMLString::WorkItemLoadHTMLString):
199         (WorkItemLoadHTMLString::run):
200         (LayoutTestController::queueLoadHTMLString):
201
202         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
203         (LoadHTMLStringItem::invoke):
204         * DumpRenderTree/mac/WorkQueueItemMac.mm:
205         (LoadHTMLStringItem::invoke):
206         * DumpRenderTree/win/WorkQueueItemWin.cpp:
207         (LoadHTMLStringItem::invoke):
208
209 2011-01-17  Dan Bernstein  <mitz@apple.com>
210
211         Rubber-stamped by Mark Rowe.
212
213         Update xcodeproj svn:ignore to include xcuserdata.
214
215         * DumpRenderTree/DumpRenderTree.xcodeproj: Modified property svn:ignore.
216         * MiniBrowser/MiniBrowser.xcodeproj: Modified property svn:ignore.
217         * TestWebKitAPI/TestWebKitAPI.xcodeproj: Modified property svn:ignore.
218         * WebKitLauncher/WebKitLauncher.xcodeproj: Modified property svn:ignore.
219         * WebKitTestRunner/WebKitTestRunner.xcodeproj: Modified property svn:ignore.
220
221 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
222
223         Unreviewed fix after r75908.
224
225         Move WebKit into Source
226         https://bugs.webkit.org/show_bug.cgi?id=52530
227
228         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add Source to the path for Qt API tests.
229
230 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
231
232         Unreviewed.
233
234         Remove accidentally committed debug printing after r75908.
235
236         * Scripts/webkitdirs.pm:
237
238 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
239
240         Unreviewed.
241
242         Add myself to committers list
243         https://bugs.webkit.org/show_bug.cgi?id=52566
244
245         * Scripts/webkitpy/common/config/committers.py:
246
247 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
248
249         Reviewed by Jeremy Orlow.
250
251         GeolocationController should call stopUpdating on destruction
252         https://bugs.webkit.org/show_bug.cgi?id=52216
253
254         fast/dom/Geolocation/window-close-crash.html requires that a
255         Geolocation watch be started in a secondary window. Consequently,
256         we need to allow geolocation permission and provide a mock
257         geolocation position for the secondary window's
258         GeolocationClientMock.
259
260         * DumpRenderTree/chromium/LayoutTestController.cpp:
261         (LayoutTestController::setGeolocationPermission):
262         (LayoutTestController::setMockGeolocationPosition):
263         (LayoutTestController::setMockGeolocationError):
264         * DumpRenderTree/chromium/TestShell.h:
265         (TestShell::windowList):
266
267 2011-01-16  Adam Barth  <abarth@webkit.org>
268
269         Update more include paths to reflect WebKit move.
270
271         * DumpRenderTree/chromium/EventSender.cpp:
272         (EventSender::keyDown):
273         (EventSender::needsShiftModifier):
274         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
275         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
276
277 2011-01-16  Kent Tamura  <tkent@chromium.org>
278
279         Unreviewed, Chromium build fix.
280
281         * Scripts/update-webkit-chromium: Webkit/chromium -> Source/WebKit/chromium
282
283 2011-01-16  Martin Robinson  <mrobinson@igalia.com>
284
285         Build fix for GTK+ after source directory movement.
286
287         * GNUmakefile.am: Correct include paths.
288
289 2011-01-16  Adam Barth  <abarth@webkit.org>
290
291         Teach svn-apply about WebKit move.
292
293         * Scripts/VCSUtils.pm:
294
295 2011-01-16  Adam Barth  <abarth@webkit.org>
296
297         Rubber-stamped by Eric Seidel.
298
299         Move WebKit into Source
300         https://bugs.webkit.org/show_bug.cgi?id=52530
301
302         * DumpRenderTree/mac/InternalHeaders/WebKit/WebTypesInternal.h:
303         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
304         * DumpRenderTree/qt/DumpRenderTreeQt.h:
305         * DumpRenderTree/qt/GCControllerQt.cpp:
306         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
307         * DumpRenderTree/qt/PlainTextControllerQt.cpp:
308         * DumpRenderTree/qt/TextInputControllerQt.cpp:
309         * DumpRenderTree/wscript:
310         * QtTestBrowser/launcherwindow.h:
311         * Scripts/build-webkit:
312         * Scripts/webkitdirs.pm:
313
314 2011-01-15  Adam Barth  <abarth@webkit.org>
315
316         Teach svn-apply about WebKit2 move.
317
318         * Scripts/VCSUtils.pm:
319
320 2011-01-15  Adam Barth  <abarth@webkit.org>
321
322         Rubber-stamped by Eric Seidel.
323
324         Move WebKit2 into Source
325         https://bugs.webkit.org/show_bug.cgi?id=52438
326
327         * MiniBrowser/qt/MiniBrowser.pro:
328         * Scripts/build-webkit:
329         * Scripts/do-file-rename:
330         * Scripts/do-webcore-rename:
331         * Scripts/test-webkitpy:
332         * Scripts/webkitdirs.pm:
333         * Scripts/webkitpy/style/checker.py:
334         * WebKitTestRunner/DerivedSources.pro:
335         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
336         * WebKitTestRunner/qt/WebKitTestRunner.pro:
337
338 2011-01-15  Jochen Eisinger  <jochen@chromium.org>
339
340         Reviewed by David Levin.
341
342         [chromium] remove obsolete createView method
343         https://bugs.webkit.org/show_bug.cgi?id=52437
344
345         * DumpRenderTree/chromium/WebViewHost.cpp:
346         (WebViewHost::createView):
347         * DumpRenderTree/chromium/WebViewHost.h:
348
349 2011-01-14  Brian Weinstein  <bweinstein@apple.com>
350
351         Reviewed by Geoff Garen.
352
353         ShouldLoadResourceForFrame should use strings, not URLs.
354         https://bugs.webkit.org/show_bug.cgi?id=52476
355
356         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
357         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Update to use a WKStringRef.
358         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
359
360 2011-01-14  Tony Gentilcore  <tonyg@chromium.org>
361
362         Reviewed by David Levin.
363
364         Add Tony Gentilcore as a reviewer
365         https://bugs.webkit.org/show_bug.cgi?id=52480
366
367         * Scripts/webkitpy/common/config/committers.py:
368
369 2011-01-14  David Levin  <levin@chromium.org>
370
371         Reviewed by Eric Seidel.
372
373         check-webkit-style: _FunctionState should keep track of where the function name starts.
374         https://bugs.webkit.org/show_bug.cgi?id=52454
375
376         * Scripts/webkitpy/style/checkers/cpp.py: Added function_name_start_position to
377         _FunctionState and logic for setting it correctly.
378         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests.
379
380 2011-01-14  Vincent Scheib  <scheib@chromium.org>
381
382         Reviewed by David Levin.
383
384         Add support to DumpRenderTree to use the GPU rather than software renderer
385         https://bugs.webkit.org/show_bug.cgi?id=52333
386
387         * DumpRenderTree/chromium/DumpRenderTree.cpp:
388         (main):
389         * Scripts/webkitpy/layout_tests/port/chromium.py:
390         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
391
392 2011-01-14  Tony Chang  <tony@chromium.org>
393
394         Reviewed by Kent Tamura.
395
396         [chromium] update fonts.conf to fix 6 linux tests in drt
397         https://bugs.webkit.org/show_bug.cgi?id=52411
398
399         * DumpRenderTree/chromium/fonts.conf: Update to match the copy in
400             chromium's src/webkit/tools/test_shell/resources/fonts.conf
401
402 2011-01-14  Eric Seidel  <eric@webkit.org>
403
404         Original patch from Peter Gal  <galpater@inf.u-szeged.hu>
405
406         Reviewed by Adam Barth.
407
408         Fix when running Tools/Scripts/check-webkit-style without arguments.
409         https://bugs.webkit.org/show_bug.cgi?id=52261#c16
410
411         * Scripts/webkitpy/common/checkout/scm.py: Handle None for changed_files argument better in Git.create_patch method.
412         * Scripts/webkitpy/common/checkout/scm_unittest.py:
413
414 2011-01-04  Jochen Eisinger  <jochen@chromium.org>
415
416         Reviewed by David Levin.
417
418         Store the tempdir object in a variable so it doesn't get deleted too early.
419         https://bugs.webkit.org/show_bug.cgi?id=51875
420
421         * Scripts/update-webkit-auxiliary-libs:
422         * Scripts/update-webkit-support-libs:
423
424 2011-01-14  Eric Seidel  <eric@webkit.org>
425
426         Unreviewed.  Make it work in python 2.5.
427
428         webkit-patch suggest-reviewers dies when ChangeLogs are missing
429         https://bugs.webkit.org/show_bug.cgi?id=49158
430
431         * Scripts/webkitpy/common/checkout/api_unittest.py:
432
433 2011-01-14  Sheriff Bot  <webkit.review.bot@gmail.com>
434
435         Unreviewed, rolling out r75774.
436         http://trac.webkit.org/changeset/75774
437         https://bugs.webkit.org/show_bug.cgi?id=52431
438
439         gtk builds were broken (Requested by loislo2 on #webkit).
440
441         * Scripts/webkitpy/common/checkout/scm.py:
442
443 2011-01-14  David Levin  <levin@chromium.org>
444
445         Reviewed by Shinichiro Hamaji.
446
447         check-webkit-style: _FunctionState should detect pure functions.
448         https://bugs.webkit.org/show_bug.cgi?id=52428
449
450         * Scripts/webkitpy/style/checkers/cpp.py: Added detection for if a function declaration
451         is a pure virtual function.
452         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests for verifying that pure
453         virtual functions are correctly detected.
454
455 2011-01-13  Ilya Tikhonovsky  <loislo@chromium.org>
456
457         Reviewed by Yury Semikhatsky.
458
459         Just small fix for problem with check-webkit-style.
460         It just didn't work for this patch.
461         Old code can't concatenate a list of strings with None.
462
463         * Scripts/webkitpy/common/checkout/scm.py:
464
465 2011-01-13  David Levin  <levin@chromium.org>
466
467         Reviewed by Shinichiro Hamaji.
468
469         check-webkit-style: _FunctionState should use Position to know where items are.
470         https://bugs.webkit.org/show_bug.cgi?id=52424
471
472         * Scripts/webkitpy/style/checkers/cpp.py:
473         (_FunctionState.*): Changed _FunctionState to use Position instead of line numbers.
474         (detect_functions): Changed to pass Position's to _FunctionState.begin and
475         did some minor clean-up.
476         (*): Other changes are simply about converting to use the Position's in_FunctionState
477         instead of line numbers.
478         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Changed the test code
479         to verify the positions stored in _FunctionState.
480
481 2011-01-13  Eric Seidel  <eric@webkit.org>
482
483         Reviewed by David Levin.
484
485         webkit-patch suggest-reviewers dies when ChangeLogs are missing
486         https://bugs.webkit.org/show_bug.cgi?id=49158
487
488         This is not the most elegant, but it is a very safe fix to this bug.
489         One advantage of catching ScriptError like this instead of adding a
490         new added_or_modified_files or fixing all changed_files callers
491         to use a more specific change_files variant, is that we catch
492         all kinds of ScriptErrors which might cause our (non-essential)
493         suggest-reviewers code to fail out.  This should make passing
494         --suggest-reviewers to webkit-patch upload much more robust
495         and may even make it possible for us to make it default.
496
497         The root of the problem here is that SCM.changed_files includes
498         deleted ChangeLog paths (from moves, etc) which then when we ask
499         SVN/Git for the contents of the file at that revision, the command
500         errors out and Executive.run_command raises a ScriptError.
501
502         In the future we might fix this differently by making all current
503         callers of chagned_files use a more specific method for requesting
504         what types of changes they're interested in (adds, modifies, deletes, etc.)
505
506         * Scripts/webkitpy/common/checkout/api.py:
507         * Scripts/webkitpy/common/checkout/api_unittest.py:
508
509 2011-01-13  Dan Bernstein  <mitz@apple.com>
510
511         Reviewed by Alexey Proskuryakov.
512
513         <rdar://problem/8827065> REGRESSION (r71884): Cross-origin XHR fails if willSendRequest changes the URL
514         https://bugs.webkit.org/show_bug.cgi?id=52419
515
516         Allow to further control the behavior of the willSendRequest delegate callback by making it
517         set a different URL in the new request.
518
519         * DumpRenderTree/LayoutTestController.cpp:
520         (addURLToRedirectCallback): Added.
521         (LayoutTestController::staticFunctions): Added addURLToRedirect.
522         (LayoutTestController::addURLToRedirect): Added. Adds the redirection to the map.
523         (LayoutTestController::redirectionDestinationForURL): Added this getter.
524         * DumpRenderTree/LayoutTestController.h:
525         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
526         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]): Check
527         if there is a redirection for the request’s URL, established by addURLToRedirect(), and if so,
528         change the URL in the new request to the redirect destination.
529
530 2011-01-13  Eric Seidel  <eric@webkit.org>
531
532         Reviewed by Mihai Parparita.
533
534         webkit-patch suggest-reviewers fails due to invalid utf8 in ChangeLog files
535         https://bugs.webkit.org/show_bug.cgi?id=52416
536
537         Example: webkit-patch suggest-reviewers -g ca3890fe74d94d85d6bfa48f9ea497b094d8e717 
538         UnicodeDecodeError: 'utf8' codec can't decode bytes in position 536-538: invalid data
539
540         I also added FIXMEs about the changed_files returning deleted files problem
541         which is causing the other most common exception for suggest-reviewers
542         (and is probably breaking sheriff-bots blame detection).
543
544         * Scripts/webkitpy/common/checkout/api.py:
545         * Scripts/webkitpy/common/checkout/api_unittest.py:
546         * Scripts/webkitpy/common/checkout/scm.py:
547
548 2011-01-13  Eric Seidel  <eric@webkit.org>
549
550         Reviewed by Adam Barth.
551
552         results archives from commit-queue are too large to upload
553         https://bugs.webkit.org/show_bug.cgi?id=52405
554
555         * Scripts/webkitpy/common/system/filesystem.py:
556         * Scripts/webkitpy/common/system/filesystem_mock.py:
557         * Scripts/webkitpy/tool/commands/queues.py:
558
559 2011-01-13  Alejandro G. Castro  <alex@igalia.com>
560
561         Reviewed by Martin Robinson.
562
563         [gtk] Zero-sized font does not yet work
564         https://bugs.webkit.org/show_bug.cgi?id=49793
565
566         Set minimum-font-size to 0 for the DRT.
567
568         * DumpRenderTree/gtk/DumpRenderTree.cpp:
569         (resetDefaultsToConsistentValues):
570
571 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
572
573         Reviewed by Darin Adler.
574
575         Make old-run-webkit-tests more robust on buildbots
576         https://bugs.webkit.org/show_bug.cgi?id=52364
577
578         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Pass --exit-after-n-failures 500 to old-run-webkit-tests script.
579
580 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
581
582         Reviewed by Darin Adler.
583
584         Make old-run-webkit-tests more robust on buildbots
585         https://bugs.webkit.org/show_bug.cgi?id=52364
586
587         * Scripts/old-run-webkit-tests: Ensure that testResultsDirectory is empty.
588
589 2011-01-13  Tony Chang  <tony@chromium.org>
590
591         Reviewed by Kent Tamura.
592
593         [chromium] fix plugins/plugin-javascript-access.html on Linux and Mac
594         https://bugs.webkit.org/show_bug.cgi?id=52332
595
596         Forked Info.plist is not longer needed.
597
598         * DumpRenderTree/chromium/TestNetscapePlugIn/Info.plist: Removed.
599
600 2011-01-13  Mikhail Naganov  <mnaganov@chromium.org>
601
602         Reviewed by Timothy Hatcher.
603
604         Web Inspector: Cleanup after r75613 -- make all UI-facing strings
605         to be passed directly to WebInspector.UIString
606
607         https://bugs.webkit.org/show_bug.cgi?id=52365
608
609         * Scripts/check-inspector-strings:
610
611 2011-01-13  Sheriff Bot  <webkit.review.bot@gmail.com>
612
613         Unreviewed, rolling out r74881.
614         http://trac.webkit.org/changeset/74881
615         https://bugs.webkit.org/show_bug.cgi?id=52357
616
617         The EFL builder has been red for days (Requested by abarth on
618         #webkit).
619
620         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
621         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
622
623 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
624
625         Reviewed by David Levin.
626
627         Add beforeunload support to WebKitTestRunner
628         https://bugs.webkit.org/show_bug.cgi?id=52353
629         
630         This makes a number of currently failing tests pass.
631
632         * WebKitTestRunner/TestController.cpp:
633         (WTR::runBeforeUnloadConfirmPanel):
634         (WTR::createOtherPage):
635         (WTR::TestController::initialize):
636
637 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
638
639         Reviewed by Sam Weinig.
640
641         Detect, identify and recover from WebProcess crashes in run-webkit-tests
642         https://bugs.webkit.org/show_bug.cgi?id=52330
643
644         * Scripts/old-run-webkit-tests: Detect when the regression test tool reports
645         a web process crash.
646         * WebKitTestRunner/TestController.cpp:
647         (WTR::TestController::initialize): Set up a processDidCrash
648         callback.
649         (WTR::TestController::processDidCrash): Report that the Web process
650         crashed.
651         * WebKitTestRunner/TestController.h:
652
653 2011-01-12  David Levin  <levin@chromium.org>
654
655         Reviewed by Shinichiro Hamaji.
656
657         check-webkit-style -- close_expression function doesn't work correctly.
658         https://bugs.webkit.org/show_bug.cgi?id=52272
659
660         * Scripts/webkitpy/style/checkers/cpp.py:
661         (Position.__str__): Added a way to convert it to a string which is useful in tests.
662         (Position.__cmp__): Added a way to compare Position which is useful in tests and
663         generally useful (for upcoming code changes).
664         (close_expression): Changed to use Position for input and output.
665         Also, fixed many bugs such as only working correctly for parenthesis,
666         not working correctly if given an offset in a line and not finding
667         the real closing element if there were multiple closing elements in
668         the same line.
669         (detect_functions): Adjusted due to the change in arguments for
670         close_expression.
671         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
672         (CppStyleTestBase.assert_positions_equal): Added a way to verify that
673         two positions are the same.
674         (CppStyleTest.test_position): Added tests for the __str_ and __cmp__ methods.
675         (CppStyleTest.test_close_expression): Added tests to catch the issues
676         that were fixed.
677
678 2011-01-12  Sheriff Bot  <webkit.review.bot@gmail.com>
679
680         Unreviewed, rolling out r75576.
681         http://trac.webkit.org/changeset/75576
682         https://bugs.webkit.org/show_bug.cgi?id=52304
683
684         broke rebaseline-chromium-webkit-test (Requested by thakis on
685         #webkit).
686
687         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
688         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
689         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
690         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
691         * Scripts/webkitpy/layout_tests/port/base.py:
692         * Scripts/webkitpy/layout_tests/port/chromium.py:
693         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
694         * Scripts/webkitpy/layout_tests/port/test.py:
695         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
696         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
697         * Scripts/webkitpy/style/checkers/test_expectations.py:
698         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
699
700 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
701
702         Reviewed by Darin Adler.
703
704         Add a no-build option to run-webkit-tests, to avoid building DRT/WKTR
705         https://bugs.webkit.org/show_bug.cgi?id=52307
706
707         * Scripts/old-run-webkit-tests:
708
709 2011-01-12  Koan-Sin Tan  <koansin.tan@gmail.com>
710
711         Reviewed by Martin Robinson.
712
713         [Gtk] WebKitGtk+ doesn't build on Mac OS X 10.6
714         https://bugs.webkit.org/show_bug.cgi?id=50867
715
716         Fixed library extention for Mac in webkitdirs.pm and type conflict in
717         TestNetscapePlugin.cpp 
718
719         * GNUmakefile.am: Don't use AppKit when compiling TestNetscapePlugin for GTK+
720         * Scripts/webkitdirs.pm:
721
722 2011-01-12  Mikhail Naganov  <mnaganov@chromium.org>
723
724         Reviewed by Pavel Feldman.
725
726         Add check-inspector-strings script.
727
728         https://bugs.webkit.org/show_bug.cgi?id=52295
729
730         * Scripts/check-inspector-strings: Added.
731
732 2011-01-12  Adam Roben  <aroben@apple.com>
733
734         Advertise the .testnetscape file extension on Windows
735
736         Fixes <http://webkit.org/b/52298>
737         plugins/no-mime-with-valid-extension.html fails on Windows
738
739         Reviewed by Dan Bernstein.
740
741         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Added a
742         FileExtents field to map the .testnetscape file extension to the
743         application/x-webkit-test-netscape MIME type, just as we do on Mac.
744
745 2011-01-12  Adam Barth  <abarth@webkit.org>
746
747         Reviewed by Eric Seidel.
748
749         Make webkit-patch support subdirectories for SVN checkouts
750         https://bugs.webkit.org/show_bug.cgi?id=52261
751
752         os.relpath does not exist on Python 2.5, so we need to call our version
753         of the API.
754
755         * Scripts/webkitpy/common/checkout/scm.py:
756
757 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
758
759         Reviewed by Eric Seidel.
760
761         Close additional pages opened during a test once the test completes.
762         https://bugs.webkit.org/show_bug.cgi?id=52276
763
764         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
765         (WTR::InjectedBundle::done):
766
767 2011-01-11  David Levin  <levin@chromium.org>
768
769         Reviewed by Eric Seidel.
770
771         Errors should be separated from the command line in bot messages.
772         https://bugs.webkit.org/show_bug.cgi?id=52275
773
774         * Scripts/webkitpy/common/system/executive.py:
775         (ScriptError.message_with_output): Added a newline to separate the command
776         line from the errors.
777         * Scripts/webkitpy/common/system/executive_unittest.py:
778         (ScriptErrorTest.test_message_with_output): Added tests for the various code
779         paths in message_with_output.
780
781 2011-01-11  Eric Seidel  <eric@webkit.org>
782
783         Unreviewed.
784
785         commit-queue should know how to upload archived results (for test flakes or general failures)
786         https://bugs.webkit.org/show_bug.cgi?id=52048
787
788         The zips are mostly empty due to forgetting -r.
789         Expected diffs were not being pulled from the archive due
790         to the archive having longer paths than I realized.
791
792         * Scripts/webkitpy/common/system/workspace.py:
793         * Scripts/webkitpy/common/system/workspace_unittest.py:
794         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
795         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
796
797 2011-01-11  Dirk Pranke  <dpranke@chromium.org>
798
799         Reviewed by Ojan Vafai.
800
801         The current modifier parsing code in test_expectations is
802         fragile and hard-coded, so it's not easy to understand the logic
803         or easily add new types of modifiers (like GPU vs. CPU testing
804         for graphics tests, or 32-bit vs. 64-bit differences).
805
806         This is the first of two patches that will add in more generic
807         support and then eliminate the GPU-specific test expectations
808         files for Chromium.
809
810         This patch adds two standalone objects for handling modifiers. The
811         rules for interpreting modifiers, precedence, and conflicts are
812         given in the docstring to the ModifierMatcher class, which
813         returns ModifierMatchResult objects.
814         
815         This patch also adds routines to the Port interface and a
816         default set of values in the base object, in order to obtain the
817         values needed on a given test run. These values are then passed
818         to the expectation parser. This also allows us to clean up the
819         logic used to lint all of the different configurations in a
820         single test_expectations.txt file.
821
822         The next patch will merge in the separate GPU expectations file.
823
824         https://bugs.webkit.org/show_bug.cgi?id=51222
825
826         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
827         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
828         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
829         * Scripts/webkitpy/layout_tests/port/base.py:
830         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
831         * Scripts/webkitpy/layout_tests/port/chromium.py:
832         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
833         * Scripts/webkitpy/layout_tests/port/test.py:
834         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
835         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
836
837 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
838
839         Reviewed by Adam Barth.
840
841         Make webkit-patch support subdirectories for SVN checkouts
842         https://bugs.webkit.org/show_bug.cgi?id=52261
843
844         * Scripts/webkitpy/common/checkout/scm.py:
845         * Scripts/webkitpy/style_references.py:
846         * Scripts/webkitpy/tool/main.py:
847         * Scripts/webkitpy/tool/steps/preparechangelog.py:
848
849 2011-01-11  Eric Seidel  <eric@webkit.org>
850
851         Unreviewed.
852
853         commit-queue should know how to upload archived results (for test flakes or general failures)
854         https://bugs.webkit.org/show_bug.cgi?id=52048
855
856         I changed the API for archive_last_layout_test_results w/o updating the implementation.  Oops.
857         This fixes an exception seen on the commit-queue when attempting to report flaky tests.
858
859         * Scripts/webkitpy/common/system/workspace.py:
860         * Scripts/webkitpy/common/system/workspace_unittest.py:
861         * Scripts/webkitpy/tool/commands/queues.py:
862
863 2011-01-11  Sam Weinig  <sam@webkit.org>
864
865         Roll r75474 back in.
866
867 2011-01-11  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
868
869         Reviewed by Kenneth Rohde Christiansen.
870
871         [Qt] Remove uses of QFuture since it isn't supported on all platforms.
872         https://bugs.webkit.org/show_bug.cgi?id=51204
873
874         * QtTestBrowser/webpage.h:
875         (QtNAMThread::QtNAMThread):
876         (QtNAMThread::networkAccessManager):
877         (QtNAMThread::run):
878
879 2011-01-11  Peter Varga  <pvarga@webkit.org>
880
881         Unreviewed.
882
883         Add myself to committers' list.
884
885         * Scripts/webkitpy/common/config/committers.py:
886
887 2011-01-11  Eric Seidel  <eric@webkit.org>
888
889         Reviewed by Adam Barth.
890
891         commit-queue should know how to upload archived results (for test flakes or general failures)
892         https://bugs.webkit.org/show_bug.cgi?id=52048
893
894         Now the queue will always upload results.  Either the entire zip, or just
895         the diffs.txt in the case of text failures.
896
897         This should make understanding flakes much easier, and paves the way
898         for having the EWS run layout tests (and upload failures).
899
900         In order to upload .zip files I had to teach bugzilla.py to autodetect
901         mime types from the filename.  Since mimetypes.py doesn't include a mapping
902         for .patch files, I have it add one before calling guess_type.
903
904         We may find that always uploading the whole zip instead of just the -diffs.txt
905         file is preferable, but for now I'm keeping the old behavior because it makes
906         quickly understanding text failures easy.
907
908         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
909         * Scripts/webkitpy/common/system/workspace.py: Added.
910         * Scripts/webkitpy/common/system/workspace_unittest.py: Added.
911         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
912         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
913         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
914         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
915         * Scripts/webkitpy/tool/commands/queues.py:
916         * Scripts/webkitpy/tool/commands/queues_unittest.py:
917
918 2011-01-10  Sheriff Bot  <webkit.review.bot@gmail.com>
919
920         Unreviewed, rolling out r75464.
921         http://trac.webkit.org/changeset/75464
922         https://bugs.webkit.org/show_bug.cgi?id=52193
923
924         Followup rollout for 75474 (Requested by Ossy on #webkit).
925
926         * MiniBrowser/mac/BrowserWindowController.m:
927         (-[BrowserWindowController awakeFromNib]):
928         * MiniBrowser/win/BrowserView.cpp:
929         (BrowserView::create):
930         * WebKitTestRunner/TestController.cpp:
931         (WTR::createOtherPage):
932         (WTR::TestController::initialize):
933
934 2011-01-10  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
935
936         Reviewed by Csaba Osztrogonác.
937
938         [Qt] Baseline qt_minimal configuration
939         https://bugs.webkit.org/show_bug.cgi?id=51313
940
941         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
942         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): Add
943         QT_NO_UNDOSTACK guard.
944
945         * QtTestBrowser/launcherwindow.cpp:
946         (LauncherWindow::createChrome): Add QT_NO_SHORTCUT and QT_NO_PRINTER
947         guards.
948         (LauncherWindow::applyZoom): Add QT_NO_ANIMATION guard.
949         (LauncherWindow::screenshot): Add QT_NO_FILEDIALOG guard.
950         (LauncherWindow::selectElements): Add QT_NO_INPUTDIALOG guard.
951         (LauncherWindow::showUserAgentDialog): Add QT_NO_COMBOBOX guard.
952
953         * QtTestBrowser/launcherwindow.h:
954         * QtTestBrowser/locationedit.cpp: Add QT_NO_INPUTDIALOG guard.
955         * QtTestBrowser/locationedit.h: Ditto.
956
957         * QtTestBrowser/mainwindow.cpp:
958         (MainWindow::buildUI): Add QT_NO_INPUTDIALOG, QT_NO_SHORTCUT and
959         QT_NO_UNDOSTACK guards.
960         (MainWindow::setAddressUrl): Add QT_NO_INPUTDIALOG guard.
961         (MainWindow::changeLocation): Ditto.
962         (MainWindow::openFile): Add QT_NO_FILEDIALOG guard.
963         (MainWindow::openLocation): Add QT_NO_INPUTDIALOG guard.
964
965         * QtTestBrowser/webpage.cpp:
966         (WebPage::openUrlInDefaultBrowser): Add QT_NO_DESKTOPSERVICES guard.
967         (WebPage::authenticationRequired): Add QT_NO_LINEEDIT guard.
968
969         * QtTestBrowser/webview.cpp:
970         (WebViewGraphicsBased::animatedFlip): Add QT_NO_ANIMATION guard.
971         (WebViewGraphicsBased::animatedYFlip): Ditto.
972
973 2011-01-10  Sam Weinig  <sam@webkit.org>
974
975         Fix build.
976
977         * MiniBrowser/mac/BrowserWindowController.m:
978         (-[BrowserWindowController awakeFromNib]):
979         * MiniBrowser/win/BrowserView.cpp:
980         (BrowserView::create):
981         * WebKitTestRunner/TestController.cpp:
982         (WTR::createOtherPage):
983         (WTR::TestController::initialize):
984
985 2011-01-10  Eric Seidel  <eric@webkit.org>
986
987         Reviewed by Ojan Vafai.
988
989         style-queue messages are way too long for big patches
990         https://bugs.webkit.org/show_bug.cgi?id=52161
991
992         We definitely could build much fancier list-to-string-with-limit functions
993         but this should be sufficient for our needs at the moment.
994
995         * Scripts/webkitpy/common/system/executive.py:
996         * Scripts/webkitpy/common/system/executive_unittest.py:
997
998 2011-01-10  Tony Chang  <tony@chromium.org>
999
1000         Unreviewed, rolling out r75398.
1001         http://trac.webkit.org/changeset/75398
1002         https://bugs.webkit.org/show_bug.cgi?id=52008
1003
1004         Some layout tests are crashing on Chromium Win.
1005
1006         * DumpRenderTree/chromium/WebViewHost.cpp:
1007         (WebViewHost::updatePaintRect):
1008         * DumpRenderTree/chromium/WebViewHost.h:
1009
1010 2011-01-10  Adam Roben  <aroben@apple.com>
1011
1012         Roll out r75392
1013
1014         It isn't needed now that r75289 has been rolled out.
1015
1016         * Scripts/run-javascriptcore-tests:
1017
1018 2011-01-10  Maciej Stachowiak  <mjs@apple.com>
1019
1020         Reviewed by Anders Carlsson.
1021
1022         WebKitTestRunner uses crazy amounts of CPU, making layout tests slow and flaky
1023         https://bugs.webkit.org/show_bug.cgi?id=52160
1024
1025         * WebKitTestRunner/mac/TestControllerMac.mm:
1026         (WTR::TestController::platformRunUntil): Instead of busy-looping, wait for the timeout.
1027         Anything that can make runUntil() conditions turn true will happen on a run loop cycle
1028         anyway.
1029
1030 2011-01-10  Tony Chang  <tony@chromium.org>
1031
1032         Reviewed by Mihai Parparita.
1033
1034         [chromium] fix for animated gif layout tests
1035         https://bugs.webkit.org/show_bug.cgi?id=52008
1036
1037         * DumpRenderTree/chromium/WebViewHost.cpp: Schedule a paint when we update the paint rect
1038             to trigger gif animations.
1039         (WebViewHostPaintTask::WebViewHostPaintTask):
1040         (WebViewHostPaintTask::runIfValid):
1041         (WebViewHost::updatePaintRect):
1042         * DumpRenderTree/chromium/WebViewHost.h:
1043         (WebViewHost::taskList):
1044
1045 2011-01-10  Alejandro G. Castro  <alex@igalia.com>
1046
1047         Reviewed by Xan Lopez.
1048
1049         [GTK] Fix gtk2 compilation for master
1050         https://bugs.webkit.org/show_bug.cgi?id=51885
1051
1052         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
1053         (createBitmapContextFromWebView): Replaced the old
1054         gdk_drawable_get_size with gdk_pixmap_get_size.
1055
1056 2011-01-10  Patrick Gansterer  <paroga@webkit.org>
1057
1058         Reviewed by Laszlo Gombos.
1059
1060         [WINCE] Reenable NPAPI after r75203
1061         https://bugs.webkit.org/show_bug.cgi?id=52109
1062
1063         Remove the !isWinCE() check for ENABLE_NETSCAPE_PLUGIN_API and replace
1064         it with !isEfl(), because EFL port does not support NPAPI (yet).
1065
1066         * Scripts/build-webkit:
1067
1068 2011-01-10  Adam Roben  <aroben@apple.com>
1069
1070         Skip some asserting JS tests
1071
1072         See <http://webkit.org/b/52156>.
1073
1074         * Scripts/run-javascriptcore-tests:
1075
1076 2011-01-10  Martin Robinson  <mrobinson@igalia.com>
1077
1078         Reviewed by Xan Lopez.
1079
1080         [GTK] build-webkit disable Blob support via arguments passed to automake
1081         https://bugs.webkit.org/show_bug.cgi?id=52097
1082
1083         * Scripts/build-webkit: Enable Blob support when building WebKitGTK+ via
1084         build-webkit.
1085
1086 2011-01-10  Adam Roben  <aroben@apple.com>
1087
1088         Use the same name and description for TestNetscapePlugin on Windows and
1089         Mac
1090
1091         Fixes <http://webkit.org/b/52151>
1092         fast/frames/iframe-reparenting-plugins.html fails on Windows
1093
1094         Reviewed by Steve Falkenburg.
1095
1096         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Copied
1097         the name and description from Mac's Info.plist.
1098
1099 2011-01-10  Siddharth Mathur <siddharth.mathur@nokia.com>
1100
1101         Reviewed by Laszlo Gombos.
1102
1103         [Qt][WK2] Guard gcc-specific syntax
1104
1105         Non-gcc based compliers choke on the "-include"
1106         syntax for preinclude, place guard around it.
1107
1108         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1109         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1110
1111 2011-01-10  Andreas Kling  <kling@webkit.org>
1112
1113         Reviewed by Simon Hausmann.
1114
1115         [Qt] [WK2] MiniBrowser does not load pages opened in new windows
1116         https://bugs.webkit.org/show_bug.cgi?id=52111
1117
1118         When getting a createNewPage() callback from QWKPage, create the
1119         new page with the same QWKContext as the page that is passed to
1120         the callback.
1121
1122         * MiniBrowser/qt/BrowserView.h:
1123         * MiniBrowser/qt/BrowserWindow.cpp:
1124         (newPageFunction):
1125         (BrowserWindow::BrowserWindow):
1126         * MiniBrowser/qt/BrowserWindow.h:
1127
1128 2011-01-10  Andreas Kling  <kling@webkit.org>
1129
1130         Reviewed by Kenneth Rohde Christiansen.
1131
1132         [Qt] MiniBrowser: Remove superfluous createNewPage() callback
1133
1134         BrowserView set its own useless createNewPage() callback on QWKPage.
1135         This was immediately overridden by BrowserWindow anyway, so remove
1136         the BrowserView one.
1137
1138         * MiniBrowser/qt/BrowserView.cpp:
1139         (BrowserView::BrowserView):
1140
1141 2011-01-10  John Knottenbelt  <jknotten@chromium.org>
1142
1143         Reviewed by Jeremy Orlow.
1144
1145         [Chromium] Remove non-client-based Geolocation code
1146         https://bugs.webkit.org/show_bug.cgi?id=50921
1147
1148         * DumpRenderTree/chromium/LayoutTestController.cpp:
1149         (LayoutTestController::setGeolocationPermission):
1150         (LayoutTestController::setMockGeolocationPosition):
1151         (LayoutTestController::setMockGeolocationError):
1152         * DumpRenderTree/chromium/WebViewHost.cpp:
1153         (WebViewHost::geolocationClientMock):
1154         (WebViewHost::reset):
1155         * DumpRenderTree/chromium/WebViewHost.h:
1156
1157 2011-01-10  Eric Seidel  <eric@webkit.org>
1158
1159         Reviewed by Adam Barth.
1160
1161         Commit bot tried to land r? cq+ patch
1162         https://bugs.webkit.org/show_bug.cgi?id=36638
1163
1164         It should now be possible to post a patch with r? and cq+ and the
1165         commit-queue will correctly wait for the r+ before attempting to land the patch.
1166         (This was a feature requested by several users.)
1167
1168         One caveat: We don't actually reject r-, cq+ patches from the queue
1169         (we just ignore them), but I think that's OK for now.
1170
1171         I also noticed that setting r- once a commit-queue node had grabbed
1172         a patch would not properly cancel the landing.  That's fixed and
1173         tested in this patch.
1174
1175         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1176         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1177         * Scripts/webkitpy/tool/bot/feeders.py:
1178         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
1179
1180 2011-01-08  Benjamin Poulain  <benjamin.poulain@nokia.com>
1181
1182         Reviewed by Kenneth Rohde Christiansen.
1183
1184         [Qt] QtWebKit crashes when using XMLHttpRequest from the unload event
1185         https://bugs.webkit.org/show_bug.cgi?id=51934
1186
1187         When accessing the network from the destructor of QWebPage, the network access manager
1188         was already deleted because the object WebPage was already destructed.
1189
1190         This solve the problem by linking the lifetime of the network access manager to WebPage's QObject.
1191         The object is now destructed in the destructor of QObject.
1192
1193         * QtTestBrowser/webpage.cpp:
1194         (WebPage::WebPage):
1195         (WebPage::setQnamThreaded):
1196         * QtTestBrowser/webpage.h:
1197         (QtNAMThread::QtNAMThread):
1198
1199 2011-01-08  Eric Seidel  <eric@webkit.org>
1200
1201         Reviewed by Ojan Vafai.
1202
1203         test_failures.py should not mention TestShell (long live DumpRenderTree!)
1204         https://bugs.webkit.org/show_bug.cgi?id=52067
1205
1206         I ran test-webkitpy, but didn't bother adding a unit test for this string change.
1207         https://bugs.webkit.org/show_bug.cgi?id=51138#c3 is an example of why this is needed.
1208
1209         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1210
1211 2011-01-08  Eric Seidel  <eric@webkit.org>
1212
1213         Reviewed by Mihai Parparita.
1214
1215         commit-queue hangs when the ChangeLog diff is bad
1216         https://bugs.webkit.org/show_bug.cgi?id=52072
1217
1218         * Scripts/webkitpy/tool/steps/validatechangelogs.py:
1219         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
1220
1221 2011-01-08  Adam Barth  <abarth@webkit.org>
1222
1223         Teach svn-apply how to re-write WebCore to Source/WebCore.
1224
1225         * Scripts/VCSUtils.pm:
1226
1227 2011-01-07  Adam Barth  <abarth@webkit.org>
1228
1229         Rubber-stamped by Eric Seidel.
1230
1231         Move WebCore to Source
1232         https://bugs.webkit.org/show_bug.cgi?id=52050
1233
1234         Update the tools to understand WebCore's new location.
1235
1236         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1237         * DumpRenderTree/wscript:
1238         * GNUmakefile.am:
1239         * Scripts/build-webkit:
1240         * Scripts/do-file-rename:
1241         * Scripts/do-webcore-rename:
1242         * Scripts/generate-qt-inspector-resource:
1243         * Scripts/prepare-ChangeLog:
1244         * Scripts/run-bindings-tests:
1245         * Scripts/update-iexploder-cssproperties:
1246         * Scripts/update-sources-list.py:
1247         * Scripts/update-webkit-localizable-strings:
1248         * Scripts/webkitdirs.pm:
1249         * Scripts/webkitpy/common/config/build.py:
1250         * Scripts/webkitpy/common/config/build_unittest.py:
1251         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
1252         * Scripts/webkitpy/style/checker.py:
1253         * Scripts/webkitpy/style/checker_unittest.py:
1254         * WebKitTestRunner/DerivedSources.pro:
1255         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1256         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh:
1257         * wx/browser/wscript:
1258         * wx/build/settings.py:
1259
1260 2011-01-07  Maciej Stachowiak  <mjs@apple.com>
1261
1262         Reviewed by Sam Weinig.
1263
1264         Make WebKitTestRunner rest between loads more robust to avoid test crashes
1265         https://bugs.webkit.org/show_bug.cgi?id=52086
1266
1267         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1268         (WTR::InjectedBundle::didReceiveMessage):
1269         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1270         (WTR::LayoutTestController::notifyDone):
1271         * WebKitTestRunner/TestController.cpp:
1272         (WTR::TestController::resetStateToConsistentValues):
1273         (WTR::TestController::run):
1274
1275 2011-01-07  James Robinson  <jamesr@chromium.org>
1276
1277         Revert "Implement mozilla's animationTime property"
1278         https://bugs.webkit.org/show_bug.cgi?id=51952
1279
1280         This approach isn't quite right.
1281
1282         * DumpRenderTree/chromium/WebViewHost.cpp:
1283         (WebViewHost::paintInvalidatedRegion):
1284
1285 2011-01-07  Adam Roben  <aroben@apple.com>
1286
1287         Build master fix
1288
1289         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1290         (RunWebKitTests.start): Don't try to concatenate a list and a string.
1291
1292 2011-01-07  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>
1293
1294         Reviewed by Csaba Osztrogonác.
1295
1296         run-qtwebkit-tests should be able to kill a testsuite.
1297
1298         Add new option in the script that can setup a timeout for a test.
1299         If the test execution takes more then specified time then the test
1300         would be terminated.
1301
1302         [Qt] run-qtwebkit-tests needs timeout
1303         https://bugs.webkit.org/show_bug.cgi?id=51894
1304
1305         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1306         * Scripts/run-qtwebkit-tests:
1307
1308 2011-01-07  Csaba Osztrogonác  <ossy@webkit.org>
1309
1310         Unreviewed fix after r75233.
1311
1312         Based on idea from Eric Seidel.
1313
1314         Add remote zip file handling to webkitpy.
1315         https://bugs.webkit.org/show_bug.cgi?id=50901
1316
1317         * Scripts/webkitpy/common/system/fileset.py: Make python 2.5 happy.
1318
1319 2011-01-07  Shane Stephens  <shanestephens@google.com>
1320
1321         Reviewed by Eric Seidel.
1322
1323         svn-apply: should support git binary delta diffs
1324         https://bugs.webkit.org/show_bug.cgi?id=38864
1325
1326         * Scripts/VCSUtils.pm:
1327         * Scripts/svn-apply:
1328
1329 2011-01-06  Julie Parent  <jparent@chromium.org>
1330
1331         Reviewed by Eric Seidel.
1332
1333         Test Result Server not removing old results.
1334         https://bugs.webkit.org/show_bug.cgi?id=52012
1335
1336         * TestResultServer/model/jsonresults.py:
1337         Fix off-by-one: Truncate if >= num_runs, not just >.
1338         * TestResultServer/model/jsonresults_unittest.py:
1339         Add unit test to test that merging in a new result with the same value
1340         as the last result causes previous result to fall off.
1341
1342 2011-01-06  James Kozianski  <koz@chromium.org>
1343
1344         Reviewed by Mihai Parparita.
1345
1346         Add classes to provide a consistent interface to a set of files.
1347         https://bugs.webkit.org/show_bug.cgi?id=50901
1348
1349         These classes allow us to write code that is agnostic to whether a
1350         particular set of files resides in a local directory or in a zip file
1351         on a remote machine.
1352
1353         * Scripts/webkitpy/common/system/directoryfileset.py: Added.
1354         * Scripts/webkitpy/common/system/directoryfileset_unittest.py: Added.
1355         * Scripts/webkitpy/common/system/fileset.py: Added.
1356         * Scripts/webkitpy/common/system/filesystem.py:
1357         * Scripts/webkitpy/common/system/filesystem_mock.py:
1358         * Scripts/webkitpy/common/system/zipfileset.py: Added.
1359         * Scripts/webkitpy/common/system/zipfileset_unittest.py: Added.
1360
1361 2011-01-06  Eric Seidel  <eric@webkit.org>
1362
1363         Reviewed by Adam Barth.
1364
1365         NetworkTransaction should log the url it is retrying
1366         https://bugs.webkit.org/show_bug.cgi?id=52043
1367
1368         * Scripts/webkitpy/common/net/networktransaction.py:
1369         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
1370
1371 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
1372
1373         Windows build fix.
1374         Import os before using it.
1375
1376         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1377
1378 2011-01-06  Eric Seidel  <eric@webkit.org>
1379
1380         Reviewed by Adam Barth.
1381
1382         StyleQueue fails to report errors when patches have many files
1383         https://bugs.webkit.org/show_bug.cgi?id=52042
1384
1385         This is one of at least two errors preventing style error reporting at the moment.
1386         When we moved to passing the list of files to check explicitly,
1387         we started to exceed the 500 character TEXT field limit for our AppEngine model object.
1388         We could change the type of the QueueStatus.message type, or we could
1389         just teach statusserver.py how to clamp values (and warn when it does).
1390         I chose the latter path.
1391
1392         * Scripts/webkitpy/common/net/statusserver.py:
1393
1394 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
1395
1396         Reviewed by Stephanie Lewis.
1397         
1398         Fix syntax error in script.
1399
1400         Windows bots need to archive/unarchive builds to/from configuration-specific directories
1401         https://bugs.webkit.org/show_bug.cgi?id=51996
1402
1403         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1404
1405 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1406
1407         Unreviewed, fixing WinCE build after r75196.
1408
1409         WinCE port does not (yet) support NPAPI.
1410
1411         * Scripts/build-webkit:
1412
1413 2011-01-06  Xan Lopez  <xlopez@igalia.com>
1414
1415         Reviewed by Darin Adler.
1416
1417         File::Spec->rel2abs in sunspider-compare-results mangles parameters
1418         https://bugs.webkit.org/show_bug.cgi?id=52015
1419
1420         * Scripts/sunspider-compare-results: call rel2abs on our arguments
1421         after the platform has been detected, otherwise the script will
1422         mangle things like '--gtk' into '/a/path/--gtk', breaking the
1423         detection.
1424
1425 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1426
1427         Reviewed by Eric Seidel.
1428
1429         Add ENABLE_NETSCAPE_PLUGIN_API, ENABLE_ORIENTATION_EVENTS and ENABLE_TOUCH_EVENTS flags to build-webkit
1430         https://bugs.webkit.org/show_bug.cgi?id=51346
1431
1432         * Scripts/build-webkit:
1433
1434 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
1435
1436         Reviewed by Adam Roben.
1437
1438         Windows bots need to archive/unarchive builds to/from configuration-specific directories
1439         https://bugs.webkit.org/show_bug.cgi?id=51996
1440         
1441         After the configuration directory change, we were archiving the incorrect directory for
1442         build product, so we were running tests on the wrong binaries.
1443         
1444         This change archives the correct directory, and also unarchives it into a configuration-
1445         specific directory.
1446
1447         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Use a configuration-specific directory on Windows.
1448         * BuildSlaveSupport/built-product-archive: Unarchive/archive to/from proper directory.
1449
1450 2011-01-06  Eric Seidel  <eric@webkit.org>
1451
1452         Reviewed by Mihai Parparita.
1453
1454         commit-queue mentions "Text diff mismatch" 4 times instead of once per failure
1455         https://bugs.webkit.org/show_bug.cgi?id=52002
1456
1457         See an example of this here:
1458         https://bugs.webkit.org/show_bug.cgi?id=51314#c2
1459
1460         It's due to the fact that we pass around TestFailure() instance
1461         objects and yet expect them to all compare to be the same.
1462
1463         This is bad.  We should either have shared instances of these values
1464         or we should just pass around the class names.  There are already hacks
1465         in place to make TestFailure objects pass equality tests, I just added
1466         a __hash__ implementation so they can be used in sets as expected.
1467
1468         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1469         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1470
1471 2011-01-06  Evan Martin  <evan@chromium.org>
1472
1473         Reviewed by Tony Chang.
1474
1475         [gdb] handle inaccessible memory and UChar*
1476         https://bugs.webkit.org/show_bug.cgi?id=52003
1477
1478         To pretty-print a UChar*, we just grope around in the memory
1479         looking for a terminating NUL.  We need to handle the exception
1480         that can occur when we poke into an invalid location.
1481
1482         Additionally, the logic for choosing which pretty-printer would
1483         early return before hitting the point where we'd use the UChar*
1484         printer.  (Did this ever work?  How did it regress?)
1485
1486         * gdb/webkit.py:
1487
1488 2011-01-05  Brian Weinstein  <bweinstein@apple.com>
1489
1490         Reviewed by Ada Chan.
1491
1492         WebKit2: Should be able to call into injected bundle to ask if we should allow resource loads
1493         https://bugs.webkit.org/show_bug.cgi?id=51969
1494         
1495         Add shouldLoadResourceForFrame to WTR::InjectedBundlePage.
1496
1497         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1498         (WTR::InjectedBundlePage::InjectedBundlePage):
1499         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Stub implementation.
1500         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1501
1502 2011-01-06  James Robinson  <jamesr@chromium.org>
1503
1504         Reviewed by Simon Fraser.
1505
1506         Implement mozilla's animationTime property
1507         https://bugs.webkit.org/show_bug.cgi?id=51952
1508
1509         Chromium DRT support for webkitAnimationTime.
1510
1511         * DumpRenderTree/chromium/WebViewHost.cpp:
1512         (WebViewHost::paintInvalidatedRegion):
1513
1514 2011-01-06  Julie Parent  <jparent@chromium.org>
1515
1516         Reviewed by Tony Chang.
1517
1518         Test Result Server always truncates number of results to JSON_RESULTS_MAX_BUILDS
1519         https://bugs.webkit.org/show_bug.cgi?id=51217
1520
1521         * TestResultServer/model/jsonresults.py:
1522         Pass num_runs through to _remove_items_over_max_number_of_builds, and use the value.
1523         Adds missing documentation.
1524         * TestResultServer/model/jsonresults_unittest.py:
1525         Add unit test to test that truncation happens at smaller value than JSON_RESULTS_MAX_BUILDS.
1526         Update test_merge to take a number of builds to truncate at.
1527
1528 2011-01-06  Adam Barth  <abarth@webkit.org>
1529
1530         Reviewed by Eric Seidel.
1531
1532         The EWS should log outside of the working directory
1533         https://bugs.webkit.org/show_bug.cgi?id=51986
1534
1535         This patch prepare us for using git clean -x -d -f in the EWS wrapper
1536         script, which will actually clean the working copy back to a pristine
1537         state instead of leaving untracked directories and ignored files.
1538
1539         * Scripts/webkitpy/tool/commands/queues.py:
1540         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1541
1542 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
1543
1544         Windows build fix.
1545         Back out attempted change to built-product-archive.
1546
1547         * BuildSlaveSupport/built-product-archive:
1548
1549 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
1550
1551         Windows build fix.
1552         Include configuration name when unpacking a build archive.
1553
1554         Needed, since we split Windows build results into configuration-specific directories
1555         under WebKitOutputDir.
1556
1557         * BuildSlaveSupport/built-product-archive:
1558
1559 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
1560
1561         Reviewed by Darin Adler.
1562
1563         Debug and Release builds on Windows clobber each other
1564         https://bugs.webkit.org/show_bug.cgi?id=49185
1565
1566         Changes the structure of WebKitBuild build products directory so we
1567         completely separate each build configuration into independent directories.
1568         
1569         Although we previously had per-configuration directories for obj, this change adds
1570         per-configuration directories for bin, lib, obj, and include. Each configuration's
1571         build products are stored within a directory inside of WebKitBuild.
1572         
1573         Most use of $(WebKitOutputDir) in the build files has been replaced by $(ConfigurationBuildDir),
1574         defined in common.vsprops to be $(WebKitOutputDir)\$(ConfigurationName).
1575
1576         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops:
1577         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd:
1578         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd:
1579         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
1580         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd:
1581         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd:
1582         * DumpRenderTree/win/ImageDiffCommon.vsprops:
1583         * DumpRenderTree/win/ImageDiffPostBuild.cmd:
1584         * DumpRenderTree/win/ImageDiffPreBuild.cmd:
1585         * FindSafari/FindSafari.vcproj:
1586         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
1587         * MiniBrowser/MiniBrowserPostBuild.cmd:
1588         * MiniBrowser/MiniBrowserPreBuild.cmd:
1589         * Scripts/webkitdirs.pm:
1590         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
1591         * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops:
1592         * TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd:
1593         * TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd:
1594         * TestWebKitAPI/win/copy-resources.cmd:
1595         * WebKitAPITest/WebKitAPITestCommon.vsprops:
1596         * WebKitAPITest/WebKitAPITestPostBuild.cmd:
1597         * WebKitAPITest/WebKitAPITestPreBuild.cmd:
1598         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
1599         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
1600         * WebKitTestRunner/win/InjectedBundle.vcproj:
1601         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops:
1602         * WebKitTestRunner/win/InjectedBundlePostBuild.cmd:
1603         * WebKitTestRunner/win/InjectedBundlePreBuild.cmd:
1604         * WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd:
1605         * WebKitTestRunner/win/WebKitTestRunnerPreBuild.cmd:
1606         * WinLauncher/WinLauncherCommon.vsprops:
1607         * WinLauncher/WinLauncherPostBuild.cmd:
1608         * WinLauncher/WinLauncherPreBuild.cmd:
1609
1610 2011-01-05  Jan Erik Hanssen  <jhanssen@sencha.com>
1611
1612         Reviewed by Ariya Hidayat.
1613
1614         [Qt] TestNetscapePlugin doesn't link on OS X
1615         https://bugs.webkit.org/show_bug.cgi?id=51948
1616
1617         Only add a dependency on libX11 on X11 systems
1618
1619         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1620
1621 2011-01-05  Jeff Miller  <jeffm@apple.com>
1622
1623         Reviewed by Adam Roben.
1624
1625         check-webkit-style should allow unnecessary parameter names in WebKit2 APIs because we're matching CF's header style
1626         https://bugs.webkit.org/show_bug.cgi?id=51970
1627
1628         * Scripts/webkitpy/style/checker.py:
1629         Add -readability/naming for WebKit2 C API directories.
1630
1631 2011-01-05  Eric Seidel  <eric@webkit.org>
1632
1633         Unreviewed, just fixing one more log error from my previous python patch.
1634
1635         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
1636         https://bugs.webkit.org/show_bug.cgi?id=51802
1637
1638         webkit-patch failure-reason was logging about parsing errors
1639         due to my misunderstanding of how BeautifulSoup.findAll worked.
1640
1641         Fixed, and added a unit test.
1642
1643         * Scripts/webkitpy/common/net/layouttestresults.py:
1644         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1645
1646 2011-01-05  Benjamin Poulain  <benjamin.poulain@nokia.com>
1647
1648         Reviewed by Kenneth Rohde Christiansen.
1649
1650         [Qt] [WK2] Add the possibility to open window from the WebProcess in Minibrowser
1651         https://bugs.webkit.org/show_bug.cgi?id=51951
1652
1653         Set a function to QWKPage::setCreateNewPageFunction() in Minibrowser so there is a way
1654         to create new window from WebKit.
1655
1656         * MiniBrowser/qt/BrowserWindow.cpp:
1657         (newPageFunction):
1658         (BrowserWindow::BrowserWindow):
1659         (BrowserWindow::page): Added to avoid the indirect access to QWKPage spread in the class
1660         (BrowserWindow::newWindow):
1661         (BrowserWindow::updateUserAgentList):
1662         (BrowserWindow::showUserAgentDialog):
1663         * MiniBrowser/qt/BrowserWindow.h: Add the global variable backingStoreTypeForNewWindow to
1664         define the type of the backing store used for new windows.
1665         * MiniBrowser/qt/main.cpp:
1666         (main):
1667
1668 2011-01-05  Eric Seidel  <eric@webkit.org>
1669
1670         Reviewed by Ojan Vafai.
1671
1672         commit-queue should report failure type when reporting flaky tests
1673         https://bugs.webkit.org/show_bug.cgi?id=51900
1674
1675         This patch was a ridiculous amount of plumbing.  In the end I like
1676         the NRWT-style TestResult class even less.  But now we're passing
1677         a list of TestResult objects from the queue to the FlakyTestReporter.
1678         Thus the FlakyTestReporter can more easily report what type of failure
1679         occurred.
1680
1681         In the process, I found that I was not alone in finding TestResult
1682         cumbersome to use.  A bunch of code was trying to create a TestResult
1683         object with default values.  However since the constructor didn't make
1684         this easy, some places were getting it wrong (including the TestResult unit test)!
1685         I've fixed the TestResult constructor to have default values for non-essential
1686         arguments.
1687
1688         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1689         * Scripts/webkitpy/common/net/layouttestresults.py:
1690         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1691         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1692         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1693         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1694         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
1695         * Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py:
1696         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1697         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1698         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1699         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1700         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1701         * Scripts/webkitpy/tool/commands/queues.py:
1702         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1703
1704 2011-01-05  Eric Seidel  <eric@webkit.org>
1705
1706         Unreviewed.
1707
1708         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
1709         https://bugs.webkit.org/show_bug.cgi?id=51802
1710
1711         Add another unit test to cover a previously missing import.
1712
1713         * Scripts/webkitpy/common/net/layouttestresults.py:
1714         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1715
1716 2011-01-05  Mihai Parparita  <mihaip@chromium.org>
1717
1718         Reviewed by David Levin.
1719
1720         Add mihaip@chromium.org as a reviewer
1721         https://bugs.webkit.org/show_bug.cgi?id=51966
1722         
1723         Add myself as a reviewer.
1724
1725         * Scripts/webkitpy/common/config/committers.py:
1726
1727 2011-01-05  James Simonsen  <simonjam@chromium.org>
1728
1729         Unreviewed. Adding myself to the list of committers.
1730
1731         * Scripts/webkitpy/common/config/committers.py:
1732
1733 2011-01-05  Eric Seidel  <eric@webkit.org>
1734
1735         Unreviewed.
1736
1737         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
1738         https://bugs.webkit.org/show_bug.cgi?id=51802
1739
1740         Fix two exceptions seen on the bots after my original commit.
1741
1742         * Scripts/webkitpy/common/net/layouttestresults.py:
1743         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1744
1745 2011-01-05  Kundu Suchismita  <suchi.kundu@nokia.com>
1746
1747         Reviewed by Andreas Kling.
1748
1749         [Qt]Add local storage settings to QtTestBrowser command line arguments 
1750         https://bugs.webkit.org/show_bug.cgi?id=51750
1751
1752         * QtTestBrowser/main.cpp:
1753         (LauncherApplication::handleUserOptions):
1754          Local storage settings can be enable form command line arguments for
1755          QtTestBrowser.
1756
1757 2011-01-05  Chris Fleizach  <cfleizach@apple.com>
1758
1759         Reviewed by Martin Robinson.
1760
1761         GTK: AX: DRT needs to use correct root object method.
1762         https://bugs.webkit.org/show_bug.cgi?id=51911
1763
1764         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
1765         (AccessibilityController::rootElement):
1766
1767 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
1768
1769         Rubber-stamped by Csaba Osztrogonác.
1770
1771         Based on idea from Péter Gál.
1772
1773         * Scripts/webkitpy/tool/bot/sheriff.py: Remove unnecessary apostrophes around revision numbers.
1774
1775 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
1776
1777         Reviewed by Adam Barth.
1778
1779         sheriff-bot should be able to do multi-revision rollouts
1780         https://bugs.webkit.org/show_bug.cgi?id=51176
1781
1782         * Scripts/webkitpy/tool/bot/irc_command.py:
1783         * Scripts/webkitpy/tool/bot/sheriff.py:
1784         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
1785
1786 2011-01-05  Eric Seidel  <eric@webkit.org>
1787
1788         Reviewed by Adam Barth.
1789
1790         queues.webkit.org should have per-bot status pages
1791         https://bugs.webkit.org/show_bug.cgi?id=51906
1792
1793         Just adds a /queue-status/QUEUE_NAME/bots/BOT_ID page to show
1794         statuses from a single queue.  Now that we have many bots servicing
1795         some queues (commit-queue, win-ews, etc.) its easy to have the messages
1796         you care about scroll off the end of the 15-message limit on the main page.
1797
1798         Eventually we should probably rename /queue-status to /queue or /queues,
1799         but that's fodder for another patch.
1800
1801         * QueueStatusServer/handlers/queuestatus.py:
1802         * QueueStatusServer/index.yaml:
1803         * QueueStatusServer/main.py:
1804         * QueueStatusServer/templates/includes/singlequeuestatus.html:
1805          - This probably should use a custom filter instead of hard-coding
1806            the URL scheme here, but I couldn't figure out how to easily
1807            create such a filter.  Most filters work with "strings" so we can't
1808            pass the status object.  We could add a method to the status
1809            object and call that, but that seemed a bit strange too.
1810         * QueueStatusServer/templates/queuestatus.html:
1811
1812 2011-01-05  Carlos Garcia Campos  <cgarcia@igalia.com>
1813
1814         Unreviewed. Adding myself to the list of committers.
1815
1816         * Scripts/webkitpy/common/config/committers.py:
1817
1818 2011-01-04  Koan-Sin Tan  <koansin.tan@gmail.com>
1819
1820         Reviewed by David Levin.
1821
1822         check-webkit-style treated some macros with parentheses after #elif as function calls
1823         https://bugs.webkit.org/show_bug.cgi?id=51695
1824
1825         Ingore function call space checking in any preprocessor directives
1826         (things starting with #). Change search() to match() because 
1827         preprocessor directives are supposed to be in the beginning of lines.
1828
1829         * Scripts/webkitpy/style/checkers/cpp.py:
1830         * Scripts/webkitpy/style/checkers/cpp_unittest.py: make sure there is no false positives for #elif cases
1831
1832 2011-01-04  Søren Gjesse  <sgjesse@chromium.org>
1833
1834         Reviewed by Tony Chang.
1835
1836         Change the --multi-load test option to --stress-opt
1837         https://bugs.webkit.org/show_bug.cgi?id=50751
1838
1839         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1840         (runTest):
1841         (main):
1842         * DumpRenderTree/chromium/TestShell.cpp:
1843         (TestShell::TestShell):
1844         * DumpRenderTree/chromium/TestShell.h:
1845         (TestShell::stressOpt):
1846         (TestShell::setStressOpt):
1847         (TestShell::stressDeopt):
1848         (TestShell::setStressDeopt):
1849         (TestShell::javaScriptFlags):
1850         (TestShell::setJavaScriptFlags):
1851         * Scripts/webkitpy/layout_tests/port/chromium.py:
1852         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1853
1854 2011-01-04  Chris Fleizach  <cfleizach@apple.com>
1855
1856         Reviewed by Sam Weinig.
1857
1858         WK2: Support Accessibility
1859         https://bugs.webkit.org/show_bug.cgi?id=51859
1860
1861         Use rootObject() method to get top of accessibility tree.
1862
1863         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
1864         (AccessibilityController::focusedElement):
1865         (AccessibilityController::rootElement):
1866
1867 2011-01-03  Martin Robinson  <mrobinson@igalia.com>
1868
1869         Reviewed by Darin Adler.
1870
1871         Remove the last non-GObject usage of PlatformRefPtr and move the code to GRefPtr
1872         https://bugs.webkit.org/show_bug.cgi?id=51846
1873
1874         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: Change usage of PlatformRefPtr
1875         back to GRefPtr.
1876
1877 2011-01-04  Zhe Su  <suzhe@chromium.org>
1878
1879         Reviewed by Kenneth Russell.
1880
1881         Fix insertText, setMarkedText and unmarkText methods of
1882         TextInputController to call corresponding methods of WebKit::WebView
1883         rather than WebKit::WebFrame. This change matches the behavior of
1884         chromium browser.
1885         insertText corresponds to WebView::confirmComposition(text)
1886         setMarkedText corresponds to WebView::setComposition(...)
1887         unmarkText corresponds to WebView::confirmComposition()
1888         https://bugs.webkit.org/show_bug.cgi?id=51693
1889
1890         * DumpRenderTree/chromium/TextInputController.cpp:
1891         (TextInputController::insertText):
1892         (TextInputController::setMarkedText):
1893         (TextInputController::unmarkText):
1894
1895 2011-01-04  Dihan Wickremasuriya  <dihan.wickremasuriya@nokia.com>
1896
1897         Reviewed by Laszlo Gombos.
1898
1899         [Qt] [Symbian] Do not remove 0 byte sized files from productDir
1900
1901         On Symbian productDir points to the source directory. Removing all the
1902         empty files from the productDir directory corrupts the svn repository.
1903
1904         * Scripts/build-webkit:
1905
1906 2011-01-03  Yi Shen  <yi.4.shen@nokia.com>
1907
1908         Reviewed by Adam Barth.
1909
1910         [Qt] Add SelectAll option to the context menu for the editor
1911         https://bugs.webkit.org/show_bug.cgi?id=50049
1912
1913         Set shortcut for the SelectAll action.
1914
1915         * QtTestBrowser/mainwindow.cpp:
1916         (MainWindow::buildUI):
1917
1918 2011-01-03  David Levin  <levin@chromium.org>
1919
1920         Reviewed by Eric Seidel.
1921
1922         check-webkit-style shouldn't consider "value" automatically to be a meaningless name.
1923         https://bugs.webkit.org/show_bug.cgi?id=51842
1924
1925         * Scripts/webkitpy/style/checkers/cpp.py: Remove the check for value.
1926         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Remove the test for value.
1927
1928 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
1929
1930         Reviewed by David Kilzer.
1931
1932         [WINCE] Adds a build slave.
1933         https://bugs.webkit.org/show_bug.cgi?id=50523
1934
1935         * BuildSlaveSupport/build.webkit.org-config/config.json: Add an
1936         entry for a release build of the WinCE port.
1937         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add platform
1938         flag to build the WinCE port.
1939
1940 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
1941
1942         Reviewed by David Kilzer.
1943
1944         Add WinCE support to build-webkit
1945         https://bugs.webkit.org/show_bug.cgi?id=51642
1946
1947         * Scripts/build-webkit:
1948         * Scripts/webkitdirs.pm:
1949
1950 2011-01-03  Eric Seidel  <eric@webkit.org>
1951
1952         Reviewed by Adam Barth.
1953
1954         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
1955         https://bugs.webkit.org/show_bug.cgi?id=51802
1956
1957         I'm not the biggest fan of the test_failures or test_results classes,
1958         but it's better to have one shared set of classes, than separate ones
1959         for new vs. old run-webkit-test result handling.
1960
1961         This moves the ORWT results class "LayoutTestResults" over to using
1962         TestResult and TestFailure classes, making it easy for us to
1963         make all our sheriff-bot and other webkitpy code NRWT ready.
1964
1965         This also makes it a trivial patch to generate results.json information
1966         from ORWT results.html files (for flaky test analysis, etc.) as well
1967         as making it a one-liner to report test failure types when the
1968         commit-queue sees flaky tests.
1969
1970         This patch tried not to add new functionality, but only to replace
1971         the guts of LayoutTestResults, while adding unit tests and hoping
1972         not to break anything.
1973
1974         I also moved callers which assumed User.prompt* were static/class methods
1975         to using them as instance methods (since we'll eventually want to make them such).
1976
1977         In the process of re-writing things, I broke the rebaseline command, so I wrote
1978         a unit test to catch my breakage were I do do so again in the future.
1979
1980         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1981         * Scripts/webkitpy/common/net/layouttestresults.py:
1982         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1983         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1984         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
1985         * Scripts/webkitpy/tool/commands/queries.py:
1986         * Scripts/webkitpy/tool/commands/rebaseline.py:
1987         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1988         * Scripts/webkitpy/tool/mocktool.py:
1989
1990 2011-01-03  Adam Barth  <abarth@webkit.org>
1991
1992         Reviewed by Simon Fraser.
1993
1994         webkit-patch shouldn't waste time cleaning a working directory that's already clean
1995         https://bugs.webkit.org/show_bug.cgi?id=51840
1996
1997         * Scripts/webkitpy/common/checkout/scm.py:
1998
1999 2011-01-03  Adam Barth  <abarth@webkit.org>
2000
2001         Reviewed by Simon Fraser.
2002
2003         webkit-patch should only hide update output if --quiet
2004         https://bugs.webkit.org/show_bug.cgi?id=51838
2005
2006         As requested by smfr.
2007
2008         * Scripts/webkitpy/tool/steps/update.py:
2009
2010 2011-01-03  Adam Barth  <abarth@webkit.org>
2011
2012         Reviewed by David Levin.
2013
2014         commit-queue shouldn't reject patches twice if two bots process the same patch
2015         https://bugs.webkit.org/show_bug.cgi?id=51805
2016
2017         Before raising an error, we first check whether the patch is still in
2018         the commit-queue.  This check is still racy, of course, but the time
2019         window is much smaller.
2020
2021         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2022
2023 2011-01-03  Sam Weinig  <sam@webkit.org>
2024
2025         Reviewed by Anders Carlsson.
2026
2027         Make run-api-tests less chatty.
2028         https://bugs.webkit.org/show_bug.cgi?id=51831
2029
2030         - Make script quiet by default and add --verbose option (replacing --quiet).
2031         - When not verbose, pipe stdout and stderr to devnull.
2032
2033         * Scripts/run-api-tests:
2034
2035 2011-01-03  Pratik Solanki  <psolanki@apple.com>
2036
2037         Unreviewed. Adding myself to committers.py.
2038
2039         * Scripts/webkitpy/common/config/committers.py:
2040
2041 2011-01-03  Koan-Sin Tan  <koansin.tan@gmail.com>
2042
2043         Reviewed by Xan Lopez.
2044
2045         "Tool/Scripts/run-launcher --gtk" stopped working after 74855
2046         https://bugs.webkit.org/show_bug.cgi?id=51806
2047
2048         Originally, the $libraryName is 'JavaScriptCore'. When building release 
2049         one, the $libraryDir was 'WebKitBuild/Release/JavaScriptCore/../.libs/'
2050         which doesn't exist anymore ('WebKitBuild/Release/JavaScriptCore'
2051         is 'WebKitBuild/Release/Source/JavaScriptCore' now), and 
2052         'WebKitBuild/Release/Source/JavaScriptCore/../../.libs' looks weird,
2053         so make it 'WebKitBuild/Release/.libs'
2054
2055         * Scripts/webkitdirs.pm: 
2056
2057 2011-01-02  Patrick Gansterer  <paroga@webkit.org>
2058
2059         Reviewed by Adam Barth.
2060
2061         Make EFL a core builder
2062         https://bugs.webkit.org/show_bug.cgi?id=51804
2063
2064         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2065         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2066
2067 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
2068
2069         [Qt] Unreviewed fix after r74855 and r74875.
2070
2071         * BuildSlaveSupport/built-product-archive:
2072          - Create directories explicitly.
2073          - Pass shell=True to subprocess.call().
2074
2075 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
2076
2077         [Qt] Unreviewed fix after r74855.
2078
2079         Move JavaScriptCore to Source
2080         https://bugs.webkit.org/show_bug.cgi?id=51604
2081
2082         * BuildSlaveSupport/built-product-archive: JavaScriptCore -> Source/JavaScriptCore
2083
2084 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
2085
2086         [Qt] Unreviewed run-javasriptcore-tests fix after r74855.
2087
2088         Move JavaScriptCore to Source
2089         https://bugs.webkit.org/show_bug.cgi?id=51604
2090
2091         * Scripts/webkitdirs.pm:
2092
2093 2011-01-02  Robert Hogan  <robert@webkit.org>
2094
2095         Unreviewed, build fix.
2096
2097         [Qt] Fix DRT build after 74855
2098
2099         * DumpRenderTree/qt/DumpRenderTree.pro:
2100
2101 2011-01-01  Adam Barth  <abarth@webkit.org>
2102
2103         Remove the assumption from the Qt and Gtk builds that every project is
2104         in the root directory.
2105
2106         * Scripts/build-webkit:
2107
2108 2011-01-01  Adam Barth  <abarth@webkit.org>
2109
2110         Reviewed by Eric Seidel.
2111
2112         Teach svn-apply how to apply patches even though JavaScriptCore has moved
2113         https://bugs.webkit.org/show_bug.cgi?id=51796
2114
2115         After this change, svn-apply will magically apply patches to
2116         JavaScriptCore/foo to Source/JavaScriptCore/foo.
2117
2118         * Scripts/VCSUtils.pm:
2119
2120 2011-01-01  Adam Barth  <abarth@webkit.org>
2121
2122         Reviewed by Eric Seidel.
2123
2124         Move JavaScriptCore to Source
2125         https://bugs.webkit.org/show_bug.cgi?id=51604
2126
2127         Update references to JavaScriptCore to point to the new location.
2128
2129         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2130         * DumpRenderTree/qt/DumpRenderTree.pro:
2131         * DumpRenderTree/qt/ImageDiff.pro:
2132         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2133         * DumpRenderTree/wscript:
2134         * Scripts/build-jsc:
2135         * Scripts/build-webkit:
2136         * Scripts/do-file-rename:
2137         * Scripts/do-webcore-rename:
2138         * Scripts/run-javascriptcore-tests:
2139         * Scripts/update-javascriptcore-test-results:
2140         * Scripts/webkitdirs.pm:
2141         * Scripts/webkitpy/common/config/build_unittest.py:
2142         * Scripts/webkitpy/style/checker.py:
2143         * Scripts/webkitpy/style/checker_unittest.py:
2144         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2145         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2146         * WebKitTestRunner/qt/WebKitTestRunner.pro:
2147         * wx/build/settings.py:
2148
2149 2011-01-01  Adam Barth  <abarth@webkit.org>
2150
2151         Reviewed by Eric Seidel.
2152
2153         Move Sources to Source
2154         https://bugs.webkit.org/show_bug.cgi?id=51794
2155
2156         Update scripts to point to the new location.
2157
2158         * Scripts/build-webkit:
2159         * Scripts/do-file-rename:
2160         * Scripts/do-webcore-rename:
2161         * Scripts/webkitpy/common/config/build.py:
2162         * Scripts/webkitpy/common/config/build_unittest.py:
2163
2164 2010-12-31  Kent Tamura  <tkent@chromium.org>
2165
2166         Reviewed by Eric Seidel.
2167
2168         [DRT/Chromium] Enable mock spell checker on non-OSX
2169         https://bugs.webkit.org/show_bug.cgi?id=51401
2170
2171         * DumpRenderTree/chromium/WebViewHost.cpp:
2172         (WebViewHost::spellCheck):
2173
2174 2010-12-31  Adam Barth  <abarth@webkit.org>
2175
2176         Reviewed by Ariya Hidayat.
2177
2178         Remove Tools/Scripts/wkstyle
2179         https://bugs.webkit.org/show_bug.cgi?id=51774
2180
2181         This script appears to not have been touched in a while and seems to
2182         have been replaced by check-webkit-style.
2183
2184         * Scripts/wkstyle: Removed.
2185
2186 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
2187
2188         Unreviewed. Coding style fix.
2189
2190         * DumpRenderTree/chromium/TestShell.h:
2191
2192 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
2193
2194         Reviewed by Pavel Feldman.
2195
2196         Web Inspector: [Chromium] Inspector's tests are very slow on Win(Dbg).
2197
2198         It was a problem with Chromium DRT. DevToolsAgent object instance was
2199         attached not only to the inspected page but to the DevTools window too.
2200         As result all the inspector files were interpreted as a content of inspected page
2201         and were transfered to the DevTools scripts panel for debugging etc.
2202
2203         https://bugs.webkit.org/show_bug.cgi?id=51735
2204
2205         * DumpRenderTree/chromium/TestShell.cpp:
2206         (TestShell::TestShell):
2207         (TestShell::bindJSObjectsToWindow):
2208         (TestShell::createNewWindow):
2209         * DumpRenderTree/chromium/TestShell.h:
2210
2211 2010-12-31  Adam Barth  <abarth@webkit.org>
2212
2213         Rubber-stamped by Eric Seidel.
2214
2215         Move PageLoadTests to PerformanceTests/PageLoad
2216         https://bugs.webkit.org/show_bug.cgi?id=51771
2217
2218         Update references to PageLoadTests to point to the new location.
2219
2220         * Scripts/run-pageloadtest:
2221         * Scripts/webkitpy/common/config/build.py:
2222
2223 2010-12-31  Adam Barth  <abarth@webkit.org>
2224
2225         Rubber-stamped by Eric Seidel.
2226
2227         Move SunSpider into PerformanceTests
2228         https://bugs.webkit.org/show_bug.cgi?id=51769
2229
2230         Update these scripts to point to the new location.
2231
2232         * Scripts/run-sunspider:
2233         * Scripts/sunspider-compare-results:
2234
2235 2010-12-30  Mihai Parparita  <mihaip@chromium.org>
2236
2237         Reviewed by Kent Tamura.
2238
2239         [Chromium] Add WebThemeEngineDRTMac so that Chromium DRT scrollbar rendering can match the Mac port's
2240         https://bugs.webkit.org/show_bug.cgi?id=51728
2241         
2242         Add implementation of the Mac WebThemeEngine that uses an NSScroller
2243         to render top-level scrollbars. This makes them match the Mac port's
2244         use of an NSScrollView, which means that we'll be able to share more
2245         pixel baselines.
2246         
2247         The new rendering code will not be activated until the 
2248         USE_WEB_THEME_ENGINE_TO_PAINT_THUMB #define is fliped in
2249         ScrollbarThemeChromiumMac.
2250
2251         * DumpRenderTree/DumpRenderTree.gypi:
2252         * DumpRenderTree/chromium/TestShellMac.mm:
2253         (platformInit):
2254         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Added.
2255         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Added.
2256         (+[FakeActiveWindow alwaysActiveWindow]):
2257         (+[FakeActiveWindow alwaysInactiveWindow]):
2258         (-[FakeActiveWindow initWithActiveControls:]):
2259         (-[FakeActiveWindow _hasActiveControls]):
2260         (WebThemeEngineDRTMac::paintScrollbarThumb):
2261         (stateToHIEnableState):
2262         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
2263         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
2264
2265 2010-12-30  Konstantin Tokarev  <annulen@yandex.ru>
2266
2267         Reviewed by David Kilzer.
2268
2269         [Qt] Don't build wtf/TCSystemAlloc.cpp if --system-malloc option is
2270         used
2271         https://bugs.webkit.org/show_bug.cgi?id=51672
2272
2273         * DumpRenderTree/qt/DumpRenderTree.pro: Replaced USE_SYSTEM_MALLOC
2274         with USE_SYSTEM_MALLOC=1
2275         * WebKitTestRunner/qt/WebKitTestRunner.pro: Replaced USE_SYSTEM_MALLOC
2276         with USE_SYSTEM_MALLOC=1
2277
2278 2010-12-30  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2279
2280         Reviewed by David Kilzer.
2281
2282         [Qt] [Symbian] Fix build-webkit script for Symbian
2283         https://bugs.webkit.org/show_bug.cgi?id=51509
2284
2285         Set the OUTPUT_DIR for Symbian to be the same as the source
2286         directory.
2287
2288         * Scripts/webkitdirs.pm:
2289
2290 2010-12-30  Martin Robinson  <mrobinson@igalia.com>
2291
2292         Reviewed by Darin Adler.
2293
2294         check-webkit-style should ignore NULL usage in calls to gtk_widget_style_get
2295         https://bugs.webkit.org/show_bug.cgi?id=51758
2296
2297         Add a check-webkit-style exception for gtk_widget_style_get and NULL usage.
2298
2299         * Scripts/webkitpy/style/checkers/cpp.py: Add the exception.
2300         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Add some tests for this.
2301
2302 2010-12-29  Patrick Gansterer  <paroga@webkit.org>
2303
2304         Unreviewed WinCE buildfix.
2305
2306         * WinCELauncher/main.cpp: Add missing include.
2307
2308 2010-12-29  Daniel Bates  <dbates@rim.com>
2309
2310         Reviewed by Darin Adler.
2311
2312         svn-apply updates date of wrong change log entry for a change log diff that
2313         contains two consecutive entries with the same author and date
2314         https://bugs.webkit.org/show_bug.cgi?id=46061
2315
2316         Fixes an issue where the date of the wrong change log entry may be modified.
2317         Moreover, changes fixChangeLogPatch() to move entries inserted earlier
2318         in a ChangeLog file to the top of the file.
2319
2320         Currently, fixChangeLogPatch() explicitly bails out and returns an unchanged
2321         diff when it detects that the diff inserts a change log entry earlier in a
2322         ChangeLog. It is unusual to land a patch that has such a deliberate ChangeLog
2323         change. With the advent of the commit-queue this functionality of bailing out
2324         and hence landing the patch as-is is harmful to the accuracy of the ChangeLog.
2325         Instead, we should always move the change log entry to the top of the ChangeLog file.
2326
2327         A side-effect of this change is that setChangeLogDateAndReviewer() now updates
2328         the date line of the correct change log entry in a ChangeLog diff.
2329
2330         * Scripts/VCSUtils.pm: Modified fixChangeLogPatch() to move entries inserted earlier to the top.
2331
2332         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
2333           Updated the following unit tests now that we move entries inserted earlier to the top:
2334           - "fixChangeLogPatch: New entry inserted in middle."
2335             (formerly named "fixChangeLogPatch: [no change] New entry inserted in middle.")
2336
2337           - "fixChangeLogPatch: New entry inserted earlier in the file, but after an entry with the same author and date."
2338             (formerly named "fixChangeLogPatch: [no change] New entry inserted earlier in the file, but after an entry with the same author and date.")
2339
2340         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatchThenSetChangeLogDateAndReviewer.pl: Added.
2341
2342 2010-12-29  Konstantin Tokarev  <annulen@yandex.ru>
2343
2344         Reviewed by Eric Seidel.
2345
2346         [Qt] Fixed compatibility with gold linker on X11 platforms
2347         https://bugs.webkit.org/show_bug.cgi?id=51700
2348
2349         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2350         Linked TestNetscapePlugin with libX11 on Unix platforms
2351
2352 2010-12-29  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>
2353
2354         Reviewed by Darin Adler.
2355
2356         Circular dependency in webkitpy.common.checkout.changelog module
2357         https://bugs.webkit.org/show_bug.cgi?id=50475
2358
2359         Remove automatic import of api.Checkout module when any checkout/
2360         submodule is imported (e.g.: when checkout.scm.Git is imported).
2361
2362         * Scripts/webkitpy/common/checkout/__init__.py:
2363
2364 2010-12-29  Martin Robinson  <mrobinson@igalia.com>
2365
2366         Reviewed by Ojan Vafai.
2367
2368         prepare-ChangeLog should support the -g option for specifying the git-commit
2369         https://bugs.webkit.org/show_bug.cgi?id=51708
2370
2371         Add a -g shortcut for the --git-commit prepare-ChangeLog option. This matches
2372         webkit-patch, though the exact meaning of the two options remain different.
2373
2374         * Scripts/prepare-ChangeLog: Add -g.
2375
2376 2010-12-29  Kent Hansen  <kent.hansen@nokia.com>
2377
2378         Reviewed by Simon Hausmann.
2379
2380         [Qt] Fix compilation with Qt in namespace
2381         https://bugs.webkit.org/show_bug.cgi?id=51701
2382
2383         * QtTestBrowser/webview.h:
2384
2385 2010-12-28  Daniel Bates  <dbates@rim.com>
2386
2387         Reviewed by Sam Weinig.
2388
2389         Substitute // MARK: for compiler-specific #pragma mark
2390         https://bugs.webkit.org/show_bug.cgi?id=51657
2391
2392         Fix future compilation warnings about "#pragma mark" on GTK+ bots by
2393         substituting  "// MARK:" for "#pragma mark", which provides
2394         analogous code-bookmarking functionality under Xcode.
2395
2396         Also, for consistency, we should substitute "// MARK:" for compiler-
2397         specific "#pragma mark" in the source files for the Mac port.
2398
2399         * DumpRenderTree/AccessibilityTextMarker.cpp:
2400         * DumpRenderTree/cf/WebArchiveDumpSupport.h:
2401         * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm:
2402         * DumpRenderTree/mac/ObjCController.m:
2403         * MiniBrowser/mac/AppDelegate.m:
2404         * MiniBrowser/mac/BrowserWindowController.m:
2405
2406 2010-12-28  Xan Lopez  <xlopez@igalia.com>
2407
2408         Reviewed by Eric Seidel.
2409
2410         Add --no-build option to run-sunspider
2411         https://bugs.webkit.org/show_bug.cgi?id=51658
2412
2413         * Scripts/run-sunspider: add --no-build flag to skip building
2414         phase.
2415
2416 2010-12-27  Daniel Bates  <dbates@rim.com>
2417
2418         Rubber-stamped by Martin Robinson.
2419
2420         Append the directory Tools/DumpRenderTree to the list of directories that
2421         do-webcore-rename should search so that it can rename DRT files and
2422         source code.
2423
2424         * Scripts/do-webcore-rename:
2425
2426 2010-12-27  Eric Seidel  <eric@webkit.org>
2427
2428         Reviewed by Adam Barth.
2429
2430         build-webkit should detect missing Java SDK and explain how to install it
2431         https://bugs.webkit.org/show_bug.cgi?id=51651
2432
2433         * Scripts/build-webkit:
2434
2435 2010-12-26  Martin Robinson  <mrobinson@igalia.com>
2436
2437         Reviewed by Daniel Bates.
2438
2439         [GTK] Add support for build-jsc
2440         https://bugs.webkit.org/show_bug.cgi?id=51625
2441
2442         Add GTK+ support to build-jsc now that building the jsc executable as
2443         a standalone target is easy.
2444
2445         * Scripts/build-jsc: Call buildGtkProject for the GTK+ case now.
2446         * Scripts/build-webkit: Pass in the proper target name to buildGtkProject.
2447         * Scripts/webkitdirs.pm: Actually process the project parameter in buildGtkProject
2448         and pass it along to buildAutotoolsProject.
2449
2450 2010-12-27  David Levin  <levin@chromium.org>
2451
2452         Reviewed by Eric Seidel.
2453
2454         check-webkit-style check for meaningless variable names in function declarations.
2455         https://bugs.webkit.org/show_bug.cgi?id=51523
2456
2457         * Scripts/webkitpy/style/checker.py: Exempted JavaScriptCore/jit/JITStubs.cpp
2458         from the new check and whitespace/parens because the syntax is unusual and
2459         produced a fair number of positives for these checks.
2460         * Scripts/webkitpy/style/checkers/cpp.py:
2461         (_convert_to_lower_with_underscores): Used as a canonical form for type names
2462         and parameter names when determining if the parameter name is useless.
2463         (_create_acronym): Used to check for redundant variable names in cases like "ExceptionCode ec"
2464         (Parameter.lower_with_underscores_name): Gives back the parameter name in a lower_with_underscore
2465         format.
2466         (_check_parameter_name_against_text):  Checks to see if the parameter name is in the
2467         text or an acronym of it.
2468         (check_function_definition): Checks function definitions for meaningless variable names.
2469         (process_line): Added call to check_function_definition.
2470         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2471         (CppFunctionsTest.test_convert_to_lower_with_underscores): Test for _convert_to_lower_with_underscores.
2472         (CppFunctionsTest.test_create_acronym): Test for _create_acronym.
2473         (CppFunctionsTest.test_check_parameter_against_text): Test for _check_parameter_against_text.
2474         (CppStyleTestBase.perform_single_line_lint): Removed the parameter name check
2475         because when only checking a snippet, there are a lot of bogus functions.
2476         (CppStyleTestBase.perform_multi_line_lint): Ditto and removed a bogus filter
2477         that I put there previously and just noticed.
2478         (WebKitStyleTest.test_parameter_names): Tests for the functionality -- both
2479         check_function_definition and process_line.
2480
2481 2010-12-27  Carlos Garcia Campos  <cgarcia@igalia.com>
2482
2483         Reviewed by Martin Robinson.
2484
2485         [GTK] Disable flash plugin in GtkLauncher when using gtk3
2486         https://bugs.webkit.org/show_bug.cgi?id=51591
2487
2488         Flash plugin uses gtk2 that is incompatible with gtk3 making
2489         webkit crash when it's built with gtk3.
2490
2491         * GtkLauncher/main.c:
2492         (main):
2493
2494 2010-12-25  Adam Barth  <abarth@webkit.org>
2495
2496         Reviewed by Eric Seidel.
2497
2498         Move ANGLE to Sources/ThirdParty
2499         https://bugs.webkit.org/show_bug.cgi?id=51605
2500
2501         * Scripts/build-webkit:
2502           - Point to the new ANGLE location.
2503
2504 2010-12-26  David Levin  <levin@chromium.org>
2505
2506         Reviewed by Eric Seidel.
2507
2508         check-webkit-style should be able to parse function declaration parameters.
2509         https://bugs.webkit.org/show_bug.cgi?id=51451
2510
2511         * Scripts/webkitpy/style/checkers/cpp.py:
2512         (Position.__init__): Holds simple position information (row, column).
2513         (Parameter.__init__): Holds information about a parameter.
2514         (SingleLineView.__init): Converts multiple lines into a single line for simpler searches.
2515         (SingleLineView.convert_column_to_row): Returns the original row given a column.
2516         (create_skeleton_parameters): Simplifies a parameter list for easier searching.
2517         (find_parameter_name_index): Finds where the parameter name is.
2518         (parameter_list): Generates the list of parameters for a function.
2519         (_FunctionState.begin): Added information to allow determining the parameters
2520         on demand.
2521         (_FunctionState.get_parameter_list): Returns a tuple of function parameters.
2522         (detect_functions): Improve function detection for operator functions and
2523         determine where the parameters end and pass that to _FunctionState.begin.
2524         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2525         (CppFunctionsTest.test_parameter): Verifies Parameter functionality.
2526         (CppFunctionsTest.test_single_line_view): Verifies SingleLineView functionality.
2527         (CppFunctionsTest.test_create_skeleton_parameters): Verifies create_skeleton_parameters.
2528         (CppFunctionsTest.test_find_parameter_name_index): Verifies find_parameter_name_index.
2529         (CppFunctionsTest.test_parameter_list): Does some minimal verification for parameter list.
2530         Much more thorough verification is done as part of FunctionDetectionTest.test_parameter_list.
2531         (FunctionDetectionTest.perform_function_detection): Added support for verifying
2532         the parameters found.
2533         (FunctionDetectionTest.test_function_declaration_detection): Added more function
2534         detection test to verify that we catch the operator functions.
2535         (FunctionDetectionTest.test_ignore_macros): Verify that function detection ignores macros.
2536         (FunctionDetectionTest.test_parameter_list): Added tests to verify the parameter parsing.
2537         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_bad_test_doesnt_break): Removed
2538         because the error. The test is about the bad function name. Fixing the name makes the test exactly like
2539         test_function_length_check_definition_severity1_for_test.
2540
2541 2010-12-25  Patrick Gansterer  <paroga@webkit.org>
2542
2543         Unreviewed WinCE buildfix after r74334.
2544
2545         * CMakeListsWinCE.txt:
2546
2547 2010-12-24  Sheriff Bot  <webkit.review.bot@gmail.com>
2548
2549         Unreviewed, rolling out r74632.
2550         http://trac.webkit.org/changeset/74632
2551         https://bugs.webkit.org/show_bug.cgi?id=51600
2552
2553         makes test-webkitpy hang forever on GTK (Requested by philn-tp
2554         on #webkit).
2555
2556         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
2557         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
2558
2559 2010-12-24  Ryuan Choi  <ryuan.choi@samsung.com>
2560
2561         Reviewed by Kenneth Rohde Christiansen.
2562
2563         [EFL] Screen doesn't be rendered when changing size of EWebLauncher
2564         https://bugs.webkit.org/show_bug.cgi?id=43528
2565
2566         Remove on_resize because ewk_view_fixed_layout_size_set should not be
2567         called on callback of EVAS_CALLBACK_RESIZE. As it change size of
2568         FrameView, rendering was ignored when _ewk_view_smart_calculate was
2569         called.
2570
2571         * EWebLauncher/main.c:
2572         (browserCreate):
2573
2574 2010-12-24  Eric Seidel  <eric@webkit.org>
2575
2576         Reviewed by Adam Barth.
2577
2578         webkit-patch (or a pre-commit hook) needs to prevent bad ChangeLog changes
2579         https://bugs.webkit.org/show_bug.cgi?id=28291
2580
2581         This is a start.  At least now webkit-patch will prompt when your ChangeLog looks questionable.
2582         We could do more advanced things, like parsing the ChangeLog (with changelog.py) and comparing that
2583         to strings with find in the diff.
2584         Since non-interactive always returns the default, this should cause patches with bad changelogs to fail on the commit-queue.
2585
2586         * Scripts/webkitpy/common/checkout/api.py:
2587         * Scripts/webkitpy/common/checkout/diff_parser.py:
2588         * Scripts/webkitpy/tool/steps/abstractstep.py:
2589         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
2590         * Scripts/webkitpy/tool/steps/validatechangelogs.py: Copied from Tools/Scripts/webkitpy/tool/steps/validatereviewer.py.
2591         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py: Copied from Tools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.
2592         * Scripts/webkitpy/tool/steps/validatereviewer.py:
2593
2594 2010-12-24  Dirk Pranke  <dpranke@chromium.org>
2595
2596         Reviewed by Kenneth Russell.
2597
2598         Modify new-run-webkit-tests to shut up and exit when all the threads
2599         are wedged so that test runs complete faster and we don't end up
2600         w/ enormous log files.
2601
2602         https://bugs.webkit.org/show_bug.cgi?id=51572
2603
2604         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
2605         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
2606
2607 2010-12-24  Eric Seidel  <eric@webkit.org>
2608
2609         Reviewed by David Levin.
2610
2611         commit-queue should better explain how it will re-open bugs and follow duplicate chains
2612         https://bugs.webkit.org/show_bug.cgi?id=51549
2613
2614         I've had multiple people ask me about the commit-queue's behavior
2615         regarding reporting flaky tests.  I figured it would be best to just
2616         have the queue explain itself in the bugs it files.
2617
2618         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2619         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2620
2621 2010-12-24  Shinichiro Hamaji  <hamaji@chromium.org>
2622
2623         Reviewed by Eric Seidel.
2624
2625         check-webkit-style: should ignore "wrong" namings in JavaScriptCore/qt
2626         https://bugs.webkit.org/show_bug.cgi?id=51467
2627
2628         * Scripts/webkitpy/style/checker.py:
2629         * Scripts/webkitpy/style/checker_unittest.py:
2630
2631 2010-12-23  Adam Barth  <abarth@webkit.org>
2632
2633         Rubber-stamped by Eric Seidel.
2634
2635         Move JavaScriptGlue into Sources
2636         https://bugs.webkit.org/show_bug.cgi?id=51583
2637
2638         These tools refer to JavaScriptGlue and need to be updated to its new
2639         location.
2640
2641         * Scripts/build-webkit:
2642         * Scripts/do-file-rename:
2643         * Scripts/do-webcore-rename:
2644         * Scripts/webkitpy/common/config/build.py:
2645         * Scripts/webkitpy/common/config/build_unittest.py:
2646
2647 2010-12-23  Lucas Forschler  <lforschler@apple.com>
2648
2649         Reviewed by Eric Seidel.
2650
2651         Bug 51539 - update iexploder scripts to point to new location
2652
2653         * Scripts/run-iexploder-tests:
2654         * Scripts/update-iexploder-cssproperties:
2655
2656 2010-12-23  Evan Martin  <evan@chromium.org>
2657
2658         Reviewed by Ryosuke Niwa.
2659
2660         [chromium] LayoutTestController warning in float->int conversion
2661         https://bugs.webkit.org/show_bug.cgi?id=51553
2662
2663         Rather than reading an int, converting to a float, then getting a compiler
2664         warning on passing the float to something that expects an int, instead
2665         just pass around ints.
2666
2667         No tests, fixes a compiler warning.
2668
2669         * DumpRenderTree/chromium/LayoutTestController.cpp:
2670         (parsePageSizeParameters):
2671         (LayoutTestController::pageNumberForElementById):
2672         (LayoutTestController::numberOfPages):
2673
2674 2010-12-23  Lucas Forschler  <lforschler@apple.com>
2675
2676         Reviewed by Darin Adler.
2677
2678         Bug 51537 - iexploder needs cleanup
2679         
2680         * iExploder/htdocs: Removed.
2681         * iExploder/htdocs/config.rb: Removed.
2682         * iExploder/htdocs/cssproperties.in: Removed.
2683         * iExploder/htdocs/cssvalues.in: Removed.
2684         * iExploder/htdocs/htmlattrs.in: Removed.
2685         * iExploder/htdocs/htmltags.in: Removed.
2686         * iExploder/htdocs/htmlvalues.in: Removed.
2687         * iExploder/htdocs/iexploder.cgi: Removed.
2688         * iExploder/htdocs/iexploder.rb: Removed.
2689         * iExploder/htdocs/index.html: Removed.
2690         * iExploder/htdocs/webserver.rb: Removed.
2691         * iExploder/iexploder-1.7.2/output: Removed.
2692         * iExploder/tools: Removed.
2693         * iExploder/tools/lasthit.rb: Removed.
2694         * iExploder/tools/osx_last_crash.rb: Removed.
2695         * iExploder/tools/showtest.rb: Removed.
2696
2697 2010-12-23  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
2698
2699         Reviewed by Kenneth Rohde Christiansen.
2700
2701         [EFL] Make 'single' the default backing store in EWebLauncher
2702         https://bugs.webkit.org/show_bug.cgi?id=51534
2703
2704         'single' is the simplest backing store and the one intended to be the
2705         default in the test browser. By mistake the tiled backing store was
2706         left as default in r72617.
2707
2708         * EWebLauncher/main.c:
2709         (browserCreate): ditto.
2710
2711 2010-12-23  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
2712
2713         Reviewed by Kenneth Rohde Christiansen.
2714
2715         [EFL] Subject: [webkit 4/4] [EFL] Remove non-sense workaround
2716         https://bugs.webkit.org/show_bug.cgi?id=51533
2717
2718         There's no point in concatenating env("HOME") with "blah", so remove
2719         option from EWebLauncher.
2720
2721         * EWebLauncher/main.c:
2722         (main): ditto.
2723
2724 2010-12-23  Ilya Tikhonovsky  <loislo@chromium.org>
2725
2726         Reviewed by Eric Seidel.
2727
2728         Web Inspector: chromium: inspector's tests are quite slow especially at windows(Debug).
2729
2730         Almost all inspector's tests become flaky on chromium Win(dbg) after switching to DRT.
2731         I just discovered that we have two additional GC runs per each WebViewHost.
2732         Test_shell had no such calls.
2733         These gc runs eat 15% of cpu time.
2734
2735         https://bugs.webkit.org/show_bug.cgi?id=51479
2736
2737         * DumpRenderTree/chromium/WebViewHost.cpp:
2738         (WebViewHost::~WebViewHost):
2739
2740 2010-12-22  Dirk Pranke  <dpranke@chromium.org>
2741
2742         Reviewed by Ojan Vafai.
2743
2744         This change splits out the TestRunner class into its own file.
2745         When we fork the code for message passing, we will create a new
2746         TestRunner, and this change will allow that to be more modular.
2747
2748         While we're at it, split out TestInput and ResultSummary into
2749         their own files, to reduce the size of run_webkit_tests to
2750         something more managable.
2751
2752         https://bugs.webkit.org/show_bug.cgi?id=51092
2753
2754         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2755         * Scripts/webkitpy/layout_tests/layout_package/result_summary.py:
2756         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2757         * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
2758         * Scripts/webkitpy/layout_tests/layout_package/test_input.py:
2759         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2760         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2761
2762  2010-12-22  Dirk Pranke  <dpranke@chromium.org>
2763
2764         Reviewed by Ojan Vafai.
2765
2766         nrwt multiprocessing - start over, prepare to fork the code
2767  
2768         This code cleans up the signatures and implementation of the
2769         TestRunner class so we can easily fork it to run either the
2770         stable implementation or the new, unstable message-passing
2771         implementation. The two variants will have different
2772         implementations of the run_tests() method. We will switch
2773         between the two based on the setting for the '--worker-model'
2774         switch. We rename the two currently valid values to 'old-inline'
2775         and 'old-threads'.
2776
2777         https://bugs.webkit.org/show_bug.cgi?id=51081
2778
2779         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2780         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2781
2782 2010-12-22  Victor Wang  <victorw@chromium.org>
2783
2784         Reviewed by Darin Fisher.
2785
2786         [Chromium] Update chromium archive test result url in rebaseline script.
2787
2788         https://bugs.webkit.org/show_bug.cgi?id=51503
2789
2790         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2791
2792 2010-12-22  Lucas Forschler  <lforschler@apple.com>
2793
2794         Reviewed by Alice Liu.
2795
2796         <rdar://problem/8633222> record-memory-win needs to record memory used by the webprocess.
2797         Verified on Chrome, Safari, and IE.
2798         With this change, we will record memory from a parent browser window and all child processes.
2799
2800         * record-memory-win/main.cpp:
2801         (ProcessArgs):
2802         (PrintUsage):
2803         (getMemoryInfo):
2804         (printProcessInfo):
2805         (evalProcesses):
2806         (UseImage):
2807         (QueryContinuously):
2808         (ElapsedTime):
2809
2810 2010-12-22  Lucas Forschler  <lforschler@apple.com>
2811
2812         Unreviewed rollout r74489, because it was missing changelog.
2813
2814         * record-memory-win/main.cpp:
2815         
2816 2010-12-22  Ryosuke Niwa  <rniwa@webkit.org>
2817
2818         Adding myself as a reviewer.
2819
2820         * Scripts/webkitpy/common/config/committers.py:
2821
2822 2010-12-22  Andrew Scherkus  <scherkus@chromium.org>
2823
2824         Unreviewed.  Adding myself to committers.py.
2825
2826         * Scripts/webkitpy/common/config/committers.py:
2827
2828 2010-12-22  Ariya Hidayat  <ariya@sencha.com>
2829
2830         Reviewed by Kenneth Rohde Christiansen.
2831
2832         TestNetscapePlugIn should use #if defined
2833         https://bugs.webkit.org/show_bug.cgi?id=51471
2834
2835         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2836         (NP_Initialize):
2837         (NPP_New):
2838
2839 2010-12-22  Ilya Tikhonovsky  <loislo@chromium.org>
2840
2841         Reviewed by Yury Semikhatsky.
2842
2843         Web Inspector: [chromium] DRT inspector layout tests are flaky in debug.
2844
2845         DevTools window should be closed explicitly because it has custom deinitialization code.
2846
2847         https://bugs.webkit.org/show_bug.cgi?id=50722
2848
2849         * DumpRenderTree/chromium/TestShell.cpp:
2850         (TestShell::closeRemainingWindows):
2851
2852 2010-12-22  David Levin  <levin@chromium.org>
2853
2854         Reviewed by Shinichiro Hamaji.
2855
2856         check-webkit-style shouldn't complaint about underscores in variables in objective C files.
2857         https://bugs.webkit.org/show_bug.cgi?id=51452
2858
2859         * Scripts/webkitpy/style/checkers/cpp.py:
2860         (_FileState.__init__): Added the information to determine if a file is C or Objective C.
2861         Using the file extension if possible but falling back to the file contents if we have a header file.
2862         (_FileState.is_objective_c): Determine if we have an Objective C by examining the file contents if needed.
2863         (_FileState.is_c_or_objective_c):
2864         (check_using_std): Changed to using _FileState to determine the file type.
2865         (check_max_min_macros): Ditto.
2866         (check_for_null): Ditto.
2867         (check_style): Changed the parameters to various calls since they now need _FileState
2868         to determine the file type.
2869         (check_language): Added the file_state parameter so it could be passed
2870         to check_identifier_name_in_declaration.
2871         (check_identifier_name_in_declaration): Don't warn about underscores in variables if
2872         this is an Objective C file.
2873         (_process_lines): Added information for the _FileState constructor (and moved the
2874         call to a place that had the information).
2875         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2876         (CppFunctionsTest.test_is_c_or_objective_c): Changed the tests to use FileState and exercise
2877         its functionality.
2878         (WebKitStyleTest.test_names): Add tests for underscores in Objective C files.
2879
2880 2010-12-21  Andy Estes  <aestes@apple.com>
2881
2882         Reviewed by Mark Rowe.
2883
2884         Do not build non-Intel architectures for WebKit2-related projects.
2885         https://bugs.webkit.org/show_bug.cgi?id=51440
2886
2887         * MiniBrowser/Configurations/Base.xcconfig: Only build for i386 and x86_64.
2888         * TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
2889         * WebKitTestRunner/Configurations/Base.xcconfig: Ditto.
2890
2891 2010-12-21  Mihai Parparita  <mihaip@chromium.org>
2892
2893         Reviewed by Darin Fisher.
2894
2895         [Chromium] Rename WebThemeEngine/ControlDRT to WebThemeEngine/ControlDRTWin
2896         https://bugs.webkit.org/show_bug.cgi?id=51406 
2897         
2898         Rename WebThemeControlDRT to WebThemeControlDRTWin and WebThemeEngineDRT
2899         to WebThemeEngineDRTWin and update references everywhere.
2900
2901         * DumpRenderTree/DumpRenderTree.gypi:
2902         * DumpRenderTree/chromium/TestShellWin.cpp:
2903         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRT.cpp.
2904         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRT.h.
2905         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRT.cpp.
2906         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRT.h.
2907
2908 2010-12-21  Anders Carlsson  <andersca@apple.com>
2909
2910         Reviewed by John Sullivan.
2911
2912         Clicking missing plug-in text does not show a sheet
2913         https://bugs.webkit.org/show_bug.cgi?id=51403
2914
2915         Update for changes to the WebPageUIClient.
2916
2917         * MiniBrowser/mac/BrowserWindowController.m:
2918         (-[BrowserWindowController awakeFromNib]):
2919         * WebKitTestRunner/TestController.cpp:
2920         (WTR::createOtherPage):
2921         (WTR::TestController::initialize):
2922
2923 2010-12-21  Eric Seidel  <eric@webkit.org>
2924
2925         Reviewed by Adam Barth.
2926
2927         commit-queue will report constant failures as flaky if other tests flake
2928         https://bugs.webkit.org/show_bug.cgi?id=51272
2929
2930         This patch just removes functionality and adds testing.
2931         Previously we attempted to report flaky tests when we had
2932         two different tests fail in a row.  However, since we stop
2933         running the tests at the first failure, our code was wrong in
2934         trying to determine flakiness from the incomplete runs.
2935
2936         Originally I posted an alternate patch:
2937         https://bug-51272-attachments.webkit.org/attachment.cgi?id=77078
2938         which fixed our flaky logic in this case, however it was decided
2939         that that patch would be too difficult to maintain, so now
2940         I'm just removing the broken logic.
2941
2942         This will dramatically cut-down on our flaky-test false positives
2943         at the (small) cost of the queues being unable to report
2944         any flakiness if the tree is very flaky.  (With at least one test
2945         flaking on every run, we'll never report failures anymore.)  I think
2946         this is a tradeoff worth making.
2947
2948         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2949         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2950
2951 2010-12-20  Eric Seidel  <eric@webkit.org>
2952
2953         Reviewed by Adam Barth.
2954
2955         commit-queue wrongly rejects patches when it can't update itself
2956         https://bugs.webkit.org/show_bug.cgi?id=46636
2957
2958         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2959         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2960         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2961
2962 2010-12-20  Adam Barth  <abarth@webkit.org>
2963
2964         Move web sites to Websites directory
2965         https://bugs.webkit.org/show_bug.cgi?id=51323
2966
2967         Update references to BugsSite to point to the new location.
2968
2969         This patch was never officially reviewed (because it was too large to
2970         upload to bugs.webkit.org), but it was discussed on webkit-dev and Mark
2971         Rowe gave me the green light.
2972
2973         * Scripts/old-run-webkit-tests:
2974         * Scripts/webkitpy/common/config/build.py:
2975         * Scripts/webkitpy/common/config/build_unittest.py:
2976         * Scripts/webkitpy/common/prettypatch.py:
2977         * Scripts/webkitpy/layout_tests/port/base.py:
2978         * Scripts/webkitpy/style/main.py:
2979
2980 2010-12-20  Adrienne Walker  <enne@google.com>
2981
2982         Unreviewed. Adding myself to the list of committers.
2983
2984         * webkitpy/common/config/committers.py:
2985
2986 2010-12-20  Mark Rowe  <mrowe@apple.com>
2987
2988         Reviewed by Dan Bernstein.
2989
2990         <rdar://problem/8757601> Don't install header files in to the Resources directory.
2991
2992         * Scripts/check-for-inappropriate-files-in-framework: Don't allow .h files in the
2993         Resources directory.
2994
2995 2010-12-20  Eric Seidel  <eric@webkit.org>
2996
2997         Reviewed by Adam Barth.
2998
2999         commit-queue should include bot id when attaching failure diffs
3000         https://bugs.webkit.org/show_bug.cgi?id=51280
3001
3002         This is a tiny change to include the bot id in the name of the attachment.
3003         Most of this diff is just changing the unit test expectations
3004         now that I hid the comment printing when the comment is None.
3005
3006         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3007         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3008         * Scripts/webkitpy/tool/commands/upload_unittest.py:
3009         * Scripts/webkitpy/tool/mocktool.py:
3010
3011 2010-12-20  Jeff Miller  <jeffm@apple.com>
3012
3013         Reviewed by Dan Bernstein.
3014
3015         Tools/vcbin/midl.exe needs to be rebuilt
3016         https://bugs.webkit.org/show_bug.cgi?id=51347
3017
3018         * vcbin/midl.exe: Rebuilt.
3019
3020 2010-12-20  David Levin  <levin@chromium.org>
3021
3022         Reviewed by Ariya Hidayat.
3023
3024         .gitignore and webkit-tools-completion.sh have references to WebKitTools that should be Tools.
3025         https://bugs.webkit.org/show_bug.cgi?id=51343
3026
3027         Follow up from the WebKitTools -> Tools rename.
3028
3029         * Scripts/webkit-tools-completion.sh:
3030
3031 2010-12-20  Cosmin Truta  <ctruta@chromium.org>
3032
3033         Reviewed by James Robinson.
3034
3035         new-run-webkit-tests ignores trailing EOL differences in text tests
3036         https://bugs.webkit.org/show_bug.cgi?id=36983
3037
3038         Changed the handling of new-line characters within new-run-webkit-tests
3039         to match old-run-webkit-tests.  Differences in leading and trailing empty
3040         lines in text expectation files are no longer ignored.
3041
3042         * Scripts/webkitpy/layout_tests/port/base.py:
3043         * Scripts/webkitpy/layout_tests/port/test.py:
3044         Added unit tests.  Removed old duplicate unit test entries.
3045         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
3046
3047 2010-12-20  David Levin  <levin@chromium.org>
3048
3049         Reviewed by Shinichiro Hamaji.
3050
3051         check-webkit-style should detect function declarations (and trivial functions).
3052         https://bugs.webkit.org/show_bug.cgi?id=51303
3053
3054         * Scripts/webkitpy/style/checkers/cpp.py:
3055         (_FunctionState.begin): Add is_declaration and changed the line count
3056         start to begin at -1 (which will keep the results consistent, since
3057         the starting line number passed in is one less in this change).
3058         (detect_functions): changed function detection to now catch trivial
3059         functions and declarations.
3060         (check_pass_ptr_usage): Don't check for Pass*Ptr on the first line
3061         of the function as this may look at return values (when processing
3062         a declaration).
3063         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3064         (FunctionDetectionTest.perform_function_detection): Basic mechanics
3065         of testing the function detection.
3066         (FunctionDetectionTest.test_basic_function_detection): Test a simple
3067         function.
3068         (FunctionDetectionTest.test_function_declaration_detection): Test a
3069         declaration.
3070         (FunctionDetectionTest.test_non_functions): A test case for a case
3071         that caused the code to fail due to the { being in quotes.
3072         (PassPtrTest.test_pass_ref_ptr_return_value): Added some more test
3073         cases to help catch false alarms for return values.
3074         (PassPtrTest.test_pass_ref_ptr_member_variable): Ensure that
3075         we don't get false alarms for member variables either.
3076
3077 2010-12-20  Ryuan Choi  <ryuan.choi@samsung.com>
3078
3079         Reviewed by Antonio Gomes.
3080
3081         [CMAKE] Rename WEBKITTOOLS_DIR to TOOLS_DIR
3082         https://bugs.webkit.org/show_bug.cgi?id=51319
3083
3084         * CMakeListsEfl.txt:
3085
3086 2010-12-18  Adam Barth  <abarth@webkit.org>
3087
3088         Reviewed by Sam Weinig.
3089
3090         Move WebKitExamplePlugins to Examples
3091         https://bugs.webkit.org/show_bug.cgi?id=51291
3092
3093         * Scripts/webkitpy/common/config/build.py:
3094
3095 2010-12-17  Csaba Osztrogonác  <ossy@webkit.org>
3096
3097         Unreviewed Qt buildfix after r74301.
3098
3099         Rename WebKitTools to Tools
3100         https://bugs.webkit.org/show_bug.cgi?id=49861
3101
3102         * MiniBrowser/DerivedSources.pro:
3103         * MiniBrowser/qt/MiniBrowser.pro:
3104
3105 2010-12-17  Dan Bernstein  <mitz@apple.com>
3106
3107         Reviewed by Simon Fraser.
3108
3109         Rename WebKitTools to Tools
3110         https://bugs.webkit.org/show_bug.cgi?id=49861
3111
3112         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3113         * CodeCoverage/README:
3114         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3115         (WebCore::DumpRenderTree::initializeFonts):
3116         * EWSTools/start-commit-queue.sh:
3117         * EWSTools/start-queue.sh:
3118         * GNUmakefile.am:
3119         * MIDLWrapper/MIDLWrapper.cpp:
3120         (wmain):
3121         * MiniBrowser/qt/MiniBrowser.pro:
3122         * Scripts/build-api-tests:
3123         * Scripts/build-dumprendertree:
3124         * Scripts/build-webkit:
3125         * Scripts/build-webkittestrunner:
3126         * Scripts/generate-coverage-data:
3127         * Scripts/old-run-webkit-tests:
3128         * Scripts/run-api-tests:
3129         * Scripts/run-iexploder-tests:
3130         * Scripts/run-javascriptcore-tests:
3131         * Scripts/run-mangleme-tests:
3132         * Scripts/run-sunspider:
3133         * Scripts/run-webkit-websocketserver:
3134         * Scripts/sunspider-compare-results:
3135         * Scripts/test-webkitperl:
3136         * Scripts/test-webkitpy:
3137         * Scripts/update-iexploder-cssproperties:
3138         * Scripts/update-webkit:
3139         * Scripts/update-webkit-localizable-strings:
3140         * Scripts/webkitdirs.pm:
3141         * Scripts/webkitpy/common/checkout/scm.py:
3142         * Scripts/webkitpy/common/checkout/scm_unittest.py:
3143         * Scripts/webkitpy/common/config/committervalidator.py:
3144         * Scripts/webkitpy/common/config/committervalidator_unittest.py:
3145         * Scripts/webkitpy/common/config/ports.py:
3146         * Scripts/webkitpy/common/config/ports_unittest.py:
3147         * Scripts/webkitpy/common/system/logutils_unittest.py:
3148         * Scripts/webkitpy/common/system/ospath_unittest.py:
3149         * Scripts/webkitpy/layout_tests/port/chromium.py:
3150         * Scripts/webkitpy/layout_tests/port/config.py:
3151         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
3152         * Scripts/webkitpy/layout_tests/port/http_server.py:
3153         * Scripts/webkitpy/layout_tests/port/test.py:
3154         * Scripts/webkitpy/style/checker.py:
3155         * Scripts/webkitpy/style/checker_unittest.py:
3156         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
3157         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3158         * Scripts/webkitpy/tool/steps/steps_unittest.py:
3159         * WebKitTestRunner/DerivedSources.pro:
3160         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
3161         (WTR::activateFonts):
3162         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3163         * wx/build/build_utils.py:
3164
3165 2010-12-16  Antonio Gomes  <agomes@rim.com>
3166
3167         Reviewed by Martin Robinson.
3168
3169         Settings::editingBehaviorType() incorrectly returns mac for the gtk build when running tests
3170         https://bugs.webkit.org/show_bug.cgi?id=51163
3171
3172         Since GTK+'s default editing behavior was changed to UNIX in r70975 (see webkitwebsettings.cpp),
3173         GTK+'s DRT should also reset to UNIX after each test execution.
3174
3175         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3176         (resetDefaultsToConsistentValues):
3177
3178 2010-12-17  David Levin  <levin@chromium.org>
3179
3180         Reviewed by Eric Seidel.
3181
3182         check-webkit-style should understand WTF #include guards
3183         https://bugs.webkit.org/show_bug.cgi?id=44911
3184
3185         * Scripts/webkitpy/style/checkers/cpp.py:
3186         (get_header_guard_cpp_variable): modify to suggest the WTF style
3187         of header guard when appropriate.
3188         (check_for_header_guard): handle multiple return values from
3189         get_header_guard_cpp_variable
3190         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3191         (CppStyleTest.test_build_header_guard): Added tests for the WTF
3192         header style.
3193
3194 2010-12-16  David Levin  <levin@chromium.org>
3195
3196         Reviewed by Eric Seidel.
3197
3198         test-webkitpy: unittest for the xml.py checker displays a decprecation warning.
3199         https://bugs.webkit.org/show_bug.cgi?id=51210
3200
3201         The error only shows up when using python 2.6 or later.
3202
3203         * Scripts/webkitpy/style/checkers/xml.py: Replace the usage of
3204         the decprecated field error,message with something equivalent.
3205
3206 2010-12-16  Mihai Parparita  <mihaip@chromium.org>
3207
3208         Reviewed by Eric Seidel.
3209
3210         Add --exit-after-n-failures/crashes to NRWT
3211         https://bugs.webkit.org/show_bug.cgi?id=51160
3212         
3213         Abort test run (in a similar way to how control-C is handled) when
3214         --exit-after-n-failures/crashes-or-timeouts are passed and we've reached
3215         that number of unexpected failures/crashes/timeouts.
3216
3217         * Scripts/webkitpy/layout_tests/port/test.py:
3218         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3219         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3220
3221 2010-12-16  David Levin  <levin@chromium.org>
3222
3223         Reviewed by Shinichiro Hamaji.
3224
3225         check-webkit-style unit tests has some duplicate boilerplate code.
3226         https://bugs.webkit.org/show_bug.cgi?id=49519
3227
3228         * Scripts/webkitpy/style/checkers/cpp.py:
3229         (update_include_state): Replaced the "io" parameter with the global
3230         configuration _unit_test_config. This allowed not calling into
3231         functions at a low level and also not plumbing through the injection
3232         information through many levels of code.
3233         (check_for_include_what_you_use): Ditto.
3234         (process_file_data): Added the ability to set up the unit test config
3235         to allow for injection.
3236         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3237         (ErrorCollector.__init__): Added support for having a filter for errors.
3238         (ErrorCollector.__call__): Ditto.
3239         (CppStyleTestBase.process_file_data): Added the ability to set unit_test_config.
3240         (CppStyleTestBase.perform_lint): Consolidated logic for the perform functions.
3241         (CppStyleTestBase.perform_single_line_lint): Replace specific calls to
3242         functions in the cpp.py with generic processing and a filter that
3243         indicates what errors should be kept.
3244         (CppStyleTestBase.perform_multi_line_lint): Ditto.
3245         (CppStyleTestBase.perform_language_rules_check): Ditto.
3246         (CppStyleTestBase.perform_function_lengths_check): Ditto.
3247         (CppStyleTestBase.perform_pass_ptr_check): Ditto.
3248         (CppStyleTestBase.perform_include_what_you_use): Ditto.
3249         (CppStyleTest.test_multi_line_comments): Added another
3250         error message which applies to the test case.
3251         (CppStyleTest.test_spacing_for_binary_ops): Fixed test
3252         to not have config.h, since it is processed as a header file.
3253         (CppStyleTest.test_static_or_global_stlstrings): Fixed variable name
3254         style and indentation in checked code.
3255         (OrderOfIncludesTest.test_check_preprocessor_in_include_section):
3256         Fixed line number.
3257         (NoNonVirtualDestructorsTest.test_multi_line_declaration_with_error):
3258         Ditto.
3259
3260 2010-12-15  Sheriff Bot  <webkit.review.bot@gmail.com>
3261
3262         Unreviewed, rolling out r74136.
3263         http://trac.webkit.org/changeset/74136
3264         https://bugs.webkit.org/show_bug.cgi?id=51135
3265
3266         r74136 breaks chromium canary bots because some tests are not
3267         rebaselined correctly to resolve EOL differences (Requested by
3268         jianli on #webkit).
3269
3270         * Scripts/webkitpy/layout_tests/port/base.py:
3271         * Scripts/webkitpy/layout_tests/port/test.py:
3272         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
3273
3274 2010-12-15  Adam Roben  <aroben@apple.com>
3275
3276         Teach check-webkit-style to check .vcproj and .vsprops files for XML
3277         syntax errors
3278
3279         Fixes <http://webkit.org/b/51103> check-webkit-style should check for
3280         XML syntax errors in .vcproj/.vsprops files
3281
3282         Reviewed by Dave Levin.
3283
3284         * Scripts/webkitpy/style/checker.py: Added lists of file extensions
3285         that should be treated as XML and that should be allowed to contain
3286         carriage returns. (These lists happen to be identical currently.)
3287         (FileType): Added a new XML type.
3288         (CheckerDispatcher.should_check_and_strip_carriage_returns): Added.
3289         Just does a simple file extension check.
3290         (CheckerDispatcher._file_type): Added a case for XML files.
3291         (CheckerDispatcher._create_checker): Ditto. We use XMLChecker for XML
3292         files (surprise!).
3293         (StyleProcessor.process): Ask the dispatcher whether we should pass the
3294         lines through the carriage checker.
3295
3296         * Scripts/webkitpy/style/checker_unittest.py:
3297         (CheckerDispatcherCarriageReturnTest.test_should_check_and_strip_carriage_returns):
3298         Added. Checks a few file names to see if carriage returns are allowed
3299         or not.
3300         (CheckerDispatcherDispatchTest.assert_checker_xml): Added. Similar to
3301         other assert_checker_* functions.
3302         (CheckerDispatcherDispatchTest.test_xml_paths): Added. Similar to other
3303         test_*_paths functions.
3304         (CheckerDispatcherDispatchTest.test_xml_paths): Added. Similar to other
3305         test_*_paths functions.
3306         (CheckerDispatcherDispatchTest.test_none_paths): Removed the vcproj
3307         file from this test case, as vcproj files now have a type.
3308         (StyleProcessor_CodeCoverageTest.MockDispatcher.should_check_and_strip_carriage_returns):
3309         Added. Similar to the other should_* functions.
3310         (StyleProcessor_CodeCoverageTest.test_process__carriage_returns_not_stripped):
3311         Added. Checks that carriage returns aren't checked for or stripped for
3312         allowed files.
3313
3314         * Scripts/webkitpy/style/checkers/xml.py: Added.
3315         (XMLChecker.__init__): Simple init method.
3316         (XMLChecker.check): Pass each line through the expat parser, and record
3317         a style error for any errors thrown by the parser.
3318
3319         * Scripts/webkitpy/style/checkers/xml_unittest.py: Added.
3320         (XMLCheckerTest.assert_no_error): Checks that the given XML does not
3321         produce a style error.
3322         (XMLCheckerTest.assert_error): Checks that the given XML produces an
3323         error of the given category on the given line.
3324         (XMLCheckerTest.mock_handle_style_error): Does nothing. Used for
3325         checking that the XMLChecker constructor works properly.
3326         (XMLCheckerTest.test_conflict_marker): Tests that conflict markers
3327         cause a style error (see, e.g., r73887).
3328         (XMLCheckerTest.test_extra_closing_tag): Tests that extra closing tags
3329         cause a style error (see, e.g., r73773).
3330         (XMLCheckerTest.test_init): Tests that the XMLChecker constructor works
3331         properly.
3332         (XMLCheckerTest.test_missing_closing_tag): Tests that missing closing
3333         tags cause a style error (see, e.g., r72795).
3334         (XMLCheckerTest.test_no_error): Tests that valid XML does not cause a
3335         style error.
3336
3337 2010-12-15  Lucas Forschler  <lforschler@apple.com>
3338
3339         Reviewed by Stephanie Lewis.
3340
3341         https://bugs.webkit.org/show_bug.cgi?id=51117
3342         Add a new leopard test bot
3343         really really commit to trunk this time.
3344
3345         * BuildSlaveSupport/build.webkit.org-config/config.json:
3346
3347 2010-12-15  Sam Weinig  <sam@webkit.org>
3348
3349         Reviewed by Anders Carlsson.
3350
3351         WebKit2: Can't add files to an <input type=file>
3352         https://bugs.webkit.org/show_bug.cgi?id=51087
3353
3354         * MiniBrowser/mac/BrowserWindowController.m:
3355         (runOpenPanel):
3356         (-[BrowserWindowController awakeFromNib]):
3357         Add simple implementation of runOpenPanel callback.
3358
3359         * MiniBrowser/win/BrowserView.cpp:
3360         (BrowserView::create):
3361         * WebKitTestRunner/TestController.cpp:
3362         (WTR::createOtherPage):
3363         (WTR::TestController::initialize):
3364         Stub out runOpenPanel callback. 
3365
3366 2010-12-14  Eric Seidel  <eric@webkit.org>
3367
3368         Reviewed by Adam Barth.
3369
3370         commit-queue should upload failure diffs when tests flake
3371         https://bugs.webkit.org/show_bug.cgi?id=51051
3372
3373         To make this testable I needed to pipe FileSystem down onto tool.
3374         We've wanted it there for a long time anyway.
3375
3376         This patch is kinda a big hack.  But we don't have a nice
3377         way to read results.html files.  I think this will need further
3378         revision before this code actually feels clean.
3379
3380         As part of testing this change, I had to make MockBugzilla.create_bug
3381         actually return an id (like it should) which required updating
3382         a few other unit test results (for the better).
3383
3384         The results_matching_keys change in layouttestresults/rebasline
3385         was an alternate path which I decided not to use in the end, but
3386         I left the change as it seemed an improvement.
3387
3388         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3389         * Scripts/webkitpy/common/net/layouttestresults.py:
3390         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3391         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3392         * Scripts/webkitpy/tool/commands/queues.py:
3393         * Scripts/webkitpy/tool/commands/rebaseline.py:
3394         * Scripts/webkitpy/tool/main.py:
3395         * Scripts/webkitpy/tool/mocktool.py:
3396
3397 2010-12-15  Cosmin Truta  <ctruta@chromium.org>
3398
3399         Reviewed by James Robinson.
3400
3401         new-run-webkit-tests ignores trailing EOL differences in text tests
3402         https://bugs.webkit.org/show_bug.cgi?id=36983
3403
3404         Changed the handling of new-line characters within new-run-webkit-tests
3405         to match old-run-webkit-tests.  Differences in leading and trailing empty
3406         lines in text expectation files are no longer ignored.
3407
3408         * Scripts/webkitpy/layout_tests/port/base.py:
3409         * Scripts/webkitpy/layout_tests/port/test.py:
3410         Added unit tests.  Removed old duplicate unit test entries.
3411         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
3412
3413 2010-12-15  Ojan Vafai  <ojan@chromium.org>
3414
3415         Reviewed by Adam Barth.
3416
3417         make status-bubble white-space:nowrap so we can measure it's width without wrapping
3418         https://bugs.webkit.org/show_bug.cgi?id=51149
3419
3420         * QueueStatusServer/templates/statusbubble.html:
3421
3422 2010-12-15  Ojan Vafai  <ojan@chromium.org>
3423
3424         Reviewed by Adam Barth.
3425
3426         have the statusbubble postMessage it's metrics so that embedders can properly size the iframe
3427         https://bugs.webkit.org/show_bug.cgi?id=51125
3428
3429         * QueueStatusServer/templates/statusbubble.html:
3430
3431 2010-12-15  Darin Adler  <darin@apple.com>
3432
3433         * Scripts/webkitpy/common/net/buildbot: Added property svn:ignore.
3434
3435 2010-12-15  Sheriff Bot  <webkit.review.bot@gmail.com>
3436
3437         Unreviewed, rolling out r74117.
3438         http://trac.webkit.org/changeset/74117
3439         https://bugs.webkit.org/show_bug.cgi?id=51113
3440
3441         This broke the GTK1 build. (Requested by mrobinson on
3442         #webkit).
3443
3444         * Scripts/webkitdirs.pm:
3445
3446 2010-12-15  Amruth Raj  <amruthraj@motorola.com> and Ravi Kasibhatla  <ravi.kasibhatla@motorola.com>
3447
3448         Reviewed by Martin Robinson.
3449
3450         Change generate-forwarding-headers.pl for GTK port usage 
3451         (https://bugs.webkit.org/show_bug.cgi?id=37369)
3452
3453         * Scripts/webkitdirs.pm: Added changes to build webkit2 for GTK port using build-webkit script.
3454
3455 2010-12-14  Kent Tamura  <tkent@chromium.org>
3456
3457         Reviewed by Jian Li.
3458
3459         [DRT/Chromium] Remove another unnecessary error message
3460         https://bugs.webkit.org/show_bug.cgi?id=51083
3461
3462         * DumpRenderTree/chromium/WebViewHost.cpp:
3463         (WebViewHost::didInvalidateRect):
3464
3465 2010-12-14  Lucas Forschler  <lforschler@apple.com>
3466
3467         Reviewed by Stephanie Lewis.
3468
3469         Add a new Leopard Debug Test WK2 Bot
3470
3471         * BuildSlaveSupport/build.webkit.org-config/config.json:
3472
3473 2010-12-14  Ojan Vafai  <ojan@chromium.org>
3474
3475         Fix python unittests after http://trac.webkit.org/changeset/74070.
3476
3477         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
3478
3479 2010-12-14  Kent Tamura  <tkent@chromium.org>
3480
3481         Reviewed by Jian Li.
3482
3483         [DRT/Chromium] Remove a unnecessary error message
3484         https://bugs.webkit.org/show_bug.cgi?id=51069
3485
3486         * DumpRenderTree/chromium/WebViewHost.cpp:
3487         (WebViewHost::paintInvalidatedRegion):
3488
3489 2010-12-14  Benjamin Kalman  <kalman@chromium.org>
3490
3491         Reviewed by Ojan Vafai.
3492
3493         Using BUG/BUGWK in test_expectations is error prone, should use BUGCR/BUGWK
3494         https://bugs.webkit.org/show_bug.cgi?id=48926
3495
3496         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
3497         Add presubmit check that BUG isn't used, either BUGCR/BUGWK/BUGV8_.
3498
3499 2010-12-14  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3500
3501         Reviewed by Eric Seidel.
3502
3503         [Qt] [Symbian] Do not use pkg-config on Symbian as it is not supported
3504         https://bugs.webkit.org/show_bug.cgi?id=50231
3505
3506         Guard CONFIG+=link_pkgconfig with !symbian.
3507
3508         * DumpRenderTree/qt/DumpRenderTree.pro:
3509         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3510         * WebKitTestRunner/qt/WebKitTestRunner.pro:
3511
3512 2010-12-14  Philippe Normand  <pnormand@igalia.com>
3513
3514         Reviewed by Ojan Vafai.
3515
3516         [new-run-webkit-tests] expectations parsing is slow
3517         https://bugs.webkit.org/show_bug.cgi?id=50635
3518
3519         Avoid expensive iteration of all the tests when checking if a test
3520         file is to be skipped or not.
3521
3522         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
3523         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
3524         * Scripts/webkitpy/layout_tests/port/test.py:
3525
3526 2010-12-14  Mario Sanchez Prada  <msanchez@igalia.com>
3527
3528         Reviewed by Xan Lopez.
3529
3530         [Gtk] Implement STATE_FOCUSED, STATE_FOCUSABLE, and corresponding events for text objects
3531         https://bugs.webkit.org/show_bug.cgi?id=27048
3532
3533         Add support in DRT for checking whether an accessibility UI
3534         element is focusable and/or focused. Implemented for GTK.
3535
3536         * DumpRenderTree/AccessibilityUIElement.cpp:
3537         (getIsFocusedCallback): New.
3538         (getIsFocusableCallback): New.
3539         (AccessibilityUIElement::getJSClass): Add the new available
3540         callbacks for isFocused and isFocusable.
3541         * DumpRenderTree/AccessibilityUIElement.h:
3542         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3543         (AccessibilityUIElement::isFocused): New, implemented by checking
3544         whether the related AtkState value is in the object's state set.
3545         (AccessibilityUIElement::isFocusable): Ditto.
3546         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3547         (AccessibilityUIElement::isFocused): New, dummy implementation.
3548         (AccessibilityUIElement::isFocusable): Ditto.
3549         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3550         (AccessibilityUIElement::isFocused): Ditto.
3551         (AccessibilityUIElement::isFocusable): Ditto.
3552
3553 2010-12-14  Eric Seidel  <eric@webkit.org>
3554
3555         Reviewed by Ojan Vafai.
3556
3557         webkit-patch should warn users when they're using a 32-bit git on a 64-bit system
3558         https://bugs.webkit.org/show_bug.cgi?id=50715
3559
3560         This patch makes webkit-patch print the following:
3561
3562         Warning: This machine is 64-bit, but the git binary (/usr/local/git/bin/git) does not support 64-bit.
3563         Install a 64-bit git for better performance, see:
3564         https://lists.webkit.org/pipermail/webkit-dev/2010-December/015249.html
3565
3566         I wrote this mostly because I have approximately 8 machines that I use
3567         and making sure each one is using a good Git install seemed folly.
3568         webkit-patch makes a lot of git calls, so using a fast git can shave
3569         several seconds in every invocation.  See the webkit-dev thread for more info.
3570
3571         This message will print twice during 'webkit-patch upload',
3572         once from webkit-patch and once from check-webkit-style.
3573
3574         Unfortunately there is no good way to test this due to how machine-dependent
3575         the code is.  I considered writing a test for the log message, but it seemed not worth it.
3576
3577         * Scripts/webkitpy/common/checkout/scm.py:
3578
3579 2010-12-13  Eric Seidel  <eric@webkit.org>
3580
3581         Reviewed by Adam Barth.
3582
3583         FlakyTestReporter doesn't understand bots running from multiple email addresses
3584         https://bugs.webkit.org/show_bug.cgi?id=50960
3585
3586         This explains at least one of the dupes of:
3587         https://bugs.webkit.org/show_bug.cgi?id=50863
3588         that we saw filed by the commit-queue this morning.
3589         I think the other one was explained by my previous fix to result counting code.
3590
3591         Since this is really hard to test with a unit test, instead I
3592         create a new (possibly useful in the future) command
3593         which given a layout test path will return you
3594         the one bug which our tools would assume it the flaky test bug.
3595         If some other script wants to use bug-for-test we'll
3596         need to extend it with some options like --create-if-missing or similar.
3597
3598         * Scripts/webkitpy/common/net/bugzilla/bug.py:
3599         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3600         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3601         * Scripts/webkitpy/tool/commands/__init__.py:
3602         * Scripts/webkitpy/tool/commands/bugfortest.py: Added.
3603
3604 2010-12-13  Mihai Parparita  <mihaip@chromium.org>
3605
3606         Reviewed by James Robinson.
3607
3608         Add option to build-webkit to not build WebKit2
3609         https://bugs.webkit.org/show_bug.cgi?id=50988
3610         
3611         Add support for a --no-webkit2 option to build-webkit. It seems to save
3612         ~1 minute from clean builds and ~10 seconds from no-op builds.
3613
3614         * Scripts/build-webkit:
3615
3616 2010-12-13  Lucas Forschler  <lforschler@apple.com>
3617
3618         Reviewed by Dave Kilzer.
3619
3620         Update iexploder from 1.3.2 to 1.7.2
3621         Move 1.3.2 into its own subdir
3622         Add 1.7.2 into its own subdir
3623         update scripts to point to new 1.3.2 location (avoid breaking existing scripts)
3624
3625         * Scripts/run-iexploder-tests:
3626         * Scripts/update-iexploder-cssproperties:
3627         * iExploder/CHANGELOG.txt: Removed.
3628         * iExploder/LICENSE.txt: Removed.
3629         * iExploder/README.txt: Removed.
3630         * iExploder/htdocs: Removed.
3631         * iExploder/iexploder-1.3.2: Added.
3632         * iExploder/iexploder-1.3.2/CHANGELOG.txt: Copied from iExploder/CHANGELOG.txt.
3633         * iExploder/iexploder-1.3.2/LICENSE.txt: Copied from iExploder/LICENSE.txt.
3634         * iExploder/iexploder-1.3.2/README.txt: Copied from iExploder/README.txt.
3635         * iExploder/iexploder-1.3.2/htdocs: Added.
3636         * iExploder/iexploder-1.3.2/htdocs/config.rb: Copied from iExploder/htdocs/config.rb.
3637         * iExploder/iexploder-1.3.2/htdocs/cssproperties.in: Copied from iExploder/htdocs/cssproperties.in.
3638         * iExploder/iexploder-1.3.2/htdocs/cssvalues.in: Copied from iExploder/htdocs/cssvalues.in.
3639         * iExploder/iexploder-1.3.2/htdocs/htmlattrs.in: Copied from iExploder/htdocs/htmlattrs.in.
3640         * iExploder/iexploder-1.3.2/htdocs/htmltags.in: Copied from iExploder/htdocs/htmltags.in.
3641         * iExploder/iexploder-1.3.2/htdocs/htmlvalues.in: Copied from iExploder/htdocs/htmlvalues.in.
3642         * iExploder/iexploder-1.3.2/htdocs/iexploder.cgi: Copied from iExploder/htdocs/iexploder.cgi.
3643         * iExploder/iexploder-1.3.2/htdocs/iexploder.rb: Copied from iExploder/htdocs/iexploder.rb.
3644         * iExploder/iexploder-1.3.2/htdocs/index.html: Copied from iExploder/htdocs/index.html.
3645         * iExploder/iexploder-1.3.2/htdocs/webserver.rb: Copied from iExploder/htdocs/webserver.rb.
3646         * iExploder/iexploder-1.3.2/tools: Added.
3647         * iExploder/iexploder-1.3.2/tools/lasthit.rb: Copied from iExploder/tools/lasthit.rb.
3648         * iExploder/iexploder-1.3.2/tools/osx_last_crash.rb: Copied from iExploder/tools/osx_last_crash.rb.
3649         * iExploder/iexploder-1.3.2/tools/showtest.rb: Copied from iExploder/tools/showtest.rb.
3650         * iExploder/iexploder-1.7.2: Added.
3651         * iExploder/iexploder-1.7.2/ChangeLog.txt: Added.
3652         * iExploder/iexploder-1.7.2/LICENSE.txt: Added.
3653         * iExploder/iexploder-1.7.2/README.txt: Added.
3654         * iExploder/iexploder-1.7.2/output: Added.
3655         * iExploder/iexploder-1.7.2/src: Added.
3656         * iExploder/iexploder-1.7.2/src/browser_harness.rb: Added.
3657         * iExploder/iexploder-1.7.2/src/config.yaml: Added.
3658         * iExploder/iexploder-1.7.2/src/css-atrules: Added.
3659         * iExploder/iexploder-1.7.2/src/css-atrules/mozilla: Added.
3660         * iExploder/iexploder-1.7.2/src/css-atrules/webkit: Added.
3661         * iExploder/iexploder-1.7.2/src/css-properties: Added.
3662         * iExploder/iexploder-1.7.2/src/css-properties/dillo: Added.
3663         * iExploder/iexploder-1.7.2/src/css-properties/gtkhtml: Added.
3664         * iExploder/iexploder-1.7.2/src/css-properties/internet_explorer6: Added.
3665         * iExploder/iexploder-1.7.2/src/css-properties/mozilla: Added.
3666         * iExploder/iexploder-1.7.2/src/css-properties/webkit: Added.
3667         * iExploder/iexploder-1.7.2/src/css-pseudo: Added.
3668         * iExploder/iexploder-1.7.2/src/css-pseudo/mozilla: Added.
3669         * iExploder/iexploder-1.7.2/src/css-pseudo/webkit: Added.
3670         * iExploder/iexploder-1.7.2/src/css-values: Added.
3671         * iExploder/iexploder-1.7.2/src/css-values/dillo: Added.
3672         * iExploder/iexploder-1.7.2/src/css-values/gtkhtml: Added.
3673         * iExploder/iexploder-1.7.2/src/css-values/mozilla: Added.
3674         * iExploder/iexploder-1.7.2/src/css-values/other: Added.
3675         * iExploder/iexploder-1.7.2/src/css-values/webkit: Added.
3676         * iExploder/iexploder-1.7.2/src/headers: Added.
3677         * iExploder/iexploder-1.7.2/src/headers/dillo: Added.
3678         * iExploder/iexploder-1.7.2/src/headers/gtkhtml: Added.
3679         * iExploder/iexploder-1.7.2/src/headers/mozilla: Added.
3680         * iExploder/iexploder-1.7.2/src/headers/webkit: Added.
3681         * iExploder/iexploder-1.7.2/src/html-attrs: Added.
3682         * iExploder/iexploder-1.7.2/src/html-attrs/dillo: Added.
3683         * iExploder/iexploder-1.7.2/src/html-attrs/gtkhtml: Added.
3684         * iExploder/iexploder-1.7.2/src/html-attrs/internet_explorer6: Added.
3685         * iExploder/iexploder-1.7.2/src/html-attrs/mozilla: Added.
3686         * iExploder/iexploder-1.7.2/src/html-attrs/other: Added.
3687         * iExploder/iexploder-1.7.2/src/html-attrs/webkit: Added.
3688         * iExploder/iexploder-1.7.2/src/html-tags: Added.
3689         * iExploder/iexploder-1.7.2/src/html-tags/dillo: Added.
3690         * iExploder/iexploder-1.7.2/src/html-tags/gtkhtml: Added.
3691         * iExploder/iexploder-1.7.2/src/html-tags/mozilla: Added.
3692         * iExploder/iexploder-1.7.2/src/html-tags/other: Added.
3693         * iExploder/iexploder-1.7.2/src/html-tags/webkit: Added.
3694         * iExploder/iexploder-1.7.2/src/html-values: Added.
3695         * iExploder/iexploder-1.7.2/src/html-values/dillo: Added.
3696         * iExploder/iexploder-1.7.2/src/html-values/gtkhtml: Added.
3697         * iExploder/iexploder-1.7.2/src/html-values/mozilla: Added.
3698         * iExploder/iexploder-1.7.2/src/html-values/other: Added.
3699         * iExploder/iexploder-1.7.2/src/html-values/webkit: Added.
3700         * iExploder/iexploder-1.7.2/src/iexploder.cgi: Added.
3701         * iExploder/iexploder-1.7.2/src/iexploder.rb: Added.
3702         * iExploder/iexploder-1.7.2/src/index.html: Added.
3703         * iExploder/iexploder-1.7.2/src/media: Added.
3704         * iExploder/iexploder-1.7.2/src/media/blank.ogg: Added.
3705         * iExploder/iexploder-1.7.2/src/media/blank.snd: Added.
3706         * iExploder/iexploder-1.7.2/src/media/blank.wav: Added.
3707         * iExploder/iexploder-1.7.2/src/media/bug.bmp: Added.
3708         * iExploder/iexploder-1.7.2/src/media/bug.gif: Added.
3709         * iExploder/iexploder-1.7.2/src/media/bug.ico: Added.
3710         * iExploder/iexploder-1.7.2/src/media/bug.jng: Added.
3711         * iExploder/iexploder-1.7.2/src/media/bug.jpg: Added.
3712         * iExploder/iexploder-1.7.2/src/media/bug.png: Added.
3713         * iExploder/iexploder-1.7.2/src/media/bug.svg: Added.
3714         * iExploder/iexploder-1.7.2/src/media/bug.tiff: Added.
3715         * iExploder/iexploder-1.7.2/src/media/bug.xbm: Added.
3716         * iExploder/iexploder-1.7.2/src/media/bug.xpm: Added.
3717         * iExploder/iexploder-1.7.2/src/mime-types: Added.
3718         * iExploder/iexploder-1.7.2/src/mime-types/dillo: Added.
3719         * iExploder/iexploder-1.7.2/src/mime-types/mozilla: Added.
3720         * iExploder/iexploder-1.7.2/src/mime-types/webkit: Added.
3721         * iExploder/iexploder-1.7.2/src/protocols: Added.
3722         * iExploder/iexploder-1.7.2/src/protocols/dillo: Added.
3723         * iExploder/iexploder-1.7.2/src/protocols/gtkhtml: Added.
3724         * iExploder/iexploder-1.7.2/src/protocols/mozilla: Added.
3725         * iExploder/iexploder-1.7.2/src/protocols/webkit: Added.
3726         * iExploder/iexploder-1.7.2/src/scanner.rb: Added.
3727         * iExploder/iexploder-1.7.2/src/version.rb: Added.
3728         * iExploder/iexploder-1.7.2/src/webserver.rb: Added.
3729         * iExploder/iexploder-1.7.2/testcases: Added.
3730         * iExploder/iexploder-1.7.2/testcases/testcase-Linux_x86_64_rv2.0b6pre_Gecko-20100904_Firefox-4.0b6pre-TEST-8375-1_59.html: Added.
3731         * iExploder/iexploder-1.7.2/testcases/testcase-Opera-9.80_Linux_x86_64_en_Presto-2.6.30_Version-10.61-16704-3_108,3.html: Added.
3732         * iExploder/iexploder-1.7.2/testcases/testcase-U_Intel_Mac_OS_X_10_6_4_en-US_AppleWebKit-534.8_Chrome-7.0.529.0-TEST-611-3_36,9.html: Added.
3733         * iExploder/iexploder-1.7.2/testcases/testcase-U_Intel_Mac_OS_X_10_6_4_en-US_AppleWebKit-534.8_hrome-7.0.529.0-TEST-55313622206-3_6,0.html: Added.
3734         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.6_Chrome-7.0.503.1-TEST-120813-8_72,56,24,8,0.html: Added.
3735         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.6_Chrome-7.0.503.1-TEST-121240-3_81,3.html: Added.
3736         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.7_Chrome-7.0.513.0-4800-5_80,65,15.html: Added.
3737         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.7_Chrome-7.0.513.0-TEST-23583190347-3_15,12.html: Added.
3738         * iExploder/iexploder-1.7.2/tools: Added.
3739         * iExploder/iexploder-1.7.2/tools/lasthit.rb: Added.
3740         * iExploder/iexploder-1.7.2/tools/osx_last_crash.rb: Added.