Workaround for simctl launch bug
[WebKit.git] / Tools / ChangeLog
1 2017-01-30  Jonathan Bedard  <jbedard@apple.com>
2
3         Workaround for simctl launch bug
4         https://bugs.webkit.org/show_bug.cgi?id=167613
5
6         Reviewed by Daniel Bates.
7
8         simctl launch will sometimes fail because of a race condition when many
9         simulators are being run simultaneously. These failures will always have
10         an exit code of 1. This change attempts to launch an app multiple times
11         before reporting a failure to workaround this bug.
12
13         * Scripts/webkitpy/xcode/simulator.py:
14         (Device.launch_app): Execute multiple launch attempts, better logging of failures.
15
16 2017-01-30  Alexey Proskuryakov  <ap@apple.com>
17
18         Commit queue fails to look at real name aliases for the reviewer
19         https://bugs.webkit.org/show_bug.cgi?id=167422
20
21         Reviewed by Joseph Pecoraro.
22
23         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
24         (test_has_valid_reviewer): Added tests.
25
26         * Scripts/webkitpy/common/config/committers.py:
27         (CommitterList._name_to_contributor_map):
28         Made _name_to_contributor_map include alias names.
29
30         * Scripts/webkitpy/common/config/committers_unittest.py:
31         (CommittersTest.test_contributors_by_fuzzy_match):
32         Removed subtests that are now obsolete, as these matches are strict. It is not
33         obvious if distance based fuzzy matching for names is useful at all, but we can
34         look into that some other time.
35
36 2017-01-30  Aakash Jain  <aakash_jain@apple.com>
37
38         QueueStatusServer should have an explicit timeout for _fetch_url
39         https://bugs.webkit.org/show_bug.cgi?id=167467
40
41         Reviewed by Alexey Proskuryakov.
42
43         * Scripts/webkitpy/common/net/statusserver.py:
44         (StatusServer._fetch_url): Add an explicit timeout of 300s.
45
46 2017-01-30  Kocsen Chung  <kocsen_chung@apple.com>
47
48         Add support for Trac instances that host multiple projects.
49         https://bugs.webkit.org/show_bug.cgi?id=167524
50
51         Reviewed by Alexey Proskuryakov.
52
53         When multiple projects are hosted on a single Trac instance, the current
54         behavior will retrieve changesets from all tracked projects.
55         This patch teaches Trac.js to get project-specific changesets from Trac.
56         We do this by replacing the parameter `changeset=on` to `repo-projectname=on`
57         when querying the Trac timeline.
58
59         To tell Trac to be aware of multi-project instances we leverage the 
60         `options` parameter when creating a new instance: 
61
62             new Trac("https://mytrac.com/", { projectIdentifier: "tracProjectName" });
63
64         If this option is not provided, the original behaviour will prevail.
65         Additionally, add corresponding tests.
66
67         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
68         (Trac): Reason about new optional parameter 'projectIdentifier'.
69         (Trac.prototype.revisionURL): Given a projectIdentifier, append it to the end of the URL.
70         (Trac.prototype._xmlTimelineURL): Given a projectIdentifier,
71         replace default parameter `changeset=on` with `repo-projectname=on`.
72         (Trac.prototype._convertCommitInfoElementToObject): Fix missing ';'.
73         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockTrac.js:
74         (MockTrac): Add support for instantiating Trac with a projectIdentifier.
75         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/tests.js:
76         (setup): Provide a multiple-project MockTrac instance to all test cases for testing.
77         Add the following tests:
78             test("revisionURL")
79             test("revisionURL with Trac Identifier")
80             test("_xmlTimelineURL")
81             test("_xmlTimelineURL with Trac Identifier")
82         (this.view._latestProductiveIteration): Fix missing ';'.
83
84 2017-01-30  Myles C. Maxfield  <mmaxfield@apple.com>
85
86         Correct spacing regression on inter-element complex path shaping on some fonts
87         https://bugs.webkit.org/show_bug.cgi?id=166013
88
89         Reviewed by Simon Fraser.
90
91         Unskip existing tests and make some new tests:
92         - Testing complex text with no origins
93         - Testing initial expansions
94         - Testing the sign of vertical advances
95
96         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
97         (TestWebKitAPI::TEST_F):
98
99 2017-01-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
100
101         [GTK][EFL] Avoid using a thin directory to create the built product on the archive-built-product step.
102         https://bugs.webkit.org/show_bug.cgi?id=167596
103
104         Reviewed by Daniel Bates.
105
106         We avoid needing a thin directory by invoking the zip program with
107         the list of directories from the build directory to be zipped,
108         and by using the zip feature to exclude files matching a pattern.
109
110         * BuildSlaveSupport/built-product-archive:
111         (copyBuildFiles):
112         (createZipFromList):
113         (archiveBuiltProduct):
114
115 2017-01-30  Jonathan Bedard  <jbedard@apple.com>
116
117         Use simctl instead of LayoutTestRelay
118         https://bugs.webkit.org/show_bug.cgi?id=165927
119
120         Reviewed by Daniel Bates.
121
122         Part 1
123
124         LayoutTestRelay uses SPI, since recent versions of the iOS SDK allow for installing apps on
125         simulators through simctl (iOS 10 and later), use this functionality instead.
126
127         * Scripts/webkitpy/port/base.py:
128         (Port.__init__): Added _test_runner_process_constructor.
129         * Scripts/webkitpy/port/darwin.py:
130         (DarwinPort.app_identifier_from_bundle): Added function to extract bundle ID from plist.
131         * Scripts/webkitpy/port/driver.py:
132         (Driver._start): Pass worker_number to server_process so we can look up the correct simulator device to use.
133         (IOSSimulatorDriver): Deleted.
134         * Scripts/webkitpy/port/driver_unittest.py:
135         (DriverTest.test_stop_cleans_up_properly): Set _test_runner_process_constructor for testing.
136         (DriverTest.test_two_starts_cleans_up_properly): Ditto.
137         (DriverTest.test_start_actually_starts): Ditto.
138         * Scripts/webkitpy/port/ios.py:
139         (IOSSimulatorPort): Remove relay_name.
140         (IOSSimulatorPort.__init__): Set _test_runner_process_constructor to SimulatorProcess for IOSSimulatorPort.
141         (IOSSimulatorPort._create_simulators): Formatting change.
142         (IOSSimulatorPort.relay_path): Deleted.
143         (IOSSimulatorPort._check_relay): Deleted.
144         (IOSSimulatorPort._check_port_build): Deleted. Use base class implementation
145         (IOSSimulatorPort._build_relay): Deleted.
146         (IOSSimulatorPort._build_driver): Deleted. Use base class implementation
147         (IOSSimulatorPort._driver_class): Deleted. Use base class implementation
148         * Scripts/webkitpy/port/ios_unittest.py:
149         (iosTest.test_32bit): Update test.
150         (iosTest.test_64bit): Update test.
151         * Scripts/webkitpy/port/server_process.py:
152         (ServerProcess.__init__): Added argument worker_number. This class does not make use of it. We will make use of this argument in SimulatorProcess to lookup the associated simulator device.
153         (ServerProcess._set_file_nonblocking): Added to share common code.
154         * Scripts/webkitpy/port/server_process_mock.py:
155         (MockServerProcess.__init__): Added argument worker_number.
156         * Scripts/webkitpy/port/simulator_process.py: Added.
157         (SimulatorProcess): Added.
158         (SimulatorProcess.Popen): Added.
159         (SimulatorProcess.Popen.__init__): Added. Initialize Popen structure with stdin, stdout, stderr and pid.
160         (SimulatorProcess.Popen.poll): Added. Check if the process is running.
161         (SimulatorProcess.Popen.wait): Added. Wait for process to close.
162         (SimulatorProcess.__init__): Added. Install app to device specified through port and worker_number.
163         (SimulatorProcess._reset): Added. Unlink fifos.
164         (SimulatorProcess._start): Added. Launch app on simulator, link fifos.
165         (SimulatorProcess._kill): Added. Shutdown app on simulator.
166         * Scripts/webkitpy/xcode/simulator.py:
167         (Device.__init__): Accept host to run install/launch/terminate.
168         (Device.install_app): Install app to target Device.
169         (Device.launch_app): Launch app on target Device.
170         (Device.terminate_app): Shutdown app on target Device.
171         (Simulator._parse_devices): Pass host to Device.
172
173 2017-01-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
174
175         [GTK] pixman fails to compile on Raspberry Pi (GCC crash)
176         https://bugs.webkit.org/show_bug.cgi?id=167411
177
178         Reviewed by Michael Catanzaro.
179
180         Disable the ARM iwMMXt fast path for pixman, because it triggers
181         a GCC bug on the RPi with Raspbian/PIXEL causing a build failure.
182
183         * gtk/jhbuild.modules:
184
185 2017-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
186
187         [GTK] Add API to handle the accelerated compositing policy
188         https://bugs.webkit.org/show_bug.cgi?id=167509
189
190         Reviewed by Michael Catanzaro.
191
192         Handle new setting in MiniBrowser. The settings dialog doesn't support enum settings so it needs to be handled
193         as a special case. Also add test cases to the get/set API.
194
195         * MiniBrowser/gtk/BrowserSettingsDialog.c:
196         (hardwareAccelerationPolicyToString):
197         (stringToHardwareAccelerationPolicy):
198         (cellRendererChanged):
199         (browserSettingsDialogConstructed):
200         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
201         (testWebKitSettings):
202
203 2017-01-29  Andy Estes  <aestes@apple.com>
204
205         [QuickLook] Add a WebPreference to enable saving QuickLook documents in WebKitLegacy
206         https://bugs.webkit.org/show_bug.cgi?id=167563
207         <rdar://problem/30253207>
208
209         Reviewed by Andreas Kling.
210
211         * TestWebKitAPI/Tests/WebKit2Cocoa/QuickLook.mm:
212         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
213         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
214         (runTest):
215         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
216         (TEST):
217
218 2017-01-29  Dan Bernstein  <mitz@apple.com>
219
220         [iOS] Expose WebCore::DataDetection::detectContentInRange WKWebProcessPlugInRangeHandle
221         https://bugs.webkit.org/show_bug.cgi?id=167565
222
223         Reviewed by Sam Weinig.
224
225         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
226         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandle.mm: Added.
227         (-[BundleRangeHandleRemoteObject textFromBodyRange:]):
228         (-[BundleRangeHandleRemoteObject bodyInnerHTMLAfterDetectingData:]):
229         (TEST):
230         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandlePlugIn.mm: Added.
231         (-[BundleRangeHandlePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
232         (-[BundleRangeHandlePlugIn webProcessPlugInBrowserContextController:didFinishDocumentLoadForFrame:]):
233         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandleProtocol.h: Added.
234
235 2017-01-28  Yoav Weiss  <yoav@yoav.ws>
236
237         Add Link Preload as an off-by-default experimental feature menu item.
238         https://bugs.webkit.org/show_bug.cgi?id=167201
239
240         Reviewed by Ryosuke Niwa.
241
242         * DumpRenderTree/mac/DumpRenderTree.mm:
243         (resetWebPreferencesToConsistentValues):
244         * DumpRenderTree/win/DumpRenderTree.cpp:
245         (resetWebPreferencesToConsistentValues):
246
247 2017-01-28  Joseph Pecoraro  <pecoraro@apple.com>
248
249         Add User Timing Experimental Feature
250         https://bugs.webkit.org/show_bug.cgi?id=167542
251         <rdar://problem/22746307>
252
253         Reviewed by Ryosuke Niwa.
254
255         * DumpRenderTree/mac/DumpRenderTree.mm:
256         (enableExperimentalFeatures):
257         (resetWebPreferencesToConsistentValues):
258         * DumpRenderTree/win/DumpRenderTree.cpp:
259         (enableExperimentalFeatures):
260
261 2017-01-28  Joseph Pecoraro  <pecoraro@apple.com>
262
263         Patch Review: EWS Bubbles wrap to multiple lines but can fit on one line
264         https://bugs.webkit.org/show_bug.cgi?id=167519
265
266         Reviewed by Ryosuke Niwa.
267
268         * QueueStatusServer/templates/statusbubble.html:
269         To measure the bubbleContainer's width, it must not be wrapping based
270         on its parent container. So when measuring the width temporarily set
271         the parent to a very large width so as to not artificially wrap us.
272         Restore the parent's width after measuring.
273
274 2017-01-27  Andy Estes  <aestes@apple.com>
275
276         [iOS] Add a test for _WKNSFileManagerExtras
277         https://bugs.webkit.org/show_bug.cgi?id=167478
278
279         Reviewed by Andreas Kling.
280
281         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
282         * TestWebKitAPI/Tests/WebKit2Cocoa/NSFileManagerExtras.mm: Added.
283         (expectAttributes):
284         (TEST):
285
286 2017-01-27  Keith Miller  <keith_miller@apple.com>
287
288         run-benchmarks should make sure it passes the test url to the right application
289         https://bugs.webkit.org/show_bug.cgi?id=167533
290
291         Reviewed by Joseph Pecoraro.
292
293         This fixes an issue when trying to run-benchmark script with the
294         system default browser set to STP. Previously, it would run
295         the test in STP rather than the provided build. Now, it should run
296         in the provided build.
297
298         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
299         (OSXSafariDriver.launch_url):
300
301 2017-01-27  Myles C. Maxfield  <mmaxfield@apple.com>
302
303         [Cocoa] Prepare ComplexTextController for unit testing
304         https://bugs.webkit.org/show_bug.cgi?id=167493
305
306         Reviewed by Simon Fraser.
307
308         Addressing post-review comments from Simon Fraser.
309
310         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
311         (TestWebKitAPI::TEST_F):
312
313 2017-01-27  Myles C. Maxfield  <mmaxfield@apple.com>
314
315         [Cocoa] Prepare ComplexTextController for unit testing
316         https://bugs.webkit.org/show_bug.cgi?id=167493
317
318         Reviewed by Dean Jackson.
319
320         Create four unit tests.
321
322         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
323         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp: Added.
324         (TestWebKitAPI::ComplexTextControllerTest::SetUp):
325         (TestWebKitAPI::TEST_F):
326
327 2017-01-26  Chris Dumez  <cdumez@apple.com>
328
329         Crash when navigating back to a page in PacheCache when one of its frames has been removed
330         https://bugs.webkit.org/show_bug.cgi?id=167421
331         <rdar://problem/30188490>
332
333         Reviewed by Darin Adler.
334
335         Add a new setting allowing layout tests to enable PageCache in a window
336         that has an opener, for convenience.
337
338         * DumpRenderTree/mac/DumpRenderTree.mm:
339         (resetWebPreferencesToConsistentValues):
340         * DumpRenderTree/win/DumpRenderTree.cpp:
341         (resetWebPreferencesToConsistentValues):
342         * WebKitTestRunner/TestController.cpp:
343         (WTR::TestController::resetPreferencesToConsistentValues):
344
345 2017-01-26  Keith Miller  <keith_miller@apple.com>
346
347         classInfo should take a VM so it is not materialized from the object on each call
348         https://bugs.webkit.org/show_bug.cgi?id=167424
349
350         Rubber Stamped by Michael Saboff.
351
352         Previously, classInfo() would get the VM from the target's
353         MarkedBlock.  Most callers already have a VM on hand, so it is
354         wasteful to compute the VM from the marked block every time. This
355         patch refactors some of the most common callers of classInfo(),
356         jsDynamicCast and inherits to take a VM as well.
357
358         * DumpRenderTree/TestRunner.cpp:
359         (setAudioResultCallback):
360
361 2017-01-26  Jer Noble  <jer.noble@apple.com>
362
363         Autoplay muted videos stop playback of any streaming app in the background
364         https://bugs.webkit.org/show_bug.cgi?id=163993
365         <rdar://problem/29020431>
366
367         Reviewed by Eric Carlson.
368
369         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
370         * TestWebKitAPI/Tests/WebKit/ios/AudioSessionCategoryIOS.mm:
371         (TestWebKitAPI::TEST):
372         * TestWebKitAPI/Tests/WebKit/ios/video-with-muted-audio-and-webaudio.html: Added.
373
374 2017-01-26  Ryan Haddad  <ryanhaddad@apple.com>
375
376         Disable API test WebKit2.WebsitePoliciesPlayAfterPreventedAutoplay.
377         https://bugs.webkit.org/show_bug.cgi?id=167466
378
379         Unreviewed test gardening.
380
381         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
382         (TEST):
383
384 2017-01-26  Matt Rajca  <mrajca@apple.com>
385
386         Notify clients when the user plays media otherwise prevented from autoplaying
387         https://bugs.webkit.org/show_bug.cgi?id=167390
388
389         Reviewed by Alex Christensen.
390
391         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
392         * TestWebKitAPI/Tests/WebKit2/autoplay-with-controls.html: Added.
393         * TestWebKitAPI/Tests/WebKit2/js-play-with-controls.html: Added.
394         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
395         (didPlayMediaPreventedFromPlayingWithoutUserGesture):
396         (TEST):
397         * TestWebKitAPI/cocoa/TestWKWebView.h:
398         * TestWebKitAPI/cocoa/TestWKWebView.mm:
399         (-[TestWKWebViewHostWindow _mouseUpAtPoint:]):
400         (-[TestWKWebView waitForLoad]):
401         (-[TestWKWebView mouseUpAtPoint:]):
402         * WebKitTestRunner/TestController.cpp:
403         (WTR::TestController::createOtherPage):
404         (WTR::TestController::createWebViewWithOptions):
405
406 2017-01-26  Per Arne Vollan  <pvollan@apple.com>
407
408         Crash when setting custom scale factor.
409         https://bugs.webkit.org/show_bug.cgi?id=167369
410
411         Reviewed by Sam Weinig.
412
413         Added API test.
414
415         * TestWebKitAPI/PlatformWin.cmake:
416         * TestWebKitAPI/Tests/WebKit/win/ScaleWebView.cpp: Added.
417         (TestWebKitAPI::WebKitCreateInstance):
418         (TestWebKitAPI::ScaleWebView::SetUp):
419         (TestWebKitAPI::ScaleWebView::TearDown):
420         (TestWebKitAPI::TEST_F):
421
422 2017-01-25  Ryosuke Niwa  <rniwa@webkit.org>
423
424         run-benchmark nests MotionMark results by the suite name twice
425         https://bugs.webkit.org/show_bug.cgi?id=164948
426
427         Reviewed by Said Abou-Hallawa.
428
429         Use a single level MotionMark now that this is the name of the benchmark,
430         and we no longer have tests that aren't part of the MotionMark suite.
431
432         * Scripts/webkitpy/benchmark_runner/data/patches/MotionMark.patch:
433
434 2017-01-25  Ryan Haddad  <ryanhaddad@apple.com>
435
436         Unreviewed, rolling out r211193.
437
438         This change broke internal builds.
439
440         Reverted changeset:
441
442         "Notify clients when the user plays media otherwise prevented
443         from autoplaying"
444         https://bugs.webkit.org/show_bug.cgi?id=167390
445         http://trac.webkit.org/changeset/211193
446
447 2017-01-25  Matt Rajca  <mrajca@apple.com>
448
449         Notify clients when the user plays media otherwise prevented from autoplaying
450         https://bugs.webkit.org/show_bug.cgi?id=167390
451
452         Reviewed by Alex Christensen.
453
454         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
455         * TestWebKitAPI/Tests/WebKit2/autoplay-with-controls.html: Added.
456         * TestWebKitAPI/Tests/WebKit2/js-play-with-controls.html: Added.
457         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
458         (didPlayMediaPreventedFromPlayingWithoutUserGesture):
459         (TEST):
460         * TestWebKitAPI/cocoa/TestWKWebView.h:
461         * TestWebKitAPI/cocoa/TestWKWebView.mm:
462         (-[TestWKWebViewHostWindow _mouseUpAtPoint:]):
463         (-[TestWKWebView waitForLoad]):
464         (-[TestWKWebView mouseUpAtPoint:]):
465         * WebKitTestRunner/TestController.cpp:
466         (WTR::TestController::createOtherPage):
467         (WTR::TestController::createWebViewWithOptions):
468
469 2017-01-25  Matt Rajca  <mrajca@apple.com>
470
471         [ios-simulator] API test WebKit2.WebsitePoliciesAutoplayEnabled timing out
472         https://bugs.webkit.org/show_bug.cgi?id=167385
473
474         Reviewed by Alex Christensen.
475
476         * TestWebKitAPI/Tests/WebKit2/autoplay-check.html: Avoid arbitrary timeouts in favor of promises.
477         * TestWebKitAPI/Tests/WebKit2/autoplay-no-audio-check.html:
478         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
479         (TEST): Allow inline (rather than full screen) media playback on iOS.
480
481 2017-01-25  Carlos Garcia Campos  <cgarcia@igalia.com>
482
483         [GTK] Icon Database should be in private browsing mode for ephemeral web views
484         https://bugs.webkit.org/show_bug.cgi?id=167414
485
486         Reviewed by Michael Catanzaro.
487
488         Add a test case to check ephemeral web views don't write favicons to the database.
489
490         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:
491         (ephemeralViewLoadChanged):
492         (testPrivateBrowsing):
493         (testFaviconDatabase):
494
495 2017-01-25  Carlos Garcia Campos  <cgarcia@igalia.com>
496
497         [GTK] Add a private browsing mode to MiniBrowser
498         https://bugs.webkit.org/show_bug.cgi?id=167413
499
500         Reviewed by Michael Catanzaro.
501
502         Add -p/--private command line option to create a private instance. Also add CTRL+SHIFT+P shortcut to create
503         private windows, even on non-private instances.
504
505         * MiniBrowser/gtk/BrowserWindow.c:
506         (webViewTitleChanged): Add [Private] to title window for private windows.
507         (webViewCreate): Pass web context to browser_window_new.
508         (openPrivateWindow): Create a new ephemeral web view and add it to a new window.
509         (browserWindowFinalize): Disconnect web context signal handlers.
510         (browser_window_init): Add shortcut for opening private window.
511         (browser_window_new): It now receives the context and connect to download-started here.
512         (browser_window_get_web_context): Return the context.
513         * MiniBrowser/gtk/BrowserWindow.h:
514         * MiniBrowser/gtk/main.c:
515         (createBrowserTab): Create the web view for the window web context.
516         (aboutDataScriptMessageReceivedCallback): Do not use the default web context, but the window one.
517         (aboutDataHandleRequest): Ditto.
518         (aboutURISchemeRequestCallback): Ditto.
519         (main): Create ephemeral web context if private command line option is used.
520
521 2017-01-25  Ryosuke Niwa  <rniwa@webkit.org>
522
523         collectMatchingElementsInFlatTree should not find elements inside an user agent shadow tree
524         https://bugs.webkit.org/show_bug.cgi?id=167409
525
526         Reviewed by Antti Koivisto.
527
528         Added a test case for collectMatchingElementsInFlatTree not finding elements inside an user agent shadow tree
529         as well as tests for the newly added matchingElementInFlatTree.
530
531         * TestWebKitAPI/Tests/WebKit2/InjectedBundleMakeAllShadowRootsOpen.cpp:
532         (TestWebKitAPI::runJavaScriptAlert):
533         * TestWebKitAPI/Tests/WebKit2/InjectedBundleMakeAllShadowRootsOpen_Bundle.cpp:
534         (TestWebKitAPI::InjectedBundleMakeAllShadowRootOpenTest::initialize):
535         * TestWebKitAPI/Tests/WebKit2/closed-shadow-tree-test.html:
536
537 2017-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
538
539         [GTK] Add API to create ephemeral web views and deprecate the private browsing setting
540         https://bugs.webkit.org/show_bug.cgi?id=167370
541
542         Reviewed by Michael Catanzaro.
543
544         Add several test cases of ephemeral web views.
545
546         * TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp:
547         (testWebViewAuthenticationStorage):
548         * TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp:
549         (ephemeralViewloadChanged):
550         (testCookieManagerEphemeral):
551         (beforeAll):
552         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
553         (testWebKitSettings):
554         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
555         (testWebContextEphemeral):
556         (ephemeralViewloadChanged):
557         (testWebContextProxySettings):
558         (beforeAll):
559         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
560         (ephemeralViewloadChanged):
561         (testWebViewEphemeral):
562         (beforeAll):
563         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebsiteData.cpp:
564         (ephemeralViewloadChanged):
565         (testWebsiteDataEphemeral):
566         (beforeAll):
567
568 2017-01-24  Alex Christensen  <achristensen@webkit.org>
569
570         REGRESSION (r208902): URLWithUserTypedString returns nil with file URLs
571         https://bugs.webkit.org/show_bug.cgi?id=167402
572
573         Reviewed by Ryosuke Niwa.
574
575         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm:
576         (TestWebKitAPI::TEST):
577
578 2017-01-24  Zalan Bujtas  <zalan@apple.com>
579
580         Add simple line layout toggle to MiniBrowser
581         https://bugs.webkit.org/show_bug.cgi?id=167405
582
583         Reviewed by Andreas Kling.
584
585         * MiniBrowser/mac/SettingsController.h:
586         * MiniBrowser/mac/SettingsController.m:
587         (-[SettingsController _populateMenu]):
588         (-[SettingsController validateMenuItem:]):
589         (-[SettingsController toggleSimpleLineLayoutEnabled:]):
590         (-[SettingsController simpleLineLayoutEnabled]):
591         * MiniBrowser/mac/WK1BrowserWindowController.m:
592         (-[WK1BrowserWindowController didChangeSettings]):
593         * MiniBrowser/mac/WK2BrowserWindowController.m:
594         (-[WK2BrowserWindowController didChangeSettings]):
595
596 2017-01-24  Joseph Pecoraro  <pecoraro@apple.com>
597
598         WKR does not include my nick when commit-queue lands my patch
599         https://bugs.webkit.org/show_bug.cgi?id=167388
600
601         Reviewed by Ryosuke Niwa.
602
603         * Scripts/webkitpy/tool/commands/newcommitbot.py:
604         (NewCommitBot._summarize_commit_log):
605         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py:
606         Perform nickname insertion before grabbing "Patch by" details.
607         This way we can include the nickname with the full name.
608
609 2017-01-24  Joseph Pecoraro  <pecoraro@apple.com>
610
611         Fold USER_TIMING into WEB_TIMING and make it a RuntimeEnabledFeature
612         https://bugs.webkit.org/show_bug.cgi?id=167394
613
614         Reviewed by Ryosuke Niwa.
615
616         * Scripts/webkitperl/FeatureList.pm:
617         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
618
619 2017-01-24  Youenn Fablet  <youenn@apple.com>
620
621         [WebRTC] Use HAVE_PTHREAD_COND_TIMEDWAIT_RELATIVE for libwebrtc
622         https://bugs.webkit.org/show_bug.cgi?id=167353
623
624         Reviewed by Alex Christensen.
625
626         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
627         (CMakeGenerator.initialize_targets):
628
629 2017-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
630
631         WKR should not confuse Miguel Gomez with Andres Gomez
632         https://bugs.webkit.org/show_bug.cgi?id=167389
633
634         Reviewed by Lucas Forschler.
635
636         Andres's email is a substring of Miguel's, causing WKR to credit Miguel's commits to
637         "mAndres Gomez". Fix this.
638
639         * Scripts/webkitpy/tool/commands/newcommitbot.py:
640         (NewCommitBot._summarize_commit_log): Be stricter about matching emails. SVN logs include a
641         space on each side of the email address, so expect both spaces to be there before
642         considering the email for replacement.
643         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py: Add a test.
644
645 2017-01-24  Matt Rajca  <mrajca@apple.com>
646
647         Pass down website autoplay policies to media elements
648         https://bugs.webkit.org/show_bug.cgi?id=167355
649
650         Reviewed by Alex Christensen.
651
652         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
653         * TestWebKitAPI/Tests/WebKit2/autoplay-check.html: Renamed from Tools/TestWebKitAPI/Tests/WebKit2/autoplayCheck.html to match our naming conventions.
654         * TestWebKitAPI/Tests/WebKit2/autoplay-no-audio-check.html: Added.
655         * TestWebKitAPI/Tests/WebKit2/test-without-audio-track.mp4: Added.
656         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
657         (-[AutoplayPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
658         (TEST):
659
660 2017-01-24  Nan Wang  <n_wang@apple.com>
661
662         AX: Speak Selection does not work in an iframe
663         https://bugs.webkit.org/show_bug.cgi?id=166794
664         <rdar://problem/29913013>
665
666         Reviewed by Chris Fleizach.
667
668         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
669         (WTR::UIScriptController::retrieveSpeakSelectionContent):
670         (WTR::UIScriptController::accessibilitySpeakSelectionContent):
671         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
672         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
673         (WTR::UIScriptController::retrieveSpeakSelectionContent):
674         (WTR::UIScriptController::accessibilitySpeakSelectionContent):
675         * TestRunnerShared/UIScriptContext/UIScriptController.h:
676         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
677         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
678         (-[TestRunnerWKWebView dealloc]):
679         (-[TestRunnerWKWebView _accessibilityDidGetSpeakSelectionContent:]):
680         (-[TestRunnerWKWebView accessibilityRetrieveSpeakSelectionContentWithCompletionHandler:]):
681         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
682         (WTR::UIScriptController::retrieveSpeakSelectionContent):
683         (WTR::UIScriptController::accessibilitySpeakSelectionContent):
684
685 2017-01-24  Daniel Bates  <dabates@apple.com>
686
687         StringView.split() should use an iterator design pattern instead of allocating a Vector
688         https://bugs.webkit.org/show_bug.cgi?id=163225
689
690         Reviewed by Darin Adler.
691
692         Add unit tests for StringView.split().
693
694         * TestWebKitAPI/Tests/WTF/StringView.cpp:
695         (TestWebKitAPI::stringViewFromLiteral): Moved to the top of the file so that it can be
696         used in the StringView.split() unit tests.
697         (TestWebKitAPI::stringViewFromUTF8): Ditto.
698         (TestWebKitAPI::vectorFromSplitResult): Convenience function to convert a StringView::SplitResult
699         object to a Vector of String objects.
700         (TestWebKitAPI::TEST): Added the following tests:
701             - WTF.StringViewSplitEmptyAndNullStrings
702             - WTF.StringViewSplitBasic
703             - WTF.StringViewSplitWithConsecutiveSeparators
704
705 2017-01-23  Anders Carlsson  <andersca@apple.com>
706
707         The Score Esports crashes on launch
708         https://bugs.webkit.org/show_bug.cgi?id=167338
709         rdar://problem/29948645
710
711         Reviewed by Dan Bernstein.
712
713         * TestWebKitAPI/Tests/WebKit2Cocoa/WKObject.mm:
714         (TestWebKitAPI::TEST):
715         Add a test.
716
717 2017-01-23  Carlos Garcia Campos  <cgarcia@igalia.com>
718
719         [GTK] Add API to WebKitWebsiteDataManager to handle website data
720         https://bugs.webkit.org/show_bug.cgi?id=146589
721
722         Reviewed by Michael Catanzaro.
723
724         Add about:data handler to MiniBrowser to manually test the website data API. Also add unit tests to test all the
725         new API, moving the WebKitWebsiteDataManager configuration API to the new file too.
726
727         * MiniBrowser/gtk/BrowserWindow.c:
728         (webViewDecidePolicy):
729         (newTabCallback):
730         * MiniBrowser/gtk/main.c:
731         (createBrowserTab):
732         (aboutDataRequestFree):
733         (aboutDataRequestNew):
734         (aboutDataRequestForView):
735         (websiteDataRemovedCallback):
736         (websiteDataClearedCallback):
737         (aboutDataScriptMessageReceivedCallback):
738         (domainListFree):
739         (aboutDataFillTable):
740         (gotWebsiteDataCallback):
741         (aboutDataHandleRequest):
742         (aboutURISchemeRequestCallback):
743         (main):
744         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
745         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
746         (serverCallback):
747         (beforeAll):
748         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebsiteData.cpp: Added.
749         (serverCallback):
750         (WebsiteDataTest::WebsiteDataTest):
751         (WebsiteDataTest::~WebsiteDataTest):
752         (WebsiteDataTest::fetch):
753         (WebsiteDataTest::remove):
754         (WebsiteDataTest::clear):
755         (testWebsiteDataConfiguration):
756         (testWebsiteDataCache):
757         (testWebsiteDataStorage):
758         (testWebsiteDataDatabases):
759         (testWebsiteDataAppcache):
760         (beforeAll):
761         (afterAll):
762
763 2017-01-23  Commit Queue  <commit-queue@webkit.org>
764
765         Unreviewed, rolling out r211062.
766         https://bugs.webkit.org/show_bug.cgi?id=167354
767
768         broke API tests (Requested by alexchristensen on #webkit).
769
770         Reverted changeset:
771
772         "Pass down website autoplay policies to media elements"
773         https://bugs.webkit.org/show_bug.cgi?id=167132
774         http://trac.webkit.org/changeset/211062
775
776 2017-01-23  Alex Christensen  <achristensen@webkit.org>
777
778         URLParser should fail to parse percent-encoded invalid UTF-8 sequences
779         https://bugs.webkit.org/show_bug.cgi?id=167330
780
781         Reviewed by Tim Horton.
782
783         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
784         (TestWebKitAPI::TEST_F):
785
786 2017-01-23  Alex Christensen  <achristensen@webkit.org>
787
788         Make URLs with non-special schemes and a query or fragment but no slash after the host more compatible
789         https://bugs.webkit.org/show_bug.cgi?id=167317
790
791         Reviewed by Sam Weinig.
792
793         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
794         (TestWebKitAPI::TEST_F):
795
796 2017-01-23  Jonathan Bedard  <jbedard@apple.com>
797
798         svn-create-patch should emit properties when files are moved or copied
799         https://bugs.webkit.org/show_bug.cgi?id=167264
800
801         Reviewed by Daniel Bates.
802
803         * Scripts/svn-create-patch:
804         (manufacturePatchForAdditionWithHistory): Diff the source file against nothing to get properties.
805
806 2017-01-23  Youenn Fablet  <youenn@apple.com>
807
808         [WebRTC] Filter libwebrtc link flags
809         https://bugs.webkit.org/show_bug.cgi?id=167287
810
811         Reviewed by Alex Christensen.
812
813         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
814         (CMakeGenerator._compute_link_flags):
815         (CMakeGenerator._compute_link_flags.keep_flag):
816         (CMakeGenerator._generate_compile_target_options):
817
818 2017-01-23  Youenn Fablet  <youennf@gmail.com>
819
820         [WebRTC] Make VP8 optional in libwebrtc
821         https://bugs.webkit.org/show_bug.cgi?id=167257
822
823         Reviewed by Darin Adler.
824
825         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
826         (CMakeGenerator.remove_libvpx): Adding vp8_noop.cc to the build system.
827
828 2017-01-23  Jer Noble  <jer.noble@apple.com>
829
830         Video details does not apear and missing scrubber in Control Center
831         https://bugs.webkit.org/show_bug.cgi?id=167233
832
833         Reviewed by Alex Christensen.
834
835         Refactor TestWKWebViewMac to work on PLATFORM(IOS). Add a new test to
836         NowPlayingControlTests for iOS.
837
838         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
839         * TestWebKitAPI/Tests/WebKit2Cocoa/NowPlayingControlsTests.mm:
840         (-[NowPlayingTestWebView setWindowVisible:]):
841         (TestWebKitAPI::TEST):
842         * TestWebKitAPI/Tests/WebKit2Cocoa/SnapshotStore.mm:
843         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
844         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewCandidateTests.mm:
845         * TestWebKitAPI/cocoa/TestWKWebView.h: Renamed from Tools/TestWebKitAPI/mac/TestWKWebViewMac.h.
846         * TestWebKitAPI/cocoa/TestWKWebView.mm: Renamed from Tools/TestWebKitAPI/mac/TestWKWebViewMac.mm.
847         (SOFT_LINK_CLASS):
848         (-[TestMessageHandler addMessage:withHandler:]):
849         (-[TestMessageHandler userContentController:didReceiveScriptMessage:]):
850         (__simulated_forceClickAssociatedEventsMask):
851         (-[TestWKWebViewHostWindow _mouseDownAtPoint:simulatePressure:]):
852         (-[TestWKWebViewHostWindow isKeyWindow]):
853         (-[TestWKWebViewHostWindow makeKeyWindow]):
854         (-[TestWKWebViewHostWindow resignKeyWindow]):
855         (-[TestWKWebView initWithFrame:]):
856         (-[TestWKWebView initWithFrame:configuration:]):
857         (-[TestWKWebView _setUpTestWindow:]):
858         (-[TestWKWebView performAfterReceivingMessage:action:]):
859         (-[TestWKWebView loadTestPageNamed:]):
860         (-[TestWKWebView synchronouslyLoadTestPageNamed:]):
861         (-[TestWKWebView stringByEvaluatingJavaScript:]):
862         (-[TestWKWebView waitForMessage:]):
863         (-[TestWKWebView performAfterLoading:]):
864         (-[TestWKWebView mouseDownAtPoint:simulatePressure:]):
865         (-[TestWKWebView typeCharacter:]):
866
867 2017-01-21  Carlos Garcia Campos  <cgarcia@igalia.com>
868
869         Unreviewed. Bring back gtk-doc error messages after r209981.
870
871         Since r209981, if gtk-doc shows warnings the build fails but those warnings are not printed to stdout so it's
872         impossible to know what's wrong.
873
874         * gtk/gtkdoc.py:
875         (GTKDoc._run_command): Make print_output True by default again and use debug instead of info to log "Running" messages.
876
877 2017-01-20  Youenn Fablet  <youennf@gmail.com>
878
879         [WebRTC] Update build system to make G711 optional in libwebrtc
880         https://bugs.webkit.org/show_bug.cgi?id=167256
881
882         Reviewed by Alex Christensen.
883
884         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
885         (CMakeGenerator.remove_webrtc_g711): Adding a missing file to the build system as this file includes generic pcm encoder functions.
886
887 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
888
889         Cleanup RuntimeEnabledFeatures
890         https://bugs.webkit.org/show_bug.cgi?id=167228
891
892         Reviewed by Simon Fraser.
893
894         * DumpRenderTree/mac/DumpRenderTree.mm:
895         (enableExperimentalFeatures):
896         (resetWebPreferencesToConsistentValues):
897         (setWebPreferencesForTestOptions):
898         (resetWebViewToConsistentStateBeforeTesting):
899         * DumpRenderTree/win/DumpRenderTree.cpp:
900         (enableExperimentalFeatures):
901         (resetWebPreferencesToConsistentValues):
902         More closely match WebKitTestRunner initialization of preferences
903         for experimental features.
904
905 2017-01-20  Alex Christensen  <achristensen@webkit.org>
906
907         Build Fix for Windows DumpRenderTree after r210976
908         https://bugs.webkit.org/show_bug.cgi?id=167115
909
910         * DumpRenderTree/win/DumpRenderTree.cpp:
911         (resetWebPreferencesToConsistentValues):
912
913 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
914
915         Remove outdated ENABLE(CSP_NEXT) build flag
916         https://bugs.webkit.org/show_bug.cgi?id=167252
917
918         Reviewed by Brent Fulgham.
919
920         * Scripts/webkitperl/FeatureList.pm:
921         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
922
923 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
924
925         Build Fix for Windows DumpRenderTree after r210976
926
927         * DumpRenderTree/win/DumpRenderTree.cpp:
928         (resetWebPreferencesToConsistentValues):
929
930 2017-01-20  Antoine Quint  <graouts@apple.com>
931
932         Web Animations should be off by default and enabled as an experimental feature
933         https://bugs.webkit.org/show_bug.cgi?id=167115
934         <rdar://problem/30048963>
935
936         Reviewed by Joseph Pecoraro.
937
938         Turn Web Animations on in DRT.
939
940         * DumpRenderTree/mac/DumpRenderTree.mm:
941         (resetWebPreferencesToConsistentValues):
942         * DumpRenderTree/win/DumpRenderTree.cpp:
943         (resetWebPreferencesToConsistentValues):
944
945 2017-01-20  Youenn Fablet  <youenn@apple.com>
946
947         [WebRTC] Add libwebrtc build infrastructure
948         https://bugs.webkit.org/show_bug.cgi?id=167207
949
950         Reviewed by Alex Christensen.
951
952         Adding a script doing the libwebrtc project json to CMake file conversion.
953
954         * Scripts/generate-libwebrtc-cmake: Added.
955         * Scripts/webkitpy/libwebrtc/__init__.py: Added.
956         * Scripts/webkitpy/libwebrtc/generate_cmake.py: Added.
957
958 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
959
960         Mini Browser: Show tooltip for Experimental Features
961         https://bugs.webkit.org/show_bug.cgi?id=167225
962
963         Reviewed by Alex Christensen.
964
965         * MiniBrowser/mac/SettingsController.m:
966         (-[SettingsController _populateMenu]):
967         Include the full details string as a tooltip.
968
969 2017-01-20  Per Arne Vollan  <pvollan@apple.com>
970
971         [Win] Test output results should not be written twice.
972         https://bugs.webkit.org/show_bug.cgi?id=167197
973
974         Reviewed by Brent Fulgham.
975
976         Prevent test output from being written twice by returning early from
977         the dump() function, if it already has been called.
978         This patch also adds a missing newline to a test output line. 
979         
980         * DumpRenderTree/win/DumpRenderTree.cpp:
981         (dump):
982
983 2017-01-20  Antoine Quint  <graouts@apple.com>
984
985         [Modern Media Controls] Turn modern media controls on by default
986         https://bugs.webkit.org/show_bug.cgi?id=165668
987
988         Reviewed by Dean Jackson.
989
990         Enabled modern media controls by default in test runners.
991
992         * DumpRenderTree/TestOptions.h:
993         * WebKitTestRunner/TestOptions.h:
994
995 2017-01-19  Chris Dumez  <cdumez@apple.com>
996
997         iterable<> should be enabled on WK1
998         https://bugs.webkit.org/show_bug.cgi?id=167221
999         <rdar://problem/30108531>
1000
1001         Reviewed by Youenn Fablet.
1002
1003         * DumpRenderTree/mac/DumpRenderTree.mm:
1004         (resetWebPreferencesToConsistentValues):
1005         * DumpRenderTree/win/DumpRenderTree.cpp:
1006         (resetWebPreferencesToConsistentValues):
1007         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1008         (WTR::InjectedBundle::beginTesting):
1009         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1010         (WTR::TestRunner::setDOMIteratorEnabled): Deleted.
1011         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1012
1013 2017-01-19  Aakash Jain  <aakash_jain@apple.com>
1014
1015         Ensure status server logs go to log file
1016         https://bugs.webkit.org/show_bug.cgi?id=167210
1017
1018         Reviewed by Alexey Proskuryakov.
1019
1020         * Scripts/webkitpy/common/net/statusserver.py:
1021         (StatusServer.next_work_item): Change log level from debug to info in
1022         order to facilitate deubgging issues.
1023         (StatusServer.update_work_items): Same.
1024
1025 2017-01-19  Megan Gardner  <megan_gardner@apple.com>
1026
1027         Additional selection tests and interpolation fix
1028         https://bugs.webkit.org/show_bug.cgi?id=167171
1029
1030         Reviewed by Simon Fraser.
1031
1032         We weren't adding the final event when interpolating event streams.
1033
1034         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1035         (-[HIDEventGenerator interpolatedEvents:]):
1036
1037 2017-01-19  Myles C. Maxfield  <mmaxfield@apple.com>
1038
1039         [Cocoa] Variation fonts are erroneously disabled on iOS
1040         https://bugs.webkit.org/show_bug.cgi?id=167172
1041
1042         Reviewed by Simon Fraser.
1043
1044         OpenSource builders don't seem to understand sdk=embedded*.
1045
1046         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1047
1048 2017-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
1049
1050         Unreviewed. Fix GTK+ unit tests failing since r210531.
1051
1052         Avoid using paths to files that don't actually exist.
1053
1054         * TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp:
1055         (testWebKitConsoleMessageNetworkError):
1056         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
1057         (testContextMenuDefaultMenu):
1058         * TestWebKitAPI/Tests/WebKit2Gtk/resources/silence.mpg: Added.
1059         * TestWebKitAPI/Tests/WebKit2Gtk/resources/simple.json: Added.
1060         * TestWebKitAPI/Tests/WebKit2Gtk/resources/tracks.ogg: Added.
1061
1062 2017-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
1063
1064         [GTK] Provide API to set proxy settings
1065         https://bugs.webkit.org/show_bug.cgi?id=128674
1066
1067         Reviewed by Michael Catanzaro.
1068
1069         Add tests for new proxy settings API.
1070
1071         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
1072         (serverCallback):
1073         (ProxyTest::ProxyTest):
1074         (ProxyTest::~ProxyTest):
1075         (ProxyTest::loadURIAndGetMainResourceData):
1076         (ProxyTest::proxyServerPortAsString):
1077         (testWebContextProxySettings):
1078         (beforeAll):
1079
1080 2017-01-19  Timothy Hatcher  <timothy@hatcher.name>
1081
1082         Add back my old email address so old commits will still match it.
1083
1084         * Scripts/webkitpy/common/config/contributors.json:
1085
1086 2017-01-19  Timothy Hatcher  <timothy@hatcher.name>
1087
1088         Remove my old email address from contributors.json and watchlist.
1089
1090         * Scripts/validate-committer-lists:
1091         (CommitterListFromGit): Change the mapping to the correct email.
1092         * Scripts/webkitpy/common/config/contributors.json:
1093         * Scripts/webkitpy/common/config/watchlist:
1094
1095 2017-01-18  Ryan Haddad  <ryanhaddad@apple.com>
1096
1097         Unreviewed, rolling out r210848.
1098
1099         This change introduced media-related LayoutTest failures and
1100         crashes on macOS.
1101
1102         Reverted changeset:
1103
1104         "[Modern Media Controls] Turn modern media controls on by
1105         default"
1106         https://bugs.webkit.org/show_bug.cgi?id=165668
1107         http://trac.webkit.org/changeset/210848
1108
1109 2017-01-18  Andreas Kling  <akling@apple.com>
1110
1111         Document::securityOrigin() should return a reference.
1112         <https://webkit.org/b/167124>
1113
1114         Reviewed by Sam Weinig.
1115
1116         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
1117         (TestWebKitAPI::TEST_F):
1118
1119 2017-01-18  Per Arne Vollan  <pvollan@apple.com>
1120
1121         [Win] Clipboard tests are flaky.
1122         https://bugs.webkit.org/show_bug.cgi?id=167088
1123
1124         Reviewed by Brent Fulgham.
1125
1126         Tests involving the clipboard are flaky when running with multiple DRTs, since the clipboard is global. 
1127         We can fix this by assigning each DRT a separate window station (each window station has its own clipboard).
1128
1129         * DumpRenderTree/win/DumpRenderTree.cpp:
1130         (main):
1131
1132 2017-01-18  Antoine Quint  <graouts@apple.com>
1133
1134         [Modern Media Controls] Turn modern media controls on by default
1135         https://bugs.webkit.org/show_bug.cgi?id=165668
1136
1137         Reviewed by Dean Jackson.
1138
1139         Enabled modern media controls by default in test runners. 
1140
1141         * DumpRenderTree/TestOptions.h:
1142         * WebKitTestRunner/TestOptions.h:
1143
1144 2017-01-17  Michael Catanzaro  <mcatanzaro@igalia.com>
1145
1146         Unreviewed, rolling out r210834
1147         https://bugs.webkit.org/show_bug.cgi?id=165668
1148
1149         It introduced dozens of test timeouts.
1150
1151         Reverted changeset:
1152         "[Modern Media Controls] Turn modern media controls on by default"
1153         https://bugs.webkit.org/show_bug.cgi?id=165668
1154         http://trac.webkit.org/changeset/210834
1155
1156 2017-01-17  Antoine Quint  <graouts@apple.com>
1157
1158         [Modern Media Controls] Turn modern media controls on by default
1159         https://bugs.webkit.org/show_bug.cgi?id=165668
1160
1161         Reviewed by Dean Jackson.
1162
1163         Enabled modern media controls by default in test runners. 
1164
1165         * DumpRenderTree/TestOptions.h:
1166         * WebKitTestRunner/TestOptions.h:
1167
1168 2017-01-17  Chris Dumez  <cdumez@apple.com>
1169
1170         Document title changed twice when setting document.title
1171         https://bugs.webkit.org/show_bug.cgi?id=167065
1172
1173         Reviewed by Darin Adler.
1174
1175         Add WebKit2GTK API test that was written by Michael Catanzaro.
1176
1177         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1178         (testWebViewTitleChange):
1179         (beforeAll):
1180
1181 2017-01-17  Joseph Pecoraro  <pecoraro@apple.com>
1182
1183         ENABLE(USER_TIMING) Not Defined for Apple Windows or OS X Ports
1184         https://bugs.webkit.org/show_bug.cgi?id=116551
1185         <rdar://problem/13949830>
1186
1187         Reviewed by Alex Christensen.
1188
1189         * Scripts/webkitperl/FeatureList.pm:
1190         Remove stale RESOURCE_TIMING references which are now a runtime enabled feature
1191         that is part of the existing WEB_TIMING feature.
1192
1193         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1194
1195 2017-01-17  Jonathan Bedard  <jbedard@apple.com>
1196
1197         'webkit-patch post' no longer works with moved/copied files
1198         https://bugs.webkit.org/show_bug.cgi?id=166914
1199         <rdar://problem/29979707>
1200
1201         Reviewed by Daniel Bates.
1202
1203         SVN 1.9 has a bug where when a file has been moved or copied, the svn diff of the new
1204         file outputs only the "Index:" line with an empty body.  This workaround
1205         ignores such output from svn diff.  A issue has been filed with SVN, a link to the
1206         public email list tracking this bug is below.
1207         http://mail-archives.apache.org/mod_mbox/subversion-users/201701.mbox/%3cCF9BDE0A-7454-4405-8259-1120C6B76A03@apple.com%3e
1208         
1209
1210         * Scripts/svn-create-patch:
1211         (generateDiff): Ignore an "Index:" line with an empty body.
1212
1213 2017-01-16  Joseph Pecoraro  <pecoraro@apple.com>
1214
1215         Remove the REQUEST_ANIMATION_FRAME flag
1216         https://bugs.webkit.org/show_bug.cgi?id=156980
1217         <rdar://problem/25906849>
1218
1219         Reviewed by Simon Fraser.
1220
1221         * Scripts/webkitperl/FeatureList.pm:
1222         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1223
1224 2017-01-15  Sam Weinig  <sam@webkit.org>
1225
1226         Add the ability to use numbers in makeString()
1227         https://bugs.webkit.org/show_bug.cgi?id=167087
1228
1229         Reviewed by Darin Adler.
1230
1231         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1232         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Added.
1233         Add tests for StringConcatenate, focusing on new numeric additions.
1234
1235 2017-01-15  Michael Catanzaro  <mcatanzaro@igalia.com>
1236
1237         Unreviewed, remove stale comment.
1238
1239         This test was fixed by r163173.
1240
1241         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
1242
1243 2017-01-14  Yusuke Suzuki  <utatane.tea@gmail.com>
1244
1245         Annotate large string tests with largeHeap
1246         https://bugs.webkit.org/show_bug.cgi?id=167054
1247
1248         Reviewed by Filip Pizlo.
1249
1250         * Scripts/run-javascriptcore-tests:
1251         * Scripts/run-jsc-stress-tests:
1252
1253 2017-01-14  Joseph Pecoraro  <pecoraro@apple.com>
1254
1255         Remove stale references to ENABLE_ES6_GENERATORS and ENABLE_PROMISES
1256         https://bugs.webkit.org/show_bug.cgi?id=167043
1257
1258         Reviewed by Darin Adler.
1259
1260         * Scripts/webkitperl/FeatureList.pm:
1261
1262 2017-01-13  Joseph Pecoraro  <pecoraro@apple.com>
1263
1264         Remove ENABLE(DETAILS_ELEMENT) guards
1265         https://bugs.webkit.org/show_bug.cgi?id=167042
1266
1267         Reviewed by Alex Christensen.
1268
1269         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1270
1271 2017-01-13  Said Abou-Hallawa  <sabouhallawa@apple.com>
1272
1273         26 MotionMark performance tests failing
1274         https://bugs.webkit.org/show_bug.cgi?id=166854
1275
1276         Reviewed by Ryosuke Niwa.
1277
1278         Unrelated change. This is the last place that we need to rename Animometer
1279         to MotionMark.
1280
1281         * Scripts/webkitpy/common/config/watchlist:
1282
1283 2017-01-13  Yusuke Suzuki  <utatane.tea@gmail.com>
1284
1285         run-jsc-benchmarks' echo should have -e option
1286         https://bugs.webkit.org/show_bug.cgi?id=167009
1287
1288         Reviewed by Sam Weinig.
1289
1290         echo requires `-e` option to use escape sequence.
1291         Without it, in some environment (in my Fedora 25), the escape sequence is not
1292         recognized and just dumped as `\c` etc.
1293
1294         * Scripts/run-jsc-benchmarks:
1295
1296 2017-01-12  Chris Dumez  <cdumez@apple.com>
1297
1298         Add KEYBOARD_KEY_ATTRIBUTE / KEYBOARD_CODE_ATTRIBUTE to FeatureDefines.xcconfig
1299         https://bugs.webkit.org/show_bug.cgi?id=166995
1300
1301         Reviewed by Jer Noble.
1302
1303         Add KEYBOARD_KEY_ATTRIBUTE / KEYBOARD_CODE_ATTRIBUTE to FeatureDefines.xcconfig
1304         as some people are having trouble building without it.
1305
1306         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1307
1308 2017-01-12  Sam Weinig  <sam@webkit.org>
1309
1310         Add the ability to filter the set of bindings tests you want to run
1311         https://bugs.webkit.org/show_bug.cgi?id=166977
1312
1313         Reviewed by Tim Horton.
1314
1315         Allows doing things like:
1316             run-bindings-tests TestObj* TestCEReactions*
1317         
1318         to run only those tests that match the patterns.
1319
1320         * Scripts/run-bindings-tests:
1321         (main):
1322         Switch to using optparse and pass the remaining args as the filters.
1323
1324         * Scripts/webkitpy/bindings/main.py:
1325         (BindingsTests.__init__):
1326         Store the pattens.
1327
1328         (BindingsTests.test_matches_patterns):
1329         Add helper predicate to determine if a test should be run. When no
1330         patterns are present, all tests should run.
1331
1332         (BindingsTests.run_tests):
1333         Filter tests using the passed in patterns.
1334
1335 2017-01-12  Per Arne Vollan  <pvollan@apple.com>
1336
1337         Followup fix after r210503.
1338         https://bugs.webkit.org/show_bug.cgi?id=166887
1339
1340         Reviewed by Alex Christensen.
1341
1342         After <http://trac.webkit.org/changeset/210503>, test results are written to a
1343         duplicated file handle on Windows. This patch fixes the remaining call sites.
1344
1345         * DumpRenderTree/PixelDumpSupport.cpp:
1346         * DumpRenderTree/TestRunner.cpp:
1347         (TestRunner::waitToDumpWatchdogTimerFired):
1348         * DumpRenderTree/TestRunner.h:
1349         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
1350         * DumpRenderTree/win/DumpRenderTree.cpp:
1351         * DumpRenderTree/win/DumpRenderTreeWin.h:
1352         * DumpRenderTree/win/TestRunnerWin.cpp:
1353         (TestRunner::setSpellCheckerLoggingEnabled):
1354
1355 2017-01-11  Megan Gardner  <megan_gardner@apple.com>
1356
1357         Add committer status for Megan
1358         https://bugs.webkit.org/show_bug.cgi?id=166954
1359
1360         Reviewed by Tim Horton.
1361
1362         Add committer status for Megan Gardner
1363
1364         * Scripts/webkitpy/common/config/contributors.json:
1365
1366 2017-01-11  Brent Fulgham  <bfulgham@apple.com>
1367
1368         Unreviewed test fix after r210599.
1369
1370         * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp:
1371         (TestWebKitAPI::TEST): Remove debugging code that was causing a timeout.
1372
1373 2017-01-11  Brent Fulgham  <bfulgham@apple.com>
1374
1375         Unreviewed build fix after r210599.
1376
1377         Add missing files.
1378
1379         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
1380         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
1381
1382 2017-01-11  Brent Fulgham  <bfulgham@apple.com>
1383
1384         File scheme should not allow access of a resource on a different volume.
1385         https://bugs.webkit.org/show_bug.cgi?id=158552
1386         <rdar://problem/15307582>
1387
1388         Reviewed by Alex Christensen.
1389
1390         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
1391         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
1392         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
1393
1394 2017-01-11  Ryan Haddad  <ryanhaddad@apple.com>
1395
1396         Unreviewed, rolling out r210571.
1397
1398         This change broke the 32-bit macOS build and caused LayoutTest
1399         failures.
1400
1401         Reverted changeset:
1402
1403         "File scheme should not allow access of a resource on a
1404         different volume."
1405         https://bugs.webkit.org/show_bug.cgi?id=158552
1406         http://trac.webkit.org/changeset/210571
1407
1408 2017-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1409
1410         [GTK] install-dependencies script misses gdb
1411         https://bugs.webkit.org/show_bug.cgi?id=166917
1412
1413         Reviewed by Michael Catanzaro.
1414
1415         gdb is needed for generating the crash logs.
1416
1417         * gtk/install-dependencies:
1418
1419 2017-01-10  Michael Catanzaro  <mcatanzaro@igalia.com>
1420
1421         [GTK] No way for applications to set notification permissions without waiting for permission request
1422         https://bugs.webkit.org/show_bug.cgi?id=163366
1423
1424         Reviewed by Carlos Garcia Campos.
1425
1426         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1427         (testWebViewNotification):
1428         (setInitialNotificationPermissionsAllowedCallback):
1429         (setInitialNotificationPermissionsDisallowedCallback):
1430         (testWebViewNotificationInitialPermissionAllowed):
1431         (testWebViewNotificationInitialPermissionDisallowed):
1432         (beforeAll):
1433         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
1434         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
1435         (WebViewTest::WebViewTest):
1436         (WebViewTest::initializeWebView):
1437         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
1438
1439 2017-01-10  Tim Horton  <timothy_horton@apple.com>
1440
1441         MobileMiniBrowser tests don't work by default
1442         https://bugs.webkit.org/show_bug.cgi?id=166910
1443
1444         Reviewed by Alex Christensen.
1445
1446         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/xcshareddata/xcschemes/MobileMiniBrowserUITests.xcscheme: Added.
1447         Add a shared scheme; the Makefile depends on the MobileMiniBrowserUITests scheme existing, at the very least.
1448
1449 2017-01-10  Brent Fulgham  <bfulgham@apple.com>
1450
1451         File scheme should not allow access of a resource on a different volume.
1452         https://bugs.webkit.org/show_bug.cgi?id=158552
1453         <rdar://problem/15307582>
1454
1455         Reviewed by Alex Christensen.
1456
1457         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
1458         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
1459         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
1460
1461 2017-01-10  Mark Lam  <mark.lam@apple.com>
1462
1463         Reverting run-jsc-stress-tests' $buildType to use string values.
1464         https://bugs.webkit.org/show_bug.cgi?id=166912
1465
1466         Rubber stamped by Filip Pizlo.
1467
1468         This is so that we can test for it in the tests e.g.
1469         //@ if $buildType == "debug" then runDefault("--maxSingleAllocationSize=1048576") else skip end
1470
1471         * Scripts/run-jsc-stress-tests:
1472
1473 2017-01-10  Ryosuke Niwa  <rniwa@webkit.org>
1474
1475         Temporarily add back the file removed in r210463 to unbreak internal bots.
1476
1477         * Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch: Copied from Tools/Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch.
1478
1479 2017-01-10  Jonathan Bedard  <jbedard@apple.com>
1480
1481         svn-apply failed to apply a patch (deleting file with svn property)
1482         https://bugs.webkit.org/show_bug.cgi?id=165953
1483
1484         Reviewed by Daniel Bates.
1485
1486         * Scripts/VCSUtils.pm:
1487         (parseSvnPropertyValue): The beginning of a diff will cause an early exit in the case of no empty newlines.
1488         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl: Add tests without break between diffs for properties.
1489
1490 2017-01-10  Ryan Haddad  <ryanhaddad@apple.com>
1491
1492         Update flakiness dashboard configuration.
1493         https://bugs.webkit.org/show_bug.cgi?id=166869
1494
1495         Reviewed by Alexey Proskuryakov.
1496
1497         * TestResultServer/static-dashboards/builders.jsonp:
1498         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1499
1500 2017-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1501
1502         [GTK] Stop honoring the environment variable USE_NATIVE_XDISPLAY
1503         https://bugs.webkit.org/show_bug.cgi?id=165232
1504
1505         Unreviewed follow-up patch after r210539 and r210523.
1506
1507         Instead of using that environment variable, the argument
1508         --display-server=xorg should be passed now.
1509
1510         The GTK+ performance bot was the only bot using this, and is
1511         already passing --display-server=xorg after r210539.
1512
1513         * Scripts/webkitpy/port/gtk.py:
1514         (GtkPort._driver_class):
1515
1516 2017-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1517
1518         [GTK] Add a new release test bot for Wayland and pass --display-server=xorg to the GTK Perf bot.
1519         https://bugs.webkit.org/show_bug.cgi?id=166872
1520
1521         Reviewed by Michael Catanzaro.
1522
1523         Add the new wayland release test bot as a test-only bot. It will download the built product from the release build-only bot.
1524         Define the required "--display-server=driver" in the bot additionalArguments config entry.
1525         Implement support for honoring additionalArguments on the RunGtkAPITests and RunAndUploadPerfTests steps.
1526         The step RunWebKitTests already has support for it.
1527
1528         * BuildSlaveSupport/build.webkit.org-config/config.json:
1529         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1530         (RunGtkAPITests.start):
1531         (RunAndUploadPerfTests.start):
1532         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1533
1534 2017-01-09  Ryan Haddad  <ryanhaddad@apple.com>
1535
1536         Unreviewed, rolling out r210531.
1537
1538         This change broke the 32-bit macOS build and caused LayoutTest
1539         failures.
1540
1541         Reverted changeset:
1542
1543         "File scheme should not allow access of a resource on a
1544         different volume."
1545         https://bugs.webkit.org/show_bug.cgi?id=158552
1546         http://trac.webkit.org/changeset/210531
1547
1548 2017-01-09  Brent Fulgham  <bfulgham@apple.com>
1549
1550         File scheme should not allow access of a resource on a different volume.
1551         https://bugs.webkit.org/show_bug.cgi?id=158552
1552         <rdar://problem/15307582>
1553
1554         Reviewed by Alex Christensen.
1555
1556         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
1557         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
1558         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
1559
1560 2017-01-09  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1561
1562         [GTK][Wayland] Allow running the layout tests under a native Wayland environment.
1563         https://bugs.webkit.org/show_bug.cgi?id=165232
1564
1565         Reviewed by Michael Catanzaro.
1566
1567         Add a new WaylandDriver to run the tests in the user current wayland session.
1568
1569         Also merge all the configuration options for selecting the display server inside one
1570         switch --display-server=xvfb/xorg/wayland/weston (defaulting to xvfb).
1571
1572         This switch is supported on the scripts: run-gtk-tests, run-perf-tests and run-webkit-tests.
1573
1574         * Scripts/run-gtk-tests: Add missing logging.basicConfig() initialization for the error logger.
1575         (TestRunner._create_driver):
1576         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1577         (parse_args):
1578         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1579         (PerfTestsRunner._parse_args):
1580         * Scripts/webkitpy/port/gtk.py:
1581         (GtkPort.__init__):
1582         (GtkPort._driver_class):
1583         (GtkPort._search_paths):
1584         * Scripts/webkitpy/port/waylanddriver.py: Added.
1585         (WaylandDriver):
1586         (WaylandDriver.check_driver):
1587         (WaylandDriver._setup_environ_for_test):
1588         (WaylandDriver._start):
1589
1590 2017-01-09  Andy Estes  <aestes@apple.com>
1591
1592         [QuickLook] Add a layout test for webkit.org/b/135651
1593         https://bugs.webkit.org/show_bug.cgi?id=166855
1594
1595         Reviewed by Andreas Kling.
1596
1597         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1598         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]): Added output for
1599         errors with code WebKitErrorCannotShowURL.
1600         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1601         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame): Made the error output
1602         not specific to WebKit2 error codes.
1603
1604 2017-01-09  Antoine Quint  <graouts@apple.com>
1605
1606         Support webkit-test-runner key-value pairs in http tests in DumpRenderTree
1607         https://bugs.webkit.org/show_bug.cgi?id=166837
1608
1609         Reviewed by Alex Christensen.
1610
1611         We now correctly handle the --absolutePath argument in DumpRenderTree and use
1612         the provided value when trying to determine the path to the test file. Failing
1613         that, we use the computed URL or the raw path provided to cover all cases.
1614         
1615         This was tested in the context of https://bugs.webkit.org/show_bug.cgi?id=165668
1616         by applying this patch and seeing the number test failures dramatically reduced
1617         with WK1 due to the option to turn modern media controls off for older media controls
1618         tests.
1619
1620         * DumpRenderTree/DumpRenderTree.h:
1621         * DumpRenderTree/DumpRenderTreeCommon.cpp:
1622         (parseInputLine):
1623         * DumpRenderTree/TestOptions.h:
1624         * DumpRenderTree/TestOptions.mm:
1625         (TestOptions::TestOptions):
1626         * DumpRenderTree/mac/DumpRenderTree.mm:
1627         (runTest):
1628
1629 2017-01-09  Milan Crha  <mcrha@redhat.com>
1630
1631         prepare-ChangeLog: Correct help string for --style option
1632         https://bugs.webkit.org/show_bug.cgi?id=166725
1633
1634         Reviewed by Alexey Proskuryakov.
1635
1636         * Scripts/prepare-ChangeLog:
1637         (main):
1638
1639 2017-01-09  Lucas Forschler  <lforschler@apple.com>
1640
1641         https://bugs.webkit.org/show_bug.cgi?id=166839
1642         Add php7 support for macOS.
1643         Mirror the debian logic to look for a php7 module on disk, and return the appropriate apache config file.
1644
1645         Reviewed by Alexey Proskuryakov.
1646
1647         * Scripts/webkitpy/port/base.py:
1648         (Port._is_darwin_php_version_7):
1649         (Port._debian_php_version):
1650         (Port):
1651         (Port._darwin_php_version):
1652         (Port._apache_config_file_name_for_platform):
1653
1654 2017-01-06  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1655
1656         [GTK] Should support key and code properties on keyboard events
1657         https://bugs.webkit.org/show_bug.cgi?id=166759
1658
1659         Reviewed by Carlos Garcia Campos.
1660
1661         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
1662         (WTR::getGDKKeySymForKeyRef): add missing modifier keys which were being reported as 'l' and 'r' only
1663         on tests.
1664
1665 2017-01-06  Per Arne Vollan  <pvollan@apple.com>
1666
1667         [Win] Some tests are flaky because certain DLLs are writing to stdout.
1668         https://bugs.webkit.org/show_bug.cgi?id=166760
1669
1670         Reviewed by Darin Adler.
1671
1672         Some tests are flaky because certain DLLs are writing to stdout, giving incorrect test results.
1673         We can work around that by duplicating and redirecting stdout.
1674
1675         * DumpRenderTree/PixelDumpSupport.cpp:
1676         (dumpWebViewAsPixelsAndCompareWithExpected):
1677         (printPNG):
1678         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
1679         (logEventProc):
1680         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
1681         (DRTDesktopNotificationPresenter::showDesktopNotification):
1682         (DRTDesktopNotificationPresenter::cancelDesktopNotification):
1683         (DRTDesktopNotificationPresenter::requestNotificationPermission):
1684         * DumpRenderTree/win/DumpRenderTree.cpp:
1685         (dumpFrameScrollPosition):
1686         (dumpHistoryItem):
1687         (dumpBackForwardList):
1688         (dump):
1689         (runTest):
1690         (main):
1691         * DumpRenderTree/win/DumpRenderTreeWin.h:
1692         * DumpRenderTree/win/EditingDelegate.cpp:
1693         (EditingDelegate::shouldBeginEditingInDOMRange):
1694         (EditingDelegate::shouldEndEditingInDOMRange):
1695         (EditingDelegate::shouldInsertNode):
1696         (EditingDelegate::shouldInsertText):
1697         (EditingDelegate::shouldDeleteDOMRange):
1698         (EditingDelegate::shouldChangeSelectedDOMRange):
1699         (EditingDelegate::shouldApplyStyle):
1700         (EditingDelegate::shouldChangeTypingStyle):
1701         (EditingDelegate::doPlatformCommand):
1702         (EditingDelegate::webViewDidBeginEditing):
1703         (EditingDelegate::webViewDidChange):
1704         (EditingDelegate::webViewDidEndEditing):
1705         (EditingDelegate::webViewDidChangeTypingStyle):
1706         (EditingDelegate::webViewDidChangeSelection):
1707         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1708         (FrameLoadDelegate::didStartProvisionalLoadForFrame):
1709         (FrameLoadDelegate::didReceiveServerRedirectForProvisionalLoadForFrame):
1710         (FrameLoadDelegate::didChangeLocationWithinPageForFrame):
1711         (FrameLoadDelegate::didFailProvisionalLoadWithError):
1712         (FrameLoadDelegate::didCommitLoadForFrame):
1713         (FrameLoadDelegate::didReceiveTitle):
1714         (FrameLoadDelegate::didFinishLoadForFrame):
1715         (FrameLoadDelegate::didFailLoadWithError):
1716         (FrameLoadDelegate::willPerformClientRedirectToURL):
1717         (FrameLoadDelegate::didCancelClientRedirectForFrame):
1718         (FrameLoadDelegate::windowScriptObjectAvailable):
1719         (FrameLoadDelegate::didFinishDocumentLoadForFrame):
1720         (FrameLoadDelegate::didHandleOnloadEventsForFrame):
1721         (FrameLoadDelegate::didDisplayInsecureContent):
1722         (FrameLoadDelegate::didRunInsecureContent):
1723         (FrameLoadDelegate::webViewProgressFinishedNotification):
1724         * DumpRenderTree/win/HistoryDelegate.cpp:
1725         (HistoryDelegate::didNavigateWithNavigationData):
1726         (HistoryDelegate::didPerformClientRedirectFromURL):
1727         (HistoryDelegate::didPerformServerRedirectFromURL):
1728         (HistoryDelegate::updateHistoryTitle):
1729         (HistoryDelegate::populateVisitedLinksForWebView):
1730         * DumpRenderTree/win/PolicyDelegate.cpp:
1731         (PolicyDelegate::decidePolicyForNavigationAction):
1732         (PolicyDelegate::unableToImplementPolicyWithError):
1733         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
1734         (ResourceLoadDelegate::willSendRequest):
1735         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
1736         (ResourceLoadDelegate::didReceiveResponse):
1737         (ResourceLoadDelegate::didFinishLoadingFromDataSource):
1738         (ResourceLoadDelegate::didFailLoadingWithError):
1739         * DumpRenderTree/win/TestRunnerWin.cpp:
1740         (TestRunner::addDisallowedURL):
1741         (TestRunner::originsWithApplicationCache):
1742         (TestRunner::setStorageDatabaseIdleInterval):
1743         (TestRunner::closeIdleLocalStorageDatabases):
1744         (TestRunner::copyDecodedHostName):
1745         (TestRunner::copyEncodedHostName):
1746         (TestRunner::numberOfPendingGeolocationPermissionRequests):
1747         (TestRunner::isGeolocationProviderActive):
1748         (TestRunner::pathToLocalResource):
1749         (TestRunner::setMockDeviceOrientation):
1750         (TestRunner::setMockGeolocationPosition):
1751         (TestRunner::setMockGeolocationPositionUnavailableError):
1752         (TestRunner::setSpatialNavigationEnabled):
1753         (TestRunner::setAutomaticLinkDetectionEnabled):
1754         (TestRunner::isCommandEnabled):
1755         (TestRunner::authenticateSession):
1756         (TestRunner::addChromeInputField):
1757         (TestRunner::removeChromeInputField):
1758         (TestRunner::focusWebView):
1759         (TestRunner::grantWebNotificationPermission):
1760         (TestRunner::denyWebNotificationPermission):
1761         (TestRunner::removeAllWebNotificationPermissions):
1762         (TestRunner::simulateWebNotificationClick):
1763         (TestRunner::imageCountInGeneralPasteboard):
1764         * DumpRenderTree/win/UIDelegate.cpp:
1765         (UIDelegate::runJavaScriptAlertPanelWithMessage):
1766         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
1767         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
1768         (UIDelegate::runBeforeUnloadConfirmPanelWithMessage):
1769         (UIDelegate::webViewAddMessageToConsole):
1770         (UIDelegate::exceededDatabaseQuota):
1771         (UIDelegate::setStatusText):
1772         (UIDelegate::didPressMissingPluginButton):
1773
1774 2017-01-07  Tim Horton  <timothy_horton@apple.com>
1775
1776         Add a setting to create editable MiniBrowser windows by default
1777         https://bugs.webkit.org/show_bug.cgi?id=166806
1778
1779         Reviewed by Beth Dakin.
1780
1781         * MiniBrowser/mac/AppDelegate.m:
1782         (-[BrowserAppDelegate createBrowserWindowController:]):
1783         (-[BrowserAppDelegate applicationDidFinishLaunching:]):
1784         (-[BrowserAppDelegate _updateNewWindowKeyEquivalents]):
1785         * MiniBrowser/mac/SettingsController.h:
1786         * MiniBrowser/mac/SettingsController.m:
1787         (-[SettingsController _populateMenu]):
1788         (-[SettingsController validateMenuItem:]):
1789         (-[SettingsController toggleCreateEditorByDefault:]):
1790         (-[SettingsController createEditorByDefault]):
1791         Add a setting and update the key equivalents accordingly.
1792         Also make sure to make the right kind of window on launch.
1793
1794 2017-01-07  Tim Horton  <timothy_horton@apple.com>
1795
1796         Fix the 32-bit build.
1797
1798         * MiniBrowser/mac/BrowserWindowController.h:
1799         * MiniBrowser/mac/BrowserWindowController.m:
1800
1801 2017-01-07  Tim Horton  <timothy_horton@apple.com>
1802
1803         Fix the 32-bit build.
1804
1805         * MiniBrowser/mac/BrowserWindowController.m:
1806
1807 2017-01-07  Tim Horton  <timothy_horton@apple.com>
1808
1809         Make it possible to drop HTML files on the MiniBrowser icon
1810         https://bugs.webkit.org/show_bug.cgi?id=166802
1811
1812         Reviewed by Simon Fraser.
1813
1814         * MiniBrowser/mac/AppDelegate.m:
1815         (-[BrowserAppDelegate application:openFile:]):
1816         * MiniBrowser/mac/Info.plist:
1817         If you're using an editable window, the usual trick of dropping on the
1818         window doesn't work anymore (it makes an <attachment> instead).
1819
1820 2017-01-07  Tim Horton  <timothy_horton@apple.com>
1821
1822         MiniBrowser window gets smaller each time it is instantiated
1823         https://bugs.webkit.org/show_bug.cgi?id=166807
1824
1825         Reviewed by Andy Estes.
1826
1827         * MiniBrowser/mac/BrowserWindowController.m:
1828         (-[BrowserWindowController windowDidLoad]):
1829         * MiniBrowser/mac/BrowserWindow.xib:
1830         Turn on full-window content view support with IB, instead of waiting
1831         until after the views have been loaded. This seems to resolve the
1832         longstanding ever-shrinking-window problem.
1833
1834 2017-01-07  Tim Horton  <timothy_horton@apple.com>
1835
1836         Add indent/outdent items to MiniBrowser's new format menu
1837         https://bugs.webkit.org/show_bug.cgi?id=166805
1838
1839         Reviewed by Dan Bernstein.
1840
1841         * MiniBrowser/mac/MainMenu.xib:
1842
1843 2017-01-07  Tim Horton  <timothy_horton@apple.com>
1844
1845         Add a stock Format menu to MiniBrowser
1846         https://bugs.webkit.org/show_bug.cgi?id=166804
1847
1848         Reviewed by Andy Estes.
1849
1850         * MiniBrowser/mac/MainMenu.xib:
1851         Many of the features automatically work with editable web views.
1852         However, this seems to expose a bug where none of the font-related features
1853         (Cmd-B, for example) work until the first time the font panel is shown,
1854         per process, which will need to be investigated separately.
1855
1856 2017-01-07  Tim Horton  <timothy_horton@apple.com>
1857
1858         Remove unused applicationWillTerminate methods from MiniBrowser
1859         https://bugs.webkit.org/show_bug.cgi?id=166803
1860
1861         Reviewed by Andy Estes.
1862
1863         * MiniBrowser/mac/AppDelegate.m:
1864         (-[BrowserAppDelegate applicationWillTerminate:]): Deleted.
1865         * MiniBrowser/mac/BrowserWindowController.h:
1866         * MiniBrowser/mac/BrowserWindowController.m:
1867         (-[BrowserWindowController applicationTerminating]): Deleted.
1868         * MiniBrowser/mac/WK1BrowserWindowController.m:
1869         (-[WK1BrowserWindowController applicationTerminating]): Deleted.
1870         * MiniBrowser/mac/WK2BrowserWindowController.m:
1871         (-[WK2BrowserWindowController applicationTerminating]): Deleted.
1872
1873 2017-01-07  Tim Horton  <timothy_horton@apple.com>
1874
1875         Add the ability to create empty contentEditable windows in MiniBrowser
1876         https://bugs.webkit.org/show_bug.cgi?id=166801
1877
1878         Reviewed by Wenson Hsieh.
1879
1880         * MiniBrowser/mac/AppDelegate.h:
1881         * MiniBrowser/mac/AppDelegate.m:
1882         (-[BrowserAppDelegate createBrowserWindowController:]):
1883         (-[BrowserAppDelegate newWindow:]):
1884         (-[BrowserAppDelegate newEditorWindow:]):
1885         (-[BrowserAppDelegate openDocument:]):
1886         (-[BrowserAppDelegate _updateNewWindowKeyEquivalents]):
1887         * MiniBrowser/mac/BrowserWindowController.h:
1888         * MiniBrowser/mac/BrowserWindowController.m:
1889         (-[BrowserWindowController loadHTMLString:]):
1890         (-[BrowserWindowController toggleEditable:]):
1891         * MiniBrowser/mac/MainMenu.xib:
1892         * MiniBrowser/mac/WK1BrowserWindowController.m:
1893         (-[WK1BrowserWindowController awakeFromNib]):
1894         (-[WK1BrowserWindowController loadHTMLString:]):
1895         (-[WK1BrowserWindowController validateMenuItem:]):
1896         (-[WK1BrowserWindowController setEditable:]):
1897         (-[WK1BrowserWindowController updateTitle:]):
1898         * MiniBrowser/mac/WK2BrowserWindowController.m:
1899         (-[WK2BrowserWindowController awakeFromNib]):
1900         (-[WK2BrowserWindowController validateMenuItem:]):
1901         (-[WK2BrowserWindowController setEditable:]):
1902         (-[WK2BrowserWindowController updateTitle:]):
1903         (-[WK2BrowserWindowController loadHTMLString:]):
1904         Merge more functionality from WebEditingTester.
1905         Add two menu items for creating empty editable WebKit1/2 windows.
1906         Add a menu item to the Edit menu to toggle editability on any window.
1907
1908 2017-01-07  Tim Horton  <timothy_horton@apple.com>
1909
1910         Implement find-in-page in MiniBrowser
1911         https://bugs.webkit.org/show_bug.cgi?id=166799
1912
1913         Reviewed by Andy Estes.
1914
1915         * MiniBrowser/mac/BrowserWindow.xib:
1916         * MiniBrowser/mac/BrowserWindowController.h:
1917         * MiniBrowser/mac/BrowserWindowController.m:
1918         (-[BrowserWindowController find:]): Deleted.
1919         * MiniBrowser/mac/MainMenu.xib:
1920         * MiniBrowser/mac/WK1BrowserWindowController.m:
1921         (-[WK1BrowserWindowController toggleShrinkToFit:]):
1922         (-[WK1BrowserWindowController find:]): Deleted.
1923         * MiniBrowser/mac/WK2BrowserWindowController.m:
1924         (-[WK2BrowserWindowController awakeFromNib]):
1925         (-[WK2BrowserWindowController dealloc]):
1926         (-[WK2BrowserWindowController validateMenuItem:]):
1927         (-[WK2BrowserWindowController performTextFinderAction:]):
1928         (-[WK2BrowserWindowController findBarView]):
1929         (-[WK2BrowserWindowController setFindBarView:]):
1930         (-[WK2BrowserWindowController isFindBarVisible]):
1931         (-[WK2BrowserWindowController setFindBarVisible:]):
1932         (-[WK2BrowserWindowController contentView]):
1933         (-[WK2BrowserWindowController findBarViewDidChangeHeight]):
1934         (-[WK2BrowserWindowController performFindPanelAction:]): Deleted.
1935         (-[WK2BrowserWindowController find:]): Deleted.
1936         Implement find-in-page using WKWebView's conformance to the NSTextFinderClient
1937         protocol. At first glance, it's pretty broken, but vaguely works.
1938
1939 2017-01-07  Tim Horton  <timothy_horton@apple.com>
1940
1941         Share the implementation of MiniBrowser view hiding functionality
1942         https://bugs.webkit.org/show_bug.cgi?id=166800
1943
1944         Reviewed by Andy Estes.
1945
1946         * MiniBrowser/mac/BrowserWindowController.m:
1947         (-[BrowserWindowController showHideWebView:]):
1948         (-[BrowserWindowController removeReinsertWebView:]):
1949         * MiniBrowser/mac/WK1BrowserWindowController.m:
1950         (-[WK1BrowserWindowController showHideWebView:]): Deleted.
1951         (-[WK1BrowserWindowController removeReinsertWebView:]): Deleted.
1952         * MiniBrowser/mac/WK2BrowserWindowController.m:
1953         (-[WK2BrowserWindowController showHideWebView:]): Deleted.
1954         (-[WK2BrowserWindowController removeReinsertWebView:]): Deleted.
1955         Move the implementation of these two things to the shared superclass,
1956         since they don't depend on WebKit-specific things.
1957         Also, there was no reason to retain the (WK)WebView while it was unparented,
1958         as the BrowserWindowController maintains a reference the entire time.
1959
1960 2017-01-06  Andy Estes  <aestes@apple.com>
1961
1962         [Cocoa] Consolidate duplicate copies of WebArchiveDumpSupport in DRT and WKTR into WebCoreTestSupport
1963         https://bugs.webkit.org/show_bug.cgi?id=166789
1964
1965         Reviewed by Alex Christensen.
1966
1967         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1968         * DumpRenderTree/PlatformMac.cmake:
1969         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp: Removed.
1970         * DumpRenderTree/cf/WebArchiveDumpSupport.h: Removed.
1971         * DumpRenderTree/mac/DumpRenderTree.mm:
1972         Called WebCoreTestSupport::createXMLStringFromWebArchiveData() instead of
1973         createXMLStringFromWebArchiveData().
1974         * DumpRenderTree/mac/WebArchiveDumpSupportMac.mm: Removed.
1975         * WebKitTestRunner/Configurations/Base.xcconfig:
1976         Added $(BUILT_PRODUCTS_DIR)/WebCoreTestSupport to HEADER_SEARCH_PATHS.
1977         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1978         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
1979         Called WebCoreTestSupport::createXMLStringFromWebArchiveData() instead of
1980         createXMLStringFromWebArchiveData().
1981         * WebKitTestRunner/InjectedBundle/cocoa/WebArchiveDumpSupportCocoa.mm: Removed.
1982         * WebKitTestRunner/PlatformMac.cmake:
1983         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1984         * WebKitTestRunner/cf/WebArchiveDumpSupport.h: Removed.
1985
1986 2017-01-06  Tim Horton  <timothy_horton@apple.com>
1987
1988         Minor cleanups to IndentOutdentCommand and related code
1989         https://bugs.webkit.org/show_bug.cgi?id=166791
1990
1991         Reviewed by Simon Fraser.
1992
1993         * WebEditingTester/EditingOperations.m:
1994         (editingOperations):
1995         Add the outdent operation to WebEditingTester.
1996
1997 2017-01-06  Said Abou-Hallawa  <sabouhallawa@apple.com>
1998
1999         Create a plan and a patch files for MotionMark and delete the Animometer's ones
2000         https://bugs.webkit.org/show_bug.cgi?id=166785
2001
2002         Reviewed by Ryosuke Niwa.
2003
2004         * Scripts/webkitpy/benchmark_runner/data/patches/MotionMark.patch: Renamed from Tools/Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch.
2005         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark.plan: Renamed from Tools/Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan.
2006
2007 2017-01-06  Antoine Quint  <graouts@apple.com>
2008
2009         Support webkit-test-runner key-value pairs in http tests
2010         https://bugs.webkit.org/show_bug.cgi?id=149812
2011
2012         Reviewed by Alex Christensen.
2013
2014         We pass the absolute path for a test through to WKTR so that we can parse
2015         tests that are running as URLs for webkit-test-runner options.
2016
2017         * DumpRenderTree/DumpRenderTreeCommon.cpp:
2018         (parseInputLine):
2019
2020         Explicitly skip the --absolute-path option in DRT or else we'd crash.
2021
2022         * Scripts/webkitpy/port/driver.py:
2023         (Driver._command_from_driver_input):
2024
2025         Pass the absolute path to the file through the CLI.
2026
2027         * WebKitTestRunner/TestController.cpp:
2028         (WTR::updateTestOptionsFromTestHeader):
2029         (WTR::TestController::testOptionsForTest):
2030         (WTR::parseInputLine):
2031         (WTR::TestController::runTest):
2032         * WebKitTestRunner/TestController.h:
2033
2034 2017-01-06  Tim Horton  <timothy_horton@apple.com>
2035
2036         Warning about unconnectable outlets when opening a MiniBrowser window
2037         https://bugs.webkit.org/show_bug.cgi?id=166756
2038
2039         Reviewed by Dan Bernstein.
2040
2041         * MiniBrowser/mac/BrowserWindow.xib:
2042         When launching MiniBrowser, it says:
2043         Failed to connect (Share) outlet from (WK1BrowserWindowController) to
2044             (MBToolbarItem): missing setter or instance variable
2045         Failed to connect (shareButton) outlet from (WK1BrowserWindowController) to
2046             (NSButtonCell): missing setter or instance variable.
2047
2048         It looks like someone added the connection from the share button
2049         to the BrowserWindowController three times; only one of the connections
2050         is valid. Remove the other two.
2051
2052 2017-01-05  Keith Rollin  <krollin@apple.com>
2053
2054         Add WebCore::URL::protocolHostAndPort
2055         https://bugs.webkit.org/show_bug.cgi?id=166426
2056
2057         Reviewed by Alex Christensen.
2058
2059         Add test for protocolHostAndPort.
2060
2061         * TestWebKitAPI/Tests/WebCore/URL.cpp:
2062         (TestWebKitAPI::TEST_F):
2063
2064 2017-01-05  Per Arne Vollan  <pvollan@apple.com>
2065
2066         [Win] Archive test result is failing.
2067         https://bugs.webkit.org/show_bug.cgi?id=166720
2068
2069         Reviewed by Alex Christensen.
2070
2071         Deleting the layout test result folder is sometimes failing
2072         on Windows. This is not a critical error.
2073
2074         * BuildSlaveSupport/test-result-archive:
2075         (archiveTestResults):
2076
2077 2017-01-04  Tomas Popela  <tpopela@redhat.com>
2078
2079         [GTK] Minibrowser: Add printing support
2080         https://bugs.webkit.org/show_bug.cgi?id=165298
2081
2082         Open a print dialog when the Ctrl + P shortcut is pressed. If there is
2083         an error during the print, it's printed on the console.
2084
2085         Reviewed by Michael Catanzaro.
2086
2087         * MiniBrowser/gtk/BrowserWindow.c:
2088         (webKitPrintOperationFailedCallback):
2089         (printPage):
2090         (browser_window_init):
2091
2092 2017-01-04  Manuel Rego Casasnovas  <rego@igalia.com>
2093
2094         [css-grid] Fix crash clamping grid lines
2095         https://bugs.webkit.org/show_bug.cgi?id=166637
2096
2097         Reviewed by Darin Adler.
2098
2099         Creates new unit test to verify that the maximum tracks limit
2100         is used in GridPosition too.
2101
2102         * TestWebKitAPI/PlatformEfl.cmake:
2103         * TestWebKitAPI/PlatformGTK.cmake:
2104         * TestWebKitAPI/PlatformWin.cmake:
2105         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2106         * TestWebKitAPI/Tests/WebCore/GridPosition.cpp: Added.
2107         (TestWebKitAPI::TEST):
2108
2109 2017-01-04  Wenson Hsieh  <wenson_hsieh@apple.com>
2110
2111         Move editing history scripts to WebCore PrivateHeaders
2112         https://bugs.webkit.org/show_bug.cgi?id=166709
2113         <rdar://problem/29876612>
2114
2115         Reviewed by Dan Bernstein.
2116
2117         Update references to editing script files in WebCore that were moved.
2118
2119         * EditingHistory/EditingHistory.xcodeproj/project.pbxproj:
2120
2121 2017-01-04  Yusuke Suzuki  <utatane.tea@gmail.com>
2122
2123         Unreviewed, build fix after r210313 part 2
2124         https://bugs.webkit.org/show_bug.cgi?id=166676
2125
2126         Add 'U' suffix.
2127
2128         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2129         (TestWebKitAPI::TEST):
2130         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
2131         (TestWebKitAPI::TEST):
2132
2133 2017-01-04  Yusuke Suzuki  <utatane.tea@gmail.com>
2134
2135         Limit thread name appropriately
2136         https://bugs.webkit.org/show_bug.cgi?id=166676
2137
2138         Reviewed by Sam Weinig.
2139
2140         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2141         (TestWebKitAPI::TEST):
2142         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
2143         (TestWebKitAPI::TEST):
2144
2145 2017-01-04  Andy Estes  <aestes@apple.com>
2146
2147         [Cocoa] Teach SharedBuffer to return an NSArray of data segments to avoid flattening
2148         https://bugs.webkit.org/show_bug.cgi?id=166696
2149
2150         Reviewed by Tim Horton.
2151
2152         * TestWebKitAPI/PlatformGTK.cmake:
2153         * TestWebKitAPI/PlatformWin.cmake:
2154         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2155         * TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp: Moved class SharedBufferTest to SharedBufferTest.{cpp,h}.
2156         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.cpp: Moved class SharedBufferTest from SharedBuffer.cpp.
2157         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.h: Ditto.
2158         * TestWebKitAPI/Tests/WebCore/cocoa/SharedBuffer.mm: Added.
2159         (TestWebKitAPI::expectDataArraysEqual): Added a helper to assert that two NSArrays of NSData are equal.
2160         (TestWebKitAPI::TEST_F): Added a test for createNSDataArray.
2161
2162 2017-01-03  Brian Burg  <bburg@apple.com>
2163
2164         Web Inspector: teach the protocol generator about platform-specific types, events, and commands
2165         https://bugs.webkit.org/show_bug.cgi?id=166003
2166         <rdar://problem/28718990>
2167
2168         Reviewed by Joseph Pecoraro.
2169
2170         Teach run-inspector-generator-tests to generate test output using the platform name
2171         derived from the directory that the test is in. For example, tests in the /generic/
2172         subdirectory will pass `--platform generic` to generate-inspector-protocol-bindings.py.
2173
2174         * Scripts/webkitpy/inspector/main.py:
2175         (InspectorGeneratorTests.generate_from_json):
2176         (InspectorGeneratorTests.run_tests):
2177         (InspectorGeneratorTests.main):
2178
2179 2017-01-04  Csaba Osztrogonác  <ossy@webkit.org>
2180
2181         Unreviewed cmake buildfix after r210266.
2182
2183         * DumpRenderTree/PlatformMac.cmake:
2184
2185 2017-01-04  Tim Horton  <timothy_horton@apple.com>
2186
2187         Provide a setting for clients to always prefer low-power WebGL
2188         https://bugs.webkit.org/show_bug.cgi?id=166675
2189         <rdar://problem/29834093>
2190
2191         Reviewed by Dan Bernstein.
2192
2193         * MiniBrowser/mac/Info.plist:
2194         Have MiniBrowser claim to be a modern app that supports
2195         automatic graphics switching. WebKit needs to support automatic
2196         graphics switching, so our test app might as well. Without this
2197         Info.plist parameter, this change has no effect, and bringing up
2198         a WebGL context still brings up the discrete GPU (also true of the
2199         existing web-exposed preferLowPowerToHighPerformance API).
2200
2201 2017-01-03  Yusuke Suzuki  <utatane.tea@gmail.com>
2202
2203         WorkQueueGeneric's platformInvalidate() can deadlock when called on the RunLoop's thread
2204         https://bugs.webkit.org/show_bug.cgi?id=166645
2205
2206         Reviewed by Carlos Garcia Campos.
2207
2208         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
2209         (TestWebKitAPI::TEST):
2210
2211 2017-01-03  Andy Estes  <aestes@apple.com>
2212
2213         Place all the Cocoa WebCore API tests in the same directory
2214         https://bugs.webkit.org/show_bug.cgi?id=166673
2215
2216         Reviewed by Michael Catanzaro.
2217
2218         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2219         * TestWebKitAPI/Tests/WebCore/cocoa/SerializedCryptoKeyWrap.mm: Renamed from Tools/TestWebKitAPI/Tests/WebCore/SerializedCryptoKeyWrap.mm.
2220         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm: Renamed from Tools/TestWebKitAPI/Tests/Cocoa/URLExtras.mm.
2221         * TestWebKitAPI/Tests/WebCore/cocoa/WebCoreNSURLSession.mm: Renamed from Tools/TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm.
2222
2223 2017-01-03  Tim Horton  <timothy_horton@apple.com>
2224
2225         NSSpellChecker's recordResponse isn't called for unseen automatic corrections
2226         https://bugs.webkit.org/show_bug.cgi?id=166450
2227         <rdar://problem/29447824>
2228
2229         Reviewed by Darin Adler.
2230
2231         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2232         * DumpRenderTree/TestRunner.cpp:
2233         (TestRunner::staticFunctions):
2234         * DumpRenderTree/mac/TestRunnerMac.mm:
2235         (setSpellCheckerLoggingEnabledCallback):
2236         * DumpRenderTree/win/TestRunnerWin.cpp:
2237         (setSpellCheckerLoggingEnabledCallback):
2238         * DumpRenderTree/mac/DumpRenderTree.mm:
2239         (resetWebViewToConsistentStateBeforeTesting):
2240         * DumpRenderTree/mac/DumpRenderTreeSpellChecker.h: Added.
2241         * DumpRenderTree/mac/DumpRenderTreeSpellChecker.mm: Added.
2242         (stringForCorrectionResponse):
2243         (drt_NSSpellChecker_recordResponseToCorrection):
2244         (swizzleNSSpellCheckerMethodsIfNeeded):
2245         (setSpellCheckerLoggingEnabled):
2246         Add a new testRunner method, setSpellCheckerLoggingEnabled, which, when
2247         set to true, logs to stdout (which ends up in the test result) whenever
2248         NSSpellChecker recordResponse:toCorrection:forWord:language:inSpellDocumentWithTag:
2249         is called, and then calls the original method. It is reset to false between tests.
2250
2251 2017-01-03  Sam Weinig  <sam@webkit.org>
2252
2253         Make WTF::Expected support Ref template parameters
2254         https://bugs.webkit.org/show_bug.cgi?id=166662
2255
2256         Reviewed by Alex Christensen.
2257
2258         * TestWebKitAPI/Tests/WTF/Expected.cpp:
2259         (TestWebKitAPI::TEST):
2260         Add tests for using Ref with Expected.
2261
2262 2017-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
2263
2264         [GTK] Expose WebKitSecurityOrigin API
2265         https://bugs.webkit.org/show_bug.cgi?id=166632
2266
2267         Reviewed by Carlos Garcia Campos.
2268
2269         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
2270         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSecurityOrigin.cpp: Added.
2271         (testSecurityOriginBasicConstructor):
2272         (testSecurityOriginURIConstructor):
2273         (testSecurityOriginDefaultPort):
2274         (testSecurityOriginFileURI):
2275         (testSecurityOriginDataURI):
2276         (beforeAll):
2277         (afterAll):
2278
2279 2017-01-03  Carlos Garcia Campos  <cgarcia@igalia.com>
2280
2281         [GTK] HTTP auth layout tests are flaky
2282         https://bugs.webkit.org/show_bug.cgi?id=158919
2283
2284         Reviewed by Michael Catanzaro.
2285
2286         * gtk/jhbuild.modules: Update libsoup to version 2.57.1.
2287         * gtk/jhbuildrc: Stop passing --enable-introspection unconditionally to all modules. We don't really need
2288         introspection for the dependencies in the internal build, and it makes newer libsoup build fail because of
2289         missing valac in the bots.
2290
2291 2017-01-03  Carlos Garcia Campos  <cgarcia@igalia.com>
2292
2293         REGRESSION(r173753): [GTK] Source/WebKit is distributed in tarballs
2294         https://bugs.webkit.org/show_bug.cgi?id=165797
2295
2296         Reviewed by Michael Catanzaro.
2297
2298         Move directory ruleset after all exclude rules of Source rulset.
2299
2300         * gtk/manifest.txt.in:
2301
2302 2017-01-02  Yusuke Suzuki  <utatane.tea@gmail.com>
2303
2304         Leverage Substring to create new AtomicStringImpl for StaticStringImpl and SymbolImpl
2305         https://bugs.webkit.org/show_bug.cgi?id=166636
2306
2307         Reviewed by Darin Adler.
2308
2309         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
2310         (TestWebKitAPI::TEST):
2311
2312 2017-01-02  Manuel Rego Casasnovas  <rego@igalia.com>
2313
2314         [GTK] WebCore/CSSParser unit test is not being built
2315         https://bugs.webkit.org/show_bug.cgi?id=166492
2316
2317         Reviewed by Michael Catanzaro.
2318
2319         This test was introduced in r175930, but we were not building
2320         it on GTK+ port since r176015.
2321         This patch marks the test to be built again on GTK+.
2322         JFTR, the test is passing right now.
2323
2324         * TestWebKitAPI/PlatformGTK.cmake: Add CSSParser.cpp test file and use
2325         ADD_WHOLE_ARCHIVE_TO_LIBRARIES to avoid linking errors.
2326
2327 2017-01-02  Chris Fleizach  <cfleizach@apple.com>
2328
2329         AX: Expose block quote level to iOS API
2330         https://bugs.webkit.org/show_bug.cgi?id=166629
2331         <rdar://problem/29834793>
2332
2333         Reviewed by Darin Adler.
2334
2335         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2336         (AccessibilityUIElement::numberAttributeValue):
2337         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2338         (WTR::AccessibilityUIElement::numberAttributeValue):
2339
2340 2016-12-31  Michael Catanzaro  <mcatanzaro@igalia.com>
2341
2342         SecurityOrigin::create triplet constructor does not canonicalize port
2343         https://bugs.webkit.org/show_bug.cgi?id=166624
2344
2345         Reviewed by Daniel Bates.
2346
2347         * TestWebKitAPI/PlatformGTK.cmake:
2348         * TestWebKitAPI/PlatformWin.cmake:
2349         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2350         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp: Added.
2351         (TestWebKitAPI::SecurityOriginTest::SetUp):
2352         (TestWebKitAPI::TEST_F):
2353
2354 2016-12-30  Michael Catanzaro  <mcatanzaro@igalia.com>
2355
2356         [GTK] Improve user agent construction
2357         https://bugs.webkit.org/show_bug.cgi?id=142074
2358
2359         Reviewed by Carlos Garcia Campos.
2360
2361         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
2362         (TestWebKitAPI::assertUserAgentForURLHasChromeBrowserQuirk):
2363         (TestWebKitAPI::assertUserAgentForURLHasFirefoxBrowserQuirk):
2364         (TestWebKitAPI::assertUserAgentForURLHasLinuxPlatformQuirk):
2365         (TestWebKitAPI::assertUserAgentForURLHasMacPlatformQuirk):
2366         (TestWebKitAPI::TEST):
2367
2368 2016-12-27  Michael Catanzaro  <mcatanzaro@igalia.com>
2369
2370         [GTK] Improve user agent construction
2371         https://bugs.webkit.org/show_bug.cgi?id=142074
2372
2373         Reviewed by Carlos Garcia Campos.
2374
2375         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
2376         (TestWebKitAPI::TEST):
2377
2378 2016-12-23  Simon Fraser  <simon.fraser@apple.com>
2379
2380         REGRESSION (r209299): Selection is broken when you zoom in webpage using trackpad
2381         https://bugs.webkit.org/show_bug.cgi?id=166472
2382         rdar://problem/29675551
2383
2384         Reviewed by Tim Horton.
2385
2386         These changes are necessary to allow the mouse to leave the WTR window while
2387         drag-scrolling, to test autoscroll. Previously, we were never calling -mouseDragged
2388         (which DRT does); we'd always go through mouseMoved, which hits an early return
2389         in WebViewImpl::mouseMoved() when the point is outside the view.
2390
2391         * WebKitTestRunner/mac/EventSenderProxy.mm:
2392         (WTR::EventSenderProxy::mouseMoveTo):
2393
2394 2016-12-23  Andy Estes  <aestes@apple.com>
2395
2396         [iOS] Fix some crashing webarchive tests
2397         https://bugs.webkit.org/show_bug.cgi?id=166470
2398
2399         Reviewed by Andreas Kling.
2400
2401         Tests that use TestRunner.dumpDOMAsWebArchive() crashed on iOS due to a stub implementation
2402         of WebArchiveDumpSupport in WebKitTestRunner. The Mac implementation works fine on iOS too,
2403         so this change uses that on both platforms.
2404
2405         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig: Removed
2406         WebArchiveDumpSupportMac.mm from EXCLUDED_SOURCE_FILE_NAMES.
2407         * WebKitTestRunner/InjectedBundle/cocoa/WebArchiveDumpSupportCocoa.mm: Renamed from
2408         Tools/WebKitTestRunner/mac/WebArchiveDumpSupportMac.mm.
2409         * WebKitTestRunner/PlatformMac.cmake:
2410         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2411         * WebKitTestRunner/ios/WebArchiveDumpSupportIOS.mm: Removed.
2412
2413 2016-12-22  Saam Barati  <sbarati@apple.com>
2414
2415         WebAssembly: Silence the output of the spec-tests
2416         https://bugs.webkit.org/show_bug.cgi?id=166417
2417
2418         Reviewed by Mark Lam.
2419
2420         * Scripts/run-jsc-stress-tests:
2421
2422 2016-12-22  Zhuo Li  <zachli@apple.com>
2423
2424         [Cocoa] SPI for setloadsImagesAutomatically.
2425         https://bugs.webkit.org/show_bug.cgi?id=166401.
2426
2427         Reviewed by Darin Adler.
2428
2429         * TestWebKitAPI/Tests/WebKit2Cocoa/Preferences.mm:
2430         (TEST): Test the _setLoadsImagesAutomatically SPI. By default,
2431         _loadsImagesAutomatically returns YES.
2432
2433 2016-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
2434
2435         fast/events/ios/viewport-shrink-to-fit-allows-double-tap.html is flaky/order dependent
2436         https://bugs.webkit.org/show_bug.cgi?id=161328
2437         <rdar://problem/28475977>
2438
2439         Reviewed by Darin Adler.
2440
2441         Running a test that scales the viewport and listens to a didEndZooming callback (such as
2442         viewport-shrink-to-fit-allows-double-tap.html) immediately after a test that may begin to trigger viewport
2443         scaling as the test completes (such as viewport-device-width-at-initial-scale-fast-clicks.html) may result in
2444         the didEndZooming callback of the latter test being fired early due to the previous test triggering a zoom
2445         animation. Ideally, -[WKScrollView _stopScrollingAndZoomingAnimations], which is called when committing the page
2446         load, should prevent this from happening, but from reading documentation and code inspection, this is not
2447         intended to fire any associated delegate methods or notifications of the UIScrollView, instead deferring them
2448         for later. Instead, what we need in this case is to clear out any started but not yet completed animations after
2449         we finish running a test and before we load the next test.
2450
2451         One way to do this is to remove all animations from the WKScrollView's layer, and the layers of its children,
2452         recursively. Doing so causes scrollViewDidEndZooming:withView:atScale: to fire at the end of the runloop if the
2453         previous test started zooming and then finished before zooming completed. Since this happens before the next
2454         test has a chance to run UI-side scripts, we won't end up firing this callback prematurely during the next test.
2455
2456         * WebKitTestRunner/ios/TestControllerIOS.mm:
2457         (WTR::TestController::platformResetStateToConsistentValues):
2458
2459 2016-12-22  Jer Noble  <jer.noble@apple.com>
2460
2461         Muted media element playback should not interrupt other audio playback
2462         https://bugs.webkit.org/show_bug.cgi?id=166347
2463
2464         Reviewed by Eric Carlson.
2465
2466         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2467         * TestWebKitAPI/Tests/WebKit/ios/AudioSessionCategoryIOS.mm:
2468         (TestWebKitAPI::TEST):
2469         * TestWebKitAPI/Tests/WebKit/ios/video-with-muted-audio.html: Added.
2470
2471 2016-12-22  Alejandro G. Castro  <alex@igalia.com>
2472
2473         [WebRTC] Add support for runtime PeeConnection setting, required after r209757
2474         https://bugs.webkit.org/show_bug.cgi?id=166346
2475
2476         Reviewed by Carlos Garcia Campos.
2477
2478         Enable WebRTC by default to simplify testing.
2479
2480         * MiniBrowser/gtk/main.c:
2481         (main):
2482
2483 2016-12-21  Alexey Proskuryakov  <ap@apple.com>
2484
2485         REGRESSION: API test failure: WKWebView.LocalStorageClear
2486         https://bugs.webkit.org/show_bug.cgi?id=166032
2487         <rdar://problem/29758423>
2488
2489         Reviewed by Simon Fraser.
2490
2491         Add an @autoreleasepool around the code that allocates then clears the WKWebView, 
2492         to ensure that the view is destroyed before the callback fires.
2493
2494         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
2495         (TEST):
2496
2497 2016-12-21  Saam Barati  <sbarati@apple.com>
2498
2499         WebAssembly: Import spec tests
2500         https://bugs.webkit.org/show_bug.cgi?id=166395
2501
2502         Rubber stamped by Keith Miller.
2503
2504         * Scripts/run-jsc-stress-tests:
2505
2506 2016-12-21  Alexey Proskuryakov  <ap@apple.com>
2507
2508         REGRESSION: API test failure: _WKDownload.OriginatingWebView
2509         https://bugs.webkit.org/show_bug.cgi?id=166033
2510         <rdar://problem/29758428>
2511
2512         Reviewed by Simon Fraser.
2513
2514         Add an @autoreleasepool around the code that allocates the WKWebView, 
2515         so that it can be destroyed by removing the last reference in _downloadDidStart.
2516
2517         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2518         (TEST):
2519
2520 2016-12-21  Daniel Bates  <dabates@apple.com>
2521
2522         WebKitTestRunner: Add comment to TestRunner::setCanOpenWindows()
2523         https://bugs.webkit.org/show_bug.cgi?id=166356
2524
2525         Add comment in TestRunner::setCanOpenWindows() to elaborate further on its purpose
2526         as a means to allow a test to explicit allow an embedding client to open a new windows
2527         such that the default behavior is for the embedding client to forbid such an action.
2528         The test plugins/get-url-with-blank-target.html assumes this default behavior though
2529         it is currently skipped on WebKit2 because questions were raised in the patch for
2530         <https://bugs.webkit.org/show_bug.cgi?id=43389> about its correctness and usefulness.
2531         We will need to implement TestRunner::setCanOpenWindows() should we decide to unskip
2532         this test.
2533
2534         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2535         (WTR::TestRunner::setCanOpenWindows):
2536
2537 2016-12-20  Simon Fraser  <simon.fraser@apple.com>
2538
2539         REGRESSION: API test failure: WKWebView.EvaluateJavaScriptBlockCrash
2540         https://bugs.webkit.org/show_bug.cgi?id=166031
2541
2542         Reviewed by Tim Horton.
2543         
2544         Add an @autoreleasepool around the code that allocates then clears the WKWebView, 
2545         to ensure that the view is destroyed before the callback fires.
2546
2547         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewEvaluateJavaScript.mm:
2548
2549 2016-12-20  Megan Gardner  <megan_gardner@apple.com>
2550
2551         Throw Exception when test doesn't clean up HID Events properly
2552         https://bugs.webkit.org/show_bug.cgi?id=166271
2553
2554         Reviewed by Simon Fraser.
2555
2556         Add in a check when UIScriptController is deleted to make sure that the HID event
2557         callback dictionary is empty. If it is not, and a HID event is hit, this will cause
2558         the program to crash without any good information. Crashes are race-y, and will still
2559         happen with malformed test, but the information will be much more helpful. 
2560
2561         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2562         (WTR::UIScriptController::checkForClean):
2563         * TestRunnerShared/UIScriptContext/UIScriptContext.cpp:
2564         (UIScriptContext::~UIScriptContext):
2565         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2566         (WTR::UIScriptController::checkForClean):
2567         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2568         * WebKitTestRunner/ios/HIDEventGenerator.h:
2569         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2570         (-[HIDEventGenerator checkHIDCallbacksClear]):
2571         * WebKitTestRunner/ios/TestControllerIOS.mm:
2572         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2573         (WTR::UIScriptController::checkForClean):
2574
2575 2016-12-20  Andy Estes  <aestes@apple.com>
2576
2577         [Cocoa] REGRESSION (r209558): Calling decisionHandler multiple times in webView:decidePolicyForNavigationAction:decisionHandler: leads to a crash
2578         https://bugs.webkit.org/show_bug.cgi?id=165992
2579
2580         Reviewed by Brady Eidson.
2581
2582         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2583         * TestWebKitAPI/Tests/WebKit2Cocoa/DuplicateCompletionHandlerCalls.mm: Added.
2584         (expectException):
2585         (-[DuplicateCompletionHandlerCallsDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2586         (-[DuplicateCompletionHandlerCallsDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
2587         (-[DuplicateCompletionHandlerCallsDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
2588         (-[DuplicateCompletionHandlerCallsDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
2589         (-[DuplicateCompletionHandlerCallsDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:completionHandler:]):
2590         (-[DuplicateCompletionHandlerCallsDelegate _webView:decideDatabaseQuotaForSecurityOrigin:currentQuota:currentOriginUsage:currentDatabaseUsage:expectedUsage:decisionHandler:]):
2591         (-[DuplicateCompletionHandlerCallsDelegate _webView:willSubmitFormValues:userObject:submissionHandler:]):
2592         (TEST):
2593         * TestWebKitAPI/Tests/WebKit2Cocoa/duplicate-completion-handler-calls.html: Added.
2594
2595 2016-12-20  Dean Jackson  <dino@apple.com>
2596
2597         Remove INDIE_UI
2598         https://bugs.webkit.org/show_bug.cgi?id=165881
2599         <rdar://problem/29672532>
2600
2601         Reviewed by Simon Fraser.
2602
2603         The Indie UI work has been discontinued.
2604
2605         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2606
2607 2016-12-19  Yusuke Suzuki  <utatane.tea@gmail.com>
2608
2609         [ES6] Enable ES6 Modules
2610         https://bugs.webkit.org/show_bug.cgi?id=165849
2611
2612         Reviewed by Geoffrey Garen.
2613
2614         * DumpRenderTree/mac/DumpRenderTree.mm:
2615         (resetWebPreferencesToConsistentValues):
2616         * DumpRenderTree/win/DumpRenderTree.cpp:
2617         (resetWebPreferencesToConsistentValues):
2618         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2619         (WTR::InjectedBundle::beginTesting):
2620         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2621         (WTR::TestRunner::setES6ModulesEnabled): Deleted.
2622         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2623
2624 2016-12-19  Ryan Haddad  <ryanhaddad@apple.com>
2625
2626         Repurpose bots and clean up dashboard.
2627         https://bugs.webkit.org/show_bug.cgi?id=166045
2628
2629         Reviewed by Lucas Forschler.
2630
2631         * BuildSlaveSupport/build.webkit.org-config/config.json:
2632         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
2633         (BubbleQueueServer):
2634         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
2635         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2636         (WebKitBuildbot):
2637         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2638         (table.queue-grid tr.platform.mac-os-x-yosemite img.logo): Deleted.
2639
2640 2016-12-19  Michael Catanzaro  <mcatanzaro@igalia.com>
2641
2642         [CMake] TestWebKitAPIBase links to itself
2643         https://bugs.webkit.org/show_bug.cgi?id=165985
2644
2645         Reviewed by Alex Christensen.
2646
2647         Fix CMake warning about a target linking to itself, which makes no sense.
2648
2649         * TestWebKitAPI/CMakeLists.txt:
2650
2651 2016-12-19  Michael Catanzaro  <mcatanzaro@igalia.com>
2652
2653         [GTK] GtkDoc build should be quieter
2654         https://bugs.webkit.org/show_bug.cgi?id=165994
2655
2656         Reviewed by Carlos Garcia Campos.
2657
2658         Make it not print by default.
2659
2660         * gtk/generate-gtkdoc:
2661         (get_generator_for_config):
2662         (generate_doc):
2663         * gtk/gtkdoc.py:
2664         (GTKDoc._run_command):
2665         (GTKDoc._copy_doc_files_to_output_dir):
2666
2667 2016-12-18  Simon Fraser  <simon.fraser@apple.com>
2668
2669         Expose a way for MiniBrowser to simulate header and footer banners
2670         https://bugs.webkit.org/show_bug.cgi?id=166005
2671
2672         Reviewed by Wenson Hsieh.
2673         
2674         Add a MiniBrowser menu item and setting to toggle adding space for header and footer
2675         banners. This only works in WebKit2.
2676         
2677         We need to reset these on each navigation, since newly created FrameViews
2678         don't re-fetch the header and footer height stored on Page.
2679         
2680         Also fix the signature of webView:didFinishNavigation: to follow API changes,
2681         as well as fixing webViewWebContentProcessDidTerminate:
2682
2683         * MiniBrowser/mac/SettingsController.h:
2684         * MiniBrowser/mac/SettingsController.m:
2685         (-[SettingsController _populateMenu]):
2686         (-[SettingsController validateMenuItem:]):
2687         (-[SettingsController toggleReserveSpaceForBanners:]):
2688         (-[SettingsController isSpaceReservedForBanners]):
2689         * MiniBrowser/mac/WK2BrowserWindowController.m:
2690         (-[WK2BrowserWindowController didChangeSettings]):
2691         (-[WK2BrowserWindowController webView:didFinishNavigation:]):
2692         (-[WK2BrowserWindowController webViewWebContentProcessDidTerminate:]):
2693         (-[WK2BrowserWindowController webView:didFinishLoadingNavigation:]): Deleted.
2694         (-[WK2BrowserWindowController _webViewWebProcessDidCrash:]): Deleted.
2695
2696 2016-12-17  Simon Fraser  <simon.fraser@apple.com>
2697
2698         Fix iOS test results after r209967.
2699         
2700         Subtracting out the status bar height was erroneously happening for all tests,
2701         not just for flexible viewport tests.
2702         
2703         Fix by plumbing WebViewSizingMode through resizeTo() and setWindowFrame().
2704
2705         * WebKitTestRunner/PlatformWebView.h:
2706         * WebKitTestRunner/TestController.cpp:
2707         (WTR::TestController::resetStateToConsistentValues):
2708         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2709         (WTR::PlatformWebView::resizeTo):
2710         (WTR::PlatformWebView::setWindowFrame):
2711         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
2712         (WTR::PlatformWebView::resizeTo):
2713         (WTR::PlatformWebView::setWindowFrame):
2714         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2715         (WTR::PlatformWebView::resizeTo):
2716         (WTR::PlatformWebView::setWindowFrame):
2717         * WebKitTestRunner/ios/TestControllerIOS.mm:
2718         (WTR::TestController::platformConfigureViewForTest):
2719         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2720         (WTR::PlatformWebView::resizeTo):
2721         (WTR::PlatformWebView::setWindowFrame):
2722
2723 2016-12-17  Joonghun Park  <jh718.park@samsung.com>
2724
2725         [EFL] bump EFL version to 1.18.4
2726         https://bugs.webkit.org/show_bug.cgi?id=166004
2727
2728         Reviewed by Gyuyoung Kim.
2729
2730         * efl/jhbuild.modules: Use efl-1.18.4 instead of 1.18.1.
2731
2732 2016-12-17  Wenson Hsieh  <wenson_hsieh@apple.com>
2733
2734         Visual viewports: bottom fixed elements disappear behind the keyboard
2735         https://bugs.webkit.org/show_bug.cgi?id=165983
2736         <rdar://problem/29409852>
2737
2738         Reviewed by Simon Fraser.
2739
2740         Add support for UIScriptController.inputViewBounds, which UI-side scripts may use to fetch the bounding rect of
2741         the keyboard when it is up.
2742
2743         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2744         (WTR::UIScriptController::inputViewBounds):
2745         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2746         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2747         (WTR::UIScriptController::inputViewBounds):
2748         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2749         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2750         (WTR::viewRectForWindowRect):
2751
2752         Previously, we accounted for the status bar height by translating the entire web view down by the height of the
2753         status bar. However, we did not shrink the height of the web view itself, which means that for tests which
2754         involve scrolling past the end of the document, the bottom strip of the web view is out of bounds of the window.
2755
2756         (WTR::PlatformWebView::PlatformWebView):
2757         (WTR::PlatformWebView::setWindowFrame):
2758         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2759         (WTR::UIScriptController::inputViewBounds):
2760
2761 2016-12-16  Ryosuke Niwa  <rniwa@webkit.org>
2762
2763         Deleting a character converted from pinyin after an image causes a Safari crash
2764         https://bugs.webkit.org/show_bug.cgi?id=165839
2765         <rdar://problem/27951933>
2766
2767         Reviewed by Wenson Hsieh.
2768
2769         Add a WebKit API test to call attributedSubstringForProposedRange on a WKWebView
2770         while the proposed range contains an image. This should not cause a WebProcess to crash
2771         or send an invalid message to the UIProcess.
2772
2773         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2774         * TestWebKitAPI/Tests/WebKit2/chinese-character-with-image.html: Added.
2775         * TestWebKitAPI/Tests/WebKit2/mac/AttributedSubstringForProposedRangeWithImage.mm: Added.
2776         (TestWebKitAPI::didFinishLoadForFrame):
2777         (TestWebKitAPI::processDidCrash):
2778         (TestWebKitAPI::invalidMessageFunction):
2779         (TestWebKitAPI::WebKit2.AttributedSubstringForProposedRangeWithImage):
2780
2781 2016-12-16  Wenson Hsieh  <wenson_hsieh@apple.com>
2782
2783         Visual viewports: carets and selection UI are incorrectly positioned when editing fixed elements
2784         https://bugs.webkit.org/show_bug.cgi?id=165767
2785         <rdar://problem/29602382>
2786
2787         Reviewed by Simon Fraser.
2788
2789         Introduces two new UIScriptController methods: doAfterWebPageIsInStableState and textSelectionCaretRect. See
2790         WebKit2 ChangeLog for more details.
2791
2792         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2793         (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
2794         (WTR::UIScriptController::textSelectionCaretRect):
2795         * DumpRenderTree/mac/UIScriptControllerMac.mm:
2796         (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
2797         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2798         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2799         (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
2800         (WTR::UIScriptController::textSelectionCaretRect):
2801         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2802         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2803         (-[TestRunnerWKWebView _setStableStateOverride:]):
2804
2805         Force the WKWebView to update its visible content rects when changing the stable state override.
2806
2807         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2808         (WTR::toNSDictionary):
2809         (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
2810         (WTR::UIScriptController::selectionRangeViewRects):
2811         (WTR::UIScriptController::textSelectionCaretRect):
2812         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
2813         (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
2814
2815 2016-12-15  Brent Fulgham  <bfulgham@apple.com>
2816
2817         Arguments called in wrong order
2818         https://bugs.webkit.org/show_bug.cgi?id=165923
2819
2820         Reviewed by Simon Fraser.
2821
2822         The 'audioDeviceUIDs' array is being passed to the argument that expects video devices,
2823         and the 'videoDeviceUIDs' array is being passed to the audo device argument. Fix this.
2824
2825         * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp:
2826         (TestWebKitAPI::decidePolicyForUserMediaPermissionRequestCallBack): The
2827         order of arguments to WKUserMediaPermissionRequestAllow are flipped.
2828
2829 2016-12-16  Hunseop Jeong  <hs85.jeong@samsung.com>
2830
2831         [EFL] Disable non-srcdir builds for failing libraries
2832         https://bugs.webkit.org/show_bug.cgi?id=165896
2833
2834         Reviewed by Gyuyoung Kim.
2835
2836         * efl/jhbuild.modules: Set non srcdir builds to no
2837
2838 2016-12-15  Daniel Bates  <dabates@apple.com>
2839
2840         check-style should not complain about code in icu directories
2841         https://bugs.webkit.org/show_bug.cgi?id=53929
2842
2843         Reviewed by Darin Adler.
2844
2845         Skip style checking of imported ICU headers to avoid a deluge of style issues
2846         as they do not conform to the WebKit Code Style guideline. We want to preserve
2847         the formatting of these headers so as to make it straightforward to merge
2848         changes to them, if necessary.
2849
2850         * Scripts/webkitpy/style/checker.py:
2851
2852 2016-12-15  Alexey Proskuryakov  <ap@apple.com>
2853
2854         Move JSC testers from Yosemite to Sierra
2855         https://bugs.webkit.org/show_bug.cgi?id=165925
2856
2857         Reviewed by Lucas Forschler.
2858
2859         * BuildSlaveSupport/build.webkit.org-config/config.json:
2860         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2861         (WebKitBuildbot):
2862
2863 2016-12-15  Megan Gardner  <megan_gardner@apple.com>
2864
2865         Add coordinate space to event streams and streamline tests
2866         https://bugs.webkit.org/show_bug.cgi?id=165119
2867
2868         Reviewed by Simon Fraser.
2869
2870         Update event streams to allow for both content and global coordinate space.
2871         Update example script to more accurately show all the available options.
2872
2873         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2874         * WebKitTestRunner/ios/HIDEventGenerator.h:
2875         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2876         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2877         (WTR::convertCoordinates):
2878         (WTR::UIScriptController::sendEventStream):
2879
2880 2016-12-15  Claudio Saavedra  <csaavedra@igalia.com>
2881
2882         [GTK] Ensure gst* docs are not built with update-webkitgtk-libs
2883         https://bugs.webkit.org/show_bug.cgi?id=165855
2884
2885         Reviewed by Philippe Normand.
2886
2887         GStreamer's autogen.sh enables gtk-doc always so we end up building
2888         docs even if we disable them. Use the configure script instead, since
2889         we build from packages and these include it already.
2890
2891         * gtk/jhbuild.modules: Use shipped configure instead of autogen.sh for
2892         upstream gstreamer packages.
2893
2894 2016-12-15  Alex Christensen  <achristensen@webkit.org>
2895
2896         REGRESSION (r208902) Null pointer dereference in wkIsPublicSuffix
2897         https://bugs.webkit.org/show_bug.cgi?id=165885
2898         <rdar://problem/29476917>
2899
2900         Reviewed by Darin Adler.
2901
2902         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2903         (TestWebKitAPI::utf16String): Deleted.
2904         * TestWebKitAPI/Tests/mac/PublicSuffix.mm:
2905         (TestWebKitAPI::TEST_F):
2906         * TestWebKitAPI/WTFStringUtilities.h:
2907         (utf16String):
2908         Moved from URLParser to share with other tests.
2909
2910 2016-12-14  Ryosuke Niwa  <rniwa@webkit.org>
2911
2912         iOS: An element with tabindex is not focusable unless there is no mouse event handler
2913         https://bugs.webkit.org/show_bug.cgi?id=165843
2914
2915         Reviewed by Antti Koivisto.
2916
2917         Add testRunner.isWebKit2 which is always true in WebKitTestRunner.
2918         Without this, it's really hard to reliably differentiate DumpRenderTree and WebKitTestRunner,
2919         and DumpRenderTree's runUIScript would hit an assertion :(
2920
2921         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2922         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2923         (WTR::TestRunner::isWebKit2):
2924
2925 2016-12-14  Brady Eidson  <beidson@apple.com>
2926
2927         IndexedDB 2.0: Massively speedup IDBIndex.get().
2928         https://bugs.webkit.org/show_bug.cgi?id=165802
2929
2930         Reviewed by Alex Christensen.
2931
2932         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2933         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBIndexUpgradeToV2.html: Added.
2934         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBIndexUpgradeToV2.mm: Added.
2935         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexUpgrade.blob: Added.
2936         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexUpgrade.sqlite3: Added.
2937
2938 2016-12-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2939
2940         [GTK][EFL] Update the JHBuild version.
2941         https://bugs.webkit.org/show_bug.cgi?id=165838
2942
2943         Reviewed by Michael Catanzaro.
2944
2945         * jhbuild/jhbuild-wrapper: This new version fixes a bug with the
2946         usage of the JHBUILD_MIRROR feature with git repositories.
2947
2948 2016-12-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2949
2950         [GTK] Yasm is needed for building the JHBuild after r208940
2951         https://bugs.webkit.org/show_bug.cgi?id=165837
2952
2953         Reviewed by Alejandro G. Castro.
2954
2955         * gtk/install-dependencies: Yasm is needed for building libvpx.
2956
2957 2016-12-14  Youenn Fablet  <youenn@apple.com>
2958
2959         Test infrastructure should allow to filter out text output before doing a comparison with the baseline
2960         https://bugs.webkit.org/show_bug.cgi?id=161310
2961
2962         Reviewed by Ryosuke Niwa.
2963
2964         Adding --dump-jsconsolelog-in-stderr test option for DRT and WTR.
2965         When set, WTR and DRT output JS console log in the stderr and not the test output.
2966         This allows removing potentially flaky information while still being able to read it for investigation.
2967
2968         Updated webkitpy infrastructure to use this test option in case of DumpJSConsoleLogInStdErr modifier.
2969
2970         Changes are covered by updating a fetch test to output console log and set its option to --dump-jsconsolelog-in-stderr in TestExpectations.
2971         This test should have this option when fetch API will start logging resource loader errors.
2972
2973         * DumpRenderTree/DumpRenderTree.h:
2974         (TestCommand::TestCommand): Deleted.
2975         * DumpRenderTree/DumpRenderTreeCommon.cpp:
2976         (parseInputLine):
2977         * DumpRenderTree/TestRunner.h:
2978         (TestRunner::setDumpJSConsoleLogInStdErr):
2979         (TestRunner::dumpJSConsoleLogInStdErr):
2980         * DumpRenderTree/mac/DumpRenderTree.mm:
2981         (runTest):
2982         * DumpRenderTree/mac/UIDelegate.mm:
2983         (-[UIDelegate webView:addMessageToConsole:withSource:]):
2984         * DumpRenderTree/win/DumpRenderTree.cpp:
2985         (runTest):
2986         * DumpRenderTree/win/UIDelegate.cpp:
2987         (UIDelegate::webViewAddMessageToConsole):
2988         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2989         (TestExpectationParser._tokenize_line):
2990         * Scripts/webkitpy/port/driver.py:
2991         (Driver._command_from_driver_input):
2992         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2993         (WTR::InjectedBundle::didReceiveMessageToPage):
2994         (WTR::InjectedBundle::dumpToStdErr):
2995         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2996         (WTR::InjectedBundle::dumpJSConsoleLogInStdErr):
2997         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2998         (WTR::InjectedBundlePage::willAddMessageToConsole):
2999         * WebKitTestRunner/TestController.cpp:
3000         (WTR::parseInputLine):
3001         (WTR::TestController::runTest):
3002         (WTR::TestCommand::TestCommand): Deleted.
3003         * WebKitTestRunner/TestInvocation.cpp:
3004         (WTR::TestInvocation::invoke):
3005         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3006         * WebKitTestRunner/TestInvocation.h:
3007         (WTR::TestInvocation::setDumpJSConsoleLogInStdErr):
3008
3009
3010 2016-12-14  Enrique Ocaña González  <eocanha@igalia.com>
3011
3012         REGRESSION(r207879-207891): [GStreamer] Introduced many layout test failures and crashes, bots exiting early
3013         https://bugs.webkit.org/show_bug.cgi?id=164022
3014
3015         Reviewed by Xabier Rodriguez-Calvar.
3016
3017         * Scripts/webkitperl/FeatureList.pm:
3018           Re-enable MEDIA_SOURCE for the GTK+ port.
3019
3020 2016-12-13  Alex Christensen  <achristensen@webkit.org>
3021
3022         Fix CMake build.
3023
3024         * DumpRenderTree/PlatformMac.cmake:
3025         Define NS_RETURNS_RETAINED as nothing for now.
3026
3027 2016-12-13  Jer Noble  <jer.noble@apple.com>
3028
3029         Fullscreen in WebKit2 does not restore topContentInset upon exiting; leaves top of page not visible
3030         https://bugs.webkit.org/show_bug.cgi?id=165697
3031
3032         Reviewed by Tim Horton.
3033
3034         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenTopContentInset.mm:
3035         (TestWebKitAPI::TEST):
3036
3037 2016-12-13  Andy Estes  <aestes@apple.com>
3038
3039         [Cocoa] Implement -shouldInsertText: on WKWebProcessPlugInEditingDelegate
3040         https://bugs.webkit.org/show_bug.cgi?id=165785
3041         <rdar://problem/26929398>
3042
3043         Reviewed by Darin Adler.
3044
3045         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegate.mm:
3046         (-[BundleEditingDelegateRemoteObject shouldInsertText:replacingRange:givenAction:]): Added
3047         expectations for the text, range, and action.
3048         (TEST): Set the "EditingDelegateShouldInsertText" bundle parameter to NO so that the plug-in
3049         will return NO in -_webProcessPlugInBrowserContextController:willInsertText:. Added a
3050         plain-text string to the pasteboard, executed a paste action, and verified that the selected
3051         text in the web view did not change.
3052         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegatePlugIn.mm:
3053         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]): Set
3054         _editingDelegateShouldInsertText according to the "EditingDelegateShouldInsertText" bundle
3055         parameter.
3056         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:shouldInsertText:replacingRange:givenAction:]):
3057         Added. Called -shouldInsertText:replacingRange:givenAction: on the remote object proxy
3058         and returned the value of _editingDelegateShouldInsertText.
3059         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegateProtocol.h: Declared
3060         -shouldInsertText:replacingRange:givenAction:.
3061
3062 2016-12-13  Chris Dumez  <cdumez@apple.com>
3063
3064         Unreviewed, rolling out r209544.
3065
3066         Looks like r209489 did not cause the performance regression
3067         after all
3068
3069         Reverted changeset:
3070
3071         "Unreviewed, rolling out r209489."
3072         https://bugs.webkit.org/show_bug.cgi?id=165550
3073         http://trac.webkit.org/changeset/209544
3074
3075 2016-12-12  Sam Weinig  <sam@webkit.org>
3076
3077         [WebIDL] Remove use of Dictionary in ApplePaySession
3078         https://bugs.webkit.org/show_bug.cgi?id=165787
3079
3080         Reviewed by Anders Carlsson.
3081
3082         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3083         (WTR::initializeWebViewConfiguration):
3084         (WTR::TestController::platformCreateWebView):
3085         Enable ApplePay for the tests (where supported).
3086
3087 2016-12-13  Eric Carlson  <eric.carlson@apple.com>
3088
3089         Annotate MediaStream and WebRTC idl with EnabledAtRuntime flag
3090         https://bugs.webkit.org/show_bug.cgi?id=165251
3091
3092         Reviewed by Youenn Fablet.
3093
3094         * TestWebKitAPI/Tests/WebKit2/EnumerateMediaDevices.cpp:
3095         (TestWebKitAPI::TEST): Enable MediaStream, create web view from the page group upon which
3096         the preferences have been set.
3097
3098 2016-12-08  Antti Koivisto  <antti@apple.com>
3099
3100         Enable network cache speculative revalidation in MiniBrowser
3101         https://bugs.webkit.org/show_bug.cgi?id=165616
3102
3103         Reviewed by Darin Adler.
3104
3105         Match Safari. Also add a menu item to disable it.
3106
3107         * MiniBrowser/mac/AppDelegate.m:
3108         (defaultConfiguration):
3109         * MiniBrowser/mac/SettingsController.h:
3110         * MiniBrowser/mac/SettingsController.m:
3111         (-[SettingsController _populateMenu]):
3112         (-[SettingsController validateMenuItem:]):
3113         (-[SettingsController networkCacheSpeculativeRevalidationDisabled]):
3114         (-[SettingsController toggleNetworkCacheSpeculativeRevalidationDisabled:]):
3115
3116 2016-12-12  Alexey Proskuryakov  <ap@apple.com>
3117
3118         ChangeLogs become readonly after resolving a conflict
3119         https://bugs.webkit.org/show_bug.cgi?id=165440
3120         rdar://problem/29491002
3121
3122         Reviewed by Darin Adler.
3123
3124         * Scripts/resolve-ChangeLogs: (resolveChangeLog): Set correct permissions when
3125         moving the file.
3126
3127 2016-12-12  Filip Pizlo  <fpizlo@apple.com>
3128
3129         Re-enable collectContinuously since it doesn't crash anymore
3130
3131         Rubber stamped by Michael Saboff.
3132
3133         * Scripts/run-jsc-stress-tests:
3134
3135 2016-12-11  Konstantin Tokarev  <annulen@yandex.ru>
3136
3137         Unreviewed attempt to fix EFL and Mac/cmake builds after r209665.
3138         https://bugs.webkit.org/show_bug.cgi?id=165686
3139
3140         * DumpRenderTree/CMakeLists.txt: WebKit2 should precede other target
3141         so that right config.h comes first in include path.
3142
3143 2016-12-11  Dave Hyatt  <hyatt@apple.com>
3144
3145         [CSS Parser] Make sure content extensions initialize AtomicString
3146         https://bugs.webkit.org/show_bug.cgi?id=165737
3147
3148         Reviewed by Darin Adler.
3149
3150         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3151         (TestWebKitAPI::makeBackend):
3152
3153 2016-12-08  Dave Hyatt  <hyatt@apple.com>
3154
3155         [CSS Parser] Remove the old CSS Parser
3156         https://bugs.webkit.org/show_bug.cgi?id=165645
3157
3158         Reviewed by Daniel Bates.
3159
3160         * TestWebKitAPI/Tests/WebCore/CSSParser.cpp:
3161         (TestWebKitAPI::TEST):
3162
3163 2016-12-10  Konstantin Tokarev  <annulen@yandex.ru>
3164
3165         [cmake] Include WTF, JSC, and WebCore headers automatically to targers using them
3166         https://bugs.webkit.org/show_bug.cgi?id=165686
3167
3168         Reviewed by Michael Catanzaro.
3169
3170         This change reduces duplication of include path lists between modules,
3171         and reduces future need for fixes like r209605 (broken build because of
3172         WebCore header suddenly becoming used in WebKit2).
3173
3174         * DumpRenderTree/CMakeLists.txt:
3175         * DumpRenderTree/PlatformMac.cmake:
3176         * ImageDiff/CMakeLists.txt:
3177         * MiniBrowser/gtk/CMakeLists.txt:
3178         * MiniBrowser/mac/CMakeLists.txt:
3179         * MiniBrowser/win/CMakeLists.txt:
3180         * TestWebKitAPI/CMakeLists.txt:
3181         * TestWebKitAPI/PlatformEfl.cmake:
3182         * TestWebKitAPI/PlatformJSCOnly.cmake:
3183         * TestWebKitAPI/PlatformMac.cmake:
3184         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
3185         * WebKitTestRunner/CMakeLists.txt:
3186         * WebKitTestRunner/PlatformGTK.cmake:
3187         * WebKitTestRunner/PlatformMac.cmake:
3188
3189 2016-12-09  Csaba Osztrogonác  <ossy@webkit.org>
3190
3191         Unreviewed buildfix after r209630.
3192
3193         * Scripts/build-jsc: Remove building the non-existing testWASM.
3194
3195 2016-12-09  Eric Carlson  <eric.carlson@apple.com>
3196
3197         Annotate MediaStream and WebRTC idl with EnabledAtRuntime flag
3198         https://bugs.webkit.org/show_bug.cgi?id=165251
3199
3200         Reviewed by Dean Jackson.
3201
3202         Based on a patch by Dr Alex Gouaillard <agouaillard@gmail.com>
3203
3204         * DumpRenderTree/mac/DumpRenderTree.mm:
3205         (resetWebPreferencesToConsistentValues): Enable MediaStream and PeerConnection.
3206
3207         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3208         (WTR::InjectedBundle::beginTesting): Ditto.
3209
3210         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3211         (WTR::TestRunner::setMediaStreamEnabled): New.
3212         (WTR::TestRunner::setPeerConnectionEnabled): New.
3213         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3214
3215 2016-12-09  Brady Eidson  <beidson@apple.com> 
3216  
3217         Re-landing:
3218         Add _WKIconLoadingDelegate SPI. 
3219         https://bugs.webkit.org/show_bug.cgi?id=164894 
3220  
3221         Reviewed by Alex Christensen. 
3222         
3223         Add MiniBrowser support for this new SPI, configurable with a setting. 
3224  
3225         * MiniBrowser/mac/SettingsController.h: 
3226         * MiniBrowser/mac/SettingsController.m: 
3227         (-[SettingsController _populateMenu]): 
3228         (-[SettingsController validateMenuItem:]): 
3229         (-[SettingsController loadsAllSiteIcons]): 
3230         (-[SettingsController toggleLoadsAllSiteIcons:]): 
3231         * MiniBrowser/mac/WK2BrowserWindowController.m: 
3232         (-[WK2BrowserWindowController awakeFromNib]): 
3233         (-[WK2BrowserWindowController webView:shouldLoadIconWithParameters:completionHandler:]): 
3234
3235 2016-12-09  Ryan Haddad  <ryanhaddad@apple.com>
3236
3237         Fix the 32-bit build.
3238
3239         Unreviewed build fix.
3240
3241         * MiniBrowser/mac/SettingsController.h:
3242
3243 2016-12-09  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
3244
3245         Fedora also needs a PHP7 config file alternative
3246         https://bugs.webkit.org/show_bug.cgi?id=165606
3247
3248         Reviewed by Michael Catanzaro.
3249
3250         * Scripts/webkitpy/port/base.py:
3251         (Port._is_fedora_php_version_7): check for the php7 library.
3252         (Port._fedora_php_version): get the appropriate filename for Fedora.
3253         (Port._apache_config_file_name_for_platform):
3254
3255 2016-12-09  Ryan Haddad  <ryanhaddad@apple.com>
3256
3257         Complete the revert of r208865.
3258         https://bugs.webkit.org/show_bug.cgi?id=164894
3259
3260         Unreviewed build fix.
3261
3262         * MiniBrowser/mac/SettingsController.h:
3263         * MiniBrowser/mac/SettingsController.m:
3264         (-[SettingsController _populateMenu]):
3265         (-[SettingsController validateMenuItem:]):
3266         (-[SettingsController loadsAllSiteIcons]): Deleted.
3267         (-[SettingsController toggleLoadsAllSiteIcons:]): Deleted.
3268         * MiniBrowser/mac/WK2BrowserWindowController.m:
3269         (-[WK2BrowserWindowController awakeFromNib]):
3270         (-[WK2BrowserWindowController webView:shouldLoadIconWithParameters:completionHandler:]): Deleted.
3271
3272 2016-12-09  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
3273
3274         [GTK] Force GDK backend to x11 when running with XvfbDriver
3275         https://bugs.webkit.org/show_bug.cgi?id=165612
3276
3277         Reviewed by Michael Catanzaro.
3278
3279         When the developer is running a Wayland session, GDK may get confused
3280         and try to use its Wayland backend (which is higher priority) instead.
3281         This ensures it will use the appropriate backend when running under
3282         Xvfb.
3283
3284         * Scripts/webkitpy/port/gtk.py:
3285         (GtkPort.setup_environ_for_server): when running with XvfbDriver,
3286         force GDK_BACKEND to x11.
3287
3288 2016-12-08  Keith Miller  <keith_miller@apple.com>
3289
3290         Add 64-bit signed LEB decode method
3291         https://bugs.webkit.org/show_bug.cgi?id=165630
3292
3293         Reviewed by Ryosuke Niwa.
3294
3295         Add tests for LEB int64 and uint64 decode since I guess
3296         I forgot to add tests before.
3297
3298         * TestWebKitAPI/Tests/WTF/LEBDecoder.cpp:
3299         (TestWebKitAPI::testUInt32LEBDecode):
3300         (TestWebKitAPI::TEST):
3301         (TestWebKitAPI::testUInt64LEBDecode):
3302         (TestWebKitAPI::testInt32LEBDecode):
3303         (TestWebKitAPI::testInt64LEBDecode):
3304         (TestWebKitAPI::testUnsignedLEBDecode): Deleted.
3305
3306 2016-12-08  Filip Pizlo  <fpizlo@apple.com>
3307
3308         Make it easy to enable --force-collectContinuously
3309         https://bugs.webkit.org/show_bug.cgi?id=165638
3310
3311         Reviewed by Keith Miller.
3312
3313         * Scripts/run-javascriptcore-tests:
3314         (runJSCStressTests):
3315
3316 2016-12-08  Filip Pizlo  <fpizlo@apple.com>
3317
3318         Disable the collectContinuously mode until I investigate failures.
3319
3320         Rubber stamped by Keith Miller.
3321         
3322         I'm seeing collectContinuously crashes on some platforms. Disabling that testing mode
3323         while I investigate.
3324
3325         * Scripts/run-jsc-stress-tests:
3326
3327 2016-12-08  Alex Christensen  <achristensen@webkit.org>
3328
3329         REGRESSION (URL parser): Relative URLs aren’t resolved correctly when the base URL is an applewebdata: URL
3330         https://bugs.webkit.org/show_bug.cgi?id=165621
3331
3332         Reviewed by Dan Bernstein.
3333
3334         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3335         (TestWebKitAPI::TEST_F):
3336
3337 2016-12-06  Filip Pizlo  <fpizlo@apple.com>
3338
3339         Concurrent GC should be stable enough to land enabled
3340         https://bugs.webkit.org/show_bug.cgi?id=164990
3341
3342         Reviewed by Geoffrey Garen.
3343         
3344         Add a new mode that runs GC continuously. Also made eager modes run GC continuously.
3345         
3346         It's clear that this works just fine in release, but I'm still trying to figure out if it's
3347         safe for debug. It might be too slow for debug.
3348
3349         * Scripts/run-jsc-stress-tests:
3350
3351 2016-12-08  Alex Christensen  <achristensen@webkit.org>
3352
3353         Add SPI for sending WebsiteSettings to WebProcess during navigation
3354         https://bugs.webkit.org/show_bug.cgi?id=165517
3355         <rdar://29341068>
3356
3357         Reviewed by Anders Carlsson.
3358
3359         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3360         * TestWebKitAPI/Tests/WebKit2/contentBlockerCheck.html: Added.
3361         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm: Added.
3362         (-[WebsitePoliciesDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3363         (-[WebsitePoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
3364         (-[WebsitePoliciesDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
3365         (TEST):
3366
3367 2016-12-08  Chris Dumez  <cdumez@apple.com>
3368
3369         Unreviewed, rolling out r209489.
3370
3371         Likely caused large regressions on JetStream, Sunspider and
3372         Speedometer
3373
3374         Reverted changeset:
3375
3376         "Add system trace points for JavaScript VM entry/exit"
3377         https://bugs.webkit.org/show_bug.cgi?id=165550
3378         http://trac.webkit.org/changeset/209489
3379
3380 2016-12-08  Keith Miller  <keith_miller@apple.com>
3381
3382         Move LEB tests to API tests
3383         https://bugs.webkit.org/show_bug.cgi?id=165586
3384
3385         Reviewed by Saam Barati.
3386
3387         Move the tests from testWasm.cpp and make them functions
3388         rather than macros.
3389
3390         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3391         * TestWebKitAPI/Tests/WTF/LEBDecoder.cpp: Added.
3392         (TestWebKitAPI::testUnsignedLEBDecode):
3393         (TestWebKitAPI::TEST):
3394         (TestWebKitAPI::testInt32LEBDecode):
3395
3396 2016-12-08  Chris Dumez  <cdumez@apple.com>
3397
3398         Support running the layout tests offline
3399         https://bugs.webkit.org/show_bug.cgi?id=165534
3400
3401         Reviewed by Ryosuke Niwa.
3402
3403         * Scripts/webkitpy/common/system/autoinstall.py:
3404         (AutoInstaller._download_to_stream):
3405         getcode() returns None for file URLs so handle this.
3406
3407         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
3408         (WebPlatformTestServer._install_modules):
3409         Deal with local path in the json file and resolve them into file URLs
3410         before using AutoInstall.
3411
3412 2016-12-08  Alex Christensen  <achristensen@webkit.org>
3413
3414         Fix CMake build.
3415
3416         * DumpRenderTree/PlatformMac.cmake:
3417         Remove CheckedMalloc.cpp after r209516.
3418
3419 2016-12-07  Mark Lam  <mark.lam@apple.com>
3420
3421         DumpRenderTree should stop using CheckedMalloc.
3422         https://bugs.webkit.org/show_bug.cgi?id=165563
3423         <rdar://problem/28945820>
3424
3425         Reviewed by Geoffrey Garen.
3426
3427         1. WebKitTestRunner does not have equivalent behavior to that which is implemented
3428            in CheckedMalloc.
3429         2. bmalloc does not honor the settings of CheckedMalloc.
3430
3431         The only time CheckedMalloc comes into play is when DRT uses gmalloc or system
3432         malloc.  As a result, DRT exhibits different behavior from the normal way we run
3433         our tests.  We should obsolete CheckedMalloc and make DRT behave consistently
3434         with WKTR.
3435
3436         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3437         * DumpRenderTree/mac/CheckedMalloc.cpp: Removed.
3438         * DumpRenderTree/mac/CheckedMalloc.h: Removed.
3439         * DumpRenderTree/mac/DumpRenderTree.mm:
3440         (prepareConsistentTestingEnvironment):
3441
3442 2016-12-07  Dean Jackson  <dino@apple.com>
3443
3444         Remove runtime toggle for pointer-lock
3445         https://bugs.webkit.org/show_bug.cgi?id=165577
3446         <rdar://problems/29566996>
3447
3448         Reviewed by Jon Lee.
3449
3450         Remove any runtime calls to check if pointer-lock is enabled. It's
3451         either compiled in or out.
3452
3453         * DumpRenderTree/mac/DumpRenderTree.mm:
3454         (resetWebPreferencesToConsistentValues):
3455         * WebKitTestRunner/TestController.cpp:
3456         (WTR::TestController::resetPreferencesToConsistentValues):
3457
3458 2016-12-07  Eric Carlson  <eric.carlson@apple.com>
3459
3460         [MediaStream][Mac] Revoke sandbox extensions when capture ends
3461         https://bugs.webkit.org/show_bug.cgi?id=165476
3462
3463         Reviewed by Brady Eidson.
3464         
3465         Add a test which loads a page that calls navigator.mediaDevices.enumerateDevices, kills the
3466         page, and loads the same page again to ensure that the WK2 UserMediaPermissionRequestManagerProxy
3467         is reset and recreated when a web page exits and is reloaded.
3468
3469         * TestWebKitAPI/PlatformGTK.cmake:
3470         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3471         * TestWebKitAPI/Tests/WebKit2/EnumerateMediaDevices.cpp: Added.
3472         (TestWebKitAPI::checkUserMediaPermissionCallback):
3473         (TestWebKitAPI::TEST):
3474         * TestWebKitAPI/Tests/WebKit2/enumerateMediaDevices.html: Added.
3475
3476 2016-12-07  Jeremy Jones  <jeremyj@apple.com>
3477
3478         One esc to exit fullscreen and pointer lock
3479         https://bugs.webkit.org/show_bug.cgi?id=165416
3480         rdar://problem/29430711
3481
3482         Reviewed by Jer Noble.
3483
3484         Implement WKPageUIClientV8 for pointer lock support.
3485         Add "escape" key support in EventSenderProxy.
3486
3487         * WebKitTestRunner/TestController.cpp:
3488         (WTR::requestPointerLock):
3489         (WTR::TestController::createOtherPage):
3490         (WTR::TestController::createWebViewWithOptions):
3491         * WebKitTestRunner/mac/EventSenderProxy.mm:
3492         (WTR::EventSenderProxy::keyDown):
3493
3494 2016-12-07  Simon Fraser  <simon.fraser@apple.com>
3495
3496         Add system trace points for JavaScript VM entry/exit
3497         https://bugs.webkit.org/show_bug.cgi?id=165550
3498
3499         Reviewed by Tim Horton.
3500
3501         Add trace points for entry/exit into/out of the JS VM.
3502
3503         * Tracing/SystemTracePoints.plist:
3504
3505 2016-12-07  ChangSeok Oh  <changseok@webkit.org>
3506
3507         [GTK] Cannot build GTK+ with CUPS 2.* versions
3508         https://bugs.webkit.org/show_bug.cgi?id=163591
3509
3510         Reviewed by Michael Catanzaro.
3511
3512         GTK+ build has failed on the system which CUPS 2.x is installed in. GTK+ 3.16.4
3513         does not assume to use the recent CUPS thus it fails to detect the CUPS in configuration.
3514         GTK+ upstream fixed this issue but it is not easy to apply the original patch to our
3515         old gtk+ since it requires not only bumping up glib accordingly and its consequence
3516         causes many printing test failures. So, I propose to fix the configuration issue by
3517         applying the change to the configure file directly. By doing this, we don't need to
3518         upgrade glib and worry about any test failures as a consequence of the upgraded glib.
3519
3520         * gtk/jhbuild.modules:
3521         * gtk/patches/gtk+-configure-fix-detecting-CUPS-2.x.patch: Added.
3522
3523 2016-12-07  Simon Fraser  <simon.fraser@apple.com>
3524
3525         Fix use of enum in a WK2 C SPI header.
3526         rdar://problem/28725583
3527
3528         Followup to correctly prefix the enum values.
3529
3530         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3531         (WTR::InjectedBundlePage::prepare):
3532
3533 2016-12-07  Simon Fraser  <simon.fraser@apple.com>
3534
3535         Fix use of enum in a WK2 C SPI header.
3536         rdar://problem/28725583
3537
3538         Reviewed by Dan Bernstein.
3539
3540         Use correct enum style for a C SPI header and fix the callers.
3541
3542         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3543         (WTR::InjectedBundlePage::prepare):
3544
3545 2016-12-07  Wenson Hsieh  <wenson_hsieh@apple.com>
3546
3547         Add a new project for recording and playing back editing commands in editable web content
3548         https://bugs.webkit.org/show_bug.cgi?id=165114
3549         <rdar://problem/29408135>
3550
3551         Reviewed by Beth Dakin.
3552
3553         Adds a new Xcode project containing work towards rewinding and playing back editing commands. This work is
3554         wrapped in an Xcode project to take advantage of the XCTest framework. To manually test recording, open the
3555         capture test harness, edit the contenteditable body, and then hit cmd-S. This downloads a .json file which may
3556         then be dragged into the playback test harness.
3557
3558         Also adds 3 new unit tests in EditingHistoryTests/RewindAndPlaybackTests.m. These tests carry out the following
3559         steps:
3560
3561         1. Load the capture harness and perform test-specific editing on the web view.
3562         2. Let originalState be a dump of the DOM at this point in time.
3563         3. Extract the JSON-serialized editing history data and load the playback harness with this data.
3564         4. Rewind all editing to the beginning.
3565         5. Playback all editing to the end.
3566         6. Dump the state of the DOM. This should be identical to originalState.
3567
3568         * EditingHistory/EditingHistory.xcodeproj/project.pbxproj: Added.
3569         * EditingHistory/EditingHistory/Info.plist: Added.
3570         * EditingHistory/EditingHistory/Resources/CaptureHarness.html: Added.
3571         * EditingHistory/EditingHistory/Resources/DOMTestingUtil.js: Added.
3572         * EditingHistory/EditingHistory/Resources/PlaybackHarness.html: Added.
3573         * EditingHistory/EditingHistory/TestRunner.h: Added.
3574         * EditingHistory/EditingHistory/TestRunner.m: Added.
3575         (injectedMessageEventHandlerScript):
3576         (-[TestRunner init]):
3577         (-[TestRunner deleteBackwards:]):
3578         (-[TestRunner typeString:]):
3579         (-[TestRunner bodyElementSubtree]):
3580         (-[TestRunner bodyTextContent]):
3581         (-[TestRunner editingHistoryJSON]):
3582         (-[TestRunner loadPlaybackTestHarnessWithJSON:]):
3583         (-[TestRunner numberOfUpdates]):
3584         (-[TestRunner jumpToUpdateIndex:]):
3585         (-[TestRunner expectEvents:afterPerforming:]):
3586         (-[TestRunner loadCaptureTestHarness]):
3587         (-[TestRunner setTextObfuscationEnabled:]):
3588         (-[TestRunner isDoneWaitingForPendingEvents]):
3589         (-[TestRunner userContentController:didReceiveScriptMessage:]):
3590
3591         The TestRunner provides utilities that a unit test should use to drive the test forward (e.g. loading harnesses)
3592         or inspect the state of the loaded page (e.g. extracting JSON editing history data from the capture harness).
3593
3594         * EditingHistory/EditingHistory/TestUtil.h: Added.
3595         * EditingHistory/EditingHistory/TestUtil.m: Added.
3596         (waitUntilWithTimeout):
3597         (waitUntil):
3598
3599         Provides utilities for running tests. For now, this is just spinning the runloop on a given condition.
3600
3601         * EditingHistory/EditingHistory/WKWebViewAdditions.h: Added.
3602         * EditingHistory/EditingHistory/WKWebViewAdditions.m: Added.
3603         (-[WKWebView loadPageFromBundleNamed:]):
3604         (-[WKWebView typeCharacter:]):
3605         (-[WKWebView keyPressWithCharacters:keyCode:]):
3606         (-[WKWebView stringByEvaluatingJavaScriptFromString:]):
3607
3608         Provides utilities for simulating interaction in a web view.
3609
3610         * EditingHistory/EditingHistory/main.m: Added.
3611         (main):
3612         * EditingHistory/EditingHistoryTests/Info.plist: Added.
3613         * EditingHistory/EditingHistoryTests/RewindAndPlaybackTests.m: Added.
3614         (-[RewindAndPlaybackTests setUp]):
3615         (-[RewindAndPlaybackTests tearDown]):
3616         (-[RewindAndPlaybackTests testTypingSingleLineOfText]):
3617         (-[RewindAndPlaybackTests testTypingMultipleLinesOfText]):
3618         (-[RewindAndPlaybackTests testTypingAndDeletingText]):
3619         (-[RewindAndPlaybackTests rewindAndPlaybackEditingInPlaybackTestHarness]):
3620         (-[RewindAndPlaybackTests originalBodySubtree:isEqualToFinalSubtree:]):
3621
3622 2016-12-07  Philippe Normand  <pnormand@igalia.com>
3623
3624         [GTK][jhbuild] missing dependency on libvpx in gst-plugins-good
3625         https://bugs.webkit.org/show_bug.cgi?id=165525
3626
3627         Reviewed by Carlos Garcia Campos.
3628
3629         * gtk/jhbuild.modules: gst-plugins-good should depend on the
3630         libvpx package built within jhbuild.
3631
3632 2016-12-07  Philippe Normand  <pnormand@igalia.com>
3633
3634         [GTK][jhbuild] gst-plugins-bad fails to build with OpenSSL 1.1.0
3635         https://bugs.webkit.org/show_bug.cgi?id=165520
3636
3637         Reviewed by Carlos Garcia Campos.
3638
3639         * gtk/jhbuild.modules: Added missing dependency on openh264 in
3640         gst-plugins-bad, along with 2 upstream patches fixing the build
3641         against OpenSSL 1.1.0.
3642         * gtk/patches/gst-plugins-bad-0001-dtls-port-to-OpenSSL-1.1.0.patch: Added.
3643         * gtk/patches/gst-plugins-bad-0002-dtlscertificate-Fix-error-checking-in-RSA_generate_k.patch: Added.
3644
3645 2016-12-06  Alexey Proskuryakov  <ap@apple.com>
3646
3647         Correct SDKROOT values in xcconfig files
3648         https://bugs.webkit.org/show_bug.cgi?id=165487
3649         rdar://problem/29539209
3650
3651         Reviewed by Dan Bernstein.
3652
3653         Fix suggested by Dan Bernstein.
3654
3655         * ContentExtensionTester/Configurations/DebugRelease.xcconfig:
3656         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
3657         * MiniBrowser/Configurations/DebugRelease.xcconfig:
3658         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
3659         * WebEditingTester/Configurations/DebugRelease.xcconfig:
3660         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
3661
3662 2016-12-06  Daniel Bates  <dabates@apple.com>
3663
3664         WebKitTestRunner: Plugins are disabled in new windows
3665         https://bugs.webkit.org/show_bug.cgi?id=165410
3666
3667         Reviewed by Alex Christensen.
3668
3669         Currently WebKitTestRunner only enables plugins in the main window. So, a test that opens
3670         a new window and loads a plugin will fail. We should enable plugins in all windows by
3671         default. Moreover toggling testRunner.setPluginsEnabled() should effect all windows.
3672
3673         Making these changes is a step towards running plugins/open-and-close-window-with-plugin.html
3674         in WebKitTestRunner (we still need to fix <https://bugs.webkit.org/show_bug.cgi?id=46714>) and
3675         will make the behavior of WebKitTestRunner more closely match the behavior DumpRenderTree.
3676
3677         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3678         (WTR::InjectedBundle::beginTesting): Call TestRunner::setPluginsEnabled() instead of
3679         WKBundleSetPluginsEnabled().
3680         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3681         (WTR::TestRunner::setPluginsEnabled): Take a similar approach as TestRunner::setXSSAuditorEnabled()
3682         and make use of WKBundleOverrideBoolPreferenceForTestRunner().
3683
3684 2016-12-05  Dean Jackson  <dino@apple.com>
3685
3686         pointer lock needs to be feature detectable
3687         https://bugs.webkit.org/show_bug.cgi?id=165426
3688         <rdar://problem/29486715>
3689
3690         Reviewed by Antoine Quint.
3691
3692         Expose the comment line to turn on/off pointer lock.
3693
3694         * DumpRenderTree/TestOptions.h:
3695         * DumpRenderTree/TestOptions.mm:
3696         (TestOptions::TestOptions):
3697         * DumpRenderTree/mac/DumpRenderTree.mm:
3698         (resetWebPreferencesToConsistentValues):
3699         * WebKitTestRunner/TestController.cpp:
3700         (WTR::TestController::resetPreferencesToConsistentValues):
3701         (WTR::updateTestOptionsFromTestHeader):
3702         * WebKitTestRunner/TestOptions.h:
3703         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3704         (WTR::PlatformWebView::viewSupportsOptions):
3705         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3706         (WTR::PlatformWebView::viewSupportsOptions):
3707
3708 2016-12-05  Jonathan Bedard  <jbedard@apple.com>
3709
3710         Make it possible to use an existing simulator instance for one-off testing
3711         https://bugs.webkit.org/show_bug.cgi?id=164568
3712         <rdar://problem/29189133>
3713
3714         Reviewed by Daniel Bates.
3715
3716         With this patch, if a simulator is currently running on the machine and
3717         '--dedicated-simulators' is not passed into the application, only one simulator
3718         instance will be used, and this instance will be the existing instance.
3719         If no simulator is running or '--dedicated-simulators' is passed to the script,
3720         previous behavior will be used.
3721
3722         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3723         (parse_args):
3724         * Scripts/webkitpy/port/ios.py:
3725         (IOSSimulatorPort.__init__): Logic for enabling usage of currently running simulator.
3726         (IOSSimulatorPort._create_simulators): Only create simulators when needed, don't reset already running simulators.
3727         (IOSSimulatorPort.setup_test_run): Don't open already running simulators.
3728         (IOSSimulatorPort._quit_ios_simulator): Only quit simulators if we manage them.
3729         (IOSSimulatorPort.clean_up_test_run): Only clean up simulators if we manage them. 
3730         (IOSSimulatorPort._using_dedicated_simulators): True if simulators need to be managed, false if using an existing instance.
3731         (IOSSimulatorPort.device_id_for_worker_number): Access currently running simulator if not managing devices.
3732         * Scripts/webkitpy/xcode/simulator.py:
3733         (Simulator.refresh): Check if xcode_simctl_list returned None instead of a generator.
3734         (Simulator.current_device): Get currently running device.
3735
3736 2016-12-05  Dan Bernstein  <mitz@apple.com>