2011-02-03 Dirk Pranke <dpranke@chromium.org>
[WebKit.git] / Tools / ChangeLog
1 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
2
3         Unreviewed, build fix.
4
5         Delete a line that was accidentally missed in r77586; without it
6         there is still a race between the two threads.
7
8         https://bugs.webkit.org/show_bug.cgi?id=51572
9
10         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
11
12 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
13
14         Reviewed by Tony Chang.
15
16         nrwt: handle "broken pipe" notifications from DRT more cleanly.
17
18         https://bugs.webkit.org/show_bug.cgi?id=52927
19
20         * Scripts/webkitpy/layout_tests/port/server_process.py:
21         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
22
23 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
24
25         Reviewed by Kenneth Russell.
26
27         Update, resubmit change to bug 51572. I think the race that was
28         fixed in r76703 caused the hang that caused us to roll this
29         patch out before, so I'd like to try again.
30
31         https://bugs.webkit.org/show_bug.cgi?id=51572
32
33         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
34         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
35
36 2011-02-03  Daniel Cheng  <dcheng@chromium.org>
37
38         Unreviewed.
39
40         Adding myself to committers.py.
41
42         * Scripts/webkitpy/common/config/committers.py:
43
44 2011-02-03  Adam Roben  <aroben@apple.com>
45
46         Include the crashing function in the link to a crash log
47
48         Fixes <http://webkit.org/b/53739> Crash log links in results.html should include the
49         function that crashed
50
51         Reviewed by David Kilzer.
52
53         * Scripts/old-run-webkit-tests:
54         (crashLocation): Added. Returns the location of the crash.
55         (linksForErrorTest): Include the crash location in the link text for the crash log, if one
56         could be determined.
57
58 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
59
60         Unreviewed, build fix.
61
62         Actually make the changes suggested by Mihai in his review
63         of bug 53720 :(
64
65         https://bugs.webkit.org/show_bug.cgi?id=53720
66
67         * Scripts/webkitpy/layout_tests/port/test_files.py:
68         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
69
70 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
71
72         Reviewed by Mihai Parparita.
73
74         new-run-webkit-tests: Fix bug introduced in r77434 that was
75         causing us to run the canvas GPU tests on the Mac GPU port. This
76         bug revealed that we were not setting the port.name() field
77         properly in many cases, so I've cleaned up all of that code, and
78         removed a few comments about "version-specific" GPU ports that
79         don't exist and just confused things.
80
81         Testing also revealed that port.abspath_for_test() wasn't
82         normalizing paths on Windows properly, so I fixed that as well.
83
84         https://bugs.webkit.org/show_bug.cgi?id=53719
85
86         * Scripts/webkitpy/layout_tests/port/base.py:
87         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
88         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
89
90 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
91
92         Reviewed by Mihai Parparita.
93
94         new-run-webkit-tests: fix normalization of paths on windows when gathering files
95
96         r77434 introduced a bug that was causing the test expectations
97         for the GPU ports to not be treated properly. It turns out that
98         when we gathered the list of test files on Windows, we would
99         return paths of the form "c:\LayoutTests/fast/canvas", and the
100         mixture of backslashes and forward slashes was confusing things.
101
102         This patch normalizes all of the filenames returned from
103         test_files.find(), and adds better tests for this (fixing a
104         couple of other bugs found in the meantime).
105
106         https://bugs.webkit.org/show_bug.cgi?id=53720
107
108         * Scripts/webkitpy/layout_tests/port/test.py:
109         * Scripts/webkitpy/layout_tests/port/test_files.py:
110         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
111
112 2011-02-03  Adam Roben  <aroben@apple.com>
113
114         Add links to Windows crash logs in results.html
115
116         Fixes <http://webkit.org/b/53718> run-webkit-tests should link to Windows crash logs in
117         results.html
118
119         Reviewed by David Kilzer.
120
121         * Scripts/old-run-webkit-tests:
122         (top level): Added $crashLogTag and $windowsCrashLogFilePrefix (which came from
123         createDebuggerCommandFile).
124         (testCrashedOrTimedOut): If the test crashed, capture any saved crash log after the dump
125         tool has exited.
126         (captureSavedCrashLog): Added. Finds the crash log for the test that just crashed and moves
127         it into the test results directory tree. Only implemented for Cygwin currently.
128         (findNewestFileMatchingGlob): Added. Does what it says.
129         (htmlForResultsSection): Only link to files that exist.
130         (linksForErrorTest): Add a link to the crash log.
131         (deleteExpectedAndActualResults): Delete any old crash log for this test.
132         (createDebuggerCommandFile): Use the new $windowsCrashLogFilePrefix constant instead of
133         hardcoding it here.
134
135 2011-02-03  Adam Roben  <aroben@apple.com>
136
137         Tell the debugger the path to the WebKit source tree when saving a crash log
138
139         This allows the debugger to include the crashing line of code in the log.
140
141         Fixes <http://webkit.org/b/53678> Crash logs from buildslaves don't show the crashing line
142         of code
143
144         Reviewed by Sam Weinig.
145
146         * Scripts/old-run-webkit-tests:
147         (createDebuggerCommandFile): Added. Saves commands that we'd like the debugger to run to a
148         file and returns the path to that file. The commands we pass came from
149         setUpWindowsCrashLogSaving, but I've added a .srcpath command to tell the debugger where the
150         WebKit source code lives.
151         (setUpWindowsCrashLogSaving): Instead of specifying the commands directly on the command
152         line using -c, save them to a file and specify the path to that file using -cf. This works
153         around what is presumably a bug in Windows's command line parsing, where having multiple
154         quoted paths in the debugger commands causes the post-mortem debugger not to be invoked at
155         all. Also pulled the options we pass to the debugger out into a list that is then join()ed
156         together to make them easier to modify in the future.
157
158 2011-02-02  Sam Weinig  <sam@webkit.org>
159
160         Reviewed by Anders Carlsson.
161
162         Add notification of the end of a rubber band.
163         <rdar://problem/8940648>
164
165         * MiniBrowser/mac/BrowserWindowController.m:
166         (-[BrowserWindowController awakeFromNib]):
167         * WebKitTestRunner/TestController.cpp:
168         (WTR::TestController::createOtherPage):
169         (WTR::TestController::initialize):
170         Stub out the new WKUIClient function.
171
172 2011-02-03  Gabor Rapcsanyi  <rgabor@webkit.org>
173
174         Unreviewed.
175
176         Adding myself to committers.py.
177
178         * Scripts/webkitpy/common/config/committers.py:
179
180 2011-02-03  Balazs Kelemen  <kbalazs@webkit.org>
181
182         Reviewed by Csaba Osztrogonác.
183
184         [Qt][WK2] MiniBrowser's window size should be 800x600
185         https://bugs.webkit.org/show_bug.cgi?id=53670
186
187         Make layout test failure debugging easier.
188         * MiniBrowser/qt/BrowserWindow.cpp:
189         (BrowserWindow::BrowserWindow):
190
191 2011-02-02  Andy Estes  <aestes@apple.com>
192
193         Reviewed by Mark Rowe.
194
195         'update-webkit' should handle OpenSource and Internal using different
196         VCSs.
197
198         * Scripts/update-webkit: Re-check the VCS type when updating Apple's
199         Internal directory.
200
201 2011-02-02  Dirk Pranke  <dpranke@chromium.org>
202
203         Reviewed by Mihai Parparita.
204
205         new-run-webkit-tests: hardcode the directories to scan for tests
206         for GPU bots instead of SKIPping them. See bug 53562 for some
207         context, but we will now hard-code the list of directories to
208         use by default instead of skipping over directories in the
209         expectations file. We do this so that we will be able to merge
210         the expectations files without getting conflicting SKIP
211         directives. Note that this change will reduce the # of tests
212         being run on the Mac GPU bots, because we're accidentally
213         including some today.
214
215         https://bugs.webkit.org/show_bug.cgi?id=53631
216
217         * Scripts/webkitpy/layout_tests/port/base.py:
218         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
219         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
220
221 2011-02-02  Sam Weinig  <sam@webkit.org>
222
223         Reviewed by Beth Dakin.
224
225         Add ChromeClient function to paint custom overhang areas.
226         https://bugs.webkit.org/show_bug.cgi?id=53639
227
228         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
229         (WTR::InjectedBundlePage::InjectedBundlePage):
230         Stub out new callback.
231
232 2011-02-02  Dirk Pranke  <dpranke@chromium.org>
233
234         Reviewed by Tony Chang.
235
236         new-run-webkit-tests: support chromium code paths in mock_drt
237
238         https://bugs.webkit.org/show_bug.cgi?id=53471
239
240         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
241         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
242
243 2011-02-02  Adam Klein  <adamk@chromium.org>
244
245         Reviewed by Tony Chang.
246
247         Update new-run-webkit-tests --chromium to put output under Source/...
248         https://bugs.webkit.org/show_bug.cgi?id=53612
249
250         * BuildSlaveSupport/test-result-archive:
251         * Scripts/webkitpy/layout_tests/port/chromium.py:
252
253 2011-01-28  Tony Chang  <tony@chromium.org>
254
255         Reviewed by Eric Seidel.
256
257         [chromium] remove --use-test-shell from NRWT
258         https://bugs.webkit.org/show_bug.cgi?id=53346
259
260         I've already started removing some of the bindings like eventSender so
261         this already doesn't work isn't useful.  Also updated some comments to
262         refer to DRT instead of test_shell.
263
264         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
265         * Scripts/webkitpy/layout_tests/port/chromium.py:
266         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
267         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
268         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
269         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
270         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
271         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
272
273 2011-02-02  Steve Lacey  <sjl@chromium.org>
274
275         Reviewed by Eric Carlson.
276
277         Implement basic media statistics on media elements.
278         https://bugs.webkit.org/show_bug.cgi?id=53322
279
280         * Scripts/build-webkit:
281
282 2011-02-02  Kevin Ollivier  <kevino@theolliviers.com>
283
284         [wx] Build fixes for wxWebKit.
285
286         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
287         (LayoutTestController::setSerializeHTTPLoads):
288         * wx/browser/wscript:
289         * wx/build/build_utils.py:
290         * wx/build/settings.py:
291
292 2011-02-01  Dirk Pranke  <dpranke@chromium.org>
293
294         Reviewed by Mihai Parparita.
295
296         new-run-webkit-tests: stop skipping so many tests
297
298         r77163 introduced a regression where we weren't resetting test
299         expectations properly and were skipping too many tests as a
300         result. This patch fixes that and adds a test for it.
301
302         https://bugs.webkit.org/show_bug.cgi?id=53551
303
304         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
305         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
306
307 2011-02-01  Dirk Pranke  <dpranke@chromium.org>
308
309         Reviewed by Tony Chang.
310
311         new-run-webkit-tests: add first stub of test_runner2. This
312         will add support for the 'inline', 'threads', and 'processes'
313         flags to --worker-model, but for now the implementatios just
314         fall back on the old ones.
315
316         https://bugs.webkit.org/show_bug.cgi?id=53157
317
318         * Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
319         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
320
321 2011-02-01  Mihai Parparita  <mihaip@chromium.org>
322
323         Reviewed by James Robinson.
324
325         [Chromium] run-chromium-webkit-unit-tests looks for binaries in the wrong place
326         https://bugs.webkit.org/show_bug.cgi?id=53522
327
328         * Scripts/run-chromium-webkit-unit-tests:
329
330 2011-02-01  Adam Barth  <abarth@webkit.org>
331
332         Reviewed by Mihai Parparita.
333
334         Using Control-C to cancel webkit-patch or other python tools causes
335         unpleasant traceback console spew
336         https://bugs.webkit.org/show_bug.cgi?id=53462
337
338         Catch the exception and don't print the stack trace.
339
340         * Scripts/webkit-patch:
341
342 2011-02-01  Scott Cameron  <sccameron@rim.com>
343
344         Reviewed by Daniel Bates.
345
346         Use Windows format for MinGW HTTPD path.
347         https://bugs.webkit.org/show_bug.cgi?id=53503
348
349         * Scripts/webkitperl/httpd.pm:
350           - Use single-quotes around MySys value for $httpdPath in getHTTPDPath()
351             so that we don't have to escape the space characters in the path. Also,
352             changed path to Windows-style path and removed FIXME comment.
353
354 2011-02-01  Balazs Kelemen  <kbalazs@webkit.org>
355
356         Reviewed by Andreas Kling.
357
358         [Qt][WK2] Add a way to use shared process model in MiniBrowser
359         https://bugs.webkit.org/show_bug.cgi?id=53090
360
361         * MiniBrowser/qt/BrowserView.cpp:
362         (BrowserView::BrowserView): Removed the m_context member.
363         From now the context is guaranteed to be non-null and we
364         don't need to store that in the object.
365         * MiniBrowser/qt/BrowserView.h:
366         * MiniBrowser/qt/BrowserWindow.cpp:
367         Added static bool to determine that new windows need to be
368         created with their own context or not. Use the same context
369         and web process by default to be inilne with the other ports.
370         (BrowserWindow::BrowserWindow):
371         (BrowserWindow::newWindow):
372         * MiniBrowser/qt/BrowserWindow.h:
373         * MiniBrowser/qt/main.cpp:
374         (main): Added command line switch to be able to use the
375         non-shared process model. Simplify the handling of the command line
376         switches a little bit.
377
378 2011-02-01  Zoltan Horvath  <zoltan@webkit.org>
379
380         Reviewed by Andreas Kling.
381
382         [Qt] Add Window menu and Toggle FullScreen action to MiniBrowser.
383         https://bugs.webkit.org/show_bug.cgi?id=53491
384
385         * MiniBrowser/qt/BrowserWindow.cpp:
386         (BrowserWindow::BrowserWindow):
387         (BrowserWindow::toggleFullScreenMode):
388         * MiniBrowser/qt/BrowserWindow.h:
389
390 2011-02-01  Zoltan Horvath  <zoltan@webkit.org>
391
392         Reviewed by Andreas Kling.
393
394         [Qt] Add Toggle Frame Flattening, Auto Load Images and Disable JavaScript actions to MiniBrowser.
395         https://bugs.webkit.org/show_bug.cgi?id=53489
396
397         Add Toggle Frame Flattening action to Develop menu. Add Auto Load Images and Disable JavaScript actions
398         to Settings menu.
399
400         * MiniBrowser/qt/BrowserWindow.cpp:
401         (BrowserWindow::BrowserWindow):
402         (BrowserWindow::toggleFrameFlattening):
403         (BrowserWindow::toggleDisableJavaScript):
404         (BrowserWindow::toggleAutoLoadImages):
405         * MiniBrowser/qt/BrowserWindow.h:
406
407 2011-01-31  Mihai Parparita  <mihaip@chromium.org>
408
409         Reviewed by Tony Chang.
410
411         [Chromium] Switch chromium-mac to use ChromiumDriver
412         https://bugs.webkit.org/show_bug.cgi?id=53461
413         
414         For the sake of consistency with the other Chromium platforms (and so
415         that chromium-mac picks up special flags like --enable-hardware-gpu),
416         switch chromium-mac from the WebKitDriver to ChromiumDriver.
417
418         * Scripts/webkitpy/layout_tests/port/chromium.py:
419
420 2011-01-31  Dirk Pranke  <dpranke@chromium.org>
421
422         Reviewed by Mihai Parparita.
423
424         The current modifier parsing code in test_expectations is
425         fragile and hard-coded, so it's not easy to understand the logic
426         or easily add new types of modifiers (like GPU vs. CPU testing
427         for graphics tests, or 32-bit vs. 64-bit differences).
428
429         This is the first of two patches that will add in more generic
430         support and then eliminate the GPU-specific test expectations
431         files for Chromium.
432
433         This patch adds two standalone objects for handling modifiers. The
434         rules for interpreting modifiers, precedence, and conflicts are
435         given in the docstring to the ModifierMatcher class, which
436         returns ModifierMatchResult objects.
437         
438         This patch also adds routines to the Port interface and a
439         default set of values in the base object, in order to obtain the
440         values needed on a given test run. These values are then passed
441         to the expectation parser. This also allows us to clean up the
442         logic used to lint all of the different configurations in a
443         single test_expectations.txt file.
444
445         The next patch will merge in the separate GPU expectations file.
446
447         https://bugs.webkit.org/show_bug.cgi?id=51222
448
449         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
450         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
451         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
452         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
453         * Scripts/webkitpy/layout_tests/port/base.py:
454         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
455         * Scripts/webkitpy/layout_tests/port/chromium.py:
456         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
457         * Scripts/webkitpy/layout_tests/port/test.py:
458         * Scripts/webkitpy/layout_tests/port/webkit.py:
459         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
460         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
461         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
462         * Tools/Scripts/webkitpy/style/checkers/test_expectations.py:
463         * Tools/Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
464
465 2011-01-31  Scott Cameron  <sccameron@rim.com>
466
467         Reviewed by Daniel Bates.
468
469         update run-webkit-httpd to be able to launch Apache2.2 in a MSYS environment
470         https://bugs.webkit.org/show_bug.cgi?id=50036
471
472         This will add an Apache2.2 configuration file and modifies scripts to allow
473         running an httpd server in an MSYS environment.
474
475         The default Apache2.2 installation path has been preserved and PHP5 modules disabled
476         in order to allow for simple installation/execution.  Simply install the latest
477         Apache2.2 version with OpenSSL from http://httpd.apache.org/download.cgi#apache22 to
478         be able to execute run-webkit-httpd.
479         
480
481         * Scripts/run-webkit-httpd:
482         * Scripts/webkitperl/httpd.pm:
483
484 2011-01-31  Tony Chang  <tony@chromium.org>
485
486         Reviewed by Eric Seidel.
487
488         mac DRT should report RTL scroll offset relative to top right corner
489         https://bugs.webkit.org/show_bug.cgi?id=53324
490
491         * DumpRenderTree/mac/DumpRenderTree.mm:
492         (dumpFrameScrollPosition):
493
494 2011-01-31  Zoltan Horvath  <zoltan@webkit.org>
495
496         Reviewed by Andreas Kling.
497
498         [Qt] Add Take Screen Shot action to MiniBrowser
499         https://bugs.webkit.org/show_bug.cgi?id=53422
500
501         Add Take Screen Shot action to MiniBrowser's view menu.
502
503         * MiniBrowser/qt/BrowserWindow.cpp:
504         (BrowserWindow::BrowserWindow):
505         (BrowserWindow::screenshot):
506         * MiniBrowser/qt/BrowserWindow.h:
507
508 2011-01-31  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
509
510         Reviewed by Xan Lopez.
511
512         [GTK] REGRESSION:  http/tests/media/video-{cookie,referer}.html failing
513         https://bugs.webkit.org/show_bug.cgi?id=53379
514
515         Remove left over #ifdef's. I thought all of the conditional code
516         had been freed from the condition, but I forgot to check DRT.
517
518         * DumpRenderTree/gtk/DumpRenderTree.cpp:
519         (resetDefaultsToConsistentValues):
520         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
521         (LayoutTestController::setAlwaysAcceptCookies):
522
523 2011-01-30  Dirk Pranke  <dpranke@chromium.org>
524
525         Unreviewed, build fix.
526
527         Fix regression introduced in r77093 - path.rsplit() doesn't
528         take keyword arguments.
529
530         https://bugs.webkit.org/show_bug.cgi?id=53326
531
532         * Scripts/webkitpy/common/system/filesystem_mock.py:
533
534 2011-01-30  Dirk Pranke  <dpranke@chromium.org>
535
536         Reviewed by Mihai Parparita.
537
538         Add more unit tests for rebaseline-chromium-webkit-tests. This
539         change involves restructuring a bunch of r-c-w-t code to make it
540         more testable as well. We also add wrapper classes for handling
541         testing zip files and fetching URLs.
542
543         https://bugs.webkit.org/show_bug.cgi?id=53040
544
545         * Scripts/webkitpy/common/system/urlfetcher.py:
546         * Scripts/webkitpy/common/system/urlfetcher_mock.py:
547         * Scripts/webkitpy/common/system/zipfileset_mock.py:
548         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
549         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
550         * Scripts/webkitpy/tool/mocktool.py:
551
552 2011-01-30  Dirk Pranke  <dpranke@chromium.org>
553
554         Reviewed by Eric Seidel.
555
556         Clean up of the filesystem-related modules used in webkitpy.
557         I've added relpath() to the filesystem interface, modified
558         ospath.relpath() so that it could work with the filesystem
559         interface, and modified the fileset* routines to use the
560         filesystem interface consistently.
561
562         This patch also adds a close() routine to the fileset routines
563         to indicate that the caller is done with the fileset. This
564         allows zipfileset to clean up after itself when it creates
565         tempfiles to store downloads.
566
567         https://bugs.webkit.org/show_bug.cgi?id=53326
568
569         * Scripts/webkitpy/common/system/directoryfileset.py:
570         * Scripts/webkitpy/common/system/fileset.py:
571         * Scripts/webkitpy/common/system/filesystem.py:
572         * Scripts/webkitpy/common/system/filesystem_mock.py:
573         * Scripts/webkitpy/common/system/filesystem_unittest.py:
574         * Scripts/webkitpy/common/system/ospath.py:
575         * Scripts/webkitpy/common/system/zipfileset.py:
576         * Scripts/webkitpy/common/system/zipfileset_unittest.py:
577
578 2011-01-30  Balazs Kelemen  <kbalazs@webkit.org>
579
580         Reviewed by Csaba Osztrogonác.
581
582         [Qt][WK2]REGRESSION (r76991): Fix build errors
583         https://bugs.webkit.org/show_bug.cgi?id=53400
584
585         Revert the temporary build fix (http://trac.webkit.org/changeset/77088)
586         and remove WebKit2Prefix.h from the build.
587         * MiniBrowser/qt/MiniBrowser.pro:
588
589 2011-01-30  Csaba Osztrogonác  <ossy@webkit.org>
590
591         Unreviewed.
592
593         [Qt][WK2] Buildfix.
594
595         * MiniBrowser/qt/MiniBrowser.pro:
596
597 2011-01-28  Simon Fraser  <simon.fraser@apple.com>
598
599         Reviewed by Adam Roben.
600         
601         define NOMINMAX when building ImageDiff, as we do elsewhere.
602
603         Add various clampToInt() methods to MathExtras.h
604         https://bugs.webkit.org/show_bug.cgi?id=52910
605
606         * DumpRenderTree/win/ImageDiffCommon.vsprops:
607
608 2011-01-28  Maciej Stachowiak  <mjs@apple.com>
609
610         Reviewed by Darin Adler.
611
612         WebKitTestRunner needs layoutTestController.setPOSIXLocale
613         https://bugs.webkit.org/show_bug.cgi?id=42682
614
615         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
616         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
617         (WTR::InjectedBundle::resetLocalSettings):
618         (WTR::InjectedBundle::didReceiveMessage):
619         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
620         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
621         (WTR::LayoutTestController::setPOSIXLocale):
622         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
623
624 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
625  
626          Reviewed by Mihai Parparita.
627  
628          test-webkitpy: fix webkitpy.layout_tests.port.mac_unittest.MacTest.test_skipped_file_paths
629  
630          This patch re-enables this test and changes it to
631          handle all of the mac platform versions, not just the one
632          it is running on.
633  
634          https://bugs.webkit.org/show_bug.cgi?id=53356
635  
636          * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
637  
638 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
639
640         Unreviewed, build fix.
641
642         Take two. The fix in 77023 didn't work, because we were
643         still calling path.abspath_to_uri, which calls _cygpath under
644         the covers, and it appears the cygpath on the bots does
645         something different than it does on my machine. This patch
646         removes the calls to path.abspath_to_uri, so it should be safe.
647         If it doesn't work, I'll roll it out along with r76982 and 77023.
648
649         https://bugs.webkit.org/show_bug.cgi?id=53126
650
651         * Scripts/webkitpy/layout_tests/port/test.py:
652
653 2011-01-28  David Kilzer  <ddkilzer@apple.com>
654
655         <rdar://problem/8930699> build-webkit gives a bogus warning with newer versions of Xcode 
656         <http://webkit.org/b/53353>
657
658         Reviewed by Mark Rowe.
659
660         * Scripts/webkitdirs.pm:
661         (checkRequiredSystemConfig): Check the Xcode marketing version
662         in addition to the DevCoreTools build version before complaining
663         about an old version of Xcode.  Also make the Mac OS X version
664         check use Perl's built-in version string comparitor.
665
666 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
667
668         Unreviewed, build fix.
669
670         Work around breakage on Win 7 Release bot caused by r76982
671         and the fact that windows ports use "file:////" instead of
672         "file:///". Ideally the test code should be isolated from
673         this, but it isn't yet. Will fix properly in a bit.
674
675         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
676
677 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
678
679         Reviewed by Tony Chang.
680
681         new-run-webkit-tests: change worker model values to
682         "old-inline", "old-threads" in preparation for test_runner2 /
683         multiprocessing changes.
684
685         https://bugs.webkit.org/show_bug.cgi?id=53156
686
687         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
688         * Scripts/webkitpy/layout_tests/port/base.py:
689         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
690         * Scripts/webkitpy/layout_tests/port/mac.py:
691         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
692
693 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
694
695         Reviewed by Tony Chang.
696
697         committers.py - add an IRC nickname for dpranke
698         https://bugs.webkit.org/show_bug.cgi?id=53335
699
700         * Scripts/webkitpy/common/config/committers.py:
701
702 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
703
704         Reviewed by Tony Chang.
705
706         new-run-webkit-tests: add a "mock DRT" port implementation
707         and a separate class that emulates what we expect the
708         DumpRenderTree behavior to be.
709
710         This will eventually replace port/dryrun.py and allow us to get
711         better test coverage of the new-run-webkit-tests code as well as
712         a reference for what new-run-webkit-tests expects from DRT.
713
714         This is the first attempt at this, and it is pretty bare-boned. It
715         really only has been tested on the 'mac' port (and a little on
716         the 'chromium-mac' port.
717
718         https://bugs.webkit.org/show_bug.cgi?id=53126
719
720         * Scripts/webkitpy/common/system/filesystem_mock.py:
721         * Scripts/webkitpy/layout_tests/port/dryrun.py:
722         * Scripts/webkitpy/layout_tests/port/factory.py:
723         * Scripts/webkitpy/layout_tests/port/mock_drt.py: Added.
724         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Added.
725         * Scripts/webkitpy/layout_tests/port/test.py:
726
727 2011-01-28  Pratik Solanki  <psolanki@apple.com>
728
729         Unreviewed. Removing .swp file checked in by mistake.
730
731         * Scripts/.webkitdirs.pm.swp: Removed.
732
733 2011-01-28  Pratik Solanki  <psolanki@apple.com>
734
735         Reviewed by David Kilzer.
736
737         Space not necessary for undefined feature
738         https://bugs.webkit.org/show_bug.cgi?id=53317
739
740         * Scripts/build-webkit:
741
742 2011-01-28  Chang Shu  <chang.shu@nokia.com>
743
744         Reviewed by Andreas Kling.
745
746         Reset NetworkAccessManager to clean up credentials from previous tests.
747         This change causes no performance overhead either.
748         https://bugs.webkit.org/show_bug.cgi?id=36688
749
750         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
751         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
752         (WebCore::DumpRenderTree::open):
753         * DumpRenderTree/qt/DumpRenderTreeQt.h:
754
755 2011-01-28  Zoltan Horvath  <zoltan@webkit.org>
756
757         Reviewed by Andreas Kling.
758
759         [Qt] Add Zoom Text Only action to MiniBrowser
760         https://bugs.webkit.org/show_bug.cgi?id=53297
761
762         Add Zoom Text Only action to MiniBrowser's view menu, change zoom levels to avoid unnecessary divides.
763
764         * MiniBrowser/qt/BrowserWindow.cpp:
765         (BrowserWindow::BrowserWindow):
766         (BrowserWindow::zoomIn):
767         (BrowserWindow::zoomOut):
768         (BrowserWindow::resetZoom):
769         (BrowserWindow::toggleZoomTextOnly):
770         (BrowserWindow::applyZoom):
771         * MiniBrowser/qt/BrowserWindow.h:
772
773 2011-01-28  Adam Barth  <abarth@webkit.org>
774
775         Reviewed by Eric Seidel.
776
777         Add webkit-patch roll-chromium-deps
778         https://bugs.webkit.org/show_bug.cgi?id=53288
779
780         This command updates the Source/WebKit/chromium/DEPS file with the
781         last-known good revision of Chromium (or a revision specified on the
782         command line).  I'd eventually like to turn this into a SheriffBot
783         command, but this is the first step.
784
785         This patch somewhat sprawled because I needed to move a bunch of code
786         out of ChangeLog that should never have been there in the first place.
787         Also, I had to fix a bug in MockUser in order to test the new command.
788
789         * Scripts/webkitpy/common/checkout/api.py:
790         * Scripts/webkitpy/common/checkout/changelog.py:
791         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
792         * Scripts/webkitpy/common/checkout/deps.py: Added.
793         * Scripts/webkitpy/common/config/urls.py:
794         * Scripts/webkitpy/tool/commands/__init__.py:
795         * Scripts/webkitpy/tool/commands/download_unittest.py:
796         * Scripts/webkitpy/tool/commands/roll.py: Added.
797         * Scripts/webkitpy/tool/commands/roll_unittest.py: Added.
798         * Scripts/webkitpy/tool/commands/upload_unittest.py:
799         * Scripts/webkitpy/tool/mocktool.py:
800         * Scripts/webkitpy/tool/steps/__init__.py:
801         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py: Added.
802         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
803         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py: Added.
804         * Scripts/webkitpy/tool/steps/suggestreviewers_unittest.py:
805         * Scripts/webkitpy/tool/steps/updatechromiumdeps.py: Added.
806         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
807
808 2011-01-27  Greg Coletta  <greg.coletta@nokia.com>
809
810         Reviewed by Laszlo Gombos.
811
812         Get rid of prefix header dependency for WebKit2 build system
813         https://bugs.webkit.org/show_bug.cgi?id=50174
814
815         Change the style checker so that it enforces config.h include for
816         WebKit2.
817
818         * Scripts/webkitpy/style/checker.py:
819
820 2011-01-27  Maciej Stachowiak  <mjs@apple.com>
821
822         Reviewed by Darin Adler.
823
824         execCommand("Paste") doesn't work in WebKitTestRunner
825         https://bugs.webkit.org/show_bug.cgi?id=52785
826
827         Enable both of the settings needed to allow paste.
828         
829         * WebKitTestRunner/TestController.cpp:
830         (WTR::TestController::resetStateToConsistentValues):
831
832 2011-01-27  Jacob Dinu  <dinu.jacob@nokia.com>
833
834         Reviewed by Andreas Kling.
835
836         [Qt] QtTestBrowser: User input lost when toggling use of QGraphicsView
837         https://bugs.webkit.org/show_bug.cgi?id=48440
838
839         Preserve user input when toggling use of QGraphicsView
840
841         * QtTestBrowser/launcherwindow.cpp:
842         (LauncherWindow::initializeView):
843         (LauncherWindow::loadFinished):
844         * QtTestBrowser/launcherwindow.h:
845         * QtTestBrowser/mainwindow.cpp:
846         (MainWindow::addressUrl):
847         * QtTestBrowser/mainwindow.h:
848
849 2011-01-27  Dirk Pranke  <dpranke@chromium.org>
850
851         Reviewed by Mihai Parparita.
852
853         new-run-webkit-tests: turn off pixel tests correctly by default
854         for webkit-based ports. r70013 (bug 47510) used
855         port.set_option_default() to attempt to set default values, but
856         that didn't work correctly. I have removed set_option_default
857         for now since it was only being used in two places and in three
858         useless unit tests. There is a separate bug open to fix the
859         option parsing (48095), so this workaround is fine for now.
860
861         https://bugs.webkit.org/show_bug.cgi?id=53217
862
863         * Scripts/webkitpy/layout_tests/port/webkit.py:
864         * Scripts/webkitpy/layout_tests/port/base.py:
865         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
866
867 2011-01-27  Balazs Kelemen  <kbalazs@webkit.org>
868
869         Rubber-stamped by Ariya Hidayat.
870
871         Trivial crash fix in WTR.
872
873         * WebKitTestRunner/TestController.cpp:
874         (WTR::TestController::initialize): Increase the size
875         of the vector by one to be able to store the null character.
876
877 2011-01-27  Balazs Kelemen  <kbalazs@webkit.org>
878
879         Reviewed by Csaba Osztrogonác.
880
881         [Qt][WK2] WTR should be initialized in the same way as DRT
882         https://bugs.webkit.org/show_bug.cgi?id=53240
883
884         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
885         (WTR::activateFonts): Added missing initialization steps.
886
887 2011-01-27  Joone Hur <joone.hur@collabora.co.uk>
888
889         Unreviewed. 
890
891         Adding myself to committers.py.
892
893         * Scripts/webkitpy/common/config/committers.py:
894
895 2011-01-27  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
896
897         Reviewed by Csaba Osztrogonác.
898
899         [Qt] [Symbian] Move project files into Source
900         https://bugs.webkit.org/show_bug.cgi?id=52891
901
902         Fix the Symbian build after the project files
903         are moved to Source directory. On Symbian qmake
904         needs to run in the same directory where the main
905         pro files (WebKit.pro, Tools.pro) are located.
906
907         * Scripts/webkitdirs.pm: Change to the directory where the pro file
908         is located before running qmake for Symbian. Qmake on Symbian
909         does not properly honor the "-o" option, work it around by setting
910         the name of the Makefile to bld.inf.
911
912 2011-01-27  Zoltan Horvath  <zoltan@webkit.org>
913
914         Reviewed by Andreas Kling.
915
916         [Qt] Add simple zooming features to MiniBrowser
917         https://bugs.webkit.org/show_bug.cgi?id=53231
918
919         Add View menu and Zoom In, Zoom Out, Zoom Reset actions to MiniBrowser.
920
921         * MiniBrowser/qt/BrowserWindow.cpp:
922         (BrowserWindow::BrowserWindow):
923         (BrowserWindow::zoomIn):
924         (BrowserWindow::zoomOut):
925         (BrowserWindow::resetZoom):
926         (BrowserWindow::updateUserAgentList):
927         (BrowserWindow::applyZoom):
928         * MiniBrowser/qt/BrowserWindow.h:
929
930 2011-01-26  Maciej Stachowiak  <mjs@apple.com>
931
932         Reviewed by Dan Bernstein.
933
934         WebKitTestRunner needs to support layoutTestController.evaluateInWebInspector
935         https://bugs.webkit.org/show_bug.cgi?id=42319
936         
937         Add evaluateInWebInspector and other APIs needed for inspector tests to run.
938
939         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
940         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
941         (WTR::LayoutTestController::showWebInspector):
942         (WTR::LayoutTestController::closeWebInspector):
943         (WTR::LayoutTestController::evaluateInWebInspector):
944         (WTR::LayoutTestController::setTimelineProfilingEnabled):
945         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
946         * WebKitTestRunner/TestInvocation.cpp:
947         (WTR::shouldOpenWebInspector):
948         (WTR::TestInvocation::invoke):
949         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
950
951 2011-01-26  Martin Robinson  <mrobinson@igalia.com>
952
953         Reviewed by Xan Lopez.
954
955         [GTK] Pixel dumps do not include scrollbars in output images
956         https://bugs.webkit.org/show_bug.cgi?id=53216
957
958         Show scrollbars in pixel dumps. This will fix pixel dumps for tests
959         that have scrollbars.
960
961         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
962         (createBitmapContextFromWebView): Take the snapshot of the containing GtkScrolledWindow
963         instead of the web view itself.
964
965 2011-01-26  Dirk Pranke  <dpranke@chromium.org>
966
967         Reviewed by Mihai Parparita.
968
969         Fix regression introduced in r76322 ... new-run-webkit-tests
970         was attempting to save the image diff output as a UTF-8-encoded
971         file.
972
973         https://bugs.webkit.org/show_bug.cgi?id=53210
974
975         * Scripts/webkitpy/layout_tests/port/webkit.py:
976
977 2011-01-26  Sheriff Bot  <webkit.review.bot@gmail.com>
978
979         Unreviewed, rolling out r76709.
980         http://trac.webkit.org/changeset/76709
981         https://bugs.webkit.org/show_bug.cgi?id=53194
982
983         "broke python tests on non-snowleopard platforms" (Requested
984         by dpranke on #webkit).
985
986         * Scripts/webkitpy/layout_tests/port/factory.py:
987         * Scripts/webkitpy/layout_tests/port/mock_drt.py: Removed.
988         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Removed.
989
990 2011-01-26  Dirk Pranke  <dpranke@chromium.org>
991
992         Reviewed by Tony Chang.
993
994         new-run-webkit-tests: add a "mock DRT" port implementation
995         and a separate class that emulates what we expect the
996         DumpRenderTree behavior to be.
997
998         This will eventually replace port/dryrun.py and allow us to get
999         better test coverage of the new-run-webkit-tests code as well as
1000         a reference for what new-run-webkit-tests expects from DRT.
1001
1002         This is the first attempt at this, and it is pretty bare-boned. It
1003         really only has been tested on the 'mac' port (and a little on
1004         the 'chromium-mac' port.
1005
1006         https://bugs.webkit.org/show_bug.cgi?id=53126
1007
1008         * Scripts/webkitpy/layout_tests/port/mock_drt.py: Added.
1009         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Added.
1010         * Scripts/webkitpy/layout_tests/port/factory.py:
1011
1012 2011-01-26  Xianzhu Wang  <wangxianzhu@google.com>
1013
1014         Reviewed by Tony Chang.
1015
1016         Add '--no-timeout' option to Chromium DRT to ease debugging.
1017         https://bugs.webkit.org/show_bug.cgi?id=52873
1018
1019         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1020         (main):
1021
1022 2011-01-26  Csaba Osztrogonác  <ossy@webkit.org>
1023
1024         Reviewed by Andreas Kling.
1025
1026         [Qt] Fix qt_minimal build
1027         https://bugs.webkit.org/show_bug.cgi?id=53172
1028
1029         * QtTestBrowser/locationedit.h:
1030
1031 2011-01-26  Mansi Mithal  <mansi.mithal@nokia.com>
1032
1033         Reviewed by Antonio Gomes.
1034
1035         QtTestBrowser should have a UI Setting to disable plugins
1036         https://bugs.webkit.org/show_bug.cgi?id=52408
1037         
1038         Added a new action item named "Disable Plugins"
1039         under the "Settings" menu. 
1040
1041         * QtTestBrowser/launcherwindow.cpp:
1042         (LauncherWindow::createChrome):
1043         (LauncherWindow::togglePlugins):
1044         * QtTestBrowser/launcherwindow.h:
1045
1046 2011-01-25  Patrick Gansterer  <paroga@webkit.org>
1047
1048         Reviewed by Adam Barth.
1049
1050         Move main CMakeLists.txt into Source directory
1051         https://bugs.webkit.org/show_bug.cgi?id=52888
1052
1053         * Scripts/webkitdirs.pm:
1054
1055 2011-01-25  Patrick Gansterer  <paroga@webkit.org>
1056
1057         Reviewed by Eric Seidel.
1058
1059         Improve label text in submit-to-ews
1060         https://bugs.webkit.org/show_bug.cgi?id=53130
1061
1062         * QueueStatusServer/templates/submittoews.html:
1063
1064 2011-01-25  Mansi Mithal  <mansi.mithal@nokia.com>
1065
1066         Reviewed by Antonio Gomes.
1067
1068         QtTestBrowser should have a UI Settings to prevent loading images
1069         https://bugs.webkit.org/show_bug.cgi?id=52409
1070         
1071         Added a new action item named "DisableAutoLoadImages"
1072         under the "Settings" menu 
1073
1074         * QtTestBrowser/launcherwindow.cpp:
1075         (LauncherWindow::createChrome):
1076         (LauncherWindow::toggleAutoLoadImages):
1077         * QtTestBrowser/launcherwindow.h:
1078
1079 2011-01-25  Dirk Pranke  <dpranke@chromium.org>
1080
1081         Reviewed by Tony Chang.
1082
1083         Minor bug fixes and cleanup for filesystem wrappers, port/* test
1084         classes, test_expectations.py. This change adds "test-win" and
1085         "test-mac" variants to the test port so that we can better test
1086         rebaselining, and adds a MockUser() object for reuse in testing.
1087
1088         https://bugs.webkit.org/show_bug.cgi?id=53036
1089
1090         * Scripts/webkitpy/common/system/filesystem.py:
1091         * Scripts/webkitpy/common/system/filesystem_mock.py:
1092         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1093         * Scripts/webkitpy/layout_tests/port/factory.py:
1094         * Scripts/webkitpy/layout_tests/port/base.py:
1095         * Scripts/webkitpy/layout_tests/port/test.py:
1096         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1097         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
1098         * Scripts/webkitpy/tool/mocktool.py:
1099
1100 2011-01-25  Tony Chang  <tony@chromium.org>
1101
1102         Reviewed by Dimitri Glazkov.
1103
1104         [chromium] remove unused layoutTestController callback
1105         https://bugs.webkit.org/show_bug.cgi?id=53103
1106
1107         This method is used by a test_shell_test, but not needed by DRT.
1108
1109         * DumpRenderTree/chromium/LayoutTestController.cpp:
1110         (LayoutTestController::LayoutTestController):
1111         * DumpRenderTree/chromium/LayoutTestController.h:
1112
1113 2011-01-25  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1114
1115         Reviewed by Andreas Kling.
1116
1117         [GTK] Remove 64 bits release bot from the buildbot master
1118         https://bugs.webkit.org/show_bug.cgi?id=52899
1119
1120         Removes the 64 bits release slave from the buildbot configuration,
1121         so that we can use it as an EWS.
1122
1123         * BuildSlaveSupport/build.webkit.org-config/config.json:
1124
1125 2011-01-24  Maciej Stachowiak  <mjs@apple.com>
1126
1127         Reviewed by Dan Bernstein.
1128
1129         Implement database quota callback to fix storage tests on WebKit2 bot
1130         https://bugs.webkit.org/show_bug.cgi?id=53064
1131
1132         * WebKitTestRunner/TestController.cpp:
1133         (WTR::exceededDatabaseQuota):
1134         (WTR::TestController::createOtherPage):
1135         (WTR::TestController::initialize):
1136
1137 2011-01-24  Maciej Stachowiak  <mjs@apple.com>
1138
1139         Reviewed by Anders Carlsson.
1140
1141         Use designated temp directory for the database for WebKit2
1142         https://bugs.webkit.org/show_bug.cgi?id=53052
1143         
1144         Adopt the new WK2 API for this.
1145
1146         * WebKitTestRunner/TestController.cpp:
1147         (WTR::TestController::libraryPathForTesting):
1148         (WTR::TestController::initialize):
1149         * WebKitTestRunner/TestController.h:
1150         * WebKitTestRunner/mac/TestControllerMac.mm:
1151         (WTR::TestController::platformLibraryPathForTesting):
1152         * WebKitTestRunner/qt/TestControllerQt.cpp:
1153         (WTR::TestController::platformLibraryPathForTesting):
1154         * WebKitTestRunner/win/TestControllerWin.cpp:
1155         (WTR::TestController::platformLibraryPathForTesting):
1156
1157 2011-01-24  Lucas Forschler  <lforschler@apple.com>
1158
1159         Reviewed by Stephanie Lewis.
1160
1161         Add a new Leopard test bot.
1162
1163         * BuildSlaveSupport/build.webkit.org-config/config.json:
1164
1165 2011-01-24  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1166
1167         Reviewed by Adam Barth.
1168
1169         Add EFL Builder to core waterfall
1170         https://bugs.webkit.org/show_bug.cgi?id=52704
1171
1172         Add EFL Builder to the core waterfall again.
1173
1174         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1175         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1176
1177 2011-01-24  Xianzhu Wang  <wangxianzhu@google.com>
1178
1179         Reviewed by Tony Chang.
1180
1181         new-run-webkit-tests fails to start HTTP server if there are proxy settings
1182         https://bugs.webkit.org/show_bug.cgi?id=52872
1183
1184         Force disabling proxy to resolve the problem.
1185
1186         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
1187         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
1188
1189 2011-01-24  Andreas Kling  <kling@webkit.org>
1190
1191         Reviewed by Darin Adler.
1192
1193         check-webkit-style: Update exemptions following Source/ move.
1194         https://bugs.webkit.org/show_bug.cgi?id=53017
1195
1196         * Scripts/webkitpy/style/checker.py:
1197         * Scripts/webkitpy/style/checker_unittest.py:
1198
1199 2011-01-24  Andras Becsi  <abecsi@webkit.org>
1200
1201         Rubber-stamped by Csaba Osztrogonác.
1202
1203         [Qt] Move project files into Source
1204         https://bugs.webkit.org/show_bug.cgi?id=52891
1205
1206         * DumpRenderTree/qt/ImageDiff.pro: Add missing "Source" to WebKit.pri path
1207
1208 2011-01-24  Mikhail Naganov  <mnaganov@chromium.org>
1209
1210         Reviewed by Yury Semikhatsky.
1211
1212         Web Inspector: Find duplicate strings in localizedStrings.js
1213
1214         https://bugs.webkit.org/show_bug.cgi?id=53005
1215
1216         * Scripts/check-inspector-strings:
1217
1218 2011-01-24  Zoltan Horvath  <zoltan@webkit.org>
1219
1220         Reviewed by Andreas Kling.
1221
1222         [Qt] Regroup MiniBrowser's menubar and add open file action
1223         https://bugs.webkit.org/show_bug.cgi?id=53000
1224
1225         Add File and Develop menu to MiniBrowser's menubar and add open file action to File menu.
1226
1227         * MiniBrowser/qt/BrowserWindow.cpp:
1228         (BrowserWindow::BrowserWindow):
1229         (BrowserWindow::openFile):
1230         (BrowserWindow::~BrowserWindow):
1231         * MiniBrowser/qt/BrowserWindow.h:
1232
1233 2011-01-24  Csaba Osztrogonác  <ossy@webkit.org>
1234
1235         Unreviewed fix after r76496
1236
1237         [Qt] Move project files into Source
1238         https://bugs.webkit.org/show_bug.cgi?id=52891
1239
1240         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Remove unnecessary "Source" from the path.
1241         * BuildSlaveSupport/built-product-archive: Remove unnecessary "Source" from the path.
1242         * Scripts/webkitdirs.pm: Add the accidentally removed slash to the path.
1243
1244 2011-01-24  Andras Becsi  <abecsi@webkit.org>
1245
1246         Reviewed by Csaba Osztrogonác.
1247
1248         [Qt] Move project files into Source
1249         https://bugs.webkit.org/show_bug.cgi?id=52891
1250
1251         * DerivedSources.pro: Renamed from DerivedSources.pro.
1252         * DumpRenderTree/qt/DumpRenderTree.pro:
1253         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1254         * MiniBrowser/DerivedSources.pro:
1255         * MiniBrowser/qt/MiniBrowser.pro:
1256         * QtTestBrowser/QtTestBrowser.pro:
1257         * Scripts/webkitdirs.pm:
1258         * Tools.pro: Added.
1259         * WebKitTestRunner/DerivedSources.pro:
1260         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1261         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1262
1263 2011-01-22  Geoffrey Garen  <ggaren@apple.com>
1264
1265         Reviewed by Dan Bernstein.
1266
1267         Beefed up --threaded mode to catch even more kinds of errors.
1268         https://bugs.webkit.org/show_bug.cgi?id=52971
1269
1270         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Use a shared
1271         context group to force JSC to mark multiple threads. (This used to be
1272         the default, but it changed in SnowLeopard.)
1273         (runJavaScriptThread): Do more locking and unlocking, and more allocation,
1274         to give threading mistakes more chances to show themselves.
1275         (startJavaScriptThreads):
1276         (stopJavaScriptThreads):
1277
1278 2011-01-22  Robert Hogan  <robert@webkit.org>
1279
1280         Reviewed by Andreas Kling.
1281
1282         [Qt] Support layoutTestController.addURLToRedirect()
1283         https://bugs.webkit.org/show_bug.cgi?id=52956
1284
1285         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1286         (LayoutTestController::addURLToRedirect):
1287         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1288
1289 2011-01-22  Robert Hogan  <robert@webkit.org>
1290
1291         Reviewed by Kenneth Rohde Christiansen.
1292
1293         [Qt] REGRESSION (r72360): http/tests/security/aboutBlank/xss-DENIED-* tests fail
1294         https://bugs.webkit.org/show_bug.cgi?id=49802
1295
1296         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1297         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1298         (WebCore::DumpRenderTree::open):
1299
1300 2011-01-21  Adam Barth  <abarth@webkit.org>
1301
1302         Reviewed by Maciej Stachowiak.
1303
1304         Disable mac_unittest.py that fails on some of the Mac bots
1305         https://bugs.webkit.org/show_bug.cgi?id=52947
1306
1307         As noted in the comment, this test does not appear to be correct
1308         because the function this test is testing returns different results
1309         depending on which flavor of Mac the test is run on.  This patch
1310         disable the test.  Hopefully we can re-enable the test once we've
1311         probably insulated the test from its environment.
1312
1313         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1314
1315 2011-01-21  Dirk Pranke  <dpranke@chromium.org>
1316
1317         Reviewed by Mihai Parparita.
1318
1319         Fix bug introduced in r76322 that caused NRWT to not actually
1320         read the Skipped files properly.
1321
1322         https://bugs.webkit.org/show_bug.cgi?id=52771
1323
1324         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1325         * Scripts/webkitpy/layout_tests/port/webkit.py:
1326         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1327
1328 2011-01-21  Sam Weinig  <sam@webkit.org>
1329
1330         Reviewed by Geoffrey Sean Garen and Mark Rowe.
1331
1332         WebKitTestRunner needs the HOME environment variable to be set.
1333         <rdar://problem/8896573>
1334
1335         * Scripts/old-run-webkit-tests: Set the HOME environment variable if
1336         it exists.
1337
1338 2011-01-21  Dirk Pranke  <dpranke@chromium.org>
1339
1340         Reviewed by Eric Seidel.
1341
1342         Suppress a few remaining integration tests so that none of the
1343         layout_test unit tests ever read from the filesystem or launch
1344         subprocesses that aren't part of the unit tests.
1345
1346         Also fix a minor bug in the printing unit tests that was
1347         incorrectly relying on sys.argv.
1348
1349         https://bugs.webkit.org/show_bug.cgi?id=52863
1350
1351         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1352         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1353         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1354
1355 2011-01-21  Darin Adler  <darin@apple.com>
1356
1357        Fix Mac build.
1358
1359         * MiniBrowser/mac/BrowserWindowController.m:
1360         (-[BrowserWindowController awakeFromNib]): Pass 0 for runModal function.
1361
1362 2011-01-20  Darin Adler  <darin@apple.com>
1363
1364         Reviewed by Dan Bernstein.
1365
1366         WebKit2: Implement showModalDialog
1367         https://bugs.webkit.org/show_bug.cgi?id=52855
1368
1369         This fixes WebKitTestRunner to compile, but more work is probably
1370         needed to get it to pass the tests.
1371
1372         * WebKitTestRunner/TestController.cpp:
1373         (WTR::TestController::runModal): Added. Calls through to the
1374         platform-specific version of runModal.
1375         (WTR::TestController::createOtherPage): Changed to be a private
1376         static member function so it can refer to runModal, which is
1377         a private static member function.
1378         (WTR::TestController::initialize): Pass 0 for the runModal
1379         function since we don't need to run the main window modal.
1380         I suspect this is wrong and will need to change.
1381         * WebKitTestRunner/TestController.h: Added declarations for
1382         the functions added above.
1383         * WebKitTestRunner/mac/TestControllerMac.mm:
1384         (WTR::TestController::runModal): Added. Untested implementation.
1385         * WebKitTestRunner/qt/TestControllerQt.cpp:
1386         (WTR::TestController::runModal): Added.
1387         * WebKitTestRunner/win/TestControllerWin.cpp:
1388         (WTR::TestController::runModal): Added.
1389
1390 2011-01-21  Eric Seidel  <eric@webkit.org>
1391
1392         Reviewed by Adam Barth.
1393
1394         Split Host object off from WebKitPatch for easier re-use
1395         https://bugs.webkit.org/show_bug.cgi?id=52284
1396
1397         new-run-webkit-tests and other tools are eventually going to want one of these.
1398         Basically you need to inherit from this class if you want to pretend to be a
1399         self.tool object for Steps/Commands.
1400
1401         * Scripts/webkitpy/common/host.py: Added.
1402         * Scripts/webkitpy/tool/main.py:
1403
1404 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1405
1406         Reviewed by Adam Barth.
1407
1408         Disable the tests that start and stop the http server and web
1409         server, so that we don't have to worry about port collisions on
1410         the bots.
1411
1412         https://bugs.webkit.org/show_bug.cgi?id=52861
1413
1414         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1415
1416 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1417
1418         Reviewed by Eric Seidel.
1419
1420         nrwt: rewrite google_chrome_unittest to use mock filesystem.
1421         
1422         https://bugs.webkit.org/show_bug.cgi?id=52772
1423         
1424         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
1425
1426 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1427
1428         Reviewed by Eric Siedel.
1429
1430         nrwt: clean up almost all remaining port references, remove
1431         unnecessary import clauses. The only remaining references are
1432         in places where a mock filesystem makes no sense or can't be
1433         used, and in one routine in port/google_chrome_unittest that
1434         I'll rewrite in a separate patch.
1435
1436         https://bugs.webkit.org/show_bug.cgi?id=52771
1437
1438         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1439         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1440         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1441         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1442         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1443         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1444         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1445         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
1446         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
1447         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
1448         * Scripts/webkitpy/layout_tests/port/gtk.py:
1449         * Scripts/webkitpy/layout_tests/port/mac.py:
1450         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1451         * Scripts/webkitpy/layout_tests/port/qt.py:
1452         * Scripts/webkitpy/layout_tests/port/webkit.py:
1453         * Scripts/webkitpy/layout_tests/port/win.py:
1454         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
1455
1456 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1457
1458         Reviewed by Mihai Parparita.
1459
1460         remove fs refs from run_webkit_tests, rebaseline_chromium_webkit_tests
1461
1462         https://bugs.webkit.org/show_bug.cgi?id=52762
1463
1464         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1465         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1466
1467 2011-01-20  Tony Chang  <tony@chromium.org>
1468
1469         Reviewed by Ojan Vafai.
1470
1471         [chromium] fix the paths used for the rebaseline tool
1472         https://bugs.webkit.org/show_bug.cgi?id=52857
1473
1474         Some of the bots were renamed so the path to grab the results zip
1475         file has changed.
1476
1477         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1478
1479 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1480
1481         Reviewed by Tony Chang.
1482
1483         Fix bug introduced in r72688 / bug 52768 that broke the
1484         generation of the output filename links in the results.html
1485         output. Apparently none of the unit tests actually checked to
1486         make sure the generated links were correct :(
1487
1488         https://bugs.webkit.org/show_bug.cgi?id=52854
1489
1490         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1491         * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
1492
1493 2011-01-20  Alexey Proskuryakov  <ap@apple.com>
1494
1495         Reviewed by Darin Adler.
1496
1497         https://bugs.webkit.org/show_bug.cgi?id=52849
1498         Make window.print work with WebKit2
1499
1500         * MiniBrowser/mac/BrowserWindowController.m:
1501         (-[BrowserWindowController awakeFromNib]):
1502         * WebKitTestRunner/TestController.cpp:
1503         (WTR::createOtherPage):
1504         (WTR::TestController::initialize):
1505         Added zeroes to WKPageUIClient structures to avoid build failures.
1506
1507 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1508
1509         Reviewed by Eric Seidel.
1510
1511         nrwt: remove fs refs from printing, test_failures, test_expectations, text_diff
1512
1513         https://bugs.webkit.org/show_bug.cgi?id=52756
1514
1515         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1516         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1517         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1518         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
1519         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1520         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
1521
1522 2011-01-20  Mansi Mithal  <mansi.mithal@nokia.com>
1523
1524         Reviewed by Antonio Gomes.
1525
1526         QtTestBrowser should have a seperate menu for Settings
1527         https://bugs.webkit.org/show_bug.cgi?id=52817
1528         
1529         Added a new menu item named "Settings"
1530         and moved the "Enable interrupting js scripts" and "Enable js pop up windows" under the "Settings" menu 
1531
1532         * QtTestBrowser/launcherwindow.cpp:
1533         (LauncherWindow::createChrome):
1534
1535 2011-01-20  Sam Weinig  <sam@webkit.org>
1536
1537         Reviewed by John Sullivan.
1538
1539         Update update-webkit-localizable-strings with new path to WebKit.
1540
1541         * Scripts/update-webkit-localizable-strings:
1542
1543 2011-01-20  James Robinson  <jamesr@chromium.org>
1544
1545         Reviewed by Darin Fisher.
1546
1547         Implement mozilla's requestAnimationFrame API
1548         https://bugs.webkit.org/show_bug.cgi?id=51218
1549
1550         Chromium DumpRenderTree support for window.webkitRequestAnimationFrame.
1551
1552         * DumpRenderTree/chromium/WebViewHost.cpp:
1553         (invokeScheduleComposite):
1554         (WebViewHost::scheduleAnimation):
1555         (WebViewHost::paintInvalidatedRegion):
1556         * DumpRenderTree/chromium/WebViewHost.h:
1557
1558 2011-01-20  Maciej Stachowiak  <mjs@apple.com>
1559
1560         Reviewed by Adam Roben.
1561
1562         WebKitTestRunner needs to support layoutTestController.evaluateScriptInIsolatedWorld
1563         https://bugs.webkit.org/show_bug.cgi?id=42327
1564
1565         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm: Add support
1566         for methods that take their normal arguments but also a JSContextRef.
1567         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: IDL definition
1568         for evaluateScriptInIsolatedWorld.
1569         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1570         (WTR::InjectedBundlePage::didClearWindowForFrame): Set a magic variable only if
1571         this call is for an isolated world.
1572         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1573         (WTR::worldMap): Helper to create a world map.
1574         (WTR::LayoutTestController::worldIDForWorld): Map from an ID to a world.
1575         (WTR::LayoutTestController::evaluateScriptInIsolatedWorld): The newly
1576         added LayoutTestController API.
1577         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1578
1579 2011-01-19  Adam Roben  <aroben@apple.com>
1580
1581         Convert paths in environment variables back to msys-style inside commit-log-editor
1582
1583         When this script gets run from inside git commit, msys-style paths in the environment will
1584         have been turned into Windows-style paths with forward slashes. This screws up functions
1585         like File::Spec->rel2abs, which seem to rely on $PWD having an msys-style path. We convert
1586         the paths back to msys-style before doing anything else.
1587
1588         Fixes <http://webkit.org/b/48527> commit-log-editor uses full paths for section headers when
1589         using msysgit's Perl and multiple ChangeLogs have been edited
1590
1591         Reviewed by David Kilzer.
1592
1593         * Scripts/commit-log-editor: Call fixEnvironment before doing anything else.
1594         (fixEnvironment): Added. When run in msys in conjunction with git (i.e., when invoked from
1595         inside git commit), convert Windows-style paths in the environment back to msys-style paths.
1596
1597 2011-01-20  Zoltan Horvath  <zoltan@webkit.org>
1598
1599         [Win] Unreviewed build fix after r76248.
1600
1601         * DumpRenderTree/ForwardingHeaders/wtf/FastAllocBase.h: Added.
1602
1603 2011-01-20  Zoltan Horvath  <zoltan@webkit.org>
1604
1605         Reviewed by Csaba Osztrogonác.
1606
1607         Refactoring of the custom allocation framework
1608         https://bugs.webkit.org/show_bug.cgi?id=49897
1609
1610         Inheriting from FastAllocBase can result in objects getting larger (bug #33896, #46589).
1611         The modification replaces Noncopyable and FastAllocBase classes and these inherits with their
1612         equivalent macro implementation at the necessary places.
1613 2011-01-20  Yi Shen  <yi.4.shen@nokia.com>
1614
1615         Unreviewed. 
1616
1617         Adding myself to committers.py.
1618
1619         * Scripts/webkitpy/common/config/committers.py:
1620
1621 2011-01-20  Adam Barth  <abarth@webkit.org>
1622
1623         Reviewed by Tony Chang.
1624
1625         Chromium builders don't delete unversioned directories when DEPS change
1626         https://bugs.webkit.org/show_bug.cgi?id=52745
1627
1628         If we pass this option to gclient sync, gclient will delete directories
1629         that are no longer part of DEPS instead of leaving them around to
1630         confuse us later.  Apparently, the downstream buildbots use this option
1631         already.
1632
1633         * Scripts/update-webkit-chromium:
1634
1635 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1636
1637         Unreviewed, build fix - I pulled this patch in to fix an issue
1638         revealed by r76195 running on some new bots). Also fix a couple
1639         of other issues revealed in testing.
1640
1641         nrwt: remove fs refs from layout_package/json*
1642
1643         https://bugs.webkit.org/show_bug.cgi?id=52754
1644
1645         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1646         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1647         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
1648         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1649         * Scripts/webkitpy/layout_tests/port/base.py:
1650
1651 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1652
1653         Unreviewed, build fix.
1654
1655         Fix a couple of minor bugs discovered while bringing up new bots
1656         for testing.
1657
1658         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1659         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1660
1661 2011-01-19  James Robinson  <jamesr@chromium.org>
1662
1663         Unreviewed, rolling out r76194.
1664         http://trac.webkit.org/changeset/76194
1665         https://bugs.webkit.org/show_bug.cgi?id=51218
1666
1667         Caused mysterious compile failure on the chromium win
1668         build.webkit.org bots
1669
1670         * DumpRenderTree/chromium/WebViewHost.cpp:
1671         (WebViewHost::paintInvalidatedRegion):
1672         * DumpRenderTree/chromium/WebViewHost.h:
1673
1674 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1675
1676         Reviewed by Mihai Parparita.
1677
1678         remove fs refs from test_runner, dump_render_tree_thread
1679
1680         https://bugs.webkit.org/show_bug.cgi?id=52753
1681
1682         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1683         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1684         * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
1685         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1686
1687 2011-01-19  James Robinson  <jamesr@chromium.org>
1688
1689         Reviewed by Darin Fisher.
1690
1691         Implement mozilla's requestAnimationFrame API
1692         https://bugs.webkit.org/show_bug.cgi?id=51218
1693
1694         Chromium DumpRenderTree support for window.webkitRequestAnimationFrame.
1695
1696         * DumpRenderTree/chromium/WebViewHost.cpp:
1697         (invokeScheduleComposite):
1698         (WebViewHost::scheduleAnimation):
1699         (WebViewHost::paintInvalidatedRegion):
1700         * DumpRenderTree/chromium/WebViewHost.h:
1701
1702 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1703
1704         Unreviewed, build fix.
1705
1706         Fix a few incorrect "self._filesystem" references introduced in
1707         r76184.
1708
1709         * Scripts/webkitpy/layout_tests/port/chromium.py:
1710         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1711
1712 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1713
1714         Reviewed by Mihai Parparita.
1715
1716         add a .sep property, abspath(), isabs(), mtime(), and
1717         open_text_file_for_writing() to filesystem modules. Some of
1718         these properties are not needed in this patch but will be needed
1719         in subsequent patches (I'm doing this to avoid having to track
1720         multiple versions of a single file).
1721
1722         Also, change most of the port/* modules to use the filesystem
1723         objects instead of referencing the filesystem directly.
1724
1725         https://bugs.webkit.org/show_bug.cgi?id=52748
1726
1727         * Scripts/webkitpy/common/system/filesystem.py:
1728         * Scripts/webkitpy/common/system/filesystem_mock.py:
1729         * Scripts/webkitpy/layout_tests/port/__init__.py:
1730         * Scripts/webkitpy/layout_tests/port/base.py:
1731         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1732         * Scripts/webkitpy/layout_tests/port/chromium.py:
1733         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1734         * Scripts/webkitpy/layout_tests/port/config.py:
1735         * Scripts/webkitpy/layout_tests/port/test.py:
1736         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
1737
1738 2011-01-19  Maciej Stachowiak  <mjs@apple.com>
1739
1740         Reviewed by Anders Carlsson.
1741
1742         If resetting between tests times out, treat it as a WebProcess crash
1743         https://bugs.webkit.org/show_bug.cgi?id=52757
1744
1745         * WebKitTestRunner/TestController.cpp:
1746         (WTR::TestController::runTest):
1747
1748 2011-01-19  Alexey Proskuryakov  <ap@apple.com>
1749
1750         Reviewed by Darin Adler.
1751
1752         https://bugs.webkit.org/show_bug.cgi?id=52739
1753         Make it possible for a WebKit2 client to print headers and footers
1754
1755         Added dummy implementations for new printing UIClient calls.
1756
1757         * MiniBrowser/mac/BrowserWindowController.m:
1758         (-[BrowserWindowController awakeFromNib]):
1759         * WebKitTestRunner/TestController.cpp:
1760         (WTR::createOtherPage):
1761         (WTR::TestController::initialize):
1762
1763 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1764
1765         Reviewed by Ojan Vafai.
1766
1767         Change webkitpy/layout_tests/port/test.py to use the
1768         in-memory filesystem for cleaner unit testing. This
1769         change allows us to kill a lot of code that was
1770         specific to the test port, at the cost of being a
1771         little less clear about how things would work if
1772         you didn't have a filesystem.
1773
1774         https://bugs.webkit.org/show_bug.cgi?id=52605
1775
1776         * Scripts/webkitpy/layout_tests/port/test.py:
1777
1778 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1779
1780         Unreviewed, build fix.
1781
1782         Fix test failure caused by committing attachment 79368 instead
1783         of attachment 79461 on bug 52604.
1784
1785         * Scripts/webkitpy/common/system/filesystem_mock.py:
1786
1787 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1788
1789         Reviewed by Mihai Parparita.
1790
1791         new-run-webkit-tests: remove use of os.walk, use mock filesystem for better
1792         unit testing. os.walk() is too much of a hassle to implement on
1793         top of the in-memory mock filesystem and adding the necessary
1794         interface to files_under() gives clients a cleaner API anyway
1795         (for this particular usage model).
1796
1797         https://bugs.webkit.org/show_bug.cgi?id=52691
1798
1799         * Scripts/webkitpy/common/system/filesystem.py:
1800         * Scripts/webkitpy/common/system/filesystem_mock.py:
1801         * Scripts/webkitpy/layout_tests/port/test_files.py:
1802         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
1803
1804 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1805
1806         Reviewed by Tony Chang.
1807
1808         Change more modules in the layout-tests code to use the
1809         filesystem wrapper for cleaner unit testing.
1810
1811         This patch also adds the glob() wrapper to the filesystem
1812         abstraction.
1813         
1814         https://bugs.webkit.org/show_bug.cgi?id=52604
1815
1816         * Scripts/webkitpy/layout_tests/port/test_files.py:
1817         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
1818         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
1819         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1820         * Scripts/webkitpy/common/system/filesystem.py:
1821         * Scripts/webkitpy/common/system/filesystem_mock.py:
1822
1823 2011-01-19  Levi Weintraub  <leviw@chromium.org>
1824
1825         Unreviewed.
1826
1827         Updating my email addresses and irc nick.
1828
1829         * Scripts/webkitpy/common/config/committers.py:
1830
1831 2011-01-19  Tony Chang  <tony@chromium.org>
1832
1833         Reviewed by Mihai Parparita.
1834
1835         [chromium] [linux] if check-sys-deps fails, output the failure reason
1836         https://bugs.webkit.org/show_bug.cgi?id=52671
1837
1838         * Scripts/webkitpy/common/system/executive_mock.py: Add support for
1839             error handler functions.
1840         * Scripts/webkitpy/layout_tests/port/chromium.py:
1841             output the error text from --check-sys-deps
1842         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1843
1844 2011-01-19  Aparna Nandyal  <aparna.nand@wipro.com>
1845
1846         Reviewed by Andreas Kling.
1847
1848         [Qt] QtTestBrowser crashes when closing if Facebook is opened
1849         https://bugs.webkit.org/show_bug.cgi?id=52554
1850         
1851         QtNetworkAccessManager is created in a thread and set as
1852         member variable in QWebPage. When the thread is destroyed
1853         the object is still used. So fix will set the object to
1854         NULL once the thread is destroyed.
1855
1856         * QtTestBrowser/launcherwindow.cpp:
1857         (LauncherWindow::~LauncherWindow):
1858
1859 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
1860
1861         Rubber stamped by Csaba Osztrogonac
1862
1863         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: Removed unncessary inculde of WKStringCF.h
1864
1865 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
1866
1867         Reviewed by Tony Chang.
1868
1869         new-run-webkit-tests: add a --build-directory command line argument
1870
1871         Official Google Chrome builds use a non-standard build directory
1872         location. This patch adds a --build-directory argument that
1873         allows that location to be specified on the command line. Only
1874         Chromium-based builds will use this flag for now, but anyone can
1875         in the future.
1876
1877         There are no unit tests for this since it's difficult to test
1878         until mock filesystems are fully supported in the code. This was
1879         tested by hand for now.
1880
1881         https://bugs.webkit.org/show_bug.cgi?id=52694
1882
1883         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1884         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1885         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1886         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1887
1888 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
1889
1890         Not reviewed. Bot fix.
1891
1892         Remove an inadvertently committed debugging print.
1893
1894         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1895         (LayoutTestController::notifyDone):
1896
1897 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
1898
1899         Reviewed by Sam Weinig.
1900
1901         WebKitTestRunner should track loading more like DumpRenderTree
1902         https://bugs.webkit.org/show_bug.cgi?id=52692
1903
1904         Change load tracking to track the current top loading frame, in the manner of DumpRenderTree.
1905         This makes some tests that call notifyDone multiple times pass.
1906         
1907         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1908         (WTR::InjectedBundle::InjectedBundle):
1909         (WTR::InjectedBundle::done):
1910         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1911         (WTR::InjectedBundle::topLoadingFrame):
1912         (WTR::InjectedBundle::setTopLoadingFrame):
1913         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1914         (WTR::InjectedBundlePage::InjectedBundlePage):
1915         (WTR::InjectedBundlePage::stopLoading):
1916         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
1917         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
1918         (WTR::InjectedBundlePage::didFinishLoadForFrame):
1919         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
1920         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1921         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1922         (WTR::LayoutTestController::notifyDone):
1923         * WebKitTestRunner/TestController.cpp:
1924         (WTR::TestController::didReceiveMessageFromInjectedBundle):
1925
1926 2011-01-18  Mihai Parparita  <mihaip@chromium.org>
1927
1928         Reviewed by Kent Tamura.
1929
1930         [Chromium] NRWT looking for DRT binary in the wrong path on Mac
1931         https://bugs.webkit.org/show_bug.cgi?id=52678
1932         
1933         Update path now that WebKit is inside Source.
1934
1935         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1936
1937 2011-01-18  Robert Hogan  <robert@webkit.org>
1938
1939         Reviewed by Simon Hausmann.
1940
1941         [Qt] http/tests/incremental/slow-utf8-text.pl fails
1942         https://bugs.webkit.org/show_bug.cgi?id=44282
1943
1944         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1945         (WebCore::DumpRenderTree::dump):
1946
1947 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
1948
1949         Reviewed by Mihai Parparita.
1950
1951         Fix a small race condition that could cause the unit tests for
1952         new-run-webkit-tests to fail in a multithreaded environment.
1953         There was a small window in the code where one thread would
1954         check to see if a thread had raised an exception, do something,
1955         and then check to see if the thread was alive. If the other
1956         thread raised an exception and exited in between these two
1957         steps, the exception would be lost. Flipping the order of the
1958         two checks fixes the race, since we will now always check for an
1959         exception on the thread before exiting.
1960
1961         https://bugs.webkit.org/show_bug.cgi?id=51579
1962
1963         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
1964
1965 2011-01-18  Eric Seidel  <eric@webkit.org>
1966
1967         Reviewed by Adam Barth.
1968
1969         commit-queue dies when test archiving fails
1970         https://bugs.webkit.org/show_bug.cgi?id=52617
1971
1972         I looked at the machine and it had 10 archives already
1973         thus find_unused_name was returning None.  I've upped
1974         the limit to 100 (per bug) and tested the case where
1975         find_unused_name returns None (making archive return None).
1976
1977         * Scripts/webkitpy/common/system/workspace.py:
1978         * Scripts/webkitpy/common/system/workspace_unittest.py:
1979         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1980         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1981         * Scripts/webkitpy/tool/commands/queues.py:
1982
1983 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
1984
1985         Reviewed by Ojan Vafai.
1986
1987         Update rebaseline-chromium-webkit-tests unit tests to use a mock
1988         filesystem. Also fix a couple of "with" statements missed by
1989         r76050.
1990
1991         https://bugs.webkit.org/show_bug.cgi?id=52487
1992
1993         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
1994
1995 2011-01-18  Sergio Villar Senin  <svillar@igalia.com>
1996
1997         Reviewed by Martin Robinson.
1998
1999         [Gtk] Build fixes for gtk3 build
2000         https://bugs.webkit.org/show_bug.cgi?id=52648
2001
2002         * DumpRenderTree/gtk/EventSender.cpp:
2003         (beginDragWithFilesCallback):
2004
2005 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
2006
2007         Reviewed by Mihai Parparita.
2008
2009         Update rebaseline-chromium-webkit-tests to use filesystem objects
2010         instead of direct references to os.path, shutil, tempfile, etc.
2011
2012         This patch doesn't change anything, but will allow subsequent
2013         patches to change the unit tests to no longer use the real
2014         filesystem.
2015
2016         This patch adds a bunch more methods to the filesystem object as
2017         well.
2018
2019         https://bugs.webkit.org/show_bug.cgi?id=52482
2020
2021         * Scripts/webkitpy/common/system/filesystem.py:
2022         * Scripts/webkitpy/common/system/filesystem_mock.py:
2023         * Scripts/webkitpy/tool/commands/queues.py:
2024         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2025         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
2026
2027 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
2028
2029         Reviewed by Mihai Parparita.
2030
2031         new-run-webkit-tests shouldn't crash when you try to run a
2032         directory containing only skipped files.
2033
2034         https://bugs.webkit.org/show_bug.cgi?id=52478
2035         
2036         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2037         * Scripts/webkitpy/layout_tests/port/test.py:
2038         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2039
2040 2011-01-18  Adam Bergkvist  <adam.bergkvist@ericsson.com> and Martin Robinson  <mrobinson@igalia.com>
2041
2042         Reviewed by Gustavo Noronha Silva.
2043
2044         [GTK] The GTK+ EventSender needs support for beginDragWithFiles
2045         https://bugs.webkit.org/show_bug.cgi?id=40833
2046
2047         * DumpRenderTree/gtk/EventSender.cpp: Add a beginDragWithFiles implementation for the
2048         GTK+ event sender.
2049         (dragWithFilesDragDataGetCallback): Added.
2050         (dragWithFilesDragEndCallback): Added.
2051         (beginDragWithFilesCallback): Added.
2052
2053 2011-01-18  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2054
2055         Reviewed by Adam Barth.
2056
2057         ews: Add additional watcher to efl ews
2058         https://bugs.webkit.org/show_bug.cgi?id=52613
2059
2060         Add gyuyoung.kim@samsung.com to watcher list of efl-ews.
2061
2062         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2063
2064 2011-01-17  Tony Gentilcore  <tonyg@chromium.org>
2065
2066         Reviewed by Alexey Proskuryakov.
2067
2068         Fix some headers with missing or misspelled #ifndef guards
2069         https://bugs.webkit.org/show_bug.cgi?id=52545
2070
2071         * DumpRenderTree/chromium/TestEventPrinter.h:
2072         * DumpRenderTree/chromium/WebPreferences.h:
2073
2074 2011-01-17  Jessie Berlin  <jberlin@apple.com>
2075
2076         Reviewed by Anders Carlsson.
2077
2078         REGRESSION: Assertion failure in FrameLoader::continueLoadAfterWillSubmitForm() when
2079         navigating back to an unreachable URL
2080         https://bugs.webkit.org/show_bug.cgi?id=52388
2081
2082         Add a third parameter (unreachableURL) to queueLoadHTMLString.
2083
2084         * DumpRenderTree/LayoutTestController.cpp:
2085         (queueLoadHTMLStringCallback):
2086         (LayoutTestController::queueLoadHTMLString):
2087         (LayoutTestController::queueLoadAlternateHTMLString):
2088         * DumpRenderTree/LayoutTestController.h:
2089
2090         * DumpRenderTree/WorkQueueItem.h:
2091         (LoadHTMLStringItem::LoadHTMLStringItem):
2092
2093         * DumpRenderTree/chromium/LayoutTestController.cpp:
2094         (WorkItemLoadHTMLString::WorkItemLoadHTMLString):
2095         (WorkItemLoadHTMLString::run):
2096         (LayoutTestController::queueLoadHTMLString):
2097
2098         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
2099         (LoadHTMLStringItem::invoke):
2100         * DumpRenderTree/mac/WorkQueueItemMac.mm:
2101         (LoadHTMLStringItem::invoke):
2102         * DumpRenderTree/win/WorkQueueItemWin.cpp:
2103         (LoadHTMLStringItem::invoke):
2104
2105 2011-01-17  Dan Bernstein  <mitz@apple.com>
2106
2107         Rubber-stamped by Mark Rowe.
2108
2109         Update xcodeproj svn:ignore to include xcuserdata.
2110
2111         * DumpRenderTree/DumpRenderTree.xcodeproj: Modified property svn:ignore.
2112         * MiniBrowser/MiniBrowser.xcodeproj: Modified property svn:ignore.
2113         * TestWebKitAPI/TestWebKitAPI.xcodeproj: Modified property svn:ignore.
2114         * WebKitLauncher/WebKitLauncher.xcodeproj: Modified property svn:ignore.
2115         * WebKitTestRunner/WebKitTestRunner.xcodeproj: Modified property svn:ignore.
2116
2117 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
2118
2119         Unreviewed fix after r75908.
2120
2121         Move WebKit into Source
2122         https://bugs.webkit.org/show_bug.cgi?id=52530
2123
2124         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add Source to the path for Qt API tests.
2125
2126 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
2127
2128         Unreviewed.
2129
2130         Remove accidentally committed debug printing after r75908.
2131
2132         * Scripts/webkitdirs.pm:
2133
2134 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
2135
2136         Unreviewed.
2137
2138         Add myself to committers list
2139         https://bugs.webkit.org/show_bug.cgi?id=52566
2140
2141         * Scripts/webkitpy/common/config/committers.py:
2142
2143 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
2144
2145         Reviewed by Jeremy Orlow.
2146
2147         GeolocationController should call stopUpdating on destruction
2148         https://bugs.webkit.org/show_bug.cgi?id=52216
2149
2150         fast/dom/Geolocation/window-close-crash.html requires that a
2151         Geolocation watch be started in a secondary window. Consequently,
2152         we need to allow geolocation permission and provide a mock
2153         geolocation position for the secondary window's
2154         GeolocationClientMock.
2155
2156         * DumpRenderTree/chromium/LayoutTestController.cpp:
2157         (LayoutTestController::setGeolocationPermission):
2158         (LayoutTestController::setMockGeolocationPosition):
2159         (LayoutTestController::setMockGeolocationError):
2160         * DumpRenderTree/chromium/TestShell.h:
2161         (TestShell::windowList):
2162
2163 2011-01-16  Adam Barth  <abarth@webkit.org>
2164
2165         Update more include paths to reflect WebKit move.
2166
2167         * DumpRenderTree/chromium/EventSender.cpp:
2168         (EventSender::keyDown):
2169         (EventSender::needsShiftModifier):
2170         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
2171         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
2172
2173 2011-01-16  Kent Tamura  <tkent@chromium.org>
2174
2175         Unreviewed, Chromium build fix.
2176
2177         * Scripts/update-webkit-chromium: Webkit/chromium -> Source/WebKit/chromium
2178
2179 2011-01-16  Martin Robinson  <mrobinson@igalia.com>
2180
2181         Build fix for GTK+ after source directory movement.
2182
2183         * GNUmakefile.am: Correct include paths.
2184
2185 2011-01-16  Adam Barth  <abarth@webkit.org>
2186
2187         Teach svn-apply about WebKit move.
2188
2189         * Scripts/VCSUtils.pm:
2190
2191 2011-01-16  Adam Barth  <abarth@webkit.org>
2192
2193         Rubber-stamped by Eric Seidel.
2194
2195         Move WebKit into Source
2196         https://bugs.webkit.org/show_bug.cgi?id=52530
2197
2198         * DumpRenderTree/mac/InternalHeaders/WebKit/WebTypesInternal.h:
2199         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2200         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2201         * DumpRenderTree/qt/GCControllerQt.cpp:
2202         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2203         * DumpRenderTree/qt/PlainTextControllerQt.cpp:
2204         * DumpRenderTree/qt/TextInputControllerQt.cpp:
2205         * DumpRenderTree/wscript:
2206         * QtTestBrowser/launcherwindow.h:
2207         * Scripts/build-webkit:
2208         * Scripts/webkitdirs.pm:
2209
2210 2011-01-15  Adam Barth  <abarth@webkit.org>
2211
2212         Teach svn-apply about WebKit2 move.
2213
2214         * Scripts/VCSUtils.pm:
2215
2216 2011-01-15  Adam Barth  <abarth@webkit.org>
2217
2218         Rubber-stamped by Eric Seidel.
2219
2220         Move WebKit2 into Source
2221         https://bugs.webkit.org/show_bug.cgi?id=52438
2222
2223         * MiniBrowser/qt/MiniBrowser.pro:
2224         * Scripts/build-webkit:
2225         * Scripts/do-file-rename:
2226         * Scripts/do-webcore-rename:
2227         * Scripts/test-webkitpy:
2228         * Scripts/webkitdirs.pm:
2229         * Scripts/webkitpy/style/checker.py:
2230         * WebKitTestRunner/DerivedSources.pro:
2231         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2232         * WebKitTestRunner/qt/WebKitTestRunner.pro:
2233
2234 2011-01-15  Jochen Eisinger  <jochen@chromium.org>
2235
2236         Reviewed by David Levin.
2237
2238         [chromium] remove obsolete createView method
2239         https://bugs.webkit.org/show_bug.cgi?id=52437
2240
2241         * DumpRenderTree/chromium/WebViewHost.cpp:
2242         (WebViewHost::createView):
2243         * DumpRenderTree/chromium/WebViewHost.h:
2244
2245 2011-01-14  Brian Weinstein  <bweinstein@apple.com>
2246
2247         Reviewed by Geoff Garen.
2248
2249         ShouldLoadResourceForFrame should use strings, not URLs.
2250         https://bugs.webkit.org/show_bug.cgi?id=52476
2251
2252         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2253         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Update to use a WKStringRef.
2254         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2255
2256 2011-01-14  Tony Gentilcore  <tonyg@chromium.org>
2257
2258         Reviewed by David Levin.
2259
2260         Add Tony Gentilcore as a reviewer
2261         https://bugs.webkit.org/show_bug.cgi?id=52480
2262
2263         * Scripts/webkitpy/common/config/committers.py:
2264
2265 2011-01-14  David Levin  <levin@chromium.org>
2266
2267         Reviewed by Eric Seidel.
2268
2269         check-webkit-style: _FunctionState should keep track of where the function name starts.
2270         https://bugs.webkit.org/show_bug.cgi?id=52454
2271
2272         * Scripts/webkitpy/style/checkers/cpp.py: Added function_name_start_position to
2273         _FunctionState and logic for setting it correctly.
2274         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests.
2275
2276 2011-01-14  Vincent Scheib  <scheib@chromium.org>
2277
2278         Reviewed by David Levin.
2279
2280         Add support to DumpRenderTree to use the GPU rather than software renderer
2281         https://bugs.webkit.org/show_bug.cgi?id=52333
2282
2283         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2284         (main):
2285         * Scripts/webkitpy/layout_tests/port/chromium.py:
2286         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2287
2288 2011-01-14  Tony Chang  <tony@chromium.org>
2289
2290         Reviewed by Kent Tamura.
2291
2292         [chromium] update fonts.conf to fix 6 linux tests in drt
2293         https://bugs.webkit.org/show_bug.cgi?id=52411
2294
2295         * DumpRenderTree/chromium/fonts.conf: Update to match the copy in
2296             chromium's src/webkit/tools/test_shell/resources/fonts.conf
2297
2298 2011-01-14  Eric Seidel  <eric@webkit.org>
2299
2300         Original patch from Peter Gal  <galpater@inf.u-szeged.hu>
2301
2302         Reviewed by Adam Barth.
2303
2304         Fix when running Tools/Scripts/check-webkit-style without arguments.
2305         https://bugs.webkit.org/show_bug.cgi?id=52261#c16
2306
2307         * Scripts/webkitpy/common/checkout/scm.py: Handle None for changed_files argument better in Git.create_patch method.
2308         * Scripts/webkitpy/common/checkout/scm_unittest.py:
2309
2310 2011-01-04  Jochen Eisinger  <jochen@chromium.org>
2311
2312         Reviewed by David Levin.
2313
2314         Store the tempdir object in a variable so it doesn't get deleted too early.
2315         https://bugs.webkit.org/show_bug.cgi?id=51875
2316
2317         * Scripts/update-webkit-auxiliary-libs:
2318         * Scripts/update-webkit-support-libs:
2319
2320 2011-01-14  Eric Seidel  <eric@webkit.org>
2321
2322         Unreviewed.  Make it work in python 2.5.
2323
2324         webkit-patch suggest-reviewers dies when ChangeLogs are missing
2325         https://bugs.webkit.org/show_bug.cgi?id=49158
2326
2327         * Scripts/webkitpy/common/checkout/api_unittest.py:
2328
2329 2011-01-14  Sheriff Bot  <webkit.review.bot@gmail.com>
2330
2331         Unreviewed, rolling out r75774.
2332         http://trac.webkit.org/changeset/75774
2333         https://bugs.webkit.org/show_bug.cgi?id=52431
2334
2335         gtk builds were broken (Requested by loislo2 on #webkit).
2336
2337         * Scripts/webkitpy/common/checkout/scm.py:
2338
2339 2011-01-14  David Levin  <levin@chromium.org>
2340
2341         Reviewed by Shinichiro Hamaji.
2342
2343         check-webkit-style: _FunctionState should detect pure functions.
2344         https://bugs.webkit.org/show_bug.cgi?id=52428
2345
2346         * Scripts/webkitpy/style/checkers/cpp.py: Added detection for if a function declaration
2347         is a pure virtual function.
2348         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests for verifying that pure
2349         virtual functions are correctly detected.
2350
2351 2011-01-13  Ilya Tikhonovsky  <loislo@chromium.org>
2352
2353         Reviewed by Yury Semikhatsky.
2354
2355         Just small fix for problem with check-webkit-style.
2356         It just didn't work for this patch.
2357         Old code can't concatenate a list of strings with None.
2358
2359         * Scripts/webkitpy/common/checkout/scm.py:
2360
2361 2011-01-13  David Levin  <levin@chromium.org>
2362
2363         Reviewed by Shinichiro Hamaji.
2364
2365         check-webkit-style: _FunctionState should use Position to know where items are.
2366         https://bugs.webkit.org/show_bug.cgi?id=52424
2367
2368         * Scripts/webkitpy/style/checkers/cpp.py:
2369         (_FunctionState.*): Changed _FunctionState to use Position instead of line numbers.
2370         (detect_functions): Changed to pass Position's to _FunctionState.begin and
2371         did some minor clean-up.
2372         (*): Other changes are simply about converting to use the Position's in_FunctionState
2373         instead of line numbers.
2374         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Changed the test code
2375         to verify the positions stored in _FunctionState.
2376
2377 2011-01-13  Eric Seidel  <eric@webkit.org>
2378
2379         Reviewed by David Levin.
2380
2381         webkit-patch suggest-reviewers dies when ChangeLogs are missing
2382         https://bugs.webkit.org/show_bug.cgi?id=49158
2383
2384         This is not the most elegant, but it is a very safe fix to this bug.
2385         One advantage of catching ScriptError like this instead of adding a
2386         new added_or_modified_files or fixing all changed_files callers
2387         to use a more specific change_files variant, is that we catch
2388         all kinds of ScriptErrors which might cause our (non-essential)
2389         suggest-reviewers code to fail out.  This should make passing
2390         --suggest-reviewers to webkit-patch upload much more robust
2391         and may even make it possible for us to make it default.
2392
2393         The root of the problem here is that SCM.changed_files includes
2394         deleted ChangeLog paths (from moves, etc) which then when we ask
2395         SVN/Git for the contents of the file at that revision, the command
2396         errors out and Executive.run_command raises a ScriptError.
2397
2398         In the future we might fix this differently by making all current
2399         callers of chagned_files use a more specific method for requesting
2400         what types of changes they're interested in (adds, modifies, deletes, etc.)
2401
2402         * Scripts/webkitpy/common/checkout/api.py:
2403         * Scripts/webkitpy/common/checkout/api_unittest.py:
2404
2405 2011-01-13  Dan Bernstein  <mitz@apple.com>
2406
2407         Reviewed by Alexey Proskuryakov.
2408
2409         <rdar://problem/8827065> REGRESSION (r71884): Cross-origin XHR fails if willSendRequest changes the URL
2410         https://bugs.webkit.org/show_bug.cgi?id=52419
2411
2412         Allow to further control the behavior of the willSendRequest delegate callback by making it
2413         set a different URL in the new request.
2414
2415         * DumpRenderTree/LayoutTestController.cpp:
2416         (addURLToRedirectCallback): Added.
2417         (LayoutTestController::staticFunctions): Added addURLToRedirect.
2418         (LayoutTestController::addURLToRedirect): Added. Adds the redirection to the map.
2419         (LayoutTestController::redirectionDestinationForURL): Added this getter.
2420         * DumpRenderTree/LayoutTestController.h:
2421         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2422         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]): Check
2423         if there is a redirection for the request’s URL, established by addURLToRedirect(), and if so,
2424         change the URL in the new request to the redirect destination.
2425
2426 2011-01-13  Eric Seidel  <eric@webkit.org>
2427
2428         Reviewed by Mihai Parparita.
2429
2430         webkit-patch suggest-reviewers fails due to invalid utf8 in ChangeLog files
2431         https://bugs.webkit.org/show_bug.cgi?id=52416
2432
2433         Example: webkit-patch suggest-reviewers -g ca3890fe74d94d85d6bfa48f9ea497b094d8e717 
2434         UnicodeDecodeError: 'utf8' codec can't decode bytes in position 536-538: invalid data
2435
2436         I also added FIXMEs about the changed_files returning deleted files problem
2437         which is causing the other most common exception for suggest-reviewers
2438         (and is probably breaking sheriff-bots blame detection).
2439
2440         * Scripts/webkitpy/common/checkout/api.py:
2441         * Scripts/webkitpy/common/checkout/api_unittest.py:
2442         * Scripts/webkitpy/common/checkout/scm.py:
2443
2444 2011-01-13  Eric Seidel  <eric@webkit.org>
2445
2446         Reviewed by Adam Barth.
2447
2448         results archives from commit-queue are too large to upload
2449         https://bugs.webkit.org/show_bug.cgi?id=52405
2450
2451         * Scripts/webkitpy/common/system/filesystem.py:
2452         * Scripts/webkitpy/common/system/filesystem_mock.py:
2453         * Scripts/webkitpy/tool/commands/queues.py:
2454
2455 2011-01-13  Alejandro G. Castro  <alex@igalia.com>
2456
2457         Reviewed by Martin Robinson.
2458
2459         [gtk] Zero-sized font does not yet work
2460         https://bugs.webkit.org/show_bug.cgi?id=49793
2461
2462         Set minimum-font-size to 0 for the DRT.
2463
2464         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2465         (resetDefaultsToConsistentValues):
2466
2467 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
2468
2469         Reviewed by Darin Adler.
2470
2471         Make old-run-webkit-tests more robust on buildbots
2472         https://bugs.webkit.org/show_bug.cgi?id=52364
2473
2474         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Pass --exit-after-n-failures 500 to old-run-webkit-tests script.
2475
2476 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
2477
2478         Reviewed by Darin Adler.
2479
2480         Make old-run-webkit-tests more robust on buildbots
2481         https://bugs.webkit.org/show_bug.cgi?id=52364
2482
2483         * Scripts/old-run-webkit-tests: Ensure that testResultsDirectory is empty.
2484
2485 2011-01-13  Tony Chang  <tony@chromium.org>
2486
2487         Reviewed by Kent Tamura.
2488
2489         [chromium] fix plugins/plugin-javascript-access.html on Linux and Mac
2490         https://bugs.webkit.org/show_bug.cgi?id=52332
2491
2492         Forked Info.plist is not longer needed.
2493
2494         * DumpRenderTree/chromium/TestNetscapePlugIn/Info.plist: Removed.
2495
2496 2011-01-13  Mikhail Naganov  <mnaganov@chromium.org>
2497
2498         Reviewed by Timothy Hatcher.
2499
2500         Web Inspector: Cleanup after r75613 -- make all UI-facing strings
2501         to be passed directly to WebInspector.UIString
2502
2503         https://bugs.webkit.org/show_bug.cgi?id=52365
2504
2505         * Scripts/check-inspector-strings:
2506
2507 2011-01-13  Sheriff Bot  <webkit.review.bot@gmail.com>
2508
2509         Unreviewed, rolling out r74881.
2510         http://trac.webkit.org/changeset/74881
2511         https://bugs.webkit.org/show_bug.cgi?id=52357
2512
2513         The EFL builder has been red for days (Requested by abarth on
2514         #webkit).
2515
2516         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2517         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2518
2519 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
2520
2521         Reviewed by David Levin.
2522
2523         Add beforeunload support to WebKitTestRunner
2524         https://bugs.webkit.org/show_bug.cgi?id=52353
2525         
2526         This makes a number of currently failing tests pass.
2527
2528         * WebKitTestRunner/TestController.cpp:
2529         (WTR::runBeforeUnloadConfirmPanel):
2530         (WTR::createOtherPage):
2531         (WTR::TestController::initialize):
2532
2533 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
2534
2535         Reviewed by Sam Weinig.
2536
2537         Detect, identify and recover from WebProcess crashes in run-webkit-tests
2538         https://bugs.webkit.org/show_bug.cgi?id=52330
2539
2540         * Scripts/old-run-webkit-tests: Detect when the regression test tool reports
2541         a web process crash.
2542         * WebKitTestRunner/TestController.cpp:
2543         (WTR::TestController::initialize): Set up a processDidCrash
2544         callback.
2545         (WTR::TestController::processDidCrash): Report that the Web process
2546         crashed.
2547         * WebKitTestRunner/TestController.h:
2548
2549 2011-01-12  David Levin  <levin@chromium.org>
2550
2551         Reviewed by Shinichiro Hamaji.
2552
2553         check-webkit-style -- close_expression function doesn't work correctly.
2554         https://bugs.webkit.org/show_bug.cgi?id=52272
2555
2556         * Scripts/webkitpy/style/checkers/cpp.py:
2557         (Position.__str__): Added a way to convert it to a string which is useful in tests.
2558         (Position.__cmp__): Added a way to compare Position which is useful in tests and
2559         generally useful (for upcoming code changes).
2560         (close_expression): Changed to use Position for input and output.
2561         Also, fixed many bugs such as only working correctly for parenthesis,
2562         not working correctly if given an offset in a line and not finding
2563         the real closing element if there were multiple closing elements in
2564         the same line.
2565         (detect_functions): Adjusted due to the change in arguments for
2566         close_expression.
2567         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2568         (CppStyleTestBase.assert_positions_equal): Added a way to verify that
2569         two positions are the same.
2570         (CppStyleTest.test_position): Added tests for the __str_ and __cmp__ methods.
2571         (CppStyleTest.test_close_expression): Added tests to catch the issues
2572         that were fixed.
2573
2574 2011-01-12  Sheriff Bot  <webkit.review.bot@gmail.com>
2575
2576         Unreviewed, rolling out r75576.
2577         http://trac.webkit.org/changeset/75576
2578         https://bugs.webkit.org/show_bug.cgi?id=52304
2579
2580         broke rebaseline-chromium-webkit-test (Requested by thakis on
2581         #webkit).
2582
2583         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2584         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2585         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
2586         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2587         * Scripts/webkitpy/layout_tests/port/base.py:
2588         * Scripts/webkitpy/layout_tests/port/chromium.py:
2589         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2590         * Scripts/webkitpy/layout_tests/port/test.py:
2591         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2592         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2593         * Scripts/webkitpy/style/checkers/test_expectations.py:
2594         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
2595
2596 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
2597
2598         Reviewed by Darin Adler.
2599
2600         Add a no-build option to run-webkit-tests, to avoid building DRT/WKTR
2601         https://bugs.webkit.org/show_bug.cgi?id=52307
2602
2603         * Scripts/old-run-webkit-tests:
2604
2605 2011-01-12  Koan-Sin Tan  <koansin.tan@gmail.com>
2606
2607         Reviewed by Martin Robinson.
2608
2609         [Gtk] WebKitGtk+ doesn't build on Mac OS X 10.6
2610         https://bugs.webkit.org/show_bug.cgi?id=50867
2611
2612         Fixed library extention for Mac in webkitdirs.pm and type conflict in
2613         TestNetscapePlugin.cpp 
2614
2615         * GNUmakefile.am: Don't use AppKit when compiling TestNetscapePlugin for GTK+
2616         * Scripts/webkitdirs.pm:
2617
2618 2011-01-12  Mikhail Naganov  <mnaganov@chromium.org>
2619
2620         Reviewed by Pavel Feldman.
2621
2622         Add check-inspector-strings script.
2623
2624         https://bugs.webkit.org/show_bug.cgi?id=52295
2625
2626         * Scripts/check-inspector-strings: Added.
2627
2628 2011-01-12  Adam Roben  <aroben@apple.com>
2629
2630         Advertise the .testnetscape file extension on Windows
2631
2632         Fixes <http://webkit.org/b/52298>
2633         plugins/no-mime-with-valid-extension.html fails on Windows
2634
2635         Reviewed by Dan Bernstein.
2636
2637         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Added a
2638         FileExtents field to map the .testnetscape file extension to the
2639         application/x-webkit-test-netscape MIME type, just as we do on Mac.
2640
2641 2011-01-12  Adam Barth  <abarth@webkit.org>
2642
2643         Reviewed by Eric Seidel.
2644
2645         Make webkit-patch support subdirectories for SVN checkouts
2646         https://bugs.webkit.org/show_bug.cgi?id=52261
2647
2648         os.relpath does not exist on Python 2.5, so we need to call our version
2649         of the API.
2650
2651         * Scripts/webkitpy/common/checkout/scm.py:
2652
2653 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
2654
2655         Reviewed by Eric Seidel.
2656
2657         Close additional pages opened during a test once the test completes.
2658         https://bugs.webkit.org/show_bug.cgi?id=52276
2659
2660         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2661         (WTR::InjectedBundle::done):
2662
2663 2011-01-11  David Levin  <levin@chromium.org>
2664
2665         Reviewed by Eric Seidel.
2666
2667         Errors should be separated from the command line in bot messages.
2668         https://bugs.webkit.org/show_bug.cgi?id=52275
2669
2670         * Scripts/webkitpy/common/system/executive.py:
2671         (ScriptError.message_with_output): Added a newline to separate the command
2672         line from the errors.
2673         * Scripts/webkitpy/common/system/executive_unittest.py:
2674         (ScriptErrorTest.test_message_with_output): Added tests for the various code
2675         paths in message_with_output.
2676
2677 2011-01-11  Eric Seidel  <eric@webkit.org>
2678
2679         Unreviewed.
2680
2681         commit-queue should know how to upload archived results (for test flakes or general failures)
2682         https://bugs.webkit.org/show_bug.cgi?id=52048
2683
2684         The zips are mostly empty due to forgetting -r.
2685         Expected diffs were not being pulled from the archive due
2686         to the archive having longer paths than I realized.
2687
2688         * Scripts/webkitpy/common/system/workspace.py:
2689         * Scripts/webkitpy/common/system/workspace_unittest.py:
2690         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2691         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2692
2693 2011-01-11  Dirk Pranke  <dpranke@chromium.org>
2694
2695         Reviewed by Ojan Vafai.
2696
2697         The current modifier parsing code in test_expectations is
2698         fragile and hard-coded, so it's not easy to understand the logic
2699         or easily add new types of modifiers (like GPU vs. CPU testing
2700         for graphics tests, or 32-bit vs. 64-bit differences).
2701
2702         This is the first of two patches that will add in more generic
2703         support and then eliminate the GPU-specific test expectations
2704         files for Chromium.
2705
2706         This patch adds two standalone objects for handling modifiers. The
2707         rules for interpreting modifiers, precedence, and conflicts are
2708         given in the docstring to the ModifierMatcher class, which
2709         returns ModifierMatchResult objects.
2710         
2711         This patch also adds routines to the Port interface and a
2712         default set of values in the base object, in order to obtain the
2713         values needed on a given test run. These values are then passed
2714         to the expectation parser. This also allows us to clean up the
2715         logic used to lint all of the different configurations in a
2716         single test_expectations.txt file.
2717
2718         The next patch will merge in the separate GPU expectations file.
2719
2720         https://bugs.webkit.org/show_bug.cgi?id=51222
2721
2722         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2723         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2724         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
2725         * Scripts/webkitpy/layout_tests/port/base.py:
2726         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2727         * Scripts/webkitpy/layout_tests/port/chromium.py:
2728         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2729         * Scripts/webkitpy/layout_tests/port/test.py:
2730         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2731         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2732
2733 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
2734
2735         Reviewed by Adam Barth.
2736
2737         Make webkit-patch support subdirectories for SVN checkouts
2738         https://bugs.webkit.org/show_bug.cgi?id=52261
2739
2740         * Scripts/webkitpy/common/checkout/scm.py:
2741         * Scripts/webkitpy/style_references.py:
2742         * Scripts/webkitpy/tool/main.py:
2743         * Scripts/webkitpy/tool/steps/preparechangelog.py:
2744
2745 2011-01-11  Eric Seidel  <eric@webkit.org>
2746
2747         Unreviewed.
2748
2749         commit-queue should know how to upload archived results (for test flakes or general failures)
2750         https://bugs.webkit.org/show_bug.cgi?id=52048
2751
2752         I changed the API for archive_last_layout_test_results w/o updating the implementation.  Oops.
2753         This fixes an exception seen on the commit-queue when attempting to report flaky tests.
2754
2755         * Scripts/webkitpy/common/system/workspace.py:
2756         * Scripts/webkitpy/common/system/workspace_unittest.py:
2757         * Scripts/webkitpy/tool/commands/queues.py:
2758
2759 2011-01-11  Sam Weinig  <sam@webkit.org>
2760
2761         Roll r75474 back in.
2762
2763 2011-01-11  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
2764
2765         Reviewed by Kenneth Rohde Christiansen.
2766
2767         [Qt] Remove uses of QFuture since it isn't supported on all platforms.
2768         https://bugs.webkit.org/show_bug.cgi?id=51204
2769
2770         * QtTestBrowser/webpage.h:
2771         (QtNAMThread::QtNAMThread):
2772         (QtNAMThread::networkAccessManager):
2773         (QtNAMThread::run):
2774
2775 2011-01-11  Peter Varga  <pvarga@webkit.org>
2776
2777         Unreviewed.
2778
2779         Add myself to committers' list.
2780
2781         * Scripts/webkitpy/common/config/committers.py:
2782
2783 2011-01-11  Eric Seidel  <eric@webkit.org>
2784
2785         Reviewed by Adam Barth.
2786
2787         commit-queue should know how to upload archived results (for test flakes or general failures)
2788         https://bugs.webkit.org/show_bug.cgi?id=52048
2789
2790         Now the queue will always upload results.  Either the entire zip, or just
2791         the diffs.txt in the case of text failures.
2792
2793         This should make understanding flakes much easier, and paves the way
2794         for having the EWS run layout tests (and upload failures).
2795
2796         In order to upload .zip files I had to teach bugzilla.py to autodetect
2797         mime types from the filename.  Since mimetypes.py doesn't include a mapping
2798         for .patch files, I have it add one before calling guess_type.
2799
2800         We may find that always uploading the whole zip instead of just the -diffs.txt
2801         file is preferable, but for now I'm keeping the old behavior because it makes
2802         quickly understanding text failures easy.
2803
2804         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2805         * Scripts/webkitpy/common/system/workspace.py: Added.
2806         * Scripts/webkitpy/common/system/workspace_unittest.py: Added.
2807         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2808         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2809         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2810         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2811         * Scripts/webkitpy/tool/commands/queues.py:
2812         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2813
2814 2011-01-10  Sheriff Bot  <webkit.review.bot@gmail.com>
2815
2816         Unreviewed, rolling out r75464.
2817         http://trac.webkit.org/changeset/75464
2818         https://bugs.webkit.org/show_bug.cgi?id=52193
2819
2820         Followup rollout for 75474 (Requested by Ossy on #webkit).
2821
2822         * MiniBrowser/mac/BrowserWindowController.m:
2823         (-[BrowserWindowController awakeFromNib]):
2824         * MiniBrowser/win/BrowserView.cpp:
2825         (BrowserView::create):
2826         * WebKitTestRunner/TestController.cpp:
2827         (WTR::createOtherPage):
2828         (WTR::TestController::initialize):
2829
2830 2011-01-10  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2831
2832         Reviewed by Csaba Osztrogonác.
2833
2834         [Qt] Baseline qt_minimal configuration
2835         https://bugs.webkit.org/show_bug.cgi?id=51313
2836
2837         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2838         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): Add
2839         QT_NO_UNDOSTACK guard.
2840
2841         * QtTestBrowser/launcherwindow.cpp:
2842         (LauncherWindow::createChrome): Add QT_NO_SHORTCUT and QT_NO_PRINTER
2843         guards.
2844         (LauncherWindow::applyZoom): Add QT_NO_ANIMATION guard.
2845         (LauncherWindow::screenshot): Add QT_NO_FILEDIALOG guard.
2846         (LauncherWindow::selectElements): Add QT_NO_INPUTDIALOG guard.
2847         (LauncherWindow::showUserAgentDialog): Add QT_NO_COMBOBOX guard.
2848
2849         * QtTestBrowser/launcherwindow.h:
2850         * QtTestBrowser/locationedit.cpp: Add QT_NO_INPUTDIALOG guard.
2851         * QtTestBrowser/locationedit.h: Ditto.
2852
2853         * QtTestBrowser/mainwindow.cpp:
2854         (MainWindow::buildUI): Add QT_NO_INPUTDIALOG, QT_NO_SHORTCUT and
2855         QT_NO_UNDOSTACK guards.
2856         (MainWindow::setAddressUrl): Add QT_NO_INPUTDIALOG guard.
2857         (MainWindow::changeLocation): Ditto.
2858         (MainWindow::openFile): Add QT_NO_FILEDIALOG guard.
2859         (MainWindow::openLocation): Add QT_NO_INPUTDIALOG guard.
2860
2861         * QtTestBrowser/webpage.cpp:
2862         (WebPage::openUrlInDefaultBrowser): Add QT_NO_DESKTOPSERVICES guard.
2863         (WebPage::authenticationRequired): Add QT_NO_LINEEDIT guard.
2864
2865         * QtTestBrowser/webview.cpp:
2866         (WebViewGraphicsBased::animatedFlip): Add QT_NO_ANIMATION guard.
2867         (WebViewGraphicsBased::animatedYFlip): Ditto.
2868
2869 2011-01-10  Sam Weinig  <sam@webkit.org>
2870
2871         Fix build.
2872
2873         * MiniBrowser/mac/BrowserWindowController.m:
2874         (-[BrowserWindowController awakeFromNib]):
2875         * MiniBrowser/win/BrowserView.cpp:
2876         (BrowserView::create):
2877         * WebKitTestRunner/TestController.cpp:
2878         (WTR::createOtherPage):
2879         (WTR::TestController::initialize):
2880
2881 2011-01-10  Eric Seidel  <eric@webkit.org>
2882
2883         Reviewed by Ojan Vafai.
2884
2885         style-queue messages are way too long for big patches
2886         https://bugs.webkit.org/show_bug.cgi?id=52161
2887
2888         We definitely could build much fancier list-to-string-with-limit functions
2889         but this should be sufficient for our needs at the moment.
2890
2891         * Scripts/webkitpy/common/system/executive.py:
2892         * Scripts/webkitpy/common/system/executive_unittest.py:
2893
2894 2011-01-10  Tony Chang  <tony@chromium.org>
2895
2896         Unreviewed, rolling out r75398.
2897         http://trac.webkit.org/changeset/75398
2898         https://bugs.webkit.org/show_bug.cgi?id=52008
2899
2900         Some layout tests are crashing on Chromium Win.
2901
2902         * DumpRenderTree/chromium/WebViewHost.cpp:
2903         (WebViewHost::updatePaintRect):
2904         * DumpRenderTree/chromium/WebViewHost.h:
2905
2906 2011-01-10  Adam Roben  <aroben@apple.com>
2907
2908         Roll out r75392
2909
2910         It isn't needed now that r75289 has been rolled out.
2911
2912         * Scripts/run-javascriptcore-tests:
2913
2914 2011-01-10  Maciej Stachowiak  <mjs@apple.com>
2915
2916         Reviewed by Anders Carlsson.
2917
2918         WebKitTestRunner uses crazy amounts of CPU, making layout tests slow and flaky
2919         https://bugs.webkit.org/show_bug.cgi?id=52160
2920
2921         * WebKitTestRunner/mac/TestControllerMac.mm:
2922         (WTR::TestController::platformRunUntil): Instead of busy-looping, wait for the timeout.
2923         Anything that can make runUntil() conditions turn true will happen on a run loop cycle
2924         anyway.
2925
2926 2011-01-10  Tony Chang  <tony@chromium.org>
2927
2928         Reviewed by Mihai Parparita.
2929
2930         [chromium] fix for animated gif layout tests
2931         https://bugs.webkit.org/show_bug.cgi?id=52008
2932
2933         * DumpRenderTree/chromium/WebViewHost.cpp: Schedule a paint when we update the paint rect
2934             to trigger gif animations.
2935         (WebViewHostPaintTask::WebViewHostPaintTask):
2936         (WebViewHostPaintTask::runIfValid):
2937         (WebViewHost::updatePaintRect):
2938         * DumpRenderTree/chromium/WebViewHost.h:
2939         (WebViewHost::taskList):
2940
2941 2011-01-10  Alejandro G. Castro  <alex@igalia.com>
2942
2943         Reviewed by Xan Lopez.
2944
2945         [GTK] Fix gtk2 compilation for master
2946         https://bugs.webkit.org/show_bug.cgi?id=51885
2947
2948         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
2949         (createBitmapContextFromWebView): Replaced the old
2950         gdk_drawable_get_size with gdk_pixmap_get_size.
2951
2952 2011-01-10  Patrick Gansterer  <paroga@webkit.org>
2953
2954         Reviewed by Laszlo Gombos.
2955
2956         [WINCE] Reenable NPAPI after r75203
2957         https://bugs.webkit.org/show_bug.cgi?id=52109
2958
2959         Remove the !isWinCE() check for ENABLE_NETSCAPE_PLUGIN_API and replace
2960         it with !isEfl(), because EFL port does not support NPAPI (yet).
2961
2962         * Scripts/build-webkit:
2963
2964 2011-01-10  Adam Roben  <aroben@apple.com>
2965
2966         Skip some asserting JS tests
2967
2968         See <http://webkit.org/b/52156>.
2969
2970         * Scripts/run-javascriptcore-tests:
2971
2972 2011-01-10  Martin Robinson  <mrobinson@igalia.com>
2973
2974         Reviewed by Xan Lopez.
2975
2976         [GTK] build-webkit disable Blob support via arguments passed to automake
2977         https://bugs.webkit.org/show_bug.cgi?id=52097
2978
2979         * Scripts/build-webkit: Enable Blob support when building WebKitGTK+ via
2980         build-webkit.
2981
2982 2011-01-10  Adam Roben  <aroben@apple.com>
2983
2984         Use the same name and description for TestNetscapePlugin on Windows and
2985         Mac
2986
2987         Fixes <http://webkit.org/b/52151>
2988         fast/frames/iframe-reparenting-plugins.html fails on Windows
2989
2990         Reviewed by Steve Falkenburg.
2991
2992         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Copied
2993         the name and description from Mac's Info.plist.
2994
2995 2011-01-10  Siddharth Mathur <siddharth.mathur@nokia.com>
2996
2997         Reviewed by Laszlo Gombos.
2998
2999         [Qt][WK2] Guard gcc-specific syntax
3000
3001         Non-gcc based compliers choke on the "-include"
3002         syntax for preinclude, place guard around it.
3003
3004         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3005         * WebKitTestRunner/qt/WebKitTestRunner.pro:
3006
3007 2011-01-10  Andreas Kling  <kling@webkit.org>
3008
3009         Reviewed by Simon Hausmann.
3010
3011         [Qt] [WK2] MiniBrowser does not load pages opened in new windows
3012         https://bugs.webkit.org/show_bug.cgi?id=52111
3013
3014         When getting a createNewPage() callback from QWKPage, create the
3015         new page with the same QWKContext as the page that is passed to
3016         the callback.
3017
3018         * MiniBrowser/qt/BrowserView.h:
3019         * MiniBrowser/qt/BrowserWindow.cpp:
3020         (newPageFunction):
3021         (BrowserWindow::BrowserWindow):
3022         * MiniBrowser/qt/BrowserWindow.h:
3023
3024 2011-01-10  Andreas Kling  <kling@webkit.org>
3025
3026         Reviewed by Kenneth Rohde Christiansen.
3027
3028         [Qt] MiniBrowser: Remove superfluous createNewPage() callback
3029
3030         BrowserView set its own useless createNewPage() callback on QWKPage.
3031         This was immediately overridden by BrowserWindow anyway, so remove
3032         the BrowserView one.
3033
3034         * MiniBrowser/qt/BrowserView.cpp:
3035         (BrowserView::BrowserView):
3036
3037 2011-01-10  John Knottenbelt  <jknotten@chromium.org>
3038
3039         Reviewed by Jeremy Orlow.
3040
3041         [Chromium] Remove non-client-based Geolocation code
3042         https://bugs.webkit.org/show_bug.cgi?id=50921
3043
3044         * DumpRenderTree/chromium/LayoutTestController.cpp:
3045         (LayoutTestController::setGeolocationPermission):
3046         (LayoutTestController::setMockGeolocationPosition):
3047         (LayoutTestController::setMockGeolocationError):
3048         * DumpRenderTree/chromium/WebViewHost.cpp:
3049         (WebViewHost::geolocationClientMock):
3050         (WebViewHost::reset):
3051         * DumpRenderTree/chromium/WebViewHost.h:
3052
3053 2011-01-10  Eric Seidel  <eric@webkit.org>
3054
3055         Reviewed by Adam Barth.
3056
3057         Commit bot tried to land r? cq+ patch
3058         https://bugs.webkit.org/show_bug.cgi?id=36638
3059
3060         It should now be possible to post a patch with r? and cq+ and the
3061         commit-queue will correctly wait for the r+ before attempting to land the patch.
3062         (This was a feature requested by several users.)
3063
3064         One caveat: We don't actually reject r-, cq+ patches from the queue
3065         (we just ignore them), but I think that's OK for now.
3066
3067         I also noticed that setting r- once a commit-queue node had grabbed
3068         a patch would not properly cancel the landing.  That's fixed and
3069         tested in this patch.
3070
3071         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3072         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3073         * Scripts/webkitpy/tool/bot/feeders.py:
3074         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
3075
3076 2011-01-08  Benjamin Poulain  <benjamin.poulain@nokia.com>
3077
3078         Reviewed by Kenneth Rohde Christiansen.
3079
3080         [Qt] QtWebKit crashes when using XMLHttpRequest from the unload event
3081         https://bugs.webkit.org/show_bug.cgi?id=51934
3082
3083         When accessing the network from the destructor of QWebPage, the network access manager
3084         was already deleted because the object WebPage was already destructed.
3085
3086         This solve the problem by linking the lifetime of the network access manager to WebPage's QObject.
3087         The object is now destructed in the destructor of QObject.
3088
3089         * QtTestBrowser/webpage.cpp:
3090         (WebPage::WebPage):
3091         (WebPage::setQnamThreaded):
3092         * QtTestBrowser/webpage.h:
3093         (QtNAMThread::QtNAMThread):
3094
3095 2011-01-08  Eric Seidel  <eric@webkit.org>
3096
3097         Reviewed by Ojan Vafai.
3098
3099         test_failures.py should not mention TestShell (long live DumpRenderTree!)
3100         https://bugs.webkit.org/show_bug.cgi?id=52067
3101
3102         I ran test-webkitpy, but didn't bother adding a unit test for this string change.
3103         https://bugs.webkit.org/show_bug.cgi?id=51138#c3 is an example of why this is needed.
3104
3105         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
3106
3107 2011-01-08  Eric Seidel  <eric@webkit.org>
3108
3109         Reviewed by Mihai Parparita.
3110
3111         commit-queue hangs when the ChangeLog diff is bad
3112         https://bugs.webkit.org/show_bug.cgi?id=52072
3113
3114         * Scripts/webkitpy/tool/steps/validatechangelogs.py:
3115         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
3116
3117 2011-01-08  Adam Barth  <abarth@webkit.org>
3118
3119         Teach svn-apply how to re-write WebCore to Source/WebCore.
3120
3121         * Scripts/VCSUtils.pm:
3122
3123 2011-01-07  Adam Barth  <abarth@webkit.org>
3124
3125         Rubber-stamped by Eric Seidel.
3126
3127         Move WebCore to Source
3128         https://bugs.webkit.org/show_bug.cgi?id=52050
3129
3130         Update the tools to understand WebCore's new location.
3131
3132         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3133         * DumpRenderTree/wscript:
3134         * GNUmakefile.am:
3135         * Scripts/build-webkit:
3136         * Scripts/do-file-rename:
3137         * Scripts/do-webcore-rename:
3138         * Scripts/generate-qt-inspector-resource:
3139         * Scripts/prepare-ChangeLog:
3140         * Scripts/run-bindings-tests:
3141         * Scripts/update-iexploder-cssproperties:
3142         * Scripts/update-sources-list.py:
3143         * Scripts/update-webkit-localizable-strings:
3144         * Scripts/webkitdirs.pm:
3145         * Scripts/webkitpy/common/config/build.py:
3146         * Scripts/webkitpy/common/config/build_unittest.py:
3147         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
3148         * Scripts/webkitpy/style/checker.py:
3149         * Scripts/webkitpy/style/checker_unittest.py:
3150         * WebKitTestRunner/DerivedSources.pro:
3151         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3152         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh:
3153         * wx/browser/wscript:
3154         * wx/build/settings.py:
3155
3156 2011-01-07  Maciej Stachowiak  <mjs@apple.com>
3157
3158         Reviewed by Sam Weinig.
3159
3160         Make WebKitTestRunner rest between loads more robust to avoid test crashes
3161         https://bugs.webkit.org/show_bug.cgi?id=52086
3162
3163         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3164         (WTR::InjectedBundle::didReceiveMessage):
3165         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3166         (WTR::LayoutTestController::notifyDone):
3167         * WebKitTestRunner/TestController.cpp:
3168         (WTR::TestController::resetStateToConsistentValues):
3169         (WTR::TestController::run):
3170
3171 2011-01-07  James Robinson  <jamesr@chromium.org>
3172
3173         Revert "Implement mozilla's animationTime property"
3174         https://bugs.webkit.org/show_bug.cgi?id=51952
3175
3176         This approach isn't quite right.
3177
3178         * DumpRenderTree/chromium/WebViewHost.cpp:
3179         (WebViewHost::paintInvalidatedRegion):
3180
3181 2011-01-07  Adam Roben  <aroben@apple.com>
3182
3183         Build master fix
3184
3185         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3186         (RunWebKitTests.start): Don't try to concatenate a list and a string.
3187
3188 2011-01-07  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>
3189
3190         Reviewed by Csaba Osztrogonác.
3191
3192         run-qtwebkit-tests should be able to kill a testsuite.
3193
3194         Add new option in the script that can setup a timeout for a test.
3195         If the test execution takes more then specified time then the test
3196         would be terminated.
3197
3198         [Qt] run-qtwebkit-tests needs timeout
3199         https://bugs.webkit.org/show_bug.cgi?id=51894
3200
3201         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3202         * Scripts/run-qtwebkit-tests:
3203
3204 2011-01-07  Csaba Osztrogonác  <ossy@webkit.org>
3205
3206         Unreviewed fix after r75233.
3207
3208         Based on idea from Eric Seidel.
3209
3210         Add remote zip file handling to webkitpy.
3211         https://bugs.webkit.org/show_bug.cgi?id=50901
3212
3213         * Scripts/webkitpy/common/system/fileset.py: Make python 2.5 happy.
3214
3215 2011-01-07  Shane Stephens  <shanestephens@google.com>
3216
3217         Reviewed by Eric Seidel.
3218
3219         svn-apply: should support git binary delta diffs
3220         https://bugs.webkit.org/show_bug.cgi?id=38864
3221
3222         * Scripts/VCSUtils.pm:
3223         * Scripts/svn-apply:
3224
3225 2011-01-06  Julie Parent  <jparent@chromium.org>
3226
3227         Reviewed by Eric Seidel.
3228
3229         Test Result Server not removing old results.
3230         https://bugs.webkit.org/show_bug.cgi?id=52012
3231
3232         * TestResultServer/model/jsonresults.py:
3233         Fix off-by-one: Truncate if >= num_runs, not just >.
3234         * TestResultServer/model/jsonresults_unittest.py:
3235         Add unit test to test that merging in a new result with the same value
3236         as the last result causes previous result to fall off.
3237
3238 2011-01-06  James Kozianski  <koz@chromium.org>
3239
3240         Reviewed by Mihai Parparita.
3241
3242         Add classes to provide a consistent interface to a set of files.
3243         https://bugs.webkit.org/show_bug.cgi?id=50901
3244
3245         These classes allow us to write code that is agnostic to whether a
3246         particular set of files resides in a local directory or in a zip file
3247         on a remote machine.
3248
3249         * Scripts/webkitpy/common/system/directoryfileset.py: Added.
3250         * Scripts/webkitpy/common/system/directoryfileset_unittest.py: Added.
3251         * Scripts/webkitpy/common/system/fileset.py: Added.
3252         * Scripts/webkitpy/common/system/filesystem.py:
3253         * Scripts/webkitpy/common/system/filesystem_mock.py:
3254         * Scripts/webkitpy/common/system/zipfileset.py: Added.
3255         * Scripts/webkitpy/common/system/zipfileset_unittest.py: Added.
3256
3257 2011-01-06  Eric Seidel  <eric@webkit.org>
3258
3259         Reviewed by Adam Barth.
3260
3261         NetworkTransaction should log the url it is retrying
3262         https://bugs.webkit.org/show_bug.cgi?id=52043
3263
3264         * Scripts/webkitpy/common/net/networktransaction.py:
3265         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
3266
3267 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
3268
3269         Windows build fix.
3270         Import os before using it.
3271
3272         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3273
3274 2011-01-06  Eric Seidel  <eric@webkit.org>
3275
3276         Reviewed by Adam Barth.
3277
3278         StyleQueue fails to report errors when patches have many files
3279         https://bugs.webkit.org/show_bug.cgi?id=52042
3280
3281         This is one of at least two errors preventing style error reporting at the moment.
3282         When we moved to passing the list of files to check explicitly,
3283         we started to exceed the 500 character TEXT field limit for our AppEngine model object.
3284         We could change the type of the QueueStatus.message type, or we could
3285         just teach statusserver.py how to clamp values (and warn when it does).
3286         I chose the latter path.
3287
3288         * Scripts/webkitpy/common/net/statusserver.py:
3289
3290 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
3291
3292         Reviewed by Stephanie Lewis.
3293         
3294         Fix syntax error in script.
3295
3296         Windows bots need to archive/unarchive builds to/from configuration-specific directories
3297         https://bugs.webkit.org/show_bug.cgi?id=51996
3298
3299         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3300
3301 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3302
3303         Unreviewed, fixing WinCE build after r75196.
3304
3305         WinCE port does not (yet) support NPAPI.
3306
3307         * Scripts/build-webkit:
3308
3309 2011-01-06  Xan Lopez  <xlopez@igalia.com>
3310
3311         Reviewed by Darin Adler.
3312
3313         File::Spec->rel2abs in sunspider-compare-results mangles parameters
3314         https://bugs.webkit.org/show_bug.cgi?id=52015
3315
3316         * Scripts/sunspider-compare-results: call rel2abs on our arguments
3317         after the platform has been detected, otherwise the script will
3318         mangle things like '--gtk' into '/a/path/--gtk', breaking the
3319         detection.
3320
3321 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3322
3323         Reviewed by Eric Seidel.
3324
3325         Add ENABLE_NETSCAPE_PLUGIN_API, ENABLE_ORIENTATION_EVENTS and ENABLE_TOUCH_EVENTS flags to build-webkit
3326         https://bugs.webkit.org/show_bug.cgi?id=51346
3327
3328         * Scripts/build-webkit:
3329
3330 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
3331
3332         Reviewed by Adam Roben.
3333
3334         Windows bots need to archive/unarchive builds to/from configuration-specific directories
3335         https://bugs.webkit.org/show_bug.cgi?id=51996
3336         
3337         After the configuration directory change, we were archiving the incorrect directory for
3338         build product, so we were running tests on the wrong binaries.
3339         
3340         This change archives the correct directory, and also unarchives it into a configuration-
3341         specific directory.
3342
3343         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Use a configuration-specific directory on Windows.
3344         * BuildSlaveSupport/built-product-archive: Unarchive/archive to/from proper directory.
3345
3346 2011-01-06  Eric Seidel  <eric@webkit.org>
3347
3348         Reviewed by Mihai Parparita.
3349
3350         commit-queue mentions "Text diff mismatch" 4 times instead of once per failure
3351         https://bugs.webkit.org/show_bug.cgi?id=52002
3352
3353         See an example of this here:
3354         https://bugs.webkit.org/show_bug.cgi?id=51314#c2
3355
3356         It's due to the fact that we pass around TestFailure() instance
3357         objects and yet expect them to all compare to be the same.
3358
3359         This is bad.  We should either have shared instances of these values
3360         or we should just pass around the class names.  There are already hacks
3361         in place to make TestFailure objects pass equality tests, I just added
3362         a __hash__ implementation so they can be used in sets as expected.
3363
3364         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3365         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
3366
3367 2011-01-06  Evan Martin  <evan@chromium.org>
3368
3369         Reviewed by Tony Chang.
3370
3371         [gdb] handle inaccessible memory and UChar*
3372         https://bugs.webkit.org/show_bug.cgi?id=52003
3373
3374         To pretty-print a UChar*, we just grope around in the memory
3375         looking for a terminating NUL.  We need to handle the exception
3376         that can occur when we poke into an invalid location.
3377
3378         Additionally, the logic for choosing which pretty-printer would
3379         early return before hitting the point where we'd use the UChar*
3380         printer.  (Did this ever work?  How did it regress?)
3381
3382         * gdb/webkit.py:
3383
3384 2011-01-05  Brian Weinstein  <bweinstein@apple.com>
3385
3386         Reviewed by Ada Chan.
3387
3388         WebKit2: Should be able to call into injected bundle to ask if we should allow resource loads
3389         https://bugs.webkit.org/show_bug.cgi?id=51969
3390         
3391         Add shouldLoadResourceForFrame to WTR::InjectedBundlePage.
3392
3393         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3394         (WTR::InjectedBundlePage::InjectedBundlePage):
3395         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Stub implementation.
3396         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3397
3398 2011-01-06  James Robinson  <jamesr@chromium.org>
3399
3400         Reviewed by Simon Fraser.
3401
3402         Implement mozilla's animationTime property
3403         https://bugs.webkit.org/show_bug.cgi?id=51952
3404
3405         Chromium DRT support for webkitAnimationTime.
3406
3407         * DumpRenderTree/chromium/WebViewHost.cpp:
3408         (WebViewHost::paintInvalidatedRegion):
3409
3410 2011-01-06  Julie Parent  <jparent@chromium.org>
3411
3412         Reviewed by Tony Chang.
3413
3414         Test Result Server always truncates number of results to JSON_RESULTS_MAX_BUILDS
3415         https://bugs.webkit.org/show_bug.cgi?id=51217
3416
3417         * TestResultServer/model/jsonresults.py:
3418         Pass num_runs through to _remove_items_over_max_number_of_builds, and use the value.
3419         Adds missing documentation.
3420         * TestResultServer/model/jsonresults_unittest.py:
3421         Add unit test to test that truncation happens at smaller value than JSON_RESULTS_MAX_BUILDS.
3422         Update test_merge to take a number of builds to truncate at.
3423
3424 2011-01-06  Adam Barth  <abarth@webkit.org>
3425
3426         Reviewed by Eric Seidel.
3427
3428         The EWS should log outside of the working directory
3429         https://bugs.webkit.org/show_bug.cgi?id=51986
3430
3431         This patch prepare us for using git clean -x -d -f in the EWS wrapper
3432         script, which will actually clean the working copy back to a pristine
3433         state instead of leaving untracked directories and ignored files.
3434
3435         * Scripts/webkitpy/tool/commands/queues.py:
3436         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3437
3438 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
3439
3440         Windows build fix.
3441         Back out attempted change to built-product-archive.
3442
3443         * BuildSlaveSupport/built-product-archive:
3444
3445 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
3446
3447         Windows build fix.
3448         Include configuration name when unpacking a build archive.
3449
3450         Needed, since we split Windows build results into configuration-specific directories
3451         under WebKitOutputDir.
3452
3453         * BuildSlaveSupport/built-product-archive:
3454
3455 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
3456
3457         Reviewed by Darin Adler.
3458
3459         Debug and Release builds on Windows clobber each other
3460         https://bugs.webkit.org/show_bug.cgi?id=49185
3461
3462         Changes the structure of WebKitBuild build products directory so we
3463         completely separate each build configuration into independent directories.
3464         
3465         Although we previously had per-configuration directories for obj, this change adds
3466         per-configuration directories for bin, lib, obj, and include. Each configuration's
3467         build products are stored within a directory inside of WebKitBuild.
3468         
3469         Most use of $(WebKitOutputDir) in the build files has been replaced by $(ConfigurationBuildDir),
3470         defined in common.vsprops to be $(WebKitOutputDir)\$(ConfigurationName).
3471
3472         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops:
3473         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd:
3474         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd:
3475         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
3476         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd:
3477         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd:
3478         * DumpRenderTree/win/ImageDiffCommon.vsprops:
3479         * DumpRenderTree/win/ImageDiffPostBuild.cmd:
3480         * DumpRenderTree/win/ImageDiffPreBuild.cmd:
3481         * FindSafari/FindSafari.vcproj:
3482         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
3483         * MiniBrowser/MiniBrowserPostBuild.cmd:
3484         * MiniBrowser/MiniBrowserPreBuild.cmd:
3485         * Scripts/webkitdirs.pm:
3486         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
3487         * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops:
3488         * TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd:
3489         * TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd:
3490         * TestWebKitAPI/win/copy-resources.cmd:
3491         * WebKitAPITest/WebKitAPITestCommon.vsprops:
3492         * WebKitAPITest/WebKitAPITestPostBuild.cmd:
3493         * WebKitAPITest/WebKitAPITestPreBuild.cmd:
3494         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
3495         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
3496         * WebKitTestRunner/win/InjectedBundle.vcproj:
3497         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops:
3498         * WebKitTestRunner/win/InjectedBundlePostBuild.cmd:
3499         * WebKitTestRunner/win/InjectedBundlePreBuild.cmd:
3500         * WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd:
3501         * WebKitTestRunner/win/WebKitTestRunnerPreBuild.cmd:
3502         * WinLauncher/WinLauncherCommon.vsprops:
3503         * WinLauncher/WinLauncherPostBuild.cmd:
3504         * WinLauncher/WinLauncherPreBuild.cmd:
3505
3506 2011-01-05  Jan Erik Hanssen  <jhanssen@sencha.com>
3507
3508         Reviewed by Ariya Hidayat.
3509
3510         [Qt] TestNetscapePlugin doesn't link on OS X
3511         https://bugs.webkit.org/show_bug.cgi?id=51948
3512
3513         Only add a dependency on libX11 on X11 systems
3514
3515         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3516
3517 2011-01-05  Jeff Miller  <jeffm@apple.com>
3518
3519         Reviewed by Adam Roben.
3520
3521         check-webkit-style should allow unnecessary parameter names in WebKit2 APIs because we're matching CF's header style
3522         https://bugs.webkit.org/show_bug.cgi?id=51970
3523
3524         * Scripts/webkitpy/style/checker.py:
3525         Add -readability/naming for WebKit2 C API directories.
3526
3527 2011-01-05  Eric Seidel  <eric@webkit.org>
3528
3529         Unreviewed, just fixing one more log error from my previous python patch.
3530
3531         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
3532         https://bugs.webkit.org/show_bug.cgi?id=51802
3533
3534         webkit-patch failure-reason was logging about parsing errors
3535         due to my misunderstanding of how BeautifulSoup.findAll worked.
3536
3537         Fixed, and added a unit test.
3538
3539         * Scripts/webkitpy/common/net/layouttestresults.py:
3540         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3541
3542 2011-01-05  Benjamin Poulain  <benjamin.poulain@nokia.com>
3543
3544         Reviewed by Kenneth Rohde Christiansen.
3545
3546         [Qt] [WK2] Add the possibility to open window from the WebProcess in Minibrowser
3547         https://bugs.webkit.org/show_bug.cgi?id=51951
3548
3549         Set a function to QWKPage::setCreateNewPageFunction() in Minibrowser so there is a way
3550         to create new window from WebKit.
3551
3552         * MiniBrowser/qt/BrowserWindow.cpp:
3553         (newPageFunction):
3554         (BrowserWindow::BrowserWindow):
3555         (BrowserWindow::page): Added to avoid the indirect access to QWKPage spread in the class
3556         (BrowserWindow::newWindow):
3557         (BrowserWindow::updateUserAgentList):
3558         (BrowserWindow::showUserAgentDialog):
3559         * MiniBrowser/qt/BrowserWindow.h: Add the global variable backingStoreTypeForNewWindow to
3560         define the type of the backing store used for new windows.
3561         * MiniBrowser/qt/main.cpp:
3562         (main):
3563
3564 2011-01-05  Eric Seidel  <eric@webkit.org>
3565
3566         Reviewed by Ojan Vafai.
3567
3568         commit-queue should report failure type when reporting flaky tests
3569         https://bugs.webkit.org/show_bug.cgi?id=51900
3570
3571         This patch was a ridiculous amount of plumbing.  In the end I like
3572         the NRWT-style TestResult class even less.  But now we're passing
3573         a list of TestResult objects from the queue to the FlakyTestReporter.
3574         Thus the FlakyTestReporter can more easily report what type of failure
3575         occurred.
3576
3577         In the process, I found that I was not alone in finding TestResult
3578         cumbersome to use.  A bunch of code was trying to create a TestResult
3579         object with default values.  However since the constructor didn't make
3580         this easy, some places were getting it wrong (including the TestResult unit test)!
3581         I've fixed the TestResult constructor to have default values for non-essential
3582         arguments.
3583
3584         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3585         * Scripts/webkitpy/common/net/layouttestresults.py:
3586         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3587         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3588         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3589         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
3590         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
3591         * Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py:
3592         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
3593         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3594         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3595         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3596         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3597         * Scripts/webkitpy/tool/commands/queues.py:
3598         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3599
3600 2011-01-05  Eric Seidel  <eric@webkit.org>
3601
3602         Unreviewed.
3603
3604         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
3605         https://bugs.webkit.org/show_bug.cgi?id=51802
3606
3607         Add another unit test to cover a previously missing import.
3608
3609         * Scripts/webkitpy/common/net/layouttestresults.py:
3610         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3611
3612 2011-01-05  Mihai Parparita  <mihaip@chromium.org>
3613
3614         Reviewed by David Levin.
3615
3616         Add mihaip@chromium.org as a reviewer
3617         https://bugs.webkit.org/show_bug.cgi?id=51966
3618         
3619         Add myself as a reviewer.
3620
3621         * Scripts/webkitpy/common/config/committers.py:
3622
3623 2011-01-05  James Simonsen  <simonjam@chromium.org>
3624
3625         Unreviewed. Adding myself to the list of committers.
3626
3627         * Scripts/webkitpy/common/config/committers.py:
3628
3629 2011-01-05  Eric Seidel  <eric@webkit.org>
3630
3631         Unreviewed.
3632
3633         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
3634         https://bugs.webkit.org/show_bug.cgi?id=51802
3635
3636         Fix two exceptions seen on the bots after my original commit.
3637
3638         * Scripts/webkitpy/common/net/layouttestresults.py:
3639         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3640
3641 2011-01-05  Kundu Suchismita  <suchi.kundu@nokia.com>
3642
3643         Reviewed by Andreas Kling.
3644
3645         [Qt]Add local storage settings to QtTestBrowser command line arguments 
3646         https://bugs.webkit.org/show_bug.cgi?id=51750
3647
3648         * QtTestBrowser/main.cpp:
3649         (LauncherApplication::handleUserOptions):
3650          Local storage settings can be enable form command line arguments for
3651          QtTestBrowser.
3652
3653 2011-01-05  Chris Fleizach  <cfleizach@apple.com>
3654
3655         Reviewed by Martin Robinson.
3656
3657         GTK: AX: DRT needs to use correct root object method.
3658         https://bugs.webkit.org/show_bug.cgi?id=51911
3659
3660         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
3661         (AccessibilityController::rootElement):
3662
3663 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
3664
3665         Rubber-stamped by Csaba Osztrogonác.
3666
3667         Based on idea from Péter Gál.
3668
3669         * Scripts/webkitpy/tool/bot/sheriff.py: Remove unnecessary apostrophes around revision numbers.
3670
3671 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
3672
3673         Reviewed by Adam Barth.
3674
3675         sheriff-bot should be able to do multi-revision rollouts
3676         https://bugs.webkit.org/show_bug.cgi?id=51176
3677
3678         * Scripts/webkitpy/tool/bot/irc_command.py:
3679         * Scripts/webkitpy/tool/bot/sheriff.py:
3680         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
3681
3682 2011-01-05  Eric Seidel  <eric@webkit.org>
3683
3684         Reviewed by Adam Barth.
3685
3686         queues.webkit.org should have per-bot status pages
3687         https://bugs.webkit.org/show_bug.cgi?id=51906
3688
3689         Just adds a /queue-status/QUEUE_NAME/bots/BOT_ID page to show
3690         statuses from a single queue.  Now that we have many bots servicing
3691         some queues (commit-queue, win-ews, etc.) its easy to have the messages
3692         you care about scroll off the end of the 15-message limit on the main page.
3693
3694         Eventually we should probably rename /queue-status to /queue or /queues,
3695         but that's fodder for another patch.
3696
3697         * QueueStatusServer/handlers/queuestatus.py:
3698         * QueueStatusServer/index.yaml:
3699         * QueueStatusServer/main.py:
3700         * QueueStatusServer/templates/includes/singlequeuestatus.html:
3701          - This probably should use a custom filter instead of hard-coding
3702            the URL scheme here, but I couldn't figure out how to easily
3703            create such a filter.  Most filters work with "strings" so we can't
3704            pass the status object.  We could add a method to the status
3705            object and call that, but that seemed a bit strange too.
3706         * QueueStatusServer/templates/queuestatus.html:
3707
3708 2011-01-05  Carlos Garcia Campos  <cgarcia@igalia.com>
3709
3710         Unreviewed. Adding myself to the list of committers.
3711
3712         * Scripts/webkitpy/common/config/committers.py:
3713
3714 2011-01-04  Koan-Sin Tan  <koansin.tan@gmail.com>
3715
3716         Reviewed by David Levin.
3717
3718         check-webkit-style treated some macros with parentheses after #elif as function calls
3719         https://bugs.webkit.org/show_bug.cgi?id=51695
3720
3721         Ingore function call space checking in any preprocessor directives
3722         (things starting with #). Change search() to match() because 
3723         preprocessor directives are supposed to be in the beginning of lines.
3724
3725         * Scripts/webkitpy/style/checkers/cpp.py:
3726         * Scripts/webkitpy/style/checkers/cpp_unittest.py: make sure there is no false positives for #elif cases
3727
3728 2011-01-04  Søren Gjesse  <sgjesse@chromium.org>
3729
3730         Reviewed by Tony Chang.
3731
3732         Change the --multi-load test option to --stress-opt
3733         https://bugs.webkit.org/show_bug.cgi?id=50751
3734
3735         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3736         (runTest):
3737         (main):
3738         * DumpRenderTree/chromium/TestShell.cpp:
3739         (TestShell::TestShell):
3740         * DumpRenderTree/chromium/TestShell.h:
3741         (TestShell::stressOpt):
3742         (TestShell::setStressOpt):
3743         (TestShell::stressDeopt):
3744         (TestShell::setStressDeopt):
3745         (TestShell::javaScriptFlags):
3746         (TestShell::setJavaScriptFlags):
3747         * Scripts/webkitpy/layout_tests/port/chromium.py:
3748         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3749
3750 2011-01-04  Chris Fleizach  <cfleizach@apple.com>
3751
3752         Reviewed by Sam Weinig.
3753
3754         WK2: Support Accessibility
3755         https://bugs.webkit.org/show_bug.cgi?id=51859
3756
3757         Use rootObject() method to get top of accessibility tree.
3758
3759         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
3760         (AccessibilityController::focusedElement):
3761         (AccessibilityController::rootElement):
3762
3763 2011-01-03  Martin Robinson  <mrobinson@igalia.com>
3764
3765         Reviewed by Darin Adler.
3766
3767         Remove the last non-GObject usage of PlatformRefPtr and move the code to GRefPtr
3768         https://bugs.webkit.org/show_bug.cgi?id=51846
3769
3770         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: Change usage of PlatformRefPtr
3771         back to GRefPtr.
3772
3773 2011-01-04  Zhe Su  <suzhe@chromium.org>
3774
3775         Reviewed by Kenneth Russell.
3776
3777         Fix insertText, setMarkedText and unmarkText methods of
3778         TextInputController to call corresponding methods of WebKit::WebView
3779         rather than WebKit::WebFrame. This change matches the behavior of
3780         chromium browser.
3781         insertText corresponds to WebView::confirmComposition(text)
3782         setMarkedText corresponds to WebView::setComposition(...)
3783         unmarkText corresponds to WebView::confirmComposition()
3784         https://bugs.webkit.org/show_bug.cgi?id=51693
3785