9b9a6b621f5a9fa55e1526bf61c1c7ae003d6eef
[WebKit.git] / Tools / ChangeLog
1 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
2
3         Reviewed by Tony Chang.
4
5         Fix bug introduced in r72688 / bug 52768 that broke the
6         generation of the output filename links in the results.html
7         output. Apparently none of the unit tests actually checked to
8         make sure the generated links were correct :(
9
10         https://bugs.webkit.org/show_bug.cgi?id=52854
11
12         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
13         * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
14
15 2011-01-20  Alexey Proskuryakov  <ap@apple.com>
16
17         Reviewed by Darin Adler.
18
19         https://bugs.webkit.org/show_bug.cgi?id=52849
20         Make window.print work with WebKit2
21
22         * MiniBrowser/mac/BrowserWindowController.m:
23         (-[BrowserWindowController awakeFromNib]):
24         * WebKitTestRunner/TestController.cpp:
25         (WTR::createOtherPage):
26         (WTR::TestController::initialize):
27         Added zeroes to WKPageUIClient structures to avoid build failures.
28
29 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
30
31         Reviewed by Eric Seidel.
32
33         nrwt: remove fs refs from printing, test_failures, test_expectations, text_diff
34
35         https://bugs.webkit.org/show_bug.cgi?id=52756
36
37         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
38         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
39         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
40         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
41         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
42         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
43
44 2011-01-20  Mansi Mithal  <mansi.mithal@nokia.com>
45
46         Reviewed by Antonio Gomes.
47
48         QtTestBrowser should have a seperate menu for Settings
49         https://bugs.webkit.org/show_bug.cgi?id=52817
50         
51         Added a new menu item named "Settings"
52         and moved the "Enable interrupting js scripts" and "Enable js pop up windows" under the "Settings" menu 
53
54         * QtTestBrowser/launcherwindow.cpp:
55         (LauncherWindow::createChrome):
56
57 2011-01-20  Sam Weinig  <sam@webkit.org>
58
59         Reviewed by John Sullivan.
60
61         Update update-webkit-localizable-strings with new path to WebKit.
62
63         * Scripts/update-webkit-localizable-strings:
64
65 2011-01-20  James Robinson  <jamesr@chromium.org>
66
67         Reviewed by Darin Fisher.
68
69         Implement mozilla's requestAnimationFrame API
70         https://bugs.webkit.org/show_bug.cgi?id=51218
71
72         Chromium DumpRenderTree support for window.webkitRequestAnimationFrame.
73
74         * DumpRenderTree/chromium/WebViewHost.cpp:
75         (invokeScheduleComposite):
76         (WebViewHost::scheduleAnimation):
77         (WebViewHost::paintInvalidatedRegion):
78         * DumpRenderTree/chromium/WebViewHost.h:
79
80 2011-01-20  Maciej Stachowiak  <mjs@apple.com>
81
82         Reviewed by Adam Roben.
83
84         WebKitTestRunner needs to support layoutTestController.evaluateScriptInIsolatedWorld
85         https://bugs.webkit.org/show_bug.cgi?id=42327
86
87         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm: Add support
88         for methods that take their normal arguments but also a JSContextRef.
89         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: IDL definition
90         for evaluateScriptInIsolatedWorld.
91         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
92         (WTR::InjectedBundlePage::didClearWindowForFrame): Set a magic variable only if
93         this call is for an isolated world.
94         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
95         (WTR::worldMap): Helper to create a world map.
96         (WTR::LayoutTestController::worldIDForWorld): Map from an ID to a world.
97         (WTR::LayoutTestController::evaluateScriptInIsolatedWorld): The newly
98         added LayoutTestController API.
99         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
100
101 2011-01-19  Adam Roben  <aroben@apple.com>
102
103         Convert paths in environment variables back to msys-style inside commit-log-editor
104
105         When this script gets run from inside git commit, msys-style paths in the environment will
106         have been turned into Windows-style paths with forward slashes. This screws up functions
107         like File::Spec->rel2abs, which seem to rely on $PWD having an msys-style path. We convert
108         the paths back to msys-style before doing anything else.
109
110         Fixes <http://webkit.org/b/48527> commit-log-editor uses full paths for section headers when
111         using msysgit's Perl and multiple ChangeLogs have been edited
112
113         Reviewed by David Kilzer.
114
115         * Scripts/commit-log-editor: Call fixEnvironment before doing anything else.
116         (fixEnvironment): Added. When run in msys in conjunction with git (i.e., when invoked from
117         inside git commit), convert Windows-style paths in the environment back to msys-style paths.
118
119 2011-01-20  Zoltan Horvath  <zoltan@webkit.org>
120
121         [Win] Unreviewed build fix after r76248.
122
123         * DumpRenderTree/ForwardingHeaders/wtf/FastAllocBase.h: Added.
124
125 2011-01-20  Zoltan Horvath  <zoltan@webkit.org>
126
127         Reviewed by Csaba Osztrogonác.
128
129         Refactoring of the custom allocation framework
130         https://bugs.webkit.org/show_bug.cgi?id=49897
131
132         Inheriting from FastAllocBase can result in objects getting larger (bug #33896, #46589).
133         The modification replaces Noncopyable and FastAllocBase classes and these inherits with their
134         equivalent macro implementation at the necessary places.
135 2011-01-20  Yi Shen  <yi.4.shen@nokia.com>
136
137         Unreviewed. 
138
139         Adding myself to committers.py.
140
141         * Scripts/webkitpy/common/config/committers.py:
142
143 2011-01-20  Adam Barth  <abarth@webkit.org>
144
145         Reviewed by Tony Chang.
146
147         Chromium builders don't delete unversioned directories when DEPS change
148         https://bugs.webkit.org/show_bug.cgi?id=52745
149
150         If we pass this option to gclient sync, gclient will delete directories
151         that are no longer part of DEPS instead of leaving them around to
152         confuse us later.  Apparently, the downstream buildbots use this option
153         already.
154
155         * Scripts/update-webkit-chromium:
156
157 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
158
159         Unreviewed, build fix - I pulled this patch in to fix an issue
160         revealed by r76195 running on some new bots). Also fix a couple
161         of other issues revealed in testing.
162
163         nrwt: remove fs refs from layout_package/json*
164
165         https://bugs.webkit.org/show_bug.cgi?id=52754
166
167         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
168         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
169         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
170         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
171         * Scripts/webkitpy/layout_tests/port/base.py:
172
173 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
174
175         Unreviewed, build fix.
176
177         Fix a couple of minor bugs discovered while bringing up new bots
178         for testing.
179
180         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
181         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
182
183 2011-01-19  James Robinson  <jamesr@chromium.org>
184
185         Unreviewed, rolling out r76194.
186         http://trac.webkit.org/changeset/76194
187         https://bugs.webkit.org/show_bug.cgi?id=51218
188
189         Caused mysterious compile failure on the chromium win
190         build.webkit.org bots
191
192         * DumpRenderTree/chromium/WebViewHost.cpp:
193         (WebViewHost::paintInvalidatedRegion):
194         * DumpRenderTree/chromium/WebViewHost.h:
195
196 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
197
198         Reviewed by Mihai Parparita.
199
200         remove fs refs from test_runner, dump_render_tree_thread
201
202         https://bugs.webkit.org/show_bug.cgi?id=52753
203
204         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
205         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
206         * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
207         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
208
209 2011-01-19  James Robinson  <jamesr@chromium.org>
210
211         Reviewed by Darin Fisher.
212
213         Implement mozilla's requestAnimationFrame API
214         https://bugs.webkit.org/show_bug.cgi?id=51218
215
216         Chromium DumpRenderTree support for window.webkitRequestAnimationFrame.
217
218         * DumpRenderTree/chromium/WebViewHost.cpp:
219         (invokeScheduleComposite):
220         (WebViewHost::scheduleAnimation):
221         (WebViewHost::paintInvalidatedRegion):
222         * DumpRenderTree/chromium/WebViewHost.h:
223
224 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
225
226         Unreviewed, build fix.
227
228         Fix a few incorrect "self._filesystem" references introduced in
229         r76184.
230
231         * Scripts/webkitpy/layout_tests/port/chromium.py:
232         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
233
234 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
235
236         Reviewed by Mihai Parparita.
237
238         add a .sep property, abspath(), isabs(), mtime(), and
239         open_text_file_for_writing() to filesystem modules. Some of
240         these properties are not needed in this patch but will be needed
241         in subsequent patches (I'm doing this to avoid having to track
242         multiple versions of a single file).
243
244         Also, change most of the port/* modules to use the filesystem
245         objects instead of referencing the filesystem directly.
246
247         https://bugs.webkit.org/show_bug.cgi?id=52748
248
249         * Scripts/webkitpy/common/system/filesystem.py:
250         * Scripts/webkitpy/common/system/filesystem_mock.py:
251         * Scripts/webkitpy/layout_tests/port/__init__.py:
252         * Scripts/webkitpy/layout_tests/port/base.py:
253         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
254         * Scripts/webkitpy/layout_tests/port/chromium.py:
255         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
256         * Scripts/webkitpy/layout_tests/port/config.py:
257         * Scripts/webkitpy/layout_tests/port/test.py:
258         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
259
260 2011-01-19  Maciej Stachowiak  <mjs@apple.com>
261
262         Reviewed by Anders Carlsson.
263
264         If resetting between tests times out, treat it as a WebProcess crash
265         https://bugs.webkit.org/show_bug.cgi?id=52757
266
267         * WebKitTestRunner/TestController.cpp:
268         (WTR::TestController::runTest):
269
270 2011-01-19  Alexey Proskuryakov  <ap@apple.com>
271
272         Reviewed by Darin Adler.
273
274         https://bugs.webkit.org/show_bug.cgi?id=52739
275         Make it possible for a WebKit2 client to print headers and footers
276
277         Added dummy implementations for new printing UIClient calls.
278
279         * MiniBrowser/mac/BrowserWindowController.m:
280         (-[BrowserWindowController awakeFromNib]):
281         * WebKitTestRunner/TestController.cpp:
282         (WTR::createOtherPage):
283         (WTR::TestController::initialize):
284
285 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
286
287         Reviewed by Ojan Vafai.
288
289         Change webkitpy/layout_tests/port/test.py to use the
290         in-memory filesystem for cleaner unit testing. This
291         change allows us to kill a lot of code that was
292         specific to the test port, at the cost of being a
293         little less clear about how things would work if
294         you didn't have a filesystem.
295
296         https://bugs.webkit.org/show_bug.cgi?id=52605
297
298         * Scripts/webkitpy/layout_tests/port/test.py:
299
300 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
301
302         Unreviewed, build fix.
303
304         Fix test failure caused by committing attachment 79368 instead
305         of attachment 79461 on bug 52604.
306
307         * Scripts/webkitpy/common/system/filesystem_mock.py:
308
309 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
310
311         Reviewed by Mihai Parparita.
312
313         new-run-webkit-tests: remove use of os.walk, use mock filesystem for better
314         unit testing. os.walk() is too much of a hassle to implement on
315         top of the in-memory mock filesystem and adding the necessary
316         interface to files_under() gives clients a cleaner API anyway
317         (for this particular usage model).
318
319         https://bugs.webkit.org/show_bug.cgi?id=52691
320
321         * Scripts/webkitpy/common/system/filesystem.py:
322         * Scripts/webkitpy/common/system/filesystem_mock.py:
323         * Scripts/webkitpy/layout_tests/port/test_files.py:
324         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
325
326 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
327
328         Reviewed by Tony Chang.
329
330         Change more modules in the layout-tests code to use the
331         filesystem wrapper for cleaner unit testing.
332
333         This patch also adds the glob() wrapper to the filesystem
334         abstraction.
335         
336         https://bugs.webkit.org/show_bug.cgi?id=52604
337
338         * Scripts/webkitpy/layout_tests/port/test_files.py:
339         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
340         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
341         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
342         * Scripts/webkitpy/common/system/filesystem.py:
343         * Scripts/webkitpy/common/system/filesystem_mock.py:
344
345 2011-01-19  Levi Weintraub  <leviw@chromium.org>
346
347         Unreviewed.
348
349         Updating my email addresses and irc nick.
350
351         * Scripts/webkitpy/common/config/committers.py:
352
353 2011-01-19  Tony Chang  <tony@chromium.org>
354
355         Reviewed by Mihai Parparita.
356
357         [chromium] [linux] if check-sys-deps fails, output the failure reason
358         https://bugs.webkit.org/show_bug.cgi?id=52671
359
360         * Scripts/webkitpy/common/system/executive_mock.py: Add support for
361             error handler functions.
362         * Scripts/webkitpy/layout_tests/port/chromium.py:
363             output the error text from --check-sys-deps
364         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
365
366 2011-01-19  Aparna Nandyal  <aparna.nand@wipro.com>
367
368         Reviewed by Andreas Kling.
369
370         [Qt] QtTestBrowser crashes when closing if Facebook is opened
371         https://bugs.webkit.org/show_bug.cgi?id=52554
372         
373         QtNetworkAccessManager is created in a thread and set as
374         member variable in QWebPage. When the thread is destroyed
375         the object is still used. So fix will set the object to
376         NULL once the thread is destroyed.
377
378         * QtTestBrowser/launcherwindow.cpp:
379         (LauncherWindow::~LauncherWindow):
380
381 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
382
383         Rubber stamped by Csaba Osztrogonac
384
385         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: Removed unncessary inculde of WKStringCF.h
386
387 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
388
389         Reviewed by Tony Chang.
390
391         new-run-webkit-tests: add a --build-directory command line argument
392
393         Official Google Chrome builds use a non-standard build directory
394         location. This patch adds a --build-directory argument that
395         allows that location to be specified on the command line. Only
396         Chromium-based builds will use this flag for now, but anyone can
397         in the future.
398
399         There are no unit tests for this since it's difficult to test
400         until mock filesystems are fully supported in the code. This was
401         tested by hand for now.
402
403         https://bugs.webkit.org/show_bug.cgi?id=52694
404
405         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
406         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
407         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
408         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
409
410 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
411
412         Not reviewed. Bot fix.
413
414         Remove an inadvertently committed debugging print.
415
416         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
417         (LayoutTestController::notifyDone):
418
419 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
420
421         Reviewed by Sam Weinig.
422
423         WebKitTestRunner should track loading more like DumpRenderTree
424         https://bugs.webkit.org/show_bug.cgi?id=52692
425
426         Change load tracking to track the current top loading frame, in the manner of DumpRenderTree.
427         This makes some tests that call notifyDone multiple times pass.
428         
429         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
430         (WTR::InjectedBundle::InjectedBundle):
431         (WTR::InjectedBundle::done):
432         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
433         (WTR::InjectedBundle::topLoadingFrame):
434         (WTR::InjectedBundle::setTopLoadingFrame):
435         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
436         (WTR::InjectedBundlePage::InjectedBundlePage):
437         (WTR::InjectedBundlePage::stopLoading):
438         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
439         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
440         (WTR::InjectedBundlePage::didFinishLoadForFrame):
441         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
442         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
443         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
444         (WTR::LayoutTestController::notifyDone):
445         * WebKitTestRunner/TestController.cpp:
446         (WTR::TestController::didReceiveMessageFromInjectedBundle):
447
448 2011-01-18  Mihai Parparita  <mihaip@chromium.org>
449
450         Reviewed by Kent Tamura.
451
452         [Chromium] NRWT looking for DRT binary in the wrong path on Mac
453         https://bugs.webkit.org/show_bug.cgi?id=52678
454         
455         Update path now that WebKit is inside Source.
456
457         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
458
459 2011-01-18  Robert Hogan  <robert@webkit.org>
460
461         Reviewed by Simon Hausmann.
462
463         [Qt] http/tests/incremental/slow-utf8-text.pl fails
464         https://bugs.webkit.org/show_bug.cgi?id=44282
465
466         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
467         (WebCore::DumpRenderTree::dump):
468
469 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
470
471         Reviewed by Mihai Parparita.
472
473         Fix a small race condition that could cause the unit tests for
474         new-run-webkit-tests to fail in a multithreaded environment.
475         There was a small window in the code where one thread would
476         check to see if a thread had raised an exception, do something,
477         and then check to see if the thread was alive. If the other
478         thread raised an exception and exited in between these two
479         steps, the exception would be lost. Flipping the order of the
480         two checks fixes the race, since we will now always check for an
481         exception on the thread before exiting.
482
483         https://bugs.webkit.org/show_bug.cgi?id=51579
484
485         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
486
487 2011-01-18  Eric Seidel  <eric@webkit.org>
488
489         Reviewed by Adam Barth.
490
491         commit-queue dies when test archiving fails
492         https://bugs.webkit.org/show_bug.cgi?id=52617
493
494         I looked at the machine and it had 10 archives already
495         thus find_unused_name was returning None.  I've upped
496         the limit to 100 (per bug) and tested the case where
497         find_unused_name returns None (making archive return None).
498
499         * Scripts/webkitpy/common/system/workspace.py:
500         * Scripts/webkitpy/common/system/workspace_unittest.py:
501         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
502         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
503         * Scripts/webkitpy/tool/commands/queues.py:
504
505 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
506
507         Reviewed by Ojan Vafai.
508
509         Update rebaseline-chromium-webkit-tests unit tests to use a mock
510         filesystem. Also fix a couple of "with" statements missed by
511         r76050.
512
513         https://bugs.webkit.org/show_bug.cgi?id=52487
514
515         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
516
517 2011-01-18  Sergio Villar Senin  <svillar@igalia.com>
518
519         Reviewed by Martin Robinson.
520
521         [Gtk] Build fixes for gtk3 build
522         https://bugs.webkit.org/show_bug.cgi?id=52648
523
524         * DumpRenderTree/gtk/EventSender.cpp:
525         (beginDragWithFilesCallback):
526
527 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
528
529         Reviewed by Mihai Parparita.
530
531         Update rebaseline-chromium-webkit-tests to use filesystem objects
532         instead of direct references to os.path, shutil, tempfile, etc.
533
534         This patch doesn't change anything, but will allow subsequent
535         patches to change the unit tests to no longer use the real
536         filesystem.
537
538         This patch adds a bunch more methods to the filesystem object as
539         well.
540
541         https://bugs.webkit.org/show_bug.cgi?id=52482
542
543         * Scripts/webkitpy/common/system/filesystem.py:
544         * Scripts/webkitpy/common/system/filesystem_mock.py:
545         * Scripts/webkitpy/tool/commands/queues.py:
546         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
547         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
548
549 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
550
551         Reviewed by Mihai Parparita.
552
553         new-run-webkit-tests shouldn't crash when you try to run a
554         directory containing only skipped files.
555
556         https://bugs.webkit.org/show_bug.cgi?id=52478
557         
558         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
559         * Scripts/webkitpy/layout_tests/port/test.py:
560         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
561
562 2011-01-18  Adam Bergkvist  <adam.bergkvist@ericsson.com> and Martin Robinson  <mrobinson@igalia.com>
563
564         Reviewed by Gustavo Noronha Silva.
565
566         [GTK] The GTK+ EventSender needs support for beginDragWithFiles
567         https://bugs.webkit.org/show_bug.cgi?id=40833
568
569         * DumpRenderTree/gtk/EventSender.cpp: Add a beginDragWithFiles implementation for the
570         GTK+ event sender.
571         (dragWithFilesDragDataGetCallback): Added.
572         (dragWithFilesDragEndCallback): Added.
573         (beginDragWithFilesCallback): Added.
574
575 2011-01-18  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
576
577         Reviewed by Adam Barth.
578
579         ews: Add additional watcher to efl ews
580         https://bugs.webkit.org/show_bug.cgi?id=52613
581
582         Add gyuyoung.kim@samsung.com to watcher list of efl-ews.
583
584         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
585
586 2011-01-17  Tony Gentilcore  <tonyg@chromium.org>
587
588         Reviewed by Alexey Proskuryakov.
589
590         Fix some headers with missing or misspelled #ifndef guards
591         https://bugs.webkit.org/show_bug.cgi?id=52545
592
593         * DumpRenderTree/chromium/TestEventPrinter.h:
594         * DumpRenderTree/chromium/WebPreferences.h:
595
596 2011-01-17  Jessie Berlin  <jberlin@apple.com>
597
598         Reviewed by Anders Carlsson.
599
600         REGRESSION: Assertion failure in FrameLoader::continueLoadAfterWillSubmitForm() when
601         navigating back to an unreachable URL
602         https://bugs.webkit.org/show_bug.cgi?id=52388
603
604         Add a third parameter (unreachableURL) to queueLoadHTMLString.
605
606         * DumpRenderTree/LayoutTestController.cpp:
607         (queueLoadHTMLStringCallback):
608         (LayoutTestController::queueLoadHTMLString):
609         (LayoutTestController::queueLoadAlternateHTMLString):
610         * DumpRenderTree/LayoutTestController.h:
611
612         * DumpRenderTree/WorkQueueItem.h:
613         (LoadHTMLStringItem::LoadHTMLStringItem):
614
615         * DumpRenderTree/chromium/LayoutTestController.cpp:
616         (WorkItemLoadHTMLString::WorkItemLoadHTMLString):
617         (WorkItemLoadHTMLString::run):
618         (LayoutTestController::queueLoadHTMLString):
619
620         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
621         (LoadHTMLStringItem::invoke):
622         * DumpRenderTree/mac/WorkQueueItemMac.mm:
623         (LoadHTMLStringItem::invoke):
624         * DumpRenderTree/win/WorkQueueItemWin.cpp:
625         (LoadHTMLStringItem::invoke):
626
627 2011-01-17  Dan Bernstein  <mitz@apple.com>
628
629         Rubber-stamped by Mark Rowe.
630
631         Update xcodeproj svn:ignore to include xcuserdata.
632
633         * DumpRenderTree/DumpRenderTree.xcodeproj: Modified property svn:ignore.
634         * MiniBrowser/MiniBrowser.xcodeproj: Modified property svn:ignore.
635         * TestWebKitAPI/TestWebKitAPI.xcodeproj: Modified property svn:ignore.
636         * WebKitLauncher/WebKitLauncher.xcodeproj: Modified property svn:ignore.
637         * WebKitTestRunner/WebKitTestRunner.xcodeproj: Modified property svn:ignore.
638
639 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
640
641         Unreviewed fix after r75908.
642
643         Move WebKit into Source
644         https://bugs.webkit.org/show_bug.cgi?id=52530
645
646         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add Source to the path for Qt API tests.
647
648 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
649
650         Unreviewed.
651
652         Remove accidentally committed debug printing after r75908.
653
654         * Scripts/webkitdirs.pm:
655
656 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
657
658         Unreviewed.
659
660         Add myself to committers list
661         https://bugs.webkit.org/show_bug.cgi?id=52566
662
663         * Scripts/webkitpy/common/config/committers.py:
664
665 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
666
667         Reviewed by Jeremy Orlow.
668
669         GeolocationController should call stopUpdating on destruction
670         https://bugs.webkit.org/show_bug.cgi?id=52216
671
672         fast/dom/Geolocation/window-close-crash.html requires that a
673         Geolocation watch be started in a secondary window. Consequently,
674         we need to allow geolocation permission and provide a mock
675         geolocation position for the secondary window's
676         GeolocationClientMock.
677
678         * DumpRenderTree/chromium/LayoutTestController.cpp:
679         (LayoutTestController::setGeolocationPermission):
680         (LayoutTestController::setMockGeolocationPosition):
681         (LayoutTestController::setMockGeolocationError):
682         * DumpRenderTree/chromium/TestShell.h:
683         (TestShell::windowList):
684
685 2011-01-16  Adam Barth  <abarth@webkit.org>
686
687         Update more include paths to reflect WebKit move.
688
689         * DumpRenderTree/chromium/EventSender.cpp:
690         (EventSender::keyDown):
691         (EventSender::needsShiftModifier):
692         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
693         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
694
695 2011-01-16  Kent Tamura  <tkent@chromium.org>
696
697         Unreviewed, Chromium build fix.
698
699         * Scripts/update-webkit-chromium: Webkit/chromium -> Source/WebKit/chromium
700
701 2011-01-16  Martin Robinson  <mrobinson@igalia.com>
702
703         Build fix for GTK+ after source directory movement.
704
705         * GNUmakefile.am: Correct include paths.
706
707 2011-01-16  Adam Barth  <abarth@webkit.org>
708
709         Teach svn-apply about WebKit move.
710
711         * Scripts/VCSUtils.pm:
712
713 2011-01-16  Adam Barth  <abarth@webkit.org>
714
715         Rubber-stamped by Eric Seidel.
716
717         Move WebKit into Source
718         https://bugs.webkit.org/show_bug.cgi?id=52530
719
720         * DumpRenderTree/mac/InternalHeaders/WebKit/WebTypesInternal.h:
721         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
722         * DumpRenderTree/qt/DumpRenderTreeQt.h:
723         * DumpRenderTree/qt/GCControllerQt.cpp:
724         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
725         * DumpRenderTree/qt/PlainTextControllerQt.cpp:
726         * DumpRenderTree/qt/TextInputControllerQt.cpp:
727         * DumpRenderTree/wscript:
728         * QtTestBrowser/launcherwindow.h:
729         * Scripts/build-webkit:
730         * Scripts/webkitdirs.pm:
731
732 2011-01-15  Adam Barth  <abarth@webkit.org>
733
734         Teach svn-apply about WebKit2 move.
735
736         * Scripts/VCSUtils.pm:
737
738 2011-01-15  Adam Barth  <abarth@webkit.org>
739
740         Rubber-stamped by Eric Seidel.
741
742         Move WebKit2 into Source
743         https://bugs.webkit.org/show_bug.cgi?id=52438
744
745         * MiniBrowser/qt/MiniBrowser.pro:
746         * Scripts/build-webkit:
747         * Scripts/do-file-rename:
748         * Scripts/do-webcore-rename:
749         * Scripts/test-webkitpy:
750         * Scripts/webkitdirs.pm:
751         * Scripts/webkitpy/style/checker.py:
752         * WebKitTestRunner/DerivedSources.pro:
753         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
754         * WebKitTestRunner/qt/WebKitTestRunner.pro:
755
756 2011-01-15  Jochen Eisinger  <jochen@chromium.org>
757
758         Reviewed by David Levin.
759
760         [chromium] remove obsolete createView method
761         https://bugs.webkit.org/show_bug.cgi?id=52437
762
763         * DumpRenderTree/chromium/WebViewHost.cpp:
764         (WebViewHost::createView):
765         * DumpRenderTree/chromium/WebViewHost.h:
766
767 2011-01-14  Brian Weinstein  <bweinstein@apple.com>
768
769         Reviewed by Geoff Garen.
770
771         ShouldLoadResourceForFrame should use strings, not URLs.
772         https://bugs.webkit.org/show_bug.cgi?id=52476
773
774         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
775         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Update to use a WKStringRef.
776         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
777
778 2011-01-14  Tony Gentilcore  <tonyg@chromium.org>
779
780         Reviewed by David Levin.
781
782         Add Tony Gentilcore as a reviewer
783         https://bugs.webkit.org/show_bug.cgi?id=52480
784
785         * Scripts/webkitpy/common/config/committers.py:
786
787 2011-01-14  David Levin  <levin@chromium.org>
788
789         Reviewed by Eric Seidel.
790
791         check-webkit-style: _FunctionState should keep track of where the function name starts.
792         https://bugs.webkit.org/show_bug.cgi?id=52454
793
794         * Scripts/webkitpy/style/checkers/cpp.py: Added function_name_start_position to
795         _FunctionState and logic for setting it correctly.
796         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests.
797
798 2011-01-14  Vincent Scheib  <scheib@chromium.org>
799
800         Reviewed by David Levin.
801
802         Add support to DumpRenderTree to use the GPU rather than software renderer
803         https://bugs.webkit.org/show_bug.cgi?id=52333
804
805         * DumpRenderTree/chromium/DumpRenderTree.cpp:
806         (main):
807         * Scripts/webkitpy/layout_tests/port/chromium.py:
808         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
809
810 2011-01-14  Tony Chang  <tony@chromium.org>
811
812         Reviewed by Kent Tamura.
813
814         [chromium] update fonts.conf to fix 6 linux tests in drt
815         https://bugs.webkit.org/show_bug.cgi?id=52411
816
817         * DumpRenderTree/chromium/fonts.conf: Update to match the copy in
818             chromium's src/webkit/tools/test_shell/resources/fonts.conf
819
820 2011-01-14  Eric Seidel  <eric@webkit.org>
821
822         Original patch from Peter Gal  <galpater@inf.u-szeged.hu>
823
824         Reviewed by Adam Barth.
825
826         Fix when running Tools/Scripts/check-webkit-style without arguments.
827         https://bugs.webkit.org/show_bug.cgi?id=52261#c16
828
829         * Scripts/webkitpy/common/checkout/scm.py: Handle None for changed_files argument better in Git.create_patch method.
830         * Scripts/webkitpy/common/checkout/scm_unittest.py:
831
832 2011-01-04  Jochen Eisinger  <jochen@chromium.org>
833
834         Reviewed by David Levin.
835
836         Store the tempdir object in a variable so it doesn't get deleted too early.
837         https://bugs.webkit.org/show_bug.cgi?id=51875
838
839         * Scripts/update-webkit-auxiliary-libs:
840         * Scripts/update-webkit-support-libs:
841
842 2011-01-14  Eric Seidel  <eric@webkit.org>
843
844         Unreviewed.  Make it work in python 2.5.
845
846         webkit-patch suggest-reviewers dies when ChangeLogs are missing
847         https://bugs.webkit.org/show_bug.cgi?id=49158
848
849         * Scripts/webkitpy/common/checkout/api_unittest.py:
850
851 2011-01-14  Sheriff Bot  <webkit.review.bot@gmail.com>
852
853         Unreviewed, rolling out r75774.
854         http://trac.webkit.org/changeset/75774
855         https://bugs.webkit.org/show_bug.cgi?id=52431
856
857         gtk builds were broken (Requested by loislo2 on #webkit).
858
859         * Scripts/webkitpy/common/checkout/scm.py:
860
861 2011-01-14  David Levin  <levin@chromium.org>
862
863         Reviewed by Shinichiro Hamaji.
864
865         check-webkit-style: _FunctionState should detect pure functions.
866         https://bugs.webkit.org/show_bug.cgi?id=52428
867
868         * Scripts/webkitpy/style/checkers/cpp.py: Added detection for if a function declaration
869         is a pure virtual function.
870         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests for verifying that pure
871         virtual functions are correctly detected.
872
873 2011-01-13  Ilya Tikhonovsky  <loislo@chromium.org>
874
875         Reviewed by Yury Semikhatsky.
876
877         Just small fix for problem with check-webkit-style.
878         It just didn't work for this patch.
879         Old code can't concatenate a list of strings with None.
880
881         * Scripts/webkitpy/common/checkout/scm.py:
882
883 2011-01-13  David Levin  <levin@chromium.org>
884
885         Reviewed by Shinichiro Hamaji.
886
887         check-webkit-style: _FunctionState should use Position to know where items are.
888         https://bugs.webkit.org/show_bug.cgi?id=52424
889
890         * Scripts/webkitpy/style/checkers/cpp.py:
891         (_FunctionState.*): Changed _FunctionState to use Position instead of line numbers.
892         (detect_functions): Changed to pass Position's to _FunctionState.begin and
893         did some minor clean-up.
894         (*): Other changes are simply about converting to use the Position's in_FunctionState
895         instead of line numbers.
896         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Changed the test code
897         to verify the positions stored in _FunctionState.
898
899 2011-01-13  Eric Seidel  <eric@webkit.org>
900
901         Reviewed by David Levin.
902
903         webkit-patch suggest-reviewers dies when ChangeLogs are missing
904         https://bugs.webkit.org/show_bug.cgi?id=49158
905
906         This is not the most elegant, but it is a very safe fix to this bug.
907         One advantage of catching ScriptError like this instead of adding a
908         new added_or_modified_files or fixing all changed_files callers
909         to use a more specific change_files variant, is that we catch
910         all kinds of ScriptErrors which might cause our (non-essential)
911         suggest-reviewers code to fail out.  This should make passing
912         --suggest-reviewers to webkit-patch upload much more robust
913         and may even make it possible for us to make it default.
914
915         The root of the problem here is that SCM.changed_files includes
916         deleted ChangeLog paths (from moves, etc) which then when we ask
917         SVN/Git for the contents of the file at that revision, the command
918         errors out and Executive.run_command raises a ScriptError.
919
920         In the future we might fix this differently by making all current
921         callers of chagned_files use a more specific method for requesting
922         what types of changes they're interested in (adds, modifies, deletes, etc.)
923
924         * Scripts/webkitpy/common/checkout/api.py:
925         * Scripts/webkitpy/common/checkout/api_unittest.py:
926
927 2011-01-13  Dan Bernstein  <mitz@apple.com>
928
929         Reviewed by Alexey Proskuryakov.
930
931         <rdar://problem/8827065> REGRESSION (r71884): Cross-origin XHR fails if willSendRequest changes the URL
932         https://bugs.webkit.org/show_bug.cgi?id=52419
933
934         Allow to further control the behavior of the willSendRequest delegate callback by making it
935         set a different URL in the new request.
936
937         * DumpRenderTree/LayoutTestController.cpp:
938         (addURLToRedirectCallback): Added.
939         (LayoutTestController::staticFunctions): Added addURLToRedirect.
940         (LayoutTestController::addURLToRedirect): Added. Adds the redirection to the map.
941         (LayoutTestController::redirectionDestinationForURL): Added this getter.
942         * DumpRenderTree/LayoutTestController.h:
943         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
944         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]): Check
945         if there is a redirection for the request’s URL, established by addURLToRedirect(), and if so,
946         change the URL in the new request to the redirect destination.
947
948 2011-01-13  Eric Seidel  <eric@webkit.org>
949
950         Reviewed by Mihai Parparita.
951
952         webkit-patch suggest-reviewers fails due to invalid utf8 in ChangeLog files
953         https://bugs.webkit.org/show_bug.cgi?id=52416
954
955         Example: webkit-patch suggest-reviewers -g ca3890fe74d94d85d6bfa48f9ea497b094d8e717 
956         UnicodeDecodeError: 'utf8' codec can't decode bytes in position 536-538: invalid data
957
958         I also added FIXMEs about the changed_files returning deleted files problem
959         which is causing the other most common exception for suggest-reviewers
960         (and is probably breaking sheriff-bots blame detection).
961
962         * Scripts/webkitpy/common/checkout/api.py:
963         * Scripts/webkitpy/common/checkout/api_unittest.py:
964         * Scripts/webkitpy/common/checkout/scm.py:
965
966 2011-01-13  Eric Seidel  <eric@webkit.org>
967
968         Reviewed by Adam Barth.
969
970         results archives from commit-queue are too large to upload
971         https://bugs.webkit.org/show_bug.cgi?id=52405
972
973         * Scripts/webkitpy/common/system/filesystem.py:
974         * Scripts/webkitpy/common/system/filesystem_mock.py:
975         * Scripts/webkitpy/tool/commands/queues.py:
976
977 2011-01-13  Alejandro G. Castro  <alex@igalia.com>
978
979         Reviewed by Martin Robinson.
980
981         [gtk] Zero-sized font does not yet work
982         https://bugs.webkit.org/show_bug.cgi?id=49793
983
984         Set minimum-font-size to 0 for the DRT.
985
986         * DumpRenderTree/gtk/DumpRenderTree.cpp:
987         (resetDefaultsToConsistentValues):
988
989 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
990
991         Reviewed by Darin Adler.
992
993         Make old-run-webkit-tests more robust on buildbots
994         https://bugs.webkit.org/show_bug.cgi?id=52364
995
996         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Pass --exit-after-n-failures 500 to old-run-webkit-tests script.
997
998 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
999
1000         Reviewed by Darin Adler.
1001
1002         Make old-run-webkit-tests more robust on buildbots
1003         https://bugs.webkit.org/show_bug.cgi?id=52364
1004
1005         * Scripts/old-run-webkit-tests: Ensure that testResultsDirectory is empty.
1006
1007 2011-01-13  Tony Chang  <tony@chromium.org>
1008
1009         Reviewed by Kent Tamura.
1010
1011         [chromium] fix plugins/plugin-javascript-access.html on Linux and Mac
1012         https://bugs.webkit.org/show_bug.cgi?id=52332
1013
1014         Forked Info.plist is not longer needed.
1015
1016         * DumpRenderTree/chromium/TestNetscapePlugIn/Info.plist: Removed.
1017
1018 2011-01-13  Mikhail Naganov  <mnaganov@chromium.org>
1019
1020         Reviewed by Timothy Hatcher.
1021
1022         Web Inspector: Cleanup after r75613 -- make all UI-facing strings
1023         to be passed directly to WebInspector.UIString
1024
1025         https://bugs.webkit.org/show_bug.cgi?id=52365
1026
1027         * Scripts/check-inspector-strings:
1028
1029 2011-01-13  Sheriff Bot  <webkit.review.bot@gmail.com>
1030
1031         Unreviewed, rolling out r74881.
1032         http://trac.webkit.org/changeset/74881
1033         https://bugs.webkit.org/show_bug.cgi?id=52357
1034
1035         The EFL builder has been red for days (Requested by abarth on
1036         #webkit).
1037
1038         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1039         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1040
1041 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
1042
1043         Reviewed by David Levin.
1044
1045         Add beforeunload support to WebKitTestRunner
1046         https://bugs.webkit.org/show_bug.cgi?id=52353
1047         
1048         This makes a number of currently failing tests pass.
1049
1050         * WebKitTestRunner/TestController.cpp:
1051         (WTR::runBeforeUnloadConfirmPanel):
1052         (WTR::createOtherPage):
1053         (WTR::TestController::initialize):
1054
1055 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
1056
1057         Reviewed by Sam Weinig.
1058
1059         Detect, identify and recover from WebProcess crashes in run-webkit-tests
1060         https://bugs.webkit.org/show_bug.cgi?id=52330
1061
1062         * Scripts/old-run-webkit-tests: Detect when the regression test tool reports
1063         a web process crash.
1064         * WebKitTestRunner/TestController.cpp:
1065         (WTR::TestController::initialize): Set up a processDidCrash
1066         callback.
1067         (WTR::TestController::processDidCrash): Report that the Web process
1068         crashed.
1069         * WebKitTestRunner/TestController.h:
1070
1071 2011-01-12  David Levin  <levin@chromium.org>
1072
1073         Reviewed by Shinichiro Hamaji.
1074
1075         check-webkit-style -- close_expression function doesn't work correctly.
1076         https://bugs.webkit.org/show_bug.cgi?id=52272
1077
1078         * Scripts/webkitpy/style/checkers/cpp.py:
1079         (Position.__str__): Added a way to convert it to a string which is useful in tests.
1080         (Position.__cmp__): Added a way to compare Position which is useful in tests and
1081         generally useful (for upcoming code changes).
1082         (close_expression): Changed to use Position for input and output.
1083         Also, fixed many bugs such as only working correctly for parenthesis,
1084         not working correctly if given an offset in a line and not finding
1085         the real closing element if there were multiple closing elements in
1086         the same line.
1087         (detect_functions): Adjusted due to the change in arguments for
1088         close_expression.
1089         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1090         (CppStyleTestBase.assert_positions_equal): Added a way to verify that
1091         two positions are the same.
1092         (CppStyleTest.test_position): Added tests for the __str_ and __cmp__ methods.
1093         (CppStyleTest.test_close_expression): Added tests to catch the issues
1094         that were fixed.
1095
1096 2011-01-12  Sheriff Bot  <webkit.review.bot@gmail.com>
1097
1098         Unreviewed, rolling out r75576.
1099         http://trac.webkit.org/changeset/75576
1100         https://bugs.webkit.org/show_bug.cgi?id=52304
1101
1102         broke rebaseline-chromium-webkit-test (Requested by thakis on
1103         #webkit).
1104
1105         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1106         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1107         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
1108         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1109         * Scripts/webkitpy/layout_tests/port/base.py:
1110         * Scripts/webkitpy/layout_tests/port/chromium.py:
1111         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1112         * Scripts/webkitpy/layout_tests/port/test.py:
1113         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1114         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1115         * Scripts/webkitpy/style/checkers/test_expectations.py:
1116         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1117
1118 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
1119
1120         Reviewed by Darin Adler.
1121
1122         Add a no-build option to run-webkit-tests, to avoid building DRT/WKTR
1123         https://bugs.webkit.org/show_bug.cgi?id=52307
1124
1125         * Scripts/old-run-webkit-tests:
1126
1127 2011-01-12  Koan-Sin Tan  <koansin.tan@gmail.com>
1128
1129         Reviewed by Martin Robinson.
1130
1131         [Gtk] WebKitGtk+ doesn't build on Mac OS X 10.6
1132         https://bugs.webkit.org/show_bug.cgi?id=50867
1133
1134         Fixed library extention for Mac in webkitdirs.pm and type conflict in
1135         TestNetscapePlugin.cpp 
1136
1137         * GNUmakefile.am: Don't use AppKit when compiling TestNetscapePlugin for GTK+
1138         * Scripts/webkitdirs.pm:
1139
1140 2011-01-12  Mikhail Naganov  <mnaganov@chromium.org>
1141
1142         Reviewed by Pavel Feldman.
1143
1144         Add check-inspector-strings script.
1145
1146         https://bugs.webkit.org/show_bug.cgi?id=52295
1147
1148         * Scripts/check-inspector-strings: Added.
1149
1150 2011-01-12  Adam Roben  <aroben@apple.com>
1151
1152         Advertise the .testnetscape file extension on Windows
1153
1154         Fixes <http://webkit.org/b/52298>
1155         plugins/no-mime-with-valid-extension.html fails on Windows
1156
1157         Reviewed by Dan Bernstein.
1158
1159         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Added a
1160         FileExtents field to map the .testnetscape file extension to the
1161         application/x-webkit-test-netscape MIME type, just as we do on Mac.
1162
1163 2011-01-12  Adam Barth  <abarth@webkit.org>
1164
1165         Reviewed by Eric Seidel.
1166
1167         Make webkit-patch support subdirectories for SVN checkouts
1168         https://bugs.webkit.org/show_bug.cgi?id=52261
1169
1170         os.relpath does not exist on Python 2.5, so we need to call our version
1171         of the API.
1172
1173         * Scripts/webkitpy/common/checkout/scm.py:
1174
1175 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
1176
1177         Reviewed by Eric Seidel.
1178
1179         Close additional pages opened during a test once the test completes.
1180         https://bugs.webkit.org/show_bug.cgi?id=52276
1181
1182         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1183         (WTR::InjectedBundle::done):
1184
1185 2011-01-11  David Levin  <levin@chromium.org>
1186
1187         Reviewed by Eric Seidel.
1188
1189         Errors should be separated from the command line in bot messages.
1190         https://bugs.webkit.org/show_bug.cgi?id=52275
1191
1192         * Scripts/webkitpy/common/system/executive.py:
1193         (ScriptError.message_with_output): Added a newline to separate the command
1194         line from the errors.
1195         * Scripts/webkitpy/common/system/executive_unittest.py:
1196         (ScriptErrorTest.test_message_with_output): Added tests for the various code
1197         paths in message_with_output.
1198
1199 2011-01-11  Eric Seidel  <eric@webkit.org>
1200
1201         Unreviewed.
1202
1203         commit-queue should know how to upload archived results (for test flakes or general failures)
1204         https://bugs.webkit.org/show_bug.cgi?id=52048
1205
1206         The zips are mostly empty due to forgetting -r.
1207         Expected diffs were not being pulled from the archive due
1208         to the archive having longer paths than I realized.
1209
1210         * Scripts/webkitpy/common/system/workspace.py:
1211         * Scripts/webkitpy/common/system/workspace_unittest.py:
1212         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1213         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1214
1215 2011-01-11  Dirk Pranke  <dpranke@chromium.org>
1216
1217         Reviewed by Ojan Vafai.
1218
1219         The current modifier parsing code in test_expectations is
1220         fragile and hard-coded, so it's not easy to understand the logic
1221         or easily add new types of modifiers (like GPU vs. CPU testing
1222         for graphics tests, or 32-bit vs. 64-bit differences).
1223
1224         This is the first of two patches that will add in more generic
1225         support and then eliminate the GPU-specific test expectations
1226         files for Chromium.
1227
1228         This patch adds two standalone objects for handling modifiers. The
1229         rules for interpreting modifiers, precedence, and conflicts are
1230         given in the docstring to the ModifierMatcher class, which
1231         returns ModifierMatchResult objects.
1232         
1233         This patch also adds routines to the Port interface and a
1234         default set of values in the base object, in order to obtain the
1235         values needed on a given test run. These values are then passed
1236         to the expectation parser. This also allows us to clean up the
1237         logic used to lint all of the different configurations in a
1238         single test_expectations.txt file.
1239
1240         The next patch will merge in the separate GPU expectations file.
1241
1242         https://bugs.webkit.org/show_bug.cgi?id=51222
1243
1244         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1245         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1246         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
1247         * Scripts/webkitpy/layout_tests/port/base.py:
1248         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1249         * Scripts/webkitpy/layout_tests/port/chromium.py:
1250         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1251         * Scripts/webkitpy/layout_tests/port/test.py:
1252         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1253         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1254
1255 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
1256
1257         Reviewed by Adam Barth.
1258
1259         Make webkit-patch support subdirectories for SVN checkouts
1260         https://bugs.webkit.org/show_bug.cgi?id=52261
1261
1262         * Scripts/webkitpy/common/checkout/scm.py:
1263         * Scripts/webkitpy/style_references.py:
1264         * Scripts/webkitpy/tool/main.py:
1265         * Scripts/webkitpy/tool/steps/preparechangelog.py:
1266
1267 2011-01-11  Eric Seidel  <eric@webkit.org>
1268
1269         Unreviewed.
1270
1271         commit-queue should know how to upload archived results (for test flakes or general failures)
1272         https://bugs.webkit.org/show_bug.cgi?id=52048
1273
1274         I changed the API for archive_last_layout_test_results w/o updating the implementation.  Oops.
1275         This fixes an exception seen on the commit-queue when attempting to report flaky tests.
1276
1277         * Scripts/webkitpy/common/system/workspace.py:
1278         * Scripts/webkitpy/common/system/workspace_unittest.py:
1279         * Scripts/webkitpy/tool/commands/queues.py:
1280
1281 2011-01-11  Sam Weinig  <sam@webkit.org>
1282
1283         Roll r75474 back in.
1284
1285 2011-01-11  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
1286
1287         Reviewed by Kenneth Rohde Christiansen.
1288
1289         [Qt] Remove uses of QFuture since it isn't supported on all platforms.
1290         https://bugs.webkit.org/show_bug.cgi?id=51204
1291
1292         * QtTestBrowser/webpage.h:
1293         (QtNAMThread::QtNAMThread):
1294         (QtNAMThread::networkAccessManager):
1295         (QtNAMThread::run):
1296
1297 2011-01-11  Peter Varga  <pvarga@webkit.org>
1298
1299         Unreviewed.
1300
1301         Add myself to committers' list.
1302
1303         * Scripts/webkitpy/common/config/committers.py:
1304
1305 2011-01-11  Eric Seidel  <eric@webkit.org>
1306
1307         Reviewed by Adam Barth.
1308
1309         commit-queue should know how to upload archived results (for test flakes or general failures)
1310         https://bugs.webkit.org/show_bug.cgi?id=52048
1311
1312         Now the queue will always upload results.  Either the entire zip, or just
1313         the diffs.txt in the case of text failures.
1314
1315         This should make understanding flakes much easier, and paves the way
1316         for having the EWS run layout tests (and upload failures).
1317
1318         In order to upload .zip files I had to teach bugzilla.py to autodetect
1319         mime types from the filename.  Since mimetypes.py doesn't include a mapping
1320         for .patch files, I have it add one before calling guess_type.
1321
1322         We may find that always uploading the whole zip instead of just the -diffs.txt
1323         file is preferable, but for now I'm keeping the old behavior because it makes
1324         quickly understanding text failures easy.
1325
1326         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1327         * Scripts/webkitpy/common/system/workspace.py: Added.
1328         * Scripts/webkitpy/common/system/workspace_unittest.py: Added.
1329         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1330         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1331         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1332         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1333         * Scripts/webkitpy/tool/commands/queues.py:
1334         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1335
1336 2011-01-10  Sheriff Bot  <webkit.review.bot@gmail.com>
1337
1338         Unreviewed, rolling out r75464.
1339         http://trac.webkit.org/changeset/75464
1340         https://bugs.webkit.org/show_bug.cgi?id=52193
1341
1342         Followup rollout for 75474 (Requested by Ossy on #webkit).
1343
1344         * MiniBrowser/mac/BrowserWindowController.m:
1345         (-[BrowserWindowController awakeFromNib]):
1346         * MiniBrowser/win/BrowserView.cpp:
1347         (BrowserView::create):
1348         * WebKitTestRunner/TestController.cpp:
1349         (WTR::createOtherPage):
1350         (WTR::TestController::initialize):
1351
1352 2011-01-10  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1353
1354         Reviewed by Csaba Osztrogonác.
1355
1356         [Qt] Baseline qt_minimal configuration
1357         https://bugs.webkit.org/show_bug.cgi?id=51313
1358
1359         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1360         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): Add
1361         QT_NO_UNDOSTACK guard.
1362
1363         * QtTestBrowser/launcherwindow.cpp:
1364         (LauncherWindow::createChrome): Add QT_NO_SHORTCUT and QT_NO_PRINTER
1365         guards.
1366         (LauncherWindow::applyZoom): Add QT_NO_ANIMATION guard.
1367         (LauncherWindow::screenshot): Add QT_NO_FILEDIALOG guard.
1368         (LauncherWindow::selectElements): Add QT_NO_INPUTDIALOG guard.
1369         (LauncherWindow::showUserAgentDialog): Add QT_NO_COMBOBOX guard.
1370
1371         * QtTestBrowser/launcherwindow.h:
1372         * QtTestBrowser/locationedit.cpp: Add QT_NO_INPUTDIALOG guard.
1373         * QtTestBrowser/locationedit.h: Ditto.
1374
1375         * QtTestBrowser/mainwindow.cpp:
1376         (MainWindow::buildUI): Add QT_NO_INPUTDIALOG, QT_NO_SHORTCUT and
1377         QT_NO_UNDOSTACK guards.
1378         (MainWindow::setAddressUrl): Add QT_NO_INPUTDIALOG guard.
1379         (MainWindow::changeLocation): Ditto.
1380         (MainWindow::openFile): Add QT_NO_FILEDIALOG guard.
1381         (MainWindow::openLocation): Add QT_NO_INPUTDIALOG guard.
1382
1383         * QtTestBrowser/webpage.cpp:
1384         (WebPage::openUrlInDefaultBrowser): Add QT_NO_DESKTOPSERVICES guard.
1385         (WebPage::authenticationRequired): Add QT_NO_LINEEDIT guard.
1386
1387         * QtTestBrowser/webview.cpp:
1388         (WebViewGraphicsBased::animatedFlip): Add QT_NO_ANIMATION guard.
1389         (WebViewGraphicsBased::animatedYFlip): Ditto.
1390
1391 2011-01-10  Sam Weinig  <sam@webkit.org>
1392
1393         Fix build.
1394
1395         * MiniBrowser/mac/BrowserWindowController.m:
1396         (-[BrowserWindowController awakeFromNib]):
1397         * MiniBrowser/win/BrowserView.cpp:
1398         (BrowserView::create):
1399         * WebKitTestRunner/TestController.cpp:
1400         (WTR::createOtherPage):
1401         (WTR::TestController::initialize):
1402
1403 2011-01-10  Eric Seidel  <eric@webkit.org>
1404
1405         Reviewed by Ojan Vafai.
1406
1407         style-queue messages are way too long for big patches
1408         https://bugs.webkit.org/show_bug.cgi?id=52161
1409
1410         We definitely could build much fancier list-to-string-with-limit functions
1411         but this should be sufficient for our needs at the moment.
1412
1413         * Scripts/webkitpy/common/system/executive.py:
1414         * Scripts/webkitpy/common/system/executive_unittest.py:
1415
1416 2011-01-10  Tony Chang  <tony@chromium.org>
1417
1418         Unreviewed, rolling out r75398.
1419         http://trac.webkit.org/changeset/75398
1420         https://bugs.webkit.org/show_bug.cgi?id=52008
1421
1422         Some layout tests are crashing on Chromium Win.
1423
1424         * DumpRenderTree/chromium/WebViewHost.cpp:
1425         (WebViewHost::updatePaintRect):
1426         * DumpRenderTree/chromium/WebViewHost.h:
1427
1428 2011-01-10  Adam Roben  <aroben@apple.com>
1429
1430         Roll out r75392
1431
1432         It isn't needed now that r75289 has been rolled out.
1433
1434         * Scripts/run-javascriptcore-tests:
1435
1436 2011-01-10  Maciej Stachowiak  <mjs@apple.com>
1437
1438         Reviewed by Anders Carlsson.
1439
1440         WebKitTestRunner uses crazy amounts of CPU, making layout tests slow and flaky
1441         https://bugs.webkit.org/show_bug.cgi?id=52160
1442
1443         * WebKitTestRunner/mac/TestControllerMac.mm:
1444         (WTR::TestController::platformRunUntil): Instead of busy-looping, wait for the timeout.
1445         Anything that can make runUntil() conditions turn true will happen on a run loop cycle
1446         anyway.
1447
1448 2011-01-10  Tony Chang  <tony@chromium.org>
1449
1450         Reviewed by Mihai Parparita.
1451
1452         [chromium] fix for animated gif layout tests
1453         https://bugs.webkit.org/show_bug.cgi?id=52008
1454
1455         * DumpRenderTree/chromium/WebViewHost.cpp: Schedule a paint when we update the paint rect
1456             to trigger gif animations.
1457         (WebViewHostPaintTask::WebViewHostPaintTask):
1458         (WebViewHostPaintTask::runIfValid):
1459         (WebViewHost::updatePaintRect):
1460         * DumpRenderTree/chromium/WebViewHost.h:
1461         (WebViewHost::taskList):
1462
1463 2011-01-10  Alejandro G. Castro  <alex@igalia.com>
1464
1465         Reviewed by Xan Lopez.
1466
1467         [GTK] Fix gtk2 compilation for master
1468         https://bugs.webkit.org/show_bug.cgi?id=51885
1469
1470         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
1471         (createBitmapContextFromWebView): Replaced the old
1472         gdk_drawable_get_size with gdk_pixmap_get_size.
1473
1474 2011-01-10  Patrick Gansterer  <paroga@webkit.org>
1475
1476         Reviewed by Laszlo Gombos.
1477
1478         [WINCE] Reenable NPAPI after r75203
1479         https://bugs.webkit.org/show_bug.cgi?id=52109
1480
1481         Remove the !isWinCE() check for ENABLE_NETSCAPE_PLUGIN_API and replace
1482         it with !isEfl(), because EFL port does not support NPAPI (yet).
1483
1484         * Scripts/build-webkit:
1485
1486 2011-01-10  Adam Roben  <aroben@apple.com>
1487
1488         Skip some asserting JS tests
1489
1490         See <http://webkit.org/b/52156>.
1491
1492         * Scripts/run-javascriptcore-tests:
1493
1494 2011-01-10  Martin Robinson  <mrobinson@igalia.com>
1495
1496         Reviewed by Xan Lopez.
1497
1498         [GTK] build-webkit disable Blob support via arguments passed to automake
1499         https://bugs.webkit.org/show_bug.cgi?id=52097
1500
1501         * Scripts/build-webkit: Enable Blob support when building WebKitGTK+ via
1502         build-webkit.
1503
1504 2011-01-10  Adam Roben  <aroben@apple.com>
1505
1506         Use the same name and description for TestNetscapePlugin on Windows and
1507         Mac
1508
1509         Fixes <http://webkit.org/b/52151>
1510         fast/frames/iframe-reparenting-plugins.html fails on Windows
1511
1512         Reviewed by Steve Falkenburg.
1513
1514         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Copied
1515         the name and description from Mac's Info.plist.
1516
1517 2011-01-10  Siddharth Mathur <siddharth.mathur@nokia.com>
1518
1519         Reviewed by Laszlo Gombos.
1520
1521         [Qt][WK2] Guard gcc-specific syntax
1522
1523         Non-gcc based compliers choke on the "-include"
1524         syntax for preinclude, place guard around it.
1525
1526         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1527         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1528
1529 2011-01-10  Andreas Kling  <kling@webkit.org>
1530
1531         Reviewed by Simon Hausmann.
1532
1533         [Qt] [WK2] MiniBrowser does not load pages opened in new windows
1534         https://bugs.webkit.org/show_bug.cgi?id=52111
1535
1536         When getting a createNewPage() callback from QWKPage, create the
1537         new page with the same QWKContext as the page that is passed to
1538         the callback.
1539
1540         * MiniBrowser/qt/BrowserView.h:
1541         * MiniBrowser/qt/BrowserWindow.cpp:
1542         (newPageFunction):
1543         (BrowserWindow::BrowserWindow):
1544         * MiniBrowser/qt/BrowserWindow.h:
1545
1546 2011-01-10  Andreas Kling  <kling@webkit.org>
1547
1548         Reviewed by Kenneth Rohde Christiansen.
1549
1550         [Qt] MiniBrowser: Remove superfluous createNewPage() callback
1551
1552         BrowserView set its own useless createNewPage() callback on QWKPage.
1553         This was immediately overridden by BrowserWindow anyway, so remove
1554         the BrowserView one.
1555
1556         * MiniBrowser/qt/BrowserView.cpp:
1557         (BrowserView::BrowserView):
1558
1559 2011-01-10  John Knottenbelt  <jknotten@chromium.org>
1560
1561         Reviewed by Jeremy Orlow.
1562
1563         [Chromium] Remove non-client-based Geolocation code
1564         https://bugs.webkit.org/show_bug.cgi?id=50921
1565
1566         * DumpRenderTree/chromium/LayoutTestController.cpp:
1567         (LayoutTestController::setGeolocationPermission):
1568         (LayoutTestController::setMockGeolocationPosition):
1569         (LayoutTestController::setMockGeolocationError):
1570         * DumpRenderTree/chromium/WebViewHost.cpp:
1571         (WebViewHost::geolocationClientMock):
1572         (WebViewHost::reset):
1573         * DumpRenderTree/chromium/WebViewHost.h:
1574
1575 2011-01-10  Eric Seidel  <eric@webkit.org>
1576
1577         Reviewed by Adam Barth.
1578
1579         Commit bot tried to land r? cq+ patch
1580         https://bugs.webkit.org/show_bug.cgi?id=36638
1581
1582         It should now be possible to post a patch with r? and cq+ and the
1583         commit-queue will correctly wait for the r+ before attempting to land the patch.
1584         (This was a feature requested by several users.)
1585
1586         One caveat: We don't actually reject r-, cq+ patches from the queue
1587         (we just ignore them), but I think that's OK for now.
1588
1589         I also noticed that setting r- once a commit-queue node had grabbed
1590         a patch would not properly cancel the landing.  That's fixed and
1591         tested in this patch.
1592
1593         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1594         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1595         * Scripts/webkitpy/tool/bot/feeders.py:
1596         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
1597
1598 2011-01-08  Benjamin Poulain  <benjamin.poulain@nokia.com>
1599
1600         Reviewed by Kenneth Rohde Christiansen.
1601
1602         [Qt] QtWebKit crashes when using XMLHttpRequest from the unload event
1603         https://bugs.webkit.org/show_bug.cgi?id=51934
1604
1605         When accessing the network from the destructor of QWebPage, the network access manager
1606         was already deleted because the object WebPage was already destructed.
1607
1608         This solve the problem by linking the lifetime of the network access manager to WebPage's QObject.
1609         The object is now destructed in the destructor of QObject.
1610
1611         * QtTestBrowser/webpage.cpp:
1612         (WebPage::WebPage):
1613         (WebPage::setQnamThreaded):
1614         * QtTestBrowser/webpage.h:
1615         (QtNAMThread::QtNAMThread):
1616
1617 2011-01-08  Eric Seidel  <eric@webkit.org>
1618
1619         Reviewed by Ojan Vafai.
1620
1621         test_failures.py should not mention TestShell (long live DumpRenderTree!)
1622         https://bugs.webkit.org/show_bug.cgi?id=52067
1623
1624         I ran test-webkitpy, but didn't bother adding a unit test for this string change.
1625         https://bugs.webkit.org/show_bug.cgi?id=51138#c3 is an example of why this is needed.
1626
1627         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1628
1629 2011-01-08  Eric Seidel  <eric@webkit.org>
1630
1631         Reviewed by Mihai Parparita.
1632
1633         commit-queue hangs when the ChangeLog diff is bad
1634         https://bugs.webkit.org/show_bug.cgi?id=52072
1635
1636         * Scripts/webkitpy/tool/steps/validatechangelogs.py:
1637         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
1638
1639 2011-01-08  Adam Barth  <abarth@webkit.org>
1640
1641         Teach svn-apply how to re-write WebCore to Source/WebCore.
1642
1643         * Scripts/VCSUtils.pm:
1644
1645 2011-01-07  Adam Barth  <abarth@webkit.org>
1646
1647         Rubber-stamped by Eric Seidel.
1648
1649         Move WebCore to Source
1650         https://bugs.webkit.org/show_bug.cgi?id=52050
1651
1652         Update the tools to understand WebCore's new location.
1653
1654         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1655         * DumpRenderTree/wscript:
1656         * GNUmakefile.am:
1657         * Scripts/build-webkit:
1658         * Scripts/do-file-rename:
1659         * Scripts/do-webcore-rename:
1660         * Scripts/generate-qt-inspector-resource:
1661         * Scripts/prepare-ChangeLog:
1662         * Scripts/run-bindings-tests:
1663         * Scripts/update-iexploder-cssproperties:
1664         * Scripts/update-sources-list.py:
1665         * Scripts/update-webkit-localizable-strings:
1666         * Scripts/webkitdirs.pm:
1667         * Scripts/webkitpy/common/config/build.py:
1668         * Scripts/webkitpy/common/config/build_unittest.py:
1669         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
1670         * Scripts/webkitpy/style/checker.py:
1671         * Scripts/webkitpy/style/checker_unittest.py:
1672         * WebKitTestRunner/DerivedSources.pro:
1673         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1674         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh:
1675         * wx/browser/wscript:
1676         * wx/build/settings.py:
1677
1678 2011-01-07  Maciej Stachowiak  <mjs@apple.com>
1679
1680         Reviewed by Sam Weinig.
1681
1682         Make WebKitTestRunner rest between loads more robust to avoid test crashes
1683         https://bugs.webkit.org/show_bug.cgi?id=52086
1684
1685         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1686         (WTR::InjectedBundle::didReceiveMessage):
1687         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1688         (WTR::LayoutTestController::notifyDone):
1689         * WebKitTestRunner/TestController.cpp:
1690         (WTR::TestController::resetStateToConsistentValues):
1691         (WTR::TestController::run):
1692
1693 2011-01-07  James Robinson  <jamesr@chromium.org>
1694
1695         Revert "Implement mozilla's animationTime property"
1696         https://bugs.webkit.org/show_bug.cgi?id=51952
1697
1698         This approach isn't quite right.
1699
1700         * DumpRenderTree/chromium/WebViewHost.cpp:
1701         (WebViewHost::paintInvalidatedRegion):
1702
1703 2011-01-07  Adam Roben  <aroben@apple.com>
1704
1705         Build master fix
1706
1707         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1708         (RunWebKitTests.start): Don't try to concatenate a list and a string.
1709
1710 2011-01-07  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>
1711
1712         Reviewed by Csaba Osztrogonác.
1713
1714         run-qtwebkit-tests should be able to kill a testsuite.
1715
1716         Add new option in the script that can setup a timeout for a test.
1717         If the test execution takes more then specified time then the test
1718         would be terminated.
1719
1720         [Qt] run-qtwebkit-tests needs timeout
1721         https://bugs.webkit.org/show_bug.cgi?id=51894
1722
1723         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1724         * Scripts/run-qtwebkit-tests:
1725
1726 2011-01-07  Csaba Osztrogonác  <ossy@webkit.org>
1727
1728         Unreviewed fix after r75233.
1729
1730         Based on idea from Eric Seidel.
1731
1732         Add remote zip file handling to webkitpy.
1733         https://bugs.webkit.org/show_bug.cgi?id=50901
1734
1735         * Scripts/webkitpy/common/system/fileset.py: Make python 2.5 happy.
1736
1737 2011-01-07  Shane Stephens  <shanestephens@google.com>
1738
1739         Reviewed by Eric Seidel.
1740
1741         svn-apply: should support git binary delta diffs
1742         https://bugs.webkit.org/show_bug.cgi?id=38864
1743
1744         * Scripts/VCSUtils.pm:
1745         * Scripts/svn-apply:
1746
1747 2011-01-06  Julie Parent  <jparent@chromium.org>
1748
1749         Reviewed by Eric Seidel.
1750
1751         Test Result Server not removing old results.
1752         https://bugs.webkit.org/show_bug.cgi?id=52012
1753
1754         * TestResultServer/model/jsonresults.py:
1755         Fix off-by-one: Truncate if >= num_runs, not just >.
1756         * TestResultServer/model/jsonresults_unittest.py:
1757         Add unit test to test that merging in a new result with the same value
1758         as the last result causes previous result to fall off.
1759
1760 2011-01-06  James Kozianski  <koz@chromium.org>
1761
1762         Reviewed by Mihai Parparita.
1763
1764         Add classes to provide a consistent interface to a set of files.
1765         https://bugs.webkit.org/show_bug.cgi?id=50901
1766
1767         These classes allow us to write code that is agnostic to whether a
1768         particular set of files resides in a local directory or in a zip file
1769         on a remote machine.
1770
1771         * Scripts/webkitpy/common/system/directoryfileset.py: Added.
1772         * Scripts/webkitpy/common/system/directoryfileset_unittest.py: Added.
1773         * Scripts/webkitpy/common/system/fileset.py: Added.
1774         * Scripts/webkitpy/common/system/filesystem.py:
1775         * Scripts/webkitpy/common/system/filesystem_mock.py:
1776         * Scripts/webkitpy/common/system/zipfileset.py: Added.
1777         * Scripts/webkitpy/common/system/zipfileset_unittest.py: Added.
1778
1779 2011-01-06  Eric Seidel  <eric@webkit.org>
1780
1781         Reviewed by Adam Barth.
1782
1783         NetworkTransaction should log the url it is retrying
1784         https://bugs.webkit.org/show_bug.cgi?id=52043
1785
1786         * Scripts/webkitpy/common/net/networktransaction.py:
1787         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
1788
1789 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
1790
1791         Windows build fix.
1792         Import os before using it.
1793
1794         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1795
1796 2011-01-06  Eric Seidel  <eric@webkit.org>
1797
1798         Reviewed by Adam Barth.
1799
1800         StyleQueue fails to report errors when patches have many files
1801         https://bugs.webkit.org/show_bug.cgi?id=52042
1802
1803         This is one of at least two errors preventing style error reporting at the moment.
1804         When we moved to passing the list of files to check explicitly,
1805         we started to exceed the 500 character TEXT field limit for our AppEngine model object.
1806         We could change the type of the QueueStatus.message type, or we could
1807         just teach statusserver.py how to clamp values (and warn when it does).
1808         I chose the latter path.
1809
1810         * Scripts/webkitpy/common/net/statusserver.py:
1811
1812 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
1813
1814         Reviewed by Stephanie Lewis.
1815         
1816         Fix syntax error in script.
1817
1818         Windows bots need to archive/unarchive builds to/from configuration-specific directories
1819         https://bugs.webkit.org/show_bug.cgi?id=51996
1820
1821         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1822
1823 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1824
1825         Unreviewed, fixing WinCE build after r75196.
1826
1827         WinCE port does not (yet) support NPAPI.
1828
1829         * Scripts/build-webkit:
1830
1831 2011-01-06  Xan Lopez  <xlopez@igalia.com>
1832
1833         Reviewed by Darin Adler.
1834
1835         File::Spec->rel2abs in sunspider-compare-results mangles parameters
1836         https://bugs.webkit.org/show_bug.cgi?id=52015
1837
1838         * Scripts/sunspider-compare-results: call rel2abs on our arguments
1839         after the platform has been detected, otherwise the script will
1840         mangle things like '--gtk' into '/a/path/--gtk', breaking the
1841         detection.
1842
1843 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1844
1845         Reviewed by Eric Seidel.
1846
1847         Add ENABLE_NETSCAPE_PLUGIN_API, ENABLE_ORIENTATION_EVENTS and ENABLE_TOUCH_EVENTS flags to build-webkit
1848         https://bugs.webkit.org/show_bug.cgi?id=51346
1849
1850         * Scripts/build-webkit:
1851
1852 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
1853
1854         Reviewed by Adam Roben.
1855
1856         Windows bots need to archive/unarchive builds to/from configuration-specific directories
1857         https://bugs.webkit.org/show_bug.cgi?id=51996
1858         
1859         After the configuration directory change, we were archiving the incorrect directory for
1860         build product, so we were running tests on the wrong binaries.
1861         
1862         This change archives the correct directory, and also unarchives it into a configuration-
1863         specific directory.
1864
1865         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Use a configuration-specific directory on Windows.
1866         * BuildSlaveSupport/built-product-archive: Unarchive/archive to/from proper directory.
1867
1868 2011-01-06  Eric Seidel  <eric@webkit.org>
1869
1870         Reviewed by Mihai Parparita.
1871
1872         commit-queue mentions "Text diff mismatch" 4 times instead of once per failure
1873         https://bugs.webkit.org/show_bug.cgi?id=52002
1874
1875         See an example of this here:
1876         https://bugs.webkit.org/show_bug.cgi?id=51314#c2
1877
1878         It's due to the fact that we pass around TestFailure() instance
1879         objects and yet expect them to all compare to be the same.
1880
1881         This is bad.  We should either have shared instances of these values
1882         or we should just pass around the class names.  There are already hacks
1883         in place to make TestFailure objects pass equality tests, I just added
1884         a __hash__ implementation so they can be used in sets as expected.
1885
1886         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1887         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1888
1889 2011-01-06  Evan Martin  <evan@chromium.org>
1890
1891         Reviewed by Tony Chang.
1892
1893         [gdb] handle inaccessible memory and UChar*
1894         https://bugs.webkit.org/show_bug.cgi?id=52003
1895
1896         To pretty-print a UChar*, we just grope around in the memory
1897         looking for a terminating NUL.  We need to handle the exception
1898         that can occur when we poke into an invalid location.
1899
1900         Additionally, the logic for choosing which pretty-printer would
1901         early return before hitting the point where we'd use the UChar*
1902         printer.  (Did this ever work?  How did it regress?)
1903
1904         * gdb/webkit.py:
1905
1906 2011-01-05  Brian Weinstein  <bweinstein@apple.com>
1907
1908         Reviewed by Ada Chan.
1909
1910         WebKit2: Should be able to call into injected bundle to ask if we should allow resource loads
1911         https://bugs.webkit.org/show_bug.cgi?id=51969
1912         
1913         Add shouldLoadResourceForFrame to WTR::InjectedBundlePage.
1914
1915         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1916         (WTR::InjectedBundlePage::InjectedBundlePage):
1917         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Stub implementation.
1918         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1919
1920 2011-01-06  James Robinson  <jamesr@chromium.org>
1921
1922         Reviewed by Simon Fraser.
1923
1924         Implement mozilla's animationTime property
1925         https://bugs.webkit.org/show_bug.cgi?id=51952
1926
1927         Chromium DRT support for webkitAnimationTime.
1928
1929         * DumpRenderTree/chromium/WebViewHost.cpp:
1930         (WebViewHost::paintInvalidatedRegion):
1931
1932 2011-01-06  Julie Parent  <jparent@chromium.org>
1933
1934         Reviewed by Tony Chang.
1935
1936         Test Result Server always truncates number of results to JSON_RESULTS_MAX_BUILDS
1937         https://bugs.webkit.org/show_bug.cgi?id=51217
1938
1939         * TestResultServer/model/jsonresults.py:
1940         Pass num_runs through to _remove_items_over_max_number_of_builds, and use the value.
1941         Adds missing documentation.
1942         * TestResultServer/model/jsonresults_unittest.py:
1943         Add unit test to test that truncation happens at smaller value than JSON_RESULTS_MAX_BUILDS.
1944         Update test_merge to take a number of builds to truncate at.
1945
1946 2011-01-06  Adam Barth  <abarth@webkit.org>
1947
1948         Reviewed by Eric Seidel.
1949
1950         The EWS should log outside of the working directory
1951         https://bugs.webkit.org/show_bug.cgi?id=51986
1952
1953         This patch prepare us for using git clean -x -d -f in the EWS wrapper
1954         script, which will actually clean the working copy back to a pristine
1955         state instead of leaving untracked directories and ignored files.
1956
1957         * Scripts/webkitpy/tool/commands/queues.py:
1958         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1959
1960 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
1961
1962         Windows build fix.
1963         Back out attempted change to built-product-archive.
1964
1965         * BuildSlaveSupport/built-product-archive:
1966
1967 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
1968
1969         Windows build fix.
1970         Include configuration name when unpacking a build archive.
1971
1972         Needed, since we split Windows build results into configuration-specific directories
1973         under WebKitOutputDir.
1974
1975         * BuildSlaveSupport/built-product-archive:
1976
1977 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
1978
1979         Reviewed by Darin Adler.
1980
1981         Debug and Release builds on Windows clobber each other
1982         https://bugs.webkit.org/show_bug.cgi?id=49185
1983
1984         Changes the structure of WebKitBuild build products directory so we
1985         completely separate each build configuration into independent directories.
1986         
1987         Although we previously had per-configuration directories for obj, this change adds
1988         per-configuration directories for bin, lib, obj, and include. Each configuration's
1989         build products are stored within a directory inside of WebKitBuild.
1990         
1991         Most use of $(WebKitOutputDir) in the build files has been replaced by $(ConfigurationBuildDir),
1992         defined in common.vsprops to be $(WebKitOutputDir)\$(ConfigurationName).
1993
1994         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops:
1995         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd:
1996         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd:
1997         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
1998         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd:
1999         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd:
2000         * DumpRenderTree/win/ImageDiffCommon.vsprops:
2001         * DumpRenderTree/win/ImageDiffPostBuild.cmd:
2002         * DumpRenderTree/win/ImageDiffPreBuild.cmd:
2003         * FindSafari/FindSafari.vcproj:
2004         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
2005         * MiniBrowser/MiniBrowserPostBuild.cmd:
2006         * MiniBrowser/MiniBrowserPreBuild.cmd:
2007         * Scripts/webkitdirs.pm:
2008         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
2009         * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops:
2010         * TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd:
2011         * TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd:
2012         * TestWebKitAPI/win/copy-resources.cmd:
2013         * WebKitAPITest/WebKitAPITestCommon.vsprops:
2014         * WebKitAPITest/WebKitAPITestPostBuild.cmd:
2015         * WebKitAPITest/WebKitAPITestPreBuild.cmd:
2016         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
2017         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
2018         * WebKitTestRunner/win/InjectedBundle.vcproj:
2019         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops:
2020         * WebKitTestRunner/win/InjectedBundlePostBuild.cmd:
2021         * WebKitTestRunner/win/InjectedBundlePreBuild.cmd:
2022         * WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd:
2023         * WebKitTestRunner/win/WebKitTestRunnerPreBuild.cmd:
2024         * WinLauncher/WinLauncherCommon.vsprops:
2025         * WinLauncher/WinLauncherPostBuild.cmd:
2026         * WinLauncher/WinLauncherPreBuild.cmd:
2027
2028 2011-01-05  Jan Erik Hanssen  <jhanssen@sencha.com>
2029
2030         Reviewed by Ariya Hidayat.
2031
2032         [Qt] TestNetscapePlugin doesn't link on OS X
2033         https://bugs.webkit.org/show_bug.cgi?id=51948
2034
2035         Only add a dependency on libX11 on X11 systems
2036
2037         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2038
2039 2011-01-05  Jeff Miller  <jeffm@apple.com>
2040
2041         Reviewed by Adam Roben.
2042
2043         check-webkit-style should allow unnecessary parameter names in WebKit2 APIs because we're matching CF's header style
2044         https://bugs.webkit.org/show_bug.cgi?id=51970
2045
2046         * Scripts/webkitpy/style/checker.py:
2047         Add -readability/naming for WebKit2 C API directories.
2048
2049 2011-01-05  Eric Seidel  <eric@webkit.org>
2050
2051         Unreviewed, just fixing one more log error from my previous python patch.
2052
2053         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
2054         https://bugs.webkit.org/show_bug.cgi?id=51802
2055
2056         webkit-patch failure-reason was logging about parsing errors
2057         due to my misunderstanding of how BeautifulSoup.findAll worked.
2058
2059         Fixed, and added a unit test.
2060
2061         * Scripts/webkitpy/common/net/layouttestresults.py:
2062         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2063
2064 2011-01-05  Benjamin Poulain  <benjamin.poulain@nokia.com>
2065
2066         Reviewed by Kenneth Rohde Christiansen.
2067
2068         [Qt] [WK2] Add the possibility to open window from the WebProcess in Minibrowser
2069         https://bugs.webkit.org/show_bug.cgi?id=51951
2070
2071         Set a function to QWKPage::setCreateNewPageFunction() in Minibrowser so there is a way
2072         to create new window from WebKit.
2073
2074         * MiniBrowser/qt/BrowserWindow.cpp:
2075         (newPageFunction):
2076         (BrowserWindow::BrowserWindow):
2077         (BrowserWindow::page): Added to avoid the indirect access to QWKPage spread in the class
2078         (BrowserWindow::newWindow):
2079         (BrowserWindow::updateUserAgentList):
2080         (BrowserWindow::showUserAgentDialog):
2081         * MiniBrowser/qt/BrowserWindow.h: Add the global variable backingStoreTypeForNewWindow to
2082         define the type of the backing store used for new windows.
2083         * MiniBrowser/qt/main.cpp:
2084         (main):
2085
2086 2011-01-05  Eric Seidel  <eric@webkit.org>
2087
2088         Reviewed by Ojan Vafai.
2089
2090         commit-queue should report failure type when reporting flaky tests
2091         https://bugs.webkit.org/show_bug.cgi?id=51900
2092
2093         This patch was a ridiculous amount of plumbing.  In the end I like
2094         the NRWT-style TestResult class even less.  But now we're passing
2095         a list of TestResult objects from the queue to the FlakyTestReporter.
2096         Thus the FlakyTestReporter can more easily report what type of failure
2097         occurred.
2098
2099         In the process, I found that I was not alone in finding TestResult
2100         cumbersome to use.  A bunch of code was trying to create a TestResult
2101         object with default values.  However since the constructor didn't make
2102         this easy, some places were getting it wrong (including the TestResult unit test)!
2103         I've fixed the TestResult constructor to have default values for non-essential
2104         arguments.
2105
2106         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2107         * Scripts/webkitpy/common/net/layouttestresults.py:
2108         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2109         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2110         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2111         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2112         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
2113         * Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py:
2114         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2115         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2116         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2117         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2118         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2119         * Scripts/webkitpy/tool/commands/queues.py:
2120         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2121
2122 2011-01-05  Eric Seidel  <eric@webkit.org>
2123
2124         Unreviewed.
2125
2126         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
2127         https://bugs.webkit.org/show_bug.cgi?id=51802
2128
2129         Add another unit test to cover a previously missing import.
2130
2131         * Scripts/webkitpy/common/net/layouttestresults.py:
2132         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2133
2134 2011-01-05  Mihai Parparita  <mihaip@chromium.org>
2135
2136         Reviewed by David Levin.
2137
2138         Add mihaip@chromium.org as a reviewer
2139         https://bugs.webkit.org/show_bug.cgi?id=51966
2140         
2141         Add myself as a reviewer.
2142
2143         * Scripts/webkitpy/common/config/committers.py:
2144
2145 2011-01-05  James Simonsen  <simonjam@chromium.org>
2146
2147         Unreviewed. Adding myself to the list of committers.
2148
2149         * Scripts/webkitpy/common/config/committers.py:
2150
2151 2011-01-05  Eric Seidel  <eric@webkit.org>
2152
2153         Unreviewed.
2154
2155         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
2156         https://bugs.webkit.org/show_bug.cgi?id=51802
2157
2158         Fix two exceptions seen on the bots after my original commit.
2159
2160         * Scripts/webkitpy/common/net/layouttestresults.py:
2161         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2162
2163 2011-01-05  Kundu Suchismita  <suchi.kundu@nokia.com>
2164
2165         Reviewed by Andreas Kling.
2166
2167         [Qt]Add local storage settings to QtTestBrowser command line arguments 
2168         https://bugs.webkit.org/show_bug.cgi?id=51750
2169
2170         * QtTestBrowser/main.cpp:
2171         (LauncherApplication::handleUserOptions):
2172          Local storage settings can be enable form command line arguments for
2173          QtTestBrowser.
2174
2175 2011-01-05  Chris Fleizach  <cfleizach@apple.com>
2176
2177         Reviewed by Martin Robinson.
2178
2179         GTK: AX: DRT needs to use correct root object method.
2180         https://bugs.webkit.org/show_bug.cgi?id=51911
2181
2182         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
2183         (AccessibilityController::rootElement):
2184
2185 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
2186
2187         Rubber-stamped by Csaba Osztrogonác.
2188
2189         Based on idea from Péter Gál.
2190
2191         * Scripts/webkitpy/tool/bot/sheriff.py: Remove unnecessary apostrophes around revision numbers.
2192
2193 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
2194
2195         Reviewed by Adam Barth.
2196
2197         sheriff-bot should be able to do multi-revision rollouts
2198         https://bugs.webkit.org/show_bug.cgi?id=51176
2199
2200         * Scripts/webkitpy/tool/bot/irc_command.py:
2201         * Scripts/webkitpy/tool/bot/sheriff.py:
2202         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
2203
2204 2011-01-05  Eric Seidel  <eric@webkit.org>
2205
2206         Reviewed by Adam Barth.
2207
2208         queues.webkit.org should have per-bot status pages
2209         https://bugs.webkit.org/show_bug.cgi?id=51906
2210
2211         Just adds a /queue-status/QUEUE_NAME/bots/BOT_ID page to show
2212         statuses from a single queue.  Now that we have many bots servicing
2213         some queues (commit-queue, win-ews, etc.) its easy to have the messages
2214         you care about scroll off the end of the 15-message limit on the main page.
2215
2216         Eventually we should probably rename /queue-status to /queue or /queues,
2217         but that's fodder for another patch.
2218
2219         * QueueStatusServer/handlers/queuestatus.py:
2220         * QueueStatusServer/index.yaml:
2221         * QueueStatusServer/main.py:
2222         * QueueStatusServer/templates/includes/singlequeuestatus.html:
2223          - This probably should use a custom filter instead of hard-coding
2224            the URL scheme here, but I couldn't figure out how to easily
2225            create such a filter.  Most filters work with "strings" so we can't
2226            pass the status object.  We could add a method to the status
2227            object and call that, but that seemed a bit strange too.
2228         * QueueStatusServer/templates/queuestatus.html:
2229
2230 2011-01-05  Carlos Garcia Campos  <cgarcia@igalia.com>
2231
2232         Unreviewed. Adding myself to the list of committers.
2233
2234         * Scripts/webkitpy/common/config/committers.py:
2235
2236 2011-01-04  Koan-Sin Tan  <koansin.tan@gmail.com>
2237
2238         Reviewed by David Levin.
2239
2240         check-webkit-style treated some macros with parentheses after #elif as function calls
2241         https://bugs.webkit.org/show_bug.cgi?id=51695
2242
2243         Ingore function call space checking in any preprocessor directives
2244         (things starting with #). Change search() to match() because 
2245         preprocessor directives are supposed to be in the beginning of lines.
2246
2247         * Scripts/webkitpy/style/checkers/cpp.py:
2248         * Scripts/webkitpy/style/checkers/cpp_unittest.py: make sure there is no false positives for #elif cases
2249
2250 2011-01-04  Søren Gjesse  <sgjesse@chromium.org>
2251
2252         Reviewed by Tony Chang.
2253
2254         Change the --multi-load test option to --stress-opt
2255         https://bugs.webkit.org/show_bug.cgi?id=50751
2256
2257         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2258         (runTest):
2259         (main):
2260         * DumpRenderTree/chromium/TestShell.cpp:
2261         (TestShell::TestShell):
2262         * DumpRenderTree/chromium/TestShell.h:
2263         (TestShell::stressOpt):
2264         (TestShell::setStressOpt):
2265         (TestShell::stressDeopt):
2266         (TestShell::setStressDeopt):
2267         (TestShell::javaScriptFlags):
2268         (TestShell::setJavaScriptFlags):
2269         * Scripts/webkitpy/layout_tests/port/chromium.py:
2270         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2271
2272 2011-01-04  Chris Fleizach  <cfleizach@apple.com>
2273
2274         Reviewed by Sam Weinig.
2275
2276         WK2: Support Accessibility
2277         https://bugs.webkit.org/show_bug.cgi?id=51859
2278
2279         Use rootObject() method to get top of accessibility tree.
2280
2281         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
2282         (AccessibilityController::focusedElement):
2283         (AccessibilityController::rootElement):
2284
2285 2011-01-03  Martin Robinson  <mrobinson@igalia.com>
2286
2287         Reviewed by Darin Adler.
2288
2289         Remove the last non-GObject usage of PlatformRefPtr and move the code to GRefPtr
2290         https://bugs.webkit.org/show_bug.cgi?id=51846
2291
2292         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: Change usage of PlatformRefPtr
2293         back to GRefPtr.
2294
2295 2011-01-04  Zhe Su  <suzhe@chromium.org>
2296
2297         Reviewed by Kenneth Russell.
2298
2299         Fix insertText, setMarkedText and unmarkText methods of
2300         TextInputController to call corresponding methods of WebKit::WebView
2301         rather than WebKit::WebFrame. This change matches the behavior of
2302         chromium browser.
2303         insertText corresponds to WebView::confirmComposition(text)
2304         setMarkedText corresponds to WebView::setComposition(...)
2305         unmarkText corresponds to WebView::confirmComposition()
2306         https://bugs.webkit.org/show_bug.cgi?id=51693
2307
2308         * DumpRenderTree/chromium/TextInputController.cpp:
2309         (TextInputController::insertText):
2310         (TextInputController::setMarkedText):
2311         (TextInputController::unmarkText):
2312
2313 2011-01-04  Dihan Wickremasuriya  <dihan.wickremasuriya@nokia.com>
2314
2315         Reviewed by Laszlo Gombos.
2316
2317         [Qt] [Symbian] Do not remove 0 byte sized files from productDir
2318
2319         On Symbian productDir points to the source directory. Removing all the
2320         empty files from the productDir directory corrupts the svn repository.
2321
2322         * Scripts/build-webkit:
2323
2324 2011-01-03  Yi Shen  <yi.4.shen@nokia.com>
2325
2326         Reviewed by Adam Barth.
2327
2328         [Qt] Add SelectAll option to the context menu for the editor
2329         https://bugs.webkit.org/show_bug.cgi?id=50049
2330
2331         Set shortcut for the SelectAll action.
2332
2333         * QtTestBrowser/mainwindow.cpp:
2334         (MainWindow::buildUI):
2335
2336 2011-01-03  David Levin  <levin@chromium.org>
2337
2338         Reviewed by Eric Seidel.
2339
2340         check-webkit-style shouldn't consider "value" automatically to be a meaningless name.
2341         https://bugs.webkit.org/show_bug.cgi?id=51842
2342
2343         * Scripts/webkitpy/style/checkers/cpp.py: Remove the check for value.
2344         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Remove the test for value.
2345
2346 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
2347
2348         Reviewed by David Kilzer.
2349
2350         [WINCE] Adds a build slave.
2351         https://bugs.webkit.org/show_bug.cgi?id=50523
2352
2353         * BuildSlaveSupport/build.webkit.org-config/config.json: Add an
2354         entry for a release build of the WinCE port.
2355         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add platform
2356         flag to build the WinCE port.
2357
2358 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
2359
2360         Reviewed by David Kilzer.
2361
2362         Add WinCE support to build-webkit
2363         https://bugs.webkit.org/show_bug.cgi?id=51642
2364
2365         * Scripts/build-webkit:
2366         * Scripts/webkitdirs.pm:
2367
2368 2011-01-03  Eric Seidel  <eric@webkit.org>
2369
2370         Reviewed by Adam Barth.
2371
2372         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
2373         https://bugs.webkit.org/show_bug.cgi?id=51802
2374
2375         I'm not the biggest fan of the test_failures or test_results classes,
2376         but it's better to have one shared set of classes, than separate ones
2377         for new vs. old run-webkit-test result handling.
2378
2379         This moves the ORWT results class "LayoutTestResults" over to using
2380         TestResult and TestFailure classes, making it easy for us to
2381         make all our sheriff-bot and other webkitpy code NRWT ready.
2382
2383         This also makes it a trivial patch to generate results.json information
2384         from ORWT results.html files (for flaky test analysis, etc.) as well
2385         as making it a one-liner to report test failure types when the
2386         commit-queue sees flaky tests.
2387
2388         This patch tried not to add new functionality, but only to replace
2389         the guts of LayoutTestResults, while adding unit tests and hoping
2390         not to break anything.
2391
2392         I also moved callers which assumed User.prompt* were static/class methods
2393         to using them as instance methods (since we'll eventually want to make them such).
2394
2395         In the process of re-writing things, I broke the rebaseline command, so I wrote
2396         a unit test to catch my breakage were I do do so again in the future.
2397
2398         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2399         * Scripts/webkitpy/common/net/layouttestresults.py:
2400         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2401         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
2402         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
2403         * Scripts/webkitpy/tool/commands/queries.py:
2404         * Scripts/webkitpy/tool/commands/rebaseline.py:
2405         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2406         * Scripts/webkitpy/tool/mocktool.py:
2407
2408 2011-01-03  Adam Barth  <abarth@webkit.org>
2409
2410         Reviewed by Simon Fraser.
2411
2412         webkit-patch shouldn't waste time cleaning a working directory that's already clean
2413         https://bugs.webkit.org/show_bug.cgi?id=51840
2414
2415         * Scripts/webkitpy/common/checkout/scm.py:
2416
2417 2011-01-03  Adam Barth  <abarth@webkit.org>
2418
2419         Reviewed by Simon Fraser.
2420
2421         webkit-patch should only hide update output if --quiet
2422         https://bugs.webkit.org/show_bug.cgi?id=51838
2423
2424         As requested by smfr.
2425
2426         * Scripts/webkitpy/tool/steps/update.py:
2427
2428 2011-01-03  Adam Barth  <abarth@webkit.org>
2429
2430         Reviewed by David Levin.
2431
2432         commit-queue shouldn't reject patches twice if two bots process the same patch
2433         https://bugs.webkit.org/show_bug.cgi?id=51805
2434
2435         Before raising an error, we first check whether the patch is still in
2436         the commit-queue.  This check is still racy, of course, but the time
2437         window is much smaller.
2438
2439         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2440
2441 2011-01-03  Sam Weinig  <sam@webkit.org>
2442
2443         Reviewed by Anders Carlsson.
2444
2445         Make run-api-tests less chatty.
2446         https://bugs.webkit.org/show_bug.cgi?id=51831
2447
2448         - Make script quiet by default and add --verbose option (replacing --quiet).
2449         - When not verbose, pipe stdout and stderr to devnull.
2450
2451         * Scripts/run-api-tests:
2452
2453 2011-01-03  Pratik Solanki  <psolanki@apple.com>
2454
2455         Unreviewed. Adding myself to committers.py.
2456
2457         * Scripts/webkitpy/common/config/committers.py:
2458
2459 2011-01-03  Koan-Sin Tan  <koansin.tan@gmail.com>
2460
2461         Reviewed by Xan Lopez.
2462
2463         "Tool/Scripts/run-launcher --gtk" stopped working after 74855
2464         https://bugs.webkit.org/show_bug.cgi?id=51806
2465
2466         Originally, the $libraryName is 'JavaScriptCore'. When building release 
2467         one, the $libraryDir was 'WebKitBuild/Release/JavaScriptCore/../.libs/'
2468         which doesn't exist anymore ('WebKitBuild/Release/JavaScriptCore'
2469         is 'WebKitBuild/Release/Source/JavaScriptCore' now), and 
2470         'WebKitBuild/Release/Source/JavaScriptCore/../../.libs' looks weird,
2471         so make it 'WebKitBuild/Release/.libs'
2472
2473         * Scripts/webkitdirs.pm: 
2474
2475 2011-01-02  Patrick Gansterer  <paroga@webkit.org>
2476
2477         Reviewed by Adam Barth.
2478
2479         Make EFL a core builder
2480         https://bugs.webkit.org/show_bug.cgi?id=51804
2481
2482         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2483         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2484
2485 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
2486
2487         [Qt] Unreviewed fix after r74855 and r74875.
2488
2489         * BuildSlaveSupport/built-product-archive:
2490          - Create directories explicitly.
2491          - Pass shell=True to subprocess.call().
2492
2493 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
2494
2495         [Qt] Unreviewed fix after r74855.
2496
2497         Move JavaScriptCore to Source
2498         https://bugs.webkit.org/show_bug.cgi?id=51604
2499
2500         * BuildSlaveSupport/built-product-archive: JavaScriptCore -> Source/JavaScriptCore
2501
2502 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
2503
2504         [Qt] Unreviewed run-javasriptcore-tests fix after r74855.
2505
2506         Move JavaScriptCore to Source
2507         https://bugs.webkit.org/show_bug.cgi?id=51604
2508
2509         * Scripts/webkitdirs.pm:
2510
2511 2011-01-02  Robert Hogan  <robert@webkit.org>
2512
2513         Unreviewed, build fix.
2514
2515         [Qt] Fix DRT build after 74855
2516
2517         * DumpRenderTree/qt/DumpRenderTree.pro:
2518
2519 2011-01-01  Adam Barth  <abarth@webkit.org>
2520
2521         Remove the assumption from the Qt and Gtk builds that every project is
2522         in the root directory.
2523
2524         * Scripts/build-webkit:
2525
2526 2011-01-01  Adam Barth  <abarth@webkit.org>
2527
2528         Reviewed by Eric Seidel.
2529
2530         Teach svn-apply how to apply patches even though JavaScriptCore has moved
2531         https://bugs.webkit.org/show_bug.cgi?id=51796
2532
2533         After this change, svn-apply will magically apply patches to
2534         JavaScriptCore/foo to Source/JavaScriptCore/foo.
2535
2536         * Scripts/VCSUtils.pm:
2537
2538 2011-01-01  Adam Barth  <abarth@webkit.org>
2539
2540         Reviewed by Eric Seidel.
2541
2542         Move JavaScriptCore to Source
2543         https://bugs.webkit.org/show_bug.cgi?id=51604
2544
2545         Update references to JavaScriptCore to point to the new location.
2546
2547         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2548         * DumpRenderTree/qt/DumpRenderTree.pro:
2549         * DumpRenderTree/qt/ImageDiff.pro:
2550         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2551         * DumpRenderTree/wscript:
2552         * Scripts/build-jsc:
2553         * Scripts/build-webkit:
2554         * Scripts/do-file-rename:
2555         * Scripts/do-webcore-rename:
2556         * Scripts/run-javascriptcore-tests:
2557         * Scripts/update-javascriptcore-test-results:
2558         * Scripts/webkitdirs.pm:
2559         * Scripts/webkitpy/common/config/build_unittest.py:
2560         * Scripts/webkitpy/style/checker.py:
2561         * Scripts/webkitpy/style/checker_unittest.py:
2562         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2563         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2564         * WebKitTestRunner/qt/WebKitTestRunner.pro:
2565         * wx/build/settings.py:
2566
2567 2011-01-01  Adam Barth  <abarth@webkit.org>
2568
2569         Reviewed by Eric Seidel.
2570
2571         Move Sources to Source
2572         https://bugs.webkit.org/show_bug.cgi?id=51794
2573
2574         Update scripts to point to the new location.
2575
2576         * Scripts/build-webkit:
2577         * Scripts/do-file-rename:
2578         * Scripts/do-webcore-rename:
2579         * Scripts/webkitpy/common/config/build.py:
2580         * Scripts/webkitpy/common/config/build_unittest.py:
2581
2582 2010-12-31  Kent Tamura  <tkent@chromium.org>
2583
2584         Reviewed by Eric Seidel.
2585
2586         [DRT/Chromium] Enable mock spell checker on non-OSX
2587         https://bugs.webkit.org/show_bug.cgi?id=51401
2588
2589         * DumpRenderTree/chromium/WebViewHost.cpp:
2590         (WebViewHost::spellCheck):
2591
2592 2010-12-31  Adam Barth  <abarth@webkit.org>
2593
2594         Reviewed by Ariya Hidayat.
2595
2596         Remove Tools/Scripts/wkstyle
2597         https://bugs.webkit.org/show_bug.cgi?id=51774
2598
2599         This script appears to not have been touched in a while and seems to
2600         have been replaced by check-webkit-style.
2601
2602         * Scripts/wkstyle: Removed.
2603
2604 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
2605
2606         Unreviewed. Coding style fix.
2607
2608         * DumpRenderTree/chromium/TestShell.h:
2609
2610 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
2611
2612         Reviewed by Pavel Feldman.
2613
2614         Web Inspector: [Chromium] Inspector's tests are very slow on Win(Dbg).
2615
2616         It was a problem with Chromium DRT. DevToolsAgent object instance was
2617         attached not only to the inspected page but to the DevTools window too.
2618         As result all the inspector files were interpreted as a content of inspected page
2619         and were transfered to the DevTools scripts panel for debugging etc.
2620
2621         https://bugs.webkit.org/show_bug.cgi?id=51735
2622
2623         * DumpRenderTree/chromium/TestShell.cpp:
2624         (TestShell::TestShell):
2625         (TestShell::bindJSObjectsToWindow):
2626         (TestShell::createNewWindow):
2627         * DumpRenderTree/chromium/TestShell.h:
2628
2629 2010-12-31  Adam Barth  <abarth@webkit.org>
2630
2631         Rubber-stamped by Eric Seidel.
2632
2633         Move PageLoadTests to PerformanceTests/PageLoad
2634         https://bugs.webkit.org/show_bug.cgi?id=51771
2635
2636         Update references to PageLoadTests to point to the new location.
2637
2638         * Scripts/run-pageloadtest:
2639         * Scripts/webkitpy/common/config/build.py:
2640
2641 2010-12-31  Adam Barth  <abarth@webkit.org>
2642
2643         Rubber-stamped by Eric Seidel.
2644
2645         Move SunSpider into PerformanceTests
2646         https://bugs.webkit.org/show_bug.cgi?id=51769
2647
2648         Update these scripts to point to the new location.
2649
2650         * Scripts/run-sunspider:
2651         * Scripts/sunspider-compare-results:
2652
2653 2010-12-30  Mihai Parparita  <mihaip@chromium.org>
2654
2655         Reviewed by Kent Tamura.
2656
2657         [Chromium] Add WebThemeEngineDRTMac so that Chromium DRT scrollbar rendering can match the Mac port's
2658         https://bugs.webkit.org/show_bug.cgi?id=51728
2659         
2660         Add implementation of the Mac WebThemeEngine that uses an NSScroller
2661         to render top-level scrollbars. This makes them match the Mac port's
2662         use of an NSScrollView, which means that we'll be able to share more
2663         pixel baselines.
2664         
2665         The new rendering code will not be activated until the 
2666         USE_WEB_THEME_ENGINE_TO_PAINT_THUMB #define is fliped in
2667         ScrollbarThemeChromiumMac.
2668
2669         * DumpRenderTree/DumpRenderTree.gypi:
2670         * DumpRenderTree/chromium/TestShellMac.mm:
2671         (platformInit):
2672         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Added.
2673         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Added.
2674         (+[FakeActiveWindow alwaysActiveWindow]):
2675         (+[FakeActiveWindow alwaysInactiveWindow]):
2676         (-[FakeActiveWindow initWithActiveControls:]):
2677         (-[FakeActiveWindow _hasActiveControls]):
2678         (WebThemeEngineDRTMac::paintScrollbarThumb):
2679         (stateToHIEnableState):
2680         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
2681         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
2682
2683 2010-12-30  Konstantin Tokarev  <annulen@yandex.ru>
2684
2685         Reviewed by David Kilzer.
2686
2687         [Qt] Don't build wtf/TCSystemAlloc.cpp if --system-malloc option is
2688         used
2689         https://bugs.webkit.org/show_bug.cgi?id=51672
2690
2691         * DumpRenderTree/qt/DumpRenderTree.pro: Replaced USE_SYSTEM_MALLOC
2692         with USE_SYSTEM_MALLOC=1
2693         * WebKitTestRunner/qt/WebKitTestRunner.pro: Replaced USE_SYSTEM_MALLOC
2694         with USE_SYSTEM_MALLOC=1
2695
2696 2010-12-30  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2697
2698         Reviewed by David Kilzer.
2699
2700         [Qt] [Symbian] Fix build-webkit script for Symbian
2701         https://bugs.webkit.org/show_bug.cgi?id=51509
2702
2703         Set the OUTPUT_DIR for Symbian to be the same as the source
2704         directory.
2705
2706         * Scripts/webkitdirs.pm:
2707
2708 2010-12-30  Martin Robinson  <mrobinson@igalia.com>
2709
2710         Reviewed by Darin Adler.
2711
2712         check-webkit-style should ignore NULL usage in calls to gtk_widget_style_get
2713         https://bugs.webkit.org/show_bug.cgi?id=51758
2714
2715         Add a check-webkit-style exception for gtk_widget_style_get and NULL usage.
2716
2717         * Scripts/webkitpy/style/checkers/cpp.py: Add the exception.
2718         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Add some tests for this.
2719
2720 2010-12-29  Patrick Gansterer  <paroga@webkit.org>
2721
2722         Unreviewed WinCE buildfix.
2723
2724         * WinCELauncher/main.cpp: Add missing include.
2725
2726 2010-12-29  Daniel Bates  <dbates@rim.com>
2727
2728         Reviewed by Darin Adler.
2729
2730         svn-apply updates date of wrong change log entry for a change log diff that
2731         contains two consecutive entries with the same author and date
2732         https://bugs.webkit.org/show_bug.cgi?id=46061
2733
2734         Fixes an issue where the date of the wrong change log entry may be modified.
2735         Moreover, changes fixChangeLogPatch() to move entries inserted earlier
2736         in a ChangeLog file to the top of the file.
2737
2738         Currently, fixChangeLogPatch() explicitly bails out and returns an unchanged
2739         diff when it detects that the diff inserts a change log entry earlier in a
2740         ChangeLog. It is unusual to land a patch that has such a deliberate ChangeLog
2741         change. With the advent of the commit-queue this functionality of bailing out
2742         and hence landing the patch as-is is harmful to the accuracy of the ChangeLog.
2743         Instead, we should always move the change log entry to the top of the ChangeLog file.
2744
2745         A side-effect of this change is that setChangeLogDateAndReviewer() now updates
2746         the date line of the correct change log entry in a ChangeLog diff.
2747
2748         * Scripts/VCSUtils.pm: Modified fixChangeLogPatch() to move entries inserted earlier to the top.
2749
2750         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
2751           Updated the following unit tests now that we move entries inserted earlier to the top:
2752           - "fixChangeLogPatch: New entry inserted in middle."
2753             (formerly named "fixChangeLogPatch: [no change] New entry inserted in middle.")
2754
2755           - "fixChangeLogPatch: New entry inserted earlier in the file, but after an entry with the same author and date."
2756             (formerly named "fixChangeLogPatch: [no change] New entry inserted earlier in the file, but after an entry with the same author and date.")
2757
2758         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatchThenSetChangeLogDateAndReviewer.pl: Added.
2759
2760 2010-12-29  Konstantin Tokarev  <annulen@yandex.ru>
2761
2762         Reviewed by Eric Seidel.
2763
2764         [Qt] Fixed compatibility with gold linker on X11 platforms
2765         https://bugs.webkit.org/show_bug.cgi?id=51700
2766
2767         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2768         Linked TestNetscapePlugin with libX11 on Unix platforms
2769
2770 2010-12-29  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>
2771
2772         Reviewed by Darin Adler.
2773
2774         Circular dependency in webkitpy.common.checkout.changelog module
2775         https://bugs.webkit.org/show_bug.cgi?id=50475
2776
2777         Remove automatic import of api.Checkout module when any checkout/
2778         submodule is imported (e.g.: when checkout.scm.Git is imported).
2779
2780         * Scripts/webkitpy/common/checkout/__init__.py:
2781
2782 2010-12-29  Martin Robinson  <mrobinson@igalia.com>
2783
2784         Reviewed by Ojan Vafai.
2785
2786         prepare-ChangeLog should support the -g option for specifying the git-commit
2787         https://bugs.webkit.org/show_bug.cgi?id=51708
2788
2789         Add a -g shortcut for the --git-commit prepare-ChangeLog option. This matches
2790         webkit-patch, though the exact meaning of the two options remain different.
2791
2792         * Scripts/prepare-ChangeLog: Add -g.
2793
2794 2010-12-29  Kent Hansen  <kent.hansen@nokia.com>
2795
2796         Reviewed by Simon Hausmann.
2797
2798         [Qt] Fix compilation with Qt in namespace
2799         https://bugs.webkit.org/show_bug.cgi?id=51701
2800
2801         * QtTestBrowser/webview.h:
2802
2803 2010-12-28  Daniel Bates  <dbates@rim.com>
2804
2805         Reviewed by Sam Weinig.
2806
2807         Substitute // MARK: for compiler-specific #pragma mark
2808         https://bugs.webkit.org/show_bug.cgi?id=51657
2809
2810         Fix future compilation warnings about "#pragma mark" on GTK+ bots by
2811         substituting  "// MARK:" for "#pragma mark", which provides
2812         analogous code-bookmarking functionality under Xcode.
2813
2814         Also, for consistency, we should substitute "// MARK:" for compiler-
2815         specific "#pragma mark" in the source files for the Mac port.
2816
2817         * DumpRenderTree/AccessibilityTextMarker.cpp:
2818         * DumpRenderTree/cf/WebArchiveDumpSupport.h:
2819         * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm:
2820         * DumpRenderTree/mac/ObjCController.m:
2821         * MiniBrowser/mac/AppDelegate.m:
2822         * MiniBrowser/mac/BrowserWindowController.m:
2823
2824 2010-12-28  Xan Lopez  <xlopez@igalia.com>
2825
2826         Reviewed by Eric Seidel.
2827
2828         Add --no-build option to run-sunspider
2829         https://bugs.webkit.org/show_bug.cgi?id=51658
2830
2831         * Scripts/run-sunspider: add --no-build flag to skip building
2832         phase.
2833
2834 2010-12-27  Daniel Bates  <dbates@rim.com>
2835
2836         Rubber-stamped by Martin Robinson.
2837
2838         Append the directory Tools/DumpRenderTree to the list of directories that
2839         do-webcore-rename should search so that it can rename DRT files and
2840         source code.
2841
2842         * Scripts/do-webcore-rename:
2843
2844 2010-12-27  Eric Seidel  <eric@webkit.org>
2845
2846         Reviewed by Adam Barth.
2847
2848         build-webkit should detect missing Java SDK and explain how to install it
2849         https://bugs.webkit.org/show_bug.cgi?id=51651
2850
2851         * Scripts/build-webkit:
2852
2853 2010-12-26  Martin Robinson  <mrobinson@igalia.com>
2854
2855         Reviewed by Daniel Bates.
2856
2857         [GTK] Add support for build-jsc
2858         https://bugs.webkit.org/show_bug.cgi?id=51625
2859
2860         Add GTK+ support to build-jsc now that building the jsc executable as
2861         a standalone target is easy.
2862
2863         * Scripts/build-jsc: Call buildGtkProject for the GTK+ case now.
2864         * Scripts/build-webkit: Pass in the proper target name to buildGtkProject.
2865         * Scripts/webkitdirs.pm: Actually process the project parameter in buildGtkProject
2866         and pass it along to buildAutotoolsProject.
2867
2868 2010-12-27  David Levin  <levin@chromium.org>
2869
2870         Reviewed by Eric Seidel.
2871
2872         check-webkit-style check for meaningless variable names in function declarations.
2873         https://bugs.webkit.org/show_bug.cgi?id=51523
2874
2875         * Scripts/webkitpy/style/checker.py: Exempted JavaScriptCore/jit/JITStubs.cpp
2876         from the new check and whitespace/parens because the syntax is unusual and
2877         produced a fair number of positives for these checks.
2878         * Scripts/webkitpy/style/checkers/cpp.py:
2879         (_convert_to_lower_with_underscores): Used as a canonical form for type names
2880         and parameter names when determining if the parameter name is useless.
2881         (_create_acronym): Used to check for redundant variable names in cases like "ExceptionCode ec"
2882         (Parameter.lower_with_underscores_name): Gives back the parameter name in a lower_with_underscore
2883         format.
2884         (_check_parameter_name_against_text):  Checks to see if the parameter name is in the
2885         text or an acronym of it.
2886         (check_function_definition): Checks function definitions for meaningless variable names.
2887         (process_line): Added call to check_function_definition.
2888         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2889         (CppFunctionsTest.test_convert_to_lower_with_underscores): Test for _convert_to_lower_with_underscores.
2890         (CppFunctionsTest.test_create_acronym): Test for _create_acronym.
2891         (CppFunctionsTest.test_check_parameter_against_text): Test for _check_parameter_against_text.
2892         (CppStyleTestBase.perform_single_line_lint): Removed the parameter name check
2893         because when only checking a snippet, there are a lot of bogus functions.
2894         (CppStyleTestBase.perform_multi_line_lint): Ditto and removed a bogus filter
2895         that I put there previously and just noticed.
2896         (WebKitStyleTest.test_parameter_names): Tests for the functionality -- both
2897         check_function_definition and process_line.
2898
2899 2010-12-27  Carlos Garcia Campos  <cgarcia@igalia.com>
2900
2901         Reviewed by Martin Robinson.
2902
2903         [GTK] Disable flash plugin in GtkLauncher when using gtk3
2904         https://bugs.webkit.org/show_bug.cgi?id=51591
2905
2906         Flash plugin uses gtk2 that is incompatible with gtk3 making
2907         webkit crash when it's built with gtk3.
2908
2909         * GtkLauncher/main.c:
2910         (main):
2911
2912 2010-12-25  Adam Barth  <abarth@webkit.org>
2913
2914         Reviewed by Eric Seidel.
2915
2916         Move ANGLE to Sources/ThirdParty
2917         https://bugs.webkit.org/show_bug.cgi?id=51605
2918
2919         * Scripts/build-webkit:
2920           - Point to the new ANGLE location.
2921
2922 2010-12-26  David Levin  <levin@chromium.org>
2923
2924         Reviewed by Eric Seidel.
2925
2926         check-webkit-style should be able to parse function declaration parameters.
2927         https://bugs.webkit.org/show_bug.cgi?id=51451
2928
2929         * Scripts/webkitpy/style/checkers/cpp.py:
2930         (Position.__init__): Holds simple position information (row, column).
2931         (Parameter.__init__): Holds information about a parameter.
2932         (SingleLineView.__init): Converts multiple lines into a single line for simpler searches.
2933         (SingleLineView.convert_column_to_row): Returns the original row given a column.
2934         (create_skeleton_parameters): Simplifies a parameter list for easier searching.
2935         (find_parameter_name_index): Finds where the parameter name is.
2936         (parameter_list): Generates the list of parameters for a function.
2937         (_FunctionState.begin): Added information to allow determining the parameters
2938         on demand.
2939         (_FunctionState.get_parameter_list): Returns a tuple of function parameters.
2940         (detect_functions): Improve function detection for operator functions and
2941         determine where the parameters end and pass that to _FunctionState.begin.
2942         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2943         (CppFunctionsTest.test_parameter): Verifies Parameter functionality.
2944         (CppFunctionsTest.test_single_line_view): Verifies SingleLineView functionality.
2945         (CppFunctionsTest.test_create_skeleton_parameters): Verifies create_skeleton_parameters.
2946         (CppFunctionsTest.test_find_parameter_name_index): Verifies find_parameter_name_index.
2947         (CppFunctionsTest.test_parameter_list): Does some minimal verification for parameter list.
2948         Much more thorough verification is done as part of FunctionDetectionTest.test_parameter_list.
2949         (FunctionDetectionTest.perform_function_detection): Added support for verifying
2950         the parameters found.
2951         (FunctionDetectionTest.test_function_declaration_detection): Added more function
2952         detection test to verify that we catch the operator functions.
2953         (FunctionDetectionTest.test_ignore_macros): Verify that function detection ignores macros.
2954         (FunctionDetectionTest.test_parameter_list): Added tests to verify the parameter parsing.
2955         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_bad_test_doesnt_break): Removed
2956         because the error. The test is about the bad function name. Fixing the name makes the test exactly like
2957         test_function_length_check_definition_severity1_for_test.
2958
2959 2010-12-25  Patrick Gansterer  <paroga@webkit.org>
2960
2961         Unreviewed WinCE buildfix after r74334.
2962
2963         * CMakeListsWinCE.txt:
2964
2965 2010-12-24  Sheriff Bot  <webkit.review.bot@gmail.com>
2966
2967         Unreviewed, rolling out r74632.
2968         http://trac.webkit.org/changeset/74632
2969         https://bugs.webkit.org/show_bug.cgi?id=51600
2970
2971         makes test-webkitpy hang forever on GTK (Requested by philn-tp
2972         on #webkit).
2973
2974         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
2975         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
2976
2977 2010-12-24  Ryuan Choi  <ryuan.choi@samsung.com>
2978
2979         Reviewed by Kenneth Rohde Christiansen.
2980
2981         [EFL] Screen doesn't be rendered when changing size of EWebLauncher
2982         https://bugs.webkit.org/show_bug.cgi?id=43528
2983
2984         Remove on_resize because ewk_view_fixed_layout_size_set should not be
2985         called on callback of EVAS_CALLBACK_RESIZE. As it change size of
2986         FrameView, rendering was ignored when _ewk_view_smart_calculate was
2987         called.
2988
2989         * EWebLauncher/main.c:
2990         (browserCreate):
2991
2992 2010-12-24  Eric Seidel  <eric@webkit.org>
2993
2994         Reviewed by Adam Barth.
2995
2996         webkit-patch (or a pre-commit hook) needs to prevent bad ChangeLog changes
2997         https://bugs.webkit.org/show_bug.cgi?id=28291
2998
2999         This is a start.  At least now webkit-patch will prompt when your ChangeLog looks questionable.
3000         We could do more advanced things, like parsing the ChangeLog (with changelog.py) and comparing that
3001         to strings with find in the diff.
3002         Since non-interactive always returns the default, this should cause patches with bad changelogs to fail on the commit-queue.
3003
3004         * Scripts/webkitpy/common/checkout/api.py:
3005         * Scripts/webkitpy/common/checkout/diff_parser.py:
3006         * Scripts/webkitpy/tool/steps/abstractstep.py:
3007         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
3008         * Scripts/webkitpy/tool/steps/validatechangelogs.py: Copied from Tools/Scripts/webkitpy/tool/steps/validatereviewer.py.
3009         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py: Copied from Tools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.
3010         * Scripts/webkitpy/tool/steps/validatereviewer.py:
3011
3012 2010-12-24  Dirk Pranke  <dpranke@chromium.org>
3013
3014         Reviewed by Kenneth Russell.
3015
3016         Modify new-run-webkit-tests to shut up and exit when all the threads
3017         are wedged so that test runs complete faster and we don't end up
3018         w/ enormous log files.
3019
3020         https://bugs.webkit.org/show_bug.cgi?id=51572
3021
3022         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
3023         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
3024
3025 2010-12-24  Eric Seidel  <eric@webkit.org>
3026
3027         Reviewed by David Levin.
3028
3029         commit-queue should better explain how it will re-open bugs and follow duplicate chains
3030         https://bugs.webkit.org/show_bug.cgi?id=51549
3031
3032         I've had multiple people ask me about the commit-queue's behavior
3033         regarding reporting flaky tests.  I figured it would be best to just
3034         have the queue explain itself in the bugs it files.
3035
3036         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3037         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3038
3039 2010-12-24  Shinichiro Hamaji  <hamaji@chromium.org>
3040
3041         Reviewed by Eric Seidel.
3042
3043         check-webkit-style: should ignore "wrong" namings in JavaScriptCore/qt
3044         https://bugs.webkit.org/show_bug.cgi?id=51467
3045
3046         * Scripts/webkitpy/style/checker.py:
3047         * Scripts/webkitpy/style/checker_unittest.py:
3048
3049 2010-12-23  Adam Barth  <abarth@webkit.org>
3050
3051         Rubber-stamped by Eric Seidel.
3052
3053         Move JavaScriptGlue into Sources
3054         https://bugs.webkit.org/show_bug.cgi?id=51583
3055
3056         These tools refer to JavaScriptGlue and need to be updated to its new
3057         location.
3058
3059         * Scripts/build-webkit:
3060         * Scripts/do-file-rename:
3061         * Scripts/do-webcore-rename:
3062         * Scripts/webkitpy/common/config/build.py:
3063         * Scripts/webkitpy/common/config/build_unittest.py:
3064
3065 2010-12-23  Lucas Forschler  <lforschler@apple.com>
3066
3067         Reviewed by Eric Seidel.
3068
3069         Bug 51539 - update iexploder scripts to point to new location
3070
3071         * Scripts/run-iexploder-tests:
3072         * Scripts/update-iexploder-cssproperties:
3073
3074 2010-12-23  Evan Martin  <evan@chromium.org>
3075
3076         Reviewed by Ryosuke Niwa.
3077
3078         [chromium] LayoutTestController warning in float->int conversion
3079         https://bugs.webkit.org/show_bug.cgi?id=51553
3080
3081         Rather than reading an int, converting to a float, then getting a compiler
3082         warning on passing the float to something that expects an int, instead
3083         just pass around ints.
3084
3085         No tests, fixes a compiler warning.
3086
3087         * DumpRenderTree/chromium/LayoutTestController.cpp:
3088         (parsePageSizeParameters):
3089         (LayoutTestController::pageNumberForElementById):
3090         (LayoutTestController::numberOfPages):
3091
3092 2010-12-23  Lucas Forschler  <lforschler@apple.com>
3093
3094         Reviewed by Darin Adler.
3095
3096         Bug 51537 - iexploder needs cleanup
3097         
3098         * iExploder/htdocs: Removed.
3099         * iExploder/htdocs/config.rb: Removed.
3100         * iExploder/htdocs/cssproperties.in: Removed.
3101         * iExploder/htdocs/cssvalues.in: Removed.
3102         * iExploder/htdocs/htmlattrs.in: Removed.
3103         * iExploder/htdocs/htmltags.in: Removed.
3104         * iExploder/htdocs/htmlvalues.in: Removed.
3105         * iExploder/htdocs/iexploder.cgi: Removed.
3106         * iExploder/htdocs/iexploder.rb: Removed.
3107         * iExploder/htdocs/index.html: Removed.
3108         * iExploder/htdocs/webserver.rb: Removed.
3109         * iExploder/iexploder-1.7.2/output: Removed.
3110         * iExploder/tools: Removed.
3111         * iExploder/tools/lasthit.rb: Removed.
3112         * iExploder/tools/osx_last_crash.rb: Removed.
3113         * iExploder/tools/showtest.rb: Removed.
3114
3115 2010-12-23  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
3116
3117         Reviewed by Kenneth Rohde Christiansen.
3118
3119         [EFL] Make 'single' the default backing store in EWebLauncher
3120         https://bugs.webkit.org/show_bug.cgi?id=51534
3121
3122         'single' is the simplest backing store and the one intended to be the
3123         default in the test browser. By mistake the tiled backing store was
3124         left as default in r72617.
3125
3126         * EWebLauncher/main.c:
3127         (browserCreate): ditto.
3128
3129 2010-12-23  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
3130
3131         Reviewed by Kenneth Rohde Christiansen.
3132
3133         [EFL] Subject: [webkit 4/4] [EFL] Remove non-sense workaround
3134         https://bugs.webkit.org/show_bug.cgi?id=51533
3135
3136         There's no point in concatenating env("HOME") with "blah", so remove
3137         option from EWebLauncher.
3138
3139         * EWebLauncher/main.c:
3140         (main): ditto.
3141
3142 2010-12-23  Ilya Tikhonovsky  <loislo@chromium.org>
3143
3144         Reviewed by Eric Seidel.
3145
3146         Web Inspector: chromium: inspector's tests are quite slow especially at windows(Debug).
3147
3148         Almost all inspector's tests become flaky on chromium Win(dbg) after switching to DRT.
3149         I just discovered that we have two additional GC runs per each WebViewHost.
3150         Test_shell had no such calls.
3151         These gc runs eat 15% of cpu time.
3152
3153         https://bugs.webkit.org/show_bug.cgi?id=51479
3154
3155         * DumpRenderTree/chromium/WebViewHost.cpp:
3156         (WebViewHost::~WebViewHost):
3157
3158 2010-12-22  Dirk Pranke  <dpranke@chromium.org>
3159
3160         Reviewed by Ojan Vafai.
3161
3162         This change splits out the TestRunner class into its own file.
3163         When we fork the code for message passing, we will create a new
3164         TestRunner, and this change will allow that to be more modular.
3165
3166         While we're at it, split out TestInput and ResultSummary into
3167         their own files, to reduce the size of run_webkit_tests to
3168         something more managable.
3169
3170         https://bugs.webkit.org/show_bug.cgi?id=51092
3171
3172         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
3173         * Scripts/webkitpy/layout_tests/layout_package/result_summary.py:
3174         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
3175         * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
3176         * Scripts/webkitpy/layout_tests/layout_package/test_input.py:
3177         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3178         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3179
3180  2010-12-22  Dirk Pranke  <dpranke@chromium.org>
3181
3182         Reviewed by Ojan Vafai.
3183
3184         nrwt multiprocessing - start over, prepare to fork the code
3185  
3186         This code cleans up the signatures and implementation of the
3187         TestRunner class so we can easily fork it to run either the
3188         stable implementation or the new, unstable message-passing
3189         implementation. The two variants will have different
3190         implementations of the run_tests() method. We will switch
3191         between the two based on the setting for the '--worker-model'
3192         switch. We rename the two currently valid values to 'old-inline'
3193         and 'old-threads'.
3194
3195         https://bugs.webkit.org/show_bug.cgi?id=51081
3196
3197         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3198         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3199
3200 2010-12-22  Victor Wang  <victorw@chromium.org>
3201
3202         Reviewed by Darin Fisher.
3203
3204         [Chromium] Update chromium archive test result url in rebaseline script.
3205
3206         https://bugs.webkit.org/show_bug.cgi?id=51503
3207
3208         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
3209
3210 2010-12-22  Lucas Forschler  <lforschler@apple.com>
3211
3212         Reviewed by Alice Liu.
3213
3214         <rdar://problem/8633222> record-memory-win needs to record memory used by the webprocess.
3215         Verified on Chrome, Safari, and IE.
3216         With this change, we will record memory from a parent browser window and all child processes.
3217
3218         * record-memory-win/main.cpp:
3219         (ProcessArgs):
3220         (PrintUsage):
3221         (getMemoryInfo):
3222         (printProcessInfo):
3223         (evalProcesses):
3224         (UseImage):
3225         (QueryContinuously):
3226         (ElapsedTime):
3227
3228 2010-12-22  Lucas Forschler  <lforschler@apple.com>
3229
3230         Unreviewed rollout r74489, because it was missing changelog.
3231
3232         * record-memory-win/main.cpp:
3233         
3234 2010-12-22  Ryosuke Niwa  <rniwa@webkit.org>
3235
3236         Adding myself as a reviewer.
3237
3238         * Scripts/webkitpy/common/config/committers.py:
3239
3240 2010-12-22  Andrew Scherkus  <scherkus@chromium.org>
3241
3242         Unreviewed.  Adding myself to committers.py.
3243
3244         * Scripts/webkitpy/common/config/committers.py:
3245
3246 2010-12-22  Ariya Hidayat  <ariya@sencha.com>
3247
3248         Reviewed by Kenneth Rohde Christiansen.
3249
3250         TestNetscapePlugIn should use #if defined
3251         https://bugs.webkit.org/show_bug.cgi?id=51471
3252
3253         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3254         (NP_Initialize):
3255         (NPP_New):
3256
3257 2010-12-22  Ilya Tikhonovsky  <loislo@chromium.org>
3258
3259         Reviewed by Yury Semikhatsky.
3260
3261         Web Inspector: [chromium] DRT inspector layout tests are flaky in debug.
3262
3263         DevTools window should be closed explicitly because it has custom deinitialization code.
3264
3265         https://bugs.webkit.org/show_bug.cgi?id=50722
3266
3267         * DumpRenderTree/chromium/TestShell.cpp:
3268         (TestShell::closeRemainingWindows):
3269
3270 2010-12-22  David Levin  <levin@chromium.org>
3271
3272         Reviewed by Shinichiro Hamaji.
3273
3274         check-webkit-style shouldn't complaint about underscores in variables in objective C files.
3275         https://bugs.webkit.org/show_bug.cgi?id=51452
3276
3277         * Scripts/webkitpy/style/checkers/cpp.py:
3278         (_FileState.__init__): Added the information to determine if a file is C or Objective C.
3279         Using the file extension if possible but falling back to the file contents if we have a header file.
3280         (_FileState.is_objective_c): Determine if we have an Objective C by examining the file contents if needed.
3281         (_FileState.is_c_or_objective_c):
3282         (check_using_std): Changed to using _FileState to determine the file type.
3283         (check_max_min_macros): Ditto.
3284         (check_for_null): Ditto.
3285         (check_style): Changed the parameters to various calls since they now need _FileState
3286         to determine the file type.
3287         (check_language): Added the file_state parameter so it could be passed
3288         to check_identifier_name_in_declaration.
3289         (check_identifier_name_in_declaration): Don't warn about underscores in variables if
3290         this is an Objective C file.
3291         (_process_lines): Added information for the _FileState constructor (and moved the
3292         call to a place that had the information).
3293         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3294         (CppFunctionsTest.test_is_c_or_objective_c): Changed the tests to use FileState and exercise
3295         its functionality.
3296         (WebKitStyleTest.test_names): Add tests for underscores in Objective C files.
3297
3298 2010-12-21  Andy Estes  <aestes@apple.com>
3299
3300         Reviewed by Mark Rowe.
3301
3302         Do not build non-Intel architectures for WebKit2-related projects.
3303         https://bugs.webkit.org/show_bug.cgi?id=51440
3304
3305         * MiniBrowser/Configurations/Base.xcconfig: Only build for i386 and x86_64.
3306         * TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
3307         * WebKitTestRunner/Configurations/Base.xcconfig: Ditto.
3308
3309 2010-12-21  Mihai Parparita  <mihaip@chromium.org>
3310
3311         Reviewed by Darin Fisher.
3312
3313         [Chromium] Rename WebThemeEngine/ControlDRT to WebThemeEngine/ControlDRTWin
3314         https://bugs.webkit.org/show_bug.cgi?id=51406 
3315         
3316         Rename WebThemeControlDRT to WebThemeControlDRTWin and WebThemeEngineDRT
3317         to WebThemeEngineDRTWin and update references everywhere.
3318
3319         * DumpRenderTree/DumpRenderTree.gypi:
3320         * DumpRenderTree/chromium/TestShellWin.cpp:
3321         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRT.cpp.
3322         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRT.h.
3323         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRT.cpp.
3324         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRT.h.
3325
3326 2010-12-21  Anders Carlsson  <andersca@apple.com>
3327
3328         Reviewed by John Sullivan.
3329
3330         Clicking missing plug-in text does not show a sheet
3331         https://bugs.webkit.org/show_bug.cgi?id=51403
3332
3333         Update for changes to the WebPageUIClient.
3334
3335         * MiniBrowser/mac/BrowserWindowController.m:
3336         (-[BrowserWindowController awakeFromNib]):
3337         * WebKitTestRunner/TestController.cpp:
3338         (WTR::createOtherPage):
3339         (WTR::TestController::initialize):
3340
3341 2010-12-21  Eric Seidel  <eric@webkit.org>
3342
3343         Reviewed by Adam Barth.
3344
3345         commit-queue will report constant failures as flaky if other tests flake
3346         https://bugs.webkit.org/show_bug.cgi?id=51272
3347
3348         This patch just removes functionality and adds testing.
3349         Previously we attempted to report flaky tests when we had
3350         two different tests fail in a row.  However, since we stop
3351         running the tests at the first failure, our code was wrong in
3352         trying to determine flakiness from the incomplete runs.
3353
3354         Originally I posted an alternate patch:
3355         https://bug-51272-attachments.webkit.org/attachment.cgi?id=77078
3356         which fixed our flaky logic in this case, however it was decided
3357         that that patch would be too difficult to maintain, so now
3358         I'm just removing the broken logic.
3359
3360         This will dramatically cut-down on our flaky-test false positives
3361         at the (small) cost of the queues being unable to report
3362         any flakiness if the tree is very flaky.  (With at least one test
3363         flaking on every run, we'll never report failures anymore.)  I think
3364         this is a tradeoff worth making.
3365
3366         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3367         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3368
3369 2010-12-20  Eric Seidel  <eric@webkit.org>
3370
3371         Reviewed by Adam Barth.
3372
3373         commit-queue wrongly rejects patches when it can't update itself
3374         https://bugs.webkit.org/show_bug.cgi?id=46636
3375
3376         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3377         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3378         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3379
3380 2010-12-20  Adam Barth  <abarth@webkit.org>
3381
3382         Move web sites to Websites directory
3383         https://bugs.webkit.org/show_bug.cgi?id=51323
3384
3385         Update references to BugsSite to point to the new location.
3386
3387         This patch was never officially reviewed (because it was too large to
3388         upload to bugs.webkit.org), but it was discussed on webkit-dev and Mark
3389         Rowe gave me the green light.
3390
3391         * Scripts/old-run-webkit-tests:
3392         * Scripts/webkitpy/common/config/build.py:
3393         * Scripts/webkitpy/common/config/build_unittest.py:
3394         * Scripts/webkitpy/common/prettypatch.py:
3395         * Scripts/webkitpy/layout_tests/port/base.py:
3396         * Scripts/webkitpy/style/main.py:
3397
3398 2010-12-20  Adrienne Walker  <enne@google.com>
3399
3400         Unreviewed. Adding myself to the list of committers.
3401
3402         * webkitpy/common/config/committers.py:
3403
3404 2010-12-20  Mark Rowe  <mrowe@apple.com>
3405
3406         Reviewed by Dan Bernstein.
3407
3408         <rdar://problem/8757601> Don't install header files in to the Resources directory.
3409
3410         * Scripts/check-for-inappropriate-files-in-framework: Don't allow .h files in the
3411         Resources directory.
3412
3413 2010-12-20  Eric Seidel  <eric@webkit.org>
3414
3415         Reviewed by Adam Barth.
3416
3417         commit-queue should include bot id when attaching failure diffs
3418         https://bugs.webkit.org/show_bug.cgi?id=51280
3419
3420         This is a tiny change to include the bot id in the name of the attachment.
3421         Most of this diff is just changing the unit test expectations
3422         now that I hid the comment printing when the comment is None.
3423
3424         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3425         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3426         * Scripts/webkitpy/tool/commands/upload_unittest.py:
3427         * Scripts/webkitpy/tool/mocktool.py:
3428
3429 2010-12-20  Jeff Miller  <jeffm@apple.com>
3430
3431         Reviewed by Dan Bernstein.
3432
3433         Tools/vcbin/midl.exe needs to be rebuilt
3434         https://bugs.webkit.org/show_bug.cgi?id=51347
3435
3436         * vcbin/midl.exe: Rebuilt.
3437
3438 2010-12-20  David Levin  <levin@chromium.org>
3439
3440         Reviewed by Ariya Hidayat.
3441
3442         .gitignore and webkit-tools-completion.sh have references to WebKitTools that should be Tools.
3443         https://bugs.webkit.org/show_bug.cgi?id=51343
3444
3445         Follow up from the WebKitTools -> Tools rename.
3446
3447         * Scripts/webkit-tools-completion.sh:
3448
3449 2010-12-20  Cosmin Truta  <ctruta@chromium.org>
3450
3451         Reviewed by James Robinson.
3452
3453         new-run-webkit-tests ignores trailing EOL differences in text tests
3454         https://bugs.webkit.org/show_bug.cgi?id=36983
3455
3456         Changed the handling of new-line characters within new-run-webkit-tests
3457         to match old-run-webkit-tests.  Differences in leading and trailing empty
3458         lines in text expectation files are no longer ignored.
3459
3460         * Scripts/webkitpy/layout_tests/port/base.py:
3461         * Scripts/webkitpy/layout_tests/port/test.py:
3462         Added unit tests.  Removed old duplicate unit test entries.
3463         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
3464
3465 2010-12-20  David Levin  <levin@chromium.org>
3466
3467         Reviewed by Shinichiro Hamaji.
3468
3469         check-webkit-style should detect function declarations (and trivial functions).
3470         https://bugs.webkit.org/show_bug.cgi?id=51303
3471
3472         * Scripts/webkitpy/style/checkers/cpp.py:
3473         (_FunctionState.begin): Add is_declaration and changed the line count
3474         start to begin at -1 (which will keep the results consistent, since
3475         the starting line number passed in is one less in this change).
3476         (detect_functions): changed function detection to now catch trivial
3477         functions and declarations.
3478         (check_pass_ptr_usage): Don't check for Pass*Ptr on the first line
3479         of the function as this may look at return values (when processing
3480         a declaration).
3481         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3482         (FunctionDetectionTest.perform_function_detection): Basic mechanics
3483         of testing the function detection.
3484         (FunctionDetectionTest.test_basic_function_detection): Test a simple
3485         function.
3486         (FunctionDetectionTest.test_function_declaration_detection): Test a
3487         declaration.
3488         (FunctionDetectionTest.test_non_functions): A test case for a case
3489         that caused the code to fail due to the { being in quotes.
3490         (PassPtrTest.test_pass_ref_ptr_return_value): Added some more test
3491         cases to help catch false alarms for return values.
3492         (PassPtrTest.test_pass_ref_ptr_member_variable): Ensure that
3493         we don't get false alarms for member variables either.
3494
3495 2010-12-20  Ryuan Choi  <ryuan.choi@samsung.com>
3496
3497         Reviewed by Antonio Gomes.
3498
3499         [CMAKE] Rename WEBKITTOOLS_DIR to TOOLS_DIR
3500         https://bugs.webkit.org/show_bug.cgi?id=51319
3501
3502         * CMakeListsEfl.txt:
3503
3504 2010-12-18  Adam Barth  <abarth@webkit.org>
3505
3506         Reviewed by Sam Weinig.
3507
3508         Move WebKitExamplePlugins to Examples
3509         https://bugs.webkit.org/show_bug.cgi?id=51291
3510
3511         * Scripts/webkitpy/common/config/build.py:
3512
3513 2010-12-17  Csaba Osztrogonác  <ossy@webkit.org>
3514
3515         Unreviewed Qt buildfix after r74301.
3516
3517         Rename WebKitTools to Tools
3518         https://bugs.webkit.org/show_bug.cgi?id=49861
3519
3520         * MiniBrowser/DerivedSources.pro:
3521         * MiniBrowser/qt/MiniBrowser.pro:
3522
3523 2010-12-17  Dan Bernstein  <mitz@apple.com>
3524
3525         Reviewed by Simon Fraser.
3526
3527         Rename WebKitTools to Tools
3528         https://bugs.webkit.org/show_bug.cgi?id=49861
3529
3530         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3531         * CodeCoverage/README:
3532         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3533         (WebCore::DumpRenderTree::initializeFonts):
3534         * EWSTools/start-commit-queue.sh:
3535         * EWSTools/start-queue.sh:
3536         * GNUmakefile.am:
3537         * MIDLWrapper/MIDLWrapper.cpp:
3538         (wmain):
3539         * MiniBrowser/qt/MiniBrowser.pro:
3540         * Scripts/build-api-tests:
3541         * Scripts/build-dumprendertree:
3542         * Scripts/build-webkit:
3543         * Scripts/build-webkittestrunner:
3544         * Scripts/generate-coverage-data:
3545         * Scripts/old-run-webkit-tests:
3546         * Scripts/run-api-tests:
3547         * Scripts/run-iexploder-tests:
3548         * Scripts/run-javascriptcore-tests:
3549         * Scripts/run-mangleme-tests:
3550         * Scripts/run-sunspider:
3551         * Scripts/run-webkit-websocketserver:
3552         * Scripts/sunspider-compare-results:
3553         * Scripts/test-webkitperl:
3554         * Scripts/test-webkitpy:
3555         * Scripts/update-iexploder-cssproperties:
3556         * Scripts/update-webkit:
3557         * Scripts/update-webkit-localizable-strings:
3558         * Scripts/webkitdirs.pm:
3559         * Scripts/webkitpy/common/checkout/scm.py:
3560         * Scripts/webkitpy/common/checkout/scm_unittest.py:
3561         * Scripts/webkitpy/common/config/committervalidator.py:
3562         * Scripts/webkitpy/common/config/committervalidator_unittest.py:
3563         * Scripts/webkitpy/common/config/ports.py:
3564         * Scripts/webkitpy/common/config/ports_unittest.py:
3565         * Scripts/webkitpy/common/system/logutils_unittest.py:
3566         * Scripts/webkitpy/common/system/ospath_unittest.py:
3567         * Scripts/webkitpy/layout_tests/port/chromium.py:
3568         * Scripts/webkitpy/layout_tests/port/config.py:
3569         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
3570         * Scripts/webkitpy/layout_tests/port/http_server.py:
3571         * Scripts/webkitpy/layout_tests/port/test.py:
3572         * Scripts/webkitpy/style/checker.py:
3573         * Scripts/webkitpy/style/checker_unittest.py:
3574         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
3575         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3576         * Scripts/webkitpy/tool/steps/steps_unittest.py:
3577         * WebKitTestRunner/DerivedSources.pro:
3578         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
3579         (WTR::activateFonts):
3580         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3581         * wx/build/build_utils.py:
3582
3583 2010-12-16  Antonio Gomes  <agomes@rim.com>
3584
3585         Reviewed by Martin Robinson.
3586
3587         Settings::editingBehaviorType() incorrectly returns mac for the gtk build when running tests
3588         https://bugs.webkit.org/show_bug.cgi?id=51163
3589
3590         Since GTK+'s default editing behavior was changed to UNIX in r70975 (see webkitwebsettings.cpp),
3591         GTK+'s DRT should also reset to UNIX after each test execution.
3592
3593         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3594         (resetDefaultsToConsistentValues):
3595
3596 2010-12-17  David Levin  <levin@chromium.org>
3597
3598         Reviewed by Eric Seidel.
3599
3600         check-webkit-style should understand WTF #include guards
3601         https://bugs.webkit.org/show_bug.cgi?id=44911
3602
3603         * Scripts/webkitpy/style/checkers/cpp.py:
3604         (get_header_guard_cpp_variable): modify to suggest the WTF style
3605         of header guard when appropriate.
3606         (check_for_header_guard): handle multiple return values from
3607         get_header_guard_cpp_variable
3608         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3609         (CppStyleTest.test_build_header_guard): Added tests for the WTF
3610         header style.
3611
3612 2010-12-16  David Levin  <levin@chromium.org>
3613
3614         Reviewed by Eric Seidel.
3615
3616         test-webkitpy: unittest for the xml.py checker displays a decprecation warning.
3617         https://bugs.webkit.org/show_bug.cgi?id=51210
3618
3619         The error only shows up when using python 2.6 or later.
3620
3621         * Scripts/webkitpy/style/checkers/xml.py: Replace the usage of
3622         the decprecated field error,message with something equivalent.
3623
3624 2010-12-16  Mihai Parparita  <mihaip@chromium.org>
3625
3626         Reviewed by Eric Seidel.
3627
3628         Add --exit-after-n-failures/crashes to NRWT
3629         https://bugs.webkit.org/show_bug.cgi?id=51160
3630         
3631         Abort test run (in a similar way to how control-C is handled) when
3632         --exit-after-n-failures/crashes-or-timeouts are passed and we've reached
3633         that number of unexpected failures/crashes/timeouts.
3634
3635         * Scripts/webkitpy/layout_tests/port/test.py:
3636         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3637         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3638
3639 2010-12-16  David Levin  <levin@chromium.org>
3640
3641         Reviewed by Shinichiro Hamaji.
3642
3643         check-webkit-style unit tests has some duplicate boilerplate code.
3644         https://bugs.webkit.org/show_bug.cgi?id=49519
3645
3646         * Scripts/webkitpy/style/checkers/cpp.py:
3647         (update_include_state): Replaced the "io" parameter with the global
3648         configuration _unit_test_config. This allowed not calling into
3649         functions at a low level and also not plumbing through the injection
3650         information through many levels of code.
3651         (check_for_include_what_you_use): Ditto.
3652         (process_file_data): Added the ability to set up the unit test config
3653         to allow for injection.
3654         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3655         (ErrorCollector.__init__): Added support for having a filter for errors.
3656         (ErrorCollector.__call__): Ditto.
3657         (CppStyleTestBase.process_file_data): Added the ability to set unit_test_config.
3658         (CppStyleTestBase.perform_lint): Consolidated logic for the perform functions.
3659         (CppStyleTestBase.perform_single_line_lint): Replace specific calls to
3660         functions in the cpp.py with generic processing and a filter that
3661         indicates what errors should be kept.
3662         (CppStyleTestBase.perform_multi_line_lint): Ditto.
3663         (CppStyleTestBase.perform_language_rules_check): Ditto.
3664         (CppStyleTestBase.perform_function_lengths_check): Ditto.
3665         (CppStyleTestBase.perform_pass_ptr_check): Ditto.
3666         (CppStyleTestBase.perform_include_what_you_use): Ditto.
3667         (CppStyleTest.test_multi_line_comments): Added another
3668         error message which applies to the test case.
3669         (CppStyleTest.test_spacing_for_binary_ops): Fixed test
3670         to not have config.h, since it is processed as a header file.
3671         (CppStyleTest.test_static_or_global_stlstrings): Fixed variable name
3672         style and indentation in checked code.
3673         (OrderOfIncludesTest.test_check_preprocessor_in_include_section):
3674         Fixed line number.
3675         (NoNonVirtualDestructorsTest.test_multi_line_declaration_with_error):
3676         Ditto.
3677
3678 2010-12-15  Sheriff Bot  <webkit.review.bot@gmail.com>
3679
3680         Unreviewed, rolling out r74136.
3681         http://trac.webkit.org/changeset/74136
3682         https://bugs.webkit.org/show_bug.cgi?id=51135
3683
3684         r74136 breaks chromium canary bots because some tests are not
3685         rebaselined correctly to resolve EOL differences (Requested by
3686         jianli on #webkit).
3687
3688         * Scripts/webkitpy/layout_tests/port/base.py:
3689         * Scripts/webkitpy/layout_tests/port/test.py:
3690         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
3691
3692 2010-12-15  Adam Roben  <aroben@apple.com>
3693
3694         Teach check-webkit-style to check .vcproj and .vsprops files for XML
3695         syntax errors
3696
3697         Fixes <http://webkit.org/b/51103> check-webkit-style should check for
3698         XML syntax errors in .vcproj/.vsprops files
3699
3700         Reviewed by Dave Levin.
3701
3702         * Scripts/webkitpy/style/checker.py: Added lists of file extensions
3703         that should be treated as XML and that should be allowed to contain
3704         carriage returns. (These lists happen to be identical currently.)
3705         (FileType): Added a new XML type.
3706         (CheckerDispatcher.should_check_and_strip_carriage_returns): Added.
3707         Just does a simple file extension check.
3708         (CheckerDispatcher._file_type): Added a case for XML files.
3709         (CheckerDispatcher._create_checker): Ditto. We use XMLChecker for XML
3710         files (surprise!).
3711         (StyleProcessor.process): Ask the dispatcher whether we should pass the
3712         lines through the carriage checker.
3713
3714         * Scripts/webkitpy/style/checker_unittest.py:
3715         (CheckerDispatcherCarriageReturnTest.test_should_check_and_strip_carriage_returns):
3716         Added. Checks a few file names to see if carriage returns are allowed
3717         or not.
3718         (CheckerDispatcherDispatchTest.assert_checker_xml): Added. Similar to
3719         other assert_checker_* functions.
3720         (CheckerDispatcherDispatchTest.test_xml_paths): Added. Similar to other
3721         test_*_paths functions.
3722         (CheckerDispatcherDispatchTest.test_xml_paths): Added. Similar to other
3723         test_*_paths functions.
3724         (CheckerDispatcherDispatchTest.test_none_paths): Removed the vcproj
3725         file from this test case, as vcproj files now have a type.
3726         (StyleProcessor_CodeCoverageTest.MockDispatcher.should_check_and_strip_carriage_returns):
3727         Added. Similar to the other should_* functions.
3728         (StyleProcessor_CodeCoverageTest.test_process__carriage_returns_not_stripped):
3729         Added. Checks that carriage returns aren't checked for or stripped for
3730         allowed files.
3731
3732         * Scripts/webkitpy/style/checkers/xml.py: Added.
3733         (XMLChecker.__init__): Simple init method.
3734         (XMLChecker.check): Pass each line through the expat parser, and record
3735         a style error for any errors thrown by the parser.
3736
3737         * Scripts/webkitpy/style/checkers/xml_unittest.py: Added.
3738         (XMLCheckerTest.assert_no_error): Checks that the given XML does not
3739         produce a style error.
3740         (XMLCheckerTest.assert_error): Checks that the given XML produces an
3741         error of the given category on the given line.
3742         (XMLCheckerTest.mock_handle_style_error): Does nothing. Used for
3743         checking that the XMLChecker constructor works properly.
3744         (XMLCheckerTest.test_conflict_marker): Tests that conflict markers
3745         cause a style error (see, e.g., r73887).
3746         (XMLCheckerTest.test_extra_closing_tag): Tests that extra closing tags
3747         cause a style error (see, e.g., r73773).
3748         (XMLCheckerTest.test_init): Tests that the XMLChecker constructor works
3749         properly.
3750         (XMLCheckerTest.test_missing_closing_tag): Tests that missing closing
3751         tags cause a style error (see, e.g., r72795).
3752         (XMLCheckerTest.test_no_error): Tests that valid XML does not cause a
3753         style error.
3754
3755 2010-12-15  Lucas Forschler  <lforschler@apple.com>
3756
3757         Reviewed by Stephanie Lewis.
3758
3759         https://bugs.webkit.org/show_bug.cgi?id=51117
3760         Add a new leopard test bot
3761         really really commit to trunk this time.
3762
3763         * BuildSlaveSupport/build.webkit.org-config/config.json: