2011-01-19 Dirk Pranke <dpranke@chromium.org>
[WebKit.git] / Tools / ChangeLog
1 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2
3         Unreviewed, build fix.
4
5         Fix test failure caused by committing attachment 79368 instead
6         of attachment 79461 on bug 52604.
7
8         * Scripts/webkitpy/common/system/filesystem_mock.py:
9
10 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
11
12         Reviewed by Mihai Parparita.
13
14         new-run-webkit-tests: remove use of os.walk, use mock filesystem for better
15         unit testing. os.walk() is too much of a hassle to implement on
16         top of the in-memory mock filesystem and adding the necessary
17         interface to files_under() gives clients a cleaner API anyway
18         (for this particular usage model).
19
20         https://bugs.webkit.org/show_bug.cgi?id=52691
21
22         * Scripts/webkitpy/common/system/filesystem.py:
23         * Scripts/webkitpy/common/system/filesystem_mock.py:
24         * Scripts/webkitpy/layout_tests/port/test_files.py:
25         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
26
27 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
28
29         Reviewed by Tony Chang.
30
31         Change more modules in the layout-tests code to use the
32         filesystem wrapper for cleaner unit testing.
33
34         This patch also adds the glob() wrapper to the filesystem
35         abstraction.
36         
37         https://bugs.webkit.org/show_bug.cgi?id=52604
38
39         * Scripts/webkitpy/layout_tests/port/test_files.py:
40         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
41         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
42         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
43         * Scripts/webkitpy/common/system/filesystem.py:
44         * Scripts/webkitpy/common/system/filesystem_mock.py:
45
46 2011-01-19  Levi Weintraub  <leviw@chromium.org>
47
48         Unreviewed.
49
50         Updating my email addresses and irc nick.
51
52         * Scripts/webkitpy/common/config/committers.py:
53
54 2011-01-19  Tony Chang  <tony@chromium.org>
55
56         Reviewed by Mihai Parparita.
57
58         [chromium] [linux] if check-sys-deps fails, output the failure reason
59         https://bugs.webkit.org/show_bug.cgi?id=52671
60
61         * Scripts/webkitpy/common/system/executive_mock.py: Add support for
62             error handler functions.
63         * Scripts/webkitpy/layout_tests/port/chromium.py:
64             output the error text from --check-sys-deps
65         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
66
67 2011-01-19  Aparna Nandyal  <aparna.nand@wipro.com>
68
69         Reviewed by Andreas Kling.
70
71         [Qt] QtTestBrowser crashes when closing if Facebook is opened
72         https://bugs.webkit.org/show_bug.cgi?id=52554
73         
74         QtNetworkAccessManager is created in a thread and set as
75         member variable in QWebPage. When the thread is destroyed
76         the object is still used. So fix will set the object to
77         NULL once the thread is destroyed.
78
79         * QtTestBrowser/launcherwindow.cpp:
80         (LauncherWindow::~LauncherWindow):
81
82 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
83
84         Rubber stamped by Csaba Osztrogonac
85
86         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: Removed unncessary inculde of WKStringCF.h
87
88 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
89
90         Reviewed by Tony Chang.
91
92         new-run-webkit-tests: add a --build-directory command line argument
93
94         Official Google Chrome builds use a non-standard build directory
95         location. This patch adds a --build-directory argument that
96         allows that location to be specified on the command line. Only
97         Chromium-based builds will use this flag for now, but anyone can
98         in the future.
99
100         There are no unit tests for this since it's difficult to test
101         until mock filesystems are fully supported in the code. This was
102         tested by hand for now.
103
104         https://bugs.webkit.org/show_bug.cgi?id=52694
105
106         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
107         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
108         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
109         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
110
111 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
112
113         Not reviewed. Bot fix.
114
115         Remove an inadvertently committed debugging print.
116
117         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
118         (LayoutTestController::notifyDone):
119
120 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
121
122         Reviewed by Sam Weinig.
123
124         WebKitTestRunner should track loading more like DumpRenderTree
125         https://bugs.webkit.org/show_bug.cgi?id=52692
126
127         Change load tracking to track the current top loading frame, in the manner of DumpRenderTree.
128         This makes some tests that call notifyDone multiple times pass.
129         
130         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
131         (WTR::InjectedBundle::InjectedBundle):
132         (WTR::InjectedBundle::done):
133         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
134         (WTR::InjectedBundle::topLoadingFrame):
135         (WTR::InjectedBundle::setTopLoadingFrame):
136         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
137         (WTR::InjectedBundlePage::InjectedBundlePage):
138         (WTR::InjectedBundlePage::stopLoading):
139         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
140         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
141         (WTR::InjectedBundlePage::didFinishLoadForFrame):
142         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
143         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
144         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
145         (WTR::LayoutTestController::notifyDone):
146         * WebKitTestRunner/TestController.cpp:
147         (WTR::TestController::didReceiveMessageFromInjectedBundle):
148
149 2011-01-18  Mihai Parparita  <mihaip@chromium.org>
150
151         Reviewed by Kent Tamura.
152
153         [Chromium] NRWT looking for DRT binary in the wrong path on Mac
154         https://bugs.webkit.org/show_bug.cgi?id=52678
155         
156         Update path now that WebKit is inside Source.
157
158         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
159
160 2011-01-18  Robert Hogan  <robert@webkit.org>
161
162         Reviewed by Simon Hausmann.
163
164         [Qt] http/tests/incremental/slow-utf8-text.pl fails
165         https://bugs.webkit.org/show_bug.cgi?id=44282
166
167         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
168         (WebCore::DumpRenderTree::dump):
169
170 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
171
172         Reviewed by Mihai Parparita.
173
174         Fix a small race condition that could cause the unit tests for
175         new-run-webkit-tests to fail in a multithreaded environment.
176         There was a small window in the code where one thread would
177         check to see if a thread had raised an exception, do something,
178         and then check to see if the thread was alive. If the other
179         thread raised an exception and exited in between these two
180         steps, the exception would be lost. Flipping the order of the
181         two checks fixes the race, since we will now always check for an
182         exception on the thread before exiting.
183
184         https://bugs.webkit.org/show_bug.cgi?id=51579
185
186         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
187
188 2011-01-18  Eric Seidel  <eric@webkit.org>
189
190         Reviewed by Adam Barth.
191
192         commit-queue dies when test archiving fails
193         https://bugs.webkit.org/show_bug.cgi?id=52617
194
195         I looked at the machine and it had 10 archives already
196         thus find_unused_name was returning None.  I've upped
197         the limit to 100 (per bug) and tested the case where
198         find_unused_name returns None (making archive return None).
199
200         * Scripts/webkitpy/common/system/workspace.py:
201         * Scripts/webkitpy/common/system/workspace_unittest.py:
202         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
203         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
204         * Scripts/webkitpy/tool/commands/queues.py:
205
206 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
207
208         Reviewed by Ojan Vafai.
209
210         Update rebaseline-chromium-webkit-tests unit tests to use a mock
211         filesystem. Also fix a couple of "with" statements missed by
212         r76050.
213
214         https://bugs.webkit.org/show_bug.cgi?id=52487
215
216         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
217
218 2011-01-18  Sergio Villar Senin  <svillar@igalia.com>
219
220         Reviewed by Martin Robinson.
221
222         [Gtk] Build fixes for gtk3 build
223         https://bugs.webkit.org/show_bug.cgi?id=52648
224
225         * DumpRenderTree/gtk/EventSender.cpp:
226         (beginDragWithFilesCallback):
227
228 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
229
230         Reviewed by Mihai Parparita.
231
232         Update rebaseline-chromium-webkit-tests to use filesystem objects
233         instead of direct references to os.path, shutil, tempfile, etc.
234
235         This patch doesn't change anything, but will allow subsequent
236         patches to change the unit tests to no longer use the real
237         filesystem.
238
239         This patch adds a bunch more methods to the filesystem object as
240         well.
241
242         https://bugs.webkit.org/show_bug.cgi?id=52482
243
244         * Scripts/webkitpy/common/system/filesystem.py:
245         * Scripts/webkitpy/common/system/filesystem_mock.py:
246         * Scripts/webkitpy/tool/commands/queues.py:
247         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
248         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
249
250 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
251
252         Reviewed by Mihai Parparita.
253
254         new-run-webkit-tests shouldn't crash when you try to run a
255         directory containing only skipped files.
256
257         https://bugs.webkit.org/show_bug.cgi?id=52478
258         
259         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
260         * Scripts/webkitpy/layout_tests/port/test.py:
261         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
262
263 2011-01-18  Adam Bergkvist  <adam.bergkvist@ericsson.com> and Martin Robinson  <mrobinson@igalia.com>
264
265         Reviewed by Gustavo Noronha Silva.
266
267         [GTK] The GTK+ EventSender needs support for beginDragWithFiles
268         https://bugs.webkit.org/show_bug.cgi?id=40833
269
270         * DumpRenderTree/gtk/EventSender.cpp: Add a beginDragWithFiles implementation for the
271         GTK+ event sender.
272         (dragWithFilesDragDataGetCallback): Added.
273         (dragWithFilesDragEndCallback): Added.
274         (beginDragWithFilesCallback): Added.
275
276 2011-01-18  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
277
278         Reviewed by Adam Barth.
279
280         ews: Add additional watcher to efl ews
281         https://bugs.webkit.org/show_bug.cgi?id=52613
282
283         Add gyuyoung.kim@samsung.com to watcher list of efl-ews.
284
285         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
286
287 2011-01-17  Tony Gentilcore  <tonyg@chromium.org>
288
289         Reviewed by Alexey Proskuryakov.
290
291         Fix some headers with missing or misspelled #ifndef guards
292         https://bugs.webkit.org/show_bug.cgi?id=52545
293
294         * DumpRenderTree/chromium/TestEventPrinter.h:
295         * DumpRenderTree/chromium/WebPreferences.h:
296
297 2011-01-17  Jessie Berlin  <jberlin@apple.com>
298
299         Reviewed by Anders Carlsson.
300
301         REGRESSION: Assertion failure in FrameLoader::continueLoadAfterWillSubmitForm() when
302         navigating back to an unreachable URL
303         https://bugs.webkit.org/show_bug.cgi?id=52388
304
305         Add a third parameter (unreachableURL) to queueLoadHTMLString.
306
307         * DumpRenderTree/LayoutTestController.cpp:
308         (queueLoadHTMLStringCallback):
309         (LayoutTestController::queueLoadHTMLString):
310         (LayoutTestController::queueLoadAlternateHTMLString):
311         * DumpRenderTree/LayoutTestController.h:
312
313         * DumpRenderTree/WorkQueueItem.h:
314         (LoadHTMLStringItem::LoadHTMLStringItem):
315
316         * DumpRenderTree/chromium/LayoutTestController.cpp:
317         (WorkItemLoadHTMLString::WorkItemLoadHTMLString):
318         (WorkItemLoadHTMLString::run):
319         (LayoutTestController::queueLoadHTMLString):
320
321         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
322         (LoadHTMLStringItem::invoke):
323         * DumpRenderTree/mac/WorkQueueItemMac.mm:
324         (LoadHTMLStringItem::invoke):
325         * DumpRenderTree/win/WorkQueueItemWin.cpp:
326         (LoadHTMLStringItem::invoke):
327
328 2011-01-17  Dan Bernstein  <mitz@apple.com>
329
330         Rubber-stamped by Mark Rowe.
331
332         Update xcodeproj svn:ignore to include xcuserdata.
333
334         * DumpRenderTree/DumpRenderTree.xcodeproj: Modified property svn:ignore.
335         * MiniBrowser/MiniBrowser.xcodeproj: Modified property svn:ignore.
336         * TestWebKitAPI/TestWebKitAPI.xcodeproj: Modified property svn:ignore.
337         * WebKitLauncher/WebKitLauncher.xcodeproj: Modified property svn:ignore.
338         * WebKitTestRunner/WebKitTestRunner.xcodeproj: Modified property svn:ignore.
339
340 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
341
342         Unreviewed fix after r75908.
343
344         Move WebKit into Source
345         https://bugs.webkit.org/show_bug.cgi?id=52530
346
347         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add Source to the path for Qt API tests.
348
349 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
350
351         Unreviewed.
352
353         Remove accidentally committed debug printing after r75908.
354
355         * Scripts/webkitdirs.pm:
356
357 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
358
359         Unreviewed.
360
361         Add myself to committers list
362         https://bugs.webkit.org/show_bug.cgi?id=52566
363
364         * Scripts/webkitpy/common/config/committers.py:
365
366 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
367
368         Reviewed by Jeremy Orlow.
369
370         GeolocationController should call stopUpdating on destruction
371         https://bugs.webkit.org/show_bug.cgi?id=52216
372
373         fast/dom/Geolocation/window-close-crash.html requires that a
374         Geolocation watch be started in a secondary window. Consequently,
375         we need to allow geolocation permission and provide a mock
376         geolocation position for the secondary window's
377         GeolocationClientMock.
378
379         * DumpRenderTree/chromium/LayoutTestController.cpp:
380         (LayoutTestController::setGeolocationPermission):
381         (LayoutTestController::setMockGeolocationPosition):
382         (LayoutTestController::setMockGeolocationError):
383         * DumpRenderTree/chromium/TestShell.h:
384         (TestShell::windowList):
385
386 2011-01-16  Adam Barth  <abarth@webkit.org>
387
388         Update more include paths to reflect WebKit move.
389
390         * DumpRenderTree/chromium/EventSender.cpp:
391         (EventSender::keyDown):
392         (EventSender::needsShiftModifier):
393         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
394         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
395
396 2011-01-16  Kent Tamura  <tkent@chromium.org>
397
398         Unreviewed, Chromium build fix.
399
400         * Scripts/update-webkit-chromium: Webkit/chromium -> Source/WebKit/chromium
401
402 2011-01-16  Martin Robinson  <mrobinson@igalia.com>
403
404         Build fix for GTK+ after source directory movement.
405
406         * GNUmakefile.am: Correct include paths.
407
408 2011-01-16  Adam Barth  <abarth@webkit.org>
409
410         Teach svn-apply about WebKit move.
411
412         * Scripts/VCSUtils.pm:
413
414 2011-01-16  Adam Barth  <abarth@webkit.org>
415
416         Rubber-stamped by Eric Seidel.
417
418         Move WebKit into Source
419         https://bugs.webkit.org/show_bug.cgi?id=52530
420
421         * DumpRenderTree/mac/InternalHeaders/WebKit/WebTypesInternal.h:
422         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
423         * DumpRenderTree/qt/DumpRenderTreeQt.h:
424         * DumpRenderTree/qt/GCControllerQt.cpp:
425         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
426         * DumpRenderTree/qt/PlainTextControllerQt.cpp:
427         * DumpRenderTree/qt/TextInputControllerQt.cpp:
428         * DumpRenderTree/wscript:
429         * QtTestBrowser/launcherwindow.h:
430         * Scripts/build-webkit:
431         * Scripts/webkitdirs.pm:
432
433 2011-01-15  Adam Barth  <abarth@webkit.org>
434
435         Teach svn-apply about WebKit2 move.
436
437         * Scripts/VCSUtils.pm:
438
439 2011-01-15  Adam Barth  <abarth@webkit.org>
440
441         Rubber-stamped by Eric Seidel.
442
443         Move WebKit2 into Source
444         https://bugs.webkit.org/show_bug.cgi?id=52438
445
446         * MiniBrowser/qt/MiniBrowser.pro:
447         * Scripts/build-webkit:
448         * Scripts/do-file-rename:
449         * Scripts/do-webcore-rename:
450         * Scripts/test-webkitpy:
451         * Scripts/webkitdirs.pm:
452         * Scripts/webkitpy/style/checker.py:
453         * WebKitTestRunner/DerivedSources.pro:
454         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
455         * WebKitTestRunner/qt/WebKitTestRunner.pro:
456
457 2011-01-15  Jochen Eisinger  <jochen@chromium.org>
458
459         Reviewed by David Levin.
460
461         [chromium] remove obsolete createView method
462         https://bugs.webkit.org/show_bug.cgi?id=52437
463
464         * DumpRenderTree/chromium/WebViewHost.cpp:
465         (WebViewHost::createView):
466         * DumpRenderTree/chromium/WebViewHost.h:
467
468 2011-01-14  Brian Weinstein  <bweinstein@apple.com>
469
470         Reviewed by Geoff Garen.
471
472         ShouldLoadResourceForFrame should use strings, not URLs.
473         https://bugs.webkit.org/show_bug.cgi?id=52476
474
475         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
476         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Update to use a WKStringRef.
477         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
478
479 2011-01-14  Tony Gentilcore  <tonyg@chromium.org>
480
481         Reviewed by David Levin.
482
483         Add Tony Gentilcore as a reviewer
484         https://bugs.webkit.org/show_bug.cgi?id=52480
485
486         * Scripts/webkitpy/common/config/committers.py:
487
488 2011-01-14  David Levin  <levin@chromium.org>
489
490         Reviewed by Eric Seidel.
491
492         check-webkit-style: _FunctionState should keep track of where the function name starts.
493         https://bugs.webkit.org/show_bug.cgi?id=52454
494
495         * Scripts/webkitpy/style/checkers/cpp.py: Added function_name_start_position to
496         _FunctionState and logic for setting it correctly.
497         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests.
498
499 2011-01-14  Vincent Scheib  <scheib@chromium.org>
500
501         Reviewed by David Levin.
502
503         Add support to DumpRenderTree to use the GPU rather than software renderer
504         https://bugs.webkit.org/show_bug.cgi?id=52333
505
506         * DumpRenderTree/chromium/DumpRenderTree.cpp:
507         (main):
508         * Scripts/webkitpy/layout_tests/port/chromium.py:
509         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
510
511 2011-01-14  Tony Chang  <tony@chromium.org>
512
513         Reviewed by Kent Tamura.
514
515         [chromium] update fonts.conf to fix 6 linux tests in drt
516         https://bugs.webkit.org/show_bug.cgi?id=52411
517
518         * DumpRenderTree/chromium/fonts.conf: Update to match the copy in
519             chromium's src/webkit/tools/test_shell/resources/fonts.conf
520
521 2011-01-14  Eric Seidel  <eric@webkit.org>
522
523         Original patch from Peter Gal  <galpater@inf.u-szeged.hu>
524
525         Reviewed by Adam Barth.
526
527         Fix when running Tools/Scripts/check-webkit-style without arguments.
528         https://bugs.webkit.org/show_bug.cgi?id=52261#c16
529
530         * Scripts/webkitpy/common/checkout/scm.py: Handle None for changed_files argument better in Git.create_patch method.
531         * Scripts/webkitpy/common/checkout/scm_unittest.py:
532
533 2011-01-04  Jochen Eisinger  <jochen@chromium.org>
534
535         Reviewed by David Levin.
536
537         Store the tempdir object in a variable so it doesn't get deleted too early.
538         https://bugs.webkit.org/show_bug.cgi?id=51875
539
540         * Scripts/update-webkit-auxiliary-libs:
541         * Scripts/update-webkit-support-libs:
542
543 2011-01-14  Eric Seidel  <eric@webkit.org>
544
545         Unreviewed.  Make it work in python 2.5.
546
547         webkit-patch suggest-reviewers dies when ChangeLogs are missing
548         https://bugs.webkit.org/show_bug.cgi?id=49158
549
550         * Scripts/webkitpy/common/checkout/api_unittest.py:
551
552 2011-01-14  Sheriff Bot  <webkit.review.bot@gmail.com>
553
554         Unreviewed, rolling out r75774.
555         http://trac.webkit.org/changeset/75774
556         https://bugs.webkit.org/show_bug.cgi?id=52431
557
558         gtk builds were broken (Requested by loislo2 on #webkit).
559
560         * Scripts/webkitpy/common/checkout/scm.py:
561
562 2011-01-14  David Levin  <levin@chromium.org>
563
564         Reviewed by Shinichiro Hamaji.
565
566         check-webkit-style: _FunctionState should detect pure functions.
567         https://bugs.webkit.org/show_bug.cgi?id=52428
568
569         * Scripts/webkitpy/style/checkers/cpp.py: Added detection for if a function declaration
570         is a pure virtual function.
571         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests for verifying that pure
572         virtual functions are correctly detected.
573
574 2011-01-13  Ilya Tikhonovsky  <loislo@chromium.org>
575
576         Reviewed by Yury Semikhatsky.
577
578         Just small fix for problem with check-webkit-style.
579         It just didn't work for this patch.
580         Old code can't concatenate a list of strings with None.
581
582         * Scripts/webkitpy/common/checkout/scm.py:
583
584 2011-01-13  David Levin  <levin@chromium.org>
585
586         Reviewed by Shinichiro Hamaji.
587
588         check-webkit-style: _FunctionState should use Position to know where items are.
589         https://bugs.webkit.org/show_bug.cgi?id=52424
590
591         * Scripts/webkitpy/style/checkers/cpp.py:
592         (_FunctionState.*): Changed _FunctionState to use Position instead of line numbers.
593         (detect_functions): Changed to pass Position's to _FunctionState.begin and
594         did some minor clean-up.
595         (*): Other changes are simply about converting to use the Position's in_FunctionState
596         instead of line numbers.
597         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Changed the test code
598         to verify the positions stored in _FunctionState.
599
600 2011-01-13  Eric Seidel  <eric@webkit.org>
601
602         Reviewed by David Levin.
603
604         webkit-patch suggest-reviewers dies when ChangeLogs are missing
605         https://bugs.webkit.org/show_bug.cgi?id=49158
606
607         This is not the most elegant, but it is a very safe fix to this bug.
608         One advantage of catching ScriptError like this instead of adding a
609         new added_or_modified_files or fixing all changed_files callers
610         to use a more specific change_files variant, is that we catch
611         all kinds of ScriptErrors which might cause our (non-essential)
612         suggest-reviewers code to fail out.  This should make passing
613         --suggest-reviewers to webkit-patch upload much more robust
614         and may even make it possible for us to make it default.
615
616         The root of the problem here is that SCM.changed_files includes
617         deleted ChangeLog paths (from moves, etc) which then when we ask
618         SVN/Git for the contents of the file at that revision, the command
619         errors out and Executive.run_command raises a ScriptError.
620
621         In the future we might fix this differently by making all current
622         callers of chagned_files use a more specific method for requesting
623         what types of changes they're interested in (adds, modifies, deletes, etc.)
624
625         * Scripts/webkitpy/common/checkout/api.py:
626         * Scripts/webkitpy/common/checkout/api_unittest.py:
627
628 2011-01-13  Dan Bernstein  <mitz@apple.com>
629
630         Reviewed by Alexey Proskuryakov.
631
632         <rdar://problem/8827065> REGRESSION (r71884): Cross-origin XHR fails if willSendRequest changes the URL
633         https://bugs.webkit.org/show_bug.cgi?id=52419
634
635         Allow to further control the behavior of the willSendRequest delegate callback by making it
636         set a different URL in the new request.
637
638         * DumpRenderTree/LayoutTestController.cpp:
639         (addURLToRedirectCallback): Added.
640         (LayoutTestController::staticFunctions): Added addURLToRedirect.
641         (LayoutTestController::addURLToRedirect): Added. Adds the redirection to the map.
642         (LayoutTestController::redirectionDestinationForURL): Added this getter.
643         * DumpRenderTree/LayoutTestController.h:
644         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
645         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]): Check
646         if there is a redirection for the request’s URL, established by addURLToRedirect(), and if so,
647         change the URL in the new request to the redirect destination.
648
649 2011-01-13  Eric Seidel  <eric@webkit.org>
650
651         Reviewed by Mihai Parparita.
652
653         webkit-patch suggest-reviewers fails due to invalid utf8 in ChangeLog files
654         https://bugs.webkit.org/show_bug.cgi?id=52416
655
656         Example: webkit-patch suggest-reviewers -g ca3890fe74d94d85d6bfa48f9ea497b094d8e717 
657         UnicodeDecodeError: 'utf8' codec can't decode bytes in position 536-538: invalid data
658
659         I also added FIXMEs about the changed_files returning deleted files problem
660         which is causing the other most common exception for suggest-reviewers
661         (and is probably breaking sheriff-bots blame detection).
662
663         * Scripts/webkitpy/common/checkout/api.py:
664         * Scripts/webkitpy/common/checkout/api_unittest.py:
665         * Scripts/webkitpy/common/checkout/scm.py:
666
667 2011-01-13  Eric Seidel  <eric@webkit.org>
668
669         Reviewed by Adam Barth.
670
671         results archives from commit-queue are too large to upload
672         https://bugs.webkit.org/show_bug.cgi?id=52405
673
674         * Scripts/webkitpy/common/system/filesystem.py:
675         * Scripts/webkitpy/common/system/filesystem_mock.py:
676         * Scripts/webkitpy/tool/commands/queues.py:
677
678 2011-01-13  Alejandro G. Castro  <alex@igalia.com>
679
680         Reviewed by Martin Robinson.
681
682         [gtk] Zero-sized font does not yet work
683         https://bugs.webkit.org/show_bug.cgi?id=49793
684
685         Set minimum-font-size to 0 for the DRT.
686
687         * DumpRenderTree/gtk/DumpRenderTree.cpp:
688         (resetDefaultsToConsistentValues):
689
690 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
691
692         Reviewed by Darin Adler.
693
694         Make old-run-webkit-tests more robust on buildbots
695         https://bugs.webkit.org/show_bug.cgi?id=52364
696
697         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Pass --exit-after-n-failures 500 to old-run-webkit-tests script.
698
699 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
700
701         Reviewed by Darin Adler.
702
703         Make old-run-webkit-tests more robust on buildbots
704         https://bugs.webkit.org/show_bug.cgi?id=52364
705
706         * Scripts/old-run-webkit-tests: Ensure that testResultsDirectory is empty.
707
708 2011-01-13  Tony Chang  <tony@chromium.org>
709
710         Reviewed by Kent Tamura.
711
712         [chromium] fix plugins/plugin-javascript-access.html on Linux and Mac
713         https://bugs.webkit.org/show_bug.cgi?id=52332
714
715         Forked Info.plist is not longer needed.
716
717         * DumpRenderTree/chromium/TestNetscapePlugIn/Info.plist: Removed.
718
719 2011-01-13  Mikhail Naganov  <mnaganov@chromium.org>
720
721         Reviewed by Timothy Hatcher.
722
723         Web Inspector: Cleanup after r75613 -- make all UI-facing strings
724         to be passed directly to WebInspector.UIString
725
726         https://bugs.webkit.org/show_bug.cgi?id=52365
727
728         * Scripts/check-inspector-strings:
729
730 2011-01-13  Sheriff Bot  <webkit.review.bot@gmail.com>
731
732         Unreviewed, rolling out r74881.
733         http://trac.webkit.org/changeset/74881
734         https://bugs.webkit.org/show_bug.cgi?id=52357
735
736         The EFL builder has been red for days (Requested by abarth on
737         #webkit).
738
739         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
740         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
741
742 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
743
744         Reviewed by David Levin.
745
746         Add beforeunload support to WebKitTestRunner
747         https://bugs.webkit.org/show_bug.cgi?id=52353
748         
749         This makes a number of currently failing tests pass.
750
751         * WebKitTestRunner/TestController.cpp:
752         (WTR::runBeforeUnloadConfirmPanel):
753         (WTR::createOtherPage):
754         (WTR::TestController::initialize):
755
756 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
757
758         Reviewed by Sam Weinig.
759
760         Detect, identify and recover from WebProcess crashes in run-webkit-tests
761         https://bugs.webkit.org/show_bug.cgi?id=52330
762
763         * Scripts/old-run-webkit-tests: Detect when the regression test tool reports
764         a web process crash.
765         * WebKitTestRunner/TestController.cpp:
766         (WTR::TestController::initialize): Set up a processDidCrash
767         callback.
768         (WTR::TestController::processDidCrash): Report that the Web process
769         crashed.
770         * WebKitTestRunner/TestController.h:
771
772 2011-01-12  David Levin  <levin@chromium.org>
773
774         Reviewed by Shinichiro Hamaji.
775
776         check-webkit-style -- close_expression function doesn't work correctly.
777         https://bugs.webkit.org/show_bug.cgi?id=52272
778
779         * Scripts/webkitpy/style/checkers/cpp.py:
780         (Position.__str__): Added a way to convert it to a string which is useful in tests.
781         (Position.__cmp__): Added a way to compare Position which is useful in tests and
782         generally useful (for upcoming code changes).
783         (close_expression): Changed to use Position for input and output.
784         Also, fixed many bugs such as only working correctly for parenthesis,
785         not working correctly if given an offset in a line and not finding
786         the real closing element if there were multiple closing elements in
787         the same line.
788         (detect_functions): Adjusted due to the change in arguments for
789         close_expression.
790         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
791         (CppStyleTestBase.assert_positions_equal): Added a way to verify that
792         two positions are the same.
793         (CppStyleTest.test_position): Added tests for the __str_ and __cmp__ methods.
794         (CppStyleTest.test_close_expression): Added tests to catch the issues
795         that were fixed.
796
797 2011-01-12  Sheriff Bot  <webkit.review.bot@gmail.com>
798
799         Unreviewed, rolling out r75576.
800         http://trac.webkit.org/changeset/75576
801         https://bugs.webkit.org/show_bug.cgi?id=52304
802
803         broke rebaseline-chromium-webkit-test (Requested by thakis on
804         #webkit).
805
806         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
807         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
808         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
809         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
810         * Scripts/webkitpy/layout_tests/port/base.py:
811         * Scripts/webkitpy/layout_tests/port/chromium.py:
812         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
813         * Scripts/webkitpy/layout_tests/port/test.py:
814         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
815         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
816         * Scripts/webkitpy/style/checkers/test_expectations.py:
817         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
818
819 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
820
821         Reviewed by Darin Adler.
822
823         Add a no-build option to run-webkit-tests, to avoid building DRT/WKTR
824         https://bugs.webkit.org/show_bug.cgi?id=52307
825
826         * Scripts/old-run-webkit-tests:
827
828 2011-01-12  Koan-Sin Tan  <koansin.tan@gmail.com>
829
830         Reviewed by Martin Robinson.
831
832         [Gtk] WebKitGtk+ doesn't build on Mac OS X 10.6
833         https://bugs.webkit.org/show_bug.cgi?id=50867
834
835         Fixed library extention for Mac in webkitdirs.pm and type conflict in
836         TestNetscapePlugin.cpp 
837
838         * GNUmakefile.am: Don't use AppKit when compiling TestNetscapePlugin for GTK+
839         * Scripts/webkitdirs.pm:
840
841 2011-01-12  Mikhail Naganov  <mnaganov@chromium.org>
842
843         Reviewed by Pavel Feldman.
844
845         Add check-inspector-strings script.
846
847         https://bugs.webkit.org/show_bug.cgi?id=52295
848
849         * Scripts/check-inspector-strings: Added.
850
851 2011-01-12  Adam Roben  <aroben@apple.com>
852
853         Advertise the .testnetscape file extension on Windows
854
855         Fixes <http://webkit.org/b/52298>
856         plugins/no-mime-with-valid-extension.html fails on Windows
857
858         Reviewed by Dan Bernstein.
859
860         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Added a
861         FileExtents field to map the .testnetscape file extension to the
862         application/x-webkit-test-netscape MIME type, just as we do on Mac.
863
864 2011-01-12  Adam Barth  <abarth@webkit.org>
865
866         Reviewed by Eric Seidel.
867
868         Make webkit-patch support subdirectories for SVN checkouts
869         https://bugs.webkit.org/show_bug.cgi?id=52261
870
871         os.relpath does not exist on Python 2.5, so we need to call our version
872         of the API.
873
874         * Scripts/webkitpy/common/checkout/scm.py:
875
876 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
877
878         Reviewed by Eric Seidel.
879
880         Close additional pages opened during a test once the test completes.
881         https://bugs.webkit.org/show_bug.cgi?id=52276
882
883         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
884         (WTR::InjectedBundle::done):
885
886 2011-01-11  David Levin  <levin@chromium.org>
887
888         Reviewed by Eric Seidel.
889
890         Errors should be separated from the command line in bot messages.
891         https://bugs.webkit.org/show_bug.cgi?id=52275
892
893         * Scripts/webkitpy/common/system/executive.py:
894         (ScriptError.message_with_output): Added a newline to separate the command
895         line from the errors.
896         * Scripts/webkitpy/common/system/executive_unittest.py:
897         (ScriptErrorTest.test_message_with_output): Added tests for the various code
898         paths in message_with_output.
899
900 2011-01-11  Eric Seidel  <eric@webkit.org>
901
902         Unreviewed.
903
904         commit-queue should know how to upload archived results (for test flakes or general failures)
905         https://bugs.webkit.org/show_bug.cgi?id=52048
906
907         The zips are mostly empty due to forgetting -r.
908         Expected diffs were not being pulled from the archive due
909         to the archive having longer paths than I realized.
910
911         * Scripts/webkitpy/common/system/workspace.py:
912         * Scripts/webkitpy/common/system/workspace_unittest.py:
913         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
914         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
915
916 2011-01-11  Dirk Pranke  <dpranke@chromium.org>
917
918         Reviewed by Ojan Vafai.
919
920         The current modifier parsing code in test_expectations is
921         fragile and hard-coded, so it's not easy to understand the logic
922         or easily add new types of modifiers (like GPU vs. CPU testing
923         for graphics tests, or 32-bit vs. 64-bit differences).
924
925         This is the first of two patches that will add in more generic
926         support and then eliminate the GPU-specific test expectations
927         files for Chromium.
928
929         This patch adds two standalone objects for handling modifiers. The
930         rules for interpreting modifiers, precedence, and conflicts are
931         given in the docstring to the ModifierMatcher class, which
932         returns ModifierMatchResult objects.
933         
934         This patch also adds routines to the Port interface and a
935         default set of values in the base object, in order to obtain the
936         values needed on a given test run. These values are then passed
937         to the expectation parser. This also allows us to clean up the
938         logic used to lint all of the different configurations in a
939         single test_expectations.txt file.
940
941         The next patch will merge in the separate GPU expectations file.
942
943         https://bugs.webkit.org/show_bug.cgi?id=51222
944
945         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
946         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
947         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
948         * Scripts/webkitpy/layout_tests/port/base.py:
949         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
950         * Scripts/webkitpy/layout_tests/port/chromium.py:
951         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
952         * Scripts/webkitpy/layout_tests/port/test.py:
953         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
954         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
955
956 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
957
958         Reviewed by Adam Barth.
959
960         Make webkit-patch support subdirectories for SVN checkouts
961         https://bugs.webkit.org/show_bug.cgi?id=52261
962
963         * Scripts/webkitpy/common/checkout/scm.py:
964         * Scripts/webkitpy/style_references.py:
965         * Scripts/webkitpy/tool/main.py:
966         * Scripts/webkitpy/tool/steps/preparechangelog.py:
967
968 2011-01-11  Eric Seidel  <eric@webkit.org>
969
970         Unreviewed.
971
972         commit-queue should know how to upload archived results (for test flakes or general failures)
973         https://bugs.webkit.org/show_bug.cgi?id=52048
974
975         I changed the API for archive_last_layout_test_results w/o updating the implementation.  Oops.
976         This fixes an exception seen on the commit-queue when attempting to report flaky tests.
977
978         * Scripts/webkitpy/common/system/workspace.py:
979         * Scripts/webkitpy/common/system/workspace_unittest.py:
980         * Scripts/webkitpy/tool/commands/queues.py:
981
982 2011-01-11  Sam Weinig  <sam@webkit.org>
983
984         Roll r75474 back in.
985
986 2011-01-11  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
987
988         Reviewed by Kenneth Rohde Christiansen.
989
990         [Qt] Remove uses of QFuture since it isn't supported on all platforms.
991         https://bugs.webkit.org/show_bug.cgi?id=51204
992
993         * QtTestBrowser/webpage.h:
994         (QtNAMThread::QtNAMThread):
995         (QtNAMThread::networkAccessManager):
996         (QtNAMThread::run):
997
998 2011-01-11  Peter Varga  <pvarga@webkit.org>
999
1000         Unreviewed.
1001
1002         Add myself to committers' list.
1003
1004         * Scripts/webkitpy/common/config/committers.py:
1005
1006 2011-01-11  Eric Seidel  <eric@webkit.org>
1007
1008         Reviewed by Adam Barth.
1009
1010         commit-queue should know how to upload archived results (for test flakes or general failures)
1011         https://bugs.webkit.org/show_bug.cgi?id=52048
1012
1013         Now the queue will always upload results.  Either the entire zip, or just
1014         the diffs.txt in the case of text failures.
1015
1016         This should make understanding flakes much easier, and paves the way
1017         for having the EWS run layout tests (and upload failures).
1018
1019         In order to upload .zip files I had to teach bugzilla.py to autodetect
1020         mime types from the filename.  Since mimetypes.py doesn't include a mapping
1021         for .patch files, I have it add one before calling guess_type.
1022
1023         We may find that always uploading the whole zip instead of just the -diffs.txt
1024         file is preferable, but for now I'm keeping the old behavior because it makes
1025         quickly understanding text failures easy.
1026
1027         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1028         * Scripts/webkitpy/common/system/workspace.py: Added.
1029         * Scripts/webkitpy/common/system/workspace_unittest.py: Added.
1030         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1031         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1032         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1033         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1034         * Scripts/webkitpy/tool/commands/queues.py:
1035         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1036
1037 2011-01-10  Sheriff Bot  <webkit.review.bot@gmail.com>
1038
1039         Unreviewed, rolling out r75464.
1040         http://trac.webkit.org/changeset/75464
1041         https://bugs.webkit.org/show_bug.cgi?id=52193
1042
1043         Followup rollout for 75474 (Requested by Ossy on #webkit).
1044
1045         * MiniBrowser/mac/BrowserWindowController.m:
1046         (-[BrowserWindowController awakeFromNib]):
1047         * MiniBrowser/win/BrowserView.cpp:
1048         (BrowserView::create):
1049         * WebKitTestRunner/TestController.cpp:
1050         (WTR::createOtherPage):
1051         (WTR::TestController::initialize):
1052
1053 2011-01-10  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1054
1055         Reviewed by Csaba Osztrogonác.
1056
1057         [Qt] Baseline qt_minimal configuration
1058         https://bugs.webkit.org/show_bug.cgi?id=51313
1059
1060         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1061         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): Add
1062         QT_NO_UNDOSTACK guard.
1063
1064         * QtTestBrowser/launcherwindow.cpp:
1065         (LauncherWindow::createChrome): Add QT_NO_SHORTCUT and QT_NO_PRINTER
1066         guards.
1067         (LauncherWindow::applyZoom): Add QT_NO_ANIMATION guard.
1068         (LauncherWindow::screenshot): Add QT_NO_FILEDIALOG guard.
1069         (LauncherWindow::selectElements): Add QT_NO_INPUTDIALOG guard.
1070         (LauncherWindow::showUserAgentDialog): Add QT_NO_COMBOBOX guard.
1071
1072         * QtTestBrowser/launcherwindow.h:
1073         * QtTestBrowser/locationedit.cpp: Add QT_NO_INPUTDIALOG guard.
1074         * QtTestBrowser/locationedit.h: Ditto.
1075
1076         * QtTestBrowser/mainwindow.cpp:
1077         (MainWindow::buildUI): Add QT_NO_INPUTDIALOG, QT_NO_SHORTCUT and
1078         QT_NO_UNDOSTACK guards.
1079         (MainWindow::setAddressUrl): Add QT_NO_INPUTDIALOG guard.
1080         (MainWindow::changeLocation): Ditto.
1081         (MainWindow::openFile): Add QT_NO_FILEDIALOG guard.
1082         (MainWindow::openLocation): Add QT_NO_INPUTDIALOG guard.
1083
1084         * QtTestBrowser/webpage.cpp:
1085         (WebPage::openUrlInDefaultBrowser): Add QT_NO_DESKTOPSERVICES guard.
1086         (WebPage::authenticationRequired): Add QT_NO_LINEEDIT guard.
1087
1088         * QtTestBrowser/webview.cpp:
1089         (WebViewGraphicsBased::animatedFlip): Add QT_NO_ANIMATION guard.
1090         (WebViewGraphicsBased::animatedYFlip): Ditto.
1091
1092 2011-01-10  Sam Weinig  <sam@webkit.org>
1093
1094         Fix build.
1095
1096         * MiniBrowser/mac/BrowserWindowController.m:
1097         (-[BrowserWindowController awakeFromNib]):
1098         * MiniBrowser/win/BrowserView.cpp:
1099         (BrowserView::create):
1100         * WebKitTestRunner/TestController.cpp:
1101         (WTR::createOtherPage):
1102         (WTR::TestController::initialize):
1103
1104 2011-01-10  Eric Seidel  <eric@webkit.org>
1105
1106         Reviewed by Ojan Vafai.
1107
1108         style-queue messages are way too long for big patches
1109         https://bugs.webkit.org/show_bug.cgi?id=52161
1110
1111         We definitely could build much fancier list-to-string-with-limit functions
1112         but this should be sufficient for our needs at the moment.
1113
1114         * Scripts/webkitpy/common/system/executive.py:
1115         * Scripts/webkitpy/common/system/executive_unittest.py:
1116
1117 2011-01-10  Tony Chang  <tony@chromium.org>
1118
1119         Unreviewed, rolling out r75398.
1120         http://trac.webkit.org/changeset/75398
1121         https://bugs.webkit.org/show_bug.cgi?id=52008
1122
1123         Some layout tests are crashing on Chromium Win.
1124
1125         * DumpRenderTree/chromium/WebViewHost.cpp:
1126         (WebViewHost::updatePaintRect):
1127         * DumpRenderTree/chromium/WebViewHost.h:
1128
1129 2011-01-10  Adam Roben  <aroben@apple.com>
1130
1131         Roll out r75392
1132
1133         It isn't needed now that r75289 has been rolled out.
1134
1135         * Scripts/run-javascriptcore-tests:
1136
1137 2011-01-10  Maciej Stachowiak  <mjs@apple.com>
1138
1139         Reviewed by Anders Carlsson.
1140
1141         WebKitTestRunner uses crazy amounts of CPU, making layout tests slow and flaky
1142         https://bugs.webkit.org/show_bug.cgi?id=52160
1143
1144         * WebKitTestRunner/mac/TestControllerMac.mm:
1145         (WTR::TestController::platformRunUntil): Instead of busy-looping, wait for the timeout.
1146         Anything that can make runUntil() conditions turn true will happen on a run loop cycle
1147         anyway.
1148
1149 2011-01-10  Tony Chang  <tony@chromium.org>
1150
1151         Reviewed by Mihai Parparita.
1152
1153         [chromium] fix for animated gif layout tests
1154         https://bugs.webkit.org/show_bug.cgi?id=52008
1155
1156         * DumpRenderTree/chromium/WebViewHost.cpp: Schedule a paint when we update the paint rect
1157             to trigger gif animations.
1158         (WebViewHostPaintTask::WebViewHostPaintTask):
1159         (WebViewHostPaintTask::runIfValid):
1160         (WebViewHost::updatePaintRect):
1161         * DumpRenderTree/chromium/WebViewHost.h:
1162         (WebViewHost::taskList):
1163
1164 2011-01-10  Alejandro G. Castro  <alex@igalia.com>
1165
1166         Reviewed by Xan Lopez.
1167
1168         [GTK] Fix gtk2 compilation for master
1169         https://bugs.webkit.org/show_bug.cgi?id=51885
1170
1171         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
1172         (createBitmapContextFromWebView): Replaced the old
1173         gdk_drawable_get_size with gdk_pixmap_get_size.
1174
1175 2011-01-10  Patrick Gansterer  <paroga@webkit.org>
1176
1177         Reviewed by Laszlo Gombos.
1178
1179         [WINCE] Reenable NPAPI after r75203
1180         https://bugs.webkit.org/show_bug.cgi?id=52109
1181
1182         Remove the !isWinCE() check for ENABLE_NETSCAPE_PLUGIN_API and replace
1183         it with !isEfl(), because EFL port does not support NPAPI (yet).
1184
1185         * Scripts/build-webkit:
1186
1187 2011-01-10  Adam Roben  <aroben@apple.com>
1188
1189         Skip some asserting JS tests
1190
1191         See <http://webkit.org/b/52156>.
1192
1193         * Scripts/run-javascriptcore-tests:
1194
1195 2011-01-10  Martin Robinson  <mrobinson@igalia.com>
1196
1197         Reviewed by Xan Lopez.
1198
1199         [GTK] build-webkit disable Blob support via arguments passed to automake
1200         https://bugs.webkit.org/show_bug.cgi?id=52097
1201
1202         * Scripts/build-webkit: Enable Blob support when building WebKitGTK+ via
1203         build-webkit.
1204
1205 2011-01-10  Adam Roben  <aroben@apple.com>
1206
1207         Use the same name and description for TestNetscapePlugin on Windows and
1208         Mac
1209
1210         Fixes <http://webkit.org/b/52151>
1211         fast/frames/iframe-reparenting-plugins.html fails on Windows
1212
1213         Reviewed by Steve Falkenburg.
1214
1215         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Copied
1216         the name and description from Mac's Info.plist.
1217
1218 2011-01-10  Siddharth Mathur <siddharth.mathur@nokia.com>
1219
1220         Reviewed by Laszlo Gombos.
1221
1222         [Qt][WK2] Guard gcc-specific syntax
1223
1224         Non-gcc based compliers choke on the "-include"
1225         syntax for preinclude, place guard around it.
1226
1227         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1228         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1229
1230 2011-01-10  Andreas Kling  <kling@webkit.org>
1231
1232         Reviewed by Simon Hausmann.
1233
1234         [Qt] [WK2] MiniBrowser does not load pages opened in new windows
1235         https://bugs.webkit.org/show_bug.cgi?id=52111
1236
1237         When getting a createNewPage() callback from QWKPage, create the
1238         new page with the same QWKContext as the page that is passed to
1239         the callback.
1240
1241         * MiniBrowser/qt/BrowserView.h:
1242         * MiniBrowser/qt/BrowserWindow.cpp:
1243         (newPageFunction):
1244         (BrowserWindow::BrowserWindow):
1245         * MiniBrowser/qt/BrowserWindow.h:
1246
1247 2011-01-10  Andreas Kling  <kling@webkit.org>
1248
1249         Reviewed by Kenneth Rohde Christiansen.
1250
1251         [Qt] MiniBrowser: Remove superfluous createNewPage() callback
1252
1253         BrowserView set its own useless createNewPage() callback on QWKPage.
1254         This was immediately overridden by BrowserWindow anyway, so remove
1255         the BrowserView one.
1256
1257         * MiniBrowser/qt/BrowserView.cpp:
1258         (BrowserView::BrowserView):
1259
1260 2011-01-10  John Knottenbelt  <jknotten@chromium.org>
1261
1262         Reviewed by Jeremy Orlow.
1263
1264         [Chromium] Remove non-client-based Geolocation code
1265         https://bugs.webkit.org/show_bug.cgi?id=50921
1266
1267         * DumpRenderTree/chromium/LayoutTestController.cpp:
1268         (LayoutTestController::setGeolocationPermission):
1269         (LayoutTestController::setMockGeolocationPosition):
1270         (LayoutTestController::setMockGeolocationError):
1271         * DumpRenderTree/chromium/WebViewHost.cpp:
1272         (WebViewHost::geolocationClientMock):
1273         (WebViewHost::reset):
1274         * DumpRenderTree/chromium/WebViewHost.h:
1275
1276 2011-01-10  Eric Seidel  <eric@webkit.org>
1277
1278         Reviewed by Adam Barth.
1279
1280         Commit bot tried to land r? cq+ patch
1281         https://bugs.webkit.org/show_bug.cgi?id=36638
1282
1283         It should now be possible to post a patch with r? and cq+ and the
1284         commit-queue will correctly wait for the r+ before attempting to land the patch.
1285         (This was a feature requested by several users.)
1286
1287         One caveat: We don't actually reject r-, cq+ patches from the queue
1288         (we just ignore them), but I think that's OK for now.
1289
1290         I also noticed that setting r- once a commit-queue node had grabbed
1291         a patch would not properly cancel the landing.  That's fixed and
1292         tested in this patch.
1293
1294         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1295         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1296         * Scripts/webkitpy/tool/bot/feeders.py:
1297         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
1298
1299 2011-01-08  Benjamin Poulain  <benjamin.poulain@nokia.com>
1300
1301         Reviewed by Kenneth Rohde Christiansen.
1302
1303         [Qt] QtWebKit crashes when using XMLHttpRequest from the unload event
1304         https://bugs.webkit.org/show_bug.cgi?id=51934
1305
1306         When accessing the network from the destructor of QWebPage, the network access manager
1307         was already deleted because the object WebPage was already destructed.
1308
1309         This solve the problem by linking the lifetime of the network access manager to WebPage's QObject.
1310         The object is now destructed in the destructor of QObject.
1311
1312         * QtTestBrowser/webpage.cpp:
1313         (WebPage::WebPage):
1314         (WebPage::setQnamThreaded):
1315         * QtTestBrowser/webpage.h:
1316         (QtNAMThread::QtNAMThread):
1317
1318 2011-01-08  Eric Seidel  <eric@webkit.org>
1319
1320         Reviewed by Ojan Vafai.
1321
1322         test_failures.py should not mention TestShell (long live DumpRenderTree!)
1323         https://bugs.webkit.org/show_bug.cgi?id=52067
1324
1325         I ran test-webkitpy, but didn't bother adding a unit test for this string change.
1326         https://bugs.webkit.org/show_bug.cgi?id=51138#c3 is an example of why this is needed.
1327
1328         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1329
1330 2011-01-08  Eric Seidel  <eric@webkit.org>
1331
1332         Reviewed by Mihai Parparita.
1333
1334         commit-queue hangs when the ChangeLog diff is bad
1335         https://bugs.webkit.org/show_bug.cgi?id=52072
1336
1337         * Scripts/webkitpy/tool/steps/validatechangelogs.py:
1338         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
1339
1340 2011-01-08  Adam Barth  <abarth@webkit.org>
1341
1342         Teach svn-apply how to re-write WebCore to Source/WebCore.
1343
1344         * Scripts/VCSUtils.pm:
1345
1346 2011-01-07  Adam Barth  <abarth@webkit.org>
1347
1348         Rubber-stamped by Eric Seidel.
1349
1350         Move WebCore to Source
1351         https://bugs.webkit.org/show_bug.cgi?id=52050
1352
1353         Update the tools to understand WebCore's new location.
1354
1355         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1356         * DumpRenderTree/wscript:
1357         * GNUmakefile.am:
1358         * Scripts/build-webkit:
1359         * Scripts/do-file-rename:
1360         * Scripts/do-webcore-rename:
1361         * Scripts/generate-qt-inspector-resource:
1362         * Scripts/prepare-ChangeLog:
1363         * Scripts/run-bindings-tests:
1364         * Scripts/update-iexploder-cssproperties:
1365         * Scripts/update-sources-list.py:
1366         * Scripts/update-webkit-localizable-strings:
1367         * Scripts/webkitdirs.pm:
1368         * Scripts/webkitpy/common/config/build.py:
1369         * Scripts/webkitpy/common/config/build_unittest.py:
1370         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
1371         * Scripts/webkitpy/style/checker.py:
1372         * Scripts/webkitpy/style/checker_unittest.py:
1373         * WebKitTestRunner/DerivedSources.pro:
1374         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1375         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh:
1376         * wx/browser/wscript:
1377         * wx/build/settings.py:
1378
1379 2011-01-07  Maciej Stachowiak  <mjs@apple.com>
1380
1381         Reviewed by Sam Weinig.
1382
1383         Make WebKitTestRunner rest between loads more robust to avoid test crashes
1384         https://bugs.webkit.org/show_bug.cgi?id=52086
1385
1386         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1387         (WTR::InjectedBundle::didReceiveMessage):
1388         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1389         (WTR::LayoutTestController::notifyDone):
1390         * WebKitTestRunner/TestController.cpp:
1391         (WTR::TestController::resetStateToConsistentValues):
1392         (WTR::TestController::run):
1393
1394 2011-01-07  James Robinson  <jamesr@chromium.org>
1395
1396         Revert "Implement mozilla's animationTime property"
1397         https://bugs.webkit.org/show_bug.cgi?id=51952
1398
1399         This approach isn't quite right.
1400
1401         * DumpRenderTree/chromium/WebViewHost.cpp:
1402         (WebViewHost::paintInvalidatedRegion):
1403
1404 2011-01-07  Adam Roben  <aroben@apple.com>
1405
1406         Build master fix
1407
1408         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1409         (RunWebKitTests.start): Don't try to concatenate a list and a string.
1410
1411 2011-01-07  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>
1412
1413         Reviewed by Csaba Osztrogonác.
1414
1415         run-qtwebkit-tests should be able to kill a testsuite.
1416
1417         Add new option in the script that can setup a timeout for a test.
1418         If the test execution takes more then specified time then the test
1419         would be terminated.
1420
1421         [Qt] run-qtwebkit-tests needs timeout
1422         https://bugs.webkit.org/show_bug.cgi?id=51894
1423
1424         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1425         * Scripts/run-qtwebkit-tests:
1426
1427 2011-01-07  Csaba Osztrogonác  <ossy@webkit.org>
1428
1429         Unreviewed fix after r75233.
1430
1431         Based on idea from Eric Seidel.
1432
1433         Add remote zip file handling to webkitpy.
1434         https://bugs.webkit.org/show_bug.cgi?id=50901
1435
1436         * Scripts/webkitpy/common/system/fileset.py: Make python 2.5 happy.
1437
1438 2011-01-07  Shane Stephens  <shanestephens@google.com>
1439
1440         Reviewed by Eric Seidel.
1441
1442         svn-apply: should support git binary delta diffs
1443         https://bugs.webkit.org/show_bug.cgi?id=38864
1444
1445         * Scripts/VCSUtils.pm:
1446         * Scripts/svn-apply:
1447
1448 2011-01-06  Julie Parent  <jparent@chromium.org>
1449
1450         Reviewed by Eric Seidel.
1451
1452         Test Result Server not removing old results.
1453         https://bugs.webkit.org/show_bug.cgi?id=52012
1454
1455         * TestResultServer/model/jsonresults.py:
1456         Fix off-by-one: Truncate if >= num_runs, not just >.
1457         * TestResultServer/model/jsonresults_unittest.py:
1458         Add unit test to test that merging in a new result with the same value
1459         as the last result causes previous result to fall off.
1460
1461 2011-01-06  James Kozianski  <koz@chromium.org>
1462
1463         Reviewed by Mihai Parparita.
1464
1465         Add classes to provide a consistent interface to a set of files.
1466         https://bugs.webkit.org/show_bug.cgi?id=50901
1467
1468         These classes allow us to write code that is agnostic to whether a
1469         particular set of files resides in a local directory or in a zip file
1470         on a remote machine.
1471
1472         * Scripts/webkitpy/common/system/directoryfileset.py: Added.
1473         * Scripts/webkitpy/common/system/directoryfileset_unittest.py: Added.
1474         * Scripts/webkitpy/common/system/fileset.py: Added.
1475         * Scripts/webkitpy/common/system/filesystem.py:
1476         * Scripts/webkitpy/common/system/filesystem_mock.py:
1477         * Scripts/webkitpy/common/system/zipfileset.py: Added.
1478         * Scripts/webkitpy/common/system/zipfileset_unittest.py: Added.
1479
1480 2011-01-06  Eric Seidel  <eric@webkit.org>
1481
1482         Reviewed by Adam Barth.
1483
1484         NetworkTransaction should log the url it is retrying
1485         https://bugs.webkit.org/show_bug.cgi?id=52043
1486
1487         * Scripts/webkitpy/common/net/networktransaction.py:
1488         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
1489
1490 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
1491
1492         Windows build fix.
1493         Import os before using it.
1494
1495         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1496
1497 2011-01-06  Eric Seidel  <eric@webkit.org>
1498
1499         Reviewed by Adam Barth.
1500
1501         StyleQueue fails to report errors when patches have many files
1502         https://bugs.webkit.org/show_bug.cgi?id=52042
1503
1504         This is one of at least two errors preventing style error reporting at the moment.
1505         When we moved to passing the list of files to check explicitly,
1506         we started to exceed the 500 character TEXT field limit for our AppEngine model object.
1507         We could change the type of the QueueStatus.message type, or we could
1508         just teach statusserver.py how to clamp values (and warn when it does).
1509         I chose the latter path.
1510
1511         * Scripts/webkitpy/common/net/statusserver.py:
1512
1513 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
1514
1515         Reviewed by Stephanie Lewis.
1516         
1517         Fix syntax error in script.
1518
1519         Windows bots need to archive/unarchive builds to/from configuration-specific directories
1520         https://bugs.webkit.org/show_bug.cgi?id=51996
1521
1522         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1523
1524 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1525
1526         Unreviewed, fixing WinCE build after r75196.
1527
1528         WinCE port does not (yet) support NPAPI.
1529
1530         * Scripts/build-webkit:
1531
1532 2011-01-06  Xan Lopez  <xlopez@igalia.com>
1533
1534         Reviewed by Darin Adler.
1535
1536         File::Spec->rel2abs in sunspider-compare-results mangles parameters
1537         https://bugs.webkit.org/show_bug.cgi?id=52015
1538
1539         * Scripts/sunspider-compare-results: call rel2abs on our arguments
1540         after the platform has been detected, otherwise the script will
1541         mangle things like '--gtk' into '/a/path/--gtk', breaking the
1542         detection.
1543
1544 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1545
1546         Reviewed by Eric Seidel.
1547
1548         Add ENABLE_NETSCAPE_PLUGIN_API, ENABLE_ORIENTATION_EVENTS and ENABLE_TOUCH_EVENTS flags to build-webkit
1549         https://bugs.webkit.org/show_bug.cgi?id=51346
1550
1551         * Scripts/build-webkit:
1552
1553 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
1554
1555         Reviewed by Adam Roben.
1556
1557         Windows bots need to archive/unarchive builds to/from configuration-specific directories
1558         https://bugs.webkit.org/show_bug.cgi?id=51996
1559         
1560         After the configuration directory change, we were archiving the incorrect directory for
1561         build product, so we were running tests on the wrong binaries.
1562         
1563         This change archives the correct directory, and also unarchives it into a configuration-
1564         specific directory.
1565
1566         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Use a configuration-specific directory on Windows.
1567         * BuildSlaveSupport/built-product-archive: Unarchive/archive to/from proper directory.
1568
1569 2011-01-06  Eric Seidel  <eric@webkit.org>
1570
1571         Reviewed by Mihai Parparita.
1572
1573         commit-queue mentions "Text diff mismatch" 4 times instead of once per failure
1574         https://bugs.webkit.org/show_bug.cgi?id=52002
1575
1576         See an example of this here:
1577         https://bugs.webkit.org/show_bug.cgi?id=51314#c2
1578
1579         It's due to the fact that we pass around TestFailure() instance
1580         objects and yet expect them to all compare to be the same.
1581
1582         This is bad.  We should either have shared instances of these values
1583         or we should just pass around the class names.  There are already hacks
1584         in place to make TestFailure objects pass equality tests, I just added
1585         a __hash__ implementation so they can be used in sets as expected.
1586
1587         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1588         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1589
1590 2011-01-06  Evan Martin  <evan@chromium.org>
1591
1592         Reviewed by Tony Chang.
1593
1594         [gdb] handle inaccessible memory and UChar*
1595         https://bugs.webkit.org/show_bug.cgi?id=52003
1596
1597         To pretty-print a UChar*, we just grope around in the memory
1598         looking for a terminating NUL.  We need to handle the exception
1599         that can occur when we poke into an invalid location.
1600
1601         Additionally, the logic for choosing which pretty-printer would
1602         early return before hitting the point where we'd use the UChar*
1603         printer.  (Did this ever work?  How did it regress?)
1604
1605         * gdb/webkit.py:
1606
1607 2011-01-05  Brian Weinstein  <bweinstein@apple.com>
1608
1609         Reviewed by Ada Chan.
1610
1611         WebKit2: Should be able to call into injected bundle to ask if we should allow resource loads
1612         https://bugs.webkit.org/show_bug.cgi?id=51969
1613         
1614         Add shouldLoadResourceForFrame to WTR::InjectedBundlePage.
1615
1616         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1617         (WTR::InjectedBundlePage::InjectedBundlePage):
1618         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Stub implementation.
1619         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1620
1621 2011-01-06  James Robinson  <jamesr@chromium.org>
1622
1623         Reviewed by Simon Fraser.
1624
1625         Implement mozilla's animationTime property
1626         https://bugs.webkit.org/show_bug.cgi?id=51952
1627
1628         Chromium DRT support for webkitAnimationTime.
1629
1630         * DumpRenderTree/chromium/WebViewHost.cpp:
1631         (WebViewHost::paintInvalidatedRegion):
1632
1633 2011-01-06  Julie Parent  <jparent@chromium.org>
1634
1635         Reviewed by Tony Chang.
1636
1637         Test Result Server always truncates number of results to JSON_RESULTS_MAX_BUILDS
1638         https://bugs.webkit.org/show_bug.cgi?id=51217
1639
1640         * TestResultServer/model/jsonresults.py:
1641         Pass num_runs through to _remove_items_over_max_number_of_builds, and use the value.
1642         Adds missing documentation.
1643         * TestResultServer/model/jsonresults_unittest.py:
1644         Add unit test to test that truncation happens at smaller value than JSON_RESULTS_MAX_BUILDS.
1645         Update test_merge to take a number of builds to truncate at.
1646
1647 2011-01-06  Adam Barth  <abarth@webkit.org>
1648
1649         Reviewed by Eric Seidel.
1650
1651         The EWS should log outside of the working directory
1652         https://bugs.webkit.org/show_bug.cgi?id=51986
1653
1654         This patch prepare us for using git clean -x -d -f in the EWS wrapper
1655         script, which will actually clean the working copy back to a pristine
1656         state instead of leaving untracked directories and ignored files.
1657
1658         * Scripts/webkitpy/tool/commands/queues.py:
1659         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1660
1661 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
1662
1663         Windows build fix.
1664         Back out attempted change to built-product-archive.
1665
1666         * BuildSlaveSupport/built-product-archive:
1667
1668 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
1669
1670         Windows build fix.
1671         Include configuration name when unpacking a build archive.
1672
1673         Needed, since we split Windows build results into configuration-specific directories
1674         under WebKitOutputDir.
1675
1676         * BuildSlaveSupport/built-product-archive:
1677
1678 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
1679
1680         Reviewed by Darin Adler.
1681
1682         Debug and Release builds on Windows clobber each other
1683         https://bugs.webkit.org/show_bug.cgi?id=49185
1684
1685         Changes the structure of WebKitBuild build products directory so we
1686         completely separate each build configuration into independent directories.
1687         
1688         Although we previously had per-configuration directories for obj, this change adds
1689         per-configuration directories for bin, lib, obj, and include. Each configuration's
1690         build products are stored within a directory inside of WebKitBuild.
1691         
1692         Most use of $(WebKitOutputDir) in the build files has been replaced by $(ConfigurationBuildDir),
1693         defined in common.vsprops to be $(WebKitOutputDir)\$(ConfigurationName).
1694
1695         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops:
1696         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd:
1697         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd:
1698         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
1699         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd:
1700         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd:
1701         * DumpRenderTree/win/ImageDiffCommon.vsprops:
1702         * DumpRenderTree/win/ImageDiffPostBuild.cmd:
1703         * DumpRenderTree/win/ImageDiffPreBuild.cmd:
1704         * FindSafari/FindSafari.vcproj:
1705         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
1706         * MiniBrowser/MiniBrowserPostBuild.cmd:
1707         * MiniBrowser/MiniBrowserPreBuild.cmd:
1708         * Scripts/webkitdirs.pm:
1709         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
1710         * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops:
1711         * TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd:
1712         * TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd:
1713         * TestWebKitAPI/win/copy-resources.cmd:
1714         * WebKitAPITest/WebKitAPITestCommon.vsprops:
1715         * WebKitAPITest/WebKitAPITestPostBuild.cmd:
1716         * WebKitAPITest/WebKitAPITestPreBuild.cmd:
1717         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
1718         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
1719         * WebKitTestRunner/win/InjectedBundle.vcproj:
1720         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops:
1721         * WebKitTestRunner/win/InjectedBundlePostBuild.cmd:
1722         * WebKitTestRunner/win/InjectedBundlePreBuild.cmd:
1723         * WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd:
1724         * WebKitTestRunner/win/WebKitTestRunnerPreBuild.cmd:
1725         * WinLauncher/WinLauncherCommon.vsprops:
1726         * WinLauncher/WinLauncherPostBuild.cmd:
1727         * WinLauncher/WinLauncherPreBuild.cmd:
1728
1729 2011-01-05  Jan Erik Hanssen  <jhanssen@sencha.com>
1730
1731         Reviewed by Ariya Hidayat.
1732
1733         [Qt] TestNetscapePlugin doesn't link on OS X
1734         https://bugs.webkit.org/show_bug.cgi?id=51948
1735
1736         Only add a dependency on libX11 on X11 systems
1737
1738         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1739
1740 2011-01-05  Jeff Miller  <jeffm@apple.com>
1741
1742         Reviewed by Adam Roben.
1743
1744         check-webkit-style should allow unnecessary parameter names in WebKit2 APIs because we're matching CF's header style
1745         https://bugs.webkit.org/show_bug.cgi?id=51970
1746
1747         * Scripts/webkitpy/style/checker.py:
1748         Add -readability/naming for WebKit2 C API directories.
1749
1750 2011-01-05  Eric Seidel  <eric@webkit.org>
1751
1752         Unreviewed, just fixing one more log error from my previous python patch.
1753
1754         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
1755         https://bugs.webkit.org/show_bug.cgi?id=51802
1756
1757         webkit-patch failure-reason was logging about parsing errors
1758         due to my misunderstanding of how BeautifulSoup.findAll worked.
1759
1760         Fixed, and added a unit test.
1761
1762         * Scripts/webkitpy/common/net/layouttestresults.py:
1763         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1764
1765 2011-01-05  Benjamin Poulain  <benjamin.poulain@nokia.com>
1766
1767         Reviewed by Kenneth Rohde Christiansen.
1768
1769         [Qt] [WK2] Add the possibility to open window from the WebProcess in Minibrowser
1770         https://bugs.webkit.org/show_bug.cgi?id=51951
1771
1772         Set a function to QWKPage::setCreateNewPageFunction() in Minibrowser so there is a way
1773         to create new window from WebKit.
1774
1775         * MiniBrowser/qt/BrowserWindow.cpp:
1776         (newPageFunction):
1777         (BrowserWindow::BrowserWindow):
1778         (BrowserWindow::page): Added to avoid the indirect access to QWKPage spread in the class
1779         (BrowserWindow::newWindow):
1780         (BrowserWindow::updateUserAgentList):
1781         (BrowserWindow::showUserAgentDialog):
1782         * MiniBrowser/qt/BrowserWindow.h: Add the global variable backingStoreTypeForNewWindow to
1783         define the type of the backing store used for new windows.
1784         * MiniBrowser/qt/main.cpp:
1785         (main):
1786
1787 2011-01-05  Eric Seidel  <eric@webkit.org>
1788
1789         Reviewed by Ojan Vafai.
1790
1791         commit-queue should report failure type when reporting flaky tests
1792         https://bugs.webkit.org/show_bug.cgi?id=51900
1793
1794         This patch was a ridiculous amount of plumbing.  In the end I like
1795         the NRWT-style TestResult class even less.  But now we're passing
1796         a list of TestResult objects from the queue to the FlakyTestReporter.
1797         Thus the FlakyTestReporter can more easily report what type of failure
1798         occurred.
1799
1800         In the process, I found that I was not alone in finding TestResult
1801         cumbersome to use.  A bunch of code was trying to create a TestResult
1802         object with default values.  However since the constructor didn't make
1803         this easy, some places were getting it wrong (including the TestResult unit test)!
1804         I've fixed the TestResult constructor to have default values for non-essential
1805         arguments.
1806
1807         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1808         * Scripts/webkitpy/common/net/layouttestresults.py:
1809         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1810         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1811         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1812         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1813         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
1814         * Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py:
1815         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1816         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1817         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1818         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1819         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1820         * Scripts/webkitpy/tool/commands/queues.py:
1821         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1822
1823 2011-01-05  Eric Seidel  <eric@webkit.org>
1824
1825         Unreviewed.
1826
1827         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
1828         https://bugs.webkit.org/show_bug.cgi?id=51802
1829
1830         Add another unit test to cover a previously missing import.
1831
1832         * Scripts/webkitpy/common/net/layouttestresults.py:
1833         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1834
1835 2011-01-05  Mihai Parparita  <mihaip@chromium.org>
1836
1837         Reviewed by David Levin.
1838
1839         Add mihaip@chromium.org as a reviewer
1840         https://bugs.webkit.org/show_bug.cgi?id=51966
1841         
1842         Add myself as a reviewer.
1843
1844         * Scripts/webkitpy/common/config/committers.py:
1845
1846 2011-01-05  James Simonsen  <simonjam@chromium.org>
1847
1848         Unreviewed. Adding myself to the list of committers.
1849
1850         * Scripts/webkitpy/common/config/committers.py:
1851
1852 2011-01-05  Eric Seidel  <eric@webkit.org>
1853
1854         Unreviewed.
1855
1856         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
1857         https://bugs.webkit.org/show_bug.cgi?id=51802
1858
1859         Fix two exceptions seen on the bots after my original commit.
1860
1861         * Scripts/webkitpy/common/net/layouttestresults.py:
1862         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1863
1864 2011-01-05  Kundu Suchismita  <suchi.kundu@nokia.com>
1865
1866         Reviewed by Andreas Kling.
1867
1868         [Qt]Add local storage settings to QtTestBrowser command line arguments 
1869         https://bugs.webkit.org/show_bug.cgi?id=51750
1870
1871         * QtTestBrowser/main.cpp:
1872         (LauncherApplication::handleUserOptions):
1873          Local storage settings can be enable form command line arguments for
1874          QtTestBrowser.
1875
1876 2011-01-05  Chris Fleizach  <cfleizach@apple.com>
1877
1878         Reviewed by Martin Robinson.
1879
1880         GTK: AX: DRT needs to use correct root object method.
1881         https://bugs.webkit.org/show_bug.cgi?id=51911
1882
1883         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
1884         (AccessibilityController::rootElement):
1885
1886 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
1887
1888         Rubber-stamped by Csaba Osztrogonác.
1889
1890         Based on idea from Péter Gál.
1891
1892         * Scripts/webkitpy/tool/bot/sheriff.py: Remove unnecessary apostrophes around revision numbers.
1893
1894 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
1895
1896         Reviewed by Adam Barth.
1897
1898         sheriff-bot should be able to do multi-revision rollouts
1899         https://bugs.webkit.org/show_bug.cgi?id=51176
1900
1901         * Scripts/webkitpy/tool/bot/irc_command.py:
1902         * Scripts/webkitpy/tool/bot/sheriff.py:
1903         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
1904
1905 2011-01-05  Eric Seidel  <eric@webkit.org>
1906
1907         Reviewed by Adam Barth.
1908
1909         queues.webkit.org should have per-bot status pages
1910         https://bugs.webkit.org/show_bug.cgi?id=51906
1911
1912         Just adds a /queue-status/QUEUE_NAME/bots/BOT_ID page to show
1913         statuses from a single queue.  Now that we have many bots servicing
1914         some queues (commit-queue, win-ews, etc.) its easy to have the messages
1915         you care about scroll off the end of the 15-message limit on the main page.
1916
1917         Eventually we should probably rename /queue-status to /queue or /queues,
1918         but that's fodder for another patch.
1919
1920         * QueueStatusServer/handlers/queuestatus.py:
1921         * QueueStatusServer/index.yaml:
1922         * QueueStatusServer/main.py:
1923         * QueueStatusServer/templates/includes/singlequeuestatus.html:
1924          - This probably should use a custom filter instead of hard-coding
1925            the URL scheme here, but I couldn't figure out how to easily
1926            create such a filter.  Most filters work with "strings" so we can't
1927            pass the status object.  We could add a method to the status
1928            object and call that, but that seemed a bit strange too.
1929         * QueueStatusServer/templates/queuestatus.html:
1930
1931 2011-01-05  Carlos Garcia Campos  <cgarcia@igalia.com>
1932
1933         Unreviewed. Adding myself to the list of committers.
1934
1935         * Scripts/webkitpy/common/config/committers.py:
1936
1937 2011-01-04  Koan-Sin Tan  <koansin.tan@gmail.com>
1938
1939         Reviewed by David Levin.
1940
1941         check-webkit-style treated some macros with parentheses after #elif as function calls
1942         https://bugs.webkit.org/show_bug.cgi?id=51695
1943
1944         Ingore function call space checking in any preprocessor directives
1945         (things starting with #). Change search() to match() because 
1946         preprocessor directives are supposed to be in the beginning of lines.
1947
1948         * Scripts/webkitpy/style/checkers/cpp.py:
1949         * Scripts/webkitpy/style/checkers/cpp_unittest.py: make sure there is no false positives for #elif cases
1950
1951 2011-01-04  Søren Gjesse  <sgjesse@chromium.org>
1952
1953         Reviewed by Tony Chang.
1954
1955         Change the --multi-load test option to --stress-opt
1956         https://bugs.webkit.org/show_bug.cgi?id=50751
1957
1958         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1959         (runTest):
1960         (main):
1961         * DumpRenderTree/chromium/TestShell.cpp:
1962         (TestShell::TestShell):
1963         * DumpRenderTree/chromium/TestShell.h:
1964         (TestShell::stressOpt):
1965         (TestShell::setStressOpt):
1966         (TestShell::stressDeopt):
1967         (TestShell::setStressDeopt):
1968         (TestShell::javaScriptFlags):
1969         (TestShell::setJavaScriptFlags):
1970         * Scripts/webkitpy/layout_tests/port/chromium.py:
1971         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1972
1973 2011-01-04  Chris Fleizach  <cfleizach@apple.com>
1974
1975         Reviewed by Sam Weinig.
1976
1977         WK2: Support Accessibility
1978         https://bugs.webkit.org/show_bug.cgi?id=51859
1979
1980         Use rootObject() method to get top of accessibility tree.
1981
1982         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
1983         (AccessibilityController::focusedElement):
1984         (AccessibilityController::rootElement):
1985
1986 2011-01-03  Martin Robinson  <mrobinson@igalia.com>
1987
1988         Reviewed by Darin Adler.
1989
1990         Remove the last non-GObject usage of PlatformRefPtr and move the code to GRefPtr
1991         https://bugs.webkit.org/show_bug.cgi?id=51846
1992
1993         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: Change usage of PlatformRefPtr
1994         back to GRefPtr.
1995
1996 2011-01-04  Zhe Su  <suzhe@chromium.org>
1997
1998         Reviewed by Kenneth Russell.
1999
2000         Fix insertText, setMarkedText and unmarkText methods of
2001         TextInputController to call corresponding methods of WebKit::WebView
2002         rather than WebKit::WebFrame. This change matches the behavior of
2003         chromium browser.
2004         insertText corresponds to WebView::confirmComposition(text)
2005         setMarkedText corresponds to WebView::setComposition(...)
2006         unmarkText corresponds to WebView::confirmComposition()
2007         https://bugs.webkit.org/show_bug.cgi?id=51693
2008
2009         * DumpRenderTree/chromium/TextInputController.cpp:
2010         (TextInputController::insertText):
2011         (TextInputController::setMarkedText):
2012         (TextInputController::unmarkText):
2013
2014 2011-01-04  Dihan Wickremasuriya  <dihan.wickremasuriya@nokia.com>
2015
2016         Reviewed by Laszlo Gombos.
2017
2018         [Qt] [Symbian] Do not remove 0 byte sized files from productDir
2019
2020         On Symbian productDir points to the source directory. Removing all the
2021         empty files from the productDir directory corrupts the svn repository.
2022
2023         * Scripts/build-webkit:
2024
2025 2011-01-03  Yi Shen  <yi.4.shen@nokia.com>
2026
2027         Reviewed by Adam Barth.
2028
2029         [Qt] Add SelectAll option to the context menu for the editor
2030         https://bugs.webkit.org/show_bug.cgi?id=50049
2031
2032         Set shortcut for the SelectAll action.
2033
2034         * QtTestBrowser/mainwindow.cpp:
2035         (MainWindow::buildUI):
2036
2037 2011-01-03  David Levin  <levin@chromium.org>
2038
2039         Reviewed by Eric Seidel.
2040
2041         check-webkit-style shouldn't consider "value" automatically to be a meaningless name.
2042         https://bugs.webkit.org/show_bug.cgi?id=51842
2043
2044         * Scripts/webkitpy/style/checkers/cpp.py: Remove the check for value.
2045         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Remove the test for value.
2046
2047 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
2048
2049         Reviewed by David Kilzer.
2050
2051         [WINCE] Adds a build slave.
2052         https://bugs.webkit.org/show_bug.cgi?id=50523
2053
2054         * BuildSlaveSupport/build.webkit.org-config/config.json: Add an
2055         entry for a release build of the WinCE port.
2056         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add platform
2057         flag to build the WinCE port.
2058
2059 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
2060
2061         Reviewed by David Kilzer.
2062
2063         Add WinCE support to build-webkit
2064         https://bugs.webkit.org/show_bug.cgi?id=51642
2065
2066         * Scripts/build-webkit:
2067         * Scripts/webkitdirs.pm:
2068
2069 2011-01-03  Eric Seidel  <eric@webkit.org>
2070
2071         Reviewed by Adam Barth.
2072
2073         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
2074         https://bugs.webkit.org/show_bug.cgi?id=51802
2075
2076         I'm not the biggest fan of the test_failures or test_results classes,
2077         but it's better to have one shared set of classes, than separate ones
2078         for new vs. old run-webkit-test result handling.
2079
2080         This moves the ORWT results class "LayoutTestResults" over to using
2081         TestResult and TestFailure classes, making it easy for us to
2082         make all our sheriff-bot and other webkitpy code NRWT ready.
2083
2084         This also makes it a trivial patch to generate results.json information
2085         from ORWT results.html files (for flaky test analysis, etc.) as well
2086         as making it a one-liner to report test failure types when the
2087         commit-queue sees flaky tests.
2088
2089         This patch tried not to add new functionality, but only to replace
2090         the guts of LayoutTestResults, while adding unit tests and hoping
2091         not to break anything.
2092
2093         I also moved callers which assumed User.prompt* were static/class methods
2094         to using them as instance methods (since we'll eventually want to make them such).
2095
2096         In the process of re-writing things, I broke the rebaseline command, so I wrote
2097         a unit test to catch my breakage were I do do so again in the future.
2098
2099         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2100         * Scripts/webkitpy/common/net/layouttestresults.py:
2101         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2102         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
2103         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
2104         * Scripts/webkitpy/tool/commands/queries.py:
2105         * Scripts/webkitpy/tool/commands/rebaseline.py:
2106         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2107         * Scripts/webkitpy/tool/mocktool.py:
2108
2109 2011-01-03  Adam Barth  <abarth@webkit.org>
2110
2111         Reviewed by Simon Fraser.
2112
2113         webkit-patch shouldn't waste time cleaning a working directory that's already clean
2114         https://bugs.webkit.org/show_bug.cgi?id=51840
2115
2116         * Scripts/webkitpy/common/checkout/scm.py:
2117
2118 2011-01-03  Adam Barth  <abarth@webkit.org>
2119
2120         Reviewed by Simon Fraser.
2121
2122         webkit-patch should only hide update output if --quiet
2123         https://bugs.webkit.org/show_bug.cgi?id=51838
2124
2125         As requested by smfr.
2126
2127         * Scripts/webkitpy/tool/steps/update.py:
2128
2129 2011-01-03  Adam Barth  <abarth@webkit.org>
2130
2131         Reviewed by David Levin.
2132
2133         commit-queue shouldn't reject patches twice if two bots process the same patch
2134         https://bugs.webkit.org/show_bug.cgi?id=51805
2135
2136         Before raising an error, we first check whether the patch is still in
2137         the commit-queue.  This check is still racy, of course, but the time
2138         window is much smaller.
2139
2140         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2141
2142 2011-01-03  Sam Weinig  <sam@webkit.org>
2143
2144         Reviewed by Anders Carlsson.
2145
2146         Make run-api-tests less chatty.
2147         https://bugs.webkit.org/show_bug.cgi?id=51831
2148
2149         - Make script quiet by default and add --verbose option (replacing --quiet).
2150         - When not verbose, pipe stdout and stderr to devnull.
2151
2152         * Scripts/run-api-tests:
2153
2154 2011-01-03  Pratik Solanki  <psolanki@apple.com>
2155
2156         Unreviewed. Adding myself to committers.py.
2157
2158         * Scripts/webkitpy/common/config/committers.py:
2159
2160 2011-01-03  Koan-Sin Tan  <koansin.tan@gmail.com>
2161
2162         Reviewed by Xan Lopez.
2163
2164         "Tool/Scripts/run-launcher --gtk" stopped working after 74855
2165         https://bugs.webkit.org/show_bug.cgi?id=51806
2166
2167         Originally, the $libraryName is 'JavaScriptCore'. When building release 
2168         one, the $libraryDir was 'WebKitBuild/Release/JavaScriptCore/../.libs/'
2169         which doesn't exist anymore ('WebKitBuild/Release/JavaScriptCore'
2170         is 'WebKitBuild/Release/Source/JavaScriptCore' now), and 
2171         'WebKitBuild/Release/Source/JavaScriptCore/../../.libs' looks weird,
2172         so make it 'WebKitBuild/Release/.libs'
2173
2174         * Scripts/webkitdirs.pm: 
2175
2176 2011-01-02  Patrick Gansterer  <paroga@webkit.org>
2177
2178         Reviewed by Adam Barth.
2179
2180         Make EFL a core builder
2181         https://bugs.webkit.org/show_bug.cgi?id=51804
2182
2183         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2184         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2185
2186 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
2187
2188         [Qt] Unreviewed fix after r74855 and r74875.
2189
2190         * BuildSlaveSupport/built-product-archive:
2191          - Create directories explicitly.
2192          - Pass shell=True to subprocess.call().
2193
2194 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
2195
2196         [Qt] Unreviewed fix after r74855.
2197
2198         Move JavaScriptCore to Source
2199         https://bugs.webkit.org/show_bug.cgi?id=51604
2200
2201         * BuildSlaveSupport/built-product-archive: JavaScriptCore -> Source/JavaScriptCore
2202
2203 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
2204
2205         [Qt] Unreviewed run-javasriptcore-tests fix after r74855.
2206
2207         Move JavaScriptCore to Source
2208         https://bugs.webkit.org/show_bug.cgi?id=51604
2209
2210         * Scripts/webkitdirs.pm:
2211
2212 2011-01-02  Robert Hogan  <robert@webkit.org>
2213
2214         Unreviewed, build fix.
2215
2216         [Qt] Fix DRT build after 74855
2217
2218         * DumpRenderTree/qt/DumpRenderTree.pro:
2219
2220 2011-01-01  Adam Barth  <abarth@webkit.org>
2221
2222         Remove the assumption from the Qt and Gtk builds that every project is
2223         in the root directory.
2224
2225         * Scripts/build-webkit:
2226
2227 2011-01-01  Adam Barth  <abarth@webkit.org>
2228
2229         Reviewed by Eric Seidel.
2230
2231         Teach svn-apply how to apply patches even though JavaScriptCore has moved
2232         https://bugs.webkit.org/show_bug.cgi?id=51796
2233
2234         After this change, svn-apply will magically apply patches to
2235         JavaScriptCore/foo to Source/JavaScriptCore/foo.
2236
2237         * Scripts/VCSUtils.pm:
2238
2239 2011-01-01  Adam Barth  <abarth@webkit.org>
2240
2241         Reviewed by Eric Seidel.
2242
2243         Move JavaScriptCore to Source
2244         https://bugs.webkit.org/show_bug.cgi?id=51604
2245
2246         Update references to JavaScriptCore to point to the new location.
2247
2248         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2249         * DumpRenderTree/qt/DumpRenderTree.pro:
2250         * DumpRenderTree/qt/ImageDiff.pro:
2251         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2252         * DumpRenderTree/wscript:
2253         * Scripts/build-jsc:
2254         * Scripts/build-webkit:
2255         * Scripts/do-file-rename:
2256         * Scripts/do-webcore-rename:
2257         * Scripts/run-javascriptcore-tests:
2258         * Scripts/update-javascriptcore-test-results:
2259         * Scripts/webkitdirs.pm:
2260         * Scripts/webkitpy/common/config/build_unittest.py:
2261         * Scripts/webkitpy/style/checker.py:
2262         * Scripts/webkitpy/style/checker_unittest.py:
2263         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2264         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2265         * WebKitTestRunner/qt/WebKitTestRunner.pro:
2266         * wx/build/settings.py:
2267
2268 2011-01-01  Adam Barth  <abarth@webkit.org>
2269
2270         Reviewed by Eric Seidel.
2271
2272         Move Sources to Source
2273         https://bugs.webkit.org/show_bug.cgi?id=51794
2274
2275         Update scripts to point to the new location.
2276
2277         * Scripts/build-webkit:
2278         * Scripts/do-file-rename:
2279         * Scripts/do-webcore-rename:
2280         * Scripts/webkitpy/common/config/build.py:
2281         * Scripts/webkitpy/common/config/build_unittest.py:
2282
2283 2010-12-31  Kent Tamura  <tkent@chromium.org>
2284
2285         Reviewed by Eric Seidel.
2286
2287         [DRT/Chromium] Enable mock spell checker on non-OSX
2288         https://bugs.webkit.org/show_bug.cgi?id=51401
2289
2290         * DumpRenderTree/chromium/WebViewHost.cpp:
2291         (WebViewHost::spellCheck):
2292
2293 2010-12-31  Adam Barth  <abarth@webkit.org>
2294
2295         Reviewed by Ariya Hidayat.
2296
2297         Remove Tools/Scripts/wkstyle
2298         https://bugs.webkit.org/show_bug.cgi?id=51774
2299
2300         This script appears to not have been touched in a while and seems to
2301         have been replaced by check-webkit-style.
2302
2303         * Scripts/wkstyle: Removed.
2304
2305 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
2306
2307         Unreviewed. Coding style fix.
2308
2309         * DumpRenderTree/chromium/TestShell.h:
2310
2311 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
2312
2313         Reviewed by Pavel Feldman.
2314
2315         Web Inspector: [Chromium] Inspector's tests are very slow on Win(Dbg).
2316
2317         It was a problem with Chromium DRT. DevToolsAgent object instance was
2318         attached not only to the inspected page but to the DevTools window too.
2319         As result all the inspector files were interpreted as a content of inspected page
2320         and were transfered to the DevTools scripts panel for debugging etc.
2321
2322         https://bugs.webkit.org/show_bug.cgi?id=51735
2323
2324         * DumpRenderTree/chromium/TestShell.cpp:
2325         (TestShell::TestShell):
2326         (TestShell::bindJSObjectsToWindow):
2327         (TestShell::createNewWindow):
2328         * DumpRenderTree/chromium/TestShell.h:
2329
2330 2010-12-31  Adam Barth  <abarth@webkit.org>
2331
2332         Rubber-stamped by Eric Seidel.
2333
2334         Move PageLoadTests to PerformanceTests/PageLoad
2335         https://bugs.webkit.org/show_bug.cgi?id=51771
2336
2337         Update references to PageLoadTests to point to the new location.
2338
2339         * Scripts/run-pageloadtest:
2340         * Scripts/webkitpy/common/config/build.py:
2341
2342 2010-12-31  Adam Barth  <abarth@webkit.org>
2343
2344         Rubber-stamped by Eric Seidel.
2345
2346         Move SunSpider into PerformanceTests
2347         https://bugs.webkit.org/show_bug.cgi?id=51769
2348
2349         Update these scripts to point to the new location.
2350
2351         * Scripts/run-sunspider:
2352         * Scripts/sunspider-compare-results:
2353
2354 2010-12-30  Mihai Parparita  <mihaip@chromium.org>
2355
2356         Reviewed by Kent Tamura.
2357
2358         [Chromium] Add WebThemeEngineDRTMac so that Chromium DRT scrollbar rendering can match the Mac port's
2359         https://bugs.webkit.org/show_bug.cgi?id=51728
2360         
2361         Add implementation of the Mac WebThemeEngine that uses an NSScroller
2362         to render top-level scrollbars. This makes them match the Mac port's
2363         use of an NSScrollView, which means that we'll be able to share more
2364         pixel baselines.
2365         
2366         The new rendering code will not be activated until the 
2367         USE_WEB_THEME_ENGINE_TO_PAINT_THUMB #define is fliped in
2368         ScrollbarThemeChromiumMac.
2369
2370         * DumpRenderTree/DumpRenderTree.gypi:
2371         * DumpRenderTree/chromium/TestShellMac.mm:
2372         (platformInit):
2373         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Added.
2374         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Added.
2375         (+[FakeActiveWindow alwaysActiveWindow]):
2376         (+[FakeActiveWindow alwaysInactiveWindow]):
2377         (-[FakeActiveWindow initWithActiveControls:]):
2378         (-[FakeActiveWindow _hasActiveControls]):
2379         (WebThemeEngineDRTMac::paintScrollbarThumb):
2380         (stateToHIEnableState):
2381         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
2382         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
2383
2384 2010-12-30  Konstantin Tokarev  <annulen@yandex.ru>
2385
2386         Reviewed by David Kilzer.
2387
2388         [Qt] Don't build wtf/TCSystemAlloc.cpp if --system-malloc option is
2389         used
2390         https://bugs.webkit.org/show_bug.cgi?id=51672
2391
2392         * DumpRenderTree/qt/DumpRenderTree.pro: Replaced USE_SYSTEM_MALLOC
2393         with USE_SYSTEM_MALLOC=1
2394         * WebKitTestRunner/qt/WebKitTestRunner.pro: Replaced USE_SYSTEM_MALLOC
2395         with USE_SYSTEM_MALLOC=1
2396
2397 2010-12-30  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2398
2399         Reviewed by David Kilzer.
2400
2401         [Qt] [Symbian] Fix build-webkit script for Symbian
2402         https://bugs.webkit.org/show_bug.cgi?id=51509
2403
2404         Set the OUTPUT_DIR for Symbian to be the same as the source
2405         directory.
2406
2407         * Scripts/webkitdirs.pm:
2408
2409 2010-12-30  Martin Robinson  <mrobinson@igalia.com>
2410
2411         Reviewed by Darin Adler.
2412
2413         check-webkit-style should ignore NULL usage in calls to gtk_widget_style_get
2414         https://bugs.webkit.org/show_bug.cgi?id=51758
2415
2416         Add a check-webkit-style exception for gtk_widget_style_get and NULL usage.
2417
2418         * Scripts/webkitpy/style/checkers/cpp.py: Add the exception.
2419         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Add some tests for this.
2420
2421 2010-12-29  Patrick Gansterer  <paroga@webkit.org>
2422
2423         Unreviewed WinCE buildfix.
2424
2425         * WinCELauncher/main.cpp: Add missing include.
2426
2427 2010-12-29  Daniel Bates  <dbates@rim.com>
2428
2429         Reviewed by Darin Adler.
2430
2431         svn-apply updates date of wrong change log entry for a change log diff that
2432         contains two consecutive entries with the same author and date
2433         https://bugs.webkit.org/show_bug.cgi?id=46061
2434
2435         Fixes an issue where the date of the wrong change log entry may be modified.
2436         Moreover, changes fixChangeLogPatch() to move entries inserted earlier
2437         in a ChangeLog file to the top of the file.
2438
2439         Currently, fixChangeLogPatch() explicitly bails out and returns an unchanged
2440         diff when it detects that the diff inserts a change log entry earlier in a
2441         ChangeLog. It is unusual to land a patch that has such a deliberate ChangeLog
2442         change. With the advent of the commit-queue this functionality of bailing out
2443         and hence landing the patch as-is is harmful to the accuracy of the ChangeLog.
2444         Instead, we should always move the change log entry to the top of the ChangeLog file.
2445
2446         A side-effect of this change is that setChangeLogDateAndReviewer() now updates
2447         the date line of the correct change log entry in a ChangeLog diff.
2448
2449         * Scripts/VCSUtils.pm: Modified fixChangeLogPatch() to move entries inserted earlier to the top.
2450
2451         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
2452           Updated the following unit tests now that we move entries inserted earlier to the top:
2453           - "fixChangeLogPatch: New entry inserted in middle."
2454             (formerly named "fixChangeLogPatch: [no change] New entry inserted in middle.")
2455
2456           - "fixChangeLogPatch: New entry inserted earlier in the file, but after an entry with the same author and date."
2457             (formerly named "fixChangeLogPatch: [no change] New entry inserted earlier in the file, but after an entry with the same author and date.")
2458
2459         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatchThenSetChangeLogDateAndReviewer.pl: Added.
2460
2461 2010-12-29  Konstantin Tokarev  <annulen@yandex.ru>
2462
2463         Reviewed by Eric Seidel.
2464
2465         [Qt] Fixed compatibility with gold linker on X11 platforms
2466         https://bugs.webkit.org/show_bug.cgi?id=51700
2467
2468         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2469         Linked TestNetscapePlugin with libX11 on Unix platforms
2470
2471 2010-12-29  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>
2472
2473         Reviewed by Darin Adler.
2474
2475         Circular dependency in webkitpy.common.checkout.changelog module
2476         https://bugs.webkit.org/show_bug.cgi?id=50475
2477
2478         Remove automatic import of api.Checkout module when any checkout/
2479         submodule is imported (e.g.: when checkout.scm.Git is imported).
2480
2481         * Scripts/webkitpy/common/checkout/__init__.py:
2482
2483 2010-12-29  Martin Robinson  <mrobinson@igalia.com>
2484
2485         Reviewed by Ojan Vafai.
2486
2487         prepare-ChangeLog should support the -g option for specifying the git-commit
2488         https://bugs.webkit.org/show_bug.cgi?id=51708
2489
2490         Add a -g shortcut for the --git-commit prepare-ChangeLog option. This matches
2491         webkit-patch, though the exact meaning of the two options remain different.
2492
2493         * Scripts/prepare-ChangeLog: Add -g.
2494
2495 2010-12-29  Kent Hansen  <kent.hansen@nokia.com>
2496
2497         Reviewed by Simon Hausmann.
2498
2499         [Qt] Fix compilation with Qt in namespace
2500         https://bugs.webkit.org/show_bug.cgi?id=51701
2501
2502         * QtTestBrowser/webview.h:
2503
2504 2010-12-28  Daniel Bates  <dbates@rim.com>
2505
2506         Reviewed by Sam Weinig.
2507
2508         Substitute // MARK: for compiler-specific #pragma mark
2509         https://bugs.webkit.org/show_bug.cgi?id=51657
2510
2511         Fix future compilation warnings about "#pragma mark" on GTK+ bots by
2512         substituting  "// MARK:" for "#pragma mark", which provides
2513         analogous code-bookmarking functionality under Xcode.
2514
2515         Also, for consistency, we should substitute "// MARK:" for compiler-
2516         specific "#pragma mark" in the source files for the Mac port.
2517
2518         * DumpRenderTree/AccessibilityTextMarker.cpp:
2519         * DumpRenderTree/cf/WebArchiveDumpSupport.h:
2520         * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm:
2521         * DumpRenderTree/mac/ObjCController.m:
2522         * MiniBrowser/mac/AppDelegate.m:
2523         * MiniBrowser/mac/BrowserWindowController.m:
2524
2525 2010-12-28  Xan Lopez  <xlopez@igalia.com>
2526
2527         Reviewed by Eric Seidel.
2528
2529         Add --no-build option to run-sunspider
2530         https://bugs.webkit.org/show_bug.cgi?id=51658
2531
2532         * Scripts/run-sunspider: add --no-build flag to skip building
2533         phase.
2534
2535 2010-12-27  Daniel Bates  <dbates@rim.com>
2536
2537         Rubber-stamped by Martin Robinson.
2538
2539         Append the directory Tools/DumpRenderTree to the list of directories that
2540         do-webcore-rename should search so that it can rename DRT files and
2541         source code.
2542
2543         * Scripts/do-webcore-rename:
2544
2545 2010-12-27  Eric Seidel  <eric@webkit.org>
2546
2547         Reviewed by Adam Barth.
2548
2549         build-webkit should detect missing Java SDK and explain how to install it
2550         https://bugs.webkit.org/show_bug.cgi?id=51651
2551
2552         * Scripts/build-webkit:
2553
2554 2010-12-26  Martin Robinson  <mrobinson@igalia.com>
2555
2556         Reviewed by Daniel Bates.
2557
2558         [GTK] Add support for build-jsc
2559         https://bugs.webkit.org/show_bug.cgi?id=51625
2560
2561         Add GTK+ support to build-jsc now that building the jsc executable as
2562         a standalone target is easy.
2563
2564         * Scripts/build-jsc: Call buildGtkProject for the GTK+ case now.
2565         * Scripts/build-webkit: Pass in the proper target name to buildGtkProject.
2566         * Scripts/webkitdirs.pm: Actually process the project parameter in buildGtkProject
2567         and pass it along to buildAutotoolsProject.
2568
2569 2010-12-27  David Levin  <levin@chromium.org>
2570
2571         Reviewed by Eric Seidel.
2572
2573         check-webkit-style check for meaningless variable names in function declarations.
2574         https://bugs.webkit.org/show_bug.cgi?id=51523
2575
2576         * Scripts/webkitpy/style/checker.py: Exempted JavaScriptCore/jit/JITStubs.cpp
2577         from the new check and whitespace/parens because the syntax is unusual and
2578         produced a fair number of positives for these checks.
2579         * Scripts/webkitpy/style/checkers/cpp.py:
2580         (_convert_to_lower_with_underscores): Used as a canonical form for type names
2581         and parameter names when determining if the parameter name is useless.
2582         (_create_acronym): Used to check for redundant variable names in cases like "ExceptionCode ec"
2583         (Parameter.lower_with_underscores_name): Gives back the parameter name in a lower_with_underscore
2584         format.
2585         (_check_parameter_name_against_text):  Checks to see if the parameter name is in the
2586         text or an acronym of it.
2587         (check_function_definition): Checks function definitions for meaningless variable names.
2588         (process_line): Added call to check_function_definition.
2589         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2590         (CppFunctionsTest.test_convert_to_lower_with_underscores): Test for _convert_to_lower_with_underscores.
2591         (CppFunctionsTest.test_create_acronym): Test for _create_acronym.
2592         (CppFunctionsTest.test_check_parameter_against_text): Test for _check_parameter_against_text.
2593         (CppStyleTestBase.perform_single_line_lint): Removed the parameter name check
2594         because when only checking a snippet, there are a lot of bogus functions.
2595         (CppStyleTestBase.perform_multi_line_lint): Ditto and removed a bogus filter
2596         that I put there previously and just noticed.
2597         (WebKitStyleTest.test_parameter_names): Tests for the functionality -- both
2598         check_function_definition and process_line.
2599
2600 2010-12-27  Carlos Garcia Campos  <cgarcia@igalia.com>
2601
2602         Reviewed by Martin Robinson.
2603
2604         [GTK] Disable flash plugin in GtkLauncher when using gtk3
2605         https://bugs.webkit.org/show_bug.cgi?id=51591
2606
2607         Flash plugin uses gtk2 that is incompatible with gtk3 making
2608         webkit crash when it's built with gtk3.
2609
2610         * GtkLauncher/main.c:
2611         (main):
2612
2613 2010-12-25  Adam Barth  <abarth@webkit.org>
2614
2615         Reviewed by Eric Seidel.
2616
2617         Move ANGLE to Sources/ThirdParty
2618         https://bugs.webkit.org/show_bug.cgi?id=51605
2619
2620         * Scripts/build-webkit:
2621           - Point to the new ANGLE location.
2622
2623 2010-12-26  David Levin  <levin@chromium.org>
2624
2625         Reviewed by Eric Seidel.
2626
2627         check-webkit-style should be able to parse function declaration parameters.
2628         https://bugs.webkit.org/show_bug.cgi?id=51451
2629
2630         * Scripts/webkitpy/style/checkers/cpp.py:
2631         (Position.__init__): Holds simple position information (row, column).
2632         (Parameter.__init__): Holds information about a parameter.
2633         (SingleLineView.__init): Converts multiple lines into a single line for simpler searches.
2634         (SingleLineView.convert_column_to_row): Returns the original row given a column.
2635         (create_skeleton_parameters): Simplifies a parameter list for easier searching.
2636         (find_parameter_name_index): Finds where the parameter name is.
2637         (parameter_list): Generates the list of parameters for a function.
2638         (_FunctionState.begin): Added information to allow determining the parameters
2639         on demand.
2640         (_FunctionState.get_parameter_list): Returns a tuple of function parameters.
2641         (detect_functions): Improve function detection for operator functions and
2642         determine where the parameters end and pass that to _FunctionState.begin.
2643         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2644         (CppFunctionsTest.test_parameter): Verifies Parameter functionality.
2645         (CppFunctionsTest.test_single_line_view): Verifies SingleLineView functionality.
2646         (CppFunctionsTest.test_create_skeleton_parameters): Verifies create_skeleton_parameters.
2647         (CppFunctionsTest.test_find_parameter_name_index): Verifies find_parameter_name_index.
2648         (CppFunctionsTest.test_parameter_list): Does some minimal verification for parameter list.
2649         Much more thorough verification is done as part of FunctionDetectionTest.test_parameter_list.
2650         (FunctionDetectionTest.perform_function_detection): Added support for verifying
2651         the parameters found.
2652         (FunctionDetectionTest.test_function_declaration_detection): Added more function
2653         detection test to verify that we catch the operator functions.
2654         (FunctionDetectionTest.test_ignore_macros): Verify that function detection ignores macros.
2655         (FunctionDetectionTest.test_parameter_list): Added tests to verify the parameter parsing.
2656         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_bad_test_doesnt_break): Removed
2657         because the error. The test is about the bad function name. Fixing the name makes the test exactly like
2658         test_function_length_check_definition_severity1_for_test.
2659
2660 2010-12-25  Patrick Gansterer  <paroga@webkit.org>
2661
2662         Unreviewed WinCE buildfix after r74334.
2663
2664         * CMakeListsWinCE.txt:
2665
2666 2010-12-24  Sheriff Bot  <webkit.review.bot@gmail.com>
2667
2668         Unreviewed, rolling out r74632.
2669         http://trac.webkit.org/changeset/74632
2670         https://bugs.webkit.org/show_bug.cgi?id=51600
2671
2672         makes test-webkitpy hang forever on GTK (Requested by philn-tp
2673         on #webkit).
2674
2675         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
2676         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
2677
2678 2010-12-24  Ryuan Choi  <ryuan.choi@samsung.com>
2679
2680         Reviewed by Kenneth Rohde Christiansen.
2681
2682         [EFL] Screen doesn't be rendered when changing size of EWebLauncher
2683         https://bugs.webkit.org/show_bug.cgi?id=43528
2684
2685         Remove on_resize because ewk_view_fixed_layout_size_set should not be
2686         called on callback of EVAS_CALLBACK_RESIZE. As it change size of
2687         FrameView, rendering was ignored when _ewk_view_smart_calculate was
2688         called.
2689
2690         * EWebLauncher/main.c:
2691         (browserCreate):
2692
2693 2010-12-24  Eric Seidel  <eric@webkit.org>
2694
2695         Reviewed by Adam Barth.
2696
2697         webkit-patch (or a pre-commit hook) needs to prevent bad ChangeLog changes
2698         https://bugs.webkit.org/show_bug.cgi?id=28291
2699
2700         This is a start.  At least now webkit-patch will prompt when your ChangeLog looks questionable.
2701         We could do more advanced things, like parsing the ChangeLog (with changelog.py) and comparing that
2702         to strings with find in the diff.
2703         Since non-interactive always returns the default, this should cause patches with bad changelogs to fail on the commit-queue.
2704
2705         * Scripts/webkitpy/common/checkout/api.py:
2706         * Scripts/webkitpy/common/checkout/diff_parser.py:
2707         * Scripts/webkitpy/tool/steps/abstractstep.py:
2708         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
2709         * Scripts/webkitpy/tool/steps/validatechangelogs.py: Copied from Tools/Scripts/webkitpy/tool/steps/validatereviewer.py.
2710         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py: Copied from Tools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.
2711         * Scripts/webkitpy/tool/steps/validatereviewer.py:
2712
2713 2010-12-24  Dirk Pranke  <dpranke@chromium.org>
2714
2715         Reviewed by Kenneth Russell.
2716
2717         Modify new-run-webkit-tests to shut up and exit when all the threads
2718         are wedged so that test runs complete faster and we don't end up
2719         w/ enormous log files.
2720
2721         https://bugs.webkit.org/show_bug.cgi?id=51572
2722
2723         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
2724         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
2725
2726 2010-12-24  Eric Seidel  <eric@webkit.org>
2727
2728         Reviewed by David Levin.
2729
2730         commit-queue should better explain how it will re-open bugs and follow duplicate chains
2731         https://bugs.webkit.org/show_bug.cgi?id=51549
2732
2733         I've had multiple people ask me about the commit-queue's behavior
2734         regarding reporting flaky tests.  I figured it would be best to just
2735         have the queue explain itself in the bugs it files.
2736
2737         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2738         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2739
2740 2010-12-24  Shinichiro Hamaji  <hamaji@chromium.org>
2741
2742         Reviewed by Eric Seidel.
2743
2744         check-webkit-style: should ignore "wrong" namings in JavaScriptCore/qt
2745         https://bugs.webkit.org/show_bug.cgi?id=51467
2746
2747         * Scripts/webkitpy/style/checker.py:
2748         * Scripts/webkitpy/style/checker_unittest.py:
2749
2750 2010-12-23  Adam Barth  <abarth@webkit.org>
2751
2752         Rubber-stamped by Eric Seidel.
2753
2754         Move JavaScriptGlue into Sources
2755         https://bugs.webkit.org/show_bug.cgi?id=51583
2756
2757         These tools refer to JavaScriptGlue and need to be updated to its new
2758         location.
2759
2760         * Scripts/build-webkit:
2761         * Scripts/do-file-rename:
2762         * Scripts/do-webcore-rename:
2763         * Scripts/webkitpy/common/config/build.py:
2764         * Scripts/webkitpy/common/config/build_unittest.py:
2765
2766 2010-12-23  Lucas Forschler  <lforschler@apple.com>
2767
2768         Reviewed by Eric Seidel.
2769
2770         Bug 51539 - update iexploder scripts to point to new location
2771
2772         * Scripts/run-iexploder-tests:
2773         * Scripts/update-iexploder-cssproperties:
2774
2775 2010-12-23  Evan Martin  <evan@chromium.org>
2776
2777         Reviewed by Ryosuke Niwa.
2778
2779         [chromium] LayoutTestController warning in float->int conversion
2780         https://bugs.webkit.org/show_bug.cgi?id=51553
2781
2782         Rather than reading an int, converting to a float, then getting a compiler
2783         warning on passing the float to something that expects an int, instead
2784         just pass around ints.
2785
2786         No tests, fixes a compiler warning.
2787
2788         * DumpRenderTree/chromium/LayoutTestController.cpp:
2789         (parsePageSizeParameters):
2790         (LayoutTestController::pageNumberForElementById):
2791         (LayoutTestController::numberOfPages):
2792
2793 2010-12-23  Lucas Forschler  <lforschler@apple.com>
2794
2795         Reviewed by Darin Adler.
2796
2797         Bug 51537 - iexploder needs cleanup
2798         
2799         * iExploder/htdocs: Removed.
2800         * iExploder/htdocs/config.rb: Removed.
2801         * iExploder/htdocs/cssproperties.in: Removed.
2802         * iExploder/htdocs/cssvalues.in: Removed.
2803         * iExploder/htdocs/htmlattrs.in: Removed.
2804         * iExploder/htdocs/htmltags.in: Removed.
2805         * iExploder/htdocs/htmlvalues.in: Removed.
2806         * iExploder/htdocs/iexploder.cgi: Removed.
2807         * iExploder/htdocs/iexploder.rb: Removed.
2808         * iExploder/htdocs/index.html: Removed.
2809         * iExploder/htdocs/webserver.rb: Removed.
2810         * iExploder/iexploder-1.7.2/output: Removed.
2811         * iExploder/tools: Removed.
2812         * iExploder/tools/lasthit.rb: Removed.
2813         * iExploder/tools/osx_last_crash.rb: Removed.
2814         * iExploder/tools/showtest.rb: Removed.
2815
2816 2010-12-23  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
2817
2818         Reviewed by Kenneth Rohde Christiansen.
2819
2820         [EFL] Make 'single' the default backing store in EWebLauncher
2821         https://bugs.webkit.org/show_bug.cgi?id=51534
2822
2823         'single' is the simplest backing store and the one intended to be the
2824         default in the test browser. By mistake the tiled backing store was
2825         left as default in r72617.
2826
2827         * EWebLauncher/main.c:
2828         (browserCreate): ditto.
2829
2830 2010-12-23  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
2831
2832         Reviewed by Kenneth Rohde Christiansen.
2833
2834         [EFL] Subject: [webkit 4/4] [EFL] Remove non-sense workaround
2835         https://bugs.webkit.org/show_bug.cgi?id=51533
2836
2837         There's no point in concatenating env("HOME") with "blah", so remove
2838         option from EWebLauncher.
2839
2840         * EWebLauncher/main.c:
2841         (main): ditto.
2842
2843 2010-12-23  Ilya Tikhonovsky  <loislo@chromium.org>
2844
2845         Reviewed by Eric Seidel.
2846
2847         Web Inspector: chromium: inspector's tests are quite slow especially at windows(Debug).
2848
2849         Almost all inspector's tests become flaky on chromium Win(dbg) after switching to DRT.
2850         I just discovered that we have two additional GC runs per each WebViewHost.
2851         Test_shell had no such calls.
2852         These gc runs eat 15% of cpu time.
2853
2854         https://bugs.webkit.org/show_bug.cgi?id=51479
2855
2856         * DumpRenderTree/chromium/WebViewHost.cpp:
2857         (WebViewHost::~WebViewHost):
2858
2859 2010-12-22  Dirk Pranke  <dpranke@chromium.org>
2860
2861         Reviewed by Ojan Vafai.
2862
2863         This change splits out the TestRunner class into its own file.
2864         When we fork the code for message passing, we will create a new
2865         TestRunner, and this change will allow that to be more modular.
2866
2867         While we're at it, split out TestInput and ResultSummary into
2868         their own files, to reduce the size of run_webkit_tests to
2869         something more managable.
2870
2871         https://bugs.webkit.org/show_bug.cgi?id=51092
2872
2873         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2874         * Scripts/webkitpy/layout_tests/layout_package/result_summary.py:
2875         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2876         * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
2877         * Scripts/webkitpy/layout_tests/layout_package/test_input.py:
2878         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2879         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2880
2881  2010-12-22  Dirk Pranke  <dpranke@chromium.org>
2882
2883         Reviewed by Ojan Vafai.
2884
2885         nrwt multiprocessing - start over, prepare to fork the code
2886  
2887         This code cleans up the signatures and implementation of the
2888         TestRunner class so we can easily fork it to run either the
2889         stable implementation or the new, unstable message-passing
2890         implementation. The two variants will have different
2891         implementations of the run_tests() method. We will switch
2892         between the two based on the setting for the '--worker-model'
2893         switch. We rename the two currently valid values to 'old-inline'
2894         and 'old-threads'.
2895
2896         https://bugs.webkit.org/show_bug.cgi?id=51081
2897
2898         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2899         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2900
2901 2010-12-22  Victor Wang  <victorw@chromium.org>
2902
2903         Reviewed by Darin Fisher.
2904
2905         [Chromium] Update chromium archive test result url in rebaseline script.
2906
2907         https://bugs.webkit.org/show_bug.cgi?id=51503
2908
2909         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2910
2911 2010-12-22  Lucas Forschler  <lforschler@apple.com>
2912
2913         Reviewed by Alice Liu.
2914
2915         <rdar://problem/8633222> record-memory-win needs to record memory used by the webprocess.
2916         Verified on Chrome, Safari, and IE.
2917         With this change, we will record memory from a parent browser window and all child processes.
2918
2919         * record-memory-win/main.cpp:
2920         (ProcessArgs):
2921         (PrintUsage):
2922         (getMemoryInfo):
2923         (printProcessInfo):
2924         (evalProcesses):
2925         (UseImage):
2926         (QueryContinuously):
2927         (ElapsedTime):
2928
2929 2010-12-22  Lucas Forschler  <lforschler@apple.com>
2930
2931         Unreviewed rollout r74489, because it was missing changelog.
2932
2933         * record-memory-win/main.cpp:
2934         
2935 2010-12-22  Ryosuke Niwa  <rniwa@webkit.org>
2936
2937         Adding myself as a reviewer.
2938
2939         * Scripts/webkitpy/common/config/committers.py:
2940
2941 2010-12-22  Andrew Scherkus  <scherkus@chromium.org>
2942
2943         Unreviewed.  Adding myself to committers.py.
2944
2945         * Scripts/webkitpy/common/config/committers.py:
2946
2947 2010-12-22  Ariya Hidayat  <ariya@sencha.com>
2948
2949         Reviewed by Kenneth Rohde Christiansen.
2950
2951         TestNetscapePlugIn should use #if defined
2952         https://bugs.webkit.org/show_bug.cgi?id=51471
2953
2954         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2955         (NP_Initialize):
2956         (NPP_New):
2957
2958 2010-12-22  Ilya Tikhonovsky  <loislo@chromium.org>
2959
2960         Reviewed by Yury Semikhatsky.
2961
2962         Web Inspector: [chromium] DRT inspector layout tests are flaky in debug.
2963
2964         DevTools window should be closed explicitly because it has custom deinitialization code.
2965
2966         https://bugs.webkit.org/show_bug.cgi?id=50722
2967
2968         * DumpRenderTree/chromium/TestShell.cpp:
2969         (TestShell::closeRemainingWindows):
2970
2971 2010-12-22  David Levin  <levin@chromium.org>
2972
2973         Reviewed by Shinichiro Hamaji.
2974
2975         check-webkit-style shouldn't complaint about underscores in variables in objective C files.
2976         https://bugs.webkit.org/show_bug.cgi?id=51452
2977
2978         * Scripts/webkitpy/style/checkers/cpp.py:
2979         (_FileState.__init__): Added the information to determine if a file is C or Objective C.
2980         Using the file extension if possible but falling back to the file contents if we have a header file.
2981         (_FileState.is_objective_c): Determine if we have an Objective C by examining the file contents if needed.
2982         (_FileState.is_c_or_objective_c):
2983         (check_using_std): Changed to using _FileState to determine the file type.
2984         (check_max_min_macros): Ditto.
2985         (check_for_null): Ditto.
2986         (check_style): Changed the parameters to various calls since they now need _FileState
2987         to determine the file type.
2988         (check_language): Added the file_state parameter so it could be passed
2989         to check_identifier_name_in_declaration.
2990         (check_identifier_name_in_declaration): Don't warn about underscores in variables if
2991         this is an Objective C file.
2992         (_process_lines): Added information for the _FileState constructor (and moved the
2993         call to a place that had the information).
2994         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2995         (CppFunctionsTest.test_is_c_or_objective_c): Changed the tests to use FileState and exercise
2996         its functionality.
2997         (WebKitStyleTest.test_names): Add tests for underscores in Objective C files.
2998
2999 2010-12-21  Andy Estes  <aestes@apple.com>
3000
3001         Reviewed by Mark Rowe.
3002
3003         Do not build non-Intel architectures for WebKit2-related projects.
3004         https://bugs.webkit.org/show_bug.cgi?id=51440
3005
3006         * MiniBrowser/Configurations/Base.xcconfig: Only build for i386 and x86_64.
3007         * TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
3008         * WebKitTestRunner/Configurations/Base.xcconfig: Ditto.
3009
3010 2010-12-21  Mihai Parparita  <mihaip@chromium.org>
3011
3012         Reviewed by Darin Fisher.
3013
3014         [Chromium] Rename WebThemeEngine/ControlDRT to WebThemeEngine/ControlDRTWin
3015         https://bugs.webkit.org/show_bug.cgi?id=51406 
3016         
3017         Rename WebThemeControlDRT to WebThemeControlDRTWin and WebThemeEngineDRT
3018         to WebThemeEngineDRTWin and update references everywhere.
3019
3020         * DumpRenderTree/DumpRenderTree.gypi:
3021         * DumpRenderTree/chromium/TestShellWin.cpp:
3022         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRT.cpp.
3023         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRT.h.
3024         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRT.cpp.
3025         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRT.h.
3026
3027 2010-12-21  Anders Carlsson  <andersca@apple.com>
3028
3029         Reviewed by John Sullivan.
3030
3031         Clicking missing plug-in text does not show a sheet
3032         https://bugs.webkit.org/show_bug.cgi?id=51403
3033
3034         Update for changes to the WebPageUIClient.
3035
3036         * MiniBrowser/mac/BrowserWindowController.m:
3037         (-[BrowserWindowController awakeFromNib]):
3038         * WebKitTestRunner/TestController.cpp:
3039         (WTR::createOtherPage):
3040         (WTR::TestController::initialize):
3041
3042 2010-12-21  Eric Seidel  <eric@webkit.org>
3043
3044         Reviewed by Adam Barth.
3045
3046         commit-queue will report constant failures as flaky if other tests flake
3047         https://bugs.webkit.org/show_bug.cgi?id=51272
3048
3049         This patch just removes functionality and adds testing.
3050         Previously we attempted to report flaky tests when we had
3051         two different tests fail in a row.  However, since we stop
3052         running the tests at the first failure, our code was wrong in
3053         trying to determine flakiness from the incomplete runs.
3054
3055         Originally I posted an alternate patch:
3056         https://bug-51272-attachments.webkit.org/attachment.cgi?id=77078
3057         which fixed our flaky logic in this case, however it was decided
3058         that that patch would be too difficult to maintain, so now
3059         I'm just removing the broken logic.
3060
3061         This will dramatically cut-down on our flaky-test false positives
3062         at the (small) cost of the queues being unable to report
3063         any flakiness if the tree is very flaky.  (With at least one test
3064         flaking on every run, we'll never report failures anymore.)  I think
3065         this is a tradeoff worth making.
3066
3067         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3068         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3069
3070 2010-12-20  Eric Seidel  <eric@webkit.org>
3071
3072         Reviewed by Adam Barth.
3073
3074         commit-queue wrongly rejects patches when it can't update itself
3075         https://bugs.webkit.org/show_bug.cgi?id=46636
3076
3077         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3078         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3079         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3080
3081 2010-12-20  Adam Barth  <abarth@webkit.org>
3082
3083         Move web sites to Websites directory
3084         https://bugs.webkit.org/show_bug.cgi?id=51323
3085
3086         Update references to BugsSite to point to the new location.
3087
3088         This patch was never officially reviewed (because it was too large to
3089         upload to bugs.webkit.org), but it was discussed on webkit-dev and Mark
3090         Rowe gave me the green light.
3091
3092         * Scripts/old-run-webkit-tests:
3093         * Scripts/webkitpy/common/config/build.py:
3094         * Scripts/webkitpy/common/config/build_unittest.py:
3095         * Scripts/webkitpy/common/prettypatch.py:
3096         * Scripts/webkitpy/layout_tests/port/base.py:
3097         * Scripts/webkitpy/style/main.py:
3098
3099 2010-12-20  Adrienne Walker  <enne@google.com>
3100
3101         Unreviewed. Adding myself to the list of committers.
3102
3103         * webkitpy/common/config/committers.py:
3104
3105 2010-12-20  Mark Rowe  <mrowe@apple.com>
3106
3107         Reviewed by Dan Bernstein.
3108
3109         <rdar://problem/8757601> Don't install header files in to the Resources directory.
3110
3111         * Scripts/check-for-inappropriate-files-in-framework: Don't allow .h files in the
3112         Resources directory.
3113
3114 2010-12-20  Eric Seidel  <eric@webkit.org>
3115
3116         Reviewed by Adam Barth.
3117
3118         commit-queue should include bot id when attaching failure diffs
3119         https://bugs.webkit.org/show_bug.cgi?id=51280
3120
3121         This is a tiny change to include the bot id in the name of the attachment.
3122         Most of this diff is just changing the unit test expectations
3123         now that I hid the comment printing when the comment is None.
3124
3125         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3126         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3127         * Scripts/webkitpy/tool/commands/upload_unittest.py:
3128         * Scripts/webkitpy/tool/mocktool.py:
3129
3130 2010-12-20  Jeff Miller  <jeffm@apple.com>
3131
3132         Reviewed by Dan Bernstein.
3133
3134         Tools/vcbin/midl.exe needs to be rebuilt
3135         https://bugs.webkit.org/show_bug.cgi?id=51347
3136
3137         * vcbin/midl.exe: Rebuilt.
3138
3139 2010-12-20  David Levin  <levin@chromium.org>
3140
3141         Reviewed by Ariya Hidayat.
3142
3143         .gitignore and webkit-tools-completion.sh have references to WebKitTools that should be Tools.
3144         https://bugs.webkit.org/show_bug.cgi?id=51343
3145
3146         Follow up from the WebKitTools -> Tools rename.
3147
3148         * Scripts/webkit-tools-completion.sh:
3149
3150 2010-12-20  Cosmin Truta  <ctruta@chromium.org>
3151
3152         Reviewed by James Robinson.
3153
3154         new-run-webkit-tests ignores trailing EOL differences in text tests
3155         https://bugs.webkit.org/show_bug.cgi?id=36983
3156
3157         Changed the handling of new-line characters within new-run-webkit-tests
3158         to match old-run-webkit-tests.  Differences in leading and trailing empty
3159         lines in text expectation files are no longer ignored.
3160
3161         * Scripts/webkitpy/layout_tests/port/base.py:
3162         * Scripts/webkitpy/layout_tests/port/test.py:
3163         Added unit tests.  Removed old duplicate unit test entries.
3164         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
3165
3166 2010-12-20  David Levin  <levin@chromium.org>
3167
3168         Reviewed by Shinichiro Hamaji.
3169
3170         check-webkit-style should detect function declarations (and trivial functions).
3171         https://bugs.webkit.org/show_bug.cgi?id=51303
3172
3173         * Scripts/webkitpy/style/checkers/cpp.py:
3174         (_FunctionState.begin): Add is_declaration and changed the line count
3175         start to begin at -1 (which will keep the results consistent, since
3176         the starting line number passed in is one less in this change).
3177         (detect_functions): changed function detection to now catch trivial
3178         functions and declarations.
3179         (check_pass_ptr_usage): Don't check for Pass*Ptr on the first line
3180         of the function as this may look at return values (when processing
3181         a declaration).
3182         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3183         (FunctionDetectionTest.perform_function_detection): Basic mechanics
3184         of testing the function detection.
3185         (FunctionDetectionTest.test_basic_function_detection): Test a simple
3186         function.
3187         (FunctionDetectionTest.test_function_declaration_detection): Test a
3188         declaration.
3189         (FunctionDetectionTest.test_non_functions): A test case for a case
3190         that caused the code to fail due to the { being in quotes.
3191         (PassPtrTest.test_pass_ref_ptr_return_value): Added some more test
3192         cases to help catch false alarms for return values.
3193         (PassPtrTest.test_pass_ref_ptr_member_variable): Ensure that
3194         we don't get false alarms for member variables either.
3195
3196 2010-12-20  Ryuan Choi  <ryuan.choi@samsung.com>
3197
3198         Reviewed by Antonio Gomes.
3199
3200         [CMAKE] Rename WEBKITTOOLS_DIR to TOOLS_DIR
3201         https://bugs.webkit.org/show_bug.cgi?id=51319
3202
3203         * CMakeListsEfl.txt:
3204
3205 2010-12-18  Adam Barth  <abarth@webkit.org>
3206
3207         Reviewed by Sam Weinig.
3208
3209         Move WebKitExamplePlugins to Examples
3210         https://bugs.webkit.org/show_bug.cgi?id=51291
3211
3212         * Scripts/webkitpy/common/config/build.py:
3213
3214 2010-12-17  Csaba Osztrogonác  <ossy@webkit.org>
3215
3216         Unreviewed Qt buildfix after r74301.
3217
3218         Rename WebKitTools to Tools
3219         https://bugs.webkit.org/show_bug.cgi?id=49861
3220
3221         * MiniBrowser/DerivedSources.pro:
3222         * MiniBrowser/qt/MiniBrowser.pro:
3223
3224 2010-12-17  Dan Bernstein  <mitz@apple.com>
3225
3226         Reviewed by Simon Fraser.
3227
3228         Rename WebKitTools to Tools
3229         https://bugs.webkit.org/show_bug.cgi?id=49861
3230
3231         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3232         * CodeCoverage/README:
3233         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3234         (WebCore::DumpRenderTree::initializeFonts):
3235         * EWSTools/start-commit-queue.sh:
3236         * EWSTools/start-queue.sh:
3237         * GNUmakefile.am:
3238         * MIDLWrapper/MIDLWrapper.cpp:
3239         (wmain):
3240         * MiniBrowser/qt/MiniBrowser.pro:
3241         * Scripts/build-api-tests:
3242         * Scripts/build-dumprendertree:
3243         * Scripts/build-webkit:
3244         * Scripts/build-webkittestrunner:
3245         * Scripts/generate-coverage-data:
3246         * Scripts/old-run-webkit-tests:
3247         * Scripts/run-api-tests:
3248         * Scripts/run-iexploder-tests:
3249         * Scripts/run-javascriptcore-tests:
3250         * Scripts/run-mangleme-tests:
3251         * Scripts/run-sunspider:
3252         * Scripts/run-webkit-websocketserver:
3253         * Scripts/sunspider-compare-results:
3254         * Scripts/test-webkitperl:
3255         * Scripts/test-webkitpy:
3256         * Scripts/update-iexploder-cssproperties:
3257         * Scripts/update-webkit:
3258         * Scripts/update-webkit-localizable-strings:
3259         * Scripts/webkitdirs.pm:
3260         * Scripts/webkitpy/common/checkout/scm.py:
3261         * Scripts/webkitpy/common/checkout/scm_unittest.py:
3262         * Scripts/webkitpy/common/config/committervalidator.py:
3263         * Scripts/webkitpy/common/config/committervalidator_unittest.py:
3264         * Scripts/webkitpy/common/config/ports.py:
3265         * Scripts/webkitpy/common/config/ports_unittest.py:
3266         * Scripts/webkitpy/common/system/logutils_unittest.py:
3267         * Scripts/webkitpy/common/system/ospath_unittest.py:
3268         * Scripts/webkitpy/layout_tests/port/chromium.py:
3269         * Scripts/webkitpy/layout_tests/port/config.py:
3270         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
3271         * Scripts/webkitpy/layout_tests/port/http_server.py:
3272         * Scripts/webkitpy/layout_tests/port/test.py:
3273         * Scripts/webkitpy/style/checker.py:
3274         * Scripts/webkitpy/style/checker_unittest.py:
3275         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
3276         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3277         * Scripts/webkitpy/tool/steps/steps_unittest.py:
3278         * WebKitTestRunner/DerivedSources.pro:
3279         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
3280         (WTR::activateFonts):
3281         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3282         * wx/build/build_utils.py:
3283
3284 2010-12-16  Antonio Gomes  <agomes@rim.com>
3285
3286         Reviewed by Martin Robinson.
3287
3288         Settings::editingBehaviorType() incorrectly returns mac for the gtk build when running tests
3289         https://bugs.webkit.org/show_bug.cgi?id=51163
3290
3291         Since GTK+'s default editing behavior was changed to UNIX in r70975 (see webkitwebsettings.cpp),
3292         GTK+'s DRT should also reset to UNIX after each test execution.
3293
3294         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3295         (resetDefaultsToConsistentValues):
3296
3297 2010-12-17  David Levin  <levin@chromium.org>
3298
3299         Reviewed by Eric Seidel.
3300
3301         check-webkit-style should understand WTF #include guards
3302         https://bugs.webkit.org/show_bug.cgi?id=44911
3303
3304         * Scripts/webkitpy/style/checkers/cpp.py:
3305         (get_header_guard_cpp_variable): modify to suggest the WTF style
3306         of header guard when appropriate.
3307         (check_for_header_guard): handle multiple return values from
3308         get_header_guard_cpp_variable
3309         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3310         (CppStyleTest.test_build_header_guard): Added tests for the WTF
3311         header style.
3312
3313 2010-12-16  David Levin  <levin@chromium.org>
3314
3315         Reviewed by Eric Seidel.
3316
3317         test-webkitpy: unittest for the xml.py checker displays a decprecation warning.
3318         https://bugs.webkit.org/show_bug.cgi?id=51210
3319
3320         The error only shows up when using python 2.6 or later.
3321
3322         * Scripts/webkitpy/style/checkers/xml.py: Replace the usage of
3323         the decprecated field error,message with something equivalent.
3324
3325 2010-12-16  Mihai Parparita  <mihaip@chromium.org>
3326
3327         Reviewed by Eric Seidel.
3328
3329         Add --exit-after-n-failures/crashes to NRWT
3330         https://bugs.webkit.org/show_bug.cgi?id=51160
3331         
3332         Abort test run (in a similar way to how control-C is handled) when
3333         --exit-after-n-failures/crashes-or-timeouts are passed and we've reached
3334         that number of unexpected failures/crashes/timeouts.
3335
3336         * Scripts/webkitpy/layout_tests/port/test.py:
3337         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3338         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3339
3340 2010-12-16  David Levin  <levin@chromium.org>
3341
3342         Reviewed by Shinichiro Hamaji.
3343
3344         check-webkit-style unit tests has some duplicate boilerplate code.
3345         https://bugs.webkit.org/show_bug.cgi?id=49519
3346
3347         * Scripts/webkitpy/style/checkers/cpp.py:
3348         (update_include_state): Replaced the "io" parameter with the global
3349         configuration _unit_test_config. This allowed not calling into
3350         functions at a low level and also not plumbing through the injection
3351         information through many levels of code.
3352         (check_for_include_what_you_use): Ditto.
3353         (process_file_data): Added the ability to set up the unit test config
3354         to allow for injection.
3355         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3356         (ErrorCollector.__init__): Added support for having a filter for errors.
3357         (ErrorCollector.__call__): Ditto.
3358         (CppStyleTestBase.process_file_data): Added the ability to set unit_test_config.
3359         (CppStyleTestBase.perform_lint): Consolidated logic for the perform functions.
3360         (CppStyleTestBase.perform_single_line_lint): Replace specific calls to
3361         functions in the cpp.py with generic processing and a filter that
3362         indicates what errors should be kept.
3363         (CppStyleTestBase.perform_multi_line_lint): Ditto.
3364         (CppStyleTestBase.perform_language_rules_check): Ditto.
3365         (CppStyleTestBase.perform_function_lengths_check): Ditto.
3366         (CppStyleTestBase.perform_pass_ptr_check): Ditto.
3367         (CppStyleTestBase.perform_include_what_you_use): Ditto.
3368         (CppStyleTest.test_multi_line_comments): Added another
3369         error message which applies to the test case.
3370         (CppStyleTest.test_spacing_for_binary_ops): Fixed test
3371         to not have config.h, since it is processed as a header file.
3372         (CppStyleTest.test_static_or_global_stlstrings): Fixed variable name
3373         style and indentation in checked code.
3374         (OrderOfIncludesTest.test_check_preprocessor_in_include_section):
3375         Fixed line number.
3376         (NoNonVirtualDestructorsTest.test_multi_line_declaration_with_error):
3377         Ditto.
3378
3379 2010-12-15  Sheriff Bot  <webkit.review.bot@gmail.com>
3380
3381         Unreviewed, rolling out r74136.
3382         http://trac.webkit.org/changeset/74136
3383         https://bugs.webkit.org/show_bug.cgi?id=51135
3384
3385         r74136 breaks chromium canary bots because some tests are not
3386         rebaselined correctly to resolve EOL differences (Requested by
3387         jianli on #webkit).
3388
3389         * Scripts/webkitpy/layout_tests/port/base.py:
3390         * Scripts/webkitpy/layout_tests/port/test.py:
3391         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
3392
3393 2010-12-15  Adam Roben  <aroben@apple.com>
3394
3395         Teach check-webkit-style to check .vcproj and .vsprops files for XML
3396         syntax errors
3397
3398         Fixes <http://webkit.org/b/51103> check-webkit-style should check for
3399         XML syntax errors in .vcproj/.vsprops files
3400
3401         Reviewed by Dave Levin.
3402
3403         * Scripts/webkitpy/style/checker.py: Added lists of file extensions
3404         that should be treated as XML and that should be allowed to contain
3405         carriage returns. (These lists happen to be identical currently.)
3406         (FileType): Added a new XML type.
3407         (CheckerDispatcher.should_check_and_strip_carriage_returns): Added.
3408         Just does a simple file extension check.
3409         (CheckerDispatcher._file_type): Added a case for XML files.
3410         (CheckerDispatcher._create_checker): Ditto. We use XMLChecker for XML
3411         files (surprise!).
3412         (StyleProcessor.process): Ask the dispatcher whether we should pass the
3413         lines through the carriage checker.
3414
3415         * Scripts/webkitpy/style/checker_unittest.py:
3416         (CheckerDispatcherCarriageReturnTest.test_should_check_and_strip_carriage_returns):
3417         Added. Checks a few file names to see if carriage returns are allowed
3418         or not.
3419         (CheckerDispatcherDispatchTest.assert_checker_xml): Added. Similar to
3420         other assert_checker_* functions.
3421         (CheckerDispatcherDispatchTest.test_xml_paths): Added. Similar to other
3422         test_*_paths functions.
3423         (CheckerDispatcherDispatchTest.test_xml_paths): Added. Similar to other
3424         test_*_paths functions.
3425         (CheckerDispatcherDispatchTest.test_none_paths): Removed the vcproj
3426         file from this test case, as vcproj files now have a type.
3427         (StyleProcessor_CodeCoverageTest.MockDispatcher.should_check_and_strip_carriage_returns):
3428         Added. Similar to the other should_* functions.
3429         (StyleProcessor_CodeCoverageTest.test_process__carriage_returns_not_stripped):
3430         Added. Checks that carriage returns aren't checked for or stripped for
3431         allowed files.
3432
3433         * Scripts/webkitpy/style/checkers/xml.py: Added.
3434         (XMLChecker.__init__): Simple init method.
3435         (XMLChecker.check): Pass each line through the expat parser, and record
3436         a style error for any errors thrown by the parser.
3437
3438         * Scripts/webkitpy/style/checkers/xml_unittest.py: Added.
3439         (XMLCheckerTest.assert_no_error): Checks that the given XML does not
3440         produce a style error.
3441         (XMLCheckerTest.assert_error): Checks that the given XML produces an
3442         error of the given category on the given line.
3443         (XMLCheckerTest.mock_handle_style_error): Does nothing. Used for
3444         checking that the XMLChecker constructor works properly.
3445         (XMLCheckerTest.test_conflict_marker): Tests that conflict markers
3446         cause a style error (see, e.g., r73887).
3447         (XMLCheckerTest.test_extra_closing_tag): Tests that extra closing tags
3448         cause a style error (see, e.g., r73773).
3449         (XMLCheckerTest.test_init): Tests that the XMLChecker constructor works
3450         properly.
3451         (XMLCheckerTest.test_missing_closing_tag): Tests that missing closing
3452         tags cause a style error (see, e.g., r72795).
3453         (XMLCheckerTest.test_no_error): Tests that valid XML does not cause a
3454         style error.
3455
3456 2010-12-15  Lucas Forschler  <lforschler@apple.com>
3457
3458         Reviewed by Stephanie Lewis.
3459
3460         https://bugs.webkit.org/show_bug.cgi?id=51117
3461         Add a new leopard test bot
3462         really really commit to trunk this time.
3463
3464         * BuildSlaveSupport/build.webkit.org-config/config.json:
3465
3466 2010-12-15  Sam Weinig  <sam@webkit.org>
3467
3468         Reviewed by Anders Carlsson.
3469
3470         WebKit2: Can't add files to an <input type=file>
3471         https://bugs.webkit.org/show_bug.cgi?id=51087
3472
3473         * MiniBrowser/mac/BrowserWindowController.m:
3474         (runOpenPanel):
3475         (-[BrowserWindowController awakeFromNib]):
3476         Add simple implementation of runOpenPanel callback.
3477
3478         * MiniBrowser/win/BrowserView.cpp:
3479         (BrowserView::create):
3480         * WebKitTestRunner/TestController.cpp:
3481         (WTR::createOtherPage):
3482         (WTR::TestController::initialize):
3483         Stub out runOpenPanel callback. 
3484
3485 2010-12-14  Eric Seidel  <eric@webkit.org>
3486
3487         Reviewed by Adam Barth.
3488
3489         commit-queue should upload failure diffs when tests flake
3490         https://bugs.webkit.org/show_bug.cgi?id=51051
3491
3492         To make this testable I needed to pipe FileSystem down onto tool.
3493         We've wanted it there for a long time anyway.
3494
3495         This patch is kinda a big hack.  But we don't have a nice
3496         way to read results.html files.  I think this will need further
3497         revision before this code actually feels clean.
3498
3499         As part of testing this change, I had to make MockBugzilla.create_bug
3500         actually return an id (like it should) which required updating
3501         a few other unit test results (for the better).
3502
3503         The results_matching_keys change in layouttestresults/rebasline
3504         was an alternate path which I decided not to use in the end, but
3505         I left the change as it seemed an improvement.
3506
3507         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3508         * Scripts/webkitpy/common/net/layouttestresults.py:
3509         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3510         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3511         * Scripts/webkitpy/tool/commands/queues.py:
3512         * Scripts/webkitpy/tool/commands/rebaseline.py:
3513         * Scripts/webkitpy/tool/main.py:
3514         * Scripts/webkitpy/tool/mocktool.py:
3515
3516 2010-12-15  Cosmin Truta  <ctruta@chromium.org>
3517
3518         Reviewed by James Robinson.
3519
3520         new-run-webkit-tests ignores trailing EOL differences in text tests
3521         https://bugs.webkit.org/show_bug.cgi?id=36983
3522
3523         Changed the handling of new-line characters within new-run-webkit-tests
3524         to match old-run-webkit-tests.  Differences in leading and trailing empty
3525         lines in text expectation files are no longer ignored.
3526
3527         * Scripts/webkitpy/layout_tests/port/base.py:
3528         * Scripts/webkitpy/layout_tests/port/test.py:
3529         Added unit tests.  Removed old duplicate unit test entries.
3530         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
3531
3532 2010-12-15  Ojan Vafai  <ojan@chromium.org>
3533
3534         Reviewed by Adam Barth.
3535
3536         make status-bubble white-space:nowrap so we can measure it's width without wrapping
3537         https://bugs.webkit.org/show_bug.cgi?id=51149
3538
3539         * QueueStatusServer/templates/statusbubble.html:
3540
3541 2010-12-15  Ojan Vafai  <ojan@chromium.org>
3542
3543         Reviewed by Adam Barth.
3544
3545         have the statusbubble postMessage it's metrics so that embedders can properly size the iframe
3546         https://bugs.webkit.org/show_bug.cgi?id=51125
3547
3548         * QueueStatusServer/templates/statusbubble.html:
3549
3550 2010-12-15  Darin Adler  <darin@apple.com>
3551
3552         * Scripts/webkitpy/common/net/buildbot: Added property svn:ignore.
3553
3554 2010-12-15  Sheriff Bot  <webkit.review.bot@gmail.com>
3555
3556         Unreviewed, rolling out r74117.
3557         http://trac.webkit.org/changeset/74117
3558         https://bugs.webkit.org/show_bug.cgi?id=51113
3559
3560         This broke the GTK1 build. (Requested by mrobinson on
3561         #webkit).
3562
3563         * Scripts/webkitdirs.pm:
3564
3565 2010-12-15  Amruth Raj  <amruthraj@motorola.com> and Ravi Kasibhatla  <ravi.kasibhatla@motorola.com>
3566
3567         Reviewed by Martin Robinson.
3568
3569         Change generate-forwarding-headers.pl for GTK port usage 
3570         (https://bugs.webkit.org/show_bug.cgi?id=37369)
3571
3572         * Scripts/webkitdirs.pm: Added changes to build webkit2 for GTK port using build-webkit script.
3573
3574 2010-12-14  Kent Tamura  <tkent@chromium.org>
3575
3576         Reviewed by Jian Li.
3577
3578         [DRT/Chromium] Remove another unnecessary error message
3579         https://bugs.webkit.org/show_bug.cgi?id=51083
3580
3581         * DumpRenderTree/chromium/WebViewHost.cpp:
3582         (WebViewHost::didInvalidateRect):
3583
3584 2010-12-14  Lucas Forschler  <lforschler@apple.com>
3585
3586         Reviewed by Stephanie Lewis.
3587
3588         Add a new Leopard Debug Test WK2 Bot
3589
3590         * BuildSlaveSupport/build.webkit.org-config/config.json:
3591
3592 2010-12-14  Ojan Vafai  <ojan@chromium.org>
3593
3594         Fix python unittests after http://trac.webkit.org/changeset/74070.
3595
3596         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
3597
3598 2010-12-14  Kent Tamura  <tkent@chromium.org>
3599
3600         Reviewed by Jian Li.
3601
3602         [DRT/Chromium] Remove a unnecessary error message
3603         https://bugs.webkit.org/show_bug.cgi?id=51069
3604
3605         * DumpRenderTree/chromium/WebViewHost.cpp:
3606         (WebViewHost::paintInvalidatedRegion):
3607
3608 2010-12-14  Benjamin Kalman  <kalman@chromium.org>
3609
3610         Reviewed by Ojan Vafai.
3611
3612         Using BUG/BUGWK in test_expectations is error prone, should use BUGCR/BUGWK
3613         https://bugs.webkit.org/show_bug.cgi?id=48926
3614
3615         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
3616         Add presubmit check that BUG isn't used, either BUGCR/BUGWK/BUGV8_.
3617
3618 2010-12-14  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3619
3620         Reviewed by Eric Seidel.
3621
3622         [Qt] [Symbian] Do not use pkg-config on Symbian as it is not supported
3623         https://bugs.webkit.org/show_bug.cgi?id=50231
3624
3625         Guard CONFIG+=link_pkgconfig with !symbian.
3626
3627         * DumpRenderTree/qt/DumpRenderTree.pro:
3628         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3629         * WebKitTestRunner/qt/WebKitTestRunner.pro:
3630
3631 2010-12-14  Philippe Normand  <pnormand@igalia.com>
3632
3633         Reviewed by Ojan Vafai.
3634
3635         [new-run-webkit-tests] expectations parsing is slow
3636         https://bugs.webkit.org/show_bug.cgi?id=50635
3637
3638         Avoid expensive iteration of all the tests when checking if a test
3639         file is to be skipped or not.
3640
3641         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
3642         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
3643         * Scripts/webkitpy/layout_tests/port/test.py:
3644
3645 2010-12-14  Mario Sanchez Prada  <msanchez@igalia.com>
3646
3647         Reviewed by Xan Lopez.
3648
3649         [Gtk] Implement STATE_FOCUSED, STATE_FOCUSABLE, and corresponding events for text objects
3650         https://bugs.webkit.org/show_bug.cgi?id=27048
3651
3652         Add support in DRT for checking whether an accessibility UI
3653         element is focusable and/or focused. Implemented for GTK.
3654
3655         * DumpRenderTree/AccessibilityUIElement.cpp:
3656         (getIsFocusedCallback): New.
3657         (getIsFocusableCallback): New.
3658         (AccessibilityUIElement::getJSClass): Add the new available
3659         callbacks for isFocused and isFocusable.
3660         * DumpRenderTree/AccessibilityUIElement.h:
3661         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3662         (AccessibilityUIElement::isFocused): New, implemented by checking
3663         whether the related AtkState value is in the object's state set.
3664         (AccessibilityUIElement::isFocusable): Ditto.
3665         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3666         (AccessibilityUIElement::isFocused): New, dummy implementation.
3667         (AccessibilityUIElement::isFocusable): Ditto.
3668         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3669         (AccessibilityUIElement::isFocused): Ditto.
3670         (AccessibilityUIElement::isFocusable): Ditto.
3671
3672 2010-12-14  Eric Seidel  <eric@webkit.org>
3673
3674         Reviewed by Ojan Vafai.
3675
3676         webkit-patch should warn users when they're using a 32-bit git on a 64-bit system
3677         https://bugs.webkit.org/show_bug.cgi?id=50715
3678
3679         This patch makes webkit-patch print the following:
3680
3681         Warning: This machine is 64-bit, but the git binary (/usr/local/git/bin/git) does not support 64-bit.
3682         Install a 64-bit git for better performance, see:
3683         https://lists.webkit.org/pipermail/webkit-dev/2010-December/015249.html
3684
3685         I wrote this mostly because I have approximately 8 machines that I use
3686         and making sure each one is using a good Git install seemed folly.
3687         webkit-patch makes a lot of git calls, so using a fast git can shave
3688         several seconds in every invocation.  See the webkit-dev thread for more info.
3689
3690         This message will print twice during 'webkit-patch upload',
3691         once from webkit-patch and once from check-webkit-style.
3692
3693         Unfortunately there is no good way to test this due to how machine-dependent
3694         the code is.  I considered writing a test for the log message, but it seemed not worth it.
3695
3696         * Scripts/webkitpy/common/checkout/scm.py:
3697
3698 2010-12-13  Eric Seidel  <eric@webkit.org>
3699
3700         Reviewed by Adam Barth.
3701
3702         FlakyTestReporter doesn't understand bots running from multiple email addresses
3703         https://bugs.webkit.org/show_bug.cgi?id=50960
3704
3705         This explains at least one of the dupes of:
3706         https://bugs.webkit.org/show_bug.cgi?id=50863
3707         that we saw filed by the commit-queue this morning.
3708         I think the other one was explained by my previous fix to result counting code.
3709
3710         Since this is really hard to test with a unit test, instead I
3711         create a new (possibly useful in the future) command
3712         which given a layout test path will return you
3713         the one bug which our tools would assume it the flaky test bug.
3714         If some other script wants to use bug-for-test we'll
3715         need to extend it with some options like --create-if-missing or similar.
3716
3717         * Scripts/webkitpy/common/net/bugzilla/bug.py:
3718         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3719         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3720         * Scripts/webkitpy/tool/commands/__init__.py:
3721         * Scripts/webkitpy/tool/commands/bugfortest.py: Added.
3722
3723 2010-12-13  Mihai Parparita  <mihaip@chromium.org>
3724
3725         Reviewed by James Robinson.
3726
3727         Add option to build-webkit to not build WebKit2
3728         https://bugs.webkit.org/show_bug.cgi?id=50988
3729         
3730         Add support for a --no-webkit2 option to build-webkit. It seems to save
3731         ~1 minute from clean builds and ~10 seconds from no-op builds.
3732
3733         * Scripts/build-webkit:
3734
3735 2010-12-13  Lucas Forschler  <lforschler@apple.com>
3736
3737         Reviewed by Dave Kilzer.
3738
3739         Update iexploder from 1.3.2 to 1.7.2
3740         Move 1.3.2 into its own subdir
3741         Add 1.7.2 into its own subdir
3742         update scripts to point to new 1.3.2 location (avoid breaking existing scripts)
3743
3744         * Scripts/run-iexploder-tests:
3745         * Scripts/update-iexploder-cssproperties:
3746         * iExploder/CHANGELOG.txt: Removed.
3747         * iExploder/LICENSE.txt: Removed.
3748         * iExploder/README.txt: Removed.
3749         * iExploder/htdocs: Removed.
3750         * iExploder/iexploder-1.3.2: Added.
3751         * iExploder/iexploder-1.3.2/CHANGELOG.txt: Copied from iExploder/CHANGELOG.txt.
3752         * iExploder/iexploder-1.3.2/LICENSE.txt: Copied from iExploder/LICENSE.txt.
3753         * iExploder/iexploder-1.3.2/README.txt: Copied from iExploder/README.txt.
3754         * iExploder/iexploder-1.3.2/htdocs: Added.
3755         * iExploder/iexploder-1.3.2/htdocs/config.rb: Copied from iExploder/htdocs/config.rb.
3756         * iExploder/iexploder-1.3.2/htdocs/cssproperties.in: Copied from iExploder/htdocs/cssproperties.in.