2011-01-19 Dirk Pranke <dpranke@chromium.org>

[WebKit.git] / Tools / ChangeLog

2011-01-19  Dirk Pranke  <dpranke@chromium.org>

        Unreviewed, build fix.

        Fix test failure caused by committing attachment 79368 instead
        of attachment 79461 on bug 52604.

        * Scripts/webkitpy/common/system/filesystem_mock.py:

2011-01-19  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Mihai Parparita.

        new-run-webkit-tests: remove use of os.walk, use mock filesystem for better
        unit testing. os.walk() is too much of a hassle to implement on
        top of the in-memory mock filesystem and adding the necessary
        interface to files_under() gives clients a cleaner API anyway
        (for this particular usage model).

        https://bugs.webkit.org/show_bug.cgi?id=52691

        * Scripts/webkitpy/common/system/filesystem.py:
        * Scripts/webkitpy/common/system/filesystem_mock.py:
        * Scripts/webkitpy/layout_tests/port/test_files.py:
        * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:

2011-01-19  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Tony Chang.

        Change more modules in the layout-tests code to use the
        filesystem wrapper for cleaner unit testing.

        This patch also adds the glob() wrapper to the filesystem
        abstraction.
        
        https://bugs.webkit.org/show_bug.cgi?id=52604

        * Scripts/webkitpy/layout_tests/port/test_files.py:
        * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
        * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
        * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
        * Scripts/webkitpy/common/system/filesystem.py:
        * Scripts/webkitpy/common/system/filesystem_mock.py:

2011-01-19  Levi Weintraub  <leviw@chromium.org>

        Unreviewed.

        Updating my email addresses and irc nick.

        * Scripts/webkitpy/common/config/committers.py:

2011-01-19  Tony Chang  <tony@chromium.org>

        Reviewed by Mihai Parparita.

        [chromium] [linux] if check-sys-deps fails, output the failure reason
        https://bugs.webkit.org/show_bug.cgi?id=52671

        * Scripts/webkitpy/common/system/executive_mock.py: Add support for
            error handler functions.
        * Scripts/webkitpy/layout_tests/port/chromium.py:
            output the error text from --check-sys-deps
        * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:

2011-01-19  Aparna Nandyal  <aparna.nand@wipro.com>

        Reviewed by Andreas Kling.

        [Qt] QtTestBrowser crashes when closing if Facebook is opened
        https://bugs.webkit.org/show_bug.cgi?id=52554
        
        QtNetworkAccessManager is created in a thread and set as
        member variable in QWebPage. When the thread is destroyed
        the object is still used. So fix will set the object to
        NULL once the thread is destroyed.

        * QtTestBrowser/launcherwindow.cpp:
        (LauncherWindow::~LauncherWindow):

2011-01-18  Maciej Stachowiak  <mjs@apple.com>

        Rubber stamped by Csaba Osztrogonac

        * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: Removed unncessary inculde of WKStringCF.h

2011-01-18  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Tony Chang.

        new-run-webkit-tests: add a --build-directory command line argument

        Official Google Chrome builds use a non-standard build directory
        location. This patch adds a --build-directory argument that
        allows that location to be specified on the command line. Only
        Chromium-based builds will use this flag for now, but anyone can
        in the future.

        There are no unit tests for this since it's difficult to test
        until mock filesystems are fully supported in the code. This was
        tested by hand for now.

        https://bugs.webkit.org/show_bug.cgi?id=52694

        * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
        * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
        * Scripts/webkitpy/layout_tests/port/chromium_win.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:

2011-01-18  Maciej Stachowiak  <mjs@apple.com>

        Not reviewed. Bot fix.

        Remove an inadvertently committed debugging print.

        * DumpRenderTree/mac/LayoutTestControllerMac.mm:
        (LayoutTestController::notifyDone):

2011-01-18  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Sam Weinig.

        WebKitTestRunner should track loading more like DumpRenderTree
        https://bugs.webkit.org/show_bug.cgi?id=52692

        Change load tracking to track the current top loading frame, in the manner of DumpRenderTree.
        This makes some tests that call notifyDone multiple times pass.
        
        * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
        (WTR::InjectedBundle::InjectedBundle):
        (WTR::InjectedBundle::done):
        * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
        (WTR::InjectedBundle::topLoadingFrame):
        (WTR::InjectedBundle::setTopLoadingFrame):
        * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
        (WTR::InjectedBundlePage::InjectedBundlePage):
        (WTR::InjectedBundlePage::stopLoading):
        (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
        (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
        (WTR::InjectedBundlePage::didFinishLoadForFrame):
        (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
        * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
        * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
        (WTR::LayoutTestController::notifyDone):
        * WebKitTestRunner/TestController.cpp:
        (WTR::TestController::didReceiveMessageFromInjectedBundle):

2011-01-18  Mihai Parparita  <mihaip@chromium.org>

        Reviewed by Kent Tamura.

        [Chromium] NRWT looking for DRT binary in the wrong path on Mac
        https://bugs.webkit.org/show_bug.cgi?id=52678
        
        Update path now that WebKit is inside Source.

        * Scripts/webkitpy/layout_tests/port/chromium_mac.py:

2011-01-18  Robert Hogan  <robert@webkit.org>

        Reviewed by Simon Hausmann.

        [Qt] http/tests/incremental/slow-utf8-text.pl fails
        https://bugs.webkit.org/show_bug.cgi?id=44282

        * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
        (WebCore::DumpRenderTree::dump):

2011-01-18  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Mihai Parparita.

        Fix a small race condition that could cause the unit tests for
        new-run-webkit-tests to fail in a multithreaded environment.
        There was a small window in the code where one thread would
        check to see if a thread had raised an exception, do something,
        and then check to see if the thread was alive. If the other
        thread raised an exception and exited in between these two
        steps, the exception would be lost. Flipping the order of the
        two checks fixes the race, since we will now always check for an
        exception on the thread before exiting.

        https://bugs.webkit.org/show_bug.cgi?id=51579

        * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:

2011-01-18  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        commit-queue dies when test archiving fails
        https://bugs.webkit.org/show_bug.cgi?id=52617

        I looked at the machine and it had 10 archives already
        thus find_unused_name was returning None.  I've upped
        the limit to 100 (per bug) and tested the case where
        find_unused_name returns None (making archive return None).

        * Scripts/webkitpy/common/system/workspace.py:
        * Scripts/webkitpy/common/system/workspace_unittest.py:
        * Scripts/webkitpy/tool/bot/commitqueuetask.py:
        * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
        * Scripts/webkitpy/tool/commands/queues.py:

2011-01-18  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Ojan Vafai.

        Update rebaseline-chromium-webkit-tests unit tests to use a mock
        filesystem. Also fix a couple of "with" statements missed by
        r76050.

        https://bugs.webkit.org/show_bug.cgi?id=52487

        * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:

2011-01-18  Sergio Villar Senin  <svillar@igalia.com>

        Reviewed by Martin Robinson.

        [Gtk] Build fixes for gtk3 build
        https://bugs.webkit.org/show_bug.cgi?id=52648

        * DumpRenderTree/gtk/EventSender.cpp:
        (beginDragWithFilesCallback):

2011-01-18  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Mihai Parparita.

        Update rebaseline-chromium-webkit-tests to use filesystem objects
        instead of direct references to os.path, shutil, tempfile, etc.

        This patch doesn't change anything, but will allow subsequent
        patches to change the unit tests to no longer use the real
        filesystem.

        This patch adds a bunch more methods to the filesystem object as
        well.

        https://bugs.webkit.org/show_bug.cgi?id=52482

        * Scripts/webkitpy/common/system/filesystem.py:
        * Scripts/webkitpy/common/system/filesystem_mock.py:
        * Scripts/webkitpy/tool/commands/queues.py:
        * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
        * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:

2011-01-18  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Mihai Parparita.

        new-run-webkit-tests shouldn't crash when you try to run a
        directory containing only skipped files.

        https://bugs.webkit.org/show_bug.cgi?id=52478
        
        * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
        * Scripts/webkitpy/layout_tests/port/test.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:

2011-01-18  Adam Bergkvist  <adam.bergkvist@ericsson.com> and Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Gustavo Noronha Silva.

        [GTK] The GTK+ EventSender needs support for beginDragWithFiles
        https://bugs.webkit.org/show_bug.cgi?id=40833

        * DumpRenderTree/gtk/EventSender.cpp: Add a beginDragWithFiles implementation for the
        GTK+ event sender.
        (dragWithFilesDragDataGetCallback): Added.
        (dragWithFilesDragEndCallback): Added.
        (beginDragWithFilesCallback): Added.

2011-01-18  Gyuyoung Kim  <gyuyoung.kim@samsung.com>

        Reviewed by Adam Barth.

        ews: Add additional watcher to efl ews
        https://bugs.webkit.org/show_bug.cgi?id=52613

        Add gyuyoung.kim@samsung.com to watcher list of efl-ews.

        * Scripts/webkitpy/tool/commands/earlywarningsystem.py:

2011-01-17  Tony Gentilcore  <tonyg@chromium.org>

        Reviewed by Alexey Proskuryakov.

        Fix some headers with missing or misspelled #ifndef guards
        https://bugs.webkit.org/show_bug.cgi?id=52545

        * DumpRenderTree/chromium/TestEventPrinter.h:
        * DumpRenderTree/chromium/WebPreferences.h:

2011-01-17  Jessie Berlin  <jberlin@apple.com>

        Reviewed by Anders Carlsson.

        REGRESSION: Assertion failure in FrameLoader::continueLoadAfterWillSubmitForm() when
        navigating back to an unreachable URL
        https://bugs.webkit.org/show_bug.cgi?id=52388

        Add a third parameter (unreachableURL) to queueLoadHTMLString.

        * DumpRenderTree/LayoutTestController.cpp:
        (queueLoadHTMLStringCallback):
        (LayoutTestController::queueLoadHTMLString):
        (LayoutTestController::queueLoadAlternateHTMLString):
        * DumpRenderTree/LayoutTestController.h:

        * DumpRenderTree/WorkQueueItem.h:
        (LoadHTMLStringItem::LoadHTMLStringItem):

        * DumpRenderTree/chromium/LayoutTestController.cpp:
        (WorkItemLoadHTMLString::WorkItemLoadHTMLString):
        (WorkItemLoadHTMLString::run):
        (LayoutTestController::queueLoadHTMLString):

        * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
        (LoadHTMLStringItem::invoke):
        * DumpRenderTree/mac/WorkQueueItemMac.mm:
        (LoadHTMLStringItem::invoke):
        * DumpRenderTree/win/WorkQueueItemWin.cpp:
        (LoadHTMLStringItem::invoke):

2011-01-17  Dan Bernstein  <mitz@apple.com>

        Rubber-stamped by Mark Rowe.

        Update xcodeproj svn:ignore to include xcuserdata.

        * DumpRenderTree/DumpRenderTree.xcodeproj: Modified property svn:ignore.
        * MiniBrowser/MiniBrowser.xcodeproj: Modified property svn:ignore.
        * TestWebKitAPI/TestWebKitAPI.xcodeproj: Modified property svn:ignore.
        * WebKitLauncher/WebKitLauncher.xcodeproj: Modified property svn:ignore.
        * WebKitTestRunner/WebKitTestRunner.xcodeproj: Modified property svn:ignore.

2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>

        Unreviewed fix after r75908.

        Move WebKit into Source
        https://bugs.webkit.org/show_bug.cgi?id=52530

        * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add Source to the path for Qt API tests.

2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>

        Unreviewed.

        Remove accidentally committed debug printing after r75908.

        * Scripts/webkitdirs.pm:

2011-01-17  John Knottenbelt  <jknotten@chromium.org>

        Unreviewed.

        Add myself to committers list
        https://bugs.webkit.org/show_bug.cgi?id=52566

        * Scripts/webkitpy/common/config/committers.py:

2011-01-17  John Knottenbelt  <jknotten@chromium.org>

        Reviewed by Jeremy Orlow.

        GeolocationController should call stopUpdating on destruction
        https://bugs.webkit.org/show_bug.cgi?id=52216

        fast/dom/Geolocation/window-close-crash.html requires that a
        Geolocation watch be started in a secondary window. Consequently,
        we need to allow geolocation permission and provide a mock
        geolocation position for the secondary window's
        GeolocationClientMock.

        * DumpRenderTree/chromium/LayoutTestController.cpp:
        (LayoutTestController::setGeolocationPermission):
        (LayoutTestController::setMockGeolocationPosition):
        (LayoutTestController::setMockGeolocationError):
        * DumpRenderTree/chromium/TestShell.h:
        (TestShell::windowList):

2011-01-16  Adam Barth  <abarth@webkit.org>

        Update more include paths to reflect WebKit move.

        * DumpRenderTree/chromium/EventSender.cpp:
        (EventSender::keyDown):
        (EventSender::needsShiftModifier):
        * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
        * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:

2011-01-16  Kent Tamura  <tkent@chromium.org>

        Unreviewed, Chromium build fix.

        * Scripts/update-webkit-chromium: Webkit/chromium -> Source/WebKit/chromium

2011-01-16  Martin Robinson  <mrobinson@igalia.com>

        Build fix for GTK+ after source directory movement.

        * GNUmakefile.am: Correct include paths.

2011-01-16  Adam Barth  <abarth@webkit.org>

        Teach svn-apply about WebKit move.

        * Scripts/VCSUtils.pm:

2011-01-16  Adam Barth  <abarth@webkit.org>

        Rubber-stamped by Eric Seidel.

        Move WebKit into Source
        https://bugs.webkit.org/show_bug.cgi?id=52530

        * DumpRenderTree/mac/InternalHeaders/WebKit/WebTypesInternal.h:
        * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
        * DumpRenderTree/qt/DumpRenderTreeQt.h:
        * DumpRenderTree/qt/GCControllerQt.cpp:
        * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
        * DumpRenderTree/qt/PlainTextControllerQt.cpp:
        * DumpRenderTree/qt/TextInputControllerQt.cpp:
        * DumpRenderTree/wscript:
        * QtTestBrowser/launcherwindow.h:
        * Scripts/build-webkit:
        * Scripts/webkitdirs.pm:

2011-01-15  Adam Barth  <abarth@webkit.org>

        Teach svn-apply about WebKit2 move.

        * Scripts/VCSUtils.pm:

2011-01-15  Adam Barth  <abarth@webkit.org>

        Rubber-stamped by Eric Seidel.

        Move WebKit2 into Source
        https://bugs.webkit.org/show_bug.cgi?id=52438

        * MiniBrowser/qt/MiniBrowser.pro:
        * Scripts/build-webkit:
        * Scripts/do-file-rename:
        * Scripts/do-webcore-rename:
        * Scripts/test-webkitpy:
        * Scripts/webkitdirs.pm:
        * Scripts/webkitpy/style/checker.py:
        * WebKitTestRunner/DerivedSources.pro:
        * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
        * WebKitTestRunner/qt/WebKitTestRunner.pro:

2011-01-15  Jochen Eisinger  <jochen@chromium.org>

        Reviewed by David Levin.

        [chromium] remove obsolete createView method
        https://bugs.webkit.org/show_bug.cgi?id=52437

        * DumpRenderTree/chromium/WebViewHost.cpp:
        (WebViewHost::createView):
        * DumpRenderTree/chromium/WebViewHost.h:

2011-01-14  Brian Weinstein  <bweinstein@apple.com>

        Reviewed by Geoff Garen.

        ShouldLoadResourceForFrame should use strings, not URLs.
        https://bugs.webkit.org/show_bug.cgi?id=52476

        * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
        (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Update to use a WKStringRef.
        * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:

2011-01-14  Tony Gentilcore  <tonyg@chromium.org>

        Reviewed by David Levin.

        Add Tony Gentilcore as a reviewer
        https://bugs.webkit.org/show_bug.cgi?id=52480

        * Scripts/webkitpy/common/config/committers.py:

2011-01-14  David Levin  <levin@chromium.org>

        Reviewed by Eric Seidel.

        check-webkit-style: _FunctionState should keep track of where the function name starts.
        https://bugs.webkit.org/show_bug.cgi?id=52454

        * Scripts/webkitpy/style/checkers/cpp.py: Added function_name_start_position to
        _FunctionState and logic for setting it correctly.
        * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests.

2011-01-14  Vincent Scheib  <scheib@chromium.org>

        Reviewed by David Levin.

        Add support to DumpRenderTree to use the GPU rather than software renderer
        https://bugs.webkit.org/show_bug.cgi?id=52333

        * DumpRenderTree/chromium/DumpRenderTree.cpp:
        (main):
        * Scripts/webkitpy/layout_tests/port/chromium.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:

2011-01-14  Tony Chang  <tony@chromium.org>

        Reviewed by Kent Tamura.

        [chromium] update fonts.conf to fix 6 linux tests in drt
        https://bugs.webkit.org/show_bug.cgi?id=52411

        * DumpRenderTree/chromium/fonts.conf: Update to match the copy in
            chromium's src/webkit/tools/test_shell/resources/fonts.conf

2011-01-14  Eric Seidel  <eric@webkit.org>

        Original patch from Peter Gal  <galpater@inf.u-szeged.hu>

        Reviewed by Adam Barth.

        Fix when running Tools/Scripts/check-webkit-style without arguments.
        https://bugs.webkit.org/show_bug.cgi?id=52261#c16

        * Scripts/webkitpy/common/checkout/scm.py: Handle None for changed_files argument better in Git.create_patch method.
        * Scripts/webkitpy/common/checkout/scm_unittest.py:

2011-01-04  Jochen Eisinger  <jochen@chromium.org>

        Reviewed by David Levin.

        Store the tempdir object in a variable so it doesn't get deleted too early.
        https://bugs.webkit.org/show_bug.cgi?id=51875

        * Scripts/update-webkit-auxiliary-libs:
        * Scripts/update-webkit-support-libs:

2011-01-14  Eric Seidel  <eric@webkit.org>

        Unreviewed.  Make it work in python 2.5.

        webkit-patch suggest-reviewers dies when ChangeLogs are missing
        https://bugs.webkit.org/show_bug.cgi?id=49158

        * Scripts/webkitpy/common/checkout/api_unittest.py:

2011-01-14  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r75774.
        http://trac.webkit.org/changeset/75774
        https://bugs.webkit.org/show_bug.cgi?id=52431

        gtk builds were broken (Requested by loislo2 on #webkit).

        * Scripts/webkitpy/common/checkout/scm.py:

2011-01-14  David Levin  <levin@chromium.org>

        Reviewed by Shinichiro Hamaji.

        check-webkit-style: _FunctionState should detect pure functions.
        https://bugs.webkit.org/show_bug.cgi?id=52428

        * Scripts/webkitpy/style/checkers/cpp.py: Added detection for if a function declaration
        is a pure virtual function.
        * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests for verifying that pure
        virtual functions are correctly detected.

2011-01-13  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Yury Semikhatsky.

        Just small fix for problem with check-webkit-style.
        It just didn't work for this patch.
        Old code can't concatenate a list of strings with None.

        * Scripts/webkitpy/common/checkout/scm.py:

2011-01-13  David Levin  <levin@chromium.org>

        Reviewed by Shinichiro Hamaji.

        check-webkit-style: _FunctionState should use Position to know where items are.
        https://bugs.webkit.org/show_bug.cgi?id=52424

        * Scripts/webkitpy/style/checkers/cpp.py:
        (_FunctionState.*): Changed _FunctionState to use Position instead of line numbers.
        (detect_functions): Changed to pass Position's to _FunctionState.begin and
        did some minor clean-up.
        (*): Other changes are simply about converting to use the Position's in_FunctionState
        instead of line numbers.
        * Scripts/webkitpy/style/checkers/cpp_unittest.py: Changed the test code
        to verify the positions stored in _FunctionState.

2011-01-13  Eric Seidel  <eric@webkit.org>

        Reviewed by David Levin.

        webkit-patch suggest-reviewers dies when ChangeLogs are missing
        https://bugs.webkit.org/show_bug.cgi?id=49158

        This is not the most elegant, but it is a very safe fix to this bug.
        One advantage of catching ScriptError like this instead of adding a
        new added_or_modified_files or fixing all changed_files callers
        to use a more specific change_files variant, is that we catch
        all kinds of ScriptErrors which might cause our (non-essential)
        suggest-reviewers code to fail out.  This should make passing
        --suggest-reviewers to webkit-patch upload much more robust
        and may even make it possible for us to make it default.

        The root of the problem here is that SCM.changed_files includes
        deleted ChangeLog paths (from moves, etc) which then when we ask
        SVN/Git for the contents of the file at that revision, the command
        errors out and Executive.run_command raises a ScriptError.

        In the future we might fix this differently by making all current
        callers of chagned_files use a more specific method for requesting
        what types of changes they're interested in (adds, modifies, deletes, etc.)

        * Scripts/webkitpy/common/checkout/api.py:
        * Scripts/webkitpy/common/checkout/api_unittest.py:

2011-01-13  Dan Bernstein  <mitz@apple.com>

        Reviewed by Alexey Proskuryakov.

        <rdar://problem/8827065> REGRESSION (r71884): Cross-origin XHR fails if willSendRequest changes the URL
        https://bugs.webkit.org/show_bug.cgi?id=52419

        Allow to further control the behavior of the willSendRequest delegate callback by making it
        set a different URL in the new request.

        * DumpRenderTree/LayoutTestController.cpp:
        (addURLToRedirectCallback): Added.
        (LayoutTestController::staticFunctions): Added addURLToRedirect.
        (LayoutTestController::addURLToRedirect): Added. Adds the redirection to the map.
        (LayoutTestController::redirectionDestinationForURL): Added this getter.
        * DumpRenderTree/LayoutTestController.h:
        * DumpRenderTree/mac/ResourceLoadDelegate.mm:
        (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]): Check
        if there is a redirection for the request’s URL, established by addURLToRedirect(), and if so,
        change the URL in the new request to the redirect destination.

2011-01-13  Eric Seidel  <eric@webkit.org>

        Reviewed by Mihai Parparita.

        webkit-patch suggest-reviewers fails due to invalid utf8 in ChangeLog files
        https://bugs.webkit.org/show_bug.cgi?id=52416

        Example: webkit-patch suggest-reviewers -g ca3890fe74d94d85d6bfa48f9ea497b094d8e717 
        UnicodeDecodeError: 'utf8' codec can't decode bytes in position 536-538: invalid data

        I also added FIXMEs about the changed_files returning deleted files problem
        which is causing the other most common exception for suggest-reviewers
        (and is probably breaking sheriff-bots blame detection).

        * Scripts/webkitpy/common/checkout/api.py:
        * Scripts/webkitpy/common/checkout/api_unittest.py:
        * Scripts/webkitpy/common/checkout/scm.py:

2011-01-13  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        results archives from commit-queue are too large to upload
        https://bugs.webkit.org/show_bug.cgi?id=52405

        * Scripts/webkitpy/common/system/filesystem.py:
        * Scripts/webkitpy/common/system/filesystem_mock.py:
        * Scripts/webkitpy/tool/commands/queues.py:

2011-01-13  Alejandro G. Castro  <alex@igalia.com>

        Reviewed by Martin Robinson.

        [gtk] Zero-sized font does not yet work
        https://bugs.webkit.org/show_bug.cgi?id=49793

        Set minimum-font-size to 0 for the DRT.

        * DumpRenderTree/gtk/DumpRenderTree.cpp:
        (resetDefaultsToConsistentValues):

2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>

        Reviewed by Darin Adler.

        Make old-run-webkit-tests more robust on buildbots
        https://bugs.webkit.org/show_bug.cgi?id=52364

        * BuildSlaveSupport/build.webkit.org-config/master.cfg: Pass --exit-after-n-failures 500 to old-run-webkit-tests script.

2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>

        Reviewed by Darin Adler.

        Make old-run-webkit-tests more robust on buildbots
        https://bugs.webkit.org/show_bug.cgi?id=52364

        * Scripts/old-run-webkit-tests: Ensure that testResultsDirectory is empty.

2011-01-13  Tony Chang  <tony@chromium.org>

        Reviewed by Kent Tamura.

        [chromium] fix plugins/plugin-javascript-access.html on Linux and Mac
        https://bugs.webkit.org/show_bug.cgi?id=52332

        Forked Info.plist is not longer needed.

        * DumpRenderTree/chromium/TestNetscapePlugIn/Info.plist: Removed.

2011-01-13  Mikhail Naganov  <mnaganov@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: Cleanup after r75613 -- make all UI-facing strings
        to be passed directly to WebInspector.UIString

        https://bugs.webkit.org/show_bug.cgi?id=52365

        * Scripts/check-inspector-strings:

2011-01-13  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r74881.
        http://trac.webkit.org/changeset/74881
        https://bugs.webkit.org/show_bug.cgi?id=52357

        The EFL builder has been red for days (Requested by abarth on
        #webkit).

        * Scripts/webkitpy/common/net/buildbot/buildbot.py:
        * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:

2011-01-12  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by David Levin.

        Add beforeunload support to WebKitTestRunner
        https://bugs.webkit.org/show_bug.cgi?id=52353
        
        This makes a number of currently failing tests pass.

        * WebKitTestRunner/TestController.cpp:
        (WTR::runBeforeUnloadConfirmPanel):
        (WTR::createOtherPage):
        (WTR::TestController::initialize):

2011-01-12  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Sam Weinig.

        Detect, identify and recover from WebProcess crashes in run-webkit-tests
        https://bugs.webkit.org/show_bug.cgi?id=52330

        * Scripts/old-run-webkit-tests: Detect when the regression test tool reports
        a web process crash.
        * WebKitTestRunner/TestController.cpp:
        (WTR::TestController::initialize): Set up a processDidCrash
        callback.
        (WTR::TestController::processDidCrash): Report that the Web process
        crashed.
        * WebKitTestRunner/TestController.h:

2011-01-12  David Levin  <levin@chromium.org>

        Reviewed by Shinichiro Hamaji.

        check-webkit-style -- close_expression function doesn't work correctly.
        https://bugs.webkit.org/show_bug.cgi?id=52272

        * Scripts/webkitpy/style/checkers/cpp.py:
        (Position.__str__): Added a way to convert it to a string which is useful in tests.
        (Position.__cmp__): Added a way to compare Position which is useful in tests and
        generally useful (for upcoming code changes).
        (close_expression): Changed to use Position for input and output.
        Also, fixed many bugs such as only working correctly for parenthesis,
        not working correctly if given an offset in a line and not finding
        the real closing element if there were multiple closing elements in
        the same line.
        (detect_functions): Adjusted due to the change in arguments for
        close_expression.
        * Scripts/webkitpy/style/checkers/cpp_unittest.py:
        (CppStyleTestBase.assert_positions_equal): Added a way to verify that
        two positions are the same.
        (CppStyleTest.test_position): Added tests for the __str_ and __cmp__ methods.
        (CppStyleTest.test_close_expression): Added tests to catch the issues
        that were fixed.

2011-01-12  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r75576.
        http://trac.webkit.org/changeset/75576
        https://bugs.webkit.org/show_bug.cgi?id=52304

        broke rebaseline-chromium-webkit-test (Requested by thakis on
        #webkit).

        * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
        * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
        * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
        * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
        * Scripts/webkitpy/layout_tests/port/base.py:
        * Scripts/webkitpy/layout_tests/port/chromium.py:
        * Scripts/webkitpy/layout_tests/port/port_testcase.py:
        * Scripts/webkitpy/layout_tests/port/test.py:
        * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
        * Scripts/webkitpy/style/checkers/test_expectations.py:
        * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:

2011-01-12  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Darin Adler.

        Add a no-build option to run-webkit-tests, to avoid building DRT/WKTR
        https://bugs.webkit.org/show_bug.cgi?id=52307

        * Scripts/old-run-webkit-tests:

2011-01-12  Koan-Sin Tan  <koansin.tan@gmail.com>

        Reviewed by Martin Robinson.

        [Gtk] WebKitGtk+ doesn't build on Mac OS X 10.6
        https://bugs.webkit.org/show_bug.cgi?id=50867

        Fixed library extention for Mac in webkitdirs.pm and type conflict in
        TestNetscapePlugin.cpp 

        * GNUmakefile.am: Don't use AppKit when compiling TestNetscapePlugin for GTK+
        * Scripts/webkitdirs.pm:

2011-01-12  Mikhail Naganov  <mnaganov@chromium.org>

        Reviewed by Pavel Feldman.

        Add check-inspector-strings script.

        https://bugs.webkit.org/show_bug.cgi?id=52295

        * Scripts/check-inspector-strings: Added.

2011-01-12  Adam Roben  <aroben@apple.com>

        Advertise the .testnetscape file extension on Windows

        Fixes <http://webkit.org/b/52298>
        plugins/no-mime-with-valid-extension.html fails on Windows

        Reviewed by Dan Bernstein.

        * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Added a
        FileExtents field to map the .testnetscape file extension to the
        application/x-webkit-test-netscape MIME type, just as we do on Mac.

2011-01-12  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Make webkit-patch support subdirectories for SVN checkouts
        https://bugs.webkit.org/show_bug.cgi?id=52261

        os.relpath does not exist on Python 2.5, so we need to call our version
        of the API.

        * Scripts/webkitpy/common/checkout/scm.py:

2011-01-11  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Eric Seidel.

        Close additional pages opened during a test once the test completes.
        https://bugs.webkit.org/show_bug.cgi?id=52276

        * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
        (WTR::InjectedBundle::done):

2011-01-11  David Levin  <levin@chromium.org>

        Reviewed by Eric Seidel.

        Errors should be separated from the command line in bot messages.
        https://bugs.webkit.org/show_bug.cgi?id=52275

        * Scripts/webkitpy/common/system/executive.py:
        (ScriptError.message_with_output): Added a newline to separate the command
        line from the errors.
        * Scripts/webkitpy/common/system/executive_unittest.py:
        (ScriptErrorTest.test_message_with_output): Added tests for the various code
        paths in message_with_output.

2011-01-11  Eric Seidel  <eric@webkit.org>

        Unreviewed.

        commit-queue should know how to upload archived results (for test flakes or general failures)
        https://bugs.webkit.org/show_bug.cgi?id=52048

        The zips are mostly empty due to forgetting -r.
        Expected diffs were not being pulled from the archive due
        to the archive having longer paths than I realized.

        * Scripts/webkitpy/common/system/workspace.py:
        * Scripts/webkitpy/common/system/workspace_unittest.py:
        * Scripts/webkitpy/tool/bot/flakytestreporter.py:
        * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:

2011-01-11  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Ojan Vafai.

        The current modifier parsing code in test_expectations is
        fragile and hard-coded, so it's not easy to understand the logic
        or easily add new types of modifiers (like GPU vs. CPU testing
        for graphics tests, or 32-bit vs. 64-bit differences).

        This is the first of two patches that will add in more generic
        support and then eliminate the GPU-specific test expectations
        files for Chromium.

        This patch adds two standalone objects for handling modifiers. The
        rules for interpreting modifiers, precedence, and conflicts are
        given in the docstring to the ModifierMatcher class, which
        returns ModifierMatchResult objects.
        
        This patch also adds routines to the Port interface and a
        default set of values in the base object, in order to obtain the
        values needed on a given test run. These values are then passed
        to the expectation parser. This also allows us to clean up the
        logic used to lint all of the different configurations in a
        single test_expectations.txt file.

        The next patch will merge in the separate GPU expectations file.

        https://bugs.webkit.org/show_bug.cgi?id=51222

        * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
        * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
        * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
        * Scripts/webkitpy/layout_tests/port/base.py:
        * Scripts/webkitpy/layout_tests/port/base_unittest.py:
        * Scripts/webkitpy/layout_tests/port/chromium.py:
        * Scripts/webkitpy/layout_tests/port/port_testcase.py:
        * Scripts/webkitpy/layout_tests/port/test.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:

2011-01-11  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Adam Barth.

        Make webkit-patch support subdirectories for SVN checkouts
        https://bugs.webkit.org/show_bug.cgi?id=52261

        * Scripts/webkitpy/common/checkout/scm.py:
        * Scripts/webkitpy/style_references.py:
        * Scripts/webkitpy/tool/main.py:
        * Scripts/webkitpy/tool/steps/preparechangelog.py:

2011-01-11  Eric Seidel  <eric@webkit.org>

        Unreviewed.

        commit-queue should know how to upload archived results (for test flakes or general failures)
        https://bugs.webkit.org/show_bug.cgi?id=52048

        I changed the API for archive_last_layout_test_results w/o updating the implementation.  Oops.
        This fixes an exception seen on the commit-queue when attempting to report flaky tests.

        * Scripts/webkitpy/common/system/workspace.py:
        * Scripts/webkitpy/common/system/workspace_unittest.py:
        * Scripts/webkitpy/tool/commands/queues.py:

2011-01-11  Sam Weinig  <sam@webkit.org>

        Roll r75474 back in.

2011-01-11  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Remove uses of QFuture since it isn't supported on all platforms.
        https://bugs.webkit.org/show_bug.cgi?id=51204

        * QtTestBrowser/webpage.h:
        (QtNAMThread::QtNAMThread):
        (QtNAMThread::networkAccessManager):
        (QtNAMThread::run):

2011-01-11  Peter Varga  <pvarga@webkit.org>

        Unreviewed.

        Add myself to committers' list.

        * Scripts/webkitpy/common/config/committers.py:

2011-01-11  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        commit-queue should know how to upload archived results (for test flakes or general failures)
        https://bugs.webkit.org/show_bug.cgi?id=52048

        Now the queue will always upload results.  Either the entire zip, or just
        the diffs.txt in the case of text failures.

        This should make understanding flakes much easier, and paves the way
        for having the EWS run layout tests (and upload failures).

        In order to upload .zip files I had to teach bugzilla.py to autodetect
        mime types from the filename.  Since mimetypes.py doesn't include a mapping
        for .patch files, I have it add one before calling guess_type.

        We may find that always uploading the whole zip instead of just the -diffs.txt
        file is preferable, but for now I'm keeping the old behavior because it makes
        quickly understanding text failures easy.

        * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
        * Scripts/webkitpy/common/system/workspace.py: Added.
        * Scripts/webkitpy/common/system/workspace_unittest.py: Added.
        * Scripts/webkitpy/tool/bot/commitqueuetask.py:
        * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
        * Scripts/webkitpy/tool/bot/flakytestreporter.py:
        * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
        * Scripts/webkitpy/tool/commands/queues.py:
        * Scripts/webkitpy/tool/commands/queues_unittest.py:

2011-01-10  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r75464.
        http://trac.webkit.org/changeset/75464
        https://bugs.webkit.org/show_bug.cgi?id=52193

        Followup rollout for 75474 (Requested by Ossy on #webkit).

        * MiniBrowser/mac/BrowserWindowController.m:
        (-[BrowserWindowController awakeFromNib]):
        * MiniBrowser/win/BrowserView.cpp:
        (BrowserView::create):
        * WebKitTestRunner/TestController.cpp:
        (WTR::createOtherPage):
        (WTR::TestController::initialize):

2011-01-10  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Csaba Osztrogonác.

        [Qt] Baseline qt_minimal configuration
        https://bugs.webkit.org/show_bug.cgi?id=51313

        * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
        (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): Add
        QT_NO_UNDOSTACK guard.

        * QtTestBrowser/launcherwindow.cpp:
        (LauncherWindow::createChrome): Add QT_NO_SHORTCUT and QT_NO_PRINTER
        guards.
        (LauncherWindow::applyZoom): Add QT_NO_ANIMATION guard.
        (LauncherWindow::screenshot): Add QT_NO_FILEDIALOG guard.
        (LauncherWindow::selectElements): Add QT_NO_INPUTDIALOG guard.
        (LauncherWindow::showUserAgentDialog): Add QT_NO_COMBOBOX guard.

        * QtTestBrowser/launcherwindow.h:
        * QtTestBrowser/locationedit.cpp: Add QT_NO_INPUTDIALOG guard.
        * QtTestBrowser/locationedit.h: Ditto.

        * QtTestBrowser/mainwindow.cpp:
        (MainWindow::buildUI): Add QT_NO_INPUTDIALOG, QT_NO_SHORTCUT and
        QT_NO_UNDOSTACK guards.
        (MainWindow::setAddressUrl): Add QT_NO_INPUTDIALOG guard.
        (MainWindow::changeLocation): Ditto.
        (MainWindow::openFile): Add QT_NO_FILEDIALOG guard.
        (MainWindow::openLocation): Add QT_NO_INPUTDIALOG guard.

        * QtTestBrowser/webpage.cpp:
        (WebPage::openUrlInDefaultBrowser): Add QT_NO_DESKTOPSERVICES guard.
        (WebPage::authenticationRequired): Add QT_NO_LINEEDIT guard.

        * QtTestBrowser/webview.cpp:
        (WebViewGraphicsBased::animatedFlip): Add QT_NO_ANIMATION guard.
        (WebViewGraphicsBased::animatedYFlip): Ditto.

2011-01-10  Sam Weinig  <sam@webkit.org>

        Fix build.

        * MiniBrowser/mac/BrowserWindowController.m:
        (-[BrowserWindowController awakeFromNib]):
        * MiniBrowser/win/BrowserView.cpp:
        (BrowserView::create):
        * WebKitTestRunner/TestController.cpp:
        (WTR::createOtherPage):
        (WTR::TestController::initialize):

2011-01-10  Eric Seidel  <eric@webkit.org>

        Reviewed by Ojan Vafai.

        style-queue messages are way too long for big patches
        https://bugs.webkit.org/show_bug.cgi?id=52161

        We definitely could build much fancier list-to-string-with-limit functions
        but this should be sufficient for our needs at the moment.

        * Scripts/webkitpy/common/system/executive.py:
        * Scripts/webkitpy/common/system/executive_unittest.py:

2011-01-10  Tony Chang  <tony@chromium.org>

        Unreviewed, rolling out r75398.
        http://trac.webkit.org/changeset/75398
        https://bugs.webkit.org/show_bug.cgi?id=52008

        Some layout tests are crashing on Chromium Win.

        * DumpRenderTree/chromium/WebViewHost.cpp:
        (WebViewHost::updatePaintRect):
        * DumpRenderTree/chromium/WebViewHost.h:

2011-01-10  Adam Roben  <aroben@apple.com>

        Roll out r75392

        It isn't needed now that r75289 has been rolled out.

        * Scripts/run-javascriptcore-tests:

2011-01-10  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Anders Carlsson.

        WebKitTestRunner uses crazy amounts of CPU, making layout tests slow and flaky
        https://bugs.webkit.org/show_bug.cgi?id=52160

        * WebKitTestRunner/mac/TestControllerMac.mm:
        (WTR::TestController::platformRunUntil): Instead of busy-looping, wait for the timeout.
        Anything that can make runUntil() conditions turn true will happen on a run loop cycle
        anyway.

2011-01-10  Tony Chang  <tony@chromium.org>

        Reviewed by Mihai Parparita.

        [chromium] fix for animated gif layout tests
        https://bugs.webkit.org/show_bug.cgi?id=52008

        * DumpRenderTree/chromium/WebViewHost.cpp: Schedule a paint when we update the paint rect
            to trigger gif animations.
        (WebViewHostPaintTask::WebViewHostPaintTask):
        (WebViewHostPaintTask::runIfValid):
        (WebViewHost::updatePaintRect):
        * DumpRenderTree/chromium/WebViewHost.h:
        (WebViewHost::taskList):

2011-01-10  Alejandro G. Castro  <alex@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] Fix gtk2 compilation for master
        https://bugs.webkit.org/show_bug.cgi?id=51885

        * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
        (createBitmapContextFromWebView): Replaced the old
        gdk_drawable_get_size with gdk_pixmap_get_size.

2011-01-10  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Laszlo Gombos.

        [WINCE] Reenable NPAPI after r75203
        https://bugs.webkit.org/show_bug.cgi?id=52109

        Remove the !isWinCE() check for ENABLE_NETSCAPE_PLUGIN_API and replace
        it with !isEfl(), because EFL port does not support NPAPI (yet).

        * Scripts/build-webkit:

2011-01-10  Adam Roben  <aroben@apple.com>

        Skip some asserting JS tests

        See <http://webkit.org/b/52156>.

        * Scripts/run-javascriptcore-tests:

2011-01-10  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] build-webkit disable Blob support via arguments passed to automake
        https://bugs.webkit.org/show_bug.cgi?id=52097

        * Scripts/build-webkit: Enable Blob support when building WebKitGTK+ via
        build-webkit.

2011-01-10  Adam Roben  <aroben@apple.com>

        Use the same name and description for TestNetscapePlugin on Windows and
        Mac

        Fixes <http://webkit.org/b/52151>
        fast/frames/iframe-reparenting-plugins.html fails on Windows

        Reviewed by Steve Falkenburg.

        * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Copied
        the name and description from Mac's Info.plist.

2011-01-10  Siddharth Mathur <siddharth.mathur@nokia.com>

        Reviewed by Laszlo Gombos.

        [Qt][WK2] Guard gcc-specific syntax

        Non-gcc based compliers choke on the "-include"
        syntax for preinclude, place guard around it.

        * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
        * WebKitTestRunner/qt/WebKitTestRunner.pro:

2011-01-10  Andreas Kling  <kling@webkit.org>

        Reviewed by Simon Hausmann.

        [Qt] [WK2] MiniBrowser does not load pages opened in new windows
        https://bugs.webkit.org/show_bug.cgi?id=52111

        When getting a createNewPage() callback from QWKPage, create the
        new page with the same QWKContext as the page that is passed to
        the callback.

        * MiniBrowser/qt/BrowserView.h:
        * MiniBrowser/qt/BrowserWindow.cpp:
        (newPageFunction):
        (BrowserWindow::BrowserWindow):
        * MiniBrowser/qt/BrowserWindow.h:

2011-01-10  Andreas Kling  <kling@webkit.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] MiniBrowser: Remove superfluous createNewPage() callback

        BrowserView set its own useless createNewPage() callback on QWKPage.
        This was immediately overridden by BrowserWindow anyway, so remove
        the BrowserView one.

        * MiniBrowser/qt/BrowserView.cpp:
        (BrowserView::BrowserView):

2011-01-10  John Knottenbelt  <jknotten@chromium.org>

        Reviewed by Jeremy Orlow.

        [Chromium] Remove non-client-based Geolocation code
        https://bugs.webkit.org/show_bug.cgi?id=50921

        * DumpRenderTree/chromium/LayoutTestController.cpp:
        (LayoutTestController::setGeolocationPermission):
        (LayoutTestController::setMockGeolocationPosition):
        (LayoutTestController::setMockGeolocationError):
        * DumpRenderTree/chromium/WebViewHost.cpp:
        (WebViewHost::geolocationClientMock):
        (WebViewHost::reset):
        * DumpRenderTree/chromium/WebViewHost.h:

2011-01-10  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Commit bot tried to land r? cq+ patch
        https://bugs.webkit.org/show_bug.cgi?id=36638

        It should now be possible to post a patch with r? and cq+ and the
        commit-queue will correctly wait for the r+ before attempting to land the patch.
        (This was a feature requested by several users.)

        One caveat: We don't actually reject r-, cq+ patches from the queue
        (we just ignore them), but I think that's OK for now.

        I also noticed that setting r- once a commit-queue node had grabbed
        a patch would not properly cancel the landing.  That's fixed and
        tested in this patch.

        * Scripts/webkitpy/tool/bot/commitqueuetask.py:
        * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
        * Scripts/webkitpy/tool/bot/feeders.py:
        * Scripts/webkitpy/tool/bot/feeders_unittest.py:

2011-01-08  Benjamin Poulain  <benjamin.poulain@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] QtWebKit crashes when using XMLHttpRequest from the unload event
        https://bugs.webkit.org/show_bug.cgi?id=51934

        When accessing the network from the destructor of QWebPage, the network access manager
        was already deleted because the object WebPage was already destructed.

        This solve the problem by linking the lifetime of the network access manager to WebPage's QObject.
        The object is now destructed in the destructor of QObject.

        * QtTestBrowser/webpage.cpp:
        (WebPage::WebPage):
        (WebPage::setQnamThreaded):
        * QtTestBrowser/webpage.h:
        (QtNAMThread::QtNAMThread):

2011-01-08  Eric Seidel  <eric@webkit.org>

        Reviewed by Ojan Vafai.

        test_failures.py should not mention TestShell (long live DumpRenderTree!)
        https://bugs.webkit.org/show_bug.cgi?id=52067

        I ran test-webkitpy, but didn't bother adding a unit test for this string change.
        https://bugs.webkit.org/show_bug.cgi?id=51138#c3 is an example of why this is needed.

        * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:

2011-01-08  Eric Seidel  <eric@webkit.org>

        Reviewed by Mihai Parparita.

        commit-queue hangs when the ChangeLog diff is bad
        https://bugs.webkit.org/show_bug.cgi?id=52072

        * Scripts/webkitpy/tool/steps/validatechangelogs.py:
        * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:

2011-01-08  Adam Barth  <abarth@webkit.org>

        Teach svn-apply how to re-write WebCore to Source/WebCore.

        * Scripts/VCSUtils.pm:

2011-01-07  Adam Barth  <abarth@webkit.org>

        Rubber-stamped by Eric Seidel.

        Move WebCore to Source
        https://bugs.webkit.org/show_bug.cgi?id=52050

        Update the tools to understand WebCore's new location.

        * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
        * DumpRenderTree/wscript:
        * GNUmakefile.am:
        * Scripts/build-webkit:
        * Scripts/do-file-rename:
        * Scripts/do-webcore-rename:
        * Scripts/generate-qt-inspector-resource:
        * Scripts/prepare-ChangeLog:
        * Scripts/run-bindings-tests:
        * Scripts/update-iexploder-cssproperties:
        * Scripts/update-sources-list.py:
        * Scripts/update-webkit-localizable-strings:
        * Scripts/webkitdirs.pm:
        * Scripts/webkitpy/common/config/build.py:
        * Scripts/webkitpy/common/config/build_unittest.py:
        * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
        * Scripts/webkitpy/style/checker.py:
        * Scripts/webkitpy/style/checker_unittest.py:
        * WebKitTestRunner/DerivedSources.pro:
        * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
        * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh:
        * wx/browser/wscript:
        * wx/build/settings.py:

2011-01-07  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Sam Weinig.

        Make WebKitTestRunner rest between loads more robust to avoid test crashes
        https://bugs.webkit.org/show_bug.cgi?id=52086

        * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
        (WTR::InjectedBundle::didReceiveMessage):
        * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
        (WTR::LayoutTestController::notifyDone):
        * WebKitTestRunner/TestController.cpp:
        (WTR::TestController::resetStateToConsistentValues):
        (WTR::TestController::run):

2011-01-07  James Robinson  <jamesr@chromium.org>

        Revert "Implement mozilla's animationTime property"
        https://bugs.webkit.org/show_bug.cgi?id=51952

        This approach isn't quite right.

        * DumpRenderTree/chromium/WebViewHost.cpp:
        (WebViewHost::paintInvalidatedRegion):

2011-01-07  Adam Roben  <aroben@apple.com>

        Build master fix

        * BuildSlaveSupport/build.webkit.org-config/master.cfg:
        (RunWebKitTests.start): Don't try to concatenate a list and a string.

2011-01-07  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>

        Reviewed by Csaba Osztrogonác.

        run-qtwebkit-tests should be able to kill a testsuite.

        Add new option in the script that can setup a timeout for a test.
        If the test execution takes more then specified time then the test
        would be terminated.

        [Qt] run-qtwebkit-tests needs timeout
        https://bugs.webkit.org/show_bug.cgi?id=51894

        * BuildSlaveSupport/build.webkit.org-config/master.cfg:
        * Scripts/run-qtwebkit-tests:

2011-01-07  Csaba Osztrogonác  <ossy@webkit.org>

        Unreviewed fix after r75233.

        Based on idea from Eric Seidel.

        Add remote zip file handling to webkitpy.
        https://bugs.webkit.org/show_bug.cgi?id=50901

        * Scripts/webkitpy/common/system/fileset.py: Make python 2.5 happy.

2011-01-07  Shane Stephens  <shanestephens@google.com>

        Reviewed by Eric Seidel.

        svn-apply: should support git binary delta diffs
        https://bugs.webkit.org/show_bug.cgi?id=38864

        * Scripts/VCSUtils.pm:
        * Scripts/svn-apply:

2011-01-06  Julie Parent  <jparent@chromium.org>

        Reviewed by Eric Seidel.

        Test Result Server not removing old results.
        https://bugs.webkit.org/show_bug.cgi?id=52012

        * TestResultServer/model/jsonresults.py:
        Fix off-by-one: Truncate if >= num_runs, not just >.
        * TestResultServer/model/jsonresults_unittest.py:
        Add unit test to test that merging in a new result with the same value
        as the last result causes previous result to fall off.

2011-01-06  James Kozianski  <koz@chromium.org>

        Reviewed by Mihai Parparita.

        Add classes to provide a consistent interface to a set of files.
        https://bugs.webkit.org/show_bug.cgi?id=50901

        These classes allow us to write code that is agnostic to whether a
        particular set of files resides in a local directory or in a zip file
        on a remote machine.

        * Scripts/webkitpy/common/system/directoryfileset.py: Added.
        * Scripts/webkitpy/common/system/directoryfileset_unittest.py: Added.
        * Scripts/webkitpy/common/system/fileset.py: Added.
        * Scripts/webkitpy/common/system/filesystem.py:
        * Scripts/webkitpy/common/system/filesystem_mock.py:
        * Scripts/webkitpy/common/system/zipfileset.py: Added.
        * Scripts/webkitpy/common/system/zipfileset_unittest.py: Added.

2011-01-06  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        NetworkTransaction should log the url it is retrying
        https://bugs.webkit.org/show_bug.cgi?id=52043

        * Scripts/webkitpy/common/net/networktransaction.py:
        * Scripts/webkitpy/common/net/networktransaction_unittest.py:

2011-01-06  Steve Falkenburg  <sfalken@apple.com>

        Windows build fix.
        Import os before using it.

        * BuildSlaveSupport/build.webkit.org-config/master.cfg:

2011-01-06  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        StyleQueue fails to report errors when patches have many files
        https://bugs.webkit.org/show_bug.cgi?id=52042

        This is one of at least two errors preventing style error reporting at the moment.
        When we moved to passing the list of files to check explicitly,
        we started to exceed the 500 character TEXT field limit for our AppEngine model object.
        We could change the type of the QueueStatus.message type, or we could
        just teach statusserver.py how to clamp values (and warn when it does).
        I chose the latter path.

        * Scripts/webkitpy/common/net/statusserver.py:

2011-01-06  Steve Falkenburg  <sfalken@apple.com>

        Reviewed by Stephanie Lewis.
        
        Fix syntax error in script.

        Windows bots need to archive/unarchive builds to/from configuration-specific directories
        https://bugs.webkit.org/show_bug.cgi?id=51996

        * BuildSlaveSupport/build.webkit.org-config/master.cfg:

2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Unreviewed, fixing WinCE build after r75196.

        WinCE port does not (yet) support NPAPI.

        * Scripts/build-webkit:

2011-01-06  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Darin Adler.

        File::Spec->rel2abs in sunspider-compare-results mangles parameters
        https://bugs.webkit.org/show_bug.cgi?id=52015

        * Scripts/sunspider-compare-results: call rel2abs on our arguments
        after the platform has been detected, otherwise the script will
        mangle things like '--gtk' into '/a/path/--gtk', breaking the
        detection.

2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Eric Seidel.

        Add ENABLE_NETSCAPE_PLUGIN_API, ENABLE_ORIENTATION_EVENTS and ENABLE_TOUCH_EVENTS flags to build-webkit
        https://bugs.webkit.org/show_bug.cgi?id=51346

        * Scripts/build-webkit:

2011-01-06  Steve Falkenburg  <sfalken@apple.com>

        Reviewed by Adam Roben.

        Windows bots need to archive/unarchive builds to/from configuration-specific directories
        https://bugs.webkit.org/show_bug.cgi?id=51996
        
        After the configuration directory change, we were archiving the incorrect directory for
        build product, so we were running tests on the wrong binaries.
        
        This change archives the correct directory, and also unarchives it into a configuration-
        specific directory.

        * BuildSlaveSupport/build.webkit.org-config/master.cfg: Use a configuration-specific directory on Windows.
        * BuildSlaveSupport/built-product-archive: Unarchive/archive to/from proper directory.

2011-01-06  Eric Seidel  <eric@webkit.org>

        Reviewed by Mihai Parparita.

        commit-queue mentions "Text diff mismatch" 4 times instead of once per failure
        https://bugs.webkit.org/show_bug.cgi?id=52002

        See an example of this here:
        https://bugs.webkit.org/show_bug.cgi?id=51314#c2

        It's due to the fact that we pass around TestFailure() instance
        objects and yet expect them to all compare to be the same.

        This is bad.  We should either have shared instances of these values
        or we should just pass around the class names.  There are already hacks
        in place to make TestFailure objects pass equality tests, I just added
        a __hash__ implementation so they can be used in sets as expected.

        * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
        * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:

2011-01-06  Evan Martin  <evan@chromium.org>

        Reviewed by Tony Chang.

        [gdb] handle inaccessible memory and UChar*
        https://bugs.webkit.org/show_bug.cgi?id=52003

        To pretty-print a UChar*, we just grope around in the memory
        looking for a terminating NUL.  We need to handle the exception
        that can occur when we poke into an invalid location.

        Additionally, the logic for choosing which pretty-printer would
        early return before hitting the point where we'd use the UChar*
        printer.  (Did this ever work?  How did it regress?)

        * gdb/webkit.py:

2011-01-05  Brian Weinstein  <bweinstein@apple.com>

        Reviewed by Ada Chan.

        WebKit2: Should be able to call into injected bundle to ask if we should allow resource loads
        https://bugs.webkit.org/show_bug.cgi?id=51969
        
        Add shouldLoadResourceForFrame to WTR::InjectedBundlePage.

        * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
        (WTR::InjectedBundlePage::InjectedBundlePage):
        (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Stub implementation.
        * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:

2011-01-06  James Robinson  <jamesr@chromium.org>

        Reviewed by Simon Fraser.

        Implement mozilla's animationTime property
        https://bugs.webkit.org/show_bug.cgi?id=51952

        Chromium DRT support for webkitAnimationTime.

        * DumpRenderTree/chromium/WebViewHost.cpp:
        (WebViewHost::paintInvalidatedRegion):

2011-01-06  Julie Parent  <jparent@chromium.org>

        Reviewed by Tony Chang.

        Test Result Server always truncates number of results to JSON_RESULTS_MAX_BUILDS
        https://bugs.webkit.org/show_bug.cgi?id=51217

        * TestResultServer/model/jsonresults.py:
        Pass num_runs through to _remove_items_over_max_number_of_builds, and use the value.
        Adds missing documentation.
        * TestResultServer/model/jsonresults_unittest.py:
        Add unit test to test that truncation happens at smaller value than JSON_RESULTS_MAX_BUILDS.
        Update test_merge to take a number of builds to truncate at.

2011-01-06  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        The EWS should log outside of the working directory
        https://bugs.webkit.org/show_bug.cgi?id=51986

        This patch prepare us for using git clean -x -d -f in the EWS wrapper
        script, which will actually clean the working copy back to a pristine
        state instead of leaving untracked directories and ignored files.

        * Scripts/webkitpy/tool/commands/queues.py:
        * Scripts/webkitpy/tool/commands/queues_unittest.py:

2011-01-05  Steve Falkenburg  <sfalken@apple.com>

        Windows build fix.
        Back out attempted change to built-product-archive.

        * BuildSlaveSupport/built-product-archive:

2011-01-05  Steve Falkenburg  <sfalken@apple.com>

        Windows build fix.
        Include configuration name when unpacking a build archive.

        Needed, since we split Windows build results into configuration-specific directories
        under WebKitOutputDir.

        * BuildSlaveSupport/built-product-archive:

2011-01-05  Steve Falkenburg  <sfalken@apple.com>

        Reviewed by Darin Adler.

        Debug and Release builds on Windows clobber each other
        https://bugs.webkit.org/show_bug.cgi?id=49185

        Changes the structure of WebKitBuild build products directory so we
        completely separate each build configuration into independent directories.
        
        Although we previously had per-configuration directories for obj, this change adds
        per-configuration directories for bin, lib, obj, and include. Each configuration's
        build products are stored within a directory inside of WebKitBuild.
        
        Most use of $(WebKitOutputDir) in the build files has been replaced by $(ConfigurationBuildDir),
        defined in common.vsprops to be $(WebKitOutputDir)\$(ConfigurationName).

        * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops:
        * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd:
        * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd:
        * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
        * DumpRenderTree/win/DumpRenderTreePostBuild.cmd:
        * DumpRenderTree/win/DumpRenderTreePreBuild.cmd:
        * DumpRenderTree/win/ImageDiffCommon.vsprops:
        * DumpRenderTree/win/ImageDiffPostBuild.cmd:
        * DumpRenderTree/win/ImageDiffPreBuild.cmd:
        * FindSafari/FindSafari.vcproj:
        * MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
        * MiniBrowser/MiniBrowserPostBuild.cmd:
        * MiniBrowser/MiniBrowserPreBuild.cmd:
        * Scripts/webkitdirs.pm:
        * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
        * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops:
        * TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd:
        * TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd:
        * TestWebKitAPI/win/copy-resources.cmd:
        * WebKitAPITest/WebKitAPITestCommon.vsprops:
        * WebKitAPITest/WebKitAPITestPostBuild.cmd:
        * WebKitAPITest/WebKitAPITestPreBuild.cmd:
        * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
        * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
        * WebKitTestRunner/win/InjectedBundle.vcproj:
        * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops:
        * WebKitTestRunner/win/InjectedBundlePostBuild.cmd:
        * WebKitTestRunner/win/InjectedBundlePreBuild.cmd:
        * WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd:
        * WebKitTestRunner/win/WebKitTestRunnerPreBuild.cmd:
        * WinLauncher/WinLauncherCommon.vsprops:
        * WinLauncher/WinLauncherPostBuild.cmd:
        * WinLauncher/WinLauncherPreBuild.cmd:

2011-01-05  Jan Erik Hanssen  <jhanssen@sencha.com>

        Reviewed by Ariya Hidayat.

        [Qt] TestNetscapePlugin doesn't link on OS X
        https://bugs.webkit.org/show_bug.cgi?id=51948

        Only add a dependency on libX11 on X11 systems

        * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:

2011-01-05  Jeff Miller  <jeffm@apple.com>

        Reviewed by Adam Roben.

        check-webkit-style should allow unnecessary parameter names in WebKit2 APIs because we're matching CF's header style
        https://bugs.webkit.org/show_bug.cgi?id=51970

        * Scripts/webkitpy/style/checker.py:
        Add -readability/naming for WebKit2 C API directories.

2011-01-05  Eric Seidel  <eric@webkit.org>

        Unreviewed, just fixing one more log error from my previous python patch.

        Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
        https://bugs.webkit.org/show_bug.cgi?id=51802

        webkit-patch failure-reason was logging about parsing errors
        due to my misunderstanding of how BeautifulSoup.findAll worked.

        Fixed, and added a unit test.

        * Scripts/webkitpy/common/net/layouttestresults.py:
        * Scripts/webkitpy/common/net/layouttestresults_unittest.py:

2011-01-05  Benjamin Poulain  <benjamin.poulain@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] [WK2] Add the possibility to open window from the WebProcess in Minibrowser
        https://bugs.webkit.org/show_bug.cgi?id=51951

        Set a function to QWKPage::setCreateNewPageFunction() in Minibrowser so there is a way
        to create new window from WebKit.

        * MiniBrowser/qt/BrowserWindow.cpp:
        (newPageFunction):
        (BrowserWindow::BrowserWindow):
        (BrowserWindow::page): Added to avoid the indirect access to QWKPage spread in the class
        (BrowserWindow::newWindow):
        (BrowserWindow::updateUserAgentList):
        (BrowserWindow::showUserAgentDialog):
        * MiniBrowser/qt/BrowserWindow.h: Add the global variable backingStoreTypeForNewWindow to
        define the type of the backing store used for new windows.
        * MiniBrowser/qt/main.cpp:
        (main):

2011-01-05  Eric Seidel  <eric@webkit.org>

        Reviewed by Ojan Vafai.

        commit-queue should report failure type when reporting flaky tests
        https://bugs.webkit.org/show_bug.cgi?id=51900

        This patch was a ridiculous amount of plumbing.  In the end I like
        the NRWT-style TestResult class even less.  But now we're passing
        a list of TestResult objects from the queue to the FlakyTestReporter.
        Thus the FlakyTestReporter can more easily report what type of failure
        occurred.

        In the process, I found that I was not alone in finding TestResult
        cumbersome to use.  A bunch of code was trying to create a TestResult
        object with default values.  However since the constructor didn't make
        this easy, some places were getting it wrong (including the TestResult unit test)!
        I've fixed the TestResult constructor to have default values for non-essential
        arguments.

        * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
        * Scripts/webkitpy/common/net/layouttestresults.py:
        * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
        * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
        * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
        * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
        * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
        * Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py:
        * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
        * Scripts/webkitpy/tool/bot/commitqueuetask.py:
        * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
        * Scripts/webkitpy/tool/bot/flakytestreporter.py:
        * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
        * Scripts/webkitpy/tool/commands/queues.py:
        * Scripts/webkitpy/tool/commands/queues_unittest.py:

2011-01-05  Eric Seidel  <eric@webkit.org>

        Unreviewed.

        Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
        https://bugs.webkit.org/show_bug.cgi?id=51802

        Add another unit test to cover a previously missing import.

        * Scripts/webkitpy/common/net/layouttestresults.py:
        * Scripts/webkitpy/common/net/layouttestresults_unittest.py:

2011-01-05  Mihai Parparita  <mihaip@chromium.org>

        Reviewed by David Levin.

        Add mihaip@chromium.org as a reviewer
        https://bugs.webkit.org/show_bug.cgi?id=51966
        
        Add myself as a reviewer.

        * Scripts/webkitpy/common/config/committers.py:

2011-01-05  James Simonsen  <simonjam@chromium.org>

        Unreviewed. Adding myself to the list of committers.

        * Scripts/webkitpy/common/config/committers.py:

2011-01-05  Eric Seidel  <eric@webkit.org>

        Unreviewed.

        Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
        https://bugs.webkit.org/show_bug.cgi?id=51802

        Fix two exceptions seen on the bots after my original commit.

        * Scripts/webkitpy/common/net/layouttestresults.py:
        * Scripts/webkitpy/common/net/layouttestresults_unittest.py:

2011-01-05  Kundu Suchismita  <suchi.kundu@nokia.com>

        Reviewed by Andreas Kling.

        [Qt]Add local storage settings to QtTestBrowser command line arguments 
        https://bugs.webkit.org/show_bug.cgi?id=51750

        * QtTestBrowser/main.cpp:
        (LauncherApplication::handleUserOptions):
         Local storage settings can be enable form command line arguments for
         QtTestBrowser.

2011-01-05  Chris Fleizach  <cfleizach@apple.com>

        Reviewed by Martin Robinson.

        GTK: AX: DRT needs to use correct root object method.
        https://bugs.webkit.org/show_bug.cgi?id=51911

        * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
        (AccessibilityController::rootElement):

2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>

        Rubber-stamped by Csaba Osztrogonác.

        Based on idea from Péter Gál.

        * Scripts/webkitpy/tool/bot/sheriff.py: Remove unnecessary apostrophes around revision numbers.

2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>

        Reviewed by Adam Barth.

        sheriff-bot should be able to do multi-revision rollouts
        https://bugs.webkit.org/show_bug.cgi?id=51176

        * Scripts/webkitpy/tool/bot/irc_command.py:
        * Scripts/webkitpy/tool/bot/sheriff.py:
        * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:

2011-01-05  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        queues.webkit.org should have per-bot status pages
        https://bugs.webkit.org/show_bug.cgi?id=51906

        Just adds a /queue-status/QUEUE_NAME/bots/BOT_ID page to show
        statuses from a single queue.  Now that we have many bots servicing
        some queues (commit-queue, win-ews, etc.) its easy to have the messages
        you care about scroll off the end of the 15-message limit on the main page.

        Eventually we should probably rename /queue-status to /queue or /queues,
        but that's fodder for another patch.

        * QueueStatusServer/handlers/queuestatus.py:
        * QueueStatusServer/index.yaml:
        * QueueStatusServer/main.py:
        * QueueStatusServer/templates/includes/singlequeuestatus.html:
         - This probably should use a custom filter instead of hard-coding
           the URL scheme here, but I couldn't figure out how to easily
           create such a filter.  Most filters work with "strings" so we can't
           pass the status object.  We could add a method to the status
           object and call that, but that seemed a bit strange too.
        * QueueStatusServer/templates/queuestatus.html:

2011-01-05  Carlos Garcia Campos  <cgarcia@igalia.com>

        Unreviewed. Adding myself to the list of committers.

        * Scripts/webkitpy/common/config/committers.py:

2011-01-04  Koan-Sin Tan  <koansin.tan@gmail.com>

        Reviewed by David Levin.

        check-webkit-style treated some macros with parentheses after #elif as function calls
        https://bugs.webkit.org/show_bug.cgi?id=51695

        Ingore function call space checking in any preprocessor directives
        (things starting with #). Change search() to match() because 
        preprocessor directives are supposed to be in the beginning of lines.

        * Scripts/webkitpy/style/checkers/cpp.py:
        * Scripts/webkitpy/style/checkers/cpp_unittest.py: make sure there is no false positives for #elif cases

2011-01-04  Søren Gjesse  <sgjesse@chromium.org>

        Reviewed by Tony Chang.

        Change the --multi-load test option to --stress-opt
        https://bugs.webkit.org/show_bug.cgi?id=50751

        * DumpRenderTree/chromium/DumpRenderTree.cpp:
        (runTest):
        (main):
        * DumpRenderTree/chromium/TestShell.cpp:
        (TestShell::TestShell):
        * DumpRenderTree/chromium/TestShell.h:
        (TestShell::stressOpt):
        (TestShell::setStressOpt):
        (TestShell::stressDeopt):
        (TestShell::setStressDeopt):
        (TestShell::javaScriptFlags):
        (TestShell::setJavaScriptFlags):
        * Scripts/webkitpy/layout_tests/port/chromium.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:

2011-01-04  Chris Fleizach  <cfleizach@apple.com>

        Reviewed by Sam Weinig.

        WK2: Support Accessibility
        https://bugs.webkit.org/show_bug.cgi?id=51859

        Use rootObject() method to get top of accessibility tree.

        * DumpRenderTree/mac/AccessibilityControllerMac.mm:
        (AccessibilityController::focusedElement):
        (AccessibilityController::rootElement):

2011-01-03  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Darin Adler.

        Remove the last non-GObject usage of PlatformRefPtr and move the code to GRefPtr
        https://bugs.webkit.org/show_bug.cgi?id=51846

        * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: Change usage of PlatformRefPtr
        back to GRefPtr.

2011-01-04  Zhe Su  <suzhe@chromium.org>

        Reviewed by Kenneth Russell.

        Fix insertText, setMarkedText and unmarkText methods of
        TextInputController to call corresponding methods of WebKit::WebView
        rather than WebKit::WebFrame. This change matches the behavior of
        chromium browser.
        insertText corresponds to WebView::confirmComposition(text)
        setMarkedText corresponds to WebView::setComposition(...)
        unmarkText corresponds to WebView::confirmComposition()
        https://bugs.webkit.org/show_bug.cgi?id=51693

        * DumpRenderTree/chromium/TextInputController.cpp:
        (TextInputController::insertText):
        (TextInputController::setMarkedText):
        (TextInputController::unmarkText):

2011-01-04  Dihan Wickremasuriya  <dihan.wickremasuriya@nokia.com>

        Reviewed by Laszlo Gombos.

        [Qt] [Symbian] Do not remove 0 byte sized files from productDir

        On Symbian productDir points to the source directory. Removing all the
        empty files from the productDir directory corrupts the svn repository.

        * Scripts/build-webkit:

2011-01-03  Yi Shen  <yi.4.shen@nokia.com>

        Reviewed by Adam Barth.

        [Qt] Add SelectAll option to the context menu for the editor
        https://bugs.webkit.org/show_bug.cgi?id=50049

        Set shortcut for the SelectAll action.

        * QtTestBrowser/mainwindow.cpp:
        (MainWindow::buildUI):

2011-01-03  David Levin  <levin@chromium.org>

        Reviewed by Eric Seidel.

        check-webkit-style shouldn't consider "value" automatically to be a meaningless name.
        https://bugs.webkit.org/show_bug.cgi?id=51842

        * Scripts/webkitpy/style/checkers/cpp.py: Remove the check for value.
        * Scripts/webkitpy/style/checkers/cpp_unittest.py: Remove the test for value.

2011-01-03  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by David Kilzer.

        [WINCE] Adds a build slave.
        https://bugs.webkit.org/show_bug.cgi?id=50523

        * BuildSlaveSupport/build.webkit.org-config/config.json: Add an
        entry for a release build of the WinCE port.
        * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add platform
        flag to build the WinCE port.

2011-01-03  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by David Kilzer.

        Add WinCE support to build-webkit
        https://bugs.webkit.org/show_bug.cgi?id=51642

        * Scripts/build-webkit:
        * Scripts/webkitdirs.pm:

2011-01-03  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
        https://bugs.webkit.org/show_bug.cgi?id=51802

        I'm not the biggest fan of the test_failures or test_results classes,
        but it's better to have one shared set of classes, than separate ones
        for new vs. old run-webkit-test result handling.

        This moves the ORWT results class "LayoutTestResults" over to using
        TestResult and TestFailure classes, making it easy for us to
        make all our sheriff-bot and other webkitpy code NRWT ready.

        This also makes it a trivial patch to generate results.json information
        from ORWT results.html files (for flaky test analysis, etc.) as well
        as making it a one-liner to report test failure types when the
        commit-queue sees flaky tests.

        This patch tried not to add new functionality, but only to replace
        the guts of LayoutTestResults, while adding unit tests and hoping
        not to break anything.

        I also moved callers which assumed User.prompt* were static/class methods
        to using them as instance methods (since we'll eventually want to make them such).

        In the process of re-writing things, I broke the rebaseline command, so I wrote
        a unit test to catch my breakage were I do do so again in the future.

        * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
        * Scripts/webkitpy/common/net/layouttestresults.py:
        * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
        * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
        * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
        * Scripts/webkitpy/tool/commands/queries.py:
        * Scripts/webkitpy/tool/commands/rebaseline.py:
        * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
        * Scripts/webkitpy/tool/mocktool.py:

2011-01-03  Adam Barth  <abarth@webkit.org>

        Reviewed by Simon Fraser.

        webkit-patch shouldn't waste time cleaning a working directory that's already clean
        https://bugs.webkit.org/show_bug.cgi?id=51840

        * Scripts/webkitpy/common/checkout/scm.py:

2011-01-03  Adam Barth  <abarth@webkit.org>

        Reviewed by Simon Fraser.

        webkit-patch should only hide update output if --quiet
        https://bugs.webkit.org/show_bug.cgi?id=51838

        As requested by smfr.

        * Scripts/webkitpy/tool/steps/update.py:

2011-01-03  Adam Barth  <abarth@webkit.org>

        Reviewed by David Levin.

        commit-queue shouldn't reject patches twice if two bots process the same patch
        https://bugs.webkit.org/show_bug.cgi?id=51805

        Before raising an error, we first check whether the patch is still in
        the commit-queue.  This check is still racy, of course, but the time
        window is much smaller.

        * Scripts/webkitpy/tool/bot/commitqueuetask.py:

2011-01-03  Sam Weinig  <sam@webkit.org>

        Reviewed by Anders Carlsson.

        Make run-api-tests less chatty.
        https://bugs.webkit.org/show_bug.cgi?id=51831

        - Make script quiet by default and add --verbose option (replacing --quiet).
        - When not verbose, pipe stdout and stderr to devnull.

        * Scripts/run-api-tests:

2011-01-03  Pratik Solanki  <psolanki@apple.com>

        Unreviewed. Adding myself to committers.py.

        * Scripts/webkitpy/common/config/committers.py:

2011-01-03  Koan-Sin Tan  <koansin.tan@gmail.com>

        Reviewed by Xan Lopez.

        "Tool/Scripts/run-launcher --gtk" stopped working after 74855
        https://bugs.webkit.org/show_bug.cgi?id=51806

        Originally, the $libraryName is 'JavaScriptCore'. When building release 
        one, the $libraryDir was 'WebKitBuild/Release/JavaScriptCore/../.libs/'
        which doesn't exist anymore ('WebKitBuild/Release/JavaScriptCore'
        is 'WebKitBuild/Release/Source/JavaScriptCore' now), and 
        'WebKitBuild/Release/Source/JavaScriptCore/../../.libs' looks weird,
        so make it 'WebKitBuild/Release/.libs'

        * Scripts/webkitdirs.pm: 

2011-01-02  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Adam Barth.

        Make EFL a core builder
        https://bugs.webkit.org/show_bug.cgi?id=51804

        * Scripts/webkitpy/common/net/buildbot/buildbot.py:
        * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:

2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>

        [Qt] Unreviewed fix after r74855 and r74875.

        * BuildSlaveSupport/built-product-archive:
         - Create directories explicitly.
         - Pass shell=True to subprocess.call().

2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>

        [Qt] Unreviewed fix after r74855.

        Move JavaScriptCore to Source
        https://bugs.webkit.org/show_bug.cgi?id=51604

        * BuildSlaveSupport/built-product-archive: JavaScriptCore -> Source/JavaScriptCore

2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>

        [Qt] Unreviewed run-javasriptcore-tests fix after r74855.

        Move JavaScriptCore to Source
        https://bugs.webkit.org/show_bug.cgi?id=51604

        * Scripts/webkitdirs.pm:

2011-01-02  Robert Hogan  <robert@webkit.org>

        Unreviewed, build fix.

        [Qt] Fix DRT build after 74855

        * DumpRenderTree/qt/DumpRenderTree.pro:

2011-01-01  Adam Barth  <abarth@webkit.org>

        Remove the assumption from the Qt and Gtk builds that every project is
        in the root directory.

        * Scripts/build-webkit:

2011-01-01  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Teach svn-apply how to apply patches even though JavaScriptCore has moved
        https://bugs.webkit.org/show_bug.cgi?id=51796

        After this change, svn-apply will magically apply patches to
        JavaScriptCore/foo to Source/JavaScriptCore/foo.

        * Scripts/VCSUtils.pm:

2011-01-01  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Move JavaScriptCore to Source
        https://bugs.webkit.org/show_bug.cgi?id=51604

        Update references to JavaScriptCore to point to the new location.

        * BuildSlaveSupport/build.webkit.org-config/master.cfg:
        * DumpRenderTree/qt/DumpRenderTree.pro:
        * DumpRenderTree/qt/ImageDiff.pro:
        * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
        * DumpRenderTree/wscript:
        * Scripts/build-jsc:
        * Scripts/build-webkit:
        * Scripts/do-file-rename:
        * Scripts/do-webcore-rename:
        * Scripts/run-javascriptcore-tests:
        * Scripts/update-javascriptcore-test-results:
        * Scripts/webkitdirs.pm:
        * Scripts/webkitpy/common/config/build_unittest.py:
        * Scripts/webkitpy/style/checker.py:
        * Scripts/webkitpy/style/checker_unittest.py:
        * Scripts/webkitpy/style/checkers/cpp_unittest.py:
        * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
        * WebKitTestRunner/qt/WebKitTestRunner.pro:
        * wx/build/settings.py:

2011-01-01  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Move Sources to Source
        https://bugs.webkit.org/show_bug.cgi?id=51794

        Update scripts to point to the new location.

        * Scripts/build-webkit:
        * Scripts/do-file-rename:
        * Scripts/do-webcore-rename:
        * Scripts/webkitpy/common/config/build.py:
        * Scripts/webkitpy/common/config/build_unittest.py:

2010-12-31  Kent Tamura  <tkent@chromium.org>

        Reviewed by Eric Seidel.

        [DRT/Chromium] Enable mock spell checker on non-OSX
        https://bugs.webkit.org/show_bug.cgi?id=51401

        * DumpRenderTree/chromium/WebViewHost.cpp:
        (WebViewHost::spellCheck):

2010-12-31  Adam Barth  <abarth@webkit.org>

        Reviewed by Ariya Hidayat.

        Remove Tools/Scripts/wkstyle
        https://bugs.webkit.org/show_bug.cgi?id=51774

        This script appears to not have been touched in a while and seems to
        have been replaced by check-webkit-style.

        * Scripts/wkstyle: Removed.

2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>

        Unreviewed. Coding style fix.

        * DumpRenderTree/chromium/TestShell.h:

2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: [Chromium] Inspector's tests are very slow on Win(Dbg).

        It was a problem with Chromium DRT. DevToolsAgent object instance was
        attached not only to the inspected page but to the DevTools window too.
        As result all the inspector files were interpreted as a content of inspected page
        and were transfered to the DevTools scripts panel for debugging etc.

        https://bugs.webkit.org/show_bug.cgi?id=51735

        * DumpRenderTree/chromium/TestShell.cpp:
        (TestShell::TestShell):
        (TestShell::bindJSObjectsToWindow):
        (TestShell::createNewWindow):
        * DumpRenderTree/chromium/TestShell.h:

2010-12-31  Adam Barth  <abarth@webkit.org>

        Rubber-stamped by Eric Seidel.

        Move PageLoadTests to PerformanceTests/PageLoad
        https://bugs.webkit.org/show_bug.cgi?id=51771

        Update references to PageLoadTests to point to the new location.

        * Scripts/run-pageloadtest:
        * Scripts/webkitpy/common/config/build.py:

2010-12-31  Adam Barth  <abarth@webkit.org>

        Rubber-stamped by Eric Seidel.

        Move SunSpider into PerformanceTests
        https://bugs.webkit.org/show_bug.cgi?id=51769

        Update these scripts to point to the new location.

        * Scripts/run-sunspider:
        * Scripts/sunspider-compare-results:

2010-12-30  Mihai Parparita  <mihaip@chromium.org>

        Reviewed by Kent Tamura.

        [Chromium] Add WebThemeEngineDRTMac so that Chromium DRT scrollbar rendering can match the Mac port's
        https://bugs.webkit.org/show_bug.cgi?id=51728
        
        Add implementation of the Mac WebThemeEngine that uses an NSScroller
        to render top-level scrollbars. This makes them match the Mac port's
        use of an NSScrollView, which means that we'll be able to share more
        pixel baselines.
        
        The new rendering code will not be activated until the 
        USE_WEB_THEME_ENGINE_TO_PAINT_THUMB #define is fliped in
        ScrollbarThemeChromiumMac.

        * DumpRenderTree/DumpRenderTree.gypi:
        * DumpRenderTree/chromium/TestShellMac.mm:
        (platformInit):
        * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Added.
        * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Added.
        (+[FakeActiveWindow alwaysActiveWindow]):
        (+[FakeActiveWindow alwaysInactiveWindow]):
        (-[FakeActiveWindow initWithActiveControls:]):
        (-[FakeActiveWindow _hasActiveControls]):
        (WebThemeEngineDRTMac::paintScrollbarThumb):
        (stateToHIEnableState):
        (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
        (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):

2010-12-30  Konstantin Tokarev  <annulen@yandex.ru>

        Reviewed by David Kilzer.

        [Qt] Don't build wtf/TCSystemAlloc.cpp if --system-malloc option is
        used
        https://bugs.webkit.org/show_bug.cgi?id=51672

        * DumpRenderTree/qt/DumpRenderTree.pro: Replaced USE_SYSTEM_MALLOC
        with USE_SYSTEM_MALLOC=1
        * WebKitTestRunner/qt/WebKitTestRunner.pro: Replaced USE_SYSTEM_MALLOC
        with USE_SYSTEM_MALLOC=1

2010-12-30  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by David Kilzer.

        [Qt] [Symbian] Fix build-webkit script for Symbian
        https://bugs.webkit.org/show_bug.cgi?id=51509

        Set the OUTPUT_DIR for Symbian to be the same as the source
        directory.

        * Scripts/webkitdirs.pm:

2010-12-30  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Darin Adler.

        check-webkit-style should ignore NULL usage in calls to gtk_widget_style_get
        https://bugs.webkit.org/show_bug.cgi?id=51758

        Add a check-webkit-style exception for gtk_widget_style_get and NULL usage.

        * Scripts/webkitpy/style/checkers/cpp.py: Add the exception.
        * Scripts/webkitpy/style/checkers/cpp_unittest.py: Add some tests for this.

2010-12-29  Patrick Gansterer  <paroga@webkit.org>

        Unreviewed WinCE buildfix.

        * WinCELauncher/main.cpp: Add missing include.

2010-12-29  Daniel Bates  <dbates@rim.com>

        Reviewed by Darin Adler.

        svn-apply updates date of wrong change log entry for a change log diff that
        contains two consecutive entries with the same author and date
        https://bugs.webkit.org/show_bug.cgi?id=46061

        Fixes an issue where the date of the wrong change log entry may be modified.
        Moreover, changes fixChangeLogPatch() to move entries inserted earlier
        in a ChangeLog file to the top of the file.

        Currently, fixChangeLogPatch() explicitly bails out and returns an unchanged
        diff when it detects that the diff inserts a change log entry earlier in a
        ChangeLog. It is unusual to land a patch that has such a deliberate ChangeLog
        change. With the advent of the commit-queue this functionality of bailing out
        and hence landing the patch as-is is harmful to the accuracy of the ChangeLog.
        Instead, we should always move the change log entry to the top of the ChangeLog file.

        A side-effect of this change is that setChangeLogDateAndReviewer() now updates
        the date line of the correct change log entry in a ChangeLog diff.

        * Scripts/VCSUtils.pm: Modified fixChangeLogPatch() to move entries inserted earlier to the top.

        * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
          Updated the following unit tests now that we move entries inserted earlier to the top:
          - "fixChangeLogPatch: New entry inserted in middle."
            (formerly named "fixChangeLogPatch: [no change] New entry inserted in middle.")

          - "fixChangeLogPatch: New entry inserted earlier in the file, but after an entry with the same author and date."
            (formerly named "fixChangeLogPatch: [no change] New entry inserted earlier in the file, but after an entry with the same author and date.")

        * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatchThenSetChangeLogDateAndReviewer.pl: Added.

2010-12-29  Konstantin Tokarev  <annulen@yandex.ru>

        Reviewed by Eric Seidel.

        [Qt] Fixed compatibility with gold linker on X11 platforms
        https://bugs.webkit.org/show_bug.cgi?id=51700

        * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
        Linked TestNetscapePlugin with libX11 on Unix platforms

2010-12-29  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>

        Reviewed by Darin Adler.

        Circular dependency in webkitpy.common.checkout.changelog module
        https://bugs.webkit.org/show_bug.cgi?id=50475

        Remove automatic import of api.Checkout module when any checkout/
        submodule is imported (e.g.: when checkout.scm.Git is imported).

        * Scripts/webkitpy/common/checkout/__init__.py:

2010-12-29  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Ojan Vafai.

        prepare-ChangeLog should support the -g option for specifying the git-commit
        https://bugs.webkit.org/show_bug.cgi?id=51708

        Add a -g shortcut for the --git-commit prepare-ChangeLog option. This matches
        webkit-patch, though the exact meaning of the two options remain different.

        * Scripts/prepare-ChangeLog: Add -g.

2010-12-29  Kent Hansen  <kent.hansen@nokia.com>

        Reviewed by Simon Hausmann.

        [Qt] Fix compilation with Qt in namespace
        https://bugs.webkit.org/show_bug.cgi?id=51701

        * QtTestBrowser/webview.h:

2010-12-28  Daniel Bates  <dbates@rim.com>

        Reviewed by Sam Weinig.

        Substitute // MARK: for compiler-specific #pragma mark
        https://bugs.webkit.org/show_bug.cgi?id=51657

        Fix future compilation warnings about "#pragma mark" on GTK+ bots by
        substituting  "// MARK:" for "#pragma mark", which provides
        analogous code-bookmarking functionality under Xcode.

        Also, for consistency, we should substitute "// MARK:" for compiler-
        specific "#pragma mark" in the source files for the Mac port.

        * DumpRenderTree/AccessibilityTextMarker.cpp:
        * DumpRenderTree/cf/WebArchiveDumpSupport.h:
        * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm:
        * DumpRenderTree/mac/ObjCController.m:
        * MiniBrowser/mac/AppDelegate.m:
        * MiniBrowser/mac/BrowserWindowController.m:

2010-12-28  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Eric Seidel.

        Add --no-build option to run-sunspider
        https://bugs.webkit.org/show_bug.cgi?id=51658

        * Scripts/run-sunspider: add --no-build flag to skip building
        phase.

2010-12-27  Daniel Bates  <dbates@rim.com>

        Rubber-stamped by Martin Robinson.

        Append the directory Tools/DumpRenderTree to the list of directories that
        do-webcore-rename should search so that it can rename DRT files and
        source code.

        * Scripts/do-webcore-rename:

2010-12-27  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        build-webkit should detect missing Java SDK and explain how to install it
        https://bugs.webkit.org/show_bug.cgi?id=51651

        * Scripts/build-webkit:

2010-12-26  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Daniel Bates.

        [GTK] Add support for build-jsc
        https://bugs.webkit.org/show_bug.cgi?id=51625

        Add GTK+ support to build-jsc now that building the jsc executable as
        a standalone target is easy.

        * Scripts/build-jsc: Call buildGtkProject for the GTK+ case now.
        * Scripts/build-webkit: Pass in the proper target name to buildGtkProject.
        * Scripts/webkitdirs.pm: Actually process the project parameter in buildGtkProject
        and pass it along to buildAutotoolsProject.

2010-12-27  David Levin  <levin@chromium.org>

        Reviewed by Eric Seidel.

        check-webkit-style check for meaningless variable names in function declarations.
        https://bugs.webkit.org/show_bug.cgi?id=51523

        * Scripts/webkitpy/style/checker.py: Exempted JavaScriptCore/jit/JITStubs.cpp
        from the new check and whitespace/parens because the syntax is unusual and
        produced a fair number of positives for these checks.
        * Scripts/webkitpy/style/checkers/cpp.py:
        (_convert_to_lower_with_underscores): Used as a canonical form for type names
        and parameter names when determining if the parameter name is useless.
        (_create_acronym): Used to check for redundant variable names in cases like "ExceptionCode ec"
        (Parameter.lower_with_underscores_name): Gives back the parameter name in a lower_with_underscore
        format.
        (_check_parameter_name_against_text):  Checks to see if the parameter name is in the
        text or an acronym of it.
        (check_function_definition): Checks function definitions for meaningless variable names.
        (process_line): Added call to check_function_definition.
        * Scripts/webkitpy/style/checkers/cpp_unittest.py:
        (CppFunctionsTest.test_convert_to_lower_with_underscores): Test for _convert_to_lower_with_underscores.
        (CppFunctionsTest.test_create_acronym): Test for _create_acronym.
        (CppFunctionsTest.test_check_parameter_against_text): Test for _check_parameter_against_text.
        (CppStyleTestBase.perform_single_line_lint): Removed the parameter name check
        because when only checking a snippet, there are a lot of bogus functions.
        (CppStyleTestBase.perform_multi_line_lint): Ditto and removed a bogus filter
        that I put there previously and just noticed.
        (WebKitStyleTest.test_parameter_names): Tests for the functionality -- both
        check_function_definition and process_line.

2010-12-27  Carlos Garcia Campos  <cgarcia@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Disable flash plugin in GtkLauncher when using gtk3
        https://bugs.webkit.org/show_bug.cgi?id=51591

        Flash plugin uses gtk2 that is incompatible with gtk3 making
        webkit crash when it's built with gtk3.

        * GtkLauncher/main.c:
        (main):

2010-12-25  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Move ANGLE to Sources/ThirdParty
        https://bugs.webkit.org/show_bug.cgi?id=51605

        * Scripts/build-webkit:
          - Point to the new ANGLE location.

2010-12-26  David Levin  <levin@chromium.org>

        Reviewed by Eric Seidel.

        check-webkit-style should be able to parse function declaration parameters.
        https://bugs.webkit.org/show_bug.cgi?id=51451

        * Scripts/webkitpy/style/checkers/cpp.py:
        (Position.__init__): Holds simple position information (row, column).
        (Parameter.__init__): Holds information about a parameter.
        (SingleLineView.__init): Converts multiple lines into a single line for simpler searches.
        (SingleLineView.convert_column_to_row): Returns the original row given a column.
        (create_skeleton_parameters): Simplifies a parameter list for easier searching.
        (find_parameter_name_index): Finds where the parameter name is.
        (parameter_list): Generates the list of parameters for a function.
        (_FunctionState.begin): Added information to allow determining the parameters
        on demand.
        (_FunctionState.get_parameter_list): Returns a tuple of function parameters.
        (detect_functions): Improve function detection for operator functions and
        determine where the parameters end and pass that to _FunctionState.begin.
        * Scripts/webkitpy/style/checkers/cpp_unittest.py:
        (CppFunctionsTest.test_parameter): Verifies Parameter functionality.
        (CppFunctionsTest.test_single_line_view): Verifies SingleLineView functionality.
        (CppFunctionsTest.test_create_skeleton_parameters): Verifies create_skeleton_parameters.
        (CppFunctionsTest.test_find_parameter_name_index): Verifies find_parameter_name_index.
        (CppFunctionsTest.test_parameter_list): Does some minimal verification for parameter list.
        Much more thorough verification is done as part of FunctionDetectionTest.test_parameter_list.
        (FunctionDetectionTest.perform_function_detection): Added support for verifying
        the parameters found.
        (FunctionDetectionTest.test_function_declaration_detection): Added more function
        detection test to verify that we catch the operator functions.
        (FunctionDetectionTest.test_ignore_macros): Verify that function detection ignores macros.
        (FunctionDetectionTest.test_parameter_list): Added tests to verify the parameter parsing.
        (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_bad_test_doesnt_break): Removed
        because the error. The test is about the bad function name. Fixing the name makes the test exactly like
        test_function_length_check_definition_severity1_for_test.

2010-12-25  Patrick Gansterer  <paroga@webkit.org>

        Unreviewed WinCE buildfix after r74334.

        * CMakeListsWinCE.txt:

2010-12-24  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r74632.
        http://trac.webkit.org/changeset/74632
        https://bugs.webkit.org/show_bug.cgi?id=51600

        makes test-webkitpy hang forever on GTK (Requested by philn-tp
        on #webkit).

        * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
        * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:

2010-12-24  Ryuan Choi  <ryuan.choi@samsung.com>

        Reviewed by Kenneth Rohde Christiansen.

        [EFL] Screen doesn't be rendered when changing size of EWebLauncher
        https://bugs.webkit.org/show_bug.cgi?id=43528

        Remove on_resize because ewk_view_fixed_layout_size_set should not be
        called on callback of EVAS_CALLBACK_RESIZE. As it change size of
        FrameView, rendering was ignored when _ewk_view_smart_calculate was
        called.

        * EWebLauncher/main.c:
        (browserCreate):

2010-12-24  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        webkit-patch (or a pre-commit hook) needs to prevent bad ChangeLog changes
        https://bugs.webkit.org/show_bug.cgi?id=28291

        This is a start.  At least now webkit-patch will prompt when your ChangeLog looks questionable.
        We could do more advanced things, like parsing the ChangeLog (with changelog.py) and comparing that
        to strings with find in the diff.
        Since non-interactive always returns the default, this should cause patches with bad changelogs to fail on the commit-queue.

        * Scripts/webkitpy/common/checkout/api.py:
        * Scripts/webkitpy/common/checkout/diff_parser.py:
        * Scripts/webkitpy/tool/steps/abstractstep.py:
        * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
        * Scripts/webkitpy/tool/steps/validatechangelogs.py: Copied from Tools/Scripts/webkitpy/tool/steps/validatereviewer.py.
        * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py: Copied from Tools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.
        * Scripts/webkitpy/tool/steps/validatereviewer.py:

2010-12-24  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Kenneth Russell.

        Modify new-run-webkit-tests to shut up and exit when all the threads
        are wedged so that test runs complete faster and we don't end up
        w/ enormous log files.

        https://bugs.webkit.org/show_bug.cgi?id=51572

        * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
        * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:

2010-12-24  Eric Seidel  <eric@webkit.org>

        Reviewed by David Levin.

        commit-queue should better explain how it will re-open bugs and follow duplicate chains
        https://bugs.webkit.org/show_bug.cgi?id=51549

        I've had multiple people ask me about the commit-queue's behavior
        regarding reporting flaky tests.  I figured it would be best to just
        have the queue explain itself in the bugs it files.

        * Scripts/webkitpy/tool/bot/flakytestreporter.py:
        * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:

2010-12-24  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Eric Seidel.

        check-webkit-style: should ignore "wrong" namings in JavaScriptCore/qt
        https://bugs.webkit.org/show_bug.cgi?id=51467

        * Scripts/webkitpy/style/checker.py:
        * Scripts/webkitpy/style/checker_unittest.py:

2010-12-23  Adam Barth  <abarth@webkit.org>

        Rubber-stamped by Eric Seidel.

        Move JavaScriptGlue into Sources
        https://bugs.webkit.org/show_bug.cgi?id=51583

        These tools refer to JavaScriptGlue and need to be updated to its new
        location.

        * Scripts/build-webkit:
        * Scripts/do-file-rename:
        * Scripts/do-webcore-rename:
        * Scripts/webkitpy/common/config/build.py:
        * Scripts/webkitpy/common/config/build_unittest.py:

2010-12-23  Lucas Forschler  <lforschler@apple.com>

        Reviewed by Eric Seidel.

        Bug 51539 - update iexploder scripts to point to new location

        * Scripts/run-iexploder-tests:
        * Scripts/update-iexploder-cssproperties:

2010-12-23  Evan Martin  <evan@chromium.org>

        Reviewed by Ryosuke Niwa.

        [chromium] LayoutTestController warning in float->int conversion
        https://bugs.webkit.org/show_bug.cgi?id=51553

        Rather than reading an int, converting to a float, then getting a compiler
        warning on passing the float to something that expects an int, instead
        just pass around ints.

        No tests, fixes a compiler warning.

        * DumpRenderTree/chromium/LayoutTestController.cpp:
        (parsePageSizeParameters):
        (LayoutTestController::pageNumberForElementById):
        (LayoutTestController::numberOfPages):

2010-12-23  Lucas Forschler  <lforschler@apple.com>

        Reviewed by Darin Adler.

        Bug 51537 - iexploder needs cleanup
        
        * iExploder/htdocs: Removed.
        * iExploder/htdocs/config.rb: Removed.
        * iExploder/htdocs/cssproperties.in: Removed.
        * iExploder/htdocs/cssvalues.in: Removed.
        * iExploder/htdocs/htmlattrs.in: Removed.
        * iExploder/htdocs/htmltags.in: Removed.
        * iExploder/htdocs/htmlvalues.in: Removed.
        * iExploder/htdocs/iexploder.cgi: Removed.
        * iExploder/htdocs/iexploder.rb: Removed.
        * iExploder/htdocs/index.html: Removed.
        * iExploder/htdocs/webserver.rb: Removed.
        * iExploder/iexploder-1.7.2/output: Removed.
        * iExploder/tools: Removed.
        * iExploder/tools/lasthit.rb: Removed.
        * iExploder/tools/osx_last_crash.rb: Removed.
        * iExploder/tools/showtest.rb: Removed.

2010-12-23  Lucas De Marchi  <lucas.demarchi@profusion.mobi>

        Reviewed by Kenneth Rohde Christiansen.

        [EFL] Make 'single' the default backing store in EWebLauncher
        https://bugs.webkit.org/show_bug.cgi?id=51534

        'single' is the simplest backing store and the one intended to be the
        default in the test browser. By mistake the tiled backing store was
        left as default in r72617.

        * EWebLauncher/main.c:
        (browserCreate): ditto.

2010-12-23  Lucas De Marchi  <lucas.demarchi@profusion.mobi>

        Reviewed by Kenneth Rohde Christiansen.

        [EFL] Subject: [webkit 4/4] [EFL] Remove non-sense workaround
        https://bugs.webkit.org/show_bug.cgi?id=51533

        There's no point in concatenating env("HOME") with "blah", so remove
        option from EWebLauncher.

        * EWebLauncher/main.c:
        (main): ditto.

2010-12-23  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Eric Seidel.

        Web Inspector: chromium: inspector's tests are quite slow especially at windows(Debug).

        Almost all inspector's tests become flaky on chromium Win(dbg) after switching to DRT.
        I just discovered that we have two additional GC runs per each WebViewHost.
        Test_shell had no such calls.
        These gc runs eat 15% of cpu time.

        https://bugs.webkit.org/show_bug.cgi?id=51479

        * DumpRenderTree/chromium/WebViewHost.cpp:
        (WebViewHost::~WebViewHost):

2010-12-22  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Ojan Vafai.

        This change splits out the TestRunner class into its own file.
        When we fork the code for message passing, we will create a new
        TestRunner, and this change will allow that to be more modular.

        While we're at it, split out TestInput and ResultSummary into
        their own files, to reduce the size of run_webkit_tests to
        something more managable.

        https://bugs.webkit.org/show_bug.cgi?id=51092

        * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
        * Scripts/webkitpy/layout_tests/layout_package/result_summary.py:
        * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
        * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
        * Scripts/webkitpy/layout_tests/layout_package/test_input.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:

 2010-12-22  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Ojan Vafai.

        nrwt multiprocessing - start over, prepare to fork the code
 
        This code cleans up the signatures and implementation of the
        TestRunner class so we can easily fork it to run either the
        stable implementation or the new, unstable message-passing
        implementation. The two variants will have different
        implementations of the run_tests() method. We will switch
        between the two based on the setting for the '--worker-model'
        switch. We rename the two currently valid values to 'old-inline'
        and 'old-threads'.

        https://bugs.webkit.org/show_bug.cgi?id=51081

        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:

2010-12-22  Victor Wang  <victorw@chromium.org>

        Reviewed by Darin Fisher.

        [Chromium] Update chromium archive test result url in rebaseline script.

        https://bugs.webkit.org/show_bug.cgi?id=51503

        * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:

2010-12-22  Lucas Forschler  <lforschler@apple.com>

        Reviewed by Alice Liu.

        <rdar://problem/8633222> record-memory-win needs to record memory used by the webprocess.
        Verified on Chrome, Safari, and IE.
        With this change, we will record memory from a parent browser window and all child processes.

        * record-memory-win/main.cpp:
        (ProcessArgs):
        (PrintUsage):
        (getMemoryInfo):
        (printProcessInfo):
        (evalProcesses):
        (UseImage):
        (QueryContinuously):
        (ElapsedTime):

2010-12-22  Lucas Forschler  <lforschler@apple.com>

        Unreviewed rollout r74489, because it was missing changelog.

        * record-memory-win/main.cpp:
        
2010-12-22  Ryosuke Niwa  <rniwa@webkit.org>

        Adding myself as a reviewer.

        * Scripts/webkitpy/common/config/committers.py:

2010-12-22  Andrew Scherkus  <scherkus@chromium.org>

        Unreviewed.  Adding myself to committers.py.

        * Scripts/webkitpy/common/config/committers.py:

2010-12-22  Ariya Hidayat  <ariya@sencha.com>

        Reviewed by Kenneth Rohde Christiansen.

        TestNetscapePlugIn should use #if defined
        https://bugs.webkit.org/show_bug.cgi?id=51471

        * DumpRenderTree/TestNetscapePlugIn/main.cpp:
        (NP_Initialize):
        (NPP_New):

2010-12-22  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: [chromium] DRT inspector layout tests are flaky in debug.

        DevTools window should be closed explicitly because it has custom deinitialization code.

        https://bugs.webkit.org/show_bug.cgi?id=50722

        * DumpRenderTree/chromium/TestShell.cpp:
        (TestShell::closeRemainingWindows):

2010-12-22  David Levin  <levin@chromium.org>

        Reviewed by Shinichiro Hamaji.

        check-webkit-style shouldn't complaint about underscores in variables in objective C files.
        https://bugs.webkit.org/show_bug.cgi?id=51452

        * Scripts/webkitpy/style/checkers/cpp.py:
        (_FileState.__init__): Added the information to determine if a file is C or Objective C.
        Using the file extension if possible but falling back to the file contents if we have a header file.
        (_FileState.is_objective_c): Determine if we have an Objective C by examining the file contents if needed.
        (_FileState.is_c_or_objective_c):
        (check_using_std): Changed to using _FileState to determine the file type.
        (check_max_min_macros): Ditto.
        (check_for_null): Ditto.
        (check_style): Changed the parameters to various calls since they now need _FileState
        to determine the file type.
        (check_language): Added the file_state parameter so it could be passed
        to check_identifier_name_in_declaration.
        (check_identifier_name_in_declaration): Don't warn about underscores in variables if
        this is an Objective C file.
        (_process_lines): Added information for the _FileState constructor (and moved the
        call to a place that had the information).
        * Scripts/webkitpy/style/checkers/cpp_unittest.py:
        (CppFunctionsTest.test_is_c_or_objective_c): Changed the tests to use FileState and exercise
        its functionality.
        (WebKitStyleTest.test_names): Add tests for underscores in Objective C files.

2010-12-21  Andy Estes  <aestes@apple.com>

        Reviewed by Mark Rowe.

        Do not build non-Intel architectures for WebKit2-related projects.
        https://bugs.webkit.org/show_bug.cgi?id=51440

        * MiniBrowser/Configurations/Base.xcconfig: Only build for i386 and x86_64.
        * TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
        * WebKitTestRunner/Configurations/Base.xcconfig: Ditto.

2010-12-21  Mihai Parparita  <mihaip@chromium.org>

        Reviewed by Darin Fisher.

        [Chromium] Rename WebThemeEngine/ControlDRT to WebThemeEngine/ControlDRTWin
        https://bugs.webkit.org/show_bug.cgi?id=51406 
        
        Rename WebThemeControlDRT to WebThemeControlDRTWin and WebThemeEngineDRT
        to WebThemeEngineDRTWin and update references everywhere.

        * DumpRenderTree/DumpRenderTree.gypi:
        * DumpRenderTree/chromium/TestShellWin.cpp:
        * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRT.cpp.
        * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRT.h.
        * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRT.cpp.
        * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRT.h.

2010-12-21  Anders Carlsson  <andersca@apple.com>

        Reviewed by John Sullivan.

        Clicking missing plug-in text does not show a sheet
        https://bugs.webkit.org/show_bug.cgi?id=51403

        Update for changes to the WebPageUIClient.

        * MiniBrowser/mac/BrowserWindowController.m:
        (-[BrowserWindowController awakeFromNib]):
        * WebKitTestRunner/TestController.cpp:
        (WTR::createOtherPage):
        (WTR::TestController::initialize):

2010-12-21  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        commit-queue will report constant failures as flaky if other tests flake
        https://bugs.webkit.org/show_bug.cgi?id=51272

        This patch just removes functionality and adds testing.
        Previously we attempted to report flaky tests when we had
        two different tests fail in a row.  However, since we stop
        running the tests at the first failure, our code was wrong in
        trying to determine flakiness from the incomplete runs.

        Originally I posted an alternate patch:
        https://bug-51272-attachments.webkit.org/attachment.cgi?id=77078
        which fixed our flaky logic in this case, however it was decided
        that that patch would be too difficult to maintain, so now
        I'm just removing the broken logic.

        This will dramatically cut-down on our flaky-test false positives
        at the (small) cost of the queues being unable to report
        any flakiness if the tree is very flaky.  (With at least one test
        flaking on every run, we'll never report failures anymore.)  I think
        this is a tradeoff worth making.

        * Scripts/webkitpy/tool/bot/commitqueuetask.py:
        * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:

2010-12-20  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        commit-queue wrongly rejects patches when it can't update itself
        https://bugs.webkit.org/show_bug.cgi?id=46636

        * Scripts/webkitpy/tool/bot/commitqueuetask.py:
        * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
        * Scripts/webkitpy/tool/commands/queues_unittest.py:

2010-12-20  Adam Barth  <abarth@webkit.org>

        Move web sites to Websites directory
        https://bugs.webkit.org/show_bug.cgi?id=51323

        Update references to BugsSite to point to the new location.

        This patch was never officially reviewed (because it was too large to
        upload to bugs.webkit.org), but it was discussed on webkit-dev and Mark
        Rowe gave me the green light.

        * Scripts/old-run-webkit-tests:
        * Scripts/webkitpy/common/config/build.py:
        * Scripts/webkitpy/common/config/build_unittest.py:
        * Scripts/webkitpy/common/prettypatch.py:
        * Scripts/webkitpy/layout_tests/port/base.py:
        * Scripts/webkitpy/style/main.py:

2010-12-20  Adrienne Walker  <enne@google.com>

        Unreviewed. Adding myself to the list of committers.

        * webkitpy/common/config/committers.py:

2010-12-20  Mark Rowe  <mrowe@apple.com>

        Reviewed by Dan Bernstein.

        <rdar://problem/8757601> Don't install header files in to the Resources directory.

        * Scripts/check-for-inappropriate-files-in-framework: Don't allow .h files in the
        Resources directory.

2010-12-20  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        commit-queue should include bot id when attaching failure diffs
        https://bugs.webkit.org/show_bug.cgi?id=51280

        This is a tiny change to include the bot id in the name of the attachment.
        Most of this diff is just changing the unit test expectations
        now that I hid the comment printing when the comment is None.

        * Scripts/webkitpy/tool/bot/flakytestreporter.py:
        * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
        * Scripts/webkitpy/tool/commands/upload_unittest.py:
        * Scripts/webkitpy/tool/mocktool.py:

2010-12-20  Jeff Miller  <jeffm@apple.com>

        Reviewed by Dan Bernstein.

        Tools/vcbin/midl.exe needs to be rebuilt
        https://bugs.webkit.org/show_bug.cgi?id=51347

        * vcbin/midl.exe: Rebuilt.

2010-12-20  David Levin  <levin@chromium.org>

        Reviewed by Ariya Hidayat.

        .gitignore and webkit-tools-completion.sh have references to WebKitTools that should be Tools.
        https://bugs.webkit.org/show_bug.cgi?id=51343

        Follow up from the WebKitTools -> Tools rename.

        * Scripts/webkit-tools-completion.sh:

2010-12-20  Cosmin Truta  <ctruta@chromium.org>

        Reviewed by James Robinson.

        new-run-webkit-tests ignores trailing EOL differences in text tests
        https://bugs.webkit.org/show_bug.cgi?id=36983

        Changed the handling of new-line characters within new-run-webkit-tests
        to match old-run-webkit-tests.  Differences in leading and trailing empty
        lines in text expectation files are no longer ignored.

        * Scripts/webkitpy/layout_tests/port/base.py:
        * Scripts/webkitpy/layout_tests/port/test.py:
        Added unit tests.  Removed old duplicate unit test entries.
        * Scripts/webkitpy/layout_tests/test_types/text_diff.py:

2010-12-20  David Levin  <levin@chromium.org>

        Reviewed by Shinichiro Hamaji.

        check-webkit-style should detect function declarations (and trivial functions).
        https://bugs.webkit.org/show_bug.cgi?id=51303

        * Scripts/webkitpy/style/checkers/cpp.py:
        (_FunctionState.begin): Add is_declaration and changed the line count
        start to begin at -1 (which will keep the results consistent, since
        the starting line number passed in is one less in this change).
        (detect_functions): changed function detection to now catch trivial
        functions and declarations.
        (check_pass_ptr_usage): Don't check for Pass*Ptr on the first line
        of the function as this may look at return values (when processing
        a declaration).
        * Scripts/webkitpy/style/checkers/cpp_unittest.py:
        (FunctionDetectionTest.perform_function_detection): Basic mechanics
        of testing the function detection.
        (FunctionDetectionTest.test_basic_function_detection): Test a simple
        function.
        (FunctionDetectionTest.test_function_declaration_detection): Test a
        declaration.
        (FunctionDetectionTest.test_non_functions): A test case for a case
        that caused the code to fail due to the { being in quotes.
        (PassPtrTest.test_pass_ref_ptr_return_value): Added some more test
        cases to help catch false alarms for return values.
        (PassPtrTest.test_pass_ref_ptr_member_variable): Ensure that
        we don't get false alarms for member variables either.

2010-12-20  Ryuan Choi  <ryuan.choi@samsung.com>

        Reviewed by Antonio Gomes.

        [CMAKE] Rename WEBKITTOOLS_DIR to TOOLS_DIR
        https://bugs.webkit.org/show_bug.cgi?id=51319

        * CMakeListsEfl.txt:

2010-12-18  Adam Barth  <abarth@webkit.org>

        Reviewed by Sam Weinig.

        Move WebKitExamplePlugins to Examples
        https://bugs.webkit.org/show_bug.cgi?id=51291

        * Scripts/webkitpy/common/config/build.py:

2010-12-17  Csaba Osztrogonác  <ossy@webkit.org>

        Unreviewed Qt buildfix after r74301.

        Rename WebKitTools to Tools
        https://bugs.webkit.org/show_bug.cgi?id=49861

        * MiniBrowser/DerivedSources.pro:
        * MiniBrowser/qt/MiniBrowser.pro:

2010-12-17  Dan Bernstein  <mitz@apple.com>

        Reviewed by Simon Fraser.

        Rename WebKitTools to Tools
        https://bugs.webkit.org/show_bug.cgi?id=49861

        * BuildSlaveSupport/build.webkit.org-config/master.cfg:
        * CodeCoverage/README:
        * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
        (WebCore::DumpRenderTree::initializeFonts):
        * EWSTools/start-commit-queue.sh:
        * EWSTools/start-queue.sh:
        * GNUmakefile.am:
        * MIDLWrapper/MIDLWrapper.cpp:
        (wmain):
        * MiniBrowser/qt/MiniBrowser.pro:
        * Scripts/build-api-tests:
        * Scripts/build-dumprendertree:
        * Scripts/build-webkit:
        * Scripts/build-webkittestrunner:
        * Scripts/generate-coverage-data:
        * Scripts/old-run-webkit-tests:
        * Scripts/run-api-tests:
        * Scripts/run-iexploder-tests:
        * Scripts/run-javascriptcore-tests:
        * Scripts/run-mangleme-tests:
        * Scripts/run-sunspider:
        * Scripts/run-webkit-websocketserver:
        * Scripts/sunspider-compare-results:
        * Scripts/test-webkitperl:
        * Scripts/test-webkitpy:
        * Scripts/update-iexploder-cssproperties:
        * Scripts/update-webkit:
        * Scripts/update-webkit-localizable-strings:
        * Scripts/webkitdirs.pm:
        * Scripts/webkitpy/common/checkout/scm.py:
        * Scripts/webkitpy/common/checkout/scm_unittest.py:
        * Scripts/webkitpy/common/config/committervalidator.py:
        * Scripts/webkitpy/common/config/committervalidator_unittest.py:
        * Scripts/webkitpy/common/config/ports.py:
        * Scripts/webkitpy/common/config/ports_unittest.py:
        * Scripts/webkitpy/common/system/logutils_unittest.py:
        * Scripts/webkitpy/common/system/ospath_unittest.py:
        * Scripts/webkitpy/layout_tests/port/chromium.py:
        * Scripts/webkitpy/layout_tests/port/config.py:
        * Scripts/webkitpy/layout_tests/port/config_unittest.py:
        * Scripts/webkitpy/layout_tests/port/http_server.py:
        * Scripts/webkitpy/layout_tests/port/test.py:
        * Scripts/webkitpy/style/checker.py:
        * Scripts/webkitpy/style/checker_unittest.py:
        * Scripts/webkitpy/tool/bot/feeders_unittest.py:
        * Scripts/webkitpy/tool/commands/queues_unittest.py:
        * Scripts/webkitpy/tool/steps/steps_unittest.py:
        * WebKitTestRunner/DerivedSources.pro:
        * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
        (WTR::activateFonts):
        * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
        * wx/build/build_utils.py:

2010-12-16  Antonio Gomes  <agomes@rim.com>

        Reviewed by Martin Robinson.

        Settings::editingBehaviorType() incorrectly returns mac for the gtk build when running tests
        https://bugs.webkit.org/show_bug.cgi?id=51163

        Since GTK+'s default editing behavior was changed to UNIX in r70975 (see webkitwebsettings.cpp),
        GTK+'s DRT should also reset to UNIX after each test execution.

        * DumpRenderTree/gtk/DumpRenderTree.cpp:
        (resetDefaultsToConsistentValues):

2010-12-17  David Levin  <levin@chromium.org>

        Reviewed by Eric Seidel.

        check-webkit-style should understand WTF #include guards
        https://bugs.webkit.org/show_bug.cgi?id=44911

        * Scripts/webkitpy/style/checkers/cpp.py:
        (get_header_guard_cpp_variable): modify to suggest the WTF style
        of header guard when appropriate.
        (check_for_header_guard): handle multiple return values from
        get_header_guard_cpp_variable
        * Scripts/webkitpy/style/checkers/cpp_unittest.py:
        (CppStyleTest.test_build_header_guard): Added tests for the WTF
        header style.

2010-12-16  David Levin  <levin@chromium.org>

        Reviewed by Eric Seidel.

        test-webkitpy: unittest for the xml.py checker displays a decprecation warning.
        https://bugs.webkit.org/show_bug.cgi?id=51210

        The error only shows up when using python 2.6 or later.

        * Scripts/webkitpy/style/checkers/xml.py: Replace the usage of
        the decprecated field error,message with something equivalent.

2010-12-16  Mihai Parparita  <mihaip@chromium.org>

        Reviewed by Eric Seidel.

        Add --exit-after-n-failures/crashes to NRWT
        https://bugs.webkit.org/show_bug.cgi?id=51160
        
        Abort test run (in a similar way to how control-C is handled) when
        --exit-after-n-failures/crashes-or-timeouts are passed and we've reached
        that number of unexpected failures/crashes/timeouts.

        * Scripts/webkitpy/layout_tests/port/test.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:

2010-12-16  David Levin  <levin@chromium.org>

        Reviewed by Shinichiro Hamaji.

        check-webkit-style unit tests has some duplicate boilerplate code.
        https://bugs.webkit.org/show_bug.cgi?id=49519

        * Scripts/webkitpy/style/checkers/cpp.py:
        (update_include_state): Replaced the "io" parameter with the global
        configuration _unit_test_config. This allowed not calling into
        functions at a low level and also not plumbing through the injection
        information through many levels of code.
        (check_for_include_what_you_use): Ditto.
        (process_file_data): Added the ability to set up the unit test config
        to allow for injection.
        * Scripts/webkitpy/style/checkers/cpp_unittest.py:
        (ErrorCollector.__init__): Added support for having a filter for errors.
        (ErrorCollector.__call__): Ditto.
        (CppStyleTestBase.process_file_data): Added the ability to set unit_test_config.
        (CppStyleTestBase.perform_lint): Consolidated logic for the perform functions.
        (CppStyleTestBase.perform_single_line_lint): Replace specific calls to
        functions in the cpp.py with generic processing and a filter that
        indicates what errors should be kept.
        (CppStyleTestBase.perform_multi_line_lint): Ditto.
        (CppStyleTestBase.perform_language_rules_check): Ditto.
        (CppStyleTestBase.perform_function_lengths_check): Ditto.
        (CppStyleTestBase.perform_pass_ptr_check): Ditto.
        (CppStyleTestBase.perform_include_what_you_use): Ditto.
        (CppStyleTest.test_multi_line_comments): Added another
        error message which applies to the test case.
        (CppStyleTest.test_spacing_for_binary_ops): Fixed test
        to not have config.h, since it is processed as a header file.
        (CppStyleTest.test_static_or_global_stlstrings): Fixed variable name
        style and indentation in checked code.
        (OrderOfIncludesTest.test_check_preprocessor_in_include_section):
        Fixed line number.
        (NoNonVirtualDestructorsTest.test_multi_line_declaration_with_error):
        Ditto.

2010-12-15  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r74136.
        http://trac.webkit.org/changeset/74136
        https://bugs.webkit.org/show_bug.cgi?id=51135

        r74136 breaks chromium canary bots because some tests are not
        rebaselined correctly to resolve EOL differences (Requested by
        jianli on #webkit).

        * Scripts/webkitpy/layout_tests/port/base.py:
        * Scripts/webkitpy/layout_tests/port/test.py:
        * Scripts/webkitpy/layout_tests/test_types/text_diff.py:

2010-12-15  Adam Roben  <aroben@apple.com>

        Teach check-webkit-style to check .vcproj and .vsprops files for XML
        syntax errors

        Fixes <http://webkit.org/b/51103> check-webkit-style should check for
        XML syntax errors in .vcproj/.vsprops files

        Reviewed by Dave Levin.

        * Scripts/webkitpy/style/checker.py: Added lists of file extensions
        that should be treated as XML and that should be allowed to contain
        carriage returns. (These lists happen to be identical currently.)
        (FileType): Added a new XML type.
        (CheckerDispatcher.should_check_and_strip_carriage_returns): Added.
        Just does a simple file extension check.
        (CheckerDispatcher._file_type): Added a case for XML files.
        (CheckerDispatcher._create_checker): Ditto. We use XMLChecker for XML
        files (surprise!).
        (StyleProcessor.process): Ask the dispatcher whether we should pass the
        lines through the carriage checker.

        * Scripts/webkitpy/style/checker_unittest.py:
        (CheckerDispatcherCarriageReturnTest.test_should_check_and_strip_carriage_returns):
        Added. Checks a few file names to see if carriage returns are allowed
        or not.
        (CheckerDispatcherDispatchTest.assert_checker_xml): Added. Similar to
        other assert_checker_* functions.
        (CheckerDispatcherDispatchTest.test_xml_paths): Added. Similar to other
        test_*_paths functions.
        (CheckerDispatcherDispatchTest.test_xml_paths): Added. Similar to other
        test_*_paths functions.
        (CheckerDispatcherDispatchTest.test_none_paths): Removed the vcproj
        file from this test case, as vcproj files now have a type.
        (StyleProcessor_CodeCoverageTest.MockDispatcher.should_check_and_strip_carriage_returns):
        Added. Similar to the other should_* functions.
        (StyleProcessor_CodeCoverageTest.test_process__carriage_returns_not_stripped):
        Added. Checks that carriage returns aren't checked for or stripped for
        allowed files.

        * Scripts/webkitpy/style/checkers/xml.py: Added.
        (XMLChecker.__init__): Simple init method.
        (XMLChecker.check): Pass each line through the expat parser, and record
        a style error for any errors thrown by the parser.

        * Scripts/webkitpy/style/checkers/xml_unittest.py: Added.
        (XMLCheckerTest.assert_no_error): Checks that the given XML does not
        produce a style error.
        (XMLCheckerTest.assert_error): Checks that the given XML produces an
        error of the given category on the given line.
        (XMLCheckerTest.mock_handle_style_error): Does nothing. Used for
        checking that the XMLChecker constructor works properly.
        (XMLCheckerTest.test_conflict_marker): Tests that conflict markers
        cause a style error (see, e.g., r73887).
        (XMLCheckerTest.test_extra_closing_tag): Tests that extra closing tags
        cause a style error (see, e.g., r73773).
        (XMLCheckerTest.test_init): Tests that the XMLChecker constructor works
        properly.
        (XMLCheckerTest.test_missing_closing_tag): Tests that missing closing
        tags cause a style error (see, e.g., r72795).
        (XMLCheckerTest.test_no_error): Tests that valid XML does not cause a
        style error.

2010-12-15  Lucas Forschler  <lforschler@apple.com>

        Reviewed by Stephanie Lewis.

        https://bugs.webkit.org/show_bug.cgi?id=51117
        Add a new leopard test bot
        really really commit to trunk this time.

        * BuildSlaveSupport/build.webkit.org-config/config.json:

2010-12-15  Sam Weinig  <sam@webkit.org>

        Reviewed by Anders Carlsson.

        WebKit2: Can't add files to an <input type=file>
        https://bugs.webkit.org/show_bug.cgi?id=51087

        * MiniBrowser/mac/BrowserWindowController.m:
        (runOpenPanel):
        (-[BrowserWindowController awakeFromNib]):
        Add simple implementation of runOpenPanel callback.

        * MiniBrowser/win/BrowserView.cpp:
        (BrowserView::create):
        * WebKitTestRunner/TestController.cpp:
        (WTR::createOtherPage):
        (WTR::TestController::initialize):
        Stub out runOpenPanel callback. 

2010-12-14  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        commit-queue should upload failure diffs when tests flake
        https://bugs.webkit.org/show_bug.cgi?id=51051

        To make this testable I needed to pipe FileSystem down onto tool.
        We've wanted it there for a long time anyway.

        This patch is kinda a big hack.  But we don't have a nice
        way to read results.html files.  I think this will need further
        revision before this code actually feels clean.

        As part of testing this change, I had to make MockBugzilla.create_bug
        actually return an id (like it should) which required updating
        a few other unit test results (for the better).

        The results_matching_keys change in layouttestresults/rebasline
        was an alternate path which I decided not to use in the end, but
        I left the change as it seemed an improvement.

        * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
        * Scripts/webkitpy/common/net/layouttestresults.py:
        * Scripts/webkitpy/tool/bot/flakytestreporter.py:
        * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
        * Scripts/webkitpy/tool/commands/queues.py:
        * Scripts/webkitpy/tool/commands/rebaseline.py:
        * Scripts/webkitpy/tool/main.py:
        * Scripts/webkitpy/tool/mocktool.py:

2010-12-15  Cosmin Truta  <ctruta@chromium.org>

        Reviewed by James Robinson.

        new-run-webkit-tests ignores trailing EOL differences in text tests
        https://bugs.webkit.org/show_bug.cgi?id=36983

        Changed the handling of new-line characters within new-run-webkit-tests
        to match old-run-webkit-tests.  Differences in leading and trailing empty
        lines in text expectation files are no longer ignored.

        * Scripts/webkitpy/layout_tests/port/base.py:
        * Scripts/webkitpy/layout_tests/port/test.py:
        Added unit tests.  Removed old duplicate unit test entries.
        * Scripts/webkitpy/layout_tests/test_types/text_diff.py:

2010-12-15  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Adam Barth.

        make status-bubble white-space:nowrap so we can measure it's width without wrapping
        https://bugs.webkit.org/show_bug.cgi?id=51149

        * QueueStatusServer/templates/statusbubble.html:

2010-12-15  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Adam Barth.

        have the statusbubble postMessage it's metrics so that embedders can properly size the iframe
        https://bugs.webkit.org/show_bug.cgi?id=51125

        * QueueStatusServer/templates/statusbubble.html:

2010-12-15  Darin Adler  <darin@apple.com>

        * Scripts/webkitpy/common/net/buildbot: Added property svn:ignore.

2010-12-15  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r74117.
        http://trac.webkit.org/changeset/74117
        https://bugs.webkit.org/show_bug.cgi?id=51113

        This broke the GTK1 build. (Requested by mrobinson on
        #webkit).

        * Scripts/webkitdirs.pm:

2010-12-15  Amruth Raj  <amruthraj@motorola.com> and Ravi Kasibhatla  <ravi.kasibhatla@motorola.com>

        Reviewed by Martin Robinson.

        Change generate-forwarding-headers.pl for GTK port usage 
        (https://bugs.webkit.org/show_bug.cgi?id=37369)

        * Scripts/webkitdirs.pm: Added changes to build webkit2 for GTK port using build-webkit script.

2010-12-14  Kent Tamura  <tkent@chromium.org>

        Reviewed by Jian Li.

        [DRT/Chromium] Remove another unnecessary error message
        https://bugs.webkit.org/show_bug.cgi?id=51083

        * DumpRenderTree/chromium/WebViewHost.cpp:
        (WebViewHost::didInvalidateRect):

2010-12-14  Lucas Forschler  <lforschler@apple.com>

        Reviewed by Stephanie Lewis.

        Add a new Leopard Debug Test WK2 Bot

        * BuildSlaveSupport/build.webkit.org-config/config.json:

2010-12-14  Ojan Vafai  <ojan@chromium.org>

        Fix python unittests after http://trac.webkit.org/changeset/74070.

        * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:

2010-12-14  Kent Tamura  <tkent@chromium.org>

        Reviewed by Jian Li.

        [DRT/Chromium] Remove a unnecessary error message
        https://bugs.webkit.org/show_bug.cgi?id=51069

        * DumpRenderTree/chromium/WebViewHost.cpp:
        (WebViewHost::paintInvalidatedRegion):

2010-12-14  Benjamin Kalman  <kalman@chromium.org>

        Reviewed by Ojan Vafai.

        Using BUG/BUGWK in test_expectations is error prone, should use BUGCR/BUGWK
        https://bugs.webkit.org/show_bug.cgi?id=48926

        * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
        Add presubmit check that BUG isn't used, either BUGCR/BUGWK/BUGV8_.

2010-12-14  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Eric Seidel.

        [Qt] [Symbian] Do not use pkg-config on Symbian as it is not supported
        https://bugs.webkit.org/show_bug.cgi?id=50231

        Guard CONFIG+=link_pkgconfig with !symbian.

        * DumpRenderTree/qt/DumpRenderTree.pro:
        * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
        * WebKitTestRunner/qt/WebKitTestRunner.pro:

2010-12-14  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Ojan Vafai.

        [new-run-webkit-tests] expectations parsing is slow
        https://bugs.webkit.org/show_bug.cgi?id=50635

        Avoid expensive iteration of all the tests when checking if a test
        file is to be skipped or not.

        * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
        * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
        * Scripts/webkitpy/layout_tests/port/test.py:

2010-12-14  Mario Sanchez Prada  <msanchez@igalia.com>

        Reviewed by Xan Lopez.

        [Gtk] Implement STATE_FOCUSED, STATE_FOCUSABLE, and corresponding events for text objects
        https://bugs.webkit.org/show_bug.cgi?id=27048

        Add support in DRT for checking whether an accessibility UI
        element is focusable and/or focused. Implemented for GTK.

        * DumpRenderTree/AccessibilityUIElement.cpp:
        (getIsFocusedCallback): New.
        (getIsFocusableCallback): New.
        (AccessibilityUIElement::getJSClass): Add the new available
        callbacks for isFocused and isFocusable.
        * DumpRenderTree/AccessibilityUIElement.h:
        * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
        (AccessibilityUIElement::isFocused): New, implemented by checking
        whether the related AtkState value is in the object's state set.
        (AccessibilityUIElement::isFocusable): Ditto.
        * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
        (AccessibilityUIElement::isFocused): New, dummy implementation.
        (AccessibilityUIElement::isFocusable): Ditto.
        * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
        (AccessibilityUIElement::isFocused): Ditto.
        (AccessibilityUIElement::isFocusable): Ditto.

2010-12-14  Eric Seidel  <eric@webkit.org>

        Reviewed by Ojan Vafai.

        webkit-patch should warn users when they're using a 32-bit git on a 64-bit system
        https://bugs.webkit.org/show_bug.cgi?id=50715

        This patch makes webkit-patch print the following:

        Warning: This machine is 64-bit, but the git binary (/usr/local/git/bin/git) does not support 64-bit.
        Install a 64-bit git for better performance, see:
        https://lists.webkit.org/pipermail/webkit-dev/2010-December/015249.html

        I wrote this mostly because I have approximately 8 machines that I use
        and making sure each one is using a good Git install seemed folly.
        webkit-patch makes a lot of git calls, so using a fast git can shave
        several seconds in every invocation.  See the webkit-dev thread for more info.

        This message will print twice during 'webkit-patch upload',
        once from webkit-patch and once from check-webkit-style.

        Unfortunately there is no good way to test this due to how machine-dependent
        the code is.  I considered writing a test for the log message, but it seemed not worth it.

        * Scripts/webkitpy/common/checkout/scm.py:

2010-12-13  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        FlakyTestReporter doesn't understand bots running from multiple email addresses
        https://bugs.webkit.org/show_bug.cgi?id=50960

        This explains at least one of the dupes of:
        https://bugs.webkit.org/show_bug.cgi?id=50863
        that we saw filed by the commit-queue this morning.
        I think the other one was explained by my previous fix to result counting code.

        Since this is really hard to test with a unit test, instead I
        create a new (possibly useful in the future) command
        which given a layout test path will return you
        the one bug which our tools would assume it the flaky test bug.
        If some other script wants to use bug-for-test we'll
        need to extend it with some options like --create-if-missing or similar.

        * Scripts/webkitpy/common/net/bugzilla/bug.py:
        * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
        * Scripts/webkitpy/tool/bot/flakytestreporter.py:
        * Scripts/webkitpy/tool/commands/__init__.py:
        * Scripts/webkitpy/tool/commands/bugfortest.py: Added.

2010-12-13  Mihai Parparita  <mihaip@chromium.org>

        Reviewed by James Robinson.

        Add option to build-webkit to not build WebKit2
        https://bugs.webkit.org/show_bug.cgi?id=50988
        
        Add support for a --no-webkit2 option to build-webkit. It seems to save
        ~1 minute from clean builds and ~10 seconds from no-op builds.

        * Scripts/build-webkit:

2010-12-13  Lucas Forschler  <lforschler@apple.com>

        Reviewed by Dave Kilzer.

        Update iexploder from 1.3.2 to 1.7.2
        Move 1.3.2 into its own subdir
        Add 1.7.2 into its own subdir
        update scripts to point to new 1.3.2 location (avoid breaking existing scripts)

        * Scripts/run-iexploder-tests:
        * Scripts/update-iexploder-cssproperties:
        * iExploder/CHANGELOG.txt: Removed.
        * iExploder/LICENSE.txt: Removed.
        * iExploder/README.txt: Removed.
        * iExploder/htdocs: Removed.
        * iExploder/iexploder-1.3.2: Added.
        * iExploder/iexploder-1.3.2/CHANGELOG.txt: Copied from iExploder/CHANGELOG.txt.
        * iExploder/iexploder-1.3.2/LICENSE.txt: Copied from iExploder/LICENSE.txt.
        * iExploder/iexploder-1.3.2/README.txt: Copied from iExploder/README.txt.
        * iExploder/iexploder-1.3.2/htdocs: Added.
        * iExploder/iexploder-1.3.2/htdocs/config.rb: Copied from iExploder/htdocs/config.rb.
        * iExploder/iexploder-1.3.2/htdocs/cssproperties.in: Copied from iExploder/htdocs/cssproperties.in.