952f8e65cd2381d2b35956fd2c1d245366671eac
[WebKit.git] / Tools / ChangeLog
1 2012-07-06  Oswald Buddenhagen  <oswald.buddenhagen@nokia.com>
2
3         [Qt] Unify qtFeatureDefaults code paths
4
5         There's no reason to run qmake on features.prf directly anymore, as we
6         can selectivly run configure tests in the project file now.
7
8         https://bugs.webkit.org/show_bug.cgi?id=90461
9
10         Reviewed by Tor Arne Vestbø.
11
12         * Scripts/webkitdirs.pm:
13         (qtFeatureDefaults):
14         * qmake/configure.pri:
15         * qmake/mkspecs/features/features.prf:
16
17 2012-07-06  Oswald Buddenhagen  <oswald.buddenhagen@nokia.com>
18
19         [Qt] Don't let qt_webkit.pri proclaim its own location
20
21         This won't work any more with recent Qt5 versions, as the forwarding
22         pri is created by qt_module_config, which needs MODULE_PRI to be set
23         up already.
24
25         We also need to load build_config, not qt_module.
26
27         https://bugs.webkit.org/show_bug.cgi?id=90461
28
29         Reviewed by Tor Arne Vestbø.
30
31         * qmake/qt_webkit.pri:
32
33 2012-07-06  Oswald Buddenhagen  <oswald.buddenhagen@nokia.com>
34
35         [Qt] Remove redundant CONFIG+=module
36
37         qt_module_config takes care of that.
38
39         In api.pri we are actually testing the flag ourselves, so now we need to
40         test a related flag qt_module_config sets instead.
41
42         Reviewed by Tor Arne Vestbø.
43
44         * qmake/mkspecs/features/default_post.prf:
45
46 2012-07-06  Oswald Buddenhagen  <oswald.buddenhagen@nokia.com>
47
48         [Qt] Switch to new-style Qt 5 configure tests
49
50         Use explicit project file action instead of syncqt magic.
51
52         https://bugs.webkit.org/show_bug.cgi?id=90461
53
54         Reviewed by Tor Arne Vestbø.
55
56         * Scripts/webkitdirs.pm:
57         (buildQMakeProjects):
58         * qmake/configure.pri: Copied from Tools/qmake/configure.pro.
59         * qmake/configure.pro:
60         * qmake/mkspecs/features/default_pre.prf:
61         * qmake/mkspecs/features/features.prf:
62         * qmake/sync.profile: Removed.
63
64 2012-07-05  Jason Liu  <jason.liu@torchmobile.com.cn>
65
66         Add Jason Liu to committers.py.
67         https://bugs.webkit.org/show_bug.cgi?id=90654
68
69         Unreviewed.
70
71         * Scripts/webkitpy/common/config/committers.py:
72
73 2012-07-05  Benjamin Poulain  <bpoulain@apple.com>
74
75         Double release of resources if the load is canceled in a callback of ResourceLoader::didFinishLoading
76         https://bugs.webkit.org/show_bug.cgi?id=90431
77
78         Reviewed by Anders Carlsson.
79
80         Add a Mac API test.
81
82         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
83         * TestWebKitAPI/Tests/mac/CancelLoadFromResourceLoadDelegate.html: Added.
84         * TestWebKitAPI/Tests/mac/CancelLoadFromResourceLoadDelegate.mm: Added.
85         (-[CancelLoadFromResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
86         (-[CancelLoadFromResourceLoadDelegateFrameLoadDelegate webView:didFinishLoadForFrame:]):
87         (TestWebKitAPI):
88         (TestWebKitAPI::TEST):
89
90 2012-07-05  Dave Tharp  <dtharp@codeaurora.org>
91
92         Adding myself as committer to committers.py
93
94         Unreviewed.
95
96         * Scripts/webkitpy/common/config/committers.py:
97
98 2012-07-05  Alexey Proskuryakov  <ap@apple.com>
99
100         [Mac][WK2] Enable HTTPS tests
101         https://bugs.webkit.org/show_bug.cgi?id=90600
102
103         Reviewed by Brady Eidson.
104
105         * DumpRenderTree/mac/DumpRenderTree.mm: (dumpRenderTree): Removed a misleading comment.
106         It explained why we were doing this here instead of a frame load delegate, but that's
107         just history, not an explanation of why we need this code.
108
109         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm: (WTR::InjectedBundle::platformInitialize):
110         Ignore certificate errors for localhost and 127.0.0.1. Since this is only needed
111         for tests, it seems appropriate to have platform specific solutions in every WTR,
112         and not add a WebKit2 API.
113
114 2012-07-05  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
115
116         [Qt] Remove rpath-hacks in qt_webkit.pri
117
118         Having it in qt_webkit.pri meant that all client apps would inherit the rpath,
119         even if they were not using QtWebKit.
120
121         This is a regression for people who build client apps against a non-installed
122         QtWebKit, as the client app will be missing a rpath to the standalone WebKit
123         build dir. This can be solved by LD_LIBRARY_PATH or custom QMAKE_RPATHDIR
124         logic, until the real issue is fixed in Qt.
125
126         Reviewed by Csaba Osztrogonác.
127
128         * qmake/mkspecs/features/rpath.prf:
129         * qmake/qt_webkit.pri:
130
131 2012-07-05  Dongwoo Im  <dw.im@samsung.com>
132
133         [EFL] Enable the CUSTOM_SCHEME_HANDLER feature as default.
134         https://bugs.webkit.org/show_bug.cgi?id=88608
135
136         Reviewed by Hajime Morita.
137
138         * Scripts/webkitperl/FeatureList.pm: Enable the CUSTOM_SCHEME_HANDLER feature as default.
139
140 2012-07-05  Ryuan Choi  <ryuan.choi@samsung.com>
141
142         [Wk2][EFL] EFL needs a WebKitTestRunner
143         https://bugs.webkit.org/show_bug.cgi?id=87659
144
145         Reviewed by Kenneth Rohde Christiansen.
146
147         Add an implementation of WebKitTestRunner for Efl port.
148
149         * CMakeLists.txt: Includes WebKitTestRunner build script.
150         * Scripts/build-webkittestrunner: Added knowledge of WebKitTestRunner/Efl.
151         * Scripts/webkitpy/layout_tests/port/efl.py: Ditto.
152         (EflPort.setup_environ_for_server):
153         * WebKitTestRunner/CMakeLists.txt: Added.
154         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
155         * WebKitTestRunner/InjectedBundle/efl/ActivateFontsEfl.cpp: Added.
156         * WebKitTestRunner/InjectedBundle/efl/InjectedBundleEfl.cpp: Added.
157         * WebKitTestRunner/InjectedBundle/efl/LayoutTestControllerEfl.cpp: Added.
158         * WebKitTestRunner/PlatformEfl.cmake: Added.
159         * WebKitTestRunner/PlatformWebView.h:
160         * WebKitTestRunner/TestController.cpp:
161         * WebKitTestRunner/config.h: Added knowledge of WebKitTestRunner/Efl.
162         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp: Added.
163         * WebKitTestRunner/efl/TestControllerEfl.cpp: Added.
164         * WebKitTestRunner/efl/main.cpp: Added.
165         (main):
166
167 2012-07-05  Christophe Dumez  <christophe.dumez@intel.com>
168
169         [WK2][EFL] Ewk_View needs API to load HTML data
170         https://bugs.webkit.org/show_bug.cgi?id=90540
171
172         Reviewed by Kenneth Rohde Christiansen.
173
174         Update EFL MiniBrowser to catch the "load,error" signal
175         on the view and display an error page.
176
177         * MiniBrowser/efl/main.c:
178         (on_error):
179         (browserCreate):
180
181 2012-07-05  Sergio Villar Senin  <svillar@igalia.com>
182
183         Hidden dirs are not copied when creating the built product archive
184         https://bugs.webkit.org/show_bug.cgi?id=90559
185
186         Reviewed by Carlos Garcia Campos.
187
188         Hidden dirs are not copied inside the built product archive
189         because the recursive copy command was ignoring them. We need those
190         hidden directories for the GTK WebKit2 testing bot to work fine.
191
192         * BuildSlaveSupport/built-product-archive:
193         (archiveBuiltProduct): replaced "*" by "." to include hidden
194         dirs/files.
195
196 2012-07-04  Yoshifumi Inoue  <yosin@chromium.org>
197
198         Unreviewed Chromium gardening, Disable always failed python tests on Windows.
199         https://bugs.webkit.org/show_bug.cgi?id=90587
200
201         PortTest.qt_linux and mac_lion are always failed on Chromium Windows at
202         creating child process.
203
204         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
205         (PortTest.disabled_test_qt_linux):
206         (PortTest.disabled_test_mac_lion):
207
208 2012-07-04  Yoshifumi Inoue  <yosin@chromium.org>
209
210         [Tools] webkit_unittest.py got assertion
211         https://bugs.webkit.org/show_bug.cgi?id=90579
212
213         Reviewed by Hajime Morita.
214
215         This patch updates expectation of assertion in test_skipped_directories_for_symbols().
216         r121874 added new (exclude) directory (inspector/styles/variables), however it didn't
217         update one of two assertions.
218
219         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
220
221 2012-07-04  Balazs Ankes  <bank@inf.u-szeged.hu>
222
223         webkit-patch should add reviewer if "Reviewed by NOBODY ..." is missing
224         https://bugs.webkit.org/show_bug.cgi?id=67935
225
226         Reviewed by Ryosuke Niwa.
227
228         * Scripts/webkitpy/common/checkout/changelog.py:
229         (ChangeLog.set_reviewer):
230         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
231         (test_set_reviewer):
232         (test_set_short_description_and_bug_url):
233
234 2012-07-04  Sheriff Bot  <webkit.review.bot@gmail.com>
235
236         Unreviewed, rolling out r121862.
237         http://trac.webkit.org/changeset/121862
238         https://bugs.webkit.org/show_bug.cgi?id=90569
239
240         It broke built-product-archive for GTK, Qt and EFL (Requested
241         by svillar on #webkit).
242
243         * BuildSlaveSupport/built-product-archive:
244         (archiveBuiltProduct):
245
246 2012-07-04  Sergio Villar Senin  <svillar@igalia.com>
247
248         Hidden dirs are not copied when creating the built product archive
249         https://bugs.webkit.org/show_bug.cgi?id=90559
250
251         Reviewed by Carlos Garcia Campos.
252
253         Hidden dirs are not copied inside the built product archive because
254         the recursive copy command was ignoring them. We need those hidden
255         directories for the GTK WebKit2 testing bot to work fine.
256
257         * BuildSlaveSupport/built-product-archive:
258         (archiveBuiltProduct): removed the trailing "*" from the copy
259         command.
260
261 2012-07-04  John Mellor  <johnme@chromium.org>
262
263         Text Autosizing: Add compile flag and runtime setting
264         https://bugs.webkit.org/show_bug.cgi?id=87394
265
266         This patch renames Font Boosting to Text Autosizing.
267
268         Reviewed by Adam Barth.
269
270         * Scripts/webkitperl/FeatureList.pm:
271         * qmake/mkspecs/features/features.pri:
272
273 2012-07-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
274
275         [Qt] Replace deprecated IN_PWD with PWD
276
277         Reviewed by Csaba Osztrogonác.
278
279         * qmake/mkspecs/features/default_pre.prf:
280
281 2012-07-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
282
283         [Qt] Don't try to build WTR twice
284
285         Reviewed by Csaba Osztrogonác.
286
287         * Tools.pro:
288
289 2012-07-04  Sheriff Bot  <webkit.review.bot@gmail.com>
290
291         Unreviewed, rolling out r121821.
292         http://trac.webkit.org/changeset/121821
293         https://bugs.webkit.org/show_bug.cgi?id=90551
294
295         This patch did not receive a high-quality review and has a
296         number of errors (Requested by abarth on #webkit).
297
298         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
299         (Build.results_url):
300         * Scripts/webkitpy/common/net/buildbot/chromiumbuildbot.py:
301         (ChromiumBuilder.accumulated_results_url):
302         * Scripts/webkitpy/layout_tests/port/builders.py:
303         * Scripts/webkitpy/tool/commands/rebaseline.py:
304         (AbstractParallelRebaselineCommand.__init__):
305         (Rebaseline):
306         (Rebaseline._builder_to_pull_from):
307         (Rebaseline._tests_to_update):
308         (Rebaseline.execute):
309         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
310         (test_rebaseline.mock_builder_to_pull_from):
311         (test_rebaseline):
312
313 2012-07-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
314
315         [Qt] Get rid of un-needed QT += declarative for Qt 5
316
317         The declarative module has been renamed to quick1 in Qt 5, and the
318         engine-only module for Qt 5 is named 'qml'. For many of the instances
319         we could just remove 'declarative', since the project file was only
320         used for Qt5/WebKit2 builds. In the other cases the module was wrapped
321         in a haveQt(4) scope.
322
323         Reviewed by Csaba Osztrogonác.
324
325         * MiniBrowser/qt/MiniBrowser.pro:
326         * WebKitTestRunner/InjectedBundle/Target.pri:
327         * WebKitTestRunner/Target.pri:
328
329 2012-07-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
330
331         [Qt] Remove a few un-needed load(features) after r121777
332
333         The features are computed by configure.pro and cached in .qmake.cache.
334
335         Reviewed by Jocelyn Turcotte..
336
337         * MiniBrowser/qt/raw/Target.pri:
338
339 2012-07-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
340
341         [Qt] Use haveQtModule() in project files instead of manual checks
342
343         Reviewed by Jocelyn Turcotte.
344
345         * qmake/mkspecs/features/default_pre.prf:
346         * qmake/mkspecs/features/features.prf:
347
348 2012-07-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
349
350         [Qt] Fix haveQtModule() check
351
352         Without {} brackets we were pulling out the value of the module.name variable.
353
354         Reviewed by Jocelyn Turcotte.
355
356         * qmake/mkspecs/features/functions.prf:
357
358 2012-07-04  Sergio Villar Senin  <svillar@igalia.com>
359
360         [WK2] [GTK] WK2 testing bot unable to find the InjectedBundle library
361         https://bugs.webkit.org/show_bug.cgi?id=90541
362
363         Reviewed by Carlos Garcia Campos.
364
365         We must add the contents of WebKitBuild/*/Libraries/ directory to
366         the file to be uploaded to b.w.o to successfully run WebKit2 tests
367         in the WebKit2 testing bot.
368
369         * BuildSlaveSupport/built-product-archive:
370         (archiveBuiltProduct): appended Libraries to the list of
371         neededDirectories.
372
373 2012-07-04  Sergio Villar Senin  <svillar@igalia.com>
374
375         [GTK] WebKit2 testing bot unable to find the build directory
376         https://bugs.webkit.org/show_bug.cgi?id=90523
377
378         Reviewed by Carlos Garcia Campos.
379
380         The presence of GNUmakefile was used to determine whether a given
381         directory was a valid build directory or not. That's not correct for
382         testing bots as we export only the minimum required stuff to run the
383         tests.
384
385         * gtk/common.py:
386         (get_build_path.is_valid_build_directory): added an extra check.:
387
388 2012-07-04  Joe Thomas  <joethomas@motorola.com>
389
390         Adding myself to committers list.
391
392         Unreviewed.
393
394         * Scripts/webkitpy/common/config/committers.py:
395
396 2012-07-03  Christophe Dumez  <christophe.dumez@intel.com>
397
398         [WK2][EFL] Ewk_View should report the load progress
399         https://bugs.webkit.org/show_bug.cgi?id=90457
400
401         Reviewed by Kenneth Rohde Christiansen.
402
403         Update EFL MiniBrowser so that it listens for the
404         "load,progress" on the Ewk_View and updates its
405         window title accordingly.
406
407         * MiniBrowser/efl/main.c:
408         (title_set):
409         (on_title_changed):
410         (on_progress):
411         (browserCreate):
412
413 2012-07-03  Dirk Pranke  <dpranke@chromium.org>
414
415         disable failing mock-chromium-mac python unit tests
416
417         Unreviewed, build fix.
418
419         Disable these tests until I can figure out why they're failing
420         on the bots.
421
422         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
423         (PortTest.disabled_test_chromium_mac_lion):
424         (PortTest.disabled_test_chromium_mac_lion_in_test_shell_mode):
425
426 2012-07-03  Ian Vollick  <vollick@chromium.org>
427
428         Add vollick to the list of committers
429         https://bugs.webkit.org/show_bug.cgi?id=90512
430
431         Reviewed by Adrienne Walker.
432
433         * Scripts/webkitpy/common/config/committers.py:
434
435 2012-07-03  Ojan Vafai  <ojan@chromium.org>
436
437         Improve webkit-patch rebaseline to work for more cases
438         https://bugs.webkit.org/show_bug.cgi?id=90504
439
440         Reviewed by Dirk Pranke.
441
442         -Makes it work for the build.chromium.org bots.
443         -Lets you rebaseline all builders instead of just one.
444         -Lets you pass in the builder or test to rebaseline.
445
446         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
447         (Build.results_url):
448         Make this work for build.chromium.org builders as well.
449
450         * Scripts/webkitpy/common/net/buildbot/chromiumbuildbot.py:
451         (ChromiumBuilder):
452         (ChromiumBuilder.latest_cached_build):
453         ChromiumBuilder doesn't support large parts of the Builder interface.
454         This provides the bare minimum for this patch to work. Eventually,
455         we should create a single interface that can be supported for both
456         sets of buildbots.
457
458         * Scripts/webkitpy/layout_tests/port/builders.py:
459         (builder_path_from_name):
460         (all_builder_names):
461         memoizing here is incorrect because the test override _exact_matches,
462         so these can return different values. In either case, I'm pretty sure these
463         are not remotely hot codepaths.
464
465         * Scripts/webkitpy/tool/commands/rebaseline.py:
466         (AbstractParallelRebaselineCommand.__init__):
467         (Rebaseline):
468         (Rebaseline.__init__):
469         (Rebaseline._builders_to_pull_from):
470         (Rebaseline._builder_with_name):
471         (Rebaseline._tests_to_update):
472         (Rebaseline.execute):
473         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
474         (test_rebaseline.mock_builders_to_pull_from):
475         (test_rebaseline):
476         (test_rebaseline_command_line_flags):
477         (test_rebaseline_multiple_builders):
478         (test_rebaseline_multiple_builders.mock_builders_to_pull_from):
479         (test_rebaseline_multiple_builders.mock_tests_to_update):
480
481 2012-07-03  Christophe Dumez  <christophe.dumez@intel.com>
482
483         [EFL] Enable CSS variables support at compile time
484         https://bugs.webkit.org/show_bug.cgi?id=90448
485
486         Reviewed by Kenneth Rohde Christiansen.
487
488         Turn on CSS_VARIABLES flag by default on EFL port.
489
490         * Scripts/webkitperl/FeatureList.pm:
491
492 2012-07-03  Dirk Pranke  <dpranke@chromium.org>
493
494         nrwt: clean up exception handling and make sure we log some more failures
495         https://bugs.webkit.org/show_bug.cgi?id=90503
496
497         Reviewed by Ojan Vafai.
498
499         There were several places where exceptions weren't getting
500         logged, most notably if you passed a bad value to --platform.
501         This change tests that and cleans things up a bit; more cleanup
502         will be possible when we rework the manager_worker_broker code.
503
504         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
505         (_BrokerConnection.raise_exception):
506         (_InlineWorkerConnection.raise_exception):
507         * Scripts/webkitpy/layout_tests/controllers/worker.py:
508         (Worker.run):
509         (Worker.kill_driver):
510         * Scripts/webkitpy/layout_tests/port/factory.py:
511         (PortFactory.get):
512         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
513         (run):
514         (main):
515         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
516         (MainTest.test_unsupported_platfrom):
517
518 2012-07-03  Dirk Pranke  <dpranke@chromium.org>
519
520         nrwt: fix mock port
521         https://bugs.webkit.org/show_bug.cgi?id=90500
522
523         Reviewed by Ojan Vafai.
524
525         The MockDRT code was never updated when we switched the chromium
526         ports to using "drt mode" by default. This change updates that
527         code, fixes a typo in the chromium port that went undetected
528         (default_test_timeout_ms -> default_timeout_ms), and adds tests
529         that actually exercise some of the mock ports. These tests are
530         useful in that they will exercise the port-specific code in an
531         end-to-end-manner, but they are a bit slow for some reason (>1s
532         each) that I need to look into.
533
534         * Scripts/webkitpy/layout_tests/port/chromium.py:
535         (ChromiumDriver.stop):
536         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
537         (ChromiumAndroidPort.default_timeout_ms):
538         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
539         (TestChromiumAndroidPort.test_default_timeout_ms):
540         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
541         (main):
542         (parse_options):
543         (MockTestShell):
544         (MockTestShell.output_for_test):
545         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
546         (MockDRTTest.assertTest):
547         (MockTestShellTest):
548         (MockTestShellTest.make_drt):
549         (MockTestShellTest.test_test_shell_parse_options):
550         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
551         (PortTest):
552         (PortTest.assert_mock_port_works):
553         (PortTest.test_chromium_mac_lion):
554         (PortTest.test_chromium_mac_lion_in_test_shell_mode):
555         (PortTest.test_qt_linux):
556         (PortTest.test_mac_lion):
557
558 2012-07-03  Dirk Pranke  <dpranke@chromium.org>
559
560         nrwt: make the worker class stand alone with a cleaner interface
561         https://bugs.webkit.org/show_bug.cgi?id=90409
562
563         Reviewed by Ojan Vafai.
564
565         Currently the Worker class derives from AbstractWorker, which is
566         kind of crufty and awkward; it would be better if we did not
567         rely on shared state.
568
569         This change changes that so that Worker derives from object, and
570         exposes the following interface:
571           __init__() - called in the manager process
572           safe_init() - called in the worker process to initialize
573             unpicklable state
574           handle() - a single routine to handle all messages
575           cleanup() - called so the worker can clean up
576
577         Also, all of the "administrative" messages that are handled by
578         the worker (notification of start/stop/etc.) move into
579         manager_worker_broker - this reduces worker.py to just handling
580         the mechanics of actually running each test.
581
582         For the moment, we do this by creating Yet Another wrapper/proxy
583         class in manager_worker_broker, but this will get simpler
584         shortly when the rest of m_w_b is cleaned up.
585
586         With this change worker is now in its new form but there will be
587         a follow-on change that cleans up some names and other minor
588         things.
589
590         This change is again mostly just moving things around and should
591         be covered by the (updated) existing tests.
592
593         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
594         (get):
595         (AbstractWorker.__init__):
596         (AbstractWorker.run):
597         (AbstractWorker):
598         (AbstractWorker.handle_stop):
599         (AbstractWorker.handle_test_list):
600         (AbstractWorker.yield_to_broker):
601         (AbstractWorker.post_message):
602         (_WorkerConnection.__init__):
603         (_Process.run):
604         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
605         (_TestWorker):
606         (_TestWorker.__init__):
607         (_TestWorker.name):
608         (_TestWorker.cleanup):
609         (_TestWorker.handle):
610         (_TestWorker.safe_init):
611         (_TestWorker.stop):
612         (_TestsMixin.handle_finished_test):
613         (_TestsMixin.setUp):
614         (_TestsMixin.test_cancel):
615         (_TestsMixin.test_done):
616         * Scripts/webkitpy/layout_tests/controllers/worker.py:
617         (Worker):
618         (Worker.__init__):
619         (Worker.safe_init):
620         (Worker.handle):
621
622 2012-07-03  Dirk Pranke  <dpranke@chromium.org>
623
624         nrwt: moving child process logging code into manager_worker_broker
625         https://bugs.webkit.org/show_bug.cgi?id=90408
626
627         Reviewed by Ojan Vafai.
628
629         Users of manager_worker_broker should not have to be aware of
630         whether they're in the same process or different processes and
631         configure logging themselves; mwb should hide this complexity.
632         We can't quite do this completely/correctly yet, since the
633         manager expects to get a list of messages to log, but this
634         change fixes the worker side of it, at least.
635
636         This is just moving code around, there is no new functionality
637         and this should be covered by existing tests.
638
639         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
640         (AbstractWorker.__init__):
641         (_WorkerConnection.__init__):
642         (_WorkerConnection.post_message):
643         (_WorkerConnection):
644         (_WorkerConnection.set_up_logging):
645         (_WorkerConnection.clean_up_logging):
646         (_InlineWorkerConnection.run):
647         (_MultiProcessWorkerConnection.run):
648         (_WorkerLogHandler):
649         (_WorkerLogHandler.__init__):
650         (_WorkerLogHandler.emit):
651         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
652         (_TestWorker.run):
653         (_TestsMixin.handle_done):
654         * Scripts/webkitpy/layout_tests/controllers/worker.py:
655         (Worker.__init__):
656         (Worker.run):
657         (Worker._run_test):
658         (Worker.cleanup):
659         (Worker.run_single_test):
660
661 2012-07-03  Tony Chang  <tony@chromium.org>
662
663         [chromium] Don't archive build files generated by VS2010
664         https://bugs.webkit.org/show_bug.cgi?id=90493
665
666         Reviewed by Ojan Vafai.
667
668         In particular, the pch (pre compiled header) files are gigantic, making
669         release.zip almost a 1gb in size.
670
671         * BuildSlaveSupport/built-product-archive:
672         (archiveBuiltProduct):
673
674 2012-07-03  Tony Chang  <tony@chromium.org>
675
676         [chromium] Unreviewed, update .gitignore to handle VS2010 files.
677
678         * .gitignore:
679         * DumpRenderTree/DumpRenderTree.gyp/.gitignore:
680         * TestWebKitAPI/TestWebKitAPI.gyp/.gitignore:
681
682 2012-07-03  Ojan Vafai  <ojan@chromium.org>
683
684         Have webkit-patch rebaseline use rebaseline-test-internal
685         https://bugs.webkit.org/show_bug.cgi?id=90491
686
687         Reviewed by Dirk Pranke.
688
689         This lets it handle new files, reduces duplicate code and lays the
690         groundwork for making rebaseline have a richer interface.
691
692         * Scripts/webkitpy/common/net/buildbot/buildbot_mock.py:
693         (MockBuild):
694         (MockBuild.__init__):
695         (MockBuilder.build):
696         * Scripts/webkitpy/tool/commands/rebaseline.py:
697         (AbstractParallelRebaselineCommand._files_to_add):
698         (Rebaseline):
699         (Rebaseline._builder_to_pull_from):
700         (Rebaseline._tests_to_update):
701         (Rebaseline.execute):
702         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
703         (test_overrides_are_included_correctly):
704         (test_rebaseline):
705         (test_rebaseline.mock_builder_to_pull_from):
706         (test_rebaseline.mock_tests_to_update):
707
708 2012-07-03  Ojan Vafai  <ojan@chromium.org>
709
710         Rename rebaseline-test to rebaseline-test-internal
711         https://bugs.webkit.org/show_bug.cgi?id=90485
712
713         Reviewed by Adam Barth.
714
715         It's now only used by other rebaseline commands. It's still useful to leave it
716         as it's own command to aid in debugging when something goes wrong. In a followup
717         patch, I'll make webkit-patch rebaseline cover any use-cases that rebaseline-test
718         might have covered.
719
720         We no longer need the --print-scm-changes option since the only caller always passes
721         that option in.
722
723         Also, make all the arguments command-line flags instead. Simplifies the code
724         a bit in my opinion.
725
726         * Scripts/webkitpy/tool/commands/rebaseline.py:
727         (RebaselineTest):
728         (RebaselineTest.__init__):
729         (RebaselineTest.execute):
730         (AbstractParallelRebaselineCommand._rebaseline_commands):
731         (RebaselineExpectations.execute):
732         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
733         (test_rebaseline_all):
734
735 2012-07-03  Balazs Kelemen  <kbalazs@webkit.org>
736
737         [Qt][WTR] Get rid of using DumpRenderTreeSupportQt
738         https://bugs.webkit.org/show_bug.cgi?id=90262
739
740         Unreviewed build fix.
741
742         Reverting r121550 manually because it caused build
743         break on ARM and Mac. It turned out that the Qt build
744         system is too broken for this change now, first we have
745         to address two issues:
746             * symbol hiding was forbidden accidentally on x86 Linux
747             * Qt lacks a separate library for test support
748
749         * Tools.pro:
750         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
751         (WTR::InjectedBundlePage::resetAfterTest):
752         (WTR::InjectedBundlePage::didClearWindowForFrame):
753         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
754
755 2012-07-03  Tony Chang  <tony@chromium.org>
756
757         [chromium] Handle trailing backslash on %VSINSTALLDIR%
758         https://bugs.webkit.org/show_bug.cgi?id=90410
759
760         Reviewed by Ojan Vafai.
761
762         * Scripts/webkitdirs.pm:
763         (buildChromiumVisualStudioProject): Handle VSINSTALLDIR ending in a backslash, the backslash escapes the closing double quote.
764
765 2012-07-02  Ojan Vafai  <ojan@chromium.org>
766
767         Make the skia_test_expectations.txt file optional.
768         https://bugs.webkit.org/show_bug.cgi?id=90400
769
770         Reviewed by Dirk Pranke.
771
772         It used to be optional. This regressed at some point. It's important that it be
773         optional so that webkit-patch commands work in a pure-webkit checkout for chromium bots.
774         Specifically, this was breaking webkit-patch rebaseline-test when it would go to update
775         TestExpectations.
776
777         * Scripts/webkitpy/layout_tests/port/chromium.py:
778         (ChromiumPort.expectations_files):
779         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
780         (ChromiumDriverTest.test_expectations_dict):
781
782 2012-07-03  Raphael Kubo da Costa  <rakuco@webkit.org>
783
784         [jhbuild][EFL] Bump libffi dependency.
785         https://bugs.webkit.org/show_bug.cgi?id=85373
786
787         Reviewed by Gustavo Noronha Silva.
788
789         Update libffi to 3.0.11, which fixes the build on some platforms
790         where 3.0.10 had problems.
791
792         * efl/jhbuild.modules:
793
794 2012-07-03  George Staikos  <staikos@webkit.org>
795
796         [BlackBerry] Enable microdata support for BlackBerry.
797         https://bugs.webkit.org/show_bug.cgi?id=90429
798
799         Reviewed by Rob Buis.
800
801         * Scripts/webkitperl/FeatureList.pm:
802
803 2012-07-03  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
804
805         [Qt] Make use of .qmake.cache for caching features
806
807         Instead of loading() features from the files that need them (and re-running
808         a bunch of checks), we now run feature detection as part of configure.pro,
809         and have build-webkit write the computed feature-defines and CONFIG to
810         .qmake.cache, which is then loaded by qmake _before_ even defaults_pre
811         when building WebKit.pro.
812
813         At some point we'll be able to selectivly prevent running of config tests
814         in configure.pro, which means we don't need a separate code-path for
815         the build-webkit --help case.
816
817         We should also move the code in build-webkit that now uses .webkit.config
818         to detect clean builds, to use .qmake.cache, since we now store the same
819         thing there.
820
821         Original patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com>
822
823         Reviewed by Tor Arne Vestbø.
824
825         * DumpRenderTree/qt/DumpRenderTree.pro:
826         * QtTestBrowser/QtTestBrowser.pro:
827         * Scripts/webkitdirs.pm:
828         (qtFeatureDefaults):
829         (buildQMakeProjects):
830         * Tools.pro:
831         * WebKitTestRunner/InjectedBundle/DerivedSources.pri:
832         * WebKitTestRunner/InjectedBundle/Target.pri:
833         * WebKitTestRunner/Target.pri:
834         * qmake/.qmake.conf: Added.
835         * qmake/configure.pro:
836         * qmake/mkspecs/features/default_post.prf:
837         * qmake/mkspecs/features/default_pre.prf:
838         * qmake/mkspecs/features/features.prf:
839
840 2012-07-03  Nico Weber  <thakis@chromium.org>
841
842         -Wunused-private-field cleanup, linux edition
843         https://bugs.webkit.org/show_bug.cgi?id=90463
844
845         Reviewed by Stephen White.
846
847         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
848         * DumpRenderTree/chromium/GamepadController.h:
849         (GamepadController):
850         * DumpRenderTree/chromium/NotificationPresenter.h:
851         (NotificationPresenter::NotificationPresenter):
852         (NotificationPresenter):
853
854 2012-07-03  Sheriff Bot  <webkit.review.bot@gmail.com>
855
856         Unreviewed, rolling out r121766.
857         http://trac.webkit.org/changeset/121766
858         https://bugs.webkit.org/show_bug.cgi?id=90465
859
860         It caused flakey build errors on the bots (Requested by Ossy
861         on #webkit).
862
863         * DumpRenderTree/qt/DumpRenderTree.pro:
864         * QtTestBrowser/QtTestBrowser.pro:
865         * Scripts/webkitdirs.pm:
866         (qtFeatureDefaults):
867         (buildQMakeProjects):
868         * Tools.pro:
869         * WebKitTestRunner/InjectedBundle/DerivedSources.pri:
870         * WebKitTestRunner/InjectedBundle/Target.pri:
871         * WebKitTestRunner/Target.pri:
872         * qmake/.qmake.conf: Removed.
873         * qmake/configure.pro:
874         * qmake/mkspecs/features/default_post.prf:
875         * qmake/mkspecs/features/default_pre.prf:
876         * qmake/mkspecs/features/features.prf:
877
878 2012-07-03  George Staikos  <staikos@webkit.org>
879
880         [BlackBerry] Enable Custom Scheme Handlers for BlackBerry.
881         https://bugs.webkit.org/show_bug.cgi?id=90422
882
883         Reviewed by Rob Buis.
884
885         * Scripts/webkitperl/FeatureList.pm:
886
887 2012-07-03  George Staikos  <staikos@webkit.org>
888
889         [BlackBerry] Enable RegisterProtocolHandler for BlackBerry.
890         https://bugs.webkit.org/show_bug.cgi?id=90422
891
892         Reviewed by Rob Buis.
893
894         * Scripts/webkitperl/FeatureList.pm:
895
896 2012-07-03  Thiago Marcos P. Santos  <thiago.santos@intel.com>
897
898         [EFL] Add run API tests as a step on the build bots
899         https://bugs.webkit.org/show_bug.cgi?id=87252
900
901         Reviewed by Daniel Bates.
902
903         Run EFL API test suite on the build bots.
904
905         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
906         (RunEflAPITests):
907         (TestFactory.__init__):
908         (BuildAndTestFactory.__init__):
909         * Scripts/run-efl-tests: Added.
910
911 2012-07-03  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
912
913         [Qt] Make use of .qmake.cache for caching features
914
915         Instead of loading() features from the files that need them (and re-running
916         a bunch of checks), we now run feature detection as part of configure.pro,
917         and have build-webkit write the computed feature-defines and CONFIG to
918         .qmake.cache, which is then loaded by qmake _before_ even defaults_pre
919         when building WebKit.pro.
920
921         At some point we'll be able to selectivly prevent running of config tests
922         in configure.pro, which means we don't need a separate code-path for
923         the build-webkit --help case.
924
925         We should also move the code in build-webkit that now uses .webkit.config
926         to detect clean builds, to use .qmake.cache, since we now store the same
927         thing there.
928
929         Original patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com>
930
931         Reviewed by Tor Arne Vestbø.
932
933         * DumpRenderTree/qt/DumpRenderTree.pro:
934         * QtTestBrowser/QtTestBrowser.pro:
935         * Scripts/webkitdirs.pm:
936         (qtFeatureDefaults):
937         (buildQMakeProjects):
938         * Tools.pro:
939         * WebKitTestRunner/InjectedBundle/DerivedSources.pri:
940         * WebKitTestRunner/InjectedBundle/Target.pri:
941         * WebKitTestRunner/Target.pri:
942         * qmake/.qmake.conf: Added.
943         * qmake/configure.pro:
944         * qmake/mkspecs/features/default_post.prf:
945         * qmake/mkspecs/features/default_pre.prf:
946         * qmake/mkspecs/features/features.prf:
947
948 2012-07-03  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>  Joel Dillon <joel.dillon@codethink.co.uk>
949
950         [Qt][Win] Fix broken QtWebKit5.lib linking
951         https://bugs.webkit.org/show_bug.cgi?id=88321
952
953         Reviewed by Kenneth Rohde Christiansen.
954
955         On windows the import/export definition is part of the symbol's signature.
956         Define STATICALLY_LINKED_WITH_$$library for each dependend module
957         that is being linked statically to make sure that they can be linked together
958         later on.
959
960         Also do not compile Assertions.cpp in DumpRenderTree anymore since all the
961         used symbols are exported and it would cause a duplicate symbols error.
962
963         * DumpRenderTree/qt/DumpRenderTree.pro:
964         * qmake/mkspecs/features/default_post.prf:
965
966 2012-07-03  Szilard Ledan  <szledan@inf.u-szeged.hu>
967
968         master.cfg cleanup, pass BuildStep instances instead of BuildStep subclasses
969         https://bugs.webkit.org/show_bug.cgi?id=89001
970
971         Reviewed by Csaba Osztrogonác.
972
973         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
974         (UploadBuiltProduct.__init__):
975         (UploadTestResults.__init__):
976         (ExtractTestResults.__init__):
977         (Factory.__init__):
978         (BuildFactory.__init__):
979         (TestFactory.__init__):
980         (BuildAndTestFactory.__init__):
981         (BuildAndPerfTestFactory.__init__):
982         (BuildAndPerfTestWebKit2Factory.__init__):
983         (DownloadAndPerfTestFactory.__init__):
984
985 2012-07-03  Ádám Kallai  <kadam@inf.u-szeged.hu>
986
987         Update unit test after r121724.
988         https://bugs.webkit.org/show_bug.cgi?id=90444
989
990         Reviewed by Csaba Osztrogonác.
991
992         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
993         (GardeningServerTest.test_rebaseline_new_port):
994
995 2012-07-03  Sheriff Bot  <webkit.review.bot@gmail.com>
996
997         Unreviewed, rolling out r121749.
998         http://trac.webkit.org/changeset/121749
999         https://bugs.webkit.org/show_bug.cgi?id=90441
1000
1001         Tests crash on the paralel NRWT Qt bot (Requested by Ossy on
1002         #webkit).
1003
1004         * Scripts/webkitpy/layout_tests/port/qt.py:
1005         (QtPort._build_driver):
1006         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
1007         (XvfbDriver._start):
1008         (XvfbDriver._start.x_filter):
1009         (XvfbDriver.stop):
1010
1011 2012-07-03  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
1012
1013         [NRWT] XvfbDriver should choose the next free display
1014         https://bugs.webkit.org/show_bug.cgi?id=88414
1015
1016         Reviewed by Dirk Pranke.
1017
1018         * Scripts/webkitpy/layout_tests/port/qt.py:
1019         (QtPort._driver_class):
1020         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
1021         (XvfbDriver.__init__):
1022         (XvfbDriver._start):
1023         (XvfbDriver._start.next_free_id):
1024         (XvfbDriver.stop):
1025
1026 2012-07-03  Christophe Dumez  <christophe.dumez@intel.com>
1027
1028         [EFL] Enable MICRODATA support
1029         https://bugs.webkit.org/show_bug.cgi?id=90377
1030
1031         Reviewed by Kenneth Rohde Christiansen.
1032
1033         Turn on MICRODATA flag for EFL port by default.
1034
1035         * Scripts/webkitperl/FeatureList.pm:
1036
1037 2012-07-02  George Staikos  <staikos@webkit.org>
1038
1039         [BlackBerry] Enable scoped style for BlackBerry.
1040         https://bugs.webkit.org/show_bug.cgi?id=90418
1041
1042         Reviewed by Rob Buis.
1043
1044         * Scripts/webkitperl/FeatureList.pm:
1045
1046 2012-07-02  Xiaobo Wang  <xbwang@torchmobile.com.cn>
1047
1048         [BlackBerry] Use PUBLIC_BUILD to enable/disable DRT
1049         https://bugs.webkit.org/show_bug.cgi?id=90271
1050
1051         Reviewed by George Staikos.
1052
1053         RIM PR #154707
1054
1055         Currently DRT code will be compiled only if ENABLE_DRT is set, and it's not
1056         defined by default.
1057         We should enable DRT by default unless PUBLIC_BUILD is set. In this way we don't
1058         need to rebuild webkit before running DRT.
1059
1060         * Scripts/webkitdirs.pm:
1061         (blackberryCMakeArguments):
1062
1063 2012-07-02  Ojan Vafai  <ojan@chromium.org>
1064
1065         webkit-patch rebaseline-expectations should share code with rebaseline-all
1066         https://bugs.webkit.org/show_bug.cgi?id=90413
1067
1068         Reviewed by Dirk Pranke.
1069
1070         Make them share code. In addition to reducing code duplication this makes
1071         rebaseline-expectations considerably faster by rebaselining in parallel.
1072
1073         * Scripts/webkitpy/tool/commands/rebaseline.py:
1074         (AbstractParallelRebaselineCommand):
1075         (AbstractParallelRebaselineCommand._run_webkit_patch):
1076         (AbstractParallelRebaselineCommand._rebaseline):
1077         (RebaselineJson):
1078         (RebaselineJson.execute):
1079         (RebaselineExpectations):
1080         (RebaselineExpectations._update_expectations_file):
1081         (RebaselineExpectations._tests_to_rebaseline):
1082         (RebaselineExpectations._add_tests_to_rebaseline_for_port):
1083         (RebaselineExpectations.execute):
1084         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1085         (test_rebaseline_all):
1086         (test_rebaseline_expectations.run_in_parallel):
1087         (test_rebaseline_expectations):
1088
1089 2012-07-02  Xiaobo Wang  <xbwang@torchmobile.com.cn>
1090
1091         [BlackBerry] Update DumpRenderTree to have it work interactively in parallel
1092         https://bugs.webkit.org/show_bug.cgi?id=88326
1093
1094         Reviewed by Rob Buis.
1095
1096         1. Test name is sent to torch-launcher via PPS message(from host machine).
1097            So we get test list by monitoring and receiving PPS message instead of
1098            reading file index.drt.
1099         2. Torch-launcher create a <test file>.done file when it finished a test.
1100         3. We don't need to search for Ref-tests in DumpRenderTree.cpp any more. NRWT
1101            will get them for us.
1102
1103         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
1104         (BlackBerry::WebKit::DumpRenderTree::DumpRenderTree):
1105         (BlackBerry::WebKit::DumpRenderTree::doneDrt):
1106         (BlackBerry::WebKit::DumpRenderTree::runRemainingTests):
1107         (BlackBerry::WebKit::DumpRenderTree::ensurePPS):
1108         (WebKit):
1109         (BlackBerry::WebKit::DumpRenderTree::handlePPSData):
1110         (BlackBerry::WebKit::DumpRenderTree::waitForTest):
1111         (BlackBerry::WebKit::DumpRenderTree::runTests):
1112         (BlackBerry::WebKit::DumpRenderTree::dump):
1113         * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
1114         (DumpRenderTree):
1115
1116 2012-07-02  Adam Barth  <abarth@webkit.org>
1117
1118         Remove flashplugin-installer from the EWS image because it causes some tests to crash
1119         https://bugs.webkit.org/show_bug.cgi?id=90403
1120
1121         Reviewed by Tony Chang.
1122
1123         * EWSTools/cold-boot.sh:
1124
1125 2012-07-02  Leandro Gracia Gil  <leandrogracia@chromium.org>
1126
1127         [Chromium] Implement a Layout Test for editing/SurroundingText
1128         https://bugs.webkit.org/show_bug.cgi?id=82461
1129
1130         Reviewed by Ryosuke Niwa.
1131
1132         Add a new method to the layout test controller in order to retrieve the
1133         text surrounding a provided element.
1134
1135         * DumpRenderTree/chromium/LayoutTestController.cpp:
1136         (LayoutTestController::LayoutTestController):
1137         (LayoutTestController::textSurroundingElement):
1138         * DumpRenderTree/chromium/LayoutTestController.h:
1139         (LayoutTestController):
1140
1141 2012-07-02  Ojan Vafai  <ojan@chromium.org>
1142
1143         Delete unused rebaseline method in gardeningserver.py
1144         https://bugs.webkit.org/show_bug.cgi?id=90396
1145
1146         Reviewed by Eric Seidel.
1147
1148         As best I can tell, the only usage was in this unittest.
1149
1150         * Scripts/webkitpy/tool/servers/gardeningserver.py:
1151         (GardeningHTTPRequestHandler.updateexpectations):
1152         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
1153         (GardeningServerTest.test_rebaseline_new_port):
1154
1155 2012-07-02  Csaba Osztrogonác  <ossy@webkit.org>
1156
1157         REGRESSION(r121497): It switched off and broke many unittests
1158         https://bugs.webkit.org/show_bug.cgi?id=90371
1159
1160         Reviewed by Adam Barth.
1161
1162         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
1163         (ChromiumMacPortTest): Use snowleopard as os_version instead of leopard, because it isn't supported anymore.
1164         * Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py:
1165         (ChromiumPortTestCase.test_all_test_configurations): Remove leopard testcases, because it isn't supported anymore.
1166         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1167         (PortTestCase): Inherit class PortTestCase from unittest.TestCase instead of object.
1168
1169 2012-07-02  Ojan Vafai  <ojan@chromium.org>
1170
1171         Move rebaseline-all command from the gardening-server down into webkit-patch
1172         https://bugs.webkit.org/show_bug.cgi?id=90395
1173
1174         Reviewed by Adam Barth.
1175
1176         This is just moving code. It it in preparation for making rebaseline-expectations
1177         use the same code in order to get the parallelism benefits and reduces the amount
1178         of code we have for doing rebaselines.
1179
1180         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
1181         (CheckoutTest.test_apply_patch):
1182         Updated due to the change to executive_mock.
1183         * Scripts/webkitpy/common/system/executive_mock.py:
1184         (MockExecutive.run_command):
1185         Update to print out the input passed to stdin.
1186         * Scripts/webkitpy/tool/commands/download_unittest.py:
1187         Updated due to executive_mock change.
1188         * Scripts/webkitpy/tool/commands/rebaseline.py:
1189         (RebaselineAll):
1190         (RebaselineAll._run_webkit_patch):
1191         (RebaselineAll._builders_to_fetch_from):
1192         (RebaselineAll._rebaseline_commands):
1193         (RebaselineAll._files_to_add):
1194         (RebaselineAll._optimize_baselines):
1195         (RebaselineAll._rebaseline):
1196         (RebaselineAll.execute):
1197         All this code is just copy-pasted except for mechanical changes
1198         (e.g. self.server.tool --> self._tool) and the reading in of the 
1199         JSON from stdin instead of the post body.
1200         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1201         (test_rebaseline_all):
1202         Copied the test-case out of gardeningserver_unittest.py.
1203         * Scripts/webkitpy/tool/servers/gardeningserver.py:
1204         (GardeningHTTPRequestHandler):
1205         (GardeningHTTPRequestHandler.rebaseline):
1206         (GardeningHTTPRequestHandler.rebaselineall):
1207         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
1208         (GardeningServerTest.test_rebaselineall):
1209         (GardeningServerTest.test_rebaselineall.run_command):
1210
1211 2012-07-02  Ojan Vafai  <ojan@chromium.org>
1212
1213         Remove Leopard support from the flakiness dashboard
1214         https://bugs.webkit.org/show_bug.cgi?id=90390
1215
1216         Reviewed by Adam Barth.
1217
1218         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1219         (nonChromiumPlatform):
1220         (chromiumPlatform):
1221         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1222         (test):
1223         * TestResultServer/static-dashboards/run-embedded-unittests.html:
1224         * TestResultServer/static-dashboards/run-unittests.html:
1225
1226 2012-07-02  Ojan Vafai  <ojan@chromium.org>
1227
1228         Fix posting from garden-o-matic. This broke in moving away from jquery's ajax method
1229         in http://trac.webkit.org/changeset/121617.
1230         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/net.js:
1231
1232 2012-07-02  Carlos Garcia Campos  <cgarcia@igalia.com>
1233
1234         [GTK] Read fonts path when running layout tests from alternative fonts dir when main dir doesn't exist
1235         https://bugs.webkit.org/show_bug.cgi?id=89437
1236
1237         Reviewed by Martin Robinson.
1238
1239         If main fonts directory doesn't exist, try with an alternative
1240         fonts directory at build directory.
1241
1242         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1243         (getOutputDir):
1244         (getFontsPath):
1245         (initializeFonts):
1246         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
1247         (WTR::getOutputDir):
1248         (WTR):
1249         (WTR::getFontsPath):
1250         (WTR::inititializeFontConfigSetting):
1251
1252 2012-07-02  Carlos Garcia Campos  <cgarcia@igalia.com>
1253
1254         [GTK] Don't run the tests with jhbuild wrapper if it's already running under jhbuild
1255         https://bugs.webkit.org/show_bug.cgi?id=89435
1256
1257         Reviewed by Martin Robinson.
1258
1259         * Scripts/new-run-webkit-tests: Don't run the tests with the
1260         jhbuild wrapper if there isn't a Dependencies directory inside the
1261         build directory.
1262
1263 2012-06-29  Oswald Buddenhagen  <oswald.buddenhagen@nokia.com>
1264
1265         [Qt] Simplify detection of non-installed module file
1266
1267         Has the additional advantage that we do not rely on additional information.
1268
1269         Reviewed by Tor Arne Vestbø.
1270
1271         * qmake/qt_webkit.pri:
1272
1273 2012-07-01  Christophe Dumez  <christophe.dumez@intel.com>
1274
1275         [EFL] Add Gamepad support
1276         https://bugs.webkit.org/show_bug.cgi?id=90170
1277
1278         Reviewed by Kenneth Rohde Christiansen.
1279
1280         * Scripts/webkitperl/FeatureList.pm: Turn on GAMEPAD flag
1281         by default for EFL port.
1282         * efl/jhbuild.modules: Bump dependency versions of EFL libs
1283         since the latest Eeze is required for gamepad support.
1284
1285 2012-07-01  Adam Barth  <abarth@webkit.org>
1286
1287         Unreviewed.
1288
1289         Using the default start cylinder for fdisk causes a warning about the
1290         partition not starting on physical sector boundary.  The Ubuntu forums
1291         recommend using a number that's divisible by 8, which is what we do in
1292         this patch.
1293
1294         * EWSTools/cold-boot.sh:
1295
1296 2012-07-01  Adam Barth  <abarth@webkit.org>
1297
1298         Unreviewed.
1299
1300         It turns out we need to use Ubuntu 10.04 to get the right image results
1301         for chromium-linux. This patch updates our scripts to be compatible
1302         with Ubuntu 10.04.
1303
1304         * EWSTools/cold-boot.sh:
1305             - fdisk doesn't have p and 1 as default commands in 10.04.
1306         * EWSTools/start-queue.sh:
1307             - git doesn't understanding the -B argument in 10.04. We've been
1308               using this change locally on the EC2 bots for a while.
1309
1310 2012-07-01  Adam Barth  <abarth@webkit.org>
1311
1312         Unreviewed.
1313
1314         * EWSTools/boot.sh:
1315             - We need to start the screen in detached mode so that we can run
1316               it remotely via ssh.
1317
1318 2012-07-01  Adam Barth  <abarth@webkit.org>
1319
1320         Unreviewed.
1321
1322         * EWSTools/cold-boot.sh:
1323             - Turns out we need to sudo this command in order for it to
1324               actually dimiss the EULA screen. :)
1325
1326 2012-06-29  Adam Barth  <abarth@webkit.org>
1327
1328         Turns out we need zip too.
1329
1330         * EWSTools/cold-boot.sh:
1331
1332 2012-06-29  Adam Barth  <abarth@webkit.org>
1333
1334         Add a cold-boot.sh script for the EWS
1335         https://bugs.webkit.org/show_bug.cgi?id=90330
1336
1337         Unreviewed.
1338
1339         * EWSTools/cold-boot.sh: Added.
1340             - This script can take us from a cold GCE instance to a running EWS
1341               bot in one fell swoop.
1342         * EWSTools/start-queue.sh:
1343             - The if-block at the top of this script was causing trouble. I
1344               removed it from the bots a while ago. Now that we're using SVN to
1345               cold-boot the EWS bots, we need to make this change in the repo.
1346
1347 2012-06-29  Luiz Agostini  <luiz.agostini@nokia.com>
1348
1349         [Qt][WK2] Private non-QtQuick API
1350         https://bugs.webkit.org/show_bug.cgi?id=84532
1351
1352         MiniBrowserRaw is an usage example for the QRawWebView API.
1353         It is only an example and is not fully implemented.
1354
1355         Reviewed by Noam Rosenthal.
1356
1357         * MiniBrowser/qt/raw/DerivedSources.pri: Added.
1358         * MiniBrowser/qt/raw/MiniBrowserRaw.pro: Added.
1359         * MiniBrowser/qt/raw/Target.pri: Added.
1360         * MiniBrowser/qt/raw/View.cpp: Added.
1361         * MiniBrowser/qt/raw/View.h: Added.
1362         * Scripts/webkitpy/style/checker.py:
1363         * Tools.pro:
1364
1365 2012-06-29  Ojan Vafai  <ojan@chromium.org>
1366
1367         Remove leopard bots from garden-o-matic
1368         https://bugs.webkit.org/show_bug.cgi?id=90328
1369
1370         Reviewed by Adam Barth.
1371
1372         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
1373         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
1374         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
1375
1376 2012-06-29  Ojan Vafai  <ojan@chromium.org>
1377
1378         garden-o-matic broken: TypeError: 'undefined' is not an object (evaluating 'buildLocations[currentIndex].url')
1379         https://bugs.webkit.org/show_bug.cgi?id=90243
1380
1381         Reviewed by Dirk Pranke.
1382
1383         jQuery was trying to be too smart and parsing the jsonp as json because of it's content-type.
1384         Excise jQuery and just use XHR directly since it's easier to maintain something where we control it
1385         all.
1386
1387         Not really sure how to unittest this. I tested it all manually of course.
1388
1389         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/net.js:
1390         Made net.ajax a drop-in replacement for the features of $.ajax that we were using.
1391         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
1392         Not related to this patch, but figured I'd update the failing test while I was at it.
1393
1394 2012-06-29  Yaron Friedman  <yfriedman@chromium.org>
1395
1396         Fix layout test runner for Android after https://bugs.webkit.org/show_bug.cgi?id=88134
1397         https://bugs.webkit.org/show_bug.cgi?id=90309
1398
1399         Reviewed by Adam Barth.
1400
1401         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1402         (ChromiumAndroidPort.start_http_server):
1403
1404 2012-06-29  James Weatherall  <wez@chromium.org>
1405
1406         NPObjectWrapper may not address all window script object lifetime issues
1407         https://bugs.webkit.org/show_bug.cgi?id=85679
1408
1409         TestNetscapePlugin now has a leak-window-scriptable-object test which takes a reference to the window script object, and a second reference to it via the "self" property, and does not release those references. This is used to simulate a leaky plugin in layout tests of the NPAPI scripting interface glue code.
1410
1411         Reviewed by Nate Chapin.
1412
1413         * DumpRenderTree/DumpRenderTree.gypi:
1414         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
1415         (PluginTest::NPN_GetProperty):
1416         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
1417         (PluginTest):
1418         * DumpRenderTree/TestNetscapePlugIn/Tests/LeakWindowScriptableObject.cpp: Added.
1419         (LeakWindowScriptableObject):
1420         (LeakWindowScriptableObject::LeakWindowScriptableObject):
1421         (LeakWindowScriptableObject::NPP_New):
1422
1423 2012-06-29  Dirk Pranke  <dpranke@chromium.org>
1424
1425         webkitpy: add comment about how determine_full_port_name() works for apple ports, fix -wk2 bug
1426         https://bugs.webkit.org/show_bug.cgi?id=90314
1427
1428         Reviewed by Ojan Vafai.
1429
1430         Add comments and fix a bug in how we would handle the mac-wk2
1431         and win-wk2 port names after confusion around in bug 90312 :).
1432
1433         * Scripts/webkitpy/layout_tests/port/apple.py:
1434         (ApplePort.determine_full_port_name):
1435
1436 2012-06-29  Dirk Pranke  <dpranke@chromium.org>
1437
1438         webkitpy: remove support for mac leopard from chromium configurations
1439         https://bugs.webkit.org/show_bug.cgi?id=90313
1440
1441         Reviewed by Tony Chang.
1442
1443         Google has shipped the last version of Chrome that will support
1444         Mac OS 10.5 (Leopard), and we no longer have bots that run this
1445         configuration, so we're removing support for it.
1446
1447         A subsequent change will remove the baselines in platform/chromium-mac-leopard.
1448
1449         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
1450         (BaselineOptimizerTest.test_complex_shadowing):
1451         * Scripts/webkitpy/layout_tests/port/builders.py:
1452         * Scripts/webkitpy/layout_tests/port/chromium.py:
1453         (ChromiumPort):
1454         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1455         (ChromiumMacPort):
1456         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
1457         (ChromiumMacPortTest.test_versions):
1458         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
1459         (FactoryTest.test_mac):
1460         (FactoryTest.test_chromium_mac):
1461         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1462         (test_rebaseline_and_copy_test_with_lion_result):
1463
1464 2012-06-29  Ojan Vafai  <ojan@chromium.org>
1465
1466         Fix optimize-baselines to not move baselines from win to win-7sp0
1467         https://bugs.webkit.org/show_bug.cgi?id=90312
1468
1469         Reviewed by Dirk Pranke.
1470
1471         It used to consider win-7sp0 as the common directory for all the Apple
1472         windows ports and incorrectly move results out of win.
1473
1474         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
1475         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
1476         (BaselineOptimizerTest.test_win_does_not_drop_to_win_7sp0):
1477         (BaselineOptimizerTest.test_common_directory_includes_root):
1478
1479 2012-06-28  Ojan Vafai  <ojan@chromium.org>
1480
1481         Fix rebaselining for Qt and Apple ports
1482         https://bugs.webkit.org/show_bug.cgi?id=90204
1483
1484         Reviewed by Dirk Pranke.
1485
1486         -Apporpriately put wk2 results in the -wk2 directories.
1487         -Since Qt and Apple-Win don't have bots that correspond to the
1488         platform/qt and platform/win directories, we need to fudge it
1489         and always put the results in those directories for those ports.
1490
1491         * Scripts/webkitpy/layout_tests/port/builders.py:
1492         (rebaseline_override_dir):
1493         * Scripts/webkitpy/layout_tests/port/factory.py:
1494         (_builder_options):
1495         Identify webkit2 builders by the WK2 in the builder name.
1496         * Scripts/webkitpy/tool/commands/rebaseline.py:
1497         (RebaselineTest._baseline_directory):
1498         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1499         (TestRebaseline.test_baseline_directory):
1500
1501 2012-06-29  Zoltan Horvath  <zoltan@webkit.org>
1502
1503         Add support for --force parameter to run-performance-tests
1504         https://bugs.webkit.org/show_bug.cgi?id=90279
1505
1506         Reviewed by Dirk Pranke.
1507
1508         It's helpful to be able to run tests from the Skipped list of the performance tests.
1509
1510         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1511         (PerfTestsRunner._parse_args):
1512         (PerfTestsRunner._collect_tests):
1513         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py: Add test.
1514         (test_collect_tests_with_skipped_list):
1515
1516 2012-06-29  Tony Chang  <tony@chromium.org>
1517
1518         [GTK] Enable CSS grid layout LayoutTests on GTK+
1519         https://bugs.webkit.org/show_bug.cgi?id=90226
1520
1521         Reviewed by Martin Robinson.
1522
1523         This feature is disabled via Settings by default, but for testing,
1524         we enable it using layoutTestController.overridePreferences. Add the
1525         necessary plumbing for DRT.
1526
1527         WTR already works because support was added for Apple Mac earlier.
1528
1529         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1530         (resetDefaultsToConsistentValues): Feature is off by default.
1531         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1532         (LayoutTestController::overridePreference): Add handling of WebKitCSSGridLayoutEnabled.
1533
1534 2012-06-29  Ádám Kallai  <kadam@inf.u-szeged.hu>
1535
1536         [Qt] Added Qt port for garden-o-matic.
1537         https://bugs.webkit.org/show_bug.cgi?id=82719
1538
1539         Reviewed by Adam Barth.
1540
1541         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
1542         (.):
1543
1544 2012-06-29  Balazs Kelemen  <kbalazs@webkit.org>
1545
1546         [Qt][WTR] Get rid of using DumpRenderTreeSupportQt
1547         https://bugs.webkit.org/show_bug.cgi?id=90262
1548
1549         Reviewed by Alexey Proskuryakov.
1550
1551         Now that we decided to not support v8 in WebKit2
1552         we can get rid of using DumpRenderTreeSupportQt
1553         in WebKitTestRunner.
1554
1555         * Tools.pro:
1556         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1557         (WTR::InjectedBundlePage::resetAfterTest):
1558         (WTR::InjectedBundlePage::didClearWindowForFrame):
1559         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
1560
1561 2012-06-29  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1562
1563         Revert r121540, it broke most Qt builds
1564
1565         * qmake/mkspecs/features/default_post.prf:
1566         * qmake/mkspecs/features/functions.prf:
1567
1568 2012-06-29  Oswald Buddenhagen  <oswald.buddenhagen@nokia.com>
1569
1570         [Qt] Make build-webkit reject uknown configurations, eg. --profile
1571
1572         The qmake-based buildsystem doesn't support it.
1573
1574         Reviewed by Tor Arne Vestbø.
1575
1576         * Scripts/webkitdirs.pm:
1577         (buildQMakeProjects):
1578
1579 2012-06-29  Oswald Buddenhagen  <oswald.buddenhagen@nokia.com>
1580
1581         [Qt] Don't add Qt module dependencies in features.prf
1582
1583         The required dependencies are already added in WebCore.pri.
1584
1585         Reviewed by Tor Arne Vestbø.
1586
1587         * qmake/mkspecs/features/features.prf:
1588
1589 2012-06-27  Oswald Buddenhagen  <oswald.buddenhagen@nokia.com>
1590
1591         [Qt] Use LIBS_PRIVATE instead of putting dependencies into LIBS
1592
1593         Reviewed by Tor Arne Vestbø..
1594
1595         * qmake/mkspecs/features/default_post.prf:
1596         * qmake/mkspecs/features/functions.prf:
1597
1598 2012-06-28  Ryosuke Niwa  <rniwa@webkit.org>
1599
1600         DOMHTMLCollection::item may return a wrong element after namedItem is called
1601         https://bugs.webkit.org/show_bug.cgi?id=90240
1602
1603         Reviewed by Antti Koivisto.
1604
1605         Add a WebKit API test since namedItem is not used in the JS/V8 binding code.
1606
1607         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1608         * TestWebKitAPI/Tests/mac/HTMLCollectionNamedItem.html: Copied from Tools/TestWebKitAPI/Tests/mac/HTMLFormCollectionNamedItem.html.
1609         * TestWebKitAPI/Tests/mac/HTMLCollectionNamedItem.mm: Copied from Tools/TestWebKitAPI/Tests/mac/HTMLFormCollectionNamedItem.mm.
1610         (TestWebKitAPI::TEST):
1611
1612 2012-06-28  Dirk Pranke  <dpranke@chromium.org>
1613
1614         nrwt: remove the 'google-chrome' port code
1615         https://bugs.webkit.org/show_bug.cgi?id=88824
1616
1617         Reviewed by Ojan Vafai.
1618
1619         NRWT now supports passing additional baseline directories
1620         and expectations files on the command line, so there's no need
1621         to support the concept of a 'google-chrome' port directly.
1622
1623         * Scripts/webkitpy/layout_tests/port/base.py:
1624         (Port.path_to_test_expectations_file):
1625         * Scripts/webkitpy/layout_tests/port/builders.py:
1626         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1627         (ChromiumMacPort.__init__):
1628         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1629         (ChromiumWinPort.__init__):
1630         * Scripts/webkitpy/layout_tests/port/factory.py:
1631         (PortFactory):
1632         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
1633         (FactoryTest.test_win):
1634         * Scripts/webkitpy/layout_tests/port/google_chrome.py: Removed.
1635         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py: Removed.
1636
1637 2012-06-28  Dirk Pranke  <dpranke@chromium.org>
1638
1639         nrwt: clean up how arguments are passed to workers
1640         https://bugs.webkit.org/show_bug.cgi?id=90126
1641
1642         Reviewed by Ojan Vafai.
1643
1644         The way arguments are passed to workers has been crufty. It
1645         turns out it can be a lot cleaner via two things:
1646         1) using a factory method instead of instantiating objects
1647         directly in manager_worker_broker removes the need for passing
1648         'worker arguments' to the broker.
1649         2) it turns out that since mock hosts and test ports are purely
1650         in-memory constructions, they can be pickled and passed to child
1651         workers, meaning that the worker no longer needs hacky code to
1652         pass the port in a special case or to guess what to do if we
1653         don't have a host - all of the test-specific logic can move to
1654         the test file, where we can stub out the mock host's
1655         port_factory to return the same already-created port when it
1656         needs to be shared.
1657
1658         This change also moves WorkerException to manager_worker_broker.py
1659         where it belongs, and removes several useless tests that were
1660         just a maintenance burden (and would've needed rewriting when we
1661         change the rest of the broker implementation).
1662
1663         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1664         (Manager._run_tests.worker_factory):
1665         (Manager._run_tests):
1666         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
1667         (get):
1668         (WorkerException):
1669         (AbstractWorker.__init__):
1670         (_ManagerConnection.__init__):
1671         (_ManagerConnection.start_worker):
1672         (_InlineManager.__init__):
1673         (_InlineManager.start_worker):
1674         (_MultiProcessManager._can_pickle_host):
1675         (_MultiProcessManager):
1676         (_MultiProcessManager.start_worker):
1677         (_WorkerConnection.__init__):
1678         (_InlineWorkerConnection.__init__):
1679         (_InlineWorkerConnection.join):
1680         (_InlineWorkerConnection.run):
1681         (_Process.run):
1682         (_MultiProcessWorkerConnection.__init__):
1683         (_MultiProcessWorkerConnection.start):
1684         (_MultiProcessWorkerConnection):
1685         (_MultiProcessWorkerConnection.run):
1686         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
1687         (_TestWorker.__init__):
1688         (_TestWorker.run):
1689         (_TestsMixin.test_name):
1690         (_TestsMixin.test_cancel):
1691         (_TestsMixin.test_done):
1692         (_TestsMixin.test_unknown_message):
1693         (InlineBrokerTests.setUp):
1694         (MultiProcessBrokerTests.setUp):
1695         * Scripts/webkitpy/layout_tests/controllers/worker.py:
1696         (Worker.__init__):
1697         (Worker.run):
1698         * Scripts/webkitpy/layout_tests/controllers/worker_unittest.py: Removed.
1699         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1700         (passing_run):
1701         (logging_run):
1702         (run_and_capture):
1703         (MainTest.test_child_processes_2):
1704         (MainTest.test_child_processes_min):
1705         (MainTest.test_exception_raised):
1706         (MainTest.test_keyboard_interrupt):
1707         (MainTest.test_retrying_and_flaky_tests):
1708         (MainTest.test_run_order__inline):
1709
1710 2012-06-28  Dirk Pranke  <dpranke@chromium.org>
1711
1712         nrwt: don't try to catch worker exceptions in run_webkit_tests.__main__
1713         https://bugs.webkit.org/show_bug.cgi?id=90125
1714
1715         Reviewed by Ojan Vafai.
1716
1717         It turns out run_webkit_tests.py wasn't really using
1718         WorkerException and the catch we had for it was pointless. I've
1719         removed the symbol import and moved it to the integration tests
1720         where it is needed. Eventually the definition of the exception
1721         moves to the broker module, and so minimizing the number of
1722         users of it is a good thing.
1723
1724         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1725         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1726         (MainTest.test_exception_raised):
1727
1728 2012-06-28  Dirk Pranke  <dpranke@chromium.org>
1729
1730         nrwt: clean up passing of log messages between processes
1731         https://bugs.webkit.org/show_bug.cgi?id=90123
1732
1733         Reviewed by Ojan Vafai.
1734
1735         It turns out log messages are perfectly picklable by themselves
1736         and contain the process id of the process that generated the
1737         message, so if we just pass the record from the worker to the
1738         manager and call logger.handle() in the manager, everything just
1739         works :).
1740
1741         The change is covered by existing tests.
1742
1743         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1744         (Manager._log_messages):
1745         * Scripts/webkitpy/layout_tests/controllers/worker.py:
1746         (_WorkerLogHandler.emit):
1747         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
1748         (MeteredStream.__init__):
1749         (_LogHandler.emit):
1750
1751 2012-06-28  Dirk Pranke  <dpranke@chromium.org>
1752
1753         add a pylint wrapper for linting python code
1754         https://bugs.webkit.org/show_bug.cgi?id=90232
1755
1756         Reviewed by Adam Barth.
1757
1758         Currently we use 'pep8' to check python code in
1759         check-webkit-style. pep8 is fast but simple; pylint is slower
1760         but has much more robust linting capabilities and will catch
1761         variable typos and all sorts of other things. Eventually we
1762         should switch check-webkit-style to use this, but our code is
1763         far from linting now so it needs to be cleaned up first.
1764
1765         This change adds the infrastructure and a wrapper so we can
1766         start doing that.
1767
1768         * Scripts/lint-webkitpy: Added.
1769         * Scripts/webkitpy/pylintrc: Added.
1770         * Scripts/webkitpy/thirdparty/__init__.py:
1771         (AutoinstallImportHook.find_module):
1772         (AutoinstallImportHook._install_pylint):
1773
1774 2012-06-28  Tony Chang  <tony@chromium.org>
1775
1776         [GTK] Use WEBKITOUTPUTDIR to find fonts in DumpRenderTree
1777         https://bugs.webkit.org/show_bug.cgi?id=90215
1778
1779         Reviewed by Martin Robinson.
1780
1781         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1782         (initializeFonts): Check for WEBKITOUTPUTDIR first.
1783         * Scripts/webkitpy/layout_tests/port/gtk.py:
1784         (GtkPort.setup_environ_for_server): Copy the environment variable to the child process.
1785         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
1786         (WTR::inititializeFontConfigSetting): Check for WEBKITOUTPUTDIR first.
1787
1788 2012-06-28  Dirk Pranke  <dpranke@chromium.org>
1789
1790         derive ChromiumPort from WebKitPort in NRWT in order to support skipping tests if symbols are missing
1791         https://bugs.webkit.org/show_bug.cgi?id=89706
1792
1793         Reviewed by Ojan Vafai.
1794
1795         Try again to land the change first landed in r121363. This patch
1796         adds a bunch more tests and reworks the handling of
1797         port-specific default values for --pixel-tests and --time-out-ms
1798         to be more consistent (adding a default_pixel_tests() method,
1799         pushing the webkit default_timeout_ms() value up into base.py,
1800         and overriding it properly in the chromium and apple mac ports.
1801
1802         Also change the logic in
1803         run_webkit_tests._setup_derived_options() to not second-guess
1804         what the port wants the timeout value to be for debug builds;
1805         computing this in two different places led to several bugs.
1806
1807         This change also changes the Chromium unittest ports to derive
1808         from ChromiumPortTestCase instead of PortTestCase, so that we
1809         ensure that we're running the same tests on all port variants
1810         more easily. There's more cleanup that can be done here, but
1811         this is good enough for now
1812
1813         * Scripts/webkitpy/layout_tests/port/base.py:
1814         (Port.default_pixel_tests):
1815         (Port):
1816         (Port.default_timeout_ms):
1817         * Scripts/webkitpy/layout_tests/port/chromium.py:
1818         (ChromiumPort):
1819         (ChromiumPort.__init__):
1820         (ChromiumPort.default_pixel_tests):
1821         (ChromiumPort.default_timeout_ms):
1822         (ChromiumPort.driver_name):
1823         (ChromiumPort._driver_class):
1824         (ChromiumPort._missing_symbol_to_skipped_tests):
1825         (ChromiumPort.skipped_layout_tests):
1826         (ChromiumPort.setup_test_run):
1827         (ChromiumPort._path_to_image_diff):
1828         (ChromiumPort._convert_path):
1829         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
1830         (ChromiumAndroidPortTest):
1831         (ChromiumAndroidPortTest.test_expectations_files):
1832         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1833         (ChromiumLinuxPort._modules_to_search_for_symbols):
1834         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
1835         (ChromiumLinuxPortTest):
1836         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1837         (ChromiumMacPort._modules_to_search_for_symbols):
1838         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
1839         (ChromiumMacPortTest):
1840         * Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py:
1841         split off from chromium_unittest.
1842         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1843         (ChromiumWinPort._modules_to_search_for_symbols):
1844         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
1845         (ChromiumWinTest):
1846         * Scripts/webkitpy/layout_tests/port/mac.py:
1847         (MacPort.default_timeout_ms):
1848         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1849         (MacTest.test_default_timeout_ms):
1850         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
1851         (MockDRTPort.start_http_server):
1852         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1853         (PortTestCase.test_default_timeout_ms):
1854         (PortTestCase):
1855         (PortTestCase.test_default_pixel_tests):
1856         * Scripts/webkitpy/layout_tests/port/test.py:
1857         (TestPort.default_pixel_tests):
1858         * Scripts/webkitpy/layout_tests/port/webkit.py:
1859         (WebKitPort._modules_to_search_for_symbols):
1860         (WebKitPort):
1861         (WebKitPort._symbols_string):
1862         (WebKitPort._skipped_tests_for_unsupported_features):
1863         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1864         (TestWebKitPort._symbols_string):
1865         (TestWebKitPort._tests_for_disabled_features):
1866         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1867         (_set_up_derived_options):
1868
1869 2012-06-28  Joshua Bell  <jsbell@chromium.org>
1870
1871         run-bindings-tests should return non-zero exit code on test failure
1872         https://bugs.webkit.org/show_bug.cgi?id=90205
1873
1874         Reviewed by Adam Barth.
1875
1876         * Scripts/run-bindings-tests:
1877         (main):
1878
1879 2012-06-28  Terry Anderson  <tdanderson@chromium.org>
1880
1881         [chromium] Reset the device scale factor to 1 before each test is run
1882         https://bugs.webkit.org/show_bug.cgi?id=90212
1883
1884         Reviewed by Adam Barth.
1885
1886         Some tests change the device scale factor, so this needs to be reset to
1887         1.0 at the start of each test to avoid test flakiness.
1888
1889         * DumpRenderTree/chromium/LayoutTestController.cpp:
1890         (LayoutTestController::reset):
1891
1892 2012-06-28  Ryosuke Niwa  <rniwa@webkit.org>
1893
1894         Cleanup HTMLFormCollection
1895         https://bugs.webkit.org/show_bug.cgi?id=90111
1896
1897         Reviewed by Andreas Kling.
1898
1899         Add a WebKit API test using copy-paste design pattern per kling's request.
1900
1901         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1902         * TestWebKitAPI/Tests/mac/HTMLFormCollectionNamedItem.html: Added.
1903         * TestWebKitAPI/Tests/mac/HTMLFormCollectionNamedItem.mm: Added.
1904         (-[HTMLFormCollectionNamedItemTest webView:didFinishLoadForFrame:]):
1905         (TestWebKitAPI):
1906         (TestWebKitAPI::TEST):
1907
1908 2012-06-28  Tim Horton  <timothy_horton@apple.com>
1909
1910         [mac] WKTR windows still don't stay off screen sometimes
1911         https://bugs.webkit.org/show_bug.cgi?id=90214
1912         <rdar://problem/11760263>
1913
1914         Reviewed by Simon Fraser.
1915
1916         In some cases, the system itself will consult [WebKitTestRunnerWindow frame], so we should refrain from
1917         overriding it and instead provide a different method to use when we want the web-facing "fake" window origin
1918         (for PlatformWebView::windowFrame()).
1919
1920         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1921         (-[WebKitTestRunnerWindow frameRespectingFakeOrigin]):
1922         (WTR::PlatformWebView::windowFrame):
1923
1924 2012-06-28  Martin Robinson  <mrobinson@igalia.com>
1925
1926         [GTK] Add unit tests for GtkInputMethodFilter
1927         https://bugs.webkit.org/show_bug.cgi?id=88698
1928
1929         Reviewed by Carlos Garcia Campos.
1930
1931         Add unit tests for GtkInputMethodFilter in the WebCore platform layer.
1932         This change adds the TestGtk test suite which will be used for all non-API
1933         layer GTK unit tests.
1934
1935         * TestWebKitAPI/GNUmakefile.am: Update the build to include the new tests.
1936         * TestWebKitAPI/Tests/gtk/InputMethodFilter.cpp: Added.
1937         (TestWebKitAPI::PlatformWebView::PlatformWebView): Remove the call to gtk_init here
1938         as it's now in main.cpp.
1939         * TestWebKitAPI/gtk/main.cpp: Change the g_type_init call to gtk_init, because now
1940         a majority of all unit tests depend on GTK+ being initialized.
1941
1942 2012-06-28  Christophe Dumez  <christophe.dumez@intel.com>
1943
1944         [EFL] Enable support for HTML5 datalist
1945         https://bugs.webkit.org/show_bug.cgi?id=90157
1946
1947         Reviewed by Martin Robinson.
1948
1949         Turn on DATALIST flag by default on EFL port to
1950         support HTML5 datalist tag.
1951
1952         * Scripts/webkitperl/FeatureList.pm:
1953
1954 2012-06-28  Tony Chang  <tony@chromium.org>
1955
1956         Enable CSS grid layout LayoutTests on platform Mac
1957         https://bugs.webkit.org/show_bug.cgi?id=90113
1958
1959         Reviewed by Ojan Vafai.
1960
1961         * DumpRenderTree/mac/DumpRenderTree.mm:
1962         (resetDefaultsToConsistentValues): Reset the value to NO between tests.
1963
1964 2012-06-28  Mike Fenton  <mifenton@rim.com>
1965
1966         [BlackBerry] Add watchlist options for Blackberry and editing.
1967         https://bugs.webkit.org/show_bug.cgi?id=90193
1968
1969         Unreviewed.
1970
1971         Add BlackBerry and Editing watchlist and monitor them.
1972
1973         * Scripts/webkitpy/common/config/watchlist:
1974
1975 2012-06-28  Tim Horton  <timothy_horton@apple.com>
1976
1977         Unreviewed, upgrade myself to a reviewer!
1978
1979         http://www.webkit.org/blog/2082/tim-horton-is-now-a-webkit-reviewer/
1980
1981         * Scripts/webkitpy/common/config/committers.py:
1982
1983 2012-06-28  Terry Anderson  <tdanderson@chromium.org>
1984
1985         [Chromium] Chromium's LayoutTestController is missing setBackingScaleFactor
1986         https://bugs.webkit.org/show_bug.cgi?id=83635
1987
1988         Reviewed by Adam Barth.
1989
1990         Added InvokeCallbackTask, a new derived class of MethodTask. When
1991         setBackingScaleFactor is called, a call to setDeviceScaleFactor in
1992         WebView is made and then postTask is used to invoke the callback
1993         function specified in testRunner.setBackingScaleFactor. 
1994
1995         * DumpRenderTree/chromium/LayoutTestController.cpp:
1996         (LayoutTestController::LayoutTestController):
1997         (InvokeCallbackTask):
1998         (InvokeCallbackTask::InvokeCallbackTask):
1999         (InvokeCallbackTask::runIfValid):
2000         (LayoutTestController::setBackingScaleFactor):
2001         * DumpRenderTree/chromium/LayoutTestController.h:
2002         (LayoutTestController):
2003
2004 2012-06-28  Ojan Vafai  <ojan@chromium.org>
2005
2006         Make rebaseline-test and rebaseline-expectations work for non-Chromium ports
2007         https://bugs.webkit.org/show_bug.cgi?id=90186
2008
2009         Reviewed by Adam Barth.
2010
2011         This makes rebaselining work for all ports that have a TestExpectations file
2012         in the tree. I didn't test other ports.
2013
2014         This doesn't address 100% of the problem. The rebaseline code puts the expectations
2015         in the most specific directory and relies on optimize-baselines to merge baselines
2016         appropriately. This only works if every platform directory has an equivalent bot
2017         that runs the tests, which is not true for most ports.
2018
2019         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2020         (Builder._revision_and_build_for_filename):
2021         Some bots have filenames that aren't revision/build number pairs
2022         e.g. they are random junk like aQhxvx. Handle this gracefully.
2023         (Builder._fetch_revision_to_build_map):
2024         (Builder._file_info_list_to_revision_to_build_list):
2025         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2026         (BuilderTest.test_build_and_revision_for_filename):
2027         (BuilderTest.test_file_info_list_to_revision_to_build_list):
2028         * Scripts/webkitpy/layout_tests/port/builders.py:
2029         Update the list of builders. This list needs to be kept up
2030         to date for the rebaseline tool to work.
2031         * Scripts/webkitpy/tool/commands/rebaseline.py:
2032         (RebaselineTest._results_url):
2033         (RebaselineExpectations._run_webkit_patch):
2034         (RebaselineExpectations._rebaseline_port):
2035         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2036         Qt port uses qmake to determine the right version. Systems without qmake correctly fallback
2037         to a specific version.
2038
2039 2012-06-28  Csaba Osztrogonác  <ossy@webkit.org>
2040
2041         [Qt][NRWT] Fix baseline and skipped file search path.
2042         https://bugs.webkit.org/show_bug.cgi?id=89882
2043
2044         Unreviewed trivial typo fix after r121430.
2045
2046         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
2047         (QtPortTest._assert_search_path):
2048         (QtPortTest._assert_skipped_path):
2049
2050 2012-06-28  János Badics  <jbadics@inf.u-szeged.hu>
2051
2052         [Qt][NRWT] Fix baseline and skipped file search path.
2053         https://bugs.webkit.org/show_bug.cgi?id=89882
2054
2055         Reviewed by Csaba Osztrogonác.
2056
2057         * Scripts/webkitpy/layout_tests/port/qt.py:
2058         (QtPort._search_paths):
2059         (QtPort):
2060         (QtPort.baseline_search_path):
2061         (QtPort._skipped_file_search_paths):
2062         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
2063         (QtPortTest):
2064         (QtPortTest._assert_skipped_path):
2065         (QtPortTest.test_baseline_search_path):
2066         (QtPortTest.test_skipped_file_search_path):
2067
2068 2012-06-28  Alexander Pavlov  <apavlov@chromium.org>
2069
2070         [Qt] inspector/styles/inject-stylesheet.html makes 4 tests flakey (TEXT PASS)
2071         https://bugs.webkit.org/show_bug.cgi?id=90167
2072
2073         Reviewed by Csaba Osztrogonác.
2074
2075         DRT should remove user stylesheets from the page group when resetting before running another test.
2076
2077         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2078         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
2079
2080 2012-06-28  Csaba Osztrogonác  <ossy@webkit.org>
2081
2082         [Qt][DRT] Reset AcceleratedCompositingEnabled between tests
2083         https://bugs.webkit.org/show_bug.cgi?id=90164
2084
2085         Reviewed by Simon Hausmann.
2086
2087         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2088         (WebCore::WebPage::resetSettings):
2089
2090 2012-06-28  Csaba Osztrogonác  <ossy@webkit.org>
2091
2092         [Qt] Restore original value of mock scrollbars between tests
2093         https://bugs.webkit.org/show_bug.cgi?id=90155
2094
2095         Reviewed by Simon Hausmann.
2096
2097         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2098         (WebCore::WebPage::resetSettings):
2099         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2100         (LayoutTestController::setMockScrollbarsEnabled):
2101         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2102         (LayoutTestController):
2103
2104 2012-06-27  Mark Rowe  <mrowe@apple.com>
2105
2106         <http://webkit.org/b/90096> Building within Xcode sometimes does a full rebuild after building via build-webkit
2107
2108         We need to ensure that build-webkit uses the same setting for SHARED_PRECOMPS_DIR
2109         as what Xcode itself will use when building, otherwise switching between the two
2110         can result in the precompiled headers being rebuilt and thus the entire world
2111         rebuilding.
2112
2113         Reviewed by Dan Bernstein.
2114
2115         * Scripts/webkitdirs.pm:
2116         (determineBaseProductDir):
2117
2118 2012-06-27  Sheriff Bot  <webkit.review.bot@gmail.com>
2119
2120         Unreviewed, rolling out r121363, r121367, r121384, and
2121         r121390.
2122         http://trac.webkit.org/changeset/121363
2123         http://trac.webkit.org/changeset/121367
2124         http://trac.webkit.org/changeset/121384
2125         http://trac.webkit.org/changeset/121390
2126         https://bugs.webkit.org/show_bug.cgi?id=90134
2127
2128         It broke debug NRWT on GTK and on Qt (Requested by Ossy_NIGHT
2129         on #webkit).
2130
2131         * Scripts/webkitpy/layout_tests/port/chromium.py:
2132         (ChromiumPort):
2133         (ChromiumPort.__init__):
2134         (ChromiumPort._check_file_exists):
2135         (ChromiumPort.default_results_directory):
2136         (ChromiumPort._driver_class):
2137         (ChromiumPort._build_path):
2138         (ChromiumPort._path_to_image_diff):
2139         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2140         (ChromiumLinuxPort.baseline_search_path):
2141         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2142         (ChromiumMacPort.baseline_search_path):
2143         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2144         (ChromiumPortTest):
2145         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2146         (ChromiumWinPort.baseline_search_path):
2147         * Scripts/webkitpy/layout_tests/port/webkit.py:
2148         (WebKitPort.__init__):
2149         (WebKitPort._webcore_symbols_string):
2150         (WebKitPort._skipped_tests_for_unsupported_features):
2151         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2152         (TestWebKitPort._webcore_symbols_string):
2153         (WebKitPortUnitTests.test_default_options):
2154
2155 2012-06-27  Dirk Pranke  <dpranke@chromium.org>
2156
2157         Fix typo in r121384 :(
2158
2159         Unreviewed, build fix.
2160
2161         * Scripts/webkitpy/layout_tests/port/webkit.py:
2162         (WebKitPort.default_test_timeout_ms):
2163
2164 2012-06-27  Dirk Pranke  <dpranke@chromium.org>
2165
2166         nrwt: default timeout for debug bots broke in r121363
2167         https://bugs.webkit.org/show_bug.cgi?id=90112
2168
2169         Unreviewed, build fix.
2170
2171         I forgot to account for release and debug having different
2172         default values :(.
2173
2174         * Scripts/webkitpy/layout_tests/port/chromium.py:
2175         (ChromiumPort.default_test_timeout_ms):
2176         * Scripts/webkitpy/layout_tests/port/webkit.py:
2177         (WebKitPort):
2178         (WebKitPort.default_test_timeout_ms):
2179         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2180         (WebKitPortUnitTests.test_default_options):
2181
2182 2012-06-27  Dirk Pranke  <dpranke@chromium.org>
2183
2184         webkitpy: fix a couple of issues running under cygwin
2185         https://bugs.webkit.org/show_bug.cgi?id=90035
2186
2187         Reviewed by Eric Seidel.
2188
2189         These were causing unit tests to fail on cygwin (apple win bot).
2190
2191         * Scripts/webkitpy/layout_tests/port/chromium.py:
2192         * Scripts/webkitpy/performance_tests/perftest.py:
2193
2194 2012-06-27  Adam Barth  <abarth@webkit.org>
2195
2196         [Chromium] DumpRenderTree on Android should call SkUseTestFontConfigFile once available
2197         https://bugs.webkit.org/show_bug.cgi?id=89801
2198
2199         Reviewed by Nate Chapin.
2200
2201         Let's call SkUseTestFontConfigFile now that it exists.
2202
2203         * DumpRenderTree/chromium/TestShellAndroid.cpp:
2204         (platformInit):
2205
2206 2012-06-27  Dirk Pranke  <dpranke@chromium.org>
2207
2208         Fix typo introduced in r121363.
2209
2210         Unreviewed, build fix.
2211
2212         * Scripts/webkitpy/layout_tests/port/webkit.py:
2213         (WebKitPort._symbols_string):
2214
2215 2012-06-27  Mark Hahnenberg  <mhahnenberg@apple.com>
2216
2217         Moving from committers to reviewers :-)
2218
2219         Rubber stamped by Filip Pizlo.
2220
2221         * Scripts/webkitpy/common/config/committers.py:
2222
2223 2012-06-27  Dirk Pranke  <dpranke@chromium.org>
2224
2225         Derive ChromiumPort from WebKitPort to add support for missing symbols to skip tests
2226         https://bugs.webkit.org/show_bug.cgi?id=89706
2227
2228         Reviewed by Adam Barth.
2229
2230         Based on the original patch by Raymond Toy.
2231
2232         This patch changes ChromiumPort to derive from webkit.WebKitPort
2233         instead of base.Port. This is a long-awaited change and a
2234         precursor to merging base.Port and webkit.WebKitPort, but is
2235         driven by the desire to dynamically detect whether the MP3 and
2236         AAC codecs are compiled into DRT on Chromium, for which we
2237         wanted to re-use the existing logic in WebKit port for determine
2238         what to skip at compile time.
2239
2240         Most of the changes are shuffling things around so that we don't
2241         change any other logic and so we override the necessary methods
2242         in WebKitPort (and try to follow the same method definition
2243         order where possible).
2244
2245         Also, on the Chromium port the mp3 and aac codecs are actually
2246         defined in a separate library, so scanning webcore isn't
2247         sufficient. This patch generalizes the symbol lookup to handle
2248         multiple libraries, and uses different libraries as appropriate
2249         for Chromium.
2250
2251         The only functional/visible changes should be in the value
2252         returned for skipped_layout_tests().
2253
2254         * Scripts/webkitpy/layout_tests/port/chromium.py:
2255         (ChromiumPort):
2256         (ChromiumPort.__init__):
2257         (ChromiumPort.driver_name):
2258         (ChromiumPort._driver_class):
2259         (ChromiumPort._missing_symbol_to_skipped_tests):
2260         (ChromiumPort.skipped_layout_tests):
2261         (ChromiumPort.setup_test_run):
2262         (ChromiumPort._path_to_image_diff):
2263         (ChromiumPort._convert_path):
2264         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2265         (ChromiumPortTest.test_missing_symbol_to_skipped_tests):
2266         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2267         (ChromiumLinuxPort._modules_to_search_for_symbols):
2268         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2269         (ChromiumLinuxPort._modules_to_search_for_symbols):
2270         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2271         (ChromiumLinuxPort._modules_to_search_for_symbols):
2272         * Scripts/webkitpy/layout_tests/port/webkit.py:
2273         (WebKitPort):
2274         (WebKitPort.__init__):
2275         (WebKitPort._symbols_string):
2276         (WebKitPort._modules_to_search_for_symbols):
2277
2278 2012-06-27  Csaba Osztrogonác  <ossy@webkit.org>
2279
2280         [Qt] REGRESSION(r121339): It broke the build on the Qt Windows bots
2281         https://bugs.webkit.org/show_bug.cgi?id=90081
2282
2283         Buildfix for Qt 4.8 Windows. Use the former path for Qt 4.8, and the newer one for Qt 5.
2284
2285         Reviewed by Noam Rosenthal.
2286
2287         * qmake/mkspecs/features/features.prf:
2288
2289 2012-06-27  Sergio Villar Senin  <svillar@igalia.com>
2290
2291         [WK2] [GTK] WebKit2 testing bot fails to run tests due to missing files
2292         https://bugs.webkit.org/show_bug.cgi?id=90061
2293
2294         Reviewed by Gustavo Noronha Silva.
2295
2296         Add "-no-install -no-fast-install" to the LDFLAGS in bots. With
2297         this flag libtool tells the linker to set the rpath for the output
2298         file to the full path of the .libs directory, instead of using a
2299         wrapper script to set up the LD_LIBRARY_PATH. This will allow us
2300         to directly reuse builds in the pure testing bots.
2301
2302         * BuildSlaveSupport/gtk/daemontools-buildbot.conf:
2303
2304 2012-06-27  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2305
2306         [Qt] No need to save and restore TEMPLATE in a function
2307
2308         This was a leftover from when the logic was not in its own function scope.
2309
2310         QMAKE_FRAMEWORK_BUNDLE_NAME on the other hand is exported in qtLibraryTarget, which
2311         will surprisingly affect the global scope as well, so we have to save and restore it.
2312
2313         Original patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com> on 2012-06-27
2314
2315         Reviewed by Tor Arne Vestbø.
2316
2317         * qmake/mkspecs/features/functions.prf:
2318
2319 2012-06-27  Oswald Buddenhagen  <oswald.buddenhagen@nokia.com>
2320
2321         [Qt] Fix lookup location for sqlite sources
2322
2323         Don't look in the install dir - we are unlikely to find anything there
2324         unless we are doing a developer build.
2325
2326         Reviewed by Tor Arne Vestbø.
2327
2328         * qmake/mkspecs/features/features.prf:
2329
2330 2012-06-27  Zan Dobersek  <zandobersek@gmail.com>
2331
2332         [Gtk] Add support for the Gamepad API
2333         https://bugs.webkit.org/show_bug.cgi?id=87503
2334
2335         Reviewed by Carlos Garcia Campos.
2336
2337         Enable the gamepad support for the GTK port.
2338
2339         * Scripts/webkitperl/FeatureList.pm:
2340
2341 2012-06-27  Ryosuke Niwa  <rniwa@webkit.org>
2342
2343         Fix gcc build after r121302
2344         https://bugs.webkit.org/show_bug.cgi?id=90055
2345
2346         Reviewed by Mark Rowe.
2347
2348         Assume RTTI is always disabled so that gtest builds on XCode 3.2.6.
2349
2350         It appears that gcc doesn't like window.get().* inside a template so replace that by [window.get() *] instead.
2351
2352         * TestWebKitAPI/Configurations/Base.xcconfig:
2353         * TestWebKitAPI/Tests/mac/AcceptsFirstMouse.mm:
2354         (TestWebKitAPI::AcceptsFirstMouse::runTest):
2355
2356 2012-06-27  Csaba Osztrogonác  <ossy@webkit.org>
2357
2358         Add master.cfg unittest to help migration - pass BuildStep instances instead of BuildStep subclasses
2359         https://bugs.webkit.org/show_bug.cgi?id=89564
2360
2361         Reviewed by Tony Chang.
2362
2363         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
2364         (BuildStepsConstructorTest):
2365         (BuildStepsConstructorTest.generateTests):
2366         (BuildStepsConstructorTest.createTest):
2367         (BuildStepsConstructorTest.createTest.doTest):
2368
2369 2012-06-26  Mark Hahnenberg  <mhahnenberg@apple.com>
2370
2371         Add support for preciseTime() to WebKitTestRunner
2372         https://bugs.webkit.org/show_bug.cgi?id=90027
2373
2374         Reviewed by Darin Adler.
2375
2376         It would be nice to be able to use preciseTime() in WebKitTestRunner like we can in DumpRenderTree.
2377
2378         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2379         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: 
2380         (WTR::LayoutTestController::preciseTime): 
2381         (WTR):
2382         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2383         (LayoutTestController):
2384
2385 2012-06-26  Lucas Forschler  <lforschler@apple.com>
2386
2387       Teach the Apple port how to build the test tools in build-webkit
2388       https://bugs.webkit.org/show_bug.cgi?id=89540
2389
2390       Reviewed by Jon Lee & Simon Fraser.
2391
2392       * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2393       (RunWebKitTests.start): pass --no-build since tools should now be in the downloaded archive
2394       (RunUnitTests.start): ditto
2395       * Scripts/build-webkit: add tools to the projects build list
2396
2397 2012-06-26  Ojan Vafai  <ojan@chromium.org>
2398
2399         Only show the platform-appropriate builders for non-layout test failures in garden-o-matic
2400         https://bugs.webkit.org/show_bug.cgi?id=90025
2401
2402         Reviewed by Simon Fraser.
2403
2404         Move the chromium-specific filtering code into config.js and replace it with a method on each platform
2405         config. Also, let the webkit test step name be webkit_tests (build.chromium.org) or layout-test (build.webkit.org).
2406
2407         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
2408         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
2409         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
2410
2411 2012-06-26  Ojan Vafai  <ojan@chromium.org>
2412
2413         Fix failing garden-o-matic unittests
2414         https://bugs.webkit.org/show_bug.cgi?id=90021
2415
2416         Reviewed by Adam Barth.
2417
2418         These had all just fallen out of date.
2419
2420         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
2421         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
2422         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
2423
2424 2012-06-26  Ojan Vafai  <ojan@chromium.org>
2425
2426         Fix platform picker change handler in garden-o-matic
2427         https://bugs.webkit.org/show_bug.cgi?id=90010
2428
2429         Reviewed by Simon Fraser.
2430
2431         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
2432         The old code never worked. This is hard to test because change handlers require
2433         a user-initiated action and the code is changing the window's location, which would
2434         navigate the test page.
2435
2436         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css:
2437         Fix the CSS so it doesn't cause the tabstrip to be disconnected from the tabs on Linux
2438         due to the large margin-bottom.
2439
2440 2012-06-26  Thiago Marcos P. Santos  <thiago.santos@intel.com>
2441
2442         webkitpy: Make webkit-patch patches-to-review useful
2443         https://bugs.webkit.org/show_bug.cgi?id=89470
2444
2445         Reviewed by Eric Seidel.
2446
2447         webkit-patch patches-to-review will now output the list of
2448         bugs with patches pending for review that has the user on CC,
2449         excluding patches with cq-, sorted by the age of the patch.
2450
2451         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2452         (BugzillaQueries.fetch_bugs_from_review_queue):
2453         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
2454         (MockBugzillaQueries.fetch_bugs_from_review_queue):
2455         (MockBugzilla.__init__):
2456         (MockBugzilla.authenticate):
2457         * Scripts/webkitpy/tool/commands/queries.py:
2458         (PatchesToReview):
2459         (PatchesToReview.__init__):
2460         (PatchesToReview._print_report):
2461         (PatchesToReview._generate_report):
2462         (PatchesToReview.execute):
2463         * Scripts/webkitpy/tool/commands/queries_unittest.py:
2464         (QueryCommandsTest.test_patches_to_review):
2465
2466 2012-06-26  Dirk Pranke  <dpranke@chromium.org>
2467
2468         nrwt: broken for chromium on vista
2469         https://bugs.webkit.org/show_bug.cgi?id=89988
2470
2471         Reviewed by Tony Chang.
2472
2473         r121194 removed support for 'chromium-win-vista' as a separate
2474         port, but this actually prevented the code from running on vista
2475         at all, which is unduly harsh and broke the websocket tests on
2476         the (non-webkit) chromium bots that are still running on vista.
2477
2478         It's probably good enough to pretend that vista is win7 instead;
2479         some layout tests will still fail but at least things'll run.
2480
2481         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2482         (ChromiumWinPort.determine_full_port_name):
2483         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
2484         (ChromiumWinTest.test_versions):
2485
2486 2012-06-26  Csaba Osztrogonác  <ossy@webkit.org>
2487
2488         master.cfg cleanup: Pass CheckOutSource instance instead of class to BuildStep.addStep
2489         https://bugs.webkit.org/show_bug.cgi?id=89215
2490
2491         We need it because it is deprecated and will be dropped in buildbot 0.8.7
2492
2493         Reviewed by Tony Chang.
2494
2495         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2496         (CheckOutSource.__init__):
2497         (Factory.__init__):
2498
2499 2012-06-26  Simon Hausmann  <simon.hausmann@nokia.com>
2500
2501         [Qt][Win] Symbols are not exported in QtWebKit5.dll
2502         https://bugs.webkit.org/show_bug.cgi?id=88873
2503
2504         Reviewed by Tor Arne Vestbø.
2505
2506         When linking the target dll make sure to re-export the symbols from
2507         the static libraries marked as export, with the help of a little python
2508         script and a qmake extra compiler.
2509
2510         * Scripts/generate-win32-export-forwards: Added.
2511         * qmake/mkspecs/features/win32/default_post.prf:
2512
2513 2012-06-25  Jocelyn Turcotte  <turcotte.j@gmail.com>
2514
2515         Add a note about hostname completion not working well with --cc completion
2516
2517         Reviewed by Simon Hausmann.
2518
2519         Hostname completion tries to resolve anything after an @ sign which is present
2520         in the completed list of contributor emails to CC.
2521
2522         * Scripts/webkit-tools-completion.sh:
2523
2524 2012-06-26  Sheriff Bot  <webkit.review.bot@gmail.com>
2525
2526         Unreviewed, rolling out r121244.
2527         http://trac.webkit.org/changeset/121244
2528         https://bugs.webkit.org/show_bug.cgi?id=89966
2529
2530         skip list path is incorrect now. (Requested by Ossy on
2531         #webkit).
2532
2533         * Scripts/webkitpy/layout_tests/port/qt.py:
2534         (QtPort.baseline_search_path):
2535         (QtPort._skipped_file_search_paths):
2536         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
2537         (QtPortTest.test_baseline_search_path):
2538
2539 2012-06-26  János Badics  <jbadics@inf.u-szeged.hu>
2540
2541         [Qt][NRWT] Fix baseline and skipped file search path.
2542         https://bugs.webkit.org/show_bug.cgi?id=89882
2543
2544         Reviewed by Csaba Osztrogonác.
2545
2546         * Scripts/webkitpy/layout_tests/port/qt.py:
2547         (QtPort.baseline_search_path):
2548         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
2549         (QtPortTest.test_baseline_search_path):
2550
2551 2012-06-26  Tony Chang  <tony@chromium.org>
2552
2553         [Qt] Enable grid layout LayoutTests
2554         https://bugs.webkit.org/show_bug.cgi?id=89909
2555
2556         Reviewed by Csaba Osztrogonác.
2557
2558         These tests pass, we just need to hook up the overridePreference.
2559
2560         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2561         (WebCore::WebPage::resetSettings): Reset grid layout and regions between tests.
2562         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2563         (LayoutTestController::overridePreference): Add WebKitCSSGridLayoutEnabled.
2564
2565 2012-06-26  Sheriff Bot  <webkit.review.bot@gmail.com>
2566
2567         Unreviewed, rolling out r121236.
2568         http://trac.webkit.org/changeset/121236
2569         https://bugs.webkit.org/show_bug.cgi?id=89956
2570
2571         It's broke the nrwt on qt and gtk platform (Requested by
2572         kkristof on #webkit).
2573
2574         * Scripts/webkitpy/layout_tests/port/qt.py:
2575         (QtPort._build_driver):
2576         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
2577         (XvfbDriver._start):
2578         (XvfbDriver._start.x_filter):
2579         (XvfbDriver.stop):
2580
2581 2012-06-26  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
2582
2583         [NRWT] XvfbDriver should choose the next free display
2584         https://bugs.webkit.org/show_bug.cgi?id=88414
2585
2586         Reviewed by Dirk Pranke.
2587
2588         * Scripts/webkitpy/layout_tests/port/qt.py:
2589         (QtPort._driver_class):
2590         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
2591         (XvfbDriver.__init__):
2592         (XvfbDriver._start):
2593         (XvfbDriver._start.next_free_id):
2594         (XvfbDriver.stop):
2595
2596 2012-06-25  Simon Hausmann  <simon.hausmann@nokia.com>
2597
2598         [Qt] Make it possible to build WebKit without QtWidgets
2599         https://bugs.webkit.org/show_bug.cgi?id=78109
2600
2601         Reviewed by Tor Arne Vestbø.
2602
2603         * Tools.pro: Disable various tools that depend on WK1.
2604         * qmake/mkspecs/features/default_post.prf: Add WK1 as supported static lib in WEBKIT
2605         * qmake/mkspecs/features/default_pre.prf: Disable WK1 if QtWidgets is not built.
2606         * qmake/mkspecs/modules/webkit1.prf: Added.
2607
2608 2012-06-25  Dirk Pranke  <dpranke@chromium.org>
2609
2610         put vista back for chromium (non-webkit) bots ...
2611         https://bugs.webkit.org/show_bug.cgi?id=89929
2612
2613         Unreviewed, build fix.
2614
2615         Turns out we've only gotten rid of vista on the webkit tests so
2616         far. Put vista back for the other chromium bots ...
2617
2618         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2619         (chromiumPlatform):
2620         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
2621         (test):
2622
2623 2012-06-25  Dirk Pranke  <dpranke@chromium.org>
2624
2625         update flakiness dashboard after removing chromium-vista bots
2626         https://bugs.webkit.org/show_bug.cgi?id=89925
2627
2628         Unreviewed, build fix.
2629
2630         More changes missed in r121194 :(.
2631
2632         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2633         (chromiumPlatform):
2634         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
2635         (test):
2636
2637 2012-06-25  Dirk Pranke  <dpranke@chromium.org>
2638
2639         remove support for chromium vista from tools
2640         https://bugs.webkit.org/show_bug.cgi?id=89915
2641
2642         Reviewed by Tony Chang.
2643
2644         This change is all deleting code and updating tests to handle
2645         the configuration being gone. All tests now pass except for a
2646         few unittests for the flakiness dashboard which were failing
2647         before this patch.
2648
2649         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
2650         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
2651         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
2652         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
2653         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
2654         (BaselineOptimizerTest.test_complex_shadowing):
2655         * Scripts/webkitpy/layout_tests/port/builders.py:
2656         * Scripts/webkitpy/layout_tests/port/chromium.py:
2657         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2658         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2659         (ChromiumWinPort):
2660         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
2661         (ChromiumWinTest.test_versions):
2662         (ChromiumWinTest.test_baseline_path):
2663         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2664         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
2665         (BuildCoverageExtrapolatorTest.test_extrapolate):
2666
2667 2012-06-25  Scott Graham  <scottmg@chromium.org>
2668
2669         [Chromium] add empty impl of WebThemeEngine::getSize() for DRT
2670         https://bugs.webkit.org/show_bug.cgi?id=89907
2671
2672         Not reviewed. Fix build in Chromium.
2673
2674         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp:
2675         (WebThemeEngineDRTWin::getSize):
2676         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h:
2677         (WebThemeEngineDRTWin):
2678
2679 2012-06-25  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2680
2681         [EFL] Implement Network Information API
2682         https://bugs.webkit.org/show_bug.cgi?id=87067
2683
2684         Reviewed by Kenneth Rohde Christiansen.
2685
2686         * efl/jhbuild.modules: Add eeze library dependency.
2687
2688 2012-06-25  Simon Hausmann  <simon.hausmann@nokia.com>
2689
2690         [Qt] Fix Win32 debug build
2691
2692         Reviewed by Tor Arne Vestbø.
2693
2694         Consolidate use_all_in_one_files into mac/unix/win32 default_pre.prf.
2695
2696         * qmake/mkspecs/features/unix/default_pre.prf:
2697         * qmake/mkspecs/features/win32/default_pre.prf: Added.
2698
2699 2012-06-24  Thiago Marcos P. Santos  <thiago.santos@intel.com>
2700
2701         [Qt] Enable <input type="color"> support by default
2702         https://bugs.webkit.org/show_bug.cgi?id=89653
2703
2704         Reviewed by Kenneth Rohde Christiansen.
2705
2706         This feature is complete for Qt WebKit2. Enabling by default
2707         will help to mature the implementation.
2708
2709         * Scripts/webkitperl/FeatureList.pm:
2710         * qmake/mkspecs/features/features.pri:
2711
2712 2012-06-24  Dan Bernstein  <mitz@apple.com>
2713
2714         Made debug-{minibrowser,safari,test-runner} work with LLDB.
2715
2716         Reviewed by Sam Weinig.
2717
2718         * Scripts/debug-minibrowser: Pass INCLUDE_OPTIONS_FOR_DEBUGGING to
2719         printHelpAndExitForRunAndDebugWebKitAppIfNeeded().
2720         * Scripts/debug-safari: Ditto.
2721         * Scripts/debug-test-runner: Ditto.
2722         * Scripts/webkitdirs.pm:
2723         (debugger): Added. Calls determineDebugger() if needed and returns the chosen debugger.
2724         (determineDebugger): Added. Sets the debugger to "lldb" if the --use-lldb switch is present,
2725         and to "gdb" otherwise.
2726         (printHelpAndExitForRunAndDebugWebKitAppIfNeeded): Changed to print help for the
2727         --target-web-process and --use-lldb switches if passed INCLUDE_OPTIONS_FOR_DEBUGGING.
2728         (execMacWebKitAppForDebugging): Changed to use the chosen debugger.
2729
2730 2012-06-24  Adam Barth  <abarth@webkit.org>
2731
2732         [Chromium] Release media resources after each LayoutTest on Android
2733         https://bugs.webkit.org/show_bug.cgi?id=89720
2734
2735         Reviewed by Eric Carlson.
2736
2737         The LayoutTests can hang when run on Android because we sometimes run
2738         out of media resources. This patch causes us to release our media
2739         resources after each test in order to avoid running out of this
2740         resource. In production, there are other mechanisms that manage this
2741         resource.
2742
2743         * DumpRenderTree/chromium/TestShell.cpp:
2744         (TestShell::resetTestController):
2745
2746 2012-06-23  Zan Dobersek  <zandobersek@gmail.com>
2747
2748         [Gtk] REGRESSION(r120918): Causes flaky DND tests
2749         https://bugs.webkit.org/show_bug.cgi?id=89770
2750
2751         Reviewed by Martin Robinson.
2752
2753         Connect to the run-file-chooser signal of the WebKitWebView and
2754         return TRUE so no file chooser dialog is run. This prevents certain
2755         test failures.
2756
2757         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2758         (webViewRunFileChooser):
2759         (createWebView):
2760
2761 2012-06-23  Dan Bernstein  <mitz@apple.com>
2762
2763         debug-{minibrowser,safari,test-runner} fail when gdb is not installed in /usr/bin.
2764
2765         Reviewed by Sam Weinig.
2766
2767         * Scripts/webkitdirs.pm:
2768         (execMacWebKitAppForDebugging): Use xcrun to locate gdb.
2769
2770 2012-06-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2771
2772         Unreviewed. Skip GTK+ unit test /webkit2/WebKitFindController/hide.
2773
2774         It fails always when running it in Xvfb.
2775
2776         * gtk/run-api-tests:
2777         (TestRunner):
2778
2779 2012-06-23  Wajahat Siddiqui  <mdwajahatali.siddiqui@motorola.com>
2780
2781         [GTK][WK2]Mis-spelt defaultWindowTitle
2782         https://bugs.webkit.org/show_bug.cgi?id=89808
2783
2784         Reviewed by Carlos Garcia Campos.
2785
2786         * MiniBrowser/gtk/BrowserWindow.c:
2787
2788 2012-06-23  Sergio Villar Senin  <svillar@igalia.com>
2789
2790         [GTK] Add a new webkit2 tests slave bot
2791         https://bugs.webkit.org/show_bug.cgi?id=89336
2792
2793         Reviewed by Csaba Osztrogonác.
2794
2795         Slave configuration for a new GTK 64 bit release bot that will run
2796         WebKit2 tests.
2797
2798         Also BuildAndTest now accepts the "triggers" parametter,
2799         this means that apart from building and testing it can trigger
2800         some other build/test sequences in other slaves.
2801
2802         * BuildSlaveSupport/build.webkit.org-config/config.json:
2803         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2804         (BuildAndTestFactory.__init__):
2805
2806 2012-06-23  Kwang Yul Seo  <skyul@company100.net>
2807
2808         Unreviewed. Update my email.
2809
2810         * Scripts/webkitpy/common/config/committers.py:
2811
2812 2012-06-22  Adam Barth  <abarth@webkit.org>
2813
2814         [Chromium] DumpRenderTree on Android needs to configure fonts for testing
2815         https://bugs.webkit.org/show_bug.cgi?id=89721
2816
2817         Reviewed by Nate Chapin.
2818
2819         This patch teaches DumpRenderTree to configure Skia to use the fallback
2820         fonts that the LayoutTests assume. This patch reduces the number result
2821         differences between chromium-android and chromium-linux.
2822
2823         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2824         * DumpRenderTree/chromium/TestShellAndroid.cpp:
2825         (platformInit):
2826         * DumpRenderTree/chromium/android_fallback_fonts.xml: Added.
2827         * DumpRenderTree/chromium/android_main_fonts.xml: Added.
2828         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2829
2830 2012-06-22  Alexandru Chiculita  <achicu@adobe.com>
2831
2832         [CSS Shaders] Re-enable the CSS Shaders compile time flag on Safari Mac
2833         https://bugs.webkit.org/show_bug.cgi?id=89781
2834
2835         Reviewed by Dean Jackson.
2836
2837         Added CSS Shaders as enabled by default on Safari for Mac.
2838
2839         * Scripts/webkitperl/FeatureList.pm:
2840
2841 2012-06-22  Adam Barth  <abarth@webkit.org>
2842
2843         Add support for test_expectations_android.txt for overriding test expecations on the chromium-android branch
2844         https://bugs.webkit.org/show_bug.cgi?id=89791
2845
2846         Reviewed by Dirk Pranke.
2847
2848         Downstream, the chromium-android port maintains a test expectations
2849         file to keep track of which tests pass or fail. That causes them to
2850         keep a patch in chromium_android.py in their branch.
2851
2852         This patch teaches chromium_android.py to use test_expectations_android.txt.
2853         We don't intend to use this file upstream, but having this code patch
2854         upstream lets us unfork webkitpy.
2855
2856         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2857         (ChromiumAndroidPort.expectations_files):
2858
2859 2012-06-22  Dirk Pranke  <dpranke@chromium.org>
2860
2861         run_webkit_tests.py failed with AttributeError(''NoneType' object has no attribute 'pid'')
2862         https://bugs.webkit.org/show_bug.cgi?id=89734
2863
2864         Reviewed by Ryosuke Niwa.
2865
2866         Fix a crash in ServerProcess if you called .pid() after it
2867         crashed during a write(). We had a test for this case but the
2868         test wasn't calling pid(), just has_crashed(). Fixed the problem
2869         and the test.
2870
2871         * Scripts/webkitpy/layout_tests/port/server_process.py:
2872         (ServerProcess.__init__):
2873         (ServerProcess.pid):
2874         (ServerProcess._start):
2875         (ServerProcess.stop):
2876         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
2877         (FakeServerProcess._start):
2878         (TestServerProcess.test_broken_pipe):
2879
2880 2012-06-22  Peter Beverloo  <peter@chromium.org>
2881
2882         [Chromium] Disable c++0x compatibility warnings in JavaScriptCore.gyp when building for Android
2883         https://bugs.webkit.org/show_bug.cgi?id=88853
2884
2885         Reviewed by Steve Block.
2886
2887         The Android exclusions were necessary to fix a gyp generation error, as
2888         the gcc_version variable wasn't being defined for Android. Remove these
2889         exceptions when Chromium is able to define the gcc_version variable.
2890
2891         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2892
2893 2012-06-22  Mario Sanchez Prada  <msanchez@igalia.com>
2894
2895         Unreviewed gardening. Unskipping test passing after fixing bug 88419.
2896
2897         * gtk/run-api-tests:
2898         (TestRunner): Unskip WTF.HashMap.
2899
2900 2012-06-22  Zoltan Horvath  <zoltan@webkit.org>
2901
2902         [Qt] Allow DumpRenderTree to dump about:blank
2903         https://bugs.webkit.org/show_bug.cgi?id=89685
2904
2905         Reviewed by Ryosuke Niwa.
2906
2907         We need to allow DumpRenderTree to dump about:blank page, then it will be consistent with other ports,
2908         additionaly this behavior is required for running WTR performance tests.
2909
2910         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2911         (WebCore::DumpRenderTree::processLine):
2912
2913 2012-06-21  Adam Barth  <abarth@webkit.org>
2914
2915         [Chromium] Reset mediaPlaybackRequiresUserGesture WebSettings after each test
2916         https://bugs.webkit.org/show_bug.cgi?id=89718
2917
2918         Reviewed by Kent Tamura.
2919
2920         We should reset this WebSetting to its default value so that it behaves
2921         consistently across tests.
2922
2923         * DumpRenderTree/chromium/WebPreferences.cpp:
2924         (WebPreferences::reset):
2925         (WebPreferences::applyTo):
2926         * DumpRenderTree/chromium/WebPreferences.h:
2927         (WebPreferences):
2928
2929 2012-06-21  Zoltan Horvath  <zoltan@webkit.org>
2930
2931         DRT/WTR python interface handles about:blank incorrectly
2932         https://bugs.webkit.org/show_bug.cgi?id=89563
2933
2934         Reviewed by Dirk Pranke.
2935
2936         Currently DRT/WTR python interface's _command_from_driver_input function
2937         puts the test directory path before about:blank. Remove this incorrect behavior.
2938
2939         * Scripts/webkitpy/layout_tests/port/webkit.py:
2940         (WebKitDriver._command_from_driver_input):
2941
2942 2012-06-21  Dirk Pranke  <dpranke@chromium.org>
2943
2944         reenable perf tests on win
2945         https://bugs.webkit.org/show_bug.cgi?id=89690
2946
2947         Reviewed by Ryosuke Niwa.
2948
2949         Only the replay tests don't work, and those are disabled by
2950         default. This change also fixes the undefined _log reference
2951         that was causing a crash.
2952
2953         * Scripts/run-perf-tests:
2954
2955 2012-06-21  Sheriff Bot  <webkit.review.bot@gmail.com>
2956
2957         Unreviewed, rolling out r120937.
2958         http://trac.webkit.org/changeset/120937
2959         https://bugs.webkit.org/show_bug.cgi?id=89679
2960
2961         This patch brought buildbot master down (Requested by svillar
2962         on #webkit).
2963
2964         * BuildSlaveSupport/build.webkit.org-config/config.json:
2965
2966 2012-06-21  Martin Robinson  <mrobinson@igalia.com>
2967
2968         [GTK] Combine WebKit API tests into fewer binaries
2969         https://bugs.webkit.org/show_bug.cgi?id=88458
2970
2971         Reviewed by Carlos Garcia Campos.
2972
2973         Instead of creating one binary per-test file, create binaries for each
2974         category of tests. Right now this includes WTF and the WebKit2 C API,
2975         but later tests can be added for the GTK+ platform layer and the WebKit1
2976         and WebKit2 API layers.
2977
2978         * TestWebKitAPI/GNUmakefile.am: Compile only two test binaries, one for the WebKit2
2979           C API and one for WTF. Refresh the source list to ensure that new test are active.
2980         * gtk/run-api-tests: Change the way that tests are skipped by splitting out the
2981         concept of skipping a test and skipping a suite (program) of tests. Test cases are
2982         skipped because of legitimate failures, but entire programs are skipped because of
2983         problems in the harness. As of right now a test program is only skipped if the
2984         accessibility bus cannot be started.
2985         (SkippedTest.__init__): Make the test case a required argument and have one skipped
2986         test case per SkippedTest instance.
2987         (SkippedTest.__str__): Ditto.
2988         (TestRunner): Update the directory list. We only have two gtest binaries now and they are
2989         in one directory. Reformat the test list to make it slightly easier to read.
2990         (TestRunner.__init__): Add the _skipped_test_program member, which handles entire
2991         test programs that are skipped.
2992         (TestRunner._setup_testing_environment): Use the new member.
2993         (TestRunner._test_cases_to_skip): Collect all skipped test cases now instead of just
2994         the first SkippedTest that matches.
2995         (TestRunner._should_run_test_program): Take a look at the new member to make this
2996         decision.
2997         (TestRunner._run_test_command): Use the name test_program instead of test
2998         to disambiguate between test cases and test suites.
2999         (TestRunner._run_test_glib): ditto.
3000         (TestRunner._run_test_google): Ditto.
3001         (TestRunner._run_test): Ditto.
3002         (TestRunner.run_tests): Ditto.
3003
3004 2012-06-21  Yong Li  <yoli@rim.com>
3005
3006         Unreviewed. Moving myself from committer to reviewer.
3007
3008         * Scripts/webkitpy/common/config/committers.py:
3009
3010 2012-06-21  Sergio Villar Senin  <svillar@igalia.com>
3011
3012         [GTK] Add a new webkit2 tests slave bot
3013         https://bugs.webkit.org/show_bug.cgi?id=89336
3014
3015         Reviewed by Philippe Normand.
3016
3017         Slave configuration for a new GTK bot that will run WebKit2 tests.
3018
3019         * BuildSlaveSupport/build.webkit.org-config/config.json:
3020
3021 2012-06-21  Thiago Marcos P. Santos  <thiago.santos@intel.com>
3022
3023         [Qt] Add a custom Color Chooser widget to MiniBrowser
3024         https://bugs.webkit.org/show_bug.cgi?id=87988
3025
3026         Reviewed by Alexis Menard.
3027
3028         Added custom color chooser example for the MiniBrowser.
3029
3030         * MiniBrowser/qt/MiniBrowser.qrc:
3031         * MiniBrowser/qt/qml/BrowserWindow.qml:
3032         * MiniBrowser/qt/qml/ColorChooser.qml: Added.
3033
3034 2012-06-21  Vivek Galatage  <vivekgalatage@gmail.com>
3035
3036         Remove the warning "File not found" in MiniBrowser post-build event
3037         https://bugs.webkit.org/show_bug.cgi?id=89601
3038
3039         Reviewed by Adam Roben.
3040
3041         * MiniBrowser/MiniBrowserPostBuild.cmd:
3042
3043 2012-06-21  Balazs Kelemen  <kbalazs@webkit.org>
3044
3045         [Qt] DRT in standalone mode hangs after the first test
3046         https://bugs.webkit.org/show_bug.cgi?id=89613
3047
3048         Reviewed by Csaba Osztrogonác.
3049
3050         Break an inline signal slot chain that ends up in setting
3051         LayoutTestController::m_hasDumped too early. In LayoutTestController::maybeDump()
3052         we emit done() which starts the chain that finishes in DumpRenderTree::open().
3053         The next line in maybeDump sets m_hasDumped to true. We could simply reorder
3054         these two lines but it seems to be wrong in general to start the next load
3055         from this call chain. The server mode (when DRT is runned by the test harness)
3056         also uses a queued connection to read the next test from stdin.
3057
3058         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3059         (WebCore::DumpRenderTree::processArgsLine):
3060
3061 2012-06-20  Hans Wennborg  <hans@chromium.org>
3062
3063         Speech JavaScript API: SpeechRecognition should hook up with ActiveDOMObject more
3064         https://bugs.webkit.org/show_bug.cgi?id=89217
3065
3066         Reviewed by Adam Barth.
3067
3068         Add a method for checking whether the mock speech
3069         recognition was aborted.
3070
3071         Also redo the way the mock posts tasks. Instead of posting them all at once,
3072         maintain an internal queue of task objects, and call postTask() for them
3073         once at the time. This means that for example when the page is navigated
3074         away and abort() is called, that call doesn't end up after a bunch
3075         of previously posted events on the event loop.
3076
3077         * DumpRenderTree/chromium/LayoutTestController.cpp:
3078         (LayoutTestController::LayoutTestController):
3079         (LayoutTestController::wasMockSpeechRecognitionAborted):
3080         * DumpRenderTree/chromium/LayoutTestController.h:
3081         (LayoutTestController):
3082         * DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp:
3083         (WebKit::ClientCallTask::ClientCallTask):
3084         (WebKit::ResultTask::ResultTask):
3085         (WebKit::NoMatchTask::NoMatchTask):
3086         (WebKit::ErrorTask::ErrorTask):
3087         (MockWebSpeechRecognizer::start):
3088         (MockWebSpeechRecognizer::abort):
3089         (MockWebSpeechRecognizer::setError):
3090         (MockWebSpeechRecognizer::MockWebSpeechRecognizer):
3091         (MockWebSpeechRecognizer::startTaskQueue):
3092         (MockWebSpeechRecognizer::StepTask::runIfValid):
3093         * DumpRenderTree/chromium/MockWebSpeechRecognizer.h:
3094         (MockWebSpeechRecognizer::hasBeenAborted):
3095         (MockWebSpeechRecognizer):
3096         (MockWebSpeechRecognizer::taskList):
3097         (Task):
3098         (MockWebSpeechRecognizer::Task::Task):
3099         (MockWebSpeechRecognizer::Task::~Task):
3100         (StepTask):
3101         (MockWebSpeechRecognizer::StepTask::StepTask):
3102
3103 2012-06-21  Mario Sanchez Prada  <msanchez@igalia.com>
3104
3105         [GTK] Add support for window.showModalDialog in WebKit2GTK+
3106         https://bugs.webkit.org/show_bug.cgi?id=79500
3107
3108         Reviewed by Carlos Garcia Campos.
3109
3110         Add support for modal dialogs in GTK's MiniBrowser.
3111
3112         * MiniBrowser/gtk/BrowserWindow.c:
3113         (webViewRunAsModal):
3114         (webViewCreate):
3115         (webViewDecidePolicy):
3116         (browser_window_new):
3117         * MiniBrowser/gtk/BrowserWindow.h:
3118         * MiniBrowser/gtk/main.c:
3119         (createBrowserWindow):
3120
3121 2012-06-20  Brent Fulgham  <bfulgham@webkit.org>
3122
3123         [WinCairo] Unreviewed build fix.
3124         The wrapper script that launched new- and old-run-webkit-tests
3125         was discarding the --wincairo argument needed to get the proper
3126         test infrastructure to build under WinCairo.
3127
3128         * Scripts/run-webkit-tests: Emulate the Qt, Wx, Chromium, etc.,
3129         behavior to chain the --wincairo flag through to the new build
3130         and test scripts.
3131
3132 2012-06-20  Mark Rowe  <mrowe@apple.com>
3133
3134         <http://webkit.org/b/89606> Teach run-safari and debug-safari to work with a Safari.app that has entitlements
3135
3136         Reviewed by Dan Bernstein.
3137
3138         * Scripts/webkitdirs.pm:
3139         (executableHasEntitlements):
3140         (safariPathFromSafariBundle):
3141
3142 2012-06-20  Sheriff Bot  <webkit.review.bot@gmail.com>
3143
3144         Unreviewed, rolling out r120821.
3145         http://trac.webkit.org/changeset/120821
3146         https://bugs.webkit.org/show_bug.cgi?id=89605
3147
3148         It made duplicated reviewer entries (Requested by Ossy on
3149         #webkit).
3150
3151         * Scripts/webkitpy/common/checkout/changelog.py:
3152         (ChangeLog.set_reviewer):
3153         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
3154         (test_set_reviewer):
3155         (test_set_short_description_and_bug_url):
3156
3157 2012-06-20  Dirk Pranke  <dpranke@chromium.org>
3158
3159         nrwt outputs empty files for wdiff output if wdiff is not installed
3160         https://bugs.webkit.org/show_bug.cgi?id=88709
3161
3162         Reviewed by Tony Chang.
3163
3164         Reviewed by Tony Chang.
3165
3166         Don't write -wdiff or -pretty.html files if wdiff or prettypatch
3167         aren't available, and clean up the handling for them in the port
3168         code.
3169
3170         * Scripts/webkitpy/run_webkit_tests_integrationtest.py:
3171         (MainTest.test_output_diffs):
3172         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
3173         (TestResultWriter.create_text_diff_and_write_result):
3174         * Scripts/webkitpy/layout_tests/port/base.py:
3175         (Port.check_pretty_patch):
3176         (Port.check_wdiff):
3177         (Port._wdiff_missing_message):
3178         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3179         (ChromiumLinuxPort.check_build):
3180         (ChromiumLinuxPort._wdiff_missing_message):
3181         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3182         (ChromiumMacPort.check_build):
3183         (ChromiumMacPort):
3184         (ChromiumMacPort._wdiff_missing_message):
3185         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
3186         (ChromiumMacPortTest):
3187
3188 2012-06-20  Dirk Pranke  <dpranke@chromium.org>
3189
3190         nrwt: fix unit tests for ensuring svn revision is correct
3191         https://bugs.webkit.org/show_bug.cgi?id=89498
3192
3193         Reviewed by Eric Seidel.
3194
3195         Reviewed by Eric Seidel.
3196
3197         Fix the unit tests for testing that we are embedding the SVN
3198         revision in the results json for NRWT properly; this was broken
3199         in r120646 but because the MockHost worked differently than the
3200         real one (by always initializing the MockSCM object) we didn't
3201         notice. Unfortunately, just changing the default breaks all
3202         sorts of unit tests ...
3203
3204         * Scripts/webkitpy/common/host_mock.py:
3205         (MockHost.__init__):
3206         (MockHost._initialize_scm):
3207         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
3208         (ResultSummaryTest.test_no_svn_revision):
3209         (ResultSummaryTest.test_svn_revision):
3210
3211 2012-06-20  Dirk Pranke  <dpranke@chromium.org>
3212
3213         new-run-webkit-tests appends "/Debug" or "/Release" to $WEBKITOUTPUTDIR
3214         https://bugs.webkit.org/show_bug.cgi?id=69360
3215
3216         Reviewed by Eric Seidel.
3217
3218         Reviewed by Eric Seidel.
3219
3220         Propagate the 'port_implementation' part of the platform (i.e.,
3221         gtk,qt,chromium) to webkit-build-directory so that we can pick
3222         up the gtk-specific handling of WEBKITOUTPUTDIR ...
3223
3224         I didn't write any additional tests for this; testing it
3225         properly is an integration test between the python code and the
3226         perl code, which I verified by hand.
3227
3228         * Scripts/webkitpy/layout_tests/port/base.py:
3229         (Port.__init__):
3230         * Scripts/webkitpy/layout_tests/port/config.py:
3231         (Config.__init__):
3232         (Config.build_directory):
3233         * Scripts/webkitpy/layout_tests/port/config_mock.py:
3234         (MockConfig.__init__):
3235         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
3236         (ConfigTest.test_build_directory_passes_port_implementation):
3237
3238 2012-06-20  Dirk Pranke  <dpranke@chromium.org>
3239
3240         Fix import sorting missed in r120846
3241
3242         Reviewed by Tony Chang.
3243
3244         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
3245
3246 2012-06-20  Dirk Pranke  <dpranke@chromium.org>
3247
3248         Fix chromium win http servers after breakage introduced in r120846.
3249
3250         Unreviewed, build fix.
3251
3252         * Scripts/webkitpy/layout_tests/port/base.py:
3253         (Port.to.start_http_server):
3254         * Scripts/webkitpy/layout_tests/servers/http_server.py:
3255         (Lighttpd.__init__):
3256
3257 2012-06-20  Dirk Pranke  <dpranke@chromium.org>
3258
3259         tweak output of webkit-patch print-{baselines,expectations}
3260         https://bugs.webkit.org/show_bug.cgi?id=89588
3261
3262         Reviewed by Tony Chang.
3263
3264         Minor tweaks to the output to make it more readable, including
3265         turning off csv by default for print-baselines with multiple ports.
3266
3267         * Scripts/webkitpy/layout_tests/port/test.py:
3268         (TestPort):
3269         * Scripts/webkitpy/tool/commands/queries.py:
3270         (PrintExpectations.execute):
3271         (PrintBaselines.execute):
3272         * Scripts/webkitpy/tool/commands/queries_unittest.py:
3273         (PrintExpectationsTest.run_test):
3274         (PrintExpectationsTest.test_multiple):
3275         (PrintBaselinesTest.setUp):
3276         (PrintBaselinesTest.test_multiple):
3277
3278 2012-06-18  Dirk Pranke  <dpranke@chromium.org>
3279
3280         new-run-webkit-tests should spin-up enough httpd processes to avoid timeouts
3281         https://bugs.webkit.org/show_bug.cgi?id=88134
3282
3283         Reviewed by Tony Chang.
3284
3285         Change NRWT to spin up 2*min(child_processes, locked_shards)
3286         http servers by default so that we are less likely to get a
3287         bunch of http timeouts at the beginning of a test run.
3288
3289         Note that I had to tweak executive_mock to support mocked stderr
3290         because the apache_http_server code reads stderr when starting a
3291         process to ensure it started okay.
3292
3293         * Scripts/webkitpy/common/system/executive_mock.py:
3294         (MockProcess.__init__):
3295         * Scripts/webkitpy/common/system/outputcapture.py:
3296         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3297         (Manager._run_tests):
3298         (Manager.start_servers_with_lock):
3299         * Scripts/webkitpy/layout_tests/port/base.py:
3300         (Port.to.start_http_server):
3301         * Scripts/webkitpy/layout_tests/port/test.py:
3302         (TestPort.start_http_server):
3303         (TestPort._path_to_apache):
3304         (TestPort):
3305         (TestPort._path_to_apache_config_file):
3306         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
3307         (LayoutTestApacheHttpd.__init__):
3308         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py: Added
3309         (LayoutTestApacheHttpd.__init__):
3310         * Scripts/webkitpy/layout_tests/servers/http_server.py:
3311         (Lighttpd.__init__):
3312         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
3313         (HttpServerBase.__init__):
3314
3315 2012-06-20  Tom Zakrajsek  <tomz@codeaurora.org>
3316
3317         Unreviewed: Back out accidentally checked in debug print which broke a test
3318
3319         * Scripts/webkitpy/performance_tests/perftest.py:
3320         (PerfTest.parse_output):
3321
3322 2012-06-20  Tom Zakrajsek  <tomz@codeaurora.org>
3323
3324         Import themaninblue.com/experiment/AnimationBenchmark/ as performance tests
3325         https://bugs.webkit.org/show_bug.cgi?id=78789
3326
3327         Reviewed by Ryosuke Niwa.
3328
3329         Updated parser to include fps as a valid unit.
3330
3331         * Scripts/webkitpy/performance_tests/perftest.py:
3332         (PerfTest):
3333         (PerfTest.parse_output):
3334
3335 2012-06-20  Balazs Ankes  <bank@inf.u-szeged.hu>
3336
3337         webkit-patch should add reviewer if "Reviewed by NOBODY ..." is missing
3338         https://bugs.webkit.org/show_bug.cgi?id=67935
3339
3340         Reviewed by Ryosuke Niwa.
3341
3342         * Scripts/webkitpy/common/checkout/changelog.py:
3343         (ChangeLog.set_reviewer):
3344         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
3345         (test_set_reviewer):
3346         (test_set_short_description_and_bug_url):
3347
3348 2012-06-20  Simon Hausmann  <simon.hausmann@nokia.com>
3349
3350         Unreviewed trivial permissions fix.
3351
3352         * qmake/mkspecs/features/features.prf: Don't mark this file as executable.
3353
3354 2012-06-19  Ryuan Choi  <ryuan.choi@samsung.com>
3355
3356         [EFL][Regression] Build break after r120786
3357         https://bugs.webkit.org/show_bug.cgi?id=89549
3358
3359         Unreviewed build fix for Efl port.
3360
3361         * DumpRenderTree/efl/CMakeLists.txt: Added disassembler in includes.
3362
3363 2012-06-19  Dirk Pranke  <dpranke@chromium.org>
3364
3365         NRWT spins up and down the WebSocket server when running a single HTTP test from the command line
3366         https://bugs.webkit.org/show_bug.cgi?id=64489
3367
3368         Reviewed by Tony Chang.
3369
3370         This change changes NRWT so that we don't start the websocket
3371         server if we aren't running websocket tests and don't start the
3372         HTTP server if we aren't running http tests.
3373         
3374         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3375         (Manager._websocket_tests):
3376         (Manager.start_servers_with_lock):
3377         (Manager.stop_servers_with_lock):
3378         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
3379         (ManagerTest.test_servers_started):
3380
3381 2012-06-19  Dirk Pranke  <dpranke@chromium.org>
3382
3383         test-webkitpy: add a -p flag to pass through captured output to enable debugging
3384         https://bugs.webkit.org/show_bug.cgi?id=89158
3385
3386         Reviewed by Eric Seidel.
3387
3388         Normally when outputcapture runs it intercepts stdout/stderr,
3389         which makes running under the debugger difficult and mostly
3390         pointless (since you can't see any output). This change adds a
3391         flag to test-webkitpy (-p) that will cause outputcapture to pass
3392         through the output as well as capture it.
3393
3394         * Scripts/webkitpy/common/system/outputcapture.py:
3395         (OutputCapture.stream_wrapper):
3396         (OutputCapture._capture_output_with_name):
3397         * Scripts/webkitpy/common/system/outputcapture_unittest.py:
3398         (OutputCaptureTest.setUp):
3399         * Scripts/webkitpy/test/main.py:
3400         (Tester._parse_args):
3401         (Tester._run_tests):
3402         (Tester._log_exception):
3403         (_CaptureAndPassThroughStream):
3404         (_CaptureAndPassThroughStream.__init__):
3405         (_CaptureAndPassThroughStream.write):
3406         (_CaptureAndPassThroughStream._message_is_from_pdb):
3407         (_CaptureAndPassThroughStream.flush):
3408         (_CaptureAndPassThroughStream.getvalue):
3409
3410 2012-06-19  Adam Barth  <abarth@webkit.org>
3411
3412         garden-o-matic fails to rebaseline tests with MISSING results
3413         https://bugs.webkit.org/show_bug.cgi?id=89521
3414
3415         Reviewed by Kenneth Russell.
3416
3417         If the bots report "MISSING", we should try to find PNG and TXT results on the server.
3418
3419         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
3420
3421 2012-06-19  Adam Barth  <abarth@webkit.org>
3422
3423         svn.delete_list fails to delete empty parent directories
3424         https://bugs.webkit.org/show_bug.cgi?id=89520
3425
3426         Reviewed by Dirk Pranke.
3427
3428         These functions were calling scm.delete and scm.add, which already
3429         delete the parent directory. We'd get an exception when we tried to
3430         delete the parent directory again.
3431
3432         * Scripts/webkitpy/common/checkout/scm/svn.py:
3433         (SVN._add_parent_directories):
3434         (SVN._delete_parent_directories):
3435
3436 2012-06-19  Thiago Marcos P. Santos  <thiago.santos@intel.com>
3437
3438         webkitpy: Simplify fetch_bugs_matching_search()
3439         https://bugs.webkit.org/show_bug.cgi?id=89497
3440
3441         Reviewed by Adam Barth.
3442
3443         Removed parameter with default value. It's not being used
3444         and the handling of the parameter was wrong. Saves a check.
3445
3446         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3447         (BugzillaQueries.fetch_bugs_matching_search):
3448         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
3449         (MockBugzillaQueries.fetch_bugs_matching_search):
3450
3451 2012-06-19  Dirk Pranke  <dpranke@chromium.org>
3452
3453         webkitpy: remove unneeded imports in layout_tests/port/chromium.py
3454         https://bugs.webkit.org/show_bug.cgi?id=89522
3455
3456         Reviewed by Eric Seidel.
3457
3458         They were no longer being used. No tests necessary.
3459
3460         * Scripts/webkitpy/layout_tests/port/chromium.py:
3461
3462 2012-06-19  Adam Barth  <abarth@webkit.org>
3463
3464         Missing results aren't shown in garden-o-matic
3465
3466         Reviewed by Kenneth Russell.
3467
3468         Previously we didn't know to look for text and image results when the
3469         bot told us that results were missing.
3470
3471         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
3472
3473 2012-06-19  Dirk Pranke  <dpranke@chromium.org>
3474
3475         Fix regression introduced in r120646 where the svn revision isn't saved in results.json
3476
3477         Unreviewed, build fix.
3478
3479         It turns out that we store the svn revision two different ways
3480         in the JSON, and I only caught one of them :(. This should fix
3481         the other.
3482
3483         Also, this part of the code is poorly tested. I will investigate
3484         adding at least a basic test for this in a separate fix.
3485
3486         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3487         (summarize_results):
3488
3489 2012-06-19  Dirk Pranke  <dpranke@chromium.org>
3490
3491         REGRESSION (NRWT): Results for new non-text-only tests are always put in the most-specific platform directory
3492         https://bugs.webkit.org/show_bug.cgi?id=78127
3493
3494         Reviewed by Ryosuke Niwa.
3495
3496         Add the --add-platform-exceptions flag from ORWT, and ensure
3497         that --new-baseline is equivalent to --reset-results
3498         --add-platform-exceptions. Also fix the default logic for where to
3499         put PNGs and render tree dumps if --new-test-results is true:
3500         if --add-platform-exceptions is False, baselines should go in
3501         the least-specific platform directory (e.g., platform/mac)
3502         rather than the most-specific (platform/mac-snowleopard).
3503
3504         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
3505         (SingleTestRunner):
3506         (SingleTestRunner.run):
3507         (SingleTestRunner._run_rebaseline):
3508         (SingleTestRunner._add_missing_baselines):
3509         (SingleTestRunner._location_for_new_baseline):
3510         (SingleTestRunner._overwrite_baselines):
3511         (SingleTestRunner._save_baseline_data):
3512         * Scripts/webkitpy/layout_tests/port/base.py:
3513         (Port.baseline_path):
3514         (Port):
3515         (Port.baseline_platform_dir):
3516         (Port.baseline_version_dir):
3517         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3518         (_set_up_derived_options):
3519         (parse_args):
3520         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3521         (RebaselineTest.assertBaselines):
3522         (RebaselineTest.test_reset_results):
3523         (RebaselineTest.test_missing_results):
3524         (RebaselineTest.test_new_baseline):
3525
3526 2012-06-19  Dirk Pranke  <dpranke@chromium.org>
3527
3528         NRWT should not take memory used as disk cache into account when deciding how many processes to launch
3529         https://bugs.webkit.org/show_bug.cgi?id=81379
3530
3531         Reviewed by Eric Seidel.
3532
3533         The 'free memory' calculation we were running on the mac seemed
3534         to underestimate how many children we can run in parallel, and
3535         it was complex. This patch replaces that calculation with a
3536         simpler one that reserves 2GB for overhead and assumes 256MB per
3537         DRT/WTR, so if we had 4GB of RAM we can run up to 8 DRTs.
3538
3539         Also, there was a bug where we were truncating the memory
3540         installed on the machine to 4GB by casting to an int instead of
3541         a long; this was probably the source of some of the earlier
3542         problems when using total memory.
3543
3544         This patch also removes the no-longer-needed restrictions on the
3545         number of workers on beefy Lion boxes for both Apple Mac and Chromium
3546         Mac; we should now use all of the cores by default.
3547
3548         The memory calculations have only been implemented on the mac;
3549         having the calculation in base.default_child_processes() was IMO
3550         misleading, and so this patch also moves the computation into
3551         the MacPort. I have not heard of the # of workers being an issue
3552         on any other ports, so this should be fine.
3553
3554         * Scripts/webkitpy/common/system/platforminfo.py:
3555         (PlatformInfo.total_bytes_memory):
3556         * Scripts/webkitpy/common/system/platforminfo_mock.py:
3557         (PlatformInfo.total_bytes_memory):
3558         (PlatformInfo.total_bytes_memory):
3559         (PlatformInfo._win_version_tuple_from_cmd):
3560         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
3561         (TestPlatformInfo.test_total_bytes_memory):
3562         * Scripts/webkitpy/layout_tests/port/base.py:
3563         (Port.default_child_processes):
3564         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3565         (PortTest.test_default_child_processes):
3566         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3567         (ChromiumMacPort.operating_system):
3568         * Scripts/webkitpy/layout_tests/port/mac.py:
3569         (MacPort.default_child_processes):
3570         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3571         (TestMacPort.test_default_child_processes):
3572
3573 2012-06-19  Dirk Pranke  <dpranke@chromium.org>
3574
3575         new-run-webkit-tests reports unexpected pass of pixel tests when pixel testing is disabled
3576         https://bugs.webkit.org/show_bug.cgi?id=85446
3577
3578         Reviewed by Simon Fraser.
3579
3580         Embed whether pixel testing was enabled into the results.json.
3581
3582         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3583         (summarize_results):
3584
3585 2012-06-19  Zoltan Horvath  <zoltan@webkit.org>
3586
3587         [Qt] Modify HTTPS port to 8443 for performance tests
3588         https://bugs.webkit.org/show_bug.cgi?id=89442
3589
3590         Reviewed by Ryosuke Niwa.
3591
3592         We should be consistent with the default HTTPS port and with the changelog of r119188.
3593
3594         * Scripts/webkitpy/performance_tests/perftest.py:
3595         (ReplayServer.__init__):
3596
3597 2012-06-19  Mike West  <mkwst@chromium.org>
3598
3599         Introduce ENABLE_CSP_NEXT configuration flag.
3600         https://bugs.webkit.org/show_bug.cgi?id=89300
3601
3602         Reviewed by Adam Barth.
3603
3604         The 1.0 draft of the Content Security Policy spec is just about to
3605         move to Last Call. We'll hide work on the upcoming 1.1 spec behind
3606         this ENABLE flag, disabled by default.
3607
3608         Spec: https://dvcs.w3.org/hg/content-security-policy/raw-file/tip/csp-specification.dev.html
3609
3610         * Scripts/webkitperl/FeatureList.pm:
3611         * qmake/mkspecs/features/features.pri:
3612
3613 2012-06-19  Christophe Dumez  <christophe.dumez@intel.com>
3614
3615         [EFL] EFL's LayoutTestController does not support setTextDirection
3616         https://bugs.webkit.org/show_bug.cgi?id=87481
3617
3618         Reviewed by Hajime Morita.
3619
3620         Implement setTextDirection in EFL's LayoutTestController and
3621         properly reset its value between test cases to avoid flakiness.
3622
3623         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3624         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
3625         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
3626         (LayoutTestController::setTextDirection):
3627
3628 2012-06-19  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
3629
3630         [Qt] Temporarily disable xvfb driver in nrwt
3631         https://bugs.webkit.org/show_bug.cgi?id=88414
3632
3633         Reviewed by Csaba Osztrogonác.
3634
3635         * Scripts/webkitpy/layout_tests/port/qt.py:
3636         (QtPort._build_driver):
3637
3638 2012-06-18  Joone Hur  <joone.hur@intel.com>
3639
3640         [EFL] Fontconfig can't be linked properly
3641         https://bugs.webkit.org/show_bug.cgi?id=89418
3642
3643         Unreviewed build fix.
3644
3645         Make Fontconfig be linked correctly.
3646
3647         * MiniBrowser/efl/CMakeLists.txt: add FONTCONFIG_LIBRARIES to MiniBrowser_LIBRARIES.
3648
3649 2012-06-18  Joone Hur  <joone.hur@intel.com>
3650
3651         Unreviewed. Updating email for committers.py script.
3652
3653         * Scripts/webkitpy/common/config/committers.py:
3654
3655 2012-06-18  Simon Fraser  <simon.fraser@apple.com>
3656
3657         Fix a typo that caused TestFailures to have a syntax error.
3658         
3659         Sadly TestFailures is broken for another reason now too:
3660         https://bugs.webkit.org/show_bug.cgi?id=89419
3661
3662         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ViewController.js:
3663         (ViewController.prototype._domForBuildName):
3664
3665 2012-06-18  Simon Fraser  <simon.fraser@apple.com>
3666
3667         Provide bug links for suspicious commits
3668         https://bugs.webkit.org/show_bug.cgi?id=89408
3669         
3670         Reviewed by Adam Barth.
3671
3672         Add links to bugs for the suspicious commits if we have bug data.
3673
3674         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Bugzilla.js:
3675         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
3676         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
3677         (ol.notifications>li ul.causes>li>div.description>span>span.bugID::before):
3678         (ol.notifications>li ul.causes>li>div.description>span>span.bugID>a):
3679
3680 2012-06-18  Amy Ousterhout  <aousterh@chromium.org>
3681
3682         [Chromium] DeviceOrientation Cleanup
3683         https://bugs.webkit.org/show_bug.cgi?id=89354
3684
3685         Reviewed by Kent Tamura.
3686
3687         * DumpRenderTree/chromium/WebViewHost.h: added OVERRIDE specifier for virtual function
3688         (WebViewHost):
3689
3690 2012-06-18  James Robinson  <jamesr@chromium.org>
3691
3692         [chromium] Stop passing deprecated 'direct' parameter to webkit_support::CreateGraphicsContext3D
3693         https://bugs.webkit.org/show_bug.cgi?id=89254
3694
3695         Reviewed by Adrienne Walker.
3696
3697         This parameter doesn't mean anything since this codepath is only used for onscreen contexts and is deprecated
3698         upstream.
3699
3700         * DumpRenderTree/chromium/WebViewHost.cpp:
3701         (WebViewHost::createGraphicsContext3D):
3702
3703 2012-06-18  Simon Fraser  <simon.fraser@apple.com>
3704
3705         Minor fix suggested by Adam Barth.
3706
3707         Use $(this._what).empty(); rather than removing children one at a time.
3708         For some reason removeAllChildren() is undefined on this node.
3709         
3710         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
3711
3712 2012-06-18  Simon Fraser  <simon.fraser@apple.com>
3713
3714         Show TOT revision in garden-o-matic, and make the revisions into links
3715         https://bugs.webkit.org/show_bug.cgi?id=89396
3716
3717         Reviewed by Adam Barth.
3718
3719         The "latest revision" notification now reads "Latest revision processed by every bot: NN (trunk is at NN)"
3720         where the revisions are links to trac.
3721         
3722         To avoid setting innerHTML, I made base.createLinkNode() and used it in a bunch of places, which had
3723         the knock-on effect of flipping the target and href attributes for anchors in some test output.
3724
3725         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ViewController.js:
3726         (ViewController.prototype._displayTesters.updateList.list):
3727         (ViewController.prototype._displayTesters.updateList):
3728         (ViewController.prototype._domForRegressionRange.trac.commitDataForRevisionRange):
3729         (ViewController.prototype._domForRegressionRange):
3730         (ViewController.prototype._domForAuxiliaryUIElements):
3731         (ViewController.prototype._domForBuildName):
3732         (ViewController.prototype):
3733         (ViewController.prototype.):
3734         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
3735         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
3736         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
3737         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
3738         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
3739
3740 2012-06-18  Csaba Osztrogonác  <ossy@webkit.org>
3741
3742         REGRESSION(r100558): NRWT should work without SVN or GIT
3743         https://bugs.webkit.org/show_bug.cgi?id=76630
3744
3745         Reviewed by Dirk Pranke.
3746
3747         NRWT is not supposed to have a requirement that we have an
3748         actual SVN or Git checkout, and we were unnecessarily
3749         initializing the checkout. This patch removes that line :).
3750
3751         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3752         (main):
3753
3754 2012-06-18  Zan Dobersek  <zandobersek@gmail.com>
3755
3756         [garden-o-matic] Add support for the GTK builders
3757         https://bugs.webkit.org/show_bug.cgi?id=89360
3758
3759         Reviewed by Adam Barth.
3760
3761         Add the 'gtk' platform, essentially a copy of the 'apple' platform since
3762         both get their data from build.webkit.org.
3763
3764         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
3765         (.):
3766
3767 2012-06-18  Nico Weber  <thakis@chromium.org>
3768
3769         [chromium/mac] Unbreak smooth scrolling.
3770         https://bugs.webkit.org/show_bug.cgi?id=89327
3771
3772         Reviewed by Dimitri Glazkov.
3773
3774         Broken by Sam in r115589 / r115591.
3775
3776         * DumpRenderTree/mac/DumpRenderTree.mm:
3777         (resetDefaultsToConsistentValues):
3778         * TestWebKitAPI/mac/InjectedBundleControllerMac.mm:
3779         (TestWebKitAPI::InjectedBundleController::platformInitialize):
3780         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
3781         (WTR::InjectedBundle::platformInitialize):
3782
3783 2012-06-18  Sheriff Bot  <webkit.review.bot@gmail.com>
3784
3785         Unreviewed, rolling out r120541, r120547, and r120548.
3786         http://trac.webkit.org/changeset/120541
3787         http://trac.webkit.org/changeset/120547
3788         http://trac.webkit.org/changeset/120548
3789         https://bugs.webkit.org/show_bug.cgi?id=89383
3790
3791         This approach doesn't work for WebKit2 (Requested by abarth on
3792         #webkit).
3793
3794         * DumpRenderTree/LayoutTestController.cpp:
3795         (setBackingScaleFactorCallback):
3796         (LayoutTestController::staticFunctions):
3797         * DumpRenderTree/LayoutTestController.h:
3798         (LayoutTestController):
3799         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
3800         (LayoutTestController::setBackingScaleFactor):
3801         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
3802         (LayoutTestController::setBackingScaleFactor):
3803         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3804         (LayoutTestController::setBackingScaleFactor):
3805         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3806         (LayoutTestController::setBackingScaleFactor):
3807         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3808         (LayoutTestController::setBackingScaleFactor):
3809         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3810         (LayoutTestController::setBackingScaleFactor):
3811         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
3812         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3813         (WTR::InjectedBundle::didReceiveMessage):
3814         (WTR::InjectedBundle::postSetBackingScaleFactor):
3815         (WTR):
3816         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3817         (InjectedBundle):
3818         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3819         (WTR::LayoutTestController::setBackingScaleFactor):
3820         (WTR):
3821         (WTR::LayoutTestController::callSetBackingScaleFactorCallback):
3822         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3823         (LayoutTestController):
3824         * WebKitTestRunner/TestInvocation.cpp:
3825         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3826
3827 2012-06-18  Zan Dobersek  <zandobersek@gmail.com>
3828
3829         REGRESSION(r120546): It made 3 webkitpy tests fail
3830         https://bugs.webkit.org/show_bug.cgi?id=89332
3831
3832         Reviewed by Adam Barth.
3833
3834         Update the BaselineOptimizer unittest after r120546.
3835
3836         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
3837         (BaselineOptimizerTest.test_no_add_mac_future):
3838         (BaselineOptimizerTest.test_mac_future):
3839         (BaselineOptimizerTest.test_complex_shadowing):
3840
3841 2012-06-18  Dirk Pranke  <dpranke@chromium.org>
3842
3843         new-run-webkit-tests output gets confused when logging
3844         https://bugs.webkit.org/show_bug.cgi?id=63793
3845
3846         Reviewed by Adam Barth.
3847
3848         Ship all of the log messages generated in the worker back
3849         to the manager; this allows the messages to be properly
3850         serialized to stderr and for the meter to flush its output correctly.
3851
3852         Note however that this will likely result in messages to be
3853         logged out of order between workers; I'm not sure that there's
3854         an easy way to fix this short of buffering a potentially
3855         unbounded amount of data. It might be better to just log through
3856         stderr unless we're in 'metering' mode, but it's also worth
3857         noting that we already get messages out of order through stderr
3858         on Windows.
3859
3860         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3861         (Manager.handle_done):
3862         (Manager.handle_finished_test):
3863         (Manager._log_messages):
3864         * Scripts/webkitpy/layout_tests/controllers/worker.py:
3865         (Worker.__init__):
3866         (Worker._set_up_logging):
3867         (Worker.run):
3868         (Worker._run_test):
3869         (Worker.cleanup):
3870         (Worker.run_single_test):
3871         (_WorkerLogHandler):
3872         (_WorkerLogHandler.__init__):
3873         (_WorkerLogHandler.emit):
3874         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
3875         (MeteredStream.write):
3876         (MeteredStream.writeln):
3877         * Scripts/webkitpy/layout_tests/views/printing.py:
3878         (Printer.writeln):
3879
3880 2012-06-18  Zan Dobersek  <zandobersek@gmail.com>
3881
3882         [garden-o-matic] Builder names without underscores cause incorrect BuildSelector behavior
3883         https://bugs.webkit.org/show_bug.cgi?id=89362
3884
3885         Reviewed by Simon Fraser.
3886
3887         Replace white spaces, braces and dots in the builder name with underscores. This
3888         way the JQuery tabs will be properly matched with the according container.
3889
3890         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
3891
3892 2012-06-18  Dirk Pranke  <dpranke@chromium.org>
3893
3894         nrwt: metered output doesn't handle ^C cleanly
3895         https://bugs.webkit.org/show_bug.cgi?id=89249
3896
3897         Reviewed by Tony Chang.
3898
3899         If you ctrl-c a running nrwt (w/o --verbose), then all but
3900         two characters of the last update are erased, and then we print
3901         "interrupted, exiting" as an update, which itself then gets
3902         erased. Fix this so that we flush the meter (making the last
3903         update persistent, so that we print the ^C for a visual clue),
3904         print the interrupt message, and move on ...
3905
3906         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3907         (Manager._run_tests):
3908         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
3909         (MeteredStream.flush):
3910         * Scripts/webkitpy/layout_tests/views/printing.py:
3911         (Printer._write):
3912         (Printer):
3913         (Printer.flush):
3914
3915 2012-06-18  Xianzhu Wang  <wangxianzhu@chromium.org>
3916
3917         [Chromium] Change back "linuxish" to "linux" and include WebFontRendering.cpp on Android
3918         https://bugs.webkit.org/show_bug.cgi?id=89228
3919
3920         Reviewed by Tony Chang.
3921
3922         * DumpRenderTree/chromium/LayoutTestController.cpp:
3923         * DumpRenderTree/chromium/TestShellAndroid.cpp:
3924
3925 2012-06-18  Mario Sanchez Prada  <msanchez@igalia.com>
3926
3927         [GTK] Get rid of DumpRenderTreeSupportGtk::{in|de}crementAccessibilityValue
3928         https://bugs.webkit.org/show_bug.cgi?id=89226
3929
3930         Reviewed by Martin Robinson.
3931
3932         Implement increment() and decrement() functions in term of the AtkValue interface,
3933         instead of using DumpRenderTreeSupportGtk helper class.
3934
3935         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3936         (AccessibilityUIElement::intValue):
3937         (AccessibilityUIElement::minValue):
3938         (AccessibilityUIElement::maxValue):
3939         (alterCurrentValue):
3940         (AccessibilityUIElement::increment):
3941         (AccessibilityUIElement::decrement):
3942
3943 2012-06-17  Simon Fraser  <simon.fraser@apple.com>
3944
3945         garden-o-matic 'Results' panel is broken for the Apple platform
3946         https://bugs.webkit.org/show_bug.cgi?id=89310
3947
3948         Reviewed by Adam Barth.
3949         
3950         For platforms that don't use accumulated build directories on the server,
3951         carry along buildLocation data with buildInfo, so that we know where to
3952         look for the test results files for a given test.
3953         
3954         Renamed historicalResultsSummaryURLs to historicalResultsLocations because
3955         it now returns an array of objects with buildNumber, revision and url info.
3956         
3957         Fixed results.fetchResultsURLs() to use this data to find results.
3958         
3959         Fixed the results display to not scroll when you click on a test to see the results.
3960         Made the h3s look less ugly
3961         
3962         Don't try to show the flakiness dashboard for the Apple platform.
3963
3964         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
3965         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
3966         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
3967         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
3968         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
3969         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
3970         (.results-view .top-panel):
3971         (.results-view h3):
3972
3973 2012-06-16  Simon Fraser  <simon.fraser@apple.com>
3974
3975         Make garden-o-matic work for the Apple Mac port
3976         https://bugs.webkit.org/show_bug.cgi?id=84642
3977
3978         Reviewed by Adam Barth.
3979         
3980         Make garden-o-matic work for the Apple, webkit.org-hosted builders and testers. This involved
3981         educating the scripts in various ways:
3982         * Wrap up platform-related differences in config.kPlatforms[]
3983         * Add a <select> to switch between platforms, and support a url parameter, ?platform=chromium/apple
3984         * The webkit.org bots don't accumulate test results into a single directory like the chromium.org ones do,
3985           so add config.haveBuilderAccumulatedResults and logic in fetchResultsByBuilder() to find the most
3986           recent build with valid results.
3987         * The webkit.org bots often generate results directories with no layout test data (e.g. when testers
3988           try to test a build that has already been deleted). Make walkHistory() more robust here.
3989         * webkit.org uses differently named test result directories, that include the SVN revision as
3990           well as the build number. That forces us to fetch more build info before we can get the
3991           result directory URL.
3992         * chromium.org serves raw directory listings for a builder's results directories. webkit.org serves
3993           those with Twisted, so rather than scrape directory listings, we use buildbot JSON to find results
3994           dirs.
3995         * Various URLs differ between webkit.org and chromium.org
3996         * Better UI for the failures info, so that some info is visible even when not hovered.
3997
3998         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
3999         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/LayoutTestResultsLoader.js:
4000         (LayoutTestResultsLoader.prototype.set _fetchAndParseNRWTResults):
4001         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
4002         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
4003         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
4004         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/net.js:
4005         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
4006         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
4007         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary-mock.js:
4008         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
4009         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
4010         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
4011         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/perf.js:
4012         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
4013         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
4014         (ol.notifications>li table.failures):
4015         (ol.notifications>li:hover table.failures):
4016         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css:
4017         (#onebar #platform-picker):
4018         * Scripts/webkitpy/layout_tests/port/builders.py:
4019
4020 2012-06-16  Sheriff Bot  <webkit.review.bot@gmail.com>
4021
4022         Unreviewed, rolling out r120536.
4023         http://trac.webkit.org/changeset/120536
4024         https://bugs.webkit.org/show_bug.cgi?id=89296
4025
4026         Does not compile on chromium-linux (Requested by abarth on
4027         #webkit).
4028
4029         * DumpRenderTree/chromium/LayoutTestController.cpp:
4030         (LayoutTestController::reset):
4031         (LayoutTestController::setTextSubpixelPositioning):
4032         * DumpRenderTree/chromium/TestShellAndroid.cpp:
4033
4034 2012-06-16  Adam Barth  <abarth@webkit.org>
4035
4036         layoutTestController.setBackingScaleFactor is redundant with (and less awesome than) internals.settings.setDeviceScaleFactor
4037         https://bugs.webkit.org/show_bug.cgi?id=89274
4038
4039         Reviewed by Levi Weintraub.
4040
4041         Delete (mostly stub) implementations of layoutTestController.setBackingScaleFactor.
4042         Note: The WebKit2 API that setBackingScaleFactor exercises is still
4043         tested by API-level tests.
4044
4045         * DumpRenderTree/LayoutTestController.cpp:
4046         (LayoutTestController::staticFunctions):
4047         * DumpRenderTree/LayoutTestController.h:
4048         (LayoutTestController):
4049         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
4050         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
4051         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
4052         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
4053         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
4054         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
4055         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
4056         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
4057         (WTR::InjectedBundle::didReceiveMessage):
4058         (WTR):
4059         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
4060         (InjectedBundle):
4061         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
4062         (WTR):
4063         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
4064         (LayoutTestController):
4065         * WebKitTestRunner/TestInvocation.cpp:
4066         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
4067
4068 2012-06-16  Xianzhu Wang  <wangxianzhu@chromium.org>
4069
4070         [Chromium] Move chromium/public/linuxish/WebFontRendering.h out of linuxish directory
4071         https://bugs.webkit.org/show_bug.cgi?id=89228
4072
4073         Reviewed by Tony Chang.
4074
4075         * DumpRenderTree/chromium/LayoutTestController.cpp:
4076         (LayoutTestController::reset):
4077         (LayoutTestController::setTextSubpixelPositioning):
4078         * DumpRenderTree/chromium/TestShellAndroid.cpp:
4079
4080 2012-06-15  Adam Barth  <abarth@webkit.org>
4081
4082         garden-o-matic's results.js should use RequestTracker
4083         https://bugs.webkit.org/show_bug.cgi?id=89257
4084
4085         Reviewed by Dimitri Glazkov.
4086
4087         We wrote results.js before we recognized the RequestTracker pattern.
4088         This patch replaces the manual implementations of RequestTracker with
4089         the real deal.
4090
4091         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
4092
4093 2012-06-15  Darin Adler  <darin@apple.com>
4094
4095         * Scripts/webkitpy/bindings: Added property svn:ignore.
4096
4097 2012-06-15  Sheriff Bot  <webkit.review.bot@gmail.com>
4098
4099         Unreviewed, rolling out r120511.
4100         http://trac.webkit.org/changeset/120511
4101         https://bugs.webkit.org/show_bug.cgi?id=89255
4102
4103         Breaks at least Android builder (Requested by wangxianzhu on
4104         #webkit).
4105
4106         * DumpRenderTree/chromium/LayoutTestController.cpp:
4107         (LayoutTestController::reset):
4108         (LayoutTestController::setTextSubpixelPositioning):
4109
4110 2012-06-15  Xianzhu Wang  <wangxianzhu@chromium.org>
4111
4112         [Chromium] Move chromium/public/linuxish/WebFontRendering.h out of linuxish directory
4113         https://bugs.webkit.org/show_bug.cgi?id=89228
4114
4115         Reviewed by Tony Chang.
4116
4117         * DumpRenderTree/chromium/LayoutTestController.cpp:
4118         (LayoutTestController::reset):
4119         (LayoutTestController::setTextSubpixelPositioning):
4120
4121 2012-06-15  Dirk Pranke  <dpranke@chromium.org>
4122
4123         webkitpy: remove DummyOptions and clean up the code in Port.get_option() and Port.set_option_default()
4124         https://bugs.webkit.org/show_bug.cgi?id=89135
4125
4126         Re-land change in r120370 with fix in
4127         PortFactory.get_from_builder_name() that changes BuilderOptions
4128         to an actual optparse.Values object.
4129
4130         * Scripts/webkitpy/layout_tests/port/base.py:
4131         (Port.__init__):
4132         (Port.get_option):
4133         (Port.set_option_default):
4134         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
4135         (ChromiumWinTest.test_setup_environ_for_server_register_cygwin):
4136         * Scripts/webkitpy/layout_tests/port/factory.py:
4137         (_builder_options):
4138         (PortFactory.get_from_builder_name):
4139         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
4140         (FactoryTest.test_get_from_builder_name):
4141         * Scripts/webkitpy/style/checkers/test_expectations.py:
4142         (TestExpectationsChecker._determine_port_from_expectations_path):
4143         * Scripts/webkitpy/tool/mocktool.py:
4144         (MockOptions.ensure_value):
4145
4146 2012-06-15  Bill Budge  <bbudge@chromium.org>
4147
4148         Add bbudge@chromium.org to committers.py
4149
4150         Unreviewed.
4151
4152         * Scripts/webkitpy/common/config/committers.py:
4153
4154 2012-06-15  Csaba Osztrogonác  <ossy@webkit.org>
4155
4156         Unreviewed style fix after r120351.
4157
4158         * BuildSlaveSupport/build.webkit.org-config/public_html/default.css:
4159         (body.interface):
4160
4161 2012-06-15  Csaba Osztrogonác  <ossy@webkit.org>
4162
4163         master.cfg cleanup, remove unnecessary workaround
4164         https://bugs.webkit.org/show_bug.cgi?id=88994
4165
4166         Reviewed by Lucas Forschler.
4167
4168         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
4169         (loadBuilderConfig):
4170
4171 2012-06-15  Dirk Pranke  <dpranke@chromium.org>
4172
4173         webkit-patch rebaseline-expectations should only rebaseline the appropriate suffixes for the failure in question
4174         https://bugs.webkit.org/show_bug.cgi?id=88581
4175
4176         Reviewed by Adam Barth.
4177
4178         Make sure we only optimize the suffixes we rebaselined during
4179         rebaseline-expectations, and not all suffixes for a test.
4180         While optimizing is somewhere between harmless and good, it's also confusing :)
4181
4182         * Scripts/webkitpy/tool/commands/rebaseline.py:
4183         (RebaselineExpectations._rebaseline_port):
4184         (RebaselineExpectations.execute):
4185         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
4186
4187 2012-06-15  Csaba Osztrogonác  <ossy@webkit.org>
4188
4189         Update builder.html template for newer buildmaster
4190         https://bugs.webkit.org/show_bug.cgi?id=89207
4191
4192         Rebasing builder.html template from v0.8.3 to v0.8.6p1.
4193
4194         Reviewed by Zoltan Herczeg.
4195
4196         * BuildSlaveSupport/build.webkit.org-config/templates/builder.html:
4197
4198 2012-06-15  Csaba Osztrogonác  <ossy@webkit.org>
4199
4200         Add ForceScheduler to build.webkit.org
4201         https://bugs.webkit.org/show_bug.cgi?id=88982
4202
4203         Reviewed by Ryosuke Niwa.
4204
4205         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
4206         (loadBuilderConfig):
4207
4208 2012-06-15  Christophe Dumez  <christophe.dumez@intel.com>
4209
4210         [EFL][WK2] Add title support to Ewk_View
4211         https://bugs.webkit.org/show_bug.cgi?id=89095
4212
4213         Reviewed by Kenneth Rohde Christiansen.
4214
4215         Update the MiniBrowser so it listens for the "title,change"
4216         signal on the view and keeps the browser window title
4217         up-to-date.
4218
4219         * MiniBrowser/efl/main.c:
4220         (on_title_changed):
4221         (browserCreate):
4222
4223 2012-06-15  Christophe Dumez  <christophe.dumez@intel.com>
4224
4225         [WK2][EFL] Implement navigation back/forward in Ewk_View
4226         https://bugs.webkit.org/show_bug.cgi?id=89173
4227
4228         Reviewed by Kenneth Rohde Christiansen.
4229
4230         Implement navigation back / forward in MiniBrowser. Use
4231         'F1' to navigate back and 'F2' to navigate forward.
4232
4233         * MiniBrowser/efl/main.c:
4234         (on_key_down):
4235
4236 2012-06-15  Christophe Dumez  <christophe.dumez@intel.com>
4237
4238         [EFL] EFL's LayoutTestController does not support titleTextDirection
4239         https://bugs.webkit.org/show_bug.cgi?id=86475
4240
4241         Reviewed by Hajime Morita.
4242
4243         Add titleTextDirection getter and setter to LayoutTestController and
4244         expose its value to JavaScript.
4245         Update the titleTextDirection value from EFL's "title,changed"
4246         callback in DumpRenderTree.
4247
4248         * DumpRenderTree/LayoutTestController.cpp:
4249         (LayoutTestController::LayoutTestController):
4250         (getTitleTextDirectionCallback):
4251         (LayoutTestController::staticValues):
4252         * DumpRenderTree/LayoutTestController.h:
4253         (LayoutTestController::titleTextDirection):
4254         (LayoutTestController::setTitleTextDirection):
4255         (LayoutTestController):
4256         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
4257         (DumpRenderTreeChrome::onFrameTitleChanged):
4258
4259 2012-06-15  Christophe Dumez  <christophe.dumez@intel.com>
4260
4261         [EFL][WK2] Implement reload / stop in Ewk_View
4262         https://bugs.webkit.org/show_bug.cgi?id=89168
4263
4264         Reviewed by Kenneth Rohde Christiansen.
4265
4266         Implement view reload / stop loading in MiniBrowser.
4267         Use 'F5' for reload and 'F6' for stopping the load.
4268
4269         * MiniBrowser/efl/main.c:
4270         (on_key_down):
4271         (browserCreate):
4272
4273 2012-06-15  Hironori Bono  <hbono@chromium.org>
4274
4275         Allow platforms to choose whether to remove markers on editing
4276         https://bugs.webkit.org/show_bug.cgi?id=88838
4277
4278         Reviewed by Hajime Morita.
4279
4280         This change implements WebViewHost::checkTextOfParagraph so DumpRenderTree can
4281         run grammar tests.
4282
4283         * DumpRenderTree/chromium/WebViewHost.cpp:
4284         (WebViewHost::checkTextOfParagraph): Implement this function with our mock spell checker and grammar checker.
4285         * DumpRenderTree/chromium/WebViewHost.h:
4286         (WebViewHost): Override WebSpellCheckClient::checkTextOfParagraph.
4287
4288 2012-06-15  Sheriff Bot  <webkit.review.bot@gmail.com>
4289
4290         Unreviewed, rolling out r120370.
4291         http://trac.webkit.org/changeset/120370
4292         https://bugs.webkit.org/show_bug.cgi?id=89183
4293
4294         Broke webkit-patch rebaseline (Requested by zdobersek on
4295         #webkit).
4296
4297         * Scripts/webkitpy/layout_tests/port/base.py:
4298         (DummyOptions):
4299         (DummyOptions.__init__):
4300         (DummyOptions.__init__.this):
4301         (Port.__init__):
4302         (Port.get_option):
4303         (Port.set_option_default):
4304         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
4305         (ChromiumWinTest.RegisterCygwinOption):
4306         (ChromiumWinTest.RegisterCygwinOption.__init__):
4307         (ChromiumWinTest.test_setup_environ_for_server_register_cygwin):
4308         * Scripts/webkitpy/style/checkers/test_expectations.py:
4309         (TestExpectationsChecker._determine_port_from_expectations_path):
4310         * Scripts/webkitpy/tool/mocktool.py:
4311         (MockOptions.update):
4312
4313 2012-06-14  Xianzhu Wang  <wangxianzhu@chromium.org>
4314
4315         [Chromium-Android] Initialize font rendering in DumpRenderTree
4316         https://bugs.webkit.org/show_bug.cgi?id=89133
4317
4318         Reviewed by Adam Barth.
4319
4320         * DumpRenderTree/chromium/LayoutTestController.cpp:
4321         (LayoutTestController::reset):
4322         (LayoutTestController::setTextSubpixelPositioning):
4323         * DumpRenderTree/chromium/TestShellAndroid.cpp:
4324         (platformInit):
4325
4326 2012-06-14  Dongwoo Im  <dw.im@samsung.com>
4327
4328         [EFL] [DRT] Reset the WebAudio setting on DumpRenderTree
4329         https://bugs.webkit.org/show_bug.cgi?id=88622
4330
4331         Reviewed by Philippe Normand.
4332
4333         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp: Reset the setting of the Web Audio feature as default.
4334         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
4335
4336 2012-06-14  Xianzhu Wang  <wangxianzhu@chromium.org>
4337
4338         [Chromium-Android] Should retry a few times when failed to start DumpRenderTree
4339         https://bugs.webkit.org/show_bug.cgi?id=89124
4340
4341         Reviewed by Dirk Pranke.
4342
4343         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
4344         (ChromiumAndroidDriver._start):
4345         (ChromiumAndroidDriver):
4346         (ChromiumAndroidDriver._start_once):
4347
4348 2012-06-14  Tony Gentilcore  <tonyg@chromium.org>
4349
4350         Update webpagereplay to 1.1.2
4351         https://bugs.webkit.org/show_bug.cgi?id=89118
4352
4353         This includes the following patch which avoids pkg_resources import errors:
4354         http://code.google.com/p/web-page-replay/source/detail?r=476
4355
4356         Reviewed by Dirk Pranke.
4357
4358         * Scripts/webkitpy/thirdparty/__init__.py:
4359         (AutoinstallImportHook._install_webpagereplay):
4360
4361 2012-06-14  Ryosuke Niwa  <rniwa@webkit.org>
4362
4363         Get rid of FAIL test expectation
4364         https://bugs.webkit.org/show_bug.cgi?id=89137
4365
4366         Reviewed by Dirk Pranke.
4367
4368         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
4369         (ResultSummaryTest.test_summarized_results_wontfix):
4370         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py:
4371         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
4372         (JSONLayoutResultsGenerator):
4373         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
4374         (result_was_expected):
4375         (suffixes_for_expectations):
4376         (TestExpectationsModel._add_test):
4377         (TestExpectations):
4378         (TestExpectations.get_rebaselining_failures):
4379         (TestExpectations.remove_configuration_from_test):
4380         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
4381         (FunctionsTest.test_result_was_expected):
4382         (FunctionsTest.test_suffixes_for_expectations):
4383         (TestExpectationSerializerTests.test_parsed_expectations_string):
4384         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
4385         (test_test_expectations):
4386         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
4387         (TestExpectationsTestCase.test_valid_expectations):
4388
4389 2012-06-14  Dirk Pranke  <dpranke@chromium.org>
4390
4391         webkitpy: remove DummyOptions and clean up the code in Port.get_option() and Port.set_option_default()
4392         https://bugs.webkit.org/show_bug.cgi?id=89135
4393
4394         Reviewed by Ryosuke Niwa.
4395
4396         This patch is just some minor cleanup and simplification. There
4397         should be no functional changes here.
4398
4399         * Scripts/webkitpy/layout_tests/port/base.py:
4400         (Port.__init__):
4401         (Port.get_option):
4402         (Port.set_option_default):
4403         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
4404         (ChromiumWinTest.test_setup_environ_for_server_register_cygwin):
4405         * Scripts/webkitpy/style/checkers/test_expectations.py:
4406         (TestExpectationsChecker._determine_port_from_expectations_path):
4407         * Scripts/webkitpy/tool/mocktool.py:
4408         (MockOptions.ensure_value):
4409
4410 2012-06-14  Ian Vollick  <vollick@chromium.org>
4411
4412         [chromium] Certain settings in CCSettings could be global
4413         https://bugs.webkit.org/show_bug.cgi?id=88384
4414
4415         Reviewed by James Robinson.
4416
4417         * DumpRenderTree/chromium/TestShell.cpp:
4418         (TestShell::TestShell):
4419         (TestShell::resetWebSettings):
4420         (TestShell::setPerTilePaintingEnabled):
4421         * DumpRenderTree/chromium/TestShell.h:
4422         (TestShell):
4423         * DumpRenderTree/chromium/WebPreferences.cpp:
4424         (WebPreferences::reset):
4425         (WebPreferences::applyTo):
4426         * DumpRenderTree/chromium/WebPreferences.h:
4427         (WebPreferences):
4428
4429 2012-06-14  Sheriff Bot  <webkit.review.bot@gmail.com>
4430
4431         Unreviewed, rolling out r120352.
4432         http://trac.webkit.org/changeset/120352
4433         https://bugs.webkit.org/show_bug.cgi?id=89120
4434
4435         It seems something is still wrong with it :/ (Requested by
4436         Ossy on #webkit).
4437
4438         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
4439         (Factory.__init__):
4440         (BuildFactory.__init__):
4441         (TestFactory.__init__):
4442         (BuildAndTestFactory.__init__):
4443         (BuildAndPerfTestFactory.__init__):
4444         (BuildAndPerfTestWebKit2Factory.__init__):
4445         (DownloadAndPerfTestFactory.__init__):
4446         (DownloadAndPerfTestWebKit2Factory.__init__):
4447
4448 2012-06-14  Jia Pu  <jpu@apple.com>
4449
4450         Mark text with text alternative with blue underline.
4451         https://bugs.webkit.org/show_bug.cgi?id=83047
4452
4453         Reviewed by NOBODY Enrica Casucci.
4454
4455         * DumpRenderTree/mac/TextInputController.m:
4456         (+[TextInputController isSelectorExcludedFromWebScript:]):</