93f200a39253c85a7506662c77c98e54b35330cb
[WebKit.git] / Tools / ChangeLog
1 2011-01-27  Dirk Pranke  <dpranke@chromium.org>
2
3         Reviewed by Mihai Parparita.
4
5         new-run-webkit-tests: turn off pixel tests correctly by default
6         for webkit-based ports. r70013 (bug 47510) used
7         port.set_option_default() to attempt to set default values, but
8         that didn't work correctly. I have removed set_option_default
9         for now since it was only being used in two places and in three
10         useless unit tests. There is a separate bug open to fix the
11         option parsing (48095), so this workaround is fine for now.
12
13         https://bugs.webkit.org/show_bug.cgi?id=53217
14
15         * Scripts/webkitpy/layout_tests/port/webkit.py:
16         * Scripts/webkitpy/layout_tests/port/base.py:
17         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
18
19 2011-01-27  Balazs Kelemen  <kbalazs@webkit.org>
20
21         Rubber-stamped by Ariya Hidayat.
22
23         Trivial crash fix in WTR.
24
25         * WebKitTestRunner/TestController.cpp:
26         (WTR::TestController::initialize): Increase the size
27         of the vector by one to be able to store the null character.
28
29 2011-01-27  Balazs Kelemen  <kbalazs@webkit.org>
30
31         Reviewed by Csaba Osztrogonác.
32
33         [Qt][WK2] WTR should be initialized in the same way as DRT
34         https://bugs.webkit.org/show_bug.cgi?id=53240
35
36         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
37         (WTR::activateFonts): Added missing initialization steps.
38
39 2011-01-27  Joone Hur <joone.hur@collabora.co.uk>
40
41         Unreviewed. 
42
43         Adding myself to committers.py.
44
45         * Scripts/webkitpy/common/config/committers.py:
46
47 2011-01-27  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
48
49         Reviewed by Csaba Osztrogonác.
50
51         [Qt] [Symbian] Move project files into Source
52         https://bugs.webkit.org/show_bug.cgi?id=52891
53
54         Fix the Symbian build after the project files
55         are moved to Source directory. On Symbian qmake
56         needs to run in the same directory where the main
57         pro files (WebKit.pro, Tools.pro) are located.
58
59         * Scripts/webkitdirs.pm: Change to the directory where the pro file
60         is located before running qmake for Symbian. Qmake on Symbian
61         does not properly honor the "-o" option, work it around by setting
62         the name of the Makefile to bld.inf.
63
64 2011-01-27  Zoltan Horvath  <zoltan@webkit.org>
65
66         Reviewed by Andreas Kling.
67
68         [Qt] Add simple zooming features to MiniBrowser
69         https://bugs.webkit.org/show_bug.cgi?id=53231
70
71         Add View menu and Zoom In, Zoom Out, Zoom Reset actions to MiniBrowser.
72
73         * MiniBrowser/qt/BrowserWindow.cpp:
74         (BrowserWindow::BrowserWindow):
75         (BrowserWindow::zoomIn):
76         (BrowserWindow::zoomOut):
77         (BrowserWindow::resetZoom):
78         (BrowserWindow::updateUserAgentList):
79         (BrowserWindow::applyZoom):
80         * MiniBrowser/qt/BrowserWindow.h:
81
82 2011-01-26  Maciej Stachowiak  <mjs@apple.com>
83
84         Reviewed by Dan Bernstein.
85
86         WebKitTestRunner needs to support layoutTestController.evaluateInWebInspector
87         https://bugs.webkit.org/show_bug.cgi?id=42319
88         
89         Add evaluateInWebInspector and other APIs needed for inspector tests to run.
90
91         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
92         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
93         (WTR::LayoutTestController::showWebInspector):
94         (WTR::LayoutTestController::closeWebInspector):
95         (WTR::LayoutTestController::evaluateInWebInspector):
96         (WTR::LayoutTestController::setTimelineProfilingEnabled):
97         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
98         * WebKitTestRunner/TestInvocation.cpp:
99         (WTR::shouldOpenWebInspector):
100         (WTR::TestInvocation::invoke):
101         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
102
103 2011-01-26  Martin Robinson  <mrobinson@igalia.com>
104
105         Reviewed by Xan Lopez.
106
107         [GTK] Pixel dumps do not include scrollbars in output images
108         https://bugs.webkit.org/show_bug.cgi?id=53216
109
110         Show scrollbars in pixel dumps. This will fix pixel dumps for tests
111         that have scrollbars.
112
113         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
114         (createBitmapContextFromWebView): Take the snapshot of the containing GtkScrolledWindow
115         instead of the web view itself.
116
117 2011-01-26  Dirk Pranke  <dpranke@chromium.org>
118
119         Reviewed by Mihai Parparita.
120
121         Fix regression introduced in r76322 ... new-run-webkit-tests
122         was attempting to save the image diff output as a UTF-8-encoded
123         file.
124
125         https://bugs.webkit.org/show_bug.cgi?id=53210
126
127         * Scripts/webkitpy/layout_tests/port/webkit.py:
128
129 2011-01-26  Sheriff Bot  <webkit.review.bot@gmail.com>
130
131         Unreviewed, rolling out r76709.
132         http://trac.webkit.org/changeset/76709
133         https://bugs.webkit.org/show_bug.cgi?id=53194
134
135         "broke python tests on non-snowleopard platforms" (Requested
136         by dpranke on #webkit).
137
138         * Scripts/webkitpy/layout_tests/port/factory.py:
139         * Scripts/webkitpy/layout_tests/port/mock_drt.py: Removed.
140         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Removed.
141
142 2011-01-26  Dirk Pranke  <dpranke@chromium.org>
143
144         Reviewed by Tony Chang.
145
146         new-run-webkit-tests: add a "mock DRT" port implementation
147         and a separate class that emulates what we expect the
148         DumpRenderTree behavior to be.
149
150         This will eventually replace port/dryrun.py and allow us to get
151         better test coverage of the new-run-webkit-tests code as well as
152         a reference for what new-run-webkit-tests expects from DRT.
153
154         This is the first attempt at this, and it is pretty bare-boned. It
155         really only has been tested on the 'mac' port (and a little on
156         the 'chromium-mac' port.
157
158         https://bugs.webkit.org/show_bug.cgi?id=53126
159
160         * Scripts/webkitpy/layout_tests/port/mock_drt.py: Added.
161         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Added.
162         * Scripts/webkitpy/layout_tests/port/factory.py:
163
164 2011-01-26  Xianzhu Wang  <wangxianzhu@google.com>
165
166         Reviewed by Tony Chang.
167
168         Add '--no-timeout' option to Chromium DRT to ease debugging.
169         https://bugs.webkit.org/show_bug.cgi?id=52873
170
171         * DumpRenderTree/chromium/DumpRenderTree.cpp:
172         (main):
173
174 2011-01-26  Csaba Osztrogonác  <ossy@webkit.org>
175
176         Reviewed by Andreas Kling.
177
178         [Qt] Fix qt_minimal build
179         https://bugs.webkit.org/show_bug.cgi?id=53172
180
181         * QtTestBrowser/locationedit.h:
182
183 2011-01-26  Mansi Mithal  <mansi.mithal@nokia.com>
184
185         Reviewed by Antonio Gomes.
186
187         QtTestBrowser should have a UI Setting to disable plugins
188         https://bugs.webkit.org/show_bug.cgi?id=52408
189         
190         Added a new action item named "Disable Plugins"
191         under the "Settings" menu. 
192
193         * QtTestBrowser/launcherwindow.cpp:
194         (LauncherWindow::createChrome):
195         (LauncherWindow::togglePlugins):
196         * QtTestBrowser/launcherwindow.h:
197
198 2011-01-25  Patrick Gansterer  <paroga@webkit.org>
199
200         Reviewed by Adam Barth.
201
202         Move main CMakeLists.txt into Source directory
203         https://bugs.webkit.org/show_bug.cgi?id=52888
204
205         * Scripts/webkitdirs.pm:
206
207 2011-01-25  Patrick Gansterer  <paroga@webkit.org>
208
209         Reviewed by Eric Seidel.
210
211         Improve label text in submit-to-ews
212         https://bugs.webkit.org/show_bug.cgi?id=53130
213
214         * QueueStatusServer/templates/submittoews.html:
215
216 2011-01-25  Mansi Mithal  <mansi.mithal@nokia.com>
217
218         Reviewed by Antonio Gomes.
219
220         QtTestBrowser should have a UI Settings to prevent loading images
221         https://bugs.webkit.org/show_bug.cgi?id=52409
222         
223         Added a new action item named "DisableAutoLoadImages"
224         under the "Settings" menu 
225
226         * QtTestBrowser/launcherwindow.cpp:
227         (LauncherWindow::createChrome):
228         (LauncherWindow::toggleAutoLoadImages):
229         * QtTestBrowser/launcherwindow.h:
230
231 2011-01-25  Dirk Pranke  <dpranke@chromium.org>
232
233         Reviewed by Tony Chang.
234
235         Minor bug fixes and cleanup for filesystem wrappers, port/* test
236         classes, test_expectations.py. This change adds "test-win" and
237         "test-mac" variants to the test port so that we can better test
238         rebaselining, and adds a MockUser() object for reuse in testing.
239
240         https://bugs.webkit.org/show_bug.cgi?id=53036
241
242         * Scripts/webkitpy/common/system/filesystem.py:
243         * Scripts/webkitpy/common/system/filesystem_mock.py:
244         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
245         * Scripts/webkitpy/layout_tests/port/factory.py:
246         * Scripts/webkitpy/layout_tests/port/base.py:
247         * Scripts/webkitpy/layout_tests/port/test.py:
248         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
249         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
250         * Scripts/webkitpy/tool/mocktool.py:
251
252 2011-01-25  Tony Chang  <tony@chromium.org>
253
254         Reviewed by Dimitri Glazkov.
255
256         [chromium] remove unused layoutTestController callback
257         https://bugs.webkit.org/show_bug.cgi?id=53103
258
259         This method is used by a test_shell_test, but not needed by DRT.
260
261         * DumpRenderTree/chromium/LayoutTestController.cpp:
262         (LayoutTestController::LayoutTestController):
263         * DumpRenderTree/chromium/LayoutTestController.h:
264
265 2011-01-25  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
266
267         Reviewed by Andreas Kling.
268
269         [GTK] Remove 64 bits release bot from the buildbot master
270         https://bugs.webkit.org/show_bug.cgi?id=52899
271
272         Removes the 64 bits release slave from the buildbot configuration,
273         so that we can use it as an EWS.
274
275         * BuildSlaveSupport/build.webkit.org-config/config.json:
276
277 2011-01-24  Maciej Stachowiak  <mjs@apple.com>
278
279         Reviewed by Dan Bernstein.
280
281         Implement database quota callback to fix storage tests on WebKit2 bot
282         https://bugs.webkit.org/show_bug.cgi?id=53064
283
284         * WebKitTestRunner/TestController.cpp:
285         (WTR::exceededDatabaseQuota):
286         (WTR::TestController::createOtherPage):
287         (WTR::TestController::initialize):
288
289 2011-01-24  Maciej Stachowiak  <mjs@apple.com>
290
291         Reviewed by Anders Carlsson.
292
293         Use designated temp directory for the database for WebKit2
294         https://bugs.webkit.org/show_bug.cgi?id=53052
295         
296         Adopt the new WK2 API for this.
297
298         * WebKitTestRunner/TestController.cpp:
299         (WTR::TestController::libraryPathForTesting):
300         (WTR::TestController::initialize):
301         * WebKitTestRunner/TestController.h:
302         * WebKitTestRunner/mac/TestControllerMac.mm:
303         (WTR::TestController::platformLibraryPathForTesting):
304         * WebKitTestRunner/qt/TestControllerQt.cpp:
305         (WTR::TestController::platformLibraryPathForTesting):
306         * WebKitTestRunner/win/TestControllerWin.cpp:
307         (WTR::TestController::platformLibraryPathForTesting):
308
309 2011-01-24  Lucas Forschler  <lforschler@apple.com>
310
311         Reviewed by Stephanie Lewis.
312
313         Add a new Leopard test bot.
314
315         * BuildSlaveSupport/build.webkit.org-config/config.json:
316
317 2011-01-24  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
318
319         Reviewed by Adam Barth.
320
321         Add EFL Builder to core waterfall
322         https://bugs.webkit.org/show_bug.cgi?id=52704
323
324         Add EFL Builder to the core waterfall again.
325
326         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
327         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
328
329 2011-01-24  Xianzhu Wang  <wangxianzhu@google.com>
330
331         Reviewed by Tony Chang.
332
333         new-run-webkit-tests fails to start HTTP server if there are proxy settings
334         https://bugs.webkit.org/show_bug.cgi?id=52872
335
336         Force disabling proxy to resolve the problem.
337
338         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
339         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
340
341 2011-01-24  Andreas Kling  <kling@webkit.org>
342
343         Reviewed by Darin Adler.
344
345         check-webkit-style: Update exemptions following Source/ move.
346         https://bugs.webkit.org/show_bug.cgi?id=53017
347
348         * Scripts/webkitpy/style/checker.py:
349         * Scripts/webkitpy/style/checker_unittest.py:
350
351 2011-01-24  Andras Becsi  <abecsi@webkit.org>
352
353         Rubber-stamped by Csaba Osztrogonác.
354
355         [Qt] Move project files into Source
356         https://bugs.webkit.org/show_bug.cgi?id=52891
357
358         * DumpRenderTree/qt/ImageDiff.pro: Add missing "Source" to WebKit.pri path
359
360 2011-01-24  Mikhail Naganov  <mnaganov@chromium.org>
361
362         Reviewed by Yury Semikhatsky.
363
364         Web Inspector: Find duplicate strings in localizedStrings.js
365
366         https://bugs.webkit.org/show_bug.cgi?id=53005
367
368         * Scripts/check-inspector-strings:
369
370 2011-01-24  Zoltan Horvath  <zoltan@webkit.org>
371
372         Reviewed by Andreas Kling.
373
374         [Qt] Regroup MiniBrowser's menubar and add open file action
375         https://bugs.webkit.org/show_bug.cgi?id=53000
376
377         Add File and Develop menu to MiniBrowser's menubar and add open file action to File menu.
378
379         * MiniBrowser/qt/BrowserWindow.cpp:
380         (BrowserWindow::BrowserWindow):
381         (BrowserWindow::openFile):
382         (BrowserWindow::~BrowserWindow):
383         * MiniBrowser/qt/BrowserWindow.h:
384
385 2011-01-24  Csaba Osztrogonác  <ossy@webkit.org>
386
387         Unreviewed fix after r76496
388
389         [Qt] Move project files into Source
390         https://bugs.webkit.org/show_bug.cgi?id=52891
391
392         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Remove unnecessary "Source" from the path.
393         * BuildSlaveSupport/built-product-archive: Remove unnecessary "Source" from the path.
394         * Scripts/webkitdirs.pm: Add the accidentally removed slash to the path.
395
396 2011-01-24  Andras Becsi  <abecsi@webkit.org>
397
398         Reviewed by Csaba Osztrogonác.
399
400         [Qt] Move project files into Source
401         https://bugs.webkit.org/show_bug.cgi?id=52891
402
403         * DerivedSources.pro: Renamed from DerivedSources.pro.
404         * DumpRenderTree/qt/DumpRenderTree.pro:
405         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
406         * MiniBrowser/DerivedSources.pro:
407         * MiniBrowser/qt/MiniBrowser.pro:
408         * QtTestBrowser/QtTestBrowser.pro:
409         * Scripts/webkitdirs.pm:
410         * Tools.pro: Added.
411         * WebKitTestRunner/DerivedSources.pro:
412         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
413         * WebKitTestRunner/qt/WebKitTestRunner.pro:
414
415 2011-01-22  Geoffrey Garen  <ggaren@apple.com>
416
417         Reviewed by Dan Bernstein.
418
419         Beefed up --threaded mode to catch even more kinds of errors.
420         https://bugs.webkit.org/show_bug.cgi?id=52971
421
422         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Use a shared
423         context group to force JSC to mark multiple threads. (This used to be
424         the default, but it changed in SnowLeopard.)
425         (runJavaScriptThread): Do more locking and unlocking, and more allocation,
426         to give threading mistakes more chances to show themselves.
427         (startJavaScriptThreads):
428         (stopJavaScriptThreads):
429
430 2011-01-22  Robert Hogan  <robert@webkit.org>
431
432         Reviewed by Andreas Kling.
433
434         [Qt] Support layoutTestController.addURLToRedirect()
435         https://bugs.webkit.org/show_bug.cgi?id=52956
436
437         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
438         (LayoutTestController::addURLToRedirect):
439         * DumpRenderTree/qt/LayoutTestControllerQt.h:
440
441 2011-01-22  Robert Hogan  <robert@webkit.org>
442
443         Reviewed by Kenneth Rohde Christiansen.
444
445         [Qt] REGRESSION (r72360): http/tests/security/aboutBlank/xss-DENIED-* tests fail
446         https://bugs.webkit.org/show_bug.cgi?id=49802
447
448         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
449         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
450         (WebCore::DumpRenderTree::open):
451
452 2011-01-21  Adam Barth  <abarth@webkit.org>
453
454         Reviewed by Maciej Stachowiak.
455
456         Disable mac_unittest.py that fails on some of the Mac bots
457         https://bugs.webkit.org/show_bug.cgi?id=52947
458
459         As noted in the comment, this test does not appear to be correct
460         because the function this test is testing returns different results
461         depending on which flavor of Mac the test is run on.  This patch
462         disable the test.  Hopefully we can re-enable the test once we've
463         probably insulated the test from its environment.
464
465         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
466
467 2011-01-21  Dirk Pranke  <dpranke@chromium.org>
468
469         Reviewed by Mihai Parparita.
470
471         Fix bug introduced in r76322 that caused NRWT to not actually
472         read the Skipped files properly.
473
474         https://bugs.webkit.org/show_bug.cgi?id=52771
475
476         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
477         * Scripts/webkitpy/layout_tests/port/webkit.py:
478         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
479
480 2011-01-21  Sam Weinig  <sam@webkit.org>
481
482         Reviewed by Geoffrey Sean Garen and Mark Rowe.
483
484         WebKitTestRunner needs the HOME environment variable to be set.
485         <rdar://problem/8896573>
486
487         * Scripts/old-run-webkit-tests: Set the HOME environment variable if
488         it exists.
489
490 2011-01-21  Dirk Pranke  <dpranke@chromium.org>
491
492         Reviewed by Eric Seidel.
493
494         Suppress a few remaining integration tests so that none of the
495         layout_test unit tests ever read from the filesystem or launch
496         subprocesses that aren't part of the unit tests.
497
498         Also fix a minor bug in the printing unit tests that was
499         incorrectly relying on sys.argv.
500
501         https://bugs.webkit.org/show_bug.cgi?id=52863
502
503         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
504         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
505         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
506
507 2011-01-21  Darin Adler  <darin@apple.com>
508
509        Fix Mac build.
510
511         * MiniBrowser/mac/BrowserWindowController.m:
512         (-[BrowserWindowController awakeFromNib]): Pass 0 for runModal function.
513
514 2011-01-20  Darin Adler  <darin@apple.com>
515
516         Reviewed by Dan Bernstein.
517
518         WebKit2: Implement showModalDialog
519         https://bugs.webkit.org/show_bug.cgi?id=52855
520
521         This fixes WebKitTestRunner to compile, but more work is probably
522         needed to get it to pass the tests.
523
524         * WebKitTestRunner/TestController.cpp:
525         (WTR::TestController::runModal): Added. Calls through to the
526         platform-specific version of runModal.
527         (WTR::TestController::createOtherPage): Changed to be a private
528         static member function so it can refer to runModal, which is
529         a private static member function.
530         (WTR::TestController::initialize): Pass 0 for the runModal
531         function since we don't need to run the main window modal.
532         I suspect this is wrong and will need to change.
533         * WebKitTestRunner/TestController.h: Added declarations for
534         the functions added above.
535         * WebKitTestRunner/mac/TestControllerMac.mm:
536         (WTR::TestController::runModal): Added. Untested implementation.
537         * WebKitTestRunner/qt/TestControllerQt.cpp:
538         (WTR::TestController::runModal): Added.
539         * WebKitTestRunner/win/TestControllerWin.cpp:
540         (WTR::TestController::runModal): Added.
541
542 2011-01-21  Eric Seidel  <eric@webkit.org>
543
544         Reviewed by Adam Barth.
545
546         Split Host object off from WebKitPatch for easier re-use
547         https://bugs.webkit.org/show_bug.cgi?id=52284
548
549         new-run-webkit-tests and other tools are eventually going to want one of these.
550         Basically you need to inherit from this class if you want to pretend to be a
551         self.tool object for Steps/Commands.
552
553         * Scripts/webkitpy/common/host.py: Added.
554         * Scripts/webkitpy/tool/main.py:
555
556 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
557
558         Reviewed by Adam Barth.
559
560         Disable the tests that start and stop the http server and web
561         server, so that we don't have to worry about port collisions on
562         the bots.
563
564         https://bugs.webkit.org/show_bug.cgi?id=52861
565
566         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
567
568 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
569
570         Reviewed by Eric Seidel.
571
572         nrwt: rewrite google_chrome_unittest to use mock filesystem.
573         
574         https://bugs.webkit.org/show_bug.cgi?id=52772
575         
576         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
577
578 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
579
580         Reviewed by Eric Siedel.
581
582         nrwt: clean up almost all remaining port references, remove
583         unnecessary import clauses. The only remaining references are
584         in places where a mock filesystem makes no sense or can't be
585         used, and in one routine in port/google_chrome_unittest that
586         I'll rewrite in a separate patch.
587
588         https://bugs.webkit.org/show_bug.cgi?id=52771
589
590         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
591         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
592         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
593         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
594         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
595         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
596         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
597         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
598         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
599         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
600         * Scripts/webkitpy/layout_tests/port/gtk.py:
601         * Scripts/webkitpy/layout_tests/port/mac.py:
602         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
603         * Scripts/webkitpy/layout_tests/port/qt.py:
604         * Scripts/webkitpy/layout_tests/port/webkit.py:
605         * Scripts/webkitpy/layout_tests/port/win.py:
606         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
607
608 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
609
610         Reviewed by Mihai Parparita.
611
612         remove fs refs from run_webkit_tests, rebaseline_chromium_webkit_tests
613
614         https://bugs.webkit.org/show_bug.cgi?id=52762
615
616         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
617         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
618
619 2011-01-20  Tony Chang  <tony@chromium.org>
620
621         Reviewed by Ojan Vafai.
622
623         [chromium] fix the paths used for the rebaseline tool
624         https://bugs.webkit.org/show_bug.cgi?id=52857
625
626         Some of the bots were renamed so the path to grab the results zip
627         file has changed.
628
629         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
630
631 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
632
633         Reviewed by Tony Chang.
634
635         Fix bug introduced in r72688 / bug 52768 that broke the
636         generation of the output filename links in the results.html
637         output. Apparently none of the unit tests actually checked to
638         make sure the generated links were correct :(
639
640         https://bugs.webkit.org/show_bug.cgi?id=52854
641
642         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
643         * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
644
645 2011-01-20  Alexey Proskuryakov  <ap@apple.com>
646
647         Reviewed by Darin Adler.
648
649         https://bugs.webkit.org/show_bug.cgi?id=52849
650         Make window.print work with WebKit2
651
652         * MiniBrowser/mac/BrowserWindowController.m:
653         (-[BrowserWindowController awakeFromNib]):
654         * WebKitTestRunner/TestController.cpp:
655         (WTR::createOtherPage):
656         (WTR::TestController::initialize):
657         Added zeroes to WKPageUIClient structures to avoid build failures.
658
659 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
660
661         Reviewed by Eric Seidel.
662
663         nrwt: remove fs refs from printing, test_failures, test_expectations, text_diff
664
665         https://bugs.webkit.org/show_bug.cgi?id=52756
666
667         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
668         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
669         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
670         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
671         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
672         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
673
674 2011-01-20  Mansi Mithal  <mansi.mithal@nokia.com>
675
676         Reviewed by Antonio Gomes.
677
678         QtTestBrowser should have a seperate menu for Settings
679         https://bugs.webkit.org/show_bug.cgi?id=52817
680         
681         Added a new menu item named "Settings"
682         and moved the "Enable interrupting js scripts" and "Enable js pop up windows" under the "Settings" menu 
683
684         * QtTestBrowser/launcherwindow.cpp:
685         (LauncherWindow::createChrome):
686
687 2011-01-20  Sam Weinig  <sam@webkit.org>
688
689         Reviewed by John Sullivan.
690
691         Update update-webkit-localizable-strings with new path to WebKit.
692
693         * Scripts/update-webkit-localizable-strings:
694
695 2011-01-20  James Robinson  <jamesr@chromium.org>
696
697         Reviewed by Darin Fisher.
698
699         Implement mozilla's requestAnimationFrame API
700         https://bugs.webkit.org/show_bug.cgi?id=51218
701
702         Chromium DumpRenderTree support for window.webkitRequestAnimationFrame.
703
704         * DumpRenderTree/chromium/WebViewHost.cpp:
705         (invokeScheduleComposite):
706         (WebViewHost::scheduleAnimation):
707         (WebViewHost::paintInvalidatedRegion):
708         * DumpRenderTree/chromium/WebViewHost.h:
709
710 2011-01-20  Maciej Stachowiak  <mjs@apple.com>
711
712         Reviewed by Adam Roben.
713
714         WebKitTestRunner needs to support layoutTestController.evaluateScriptInIsolatedWorld
715         https://bugs.webkit.org/show_bug.cgi?id=42327
716
717         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm: Add support
718         for methods that take their normal arguments but also a JSContextRef.
719         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: IDL definition
720         for evaluateScriptInIsolatedWorld.
721         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
722         (WTR::InjectedBundlePage::didClearWindowForFrame): Set a magic variable only if
723         this call is for an isolated world.
724         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
725         (WTR::worldMap): Helper to create a world map.
726         (WTR::LayoutTestController::worldIDForWorld): Map from an ID to a world.
727         (WTR::LayoutTestController::evaluateScriptInIsolatedWorld): The newly
728         added LayoutTestController API.
729         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
730
731 2011-01-19  Adam Roben  <aroben@apple.com>
732
733         Convert paths in environment variables back to msys-style inside commit-log-editor
734
735         When this script gets run from inside git commit, msys-style paths in the environment will
736         have been turned into Windows-style paths with forward slashes. This screws up functions
737         like File::Spec->rel2abs, which seem to rely on $PWD having an msys-style path. We convert
738         the paths back to msys-style before doing anything else.
739
740         Fixes <http://webkit.org/b/48527> commit-log-editor uses full paths for section headers when
741         using msysgit's Perl and multiple ChangeLogs have been edited
742
743         Reviewed by David Kilzer.
744
745         * Scripts/commit-log-editor: Call fixEnvironment before doing anything else.
746         (fixEnvironment): Added. When run in msys in conjunction with git (i.e., when invoked from
747         inside git commit), convert Windows-style paths in the environment back to msys-style paths.
748
749 2011-01-20  Zoltan Horvath  <zoltan@webkit.org>
750
751         [Win] Unreviewed build fix after r76248.
752
753         * DumpRenderTree/ForwardingHeaders/wtf/FastAllocBase.h: Added.
754
755 2011-01-20  Zoltan Horvath  <zoltan@webkit.org>
756
757         Reviewed by Csaba Osztrogonác.
758
759         Refactoring of the custom allocation framework
760         https://bugs.webkit.org/show_bug.cgi?id=49897
761
762         Inheriting from FastAllocBase can result in objects getting larger (bug #33896, #46589).
763         The modification replaces Noncopyable and FastAllocBase classes and these inherits with their
764         equivalent macro implementation at the necessary places.
765 2011-01-20  Yi Shen  <yi.4.shen@nokia.com>
766
767         Unreviewed. 
768
769         Adding myself to committers.py.
770
771         * Scripts/webkitpy/common/config/committers.py:
772
773 2011-01-20  Adam Barth  <abarth@webkit.org>
774
775         Reviewed by Tony Chang.
776
777         Chromium builders don't delete unversioned directories when DEPS change
778         https://bugs.webkit.org/show_bug.cgi?id=52745
779
780         If we pass this option to gclient sync, gclient will delete directories
781         that are no longer part of DEPS instead of leaving them around to
782         confuse us later.  Apparently, the downstream buildbots use this option
783         already.
784
785         * Scripts/update-webkit-chromium:
786
787 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
788
789         Unreviewed, build fix - I pulled this patch in to fix an issue
790         revealed by r76195 running on some new bots). Also fix a couple
791         of other issues revealed in testing.
792
793         nrwt: remove fs refs from layout_package/json*
794
795         https://bugs.webkit.org/show_bug.cgi?id=52754
796
797         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
798         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
799         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
800         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
801         * Scripts/webkitpy/layout_tests/port/base.py:
802
803 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
804
805         Unreviewed, build fix.
806
807         Fix a couple of minor bugs discovered while bringing up new bots
808         for testing.
809
810         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
811         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
812
813 2011-01-19  James Robinson  <jamesr@chromium.org>
814
815         Unreviewed, rolling out r76194.
816         http://trac.webkit.org/changeset/76194
817         https://bugs.webkit.org/show_bug.cgi?id=51218
818
819         Caused mysterious compile failure on the chromium win
820         build.webkit.org bots
821
822         * DumpRenderTree/chromium/WebViewHost.cpp:
823         (WebViewHost::paintInvalidatedRegion):
824         * DumpRenderTree/chromium/WebViewHost.h:
825
826 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
827
828         Reviewed by Mihai Parparita.
829
830         remove fs refs from test_runner, dump_render_tree_thread
831
832         https://bugs.webkit.org/show_bug.cgi?id=52753
833
834         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
835         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
836         * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
837         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
838
839 2011-01-19  James Robinson  <jamesr@chromium.org>
840
841         Reviewed by Darin Fisher.
842
843         Implement mozilla's requestAnimationFrame API
844         https://bugs.webkit.org/show_bug.cgi?id=51218
845
846         Chromium DumpRenderTree support for window.webkitRequestAnimationFrame.
847
848         * DumpRenderTree/chromium/WebViewHost.cpp:
849         (invokeScheduleComposite):
850         (WebViewHost::scheduleAnimation):
851         (WebViewHost::paintInvalidatedRegion):
852         * DumpRenderTree/chromium/WebViewHost.h:
853
854 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
855
856         Unreviewed, build fix.
857
858         Fix a few incorrect "self._filesystem" references introduced in
859         r76184.
860
861         * Scripts/webkitpy/layout_tests/port/chromium.py:
862         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
863
864 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
865
866         Reviewed by Mihai Parparita.
867
868         add a .sep property, abspath(), isabs(), mtime(), and
869         open_text_file_for_writing() to filesystem modules. Some of
870         these properties are not needed in this patch but will be needed
871         in subsequent patches (I'm doing this to avoid having to track
872         multiple versions of a single file).
873
874         Also, change most of the port/* modules to use the filesystem
875         objects instead of referencing the filesystem directly.
876
877         https://bugs.webkit.org/show_bug.cgi?id=52748
878
879         * Scripts/webkitpy/common/system/filesystem.py:
880         * Scripts/webkitpy/common/system/filesystem_mock.py:
881         * Scripts/webkitpy/layout_tests/port/__init__.py:
882         * Scripts/webkitpy/layout_tests/port/base.py:
883         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
884         * Scripts/webkitpy/layout_tests/port/chromium.py:
885         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
886         * Scripts/webkitpy/layout_tests/port/config.py:
887         * Scripts/webkitpy/layout_tests/port/test.py:
888         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
889
890 2011-01-19  Maciej Stachowiak  <mjs@apple.com>
891
892         Reviewed by Anders Carlsson.
893
894         If resetting between tests times out, treat it as a WebProcess crash
895         https://bugs.webkit.org/show_bug.cgi?id=52757
896
897         * WebKitTestRunner/TestController.cpp:
898         (WTR::TestController::runTest):
899
900 2011-01-19  Alexey Proskuryakov  <ap@apple.com>
901
902         Reviewed by Darin Adler.
903
904         https://bugs.webkit.org/show_bug.cgi?id=52739
905         Make it possible for a WebKit2 client to print headers and footers
906
907         Added dummy implementations for new printing UIClient calls.
908
909         * MiniBrowser/mac/BrowserWindowController.m:
910         (-[BrowserWindowController awakeFromNib]):
911         * WebKitTestRunner/TestController.cpp:
912         (WTR::createOtherPage):
913         (WTR::TestController::initialize):
914
915 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
916
917         Reviewed by Ojan Vafai.
918
919         Change webkitpy/layout_tests/port/test.py to use the
920         in-memory filesystem for cleaner unit testing. This
921         change allows us to kill a lot of code that was
922         specific to the test port, at the cost of being a
923         little less clear about how things would work if
924         you didn't have a filesystem.
925
926         https://bugs.webkit.org/show_bug.cgi?id=52605
927
928         * Scripts/webkitpy/layout_tests/port/test.py:
929
930 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
931
932         Unreviewed, build fix.
933
934         Fix test failure caused by committing attachment 79368 instead
935         of attachment 79461 on bug 52604.
936
937         * Scripts/webkitpy/common/system/filesystem_mock.py:
938
939 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
940
941         Reviewed by Mihai Parparita.
942
943         new-run-webkit-tests: remove use of os.walk, use mock filesystem for better
944         unit testing. os.walk() is too much of a hassle to implement on
945         top of the in-memory mock filesystem and adding the necessary
946         interface to files_under() gives clients a cleaner API anyway
947         (for this particular usage model).
948
949         https://bugs.webkit.org/show_bug.cgi?id=52691
950
951         * Scripts/webkitpy/common/system/filesystem.py:
952         * Scripts/webkitpy/common/system/filesystem_mock.py:
953         * Scripts/webkitpy/layout_tests/port/test_files.py:
954         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
955
956 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
957
958         Reviewed by Tony Chang.
959
960         Change more modules in the layout-tests code to use the
961         filesystem wrapper for cleaner unit testing.
962
963         This patch also adds the glob() wrapper to the filesystem
964         abstraction.
965         
966         https://bugs.webkit.org/show_bug.cgi?id=52604
967
968         * Scripts/webkitpy/layout_tests/port/test_files.py:
969         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
970         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
971         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
972         * Scripts/webkitpy/common/system/filesystem.py:
973         * Scripts/webkitpy/common/system/filesystem_mock.py:
974
975 2011-01-19  Levi Weintraub  <leviw@chromium.org>
976
977         Unreviewed.
978
979         Updating my email addresses and irc nick.
980
981         * Scripts/webkitpy/common/config/committers.py:
982
983 2011-01-19  Tony Chang  <tony@chromium.org>
984
985         Reviewed by Mihai Parparita.
986
987         [chromium] [linux] if check-sys-deps fails, output the failure reason
988         https://bugs.webkit.org/show_bug.cgi?id=52671
989
990         * Scripts/webkitpy/common/system/executive_mock.py: Add support for
991             error handler functions.
992         * Scripts/webkitpy/layout_tests/port/chromium.py:
993             output the error text from --check-sys-deps
994         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
995
996 2011-01-19  Aparna Nandyal  <aparna.nand@wipro.com>
997
998         Reviewed by Andreas Kling.
999
1000         [Qt] QtTestBrowser crashes when closing if Facebook is opened
1001         https://bugs.webkit.org/show_bug.cgi?id=52554
1002         
1003         QtNetworkAccessManager is created in a thread and set as
1004         member variable in QWebPage. When the thread is destroyed
1005         the object is still used. So fix will set the object to
1006         NULL once the thread is destroyed.
1007
1008         * QtTestBrowser/launcherwindow.cpp:
1009         (LauncherWindow::~LauncherWindow):
1010
1011 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
1012
1013         Rubber stamped by Csaba Osztrogonac
1014
1015         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: Removed unncessary inculde of WKStringCF.h
1016
1017 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
1018
1019         Reviewed by Tony Chang.
1020
1021         new-run-webkit-tests: add a --build-directory command line argument
1022
1023         Official Google Chrome builds use a non-standard build directory
1024         location. This patch adds a --build-directory argument that
1025         allows that location to be specified on the command line. Only
1026         Chromium-based builds will use this flag for now, but anyone can
1027         in the future.
1028
1029         There are no unit tests for this since it's difficult to test
1030         until mock filesystems are fully supported in the code. This was
1031         tested by hand for now.
1032
1033         https://bugs.webkit.org/show_bug.cgi?id=52694
1034
1035         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1036         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1037         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1038         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1039
1040 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
1041
1042         Not reviewed. Bot fix.
1043
1044         Remove an inadvertently committed debugging print.
1045
1046         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1047         (LayoutTestController::notifyDone):
1048
1049 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
1050
1051         Reviewed by Sam Weinig.
1052
1053         WebKitTestRunner should track loading more like DumpRenderTree
1054         https://bugs.webkit.org/show_bug.cgi?id=52692
1055
1056         Change load tracking to track the current top loading frame, in the manner of DumpRenderTree.
1057         This makes some tests that call notifyDone multiple times pass.
1058         
1059         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1060         (WTR::InjectedBundle::InjectedBundle):
1061         (WTR::InjectedBundle::done):
1062         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1063         (WTR::InjectedBundle::topLoadingFrame):
1064         (WTR::InjectedBundle::setTopLoadingFrame):
1065         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1066         (WTR::InjectedBundlePage::InjectedBundlePage):
1067         (WTR::InjectedBundlePage::stopLoading):
1068         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
1069         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
1070         (WTR::InjectedBundlePage::didFinishLoadForFrame):
1071         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
1072         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1073         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1074         (WTR::LayoutTestController::notifyDone):
1075         * WebKitTestRunner/TestController.cpp:
1076         (WTR::TestController::didReceiveMessageFromInjectedBundle):
1077
1078 2011-01-18  Mihai Parparita  <mihaip@chromium.org>
1079
1080         Reviewed by Kent Tamura.
1081
1082         [Chromium] NRWT looking for DRT binary in the wrong path on Mac
1083         https://bugs.webkit.org/show_bug.cgi?id=52678
1084         
1085         Update path now that WebKit is inside Source.
1086
1087         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1088
1089 2011-01-18  Robert Hogan  <robert@webkit.org>
1090
1091         Reviewed by Simon Hausmann.
1092
1093         [Qt] http/tests/incremental/slow-utf8-text.pl fails
1094         https://bugs.webkit.org/show_bug.cgi?id=44282
1095
1096         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1097         (WebCore::DumpRenderTree::dump):
1098
1099 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
1100
1101         Reviewed by Mihai Parparita.
1102
1103         Fix a small race condition that could cause the unit tests for
1104         new-run-webkit-tests to fail in a multithreaded environment.
1105         There was a small window in the code where one thread would
1106         check to see if a thread had raised an exception, do something,
1107         and then check to see if the thread was alive. If the other
1108         thread raised an exception and exited in between these two
1109         steps, the exception would be lost. Flipping the order of the
1110         two checks fixes the race, since we will now always check for an
1111         exception on the thread before exiting.
1112
1113         https://bugs.webkit.org/show_bug.cgi?id=51579
1114
1115         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
1116
1117 2011-01-18  Eric Seidel  <eric@webkit.org>
1118
1119         Reviewed by Adam Barth.
1120
1121         commit-queue dies when test archiving fails
1122         https://bugs.webkit.org/show_bug.cgi?id=52617
1123
1124         I looked at the machine and it had 10 archives already
1125         thus find_unused_name was returning None.  I've upped
1126         the limit to 100 (per bug) and tested the case where
1127         find_unused_name returns None (making archive return None).
1128
1129         * Scripts/webkitpy/common/system/workspace.py:
1130         * Scripts/webkitpy/common/system/workspace_unittest.py:
1131         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1132         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1133         * Scripts/webkitpy/tool/commands/queues.py:
1134
1135 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
1136
1137         Reviewed by Ojan Vafai.
1138
1139         Update rebaseline-chromium-webkit-tests unit tests to use a mock
1140         filesystem. Also fix a couple of "with" statements missed by
1141         r76050.
1142
1143         https://bugs.webkit.org/show_bug.cgi?id=52487
1144
1145         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
1146
1147 2011-01-18  Sergio Villar Senin  <svillar@igalia.com>
1148
1149         Reviewed by Martin Robinson.
1150
1151         [Gtk] Build fixes for gtk3 build
1152         https://bugs.webkit.org/show_bug.cgi?id=52648
1153
1154         * DumpRenderTree/gtk/EventSender.cpp:
1155         (beginDragWithFilesCallback):
1156
1157 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
1158
1159         Reviewed by Mihai Parparita.
1160
1161         Update rebaseline-chromium-webkit-tests to use filesystem objects
1162         instead of direct references to os.path, shutil, tempfile, etc.
1163
1164         This patch doesn't change anything, but will allow subsequent
1165         patches to change the unit tests to no longer use the real
1166         filesystem.
1167
1168         This patch adds a bunch more methods to the filesystem object as
1169         well.
1170
1171         https://bugs.webkit.org/show_bug.cgi?id=52482
1172
1173         * Scripts/webkitpy/common/system/filesystem.py:
1174         * Scripts/webkitpy/common/system/filesystem_mock.py:
1175         * Scripts/webkitpy/tool/commands/queues.py:
1176         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1177         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
1178
1179 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
1180
1181         Reviewed by Mihai Parparita.
1182
1183         new-run-webkit-tests shouldn't crash when you try to run a
1184         directory containing only skipped files.
1185
1186         https://bugs.webkit.org/show_bug.cgi?id=52478
1187         
1188         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1189         * Scripts/webkitpy/layout_tests/port/test.py:
1190         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1191
1192 2011-01-18  Adam Bergkvist  <adam.bergkvist@ericsson.com> and Martin Robinson  <mrobinson@igalia.com>
1193
1194         Reviewed by Gustavo Noronha Silva.
1195
1196         [GTK] The GTK+ EventSender needs support for beginDragWithFiles
1197         https://bugs.webkit.org/show_bug.cgi?id=40833
1198
1199         * DumpRenderTree/gtk/EventSender.cpp: Add a beginDragWithFiles implementation for the
1200         GTK+ event sender.
1201         (dragWithFilesDragDataGetCallback): Added.
1202         (dragWithFilesDragEndCallback): Added.
1203         (beginDragWithFilesCallback): Added.
1204
1205 2011-01-18  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1206
1207         Reviewed by Adam Barth.
1208
1209         ews: Add additional watcher to efl ews
1210         https://bugs.webkit.org/show_bug.cgi?id=52613
1211
1212         Add gyuyoung.kim@samsung.com to watcher list of efl-ews.
1213
1214         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1215
1216 2011-01-17  Tony Gentilcore  <tonyg@chromium.org>
1217
1218         Reviewed by Alexey Proskuryakov.
1219
1220         Fix some headers with missing or misspelled #ifndef guards
1221         https://bugs.webkit.org/show_bug.cgi?id=52545
1222
1223         * DumpRenderTree/chromium/TestEventPrinter.h:
1224         * DumpRenderTree/chromium/WebPreferences.h:
1225
1226 2011-01-17  Jessie Berlin  <jberlin@apple.com>
1227
1228         Reviewed by Anders Carlsson.
1229
1230         REGRESSION: Assertion failure in FrameLoader::continueLoadAfterWillSubmitForm() when
1231         navigating back to an unreachable URL
1232         https://bugs.webkit.org/show_bug.cgi?id=52388
1233
1234         Add a third parameter (unreachableURL) to queueLoadHTMLString.
1235
1236         * DumpRenderTree/LayoutTestController.cpp:
1237         (queueLoadHTMLStringCallback):
1238         (LayoutTestController::queueLoadHTMLString):
1239         (LayoutTestController::queueLoadAlternateHTMLString):
1240         * DumpRenderTree/LayoutTestController.h:
1241
1242         * DumpRenderTree/WorkQueueItem.h:
1243         (LoadHTMLStringItem::LoadHTMLStringItem):
1244
1245         * DumpRenderTree/chromium/LayoutTestController.cpp:
1246         (WorkItemLoadHTMLString::WorkItemLoadHTMLString):
1247         (WorkItemLoadHTMLString::run):
1248         (LayoutTestController::queueLoadHTMLString):
1249
1250         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
1251         (LoadHTMLStringItem::invoke):
1252         * DumpRenderTree/mac/WorkQueueItemMac.mm:
1253         (LoadHTMLStringItem::invoke):
1254         * DumpRenderTree/win/WorkQueueItemWin.cpp:
1255         (LoadHTMLStringItem::invoke):
1256
1257 2011-01-17  Dan Bernstein  <mitz@apple.com>
1258
1259         Rubber-stamped by Mark Rowe.
1260
1261         Update xcodeproj svn:ignore to include xcuserdata.
1262
1263         * DumpRenderTree/DumpRenderTree.xcodeproj: Modified property svn:ignore.
1264         * MiniBrowser/MiniBrowser.xcodeproj: Modified property svn:ignore.
1265         * TestWebKitAPI/TestWebKitAPI.xcodeproj: Modified property svn:ignore.
1266         * WebKitLauncher/WebKitLauncher.xcodeproj: Modified property svn:ignore.
1267         * WebKitTestRunner/WebKitTestRunner.xcodeproj: Modified property svn:ignore.
1268
1269 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
1270
1271         Unreviewed fix after r75908.
1272
1273         Move WebKit into Source
1274         https://bugs.webkit.org/show_bug.cgi?id=52530
1275
1276         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add Source to the path for Qt API tests.
1277
1278 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
1279
1280         Unreviewed.
1281
1282         Remove accidentally committed debug printing after r75908.
1283
1284         * Scripts/webkitdirs.pm:
1285
1286 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
1287
1288         Unreviewed.
1289
1290         Add myself to committers list
1291         https://bugs.webkit.org/show_bug.cgi?id=52566
1292
1293         * Scripts/webkitpy/common/config/committers.py:
1294
1295 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
1296
1297         Reviewed by Jeremy Orlow.
1298
1299         GeolocationController should call stopUpdating on destruction
1300         https://bugs.webkit.org/show_bug.cgi?id=52216
1301
1302         fast/dom/Geolocation/window-close-crash.html requires that a
1303         Geolocation watch be started in a secondary window. Consequently,
1304         we need to allow geolocation permission and provide a mock
1305         geolocation position for the secondary window's
1306         GeolocationClientMock.
1307
1308         * DumpRenderTree/chromium/LayoutTestController.cpp:
1309         (LayoutTestController::setGeolocationPermission):
1310         (LayoutTestController::setMockGeolocationPosition):
1311         (LayoutTestController::setMockGeolocationError):
1312         * DumpRenderTree/chromium/TestShell.h:
1313         (TestShell::windowList):
1314
1315 2011-01-16  Adam Barth  <abarth@webkit.org>
1316
1317         Update more include paths to reflect WebKit move.
1318
1319         * DumpRenderTree/chromium/EventSender.cpp:
1320         (EventSender::keyDown):
1321         (EventSender::needsShiftModifier):
1322         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
1323         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
1324
1325 2011-01-16  Kent Tamura  <tkent@chromium.org>
1326
1327         Unreviewed, Chromium build fix.
1328
1329         * Scripts/update-webkit-chromium: Webkit/chromium -> Source/WebKit/chromium
1330
1331 2011-01-16  Martin Robinson  <mrobinson@igalia.com>
1332
1333         Build fix for GTK+ after source directory movement.
1334
1335         * GNUmakefile.am: Correct include paths.
1336
1337 2011-01-16  Adam Barth  <abarth@webkit.org>
1338
1339         Teach svn-apply about WebKit move.
1340
1341         * Scripts/VCSUtils.pm:
1342
1343 2011-01-16  Adam Barth  <abarth@webkit.org>
1344
1345         Rubber-stamped by Eric Seidel.
1346
1347         Move WebKit into Source
1348         https://bugs.webkit.org/show_bug.cgi?id=52530
1349
1350         * DumpRenderTree/mac/InternalHeaders/WebKit/WebTypesInternal.h:
1351         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1352         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1353         * DumpRenderTree/qt/GCControllerQt.cpp:
1354         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1355         * DumpRenderTree/qt/PlainTextControllerQt.cpp:
1356         * DumpRenderTree/qt/TextInputControllerQt.cpp:
1357         * DumpRenderTree/wscript:
1358         * QtTestBrowser/launcherwindow.h:
1359         * Scripts/build-webkit:
1360         * Scripts/webkitdirs.pm:
1361
1362 2011-01-15  Adam Barth  <abarth@webkit.org>
1363
1364         Teach svn-apply about WebKit2 move.
1365
1366         * Scripts/VCSUtils.pm:
1367
1368 2011-01-15  Adam Barth  <abarth@webkit.org>
1369
1370         Rubber-stamped by Eric Seidel.
1371
1372         Move WebKit2 into Source
1373         https://bugs.webkit.org/show_bug.cgi?id=52438
1374
1375         * MiniBrowser/qt/MiniBrowser.pro:
1376         * Scripts/build-webkit:
1377         * Scripts/do-file-rename:
1378         * Scripts/do-webcore-rename:
1379         * Scripts/test-webkitpy:
1380         * Scripts/webkitdirs.pm:
1381         * Scripts/webkitpy/style/checker.py:
1382         * WebKitTestRunner/DerivedSources.pro:
1383         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1384         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1385
1386 2011-01-15  Jochen Eisinger  <jochen@chromium.org>
1387
1388         Reviewed by David Levin.
1389
1390         [chromium] remove obsolete createView method
1391         https://bugs.webkit.org/show_bug.cgi?id=52437
1392
1393         * DumpRenderTree/chromium/WebViewHost.cpp:
1394         (WebViewHost::createView):
1395         * DumpRenderTree/chromium/WebViewHost.h:
1396
1397 2011-01-14  Brian Weinstein  <bweinstein@apple.com>
1398
1399         Reviewed by Geoff Garen.
1400
1401         ShouldLoadResourceForFrame should use strings, not URLs.
1402         https://bugs.webkit.org/show_bug.cgi?id=52476
1403
1404         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1405         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Update to use a WKStringRef.
1406         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1407
1408 2011-01-14  Tony Gentilcore  <tonyg@chromium.org>
1409
1410         Reviewed by David Levin.
1411
1412         Add Tony Gentilcore as a reviewer
1413         https://bugs.webkit.org/show_bug.cgi?id=52480
1414
1415         * Scripts/webkitpy/common/config/committers.py:
1416
1417 2011-01-14  David Levin  <levin@chromium.org>
1418
1419         Reviewed by Eric Seidel.
1420
1421         check-webkit-style: _FunctionState should keep track of where the function name starts.
1422         https://bugs.webkit.org/show_bug.cgi?id=52454
1423
1424         * Scripts/webkitpy/style/checkers/cpp.py: Added function_name_start_position to
1425         _FunctionState and logic for setting it correctly.
1426         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests.
1427
1428 2011-01-14  Vincent Scheib  <scheib@chromium.org>
1429
1430         Reviewed by David Levin.
1431
1432         Add support to DumpRenderTree to use the GPU rather than software renderer
1433         https://bugs.webkit.org/show_bug.cgi?id=52333
1434
1435         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1436         (main):
1437         * Scripts/webkitpy/layout_tests/port/chromium.py:
1438         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1439
1440 2011-01-14  Tony Chang  <tony@chromium.org>
1441
1442         Reviewed by Kent Tamura.
1443
1444         [chromium] update fonts.conf to fix 6 linux tests in drt
1445         https://bugs.webkit.org/show_bug.cgi?id=52411
1446
1447         * DumpRenderTree/chromium/fonts.conf: Update to match the copy in
1448             chromium's src/webkit/tools/test_shell/resources/fonts.conf
1449
1450 2011-01-14  Eric Seidel  <eric@webkit.org>
1451
1452         Original patch from Peter Gal  <galpater@inf.u-szeged.hu>
1453
1454         Reviewed by Adam Barth.
1455
1456         Fix when running Tools/Scripts/check-webkit-style without arguments.
1457         https://bugs.webkit.org/show_bug.cgi?id=52261#c16
1458
1459         * Scripts/webkitpy/common/checkout/scm.py: Handle None for changed_files argument better in Git.create_patch method.
1460         * Scripts/webkitpy/common/checkout/scm_unittest.py:
1461
1462 2011-01-04  Jochen Eisinger  <jochen@chromium.org>
1463
1464         Reviewed by David Levin.
1465
1466         Store the tempdir object in a variable so it doesn't get deleted too early.
1467         https://bugs.webkit.org/show_bug.cgi?id=51875
1468
1469         * Scripts/update-webkit-auxiliary-libs:
1470         * Scripts/update-webkit-support-libs:
1471
1472 2011-01-14  Eric Seidel  <eric@webkit.org>
1473
1474         Unreviewed.  Make it work in python 2.5.
1475
1476         webkit-patch suggest-reviewers dies when ChangeLogs are missing
1477         https://bugs.webkit.org/show_bug.cgi?id=49158
1478
1479         * Scripts/webkitpy/common/checkout/api_unittest.py:
1480
1481 2011-01-14  Sheriff Bot  <webkit.review.bot@gmail.com>
1482
1483         Unreviewed, rolling out r75774.
1484         http://trac.webkit.org/changeset/75774
1485         https://bugs.webkit.org/show_bug.cgi?id=52431
1486
1487         gtk builds were broken (Requested by loislo2 on #webkit).
1488
1489         * Scripts/webkitpy/common/checkout/scm.py:
1490
1491 2011-01-14  David Levin  <levin@chromium.org>
1492
1493         Reviewed by Shinichiro Hamaji.
1494
1495         check-webkit-style: _FunctionState should detect pure functions.
1496         https://bugs.webkit.org/show_bug.cgi?id=52428
1497
1498         * Scripts/webkitpy/style/checkers/cpp.py: Added detection for if a function declaration
1499         is a pure virtual function.
1500         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests for verifying that pure
1501         virtual functions are correctly detected.
1502
1503 2011-01-13  Ilya Tikhonovsky  <loislo@chromium.org>
1504
1505         Reviewed by Yury Semikhatsky.
1506
1507         Just small fix for problem with check-webkit-style.
1508         It just didn't work for this patch.
1509         Old code can't concatenate a list of strings with None.
1510
1511         * Scripts/webkitpy/common/checkout/scm.py:
1512
1513 2011-01-13  David Levin  <levin@chromium.org>
1514
1515         Reviewed by Shinichiro Hamaji.
1516
1517         check-webkit-style: _FunctionState should use Position to know where items are.
1518         https://bugs.webkit.org/show_bug.cgi?id=52424
1519
1520         * Scripts/webkitpy/style/checkers/cpp.py:
1521         (_FunctionState.*): Changed _FunctionState to use Position instead of line numbers.
1522         (detect_functions): Changed to pass Position's to _FunctionState.begin and
1523         did some minor clean-up.
1524         (*): Other changes are simply about converting to use the Position's in_FunctionState
1525         instead of line numbers.
1526         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Changed the test code
1527         to verify the positions stored in _FunctionState.
1528
1529 2011-01-13  Eric Seidel  <eric@webkit.org>
1530
1531         Reviewed by David Levin.
1532
1533         webkit-patch suggest-reviewers dies when ChangeLogs are missing
1534         https://bugs.webkit.org/show_bug.cgi?id=49158
1535
1536         This is not the most elegant, but it is a very safe fix to this bug.
1537         One advantage of catching ScriptError like this instead of adding a
1538         new added_or_modified_files or fixing all changed_files callers
1539         to use a more specific change_files variant, is that we catch
1540         all kinds of ScriptErrors which might cause our (non-essential)
1541         suggest-reviewers code to fail out.  This should make passing
1542         --suggest-reviewers to webkit-patch upload much more robust
1543         and may even make it possible for us to make it default.
1544
1545         The root of the problem here is that SCM.changed_files includes
1546         deleted ChangeLog paths (from moves, etc) which then when we ask
1547         SVN/Git for the contents of the file at that revision, the command
1548         errors out and Executive.run_command raises a ScriptError.
1549
1550         In the future we might fix this differently by making all current
1551         callers of chagned_files use a more specific method for requesting
1552         what types of changes they're interested in (adds, modifies, deletes, etc.)
1553
1554         * Scripts/webkitpy/common/checkout/api.py:
1555         * Scripts/webkitpy/common/checkout/api_unittest.py:
1556
1557 2011-01-13  Dan Bernstein  <mitz@apple.com>
1558
1559         Reviewed by Alexey Proskuryakov.
1560
1561         <rdar://problem/8827065> REGRESSION (r71884): Cross-origin XHR fails if willSendRequest changes the URL
1562         https://bugs.webkit.org/show_bug.cgi?id=52419
1563
1564         Allow to further control the behavior of the willSendRequest delegate callback by making it
1565         set a different URL in the new request.
1566
1567         * DumpRenderTree/LayoutTestController.cpp:
1568         (addURLToRedirectCallback): Added.
1569         (LayoutTestController::staticFunctions): Added addURLToRedirect.
1570         (LayoutTestController::addURLToRedirect): Added. Adds the redirection to the map.
1571         (LayoutTestController::redirectionDestinationForURL): Added this getter.
1572         * DumpRenderTree/LayoutTestController.h:
1573         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1574         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]): Check
1575         if there is a redirection for the request’s URL, established by addURLToRedirect(), and if so,
1576         change the URL in the new request to the redirect destination.
1577
1578 2011-01-13  Eric Seidel  <eric@webkit.org>
1579
1580         Reviewed by Mihai Parparita.
1581
1582         webkit-patch suggest-reviewers fails due to invalid utf8 in ChangeLog files
1583         https://bugs.webkit.org/show_bug.cgi?id=52416
1584
1585         Example: webkit-patch suggest-reviewers -g ca3890fe74d94d85d6bfa48f9ea497b094d8e717 
1586         UnicodeDecodeError: 'utf8' codec can't decode bytes in position 536-538: invalid data
1587
1588         I also added FIXMEs about the changed_files returning deleted files problem
1589         which is causing the other most common exception for suggest-reviewers
1590         (and is probably breaking sheriff-bots blame detection).
1591
1592         * Scripts/webkitpy/common/checkout/api.py:
1593         * Scripts/webkitpy/common/checkout/api_unittest.py:
1594         * Scripts/webkitpy/common/checkout/scm.py:
1595
1596 2011-01-13  Eric Seidel  <eric@webkit.org>
1597
1598         Reviewed by Adam Barth.
1599
1600         results archives from commit-queue are too large to upload
1601         https://bugs.webkit.org/show_bug.cgi?id=52405
1602
1603         * Scripts/webkitpy/common/system/filesystem.py:
1604         * Scripts/webkitpy/common/system/filesystem_mock.py:
1605         * Scripts/webkitpy/tool/commands/queues.py:
1606
1607 2011-01-13  Alejandro G. Castro  <alex@igalia.com>
1608
1609         Reviewed by Martin Robinson.
1610
1611         [gtk] Zero-sized font does not yet work
1612         https://bugs.webkit.org/show_bug.cgi?id=49793
1613
1614         Set minimum-font-size to 0 for the DRT.
1615
1616         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1617         (resetDefaultsToConsistentValues):
1618
1619 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
1620
1621         Reviewed by Darin Adler.
1622
1623         Make old-run-webkit-tests more robust on buildbots
1624         https://bugs.webkit.org/show_bug.cgi?id=52364
1625
1626         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Pass --exit-after-n-failures 500 to old-run-webkit-tests script.
1627
1628 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
1629
1630         Reviewed by Darin Adler.
1631
1632         Make old-run-webkit-tests more robust on buildbots
1633         https://bugs.webkit.org/show_bug.cgi?id=52364
1634
1635         * Scripts/old-run-webkit-tests: Ensure that testResultsDirectory is empty.
1636
1637 2011-01-13  Tony Chang  <tony@chromium.org>
1638
1639         Reviewed by Kent Tamura.
1640
1641         [chromium] fix plugins/plugin-javascript-access.html on Linux and Mac
1642         https://bugs.webkit.org/show_bug.cgi?id=52332
1643
1644         Forked Info.plist is not longer needed.
1645
1646         * DumpRenderTree/chromium/TestNetscapePlugIn/Info.plist: Removed.
1647
1648 2011-01-13  Mikhail Naganov  <mnaganov@chromium.org>
1649
1650         Reviewed by Timothy Hatcher.
1651
1652         Web Inspector: Cleanup after r75613 -- make all UI-facing strings
1653         to be passed directly to WebInspector.UIString
1654
1655         https://bugs.webkit.org/show_bug.cgi?id=52365
1656
1657         * Scripts/check-inspector-strings:
1658
1659 2011-01-13  Sheriff Bot  <webkit.review.bot@gmail.com>
1660
1661         Unreviewed, rolling out r74881.
1662         http://trac.webkit.org/changeset/74881
1663         https://bugs.webkit.org/show_bug.cgi?id=52357
1664
1665         The EFL builder has been red for days (Requested by abarth on
1666         #webkit).
1667
1668         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1669         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1670
1671 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
1672
1673         Reviewed by David Levin.
1674
1675         Add beforeunload support to WebKitTestRunner
1676         https://bugs.webkit.org/show_bug.cgi?id=52353
1677         
1678         This makes a number of currently failing tests pass.
1679
1680         * WebKitTestRunner/TestController.cpp:
1681         (WTR::runBeforeUnloadConfirmPanel):
1682         (WTR::createOtherPage):
1683         (WTR::TestController::initialize):
1684
1685 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
1686
1687         Reviewed by Sam Weinig.
1688
1689         Detect, identify and recover from WebProcess crashes in run-webkit-tests
1690         https://bugs.webkit.org/show_bug.cgi?id=52330
1691
1692         * Scripts/old-run-webkit-tests: Detect when the regression test tool reports
1693         a web process crash.
1694         * WebKitTestRunner/TestController.cpp:
1695         (WTR::TestController::initialize): Set up a processDidCrash
1696         callback.
1697         (WTR::TestController::processDidCrash): Report that the Web process
1698         crashed.
1699         * WebKitTestRunner/TestController.h:
1700
1701 2011-01-12  David Levin  <levin@chromium.org>
1702
1703         Reviewed by Shinichiro Hamaji.
1704
1705         check-webkit-style -- close_expression function doesn't work correctly.
1706         https://bugs.webkit.org/show_bug.cgi?id=52272
1707
1708         * Scripts/webkitpy/style/checkers/cpp.py:
1709         (Position.__str__): Added a way to convert it to a string which is useful in tests.
1710         (Position.__cmp__): Added a way to compare Position which is useful in tests and
1711         generally useful (for upcoming code changes).
1712         (close_expression): Changed to use Position for input and output.
1713         Also, fixed many bugs such as only working correctly for parenthesis,
1714         not working correctly if given an offset in a line and not finding
1715         the real closing element if there were multiple closing elements in
1716         the same line.
1717         (detect_functions): Adjusted due to the change in arguments for
1718         close_expression.
1719         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1720         (CppStyleTestBase.assert_positions_equal): Added a way to verify that
1721         two positions are the same.
1722         (CppStyleTest.test_position): Added tests for the __str_ and __cmp__ methods.
1723         (CppStyleTest.test_close_expression): Added tests to catch the issues
1724         that were fixed.
1725
1726 2011-01-12  Sheriff Bot  <webkit.review.bot@gmail.com>
1727
1728         Unreviewed, rolling out r75576.
1729         http://trac.webkit.org/changeset/75576
1730         https://bugs.webkit.org/show_bug.cgi?id=52304
1731
1732         broke rebaseline-chromium-webkit-test (Requested by thakis on
1733         #webkit).
1734
1735         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1736         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1737         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
1738         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1739         * Scripts/webkitpy/layout_tests/port/base.py:
1740         * Scripts/webkitpy/layout_tests/port/chromium.py:
1741         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1742         * Scripts/webkitpy/layout_tests/port/test.py:
1743         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1744         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1745         * Scripts/webkitpy/style/checkers/test_expectations.py:
1746         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1747
1748 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
1749
1750         Reviewed by Darin Adler.
1751
1752         Add a no-build option to run-webkit-tests, to avoid building DRT/WKTR
1753         https://bugs.webkit.org/show_bug.cgi?id=52307
1754
1755         * Scripts/old-run-webkit-tests:
1756
1757 2011-01-12  Koan-Sin Tan  <koansin.tan@gmail.com>
1758
1759         Reviewed by Martin Robinson.
1760
1761         [Gtk] WebKitGtk+ doesn't build on Mac OS X 10.6
1762         https://bugs.webkit.org/show_bug.cgi?id=50867
1763
1764         Fixed library extention for Mac in webkitdirs.pm and type conflict in
1765         TestNetscapePlugin.cpp 
1766
1767         * GNUmakefile.am: Don't use AppKit when compiling TestNetscapePlugin for GTK+
1768         * Scripts/webkitdirs.pm:
1769
1770 2011-01-12  Mikhail Naganov  <mnaganov@chromium.org>
1771
1772         Reviewed by Pavel Feldman.
1773
1774         Add check-inspector-strings script.
1775
1776         https://bugs.webkit.org/show_bug.cgi?id=52295
1777
1778         * Scripts/check-inspector-strings: Added.
1779
1780 2011-01-12  Adam Roben  <aroben@apple.com>
1781
1782         Advertise the .testnetscape file extension on Windows
1783
1784         Fixes <http://webkit.org/b/52298>
1785         plugins/no-mime-with-valid-extension.html fails on Windows
1786
1787         Reviewed by Dan Bernstein.
1788
1789         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Added a
1790         FileExtents field to map the .testnetscape file extension to the
1791         application/x-webkit-test-netscape MIME type, just as we do on Mac.
1792
1793 2011-01-12  Adam Barth  <abarth@webkit.org>
1794
1795         Reviewed by Eric Seidel.
1796
1797         Make webkit-patch support subdirectories for SVN checkouts
1798         https://bugs.webkit.org/show_bug.cgi?id=52261
1799
1800         os.relpath does not exist on Python 2.5, so we need to call our version
1801         of the API.
1802
1803         * Scripts/webkitpy/common/checkout/scm.py:
1804
1805 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
1806
1807         Reviewed by Eric Seidel.
1808
1809         Close additional pages opened during a test once the test completes.
1810         https://bugs.webkit.org/show_bug.cgi?id=52276
1811
1812         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1813         (WTR::InjectedBundle::done):
1814
1815 2011-01-11  David Levin  <levin@chromium.org>
1816
1817         Reviewed by Eric Seidel.
1818
1819         Errors should be separated from the command line in bot messages.
1820         https://bugs.webkit.org/show_bug.cgi?id=52275
1821
1822         * Scripts/webkitpy/common/system/executive.py:
1823         (ScriptError.message_with_output): Added a newline to separate the command
1824         line from the errors.
1825         * Scripts/webkitpy/common/system/executive_unittest.py:
1826         (ScriptErrorTest.test_message_with_output): Added tests for the various code
1827         paths in message_with_output.
1828
1829 2011-01-11  Eric Seidel  <eric@webkit.org>
1830
1831         Unreviewed.
1832
1833         commit-queue should know how to upload archived results (for test flakes or general failures)
1834         https://bugs.webkit.org/show_bug.cgi?id=52048
1835
1836         The zips are mostly empty due to forgetting -r.
1837         Expected diffs were not being pulled from the archive due
1838         to the archive having longer paths than I realized.
1839
1840         * Scripts/webkitpy/common/system/workspace.py:
1841         * Scripts/webkitpy/common/system/workspace_unittest.py:
1842         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1843         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1844
1845 2011-01-11  Dirk Pranke  <dpranke@chromium.org>
1846
1847         Reviewed by Ojan Vafai.
1848
1849         The current modifier parsing code in test_expectations is
1850         fragile and hard-coded, so it's not easy to understand the logic
1851         or easily add new types of modifiers (like GPU vs. CPU testing
1852         for graphics tests, or 32-bit vs. 64-bit differences).
1853
1854         This is the first of two patches that will add in more generic
1855         support and then eliminate the GPU-specific test expectations
1856         files for Chromium.
1857
1858         This patch adds two standalone objects for handling modifiers. The
1859         rules for interpreting modifiers, precedence, and conflicts are
1860         given in the docstring to the ModifierMatcher class, which
1861         returns ModifierMatchResult objects.
1862         
1863         This patch also adds routines to the Port interface and a
1864         default set of values in the base object, in order to obtain the
1865         values needed on a given test run. These values are then passed
1866         to the expectation parser. This also allows us to clean up the
1867         logic used to lint all of the different configurations in a
1868         single test_expectations.txt file.
1869
1870         The next patch will merge in the separate GPU expectations file.
1871
1872         https://bugs.webkit.org/show_bug.cgi?id=51222
1873
1874         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1875         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1876         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
1877         * Scripts/webkitpy/layout_tests/port/base.py:
1878         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1879         * Scripts/webkitpy/layout_tests/port/chromium.py:
1880         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1881         * Scripts/webkitpy/layout_tests/port/test.py:
1882         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1883         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1884
1885 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
1886
1887         Reviewed by Adam Barth.
1888
1889         Make webkit-patch support subdirectories for SVN checkouts
1890         https://bugs.webkit.org/show_bug.cgi?id=52261
1891
1892         * Scripts/webkitpy/common/checkout/scm.py:
1893         * Scripts/webkitpy/style_references.py:
1894         * Scripts/webkitpy/tool/main.py:
1895         * Scripts/webkitpy/tool/steps/preparechangelog.py:
1896
1897 2011-01-11  Eric Seidel  <eric@webkit.org>
1898
1899         Unreviewed.
1900
1901         commit-queue should know how to upload archived results (for test flakes or general failures)
1902         https://bugs.webkit.org/show_bug.cgi?id=52048
1903
1904         I changed the API for archive_last_layout_test_results w/o updating the implementation.  Oops.
1905         This fixes an exception seen on the commit-queue when attempting to report flaky tests.
1906
1907         * Scripts/webkitpy/common/system/workspace.py:
1908         * Scripts/webkitpy/common/system/workspace_unittest.py:
1909         * Scripts/webkitpy/tool/commands/queues.py:
1910
1911 2011-01-11  Sam Weinig  <sam@webkit.org>
1912
1913         Roll r75474 back in.
1914
1915 2011-01-11  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
1916
1917         Reviewed by Kenneth Rohde Christiansen.
1918
1919         [Qt] Remove uses of QFuture since it isn't supported on all platforms.
1920         https://bugs.webkit.org/show_bug.cgi?id=51204
1921
1922         * QtTestBrowser/webpage.h:
1923         (QtNAMThread::QtNAMThread):
1924         (QtNAMThread::networkAccessManager):
1925         (QtNAMThread::run):
1926
1927 2011-01-11  Peter Varga  <pvarga@webkit.org>
1928
1929         Unreviewed.
1930
1931         Add myself to committers' list.
1932
1933         * Scripts/webkitpy/common/config/committers.py:
1934
1935 2011-01-11  Eric Seidel  <eric@webkit.org>
1936
1937         Reviewed by Adam Barth.
1938
1939         commit-queue should know how to upload archived results (for test flakes or general failures)
1940         https://bugs.webkit.org/show_bug.cgi?id=52048
1941
1942         Now the queue will always upload results.  Either the entire zip, or just
1943         the diffs.txt in the case of text failures.
1944
1945         This should make understanding flakes much easier, and paves the way
1946         for having the EWS run layout tests (and upload failures).
1947
1948         In order to upload .zip files I had to teach bugzilla.py to autodetect
1949         mime types from the filename.  Since mimetypes.py doesn't include a mapping
1950         for .patch files, I have it add one before calling guess_type.
1951
1952         We may find that always uploading the whole zip instead of just the -diffs.txt
1953         file is preferable, but for now I'm keeping the old behavior because it makes
1954         quickly understanding text failures easy.
1955
1956         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1957         * Scripts/webkitpy/common/system/workspace.py: Added.
1958         * Scripts/webkitpy/common/system/workspace_unittest.py: Added.
1959         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1960         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1961         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1962         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1963         * Scripts/webkitpy/tool/commands/queues.py:
1964         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1965
1966 2011-01-10  Sheriff Bot  <webkit.review.bot@gmail.com>
1967
1968         Unreviewed, rolling out r75464.
1969         http://trac.webkit.org/changeset/75464
1970         https://bugs.webkit.org/show_bug.cgi?id=52193
1971
1972         Followup rollout for 75474 (Requested by Ossy on #webkit).
1973
1974         * MiniBrowser/mac/BrowserWindowController.m:
1975         (-[BrowserWindowController awakeFromNib]):
1976         * MiniBrowser/win/BrowserView.cpp:
1977         (BrowserView::create):
1978         * WebKitTestRunner/TestController.cpp:
1979         (WTR::createOtherPage):
1980         (WTR::TestController::initialize):
1981
1982 2011-01-10  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1983
1984         Reviewed by Csaba Osztrogonác.
1985
1986         [Qt] Baseline qt_minimal configuration
1987         https://bugs.webkit.org/show_bug.cgi?id=51313
1988
1989         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1990         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): Add
1991         QT_NO_UNDOSTACK guard.
1992
1993         * QtTestBrowser/launcherwindow.cpp:
1994         (LauncherWindow::createChrome): Add QT_NO_SHORTCUT and QT_NO_PRINTER
1995         guards.
1996         (LauncherWindow::applyZoom): Add QT_NO_ANIMATION guard.
1997         (LauncherWindow::screenshot): Add QT_NO_FILEDIALOG guard.
1998         (LauncherWindow::selectElements): Add QT_NO_INPUTDIALOG guard.
1999         (LauncherWindow::showUserAgentDialog): Add QT_NO_COMBOBOX guard.
2000
2001         * QtTestBrowser/launcherwindow.h:
2002         * QtTestBrowser/locationedit.cpp: Add QT_NO_INPUTDIALOG guard.
2003         * QtTestBrowser/locationedit.h: Ditto.
2004
2005         * QtTestBrowser/mainwindow.cpp:
2006         (MainWindow::buildUI): Add QT_NO_INPUTDIALOG, QT_NO_SHORTCUT and
2007         QT_NO_UNDOSTACK guards.
2008         (MainWindow::setAddressUrl): Add QT_NO_INPUTDIALOG guard.
2009         (MainWindow::changeLocation): Ditto.
2010         (MainWindow::openFile): Add QT_NO_FILEDIALOG guard.
2011         (MainWindow::openLocation): Add QT_NO_INPUTDIALOG guard.
2012
2013         * QtTestBrowser/webpage.cpp:
2014         (WebPage::openUrlInDefaultBrowser): Add QT_NO_DESKTOPSERVICES guard.
2015         (WebPage::authenticationRequired): Add QT_NO_LINEEDIT guard.
2016
2017         * QtTestBrowser/webview.cpp:
2018         (WebViewGraphicsBased::animatedFlip): Add QT_NO_ANIMATION guard.
2019         (WebViewGraphicsBased::animatedYFlip): Ditto.
2020
2021 2011-01-10  Sam Weinig  <sam@webkit.org>
2022
2023         Fix build.
2024
2025         * MiniBrowser/mac/BrowserWindowController.m:
2026         (-[BrowserWindowController awakeFromNib]):
2027         * MiniBrowser/win/BrowserView.cpp:
2028         (BrowserView::create):
2029         * WebKitTestRunner/TestController.cpp:
2030         (WTR::createOtherPage):
2031         (WTR::TestController::initialize):
2032
2033 2011-01-10  Eric Seidel  <eric@webkit.org>
2034
2035         Reviewed by Ojan Vafai.
2036
2037         style-queue messages are way too long for big patches
2038         https://bugs.webkit.org/show_bug.cgi?id=52161
2039
2040         We definitely could build much fancier list-to-string-with-limit functions
2041         but this should be sufficient for our needs at the moment.
2042
2043         * Scripts/webkitpy/common/system/executive.py:
2044         * Scripts/webkitpy/common/system/executive_unittest.py:
2045
2046 2011-01-10  Tony Chang  <tony@chromium.org>
2047
2048         Unreviewed, rolling out r75398.
2049         http://trac.webkit.org/changeset/75398
2050         https://bugs.webkit.org/show_bug.cgi?id=52008
2051
2052         Some layout tests are crashing on Chromium Win.
2053
2054         * DumpRenderTree/chromium/WebViewHost.cpp:
2055         (WebViewHost::updatePaintRect):
2056         * DumpRenderTree/chromium/WebViewHost.h:
2057
2058 2011-01-10  Adam Roben  <aroben@apple.com>
2059
2060         Roll out r75392
2061
2062         It isn't needed now that r75289 has been rolled out.
2063
2064         * Scripts/run-javascriptcore-tests:
2065
2066 2011-01-10  Maciej Stachowiak  <mjs@apple.com>
2067
2068         Reviewed by Anders Carlsson.
2069
2070         WebKitTestRunner uses crazy amounts of CPU, making layout tests slow and flaky
2071         https://bugs.webkit.org/show_bug.cgi?id=52160
2072
2073         * WebKitTestRunner/mac/TestControllerMac.mm:
2074         (WTR::TestController::platformRunUntil): Instead of busy-looping, wait for the timeout.
2075         Anything that can make runUntil() conditions turn true will happen on a run loop cycle
2076         anyway.
2077
2078 2011-01-10  Tony Chang  <tony@chromium.org>
2079
2080         Reviewed by Mihai Parparita.
2081
2082         [chromium] fix for animated gif layout tests
2083         https://bugs.webkit.org/show_bug.cgi?id=52008
2084
2085         * DumpRenderTree/chromium/WebViewHost.cpp: Schedule a paint when we update the paint rect
2086             to trigger gif animations.
2087         (WebViewHostPaintTask::WebViewHostPaintTask):
2088         (WebViewHostPaintTask::runIfValid):
2089         (WebViewHost::updatePaintRect):
2090         * DumpRenderTree/chromium/WebViewHost.h:
2091         (WebViewHost::taskList):
2092
2093 2011-01-10  Alejandro G. Castro  <alex@igalia.com>
2094
2095         Reviewed by Xan Lopez.
2096
2097         [GTK] Fix gtk2 compilation for master
2098         https://bugs.webkit.org/show_bug.cgi?id=51885
2099
2100         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
2101         (createBitmapContextFromWebView): Replaced the old
2102         gdk_drawable_get_size with gdk_pixmap_get_size.
2103
2104 2011-01-10  Patrick Gansterer  <paroga@webkit.org>
2105
2106         Reviewed by Laszlo Gombos.
2107
2108         [WINCE] Reenable NPAPI after r75203
2109         https://bugs.webkit.org/show_bug.cgi?id=52109
2110
2111         Remove the !isWinCE() check for ENABLE_NETSCAPE_PLUGIN_API and replace
2112         it with !isEfl(), because EFL port does not support NPAPI (yet).
2113
2114         * Scripts/build-webkit:
2115
2116 2011-01-10  Adam Roben  <aroben@apple.com>
2117
2118         Skip some asserting JS tests
2119
2120         See <http://webkit.org/b/52156>.
2121
2122         * Scripts/run-javascriptcore-tests:
2123
2124 2011-01-10  Martin Robinson  <mrobinson@igalia.com>
2125
2126         Reviewed by Xan Lopez.
2127
2128         [GTK] build-webkit disable Blob support via arguments passed to automake
2129         https://bugs.webkit.org/show_bug.cgi?id=52097
2130
2131         * Scripts/build-webkit: Enable Blob support when building WebKitGTK+ via
2132         build-webkit.
2133
2134 2011-01-10  Adam Roben  <aroben@apple.com>
2135
2136         Use the same name and description for TestNetscapePlugin on Windows and
2137         Mac
2138
2139         Fixes <http://webkit.org/b/52151>
2140         fast/frames/iframe-reparenting-plugins.html fails on Windows
2141
2142         Reviewed by Steve Falkenburg.
2143
2144         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Copied
2145         the name and description from Mac's Info.plist.
2146
2147 2011-01-10  Siddharth Mathur <siddharth.mathur@nokia.com>
2148
2149         Reviewed by Laszlo Gombos.
2150
2151         [Qt][WK2] Guard gcc-specific syntax
2152
2153         Non-gcc based compliers choke on the "-include"
2154         syntax for preinclude, place guard around it.
2155
2156         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2157         * WebKitTestRunner/qt/WebKitTestRunner.pro:
2158
2159 2011-01-10  Andreas Kling  <kling@webkit.org>
2160
2161         Reviewed by Simon Hausmann.
2162
2163         [Qt] [WK2] MiniBrowser does not load pages opened in new windows
2164         https://bugs.webkit.org/show_bug.cgi?id=52111
2165
2166         When getting a createNewPage() callback from QWKPage, create the
2167         new page with the same QWKContext as the page that is passed to
2168         the callback.
2169
2170         * MiniBrowser/qt/BrowserView.h:
2171         * MiniBrowser/qt/BrowserWindow.cpp:
2172         (newPageFunction):
2173         (BrowserWindow::BrowserWindow):
2174         * MiniBrowser/qt/BrowserWindow.h:
2175
2176 2011-01-10  Andreas Kling  <kling@webkit.org>
2177
2178         Reviewed by Kenneth Rohde Christiansen.
2179
2180         [Qt] MiniBrowser: Remove superfluous createNewPage() callback
2181
2182         BrowserView set its own useless createNewPage() callback on QWKPage.
2183         This was immediately overridden by BrowserWindow anyway, so remove
2184         the BrowserView one.
2185
2186         * MiniBrowser/qt/BrowserView.cpp:
2187         (BrowserView::BrowserView):
2188
2189 2011-01-10  John Knottenbelt  <jknotten@chromium.org>
2190
2191         Reviewed by Jeremy Orlow.
2192
2193         [Chromium] Remove non-client-based Geolocation code
2194         https://bugs.webkit.org/show_bug.cgi?id=50921
2195
2196         * DumpRenderTree/chromium/LayoutTestController.cpp:
2197         (LayoutTestController::setGeolocationPermission):
2198         (LayoutTestController::setMockGeolocationPosition):
2199         (LayoutTestController::setMockGeolocationError):
2200         * DumpRenderTree/chromium/WebViewHost.cpp:
2201         (WebViewHost::geolocationClientMock):
2202         (WebViewHost::reset):
2203         * DumpRenderTree/chromium/WebViewHost.h:
2204
2205 2011-01-10  Eric Seidel  <eric@webkit.org>
2206
2207         Reviewed by Adam Barth.
2208
2209         Commit bot tried to land r? cq+ patch
2210         https://bugs.webkit.org/show_bug.cgi?id=36638
2211
2212         It should now be possible to post a patch with r? and cq+ and the
2213         commit-queue will correctly wait for the r+ before attempting to land the patch.
2214         (This was a feature requested by several users.)
2215
2216         One caveat: We don't actually reject r-, cq+ patches from the queue
2217         (we just ignore them), but I think that's OK for now.
2218
2219         I also noticed that setting r- once a commit-queue node had grabbed
2220         a patch would not properly cancel the landing.  That's fixed and
2221         tested in this patch.
2222
2223         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2224         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2225         * Scripts/webkitpy/tool/bot/feeders.py:
2226         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
2227
2228 2011-01-08  Benjamin Poulain  <benjamin.poulain@nokia.com>
2229
2230         Reviewed by Kenneth Rohde Christiansen.
2231
2232         [Qt] QtWebKit crashes when using XMLHttpRequest from the unload event
2233         https://bugs.webkit.org/show_bug.cgi?id=51934
2234
2235         When accessing the network from the destructor of QWebPage, the network access manager
2236         was already deleted because the object WebPage was already destructed.
2237
2238         This solve the problem by linking the lifetime of the network access manager to WebPage's QObject.
2239         The object is now destructed in the destructor of QObject.
2240
2241         * QtTestBrowser/webpage.cpp:
2242         (WebPage::WebPage):
2243         (WebPage::setQnamThreaded):
2244         * QtTestBrowser/webpage.h:
2245         (QtNAMThread::QtNAMThread):
2246
2247 2011-01-08  Eric Seidel  <eric@webkit.org>
2248
2249         Reviewed by Ojan Vafai.
2250
2251         test_failures.py should not mention TestShell (long live DumpRenderTree!)
2252         https://bugs.webkit.org/show_bug.cgi?id=52067
2253
2254         I ran test-webkitpy, but didn't bother adding a unit test for this string change.
2255         https://bugs.webkit.org/show_bug.cgi?id=51138#c3 is an example of why this is needed.
2256
2257         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
2258
2259 2011-01-08  Eric Seidel  <eric@webkit.org>
2260
2261         Reviewed by Mihai Parparita.
2262
2263         commit-queue hangs when the ChangeLog diff is bad
2264         https://bugs.webkit.org/show_bug.cgi?id=52072
2265
2266         * Scripts/webkitpy/tool/steps/validatechangelogs.py:
2267         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
2268
2269 2011-01-08  Adam Barth  <abarth@webkit.org>
2270
2271         Teach svn-apply how to re-write WebCore to Source/WebCore.
2272
2273         * Scripts/VCSUtils.pm:
2274
2275 2011-01-07  Adam Barth  <abarth@webkit.org>
2276
2277         Rubber-stamped by Eric Seidel.
2278
2279         Move WebCore to Source
2280         https://bugs.webkit.org/show_bug.cgi?id=52050
2281
2282         Update the tools to understand WebCore's new location.
2283
2284         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2285         * DumpRenderTree/wscript:
2286         * GNUmakefile.am:
2287         * Scripts/build-webkit:
2288         * Scripts/do-file-rename:
2289         * Scripts/do-webcore-rename:
2290         * Scripts/generate-qt-inspector-resource:
2291         * Scripts/prepare-ChangeLog:
2292         * Scripts/run-bindings-tests:
2293         * Scripts/update-iexploder-cssproperties:
2294         * Scripts/update-sources-list.py:
2295         * Scripts/update-webkit-localizable-strings:
2296         * Scripts/webkitdirs.pm:
2297         * Scripts/webkitpy/common/config/build.py:
2298         * Scripts/webkitpy/common/config/build_unittest.py:
2299         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
2300         * Scripts/webkitpy/style/checker.py:
2301         * Scripts/webkitpy/style/checker_unittest.py:
2302         * WebKitTestRunner/DerivedSources.pro:
2303         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2304         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh:
2305         * wx/browser/wscript:
2306         * wx/build/settings.py:
2307
2308 2011-01-07  Maciej Stachowiak  <mjs@apple.com>
2309
2310         Reviewed by Sam Weinig.
2311
2312         Make WebKitTestRunner rest between loads more robust to avoid test crashes
2313         https://bugs.webkit.org/show_bug.cgi?id=52086
2314
2315         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2316         (WTR::InjectedBundle::didReceiveMessage):
2317         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2318         (WTR::LayoutTestController::notifyDone):
2319         * WebKitTestRunner/TestController.cpp:
2320         (WTR::TestController::resetStateToConsistentValues):
2321         (WTR::TestController::run):
2322
2323 2011-01-07  James Robinson  <jamesr@chromium.org>
2324
2325         Revert "Implement mozilla's animationTime property"
2326         https://bugs.webkit.org/show_bug.cgi?id=51952
2327
2328         This approach isn't quite right.
2329
2330         * DumpRenderTree/chromium/WebViewHost.cpp:
2331         (WebViewHost::paintInvalidatedRegion):
2332
2333 2011-01-07  Adam Roben  <aroben@apple.com>
2334
2335         Build master fix
2336
2337         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2338         (RunWebKitTests.start): Don't try to concatenate a list and a string.
2339
2340 2011-01-07  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>
2341
2342         Reviewed by Csaba Osztrogonác.
2343
2344         run-qtwebkit-tests should be able to kill a testsuite.
2345
2346         Add new option in the script that can setup a timeout for a test.
2347         If the test execution takes more then specified time then the test
2348         would be terminated.
2349
2350         [Qt] run-qtwebkit-tests needs timeout
2351         https://bugs.webkit.org/show_bug.cgi?id=51894
2352
2353         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2354         * Scripts/run-qtwebkit-tests:
2355
2356 2011-01-07  Csaba Osztrogonác  <ossy@webkit.org>
2357
2358         Unreviewed fix after r75233.
2359
2360         Based on idea from Eric Seidel.
2361
2362         Add remote zip file handling to webkitpy.
2363         https://bugs.webkit.org/show_bug.cgi?id=50901
2364
2365         * Scripts/webkitpy/common/system/fileset.py: Make python 2.5 happy.
2366
2367 2011-01-07  Shane Stephens  <shanestephens@google.com>
2368
2369         Reviewed by Eric Seidel.
2370
2371         svn-apply: should support git binary delta diffs
2372         https://bugs.webkit.org/show_bug.cgi?id=38864
2373
2374         * Scripts/VCSUtils.pm:
2375         * Scripts/svn-apply:
2376
2377 2011-01-06  Julie Parent  <jparent@chromium.org>
2378
2379         Reviewed by Eric Seidel.
2380
2381         Test Result Server not removing old results.
2382         https://bugs.webkit.org/show_bug.cgi?id=52012
2383
2384         * TestResultServer/model/jsonresults.py:
2385         Fix off-by-one: Truncate if >= num_runs, not just >.
2386         * TestResultServer/model/jsonresults_unittest.py:
2387         Add unit test to test that merging in a new result with the same value
2388         as the last result causes previous result to fall off.
2389
2390 2011-01-06  James Kozianski  <koz@chromium.org>
2391
2392         Reviewed by Mihai Parparita.
2393
2394         Add classes to provide a consistent interface to a set of files.
2395         https://bugs.webkit.org/show_bug.cgi?id=50901
2396
2397         These classes allow us to write code that is agnostic to whether a
2398         particular set of files resides in a local directory or in a zip file
2399         on a remote machine.
2400
2401         * Scripts/webkitpy/common/system/directoryfileset.py: Added.
2402         * Scripts/webkitpy/common/system/directoryfileset_unittest.py: Added.
2403         * Scripts/webkitpy/common/system/fileset.py: Added.
2404         * Scripts/webkitpy/common/system/filesystem.py:
2405         * Scripts/webkitpy/common/system/filesystem_mock.py:
2406         * Scripts/webkitpy/common/system/zipfileset.py: Added.
2407         * Scripts/webkitpy/common/system/zipfileset_unittest.py: Added.
2408
2409 2011-01-06  Eric Seidel  <eric@webkit.org>
2410
2411         Reviewed by Adam Barth.
2412
2413         NetworkTransaction should log the url it is retrying
2414         https://bugs.webkit.org/show_bug.cgi?id=52043
2415
2416         * Scripts/webkitpy/common/net/networktransaction.py:
2417         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
2418
2419 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
2420
2421         Windows build fix.
2422         Import os before using it.
2423
2424         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2425
2426 2011-01-06  Eric Seidel  <eric@webkit.org>
2427
2428         Reviewed by Adam Barth.
2429
2430         StyleQueue fails to report errors when patches have many files
2431         https://bugs.webkit.org/show_bug.cgi?id=52042
2432
2433         This is one of at least two errors preventing style error reporting at the moment.
2434         When we moved to passing the list of files to check explicitly,
2435         we started to exceed the 500 character TEXT field limit for our AppEngine model object.
2436         We could change the type of the QueueStatus.message type, or we could
2437         just teach statusserver.py how to clamp values (and warn when it does).
2438         I chose the latter path.
2439
2440         * Scripts/webkitpy/common/net/statusserver.py:
2441
2442 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
2443
2444         Reviewed by Stephanie Lewis.
2445         
2446         Fix syntax error in script.
2447
2448         Windows bots need to archive/unarchive builds to/from configuration-specific directories
2449         https://bugs.webkit.org/show_bug.cgi?id=51996
2450
2451         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2452
2453 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2454
2455         Unreviewed, fixing WinCE build after r75196.
2456
2457         WinCE port does not (yet) support NPAPI.
2458
2459         * Scripts/build-webkit:
2460
2461 2011-01-06  Xan Lopez  <xlopez@igalia.com>
2462
2463         Reviewed by Darin Adler.
2464
2465         File::Spec->rel2abs in sunspider-compare-results mangles parameters
2466         https://bugs.webkit.org/show_bug.cgi?id=52015
2467
2468         * Scripts/sunspider-compare-results: call rel2abs on our arguments
2469         after the platform has been detected, otherwise the script will
2470         mangle things like '--gtk' into '/a/path/--gtk', breaking the
2471         detection.
2472
2473 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2474
2475         Reviewed by Eric Seidel.
2476
2477         Add ENABLE_NETSCAPE_PLUGIN_API, ENABLE_ORIENTATION_EVENTS and ENABLE_TOUCH_EVENTS flags to build-webkit
2478         https://bugs.webkit.org/show_bug.cgi?id=51346
2479
2480         * Scripts/build-webkit:
2481
2482 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
2483
2484         Reviewed by Adam Roben.
2485
2486         Windows bots need to archive/unarchive builds to/from configuration-specific directories
2487         https://bugs.webkit.org/show_bug.cgi?id=51996
2488         
2489         After the configuration directory change, we were archiving the incorrect directory for
2490         build product, so we were running tests on the wrong binaries.
2491         
2492         This change archives the correct directory, and also unarchives it into a configuration-
2493         specific directory.
2494
2495         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Use a configuration-specific directory on Windows.
2496         * BuildSlaveSupport/built-product-archive: Unarchive/archive to/from proper directory.
2497
2498 2011-01-06  Eric Seidel  <eric@webkit.org>
2499
2500         Reviewed by Mihai Parparita.
2501
2502         commit-queue mentions "Text diff mismatch" 4 times instead of once per failure
2503         https://bugs.webkit.org/show_bug.cgi?id=52002
2504
2505         See an example of this here:
2506         https://bugs.webkit.org/show_bug.cgi?id=51314#c2
2507
2508         It's due to the fact that we pass around TestFailure() instance
2509         objects and yet expect them to all compare to be the same.
2510
2511         This is bad.  We should either have shared instances of these values
2512         or we should just pass around the class names.  There are already hacks
2513         in place to make TestFailure objects pass equality tests, I just added
2514         a __hash__ implementation so they can be used in sets as expected.
2515
2516         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2517         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
2518
2519 2011-01-06  Evan Martin  <evan@chromium.org>
2520
2521         Reviewed by Tony Chang.
2522
2523         [gdb] handle inaccessible memory and UChar*
2524         https://bugs.webkit.org/show_bug.cgi?id=52003
2525
2526         To pretty-print a UChar*, we just grope around in the memory
2527         looking for a terminating NUL.  We need to handle the exception
2528         that can occur when we poke into an invalid location.
2529
2530         Additionally, the logic for choosing which pretty-printer would
2531         early return before hitting the point where we'd use the UChar*
2532         printer.  (Did this ever work?  How did it regress?)
2533
2534         * gdb/webkit.py:
2535
2536 2011-01-05  Brian Weinstein  <bweinstein@apple.com>
2537
2538         Reviewed by Ada Chan.
2539
2540         WebKit2: Should be able to call into injected bundle to ask if we should allow resource loads
2541         https://bugs.webkit.org/show_bug.cgi?id=51969
2542         
2543         Add shouldLoadResourceForFrame to WTR::InjectedBundlePage.
2544
2545         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2546         (WTR::InjectedBundlePage::InjectedBundlePage):
2547         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Stub implementation.
2548         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2549
2550 2011-01-06  James Robinson  <jamesr@chromium.org>
2551
2552         Reviewed by Simon Fraser.
2553
2554         Implement mozilla's animationTime property
2555         https://bugs.webkit.org/show_bug.cgi?id=51952
2556
2557         Chromium DRT support for webkitAnimationTime.
2558
2559         * DumpRenderTree/chromium/WebViewHost.cpp:
2560         (WebViewHost::paintInvalidatedRegion):
2561
2562 2011-01-06  Julie Parent  <jparent@chromium.org>
2563
2564         Reviewed by Tony Chang.
2565
2566         Test Result Server always truncates number of results to JSON_RESULTS_MAX_BUILDS
2567         https://bugs.webkit.org/show_bug.cgi?id=51217
2568
2569         * TestResultServer/model/jsonresults.py:
2570         Pass num_runs through to _remove_items_over_max_number_of_builds, and use the value.
2571         Adds missing documentation.
2572         * TestResultServer/model/jsonresults_unittest.py:
2573         Add unit test to test that truncation happens at smaller value than JSON_RESULTS_MAX_BUILDS.
2574         Update test_merge to take a number of builds to truncate at.
2575
2576 2011-01-06  Adam Barth  <abarth@webkit.org>
2577
2578         Reviewed by Eric Seidel.
2579
2580         The EWS should log outside of the working directory
2581         https://bugs.webkit.org/show_bug.cgi?id=51986
2582
2583         This patch prepare us for using git clean -x -d -f in the EWS wrapper
2584         script, which will actually clean the working copy back to a pristine
2585         state instead of leaving untracked directories and ignored files.
2586
2587         * Scripts/webkitpy/tool/commands/queues.py:
2588         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2589
2590 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
2591
2592         Windows build fix.
2593         Back out attempted change to built-product-archive.
2594
2595         * BuildSlaveSupport/built-product-archive:
2596
2597 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
2598
2599         Windows build fix.
2600         Include configuration name when unpacking a build archive.
2601
2602         Needed, since we split Windows build results into configuration-specific directories
2603         under WebKitOutputDir.
2604
2605         * BuildSlaveSupport/built-product-archive:
2606
2607 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
2608
2609         Reviewed by Darin Adler.
2610
2611         Debug and Release builds on Windows clobber each other
2612         https://bugs.webkit.org/show_bug.cgi?id=49185
2613
2614         Changes the structure of WebKitBuild build products directory so we
2615         completely separate each build configuration into independent directories.
2616         
2617         Although we previously had per-configuration directories for obj, this change adds
2618         per-configuration directories for bin, lib, obj, and include. Each configuration's
2619         build products are stored within a directory inside of WebKitBuild.
2620         
2621         Most use of $(WebKitOutputDir) in the build files has been replaced by $(ConfigurationBuildDir),
2622         defined in common.vsprops to be $(WebKitOutputDir)\$(ConfigurationName).
2623
2624         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops:
2625         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd:
2626         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd:
2627         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
2628         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd:
2629         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd:
2630         * DumpRenderTree/win/ImageDiffCommon.vsprops:
2631         * DumpRenderTree/win/ImageDiffPostBuild.cmd:
2632         * DumpRenderTree/win/ImageDiffPreBuild.cmd:
2633         * FindSafari/FindSafari.vcproj:
2634         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
2635         * MiniBrowser/MiniBrowserPostBuild.cmd:
2636         * MiniBrowser/MiniBrowserPreBuild.cmd:
2637         * Scripts/webkitdirs.pm:
2638         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
2639         * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops:
2640         * TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd:
2641         * TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd:
2642         * TestWebKitAPI/win/copy-resources.cmd:
2643         * WebKitAPITest/WebKitAPITestCommon.vsprops:
2644         * WebKitAPITest/WebKitAPITestPostBuild.cmd:
2645         * WebKitAPITest/WebKitAPITestPreBuild.cmd:
2646         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
2647         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
2648         * WebKitTestRunner/win/InjectedBundle.vcproj:
2649         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops:
2650         * WebKitTestRunner/win/InjectedBundlePostBuild.cmd:
2651         * WebKitTestRunner/win/InjectedBundlePreBuild.cmd:
2652         * WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd:
2653         * WebKitTestRunner/win/WebKitTestRunnerPreBuild.cmd:
2654         * WinLauncher/WinLauncherCommon.vsprops:
2655         * WinLauncher/WinLauncherPostBuild.cmd:
2656         * WinLauncher/WinLauncherPreBuild.cmd:
2657
2658 2011-01-05  Jan Erik Hanssen  <jhanssen@sencha.com>
2659
2660         Reviewed by Ariya Hidayat.
2661
2662         [Qt] TestNetscapePlugin doesn't link on OS X
2663         https://bugs.webkit.org/show_bug.cgi?id=51948
2664
2665         Only add a dependency on libX11 on X11 systems
2666
2667         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2668
2669 2011-01-05  Jeff Miller  <jeffm@apple.com>
2670
2671         Reviewed by Adam Roben.
2672
2673         check-webkit-style should allow unnecessary parameter names in WebKit2 APIs because we're matching CF's header style
2674         https://bugs.webkit.org/show_bug.cgi?id=51970
2675
2676         * Scripts/webkitpy/style/checker.py:
2677         Add -readability/naming for WebKit2 C API directories.
2678
2679 2011-01-05  Eric Seidel  <eric@webkit.org>
2680
2681         Unreviewed, just fixing one more log error from my previous python patch.
2682
2683         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
2684         https://bugs.webkit.org/show_bug.cgi?id=51802
2685
2686         webkit-patch failure-reason was logging about parsing errors
2687         due to my misunderstanding of how BeautifulSoup.findAll worked.
2688
2689         Fixed, and added a unit test.
2690
2691         * Scripts/webkitpy/common/net/layouttestresults.py:
2692         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2693
2694 2011-01-05  Benjamin Poulain  <benjamin.poulain@nokia.com>
2695
2696         Reviewed by Kenneth Rohde Christiansen.
2697
2698         [Qt] [WK2] Add the possibility to open window from the WebProcess in Minibrowser
2699         https://bugs.webkit.org/show_bug.cgi?id=51951
2700
2701         Set a function to QWKPage::setCreateNewPageFunction() in Minibrowser so there is a way
2702         to create new window from WebKit.
2703
2704         * MiniBrowser/qt/BrowserWindow.cpp:
2705         (newPageFunction):
2706         (BrowserWindow::BrowserWindow):
2707         (BrowserWindow::page): Added to avoid the indirect access to QWKPage spread in the class
2708         (BrowserWindow::newWindow):
2709         (BrowserWindow::updateUserAgentList):
2710         (BrowserWindow::showUserAgentDialog):
2711         * MiniBrowser/qt/BrowserWindow.h: Add the global variable backingStoreTypeForNewWindow to
2712         define the type of the backing store used for new windows.
2713         * MiniBrowser/qt/main.cpp:
2714         (main):
2715
2716 2011-01-05  Eric Seidel  <eric@webkit.org>
2717
2718         Reviewed by Ojan Vafai.
2719
2720         commit-queue should report failure type when reporting flaky tests
2721         https://bugs.webkit.org/show_bug.cgi?id=51900
2722
2723         This patch was a ridiculous amount of plumbing.  In the end I like
2724         the NRWT-style TestResult class even less.  But now we're passing
2725         a list of TestResult objects from the queue to the FlakyTestReporter.
2726         Thus the FlakyTestReporter can more easily report what type of failure
2727         occurred.
2728
2729         In the process, I found that I was not alone in finding TestResult
2730         cumbersome to use.  A bunch of code was trying to create a TestResult
2731         object with default values.  However since the constructor didn't make
2732         this easy, some places were getting it wrong (including the TestResult unit test)!
2733         I've fixed the TestResult constructor to have default values for non-essential
2734         arguments.
2735
2736         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2737         * Scripts/webkitpy/common/net/layouttestresults.py:
2738         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2739         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2740         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2741         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2742         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
2743         * Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py:
2744         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2745         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2746         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2747         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2748         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2749         * Scripts/webkitpy/tool/commands/queues.py:
2750         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2751
2752 2011-01-05  Eric Seidel  <eric@webkit.org>
2753
2754         Unreviewed.
2755
2756         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
2757         https://bugs.webkit.org/show_bug.cgi?id=51802
2758
2759         Add another unit test to cover a previously missing import.
2760
2761         * Scripts/webkitpy/common/net/layouttestresults.py:
2762         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2763
2764 2011-01-05  Mihai Parparita  <mihaip@chromium.org>
2765
2766         Reviewed by David Levin.
2767
2768         Add mihaip@chromium.org as a reviewer
2769         https://bugs.webkit.org/show_bug.cgi?id=51966
2770         
2771         Add myself as a reviewer.
2772
2773         * Scripts/webkitpy/common/config/committers.py:
2774
2775 2011-01-05  James Simonsen  <simonjam@chromium.org>
2776
2777         Unreviewed. Adding myself to the list of committers.
2778
2779         * Scripts/webkitpy/common/config/committers.py:
2780
2781 2011-01-05  Eric Seidel  <eric@webkit.org>
2782
2783         Unreviewed.
2784
2785         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
2786         https://bugs.webkit.org/show_bug.cgi?id=51802
2787
2788         Fix two exceptions seen on the bots after my original commit.
2789
2790         * Scripts/webkitpy/common/net/layouttestresults.py:
2791         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2792
2793 2011-01-05  Kundu Suchismita  <suchi.kundu@nokia.com>
2794
2795         Reviewed by Andreas Kling.
2796
2797         [Qt]Add local storage settings to QtTestBrowser command line arguments 
2798         https://bugs.webkit.org/show_bug.cgi?id=51750
2799
2800         * QtTestBrowser/main.cpp:
2801         (LauncherApplication::handleUserOptions):
2802          Local storage settings can be enable form command line arguments for
2803          QtTestBrowser.
2804
2805 2011-01-05  Chris Fleizach  <cfleizach@apple.com>
2806
2807         Reviewed by Martin Robinson.
2808
2809         GTK: AX: DRT needs to use correct root object method.
2810         https://bugs.webkit.org/show_bug.cgi?id=51911
2811
2812         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
2813         (AccessibilityController::rootElement):
2814
2815 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
2816
2817         Rubber-stamped by Csaba Osztrogonác.
2818
2819         Based on idea from Péter Gál.
2820
2821         * Scripts/webkitpy/tool/bot/sheriff.py: Remove unnecessary apostrophes around revision numbers.
2822
2823 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
2824
2825         Reviewed by Adam Barth.
2826
2827         sheriff-bot should be able to do multi-revision rollouts
2828         https://bugs.webkit.org/show_bug.cgi?id=51176
2829
2830         * Scripts/webkitpy/tool/bot/irc_command.py:
2831         * Scripts/webkitpy/tool/bot/sheriff.py:
2832         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
2833
2834 2011-01-05  Eric Seidel  <eric@webkit.org>
2835
2836         Reviewed by Adam Barth.
2837
2838         queues.webkit.org should have per-bot status pages
2839         https://bugs.webkit.org/show_bug.cgi?id=51906
2840
2841         Just adds a /queue-status/QUEUE_NAME/bots/BOT_ID page to show
2842         statuses from a single queue.  Now that we have many bots servicing
2843         some queues (commit-queue, win-ews, etc.) its easy to have the messages
2844         you care about scroll off the end of the 15-message limit on the main page.
2845
2846         Eventually we should probably rename /queue-status to /queue or /queues,
2847         but that's fodder for another patch.
2848
2849         * QueueStatusServer/handlers/queuestatus.py:
2850         * QueueStatusServer/index.yaml:
2851         * QueueStatusServer/main.py:
2852         * QueueStatusServer/templates/includes/singlequeuestatus.html:
2853          - This probably should use a custom filter instead of hard-coding
2854            the URL scheme here, but I couldn't figure out how to easily
2855            create such a filter.  Most filters work with "strings" so we can't
2856            pass the status object.  We could add a method to the status
2857            object and call that, but that seemed a bit strange too.
2858         * QueueStatusServer/templates/queuestatus.html:
2859
2860 2011-01-05  Carlos Garcia Campos  <cgarcia@igalia.com>
2861
2862         Unreviewed. Adding myself to the list of committers.
2863
2864         * Scripts/webkitpy/common/config/committers.py:
2865
2866 2011-01-04  Koan-Sin Tan  <koansin.tan@gmail.com>
2867
2868         Reviewed by David Levin.
2869
2870         check-webkit-style treated some macros with parentheses after #elif as function calls
2871         https://bugs.webkit.org/show_bug.cgi?id=51695
2872
2873         Ingore function call space checking in any preprocessor directives
2874         (things starting with #). Change search() to match() because 
2875         preprocessor directives are supposed to be in the beginning of lines.
2876
2877         * Scripts/webkitpy/style/checkers/cpp.py:
2878         * Scripts/webkitpy/style/checkers/cpp_unittest.py: make sure there is no false positives for #elif cases
2879
2880 2011-01-04  Søren Gjesse  <sgjesse@chromium.org>
2881
2882         Reviewed by Tony Chang.
2883
2884         Change the --multi-load test option to --stress-opt
2885         https://bugs.webkit.org/show_bug.cgi?id=50751
2886
2887         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2888         (runTest):
2889         (main):
2890         * DumpRenderTree/chromium/TestShell.cpp:
2891         (TestShell::TestShell):
2892         * DumpRenderTree/chromium/TestShell.h:
2893         (TestShell::stressOpt):
2894         (TestShell::setStressOpt):
2895         (TestShell::stressDeopt):
2896         (TestShell::setStressDeopt):
2897         (TestShell::javaScriptFlags):
2898         (TestShell::setJavaScriptFlags):
2899         * Scripts/webkitpy/layout_tests/port/chromium.py:
2900         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2901
2902 2011-01-04  Chris Fleizach  <cfleizach@apple.com>
2903
2904         Reviewed by Sam Weinig.
2905
2906         WK2: Support Accessibility
2907         https://bugs.webkit.org/show_bug.cgi?id=51859
2908
2909         Use rootObject() method to get top of accessibility tree.
2910
2911         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
2912         (AccessibilityController::focusedElement):
2913         (AccessibilityController::rootElement):
2914
2915 2011-01-03  Martin Robinson  <mrobinson@igalia.com>
2916
2917         Reviewed by Darin Adler.
2918
2919         Remove the last non-GObject usage of PlatformRefPtr and move the code to GRefPtr
2920         https://bugs.webkit.org/show_bug.cgi?id=51846
2921
2922         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: Change usage of PlatformRefPtr
2923         back to GRefPtr.
2924
2925 2011-01-04  Zhe Su  <suzhe@chromium.org>
2926
2927         Reviewed by Kenneth Russell.
2928
2929         Fix insertText, setMarkedText and unmarkText methods of
2930         TextInputController to call corresponding methods of WebKit::WebView
2931         rather than WebKit::WebFrame. This change matches the behavior of
2932         chromium browser.
2933         insertText corresponds to WebView::confirmComposition(text)
2934         setMarkedText corresponds to WebView::setComposition(...)
2935         unmarkText corresponds to WebView::confirmComposition()
2936         https://bugs.webkit.org/show_bug.cgi?id=51693
2937
2938         * DumpRenderTree/chromium/TextInputController.cpp:
2939         (TextInputController::insertText):
2940         (TextInputController::setMarkedText):
2941         (TextInputController::unmarkText):
2942
2943 2011-01-04  Dihan Wickremasuriya  <dihan.wickremasuriya@nokia.com>
2944
2945         Reviewed by Laszlo Gombos.
2946
2947         [Qt] [Symbian] Do not remove 0 byte sized files from productDir
2948
2949         On Symbian productDir points to the source directory. Removing all the
2950         empty files from the productDir directory corrupts the svn repository.
2951
2952         * Scripts/build-webkit:
2953
2954 2011-01-03  Yi Shen  <yi.4.shen@nokia.com>
2955
2956         Reviewed by Adam Barth.
2957
2958         [Qt] Add SelectAll option to the context menu for the editor
2959         https://bugs.webkit.org/show_bug.cgi?id=50049
2960
2961         Set shortcut for the SelectAll action.
2962
2963         * QtTestBrowser/mainwindow.cpp:
2964         (MainWindow::buildUI):
2965
2966 2011-01-03  David Levin  <levin@chromium.org>
2967
2968         Reviewed by Eric Seidel.
2969
2970         check-webkit-style shouldn't consider "value" automatically to be a meaningless name.
2971         https://bugs.webkit.org/show_bug.cgi?id=51842
2972
2973         * Scripts/webkitpy/style/checkers/cpp.py: Remove the check for value.
2974         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Remove the test for value.
2975
2976 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
2977
2978         Reviewed by David Kilzer.
2979
2980         [WINCE] Adds a build slave.
2981         https://bugs.webkit.org/show_bug.cgi?id=50523
2982
2983         * BuildSlaveSupport/build.webkit.org-config/config.json: Add an
2984         entry for a release build of the WinCE port.
2985         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add platform
2986         flag to build the WinCE port.
2987
2988 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
2989
2990         Reviewed by David Kilzer.
2991
2992         Add WinCE support to build-webkit
2993         https://bugs.webkit.org/show_bug.cgi?id=51642
2994
2995         * Scripts/build-webkit:
2996         * Scripts/webkitdirs.pm:
2997
2998 2011-01-03  Eric Seidel  <eric@webkit.org>
2999
3000         Reviewed by Adam Barth.
3001
3002         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
3003         https://bugs.webkit.org/show_bug.cgi?id=51802
3004
3005         I'm not the biggest fan of the test_failures or test_results classes,
3006         but it's better to have one shared set of classes, than separate ones
3007         for new vs. old run-webkit-test result handling.
3008
3009         This moves the ORWT results class "LayoutTestResults" over to using
3010         TestResult and TestFailure classes, making it easy for us to
3011         make all our sheriff-bot and other webkitpy code NRWT ready.
3012
3013         This also makes it a trivial patch to generate results.json information
3014         from ORWT results.html files (for flaky test analysis, etc.) as well
3015         as making it a one-liner to report test failure types when the
3016         commit-queue sees flaky tests.
3017
3018         This patch tried not to add new functionality, but only to replace
3019         the guts of LayoutTestResults, while adding unit tests and hoping
3020         not to break anything.
3021
3022         I also moved callers which assumed User.prompt* were static/class methods
3023         to using them as instance methods (since we'll eventually want to make them such).
3024
3025         In the process of re-writing things, I broke the rebaseline command, so I wrote
3026         a unit test to catch my breakage were I do do so again in the future.
3027
3028         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3029         * Scripts/webkitpy/common/net/layouttestresults.py:
3030         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3031         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
3032         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
3033         * Scripts/webkitpy/tool/commands/queries.py:
3034         * Scripts/webkitpy/tool/commands/rebaseline.py:
3035         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3036         * Scripts/webkitpy/tool/mocktool.py:
3037
3038 2011-01-03  Adam Barth  <abarth@webkit.org>
3039
3040         Reviewed by Simon Fraser.
3041
3042         webkit-patch shouldn't waste time cleaning a working directory that's already clean
3043         https://bugs.webkit.org/show_bug.cgi?id=51840
3044
3045         * Scripts/webkitpy/common/checkout/scm.py:
3046
3047 2011-01-03  Adam Barth  <abarth@webkit.org>
3048
3049         Reviewed by Simon Fraser.
3050
3051         webkit-patch should only hide update output if --quiet
3052         https://bugs.webkit.org/show_bug.cgi?id=51838
3053
3054         As requested by smfr.
3055
3056         * Scripts/webkitpy/tool/steps/update.py:
3057
3058 2011-01-03  Adam Barth  <abarth@webkit.org>
3059
3060         Reviewed by David Levin.
3061
3062         commit-queue shouldn't reject patches twice if two bots process the same patch
3063         https://bugs.webkit.org/show_bug.cgi?id=51805
3064
3065         Before raising an error, we first check whether the patch is still in
3066         the commit-queue.  This check is still racy, of course, but the time
3067         window is much smaller.
3068
3069         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3070
3071 2011-01-03  Sam Weinig  <sam@webkit.org>
3072
3073         Reviewed by Anders Carlsson.
3074
3075         Make run-api-tests less chatty.
3076         https://bugs.webkit.org/show_bug.cgi?id=51831
3077
3078         - Make script quiet by default and add --verbose option (replacing --quiet).
3079         - When not verbose, pipe stdout and stderr to devnull.
3080
3081         * Scripts/run-api-tests:
3082
3083 2011-01-03  Pratik Solanki  <psolanki@apple.com>
3084
3085         Unreviewed. Adding myself to committers.py.
3086
3087         * Scripts/webkitpy/common/config/committers.py:
3088
3089 2011-01-03  Koan-Sin Tan  <koansin.tan@gmail.com>
3090
3091         Reviewed by Xan Lopez.
3092
3093         "Tool/Scripts/run-launcher --gtk" stopped working after 74855
3094         https://bugs.webkit.org/show_bug.cgi?id=51806
3095
3096         Originally, the $libraryName is 'JavaScriptCore'. When building release 
3097         one, the $libraryDir was 'WebKitBuild/Release/JavaScriptCore/../.libs/'
3098         which doesn't exist anymore ('WebKitBuild/Release/JavaScriptCore'
3099         is 'WebKitBuild/Release/Source/JavaScriptCore' now), and 
3100         'WebKitBuild/Release/Source/JavaScriptCore/../../.libs' looks weird,
3101         so make it 'WebKitBuild/Release/.libs'
3102
3103         * Scripts/webkitdirs.pm: 
3104
3105 2011-01-02  Patrick Gansterer  <paroga@webkit.org>
3106
3107         Reviewed by Adam Barth.
3108
3109         Make EFL a core builder
3110         https://bugs.webkit.org/show_bug.cgi?id=51804
3111
3112         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
3113         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3114
3115 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
3116
3117         [Qt] Unreviewed fix after r74855 and r74875.
3118
3119         * BuildSlaveSupport/built-product-archive:
3120          - Create directories explicitly.
3121          - Pass shell=True to subprocess.call().
3122
3123 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
3124
3125         [Qt] Unreviewed fix after r74855.
3126
3127         Move JavaScriptCore to Source
3128         https://bugs.webkit.org/show_bug.cgi?id=51604
3129
3130         * BuildSlaveSupport/built-product-archive: JavaScriptCore -> Source/JavaScriptCore
3131
3132 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
3133
3134         [Qt] Unreviewed run-javasriptcore-tests fix after r74855.
3135
3136         Move JavaScriptCore to Source
3137         https://bugs.webkit.org/show_bug.cgi?id=51604
3138
3139         * Scripts/webkitdirs.pm:
3140
3141 2011-01-02  Robert Hogan  <robert@webkit.org>
3142
3143         Unreviewed, build fix.
3144
3145         [Qt] Fix DRT build after 74855
3146
3147         * DumpRenderTree/qt/DumpRenderTree.pro:
3148
3149 2011-01-01  Adam Barth  <abarth@webkit.org>
3150
3151         Remove the assumption from the Qt and Gtk builds that every project is
3152         in the root directory.
3153
3154         * Scripts/build-webkit:
3155
3156 2011-01-01  Adam Barth  <abarth@webkit.org>
3157
3158         Reviewed by Eric Seidel.
3159
3160         Teach svn-apply how to apply patches even though JavaScriptCore has moved
3161         https://bugs.webkit.org/show_bug.cgi?id=51796
3162
3163         After this change, svn-apply will magically apply patches to
3164         JavaScriptCore/foo to Source/JavaScriptCore/foo.
3165
3166         * Scripts/VCSUtils.pm:
3167
3168 2011-01-01  Adam Barth  <abarth@webkit.org>
3169
3170         Reviewed by Eric Seidel.
3171
3172         Move JavaScriptCore to Source
3173         https://bugs.webkit.org/show_bug.cgi?id=51604
3174
3175         Update references to JavaScriptCore to point to the new location.
3176
3177         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3178         * DumpRenderTree/qt/DumpRenderTree.pro:
3179         * DumpRenderTree/qt/ImageDiff.pro:
3180         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3181         * DumpRenderTree/wscript:
3182         * Scripts/build-jsc:
3183         * Scripts/build-webkit:
3184         * Scripts/do-file-rename:
3185         * Scripts/do-webcore-rename:
3186         * Scripts/run-javascriptcore-tests:
3187         * Scripts/update-javascriptcore-test-results:
3188         * Scripts/webkitdirs.pm:
3189         * Scripts/webkitpy/common/config/build_unittest.py:
3190         * Scripts/webkitpy/style/checker.py:
3191         * Scripts/webkitpy/style/checker_unittest.py:
3192         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3193         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3194         * WebKitTestRunner/qt/WebKitTestRunner.pro:
3195         * wx/build/settings.py:
3196
3197 2011-01-01  Adam Barth  <abarth@webkit.org>
3198
3199         Reviewed by Eric Seidel.
3200
3201         Move Sources to Source
3202         https://bugs.webkit.org/show_bug.cgi?id=51794
3203
3204         Update scripts to point to the new location.
3205
3206         * Scripts/build-webkit:
3207         * Scripts/do-file-rename:
3208         * Scripts/do-webcore-rename:
3209         * Scripts/webkitpy/common/config/build.py:
3210         * Scripts/webkitpy/common/config/build_unittest.py:
3211
3212 2010-12-31  Kent Tamura  <tkent@chromium.org>
3213
3214         Reviewed by Eric Seidel.
3215
3216         [DRT/Chromium] Enable mock spell checker on non-OSX
3217         https://bugs.webkit.org/show_bug.cgi?id=51401
3218
3219         * DumpRenderTree/chromium/WebViewHost.cpp:
3220         (WebViewHost::spellCheck):
3221
3222 2010-12-31  Adam Barth  <abarth@webkit.org>
3223
3224         Reviewed by Ariya Hidayat.
3225
3226         Remove Tools/Scripts/wkstyle
3227         https://bugs.webkit.org/show_bug.cgi?id=51774
3228
3229         This script appears to not have been touched in a while and seems to
3230         have been replaced by check-webkit-style.
3231
3232         * Scripts/wkstyle: Removed.
3233
3234 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
3235
3236         Unreviewed. Coding style fix.
3237
3238         * DumpRenderTree/chromium/TestShell.h:
3239
3240 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
3241
3242         Reviewed by Pavel Feldman.
3243
3244         Web Inspector: [Chromium] Inspector's tests are very slow on Win(Dbg).
3245
3246         It was a problem with Chromium DRT. DevToolsAgent object instance was
3247         attached not only to the inspected page but to the DevTools window too.
3248         As result all the inspector files were interpreted as a content of inspected page
3249         and were transfered to the DevTools scripts panel for debugging etc.
3250
3251         https://bugs.webkit.org/show_bug.cgi?id=51735
3252
3253         * DumpRenderTree/chromium/TestShell.cpp:
3254         (TestShell::TestShell):
3255         (TestShell::bindJSObjectsToWindow):
3256         (TestShell::createNewWindow):
3257         * DumpRenderTree/chromium/TestShell.h:
3258
3259 2010-12-31  Adam Barth  <abarth@webkit.org>
3260
3261         Rubber-stamped by Eric Seidel.
3262
3263         Move PageLoadTests to PerformanceTests/PageLoad
3264         https://bugs.webkit.org/show_bug.cgi?id=51771
3265
3266         Update references to PageLoadTests to point to the new location.
3267
3268         * Scripts/run-pageloadtest:
3269         * Scripts/webkitpy/common/config/build.py:
3270
3271 2010-12-31  Adam Barth  <abarth@webkit.org>
3272
3273         Rubber-stamped by Eric Seidel.
3274
3275         Move SunSpider into PerformanceTests
3276         https://bugs.webkit.org/show_bug.cgi?id=51769
3277
3278         Update these scripts to point to the new location.
3279
3280         * Scripts/run-sunspider:
3281         * Scripts/sunspider-compare-results:
3282
3283 2010-12-30  Mihai Parparita  <mihaip@chromium.org>
3284
3285         Reviewed by Kent Tamura.
3286
3287         [Chromium] Add WebThemeEngineDRTMac so that Chromium DRT scrollbar rendering can match the Mac port's
3288         https://bugs.webkit.org/show_bug.cgi?id=51728
3289         
3290         Add implementation of the Mac WebThemeEngine that uses an NSScroller
3291         to render top-level scrollbars. This makes them match the Mac port's
3292         use of an NSScrollView, which means that we'll be able to share more
3293         pixel baselines.
3294         
3295         The new rendering code will not be activated until the 
3296         USE_WEB_THEME_ENGINE_TO_PAINT_THUMB #define is fliped in
3297         ScrollbarThemeChromiumMac.
3298
3299         * DumpRenderTree/DumpRenderTree.gypi:
3300         * DumpRenderTree/chromium/TestShellMac.mm:
3301         (platformInit):
3302         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Added.
3303         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Added.
3304         (+[FakeActiveWindow alwaysActiveWindow]):
3305         (+[FakeActiveWindow alwaysInactiveWindow]):
3306         (-[FakeActiveWindow initWithActiveControls:]):
3307         (-[FakeActiveWindow _hasActiveControls]):
3308         (WebThemeEngineDRTMac::paintScrollbarThumb):
3309         (stateToHIEnableState):
3310         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
3311         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
3312
3313 2010-12-30  Konstantin Tokarev  <annulen@yandex.ru>
3314
3315         Reviewed by David Kilzer.
3316
3317         [Qt] Don't build wtf/TCSystemAlloc.cpp if --system-malloc option is
3318         used
3319         https://bugs.webkit.org/show_bug.cgi?id=51672
3320
3321         * DumpRenderTree/qt/DumpRenderTree.pro: Replaced USE_SYSTEM_MALLOC
3322         with USE_SYSTEM_MALLOC=1
3323         * WebKitTestRunner/qt/WebKitTestRunner.pro: Replaced USE_SYSTEM_MALLOC
3324         with USE_SYSTEM_MALLOC=1
3325
3326 2010-12-30  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3327
3328         Reviewed by David Kilzer.
3329
3330         [Qt] [Symbian] Fix build-webkit script for Symbian
3331         https://bugs.webkit.org/show_bug.cgi?id=51509
3332
3333         Set the OUTPUT_DIR for Symbian to be the same as the source
3334         directory.
3335
3336         * Scripts/webkitdirs.pm:
3337
3338 2010-12-30  Martin Robinson  <mrobinson@igalia.com>
3339
3340         Reviewed by Darin Adler.
3341
3342         check-webkit-style should ignore NULL usage in calls to gtk_widget_style_get
3343         https://bugs.webkit.org/show_bug.cgi?id=51758
3344
3345         Add a check-webkit-style exception for gtk_widget_style_get and NULL usage.
3346
3347         * Scripts/webkitpy/style/checkers/cpp.py: Add the exception.
3348         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Add some tests for this.
3349
3350 2010-12-29  Patrick Gansterer  <paroga@webkit.org>
3351
3352         Unreviewed WinCE buildfix.
3353
3354         * WinCELauncher/main.cpp: Add missing include.
3355
3356 2010-12-29  Daniel Bates  <dbates@rim.com>
3357
3358         Reviewed by Darin Adler.
3359
3360         svn-apply updates date of wrong change log entry for a change log diff that
3361         contains two consecutive entries with the same author and date
3362         https://bugs.webkit.org/show_bug.cgi?id=46061
3363
3364         Fixes an issue where the date of the wrong change log entry may be modified.
3365         Moreover, changes fixChangeLogPatch() to move entries inserted earlier
3366         in a ChangeLog file to the top of the file.
3367
3368         Currently, fixChangeLogPatch() explicitly bails out and returns an unchanged
3369         diff when it detects that the diff inserts a change log entry earlier in a
3370         ChangeLog. It is unusual to land a patch that has such a deliberate ChangeLog
3371         change. With the advent of the commit-queue this functionality of bailing out
3372         and hence landing the patch as-is is harmful to the accuracy of the ChangeLog.
3373         Instead, we should always move the change log entry to the top of the ChangeLog file.
3374
3375         A side-effect of this change is that setChangeLogDateAndReviewer() now updates
3376         the date line of the correct change log entry in a ChangeLog diff.
3377
3378         * Scripts/VCSUtils.pm: Modified fixChangeLogPatch() to move entries inserted earlier to the top.
3379
3380         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
3381           Updated the following unit tests now that we move entries inserted earlier to the top:
3382           - "fixChangeLogPatch: New entry inserted in middle."
3383             (formerly named "fixChangeLogPatch: [no change] New entry inserted in middle.")
3384
3385           - "fixChangeLogPatch: New entry inserted earlier in the file, but after an entry with the same author and date."
3386             (formerly named "fixChangeLogPatch: [no change] New entry inserted earlier in the file, but after an entry with the same author and date.")
3387
3388         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatchThenSetChangeLogDateAndReviewer.pl: Added.
3389
3390 2010-12-29  Konstantin Tokarev  <annulen@yandex.ru>
3391
3392         Reviewed by Eric Seidel.
3393
3394         [Qt] Fixed compatibility with gold linker on X11 platforms
3395         https://bugs.webkit.org/show_bug.cgi?id=51700
3396
3397         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3398         Linked TestNetscapePlugin with libX11 on Unix platforms
3399
3400 2010-12-29  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>
3401
3402         Reviewed by Darin Adler.
3403
3404         Circular dependency in webkitpy.common.checkout.changelog module
3405         https://bugs.webkit.org/show_bug.cgi?id=50475
3406
3407         Remove automatic import of api.Checkout module when any checkout/
3408         submodule is imported (e.g.: when checkout.scm.Git is imported).
3409
3410         * Scripts/webkitpy/common/checkout/__init__.py:
3411
3412 2010-12-29  Martin Robinson  <mrobinson@igalia.com>
3413
3414         Reviewed by Ojan Vafai.
3415
3416         prepare-ChangeLog should support the -g option for specifying the git-commit
3417         https://bugs.webkit.org/show_bug.cgi?id=51708
3418
3419         Add a -g shortcut for the --git-commit prepare-ChangeLog option. This matches
3420         webkit-patch, though the exact meaning of the two options remain different.
3421
3422         * Scripts/prepare-ChangeLog: Add -g.
3423
3424 2010-12-29  Kent Hansen  <kent.hansen@nokia.com>
3425
3426         Reviewed by Simon Hausmann.
3427
3428         [Qt] Fix compilation with Qt in namespace
3429         https://bugs.webkit.org/show_bug.cgi?id=51701
3430
3431         * QtTestBrowser/webview.h:
3432
3433 2010-12-28  Daniel Bates  <dbates@rim.com>
3434
3435         Reviewed by Sam Weinig.
3436
3437         Substitute // MARK: for compiler-specific #pragma mark
3438         https://bugs.webkit.org/show_bug.cgi?id=51657
3439
3440         Fix future compilation warnings about "#pragma mark" on GTK+ bots by
3441         substituting  "// MARK:" for "#pragma mark", which provides
3442         analogous code-bookmarking functionality under Xcode.
3443
3444         Also, for consistency, we should substitute "// MARK:" for compiler-
3445         specific "#pragma mark" in the source files for the Mac port.
3446
3447         * DumpRenderTree/AccessibilityTextMarker.cpp:
3448         * DumpRenderTree/cf/WebArchiveDumpSupport.h:
3449         * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm:
3450         * DumpRenderTree/mac/ObjCController.m:
3451         * MiniBrowser/mac/AppDelegate.m:
3452         * MiniBrowser/mac/BrowserWindowController.m:
3453
3454 2010-12-28  Xan Lopez  <xlopez@igalia.com>
3455
3456         Reviewed by Eric Seidel.
3457
3458         Add --no-build option to run-sunspider
3459         https://bugs.webkit.org/show_bug.cgi?id=51658
3460
3461         * Scripts/run-sunspider: add --no-build flag to skip building
3462         phase.
3463
3464 2010-12-27  Daniel Bates  <dbates@rim.com>
3465
3466         Rubber-stamped by Martin Robinson.
3467
3468         Append the directory Tools/DumpRenderTree to the list of directories that
3469         do-webcore-rename should search so that it can rename DRT files and
3470         source code.
3471
3472         * Scripts/do-webcore-rename:
3473
3474 2010-12-27  Eric Seidel  <eric@webkit.org>
3475
3476         Reviewed by Adam Barth.
3477
3478         build-webkit should detect missing Java SDK and explain how to install it
3479         https://bugs.webkit.org/show_bug.cgi?id=51651
3480
3481         * Scripts/build-webkit:
3482
3483 2010-12-26  Martin Robinson  <mrobinson@igalia.com>
3484
3485         Reviewed by Daniel Bates.
3486
3487         [GTK] Add support for build-jsc
3488         https://bugs.webkit.org/show_bug.cgi?id=51625
3489
3490         Add GTK+ support to build-jsc now that building the jsc executable as
3491         a standalone target is easy.
3492
3493         * Scripts/build-jsc: Call buildGtkProject for the GTK+ case now.
3494         * Scripts/build-webkit: Pass in the proper target name to buildGtkProject.
3495         * Scripts/webkitdirs.pm: Actually process the project parameter in buildGtkProject
3496         and pass it along to buildAutotoolsProject.
3497
3498 2010-12-27  David Levin  <levin@chromium.org>
3499
3500         Reviewed by Eric Seidel.
3501
3502         check-webkit-style check for meaningless variable names in function declarations.
3503         https://bugs.webkit.org/show_bug.cgi?id=51523
3504
3505         * Scripts/webkitpy/style/checker.py: Exempted JavaScriptCore/jit/JITStubs.cpp
3506         from the new check and whitespace/parens because the syntax is unusual and
3507         produced a fair number of positives for these checks.
3508         * Scripts/webkitpy/style/checkers/cpp.py:
3509         (_convert_to_lower_with_underscores): Used as a canonical form for type names
3510         and parameter names when determining if the parameter name is useless.
3511         (_create_acronym): Used to check for redundant variable names in cases like "ExceptionCode ec"
3512         (Parameter.lower_with_underscores_name): Gives back the parameter name in a lower_with_underscore
3513         format.
3514         (_check_parameter_name_against_text):  Checks to see if the parameter name is in the
3515         text or an acronym of it.
3516         (check_function_definition): Checks function definitions for meaningless variable names.
3517         (process_line): Added call to check_function_definition.
3518         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3519         (CppFunctionsTest.test_convert_to_lower_with_underscores): Test for _convert_to_lower_with_underscores.
3520         (CppFunctionsTest.test_create_acronym): Test for _create_acronym.
3521         (CppFunctionsTest.test_check_parameter_against_text): Test for _check_parameter_against_text.
3522         (CppStyleTestBase.perform_single_line_lint): Removed the parameter name check
3523         because when only checking a snippet, there are a lot of bogus functions.
3524         (CppStyleTestBase.perform_multi_line_lint): Ditto and removed a bogus filter
3525         that I put there previously and just noticed.
3526         (WebKitStyleTest.test_parameter_names): Tests for the functionality -- both
3527         check_function_definition and process_line.
3528
3529 2010-12-27  Carlos Garcia Campos  <cgarcia@igalia.com>
3530
3531         Reviewed by Martin Robinson.
3532
3533         [GTK] Disable flash plugin in GtkLauncher when using gtk3
3534         https://bugs.webkit.org/show_bug.cgi?id=51591
3535
3536         Flash plugin uses gtk2 that is incompatible with gtk3 making
3537         webkit crash when it's built with gtk3.
3538
3539         * GtkLauncher/main.c:
3540         (main):
3541
3542 2010-12-25  Adam Barth  <abarth@webkit.org>
3543
3544         Reviewed by Eric Seidel.
3545
3546         Move ANGLE to Sources/ThirdParty
3547         https://bugs.webkit.org/show_bug.cgi?id=51605
3548
3549         * Scripts/build-webkit:
3550           - Point to the new ANGLE location.
3551
3552 2010-12-26  David Levin  <levin@chromium.org>
3553
3554         Reviewed by Eric Seidel.
3555
3556         check-webkit-style should be able to parse function declaration parameters.
3557         https://bugs.webkit.org/show_bug.cgi?id=51451
3558
3559         * Scripts/webkitpy/style/checkers/cpp.py:
3560         (Position.__init__): Holds simple position information (row, column).
3561         (Parameter.__init__): Holds information about a parameter.
3562         (SingleLineView.__init): Converts multiple lines into a single line for simpler searches.
3563         (SingleLineView.convert_column_to_row): Returns the original row given a column.
3564         (create_skeleton_parameters): Simplifies a parameter list for easier searching.
3565         (find_parameter_name_index): Finds where the parameter name is.
3566         (parameter_list): Generates the list of parameters for a function.
3567         (_FunctionState.begin): Added information to allow determining the parameters
3568         on demand.
3569         (_FunctionState.get_parameter_list): Returns a tuple of function parameters.
3570         (detect_functions): Improve function detection for operator functions and
3571         determine where the parameters end and pass that to _FunctionState.begin.
3572         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3573         (CppFunctionsTest.test_parameter): Verifies Parameter functionality.
3574         (CppFunctionsTest.test_single_line_view): Verifies SingleLineView functionality.
3575         (CppFunctionsTest.test_create_skeleton_parameters): Verifies create_skeleton_parameters.
3576         (CppFunctionsTest.test_find_parameter_name_index): Verifies find_parameter_name_index.
3577         (CppFunctionsTest.test_parameter_list): Does some minimal verification for parameter list.
3578         Much more thorough verification is done as part of FunctionDetectionTest.test_parameter_list.
3579         (FunctionDetectionTest.perform_function_detection): Added support for verifying
3580         the parameters found.
3581         (FunctionDetectionTest.test_function_declaration_detection): Added more function
3582         detection test to verify that we catch the operator functions.
3583         (FunctionDetectionTest.test_ignore_macros): Verify that function detection ignores macros.
3584         (FunctionDetectionTest.test_parameter_list): Added tests to verify the parameter parsing.
3585         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_bad_test_doesnt_break): Removed
3586         because the error. The test is about the bad function name. Fixing the name makes the test exactly like
3587         test_function_length_check_definition_severity1_for_test.
3588
3589 2010-12-25  Patrick Gansterer  <paroga@webkit.org>
3590
3591         Unreviewed WinCE buildfix after r74334.
3592
3593         * CMakeListsWinCE.txt:
3594
3595 2010-12-24  Sheriff Bot  <webkit.review.bot@gmail.com>
3596
3597         Unreviewed, rolling out r74632.
3598         http://trac.webkit.org/changeset/74632
3599         https://bugs.webkit.org/show_bug.cgi?id=51600
3600
3601         makes test-webkitpy hang forever on GTK (Requested by philn-tp
3602         on #webkit).
3603
3604         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
3605         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
3606
3607 2010-12-24  Ryuan Choi  <ryuan.choi@samsung.com>
3608
3609         Reviewed by Kenneth Rohde Christiansen.
3610
3611         [EFL] Screen doesn't be rendered when changing size of EWebLauncher
3612         https://bugs.webkit.org/show_bug.cgi?id=43528
3613
3614         Remove on_resize because ewk_view_fixed_layout_size_set should not be
3615         called on callback of EVAS_CALLBACK_RESIZE. As it change size of
3616         FrameView, rendering was ignored when _ewk_view_smart_calculate was
3617         called.
3618
3619         * EWebLauncher/main.c:
3620         (browserCreate):
3621
3622 2010-12-24  Eric Seidel  <eric@webkit.org>
3623
3624         Reviewed by Adam Barth.
3625
3626         webkit-patch (or a pre-commit hook) needs to prevent bad ChangeLog changes
3627         https://bugs.webkit.org/show_bug.cgi?id=28291
3628
3629         This is a start.  At least now webkit-patch will prompt when your ChangeLog looks questionable.
3630         We could do more advanced things, like parsing the ChangeLog (with changelog.py) and comparing that
3631         to strings with find in the diff.
3632         Since non-interactive always returns the default, this should cause patches with bad changelogs to fail on the commit-queue.
3633
3634         * Scripts/webkitpy/common/checkout/api.py:
3635         * Scripts/webkitpy/common/checkout/diff_parser.py:
3636         * Scripts/webkitpy/tool/steps/abstractstep.py:
3637         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
3638         * Scripts/webkitpy/tool/steps/validatechangelogs.py: Copied from Tools/Scripts/webkitpy/tool/steps/validatereviewer.py.
3639         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py: Copied from Tools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.
3640         * Scripts/webkitpy/tool/steps/validatereviewer.py:
3641
3642 2010-12-24  Dirk Pranke  <dpranke@chromium.org>
3643
3644         Reviewed by Kenneth Russell.
3645
3646         Modify new-run-webkit-tests to shut up and exit when all the threads
3647         are wedged so that test runs complete faster and we don't end up
3648         w/ enormous log files.
3649
3650         https://bugs.webkit.org/show_bug.cgi?id=51572
3651
3652         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
3653         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
3654
3655 2010-12-24  Eric Seidel  <eric@webkit.org>
3656
3657         Reviewed by David Levin.
3658
3659         commit-queue should better explain how it will re-open bugs and follow duplicate chains
3660         https://bugs.webkit.org/show_bug.cgi?id=51549
3661
3662         I've had multiple people ask me about the commit-queue's behavior
3663         regarding reporting flaky tests.  I figured it would be best to just
3664         have the queue explain itself in the bugs it files.
3665
3666         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3667         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3668
3669 2010-12-24  Shinichiro Hamaji  <hamaji@chromium.org>
3670
3671         Reviewed by Eric Seidel.
3672
3673         check-webkit-style: should ignore "wrong" namings in JavaScriptCore/qt
3674         https://bugs.webkit.org/show_bug.cgi?id=51467
3675
3676         * Scripts/webkitpy/style/checker.py:
3677         * Scripts/webkitpy/style/checker_unittest.py:
3678
3679 2010-12-23  Adam Barth  <abarth@webkit.org>
3680
3681         Rubber-stamped by Eric Seidel.
3682
3683         Move JavaScriptGlue into Sources
3684         https://bugs.webkit.org/show_bug.cgi?id=51583
3685
3686         These tools refer to JavaScriptGlue and need to be updated to its new
3687         location.
3688
3689         * Scripts/build-webkit:
3690         * Scripts/do-file-rename:
3691         * Scripts/do-webcore-rename:
3692         * Scripts/webkitpy/common/config/build.py:
3693         * Scripts/webkitpy/common/config/build_unittest.py:
3694
3695 2010-12-23  Lucas Forschler  <lforschler@apple.com>
3696
3697         Reviewed by Eric Seidel.
3698
3699         Bug 51539 - update iexploder scripts to point to new location
3700
3701         * Scripts/run-iexploder-tests:
3702         * Scripts/update-iexploder-cssproperties:
3703
3704 2010-12-23  Evan Martin  <evan@chromium.org>
3705
3706         Reviewed by Ryosuke Niwa.
3707
3708         [chromium] LayoutTestController warning in float->int conversion
3709         https://bugs.webkit.org/show_bug.cgi?id=51553
3710
3711         Rather than reading an int, converting to a float, then getting a compiler
3712         warning on passing the float to something that expects an int, instead
3713         just pass around ints.
3714
3715         No tests, fixes a compiler warning.
3716
3717         * DumpRenderTree/chromium/LayoutTestController.cpp:
3718         (parsePageSizeParameters):
3719         (LayoutTestController::pageNumberForElementById):
3720         (LayoutTestController::numberOfPages):
3721
3722 2010-12-23  Lucas Forschler  <lforschler@apple.com>
3723
3724         Reviewed by Darin Adler.
3725
3726         Bug 51537 - iexploder needs cleanup
3727         
3728         * iExploder/htdocs: Removed.
3729         * iExploder/htdocs/config.rb: Removed.
3730         * iExploder/htdocs/cssproperties.in: Removed.
3731         * iExploder/htdocs/cssvalues.in: Removed.
3732         * iExploder/htdocs/htmlattrs.in: Removed.
3733         * iExploder/htdocs/htmltags.in: Removed.
3734         * iExploder/htdocs/htmlvalues.in: Removed.
3735         * iExploder/htdocs/iexploder.cgi: Removed.
3736         * iExploder/htdocs/iexploder.rb: Removed.
3737         * iExploder/htdocs/index.html: Removed.
3738         * iExploder/htdocs/webserver.rb: Removed.
3739         * iExploder/iexploder-1.7.2/output: Removed.
3740         * iExploder/tools: Removed.
3741         * iExploder/tools/lasthit.rb: Removed.
3742         * iExploder/tools/osx_last_crash.rb: Removed.
3743         * iExploder/tools/showtest.rb: Removed.
3744
3745 2010-12-23  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
3746
3747         Reviewed by Kenneth Rohde Christiansen.
3748
3749         [EFL] Make 'single' the default backing store in EWebLauncher
3750         https://bugs.webkit.org/show_bug.cgi?id=51534
3751
3752         'single' is the simplest backing store and the one intended to be the
3753         default in the test browser. By mistake the tiled backing store was
3754         left as default in r72617.
3755
3756         * EWebLauncher/main.c:
3757         (browserCreate): ditto.
3758
3759 2010-12-23  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
3760
3761         Reviewed by Kenneth Rohde Christiansen.
3762
3763         [EFL] Subject: [webkit 4/4] [EFL] Remove non-sense workaround
3764         https://bugs.webkit.org/show_bug.cgi?id=51533
3765
3766         There's no point in concatenating env("HOME") with "blah", so remove
3767         option from EWebLauncher.
3768
3769         * EWebLauncher/main.c:
3770         (main): ditto.
3771
3772 2010-12-23  Ilya Tikhonovsky  <loislo@chromium.org>
3773
3774         Reviewed by Eric Seidel.
3775
3776         Web Inspector: chromium: inspector's tests are quite slow especially at windows(Debug).
3777
3778         Almost all inspector's tests become flaky on chromium Win(dbg) after switching to DRT.
3779         I just discovered that we have two additional GC runs per each WebViewHost.
3780         Test_shell had no such calls.
3781         These gc runs eat 15% of cpu time.
3782
3783         https://bugs.webkit.org/show_bug.cgi?id=51479
3784
3785         * DumpRenderTree/chromium/WebViewHost.cpp:
3786         (WebViewHost::~WebViewHost):
3787
3788 2010-12-22  Dirk Pranke  <dpranke@chromium.org>
3789
3790         Reviewed by Ojan Vafai.
3791
3792         This change splits out the TestRunner class into its own file.
3793         When we fork the code for message passing, we will create a new
3794         TestRunner, and this change will allow that to be more modular.
3795
3796         While we're at it, split out TestInput and ResultSummary into
3797         their own files, to reduce the size of run_webkit_tests to
3798         something more managable.
3799
3800         https://bugs.webkit.org/show_bug.cgi?id=51092
3801
3802         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
3803         * Scripts/webkitpy/layout_tests/layout_package/result_summary.py:
3804         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
3805         * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
3806         * Scripts/webkitpy/layout_tests/layout_package/test_input.py:
3807         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3808         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3809
3810  2010-12-22  Dirk Pranke  <dpranke@chromium.org>
3811
3812         Reviewed by Ojan Vafai.
3813
3814         nrwt multiprocessing - start over, prepare to fork the code
3815  
3816         This code cleans up the signatures and implementation of the
3817         TestRunner class so we can easily fork it to run either the
3818         stable implementation or the new, unstable message-passing
3819         implementation. The two variants will have different
3820         implementations of the run_tests() method. We will switch
3821         between the two based on the setting for the '--worker-model'
3822         switch. We rename the two currently valid values to 'old-inline'
3823         and 'old-threads'.
3824
3825         https://bugs.webkit.org/show_bug.cgi?id=51081
3826
3827         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3828         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3829
3830 2010-12-22  Victor Wang  <victorw@chromium.org>
3831
3832         Reviewed by Darin Fisher.
3833
3834         [Chromium] Update chromium archive test result url in rebaseline script.
3835
3836         https://bugs.webkit.org/show_bug.cgi?id=51503
3837
3838         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
3839
3840 2010-12-22  Lucas Forschler  <lforschler@apple.com>
3841
3842         Reviewed by Alice Liu.
3843
3844         <rdar://problem/8633222> record-memory-win needs to record memory used by the webprocess.
3845         Verified on Chrome, Safari, and IE.
3846         With this change, we will record memory from a parent browser window and all child processes.
3847
3848         * record-memory-win/main.cpp:
3849         (ProcessArgs):
3850         (PrintUsage):
3851         (getMemoryInfo):
3852         (printProcessInfo):
3853         (evalProcesses):
3854         (UseImage):
3855         (QueryContinuously):
3856         (ElapsedTime):
3857
3858 2010-12-22  Lucas Forschler  <lforschler@apple.com>
3859
3860         Unreviewed rollout r74489, because it was missing changelog.
3861
3862         * record-memory-win/main.cpp:
3863         
3864 2010-12-22  Ryosuke Niwa  <rniwa@webkit.org>
3865
3866         Adding myself as a reviewer.
3867
3868         * Scripts/webkitpy/common/config/committers.py:
3869
3870 2010-12-22  Andrew Scherkus  <scherkus@chromium.org>
3871
3872         Unreviewed.  Adding myself to committers.py.
3873
3874         * Scripts/webkitpy/common/config/committers.py:
3875
3876 2010-12-22  Ariya Hidayat  <ariya@sencha.com>
3877
3878         Reviewed by Kenneth Rohde Christiansen.
3879
3880         TestNetscapePlugIn should use #if defined
3881         https://bugs.webkit.org/show_bug.cgi?id=51471
3882
3883         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3884         (NP_Initialize):
3885         (NPP_New):
3886
3887 2010-12-22  Ilya Tikhonovsky  <loislo@chromium.org>
3888
3889         Reviewed by Yury Semikhatsky.
3890
3891         Web Inspector: [chromium] DRT inspector layout tests are flaky in debug.
3892
3893         DevTools window should be closed explicitly because it has custom deinitialization code.
3894
3895         https://bugs.webkit.org/show_bug.cgi?id=50722
3896
3897         * DumpRenderTree/chromium/TestShell.cpp:
3898         (TestShell::closeRemainingWindows):
3899
3900 2010-12-22  David Levin  <levin@chromium.org>
3901
3902         Reviewed by Shinichiro Hamaji.
3903
3904         check-webkit-style shouldn't complaint about underscores in variables in objective C files.
3905         https://bugs.webkit.org/show_bug.cgi?id=51452
3906
3907         * Scripts/webkitpy/style/checkers/cpp.py:
3908         (_FileState.__init__): Added the information to determine if a file is C or Objective C.
3909         Using the file extension if possible but falling back to the file contents if we have a header file.
3910         (_FileState.is_objective_c): Determine if we have an Objective C by examining the file contents if needed.
3911         (_FileState.is_c_or_objective_c):
3912         (check_using_std): Changed to using _FileState to determine the file type.
3913         (check_max_min_macros): Ditto.
3914         (check_for_null): Ditto.
3915         (check_style): Changed the parameters to various calls since they now need _FileState
3916         to determine the file type.
3917         (check_language): Added the file_state parameter so it could be passed
3918         to check_identifier_name_in_declaration.
3919         (check_identifier_name_in_declaration): Don't warn about underscores in variables if
3920         this is an Objective C file.
3921         (_process_lines): Added information for the _FileState constructor (and moved the
3922         call to a place that had the information).
3923         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3924         (CppFunctionsTest.test_is_c_or_objective_c): Changed the tests to use FileState and exercise
3925         its functionality.
3926         (WebKitStyleTest.test_names): Add tests for underscores in Objective C files.
3927
3928 2010-12-21  Andy Estes  <aestes@apple.com>
3929
3930         Reviewed by Mark Rowe.
3931
3932         Do not build non-Intel architectures for WebKit2-related projects.
3933         https://bugs.webkit.org/show_bug.cgi?id=51440
3934
3935         * MiniBrowser/Configurations/Base.xcconfig: Only build for i386 and x86_64.
3936         * TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
3937         * WebKitTestRunner/Configurations/Base.xcconfig: Ditto.
3938
3939 2010-12-21  Mihai Parparita  <mihaip@chromium.org>
3940
3941         Reviewed by Darin Fisher.
3942
3943         [Chromium] Rename WebThemeEngine/ControlDRT to WebThemeEngine/ControlDRTWin
3944         https://bugs.webkit.org/show_bug.cgi?id=51406 
3945         
3946         Rename WebThemeControlDRT to WebThemeControlDRTWin and WebThemeEngineDRT
3947         to WebThemeEngineDRTWin and update references everywhere.
3948
3949         * DumpRenderTree/DumpRenderTree.gypi:
3950         * DumpRenderTree/chromium/TestShellWin.cpp:
3951         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRT.cpp.
3952         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRT.h.
3953         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRT.cpp.
3954         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRT.h.
3955
3956 2010-12-21  Anders Carlsson  <andersca@apple.com>
3957
3958         Reviewed by John Sullivan.
3959
3960         Clicking missing plug-in text does not show a sheet
3961         https://bugs.webkit.org/show_bug.cgi?id=51403
3962
3963         Update for changes to the WebPageUIClient.
3964
3965         * MiniBrowser/mac/BrowserWindowController.m:
3966         (-[BrowserWindowController awakeFromNib]):
3967         * WebKitTestRunner/TestController.cpp:
3968         (WTR::createOtherPage):
3969         (WTR::TestController::initialize):
3970
3971 2010-12-21  Eric Seidel  <eric@webkit.org>
3972
3973         Reviewed by Adam Barth.
3974
3975         commit-queue will report constant failures as flaky if other tests flake
3976         https://bugs.webkit.org/show_bug.cgi?id=51272
3977
3978         This patch just removes functionality and adds testing.
3979         Previously we attempted to report flaky tests when we had
3980         two different tests fail in a row.  However, since we stop
3981         running the tests at the first failure, our code was wrong in
3982         trying to determine flakiness from the incomplete runs.
3983
3984         Originally I posted an alternate patch:
3985         https://bug-51272-attachments.webkit.org/attachment.cgi?id=77078
3986         which fixed our flaky logic in this case, however it was decided
3987         that that patch would be too difficult to maintain, so now
3988         I'm just removing the broken logic.
3989
3990         This will dramatically cut-down on our flaky-test false positives
3991         at the (small) cost of the queues being unable to report
3992         any flakiness if the tree is very flaky.  (With at least one test
3993         flaking on every run, we'll never report failures anymore.)  I think
3994         this is a tradeoff worth making.
3995
3996         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3997         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3998
3999 2010-12-20  Eric Seidel  <eric@webkit.org>
4000
4001         Reviewed by Adam Barth.
4002
4003         commit-queue wrongly rejects patches when it can't update itself
4004         https://bugs.webkit.org/show_bug.cgi?id=46636
4005
4006         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
4007         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
4008         * Scripts/webkitpy/tool/commands/queues_unittest.py:
4009
4010 2010-12-20  Adam Barth  <abarth@webkit.org>
4011
4012         Move web sites to Websites directory
4013         https://bugs.webkit.org/show_bug.cgi?id=51323
4014
4015         Update references to BugsSite to point to the new location.
4016
4017         This patch was never officially reviewed (because it was too large to
4018         upload to bugs.webkit.org), but it was discussed on webkit-dev and Mark
4019         Rowe gave me the green light.
4020
4021         * Scripts/old-run-webkit-tests:
4022         * Scripts/webkitpy/common/config/build.py:
4023         * Scripts/webkitpy/common/config/build_unittest.py:
4024         * Scripts/webkitpy/common/prettypatch.py:
4025         * Scripts/webkitpy/layout_tests/port/base.py:
4026         * Scripts/webkitpy/style/main.py:
4027
4028 2010-12-20  Adrienne Walker  <enne@google.com>
4029
4030         Unreviewed. Adding myself to the list of committers.
4031
4032         * webkitpy/common/config/committers.py:
4033
4034 2010-12-20  Mark Rowe  <mrowe@apple.com>
4035
4036         Reviewed by Dan Bernstein.
4037
4038         <rdar://problem/8757601> Don't install header files in to the Resources directory.
4039
4040         * Scripts/check-for-inappropriate-files-in-framework: Don't allow .h files in the
4041         Resources directory.
4042
4043 2010-12-20  Eric Seidel  <eric@webkit.org>
4044
4045         Reviewed by Adam Barth.
4046
4047         commit-queue should include bot id when attaching failure diffs
4048         https://bugs.webkit.org/show_bug.cgi?id=51280
4049
4050         This is a tiny change to include the bot id in the name of the attachment.
4051         Most of this diff is just changing the unit test expectations
4052         now that I hid the comment printing when the comment is None.
4053
4054         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
4055         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
4056         * Scripts/webkitpy/tool/commands/upload_unittest.py:
4057         * Scripts/webkitpy/tool/mocktool.py:
4058
4059 2010-12-20  Jeff Miller  <jeffm@apple.com>
4060
4061         Reviewed by Dan Bernstein.
4062
4063         Tools/vcbin/midl.exe needs to be rebuilt
4064         https://bugs.webkit.org/show_bug.cgi?id=51347
4065
4066         * vcbin/midl.exe: Rebuilt.
4067
4068 2010-12-20  David Levin  <levin@chromium.org>
4069
4070         Reviewed by Ariya Hidayat.
4071
4072         .gitignore and webkit-tools-completion.sh have references to WebKitTools that should be Tools.
4073         https://bugs.webkit.org/show_bug.cgi?id=51343
4074
4075         Follow up from the WebKitTools -> Tools rename.
4076
4077         * Scripts/webkit-tools-completion.sh:
4078
4079 2010-12-20  Cosmin Truta  <ctruta@chromium.org>
4080
4081         Reviewed by James Robinson.
4082
4083         new-run-webkit-tests ignores trailing EOL differences in text tests
4084         https://bugs.webkit.org/show_bug.cgi?id=36983
4085
4086         Changed the handling of new-line characters within new-run-webkit-tests
4087         to match old-run-webkit-tests.  Differences in leading and trailing empty
4088         lines in text expectation files are no longer ignored.
4089
4090         * Scripts/webkitpy/layout_tests/port/base.py:
4091         * Scripts/webkitpy/layout_tests/port/test.py:
4092         Added unit tests.  Removed old duplicate unit test entries.
4093         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
4094
4095 2010-12-20  David Levin  <levin@chromium.org>
4096
4097         Reviewed by Shinichiro Hamaji.
4098
4099         check-webkit-style should detect function declarations (and trivial functions).
4100         https://bugs.webkit.org/show_bug.cgi?id=51303
4101
4102         * Scripts/webkitpy/style/checkers/cpp.py:
4103         (_FunctionState.begin): Add is_declaration and changed the line count
4104         start to begin at -1 (which will keep the results consistent, since
4105         the starting line number passed in is one less in this change).
4106         (detect_functions): changed function detection to now catch trivial
4107         functions and declarations.
4108         (check_pass_ptr_usage): Don't check for Pass*Ptr on the first line
4109         of the function as this may look at return values (when processing
4110         a declaration).
4111         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
4112         (FunctionDetectionTest.perform_function_detection): Basic mechanics
4113         of testing the function detection.
4114         (FunctionDetectionTest.test_basic_function_detection): Test a simple
4115         function.
4116         (FunctionDetectionTest.test_function_declaration_detection): Test a
4117         declaration.
4118         (FunctionDetectionTest.test_non_functions): A test case for a case
4119         that caused the code to fail due to the { being in quotes.
4120         (PassPtrTest.test_pass_ref_ptr_return_value): Added some more test
4121         cases to help catch false alarms for return values.
4122         (PassPtrTest.test_pass_ref_ptr_member_variable): Ensure that
4123         we don't get false alarms for member variables either.
4124
4125 2010-12-20  Ryuan Choi  <ryuan.choi@samsung.com>
4126
4127         Reviewed by Antonio Gomes.
4128
4129         [CMAKE] Rename WEBKITTOOLS_DIR to TOOLS_DIR
4130         https://bugs.webkit.org/show_bug.cgi?id=51319
4131
4132         * CMakeListsEfl.txt:
4133
4134 2010-12-18  Adam Barth  <abarth@webkit.org>
4135
4136         Reviewed by Sam Weinig.
4137
4138         Move WebKitExamplePlugins to Examples
4139         https://bugs.webkit.org/show_bug.cgi?id=51291
4140
4141         * Scripts/webkitpy/common/config/build.py:
4142
4143 2010-12-17  Csaba Osztrogonác  <ossy@webkit.org>
4144
4145         Unreviewed Qt buildfix after r74301.
4146
4147         Rename WebKitTools to Tools
4148         https://bugs.webkit.org/show_bug.cgi?id=49861
4149
4150         * MiniBrowser/DerivedSources.pro:
4151         * MiniBrowser/qt/MiniBrowser.pro:
4152
4153 2010-12-17  Dan Bernstein  <mitz@apple.com>
4154
4155         Reviewed by Simon Fraser.
4156
4157         Rename WebKitTools to Tools
4158         https://bugs.webkit.org/show_bug.cgi?id=49861
4159
4160         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
4161         * CodeCoverage/README:
4162         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
4163         (WebCore::DumpRenderTree::initializeFonts):
4164         * EWSTools/start-commit-queue.sh:
4165         * EWSTools/start-queue.sh:
4166         * GNUmakefile.am:
4167         * MIDLWrapper/MIDLWrapper.cpp:
4168         (wmain):
4169         * MiniBrowser/qt/MiniBrowser.pro:
4170         * Scripts/build-api-tests:
4171         * Scripts/build-dumprendertree:
4172         * Scripts/build-webkit:
4173         * Scripts/build-webkittestrunner:
4174         * Scripts/generate-coverage-data:
4175         * Scripts/old-run-webkit-tests:
4176         * Scripts/run-api-tests:
4177         * Scripts/run-iexploder-tests:
4178         * Scripts/run-javascriptcore-tests:
4179         * Scripts/run-mangleme-tests:
4180         * Scripts/run-sunspider:
4181         * Scripts/run-webkit-websocketserver:
4182         * Scripts/sunspider-compare-results:
4183         * Scripts/test-webkitperl:
4184         * Scripts/test-webkitpy:
4185         * Scripts/update-iexploder-cssproperties:
4186         * Scripts/update-webkit:
4187         * Scripts/update-webkit-localizable-strings:
4188         * Scripts/webkitdirs.pm:
4189         * Scripts/webkitpy/common/checkout/scm.py:
4190         * Scripts/webkitpy/common/checkout/scm_unittest.py:
4191         * Scripts/webkitpy/common/config/committervalidator.py:
4192         * Scripts/webkitpy/common/config/committervalidator_unittest.py:
4193         * Scripts/webkitpy/common/config/ports.py:
4194         * Scripts/webkitpy/common/config/ports_unittest.py:
4195         * Scripts/webkitpy/common/system/logutils_unittest.py:
4196         * Scripts/webkitpy/common/system/ospath_unittest.py:
4197         * Scripts/webkitpy/layout_tests/port/chromium.py:
4198         * Scripts/webkitpy/layout_tests/port/config.py:
4199         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
4200         * Scripts/webkitpy/layout_tests/port/http_server.py:
4201         * Scripts/webkitpy/layout_tests/port/test.py:
4202         * Scripts/webkitpy/style/checker.py:
4203         * Scripts/webkitpy/style/checker_unittest.py:
4204         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
4205         * Scripts/webkitpy/tool/commands/queues_unittest.py:
4206         * Scripts/webkitpy/tool/steps/steps_unittest.py:
4207         * WebKitTestRunner/DerivedSources.pro:
4208         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
4209         (WTR::activateFonts):
4210         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
4211         * wx/build/build_utils.py:
4212
4213 2010-12-16  Antonio Gomes  <agomes@rim.com>
4214
4215         Reviewed by Martin Robinson.
4216
4217         Settings::editingBehaviorType() incorrectly returns mac for the gtk build when running tests
4218         https://bugs.webkit.org/show_bug.cgi?id=51163
4219
4220         Since GTK+'s default editing behavior was changed to UNIX in r70975 (see webkitwebsettings.cpp),
4221         GTK+'s DRT should also reset to UNIX after each test execution.
4222
4223         * DumpRenderTree/gtk/DumpRenderTree.cpp:
4224         (resetDefaultsToConsistentValues):
4225
4226 2010-12-17  David Levin  <levin@chromium.org>
4227
4228         Reviewed by Eric Seidel.
4229
4230         check-webkit-style should understand WTF #include guards
4231         https://bugs.webkit.org/show_bug.cgi?id=44911
4232
4233         * Scripts/webkitpy/style/checkers/cpp.py:
4234         (get_header_guard_cpp_variable): modify to suggest the WTF style
4235         of header guard when appropriate.
4236         (check_for_header_guard): handle multiple return values from
4237         get_header_guard_cpp_variable
4238         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
4239         (CppStyleTest.test_build_header_guard): Added tests for the WTF
4240         header style.
4241
4242 2010-12-16  David Levin  <levin@chromium.org>
4243
4244         Reviewed by Eric Seidel.
4245
4246         test-webkitpy: unittest for the xml.py checker displays a decprecation warning.
4247         https://bugs.webkit.org/show_bug.cgi?id=51210
4248
4249         The error only shows up when using python 2.6 or later.
4250
4251         * Scripts/webkitpy/style/checkers/xml.py: Replace the usage of
4252         the decprecated field error,message with something equivalent.
4253
4254 2010-12-16  Mihai Parparita  <mihaip@chromium.org>
4255
4256         Reviewed by Eric Seidel.
4257
4258         Add --exit-after-n-failures/crashes to NRWT
4259         https://bugs.webkit.org/show_bug.cgi?id=51160
4260         
4261         Abort test run (in a similar way to how control-C is handled) when
4262         --exit-after-n-failures/crashes-or-timeouts are passed and we've reached
4263         that number of unexpected failures/crashes/timeouts.
4264
4265         * Scripts/webkitpy/layout_tests/port/test.py:
4266         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4267         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
4268
4269 2010-12-16  David Levin  <levin@chromium.org>
4270
4271         Reviewed by Shinichiro Hamaji.
4272
4273         check-webkit-style unit tests has some duplicate boilerplate code.
4274         https://bugs.webkit.org/show_bug.cgi?id=49519
4275
4276         * Scripts/webkitpy/style/checkers/cpp.py:
4277         (update_include_state): Replaced the "io" parameter with the global
4278         configuration _unit_test_config. This allowed not calling into
4279         functions at a low level and also not plumbing through the injection
4280         information through many levels of code.
4281         (check_for_include_what_you_use): Ditto.
4282         (process_file_data): Added the ability to set up the unit test config
4283         to allow for injection.
4284         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
4285         (ErrorCollector.__init__): Added support for having a filter for errors.
4286         (ErrorCollector.__call__): Ditto.
4287         (CppStyleTestBase.process_file_data): Added the ability to set unit_test_config.
4288         (CppStyleTestBase.perform_lint): Consolidated logic for the perform functions.
4289         (CppStyleTestBase.perform_single_line_lint): Replace specific calls to
4290         functions in the cpp.py with generic processing and a filter that
4291         indicates what errors should be kept.
4292         (CppStyleTestBase.perform_multi_line_lint): Ditto.
4293         (CppStyleTestBase.perform_language_rules_check): Ditto.
4294         (CppStyleTestBase.perform_function_lengths_check): Ditto.
4295         (CppStyleTestBase.perform_pass_ptr_check): Ditto.
4296         (CppStyleTestBase.perform_include_what_you_use): Ditto.
4297         (CppStyleTest.test_multi_line_comments): Added another
4298         error message which applies to the test case.
4299         (CppStyleTest.test_spacing_for_binary_ops): Fixed test
4300         to not have config.h, since it is processed as a header file.
4301         (CppStyleTest.test_static_or_global_stlstrings): Fixed variable name
4302         style and indentation in checked code.
4303         (OrderOfIncludesTest.test_check_preprocessor_in_include_section):
4304         Fixed line number.
4305         (NoNonVirtualDestructorsTest.test_multi_line_declaration_with_error):
4306         Ditto.
4307
4308 2010-12-15  Sheriff Bot  <webkit.review.bot@gmail.com>
4309
4310         Unreviewed, rolling out r74136.
4311         http://trac.webkit.org/changeset/74136
4312         https://bugs.webkit.org/show_bug.cgi?id=51135
4313
4314         r74136 breaks chromium canary bots because some tests are not
4315         rebaselined correctly to resolve EOL differences (Requested by
4316         jianli on #webkit).
4317
4318         * Scripts/webkitpy/layout_tests/port/base.py:
4319         * Scripts/webkitpy/layout_tests/port/test.py:
4320         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
4321
4322 2010-12-15  Adam Roben  <aroben@apple.com>
4323
4324         Teach check-webkit-style to check .vcproj and .vsprops files for XML
4325         syntax errors
4326
4327         Fixes <http://webkit.org/b/51103> check-webkit-style should check for
4328         XML syntax errors in .vcproj/.vsprops files
4329
4330         Reviewed by Dave Levin.
4331
4332         * Scripts/webkitpy/style/checker.py: Added lists of file extensions
4333         that should be treated as XML and that should be allowed to contain
4334         carriage returns. (These lists happen to be identical currently.)
4335         (FileType): Added a new XML type.
4336         (CheckerDispatcher.should_check_and_strip_carriage_returns): Added.
4337         Just does a simple file extension check.
4338         (CheckerDispatcher._file_type): Added a case for XML files.
4339         (CheckerDispatcher._create_checker): Ditto. We use XMLChecker for XML
4340         files (surprise!).
4341         (StyleProcessor.process): Ask the dispatcher whether we should pass the
4342         lines through the carriage checker.
4343
4344         * Scripts/webkitpy/style/checker_unittest.py:
4345         (CheckerDispatcherCarriageReturnTest.test_should_check_and_strip_carriage_returns):
4346         Added. Checks a few file names to see if carriage returns are allowed
4347         or not.
4348         (CheckerDispatcherDispatchTest.assert_checker_xml): Added. Similar to
4349         other assert_checker_* functions.
4350         (CheckerDispatcherDispatchTest.test_xml_paths): Added. Similar to other
4351         test_*_paths functions.
4352         (CheckerDispatcherDispatchTest.test_xml_paths): Added. Similar to other
4353         test_*_paths functions.
4354         (CheckerDispatcherDispatchTest.test_none_paths): Removed the vcproj
4355         file from this test case, as vcproj files now have a type.
4356         (StyleProcessor_CodeCoverageTest.MockDispatcher.should_check_and_strip_carriage_returns):
4357         Added. Similar to the other should_* functions.
4358         (StyleProcessor_CodeCoverageTest.test_process__carriage_returns_not_stripped):
4359         Added. Checks that carriage returns aren't checked for or stripped for
4360         allowed files.
4361
4362         * Scripts/webkitpy/style/checkers/xml.py: Added.
4363         (XMLChecker.__init__): Simple init method.
4364         (XMLChecker.check): Pass each line through the expat parser, and record
4365         a style error for any errors thrown by the parser.
4366
4367         * Scripts/webkitpy/style/checkers/xml_unittest.py: Added.
4368         (XMLCheckerTest.assert_no_error): Checks that the given XML does not
4369         produce a style error.
4370         (XMLCheckerTest.assert_error): Checks that the given XML produces an
4371         error of the given category on the given line.
4372         (XMLCheckerTest.mock_handle_style_error): Does nothing. Used for
4373         checking that the XMLChecker constructor works properly.
4374         (XMLCheckerTest.test_conflict_marker): Tests that conflict markers
4375         cause a style error (see, e.g., r73887).
4376         (XMLCheckerTest.test_extra_closing_tag): Tests that extra closing tags
4377         cause a style error (see, e.g., r73773).
4378         (XMLCheckerTest.test_init): Tests that the XMLChecker constructor works
4379         properly.
4380         (XMLCheckerTest.test_missing_closing_tag): Tests that missing closing
4381         tags cause a style error (see, e.g., r72795).
4382         (XMLCheckerTest.test_no_error): Tests that valid XML does not cause a
4383         style error.
4384
4385 2010-12-15  Lucas Forschler  <lforschler@apple.com>
4386
4387         Reviewed by Stephanie Lewis.
4388
4389         https://bugs.webkit.org/show_bug.cgi?id=51117
4390         Add a new leopard test bot
4391         really really commit to trunk this time.
4392
4393         * BuildSlaveSupport/build.webkit.org-config/config.json:
4394
4395 2010-12-15  Sam Weinig  <sam@webkit.org>
4396
4397         Reviewed by Anders Carlsson.
4398
4399         WebKit2: Can't add files to an <input type=file>
4400         https://bugs.webkit.org/show_bug.cgi?id=51087
4401
4402         * MiniBrowser/mac/BrowserWindowController.m:
4403         (runOpenPanel):
4404         (-[BrowserWindowController awakeFromNib]):
4405         Add simple implementation of runOpenPanel callback.
4406
4407         * MiniBrowser/win/BrowserView.cpp:
4408         (BrowserView::create):
4409         * WebKitTestRunner/TestController.cpp:
4410         (WTR::createOtherPage):
4411         (WTR::TestController::initialize):
4412         Stub out runOpenPanel callback. 
4413
4414 2010-12-14  Eric Seidel  <eric@webkit.org>
4415
4416         Reviewed by Adam Barth.
4417
4418         commit-queue should upload failure diffs when tests flake
4419         https://bugs.webkit.org/show_bug.cgi?id=51051
4420
4421         To make this testable I needed to pipe FileSystem down onto tool.
4422         We've wanted it there for a long time anyway.
4423
4424         This patch is kinda a big hack.  But we don't have a nice
4425         way to read results.html files.  I think this will need further
4426         revision before this code actually feels clean.
4427
4428         As part of testing this change, I had to make MockBugzilla.create_bug
4429         actually return an id (like it should) which required updating
4430         a few other unit test results (for the better).
4431
4432         The results_matching_keys change in layouttestresults/rebasline
4433         was an alternate path which I decided not to use in the end, but
4434         I left the change as it seemed an improvement.
4435
4436         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
4437         * Scripts/webkitpy/common/net/layouttestresults.py:
4438         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
4439         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
4440         * Scripts/webkitpy/tool/commands/queues.py:
4441         * Scripts/webkitpy/tool/commands/rebaseline.py:
4442         * Scripts/webkitpy/tool/main.py:
4443         * Scripts/webkitpy/tool/mocktool.py:
4444
4445 2010-12-15  Cosmin Truta  <ctruta@chromium.org>
4446
4447         Reviewed by James Robinson.
4448
4449         new-run-webkit-tests ignores trailing EOL differences in text tests
4450         https://bugs.webkit.org/show_bug.cgi?id=36983
4451
4452         Changed the handling of new-line characters within new-run-webkit-tests
4453         to match old-run-webkit-tests.  Differences in leading and trailing empty
4454         lines in text expectation files are no longer ignored.
4455
4456         * Scripts/webkitpy/layout_tests/port/base.py:
4457         * Scripts/webkitpy/layout_tests/port/test.py:
4458         Added unit tests.  Removed old duplicate unit test entries.
4459         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
4460
4461 2010-12-15  Ojan Vafai  <ojan@chromium.org>
4462
4463         Reviewed by Adam Barth.
4464
4465         make status-bubble white-space:nowrap so we can measure it's width without wrapping
4466         https://bugs.webkit.org/show_bug.cgi?id=51149
4467
4468         * QueueStatusServer/templates/statusbubble.html:
4469
4470 2010-12-15  Ojan Vafai  <ojan@chromium.org>
4471
4472         Reviewed by Adam Barth.
4473
4474         have the statusbubble postMessage it's metrics so that embedders can properly size the iframe
4475         https://bugs.webkit.org/show_bug.cgi?id=51125
4476
4477         * QueueStatusServer/templates/statusbubble.html:
4478
4479 2010-12-15  Darin Adler  <darin@apple.com>
4480
4481         * Scripts/webkitpy/common/net/buildbot: Added property svn:ignore.
4482