REGRESSION (r204052): Popovers on bot watcher's dashboard are broken
[WebKit.git] / Tools / ChangeLog
1 2016-08-27  Alexey Proskuryakov  <ap@apple.com>
2
3         REGRESSION (r204052): Popovers on bot watcher's dashboard are broken
4         https://bugs.webkit.org/show_bug.cgi?id=161254
5
6         Reviewed by Darin Adler.
7
8         Simplify the CSS. My understanding that the CSS was correct, and the root cause
9         is tracked in bug 160478.
10
11         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Popover.css:
12
13 2016-08-27  Simon Fraser  <simon.fraser@apple.com>
14
15         Add run-webkit-tests --print-expectations to show expectations for all or a subset of tests
16         https://bugs.webkit.org/show_bug.cgi?id=161217
17
18         Reviewed by Ryosuke Niwa.
19
20         "run-webkit-tests --print-expectations" runs the same logic as running the tests, but
21         dumps out the lists of tests that would be run and skipped, and, for each, the entry
22         in TestExpectations that determines the expected outcome of the test.
23
24         This is an improved version of webkit-patch print-expectations.
25
26         See bug for sample output.
27
28         * Scripts/webkitpy/layout_tests/controllers/manager.py:
29         (Manager._print_expectations_for_subset): Print out the list of tests and expected
30         outcome for some subset of tests.
31         (Manager.print_expectations): Do the same splitting by device class that running tests
32         does, and for each subset of tests, call _print_expectations_for_subset.
33         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
34         (TestExpectationParser.expectation_for_skipped_test): Set the flag
35         expectation_line.not_applicable_to_current_platform
36         (TestExpectationLine.__init__): Init not_applicable_to_current_platform to False
37         (TestExpectationLine.expected_behavior): line.expectation is ['PASS'] by default,
38         even for skipped tests. This function returns a list relevant for display, taking the skipped
39         modifier into account.
40         (TestExpectationLine.create_passing_expectation): expectations is normally a list, not a set.
41         (TestExpectations.readable_filename_and_line_number): Return something printable for 
42         lines with and without filenames
43         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
44         (main): Handle options.print_expectations
45         (parse_args): Add support for --print-expectations
46         (_print_expectations):
47         * Scripts/webkitpy/port/ios.py:
48         (IOSSimulatorPort.default_child_processes): Make this a debug log.
49
50 2016-08-26  Dan Bernstein  <mitz@apple.com>
51
52         Keep trying to fix the build after r205057.
53
54         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
55
56 2016-08-26  Dan Bernstein  <mitz@apple.com>
57
58         Keep trying to fix the build after r205057.
59
60         * MobileMiniBrowser/MobileMiniBrowser/AppDelegate.m: Don’t try to import nonexistent
61           config.h. This file is only meant to be built with Xcode anyway.
62         * MobileMiniBrowser/MobileMiniBrowser/Base.lproj/LaunchScreen.storyboard: Make this compile
63           with Xcode 7.3 and deploy to iOS 9.0.
64         * MobileMiniBrowser/MobileMiniBrowser/Base.lproj/Main.storyboard: Ditto.
65         * MobileMiniBrowser/MobileMiniBrowser/TabViewController.m: Don’t try to import config.h.
66         * MobileMiniBrowser/MobileMiniBrowser/WebViewController.m: Ditto.
67
68 2016-08-26  Dan Bernstein  <mitz@apple.com>
69
70         Start trying to fix the build after r205057.
71
72         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
73
74 2016-08-26  Alexey Proskuryakov  <ap@apple.com>
75
76         Remove Yosemite Leaks from the flakiness dashboard
77         https://bugs.webkit.org/show_bug.cgi?id=161253
78
79         Reviewed by Anders Carlsson.
80
81         * TestResultServer/static-dashboards/builders.jsonp:
82
83 2016-08-26  Sam Weinig  <sam@webkit.org>
84
85         Remove support for ENABLE_LEGACY_WEB_AUDIO
86         https://bugs.webkit.org/show_bug.cgi?id=161262
87
88         Reviewed by Anders Carlsson.
89
90         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
91
92 2016-08-26  Jer Noble  <jer.noble@apple.com>
93
94         Add a test harness for running UI tests on the iOS Simulator
95         https://bugs.webkit.org/show_bug.cgi?id=161265
96
97         Reviewed by Simon Fraser.
98
99         Add a new iOS Simulator application which uses WKWebView to implement a basic browser, and which
100         can serve as a test harness for WebKit UI tests.
101
102         Also add a basic media playback test which verifies that a <video> element will begin playing in
103         fullscreen on an iPhone device, but will play inline on an iPad device.
104
105         * Makefile: Add MobileMiniBrowser as a Module for iOS builds.
106         * MobileMiniBrowser/Configurations/Base.xcconfig: Added.
107         * MobileMiniBrowser/Configurations/DebugRelease.xcconfig: Added.
108         * MobileMiniBrowser/Configurations/MobileMiniBrowser.xcconfig: Added.
109         * MobileMiniBrowser/Makefile: Added.
110         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj: Added.
111         * MobileMiniBrowser/MobileMiniBrowser/AppDelegate.h: Added.
112         * MobileMiniBrowser/MobileMiniBrowser/AppDelegate.m: Added.
113         (-[AppDelegate application:didFinishLaunchingWithOptions:]):
114         (-[AppDelegate applicationWillResignActive:]):
115         (-[AppDelegate applicationDidEnterBackground:]):
116         (-[AppDelegate applicationWillEnterForeground:]):
117         (-[AppDelegate applicationDidBecomeActive:]):
118         (-[AppDelegate applicationWillTerminate:]):
119         * MobileMiniBrowser/MobileMiniBrowser/Assets.xcassets/AppIcon.appiconset/Contents.json: Added.
120         * MobileMiniBrowser/MobileMiniBrowser/Base.lproj/LaunchScreen.storyboard: Added.
121         * MobileMiniBrowser/MobileMiniBrowser/Base.lproj/Main.storyboard: Added.
122         * MobileMiniBrowser/MobileMiniBrowser/Info.plist: Added.
123         * MobileMiniBrowser/MobileMiniBrowser/TabViewController.h: Added.
124         * MobileMiniBrowser/MobileMiniBrowser/TabViewController.m: Added.
125         (-[TabViewController dealloc]):
126         (-[TabViewController viewDidLoad]):
127         (-[TabViewController observeValueForKeyPath:ofObject:change:context:]):
128         (-[TabViewController tableView:cellForRowAtIndexPath:]):
129         (-[TabViewController tableView:numberOfRowsInSection:]):
130         (-[TabViewController numberOfSectionsInTableView:]):
131         (-[TabViewController tableView:canEditRowAtIndexPath:]):
132         (-[TabViewController tableView:canMoveRowAtIndexPath:]):
133         (-[TabViewController tableView:commitEditingStyle:forRowAtIndexPath:]):
134         (-[TabViewController tableView:didSelectRowAtIndexPath:]):
135         * MobileMiniBrowser/MobileMiniBrowser/WebViewController.h: Added.
136         * MobileMiniBrowser/MobileMiniBrowser/WebViewController.m: Added.
137         (-[WebViewController viewDidLoad]):
138         (-[WebViewController didReceiveMemoryWarning]):
139         (-[WebViewController reload:]):
140         (-[WebViewController goBack:]):
141         (-[WebViewController goForward:]):
142         (-[WebViewController urlFieldEditingBegan:]):
143         (-[WebViewController navigateTo:]):
144         (-[WebViewController showTabs:]):
145         (-[WebViewController selectWebViewAtIndex:]):
146         (-[WebViewController removeWebViewAtIndex:]):
147         (-[WebViewController addWebView]):
148         (-[WebViewController createWebView]):
149         (-[WebViewController removeWebView:]):
150         (-[WebViewController setCurrentWebView:]):
151         (-[WebViewController webView:didFailNavigation:withError:]):
152         (-[WebViewController observeValueForKeyPath:ofObject:change:context:]):
153         * MobileMiniBrowser/MobileMiniBrowser/main.m: Added.
154         (main):
155         * MobileMiniBrowser/MobileMiniBrowserUITests/Info.plist: Added.
156         * MobileMiniBrowser/MobileMiniBrowserUITests/MobileMiniBrowserUITests.m: Added.
157         (-[MobileMiniBrowserUITests setUp]):
158         (-[MobileMiniBrowserUITests tearDown]):
159         (-[MobileMiniBrowserUITests testBasicVideoPlayback]):
160
161 2016-08-26  Aakash Jain  <aakash_jain@apple.com>
162
163         webkit-queues queue-status page should should list more recent statuses
164         https://bugs.webkit.org/show_bug.cgi?id=161220
165
166         Reviewed by Daniel Bates.
167
168         * QueueStatusServer/handlers/queuestatus.py:
169         (QueueStatus._fetch_statuses): Increase the number of recent statuses from 15 to 50.
170
171 2016-08-26  Dan Bernstein  <mitz@apple.com>
172
173         [Cocoa] Infinite recursion calling -charValue on a WKNSNumber
174         https://bugs.webkit.org/show_bug.cgi?id=161258
175
176         Reviewed by Anders Carlsson.
177
178         * TestWebKitAPI/Tests/WebKit2Cocoa/WKNSNumber.mm:
179         (TestWebKitAPI::TEST):
180
181 2016-08-26  Csaba Osztrogonác  <ossy@webkit.org>
182
183         Fix the ENABLE(WEBASSEMBLY) build on Linux
184         https://bugs.webkit.org/show_bug.cgi?id=161197
185
186         Reviewed by Mark Lam.
187
188         * Scripts/build-jsc:
189
190 2016-08-26  Carlos Alberto Lopez Perez  <clopez@igalia.com>
191
192         [GTK] run-gtk-tests should use the driver environment for checking the accessibility bus
193         https://bugs.webkit.org/show_bug.cgi?id=161149
194
195         Reviewed by Carlos Garcia Campos.
196
197         Add a new function for waiting for the accesibility bus. It sets
198         the test environment variables before starting the GLib mainloop.
199         And restores the previous environment after it has finished.
200         It also adds a timeout (5 seconds) to abort in case it has not
201         been able to detect the accesibility bus before the timeout expires.
202
203         * Scripts/run-gtk-tests:
204         (TestRunner):
205         (TestRunner._wait_for_accessibility_bus):
206         (TestRunner._wait_for_accessibility_bus.timeout_accessibility_bus):
207         (TestRunner._start_accessibility_daemons):
208         (TestRunner._get_tests_from_google_test_suite): Run this command also with the driver test environment.
209
210 2016-08-26  Per Arne Vollan  <pvollan@apple.com>
211
212         [Win] Warning fix.
213         https://bugs.webkit.org/show_bug.cgi?id=161236
214
215         Reviewed by Brent Fulgham.
216
217         The & operator in the Test struct has no body.
218
219         * TestWebKitAPI/Tests/WTF/Vector.cpp:
220         (TestWebKitAPI::TEST):
221
222 2016-08-26  Carlos Alberto Lopez Perez  <clopez@igalia.com>
223
224         [GTK] run-gtk-tests should use webkitpy.port.gtk and webkitpy.port.xvfbdriver
225         https://bugs.webkit.org/show_bug.cgi?id=160736
226
227         Reviewed by Carlos Garcia Campos.
228
229         This plugs run-gtk-tests into the webkitpy testing infrastructure.
230         As a benefit of this, run-gtk-tests now can be executed over any of
231         the existing supported gtk test display servers (xvfb, weston-over-xvfb,
232         or native xorg). A new command line switch --wayland is added for
233         run-gtk-tests.
234
235         * Scripts/run-gtk-tests:
236         (TestRunner.__init__): Remove the --display command line switch, its not longer useful.
237         Add a --wayland command line switch.
238         (TestRunner._start_accessibility_daemons):
239         (TestRunner):
240         (TestRunner.__init__):
241         (TestRunner._run_xvfb): Deleted.
242         (TestRunner._create_driver):
243         (TestRunner._setup_testing_environment): Delete the environment variable definitions that
244         are now done by driver._setup_environ_for_test().
245         (TestRunner._tear_down_testing_environment):
246         * Scripts/webkitpy/port/driver.py:
247         (Driver.__init__): Define self._server_name in the constructor of the base class.
248         It is used by several functions, so it makes sense to store once the value here.
249         (Driver._setup_environ_for_test): Factorize setting the environment for a given test.
250         (Driver._start): Get the environment from self._setup_environ_for_test()
251         * Scripts/webkitpy/port/driver_unittest.py:
252         (DriverTest):
253         (DriverTest.test_setup_environ_for_test): Add unittest for driver._setup_environ_for_test()
254         * Scripts/webkitpy/port/gtk.py: Move the inspection of the env var USE_NATIVE_XDISPLAY to the constructor.
255         (GtkPort.__init__):
256         (GtkPort._driver_class):
257         * Scripts/webkitpy/port/westondriver.py: Define and use self._setup_environ_for_test()
258         (WestonDriver._setup_environ_for_test):
259         (WestonDriver._start):
260         * Scripts/webkitpy/port/xorgdriver.py: Define and use self._setup_environ_for_test()
261         (XorgDriver._setup_environ_for_test):
262         (XorgDriver._start):
263         * Scripts/webkitpy/port/xvfbdriver.py: Define and use self._setup_environ_for_test()
264         (XvfbDriver._setup_environ_for_test):
265         (XvfbDriver._start):
266
267 2016-08-26  Csaba Osztrogonác  <ossy@webkit.org>
268
269         [EFL][GTK] REGRESSION(204877): Fix the clean build
270         https://bugs.webkit.org/show_bug.cgi?id=161240
271
272         Reviewed by Carlos Garcia Campos.
273
274         * WebKitTestRunner/PlatformEfl.cmake:
275         * WebKitTestRunner/PlatformGTK.cmake:
276
277 2016-08-26  Aakash Jain  <aakash_jain@apple.com>
278
279         EWS should indicate which bot processed the patch
280         https://bugs.webkit.org/show_bug.cgi?id=161222
281
282         Reviewed by Daniel Bates.
283
284         * QueueStatusServer/handlers/statusbubble.py:
285         (StatusBubble._build_bubble): Display the bot id in status bubble. Also removed "Started processing" message since
286         after bug fix of 161223, bots send the "Started processing patch" message and it would be displayed in Recent messages.
287         Also added "Started processing patch" message to progress_statuses.
288         I might consider displaying bot id in other statuses as well later on.
289
290 2016-08-26  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
291
292         [EFL] Change homepage url to www.ewebkit.org on MiniBrowser
293         https://bugs.webkit.org/show_bug.cgi?id=161184
294
295         Reviewed by Carlos Garcia Campos.
296
297         * MiniBrowser/efl/main.c: Set www.ewebkit.org.
298
299 2016-08-25  Aakash Jain  <aakash_jain@apple.com>
300
301         ews queues should update status server when they start processing patch
302         https://bugs.webkit.org/show_bug.cgi?id=161223
303
304         Reviewed by Daniel Bates.
305
306         * Scripts/webkitpy/tool/commands/queues.py:
307         (AbstractReviewQueue.process_work_item): Update status server that the bot started processing the patch.
308         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
309         (EarlyWarningSystemTest._default_expected_logs): Updated the unit test accordingly.
310         * Scripts/webkitpy/tool/commands/queues_unittest.py:
311         (StyleQueueTest.test_style_queue_with_style_exception): Same.
312         (test_style_queue_with_watch_list_exception): Same.
313         (test_non_valid_patch): Same.
314
315 2016-08-25  Alex Christensen  <achristensen@webkit.org>
316
317         CMake build fix.
318
319         * DumpRenderTree/PlatformMac.cmake:
320
321 2016-08-25  Alex Christensen  <achristensen@webkit.org>
322
323         Fix URLParserTest with GuardMalloc
324         https://bugs.webkit.org/show_bug.cgi?id=161214
325         rdar://problem/28014390
326
327         Reviewed by Tim Horton.
328
329         The CString returned by String::utf8 was going out of scope before we were doing a string comparison on its data.
330         This just does the comparison of the CStrings instead to keep them in scope during the comparison.
331
332         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
333         (TestWebKitAPI::eq):
334         (TestWebKitAPI::checkURL):
335         (TestWebKitAPI::checkURLDifferences):
336         (TestWebKitAPI::s): Deleted.
337
338 2016-08-25  Wenson Hsieh  <wenson_hsieh@apple.com>
339
340         Dragging against the end of the inline media scrubber causes the media scrubber to hide
341         https://bugs.webkit.org/show_bug.cgi?id=161207
342
343         Reviewed by Eric Carlson.
344
345         Tweaks an existing WebKit API test covering this behavior change. After some discussion, rather than hide media
346         controls in this case, we should actually continue showing them. This is because seeking due to user gestures
347         similar to "scrubbing" are indistinguishable from gestures that immediately seek to the end.
348
349         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
350         (TestWebKitAPI::TEST):
351
352 2016-08-25  Daniel Bates  <dabates@apple.com>
353
354         Watch more things.
355
356         * Scripts/webkitpy/common/config/watchlist:
357
358 2016-08-25  Daniel Bates  <dabates@apple.com>
359
360         Fix test failure on GTK Linux bots after <http://trac.webkit.org/changeset/204695>
361         (https://bugs.webkit.org/show_bug.cgi?id=148437)
362
363         Remove use of module File::Slurp as it is not part of the standard Perl 5 distribution
364         and is not installed on the GTK Linux bots.
365
366         * Scripts/webkitperl/prepare-ChangeLog_unittest/generateFunctionLists.pl:
367         (writeFileWithContent): Added.
368
369 2016-08-25  Per Arne Vollan  <pvollan@apple.com>
370
371         [Win] run-api-tests is failing.
372         https://bugs.webkit.org/show_bug.cgi?id=161140
373
374         Reviewed by Brent Fulgham.
375
376         Since the move constructor is called 3 more times on Windows, we will have 3 more destructor calls.
377
378         * TestWebKitAPI/Tests/WTF/CrossThreadTask.cpp:
379         (TestWebKitAPI::TEST):
380
381 2016-08-24  Per Arne Vollan  <pvollan@apple.com>
382
383         [Win] run-api-tests is failing.
384         https://bugs.webkit.org/show_bug.cgi?id=161140
385
386         Reviewed by Brent Fulgham.
387
388         The number of times the move constructor is called is different on Windows in this test. This seems
389         to be caused by differences in MSVC's implementation of lambdas or std functions like std::make_tuple.
390
391         * TestWebKitAPI/Tests/WTF/CrossThreadTask.cpp:
392         (TestWebKitAPI::TEST):
393
394 2016-08-24  Simon Fraser  <simon.fraser@apple.com>
395
396         Fix iOS DRT build.
397
398         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
399         (WTR::UIScriptController::zoomToScale):
400
401 2016-08-24  Simon Fraser  <simon.fraser@apple.com>
402
403         [iOS DRT] Hook up uiController.zoomToScale() for DRT
404         https://bugs.webkit.org/show_bug.cgi?id=161173
405
406         Reviewed by Tim Horton.
407         
408         Make a UIWebScrollView subclass, DumpRenderTreeWebScrollView, which has an internal delegate to get
409         UIScrollView delegate callbacks. Store the zoomToScaleCompletionHandler on it.
410         
411         UIScriptController::zoomToScale() has to bounce the zoom to the main thread (no poking UIKit from
412         the WebThread!), but queue up the callback first.
413
414         * DumpRenderTree/ios/DumpRenderTreeBrowserView.h:
415         * DumpRenderTree/ios/DumpRenderTreeBrowserView.mm:
416         (-[DumpRenderTreeWebScrollView initWithFrame:]):
417         (-[DumpRenderTreeWebScrollView dealloc]):
418         (-[DumpRenderTreeWebScrollView zoomToScale:animated:completionHandler:]):
419         (-[DumpRenderTreeWebScrollView completedZoomToScale]):
420         (-[DumpRenderTreeWebScrollViewDelegate initWithScrollView:]):
421         (-[DumpRenderTreeWebScrollViewDelegate viewForZoomingInScrollView:]): All UIScrollView delegates need to implement this.
422         (-[DumpRenderTreeWebScrollViewDelegate scrollViewDidEndZooming:withView:atScale:]):
423         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
424         (WTR::UIScriptController::zoomToScale):
425         * DumpRenderTree/mac/DumpRenderTree.mm:
426         (createWebViewAndOffscreenWindow):
427         * TestRunnerShared/UIScriptContext/UIScriptController.h:
428         (WTR::UIScriptController::context):
429
430 2016-08-24  Ryan Haddad  <ryanhaddad@apple.com>
431
432         Attempt to fix Windows build after r204918.
433
434         Unreviewed build fix.
435
436         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
437         (ResourceLoadDelegate::willSendRequest):
438
439 2016-08-24  Simon Fraser  <simon.fraser@apple.com>
440
441         [iOS DRT] Get basic viewport tests working in DRT
442         https://bugs.webkit.org/show_bug.cgi?id=161160
443
444         Reviewed by Tim Horton.
445         
446         Hook up enough of UIScriptController in iOS DRT to be able to read viewport
447         scale, and get the contentVisibleRect.
448         
449         Requires exposing a bit of UIWebBrowserView SPI from UIKit, which in turn
450         requires typing the gWebBrowserView as a DumpRenderTreeBrowserView * everywhere.
451         
452         One test has different results between DRT and WTR, but DRT behavior seems to differ
453         from UIWebView here, so just give it a WK1-specific result.
454
455         * DumpRenderTree/ios/DumpRenderTreeBrowserView.h:
456         * DumpRenderTree/ios/DumpRenderTreeBrowserView.mm:
457         (-[DumpRenderTreeBrowserView documentVisibleRect]):
458         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
459         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
460         (WTR::UIScriptController::zoomScale):
461         (WTR::UIScriptController::minimumZoomScale):
462         (WTR::UIScriptController::maximumZoomScale):
463         (WTR::UIScriptController::contentVisibleRect):
464         * DumpRenderTree/mac/DumpRenderTree.mm:
465         (createWebViewAndOffscreenWindow):
466         * DumpRenderTree/mac/DumpRenderTreeMac.h:
467
468 2016-08-24  Simon Fraser  <simon.fraser@apple.com>
469
470         Minor project rearrangement.
471
472         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
473
474 2016-08-24  Simon Fraser  <simon.fraser@apple.com>
475
476         [iOS DRT] Make iOS DRT use the same window size as WebKitTestRunner for flexible viewport tests
477         https://bugs.webkit.org/show_bug.cgi?id=161124
478
479         Reviewed by Daniel Bates.
480         
481         Use the main UIScreen's bounds for the size of the window in flexible viewport mode,
482         and remove the 'phoneBrowserAddressBarOffset' hack, so that it matches WTR.
483         
484         Remove some unnecessary zero initializations of static variables.
485         
486         Change _setVisibleSize to use the window size, which should not be a behavior change
487         because this it just used for text autosizing, which is disabled by default,
488         and only the width is consulted.
489
490         * DumpRenderTree/mac/DumpRenderTree.mm:
491         (adjustWebDocumentForFlexibleViewport):
492         (adjustWebDocumentForStandardViewport):
493         (createWebViewAndOffscreenWindow):
494
495 2016-08-24  Jonathan Bedard  <jbedard@apple.com>
496
497         WebKit2 needs layoutTestController.setDeferMainResourceDataLoad
498         https://bugs.webkit.org/show_bug.cgi?id=42777
499
500         Reviewed by Darin Adler.
501
502         The setDeferMainResourceDataLoad method was not correctly tested in DumpRenderTree and would pass even when setDeterMainResourceDataLoad was not called.  Removed function and test.
503
504         * DumpRenderTree/TestRunner.cpp:
505         (setDeferMainResourceDataLoadCallback): Removed setDeferMainResourceDataLoad.
506         * DumpRenderTree/TestRunner.h:
507         (TestRunner::deferMainResourceDataLoad): Ditto.
508         (TestRunner::setDeferMainResourceDataLoad): Ditto.
509         * DumpRenderTree/mac/ResourceLoadDelegate.mm: Ditto.
510
511 2016-08-23  Anders Carlsson  <andersca@apple.com>
512
513         Add enum traits and use them in the IPC::Decoder
514         https://bugs.webkit.org/show_bug.cgi?id=161103
515
516         Reviewed by Sam Weinig.
517
518         Add API test.
519
520         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
521         * TestWebKitAPI/Tests/WTF/EnumTraits.cpp: Added.
522         (TestWebKitAPI::TEST):
523
524 2016-08-24  Filip Pizlo  <fpizlo@apple.com>
525
526         Unreviewed, roll out r204901, r204897, r204866, r204856, r204854.
527
528         * DumpRenderTree/TestRunner.cpp:
529         * DumpRenderTree/mac/DumpRenderTree.mm:
530         (DumpRenderTreeMain):
531         * Scripts/run-jsc-stress-tests:
532         * TestWebKitAPI/Tests/WTF/Vector.cpp:
533         (TestWebKitAPI::TEST):
534
535 2016-08-24  Simon Fraser  <simon.fraser@apple.com>
536
537         Try to fix Production builds.
538         
539         PRODUCTION_FRAMEWORKS_DIR was undefined here.
540
541         * DumpRenderTree/mac/Configurations/Base.xcconfig:
542
543 2016-08-24  Dan Bernstein  <mitz@apple.com>
544
545         Add a convenience function for creating a WKFrameHandleRef from a WKFrameRef without going through WKFrameInfoRef
546         https://bugs.webkit.org/show_bug.cgi?id=161152
547
548         Reviewed by Anders Carlsson.
549
550         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
551         * TestWebKitAPI/Tests/WebKit2/FrameHandle.cpp: Added.
552         (TestWebKitAPI::didFinishLoadForFrame):
553         (TestWebKitAPI::TEST):
554
555 2016-08-24  Nan Wang  <n_wang@apple.com>
556
557         AX: Add test for line text marker range on iOS
558         https://bugs.webkit.org/show_bug.cgi?id=161108
559         <rdar://problem/27976405>
560
561         Reviewed by Chris Fleizach.
562
563         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
564         (AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
565         (AccessibilityUIElement::textMarkerRangeForElement):
566         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
567         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
568         (WTR::AccessibilityUIElement::textMarkerRangeForElement):
569
570 2016-08-24  Per Arne Vollan  <pvollan@apple.com>
571
572         [Win] Warning fixes.
573         https://bugs.webkit.org/show_bug.cgi?id=161079
574
575         Reviewed by Brent Fulgham.
576
577         * MiniBrowser/win/WebDownloadDelegate.cpp:
578         * MiniBrowser/win/WinMain.cpp:
579         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
580         (TestWebKitAPI::TEST):
581
582 2016-08-23  Simon Fraser  <simon.fraser@apple.com>
583
584         Fix Windows DRT build.
585
586         * DumpRenderTree/win/TestRunnerWin.cpp:
587         (TestRunner::mainFrameJSContext):
588
589 2016-08-23  Simon Fraser  <simon.fraser@apple.com>
590
591         Try to fix Windows build.
592         
593         Pass Tools/DumpRenderTree/Bindings as the working directory for the generate_bindings.pl
594         so that perl finds CodeGeneratorDumpRenderTree.pm.
595
596         * DumpRenderTree/CMakeLists.txt:
597
598 2016-08-23  Simon Fraser  <simon.fraser@apple.com>
599
600         Hook up UIScriptController in DumpRenderTree
601         https://bugs.webkit.org/show_bug.cgi?id=161064
602
603         Reviewed by Sam Weinig.
604
605         Add a skeleton implementation of UIScriptController to DumpRenderTree, building for both
606         Mac and iOS. Currently this is sufficient to test doAsyncTask(), enabling two tests
607         in fast/harness which test this.
608
609         Add a DerivedSources target to DumpRenderTree to invoke DerivedSources.make.
610
611         Move related code shared between WTR and DRT into Tools/TestRunnerShared, and cleanse it of
612         WK2-isms. Fix the makefiles to refer to the new location.
613
614         Hook up TestRunner::runUIScript() for DumpRenderTree, which requires keeping track of callbacks
615         by ID and firing them once they are complete.
616
617         * DumpRenderTree/Bindings/CodeGeneratorDumpRenderTree.pm: Added (copied from WTR).
618         * DumpRenderTree/CMakeLists.txt:
619         * DumpRenderTree/DerivedSources.make: Copied from Tools/WebKitTestRunner/DerivedSources.make.
620         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
621         * DumpRenderTree/TestRunner.cpp:
622         (runUIScriptCallback):
623         (TestRunner::staticFunctions):
624         (TestRunner::cacheTestRunnerCallback):
625         (TestRunner::callTestRunnerCallback):
626         (TestRunner::clearTestRunnerCallbacks):
627         (nextUIScriptCallbackID):
628         (TestRunner::runUIScript):
629         (TestRunner::callUIScriptCallback):
630         (TestRunner::uiScriptDidComplete):
631         (TestRunner::cleanup):
632         * DumpRenderTree/TestRunner.h:
633         * DumpRenderTree/ios/UIScriptControllerIOS.mm: Added.
634         * DumpRenderTree/mac/Configurations/Base.xcconfig: DerivedSources.make needs WEBCORE_PRIVATE_HEADERS_DIR to be defined.
635         * DumpRenderTree/mac/DumpRenderTree.mm:
636         (runTest):
637         * DumpRenderTree/mac/TestRunnerMac.mm:
638         (TestRunner::mainFrameJSContext):
639         * DumpRenderTree/mac/UIScriptControllerMac.mm: Copied from Tools/WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h.
640         (WTR::UIScriptController::doAsyncTask):
641         * DumpRenderTree/win/DumpRenderTree.cpp:
642         * TestRunnerShared/Bindings/JSWrappable.h: Renamed from Tools/WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h.
643         (WTR::JSWrappable::~JSWrappable):
644         (WTR::JSValueMakeStringOrNull):
645         * TestRunnerShared/Bindings/JSWrapper.cpp: Renamed from Tools/WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.cpp.
646         (WTR::JSWrapper::wrap):
647         (WTR::JSWrapper::unwrap):
648         (WTR::unwrapObject):
649         (WTR::JSWrapper::initialize):
650         (WTR::JSWrapper::finalize):
651         * TestRunnerShared/Bindings/JSWrapper.h: Renamed from Tools/WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.h.
652         (WTR::toJS):
653         (WTR::setProperty):
654         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl: Renamed from Tools/WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl.
655         * TestRunnerShared/UIScriptContext/UIScriptContext.cpp: Renamed from Tools/WebKitTestRunner/UIScriptContext/UIScriptContext.cpp.
656         * TestRunnerShared/UIScriptContext/UIScriptContext.h: Renamed from Tools/WebKitTestRunner/UIScriptContext/UIScriptContext.h.
657         (WTR::UIScriptContext::currentParentCallbackIsPendingCompletion):
658         * TestRunnerShared/UIScriptContext/UIScriptController.cpp: Renamed from Tools/WebKitTestRunner/UIScriptContext/UIScriptController.cpp.
659         * TestRunnerShared/UIScriptContext/UIScriptController.h: Renamed from Tools/WebKitTestRunner/UIScriptContext/UIScriptController.h.
660         * WebKitTestRunner/CMakeLists.txt:
661         * WebKitTestRunner/DerivedSources.make:
662         * WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h:
663         (WTR::JSWrappable::~JSWrappable): Deleted.
664         (WTR::JSValueMakeStringOrNull): Deleted.
665         * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.cpp:
666         (WTR::JSWrapper::wrap): Deleted.
667         (WTR::JSWrapper::unwrap): Deleted.
668         (WTR::unwrapObject): Deleted.
669         (WTR::JSWrapper::initialize): Deleted.
670         (WTR::JSWrapper::finalize): Deleted.
671         * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.h:
672         (WTR::toJS): Deleted.
673         (WTR::setProperty): Deleted.
674         * WebKitTestRunner/TestInvocation.cpp:
675         (WTR::TestInvocation::runUISideScript):
676         (WTR::TestInvocation::uiScriptDidComplete):
677         * WebKitTestRunner/TestInvocation.h:
678         * WebKitTestRunner/UIScriptContext/UIScriptContext.cpp: Moved
679         * WebKitTestRunner/UIScriptContext/UIScriptContext.h: Moved
680         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp: Moved
681         * WebKitTestRunner/UIScriptContext/UIScriptController.h: Moved
682         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
683         * WebKitTestRunner/config.h:
684         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
685         (WTR::UIScriptController::contentVisibleRect):
686
687 2016-08-23  Saam Barati  <sbarati@apple.com>
688
689         JSC should have a "microbenchmarks" directory instead of "regress" directory
690         https://bugs.webkit.org/show_bug.cgi?id=161096
691
692         Rubber stamped by Mark Lam.
693
694         This patch moves LayoutTests/js/regress/script-tests to the JSTests/microbenchmarks
695         directory and removes all the related html and txt files. I did this because
696         that directory was only there for microbenchmarks, and not for "regression"
697         tests. I also changed the various scripts to point to it.
698
699         * Scripts/run-javascriptcore-tests:
700         (runJSCStressTests):
701         * Scripts/run-jsc-benchmarks:
702
703 2016-08-23  Alex Christensen  <achristensen@webkit.org>
704
705         Fix EFL build.
706
707         * TestWebKitAPI/CMakeLists.txt:
708         Include new directory.
709
710 2016-08-22  Filip Pizlo  <fpizlo@apple.com>
711
712         Butterflies should be allocated in Auxiliary MarkedSpace instead of CopiedSpace and we should rewrite as much of the GC as needed to make this not a regression
713         https://bugs.webkit.org/show_bug.cgi?id=160125
714
715         Reviewed by Geoffrey Garen.
716
717         * DumpRenderTree/TestRunner.cpp: Rewire some #includes.
718         * Scripts/run-jsc-stress-tests: New test flag!
719
720 2016-08-23  Brady Eidson  <beidson@apple.com>
721
722         WK2 Gamepad layout test support.
723         https://bugs.webkit.org/show_bug.cgi?id=134671
724
725         Reviewed by Alex Christensen.
726         
727         Have the injected bundle expose the MockGamepadProvider to the UI process, which will then 
728         feed back into the UIGamepadProvider.
729         
730         Also, fool NSApplication into treating the most recently created "isKeyWindow" of the test windows
731         as the actual keyWindow for the test runner, which will allow the view to get gamepad updates.
732
733         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
734         
735         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
736         (WTR::TestRunner::setMockGamepadDetails):
737         (WTR::TestRunner::setMockGamepadAxisValue):
738         (WTR::TestRunner::setMockGamepadButtonValue):
739         
740         * WebKitTestRunner/PlatformWebView.h:
741         
742         * WebKitTestRunner/TestController.cpp:
743         (WTR::TestController::initialize):
744         
745         * WebKitTestRunner/TestInvocation.cpp:
746         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
747         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Deleted.
748         
749         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
750         
751         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
752         (-[WebKitTestRunnerWindow initWithFrame:]):
753         (-[WebKitTestRunnerWindow dealloc]):
754         (WTR::PlatformWebView::keyWindow):
755         
756         * WebKitTestRunner/ios/TestControllerIOS.mm:
757         (WTR::wtr_NSApplication_keyWindow):
758         (WTR::TestController::platformInitialize):
759         
760         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
761         (+[WebKitTestRunnerWindow _WTR_keyWindow]):
762         (-[WebKitTestRunnerWindow initWithContentRect:styleMask:backing:defer:]):
763         (-[WebKitTestRunnerWindow dealloc]):
764         (WTR::PlatformWebView::keyWindow):
765         
766         * WebKitTestRunner/mac/TestControllerMac.mm:
767         (WTR::wtr_NSApplication_keyWindow):
768         (WTR::TestController::platformInitialize):
769         * WebKitTestRunner/mac/main.mm:
770
771 2016-08-23  Alexey Proskuryakov  <ap@apple.com>
772
773         REGRESSION (PHP 5.6): http/tests/misc/bad-charset-alias.html fails
774         https://bugs.webkit.org/show_bug.cgi?id=161047
775         rdar://problem/27434307
776
777         Reviewed by Lucas Forschler.
778
779         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py: Specify a php.ini file.
780
781 2016-08-23  Chris Dumez  <cdumez@apple.com>
782
783         Unreviewed, rolling out r204243.
784
785         Caused some layout test failures
786
787         Reverted changeset:
788
789         "Write API test to cover crash fix in r204135"
790         https://bugs.webkit.org/show_bug.cgi?id=160587
791         http://trac.webkit.org/changeset/204243
792
793 2016-08-23  Rawinder Singh  <rawinder.singh-webkit@cisra.canon.com.au>
794
795         Order feature option list in FeatureList.pm
796         https://bugs.webkit.org/show_bug.cgi?id=161074
797
798         Reviewed by Michael Catanzaro.
799
800         Reorder features in alphabetical order based on command line option. Also, sort variables in alphabetical order.
801
802         * Scripts/webkitperl/FeatureList.pm:
803
804 2016-08-22  Dewei Zhu  <dewei_zhu@apple.com>
805
806         Stop python icon bouncing in the dock while running browser benchmarks.
807         https://bugs.webkit.org/show_bug.cgi?id=161066
808
809         Reviewed by Ryosuke Niwa.
810
811         Bouncing python icon may impact browser benchmark results.
812         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
813         (OSXBrowserDriver.prepare_env):
814         (OSXBrowserDriver.restore_env):
815
816 2016-08-22  Simon Fraser  <simon.fraser@apple.com>
817
818         <select> menu on iPad causes shifting of hit-testing areas
819         https://bugs.webkit.org/show_bug.cgi?id=150079
820
821         Reviewed by Tim Horton.
822
823         -isAssistingNode (aka the poorly named isEditable) is input into WebPageProxy::computeCustomFixedPositionRect(),
824         so when it changes we have to update visible rects. We were doing this on focus, but failing
825         to do it on blur.
826
827         Added the ability to test by:
828         1. Making it possible to initiate an animated scroll in the UI process
829         2. Adding callbacks for starting and ending interaction with a form control. Sadly
830         the "ending interaction" for <select> popovers on iPad isn't late enough, since we
831         have no way currently to know when the dimming view behind the popover animates out,
832         so for now the test keeps trying to tap a button.
833
834         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
835         * WebKitTestRunner/UIScriptContext/UIScriptContext.h:
836         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
837         (WTR::UIScriptController::setDidStartFormControlInteractionCallback):
838         (WTR::UIScriptController::didStartFormControlInteractionCallback):
839         (WTR::UIScriptController::setDidEndFormControlInteractionCallback):
840         (WTR::UIScriptController::didEndFormControlInteractionCallback):
841         (WTR::UIScriptController::scrollToOffset):
842         (WTR::UIScriptController::platformSetDidStartFormControlInteractionCallback):
843         (WTR::UIScriptController::platformSetDidEndFormControlInteractionCallback):
844         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
845         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
846         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
847         (-[TestRunnerWKWebView dealloc]):
848         (-[TestRunnerWKWebView didStartFormControlInteraction]):
849         (-[TestRunnerWKWebView didEndFormControlInteraction]):
850         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
851         (WTR::contentOffsetBoundedInValidRange):
852         (WTR::UIScriptController::scrollToOffset):
853         (WTR::UIScriptController::platformSetDidStartFormControlInteractionCallback):
854         (WTR::UIScriptController::platformSetDidEndFormControlInteractionCallback):
855
856 2016-08-22  Carlos Alberto Lopez Perez  <clopez@igalia.com>
857
858         [EFL][GTK] Script process-linux-coredump is not needed, switch back to use the kernel core dumper instead.
859         https://bugs.webkit.org/show_bug.cgi?id=160927
860
861         Reviewed by Daniel Bates.
862
863         * Scripts/process-linux-coredump: Removed.
864         * Scripts/webkitpy/port/efl.py:
865         (EflPort._get_crash_log):
866         * Scripts/webkitpy/port/gtk.py:
867         (GtkPort._get_crash_log):
868         * Scripts/webkitpy/port/linux_get_crash_log.py:
869         (GDBCrashLogGenerator.__init__):
870         (GDBCrashLogGenerator.generate_crash_log):
871         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
872         (GDBCrashLogGeneratorTest.test_generate_crash_log):
873
874 2016-08-22  Jonathan Bedard  <jbedard@apple.com>
875
876         check-webkit-style does not work with Lambda functions in C++
877         https://bugs.webkit.org/show_bug.cgi?id=160910
878
879         Reviewed by Darin Adler.
880
881         This change eliminates false positives on correctly styled lambda functions and includes a few basic checks on capture list.
882
883         * Scripts/webkitpy/style/checkers/cpp.py:
884         (regex_for_lambda_functions): Added function which checks if a string is the start of a lambda function.
885         (check_for_non_standard_constructs): Added lambda function check.
886         (check_spacing_for_function_call): Added lambda function check.
887         (check_braces): Added lambda function check.
888         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
889         (CppStyleTest.test_lambda_functions): Added test function for lambda function style checks.
890
891 2016-08-21  Alex Christensen  <achristensen@webkit.org>
892
893         URLParser should parse IPv4 addresses
894         https://bugs.webkit.org/show_bug.cgi?id=161023
895
896         Reviewed by Darin Adler.
897
898         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
899         (TestWebKitAPI::TEST_F):
900         (TestWebKitAPI::checkURLDifferences):
901         We are already getting differences between the old URL::parse and the new URLParser.
902         (TestWebKitAPI::shouldFail):
903
904 2016-08-21  Daniel Bates  <dabates@apple.com>
905
906         prepare-ChangeLog lists unmodified functions as modified and marks functions with few changes as deleted
907         https://bugs.webkit.org/show_bug.cgi?id=148437
908
909         Reviewed by Dan Bernstein.
910
911         * Scripts/prepare-ChangeLog:
912         (diffCommand): When using a Subversion checkout, generate a unified diff without any context lines.
913         This matches our behavior when using a Git checkout. The function overlap logic in generateFunctionListsByRanges()
914         assumes that its line ranges were from a unified diff without any context lines.
915         (extractLineRangeAfterChange): A deleted line should be represented with a ("begin line number", "end line number") = ("new starting line number", "new starting line number").
916         (extractLineRangeBeforeChange): An added line should be represented with a ("begin line number", "end line number") = ("original starting line number", "original starting line number").
917         * Scripts/webkitperl/prepare-ChangeLog_unittest/extractLineRangeBeforeAndAfterChange.pl: Update expected results
918         based on changes to extractLineRangeAfterChange() and extractLineRangeBeforeChange().
919         * Scripts/webkitperl/prepare-ChangeLog_unittest/generateFunctionLists.pl: Added.
920         (discardOutput): Convenience function invokes the specified function redirecting standard output and standard error
921         to /dev/null for the duration of the function call.
922
923 2016-08-20  Gyuyoung Kim  <gyuyoung.kim@navercorp.com>
924
925         [EFL] Remove unnecessary a patch to mute ecore warnings
926         https://bugs.webkit.org/show_bug.cgi?id=160997
927
928         Reviewed by Darin Adler.
929
930         There is no warning messages during the layout test and perf test
931         after bumping efl version from 1.17 to 1.18. Remove it.
932
933         * efl/patches/ecore_remove_warnings.patch: Removed.
934
935 2016-08-20  Simon Fraser  <simon.fraser@apple.com>
936
937         REGRESSION (r204477): Running LayoutTests on ios-simulator became ~15 minutes slower
938         https://bugs.webkit.org/show_bug.cgi?id=160985
939
940         Re-land r204672, but don't check the result of 'xcrun simctl shutdown', because
941         device shutdown seems to happen as result of killing Simulator.apps, and we're racing
942         with that.
943
944         * Scripts/webkitpy/layout_tests/views/printing.py:
945         (Printer.print_config):
946         * Scripts/webkitpy/port/base.py:
947         (Port.driver_cmd_line_for_logging):
948         (Port.driver_cmd_line): Deleted.
949         * Scripts/webkitpy/port/driver.py:
950         (IOSSimulatorDriver.cmd_line):
951         * Scripts/webkitpy/port/ios.py:
952         (IOSSimulatorPort.__init__):
953         (IOSSimulatorPort.driver_cmd_line_for_logging):
954         (IOSSimulatorPort._create_simulators):
955         (IOSSimulatorPort.setup_test_run):
956         (IOSSimulatorPort._quit_ios_simulator):
957         (IOSSimulatorPort.clean_up_test_run):
958         (IOSSimulatorPort._create_device):
959         (IOSSimulatorPort):
960         (IOSSimulatorPort._remove_device):
961         (IOSSimulatorPort._testing_device):
962         (IOSSimulatorPort.device_id_for_worker_number):
963         (IOSSimulatorPort._set_device_class): Deleted.
964         (IOSSimulatorPort.testing_device): Deleted.
965         * Scripts/webkitpy/port/port_testcase.py:
966         (PortTestCase.test_driver_cmd_line):
967         * Scripts/webkitpy/xcode/simulator.py:
968         (Device.shutdown):
969         (Device):
970         (Device.delete):
971         (Device.reset):
972         (Simulator):
973         (Simulator.create_device):
974         (Simulator.remove_device):
975         (Simulator.device_number):
976         (Simulator.device_state_description):
977         (Simulator.wait_until_device_is_in_state):
978
979 2016-08-19  Ryan Haddad  <ryanhaddad@apple.com>
980
981         Unreviewed, rolling out r204659.
982
983         This change appears to have caused ios-simulator LayoutTests
984         to fail when shutting down the simulator
985
986         Reverted changeset:
987
988         "REGRESSION (r204477): Running LayoutTests on ios-simulator
989         became ~15 minutes slower"
990         https://bugs.webkit.org/show_bug.cgi?id=160985
991         http://trac.webkit.org/changeset/204659
992
993 2016-08-19  Alexey Proskuryakov  <ap@apple.com>
994
995         Build fix for non-USE_SIM_SERVICE_CONTEXT builds
996         * LayoutTestRelay/LayoutTestRelay/main.m: (main):
997
998 2016-08-18  Simon Fraser  <simon.fraser@apple.com>
999
1000         REGRESSION (r204477): Running LayoutTests on ios-simulator became ~15 minutes slower
1001         https://bugs.webkit.org/show_bug.cgi?id=160985
1002
1003         Reviewed by Alexey Proskuryakov.
1004         
1005         r204477 removed @memoized on a couple of ios.py functions, causing them to instantiate
1006         a Simulator() on every call, which causes 'xcrun simctl list' to run. The functions
1007         must not be @memoized, because their return value depends on the value of simulator_device_type().
1008         
1009         Fix by adding some global state in simulator.py that tracks the created devices 
1010         in a worker number -> Device dictionary. Explicitly create devices in _create_simulators(),
1011         and delete them in clean_up_test_run().
1012         
1013         Also explicitly called 'xcrun simctl shutdown' to shut down devices, since it seems
1014         that killing the Simulator apps isn't enough.
1015         
1016         Simulator tracks the devices in a global dictionary, since state needs to persist
1017         across different instances of IOSSimulatorPort.
1018         
1019         Annoyingly, the "Command line:" dumping tried to access a device before we'd done
1020         any setup. Rather than implicitly creating a device here (which the old code did),
1021         override the more clearly named driver_cmd_line_for_logging() in IOSSimulatorPort
1022         and set flag to say that device_id_for_worker_number() doesn't need to return a real
1023         device id.
1024
1025         * Scripts/webkitpy/layout_tests/views/printing.py:
1026         (print_options):
1027         (Printer.print_config):
1028         * Scripts/webkitpy/port/base.py:
1029         (Port.driver_cmd_line_for_logging):
1030         (Port.driver_cmd_line): Deleted.
1031         * Scripts/webkitpy/port/driver.py:
1032         (IOSSimulatorDriver.cmd_line):
1033         * Scripts/webkitpy/port/ios.py:
1034         (IOSSimulatorPort.__init__):
1035         (IOSSimulatorPort.driver_cmd_line_for_logging):
1036         (IOSSimulatorPort._create_simulators):
1037         (IOSSimulatorPort.setup_test_run):
1038         (IOSSimulatorPort.clean_up_test_run):
1039         (IOSSimulatorPort._create_device):
1040         (IOSSimulatorPort):
1041         (IOSSimulatorPort._remove_device):
1042         (IOSSimulatorPort._testing_device):
1043         (IOSSimulatorPort.device_id_for_worker_number):
1044         (IOSSimulatorPort._set_device_class): Deleted.
1045         (IOSSimulatorPort.testing_device): Deleted.
1046         * Scripts/webkitpy/port/port_testcase.py:
1047         (PortTestCase.test_driver_cmd_line):
1048         * Scripts/webkitpy/xcode/simulator.py:
1049         (Device.shutdown):
1050         (Device.delete):
1051         (Device.reset):
1052         (Simulator.create_device):
1053         (Simulator.remove_device):
1054         (Simulator.device_number):
1055         (Simulator.device_state_description):
1056         (Simulator.wait_until_device_is_in_state):
1057
1058 2016-08-19  Alexey Proskuryakov  <ap@apple.com>
1059
1060         Adopt SimServiceContext in LayoutTestRelay
1061         https://bugs.webkit.org/show_bug.cgi?id=161000
1062         <rdar://problem/25765594>
1063
1064         Reviewed by Daniel Bates.
1065
1066         * LayoutTestRelay/LayoutTestRelay/CoreSimulatorSPI.h:
1067         * LayoutTestRelay/LayoutTestRelay/main.m:
1068
1069 2016-08-19  Lucas Forschler  <lforschler@apple.com>
1070
1071         Remove Yosemite Leaks bot after http://trac.webkit.org/projects/webkit/changeset/204629
1072
1073         Reviewed by Kocsen Chung.
1074
1075         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1076         (WebKitBuildbot):
1077
1078 2016-08-19  Alexey Proskuryakov  <ap@apple.com>
1079
1080         Partial revert of r203811 - this key is not needed.
1081
1082         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m: (-[LTRelayController installApp]):
1083
1084 2016-08-19  Daniel Bates  <dabates@apple.com>
1085
1086         Another attempt to fix the iOS 9.3 build
1087
1088         Define WK_EMPTY_, WK_NOT_, and WK_NOT_YES.
1089
1090         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1091         * WebKitTestRunner/Configurations/Base.xcconfig:
1092
1093 2016-08-19  Lucas Forschler  <lforschler@apple.com>
1094
1095         Remove Yosemite Leaks bot from config.json
1096         
1097         Reviewed by Alexey Proskuryakov.
1098
1099         * BuildSlaveSupport/build.webkit.org-config/config.json:
1100
1101 2016-08-18  Dan Bernstein  <mitz@apple.com>
1102
1103         [Cocoa] API::Number needs to be wrapped by an NSNumber
1104         https://bugs.webkit.org/show_bug.cgi?id=160977
1105         <rdar://problem/27877735>
1106
1107         Reviewed by Anders Carlsson.
1108
1109         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1110         * TestWebKitAPI/Tests/WebKit2Cocoa/WKNSNumber.mm: Added.
1111         (TestWebKitAPI::TEST):
1112
1113 2016-08-17  Myles C. Maxfield  <mmaxfield@apple.com>
1114
1115         [Cocoa] Migrate off of deprecated CoreGraphics API CGContextSelectFont() and CGContextShowTextAtPoint()
1116         https://bugs.webkit.org/show_bug.cgi?id=160895
1117
1118         Reviewed by Dean Jackson.
1119
1120         Link to the existing CoreText framework.
1121
1122         * DumpRenderTree/PlatformWin.cmake:
1123         * TestWebKitAPI/PlatformWin.cmake:
1124
1125 2016-08-17  Brent Fulgham  <bfulgham@apple.com>
1126
1127         [Win] Remove old libraries from build inputs
1128         https://bugs.webkit.org/show_bug.cgi?id=160949
1129
1130         Reviewed by Dean Jackson.
1131
1132         Modify the download script to remove the old 'icuuc.lib' and
1133         'icuin.lib' files for Windows builds.
1134
1135         * Scripts/update-webkit-auxiliary-libs:
1136
1137 2016-08-17  Jonathan Bedard  <jbedard@apple.com>
1138
1139         Extra logging for crash reason
1140         https://bugs.webkit.org/show_bug.cgi?id=160943
1141
1142         Reviewed by Alexey Proskuryakov.
1143
1144         A number of tests have been erroneously marked as crashed, this should help diagnose these false crashes.
1145
1146         * Scripts/webkitpy/port/server_process.py:
1147         (ServerProcess.write): Add extra logging to determine why a process has been marked as crashed.
1148         (ServerProcess._wait_for_data_and_update_buffers_using_select): Ditto.
1149         (ServerProcess.has_crashed): Ditto.
1150
1151 2016-08-17  Dan Bernstein  <mitz@apple.com>
1152
1153         [Cocoa] -[NSString isEqualToString:] returns NO for any WKNSString argument
1154         https://bugs.webkit.org/show_bug.cgi?id=160938
1155         <rdar://problem/27876652>
1156
1157         Reviewed by Anders Carlsson.
1158
1159         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1160         * TestWebKitAPI/Tests/WebKit2Cocoa/WKObject.mm: Added.
1161         (TestWebKitAPI::TEST):
1162
1163 2016-08-17  Chris Fleizach  <cfleizach@apple.com>
1164
1165         AX: Support abbreviations in iOS
1166         https://bugs.webkit.org/show_bug.cgi?id=160907
1167
1168         Reviewed by Joanmarie Diggs.
1169
1170         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1171         (AccessibilityUIElement::stringAttributeValue):
1172         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1173         (WTR::AccessibilityUIElement::stringAttributeValue):
1174
1175 2016-08-17  Gyuyoung Kim  <gyuyoung.kim@navercorp.com>
1176
1177         [EFL] Bump efl version from 1.17 to 1.18
1178         https://bugs.webkit.org/show_bug.cgi?id=160899
1179
1180         Reviewed by Antonio Gomes.
1181
1182         To use efl-1.18, EFL port needs to update install dependencies as well.
1183
1184         * efl/install-dependencies:
1185         * efl/jhbuild.modules:
1186
1187 2016-08-17  Per Arne Vollan  <pvollan@apple.com>
1188
1189         [Win] Add tests for linked fonts.
1190         https://bugs.webkit.org/show_bug.cgi?id=160898
1191
1192         Reviewed by Brent Fulgham.
1193
1194         Add tests for https://trac.webkit.org/changeset/204502.
1195
1196         * TestWebKitAPI/PlatformWin.cmake:
1197         * TestWebKitAPI/Tests/WebCore/win/LinkedFonts.cpp: Added.
1198         (TestWebKitAPI::TEST):
1199
1200 2016-08-16  Daniel Bates  <dabates@apple.com>
1201
1202         prepare-ChangeLog: Extract logic from generateFunctionLists() into a function that takes a delegate object
1203         https://bugs.webkit.org/show_bug.cgi?id=160924
1204
1205         Reviewed by Stephanie Lewis.
1206
1207         Towards adding unit tests for generateFunctionLists() we move its logic into actuallyGenerateFunctionLists()
1208         and have actuallyGenerateFunctionLists() take a delegate object to use to query the file system and SCM.
1209         We modify generateFunctionLists() to call actuallyGenerateFunctionLists(). This will make is possible to
1210         test the generate function list machinery without requiring a SCM checkout by substituting a delegate
1211         object that mocks out the file system and SCM operations.
1212
1213         * Scripts/VCSUtils.pm:
1214         (parseDiffStartLine): Parses an SVN or Git start line and returns the path to the target file.
1215         * Scripts/prepare-ChangeLog:
1216         (generateFunctionLists): Move functionality to actually generate the function lists to actuallyGenerateFunctionLists(),
1217         abstracting the logic to query the file system and SCM into functions on a delegate object that
1218         we pass to it.
1219         (actuallyGenerateFunctionLists): Extracted from generateFunctionLists().
1220         (diffHeaderFormat): Deleted.
1221
1222 2016-08-16  Alex Christensen  <achristensen@webkit.org>
1223
1224         URLParser should parse URLs without credentials
1225         https://bugs.webkit.org/show_bug.cgi?id=160913
1226
1227         Reviewed by Brady Eidson.
1228
1229         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1230         (TestWebKitAPI::s):
1231         (TestWebKitAPI::checkURL):
1232         (TestWebKitAPI::TEST_F):
1233
1234 2016-08-16  Anders Carlsson  <andersca@apple.com>
1235
1236         Add WTF::ScopeExit
1237         https://bugs.webkit.org/show_bug.cgi?id=160908
1238
1239         Reviewed by Geoffrey Garen.
1240
1241         * TestWebKitAPI/CMakeLists.txt:
1242         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1243         * TestWebKitAPI/Tests/WTF/Scope.cpp: Added.
1244         (TestWebKitAPI::TEST):
1245
1246 2016-08-16  Aakash Jain  <aakash_jain@apple.com>
1247
1248         EWS logs file are rotated too quickly
1249         https://bugs.webkit.org/show_bug.cgi?id=160724
1250
1251         Reviewed by Daniel Bates.
1252
1253         Currently we are rotating the log file after 10 iterations of queue. If the queue
1254         doesn't have any pending patches, these iterations result in very small amount of 
1255         logs (1 KB log file). Even if the queue process some patches, logs are few KBs.
1256         This results in a lot of log files in a day. This patch ensures that we rotate the
1257         log file when its file size is greater than or equal to 100 KB.
1258
1259         * EWSTools/start-queue-mac.sh: Added check for file size before rotating log file.
1260
1261 2016-08-16  Daniel Bates  <dabates@apple.com>
1262
1263         WKSI static library should be named by major iOS revision, not individual updates
1264         https://bugs.webkit.org/show_bug.cgi?id=160727
1265         <rdar://problem/22274848>
1266
1267         Reviewed by Alexey Proskuryakov.
1268
1269         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1270         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1271         * Scripts/copy-webkitlibraries-to-product-directory:
1272         * WebKitTestRunner/Configurations/Base.xcconfig:
1273         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1274
1275 2016-08-16  Simon Fraser  <simon.fraser@apple.com>
1276
1277         Make it possible to test iOS select elements, and add iPhone and iPad tests for them
1278         https://bugs.webkit.org/show_bug.cgi?id=160909
1279
1280         Reviewed by Enrica Casucci.
1281         
1282         Add functions to UIScriptController to dismiss the form accessory view for iOS,
1283         and to programmatically pick a row from a <select> picker.
1284
1285         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
1286         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
1287         (WTR::UIScriptController::dismissFormAccessoryView):
1288         (WTR::UIScriptController::selectFormAccessoryPickerRow):
1289         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
1290         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1291         (WTR::UIScriptController::dismissFormAccessoryView):
1292         (WTR::UIScriptController::selectFormAccessoryPickerRow):
1293
1294 2016-08-15  Simon Fraser  <simon.fraser@apple.com>
1295
1296         [iOS] Add iPad viewport and form tests, and revert the iPad-testing part of r202132
1297         https://bugs.webkit.org/show_bug.cgi?id=160878
1298
1299         Reviewed by Tim Horton.
1300         
1301         Remove testing-specific "forceIPadStyleZoomOnInputFocus" behavior added in r202132
1302         now that we have the ability to run tests in the iPad simulator.
1303
1304         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
1305         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
1306         (WTR::UIScriptController::forceIPadStyleZoomOnInputFocus): Deleted.
1307         (WTR::UIScriptController::setForceIPadStyleZoomOnInputFocus): Deleted.
1308         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
1309         * WebKitTestRunner/ios/TestControllerIOS.mm:
1310         (WTR::TestController::platformResetStateToConsistentValues): Deleted.
1311         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1312         (WTR::UIScriptController::forceIPadStyleZoomOnInputFocus): Deleted.
1313         (WTR::UIScriptController::setForceIPadStyleZoomOnInputFocus): Deleted.
1314
1315 2016-08-15  Anders Carlsson  <andersca@apple.com>
1316
1317         Add an address-of operator to RetainPtr
1318         https://bugs.webkit.org/show_bug.cgi?id=160879
1319
1320         Reviewed by Tim Horton.
1321
1322         Test HashMap and HashSet with an object whose operator& is deleted.
1323
1324         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1325         Sort the Xcode project.
1326
1327         * TestWebKitAPI/Tests/WTF/DeletedAddressOfOperator.h: Added.
1328         (DeletedAddressOfOperator::DeletedAddressOfOperator):
1329         (DeletedAddressOfOperator::value):
1330         (DeletedAddressOfOperator::operator==):
1331         (WTF::HashTraits<DeletedAddressOfOperator>::constructDeletedValue):
1332         (WTF::HashTraits<DeletedAddressOfOperator>::isDeletedValue):
1333         (WTF::DefaultHash<DeletedAddressOfOperator>::Hash::hash):
1334         (WTF::DefaultHash<DeletedAddressOfOperator>::Hash::equal):
1335         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
1336         (TestWebKitAPI::TEST):
1337         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
1338         (TestWebKitAPI::TEST):
1339
1340 2016-08-16  Jonathan Bedard  <jbedard@apple.com>
1341
1342         False crashes in fast/text/emoji-gender-* tests
1343         https://bugs.webkit.org/show_bug.cgi?id=160779
1344
1345         Reviewed by Alexey Proskuryakov.
1346
1347         Fix from <rdar://problem/27786762>, where timed out tests falsely report as crashed.
1348
1349         * Scripts/webkitpy/port/driver.py:
1350         (Driver._check_for_driver_crash_or_unresponsiveness): Change call to ‘write’ to disable crash flag.
1351         * Scripts/webkitpy/port/driver_unittest.py: Added 3 variable to test version of ‘write.’
1352         * Scripts/webkitpy/port/server_process.py:
1353         (ServerProcess.write): Allow caller to disable crash flag on exception.
1354
1355 2016-08-15  Simon Fraser  <simon.fraser@apple.com>
1356
1357         webkitpy error in TestRunResults.merge()
1358         https://bugs.webkit.org/show_bug.cgi?id=160882
1359
1360         Reviewed by Daniel Bates.
1361         
1362         The argument to TestRunResults.merge() can be None if there are no device-specifc
1363         initial results or retry results in Manager.run(), so just return early in that case.
1364
1365         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1366         (TestRunResults.merge):
1367
1368 2016-08-15  Sam Weinig  <sam@webkit.org>
1369
1370         Speed up compile times by not including wtf/Variant.h so much
1371         https://bugs.webkit.org/show_bug.cgi?id=160847
1372
1373         Reviewed by Alex Christensen and Saam Barati.
1374
1375         * TestWebKitAPI/Tests/WTF/Variant.cpp:
1376         (TestWebKitAPI::TEST):
1377         Explicitly use std::experimental::variant.
1378
1379 2016-08-15  Simon Fraser  <simon.fraser@apple.com>
1380
1381         Allow a port to run tests with a custom device setup
1382         https://bugs.webkit.org/show_bug.cgi?id=160833
1383
1384         Reviewed by Daniel Bates.
1385
1386         These changes allow the IOSSimulator port to run tests in iPad mode.
1387
1388         This is made possible by allowing a platform to define CUSTOM_DEVICE_CLASSES,
1389         in this case 'ipad'. When specified, any test in a directory with a suffix that matches
1390         a custom device will be collected into a set, and run in that device's environment after
1391         the other tests have run.
1392
1393         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1394         (Manager._custom_device_for_test): If the test contains a directory matching a
1395         custom device suffix, return that custom device.
1396         (Manager._set_up_run): Push the custom device class, if any, into options so
1397         that the Worker can get to it.
1398         (Manager.run): Go through the list of tests, and break it down into device-generic
1399         tests, and tests for each device class. _run_test_subset is then called for
1400         each collection of tests, and the results merged.
1401         (Manager._run_test_subset): Some lines unwrapped.
1402         (Manager._end_test_run):
1403         (Manager._run_tests):
1404         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
1405         (SingleTestRunner.__init__): Unwrapped a line.
1406         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1407         (TestRunResults.merge): Add this function to merge TestRunResults
1408         * Scripts/webkitpy/layout_tests/views/printing.py:
1409         (Printer.print_workers_and_shards): Print the custom device, if any.
1410         * Scripts/webkitpy/port/base.py:
1411         (Port): Base port has empty array of custom devices.
1412         (Port.setup_test_run): Add device_class argument.
1413         * Scripts/webkitpy/port/driver.py:
1414         (DriverInput.__repr__):
1415         (Driver.check_driver.implementation):
1416         * Scripts/webkitpy/port/efl.py:
1417         (EflPort.setup_test_run):
1418         * Scripts/webkitpy/port/gtk.py:
1419         (GtkPort.setup_test_run):
1420         * Scripts/webkitpy/port/ios.py:
1421         (IOSSimulatorPort): Add CUSTOM_DEVICE_CLASSES for ipad.
1422         (IOSSimulatorPort.__init__):
1423         (IOSSimulatorPort.simulator_device_type): Use a device name from the DEVICE_CLASS_MAP
1424         based on the custom device class.
1425         (IOSSimulatorPort._set_device_class):
1426         (IOSSimulatorPort._create_simulators): Factor some code into this function.
1427         (IOSSimulatorPort.setup_test_run):
1428         (IOSSimulatorPort.testing_device):
1429         (IOSSimulatorPort.reset_preferences): This used to create the simulator apps, but that
1430         seemed wrong for this function. That was moved to setup_test_run().
1431         (IOSSimulatorPort.check_sys_deps): This function used to create testing devices,
1432         but this happened too early, before we knew which kind of devices to create. Devices
1433         are now created in setup_test_run().
1434         * Scripts/webkitpy/port/win.py:
1435         (WinPort.setup_test_run):
1436
1437 2016-08-15  Daniel Bates  <dabates@apple.com>
1438
1439         Cannot build WebKit for iOS device using Xcode 7.3/iOS 9.3 public SDK due to missing
1440         private frameworks and libraries
1441         https://bugs.webkit.org/show_bug.cgi?id=155931
1442         <rdar://problem/25807989>
1443
1444         Reviewed by Dan Bernstein.
1445
1446         Add directory WebKitLibraries/WebKitPrivateFrameworkStubs/iOS/X to the framework search path
1447         where X is the major version of the active iOS SDK.
1448
1449         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1450         * WebKitTestRunner/Configurations/Base.xcconfig:
1451
1452 2016-08-15  Simon Fraser  <simon.fraser@apple.com>
1453
1454         Add a setting and preferences to enable visual viewport mode
1455         https://bugs.webkit.org/show_bug.cgi?id=160843
1456
1457         Reviewed by Sam Weinig.
1458         
1459         Pref and a menu item to toggle visualViewportEnabled for WebKits 1 and 2.
1460
1461         * MiniBrowser/mac/SettingsController.h:
1462         * MiniBrowser/mac/SettingsController.m:
1463         (-[SettingsController _populateMenu]):
1464         (-[SettingsController validateMenuItem:]):
1465         (-[SettingsController visualViewportEnabled]):
1466         (-[SettingsController toggleVisualViewportEnabled:]):
1467         * MiniBrowser/mac/WK1BrowserWindowController.m:
1468         (-[WK1BrowserWindowController didChangeSettings]):
1469         * MiniBrowser/mac/WK2BrowserWindowController.m:
1470         (-[WK2BrowserWindowController didChangeSettings]):
1471
1472 2016-08-15  Konstantin Tokarev  <annulen@yandex.ru>
1473
1474         Allow using make-dist with non-GTK ports
1475         https://bugs.webkit.org/show_bug.cgi?id=160842
1476
1477         Reviewed by Michael Catanzaro.
1478
1479         This patch adds support for setting base name of tarball and argument
1480         passed to cmake's -DPORT= via command line arguments.
1481
1482         * gtk/make-dist.py:
1483         (Distcheck.configure):
1484         (Distcheck.check):
1485         (get_tarball_root_and_output_filename_from_arguments):
1486
1487 2016-08-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1488
1489         [GTK] Install script lacks gstreamer related dependencies
1490         https://bugs.webkit.org/show_bug.cgi?id=160814
1491
1492         Reviewed by Carlos Garcia Campos.
1493
1494         * gtk/install-dependencies: Fedora case had already listed this dependencies,
1495         but both Arch and Debian/Ubuntu were missing them.
1496
1497 2016-08-13  Konstantin Tokarev  <annulen@yandex.ru>
1498
1499         make-dist.py should not allow unknown rules in manifest
1500         https://bugs.webkit.org/show_bug.cgi?id=160841
1501
1502         Reviewed by Carlos Garcia Campos.
1503
1504         * gtk/make-dist.py:
1505         (Manifest.process_line):
1506
1507 2016-08-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1508
1509         [EFL][GTK] Install script not working on Debian 9 (testing) and Ubuntu 16.10
1510         https://bugs.webkit.org/show_bug.cgi?id=160809
1511
1512         Reviewed by Carlos Garcia Campos.
1513
1514         * efl/install-dependencies: Factorize the previous logic for handling the php5/7
1515         case, and use it also for the new package names of libpng and libgeoclue.
1516         * gtk/install-dependencies: Ditto.
1517
1518 2016-08-12  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1519
1520         Skip to check directories existence in build-webkit
1521         https://bugs.webkit.org/show_bug.cgi?id=160691
1522
1523         Reviewed by Alex Christensen.
1524
1525         CMake checks if directories are there itself. So CMake ports
1526         don't need to check it in the build-webkit script.
1527
1528         * Scripts/build-webkit:
1529         * Scripts/webkitdirs.pm:
1530         (determineSourceDir):
1531         (isCMakeBuild):
1532
1533 2016-08-12  Alex Christensen  <achristensen@webkit.org>
1534
1535         Make URLParser work with URLs missing URL parts
1536         https://bugs.webkit.org/show_bug.cgi?id=160824
1537
1538         Reviewed by Brady Eidson.
1539
1540         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1541         (TestWebKitAPI::s):
1542         (TestWebKitAPI::checkURL):
1543         (TestWebKitAPI::TEST_F):
1544         (TestWebKitAPI::eq): Deleted.
1545
1546 2016-08-12  John Wilander  <wilander@apple.com>
1547
1548         Add HashCountedSet API tests to TestWTFLibrary target
1549         https://bugs.webkit.org/show_bug.cgi?id=160815
1550
1551         Reviewed by Alex Christensen.
1552
1553         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1554             Added HashCountedSet.cpp and sorted the file reference section
1555             according to UNIX sort.
1556
1557 2016-08-12  Ryosuke Niwa  <rniwa@webkit.org>
1558
1559         run-benchmark should run JetStream 1.1 instead of 1.0.1
1560         https://bugs.webkit.org/show_bug.cgi?id=160816
1561
1562         Reviewed by Filip Pizlo.
1563
1564         Use the latest JetStream 1.1 in run-benchmark.
1565
1566         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
1567         (BenchmarkBuilder.__exit__):
1568         * Scripts/webkitpy/benchmark_runner/data/patches/JetStream.patch: Updated to apply against 1.1 directory.
1569         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Updated to use r190897, which is the last
1570         change to JetStream directory.
1571
1572 2016-08-12  Alex Christensen  <achristensen@webkit.org>
1573
1574         Initial URLParser implementation
1575         https://bugs.webkit.org/show_bug.cgi?id=160811
1576
1577         Reviewed by Brady Eidson.
1578
1579         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1580         (TestWebKitAPI::eq):
1581         (TestWebKitAPI::checkURL):
1582         (TestWebKitAPI::TEST_F):
1583
1584 2016-08-12  Brady Eidson  <beidson@apple.com>
1585
1586         Fix the 32-bit Mac build after:
1587         Add WK2 ExperimentalFeature support to MiniBrowser
1588         https://bugs.webkit.org/show_bug.cgi?id=160788
1589
1590         Unreviewed.
1591
1592         Sprinkle "#if WK_API_ENABLED"s liberally.
1593         
1594         * MiniBrowser/mac/AppDelegate.m:
1595         (defaultConfiguration):
1596         * MiniBrowser/mac/SettingsController.m:
1597         (-[SettingsController _populateMenu]):
1598         (-[SettingsController validateMenuItem:]):
1599
1600 2016-08-12  Philippe Normand  <pnormand@igalia.com>
1601
1602         [GStreamer][OWR] Video rendering fixes
1603         https://bugs.webkit.org/show_bug.cgi?id=160764
1604
1605         Reviewed by Xabier Rodriguez-Calvar.
1606
1607         * gtk/jhbuild.modules: Bump to current OpenWebRTC master.
1608
1609 2016-08-12  Per Arne Vollan  <pvollan@apple.com>
1610
1611         Add missing return statement in convertFast function added in r204376.
1612
1613         Unreviewed.
1614
1615         * Scripts/webkitpy/common/system/path.py:
1616         (_CygPath.convertFast):
1617
1618 2016-08-11  Brady Eidson  <beidson@apple.com>
1619
1620         Add WK2 ExperimentalFeature support to MiniBrowser.
1621         https://bugs.webkit.org/show_bug.cgi?id=160788
1622
1623         Reviewed by Alex Christensen.
1624
1625         * MiniBrowser/mac/AppDelegate.h:
1626         * MiniBrowser/mac/AppDelegate.m:
1627         (defaultConfiguration):
1628         (defaultPreferences):
1629         
1630         * MiniBrowser/mac/SettingsController.m:
1631         (-[SettingsController _populateMenu]):
1632         (-[SettingsController validateMenuItem:]):
1633         (-[SettingsController toggleExperimentalFeature:]):
1634
1635 2016-08-11  Aakash Jain  <aakash_jain@apple.com>
1636
1637         Keep EWS logs for longer
1638         https://bugs.webkit.org/show_bug.cgi?id=160776
1639
1640         Reviewed by Daniel Bates.
1641
1642         * EWSTools/start-queue-mac.sh: Keep logs for 30 days instead of 14 days.
1643
1644 2016-08-11  Simon Fraser  <simon.fraser@apple.com>
1645
1646         iOS DRT/WTR project cleanup
1647         https://bugs.webkit.org/show_bug.cgi?id=160778
1648
1649         Reviewed by Tim Horton.
1650
1651         Move TARGETED_DEVICE_FAMILY from the project to an xcconfig file.
1652
1653         Remove AppDelegate.* which were unused.
1654
1655         Exclude ios/Launch.storyboard on more platforms.
1656
1657         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1658         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
1659         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
1660         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1661         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.h: Removed.
1662         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.m: Removed.
1663         (-[AppDelegate application:didFinishLaunchingWithOptions:]): Deleted.
1664
1665 2016-08-11  Alex Christensen  <achristensen@webkit.org>
1666
1667         Fix Yosemite bots' cookie accept policies after r204365.
1668         https://bugs.webkit.org/show_bug.cgi?id=160758
1669
1670         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm:
1671         (TEST):
1672         This makes the test fully clean up after itself.
1673
1674 2016-08-11  Alex Christensen  <achristensen@webkit.org>
1675
1676         Fix Yosemite bots' cookie accept policies after r204365.
1677         https://bugs.webkit.org/show_bug.cgi?id=160758
1678
1679         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm:
1680         (TEST):
1681         I didn't restore the cookieAcceptPolicy of the sharedHTTPCookieStorage after changing it with this API test.
1682         On Yosemite, this is changing the cookieAcceptPolicy that DumpRenderTree uses.
1683         On more recent Cocoa platforms, it is only changing the cookieAcceptPolicy that TestWebKitAPI uses, which isn't
1684         causing any problems because there are no other API tests that do anything with cookies.
1685         My solution will be to restore the original cookieAcceptPolicy after running this API test to clean up,
1686         but first I am committing this patch setting the cookieAcceptPolicy to NSHTTPCookieAcceptPolicyOnlyFromMainDocumentDomain
1687         to reset any bots that have run tests since r204365.  I will commit a followup that sets it to originalCookieAcceptPolicy.
1688
1689 2016-08-11  Aakash Jain  <aakash_jain@apple.com>
1690
1691         EWS should check if the patch is still valid before executing every major step
1692         https://bugs.webkit.org/show_bug.cgi?id=160739
1693         rdar://problem/27768813
1694
1695         Reviewed by Alexey Proskuryakov.
1696
1697         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1698         (CommitQueueTask.run): validate method is now executed in base class.
1699         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
1700         (EarlyWarningSystemTask.run): validate method is now executed in base class.
1701         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
1702         (StyleQueueTask.validate): Raise an PatchIsNotValid exception instead of returning False.
1703         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1704         (PatchAnalysisTask._run_command): validate the patch before executing any command. This is to ensure
1705         that we do not waste time on any patch which has become invalid (e.g.: obsolete, r-).
1706         * Scripts/webkitpy/tool/commands/perfalizer.py:
1707         (PerfalizerTask.validate): Added.
1708         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1709         (test_manual_reject_during_processing): Updated test case.
1710
1711 2016-08-11  Alex Christensen  <achristensen@webkit.org>
1712
1713         Add URLParser stub
1714         https://bugs.webkit.org/show_bug.cgi?id=160770
1715
1716         Reviewed by Sam Weinig.
1717
1718         * TestWebKitAPI/PlatformGTK.cmake:
1719         * TestWebKitAPI/PlatformWin.cmake:
1720         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1721         * TestWebKitAPI/Tests/WebCore/URLParser.cpp: Added.
1722         (TestWebKitAPI::TEST_F):
1723
1724 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
1725
1726         [iOS DRT] Allow DRT to be iPad-sized in the iPad simulator
1727         https://bugs.webkit.org/show_bug.cgi?id=160761
1728
1729         Reviewed by Tim Horton.
1730
1731         Give iOS DRT a Launch storyboard.
1732
1733         Have it use a UIViewController so future forms testing works correctly.
1734
1735         Add TARGETED_DEVICE_FAMILY = "1,2" to the build settings for the .app, so that it
1736         can run in iPad mode.
1737
1738         Remove empty InfoPlist.strings files.
1739
1740         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1741         * DumpRenderTree/ios/Info.plist:
1742         * DumpRenderTree/ios/Launch.storyboard: Added.
1743         * DumpRenderTree/mac/DumpRenderTree.mm:
1744         (createWebViewAndOffscreenWindow):
1745         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1746         * WebKitTestRunner/WebKitTestRunnerApp/en.lproj/InfoPlist.strings: Removed.
1747         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1748         (WTR::PlatformWebView::PlatformWebView): Drive-by leak fix.
1749
1750 2016-08-11  Per Arne Vollan  <pvollan@apple.com>
1751
1752         [Win] Unable to reliably run tests in parallel
1753         https://bugs.webkit.org/show_bug.cgi?id=140914
1754
1755         Reviewed by Brent Fulgham.
1756
1757         The cygpath utility function can fail badly when running with multiple DumpRenderTree
1758         processes. We can use string replacement to convert the Cygwin path to a Windows path
1759         instead.
1760
1761         * Scripts/webkitpy/common/system/path.py:
1762         (cygpathFast):
1763         * Scripts/webkitpy/port/driver.py:
1764         (Driver._command_from_driver_input):
1765
1766 2016-08-10  Alex Christensen  <achristensen@webkit.org>
1767
1768         Fix crash when changing cookie accept policy after r204327
1769         https://bugs.webkit.org/show_bug.cgi?id=160758
1770
1771         Reviewed by Simon Fraser.
1772
1773         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1774         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm: Added.
1775         (-[CookieAcceptPolicyMessageHandler userContentController:didReceiveScriptMessage:]):
1776         (TEST):
1777         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieMessage.html: Added.
1778
1779 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
1780
1781         [iOS WK2] Have WebKitTestRunnerApp.app use a UIViewController, and fix to avoid the status bar
1782         https://bugs.webkit.org/show_bug.cgi?id=160757
1783
1784         Reviewed by Tim Horton.
1785
1786         When programmatically creating the test UIWindow, make a root UIViewController and parent
1787         the WKWebView in its view. This makes the app more like a normal UIKit application.
1788         
1789         Move the WKWebView down 20px to avoid the status bar.
1790         
1791         Give the UIWindow a gray background so it's obvious where the window and view positioned.
1792
1793         Sorted the project file. Removed the link to UIKit which showed red, and wasn't necessary.
1794         
1795         Remove duplicate references to Launch.storyboard.
1796
1797         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1798         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.h: Add license.
1799         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.m: Add license.
1800         (-[AppDelegate applicationWillResignActive:]): Deleted.
1801         (-[AppDelegate applicationDidEnterBackground:]): Deleted.
1802         (-[AppDelegate applicationWillEnterForeground:]): Deleted.
1803         (-[AppDelegate applicationDidBecomeActive:]): Deleted.
1804         (-[AppDelegate applicationWillTerminate:]): Deleted.
1805         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1806         (WTR::viewRectForWindowRect):
1807         (WTR::PlatformWebView::PlatformWebView):
1808         (WTR::PlatformWebView::setWindowFrame):
1809
1810 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
1811
1812         [iOS WK2] Use the simulated device's screen size, rather than a harcoded size
1813         https://bugs.webkit.org/show_bug.cgi?id=160748
1814
1815         Reviewed by Tim Horton.
1816         
1817         Use the main UIScreen's bounds for the window size if we're using a flexible viewport. This
1818         opens the door for tests using other device sizes.
1819
1820         * WebKitTestRunner/ios/TestControllerIOS.mm:
1821         (WTR::TestController::platformConfigureViewForTest):
1822
1823 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
1824
1825         Sort the feature flags in the FEATURE_DEFINES lines
1826         https://bugs.webkit.org/show_bug.cgi?id=160742
1827
1828         Reviewed by Anders Carlsson.
1829         
1830         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1831
1832 2016-08-09  Simon Fraser  <simon.fraser@apple.com>
1833
1834         Logging and other minor improvements to iOS webkitpy
1835         https://bugs.webkit.org/show_bug.cgi?id=160722
1836
1837         Reviewed by Dan Bates.
1838
1839         Fix --debug-rwt-logging to log all the calls to simctl as well as device state information,
1840         to make it easier to debug launching issues.
1841
1842         Have reset_preferences() reset the device, rather than just nuking the data
1843         directory (which broke some versions of the simulator).
1844
1845         Make the Simulator.app launch in the background with open -g.
1846
1847         Wait for the simulator device to be in a known state in some more places.
1848
1849         * Scripts/webkitpy/port/ios.py:
1850         (IOSSimulatorPort.setup_test_run):
1851         (IOSSimulatorPort._quit_ios_simulator):
1852         (IOSSimulatorPort.clean_up_test_run):
1853         (IOSSimulatorPort.setup_environ_for_server):
1854         (IOSSimulatorPort.reset_preferences):
1855         * Scripts/webkitpy/xcode/simulator.py:
1856         (Device.create):
1857         (Device.delete):
1858         (Device):
1859         (Device.reset):
1860         (Simulator.wait_until_device_is_booted):
1861         (Simulator.wait_until_device_is_in_state):
1862         (Simulator):
1863         (Simulator.delete_device):
1864         (Simulator.reset_device):
1865         (Simulator.lookup_or_create_device):
1866
1867 2016-08-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1868
1869         [GTK][EFL] ALSA_CARD environment variable is not passed for layout tests.
1870         https://bugs.webkit.org/show_bug.cgi?id=160697
1871
1872         Reviewed by Antonio Gomes.
1873
1874         * Scripts/webkitpy/port/base.py:
1875         (Port.to.setup_environ_for_server): Add ALSA_CARD and sort the Linux
1876         list of environment variables to copy.
1877
1878 2016-08-09  George Ruan  <gruan@apple.com>
1879
1880         Implement functionality of media capture on iOS
1881         https://bugs.webkit.org/show_bug.cgi?id=158945
1882         <rdar://problem/26893343>
1883
1884         Reviewed by Tim Horton.
1885
1886         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Enable Media
1887         Capture feature on iOS.
1888
1889 2016-08-09  Saam Barati  <sbarati@apple.com>
1890
1891         Parser<LexerType>::parseFunctionInfo() has the wrong info about captured vars when a function is not cached.
1892         https://bugs.webkit.org/show_bug.cgi?id=160671
1893         <rdar://problem/27756112>
1894
1895         Reviewed by Mark Lam.
1896
1897         * Scripts/run-jsc-stress-tests:
1898
1899 2016-08-09  Alexey Proskuryakov  <ap@apple.com>
1900
1901         Make directory reading code in iOSSimulatorDevices() more strict
1902         https://bugs.webkit.org/show_bug.cgi?id=160702
1903
1904         Reviewed by Tim Horton.
1905
1906         * Scripts/webkitdirs.pm:
1907         (iOSSimulatorDevices):
1908
1909 2016-08-06  Sam Weinig  <sam@webkit.org>
1910
1911         Replace NodeOrString with std::variant<RefPtr<Node>, String>
1912         https://bugs.webkit.org/show_bug.cgi?id=160638
1913
1914         Reviewed by Anders Carlsson.
1915
1916         * TestWebKitAPI/CMakeLists.txt:
1917         * TestWebKitAPI/Tests/WTF/Variant.cpp:
1918         Add additional tests for the initial state of std::variant and using
1919         makeVisitor for visiting.
1920
1921 2016-08-09  Aakash Jain  <aakash_jain@apple.com>
1922
1923         EWS logging should ensure the logging to file is stopped on queue termination
1924         https://bugs.webkit.org/show_bug.cgi?id=160698
1925         rdar://problem/24464570
1926
1927         Reviewed by Daniel Bates.
1928
1929         * Scripts/webkitpy/tool/bot/queueengine.py:
1930         (QueueEngine._stopping): Stop logging to file on queue termination.
1931         (QueueEngine._begin_logging): Configure the Python logger to log to file.
1932         * Scripts/webkitpy/common/system/logutils.py:
1933         (configure_logger_to_log_to_file): Return the handler so as to enable caller to remove it later.
1934         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
1935         (QueueEngineTest._run_engine): Removed extra newline character to improve log readability.
1936         * Scripts/webkitpy/tool/commands/queues.py:
1937         (AbstractQueue._log_directory): Reverting to os.path.join as we don't have host object.
1938         (AbstractQueue.queue_log_path): Same.
1939         (AbstractQueue.begin_work_queue): Removed logging initialization, it is now being done in QueueEngine.
1940         (AbstractQueue.__init__): Removed host parameter, not required anymore, it was required by logging initialization
1941         which moved to QueueEngine now.
1942         (PatchProcessingQueue.__init__): Same.
1943         (CommitQueue.__init__): Same.
1944         (AbstractReviewQueue.__init__): Same.
1945         (StyleQueue.__init__): Same.
1946         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1947         (TestCommitQueue): Removed host parameter.
1948         (TestCommitQueue.__init__): Same.
1949         (AbstractPatchQueueTest.test_next_patch): Same.
1950         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Same.
1951         (test_commit_queue_failure): Same.
1952         (mock_run_webkit_patch):
1953         (MockCommitQueueTask.results_from_patch_test_run): Same.
1954         (test_rollout_lands): Same.
1955         (test_non_valid_patch): Same.
1956         (test_auto_retry): Same.
1957         (test_style_queue_with_watch_list_exception): Same.
1958         (TestQueue.__init__): Deleted.
1959         (TestReviewQueue.__init__): Deleted.
1960         (TestFeederQueue.__init__): Deleted.
1961
1962 2016-08-09  Konstantin Tokarev  <annulen@yandex.ru>
1963
1964         webkit-gtk tarball fails to build due to missing files
1965         https://bugs.webkit.org/show_bug.cgi?id=160684
1966
1967         Reviewed by Alex Christensen.
1968
1969         * gtk/manifest.txt.in: Added back spi directories.
1970
1971 2016-08-09  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1972
1973         [GTK] Build the jhbuild with -O2 optimization level by default
1974         https://bugs.webkit.org/show_bug.cgi?id=160544
1975
1976         Reviewed by Michael Catanzaro.
1977
1978         * gtk/jhbuildrc: Pass -O2 when building the JHBuild, as also -g1
1979         which don't increases the required disk space significatively and
1980         provides better debug information than no passing it.
1981
1982 2016-08-09  Csaba Osztrogonác  <ossy@webkit.org>
1983
1984         Allow more --cmakeargs option in build-jsc and build-webkit
1985         https://bugs.webkit.org/show_bug.cgi?id=160340
1986
1987         Reviewed by Michael Catanzaro.
1988
1989         * Scripts/build-jsc:
1990         * Scripts/build-webkit:
1991
1992 2016-08-09  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1993
1994         Do not check if WebKitLibraries folder exists on EFL and GTK
1995         https://bugs.webkit.org/show_bug.cgi?id=160659
1996
1997         Reviewed by Csaba Osztrogonác.
1998
1999         Though WebKitLibraries is only needed by mac and win ports,
2000         EFL and GTK ports have checked whether it exists.
2001
2002         * Scripts/build-webkit:
2003
2004 2016-08-08  Aakash Jain  <aakash_jain@apple.com>
2005
2006         Some EWS console logs doesn't go to log file
2007         https://bugs.webkit.org/show_bug.cgi?id=160585
2008         rdar://problem/24464570
2009
2010         Reviewed by Daniel Bates.
2011
2012         * Scripts/webkitpy/common/system/logutils.py:
2013         (FileSystemHandler._open): Ensure that we open logfile in append mode in order to avoid
2014         any possible overwriting.
2015         * Scripts/webkitpy/common/system/filesystem.py:
2016         (FileSystem.open_text_file_for_writing): Add should_append parameter to append to file.
2017         * Scripts/webkitpy/common/system/filesystem_mock.py:
2018         (MockFileSystem.open_text_file_for_writing): Same.
2019         * Scripts/webkitpy/common/system/filesystem_unittest.py:
2020         (RealFileSystemTest.test_read_and_write_text_file): Removed unused variable 'hex_equivalent'.
2021         (RealFileSystemTest.test_append_to_text_file): Added new unit test for testing append functionality.
2022         * Scripts/webkitpy/tool/commands/queues.py:
2023         (AbstractQueue.begin_work_queue): Configure the logger for overall webkitpy to log to file.
2024         This will ensure that all the sub-modules inside webkitpy will log to file.
2025
2026 2016-08-08  Simon Fraser  <simon.fraser@apple.com>
2027
2028         Have the iOS platform interit from the Apple platform in webkitpy
2029         https://bugs.webkit.org/show_bug.cgi?id=160672
2030
2031         Reviewed by Dan Bates.
2032         
2033         The IOSSimulatorPort used to inherit from Port, rather than ApplePort.
2034         Fix this, and move duplicated code from IOSSimulatorPort and MacPort into
2035         ApplePort.
2036         
2037         Since WinPort also inherits from ApplePort, it needs to stub out some things
2038         that are unavailable on Windows (leaks, sampling).
2039         
2040         Some SnowLeopard-related code and the associated test were removed.
2041
2042         * Scripts/webkitpy/port/apple.py:
2043         (ApplePort.__init__):
2044         (ApplePort):
2045         (ApplePort._make_leak_detector):
2046         (ApplePort.default_timeout_ms):
2047         (ApplePort.supports_per_test_timeout):
2048         (ApplePort.should_retry_crashes):
2049         (ApplePort._generate_all_test_configurations):
2050         (ApplePort.check_for_leaks):
2051         (ApplePort.print_leaks_summary):
2052         (ApplePort._path_to_webcore_library):
2053         (ApplePort.show_results_html_file):
2054         (ApplePort._merge_crash_logs):
2055         (ApplePort._look_for_all_crash_logs_in_log_dir):
2056         (ApplePort._get_crash_log):
2057         (ApplePort.look_for_new_crash_logs):
2058         (ApplePort.sample_process):
2059         (ApplePort.sample_file_path):
2060         (ApplePort.look_for_new_samples):
2061         (ApplePort._path_to_helper):
2062         (ApplePort.determine_full_port_name): Deleted.
2063         * Scripts/webkitpy/port/ios.py:
2064         (IOSSimulatorPort):
2065         (IOSSimulatorPort.__init__):
2066         (IOSSimulatorPort.default_timeout_ms): Deleted.
2067         (IOSSimulatorPort.supports_per_test_timeout): Deleted.
2068         (IOSSimulatorPort.should_retry_crashes): Deleted.
2069         (IOSSimulatorPort.check_for_leaks): Deleted.
2070         (IOSSimulatorPort.print_leaks_summary): Deleted.
2071         (IOSSimulatorPort._path_to_webcore_library): Deleted.
2072         (IOSSimulatorPort.show_results_html_file): Deleted.
2073         (IOSSimulatorPort.sample_file_path): Deleted.
2074         (IOSSimulatorPort._merge_crash_logs): Deleted.
2075         (IOSSimulatorPort._look_for_all_crash_logs_in_log_dir): Deleted.
2076         (IOSSimulatorPort.look_for_new_crash_logs): Deleted.
2077         (IOSSimulatorPort.look_for_new_samples): Deleted.
2078         (IOSSimulatorPort.sample_process): Deleted.
2079         (IOSSimulatorPort._path_to_helper): Deleted.
2080         (IOSSimulatorPort.make_command): Deleted.
2081         * Scripts/webkitpy/port/mac.py:
2082         (MacPort.__init__):
2083         (MacPort.make_command):
2084         (MacPort._build_java_test_support):
2085         (MacPort): Deleted.
2086         (MacPort.default_timeout_ms): Deleted.
2087         (MacPort.supports_per_test_timeout): Deleted.
2088         (MacPort.should_retry_crashes): Deleted.
2089         (MacPort.default_child_processes): Deleted.
2090         (MacPort.check_for_leaks): Deleted.
2091         (MacPort.print_leaks_summary): Deleted.
2092         (MacPort._path_to_webcore_library): Deleted.
2093         (MacPort.show_results_html_file): Deleted.
2094         (MacPort.sample_file_path): Deleted.
2095         (MacPort._merge_crash_logs): Deleted.
2096         (MacPort._look_for_all_crash_logs_in_log_dir): Deleted.
2097         (MacPort.look_for_new_crash_logs): Deleted.
2098         (MacPort.look_for_new_samples): Deleted.
2099         (MacPort.sample_process): Deleted.
2100         (MacPort._path_to_helper): Deleted.
2101         * Scripts/webkitpy/port/mac_unittest.py:
2102         (MacTest.test_default_child_processes): Deleted.
2103         * Scripts/webkitpy/port/win.py:
2104         (WinPort.look_for_new_samples):
2105         (WinPort):
2106         (WinPort.sample_process):
2107         (WinPort._make_leak_detector):
2108         (WinPort.check_for_leaks):
2109         (WinPort.print_leaks_summary):
2110         (WinPort._path_to_webcore_library):
2111
2112 2016-08-08  Matt Baker  <mattbaker@apple.com>
2113
2114         Unreviewed: moved myself to the reviewers list.
2115
2116         * Scripts/webkitpy/common/config/contributors.json:
2117
2118 2016-08-08  Chris Dumez  <cdumez@apple.com>
2119
2120         Update API tests in mac/SetDocumentURI.mm after r204247
2121         https://bugs.webkit.org/show_bug.cgi?id=160660
2122
2123         Reviewed by Alex Christensen.
2124
2125         * TestWebKitAPI/Tests/mac/SetDocumentURI.mm:
2126         (TestWebKitAPI::TEST):
2127
2128 2016-08-08  Jonathan Bedard  <jbedard@apple.com>
2129
2130         run-webkit-tests should trigger a spindump when WebContent process is unresponsive
2131         https://bugs.webkit.org/show_bug.cgi?id=159827
2132
2133         Reviewed by Daniel Bates.
2134
2135         This change was spurred by a process hang which occurred between tests and did
2136         not produce a meaningful crashlog.
2137
2138         * Scripts/webkitpy/port/driver.py:
2139         (Driver._check_for_driver_crash_or_unresponsiveness): Notify test controller when finished through stdin.
2140
2141          * Scripts/webkitpy/port/ios.py:
2142         (IOSSimulatorPort):
2143         (IOSSimulatorPort.sample_process): Attempt spindump, but use sample if spindump fails.
2144         * Scripts/webkitpy/port/mac.py:
2145         (MacPort):
2146         (MacPort.sample_process): Attempt spindump, but use sample if spindump fails.
2147
2148         * Scripts/webkitpy/port/mac_unittest.py: Changed expected values to match spindump calls, added specific spindump test.
2149         * Scripts/webkitpy/port/driver_unittest.py: Added dummy write function.
2150
2151         * WebKitTestRunner/TestController.h:
2152         (WTR::TestController::usingServerMode): Added accessor for m_usingServerMode.
2153         * WebKitTestRunner/TestInvocation.cpp:
2154         (WTR::TestInvocation::dumpWebProcessUnresponsiveness): Wait for stdin before continuing when in server mode.
2155
2156 2016-08-07  Dan Bernstein  <mitz@apple.com>
2157
2158         [Cocoa] Reply block leaks if the remote object doesn’t call it
2159         https://bugs.webkit.org/show_bug.cgi?id=160642
2160
2161         Reviewed by Sam Weinig.
2162
2163         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h: Declared a new method.
2164         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
2165         (TEST): Added a test case that checks that the reply block is released even when it’s not
2166           called.
2167         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm:
2168         (-[RemoteObjectRegistryPlugIn doNotCallCompletionHandler:]): Implement new method by not
2169           calling the completion handler.
2170
2171 2016-08-07  Chris Dumez  <cdumez@apple.com>
2172
2173         Write API test to cover crash fix in r204135
2174         https://bugs.webkit.org/show_bug.cgi?id=160587
2175
2176         Reviewed by Darin Adler.
2177
2178         Add API test to cover crash fix in r204135. This reproduces the crash
2179         by destroying a related WKWebView in the webViewWebContentProcessDidTerminate
2180         callback.
2181
2182         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
2183         (-[NavigationDelegate webViewWebContentProcessDidTerminate:]):
2184         (TEST):
2185
2186 2016-08-06  Chris Dumez  <cdumez@apple.com>
2187
2188         Unreviewed, rolling out r204226.
2189
2190         Broke some API tests
2191
2192         Reverted changeset:
2193
2194         "Write API test to cover crash fix in r204135"
2195         https://bugs.webkit.org/show_bug.cgi?id=160587
2196         http://trac.webkit.org/changeset/204226
2197
2198 2016-08-06  Aakash Jain  <aakash_jain@apple.com>
2199
2200         EWS Style Queue fails to process patches which fails validation
2201         https://bugs.webkit.org/show_bug.cgi?id=160632
2202
2203         Reviewed by Alexey Proskuryakov.
2204
2205         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
2206         (StyleQueueTask.validate): Add more information about validation failure.
2207         (StyleQueueTask.run): Pass the error details in the PatchIsNotValid exception.
2208         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2209         (test_non_valid_patch): Add a unit test to test the above code path.
2210
2211 2016-08-06  Sam Weinig  <sam@webkit.org>
2212
2213         WTF needs a variant implementation
2214         https://bugs.webkit.org/show_bug.cgi?id=160618
2215
2216         Reviewed by Darin Adler.
2217
2218         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2219         * TestWebKitAPI/Tests/WTF/Variant.cpp: Added.
2220         Add tests for the variant implementation.
2221
2222 2016-08-06  Chris Dumez  <cdumez@apple.com>
2223
2224         Write API test to cover crash fix in r204135
2225         https://bugs.webkit.org/show_bug.cgi?id=160587
2226
2227         Reviewed by Darin Adler.
2228
2229         Add API test to cover crash fix in r204135. This reproduces the crash
2230         by destroying a related WKWebView in the webViewWebContentProcessDidTerminate
2231         callback.
2232
2233         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
2234         (-[NavigationDelegate webViewWebContentProcessDidTerminate:]):
2235         (TEST):
2236
2237 2016-08-05  Tim Horton  <timothy_horton@apple.com>
2238
2239         run-api-tests should use a headed simulator
2240         https://bugs.webkit.org/show_bug.cgi?id=160611
2241
2242         Reviewed by Sam Weinig.
2243
2244         CADisplayLink doesn't work in a headless simulator, but is
2245         vital for the proper functioning of WebKit2 painting on iOS.
2246         So, we should not use a headless simulator.
2247
2248         * Scripts/run-api-tests:
2249         Launch a simulator app, don't just boot the simulator.
2250
2251         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
2252         Re-enable a test that works now.
2253
2254 2016-08-05  Dan Bernstein  <mitz@apple.com>
2255
2256         [Cocoa] WKRemoteObjectCoder doesn’t handle NSRange
2257         https://bugs.webkit.org/show_bug.cgi?id=160589
2258
2259         Reviewed by Tim Horton.
2260
2261         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h:
2262         (remoteObjectInterface): Fixed a mistake in the set of allowed classes in one of the reply
2263           blocks, which wasn’t caught because the test wasn’t run correctly.
2264         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
2265         (TEST): Fixed the -selectionAndClickInformationForClickAtPoint:completionHandler: test, and
2266           added a test that sends over an NSRange.
2267         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm:
2268         (-[RemoteObjectRegistryPlugIn takeRange:completionHandler:]): Added. Calls the completion
2269           handler with the range‘s location and length.
2270
2271 2016-08-05  Enrica Casucci  <enrica@apple.com>
2272
2273         Fixing tests failing after r204175.
2274
2275         Unreviewed.
2276
2277         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig:
2278
2279 2016-08-05  Enrica Casucci  <enrica@apple.com>
2280
2281         Build fix after 204053.
2282
2283         Unreviewed.
2284
2285         * TestWebKitAPI/Configurations/Base.xcconfig:
2286         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm:
2287         (-[MockContentFilterEnabler initWithCoder:]):
2288         (-[MockContentFilterEnabler dealloc]):
2289
2290 2016-08-05  Konstantin Tokarev  <annulen@yandex.ru>
2291
2292         Print test name in "Last character read from DRT..." error message.
2293         https://bugs.webkit.org/show_bug.cgi?id=160559
2294
2295         Reviewed by Michael Catanzaro.
2296
2297         * Scripts/webkitpy/port/driver.py:
2298         (Driver.run_test):
2299         (Driver._read_first_block):
2300         (Driver._read_optional_image_block):
2301         (Driver._read_block):
2302         * Scripts/webkitpy/port/driver_unittest.py:
2303         (DriverTest.test_read_block):
2304         (DriverTest.test_read_binary_block):
2305         (DriverTest.test_read_base64_block):
2306
2307 2016-08-05  Commit Queue  <commit-queue@webkit.org>
2308
2309         Unreviewed, rolling out r204123.
2310         https://bugs.webkit.org/show_bug.cgi?id=160597
2311
2312         Caused layout test timeouts on Windows. (Requested by perarne
2313         on #webkit).
2314
2315         Reverted changeset:
2316
2317         "[Win] Unable to reliably run tests in parallel"
2318         https://bugs.webkit.org/show_bug.cgi?id=140914
2319         http://trac.webkit.org/changeset/204123
2320
2321 2016-08-04  Saam Barati  <sbarati@apple.com>
2322
2323         Restore CodeBlock jettison code to jettison when a CodeBlock has been alive for a long time
2324         https://bugs.webkit.org/show_bug.cgi?id=151241
2325
2326         Reviewed by Benjamin Poulain.
2327
2328         * Scripts/run-jsc-stress-tests:
2329
2330 2016-08-04  Dean Johnson  <dean_johnson@apple.com>
2331
2332         UI improvements to Flakiness Dashboard.
2333         https://bugs.webkit.org/show_bug.cgi?id=153295
2334
2335         Reviewed by Alexey Proskuryakov.
2336
2337         * TestResultServer/static-dashboards/flakiness_dashboard.css:
2338         (td.options-container): Center text in most fields.
2339         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2340         (createBugHTML): Text/Grammar updates.
2341         (tableHeaders): Ditto.
2342         (htmlForSingleTestRow): Ditto.
2343         (headerForTestTableHtml): Ditto.
2344         * TestResultServer/static-dashboards/ui.js: Removed the "Group: " and "Test type: " headings.
2345         (ui.html.testTypeSwitcher): Deleted. Removes the "Group:" heading.
2346
2347 2016-08-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2348
2349         [GTK] install-dependencies script misses libxslt as build-dependency and some python libs for the run-benchmark script
2350         https://bugs.webkit.org/show_bug.cgi?id=160518
2351
2352         Reviewed by Michael Catanzaro.
2353
2354         * Scripts/webkitpy/thirdparty/__init__.py:
2355         (AutoinstallImportHook._install_twisted): Twisted requires zope.interface.
2356         * gtk/install-dependencies:
2357
2358 2016-08-04  Alexey Proskuryakov  <ap@apple.com>
2359
2360         Optimize bot watcher's dashboard a little
2361         https://bugs.webkit.org/show_bug.cgi?id=160515
2362         rdar://problem/26096900
2363
2364         Reviewed by Lucas Forschler.
2365
2366         Made re-sorting after loading an iteration more efficient.
2367
2368         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2369         (BuildbotIteration.prototype._updateWithData):
2370         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2371         (BuildbotQueue.prototype.updateIterationPosition):
2372
2373 2016-08-04  Per Arne Vollan  <pvollan@apple.com>
2374
2375         [Win] Unable to reliably run tests in parallel
2376         https://bugs.webkit.org/show_bug.cgi?id=140914
2377
2378         Reviewed by Brent Fulgham.
2379
2380         The cygpath utility function can fail badly when running with multiple DumpRenderTree
2381         processes. We can use string replacement to convert the Cygwin path to a Windows path
2382         instead.
2383  
2384         * Scripts/webkitpy/common/system/path.py:
2385         (cygpathFast):
2386         * Scripts/webkitpy/port/driver.py:
2387         (Driver._command_from_driver_input):
2388
2389 2016-08-03  Aakash Jain  <aakash_jain@apple.com>
2390
2391         Document instructions for increasing process and file limits
2392         https://bugs.webkit.org/show_bug.cgi?id=160528
2393         rdar://problem/24777576
2394
2395         Reviewed by Alexey Proskuryakov.
2396
2397         * Scripts/webkitpy/port/ios.py:
2398         (IOSSimulatorPort.default_child_processes):
2399
2400 2016-08-03  Anders Carlsson  <andersca@apple.com>
2401
2402         Remove the Objective-C bindings generator
2403         https://bugs.webkit.org/show_bug.cgi?id=160526
2404
2405         Reviewed by Sam Weinig.
2406
2407         * Scripts/run-bindings-tests:
2408         Update test.
2409
2410 2016-08-03  Tim Horton  <timothy_horton@apple.com>
2411
2412         Revise a TestWebKitAPI comment to mention the actual underlying problem
2413
2414         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
2415         Note that this is because of https://bugs.webkit.org/show_bug.cgi?id=160516
2416
2417 2016-08-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2418
2419         Benchmark test content-animation timeouts always
2420         https://bugs.webkit.org/show_bug.cgi?id=160057
2421
2422         Reviewed by Simon Fraser.
2423
2424         * Scripts/webkitpy/benchmark_runner/data/plans/Skipped: Added.
2425         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
2426         (start):
2427
2428 2016-08-02  Nan Wang  <n_wang@apple.com>
2429
2430         AX: Simulated touch events are not working on iOS
2431         https://bugs.webkit.org/show_bug.cgi?id=160395
2432         <rdar://problem/27633597>
2433
2434         Reviewed by Chris Fleizach.
2435
2436         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2437         (WTR::AccessibilityUIElement::press):
2438         (WTR::AccessibilityUIElement::setSelectedChild):
2439
2440 2016-08-02  Filip Pizlo  <fpizlo@apple.com>
2441
2442         run-javascriptcore-tests should accept multiple --extra-tests
2443         https://bugs.webkit.org/show_bug.cgi?id=160486
2444
2445         Reviewed by Saam Barati.
2446         
2447         We want to be able to pass --extra-tests multiple times, to supply an arbitrary number of extra
2448         test suites. This does it by using GetOpt::Long's array support.
2449
2450         * Scripts/run-javascriptcore-tests:
2451         (runJSCStressTests):
2452
2453 2016-08-02  Enrica Casucci  <enrica@apple.com>
2454
2455         Allow building with content filtering disabled.
2456         https://bugs.webkit.org/show_bug.cgi?id=160454
2457
2458         Reviewed by Simon Fraser.
2459
2460         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2461
2462 2016-08-02  Brady Eidson  <beidson@apple.com>
2463
2464         Removing IndexedDB WebsiteData can fail for some users.
2465         https://bugs.webkit.org/show_bug.cgi?id=160463
2466
2467         Reviewed by Alex Christensen.
2468
2469         * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobThenDelete.mm:
2470
2471 2016-08-01  Alex Christensen  <achristensen@webkit.org>
2472
2473         _WKDownloadDelegate.didReceiveResponse should be called before decideDestinationWithSuggestedFilename
2474         https://bugs.webkit.org/show_bug.cgi?id=160437
2475         <rdar://problem/27578272>
2476
2477         Reviewed by Brady Eidson.
2478
2479         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2480         (-[DownloadDelegate _download:didReceiveResponse:]):
2481         (-[DownloadDelegate _download:decideDestinationWithSuggestedFilename:allowOverwrite:]):
2482         (runTest):
2483         Add a boolean to make sure that didReceiveResponse is called before decideDestinationWithSuggestedFilename.
2484
2485 2016-08-01  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2486
2487         [Tools] The GDB backtrace report tool don't checks the gdb return code.
2488         https://bugs.webkit.org/show_bug.cgi?id=160414
2489
2490         Reviewed by Michael Catanzaro.
2491
2492         * Scripts/webkitpy/port/linux_get_crash_log.py:
2493         (GDBCrashLogGenerator._wait_for_corefile):
2494
2495 2016-08-01  Youenn Fablet  <youenn@apple.com>
2496
2497         Make wpt server generate its certificates in layout test results folder
2498         https://bugs.webkit.org/show_bug.cgi?id=160422
2499
2500         Reviewed by Chris Dumez.
2501
2502         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
2503         (WebPlatformTestServer._copy_webkit_test_files): Setting certificate folder to layout tests results directory.
2504
2505 2016-08-01  Jonathan Bedard  <jbedard@apple.com>
2506
2507         Function Call on NULL Object
2508         https://bugs.webkit.org/show_bug.cgi?id=160325
2509
2510         Reviewed by Darin Adler.
2511
2512         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2513         (WTR::InjectedBundle::didReceiveMessageToPage): Changed removeAllWebNotificationPermissions() call to static function call.
2514         * WebKitTestRunner/InjectedBundle/TestRunner.h: Made all web-notification functions static.
2515
2516 2016-08-01  Keith Miller  <keith_miller@apple.com>
2517
2518         We should not keep the JavaScript tests inside the Source/JavaScriptCore/ directory.
2519         https://bugs.webkit.org/show_bug.cgi?id=160372
2520
2521         Rubber stamped by Geoffrey Garen.
2522
2523         This patch moves all the JavaScript tests from Source/JavaScriptCore/tests to
2524         a new top level directory, JSTests. Having the tests in the Source directory
2525         was both confusing an inconvenient for people that just want to checkout the
2526         source code of WebKit. Since there is no other obvious place to put all the
2527         JavaScript tests a new top level directory seemed the most sensible.
2528
2529         * Scripts/import-test262-tests:
2530         * Scripts/run-javascriptcore-tests:
2531         * Scripts/update-javascriptcore-test-res:
2532
2533 2016-07-31  Nan Wang  <n_wang@apple.com>
2534
2535         AX: Add a check for touch event listener on iOS accessibility object
2536         https://bugs.webkit.org/show_bug.cgi?id=160388
2537
2538         Reviewed by Chris Fleizach.
2539
2540         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2541         (AccessibilityUIElement::boolAttributeValue):
2542         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2543         (WTR::AccessibilityUIElement::boolAttributeValue):
2544
2545 2016-07-30  Manuel Rego Casasnovas  <rego@igalia.com>
2546
2547         Unreviewed: add myself to the reviewers list.
2548
2549         * Scripts/webkitpy/common/config/contributors.json:
2550
2551 2016-07-29  Alexey Proskuryakov  <ap@apple.com>
2552
2553         Undo r203939, and copy over a rule that clips the logos.
2554
2555         Sierra wasn't the only logo without transparency.
2556
2557         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra.png:
2558         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra@2x.png:
2559         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2560
2561 2016-07-29  Alan Sien Wei Hshieh  <hshieh@apple.com>
2562
2563         The Sierra asset at build.webkit.org/dashboard/images/Sierra*.png has a white background
2564         https://bugs.webkit.org/show_bug.cgi?id=160377
2565
2566         Reviewed by Brian Weinstein.
2567
2568         Update assets to remove the white background and use a transparent background instead.
2569
2570         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra.png:
2571         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra@2x.png:
2572
2573 2016-07-29  David Kilzer  <ddkilzer@apple.com>
2574
2575         Ignore most check-webkit-style checks for ANGLE project
2576         <https://webkit.org/b/160333>
2577
2578         Reviewed by Daniel Bates.
2579
2580         * Scripts/webkitpy/style/checker.py: Ignore all checkers except:
2581         - No tabs.
2582         - No spaces at the end of lines.
2583         - No carriage returns (DOS line endings).
2584
2585 2016-07-29  Wenson Hsieh  <wenson_hsieh@apple.com>
2586
2587         Media controls are not displayed for some autoplaying videos at certain browser dimensions
2588         https://bugs.webkit.org/show_bug.cgi?id=160360
2589         <rdar://problem/27179484>
2590
2591         Reviewed by Myles C. Maxfield.
2592
2593         Adds two tests verifying that videos may be considered main content as long as they
2594         are large enough and cover a majority of the mainframe's viewport.
2595
2596         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2597         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
2598         (TestWebKitAPI::TEST):
2599         * TestWebKitAPI/Tests/WebKit2Cocoa/full-size-autoplaying-video-with-audio.html: Added.
2600         * TestWebKitAPI/Tests/WebKit2Cocoa/skinny-autoplaying-video-with-audio.html: Added.
2601
2602 2016-07-29  Mark Lam  <mark.lam@apple.com>
2603
2604         Gardening: removed unused variable.
2605
2606         Not reviewed.
2607
2608         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2609         (TestWebKitAPI::TEST):
2610
2611 2016-07-29  Wenson Hsieh  <wenson_hsieh@apple.com>
2612
2613         Add TestWebKitAPI support for interacting with media controls
2614         https://bugs.webkit.org/show_bug.cgi?id=160342
2615         <rdar://problem/27610246>
2616
2617         Reviewed by Beth Dakin.
2618
2619         Adds support for testing interaction with some media controls, as well as a basic test
2620         verifying that media control teardown after interaction does not result in a crash.
2621
2622         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
2623         (-[WKWebView mouseDownAtPoint:]):
2624         (-[WKWebView performAfterLoading:]):
2625         (TestWebKitAPI::TEST):
2626
2627 2016-07-29  Jonathan Bedard  <jbedard@apple.com>
2628
2629         Crash Log Clobbering on Unbound Crashes
2630         https://bugs.webkit.org/show_bug.cgi?id=160198
2631         <rdar://problem/27472618>
2632
2633         Reviewed by Alexey Proskuryakov.
2634
2635         * Scripts/webkitpy/common/system/crashlogs.py:
2636         (CrashLogs): Fix header order.
2637         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2638         (TestResultWriter.output_filename): Only remove file extension if it is clearly a file extension.
2639
2640 2016-07-29  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
2641
2642         Update for contributors.json
2643         https://bugs.webkit.org/show_bug.cgi?id=160294
2644
2645         * Scripts/webkitpy/common/config/contributors.json:
2646
2647 2016-07-28  Myles C. Maxfield  <mmaxfield@apple.com>
2648
2649         Remove deprecated SPI for video inline / fullscreen controls
2650         https://bugs.webkit.org/show_bug.cgi?id=160318
2651
2652         Reviewed by Tim Horton.
2653
2654         * DumpRenderTree/mac/DumpRenderTree.mm:
2655         (setDefaultsToConsistentValuesForTesting): Deleted.
2656         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
2657         (RequiresUserActionForPlaybackTest::SetUp): Deleted.
2658         * WebKitTestRunner/TestController.cpp:
2659         (WTR::TestController::resetPreferencesToConsistentValues): Deleted.
2660         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2661         (WTR::initializeWebViewConfiguration): Deleted.
2662
2663 2016-07-28  Daniel Bates  <dabates@apple.com>
2664
2665         [iOS] TestWebKitAPI bundle targets are not code signed
2666         https://bugs.webkit.org/show_bug.cgi?id=160328
2667         <rdar://problem/27409246>
2668
2669         Reviewed by Andy Estes.
2670
2671         Workaround <rdar://problem/27459890> by explicitly defining Xcode build settings
2672         CODE_SIGNING_ALLOWED and AD_HOC_CODE_SIGNING_ALLOWED to be YES so as to allow the
2673         the TestWebKitAPI bundle targets to be code signed when building for the iOS simulator.
2674
2675         * TestWebKitAPI/Configurations/Base.xcconfig:
2676
2677 2016-07-28  Tim Horton  <timothy_horton@apple.com>
2678
2679         Disable WebKit2.ResizeWithHiddenContentDoesNotHang for now
2680
2681         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
2682         (animatedResizeWebView):
2683         (TEST):
2684         This test times out only when run in the WebKit Testing simulator environment,
2685         but not in a fresh simulator. Disabling to keep the bots green while under investigation.
2686
2687 2016-07-28  Tim Horton  <timothy_horton@apple.com>
2688
2689         Frequent animation lags when interacting with Safari (sidebar, tab switching, etc.)
2690         https://bugs.webkit.org/show_bug.cgi?id=160289
2691         <rdar://problem/27553464>
2692
2693         Reviewed by Simon Fraser.
2694
2695         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
2696         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2697         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm: Added.
2698         (-[AnimatedResizeNavigationDelegate _webView:renderingProgressDidChange:]):
2699         (-[AnimatedResizeWebView _endAnimatedResize]):
2700         (animatedResizeWebView):
2701         (TEST):
2702         * TestWebKitAPI/Tests/WebKit2Cocoa/blinking-div.html: Added.
2703         Add two tests that ensure that hidden-content and animated resizes
2704         don't cause unnecessary synchronous waits. Only the hidden-content
2705         one fails before my patch, but it seemed reasonable to add both anyway.
2706
2707 2016-07-28  David Kilzer  <ddkilzer@apple.com>
2708
2709         webkit-patch upload --suggest-reviewers shouldn't break in the presence of deleted or moved files
2710         <https://webkit.org/b/83342>
2711
2712         Reviewed by Ryosuke Niwa.
2713
2714         * Scripts/webkitpy/common/checkout/scm/git.py:
2715         (Git.revisions_changing_file): Remove code to raise an exception
2716         when the file doesn't exist.  If a file was moved or renamed,
2717         then this caused the script to terminate, which was very
2718         frustrating when you wanted a list of reviewers.
2719         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2720         (SCMTest._shared_test_revisions_changing_file): Update test
2721         expectation to return an empty list of revisions.
2722         (test_create_patch_is_full_patch): Drive-by fix when running all
2723         webkitpy tests (including scm tests).
2724         * Scripts/webkitpy/common/checkout/scm/svn.py:
2725         (SVN.revisions_changing_file): Catch ScriptError exceptions and
2726         return an empty array of revisions if this occurs.
2727
2728 2016-07-28  Aakash Jain  <aakash_jain@apple.com>
2729
2730         EWS error message "Error: * did not process patch" should include explanation
2731         https://bugs.webkit.org/show_bug.cgi?id=159903
2732         <rdar://problem/27410788>
2733
2734         Reviewed by Alexey Proskuryakov.
2735
2736         * QueueStatusServer/handlers/statusbubble.py:
2737         (StatusBubble._build_bubble): Display more detailed error message on bubbles when patch
2738         is not processed.
2739         * QueueStatusServer/handlers/processingtimesjson.py:
2740         (ProcessingTimesJSON._resultFromFinalStatus): Updated error message to match with rest
2741         of the code.
2742         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2743         (CommitQueueTask.validate): Add more information about validation failure.
2744         (CommitQueueTask.run): Pass the error details in the PatchIsNotValid exception.
2745         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
2746         (EarlyWarningSystemTask.validate): Add more information about validation failure.
2747         (EarlyWarningSystemTask.run): Pass the error details in the PatchIsNotValid exception.
2748         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
2749         (PatchIsNotValid.__init__): Add the failure_message argument.
2750         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2751         (AbstractEarlyWarningSystem.review_patch): Re-word the error message and include
2752         failure details.
2753         * Scripts/webkitpy/tool/commands/queues.py:
2754         (CommitQueue.process_work_item): Same.
2755         (StyleQueue.review_patch): Same.
2756         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2757         (test_non_valid_patch): Updated test-cases messages to match the above changes.
2758
2759 2016-07-27  Alexey Proskuryakov  <ap@apple.com>
2760
2761         LayoutTestRelay should wait for WebKitTestRunnerApp installation to complete
2762         https://bugs.webkit.org/show_bug.cgi?id=160262
2763
2764         Reviewed by Daniel Bates.
2765
2766         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
2767         (-[LTRelayController installApp]):
2768
2769 2016-07-27  Ryan Haddad  <ryanhaddad@apple.com>
2770
2771         Disable WebCoreNSURLSessionTest API tests on ios-simulator
2772         https://bugs.webkit.org/show_bug.cgi?id=160225
2773
2774         Reviewed by Alexey Proskuryakov.
2775
2776         * TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm:
2777
2778 2016-07-27  Miguel Gomez  <magomez@igalia.com>
2779
2780         [GTK] Fix some video/canvas tests that should be passing
2781         https://bugs.webkit.org/show_bug.cgi?id=160023
2782
2783         Reviewed by Carlos Garcia Campos.
2784
2785         Add a platform identifier to the TestRunner's page user agent when the tests are run on the
2786         EFL or GTK platforms.
2787
2788         * WebKitTestRunner/efl/TestControllerEfl.cpp:
2789         (WTR::TestController::platformConfigureViewForTest):
2790         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
2791         (WTR::TestController::platformConfigureViewForTest):
2792
2793 2016-07-27  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2794
2795         [Tools] The built product doesn't contains the dwo files when DEBUG_FISSION is enabled.
2796         https://bugs.webkit.org/show_bug.cgi?id=160247
2797
2798         Reviewed by Michael Catanzaro.
2799
2800         * BuildSlaveSupport/built-product-archive:
2801         (createZip):
2802         (dirContainsdwo):
2803         (archiveBuiltProduct):
2804
2805 2016-07-26  Alex Christensen  <achristensen@webkit.org>
2806
2807         Fix tests after r203743.
2808         https://bugs.webkit.org/show_bug.cgi?id=156947
2809
2810         * WebKitTestRunner/TestController.cpp:
2811         (WTR::TestController::resetStateToConsistentValues):
2812         Reset the new boolean m_rejectsProtectionSpaceAndContinueForAuthenticationChallenges.
2813
2814 2016-07-26  Myles C. Maxfield  <mmaxfield@apple.com>
2815
2816         [iPhone] Playing a video on tudou.com plays only sound, no video
2817         https://bugs.webkit.org/show_bug.cgi?id=160178
2818         <rdar://problem/27535468>
2819
2820         Reviewed by Dan Bernstein.
2821
2822         * DumpRenderTree/mac/DumpRenderTree.mm:
2823         (setDefaultsToConsistentValuesForTesting):
2824         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
2825         (RequiresUserActionForPlaybackTest::SetUp):
2826         * WebKitTestRunner/TestController.cpp:
2827         (WTR::TestController::resetPreferencesToConsistentValues):
2828         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2829         (WTR::initializeWebViewConfiguration):
2830
2831 2016-07-26  Simon Fraser  <simon.fraser@apple.com>
2832
2833         Allow LOG macros to be used outside the namespace, and other logging cleanup
2834         https://bugs.webkit.org/show_bug.cgi?id=160216
2835
2836         Reviewed by Anders Carlsson.
2837         
2838         initializeLoggingChannelsIfNecessary -> initializeLogChannelsIfNecessary
2839
2840         * DumpRenderTree/TestRunner.cpp:
2841         * DumpRenderTree/mac/DumpRenderTree.mm:
2842         (resetWebViewToConsistentStateBeforeTesting):
2843
2844 2016-07-26  David Kilzer <ddkilzer@apple.com>
2845
2846         Networking process crash due to missing -[WebCoreAuthenticationClientAsChallengeSender performDefaultHandlingForAuthenticationChallenge:] implementation
2847         https://bugs.webkit.org/show_bug.cgi?id=156947
2848         <rdar://problem/23325160>
2849
2850         Reviewed by Alex Christensen.
2851
2852         * DumpRenderTree/TestRunner.cpp:
2853         (TestRunner::TestRunner):
2854         (setRejectsProtectionSpaceAndContinueForAuthenticationChallengesCallback):
2855         * DumpRenderTree/TestRunner.h:
2856         (TestRunner::rejectsProtectionSpaceAndContinueForAuthenticationChallenges):
2857         (TestRunner::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
2858         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2859         (-[ResourceLoadDelegate webView:resource:didReceiveAuthenticationChallenge:fromDataSource:]):
2860         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2861         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2862         (WTR::TestRunner::queueNonLoadingScript):
2863         (WTR::TestRunner::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
2864         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2865         * WebKitTestRunner/TestController.cpp:
2866         (WTR::TestController::didReceiveAuthenticationChallenge):
2867         * WebKitTestRunner/TestController.h:
2868         (WTR::TestController::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
2869         * WebKitTestRunner/TestInvocation.cpp:
2870         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2871         Add TestRunner.setRejectsProtectionSpaceAndContinueForAuthenticationChallenges to use for testing.
2872
2873 2016-07-26  David Kilzer  <ddkilzer@apple.com>
2874
2875         check-for-exit-time-destructors should be usable outside Xcode
2876         <https://webkit.org/b/160195>
2877
2878         Reviewed by Darin Adler.
2879
2880         * Scripts/check-for-exit-time-destructors: Update to parse
2881         -h|--help switch, or to take one argument to a binary to check
2882         for exit time destructors on the command-line.  The clang
2883         compiler will find these at compile-time with the
2884         -Wexit-time-destructors switch, but this script will check for
2885         them after-the-fact.
2886
2887 2016-07-26  Lucas Forschler  <lforschler@apple.com>
2888
2889         Test svn.webkit.org functionality after maintenance.
2890
2891 2016-07-25  Brady Eidson  <beidson@apple.com>
2892
2893         Modern IDB: Make sure IndexedDB works from file:// url documents by default
2894         https://bugs.webkit.org/show_bug.cgi?id=153783
2895
2896         Reviewed by Alex Christensen.
2897
2898         Previously, to grant IndexedDB access to file:// urls for testing purposes, 
2899         we had to call the SPI [WKWebViewConfiguration _setAllowUniversalAccessFromFileURLs:].
2900         
2901         As of https://trac.webkit.org/changeset/203695 this is no longer required.
2902         
2903         Change the relevant API tests to make sure this continues to be no longer required.
2904
2905         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.mm:
2906         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm:
2907         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:
2908         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence.mm:
2909         * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobThenDelete.mm:
2910         * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup.mm:
2911
2912 2016-07-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2913
2914         Media controls should not be displayed for a video until it starts playing
2915         https://bugs.webkit.org/show_bug.cgi?id=160092
2916         <rdar://problem/26986673>
2917
2918         Reviewed by Beth Dakin.
2919
2920         Verify that multiple videos do or don't show the media controller depending on whether videos
2921         are playing. Also tweaks an existing API test (VideoControlsManagerSingleLargeVideo) that was
2922         passing because we were always showing media controls for large videos with audio, even if they
2923         had not played back yet. This change ensures that large videos with audio show media controls
2924         only after they begin to play back, and not by virtue of being large enough for main content.
2925
2926         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2927         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
2928         (TestWebKitAPI::TEST):
2929         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-with-audio.html:
2930         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-with-audio-autoplay.html: Added.
2931         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-with-audio.html: Added.
2932
2933 2016-07-25  Wenson Hsieh  <wenson_hsieh@apple.com>
2934
2935         Media controls on apple.com don't disappear when movie finishes playing
2936         https://bugs.webkit.org/show_bug.cgi?id=160068
2937         <rdar://problem/26668526>
2938
2939         Reviewed by Darin Adler.
2940
2941         Adds new API tests. Please see WebCore ChangeLog for more details.
2942
2943         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2944         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
2945         (-[MediaPlaybackMessageHandler initWithWKWebView:finalMessageString:]):
2946         (-[MediaPlaybackMessageHandler userContentController:didReceiveScriptMessage:]):
2947         (TestWebKitAPI::TEST):
2948         (-[DidPlayMessageHandler initWithWKWebView:]): Deleted.
2949         (-[DidPlayMessageHandler userContentController:didReceiveScriptMessage:]): Deleted.
2950         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-hides-controls-after-seek-to-end.html: Added.
2951         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-seek-after-ending.html: Added.
2952         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-seek-to-beginning-and-play-after-ending.html: Added.
2953
2954 2016-07-25  Philippe Normand  <pnormand@igalia.com>
2955
2956         Unreviewed, fix test-webkitpy after r203674.
2957
2958         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
2959         (GDBCrashLogGeneratorTest.test_generate_crash_log):
2960
2961 2016-07-24  Philippe Normand  <pnormand@igalia.com>
2962
2963         Unreviewed, forgot to commit this file in r203674.
2964
2965         * Scripts/process-linux-coredump: Added.
2966         (main):
2967
2968 2016-07-25  Philippe Normand  <pnormand@igalia.com>
2969
2970         Improve GDB backtrace generation for GTK/EFL
2971         https://bugs.webkit.org/show_bug.cgi?id=128928
2972
2973         Reviewed by Carlos Garcia Campos.
2974
2975         The PID of the crashed process is now correctly supplied to the
2976         crash log reporter. The kernel core_pattern needs to be updated
2977         after this change to something like:
2978
2979         echo "|/home/phil/WebKit/Tools/Scripts/process-linux-coredump /tmp/core-pid_%p.dump" > /proc/sys/kernel/core_pattern
2980
2981         * Scripts/process-linux-coredump: Added.
2982         (main): Minimal python script reading coredump data on stdin and writing it to a file in /tmp/.
2983         * Scripts/webkitpy/port/efl.py:
2984         (EflPort._get_crash_log): Supply path of the process-linux-coredump script.
2985         * Scripts/webkitpy/port/gtk.py:
2986         (GtkPort._get_crash_log): Ditto.
2987         * Scripts/webkitpy/port/linux_get_crash_log.py:
2988         (GDBCrashLogGenerator.__init__): New argument for supplying the path of a coredump processor script.
2989         (GDBCrashLogGenerator.generate_crash_log): Update error message, the core_pattern should now be set to pipe coredumps to a script.
2990         (GDBCrashLogGenerator): Deleted.
2991         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
2992         (GDBCrashLogGeneratorTest.test_generate_crash_log): Update test expectations.
2993         * WebKitTestRunner/TestController.cpp:
2994         (WTR::TestController::networkProcessDidCrash): Supply PID of crash process.
2995         (WTR::TestController::databaseProcessDidCrash): Ditto.
2996         (WTR::TestController::processDidCrash): Ditto.
2997
2998 2016-07-23  Youenn Fablet  <youenn@apple.com>
2999
3000         WPT stash server should be kept running when launching wpt server
3001         https://bugs.webkit.org/show_bug.cgi?id=160052
3002
3003         Reviewed by Sam Weinig.
3004
3005         * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
3006         (main): waiting to read stdin while stash server is started.
3007
3008 2016-07-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3009
3010         Media controls should be displayed for media in media documents
3011         https://bugs.webkit.org/show_bug.cgi?id=160104
3012         <rdar://problem/27438936>
3013
3014         Reviewed by Myles C. Maxfield.
3015
3016         Verifies that even a small video with audio in a media document gets media controls.
3017
3018         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
3019         (TestWebKitAPI::TEST):
3020
3021 2016-07-22  Michael Saboff  <msaboff@apple.com>
3022
3023         REGRESSION(203616): no FTL testing was inadvertently removed
3024         https://bugs.webkit.org/show_bug.cgi?id=160100
3025
3026         Rubber-stamped by Filip Pizlo.
3027
3028         Added runNoFTL back into the set of tests we run on FTL enabled platforms.
3029         Renamed runLayoutTestNoFTL to runLayoutTestDefault.  Restructured the test
3030         logic for the runLayout and runNoisy variants to match the run test logic,
3031         that is we always invoke runXXXDefault and invoke runXXXNoFTL for FTL
3032         enabled platforms.
3033
3034         * Scripts/run-jsc-stress-tests:
3035
3036 2016-07-22  Brady Eidson  <beidson@apple.com>
3037
3038         Removing IndexedDatabases that have stored blobs doesn't remove the blob files.
3039         https://bugs.webkit.org/show_bug.cgi?id=160089
3040
3041         Reviewed by Darin Adler.
3042
3043         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3044         * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobThenDelete.mm: Added.
3045         * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobToBeDeleted.html: Added.
3046
3047 2016-07-22  Konstantin Tokarev  <annulen@yandex.ru>
3048
3049         [GTK] Improved exclusion patterns in make-dist.py manifest.
3050         https://bugs.webkit.org/show_bug.cgi?id=160094
3051
3052         Reviewed by Michael Catanzaro.
3053
3054         * gtk/manifest.txt.in:
3055         Exclude Platform*.cmake files for more ports.
3056         Removed obsolete .gyp and .pro.user patterns.
3057         Exclude 'Configurations' and 'spi' directories.
3058         Exclude CMakeLists.txt.user (Qt Creator IDE).
3059
3060 2016-07-22  Michael Saboff  <msaboff@apple.com>
3061
3062         Don't run FTL related JSC stress tests on non-FTL platforms
3063         https://bugs.webkit.org/show_bug.cgi?id=160033
3064
3065         Reviewed by Mark Lam.
3066
3067         Added check for running tests on platforms that don't enable FTL to not run FTL tests.
3068         Refactored several of the runXXX test methods to always runXXXDefault and made those
3069         runXXXDefault to pass FTL_OPTIONS.  For platforms that don't enable the FTL, FTL_OPTIONS
3070         doesn't cause a problem.
3071
3072         * Scripts/run-jsc-stress-tests:
3073
3074 2016-07-22  Per Arne Vollan  <pvollan@apple.com>
3075
3076         IWebView::mainFrame crashes if called after IWebView::close
3077         https://bugs.webkit.org/show_bug.cgi?id=32868
3078
3079         Reviewed by Brent Fulgham.
3080
3081         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp:
3082         (TestWebKitAPI::TEST_F): Added test.
3083
3084 2016-07-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3085
3086         [GTK] Enable threaded compositor by default
3087         https://bugs.webkit.org/show_bug.cgi?id=160079
3088
3089         Reviewed by Žan Doberšek.
3090
3091         * Scripts/webkitperl/FeatureList.pm:
3092
3093 2016-07-22  Youenn Fablet  <youenn@apple.com>
3094
3095         run-builtins-generator-tests should be able to test WebCore builtins wrapper with more than one file
3096         https://bugs.webkit.org/show_bug.cgi?id=159921
3097
3098         Reviewed by Brian Burg.
3099
3100         Updated builtin generator test runner to generate WebCore wrapper files based on all WebCore valid separate files.
3101
3102         * Scripts/webkitpy/codegen/main.py:
3103         (BuiltinsGeneratorTests.generate_from_js_builtins): Passing a list of builtin files to the script.
3104         (BuiltinsGeneratorTests):
3105         (BuiltinsGeneratorTests.single_builtin_test): Added to handle the case of single builtin generation.
3106         (BuiltinsGeneratorTests.wrappers_builtin_test): Added to handle the case of WebCore wrappers builtin generation.
3107         (BuiltinsGeneratorTests.run_test): Helper routine to run a test in reset mode or normal check mode.
3108         (BuiltinsGeneratorTests.run_tests): Updated to add WebCore wrappers builtin generation test.
3109
3110 2016-07-21  Dan Bernstein  <mitz@apple.com>
3111
3112         [Mac] webkitdirs.pm contains unused code to support outdated OS X and Xcode versions
3113         https://bugs.webkit.org/show_bug.cgi?id=160072
3114
3115         Reviewed by Andy Estes.
3116
3117         * Scripts/webkitdirs.pm:
3118         (readXcodeUserDefault): Changed to take a defaults key rather than a suffix. Removed support
3119           for old Xcode versions.
3120         (determineBaseProductDir): Removed support for old Xcode versions. Updated for the change
3121           to readXcodeUserDefault.
3122         (debugger): Deleted. This was only used for Darwin, where LLDB is now the only supported
3123           debugger.
3124         (determineDebugger): Ditto.
3125         (checkRequiredSystemConfig): Updated to require at least OS X Yosemite v10.10.5 and Xcode
3126           7.0.
3127         (printHelpAndExitForRunAndDebugWebKitAppIfNeeded): Removed --use-gdb and --use-lldb
3128           switches.
3129         (execMacWebKitAppForDebugging): Removed support for GDB.
3130
3131 2016-07-21  Myles C. Maxfield  <mmaxfield@apple.com>
3132
3133         Remove support for deprecated SPI inlineMediaPlaybackRequiresPlaysInlineAttribute
3134         https://bugs.webkit.org/show_bug.cgi?id=160066
3135
3136         Reviewed by Dean Jackson.
3137
3138         * DumpRenderTree/mac/DumpRenderTree.mm:
3139         (setDefaultsToConsistentValuesForTesting): Deleted.
3140         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
3141         (RequiresUserActionForPlaybackTest::SetUp): Deleted.
3142         * WebKitTestRunner/TestController.cpp:
3143         (WTR::TestController::resetPreferencesToConsistentValues): Deleted.
3144         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3145         (WTR::initializeWebViewConfiguration): Deleted.
3146
3147 2016-07-21  Chelsea Pugh  <cpugh@apple.com>
3148
3149         [iOS] Apps using WKWebView will crash if they set the scroll view's delegate and don't nil it out later
3150         https://bugs.webkit.org/show_bug.cgi?id=159980
3151         rdar://problem/27450825
3152
3153         Reviewed by Dan Bernstein.
3154
3155         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3156         * TestWebKitAPI/Tests/ios/WKScrollViewDelegateCrash.mm: Added.
3157         (-[TestDelegateForScrollView dealloc]): Update delegateIsDeallocated to true so that we can tell
3158         when our delegate has hit -dealloc.
3159         (TestWebKitAPI::TEST): Ensure that after an object has been set as the scroll view's delegate,
3160         and has then been deallocated, that the scroll view's delegate is nil and the deallocated delegate
3161         will not be messaged.
3162
3163 2016-07-21  Myles C. Maxfield  <mmaxfield@apple.com>
3164
3165         Follow-up patch to r203520
3166         https://bugs.webkit.org/show_bug.cgi?id=159967
3167         <rdar://problem/26964090>
3168
3169         Unreviewed.
3170
3171         * DumpRenderTree/mac/DumpRenderTree.mm:
3172         (setDefaultsToConsistentValuesForTesting):
3173         * WebKitTestRunner/TestController.cpp:
3174         (WTR::TestController::resetPreferencesToConsistentValues):
3175
3176 2016-07-21  Myles C. Maxfield  <mmaxfield@apple.com>
3177
3178         [iPhone] Playing a video on tudou.com plays only sound, no video
3179         https://bugs.webkit.org/show_bug.cgi?id=159967
3180         <rdar://problem/26964090>
3181
3182         Reviewed by Jon Lee, Jeremy Jones, and Anders Carlsson.
3183
3184         Migrate tests to use new SPI.
3185
3186         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
3187         (RequiresUserActionForPlaybackTest::SetUp):
3188         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3189         (WTR::initializeWebViewConfiguration):
3190
3191 2016-07-21  Csaba Osztrogonác  <ossy@webkit.org>
3192
3193         Clarify testing mode names in run-jsc-stress-tests
3194         https://bugs.webkit.org/show_bug.cgi?id=160021
3195
3196         Reviewed by Mark Lam.
3197
3198         Default should mean really default, not default with disabled FTL, renamed
3199         - runMozillaTestDefault to runMozillaTestNoFTL
3200         - runMozillaTestDefaultFTL to runMozillaTestDefault
3201         - runDefault to runNoFTL
3202         - runDefaultFTL to runDefault
3203         - runLayoutTestDefault to runLayoutTestNoFTL
3204         - runLayoutTestDefaultFTL to runLayoutTestDefault
3205         - runNoisyTestDefault to runNoisyTestNoFTL
3206         - runNoisyTestDefaultFTL to runNoisyTestDefault
3207
3208         * Scripts/run-jsc-stress-tests:
3209
3210 2016-07-21  Yongjun Zhang  <yongjun_zhang@apple.com>
3211
3212         WebBackForwardList's currentIndex could get out of bounds when filtering items.
3213         https://bugs.webkit.org/show_bug.cgi?id=159986
3214
3215         Add a test to verify filtering out 2 items from a 3-item list will set the currentIndex
3216         to 0.
3217
3218         Reviewed by Dan Bernstein.
3219
3220         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3221         * TestWebKitAPI/Tests/WebKit2/WKBackForwardList.mm: Added.
3222         (-[WKBackForwardListTestNavigationDelegate webView:didFinishNavigation:]):
3223         (TEST):
3224
3225 2016-07-21  Carlos Garcia Campos  <cgarcia@igalia.com>
3226
3227         [GTK] Web view background colors don't work in accelerated compositing mode
3228         https://bugs.webkit.org/show_bug.cgi?id=159455
3229
3230         Reviewed by Michael Catanzaro.
3231
3232         Set always RGBA visual to the view widget when setting a background color.
3233
3234         * MiniBrowser/gtk/BrowserWindow.c:
3235         (browser_window_set_background_color):
3236
3237 2016-07-20  Youenn Fablet  <youenn@apple.com>
3238
3239         Bots should run built-ins generator tests
3240         https://bugs.webkit.org/show_bug.cgi?id=159971
3241
3242         Reviewed by Alexey Proskuryakov.
3243
3244         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3245         (RunBuiltinsTests): New step to run built-in generator tests.
3246         (TestFactory.__init__): Adding an additional step for bultin generator tests.
3247         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Rebasing expectations.
3248         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js: Adding additional step for proper display.
3249
3250 2016-07-20  Aakash Jain  <aakash_jain@apple.com>
3251
3252         Revert temporary fix r203417
3253         https://bugs.webkit.org/show_bug.cgi?id=160001
3254
3255         Reviewed by Alexey Proskuryakov.
3256
3257         * EWSTools/start-queue-mac.sh: Revert the temporary fix.
3258
3259 2016-07-20  Aakash Jain  <aakash_jain@apple.com>
3260
3261         REGRESSION(r148588): ews classes might get garbage collected
3262         https://bugs.webkit.org/show_bug.cgi?id=159990
3263
3264         Reviewed by Ryosuke Niwa.
3265
3266         * Scripts/webkitpy/tool/commands/__init__.py: Store the loaded ews classes
3267         in a variable so that they do not get garbage collected.
3268
3269 2016-07-20  Jeremy Jones  <jeremyj@apple.com>
3270
3271         Add API test for layout constraints after exit fullscreen
3272         https://bugs.webkit.org/show_bug.cgi?id=159900
3273
3274         Reviewed by Jon Lee.
3275
3276         Added Fullscreen.LaytoutConstraints API test. 
3277         Tests fix from https://bugs.webkit.org/show_bug.cgi?id=159731
3278
3279         This test compares layout constraints on the web view before and after fullscreen to make sure 
3280         they are preserved.
3281
3282         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenLayoutConstraints.html: Added.
3283         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenLayoutConstraints.mm: Added.
3284         (-[FullscreenStateChangeMessageHandler userContentController:didReceiveScriptMessage:]):
3285         (TestWebKitAPI::TEST):
3286
3287 2016-07-20  Ryan Haddad  <ryanhaddad@apple.com>
3288
3289         Disable two failing API tests.
3290
3291         Unreviewed test gardening.
3292
3293         * TestWebKitAPI/Tests/mac/CandidateTests.mm:
3294         (TestWebKitAPI::TEST):
3295
3296 2016-07-20  Wenson Hsieh  <wenson_hsieh@apple.com>
3297
3298         Unreviewed iOS build fix.
3299
3300         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm: Only import Carbon.h on Mac.
3301
3302 2016-07-20  Wenson Hsieh  <wenson_hsieh@apple.com>
3303
3304         Media controls don't appear when pausing a small autoplaying video
3305         https://bugs.webkit.org/show_bug.cgi?id=159972
3306         <rdar://problem/27180657>
3307
3308         Reviewed by Beth Dakin.
3309
3310         Adds a new test that verifies media controls show up when pausing a small autoplayed video. Also adds mechanisms
3311         for simulating basic user interaction in VideoControlsManager.
3312
3313         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3314         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
3315         (-[WKWebView mouseDownAtPoint:]):
3316         (-[DidPlayMessageHandler userContentController:didReceiveScriptMessage:]):
3317         (-[OnLoadMessageHandler initWithWKWebView:handler:]):
3318         (-[OnLoadMessageHandler userContentController:didReceiveScriptMessage:]):
3319         (TestWebKitAPI::TEST):
3320         * TestWebKitAPI/Tests/WebKit2Cocoa/autoplaying-video-with-audio.html: Added.
3321
3322 2016-07-20  Per Arne Vollan  <pvollan@apple.com>
3323
3324         [Win] MathML fonts are not found.
3325         https://bugs.webkit.org/show_bug.cgi?id=159920
3326
3327         Reviewed by Alex Christensen.
3328
3329         When looking up a font in the registry, use the /v option of the Windows 'reg query' command to query
3330         for a specific registry key value.
3331
3332         * Scripts/webkitdirs.pm:
3333         (fontExists):
3334
3335 2016-07-20  Joseph Pecoraro  <pecoraro@apple.com>
3336
3337         Improve prepare-ChangeLog for @media blocks
3338         https://bugs.webkit.org/show_bug.cgi?id=159907
3339
3340         Reviewed by Timothy Hatcher.
3341
3342         * Scripts/prepare-ChangeLog:
3343         (get_selector_line_ranges_for_css):
3344         Get a range for @media blocks just like a selector.
3345             Start Line = line with '{'
3346             End line = line with '}'
3347             Name = "@media ..."
3348
3349         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests_warning-expected.txt:
3350         Improved error messages for unbalanced portions.
3351
3352         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests-expected.txt:
3353         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests.css:
3354         (.media-query::before):
3355         (@media only screen and (max-width: 980px)):
3356         (.media-query a):
3357         (@media (-webkit-min-device-pixel-ratio: 2)):
3358         (.both a):
3359         (.both b):
3360         (.media-query b):
3361         (.media-query::after):
3362
3363 2016-07-20  Csaba Osztrogonác  <ossy@webkit.org>
3364
3365         Fix expectedFailErrorHandler in run-jsc-stress-tests
3366         https://bugs.webkit.org/show_bug.cgi?id=159811
3367
3368         Reviewed by Yusuke Suzuki.
3369
3370         * Scripts/run-jsc-stress-tests:
3371
3372 2016-07-20  Csaba Osztrogonác  <ossy@webkit.org>
3373
3374         Unreviewed Mac cmake buildfix after r203426. Just for fun.
3375
3376         * TestWebKitAPI/PlatformMac.cmake:
3377
3378 2016-07-19  Filip Pizlo  <fpizlo@apple.com>
3379
3380         The default testing mode should not involve disabling the FTL JIT
3381         https://bugs.webkit.org/show_bug.cgi?id=159929
3382
3383         Rubber stamped by Mark Lam and Saam Barati.
3384         
3385         It used to be the case that most actively maintained ports did not have the FTL JIT enabled.
3386         Heck, for most of the FTL's initial development, it wasn't enabled anywhere. So, testing the
3387         FTL was not the default. You had to enable it with an option.
3388         
3389         For some reason we have kept this arrangement even though the FTL JIT is now the default on
3390         all of the major ports. This has become a serious pain. For example, it's useful to be able
3391         to say that a test should only run in the default config that is representative of what a
3392         normal user would see if they ran JSC. Clearly, this would be a config that does not
3393         explicitly disable the FTL JIT on the command line. However, if you try to specify this then
3394         your test won't run at all if the --ftl-jit option is not passed. That's dangerous!
3395         
3396         So, this change gets rid of all of this logic. I think it's better to get rid of it then to
3397         try to fix it, because:
3398         
3399         - I don't know what the fix would look like. Presumably it would ensure that ports that don't
3400           have the FTL enabled never run any tests that explicitly disable the FTL, since that
3401           doesn't do anything. The code is not really structured to allow this.
3402         
3403         - It benefits a minority of clients. Three build bots run tests in a config that has the FTL
3404           disabled in testing. On the other hand there are already build bots that do FTL tests
3405           despite having the FTL disabled by virtue of being a 32-bit platform. So, maybe rather than
3406           preserving this broken feature, we should create something that (a) acknowledges the fact
3407           that the FTL is the default on those platforms that support it and (b) avoids running
3408           no-ftl tests on precisely those platforms that don't have FTL.
3409         
3410         - To the extent that some bots benefited from disabling FTL tests, they were doing it by
3411           relying on a feature that was never meant to stick around. The FTL JIT is meant to be the
3412           default configuration. Disabling the FTL JIT is the non-default. So, we shouldn't be
3413           pretending that the FTL JIT is not the default just because some bots used that as an
3414           optimization.
3415         
3416         This change allows me to speed up some debug tests and paint some bots green.
3417
3418         * Scripts/run-javascriptcore-tests:
3419         (runJSCStressTests):
3420         * Scripts/run-jsc-stress-tests:
3421
3422 2016-07-19  Alex Christensen  <achristensen@webkit.org>
3423
3424         Fix API test after r203426.
3425         https://bugs.webkit.org/show_bug.cgi?id=159949
3426
3427         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
3428         (TEST):
3429         If there is website data already on disk, the initial count after putting the AppCache data in place will not be exactly 1.
3430         This is no problem.  We want to verify that it is a nonzero number and that it decrements by one when we remove the 1 AppCache data.
3431
3432 2016-07-19  Andy Estes  <aestes@apple.com>
3433
3434         Move WebKitErrorFrameLoadBlockedByContentFilter from WebKitErrors.h to WebKitErrorsPrivate.h
3435         https://bugs.webkit.org/show_bug.cgi?id=159956
3436
3437         Reviewed by Dan Bernstein.
3438
3439         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm: Included WKErrorRef.h.
3440         (-[LoadAlternateNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
3441         Used kWKErrorCodeFrameLoadBlockedByContentFilter instead of WebKitErrorFrameLoadBlockedByContentFilter.
3442         * TestWebKitAPI/Tests/mac/ContentFiltering.mm: Included WebKitErrorsPrivate.h instead of WebKitErrors.h.
3443
3444 2016-07-19  Alex Christensen  <achristensen@webkit.org>
3445
3446         Add regression test for r203392
3447         https://bugs.webkit.org/show_bug.cgi?id=159949
3448
3449         Reviewed by Brady Eidson.
3450
3451         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
3452         (fileSize):
3453         (swizzledBundleIdentifierWebBookmarksD):
3454         (defaultApplicationCacheDirectory):
3455         (TEST):
3456         (swizzledBundleIdentifierMobileSafari): Deleted.
3457         This actually tests that webbookmarksd uses the path quirk in WebsiteDataStore::defaultApplicationCacheDirectory.
3458         I wanted to verify that it uses the same path as MobileSafari, but swizzling out the bundleIdentifier twice caused
3459         problems with the static bools that are set once in RuntimeApplicationChecks.mm.
3460
3461 2016-07-19  Alex Christensen  <achristensen@webkit.org>
3462
3463         Add regression test for r203392
3464         https://bugs.webkit.org/show_bug.cgi?id=159949
3465
3466         Reviewed by Brady Eidson.
3467
3468         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3469         * TestWebKitAPI/Tests/WebKit2Cocoa/ApplicationCache.db: Added.
3470         * TestWebKitAPI/Tests/WebKit2Cocoa/ApplicationCache.db-shm: Added.
3471         * TestWebKitAPI/Tests/WebKit2Cocoa/ApplicationCache.db-wal: Added.
3472         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
3473         (TEST):
3474         (fileSize):
3475         (swizzledBundleIdentifierMobileSafari):
3476         (swizzledBundleIdentifierWebBookmarksD):
3477         (defaultApplicationCacheDirectory):
3478         * TestWebKitAPI/cocoa/InstanceMethodSwizzler.h: Copied from TestWebKitAPI/mac/InstanceMethodSwizzler.h.
3479         * TestWebKitAPI/cocoa/InstanceMethodSwizzler.mm: Copied from TestWebKitAPI/mac/InstanceMethodSwizzler.mm.
3480         * TestWebKitAPI/mac/InstanceMethodSwizzler.h: Removed.
3481         * TestWebKitAPI/mac/InstanceMethodSwizzler.mm: Removed.
3482
3483 2016-07-19  Keith Miller  <keith_miller@apple.com>
3484
3485         Test262 should have a file with the revision and url
3486         https://bugs.webkit.org/show_bug.cgi?id=159937
3487
3488         Reviewed by Mark Lam.
3489
3490         The import script should update the information from
3491         the path to the test262 repository it gets.
3492
3493         * Scripts/import-test262-tests:
3494
3495 2016-07-19  Alexey Proskuryakov  <ap@apple.com>
3496
3497         Temporary workaround for iOS EWS failing after the fix for bug 159539.
3498         To be deleted once the root cause is found and addressed.
3499
3500         * EWSTools/start-queue-mac.sh:
3501
3502 2016-07-19  Frederic Wang  <fwang@igalia.com>
3503
3504         [win] Fixup the register name for STIX Math and Latin Modern Math
3505
3506         Unreviewed follow-up of r203406
3507
3508         * Scripts/webkitdirs.pm:
3509         (checkInstalledTools):
3510
3511 2016-07-19  Frederic Wang  <fwang@igalia.com>
3512
3513         [win] Update the list of MathML fonts
3514         https://bugs.webkit.org/show_bug.cgi?id=156838
3515
3516         The set of recommended math fonts is now described at
3517         https://trac.webkit.org/wiki/MathML/Fonts
3518         We update the Perl script to use the latest list of fonts.
3519
3520         Reviewed by Brent Fulgham.
3521
3522         * Scripts/webkitdirs.pm:
3523         (checkInstalledTools):
3524
3525 2016-07-19  Per Arne Vollan  <pvollan@apple.com>
3526
3527         [Win] The test fast/scrolling/overflow-scroll-past-max.html is timing out.
3528         https://bugs.webkit.org/show_bug.cgi?id=159342
3529
3530         Reviewed by Darin Adler.
3531
3532         Implement required functions in event sender.
3533
3534         * DumpRenderTree/PlatformWin.cmake:
3535         * DumpRenderTree/win/EventSender.cpp:
3536         (monitorWheelEvents): Added.
3537         (callAfterScrollingCompletes): Added.
3538
3539 2016-07-19  Youenn Fablet  <youenn@apple.com>
3540
3541         Add new aliases to http test server
3542         https://bugs.webkit.org/show_bug.cgi?id=159878
3543
3544         Reviewed by Darin Adler.
3545
3546         Adding testharness.css, testharness.js and testharnessreport.js new aliases to http test servers.
3547         Adding explicitly these links to perl script.
3548         Extracting default alias in an aliases.json file.
3549         Reading that file from python scripts to initialize aliases from that file.
3550
3551         Python script changes covered by unit tests and changed layout test.
3552
3553         * Scripts/webkitperl/httpd.pm:
3554         (getDefaultConfigForTestDirectory): Adding 3 new aliases
3555         * Scripts/webkitpy/layout_tests/servers/aliases.json: Added.
3556         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
3557         (LayoutTestApacheHttpd.__init__): Setting upper class tests_dir member if needed and according constructor parameter.
3558         Adding -c directives for each alias.
3559         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
3560         (TestLayoutTestApacheHttpd.test_start_cmd): Adding aliases.json mock-up file.
3561         * Scripts/webkitpy/layout_tests/servers/http_server.py:
3562         (Lighttpd.__init__): Setting upper class tests_dir member if needed and according constructor parameter.
3563         Adding alias directive for each alias.
3564         (Lighttpd._prepare_config):
3565         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
3566         (HttpServerBase.__init__): Adding tests_dir member with a default value being layout tests directory.
3567         (HttpServerBase.aliases): Computing of alias from the json file, paths to the real files being relative to
3568         layout tests directory.
3569         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
3570         (TestHttpServer.test_start_cmd): Adding aliases.json mock-up file and updating test expectation.
3571         (TestHttpServer.test_win32_start_and_stop): Adding aliases.json mock-up file.
3572
3573 2016-07-18  Aakash Jain  <aakash_jain@apple.com>
3574
3575         EWS console logs doesn't go to log file
3576         https://bugs.webkit.org/show_bug.cgi?id=159539
3577         <rdar://problem/24464570>
3578
3579         Reviewed by David Kilzer.
3580
3581         * Scripts/webkitpy/common/system/logutils.py:
3582         (configure_logger_to_log_to_file): Added method to configure the logger to log to file.
3583         (FileSystemHandler): Added class which uses logging.FileHandler as base class and supports writing
3584         to filesystem. It also supports passing MockFilesystem.
3585         (FileSystemHandler.__init__): Initialize the class and calls base class __init__.
3586         (FileSystemHandler._open): Overrides the base class _open method to use filesystem object.
3587         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3588         (AbstractEarlyWarningSystemTest.test_failing_tests_message): Added MockHost() parameter.
3589         (_test_ews): Same.
3590         * Scripts/webkitpy/tool/commands/queues.py:
3591         (AbstractQueue.begin_work_queue): Configure the logger to log to file.
3592         (AbstractQueue._log_directory): Using filesystem object instead of os.
3593         (AbstractQueue.queue_log_path): Same.
3594         (AbstractQueue.__init__): Passed host parameter.
3595         (PatchProcessingQueue.__init__): Same.
3596         (CommitQueue.__init__): Same.
3597         (AbstractReviewQueue.__init__): Same.
3598         (StyleQueue.__init__): Same.
3599         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3600         (TestCommitQueue): Passed MockHost() as host.
3601         (TestCommitQueue.__init__): Same.
3602         (TestQueue.__init__): Same.
3603         (TestReviewQueue.__init__): Same.
3604         (TestFeederQueue.__init__): Same.
3605         (AbstractPatchQueueTest.test_next_patch): Same.
3606         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Same.
3607         (test_commit_queue_failure): Same.
3608         (MockCommitQueueTask.results_from_patch_test_run): Same.
3609         (test_rollout_lands): Same.
3610         (test_non_valid_patch): Same.
3611         (test_auto_retry): Same.
3612         (test_style_queue_with_watch_list_exception): Same.
3613
3614 2016-07-02  Filip Pizlo  <fpizlo@apple.com>
3615
3616         WTF::Lock should be fair eventually
3617         https://bugs.webkit.org/show_bug.cgi?id=159384
3618
3619         Reviewed by Geoffrey Garen.
3620
3621         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
3622
3623 2016-07-17  Sam Weinig  <sam@webkit.org>
3624
3625         [WebKit API] Add SPI to track multiple navigations caused by a single user gesture
3626         <rdar://problem/26554137>
3627         https://bugs.webkit.org/show_bug.cgi?id=159856
3628
3629         Reviewed by Dan Bernstein.
3630
3631         * MiniBrowser/mac/WK2BrowserWindowController.m:
3632         (-[WK2BrowserWindowController webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
3633         Add basic window.open implementation.
3634
3635         (-[WK2BrowserWindowController webView:decidePolicyForNavigationAction:decisionHandler:]):
3636         Add basic navigation policy implementation which implements a rule where a user gesture is only allowed
3637         to open a single non-web URL, all others are dropped.
3638
3639         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3640         * TestWebKitAPI/Tests/WebKit2Cocoa/UserInitiatedActionInNavigationAction.mm: Added.
3641         * TestWebKitAPI/Tests/WebKit2Cocoa/open-multiple-external-url.html: Added.
3642         Add API for the new SPI.
3643
3644 2016-07-17  Yusuke Suzuki  <utatane.tea@gmail.com>
3645
3646         [JSC] Enable test262 module tests
3647         https://bugs.webkit.org/show_bug.cgi?id=159854
3648
3649         Reviewed by Saam Barati.
3650
3651         Use --module-file instead.
3652
3653         * Scripts/run-jsc-stress-tests:
3654
3655 2016-07-16  Chris Dumez  <cdumez@apple.com>
3656
3657         Unreviewed, rolling out r203318.
3658
3659         Regressed most JS Benchmarks on MacBook Air by ~2% (7% on
3660         SunSpider)
3661
3662         Reverted changeset:
3663
3664         "[JSC] Change some parameters based on a random search"
3665         https://bugs.webkit.org/show_bug.cgi?id=158514
3666         http://trac.webkit.org/changeset/203318
3667
3668 2016-07-16  Chris Dumez  <cdumez@apple.com>
3669
3670         Add move constructor / assignment operator to ListHashSet
3671         https://bugs.webkit.org/show_bug.cgi?id=159837
3672
3673         Reviewed by Darin Adler.
3674
3675         Add API tests.
3676
3677         * TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
3678         (TestWebKitAPI::TEST):
3679
3680 2016-07-15  Benjamin Poulain  <bpoulain@apple.com>
3681
3682         [JSC] Change some parameters based on a random search
3683         https://bugs.webkit.org/show_bug.cgi?id=158514
3684
3685         Reviewed by Saam Barati.
3686
3687         * Scripts/run-jsc-stress-tests:
3688
3689 2016-07-15  Jon Davis  <jond@apple.com>
3690
3691         Changed the start page URL for WebKit Nightly builds.
3692         https://bugs.webkit.org/show_bug.cgi?id=159816
3693
3694         Reviewed by Timothy Hatcher.
3695
3696         * WebKitLauncher/start.html:
3697
3698 2016-07-15  Per Arne Vollan  <pvollan@apple.com>
3699