Tools/ChangeLog

   1 2011-01-11  Peter Varga  <pvarga@webkit.org>
   2
   3         Unreviewed.
   4
   5         Add myself to committers' list.
   6
   7         * Scripts/webkitpy/common/config/committers.py:
   8
   9 2011-01-11  Eric Seidel  <eric@webkit.org>
  10
  11         Reviewed by Adam Barth.
  12
  13         commit-queue should know how to upload archived results (for test flakes or general failures)
  14         https://bugs.webkit.org/show_bug.cgi?id=52048
  15
  16         Now the queue will always upload results.  Either the entire zip, or just
  17         the diffs.txt in the case of text failures.
  18
  19         This should make understanding flakes much easier, and paves the way
  20         for having the EWS run layout tests (and upload failures).
  21
  22         In order to upload .zip files I had to teach bugzilla.py to autodetect
  23         mime types from the filename.  Since mimetypes.py doesn't include a mapping
  24         for .patch files, I have it add one before calling guess_type.
  25
  26         We may find that always uploading the whole zip instead of just the -diffs.txt
  27         file is preferable, but for now I'm keeping the old behavior because it makes
  28         quickly understanding text failures easy.
  29
  30         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
  31         * Scripts/webkitpy/common/system/workspace.py: Added.
  32         * Scripts/webkitpy/common/system/workspace_unittest.py: Added.
  33         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
  34         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
  35         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
  36         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
  37         * Scripts/webkitpy/tool/commands/queues.py:
  38         * Scripts/webkitpy/tool/commands/queues_unittest.py:
  39
  40 2011-01-10  Sheriff Bot  <webkit.review.bot@gmail.com>
  41
  42         Unreviewed, rolling out r75464.
  43         http://trac.webkit.org/changeset/75464
  44         https://bugs.webkit.org/show_bug.cgi?id=52193
  45
  46         Followup rollout for 75474 (Requested by Ossy on #webkit).
  47
  48         * MiniBrowser/mac/BrowserWindowController.m:
  49         (-[BrowserWindowController awakeFromNib]):
  50         * MiniBrowser/win/BrowserView.cpp:
  51         (BrowserView::create):
  52         * WebKitTestRunner/TestController.cpp:
  53         (WTR::createOtherPage):
  54         (WTR::TestController::initialize):
  55
  56 2011-01-10  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
  57
  58         Reviewed by Csaba Osztrogonác.
  59
  60         [Qt] Baseline qt_minimal configuration
  61         https://bugs.webkit.org/show_bug.cgi?id=51313
  62
  63         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
  64         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): Add
  65         QT_NO_UNDOSTACK guard.
  66
  67         * QtTestBrowser/launcherwindow.cpp:
  68         (LauncherWindow::createChrome): Add QT_NO_SHORTCUT and QT_NO_PRINTER
  69         guards.
  70         (LauncherWindow::applyZoom): Add QT_NO_ANIMATION guard.
  71         (LauncherWindow::screenshot): Add QT_NO_FILEDIALOG guard.
  72         (LauncherWindow::selectElements): Add QT_NO_INPUTDIALOG guard.
  73         (LauncherWindow::showUserAgentDialog): Add QT_NO_COMBOBOX guard.
  74
  75         * QtTestBrowser/launcherwindow.h:
  76         * QtTestBrowser/locationedit.cpp: Add QT_NO_INPUTDIALOG guard.
  77         * QtTestBrowser/locationedit.h: Ditto.
  78
  79         * QtTestBrowser/mainwindow.cpp:
  80         (MainWindow::buildUI): Add QT_NO_INPUTDIALOG, QT_NO_SHORTCUT and
  81         QT_NO_UNDOSTACK guards.
  82         (MainWindow::setAddressUrl): Add QT_NO_INPUTDIALOG guard.
  83         (MainWindow::changeLocation): Ditto.
  84         (MainWindow::openFile): Add QT_NO_FILEDIALOG guard.
  85         (MainWindow::openLocation): Add QT_NO_INPUTDIALOG guard.
  86
  87         * QtTestBrowser/webpage.cpp:
  88         (WebPage::openUrlInDefaultBrowser): Add QT_NO_DESKTOPSERVICES guard.
  89         (WebPage::authenticationRequired): Add QT_NO_LINEEDIT guard.
  90
  91         * QtTestBrowser/webview.cpp:
  92         (WebViewGraphicsBased::animatedFlip): Add QT_NO_ANIMATION guard.
  93         (WebViewGraphicsBased::animatedYFlip): Ditto.
  94
  95 2011-01-10  Sam Weinig  <sam@webkit.org>
  96
  97         Fix build.
  98
  99         * MiniBrowser/mac/BrowserWindowController.m:
 100         (-[BrowserWindowController awakeFromNib]):
 101         * MiniBrowser/win/BrowserView.cpp:
 102         (BrowserView::create):
 103         * WebKitTestRunner/TestController.cpp:
 104         (WTR::createOtherPage):
 105         (WTR::TestController::initialize):
 106
 107 2011-01-10  Eric Seidel  <eric@webkit.org>
 108
 109         Reviewed by Ojan Vafai.
 110
 111         style-queue messages are way too long for big patches
 112         https://bugs.webkit.org/show_bug.cgi?id=52161
 113
 114         We definitely could build much fancier list-to-string-with-limit functions
 115         but this should be sufficient for our needs at the moment.
 116
 117         * Scripts/webkitpy/common/system/executive.py:
 118         * Scripts/webkitpy/common/system/executive_unittest.py:
 119
 120 2011-01-10  Tony Chang  <tony@chromium.org>
 121
 122         Unreviewed, rolling out r75398.
 123         http://trac.webkit.org/changeset/75398
 124         https://bugs.webkit.org/show_bug.cgi?id=52008
 125
 126         Some layout tests are crashing on Chromium Win.
 127
 128         * DumpRenderTree/chromium/WebViewHost.cpp:
 129         (WebViewHost::updatePaintRect):
 130         * DumpRenderTree/chromium/WebViewHost.h:
 131
 132 2011-01-10  Adam Roben  <aroben@apple.com>
 133
 134         Roll out r75392
 135
 136         It isn't needed now that r75289 has been rolled out.
 137
 138         * Scripts/run-javascriptcore-tests:
 139
 140 2011-01-10  Maciej Stachowiak  <mjs@apple.com>
 141
 142         Reviewed by Anders Carlsson.
 143
 144         WebKitTestRunner uses crazy amounts of CPU, making layout tests slow and flaky
 145         https://bugs.webkit.org/show_bug.cgi?id=52160
 146
 147         * WebKitTestRunner/mac/TestControllerMac.mm:
 148         (WTR::TestController::platformRunUntil): Instead of busy-looping, wait for the timeout.
 149         Anything that can make runUntil() conditions turn true will happen on a run loop cycle
 150         anyway.
 151
 152 2011-01-10  Tony Chang  <tony@chromium.org>
 153
 154         Reviewed by Mihai Parparita.
 155
 156         [chromium] fix for animated gif layout tests
 157         https://bugs.webkit.org/show_bug.cgi?id=52008
 158
 159         * DumpRenderTree/chromium/WebViewHost.cpp: Schedule a paint when we update the paint rect
 160             to trigger gif animations.
 161         (WebViewHostPaintTask::WebViewHostPaintTask):
 162         (WebViewHostPaintTask::runIfValid):
 163         (WebViewHost::updatePaintRect):
 164         * DumpRenderTree/chromium/WebViewHost.h:
 165         (WebViewHost::taskList):
 166
 167 2011-01-10  Alejandro G. Castro  <alex@igalia.com>
 168
 169         Reviewed by Xan Lopez.
 170
 171         [GTK] Fix gtk2 compilation for master
 172         https://bugs.webkit.org/show_bug.cgi?id=51885
 173
 174         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
 175         (createBitmapContextFromWebView): Replaced the old
 176         gdk_drawable_get_size with gdk_pixmap_get_size.
 177
 178 2011-01-10  Patrick Gansterer  <paroga@webkit.org>
 179
 180         Reviewed by Laszlo Gombos.
 181
 182         [WINCE] Reenable NPAPI after r75203
 183         https://bugs.webkit.org/show_bug.cgi?id=52109
 184
 185         Remove the !isWinCE() check for ENABLE_NETSCAPE_PLUGIN_API and replace
 186         it with !isEfl(), because EFL port does not support NPAPI (yet).
 187
 188         * Scripts/build-webkit:
 189
 190 2011-01-10  Adam Roben  <aroben@apple.com>
 191
 192         Skip some asserting JS tests
 193
 194         See <http://webkit.org/b/52156>.
 195
 196         * Scripts/run-javascriptcore-tests:
 197
 198 2011-01-10  Martin Robinson  <mrobinson@igalia.com>
 199
 200         Reviewed by Xan Lopez.
 201
 202         [GTK] build-webkit disable Blob support via arguments passed to automake
 203         https://bugs.webkit.org/show_bug.cgi?id=52097
 204
 205         * Scripts/build-webkit: Enable Blob support when building WebKitGTK+ via
 206         build-webkit.
 207
 208 2011-01-10  Adam Roben  <aroben@apple.com>
 209
 210         Use the same name and description for TestNetscapePlugin on Windows and
 211         Mac
 212
 213         Fixes <http://webkit.org/b/52151>
 214         fast/frames/iframe-reparenting-plugins.html fails on Windows
 215
 216         Reviewed by Steve Falkenburg.
 217
 218         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Copied
 219         the name and description from Mac's Info.plist.
 220
 221 2011-01-10  Siddharth Mathur <siddharth.mathur@nokia.com>
 222
 223         Reviewed by Laszlo Gombos.
 224
 225         [Qt][WK2] Guard gcc-specific syntax
 226
 227         Non-gcc based compliers choke on the "-include"
 228         syntax for preinclude, place guard around it.
 229
 230         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
 231         * WebKitTestRunner/qt/WebKitTestRunner.pro:
 232
 233 2011-01-10  Andreas Kling  <kling@webkit.org>
 234
 235         Reviewed by Simon Hausmann.
 236
 237         [Qt] [WK2] MiniBrowser does not load pages opened in new windows
 238         https://bugs.webkit.org/show_bug.cgi?id=52111
 239
 240         When getting a createNewPage() callback from QWKPage, create the
 241         new page with the same QWKContext as the page that is passed to
 242         the callback.
 243
 244         * MiniBrowser/qt/BrowserView.h:
 245         * MiniBrowser/qt/BrowserWindow.cpp:
 246         (newPageFunction):
 247         (BrowserWindow::BrowserWindow):
 248         * MiniBrowser/qt/BrowserWindow.h:
 249
 250 2011-01-10  Andreas Kling  <kling@webkit.org>
 251
 252         Reviewed by Kenneth Rohde Christiansen.
 253
 254         [Qt] MiniBrowser: Remove superfluous createNewPage() callback
 255
 256         BrowserView set its own useless createNewPage() callback on QWKPage.
 257         This was immediately overridden by BrowserWindow anyway, so remove
 258         the BrowserView one.
 259
 260         * MiniBrowser/qt/BrowserView.cpp:
 261         (BrowserView::BrowserView):
 262
 263 2011-01-10  John Knottenbelt  <jknotten@chromium.org>
 264
 265         Reviewed by Jeremy Orlow.
 266
 267         [Chromium] Remove non-client-based Geolocation code
 268         https://bugs.webkit.org/show_bug.cgi?id=50921
 269
 270         * DumpRenderTree/chromium/LayoutTestController.cpp:
 271         (LayoutTestController::setGeolocationPermission):
 272         (LayoutTestController::setMockGeolocationPosition):
 273         (LayoutTestController::setMockGeolocationError):
 274         * DumpRenderTree/chromium/WebViewHost.cpp:
 275         (WebViewHost::geolocationClientMock):
 276         (WebViewHost::reset):
 277         * DumpRenderTree/chromium/WebViewHost.h:
 278
 279 2011-01-10  Eric Seidel  <eric@webkit.org>
 280
 281         Reviewed by Adam Barth.
 282
 283         Commit bot tried to land r? cq+ patch
 284         https://bugs.webkit.org/show_bug.cgi?id=36638
 285
 286         It should now be possible to post a patch with r? and cq+ and the
 287         commit-queue will correctly wait for the r+ before attempting to land the patch.
 288         (This was a feature requested by several users.)
 289
 290         One caveat: We don't actually reject r-, cq+ patches from the queue
 291         (we just ignore them), but I think that's OK for now.
 292
 293         I also noticed that setting r- once a commit-queue node had grabbed
 294         a patch would not properly cancel the landing.  That's fixed and
 295         tested in this patch.
 296
 297         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
 298         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
 299         * Scripts/webkitpy/tool/bot/feeders.py:
 300         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
 301
 302 2011-01-08  Benjamin Poulain  <benjamin.poulain@nokia.com>
 303
 304         Reviewed by Kenneth Rohde Christiansen.
 305
 306         [Qt] QtWebKit crashes when using XMLHttpRequest from the unload event
 307         https://bugs.webkit.org/show_bug.cgi?id=51934
 308
 309         When accessing the network from the destructor of QWebPage, the network access manager
 310         was already deleted because the object WebPage was already destructed.
 311
 312         This solve the problem by linking the lifetime of the network access manager to WebPage's QObject.
 313         The object is now destructed in the destructor of QObject.
 314
 315         * QtTestBrowser/webpage.cpp:
 316         (WebPage::WebPage):
 317         (WebPage::setQnamThreaded):
 318         * QtTestBrowser/webpage.h:
 319         (QtNAMThread::QtNAMThread):
 320
 321 2011-01-08  Eric Seidel  <eric@webkit.org>
 322
 323         Reviewed by Ojan Vafai.
 324
 325         test_failures.py should not mention TestShell (long live DumpRenderTree!)
 326         https://bugs.webkit.org/show_bug.cgi?id=52067
 327
 328         I ran test-webkitpy, but didn't bother adding a unit test for this string change.
 329         https://bugs.webkit.org/show_bug.cgi?id=51138#c3 is an example of why this is needed.
 330
 331         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
 332
 333 2011-01-08  Eric Seidel  <eric@webkit.org>
 334
 335         Reviewed by Mihai Parparita.
 336
 337         commit-queue hangs when the ChangeLog diff is bad
 338         https://bugs.webkit.org/show_bug.cgi?id=52072
 339
 340         * Scripts/webkitpy/tool/steps/validatechangelogs.py:
 341         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
 342
 343 2011-01-08  Adam Barth  <abarth@webkit.org>
 344
 345         Teach svn-apply how to re-write WebCore to Source/WebCore.
 346
 347         * Scripts/VCSUtils.pm:
 348
 349 2011-01-07  Adam Barth  <abarth@webkit.org>
 350
 351         Rubber-stamped by Eric Seidel.
 352
 353         Move WebCore to Source
 354         https://bugs.webkit.org/show_bug.cgi?id=52050
 355
 356         Update the tools to understand WebCore's new location.
 357
 358         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
 359         * DumpRenderTree/wscript:
 360         * GNUmakefile.am:
 361         * Scripts/build-webkit:
 362         * Scripts/do-file-rename:
 363         * Scripts/do-webcore-rename:
 364         * Scripts/generate-qt-inspector-resource:
 365         * Scripts/prepare-ChangeLog:
 366         * Scripts/run-bindings-tests:
 367         * Scripts/update-iexploder-cssproperties:
 368         * Scripts/update-sources-list.py:
 369         * Scripts/update-webkit-localizable-strings:
 370         * Scripts/webkitdirs.pm:
 371         * Scripts/webkitpy/common/config/build.py:
 372         * Scripts/webkitpy/common/config/build_unittest.py:
 373         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
 374         * Scripts/webkitpy/style/checker.py:
 375         * Scripts/webkitpy/style/checker_unittest.py:
 376         * WebKitTestRunner/DerivedSources.pro:
 377         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
 378         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh:
 379         * wx/browser/wscript:
 380         * wx/build/settings.py:
 381
 382 2011-01-07  Maciej Stachowiak  <mjs@apple.com>
 383
 384         Reviewed by Sam Weinig.
 385
 386         Make WebKitTestRunner rest between loads more robust to avoid test crashes
 387         https://bugs.webkit.org/show_bug.cgi?id=52086
 388
 389         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
 390         (WTR::InjectedBundle::didReceiveMessage):
 391         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
 392         (WTR::LayoutTestController::notifyDone):
 393         * WebKitTestRunner/TestController.cpp:
 394         (WTR::TestController::resetStateToConsistentValues):
 395         (WTR::TestController::run):
 396
 397 2011-01-07  James Robinson  <jamesr@chromium.org>
 398
 399         Revert "Implement mozilla's animationTime property"
 400         https://bugs.webkit.org/show_bug.cgi?id=51952
 401
 402         This approach isn't quite right.
 403
 404         * DumpRenderTree/chromium/WebViewHost.cpp:
 405         (WebViewHost::paintInvalidatedRegion):
 406
 407 2011-01-07  Adam Roben  <aroben@apple.com>
 408
 409         Build master fix
 410
 411         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
 412         (RunWebKitTests.start): Don't try to concatenate a list and a string.
 413
 414 2011-01-07  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>
 415
 416         Reviewed by Csaba Osztrogonác.
 417
 418         run-qtwebkit-tests should be able to kill a testsuite.
 419
 420         Add new option in the script that can setup a timeout for a test.
 421         If the test execution takes more then specified time then the test
 422         would be terminated.
 423
 424         [Qt] run-qtwebkit-tests needs timeout
 425         https://bugs.webkit.org/show_bug.cgi?id=51894
 426
 427         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
 428         * Scripts/run-qtwebkit-tests:
 429
 430 2011-01-07  Csaba Osztrogonác  <ossy@webkit.org>
 431
 432         Unreviewed fix after r75233.
 433
 434         Based on idea from Eric Seidel.
 435
 436         Add remote zip file handling to webkitpy.
 437         https://bugs.webkit.org/show_bug.cgi?id=50901
 438
 439         * Scripts/webkitpy/common/system/fileset.py: Make python 2.5 happy.
 440
 441 2011-01-07  Shane Stephens  <shanestephens@google.com>
 442
 443         Reviewed by Eric Seidel.
 444
 445         svn-apply: should support git binary delta diffs
 446         https://bugs.webkit.org/show_bug.cgi?id=38864
 447
 448         * Scripts/VCSUtils.pm:
 449         * Scripts/svn-apply:
 450
 451 2011-01-06  Julie Parent  <jparent@chromium.org>
 452
 453         Reviewed by Eric Seidel.
 454
 455         Test Result Server not removing old results.
 456         https://bugs.webkit.org/show_bug.cgi?id=52012
 457
 458         * TestResultServer/model/jsonresults.py:
 459         Fix off-by-one: Truncate if >= num_runs, not just >.
 460         * TestResultServer/model/jsonresults_unittest.py:
 461         Add unit test to test that merging in a new result with the same value
 462         as the last result causes previous result to fall off.
 463
 464 2011-01-06  James Kozianski  <koz@chromium.org>
 465
 466         Reviewed by Mihai Parparita.
 467
 468         Add classes to provide a consistent interface to a set of files.
 469         https://bugs.webkit.org/show_bug.cgi?id=50901
 470
 471         These classes allow us to write code that is agnostic to whether a
 472         particular set of files resides in a local directory or in a zip file
 473         on a remote machine.
 474
 475         * Scripts/webkitpy/common/system/directoryfileset.py: Added.
 476         * Scripts/webkitpy/common/system/directoryfileset_unittest.py: Added.
 477         * Scripts/webkitpy/common/system/fileset.py: Added.
 478         * Scripts/webkitpy/common/system/filesystem.py:
 479         * Scripts/webkitpy/common/system/filesystem_mock.py:
 480         * Scripts/webkitpy/common/system/zipfileset.py: Added.
 481         * Scripts/webkitpy/common/system/zipfileset_unittest.py: Added.
 482
 483 2011-01-06  Eric Seidel  <eric@webkit.org>
 484
 485         Reviewed by Adam Barth.
 486
 487         NetworkTransaction should log the url it is retrying
 488         https://bugs.webkit.org/show_bug.cgi?id=52043
 489
 490         * Scripts/webkitpy/common/net/networktransaction.py:
 491         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
 492
 493 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
 494
 495         Windows build fix.
 496         Import os before using it.
 497
 498         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
 499
 500 2011-01-06  Eric Seidel  <eric@webkit.org>
 501
 502         Reviewed by Adam Barth.
 503
 504         StyleQueue fails to report errors when patches have many files
 505         https://bugs.webkit.org/show_bug.cgi?id=52042
 506
 507         This is one of at least two errors preventing style error reporting at the moment.
 508         When we moved to passing the list of files to check explicitly,
 509         we started to exceed the 500 character TEXT field limit for our AppEngine model object.
 510         We could change the type of the QueueStatus.message type, or we could
 511         just teach statusserver.py how to clamp values (and warn when it does).
 512         I chose the latter path.
 513
 514         * Scripts/webkitpy/common/net/statusserver.py:
 515
 516 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
 517
 518         Reviewed by Stephanie Lewis.
 519
 520         Fix syntax error in script.
 521
 522         Windows bots need to archive/unarchive builds to/from configuration-specific directories
 523         https://bugs.webkit.org/show_bug.cgi?id=51996
 524
 525         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
 526
 527 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
 528
 529         Unreviewed, fixing WinCE build after r75196.
 530
 531         WinCE port does not (yet) support NPAPI.
 532
 533         * Scripts/build-webkit:
 534
 535 2011-01-06  Xan Lopez  <xlopez@igalia.com>
 536
 537         Reviewed by Darin Adler.
 538
 539         File::Spec->rel2abs in sunspider-compare-results mangles parameters
 540         https://bugs.webkit.org/show_bug.cgi?id=52015
 541
 542         * Scripts/sunspider-compare-results: call rel2abs on our arguments
 543         after the platform has been detected, otherwise the script will
 544         mangle things like '--gtk' into '/a/path/--gtk', breaking the
 545         detection.
 546
 547 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
 548
 549         Reviewed by Eric Seidel.
 550
 551         Add ENABLE_NETSCAPE_PLUGIN_API, ENABLE_ORIENTATION_EVENTS and ENABLE_TOUCH_EVENTS flags to build-webkit
 552         https://bugs.webkit.org/show_bug.cgi?id=51346
 553
 554         * Scripts/build-webkit:
 555
 556 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
 557
 558         Reviewed by Adam Roben.
 559
 560         Windows bots need to archive/unarchive builds to/from configuration-specific directories
 561         https://bugs.webkit.org/show_bug.cgi?id=51996
 562
 563         After the configuration directory change, we were archiving the incorrect directory for
 564         build product, so we were running tests on the wrong binaries.
 565
 566         This change archives the correct directory, and also unarchives it into a configuration-
 567         specific directory.
 568
 569         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Use a configuration-specific directory on Windows.
 570         * BuildSlaveSupport/built-product-archive: Unarchive/archive to/from proper directory.
 571
 572 2011-01-06  Eric Seidel  <eric@webkit.org>
 573
 574         Reviewed by Mihai Parparita.
 575
 576         commit-queue mentions "Text diff mismatch" 4 times instead of once per failure
 577         https://bugs.webkit.org/show_bug.cgi?id=52002
 578
 579         See an example of this here:
 580         https://bugs.webkit.org/show_bug.cgi?id=51314#c2
 581
 582         It's due to the fact that we pass around TestFailure() instance
 583         objects and yet expect them to all compare to be the same.
 584
 585         This is bad.  We should either have shared instances of these values
 586         or we should just pass around the class names.  There are already hacks
 587         in place to make TestFailure objects pass equality tests, I just added
 588         a __hash__ implementation so they can be used in sets as expected.
 589
 590         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
 591         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
 592
 593 2011-01-06  Evan Martin  <evan@chromium.org>
 594
 595         Reviewed by Tony Chang.
 596
 597         [gdb] handle inaccessible memory and UChar*
 598         https://bugs.webkit.org/show_bug.cgi?id=52003
 599
 600         To pretty-print a UChar*, we just grope around in the memory
 601         looking for a terminating NUL.  We need to handle the exception
 602         that can occur when we poke into an invalid location.
 603
 604         Additionally, the logic for choosing which pretty-printer would
 605         early return before hitting the point where we'd use the UChar*
 606         printer.  (Did this ever work?  How did it regress?)
 607
 608         * gdb/webkit.py:
 609
 610 2011-01-05  Brian Weinstein  <bweinstein@apple.com>
 611
 612         Reviewed by Ada Chan.
 613
 614         WebKit2: Should be able to call into injected bundle to ask if we should allow resource loads
 615         https://bugs.webkit.org/show_bug.cgi?id=51969
 616
 617         Add shouldLoadResourceForFrame to WTR::InjectedBundlePage.
 618
 619         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
 620         (WTR::InjectedBundlePage::InjectedBundlePage):
 621         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Stub implementation.
 622         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
 623
 624 2011-01-06  James Robinson  <jamesr@chromium.org>
 625
 626         Reviewed by Simon Fraser.
 627
 628         Implement mozilla's animationTime property
 629         https://bugs.webkit.org/show_bug.cgi?id=51952
 630
 631         Chromium DRT support for webkitAnimationTime.
 632
 633         * DumpRenderTree/chromium/WebViewHost.cpp:
 634         (WebViewHost::paintInvalidatedRegion):
 635
 636 2011-01-06  Julie Parent  <jparent@chromium.org>
 637
 638         Reviewed by Tony Chang.
 639
 640         Test Result Server always truncates number of results to JSON_RESULTS_MAX_BUILDS
 641         https://bugs.webkit.org/show_bug.cgi?id=51217
 642
 643         * TestResultServer/model/jsonresults.py:
 644         Pass num_runs through to _remove_items_over_max_number_of_builds, and use the value.
 645         Adds missing documentation.
 646         * TestResultServer/model/jsonresults_unittest.py:
 647         Add unit test to test that truncation happens at smaller value than JSON_RESULTS_MAX_BUILDS.
 648         Update test_merge to take a number of builds to truncate at.
 649
 650 2011-01-06  Adam Barth  <abarth@webkit.org>
 651
 652         Reviewed by Eric Seidel.
 653
 654         The EWS should log outside of the working directory
 655         https://bugs.webkit.org/show_bug.cgi?id=51986
 656
 657         This patch prepare us for using git clean -x -d -f in the EWS wrapper
 658         script, which will actually clean the working copy back to a pristine
 659         state instead of leaving untracked directories and ignored files.
 660
 661         * Scripts/webkitpy/tool/commands/queues.py:
 662         * Scripts/webkitpy/tool/commands/queues_unittest.py:
 663
 664 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
 665
 666         Windows build fix.
 667         Back out attempted change to built-product-archive.
 668
 669         * BuildSlaveSupport/built-product-archive:
 670
 671 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
 672
 673         Windows build fix.
 674         Include configuration name when unpacking a build archive.
 675
 676         Needed, since we split Windows build results into configuration-specific directories
 677         under WebKitOutputDir.
 678
 679         * BuildSlaveSupport/built-product-archive:
 680
 681 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
 682
 683         Reviewed by Darin Adler.
 684
 685         Debug and Release builds on Windows clobber each other
 686         https://bugs.webkit.org/show_bug.cgi?id=49185
 687
 688         Changes the structure of WebKitBuild build products directory so we
 689         completely separate each build configuration into independent directories.
 690
 691         Although we previously had per-configuration directories for obj, this change adds
 692         per-configuration directories for bin, lib, obj, and include. Each configuration's
 693         build products are stored within a directory inside of WebKitBuild.
 694
 695         Most use of $(WebKitOutputDir) in the build files has been replaced by $(ConfigurationBuildDir),
 696         defined in common.vsprops to be $(WebKitOutputDir)\$(ConfigurationName).
 697
 698         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops:
 699         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd:
 700         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd:
 701         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
 702         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd:
 703         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd:
 704         * DumpRenderTree/win/ImageDiffCommon.vsprops:
 705         * DumpRenderTree/win/ImageDiffPostBuild.cmd:
 706         * DumpRenderTree/win/ImageDiffPreBuild.cmd:
 707         * FindSafari/FindSafari.vcproj:
 708         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
 709         * MiniBrowser/MiniBrowserPostBuild.cmd:
 710         * MiniBrowser/MiniBrowserPreBuild.cmd:
 711         * Scripts/webkitdirs.pm:
 712         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
 713         * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops:
 714         * TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd:
 715         * TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd:
 716         * TestWebKitAPI/win/copy-resources.cmd:
 717         * WebKitAPITest/WebKitAPITestCommon.vsprops:
 718         * WebKitAPITest/WebKitAPITestPostBuild.cmd:
 719         * WebKitAPITest/WebKitAPITestPreBuild.cmd:
 720         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
 721         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
 722         * WebKitTestRunner/win/InjectedBundle.vcproj:
 723         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops:
 724         * WebKitTestRunner/win/InjectedBundlePostBuild.cmd:
 725         * WebKitTestRunner/win/InjectedBundlePreBuild.cmd:
 726         * WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd:
 727         * WebKitTestRunner/win/WebKitTestRunnerPreBuild.cmd:
 728         * WinLauncher/WinLauncherCommon.vsprops:
 729         * WinLauncher/WinLauncherPostBuild.cmd:
 730         * WinLauncher/WinLauncherPreBuild.cmd:
 731
 732 2011-01-05  Jan Erik Hanssen  <jhanssen@sencha.com>
 733
 734         Reviewed by Ariya Hidayat.
 735
 736         [Qt] TestNetscapePlugin doesn't link on OS X
 737         https://bugs.webkit.org/show_bug.cgi?id=51948
 738
 739         Only add a dependency on libX11 on X11 systems
 740
 741         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
 742
 743 2011-01-05  Jeff Miller  <jeffm@apple.com>
 744
 745         Reviewed by Adam Roben.
 746
 747         check-webkit-style should allow unnecessary parameter names in WebKit2 APIs because we're matching CF's header style
 748         https://bugs.webkit.org/show_bug.cgi?id=51970
 749
 750         * Scripts/webkitpy/style/checker.py:
 751         Add -readability/naming for WebKit2 C API directories.
 752
 753 2011-01-05  Eric Seidel  <eric@webkit.org>
 754
 755         Unreviewed, just fixing one more log error from my previous python patch.
 756
 757         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
 758         https://bugs.webkit.org/show_bug.cgi?id=51802
 759
 760         webkit-patch failure-reason was logging about parsing errors
 761         due to my misunderstanding of how BeautifulSoup.findAll worked.
 762
 763         Fixed, and added a unit test.
 764
 765         * Scripts/webkitpy/common/net/layouttestresults.py:
 766         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
 767
 768 2011-01-05  Benjamin Poulain  <benjamin.poulain@nokia.com>
 769
 770         Reviewed by Kenneth Rohde Christiansen.
 771
 772         [Qt] [WK2] Add the possibility to open window from the WebProcess in Minibrowser
 773         https://bugs.webkit.org/show_bug.cgi?id=51951
 774
 775         Set a function to QWKPage::setCreateNewPageFunction() in Minibrowser so there is a way
 776         to create new window from WebKit.
 777
 778         * MiniBrowser/qt/BrowserWindow.cpp:
 779         (newPageFunction):
 780         (BrowserWindow::BrowserWindow):
 781         (BrowserWindow::page): Added to avoid the indirect access to QWKPage spread in the class
 782         (BrowserWindow::newWindow):
 783         (BrowserWindow::updateUserAgentList):
 784         (BrowserWindow::showUserAgentDialog):
 785         * MiniBrowser/qt/BrowserWindow.h: Add the global variable backingStoreTypeForNewWindow to
 786         define the type of the backing store used for new windows.
 787         * MiniBrowser/qt/main.cpp:
 788         (main):
 789
 790 2011-01-05  Eric Seidel  <eric@webkit.org>
 791
 792         Reviewed by Ojan Vafai.
 793
 794         commit-queue should report failure type when reporting flaky tests
 795         https://bugs.webkit.org/show_bug.cgi?id=51900
 796
 797         This patch was a ridiculous amount of plumbing.  In the end I like
 798         the NRWT-style TestResult class even less.  But now we're passing
 799         a list of TestResult objects from the queue to the FlakyTestReporter.
 800         Thus the FlakyTestReporter can more easily report what type of failure
 801         occurred.
 802
 803         In the process, I found that I was not alone in finding TestResult
 804         cumbersome to use.  A bunch of code was trying to create a TestResult
 805         object with default values.  However since the constructor didn't make
 806         this easy, some places were getting it wrong (including the TestResult unit test)!
 807         I've fixed the TestResult constructor to have default values for non-essential
 808         arguments.
 809
 810         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
 811         * Scripts/webkitpy/common/net/layouttestresults.py:
 812         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
 813         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
 814         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
 815         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
 816         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
 817         * Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py:
 818         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
 819         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
 820         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
 821         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
 822         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
 823         * Scripts/webkitpy/tool/commands/queues.py:
 824         * Scripts/webkitpy/tool/commands/queues_unittest.py:
 825
 826 2011-01-05  Eric Seidel  <eric@webkit.org>
 827
 828         Unreviewed.
 829
 830         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
 831         https://bugs.webkit.org/show_bug.cgi?id=51802
 832
 833         Add another unit test to cover a previously missing import.
 834
 835         * Scripts/webkitpy/common/net/layouttestresults.py:
 836         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
 837
 838 2011-01-05  Mihai Parparita  <mihaip@chromium.org>
 839
 840         Reviewed by David Levin.
 841
 842         Add mihaip@chromium.org as a reviewer
 843         https://bugs.webkit.org/show_bug.cgi?id=51966
 844
 845         Add myself as a reviewer.
 846
 847         * Scripts/webkitpy/common/config/committers.py:
 848
 849 2011-01-05  James Simonsen  <simonjam@chromium.org>
 850
 851         Unreviewed. Adding myself to the list of committers.
 852
 853         * Scripts/webkitpy/common/config/committers.py:
 854
 855 2011-01-05  Eric Seidel  <eric@webkit.org>
 856
 857         Unreviewed.
 858
 859         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
 860         https://bugs.webkit.org/show_bug.cgi?id=51802
 861
 862         Fix two exceptions seen on the bots after my original commit.
 863
 864         * Scripts/webkitpy/common/net/layouttestresults.py:
 865         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
 866
 867 2011-01-05  Kundu Suchismita  <suchi.kundu@nokia.com>
 868
 869         Reviewed by Andreas Kling.
 870
 871         [Qt]Add local storage settings to QtTestBrowser command line arguments
 872         https://bugs.webkit.org/show_bug.cgi?id=51750
 873
 874         * QtTestBrowser/main.cpp:
 875         (LauncherApplication::handleUserOptions):
 876          Local storage settings can be enable form command line arguments for
 877          QtTestBrowser.
 878
 879 2011-01-05  Chris Fleizach  <cfleizach@apple.com>
 880
 881         Reviewed by Martin Robinson.
 882
 883         GTK: AX: DRT needs to use correct root object method.
 884         https://bugs.webkit.org/show_bug.cgi?id=51911
 885
 886         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
 887         (AccessibilityController::rootElement):
 888
 889 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
 890
 891         Rubber-stamped by Csaba Osztrogonác.
 892
 893         Based on idea from Péter Gál.
 894
 895         * Scripts/webkitpy/tool/bot/sheriff.py: Remove unnecessary apostrophes around revision numbers.
 896
 897 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
 898
 899         Reviewed by Adam Barth.
 900
 901         sheriff-bot should be able to do multi-revision rollouts
 902         https://bugs.webkit.org/show_bug.cgi?id=51176
 903
 904         * Scripts/webkitpy/tool/bot/irc_command.py:
 905         * Scripts/webkitpy/tool/bot/sheriff.py:
 906         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
 907
 908 2011-01-05  Eric Seidel  <eric@webkit.org>
 909
 910         Reviewed by Adam Barth.
 911
 912         queues.webkit.org should have per-bot status pages
 913         https://bugs.webkit.org/show_bug.cgi?id=51906
 914
 915         Just adds a /queue-status/QUEUE_NAME/bots/BOT_ID page to show
 916         statuses from a single queue.  Now that we have many bots servicing
 917         some queues (commit-queue, win-ews, etc.) its easy to have the messages
 918         you care about scroll off the end of the 15-message limit on the main page.
 919
 920         Eventually we should probably rename /queue-status to /queue or /queues,
 921         but that's fodder for another patch.
 922
 923         * QueueStatusServer/handlers/queuestatus.py:
 924         * QueueStatusServer/index.yaml:
 925         * QueueStatusServer/main.py:
 926         * QueueStatusServer/templates/includes/singlequeuestatus.html:
 927          - This probably should use a custom filter instead of hard-coding
 928            the URL scheme here, but I couldn't figure out how to easily
 929            create such a filter.  Most filters work with "strings" so we can't
 930            pass the status object.  We could add a method to the status
 931            object and call that, but that seemed a bit strange too.
 932         * QueueStatusServer/templates/queuestatus.html:
 933
 934 2011-01-05  Carlos Garcia Campos  <cgarcia@igalia.com>
 935
 936         Unreviewed. Adding myself to the list of committers.
 937
 938         * Scripts/webkitpy/common/config/committers.py:
 939
 940 2011-01-04  Koan-Sin Tan  <koansin.tan@gmail.com>
 941
 942         Reviewed by David Levin.
 943
 944         check-webkit-style treated some macros with parentheses after #elif as function calls
 945         https://bugs.webkit.org/show_bug.cgi?id=51695
 946
 947         Ingore function call space checking in any preprocessor directives
 948         (things starting with #). Change search() to match() because
 949         preprocessor directives are supposed to be in the beginning of lines.
 950
 951         * Scripts/webkitpy/style/checkers/cpp.py:
 952         * Scripts/webkitpy/style/checkers/cpp_unittest.py: make sure there is no false positives for #elif cases
 953
 954 2011-01-04  Søren Gjesse  <sgjesse@chromium.org>
 955
 956         Reviewed by Tony Chang.
 957
 958         Change the --multi-load test option to --stress-opt
 959         https://bugs.webkit.org/show_bug.cgi?id=50751
 960
 961         * DumpRenderTree/chromium/DumpRenderTree.cpp:
 962         (runTest):
 963         (main):
 964         * DumpRenderTree/chromium/TestShell.cpp:
 965         (TestShell::TestShell):
 966         * DumpRenderTree/chromium/TestShell.h:
 967         (TestShell::stressOpt):
 968         (TestShell::setStressOpt):
 969         (TestShell::stressDeopt):
 970         (TestShell::setStressDeopt):
 971         (TestShell::javaScriptFlags):
 972         (TestShell::setJavaScriptFlags):
 973         * Scripts/webkitpy/layout_tests/port/chromium.py:
 974         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
 975
 976 2011-01-04  Chris Fleizach  <cfleizach@apple.com>
 977
 978         Reviewed by Sam Weinig.
 979
 980         WK2: Support Accessibility
 981         https://bugs.webkit.org/show_bug.cgi?id=51859
 982
 983         Use rootObject() method to get top of accessibility tree.
 984
 985         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
 986         (AccessibilityController::focusedElement):
 987         (AccessibilityController::rootElement):
 988
 989 2011-01-03  Martin Robinson  <mrobinson@igalia.com>
 990
 991         Reviewed by Darin Adler.
 992
 993         Remove the last non-GObject usage of PlatformRefPtr and move the code to GRefPtr
 994         https://bugs.webkit.org/show_bug.cgi?id=51846
 995
 996         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: Change usage of PlatformRefPtr
 997         back to GRefPtr.
 998
 999 2011-01-04  Zhe Su  <suzhe@chromium.org>
1000
1001         Reviewed by Kenneth Russell.
1002
1003         Fix insertText, setMarkedText and unmarkText methods of
1004         TextInputController to call corresponding methods of WebKit::WebView
1005         rather than WebKit::WebFrame. This change matches the behavior of
1006         chromium browser.
1007         insertText corresponds to WebView::confirmComposition(text)
1008         setMarkedText corresponds to WebView::setComposition(...)
1009         unmarkText corresponds to WebView::confirmComposition()
1010         https://bugs.webkit.org/show_bug.cgi?id=51693
1011
1012         * DumpRenderTree/chromium/TextInputController.cpp:
1013         (TextInputController::insertText):
1014         (TextInputController::setMarkedText):
1015         (TextInputController::unmarkText):
1016
1017 2011-01-04  Dihan Wickremasuriya  <dihan.wickremasuriya@nokia.com>
1018
1019         Reviewed by Laszlo Gombos.
1020
1021         [Qt] [Symbian] Do not remove 0 byte sized files from productDir
1022
1023         On Symbian productDir points to the source directory. Removing all the
1024         empty files from the productDir directory corrupts the svn repository.
1025
1026         * Scripts/build-webkit:
1027
1028 2011-01-03  Yi Shen  <yi.4.shen@nokia.com>
1029
1030         Reviewed by Adam Barth.
1031
1032         [Qt] Add SelectAll option to the context menu for the editor
1033         https://bugs.webkit.org/show_bug.cgi?id=50049
1034
1035         Set shortcut for the SelectAll action.
1036
1037         * QtTestBrowser/mainwindow.cpp:
1038         (MainWindow::buildUI):
1039
1040 2011-01-03  David Levin  <levin@chromium.org>
1041
1042         Reviewed by Eric Seidel.
1043
1044         check-webkit-style shouldn't consider "value" automatically to be a meaningless name.
1045         https://bugs.webkit.org/show_bug.cgi?id=51842
1046
1047         * Scripts/webkitpy/style/checkers/cpp.py: Remove the check for value.
1048         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Remove the test for value.
1049
1050 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
1051
1052         Reviewed by David Kilzer.
1053
1054         [WINCE] Adds a build slave.
1055         https://bugs.webkit.org/show_bug.cgi?id=50523
1056
1057         * BuildSlaveSupport/build.webkit.org-config/config.json: Add an
1058         entry for a release build of the WinCE port.
1059         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add platform
1060         flag to build the WinCE port.
1061
1062 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
1063
1064         Reviewed by David Kilzer.
1065
1066         Add WinCE support to build-webkit
1067         https://bugs.webkit.org/show_bug.cgi?id=51642
1068
1069         * Scripts/build-webkit:
1070         * Scripts/webkitdirs.pm:
1071
1072 2011-01-03  Eric Seidel  <eric@webkit.org>
1073
1074         Reviewed by Adam Barth.
1075
1076         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
1077         https://bugs.webkit.org/show_bug.cgi?id=51802
1078
1079         I'm not the biggest fan of the test_failures or test_results classes,
1080         but it's better to have one shared set of classes, than separate ones
1081         for new vs. old run-webkit-test result handling.
1082
1083         This moves the ORWT results class "LayoutTestResults" over to using
1084         TestResult and TestFailure classes, making it easy for us to
1085         make all our sheriff-bot and other webkitpy code NRWT ready.
1086
1087         This also makes it a trivial patch to generate results.json information
1088         from ORWT results.html files (for flaky test analysis, etc.) as well
1089         as making it a one-liner to report test failure types when the
1090         commit-queue sees flaky tests.
1091
1092         This patch tried not to add new functionality, but only to replace
1093         the guts of LayoutTestResults, while adding unit tests and hoping
1094         not to break anything.
1095
1096         I also moved callers which assumed User.prompt* were static/class methods
1097         to using them as instance methods (since we'll eventually want to make them such).
1098
1099         In the process of re-writing things, I broke the rebaseline command, so I wrote
1100         a unit test to catch my breakage were I do do so again in the future.
1101
1102         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1103         * Scripts/webkitpy/common/net/layouttestresults.py:
1104         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1105         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1106         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
1107         * Scripts/webkitpy/tool/commands/queries.py:
1108         * Scripts/webkitpy/tool/commands/rebaseline.py:
1109         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1110         * Scripts/webkitpy/tool/mocktool.py:
1111
1112 2011-01-03  Adam Barth  <abarth@webkit.org>
1113
1114         Reviewed by Simon Fraser.
1115
1116         webkit-patch shouldn't waste time cleaning a working directory that's already clean
1117         https://bugs.webkit.org/show_bug.cgi?id=51840
1118
1119         * Scripts/webkitpy/common/checkout/scm.py:
1120
1121 2011-01-03  Adam Barth  <abarth@webkit.org>
1122
1123         Reviewed by Simon Fraser.
1124
1125         webkit-patch should only hide update output if --quiet
1126         https://bugs.webkit.org/show_bug.cgi?id=51838
1127
1128         As requested by smfr.
1129
1130         * Scripts/webkitpy/tool/steps/update.py:
1131
1132 2011-01-03  Adam Barth  <abarth@webkit.org>
1133
1134         Reviewed by David Levin.
1135
1136         commit-queue shouldn't reject patches twice if two bots process the same patch
1137         https://bugs.webkit.org/show_bug.cgi?id=51805
1138
1139         Before raising an error, we first check whether the patch is still in
1140         the commit-queue.  This check is still racy, of course, but the time
1141         window is much smaller.
1142
1143         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1144
1145 2011-01-03  Sam Weinig  <sam@webkit.org>
1146
1147         Reviewed by Anders Carlsson.
1148
1149         Make run-api-tests less chatty.
1150         https://bugs.webkit.org/show_bug.cgi?id=51831
1151
1152         - Make script quiet by default and add --verbose option (replacing --quiet).
1153         - When not verbose, pipe stdout and stderr to devnull.
1154
1155         * Scripts/run-api-tests:
1156
1157 2011-01-03  Pratik Solanki  <psolanki@apple.com>
1158
1159         Unreviewed. Adding myself to committers.py.
1160
1161         * Scripts/webkitpy/common/config/committers.py:
1162
1163 2011-01-03  Koan-Sin Tan  <koansin.tan@gmail.com>
1164
1165         Reviewed by Xan Lopez.
1166
1167         "Tool/Scripts/run-launcher --gtk" stopped working after 74855
1168         https://bugs.webkit.org/show_bug.cgi?id=51806
1169
1170         Originally, the $libraryName is 'JavaScriptCore'. When building release
1171         one, the $libraryDir was 'WebKitBuild/Release/JavaScriptCore/../.libs/'
1172         which doesn't exist anymore ('WebKitBuild/Release/JavaScriptCore'
1173         is 'WebKitBuild/Release/Source/JavaScriptCore' now), and
1174         'WebKitBuild/Release/Source/JavaScriptCore/../../.libs' looks weird,
1175         so make it 'WebKitBuild/Release/.libs'
1176
1177         * Scripts/webkitdirs.pm:
1178
1179 2011-01-02  Patrick Gansterer  <paroga@webkit.org>
1180
1181         Reviewed by Adam Barth.
1182
1183         Make EFL a core builder
1184         https://bugs.webkit.org/show_bug.cgi?id=51804
1185
1186         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1187         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1188
1189 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
1190
1191         [Qt] Unreviewed fix after r74855 and r74875.
1192
1193         * BuildSlaveSupport/built-product-archive:
1194          - Create directories explicitly.
1195          - Pass shell=True to subprocess.call().
1196
1197 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
1198
1199         [Qt] Unreviewed fix after r74855.
1200
1201         Move JavaScriptCore to Source
1202         https://bugs.webkit.org/show_bug.cgi?id=51604
1203
1204         * BuildSlaveSupport/built-product-archive: JavaScriptCore -> Source/JavaScriptCore
1205
1206 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
1207
1208         [Qt] Unreviewed run-javasriptcore-tests fix after r74855.
1209
1210         Move JavaScriptCore to Source
1211         https://bugs.webkit.org/show_bug.cgi?id=51604
1212
1213         * Scripts/webkitdirs.pm:
1214
1215 2011-01-02  Robert Hogan  <robert@webkit.org>
1216
1217         Unreviewed, build fix.
1218
1219         [Qt] Fix DRT build after 74855
1220
1221         * DumpRenderTree/qt/DumpRenderTree.pro:
1222
1223 2011-01-01  Adam Barth  <abarth@webkit.org>
1224
1225         Remove the assumption from the Qt and Gtk builds that every project is
1226         in the root directory.
1227
1228         * Scripts/build-webkit:
1229
1230 2011-01-01  Adam Barth  <abarth@webkit.org>
1231
1232         Reviewed by Eric Seidel.
1233
1234         Teach svn-apply how to apply patches even though JavaScriptCore has moved
1235         https://bugs.webkit.org/show_bug.cgi?id=51796
1236
1237         After this change, svn-apply will magically apply patches to
1238         JavaScriptCore/foo to Source/JavaScriptCore/foo.
1239
1240         * Scripts/VCSUtils.pm:
1241
1242 2011-01-01  Adam Barth  <abarth@webkit.org>
1243
1244         Reviewed by Eric Seidel.
1245
1246         Move JavaScriptCore to Source
1247         https://bugs.webkit.org/show_bug.cgi?id=51604
1248
1249         Update references to JavaScriptCore to point to the new location.
1250
1251         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1252         * DumpRenderTree/qt/DumpRenderTree.pro:
1253         * DumpRenderTree/qt/ImageDiff.pro:
1254         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1255         * DumpRenderTree/wscript:
1256         * Scripts/build-jsc:
1257         * Scripts/build-webkit:
1258         * Scripts/do-file-rename:
1259         * Scripts/do-webcore-rename:
1260         * Scripts/run-javascriptcore-tests:
1261         * Scripts/update-javascriptcore-test-results:
1262         * Scripts/webkitdirs.pm:
1263         * Scripts/webkitpy/common/config/build_unittest.py:
1264         * Scripts/webkitpy/style/checker.py:
1265         * Scripts/webkitpy/style/checker_unittest.py:
1266         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1267         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1268         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1269         * wx/build/settings.py:
1270
1271 2011-01-01  Adam Barth  <abarth@webkit.org>
1272
1273         Reviewed by Eric Seidel.
1274
1275         Move Sources to Source
1276         https://bugs.webkit.org/show_bug.cgi?id=51794
1277
1278         Update scripts to point to the new location.
1279
1280         * Scripts/build-webkit:
1281         * Scripts/do-file-rename:
1282         * Scripts/do-webcore-rename:
1283         * Scripts/webkitpy/common/config/build.py:
1284         * Scripts/webkitpy/common/config/build_unittest.py:
1285
1286 2010-12-31  Kent Tamura  <tkent@chromium.org>
1287
1288         Reviewed by Eric Seidel.
1289
1290         [DRT/Chromium] Enable mock spell checker on non-OSX
1291         https://bugs.webkit.org/show_bug.cgi?id=51401
1292
1293         * DumpRenderTree/chromium/WebViewHost.cpp:
1294         (WebViewHost::spellCheck):
1295
1296 2010-12-31  Adam Barth  <abarth@webkit.org>
1297
1298         Reviewed by Ariya Hidayat.
1299
1300         Remove Tools/Scripts/wkstyle
1301         https://bugs.webkit.org/show_bug.cgi?id=51774
1302
1303         This script appears to not have been touched in a while and seems to
1304         have been replaced by check-webkit-style.
1305
1306         * Scripts/wkstyle: Removed.
1307
1308 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
1309
1310         Unreviewed. Coding style fix.
1311
1312         * DumpRenderTree/chromium/TestShell.h:
1313
1314 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
1315
1316         Reviewed by Pavel Feldman.
1317
1318         Web Inspector: [Chromium] Inspector's tests are very slow on Win(Dbg).
1319
1320         It was a problem with Chromium DRT. DevToolsAgent object instance was
1321         attached not only to the inspected page but to the DevTools window too.
1322         As result all the inspector files were interpreted as a content of inspected page
1323         and were transfered to the DevTools scripts panel for debugging etc.
1324
1325         https://bugs.webkit.org/show_bug.cgi?id=51735
1326
1327         * DumpRenderTree/chromium/TestShell.cpp:
1328         (TestShell::TestShell):
1329         (TestShell::bindJSObjectsToWindow):
1330         (TestShell::createNewWindow):
1331         * DumpRenderTree/chromium/TestShell.h:
1332
1333 2010-12-31  Adam Barth  <abarth@webkit.org>
1334
1335         Rubber-stamped by Eric Seidel.
1336
1337         Move PageLoadTests to PerformanceTests/PageLoad
1338         https://bugs.webkit.org/show_bug.cgi?id=51771
1339
1340         Update references to PageLoadTests to point to the new location.
1341
1342         * Scripts/run-pageloadtest:
1343         * Scripts/webkitpy/common/config/build.py:
1344
1345 2010-12-31  Adam Barth  <abarth@webkit.org>
1346
1347         Rubber-stamped by Eric Seidel.
1348
1349         Move SunSpider into PerformanceTests
1350         https://bugs.webkit.org/show_bug.cgi?id=51769
1351
1352         Update these scripts to point to the new location.
1353
1354         * Scripts/run-sunspider:
1355         * Scripts/sunspider-compare-results:
1356
1357 2010-12-30  Mihai Parparita  <mihaip@chromium.org>
1358
1359         Reviewed by Kent Tamura.
1360
1361         [Chromium] Add WebThemeEngineDRTMac so that Chromium DRT scrollbar rendering can match the Mac port's
1362         https://bugs.webkit.org/show_bug.cgi?id=51728
1363
1364         Add implementation of the Mac WebThemeEngine that uses an NSScroller
1365         to render top-level scrollbars. This makes them match the Mac port's
1366         use of an NSScrollView, which means that we'll be able to share more
1367         pixel baselines.
1368
1369         The new rendering code will not be activated until the
1370         USE_WEB_THEME_ENGINE_TO_PAINT_THUMB #define is fliped in
1371         ScrollbarThemeChromiumMac.
1372
1373         * DumpRenderTree/DumpRenderTree.gypi:
1374         * DumpRenderTree/chromium/TestShellMac.mm:
1375         (platformInit):
1376         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Added.
1377         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Added.
1378         (+[FakeActiveWindow alwaysActiveWindow]):
1379         (+[FakeActiveWindow alwaysInactiveWindow]):
1380         (-[FakeActiveWindow initWithActiveControls:]):
1381         (-[FakeActiveWindow _hasActiveControls]):
1382         (WebThemeEngineDRTMac::paintScrollbarThumb):
1383         (stateToHIEnableState):
1384         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
1385         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
1386
1387 2010-12-30  Konstantin Tokarev  <annulen@yandex.ru>
1388
1389         Reviewed by David Kilzer.
1390
1391         [Qt] Don't build wtf/TCSystemAlloc.cpp if --system-malloc option is
1392         used
1393         https://bugs.webkit.org/show_bug.cgi?id=51672
1394
1395         * DumpRenderTree/qt/DumpRenderTree.pro: Replaced USE_SYSTEM_MALLOC
1396         with USE_SYSTEM_MALLOC=1
1397         * WebKitTestRunner/qt/WebKitTestRunner.pro: Replaced USE_SYSTEM_MALLOC
1398         with USE_SYSTEM_MALLOC=1
1399
1400 2010-12-30  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1401
1402         Reviewed by David Kilzer.
1403
1404         [Qt] [Symbian] Fix build-webkit script for Symbian
1405         https://bugs.webkit.org/show_bug.cgi?id=51509
1406
1407         Set the OUTPUT_DIR for Symbian to be the same as the source
1408         directory.
1409
1410         * Scripts/webkitdirs.pm:
1411
1412 2010-12-30  Martin Robinson  <mrobinson@igalia.com>
1413
1414         Reviewed by Darin Adler.
1415
1416         check-webkit-style should ignore NULL usage in calls to gtk_widget_style_get
1417         https://bugs.webkit.org/show_bug.cgi?id=51758
1418
1419         Add a check-webkit-style exception for gtk_widget_style_get and NULL usage.
1420
1421         * Scripts/webkitpy/style/checkers/cpp.py: Add the exception.
1422         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Add some tests for this.
1423
1424 2010-12-29  Patrick Gansterer  <paroga@webkit.org>
1425
1426         Unreviewed WinCE buildfix.
1427
1428         * WinCELauncher/main.cpp: Add missing include.
1429
1430 2010-12-29  Daniel Bates  <dbates@rim.com>
1431
1432         Reviewed by Darin Adler.
1433
1434         svn-apply updates date of wrong change log entry for a change log diff that
1435         contains two consecutive entries with the same author and date
1436         https://bugs.webkit.org/show_bug.cgi?id=46061
1437
1438         Fixes an issue where the date of the wrong change log entry may be modified.
1439         Moreover, changes fixChangeLogPatch() to move entries inserted earlier
1440         in a ChangeLog file to the top of the file.
1441
1442         Currently, fixChangeLogPatch() explicitly bails out and returns an unchanged
1443         diff when it detects that the diff inserts a change log entry earlier in a
1444         ChangeLog. It is unusual to land a patch that has such a deliberate ChangeLog
1445         change. With the advent of the commit-queue this functionality of bailing out
1446         and hence landing the patch as-is is harmful to the accuracy of the ChangeLog.
1447         Instead, we should always move the change log entry to the top of the ChangeLog file.
1448
1449         A side-effect of this change is that setChangeLogDateAndReviewer() now updates
1450         the date line of the correct change log entry in a ChangeLog diff.
1451
1452         * Scripts/VCSUtils.pm: Modified fixChangeLogPatch() to move entries inserted earlier to the top.
1453
1454         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
1455           Updated the following unit tests now that we move entries inserted earlier to the top:
1456           - "fixChangeLogPatch: New entry inserted in middle."
1457             (formerly named "fixChangeLogPatch: [no change] New entry inserted in middle.")
1458
1459           - "fixChangeLogPatch: New entry inserted earlier in the file, but after an entry with the same author and date."
1460             (formerly named "fixChangeLogPatch: [no change] New entry inserted earlier in the file, but after an entry with the same author and date.")
1461
1462         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatchThenSetChangeLogDateAndReviewer.pl: Added.
1463
1464 2010-12-29  Konstantin Tokarev  <annulen@yandex.ru>
1465
1466         Reviewed by Eric Seidel.
1467
1468         [Qt] Fixed compatibility with gold linker on X11 platforms
1469         https://bugs.webkit.org/show_bug.cgi?id=51700
1470
1471         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1472         Linked TestNetscapePlugin with libX11 on Unix platforms
1473
1474 2010-12-29  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>
1475
1476         Reviewed by Darin Adler.
1477
1478         Circular dependency in webkitpy.common.checkout.changelog module
1479         https://bugs.webkit.org/show_bug.cgi?id=50475
1480
1481         Remove automatic import of api.Checkout module when any checkout/
1482         submodule is imported (e.g.: when checkout.scm.Git is imported).
1483
1484         * Scripts/webkitpy/common/checkout/__init__.py:
1485
1486 2010-12-29  Martin Robinson  <mrobinson@igalia.com>
1487
1488         Reviewed by Ojan Vafai.
1489
1490         prepare-ChangeLog should support the -g option for specifying the git-commit
1491         https://bugs.webkit.org/show_bug.cgi?id=51708
1492
1493         Add a -g shortcut for the --git-commit prepare-ChangeLog option. This matches
1494         webkit-patch, though the exact meaning of the two options remain different.
1495
1496         * Scripts/prepare-ChangeLog: Add -g.
1497
1498 2010-12-29  Kent Hansen  <kent.hansen@nokia.com>
1499
1500         Reviewed by Simon Hausmann.
1501
1502         [Qt] Fix compilation with Qt in namespace
1503         https://bugs.webkit.org/show_bug.cgi?id=51701
1504
1505         * QtTestBrowser/webview.h:
1506
1507 2010-12-28  Daniel Bates  <dbates@rim.com>
1508
1509         Reviewed by Sam Weinig.
1510
1511         Substitute // MARK: for compiler-specific #pragma mark
1512         https://bugs.webkit.org/show_bug.cgi?id=51657
1513
1514         Fix future compilation warnings about "#pragma mark" on GTK+ bots by
1515         substituting  "// MARK:" for "#pragma mark", which provides
1516         analogous code-bookmarking functionality under Xcode.
1517
1518         Also, for consistency, we should substitute "// MARK:" for compiler-
1519         specific "#pragma mark" in the source files for the Mac port.
1520
1521         * DumpRenderTree/AccessibilityTextMarker.cpp:
1522         * DumpRenderTree/cf/WebArchiveDumpSupport.h:
1523         * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm:
1524         * DumpRenderTree/mac/ObjCController.m:
1525         * MiniBrowser/mac/AppDelegate.m:
1526         * MiniBrowser/mac/BrowserWindowController.m:
1527
1528 2010-12-28  Xan Lopez  <xlopez@igalia.com>
1529
1530         Reviewed by Eric Seidel.
1531
1532         Add --no-build option to run-sunspider
1533         https://bugs.webkit.org/show_bug.cgi?id=51658
1534
1535         * Scripts/run-sunspider: add --no-build flag to skip building
1536         phase.
1537
1538 2010-12-27  Daniel Bates  <dbates@rim.com>
1539
1540         Rubber-stamped by Martin Robinson.
1541
1542         Append the directory Tools/DumpRenderTree to the list of directories that
1543         do-webcore-rename should search so that it can rename DRT files and
1544         source code.
1545
1546         * Scripts/do-webcore-rename:
1547
1548 2010-12-27  Eric Seidel  <eric@webkit.org>
1549
1550         Reviewed by Adam Barth.
1551
1552         build-webkit should detect missing Java SDK and explain how to install it
1553         https://bugs.webkit.org/show_bug.cgi?id=51651
1554
1555         * Scripts/build-webkit:
1556
1557 2010-12-26  Martin Robinson  <mrobinson@igalia.com>
1558
1559         Reviewed by Daniel Bates.
1560
1561         [GTK] Add support for build-jsc
1562         https://bugs.webkit.org/show_bug.cgi?id=51625
1563
1564         Add GTK+ support to build-jsc now that building the jsc executable as
1565         a standalone target is easy.
1566
1567         * Scripts/build-jsc: Call buildGtkProject for the GTK+ case now.
1568         * Scripts/build-webkit: Pass in the proper target name to buildGtkProject.
1569         * Scripts/webkitdirs.pm: Actually process the project parameter in buildGtkProject
1570         and pass it along to buildAutotoolsProject.
1571
1572 2010-12-27  David Levin  <levin@chromium.org>
1573
1574         Reviewed by Eric Seidel.
1575
1576         check-webkit-style check for meaningless variable names in function declarations.
1577         https://bugs.webkit.org/show_bug.cgi?id=51523
1578
1579         * Scripts/webkitpy/style/checker.py: Exempted JavaScriptCore/jit/JITStubs.cpp
1580         from the new check and whitespace/parens because the syntax is unusual and
1581         produced a fair number of positives for these checks.
1582         * Scripts/webkitpy/style/checkers/cpp.py:
1583         (_convert_to_lower_with_underscores): Used as a canonical form for type names
1584         and parameter names when determining if the parameter name is useless.
1585         (_create_acronym): Used to check for redundant variable names in cases like "ExceptionCode ec"
1586         (Parameter.lower_with_underscores_name): Gives back the parameter name in a lower_with_underscore
1587         format.
1588         (_check_parameter_name_against_text):  Checks to see if the parameter name is in the
1589         text or an acronym of it.
1590         (check_function_definition): Checks function definitions for meaningless variable names.
1591         (process_line): Added call to check_function_definition.
1592         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1593         (CppFunctionsTest.test_convert_to_lower_with_underscores): Test for _convert_to_lower_with_underscores.
1594         (CppFunctionsTest.test_create_acronym): Test for _create_acronym.
1595         (CppFunctionsTest.test_check_parameter_against_text): Test for _check_parameter_against_text.
1596         (CppStyleTestBase.perform_single_line_lint): Removed the parameter name check
1597         because when only checking a snippet, there are a lot of bogus functions.
1598         (CppStyleTestBase.perform_multi_line_lint): Ditto and removed a bogus filter
1599         that I put there previously and just noticed.
1600         (WebKitStyleTest.test_parameter_names): Tests for the functionality -- both
1601         check_function_definition and process_line.
1602
1603 2010-12-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1604
1605         Reviewed by Martin Robinson.
1606
1607         [GTK] Disable flash plugin in GtkLauncher when using gtk3
1608         https://bugs.webkit.org/show_bug.cgi?id=51591
1609
1610         Flash plugin uses gtk2 that is incompatible with gtk3 making
1611         webkit crash when it's built with gtk3.
1612
1613         * GtkLauncher/main.c:
1614         (main):
1615
1616 2010-12-25  Adam Barth  <abarth@webkit.org>
1617
1618         Reviewed by Eric Seidel.
1619
1620         Move ANGLE to Sources/ThirdParty
1621         https://bugs.webkit.org/show_bug.cgi?id=51605
1622
1623         * Scripts/build-webkit:
1624           - Point to the new ANGLE location.
1625
1626 2010-12-26  David Levin  <levin@chromium.org>
1627
1628         Reviewed by Eric Seidel.
1629
1630         check-webkit-style should be able to parse function declaration parameters.
1631         https://bugs.webkit.org/show_bug.cgi?id=51451
1632
1633         * Scripts/webkitpy/style/checkers/cpp.py:
1634         (Position.__init__): Holds simple position information (row, column).
1635         (Parameter.__init__): Holds information about a parameter.
1636         (SingleLineView.__init): Converts multiple lines into a single line for simpler searches.
1637         (SingleLineView.convert_column_to_row): Returns the original row given a column.
1638         (create_skeleton_parameters): Simplifies a parameter list for easier searching.
1639         (find_parameter_name_index): Finds where the parameter name is.
1640         (parameter_list): Generates the list of parameters for a function.
1641         (_FunctionState.begin): Added information to allow determining the parameters
1642         on demand.
1643         (_FunctionState.get_parameter_list): Returns a tuple of function parameters.
1644         (detect_functions): Improve function detection for operator functions and
1645         determine where the parameters end and pass that to _FunctionState.begin.
1646         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1647         (CppFunctionsTest.test_parameter): Verifies Parameter functionality.
1648         (CppFunctionsTest.test_single_line_view): Verifies SingleLineView functionality.
1649         (CppFunctionsTest.test_create_skeleton_parameters): Verifies create_skeleton_parameters.
1650         (CppFunctionsTest.test_find_parameter_name_index): Verifies find_parameter_name_index.
1651         (CppFunctionsTest.test_parameter_list): Does some minimal verification for parameter list.
1652         Much more thorough verification is done as part of FunctionDetectionTest.test_parameter_list.
1653         (FunctionDetectionTest.perform_function_detection): Added support for verifying
1654         the parameters found.
1655         (FunctionDetectionTest.test_function_declaration_detection): Added more function
1656         detection test to verify that we catch the operator functions.
1657         (FunctionDetectionTest.test_ignore_macros): Verify that function detection ignores macros.
1658         (FunctionDetectionTest.test_parameter_list): Added tests to verify the parameter parsing.
1659         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_bad_test_doesnt_break): Removed
1660         because the error. The test is about the bad function name. Fixing the name makes the test exactly like
1661         test_function_length_check_definition_severity1_for_test.
1662
1663 2010-12-25  Patrick Gansterer  <paroga@webkit.org>
1664
1665         Unreviewed WinCE buildfix after r74334.
1666
1667         * CMakeListsWinCE.txt:
1668
1669 2010-12-24  Sheriff Bot  <webkit.review.bot@gmail.com>
1670
1671         Unreviewed, rolling out r74632.
1672         http://trac.webkit.org/changeset/74632
1673         https://bugs.webkit.org/show_bug.cgi?id=51600
1674
1675         makes test-webkitpy hang forever on GTK (Requested by philn-tp
1676         on #webkit).
1677
1678         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
1679         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
1680
1681 2010-12-24  Ryuan Choi  <ryuan.choi@samsung.com>
1682
1683         Reviewed by Kenneth Rohde Christiansen.
1684
1685         [EFL] Screen doesn't be rendered when changing size of EWebLauncher
1686         https://bugs.webkit.org/show_bug.cgi?id=43528
1687
1688         Remove on_resize because ewk_view_fixed_layout_size_set should not be
1689         called on callback of EVAS_CALLBACK_RESIZE. As it change size of
1690         FrameView, rendering was ignored when _ewk_view_smart_calculate was
1691         called.
1692
1693         * EWebLauncher/main.c:
1694         (browserCreate):
1695
1696 2010-12-24  Eric Seidel  <eric@webkit.org>
1697
1698         Reviewed by Adam Barth.
1699
1700         webkit-patch (or a pre-commit hook) needs to prevent bad ChangeLog changes
1701         https://bugs.webkit.org/show_bug.cgi?id=28291
1702
1703         This is a start.  At least now webkit-patch will prompt when your ChangeLog looks questionable.
1704         We could do more advanced things, like parsing the ChangeLog (with changelog.py) and comparing that
1705         to strings with find in the diff.
1706         Since non-interactive always returns the default, this should cause patches with bad changelogs to fail on the commit-queue.
1707
1708         * Scripts/webkitpy/common/checkout/api.py:
1709         * Scripts/webkitpy/common/checkout/diff_parser.py:
1710         * Scripts/webkitpy/tool/steps/abstractstep.py:
1711         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
1712         * Scripts/webkitpy/tool/steps/validatechangelogs.py: Copied from Tools/Scripts/webkitpy/tool/steps/validatereviewer.py.
1713         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py: Copied from Tools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.
1714         * Scripts/webkitpy/tool/steps/validatereviewer.py:
1715
1716 2010-12-24  Dirk Pranke  <dpranke@chromium.org>
1717
1718         Reviewed by Kenneth Russell.
1719
1720         Modify new-run-webkit-tests to shut up and exit when all the threads
1721         are wedged so that test runs complete faster and we don't end up
1722         w/ enormous log files.
1723
1724         https://bugs.webkit.org/show_bug.cgi?id=51572
1725
1726         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
1727         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
1728
1729 2010-12-24  Eric Seidel  <eric@webkit.org>
1730
1731         Reviewed by David Levin.
1732
1733         commit-queue should better explain how it will re-open bugs and follow duplicate chains
1734         https://bugs.webkit.org/show_bug.cgi?id=51549
1735
1736         I've had multiple people ask me about the commit-queue's behavior
1737         regarding reporting flaky tests.  I figured it would be best to just
1738         have the queue explain itself in the bugs it files.
1739
1740         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1741         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1742
1743 2010-12-24  Shinichiro Hamaji  <hamaji@chromium.org>
1744
1745         Reviewed by Eric Seidel.
1746
1747         check-webkit-style: should ignore "wrong" namings in JavaScriptCore/qt
1748         https://bugs.webkit.org/show_bug.cgi?id=51467
1749
1750         * Scripts/webkitpy/style/checker.py:
1751         * Scripts/webkitpy/style/checker_unittest.py:
1752
1753 2010-12-23  Adam Barth  <abarth@webkit.org>
1754
1755         Rubber-stamped by Eric Seidel.
1756
1757         Move JavaScriptGlue into Sources
1758         https://bugs.webkit.org/show_bug.cgi?id=51583
1759
1760         These tools refer to JavaScriptGlue and need to be updated to its new
1761         location.
1762
1763         * Scripts/build-webkit:
1764         * Scripts/do-file-rename:
1765         * Scripts/do-webcore-rename:
1766         * Scripts/webkitpy/common/config/build.py:
1767         * Scripts/webkitpy/common/config/build_unittest.py:
1768
1769 2010-12-23  Lucas Forschler  <lforschler@apple.com>
1770
1771         Reviewed by Eric Seidel.
1772
1773         Bug 51539 - update iexploder scripts to point to new location
1774
1775         * Scripts/run-iexploder-tests:
1776         * Scripts/update-iexploder-cssproperties:
1777
1778 2010-12-23  Evan Martin  <evan@chromium.org>
1779
1780         Reviewed by Ryosuke Niwa.
1781
1782         [chromium] LayoutTestController warning in float->int conversion
1783         https://bugs.webkit.org/show_bug.cgi?id=51553
1784
1785         Rather than reading an int, converting to a float, then getting a compiler
1786         warning on passing the float to something that expects an int, instead
1787         just pass around ints.
1788
1789         No tests, fixes a compiler warning.
1790
1791         * DumpRenderTree/chromium/LayoutTestController.cpp:
1792         (parsePageSizeParameters):
1793         (LayoutTestController::pageNumberForElementById):
1794         (LayoutTestController::numberOfPages):
1795
1796 2010-12-23  Lucas Forschler  <lforschler@apple.com>
1797
1798         Reviewed by Darin Adler.
1799
1800         Bug 51537 - iexploder needs cleanup
1801
1802         * iExploder/htdocs: Removed.
1803         * iExploder/htdocs/config.rb: Removed.
1804         * iExploder/htdocs/cssproperties.in: Removed.
1805         * iExploder/htdocs/cssvalues.in: Removed.
1806         * iExploder/htdocs/htmlattrs.in: Removed.
1807         * iExploder/htdocs/htmltags.in: Removed.
1808         * iExploder/htdocs/htmlvalues.in: Removed.
1809         * iExploder/htdocs/iexploder.cgi: Removed.
1810         * iExploder/htdocs/iexploder.rb: Removed.
1811         * iExploder/htdocs/index.html: Removed.
1812         * iExploder/htdocs/webserver.rb: Removed.
1813         * iExploder/iexploder-1.7.2/output: Removed.
1814         * iExploder/tools: Removed.
1815         * iExploder/tools/lasthit.rb: Removed.
1816         * iExploder/tools/osx_last_crash.rb: Removed.
1817         * iExploder/tools/showtest.rb: Removed.
1818
1819 2010-12-23  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
1820
1821         Reviewed by Kenneth Rohde Christiansen.
1822
1823         [EFL] Make 'single' the default backing store in EWebLauncher
1824         https://bugs.webkit.org/show_bug.cgi?id=51534
1825
1826         'single' is the simplest backing store and the one intended to be the
1827         default in the test browser. By mistake the tiled backing store was
1828         left as default in r72617.
1829
1830         * EWebLauncher/main.c:
1831         (browserCreate): ditto.
1832
1833 2010-12-23  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
1834
1835         Reviewed by Kenneth Rohde Christiansen.
1836
1837         [EFL] Subject: [webkit 4/4] [EFL] Remove non-sense workaround
1838         https://bugs.webkit.org/show_bug.cgi?id=51533
1839
1840         There's no point in concatenating env("HOME") with "blah", so remove
1841         option from EWebLauncher.
1842
1843         * EWebLauncher/main.c:
1844         (main): ditto.
1845
1846 2010-12-23  Ilya Tikhonovsky  <loislo@chromium.org>
1847
1848         Reviewed by Eric Seidel.
1849
1850         Web Inspector: chromium: inspector's tests are quite slow especially at windows(Debug).
1851
1852         Almost all inspector's tests become flaky on chromium Win(dbg) after switching to DRT.
1853         I just discovered that we have two additional GC runs per each WebViewHost.
1854         Test_shell had no such calls.
1855         These gc runs eat 15% of cpu time.
1856
1857         https://bugs.webkit.org/show_bug.cgi?id=51479
1858
1859         * DumpRenderTree/chromium/WebViewHost.cpp:
1860         (WebViewHost::~WebViewHost):
1861
1862 2010-12-22  Dirk Pranke  <dpranke@chromium.org>
1863
1864         Reviewed by Ojan Vafai.
1865
1866         This change splits out the TestRunner class into its own file.
1867         When we fork the code for message passing, we will create a new
1868         TestRunner, and this change will allow that to be more modular.
1869
1870         While we're at it, split out TestInput and ResultSummary into
1871         their own files, to reduce the size of run_webkit_tests to
1872         something more managable.
1873
1874         https://bugs.webkit.org/show_bug.cgi?id=51092
1875
1876         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1877         * Scripts/webkitpy/layout_tests/layout_package/result_summary.py:
1878         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1879         * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
1880         * Scripts/webkitpy/layout_tests/layout_package/test_input.py:
1881         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1882         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1883
1884  2010-12-22  Dirk Pranke  <dpranke@chromium.org>
1885
1886         Reviewed by Ojan Vafai.
1887
1888         nrwt multiprocessing - start over, prepare to fork the code
1889
1890         This code cleans up the signatures and implementation of the
1891         TestRunner class so we can easily fork it to run either the
1892         stable implementation or the new, unstable message-passing
1893         implementation. The two variants will have different
1894         implementations of the run_tests() method. We will switch
1895         between the two based on the setting for the '--worker-model'
1896         switch. We rename the two currently valid values to 'old-inline'
1897         and 'old-threads'.
1898
1899         https://bugs.webkit.org/show_bug.cgi?id=51081
1900
1901         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1902         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1903
1904 2010-12-22  Victor Wang  <victorw@chromium.org>
1905
1906         Reviewed by Darin Fisher.
1907
1908         [Chromium] Update chromium archive test result url in rebaseline script.
1909
1910         https://bugs.webkit.org/show_bug.cgi?id=51503
1911
1912         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1913
1914 2010-12-22  Lucas Forschler  <lforschler@apple.com>
1915
1916         Reviewed by Alice Liu.
1917
1918         <rdar://problem/8633222> record-memory-win needs to record memory used by the webprocess.
1919         Verified on Chrome, Safari, and IE.
1920         With this change, we will record memory from a parent browser window and all child processes.
1921
1922         * record-memory-win/main.cpp:
1923         (ProcessArgs):
1924         (PrintUsage):
1925         (getMemoryInfo):
1926         (printProcessInfo):
1927         (evalProcesses):
1928         (UseImage):
1929         (QueryContinuously):
1930         (ElapsedTime):
1931
1932 2010-12-22  Lucas Forschler  <lforschler@apple.com>
1933
1934         Unreviewed rollout r74489, because it was missing changelog.
1935
1936         * record-memory-win/main.cpp:
1937
1938 2010-12-22  Ryosuke Niwa  <rniwa@webkit.org>
1939
1940         Adding myself as a reviewer.
1941
1942         * Scripts/webkitpy/common/config/committers.py:
1943
1944 2010-12-22  Andrew Scherkus  <scherkus@chromium.org>
1945
1946         Unreviewed.  Adding myself to committers.py.
1947
1948         * Scripts/webkitpy/common/config/committers.py:
1949
1950 2010-12-22  Ariya Hidayat  <ariya@sencha.com>
1951
1952         Reviewed by Kenneth Rohde Christiansen.
1953
1954         TestNetscapePlugIn should use #if defined
1955         https://bugs.webkit.org/show_bug.cgi?id=51471
1956
1957         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1958         (NP_Initialize):
1959         (NPP_New):
1960
1961 2010-12-22  Ilya Tikhonovsky  <loislo@chromium.org>
1962
1963         Reviewed by Yury Semikhatsky.
1964
1965         Web Inspector: [chromium] DRT inspector layout tests are flaky in debug.
1966
1967         DevTools window should be closed explicitly because it has custom deinitialization code.
1968
1969         https://bugs.webkit.org/show_bug.cgi?id=50722
1970
1971         * DumpRenderTree/chromium/TestShell.cpp:
1972         (TestShell::closeRemainingWindows):
1973
1974 2010-12-22  David Levin  <levin@chromium.org>
1975
1976         Reviewed by Shinichiro Hamaji.
1977
1978         check-webkit-style shouldn't complaint about underscores in variables in objective C files.
1979         https://bugs.webkit.org/show_bug.cgi?id=51452
1980
1981         * Scripts/webkitpy/style/checkers/cpp.py:
1982         (_FileState.__init__): Added the information to determine if a file is C or Objective C.
1983         Using the file extension if possible but falling back to the file contents if we have a header file.
1984         (_FileState.is_objective_c): Determine if we have an Objective C by examining the file contents if needed.
1985         (_FileState.is_c_or_objective_c):
1986         (check_using_std): Changed to using _FileState to determine the file type.
1987         (check_max_min_macros): Ditto.
1988         (check_for_null): Ditto.
1989         (check_style): Changed the parameters to various calls since they now need _FileState
1990         to determine the file type.
1991         (check_language): Added the file_state parameter so it could be passed
1992         to check_identifier_name_in_declaration.
1993         (check_identifier_name_in_declaration): Don't warn about underscores in variables if
1994         this is an Objective C file.
1995         (_process_lines): Added information for the _FileState constructor (and moved the
1996         call to a place that had the information).
1997         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1998         (CppFunctionsTest.test_is_c_or_objective_c): Changed the tests to use FileState and exercise
1999         its functionality.
2000         (WebKitStyleTest.test_names): Add tests for underscores in Objective C files.
2001
2002 2010-12-21  Andy Estes  <aestes@apple.com>
2003
2004         Reviewed by Mark Rowe.
2005
2006         Do not build non-Intel architectures for WebKit2-related projects.
2007         https://bugs.webkit.org/show_bug.cgi?id=51440
2008
2009         * MiniBrowser/Configurations/Base.xcconfig: Only build for i386 and x86_64.
2010         * TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
2011         * WebKitTestRunner/Configurations/Base.xcconfig: Ditto.
2012
2013 2010-12-21  Mihai Parparita  <mihaip@chromium.org>
2014
2015         Reviewed by Darin Fisher.
2016
2017         [Chromium] Rename WebThemeEngine/ControlDRT to WebThemeEngine/ControlDRTWin
2018         https://bugs.webkit.org/show_bug.cgi?id=51406
2019
2020         Rename WebThemeControlDRT to WebThemeControlDRTWin and WebThemeEngineDRT
2021         to WebThemeEngineDRTWin and update references everywhere.
2022
2023         * DumpRenderTree/DumpRenderTree.gypi:
2024         * DumpRenderTree/chromium/TestShellWin.cpp:
2025         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRT.cpp.
2026         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRT.h.
2027         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRT.cpp.
2028         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRT.h.
2029
2030 2010-12-21  Anders Carlsson  <andersca@apple.com>
2031
2032         Reviewed by John Sullivan.
2033
2034         Clicking missing plug-in text does not show a sheet
2035         https://bugs.webkit.org/show_bug.cgi?id=51403
2036
2037         Update for changes to the WebPageUIClient.
2038
2039         * MiniBrowser/mac/BrowserWindowController.m:
2040         (-[BrowserWindowController awakeFromNib]):
2041         * WebKitTestRunner/TestController.cpp:
2042         (WTR::createOtherPage):
2043         (WTR::TestController::initialize):
2044
2045 2010-12-21  Eric Seidel  <eric@webkit.org>
2046
2047         Reviewed by Adam Barth.
2048
2049         commit-queue will report constant failures as flaky if other tests flake
2050         https://bugs.webkit.org/show_bug.cgi?id=51272
2051
2052         This patch just removes functionality and adds testing.
2053         Previously we attempted to report flaky tests when we had
2054         two different tests fail in a row.  However, since we stop
2055         running the tests at the first failure, our code was wrong in
2056         trying to determine flakiness from the incomplete runs.
2057
2058         Originally I posted an alternate patch:
2059         https://bug-51272-attachments.webkit.org/attachment.cgi?id=77078
2060         which fixed our flaky logic in this case, however it was decided
2061         that that patch would be too difficult to maintain, so now
2062         I'm just removing the broken logic.
2063
2064         This will dramatically cut-down on our flaky-test false positives
2065         at the (small) cost of the queues being unable to report
2066         any flakiness if the tree is very flaky.  (With at least one test
2067         flaking on every run, we'll never report failures anymore.)  I think
2068         this is a tradeoff worth making.
2069
2070         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2071         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2072
2073 2010-12-20  Eric Seidel  <eric@webkit.org>
2074
2075         Reviewed by Adam Barth.
2076
2077         commit-queue wrongly rejects patches when it can't update itself
2078         https://bugs.webkit.org/show_bug.cgi?id=46636
2079
2080         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2081         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2082         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2083
2084 2010-12-20  Adam Barth  <abarth@webkit.org>
2085
2086         Move web sites to Websites directory
2087         https://bugs.webkit.org/show_bug.cgi?id=51323
2088
2089         Update references to BugsSite to point to the new location.
2090
2091         This patch was never officially reviewed (because it was too large to
2092         upload to bugs.webkit.org), but it was discussed on webkit-dev and Mark
2093         Rowe gave me the green light.
2094
2095         * Scripts/old-run-webkit-tests:
2096         * Scripts/webkitpy/common/config/build.py:
2097         * Scripts/webkitpy/common/config/build_unittest.py:
2098         * Scripts/webkitpy/common/prettypatch.py:
2099         * Scripts/webkitpy/layout_tests/port/base.py:
2100         * Scripts/webkitpy/style/main.py:
2101
2102 2010-12-20  Adrienne Walker  <enne@google.com>
2103
2104         Unreviewed. Adding myself to the list of committers.
2105
2106         * webkitpy/common/config/committers.py:
2107
2108 2010-12-20  Mark Rowe  <mrowe@apple.com>
2109
2110         Reviewed by Dan Bernstein.
2111
2112         <rdar://problem/8757601> Don't install header files in to the Resources directory.
2113
2114         * Scripts/check-for-inappropriate-files-in-framework: Don't allow .h files in the
2115         Resources directory.
2116
2117 2010-12-20  Eric Seidel  <eric@webkit.org>
2118
2119         Reviewed by Adam Barth.
2120
2121         commit-queue should include bot id when attaching failure diffs
2122         https://bugs.webkit.org/show_bug.cgi?id=51280
2123
2124         This is a tiny change to include the bot id in the name of the attachment.
2125         Most of this diff is just changing the unit test expectations
2126         now that I hid the comment printing when the comment is None.
2127
2128         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2129         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2130         * Scripts/webkitpy/tool/commands/upload_unittest.py:
2131         * Scripts/webkitpy/tool/mocktool.py:
2132
2133 2010-12-20  Jeff Miller  <jeffm@apple.com>
2134
2135         Reviewed by Dan Bernstein.
2136
2137         Tools/vcbin/midl.exe needs to be rebuilt
2138         https://bugs.webkit.org/show_bug.cgi?id=51347
2139
2140         * vcbin/midl.exe: Rebuilt.
2141
2142 2010-12-20  David Levin  <levin@chromium.org>
2143
2144         Reviewed by Ariya Hidayat.
2145
2146         .gitignore and webkit-tools-completion.sh have references to WebKitTools that should be Tools.
2147         https://bugs.webkit.org/show_bug.cgi?id=51343
2148
2149         Follow up from the WebKitTools -> Tools rename.
2150
2151         * Scripts/webkit-tools-completion.sh:
2152
2153 2010-12-20  Cosmin Truta  <ctruta@chromium.org>
2154
2155         Reviewed by James Robinson.
2156
2157         new-run-webkit-tests ignores trailing EOL differences in text tests
2158         https://bugs.webkit.org/show_bug.cgi?id=36983
2159
2160         Changed the handling of new-line characters within new-run-webkit-tests
2161         to match old-run-webkit-tests.  Differences in leading and trailing empty
2162         lines in text expectation files are no longer ignored.
2163
2164         * Scripts/webkitpy/layout_tests/port/base.py:
2165         * Scripts/webkitpy/layout_tests/port/test.py:
2166         Added unit tests.  Removed old duplicate unit test entries.
2167         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
2168
2169 2010-12-20  David Levin  <levin@chromium.org>
2170
2171         Reviewed by Shinichiro Hamaji.
2172
2173         check-webkit-style should detect function declarations (and trivial functions).
2174         https://bugs.webkit.org/show_bug.cgi?id=51303
2175
2176         * Scripts/webkitpy/style/checkers/cpp.py:
2177         (_FunctionState.begin): Add is_declaration and changed the line count
2178         start to begin at -1 (which will keep the results consistent, since
2179         the starting line number passed in is one less in this change).
2180         (detect_functions): changed function detection to now catch trivial
2181         functions and declarations.
2182         (check_pass_ptr_usage): Don't check for Pass*Ptr on the first line
2183         of the function as this may look at return values (when processing
2184         a declaration).
2185         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2186         (FunctionDetectionTest.perform_function_detection): Basic mechanics
2187         of testing the function detection.
2188         (FunctionDetectionTest.test_basic_function_detection): Test a simple
2189         function.
2190         (FunctionDetectionTest.test_function_declaration_detection): Test a
2191         declaration.
2192         (FunctionDetectionTest.test_non_functions): A test case for a case
2193         that caused the code to fail due to the { being in quotes.
2194         (PassPtrTest.test_pass_ref_ptr_return_value): Added some more test
2195         cases to help catch false alarms for return values.
2196         (PassPtrTest.test_pass_ref_ptr_member_variable): Ensure that
2197         we don't get false alarms for member variables either.
2198
2199 2010-12-20  Ryuan Choi  <ryuan.choi@samsung.com>
2200
2201         Reviewed by Antonio Gomes.
2202
2203         [CMAKE] Rename WEBKITTOOLS_DIR to TOOLS_DIR
2204         https://bugs.webkit.org/show_bug.cgi?id=51319
2205
2206         * CMakeListsEfl.txt:
2207
2208 2010-12-18  Adam Barth  <abarth@webkit.org>
2209
2210         Reviewed by Sam Weinig.
2211
2212         Move WebKitExamplePlugins to Examples
2213         https://bugs.webkit.org/show_bug.cgi?id=51291
2214
2215         * Scripts/webkitpy/common/config/build.py:
2216
2217 2010-12-17  Csaba Osztrogonác  <ossy@webkit.org>
2218
2219         Unreviewed Qt buildfix after r74301.
2220
2221         Rename WebKitTools to Tools
2222         https://bugs.webkit.org/show_bug.cgi?id=49861
2223
2224         * MiniBrowser/DerivedSources.pro:
2225         * MiniBrowser/qt/MiniBrowser.pro:
2226
2227 2010-12-17  Dan Bernstein  <mitz@apple.com>
2228
2229         Reviewed by Simon Fraser.
2230
2231         Rename WebKitTools to Tools
2232         https://bugs.webkit.org/show_bug.cgi?id=49861
2233
2234         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2235         * CodeCoverage/README:
2236         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2237         (WebCore::DumpRenderTree::initializeFonts):
2238         * EWSTools/start-commit-queue.sh:
2239         * EWSTools/start-queue.sh:
2240         * GNUmakefile.am:
2241         * MIDLWrapper/MIDLWrapper.cpp:
2242         (wmain):
2243         * MiniBrowser/qt/MiniBrowser.pro:
2244         * Scripts/build-api-tests:
2245         * Scripts/build-dumprendertree:
2246         * Scripts/build-webkit:
2247         * Scripts/build-webkittestrunner:
2248         * Scripts/generate-coverage-data:
2249         * Scripts/old-run-webkit-tests:
2250         * Scripts/run-api-tests:
2251         * Scripts/run-iexploder-tests:
2252         * Scripts/run-javascriptcore-tests:
2253         * Scripts/run-mangleme-tests:
2254         * Scripts/run-sunspider:
2255         * Scripts/run-webkit-websocketserver:
2256         * Scripts/sunspider-compare-results:
2257         * Scripts/test-webkitperl:
2258         * Scripts/test-webkitpy:
2259         * Scripts/update-iexploder-cssproperties:
2260         * Scripts/update-webkit:
2261         * Scripts/update-webkit-localizable-strings:
2262         * Scripts/webkitdirs.pm:
2263         * Scripts/webkitpy/common/checkout/scm.py:
2264         * Scripts/webkitpy/common/checkout/scm_unittest.py:
2265         * Scripts/webkitpy/common/config/committervalidator.py:
2266         * Scripts/webkitpy/common/config/committervalidator_unittest.py:
2267         * Scripts/webkitpy/common/config/ports.py:
2268         * Scripts/webkitpy/common/config/ports_unittest.py:
2269         * Scripts/webkitpy/common/system/logutils_unittest.py:
2270         * Scripts/webkitpy/common/system/ospath_unittest.py:
2271         * Scripts/webkitpy/layout_tests/port/chromium.py:
2272         * Scripts/webkitpy/layout_tests/port/config.py:
2273         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
2274         * Scripts/webkitpy/layout_tests/port/http_server.py:
2275         * Scripts/webkitpy/layout_tests/port/test.py:
2276         * Scripts/webkitpy/style/checker.py:
2277         * Scripts/webkitpy/style/checker_unittest.py:
2278         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
2279         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2280         * Scripts/webkitpy/tool/steps/steps_unittest.py:
2281         * WebKitTestRunner/DerivedSources.pro:
2282         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
2283         (WTR::activateFonts):
2284         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2285         * wx/build/build_utils.py:
2286
2287 2010-12-16  Antonio Gomes  <agomes@rim.com>
2288
2289         Reviewed by Martin Robinson.
2290
2291         Settings::editingBehaviorType() incorrectly returns mac for the gtk build when running tests
2292         https://bugs.webkit.org/show_bug.cgi?id=51163
2293
2294         Since GTK+'s default editing behavior was changed to UNIX in r70975 (see webkitwebsettings.cpp),
2295         GTK+'s DRT should also reset to UNIX after each test execution.
2296
2297         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2298         (resetDefaultsToConsistentValues):
2299
2300 2010-12-17  David Levin  <levin@chromium.org>
2301
2302         Reviewed by Eric Seidel.
2303
2304         check-webkit-style should understand WTF #include guards
2305         https://bugs.webkit.org/show_bug.cgi?id=44911
2306
2307         * Scripts/webkitpy/style/checkers/cpp.py:
2308         (get_header_guard_cpp_variable): modify to suggest the WTF style
2309         of header guard when appropriate.
2310         (check_for_header_guard): handle multiple return values from
2311         get_header_guard_cpp_variable
2312         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2313         (CppStyleTest.test_build_header_guard): Added tests for the WTF
2314         header style.
2315
2316 2010-12-16  David Levin  <levin@chromium.org>
2317
2318         Reviewed by Eric Seidel.
2319
2320         test-webkitpy: unittest for the xml.py checker displays a decprecation warning.
2321         https://bugs.webkit.org/show_bug.cgi?id=51210
2322
2323         The error only shows up when using python 2.6 or later.
2324
2325         * Scripts/webkitpy/style/checkers/xml.py: Replace the usage of
2326         the decprecated field error,message with something equivalent.
2327
2328 2010-12-16  Mihai Parparita  <mihaip@chromium.org>
2329
2330         Reviewed by Eric Seidel.
2331
2332         Add --exit-after-n-failures/crashes to NRWT
2333         https://bugs.webkit.org/show_bug.cgi?id=51160
2334
2335         Abort test run (in a similar way to how control-C is handled) when
2336         --exit-after-n-failures/crashes-or-timeouts are passed and we've reached
2337         that number of unexpected failures/crashes/timeouts.
2338
2339         * Scripts/webkitpy/layout_tests/port/test.py:
2340         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2341         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2342
2343 2010-12-16  David Levin  <levin@chromium.org>
2344
2345         Reviewed by Shinichiro Hamaji.
2346
2347         check-webkit-style unit tests has some duplicate boilerplate code.
2348         https://bugs.webkit.org/show_bug.cgi?id=49519
2349
2350         * Scripts/webkitpy/style/checkers/cpp.py:
2351         (update_include_state): Replaced the "io" parameter with the global
2352         configuration _unit_test_config. This allowed not calling into
2353         functions at a low level and also not plumbing through the injection
2354         information through many levels of code.
2355         (check_for_include_what_you_use): Ditto.
2356         (process_file_data): Added the ability to set up the unit test config
2357         to allow for injection.
2358         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2359         (ErrorCollector.__init__): Added support for having a filter for errors.
2360         (ErrorCollector.__call__): Ditto.
2361         (CppStyleTestBase.process_file_data): Added the ability to set unit_test_config.
2362         (CppStyleTestBase.perform_lint): Consolidated logic for the perform functions.
2363         (CppStyleTestBase.perform_single_line_lint): Replace specific calls to
2364         functions in the cpp.py with generic processing and a filter that
2365         indicates what errors should be kept.
2366         (CppStyleTestBase.perform_multi_line_lint): Ditto.
2367         (CppStyleTestBase.perform_language_rules_check): Ditto.
2368         (CppStyleTestBase.perform_function_lengths_check): Ditto.
2369         (CppStyleTestBase.perform_pass_ptr_check): Ditto.
2370         (CppStyleTestBase.perform_include_what_you_use): Ditto.
2371         (CppStyleTest.test_multi_line_comments): Added another
2372         error message which applies to the test case.
2373         (CppStyleTest.test_spacing_for_binary_ops): Fixed test
2374         to not have config.h, since it is processed as a header file.
2375         (CppStyleTest.test_static_or_global_stlstrings): Fixed variable name
2376         style and indentation in checked code.
2377         (OrderOfIncludesTest.test_check_preprocessor_in_include_section):
2378         Fixed line number.
2379         (NoNonVirtualDestructorsTest.test_multi_line_declaration_with_error):
2380         Ditto.
2381
2382 2010-12-15  Sheriff Bot  <webkit.review.bot@gmail.com>
2383
2384         Unreviewed, rolling out r74136.
2385         http://trac.webkit.org/changeset/74136
2386         https://bugs.webkit.org/show_bug.cgi?id=51135
2387
2388         r74136 breaks chromium canary bots because some tests are not
2389         rebaselined correctly to resolve EOL differences (Requested by
2390         jianli on #webkit).
2391
2392         * Scripts/webkitpy/layout_tests/port/base.py:
2393         * Scripts/webkitpy/layout_tests/port/test.py:
2394         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
2395
2396 2010-12-15  Adam Roben  <aroben@apple.com>
2397
2398         Teach check-webkit-style to check .vcproj and .vsprops files for XML
2399         syntax errors
2400
2401         Fixes <http://webkit.org/b/51103> check-webkit-style should check for
2402         XML syntax errors in .vcproj/.vsprops files
2403
2404         Reviewed by Dave Levin.
2405
2406         * Scripts/webkitpy/style/checker.py: Added lists of file extensions
2407         that should be treated as XML and that should be allowed to contain
2408         carriage returns. (These lists happen to be identical currently.)
2409         (FileType): Added a new XML type.
2410         (CheckerDispatcher.should_check_and_strip_carriage_returns): Added.
2411         Just does a simple file extension check.
2412         (CheckerDispatcher._file_type): Added a case for XML files.
2413         (CheckerDispatcher._create_checker): Ditto. We use XMLChecker for XML
2414         files (surprise!).
2415         (StyleProcessor.process): Ask the dispatcher whether we should pass the
2416         lines through the carriage checker.
2417
2418         * Scripts/webkitpy/style/checker_unittest.py:
2419         (CheckerDispatcherCarriageReturnTest.test_should_check_and_strip_carriage_returns):
2420         Added. Checks a few file names to see if carriage returns are allowed
2421         or not.
2422         (CheckerDispatcherDispatchTest.assert_checker_xml): Added. Similar to
2423         other assert_checker_* functions.
2424         (CheckerDispatcherDispatchTest.test_xml_paths): Added. Similar to other
2425         test_*_paths functions.
2426         (CheckerDispatcherDispatchTest.test_xml_paths): Added. Similar to other
2427         test_*_paths functions.
2428         (CheckerDispatcherDispatchTest.test_none_paths): Removed the vcproj
2429         file from this test case, as vcproj files now have a type.
2430         (StyleProcessor_CodeCoverageTest.MockDispatcher.should_check_and_strip_carriage_returns):
2431         Added. Similar to the other should_* functions.
2432         (StyleProcessor_CodeCoverageTest.test_process__carriage_returns_not_stripped):
2433         Added. Checks that carriage returns aren't checked for or stripped for
2434         allowed files.
2435
2436         * Scripts/webkitpy/style/checkers/xml.py: Added.
2437         (XMLChecker.__init__): Simple init method.
2438         (XMLChecker.check): Pass each line through the expat parser, and record
2439         a style error for any errors thrown by the parser.
2440
2441         * Scripts/webkitpy/style/checkers/xml_unittest.py: Added.
2442         (XMLCheckerTest.assert_no_error): Checks that the given XML does not
2443         produce a style error.
2444         (XMLCheckerTest.assert_error): Checks that the given XML produces an
2445         error of the given category on the given line.
2446         (XMLCheckerTest.mock_handle_style_error): Does nothing. Used for
2447         checking that the XMLChecker constructor works properly.
2448         (XMLCheckerTest.test_conflict_marker): Tests that conflict markers
2449         cause a style error (see, e.g., r73887).
2450         (XMLCheckerTest.test_extra_closing_tag): Tests that extra closing tags
2451         cause a style error (see, e.g., r73773).
2452         (XMLCheckerTest.test_init): Tests that the XMLChecker constructor works
2453         properly.
2454         (XMLCheckerTest.test_missing_closing_tag): Tests that missing closing
2455         tags cause a style error (see, e.g., r72795).
2456         (XMLCheckerTest.test_no_error): Tests that valid XML does not cause a
2457         style error.
2458
2459 2010-12-15  Lucas Forschler  <lforschler@apple.com>
2460
2461         Reviewed by Stephanie Lewis.
2462
2463         https://bugs.webkit.org/show_bug.cgi?id=51117
2464         Add a new leopard test bot
2465         really really commit to trunk this time.
2466
2467         * BuildSlaveSupport/build.webkit.org-config/config.json:
2468
2469 2010-12-15  Sam Weinig  <sam@webkit.org>
2470
2471         Reviewed by Anders Carlsson.
2472
2473         WebKit2: Can't add files to an <input type=file>
2474         https://bugs.webkit.org/show_bug.cgi?id=51087
2475
2476         * MiniBrowser/mac/BrowserWindowController.m:
2477         (runOpenPanel):
2478         (-[BrowserWindowController awakeFromNib]):
2479         Add simple implementation of runOpenPanel callback.
2480
2481         * MiniBrowser/win/BrowserView.cpp:
2482         (BrowserView::create):
2483         * WebKitTestRunner/TestController.cpp:
2484         (WTR::createOtherPage):
2485         (WTR::TestController::initialize):
2486         Stub out runOpenPanel callback.
2487
2488 2010-12-14  Eric Seidel  <eric@webkit.org>
2489
2490         Reviewed by Adam Barth.
2491
2492         commit-queue should upload failure diffs when tests flake
2493         https://bugs.webkit.org/show_bug.cgi?id=51051
2494
2495         To make this testable I needed to pipe FileSystem down onto tool.
2496         We've wanted it there for a long time anyway.
2497
2498         This patch is kinda a big hack.  But we don't have a nice
2499         way to read results.html files.  I think this will need further
2500         revision before this code actually feels clean.
2501
2502         As part of testing this change, I had to make MockBugzilla.create_bug
2503         actually return an id (like it should) which required updating
2504         a few other unit test results (for the better).
2505
2506         The results_matching_keys change in layouttestresults/rebasline
2507         was an alternate path which I decided not to use in the end, but
2508         I left the change as it seemed an improvement.
2509
2510         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2511         * Scripts/webkitpy/common/net/layouttestresults.py:
2512         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2513         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2514         * Scripts/webkitpy/tool/commands/queues.py:
2515         * Scripts/webkitpy/tool/commands/rebaseline.py:
2516         * Scripts/webkitpy/tool/main.py:
2517         * Scripts/webkitpy/tool/mocktool.py:
2518
2519 2010-12-15  Cosmin Truta  <ctruta@chromium.org>
2520
2521         Reviewed by James Robinson.
2522
2523         new-run-webkit-tests ignores trailing EOL differences in text tests
2524         https://bugs.webkit.org/show_bug.cgi?id=36983
2525
2526         Changed the handling of new-line characters within new-run-webkit-tests
2527         to match old-run-webkit-tests.  Differences in leading and trailing empty
2528         lines in text expectation files are no longer ignored.
2529
2530         * Scripts/webkitpy/layout_tests/port/base.py:
2531         * Scripts/webkitpy/layout_tests/port/test.py:
2532         Added unit tests.  Removed old duplicate unit test entries.
2533         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
2534
2535 2010-12-15  Ojan Vafai  <ojan@chromium.org>
2536
2537         Reviewed by Adam Barth.
2538
2539         make status-bubble white-space:nowrap so we can measure it's width without wrapping
2540         https://bugs.webkit.org/show_bug.cgi?id=51149
2541
2542         * QueueStatusServer/templates/statusbubble.html:
2543
2544 2010-12-15  Ojan Vafai  <ojan@chromium.org>
2545
2546         Reviewed by Adam Barth.
2547
2548         have the statusbubble postMessage it's metrics so that embedders can properly size the iframe
2549         https://bugs.webkit.org/show_bug.cgi?id=51125
2550
2551         * QueueStatusServer/templates/statusbubble.html:
2552
2553 2010-12-15  Darin Adler  <darin@apple.com>
2554
2555         * Scripts/webkitpy/common/net/buildbot: Added property svn:ignore.
2556
2557 2010-12-15  Sheriff Bot  <webkit.review.bot@gmail.com>
2558
2559         Unreviewed, rolling out r74117.
2560         http://trac.webkit.org/changeset/74117
2561         https://bugs.webkit.org/show_bug.cgi?id=51113
2562
2563         This broke the GTK1 build. (Requested by mrobinson on
2564         #webkit).
2565
2566         * Scripts/webkitdirs.pm:
2567
2568 2010-12-15  Amruth Raj  <amruthraj@motorola.com> and Ravi Kasibhatla  <ravi.kasibhatla@motorola.com>
2569
2570         Reviewed by Martin Robinson.
2571
2572         Change generate-forwarding-headers.pl for GTK port usage
2573         (https://bugs.webkit.org/show_bug.cgi?id=37369)
2574
2575         * Scripts/webkitdirs.pm: Added changes to build webkit2 for GTK port using build-webkit script.
2576
2577 2010-12-14  Kent Tamura  <tkent@chromium.org>
2578
2579         Reviewed by Jian Li.
2580
2581         [DRT/Chromium] Remove another unnecessary error message
2582         https://bugs.webkit.org/show_bug.cgi?id=51083
2583
2584         * DumpRenderTree/chromium/WebViewHost.cpp:
2585         (WebViewHost::didInvalidateRect):
2586
2587 2010-12-14  Lucas Forschler  <lforschler@apple.com>
2588
2589         Reviewed by Stephanie Lewis.
2590
2591         Add a new Leopard Debug Test WK2 Bot
2592
2593         * BuildSlaveSupport/build.webkit.org-config/config.json:
2594
2595 2010-12-14  Ojan Vafai  <ojan@chromium.org>
2596
2597         Fix python unittests after http://trac.webkit.org/changeset/74070.
2598
2599         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
2600
2601 2010-12-14  Kent Tamura  <tkent@chromium.org>
2602
2603         Reviewed by Jian Li.
2604
2605         [DRT/Chromium] Remove a unnecessary error message
2606         https://bugs.webkit.org/show_bug.cgi?id=51069
2607
2608         * DumpRenderTree/chromium/WebViewHost.cpp:
2609         (WebViewHost::paintInvalidatedRegion):
2610
2611 2010-12-14  Benjamin Kalman  <kalman@chromium.org>
2612
2613         Reviewed by Ojan Vafai.
2614
2615         Using BUG/BUGWK in test_expectations is error prone, should use BUGCR/BUGWK
2616         https://bugs.webkit.org/show_bug.cgi?id=48926
2617
2618         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2619         Add presubmit check that BUG isn't used, either BUGCR/BUGWK/BUGV8_.
2620
2621 2010-12-14  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2622
2623         Reviewed by Eric Seidel.
2624
2625         [Qt] [Symbian] Do not use pkg-config on Symbian as it is not supported
2626         https://bugs.webkit.org/show_bug.cgi?id=50231
2627
2628         Guard CONFIG+=link_pkgconfig with !symbian.
2629
2630         * DumpRenderTree/qt/DumpRenderTree.pro:
2631         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2632         * WebKitTestRunner/qt/WebKitTestRunner.pro:
2633
2634 2010-12-14  Philippe Normand  <pnormand@igalia.com>
2635
2636         Reviewed by Ojan Vafai.
2637
2638         [new-run-webkit-tests] expectations parsing is slow
2639         https://bugs.webkit.org/show_bug.cgi?id=50635
2640
2641         Avoid expensive iteration of all the tests when checking if a test
2642         file is to be skipped or not.
2643
2644         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2645         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
2646         * Scripts/webkitpy/layout_tests/port/test.py:
2647
2648 2010-12-14  Mario Sanchez Prada  <msanchez@igalia.com>
2649
2650         Reviewed by Xan Lopez.
2651
2652         [Gtk] Implement STATE_FOCUSED, STATE_FOCUSABLE, and corresponding events for text objects
2653         https://bugs.webkit.org/show_bug.cgi?id=27048
2654
2655         Add support in DRT for checking whether an accessibility UI
2656         element is focusable and/or focused. Implemented for GTK.
2657
2658         * DumpRenderTree/AccessibilityUIElement.cpp:
2659         (getIsFocusedCallback): New.
2660         (getIsFocusableCallback): New.
2661         (AccessibilityUIElement::getJSClass): Add the new available
2662         callbacks for isFocused and isFocusable.
2663         * DumpRenderTree/AccessibilityUIElement.h:
2664         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2665         (AccessibilityUIElement::isFocused): New, implemented by checking
2666         whether the related AtkState value is in the object's state set.
2667         (AccessibilityUIElement::isFocusable): Ditto.
2668         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2669         (AccessibilityUIElement::isFocused): New, dummy implementation.
2670         (AccessibilityUIElement::isFocusable): Ditto.
2671         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2672         (AccessibilityUIElement::isFocused): Ditto.
2673         (AccessibilityUIElement::isFocusable): Ditto.
2674
2675 2010-12-14  Eric Seidel  <eric@webkit.org>
2676
2677         Reviewed by Ojan Vafai.
2678
2679         webkit-patch should warn users when they're using a 32-bit git on a 64-bit system
2680         https://bugs.webkit.org/show_bug.cgi?id=50715
2681
2682         This patch makes webkit-patch print the following:
2683
2684         Warning: This machine is 64-bit, but the git binary (/usr/local/git/bin/git) does not support 64-bit.
2685         Install a 64-bit git for better performance, see:
2686         https://lists.webkit.org/pipermail/webkit-dev/2010-December/015249.html
2687
2688         I wrote this mostly because I have approximately 8 machines that I use
2689         and making sure each one is using a good Git install seemed folly.
2690         webkit-patch makes a lot of git calls, so using a fast git can shave
2691         several seconds in every invocation.  See the webkit-dev thread for more info.
2692
2693         This message will print twice during 'webkit-patch upload',
2694         once from webkit-patch and once from check-webkit-style.
2695
2696         Unfortunately there is no good way to test this due to how machine-dependent
2697         the code is.  I considered writing a test for the log message, but it seemed not worth it.
2698
2699         * Scripts/webkitpy/common/checkout/scm.py:
2700
2701 2010-12-13  Eric Seidel  <eric@webkit.org>
2702
2703         Reviewed by Adam Barth.
2704
2705         FlakyTestReporter doesn't understand bots running from multiple email addresses
2706         https://bugs.webkit.org/show_bug.cgi?id=50960
2707
2708         This explains at least one of the dupes of:
2709         https://bugs.webkit.org/show_bug.cgi?id=50863
2710         that we saw filed by the commit-queue this morning.
2711         I think the other one was explained by my previous fix to result counting code.
2712
2713         Since this is really hard to test with a unit test, instead I
2714         create a new (possibly useful in the future) command
2715         which given a layout test path will return you
2716         the one bug which our tools would assume it the flaky test bug.
2717         If some other script wants to use bug-for-test we'll
2718         need to extend it with some options like --create-if-missing or similar.
2719
2720         * Scripts/webkitpy/common/net/bugzilla/bug.py:
2721         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2722         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2723         * Scripts/webkitpy/tool/commands/__init__.py:
2724         * Scripts/webkitpy/tool/commands/bugfortest.py: Added.
2725
2726 2010-12-13  Mihai Parparita  <mihaip@chromium.org>
2727
2728         Reviewed by James Robinson.
2729
2730         Add option to build-webkit to not build WebKit2
2731         https://bugs.webkit.org/show_bug.cgi?id=50988
2732
2733         Add support for a --no-webkit2 option to build-webkit. It seems to save
2734         ~1 minute from clean builds and ~10 seconds from no-op builds.
2735
2736         * Scripts/build-webkit:
2737
2738 2010-12-13  Lucas Forschler  <lforschler@apple.com>
2739
2740         Reviewed by Dave Kilzer.
2741
2742         Update iexploder from 1.3.2 to 1.7.2
2743         Move 1.3.2 into its own subdir
2744         Add 1.7.2 into its own subdir
2745         update scripts to point to new 1.3.2 location (avoid breaking existing scripts)
2746
2747         * Scripts/run-iexploder-tests:
2748         * Scripts/update-iexploder-cssproperties:
2749         * iExploder/CHANGELOG.txt: Removed.
2750         * iExploder/LICENSE.txt: Removed.
2751         * iExploder/README.txt: Removed.
2752         * iExploder/htdocs: Removed.
2753         * iExploder/iexploder-1.3.2: Added.
2754         * iExploder/iexploder-1.3.2/CHANGELOG.txt: Copied from iExploder/CHANGELOG.txt.
2755         * iExploder/iexploder-1.3.2/LICENSE.txt: Copied from iExploder/LICENSE.txt.
2756         * iExploder/iexploder-1.3.2/README.txt: Copied from iExploder/README.txt.
2757         * iExploder/iexploder-1.3.2/htdocs: Added.
2758         * iExploder/iexploder-1.3.2/htdocs/config.rb: Copied from iExploder/htdocs/config.rb.
2759         * iExploder/iexploder-1.3.2/htdocs/cssproperties.in: Copied from iExploder/htdocs/cssproperties.in.
2760         * iExploder/iexploder-1.3.2/htdocs/cssvalues.in: Copied from iExploder/htdocs/cssvalues.in.
2761         * iExploder/iexploder-1.3.2/htdocs/htmlattrs.in: Copied from iExploder/htdocs/htmlattrs.in.
2762         * iExploder/iexploder-1.3.2/htdocs/htmltags.in: Copied from iExploder/htdocs/htmltags.in.
2763         * iExploder/iexploder-1.3.2/htdocs/htmlvalues.in: Copied from iExploder/htdocs/htmlvalues.in.
2764         * iExploder/iexploder-1.3.2/htdocs/iexploder.cgi: Copied from iExploder/htdocs/iexploder.cgi.
2765         * iExploder/iexploder-1.3.2/htdocs/iexploder.rb: Copied from iExploder/htdocs/iexploder.rb.
2766         * iExploder/iexploder-1.3.2/htdocs/index.html: Copied from iExploder/htdocs/index.html.
2767         * iExploder/iexploder-1.3.2/htdocs/webserver.rb: Copied from iExploder/htdocs/webserver.rb.
2768         * iExploder/iexploder-1.3.2/tools: Added.
2769         * iExploder/iexploder-1.3.2/tools/lasthit.rb: Copied from iExploder/tools/lasthit.rb.
2770         * iExploder/iexploder-1.3.2/tools/osx_last_crash.rb: Copied from iExploder/tools/osx_last_crash.rb.
2771         * iExploder/iexploder-1.3.2/tools/showtest.rb: Copied from iExploder/tools/showtest.rb.
2772         * iExploder/iexploder-1.7.2: Added.
2773         * iExploder/iexploder-1.7.2/ChangeLog.txt: Added.
2774         * iExploder/iexploder-1.7.2/LICENSE.txt: Added.
2775         * iExploder/iexploder-1.7.2/README.txt: Added.
2776         * iExploder/iexploder-1.7.2/output: Added.
2777         * iExploder/iexploder-1.7.2/src: Added.
2778         * iExploder/iexploder-1.7.2/src/browser_harness.rb: Added.
2779         * iExploder/iexploder-1.7.2/src/config.yaml: Added.
2780         * iExploder/iexploder-1.7.2/src/css-atrules: Added.
2781         * iExploder/iexploder-1.7.2/src/css-atrules/mozilla: Added.
2782         * iExploder/iexploder-1.7.2/src/css-atrules/webkit: Added.
2783         * iExploder/iexploder-1.7.2/src/css-properties: Added.
2784         * iExploder/iexploder-1.7.2/src/css-properties/dillo: Added.
2785         * iExploder/iexploder-1.7.2/src/css-properties/gtkhtml: Added.
2786         * iExploder/iexploder-1.7.2/src/css-properties/internet_explorer6: Added.
2787         * iExploder/iexploder-1.7.2/src/css-properties/mozilla: Added.
2788         * iExploder/iexploder-1.7.2/src/css-properties/webkit: Added.
2789         * iExploder/iexploder-1.7.2/src/css-pseudo: Added.
2790         * iExploder/iexploder-1.7.2/src/css-pseudo/mozilla: Added.
2791         * iExploder/iexploder-1.7.2/src/css-pseudo/webkit: Added.
2792         * iExploder/iexploder-1.7.2/src/css-values: Added.
2793         * iExploder/iexploder-1.7.2/src/css-values/dillo: Added.
2794         * iExploder/iexploder-1.7.2/src/css-values/gtkhtml: Added.
2795         * iExploder/iexploder-1.7.2/src/css-values/mozilla: Added.
2796         * iExploder/iexploder-1.7.2/src/css-values/other: Added.
2797         * iExploder/iexploder-1.7.2/src/css-values/webkit: Added.
2798         * iExploder/iexploder-1.7.2/src/headers: Added.
2799         * iExploder/iexploder-1.7.2/src/headers/dillo: Added.
2800         * iExploder/iexploder-1.7.2/src/headers/gtkhtml: Added.
2801         * iExploder/iexploder-1.7.2/src/headers/mozilla: Added.
2802         * iExploder/iexploder-1.7.2/src/headers/webkit: Added.
2803         * iExploder/iexploder-1.7.2/src/html-attrs: Added.
2804         * iExploder/iexploder-1.7.2/src/html-attrs/dillo: Added.
2805         * iExploder/iexploder-1.7.2/src/html-attrs/gtkhtml: Added.
2806         * iExploder/iexploder-1.7.2/src/html-attrs/internet_explorer6: Added.
2807         * iExploder/iexploder-1.7.2/src/html-attrs/mozilla: Added.
2808         * iExploder/iexploder-1.7.2/src/html-attrs/other: Added.
2809         * iExploder/iexploder-1.7.2/src/html-attrs/webkit: Added.
2810         * iExploder/iexploder-1.7.2/src/html-tags: Added.
2811         * iExploder/iexploder-1.7.2/src/html-tags/dillo: Added.
2812         * iExploder/iexploder-1.7.2/src/html-tags/gtkhtml: Added.
2813         * iExploder/iexploder-1.7.2/src/html-tags/mozilla: Added.
2814         * iExploder/iexploder-1.7.2/src/html-tags/other: Added.
2815         * iExploder/iexploder-1.7.2/src/html-tags/webkit: Added.
2816         * iExploder/iexploder-1.7.2/src/html-values: Added.
2817         * iExploder/iexploder-1.7.2/src/html-values/dillo: Added.
2818         * iExploder/iexploder-1.7.2/src/html-values/gtkhtml: Added.
2819         * iExploder/iexploder-1.7.2/src/html-values/mozilla: Added.
2820         * iExploder/iexploder-1.7.2/src/html-values/other: Added.
2821         * iExploder/iexploder-1.7.2/src/html-values/webkit: Added.
2822         * iExploder/iexploder-1.7.2/src/iexploder.cgi: Added.
2823         * iExploder/iexploder-1.7.2/src/iexploder.rb: Added.
2824         * iExploder/iexploder-1.7.2/src/index.html: Added.
2825         * iExploder/iexploder-1.7.2/src/media: Added.
2826         * iExploder/iexploder-1.7.2/src/media/blank.ogg: Added.
2827         * iExploder/iexploder-1.7.2/src/media/blank.snd: Added.
2828         * iExploder/iexploder-1.7.2/src/media/blank.wav: Added.
2829         * iExploder/iexploder-1.7.2/src/media/bug.bmp: Added.
2830         * iExploder/iexploder-1.7.2/src/media/bug.gif: Added.
2831         * iExploder/iexploder-1.7.2/src/media/bug.ico: Added.
2832         * iExploder/iexploder-1.7.2/src/media/bug.jng: Added.
2833         * iExploder/iexploder-1.7.2/src/media/bug.jpg: Added.
2834         * iExploder/iexploder-1.7.2/src/media/bug.png: Added.
2835         * iExploder/iexploder-1.7.2/src/media/bug.svg: Added.
2836         * iExploder/iexploder-1.7.2/src/media/bug.tiff: Added.
2837         * iExploder/iexploder-1.7.2/src/media/bug.xbm: Added.
2838         * iExploder/iexploder-1.7.2/src/media/bug.xpm: Added.
2839         * iExploder/iexploder-1.7.2/src/mime-types: Added.
2840         * iExploder/iexploder-1.7.2/src/mime-types/dillo: Added.
2841         * iExploder/iexploder-1.7.2/src/mime-types/mozilla: Added.
2842         * iExploder/iexploder-1.7.2/src/mime-types/webkit: Added.
2843         * iExploder/iexploder-1.7.2/src/protocols: Added.
2844         * iExploder/iexploder-1.7.2/src/protocols/dillo: Added.
2845         * iExploder/iexploder-1.7.2/src/protocols/gtkhtml: Added.
2846         * iExploder/iexploder-1.7.2/src/protocols/mozilla: Added.
2847         * iExploder/iexploder-1.7.2/src/protocols/webkit: Added.
2848         * iExploder/iexploder-1.7.2/src/scanner.rb: Added.
2849         * iExploder/iexploder-1.7.2/src/version.rb: Added.
2850         * iExploder/iexploder-1.7.2/src/webserver.rb: Added.
2851         * iExploder/iexploder-1.7.2/testcases: Added.
2852         * iExploder/iexploder-1.7.2/testcases/testcase-Linux_x86_64_rv2.0b6pre_Gecko-20100904_Firefox-4.0b6pre-TEST-8375-1_59.html: Added.
2853         * iExploder/iexploder-1.7.2/testcases/testcase-Opera-9.80_Linux_x86_64_en_Presto-2.6.30_Version-10.61-16704-3_108,3.html: Added.
2854         * iExploder/iexploder-1.7.2/testcases/testcase-U_Intel_Mac_OS_X_10_6_4_en-US_AppleWebKit-534.8_Chrome-7.0.529.0-TEST-611-3_36,9.html: Added.
2855         * iExploder/iexploder-1.7.2/testcases/testcase-U_Intel_Mac_OS_X_10_6_4_en-US_AppleWebKit-534.8_hrome-7.0.529.0-TEST-55313622206-3_6,0.html: Added.
2856         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.6_Chrome-7.0.503.1-TEST-120813-8_72,56,24,8,0.html: Added.
2857         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.6_Chrome-7.0.503.1-TEST-121240-3_81,3.html: Added.
2858         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.7_Chrome-7.0.513.0-4800-5_80,65,15.html: Added.
2859         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.7_Chrome-7.0.513.0-TEST-23583190347-3_15,12.html: Added.
2860         * iExploder/iexploder-1.7.2/tools: Added.
2861         * iExploder/iexploder-1.7.2/tools/lasthit.rb: Added.
2862         * iExploder/iexploder-1.7.2/tools/osx_last_crash.rb: Added.
2863         * iExploder/iexploder-1.7.2/tools/release_src.sh: Added.
2864         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh: Added.
2865         * iExploder/tools: Removed.
2866
2867 2010-12-13  Sam Weinig  <sam@webkit.org>
2868
2869         Reviewed by Anders Carlsson.
2870
2871         Remove associated page concept from WKView constructor
2872         https://bugs.webkit.org/show_bug.cgi?id=50983
2873
2874         Step 1: Remove associate page constructors from WKView and make
2875         all views use the shared namespace for the context.
2876
2877         * TestWebKitAPI/PlatformWebView.h:
2878         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
2879         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
2880         * WebKitTestRunner/PlatformWebView.h:
2881         * WebKitTestRunner/TestController.cpp:
2882         (WTR::createOtherPage):
2883         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2884         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2885         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2886
2887 2010-12-13  Sam Weinig  <sam@webkit.org>
2888
2889         Reviewed by Anders Carlsson.
2890
2891         Change the WebKit2 public API so there is no explicit WKPageNamespace object
2892         https://bugs.webkit.org/show_bug.cgi?id=50898
2893
2894         * MiniBrowser/mac/AppDelegate.h:
2895         * MiniBrowser/mac/AppDelegate.m:
2896         * MiniBrowser/mac/BrowserWindowController.h:
2897         * MiniBrowser/mac/BrowserWindowController.m:
2898         * MiniBrowser/win/BrowserView.cpp:
2899         Convert MiniBrowser to not use PageNamespaces.
2900
2901         * TestWebKitAPI/PlatformWebView.h:
2902         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
2903         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
2904         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
2905         * TestWebKitAPI/Tests/WebKit2/Find.cpp:
2906         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
2907         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
2908         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
2909         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
2910         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
2911         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
2912         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
2913         * TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp:
2914         * TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp:
2915         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
2916         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
2917         Convert TestWebKitAPI to not use PageNamespaces.
2918
2919         * WebKitTestRunner/PlatformWebView.h:
2920         * WebKitTestRunner/TestController.cpp:
2921         * WebKitTestRunner/TestController.h:
2922         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2923         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2924         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2925         Convert WebKitTestRunner to not use PageNamespaces.
2926
2927 2010-12-13  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
2928
2929         Reviewed by Eric Seidel.
2930
2931         webkit-patch rollout should be able to do multi-revision rollouts
2932         https://bugs.webkit.org/show_bug.cgi?id=33336
2933
2934         Make it possible to pass more than one revision to webkit-patch.
2935
2936         * Scripts/webkitpy/common/checkout/api.py:
2937         * Scripts/webkitpy/common/checkout/changelog.py:
2938         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2939         * Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:
2940         * Scripts/webkitpy/tool/commands/download.py:
2941         * Scripts/webkitpy/tool/commands/download_unittest.py:
2942         * Scripts/webkitpy/tool/mocktool.py:
2943         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
2944         * Scripts/webkitpy/tool/steps/revertrevision.py:
2945
2946 2010-12-13  Eric Seidel  <eric@webkit.org>
2947
2948         Unreviewed.
2949
2950         Teach webkit-patch how to search bugzilla
2951         https://bugs.webkit.org/show_bug.cgi?id=50500
2952
2953         webkit-patch bug-search fails when there is only one result.
2954         Turns out we needed a bit more logic in our result count parsing code.
2955
2956         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2957         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
2958
2959 2010-12-13  Antti Koivisto  <antti@apple.com>
2960
2961         Reviewed by Alexey Proskuryakov.
2962
2963         Add setSerializeHTTPLoads function to allow testing resource load order on OS X.
2964         https://bugs.webkit.org/show_bug.cgi?id=50758
2965
2966         * DumpRenderTree/LayoutTestController.cpp:
2967         (setSerializeHTTPLoadsCallback):
2968         (LayoutTestController::staticFunctions):
2969         * DumpRenderTree/LayoutTestController.h:
2970         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2971         (LayoutTestController::setSerializeHTTPLoads):
2972         * DumpRenderTree/mac/DumpRenderTree.mm:
2973         (resetDefaultsToConsistentValues):
2974         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2975         (LayoutTestController::setSerializeHTTPLoads):
2976         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2977         (LayoutTestController::setSerializeHTTPLoads):
2978
2979 2010-12-13  Dimitri Glazkov  <dglazkov@chromium.org>
2980
2981         Reviewed by Ojan Vafai.
2982
2983         Remove "use-drt" option from test step command line, since the option was removed in r73748.
2984         https://bugs.webkit.org/show_bug.cgi?id=50936
2985
2986         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Removed the option.
2987
2988 2010-12-13  Patrick Gansterer  <paroga@webkit.org>
2989
2990         Reviewed by Csaba Osztrogonác.
2991
2992         Add revlink to BuildBot status
2993         https://bugs.webkit.org/show_bug.cgi?id=50914
2994
2995         This adds a hyperlink to trac changeset on the revision numbers.
2996
2997         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2998
2999 2010-12-13  Andras Becsi  <abecsi@webkit.org>
3000
3001         Reviewed by Csaba Osztrogonác.
3002
3003         [Qt][WK2] Fix build if WebKitTools are not available
3004         https://bugs.webkit.org/show_bug.cgi?id=50242
3005
3006         * MiniBrowser/qt/MiniBrowser.pro: Correct the comment.
3007         * Scripts/webkitdirs.pm: Added WebKitTools/MiniBrowser to $subdirs.
3008         * MiniBrowser/DerivedSources.pro: Added.
3009
3010 2010-12-13  Eric Seidel  <eric@webkit.org>
3011
3012         Reviewed by Adam Barth.
3013
3014         EWS Queues should remove orpahned pyc files before starting
3015         https://bugs.webkit.org/show_bug.cgi?id=50904
3016
3017         A previous check added a platform.py which caused
3018         EWS bots on some platforms to hit an import exception.
3019         The platform.py file was removed in a subsequent commit, but
3020         the EWS bots in question stayed stuck.  This change will
3021         fix those bots once restarted (and prevent this in the future).
3022
3023         I also went ahead and unified start-queue and start-commit-queue
3024         since they were nearly identical.  I also added bot_id support
3025         to both force all EWSes to have bot ids as well as get rid of the one
3026         remaining reason why I had my own copies of these scripts.
3027         Hopefully this will be enough to get all the other bot admins
3028         (ahem, Adam, ahem) to move to using these checked in copies as well.
3029
3030         * EWSTools/start-commit-queue.sh: Removed.
3031         * EWSTools/start-queue.sh:
3032
3033 2010-10-28  MORITA Hajime  <morrita@google.com>
3034
3035         Reviewed by Ojan Vafai.
3036
3037         spellcheck does not check pasted text
3038         https://bugs.webkit.org/show_bug.cgi?id=40092
3039
3040         Added LayoutTestController::setAsynchronousSpellCheckingEnabled()
3041         to control the setting.
3042
3043         * DumpRenderTree/LayoutTestController.cpp:
3044         (setAsynchronousSpellCheckingEnabledCallback):
3045         (LayoutTestController::staticFunctions):
3046         * DumpRenderTree/LayoutTestController.h:
3047         * DumpRenderTree/chromium/LayoutTestController.h:
3048         * DumpRenderTree/chromium/LayoutTestController.cpp:
3049         (LayoutTestController::LayoutTestController):
3050         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
3051         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3052         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
3053         * DumpRenderTree/mac/DumpRenderTree.mm:
3054         (resetDefaultsToConsistentValues):
3055         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3056         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
3057         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3058         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3059         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
3060         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3061         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
3062         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3063         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
3064
3065 2010-12-12  Sam Weinig  <sam@webkit.org>
3066
3067         Reviewed by Anders Carlsson.
3068
3069         Fix failing API test. It turns out that a pop-state event
3070         is sent before every fragment navigation, so we have to test
3071         for it in addition in PageLoadDidChangeLocationWithinPageForFrame.
3072
3073         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
3074         (TestWebKitAPI::didSameDocumentNavigationForFrame):
3075
3076 2010-12-12  Alejandro G. Castro  <alex@igalia.com>
3077
3078         Reviewed by Eric Seidel.
3079
3080         [GTK] Add new-run-webkit-tests support to gtk
3081         https://bugs.webkit.org/show_bug.cgi?id=50681
3082
3083         Adding the basic support to run the new-run-webkit-tests.
3084
3085         * Scripts/webkitpy/layout_tests/port/gtk.py:
3086
3087 2010-10-11  Diego Gonzalez  <diegohcg@webkit.org>
3088
3089         Reviewed by Kenneth Rohde Christiansen.
3090
3091         [Qt] Mock DeviceOrientation client for DRT
3092         https://bugs.webkit.org/show_bug.cgi?id=47490
3093
3094         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3095         (WebCore::DumpRenderTree::DumpRenderTree):
3096         (WebCore::DumpRenderTree::~DumpRenderTree):
3097         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3098         (LayoutTestController::setMockDeviceOrientation):
3099
3100 2010-12-11  Philippe Normand  <pnormand@igalia.com>
3101
3102         Reviewed by Gustavo Noronha Silva.
3103
3104         [GTK] launcher: disable the Mozilla-style fullscreen API
3105         https://bugs.webkit.org/show_bug.cgi?id=50874
3106
3107         Disabling the fullscreen API until its implementation for GTK is
3108         mature enough. The webview setting for it is already FALSE by
3109         default.
3110
3111         * GtkLauncher/main.c:
3112         (createWindow):
3113
3114 2010-12-10  Eric Seidel  <eric@webkit.org>
3115
3116         Reviewed by Adam Barth.
3117
3118         commit-queue flaky test messages show cryptic version information for mac os x
3119         https://bugs.webkit.org/show_bug.cgi?id=50864
3120
3121         Turns out platform.platform() returns kernel version information
3122         which isn't helpful, and just plain confusing on Mac
3123         (OS X 10.6.5 uses Darwin Kernel 10.5.0).
3124
3125         So I've updated PlatformInfo.display_name() to special case
3126         mac.  I also found a bad use of sys.platform in the process
3127         and fixed that.  (sys.platform always returns 'darwin' on mac).
3128
3129         * Scripts/webkitpy/common/system/platforminfo.py:
3130         * Scripts/webkitpy/common/system/user.py:
3131         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3132         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3133         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3134
3135 2010-12-10  Eric Seidel  <eric@webkit.org>
3136
3137         Unreviewed.
3138
3139         Exception seen while reporting flaky test with commit-queue.
3140         Just a missing include.
3141
3142         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3143         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3144
3145 2010-12-10  Kinuko Yasuda  <kinuko@chromium.org>
3146
3147         Reviewed by Eric Seidel.
3148
3149         [Chromium] Remove old JSONResultsGenerator script that existed for backward-compatibility
3150         https://bugs.webkit.org/show_bug.cgi?id=50796
3151
3152         Also updating the test code to use JSONResultsGeneratorBase and
3153         to improve test coverage for incremental cases.
3154
3155         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3156         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
3157
3158 2010-12-10  Joseph Pecoraro  <joepeck@webkit.org>
3159
3160         Reviewed by Darin Adler.
3161
3162         prepare-ChangeLog --help doesn't mention --bug shorthand -b
3163         https://bugs.webkit.org/show_bug.cgi?id=50835
3164
3165         * Scripts/prepare-ChangeLog: be more explicit about -b and match file style.
3166
3167 2010-12-10  Eric Seidel  <eric@webkit.org>
3168
3169         Reviewed by Adam Barth.
3170
3171         Bugs created by the commit-queue should all block on a master bug
3172         https://bugs.webkit.org/show_bug.cgi?id=50857
3173
3174         This makes all bugs created by the commit-queue block on:
3175         https://bugs.webkit.org/show_bug.cgi?id=50856
3176
3177         In the process of testing this, I found that the existing
3178         create_bug code was wrong.  I also found that existing
3179         unit tests for create-rollout used invalid values
3180         for options.blocks.  I fixed both issues and tested.
3181
3182         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3183         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3184         * Scripts/webkitpy/tool/commands/commandtest.py:
3185         * Scripts/webkitpy/tool/commands/download_unittest.py:
3186         * Scripts/webkitpy/tool/commands/upload_unittest.py:
3187         * Scripts/webkitpy/tool/mocktool.py:
3188         * Scripts/webkitpy/tool/steps/options.py:
3189
3190 2010-12-10  Eric Seidel  <eric@webkit.org>
3191
3192         Reviewed by Adam Barth.
3193
3194         Teach webkitpy how to follow duplicate chains when posting comments on flake bugs
3195         https://bugs.webkit.org/show_bug.cgi?id=50853
3196
3197         I also discovered when doing this that the code was posting
3198         the comment on the wrong bug, but that's fixed here too.
3199
3200         * Scripts/webkitpy/common/net/bugzilla/bug.py:
3201         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3202         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3203         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3204         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3205         * Scripts/webkitpy/tool/mocktool.py:
3206
3207 2010-12-10  Anders Carlsson  <andersca@apple.com>
3208
3209         Reviewed by John Sullivan.
3210
3211         Make WKContextGetStatistics gather global statistics
3212         https://bugs.webkit.org/show_bug.cgi?id=50850
3213
3214         Remove the code that gets the statistics and fills in the per context
3215         statistics information for now.
3216
3217         * MiniBrowser/mac/BrowserStatisticsWindowController.m:
3218         (-[BrowserStatisticsWindowController refreshStatistics:]):
3219
3220 2010-12-10  Eric Seidel  <eric@webkit.org>
3221
3222         Unreviewed.
3223
3224         commit-queue should report port/platform information when commenting on flaky test bugs
3225         https://bugs.webkit.org/show_bug.cgi?id=50839
3226
3227         Renamed platform.py to platforminfo.py.  This broke import platform in executive.py
3228         which was only used by new run webkit tests (and clearly not unit tested).
3229
3230         * Scripts/webkitpy/common/system/platforminfo.py: Renamed from WebKitTools/Scripts/webkitpy/common/system/platform.py.
3231         * Scripts/webkitpy/tool/main.py:
3232         * Scripts/webkitpy/tool/mocktool.py:
3233
3234 2010-12-10  Eric Seidel  <eric@webkit.org>
3235
3236         Reviewed by Tony Chang.
3237
3238         commit-queue should report port/platform information when commenting on flaky test bugs
3239         https://bugs.webkit.org/show_bug.cgi?id=50839
3240
3241         This was a suggestion from Tony Chang this morning.
3242         I added a platform.py class so I could easily mock the platform call,
3243         but that may not be the final solution for this mocking.
3244         We'll try it and see.
3245
3246         * Scripts/webkitpy/common/system/platform.py: Added.
3247         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3248         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3249         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3250         * Scripts/webkitpy/tool/main.py:
3251         * Scripts/webkitpy/tool/mocktool.py:
3252
3253 2010-12-10  Krithigassree Sambamurthy  <krithigassree.sambamurthy@nokia.com>
3254
3255         Reviewed by Joseph Pecoraro.
3256
3257         Bug 43455 - [Qt]: Implement Application Cache Quotas
3258         https://bugs.webkit.org/show_bug.cgi?id=43455
3259
3260         Introduce functions to allow new appcache layout test origin-quota.html
3261         to work correctly under Qt.
3262
3263         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3264         (WebCore::DumpRenderTree::DumpRenderTree):
3265         (WebCore::DumpRenderTree::dumpApplicationCacheQuota):
3266         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3267
3268         Introduce functions to allow new appcache layout test origin-quota.html
3269         to be successful under qt. Changes required because LayoutTestControllerQt
3270         does not inherit from LayoutController.
3271
3272         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3273         (LayoutTestController::reset):
3274         (LayoutTestController::clearAllApplicationCaches):
3275         (LayoutTestController::setApplicationCacheOriginQuota):
3276         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3277         (LayoutTestController::shouldDumpApplicationCacheDelegateCallbacks):
3278         (LayoutTestController::dumpApplicationCacheDelegateCallbacks):
3279
3280 2010-12-10  Eric Seidel  <eric@webkit.org>
3281
3282         Reviewed by Adam Barth.
3283
3284         Move buildbot.py into its own module so we can split it out into one-file-per-class
3285         https://bugs.webkit.org/show_bug.cgi?id=50806
3286
3287         We're adding more buildbot logic these days, so it makes sense
3288         to give buildbot its own module.
3289
3290         * Scripts/webkitpy/common/net/buildbot/__init__.py: Added.
3291         * Scripts/webkitpy/common/net/buildbot/buildbot.py: Renamed from WebKitTools/Scripts/webkitpy/common/net/buildbot.py.
3292         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py: Renamed from WebKitTools/Scripts/webkitpy/common/net/buildbot_unittest.py.
3293         * Scripts/webkitpy/common/net/failuremap.py:
3294         * Scripts/webkitpy/common/net/regressionwindow.py:
3295         * Scripts/webkitpy/tool/commands/rebaseline.py:
3296
3297 2010-12-10  Tony Chang  <tony@chromium.org>
3298
3299         Reviewed by Eric Seidel.
3300
3301         Use FileSystem::remove when cleaning up http lock files
3302         https://bugs.webkit.org/show_bug.cgi?id=50830
3303
3304         * Scripts/webkitpy/layout_tests/port/http_lock.py:
3305
3306 2010-12-10  Joone Hur  <joone@kldp.org>
3307
3308         Reviewed by Martin Robinson.
3309
3310         [GTK] DRT needs layoutTestController.setCacheModel
3311         https://bugs.webkit.org/show_bug.cgi?id=50705
3312
3313         webkit_set_cache_mode() is called to set the cache model.
3314
3315         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3316         (LayoutTestController::setCacheModel): Set the cache model.
3317
3318 2010-12-10  Tony Chang  <tony@chromium.org>
3319
3320         Reviewed by Ojan Vafai.
3321
3322         [chromium] remove --use-drt and add --use-test-shell
3323         https://bugs.webkit.org/show_bug.cgi?id=50701
3324
3325         * Scripts/webkitpy/common/config/ports.py:
3326         * Scripts/webkitpy/common/config/ports_unittest.py:
3327         * Scripts/webkitpy/layout_tests/port/chromium.py:
3328         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
3329         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
3330         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3331         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3332         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3333         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3334         * Scripts/webkitpy/layout_tests/port/webkit.py:
3335         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3336         * Scripts/webkitpy/style/checkers/test_expectations.py:
3337         * Scripts/webkitpy/tool/commands/queries.py:
3338
3339 2010-12-10  John Knottenbelt  <jknotten@chromium.org>
3340
3341         Reviewed by Steve Block.
3342
3343         [Chromium] Implement mocks for client-based geolocation
3344         https://bugs.webkit.org/show_bug.cgi?id=46895
3345
3346         * DumpRenderTree/chromium/LayoutTestController.cpp:
3347         (LayoutTestController::setGeolocationPermission):
3348         (LayoutTestController::setMockGeolocationPosition):
3349         (LayoutTestController::setMockGeolocationError):
3350         * DumpRenderTree/chromium/LayoutTestController.h:
3351         * DumpRenderTree/chromium/WebViewHost.cpp:
3352         (WebViewHost::geolocationClient):
3353         (WebViewHost::geolocationClientMock):
3354         (WebViewHost::reset):
3355         * DumpRenderTree/chromium/WebViewHost.h:
3356
3357 2010-12-10  Alejandro G. Castro  <alex@igalia.com>
3358
3359         Reviewed by Martin Robinson.
3360
3361         [GTK] Add hasSpellingMarker support to the DRT
3362         https://bugs.webkit.org/show_bug.cgi?id=50739
3363
3364         Implemented the hasSpellingMarker to support spelling tests.
3365
3366         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3367         (LayoutTestController::hasSpellingMarker):
3368
3369 2010-12-10  Eric Seidel  <eric@webkit.org>
3370
3371         Reviewed by Ojan Vafai.
3372
3373         webkit-patch: not possible to use build-and-test with local commits
3374         https://bugs.webkit.org/show_bug.cgi?id=33378
3375
3376         Make --no-clean not even check if we have local commits.
3377         It's unclear to me why the code was originally written this way.
3378         I was unable to dig up a reason from svn history.
3379
3380         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
3381         * Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py: Copied from WebKitTools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.
3382
3383 2010-12-10  Mario Sanchez Prada  <msanchez@igalia.com>
3384
3385         Reviewed by Martin Robinson.
3386
3387         [GTK] AX: implement isEnabled in DRT
3388         https://bugs.webkit.org/show_bug.cgi?id=50814
3389
3390         Implement AccessibilityUIElement::isEnabled() for GTK.
3391
3392         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3393         (checkElementState): New function to refactor common code.
3394         (AccessibilityUIElement::isEnabled): Implement this by checking
3395         the current state of the AtkObject.
3396         (AccessibilityUIElement::isSelected): Use the new
3397         checkElementState function.
3398
3399 2010-12-10  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
3400
3401         Reviewed by Kenneth Rohde Christiansen.
3402
3403         [Qt][WK2] Add the QWKContext API class to wrap the WebContext.
3404         https://bugs.webkit.org/show_bug.cgi?id=50750
3405
3406         * MiniBrowser/qt/BrowserView.cpp:
3407         (BrowserView::BrowserView):
3408         * MiniBrowser/qt/BrowserView.h:
3409         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3410         (WTR::WebView::WebView):
3411
3412 2010-12-10  Joone Hur  <joone@kldp.org>
3413
3414         Reviewed by Xan Lopez.
3415
3416         [GTK] Unskipping some test cases in userscripts dependent on addUserStyleSheet
3417         https://bugs.webkit.org/show_bug.cgi?id=50808
3418
3419         Unskipping the following test cases:
3420         userscripts/mixed-case-stylesheet.html
3421         userscripts/simple-stylesheet.html
3422         userscripts/user-style-all-frames.html
3423
3424         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3425         (LayoutTestController::addUserStyleSheet):
3426
3427 2010-12-10  Joone Hur  <joone@kldp.org>
3428
3429         Reviewed by Eric Seidel.
3430
3431         [GTK] Add DRT support for pageProperty, isPageBoxVisible, pageSizeAndMarginsInPixels, and addUserStyleSheet
3432         https://bugs.webkit.org/show_bug.cgi?id=50783
3433
3434         This patch allows to unskip the following test cases:
3435         printing/page-rule-selection.html
3436         printing/page-format-data.html
3437
3438         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3439         (LayoutTestController::pageProperty): Added.
3440         (LayoutTestController::isPageBoxVisible): Ditto.
3441         (LayoutTestController::pageSizeAndMarginsInPixels): Ditto.
3442         (LayoutTestController::addUserStyleSheet): Ditto.
3443
3444 2010-12-10  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
3445
3446         Reviewed by Kenneth Rohde Christiansen.
3447
3448         [Qt] Make QtTestBrowser spawn QNAM in a secondary thread.
3449
3450         A menu allows to switch QNAM back to the same thread.
3451
3452         * QtTestBrowser/launcherwindow.cpp:
3453         (LauncherWindow::initializeView):
3454         (LauncherWindow::createChrome):
3455         (LauncherWindow::toggleThreadedQnam):
3456         * QtTestBrowser/launcherwindow.h:
3457         (WindowOptions::WindowOptions):
3458         * QtTestBrowser/webpage.cpp:
3459         (WebPage::WebPage):
3460         (WebPage::setQnamThreaded):
3461         * QtTestBrowser/webpage.h:
3462         (QnamThread::QnamThread):
3463         (QnamThread::~QnamThread):
3464         (QnamThread::networkAccessManager):
3465         (QnamThread::run):
3466
3467 2010-12-10  Martin Robinson  <mrobinson@igalia.com>
3468
3469         Reviewed by Xan Lopez.
3470
3471         [Gtk] style="font-family: courier" makes text disappear
3472         https://bugs.webkit.org/show_bug.cgi?id=47452
3473
3474         Add a test that verifies that fonts without valid charmaps are
3475         never selected.
3476
3477         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3478         (initializeFonts): Initialize DRT with our font (derived from Ahem)
3479         that has no valid charmap.
3480         * DumpRenderTree/gtk/fonts/FontWithNoValidEncoding.fon: Added.
3481         * DumpRenderTree/gtk/fonts/fonts.conf: Updated settings to override users'
3482         settings which may disable selection of bitmap fonts.
3483
3484 2010-12-10  Eric Seidel  <eric@webkit.org>
3485
3486         Unreviewed.
3487
3488         The commit-queue should file bugs about flaky tests it encounters
3489         https://bugs.webkit.org/show_bug.cgi?id=50803
3490
3491         create_bug_for_flaky_test was insufficiently tested, thus buggy.
3492         Now it's tested.
3493
3494         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3495         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3496
3497 2010-12-10  Eric Seidel  <eric@webkit.org>
3498
3499         Unreviewed.  Somehow this last-minute edit didn't quite get committed.
3500
3501         The commit-queue should file bugs about flaky tests it encounters
3502         https://bugs.webkit.org/show_bug.cgi?id=50803
3503
3504         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3505
3506 2010-12-09  Eric Seidel  <eric@webkit.org>
3507
3508         Reviewed by Adam Barth.
3509
3510         The commit-queue should file bugs about flaky tests it encounters
3511         https://bugs.webkit.org/show_bug.cgi?id=50803
3512
3513         This change got a bit big.  I also added a new config.urls file
3514         because I needed to share the view_source_url code with committervalidator.py.
3515
3516         This adds a new class FlakyTestReporter which holds all the logic about
3517         reporting flaky tests to bugzilla.
3518
3519         Right now this code knows how to look up bugs for flaky tests.
3520         If it can't find a bug filed from the commit-queue, it will open a new
3521         one, ccing the relevant people and adding information about the failure.
3522
3523         It is not yet smart enough to chase down duplicate chains, or to include
3524         the actual failure diff.  But those can be added in later iterations.
3525
3526         * Scripts/webkitpy/common/checkout/api.py:
3527         * Scripts/webkitpy/common/checkout/changelog.py:
3528         * Scripts/webkitpy/common/checkout/commitinfo.py:
3529         * Scripts/webkitpy/common/config/committervalidator.py:
3530         * Scripts/webkitpy/common/config/urls.py: Copied from WebKitTools/Scripts/webkitpy/tool/comments.py.
3531         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3532         * Scripts/webkitpy/tool/bot/flakytestreporter.py: Added.
3533         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py: Copied from WebKitTools/Scripts/webkitpy/tool/comments.py.
3534         * Scripts/webkitpy/tool/bot/irc_command.py:
3535         * Scripts/webkitpy/tool/bot/sheriff.py:
3536         * Scripts/webkitpy/tool/commands/download.py:
3537         * Scripts/webkitpy/tool/commands/queues.py:
3538         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3539         * Scripts/webkitpy/tool/comments.py:
3540         * Scripts/webkitpy/tool/mocktool.py:
3541         * Scripts/webkitpy/tool/steps/commit.py:
3542
3543 2010-12-09  Eric Seidel  <eric@webkit.org>
3544
3545         Reviewed by Adam Barth.
3546
3547         Teach webkit-patch how to search bugzilla
3548         https://bugs.webkit.org/show_bug.cgi?id=50500
3549
3550         This is a step towards teaching webkitpy how to file
3551         new bugs for flaky tests and update them when new flakes occur.
3552
3553         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3554         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
3555         * Scripts/webkitpy/tool/commands/__init__.py:
3556         * Scripts/webkitpy/tool/commands/bugsearch.py: Added.
3557
3558 2010-12-09  Adam Barth  <abarth@webkit.org>
3559
3560         Reviewed by Ojan Vafai.
3561
3562         commit-queue errors out due to local commits
3563         https://bugs.webkit.org/show_bug.cgi?id=50766
3564
3565         We seem to be tripping over having local commits in the working copy a
3566         lot recently.  I don't quite fully understand what the issue is, but
3567         this patch attempts to solve the problem by adding an explicit clean
3568         step before processing a patch.  Previously, we did the cleaning as
3569         part of the apply-attachment step, so this might not actually fix the
3570         problem.
3571
3572         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3573         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3574         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3575
3576 2010-12-09  Dirk Pranke  <dpranke@chromium.org>
3577
3578         Reviewed by Ojan Vafai.
3579
3580         Make new-run-webkit-tests --lint-test-files log slightly better
3581         messages and return -1 if lint fails. Remove the
3582         'suppress_errors' keyword param to the TestExpectationsFile
3583         class, and clean up logging and exception raising for error
3584         handling. Also add more unit tests and clean up the unit test code a bit.
3585
3586         https://bugs.webkit.org/show_bug.cgi?id=50205
3587
3588         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3589         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3590         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py
3591         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py
3592         * Scripts/webkitpy/layout_tests/port/chromium.py:
3593         * Scripts/webkitpy/style/checkers/test_expectations.py:
3594         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
3595
3596 2010-12-09  Tony Chang  <tony@chromium.org>
3597
3598         Unreviewed, fix for windows code.  We were catching the wrong
3599         exception in Windows.
3600
3601         * Scripts/webkitpy/common/system/filesystem.py:
3602
3603 2010-12-09  Antonio Gomes  <agomes@rim.com>
3604
3605         Reviewed by Martin Robinson.
3606
3607         [Gtk] Populate DumpRenderTreeSupportGtk (part IV)
3608         https://bugs.webkit.org/show_bug.cgi?id=48429
3609
3610         Adjust call sites of webkit_thread_count to use the DumpRenderTreeSupportGtk version now.
3611
3612         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3613         (LayoutTestController::workerThreadCount):
3614
3615 2010-12-06  Philippe Normand  <pnormand@igalia.com>
3616
3617         Reviewed by Martin Robinson.
3618
3619         [GTK] Support the Mozilla-style Fullscreen Javascript API
3620         https://bugs.webkit.org/show_bug.cgi?id=50572
3621
3622         Enable the Javascript Fullscreen support in the GtkLauncher. Also
3623         make DRT update the Chrome when the WebView settings have been
3624         reset to consistent values.
3625
3626         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3627         (resetDefaultsToConsistentValues):
3628         * GtkLauncher/main.c:
3629         (create_window):
3630         * Scripts/build-webkit:
3631
3632 2010-12-09  Koan-Sin Tan  <koansin.tan@gmail.com>
3633
3634         Reviewed by Tor Arne Vestbø
3635
3636         [Qt] run-launcher doesn't start the browser on Mac OS X 10.6
3637         https://bugs.webkit.org/show_bug.cgi?id=50742
3638
3639         check not only QtWebKit.framework/QtWebKit but also libQtWebKit.dylib
3640
3641         * Scripts/webkitdirs.pm:
3642
3643 2010-12-09  Joone Hur  <joone@kldp.org>
3644
3645          Reviewed by Martin Robinson.
3646
3647          [GTK] Support for viewport meta tag
3648          https://bugs.webkit.org/show_bug.cgi?id=45443
3649
3650          Add support for testing the viewport properties for WebKitGtk.
3651
3652          * DumpRenderTree/LayoutTestController.cpp:
3653          (dumpConfigurationForViewportCallback): Added this JS callback to set the size of the visible viewport.
3654          (LayoutTestController::staticFunctions):
3655          * DumpRenderTree/LayoutTestController.h:
3656          * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3657          (LayoutTestController::dumpConfigurationForViewport): Added this function to test the viewport properties.
3658          * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3659          (LayoutTestController::dumpConfigurationForViewport): Ditto.
3660          * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3661          (LayoutTestController::dumpConfigurationForViewport): Ditto.
3662          * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3663          (LayoutTestController::dumpConfigurationForViewport): Ditto.
3664          * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3665          (LayoutTestController::dumpConfigurationForViewport): Ditto.
3666
3667 2010-12-08  William Siegrist <wsiegrist@apple.com>
3668
3669         Reviewed by Eric Seidel.
3670
3671         Migrate buildbot.py from xmlrpc to json.
3672         https://bugs.webkit.org/show_bug.cgi?id=50647
3673
3674         * Scripts/webkitpy/common/net/buildbot.py:
3675
3676 2010-12-08  Tony Chang  <tony@chromium.org>
3677
3678         Reviewed by Eric Seidel.
3679
3680         make starting the websocket server more reliable on windows
3681         https://bugs.webkit.org/show_bug.cgi?id=50712
3682
3683         * Scripts/webkitpy/common/system/filesystem.py:
3684         (remove): Substitute method for os.remove to retry on error on Windows
3685         * Scripts/webkitpy/common/system/filesystem_unittest.py:
3686         * Scripts/webkitpy/layout_tests/port/http_server_base.py: Use FileSystem.remove
3687
3688 2010-12-08  Jessie Berlin  <jberlin@apple.com>
3689
3690         Reviewed by Adam Roben.
3691
3692         WebKit2: Implement WebChromeClient::exceededDatabaseQuota
3693         https://bugs.webkit.org/show_bug.cgi?id=50656
3694
3695         * MiniBrowser/mac/BrowserWindowController.m:
3696         (-[BrowserWindowController awakeFromNib]):
3697         Indicate that exceededDatabaseQuota is not implemented.
3698         * MiniBrowser/win/BrowserView.cpp:
3699         (BrowserView::create):
3700         Ditto.
3701         * WebKitTestRunner/TestController.cpp:
3702         (WTR::createOtherPage):
3703         Ditto.
3704         (WTR::TestController::initialize):
3705         Ditto.
3706
3707 2010-12-08  Antonio Gomes  <agomes@rim.com>
3708
3709         Reviewed by Martin Robinson.
3710
3711         [Gtk] Populate DumpRenderTreeSupportGtk (part III)
3712         https://bugs.webkit.org/show_bug.cgi?id=48429
3713
3714         Moved the following methods from webkitprivate.h to DumpRenderTreeSupportGtk.cpp|h:
3715         * webkit_gc_collect_javascript_objects;
3716         * webkit_gc_collect_javascript_objects_on_alternate_thread;
3717         * webkit_gc_count_javascript_objects;
3718         * webkit_web_frame_layout.
3719
3720         These were all only used by GTK+ DRT.
3721
3722         * DumpRenderTree/gtk/EventSender.cpp:
3723         (dispatchEvent):
3724         * DumpRenderTree/gtk/GCControllerGtk.cpp:
3725         (GCController::collect):
3726         (GCController::collectOnAlternateThread):
3727         (GCController::getJSObjectCount):