8cbfcc3eb0c0479c3bd0a38805bbc65af042cbd5
[WebKit.git] / Tools / ChangeLog
1 2011-01-18  Mihai Parparita  <mihaip@chromium.org>
2
3         Reviewed by Kent Tamura.
4
5         [Chromium] NRWT looking for DRT binary in the wrong path on Mac
6         https://bugs.webkit.org/show_bug.cgi?id=52678
7         
8         Update path now that WebKit is inside Source.
9
10         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
11
12 2011-01-18  Robert Hogan  <robert@webkit.org>
13
14         Reviewed by Simon Hausmann.
15
16         [Qt] http/tests/incremental/slow-utf8-text.pl fails
17         https://bugs.webkit.org/show_bug.cgi?id=44282
18
19         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
20         (WebCore::DumpRenderTree::dump):
21
22 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
23
24         Reviewed by Mihai Parparita.
25
26         Fix a small race condition that could cause the unit tests for
27         new-run-webkit-tests to fail in a multithreaded environment.
28         There was a small window in the code where one thread would
29         check to see if a thread had raised an exception, do something,
30         and then check to see if the thread was alive. If the other
31         thread raised an exception and exited in between these two
32         steps, the exception would be lost. Flipping the order of the
33         two checks fixes the race, since we will now always check for an
34         exception on the thread before exiting.
35
36         https://bugs.webkit.org/show_bug.cgi?id=51579
37
38         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
39
40 2011-01-18  Eric Seidel  <eric@webkit.org>
41
42         Reviewed by Adam Barth.
43
44         commit-queue dies when test archiving fails
45         https://bugs.webkit.org/show_bug.cgi?id=52617
46
47         I looked at the machine and it had 10 archives already
48         thus find_unused_name was returning None.  I've upped
49         the limit to 100 (per bug) and tested the case where
50         find_unused_name returns None (making archive return None).
51
52         * Scripts/webkitpy/common/system/workspace.py:
53         * Scripts/webkitpy/common/system/workspace_unittest.py:
54         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
55         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
56         * Scripts/webkitpy/tool/commands/queues.py:
57
58 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
59
60         Reviewed by Ojan Vafai.
61
62         Update rebaseline-chromium-webkit-tests unit tests to use a mock
63         filesystem. Also fix a couple of "with" statements missed by
64         r76050.
65
66         https://bugs.webkit.org/show_bug.cgi?id=52487
67
68         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
69
70 2011-01-18  Sergio Villar Senin  <svillar@igalia.com>
71
72         Reviewed by Martin Robinson.
73
74         [Gtk] Build fixes for gtk3 build
75         https://bugs.webkit.org/show_bug.cgi?id=52648
76
77         * DumpRenderTree/gtk/EventSender.cpp:
78         (beginDragWithFilesCallback):
79
80 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
81
82         Reviewed by Mihai Parparita.
83
84         Update rebaseline-chromium-webkit-tests to use filesystem objects
85         instead of direct references to os.path, shutil, tempfile, etc.
86
87         This patch doesn't change anything, but will allow subsequent
88         patches to change the unit tests to no longer use the real
89         filesystem.
90
91         This patch adds a bunch more methods to the filesystem object as
92         well.
93
94         https://bugs.webkit.org/show_bug.cgi?id=52482
95
96         * Scripts/webkitpy/common/system/filesystem.py:
97         * Scripts/webkitpy/common/system/filesystem_mock.py:
98         * Scripts/webkitpy/tool/commands/queues.py:
99         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
100         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
101
102 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
103
104         Reviewed by Mihai Parparita.
105
106         new-run-webkit-tests shouldn't crash when you try to run a
107         directory containing only skipped files.
108
109         https://bugs.webkit.org/show_bug.cgi?id=52478
110         
111         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
112         * Scripts/webkitpy/layout_tests/port/test.py:
113         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
114
115 2011-01-18  Adam Bergkvist  <adam.bergkvist@ericsson.com> and Martin Robinson  <mrobinson@igalia.com>
116
117         Reviewed by Gustavo Noronha Silva.
118
119         [GTK] The GTK+ EventSender needs support for beginDragWithFiles
120         https://bugs.webkit.org/show_bug.cgi?id=40833
121
122         * DumpRenderTree/gtk/EventSender.cpp: Add a beginDragWithFiles implementation for the
123         GTK+ event sender.
124         (dragWithFilesDragDataGetCallback): Added.
125         (dragWithFilesDragEndCallback): Added.
126         (beginDragWithFilesCallback): Added.
127
128 2011-01-18  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
129
130         Reviewed by Adam Barth.
131
132         ews: Add additional watcher to efl ews
133         https://bugs.webkit.org/show_bug.cgi?id=52613
134
135         Add gyuyoung.kim@samsung.com to watcher list of efl-ews.
136
137         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
138
139 2011-01-17  Tony Gentilcore  <tonyg@chromium.org>
140
141         Reviewed by Alexey Proskuryakov.
142
143         Fix some headers with missing or misspelled #ifndef guards
144         https://bugs.webkit.org/show_bug.cgi?id=52545
145
146         * DumpRenderTree/chromium/TestEventPrinter.h:
147         * DumpRenderTree/chromium/WebPreferences.h:
148
149 2011-01-17  Jessie Berlin  <jberlin@apple.com>
150
151         Reviewed by Anders Carlsson.
152
153         REGRESSION: Assertion failure in FrameLoader::continueLoadAfterWillSubmitForm() when
154         navigating back to an unreachable URL
155         https://bugs.webkit.org/show_bug.cgi?id=52388
156
157         Add a third parameter (unreachableURL) to queueLoadHTMLString.
158
159         * DumpRenderTree/LayoutTestController.cpp:
160         (queueLoadHTMLStringCallback):
161         (LayoutTestController::queueLoadHTMLString):
162         (LayoutTestController::queueLoadAlternateHTMLString):
163         * DumpRenderTree/LayoutTestController.h:
164
165         * DumpRenderTree/WorkQueueItem.h:
166         (LoadHTMLStringItem::LoadHTMLStringItem):
167
168         * DumpRenderTree/chromium/LayoutTestController.cpp:
169         (WorkItemLoadHTMLString::WorkItemLoadHTMLString):
170         (WorkItemLoadHTMLString::run):
171         (LayoutTestController::queueLoadHTMLString):
172
173         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
174         (LoadHTMLStringItem::invoke):
175         * DumpRenderTree/mac/WorkQueueItemMac.mm:
176         (LoadHTMLStringItem::invoke):
177         * DumpRenderTree/win/WorkQueueItemWin.cpp:
178         (LoadHTMLStringItem::invoke):
179
180 2011-01-17  Dan Bernstein  <mitz@apple.com>
181
182         Rubber-stamped by Mark Rowe.
183
184         Update xcodeproj svn:ignore to include xcuserdata.
185
186         * DumpRenderTree/DumpRenderTree.xcodeproj: Modified property svn:ignore.
187         * MiniBrowser/MiniBrowser.xcodeproj: Modified property svn:ignore.
188         * TestWebKitAPI/TestWebKitAPI.xcodeproj: Modified property svn:ignore.
189         * WebKitLauncher/WebKitLauncher.xcodeproj: Modified property svn:ignore.
190         * WebKitTestRunner/WebKitTestRunner.xcodeproj: Modified property svn:ignore.
191
192 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
193
194         Unreviewed fix after r75908.
195
196         Move WebKit into Source
197         https://bugs.webkit.org/show_bug.cgi?id=52530
198
199         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add Source to the path for Qt API tests.
200
201 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
202
203         Unreviewed.
204
205         Remove accidentally committed debug printing after r75908.
206
207         * Scripts/webkitdirs.pm:
208
209 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
210
211         Unreviewed.
212
213         Add myself to committers list
214         https://bugs.webkit.org/show_bug.cgi?id=52566
215
216         * Scripts/webkitpy/common/config/committers.py:
217
218 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
219
220         Reviewed by Jeremy Orlow.
221
222         GeolocationController should call stopUpdating on destruction
223         https://bugs.webkit.org/show_bug.cgi?id=52216
224
225         fast/dom/Geolocation/window-close-crash.html requires that a
226         Geolocation watch be started in a secondary window. Consequently,
227         we need to allow geolocation permission and provide a mock
228         geolocation position for the secondary window's
229         GeolocationClientMock.
230
231         * DumpRenderTree/chromium/LayoutTestController.cpp:
232         (LayoutTestController::setGeolocationPermission):
233         (LayoutTestController::setMockGeolocationPosition):
234         (LayoutTestController::setMockGeolocationError):
235         * DumpRenderTree/chromium/TestShell.h:
236         (TestShell::windowList):
237
238 2011-01-16  Adam Barth  <abarth@webkit.org>
239
240         Update more include paths to reflect WebKit move.
241
242         * DumpRenderTree/chromium/EventSender.cpp:
243         (EventSender::keyDown):
244         (EventSender::needsShiftModifier):
245         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
246         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
247
248 2011-01-16  Kent Tamura  <tkent@chromium.org>
249
250         Unreviewed, Chromium build fix.
251
252         * Scripts/update-webkit-chromium: Webkit/chromium -> Source/WebKit/chromium
253
254 2011-01-16  Martin Robinson  <mrobinson@igalia.com>
255
256         Build fix for GTK+ after source directory movement.
257
258         * GNUmakefile.am: Correct include paths.
259
260 2011-01-16  Adam Barth  <abarth@webkit.org>
261
262         Teach svn-apply about WebKit move.
263
264         * Scripts/VCSUtils.pm:
265
266 2011-01-16  Adam Barth  <abarth@webkit.org>
267
268         Rubber-stamped by Eric Seidel.
269
270         Move WebKit into Source
271         https://bugs.webkit.org/show_bug.cgi?id=52530
272
273         * DumpRenderTree/mac/InternalHeaders/WebKit/WebTypesInternal.h:
274         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
275         * DumpRenderTree/qt/DumpRenderTreeQt.h:
276         * DumpRenderTree/qt/GCControllerQt.cpp:
277         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
278         * DumpRenderTree/qt/PlainTextControllerQt.cpp:
279         * DumpRenderTree/qt/TextInputControllerQt.cpp:
280         * DumpRenderTree/wscript:
281         * QtTestBrowser/launcherwindow.h:
282         * Scripts/build-webkit:
283         * Scripts/webkitdirs.pm:
284
285 2011-01-15  Adam Barth  <abarth@webkit.org>
286
287         Teach svn-apply about WebKit2 move.
288
289         * Scripts/VCSUtils.pm:
290
291 2011-01-15  Adam Barth  <abarth@webkit.org>
292
293         Rubber-stamped by Eric Seidel.
294
295         Move WebKit2 into Source
296         https://bugs.webkit.org/show_bug.cgi?id=52438
297
298         * MiniBrowser/qt/MiniBrowser.pro:
299         * Scripts/build-webkit:
300         * Scripts/do-file-rename:
301         * Scripts/do-webcore-rename:
302         * Scripts/test-webkitpy:
303         * Scripts/webkitdirs.pm:
304         * Scripts/webkitpy/style/checker.py:
305         * WebKitTestRunner/DerivedSources.pro:
306         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
307         * WebKitTestRunner/qt/WebKitTestRunner.pro:
308
309 2011-01-15  Jochen Eisinger  <jochen@chromium.org>
310
311         Reviewed by David Levin.
312
313         [chromium] remove obsolete createView method
314         https://bugs.webkit.org/show_bug.cgi?id=52437
315
316         * DumpRenderTree/chromium/WebViewHost.cpp:
317         (WebViewHost::createView):
318         * DumpRenderTree/chromium/WebViewHost.h:
319
320 2011-01-14  Brian Weinstein  <bweinstein@apple.com>
321
322         Reviewed by Geoff Garen.
323
324         ShouldLoadResourceForFrame should use strings, not URLs.
325         https://bugs.webkit.org/show_bug.cgi?id=52476
326
327         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
328         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Update to use a WKStringRef.
329         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
330
331 2011-01-14  Tony Gentilcore  <tonyg@chromium.org>
332
333         Reviewed by David Levin.
334
335         Add Tony Gentilcore as a reviewer
336         https://bugs.webkit.org/show_bug.cgi?id=52480
337
338         * Scripts/webkitpy/common/config/committers.py:
339
340 2011-01-14  David Levin  <levin@chromium.org>
341
342         Reviewed by Eric Seidel.
343
344         check-webkit-style: _FunctionState should keep track of where the function name starts.
345         https://bugs.webkit.org/show_bug.cgi?id=52454
346
347         * Scripts/webkitpy/style/checkers/cpp.py: Added function_name_start_position to
348         _FunctionState and logic for setting it correctly.
349         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests.
350
351 2011-01-14  Vincent Scheib  <scheib@chromium.org>
352
353         Reviewed by David Levin.
354
355         Add support to DumpRenderTree to use the GPU rather than software renderer
356         https://bugs.webkit.org/show_bug.cgi?id=52333
357
358         * DumpRenderTree/chromium/DumpRenderTree.cpp:
359         (main):
360         * Scripts/webkitpy/layout_tests/port/chromium.py:
361         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
362
363 2011-01-14  Tony Chang  <tony@chromium.org>
364
365         Reviewed by Kent Tamura.
366
367         [chromium] update fonts.conf to fix 6 linux tests in drt
368         https://bugs.webkit.org/show_bug.cgi?id=52411
369
370         * DumpRenderTree/chromium/fonts.conf: Update to match the copy in
371             chromium's src/webkit/tools/test_shell/resources/fonts.conf
372
373 2011-01-14  Eric Seidel  <eric@webkit.org>
374
375         Original patch from Peter Gal  <galpater@inf.u-szeged.hu>
376
377         Reviewed by Adam Barth.
378
379         Fix when running Tools/Scripts/check-webkit-style without arguments.
380         https://bugs.webkit.org/show_bug.cgi?id=52261#c16
381
382         * Scripts/webkitpy/common/checkout/scm.py: Handle None for changed_files argument better in Git.create_patch method.
383         * Scripts/webkitpy/common/checkout/scm_unittest.py:
384
385 2011-01-04  Jochen Eisinger  <jochen@chromium.org>
386
387         Reviewed by David Levin.
388
389         Store the tempdir object in a variable so it doesn't get deleted too early.
390         https://bugs.webkit.org/show_bug.cgi?id=51875
391
392         * Scripts/update-webkit-auxiliary-libs:
393         * Scripts/update-webkit-support-libs:
394
395 2011-01-14  Eric Seidel  <eric@webkit.org>
396
397         Unreviewed.  Make it work in python 2.5.
398
399         webkit-patch suggest-reviewers dies when ChangeLogs are missing
400         https://bugs.webkit.org/show_bug.cgi?id=49158
401
402         * Scripts/webkitpy/common/checkout/api_unittest.py:
403
404 2011-01-14  Sheriff Bot  <webkit.review.bot@gmail.com>
405
406         Unreviewed, rolling out r75774.
407         http://trac.webkit.org/changeset/75774
408         https://bugs.webkit.org/show_bug.cgi?id=52431
409
410         gtk builds were broken (Requested by loislo2 on #webkit).
411
412         * Scripts/webkitpy/common/checkout/scm.py:
413
414 2011-01-14  David Levin  <levin@chromium.org>
415
416         Reviewed by Shinichiro Hamaji.
417
418         check-webkit-style: _FunctionState should detect pure functions.
419         https://bugs.webkit.org/show_bug.cgi?id=52428
420
421         * Scripts/webkitpy/style/checkers/cpp.py: Added detection for if a function declaration
422         is a pure virtual function.
423         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests for verifying that pure
424         virtual functions are correctly detected.
425
426 2011-01-13  Ilya Tikhonovsky  <loislo@chromium.org>
427
428         Reviewed by Yury Semikhatsky.
429
430         Just small fix for problem with check-webkit-style.
431         It just didn't work for this patch.
432         Old code can't concatenate a list of strings with None.
433
434         * Scripts/webkitpy/common/checkout/scm.py:
435
436 2011-01-13  David Levin  <levin@chromium.org>
437
438         Reviewed by Shinichiro Hamaji.
439
440         check-webkit-style: _FunctionState should use Position to know where items are.
441         https://bugs.webkit.org/show_bug.cgi?id=52424
442
443         * Scripts/webkitpy/style/checkers/cpp.py:
444         (_FunctionState.*): Changed _FunctionState to use Position instead of line numbers.
445         (detect_functions): Changed to pass Position's to _FunctionState.begin and
446         did some minor clean-up.
447         (*): Other changes are simply about converting to use the Position's in_FunctionState
448         instead of line numbers.
449         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Changed the test code
450         to verify the positions stored in _FunctionState.
451
452 2011-01-13  Eric Seidel  <eric@webkit.org>
453
454         Reviewed by David Levin.
455
456         webkit-patch suggest-reviewers dies when ChangeLogs are missing
457         https://bugs.webkit.org/show_bug.cgi?id=49158
458
459         This is not the most elegant, but it is a very safe fix to this bug.
460         One advantage of catching ScriptError like this instead of adding a
461         new added_or_modified_files or fixing all changed_files callers
462         to use a more specific change_files variant, is that we catch
463         all kinds of ScriptErrors which might cause our (non-essential)
464         suggest-reviewers code to fail out.  This should make passing
465         --suggest-reviewers to webkit-patch upload much more robust
466         and may even make it possible for us to make it default.
467
468         The root of the problem here is that SCM.changed_files includes
469         deleted ChangeLog paths (from moves, etc) which then when we ask
470         SVN/Git for the contents of the file at that revision, the command
471         errors out and Executive.run_command raises a ScriptError.
472
473         In the future we might fix this differently by making all current
474         callers of chagned_files use a more specific method for requesting
475         what types of changes they're interested in (adds, modifies, deletes, etc.)
476
477         * Scripts/webkitpy/common/checkout/api.py:
478         * Scripts/webkitpy/common/checkout/api_unittest.py:
479
480 2011-01-13  Dan Bernstein  <mitz@apple.com>
481
482         Reviewed by Alexey Proskuryakov.
483
484         <rdar://problem/8827065> REGRESSION (r71884): Cross-origin XHR fails if willSendRequest changes the URL
485         https://bugs.webkit.org/show_bug.cgi?id=52419
486
487         Allow to further control the behavior of the willSendRequest delegate callback by making it
488         set a different URL in the new request.
489
490         * DumpRenderTree/LayoutTestController.cpp:
491         (addURLToRedirectCallback): Added.
492         (LayoutTestController::staticFunctions): Added addURLToRedirect.
493         (LayoutTestController::addURLToRedirect): Added. Adds the redirection to the map.
494         (LayoutTestController::redirectionDestinationForURL): Added this getter.
495         * DumpRenderTree/LayoutTestController.h:
496         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
497         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]): Check
498         if there is a redirection for the request’s URL, established by addURLToRedirect(), and if so,
499         change the URL in the new request to the redirect destination.
500
501 2011-01-13  Eric Seidel  <eric@webkit.org>
502
503         Reviewed by Mihai Parparita.
504
505         webkit-patch suggest-reviewers fails due to invalid utf8 in ChangeLog files
506         https://bugs.webkit.org/show_bug.cgi?id=52416
507
508         Example: webkit-patch suggest-reviewers -g ca3890fe74d94d85d6bfa48f9ea497b094d8e717 
509         UnicodeDecodeError: 'utf8' codec can't decode bytes in position 536-538: invalid data
510
511         I also added FIXMEs about the changed_files returning deleted files problem
512         which is causing the other most common exception for suggest-reviewers
513         (and is probably breaking sheriff-bots blame detection).
514
515         * Scripts/webkitpy/common/checkout/api.py:
516         * Scripts/webkitpy/common/checkout/api_unittest.py:
517         * Scripts/webkitpy/common/checkout/scm.py:
518
519 2011-01-13  Eric Seidel  <eric@webkit.org>
520
521         Reviewed by Adam Barth.
522
523         results archives from commit-queue are too large to upload
524         https://bugs.webkit.org/show_bug.cgi?id=52405
525
526         * Scripts/webkitpy/common/system/filesystem.py:
527         * Scripts/webkitpy/common/system/filesystem_mock.py:
528         * Scripts/webkitpy/tool/commands/queues.py:
529
530 2011-01-13  Alejandro G. Castro  <alex@igalia.com>
531
532         Reviewed by Martin Robinson.
533
534         [gtk] Zero-sized font does not yet work
535         https://bugs.webkit.org/show_bug.cgi?id=49793
536
537         Set minimum-font-size to 0 for the DRT.
538
539         * DumpRenderTree/gtk/DumpRenderTree.cpp:
540         (resetDefaultsToConsistentValues):
541
542 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
543
544         Reviewed by Darin Adler.
545
546         Make old-run-webkit-tests more robust on buildbots
547         https://bugs.webkit.org/show_bug.cgi?id=52364
548
549         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Pass --exit-after-n-failures 500 to old-run-webkit-tests script.
550
551 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
552
553         Reviewed by Darin Adler.
554
555         Make old-run-webkit-tests more robust on buildbots
556         https://bugs.webkit.org/show_bug.cgi?id=52364
557
558         * Scripts/old-run-webkit-tests: Ensure that testResultsDirectory is empty.
559
560 2011-01-13  Tony Chang  <tony@chromium.org>
561
562         Reviewed by Kent Tamura.
563
564         [chromium] fix plugins/plugin-javascript-access.html on Linux and Mac
565         https://bugs.webkit.org/show_bug.cgi?id=52332
566
567         Forked Info.plist is not longer needed.
568
569         * DumpRenderTree/chromium/TestNetscapePlugIn/Info.plist: Removed.
570
571 2011-01-13  Mikhail Naganov  <mnaganov@chromium.org>
572
573         Reviewed by Timothy Hatcher.
574
575         Web Inspector: Cleanup after r75613 -- make all UI-facing strings
576         to be passed directly to WebInspector.UIString
577
578         https://bugs.webkit.org/show_bug.cgi?id=52365
579
580         * Scripts/check-inspector-strings:
581
582 2011-01-13  Sheriff Bot  <webkit.review.bot@gmail.com>
583
584         Unreviewed, rolling out r74881.
585         http://trac.webkit.org/changeset/74881
586         https://bugs.webkit.org/show_bug.cgi?id=52357
587
588         The EFL builder has been red for days (Requested by abarth on
589         #webkit).
590
591         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
592         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
593
594 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
595
596         Reviewed by David Levin.
597
598         Add beforeunload support to WebKitTestRunner
599         https://bugs.webkit.org/show_bug.cgi?id=52353
600         
601         This makes a number of currently failing tests pass.
602
603         * WebKitTestRunner/TestController.cpp:
604         (WTR::runBeforeUnloadConfirmPanel):
605         (WTR::createOtherPage):
606         (WTR::TestController::initialize):
607
608 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
609
610         Reviewed by Sam Weinig.
611
612         Detect, identify and recover from WebProcess crashes in run-webkit-tests
613         https://bugs.webkit.org/show_bug.cgi?id=52330
614
615         * Scripts/old-run-webkit-tests: Detect when the regression test tool reports
616         a web process crash.
617         * WebKitTestRunner/TestController.cpp:
618         (WTR::TestController::initialize): Set up a processDidCrash
619         callback.
620         (WTR::TestController::processDidCrash): Report that the Web process
621         crashed.
622         * WebKitTestRunner/TestController.h:
623
624 2011-01-12  David Levin  <levin@chromium.org>
625
626         Reviewed by Shinichiro Hamaji.
627
628         check-webkit-style -- close_expression function doesn't work correctly.
629         https://bugs.webkit.org/show_bug.cgi?id=52272
630
631         * Scripts/webkitpy/style/checkers/cpp.py:
632         (Position.__str__): Added a way to convert it to a string which is useful in tests.
633         (Position.__cmp__): Added a way to compare Position which is useful in tests and
634         generally useful (for upcoming code changes).
635         (close_expression): Changed to use Position for input and output.
636         Also, fixed many bugs such as only working correctly for parenthesis,
637         not working correctly if given an offset in a line and not finding
638         the real closing element if there were multiple closing elements in
639         the same line.
640         (detect_functions): Adjusted due to the change in arguments for
641         close_expression.
642         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
643         (CppStyleTestBase.assert_positions_equal): Added a way to verify that
644         two positions are the same.
645         (CppStyleTest.test_position): Added tests for the __str_ and __cmp__ methods.
646         (CppStyleTest.test_close_expression): Added tests to catch the issues
647         that were fixed.
648
649 2011-01-12  Sheriff Bot  <webkit.review.bot@gmail.com>
650
651         Unreviewed, rolling out r75576.
652         http://trac.webkit.org/changeset/75576
653         https://bugs.webkit.org/show_bug.cgi?id=52304
654
655         broke rebaseline-chromium-webkit-test (Requested by thakis on
656         #webkit).
657
658         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
659         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
660         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
661         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
662         * Scripts/webkitpy/layout_tests/port/base.py:
663         * Scripts/webkitpy/layout_tests/port/chromium.py:
664         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
665         * Scripts/webkitpy/layout_tests/port/test.py:
666         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
667         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
668         * Scripts/webkitpy/style/checkers/test_expectations.py:
669         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
670
671 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
672
673         Reviewed by Darin Adler.
674
675         Add a no-build option to run-webkit-tests, to avoid building DRT/WKTR
676         https://bugs.webkit.org/show_bug.cgi?id=52307
677
678         * Scripts/old-run-webkit-tests:
679
680 2011-01-12  Koan-Sin Tan  <koansin.tan@gmail.com>
681
682         Reviewed by Martin Robinson.
683
684         [Gtk] WebKitGtk+ doesn't build on Mac OS X 10.6
685         https://bugs.webkit.org/show_bug.cgi?id=50867
686
687         Fixed library extention for Mac in webkitdirs.pm and type conflict in
688         TestNetscapePlugin.cpp 
689
690         * GNUmakefile.am: Don't use AppKit when compiling TestNetscapePlugin for GTK+
691         * Scripts/webkitdirs.pm:
692
693 2011-01-12  Mikhail Naganov  <mnaganov@chromium.org>
694
695         Reviewed by Pavel Feldman.
696
697         Add check-inspector-strings script.
698
699         https://bugs.webkit.org/show_bug.cgi?id=52295
700
701         * Scripts/check-inspector-strings: Added.
702
703 2011-01-12  Adam Roben  <aroben@apple.com>
704
705         Advertise the .testnetscape file extension on Windows
706
707         Fixes <http://webkit.org/b/52298>
708         plugins/no-mime-with-valid-extension.html fails on Windows
709
710         Reviewed by Dan Bernstein.
711
712         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Added a
713         FileExtents field to map the .testnetscape file extension to the
714         application/x-webkit-test-netscape MIME type, just as we do on Mac.
715
716 2011-01-12  Adam Barth  <abarth@webkit.org>
717
718         Reviewed by Eric Seidel.
719
720         Make webkit-patch support subdirectories for SVN checkouts
721         https://bugs.webkit.org/show_bug.cgi?id=52261
722
723         os.relpath does not exist on Python 2.5, so we need to call our version
724         of the API.
725
726         * Scripts/webkitpy/common/checkout/scm.py:
727
728 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
729
730         Reviewed by Eric Seidel.
731
732         Close additional pages opened during a test once the test completes.
733         https://bugs.webkit.org/show_bug.cgi?id=52276
734
735         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
736         (WTR::InjectedBundle::done):
737
738 2011-01-11  David Levin  <levin@chromium.org>
739
740         Reviewed by Eric Seidel.
741
742         Errors should be separated from the command line in bot messages.
743         https://bugs.webkit.org/show_bug.cgi?id=52275
744
745         * Scripts/webkitpy/common/system/executive.py:
746         (ScriptError.message_with_output): Added a newline to separate the command
747         line from the errors.
748         * Scripts/webkitpy/common/system/executive_unittest.py:
749         (ScriptErrorTest.test_message_with_output): Added tests for the various code
750         paths in message_with_output.
751
752 2011-01-11  Eric Seidel  <eric@webkit.org>
753
754         Unreviewed.
755
756         commit-queue should know how to upload archived results (for test flakes or general failures)
757         https://bugs.webkit.org/show_bug.cgi?id=52048
758
759         The zips are mostly empty due to forgetting -r.
760         Expected diffs were not being pulled from the archive due
761         to the archive having longer paths than I realized.
762
763         * Scripts/webkitpy/common/system/workspace.py:
764         * Scripts/webkitpy/common/system/workspace_unittest.py:
765         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
766         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
767
768 2011-01-11  Dirk Pranke  <dpranke@chromium.org>
769
770         Reviewed by Ojan Vafai.
771
772         The current modifier parsing code in test_expectations is
773         fragile and hard-coded, so it's not easy to understand the logic
774         or easily add new types of modifiers (like GPU vs. CPU testing
775         for graphics tests, or 32-bit vs. 64-bit differences).
776
777         This is the first of two patches that will add in more generic
778         support and then eliminate the GPU-specific test expectations
779         files for Chromium.
780
781         This patch adds two standalone objects for handling modifiers. The
782         rules for interpreting modifiers, precedence, and conflicts are
783         given in the docstring to the ModifierMatcher class, which
784         returns ModifierMatchResult objects.
785         
786         This patch also adds routines to the Port interface and a
787         default set of values in the base object, in order to obtain the
788         values needed on a given test run. These values are then passed
789         to the expectation parser. This also allows us to clean up the
790         logic used to lint all of the different configurations in a
791         single test_expectations.txt file.
792
793         The next patch will merge in the separate GPU expectations file.
794
795         https://bugs.webkit.org/show_bug.cgi?id=51222
796
797         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
798         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
799         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
800         * Scripts/webkitpy/layout_tests/port/base.py:
801         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
802         * Scripts/webkitpy/layout_tests/port/chromium.py:
803         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
804         * Scripts/webkitpy/layout_tests/port/test.py:
805         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
806         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
807
808 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
809
810         Reviewed by Adam Barth.
811
812         Make webkit-patch support subdirectories for SVN checkouts
813         https://bugs.webkit.org/show_bug.cgi?id=52261
814
815         * Scripts/webkitpy/common/checkout/scm.py:
816         * Scripts/webkitpy/style_references.py:
817         * Scripts/webkitpy/tool/main.py:
818         * Scripts/webkitpy/tool/steps/preparechangelog.py:
819
820 2011-01-11  Eric Seidel  <eric@webkit.org>
821
822         Unreviewed.
823
824         commit-queue should know how to upload archived results (for test flakes or general failures)
825         https://bugs.webkit.org/show_bug.cgi?id=52048
826
827         I changed the API for archive_last_layout_test_results w/o updating the implementation.  Oops.
828         This fixes an exception seen on the commit-queue when attempting to report flaky tests.
829
830         * Scripts/webkitpy/common/system/workspace.py:
831         * Scripts/webkitpy/common/system/workspace_unittest.py:
832         * Scripts/webkitpy/tool/commands/queues.py:
833
834 2011-01-11  Sam Weinig  <sam@webkit.org>
835
836         Roll r75474 back in.
837
838 2011-01-11  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
839
840         Reviewed by Kenneth Rohde Christiansen.
841
842         [Qt] Remove uses of QFuture since it isn't supported on all platforms.
843         https://bugs.webkit.org/show_bug.cgi?id=51204
844
845         * QtTestBrowser/webpage.h:
846         (QtNAMThread::QtNAMThread):
847         (QtNAMThread::networkAccessManager):
848         (QtNAMThread::run):
849
850 2011-01-11  Peter Varga  <pvarga@webkit.org>
851
852         Unreviewed.
853
854         Add myself to committers' list.
855
856         * Scripts/webkitpy/common/config/committers.py:
857
858 2011-01-11  Eric Seidel  <eric@webkit.org>
859
860         Reviewed by Adam Barth.
861
862         commit-queue should know how to upload archived results (for test flakes or general failures)
863         https://bugs.webkit.org/show_bug.cgi?id=52048
864
865         Now the queue will always upload results.  Either the entire zip, or just
866         the diffs.txt in the case of text failures.
867
868         This should make understanding flakes much easier, and paves the way
869         for having the EWS run layout tests (and upload failures).
870
871         In order to upload .zip files I had to teach bugzilla.py to autodetect
872         mime types from the filename.  Since mimetypes.py doesn't include a mapping
873         for .patch files, I have it add one before calling guess_type.
874
875         We may find that always uploading the whole zip instead of just the -diffs.txt
876         file is preferable, but for now I'm keeping the old behavior because it makes
877         quickly understanding text failures easy.
878
879         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
880         * Scripts/webkitpy/common/system/workspace.py: Added.
881         * Scripts/webkitpy/common/system/workspace_unittest.py: Added.
882         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
883         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
884         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
885         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
886         * Scripts/webkitpy/tool/commands/queues.py:
887         * Scripts/webkitpy/tool/commands/queues_unittest.py:
888
889 2011-01-10  Sheriff Bot  <webkit.review.bot@gmail.com>
890
891         Unreviewed, rolling out r75464.
892         http://trac.webkit.org/changeset/75464
893         https://bugs.webkit.org/show_bug.cgi?id=52193
894
895         Followup rollout for 75474 (Requested by Ossy on #webkit).
896
897         * MiniBrowser/mac/BrowserWindowController.m:
898         (-[BrowserWindowController awakeFromNib]):
899         * MiniBrowser/win/BrowserView.cpp:
900         (BrowserView::create):
901         * WebKitTestRunner/TestController.cpp:
902         (WTR::createOtherPage):
903         (WTR::TestController::initialize):
904
905 2011-01-10  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
906
907         Reviewed by Csaba Osztrogonác.
908
909         [Qt] Baseline qt_minimal configuration
910         https://bugs.webkit.org/show_bug.cgi?id=51313
911
912         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
913         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): Add
914         QT_NO_UNDOSTACK guard.
915
916         * QtTestBrowser/launcherwindow.cpp:
917         (LauncherWindow::createChrome): Add QT_NO_SHORTCUT and QT_NO_PRINTER
918         guards.
919         (LauncherWindow::applyZoom): Add QT_NO_ANIMATION guard.
920         (LauncherWindow::screenshot): Add QT_NO_FILEDIALOG guard.
921         (LauncherWindow::selectElements): Add QT_NO_INPUTDIALOG guard.
922         (LauncherWindow::showUserAgentDialog): Add QT_NO_COMBOBOX guard.
923
924         * QtTestBrowser/launcherwindow.h:
925         * QtTestBrowser/locationedit.cpp: Add QT_NO_INPUTDIALOG guard.
926         * QtTestBrowser/locationedit.h: Ditto.
927
928         * QtTestBrowser/mainwindow.cpp:
929         (MainWindow::buildUI): Add QT_NO_INPUTDIALOG, QT_NO_SHORTCUT and
930         QT_NO_UNDOSTACK guards.
931         (MainWindow::setAddressUrl): Add QT_NO_INPUTDIALOG guard.
932         (MainWindow::changeLocation): Ditto.
933         (MainWindow::openFile): Add QT_NO_FILEDIALOG guard.
934         (MainWindow::openLocation): Add QT_NO_INPUTDIALOG guard.
935
936         * QtTestBrowser/webpage.cpp:
937         (WebPage::openUrlInDefaultBrowser): Add QT_NO_DESKTOPSERVICES guard.
938         (WebPage::authenticationRequired): Add QT_NO_LINEEDIT guard.
939
940         * QtTestBrowser/webview.cpp:
941         (WebViewGraphicsBased::animatedFlip): Add QT_NO_ANIMATION guard.
942         (WebViewGraphicsBased::animatedYFlip): Ditto.
943
944 2011-01-10  Sam Weinig  <sam@webkit.org>
945
946         Fix build.
947
948         * MiniBrowser/mac/BrowserWindowController.m:
949         (-[BrowserWindowController awakeFromNib]):
950         * MiniBrowser/win/BrowserView.cpp:
951         (BrowserView::create):
952         * WebKitTestRunner/TestController.cpp:
953         (WTR::createOtherPage):
954         (WTR::TestController::initialize):
955
956 2011-01-10  Eric Seidel  <eric@webkit.org>
957
958         Reviewed by Ojan Vafai.
959
960         style-queue messages are way too long for big patches
961         https://bugs.webkit.org/show_bug.cgi?id=52161
962
963         We definitely could build much fancier list-to-string-with-limit functions
964         but this should be sufficient for our needs at the moment.
965
966         * Scripts/webkitpy/common/system/executive.py:
967         * Scripts/webkitpy/common/system/executive_unittest.py:
968
969 2011-01-10  Tony Chang  <tony@chromium.org>
970
971         Unreviewed, rolling out r75398.
972         http://trac.webkit.org/changeset/75398
973         https://bugs.webkit.org/show_bug.cgi?id=52008
974
975         Some layout tests are crashing on Chromium Win.
976
977         * DumpRenderTree/chromium/WebViewHost.cpp:
978         (WebViewHost::updatePaintRect):
979         * DumpRenderTree/chromium/WebViewHost.h:
980
981 2011-01-10  Adam Roben  <aroben@apple.com>
982
983         Roll out r75392
984
985         It isn't needed now that r75289 has been rolled out.
986
987         * Scripts/run-javascriptcore-tests:
988
989 2011-01-10  Maciej Stachowiak  <mjs@apple.com>
990
991         Reviewed by Anders Carlsson.
992
993         WebKitTestRunner uses crazy amounts of CPU, making layout tests slow and flaky
994         https://bugs.webkit.org/show_bug.cgi?id=52160
995
996         * WebKitTestRunner/mac/TestControllerMac.mm:
997         (WTR::TestController::platformRunUntil): Instead of busy-looping, wait for the timeout.
998         Anything that can make runUntil() conditions turn true will happen on a run loop cycle
999         anyway.
1000
1001 2011-01-10  Tony Chang  <tony@chromium.org>
1002
1003         Reviewed by Mihai Parparita.
1004
1005         [chromium] fix for animated gif layout tests
1006         https://bugs.webkit.org/show_bug.cgi?id=52008
1007
1008         * DumpRenderTree/chromium/WebViewHost.cpp: Schedule a paint when we update the paint rect
1009             to trigger gif animations.
1010         (WebViewHostPaintTask::WebViewHostPaintTask):
1011         (WebViewHostPaintTask::runIfValid):
1012         (WebViewHost::updatePaintRect):
1013         * DumpRenderTree/chromium/WebViewHost.h:
1014         (WebViewHost::taskList):
1015
1016 2011-01-10  Alejandro G. Castro  <alex@igalia.com>
1017
1018         Reviewed by Xan Lopez.
1019
1020         [GTK] Fix gtk2 compilation for master
1021         https://bugs.webkit.org/show_bug.cgi?id=51885
1022
1023         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
1024         (createBitmapContextFromWebView): Replaced the old
1025         gdk_drawable_get_size with gdk_pixmap_get_size.
1026
1027 2011-01-10  Patrick Gansterer  <paroga@webkit.org>
1028
1029         Reviewed by Laszlo Gombos.
1030
1031         [WINCE] Reenable NPAPI after r75203
1032         https://bugs.webkit.org/show_bug.cgi?id=52109
1033
1034         Remove the !isWinCE() check for ENABLE_NETSCAPE_PLUGIN_API and replace
1035         it with !isEfl(), because EFL port does not support NPAPI (yet).
1036
1037         * Scripts/build-webkit:
1038
1039 2011-01-10  Adam Roben  <aroben@apple.com>
1040
1041         Skip some asserting JS tests
1042
1043         See <http://webkit.org/b/52156>.
1044
1045         * Scripts/run-javascriptcore-tests:
1046
1047 2011-01-10  Martin Robinson  <mrobinson@igalia.com>
1048
1049         Reviewed by Xan Lopez.
1050
1051         [GTK] build-webkit disable Blob support via arguments passed to automake
1052         https://bugs.webkit.org/show_bug.cgi?id=52097
1053
1054         * Scripts/build-webkit: Enable Blob support when building WebKitGTK+ via
1055         build-webkit.
1056
1057 2011-01-10  Adam Roben  <aroben@apple.com>
1058
1059         Use the same name and description for TestNetscapePlugin on Windows and
1060         Mac
1061
1062         Fixes <http://webkit.org/b/52151>
1063         fast/frames/iframe-reparenting-plugins.html fails on Windows
1064
1065         Reviewed by Steve Falkenburg.
1066
1067         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Copied
1068         the name and description from Mac's Info.plist.
1069
1070 2011-01-10  Siddharth Mathur <siddharth.mathur@nokia.com>
1071
1072         Reviewed by Laszlo Gombos.
1073
1074         [Qt][WK2] Guard gcc-specific syntax
1075
1076         Non-gcc based compliers choke on the "-include"
1077         syntax for preinclude, place guard around it.
1078
1079         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1080         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1081
1082 2011-01-10  Andreas Kling  <kling@webkit.org>
1083
1084         Reviewed by Simon Hausmann.
1085
1086         [Qt] [WK2] MiniBrowser does not load pages opened in new windows
1087         https://bugs.webkit.org/show_bug.cgi?id=52111
1088
1089         When getting a createNewPage() callback from QWKPage, create the
1090         new page with the same QWKContext as the page that is passed to
1091         the callback.
1092
1093         * MiniBrowser/qt/BrowserView.h:
1094         * MiniBrowser/qt/BrowserWindow.cpp:
1095         (newPageFunction):
1096         (BrowserWindow::BrowserWindow):
1097         * MiniBrowser/qt/BrowserWindow.h:
1098
1099 2011-01-10  Andreas Kling  <kling@webkit.org>
1100
1101         Reviewed by Kenneth Rohde Christiansen.
1102
1103         [Qt] MiniBrowser: Remove superfluous createNewPage() callback
1104
1105         BrowserView set its own useless createNewPage() callback on QWKPage.
1106         This was immediately overridden by BrowserWindow anyway, so remove
1107         the BrowserView one.
1108
1109         * MiniBrowser/qt/BrowserView.cpp:
1110         (BrowserView::BrowserView):
1111
1112 2011-01-10  John Knottenbelt  <jknotten@chromium.org>
1113
1114         Reviewed by Jeremy Orlow.
1115
1116         [Chromium] Remove non-client-based Geolocation code
1117         https://bugs.webkit.org/show_bug.cgi?id=50921
1118
1119         * DumpRenderTree/chromium/LayoutTestController.cpp:
1120         (LayoutTestController::setGeolocationPermission):
1121         (LayoutTestController::setMockGeolocationPosition):
1122         (LayoutTestController::setMockGeolocationError):
1123         * DumpRenderTree/chromium/WebViewHost.cpp:
1124         (WebViewHost::geolocationClientMock):
1125         (WebViewHost::reset):
1126         * DumpRenderTree/chromium/WebViewHost.h:
1127
1128 2011-01-10  Eric Seidel  <eric@webkit.org>
1129
1130         Reviewed by Adam Barth.
1131
1132         Commit bot tried to land r? cq+ patch
1133         https://bugs.webkit.org/show_bug.cgi?id=36638
1134
1135         It should now be possible to post a patch with r? and cq+ and the
1136         commit-queue will correctly wait for the r+ before attempting to land the patch.
1137         (This was a feature requested by several users.)
1138
1139         One caveat: We don't actually reject r-, cq+ patches from the queue
1140         (we just ignore them), but I think that's OK for now.
1141
1142         I also noticed that setting r- once a commit-queue node had grabbed
1143         a patch would not properly cancel the landing.  That's fixed and
1144         tested in this patch.
1145
1146         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1147         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1148         * Scripts/webkitpy/tool/bot/feeders.py:
1149         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
1150
1151 2011-01-08  Benjamin Poulain  <benjamin.poulain@nokia.com>
1152
1153         Reviewed by Kenneth Rohde Christiansen.
1154
1155         [Qt] QtWebKit crashes when using XMLHttpRequest from the unload event
1156         https://bugs.webkit.org/show_bug.cgi?id=51934
1157
1158         When accessing the network from the destructor of QWebPage, the network access manager
1159         was already deleted because the object WebPage was already destructed.
1160
1161         This solve the problem by linking the lifetime of the network access manager to WebPage's QObject.
1162         The object is now destructed in the destructor of QObject.
1163
1164         * QtTestBrowser/webpage.cpp:
1165         (WebPage::WebPage):
1166         (WebPage::setQnamThreaded):
1167         * QtTestBrowser/webpage.h:
1168         (QtNAMThread::QtNAMThread):
1169
1170 2011-01-08  Eric Seidel  <eric@webkit.org>
1171
1172         Reviewed by Ojan Vafai.
1173
1174         test_failures.py should not mention TestShell (long live DumpRenderTree!)
1175         https://bugs.webkit.org/show_bug.cgi?id=52067
1176
1177         I ran test-webkitpy, but didn't bother adding a unit test for this string change.
1178         https://bugs.webkit.org/show_bug.cgi?id=51138#c3 is an example of why this is needed.
1179
1180         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1181
1182 2011-01-08  Eric Seidel  <eric@webkit.org>
1183
1184         Reviewed by Mihai Parparita.
1185
1186         commit-queue hangs when the ChangeLog diff is bad
1187         https://bugs.webkit.org/show_bug.cgi?id=52072
1188
1189         * Scripts/webkitpy/tool/steps/validatechangelogs.py:
1190         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
1191
1192 2011-01-08  Adam Barth  <abarth@webkit.org>
1193
1194         Teach svn-apply how to re-write WebCore to Source/WebCore.
1195
1196         * Scripts/VCSUtils.pm:
1197
1198 2011-01-07  Adam Barth  <abarth@webkit.org>
1199
1200         Rubber-stamped by Eric Seidel.
1201
1202         Move WebCore to Source
1203         https://bugs.webkit.org/show_bug.cgi?id=52050
1204
1205         Update the tools to understand WebCore's new location.
1206
1207         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1208         * DumpRenderTree/wscript:
1209         * GNUmakefile.am:
1210         * Scripts/build-webkit:
1211         * Scripts/do-file-rename:
1212         * Scripts/do-webcore-rename:
1213         * Scripts/generate-qt-inspector-resource:
1214         * Scripts/prepare-ChangeLog:
1215         * Scripts/run-bindings-tests:
1216         * Scripts/update-iexploder-cssproperties:
1217         * Scripts/update-sources-list.py:
1218         * Scripts/update-webkit-localizable-strings:
1219         * Scripts/webkitdirs.pm:
1220         * Scripts/webkitpy/common/config/build.py:
1221         * Scripts/webkitpy/common/config/build_unittest.py:
1222         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
1223         * Scripts/webkitpy/style/checker.py:
1224         * Scripts/webkitpy/style/checker_unittest.py:
1225         * WebKitTestRunner/DerivedSources.pro:
1226         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1227         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh:
1228         * wx/browser/wscript:
1229         * wx/build/settings.py:
1230
1231 2011-01-07  Maciej Stachowiak  <mjs@apple.com>
1232
1233         Reviewed by Sam Weinig.
1234
1235         Make WebKitTestRunner rest between loads more robust to avoid test crashes
1236         https://bugs.webkit.org/show_bug.cgi?id=52086
1237
1238         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1239         (WTR::InjectedBundle::didReceiveMessage):
1240         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1241         (WTR::LayoutTestController::notifyDone):
1242         * WebKitTestRunner/TestController.cpp:
1243         (WTR::TestController::resetStateToConsistentValues):
1244         (WTR::TestController::run):
1245
1246 2011-01-07  James Robinson  <jamesr@chromium.org>
1247
1248         Revert "Implement mozilla's animationTime property"
1249         https://bugs.webkit.org/show_bug.cgi?id=51952
1250
1251         This approach isn't quite right.
1252
1253         * DumpRenderTree/chromium/WebViewHost.cpp:
1254         (WebViewHost::paintInvalidatedRegion):
1255
1256 2011-01-07  Adam Roben  <aroben@apple.com>
1257
1258         Build master fix
1259
1260         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1261         (RunWebKitTests.start): Don't try to concatenate a list and a string.
1262
1263 2011-01-07  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>
1264
1265         Reviewed by Csaba Osztrogonác.
1266
1267         run-qtwebkit-tests should be able to kill a testsuite.
1268
1269         Add new option in the script that can setup a timeout for a test.
1270         If the test execution takes more then specified time then the test
1271         would be terminated.
1272
1273         [Qt] run-qtwebkit-tests needs timeout
1274         https://bugs.webkit.org/show_bug.cgi?id=51894
1275
1276         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1277         * Scripts/run-qtwebkit-tests:
1278
1279 2011-01-07  Csaba Osztrogonác  <ossy@webkit.org>
1280
1281         Unreviewed fix after r75233.
1282
1283         Based on idea from Eric Seidel.
1284
1285         Add remote zip file handling to webkitpy.
1286         https://bugs.webkit.org/show_bug.cgi?id=50901
1287
1288         * Scripts/webkitpy/common/system/fileset.py: Make python 2.5 happy.
1289
1290 2011-01-07  Shane Stephens  <shanestephens@google.com>
1291
1292         Reviewed by Eric Seidel.
1293
1294         svn-apply: should support git binary delta diffs
1295         https://bugs.webkit.org/show_bug.cgi?id=38864
1296
1297         * Scripts/VCSUtils.pm:
1298         * Scripts/svn-apply:
1299
1300 2011-01-06  Julie Parent  <jparent@chromium.org>
1301
1302         Reviewed by Eric Seidel.
1303
1304         Test Result Server not removing old results.
1305         https://bugs.webkit.org/show_bug.cgi?id=52012
1306
1307         * TestResultServer/model/jsonresults.py:
1308         Fix off-by-one: Truncate if >= num_runs, not just >.
1309         * TestResultServer/model/jsonresults_unittest.py:
1310         Add unit test to test that merging in a new result with the same value
1311         as the last result causes previous result to fall off.
1312
1313 2011-01-06  James Kozianski  <koz@chromium.org>
1314
1315         Reviewed by Mihai Parparita.
1316
1317         Add classes to provide a consistent interface to a set of files.
1318         https://bugs.webkit.org/show_bug.cgi?id=50901
1319
1320         These classes allow us to write code that is agnostic to whether a
1321         particular set of files resides in a local directory or in a zip file
1322         on a remote machine.
1323
1324         * Scripts/webkitpy/common/system/directoryfileset.py: Added.
1325         * Scripts/webkitpy/common/system/directoryfileset_unittest.py: Added.
1326         * Scripts/webkitpy/common/system/fileset.py: Added.
1327         * Scripts/webkitpy/common/system/filesystem.py:
1328         * Scripts/webkitpy/common/system/filesystem_mock.py:
1329         * Scripts/webkitpy/common/system/zipfileset.py: Added.
1330         * Scripts/webkitpy/common/system/zipfileset_unittest.py: Added.
1331
1332 2011-01-06  Eric Seidel  <eric@webkit.org>
1333
1334         Reviewed by Adam Barth.
1335
1336         NetworkTransaction should log the url it is retrying
1337         https://bugs.webkit.org/show_bug.cgi?id=52043
1338
1339         * Scripts/webkitpy/common/net/networktransaction.py:
1340         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
1341
1342 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
1343
1344         Windows build fix.
1345         Import os before using it.
1346
1347         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1348
1349 2011-01-06  Eric Seidel  <eric@webkit.org>
1350
1351         Reviewed by Adam Barth.
1352
1353         StyleQueue fails to report errors when patches have many files
1354         https://bugs.webkit.org/show_bug.cgi?id=52042
1355
1356         This is one of at least two errors preventing style error reporting at the moment.
1357         When we moved to passing the list of files to check explicitly,
1358         we started to exceed the 500 character TEXT field limit for our AppEngine model object.
1359         We could change the type of the QueueStatus.message type, or we could
1360         just teach statusserver.py how to clamp values (and warn when it does).
1361         I chose the latter path.
1362
1363         * Scripts/webkitpy/common/net/statusserver.py:
1364
1365 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
1366
1367         Reviewed by Stephanie Lewis.
1368         
1369         Fix syntax error in script.
1370
1371         Windows bots need to archive/unarchive builds to/from configuration-specific directories
1372         https://bugs.webkit.org/show_bug.cgi?id=51996
1373
1374         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1375
1376 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1377
1378         Unreviewed, fixing WinCE build after r75196.
1379
1380         WinCE port does not (yet) support NPAPI.
1381
1382         * Scripts/build-webkit:
1383
1384 2011-01-06  Xan Lopez  <xlopez@igalia.com>
1385
1386         Reviewed by Darin Adler.
1387
1388         File::Spec->rel2abs in sunspider-compare-results mangles parameters
1389         https://bugs.webkit.org/show_bug.cgi?id=52015
1390
1391         * Scripts/sunspider-compare-results: call rel2abs on our arguments
1392         after the platform has been detected, otherwise the script will
1393         mangle things like '--gtk' into '/a/path/--gtk', breaking the
1394         detection.
1395
1396 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1397
1398         Reviewed by Eric Seidel.
1399
1400         Add ENABLE_NETSCAPE_PLUGIN_API, ENABLE_ORIENTATION_EVENTS and ENABLE_TOUCH_EVENTS flags to build-webkit
1401         https://bugs.webkit.org/show_bug.cgi?id=51346
1402
1403         * Scripts/build-webkit:
1404
1405 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
1406
1407         Reviewed by Adam Roben.
1408
1409         Windows bots need to archive/unarchive builds to/from configuration-specific directories
1410         https://bugs.webkit.org/show_bug.cgi?id=51996
1411         
1412         After the configuration directory change, we were archiving the incorrect directory for
1413         build product, so we were running tests on the wrong binaries.
1414         
1415         This change archives the correct directory, and also unarchives it into a configuration-
1416         specific directory.
1417
1418         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Use a configuration-specific directory on Windows.
1419         * BuildSlaveSupport/built-product-archive: Unarchive/archive to/from proper directory.
1420
1421 2011-01-06  Eric Seidel  <eric@webkit.org>
1422
1423         Reviewed by Mihai Parparita.
1424
1425         commit-queue mentions "Text diff mismatch" 4 times instead of once per failure
1426         https://bugs.webkit.org/show_bug.cgi?id=52002
1427
1428         See an example of this here:
1429         https://bugs.webkit.org/show_bug.cgi?id=51314#c2
1430
1431         It's due to the fact that we pass around TestFailure() instance
1432         objects and yet expect them to all compare to be the same.
1433
1434         This is bad.  We should either have shared instances of these values
1435         or we should just pass around the class names.  There are already hacks
1436         in place to make TestFailure objects pass equality tests, I just added
1437         a __hash__ implementation so they can be used in sets as expected.
1438
1439         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1440         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1441
1442 2011-01-06  Evan Martin  <evan@chromium.org>
1443
1444         Reviewed by Tony Chang.
1445
1446         [gdb] handle inaccessible memory and UChar*
1447         https://bugs.webkit.org/show_bug.cgi?id=52003
1448
1449         To pretty-print a UChar*, we just grope around in the memory
1450         looking for a terminating NUL.  We need to handle the exception
1451         that can occur when we poke into an invalid location.
1452
1453         Additionally, the logic for choosing which pretty-printer would
1454         early return before hitting the point where we'd use the UChar*
1455         printer.  (Did this ever work?  How did it regress?)
1456
1457         * gdb/webkit.py:
1458
1459 2011-01-05  Brian Weinstein  <bweinstein@apple.com>
1460
1461         Reviewed by Ada Chan.
1462
1463         WebKit2: Should be able to call into injected bundle to ask if we should allow resource loads
1464         https://bugs.webkit.org/show_bug.cgi?id=51969
1465         
1466         Add shouldLoadResourceForFrame to WTR::InjectedBundlePage.
1467
1468         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1469         (WTR::InjectedBundlePage::InjectedBundlePage):
1470         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Stub implementation.
1471         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1472
1473 2011-01-06  James Robinson  <jamesr@chromium.org>
1474
1475         Reviewed by Simon Fraser.
1476
1477         Implement mozilla's animationTime property
1478         https://bugs.webkit.org/show_bug.cgi?id=51952
1479
1480         Chromium DRT support for webkitAnimationTime.
1481
1482         * DumpRenderTree/chromium/WebViewHost.cpp:
1483         (WebViewHost::paintInvalidatedRegion):
1484
1485 2011-01-06  Julie Parent  <jparent@chromium.org>
1486
1487         Reviewed by Tony Chang.
1488
1489         Test Result Server always truncates number of results to JSON_RESULTS_MAX_BUILDS
1490         https://bugs.webkit.org/show_bug.cgi?id=51217
1491
1492         * TestResultServer/model/jsonresults.py:
1493         Pass num_runs through to _remove_items_over_max_number_of_builds, and use the value.
1494         Adds missing documentation.
1495         * TestResultServer/model/jsonresults_unittest.py:
1496         Add unit test to test that truncation happens at smaller value than JSON_RESULTS_MAX_BUILDS.
1497         Update test_merge to take a number of builds to truncate at.
1498
1499 2011-01-06  Adam Barth  <abarth@webkit.org>
1500
1501         Reviewed by Eric Seidel.
1502
1503         The EWS should log outside of the working directory
1504         https://bugs.webkit.org/show_bug.cgi?id=51986
1505
1506         This patch prepare us for using git clean -x -d -f in the EWS wrapper
1507         script, which will actually clean the working copy back to a pristine
1508         state instead of leaving untracked directories and ignored files.
1509
1510         * Scripts/webkitpy/tool/commands/queues.py:
1511         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1512
1513 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
1514
1515         Windows build fix.
1516         Back out attempted change to built-product-archive.
1517
1518         * BuildSlaveSupport/built-product-archive:
1519
1520 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
1521
1522         Windows build fix.
1523         Include configuration name when unpacking a build archive.
1524
1525         Needed, since we split Windows build results into configuration-specific directories
1526         under WebKitOutputDir.
1527
1528         * BuildSlaveSupport/built-product-archive:
1529
1530 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
1531
1532         Reviewed by Darin Adler.
1533
1534         Debug and Release builds on Windows clobber each other
1535         https://bugs.webkit.org/show_bug.cgi?id=49185
1536
1537         Changes the structure of WebKitBuild build products directory so we
1538         completely separate each build configuration into independent directories.
1539         
1540         Although we previously had per-configuration directories for obj, this change adds
1541         per-configuration directories for bin, lib, obj, and include. Each configuration's
1542         build products are stored within a directory inside of WebKitBuild.
1543         
1544         Most use of $(WebKitOutputDir) in the build files has been replaced by $(ConfigurationBuildDir),
1545         defined in common.vsprops to be $(WebKitOutputDir)\$(ConfigurationName).
1546
1547         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops:
1548         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd:
1549         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd:
1550         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
1551         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd:
1552         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd:
1553         * DumpRenderTree/win/ImageDiffCommon.vsprops:
1554         * DumpRenderTree/win/ImageDiffPostBuild.cmd:
1555         * DumpRenderTree/win/ImageDiffPreBuild.cmd:
1556         * FindSafari/FindSafari.vcproj:
1557         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
1558         * MiniBrowser/MiniBrowserPostBuild.cmd:
1559         * MiniBrowser/MiniBrowserPreBuild.cmd:
1560         * Scripts/webkitdirs.pm:
1561         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
1562         * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops:
1563         * TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd:
1564         * TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd:
1565         * TestWebKitAPI/win/copy-resources.cmd:
1566         * WebKitAPITest/WebKitAPITestCommon.vsprops:
1567         * WebKitAPITest/WebKitAPITestPostBuild.cmd:
1568         * WebKitAPITest/WebKitAPITestPreBuild.cmd:
1569         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
1570         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
1571         * WebKitTestRunner/win/InjectedBundle.vcproj:
1572         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops:
1573         * WebKitTestRunner/win/InjectedBundlePostBuild.cmd:
1574         * WebKitTestRunner/win/InjectedBundlePreBuild.cmd:
1575         * WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd:
1576         * WebKitTestRunner/win/WebKitTestRunnerPreBuild.cmd:
1577         * WinLauncher/WinLauncherCommon.vsprops:
1578         * WinLauncher/WinLauncherPostBuild.cmd:
1579         * WinLauncher/WinLauncherPreBuild.cmd:
1580
1581 2011-01-05  Jan Erik Hanssen  <jhanssen@sencha.com>
1582
1583         Reviewed by Ariya Hidayat.
1584
1585         [Qt] TestNetscapePlugin doesn't link on OS X
1586         https://bugs.webkit.org/show_bug.cgi?id=51948
1587
1588         Only add a dependency on libX11 on X11 systems
1589
1590         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1591
1592 2011-01-05  Jeff Miller  <jeffm@apple.com>
1593
1594         Reviewed by Adam Roben.
1595
1596         check-webkit-style should allow unnecessary parameter names in WebKit2 APIs because we're matching CF's header style
1597         https://bugs.webkit.org/show_bug.cgi?id=51970
1598
1599         * Scripts/webkitpy/style/checker.py:
1600         Add -readability/naming for WebKit2 C API directories.
1601
1602 2011-01-05  Eric Seidel  <eric@webkit.org>
1603
1604         Unreviewed, just fixing one more log error from my previous python patch.
1605
1606         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
1607         https://bugs.webkit.org/show_bug.cgi?id=51802
1608
1609         webkit-patch failure-reason was logging about parsing errors
1610         due to my misunderstanding of how BeautifulSoup.findAll worked.
1611
1612         Fixed, and added a unit test.
1613
1614         * Scripts/webkitpy/common/net/layouttestresults.py:
1615         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1616
1617 2011-01-05  Benjamin Poulain  <benjamin.poulain@nokia.com>
1618
1619         Reviewed by Kenneth Rohde Christiansen.
1620
1621         [Qt] [WK2] Add the possibility to open window from the WebProcess in Minibrowser
1622         https://bugs.webkit.org/show_bug.cgi?id=51951
1623
1624         Set a function to QWKPage::setCreateNewPageFunction() in Minibrowser so there is a way
1625         to create new window from WebKit.
1626
1627         * MiniBrowser/qt/BrowserWindow.cpp:
1628         (newPageFunction):
1629         (BrowserWindow::BrowserWindow):
1630         (BrowserWindow::page): Added to avoid the indirect access to QWKPage spread in the class
1631         (BrowserWindow::newWindow):
1632         (BrowserWindow::updateUserAgentList):
1633         (BrowserWindow::showUserAgentDialog):
1634         * MiniBrowser/qt/BrowserWindow.h: Add the global variable backingStoreTypeForNewWindow to
1635         define the type of the backing store used for new windows.
1636         * MiniBrowser/qt/main.cpp:
1637         (main):
1638
1639 2011-01-05  Eric Seidel  <eric@webkit.org>
1640
1641         Reviewed by Ojan Vafai.
1642
1643         commit-queue should report failure type when reporting flaky tests
1644         https://bugs.webkit.org/show_bug.cgi?id=51900
1645
1646         This patch was a ridiculous amount of plumbing.  In the end I like
1647         the NRWT-style TestResult class even less.  But now we're passing
1648         a list of TestResult objects from the queue to the FlakyTestReporter.
1649         Thus the FlakyTestReporter can more easily report what type of failure
1650         occurred.
1651
1652         In the process, I found that I was not alone in finding TestResult
1653         cumbersome to use.  A bunch of code was trying to create a TestResult
1654         object with default values.  However since the constructor didn't make
1655         this easy, some places were getting it wrong (including the TestResult unit test)!
1656         I've fixed the TestResult constructor to have default values for non-essential
1657         arguments.
1658
1659         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1660         * Scripts/webkitpy/common/net/layouttestresults.py:
1661         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1662         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1663         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1664         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1665         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
1666         * Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py:
1667         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1668         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1669         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1670         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1671         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1672         * Scripts/webkitpy/tool/commands/queues.py:
1673         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1674
1675 2011-01-05  Eric Seidel  <eric@webkit.org>
1676
1677         Unreviewed.
1678
1679         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
1680         https://bugs.webkit.org/show_bug.cgi?id=51802
1681
1682         Add another unit test to cover a previously missing import.
1683
1684         * Scripts/webkitpy/common/net/layouttestresults.py:
1685         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1686
1687 2011-01-05  Mihai Parparita  <mihaip@chromium.org>
1688
1689         Reviewed by David Levin.
1690
1691         Add mihaip@chromium.org as a reviewer
1692         https://bugs.webkit.org/show_bug.cgi?id=51966
1693         
1694         Add myself as a reviewer.
1695
1696         * Scripts/webkitpy/common/config/committers.py:
1697
1698 2011-01-05  James Simonsen  <simonjam@chromium.org>
1699
1700         Unreviewed. Adding myself to the list of committers.
1701
1702         * Scripts/webkitpy/common/config/committers.py:
1703
1704 2011-01-05  Eric Seidel  <eric@webkit.org>
1705
1706         Unreviewed.
1707
1708         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
1709         https://bugs.webkit.org/show_bug.cgi?id=51802
1710
1711         Fix two exceptions seen on the bots after my original commit.
1712
1713         * Scripts/webkitpy/common/net/layouttestresults.py:
1714         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1715
1716 2011-01-05  Kundu Suchismita  <suchi.kundu@nokia.com>
1717
1718         Reviewed by Andreas Kling.
1719
1720         [Qt]Add local storage settings to QtTestBrowser command line arguments 
1721         https://bugs.webkit.org/show_bug.cgi?id=51750
1722
1723         * QtTestBrowser/main.cpp:
1724         (LauncherApplication::handleUserOptions):
1725          Local storage settings can be enable form command line arguments for
1726          QtTestBrowser.
1727
1728 2011-01-05  Chris Fleizach  <cfleizach@apple.com>
1729
1730         Reviewed by Martin Robinson.
1731
1732         GTK: AX: DRT needs to use correct root object method.
1733         https://bugs.webkit.org/show_bug.cgi?id=51911
1734
1735         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
1736         (AccessibilityController::rootElement):
1737
1738 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
1739
1740         Rubber-stamped by Csaba Osztrogonác.
1741
1742         Based on idea from Péter Gál.
1743
1744         * Scripts/webkitpy/tool/bot/sheriff.py: Remove unnecessary apostrophes around revision numbers.
1745
1746 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
1747
1748         Reviewed by Adam Barth.
1749
1750         sheriff-bot should be able to do multi-revision rollouts
1751         https://bugs.webkit.org/show_bug.cgi?id=51176
1752
1753         * Scripts/webkitpy/tool/bot/irc_command.py:
1754         * Scripts/webkitpy/tool/bot/sheriff.py:
1755         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
1756
1757 2011-01-05  Eric Seidel  <eric@webkit.org>
1758
1759         Reviewed by Adam Barth.
1760
1761         queues.webkit.org should have per-bot status pages
1762         https://bugs.webkit.org/show_bug.cgi?id=51906
1763
1764         Just adds a /queue-status/QUEUE_NAME/bots/BOT_ID page to show
1765         statuses from a single queue.  Now that we have many bots servicing
1766         some queues (commit-queue, win-ews, etc.) its easy to have the messages
1767         you care about scroll off the end of the 15-message limit on the main page.
1768
1769         Eventually we should probably rename /queue-status to /queue or /queues,
1770         but that's fodder for another patch.
1771
1772         * QueueStatusServer/handlers/queuestatus.py:
1773         * QueueStatusServer/index.yaml:
1774         * QueueStatusServer/main.py:
1775         * QueueStatusServer/templates/includes/singlequeuestatus.html:
1776          - This probably should use a custom filter instead of hard-coding
1777            the URL scheme here, but I couldn't figure out how to easily
1778            create such a filter.  Most filters work with "strings" so we can't
1779            pass the status object.  We could add a method to the status
1780            object and call that, but that seemed a bit strange too.
1781         * QueueStatusServer/templates/queuestatus.html:
1782
1783 2011-01-05  Carlos Garcia Campos  <cgarcia@igalia.com>
1784
1785         Unreviewed. Adding myself to the list of committers.
1786
1787         * Scripts/webkitpy/common/config/committers.py:
1788
1789 2011-01-04  Koan-Sin Tan  <koansin.tan@gmail.com>
1790
1791         Reviewed by David Levin.
1792
1793         check-webkit-style treated some macros with parentheses after #elif as function calls
1794         https://bugs.webkit.org/show_bug.cgi?id=51695
1795
1796         Ingore function call space checking in any preprocessor directives
1797         (things starting with #). Change search() to match() because 
1798         preprocessor directives are supposed to be in the beginning of lines.
1799
1800         * Scripts/webkitpy/style/checkers/cpp.py:
1801         * Scripts/webkitpy/style/checkers/cpp_unittest.py: make sure there is no false positives for #elif cases
1802
1803 2011-01-04  Søren Gjesse  <sgjesse@chromium.org>
1804
1805         Reviewed by Tony Chang.
1806
1807         Change the --multi-load test option to --stress-opt
1808         https://bugs.webkit.org/show_bug.cgi?id=50751
1809
1810         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1811         (runTest):
1812         (main):
1813         * DumpRenderTree/chromium/TestShell.cpp:
1814         (TestShell::TestShell):
1815         * DumpRenderTree/chromium/TestShell.h:
1816         (TestShell::stressOpt):
1817         (TestShell::setStressOpt):
1818         (TestShell::stressDeopt):
1819         (TestShell::setStressDeopt):
1820         (TestShell::javaScriptFlags):
1821         (TestShell::setJavaScriptFlags):
1822         * Scripts/webkitpy/layout_tests/port/chromium.py:
1823         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1824
1825 2011-01-04  Chris Fleizach  <cfleizach@apple.com>
1826
1827         Reviewed by Sam Weinig.
1828
1829         WK2: Support Accessibility
1830         https://bugs.webkit.org/show_bug.cgi?id=51859
1831
1832         Use rootObject() method to get top of accessibility tree.
1833
1834         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
1835         (AccessibilityController::focusedElement):
1836         (AccessibilityController::rootElement):
1837
1838 2011-01-03  Martin Robinson  <mrobinson@igalia.com>
1839
1840         Reviewed by Darin Adler.
1841
1842         Remove the last non-GObject usage of PlatformRefPtr and move the code to GRefPtr
1843         https://bugs.webkit.org/show_bug.cgi?id=51846
1844
1845         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: Change usage of PlatformRefPtr
1846         back to GRefPtr.
1847
1848 2011-01-04  Zhe Su  <suzhe@chromium.org>
1849
1850         Reviewed by Kenneth Russell.
1851
1852         Fix insertText, setMarkedText and unmarkText methods of
1853         TextInputController to call corresponding methods of WebKit::WebView
1854         rather than WebKit::WebFrame. This change matches the behavior of
1855         chromium browser.
1856         insertText corresponds to WebView::confirmComposition(text)
1857         setMarkedText corresponds to WebView::setComposition(...)
1858         unmarkText corresponds to WebView::confirmComposition()
1859         https://bugs.webkit.org/show_bug.cgi?id=51693
1860
1861         * DumpRenderTree/chromium/TextInputController.cpp:
1862         (TextInputController::insertText):
1863         (TextInputController::setMarkedText):
1864         (TextInputController::unmarkText):
1865
1866 2011-01-04  Dihan Wickremasuriya  <dihan.wickremasuriya@nokia.com>
1867
1868         Reviewed by Laszlo Gombos.
1869
1870         [Qt] [Symbian] Do not remove 0 byte sized files from productDir
1871
1872         On Symbian productDir points to the source directory. Removing all the
1873         empty files from the productDir directory corrupts the svn repository.
1874
1875         * Scripts/build-webkit:
1876
1877 2011-01-03  Yi Shen  <yi.4.shen@nokia.com>
1878
1879         Reviewed by Adam Barth.
1880
1881         [Qt] Add SelectAll option to the context menu for the editor
1882         https://bugs.webkit.org/show_bug.cgi?id=50049
1883
1884         Set shortcut for the SelectAll action.
1885
1886         * QtTestBrowser/mainwindow.cpp:
1887         (MainWindow::buildUI):
1888
1889 2011-01-03  David Levin  <levin@chromium.org>
1890
1891         Reviewed by Eric Seidel.
1892
1893         check-webkit-style shouldn't consider "value" automatically to be a meaningless name.
1894         https://bugs.webkit.org/show_bug.cgi?id=51842
1895
1896         * Scripts/webkitpy/style/checkers/cpp.py: Remove the check for value.
1897         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Remove the test for value.
1898
1899 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
1900
1901         Reviewed by David Kilzer.
1902
1903         [WINCE] Adds a build slave.
1904         https://bugs.webkit.org/show_bug.cgi?id=50523
1905
1906         * BuildSlaveSupport/build.webkit.org-config/config.json: Add an
1907         entry for a release build of the WinCE port.
1908         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add platform
1909         flag to build the WinCE port.
1910
1911 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
1912
1913         Reviewed by David Kilzer.
1914
1915         Add WinCE support to build-webkit
1916         https://bugs.webkit.org/show_bug.cgi?id=51642
1917
1918         * Scripts/build-webkit:
1919         * Scripts/webkitdirs.pm:
1920
1921 2011-01-03  Eric Seidel  <eric@webkit.org>
1922
1923         Reviewed by Adam Barth.
1924
1925         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
1926         https://bugs.webkit.org/show_bug.cgi?id=51802
1927
1928         I'm not the biggest fan of the test_failures or test_results classes,
1929         but it's better to have one shared set of classes, than separate ones
1930         for new vs. old run-webkit-test result handling.
1931
1932         This moves the ORWT results class "LayoutTestResults" over to using
1933         TestResult and TestFailure classes, making it easy for us to
1934         make all our sheriff-bot and other webkitpy code NRWT ready.
1935
1936         This also makes it a trivial patch to generate results.json information
1937         from ORWT results.html files (for flaky test analysis, etc.) as well
1938         as making it a one-liner to report test failure types when the
1939         commit-queue sees flaky tests.
1940
1941         This patch tried not to add new functionality, but only to replace
1942         the guts of LayoutTestResults, while adding unit tests and hoping
1943         not to break anything.
1944
1945         I also moved callers which assumed User.prompt* were static/class methods
1946         to using them as instance methods (since we'll eventually want to make them such).
1947
1948         In the process of re-writing things, I broke the rebaseline command, so I wrote
1949         a unit test to catch my breakage were I do do so again in the future.
1950
1951         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1952         * Scripts/webkitpy/common/net/layouttestresults.py:
1953         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1954         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1955         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
1956         * Scripts/webkitpy/tool/commands/queries.py:
1957         * Scripts/webkitpy/tool/commands/rebaseline.py:
1958         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1959         * Scripts/webkitpy/tool/mocktool.py:
1960
1961 2011-01-03  Adam Barth  <abarth@webkit.org>
1962
1963         Reviewed by Simon Fraser.
1964
1965         webkit-patch shouldn't waste time cleaning a working directory that's already clean
1966         https://bugs.webkit.org/show_bug.cgi?id=51840
1967
1968         * Scripts/webkitpy/common/checkout/scm.py:
1969
1970 2011-01-03  Adam Barth  <abarth@webkit.org>
1971
1972         Reviewed by Simon Fraser.
1973
1974         webkit-patch should only hide update output if --quiet
1975         https://bugs.webkit.org/show_bug.cgi?id=51838
1976
1977         As requested by smfr.
1978
1979         * Scripts/webkitpy/tool/steps/update.py:
1980
1981 2011-01-03  Adam Barth  <abarth@webkit.org>
1982
1983         Reviewed by David Levin.
1984
1985         commit-queue shouldn't reject patches twice if two bots process the same patch
1986         https://bugs.webkit.org/show_bug.cgi?id=51805
1987
1988         Before raising an error, we first check whether the patch is still in
1989         the commit-queue.  This check is still racy, of course, but the time
1990         window is much smaller.
1991
1992         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1993
1994 2011-01-03  Sam Weinig  <sam@webkit.org>
1995
1996         Reviewed by Anders Carlsson.
1997
1998         Make run-api-tests less chatty.
1999         https://bugs.webkit.org/show_bug.cgi?id=51831
2000
2001         - Make script quiet by default and add --verbose option (replacing --quiet).
2002         - When not verbose, pipe stdout and stderr to devnull.
2003
2004         * Scripts/run-api-tests:
2005
2006 2011-01-03  Pratik Solanki  <psolanki@apple.com>
2007
2008         Unreviewed. Adding myself to committers.py.
2009
2010         * Scripts/webkitpy/common/config/committers.py:
2011
2012 2011-01-03  Koan-Sin Tan  <koansin.tan@gmail.com>
2013
2014         Reviewed by Xan Lopez.
2015
2016         "Tool/Scripts/run-launcher --gtk" stopped working after 74855
2017         https://bugs.webkit.org/show_bug.cgi?id=51806
2018
2019         Originally, the $libraryName is 'JavaScriptCore'. When building release 
2020         one, the $libraryDir was 'WebKitBuild/Release/JavaScriptCore/../.libs/'
2021         which doesn't exist anymore ('WebKitBuild/Release/JavaScriptCore'
2022         is 'WebKitBuild/Release/Source/JavaScriptCore' now), and 
2023         'WebKitBuild/Release/Source/JavaScriptCore/../../.libs' looks weird,
2024         so make it 'WebKitBuild/Release/.libs'
2025
2026         * Scripts/webkitdirs.pm: 
2027
2028 2011-01-02  Patrick Gansterer  <paroga@webkit.org>
2029
2030         Reviewed by Adam Barth.
2031
2032         Make EFL a core builder
2033         https://bugs.webkit.org/show_bug.cgi?id=51804
2034
2035         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2036         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2037
2038 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
2039
2040         [Qt] Unreviewed fix after r74855 and r74875.
2041
2042         * BuildSlaveSupport/built-product-archive:
2043          - Create directories explicitly.
2044          - Pass shell=True to subprocess.call().
2045
2046 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
2047
2048         [Qt] Unreviewed fix after r74855.
2049
2050         Move JavaScriptCore to Source
2051         https://bugs.webkit.org/show_bug.cgi?id=51604
2052
2053         * BuildSlaveSupport/built-product-archive: JavaScriptCore -> Source/JavaScriptCore
2054
2055 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
2056
2057         [Qt] Unreviewed run-javasriptcore-tests fix after r74855.
2058
2059         Move JavaScriptCore to Source
2060         https://bugs.webkit.org/show_bug.cgi?id=51604
2061
2062         * Scripts/webkitdirs.pm:
2063
2064 2011-01-02  Robert Hogan  <robert@webkit.org>
2065
2066         Unreviewed, build fix.
2067
2068         [Qt] Fix DRT build after 74855
2069
2070         * DumpRenderTree/qt/DumpRenderTree.pro:
2071
2072 2011-01-01  Adam Barth  <abarth@webkit.org>
2073
2074         Remove the assumption from the Qt and Gtk builds that every project is
2075         in the root directory.
2076
2077         * Scripts/build-webkit:
2078
2079 2011-01-01  Adam Barth  <abarth@webkit.org>
2080
2081         Reviewed by Eric Seidel.
2082
2083         Teach svn-apply how to apply patches even though JavaScriptCore has moved
2084         https://bugs.webkit.org/show_bug.cgi?id=51796
2085
2086         After this change, svn-apply will magically apply patches to
2087         JavaScriptCore/foo to Source/JavaScriptCore/foo.
2088
2089         * Scripts/VCSUtils.pm:
2090
2091 2011-01-01  Adam Barth  <abarth@webkit.org>
2092
2093         Reviewed by Eric Seidel.
2094
2095         Move JavaScriptCore to Source
2096         https://bugs.webkit.org/show_bug.cgi?id=51604
2097
2098         Update references to JavaScriptCore to point to the new location.
2099
2100         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2101         * DumpRenderTree/qt/DumpRenderTree.pro:
2102         * DumpRenderTree/qt/ImageDiff.pro:
2103         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2104         * DumpRenderTree/wscript:
2105         * Scripts/build-jsc:
2106         * Scripts/build-webkit:
2107         * Scripts/do-file-rename:
2108         * Scripts/do-webcore-rename:
2109         * Scripts/run-javascriptcore-tests:
2110         * Scripts/update-javascriptcore-test-results:
2111         * Scripts/webkitdirs.pm:
2112         * Scripts/webkitpy/common/config/build_unittest.py:
2113         * Scripts/webkitpy/style/checker.py:
2114         * Scripts/webkitpy/style/checker_unittest.py:
2115         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2116         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2117         * WebKitTestRunner/qt/WebKitTestRunner.pro:
2118         * wx/build/settings.py:
2119
2120 2011-01-01  Adam Barth  <abarth@webkit.org>
2121
2122         Reviewed by Eric Seidel.
2123
2124         Move Sources to Source
2125         https://bugs.webkit.org/show_bug.cgi?id=51794
2126
2127         Update scripts to point to the new location.
2128
2129         * Scripts/build-webkit:
2130         * Scripts/do-file-rename:
2131         * Scripts/do-webcore-rename:
2132         * Scripts/webkitpy/common/config/build.py:
2133         * Scripts/webkitpy/common/config/build_unittest.py:
2134
2135 2010-12-31  Kent Tamura  <tkent@chromium.org>
2136
2137         Reviewed by Eric Seidel.
2138
2139         [DRT/Chromium] Enable mock spell checker on non-OSX
2140         https://bugs.webkit.org/show_bug.cgi?id=51401
2141
2142         * DumpRenderTree/chromium/WebViewHost.cpp:
2143         (WebViewHost::spellCheck):
2144
2145 2010-12-31  Adam Barth  <abarth@webkit.org>
2146
2147         Reviewed by Ariya Hidayat.
2148
2149         Remove Tools/Scripts/wkstyle
2150         https://bugs.webkit.org/show_bug.cgi?id=51774
2151
2152         This script appears to not have been touched in a while and seems to
2153         have been replaced by check-webkit-style.
2154
2155         * Scripts/wkstyle: Removed.
2156
2157 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
2158
2159         Unreviewed. Coding style fix.
2160
2161         * DumpRenderTree/chromium/TestShell.h:
2162
2163 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
2164
2165         Reviewed by Pavel Feldman.
2166
2167         Web Inspector: [Chromium] Inspector's tests are very slow on Win(Dbg).
2168
2169         It was a problem with Chromium DRT. DevToolsAgent object instance was
2170         attached not only to the inspected page but to the DevTools window too.
2171         As result all the inspector files were interpreted as a content of inspected page
2172         and were transfered to the DevTools scripts panel for debugging etc.
2173
2174         https://bugs.webkit.org/show_bug.cgi?id=51735
2175
2176         * DumpRenderTree/chromium/TestShell.cpp:
2177         (TestShell::TestShell):
2178         (TestShell::bindJSObjectsToWindow):
2179         (TestShell::createNewWindow):
2180         * DumpRenderTree/chromium/TestShell.h:
2181
2182 2010-12-31  Adam Barth  <abarth@webkit.org>
2183
2184         Rubber-stamped by Eric Seidel.
2185
2186         Move PageLoadTests to PerformanceTests/PageLoad
2187         https://bugs.webkit.org/show_bug.cgi?id=51771
2188
2189         Update references to PageLoadTests to point to the new location.
2190
2191         * Scripts/run-pageloadtest:
2192         * Scripts/webkitpy/common/config/build.py:
2193
2194 2010-12-31  Adam Barth  <abarth@webkit.org>
2195
2196         Rubber-stamped by Eric Seidel.
2197
2198         Move SunSpider into PerformanceTests
2199         https://bugs.webkit.org/show_bug.cgi?id=51769
2200
2201         Update these scripts to point to the new location.
2202
2203         * Scripts/run-sunspider:
2204         * Scripts/sunspider-compare-results:
2205
2206 2010-12-30  Mihai Parparita  <mihaip@chromium.org>
2207
2208         Reviewed by Kent Tamura.
2209
2210         [Chromium] Add WebThemeEngineDRTMac so that Chromium DRT scrollbar rendering can match the Mac port's
2211         https://bugs.webkit.org/show_bug.cgi?id=51728
2212         
2213         Add implementation of the Mac WebThemeEngine that uses an NSScroller
2214         to render top-level scrollbars. This makes them match the Mac port's
2215         use of an NSScrollView, which means that we'll be able to share more
2216         pixel baselines.
2217         
2218         The new rendering code will not be activated until the 
2219         USE_WEB_THEME_ENGINE_TO_PAINT_THUMB #define is fliped in
2220         ScrollbarThemeChromiumMac.
2221
2222         * DumpRenderTree/DumpRenderTree.gypi:
2223         * DumpRenderTree/chromium/TestShellMac.mm:
2224         (platformInit):
2225         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Added.
2226         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Added.
2227         (+[FakeActiveWindow alwaysActiveWindow]):
2228         (+[FakeActiveWindow alwaysInactiveWindow]):
2229         (-[FakeActiveWindow initWithActiveControls:]):
2230         (-[FakeActiveWindow _hasActiveControls]):
2231         (WebThemeEngineDRTMac::paintScrollbarThumb):
2232         (stateToHIEnableState):
2233         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
2234         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
2235
2236 2010-12-30  Konstantin Tokarev  <annulen@yandex.ru>
2237
2238         Reviewed by David Kilzer.
2239
2240         [Qt] Don't build wtf/TCSystemAlloc.cpp if --system-malloc option is
2241         used
2242         https://bugs.webkit.org/show_bug.cgi?id=51672
2243
2244         * DumpRenderTree/qt/DumpRenderTree.pro: Replaced USE_SYSTEM_MALLOC
2245         with USE_SYSTEM_MALLOC=1
2246         * WebKitTestRunner/qt/WebKitTestRunner.pro: Replaced USE_SYSTEM_MALLOC
2247         with USE_SYSTEM_MALLOC=1
2248
2249 2010-12-30  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2250
2251         Reviewed by David Kilzer.
2252
2253         [Qt] [Symbian] Fix build-webkit script for Symbian
2254         https://bugs.webkit.org/show_bug.cgi?id=51509
2255
2256         Set the OUTPUT_DIR for Symbian to be the same as the source
2257         directory.
2258
2259         * Scripts/webkitdirs.pm:
2260
2261 2010-12-30  Martin Robinson  <mrobinson@igalia.com>
2262
2263         Reviewed by Darin Adler.
2264
2265         check-webkit-style should ignore NULL usage in calls to gtk_widget_style_get
2266         https://bugs.webkit.org/show_bug.cgi?id=51758
2267
2268         Add a check-webkit-style exception for gtk_widget_style_get and NULL usage.
2269
2270         * Scripts/webkitpy/style/checkers/cpp.py: Add the exception.
2271         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Add some tests for this.
2272
2273 2010-12-29  Patrick Gansterer  <paroga@webkit.org>
2274
2275         Unreviewed WinCE buildfix.
2276
2277         * WinCELauncher/main.cpp: Add missing include.
2278
2279 2010-12-29  Daniel Bates  <dbates@rim.com>
2280
2281         Reviewed by Darin Adler.
2282
2283         svn-apply updates date of wrong change log entry for a change log diff that
2284         contains two consecutive entries with the same author and date
2285         https://bugs.webkit.org/show_bug.cgi?id=46061
2286
2287         Fixes an issue where the date of the wrong change log entry may be modified.
2288         Moreover, changes fixChangeLogPatch() to move entries inserted earlier
2289         in a ChangeLog file to the top of the file.
2290
2291         Currently, fixChangeLogPatch() explicitly bails out and returns an unchanged
2292         diff when it detects that the diff inserts a change log entry earlier in a
2293         ChangeLog. It is unusual to land a patch that has such a deliberate ChangeLog
2294         change. With the advent of the commit-queue this functionality of bailing out
2295         and hence landing the patch as-is is harmful to the accuracy of the ChangeLog.
2296         Instead, we should always move the change log entry to the top of the ChangeLog file.
2297
2298         A side-effect of this change is that setChangeLogDateAndReviewer() now updates
2299         the date line of the correct change log entry in a ChangeLog diff.
2300
2301         * Scripts/VCSUtils.pm: Modified fixChangeLogPatch() to move entries inserted earlier to the top.
2302
2303         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
2304           Updated the following unit tests now that we move entries inserted earlier to the top:
2305           - "fixChangeLogPatch: New entry inserted in middle."
2306             (formerly named "fixChangeLogPatch: [no change] New entry inserted in middle.")
2307
2308           - "fixChangeLogPatch: New entry inserted earlier in the file, but after an entry with the same author and date."
2309             (formerly named "fixChangeLogPatch: [no change] New entry inserted earlier in the file, but after an entry with the same author and date.")
2310
2311         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatchThenSetChangeLogDateAndReviewer.pl: Added.
2312
2313 2010-12-29  Konstantin Tokarev  <annulen@yandex.ru>
2314
2315         Reviewed by Eric Seidel.
2316
2317         [Qt] Fixed compatibility with gold linker on X11 platforms
2318         https://bugs.webkit.org/show_bug.cgi?id=51700
2319
2320         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2321         Linked TestNetscapePlugin with libX11 on Unix platforms
2322
2323 2010-12-29  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>
2324
2325         Reviewed by Darin Adler.
2326
2327         Circular dependency in webkitpy.common.checkout.changelog module
2328         https://bugs.webkit.org/show_bug.cgi?id=50475
2329
2330         Remove automatic import of api.Checkout module when any checkout/
2331         submodule is imported (e.g.: when checkout.scm.Git is imported).
2332
2333         * Scripts/webkitpy/common/checkout/__init__.py:
2334
2335 2010-12-29  Martin Robinson  <mrobinson@igalia.com>
2336
2337         Reviewed by Ojan Vafai.
2338
2339         prepare-ChangeLog should support the -g option for specifying the git-commit
2340         https://bugs.webkit.org/show_bug.cgi?id=51708
2341
2342         Add a -g shortcut for the --git-commit prepare-ChangeLog option. This matches
2343         webkit-patch, though the exact meaning of the two options remain different.
2344
2345         * Scripts/prepare-ChangeLog: Add -g.
2346
2347 2010-12-29  Kent Hansen  <kent.hansen@nokia.com>
2348
2349         Reviewed by Simon Hausmann.
2350
2351         [Qt] Fix compilation with Qt in namespace
2352         https://bugs.webkit.org/show_bug.cgi?id=51701
2353
2354         * QtTestBrowser/webview.h:
2355
2356 2010-12-28  Daniel Bates  <dbates@rim.com>
2357
2358         Reviewed by Sam Weinig.
2359
2360         Substitute // MARK: for compiler-specific #pragma mark
2361         https://bugs.webkit.org/show_bug.cgi?id=51657
2362
2363         Fix future compilation warnings about "#pragma mark" on GTK+ bots by
2364         substituting  "// MARK:" for "#pragma mark", which provides
2365         analogous code-bookmarking functionality under Xcode.
2366
2367         Also, for consistency, we should substitute "// MARK:" for compiler-
2368         specific "#pragma mark" in the source files for the Mac port.
2369
2370         * DumpRenderTree/AccessibilityTextMarker.cpp:
2371         * DumpRenderTree/cf/WebArchiveDumpSupport.h:
2372         * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm:
2373         * DumpRenderTree/mac/ObjCController.m:
2374         * MiniBrowser/mac/AppDelegate.m:
2375         * MiniBrowser/mac/BrowserWindowController.m:
2376
2377 2010-12-28  Xan Lopez  <xlopez@igalia.com>
2378
2379         Reviewed by Eric Seidel.
2380
2381         Add --no-build option to run-sunspider
2382         https://bugs.webkit.org/show_bug.cgi?id=51658
2383
2384         * Scripts/run-sunspider: add --no-build flag to skip building
2385         phase.
2386
2387 2010-12-27  Daniel Bates  <dbates@rim.com>
2388
2389         Rubber-stamped by Martin Robinson.
2390
2391         Append the directory Tools/DumpRenderTree to the list of directories that
2392         do-webcore-rename should search so that it can rename DRT files and
2393         source code.
2394
2395         * Scripts/do-webcore-rename:
2396
2397 2010-12-27  Eric Seidel  <eric@webkit.org>
2398
2399         Reviewed by Adam Barth.
2400
2401         build-webkit should detect missing Java SDK and explain how to install it
2402         https://bugs.webkit.org/show_bug.cgi?id=51651
2403
2404         * Scripts/build-webkit:
2405
2406 2010-12-26  Martin Robinson  <mrobinson@igalia.com>
2407
2408         Reviewed by Daniel Bates.
2409
2410         [GTK] Add support for build-jsc
2411         https://bugs.webkit.org/show_bug.cgi?id=51625
2412
2413         Add GTK+ support to build-jsc now that building the jsc executable as
2414         a standalone target is easy.
2415
2416         * Scripts/build-jsc: Call buildGtkProject for the GTK+ case now.
2417         * Scripts/build-webkit: Pass in the proper target name to buildGtkProject.
2418         * Scripts/webkitdirs.pm: Actually process the project parameter in buildGtkProject
2419         and pass it along to buildAutotoolsProject.
2420
2421 2010-12-27  David Levin  <levin@chromium.org>
2422
2423         Reviewed by Eric Seidel.
2424
2425         check-webkit-style check for meaningless variable names in function declarations.
2426         https://bugs.webkit.org/show_bug.cgi?id=51523
2427
2428         * Scripts/webkitpy/style/checker.py: Exempted JavaScriptCore/jit/JITStubs.cpp
2429         from the new check and whitespace/parens because the syntax is unusual and
2430         produced a fair number of positives for these checks.
2431         * Scripts/webkitpy/style/checkers/cpp.py:
2432         (_convert_to_lower_with_underscores): Used as a canonical form for type names
2433         and parameter names when determining if the parameter name is useless.
2434         (_create_acronym): Used to check for redundant variable names in cases like "ExceptionCode ec"
2435         (Parameter.lower_with_underscores_name): Gives back the parameter name in a lower_with_underscore
2436         format.
2437         (_check_parameter_name_against_text):  Checks to see if the parameter name is in the
2438         text or an acronym of it.
2439         (check_function_definition): Checks function definitions for meaningless variable names.
2440         (process_line): Added call to check_function_definition.
2441         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2442         (CppFunctionsTest.test_convert_to_lower_with_underscores): Test for _convert_to_lower_with_underscores.
2443         (CppFunctionsTest.test_create_acronym): Test for _create_acronym.
2444         (CppFunctionsTest.test_check_parameter_against_text): Test for _check_parameter_against_text.
2445         (CppStyleTestBase.perform_single_line_lint): Removed the parameter name check
2446         because when only checking a snippet, there are a lot of bogus functions.
2447         (CppStyleTestBase.perform_multi_line_lint): Ditto and removed a bogus filter
2448         that I put there previously and just noticed.
2449         (WebKitStyleTest.test_parameter_names): Tests for the functionality -- both
2450         check_function_definition and process_line.
2451
2452 2010-12-27  Carlos Garcia Campos  <cgarcia@igalia.com>
2453
2454         Reviewed by Martin Robinson.
2455
2456         [GTK] Disable flash plugin in GtkLauncher when using gtk3
2457         https://bugs.webkit.org/show_bug.cgi?id=51591
2458
2459         Flash plugin uses gtk2 that is incompatible with gtk3 making
2460         webkit crash when it's built with gtk3.
2461
2462         * GtkLauncher/main.c:
2463         (main):
2464
2465 2010-12-25  Adam Barth  <abarth@webkit.org>
2466
2467         Reviewed by Eric Seidel.
2468
2469         Move ANGLE to Sources/ThirdParty
2470         https://bugs.webkit.org/show_bug.cgi?id=51605
2471
2472         * Scripts/build-webkit:
2473           - Point to the new ANGLE location.
2474
2475 2010-12-26  David Levin  <levin@chromium.org>
2476
2477         Reviewed by Eric Seidel.
2478
2479         check-webkit-style should be able to parse function declaration parameters.
2480         https://bugs.webkit.org/show_bug.cgi?id=51451
2481
2482         * Scripts/webkitpy/style/checkers/cpp.py:
2483         (Position.__init__): Holds simple position information (row, column).
2484         (Parameter.__init__): Holds information about a parameter.
2485         (SingleLineView.__init): Converts multiple lines into a single line for simpler searches.
2486         (SingleLineView.convert_column_to_row): Returns the original row given a column.
2487         (create_skeleton_parameters): Simplifies a parameter list for easier searching.
2488         (find_parameter_name_index): Finds where the parameter name is.
2489         (parameter_list): Generates the list of parameters for a function.
2490         (_FunctionState.begin): Added information to allow determining the parameters
2491         on demand.
2492         (_FunctionState.get_parameter_list): Returns a tuple of function parameters.
2493         (detect_functions): Improve function detection for operator functions and
2494         determine where the parameters end and pass that to _FunctionState.begin.
2495         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2496         (CppFunctionsTest.test_parameter): Verifies Parameter functionality.
2497         (CppFunctionsTest.test_single_line_view): Verifies SingleLineView functionality.
2498         (CppFunctionsTest.test_create_skeleton_parameters): Verifies create_skeleton_parameters.
2499         (CppFunctionsTest.test_find_parameter_name_index): Verifies find_parameter_name_index.
2500         (CppFunctionsTest.test_parameter_list): Does some minimal verification for parameter list.
2501         Much more thorough verification is done as part of FunctionDetectionTest.test_parameter_list.
2502         (FunctionDetectionTest.perform_function_detection): Added support for verifying
2503         the parameters found.
2504         (FunctionDetectionTest.test_function_declaration_detection): Added more function
2505         detection test to verify that we catch the operator functions.
2506         (FunctionDetectionTest.test_ignore_macros): Verify that function detection ignores macros.
2507         (FunctionDetectionTest.test_parameter_list): Added tests to verify the parameter parsing.
2508         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_bad_test_doesnt_break): Removed
2509         because the error. The test is about the bad function name. Fixing the name makes the test exactly like
2510         test_function_length_check_definition_severity1_for_test.
2511
2512 2010-12-25  Patrick Gansterer  <paroga@webkit.org>
2513
2514         Unreviewed WinCE buildfix after r74334.
2515
2516         * CMakeListsWinCE.txt:
2517
2518 2010-12-24  Sheriff Bot  <webkit.review.bot@gmail.com>
2519
2520         Unreviewed, rolling out r74632.
2521         http://trac.webkit.org/changeset/74632
2522         https://bugs.webkit.org/show_bug.cgi?id=51600
2523
2524         makes test-webkitpy hang forever on GTK (Requested by philn-tp
2525         on #webkit).
2526
2527         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
2528         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
2529
2530 2010-12-24  Ryuan Choi  <ryuan.choi@samsung.com>
2531
2532         Reviewed by Kenneth Rohde Christiansen.
2533
2534         [EFL] Screen doesn't be rendered when changing size of EWebLauncher
2535         https://bugs.webkit.org/show_bug.cgi?id=43528
2536
2537         Remove on_resize because ewk_view_fixed_layout_size_set should not be
2538         called on callback of EVAS_CALLBACK_RESIZE. As it change size of
2539         FrameView, rendering was ignored when _ewk_view_smart_calculate was
2540         called.
2541
2542         * EWebLauncher/main.c:
2543         (browserCreate):
2544
2545 2010-12-24  Eric Seidel  <eric@webkit.org>
2546
2547         Reviewed by Adam Barth.
2548
2549         webkit-patch (or a pre-commit hook) needs to prevent bad ChangeLog changes
2550         https://bugs.webkit.org/show_bug.cgi?id=28291
2551
2552         This is a start.  At least now webkit-patch will prompt when your ChangeLog looks questionable.
2553         We could do more advanced things, like parsing the ChangeLog (with changelog.py) and comparing that
2554         to strings with find in the diff.
2555         Since non-interactive always returns the default, this should cause patches with bad changelogs to fail on the commit-queue.
2556
2557         * Scripts/webkitpy/common/checkout/api.py:
2558         * Scripts/webkitpy/common/checkout/diff_parser.py:
2559         * Scripts/webkitpy/tool/steps/abstractstep.py:
2560         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
2561         * Scripts/webkitpy/tool/steps/validatechangelogs.py: Copied from Tools/Scripts/webkitpy/tool/steps/validatereviewer.py.
2562         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py: Copied from Tools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.
2563         * Scripts/webkitpy/tool/steps/validatereviewer.py:
2564
2565 2010-12-24  Dirk Pranke  <dpranke@chromium.org>
2566
2567         Reviewed by Kenneth Russell.
2568
2569         Modify new-run-webkit-tests to shut up and exit when all the threads
2570         are wedged so that test runs complete faster and we don't end up
2571         w/ enormous log files.
2572
2573         https://bugs.webkit.org/show_bug.cgi?id=51572
2574
2575         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
2576         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
2577
2578 2010-12-24  Eric Seidel  <eric@webkit.org>
2579
2580         Reviewed by David Levin.
2581
2582         commit-queue should better explain how it will re-open bugs and follow duplicate chains
2583         https://bugs.webkit.org/show_bug.cgi?id=51549
2584
2585         I've had multiple people ask me about the commit-queue's behavior
2586         regarding reporting flaky tests.  I figured it would be best to just
2587         have the queue explain itself in the bugs it files.
2588
2589         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2590         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2591
2592 2010-12-24  Shinichiro Hamaji  <hamaji@chromium.org>
2593
2594         Reviewed by Eric Seidel.
2595
2596         check-webkit-style: should ignore "wrong" namings in JavaScriptCore/qt
2597         https://bugs.webkit.org/show_bug.cgi?id=51467
2598
2599         * Scripts/webkitpy/style/checker.py:
2600         * Scripts/webkitpy/style/checker_unittest.py:
2601
2602 2010-12-23  Adam Barth  <abarth@webkit.org>
2603
2604         Rubber-stamped by Eric Seidel.
2605
2606         Move JavaScriptGlue into Sources
2607         https://bugs.webkit.org/show_bug.cgi?id=51583
2608
2609         These tools refer to JavaScriptGlue and need to be updated to its new
2610         location.
2611
2612         * Scripts/build-webkit:
2613         * Scripts/do-file-rename:
2614         * Scripts/do-webcore-rename:
2615         * Scripts/webkitpy/common/config/build.py:
2616         * Scripts/webkitpy/common/config/build_unittest.py:
2617
2618 2010-12-23  Lucas Forschler  <lforschler@apple.com>
2619
2620         Reviewed by Eric Seidel.
2621
2622         Bug 51539 - update iexploder scripts to point to new location
2623
2624         * Scripts/run-iexploder-tests:
2625         * Scripts/update-iexploder-cssproperties:
2626
2627 2010-12-23  Evan Martin  <evan@chromium.org>
2628
2629         Reviewed by Ryosuke Niwa.
2630
2631         [chromium] LayoutTestController warning in float->int conversion
2632         https://bugs.webkit.org/show_bug.cgi?id=51553
2633
2634         Rather than reading an int, converting to a float, then getting a compiler
2635         warning on passing the float to something that expects an int, instead
2636         just pass around ints.
2637
2638         No tests, fixes a compiler warning.
2639
2640         * DumpRenderTree/chromium/LayoutTestController.cpp:
2641         (parsePageSizeParameters):
2642         (LayoutTestController::pageNumberForElementById):
2643         (LayoutTestController::numberOfPages):
2644
2645 2010-12-23  Lucas Forschler  <lforschler@apple.com>
2646
2647         Reviewed by Darin Adler.
2648
2649         Bug 51537 - iexploder needs cleanup
2650         
2651         * iExploder/htdocs: Removed.
2652         * iExploder/htdocs/config.rb: Removed.
2653         * iExploder/htdocs/cssproperties.in: Removed.
2654         * iExploder/htdocs/cssvalues.in: Removed.
2655         * iExploder/htdocs/htmlattrs.in: Removed.
2656         * iExploder/htdocs/htmltags.in: Removed.
2657         * iExploder/htdocs/htmlvalues.in: Removed.
2658         * iExploder/htdocs/iexploder.cgi: Removed.
2659         * iExploder/htdocs/iexploder.rb: Removed.
2660         * iExploder/htdocs/index.html: Removed.
2661         * iExploder/htdocs/webserver.rb: Removed.
2662         * iExploder/iexploder-1.7.2/output: Removed.
2663         * iExploder/tools: Removed.
2664         * iExploder/tools/lasthit.rb: Removed.
2665         * iExploder/tools/osx_last_crash.rb: Removed.
2666         * iExploder/tools/showtest.rb: Removed.
2667
2668 2010-12-23  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
2669
2670         Reviewed by Kenneth Rohde Christiansen.
2671
2672         [EFL] Make 'single' the default backing store in EWebLauncher
2673         https://bugs.webkit.org/show_bug.cgi?id=51534
2674
2675         'single' is the simplest backing store and the one intended to be the
2676         default in the test browser. By mistake the tiled backing store was
2677         left as default in r72617.
2678
2679         * EWebLauncher/main.c:
2680         (browserCreate): ditto.
2681
2682 2010-12-23  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
2683
2684         Reviewed by Kenneth Rohde Christiansen.
2685
2686         [EFL] Subject: [webkit 4/4] [EFL] Remove non-sense workaround
2687         https://bugs.webkit.org/show_bug.cgi?id=51533
2688
2689         There's no point in concatenating env("HOME") with "blah", so remove
2690         option from EWebLauncher.
2691
2692         * EWebLauncher/main.c:
2693         (main): ditto.
2694
2695 2010-12-23  Ilya Tikhonovsky  <loislo@chromium.org>
2696
2697         Reviewed by Eric Seidel.
2698
2699         Web Inspector: chromium: inspector's tests are quite slow especially at windows(Debug).
2700
2701         Almost all inspector's tests become flaky on chromium Win(dbg) after switching to DRT.
2702         I just discovered that we have two additional GC runs per each WebViewHost.
2703         Test_shell had no such calls.
2704         These gc runs eat 15% of cpu time.
2705
2706         https://bugs.webkit.org/show_bug.cgi?id=51479
2707
2708         * DumpRenderTree/chromium/WebViewHost.cpp:
2709         (WebViewHost::~WebViewHost):
2710
2711 2010-12-22  Dirk Pranke  <dpranke@chromium.org>
2712
2713         Reviewed by Ojan Vafai.
2714
2715         This change splits out the TestRunner class into its own file.
2716         When we fork the code for message passing, we will create a new
2717         TestRunner, and this change will allow that to be more modular.
2718
2719         While we're at it, split out TestInput and ResultSummary into
2720         their own files, to reduce the size of run_webkit_tests to
2721         something more managable.
2722
2723         https://bugs.webkit.org/show_bug.cgi?id=51092
2724
2725         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2726         * Scripts/webkitpy/layout_tests/layout_package/result_summary.py:
2727         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2728         * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
2729         * Scripts/webkitpy/layout_tests/layout_package/test_input.py:
2730         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2731         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2732
2733  2010-12-22  Dirk Pranke  <dpranke@chromium.org>
2734
2735         Reviewed by Ojan Vafai.
2736
2737         nrwt multiprocessing - start over, prepare to fork the code
2738  
2739         This code cleans up the signatures and implementation of the
2740         TestRunner class so we can easily fork it to run either the
2741         stable implementation or the new, unstable message-passing
2742         implementation. The two variants will have different
2743         implementations of the run_tests() method. We will switch
2744         between the two based on the setting for the '--worker-model'
2745         switch. We rename the two currently valid values to 'old-inline'
2746         and 'old-threads'.
2747
2748         https://bugs.webkit.org/show_bug.cgi?id=51081
2749
2750         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2751         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2752
2753 2010-12-22  Victor Wang  <victorw@chromium.org>
2754
2755         Reviewed by Darin Fisher.
2756
2757         [Chromium] Update chromium archive test result url in rebaseline script.
2758
2759         https://bugs.webkit.org/show_bug.cgi?id=51503
2760
2761         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2762
2763 2010-12-22  Lucas Forschler  <lforschler@apple.com>
2764
2765         Reviewed by Alice Liu.
2766
2767         <rdar://problem/8633222> record-memory-win needs to record memory used by the webprocess.
2768         Verified on Chrome, Safari, and IE.
2769         With this change, we will record memory from a parent browser window and all child processes.
2770
2771         * record-memory-win/main.cpp:
2772         (ProcessArgs):
2773         (PrintUsage):
2774         (getMemoryInfo):
2775         (printProcessInfo):
2776         (evalProcesses):
2777         (UseImage):
2778         (QueryContinuously):
2779         (ElapsedTime):
2780
2781 2010-12-22  Lucas Forschler  <lforschler@apple.com>
2782
2783         Unreviewed rollout r74489, because it was missing changelog.
2784
2785         * record-memory-win/main.cpp:
2786         
2787 2010-12-22  Ryosuke Niwa  <rniwa@webkit.org>
2788
2789         Adding myself as a reviewer.
2790
2791         * Scripts/webkitpy/common/config/committers.py:
2792
2793 2010-12-22  Andrew Scherkus  <scherkus@chromium.org>
2794
2795         Unreviewed.  Adding myself to committers.py.
2796
2797         * Scripts/webkitpy/common/config/committers.py:
2798
2799 2010-12-22  Ariya Hidayat  <ariya@sencha.com>
2800
2801         Reviewed by Kenneth Rohde Christiansen.
2802
2803         TestNetscapePlugIn should use #if defined
2804         https://bugs.webkit.org/show_bug.cgi?id=51471
2805
2806         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2807         (NP_Initialize):
2808         (NPP_New):
2809
2810 2010-12-22  Ilya Tikhonovsky  <loislo@chromium.org>
2811
2812         Reviewed by Yury Semikhatsky.
2813
2814         Web Inspector: [chromium] DRT inspector layout tests are flaky in debug.
2815
2816         DevTools window should be closed explicitly because it has custom deinitialization code.
2817
2818         https://bugs.webkit.org/show_bug.cgi?id=50722
2819
2820         * DumpRenderTree/chromium/TestShell.cpp:
2821         (TestShell::closeRemainingWindows):
2822
2823 2010-12-22  David Levin  <levin@chromium.org>
2824
2825         Reviewed by Shinichiro Hamaji.
2826
2827         check-webkit-style shouldn't complaint about underscores in variables in objective C files.
2828         https://bugs.webkit.org/show_bug.cgi?id=51452
2829
2830         * Scripts/webkitpy/style/checkers/cpp.py:
2831         (_FileState.__init__): Added the information to determine if a file is C or Objective C.
2832         Using the file extension if possible but falling back to the file contents if we have a header file.
2833         (_FileState.is_objective_c): Determine if we have an Objective C by examining the file contents if needed.
2834         (_FileState.is_c_or_objective_c):
2835         (check_using_std): Changed to using _FileState to determine the file type.
2836         (check_max_min_macros): Ditto.
2837         (check_for_null): Ditto.
2838         (check_style): Changed the parameters to various calls since they now need _FileState
2839         to determine the file type.
2840         (check_language): Added the file_state parameter so it could be passed
2841         to check_identifier_name_in_declaration.
2842         (check_identifier_name_in_declaration): Don't warn about underscores in variables if
2843         this is an Objective C file.
2844         (_process_lines): Added information for the _FileState constructor (and moved the
2845         call to a place that had the information).
2846         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2847         (CppFunctionsTest.test_is_c_or_objective_c): Changed the tests to use FileState and exercise
2848         its functionality.
2849         (WebKitStyleTest.test_names): Add tests for underscores in Objective C files.
2850
2851 2010-12-21  Andy Estes  <aestes@apple.com>
2852
2853         Reviewed by Mark Rowe.
2854
2855         Do not build non-Intel architectures for WebKit2-related projects.
2856         https://bugs.webkit.org/show_bug.cgi?id=51440
2857
2858         * MiniBrowser/Configurations/Base.xcconfig: Only build for i386 and x86_64.
2859         * TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
2860         * WebKitTestRunner/Configurations/Base.xcconfig: Ditto.
2861
2862 2010-12-21  Mihai Parparita  <mihaip@chromium.org>
2863
2864         Reviewed by Darin Fisher.
2865
2866         [Chromium] Rename WebThemeEngine/ControlDRT to WebThemeEngine/ControlDRTWin
2867         https://bugs.webkit.org/show_bug.cgi?id=51406 
2868         
2869         Rename WebThemeControlDRT to WebThemeControlDRTWin and WebThemeEngineDRT
2870         to WebThemeEngineDRTWin and update references everywhere.
2871
2872         * DumpRenderTree/DumpRenderTree.gypi:
2873         * DumpRenderTree/chromium/TestShellWin.cpp:
2874         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRT.cpp.
2875         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRT.h.
2876         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRT.cpp.
2877         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRT.h.
2878
2879 2010-12-21  Anders Carlsson  <andersca@apple.com>
2880
2881         Reviewed by John Sullivan.
2882
2883         Clicking missing plug-in text does not show a sheet
2884         https://bugs.webkit.org/show_bug.cgi?id=51403
2885
2886         Update for changes to the WebPageUIClient.
2887
2888         * MiniBrowser/mac/BrowserWindowController.m:
2889         (-[BrowserWindowController awakeFromNib]):
2890         * WebKitTestRunner/TestController.cpp:
2891         (WTR::createOtherPage):
2892         (WTR::TestController::initialize):
2893
2894 2010-12-21  Eric Seidel  <eric@webkit.org>
2895
2896         Reviewed by Adam Barth.
2897
2898         commit-queue will report constant failures as flaky if other tests flake
2899         https://bugs.webkit.org/show_bug.cgi?id=51272
2900
2901         This patch just removes functionality and adds testing.
2902         Previously we attempted to report flaky tests when we had
2903         two different tests fail in a row.  However, since we stop
2904         running the tests at the first failure, our code was wrong in
2905         trying to determine flakiness from the incomplete runs.
2906
2907         Originally I posted an alternate patch:
2908         https://bug-51272-attachments.webkit.org/attachment.cgi?id=77078
2909         which fixed our flaky logic in this case, however it was decided
2910         that that patch would be too difficult to maintain, so now
2911         I'm just removing the broken logic.
2912
2913         This will dramatically cut-down on our flaky-test false positives
2914         at the (small) cost of the queues being unable to report
2915         any flakiness if the tree is very flaky.  (With at least one test
2916         flaking on every run, we'll never report failures anymore.)  I think
2917         this is a tradeoff worth making.
2918
2919         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2920         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2921
2922 2010-12-20  Eric Seidel  <eric@webkit.org>
2923
2924         Reviewed by Adam Barth.
2925
2926         commit-queue wrongly rejects patches when it can't update itself
2927         https://bugs.webkit.org/show_bug.cgi?id=46636
2928
2929         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2930         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2931         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2932
2933 2010-12-20  Adam Barth  <abarth@webkit.org>
2934
2935         Move web sites to Websites directory
2936         https://bugs.webkit.org/show_bug.cgi?id=51323
2937
2938         Update references to BugsSite to point to the new location.
2939
2940         This patch was never officially reviewed (because it was too large to
2941         upload to bugs.webkit.org), but it was discussed on webkit-dev and Mark
2942         Rowe gave me the green light.
2943
2944         * Scripts/old-run-webkit-tests:
2945         * Scripts/webkitpy/common/config/build.py:
2946         * Scripts/webkitpy/common/config/build_unittest.py:
2947         * Scripts/webkitpy/common/prettypatch.py:
2948         * Scripts/webkitpy/layout_tests/port/base.py:
2949         * Scripts/webkitpy/style/main.py:
2950
2951 2010-12-20  Adrienne Walker  <enne@google.com>
2952
2953         Unreviewed. Adding myself to the list of committers.
2954
2955         * webkitpy/common/config/committers.py:
2956
2957 2010-12-20  Mark Rowe  <mrowe@apple.com>
2958
2959         Reviewed by Dan Bernstein.
2960
2961         <rdar://problem/8757601> Don't install header files in to the Resources directory.
2962
2963         * Scripts/check-for-inappropriate-files-in-framework: Don't allow .h files in the
2964         Resources directory.
2965
2966 2010-12-20  Eric Seidel  <eric@webkit.org>
2967
2968         Reviewed by Adam Barth.
2969
2970         commit-queue should include bot id when attaching failure diffs
2971         https://bugs.webkit.org/show_bug.cgi?id=51280
2972
2973         This is a tiny change to include the bot id in the name of the attachment.
2974         Most of this diff is just changing the unit test expectations
2975         now that I hid the comment printing when the comment is None.
2976
2977         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2978         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2979         * Scripts/webkitpy/tool/commands/upload_unittest.py:
2980         * Scripts/webkitpy/tool/mocktool.py:
2981
2982 2010-12-20  Jeff Miller  <jeffm@apple.com>
2983
2984         Reviewed by Dan Bernstein.
2985
2986         Tools/vcbin/midl.exe needs to be rebuilt
2987         https://bugs.webkit.org/show_bug.cgi?id=51347
2988
2989         * vcbin/midl.exe: Rebuilt.
2990
2991 2010-12-20  David Levin  <levin@chromium.org>
2992
2993         Reviewed by Ariya Hidayat.
2994
2995         .gitignore and webkit-tools-completion.sh have references to WebKitTools that should be Tools.
2996         https://bugs.webkit.org/show_bug.cgi?id=51343
2997
2998         Follow up from the WebKitTools -> Tools rename.
2999
3000         * Scripts/webkit-tools-completion.sh:
3001
3002 2010-12-20  Cosmin Truta  <ctruta@chromium.org>
3003
3004         Reviewed by James Robinson.
3005
3006         new-run-webkit-tests ignores trailing EOL differences in text tests
3007         https://bugs.webkit.org/show_bug.cgi?id=36983
3008
3009         Changed the handling of new-line characters within new-run-webkit-tests
3010         to match old-run-webkit-tests.  Differences in leading and trailing empty
3011         lines in text expectation files are no longer ignored.
3012
3013         * Scripts/webkitpy/layout_tests/port/base.py:
3014         * Scripts/webkitpy/layout_tests/port/test.py:
3015         Added unit tests.  Removed old duplicate unit test entries.
3016         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
3017
3018 2010-12-20  David Levin  <levin@chromium.org>
3019
3020         Reviewed by Shinichiro Hamaji.
3021
3022         check-webkit-style should detect function declarations (and trivial functions).
3023         https://bugs.webkit.org/show_bug.cgi?id=51303
3024
3025         * Scripts/webkitpy/style/checkers/cpp.py:
3026         (_FunctionState.begin): Add is_declaration and changed the line count
3027         start to begin at -1 (which will keep the results consistent, since
3028         the starting line number passed in is one less in this change).
3029         (detect_functions): changed function detection to now catch trivial
3030         functions and declarations.
3031         (check_pass_ptr_usage): Don't check for Pass*Ptr on the first line
3032         of the function as this may look at return values (when processing
3033         a declaration).
3034         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3035         (FunctionDetectionTest.perform_function_detection): Basic mechanics
3036         of testing the function detection.
3037         (FunctionDetectionTest.test_basic_function_detection): Test a simple
3038         function.
3039         (FunctionDetectionTest.test_function_declaration_detection): Test a
3040         declaration.
3041         (FunctionDetectionTest.test_non_functions): A test case for a case
3042         that caused the code to fail due to the { being in quotes.
3043         (PassPtrTest.test_pass_ref_ptr_return_value): Added some more test
3044         cases to help catch false alarms for return values.
3045         (PassPtrTest.test_pass_ref_ptr_member_variable): Ensure that
3046         we don't get false alarms for member variables either.
3047
3048 2010-12-20  Ryuan Choi  <ryuan.choi@samsung.com>
3049
3050         Reviewed by Antonio Gomes.
3051
3052         [CMAKE] Rename WEBKITTOOLS_DIR to TOOLS_DIR
3053         https://bugs.webkit.org/show_bug.cgi?id=51319
3054
3055         * CMakeListsEfl.txt:
3056
3057 2010-12-18  Adam Barth  <abarth@webkit.org>
3058
3059         Reviewed by Sam Weinig.
3060
3061         Move WebKitExamplePlugins to Examples
3062         https://bugs.webkit.org/show_bug.cgi?id=51291
3063
3064         * Scripts/webkitpy/common/config/build.py:
3065
3066 2010-12-17  Csaba Osztrogonác  <ossy@webkit.org>
3067
3068         Unreviewed Qt buildfix after r74301.
3069
3070         Rename WebKitTools to Tools
3071         https://bugs.webkit.org/show_bug.cgi?id=49861
3072
3073         * MiniBrowser/DerivedSources.pro:
3074         * MiniBrowser/qt/MiniBrowser.pro:
3075
3076 2010-12-17  Dan Bernstein  <mitz@apple.com>
3077
3078         Reviewed by Simon Fraser.
3079
3080         Rename WebKitTools to Tools
3081         https://bugs.webkit.org/show_bug.cgi?id=49861
3082
3083         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3084         * CodeCoverage/README:
3085         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3086         (WebCore::DumpRenderTree::initializeFonts):
3087         * EWSTools/start-commit-queue.sh:
3088         * EWSTools/start-queue.sh:
3089         * GNUmakefile.am:
3090         * MIDLWrapper/MIDLWrapper.cpp:
3091         (wmain):
3092         * MiniBrowser/qt/MiniBrowser.pro:
3093         * Scripts/build-api-tests:
3094         * Scripts/build-dumprendertree:
3095         * Scripts/build-webkit:
3096         * Scripts/build-webkittestrunner:
3097         * Scripts/generate-coverage-data:
3098         * Scripts/old-run-webkit-tests:
3099         * Scripts/run-api-tests:
3100         * Scripts/run-iexploder-tests:
3101         * Scripts/run-javascriptcore-tests:
3102         * Scripts/run-mangleme-tests:
3103         * Scripts/run-sunspider:
3104         * Scripts/run-webkit-websocketserver:
3105         * Scripts/sunspider-compare-results:
3106         * Scripts/test-webkitperl:
3107         * Scripts/test-webkitpy:
3108         * Scripts/update-iexploder-cssproperties:
3109         * Scripts/update-webkit:
3110         * Scripts/update-webkit-localizable-strings:
3111         * Scripts/webkitdirs.pm:
3112         * Scripts/webkitpy/common/checkout/scm.py:
3113         * Scripts/webkitpy/common/checkout/scm_unittest.py:
3114         * Scripts/webkitpy/common/config/committervalidator.py:
3115         * Scripts/webkitpy/common/config/committervalidator_unittest.py:
3116         * Scripts/webkitpy/common/config/ports.py:
3117         * Scripts/webkitpy/common/config/ports_unittest.py:
3118         * Scripts/webkitpy/common/system/logutils_unittest.py:
3119         * Scripts/webkitpy/common/system/ospath_unittest.py:
3120         * Scripts/webkitpy/layout_tests/port/chromium.py:
3121         * Scripts/webkitpy/layout_tests/port/config.py:
3122         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
3123         * Scripts/webkitpy/layout_tests/port/http_server.py:
3124         * Scripts/webkitpy/layout_tests/port/test.py:
3125         * Scripts/webkitpy/style/checker.py:
3126         * Scripts/webkitpy/style/checker_unittest.py:
3127         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
3128         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3129         * Scripts/webkitpy/tool/steps/steps_unittest.py:
3130         * WebKitTestRunner/DerivedSources.pro:
3131         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
3132         (WTR::activateFonts):
3133         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3134         * wx/build/build_utils.py:
3135
3136 2010-12-16  Antonio Gomes  <agomes@rim.com>
3137
3138         Reviewed by Martin Robinson.
3139
3140         Settings::editingBehaviorType() incorrectly returns mac for the gtk build when running tests
3141         https://bugs.webkit.org/show_bug.cgi?id=51163
3142
3143         Since GTK+'s default editing behavior was changed to UNIX in r70975 (see webkitwebsettings.cpp),
3144         GTK+'s DRT should also reset to UNIX after each test execution.
3145
3146         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3147         (resetDefaultsToConsistentValues):
3148
3149 2010-12-17  David Levin  <levin@chromium.org>
3150
3151         Reviewed by Eric Seidel.
3152
3153         check-webkit-style should understand WTF #include guards
3154         https://bugs.webkit.org/show_bug.cgi?id=44911
3155
3156         * Scripts/webkitpy/style/checkers/cpp.py:
3157         (get_header_guard_cpp_variable): modify to suggest the WTF style
3158         of header guard when appropriate.
3159         (check_for_header_guard): handle multiple return values from
3160         get_header_guard_cpp_variable
3161         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3162         (CppStyleTest.test_build_header_guard): Added tests for the WTF
3163         header style.
3164
3165 2010-12-16  David Levin  <levin@chromium.org>
3166
3167         Reviewed by Eric Seidel.
3168
3169         test-webkitpy: unittest for the xml.py checker displays a decprecation warning.
3170         https://bugs.webkit.org/show_bug.cgi?id=51210
3171
3172         The error only shows up when using python 2.6 or later.
3173
3174         * Scripts/webkitpy/style/checkers/xml.py: Replace the usage of
3175         the decprecated field error,message with something equivalent.
3176
3177 2010-12-16  Mihai Parparita  <mihaip@chromium.org>
3178
3179         Reviewed by Eric Seidel.
3180
3181         Add --exit-after-n-failures/crashes to NRWT
3182         https://bugs.webkit.org/show_bug.cgi?id=51160
3183         
3184         Abort test run (in a similar way to how control-C is handled) when
3185         --exit-after-n-failures/crashes-or-timeouts are passed and we've reached
3186         that number of unexpected failures/crashes/timeouts.
3187
3188         * Scripts/webkitpy/layout_tests/port/test.py:
3189         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3190         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3191
3192 2010-12-16  David Levin  <levin@chromium.org>
3193
3194         Reviewed by Shinichiro Hamaji.
3195
3196         check-webkit-style unit tests has some duplicate boilerplate code.
3197         https://bugs.webkit.org/show_bug.cgi?id=49519
3198
3199         * Scripts/webkitpy/style/checkers/cpp.py:
3200         (update_include_state): Replaced the "io" parameter with the global
3201         configuration _unit_test_config. This allowed not calling into
3202         functions at a low level and also not plumbing through the injection
3203         information through many levels of code.
3204         (check_for_include_what_you_use): Ditto.
3205         (process_file_data): Added the ability to set up the unit test config
3206         to allow for injection.
3207         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3208         (ErrorCollector.__init__): Added support for having a filter for errors.
3209         (ErrorCollector.__call__): Ditto.
3210         (CppStyleTestBase.process_file_data): Added the ability to set unit_test_config.
3211         (CppStyleTestBase.perform_lint): Consolidated logic for the perform functions.
3212         (CppStyleTestBase.perform_single_line_lint): Replace specific calls to
3213         functions in the cpp.py with generic processing and a filter that
3214         indicates what errors should be kept.
3215         (CppStyleTestBase.perform_multi_line_lint): Ditto.
3216         (CppStyleTestBase.perform_language_rules_check): Ditto.
3217         (CppStyleTestBase.perform_function_lengths_check): Ditto.
3218         (CppStyleTestBase.perform_pass_ptr_check): Ditto.
3219         (CppStyleTestBase.perform_include_what_you_use): Ditto.
3220         (CppStyleTest.test_multi_line_comments): Added another
3221         error message which applies to the test case.
3222         (CppStyleTest.test_spacing_for_binary_ops): Fixed test
3223         to not have config.h, since it is processed as a header file.
3224         (CppStyleTest.test_static_or_global_stlstrings): Fixed variable name
3225         style and indentation in checked code.
3226         (OrderOfIncludesTest.test_check_preprocessor_in_include_section):
3227         Fixed line number.
3228         (NoNonVirtualDestructorsTest.test_multi_line_declaration_with_error):
3229         Ditto.
3230
3231 2010-12-15  Sheriff Bot  <webkit.review.bot@gmail.com>
3232
3233         Unreviewed, rolling out r74136.
3234         http://trac.webkit.org/changeset/74136
3235         https://bugs.webkit.org/show_bug.cgi?id=51135
3236
3237         r74136 breaks chromium canary bots because some tests are not
3238         rebaselined correctly to resolve EOL differences (Requested by
3239         jianli on #webkit).
3240
3241         * Scripts/webkitpy/layout_tests/port/base.py:
3242         * Scripts/webkitpy/layout_tests/port/test.py:
3243         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
3244
3245 2010-12-15  Adam Roben  <aroben@apple.com>
3246
3247         Teach check-webkit-style to check .vcproj and .vsprops files for XML
3248         syntax errors
3249
3250         Fixes <http://webkit.org/b/51103> check-webkit-style should check for
3251         XML syntax errors in .vcproj/.vsprops files
3252
3253         Reviewed by Dave Levin.
3254
3255         * Scripts/webkitpy/style/checker.py: Added lists of file extensions
3256         that should be treated as XML and that should be allowed to contain
3257         carriage returns. (These lists happen to be identical currently.)
3258         (FileType): Added a new XML type.
3259         (CheckerDispatcher.should_check_and_strip_carriage_returns): Added.
3260         Just does a simple file extension check.
3261         (CheckerDispatcher._file_type): Added a case for XML files.
3262         (CheckerDispatcher._create_checker): Ditto. We use XMLChecker for XML
3263         files (surprise!).
3264         (StyleProcessor.process): Ask the dispatcher whether we should pass the
3265         lines through the carriage checker.
3266
3267         * Scripts/webkitpy/style/checker_unittest.py:
3268         (CheckerDispatcherCarriageReturnTest.test_should_check_and_strip_carriage_returns):
3269         Added. Checks a few file names to see if carriage returns are allowed
3270         or not.
3271         (CheckerDispatcherDispatchTest.assert_checker_xml): Added. Similar to
3272         other assert_checker_* functions.
3273         (CheckerDispatcherDispatchTest.test_xml_paths): Added. Similar to other
3274         test_*_paths functions.
3275         (CheckerDispatcherDispatchTest.test_xml_paths): Added. Similar to other
3276         test_*_paths functions.
3277         (CheckerDispatcherDispatchTest.test_none_paths): Removed the vcproj
3278         file from this test case, as vcproj files now have a type.
3279         (StyleProcessor_CodeCoverageTest.MockDispatcher.should_check_and_strip_carriage_returns):
3280         Added. Similar to the other should_* functions.
3281         (StyleProcessor_CodeCoverageTest.test_process__carriage_returns_not_stripped):
3282         Added. Checks that carriage returns aren't checked for or stripped for
3283         allowed files.
3284
3285         * Scripts/webkitpy/style/checkers/xml.py: Added.
3286         (XMLChecker.__init__): Simple init method.
3287         (XMLChecker.check): Pass each line through the expat parser, and record
3288         a style error for any errors thrown by the parser.
3289
3290         * Scripts/webkitpy/style/checkers/xml_unittest.py: Added.
3291         (XMLCheckerTest.assert_no_error): Checks that the given XML does not
3292         produce a style error.
3293         (XMLCheckerTest.assert_error): Checks that the given XML produces an
3294         error of the given category on the given line.
3295         (XMLCheckerTest.mock_handle_style_error): Does nothing. Used for
3296         checking that the XMLChecker constructor works properly.
3297         (XMLCheckerTest.test_conflict_marker): Tests that conflict markers
3298         cause a style error (see, e.g., r73887).
3299         (XMLCheckerTest.test_extra_closing_tag): Tests that extra closing tags
3300         cause a style error (see, e.g., r73773).
3301         (XMLCheckerTest.test_init): Tests that the XMLChecker constructor works
3302         properly.
3303         (XMLCheckerTest.test_missing_closing_tag): Tests that missing closing
3304         tags cause a style error (see, e.g., r72795).
3305         (XMLCheckerTest.test_no_error): Tests that valid XML does not cause a
3306         style error.
3307
3308 2010-12-15  Lucas Forschler  <lforschler@apple.com>
3309
3310         Reviewed by Stephanie Lewis.
3311
3312         https://bugs.webkit.org/show_bug.cgi?id=51117
3313         Add a new leopard test bot
3314         really really commit to trunk this time.
3315
3316         * BuildSlaveSupport/build.webkit.org-config/config.json:
3317
3318 2010-12-15  Sam Weinig  <sam@webkit.org>
3319
3320         Reviewed by Anders Carlsson.
3321
3322         WebKit2: Can't add files to an <input type=file>
3323         https://bugs.webkit.org/show_bug.cgi?id=51087
3324
3325         * MiniBrowser/mac/BrowserWindowController.m:
3326         (runOpenPanel):
3327         (-[BrowserWindowController awakeFromNib]):
3328         Add simple implementation of runOpenPanel callback.
3329
3330         * MiniBrowser/win/BrowserView.cpp:
3331         (BrowserView::create):
3332         * WebKitTestRunner/TestController.cpp:
3333         (WTR::createOtherPage):
3334         (WTR::TestController::initialize):
3335         Stub out runOpenPanel callback. 
3336
3337 2010-12-14  Eric Seidel  <eric@webkit.org>
3338
3339         Reviewed by Adam Barth.
3340
3341         commit-queue should upload failure diffs when tests flake
3342         https://bugs.webkit.org/show_bug.cgi?id=51051
3343
3344         To make this testable I needed to pipe FileSystem down onto tool.
3345         We've wanted it there for a long time anyway.
3346
3347         This patch is kinda a big hack.  But we don't have a nice
3348         way to read results.html files.  I think this will need further
3349         revision before this code actually feels clean.
3350
3351         As part of testing this change, I had to make MockBugzilla.create_bug
3352         actually return an id (like it should) which required updating
3353         a few other unit test results (for the better).
3354
3355         The results_matching_keys change in layouttestresults/rebasline
3356         was an alternate path which I decided not to use in the end, but
3357         I left the change as it seemed an improvement.
3358
3359         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3360         * Scripts/webkitpy/common/net/layouttestresults.py:
3361         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3362         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3363         * Scripts/webkitpy/tool/commands/queues.py:
3364         * Scripts/webkitpy/tool/commands/rebaseline.py:
3365         * Scripts/webkitpy/tool/main.py:
3366         * Scripts/webkitpy/tool/mocktool.py:
3367
3368 2010-12-15  Cosmin Truta  <ctruta@chromium.org>
3369
3370         Reviewed by James Robinson.
3371
3372         new-run-webkit-tests ignores trailing EOL differences in text tests
3373         https://bugs.webkit.org/show_bug.cgi?id=36983
3374
3375         Changed the handling of new-line characters within new-run-webkit-tests
3376         to match old-run-webkit-tests.  Differences in leading and trailing empty
3377         lines in text expectation files are no longer ignored.
3378
3379         * Scripts/webkitpy/layout_tests/port/base.py:
3380         * Scripts/webkitpy/layout_tests/port/test.py:
3381         Added unit tests.  Removed old duplicate unit test entries.
3382         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
3383
3384 2010-12-15  Ojan Vafai  <ojan@chromium.org>
3385
3386         Reviewed by Adam Barth.
3387
3388         make status-bubble white-space:nowrap so we can measure it's width without wrapping
3389         https://bugs.webkit.org/show_bug.cgi?id=51149
3390
3391         * QueueStatusServer/templates/statusbubble.html:
3392
3393 2010-12-15  Ojan Vafai  <ojan@chromium.org>
3394
3395         Reviewed by Adam Barth.
3396
3397         have the statusbubble postMessage it's metrics so that embedders can properly size the iframe
3398         https://bugs.webkit.org/show_bug.cgi?id=51125
3399
3400         * QueueStatusServer/templates/statusbubble.html:
3401
3402 2010-12-15  Darin Adler  <darin@apple.com>
3403
3404         * Scripts/webkitpy/common/net/buildbot: Added property svn:ignore.
3405
3406 2010-12-15  Sheriff Bot  <webkit.review.bot@gmail.com>
3407
3408         Unreviewed, rolling out r74117.
3409         http://trac.webkit.org/changeset/74117
3410         https://bugs.webkit.org/show_bug.cgi?id=51113
3411
3412         This broke the GTK1 build. (Requested by mrobinson on
3413         #webkit).
3414
3415         * Scripts/webkitdirs.pm:
3416
3417 2010-12-15  Amruth Raj  <amruthraj@motorola.com> and Ravi Kasibhatla  <ravi.kasibhatla@motorola.com>
3418
3419         Reviewed by Martin Robinson.
3420
3421         Change generate-forwarding-headers.pl for GTK port usage 
3422         (https://bugs.webkit.org/show_bug.cgi?id=37369)
3423
3424         * Scripts/webkitdirs.pm: Added changes to build webkit2 for GTK port using build-webkit script.
3425
3426 2010-12-14  Kent Tamura  <tkent@chromium.org>
3427
3428         Reviewed by Jian Li.
3429
3430         [DRT/Chromium] Remove another unnecessary error message
3431         https://bugs.webkit.org/show_bug.cgi?id=51083
3432
3433         * DumpRenderTree/chromium/WebViewHost.cpp:
3434         (WebViewHost::didInvalidateRect):
3435
3436 2010-12-14  Lucas Forschler  <lforschler@apple.com>
3437
3438         Reviewed by Stephanie Lewis.
3439
3440         Add a new Leopard Debug Test WK2 Bot
3441
3442         * BuildSlaveSupport/build.webkit.org-config/config.json:
3443
3444 2010-12-14  Ojan Vafai  <ojan@chromium.org>
3445
3446         Fix python unittests after http://trac.webkit.org/changeset/74070.
3447
3448         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
3449
3450 2010-12-14  Kent Tamura  <tkent@chromium.org>
3451
3452         Reviewed by Jian Li.
3453
3454         [DRT/Chromium] Remove a unnecessary error message
3455         https://bugs.webkit.org/show_bug.cgi?id=51069
3456
3457         * DumpRenderTree/chromium/WebViewHost.cpp:
3458         (WebViewHost::paintInvalidatedRegion):
3459
3460 2010-12-14  Benjamin Kalman  <kalman@chromium.org>
3461
3462         Reviewed by Ojan Vafai.
3463
3464         Using BUG/BUGWK in test_expectations is error prone, should use BUGCR/BUGWK
3465         https://bugs.webkit.org/show_bug.cgi?id=48926
3466
3467         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
3468         Add presubmit check that BUG isn't used, either BUGCR/BUGWK/BUGV8_.
3469
3470 2010-12-14  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3471
3472         Reviewed by Eric Seidel.
3473
3474         [Qt] [Symbian] Do not use pkg-config on Symbian as it is not supported
3475         https://bugs.webkit.org/show_bug.cgi?id=50231
3476
3477         Guard CONFIG+=link_pkgconfig with !symbian.
3478
3479         * DumpRenderTree/qt/DumpRenderTree.pro:
3480         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3481         * WebKitTestRunner/qt/WebKitTestRunner.pro:
3482
3483 2010-12-14  Philippe Normand  <pnormand@igalia.com>
3484
3485         Reviewed by Ojan Vafai.
3486
3487         [new-run-webkit-tests] expectations parsing is slow
3488         https://bugs.webkit.org/show_bug.cgi?id=50635
3489
3490         Avoid expensive iteration of all the tests when checking if a test
3491         file is to be skipped or not.
3492
3493         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
3494         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
3495         * Scripts/webkitpy/layout_tests/port/test.py:
3496
3497 2010-12-14  Mario Sanchez Prada  <msanchez@igalia.com>
3498
3499         Reviewed by Xan Lopez.
3500
3501         [Gtk] Implement STATE_FOCUSED, STATE_FOCUSABLE, and corresponding events for text objects
3502         https://bugs.webkit.org/show_bug.cgi?id=27048
3503
3504         Add support in DRT for checking whether an accessibility UI
3505         element is focusable and/or focused. Implemented for GTK.
3506
3507         * DumpRenderTree/AccessibilityUIElement.cpp:
3508         (getIsFocusedCallback): New.
3509         (getIsFocusableCallback): New.
3510         (AccessibilityUIElement::getJSClass): Add the new available
3511         callbacks for isFocused and isFocusable.
3512         * DumpRenderTree/AccessibilityUIElement.h:
3513         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3514         (AccessibilityUIElement::isFocused): New, implemented by checking
3515         whether the related AtkState value is in the object's state set.
3516         (AccessibilityUIElement::isFocusable): Ditto.
3517         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3518         (AccessibilityUIElement::isFocused): New, dummy implementation.
3519         (AccessibilityUIElement::isFocusable): Ditto.
3520         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3521         (AccessibilityUIElement::isFocused): Ditto.
3522         (AccessibilityUIElement::isFocusable): Ditto.
3523
3524 2010-12-14  Eric Seidel  <eric@webkit.org>
3525
3526         Reviewed by Ojan Vafai.
3527
3528         webkit-patch should warn users when they're using a 32-bit git on a 64-bit system
3529         https://bugs.webkit.org/show_bug.cgi?id=50715
3530
3531         This patch makes webkit-patch print the following:
3532
3533         Warning: This machine is 64-bit, but the git binary (/usr/local/git/bin/git) does not support 64-bit.
3534         Install a 64-bit git for better performance, see:
3535         https://lists.webkit.org/pipermail/webkit-dev/2010-December/015249.html
3536
3537         I wrote this mostly because I have approximately 8 machines that I use
3538         and making sure each one is using a good Git install seemed folly.
3539         webkit-patch makes a lot of git calls, so using a fast git can shave
3540         several seconds in every invocation.  See the webkit-dev thread for more info.
3541
3542         This message will print twice during 'webkit-patch upload',
3543         once from webkit-patch and once from check-webkit-style.
3544
3545         Unfortunately there is no good way to test this due to how machine-dependent
3546         the code is.  I considered writing a test for the log message, but it seemed not worth it.
3547
3548         * Scripts/webkitpy/common/checkout/scm.py:
3549
3550 2010-12-13  Eric Seidel  <eric@webkit.org>
3551
3552         Reviewed by Adam Barth.
3553
3554         FlakyTestReporter doesn't understand bots running from multiple email addresses
3555         https://bugs.webkit.org/show_bug.cgi?id=50960
3556
3557         This explains at least one of the dupes of:
3558         https://bugs.webkit.org/show_bug.cgi?id=50863
3559         that we saw filed by the commit-queue this morning.
3560         I think the other one was explained by my previous fix to result counting code.
3561
3562         Since this is really hard to test with a unit test, instead I
3563         create a new (possibly useful in the future) command
3564         which given a layout test path will return you
3565         the one bug which our tools would assume it the flaky test bug.
3566         If some other script wants to use bug-for-test we'll
3567         need to extend it with some options like --create-if-missing or similar.
3568
3569         * Scripts/webkitpy/common/net/bugzilla/bug.py:
3570         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3571         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3572         * Scripts/webkitpy/tool/commands/__init__.py:
3573         * Scripts/webkitpy/tool/commands/bugfortest.py: Added.
3574
3575 2010-12-13  Mihai Parparita  <mihaip@chromium.org>
3576
3577         Reviewed by James Robinson.
3578
3579         Add option to build-webkit to not build WebKit2
3580         https://bugs.webkit.org/show_bug.cgi?id=50988
3581         
3582         Add support for a --no-webkit2 option to build-webkit. It seems to save
3583         ~1 minute from clean builds and ~10 seconds from no-op builds.
3584
3585         * Scripts/build-webkit:
3586
3587 2010-12-13  Lucas Forschler  <lforschler@apple.com>
3588
3589         Reviewed by Dave Kilzer.
3590
3591         Update iexploder from 1.3.2 to 1.7.2
3592         Move 1.3.2 into its own subdir
3593         Add 1.7.2 into its own subdir
3594         update scripts to point to new 1.3.2 location (avoid breaking existing scripts)
3595
3596         * Scripts/run-iexploder-tests:
3597         * Scripts/update-iexploder-cssproperties:
3598         * iExploder/CHANGELOG.txt: Removed.
3599         * iExploder/LICENSE.txt: Removed.
3600         * iExploder/README.txt: Removed.
3601         * iExploder/htdocs: Removed.
3602         * iExploder/iexploder-1.3.2: Added.
3603         * iExploder/iexploder-1.3.2/CHANGELOG.txt: Copied from iExploder/CHANGELOG.txt.
3604         * iExploder/iexploder-1.3.2/LICENSE.txt: Copied from iExploder/LICENSE.txt.
3605         * iExploder/iexploder-1.3.2/README.txt: Copied from iExploder/README.txt.
3606         * iExploder/iexploder-1.3.2/htdocs: Added.
3607         * iExploder/iexploder-1.3.2/htdocs/config.rb: Copied from iExploder/htdocs/config.rb.
3608         * iExploder/iexploder-1.3.2/htdocs/cssproperties.in: Copied from iExploder/htdocs/cssproperties.in.
3609         * iExploder/iexploder-1.3.2/htdocs/cssvalues.in: Copied from iExploder/htdocs/cssvalues.in.
3610         * iExploder/iexploder-1.3.2/htdocs/htmlattrs.in: Copied from iExploder/htdocs/htmlattrs.in.
3611         * iExploder/iexploder-1.3.2/htdocs/htmltags.in: Copied from iExploder/htdocs/htmltags.in.
3612         * iExploder/iexploder-1.3.2/htdocs/htmlvalues.in: Copied from iExploder/htdocs/htmlvalues.in.
3613         * iExploder/iexploder-1.3.2/htdocs/iexploder.cgi: Copied from iExploder/htdocs/iexploder.cgi.
3614         * iExploder/iexploder-1.3.2/htdocs/iexploder.rb: Copied from iExploder/htdocs/iexploder.rb.
3615         * iExploder/iexploder-1.3.2/htdocs/index.html: Copied from iExploder/htdocs/index.html.
3616         * iExploder/iexploder-1.3.2/htdocs/webserver.rb: Copied from iExploder/htdocs/webserver.rb.
3617         * iExploder/iexploder-1.3.2/tools: Added.
3618         * iExploder/iexploder-1.3.2/tools/lasthit.rb: Copied from iExploder/tools/lasthit.rb.
3619         * iExploder/iexploder-1.3.2/tools/osx_last_crash.rb: Copied from iExploder/tools/osx_last_crash.rb.
3620         * iExploder/iexploder-1.3.2/tools/showtest.rb: Copied from iExploder/tools/showtest.rb.
3621         * iExploder/iexploder-1.7.2: Added.
3622         * iExploder/iexploder-1.7.2/ChangeLog.txt: Added.
3623         * iExploder/iexploder-1.7.2/LICENSE.txt: Added.
3624         * iExploder/iexploder-1.7.2/README.txt: Added.
3625         * iExploder/iexploder-1.7.2/output: Added.
3626         * iExploder/iexploder-1.7.2/src: Added.
3627         * iExploder/iexploder-1.7.2/src/browser_harness.rb: Added.
3628         * iExploder/iexploder-1.7.2/src/config.yaml: Added.
3629         * iExploder/iexploder-1.7.2/src/css-atrules: Added.
3630         * iExploder/iexploder-1.7.2/src/css-atrules/mozilla: Added.
3631         * iExploder/iexploder-1.7.2/src/css-atrules/webkit: Added.
3632         * iExploder/iexploder-1.7.2/src/css-properties: Added.
3633         * iExploder/iexploder-1.7.2/src/css-properties/dillo: Added.
3634         * iExploder/iexploder-1.7.2/src/css-properties/gtkhtml: Added.
3635         * iExploder/iexploder-1.7.2/src/css-properties/internet_explorer6: Added.
3636         * iExploder/iexploder-1.7.2/src/css-properties/mozilla: Added.
3637         * iExploder/iexploder-1.7.2/src/css-properties/webkit: Added.
3638         * iExploder/iexploder-1.7.2/src/css-pseudo: Added.
3639         * iExploder/iexploder-1.7.2/src/css-pseudo/mozilla: Added.
3640         * iExploder/iexploder-1.7.2/src/css-pseudo/webkit: Added.
3641         * iExploder/iexploder-1.7.2/src/css-values: Added.
3642         * iExploder/iexploder-1.7.2/src/css-values/dillo: Added.
3643         * iExploder/iexploder-1.7.2/src/css-values/gtkhtml: Added.
3644         * iExploder/iexploder-1.7.2/src/css-values/mozilla: Added.
3645         * iExploder/iexploder-1.7.2/src/css-values/other: Added.
3646         * iExploder/iexploder-1.7.2/src/css-values/webkit: Added.
3647         * iExploder/iexploder-1.7.2/src/headers: Added.
3648         * iExploder/iexploder-1.7.2/src/headers/dillo: Added.
3649         * iExploder/iexploder-1.7.2/src/headers/gtkhtml: Added.
3650         * iExploder/iexploder-1.7.2/src/headers/mozilla: Added.
3651         * iExploder/iexploder-1.7.2/src/headers/webkit: Added.
3652         * iExploder/iexploder-1.7.2/src/html-attrs: Added.
3653         * iExploder/iexploder-1.7.2/src/html-attrs/dillo: Added.
3654         * iExploder/iexploder-1.7.2/src/html-attrs/gtkhtml: Added.
3655         * iExploder/iexploder-1.7.2/src/html-attrs/internet_explorer6: Added.
3656         * iExploder/iexploder-1.7.2/src/html-attrs/mozilla: Added.
3657         * iExploder/iexploder-1.7.2/src/html-attrs/other: Added.
3658         * iExploder/iexploder-1.7.2/src/html-attrs/webkit: Added.
3659         * iExploder/iexploder-1.7.2/src/html-tags: Added.
3660         * iExploder/iexploder-1.7.2/src/html-tags/dillo: Added.
3661         * iExploder/iexploder-1.7.2/src/html-tags/gtkhtml: Added.
3662         * iExploder/iexploder-1.7.2/src/html-tags/mozilla: Added.
3663         * iExploder/iexploder-1.7.2/src/html-tags/other: Added.
3664         * iExploder/iexploder-1.7.2/src/html-tags/webkit: Added.
3665         * iExploder/iexploder-1.7.2/src/html-values: Added.
3666         * iExploder/iexploder-1.7.2/src/html-values/dillo: Added.
3667         * iExploder/iexploder-1.7.2/src/html-values/gtkhtml: Added.
3668         * iExploder/iexploder-1.7.2/src/html-values/mozilla: Added.
3669         * iExploder/iexploder-1.7.2/src/html-values/other: Added.
3670         * iExploder/iexploder-1.7.2/src/html-values/webkit: Added.
3671         * iExploder/iexploder-1.7.2/src/iexploder.cgi: Added.
3672         * iExploder/iexploder-1.7.2/src/iexploder.rb: Added.
3673         * iExploder/iexploder-1.7.2/src/index.html: Added.
3674         * iExploder/iexploder-1.7.2/src/media: Added.
3675         * iExploder/iexploder-1.7.2/src/media/blank.ogg: Added.
3676         * iExploder/iexploder-1.7.2/src/media/blank.snd: Added.
3677         * iExploder/iexploder-1.7.2/src/media/blank.wav: Added.
3678         * iExploder/iexploder-1.7.2/src/media/bug.bmp: Added.
3679         * iExploder/iexploder-1.7.2/src/media/bug.gif: Added.
3680         * iExploder/iexploder-1.7.2/src/media/bug.ico: Added.
3681         * iExploder/iexploder-1.7.2/src/media/bug.jng: Added.
3682         * iExploder/iexploder-1.7.2/src/media/bug.jpg: Added.
3683         * iExploder/iexploder-1.7.2/src/media/bug.png: Added.
3684         * iExploder/iexploder-1.7.2/src/media/bug.svg: Added.
3685         * iExploder/iexploder-1.7.2/src/media/bug.tiff: Added.
3686         * iExploder/iexploder-1.7.2/src/media/bug.xbm: Added.
3687         * iExploder/iexploder-1.7.2/src/media/bug.xpm: Added.
3688         * iExploder/iexploder-1.7.2/src/mime-types: Added.
3689         * iExploder/iexploder-1.7.2/src/mime-types/dillo: Added.
3690         * iExploder/iexploder-1.7.2/src/mime-types/mozilla: Added.
3691         * iExploder/iexploder-1.7.2/src/mime-types/webkit: Added.
3692         * iExploder/iexploder-1.7.2/src/protocols: Added.
3693         * iExploder/iexploder-1.7.2/src/protocols/dillo: Added.
3694         * iExploder/iexploder-1.7.2/src/protocols/gtkhtml: Added.
3695         * iExploder/iexploder-1.7.2/src/protocols/mozilla: Added.
3696         * iExploder/iexploder-1.7.2/src/protocols/webkit: Added.
3697         * iExploder/iexploder-1.7.2/src/scanner.rb: Added.
3698         * iExploder/iexploder-1.7.2/src/version.rb: Added.
3699         * iExploder/iexploder-1.7.2/src/webserver.rb: Added.
3700         * iExploder/iexploder-1.7.2/testcases: Added.
3701         * iExploder/iexploder-1.7.2/testcases/testcase-Linux_x86_64_rv2.0b6pre_Gecko-20100904_Firefox-4.0b6pre-TEST-8375-1_59.html: Added.
3702         * iExploder/iexploder-1.7.2/testcases/testcase-Opera-9.80_Linux_x86_64_en_Presto-2.6.30_Version-10.61-16704-3_108,3.html: Added.
3703         * iExploder/iexploder-1.7.2/testcases/testcase-U_Intel_Mac_OS_X_10_6_4_en-US_AppleWebKit-534.8_Chrome-7.0.529.0-TEST-611-3_36,9.html: Added.
3704         * iExploder/iexploder-1.7.2/testcases/testcase-U_Intel_Mac_OS_X_10_6_4_en-US_AppleWebKit-534.8_hrome-7.0.529.0-TEST-55313622206-3_6,0.html: Added.
3705         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.6_Chrome-7.0.503.1-TEST-120813-8_72,56,24,8,0.html: Added.
3706         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.6_Chrome-7.0.503.1-TEST-121240-3_81,3.html: Added.
3707         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.7_Chrome-7.0.513.0-4800-5_80,65,15.html: Added.
3708         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.7_Chrome-7.0.513.0-TEST-23583190347-3_15,12.html: Added.
3709         * iExploder/iexploder-1.7.2/tools: Added.
3710         * iExploder/iexploder-1.7.2/tools/lasthit.rb: Added.
3711         * iExploder/iexploder-1.7.2/tools/osx_last_crash.rb: Added.
3712         * iExploder/iexploder-1.7.2/tools/release_src.sh: Added.
3713         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh: Added.
3714         * iExploder/tools: Removed.
3715
3716 2010-12-13  Sam Weinig  <sam@webkit.org>
3717
3718         Reviewed by Anders Carlsson.
3719
3720         Remove associated page concept from WKView constructor
3721         https://bugs.webkit.org/show_bug.cgi?id=50983
3722
3723         Step 1: Remove associate page constructors from WKView and make
3724         all views use the shared namespace for the context.
3725
3726         * TestWebKitAPI/PlatformWebView.h:
3727         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
3728         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
3729         * WebKitTestRunner/PlatformWebView.h:
3730         * WebKitTestRunner/TestController.cpp:
3731         (WTR::createOtherPage):
3732         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3733         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3734         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3735
3736 2010-12-13  Sam Weinig  <sam@webkit.org>
3737
3738         Reviewed by Anders Carlsson.
3739
3740         Change the WebKit2 public API so there is no explicit WKPageNamespace object
3741         https://bugs.webkit.org/show_bug.cgi?id=50898
3742
3743         * MiniBrowser/mac/AppDelegate.h:
3744         * MiniBrowser/mac/AppDelegate.m:
3745         * MiniBrowser/mac/BrowserWindowController.h:
3746         * MiniBrowser/mac/BrowserWindowController.m:
3747         * MiniBrowser/win/BrowserView.cpp:
3748         Convert MiniBrowser to not use PageNamespaces.
3749
3750         * TestWebKitAPI/PlatformWebView.h:
3751         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
3752         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
3753         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
3754         * TestWebKitAPI/Tests/WebKit2/Find.cpp:
3755         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
3756         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
3757         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
3758         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
3759         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
3760         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
3761         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
3762         * TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp:
3763         * TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp:
3764         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
3765         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
3766         Convert TestWebKitAPI to not use PageNamespaces.
3767
3768         * WebKitTestRunner/PlatformWebView.h:
3769         * WebKitTestRunner/TestController.cpp:
3770         * WebKitTestRunner/TestController.h:
3771         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3772         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3773         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3774         Convert WebKitTestRunner to not use PageNamespaces.
3775
3776 2010-12-13  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
3777
3778         Reviewed by Eric Seidel.
3779
3780         webkit-patch rollout should be able to do multi-revision rollouts
3781         https://bugs.webkit.org/show_bug.cgi?id=33336
3782
3783         Make it possible to pass more than one revision to webkit-patch.
3784
3785         * Scripts/webkitpy/common/checkout/api.py:
3786         * Scripts/webkitpy/common/checkout/changelog.py:
3787         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
3788         * Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:
3789         * Scripts/webkitpy/tool/commands/download.py:
3790         * Scripts/webkitpy/tool/commands/download_unittest.py:
3791         * Scripts/webkitpy/tool/mocktool.py:
3792         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
3793         * Scripts/webkitpy/tool/steps/revertrevision.py:
3794
3795 2010-12-13  Eric Seidel  <eric@webkit.org>
3796
3797         Unreviewed.
3798
3799         Teach webkit-patch how to search bugzilla
3800         https://bugs.webkit.org/show_bug.cgi?id=50500
3801
3802         webkit-patch bug-search fails when there is only one result.
3803         Turns out we needed a bit more logic in our result count parsing code.
3804
3805         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3806         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
3807
3808 2010-12-13  Antti Koivisto  <antti@apple.com>
3809
3810         Reviewed by Alexey Proskuryakov.
3811
3812         Add setSerializeHTTPLoads function to allow testing resource load order on OS X.
3813         https://bugs.webkit.org/show_bug.cgi?id=50758
3814
3815         * DumpRenderTree/LayoutTestController.cpp:
3816         (setSerializeHTTPLoadsCallback):
3817         (LayoutTestController::staticFunctions):
3818         * DumpRenderTree/LayoutTestController.h:
3819         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3820         (LayoutTestController::setSerializeHTTPLoads):
3821         * DumpRenderTree/mac/DumpRenderTree.mm:
3822         (resetDefaultsToConsistentValues):
3823         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3824         (LayoutTestController::setSerializeHTTPLoads):
3825         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3826         (LayoutTestController::setSerializeHTTPLoads):
3827
3828 2010-12-13  Dimitri Glazkov  <dglazkov@chromium.org>
3829
3830         Reviewed by Ojan Vafai.
3831
3832         Remove "use-drt" option from test step command line, since the option was removed in r73748.
3833         https://bugs.webkit.org/show_bug.cgi?id=50936
3834
3835         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Removed the option.
3836
3837 2010-12-13  Patrick Gansterer  <paroga@webkit.org>
3838
3839         Reviewed by Csaba Osztrogonác.
3840
3841         Add revlink to BuildBot status
3842         https://bugs.webkit.org/show_bug.cgi?id=50914
3843
3844         This adds a hyperlink to trac changeset on the revision numbers. 
3845
3846         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3847
3848 2010-12-13  Andras Becsi  <abecsi@webkit.org>
3849
3850         Reviewed by Csaba Osztrogonác.
3851
3852         [Qt][WK2] Fix build if WebKitTools are not available
3853         https://bugs.webkit.org/show_bug.cgi?id=50242
3854
3855         * MiniBrowser/qt/MiniBrowser.pro: Correct the comment.
3856         * Scripts/webkitdirs.pm: Added WebKitTools/MiniBrowser to $subdirs.
3857         * MiniBrowser/DerivedSources.pro: Added.
3858
3859 2010-12-13  Eric Seidel  <eric@webkit.org>
3860
3861         Reviewed by Adam Barth.
3862
3863         EWS Queues should remove orpahned pyc files before starting
3864         https://bugs.webkit.org/show_bug.cgi?id=50904
3865
3866         A previous check added a platform.py which caused
3867         EWS bots on some platforms to hit an import exception.
3868         The platform.py file was removed in a subsequent commit, but
3869         the EWS bots in question stayed stuck.  This change will
3870         fix those bots once restarted (and prevent this in the future).
3871
3872         I also went ahead and unified start-queue and start-commit-queue
3873         since they were nearly identical.  I also added bot_id support
3874         to both force all EWSes to have bot ids as well as get rid of the one
3875         remaining reason why I had my own copies of these scripts.
3876         Hopefully this will be enough to get all the other bot admins
3877         (ahem, Adam, ahem) to move to using these checked in copies as well.
3878
3879         * EWSTools/start-commit-queue.sh: Removed.
3880         * EWSTools/start-queue.sh:
3881
3882 2010-10-28  MORITA Hajime  <morrita@google.com>
3883
3884         Reviewed by Ojan Vafai.
3885
3886         spellcheck does not check pasted text
3887         https://bugs.webkit.org/show_bug.cgi?id=40092
3888
3889         Added LayoutTestController::setAsynchronousSpellCheckingEnabled()
3890         to control the setting.
3891
3892         * DumpRenderTree/LayoutTestController.cpp:
3893         (setAsynchronousSpellCheckingEnabledCallback):
3894         (LayoutTestController::staticFunctions):
3895         * DumpRenderTree/LayoutTestController.h:
3896         * DumpRenderTree/chromium/LayoutTestController.h:
3897         * DumpRenderTree/chromium/LayoutTestController.cpp:
3898         (LayoutTestController::LayoutTestController):
3899         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
3900         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3901         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
3902         * DumpRenderTree/mac/DumpRenderTree.mm:
3903         (resetDefaultsToConsistentValues):
3904         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3905         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
3906         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3907         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3908         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
3909         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3910         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
3911         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3912         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
3913
3914 2010-12-12  Sam Weinig  <sam@webkit.org>
3915
3916         Reviewed by Anders Carlsson.
3917
3918         Fix failing API test. It turns out that a pop-state event
3919         is sent before every fragment navigation, so we have to test
3920         for it in addition in PageLoadDidChangeLocationWithinPageForFrame.
3921
3922         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
3923         (TestWebKitAPI::didSameDocumentNavigationForFrame):
3924
3925 2010-12-12  Alejandro G. Castro  <alex@igalia.com>
3926
3927         Reviewed by Eric Seidel.
3928
3929         [GTK] Add new-run-webkit-tests support to gtk
3930         https://bugs.webkit.org/show_bug.cgi?id=50681
3931
3932         Adding the basic support to run the new-run-webkit-tests.
3933
3934         * Scripts/webkitpy/layout_tests/port/gtk.py:
3935
3936 2010-10-11  Diego Gonzalez  <diegohcg@webkit.org>
3937
3938         Reviewed by Kenneth Rohde Christiansen.
3939
3940         [Qt] Mock DeviceOrientation client for DRT
3941         https://bugs.webkit.org/show_bug.cgi?id=47490
3942
3943         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3944         (WebCore::DumpRenderTree::DumpRenderTree):
3945         (WebCore::DumpRenderTree::~DumpRenderTree):
3946         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3947         (LayoutTestController::setMockDeviceOrientation):
3948
3949 2010-12-11  Philippe Normand  <pnormand@igalia.com>
3950
3951         Reviewed by Gustavo Noronha Silva.
3952
3953         [GTK] launcher: disable the Mozilla-style fullscreen API
3954         https://bugs.webkit.org/show_bug.cgi?id=50874
3955
3956         Disabling the fullscreen API until its implementation for GTK is
3957         mature enough. The webview setting for it is already FALSE by
3958         default.
3959
3960         * GtkLauncher/main.c:
3961         (createWindow):
3962
3963 2010-12-10  Eric Seidel  <eric@webkit.org>
3964
3965         Reviewed by Adam Barth.
3966
3967         commit-queue flaky test messages show cryptic version information for mac os x
3968         https://bugs.webkit.org/show_bug.cgi?id=50864
3969
3970         Turns out platform.platform() returns kernel version information
3971         which isn't helpful, and just plain confusing on Mac
3972         (OS X 10.6.5 uses Darwin Kernel 10.5.0).
3973
3974         So I've updated PlatformInfo.display_name() to special case
3975         mac.  I also found a bad use of sys.platform in the process
3976         and fixed that.  (sys.platform always returns 'darwin' on mac).
3977
3978         * Scripts/webkitpy/common/system/platforminfo.py:
3979         * Scripts/webkitpy/common/system/user.py:
3980         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3981         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3982         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3983
3984 2010-12-10  Eric Seidel  <eric@webkit.org>
3985
3986         Unreviewed.
3987
3988         Exception seen while reporting flaky test with commit-queue.
3989         Just a missing include.
3990
3991         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3992         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3993
3994 2010-12-10  Kinuko Yasuda  <kinuko@chromium.org>
3995
3996         Reviewed by Eric Seidel.
3997
3998         [Chromium] Remove old JSONResultsGenerator script that existed for backward-compatibility
3999         https://bugs.webkit.org/show_bug.cgi?id=50796
4000
4001         Also updating the test code to use JSONResultsGeneratorBase and
4002         to improve test coverage for incremental cases.
4003
4004         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
4005         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
4006
4007 2010-12-10  Joseph Pecoraro  <joepeck@webkit.org>
4008
4009         Reviewed by Darin Adler.
4010
4011         prepare-ChangeLog --help doesn't mention --bug shorthand -b
4012         https://bugs.webkit.org/show_bug.cgi?id=50835
4013
4014         * Scripts/prepare-ChangeLog: be more explicit about -b and match file style.
4015
4016 2010-12-10  Eric Seidel  <eric@webkit.org>
4017
4018         Reviewed by Adam Barth.
4019
4020         Bugs created by the commit-queue should all block on a master bug
4021         https://bugs.webkit.org/show_bug.cgi?id=50857
4022
4023         This makes all bugs created by the commit-queue block on:
4024         https://bugs.webkit.org/show_bug.cgi?id=50856
4025
4026         In the process of testing this, I found that the existing
4027         create_bug code was wrong.  I also found that existing
4028         unit tests for create-rollout used invalid values
4029         for options.blocks.  I fixed both issues and tested.
4030
4031         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
4032         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
4033         * Scripts/webkitpy/tool/commands/commandtest.py:
4034         * Scripts/webkitpy/tool/commands/download_unittest.py:
4035         * Scripts/webkitpy/tool/commands/upload_unittest.py:
4036         * Scripts/webkitpy/tool/mocktool.py:
4037         * Scripts/webkitpy/tool/steps/options.py:
4038
4039 2010-12-10  Eric Seidel  <eric@webkit.org>
4040
4041         Reviewed by Adam Barth.
4042
4043         Teach webkitpy how to follow duplicate chains when posting comments on flake bugs
4044         https://bugs.webkit.org/show_bug.cgi?id=50853
4045
4046         I also discovered when doing this that the code was posting
4047         the comment on the wrong bug, but that's fixed here too.
4048
4049         * Scripts/webkitpy/common/net/bugzilla/bug.py:
4050         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
4051         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
4052         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
4053         * Scripts/webkitpy/tool/commands/queues_unittest.py:
4054         * Scripts/webkitpy/tool/mocktool.py:
4055
4056 2010-12-10  Anders Carlsson  <andersca@apple.com>
4057
4058         Reviewed by John Sullivan.
4059
4060         Make WKContextGetStatistics gather global statistics
4061         https://bugs.webkit.org/show_bug.cgi?id=50850
4062
4063         Remove the code that gets the statistics and fills in the per context
4064         statistics information for now.
4065
4066         * MiniBrowser/mac/BrowserStatisticsWindowController.m:
4067         (-[BrowserStatisticsWindowController refreshStatistics:]):
4068
4069 2010-12-10  Eric Seidel  <eric@webkit.org>
4070
4071         Unreviewed.
4072
4073         commit-queue should report port/platform information when commenting on flaky test bugs
4074         https://bugs.webkit.org/show_bug.cgi?id=50839
4075
4076         Renamed platform.py to platforminfo.py.  This broke import platform in executive.py
4077         which was only used by new run webkit tests (and clearly not unit tested).
4078
4079         * Scripts/webkitpy/common/system/platforminfo.py: Renamed from WebKitTools/Scripts/webkitpy/common/system/platform.py.
4080         * Scripts/webkitpy/tool/main.py:
4081         * Scripts/webkitpy/tool/mocktool.py:
4082
4083 2010-12-10  Eric Seidel  <eric@webkit.org>
4084
4085         Reviewed by Tony Chang.
4086
4087         commit-queue should report port/platform information when commenting on flaky test bugs
4088         https://bugs.webkit.org/show_bug.cgi?id=50839
4089
4090         This was a suggestion from Tony Chang this morning.
4091         I added a platform.py class so I could easily mock the platform call,
4092         but that may not be the final solution for this mocking.
4093         We'll try it and see.
4094
4095         * Scripts/webkitpy/common/system/platform.py: Added.
4096         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
4097         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
4098         * Scripts/webkitpy/tool/commands/queues_unittest.py:
4099         * Scripts/webkitpy/tool/main.py:
4100         * Scripts/webkitpy/tool/mocktool.py:
4101
4102 2010-12-10  Krithigassree Sambamurthy  <krithigassree.sambamurthy@nokia.com>
4103
4104         Reviewed by Joseph Pecoraro.
4105
4106         Bug 43455 - [Qt]: Implement Application Cache Quotas
4107         https://bugs.webkit.org/show_bug.cgi?id=43455
4108
4109         Introduce functions to allow new appcache layout test origin-quota.html
4110         to work correctly under Qt.
4111
4112         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
4113         (WebCore::DumpRenderTree::DumpRenderTree):
4114         (WebCore::DumpRenderTree::dumpApplicationCacheQuota):
4115         * DumpRenderTree/qt/DumpRenderTreeQt.h:
4116
4117         Introduce functions to allow new appcache layout test origin-quota.html
4118         to be successful under qt. Changes required because LayoutTestControllerQt
4119         does not inherit from LayoutController.
4120
4121         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
4122         (LayoutTestController::reset):
4123         (LayoutTestController::clearAllApplicationCaches):
4124         (LayoutTestController::setApplicationCacheOriginQuota):
4125         * DumpRenderTree/qt/LayoutTestControllerQt.h:
4126         (LayoutTestController::shouldDumpApplicationCacheDelegateCallbacks):
4127         (LayoutTestController::dumpApplicationCacheDelegateCallbacks):
4128
4129 2010-12-10  Eric Seidel  <eric@webkit.org>
4130
4131         Reviewed by Adam Barth.
4132
4133         Move buildbot.py into its own module so we can split it out into one-file-per-class
4134         https://bugs.webkit.org/show_bug.cgi?id=50806
4135
4136         We're adding more buildbot logic these days, so it makes sense
4137         to give buildbot its own module.
4138
4139         * Scripts/webkitpy/common/net/buildbot/__init__.py: Added.
4140         * Scripts/webkitpy/common/net/buildbot/buildbot.py: Renamed from WebKitTools/Scripts/webkitpy/common/net/buildbot.py.
4141         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py: Renamed from WebKitTools/Scripts/webkitpy/common/net/buildbot_unittest.py.
4142         * Scripts/webkitpy/common/net/failuremap.py:
4143         * Scripts/webkitpy/common/net/regressionwindow.py:
4144         * Scripts/webkitpy/tool/commands/rebaseline.py:
4145
4146 2010-12-10  Tony Chang  <tony@chromium.org>
4147
4148         Reviewed by Eric Seidel.
4149
4150         Use FileSystem::remove when cleaning up http lock files
4151         https://bugs.webkit.org/show_bug.cgi?id=50830
4152
4153         * Scripts/webkitpy/layout_tests/port/http_lock.py:
4154
4155 2010-12-10  Joone Hur  <joone@kldp.org>
4156
4157         Reviewed by Martin Robinson.
4158
4159         [GTK] DRT needs layoutTestController.setCacheModel
4160         https://bugs.webkit.org/show_bug.cgi?id=50705
4161         
4162         webkit_set_cache_mode() is called to set the cache model.
4163         
4164         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
4165         (LayoutTestController::setCacheModel): Set the cache model. 
4166
4167 2010-12-10  Tony Chang  <tony@chromium.org>
4168
4169         Reviewed by Ojan Vafai.
4170
4171         [chromium] remove --use-drt and add --use-test-shell
4172         https://bugs.webkit.org/show_bug.cgi?id=50701
4173
4174         * Scripts/webkitpy/common/config/ports.py:
4175         * Scripts/webkitpy/common/config/ports_unittest.py:
4176         * Scripts/webkitpy/layout_tests/port/chromium.py:
4177         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
4178         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
4179         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
4180         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
4181         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
4182         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
4183         * Scripts/webkitpy/layout_tests/port/webkit.py:
4184         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4185         * Scripts/webkitpy/style/checkers/test_expectations.py:
4186         * Scripts/webkitpy/tool/commands/queries.py:
4187
4188 2010-12-10  John Knottenbelt  <jknotten@chromium.org>
4189
4190         Reviewed by Steve Block.
4191
4192         [Chromium] Implement mocks for client-based geolocation
4193         https://bugs.webkit.org/show_bug.cgi?id=46895
4194
4195         * DumpRenderTree/chromium/LayoutTestController.cpp:
4196         (LayoutTestController::setGeolocationPermission):
4197         (LayoutTestController::setMockGeolocationPosition):
4198         (LayoutTestController::setMockGeolocationError):
4199         * DumpRenderTree/chromium/LayoutTestController.h:
4200         * DumpRenderTree/chromium/WebViewHost.cpp:
4201         (WebViewHost::geolocationClient):
4202         (WebViewHost::geolocationClientMock):
4203         (WebViewHost::reset):
4204         * DumpRenderTree/chromium/WebViewHost.h:
4205
4206 2010-12-10  Alejandro G. Castro  <alex@igalia.com>
4207
4208         Reviewed by Martin Robinson.
4209
4210         [GTK] Add hasSpellingMarker support to the DRT
4211         https://bugs.webkit.org/show_bug.cgi?id=50739
4212
4213         Implemented the hasSpellingMarker to support spelling tests.
4214
4215         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
4216         (LayoutTestController::hasSpellingMarker):
4217
4218 2010-12-10  Eric Seidel  <eric@webkit.org>
4219
4220         Reviewed by Ojan Vafai.
4221
4222         webkit-patch: not possible to use build-and-test with local commits
4223         https://bugs.webkit.org/show_bug.cgi?id=33378
4224
4225         Make --no-clean not even check if we have local commits.
4226         It's unclear to me why the code was originally written this way.
4227         I was unable to dig up a reason from svn history.
4228
4229         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
4230         * Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py: Copied from WebKitTools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.
4231
4232 2010-12-10  Mario Sanchez Prada  <msanchez@igalia.com>
4233
4234         Reviewed by Martin Robinson.
4235
4236         [GTK] AX: implement isEnabled in DRT
4237         https://bugs.webkit.org/show_bug.cgi?id=50814
4238
4239         Implement AccessibilityUIElement::isEnabled() for GTK.
4240
4241         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
4242         (checkElementState): New function to refactor common code.
4243         (AccessibilityUIElement::isEnabled): Implement this by checking
4244         the current state of the AtkObject.
4245         (AccessibilityUIElement::isSelected): Use the new
4246         checkElementState function.
4247
4248 2010-12-10  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
4249
4250         Reviewed by Kenneth Rohde Christiansen.
4251
4252         [Qt][WK2] Add the QWKContext API class to wrap the WebContext.
4253         https://bugs.webkit.org/show_bug.cgi?id=50750
4254
4255         * MiniBrowser/qt/BrowserView.cpp:
4256         (BrowserView::BrowserView):
4257         * MiniBrowser/qt/BrowserView.h:
4258         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
4259         (WTR::WebView::WebView):
4260
4261 2010-12-10  Joone Hur  <joone@kldp.org>
4262
4263         Reviewed by Xan Lopez.
4264
4265         [GTK] Unskipping some test cases in userscripts dependent on addUserStyleSheet
4266         https://bugs.webkit.org/show_bug.cgi?id=50808
4267
4268         Unskipping the following test cases:
4269         userscripts/mixed-case-stylesheet.html
4270         userscripts/simple-stylesheet.html
4271         userscripts/user-style-all-frames.html
4272
4273         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
4274         (LayoutTestController::addUserStyleSheet):
4275
4276 2010-12-10  Joone Hur  <joone@kldp.org>
4277
4278         Reviewed by Eric Seidel.
4279
4280         [GTK] Add DRT support for pageProperty, isPageBoxVisible, pageSizeAndMarginsInPixels, and addUserStyleSheet
4281         https://bugs.webkit.org/show_bug.cgi?id=50783
4282
4283         This patch allows to unskip the following test cases:
4284         printing/page-rule-selection.html
4285         printing/page-format-data.html
4286
4287         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
4288         (LayoutTestController::pageProperty): Added.
4289         (LayoutTestController::isPageBoxVisible): Ditto.
4290         (LayoutTestController::pageSizeAndMarginsInPixels): Ditto.
4291         (LayoutTestController::addUserStyleSheet): Ditto.
4292
4293 2010-12-10  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
4294
4295         Reviewed by Kenneth Rohde Christiansen.
4296
4297         [Qt] Make QtTestBrowser spawn QNAM in a secondary thread.
4298
4299         A menu allows to switch QNAM back to the same thread.
4300
4301         * QtTestBrowser/launcherwindow.cpp:
4302         (LauncherWindow::initializeView):
4303         (LauncherWindow::createChrome):
4304         (LauncherWindow::toggleThreadedQnam):
4305         * QtTestBrowser/launcherwindow.h:
4306         (WindowOptions::WindowOptions):
4307         * QtTestBrowser/webpage.cpp:
4308         (WebPage::WebPage):
4309         (WebPage::setQnamThreaded):
4310         * QtTestBrowser/webpage.h:
4311         (QnamThread::QnamThread):
4312         (QnamThread::~QnamThread):
4313         (QnamThread::networkAccessManager):
4314         (QnamThread::run):
4315
4316 2010-12-10  Martin Robinson  <mrobinson@igalia.com>
4317
4318         Reviewed by Xan Lopez.
4319
4320         [Gtk] style="font-family: courier" makes text disappear
4321         https://bugs.webkit.org/show_bug.cgi?id=47452
4322
4323         Add a test that verifies that fonts without valid charmaps are
4324         never selected.
4325
4326         * DumpRenderTree/gtk/DumpRenderTree.cpp:
4327         (initializeFonts): Initialize DRT with our font (derived from Ahem)
4328         that has no valid charmap.
4329         * DumpRenderTree/gtk/fonts/FontWithNoValidEncoding.fon: Added.
4330         * DumpRenderTree/gtk/fonts/fonts.conf: Updated settings to override users'
4331         settings which may disable selection of bitmap fonts.
4332
4333 2010-12-10  Eric Seidel  <eric@webkit.org>
4334
4335         Unreviewed.
4336
4337         The commit-queue should file bugs about flaky tests it encounters
4338         https://bugs.webkit.org/show_bug.cgi?id=50803
4339
4340         create_bug_for_flaky_test was insufficiently tested, thus buggy.
4341         Now it's tested.
4342
4343         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
4344         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
4345
4346 2010-12-10  Eric Seidel  <eric@webkit.org>
4347
4348         Unreviewed.  Somehow this last-minute edit didn't quite get committed.
4349
4350         The commit-queue should file bugs about flaky tests it encounters
4351         https://bugs.webkit.org/show_bug.cgi?id=50803
4352
4353         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
4354
4355 2010-12-09  Eric Seidel  <eric@webkit.org>
4356
4357         Reviewed by Adam Barth.
4358
4359         The commit-queue should file bugs about flaky tests it encounters
4360         https://bugs.webkit.org/show_bug.cgi?id=50803
4361
4362         This change got a bit big.  I also added a new config.urls file
4363         because I needed to share the view_source_url code with committervalidator.py.
4364
4365         This adds a new class FlakyTestReporter which holds all the logic about
4366         reporting flaky tests to bugzilla.
4367
4368         Right now this code knows how to look up bugs for flaky tests.
4369         If it can't find a bug filed from the commit-queue, it will open a new
4370         one, ccing the relevant people and adding information about the failure.
4371
4372         It is not yet smart enough to chase down duplicate chains, or to include
4373         the actual failure diff.  But those can be added in later iterations.
4374
4375         * Scripts/webkitpy/common/checkout/api.py:
4376         * Scripts/webkitpy/common/checkout/changelog.py:
4377         * Scripts/webkitpy/common/checkout/commitinfo.py:
4378         * Scripts/webkitpy/common/config/committervalidator.py:
4379         * Scripts/webkitpy/common/config/urls.py: Copied from WebKitTools/Scripts/webkitpy/tool/comments.py.
4380         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
4381         * Scripts/webkitpy/tool/bot/flakytestreporter.py: Added.
4382         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py: Copied from WebKitTools/Scripts/webkitpy/tool/comments.py.
4383         * Scripts/webkitpy/tool/bot/irc_command.py:
4384         * Scripts/webkitpy/tool/bot/sheriff.py:
4385         * Scripts/webkitpy/tool/commands/download.py:
4386         * Scripts/webkitpy/tool/commands/queues.py:
4387         * Scripts/webkitpy/tool/commands/queues_unittest.py:
4388         * Scripts/webkitpy/tool/comments.py:
4389         * Scripts/webkitpy/tool/mocktool.py:
4390         * Scripts/webkitpy/tool/steps/commit.py:
4391
4392 2010-12-09  Eric Seidel  <eric@webkit.org>
4393
4394         Reviewed by Adam Barth.
4395
4396         Teach webkit-patch how to search bugzilla
4397         https://bugs.webkit.org/show_bug.cgi?id=50500
4398
4399         This is a step towards teaching webkitpy how to file
4400         new bugs for flaky tests and update them when new flakes occur.
4401
4402         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
4403         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
4404         * Scripts/webkitpy/tool/commands/__init__.py:
4405         * Scripts/webkitpy/tool/commands/bugsearch.py: Added.
4406
4407 2010-12-09  Adam Barth  <abarth@webkit.org>
4408
4409         Reviewed by Ojan Vafai.
4410
4411         commit-queue errors out due to local commits
4412         https://bugs.webkit.org/show_bug.cgi?id=50766
4413
4414         We seem to be tripping over having local commits in the working copy a
4415         lot recently.  I don't quite fully understand what the issue is, but
4416         this patch attempts to solve the problem by adding an explicit clean
4417         step before processing a patch.  Previously, we did the cleaning as
4418         part of the apply-attachment step, so this might not actually fix the
4419         problem.
4420
4421         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
4422         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
4423         * Scripts/webkitpy/tool/commands/queues_unittest.py:
4424
4425 2010-12-09  Dirk Pranke  <dpranke@chromium.org>
4426
4427         Reviewed by Ojan Vafai.
4428
4429         Make new-run-webkit-tests --lint-test-files log slightly better
4430         messages and return -1 if lint fails. Remove the
4431         'suppress_errors' keyword param to the TestExpectationsFile
4432         class, and clean up logging and exception raising for error
4433         handling. Also add more unit tests and clean up the unit test code a bit.
4434
4435         https://bugs.webkit.org/show_bug.cgi?id=50205
4436
4437         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4438         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
4439         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py
4440    &nb