898a301d10a51d1229ca855634c70aae7ffd387d
[WebKit.git] / Tools / ChangeLog
1 2010-12-22  Dirk Pranke  <dpranke@chromium.org>
2
3         Reviewed by Ojan Vafai.
4
5         nrwt multiprocessing - start over, prepare to fork the code
6  
7         This code cleans up the signatures and implementation of the
8         TestRunner class so we can easily fork it to run either the
9         stable implementation or the new, unstable message-passing
10         implementation. The two variants will have different
11         implementations of the run_tests() method. We will switch
12         between the two based on the setting for the '--worker-model'
13         switch. We rename the two currently valid values to 'old-inline'
14         and 'old-threads'.
15
16         https://bugs.webkit.org/show_bug.cgi?id=51081
17
18         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
19         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
20
21 2010-12-22  Victor Wang  <victorw@chromium.org>
22
23         Reviewed by Darin Fisher.
24
25         [Chromium] Update chromium archive test result url in rebaseline script.
26
27         https://bugs.webkit.org/show_bug.cgi?id=51503
28
29         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
30
31 2010-12-22  Lucas Forschler  <lforschler@apple.com>
32
33         Reviewed by Alice Liu.
34
35         <rdar://problem/8633222> record-memory-win needs to record memory used by the webprocess.
36         Verified on Chrome, Safari, and IE.
37         With this change, we will record memory from a parent browser window and all child processes.
38
39         * record-memory-win/main.cpp:
40         (ProcessArgs):
41         (PrintUsage):
42         (getMemoryInfo):
43         (printProcessInfo):
44         (evalProcesses):
45         (UseImage):
46         (QueryContinuously):
47         (ElapsedTime):
48
49 2010-12-22  Lucas Forschler  <lforschler@apple.com>
50
51         Unreviewed rollout r74489, because it was missing changelog.
52
53         * record-memory-win/main.cpp:
54         
55 2010-12-22  Ryosuke Niwa  <rniwa@webkit.org>
56
57         Adding myself as a reviewer.
58
59         * Scripts/webkitpy/common/config/committers.py:
60
61 2010-12-22  Andrew Scherkus  <scherkus@chromium.org>
62
63         Unreviewed.  Adding myself to committers.py.
64
65         * Scripts/webkitpy/common/config/committers.py:
66
67 2010-12-22  Ariya Hidayat  <ariya@sencha.com>
68
69         Reviewed by Kenneth Rohde Christiansen.
70
71         TestNetscapePlugIn should use #if defined
72         https://bugs.webkit.org/show_bug.cgi?id=51471
73
74         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
75         (NP_Initialize):
76         (NPP_New):
77
78 2010-12-22  Ilya Tikhonovsky  <loislo@chromium.org>
79
80         Reviewed by Yury Semikhatsky.
81
82         Web Inspector: [chromium] DRT inspector layout tests are flaky in debug.
83
84         DevTools window should be closed explicitly because it has custom deinitialization code.
85
86         https://bugs.webkit.org/show_bug.cgi?id=50722
87
88         * DumpRenderTree/chromium/TestShell.cpp:
89         (TestShell::closeRemainingWindows):
90
91 2010-12-22  David Levin  <levin@chromium.org>
92
93         Reviewed by Shinichiro Hamaji.
94
95         check-webkit-style shouldn't complaint about underscores in variables in objective C files.
96         https://bugs.webkit.org/show_bug.cgi?id=51452
97
98         * Scripts/webkitpy/style/checkers/cpp.py:
99         (_FileState.__init__): Added the information to determine if a file is C or Objective C.
100         Using the file extension if possible but falling back to the file contents if we have a header file.
101         (_FileState.is_objective_c): Determine if we have an Objective C by examining the file contents if needed.
102         (_FileState.is_c_or_objective_c):
103         (check_using_std): Changed to using _FileState to determine the file type.
104         (check_max_min_macros): Ditto.
105         (check_for_null): Ditto.
106         (check_style): Changed the parameters to various calls since they now need _FileState
107         to determine the file type.
108         (check_language): Added the file_state parameter so it could be passed
109         to check_identifier_name_in_declaration.
110         (check_identifier_name_in_declaration): Don't warn about underscores in variables if
111         this is an Objective C file.
112         (_process_lines): Added information for the _FileState constructor (and moved the
113         call to a place that had the information).
114         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
115         (CppFunctionsTest.test_is_c_or_objective_c): Changed the tests to use FileState and exercise
116         its functionality.
117         (WebKitStyleTest.test_names): Add tests for underscores in Objective C files.
118
119 2010-12-21  Andy Estes  <aestes@apple.com>
120
121         Reviewed by Mark Rowe.
122
123         Do not build non-Intel architectures for WebKit2-related projects.
124         https://bugs.webkit.org/show_bug.cgi?id=51440
125
126         * MiniBrowser/Configurations/Base.xcconfig: Only build for i386 and x86_64.
127         * TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
128         * WebKitTestRunner/Configurations/Base.xcconfig: Ditto.
129
130 2010-12-21  Mihai Parparita  <mihaip@chromium.org>
131
132         Reviewed by Darin Fisher.
133
134         [Chromium] Rename WebThemeEngine/ControlDRT to WebThemeEngine/ControlDRTWin
135         https://bugs.webkit.org/show_bug.cgi?id=51406 
136         
137         Rename WebThemeControlDRT to WebThemeControlDRTWin and WebThemeEngineDRT
138         to WebThemeEngineDRTWin and update references everywhere.
139
140         * DumpRenderTree/DumpRenderTree.gypi:
141         * DumpRenderTree/chromium/TestShellWin.cpp:
142         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRT.cpp.
143         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRT.h.
144         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRT.cpp.
145         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRT.h.
146
147 2010-12-21  Anders Carlsson  <andersca@apple.com>
148
149         Reviewed by John Sullivan.
150
151         Clicking missing plug-in text does not show a sheet
152         https://bugs.webkit.org/show_bug.cgi?id=51403
153
154         Update for changes to the WebPageUIClient.
155
156         * MiniBrowser/mac/BrowserWindowController.m:
157         (-[BrowserWindowController awakeFromNib]):
158         * WebKitTestRunner/TestController.cpp:
159         (WTR::createOtherPage):
160         (WTR::TestController::initialize):
161
162 2010-12-21  Eric Seidel  <eric@webkit.org>
163
164         Reviewed by Adam Barth.
165
166         commit-queue will report constant failures as flaky if other tests flake
167         https://bugs.webkit.org/show_bug.cgi?id=51272
168
169         This patch just removes functionality and adds testing.
170         Previously we attempted to report flaky tests when we had
171         two different tests fail in a row.  However, since we stop
172         running the tests at the first failure, our code was wrong in
173         trying to determine flakiness from the incomplete runs.
174
175         Originally I posted an alternate patch:
176         https://bug-51272-attachments.webkit.org/attachment.cgi?id=77078
177         which fixed our flaky logic in this case, however it was decided
178         that that patch would be too difficult to maintain, so now
179         I'm just removing the broken logic.
180
181         This will dramatically cut-down on our flaky-test false positives
182         at the (small) cost of the queues being unable to report
183         any flakiness if the tree is very flaky.  (With at least one test
184         flaking on every run, we'll never report failures anymore.)  I think
185         this is a tradeoff worth making.
186
187         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
188         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
189
190 2010-12-20  Eric Seidel  <eric@webkit.org>
191
192         Reviewed by Adam Barth.
193
194         commit-queue wrongly rejects patches when it can't update itself
195         https://bugs.webkit.org/show_bug.cgi?id=46636
196
197         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
198         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
199         * Scripts/webkitpy/tool/commands/queues_unittest.py:
200
201 2010-12-20  Adam Barth  <abarth@webkit.org>
202
203         Move web sites to Websites directory
204         https://bugs.webkit.org/show_bug.cgi?id=51323
205
206         Update references to BugsSite to point to the new location.
207
208         This patch was never officially reviewed (because it was too large to
209         upload to bugs.webkit.org), but it was discussed on webkit-dev and Mark
210         Rowe gave me the green light.
211
212         * Scripts/old-run-webkit-tests:
213         * Scripts/webkitpy/common/config/build.py:
214         * Scripts/webkitpy/common/config/build_unittest.py:
215         * Scripts/webkitpy/common/prettypatch.py:
216         * Scripts/webkitpy/layout_tests/port/base.py:
217         * Scripts/webkitpy/style/main.py:
218
219 2010-12-20  Adrienne Walker  <enne@google.com>
220
221         Unreviewed. Adding myself to the list of committers.
222
223         * webkitpy/common/config/committers.py:
224
225 2010-12-20  Mark Rowe  <mrowe@apple.com>
226
227         Reviewed by Dan Bernstein.
228
229         <rdar://problem/8757601> Don't install header files in to the Resources directory.
230
231         * Scripts/check-for-inappropriate-files-in-framework: Don't allow .h files in the
232         Resources directory.
233
234 2010-12-20  Eric Seidel  <eric@webkit.org>
235
236         Reviewed by Adam Barth.
237
238         commit-queue should include bot id when attaching failure diffs
239         https://bugs.webkit.org/show_bug.cgi?id=51280
240
241         This is a tiny change to include the bot id in the name of the attachment.
242         Most of this diff is just changing the unit test expectations
243         now that I hid the comment printing when the comment is None.
244
245         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
246         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
247         * Scripts/webkitpy/tool/commands/upload_unittest.py:
248         * Scripts/webkitpy/tool/mocktool.py:
249
250 2010-12-20  Jeff Miller  <jeffm@apple.com>
251
252         Reviewed by Dan Bernstein.
253
254         Tools/vcbin/midl.exe needs to be rebuilt
255         https://bugs.webkit.org/show_bug.cgi?id=51347
256
257         * vcbin/midl.exe: Rebuilt.
258
259 2010-12-20  David Levin  <levin@chromium.org>
260
261         Reviewed by Ariya Hidayat.
262
263         .gitignore and webkit-tools-completion.sh have references to WebKitTools that should be Tools.
264         https://bugs.webkit.org/show_bug.cgi?id=51343
265
266         Follow up from the WebKitTools -> Tools rename.
267
268         * Scripts/webkit-tools-completion.sh:
269
270 2010-12-20  Cosmin Truta  <ctruta@chromium.org>
271
272         Reviewed by James Robinson.
273
274         new-run-webkit-tests ignores trailing EOL differences in text tests
275         https://bugs.webkit.org/show_bug.cgi?id=36983
276
277         Changed the handling of new-line characters within new-run-webkit-tests
278         to match old-run-webkit-tests.  Differences in leading and trailing empty
279         lines in text expectation files are no longer ignored.
280
281         * Scripts/webkitpy/layout_tests/port/base.py:
282         * Scripts/webkitpy/layout_tests/port/test.py:
283         Added unit tests.  Removed old duplicate unit test entries.
284         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
285
286 2010-12-20  David Levin  <levin@chromium.org>
287
288         Reviewed by Shinichiro Hamaji.
289
290         check-webkit-style should detect function declarations (and trivial functions).
291         https://bugs.webkit.org/show_bug.cgi?id=51303
292
293         * Scripts/webkitpy/style/checkers/cpp.py:
294         (_FunctionState.begin): Add is_declaration and changed the line count
295         start to begin at -1 (which will keep the results consistent, since
296         the starting line number passed in is one less in this change).
297         (detect_functions): changed function detection to now catch trivial
298         functions and declarations.
299         (check_pass_ptr_usage): Don't check for Pass*Ptr on the first line
300         of the function as this may look at return values (when processing
301         a declaration).
302         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
303         (FunctionDetectionTest.perform_function_detection): Basic mechanics
304         of testing the function detection.
305         (FunctionDetectionTest.test_basic_function_detection): Test a simple
306         function.
307         (FunctionDetectionTest.test_function_declaration_detection): Test a
308         declaration.
309         (FunctionDetectionTest.test_non_functions): A test case for a case
310         that caused the code to fail due to the { being in quotes.
311         (PassPtrTest.test_pass_ref_ptr_return_value): Added some more test
312         cases to help catch false alarms for return values.
313         (PassPtrTest.test_pass_ref_ptr_member_variable): Ensure that
314         we don't get false alarms for member variables either.
315
316 2010-12-20  Ryuan Choi  <ryuan.choi@samsung.com>
317
318         Reviewed by Antonio Gomes.
319
320         [CMAKE] Rename WEBKITTOOLS_DIR to TOOLS_DIR
321         https://bugs.webkit.org/show_bug.cgi?id=51319
322
323         * CMakeListsEfl.txt:
324
325 2010-12-18  Adam Barth  <abarth@webkit.org>
326
327         Reviewed by Sam Weinig.
328
329         Move WebKitExamplePlugins to Examples
330         https://bugs.webkit.org/show_bug.cgi?id=51291
331
332         * Scripts/webkitpy/common/config/build.py:
333
334 2010-12-17  Csaba Osztrogonác  <ossy@webkit.org>
335
336         Unreviewed Qt buildfix after r74301.
337
338         Rename WebKitTools to Tools
339         https://bugs.webkit.org/show_bug.cgi?id=49861
340
341         * MiniBrowser/DerivedSources.pro:
342         * MiniBrowser/qt/MiniBrowser.pro:
343
344 2010-12-17  Dan Bernstein  <mitz@apple.com>
345
346         Reviewed by Simon Fraser.
347
348         Rename WebKitTools to Tools
349         https://bugs.webkit.org/show_bug.cgi?id=49861
350
351         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
352         * CodeCoverage/README:
353         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
354         (WebCore::DumpRenderTree::initializeFonts):
355         * EWSTools/start-commit-queue.sh:
356         * EWSTools/start-queue.sh:
357         * GNUmakefile.am:
358         * MIDLWrapper/MIDLWrapper.cpp:
359         (wmain):
360         * MiniBrowser/qt/MiniBrowser.pro:
361         * Scripts/build-api-tests:
362         * Scripts/build-dumprendertree:
363         * Scripts/build-webkit:
364         * Scripts/build-webkittestrunner:
365         * Scripts/generate-coverage-data:
366         * Scripts/old-run-webkit-tests:
367         * Scripts/run-api-tests:
368         * Scripts/run-iexploder-tests:
369         * Scripts/run-javascriptcore-tests:
370         * Scripts/run-mangleme-tests:
371         * Scripts/run-sunspider:
372         * Scripts/run-webkit-websocketserver:
373         * Scripts/sunspider-compare-results:
374         * Scripts/test-webkitperl:
375         * Scripts/test-webkitpy:
376         * Scripts/update-iexploder-cssproperties:
377         * Scripts/update-webkit:
378         * Scripts/update-webkit-localizable-strings:
379         * Scripts/webkitdirs.pm:
380         * Scripts/webkitpy/common/checkout/scm.py:
381         * Scripts/webkitpy/common/checkout/scm_unittest.py:
382         * Scripts/webkitpy/common/config/committervalidator.py:
383         * Scripts/webkitpy/common/config/committervalidator_unittest.py:
384         * Scripts/webkitpy/common/config/ports.py:
385         * Scripts/webkitpy/common/config/ports_unittest.py:
386         * Scripts/webkitpy/common/system/logutils_unittest.py:
387         * Scripts/webkitpy/common/system/ospath_unittest.py:
388         * Scripts/webkitpy/layout_tests/port/chromium.py:
389         * Scripts/webkitpy/layout_tests/port/config.py:
390         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
391         * Scripts/webkitpy/layout_tests/port/http_server.py:
392         * Scripts/webkitpy/layout_tests/port/test.py:
393         * Scripts/webkitpy/style/checker.py:
394         * Scripts/webkitpy/style/checker_unittest.py:
395         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
396         * Scripts/webkitpy/tool/commands/queues_unittest.py:
397         * Scripts/webkitpy/tool/steps/steps_unittest.py:
398         * WebKitTestRunner/DerivedSources.pro:
399         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
400         (WTR::activateFonts):
401         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
402         * wx/build/build_utils.py:
403
404 2010-12-16  Antonio Gomes  <agomes@rim.com>
405
406         Reviewed by Martin Robinson.
407
408         Settings::editingBehaviorType() incorrectly returns mac for the gtk build when running tests
409         https://bugs.webkit.org/show_bug.cgi?id=51163
410
411         Since GTK+'s default editing behavior was changed to UNIX in r70975 (see webkitwebsettings.cpp),
412         GTK+'s DRT should also reset to UNIX after each test execution.
413
414         * DumpRenderTree/gtk/DumpRenderTree.cpp:
415         (resetDefaultsToConsistentValues):
416
417 2010-12-17  David Levin  <levin@chromium.org>
418
419         Reviewed by Eric Seidel.
420
421         check-webkit-style should understand WTF #include guards
422         https://bugs.webkit.org/show_bug.cgi?id=44911
423
424         * Scripts/webkitpy/style/checkers/cpp.py:
425         (get_header_guard_cpp_variable): modify to suggest the WTF style
426         of header guard when appropriate.
427         (check_for_header_guard): handle multiple return values from
428         get_header_guard_cpp_variable
429         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
430         (CppStyleTest.test_build_header_guard): Added tests for the WTF
431         header style.
432
433 2010-12-16  David Levin  <levin@chromium.org>
434
435         Reviewed by Eric Seidel.
436
437         test-webkitpy: unittest for the xml.py checker displays a decprecation warning.
438         https://bugs.webkit.org/show_bug.cgi?id=51210
439
440         The error only shows up when using python 2.6 or later.
441
442         * Scripts/webkitpy/style/checkers/xml.py: Replace the usage of
443         the decprecated field error,message with something equivalent.
444
445 2010-12-16  Mihai Parparita  <mihaip@chromium.org>
446
447         Reviewed by Eric Seidel.
448
449         Add --exit-after-n-failures/crashes to NRWT
450         https://bugs.webkit.org/show_bug.cgi?id=51160
451         
452         Abort test run (in a similar way to how control-C is handled) when
453         --exit-after-n-failures/crashes-or-timeouts are passed and we've reached
454         that number of unexpected failures/crashes/timeouts.
455
456         * Scripts/webkitpy/layout_tests/port/test.py:
457         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
458         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
459
460 2010-12-16  David Levin  <levin@chromium.org>
461
462         Reviewed by Shinichiro Hamaji.
463
464         check-webkit-style unit tests has some duplicate boilerplate code.
465         https://bugs.webkit.org/show_bug.cgi?id=49519
466
467         * Scripts/webkitpy/style/checkers/cpp.py:
468         (update_include_state): Replaced the "io" parameter with the global
469         configuration _unit_test_config. This allowed not calling into
470         functions at a low level and also not plumbing through the injection
471         information through many levels of code.
472         (check_for_include_what_you_use): Ditto.
473         (process_file_data): Added the ability to set up the unit test config
474         to allow for injection.
475         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
476         (ErrorCollector.__init__): Added support for having a filter for errors.
477         (ErrorCollector.__call__): Ditto.
478         (CppStyleTestBase.process_file_data): Added the ability to set unit_test_config.
479         (CppStyleTestBase.perform_lint): Consolidated logic for the perform functions.
480         (CppStyleTestBase.perform_single_line_lint): Replace specific calls to
481         functions in the cpp.py with generic processing and a filter that
482         indicates what errors should be kept.
483         (CppStyleTestBase.perform_multi_line_lint): Ditto.
484         (CppStyleTestBase.perform_language_rules_check): Ditto.
485         (CppStyleTestBase.perform_function_lengths_check): Ditto.
486         (CppStyleTestBase.perform_pass_ptr_check): Ditto.
487         (CppStyleTestBase.perform_include_what_you_use): Ditto.
488         (CppStyleTest.test_multi_line_comments): Added another
489         error message which applies to the test case.
490         (CppStyleTest.test_spacing_for_binary_ops): Fixed test
491         to not have config.h, since it is processed as a header file.
492         (CppStyleTest.test_static_or_global_stlstrings): Fixed variable name
493         style and indentation in checked code.
494         (OrderOfIncludesTest.test_check_preprocessor_in_include_section):
495         Fixed line number.
496         (NoNonVirtualDestructorsTest.test_multi_line_declaration_with_error):
497         Ditto.
498
499 2010-12-15  Sheriff Bot  <webkit.review.bot@gmail.com>
500
501         Unreviewed, rolling out r74136.
502         http://trac.webkit.org/changeset/74136
503         https://bugs.webkit.org/show_bug.cgi?id=51135
504
505         r74136 breaks chromium canary bots because some tests are not
506         rebaselined correctly to resolve EOL differences (Requested by
507         jianli on #webkit).
508
509         * Scripts/webkitpy/layout_tests/port/base.py:
510         * Scripts/webkitpy/layout_tests/port/test.py:
511         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
512
513 2010-12-15  Adam Roben  <aroben@apple.com>
514
515         Teach check-webkit-style to check .vcproj and .vsprops files for XML
516         syntax errors
517
518         Fixes <http://webkit.org/b/51103> check-webkit-style should check for
519         XML syntax errors in .vcproj/.vsprops files
520
521         Reviewed by Dave Levin.
522
523         * Scripts/webkitpy/style/checker.py: Added lists of file extensions
524         that should be treated as XML and that should be allowed to contain
525         carriage returns. (These lists happen to be identical currently.)
526         (FileType): Added a new XML type.
527         (CheckerDispatcher.should_check_and_strip_carriage_returns): Added.
528         Just does a simple file extension check.
529         (CheckerDispatcher._file_type): Added a case for XML files.
530         (CheckerDispatcher._create_checker): Ditto. We use XMLChecker for XML
531         files (surprise!).
532         (StyleProcessor.process): Ask the dispatcher whether we should pass the
533         lines through the carriage checker.
534
535         * Scripts/webkitpy/style/checker_unittest.py:
536         (CheckerDispatcherCarriageReturnTest.test_should_check_and_strip_carriage_returns):
537         Added. Checks a few file names to see if carriage returns are allowed
538         or not.
539         (CheckerDispatcherDispatchTest.assert_checker_xml): Added. Similar to
540         other assert_checker_* functions.
541         (CheckerDispatcherDispatchTest.test_xml_paths): Added. Similar to other
542         test_*_paths functions.
543         (CheckerDispatcherDispatchTest.test_xml_paths): Added. Similar to other
544         test_*_paths functions.
545         (CheckerDispatcherDispatchTest.test_none_paths): Removed the vcproj
546         file from this test case, as vcproj files now have a type.
547         (StyleProcessor_CodeCoverageTest.MockDispatcher.should_check_and_strip_carriage_returns):
548         Added. Similar to the other should_* functions.
549         (StyleProcessor_CodeCoverageTest.test_process__carriage_returns_not_stripped):
550         Added. Checks that carriage returns aren't checked for or stripped for
551         allowed files.
552
553         * Scripts/webkitpy/style/checkers/xml.py: Added.
554         (XMLChecker.__init__): Simple init method.
555         (XMLChecker.check): Pass each line through the expat parser, and record
556         a style error for any errors thrown by the parser.
557
558         * Scripts/webkitpy/style/checkers/xml_unittest.py: Added.
559         (XMLCheckerTest.assert_no_error): Checks that the given XML does not
560         produce a style error.
561         (XMLCheckerTest.assert_error): Checks that the given XML produces an
562         error of the given category on the given line.
563         (XMLCheckerTest.mock_handle_style_error): Does nothing. Used for
564         checking that the XMLChecker constructor works properly.
565         (XMLCheckerTest.test_conflict_marker): Tests that conflict markers
566         cause a style error (see, e.g., r73887).
567         (XMLCheckerTest.test_extra_closing_tag): Tests that extra closing tags
568         cause a style error (see, e.g., r73773).
569         (XMLCheckerTest.test_init): Tests that the XMLChecker constructor works
570         properly.
571         (XMLCheckerTest.test_missing_closing_tag): Tests that missing closing
572         tags cause a style error (see, e.g., r72795).
573         (XMLCheckerTest.test_no_error): Tests that valid XML does not cause a
574         style error.
575
576 2010-12-15  Lucas Forschler  <lforschler@apple.com>
577
578         Reviewed by Stephanie Lewis.
579
580         https://bugs.webkit.org/show_bug.cgi?id=51117
581         Add a new leopard test bot
582         really really commit to trunk this time.
583
584         * BuildSlaveSupport/build.webkit.org-config/config.json:
585
586 2010-12-15  Sam Weinig  <sam@webkit.org>
587
588         Reviewed by Anders Carlsson.
589
590         WebKit2: Can't add files to an <input type=file>
591         https://bugs.webkit.org/show_bug.cgi?id=51087
592
593         * MiniBrowser/mac/BrowserWindowController.m:
594         (runOpenPanel):
595         (-[BrowserWindowController awakeFromNib]):
596         Add simple implementation of runOpenPanel callback.
597
598         * MiniBrowser/win/BrowserView.cpp:
599         (BrowserView::create):
600         * WebKitTestRunner/TestController.cpp:
601         (WTR::createOtherPage):
602         (WTR::TestController::initialize):
603         Stub out runOpenPanel callback. 
604
605 2010-12-14  Eric Seidel  <eric@webkit.org>
606
607         Reviewed by Adam Barth.
608
609         commit-queue should upload failure diffs when tests flake
610         https://bugs.webkit.org/show_bug.cgi?id=51051
611
612         To make this testable I needed to pipe FileSystem down onto tool.
613         We've wanted it there for a long time anyway.
614
615         This patch is kinda a big hack.  But we don't have a nice
616         way to read results.html files.  I think this will need further
617         revision before this code actually feels clean.
618
619         As part of testing this change, I had to make MockBugzilla.create_bug
620         actually return an id (like it should) which required updating
621         a few other unit test results (for the better).
622
623         The results_matching_keys change in layouttestresults/rebasline
624         was an alternate path which I decided not to use in the end, but
625         I left the change as it seemed an improvement.
626
627         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
628         * Scripts/webkitpy/common/net/layouttestresults.py:
629         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
630         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
631         * Scripts/webkitpy/tool/commands/queues.py:
632         * Scripts/webkitpy/tool/commands/rebaseline.py:
633         * Scripts/webkitpy/tool/main.py:
634         * Scripts/webkitpy/tool/mocktool.py:
635
636 2010-12-15  Cosmin Truta  <ctruta@chromium.org>
637
638         Reviewed by James Robinson.
639
640         new-run-webkit-tests ignores trailing EOL differences in text tests
641         https://bugs.webkit.org/show_bug.cgi?id=36983
642
643         Changed the handling of new-line characters within new-run-webkit-tests
644         to match old-run-webkit-tests.  Differences in leading and trailing empty
645         lines in text expectation files are no longer ignored.
646
647         * Scripts/webkitpy/layout_tests/port/base.py:
648         * Scripts/webkitpy/layout_tests/port/test.py:
649         Added unit tests.  Removed old duplicate unit test entries.
650         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
651
652 2010-12-15  Ojan Vafai  <ojan@chromium.org>
653
654         Reviewed by Adam Barth.
655
656         make status-bubble white-space:nowrap so we can measure it's width without wrapping
657         https://bugs.webkit.org/show_bug.cgi?id=51149
658
659         * QueueStatusServer/templates/statusbubble.html:
660
661 2010-12-15  Ojan Vafai  <ojan@chromium.org>
662
663         Reviewed by Adam Barth.
664
665         have the statusbubble postMessage it's metrics so that embedders can properly size the iframe
666         https://bugs.webkit.org/show_bug.cgi?id=51125
667
668         * QueueStatusServer/templates/statusbubble.html:
669
670 2010-12-15  Darin Adler  <darin@apple.com>
671
672         * Scripts/webkitpy/common/net/buildbot: Added property svn:ignore.
673
674 2010-12-15  Sheriff Bot  <webkit.review.bot@gmail.com>
675
676         Unreviewed, rolling out r74117.
677         http://trac.webkit.org/changeset/74117
678         https://bugs.webkit.org/show_bug.cgi?id=51113
679
680         This broke the GTK1 build. (Requested by mrobinson on
681         #webkit).
682
683         * Scripts/webkitdirs.pm:
684
685 2010-12-15  Amruth Raj  <amruthraj@motorola.com> and Ravi Kasibhatla  <ravi.kasibhatla@motorola.com>
686
687         Reviewed by Martin Robinson.
688
689         Change generate-forwarding-headers.pl for GTK port usage 
690         (https://bugs.webkit.org/show_bug.cgi?id=37369)
691
692         * Scripts/webkitdirs.pm: Added changes to build webkit2 for GTK port using build-webkit script.
693
694 2010-12-14  Kent Tamura  <tkent@chromium.org>
695
696         Reviewed by Jian Li.
697
698         [DRT/Chromium] Remove another unnecessary error message
699         https://bugs.webkit.org/show_bug.cgi?id=51083
700
701         * DumpRenderTree/chromium/WebViewHost.cpp:
702         (WebViewHost::didInvalidateRect):
703
704 2010-12-14  Lucas Forschler  <lforschler@apple.com>
705
706         Reviewed by Stephanie Lewis.
707
708         Add a new Leopard Debug Test WK2 Bot
709
710         * BuildSlaveSupport/build.webkit.org-config/config.json:
711
712 2010-12-14  Ojan Vafai  <ojan@chromium.org>
713
714         Fix python unittests after http://trac.webkit.org/changeset/74070.
715
716         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
717
718 2010-12-14  Kent Tamura  <tkent@chromium.org>
719
720         Reviewed by Jian Li.
721
722         [DRT/Chromium] Remove a unnecessary error message
723         https://bugs.webkit.org/show_bug.cgi?id=51069
724
725         * DumpRenderTree/chromium/WebViewHost.cpp:
726         (WebViewHost::paintInvalidatedRegion):
727
728 2010-12-14  Benjamin Kalman  <kalman@chromium.org>
729
730         Reviewed by Ojan Vafai.
731
732         Using BUG/BUGWK in test_expectations is error prone, should use BUGCR/BUGWK
733         https://bugs.webkit.org/show_bug.cgi?id=48926
734
735         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
736         Add presubmit check that BUG isn't used, either BUGCR/BUGWK/BUGV8_.
737
738 2010-12-14  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
739
740         Reviewed by Eric Seidel.
741
742         [Qt] [Symbian] Do not use pkg-config on Symbian as it is not supported
743         https://bugs.webkit.org/show_bug.cgi?id=50231
744
745         Guard CONFIG+=link_pkgconfig with !symbian.
746
747         * DumpRenderTree/qt/DumpRenderTree.pro:
748         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
749         * WebKitTestRunner/qt/WebKitTestRunner.pro:
750
751 2010-12-14  Philippe Normand  <pnormand@igalia.com>
752
753         Reviewed by Ojan Vafai.
754
755         [new-run-webkit-tests] expectations parsing is slow
756         https://bugs.webkit.org/show_bug.cgi?id=50635
757
758         Avoid expensive iteration of all the tests when checking if a test
759         file is to be skipped or not.
760
761         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
762         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
763         * Scripts/webkitpy/layout_tests/port/test.py:
764
765 2010-12-14  Mario Sanchez Prada  <msanchez@igalia.com>
766
767         Reviewed by Xan Lopez.
768
769         [Gtk] Implement STATE_FOCUSED, STATE_FOCUSABLE, and corresponding events for text objects
770         https://bugs.webkit.org/show_bug.cgi?id=27048
771
772         Add support in DRT for checking whether an accessibility UI
773         element is focusable and/or focused. Implemented for GTK.
774
775         * DumpRenderTree/AccessibilityUIElement.cpp:
776         (getIsFocusedCallback): New.
777         (getIsFocusableCallback): New.
778         (AccessibilityUIElement::getJSClass): Add the new available
779         callbacks for isFocused and isFocusable.
780         * DumpRenderTree/AccessibilityUIElement.h:
781         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
782         (AccessibilityUIElement::isFocused): New, implemented by checking
783         whether the related AtkState value is in the object's state set.
784         (AccessibilityUIElement::isFocusable): Ditto.
785         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
786         (AccessibilityUIElement::isFocused): New, dummy implementation.
787         (AccessibilityUIElement::isFocusable): Ditto.
788         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
789         (AccessibilityUIElement::isFocused): Ditto.
790         (AccessibilityUIElement::isFocusable): Ditto.
791
792 2010-12-14  Eric Seidel  <eric@webkit.org>
793
794         Reviewed by Ojan Vafai.
795
796         webkit-patch should warn users when they're using a 32-bit git on a 64-bit system
797         https://bugs.webkit.org/show_bug.cgi?id=50715
798
799         This patch makes webkit-patch print the following:
800
801         Warning: This machine is 64-bit, but the git binary (/usr/local/git/bin/git) does not support 64-bit.
802         Install a 64-bit git for better performance, see:
803         https://lists.webkit.org/pipermail/webkit-dev/2010-December/015249.html
804
805         I wrote this mostly because I have approximately 8 machines that I use
806         and making sure each one is using a good Git install seemed folly.
807         webkit-patch makes a lot of git calls, so using a fast git can shave
808         several seconds in every invocation.  See the webkit-dev thread for more info.
809
810         This message will print twice during 'webkit-patch upload',
811         once from webkit-patch and once from check-webkit-style.
812
813         Unfortunately there is no good way to test this due to how machine-dependent
814         the code is.  I considered writing a test for the log message, but it seemed not worth it.
815
816         * Scripts/webkitpy/common/checkout/scm.py:
817
818 2010-12-13  Eric Seidel  <eric@webkit.org>
819
820         Reviewed by Adam Barth.
821
822         FlakyTestReporter doesn't understand bots running from multiple email addresses
823         https://bugs.webkit.org/show_bug.cgi?id=50960
824
825         This explains at least one of the dupes of:
826         https://bugs.webkit.org/show_bug.cgi?id=50863
827         that we saw filed by the commit-queue this morning.
828         I think the other one was explained by my previous fix to result counting code.
829
830         Since this is really hard to test with a unit test, instead I
831         create a new (possibly useful in the future) command
832         which given a layout test path will return you
833         the one bug which our tools would assume it the flaky test bug.
834         If some other script wants to use bug-for-test we'll
835         need to extend it with some options like --create-if-missing or similar.
836
837         * Scripts/webkitpy/common/net/bugzilla/bug.py:
838         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
839         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
840         * Scripts/webkitpy/tool/commands/__init__.py:
841         * Scripts/webkitpy/tool/commands/bugfortest.py: Added.
842
843 2010-12-13  Mihai Parparita  <mihaip@chromium.org>
844
845         Reviewed by James Robinson.
846
847         Add option to build-webkit to not build WebKit2
848         https://bugs.webkit.org/show_bug.cgi?id=50988
849         
850         Add support for a --no-webkit2 option to build-webkit. It seems to save
851         ~1 minute from clean builds and ~10 seconds from no-op builds.
852
853         * Scripts/build-webkit:
854
855 2010-12-13  Lucas Forschler  <lforschler@apple.com>
856
857         Reviewed by Dave Kilzer.
858
859         Update iexploder from 1.3.2 to 1.7.2
860         Move 1.3.2 into its own subdir
861         Add 1.7.2 into its own subdir
862         update scripts to point to new 1.3.2 location (avoid breaking existing scripts)
863
864         * Scripts/run-iexploder-tests:
865         * Scripts/update-iexploder-cssproperties:
866         * iExploder/CHANGELOG.txt: Removed.
867         * iExploder/LICENSE.txt: Removed.
868         * iExploder/README.txt: Removed.
869         * iExploder/htdocs: Removed.
870         * iExploder/iexploder-1.3.2: Added.
871         * iExploder/iexploder-1.3.2/CHANGELOG.txt: Copied from iExploder/CHANGELOG.txt.
872         * iExploder/iexploder-1.3.2/LICENSE.txt: Copied from iExploder/LICENSE.txt.
873         * iExploder/iexploder-1.3.2/README.txt: Copied from iExploder/README.txt.
874         * iExploder/iexploder-1.3.2/htdocs: Added.
875         * iExploder/iexploder-1.3.2/htdocs/config.rb: Copied from iExploder/htdocs/config.rb.
876         * iExploder/iexploder-1.3.2/htdocs/cssproperties.in: Copied from iExploder/htdocs/cssproperties.in.
877         * iExploder/iexploder-1.3.2/htdocs/cssvalues.in: Copied from iExploder/htdocs/cssvalues.in.
878         * iExploder/iexploder-1.3.2/htdocs/htmlattrs.in: Copied from iExploder/htdocs/htmlattrs.in.
879         * iExploder/iexploder-1.3.2/htdocs/htmltags.in: Copied from iExploder/htdocs/htmltags.in.
880         * iExploder/iexploder-1.3.2/htdocs/htmlvalues.in: Copied from iExploder/htdocs/htmlvalues.in.
881         * iExploder/iexploder-1.3.2/htdocs/iexploder.cgi: Copied from iExploder/htdocs/iexploder.cgi.
882         * iExploder/iexploder-1.3.2/htdocs/iexploder.rb: Copied from iExploder/htdocs/iexploder.rb.
883         * iExploder/iexploder-1.3.2/htdocs/index.html: Copied from iExploder/htdocs/index.html.
884         * iExploder/iexploder-1.3.2/htdocs/webserver.rb: Copied from iExploder/htdocs/webserver.rb.
885         * iExploder/iexploder-1.3.2/tools: Added.
886         * iExploder/iexploder-1.3.2/tools/lasthit.rb: Copied from iExploder/tools/lasthit.rb.
887         * iExploder/iexploder-1.3.2/tools/osx_last_crash.rb: Copied from iExploder/tools/osx_last_crash.rb.
888         * iExploder/iexploder-1.3.2/tools/showtest.rb: Copied from iExploder/tools/showtest.rb.
889         * iExploder/iexploder-1.7.2: Added.
890         * iExploder/iexploder-1.7.2/ChangeLog.txt: Added.
891         * iExploder/iexploder-1.7.2/LICENSE.txt: Added.
892         * iExploder/iexploder-1.7.2/README.txt: Added.
893         * iExploder/iexploder-1.7.2/output: Added.
894         * iExploder/iexploder-1.7.2/src: Added.
895         * iExploder/iexploder-1.7.2/src/browser_harness.rb: Added.
896         * iExploder/iexploder-1.7.2/src/config.yaml: Added.
897         * iExploder/iexploder-1.7.2/src/css-atrules: Added.
898         * iExploder/iexploder-1.7.2/src/css-atrules/mozilla: Added.
899         * iExploder/iexploder-1.7.2/src/css-atrules/webkit: Added.
900         * iExploder/iexploder-1.7.2/src/css-properties: Added.
901         * iExploder/iexploder-1.7.2/src/css-properties/dillo: Added.
902         * iExploder/iexploder-1.7.2/src/css-properties/gtkhtml: Added.
903         * iExploder/iexploder-1.7.2/src/css-properties/internet_explorer6: Added.
904         * iExploder/iexploder-1.7.2/src/css-properties/mozilla: Added.
905         * iExploder/iexploder-1.7.2/src/css-properties/webkit: Added.
906         * iExploder/iexploder-1.7.2/src/css-pseudo: Added.
907         * iExploder/iexploder-1.7.2/src/css-pseudo/mozilla: Added.
908         * iExploder/iexploder-1.7.2/src/css-pseudo/webkit: Added.
909         * iExploder/iexploder-1.7.2/src/css-values: Added.
910         * iExploder/iexploder-1.7.2/src/css-values/dillo: Added.
911         * iExploder/iexploder-1.7.2/src/css-values/gtkhtml: Added.
912         * iExploder/iexploder-1.7.2/src/css-values/mozilla: Added.
913         * iExploder/iexploder-1.7.2/src/css-values/other: Added.
914         * iExploder/iexploder-1.7.2/src/css-values/webkit: Added.
915         * iExploder/iexploder-1.7.2/src/headers: Added.
916         * iExploder/iexploder-1.7.2/src/headers/dillo: Added.
917         * iExploder/iexploder-1.7.2/src/headers/gtkhtml: Added.
918         * iExploder/iexploder-1.7.2/src/headers/mozilla: Added.
919         * iExploder/iexploder-1.7.2/src/headers/webkit: Added.
920         * iExploder/iexploder-1.7.2/src/html-attrs: Added.
921         * iExploder/iexploder-1.7.2/src/html-attrs/dillo: Added.
922         * iExploder/iexploder-1.7.2/src/html-attrs/gtkhtml: Added.
923         * iExploder/iexploder-1.7.2/src/html-attrs/internet_explorer6: Added.
924         * iExploder/iexploder-1.7.2/src/html-attrs/mozilla: Added.
925         * iExploder/iexploder-1.7.2/src/html-attrs/other: Added.
926         * iExploder/iexploder-1.7.2/src/html-attrs/webkit: Added.
927         * iExploder/iexploder-1.7.2/src/html-tags: Added.
928         * iExploder/iexploder-1.7.2/src/html-tags/dillo: Added.
929         * iExploder/iexploder-1.7.2/src/html-tags/gtkhtml: Added.
930         * iExploder/iexploder-1.7.2/src/html-tags/mozilla: Added.
931         * iExploder/iexploder-1.7.2/src/html-tags/other: Added.
932         * iExploder/iexploder-1.7.2/src/html-tags/webkit: Added.
933         * iExploder/iexploder-1.7.2/src/html-values: Added.
934         * iExploder/iexploder-1.7.2/src/html-values/dillo: Added.
935         * iExploder/iexploder-1.7.2/src/html-values/gtkhtml: Added.
936         * iExploder/iexploder-1.7.2/src/html-values/mozilla: Added.
937         * iExploder/iexploder-1.7.2/src/html-values/other: Added.
938         * iExploder/iexploder-1.7.2/src/html-values/webkit: Added.
939         * iExploder/iexploder-1.7.2/src/iexploder.cgi: Added.
940         * iExploder/iexploder-1.7.2/src/iexploder.rb: Added.
941         * iExploder/iexploder-1.7.2/src/index.html: Added.
942         * iExploder/iexploder-1.7.2/src/media: Added.
943         * iExploder/iexploder-1.7.2/src/media/blank.ogg: Added.
944         * iExploder/iexploder-1.7.2/src/media/blank.snd: Added.
945         * iExploder/iexploder-1.7.2/src/media/blank.wav: Added.
946         * iExploder/iexploder-1.7.2/src/media/bug.bmp: Added.
947         * iExploder/iexploder-1.7.2/src/media/bug.gif: Added.
948         * iExploder/iexploder-1.7.2/src/media/bug.ico: Added.
949         * iExploder/iexploder-1.7.2/src/media/bug.jng: Added.
950         * iExploder/iexploder-1.7.2/src/media/bug.jpg: Added.
951         * iExploder/iexploder-1.7.2/src/media/bug.png: Added.
952         * iExploder/iexploder-1.7.2/src/media/bug.svg: Added.
953         * iExploder/iexploder-1.7.2/src/media/bug.tiff: Added.
954         * iExploder/iexploder-1.7.2/src/media/bug.xbm: Added.
955         * iExploder/iexploder-1.7.2/src/media/bug.xpm: Added.
956         * iExploder/iexploder-1.7.2/src/mime-types: Added.
957         * iExploder/iexploder-1.7.2/src/mime-types/dillo: Added.
958         * iExploder/iexploder-1.7.2/src/mime-types/mozilla: Added.
959         * iExploder/iexploder-1.7.2/src/mime-types/webkit: Added.
960         * iExploder/iexploder-1.7.2/src/protocols: Added.
961         * iExploder/iexploder-1.7.2/src/protocols/dillo: Added.
962         * iExploder/iexploder-1.7.2/src/protocols/gtkhtml: Added.
963         * iExploder/iexploder-1.7.2/src/protocols/mozilla: Added.
964         * iExploder/iexploder-1.7.2/src/protocols/webkit: Added.
965         * iExploder/iexploder-1.7.2/src/scanner.rb: Added.
966         * iExploder/iexploder-1.7.2/src/version.rb: Added.
967         * iExploder/iexploder-1.7.2/src/webserver.rb: Added.
968         * iExploder/iexploder-1.7.2/testcases: Added.
969         * iExploder/iexploder-1.7.2/testcases/testcase-Linux_x86_64_rv2.0b6pre_Gecko-20100904_Firefox-4.0b6pre-TEST-8375-1_59.html: Added.
970         * iExploder/iexploder-1.7.2/testcases/testcase-Opera-9.80_Linux_x86_64_en_Presto-2.6.30_Version-10.61-16704-3_108,3.html: Added.
971         * iExploder/iexploder-1.7.2/testcases/testcase-U_Intel_Mac_OS_X_10_6_4_en-US_AppleWebKit-534.8_Chrome-7.0.529.0-TEST-611-3_36,9.html: Added.
972         * iExploder/iexploder-1.7.2/testcases/testcase-U_Intel_Mac_OS_X_10_6_4_en-US_AppleWebKit-534.8_hrome-7.0.529.0-TEST-55313622206-3_6,0.html: Added.
973         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.6_Chrome-7.0.503.1-TEST-120813-8_72,56,24,8,0.html: Added.
974         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.6_Chrome-7.0.503.1-TEST-121240-3_81,3.html: Added.
975         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.7_Chrome-7.0.513.0-4800-5_80,65,15.html: Added.
976         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.7_Chrome-7.0.513.0-TEST-23583190347-3_15,12.html: Added.
977         * iExploder/iexploder-1.7.2/tools: Added.
978         * iExploder/iexploder-1.7.2/tools/lasthit.rb: Added.
979         * iExploder/iexploder-1.7.2/tools/osx_last_crash.rb: Added.
980         * iExploder/iexploder-1.7.2/tools/release_src.sh: Added.
981         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh: Added.
982         * iExploder/tools: Removed.
983
984 2010-12-13  Sam Weinig  <sam@webkit.org>
985
986         Reviewed by Anders Carlsson.
987
988         Remove associated page concept from WKView constructor
989         https://bugs.webkit.org/show_bug.cgi?id=50983
990
991         Step 1: Remove associate page constructors from WKView and make
992         all views use the shared namespace for the context.
993
994         * TestWebKitAPI/PlatformWebView.h:
995         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
996         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
997         * WebKitTestRunner/PlatformWebView.h:
998         * WebKitTestRunner/TestController.cpp:
999         (WTR::createOtherPage):
1000         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1001         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1002         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
1003
1004 2010-12-13  Sam Weinig  <sam@webkit.org>
1005
1006         Reviewed by Anders Carlsson.
1007
1008         Change the WebKit2 public API so there is no explicit WKPageNamespace object
1009         https://bugs.webkit.org/show_bug.cgi?id=50898
1010
1011         * MiniBrowser/mac/AppDelegate.h:
1012         * MiniBrowser/mac/AppDelegate.m:
1013         * MiniBrowser/mac/BrowserWindowController.h:
1014         * MiniBrowser/mac/BrowserWindowController.m:
1015         * MiniBrowser/win/BrowserView.cpp:
1016         Convert MiniBrowser to not use PageNamespaces.
1017
1018         * TestWebKitAPI/PlatformWebView.h:
1019         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
1020         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
1021         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
1022         * TestWebKitAPI/Tests/WebKit2/Find.cpp:
1023         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
1024         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
1025         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
1026         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
1027         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
1028         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
1029         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
1030         * TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp:
1031         * TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp:
1032         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
1033         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
1034         Convert TestWebKitAPI to not use PageNamespaces.
1035
1036         * WebKitTestRunner/PlatformWebView.h:
1037         * WebKitTestRunner/TestController.cpp:
1038         * WebKitTestRunner/TestController.h:
1039         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1040         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1041         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
1042         Convert WebKitTestRunner to not use PageNamespaces.
1043
1044 2010-12-13  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
1045
1046         Reviewed by Eric Seidel.
1047
1048         webkit-patch rollout should be able to do multi-revision rollouts
1049         https://bugs.webkit.org/show_bug.cgi?id=33336
1050
1051         Make it possible to pass more than one revision to webkit-patch.
1052
1053         * Scripts/webkitpy/common/checkout/api.py:
1054         * Scripts/webkitpy/common/checkout/changelog.py:
1055         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1056         * Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:
1057         * Scripts/webkitpy/tool/commands/download.py:
1058         * Scripts/webkitpy/tool/commands/download_unittest.py:
1059         * Scripts/webkitpy/tool/mocktool.py:
1060         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
1061         * Scripts/webkitpy/tool/steps/revertrevision.py:
1062
1063 2010-12-13  Eric Seidel  <eric@webkit.org>
1064
1065         Unreviewed.
1066
1067         Teach webkit-patch how to search bugzilla
1068         https://bugs.webkit.org/show_bug.cgi?id=50500
1069
1070         webkit-patch bug-search fails when there is only one result.
1071         Turns out we needed a bit more logic in our result count parsing code.
1072
1073         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1074         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
1075
1076 2010-12-13  Antti Koivisto  <antti@apple.com>
1077
1078         Reviewed by Alexey Proskuryakov.
1079
1080         Add setSerializeHTTPLoads function to allow testing resource load order on OS X.
1081         https://bugs.webkit.org/show_bug.cgi?id=50758
1082
1083         * DumpRenderTree/LayoutTestController.cpp:
1084         (setSerializeHTTPLoadsCallback):
1085         (LayoutTestController::staticFunctions):
1086         * DumpRenderTree/LayoutTestController.h:
1087         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1088         (LayoutTestController::setSerializeHTTPLoads):
1089         * DumpRenderTree/mac/DumpRenderTree.mm:
1090         (resetDefaultsToConsistentValues):
1091         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1092         (LayoutTestController::setSerializeHTTPLoads):
1093         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1094         (LayoutTestController::setSerializeHTTPLoads):
1095
1096 2010-12-13  Dimitri Glazkov  <dglazkov@chromium.org>
1097
1098         Reviewed by Ojan Vafai.
1099
1100         Remove "use-drt" option from test step command line, since the option was removed in r73748.
1101         https://bugs.webkit.org/show_bug.cgi?id=50936
1102
1103         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Removed the option.
1104
1105 2010-12-13  Patrick Gansterer  <paroga@webkit.org>
1106
1107         Reviewed by Csaba Osztrogonác.
1108
1109         Add revlink to BuildBot status
1110         https://bugs.webkit.org/show_bug.cgi?id=50914
1111
1112         This adds a hyperlink to trac changeset on the revision numbers. 
1113
1114         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1115
1116 2010-12-13  Andras Becsi  <abecsi@webkit.org>
1117
1118         Reviewed by Csaba Osztrogonác.
1119
1120         [Qt][WK2] Fix build if WebKitTools are not available
1121         https://bugs.webkit.org/show_bug.cgi?id=50242
1122
1123         * MiniBrowser/qt/MiniBrowser.pro: Correct the comment.
1124         * Scripts/webkitdirs.pm: Added WebKitTools/MiniBrowser to $subdirs.
1125         * MiniBrowser/DerivedSources.pro: Added.
1126
1127 2010-12-13  Eric Seidel  <eric@webkit.org>
1128
1129         Reviewed by Adam Barth.
1130
1131         EWS Queues should remove orpahned pyc files before starting
1132         https://bugs.webkit.org/show_bug.cgi?id=50904
1133
1134         A previous check added a platform.py which caused
1135         EWS bots on some platforms to hit an import exception.
1136         The platform.py file was removed in a subsequent commit, but
1137         the EWS bots in question stayed stuck.  This change will
1138         fix those bots once restarted (and prevent this in the future).
1139
1140         I also went ahead and unified start-queue and start-commit-queue
1141         since they were nearly identical.  I also added bot_id support
1142         to both force all EWSes to have bot ids as well as get rid of the one
1143         remaining reason why I had my own copies of these scripts.
1144         Hopefully this will be enough to get all the other bot admins
1145         (ahem, Adam, ahem) to move to using these checked in copies as well.
1146
1147         * EWSTools/start-commit-queue.sh: Removed.
1148         * EWSTools/start-queue.sh:
1149
1150 2010-10-28  MORITA Hajime  <morrita@google.com>
1151
1152         Reviewed by Ojan Vafai.
1153
1154         spellcheck does not check pasted text
1155         https://bugs.webkit.org/show_bug.cgi?id=40092
1156
1157         Added LayoutTestController::setAsynchronousSpellCheckingEnabled()
1158         to control the setting.
1159
1160         * DumpRenderTree/LayoutTestController.cpp:
1161         (setAsynchronousSpellCheckingEnabledCallback):
1162         (LayoutTestController::staticFunctions):
1163         * DumpRenderTree/LayoutTestController.h:
1164         * DumpRenderTree/chromium/LayoutTestController.h:
1165         * DumpRenderTree/chromium/LayoutTestController.cpp:
1166         (LayoutTestController::LayoutTestController):
1167         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
1168         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1169         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
1170         * DumpRenderTree/mac/DumpRenderTree.mm:
1171         (resetDefaultsToConsistentValues):
1172         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1173         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
1174         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1175         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1176         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
1177         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1178         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
1179         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1180         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
1181
1182 2010-12-12  Sam Weinig  <sam@webkit.org>
1183
1184         Reviewed by Anders Carlsson.
1185
1186         Fix failing API test. It turns out that a pop-state event
1187         is sent before every fragment navigation, so we have to test
1188         for it in addition in PageLoadDidChangeLocationWithinPageForFrame.
1189
1190         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
1191         (TestWebKitAPI::didSameDocumentNavigationForFrame):
1192
1193 2010-12-12  Alejandro G. Castro  <alex@igalia.com>
1194
1195         Reviewed by Eric Seidel.
1196
1197         [GTK] Add new-run-webkit-tests support to gtk
1198         https://bugs.webkit.org/show_bug.cgi?id=50681
1199
1200         Adding the basic support to run the new-run-webkit-tests.
1201
1202         * Scripts/webkitpy/layout_tests/port/gtk.py:
1203
1204 2010-10-11  Diego Gonzalez  <diegohcg@webkit.org>
1205
1206         Reviewed by Kenneth Rohde Christiansen.
1207
1208         [Qt] Mock DeviceOrientation client for DRT
1209         https://bugs.webkit.org/show_bug.cgi?id=47490
1210
1211         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1212         (WebCore::DumpRenderTree::DumpRenderTree):
1213         (WebCore::DumpRenderTree::~DumpRenderTree):
1214         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1215         (LayoutTestController::setMockDeviceOrientation):
1216
1217 2010-12-11  Philippe Normand  <pnormand@igalia.com>
1218
1219         Reviewed by Gustavo Noronha Silva.
1220
1221         [GTK] launcher: disable the Mozilla-style fullscreen API
1222         https://bugs.webkit.org/show_bug.cgi?id=50874
1223
1224         Disabling the fullscreen API until its implementation for GTK is
1225         mature enough. The webview setting for it is already FALSE by
1226         default.
1227
1228         * GtkLauncher/main.c:
1229         (createWindow):
1230
1231 2010-12-10  Eric Seidel  <eric@webkit.org>
1232
1233         Reviewed by Adam Barth.
1234
1235         commit-queue flaky test messages show cryptic version information for mac os x
1236         https://bugs.webkit.org/show_bug.cgi?id=50864
1237
1238         Turns out platform.platform() returns kernel version information
1239         which isn't helpful, and just plain confusing on Mac
1240         (OS X 10.6.5 uses Darwin Kernel 10.5.0).
1241
1242         So I've updated PlatformInfo.display_name() to special case
1243         mac.  I also found a bad use of sys.platform in the process
1244         and fixed that.  (sys.platform always returns 'darwin' on mac).
1245
1246         * Scripts/webkitpy/common/system/platforminfo.py:
1247         * Scripts/webkitpy/common/system/user.py:
1248         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1249         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1250         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1251
1252 2010-12-10  Eric Seidel  <eric@webkit.org>
1253
1254         Unreviewed.
1255
1256         Exception seen while reporting flaky test with commit-queue.
1257         Just a missing include.
1258
1259         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1260         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1261
1262 2010-12-10  Kinuko Yasuda  <kinuko@chromium.org>
1263
1264         Reviewed by Eric Seidel.
1265
1266         [Chromium] Remove old JSONResultsGenerator script that existed for backward-compatibility
1267         https://bugs.webkit.org/show_bug.cgi?id=50796
1268
1269         Also updating the test code to use JSONResultsGeneratorBase and
1270         to improve test coverage for incremental cases.
1271
1272         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1273         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
1274
1275 2010-12-10  Joseph Pecoraro  <joepeck@webkit.org>
1276
1277         Reviewed by Darin Adler.
1278
1279         prepare-ChangeLog --help doesn't mention --bug shorthand -b
1280         https://bugs.webkit.org/show_bug.cgi?id=50835
1281
1282         * Scripts/prepare-ChangeLog: be more explicit about -b and match file style.
1283
1284 2010-12-10  Eric Seidel  <eric@webkit.org>
1285
1286         Reviewed by Adam Barth.
1287
1288         Bugs created by the commit-queue should all block on a master bug
1289         https://bugs.webkit.org/show_bug.cgi?id=50857
1290
1291         This makes all bugs created by the commit-queue block on:
1292         https://bugs.webkit.org/show_bug.cgi?id=50856
1293
1294         In the process of testing this, I found that the existing
1295         create_bug code was wrong.  I also found that existing
1296         unit tests for create-rollout used invalid values
1297         for options.blocks.  I fixed both issues and tested.
1298
1299         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1300         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1301         * Scripts/webkitpy/tool/commands/commandtest.py:
1302         * Scripts/webkitpy/tool/commands/download_unittest.py:
1303         * Scripts/webkitpy/tool/commands/upload_unittest.py:
1304         * Scripts/webkitpy/tool/mocktool.py:
1305         * Scripts/webkitpy/tool/steps/options.py:
1306
1307 2010-12-10  Eric Seidel  <eric@webkit.org>
1308
1309         Reviewed by Adam Barth.
1310
1311         Teach webkitpy how to follow duplicate chains when posting comments on flake bugs
1312         https://bugs.webkit.org/show_bug.cgi?id=50853
1313
1314         I also discovered when doing this that the code was posting
1315         the comment on the wrong bug, but that's fixed here too.
1316
1317         * Scripts/webkitpy/common/net/bugzilla/bug.py:
1318         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1319         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1320         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1321         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1322         * Scripts/webkitpy/tool/mocktool.py:
1323
1324 2010-12-10  Anders Carlsson  <andersca@apple.com>
1325
1326         Reviewed by John Sullivan.
1327
1328         Make WKContextGetStatistics gather global statistics
1329         https://bugs.webkit.org/show_bug.cgi?id=50850
1330
1331         Remove the code that gets the statistics and fills in the per context
1332         statistics information for now.
1333
1334         * MiniBrowser/mac/BrowserStatisticsWindowController.m:
1335         (-[BrowserStatisticsWindowController refreshStatistics:]):
1336
1337 2010-12-10  Eric Seidel  <eric@webkit.org>
1338
1339         Unreviewed.
1340
1341         commit-queue should report port/platform information when commenting on flaky test bugs
1342         https://bugs.webkit.org/show_bug.cgi?id=50839
1343
1344         Renamed platform.py to platforminfo.py.  This broke import platform in executive.py
1345         which was only used by new run webkit tests (and clearly not unit tested).
1346
1347         * Scripts/webkitpy/common/system/platforminfo.py: Renamed from WebKitTools/Scripts/webkitpy/common/system/platform.py.
1348         * Scripts/webkitpy/tool/main.py:
1349         * Scripts/webkitpy/tool/mocktool.py:
1350
1351 2010-12-10  Eric Seidel  <eric@webkit.org>
1352
1353         Reviewed by Tony Chang.
1354
1355         commit-queue should report port/platform information when commenting on flaky test bugs
1356         https://bugs.webkit.org/show_bug.cgi?id=50839
1357
1358         This was a suggestion from Tony Chang this morning.
1359         I added a platform.py class so I could easily mock the platform call,
1360         but that may not be the final solution for this mocking.
1361         We'll try it and see.
1362
1363         * Scripts/webkitpy/common/system/platform.py: Added.
1364         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1365         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1366         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1367         * Scripts/webkitpy/tool/main.py:
1368         * Scripts/webkitpy/tool/mocktool.py:
1369
1370 2010-12-10  Krithigassree Sambamurthy  <krithigassree.sambamurthy@nokia.com>
1371
1372         Reviewed by Joseph Pecoraro.
1373
1374         Bug 43455 - [Qt]: Implement Application Cache Quotas
1375         https://bugs.webkit.org/show_bug.cgi?id=43455
1376
1377         Introduce functions to allow new appcache layout test origin-quota.html
1378         to work correctly under Qt.
1379
1380         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1381         (WebCore::DumpRenderTree::DumpRenderTree):
1382         (WebCore::DumpRenderTree::dumpApplicationCacheQuota):
1383         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1384
1385         Introduce functions to allow new appcache layout test origin-quota.html
1386         to be successful under qt. Changes required because LayoutTestControllerQt
1387         does not inherit from LayoutController.
1388
1389         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1390         (LayoutTestController::reset):
1391         (LayoutTestController::clearAllApplicationCaches):
1392         (LayoutTestController::setApplicationCacheOriginQuota):
1393         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1394         (LayoutTestController::shouldDumpApplicationCacheDelegateCallbacks):
1395         (LayoutTestController::dumpApplicationCacheDelegateCallbacks):
1396
1397 2010-12-10  Eric Seidel  <eric@webkit.org>
1398
1399         Reviewed by Adam Barth.
1400
1401         Move buildbot.py into its own module so we can split it out into one-file-per-class
1402         https://bugs.webkit.org/show_bug.cgi?id=50806
1403
1404         We're adding more buildbot logic these days, so it makes sense
1405         to give buildbot its own module.
1406
1407         * Scripts/webkitpy/common/net/buildbot/__init__.py: Added.
1408         * Scripts/webkitpy/common/net/buildbot/buildbot.py: Renamed from WebKitTools/Scripts/webkitpy/common/net/buildbot.py.
1409         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py: Renamed from WebKitTools/Scripts/webkitpy/common/net/buildbot_unittest.py.
1410         * Scripts/webkitpy/common/net/failuremap.py:
1411         * Scripts/webkitpy/common/net/regressionwindow.py:
1412         * Scripts/webkitpy/tool/commands/rebaseline.py:
1413
1414 2010-12-10  Tony Chang  <tony@chromium.org>
1415
1416         Reviewed by Eric Seidel.
1417
1418         Use FileSystem::remove when cleaning up http lock files
1419         https://bugs.webkit.org/show_bug.cgi?id=50830
1420
1421         * Scripts/webkitpy/layout_tests/port/http_lock.py:
1422
1423 2010-12-10  Joone Hur  <joone@kldp.org>
1424
1425         Reviewed by Martin Robinson.
1426
1427         [GTK] DRT needs layoutTestController.setCacheModel
1428         https://bugs.webkit.org/show_bug.cgi?id=50705
1429         
1430         webkit_set_cache_mode() is called to set the cache model.
1431         
1432         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1433         (LayoutTestController::setCacheModel): Set the cache model. 
1434
1435 2010-12-10  Tony Chang  <tony@chromium.org>
1436
1437         Reviewed by Ojan Vafai.
1438
1439         [chromium] remove --use-drt and add --use-test-shell
1440         https://bugs.webkit.org/show_bug.cgi?id=50701
1441
1442         * Scripts/webkitpy/common/config/ports.py:
1443         * Scripts/webkitpy/common/config/ports_unittest.py:
1444         * Scripts/webkitpy/layout_tests/port/chromium.py:
1445         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1446         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1447         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1448         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1449         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1450         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1451         * Scripts/webkitpy/layout_tests/port/webkit.py:
1452         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1453         * Scripts/webkitpy/style/checkers/test_expectations.py:
1454         * Scripts/webkitpy/tool/commands/queries.py:
1455
1456 2010-12-10  John Knottenbelt  <jknotten@chromium.org>
1457
1458         Reviewed by Steve Block.
1459
1460         [Chromium] Implement mocks for client-based geolocation
1461         https://bugs.webkit.org/show_bug.cgi?id=46895
1462
1463         * DumpRenderTree/chromium/LayoutTestController.cpp:
1464         (LayoutTestController::setGeolocationPermission):
1465         (LayoutTestController::setMockGeolocationPosition):
1466         (LayoutTestController::setMockGeolocationError):
1467         * DumpRenderTree/chromium/LayoutTestController.h:
1468         * DumpRenderTree/chromium/WebViewHost.cpp:
1469         (WebViewHost::geolocationClient):
1470         (WebViewHost::geolocationClientMock):
1471         (WebViewHost::reset):
1472         * DumpRenderTree/chromium/WebViewHost.h:
1473
1474 2010-12-10  Alejandro G. Castro  <alex@igalia.com>
1475
1476         Reviewed by Martin Robinson.
1477
1478         [GTK] Add hasSpellingMarker support to the DRT
1479         https://bugs.webkit.org/show_bug.cgi?id=50739
1480
1481         Implemented the hasSpellingMarker to support spelling tests.
1482
1483         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1484         (LayoutTestController::hasSpellingMarker):
1485
1486 2010-12-10  Eric Seidel  <eric@webkit.org>
1487
1488         Reviewed by Ojan Vafai.
1489
1490         webkit-patch: not possible to use build-and-test with local commits
1491         https://bugs.webkit.org/show_bug.cgi?id=33378
1492
1493         Make --no-clean not even check if we have local commits.
1494         It's unclear to me why the code was originally written this way.
1495         I was unable to dig up a reason from svn history.
1496
1497         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
1498         * Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py: Copied from WebKitTools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.
1499
1500 2010-12-10  Mario Sanchez Prada  <msanchez@igalia.com>
1501
1502         Reviewed by Martin Robinson.
1503
1504         [GTK] AX: implement isEnabled in DRT
1505         https://bugs.webkit.org/show_bug.cgi?id=50814
1506
1507         Implement AccessibilityUIElement::isEnabled() for GTK.
1508
1509         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1510         (checkElementState): New function to refactor common code.
1511         (AccessibilityUIElement::isEnabled): Implement this by checking
1512         the current state of the AtkObject.
1513         (AccessibilityUIElement::isSelected): Use the new
1514         checkElementState function.
1515
1516 2010-12-10  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
1517
1518         Reviewed by Kenneth Rohde Christiansen.
1519
1520         [Qt][WK2] Add the QWKContext API class to wrap the WebContext.
1521         https://bugs.webkit.org/show_bug.cgi?id=50750
1522
1523         * MiniBrowser/qt/BrowserView.cpp:
1524         (BrowserView::BrowserView):
1525         * MiniBrowser/qt/BrowserView.h:
1526         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1527         (WTR::WebView::WebView):
1528
1529 2010-12-10  Joone Hur  <joone@kldp.org>
1530
1531         Reviewed by Xan Lopez.
1532
1533         [GTK] Unskipping some test cases in userscripts dependent on addUserStyleSheet
1534         https://bugs.webkit.org/show_bug.cgi?id=50808
1535
1536         Unskipping the following test cases:
1537         userscripts/mixed-case-stylesheet.html
1538         userscripts/simple-stylesheet.html
1539         userscripts/user-style-all-frames.html
1540
1541         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1542         (LayoutTestController::addUserStyleSheet):
1543
1544 2010-12-10  Joone Hur  <joone@kldp.org>
1545
1546         Reviewed by Eric Seidel.
1547
1548         [GTK] Add DRT support for pageProperty, isPageBoxVisible, pageSizeAndMarginsInPixels, and addUserStyleSheet
1549         https://bugs.webkit.org/show_bug.cgi?id=50783
1550
1551         This patch allows to unskip the following test cases:
1552         printing/page-rule-selection.html
1553         printing/page-format-data.html
1554
1555         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1556         (LayoutTestController::pageProperty): Added.
1557         (LayoutTestController::isPageBoxVisible): Ditto.
1558         (LayoutTestController::pageSizeAndMarginsInPixels): Ditto.
1559         (LayoutTestController::addUserStyleSheet): Ditto.
1560
1561 2010-12-10  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
1562
1563         Reviewed by Kenneth Rohde Christiansen.
1564
1565         [Qt] Make QtTestBrowser spawn QNAM in a secondary thread.
1566
1567         A menu allows to switch QNAM back to the same thread.
1568
1569         * QtTestBrowser/launcherwindow.cpp:
1570         (LauncherWindow::initializeView):
1571         (LauncherWindow::createChrome):
1572         (LauncherWindow::toggleThreadedQnam):
1573         * QtTestBrowser/launcherwindow.h:
1574         (WindowOptions::WindowOptions):
1575         * QtTestBrowser/webpage.cpp:
1576         (WebPage::WebPage):
1577         (WebPage::setQnamThreaded):
1578         * QtTestBrowser/webpage.h:
1579         (QnamThread::QnamThread):
1580         (QnamThread::~QnamThread):
1581         (QnamThread::networkAccessManager):
1582         (QnamThread::run):
1583
1584 2010-12-10  Martin Robinson  <mrobinson@igalia.com>
1585
1586         Reviewed by Xan Lopez.
1587
1588         [Gtk] style="font-family: courier" makes text disappear
1589         https://bugs.webkit.org/show_bug.cgi?id=47452
1590
1591         Add a test that verifies that fonts without valid charmaps are
1592         never selected.
1593
1594         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1595         (initializeFonts): Initialize DRT with our font (derived from Ahem)
1596         that has no valid charmap.
1597         * DumpRenderTree/gtk/fonts/FontWithNoValidEncoding.fon: Added.
1598         * DumpRenderTree/gtk/fonts/fonts.conf: Updated settings to override users'
1599         settings which may disable selection of bitmap fonts.
1600
1601 2010-12-10  Eric Seidel  <eric@webkit.org>
1602
1603         Unreviewed.
1604
1605         The commit-queue should file bugs about flaky tests it encounters
1606         https://bugs.webkit.org/show_bug.cgi?id=50803
1607
1608         create_bug_for_flaky_test was insufficiently tested, thus buggy.
1609         Now it's tested.
1610
1611         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1612         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1613
1614 2010-12-10  Eric Seidel  <eric@webkit.org>
1615
1616         Unreviewed.  Somehow this last-minute edit didn't quite get committed.
1617
1618         The commit-queue should file bugs about flaky tests it encounters
1619         https://bugs.webkit.org/show_bug.cgi?id=50803
1620
1621         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1622
1623 2010-12-09  Eric Seidel  <eric@webkit.org>
1624
1625         Reviewed by Adam Barth.
1626
1627         The commit-queue should file bugs about flaky tests it encounters
1628         https://bugs.webkit.org/show_bug.cgi?id=50803
1629
1630         This change got a bit big.  I also added a new config.urls file
1631         because I needed to share the view_source_url code with committervalidator.py.
1632
1633         This adds a new class FlakyTestReporter which holds all the logic about
1634         reporting flaky tests to bugzilla.
1635
1636         Right now this code knows how to look up bugs for flaky tests.
1637         If it can't find a bug filed from the commit-queue, it will open a new
1638         one, ccing the relevant people and adding information about the failure.
1639
1640         It is not yet smart enough to chase down duplicate chains, or to include
1641         the actual failure diff.  But those can be added in later iterations.
1642
1643         * Scripts/webkitpy/common/checkout/api.py:
1644         * Scripts/webkitpy/common/checkout/changelog.py:
1645         * Scripts/webkitpy/common/checkout/commitinfo.py:
1646         * Scripts/webkitpy/common/config/committervalidator.py:
1647         * Scripts/webkitpy/common/config/urls.py: Copied from WebKitTools/Scripts/webkitpy/tool/comments.py.
1648         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1649         * Scripts/webkitpy/tool/bot/flakytestreporter.py: Added.
1650         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py: Copied from WebKitTools/Scripts/webkitpy/tool/comments.py.
1651         * Scripts/webkitpy/tool/bot/irc_command.py:
1652         * Scripts/webkitpy/tool/bot/sheriff.py:
1653         * Scripts/webkitpy/tool/commands/download.py:
1654         * Scripts/webkitpy/tool/commands/queues.py:
1655         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1656         * Scripts/webkitpy/tool/comments.py:
1657         * Scripts/webkitpy/tool/mocktool.py:
1658         * Scripts/webkitpy/tool/steps/commit.py:
1659
1660 2010-12-09  Eric Seidel  <eric@webkit.org>
1661
1662         Reviewed by Adam Barth.
1663
1664         Teach webkit-patch how to search bugzilla
1665         https://bugs.webkit.org/show_bug.cgi?id=50500
1666
1667         This is a step towards teaching webkitpy how to file
1668         new bugs for flaky tests and update them when new flakes occur.
1669
1670         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1671         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
1672         * Scripts/webkitpy/tool/commands/__init__.py:
1673         * Scripts/webkitpy/tool/commands/bugsearch.py: Added.
1674
1675 2010-12-09  Adam Barth  <abarth@webkit.org>
1676
1677         Reviewed by Ojan Vafai.
1678
1679         commit-queue errors out due to local commits
1680         https://bugs.webkit.org/show_bug.cgi?id=50766
1681
1682         We seem to be tripping over having local commits in the working copy a
1683         lot recently.  I don't quite fully understand what the issue is, but
1684         this patch attempts to solve the problem by adding an explicit clean
1685         step before processing a patch.  Previously, we did the cleaning as
1686         part of the apply-attachment step, so this might not actually fix the
1687         problem.
1688
1689         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1690         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1691         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1692
1693 2010-12-09  Dirk Pranke  <dpranke@chromium.org>
1694
1695         Reviewed by Ojan Vafai.
1696
1697         Make new-run-webkit-tests --lint-test-files log slightly better
1698         messages and return -1 if lint fails. Remove the
1699         'suppress_errors' keyword param to the TestExpectationsFile
1700         class, and clean up logging and exception raising for error
1701         handling. Also add more unit tests and clean up the unit test code a bit.
1702
1703         https://bugs.webkit.org/show_bug.cgi?id=50205
1704
1705         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1706         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1707         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py
1708         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py
1709         * Scripts/webkitpy/layout_tests/port/chromium.py:
1710         * Scripts/webkitpy/style/checkers/test_expectations.py:
1711         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1712
1713 2010-12-09  Tony Chang  <tony@chromium.org>
1714
1715         Unreviewed, fix for windows code.  We were catching the wrong
1716         exception in Windows.
1717
1718         * Scripts/webkitpy/common/system/filesystem.py:
1719
1720 2010-12-09  Antonio Gomes  <agomes@rim.com>
1721
1722         Reviewed by Martin Robinson.
1723
1724         [Gtk] Populate DumpRenderTreeSupportGtk (part IV)
1725         https://bugs.webkit.org/show_bug.cgi?id=48429
1726
1727         Adjust call sites of webkit_thread_count to use the DumpRenderTreeSupportGtk version now.
1728
1729         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1730         (LayoutTestController::workerThreadCount):
1731
1732 2010-12-06  Philippe Normand  <pnormand@igalia.com>
1733
1734         Reviewed by Martin Robinson.
1735
1736         [GTK] Support the Mozilla-style Fullscreen Javascript API
1737         https://bugs.webkit.org/show_bug.cgi?id=50572
1738
1739         Enable the Javascript Fullscreen support in the GtkLauncher. Also
1740         make DRT update the Chrome when the WebView settings have been
1741         reset to consistent values.
1742
1743         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1744         (resetDefaultsToConsistentValues):
1745         * GtkLauncher/main.c:
1746         (create_window):
1747         * Scripts/build-webkit:
1748
1749 2010-12-09  Koan-Sin Tan  <koansin.tan@gmail.com>
1750
1751         Reviewed by Tor Arne Vestbø
1752
1753         [Qt] run-launcher doesn't start the browser on Mac OS X 10.6
1754         https://bugs.webkit.org/show_bug.cgi?id=50742
1755
1756         check not only QtWebKit.framework/QtWebKit but also libQtWebKit.dylib
1757
1758         * Scripts/webkitdirs.pm:
1759
1760 2010-12-09  Joone Hur  <joone@kldp.org>
1761
1762          Reviewed by Martin Robinson.
1763
1764          [GTK] Support for viewport meta tag
1765          https://bugs.webkit.org/show_bug.cgi?id=45443
1766
1767          Add support for testing the viewport properties for WebKitGtk.
1768
1769          * DumpRenderTree/LayoutTestController.cpp:
1770          (dumpConfigurationForViewportCallback): Added this JS callback to set the size of the visible viewport.
1771          (LayoutTestController::staticFunctions):
1772          * DumpRenderTree/LayoutTestController.h:
1773          * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1774          (LayoutTestController::dumpConfigurationForViewport): Added this function to test the viewport properties.
1775          * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1776          (LayoutTestController::dumpConfigurationForViewport): Ditto.
1777          * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1778          (LayoutTestController::dumpConfigurationForViewport): Ditto.
1779          * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1780          (LayoutTestController::dumpConfigurationForViewport): Ditto.
1781          * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1782          (LayoutTestController::dumpConfigurationForViewport): Ditto.
1783
1784 2010-12-08  William Siegrist <wsiegrist@apple.com>
1785
1786         Reviewed by Eric Seidel.
1787
1788         Migrate buildbot.py from xmlrpc to json.
1789         https://bugs.webkit.org/show_bug.cgi?id=50647
1790
1791         * Scripts/webkitpy/common/net/buildbot.py:
1792
1793 2010-12-08  Tony Chang  <tony@chromium.org>
1794
1795         Reviewed by Eric Seidel.
1796
1797         make starting the websocket server more reliable on windows
1798         https://bugs.webkit.org/show_bug.cgi?id=50712
1799
1800         * Scripts/webkitpy/common/system/filesystem.py:
1801         (remove): Substitute method for os.remove to retry on error on Windows
1802         * Scripts/webkitpy/common/system/filesystem_unittest.py:
1803         * Scripts/webkitpy/layout_tests/port/http_server_base.py: Use FileSystem.remove
1804
1805 2010-12-08  Jessie Berlin  <jberlin@apple.com>
1806
1807         Reviewed by Adam Roben.
1808
1809         WebKit2: Implement WebChromeClient::exceededDatabaseQuota
1810         https://bugs.webkit.org/show_bug.cgi?id=50656
1811
1812         * MiniBrowser/mac/BrowserWindowController.m:
1813         (-[BrowserWindowController awakeFromNib]):
1814         Indicate that exceededDatabaseQuota is not implemented.
1815         * MiniBrowser/win/BrowserView.cpp:
1816         (BrowserView::create):
1817         Ditto.
1818         * WebKitTestRunner/TestController.cpp:
1819         (WTR::createOtherPage):
1820         Ditto.
1821         (WTR::TestController::initialize):
1822         Ditto.
1823
1824 2010-12-08  Antonio Gomes  <agomes@rim.com>
1825
1826         Reviewed by Martin Robinson.
1827
1828         [Gtk] Populate DumpRenderTreeSupportGtk (part III)
1829         https://bugs.webkit.org/show_bug.cgi?id=48429
1830
1831         Moved the following methods from webkitprivate.h to DumpRenderTreeSupportGtk.cpp|h:
1832         * webkit_gc_collect_javascript_objects;
1833         * webkit_gc_collect_javascript_objects_on_alternate_thread;
1834         * webkit_gc_count_javascript_objects;
1835         * webkit_web_frame_layout.
1836
1837         These were all only used by GTK+ DRT.
1838
1839         * DumpRenderTree/gtk/EventSender.cpp:
1840         (dispatchEvent):
1841         * DumpRenderTree/gtk/GCControllerGtk.cpp:
1842         (GCController::collect):
1843         (GCController::collectOnAlternateThread):
1844         (GCController::getJSObjectCount):
1845
1846 2010-12-07  Tony Chang  <tony@chromium.org>
1847
1848         Reviewed by Ojan Vafai.
1849
1850         [chromium] force NRWT to use DRT
1851         https://bugs.webkit.org/show_bug.cgi?id=50359
1852
1853         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1854
1855 2010-12-06  Sam Weinig  <sam@webkit.org>
1856
1857         Reviewed by Anders Carlsson.
1858
1859         Generalize didChangeLocationWithinPageForFrame for all same document navigations
1860         https://bugs.webkit.org/show_bug.cgi?id=50584
1861
1862         * MiniBrowser/mac/BrowserWindowController.m:
1863         (didSameDocumentNavigationForFrame):
1864         (-[BrowserWindowController awakeFromNib]):
1865         (-[BrowserWindowController didSameDocumentNavigationForFrame:]):
1866         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
1867         (TestWebKitAPI::didSameDocumentNavigationForFrame):
1868         (TestWebKitAPI::TEST):
1869         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1870         (WTR::InjectedBundlePage::InjectedBundlePage):
1871         (WTR::InjectedBundlePage::didSameDocumentNavigationForFrame):
1872         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1873         * WebKitTestRunner/TestController.cpp:
1874         (WTR::TestController::initialize):
1875
1876 2010-12-06  Kinuko Yasuda  <kinuko@chromium.org>
1877
1878         Reviewed by Ojan Vafai.
1879
1880         Make TestResultsServer return 404 for non-existing results files.
1881         https://bugs.webkit.org/show_bug.cgi?id=50581
1882
1883         * TestResultServer/handlers/testfilehandler.py:
1884
1885 2010-12-06  Tony Chang  <tony@chromium.org>
1886
1887         Reviewed by Ojan Vafai.
1888
1889         [chromium] fix an assert hit in DRT
1890         https://bugs.webkit.org/show_bug.cgi?id=50575
1891
1892         This class uses WTF's RefPtr, but expects chrome's base::RefPtr
1893         semantics.
1894
1895         Otherwise, we hit ASSERTION FAILED: !m_adoptionIsRequired
1896         (third_party/WebKit/JavaScriptCore/wtf/RefCounted.h:37 void
1897         WTF::RefCountedBase::ref()).
1898
1899         * DumpRenderTree/chromium/TestWebWorker.h:
1900         (TestWebWorker::TestWebWorker):
1901
1902 2010-12-02  Ojan Vafai  <ojan@chromium.org>
1903
1904         Reviewed by Eric Seidel.
1905
1906         make webkit-patch command work when the git branch is not synced to the remote svn branch
1907         https://bugs.webkit.org/show_bug.cgi?id=50424
1908
1909         * Scripts/webkitpy/common/checkout/scm.py:
1910         * Scripts/webkitpy/common/checkout/scm_unittest.py:
1911
1912 2010-12-06  Patrick Gansterer  <paroga@webkit.org>
1913
1914         Reviewed by Andreas Kling.
1915
1916         [WINCE] Add build system
1917         https://bugs.webkit.org/show_bug.cgi?id=50522
1918
1919         * CMakeListsWinCE.txt: Added.
1920
1921 2010-12-03  Mihai Parparita  <mihaip@chromium.org>
1922
1923         Reviewed by Tony Chang.
1924
1925         Allow the Chromium port to have Leopard-specific baselines
1926         https://bugs.webkit.org/show_bug.cgi?id=50506
1927
1928         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1929
1930 2010-12-03  Tony Chang  <tony@chromium.org>
1931
1932         Reviewed by Kent Tamura.
1933
1934         [chromium] fix 2 bugs with inspector tests in DRT
1935         https://bugs.webkit.org/show_bug.cgi?id=50492
1936
1937         Tasks can outlive the tasklist (even when canceled) so this was
1938         causing a crash when ~WebTask() ran.  Avoid this by unregistering
1939         when a task is canceled.
1940
1941         Also fix an assert when closing devtool windows by copying some
1942         logic from test_shell.
1943
1944         * DumpRenderTree/chromium/Task.cpp:
1945         (WebTask::~WebTask):
1946         (TaskList::revokeAll):
1947         * DumpRenderTree/chromium/Task.h: Canceling a task now removes it from
1948             the tasklist (since the task can outlive the tasklist).
1949         * DumpRenderTree/chromium/TestShell.h:
1950         (TestShell::devToolsWebView):
1951         * DumpRenderTree/chromium/WebViewHost.cpp:
1952         (WebViewHost::~WebViewHost): Don't load about:blank when closing
1953             a window if the window has devtools loaded.  This avoids an
1954             ASSERT and matches test_shell.
1955
1956 2010-12-06  Alejandro G. Castro  <alex@igalia.com>
1957
1958         Reviewed by Martin Robinson.
1959
1960         [GTK] Fix GtkLauncher.c style, use webkit style
1961         https://bugs.webkit.org/show_bug.cgi?id=50542
1962
1963         * GtkLauncher/main.c:
1964         (activateUriEntryCb):
1965         (updateTitle):
1966         (linkHoverCb):
1967         (notifyTitleCb):
1968         (notifyLoadStatusCb):
1969         (notifyProgressCb):
1970         (destroyCb):
1971         (goBackCb):
1972         (goForwardCb):
1973         (create_webViewCb):
1974         (webViewReadyCb):
1975         (closeWebViewCb):
1976         (createBrowser):
1977         (createStatusbar):
1978         (createToolbar):
1979         (createWindow):
1980         (main):
1981
1982 2010-12-04  Antonio Gomes  <agomes@rim.com>
1983
1984         Reviewed by Martin Robinson.
1985
1986         [Gtk] Populate DumpRenderTreeSupportGtk (Part II)
1987         https://bugs.webkit.org/show_bug.cgi?id=48429
1988
1989         Moved more private method declared with WEBKIT_API to
1990         DumpRenderTreeSupportGtk, since they were only being used by DRT.
1991
1992         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1993         (resetDefaultsToConsistentValues):
1994         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1995         (LayoutTestController::addOriginAccessWhitelistEntry):
1996         (LayoutTestController::execCommand):
1997         (LayoutTestController::isCommandEnabled):
1998
1999 2010-12-04  Antonio Gomes  <agomes@rim.com>
2000
2001         Reviewed by Andreas Kling.
2002
2003         Removed extern webkit_web_view_set_group_name from gtk/DumpRenderTree.cpp
2004
2005         Method was removed by http://trac.webkit.org/changeset/71604
2006
2007         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2008
2009 2010-12-05  Alejandro G. Castro  <alex@igalia.com>
2010
2011         Reviewed by Xan Lopez.
2012
2013         [GTK] Fix compilation warnings reported by clang
2014         https://bugs.webkit.org/show_bug.cgi?id=50252
2015
2016         * GtkLauncher/main.c:
2017         (create_window): The create_statusbar function does not have
2018         parameters.
2019
2020 2010-12-05  Robert Hogan  <robert@webkit.org>
2021
2022         Reviewed by Andreas Kling.
2023
2024         [Qt] Zero-sized font does not yet work
2025
2026         Fix fast/text/font-size-zero.html
2027
2028         Copy other ports by setting minimumFontSize to 0 for DRT runs.
2029
2030         https://bugs.webkit.org/show_bug.cgi?id=49759
2031
2032         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2033         (WebCore::WebPage::WebPage):
2034
2035 2010-12-04  Sam Weinig  <sam@webkit.org>
2036
2037         Reviewed by Jon Honeycutt.
2038
2039         WebKit2: Need client functions to notify app when the url changes due to a fragment navigation
2040         https://bugs.webkit.org/show_bug.cgi?id=50511
2041
2042         Update tools for new didChangeLocationWithinPageForFrame client function (and changed bundle
2043         signature) and added a test for the functionality (PageLoadDidChangeLocationWithinPageForFrame.cpp)
2044
2045         * MiniBrowser/mac/BrowserWindowController.m:
2046         (didChangeLocationWithinPageForFrame):
2047         (-[BrowserWindowController awakeFromNib]):
2048         (-[BrowserWindowController didChangeLocationWithinPageForFrame:]):
2049         * TestWebKitAPI/PlatformUtilities.cpp:
2050         (TestWebKitAPI::Util::toWK):
2051         * TestWebKitAPI/PlatformUtilities.h:
2052         (TestWebKitAPI::Util::adoptWK):
2053         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2054         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp: Added.
2055         (TestWebKitAPI::nullJavaScriptCallback):
2056         (TestWebKitAPI::didFinishLoadForFrame):
2057         (TestWebKitAPI::didChangeLocationWithinPageForFrame):
2058         (TestWebKitAPI::TEST):
2059         * TestWebKitAPI/Tests/WebKit2/file-with-anchor.html: Added.
2060         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2061         * TestWebKitAPI/win/copy-resources.cmd:
2062         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2063         (WTR::InjectedBundlePage::InjectedBundlePage):
2064         (WTR::InjectedBundlePage::didChangeLocationWithinPageForFrame):
2065         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2066         * WebKitTestRunner/TestController.cpp:
2067         (WTR::TestController::initialize):
2068
2069 2010-11-08  Antonio Gomes  <agomes@rim.com>
2070
2071         Reviewed by Martin Robinson.
2072
2073         [Gtk] Populate DumpRenderTreeSupportGtk
2074         https://bugs.webkit.org/show_bug.cgi?id=48429
2075
2076         Made the previous calls to webkit_web_frame* functions defined as private
2077         APIs in webkitprivate.h go through DRTSupportGtk.
2078
2079         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
2080         (AccessibilityController::focusedElement):
2081         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2082         (dumpFramesAsText):
2083         (resetDefaultsToConsistentValues):
2084         (dump):
2085         (webViewDocumentLoadFinished):
2086         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2087         (LayoutTestController::counterValueForElementById):
2088         (LayoutTestController::pageNumberForElementById):
2089         (LayoutTestController::numberOfPages):
2090         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
2091         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
2092         (LayoutTestController::sampleSVGAnimationForElementAtTime):
2093         (LayoutTestController::numberOfActiveAnimations):
2094         (LayoutTestController::suspendAnimations):
2095         (LayoutTestController::resumeAnimations):
2096         (LayoutTestController::markerTextForListItem):
2097
2098 2010-12-03  Mihai Parparita  <mihaip@chromium.org>
2099
2100         Reviewed by Tony Chang.
2101
2102         Rebaseline server: use pretty text diff output
2103         https://bugs.webkit.org/show_bug.cgi?id=50484
2104         
2105         Serve *-pretty-diff.html for text diff output.
2106
2107         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
2108         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
2109         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
2110         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
2111
2112 2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
2113
2114         Unreviewed, rolling out r73302.
2115         http://trac.webkit.org/changeset/73302
2116         https://bugs.webkit.org/show_bug.cgi?id=50499
2117
2118         Causes crashes in debug LayoutTests (Requested by xan_ on
2119         #webkit).
2120
2121         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
2122         (AccessibilityUIElement::AccessibilityUIElement):
2123         (AccessibilityUIElement::parentElementCallback):
2124         * DumpRenderTree/chromium/AccessibilityUIElement.h:
2125         * DumpRenderTree/chromium/CppBoundClass.cpp:
2126         * DumpRenderTree/chromium/CppBoundClass.h:
2127
2128 2010-12-03  Sam Weinig  <sam@webkit.org>
2129
2130         Reviewed by Maciej Stachowiak.
2131
2132         Enable <a ping> for Mac/Windows/WebKit2 builds
2133         <rdar://problem/8504473>
2134         https://bugs.webkit.org/show_bug.cgi?id=50488
2135
2136         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
2137         (TestWebKitAPI::TEST): Test that the default value of
2138         WKPreferencesGetHyperlinkAuditingEnabled is true.
2139
2140 2010-12-03  Chris Guillory  <chris.guillory@google.com>
2141
2142         Reviewed by Chris Fleizach.
2143
2144         Include the FrameView widget of a RenderWidget in the accessibility tree.
2145         https://bugs.webkit.org/show_bug.cgi?id=49106
2146
2147         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
2148         (AccessibilityUIElement::AccessibilityUIElement):
2149         (AccessibilityUIElement::parentElementCallback):
2150         (AccessibilityUIElement::isEqualCallback):
2151         * DumpRenderTree/chromium/AccessibilityUIElement.h:
2152         * DumpRenderTree/chromium/CppBoundClass.cpp:
2153         (CppBoundClass::getFromCppVariant):
2154         * DumpRenderTree/chromium/CppBoundClass.h:
2155
2156 2010-12-03  Mihai Parparita  <mihaip@chromium.org>
2157
2158         Reviewed by Tony Chang.
2159
2160         Rebaseline server: organize tests by state, add dry run mode
2161         https://bugs.webkit.org/show_bug.cgi?id=50473
2162         
2163         Group tests in the menu by state, so that it's easier to see after
2164         processing the queue which failed.
2165         
2166         Add support for the --dry-run flag so that it's easier to test changes
2167         such as this (stubs out filesystem and SCM operations).
2168
2169         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
2170         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js:
2171         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
2172
2173 2010-12-03  Brady Eidson  <beidson@apple.com>
2174
2175         Reviewed by Anders Carlsson.
2176
2177         Groundwork for <rdar://problem/7660733> and https://bugs.webkit.org/show_bug.cgi?id=50191
2178         WebKit2 Authentication Support
2179
2180         Keep these builds working:
2181         * MiniBrowser/mac/BrowserWindowController.m:
2182         (-[BrowserWindowController awakeFromNib]):
2183
2184         * WebKitTestRunner/TestController.cpp:
2185         (WTR::TestController::initialize):
2186
2187 2010-12-02  Mihai Parparita  <mihaip@chromium.org>
2188
2189         Reviewed by Tony Chang.
2190
2191         Rebaseline server: move existing baselines
2192         https://bugs.webkit.org/show_bug.cgi?id=50421
2193         
2194         Implement moving of existing baselines: move all files that are about
2195         to be overwriten by update baselines.
2196         
2197         Also fix a typo in the UI JS.
2198
2199         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js:
2200         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
2201         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py:
2202
2203 2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
2204
2205         Unreviewed, rolling out r73211.
2206         http://trac.webkit.org/changeset/73211
2207         https://bugs.webkit.org/show_bug.cgi?id=50450
2208
2209         Broke Chromium's "Webkit Win (dbg)(2)" bot. (Requested by
2210         yutak on #webkit).
2211
2212         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2213
2214 2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
2215
2216         Unreviewed, rolling out r73222.
2217         http://trac.webkit.org/changeset/73222
2218         https://bugs.webkit.org/show_bug.cgi?id=50449
2219
2220         r73211 seemed to break Chromium's "Webkit Win (dbg)(2)" bot.
2221         (Requested by yutak on #webkit).
2222
2223         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2224         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
2225         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
2226         * Scripts/webkitpy/layout_tests/port/base.py:
2227         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2228         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2229
2230 2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
2231
2232         Unreviewed, rolling out r73228.
2233         http://trac.webkit.org/changeset/73228
2234         https://bugs.webkit.org/show_bug.cgi?id=50448
2235
2236         r73211 seemed to break Chromium's "Webkit Win (dbg)(2)" bot.
2237         (Requested by yutak on #webkit).
2238
2239         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2240         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
2241         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
2242         * Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py:
2243         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
2244
2245 2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
2246
2247         Unreviewed, rolling out r73231.
2248         http://trac.webkit.org/changeset/73231
2249         https://bugs.webkit.org/show_bug.cgi?id=50443
2250
2251         r73211 seemed to broke Chromium's "Webkit Win (dbg)(2)" bot.
2252         (Requested by yutak on #webkit).
2253
2254         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
2255         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
2256         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2257         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2258
2259 2010-12-03  David Levin  <levin@chromium.org>
2260
2261         Reviewed by Shinichiro Hamaji.
2262
2263         check-webkit-style: false positive reported for #if macro
2264         https://bugs.webkit.org/show_bug.cgi?id=48242
2265
2266         * Scripts/webkitpy/style/checkers/cpp.py: Adjusted check to avoid
2267           all preprocessor commands.
2268         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added test.
2269
2270 2010-12-02  Eric Seidel  <eric@webkit.org>
2271
2272         Reviewed by Adam Barth.
2273
2274         Update the EWSTools scripts to use modern-style git repos
2275         https://bugs.webkit.org/show_bug.cgi?id=50402
2276
2277         * EWSTools/create-webkit-git:
2278         * EWSTools/start-commit-queue.sh:
2279         * EWSTools/start-queue.sh:
2280
2281 2010-12-02  Simon Fraser  <simon.fraser@apple.com>
2282
2283         Fix Chromium Linux plugin tests by not logging
2284         unconditionally from the event handling code.
2285
2286         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2287         (handleEventX11):
2288
2289 2010-12-02  Dirk Pranke  <dpranke@chromium.org>
2290
2291         Reviewed by Tony Chang.
2292
2293         nrwt multiprocessing - move logic back into run_webkit_tests
2294
2295         This change moves a bunch of logic that I had put into
2296         message_broker back into run_webkit_tests, in a slightly
2297         different format. WorkerMessageBroker needed to become less aware of
2298         the logic the TestRunner class uses, and more generic.
2299         Eventually the MessageBroker will only do generic messaging and
2300         thread/process-pooling, and (almost) all of the
2301         run-webkit-tests-specific logic will be moved to
2302         run_webkit_tests.py and dump_render_tree_thread.py.
2303         
2304         The biggest changes are that the Broker can now start a single
2305         worker, but the responsibility for starting all of them is pushed
2306         back to the TestRunner (Manager), and the logic for checking if
2307         the threads are done or wedged is moved back to TestRunner. We
2308         also remove WorkerMessageBroker.cleanup (not needed) and
2309         cancel_workers (they have to be cancelled individually).
2310         
2311         The  message_broker is now encapsulated inside
2312         TestRunner._run_tests(); it only needs to exist while actually
2313         running the tests.
2314
2315         Also, delete a bunch of tests in message_broker_unittest that no
2316         longer make much sense.
2317
2318         This patch depends on bug 50372.
2319
2320         https://bugs.webkit.org/show_bug.cgi?id=50374
2321
2322         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2323         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
2324         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
2325         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2326         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2327
2328 2010-12-02  Hayato Ito  <hayato@chromium.org>
2329
2330         Reviewed by Eric Seidel.
2331
2332         Refactor test_types's compare_output() method so that it takes a
2333         TestInput object.
2334
2335         compare_output() will need additional information included in a TestInput
2336         object to support reftests. This change is a pre-requirement of that.
2337
2338         https://bugs.webkit.org/show_bug.cgi?id=50362
2339
2340         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2341         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
2342         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
2343         * Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py:
2344         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
2345
2346 2010-12-02  Simon Fraser  <simon.fraser@apple.com>
2347
2348         Reviewed by Anders Carlsson.
2349
2350         Add the ability to run script on 'new' and 'paint' in the test plugin
2351         https://bugs.webkit.org/show_bug.cgi?id=50425
2352         
2353         Add "onnew" and "onpaintevent" attributes to the test plugin,
2354         so that tests can run JS at these times.
2355
2356         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
2357         (pluginAllocate):
2358         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
2359         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2360         (NPP_New):
2361         (NPP_Destroy):
2362         (handleEventCarbon):
2363         (handleEventCocoa):
2364         (NPP_HandleEvent):
2365
2366 2010-12-02  Sam Weinig  <sam@webkit.org>
2367
2368         Fix Qt build.
2369
2370         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2371         (WTR::PlatformWebView::PlatformWebView):
2372
2373 2010-12-02  Sam Weinig  <sam@webkit.org>
2374
2375         Reviewed by Anders Carlsson.
2376
2377         WebKit2 Preferences should be held off the PageGroup, not the Context
2378         https://bugs.webkit.org/show_bug.cgi?id=50414
2379
2380         Update for API changes.
2381
2382         * WebKitTestRunner/PlatformWebView.h:
2383         * WebKitTestRunner/TestController.cpp:
2384         (WTR::createOtherPage):
2385         (WTR::TestController::initialize):
2386         (WTR::TestController::resetStateToConsistentValues):
2387         * WebKitTestRunner/TestController.h:
2388         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2389         (WTR::PlatformWebView::PlatformWebView):
2390         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2391         (WTR::PlatformWebView::PlatformWebView):
2392
2393 2010-12-02  Dirk Pranke  <dpranke@chromium.org>
2394
2395         Reviewed by Tony Chang.
2396
2397         new-run-webkit-tests: minor cleanup for multiprocessing work
2398
2399         This change:
2400         * moves worker naming into TestShellThread, eliminating a
2401           parameter to the constructor and putting the responsibility in
2402           the correct place.
2403         * eliminates the _WorkerState() class in message_broker, because
2404           it turns out that state really needs to be in run_webkit_tests
2405         * renames the Broker classes to be module-private.
2406         * fixes a bunch of minor commenting and whitespace issues to
2407           make subsequent patches a bit clearer.
2408         * Adds a Port hook for default_worker_model() so that we can
2409           accomodate the potential for different worker models on
2410           different ports.
2411         * merge in the fix from 50420 for the brokenness introduced in
2412           bug 50367.
2413
2414         This patch depends on bug 50367.
2415
2416         https://bugs.webkit.org/show_bug.cgi?id=50372
2417
2418         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2419         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
2420         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
2421         * Scripts/webkitpy/layout_tests/port/base.py:
2422         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2423         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2424
2425 2010-12-02  Dirk Pranke  <dpranke@chromium.org>
2426
2427         Reviewed by Tony Chang.
2428
2429         This change is a bunch of cleanup / refactoring of the file
2430         below. It moves a bunch of free functions to methods on the
2431         TestShellThread class, and restructures other methods to be
2432         closer to the structure we'll need for the multiprocessing
2433         rewrite.
2434
2435         It also makes the logic of --run-singly a *lot* easier to follow
2436         by nestling all of the separate-thread logic into a single
2437         routine.
2438
2439         There should be no semantic changes in this patch, just cleanup.
2440
2441         https://bugs.webkit.org/show_bug.cgi?id=50367
2442
2443         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2444
2445 2010-12-02  Tony Chang  <tony@chromium.org>
2446
2447         Unreviewed, rolling out r73164.
2448         http://trac.webkit.org/changeset/73164
2449         https://bugs.webkit.org/show_bug.cgi?id=50359
2450
2451         broke debugger tests on win
2452
2453         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2454
2455 2010-11-30  Mihai Parparita  <mihaip@chromium.org>
2456
2457         Reviewed by Tony Chang.
2458
2459         Rebaseline server: add updating of baselines
2460         https://bugs.webkit.org/show_bug.cgi?id=50305
2461         
2462         Implements updating of baselines, where we copy -actual.* files over
2463         the current -expected.* files. To do this, we need a
2464         _get_actual_result_files method to get test results files and a
2465         _rebaseline_test method to actually do the file copy and SCM operation.
2466         _rebaseline_test logs output into a buffer, this is useful for both
2467         showing result in the UI and for unit tests.
2468         
2469         To make passing around of the various test environment properties
2470         (results directory, filesystem, SCM, etc) easier, add a TestConfig
2471         class for them.
2472         
2473         Moving of existing baselines is not implemented yet, this patch is big
2474         enough as it is.
2475
2476         * Scripts/webkitpy/common/system/filesystem.py:
2477         * Scripts/webkitpy/common/system/filesystem_mock.py:
2478         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js:
2479         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
2480         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py:
2481         * Scripts/webkitpy/tool/mocktool.py:
2482
2483 2010-12-02  Brent Fulgham  <bfulgham@webkit.org>
2484
2485         Unreviewed build fix after vcproj updates.
2486
2487         * DumpRenderTree/win/DumpRenderTreeCairo.vsprops: Make sure
2488         that WIN_CAIRO is defined for this build.
2489         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd: Update file
2490         to reflect new 'Debug_Cairo_CFLite' and 'Release_Cairo_CFLite'
2491         (these were previously 'Debug_Cairo' and 'Release_Cairo'
2492
2493 2010-12-02  Sam Weinig  <sam@webkit.org>
2494
2495         Reviewed by Anders Carlsson.
2496
2497         WebKit2 needs API to turn on popup blocking
2498         https://bugs.webkit.org/show_bug.cgi?id=50407
2499
2500         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
2501         (TestWebKitAPI::TEST):
2502         * WebKitTestRunner/TestController.cpp:
2503         (WTR::TestController::resetStateToConsistentValues):
2504
2505 2010-12-01  Tony Chang  <tony@chromium.org>
2506
2507         Reviewed by Ojan Vafai.
2508
2509         [chromium] force NRWT to use DRT
2510         https://bugs.webkit.org/show_bug.cgi?id=50359
2511
2512         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2513
2514 2010-12-02  Martin Robinson  <mrobinson@igalia.com>
2515
2516         Reviewed by Xan Lopez.
2517
2518         [GTK] DumpRenderTree has two copies of JavaScriptCore
2519         https://bugs.webkit.org/show_bug.cgi?id=49877
2520
2521         * GNUmakefile.am: Remove the second copy of JavaScriptCore from the
2522         LDADD list for DumpRenderTree.
2523
2524 2010-12-02  Sergio Villar Senin  <svillar@igalia.com>
2525
2526         Unreviewed: Added myself to list of Committers.
2527
2528         * Scripts/webkitpy/common/config/committers.py:
2529
2530 2010-12-01  Mihai Parparita  <mihaip@chromium.org>
2531
2532         Reviewed by Adam Barth.
2533
2534         build-webkit --chromium always updates DEPS and re-generates project files
2535         https://bugs.webkit.org/show_bug.cgi?id=50340
2536         
2537         Make build-webkit --chromium invoke update-webkit-chromium only when
2538         --update-chromium is passed in, so that we don't add 20 seconds to all
2539         builds.
2540         
2541         Making all invocations update was added with r61883, with the goal of
2542         making EWS bots always update. The bots will switch to using this flag
2543         (as will all other webkit-patch build steps) so nothing should change
2544         for them.
2545
2546         * Scripts/webkitdirs.pm:
2547         * Scripts/webkitpy/common/config/ports.py:
2548         * Scripts/webkitpy/common/config/ports_unittest.py:
2549
2550 2010-12-01  Dirk Pranke  <dpranke@chromium.org>
2551
2552         Reviewed by Tony Chang.
2553
2554         new-run-webkit-tests: add a --dry-run / -n flag
2555         https://bugs.webkit.org/show_bug.cgi?id=50045
2556
2557         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2558         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2559
2560 2010-12-01  Steve Falkenburg  <sfalken@apple.com>
2561
2562         Reviewed by Adam Roben.
2563
2564         WinCairo build should not use link-time code generation (LTCG)
2565         https://bugs.webkit.org/show_bug.cgi?id=50353
2566
2567         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2568         * DumpRenderTree/win/DumpRenderTree.vcproj:
2569         * DumpRenderTree/win/ImageDiff.vcproj:
2570         * FindSafari/FindSafari.vcproj:
2571         * MiniBrowser/MiniBrowser.vcproj:
2572         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2573         * WebKitAPITest/WebKitAPITest.vcproj:
2574         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
2575         * WebKitTestRunner/win/InjectedBundle.vcproj:
2576         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
2577         * WinLauncher/WinLauncher.vcproj:
2578         * record-memory-win/record-memory-win.vcproj:
2579
2580 2010-12-01  Martin Robinson  <mrobinson@igalia.com>
2581
2582         Touch GetUserAgentWithNullNPPFromNPPNew.cpp in an effort to force
2583         a rebuild of TestNetscapePlugin.la on GTK+. It seems that simply
2584         adding the file to the sources list was not enough to force the rebuild.
2585
2586         * DumpRenderTree/TestNetscapePlugIn/Tests/GetUserAgentWithNullNPPFromNPPNew.cpp:
2587         Remove an empty line at the end of this file to force a rebuild.
2588
2589 2010-12-01  Sam Weinig  <sam@webkit.org>
2590
2591         Fix windows build.
2592
2593         * MiniBrowser/win/BrowserView.cpp:
2594         (BrowserView::create):
2595
2596 2010-12-01  Martin Robinson  <mrobinson@igalia.com>
2597
2598         Add missing file to the TestNetscapePlugin sources list after r73057.
2599
2600         * GNUmakefile.am: Add missing file.
2601
2602 2010-12-01  Sam Weinig  <sam@webkit.org>
2603
2604         Reviewed by Anders Carlsson.
2605
2606         Add PageGrouping to WebKit2 API
2607         https://bugs.webkit.org/show_bug.cgi?id=50332
2608
2609         - Update testing harnesses to deal with new PageGroup API.
2610
2611         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
2612         (WKBundleInitialize):
2613         * TestWebKitAPI/InjectedBundleController.cpp:
2614         (TestWebKitAPI::InjectedBundleController::initialize):
2615         (TestWebKitAPI::InjectedBundleController::didInitializePageGroup):
2616         (TestWebKitAPI::InjectedBundleController::initializeTestNamed):
2617         * TestWebKitAPI/InjectedBundleController.h:
2618         * TestWebKitAPI/InjectedBundleTest.h:
2619         (TestWebKitAPI::InjectedBundleTest::initialize):
2620         (TestWebKitAPI::InjectedBundleTest::didInitializePageGroup):
2621         * TestWebKitAPI/PlatformUtilities.cpp:
2622         (TestWebKitAPI::Util::createContextForInjectedBundleTest):
2623         * TestWebKitAPI/PlatformUtilities.h:
2624         * TestWebKitAPI/PlatformWebView.h:
2625         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
2626         (TestWebKitAPI::TEST):
2627         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp:
2628         (TestWebKitAPI::DocumentStartUserScriptAlertCrashTest::initialize):
2629         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
2630         (TestWebKitAPI::PlatformWebView::PlatformWebView):
2631         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
2632         (TestWebKitAPI::PlatformWebView::PlatformWebView):
2633         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2634         (WTR::InjectedBundle::didInitializePageGroup):
2635         (WTR::InjectedBundle::initialize):
2636         (WTR::InjectedBundle::beginTesting):
2637         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2638         (WTR::InjectedBundle::pageGroup):
2639         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2640         (WTR::LayoutTestController::addUserScript):
2641         (WTR::LayoutTestController::addUserStyleSheet):
2642         (WTR::LayoutTestController::setXSSAuditorEnabled):
2643         * WebKitTestRunner/TestController.cpp:
2644         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2645         (WTR::PlatformWebView::PlatformWebView):
2646
2647 2010-12-01  Steve Falkenburg  <sfalken@apple.com>
2648
2649         Reviewed by Adam Roben.
2650
2651         vcproj changes can't be applied cleanly by the Windows EWS bot
2652         https://bugs.webkit.org/show_bug.cgi?id=50328
2653
2654         * CLWrapper/CLWrapper.sln: Modified property svn:eol-style.
2655         * CLWrapper/CLWrapper.vcproj: Modified property svn:eol-style.
2656         * DumpRenderTree/DumpRenderTree.sln: Modified property svn:eol-style.
2657         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops: Added property svn:eol-style.
2658         * DumpRenderTree/win/DumpRenderTree.vcproj: Modified property svn:eol-style.
2659         * DumpRenderTree/win/DumpRenderTreeApple.vsprops: Added property svn:eol-style.
2660         * DumpRenderTree/win/DumpRenderTreeCFLite.vsprops: Added property svn:eol-style.
2661         * DumpRenderTree/win/DumpRenderTreeCairo.vsprops: Added property svn:eol-style.
2662         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops: Added property svn:eol-style.
2663         * DumpRenderTree/win/ImageDiff.vcproj: Modified property svn:eol-style.
2664         * DumpRenderTree/win/ImageDiffCommon.vsprops: Added property svn:eol-style.
2665         * FindSafari/FindSafari.vcproj: Modified property svn:eol-style.
2666         * FindSafari/FindSafariCommon.vsprops: Added property svn:eol-style.
2667         * MIDLWrapper/MIDLWrapper.sln: Modified property svn:eol-style.
2668         * MIDLWrapper/MIDLWrapper.vcproj: Modified property svn:eol-style.
2669         * MiniBrowser/Configurations/MiniBrowserCFLite.vsprops: Added property svn:eol-style.
2670         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops: Added property svn:eol-style.
2671         * MiniBrowser/Configurations/MiniBrowserCoreFoundation.vsprops: Added property svn:eol-style.
2672         * MiniBrowser/MiniBrowser.vcproj: Added property svn:eol-style.
2673         * TestWebKitAPI/Configurations/TestWebKitAPICFLite.vsprops: Added property svn:eol-style.
2674         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops: Added property svn:eol-style.
2675         * TestWebKitAPI/Configurations/TestWebKitAPICoreFoundation.vsprops: Added property svn:eol-style.
2676         * TestWebKitAPI/win/TestWebKitAPI.sln: Added property svn:eol-style.
2677         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Added property svn:eol-style.
2678         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj: Added property svn:eol-style.
2679         * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops: Added property svn:eol-style.
2680         * WebKitAPITest/WebKitAPITest.vcproj: Added property svn:eol-style.
2681         * WebKitAPITest/WebKitAPITestCommon.vsprops: Added property svn:eol-style.
2682         * WebKitLauncherWin/WebKitLauncherWin.vcproj: Modified property svn:eol-style.
2683         * WebKitLauncherWin/WebKitLauncherWinCommon.vsprops: Added property svn:eol-style.
2684         * WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops: Added property svn:eol-style.
2685         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops: Added property svn:eol-style.
2686         * WebKitTestRunner/Configurations/InjectedBundleCoreFoundation.vsprops: Added property svn:eol-style.
2687         * WebKitTestRunner/Configurations/WebKitTestRunnerCFLite.vsprops: Added property svn:eol-style.
2688         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops: Added property svn:eol-style.
2689         * WebKitTestRunner/Configurations/WebKitTestRunnerCoreFoundation.vsprops: Added property svn:eol-style.
2690         * WebKitTestRunner/WebKitTestRunner.sln: Added property svn:eol-style.
2691         * WebKitTestRunner/win/InjectedBundle.vcproj: Added property svn:eol-style.
2692         * WebKitTestRunner/win/InjectedBundleGenerated.vcproj: Added property svn:eol-style.
2693         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops: Added property svn:eol-style.
2694         * WebKitTestRunner/win/WebKitTestRunner.vcproj: Added property svn:eol-style.
2695         * WinLauncher/WinLauncher.vcproj: Modified property svn:eol-style.
2696         * WinLauncher/WinLauncherCommon.vsprops: Added property svn:eol-style.
2697         * record-memory-win/record-memory-win-common.vsprops: Added property svn:eol-style.
2698         * record-memory-win/record-memory-win.vcproj: Modified property svn:eol-style.
2699
2700 2010-12-01  Anders Carlsson  <andersca@apple.com>
2701
2702         Reviewed by Darin Adler.
2703
2704         Return a correct user agent if NPN_UserAgent is called with a null NPP from NPP_New.
2705         https://bugs.webkit.org/show_bug.cgi?id=50336
2706
2707         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2708         Add new test.
2709
2710         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
2711         (PluginTest::NPP_New):
2712         Add default implementation/
2713
2714         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
2715         * DumpRenderTree/TestNetscapePlugIn/Tests/GetUserAgentWithNullNPPFromNPPNew.cpp: Added.
2716         (GetUserAgentWithNullNPPFromNPPNew::GetUserAgentWithNullNPPFromNPPNew):
2717         (GetUserAgentWithNullNPPFromNPPNew::NPP_New):
2718         Get the user agent.
2719
2720         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2721         (NPP_New):
2722         Call PluginTest::NPP_New.
2723
2724         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2725         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2726         Add new files.
2727
2728         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2729         (webkit_test_plugin_new_instance):
2730         Call PluginTest::NPP_New.
2731
2732 2010-12-01  Kevin Ollivier  <kevino@theolliviers.com>
2733
2734         [wx] Build fixes after recent trunk changes.
2735
2736         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2737         (LayoutTestController::findString):
2738         * wx/build/settings.py:
2739
2740 2010-12-01  Dan Bernstein  <mitz@apple.com>
2741
2742         Reviewed by Darin Adler.
2743
2744         WebKitTestRunner needs layoutTestController.findString
2745         https://bugs.webkit.org/show_bug.cgi?id=50238
2746
2747         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Added findString().
2748         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2749         (WTR::LayoutTestController::findString): Updated signature for autogenerated bindings.
2750         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Ditto.
2751
2752 2010-12-01  Steve Falkenburg  <sfalken@apple.com>
2753
2754         Try using svn:eol-style native on a vcproj file.
2755
2756         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Modified property svn:eol-style.
2757
2758 2010-12-01  Patrick Gansterer  <paroga@webkit.org>
2759
2760         Reviewed by Adam Roben.
2761
2762         [WINCE] Add WinCELauncher
2763         https://bugs.webkit.org/show_bug.cgi?id=50217
2764
2765         * WinCELauncher/main.cpp: Added.
2766
2767 2010-11-30  Benjamin Poulain  <benjamin.poulain@nokia.com>
2768
2769         Reviewed by Kenneth Rohde Christiansen.
2770
2771         [Qt] Implement layoutTestController.findString
2772         https://bugs.webkit.org/show_bug.cgi?id=50236
2773
2774         Add the missing function to the LayoutTestController.
2775
2776         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2777         (LayoutTestController::findString):
2778         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2779
2780 2010-11-30  Tony Chang  <tony@chromium.org>
2781
2782         Reviewed by Adam Barth.
2783
2784         [chromium] fix get-int-identifier-special-values.html using TestNetscapePlugIn
2785         https://bugs.webkit.org/show_bug.cgi?id=49036
2786
2787         * DumpRenderTree/chromium/LayoutTestController.cpp: Use IsNumber instead of IsInt32
2788             for CppVariants.
2789         (LayoutTestController::cppVariantToBool):
2790         (LayoutTestController::cppVariantToInt32):
2791         (LayoutTestController::setDatabaseQuota):
2792         (LayoutTestController::evaluateInWebInspector):
2793         (LayoutTestController::setMockGeolocationError):
2794
2795 2010-11-30  Eric Seidel  <eric@webkit.org>
2796
2797         Reviewed by Tony Chang.
2798
2799         update-webkit should call git fetch before git svn rebase
2800         https://bugs.webkit.org/show_bug.cgi?id=50273
2801
2802         After discussion on webkit-dev, we've decided to move the "default"
2803         git setup to pulling updates from git.webkit.org in preference
2804         to rebuilding the local svn index using git svn fetch every time.
2805
2806         This change should have no effect on people using the "old" git setup
2807         and should dramatically increase the speed of updates for those using
2808         the "new" git setup along with update-webkit.  I'm about to move the
2809         EWS and other queues over to this setup once this lands.
2810
2811         * Scripts/update-webkit:
2812
2813 2010-11-30  Mario Sanchez Prada  <msanchez@igalia.com>
2814
2815         Reviewed by Xan Lopez.
2816
2817         GTK: AX: implement press in DRT
2818         https://bugs.webkit.org/show_bug.cgi?id=36146
2819
2820         Implement AccessibilityUIElement::press() for GTK.
2821
2822         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2823         (AccessibilityUIElement::press): Implemented.
2824
2825 2010-11-29  Mihai Parparita  <mihaip@chromium.org>
2826
2827         Reviewed by Tony Chang.
2828
2829         config.webkit_base_dir returns a path with a trailing slash
2830         https://bugs.webkit.org/show_bug.cgi?id=50197
2831         
2832         config.webkit_base_dir() should return a path without a trailing slash,
2833         like all the other methods that return paths.
2834         
2835         Undoes MockFileSytem changes by r72640, since they're no longer
2836         necessary for GetBaselinesTest to pass.
2837
2838         * Scripts/webkitpy/common/system/filesystem_mock.py:
2839         * Scripts/webkitpy/layout_tests/port/base.py:
2840         * Scripts/webkitpy/layout_tests/port/config.py:
2841         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
2842
2843 2010-11-30  Mihai Parparita  <mihaip@chromium.org>
2844
2845         Reviewed by Tony Chang.
2846
2847         Rebaseline server: baseline display tweaks
2848         https://bugs.webkit.org/show_bug.cgi?id=50207
2849         
2850         Determine which baselines were used when running the tests and highlight
2851         them in the UI. Sort platform names alphabetically.
2852         
2853         Also makes the server URL be launched in the user's browser
2854         automatically.
2855
2856         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
2857         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
2858         * Scripts/webkitpy/tool/commands/data/rebaselineserver/util.js:
2859         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
2860         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py:
2861
2862 2010-11-30  Dan Bernstein  <mitz@apple.com>
2863
2864         Reviewed by Anders Carlsson.
2865
2866         <rdar://problem/8710645> WebKitTestRunner needs layoutTestController.findString
2867         https://bugs.webkit.org/show_bug.cgi?id=50238
2868
2869         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2870         (WTR::LayoutTestController::findString): Added.
2871         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2872
2873 2010-11-30  Steve Falkenburg  <sfalken@apple.com>
2874
2875         Reviewed by Adam Roben.
2876
2877         All projects on Windows should use cmd files for build events
2878         https://bugs.webkit.org/show_bug.cgi?id=50213
2879
2880         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops:
2881         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd: Added.
2882         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd: Added.
2883         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
2884         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd: Added.
2885         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd: Added.
2886         * DumpRenderTree/win/ImageDiffCommon.vsprops:
2887         * DumpRenderTree/win/ImageDiffPostBuild.cmd: Added.
2888         * DumpRenderTree/win/ImageDiffPreBuild.cmd: Added.
2889         * MiniBrowser/Configurations/MiniBrowserCFLite.vsprops:
2890         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
2891         * MiniBrowser/Configurations/MiniBrowserCoreFoundation.vsprops:
2892         * MiniBrowser/MiniBrowserPostBuild.cmd: Added.
2893         * MiniBrowser/MiniBrowserPreBuild.cmd: Added.
2894         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
2895         * TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd: Added.
2896         * TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd: Added.
2897         * WebKitAPITest/WebKitAPITestCommon.vsprops:
2898         * WebKitAPITest/WebKitAPITestPostBuild.cmd: Added.
2899         * WebKitAPITest/WebKitAPITestPreBuild.cmd: Added.
2900         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
2901         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
2902         * WebKitTestRunner/win/InjectedBundlePostBuild.cmd: Added.
2903         * WebKitTestRunner/win/InjectedBundlePreBuild.cmd: Added.
2904         * WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd: Added.
2905         * WebKitTestRunner/win/WebKitTestRunnerPreBuild.cmd: Added.
2906         * WinLauncher/WinLauncherCommon.vsprops:
2907         * WinLauncher/WinLauncherPostBuild.cmd: Added.
2908         * WinLauncher/WinLauncherPreBuild.cmd: Added.
2909
2910 2010-11-29  Dan Bernstein  <mitz@apple.com>
2911
2912         GTK DumpRenderTree build fix after r72887.
2913
2914         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2915         (LayoutTestController::findString):
2916
2917 2010-11-29  Dan Bernstein  <mitz@apple.com>
2918
2919         Windows DumpRenderTree build fix after r72887.
2920
2921         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2922         (LayoutTestController::findString): Added empty implementation.
2923
2924 2010-11-29  Dan Bernstein  <mitz@apple.com>
2925
2926         Reviewed by Darin Adler.
2927
2928         DumpRenderTree changes for testing the text search API.
2929         https://bugs.webkit.org/show_bug.cgi?id=50038
2930
2931         * DumpRenderTree/LayoutTestController.cpp:
2932         (findStringCallback):
2933         (LayoutTestController::staticFunctions):
2934         * DumpRenderTree/LayoutTestController.h:
2935         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2936         (LayoutTestController::findString):
2937         * MiniBrowser/mac/BrowserWindowController.m:
2938         (-[BrowserWindowController find:]):
2939
2940 2010-11-29  Johnny Ding  <jnd@chromium.org>
2941
2942         Unreviewed: Add myself to the list of Committers.
2943
2944         * Scripts/webkitpy/common/config/committers.py:
2945
2946 2010-11-29  Mark Rowe  <mrowe@apple.com>
2947
2948         Reviewed by Adele Peterson.
2949
2950         <rdar://problem/8694997> DumpRenderTree fails to build.
2951
2952         * DumpRenderTree/mac/PerlSupport/Makefile: Skip generating wrappers.
2953
2954 2010-11-29  Mark Rowe  <mrowe@apple.com>
2955
2956         Reviewed by Adele Peterson.
2957
2958         <rdar://problem/8694997> DumpRenderTree fails to build.
2959
2960         * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupportPregenerated.pm: Renamed from WebKitTools/DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupportTiger.pm.
2961         * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport_wrapPregenerated.c: Renamed from WebKitTools/DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport_wrapTiger.c.
2962         * DumpRenderTree/mac/PerlSupport/Makefile:
2963
2964 2010-11-29  Mario Sanchez Prada  <msanchez@igalia.com>
2965
2966         Reviewed by Martin Robinson.
2967
2968         [GTK] Null-check needed in DRT's AccessibilityUIElement::allAtributes()
2969         https://bugs.webkit.org/show_bug.cgi?id=50154
2970
2971         Added missing checks to allAttributes().
2972
2973         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2974         (AccessibilityUIElement::allAttributes): Added missing checks.
2975
2976 2010-11-29  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2977
2978         Reviewed by Kenneth Rohde Christiansen.
2979
2980         [Qt] Allow pre-generation for package builds for WebKit2
2981         https://bugs.webkit.org/show_bug.cgi?id=50139
2982
2983         Use a build variable for the generated directory path and set the
2984         value based on CONFIG just like for WebKit1.
2985
2986         For non-package builds use a relative base path for the
2987         genrated directory just like for WebKit1.
2988
2989         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2990         * WebKitTestRunner/qt/WebKitTestRunner.pro:
2991
2992 2010-11-28  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2993
2994         Reviewed by Kenneth Rohde Christiansen.
2995
2996         [Qt] Move some build logic from Qt to platform independent code
2997         https://bugs.webkit.org/show_bug.cgi?id=50134
2998
2999         Create target directories inside generate-forwarding-headers.pl.
3000
3001         * Scripts/generate-forwarding-headers.pl:
3002
3003 2010-11-24  Nicolas Dufresne  <nicolas.dufresne@collabora.co.uk>
3004
3005         Reviewed by Martin Robinson.
3006
3007         [GTK] Windowless plugins gets broken key input
3008         https://bugs.webkit.org/show_bug.cgi?id=49927
3009
3010         Convert the XEvent::keycode to ASCII before printing it. Not
3011         doing this was causing false positive in 
3012         plugins/keyboard-events.html.
3013
3014         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
3015         (keycode_to_char):
3016         (webkit_test_plugin_handle_event):
3017
3018 2010-11-24  Jan Erik Hanssen  <jhanssen@sencha.com>
3019
3020         Reviewed by Antonio Gomes.
3021
3022         [Qt] Html autofocus not working with QGraphicsWebView
3023         https://bugs.webkit.org/show_bug.cgi?id=43169
3024
3025         Tell the scene to set the webview item as the currently
3026         focused item. This makes the input field with autofocus get
3027         focus as it should.
3028
3029         * QtTestBrowser/webview.cpp:
3030         (WebViewGraphicsBased::WebViewGraphicsBased):
3031
3032 2010-11-24  Dirk Pranke  <dpranke@chromium.org>
3033
3034         Reviewed by Tony Chang.
3035
3036         nrwt - clean up create_driver interface and print out the
3037         command line used for DumpRenderTree/TestShell.
3038
3039         This patch adds a driver_cmd_line() call to the Port class in
3040         order to retrive the command line to print it out (as part of
3041         --print config).
3042
3043         In addition, this patch cleans up the Port.create_driver()
3044         signature and the Driver constructor interface to take a worker
3045         number and no longer require the image_path argument (Chromium's
3046         drivers now synthesize the image_path from the worker number
3047         internally).
3048
3049         https://bugs.webkit.org/show_bug.cgi?id=49934
3050
3051         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3052         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
3053         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
3054         * Scripts/webkitpy/layout_tests/port/base.py:
3055         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3056         * Scripts/webkitpy/layout_tests/port/chromium.py:
3057         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3058         * Scripts/webkitpy/layout_tests/port/dryrun.py:
3059         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3060         * Scripts/webkitpy/layout_tests/port/test.py:
3061         * Scripts/webkitpy/layout_tests/port/webkit.py:
3062         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3063         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3064
3065 2010-11-24  Ojan Vafai  <ojan@chromium.org>
3066
3067         Reviewed by Tony Chang.
3068
3069         [chromium] improve memory usage for test results server and store fewer runs
3070         https://bugs.webkit.org/show_bug.cgi?id=50035
3071
3072         Store fewer runs and don't pass full files around when we only need bools.
3073         Greatly improves error rates on test-results.appspot.com.
3074
3075         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3076         * TestResultServer/handlers/testfilehandler.py:
3077         * TestResultServer/model/dashboardfile.py:
3078         * TestResultServer/model/jsonresults.py:
3079
3080 2010-11-24  Dirk Pranke  <dpranke@chromium.org>
3081
3082         Reviewed by Tony Chang.
3083
3084         This patch implements the first part of the manager side of the
3085         Broker objects - it handles creating threads, waiting for them
3086         to complete, and running a single-threaded loop as well.
3087
3088         https://bugs.webkit.org/show_bug.cgi?id=49779
3089
3090         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
3091         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
3092         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3093         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3094
3095 2010-11-24  Mihai Parparita  <mihaip@chromium.org>
3096
3097         Reviewed by David Levin.
3098
3099         DRT should not generate pixel output for text/plain tests
3100         https://bugs.webkit.org/show_bug.cgi?id=50002
3101         
3102         Modify Mac, Windows and GTK DRT implementations to disable pixel output
3103         when encountering a text/plain response (the Chromium one already does
3104         this, and none of the other ports special-case text/plain output in
3105         the first place).
3106
3107         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3108         (dump):
3109         * DumpRenderTree/mac/DumpRenderTree.mm:
3110         (dump):
3111         * DumpRenderTree/win/DumpRenderTree.cpp:
3112         (dump):
3113
3114 2010-11-24  Andras Becsi  <abecsi@inf.u-szeged.hu>
3115
3116         Unreviewed.
3117
3118         Add my other email address to committers.py.
3119
3120         * Scripts/webkitpy/common/config/committers.py:
3121
3122 2010-11-24  Andras Becsi  <abecsi@inf.u-szeged.hu>
3123
3124         Reviewed by Csaba Osztrogonác.
3125
3126         Make build-webkit --minimal build with ENABLE_INSPECTOR=0
3127         https://bugs.webkit.org/show_bug.cgi?id=49975
3128
3129         * Scripts/build-webkit: Add ENABLE_INSPECTOR define to features,
3130         to enable the script to define it 0 in case of a minimal build.
3131
3132 2010-11-24  Martin Robinson  <mrobinson@igalia.com>
3133
3134         Reviewed by Xan Lopez.
3135
3136         [GTK] The WebKitWebView should expose a set of signals encapsulating the behavior of the EditorClient
3137         https://bugs.webkit.org/show_bug.cgi?id=49143
3138
3139         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3140         (createWebView): Call the new connectEditingCallbacks function.
3141         * DumpRenderTree/gtk/EditingCallbacks.cpp: Added.
3142         (dumpNodePath):
3143         (dumpRange):
3144         (insertActionString):
3145         (selectionAffinityString):
3146         (shouldBeginEditing):
3147         (shouldEndEditing):
3148         (shouldInsertNode):
3149         (shouldInsertText):
3150         (shouldDeleteRange):
3151         (shouldShowDeleteInterfaceForElement):
3152         (shouldChangeSelectedRange):
3153         (shouldApplyStyle):
3154         (editingBegan):
3155         (userChangedContents):
3156         (editingEnded):
3157         (selectionChanged):
3158         (connectEditingCallbacks):
3159         * DumpRenderTree/gtk/EditingCallbacks.h: Added.
3160         * GNUmakefile.am: Added EditingCallbacks.{h,cpp} to the source list.
3161
3162 2010-11-24  Yi Shen  <yi.4.shen@nokia.com>
3163
3164         Reviewed by Andreas Kling.
3165
3166         [Qt] Make QtTestBrowser remember the selected user agent
3167         https://bugs.webkit.org/show_bug.cgi?id=50021
3168
3169         Set user agent for a new page by using the old page's
3170
3171         * QtTestBrowser/mainwindow.cpp:
3172         (MainWindow::setPage):
3173
3174 2010-11-24 Patrick Gansterer <paroga@webkit.org>
3175
3176         Reviewed by Csaba Osztrogonác.
3177
3178         Remove Bakefile build system files
3179         https://bugs.webkit.org/show_bug.cgi?id=49983
3180
3181         r53757 only removed the content, but not the files.
3182         This patch removes that empty files.
3183
3184         * DumpRenderTree/wx/DumpRenderTree.bkl: Removed.
3185         * wx/browser/browser.bkl: Removed.
3186         * wx/build-wxwebkit: Removed.
3187
3188 2010-11-23  Dirk Pranke  <dpranke@chromium.org>
3189
3190         Reviewed by Tony Chang.
3191
3192         This patch cleans up the logic used to shard tests into groups a
3193         bit and adds the --worker-model flag to NRWT. The flag is only
3194         used at the moment to control whether to run single-threaded or
3195         not, but eventually will also allow toggling between threads and
3196         processes.
3197
3198         Also add a minor cleanup with _test_is_slow(), which just
3199         eliminates some repetition and gives slightly better encapsulation.
3200
3201         https://bugs.webkit.org/show_bug.cgi?id=49773
3202
3203         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3204         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3205
3206 2010-11-23  Mihai Parparita  <mihaip@chromium.org>
3207
3208         Reviewed by Tony Chang.
3209
3210         Rebaseline server: list current baselines and platforms
3211         https://bugs.webkit.org/show_bug.cgi?id=49991
3212         
3213         List existing baselines (with Trac links) for tests.
3214         
3215         Add dropdowns for choosing with platform baselines to target (and what
3216         to do with existing ones).
3217
3218         Also fix MockFileSystem.join to behave more like os.path.join (unit
3219         test was ending up with two consecutive slashes in a layout test
3220         path).        
3221
3222         * Scripts/webkitpy/common/system/filesystem_mock.py:
3223         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
3224         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
3225         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
3226         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js:
3227         * Scripts/webkitpy/tool/commands/data/rebaselineserver/util.js:
3228         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
3229         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py: Added.
3230
3231 2010-11-23  Ojan Vafai  <ojan@chromium.org>
3232
3233         Reviewed by Tony Chang.
3234
3235         remove timeout argument to urlopen
3236         https://bugs.webkit.org/show_bug.cgi?id=49995
3237
3238         Apparently the version of python we have on the bots doesn't accept a timeout argument.
3239
3240         * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py:
3241
3242 2010-11-23  Sheriff Bot  <webkit.review.bot@gmail.com>
3243
3244         Unreviewed, rolling out r72628.
3245         http://trac.webkit.org/changeset/72628
3246         https://bugs.webkit.org/show_bug.cgi?id=49994
3247
3248         This patch is causing layout-test failtures on GTK Linux
3249         64-bit Debug (Requested by ctguil on #webkit).
3250
3251         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
3252         (AccessibilityUIElement::AccessibilityUIElement):
3253         (AccessibilityUIElement::parentElementCallback):
3254         * DumpRenderTree/chromium/AccessibilityUIElement.h:
3255         * DumpRenderTree/chromium/CppBoundClass.cpp:
3256         * DumpRenderTree/chromium/CppBoundClass.h:
3257
3258 2010-11-22  Ojan Vafai  <ojan@chromium.org>
3259
3260         Reviewed by Tony Chang.
3261
3262         speculative fix for upload errors: stop using mechanize to upload to test-results.appspot.com
3263         https://bugs.webkit.org/show_bug.cgi?id=49944
3264
3265         * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py:
3266
3267 2010-11-23  Chris Guillory  <chris.guillory@google.com>
3268
3269         Reviewed by Dimitri Glazkov.
3270
3271         Include the FrameView widget of a RenderWidget in the accessibility tree.
3272         https://bugs.webkit.org/show_bug.cgi?id=49106
3273
3274         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
3275         (AccessibilityUIElement::AccessibilityUIElement):
3276         (AccessibilityUIElement::parentElementCallback):
3277         (AccessibilityUIElement::isEqualCallback):
3278         * DumpRenderTree/chromium/AccessibilityUIElement.h:
3279         * DumpRenderTree/chromium/CppBoundClass.cpp:
3280         (CppBoundClass::getFromCppVariant):
3281         * DumpRenderTree/chromium/CppBoundClass.h:
3282
3283 2010-11-23  Alex Grilo  <abgrilo@profusion.mobi>
3284
3285         Reviewed by Kenneth Rohde Christiansen.
3286
3287         [EFL] Add tiled backing store to EWebLauncher
3288         https://bugs.webkit.org/show_bug.cgi?id=45777
3289
3290         Allow EWebLauncher to choose between single and tiled backing store
3291
3292         * EWebLauncher/main.c:
3293         (on_key_down):
3294         (browserCreate):
3295         (main):
3296
3297 2010-11-23  Simon Hausmann  <simon.hausmann@nokia.com>
3298
3299         Reviewed by Tor Arne Vestbø.
3300
3301         [Qt] Review the setUserPermission & friends API
3302         https://bugs.webkit.org/show_bug.cgi?id=46810
3303
3304         Renamed requestPermissionFromUser to featurePermissionRequested
3305         and cancelRequestsForPermission to featurePermissionRequestCanceled.
3306
3307         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3308         (WebCore::WebPage::WebPage):
3309         * QtTestBrowser/webpage.cpp:
3310         (WebPage::WebPage):
3311         (WebPage::featurePermissionRequestCanceled):
3312         * QtTestBrowser/webpage.h:
3313
3314 2010-11-23  Simon Hausmann  <simon.hausmann@nokia.com>
3315
3316         Reviewed by Tor Arne Vestbø.
3317
3318         [Qt] Review the setUserPermission & friends API
3319         https://bugs.webkit.org/show_bug.cgi?id=46810
3320
3321         Rename setUserPermission to setFeaturePermission
3322
3323         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3324         (WebCore::WebPage::requestPermission):
3325         (WebCore::WebPage::permissionSet):
3326         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3327         (LayoutTestController::grantDesktopNotificationPermission):
3328         * QtTestBrowser/webpage.cpp:
3329         (WebPage::requestPermission):
3330
3331 2010-11-23  Simon Hausmann  <simon.hausmann@nokia.com>
3332
3333         Reviewed by Tor Arne Vestbø.
3334
3335         [Qt] Review the setUserPermission & friends API
3336         https://bugs.webkit.org/show_bug.cgi?id=46810
3337
3338         Rename PermissionDomain to Feature, NotificationsPermissionDomain to Notifications
3339         and GeolocationPermissionDomain to Geolocation.
3340
3341         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3342         (WebCore::WebPage::WebPage):
3343         (WebCore::WebPage::requestPermission):
3344         (WebCore::WebPage::cancelPermission):
3345         (WebCore::WebPage::permissionSet):
3346         (WebCore::DumpRenderTree::geolocationPermissionSet):
3347         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3348         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3349         (LayoutTestController::grantDesktopNotificationPermission):
3350         * QtTestBrowser/webpage.cpp:
3351         (WebPage::WebPage):
3352         (WebPage::requestPermission):
3353         (WebPage::cancelRequestsForPermission):
3354         * QtTestBrowser/webpage.h:
3355
3356 2010-11-23  Simon Hausmann  <simon.hausmann@nokia.com>
3357
3358         Reviewed by Tor Arne Vestbø.
3359
3360         [Qt] Review the setUserPermission & friends API
3361         https://bugs.webkit.org/show_bug.cgi?id=46810
3362
3363         Add a ByUser suffix to PermissionGranted/Denied. In the future
3364         we can add PermissionGrantedByDefault.
3365
3366
3367         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3368         (WebCore::WebPage::requestPermission):
3369         (WebCore::WebPage::permissionSet):
3370         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3371         (LayoutTestController::grantDesktopNotificationPermission):
3372         * QtTestBrowser/webpage.cpp:
3373         (WebPage::requestPermission):
3374
3375 2010-11-18  Satish Sampath  <satish@chromium.org>
3376
3377         Reviewed by Jeremy Orlow.
3378
3379         For speech input event, send an event object containing all the recognition results and metadata.
3380         https://bugs.webkit.org/show_bug.cgi?id=49736
3381
3382         Updated DRT by renaming the mock result method on all platforms to the new signature.
3383
3384         * DumpRenderTree/LayoutTestController.cpp:
3385         (addMockSpeechInputResultCallback):
3386         (LayoutTestController::staticFunctions):
3387         * DumpRenderTree/LayoutTestController.h:
3388         * DumpRenderTree/chromium/LayoutTestController.cpp:
3389         (LayoutTestController::LayoutTestController):
3390         (LayoutTestController::addMockSpeechInputResult):
3391         * DumpRenderTree/chromium/LayoutTestController.h:
3392         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3393         (LayoutTestController::addMockSpeechInputResult):
3394         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3395         (LayoutTestController::addMockSpeechInputResult):
3396         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3397         (LayoutTestController::addMockSpeechInputResult):
3398         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3399         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3400         (LayoutTestController::addMockSpeechInputResult):
3401         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3402         (LayoutTestController::addMockSpeechInputResult):
3403
3404 2010-11-22  Dirk Pranke  <dpranke@chromium.org>
3405
3406         Reviewed by Tony Chang.
3407
3408         Fix some spacing issues with log messages with
3409         new-run-webkit-tests --verbose.
3410
3411         https://bugs.webkit.org/show_bug.cgi?id=49936
3412
3413         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
3414
3415 2010-11-22  Ojan Vafai  <ojan@chromium.org>
3416
3417         Reviewed by Adam Barth.
3418
3419         update scm to work with different remote branches
3420         https://bugs.webkit.org/show_bug.cgi?id=49949
3421
3422         This works if there are multiple svn tracking branches
3423         and/or if the tracking branch is refs/remots/origin/master
3424         instead of refs/remotes/trunk which is the direction we're trying
3425         to head since that makes fetches faster.
3426
3427         * Scripts/webkitpy/common/checkout/scm.py:
3428         * Scripts/webkitpy/common/checkout/scm_unittest.py:
3429
3430 2010-11-22  Hayato Ito  <hayato@chromium.org>
3431
3432         Reviewed by Shinichiro Hamaji.
3433
3434         Ignore reference files which will be used by reftests when collecting
3435         test cases.
3436         https://bugs.webkit.org/show_bug.cgi?id=49835
3437
3438         * Scripts/webkitpy/layout_tests/port/test_files.py:
3439         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
3440
3441 2010-11-22  Adam Roben  <aroben@apple.com>
3442
3443         Use paths relative to $WebKitVSPropsRedirectionDir to access shared .vsprops files
3444
3445         Apple's Windows build allows placing header files and import libraries for WebKit's
3446         dependencies (CoreGraphics, CFNetwork, SQLite, etc.) outside the source tree via the
3447         $WebKitLibrariesDir environment variable. This is both required for production builds and
3448         convenient for Apple-internal developer builds. Apple's production builds also require that
3449         WebKit's shared .vsprops files be accessed relative to $WebKitLibrariesDir. In production
3450         builds, the files are copied into that directory tree by the
3451         WebKitLibraries/win/tools/WinTools.make file. In Apple-internal developer builds, the
3452         copying is done by
3453         JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make.
3454
3455         This .vsprops copying is problematic in one very important case: when a developer updates
3456         their source tree and then tries to build. Visual Studio only reads .vsprops files when a
3457         project is first loaded. So, when Visual Studio is first opened after the .vsprops files are
3458         updated, it reads in the old files that were already residing in $WebKitLibrariesDir. When a
3459         build is started, JavaScriptCoreGenerated.make copies the new .vsprops files into
3460         $WebKitLibrariesDir, but Visual Studio will not pick up the changes.  The rest of the build
3461         will proceed with out-of-date .vsprops files, which will likely result in a build failure.
3462
3463         To fix this, we now use normal relative paths to access the .vsprops files in the source
3464         tree rather than in $WebKitLibrariesDir, but prefix those paths with a new environment
3465         variable, $WebKitVSPropsRedirectionDir. In developer builds, this environment variable is
3466         unset, so the normal relative paths are used to read the .vsprops files out of the source
3467         tree directly. In production builds, this environment variable is set to a fake directory
3468         that will cause the .vsprops files in $WebKitLibrariesDir to be found when the relative path
3469         is resolved.
3470         
3471         For example, JavaScriptCore.vcproj uses this path for FeatureDefines.vsprops:
3472
3473         $(WebKitVSPropsRedirectionDir)..\..\..\WebKitLibraries\win\tools\vsprops\FeatureDefines.vsprops
3474
3475         In developer builds, where $WebKitVSPropsRedirectionDir is unset, this will point to the
3476         files in WebKitLibraries\win\tools\vsprops in the source tree. In production builds,
3477         JavaScriptCore.make sets $WebKitVSPropsRedirectionDir to
3478         "$(SRCROOT)\AppleInternal\tools\vsprops\OpenSource\1\2\3\", so the full path for
3479         FeatureDefines.vsprops becomes:
3480
3481         $(SRCROOT)\AppleInternal\tools\vsprops\OpenSource\1\2\3\..\..\..\WebKitLibraries\win\tools\vsprops\FeatureDefines.vsprops
3482
3483         which resolves to:
3484
3485         $(SRCROOT)\AppleInternal\tools\vsprops\OpenSource\WebKitLibraries\win\tools\vsprops\FeatureDefines.vsprops
3486
3487         (We rely on the fact that Windows doesn't care whether the directories "1", "2", and "3"
3488         actually exist since they are matched by an equal number of ".." path components.)
3489
3490         Note that Visual Studio still won't pick up changes made to .vsprops files while Visual
3491         Studio is open, but that problem hasn't seemed to cause developers many headaches so far.
3492
3493         Fixes <http://webkit.org/b/49181> Windows build fails mysteriously when .vsprops files are
3494         updated
3495
3496         Reviewed by Dave Hyatt.
3497
3498         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3499         * DumpRenderTree/win/DumpRenderTree.vcproj:
3500         * DumpRenderTree/win/ImageDiff.vcproj:
3501         * FindSafari/FindSafari.vcproj:
3502         * MiniBrowser/MiniBrowser.vcproj:
3503         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3504         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj:
3505         * WebKitAPITest/WebKitAPITest.vcproj:
3506         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
3507         * WebKitTestRunner/win/InjectedBundle.vcproj:
3508         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
3509         * WinLauncher/WinLauncher.vcproj:
3510         * record-memory-win/record-memory-win.vcproj:
3511         Changed to use paths relative to $WebKitVSPropsRedirectionDir to access shared .vsprops
3512         files.
3513
3514 2010-11-22  Adam Roben  <aroben@apple.com>
3515
3516         Make it possible to run tests on Windows without Visual Studio or VC++
3517         Express installed
3518
3519         webkitdir.pm::setupCygwinEnv dies when Visual Studio and VC++ Express
3520         are not installed. But this function doesn't need to be called when we
3521         already have a build available and are just trying to run the tests.
3522
3523         Fixes <http://webkit.org/b/49932> New Windows 7 bot can't run tests
3524         because Visual Studio/VC++ Express aren't installed
3525
3526         Reviewed by Dave Hyatt.
3527
3528         * Scripts/webkitdirs.pm:
3529         (determineConfigurationForVisualStudio): Don't call setupCygwinEnv, as
3530         it is not needed by this function. Also added a FIXME.
3531
3532         (usingVisualStudioExpress): Call setupCygwinEnv directly rather than
3533         relying on determineConfigurationForVisualStudio doing it.
3534
3535 2010-11-19  Hayato Ito  <hayato@chromium.org>
3536
3537         Reviewed by Shinichiro Hamaji.
3538
3539         Simplify Driver.run_test() so that it takes only one parameter, TestInput.
3540
3541         https://bugs.webkit.org/show_bug.cgi?id=49812
3542
3543         * Scripts/webkitpy/layout_tests/driver_test.py:
3544         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3545         * Scripts/webkitpy/layout_tests/port/base.py:
3546         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3547         * Scripts/webkitpy/layout_tests/port/chromium.py:
3548         * Scripts/webkitpy/layout_tests/port/dryrun.py:
3549         * Scripts/webkitpy/layout_tests/port/test.py:
3550         * Scripts/webkitpy/layout_tests/port/webkit.py:
3551         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3552         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3553
3554 2010-11-22  Hayato Ito  <hayato@chromium.org>
3555
3556         Reviewed by Tony Chang.
3557
3558         [NRWT] Retry a few times in reading a png image to avoid a race condition.
3559
3560         https://bugs.webkit.org/show_bug.cgi?id=49924
3561
3562         * Scripts/webkitpy/layout_tests/port/chromium.py:
3563
3564 2010-11-22  João Paulo Rechi Vita  <jprvita@profusion.mobi>
3565
3566         Reviewed by Kenneth Rohde Christiansen.
3567
3568         Fix EWebLauncher zoom discretization
3569         https://bugs.webkit.org/show_bug.cgi?id=49810
3570
3571         * EWebLauncher/main.c:
3572         (nearest_zoom_level_get):
3573         (zoom_level_set):
3574         (on_load_finished):
3575         (on_key_down):
3576
3577 2010-11-21  Sam Weinig  <sam@webkit.org>
3578
3579         Rubber-stamped by Dan Bernstein.
3580
3581         Fix ~300 WebKit2 tests by enabling developer extras preference.
3582
3583         * WebKitTestRunner/TestController.cpp:
3584         (WTR::TestController::resetStateToConsistentValues):
3585
3586 2010-11-21  Sam Weinig  <sam@webkit.org>
3587
3588         Reviewed by Dan Bernstein.
3589
3590         Textareas should be resizable by default
3591         https://bugs.webkit.org/show_bug.cgi?id=49892
3592
3593         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3594         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp: Added.
3595         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3596         Add preferences test.
3597
3598 2010-11-19  Mihai Parparita  <mihaip@chromium.org>
3599
3600         Reviewed by Tony Chang.
3601
3602         Rebaseline server: checksum-only differences and prefetching
3603         https://bugs.webkit.org/show_bug.cgi?id=49841
3604         
3605         Add support for image test results where the only difference is in the
3606         checksum.
3607         
3608         Add prefetching of the image results from the next test.
3609         
3610         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
3611         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
3612         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
3613
3614 2010-11-19  Dirk Pranke  <dpranke@chromium.org>
3615
3616         Reviewed by Tony Chang.
3617
3618         nrwt multiprocessing - add 'worker number' concept, move stuff to worker thread
3619
3620         Add the 'worker number' and 'worker name' concepts to the 
3621         TestShellThread objects, and move test_types and test_args from
3622         the TestRunner to the TestShellThread.
3623
3624         https://bugs.webkit.org/show_bug.cgi?id=49768
3625
3626         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3627         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3628
3629 2010-11-19  Dirk Pranke  <dpranke@chromium.org>
3630
3631         Reviewed by Ojan Vafai.
3632
3633         Do some minor cleanup and bug fixing.
3634
3635         https://bugs.webkit.org/show_bug.cgi?id=49777
3636
3637         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3638         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3639
3640 2010-11-19  Dirk Pranke  <dpranke@chromium.org>
3641
3642         Reviewed by Ojan Vafai.
3643
3644         nrwt - config.build_directory() is busted
3645
3646         Fixes a typo that was causing us to usually return the top level
3647         directory WebKitBuild instead of WebKitBuild/{Debug,Release}. The
3648         bug was hidden by test stubs that were too simplistic :(.
3649
3650         https://bugs.webkit.org/show_bug.cgi?id=49815
3651
3652         * Scripts/webkitpy/common/system/executive_mock.py:
3653         * Scripts/webkitpy/layout_tests/port/config.py:
3654         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
3655
3656 2010-11-19  Steve Falkenburg  <sfalken@apple.com>
3657
3658         Reviewed by Adam Roben.
3659
3660         Add Debug_Cairo_CFLite and Release_Cairo_CFLite configurations for all vcproj files
3661         https://bugs.webkit.org/show_bug.cgi?id=49819
3662
3663         * DumpRenderTree/DumpRenderTree.sln:
3664         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3665         * DumpRenderTree/win/DumpRenderTree.vcproj:
3666         * DumpRenderTree/win/ImageDiff.vcproj:
3667         * FindSafari/FindSafari.vcproj:
3668         * MiniBrowser/MiniBrowser.vcproj:
3669         * TestWebKitAPI/win/TestWebKitAPI.sln:
3670         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3671         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj:
3672         * WebKitAPITest/WebKitAPITest.vcproj:
3673         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
3674         * WebKitTestRunner/win/InjectedBundle.vcproj:
3675         * WebKitTestRunner/win/InjectedBundleGenerated.vcproj:
3676         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
3677         * WinLauncher/WinLauncher.vcproj:
3678         * record-memory-win/record-memory-win.vcproj:
3679
3680 2010-11-19  Adam Roben  <aroben@apple.com>
3681
3682         Add some more Windows slaves
3683
3684         This is probably more than we will be using in the immediate future,
3685         but having some extra slave names makes experimenting with different
3686         configurations easier.
3687
3688         Reviewed by Jon Honeycutt.
3689
3690         * BuildSlaveSupport/build.webkit.org-config/config.json: Added 5 more
3691         Windows slaves and distributed them among the three different Test
3692         builders.
3693
3694 2010-11-19  Kinuko Yasuda  <kinuko@chromium.org>
3695
3696         Reviewed by Ojan Vafai.
3697
3698         [Chromium] REGRESSION: Record actual test results in the JSON result summary for non-layout tests
3699         https://bugs.webkit.org/show_bug.cgi?id=49702
3700
3701         Re-landing r72357 with a test fix.
3702
3703         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
3704         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3705         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
3706
3707 2010-11-19  Avi Drissman  <avi@google.com>
3708
3709         Reviewed by Antonio Gomes.
3710
3711         Complete support for Unix editing mode
3712         https://bugs.webkit.org/show_bug.cgi?id=49757
3713
3714         * DumpRenderTree/LayoutTestController.cpp:
3715         (setEditingBehaviorCallback):
3716         * DumpRenderTree/chromium/LayoutTestController.cpp:
3717         (LayoutTestController::setEditingBehavior):
3718
3719 2010-11-19  Adam Roben  <aroben@apple.com>
3720
3721         Fix run-javascriptcore-tests when there's a space in the path to
3722         testapi
3723
3724         Reviewed by Sam Weinig.
3725
3726         * Scripts/run-javascriptcore-tests: Use an indirect object when calling
3727         system() to force it to interpret spaces in the path correctly.
3728
3729 2010-11-19  Adam Roben  <aroben@apple.com>
3730
3731         Update scripts for .exe name changes after r72327
3732
3733         As of r72327, the "_debug" suffix is only used in Debug_All builds.
3734
3735         Reviewed by Sam Weinig.
3736
3737         * Scripts/run-javascriptcore-tests:
3738         (testapiPath):
3739
3740         * Scripts/sunspider-compare-results:
3741         (pathToBuiltJSC):
3742
3743         * Scripts/webkitdirs.pm:
3744         (jscPath):
3745         (safariPath):
3746
3747 2010-11-19  Steve Falkenburg  <sfalken@apple.com>
3748
3749         Reviewed by Darin Adler.
3750
3751         Normalize Cairo/CFLite project/solution configuration names
3752         https://bugs.webkit.org/show_bug.cgi?id=49818
3753
3754         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3755         * DumpRenderTree/win/DumpRenderTree.vcproj:
3756         * DumpRenderTree/win/ImageDiff.vcproj:
3757         * MiniBrowser/MiniBrowser.vcproj:
3758         * TestWebKitAPI/win/TestWebKitAPI.sln:
3759         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3760         * WebKitAPITest/WebKitAPITest.vcproj:
3761         * WebKitTestRunner/win/InjectedBundle.vcproj:
3762         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
3763         * WinLauncher/WinLauncher.vcproj:
3764         * Scripts/webkitdirs.pm: Updated cairo build configs.
3765
3766 2010-11-18  Steve Falkenburg  <sfalken@apple.com>
3767
3768         Reviewed by Adam Roben.
3769
3770         Windows vcproj configuration names should be normalized across projects
3771         https://bugs.webkit.org/show_bug.cgi?id=49776
3772
3773         * DumpRenderTree/DumpRenderTree.sln:
3774         * FindSafari/FindSafari.vcproj:
3775         * TestWebKitAPI/win/TestWebKitAPI.sln:
3776         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj:
3777         * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops: Added.
3778         * WebKitAPITest/WebKitAPITest.vcproj:
3779         * WebKitAPITest/WebKitAPITestCommon.vsprops:
3780         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
3781         * WebKitTestRunner/WebKitTestRunner.sln:
3782         * WebKitTestRunner/win/InjectedBundleGenerated.vcproj:
3783         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops: Added.
3784         * record-memory-win/record-memory-win.vcproj:
3785
3786 2010-11-18  Gavin Barraclough  <barraclough@apple.com>
3787
3788         Build fix - as per DRT-mac, always enabled developer extras,
3789         in win/qt/gtk DRT.
3790
3791         This is necessary to enable rich exception messages to be generated
3792         following https://bugs.webkit.org/show_bug.cgi?id=49708.
3793
3794         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3795         (shouldEnableDeveloperExtras):
3796         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3797         (WebCore::shouldEnableDeveloperExtras):
3798         * DumpRenderTree/win/DumpRenderTree.cpp:
3799         (shouldEnableDeveloperExtras):
3800
3801 2010-11-18  Sheriff Bot  <webkit.review.bot@gmail.com>
3802
3803         Unreviewed, rolling out r72357.
3804         http://trac.webkit.org/changeset/72357
3805         https://bugs.webkit.org/show_bug.cgi?id=49784
3806
3807         It broke test-webkitpy tests since the patch didn't have the
3808         corresponding test update (Requested by kinuko on #webkit).
3809
3810         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
3811         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3812
3813 2010-11-18  Mihai Parparita  <mihaip@chromium.org>
3814
3815         Reviewed by Tony Chang.
3816
3817         Rebaseline server: add rebaseline queue
3818         https://bugs.webkit.org/show_bug.cgi?id=49763
3819         
3820         Add a UI queue (a multi-item <select>) where tests to be baselined
3821         can be enqueued (also supports basic removal). A queue is used instead
3822         of immediately doing rebaselines since SCM operations can take a while.
3823         It's better to go through lots of tests quickly to mark them as
3824         needing rebaselining and then batch the SCM operations.
3825         
3826         Also adds a simple log where results can be displayed.
3827
3828         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
3829         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
3830         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
3831         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js: Added.
3832         * Scripts/webkitpy/tool/commands/data/rebaselineserver/util.js:
3833         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
3834
3835 2010-11-18  Gavin Barraclough  <barraclough@apple.com>
3836
3837         Reviewed by Oliver Hunt.
3838
3839         Bug 49708 - Stop recompiling functions to regenerate exception info.
3840
3841         Instead only hold info as necessary – keep divot info is the inspector
3842         is enabled, line number info is debugging or profiling, and handler
3843         info for functions with try/catch.
3844
3845         * DumpRenderTree/mac/DumpRenderTree.mm:
3846         (shouldEnableDeveloperExtras):
3847             - always enable the developer tools from DRT, to ensure we
3848               produce rich error messages on JavaScript exceptions.
3849
3850 2010-11-18  Kinuko Yasuda  <kinuko@chromium.org>
3851
3852         Reviewed by Ojan Vafai.
3853
3854         [Chromium] REGRESSION: Record actual test results in the JSON result summary for non-layout tests
3855         https://bugs.webkit.org/show_bug.cgi?id=49702
3856
3857         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
3858         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3859
3860 2010-11-18  Dirk Pranke  <dpranke@chromium.org>
3861
3862         Reviewed by Tony Chang.
3863
3864         new-run-webkit-tests: create first part of 'message_broker' class for multiprocessing fixes
3865
3866         Create the first version of the 'message_broker' package. This
3867         class will encapsulate all of the threading/multiprocessing and
3868         message-sending details for the communication between the
3869         'manager' object and the 'worker' objects. For the moment, it
3870         just holds some routines and tests for logging thread stacks.
3871
3872         There should be no functional changes in this patch, just moving stuff
3873         around.
3874
3875         https://bugs.webkit.org/show_bug.cgi?id=49707
3876
3877         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3878         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread_unittest.py: Removed.
3879         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py: Added.
3880         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py: Added.
3881         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3882         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3883
3884 2010-11-18  Steve Falkenburg  <sfalken@apple.com>
3885
3886         Reviewed by Adam Roben.
3887
3888         Remove leftover Windows Debug_Internal configurations
3889         https://bugs.webkit.org/show_bug.cgi?id=49758
3890
3891         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3892         * DumpRenderTree/win/DumpRenderTree.vcproj:
3893         * DumpRenderTree/win/ImageDiff.vcproj:
3894         * MiniBrowser/MiniBrowser.vcproj:
3895         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3896         * WebKitAPITest/WebKitAPITest.vcproj:
3897         * WebKitTestRunner/win/InjectedBundle.vcproj:
3898         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
3899         * WinLauncher/WinLauncher.vcproj:
3900
3901 2010-11-18  Adam Roben  <aroben@apple.com>
3902
3903         Add three new Windows XP build slaves
3904
3905         Reviewed by Steve Falkenburg.
3906
3907         * BuildSlaveSupport/build.webkit.org-config/config.json: Added three
3908         new slaves, and added them to the Windows XP Debug (Tests) builder.
3909
3910 2010-11-18  Daniel Bates  <dbates@rim.com>
3911
3912         Reviewed by Adam Roben.
3913
3914         update-webkit-support-libs should fall back to existing
3915         WebKitSupportLibrary version if there is no internet connectivity
3916         https://bugs.webkit.org/show_bug.cgi?id=49503
3917
3918         Fall back to existing support libraries (if present) when there is
3919         no internet connection.
3920
3921         Currently, update-webkit-support-libs dies with an "out-of-date"
3922         error when there is no internet connection because it cannot
3923         retrieve versioning information from developer.apple.com. Because
3924         update-webkit-support-libs fails, build-webkit fails. Instead,
3925         if there is no internet connection and the support libraries are
3926         present then we should warn the user and exit() with success so
3927         that build-webkit can work without an internet connection.
3928
3929         * Scripts/update-webkit-support-libs:
3930
3931 2010-11-18  Steve Falkenburg  <sfalken@apple.com>
3932
3933         Reviewed by Adam Roben.
3934
3935         Debug_Internal Windows configuration is unnecessary, should be removed
3936         https://bugs.webkit.org/show_bug.cgi?id=49753
3937
3938         * DumpRenderTree/win/DumpRenderTree.cpp:
3939         * MiniBrowser/win/stdafx.h:
3940         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
3941         * WebKitTestRunner/win/TestControllerWin.cpp:
3942
3943 2010-11-18  Steve Falkenburg  <sfalken@apple.com>
3944
3945         Reviewed by Adam Roben.
3946
3947         Clean up vcproj errors
3948         https://bugs.webkit.org/show_bug.cgi?id=49741
3949
3950         * MiniBrowser/MiniBrowser.vcproj:
3951         * WebKitAPITest/WebKitAPITest.vcproj:
3952         * WebKitTestRunner/win/InjectedBundle.vcproj:
3953         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
3954
3955 2010-11-18  Hayato Ito  <hayato@chromium.org>
3956
3957         Reviewed by Shinichiro Hamaji.
3958
3959         [NRWT] Fix a break of '--new-baseline' feature in pixel_test
3960         which is caused by r72249.
3961
3962         https://bugs.webkit.org/show_bug.cgi?id=49751
3963
3964         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
3965
3966 2010-11-18  Adam Roben  <aroben@apple.com>
3967
3968         Implement layoutTestController.waitForPolicyDelegate on Windows
3969
3970         Fixes <http://webkit.org/b/25038> <rdar://problem/6790213>.
3971
3972         Reviewed by Simon Fraser.
3973
3974         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3975         (LayoutTestController::waitForPolicyDelegate): Implemented by porting
3976         code from LayoutTestControllerMac.mm.
3977
3978 2010-11-18  Hayato Ito  <hayato@chromium.org>
3979
3980         Reviewed by Shinichiro Hamaji.
3981
3982         [NRWT] Fix a break of '--new-baseline' feature which is caused by r72249.
3983
3984         https://bugs.webkit.org/show_bug.cgi?id=49740
3985
3986         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
3987
3988 2010-11-18  Tony Chang  <tony@chromium.org>
3989
3990         Reviewed by Adam Barth.
3991
3992         run platform/chromium/plugins/refcount-leaks.html on all platforms
3993         https://bugs.webkit.org/show_bug.cgi?id=49485
3994
3995         Add PluginObject.testObjectCount which returns the number of allocated
3996         TestObjects. Add PluginObject.testCreateTestObject which allocates
3997         and returns a TestObject.
3998
3999         Add TestObject.refCount which returns the number of refs on the
4000         TestObject.
4001
4002         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
4003         (pluginGetProperty):
4004         (pluginInvoke):
4005         * DumpRenderTree/TestNetscapePlugIn/TestObject.cpp:
4006         (getTestObjectCount):
4007         (testAllocate):
4008         (testDeallocate):
4009         (testGetProperty):
4010         (testScriptObjectInvoke): Release a ref to a plugin object that was
4011             previously leaked.
4012         * DumpRenderTree/TestNetscapePlugIn/TestObject.h:
4013
4014 2010-11-17  Steve Falkenburg  <sfalken@apple.com>
4015
4016         Reviewed by Adam Roben.
4017
4018         WebKitTools projects (WebKitTestRunner, record-memory-win) should use vsprops for common build settings
4019         https://bugs.webkit.org/show_bug.cgi?id=49711
4020
4021         * WebKitTestRunner/Configurations/WebKitTestRunnerCFLite.vsprops: Added.
4022         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops: Added.
4023         * WebKitTestRunner/Configurations/WebKitTestRunnerCoreFoundation.vsprops: Added.
4024         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
4025         * record-memory-win/record-memory-win-common.vsprops: Added.
4026         * record-memory-win/record-memory-win.vcproj:
4027
4028 2010-11-18  Andras Becsi  <abecsi@inf.u-szeged.hu>
4029
4030         Reviewed by Csaba Osztrogonác.
4031
4032         [Qt][WK2] Only add user agent strings to the list which aren't listed yet.
4033
4034         * MiniBrowser/qt/BrowserWindow.cpp:
4035         (BrowserWindow::updateUserAgentList):
4036
4037 2010-11-17  Adam Roben  <aroben@apple.com>
4038
4039         Don't trigger Windows builds when chromium-win test results change
4040
4041         Reviewed by Mark Rowe.
4042
4043         * Scripts/webkitpy/common/config/build.py:
4044         (_should_file_trigger_build): Changed the regular expression used to
4045         search for directory names to only consider full directory names,
4046         rather than matching directory names where the string we care about is
4047         a suffix of the name.
4048
4049         * Scripts/webkitpy/common/config/build_unittest.py:
4050         (ShouldBuildTest): Added a test.
4051
4052 2010-11-17  Hayato Ito  <hayato@chromium.org>
4053
4054         Reviewed by Shinichiro Hamaji.
4055
4056         Remove a uri member from TestInput class.
4057
4058         https://bugs.webkit.org/show_bug.cgi?id=49691
4059
4060         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
4061         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4062
4063 2010-11-17  Adam Roben  <aroben@apple.com>
4064
4065         Move FindSafari's settings into a vsprops file
4066
4067         Fixes <http://webkit.org/b/49699> FindSafari should use a vsprops file
4068
4069         Reviewed by Steve Falkenburg.
4070
4071         * FindSafari/FindSafari.vcproj:
4072         * FindSafari/FindSafariCommon.vsprops: Added.
4073
4074 2010-11-17  Adam Roben  <aroben@apple.com>
4075
4076         Use a minimum font size of 0 in DRT on Windows
4077
4078         This is the Windows equivalent of r72164.
4079
4080         Rubber-stamped by Dave Hyatt.
4081
4082         * DumpRenderTree/win/DumpRenderTree.cpp:
4083         (resetDefaultsToConsistentValues):
4084
4085 2010-11-17  Dirk Pranke  <dpranke@chromium.org>
4086
4087         Reviewed by Andreas Kling.
4088
4089         webkit-patch pretty-diff shouldn't need to be run from a checkout root in git
4090         https://bugs.webkit.org/show_bug.cgi?id=49639
4091
4092         * Scripts/webkitpy/common/checkout/scm.py:
4093
4094 2010-11-17  Mihai Parparita  <mihaip@chromium.org>
4095
4096         Reviewed by Tony Chang.
4097
4098         Rebaseline server: add loupe for image diffs
4099         https://bugs.webkit.org/show_bug.cgi?id=49692
4100         
4101         Add a loupe (magnifiying glass) for inspecting image diffs. Shows an
4102         enlarged area of the expected, actual and diff images side by side.
4103
4104         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
4105         * Scripts/webkitpy/tool/commands/data/rebaselineserver/loupe.js: Added.
4106         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
4107         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
4108
4109 2010-11-17  Steve Falkenburg  <sfalken@apple.com>
4110
4111         Reviewed by Adam Roben.
4112
4113         WebKitLauncherWin should use vsprops for shared build settings
4114         https://bugs.webkit.org/show_bug.cgi?id=49696
4115
4116         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
4117         * WebKitLauncherWin/WebKitLauncherWinCommon.vsprops: Added.
4118
4119 2010-11-17  Steve Falkenburg  <sfalken@apple.com>
4120
4121         Reviewed by Adam Roben.
4122
4123         WinLauncher should use vsprops for shared build settings
4124         https://bugs.webkit.org/show_bug.cgi?id=49695
4125
4126         * WinLauncher/WinLauncher.cpp:
4127         (_tWinMain):
4128         (PrintView):
4129         (WndProc):
4130         (MyEditProc):
4131         * WinLauncher/WinLauncher.vcproj:
4132         * WinLauncher/WinLauncherCommon.vsprops: Added.
4133
4134 2010-11-17  Steve Falkenburg  <sfalken@apple.com>
4135
4136         Delete unused file unintentionally added in last change.
4137
4138         * DumpRenderTree/win/DumpRenderTreeCURL.vsprops: Removed.
4139
4140 2010-11-17  Steve Falkenburg  <sfalken@apple.com>
4141
4142         Reviewed by Adam Roben.
4143
4144         DumpRenderTree on Windows should use a vsprops file for shared project settings
4145         https://bugs.webkit.org/show_bug.cgi?id=49690
4146
4147         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
4148         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops: Added.
4149         * DumpRenderTree/win/DumpRenderTree.vcproj:
4150         * DumpRenderTree/win/DumpRenderTreeApple.vsprops: Added.
4151         * DumpRenderTree/win/DumpRenderTreeCFLite.vsprops: Added.
4152         * DumpRenderTree/win/DumpRenderTreeCURL.vsprops: Added.
4153         * DumpRenderTree/win/DumpRenderTreeCairo.vsprops: Added.
4154         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops: Added.
4155         * DumpRenderTree/win/ImageDiff.vcproj:
4156         * DumpRenderTree/win/ImageDiffCommon.vsprops: Added.
4157
4158 2010-11-17  Hayato Ito  <hayato@chromium.org>
4159
4160         Refactor TestTypeBase.compare_output().
4161
4162         Introduce a TestOutput class and update compare_output() of each test
4163         types so that they can take both actual and expected TestOutput objects.
4164
4165         https://bugs.webkit.org/show_bug.cgi?id=49431
4166
4167         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
4168         * Scripts/webkitpy/layout_tests/layout_package/test_output.py: Added.
4169         * Scripts/webkitpy/layout_tests/port/base.py:
4170         * Scripts/webkitpy/layout_tests/port/chromium.py:
4171         * Scripts/webkitpy/layout_tests/port/dryrun.py:
4172         * Scripts/webkitpy/layout_tests/port/test.py:
4173         * Scripts/webkitpy/layout_tests/port/webkit.py:
4174         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4175         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
4176         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
4177         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
4178
4179 2010-11-17  Adam Roben  <aroben@apple.com>
4180
4181         Make each Windows Test builder use the same OS for all its slaves
4182
4183         Currently each WebKit1 Windows Test builder has one Windows XP slave
4184         and one Windows 7 slave. Having different OSes in a single builder
4185         meant that the builders would alternate between red and green when
4186         there were OS-specific failures.
4187
4188         Fixes <http://webkit.org/b/49688> Windows Test builders alternate
4189         between red and green because of multiple OS versions
4190
4191         Reviewed by Mark Rowe.
4192
4193         * BuildSlaveSupport/build.webkit.org-config/config.json: Renamed
4194         "Windows Release (Tests)" to "Windows 7 Release (Tests)", "Windows
4195         Debug (Tests)" to "Windows XP Debug (Tests)", and "Windows Release
4196         (WebKit2 Tests)" to "Windows 7 Release (WebKit2 Tests)". Updated the
4197         builders for the two WebKit1 builders so that they would all use the
4198         appropriate OS.
4199
4200 2010-11-17  James Robinson  <jamesr@chromium.org>
4201
4202         Reviewed by Dan Bernstein.
4203
4204         [chromium] Set minimum font size to 0 for DRT
4205         https://bugs.webkit.org/show_bug.cgi?id=49677
4206
4207         Followup for http://trac.webkit.org/changeset/72141.
4208
4209         Test: http/tests/misc/acid3.html
4210
4211         * DumpRenderTree/chromium/WebPreferences.cpp:
4212         (WebPreferences::reset):
4213
4214 2010-11-17  Andras Becsi  <abecsi@webkit.org>
4215
4216         Unreviewed build fix.
4217
4218         [Qt] Add missing file I forgot in r72220.
4219
4220         * MiniBrowser/MiniBrowser.qrc: Added.
4221
4222 2010-11-17  Andras Becsi  <abecsi@webkit.org>
4223
4224         Reviewed by Andreas Kling.
4225
4226         [Qt][WK2] Make it possible to set custom user agent strings in MiniBrowser.
4227         https://bugs.webkit.org/show_bug.cgi?id=49627
4228
4229         Add a user agent dialog and a resource file for useragentlist.txt to MiniBrowser.
4230
4231         * MiniBrowser/MiniBrowser.qrc: Added.
4232         Add it here to prevent qmake from detecting it
4233         since it needs to be copied to the build directory.
4234         * MiniBrowser/qt/BrowserWindow.cpp:
4235         (BrowserWindow::BrowserWindow):
4236         (BrowserWindow::updateUserAgentList):
4237         (BrowserWindow::showUserAgentDialog):
4238         * MiniBrowser/qt/BrowserWindow.h:
4239         * MiniBrowser/qt/MiniBrowser.pro:
4240
4241 2010-11-17  Adam Roben  <aroben@apple.com>
4242
4243         Make changes to the Mac WebKit2 Skipped file trigger Windows builds
4244
4245         We use that file on Windows!
4246
4247         Fixes <http://webkit.org/b/49643> Changes to
4248         LayoutTests/platform/mac-wk2 should trigger a Windows build, but don't
4249
4250         Reviewed by Steve Falkenburg.
4251
4252         * Scripts/webkitpy/common/config/build.py:
4253         (_should_file_trigger_build): Added the mac-wk2 directory and make it
4254         trigger builds on SnowLeopard and Windows.
4255
4256         * Scripts/webkitpy/common/config/build_unittest.py:
4257         (ShouldBuildTest.test_should_build): Added a test.
4258
4259 2010-11-17  Satish Sampath  <satish@chromium.org>
4260
4261         Reviewed by Jeremy Orlow.
4262
4263         Clear the speech input mock explicitly before each test.
4264         https://bugs.webkit.org/show_bug.cgi?id=49660
4265
4266         * DumpRenderTree/chromium/LayoutTestController.cpp:
4267         (LayoutTestController::setMockSpeechInputResult):
4268         * DumpRenderTree/chromium/LayoutTestController.h:
4269         * DumpRenderTree/chromium/WebViewHost.cpp:
4270         (WebViewHost::speechInputController):
4271         (WebViewHost::reset): Invoke speech input mock's clearResults method.
4272         * DumpRenderTree/chromium/WebViewHost.h:
4273         (WebViewHost::speechInputControllerMock): Moved mock from LayoutTestController.
4274
4275 2010-11-17  Alexander Pavlov  <apavlov@chromium.org>
4276
4277         Unreviewed, specify IRC nickname in committers.py.
4278
4279         * Scripts/webkitpy/common/config/committers.py:
4280
4281 2010-11-17  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
4282
4283         Reviewed by Tony Chang.
4284
4285         [NRWT] Make http locking similar to perl implementation
4286         https://bugs.webkit.org/show_bug.cgi?id=49187
4287
4288         * Scripts/webkitpy/common/system/file_lock.py: Added.
4289         * Scripts/webkitpy/common/system/file_lock_unittest.py: Added.
4290         * Scripts/webkitpy/layout_tests/port/http_lock.py:
4291
4292 2010-11-17  MORITA Hajime  <morrita@google.com>
4293
4294         Reviewed by Kent Tamura.
4295
4296         [Chromium][DRT] EventSender.contextClick() should aware spellchecking
4297         https://bugs.webkit.org/show_bug.cgi?id=49366
4298
4299         - EvenSender: Checked WebContextMenuData.misspelledWord and added extra context menu entries
4300           according to the spellchecker suggestion
4301         - MockSpellCheck: add fillSuggestionList to provide fake suggestions.
4302
4303         test_expectations.txt will be changed after this change is ported to test_shell.
4304         
4305         * DumpRenderTree/chromium/EventSender.cpp:
4306         (makeMenuItemStringsFor):
4307         (EventSender::contextClick):
4308         * DumpRenderTree/chromium/MockSpellCheck.cpp:
4309         (MockSpellCheck::fillSuggestionList):
4310         (MockSpellCheck::initializeIfNeeded):
4311         * DumpRenderTree/chromium/MockSpellCheck.h:
4312         * DumpRenderTree/chromium/WebViewHost.cpp:
4313         (WebViewHost::mockSpellCheck):
4314         * DumpRenderTree/chromium/WebViewHost.h:
4315
4316 2010-11-16  Dave Hyatt  <hyatt@apple.com>
4317
4318         Reviewed by Sam Weinig.
4319
4320         Make sure the pref for minimum font size is just explicitly set to 0 every time,
4321         since the bots have 1 stuck in their plist otherwise.
4322
4323         * DumpRenderTree/mac/DumpRenderTree.mm:
4324         (resetDefaultsToConsistentValues):
4325
4326 2010-11-16  Mihai Parparita  <mihaip@chromium.org>
4327
4328         Reviewed by Tony Chang.
4329
4330         Rebaseline server: compute diffs client-side
4331         https://bugs.webkit.org/show_bug.cgi?id=49640
4332         
4333         The image diff output from the DRT is pretty bad on some ports (at
4334         least the Mac one), so it's better to compute diffs on the client by
4335         using <canvas>.
4336
4337         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
4338         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
4339         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
4340
4341 2010-11-16  Mihai Parparita  <mihaip@chromium.org>
4342
4343         Reviewed by Tony Chang.
4344
4345         Rebaseline server: display test results
4346         https://bugs.webkit.org/show_bug.cgi?id=49626
4347         
4348         Adds basic result display to the rebaseline server. On the Python side
4349         this involves:
4350         - Parsing the unexpected_results.json into a dictionary.
4351         - Serving it as JSON under /results.json.
4352         (the JSON -> dict -> JSON transform isn't strictly necessary right now,
4353         but I'll need to have access to the parsed results on the Python side
4354         for follow-up changes).
4355         
4356         On the web UI side this adds:
4357         - Markup for display image and text results (expected, actual, diff),
4358           and JS for populating it.
4359         - Markup for breaking down test results by failure type and directory,
4360           and JS for populating it.
4361
4362         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
4363         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
4364         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
4365         * Scripts/webkitpy/tool/commands/data/rebaselineserver/util.js: Added.
4366         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
4367
4368 2010-11-16  Dirk Pranke  <dpranke@chromium.org>
4369
4370         Reviewed by Ojan Vafai.
4371
4372         See Chromium issue http://codereview.chromium.org/5133001/ - we
4373         are modifying the build bots to pass in the builder name with
4374         the "GPU" string appended instead of appending it in the code.
4375
4376         https://bugs.webkit.org/show_bug.cgi?id=49636
4377
4378         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
4379
4380 2010-11-16  Steve Falkenburg  <sfalken@apple.com>
4381
4382         Reviewed by Adam Roben.
4383
4384         Disable LTCG for Windows Release builds. Add new Release_LTCG configuration.
4385         https://bugs.webkit.org/show_bug.cgi?id=49632
4386
4387         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
4388         * DumpRenderTree/win/DumpRenderTree.vcproj:
4389         * DumpRenderTree/win/ImageDiff.vcproj:
4390         * MiniBrowser/MiniBrowser.vcproj:
4391         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
4392         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
4393         * WebKitTestRunner/win/InjectedBundle.vcproj:
4394         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
4395         * WinLauncher/WinLauncher.vcproj:
4396         * record-memory-win/record-memory-win.vcproj:
4397
4398 2010-11-16  Dirk Pranke  <dpranke@chromium.org>
4399
4400         Reviewed by Ojan Vafai.
4401
4402         new-run-webkit-tests: rename TestInfo to TestInput, move image hash to work thread
4403
4404         Rename the TestInfo class to TestInput to be clearer about its
4405         function, and move the checksum-reading code into dump_render_tree_thread
4406         to avoid cross-thread access.
4407
4408         https://bugs.webkit.org/show_bug.cgi?id=49573
4409
4410         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
4411         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4412         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
4413
4414 2010-11-16  Dave Hyatt  <hyatt@apple.com>
4415
4416         Fix bustage. Remove the minimum font size pref setting in DumpRenderTree.
4417
4418         * DumpRenderTree/mac/DumpRenderTree.mm:
4419         (resetDefaultsToConsistentValues):
4420
4421 2010-11-16  Stephanie Lewis  <slewis@apple.com>
4422
4423         Reviewed by Geoff Garen.
4424
4425         <rdar://problem/8624267> Leak creating offscreen webview running fast/dom tests
4426