2011-01-10 Maciej Stachowiak <mjs@apple.com>
[WebKit.git] / Tools / ChangeLog
1 2011-01-10  Maciej Stachowiak  <mjs@apple.com>
2
3         Reviewed by Anders Carlsson.
4
5         WebKitTestRunner uses crazy amounts of CPU, making layout tests slow and flaky
6         https://bugs.webkit.org/show_bug.cgi?id=52160
7
8         * WebKitTestRunner/mac/TestControllerMac.mm:
9         (WTR::TestController::platformRunUntil): Instead of busy-looping, wait for the timeout.
10         Anything that can make runUntil() conditions turn true will happen on a run loop cycle
11         anyway.
12
13 2011-01-10  Tony Chang  <tony@chromium.org>
14
15         Reviewed by Mihai Parparita.
16
17         [chromium] fix for animated gif layout tests
18         https://bugs.webkit.org/show_bug.cgi?id=52008
19
20         * DumpRenderTree/chromium/WebViewHost.cpp: Schedule a paint when we update the paint rect
21             to trigger gif animations.
22         (WebViewHostPaintTask::WebViewHostPaintTask):
23         (WebViewHostPaintTask::runIfValid):
24         (WebViewHost::updatePaintRect):
25         * DumpRenderTree/chromium/WebViewHost.h:
26         (WebViewHost::taskList):
27
28 2011-01-10  Alejandro G. Castro  <alex@igalia.com>
29
30         Reviewed by Xan Lopez.
31
32         [GTK] Fix gtk2 compilation for master
33         https://bugs.webkit.org/show_bug.cgi?id=51885
34
35         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
36         (createBitmapContextFromWebView): Replaced the old
37         gdk_drawable_get_size with gdk_pixmap_get_size.
38
39 2011-01-10  Patrick Gansterer  <paroga@webkit.org>
40
41         Reviewed by Laszlo Gombos.
42
43         [WINCE] Reenable NPAPI after r75203
44         https://bugs.webkit.org/show_bug.cgi?id=52109
45
46         Remove the !isWinCE() check for ENABLE_NETSCAPE_PLUGIN_API and replace
47         it with !isEfl(), because EFL port does not support NPAPI (yet).
48
49         * Scripts/build-webkit:
50
51 2011-01-10  Adam Roben  <aroben@apple.com>
52
53         Skip some asserting JS tests
54
55         See <http://webkit.org/b/52156>.
56
57         * Scripts/run-javascriptcore-tests:
58
59 2011-01-10  Martin Robinson  <mrobinson@igalia.com>
60
61         Reviewed by Xan Lopez.
62
63         [GTK] build-webkit disable Blob support via arguments passed to automake
64         https://bugs.webkit.org/show_bug.cgi?id=52097
65
66         * Scripts/build-webkit: Enable Blob support when building WebKitGTK+ via
67         build-webkit.
68
69 2011-01-10  Adam Roben  <aroben@apple.com>
70
71         Use the same name and description for TestNetscapePlugin on Windows and
72         Mac
73
74         Fixes <http://webkit.org/b/52151>
75         fast/frames/iframe-reparenting-plugins.html fails on Windows
76
77         Reviewed by Steve Falkenburg.
78
79         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Copied
80         the name and description from Mac's Info.plist.
81
82 2011-01-10  Siddharth Mathur <siddharth.mathur@nokia.com>
83
84         Reviewed by Laszlo Gombos.
85
86         [Qt][WK2] Guard gcc-specific syntax
87
88         Non-gcc based compliers choke on the "-include"
89         syntax for preinclude, place guard around it.
90
91         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
92         * WebKitTestRunner/qt/WebKitTestRunner.pro:
93
94 2011-01-10  Andreas Kling  <kling@webkit.org>
95
96         Reviewed by Simon Hausmann.
97
98         [Qt] [WK2] MiniBrowser does not load pages opened in new windows
99         https://bugs.webkit.org/show_bug.cgi?id=52111
100
101         When getting a createNewPage() callback from QWKPage, create the
102         new page with the same QWKContext as the page that is passed to
103         the callback.
104
105         * MiniBrowser/qt/BrowserView.h:
106         * MiniBrowser/qt/BrowserWindow.cpp:
107         (newPageFunction):
108         (BrowserWindow::BrowserWindow):
109         * MiniBrowser/qt/BrowserWindow.h:
110
111 2011-01-10  Andreas Kling  <kling@webkit.org>
112
113         Reviewed by Kenneth Rohde Christiansen.
114
115         [Qt] MiniBrowser: Remove superfluous createNewPage() callback
116
117         BrowserView set its own useless createNewPage() callback on QWKPage.
118         This was immediately overridden by BrowserWindow anyway, so remove
119         the BrowserView one.
120
121         * MiniBrowser/qt/BrowserView.cpp:
122         (BrowserView::BrowserView):
123
124 2011-01-10  John Knottenbelt  <jknotten@chromium.org>
125
126         Reviewed by Jeremy Orlow.
127
128         [Chromium] Remove non-client-based Geolocation code
129         https://bugs.webkit.org/show_bug.cgi?id=50921
130
131         * DumpRenderTree/chromium/LayoutTestController.cpp:
132         (LayoutTestController::setGeolocationPermission):
133         (LayoutTestController::setMockGeolocationPosition):
134         (LayoutTestController::setMockGeolocationError):
135         * DumpRenderTree/chromium/WebViewHost.cpp:
136         (WebViewHost::geolocationClientMock):
137         (WebViewHost::reset):
138         * DumpRenderTree/chromium/WebViewHost.h:
139
140 2011-01-10  Eric Seidel  <eric@webkit.org>
141
142         Reviewed by Adam Barth.
143
144         Commit bot tried to land r? cq+ patch
145         https://bugs.webkit.org/show_bug.cgi?id=36638
146
147         It should now be possible to post a patch with r? and cq+ and the
148         commit-queue will correctly wait for the r+ before attempting to land the patch.
149         (This was a feature requested by several users.)
150
151         One caveat: We don't actually reject r-, cq+ patches from the queue
152         (we just ignore them), but I think that's OK for now.
153
154         I also noticed that setting r- once a commit-queue node had grabbed
155         a patch would not properly cancel the landing.  That's fixed and
156         tested in this patch.
157
158         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
159         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
160         * Scripts/webkitpy/tool/bot/feeders.py:
161         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
162
163 2011-01-08  Benjamin Poulain  <benjamin.poulain@nokia.com>
164
165         Reviewed by Kenneth Rohde Christiansen.
166
167         [Qt] QtWebKit crashes when using XMLHttpRequest from the unload event
168         https://bugs.webkit.org/show_bug.cgi?id=51934
169
170         When accessing the network from the destructor of QWebPage, the network access manager
171         was already deleted because the object WebPage was already destructed.
172
173         This solve the problem by linking the lifetime of the network access manager to WebPage's QObject.
174         The object is now destructed in the destructor of QObject.
175
176         * QtTestBrowser/webpage.cpp:
177         (WebPage::WebPage):
178         (WebPage::setQnamThreaded):
179         * QtTestBrowser/webpage.h:
180         (QtNAMThread::QtNAMThread):
181
182 2011-01-08  Eric Seidel  <eric@webkit.org>
183
184         Reviewed by Ojan Vafai.
185
186         test_failures.py should not mention TestShell (long live DumpRenderTree!)
187         https://bugs.webkit.org/show_bug.cgi?id=52067
188
189         I ran test-webkitpy, but didn't bother adding a unit test for this string change.
190         https://bugs.webkit.org/show_bug.cgi?id=51138#c3 is an example of why this is needed.
191
192         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
193
194 2011-01-08  Eric Seidel  <eric@webkit.org>
195
196         Reviewed by Mihai Parparita.
197
198         commit-queue hangs when the ChangeLog diff is bad
199         https://bugs.webkit.org/show_bug.cgi?id=52072
200
201         * Scripts/webkitpy/tool/steps/validatechangelogs.py:
202         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
203
204 2011-01-08  Adam Barth  <abarth@webkit.org>
205
206         Teach svn-apply how to re-write WebCore to Source/WebCore.
207
208         * Scripts/VCSUtils.pm:
209
210 2011-01-07  Adam Barth  <abarth@webkit.org>
211
212         Rubber-stamped by Eric Seidel.
213
214         Move WebCore to Source
215         https://bugs.webkit.org/show_bug.cgi?id=52050
216
217         Update the tools to understand WebCore's new location.
218
219         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
220         * DumpRenderTree/wscript:
221         * GNUmakefile.am:
222         * Scripts/build-webkit:
223         * Scripts/do-file-rename:
224         * Scripts/do-webcore-rename:
225         * Scripts/generate-qt-inspector-resource:
226         * Scripts/prepare-ChangeLog:
227         * Scripts/run-bindings-tests:
228         * Scripts/update-iexploder-cssproperties:
229         * Scripts/update-sources-list.py:
230         * Scripts/update-webkit-localizable-strings:
231         * Scripts/webkitdirs.pm:
232         * Scripts/webkitpy/common/config/build.py:
233         * Scripts/webkitpy/common/config/build_unittest.py:
234         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
235         * Scripts/webkitpy/style/checker.py:
236         * Scripts/webkitpy/style/checker_unittest.py:
237         * WebKitTestRunner/DerivedSources.pro:
238         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
239         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh:
240         * wx/browser/wscript:
241         * wx/build/settings.py:
242
243 2011-01-07  Maciej Stachowiak  <mjs@apple.com>
244
245         Reviewed by Sam Weinig.
246
247         Make WebKitTestRunner rest between loads more robust to avoid test crashes
248         https://bugs.webkit.org/show_bug.cgi?id=52086
249
250         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
251         (WTR::InjectedBundle::didReceiveMessage):
252         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
253         (WTR::LayoutTestController::notifyDone):
254         * WebKitTestRunner/TestController.cpp:
255         (WTR::TestController::resetStateToConsistentValues):
256         (WTR::TestController::run):
257
258 2011-01-07  James Robinson  <jamesr@chromium.org>
259
260         Revert "Implement mozilla's animationTime property"
261         https://bugs.webkit.org/show_bug.cgi?id=51952
262
263         This approach isn't quite right.
264
265         * DumpRenderTree/chromium/WebViewHost.cpp:
266         (WebViewHost::paintInvalidatedRegion):
267
268 2011-01-07  Adam Roben  <aroben@apple.com>
269
270         Build master fix
271
272         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
273         (RunWebKitTests.start): Don't try to concatenate a list and a string.
274
275 2011-01-07  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>
276
277         Reviewed by Csaba Osztrogonác.
278
279         run-qtwebkit-tests should be able to kill a testsuite.
280
281         Add new option in the script that can setup a timeout for a test.
282         If the test execution takes more then specified time then the test
283         would be terminated.
284
285         [Qt] run-qtwebkit-tests needs timeout
286         https://bugs.webkit.org/show_bug.cgi?id=51894
287
288         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
289         * Scripts/run-qtwebkit-tests:
290
291 2011-01-07  Csaba Osztrogonác  <ossy@webkit.org>
292
293         Unreviewed fix after r75233.
294
295         Based on idea from Eric Seidel.
296
297         Add remote zip file handling to webkitpy.
298         https://bugs.webkit.org/show_bug.cgi?id=50901
299
300         * Scripts/webkitpy/common/system/fileset.py: Make python 2.5 happy.
301
302 2011-01-07  Shane Stephens  <shanestephens@google.com>
303
304         Reviewed by Eric Seidel.
305
306         svn-apply: should support git binary delta diffs
307         https://bugs.webkit.org/show_bug.cgi?id=38864
308
309         * Scripts/VCSUtils.pm:
310         * Scripts/svn-apply:
311
312 2011-01-06  Julie Parent  <jparent@chromium.org>
313
314         Reviewed by Eric Seidel.
315
316         Test Result Server not removing old results.
317         https://bugs.webkit.org/show_bug.cgi?id=52012
318
319         * TestResultServer/model/jsonresults.py:
320         Fix off-by-one: Truncate if >= num_runs, not just >.
321         * TestResultServer/model/jsonresults_unittest.py:
322         Add unit test to test that merging in a new result with the same value
323         as the last result causes previous result to fall off.
324
325 2011-01-06  James Kozianski  <koz@chromium.org>
326
327         Reviewed by Mihai Parparita.
328
329         Add classes to provide a consistent interface to a set of files.
330         https://bugs.webkit.org/show_bug.cgi?id=50901
331
332         These classes allow us to write code that is agnostic to whether a
333         particular set of files resides in a local directory or in a zip file
334         on a remote machine.
335
336         * Scripts/webkitpy/common/system/directoryfileset.py: Added.
337         * Scripts/webkitpy/common/system/directoryfileset_unittest.py: Added.
338         * Scripts/webkitpy/common/system/fileset.py: Added.
339         * Scripts/webkitpy/common/system/filesystem.py:
340         * Scripts/webkitpy/common/system/filesystem_mock.py:
341         * Scripts/webkitpy/common/system/zipfileset.py: Added.
342         * Scripts/webkitpy/common/system/zipfileset_unittest.py: Added.
343
344 2011-01-06  Eric Seidel  <eric@webkit.org>
345
346         Reviewed by Adam Barth.
347
348         NetworkTransaction should log the url it is retrying
349         https://bugs.webkit.org/show_bug.cgi?id=52043
350
351         * Scripts/webkitpy/common/net/networktransaction.py:
352         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
353
354 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
355
356         Windows build fix.
357         Import os before using it.
358
359         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
360
361 2011-01-06  Eric Seidel  <eric@webkit.org>
362
363         Reviewed by Adam Barth.
364
365         StyleQueue fails to report errors when patches have many files
366         https://bugs.webkit.org/show_bug.cgi?id=52042
367
368         This is one of at least two errors preventing style error reporting at the moment.
369         When we moved to passing the list of files to check explicitly,
370         we started to exceed the 500 character TEXT field limit for our AppEngine model object.
371         We could change the type of the QueueStatus.message type, or we could
372         just teach statusserver.py how to clamp values (and warn when it does).
373         I chose the latter path.
374
375         * Scripts/webkitpy/common/net/statusserver.py:
376
377 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
378
379         Reviewed by Stephanie Lewis.
380         
381         Fix syntax error in script.
382
383         Windows bots need to archive/unarchive builds to/from configuration-specific directories
384         https://bugs.webkit.org/show_bug.cgi?id=51996
385
386         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
387
388 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
389
390         Unreviewed, fixing WinCE build after r75196.
391
392         WinCE port does not (yet) support NPAPI.
393
394         * Scripts/build-webkit:
395
396 2011-01-06  Xan Lopez  <xlopez@igalia.com>
397
398         Reviewed by Darin Adler.
399
400         File::Spec->rel2abs in sunspider-compare-results mangles parameters
401         https://bugs.webkit.org/show_bug.cgi?id=52015
402
403         * Scripts/sunspider-compare-results: call rel2abs on our arguments
404         after the platform has been detected, otherwise the script will
405         mangle things like '--gtk' into '/a/path/--gtk', breaking the
406         detection.
407
408 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
409
410         Reviewed by Eric Seidel.
411
412         Add ENABLE_NETSCAPE_PLUGIN_API, ENABLE_ORIENTATION_EVENTS and ENABLE_TOUCH_EVENTS flags to build-webkit
413         https://bugs.webkit.org/show_bug.cgi?id=51346
414
415         * Scripts/build-webkit:
416
417 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
418
419         Reviewed by Adam Roben.
420
421         Windows bots need to archive/unarchive builds to/from configuration-specific directories
422         https://bugs.webkit.org/show_bug.cgi?id=51996
423         
424         After the configuration directory change, we were archiving the incorrect directory for
425         build product, so we were running tests on the wrong binaries.
426         
427         This change archives the correct directory, and also unarchives it into a configuration-
428         specific directory.
429
430         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Use a configuration-specific directory on Windows.
431         * BuildSlaveSupport/built-product-archive: Unarchive/archive to/from proper directory.
432
433 2011-01-06  Eric Seidel  <eric@webkit.org>
434
435         Reviewed by Mihai Parparita.
436
437         commit-queue mentions "Text diff mismatch" 4 times instead of once per failure
438         https://bugs.webkit.org/show_bug.cgi?id=52002
439
440         See an example of this here:
441         https://bugs.webkit.org/show_bug.cgi?id=51314#c2
442
443         It's due to the fact that we pass around TestFailure() instance
444         objects and yet expect them to all compare to be the same.
445
446         This is bad.  We should either have shared instances of these values
447         or we should just pass around the class names.  There are already hacks
448         in place to make TestFailure objects pass equality tests, I just added
449         a __hash__ implementation so they can be used in sets as expected.
450
451         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
452         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
453
454 2011-01-06  Evan Martin  <evan@chromium.org>
455
456         Reviewed by Tony Chang.
457
458         [gdb] handle inaccessible memory and UChar*
459         https://bugs.webkit.org/show_bug.cgi?id=52003
460
461         To pretty-print a UChar*, we just grope around in the memory
462         looking for a terminating NUL.  We need to handle the exception
463         that can occur when we poke into an invalid location.
464
465         Additionally, the logic for choosing which pretty-printer would
466         early return before hitting the point where we'd use the UChar*
467         printer.  (Did this ever work?  How did it regress?)
468
469         * gdb/webkit.py:
470
471 2011-01-05  Brian Weinstein  <bweinstein@apple.com>
472
473         Reviewed by Ada Chan.
474
475         WebKit2: Should be able to call into injected bundle to ask if we should allow resource loads
476         https://bugs.webkit.org/show_bug.cgi?id=51969
477         
478         Add shouldLoadResourceForFrame to WTR::InjectedBundlePage.
479
480         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
481         (WTR::InjectedBundlePage::InjectedBundlePage):
482         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Stub implementation.
483         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
484
485 2011-01-06  James Robinson  <jamesr@chromium.org>
486
487         Reviewed by Simon Fraser.
488
489         Implement mozilla's animationTime property
490         https://bugs.webkit.org/show_bug.cgi?id=51952
491
492         Chromium DRT support for webkitAnimationTime.
493
494         * DumpRenderTree/chromium/WebViewHost.cpp:
495         (WebViewHost::paintInvalidatedRegion):
496
497 2011-01-06  Julie Parent  <jparent@chromium.org>
498
499         Reviewed by Tony Chang.
500
501         Test Result Server always truncates number of results to JSON_RESULTS_MAX_BUILDS
502         https://bugs.webkit.org/show_bug.cgi?id=51217
503
504         * TestResultServer/model/jsonresults.py:
505         Pass num_runs through to _remove_items_over_max_number_of_builds, and use the value.
506         Adds missing documentation.
507         * TestResultServer/model/jsonresults_unittest.py:
508         Add unit test to test that truncation happens at smaller value than JSON_RESULTS_MAX_BUILDS.
509         Update test_merge to take a number of builds to truncate at.
510
511 2011-01-06  Adam Barth  <abarth@webkit.org>
512
513         Reviewed by Eric Seidel.
514
515         The EWS should log outside of the working directory
516         https://bugs.webkit.org/show_bug.cgi?id=51986
517
518         This patch prepare us for using git clean -x -d -f in the EWS wrapper
519         script, which will actually clean the working copy back to a pristine
520         state instead of leaving untracked directories and ignored files.
521
522         * Scripts/webkitpy/tool/commands/queues.py:
523         * Scripts/webkitpy/tool/commands/queues_unittest.py:
524
525 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
526
527         Windows build fix.
528         Back out attempted change to built-product-archive.
529
530         * BuildSlaveSupport/built-product-archive:
531
532 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
533
534         Windows build fix.
535         Include configuration name when unpacking a build archive.
536
537         Needed, since we split Windows build results into configuration-specific directories
538         under WebKitOutputDir.
539
540         * BuildSlaveSupport/built-product-archive:
541
542 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
543
544         Reviewed by Darin Adler.
545
546         Debug and Release builds on Windows clobber each other
547         https://bugs.webkit.org/show_bug.cgi?id=49185
548
549         Changes the structure of WebKitBuild build products directory so we
550         completely separate each build configuration into independent directories.
551         
552         Although we previously had per-configuration directories for obj, this change adds
553         per-configuration directories for bin, lib, obj, and include. Each configuration's
554         build products are stored within a directory inside of WebKitBuild.
555         
556         Most use of $(WebKitOutputDir) in the build files has been replaced by $(ConfigurationBuildDir),
557         defined in common.vsprops to be $(WebKitOutputDir)\$(ConfigurationName).
558
559         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops:
560         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd:
561         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd:
562         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
563         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd:
564         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd:
565         * DumpRenderTree/win/ImageDiffCommon.vsprops:
566         * DumpRenderTree/win/ImageDiffPostBuild.cmd:
567         * DumpRenderTree/win/ImageDiffPreBuild.cmd:
568         * FindSafari/FindSafari.vcproj:
569         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
570         * MiniBrowser/MiniBrowserPostBuild.cmd:
571         * MiniBrowser/MiniBrowserPreBuild.cmd:
572         * Scripts/webkitdirs.pm:
573         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
574         * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops:
575         * TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd:
576         * TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd:
577         * TestWebKitAPI/win/copy-resources.cmd:
578         * WebKitAPITest/WebKitAPITestCommon.vsprops:
579         * WebKitAPITest/WebKitAPITestPostBuild.cmd:
580         * WebKitAPITest/WebKitAPITestPreBuild.cmd:
581         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
582         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
583         * WebKitTestRunner/win/InjectedBundle.vcproj:
584         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops:
585         * WebKitTestRunner/win/InjectedBundlePostBuild.cmd:
586         * WebKitTestRunner/win/InjectedBundlePreBuild.cmd:
587         * WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd:
588         * WebKitTestRunner/win/WebKitTestRunnerPreBuild.cmd:
589         * WinLauncher/WinLauncherCommon.vsprops:
590         * WinLauncher/WinLauncherPostBuild.cmd:
591         * WinLauncher/WinLauncherPreBuild.cmd:
592
593 2011-01-05  Jan Erik Hanssen  <jhanssen@sencha.com>
594
595         Reviewed by Ariya Hidayat.
596
597         [Qt] TestNetscapePlugin doesn't link on OS X
598         https://bugs.webkit.org/show_bug.cgi?id=51948
599
600         Only add a dependency on libX11 on X11 systems
601
602         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
603
604 2011-01-05  Jeff Miller  <jeffm@apple.com>
605
606         Reviewed by Adam Roben.
607
608         check-webkit-style should allow unnecessary parameter names in WebKit2 APIs because we're matching CF's header style
609         https://bugs.webkit.org/show_bug.cgi?id=51970
610
611         * Scripts/webkitpy/style/checker.py:
612         Add -readability/naming for WebKit2 C API directories.
613
614 2011-01-05  Eric Seidel  <eric@webkit.org>
615
616         Unreviewed, just fixing one more log error from my previous python patch.
617
618         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
619         https://bugs.webkit.org/show_bug.cgi?id=51802
620
621         webkit-patch failure-reason was logging about parsing errors
622         due to my misunderstanding of how BeautifulSoup.findAll worked.
623
624         Fixed, and added a unit test.
625
626         * Scripts/webkitpy/common/net/layouttestresults.py:
627         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
628
629 2011-01-05  Benjamin Poulain  <benjamin.poulain@nokia.com>
630
631         Reviewed by Kenneth Rohde Christiansen.
632
633         [Qt] [WK2] Add the possibility to open window from the WebProcess in Minibrowser
634         https://bugs.webkit.org/show_bug.cgi?id=51951
635
636         Set a function to QWKPage::setCreateNewPageFunction() in Minibrowser so there is a way
637         to create new window from WebKit.
638
639         * MiniBrowser/qt/BrowserWindow.cpp:
640         (newPageFunction):
641         (BrowserWindow::BrowserWindow):
642         (BrowserWindow::page): Added to avoid the indirect access to QWKPage spread in the class
643         (BrowserWindow::newWindow):
644         (BrowserWindow::updateUserAgentList):
645         (BrowserWindow::showUserAgentDialog):
646         * MiniBrowser/qt/BrowserWindow.h: Add the global variable backingStoreTypeForNewWindow to
647         define the type of the backing store used for new windows.
648         * MiniBrowser/qt/main.cpp:
649         (main):
650
651 2011-01-05  Eric Seidel  <eric@webkit.org>
652
653         Reviewed by Ojan Vafai.
654
655         commit-queue should report failure type when reporting flaky tests
656         https://bugs.webkit.org/show_bug.cgi?id=51900
657
658         This patch was a ridiculous amount of plumbing.  In the end I like
659         the NRWT-style TestResult class even less.  But now we're passing
660         a list of TestResult objects from the queue to the FlakyTestReporter.
661         Thus the FlakyTestReporter can more easily report what type of failure
662         occurred.
663
664         In the process, I found that I was not alone in finding TestResult
665         cumbersome to use.  A bunch of code was trying to create a TestResult
666         object with default values.  However since the constructor didn't make
667         this easy, some places were getting it wrong (including the TestResult unit test)!
668         I've fixed the TestResult constructor to have default values for non-essential
669         arguments.
670
671         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
672         * Scripts/webkitpy/common/net/layouttestresults.py:
673         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
674         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
675         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
676         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
677         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
678         * Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py:
679         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
680         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
681         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
682         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
683         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
684         * Scripts/webkitpy/tool/commands/queues.py:
685         * Scripts/webkitpy/tool/commands/queues_unittest.py:
686
687 2011-01-05  Eric Seidel  <eric@webkit.org>
688
689         Unreviewed.
690
691         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
692         https://bugs.webkit.org/show_bug.cgi?id=51802
693
694         Add another unit test to cover a previously missing import.
695
696         * Scripts/webkitpy/common/net/layouttestresults.py:
697         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
698
699 2011-01-05  Mihai Parparita  <mihaip@chromium.org>
700
701         Reviewed by David Levin.
702
703         Add mihaip@chromium.org as a reviewer
704         https://bugs.webkit.org/show_bug.cgi?id=51966
705         
706         Add myself as a reviewer.
707
708         * Scripts/webkitpy/common/config/committers.py:
709
710 2011-01-05  James Simonsen  <simonjam@chromium.org>
711
712         Unreviewed. Adding myself to the list of committers.
713
714         * Scripts/webkitpy/common/config/committers.py:
715
716 2011-01-05  Eric Seidel  <eric@webkit.org>
717
718         Unreviewed.
719
720         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
721         https://bugs.webkit.org/show_bug.cgi?id=51802
722
723         Fix two exceptions seen on the bots after my original commit.
724
725         * Scripts/webkitpy/common/net/layouttestresults.py:
726         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
727
728 2011-01-05  Kundu Suchismita  <suchi.kundu@nokia.com>
729
730         Reviewed by Andreas Kling.
731
732         [Qt]Add local storage settings to QtTestBrowser command line arguments 
733         https://bugs.webkit.org/show_bug.cgi?id=51750
734
735         * QtTestBrowser/main.cpp:
736         (LauncherApplication::handleUserOptions):
737          Local storage settings can be enable form command line arguments for
738          QtTestBrowser.
739
740 2011-01-05  Chris Fleizach  <cfleizach@apple.com>
741
742         Reviewed by Martin Robinson.
743
744         GTK: AX: DRT needs to use correct root object method.
745         https://bugs.webkit.org/show_bug.cgi?id=51911
746
747         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
748         (AccessibilityController::rootElement):
749
750 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
751
752         Rubber-stamped by Csaba Osztrogonác.
753
754         Based on idea from Péter Gál.
755
756         * Scripts/webkitpy/tool/bot/sheriff.py: Remove unnecessary apostrophes around revision numbers.
757
758 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
759
760         Reviewed by Adam Barth.
761
762         sheriff-bot should be able to do multi-revision rollouts
763         https://bugs.webkit.org/show_bug.cgi?id=51176
764
765         * Scripts/webkitpy/tool/bot/irc_command.py:
766         * Scripts/webkitpy/tool/bot/sheriff.py:
767         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
768
769 2011-01-05  Eric Seidel  <eric@webkit.org>
770
771         Reviewed by Adam Barth.
772
773         queues.webkit.org should have per-bot status pages
774         https://bugs.webkit.org/show_bug.cgi?id=51906
775
776         Just adds a /queue-status/QUEUE_NAME/bots/BOT_ID page to show
777         statuses from a single queue.  Now that we have many bots servicing
778         some queues (commit-queue, win-ews, etc.) its easy to have the messages
779         you care about scroll off the end of the 15-message limit on the main page.
780
781         Eventually we should probably rename /queue-status to /queue or /queues,
782         but that's fodder for another patch.
783
784         * QueueStatusServer/handlers/queuestatus.py:
785         * QueueStatusServer/index.yaml:
786         * QueueStatusServer/main.py:
787         * QueueStatusServer/templates/includes/singlequeuestatus.html:
788          - This probably should use a custom filter instead of hard-coding
789            the URL scheme here, but I couldn't figure out how to easily
790            create such a filter.  Most filters work with "strings" so we can't
791            pass the status object.  We could add a method to the status
792            object and call that, but that seemed a bit strange too.
793         * QueueStatusServer/templates/queuestatus.html:
794
795 2011-01-05  Carlos Garcia Campos  <cgarcia@igalia.com>
796
797         Unreviewed. Adding myself to the list of committers.
798
799         * Scripts/webkitpy/common/config/committers.py:
800
801 2011-01-04  Koan-Sin Tan  <koansin.tan@gmail.com>
802
803         Reviewed by David Levin.
804
805         check-webkit-style treated some macros with parentheses after #elif as function calls
806         https://bugs.webkit.org/show_bug.cgi?id=51695
807
808         Ingore function call space checking in any preprocessor directives
809         (things starting with #). Change search() to match() because 
810         preprocessor directives are supposed to be in the beginning of lines.
811
812         * Scripts/webkitpy/style/checkers/cpp.py:
813         * Scripts/webkitpy/style/checkers/cpp_unittest.py: make sure there is no false positives for #elif cases
814
815 2011-01-04  Søren Gjesse  <sgjesse@chromium.org>
816
817         Reviewed by Tony Chang.
818
819         Change the --multi-load test option to --stress-opt
820         https://bugs.webkit.org/show_bug.cgi?id=50751
821
822         * DumpRenderTree/chromium/DumpRenderTree.cpp:
823         (runTest):
824         (main):
825         * DumpRenderTree/chromium/TestShell.cpp:
826         (TestShell::TestShell):
827         * DumpRenderTree/chromium/TestShell.h:
828         (TestShell::stressOpt):
829         (TestShell::setStressOpt):
830         (TestShell::stressDeopt):
831         (TestShell::setStressDeopt):
832         (TestShell::javaScriptFlags):
833         (TestShell::setJavaScriptFlags):
834         * Scripts/webkitpy/layout_tests/port/chromium.py:
835         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
836
837 2011-01-04  Chris Fleizach  <cfleizach@apple.com>
838
839         Reviewed by Sam Weinig.
840
841         WK2: Support Accessibility
842         https://bugs.webkit.org/show_bug.cgi?id=51859
843
844         Use rootObject() method to get top of accessibility tree.
845
846         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
847         (AccessibilityController::focusedElement):
848         (AccessibilityController::rootElement):
849
850 2011-01-03  Martin Robinson  <mrobinson@igalia.com>
851
852         Reviewed by Darin Adler.
853
854         Remove the last non-GObject usage of PlatformRefPtr and move the code to GRefPtr
855         https://bugs.webkit.org/show_bug.cgi?id=51846
856
857         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: Change usage of PlatformRefPtr
858         back to GRefPtr.
859
860 2011-01-04  Zhe Su  <suzhe@chromium.org>
861
862         Reviewed by Kenneth Russell.
863
864         Fix insertText, setMarkedText and unmarkText methods of
865         TextInputController to call corresponding methods of WebKit::WebView
866         rather than WebKit::WebFrame. This change matches the behavior of
867         chromium browser.
868         insertText corresponds to WebView::confirmComposition(text)
869         setMarkedText corresponds to WebView::setComposition(...)
870         unmarkText corresponds to WebView::confirmComposition()
871         https://bugs.webkit.org/show_bug.cgi?id=51693
872
873         * DumpRenderTree/chromium/TextInputController.cpp:
874         (TextInputController::insertText):
875         (TextInputController::setMarkedText):
876         (TextInputController::unmarkText):
877
878 2011-01-04  Dihan Wickremasuriya  <dihan.wickremasuriya@nokia.com>
879
880         Reviewed by Laszlo Gombos.
881
882         [Qt] [Symbian] Do not remove 0 byte sized files from productDir
883
884         On Symbian productDir points to the source directory. Removing all the
885         empty files from the productDir directory corrupts the svn repository.
886
887         * Scripts/build-webkit:
888
889 2011-01-03  Yi Shen  <yi.4.shen@nokia.com>
890
891         Reviewed by Adam Barth.
892
893         [Qt] Add SelectAll option to the context menu for the editor
894         https://bugs.webkit.org/show_bug.cgi?id=50049
895
896         Set shortcut for the SelectAll action.
897
898         * QtTestBrowser/mainwindow.cpp:
899         (MainWindow::buildUI):
900
901 2011-01-03  David Levin  <levin@chromium.org>
902
903         Reviewed by Eric Seidel.
904
905         check-webkit-style shouldn't consider "value" automatically to be a meaningless name.
906         https://bugs.webkit.org/show_bug.cgi?id=51842
907
908         * Scripts/webkitpy/style/checkers/cpp.py: Remove the check for value.
909         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Remove the test for value.
910
911 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
912
913         Reviewed by David Kilzer.
914
915         [WINCE] Adds a build slave.
916         https://bugs.webkit.org/show_bug.cgi?id=50523
917
918         * BuildSlaveSupport/build.webkit.org-config/config.json: Add an
919         entry for a release build of the WinCE port.
920         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add platform
921         flag to build the WinCE port.
922
923 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
924
925         Reviewed by David Kilzer.
926
927         Add WinCE support to build-webkit
928         https://bugs.webkit.org/show_bug.cgi?id=51642
929
930         * Scripts/build-webkit:
931         * Scripts/webkitdirs.pm:
932
933 2011-01-03  Eric Seidel  <eric@webkit.org>
934
935         Reviewed by Adam Barth.
936
937         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
938         https://bugs.webkit.org/show_bug.cgi?id=51802
939
940         I'm not the biggest fan of the test_failures or test_results classes,
941         but it's better to have one shared set of classes, than separate ones
942         for new vs. old run-webkit-test result handling.
943
944         This moves the ORWT results class "LayoutTestResults" over to using
945         TestResult and TestFailure classes, making it easy for us to
946         make all our sheriff-bot and other webkitpy code NRWT ready.
947
948         This also makes it a trivial patch to generate results.json information
949         from ORWT results.html files (for flaky test analysis, etc.) as well
950         as making it a one-liner to report test failure types when the
951         commit-queue sees flaky tests.
952
953         This patch tried not to add new functionality, but only to replace
954         the guts of LayoutTestResults, while adding unit tests and hoping
955         not to break anything.
956
957         I also moved callers which assumed User.prompt* were static/class methods
958         to using them as instance methods (since we'll eventually want to make them such).
959
960         In the process of re-writing things, I broke the rebaseline command, so I wrote
961         a unit test to catch my breakage were I do do so again in the future.
962
963         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
964         * Scripts/webkitpy/common/net/layouttestresults.py:
965         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
966         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
967         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
968         * Scripts/webkitpy/tool/commands/queries.py:
969         * Scripts/webkitpy/tool/commands/rebaseline.py:
970         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
971         * Scripts/webkitpy/tool/mocktool.py:
972
973 2011-01-03  Adam Barth  <abarth@webkit.org>
974
975         Reviewed by Simon Fraser.
976
977         webkit-patch shouldn't waste time cleaning a working directory that's already clean
978         https://bugs.webkit.org/show_bug.cgi?id=51840
979
980         * Scripts/webkitpy/common/checkout/scm.py:
981
982 2011-01-03  Adam Barth  <abarth@webkit.org>
983
984         Reviewed by Simon Fraser.
985
986         webkit-patch should only hide update output if --quiet
987         https://bugs.webkit.org/show_bug.cgi?id=51838
988
989         As requested by smfr.
990
991         * Scripts/webkitpy/tool/steps/update.py:
992
993 2011-01-03  Adam Barth  <abarth@webkit.org>
994
995         Reviewed by David Levin.
996
997         commit-queue shouldn't reject patches twice if two bots process the same patch
998         https://bugs.webkit.org/show_bug.cgi?id=51805
999
1000         Before raising an error, we first check whether the patch is still in
1001         the commit-queue.  This check is still racy, of course, but the time
1002         window is much smaller.
1003
1004         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1005
1006 2011-01-03  Sam Weinig  <sam@webkit.org>
1007
1008         Reviewed by Anders Carlsson.
1009
1010         Make run-api-tests less chatty.
1011         https://bugs.webkit.org/show_bug.cgi?id=51831
1012
1013         - Make script quiet by default and add --verbose option (replacing --quiet).
1014         - When not verbose, pipe stdout and stderr to devnull.
1015
1016         * Scripts/run-api-tests:
1017
1018 2011-01-03  Pratik Solanki  <psolanki@apple.com>
1019
1020         Unreviewed. Adding myself to committers.py.
1021
1022         * Scripts/webkitpy/common/config/committers.py:
1023
1024 2011-01-03  Koan-Sin Tan  <koansin.tan@gmail.com>
1025
1026         Reviewed by Xan Lopez.
1027
1028         "Tool/Scripts/run-launcher --gtk" stopped working after 74855
1029         https://bugs.webkit.org/show_bug.cgi?id=51806
1030
1031         Originally, the $libraryName is 'JavaScriptCore'. When building release 
1032         one, the $libraryDir was 'WebKitBuild/Release/JavaScriptCore/../.libs/'
1033         which doesn't exist anymore ('WebKitBuild/Release/JavaScriptCore'
1034         is 'WebKitBuild/Release/Source/JavaScriptCore' now), and 
1035         'WebKitBuild/Release/Source/JavaScriptCore/../../.libs' looks weird,
1036         so make it 'WebKitBuild/Release/.libs'
1037
1038         * Scripts/webkitdirs.pm: 
1039
1040 2011-01-02  Patrick Gansterer  <paroga@webkit.org>
1041
1042         Reviewed by Adam Barth.
1043
1044         Make EFL a core builder
1045         https://bugs.webkit.org/show_bug.cgi?id=51804
1046
1047         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1048         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1049
1050 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
1051
1052         [Qt] Unreviewed fix after r74855 and r74875.
1053
1054         * BuildSlaveSupport/built-product-archive:
1055          - Create directories explicitly.
1056          - Pass shell=True to subprocess.call().
1057
1058 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
1059
1060         [Qt] Unreviewed fix after r74855.
1061
1062         Move JavaScriptCore to Source
1063         https://bugs.webkit.org/show_bug.cgi?id=51604
1064
1065         * BuildSlaveSupport/built-product-archive: JavaScriptCore -> Source/JavaScriptCore
1066
1067 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
1068
1069         [Qt] Unreviewed run-javasriptcore-tests fix after r74855.
1070
1071         Move JavaScriptCore to Source
1072         https://bugs.webkit.org/show_bug.cgi?id=51604
1073
1074         * Scripts/webkitdirs.pm:
1075
1076 2011-01-02  Robert Hogan  <robert@webkit.org>
1077
1078         Unreviewed, build fix.
1079
1080         [Qt] Fix DRT build after 74855
1081
1082         * DumpRenderTree/qt/DumpRenderTree.pro:
1083
1084 2011-01-01  Adam Barth  <abarth@webkit.org>
1085
1086         Remove the assumption from the Qt and Gtk builds that every project is
1087         in the root directory.
1088
1089         * Scripts/build-webkit:
1090
1091 2011-01-01  Adam Barth  <abarth@webkit.org>
1092
1093         Reviewed by Eric Seidel.
1094
1095         Teach svn-apply how to apply patches even though JavaScriptCore has moved
1096         https://bugs.webkit.org/show_bug.cgi?id=51796
1097
1098         After this change, svn-apply will magically apply patches to
1099         JavaScriptCore/foo to Source/JavaScriptCore/foo.
1100
1101         * Scripts/VCSUtils.pm:
1102
1103 2011-01-01  Adam Barth  <abarth@webkit.org>
1104
1105         Reviewed by Eric Seidel.
1106
1107         Move JavaScriptCore to Source
1108         https://bugs.webkit.org/show_bug.cgi?id=51604
1109
1110         Update references to JavaScriptCore to point to the new location.
1111
1112         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1113         * DumpRenderTree/qt/DumpRenderTree.pro:
1114         * DumpRenderTree/qt/ImageDiff.pro:
1115         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1116         * DumpRenderTree/wscript:
1117         * Scripts/build-jsc:
1118         * Scripts/build-webkit:
1119         * Scripts/do-file-rename:
1120         * Scripts/do-webcore-rename:
1121         * Scripts/run-javascriptcore-tests:
1122         * Scripts/update-javascriptcore-test-results:
1123         * Scripts/webkitdirs.pm:
1124         * Scripts/webkitpy/common/config/build_unittest.py:
1125         * Scripts/webkitpy/style/checker.py:
1126         * Scripts/webkitpy/style/checker_unittest.py:
1127         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1128         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1129         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1130         * wx/build/settings.py:
1131
1132 2011-01-01  Adam Barth  <abarth@webkit.org>
1133
1134         Reviewed by Eric Seidel.
1135
1136         Move Sources to Source
1137         https://bugs.webkit.org/show_bug.cgi?id=51794
1138
1139         Update scripts to point to the new location.
1140
1141         * Scripts/build-webkit:
1142         * Scripts/do-file-rename:
1143         * Scripts/do-webcore-rename:
1144         * Scripts/webkitpy/common/config/build.py:
1145         * Scripts/webkitpy/common/config/build_unittest.py:
1146
1147 2010-12-31  Kent Tamura  <tkent@chromium.org>
1148
1149         Reviewed by Eric Seidel.
1150
1151         [DRT/Chromium] Enable mock spell checker on non-OSX
1152         https://bugs.webkit.org/show_bug.cgi?id=51401
1153
1154         * DumpRenderTree/chromium/WebViewHost.cpp:
1155         (WebViewHost::spellCheck):
1156
1157 2010-12-31  Adam Barth  <abarth@webkit.org>
1158
1159         Reviewed by Ariya Hidayat.
1160
1161         Remove Tools/Scripts/wkstyle
1162         https://bugs.webkit.org/show_bug.cgi?id=51774
1163
1164         This script appears to not have been touched in a while and seems to
1165         have been replaced by check-webkit-style.
1166
1167         * Scripts/wkstyle: Removed.
1168
1169 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
1170
1171         Unreviewed. Coding style fix.
1172
1173         * DumpRenderTree/chromium/TestShell.h:
1174
1175 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
1176
1177         Reviewed by Pavel Feldman.
1178
1179         Web Inspector: [Chromium] Inspector's tests are very slow on Win(Dbg).
1180
1181         It was a problem with Chromium DRT. DevToolsAgent object instance was
1182         attached not only to the inspected page but to the DevTools window too.
1183         As result all the inspector files were interpreted as a content of inspected page
1184         and were transfered to the DevTools scripts panel for debugging etc.
1185
1186         https://bugs.webkit.org/show_bug.cgi?id=51735
1187
1188         * DumpRenderTree/chromium/TestShell.cpp:
1189         (TestShell::TestShell):
1190         (TestShell::bindJSObjectsToWindow):
1191         (TestShell::createNewWindow):
1192         * DumpRenderTree/chromium/TestShell.h:
1193
1194 2010-12-31  Adam Barth  <abarth@webkit.org>
1195
1196         Rubber-stamped by Eric Seidel.
1197
1198         Move PageLoadTests to PerformanceTests/PageLoad
1199         https://bugs.webkit.org/show_bug.cgi?id=51771
1200
1201         Update references to PageLoadTests to point to the new location.
1202
1203         * Scripts/run-pageloadtest:
1204         * Scripts/webkitpy/common/config/build.py:
1205
1206 2010-12-31  Adam Barth  <abarth@webkit.org>
1207
1208         Rubber-stamped by Eric Seidel.
1209
1210         Move SunSpider into PerformanceTests
1211         https://bugs.webkit.org/show_bug.cgi?id=51769
1212
1213         Update these scripts to point to the new location.
1214
1215         * Scripts/run-sunspider:
1216         * Scripts/sunspider-compare-results:
1217
1218 2010-12-30  Mihai Parparita  <mihaip@chromium.org>
1219
1220         Reviewed by Kent Tamura.
1221
1222         [Chromium] Add WebThemeEngineDRTMac so that Chromium DRT scrollbar rendering can match the Mac port's
1223         https://bugs.webkit.org/show_bug.cgi?id=51728
1224         
1225         Add implementation of the Mac WebThemeEngine that uses an NSScroller
1226         to render top-level scrollbars. This makes them match the Mac port's
1227         use of an NSScrollView, which means that we'll be able to share more
1228         pixel baselines.
1229         
1230         The new rendering code will not be activated until the 
1231         USE_WEB_THEME_ENGINE_TO_PAINT_THUMB #define is fliped in
1232         ScrollbarThemeChromiumMac.
1233
1234         * DumpRenderTree/DumpRenderTree.gypi:
1235         * DumpRenderTree/chromium/TestShellMac.mm:
1236         (platformInit):
1237         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Added.
1238         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Added.
1239         (+[FakeActiveWindow alwaysActiveWindow]):
1240         (+[FakeActiveWindow alwaysInactiveWindow]):
1241         (-[FakeActiveWindow initWithActiveControls:]):
1242         (-[FakeActiveWindow _hasActiveControls]):
1243         (WebThemeEngineDRTMac::paintScrollbarThumb):
1244         (stateToHIEnableState):
1245         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
1246         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
1247
1248 2010-12-30  Konstantin Tokarev  <annulen@yandex.ru>
1249
1250         Reviewed by David Kilzer.
1251
1252         [Qt] Don't build wtf/TCSystemAlloc.cpp if --system-malloc option is
1253         used
1254         https://bugs.webkit.org/show_bug.cgi?id=51672
1255
1256         * DumpRenderTree/qt/DumpRenderTree.pro: Replaced USE_SYSTEM_MALLOC
1257         with USE_SYSTEM_MALLOC=1
1258         * WebKitTestRunner/qt/WebKitTestRunner.pro: Replaced USE_SYSTEM_MALLOC
1259         with USE_SYSTEM_MALLOC=1
1260
1261 2010-12-30  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1262
1263         Reviewed by David Kilzer.
1264
1265         [Qt] [Symbian] Fix build-webkit script for Symbian
1266         https://bugs.webkit.org/show_bug.cgi?id=51509
1267
1268         Set the OUTPUT_DIR for Symbian to be the same as the source
1269         directory.
1270
1271         * Scripts/webkitdirs.pm:
1272
1273 2010-12-30  Martin Robinson  <mrobinson@igalia.com>
1274
1275         Reviewed by Darin Adler.
1276
1277         check-webkit-style should ignore NULL usage in calls to gtk_widget_style_get
1278         https://bugs.webkit.org/show_bug.cgi?id=51758
1279
1280         Add a check-webkit-style exception for gtk_widget_style_get and NULL usage.
1281
1282         * Scripts/webkitpy/style/checkers/cpp.py: Add the exception.
1283         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Add some tests for this.
1284
1285 2010-12-29  Patrick Gansterer  <paroga@webkit.org>
1286
1287         Unreviewed WinCE buildfix.
1288
1289         * WinCELauncher/main.cpp: Add missing include.
1290
1291 2010-12-29  Daniel Bates  <dbates@rim.com>
1292
1293         Reviewed by Darin Adler.
1294
1295         svn-apply updates date of wrong change log entry for a change log diff that
1296         contains two consecutive entries with the same author and date
1297         https://bugs.webkit.org/show_bug.cgi?id=46061
1298
1299         Fixes an issue where the date of the wrong change log entry may be modified.
1300         Moreover, changes fixChangeLogPatch() to move entries inserted earlier
1301         in a ChangeLog file to the top of the file.
1302
1303         Currently, fixChangeLogPatch() explicitly bails out and returns an unchanged
1304         diff when it detects that the diff inserts a change log entry earlier in a
1305         ChangeLog. It is unusual to land a patch that has such a deliberate ChangeLog
1306         change. With the advent of the commit-queue this functionality of bailing out
1307         and hence landing the patch as-is is harmful to the accuracy of the ChangeLog.
1308         Instead, we should always move the change log entry to the top of the ChangeLog file.
1309
1310         A side-effect of this change is that setChangeLogDateAndReviewer() now updates
1311         the date line of the correct change log entry in a ChangeLog diff.
1312
1313         * Scripts/VCSUtils.pm: Modified fixChangeLogPatch() to move entries inserted earlier to the top.
1314
1315         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
1316           Updated the following unit tests now that we move entries inserted earlier to the top:
1317           - "fixChangeLogPatch: New entry inserted in middle."
1318             (formerly named "fixChangeLogPatch: [no change] New entry inserted in middle.")
1319
1320           - "fixChangeLogPatch: New entry inserted earlier in the file, but after an entry with the same author and date."
1321             (formerly named "fixChangeLogPatch: [no change] New entry inserted earlier in the file, but after an entry with the same author and date.")
1322
1323         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatchThenSetChangeLogDateAndReviewer.pl: Added.
1324
1325 2010-12-29  Konstantin Tokarev  <annulen@yandex.ru>
1326
1327         Reviewed by Eric Seidel.
1328
1329         [Qt] Fixed compatibility with gold linker on X11 platforms
1330         https://bugs.webkit.org/show_bug.cgi?id=51700
1331
1332         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1333         Linked TestNetscapePlugin with libX11 on Unix platforms
1334
1335 2010-12-29  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>
1336
1337         Reviewed by Darin Adler.
1338
1339         Circular dependency in webkitpy.common.checkout.changelog module
1340         https://bugs.webkit.org/show_bug.cgi?id=50475
1341
1342         Remove automatic import of api.Checkout module when any checkout/
1343         submodule is imported (e.g.: when checkout.scm.Git is imported).
1344
1345         * Scripts/webkitpy/common/checkout/__init__.py:
1346
1347 2010-12-29  Martin Robinson  <mrobinson@igalia.com>
1348
1349         Reviewed by Ojan Vafai.
1350
1351         prepare-ChangeLog should support the -g option for specifying the git-commit
1352         https://bugs.webkit.org/show_bug.cgi?id=51708
1353
1354         Add a -g shortcut for the --git-commit prepare-ChangeLog option. This matches
1355         webkit-patch, though the exact meaning of the two options remain different.
1356
1357         * Scripts/prepare-ChangeLog: Add -g.
1358
1359 2010-12-29  Kent Hansen  <kent.hansen@nokia.com>
1360
1361         Reviewed by Simon Hausmann.
1362
1363         [Qt] Fix compilation with Qt in namespace
1364         https://bugs.webkit.org/show_bug.cgi?id=51701
1365
1366         * QtTestBrowser/webview.h:
1367
1368 2010-12-28  Daniel Bates  <dbates@rim.com>
1369
1370         Reviewed by Sam Weinig.
1371
1372         Substitute // MARK: for compiler-specific #pragma mark
1373         https://bugs.webkit.org/show_bug.cgi?id=51657
1374
1375         Fix future compilation warnings about "#pragma mark" on GTK+ bots by
1376         substituting  "// MARK:" for "#pragma mark", which provides
1377         analogous code-bookmarking functionality under Xcode.
1378
1379         Also, for consistency, we should substitute "// MARK:" for compiler-
1380         specific "#pragma mark" in the source files for the Mac port.
1381
1382         * DumpRenderTree/AccessibilityTextMarker.cpp:
1383         * DumpRenderTree/cf/WebArchiveDumpSupport.h:
1384         * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm:
1385         * DumpRenderTree/mac/ObjCController.m:
1386         * MiniBrowser/mac/AppDelegate.m:
1387         * MiniBrowser/mac/BrowserWindowController.m:
1388
1389 2010-12-28  Xan Lopez  <xlopez@igalia.com>
1390
1391         Reviewed by Eric Seidel.
1392
1393         Add --no-build option to run-sunspider
1394         https://bugs.webkit.org/show_bug.cgi?id=51658
1395
1396         * Scripts/run-sunspider: add --no-build flag to skip building
1397         phase.
1398
1399 2010-12-27  Daniel Bates  <dbates@rim.com>
1400
1401         Rubber-stamped by Martin Robinson.
1402
1403         Append the directory Tools/DumpRenderTree to the list of directories that
1404         do-webcore-rename should search so that it can rename DRT files and
1405         source code.
1406
1407         * Scripts/do-webcore-rename:
1408
1409 2010-12-27  Eric Seidel  <eric@webkit.org>
1410
1411         Reviewed by Adam Barth.
1412
1413         build-webkit should detect missing Java SDK and explain how to install it
1414         https://bugs.webkit.org/show_bug.cgi?id=51651
1415
1416         * Scripts/build-webkit:
1417
1418 2010-12-26  Martin Robinson  <mrobinson@igalia.com>
1419
1420         Reviewed by Daniel Bates.
1421
1422         [GTK] Add support for build-jsc
1423         https://bugs.webkit.org/show_bug.cgi?id=51625
1424
1425         Add GTK+ support to build-jsc now that building the jsc executable as
1426         a standalone target is easy.
1427
1428         * Scripts/build-jsc: Call buildGtkProject for the GTK+ case now.
1429         * Scripts/build-webkit: Pass in the proper target name to buildGtkProject.
1430         * Scripts/webkitdirs.pm: Actually process the project parameter in buildGtkProject
1431         and pass it along to buildAutotoolsProject.
1432
1433 2010-12-27  David Levin  <levin@chromium.org>
1434
1435         Reviewed by Eric Seidel.
1436
1437         check-webkit-style check for meaningless variable names in function declarations.
1438         https://bugs.webkit.org/show_bug.cgi?id=51523
1439
1440         * Scripts/webkitpy/style/checker.py: Exempted JavaScriptCore/jit/JITStubs.cpp
1441         from the new check and whitespace/parens because the syntax is unusual and
1442         produced a fair number of positives for these checks.
1443         * Scripts/webkitpy/style/checkers/cpp.py:
1444         (_convert_to_lower_with_underscores): Used as a canonical form for type names
1445         and parameter names when determining if the parameter name is useless.
1446         (_create_acronym): Used to check for redundant variable names in cases like "ExceptionCode ec"
1447         (Parameter.lower_with_underscores_name): Gives back the parameter name in a lower_with_underscore
1448         format.
1449         (_check_parameter_name_against_text):  Checks to see if the parameter name is in the
1450         text or an acronym of it.
1451         (check_function_definition): Checks function definitions for meaningless variable names.
1452         (process_line): Added call to check_function_definition.
1453         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1454         (CppFunctionsTest.test_convert_to_lower_with_underscores): Test for _convert_to_lower_with_underscores.
1455         (CppFunctionsTest.test_create_acronym): Test for _create_acronym.
1456         (CppFunctionsTest.test_check_parameter_against_text): Test for _check_parameter_against_text.
1457         (CppStyleTestBase.perform_single_line_lint): Removed the parameter name check
1458         because when only checking a snippet, there are a lot of bogus functions.
1459         (CppStyleTestBase.perform_multi_line_lint): Ditto and removed a bogus filter
1460         that I put there previously and just noticed.
1461         (WebKitStyleTest.test_parameter_names): Tests for the functionality -- both
1462         check_function_definition and process_line.
1463
1464 2010-12-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1465
1466         Reviewed by Martin Robinson.
1467
1468         [GTK] Disable flash plugin in GtkLauncher when using gtk3
1469         https://bugs.webkit.org/show_bug.cgi?id=51591
1470
1471         Flash plugin uses gtk2 that is incompatible with gtk3 making
1472         webkit crash when it's built with gtk3.
1473
1474         * GtkLauncher/main.c:
1475         (main):
1476
1477 2010-12-25  Adam Barth  <abarth@webkit.org>
1478
1479         Reviewed by Eric Seidel.
1480
1481         Move ANGLE to Sources/ThirdParty
1482         https://bugs.webkit.org/show_bug.cgi?id=51605
1483
1484         * Scripts/build-webkit:
1485           - Point to the new ANGLE location.
1486
1487 2010-12-26  David Levin  <levin@chromium.org>
1488
1489         Reviewed by Eric Seidel.
1490
1491         check-webkit-style should be able to parse function declaration parameters.
1492         https://bugs.webkit.org/show_bug.cgi?id=51451
1493
1494         * Scripts/webkitpy/style/checkers/cpp.py:
1495         (Position.__init__): Holds simple position information (row, column).
1496         (Parameter.__init__): Holds information about a parameter.
1497         (SingleLineView.__init): Converts multiple lines into a single line for simpler searches.
1498         (SingleLineView.convert_column_to_row): Returns the original row given a column.
1499         (create_skeleton_parameters): Simplifies a parameter list for easier searching.
1500         (find_parameter_name_index): Finds where the parameter name is.
1501         (parameter_list): Generates the list of parameters for a function.
1502         (_FunctionState.begin): Added information to allow determining the parameters
1503         on demand.
1504         (_FunctionState.get_parameter_list): Returns a tuple of function parameters.
1505         (detect_functions): Improve function detection for operator functions and
1506         determine where the parameters end and pass that to _FunctionState.begin.
1507         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1508         (CppFunctionsTest.test_parameter): Verifies Parameter functionality.
1509         (CppFunctionsTest.test_single_line_view): Verifies SingleLineView functionality.
1510         (CppFunctionsTest.test_create_skeleton_parameters): Verifies create_skeleton_parameters.
1511         (CppFunctionsTest.test_find_parameter_name_index): Verifies find_parameter_name_index.
1512         (CppFunctionsTest.test_parameter_list): Does some minimal verification for parameter list.
1513         Much more thorough verification is done as part of FunctionDetectionTest.test_parameter_list.
1514         (FunctionDetectionTest.perform_function_detection): Added support for verifying
1515         the parameters found.
1516         (FunctionDetectionTest.test_function_declaration_detection): Added more function
1517         detection test to verify that we catch the operator functions.
1518         (FunctionDetectionTest.test_ignore_macros): Verify that function detection ignores macros.
1519         (FunctionDetectionTest.test_parameter_list): Added tests to verify the parameter parsing.
1520         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_bad_test_doesnt_break): Removed
1521         because the error. The test is about the bad function name. Fixing the name makes the test exactly like
1522         test_function_length_check_definition_severity1_for_test.
1523
1524 2010-12-25  Patrick Gansterer  <paroga@webkit.org>
1525
1526         Unreviewed WinCE buildfix after r74334.
1527
1528         * CMakeListsWinCE.txt:
1529
1530 2010-12-24  Sheriff Bot  <webkit.review.bot@gmail.com>
1531
1532         Unreviewed, rolling out r74632.
1533         http://trac.webkit.org/changeset/74632
1534         https://bugs.webkit.org/show_bug.cgi?id=51600
1535
1536         makes test-webkitpy hang forever on GTK (Requested by philn-tp
1537         on #webkit).
1538
1539         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
1540         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
1541
1542 2010-12-24  Ryuan Choi  <ryuan.choi@samsung.com>
1543
1544         Reviewed by Kenneth Rohde Christiansen.
1545
1546         [EFL] Screen doesn't be rendered when changing size of EWebLauncher
1547         https://bugs.webkit.org/show_bug.cgi?id=43528
1548
1549         Remove on_resize because ewk_view_fixed_layout_size_set should not be
1550         called on callback of EVAS_CALLBACK_RESIZE. As it change size of
1551         FrameView, rendering was ignored when _ewk_view_smart_calculate was
1552         called.
1553
1554         * EWebLauncher/main.c:
1555         (browserCreate):
1556
1557 2010-12-24  Eric Seidel  <eric@webkit.org>
1558
1559         Reviewed by Adam Barth.
1560
1561         webkit-patch (or a pre-commit hook) needs to prevent bad ChangeLog changes
1562         https://bugs.webkit.org/show_bug.cgi?id=28291
1563
1564         This is a start.  At least now webkit-patch will prompt when your ChangeLog looks questionable.
1565         We could do more advanced things, like parsing the ChangeLog (with changelog.py) and comparing that
1566         to strings with find in the diff.
1567         Since non-interactive always returns the default, this should cause patches with bad changelogs to fail on the commit-queue.
1568
1569         * Scripts/webkitpy/common/checkout/api.py:
1570         * Scripts/webkitpy/common/checkout/diff_parser.py:
1571         * Scripts/webkitpy/tool/steps/abstractstep.py:
1572         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
1573         * Scripts/webkitpy/tool/steps/validatechangelogs.py: Copied from Tools/Scripts/webkitpy/tool/steps/validatereviewer.py.
1574         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py: Copied from Tools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.
1575         * Scripts/webkitpy/tool/steps/validatereviewer.py:
1576
1577 2010-12-24  Dirk Pranke  <dpranke@chromium.org>
1578
1579         Reviewed by Kenneth Russell.
1580
1581         Modify new-run-webkit-tests to shut up and exit when all the threads
1582         are wedged so that test runs complete faster and we don't end up
1583         w/ enormous log files.
1584
1585         https://bugs.webkit.org/show_bug.cgi?id=51572
1586
1587         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
1588         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
1589
1590 2010-12-24  Eric Seidel  <eric@webkit.org>
1591
1592         Reviewed by David Levin.
1593
1594         commit-queue should better explain how it will re-open bugs and follow duplicate chains
1595         https://bugs.webkit.org/show_bug.cgi?id=51549
1596
1597         I've had multiple people ask me about the commit-queue's behavior
1598         regarding reporting flaky tests.  I figured it would be best to just
1599         have the queue explain itself in the bugs it files.
1600
1601         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1602         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1603
1604 2010-12-24  Shinichiro Hamaji  <hamaji@chromium.org>
1605
1606         Reviewed by Eric Seidel.
1607
1608         check-webkit-style: should ignore "wrong" namings in JavaScriptCore/qt
1609         https://bugs.webkit.org/show_bug.cgi?id=51467
1610
1611         * Scripts/webkitpy/style/checker.py:
1612         * Scripts/webkitpy/style/checker_unittest.py:
1613
1614 2010-12-23  Adam Barth  <abarth@webkit.org>
1615
1616         Rubber-stamped by Eric Seidel.
1617
1618         Move JavaScriptGlue into Sources
1619         https://bugs.webkit.org/show_bug.cgi?id=51583
1620
1621         These tools refer to JavaScriptGlue and need to be updated to its new
1622         location.
1623
1624         * Scripts/build-webkit:
1625         * Scripts/do-file-rename:
1626         * Scripts/do-webcore-rename:
1627         * Scripts/webkitpy/common/config/build.py:
1628         * Scripts/webkitpy/common/config/build_unittest.py:
1629
1630 2010-12-23  Lucas Forschler  <lforschler@apple.com>
1631
1632         Reviewed by Eric Seidel.
1633
1634         Bug 51539 - update iexploder scripts to point to new location
1635
1636         * Scripts/run-iexploder-tests:
1637         * Scripts/update-iexploder-cssproperties:
1638
1639 2010-12-23  Evan Martin  <evan@chromium.org>
1640
1641         Reviewed by Ryosuke Niwa.
1642
1643         [chromium] LayoutTestController warning in float->int conversion
1644         https://bugs.webkit.org/show_bug.cgi?id=51553
1645
1646         Rather than reading an int, converting to a float, then getting a compiler
1647         warning on passing the float to something that expects an int, instead
1648         just pass around ints.
1649
1650         No tests, fixes a compiler warning.
1651
1652         * DumpRenderTree/chromium/LayoutTestController.cpp:
1653         (parsePageSizeParameters):
1654         (LayoutTestController::pageNumberForElementById):
1655         (LayoutTestController::numberOfPages):
1656
1657 2010-12-23  Lucas Forschler  <lforschler@apple.com>
1658
1659         Reviewed by Darin Adler.
1660
1661         Bug 51537 - iexploder needs cleanup
1662         
1663         * iExploder/htdocs: Removed.
1664         * iExploder/htdocs/config.rb: Removed.
1665         * iExploder/htdocs/cssproperties.in: Removed.
1666         * iExploder/htdocs/cssvalues.in: Removed.
1667         * iExploder/htdocs/htmlattrs.in: Removed.
1668         * iExploder/htdocs/htmltags.in: Removed.
1669         * iExploder/htdocs/htmlvalues.in: Removed.
1670         * iExploder/htdocs/iexploder.cgi: Removed.
1671         * iExploder/htdocs/iexploder.rb: Removed.
1672         * iExploder/htdocs/index.html: Removed.
1673         * iExploder/htdocs/webserver.rb: Removed.
1674         * iExploder/iexploder-1.7.2/output: Removed.
1675         * iExploder/tools: Removed.
1676         * iExploder/tools/lasthit.rb: Removed.
1677         * iExploder/tools/osx_last_crash.rb: Removed.
1678         * iExploder/tools/showtest.rb: Removed.
1679
1680 2010-12-23  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
1681
1682         Reviewed by Kenneth Rohde Christiansen.
1683
1684         [EFL] Make 'single' the default backing store in EWebLauncher
1685         https://bugs.webkit.org/show_bug.cgi?id=51534
1686
1687         'single' is the simplest backing store and the one intended to be the
1688         default in the test browser. By mistake the tiled backing store was
1689         left as default in r72617.
1690
1691         * EWebLauncher/main.c:
1692         (browserCreate): ditto.
1693
1694 2010-12-23  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
1695
1696         Reviewed by Kenneth Rohde Christiansen.
1697
1698         [EFL] Subject: [webkit 4/4] [EFL] Remove non-sense workaround
1699         https://bugs.webkit.org/show_bug.cgi?id=51533
1700
1701         There's no point in concatenating env("HOME") with "blah", so remove
1702         option from EWebLauncher.
1703
1704         * EWebLauncher/main.c:
1705         (main): ditto.
1706
1707 2010-12-23  Ilya Tikhonovsky  <loislo@chromium.org>
1708
1709         Reviewed by Eric Seidel.
1710
1711         Web Inspector: chromium: inspector's tests are quite slow especially at windows(Debug).
1712
1713         Almost all inspector's tests become flaky on chromium Win(dbg) after switching to DRT.
1714         I just discovered that we have two additional GC runs per each WebViewHost.
1715         Test_shell had no such calls.
1716         These gc runs eat 15% of cpu time.
1717
1718         https://bugs.webkit.org/show_bug.cgi?id=51479
1719
1720         * DumpRenderTree/chromium/WebViewHost.cpp:
1721         (WebViewHost::~WebViewHost):
1722
1723 2010-12-22  Dirk Pranke  <dpranke@chromium.org>
1724
1725         Reviewed by Ojan Vafai.
1726
1727         This change splits out the TestRunner class into its own file.
1728         When we fork the code for message passing, we will create a new
1729         TestRunner, and this change will allow that to be more modular.
1730
1731         While we're at it, split out TestInput and ResultSummary into
1732         their own files, to reduce the size of run_webkit_tests to
1733         something more managable.
1734
1735         https://bugs.webkit.org/show_bug.cgi?id=51092
1736
1737         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1738         * Scripts/webkitpy/layout_tests/layout_package/result_summary.py:
1739         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1740         * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
1741         * Scripts/webkitpy/layout_tests/layout_package/test_input.py:
1742         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1743         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1744
1745  2010-12-22  Dirk Pranke  <dpranke@chromium.org>
1746
1747         Reviewed by Ojan Vafai.
1748
1749         nrwt multiprocessing - start over, prepare to fork the code
1750  
1751         This code cleans up the signatures and implementation of the
1752         TestRunner class so we can easily fork it to run either the
1753         stable implementation or the new, unstable message-passing
1754         implementation. The two variants will have different
1755         implementations of the run_tests() method. We will switch
1756         between the two based on the setting for the '--worker-model'
1757         switch. We rename the two currently valid values to 'old-inline'
1758         and 'old-threads'.
1759
1760         https://bugs.webkit.org/show_bug.cgi?id=51081
1761
1762         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1763         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1764
1765 2010-12-22  Victor Wang  <victorw@chromium.org>
1766
1767         Reviewed by Darin Fisher.
1768
1769         [Chromium] Update chromium archive test result url in rebaseline script.
1770
1771         https://bugs.webkit.org/show_bug.cgi?id=51503
1772
1773         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1774
1775 2010-12-22  Lucas Forschler  <lforschler@apple.com>
1776
1777         Reviewed by Alice Liu.
1778
1779         <rdar://problem/8633222> record-memory-win needs to record memory used by the webprocess.
1780         Verified on Chrome, Safari, and IE.
1781         With this change, we will record memory from a parent browser window and all child processes.
1782
1783         * record-memory-win/main.cpp:
1784         (ProcessArgs):
1785         (PrintUsage):
1786         (getMemoryInfo):
1787         (printProcessInfo):
1788         (evalProcesses):
1789         (UseImage):
1790         (QueryContinuously):
1791         (ElapsedTime):
1792
1793 2010-12-22  Lucas Forschler  <lforschler@apple.com>
1794
1795         Unreviewed rollout r74489, because it was missing changelog.
1796
1797         * record-memory-win/main.cpp:
1798         
1799 2010-12-22  Ryosuke Niwa  <rniwa@webkit.org>
1800
1801         Adding myself as a reviewer.
1802
1803         * Scripts/webkitpy/common/config/committers.py:
1804
1805 2010-12-22  Andrew Scherkus  <scherkus@chromium.org>
1806
1807         Unreviewed.  Adding myself to committers.py.
1808
1809         * Scripts/webkitpy/common/config/committers.py:
1810
1811 2010-12-22  Ariya Hidayat  <ariya@sencha.com>
1812
1813         Reviewed by Kenneth Rohde Christiansen.
1814
1815         TestNetscapePlugIn should use #if defined
1816         https://bugs.webkit.org/show_bug.cgi?id=51471
1817
1818         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1819         (NP_Initialize):
1820         (NPP_New):
1821
1822 2010-12-22  Ilya Tikhonovsky  <loislo@chromium.org>
1823
1824         Reviewed by Yury Semikhatsky.
1825
1826         Web Inspector: [chromium] DRT inspector layout tests are flaky in debug.
1827
1828         DevTools window should be closed explicitly because it has custom deinitialization code.
1829
1830         https://bugs.webkit.org/show_bug.cgi?id=50722
1831
1832         * DumpRenderTree/chromium/TestShell.cpp:
1833         (TestShell::closeRemainingWindows):
1834
1835 2010-12-22  David Levin  <levin@chromium.org>
1836
1837         Reviewed by Shinichiro Hamaji.
1838
1839         check-webkit-style shouldn't complaint about underscores in variables in objective C files.
1840         https://bugs.webkit.org/show_bug.cgi?id=51452
1841
1842         * Scripts/webkitpy/style/checkers/cpp.py:
1843         (_FileState.__init__): Added the information to determine if a file is C or Objective C.
1844         Using the file extension if possible but falling back to the file contents if we have a header file.
1845         (_FileState.is_objective_c): Determine if we have an Objective C by examining the file contents if needed.
1846         (_FileState.is_c_or_objective_c):
1847         (check_using_std): Changed to using _FileState to determine the file type.
1848         (check_max_min_macros): Ditto.
1849         (check_for_null): Ditto.
1850         (check_style): Changed the parameters to various calls since they now need _FileState
1851         to determine the file type.
1852         (check_language): Added the file_state parameter so it could be passed
1853         to check_identifier_name_in_declaration.
1854         (check_identifier_name_in_declaration): Don't warn about underscores in variables if
1855         this is an Objective C file.
1856         (_process_lines): Added information for the _FileState constructor (and moved the
1857         call to a place that had the information).
1858         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1859         (CppFunctionsTest.test_is_c_or_objective_c): Changed the tests to use FileState and exercise
1860         its functionality.
1861         (WebKitStyleTest.test_names): Add tests for underscores in Objective C files.
1862
1863 2010-12-21  Andy Estes  <aestes@apple.com>
1864
1865         Reviewed by Mark Rowe.
1866
1867         Do not build non-Intel architectures for WebKit2-related projects.
1868         https://bugs.webkit.org/show_bug.cgi?id=51440
1869
1870         * MiniBrowser/Configurations/Base.xcconfig: Only build for i386 and x86_64.
1871         * TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
1872         * WebKitTestRunner/Configurations/Base.xcconfig: Ditto.
1873
1874 2010-12-21  Mihai Parparita  <mihaip@chromium.org>
1875
1876         Reviewed by Darin Fisher.
1877
1878         [Chromium] Rename WebThemeEngine/ControlDRT to WebThemeEngine/ControlDRTWin
1879         https://bugs.webkit.org/show_bug.cgi?id=51406 
1880         
1881         Rename WebThemeControlDRT to WebThemeControlDRTWin and WebThemeEngineDRT
1882         to WebThemeEngineDRTWin and update references everywhere.
1883
1884         * DumpRenderTree/DumpRenderTree.gypi:
1885         * DumpRenderTree/chromium/TestShellWin.cpp:
1886         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRT.cpp.
1887         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRT.h.
1888         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRT.cpp.
1889         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRT.h.
1890
1891 2010-12-21  Anders Carlsson  <andersca@apple.com>
1892
1893         Reviewed by John Sullivan.
1894
1895         Clicking missing plug-in text does not show a sheet
1896         https://bugs.webkit.org/show_bug.cgi?id=51403
1897
1898         Update for changes to the WebPageUIClient.
1899
1900         * MiniBrowser/mac/BrowserWindowController.m:
1901         (-[BrowserWindowController awakeFromNib]):
1902         * WebKitTestRunner/TestController.cpp:
1903         (WTR::createOtherPage):
1904         (WTR::TestController::initialize):
1905
1906 2010-12-21  Eric Seidel  <eric@webkit.org>
1907
1908         Reviewed by Adam Barth.
1909
1910         commit-queue will report constant failures as flaky if other tests flake
1911         https://bugs.webkit.org/show_bug.cgi?id=51272
1912
1913         This patch just removes functionality and adds testing.
1914         Previously we attempted to report flaky tests when we had
1915         two different tests fail in a row.  However, since we stop
1916         running the tests at the first failure, our code was wrong in
1917         trying to determine flakiness from the incomplete runs.
1918
1919         Originally I posted an alternate patch:
1920         https://bug-51272-attachments.webkit.org/attachment.cgi?id=77078
1921         which fixed our flaky logic in this case, however it was decided
1922         that that patch would be too difficult to maintain, so now
1923         I'm just removing the broken logic.
1924
1925         This will dramatically cut-down on our flaky-test false positives
1926         at the (small) cost of the queues being unable to report
1927         any flakiness if the tree is very flaky.  (With at least one test
1928         flaking on every run, we'll never report failures anymore.)  I think
1929         this is a tradeoff worth making.
1930
1931         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1932         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1933
1934 2010-12-20  Eric Seidel  <eric@webkit.org>
1935
1936         Reviewed by Adam Barth.
1937
1938         commit-queue wrongly rejects patches when it can't update itself
1939         https://bugs.webkit.org/show_bug.cgi?id=46636
1940
1941         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1942         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1943         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1944
1945 2010-12-20  Adam Barth  <abarth@webkit.org>
1946
1947         Move web sites to Websites directory
1948         https://bugs.webkit.org/show_bug.cgi?id=51323
1949
1950         Update references to BugsSite to point to the new location.
1951
1952         This patch was never officially reviewed (because it was too large to
1953         upload to bugs.webkit.org), but it was discussed on webkit-dev and Mark
1954         Rowe gave me the green light.
1955
1956         * Scripts/old-run-webkit-tests:
1957         * Scripts/webkitpy/common/config/build.py:
1958         * Scripts/webkitpy/common/config/build_unittest.py:
1959         * Scripts/webkitpy/common/prettypatch.py:
1960         * Scripts/webkitpy/layout_tests/port/base.py:
1961         * Scripts/webkitpy/style/main.py:
1962
1963 2010-12-20  Adrienne Walker  <enne@google.com>
1964
1965         Unreviewed. Adding myself to the list of committers.
1966
1967         * webkitpy/common/config/committers.py:
1968
1969 2010-12-20  Mark Rowe  <mrowe@apple.com>
1970
1971         Reviewed by Dan Bernstein.
1972
1973         <rdar://problem/8757601> Don't install header files in to the Resources directory.
1974
1975         * Scripts/check-for-inappropriate-files-in-framework: Don't allow .h files in the
1976         Resources directory.
1977
1978 2010-12-20  Eric Seidel  <eric@webkit.org>
1979
1980         Reviewed by Adam Barth.
1981
1982         commit-queue should include bot id when attaching failure diffs
1983         https://bugs.webkit.org/show_bug.cgi?id=51280
1984
1985         This is a tiny change to include the bot id in the name of the attachment.
1986         Most of this diff is just changing the unit test expectations
1987         now that I hid the comment printing when the comment is None.
1988
1989         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1990         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1991         * Scripts/webkitpy/tool/commands/upload_unittest.py:
1992         * Scripts/webkitpy/tool/mocktool.py:
1993
1994 2010-12-20  Jeff Miller  <jeffm@apple.com>
1995
1996         Reviewed by Dan Bernstein.
1997
1998         Tools/vcbin/midl.exe needs to be rebuilt
1999         https://bugs.webkit.org/show_bug.cgi?id=51347
2000
2001         * vcbin/midl.exe: Rebuilt.
2002
2003 2010-12-20  David Levin  <levin@chromium.org>
2004
2005         Reviewed by Ariya Hidayat.
2006
2007         .gitignore and webkit-tools-completion.sh have references to WebKitTools that should be Tools.
2008         https://bugs.webkit.org/show_bug.cgi?id=51343
2009
2010         Follow up from the WebKitTools -> Tools rename.
2011
2012         * Scripts/webkit-tools-completion.sh:
2013
2014 2010-12-20  Cosmin Truta  <ctruta@chromium.org>
2015
2016         Reviewed by James Robinson.
2017
2018         new-run-webkit-tests ignores trailing EOL differences in text tests
2019         https://bugs.webkit.org/show_bug.cgi?id=36983
2020
2021         Changed the handling of new-line characters within new-run-webkit-tests
2022         to match old-run-webkit-tests.  Differences in leading and trailing empty
2023         lines in text expectation files are no longer ignored.
2024
2025         * Scripts/webkitpy/layout_tests/port/base.py:
2026         * Scripts/webkitpy/layout_tests/port/test.py:
2027         Added unit tests.  Removed old duplicate unit test entries.
2028         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
2029
2030 2010-12-20  David Levin  <levin@chromium.org>
2031
2032         Reviewed by Shinichiro Hamaji.
2033
2034         check-webkit-style should detect function declarations (and trivial functions).
2035         https://bugs.webkit.org/show_bug.cgi?id=51303
2036
2037         * Scripts/webkitpy/style/checkers/cpp.py:
2038         (_FunctionState.begin): Add is_declaration and changed the line count
2039         start to begin at -1 (which will keep the results consistent, since
2040         the starting line number passed in is one less in this change).
2041         (detect_functions): changed function detection to now catch trivial
2042         functions and declarations.
2043         (check_pass_ptr_usage): Don't check for Pass*Ptr on the first line
2044         of the function as this may look at return values (when processing
2045         a declaration).
2046         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2047         (FunctionDetectionTest.perform_function_detection): Basic mechanics
2048         of testing the function detection.
2049         (FunctionDetectionTest.test_basic_function_detection): Test a simple
2050         function.
2051         (FunctionDetectionTest.test_function_declaration_detection): Test a
2052         declaration.
2053         (FunctionDetectionTest.test_non_functions): A test case for a case
2054         that caused the code to fail due to the { being in quotes.
2055         (PassPtrTest.test_pass_ref_ptr_return_value): Added some more test
2056         cases to help catch false alarms for return values.
2057         (PassPtrTest.test_pass_ref_ptr_member_variable): Ensure that
2058         we don't get false alarms for member variables either.
2059
2060 2010-12-20  Ryuan Choi  <ryuan.choi@samsung.com>
2061
2062         Reviewed by Antonio Gomes.
2063
2064         [CMAKE] Rename WEBKITTOOLS_DIR to TOOLS_DIR
2065         https://bugs.webkit.org/show_bug.cgi?id=51319
2066
2067         * CMakeListsEfl.txt:
2068
2069 2010-12-18  Adam Barth  <abarth@webkit.org>
2070
2071         Reviewed by Sam Weinig.
2072
2073         Move WebKitExamplePlugins to Examples
2074         https://bugs.webkit.org/show_bug.cgi?id=51291
2075
2076         * Scripts/webkitpy/common/config/build.py:
2077
2078 2010-12-17  Csaba Osztrogonác  <ossy@webkit.org>
2079
2080         Unreviewed Qt buildfix after r74301.
2081
2082         Rename WebKitTools to Tools
2083         https://bugs.webkit.org/show_bug.cgi?id=49861
2084
2085         * MiniBrowser/DerivedSources.pro:
2086         * MiniBrowser/qt/MiniBrowser.pro:
2087
2088 2010-12-17  Dan Bernstein  <mitz@apple.com>
2089
2090         Reviewed by Simon Fraser.
2091
2092         Rename WebKitTools to Tools
2093         https://bugs.webkit.org/show_bug.cgi?id=49861
2094
2095         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2096         * CodeCoverage/README:
2097         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2098         (WebCore::DumpRenderTree::initializeFonts):
2099         * EWSTools/start-commit-queue.sh:
2100         * EWSTools/start-queue.sh:
2101         * GNUmakefile.am:
2102         * MIDLWrapper/MIDLWrapper.cpp:
2103         (wmain):
2104         * MiniBrowser/qt/MiniBrowser.pro:
2105         * Scripts/build-api-tests:
2106         * Scripts/build-dumprendertree:
2107         * Scripts/build-webkit:
2108         * Scripts/build-webkittestrunner:
2109         * Scripts/generate-coverage-data:
2110         * Scripts/old-run-webkit-tests:
2111         * Scripts/run-api-tests:
2112         * Scripts/run-iexploder-tests:
2113         * Scripts/run-javascriptcore-tests:
2114         * Scripts/run-mangleme-tests:
2115         * Scripts/run-sunspider:
2116         * Scripts/run-webkit-websocketserver:
2117         * Scripts/sunspider-compare-results:
2118         * Scripts/test-webkitperl:
2119         * Scripts/test-webkitpy:
2120         * Scripts/update-iexploder-cssproperties:
2121         * Scripts/update-webkit:
2122         * Scripts/update-webkit-localizable-strings:
2123         * Scripts/webkitdirs.pm:
2124         * Scripts/webkitpy/common/checkout/scm.py:
2125         * Scripts/webkitpy/common/checkout/scm_unittest.py:
2126         * Scripts/webkitpy/common/config/committervalidator.py:
2127         * Scripts/webkitpy/common/config/committervalidator_unittest.py:
2128         * Scripts/webkitpy/common/config/ports.py:
2129         * Scripts/webkitpy/common/config/ports_unittest.py:
2130         * Scripts/webkitpy/common/system/logutils_unittest.py:
2131         * Scripts/webkitpy/common/system/ospath_unittest.py:
2132         * Scripts/webkitpy/layout_tests/port/chromium.py:
2133         * Scripts/webkitpy/layout_tests/port/config.py:
2134         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
2135         * Scripts/webkitpy/layout_tests/port/http_server.py:
2136         * Scripts/webkitpy/layout_tests/port/test.py:
2137         * Scripts/webkitpy/style/checker.py:
2138         * Scripts/webkitpy/style/checker_unittest.py:
2139         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
2140         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2141         * Scripts/webkitpy/tool/steps/steps_unittest.py:
2142         * WebKitTestRunner/DerivedSources.pro:
2143         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
2144         (WTR::activateFonts):
2145         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2146         * wx/build/build_utils.py:
2147
2148 2010-12-16  Antonio Gomes  <agomes@rim.com>
2149
2150         Reviewed by Martin Robinson.
2151
2152         Settings::editingBehaviorType() incorrectly returns mac for the gtk build when running tests
2153         https://bugs.webkit.org/show_bug.cgi?id=51163
2154
2155         Since GTK+'s default editing behavior was changed to UNIX in r70975 (see webkitwebsettings.cpp),
2156         GTK+'s DRT should also reset to UNIX after each test execution.
2157
2158         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2159         (resetDefaultsToConsistentValues):
2160
2161 2010-12-17  David Levin  <levin@chromium.org>
2162
2163         Reviewed by Eric Seidel.
2164
2165         check-webkit-style should understand WTF #include guards
2166         https://bugs.webkit.org/show_bug.cgi?id=44911
2167
2168         * Scripts/webkitpy/style/checkers/cpp.py:
2169         (get_header_guard_cpp_variable): modify to suggest the WTF style
2170         of header guard when appropriate.
2171         (check_for_header_guard): handle multiple return values from
2172         get_header_guard_cpp_variable
2173         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2174         (CppStyleTest.test_build_header_guard): Added tests for the WTF
2175         header style.
2176
2177 2010-12-16  David Levin  <levin@chromium.org>
2178
2179         Reviewed by Eric Seidel.
2180
2181         test-webkitpy: unittest for the xml.py checker displays a decprecation warning.
2182         https://bugs.webkit.org/show_bug.cgi?id=51210
2183
2184         The error only shows up when using python 2.6 or later.
2185
2186         * Scripts/webkitpy/style/checkers/xml.py: Replace the usage of
2187         the decprecated field error,message with something equivalent.
2188
2189 2010-12-16  Mihai Parparita  <mihaip@chromium.org>
2190
2191         Reviewed by Eric Seidel.
2192
2193         Add --exit-after-n-failures/crashes to NRWT
2194         https://bugs.webkit.org/show_bug.cgi?id=51160
2195         
2196         Abort test run (in a similar way to how control-C is handled) when
2197         --exit-after-n-failures/crashes-or-timeouts are passed and we've reached
2198         that number of unexpected failures/crashes/timeouts.
2199
2200         * Scripts/webkitpy/layout_tests/port/test.py:
2201         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2202         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2203
2204 2010-12-16  David Levin  <levin@chromium.org>
2205
2206         Reviewed by Shinichiro Hamaji.
2207
2208         check-webkit-style unit tests has some duplicate boilerplate code.
2209         https://bugs.webkit.org/show_bug.cgi?id=49519
2210
2211         * Scripts/webkitpy/style/checkers/cpp.py:
2212         (update_include_state): Replaced the "io" parameter with the global
2213         configuration _unit_test_config. This allowed not calling into
2214         functions at a low level and also not plumbing through the injection
2215         information through many levels of code.
2216         (check_for_include_what_you_use): Ditto.
2217         (process_file_data): Added the ability to set up the unit test config
2218         to allow for injection.
2219         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2220         (ErrorCollector.__init__): Added support for having a filter for errors.
2221         (ErrorCollector.__call__): Ditto.
2222         (CppStyleTestBase.process_file_data): Added the ability to set unit_test_config.
2223         (CppStyleTestBase.perform_lint): Consolidated logic for the perform functions.
2224         (CppStyleTestBase.perform_single_line_lint): Replace specific calls to
2225         functions in the cpp.py with generic processing and a filter that
2226         indicates what errors should be kept.
2227         (CppStyleTestBase.perform_multi_line_lint): Ditto.
2228         (CppStyleTestBase.perform_language_rules_check): Ditto.
2229         (CppStyleTestBase.perform_function_lengths_check): Ditto.
2230         (CppStyleTestBase.perform_pass_ptr_check): Ditto.
2231         (CppStyleTestBase.perform_include_what_you_use): Ditto.
2232         (CppStyleTest.test_multi_line_comments): Added another
2233         error message which applies to the test case.
2234         (CppStyleTest.test_spacing_for_binary_ops): Fixed test
2235         to not have config.h, since it is processed as a header file.
2236         (CppStyleTest.test_static_or_global_stlstrings): Fixed variable name
2237         style and indentation in checked code.
2238         (OrderOfIncludesTest.test_check_preprocessor_in_include_section):
2239         Fixed line number.
2240         (NoNonVirtualDestructorsTest.test_multi_line_declaration_with_error):
2241         Ditto.
2242
2243 2010-12-15  Sheriff Bot  <webkit.review.bot@gmail.com>
2244
2245         Unreviewed, rolling out r74136.
2246         http://trac.webkit.org/changeset/74136
2247         https://bugs.webkit.org/show_bug.cgi?id=51135
2248
2249         r74136 breaks chromium canary bots because some tests are not
2250         rebaselined correctly to resolve EOL differences (Requested by
2251         jianli on #webkit).
2252
2253         * Scripts/webkitpy/layout_tests/port/base.py:
2254         * Scripts/webkitpy/layout_tests/port/test.py:
2255         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
2256
2257 2010-12-15  Adam Roben  <aroben@apple.com>
2258
2259         Teach check-webkit-style to check .vcproj and .vsprops files for XML
2260         syntax errors
2261
2262         Fixes <http://webkit.org/b/51103> check-webkit-style should check for
2263         XML syntax errors in .vcproj/.vsprops files
2264
2265         Reviewed by Dave Levin.
2266
2267         * Scripts/webkitpy/style/checker.py: Added lists of file extensions
2268         that should be treated as XML and that should be allowed to contain
2269         carriage returns. (These lists happen to be identical currently.)
2270         (FileType): Added a new XML type.
2271         (CheckerDispatcher.should_check_and_strip_carriage_returns): Added.
2272         Just does a simple file extension check.
2273         (CheckerDispatcher._file_type): Added a case for XML files.
2274         (CheckerDispatcher._create_checker): Ditto. We use XMLChecker for XML
2275         files (surprise!).
2276         (StyleProcessor.process): Ask the dispatcher whether we should pass the
2277         lines through the carriage checker.
2278
2279         * Scripts/webkitpy/style/checker_unittest.py:
2280         (CheckerDispatcherCarriageReturnTest.test_should_check_and_strip_carriage_returns):
2281         Added. Checks a few file names to see if carriage returns are allowed
2282         or not.
2283         (CheckerDispatcherDispatchTest.assert_checker_xml): Added. Similar to
2284         other assert_checker_* functions.
2285         (CheckerDispatcherDispatchTest.test_xml_paths): Added. Similar to other
2286         test_*_paths functions.
2287         (CheckerDispatcherDispatchTest.test_xml_paths): Added. Similar to other
2288         test_*_paths functions.
2289         (CheckerDispatcherDispatchTest.test_none_paths): Removed the vcproj
2290         file from this test case, as vcproj files now have a type.
2291         (StyleProcessor_CodeCoverageTest.MockDispatcher.should_check_and_strip_carriage_returns):
2292         Added. Similar to the other should_* functions.
2293         (StyleProcessor_CodeCoverageTest.test_process__carriage_returns_not_stripped):
2294         Added. Checks that carriage returns aren't checked for or stripped for
2295         allowed files.
2296
2297         * Scripts/webkitpy/style/checkers/xml.py: Added.
2298         (XMLChecker.__init__): Simple init method.
2299         (XMLChecker.check): Pass each line through the expat parser, and record
2300         a style error for any errors thrown by the parser.
2301
2302         * Scripts/webkitpy/style/checkers/xml_unittest.py: Added.
2303         (XMLCheckerTest.assert_no_error): Checks that the given XML does not
2304         produce a style error.
2305         (XMLCheckerTest.assert_error): Checks that the given XML produces an
2306         error of the given category on the given line.
2307         (XMLCheckerTest.mock_handle_style_error): Does nothing. Used for
2308         checking that the XMLChecker constructor works properly.
2309         (XMLCheckerTest.test_conflict_marker): Tests that conflict markers
2310         cause a style error (see, e.g., r73887).
2311         (XMLCheckerTest.test_extra_closing_tag): Tests that extra closing tags
2312         cause a style error (see, e.g., r73773).
2313         (XMLCheckerTest.test_init): Tests that the XMLChecker constructor works
2314         properly.
2315         (XMLCheckerTest.test_missing_closing_tag): Tests that missing closing
2316         tags cause a style error (see, e.g., r72795).
2317         (XMLCheckerTest.test_no_error): Tests that valid XML does not cause a
2318         style error.
2319
2320 2010-12-15  Lucas Forschler  <lforschler@apple.com>
2321
2322         Reviewed by Stephanie Lewis.
2323
2324         https://bugs.webkit.org/show_bug.cgi?id=51117
2325         Add a new leopard test bot
2326         really really commit to trunk this time.
2327
2328         * BuildSlaveSupport/build.webkit.org-config/config.json:
2329
2330 2010-12-15  Sam Weinig  <sam@webkit.org>
2331
2332         Reviewed by Anders Carlsson.
2333
2334         WebKit2: Can't add files to an <input type=file>
2335         https://bugs.webkit.org/show_bug.cgi?id=51087
2336
2337         * MiniBrowser/mac/BrowserWindowController.m:
2338         (runOpenPanel):
2339         (-[BrowserWindowController awakeFromNib]):
2340         Add simple implementation of runOpenPanel callback.
2341
2342         * MiniBrowser/win/BrowserView.cpp:
2343         (BrowserView::create):
2344         * WebKitTestRunner/TestController.cpp:
2345         (WTR::createOtherPage):
2346         (WTR::TestController::initialize):
2347         Stub out runOpenPanel callback. 
2348
2349 2010-12-14  Eric Seidel  <eric@webkit.org>
2350
2351         Reviewed by Adam Barth.
2352
2353         commit-queue should upload failure diffs when tests flake
2354         https://bugs.webkit.org/show_bug.cgi?id=51051
2355
2356         To make this testable I needed to pipe FileSystem down onto tool.
2357         We've wanted it there for a long time anyway.
2358
2359         This patch is kinda a big hack.  But we don't have a nice
2360         way to read results.html files.  I think this will need further
2361         revision before this code actually feels clean.
2362
2363         As part of testing this change, I had to make MockBugzilla.create_bug
2364         actually return an id (like it should) which required updating
2365         a few other unit test results (for the better).
2366
2367         The results_matching_keys change in layouttestresults/rebasline
2368         was an alternate path which I decided not to use in the end, but
2369         I left the change as it seemed an improvement.
2370
2371         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2372         * Scripts/webkitpy/common/net/layouttestresults.py:
2373         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2374         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2375         * Scripts/webkitpy/tool/commands/queues.py:
2376         * Scripts/webkitpy/tool/commands/rebaseline.py:
2377         * Scripts/webkitpy/tool/main.py:
2378         * Scripts/webkitpy/tool/mocktool.py:
2379
2380 2010-12-15  Cosmin Truta  <ctruta@chromium.org>
2381
2382         Reviewed by James Robinson.
2383
2384         new-run-webkit-tests ignores trailing EOL differences in text tests
2385         https://bugs.webkit.org/show_bug.cgi?id=36983
2386
2387         Changed the handling of new-line characters within new-run-webkit-tests
2388         to match old-run-webkit-tests.  Differences in leading and trailing empty
2389         lines in text expectation files are no longer ignored.
2390
2391         * Scripts/webkitpy/layout_tests/port/base.py:
2392         * Scripts/webkitpy/layout_tests/port/test.py:
2393         Added unit tests.  Removed old duplicate unit test entries.
2394         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
2395
2396 2010-12-15  Ojan Vafai  <ojan@chromium.org>
2397
2398         Reviewed by Adam Barth.
2399
2400         make status-bubble white-space:nowrap so we can measure it's width without wrapping
2401         https://bugs.webkit.org/show_bug.cgi?id=51149
2402
2403         * QueueStatusServer/templates/statusbubble.html:
2404
2405 2010-12-15  Ojan Vafai  <ojan@chromium.org>
2406
2407         Reviewed by Adam Barth.
2408
2409         have the statusbubble postMessage it's metrics so that embedders can properly size the iframe
2410         https://bugs.webkit.org/show_bug.cgi?id=51125
2411
2412         * QueueStatusServer/templates/statusbubble.html:
2413
2414 2010-12-15  Darin Adler  <darin@apple.com>
2415
2416         * Scripts/webkitpy/common/net/buildbot: Added property svn:ignore.
2417
2418 2010-12-15  Sheriff Bot  <webkit.review.bot@gmail.com>
2419
2420         Unreviewed, rolling out r74117.
2421         http://trac.webkit.org/changeset/74117
2422         https://bugs.webkit.org/show_bug.cgi?id=51113
2423
2424         This broke the GTK1 build. (Requested by mrobinson on
2425         #webkit).
2426
2427         * Scripts/webkitdirs.pm:
2428
2429 2010-12-15  Amruth Raj  <amruthraj@motorola.com> and Ravi Kasibhatla  <ravi.kasibhatla@motorola.com>
2430
2431         Reviewed by Martin Robinson.
2432
2433         Change generate-forwarding-headers.pl for GTK port usage 
2434         (https://bugs.webkit.org/show_bug.cgi?id=37369)
2435
2436         * Scripts/webkitdirs.pm: Added changes to build webkit2 for GTK port using build-webkit script.
2437
2438 2010-12-14  Kent Tamura  <tkent@chromium.org>
2439
2440         Reviewed by Jian Li.
2441
2442         [DRT/Chromium] Remove another unnecessary error message
2443         https://bugs.webkit.org/show_bug.cgi?id=51083
2444
2445         * DumpRenderTree/chromium/WebViewHost.cpp:
2446         (WebViewHost::didInvalidateRect):
2447
2448 2010-12-14  Lucas Forschler  <lforschler@apple.com>
2449
2450         Reviewed by Stephanie Lewis.
2451
2452         Add a new Leopard Debug Test WK2 Bot
2453
2454         * BuildSlaveSupport/build.webkit.org-config/config.json:
2455
2456 2010-12-14  Ojan Vafai  <ojan@chromium.org>
2457
2458         Fix python unittests after http://trac.webkit.org/changeset/74070.
2459
2460         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
2461
2462 2010-12-14  Kent Tamura  <tkent@chromium.org>
2463
2464         Reviewed by Jian Li.
2465
2466         [DRT/Chromium] Remove a unnecessary error message
2467         https://bugs.webkit.org/show_bug.cgi?id=51069
2468
2469         * DumpRenderTree/chromium/WebViewHost.cpp:
2470         (WebViewHost::paintInvalidatedRegion):
2471
2472 2010-12-14  Benjamin Kalman  <kalman@chromium.org>
2473
2474         Reviewed by Ojan Vafai.
2475
2476         Using BUG/BUGWK in test_expectations is error prone, should use BUGCR/BUGWK
2477         https://bugs.webkit.org/show_bug.cgi?id=48926
2478
2479         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2480         Add presubmit check that BUG isn't used, either BUGCR/BUGWK/BUGV8_.
2481
2482 2010-12-14  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2483
2484         Reviewed by Eric Seidel.
2485
2486         [Qt] [Symbian] Do not use pkg-config on Symbian as it is not supported
2487         https://bugs.webkit.org/show_bug.cgi?id=50231
2488
2489         Guard CONFIG+=link_pkgconfig with !symbian.
2490
2491         * DumpRenderTree/qt/DumpRenderTree.pro:
2492         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2493         * WebKitTestRunner/qt/WebKitTestRunner.pro:
2494
2495 2010-12-14  Philippe Normand  <pnormand@igalia.com>
2496
2497         Reviewed by Ojan Vafai.
2498
2499         [new-run-webkit-tests] expectations parsing is slow
2500         https://bugs.webkit.org/show_bug.cgi?id=50635
2501
2502         Avoid expensive iteration of all the tests when checking if a test
2503         file is to be skipped or not.
2504
2505         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2506         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
2507         * Scripts/webkitpy/layout_tests/port/test.py:
2508
2509 2010-12-14  Mario Sanchez Prada  <msanchez@igalia.com>
2510
2511         Reviewed by Xan Lopez.
2512
2513         [Gtk] Implement STATE_FOCUSED, STATE_FOCUSABLE, and corresponding events for text objects
2514         https://bugs.webkit.org/show_bug.cgi?id=27048
2515
2516         Add support in DRT for checking whether an accessibility UI
2517         element is focusable and/or focused. Implemented for GTK.
2518
2519         * DumpRenderTree/AccessibilityUIElement.cpp:
2520         (getIsFocusedCallback): New.
2521         (getIsFocusableCallback): New.
2522         (AccessibilityUIElement::getJSClass): Add the new available
2523         callbacks for isFocused and isFocusable.
2524         * DumpRenderTree/AccessibilityUIElement.h:
2525         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2526         (AccessibilityUIElement::isFocused): New, implemented by checking
2527         whether the related AtkState value is in the object's state set.
2528         (AccessibilityUIElement::isFocusable): Ditto.
2529         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2530         (AccessibilityUIElement::isFocused): New, dummy implementation.
2531         (AccessibilityUIElement::isFocusable): Ditto.
2532         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2533         (AccessibilityUIElement::isFocused): Ditto.
2534         (AccessibilityUIElement::isFocusable): Ditto.
2535
2536 2010-12-14  Eric Seidel  <eric@webkit.org>
2537
2538         Reviewed by Ojan Vafai.
2539
2540         webkit-patch should warn users when they're using a 32-bit git on a 64-bit system
2541         https://bugs.webkit.org/show_bug.cgi?id=50715
2542
2543         This patch makes webkit-patch print the following:
2544
2545         Warning: This machine is 64-bit, but the git binary (/usr/local/git/bin/git) does not support 64-bit.
2546         Install a 64-bit git for better performance, see:
2547         https://lists.webkit.org/pipermail/webkit-dev/2010-December/015249.html
2548
2549         I wrote this mostly because I have approximately 8 machines that I use
2550         and making sure each one is using a good Git install seemed folly.
2551         webkit-patch makes a lot of git calls, so using a fast git can shave
2552         several seconds in every invocation.  See the webkit-dev thread for more info.
2553
2554         This message will print twice during 'webkit-patch upload',
2555         once from webkit-patch and once from check-webkit-style.
2556
2557         Unfortunately there is no good way to test this due to how machine-dependent
2558         the code is.  I considered writing a test for the log message, but it seemed not worth it.
2559
2560         * Scripts/webkitpy/common/checkout/scm.py:
2561
2562 2010-12-13  Eric Seidel  <eric@webkit.org>
2563
2564         Reviewed by Adam Barth.
2565
2566         FlakyTestReporter doesn't understand bots running from multiple email addresses
2567         https://bugs.webkit.org/show_bug.cgi?id=50960
2568
2569         This explains at least one of the dupes of:
2570         https://bugs.webkit.org/show_bug.cgi?id=50863
2571         that we saw filed by the commit-queue this morning.
2572         I think the other one was explained by my previous fix to result counting code.
2573
2574         Since this is really hard to test with a unit test, instead I
2575         create a new (possibly useful in the future) command
2576         which given a layout test path will return you
2577         the one bug which our tools would assume it the flaky test bug.
2578         If some other script wants to use bug-for-test we'll
2579         need to extend it with some options like --create-if-missing or similar.
2580
2581         * Scripts/webkitpy/common/net/bugzilla/bug.py:
2582         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2583         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2584         * Scripts/webkitpy/tool/commands/__init__.py:
2585         * Scripts/webkitpy/tool/commands/bugfortest.py: Added.
2586
2587 2010-12-13  Mihai Parparita  <mihaip@chromium.org>
2588
2589         Reviewed by James Robinson.
2590
2591         Add option to build-webkit to not build WebKit2
2592         https://bugs.webkit.org/show_bug.cgi?id=50988
2593         
2594         Add support for a --no-webkit2 option to build-webkit. It seems to save
2595         ~1 minute from clean builds and ~10 seconds from no-op builds.
2596
2597         * Scripts/build-webkit:
2598
2599 2010-12-13  Lucas Forschler  <lforschler@apple.com>
2600
2601         Reviewed by Dave Kilzer.
2602
2603         Update iexploder from 1.3.2 to 1.7.2
2604         Move 1.3.2 into its own subdir
2605         Add 1.7.2 into its own subdir
2606         update scripts to point to new 1.3.2 location (avoid breaking existing scripts)
2607
2608         * Scripts/run-iexploder-tests:
2609         * Scripts/update-iexploder-cssproperties:
2610         * iExploder/CHANGELOG.txt: Removed.
2611         * iExploder/LICENSE.txt: Removed.
2612         * iExploder/README.txt: Removed.
2613         * iExploder/htdocs: Removed.
2614         * iExploder/iexploder-1.3.2: Added.
2615         * iExploder/iexploder-1.3.2/CHANGELOG.txt: Copied from iExploder/CHANGELOG.txt.
2616         * iExploder/iexploder-1.3.2/LICENSE.txt: Copied from iExploder/LICENSE.txt.
2617         * iExploder/iexploder-1.3.2/README.txt: Copied from iExploder/README.txt.
2618         * iExploder/iexploder-1.3.2/htdocs: Added.
2619         * iExploder/iexploder-1.3.2/htdocs/config.rb: Copied from iExploder/htdocs/config.rb.
2620         * iExploder/iexploder-1.3.2/htdocs/cssproperties.in: Copied from iExploder/htdocs/cssproperties.in.
2621         * iExploder/iexploder-1.3.2/htdocs/cssvalues.in: Copied from iExploder/htdocs/cssvalues.in.
2622         * iExploder/iexploder-1.3.2/htdocs/htmlattrs.in: Copied from iExploder/htdocs/htmlattrs.in.
2623         * iExploder/iexploder-1.3.2/htdocs/htmltags.in: Copied from iExploder/htdocs/htmltags.in.
2624         * iExploder/iexploder-1.3.2/htdocs/htmlvalues.in: Copied from iExploder/htdocs/htmlvalues.in.
2625         * iExploder/iexploder-1.3.2/htdocs/iexploder.cgi: Copied from iExploder/htdocs/iexploder.cgi.
2626         * iExploder/iexploder-1.3.2/htdocs/iexploder.rb: Copied from iExploder/htdocs/iexploder.rb.
2627         * iExploder/iexploder-1.3.2/htdocs/index.html: Copied from iExploder/htdocs/index.html.
2628         * iExploder/iexploder-1.3.2/htdocs/webserver.rb: Copied from iExploder/htdocs/webserver.rb.
2629         * iExploder/iexploder-1.3.2/tools: Added.
2630         * iExploder/iexploder-1.3.2/tools/lasthit.rb: Copied from iExploder/tools/lasthit.rb.
2631         * iExploder/iexploder-1.3.2/tools/osx_last_crash.rb: Copied from iExploder/tools/osx_last_crash.rb.
2632         * iExploder/iexploder-1.3.2/tools/showtest.rb: Copied from iExploder/tools/showtest.rb.
2633         * iExploder/iexploder-1.7.2: Added.
2634         * iExploder/iexploder-1.7.2/ChangeLog.txt: Added.
2635         * iExploder/iexploder-1.7.2/LICENSE.txt: Added.
2636         * iExploder/iexploder-1.7.2/README.txt: Added.
2637         * iExploder/iexploder-1.7.2/output: Added.
2638         * iExploder/iexploder-1.7.2/src: Added.
2639         * iExploder/iexploder-1.7.2/src/browser_harness.rb: Added.
2640         * iExploder/iexploder-1.7.2/src/config.yaml: Added.
2641         * iExploder/iexploder-1.7.2/src/css-atrules: Added.
2642         * iExploder/iexploder-1.7.2/src/css-atrules/mozilla: Added.
2643         * iExploder/iexploder-1.7.2/src/css-atrules/webkit: Added.
2644         * iExploder/iexploder-1.7.2/src/css-properties: Added.
2645         * iExploder/iexploder-1.7.2/src/css-properties/dillo: Added.
2646         * iExploder/iexploder-1.7.2/src/css-properties/gtkhtml: Added.
2647         * iExploder/iexploder-1.7.2/src/css-properties/internet_explorer6: Added.
2648         * iExploder/iexploder-1.7.2/src/css-properties/mozilla: Added.
2649         * iExploder/iexploder-1.7.2/src/css-properties/webkit: Added.
2650         * iExploder/iexploder-1.7.2/src/css-pseudo: Added.
2651         * iExploder/iexploder-1.7.2/src/css-pseudo/mozilla: Added.
2652         * iExploder/iexploder-1.7.2/src/css-pseudo/webkit: Added.
2653         * iExploder/iexploder-1.7.2/src/css-values: Added.
2654         * iExploder/iexploder-1.7.2/src/css-values/dillo: Added.
2655         * iExploder/iexploder-1.7.2/src/css-values/gtkhtml: Added.
2656         * iExploder/iexploder-1.7.2/src/css-values/mozilla: Added.
2657         * iExploder/iexploder-1.7.2/src/css-values/other: Added.
2658         * iExploder/iexploder-1.7.2/src/css-values/webkit: Added.
2659         * iExploder/iexploder-1.7.2/src/headers: Added.
2660         * iExploder/iexploder-1.7.2/src/headers/dillo: Added.
2661         * iExploder/iexploder-1.7.2/src/headers/gtkhtml: Added.
2662         * iExploder/iexploder-1.7.2/src/headers/mozilla: Added.
2663         * iExploder/iexploder-1.7.2/src/headers/webkit: Added.
2664         * iExploder/iexploder-1.7.2/src/html-attrs: Added.
2665         * iExploder/iexploder-1.7.2/src/html-attrs/dillo: Added.
2666         * iExploder/iexploder-1.7.2/src/html-attrs/gtkhtml: Added.
2667         * iExploder/iexploder-1.7.2/src/html-attrs/internet_explorer6: Added.
2668         * iExploder/iexploder-1.7.2/src/html-attrs/mozilla: Added.
2669         * iExploder/iexploder-1.7.2/src/html-attrs/other: Added.
2670         * iExploder/iexploder-1.7.2/src/html-attrs/webkit: Added.
2671         * iExploder/iexploder-1.7.2/src/html-tags: Added.
2672         * iExploder/iexploder-1.7.2/src/html-tags/dillo: Added.
2673         * iExploder/iexploder-1.7.2/src/html-tags/gtkhtml: Added.
2674         * iExploder/iexploder-1.7.2/src/html-tags/mozilla: Added.
2675         * iExploder/iexploder-1.7.2/src/html-tags/other: Added.
2676         * iExploder/iexploder-1.7.2/src/html-tags/webkit: Added.
2677         * iExploder/iexploder-1.7.2/src/html-values: Added.
2678         * iExploder/iexploder-1.7.2/src/html-values/dillo: Added.
2679         * iExploder/iexploder-1.7.2/src/html-values/gtkhtml: Added.
2680         * iExploder/iexploder-1.7.2/src/html-values/mozilla: Added.
2681         * iExploder/iexploder-1.7.2/src/html-values/other: Added.
2682         * iExploder/iexploder-1.7.2/src/html-values/webkit: Added.
2683         * iExploder/iexploder-1.7.2/src/iexploder.cgi: Added.
2684         * iExploder/iexploder-1.7.2/src/iexploder.rb: Added.
2685         * iExploder/iexploder-1.7.2/src/index.html: Added.
2686         * iExploder/iexploder-1.7.2/src/media: Added.
2687         * iExploder/iexploder-1.7.2/src/media/blank.ogg: Added.
2688         * iExploder/iexploder-1.7.2/src/media/blank.snd: Added.
2689         * iExploder/iexploder-1.7.2/src/media/blank.wav: Added.
2690         * iExploder/iexploder-1.7.2/src/media/bug.bmp: Added.
2691         * iExploder/iexploder-1.7.2/src/media/bug.gif: Added.
2692         * iExploder/iexploder-1.7.2/src/media/bug.ico: Added.
2693         * iExploder/iexploder-1.7.2/src/media/bug.jng: Added.
2694         * iExploder/iexploder-1.7.2/src/media/bug.jpg: Added.
2695         * iExploder/iexploder-1.7.2/src/media/bug.png: Added.
2696         * iExploder/iexploder-1.7.2/src/media/bug.svg: Added.
2697         * iExploder/iexploder-1.7.2/src/media/bug.tiff: Added.
2698         * iExploder/iexploder-1.7.2/src/media/bug.xbm: Added.
2699         * iExploder/iexploder-1.7.2/src/media/bug.xpm: Added.
2700         * iExploder/iexploder-1.7.2/src/mime-types: Added.
2701         * iExploder/iexploder-1.7.2/src/mime-types/dillo: Added.
2702         * iExploder/iexploder-1.7.2/src/mime-types/mozilla: Added.
2703         * iExploder/iexploder-1.7.2/src/mime-types/webkit: Added.
2704         * iExploder/iexploder-1.7.2/src/protocols: Added.
2705         * iExploder/iexploder-1.7.2/src/protocols/dillo: Added.
2706         * iExploder/iexploder-1.7.2/src/protocols/gtkhtml: Added.
2707         * iExploder/iexploder-1.7.2/src/protocols/mozilla: Added.
2708         * iExploder/iexploder-1.7.2/src/protocols/webkit: Added.
2709         * iExploder/iexploder-1.7.2/src/scanner.rb: Added.
2710         * iExploder/iexploder-1.7.2/src/version.rb: Added.
2711         * iExploder/iexploder-1.7.2/src/webserver.rb: Added.
2712         * iExploder/iexploder-1.7.2/testcases: Added.
2713         * iExploder/iexploder-1.7.2/testcases/testcase-Linux_x86_64_rv2.0b6pre_Gecko-20100904_Firefox-4.0b6pre-TEST-8375-1_59.html: Added.
2714         * iExploder/iexploder-1.7.2/testcases/testcase-Opera-9.80_Linux_x86_64_en_Presto-2.6.30_Version-10.61-16704-3_108,3.html: Added.
2715         * iExploder/iexploder-1.7.2/testcases/testcase-U_Intel_Mac_OS_X_10_6_4_en-US_AppleWebKit-534.8_Chrome-7.0.529.0-TEST-611-3_36,9.html: Added.
2716         * iExploder/iexploder-1.7.2/testcases/testcase-U_Intel_Mac_OS_X_10_6_4_en-US_AppleWebKit-534.8_hrome-7.0.529.0-TEST-55313622206-3_6,0.html: Added.
2717         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.6_Chrome-7.0.503.1-TEST-120813-8_72,56,24,8,0.html: Added.
2718         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.6_Chrome-7.0.503.1-TEST-121240-3_81,3.html: Added.
2719         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.7_Chrome-7.0.513.0-4800-5_80,65,15.html: Added.
2720         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.7_Chrome-7.0.513.0-TEST-23583190347-3_15,12.html: Added.
2721         * iExploder/iexploder-1.7.2/tools: Added.
2722         * iExploder/iexploder-1.7.2/tools/lasthit.rb: Added.
2723         * iExploder/iexploder-1.7.2/tools/osx_last_crash.rb: Added.
2724         * iExploder/iexploder-1.7.2/tools/release_src.sh: Added.
2725         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh: Added.
2726         * iExploder/tools: Removed.
2727
2728 2010-12-13  Sam Weinig  <sam@webkit.org>
2729
2730         Reviewed by Anders Carlsson.
2731
2732         Remove associated page concept from WKView constructor
2733         https://bugs.webkit.org/show_bug.cgi?id=50983
2734
2735         Step 1: Remove associate page constructors from WKView and make
2736         all views use the shared namespace for the context.
2737
2738         * TestWebKitAPI/PlatformWebView.h:
2739         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
2740         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
2741         * WebKitTestRunner/PlatformWebView.h:
2742         * WebKitTestRunner/TestController.cpp:
2743         (WTR::createOtherPage):
2744         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2745         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2746         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2747
2748 2010-12-13  Sam Weinig  <sam@webkit.org>
2749
2750         Reviewed by Anders Carlsson.
2751
2752         Change the WebKit2 public API so there is no explicit WKPageNamespace object
2753         https://bugs.webkit.org/show_bug.cgi?id=50898
2754
2755         * MiniBrowser/mac/AppDelegate.h:
2756         * MiniBrowser/mac/AppDelegate.m:
2757         * MiniBrowser/mac/BrowserWindowController.h:
2758         * MiniBrowser/mac/BrowserWindowController.m:
2759         * MiniBrowser/win/BrowserView.cpp:
2760         Convert MiniBrowser to not use PageNamespaces.
2761
2762         * TestWebKitAPI/PlatformWebView.h:
2763         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
2764         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
2765         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
2766         * TestWebKitAPI/Tests/WebKit2/Find.cpp:
2767         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
2768         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
2769         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
2770         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
2771         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
2772         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
2773         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
2774         * TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp:
2775         * TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp:
2776         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
2777         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
2778         Convert TestWebKitAPI to not use PageNamespaces.
2779
2780         * WebKitTestRunner/PlatformWebView.h:
2781         * WebKitTestRunner/TestController.cpp:
2782         * WebKitTestRunner/TestController.h:
2783         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2784         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2785         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2786         Convert WebKitTestRunner to not use PageNamespaces.
2787
2788 2010-12-13  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
2789
2790         Reviewed by Eric Seidel.
2791
2792         webkit-patch rollout should be able to do multi-revision rollouts
2793         https://bugs.webkit.org/show_bug.cgi?id=33336
2794
2795         Make it possible to pass more than one revision to webkit-patch.
2796
2797         * Scripts/webkitpy/common/checkout/api.py:
2798         * Scripts/webkitpy/common/checkout/changelog.py:
2799         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2800         * Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:
2801         * Scripts/webkitpy/tool/commands/download.py:
2802         * Scripts/webkitpy/tool/commands/download_unittest.py:
2803         * Scripts/webkitpy/tool/mocktool.py:
2804         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
2805         * Scripts/webkitpy/tool/steps/revertrevision.py:
2806
2807 2010-12-13  Eric Seidel  <eric@webkit.org>
2808
2809         Unreviewed.
2810
2811         Teach webkit-patch how to search bugzilla
2812         https://bugs.webkit.org/show_bug.cgi?id=50500
2813
2814         webkit-patch bug-search fails when there is only one result.
2815         Turns out we needed a bit more logic in our result count parsing code.
2816
2817         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2818         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
2819
2820 2010-12-13  Antti Koivisto  <antti@apple.com>
2821
2822         Reviewed by Alexey Proskuryakov.
2823
2824         Add setSerializeHTTPLoads function to allow testing resource load order on OS X.
2825         https://bugs.webkit.org/show_bug.cgi?id=50758
2826
2827         * DumpRenderTree/LayoutTestController.cpp:
2828         (setSerializeHTTPLoadsCallback):
2829         (LayoutTestController::staticFunctions):
2830         * DumpRenderTree/LayoutTestController.h:
2831         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2832         (LayoutTestController::setSerializeHTTPLoads):
2833         * DumpRenderTree/mac/DumpRenderTree.mm:
2834         (resetDefaultsToConsistentValues):
2835         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2836         (LayoutTestController::setSerializeHTTPLoads):
2837         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2838         (LayoutTestController::setSerializeHTTPLoads):
2839
2840 2010-12-13  Dimitri Glazkov  <dglazkov@chromium.org>
2841
2842         Reviewed by Ojan Vafai.
2843
2844         Remove "use-drt" option from test step command line, since the option was removed in r73748.
2845         https://bugs.webkit.org/show_bug.cgi?id=50936
2846
2847         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Removed the option.
2848
2849 2010-12-13  Patrick Gansterer  <paroga@webkit.org>
2850
2851         Reviewed by Csaba Osztrogonác.
2852
2853         Add revlink to BuildBot status
2854         https://bugs.webkit.org/show_bug.cgi?id=50914
2855
2856         This adds a hyperlink to trac changeset on the revision numbers. 
2857
2858         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2859
2860 2010-12-13  Andras Becsi  <abecsi@webkit.org>
2861
2862         Reviewed by Csaba Osztrogonác.
2863
2864         [Qt][WK2] Fix build if WebKitTools are not available
2865         https://bugs.webkit.org/show_bug.cgi?id=50242
2866
2867         * MiniBrowser/qt/MiniBrowser.pro: Correct the comment.
2868         * Scripts/webkitdirs.pm: Added WebKitTools/MiniBrowser to $subdirs.
2869         * MiniBrowser/DerivedSources.pro: Added.
2870
2871 2010-12-13  Eric Seidel  <eric@webkit.org>
2872
2873         Reviewed by Adam Barth.
2874
2875         EWS Queues should remove orpahned pyc files before starting
2876         https://bugs.webkit.org/show_bug.cgi?id=50904
2877
2878         A previous check added a platform.py which caused
2879         EWS bots on some platforms to hit an import exception.
2880         The platform.py file was removed in a subsequent commit, but
2881         the EWS bots in question stayed stuck.  This change will
2882         fix those bots once restarted (and prevent this in the future).
2883
2884         I also went ahead and unified start-queue and start-commit-queue
2885         since they were nearly identical.  I also added bot_id support
2886         to both force all EWSes to have bot ids as well as get rid of the one
2887         remaining reason why I had my own copies of these scripts.
2888         Hopefully this will be enough to get all the other bot admins
2889         (ahem, Adam, ahem) to move to using these checked in copies as well.
2890
2891         * EWSTools/start-commit-queue.sh: Removed.
2892         * EWSTools/start-queue.sh:
2893
2894 2010-10-28  MORITA Hajime  <morrita@google.com>
2895
2896         Reviewed by Ojan Vafai.
2897
2898         spellcheck does not check pasted text
2899         https://bugs.webkit.org/show_bug.cgi?id=40092
2900
2901         Added LayoutTestController::setAsynchronousSpellCheckingEnabled()
2902         to control the setting.
2903
2904         * DumpRenderTree/LayoutTestController.cpp:
2905         (setAsynchronousSpellCheckingEnabledCallback):
2906         (LayoutTestController::staticFunctions):
2907         * DumpRenderTree/LayoutTestController.h:
2908         * DumpRenderTree/chromium/LayoutTestController.h:
2909         * DumpRenderTree/chromium/LayoutTestController.cpp:
2910         (LayoutTestController::LayoutTestController):
2911         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
2912         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2913         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
2914         * DumpRenderTree/mac/DumpRenderTree.mm:
2915         (resetDefaultsToConsistentValues):
2916         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2917         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
2918         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2919         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2920         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
2921         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2922         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
2923         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2924         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
2925
2926 2010-12-12  Sam Weinig  <sam@webkit.org>
2927
2928         Reviewed by Anders Carlsson.
2929
2930         Fix failing API test. It turns out that a pop-state event
2931         is sent before every fragment navigation, so we have to test
2932         for it in addition in PageLoadDidChangeLocationWithinPageForFrame.
2933
2934         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
2935         (TestWebKitAPI::didSameDocumentNavigationForFrame):
2936
2937 2010-12-12  Alejandro G. Castro  <alex@igalia.com>
2938
2939         Reviewed by Eric Seidel.
2940
2941         [GTK] Add new-run-webkit-tests support to gtk
2942         https://bugs.webkit.org/show_bug.cgi?id=50681
2943
2944         Adding the basic support to run the new-run-webkit-tests.
2945
2946         * Scripts/webkitpy/layout_tests/port/gtk.py:
2947
2948 2010-10-11  Diego Gonzalez  <diegohcg@webkit.org>
2949
2950         Reviewed by Kenneth Rohde Christiansen.
2951
2952         [Qt] Mock DeviceOrientation client for DRT
2953         https://bugs.webkit.org/show_bug.cgi?id=47490
2954
2955         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2956         (WebCore::DumpRenderTree::DumpRenderTree):
2957         (WebCore::DumpRenderTree::~DumpRenderTree):
2958         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2959         (LayoutTestController::setMockDeviceOrientation):
2960
2961 2010-12-11  Philippe Normand  <pnormand@igalia.com>
2962
2963         Reviewed by Gustavo Noronha Silva.
2964
2965         [GTK] launcher: disable the Mozilla-style fullscreen API
2966         https://bugs.webkit.org/show_bug.cgi?id=50874
2967
2968         Disabling the fullscreen API until its implementation for GTK is
2969         mature enough. The webview setting for it is already FALSE by
2970         default.
2971
2972         * GtkLauncher/main.c:
2973         (createWindow):
2974
2975 2010-12-10  Eric Seidel  <eric@webkit.org>
2976
2977         Reviewed by Adam Barth.
2978
2979         commit-queue flaky test messages show cryptic version information for mac os x
2980         https://bugs.webkit.org/show_bug.cgi?id=50864
2981
2982         Turns out platform.platform() returns kernel version information
2983         which isn't helpful, and just plain confusing on Mac
2984         (OS X 10.6.5 uses Darwin Kernel 10.5.0).
2985
2986         So I've updated PlatformInfo.display_name() to special case
2987         mac.  I also found a bad use of sys.platform in the process
2988         and fixed that.  (sys.platform always returns 'darwin' on mac).
2989
2990         * Scripts/webkitpy/common/system/platforminfo.py:
2991         * Scripts/webkitpy/common/system/user.py:
2992         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2993         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2994         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2995
2996 2010-12-10  Eric Seidel  <eric@webkit.org>
2997
2998         Unreviewed.
2999
3000         Exception seen while reporting flaky test with commit-queue.
3001         Just a missing include.
3002
3003         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3004         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3005
3006 2010-12-10  Kinuko Yasuda  <kinuko@chromium.org>
3007
3008         Reviewed by Eric Seidel.
3009
3010         [Chromium] Remove old JSONResultsGenerator script that existed for backward-compatibility
3011         https://bugs.webkit.org/show_bug.cgi?id=50796
3012
3013         Also updating the test code to use JSONResultsGeneratorBase and
3014         to improve test coverage for incremental cases.
3015
3016         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3017         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
3018
3019 2010-12-10  Joseph Pecoraro  <joepeck@webkit.org>
3020
3021         Reviewed by Darin Adler.
3022
3023         prepare-ChangeLog --help doesn't mention --bug shorthand -b
3024         https://bugs.webkit.org/show_bug.cgi?id=50835
3025
3026         * Scripts/prepare-ChangeLog: be more explicit about -b and match file style.
3027
3028 2010-12-10  Eric Seidel  <eric@webkit.org>
3029
3030         Reviewed by Adam Barth.
3031
3032         Bugs created by the commit-queue should all block on a master bug
3033         https://bugs.webkit.org/show_bug.cgi?id=50857
3034
3035         This makes all bugs created by the commit-queue block on:
3036         https://bugs.webkit.org/show_bug.cgi?id=50856
3037
3038         In the process of testing this, I found that the existing
3039         create_bug code was wrong.  I also found that existing
3040         unit tests for create-rollout used invalid values
3041         for options.blocks.  I fixed both issues and tested.
3042
3043         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3044         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3045         * Scripts/webkitpy/tool/commands/commandtest.py:
3046         * Scripts/webkitpy/tool/commands/download_unittest.py:
3047         * Scripts/webkitpy/tool/commands/upload_unittest.py:
3048         * Scripts/webkitpy/tool/mocktool.py:
3049         * Scripts/webkitpy/tool/steps/options.py:
3050
3051 2010-12-10  Eric Seidel  <eric@webkit.org>
3052
3053         Reviewed by Adam Barth.
3054
3055         Teach webkitpy how to follow duplicate chains when posting comments on flake bugs
3056         https://bugs.webkit.org/show_bug.cgi?id=50853
3057
3058         I also discovered when doing this that the code was posting
3059         the comment on the wrong bug, but that's fixed here too.
3060
3061         * Scripts/webkitpy/common/net/bugzilla/bug.py:
3062         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3063         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3064         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3065         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3066         * Scripts/webkitpy/tool/mocktool.py:
3067
3068 2010-12-10  Anders Carlsson  <andersca@apple.com>
3069
3070         Reviewed by John Sullivan.
3071
3072         Make WKContextGetStatistics gather global statistics
3073         https://bugs.webkit.org/show_bug.cgi?id=50850
3074
3075         Remove the code that gets the statistics and fills in the per context
3076         statistics information for now.
3077
3078         * MiniBrowser/mac/BrowserStatisticsWindowController.m:
3079         (-[BrowserStatisticsWindowController refreshStatistics:]):
3080
3081 2010-12-10  Eric Seidel  <eric@webkit.org>
3082
3083         Unreviewed.
3084
3085         commit-queue should report port/platform information when commenting on flaky test bugs
3086         https://bugs.webkit.org/show_bug.cgi?id=50839
3087
3088         Renamed platform.py to platforminfo.py.  This broke import platform in executive.py
3089         which was only used by new run webkit tests (and clearly not unit tested).
3090
3091         * Scripts/webkitpy/common/system/platforminfo.py: Renamed from WebKitTools/Scripts/webkitpy/common/system/platform.py.
3092         * Scripts/webkitpy/tool/main.py:
3093         * Scripts/webkitpy/tool/mocktool.py:
3094
3095 2010-12-10  Eric Seidel  <eric@webkit.org>
3096
3097         Reviewed by Tony Chang.
3098
3099         commit-queue should report port/platform information when commenting on flaky test bugs
3100         https://bugs.webkit.org/show_bug.cgi?id=50839
3101
3102         This was a suggestion from Tony Chang this morning.
3103         I added a platform.py class so I could easily mock the platform call,
3104         but that may not be the final solution for this mocking.
3105         We'll try it and see.
3106
3107         * Scripts/webkitpy/common/system/platform.py: Added.
3108         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3109         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3110         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3111         * Scripts/webkitpy/tool/main.py:
3112         * Scripts/webkitpy/tool/mocktool.py:
3113
3114 2010-12-10  Krithigassree Sambamurthy  <krithigassree.sambamurthy@nokia.com>
3115
3116         Reviewed by Joseph Pecoraro.
3117
3118         Bug 43455 - [Qt]: Implement Application Cache Quotas
3119         https://bugs.webkit.org/show_bug.cgi?id=43455
3120
3121         Introduce functions to allow new appcache layout test origin-quota.html
3122         to work correctly under Qt.
3123
3124         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3125         (WebCore::DumpRenderTree::DumpRenderTree):
3126         (WebCore::DumpRenderTree::dumpApplicationCacheQuota):
3127         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3128
3129         Introduce functions to allow new appcache layout test origin-quota.html
3130         to be successful under qt. Changes required because LayoutTestControllerQt
3131         does not inherit from LayoutController.
3132
3133         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3134         (LayoutTestController::reset):
3135         (LayoutTestController::clearAllApplicationCaches):
3136         (LayoutTestController::setApplicationCacheOriginQuota):
3137         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3138         (LayoutTestController::shouldDumpApplicationCacheDelegateCallbacks):
3139         (LayoutTestController::dumpApplicationCacheDelegateCallbacks):
3140
3141 2010-12-10  Eric Seidel  <eric@webkit.org>
3142
3143         Reviewed by Adam Barth.
3144
3145         Move buildbot.py into its own module so we can split it out into one-file-per-class
3146         https://bugs.webkit.org/show_bug.cgi?id=50806
3147
3148         We're adding more buildbot logic these days, so it makes sense
3149         to give buildbot its own module.
3150
3151         * Scripts/webkitpy/common/net/buildbot/__init__.py: Added.
3152         * Scripts/webkitpy/common/net/buildbot/buildbot.py: Renamed from WebKitTools/Scripts/webkitpy/common/net/buildbot.py.
3153         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py: Renamed from WebKitTools/Scripts/webkitpy/common/net/buildbot_unittest.py.
3154         * Scripts/webkitpy/common/net/failuremap.py:
3155         * Scripts/webkitpy/common/net/regressionwindow.py:
3156         * Scripts/webkitpy/tool/commands/rebaseline.py:
3157
3158 2010-12-10  Tony Chang  <tony@chromium.org>
3159
3160         Reviewed by Eric Seidel.
3161
3162         Use FileSystem::remove when cleaning up http lock files
3163         https://bugs.webkit.org/show_bug.cgi?id=50830
3164
3165         * Scripts/webkitpy/layout_tests/port/http_lock.py:
3166
3167 2010-12-10  Joone Hur  <joone@kldp.org>
3168
3169         Reviewed by Martin Robinson.
3170
3171         [GTK] DRT needs layoutTestController.setCacheModel
3172         https://bugs.webkit.org/show_bug.cgi?id=50705
3173         
3174         webkit_set_cache_mode() is called to set the cache model.
3175         
3176         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3177         (LayoutTestController::setCacheModel): Set the cache model. 
3178
3179 2010-12-10  Tony Chang  <tony@chromium.org>
3180
3181         Reviewed by Ojan Vafai.
3182
3183         [chromium] remove --use-drt and add --use-test-shell
3184         https://bugs.webkit.org/show_bug.cgi?id=50701
3185
3186         * Scripts/webkitpy/common/config/ports.py:
3187         * Scripts/webkitpy/common/config/ports_unittest.py:
3188         * Scripts/webkitpy/layout_tests/port/chromium.py:
3189         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
3190         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
3191         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3192         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3193         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3194         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3195         * Scripts/webkitpy/layout_tests/port/webkit.py:
3196         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3197         * Scripts/webkitpy/style/checkers/test_expectations.py:
3198         * Scripts/webkitpy/tool/commands/queries.py:
3199
3200 2010-12-10  John Knottenbelt  <jknotten@chromium.org>
3201
3202         Reviewed by Steve Block.
3203
3204         [Chromium] Implement mocks for client-based geolocation
3205         https://bugs.webkit.org/show_bug.cgi?id=46895
3206
3207         * DumpRenderTree/chromium/LayoutTestController.cpp:
3208         (LayoutTestController::setGeolocationPermission):
3209         (LayoutTestController::setMockGeolocationPosition):
3210         (LayoutTestController::setMockGeolocationError):
3211         * DumpRenderTree/chromium/LayoutTestController.h:
3212         * DumpRenderTree/chromium/WebViewHost.cpp:
3213         (WebViewHost::geolocationClient):
3214         (WebViewHost::geolocationClientMock):
3215         (WebViewHost::reset):
3216         * DumpRenderTree/chromium/WebViewHost.h:
3217
3218 2010-12-10  Alejandro G. Castro  <alex@igalia.com>
3219
3220         Reviewed by Martin Robinson.
3221
3222         [GTK] Add hasSpellingMarker support to the DRT
3223         https://bugs.webkit.org/show_bug.cgi?id=50739
3224
3225         Implemented the hasSpellingMarker to support spelling tests.
3226
3227         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3228         (LayoutTestController::hasSpellingMarker):
3229
3230 2010-12-10  Eric Seidel  <eric@webkit.org>
3231
3232         Reviewed by Ojan Vafai.
3233
3234         webkit-patch: not possible to use build-and-test with local commits
3235         https://bugs.webkit.org/show_bug.cgi?id=33378
3236
3237         Make --no-clean not even check if we have local commits.
3238         It's unclear to me why the code was originally written this way.
3239         I was unable to dig up a reason from svn history.
3240
3241         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
3242         * Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py: Copied from WebKitTools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.
3243
3244 2010-12-10  Mario Sanchez Prada  <msanchez@igalia.com>
3245
3246         Reviewed by Martin Robinson.
3247
3248         [GTK] AX: implement isEnabled in DRT
3249         https://bugs.webkit.org/show_bug.cgi?id=50814
3250
3251         Implement AccessibilityUIElement::isEnabled() for GTK.
3252
3253         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3254         (checkElementState): New function to refactor common code.
3255         (AccessibilityUIElement::isEnabled): Implement this by checking
3256         the current state of the AtkObject.
3257         (AccessibilityUIElement::isSelected): Use the new
3258         checkElementState function.
3259
3260 2010-12-10  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
3261
3262         Reviewed by Kenneth Rohde Christiansen.
3263
3264         [Qt][WK2] Add the QWKContext API class to wrap the WebContext.
3265         https://bugs.webkit.org/show_bug.cgi?id=50750
3266
3267         * MiniBrowser/qt/BrowserView.cpp:
3268         (BrowserView::BrowserView):
3269         * MiniBrowser/qt/BrowserView.h:
3270         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3271         (WTR::WebView::WebView):
3272
3273 2010-12-10  Joone Hur  <joone@kldp.org>
3274
3275         Reviewed by Xan Lopez.
3276
3277         [GTK] Unskipping some test cases in userscripts dependent on addUserStyleSheet
3278         https://bugs.webkit.org/show_bug.cgi?id=50808
3279
3280         Unskipping the following test cases:
3281         userscripts/mixed-case-stylesheet.html
3282         userscripts/simple-stylesheet.html
3283         userscripts/user-style-all-frames.html
3284
3285         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3286         (LayoutTestController::addUserStyleSheet):
3287
3288 2010-12-10  Joone Hur  <joone@kldp.org>
3289
3290         Reviewed by Eric Seidel.
3291
3292         [GTK] Add DRT support for pageProperty, isPageBoxVisible, pageSizeAndMarginsInPixels, and addUserStyleSheet
3293         https://bugs.webkit.org/show_bug.cgi?id=50783
3294
3295         This patch allows to unskip the following test cases:
3296         printing/page-rule-selection.html
3297         printing/page-format-data.html
3298
3299         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3300         (LayoutTestController::pageProperty): Added.
3301         (LayoutTestController::isPageBoxVisible): Ditto.
3302         (LayoutTestController::pageSizeAndMarginsInPixels): Ditto.
3303         (LayoutTestController::addUserStyleSheet): Ditto.
3304
3305 2010-12-10  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
3306
3307         Reviewed by Kenneth Rohde Christiansen.
3308
3309         [Qt] Make QtTestBrowser spawn QNAM in a secondary thread.
3310
3311         A menu allows to switch QNAM back to the same thread.
3312
3313         * QtTestBrowser/launcherwindow.cpp:
3314         (LauncherWindow::initializeView):
3315         (LauncherWindow::createChrome):
3316         (LauncherWindow::toggleThreadedQnam):
3317         * QtTestBrowser/launcherwindow.h:
3318         (WindowOptions::WindowOptions):
3319         * QtTestBrowser/webpage.cpp:
3320         (WebPage::WebPage):
3321         (WebPage::setQnamThreaded):
3322         * QtTestBrowser/webpage.h:
3323         (QnamThread::QnamThread):
3324         (QnamThread::~QnamThread):
3325         (QnamThread::networkAccessManager):
3326         (QnamThread::run):
3327
3328 2010-12-10  Martin Robinson  <mrobinson@igalia.com>
3329
3330         Reviewed by Xan Lopez.
3331
3332         [Gtk] style="font-family: courier" makes text disappear
3333         https://bugs.webkit.org/show_bug.cgi?id=47452
3334
3335         Add a test that verifies that fonts without valid charmaps are
3336         never selected.
3337
3338         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3339         (initializeFonts): Initialize DRT with our font (derived from Ahem)
3340         that has no valid charmap.
3341         * DumpRenderTree/gtk/fonts/FontWithNoValidEncoding.fon: Added.
3342         * DumpRenderTree/gtk/fonts/fonts.conf: Updated settings to override users'
3343         settings which may disable selection of bitmap fonts.
3344
3345 2010-12-10  Eric Seidel  <eric@webkit.org>
3346
3347         Unreviewed.
3348
3349         The commit-queue should file bugs about flaky tests it encounters
3350         https://bugs.webkit.org/show_bug.cgi?id=50803
3351
3352         create_bug_for_flaky_test was insufficiently tested, thus buggy.
3353         Now it's tested.
3354
3355         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3356         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3357
3358 2010-12-10  Eric Seidel  <eric@webkit.org>
3359
3360         Unreviewed.  Somehow this last-minute edit didn't quite get committed.
3361
3362         The commit-queue should file bugs about flaky tests it encounters
3363         https://bugs.webkit.org/show_bug.cgi?id=50803
3364
3365         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3366
3367 2010-12-09  Eric Seidel  <eric@webkit.org>
3368
3369         Reviewed by Adam Barth.
3370
3371         The commit-queue should file bugs about flaky tests it encounters
3372         https://bugs.webkit.org/show_bug.cgi?id=50803
3373
3374         This change got a bit big.  I also added a new config.urls file
3375         because I needed to share the view_source_url code with committervalidator.py.
3376
3377         This adds a new class FlakyTestReporter which holds all the logic about
3378         reporting flaky tests to bugzilla.
3379
3380         Right now this code knows how to look up bugs for flaky tests.
3381         If it can't find a bug filed from the commit-queue, it will open a new
3382         one, ccing the relevant people and adding information about the failure.
3383
3384         It is not yet smart enough to chase down duplicate chains, or to include
3385         the actual failure diff.  But those can be added in later iterations.
3386
3387         * Scripts/webkitpy/common/checkout/api.py:
3388         * Scripts/webkitpy/common/checkout/changelog.py:
3389         * Scripts/webkitpy/common/checkout/commitinfo.py:
3390         * Scripts/webkitpy/common/config/committervalidator.py:
3391         * Scripts/webkitpy/common/config/urls.py: Copied from WebKitTools/Scripts/webkitpy/tool/comments.py.
3392         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3393         * Scripts/webkitpy/tool/bot/flakytestreporter.py: Added.
3394         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py: Copied from WebKitTools/Scripts/webkitpy/tool/comments.py.
3395         * Scripts/webkitpy/tool/bot/irc_command.py:
3396         * Scripts/webkitpy/tool/bot/sheriff.py:
3397         * Scripts/webkitpy/tool/commands/download.py:
3398         * Scripts/webkitpy/tool/commands/queues.py:
3399         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3400         * Scripts/webkitpy/tool/comments.py:
3401         * Scripts/webkitpy/tool/mocktool.py:
3402         * Scripts/webkitpy/tool/steps/commit.py:
3403
3404 2010-12-09  Eric Seidel  <eric@webkit.org>
3405
3406         Reviewed by Adam Barth.
3407
3408         Teach webkit-patch how to search bugzilla
3409         https://bugs.webkit.org/show_bug.cgi?id=50500
3410
3411         This is a step towards teaching webkitpy how to file
3412         new bugs for flaky tests and update them when new flakes occur.
3413
3414         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3415         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
3416         * Scripts/webkitpy/tool/commands/__init__.py:
3417         * Scripts/webkitpy/tool/commands/bugsearch.py: Added.
3418
3419 2010-12-09  Adam Barth  <abarth@webkit.org>
3420
3421         Reviewed by Ojan Vafai.
3422
3423         commit-queue errors out due to local commits
3424         https://bugs.webkit.org/show_bug.cgi?id=50766
3425
3426         We seem to be tripping over having local commits in the working copy a
3427         lot recently.  I don't quite fully understand what the issue is, but
3428         this patch attempts to solve the problem by adding an explicit clean
3429         step before processing a patch.  Previously, we did the cleaning as
3430         part of the apply-attachment step, so this might not actually fix the
3431         problem.
3432
3433         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3434         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3435         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3436
3437 2010-12-09  Dirk Pranke  <dpranke@chromium.org>
3438
3439         Reviewed by Ojan Vafai.
3440
3441         Make new-run-webkit-tests --lint-test-files log slightly better
3442         messages and return -1 if lint fails. Remove the
3443         'suppress_errors' keyword param to the TestExpectationsFile
3444         class, and clean up logging and exception raising for error
3445         handling. Also add more unit tests and clean up the unit test code a bit.
3446
3447         https://bugs.webkit.org/show_bug.cgi?id=50205
3448
3449         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3450         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3451         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py
3452         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py
3453         * Scripts/webkitpy/layout_tests/port/chromium.py:
3454         * Scripts/webkitpy/style/checkers/test_expectations.py:
3455         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
3456
3457 2010-12-09  Tony Chang  <tony@chromium.org>
3458
3459         Unreviewed, fix for windows code.  We were catching the wrong
3460         exception in Windows.
3461
3462         * Scripts/webkitpy/common/system/filesystem.py:
3463
3464 2010-12-09  Antonio Gomes  <agomes@rim.com>
3465
3466         Reviewed by Martin Robinson.
3467
3468         [Gtk] Populate DumpRenderTreeSupportGtk (part IV)
3469         https://bugs.webkit.org/show_bug.cgi?id=48429
3470
3471         Adjust call sites of webkit_thread_count to use the DumpRenderTreeSupportGtk version now.
3472
3473         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3474         (LayoutTestController::workerThreadCount):
3475
3476 2010-12-06  Philippe Normand  <pnormand@igalia.com>
3477
3478         Reviewed by Martin Robinson.
3479
3480         [GTK] Support the Mozilla-style Fullscreen Javascript API
3481         https://bugs.webkit.org/show_bug.cgi?id=50572
3482
3483         Enable the Javascript Fullscreen support in the GtkLauncher. Also
3484         make DRT update the Chrome when the WebView settings have been
3485         reset to consistent values.
3486
3487         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3488         (resetDefaultsToConsistentValues):
3489         * GtkLauncher/main.c:
3490         (create_window):
3491         * Scripts/build-webkit:
3492
3493 2010-12-09  Koan-Sin Tan  <koansin.tan@gmail.com>
3494
3495         Reviewed by Tor Arne Vestbø
3496
3497         [Qt] run-launcher doesn't start the browser on Mac OS X 10.6
3498         https://bugs.webkit.org/show_bug.cgi?id=50742
3499
3500         check not only QtWebKit.framework/QtWebKit but also libQtWebKit.dylib
3501
3502         * Scripts/webkitdirs.pm:
3503
3504 2010-12-09  Joone Hur  <joone@kldp.org>
3505
3506          Reviewed by Martin Robinson.
3507
3508          [GTK] Support for viewport meta tag
3509          https://bugs.webkit.org/show_bug.cgi?id=45443
3510
3511          Add support for testing the viewport properties for WebKitGtk.
3512
3513          * DumpRenderTree/LayoutTestController.cpp:
3514          (dumpConfigurationForViewportCallback): Added this JS callback to set the size of the visible viewport.
3515          (LayoutTestController::staticFunctions):
3516          * DumpRenderTree/LayoutTestController.h:
3517          * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3518          (LayoutTestController::dumpConfigurationForViewport): Added this function to test the viewport properties.
3519          * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3520          (LayoutTestController::dumpConfigurationForViewport): Ditto.
3521          * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3522          (LayoutTestController::dumpConfigurationForViewport): Ditto.
3523          * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3524          (LayoutTestController::dumpConfigurationForViewport): Ditto.
3525          * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3526          (LayoutTestController::dumpConfigurationForViewport): Ditto.
3527
3528 2010-12-08  William Siegrist <wsiegrist@apple.com>
3529
3530         Reviewed by Eric Seidel.
3531
3532         Migrate buildbot.py from xmlrpc to json.
3533         https://bugs.webkit.org/show_bug.cgi?id=50647
3534
3535         * Scripts/webkitpy/common/net/buildbot.py:
3536
3537 2010-12-08  Tony Chang  <tony@chromium.org>
3538
3539         Reviewed by Eric Seidel.
3540
3541         make starting the websocket server more reliable on windows
3542         https://bugs.webkit.org/show_bug.cgi?id=50712
3543
3544         * Scripts/webkitpy/common/system/filesystem.py:
3545         (remove): Substitute method for os.remove to retry on error on Windows
3546         * Scripts/webkitpy/common/system/filesystem_unittest.py:
3547         * Scripts/webkitpy/layout_tests/port/http_server_base.py: Use FileSystem.remove
3548
3549 2010-12-08  Jessie Berlin  <jberlin@apple.com>
3550
3551         Reviewed by Adam Roben.
3552
3553         WebKit2: Implement WebChromeClient::exceededDatabaseQuota
3554         https://bugs.webkit.org/show_bug.cgi?id=50656
3555
3556         * MiniBrowser/mac/BrowserWindowController.m:
3557         (-[BrowserWindowController awakeFromNib]):
3558         Indicate that exceededDatabaseQuota is not implemented.
3559         * MiniBrowser/win/BrowserView.cpp:
3560         (BrowserView::create):
3561         Ditto.
3562         * WebKitTestRunner/TestController.cpp:
3563         (WTR::createOtherPage):
3564         Ditto.
3565         (WTR::TestController::initialize):
3566         Ditto.
3567
3568 2010-12-08  Antonio Gomes  <agomes@rim.com>
3569
3570         Reviewed by Martin Robinson.
3571
3572         [Gtk] Populate DumpRenderTreeSupportGtk (part III)
3573         https://bugs.webkit.org/show_bug.cgi?id=48429
3574
3575         Moved the following methods from webkitprivate.h to DumpRenderTreeSupportGtk.cpp|h:
3576         * webkit_gc_collect_javascript_objects;
3577         * webkit_gc_collect_javascript_objects_on_alternate_thread;
3578         * webkit_gc_count_javascript_objects;
3579         * webkit_web_frame_layout.
3580
3581         These were all only used by GTK+ DRT.
3582
3583         * DumpRenderTree/gtk/EventSender.cpp:
3584         (dispatchEvent):
3585         * DumpRenderTree/gtk/GCControllerGtk.cpp:
3586         (GCController::collect):
3587         (GCController::collectOnAlternateThread):
3588         (GCController::getJSObjectCount):
3589
3590 2010-12-07  Tony Chang  <tony@chromium.org>
3591
3592         Reviewed by Ojan Vafai.
3593
3594         [chromium] force NRWT to use DRT
3595         https://bugs.webkit.org/show_bug.cgi?id=50359
3596
3597         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3598
3599 2010-12-06  Sam Weinig  <sam@webkit.org>
3600
3601         Reviewed by Anders Carlsson.
3602
3603         Generalize didChangeLocationWithinPageForFrame for all same document navigations
3604         https://bugs.webkit.org/show_bug.cgi?id=50584
3605
3606         * MiniBrowser/mac/BrowserWindowController.m:
3607         (didSameDocumentNavigationForFrame):
3608         (-[BrowserWindowController awakeFromNib]):
3609         (-[BrowserWindowController didSameDocumentNavigationForFrame:]):
3610         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
3611         (TestWebKitAPI::didSameDocumentNavigationForFrame):
3612         (TestWebKitAPI::TEST):
3613         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3614         (WTR::InjectedBundlePage::InjectedBundlePage):
3615         (WTR::InjectedBundlePage::didSameDocumentNavigationForFrame):
3616         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3617         * WebKitTestRunner/TestController.cpp:
3618         (WTR::TestController::initialize):
3619
3620 2010-12-06  Kinuko Yasuda  <kinuko@chromium.org>
3621
3622         Reviewed by Ojan Vafai.
3623
3624         Make TestResultsServer return 404 for non-existing results files.
3625         https://bugs.webkit.org/show_bug.cgi?id=50581
3626
3627         * TestResultServer/handlers/testfilehandler.py:
3628
3629 2010-12-06  Tony Chang  <tony@chromium.org>
3630
3631         Reviewed by Ojan Vafai.
3632
3633         [chromium] fix an assert hit in DRT
3634         https://bugs.webkit.org/show_bug.cgi?id=50575
3635
3636         This class uses WTF's RefPtr, but expects chrome's base::RefPtr
3637         semantics.
3638
3639         Otherwise, we hit ASSERTION FAILED: !m_adoptionIsRequired
3640         (third_party/WebKit/JavaScriptCore/wtf/RefCounted.h:37 void
3641         WTF::RefCountedBase::ref()).
3642
3643         * DumpRenderTree/chromium/TestWebWorker.h:
3644         (TestWebWorker::TestWebWorker):
3645
3646 2010-12-02  Ojan Vafai  <ojan@chromium.org>
3647
3648         Reviewed by Eric Seidel.
3649
3650         make webkit-patch command work when the git branch is not synced to the remote svn branch
3651         https://bugs.webkit.org/show_bug.cgi?id=50424
3652
3653         * Scripts/webkitpy/common/checkout/scm.py:
3654         * Scripts/webkitpy/common/checkout/scm_unittest.py:
3655
3656 2010-12-06  Patrick Gansterer  <paroga@webkit.org>
3657
3658         Reviewed by Andreas Kling.
3659
3660         [WINCE] Add build system
3661         https://bugs.webkit.org/show_bug.cgi?id=50522
3662
3663         * CMakeListsWinCE.txt: Added.
3664
3665 2010-12-03  Mihai Parparita  <mihaip@chromium.org>
3666
3667         Reviewed by Tony Chang.
3668
3669         Allow the Chromium port to have Leopard-specific baselines
3670         https://bugs.webkit.org/show_bug.cgi?id=50506
3671
3672         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3673
3674 2010-12-03  Tony Chang  <tony@chromium.org>
3675
3676         Reviewed by Kent Tamura.
3677
3678         [chromium] fix 2 bugs with inspector tests in DRT
3679         https://bugs.webkit.org/show_bug.cgi?id=50492
3680
3681         Tasks can outlive the tasklist (even when canceled) so this was
3682         causing a crash when ~WebTask() ran.  Avoid this by unregistering
3683         when a task is canceled.
3684
3685         Also fix an assert when closing devtool windows by copying some
3686         logic from test_shell.
3687
3688         * DumpRenderTree/chromium/Task.cpp:
3689         (WebTask::~WebTask):
3690         (TaskList::revokeAll):
3691         * DumpRenderTree/chromium/Task.h: Canceling a task now removes it from
3692             the tasklist (since the task can outlive the tasklist).
3693         * DumpRenderTree/chromium/TestShell.h:
3694         (TestShell::devToolsWebView):
3695         * DumpRenderTree/chromium/WebViewHost.cpp:
3696         (WebViewHost::~WebViewHost): Don't load about:blank when closing
3697             a window if the window has devtools loaded.  This avoids an
3698             ASSERT and matches test_shell.
3699
3700 2010-12-06  Alejandro G. Castro  <alex@igalia.com>
3701
3702         Reviewed by Martin Robinson.
3703
3704         [GTK] Fix GtkLauncher.c style, use webkit style
3705         https://bugs.webkit.org/show_bug.cgi?id=50542
3706
3707         * GtkLauncher/main.c:
3708         (activateUriEntryCb):
3709         (updateTitle):
3710         (linkHoverCb):
3711         (notifyTitleCb):
3712         (notifyLoadStatusCb):
3713         (notifyProgressCb):
3714         (destroyCb):
3715         (goBackCb):
3716         (goForwardCb):
3717         (create_webViewCb):
3718         (webViewReadyCb):
3719         (closeWebViewCb):
3720         (createBrowser):
3721         (createStatusbar):
3722         (createToolbar):
3723         (createWindow):
3724         (main):
3725
3726 2010-12-04  Antonio Gomes  <agomes@rim.com>
3727
3728         Reviewed by Martin Robinson.
3729
3730         [Gtk] Populate DumpRenderTreeSupportGtk (Part II)
3731