Tools/ChangeLog

   1 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
   2
   3         Reviewed by Mihai Parparita.
   4
   5         new-run-webkit-tests: remove use of os.walk, use mock filesystem for better
   6         unit testing. os.walk() is too much of a hassle to implement on
   7         top of the in-memory mock filesystem and adding the necessary
   8         interface to files_under() gives clients a cleaner API anyway
   9         (for this particular usage model).
  10
  11         https://bugs.webkit.org/show_bug.cgi?id=52691
  12
  13         * Scripts/webkitpy/common/system/filesystem.py:
  14         * Scripts/webkitpy/common/system/filesystem_mock.py:
  15         * Scripts/webkitpy/layout_tests/port/test_files.py:
  16         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
  17
  18 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
  19
  20         Reviewed by Tony Chang.
  21
  22         Change more modules in the layout-tests code to use the
  23         filesystem wrapper for cleaner unit testing.
  24
  25         This patch also adds the glob() wrapper to the filesystem
  26         abstraction.
  27
  28         https://bugs.webkit.org/show_bug.cgi?id=52604
  29
  30         * Scripts/webkitpy/layout_tests/port/test_files.py:
  31         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
  32         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
  33         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
  34         * Scripts/webkitpy/common/system/filesystem.py:
  35         * Scripts/webkitpy/common/system/filesystem_mock.py:
  36
  37 2011-01-19  Levi Weintraub  <leviw@chromium.org>
  38
  39         Unreviewed.
  40
  41         Updating my email addresses and irc nick.
  42
  43         * Scripts/webkitpy/common/config/committers.py:
  44
  45 2011-01-19  Tony Chang  <tony@chromium.org>
  46
  47         Reviewed by Mihai Parparita.
  48
  49         [chromium] [linux] if check-sys-deps fails, output the failure reason
  50         https://bugs.webkit.org/show_bug.cgi?id=52671
  51
  52         * Scripts/webkitpy/common/system/executive_mock.py: Add support for
  53             error handler functions.
  54         * Scripts/webkitpy/layout_tests/port/chromium.py:
  55             output the error text from --check-sys-deps
  56         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
  57
  58 2011-01-19  Aparna Nandyal  <aparna.nand@wipro.com>
  59
  60         Reviewed by Andreas Kling.
  61
  62         [Qt] QtTestBrowser crashes when closing if Facebook is opened
  63         https://bugs.webkit.org/show_bug.cgi?id=52554
  64
  65         QtNetworkAccessManager is created in a thread and set as
  66         member variable in QWebPage. When the thread is destroyed
  67         the object is still used. So fix will set the object to
  68         NULL once the thread is destroyed.
  69
  70         * QtTestBrowser/launcherwindow.cpp:
  71         (LauncherWindow::~LauncherWindow):
  72
  73 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
  74
  75         Rubber stamped by Csaba Osztrogonac
  76
  77         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: Removed unncessary inculde of WKStringCF.h
  78
  79 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
  80
  81         Reviewed by Tony Chang.
  82
  83         new-run-webkit-tests: add a --build-directory command line argument
  84
  85         Official Google Chrome builds use a non-standard build directory
  86         location. This patch adds a --build-directory argument that
  87         allows that location to be specified on the command line. Only
  88         Chromium-based builds will use this flag for now, but anyone can
  89         in the future.
  90
  91         There are no unit tests for this since it's difficult to test
  92         until mock filesystems are fully supported in the code. This was
  93         tested by hand for now.
  94
  95         https://bugs.webkit.org/show_bug.cgi?id=52694
  96
  97         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
  98         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  99         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
 100         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
 101
 102 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
 103
 104         Not reviewed. Bot fix.
 105
 106         Remove an inadvertently committed debugging print.
 107
 108         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
 109         (LayoutTestController::notifyDone):
 110
 111 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
 112
 113         Reviewed by Sam Weinig.
 114
 115         WebKitTestRunner should track loading more like DumpRenderTree
 116         https://bugs.webkit.org/show_bug.cgi?id=52692
 117
 118         Change load tracking to track the current top loading frame, in the manner of DumpRenderTree.
 119         This makes some tests that call notifyDone multiple times pass.
 120
 121         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
 122         (WTR::InjectedBundle::InjectedBundle):
 123         (WTR::InjectedBundle::done):
 124         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
 125         (WTR::InjectedBundle::topLoadingFrame):
 126         (WTR::InjectedBundle::setTopLoadingFrame):
 127         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
 128         (WTR::InjectedBundlePage::InjectedBundlePage):
 129         (WTR::InjectedBundlePage::stopLoading):
 130         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
 131         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
 132         (WTR::InjectedBundlePage::didFinishLoadForFrame):
 133         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
 134         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
 135         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
 136         (WTR::LayoutTestController::notifyDone):
 137         * WebKitTestRunner/TestController.cpp:
 138         (WTR::TestController::didReceiveMessageFromInjectedBundle):
 139
 140 2011-01-18  Mihai Parparita  <mihaip@chromium.org>
 141
 142         Reviewed by Kent Tamura.
 143
 144         [Chromium] NRWT looking for DRT binary in the wrong path on Mac
 145         https://bugs.webkit.org/show_bug.cgi?id=52678
 146
 147         Update path now that WebKit is inside Source.
 148
 149         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
 150
 151 2011-01-18  Robert Hogan  <robert@webkit.org>
 152
 153         Reviewed by Simon Hausmann.
 154
 155         [Qt] http/tests/incremental/slow-utf8-text.pl fails
 156         https://bugs.webkit.org/show_bug.cgi?id=44282
 157
 158         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
 159         (WebCore::DumpRenderTree::dump):
 160
 161 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
 162
 163         Reviewed by Mihai Parparita.
 164
 165         Fix a small race condition that could cause the unit tests for
 166         new-run-webkit-tests to fail in a multithreaded environment.
 167         There was a small window in the code where one thread would
 168         check to see if a thread had raised an exception, do something,
 169         and then check to see if the thread was alive. If the other
 170         thread raised an exception and exited in between these two
 171         steps, the exception would be lost. Flipping the order of the
 172         two checks fixes the race, since we will now always check for an
 173         exception on the thread before exiting.
 174
 175         https://bugs.webkit.org/show_bug.cgi?id=51579
 176
 177         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
 178
 179 2011-01-18  Eric Seidel  <eric@webkit.org>
 180
 181         Reviewed by Adam Barth.
 182
 183         commit-queue dies when test archiving fails
 184         https://bugs.webkit.org/show_bug.cgi?id=52617
 185
 186         I looked at the machine and it had 10 archives already
 187         thus find_unused_name was returning None.  I've upped
 188         the limit to 100 (per bug) and tested the case where
 189         find_unused_name returns None (making archive return None).
 190
 191         * Scripts/webkitpy/common/system/workspace.py:
 192         * Scripts/webkitpy/common/system/workspace_unittest.py:
 193         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
 194         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
 195         * Scripts/webkitpy/tool/commands/queues.py:
 196
 197 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
 198
 199         Reviewed by Ojan Vafai.
 200
 201         Update rebaseline-chromium-webkit-tests unit tests to use a mock
 202         filesystem. Also fix a couple of "with" statements missed by
 203         r76050.
 204
 205         https://bugs.webkit.org/show_bug.cgi?id=52487
 206
 207         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
 208
 209 2011-01-18  Sergio Villar Senin  <svillar@igalia.com>
 210
 211         Reviewed by Martin Robinson.
 212
 213         [Gtk] Build fixes for gtk3 build
 214         https://bugs.webkit.org/show_bug.cgi?id=52648
 215
 216         * DumpRenderTree/gtk/EventSender.cpp:
 217         (beginDragWithFilesCallback):
 218
 219 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
 220
 221         Reviewed by Mihai Parparita.
 222
 223         Update rebaseline-chromium-webkit-tests to use filesystem objects
 224         instead of direct references to os.path, shutil, tempfile, etc.
 225
 226         This patch doesn't change anything, but will allow subsequent
 227         patches to change the unit tests to no longer use the real
 228         filesystem.
 229
 230         This patch adds a bunch more methods to the filesystem object as
 231         well.
 232
 233         https://bugs.webkit.org/show_bug.cgi?id=52482
 234
 235         * Scripts/webkitpy/common/system/filesystem.py:
 236         * Scripts/webkitpy/common/system/filesystem_mock.py:
 237         * Scripts/webkitpy/tool/commands/queues.py:
 238         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
 239         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
 240
 241 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
 242
 243         Reviewed by Mihai Parparita.
 244
 245         new-run-webkit-tests shouldn't crash when you try to run a
 246         directory containing only skipped files.
 247
 248         https://bugs.webkit.org/show_bug.cgi?id=52478
 249
 250         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
 251         * Scripts/webkitpy/layout_tests/port/test.py:
 252         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
 253
 254 2011-01-18  Adam Bergkvist  <adam.bergkvist@ericsson.com> and Martin Robinson  <mrobinson@igalia.com>
 255
 256         Reviewed by Gustavo Noronha Silva.
 257
 258         [GTK] The GTK+ EventSender needs support for beginDragWithFiles
 259         https://bugs.webkit.org/show_bug.cgi?id=40833
 260
 261         * DumpRenderTree/gtk/EventSender.cpp: Add a beginDragWithFiles implementation for the
 262         GTK+ event sender.
 263         (dragWithFilesDragDataGetCallback): Added.
 264         (dragWithFilesDragEndCallback): Added.
 265         (beginDragWithFilesCallback): Added.
 266
 267 2011-01-18  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
 268
 269         Reviewed by Adam Barth.
 270
 271         ews: Add additional watcher to efl ews
 272         https://bugs.webkit.org/show_bug.cgi?id=52613
 273
 274         Add gyuyoung.kim@samsung.com to watcher list of efl-ews.
 275
 276         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
 277
 278 2011-01-17  Tony Gentilcore  <tonyg@chromium.org>
 279
 280         Reviewed by Alexey Proskuryakov.
 281
 282         Fix some headers with missing or misspelled #ifndef guards
 283         https://bugs.webkit.org/show_bug.cgi?id=52545
 284
 285         * DumpRenderTree/chromium/TestEventPrinter.h:
 286         * DumpRenderTree/chromium/WebPreferences.h:
 287
 288 2011-01-17  Jessie Berlin  <jberlin@apple.com>
 289
 290         Reviewed by Anders Carlsson.
 291
 292         REGRESSION: Assertion failure in FrameLoader::continueLoadAfterWillSubmitForm() when
 293         navigating back to an unreachable URL
 294         https://bugs.webkit.org/show_bug.cgi?id=52388
 295
 296         Add a third parameter (unreachableURL) to queueLoadHTMLString.
 297
 298         * DumpRenderTree/LayoutTestController.cpp:
 299         (queueLoadHTMLStringCallback):
 300         (LayoutTestController::queueLoadHTMLString):
 301         (LayoutTestController::queueLoadAlternateHTMLString):
 302         * DumpRenderTree/LayoutTestController.h:
 303
 304         * DumpRenderTree/WorkQueueItem.h:
 305         (LoadHTMLStringItem::LoadHTMLStringItem):
 306
 307         * DumpRenderTree/chromium/LayoutTestController.cpp:
 308         (WorkItemLoadHTMLString::WorkItemLoadHTMLString):
 309         (WorkItemLoadHTMLString::run):
 310         (LayoutTestController::queueLoadHTMLString):
 311
 312         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
 313         (LoadHTMLStringItem::invoke):
 314         * DumpRenderTree/mac/WorkQueueItemMac.mm:
 315         (LoadHTMLStringItem::invoke):
 316         * DumpRenderTree/win/WorkQueueItemWin.cpp:
 317         (LoadHTMLStringItem::invoke):
 318
 319 2011-01-17  Dan Bernstein  <mitz@apple.com>
 320
 321         Rubber-stamped by Mark Rowe.
 322
 323         Update xcodeproj svn:ignore to include xcuserdata.
 324
 325         * DumpRenderTree/DumpRenderTree.xcodeproj: Modified property svn:ignore.
 326         * MiniBrowser/MiniBrowser.xcodeproj: Modified property svn:ignore.
 327         * TestWebKitAPI/TestWebKitAPI.xcodeproj: Modified property svn:ignore.
 328         * WebKitLauncher/WebKitLauncher.xcodeproj: Modified property svn:ignore.
 329         * WebKitTestRunner/WebKitTestRunner.xcodeproj: Modified property svn:ignore.
 330
 331 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
 332
 333         Unreviewed fix after r75908.
 334
 335         Move WebKit into Source
 336         https://bugs.webkit.org/show_bug.cgi?id=52530
 337
 338         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add Source to the path for Qt API tests.
 339
 340 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
 341
 342         Unreviewed.
 343
 344         Remove accidentally committed debug printing after r75908.
 345
 346         * Scripts/webkitdirs.pm:
 347
 348 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
 349
 350         Unreviewed.
 351
 352         Add myself to committers list
 353         https://bugs.webkit.org/show_bug.cgi?id=52566
 354
 355         * Scripts/webkitpy/common/config/committers.py:
 356
 357 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
 358
 359         Reviewed by Jeremy Orlow.
 360
 361         GeolocationController should call stopUpdating on destruction
 362         https://bugs.webkit.org/show_bug.cgi?id=52216
 363
 364         fast/dom/Geolocation/window-close-crash.html requires that a
 365         Geolocation watch be started in a secondary window. Consequently,
 366         we need to allow geolocation permission and provide a mock
 367         geolocation position for the secondary window's
 368         GeolocationClientMock.
 369
 370         * DumpRenderTree/chromium/LayoutTestController.cpp:
 371         (LayoutTestController::setGeolocationPermission):
 372         (LayoutTestController::setMockGeolocationPosition):
 373         (LayoutTestController::setMockGeolocationError):
 374         * DumpRenderTree/chromium/TestShell.h:
 375         (TestShell::windowList):
 376
 377 2011-01-16  Adam Barth  <abarth@webkit.org>
 378
 379         Update more include paths to reflect WebKit move.
 380
 381         * DumpRenderTree/chromium/EventSender.cpp:
 382         (EventSender::keyDown):
 383         (EventSender::needsShiftModifier):
 384         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
 385         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
 386
 387 2011-01-16  Kent Tamura  <tkent@chromium.org>
 388
 389         Unreviewed, Chromium build fix.
 390
 391         * Scripts/update-webkit-chromium: Webkit/chromium -> Source/WebKit/chromium
 392
 393 2011-01-16  Martin Robinson  <mrobinson@igalia.com>
 394
 395         Build fix for GTK+ after source directory movement.
 396
 397         * GNUmakefile.am: Correct include paths.
 398
 399 2011-01-16  Adam Barth  <abarth@webkit.org>
 400
 401         Teach svn-apply about WebKit move.
 402
 403         * Scripts/VCSUtils.pm:
 404
 405 2011-01-16  Adam Barth  <abarth@webkit.org>
 406
 407         Rubber-stamped by Eric Seidel.
 408
 409         Move WebKit into Source
 410         https://bugs.webkit.org/show_bug.cgi?id=52530
 411
 412         * DumpRenderTree/mac/InternalHeaders/WebKit/WebTypesInternal.h:
 413         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
 414         * DumpRenderTree/qt/DumpRenderTreeQt.h:
 415         * DumpRenderTree/qt/GCControllerQt.cpp:
 416         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
 417         * DumpRenderTree/qt/PlainTextControllerQt.cpp:
 418         * DumpRenderTree/qt/TextInputControllerQt.cpp:
 419         * DumpRenderTree/wscript:
 420         * QtTestBrowser/launcherwindow.h:
 421         * Scripts/build-webkit:
 422         * Scripts/webkitdirs.pm:
 423
 424 2011-01-15  Adam Barth  <abarth@webkit.org>
 425
 426         Teach svn-apply about WebKit2 move.
 427
 428         * Scripts/VCSUtils.pm:
 429
 430 2011-01-15  Adam Barth  <abarth@webkit.org>
 431
 432         Rubber-stamped by Eric Seidel.
 433
 434         Move WebKit2 into Source
 435         https://bugs.webkit.org/show_bug.cgi?id=52438
 436
 437         * MiniBrowser/qt/MiniBrowser.pro:
 438         * Scripts/build-webkit:
 439         * Scripts/do-file-rename:
 440         * Scripts/do-webcore-rename:
 441         * Scripts/test-webkitpy:
 442         * Scripts/webkitdirs.pm:
 443         * Scripts/webkitpy/style/checker.py:
 444         * WebKitTestRunner/DerivedSources.pro:
 445         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
 446         * WebKitTestRunner/qt/WebKitTestRunner.pro:
 447
 448 2011-01-15  Jochen Eisinger  <jochen@chromium.org>
 449
 450         Reviewed by David Levin.
 451
 452         [chromium] remove obsolete createView method
 453         https://bugs.webkit.org/show_bug.cgi?id=52437
 454
 455         * DumpRenderTree/chromium/WebViewHost.cpp:
 456         (WebViewHost::createView):
 457         * DumpRenderTree/chromium/WebViewHost.h:
 458
 459 2011-01-14  Brian Weinstein  <bweinstein@apple.com>
 460
 461         Reviewed by Geoff Garen.
 462
 463         ShouldLoadResourceForFrame should use strings, not URLs.
 464         https://bugs.webkit.org/show_bug.cgi?id=52476
 465
 466         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
 467         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Update to use a WKStringRef.
 468         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
 469
 470 2011-01-14  Tony Gentilcore  <tonyg@chromium.org>
 471
 472         Reviewed by David Levin.
 473
 474         Add Tony Gentilcore as a reviewer
 475         https://bugs.webkit.org/show_bug.cgi?id=52480
 476
 477         * Scripts/webkitpy/common/config/committers.py:
 478
 479 2011-01-14  David Levin  <levin@chromium.org>
 480
 481         Reviewed by Eric Seidel.
 482
 483         check-webkit-style: _FunctionState should keep track of where the function name starts.
 484         https://bugs.webkit.org/show_bug.cgi?id=52454
 485
 486         * Scripts/webkitpy/style/checkers/cpp.py: Added function_name_start_position to
 487         _FunctionState and logic for setting it correctly.
 488         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests.
 489
 490 2011-01-14  Vincent Scheib  <scheib@chromium.org>
 491
 492         Reviewed by David Levin.
 493
 494         Add support to DumpRenderTree to use the GPU rather than software renderer
 495         https://bugs.webkit.org/show_bug.cgi?id=52333
 496
 497         * DumpRenderTree/chromium/DumpRenderTree.cpp:
 498         (main):
 499         * Scripts/webkitpy/layout_tests/port/chromium.py:
 500         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
 501
 502 2011-01-14  Tony Chang  <tony@chromium.org>
 503
 504         Reviewed by Kent Tamura.
 505
 506         [chromium] update fonts.conf to fix 6 linux tests in drt
 507         https://bugs.webkit.org/show_bug.cgi?id=52411
 508
 509         * DumpRenderTree/chromium/fonts.conf: Update to match the copy in
 510             chromium's src/webkit/tools/test_shell/resources/fonts.conf
 511
 512 2011-01-14  Eric Seidel  <eric@webkit.org>
 513
 514         Original patch from Peter Gal  <galpater@inf.u-szeged.hu>
 515
 516         Reviewed by Adam Barth.
 517
 518         Fix when running Tools/Scripts/check-webkit-style without arguments.
 519         https://bugs.webkit.org/show_bug.cgi?id=52261#c16
 520
 521         * Scripts/webkitpy/common/checkout/scm.py: Handle None for changed_files argument better in Git.create_patch method.
 522         * Scripts/webkitpy/common/checkout/scm_unittest.py:
 523
 524 2011-01-04  Jochen Eisinger  <jochen@chromium.org>
 525
 526         Reviewed by David Levin.
 527
 528         Store the tempdir object in a variable so it doesn't get deleted too early.
 529         https://bugs.webkit.org/show_bug.cgi?id=51875
 530
 531         * Scripts/update-webkit-auxiliary-libs:
 532         * Scripts/update-webkit-support-libs:
 533
 534 2011-01-14  Eric Seidel  <eric@webkit.org>
 535
 536         Unreviewed.  Make it work in python 2.5.
 537
 538         webkit-patch suggest-reviewers dies when ChangeLogs are missing
 539         https://bugs.webkit.org/show_bug.cgi?id=49158
 540
 541         * Scripts/webkitpy/common/checkout/api_unittest.py:
 542
 543 2011-01-14  Sheriff Bot  <webkit.review.bot@gmail.com>
 544
 545         Unreviewed, rolling out r75774.
 546         http://trac.webkit.org/changeset/75774
 547         https://bugs.webkit.org/show_bug.cgi?id=52431
 548
 549         gtk builds were broken (Requested by loislo2 on #webkit).
 550
 551         * Scripts/webkitpy/common/checkout/scm.py:
 552
 553 2011-01-14  David Levin  <levin@chromium.org>
 554
 555         Reviewed by Shinichiro Hamaji.
 556
 557         check-webkit-style: _FunctionState should detect pure functions.
 558         https://bugs.webkit.org/show_bug.cgi?id=52428
 559
 560         * Scripts/webkitpy/style/checkers/cpp.py: Added detection for if a function declaration
 561         is a pure virtual function.
 562         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests for verifying that pure
 563         virtual functions are correctly detected.
 564
 565 2011-01-13  Ilya Tikhonovsky  <loislo@chromium.org>
 566
 567         Reviewed by Yury Semikhatsky.
 568
 569         Just small fix for problem with check-webkit-style.
 570         It just didn't work for this patch.
 571         Old code can't concatenate a list of strings with None.
 572
 573         * Scripts/webkitpy/common/checkout/scm.py:
 574
 575 2011-01-13  David Levin  <levin@chromium.org>
 576
 577         Reviewed by Shinichiro Hamaji.
 578
 579         check-webkit-style: _FunctionState should use Position to know where items are.
 580         https://bugs.webkit.org/show_bug.cgi?id=52424
 581
 582         * Scripts/webkitpy/style/checkers/cpp.py:
 583         (_FunctionState.*): Changed _FunctionState to use Position instead of line numbers.
 584         (detect_functions): Changed to pass Position's to _FunctionState.begin and
 585         did some minor clean-up.
 586         (*): Other changes are simply about converting to use the Position's in_FunctionState
 587         instead of line numbers.
 588         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Changed the test code
 589         to verify the positions stored in _FunctionState.
 590
 591 2011-01-13  Eric Seidel  <eric@webkit.org>
 592
 593         Reviewed by David Levin.
 594
 595         webkit-patch suggest-reviewers dies when ChangeLogs are missing
 596         https://bugs.webkit.org/show_bug.cgi?id=49158
 597
 598         This is not the most elegant, but it is a very safe fix to this bug.
 599         One advantage of catching ScriptError like this instead of adding a
 600         new added_or_modified_files or fixing all changed_files callers
 601         to use a more specific change_files variant, is that we catch
 602         all kinds of ScriptErrors which might cause our (non-essential)
 603         suggest-reviewers code to fail out.  This should make passing
 604         --suggest-reviewers to webkit-patch upload much more robust
 605         and may even make it possible for us to make it default.
 606
 607         The root of the problem here is that SCM.changed_files includes
 608         deleted ChangeLog paths (from moves, etc) which then when we ask
 609         SVN/Git for the contents of the file at that revision, the command
 610         errors out and Executive.run_command raises a ScriptError.
 611
 612         In the future we might fix this differently by making all current
 613         callers of chagned_files use a more specific method for requesting
 614         what types of changes they're interested in (adds, modifies, deletes, etc.)
 615
 616         * Scripts/webkitpy/common/checkout/api.py:
 617         * Scripts/webkitpy/common/checkout/api_unittest.py:
 618
 619 2011-01-13  Dan Bernstein  <mitz@apple.com>
 620
 621         Reviewed by Alexey Proskuryakov.
 622
 623         <rdar://problem/8827065> REGRESSION (r71884): Cross-origin XHR fails if willSendRequest changes the URL
 624         https://bugs.webkit.org/show_bug.cgi?id=52419
 625
 626         Allow to further control the behavior of the willSendRequest delegate callback by making it
 627         set a different URL in the new request.
 628
 629         * DumpRenderTree/LayoutTestController.cpp:
 630         (addURLToRedirectCallback): Added.
 631         (LayoutTestController::staticFunctions): Added addURLToRedirect.
 632         (LayoutTestController::addURLToRedirect): Added. Adds the redirection to the map.
 633         (LayoutTestController::redirectionDestinationForURL): Added this getter.
 634         * DumpRenderTree/LayoutTestController.h:
 635         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
 636         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]): Check
 637         if there is a redirection for the request’s URL, established by addURLToRedirect(), and if so,
 638         change the URL in the new request to the redirect destination.
 639
 640 2011-01-13  Eric Seidel  <eric@webkit.org>
 641
 642         Reviewed by Mihai Parparita.
 643
 644         webkit-patch suggest-reviewers fails due to invalid utf8 in ChangeLog files
 645         https://bugs.webkit.org/show_bug.cgi?id=52416
 646
 647         Example: webkit-patch suggest-reviewers -g ca3890fe74d94d85d6bfa48f9ea497b094d8e717
 648         UnicodeDecodeError: 'utf8' codec can't decode bytes in position 536-538: invalid data
 649
 650         I also added FIXMEs about the changed_files returning deleted files problem
 651         which is causing the other most common exception for suggest-reviewers
 652         (and is probably breaking sheriff-bots blame detection).
 653
 654         * Scripts/webkitpy/common/checkout/api.py:
 655         * Scripts/webkitpy/common/checkout/api_unittest.py:
 656         * Scripts/webkitpy/common/checkout/scm.py:
 657
 658 2011-01-13  Eric Seidel  <eric@webkit.org>
 659
 660         Reviewed by Adam Barth.
 661
 662         results archives from commit-queue are too large to upload
 663         https://bugs.webkit.org/show_bug.cgi?id=52405
 664
 665         * Scripts/webkitpy/common/system/filesystem.py:
 666         * Scripts/webkitpy/common/system/filesystem_mock.py:
 667         * Scripts/webkitpy/tool/commands/queues.py:
 668
 669 2011-01-13  Alejandro G. Castro  <alex@igalia.com>
 670
 671         Reviewed by Martin Robinson.
 672
 673         [gtk] Zero-sized font does not yet work
 674         https://bugs.webkit.org/show_bug.cgi?id=49793
 675
 676         Set minimum-font-size to 0 for the DRT.
 677
 678         * DumpRenderTree/gtk/DumpRenderTree.cpp:
 679         (resetDefaultsToConsistentValues):
 680
 681 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
 682
 683         Reviewed by Darin Adler.
 684
 685         Make old-run-webkit-tests more robust on buildbots
 686         https://bugs.webkit.org/show_bug.cgi?id=52364
 687
 688         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Pass --exit-after-n-failures 500 to old-run-webkit-tests script.
 689
 690 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
 691
 692         Reviewed by Darin Adler.
 693
 694         Make old-run-webkit-tests more robust on buildbots
 695         https://bugs.webkit.org/show_bug.cgi?id=52364
 696
 697         * Scripts/old-run-webkit-tests: Ensure that testResultsDirectory is empty.
 698
 699 2011-01-13  Tony Chang  <tony@chromium.org>
 700
 701         Reviewed by Kent Tamura.
 702
 703         [chromium] fix plugins/plugin-javascript-access.html on Linux and Mac
 704         https://bugs.webkit.org/show_bug.cgi?id=52332
 705
 706         Forked Info.plist is not longer needed.
 707
 708         * DumpRenderTree/chromium/TestNetscapePlugIn/Info.plist: Removed.
 709
 710 2011-01-13  Mikhail Naganov  <mnaganov@chromium.org>
 711
 712         Reviewed by Timothy Hatcher.
 713
 714         Web Inspector: Cleanup after r75613 -- make all UI-facing strings
 715         to be passed directly to WebInspector.UIString
 716
 717         https://bugs.webkit.org/show_bug.cgi?id=52365
 718
 719         * Scripts/check-inspector-strings:
 720
 721 2011-01-13  Sheriff Bot  <webkit.review.bot@gmail.com>
 722
 723         Unreviewed, rolling out r74881.
 724         http://trac.webkit.org/changeset/74881
 725         https://bugs.webkit.org/show_bug.cgi?id=52357
 726
 727         The EFL builder has been red for days (Requested by abarth on
 728         #webkit).
 729
 730         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
 731         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
 732
 733 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
 734
 735         Reviewed by David Levin.
 736
 737         Add beforeunload support to WebKitTestRunner
 738         https://bugs.webkit.org/show_bug.cgi?id=52353
 739
 740         This makes a number of currently failing tests pass.
 741
 742         * WebKitTestRunner/TestController.cpp:
 743         (WTR::runBeforeUnloadConfirmPanel):
 744         (WTR::createOtherPage):
 745         (WTR::TestController::initialize):
 746
 747 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
 748
 749         Reviewed by Sam Weinig.
 750
 751         Detect, identify and recover from WebProcess crashes in run-webkit-tests
 752         https://bugs.webkit.org/show_bug.cgi?id=52330
 753
 754         * Scripts/old-run-webkit-tests: Detect when the regression test tool reports
 755         a web process crash.
 756         * WebKitTestRunner/TestController.cpp:
 757         (WTR::TestController::initialize): Set up a processDidCrash
 758         callback.
 759         (WTR::TestController::processDidCrash): Report that the Web process
 760         crashed.
 761         * WebKitTestRunner/TestController.h:
 762
 763 2011-01-12  David Levin  <levin@chromium.org>
 764
 765         Reviewed by Shinichiro Hamaji.
 766
 767         check-webkit-style -- close_expression function doesn't work correctly.
 768         https://bugs.webkit.org/show_bug.cgi?id=52272
 769
 770         * Scripts/webkitpy/style/checkers/cpp.py:
 771         (Position.__str__): Added a way to convert it to a string which is useful in tests.
 772         (Position.__cmp__): Added a way to compare Position which is useful in tests and
 773         generally useful (for upcoming code changes).
 774         (close_expression): Changed to use Position for input and output.
 775         Also, fixed many bugs such as only working correctly for parenthesis,
 776         not working correctly if given an offset in a line and not finding
 777         the real closing element if there were multiple closing elements in
 778         the same line.
 779         (detect_functions): Adjusted due to the change in arguments for
 780         close_expression.
 781         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
 782         (CppStyleTestBase.assert_positions_equal): Added a way to verify that
 783         two positions are the same.
 784         (CppStyleTest.test_position): Added tests for the __str_ and __cmp__ methods.
 785         (CppStyleTest.test_close_expression): Added tests to catch the issues
 786         that were fixed.
 787
 788 2011-01-12  Sheriff Bot  <webkit.review.bot@gmail.com>
 789
 790         Unreviewed, rolling out r75576.
 791         http://trac.webkit.org/changeset/75576
 792         https://bugs.webkit.org/show_bug.cgi?id=52304
 793
 794         broke rebaseline-chromium-webkit-test (Requested by thakis on
 795         #webkit).
 796
 797         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
 798         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
 799         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
 800         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
 801         * Scripts/webkitpy/layout_tests/port/base.py:
 802         * Scripts/webkitpy/layout_tests/port/chromium.py:
 803         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
 804         * Scripts/webkitpy/layout_tests/port/test.py:
 805         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
 806         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
 807         * Scripts/webkitpy/style/checkers/test_expectations.py:
 808         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
 809
 810 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
 811
 812         Reviewed by Darin Adler.
 813
 814         Add a no-build option to run-webkit-tests, to avoid building DRT/WKTR
 815         https://bugs.webkit.org/show_bug.cgi?id=52307
 816
 817         * Scripts/old-run-webkit-tests:
 818
 819 2011-01-12  Koan-Sin Tan  <koansin.tan@gmail.com>
 820
 821         Reviewed by Martin Robinson.
 822
 823         [Gtk] WebKitGtk+ doesn't build on Mac OS X 10.6
 824         https://bugs.webkit.org/show_bug.cgi?id=50867
 825
 826         Fixed library extention for Mac in webkitdirs.pm and type conflict in
 827         TestNetscapePlugin.cpp
 828
 829         * GNUmakefile.am: Don't use AppKit when compiling TestNetscapePlugin for GTK+
 830         * Scripts/webkitdirs.pm:
 831
 832 2011-01-12  Mikhail Naganov  <mnaganov@chromium.org>
 833
 834         Reviewed by Pavel Feldman.
 835
 836         Add check-inspector-strings script.
 837
 838         https://bugs.webkit.org/show_bug.cgi?id=52295
 839
 840         * Scripts/check-inspector-strings: Added.
 841
 842 2011-01-12  Adam Roben  <aroben@apple.com>
 843
 844         Advertise the .testnetscape file extension on Windows
 845
 846         Fixes <http://webkit.org/b/52298>
 847         plugins/no-mime-with-valid-extension.html fails on Windows
 848
 849         Reviewed by Dan Bernstein.
 850
 851         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Added a
 852         FileExtents field to map the .testnetscape file extension to the
 853         application/x-webkit-test-netscape MIME type, just as we do on Mac.
 854
 855 2011-01-12  Adam Barth  <abarth@webkit.org>
 856
 857         Reviewed by Eric Seidel.
 858
 859         Make webkit-patch support subdirectories for SVN checkouts
 860         https://bugs.webkit.org/show_bug.cgi?id=52261
 861
 862         os.relpath does not exist on Python 2.5, so we need to call our version
 863         of the API.
 864
 865         * Scripts/webkitpy/common/checkout/scm.py:
 866
 867 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
 868
 869         Reviewed by Eric Seidel.
 870
 871         Close additional pages opened during a test once the test completes.
 872         https://bugs.webkit.org/show_bug.cgi?id=52276
 873
 874         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
 875         (WTR::InjectedBundle::done):
 876
 877 2011-01-11  David Levin  <levin@chromium.org>
 878
 879         Reviewed by Eric Seidel.
 880
 881         Errors should be separated from the command line in bot messages.
 882         https://bugs.webkit.org/show_bug.cgi?id=52275
 883
 884         * Scripts/webkitpy/common/system/executive.py:
 885         (ScriptError.message_with_output): Added a newline to separate the command
 886         line from the errors.
 887         * Scripts/webkitpy/common/system/executive_unittest.py:
 888         (ScriptErrorTest.test_message_with_output): Added tests for the various code
 889         paths in message_with_output.
 890
 891 2011-01-11  Eric Seidel  <eric@webkit.org>
 892
 893         Unreviewed.
 894
 895         commit-queue should know how to upload archived results (for test flakes or general failures)
 896         https://bugs.webkit.org/show_bug.cgi?id=52048
 897
 898         The zips are mostly empty due to forgetting -r.
 899         Expected diffs were not being pulled from the archive due
 900         to the archive having longer paths than I realized.
 901
 902         * Scripts/webkitpy/common/system/workspace.py:
 903         * Scripts/webkitpy/common/system/workspace_unittest.py:
 904         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
 905         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
 906
 907 2011-01-11  Dirk Pranke  <dpranke@chromium.org>
 908
 909         Reviewed by Ojan Vafai.
 910
 911         The current modifier parsing code in test_expectations is
 912         fragile and hard-coded, so it's not easy to understand the logic
 913         or easily add new types of modifiers (like GPU vs. CPU testing
 914         for graphics tests, or 32-bit vs. 64-bit differences).
 915
 916         This is the first of two patches that will add in more generic
 917         support and then eliminate the GPU-specific test expectations
 918         files for Chromium.
 919
 920         This patch adds two standalone objects for handling modifiers. The
 921         rules for interpreting modifiers, precedence, and conflicts are
 922         given in the docstring to the ModifierMatcher class, which
 923         returns ModifierMatchResult objects.
 924
 925         This patch also adds routines to the Port interface and a
 926         default set of values in the base object, in order to obtain the
 927         values needed on a given test run. These values are then passed
 928         to the expectation parser. This also allows us to clean up the
 929         logic used to lint all of the different configurations in a
 930         single test_expectations.txt file.
 931
 932         The next patch will merge in the separate GPU expectations file.
 933
 934         https://bugs.webkit.org/show_bug.cgi?id=51222
 935
 936         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
 937         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
 938         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
 939         * Scripts/webkitpy/layout_tests/port/base.py:
 940         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
 941         * Scripts/webkitpy/layout_tests/port/chromium.py:
 942         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
 943         * Scripts/webkitpy/layout_tests/port/test.py:
 944         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
 945         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
 946
 947 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
 948
 949         Reviewed by Adam Barth.
 950
 951         Make webkit-patch support subdirectories for SVN checkouts
 952         https://bugs.webkit.org/show_bug.cgi?id=52261
 953
 954         * Scripts/webkitpy/common/checkout/scm.py:
 955         * Scripts/webkitpy/style_references.py:
 956         * Scripts/webkitpy/tool/main.py:
 957         * Scripts/webkitpy/tool/steps/preparechangelog.py:
 958
 959 2011-01-11  Eric Seidel  <eric@webkit.org>
 960
 961         Unreviewed.
 962
 963         commit-queue should know how to upload archived results (for test flakes or general failures)
 964         https://bugs.webkit.org/show_bug.cgi?id=52048
 965
 966         I changed the API for archive_last_layout_test_results w/o updating the implementation.  Oops.
 967         This fixes an exception seen on the commit-queue when attempting to report flaky tests.
 968
 969         * Scripts/webkitpy/common/system/workspace.py:
 970         * Scripts/webkitpy/common/system/workspace_unittest.py:
 971         * Scripts/webkitpy/tool/commands/queues.py:
 972
 973 2011-01-11  Sam Weinig  <sam@webkit.org>
 974
 975         Roll r75474 back in.
 976
 977 2011-01-11  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
 978
 979         Reviewed by Kenneth Rohde Christiansen.
 980
 981         [Qt] Remove uses of QFuture since it isn't supported on all platforms.
 982         https://bugs.webkit.org/show_bug.cgi?id=51204
 983
 984         * QtTestBrowser/webpage.h:
 985         (QtNAMThread::QtNAMThread):
 986         (QtNAMThread::networkAccessManager):
 987         (QtNAMThread::run):
 988
 989 2011-01-11  Peter Varga  <pvarga@webkit.org>
 990
 991         Unreviewed.
 992
 993         Add myself to committers' list.
 994
 995         * Scripts/webkitpy/common/config/committers.py:
 996
 997 2011-01-11  Eric Seidel  <eric@webkit.org>
 998
 999         Reviewed by Adam Barth.
1000
1001         commit-queue should know how to upload archived results (for test flakes or general failures)
1002         https://bugs.webkit.org/show_bug.cgi?id=52048
1003
1004         Now the queue will always upload results.  Either the entire zip, or just
1005         the diffs.txt in the case of text failures.
1006
1007         This should make understanding flakes much easier, and paves the way
1008         for having the EWS run layout tests (and upload failures).
1009
1010         In order to upload .zip files I had to teach bugzilla.py to autodetect
1011         mime types from the filename.  Since mimetypes.py doesn't include a mapping
1012         for .patch files, I have it add one before calling guess_type.
1013
1014         We may find that always uploading the whole zip instead of just the -diffs.txt
1015         file is preferable, but for now I'm keeping the old behavior because it makes
1016         quickly understanding text failures easy.
1017
1018         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1019         * Scripts/webkitpy/common/system/workspace.py: Added.
1020         * Scripts/webkitpy/common/system/workspace_unittest.py: Added.
1021         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1022         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1023         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1024         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1025         * Scripts/webkitpy/tool/commands/queues.py:
1026         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1027
1028 2011-01-10  Sheriff Bot  <webkit.review.bot@gmail.com>
1029
1030         Unreviewed, rolling out r75464.
1031         http://trac.webkit.org/changeset/75464
1032         https://bugs.webkit.org/show_bug.cgi?id=52193
1033
1034         Followup rollout for 75474 (Requested by Ossy on #webkit).
1035
1036         * MiniBrowser/mac/BrowserWindowController.m:
1037         (-[BrowserWindowController awakeFromNib]):
1038         * MiniBrowser/win/BrowserView.cpp:
1039         (BrowserView::create):
1040         * WebKitTestRunner/TestController.cpp:
1041         (WTR::createOtherPage):
1042         (WTR::TestController::initialize):
1043
1044 2011-01-10  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1045
1046         Reviewed by Csaba Osztrogonác.
1047
1048         [Qt] Baseline qt_minimal configuration
1049         https://bugs.webkit.org/show_bug.cgi?id=51313
1050
1051         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1052         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): Add
1053         QT_NO_UNDOSTACK guard.
1054
1055         * QtTestBrowser/launcherwindow.cpp:
1056         (LauncherWindow::createChrome): Add QT_NO_SHORTCUT and QT_NO_PRINTER
1057         guards.
1058         (LauncherWindow::applyZoom): Add QT_NO_ANIMATION guard.
1059         (LauncherWindow::screenshot): Add QT_NO_FILEDIALOG guard.
1060         (LauncherWindow::selectElements): Add QT_NO_INPUTDIALOG guard.
1061         (LauncherWindow::showUserAgentDialog): Add QT_NO_COMBOBOX guard.
1062
1063         * QtTestBrowser/launcherwindow.h:
1064         * QtTestBrowser/locationedit.cpp: Add QT_NO_INPUTDIALOG guard.
1065         * QtTestBrowser/locationedit.h: Ditto.
1066
1067         * QtTestBrowser/mainwindow.cpp:
1068         (MainWindow::buildUI): Add QT_NO_INPUTDIALOG, QT_NO_SHORTCUT and
1069         QT_NO_UNDOSTACK guards.
1070         (MainWindow::setAddressUrl): Add QT_NO_INPUTDIALOG guard.
1071         (MainWindow::changeLocation): Ditto.
1072         (MainWindow::openFile): Add QT_NO_FILEDIALOG guard.
1073         (MainWindow::openLocation): Add QT_NO_INPUTDIALOG guard.
1074
1075         * QtTestBrowser/webpage.cpp:
1076         (WebPage::openUrlInDefaultBrowser): Add QT_NO_DESKTOPSERVICES guard.
1077         (WebPage::authenticationRequired): Add QT_NO_LINEEDIT guard.
1078
1079         * QtTestBrowser/webview.cpp:
1080         (WebViewGraphicsBased::animatedFlip): Add QT_NO_ANIMATION guard.
1081         (WebViewGraphicsBased::animatedYFlip): Ditto.
1082
1083 2011-01-10  Sam Weinig  <sam@webkit.org>
1084
1085         Fix build.
1086
1087         * MiniBrowser/mac/BrowserWindowController.m:
1088         (-[BrowserWindowController awakeFromNib]):
1089         * MiniBrowser/win/BrowserView.cpp:
1090         (BrowserView::create):
1091         * WebKitTestRunner/TestController.cpp:
1092         (WTR::createOtherPage):
1093         (WTR::TestController::initialize):
1094
1095 2011-01-10  Eric Seidel  <eric@webkit.org>
1096
1097         Reviewed by Ojan Vafai.
1098
1099         style-queue messages are way too long for big patches
1100         https://bugs.webkit.org/show_bug.cgi?id=52161
1101
1102         We definitely could build much fancier list-to-string-with-limit functions
1103         but this should be sufficient for our needs at the moment.
1104
1105         * Scripts/webkitpy/common/system/executive.py:
1106         * Scripts/webkitpy/common/system/executive_unittest.py:
1107
1108 2011-01-10  Tony Chang  <tony@chromium.org>
1109
1110         Unreviewed, rolling out r75398.
1111         http://trac.webkit.org/changeset/75398
1112         https://bugs.webkit.org/show_bug.cgi?id=52008
1113
1114         Some layout tests are crashing on Chromium Win.
1115
1116         * DumpRenderTree/chromium/WebViewHost.cpp:
1117         (WebViewHost::updatePaintRect):
1118         * DumpRenderTree/chromium/WebViewHost.h:
1119
1120 2011-01-10  Adam Roben  <aroben@apple.com>
1121
1122         Roll out r75392
1123
1124         It isn't needed now that r75289 has been rolled out.
1125
1126         * Scripts/run-javascriptcore-tests:
1127
1128 2011-01-10  Maciej Stachowiak  <mjs@apple.com>
1129
1130         Reviewed by Anders Carlsson.
1131
1132         WebKitTestRunner uses crazy amounts of CPU, making layout tests slow and flaky
1133         https://bugs.webkit.org/show_bug.cgi?id=52160
1134
1135         * WebKitTestRunner/mac/TestControllerMac.mm:
1136         (WTR::TestController::platformRunUntil): Instead of busy-looping, wait for the timeout.
1137         Anything that can make runUntil() conditions turn true will happen on a run loop cycle
1138         anyway.
1139
1140 2011-01-10  Tony Chang  <tony@chromium.org>
1141
1142         Reviewed by Mihai Parparita.
1143
1144         [chromium] fix for animated gif layout tests
1145         https://bugs.webkit.org/show_bug.cgi?id=52008
1146
1147         * DumpRenderTree/chromium/WebViewHost.cpp: Schedule a paint when we update the paint rect
1148             to trigger gif animations.
1149         (WebViewHostPaintTask::WebViewHostPaintTask):
1150         (WebViewHostPaintTask::runIfValid):
1151         (WebViewHost::updatePaintRect):
1152         * DumpRenderTree/chromium/WebViewHost.h:
1153         (WebViewHost::taskList):
1154
1155 2011-01-10  Alejandro G. Castro  <alex@igalia.com>
1156
1157         Reviewed by Xan Lopez.
1158
1159         [GTK] Fix gtk2 compilation for master
1160         https://bugs.webkit.org/show_bug.cgi?id=51885
1161
1162         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
1163         (createBitmapContextFromWebView): Replaced the old
1164         gdk_drawable_get_size with gdk_pixmap_get_size.
1165
1166 2011-01-10  Patrick Gansterer  <paroga@webkit.org>
1167
1168         Reviewed by Laszlo Gombos.
1169
1170         [WINCE] Reenable NPAPI after r75203
1171         https://bugs.webkit.org/show_bug.cgi?id=52109
1172
1173         Remove the !isWinCE() check for ENABLE_NETSCAPE_PLUGIN_API and replace
1174         it with !isEfl(), because EFL port does not support NPAPI (yet).
1175
1176         * Scripts/build-webkit:
1177
1178 2011-01-10  Adam Roben  <aroben@apple.com>
1179
1180         Skip some asserting JS tests
1181
1182         See <http://webkit.org/b/52156>.
1183
1184         * Scripts/run-javascriptcore-tests:
1185
1186 2011-01-10  Martin Robinson  <mrobinson@igalia.com>
1187
1188         Reviewed by Xan Lopez.
1189
1190         [GTK] build-webkit disable Blob support via arguments passed to automake
1191         https://bugs.webkit.org/show_bug.cgi?id=52097
1192
1193         * Scripts/build-webkit: Enable Blob support when building WebKitGTK+ via
1194         build-webkit.
1195
1196 2011-01-10  Adam Roben  <aroben@apple.com>
1197
1198         Use the same name and description for TestNetscapePlugin on Windows and
1199         Mac
1200
1201         Fixes <http://webkit.org/b/52151>
1202         fast/frames/iframe-reparenting-plugins.html fails on Windows
1203
1204         Reviewed by Steve Falkenburg.
1205
1206         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Copied
1207         the name and description from Mac's Info.plist.
1208
1209 2011-01-10  Siddharth Mathur <siddharth.mathur@nokia.com>
1210
1211         Reviewed by Laszlo Gombos.
1212
1213         [Qt][WK2] Guard gcc-specific syntax
1214
1215         Non-gcc based compliers choke on the "-include"
1216         syntax for preinclude, place guard around it.
1217
1218         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1219         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1220
1221 2011-01-10  Andreas Kling  <kling@webkit.org>
1222
1223         Reviewed by Simon Hausmann.
1224
1225         [Qt] [WK2] MiniBrowser does not load pages opened in new windows
1226         https://bugs.webkit.org/show_bug.cgi?id=52111
1227
1228         When getting a createNewPage() callback from QWKPage, create the
1229         new page with the same QWKContext as the page that is passed to
1230         the callback.
1231
1232         * MiniBrowser/qt/BrowserView.h:
1233         * MiniBrowser/qt/BrowserWindow.cpp:
1234         (newPageFunction):
1235         (BrowserWindow::BrowserWindow):
1236         * MiniBrowser/qt/BrowserWindow.h:
1237
1238 2011-01-10  Andreas Kling  <kling@webkit.org>
1239
1240         Reviewed by Kenneth Rohde Christiansen.
1241
1242         [Qt] MiniBrowser: Remove superfluous createNewPage() callback
1243
1244         BrowserView set its own useless createNewPage() callback on QWKPage.
1245         This was immediately overridden by BrowserWindow anyway, so remove
1246         the BrowserView one.
1247
1248         * MiniBrowser/qt/BrowserView.cpp:
1249         (BrowserView::BrowserView):
1250
1251 2011-01-10  John Knottenbelt  <jknotten@chromium.org>
1252
1253         Reviewed by Jeremy Orlow.
1254
1255         [Chromium] Remove non-client-based Geolocation code
1256         https://bugs.webkit.org/show_bug.cgi?id=50921
1257
1258         * DumpRenderTree/chromium/LayoutTestController.cpp:
1259         (LayoutTestController::setGeolocationPermission):
1260         (LayoutTestController::setMockGeolocationPosition):
1261         (LayoutTestController::setMockGeolocationError):
1262         * DumpRenderTree/chromium/WebViewHost.cpp:
1263         (WebViewHost::geolocationClientMock):
1264         (WebViewHost::reset):
1265         * DumpRenderTree/chromium/WebViewHost.h:
1266
1267 2011-01-10  Eric Seidel  <eric@webkit.org>
1268
1269         Reviewed by Adam Barth.
1270
1271         Commit bot tried to land r? cq+ patch
1272         https://bugs.webkit.org/show_bug.cgi?id=36638
1273
1274         It should now be possible to post a patch with r? and cq+ and the
1275         commit-queue will correctly wait for the r+ before attempting to land the patch.
1276         (This was a feature requested by several users.)
1277
1278         One caveat: We don't actually reject r-, cq+ patches from the queue
1279         (we just ignore them), but I think that's OK for now.
1280
1281         I also noticed that setting r- once a commit-queue node had grabbed
1282         a patch would not properly cancel the landing.  That's fixed and
1283         tested in this patch.
1284
1285         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1286         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1287         * Scripts/webkitpy/tool/bot/feeders.py:
1288         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
1289
1290 2011-01-08  Benjamin Poulain  <benjamin.poulain@nokia.com>
1291
1292         Reviewed by Kenneth Rohde Christiansen.
1293
1294         [Qt] QtWebKit crashes when using XMLHttpRequest from the unload event
1295         https://bugs.webkit.org/show_bug.cgi?id=51934
1296
1297         When accessing the network from the destructor of QWebPage, the network access manager
1298         was already deleted because the object WebPage was already destructed.
1299
1300         This solve the problem by linking the lifetime of the network access manager to WebPage's QObject.
1301         The object is now destructed in the destructor of QObject.
1302
1303         * QtTestBrowser/webpage.cpp:
1304         (WebPage::WebPage):
1305         (WebPage::setQnamThreaded):
1306         * QtTestBrowser/webpage.h:
1307         (QtNAMThread::QtNAMThread):
1308
1309 2011-01-08  Eric Seidel  <eric@webkit.org>
1310
1311         Reviewed by Ojan Vafai.
1312
1313         test_failures.py should not mention TestShell (long live DumpRenderTree!)
1314         https://bugs.webkit.org/show_bug.cgi?id=52067
1315
1316         I ran test-webkitpy, but didn't bother adding a unit test for this string change.
1317         https://bugs.webkit.org/show_bug.cgi?id=51138#c3 is an example of why this is needed.
1318
1319         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1320
1321 2011-01-08  Eric Seidel  <eric@webkit.org>
1322
1323         Reviewed by Mihai Parparita.
1324
1325         commit-queue hangs when the ChangeLog diff is bad
1326         https://bugs.webkit.org/show_bug.cgi?id=52072
1327
1328         * Scripts/webkitpy/tool/steps/validatechangelogs.py:
1329         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
1330
1331 2011-01-08  Adam Barth  <abarth@webkit.org>
1332
1333         Teach svn-apply how to re-write WebCore to Source/WebCore.
1334
1335         * Scripts/VCSUtils.pm:
1336
1337 2011-01-07  Adam Barth  <abarth@webkit.org>
1338
1339         Rubber-stamped by Eric Seidel.
1340
1341         Move WebCore to Source
1342         https://bugs.webkit.org/show_bug.cgi?id=52050
1343
1344         Update the tools to understand WebCore's new location.
1345
1346         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1347         * DumpRenderTree/wscript:
1348         * GNUmakefile.am:
1349         * Scripts/build-webkit:
1350         * Scripts/do-file-rename:
1351         * Scripts/do-webcore-rename:
1352         * Scripts/generate-qt-inspector-resource:
1353         * Scripts/prepare-ChangeLog:
1354         * Scripts/run-bindings-tests:
1355         * Scripts/update-iexploder-cssproperties:
1356         * Scripts/update-sources-list.py:
1357         * Scripts/update-webkit-localizable-strings:
1358         * Scripts/webkitdirs.pm:
1359         * Scripts/webkitpy/common/config/build.py:
1360         * Scripts/webkitpy/common/config/build_unittest.py:
1361         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
1362         * Scripts/webkitpy/style/checker.py:
1363         * Scripts/webkitpy/style/checker_unittest.py:
1364         * WebKitTestRunner/DerivedSources.pro:
1365         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1366         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh:
1367         * wx/browser/wscript:
1368         * wx/build/settings.py:
1369
1370 2011-01-07  Maciej Stachowiak  <mjs@apple.com>
1371
1372         Reviewed by Sam Weinig.
1373
1374         Make WebKitTestRunner rest between loads more robust to avoid test crashes
1375         https://bugs.webkit.org/show_bug.cgi?id=52086
1376
1377         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1378         (WTR::InjectedBundle::didReceiveMessage):
1379         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1380         (WTR::LayoutTestController::notifyDone):
1381         * WebKitTestRunner/TestController.cpp:
1382         (WTR::TestController::resetStateToConsistentValues):
1383         (WTR::TestController::run):
1384
1385 2011-01-07  James Robinson  <jamesr@chromium.org>
1386
1387         Revert "Implement mozilla's animationTime property"
1388         https://bugs.webkit.org/show_bug.cgi?id=51952
1389
1390         This approach isn't quite right.
1391
1392         * DumpRenderTree/chromium/WebViewHost.cpp:
1393         (WebViewHost::paintInvalidatedRegion):
1394
1395 2011-01-07  Adam Roben  <aroben@apple.com>
1396
1397         Build master fix
1398
1399         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1400         (RunWebKitTests.start): Don't try to concatenate a list and a string.
1401
1402 2011-01-07  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>
1403
1404         Reviewed by Csaba Osztrogonác.
1405
1406         run-qtwebkit-tests should be able to kill a testsuite.
1407
1408         Add new option in the script that can setup a timeout for a test.
1409         If the test execution takes more then specified time then the test
1410         would be terminated.
1411
1412         [Qt] run-qtwebkit-tests needs timeout
1413         https://bugs.webkit.org/show_bug.cgi?id=51894
1414
1415         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1416         * Scripts/run-qtwebkit-tests:
1417
1418 2011-01-07  Csaba Osztrogonác  <ossy@webkit.org>
1419
1420         Unreviewed fix after r75233.
1421
1422         Based on idea from Eric Seidel.
1423
1424         Add remote zip file handling to webkitpy.
1425         https://bugs.webkit.org/show_bug.cgi?id=50901
1426
1427         * Scripts/webkitpy/common/system/fileset.py: Make python 2.5 happy.
1428
1429 2011-01-07  Shane Stephens  <shanestephens@google.com>
1430
1431         Reviewed by Eric Seidel.
1432
1433         svn-apply: should support git binary delta diffs
1434         https://bugs.webkit.org/show_bug.cgi?id=38864
1435
1436         * Scripts/VCSUtils.pm:
1437         * Scripts/svn-apply:
1438
1439 2011-01-06  Julie Parent  <jparent@chromium.org>
1440
1441         Reviewed by Eric Seidel.
1442
1443         Test Result Server not removing old results.
1444         https://bugs.webkit.org/show_bug.cgi?id=52012
1445
1446         * TestResultServer/model/jsonresults.py:
1447         Fix off-by-one: Truncate if >= num_runs, not just >.
1448         * TestResultServer/model/jsonresults_unittest.py:
1449         Add unit test to test that merging in a new result with the same value
1450         as the last result causes previous result to fall off.
1451
1452 2011-01-06  James Kozianski  <koz@chromium.org>
1453
1454         Reviewed by Mihai Parparita.
1455
1456         Add classes to provide a consistent interface to a set of files.
1457         https://bugs.webkit.org/show_bug.cgi?id=50901
1458
1459         These classes allow us to write code that is agnostic to whether a
1460         particular set of files resides in a local directory or in a zip file
1461         on a remote machine.
1462
1463         * Scripts/webkitpy/common/system/directoryfileset.py: Added.
1464         * Scripts/webkitpy/common/system/directoryfileset_unittest.py: Added.
1465         * Scripts/webkitpy/common/system/fileset.py: Added.
1466         * Scripts/webkitpy/common/system/filesystem.py:
1467         * Scripts/webkitpy/common/system/filesystem_mock.py:
1468         * Scripts/webkitpy/common/system/zipfileset.py: Added.
1469         * Scripts/webkitpy/common/system/zipfileset_unittest.py: Added.
1470
1471 2011-01-06  Eric Seidel  <eric@webkit.org>
1472
1473         Reviewed by Adam Barth.
1474
1475         NetworkTransaction should log the url it is retrying
1476         https://bugs.webkit.org/show_bug.cgi?id=52043
1477
1478         * Scripts/webkitpy/common/net/networktransaction.py:
1479         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
1480
1481 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
1482
1483         Windows build fix.
1484         Import os before using it.
1485
1486         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1487
1488 2011-01-06  Eric Seidel  <eric@webkit.org>
1489
1490         Reviewed by Adam Barth.
1491
1492         StyleQueue fails to report errors when patches have many files
1493         https://bugs.webkit.org/show_bug.cgi?id=52042
1494
1495         This is one of at least two errors preventing style error reporting at the moment.
1496         When we moved to passing the list of files to check explicitly,
1497         we started to exceed the 500 character TEXT field limit for our AppEngine model object.
1498         We could change the type of the QueueStatus.message type, or we could
1499         just teach statusserver.py how to clamp values (and warn when it does).
1500         I chose the latter path.
1501
1502         * Scripts/webkitpy/common/net/statusserver.py:
1503
1504 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
1505
1506         Reviewed by Stephanie Lewis.
1507
1508         Fix syntax error in script.
1509
1510         Windows bots need to archive/unarchive builds to/from configuration-specific directories
1511         https://bugs.webkit.org/show_bug.cgi?id=51996
1512
1513         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1514
1515 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1516
1517         Unreviewed, fixing WinCE build after r75196.
1518
1519         WinCE port does not (yet) support NPAPI.
1520
1521         * Scripts/build-webkit:
1522
1523 2011-01-06  Xan Lopez  <xlopez@igalia.com>
1524
1525         Reviewed by Darin Adler.
1526
1527         File::Spec->rel2abs in sunspider-compare-results mangles parameters
1528         https://bugs.webkit.org/show_bug.cgi?id=52015
1529
1530         * Scripts/sunspider-compare-results: call rel2abs on our arguments
1531         after the platform has been detected, otherwise the script will
1532         mangle things like '--gtk' into '/a/path/--gtk', breaking the
1533         detection.
1534
1535 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1536
1537         Reviewed by Eric Seidel.
1538
1539         Add ENABLE_NETSCAPE_PLUGIN_API, ENABLE_ORIENTATION_EVENTS and ENABLE_TOUCH_EVENTS flags to build-webkit
1540         https://bugs.webkit.org/show_bug.cgi?id=51346
1541
1542         * Scripts/build-webkit:
1543
1544 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
1545
1546         Reviewed by Adam Roben.
1547
1548         Windows bots need to archive/unarchive builds to/from configuration-specific directories
1549         https://bugs.webkit.org/show_bug.cgi?id=51996
1550
1551         After the configuration directory change, we were archiving the incorrect directory for
1552         build product, so we were running tests on the wrong binaries.
1553
1554         This change archives the correct directory, and also unarchives it into a configuration-
1555         specific directory.
1556
1557         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Use a configuration-specific directory on Windows.
1558         * BuildSlaveSupport/built-product-archive: Unarchive/archive to/from proper directory.
1559
1560 2011-01-06  Eric Seidel  <eric@webkit.org>
1561
1562         Reviewed by Mihai Parparita.
1563
1564         commit-queue mentions "Text diff mismatch" 4 times instead of once per failure
1565         https://bugs.webkit.org/show_bug.cgi?id=52002
1566
1567         See an example of this here:
1568         https://bugs.webkit.org/show_bug.cgi?id=51314#c2
1569
1570         It's due to the fact that we pass around TestFailure() instance
1571         objects and yet expect them to all compare to be the same.
1572
1573         This is bad.  We should either have shared instances of these values
1574         or we should just pass around the class names.  There are already hacks
1575         in place to make TestFailure objects pass equality tests, I just added
1576         a __hash__ implementation so they can be used in sets as expected.
1577
1578         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1579         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1580
1581 2011-01-06  Evan Martin  <evan@chromium.org>
1582
1583         Reviewed by Tony Chang.
1584
1585         [gdb] handle inaccessible memory and UChar*
1586         https://bugs.webkit.org/show_bug.cgi?id=52003
1587
1588         To pretty-print a UChar*, we just grope around in the memory
1589         looking for a terminating NUL.  We need to handle the exception
1590         that can occur when we poke into an invalid location.
1591
1592         Additionally, the logic for choosing which pretty-printer would
1593         early return before hitting the point where we'd use the UChar*
1594         printer.  (Did this ever work?  How did it regress?)
1595
1596         * gdb/webkit.py:
1597
1598 2011-01-05  Brian Weinstein  <bweinstein@apple.com>
1599
1600         Reviewed by Ada Chan.
1601
1602         WebKit2: Should be able to call into injected bundle to ask if we should allow resource loads
1603         https://bugs.webkit.org/show_bug.cgi?id=51969
1604
1605         Add shouldLoadResourceForFrame to WTR::InjectedBundlePage.
1606
1607         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1608         (WTR::InjectedBundlePage::InjectedBundlePage):
1609         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Stub implementation.
1610         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1611
1612 2011-01-06  James Robinson  <jamesr@chromium.org>
1613
1614         Reviewed by Simon Fraser.
1615
1616         Implement mozilla's animationTime property
1617         https://bugs.webkit.org/show_bug.cgi?id=51952
1618
1619         Chromium DRT support for webkitAnimationTime.
1620
1621         * DumpRenderTree/chromium/WebViewHost.cpp:
1622         (WebViewHost::paintInvalidatedRegion):
1623
1624 2011-01-06  Julie Parent  <jparent@chromium.org>
1625
1626         Reviewed by Tony Chang.
1627
1628         Test Result Server always truncates number of results to JSON_RESULTS_MAX_BUILDS
1629         https://bugs.webkit.org/show_bug.cgi?id=51217
1630
1631         * TestResultServer/model/jsonresults.py:
1632         Pass num_runs through to _remove_items_over_max_number_of_builds, and use the value.
1633         Adds missing documentation.
1634         * TestResultServer/model/jsonresults_unittest.py:
1635         Add unit test to test that truncation happens at smaller value than JSON_RESULTS_MAX_BUILDS.
1636         Update test_merge to take a number of builds to truncate at.
1637
1638 2011-01-06  Adam Barth  <abarth@webkit.org>
1639
1640         Reviewed by Eric Seidel.
1641
1642         The EWS should log outside of the working directory
1643         https://bugs.webkit.org/show_bug.cgi?id=51986
1644
1645         This patch prepare us for using git clean -x -d -f in the EWS wrapper
1646         script, which will actually clean the working copy back to a pristine
1647         state instead of leaving untracked directories and ignored files.
1648
1649         * Scripts/webkitpy/tool/commands/queues.py:
1650         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1651
1652 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
1653
1654         Windows build fix.
1655         Back out attempted change to built-product-archive.
1656
1657         * BuildSlaveSupport/built-product-archive:
1658
1659 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
1660
1661         Windows build fix.
1662         Include configuration name when unpacking a build archive.
1663
1664         Needed, since we split Windows build results into configuration-specific directories
1665         under WebKitOutputDir.
1666
1667         * BuildSlaveSupport/built-product-archive:
1668
1669 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
1670
1671         Reviewed by Darin Adler.
1672
1673         Debug and Release builds on Windows clobber each other
1674         https://bugs.webkit.org/show_bug.cgi?id=49185
1675
1676         Changes the structure of WebKitBuild build products directory so we
1677         completely separate each build configuration into independent directories.
1678
1679         Although we previously had per-configuration directories for obj, this change adds
1680         per-configuration directories for bin, lib, obj, and include. Each configuration's
1681         build products are stored within a directory inside of WebKitBuild.
1682
1683         Most use of $(WebKitOutputDir) in the build files has been replaced by $(ConfigurationBuildDir),
1684         defined in common.vsprops to be $(WebKitOutputDir)\$(ConfigurationName).
1685
1686         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops:
1687         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd:
1688         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd:
1689         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
1690         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd:
1691         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd:
1692         * DumpRenderTree/win/ImageDiffCommon.vsprops:
1693         * DumpRenderTree/win/ImageDiffPostBuild.cmd:
1694         * DumpRenderTree/win/ImageDiffPreBuild.cmd:
1695         * FindSafari/FindSafari.vcproj:
1696         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
1697         * MiniBrowser/MiniBrowserPostBuild.cmd:
1698         * MiniBrowser/MiniBrowserPreBuild.cmd:
1699         * Scripts/webkitdirs.pm:
1700         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
1701         * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops:
1702         * TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd:
1703         * TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd:
1704         * TestWebKitAPI/win/copy-resources.cmd:
1705         * WebKitAPITest/WebKitAPITestCommon.vsprops:
1706         * WebKitAPITest/WebKitAPITestPostBuild.cmd:
1707         * WebKitAPITest/WebKitAPITestPreBuild.cmd:
1708         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
1709         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
1710         * WebKitTestRunner/win/InjectedBundle.vcproj:
1711         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops:
1712         * WebKitTestRunner/win/InjectedBundlePostBuild.cmd:
1713         * WebKitTestRunner/win/InjectedBundlePreBuild.cmd:
1714         * WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd:
1715         * WebKitTestRunner/win/WebKitTestRunnerPreBuild.cmd:
1716         * WinLauncher/WinLauncherCommon.vsprops:
1717         * WinLauncher/WinLauncherPostBuild.cmd:
1718         * WinLauncher/WinLauncherPreBuild.cmd:
1719
1720 2011-01-05  Jan Erik Hanssen  <jhanssen@sencha.com>
1721
1722         Reviewed by Ariya Hidayat.
1723
1724         [Qt] TestNetscapePlugin doesn't link on OS X
1725         https://bugs.webkit.org/show_bug.cgi?id=51948
1726
1727         Only add a dependency on libX11 on X11 systems
1728
1729         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1730
1731 2011-01-05  Jeff Miller  <jeffm@apple.com>
1732
1733         Reviewed by Adam Roben.
1734
1735         check-webkit-style should allow unnecessary parameter names in WebKit2 APIs because we're matching CF's header style
1736         https://bugs.webkit.org/show_bug.cgi?id=51970
1737
1738         * Scripts/webkitpy/style/checker.py:
1739         Add -readability/naming for WebKit2 C API directories.
1740
1741 2011-01-05  Eric Seidel  <eric@webkit.org>
1742
1743         Unreviewed, just fixing one more log error from my previous python patch.
1744
1745         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
1746         https://bugs.webkit.org/show_bug.cgi?id=51802
1747
1748         webkit-patch failure-reason was logging about parsing errors
1749         due to my misunderstanding of how BeautifulSoup.findAll worked.
1750
1751         Fixed, and added a unit test.
1752
1753         * Scripts/webkitpy/common/net/layouttestresults.py:
1754         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1755
1756 2011-01-05  Benjamin Poulain  <benjamin.poulain@nokia.com>
1757
1758         Reviewed by Kenneth Rohde Christiansen.
1759
1760         [Qt] [WK2] Add the possibility to open window from the WebProcess in Minibrowser
1761         https://bugs.webkit.org/show_bug.cgi?id=51951
1762
1763         Set a function to QWKPage::setCreateNewPageFunction() in Minibrowser so there is a way
1764         to create new window from WebKit.
1765
1766         * MiniBrowser/qt/BrowserWindow.cpp:
1767         (newPageFunction):
1768         (BrowserWindow::BrowserWindow):
1769         (BrowserWindow::page): Added to avoid the indirect access to QWKPage spread in the class
1770         (BrowserWindow::newWindow):
1771         (BrowserWindow::updateUserAgentList):
1772         (BrowserWindow::showUserAgentDialog):
1773         * MiniBrowser/qt/BrowserWindow.h: Add the global variable backingStoreTypeForNewWindow to
1774         define the type of the backing store used for new windows.
1775         * MiniBrowser/qt/main.cpp:
1776         (main):
1777
1778 2011-01-05  Eric Seidel  <eric@webkit.org>
1779
1780         Reviewed by Ojan Vafai.
1781
1782         commit-queue should report failure type when reporting flaky tests
1783         https://bugs.webkit.org/show_bug.cgi?id=51900
1784
1785         This patch was a ridiculous amount of plumbing.  In the end I like
1786         the NRWT-style TestResult class even less.  But now we're passing
1787         a list of TestResult objects from the queue to the FlakyTestReporter.
1788         Thus the FlakyTestReporter can more easily report what type of failure
1789         occurred.
1790
1791         In the process, I found that I was not alone in finding TestResult
1792         cumbersome to use.  A bunch of code was trying to create a TestResult
1793         object with default values.  However since the constructor didn't make
1794         this easy, some places were getting it wrong (including the TestResult unit test)!
1795         I've fixed the TestResult constructor to have default values for non-essential
1796         arguments.
1797
1798         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1799         * Scripts/webkitpy/common/net/layouttestresults.py:
1800         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1801         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1802         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1803         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1804         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
1805         * Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py:
1806         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1807         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1808         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1809         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1810         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1811         * Scripts/webkitpy/tool/commands/queues.py:
1812         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1813
1814 2011-01-05  Eric Seidel  <eric@webkit.org>
1815
1816         Unreviewed.
1817
1818         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
1819         https://bugs.webkit.org/show_bug.cgi?id=51802
1820
1821         Add another unit test to cover a previously missing import.
1822
1823         * Scripts/webkitpy/common/net/layouttestresults.py:
1824         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1825
1826 2011-01-05  Mihai Parparita  <mihaip@chromium.org>
1827
1828         Reviewed by David Levin.
1829
1830         Add mihaip@chromium.org as a reviewer
1831         https://bugs.webkit.org/show_bug.cgi?id=51966
1832
1833         Add myself as a reviewer.
1834
1835         * Scripts/webkitpy/common/config/committers.py:
1836
1837 2011-01-05  James Simonsen  <simonjam@chromium.org>
1838
1839         Unreviewed. Adding myself to the list of committers.
1840
1841         * Scripts/webkitpy/common/config/committers.py:
1842
1843 2011-01-05  Eric Seidel  <eric@webkit.org>
1844
1845         Unreviewed.
1846
1847         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
1848         https://bugs.webkit.org/show_bug.cgi?id=51802
1849
1850         Fix two exceptions seen on the bots after my original commit.
1851
1852         * Scripts/webkitpy/common/net/layouttestresults.py:
1853         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1854
1855 2011-01-05  Kundu Suchismita  <suchi.kundu@nokia.com>
1856
1857         Reviewed by Andreas Kling.
1858
1859         [Qt]Add local storage settings to QtTestBrowser command line arguments
1860         https://bugs.webkit.org/show_bug.cgi?id=51750
1861
1862         * QtTestBrowser/main.cpp:
1863         (LauncherApplication::handleUserOptions):
1864          Local storage settings can be enable form command line arguments for
1865          QtTestBrowser.
1866
1867 2011-01-05  Chris Fleizach  <cfleizach@apple.com>
1868
1869         Reviewed by Martin Robinson.
1870
1871         GTK: AX: DRT needs to use correct root object method.
1872         https://bugs.webkit.org/show_bug.cgi?id=51911
1873
1874         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
1875         (AccessibilityController::rootElement):
1876
1877 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
1878
1879         Rubber-stamped by Csaba Osztrogonác.
1880
1881         Based on idea from Péter Gál.
1882
1883         * Scripts/webkitpy/tool/bot/sheriff.py: Remove unnecessary apostrophes around revision numbers.
1884
1885 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
1886
1887         Reviewed by Adam Barth.
1888
1889         sheriff-bot should be able to do multi-revision rollouts
1890         https://bugs.webkit.org/show_bug.cgi?id=51176
1891
1892         * Scripts/webkitpy/tool/bot/irc_command.py:
1893         * Scripts/webkitpy/tool/bot/sheriff.py:
1894         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
1895
1896 2011-01-05  Eric Seidel  <eric@webkit.org>
1897
1898         Reviewed by Adam Barth.
1899
1900         queues.webkit.org should have per-bot status pages
1901         https://bugs.webkit.org/show_bug.cgi?id=51906
1902
1903         Just adds a /queue-status/QUEUE_NAME/bots/BOT_ID page to show
1904         statuses from a single queue.  Now that we have many bots servicing
1905         some queues (commit-queue, win-ews, etc.) its easy to have the messages
1906         you care about scroll off the end of the 15-message limit on the main page.
1907
1908         Eventually we should probably rename /queue-status to /queue or /queues,
1909         but that's fodder for another patch.
1910
1911         * QueueStatusServer/handlers/queuestatus.py:
1912         * QueueStatusServer/index.yaml:
1913         * QueueStatusServer/main.py:
1914         * QueueStatusServer/templates/includes/singlequeuestatus.html:
1915          - This probably should use a custom filter instead of hard-coding
1916            the URL scheme here, but I couldn't figure out how to easily
1917            create such a filter.  Most filters work with "strings" so we can't
1918            pass the status object.  We could add a method to the status
1919            object and call that, but that seemed a bit strange too.
1920         * QueueStatusServer/templates/queuestatus.html:
1921
1922 2011-01-05  Carlos Garcia Campos  <cgarcia@igalia.com>
1923
1924         Unreviewed. Adding myself to the list of committers.
1925
1926         * Scripts/webkitpy/common/config/committers.py:
1927
1928 2011-01-04  Koan-Sin Tan  <koansin.tan@gmail.com>
1929
1930         Reviewed by David Levin.
1931
1932         check-webkit-style treated some macros with parentheses after #elif as function calls
1933         https://bugs.webkit.org/show_bug.cgi?id=51695
1934
1935         Ingore function call space checking in any preprocessor directives
1936         (things starting with #). Change search() to match() because
1937         preprocessor directives are supposed to be in the beginning of lines.
1938
1939         * Scripts/webkitpy/style/checkers/cpp.py:
1940         * Scripts/webkitpy/style/checkers/cpp_unittest.py: make sure there is no false positives for #elif cases
1941
1942 2011-01-04  Søren Gjesse  <sgjesse@chromium.org>
1943
1944         Reviewed by Tony Chang.
1945
1946         Change the --multi-load test option to --stress-opt
1947         https://bugs.webkit.org/show_bug.cgi?id=50751
1948
1949         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1950         (runTest):
1951         (main):
1952         * DumpRenderTree/chromium/TestShell.cpp:
1953         (TestShell::TestShell):
1954         * DumpRenderTree/chromium/TestShell.h:
1955         (TestShell::stressOpt):
1956         (TestShell::setStressOpt):
1957         (TestShell::stressDeopt):
1958         (TestShell::setStressDeopt):
1959         (TestShell::javaScriptFlags):
1960         (TestShell::setJavaScriptFlags):
1961         * Scripts/webkitpy/layout_tests/port/chromium.py:
1962         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1963
1964 2011-01-04  Chris Fleizach  <cfleizach@apple.com>
1965
1966         Reviewed by Sam Weinig.
1967
1968         WK2: Support Accessibility
1969         https://bugs.webkit.org/show_bug.cgi?id=51859
1970
1971         Use rootObject() method to get top of accessibility tree.
1972
1973         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
1974         (AccessibilityController::focusedElement):
1975         (AccessibilityController::rootElement):
1976
1977 2011-01-03  Martin Robinson  <mrobinson@igalia.com>
1978
1979         Reviewed by Darin Adler.
1980
1981         Remove the last non-GObject usage of PlatformRefPtr and move the code to GRefPtr
1982         https://bugs.webkit.org/show_bug.cgi?id=51846
1983
1984         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: Change usage of PlatformRefPtr
1985         back to GRefPtr.
1986
1987 2011-01-04  Zhe Su  <suzhe@chromium.org>
1988
1989         Reviewed by Kenneth Russell.
1990
1991         Fix insertText, setMarkedText and unmarkText methods of
1992         TextInputController to call corresponding methods of WebKit::WebView
1993         rather than WebKit::WebFrame. This change matches the behavior of
1994         chromium browser.
1995         insertText corresponds to WebView::confirmComposition(text)
1996         setMarkedText corresponds to WebView::setComposition(...)
1997         unmarkText corresponds to WebView::confirmComposition()
1998         https://bugs.webkit.org/show_bug.cgi?id=51693
1999
2000         * DumpRenderTree/chromium/TextInputController.cpp:
2001         (TextInputController::insertText):
2002         (TextInputController::setMarkedText):
2003         (TextInputController::unmarkText):
2004
2005 2011-01-04  Dihan Wickremasuriya  <dihan.wickremasuriya@nokia.com>
2006
2007         Reviewed by Laszlo Gombos.
2008
2009         [Qt] [Symbian] Do not remove 0 byte sized files from productDir
2010
2011         On Symbian productDir points to the source directory. Removing all the
2012         empty files from the productDir directory corrupts the svn repository.
2013
2014         * Scripts/build-webkit:
2015
2016 2011-01-03  Yi Shen  <yi.4.shen@nokia.com>
2017
2018         Reviewed by Adam Barth.
2019
2020         [Qt] Add SelectAll option to the context menu for the editor
2021         https://bugs.webkit.org/show_bug.cgi?id=50049
2022
2023         Set shortcut for the SelectAll action.
2024
2025         * QtTestBrowser/mainwindow.cpp:
2026         (MainWindow::buildUI):
2027
2028 2011-01-03  David Levin  <levin@chromium.org>
2029
2030         Reviewed by Eric Seidel.
2031
2032         check-webkit-style shouldn't consider "value" automatically to be a meaningless name.
2033         https://bugs.webkit.org/show_bug.cgi?id=51842
2034
2035         * Scripts/webkitpy/style/checkers/cpp.py: Remove the check for value.
2036         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Remove the test for value.
2037
2038 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
2039
2040         Reviewed by David Kilzer.
2041
2042         [WINCE] Adds a build slave.
2043         https://bugs.webkit.org/show_bug.cgi?id=50523
2044
2045         * BuildSlaveSupport/build.webkit.org-config/config.json: Add an
2046         entry for a release build of the WinCE port.
2047         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add platform
2048         flag to build the WinCE port.
2049
2050 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
2051
2052         Reviewed by David Kilzer.
2053
2054         Add WinCE support to build-webkit
2055         https://bugs.webkit.org/show_bug.cgi?id=51642
2056
2057         * Scripts/build-webkit:
2058         * Scripts/webkitdirs.pm:
2059
2060 2011-01-03  Eric Seidel  <eric@webkit.org>
2061
2062         Reviewed by Adam Barth.
2063
2064         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
2065         https://bugs.webkit.org/show_bug.cgi?id=51802
2066
2067         I'm not the biggest fan of the test_failures or test_results classes,
2068         but it's better to have one shared set of classes, than separate ones
2069         for new vs. old run-webkit-test result handling.
2070
2071         This moves the ORWT results class "LayoutTestResults" over to using
2072         TestResult and TestFailure classes, making it easy for us to
2073         make all our sheriff-bot and other webkitpy code NRWT ready.
2074
2075         This also makes it a trivial patch to generate results.json information
2076         from ORWT results.html files (for flaky test analysis, etc.) as well
2077         as making it a one-liner to report test failure types when the
2078         commit-queue sees flaky tests.
2079
2080         This patch tried not to add new functionality, but only to replace
2081         the guts of LayoutTestResults, while adding unit tests and hoping
2082         not to break anything.
2083
2084         I also moved callers which assumed User.prompt* were static/class methods
2085         to using them as instance methods (since we'll eventually want to make them such).
2086
2087         In the process of re-writing things, I broke the rebaseline command, so I wrote
2088         a unit test to catch my breakage were I do do so again in the future.
2089
2090         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2091         * Scripts/webkitpy/common/net/layouttestresults.py:
2092         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2093         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
2094         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
2095         * Scripts/webkitpy/tool/commands/queries.py:
2096         * Scripts/webkitpy/tool/commands/rebaseline.py:
2097         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2098         * Scripts/webkitpy/tool/mocktool.py:
2099
2100 2011-01-03  Adam Barth  <abarth@webkit.org>
2101
2102         Reviewed by Simon Fraser.
2103
2104         webkit-patch shouldn't waste time cleaning a working directory that's already clean
2105         https://bugs.webkit.org/show_bug.cgi?id=51840
2106
2107         * Scripts/webkitpy/common/checkout/scm.py:
2108
2109 2011-01-03  Adam Barth  <abarth@webkit.org>
2110
2111         Reviewed by Simon Fraser.
2112
2113         webkit-patch should only hide update output if --quiet
2114         https://bugs.webkit.org/show_bug.cgi?id=51838
2115
2116         As requested by smfr.
2117
2118         * Scripts/webkitpy/tool/steps/update.py:
2119
2120 2011-01-03  Adam Barth  <abarth@webkit.org>
2121
2122         Reviewed by David Levin.
2123
2124         commit-queue shouldn't reject patches twice if two bots process the same patch
2125         https://bugs.webkit.org/show_bug.cgi?id=51805
2126
2127         Before raising an error, we first check whether the patch is still in
2128         the commit-queue.  This check is still racy, of course, but the time
2129         window is much smaller.
2130
2131         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2132
2133 2011-01-03  Sam Weinig  <sam@webkit.org>
2134
2135         Reviewed by Anders Carlsson.
2136
2137         Make run-api-tests less chatty.
2138         https://bugs.webkit.org/show_bug.cgi?id=51831
2139
2140         - Make script quiet by default and add --verbose option (replacing --quiet).
2141         - When not verbose, pipe stdout and stderr to devnull.
2142
2143         * Scripts/run-api-tests:
2144
2145 2011-01-03  Pratik Solanki  <psolanki@apple.com>
2146
2147         Unreviewed. Adding myself to committers.py.
2148
2149         * Scripts/webkitpy/common/config/committers.py:
2150
2151 2011-01-03  Koan-Sin Tan  <koansin.tan@gmail.com>
2152
2153         Reviewed by Xan Lopez.
2154
2155         "Tool/Scripts/run-launcher --gtk" stopped working after 74855
2156         https://bugs.webkit.org/show_bug.cgi?id=51806
2157
2158         Originally, the $libraryName is 'JavaScriptCore'. When building release
2159         one, the $libraryDir was 'WebKitBuild/Release/JavaScriptCore/../.libs/'
2160         which doesn't exist anymore ('WebKitBuild/Release/JavaScriptCore'
2161         is 'WebKitBuild/Release/Source/JavaScriptCore' now), and
2162         'WebKitBuild/Release/Source/JavaScriptCore/../../.libs' looks weird,
2163         so make it 'WebKitBuild/Release/.libs'
2164
2165         * Scripts/webkitdirs.pm:
2166
2167 2011-01-02  Patrick Gansterer  <paroga@webkit.org>
2168
2169         Reviewed by Adam Barth.
2170
2171         Make EFL a core builder
2172         https://bugs.webkit.org/show_bug.cgi?id=51804
2173
2174         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2175         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2176
2177 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
2178
2179         [Qt] Unreviewed fix after r74855 and r74875.
2180
2181         * BuildSlaveSupport/built-product-archive:
2182          - Create directories explicitly.
2183          - Pass shell=True to subprocess.call().
2184
2185 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
2186
2187         [Qt] Unreviewed fix after r74855.
2188
2189         Move JavaScriptCore to Source
2190         https://bugs.webkit.org/show_bug.cgi?id=51604
2191
2192         * BuildSlaveSupport/built-product-archive: JavaScriptCore -> Source/JavaScriptCore
2193
2194 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
2195
2196         [Qt] Unreviewed run-javasriptcore-tests fix after r74855.
2197
2198         Move JavaScriptCore to Source
2199         https://bugs.webkit.org/show_bug.cgi?id=51604
2200
2201         * Scripts/webkitdirs.pm:
2202
2203 2011-01-02  Robert Hogan  <robert@webkit.org>
2204
2205         Unreviewed, build fix.
2206
2207         [Qt] Fix DRT build after 74855
2208
2209         * DumpRenderTree/qt/DumpRenderTree.pro:
2210
2211 2011-01-01  Adam Barth  <abarth@webkit.org>
2212
2213         Remove the assumption from the Qt and Gtk builds that every project is
2214         in the root directory.
2215
2216         * Scripts/build-webkit:
2217
2218 2011-01-01  Adam Barth  <abarth@webkit.org>
2219
2220         Reviewed by Eric Seidel.
2221
2222         Teach svn-apply how to apply patches even though JavaScriptCore has moved
2223         https://bugs.webkit.org/show_bug.cgi?id=51796
2224
2225         After this change, svn-apply will magically apply patches to
2226         JavaScriptCore/foo to Source/JavaScriptCore/foo.
2227
2228         * Scripts/VCSUtils.pm:
2229
2230 2011-01-01  Adam Barth  <abarth@webkit.org>
2231
2232         Reviewed by Eric Seidel.
2233
2234         Move JavaScriptCore to Source
2235         https://bugs.webkit.org/show_bug.cgi?id=51604
2236
2237         Update references to JavaScriptCore to point to the new location.
2238
2239         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2240         * DumpRenderTree/qt/DumpRenderTree.pro:
2241         * DumpRenderTree/qt/ImageDiff.pro:
2242         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2243         * DumpRenderTree/wscript:
2244         * Scripts/build-jsc:
2245         * Scripts/build-webkit:
2246         * Scripts/do-file-rename:
2247         * Scripts/do-webcore-rename:
2248         * Scripts/run-javascriptcore-tests:
2249         * Scripts/update-javascriptcore-test-results:
2250         * Scripts/webkitdirs.pm:
2251         * Scripts/webkitpy/common/config/build_unittest.py:
2252         * Scripts/webkitpy/style/checker.py:
2253         * Scripts/webkitpy/style/checker_unittest.py:
2254         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2255         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2256         * WebKitTestRunner/qt/WebKitTestRunner.pro:
2257         * wx/build/settings.py:
2258
2259 2011-01-01  Adam Barth  <abarth@webkit.org>
2260
2261         Reviewed by Eric Seidel.
2262
2263         Move Sources to Source
2264         https://bugs.webkit.org/show_bug.cgi?id=51794
2265
2266         Update scripts to point to the new location.
2267
2268         * Scripts/build-webkit:
2269         * Scripts/do-file-rename:
2270         * Scripts/do-webcore-rename:
2271         * Scripts/webkitpy/common/config/build.py:
2272         * Scripts/webkitpy/common/config/build_unittest.py:
2273
2274 2010-12-31  Kent Tamura  <tkent@chromium.org>
2275
2276         Reviewed by Eric Seidel.
2277
2278         [DRT/Chromium] Enable mock spell checker on non-OSX
2279         https://bugs.webkit.org/show_bug.cgi?id=51401
2280
2281         * DumpRenderTree/chromium/WebViewHost.cpp:
2282         (WebViewHost::spellCheck):
2283
2284 2010-12-31  Adam Barth  <abarth@webkit.org>
2285
2286         Reviewed by Ariya Hidayat.
2287
2288         Remove Tools/Scripts/wkstyle
2289         https://bugs.webkit.org/show_bug.cgi?id=51774
2290
2291         This script appears to not have been touched in a while and seems to
2292         have been replaced by check-webkit-style.
2293
2294         * Scripts/wkstyle: Removed.
2295
2296 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
2297
2298         Unreviewed. Coding style fix.
2299
2300         * DumpRenderTree/chromium/TestShell.h:
2301
2302 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
2303
2304         Reviewed by Pavel Feldman.
2305
2306         Web Inspector: [Chromium] Inspector's tests are very slow on Win(Dbg).
2307
2308         It was a problem with Chromium DRT. DevToolsAgent object instance was
2309         attached not only to the inspected page but to the DevTools window too.
2310         As result all the inspector files were interpreted as a content of inspected page
2311         and were transfered to the DevTools scripts panel for debugging etc.
2312
2313         https://bugs.webkit.org/show_bug.cgi?id=51735
2314
2315         * DumpRenderTree/chromium/TestShell.cpp:
2316         (TestShell::TestShell):
2317         (TestShell::bindJSObjectsToWindow):
2318         (TestShell::createNewWindow):
2319         * DumpRenderTree/chromium/TestShell.h:
2320
2321 2010-12-31  Adam Barth  <abarth@webkit.org>
2322
2323         Rubber-stamped by Eric Seidel.
2324
2325         Move PageLoadTests to PerformanceTests/PageLoad
2326         https://bugs.webkit.org/show_bug.cgi?id=51771
2327
2328         Update references to PageLoadTests to point to the new location.
2329
2330         * Scripts/run-pageloadtest:
2331         * Scripts/webkitpy/common/config/build.py:
2332
2333 2010-12-31  Adam Barth  <abarth@webkit.org>
2334
2335         Rubber-stamped by Eric Seidel.
2336
2337         Move SunSpider into PerformanceTests
2338         https://bugs.webkit.org/show_bug.cgi?id=51769
2339
2340         Update these scripts to point to the new location.
2341
2342         * Scripts/run-sunspider:
2343         * Scripts/sunspider-compare-results:
2344
2345 2010-12-30  Mihai Parparita  <mihaip@chromium.org>
2346
2347         Reviewed by Kent Tamura.
2348
2349         [Chromium] Add WebThemeEngineDRTMac so that Chromium DRT scrollbar rendering can match the Mac port's
2350         https://bugs.webkit.org/show_bug.cgi?id=51728
2351
2352         Add implementation of the Mac WebThemeEngine that uses an NSScroller
2353         to render top-level scrollbars. This makes them match the Mac port's
2354         use of an NSScrollView, which means that we'll be able to share more
2355         pixel baselines.
2356
2357         The new rendering code will not be activated until the
2358         USE_WEB_THEME_ENGINE_TO_PAINT_THUMB #define is fliped in
2359         ScrollbarThemeChromiumMac.
2360
2361         * DumpRenderTree/DumpRenderTree.gypi:
2362         * DumpRenderTree/chromium/TestShellMac.mm:
2363         (platformInit):
2364         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Added.
2365         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Added.
2366         (+[FakeActiveWindow alwaysActiveWindow]):
2367         (+[FakeActiveWindow alwaysInactiveWindow]):
2368         (-[FakeActiveWindow initWithActiveControls:]):
2369         (-[FakeActiveWindow _hasActiveControls]):
2370         (WebThemeEngineDRTMac::paintScrollbarThumb):
2371         (stateToHIEnableState):
2372         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
2373         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
2374
2375 2010-12-30  Konstantin Tokarev  <annulen@yandex.ru>
2376
2377         Reviewed by David Kilzer.
2378
2379         [Qt] Don't build wtf/TCSystemAlloc.cpp if --system-malloc option is
2380         used
2381         https://bugs.webkit.org/show_bug.cgi?id=51672
2382
2383         * DumpRenderTree/qt/DumpRenderTree.pro: Replaced USE_SYSTEM_MALLOC
2384         with USE_SYSTEM_MALLOC=1
2385         * WebKitTestRunner/qt/WebKitTestRunner.pro: Replaced USE_SYSTEM_MALLOC
2386         with USE_SYSTEM_MALLOC=1
2387
2388 2010-12-30  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2389
2390         Reviewed by David Kilzer.
2391
2392         [Qt] [Symbian] Fix build-webkit script for Symbian
2393         https://bugs.webkit.org/show_bug.cgi?id=51509
2394
2395         Set the OUTPUT_DIR for Symbian to be the same as the source
2396         directory.
2397
2398         * Scripts/webkitdirs.pm:
2399
2400 2010-12-30  Martin Robinson  <mrobinson@igalia.com>
2401
2402         Reviewed by Darin Adler.
2403
2404         check-webkit-style should ignore NULL usage in calls to gtk_widget_style_get
2405         https://bugs.webkit.org/show_bug.cgi?id=51758
2406
2407         Add a check-webkit-style exception for gtk_widget_style_get and NULL usage.
2408
2409         * Scripts/webkitpy/style/checkers/cpp.py: Add the exception.
2410         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Add some tests for this.
2411
2412 2010-12-29  Patrick Gansterer  <paroga@webkit.org>
2413
2414         Unreviewed WinCE buildfix.
2415
2416         * WinCELauncher/main.cpp: Add missing include.
2417
2418 2010-12-29  Daniel Bates  <dbates@rim.com>
2419
2420         Reviewed by Darin Adler.
2421
2422         svn-apply updates date of wrong change log entry for a change log diff that
2423         contains two consecutive entries with the same author and date
2424         https://bugs.webkit.org/show_bug.cgi?id=46061
2425
2426         Fixes an issue where the date of the wrong change log entry may be modified.
2427         Moreover, changes fixChangeLogPatch() to move entries inserted earlier
2428         in a ChangeLog file to the top of the file.
2429
2430         Currently, fixChangeLogPatch() explicitly bails out and returns an unchanged
2431         diff when it detects that the diff inserts a change log entry earlier in a
2432         ChangeLog. It is unusual to land a patch that has such a deliberate ChangeLog
2433         change. With the advent of the commit-queue this functionality of bailing out
2434         and hence landing the patch as-is is harmful to the accuracy of the ChangeLog.
2435         Instead, we should always move the change log entry to the top of the ChangeLog file.
2436
2437         A side-effect of this change is that setChangeLogDateAndReviewer() now updates
2438         the date line of the correct change log entry in a ChangeLog diff.
2439
2440         * Scripts/VCSUtils.pm: Modified fixChangeLogPatch() to move entries inserted earlier to the top.
2441
2442         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
2443           Updated the following unit tests now that we move entries inserted earlier to the top:
2444           - "fixChangeLogPatch: New entry inserted in middle."
2445             (formerly named "fixChangeLogPatch: [no change] New entry inserted in middle.")
2446
2447           - "fixChangeLogPatch: New entry inserted earlier in the file, but after an entry with the same author and date."
2448             (formerly named "fixChangeLogPatch: [no change] New entry inserted earlier in the file, but after an entry with the same author and date.")
2449
2450         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatchThenSetChangeLogDateAndReviewer.pl: Added.
2451
2452 2010-12-29  Konstantin Tokarev  <annulen@yandex.ru>
2453
2454         Reviewed by Eric Seidel.
2455
2456         [Qt] Fixed compatibility with gold linker on X11 platforms
2457         https://bugs.webkit.org/show_bug.cgi?id=51700
2458
2459         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2460         Linked TestNetscapePlugin with libX11 on Unix platforms
2461
2462 2010-12-29  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>
2463
2464         Reviewed by Darin Adler.
2465
2466         Circular dependency in webkitpy.common.checkout.changelog module
2467         https://bugs.webkit.org/show_bug.cgi?id=50475
2468
2469         Remove automatic import of api.Checkout module when any checkout/
2470         submodule is imported (e.g.: when checkout.scm.Git is imported).
2471
2472         * Scripts/webkitpy/common/checkout/__init__.py:
2473
2474 2010-12-29  Martin Robinson  <mrobinson@igalia.com>
2475
2476         Reviewed by Ojan Vafai.
2477
2478         prepare-ChangeLog should support the -g option for specifying the git-commit
2479         https://bugs.webkit.org/show_bug.cgi?id=51708
2480
2481         Add a -g shortcut for the --git-commit prepare-ChangeLog option. This matches
2482         webkit-patch, though the exact meaning of the two options remain different.
2483
2484         * Scripts/prepare-ChangeLog: Add -g.
2485
2486 2010-12-29  Kent Hansen  <kent.hansen@nokia.com>
2487
2488         Reviewed by Simon Hausmann.
2489
2490         [Qt] Fix compilation with Qt in namespace
2491         https://bugs.webkit.org/show_bug.cgi?id=51701
2492
2493         * QtTestBrowser/webview.h:
2494
2495 2010-12-28  Daniel Bates  <dbates@rim.com>
2496
2497         Reviewed by Sam Weinig.
2498
2499         Substitute // MARK: for compiler-specific #pragma mark
2500         https://bugs.webkit.org/show_bug.cgi?id=51657
2501
2502         Fix future compilation warnings about "#pragma mark" on GTK+ bots by
2503         substituting  "// MARK:" for "#pragma mark", which provides
2504         analogous code-bookmarking functionality under Xcode.
2505
2506         Also, for consistency, we should substitute "// MARK:" for compiler-
2507         specific "#pragma mark" in the source files for the Mac port.
2508
2509         * DumpRenderTree/AccessibilityTextMarker.cpp:
2510         * DumpRenderTree/cf/WebArchiveDumpSupport.h:
2511         * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm:
2512         * DumpRenderTree/mac/ObjCController.m:
2513         * MiniBrowser/mac/AppDelegate.m:
2514         * MiniBrowser/mac/BrowserWindowController.m:
2515
2516 2010-12-28  Xan Lopez  <xlopez@igalia.com>
2517
2518         Reviewed by Eric Seidel.
2519
2520         Add --no-build option to run-sunspider
2521         https://bugs.webkit.org/show_bug.cgi?id=51658
2522
2523         * Scripts/run-sunspider: add --no-build flag to skip building
2524         phase.
2525
2526 2010-12-27  Daniel Bates  <dbates@rim.com>
2527
2528         Rubber-stamped by Martin Robinson.
2529
2530         Append the directory Tools/DumpRenderTree to the list of directories that
2531         do-webcore-rename should search so that it can rename DRT files and
2532         source code.
2533
2534         * Scripts/do-webcore-rename:
2535
2536 2010-12-27  Eric Seidel  <eric@webkit.org>
2537
2538         Reviewed by Adam Barth.
2539
2540         build-webkit should detect missing Java SDK and explain how to install it
2541         https://bugs.webkit.org/show_bug.cgi?id=51651
2542
2543         * Scripts/build-webkit:
2544
2545 2010-12-26  Martin Robinson  <mrobinson@igalia.com>
2546
2547         Reviewed by Daniel Bates.
2548
2549         [GTK] Add support for build-jsc
2550         https://bugs.webkit.org/show_bug.cgi?id=51625
2551
2552         Add GTK+ support to build-jsc now that building the jsc executable as
2553         a standalone target is easy.
2554
2555         * Scripts/build-jsc: Call buildGtkProject for the GTK+ case now.
2556         * Scripts/build-webkit: Pass in the proper target name to buildGtkProject.
2557         * Scripts/webkitdirs.pm: Actually process the project parameter in buildGtkProject
2558         and pass it along to buildAutotoolsProject.
2559
2560 2010-12-27  David Levin  <levin@chromium.org>
2561
2562         Reviewed by Eric Seidel.
2563
2564         check-webkit-style check for meaningless variable names in function declarations.
2565         https://bugs.webkit.org/show_bug.cgi?id=51523
2566
2567         * Scripts/webkitpy/style/checker.py: Exempted JavaScriptCore/jit/JITStubs.cpp
2568         from the new check and whitespace/parens because the syntax is unusual and
2569         produced a fair number of positives for these checks.
2570         * Scripts/webkitpy/style/checkers/cpp.py:
2571         (_convert_to_lower_with_underscores): Used as a canonical form for type names
2572         and parameter names when determining if the parameter name is useless.
2573         (_create_acronym): Used to check for redundant variable names in cases like "ExceptionCode ec"
2574         (Parameter.lower_with_underscores_name): Gives back the parameter name in a lower_with_underscore
2575         format.
2576         (_check_parameter_name_against_text):  Checks to see if the parameter name is in the
2577         text or an acronym of it.
2578         (check_function_definition): Checks function definitions for meaningless variable names.
2579         (process_line): Added call to check_function_definition.
2580         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2581         (CppFunctionsTest.test_convert_to_lower_with_underscores): Test for _convert_to_lower_with_underscores.
2582         (CppFunctionsTest.test_create_acronym): Test for _create_acronym.
2583         (CppFunctionsTest.test_check_parameter_against_text): Test for _check_parameter_against_text.
2584         (CppStyleTestBase.perform_single_line_lint): Removed the parameter name check
2585         because when only checking a snippet, there are a lot of bogus functions.
2586         (CppStyleTestBase.perform_multi_line_lint): Ditto and removed a bogus filter
2587         that I put there previously and just noticed.
2588         (WebKitStyleTest.test_parameter_names): Tests for the functionality -- both
2589         check_function_definition and process_line.
2590
2591 2010-12-27  Carlos Garcia Campos  <cgarcia@igalia.com>
2592
2593         Reviewed by Martin Robinson.
2594
2595         [GTK] Disable flash plugin in GtkLauncher when using gtk3
2596         https://bugs.webkit.org/show_bug.cgi?id=51591
2597
2598         Flash plugin uses gtk2 that is incompatible with gtk3 making
2599         webkit crash when it's built with gtk3.
2600
2601         * GtkLauncher/main.c:
2602         (main):
2603
2604 2010-12-25  Adam Barth  <abarth@webkit.org>
2605
2606         Reviewed by Eric Seidel.
2607
2608         Move ANGLE to Sources/ThirdParty
2609         https://bugs.webkit.org/show_bug.cgi?id=51605
2610
2611         * Scripts/build-webkit:
2612           - Point to the new ANGLE location.
2613
2614 2010-12-26  David Levin  <levin@chromium.org>
2615
2616         Reviewed by Eric Seidel.
2617
2618         check-webkit-style should be able to parse function declaration parameters.
2619         https://bugs.webkit.org/show_bug.cgi?id=51451
2620
2621         * Scripts/webkitpy/style/checkers/cpp.py:
2622         (Position.__init__): Holds simple position information (row, column).
2623         (Parameter.__init__): Holds information about a parameter.
2624         (SingleLineView.__init): Converts multiple lines into a single line for simpler searches.
2625         (SingleLineView.convert_column_to_row): Returns the original row given a column.
2626         (create_skeleton_parameters): Simplifies a parameter list for easier searching.
2627         (find_parameter_name_index): Finds where the parameter name is.
2628         (parameter_list): Generates the list of parameters for a function.
2629         (_FunctionState.begin): Added information to allow determining the parameters
2630         on demand.
2631         (_FunctionState.get_parameter_list): Returns a tuple of function parameters.
2632         (detect_functions): Improve function detection for operator functions and
2633         determine where the parameters end and pass that to _FunctionState.begin.
2634         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2635         (CppFunctionsTest.test_parameter): Verifies Parameter functionality.
2636         (CppFunctionsTest.test_single_line_view): Verifies SingleLineView functionality.
2637         (CppFunctionsTest.test_create_skeleton_parameters): Verifies create_skeleton_parameters.
2638         (CppFunctionsTest.test_find_parameter_name_index): Verifies find_parameter_name_index.
2639         (CppFunctionsTest.test_parameter_list): Does some minimal verification for parameter list.
2640         Much more thorough verification is done as part of FunctionDetectionTest.test_parameter_list.
2641         (FunctionDetectionTest.perform_function_detection): Added support for verifying
2642         the parameters found.
2643         (FunctionDetectionTest.test_function_declaration_detection): Added more function
2644         detection test to verify that we catch the operator functions.
2645         (FunctionDetectionTest.test_ignore_macros): Verify that function detection ignores macros.
2646         (FunctionDetectionTest.test_parameter_list): Added tests to verify the parameter parsing.
2647         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_bad_test_doesnt_break): Removed
2648         because the error. The test is about the bad function name. Fixing the name makes the test exactly like
2649         test_function_length_check_definition_severity1_for_test.
2650
2651 2010-12-25  Patrick Gansterer  <paroga@webkit.org>
2652
2653         Unreviewed WinCE buildfix after r74334.
2654
2655         * CMakeListsWinCE.txt:
2656
2657 2010-12-24  Sheriff Bot  <webkit.review.bot@gmail.com>
2658
2659         Unreviewed, rolling out r74632.
2660         http://trac.webkit.org/changeset/74632
2661         https://bugs.webkit.org/show_bug.cgi?id=51600
2662
2663         makes test-webkitpy hang forever on GTK (Requested by philn-tp
2664         on #webkit).
2665
2666         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
2667         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
2668
2669 2010-12-24  Ryuan Choi  <ryuan.choi@samsung.com>
2670
2671         Reviewed by Kenneth Rohde Christiansen.
2672
2673         [EFL] Screen doesn't be rendered when changing size of EWebLauncher
2674         https://bugs.webkit.org/show_bug.cgi?id=43528
2675
2676         Remove on_resize because ewk_view_fixed_layout_size_set should not be
2677         called on callback of EVAS_CALLBACK_RESIZE. As it change size of
2678         FrameView, rendering was ignored when _ewk_view_smart_calculate was
2679         called.
2680
2681         * EWebLauncher/main.c:
2682         (browserCreate):
2683
2684 2010-12-24  Eric Seidel  <eric@webkit.org>
2685
2686         Reviewed by Adam Barth.
2687
2688         webkit-patch (or a pre-commit hook) needs to prevent bad ChangeLog changes
2689         https://bugs.webkit.org/show_bug.cgi?id=28291
2690
2691         This is a start.  At least now webkit-patch will prompt when your ChangeLog looks questionable.
2692         We could do more advanced things, like parsing the ChangeLog (with changelog.py) and comparing that
2693         to strings with find in the diff.
2694         Since non-interactive always returns the default, this should cause patches with bad changelogs to fail on the commit-queue.
2695
2696         * Scripts/webkitpy/common/checkout/api.py:
2697         * Scripts/webkitpy/common/checkout/diff_parser.py:
2698         * Scripts/webkitpy/tool/steps/abstractstep.py:
2699         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
2700         * Scripts/webkitpy/tool/steps/validatechangelogs.py: Copied from Tools/Scripts/webkitpy/tool/steps/validatereviewer.py.
2701         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py: Copied from Tools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.
2702         * Scripts/webkitpy/tool/steps/validatereviewer.py:
2703
2704 2010-12-24  Dirk Pranke  <dpranke@chromium.org>
2705
2706         Reviewed by Kenneth Russell.
2707
2708         Modify new-run-webkit-tests to shut up and exit when all the threads
2709         are wedged so that test runs complete faster and we don't end up
2710         w/ enormous log files.
2711
2712         https://bugs.webkit.org/show_bug.cgi?id=51572
2713
2714         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
2715         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
2716
2717 2010-12-24  Eric Seidel  <eric@webkit.org>
2718
2719         Reviewed by David Levin.
2720
2721         commit-queue should better explain how it will re-open bugs and follow duplicate chains
2722         https://bugs.webkit.org/show_bug.cgi?id=51549
2723
2724         I've had multiple people ask me about the commit-queue's behavior
2725         regarding reporting flaky tests.  I figured it would be best to just
2726         have the queue explain itself in the bugs it files.
2727
2728         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2729         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2730
2731 2010-12-24  Shinichiro Hamaji  <hamaji@chromium.org>
2732
2733         Reviewed by Eric Seidel.
2734
2735         check-webkit-style: should ignore "wrong" namings in JavaScriptCore/qt
2736         https://bugs.webkit.org/show_bug.cgi?id=51467
2737
2738         * Scripts/webkitpy/style/checker.py:
2739         * Scripts/webkitpy/style/checker_unittest.py:
2740
2741 2010-12-23  Adam Barth  <abarth@webkit.org>
2742
2743         Rubber-stamped by Eric Seidel.
2744
2745         Move JavaScriptGlue into Sources
2746         https://bugs.webkit.org/show_bug.cgi?id=51583
2747
2748         These tools refer to JavaScriptGlue and need to be updated to its new
2749         location.
2750
2751         * Scripts/build-webkit:
2752         * Scripts/do-file-rename:
2753         * Scripts/do-webcore-rename:
2754         * Scripts/webkitpy/common/config/build.py:
2755         * Scripts/webkitpy/common/config/build_unittest.py:
2756
2757 2010-12-23  Lucas Forschler  <lforschler@apple.com>
2758
2759         Reviewed by Eric Seidel.
2760
2761         Bug 51539 - update iexploder scripts to point to new location
2762
2763         * Scripts/run-iexploder-tests:
2764         * Scripts/update-iexploder-cssproperties:
2765
2766 2010-12-23  Evan Martin  <evan@chromium.org>
2767
2768         Reviewed by Ryosuke Niwa.
2769
2770         [chromium] LayoutTestController warning in float->int conversion
2771         https://bugs.webkit.org/show_bug.cgi?id=51553
2772
2773         Rather than reading an int, converting to a float, then getting a compiler
2774         warning on passing the float to something that expects an int, instead
2775         just pass around ints.
2776
2777         No tests, fixes a compiler warning.
2778
2779         * DumpRenderTree/chromium/LayoutTestController.cpp:
2780         (parsePageSizeParameters):
2781         (LayoutTestController::pageNumberForElementById):
2782         (LayoutTestController::numberOfPages):
2783
2784 2010-12-23  Lucas Forschler  <lforschler@apple.com>
2785
2786         Reviewed by Darin Adler.
2787
2788         Bug 51537 - iexploder needs cleanup
2789
2790         * iExploder/htdocs: Removed.
2791         * iExploder/htdocs/config.rb: Removed.
2792         * iExploder/htdocs/cssproperties.in: Removed.
2793         * iExploder/htdocs/cssvalues.in: Removed.
2794         * iExploder/htdocs/htmlattrs.in: Removed.
2795         * iExploder/htdocs/htmltags.in: Removed.
2796         * iExploder/htdocs/htmlvalues.in: Removed.
2797         * iExploder/htdocs/iexploder.cgi: Removed.
2798         * iExploder/htdocs/iexploder.rb: Removed.
2799         * iExploder/htdocs/index.html: Removed.
2800         * iExploder/htdocs/webserver.rb: Removed.
2801         * iExploder/iexploder-1.7.2/output: Removed.
2802         * iExploder/tools: Removed.
2803         * iExploder/tools/lasthit.rb: Removed.
2804         * iExploder/tools/osx_last_crash.rb: Removed.
2805         * iExploder/tools/showtest.rb: Removed.
2806
2807 2010-12-23  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
2808
2809         Reviewed by Kenneth Rohde Christiansen.
2810
2811         [EFL] Make 'single' the default backing store in EWebLauncher
2812         https://bugs.webkit.org/show_bug.cgi?id=51534
2813
2814         'single' is the simplest backing store and the one intended to be the
2815         default in the test browser. By mistake the tiled backing store was
2816         left as default in r72617.
2817
2818         * EWebLauncher/main.c:
2819         (browserCreate): ditto.
2820
2821 2010-12-23  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
2822
2823         Reviewed by Kenneth Rohde Christiansen.
2824
2825         [EFL] Subject: [webkit 4/4] [EFL] Remove non-sense workaround
2826         https://bugs.webkit.org/show_bug.cgi?id=51533
2827
2828         There's no point in concatenating env("HOME") with "blah", so remove
2829         option from EWebLauncher.
2830
2831         * EWebLauncher/main.c:
2832         (main): ditto.
2833
2834 2010-12-23  Ilya Tikhonovsky  <loislo@chromium.org>
2835
2836         Reviewed by Eric Seidel.
2837
2838         Web Inspector: chromium: inspector's tests are quite slow especially at windows(Debug).
2839
2840         Almost all inspector's tests become flaky on chromium Win(dbg) after switching to DRT.
2841         I just discovered that we have two additional GC runs per each WebViewHost.
2842         Test_shell had no such calls.
2843         These gc runs eat 15% of cpu time.
2844
2845         https://bugs.webkit.org/show_bug.cgi?id=51479
2846
2847         * DumpRenderTree/chromium/WebViewHost.cpp:
2848         (WebViewHost::~WebViewHost):
2849
2850 2010-12-22  Dirk Pranke  <dpranke@chromium.org>
2851
2852         Reviewed by Ojan Vafai.
2853
2854         This change splits out the TestRunner class into its own file.
2855         When we fork the code for message passing, we will create a new
2856         TestRunner, and this change will allow that to be more modular.
2857
2858         While we're at it, split out TestInput and ResultSummary into
2859         their own files, to reduce the size of run_webkit_tests to
2860         something more managable.
2861
2862         https://bugs.webkit.org/show_bug.cgi?id=51092
2863
2864         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2865         * Scripts/webkitpy/layout_tests/layout_package/result_summary.py:
2866         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2867         * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
2868         * Scripts/webkitpy/layout_tests/layout_package/test_input.py:
2869         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2870         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2871
2872  2010-12-22  Dirk Pranke  <dpranke@chromium.org>
2873
2874         Reviewed by Ojan Vafai.
2875
2876         nrwt multiprocessing - start over, prepare to fork the code
2877
2878         This code cleans up the signatures and implementation of the
2879         TestRunner class so we can easily fork it to run either the
2880         stable implementation or the new, unstable message-passing
2881         implementation. The two variants will have different
2882         implementations of the run_tests() method. We will switch
2883         between the two based on the setting for the '--worker-model'
2884         switch. We rename the two currently valid values to 'old-inline'
2885         and 'old-threads'.
2886
2887         https://bugs.webkit.org/show_bug.cgi?id=51081
2888
2889         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2890         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2891
2892 2010-12-22  Victor Wang  <victorw@chromium.org>
2893
2894         Reviewed by Darin Fisher.
2895
2896         [Chromium] Update chromium archive test result url in rebaseline script.
2897
2898         https://bugs.webkit.org/show_bug.cgi?id=51503
2899
2900         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2901
2902 2010-12-22  Lucas Forschler  <lforschler@apple.com>
2903
2904         Reviewed by Alice Liu.
2905
2906         <rdar://problem/8633222> record-memory-win needs to record memory used by the webprocess.
2907         Verified on Chrome, Safari, and IE.
2908         With this change, we will record memory from a parent browser window and all child processes.
2909
2910         * record-memory-win/main.cpp:
2911         (ProcessArgs):
2912         (PrintUsage):
2913         (getMemoryInfo):
2914         (printProcessInfo):
2915         (evalProcesses):
2916         (UseImage):
2917         (QueryContinuously):
2918         (ElapsedTime):
2919
2920 2010-12-22  Lucas Forschler  <lforschler@apple.com>
2921
2922         Unreviewed rollout r74489, because it was missing changelog.
2923
2924         * record-memory-win/main.cpp:
2925
2926 2010-12-22  Ryosuke Niwa  <rniwa@webkit.org>
2927
2928         Adding myself as a reviewer.
2929
2930         * Scripts/webkitpy/common/config/committers.py:
2931
2932 2010-12-22  Andrew Scherkus  <scherkus@chromium.org>
2933
2934         Unreviewed.  Adding myself to committers.py.
2935
2936         * Scripts/webkitpy/common/config/committers.py:
2937
2938 2010-12-22  Ariya Hidayat  <ariya@sencha.com>
2939
2940         Reviewed by Kenneth Rohde Christiansen.
2941
2942         TestNetscapePlugIn should use #if defined
2943         https://bugs.webkit.org/show_bug.cgi?id=51471
2944
2945         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2946         (NP_Initialize):
2947         (NPP_New):
2948
2949 2010-12-22  Ilya Tikhonovsky  <loislo@chromium.org>
2950
2951         Reviewed by Yury Semikhatsky.
2952
2953         Web Inspector: [chromium] DRT inspector layout tests are flaky in debug.
2954
2955         DevTools window should be closed explicitly because it has custom deinitialization code.
2956
2957         https://bugs.webkit.org/show_bug.cgi?id=50722
2958
2959         * DumpRenderTree/chromium/TestShell.cpp:
2960         (TestShell::closeRemainingWindows):
2961
2962 2010-12-22  David Levin  <levin@chromium.org>
2963
2964         Reviewed by Shinichiro Hamaji.
2965
2966         check-webkit-style shouldn't complaint about underscores in variables in objective C files.
2967         https://bugs.webkit.org/show_bug.cgi?id=51452
2968
2969         * Scripts/webkitpy/style/checkers/cpp.py:
2970         (_FileState.__init__): Added the information to determine if a file is C or Objective C.
2971         Using the file extension if possible but falling back to the file contents if we have a header file.
2972         (_FileState.is_objective_c): Determine if we have an Objective C by examining the file contents if needed.
2973         (_FileState.is_c_or_objective_c):
2974         (check_using_std): Changed to using _FileState to determine the file type.
2975         (check_max_min_macros): Ditto.
2976         (check_for_null): Ditto.
2977         (check_style): Changed the parameters to various calls since they now need _FileState
2978         to determine the file type.
2979         (check_language): Added the file_state parameter so it could be passed
2980         to check_identifier_name_in_declaration.
2981         (check_identifier_name_in_declaration): Don't warn about underscores in variables if
2982         this is an Objective C file.
2983         (_process_lines): Added information for the _FileState constructor (and moved the
2984         call to a place that had the information).
2985         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2986         (CppFunctionsTest.test_is_c_or_objective_c): Changed the tests to use FileState and exercise
2987         its functionality.
2988         (WebKitStyleTest.test_names): Add tests for underscores in Objective C files.
2989
2990 2010-12-21  Andy Estes  <aestes@apple.com>
2991
2992         Reviewed by Mark Rowe.
2993
2994         Do not build non-Intel architectures for WebKit2-related projects.
2995         https://bugs.webkit.org/show_bug.cgi?id=51440
2996
2997         * MiniBrowser/Configurations/Base.xcconfig: Only build for i386 and x86_64.
2998         * TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
2999         * WebKitTestRunner/Configurations/Base.xcconfig: Ditto.
3000
3001 2010-12-21  Mihai Parparita  <mihaip@chromium.org>
3002
3003         Reviewed by Darin Fisher.
3004
3005         [Chromium] Rename WebThemeEngine/ControlDRT to WebThemeEngine/ControlDRTWin
3006         https://bugs.webkit.org/show_bug.cgi?id=51406
3007
3008         Rename WebThemeControlDRT to WebThemeControlDRTWin and WebThemeEngineDRT
3009         to WebThemeEngineDRTWin and update references everywhere.
3010
3011         * DumpRenderTree/DumpRenderTree.gypi:
3012         * DumpRenderTree/chromium/TestShellWin.cpp:
3013         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRT.cpp.
3014         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRT.h.
3015         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRT.cpp.
3016         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRT.h.
3017
3018 2010-12-21  Anders Carlsson  <andersca@apple.com>
3019
3020         Reviewed by John Sullivan.
3021
3022         Clicking missing plug-in text does not show a sheet
3023         https://bugs.webkit.org/show_bug.cgi?id=51403
3024
3025         Update for changes to the WebPageUIClient.
3026
3027         * MiniBrowser/mac/BrowserWindowController.m:
3028         (-[BrowserWindowController awakeFromNib]):
3029         * WebKitTestRunner/TestController.cpp:
3030         (WTR::createOtherPage):
3031         (WTR::TestController::initialize):
3032
3033 2010-12-21  Eric Seidel  <eric@webkit.org>
3034
3035         Reviewed by Adam Barth.
3036
3037         commit-queue will report constant failures as flaky if other tests flake
3038         https://bugs.webkit.org/show_bug.cgi?id=51272
3039
3040         This patch just removes functionality and adds testing.
3041         Previously we attempted to report flaky tests when we had
3042         two different tests fail in a row.  However, since we stop
3043         running the tests at the first failure, our code was wrong in
3044         trying to determine flakiness from the incomplete runs.
3045
3046         Originally I posted an alternate patch:
3047         https://bug-51272-attachments.webkit.org/attachment.cgi?id=77078
3048         which fixed our flaky logic in this case, however it was decided
3049         that that patch would be too difficult to maintain, so now
3050         I'm just removing the broken logic.
3051
3052         This will dramatically cut-down on our flaky-test false positives
3053         at the (small) cost of the queues being unable to report
3054         any flakiness if the tree is very flaky.  (With at least one test
3055         flaking on every run, we'll never report failures anymore.)  I think
3056         this is a tradeoff worth making.
3057
3058         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3059         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3060
3061 2010-12-20  Eric Seidel  <eric@webkit.org>
3062
3063         Reviewed by Adam Barth.
3064
3065         commit-queue wrongly rejects patches when it can't update itself
3066         https://bugs.webkit.org/show_bug.cgi?id=46636
3067
3068         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3069         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3070         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3071
3072 2010-12-20  Adam Barth  <abarth@webkit.org>
3073
3074         Move web sites to Websites directory
3075         https://bugs.webkit.org/show_bug.cgi?id=51323
3076
3077         Update references to BugsSite to point to the new location.
3078
3079         This patch was never officially reviewed (because it was too large to
3080         upload to bugs.webkit.org), but it was discussed on webkit-dev and Mark
3081         Rowe gave me the green light.
3082
3083         * Scripts/old-run-webkit-tests:
3084         * Scripts/webkitpy/common/config/build.py:
3085         * Scripts/webkitpy/common/config/build_unittest.py:
3086         * Scripts/webkitpy/common/prettypatch.py:
3087         * Scripts/webkitpy/layout_tests/port/base.py:
3088         * Scripts/webkitpy/style/main.py:
3089
3090 2010-12-20  Adrienne Walker  <enne@google.com>
3091
3092         Unreviewed. Adding myself to the list of committers.
3093
3094         * webkitpy/common/config/committers.py:
3095
3096 2010-12-20  Mark Rowe  <mrowe@apple.com>
3097
3098         Reviewed by Dan Bernstein.
3099
3100         <rdar://problem/8757601> Don't install header files in to the Resources directory.
3101
3102         * Scripts/check-for-inappropriate-files-in-framework: Don't allow .h files in the
3103         Resources directory.
3104
3105 2010-12-20  Eric Seidel  <eric@webkit.org>
3106
3107         Reviewed by Adam Barth.
3108
3109         commit-queue should include bot id when attaching failure diffs
3110         https://bugs.webkit.org/show_bug.cgi?id=51280
3111
3112         This is a tiny change to include the bot id in the name of the attachment.
3113         Most of this diff is just changing the unit test expectations
3114         now that I hid the comment printing when the comment is None.
3115
3116         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3117         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3118         * Scripts/webkitpy/tool/commands/upload_unittest.py:
3119         * Scripts/webkitpy/tool/mocktool.py:
3120
3121 2010-12-20  Jeff Miller  <jeffm@apple.com>
3122
3123         Reviewed by Dan Bernstein.
3124
3125         Tools/vcbin/midl.exe needs to be rebuilt
3126         https://bugs.webkit.org/show_bug.cgi?id=51347
3127
3128         * vcbin/midl.exe: Rebuilt.
3129
3130 2010-12-20  David Levin  <levin@chromium.org>
3131
3132         Reviewed by Ariya Hidayat.
3133
3134         .gitignore and webkit-tools-completion.sh have references to WebKitTools that should be Tools.
3135         https://bugs.webkit.org/show_bug.cgi?id=51343
3136
3137         Follow up from the WebKitTools -> Tools rename.
3138
3139         * Scripts/webkit-tools-completion.sh:
3140
3141 2010-12-20  Cosmin Truta  <ctruta@chromium.org>
3142
3143         Reviewed by James Robinson.
3144
3145         new-run-webkit-tests ignores trailing EOL differences in text tests
3146         https://bugs.webkit.org/show_bug.cgi?id=36983
3147
3148         Changed the handling of new-line characters within new-run-webkit-tests
3149         to match old-run-webkit-tests.  Differences in leading and trailing empty
3150         lines in text expectation files are no longer ignored.
3151
3152         * Scripts/webkitpy/layout_tests/port/base.py:
3153         * Scripts/webkitpy/layout_tests/port/test.py:
3154         Added unit tests.  Removed old duplicate unit test entries.
3155         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
3156
3157 2010-12-20  David Levin  <levin@chromium.org>
3158
3159         Reviewed by Shinichiro Hamaji.
3160
3161         check-webkit-style should detect function declarations (and trivial functions).
3162         https://bugs.webkit.org/show_bug.cgi?id=51303
3163
3164         * Scripts/webkitpy/style/checkers/cpp.py:
3165         (_FunctionState.begin): Add is_declaration and changed the line count
3166         start to begin at -1 (which will keep the results consistent, since
3167         the starting line number passed in is one less in this change).
3168         (detect_functions): changed function detection to now catch trivial
3169         functions and declarations.
3170         (check_pass_ptr_usage): Don't check for Pass*Ptr on the first line
3171         of the function as this may look at return values (when processing
3172         a declaration).
3173         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3174         (FunctionDetectionTest.perform_function_detection): Basic mechanics
3175         of testing the function detection.
3176         (FunctionDetectionTest.test_basic_function_detection): Test a simple
3177         function.
3178         (FunctionDetectionTest.test_function_declaration_detection): Test a
3179         declaration.
3180         (FunctionDetectionTest.test_non_functions): A test case for a case
3181         that caused the code to fail due to the { being in quotes.
3182         (PassPtrTest.test_pass_ref_ptr_return_value): Added some more test
3183         cases to help catch false alarms for return values.
3184         (PassPtrTest.test_pass_ref_ptr_member_variable): Ensure that
3185         we don't get false alarms for member variables either.
3186
3187 2010-12-20  Ryuan Choi  <ryuan.choi@samsung.com>
3188
3189         Reviewed by Antonio Gomes.
3190
3191         [CMAKE] Rename WEBKITTOOLS_DIR to TOOLS_DIR
3192         https://bugs.webkit.org/show_bug.cgi?id=51319
3193
3194         * CMakeListsEfl.txt:
3195
3196 2010-12-18  Adam Barth  <abarth@webkit.org>
3197
3198         Reviewed by Sam Weinig.
3199
3200         Move WebKitExamplePlugins to Examples
3201         https://bugs.webkit.org/show_bug.cgi?id=51291
3202
3203         * Scripts/webkitpy/common/config/build.py:
3204
3205 2010-12-17  Csaba Osztrogonác  <ossy@webkit.org>
3206
3207         Unreviewed Qt buildfix after r74301.
3208
3209         Rename WebKitTools to Tools
3210         https://bugs.webkit.org/show_bug.cgi?id=49861
3211
3212         * MiniBrowser/DerivedSources.pro:
3213         * MiniBrowser/qt/MiniBrowser.pro:
3214
3215 2010-12-17  Dan Bernstein  <mitz@apple.com>
3216
3217         Reviewed by Simon Fraser.
3218
3219         Rename WebKitTools to Tools
3220         https://bugs.webkit.org/show_bug.cgi?id=49861
3221
3222         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3223         * CodeCoverage/README:
3224         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3225         (WebCore::DumpRenderTree::initializeFonts):
3226         * EWSTools/start-commit-queue.sh:
3227         * EWSTools/start-queue.sh:
3228         * GNUmakefile.am:
3229         * MIDLWrapper/MIDLWrapper.cpp:
3230         (wmain):
3231         * MiniBrowser/qt/MiniBrowser.pro:
3232         * Scripts/build-api-tests:
3233         * Scripts/build-dumprendertree:
3234         * Scripts/build-webkit:
3235         * Scripts/build-webkittestrunner:
3236         * Scripts/generate-coverage-data:
3237         * Scripts/old-run-webkit-tests:
3238         * Scripts/run-api-tests:
3239         * Scripts/run-iexploder-tests:
3240         * Scripts/run-javascriptcore-tests:
3241         * Scripts/run-mangleme-tests:
3242         * Scripts/run-sunspider:
3243         * Scripts/run-webkit-websocketserver:
3244         * Scripts/sunspider-compare-results:
3245         * Scripts/test-webkitperl:
3246         * Scripts/test-webkitpy:
3247         * Scripts/update-iexploder-cssproperties:
3248         * Scripts/update-webkit:
3249         * Scripts/update-webkit-localizable-strings:
3250         * Scripts/webkitdirs.pm:
3251         * Scripts/webkitpy/common/checkout/scm.py:
3252         * Scripts/webkitpy/common/checkout/scm_unittest.py:
3253         * Scripts/webkitpy/common/config/committervalidator.py:
3254         * Scripts/webkitpy/common/config/committervalidator_unittest.py:
3255         * Scripts/webkitpy/common/config/ports.py:
3256         * Scripts/webkitpy/common/config/ports_unittest.py:
3257         * Scripts/webkitpy/common/system/logutils_unittest.py:
3258         * Scripts/webkitpy/common/system/ospath_unittest.py:
3259         * Scripts/webkitpy/layout_tests/port/chromium.py:
3260         * Scripts/webkitpy/layout_tests/port/config.py:
3261         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
3262         * Scripts/webkitpy/layout_tests/port/http_server.py:
3263         * Scripts/webkitpy/layout_tests/port/test.py:
3264         * Scripts/webkitpy/style/checker.py:
3265         * Scripts/webkitpy/style/checker_unittest.py:
3266         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
3267         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3268         * Scripts/webkitpy/tool/steps/steps_unittest.py:
3269         * WebKitTestRunner/DerivedSources.pro:
3270         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
3271         (WTR::activateFonts):
3272         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3273         * wx/build/build_utils.py:
3274
3275 2010-12-16  Antonio Gomes  <agomes@rim.com>
3276
3277         Reviewed by Martin Robinson.
3278
3279         Settings::editingBehaviorType() incorrectly returns mac for the gtk build when running tests
3280         https://bugs.webkit.org/show_bug.cgi?id=51163
3281
3282         Since GTK+'s default editing behavior was changed to UNIX in r70975 (see webkitwebsettings.cpp),
3283         GTK+'s DRT should also reset to UNIX after each test execution.
3284
3285         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3286         (resetDefaultsToConsistentValues):
3287
3288 2010-12-17  David Levin  <levin@chromium.org>
3289
3290         Reviewed by Eric Seidel.
3291
3292         check-webkit-style should understand WTF #include guards
3293         https://bugs.webkit.org/show_bug.cgi?id=44911
3294
3295         * Scripts/webkitpy/style/checkers/cpp.py:
3296         (get_header_guard_cpp_variable): modify to suggest the WTF style
3297         of header guard when appropriate.
3298         (check_for_header_guard): handle multiple return values from
3299         get_header_guard_cpp_variable
3300         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3301         (CppStyleTest.test_build_header_guard): Added tests for the WTF
3302         header style.
3303
3304 2010-12-16  David Levin  <levin@chromium.org>
3305
3306         Reviewed by Eric Seidel.
3307
3308         test-webkitpy: unittest for the xml.py checker displays a decprecation warning.
3309         https://bugs.webkit.org/show_bug.cgi?id=51210
3310
3311         The error only shows up when using python 2.6 or later.
3312
3313         * Scripts/webkitpy/style/checkers/xml.py: Replace the usage of
3314         the decprecated field error,message with something equivalent.
3315
3316 2010-12-16  Mihai Parparita  <mihaip@chromium.org>
3317
3318         Reviewed by Eric Seidel.
3319
3320         Add --exit-after-n-failures/crashes to NRWT
3321         https://bugs.webkit.org/show_bug.cgi?id=51160
3322
3323         Abort test run (in a similar way to how control-C is handled) when
3324         --exit-after-n-failures/crashes-or-timeouts are passed and we've reached
3325         that number of unexpected failures/crashes/timeouts.
3326
3327         * Scripts/webkitpy/layout_tests/port/test.py:
3328         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3329         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3330
3331 2010-12-16  David Levin  <levin@chromium.org>
3332
3333         Reviewed by Shinichiro Hamaji.
3334
3335         check-webkit-style unit tests has some duplicate boilerplate code.
3336         https://bugs.webkit.org/show_bug.cgi?id=49519
3337
3338         * Scripts/webkitpy/style/checkers/cpp.py:
3339         (update_include_state): Replaced the "io" parameter with the global
3340         configuration _unit_test_config. This allowed not calling into
3341         functions at a low level and also not plumbing through the injection
3342         information through many levels of code.
3343         (check_for_include_what_you_use): Ditto.
3344         (process_file_data): Added the ability to set up the unit test config
3345         to allow for injection.
3346         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3347         (ErrorCollector.__init__): Added support for having a filter for errors.
3348         (ErrorCollector.__call__): Ditto.
3349         (CppStyleTestBase.process_file_data): Added the ability to set unit_test_config.
3350         (CppStyleTestBase.perform_lint): Consolidated logic for the perform functions.
3351         (CppStyleTestBase.perform_single_line_lint): Replace specific calls to
3352         functions in the cpp.py with generic processing and a filter that
3353         indicates what errors should be kept.
3354         (CppStyleTestBase.perform_multi_line_lint): Ditto.
3355         (CppStyleTestBase.perform_language_rules_check): Ditto.
3356         (CppStyleTestBase.perform_function_lengths_check): Ditto.
3357         (CppStyleTestBase.perform_pass_ptr_check): Ditto.
3358         (CppStyleTestBase.perform_include_what_you_use): Ditto.
3359         (CppStyleTest.test_multi_line_comments): Added another
3360         error message which applies to the test case.
3361         (CppStyleTest.test_spacing_for_binary_ops): Fixed test
3362         to not have config.h, since it is processed as a header file.
3363         (CppStyleTest.test_static_or_global_stlstrings): Fixed variable name
3364         style and indentation in checked code.
3365         (OrderOfIncludesTest.test_check_preprocessor_in_include_section):
3366         Fixed line number.
3367         (NoNonVirtualDestructorsTest.test_multi_line_declaration_with_error):
3368         Ditto.
3369
3370 2010-12-15  Sheriff Bot  <webkit.review.bot@gmail.com>
3371
3372         Unreviewed, rolling out r74136.
3373         http://trac.webkit.org/changeset/74136
3374         https://bugs.webkit.org/show_bug.cgi?id=51135
3375
3376         r74136 breaks chromium canary bots because some tests are not
3377         rebaselined correctly to resolve EOL differences (Requested by
3378         jianli on #webkit).
3379
3380         * Scripts/webkitpy/layout_tests/port/base.py:
3381         * Scripts/webkitpy/layout_tests/port/test.py:
3382         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
3383
3384 2010-12-15  Adam Roben  <aroben@apple.com>
3385
3386         Teach check-webkit-style to check .vcproj and .vsprops files for XML
3387         syntax errors
3388
3389         Fixes <http://webkit.org/b/51103> check-webkit-style should check for
3390         XML syntax errors in .vcproj/.vsprops files
3391
3392         Reviewed by Dave Levin.
3393
3394         * Scripts/webkitpy/style/checker.py: Added lists of file extensions
3395         that should be treated as XML and that should be allowed to contain
3396         carriage returns. (These lists happen to be identical currently.)
3397         (FileType): Added a new XML type.
3398         (CheckerDispatcher.should_check_and_strip_carriage_returns): Added.
3399         Just does a simple file extension check.
3400         (CheckerDispatcher._file_type): Added a case for XML files.
3401         (CheckerDispatcher._create_checker): Ditto. We use XMLChecker for XML
3402         files (surprise!).
3403         (StyleProcessor.process): Ask the dispatcher whether we should pass the
3404         lines through the carriage checker.
3405
3406         * Scripts/webkitpy/style/checker_unittest.py:
3407         (CheckerDispatcherCarriageReturnTest.test_should_check_and_strip_carriage_returns):
3408         Added. Checks a few file names to see if carriage returns are allowed
3409         or not.
3410         (CheckerDispatcherDispatchTest.assert_checker_xml): Added. Similar to
3411         other assert_checker_* functions.
3412         (CheckerDispatcherDispatchTest.test_xml_paths): Added. Similar to other
3413         test_*_paths functions.
3414         (CheckerDispatcherDispatchTest.test_xml_paths): Added. Similar to other
3415         test_*_paths functions.
3416         (CheckerDispatcherDispatchTest.test_none_paths): Removed the vcproj
3417         file from this test case, as vcproj files now have a type.
3418         (StyleProcessor_CodeCoverageTest.MockDispatcher.should_check_and_strip_carriage_returns):
3419         Added. Similar to the other should_* functions.
3420         (StyleProcessor_CodeCoverageTest.test_process__carriage_returns_not_stripped):
3421         Added. Checks that carriage returns aren't checked for or stripped for
3422         allowed files.
3423
3424         * Scripts/webkitpy/style/checkers/xml.py: Added.
3425         (XMLChecker.__init__): Simple init method.
3426         (XMLChecker.check): Pass each line through the expat parser, and record
3427         a style error for any errors thrown by the parser.
3428
3429         * Scripts/webkitpy/style/checkers/xml_unittest.py: Added.
3430         (XMLCheckerTest.assert_no_error): Checks that the given XML does not
3431         produce a style error.
3432         (XMLCheckerTest.assert_error): Checks that the given XML produces an
3433         error of the given category on the given line.
3434         (XMLCheckerTest.mock_handle_style_error): Does nothing. Used for
3435         checking that the XMLChecker constructor works properly.
3436         (XMLCheckerTest.test_conflict_marker): Tests that conflict markers
3437         cause a style error (see, e.g., r73887).
3438         (XMLCheckerTest.test_extra_closing_tag): Tests that extra closing tags
3439         cause a style error (see, e.g., r73773).
3440         (XMLCheckerTest.test_init): Tests that the XMLChecker constructor works
3441         properly.
3442         (XMLCheckerTest.test_missing_closing_tag): Tests that missing closing
3443         tags cause a style error (see, e.g., r72795).
3444         (XMLCheckerTest.test_no_error): Tests that valid XML does not cause a
3445         style error.
3446
3447 2010-12-15  Lucas Forschler  <lforschler@apple.com>
3448
3449         Reviewed by Stephanie Lewis.
3450
3451         https://bugs.webkit.org/show_bug.cgi?id=51117
3452         Add a new leopard test bot
3453         really really commit to trunk this time.
3454
3455         * BuildSlaveSupport/build.webkit.org-config/config.json:
3456
3457 2010-12-15  Sam Weinig  <sam@webkit.org>
3458
3459         Reviewed by Anders Carlsson.
3460
3461         WebKit2: Can't add files to an <input type=file>
3462         https://bugs.webkit.org/show_bug.cgi?id=51087
3463
3464         * MiniBrowser/mac/BrowserWindowController.m:
3465         (runOpenPanel):
3466         (-[BrowserWindowController awakeFromNib]):
3467         Add simple implementation of runOpenPanel callback.
3468
3469         * MiniBrowser/win/BrowserView.cpp:
3470         (BrowserView::create):
3471         * WebKitTestRunner/TestController.cpp:
3472         (WTR::createOtherPage):
3473         (WTR::TestController::initialize):
3474         Stub out runOpenPanel callback.
3475
3476 2010-12-14  Eric Seidel  <eric@webkit.org>
3477
3478         Reviewed by Adam Barth.
3479
3480         commit-queue should upload failure diffs when tests flake
3481         https://bugs.webkit.org/show_bug.cgi?id=51051
3482
3483         To make this testable I needed to pipe FileSystem down onto tool.
3484         We've wanted it there for a long time anyway.
3485
3486         This patch is kinda a big hack.  But we don't have a nice
3487         way to read results.html files.  I think this will need further
3488         revision before this code actually feels clean.
3489
3490         As part of testing this change, I had to make MockBugzilla.create_bug
3491         actually return an id (like it should) which required updating
3492         a few other unit test results (for the better).
3493
3494         The results_matching_keys change in layouttestresults/rebasline
3495         was an alternate path which I decided not to use in the end, but
3496         I left the change as it seemed an improvement.
3497
3498         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3499         * Scripts/webkitpy/common/net/layouttestresults.py:
3500         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3501         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3502         * Scripts/webkitpy/tool/commands/queues.py:
3503         * Scripts/webkitpy/tool/commands/rebaseline.py:
3504         * Scripts/webkitpy/tool/main.py:
3505         * Scripts/webkitpy/tool/mocktool.py:
3506
3507 2010-12-15  Cosmin Truta  <ctruta@chromium.org>
3508
3509         Reviewed by James Robinson.
3510
3511         new-run-webkit-tests ignores trailing EOL differences in text tests
3512         https://bugs.webkit.org/show_bug.cgi?id=36983
3513
3514         Changed the handling of new-line characters within new-run-webkit-tests
3515         to match old-run-webkit-tests.  Differences in leading and trailing empty
3516         lines in text expectation files are no longer ignored.
3517
3518         * Scripts/webkitpy/layout_tests/port/base.py:
3519         * Scripts/webkitpy/layout_tests/port/test.py:
3520         Added unit tests.  Removed old duplicate unit test entries.
3521         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
3522
3523 2010-12-15  Ojan Vafai  <ojan@chromium.org>
3524
3525         Reviewed by Adam Barth.
3526
3527         make status-bubble white-space:nowrap so we can measure it's width without wrapping
3528         https://bugs.webkit.org/show_bug.cgi?id=51149
3529
3530         * QueueStatusServer/templates/statusbubble.html:
3531
3532 2010-12-15  Ojan Vafai  <ojan@chromium.org>
3533
3534         Reviewed by Adam Barth.
3535
3536         have the statusbubble postMessage it's metrics so that embedders can properly size the iframe
3537         https://bugs.webkit.org/show_bug.cgi?id=51125
3538
3539         * QueueStatusServer/templates/statusbubble.html:
3540
3541 2010-12-15  Darin Adler  <darin@apple.com>
3542
3543         * Scripts/webkitpy/common/net/buildbot: Added property svn:ignore.
3544
3545 2010-12-15  Sheriff Bot  <webkit.review.bot@gmail.com>
3546
3547         Unreviewed, rolling out r74117.
3548         http://trac.webkit.org/changeset/74117
3549         https://bugs.webkit.org/show_bug.cgi?id=51113
3550
3551         This broke the GTK1 build. (Requested by mrobinson on
3552         #webkit).
3553
3554         * Scripts/webkitdirs.pm:
3555
3556 2010-12-15  Amruth Raj  <amruthraj@motorola.com> and Ravi Kasibhatla  <ravi.kasibhatla@motorola.com>
3557
3558         Reviewed by Martin Robinson.
3559
3560         Change generate-forwarding-headers.pl for GTK port usage
3561         (https://bugs.webkit.org/show_bug.cgi?id=37369)
3562
3563         * Scripts/webkitdirs.pm: Added changes to build webkit2 for GTK port using build-webkit script.
3564
3565 2010-12-14  Kent Tamura  <tkent@chromium.org>
3566
3567         Reviewed by Jian Li.
3568
3569         [DRT/Chromium] Remove another unnecessary error message
3570         https://bugs.webkit.org/show_bug.cgi?id=51083
3571
3572         * DumpRenderTree/chromium/WebViewHost.cpp:
3573         (WebViewHost::didInvalidateRect):
3574
3575 2010-12-14  Lucas Forschler  <lforschler@apple.com>
3576
3577         Reviewed by Stephanie Lewis.
3578
3579         Add a new Leopard Debug Test WK2 Bot
3580
3581         * BuildSlaveSupport/build.webkit.org-config/config.json:
3582
3583 2010-12-14  Ojan Vafai  <ojan@chromium.org>
3584
3585         Fix python unittests after http://trac.webkit.org/changeset/74070.
3586
3587         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
3588
3589 2010-12-14  Kent Tamura  <tkent@chromium.org>
3590
3591         Reviewed by Jian Li.
3592
3593         [DRT/Chromium] Remove a unnecessary error message
3594         https://bugs.webkit.org/show_bug.cgi?id=51069
3595
3596         * DumpRenderTree/chromium/WebViewHost.cpp:
3597         (WebViewHost::paintInvalidatedRegion):
3598
3599 2010-12-14  Benjamin Kalman  <kalman@chromium.org>
3600
3601         Reviewed by Ojan Vafai.
3602
3603         Using BUG/BUGWK in test_expectations is error prone, should use BUGCR/BUGWK
3604         https://bugs.webkit.org/show_bug.cgi?id=48926
3605
3606         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
3607         Add presubmit check that BUG isn't used, either BUGCR/BUGWK/BUGV8_.
3608
3609 2010-12-14  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3610
3611         Reviewed by Eric Seidel.
3612
3613         [Qt] [Symbian] Do not use pkg-config on Symbian as it is not supported
3614         https://bugs.webkit.org/show_bug.cgi?id=50231
3615
3616         Guard CONFIG+=link_pkgconfig with !symbian.
3617
3618         * DumpRenderTree/qt/DumpRenderTree.pro:
3619         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3620         * WebKitTestRunner/qt/WebKitTestRunner.pro:
3621
3622 2010-12-14  Philippe Normand  <pnormand@igalia.com>
3623
3624         Reviewed by Ojan Vafai.
3625
3626         [new-run-webkit-tests] expectations parsing is slow
3627         https://bugs.webkit.org/show_bug.cgi?id=50635
3628
3629         Avoid expensive iteration of all the tests when checking if a test
3630         file is to be skipped or not.
3631
3632         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
3633         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
3634         * Scripts/webkitpy/layout_tests/port/test.py:
3635
3636 2010-12-14  Mario Sanchez Prada  <msanchez@igalia.com>
3637
3638         Reviewed by Xan Lopez.
3639
3640         [Gtk] Implement STATE_FOCUSED, STATE_FOCUSABLE, and corresponding events for text objects
3641         https://bugs.webkit.org/show_bug.cgi?id=27048
3642
3643         Add support in DRT for checking whether an accessibility UI
3644         element is focusable and/or focused. Implemented for GTK.
3645
3646         * DumpRenderTree/AccessibilityUIElement.cpp:
3647         (getIsFocusedCallback): New.
3648         (getIsFocusableCallback): New.
3649         (AccessibilityUIElement::getJSClass): Add the new available
3650         callbacks for isFocused and isFocusable.
3651         * DumpRenderTree/AccessibilityUIElement.h:
3652         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3653         (AccessibilityUIElement::isFocused): New, implemented by checking
3654         whether the related AtkState value is in the object's state set.
3655         (AccessibilityUIElement::isFocusable): Ditto.
3656         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3657         (AccessibilityUIElement::isFocused): New, dummy implementation.
3658         (AccessibilityUIElement::isFocusable): Ditto.
3659         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3660         (AccessibilityUIElement::isFocused): Ditto.
3661         (AccessibilityUIElement::isFocusable): Ditto.
3662
3663 2010-12-14  Eric Seidel  <eric@webkit.org>
3664
3665         Reviewed by Ojan Vafai.
3666
3667         webkit-patch should warn users when they're using a 32-bit git on a 64-bit system
3668         https://bugs.webkit.org/show_bug.cgi?id=50715
3669
3670         This patch makes webkit-patch print the following:
3671
3672         Warning: This machine is 64-bit, but the git binary (/usr/local/git/bin/git) does not support 64-bit.
3673         Install a 64-bit git for better performance, see:
3674         https://lists.webkit.org/pipermail/webkit-dev/2010-December/015249.html
3675
3676         I wrote this mostly because I have approximately 8 machines that I use
3677         and making sure each one is using a good Git install seemed folly.
3678         webkit-patch makes a lot of git calls, so using a fast git can shave
3679         several seconds in every invocation.  See the webkit-dev thread for more info.
3680
3681         This message will print twice during 'webkit-patch upload',
3682         once from webkit-patch and once from check-webkit-style.
3683
3684         Unfortunately there is no good way to test this due to how machine-dependent
3685         the code is.  I considered writing a test for the log message, but it seemed not worth it.
3686
3687         * Scripts/webkitpy/common/checkout/scm.py:
3688
3689 2010-12-13  Eric Seidel  <eric@webkit.org>
3690
3691         Reviewed by Adam Barth.
3692
3693         FlakyTestReporter doesn't understand bots running from multiple email addresses
3694         https://bugs.webkit.org/show_bug.cgi?id=50960
3695
3696         This explains at least one of the dupes of:
3697         https://bugs.webkit.org/show_bug.cgi?id=50863
3698         that we saw filed by the commit-queue this morning.
3699         I think the other one was explained by my previous fix to result counting code.
3700
3701         Since this is really hard to test with a unit test, instead I
3702         create a new (possibly useful in the future) command
3703         which given a layout test path will return you
3704         the one bug which our tools would assume it the flaky test bug.
3705         If some other script wants to use bug-for-test we'll
3706         need to extend it with some options like --create-if-missing or similar.
3707
3708         * Scripts/webkitpy/common/net/bugzilla/bug.py:
3709         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3710         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3711         * Scripts/webkitpy/tool/commands/__init__.py:
3712         * Scripts/webkitpy/tool/commands/bugfortest.py: Added.
3713
3714 2010-12-13  Mihai Parparita  <mihaip@chromium.org>
3715
3716         Reviewed by James Robinson.
3717
3718         Add option to build-webkit to not build WebKit2
3719         https://bugs.webkit.org/show_bug.cgi?id=50988
3720
3721         Add support for a --no-webkit2 option to build-webkit. It seems to save
3722         ~1 minute from clean builds and ~10 seconds from no-op builds.
3723
3724         * Scripts/build-webkit:
3725
3726 2010-12-13  Lucas Forschler  <lforschler@apple.com>
3727
3728         Reviewed by Dave Kilzer.
3729
3730         Update iexploder from 1.3.2 to 1.7.2
3731         Move 1.3.2 into its own subdir
3732         Add 1.7.2 into its own subdir
3733         update scripts to point to new 1.3.2 location (avoid breaking existing scripts)
3734
3735         * Scripts/run-iexploder-tests:
3736         * Scripts/update-iexploder-cssproperties:
3737         * iExploder/CHANGELOG.txt: Removed.
3738         * iExploder/LICENSE.txt: Removed.
3739         * iExploder/README.txt: Removed.
3740         * iExploder/htdocs: Removed.
3741         * iExploder/iexploder-1.3.2: Added.
3742         * iExploder/iexploder-1.3.2/CHANGELOG.txt: Copied from iExploder/CHANGELOG.txt.
3743         * iExploder/iexploder-1.3.2/LICENSE.txt: Copied from iExploder/LICENSE.txt.
3744         * iExploder/iexploder-1.3.2/README.txt: Copied from iExploder/README.txt.
3745         * iExploder/iexploder-1.3.2/htdocs: Added.
3746         * iExploder/iexploder-1.3.2/htdocs/config.rb: Copied from iExploder/htdocs/config.rb.
3747         * iExploder/iexploder-1.3.2/htdocs/cssproperties.in: Copied from iExploder/htdocs/cssproperties.in.
3748         * iExploder/iexploder-1.3.2/htdocs/cssvalues.in: Copied from iExploder/htdocs/cssvalues.in.
3749         * iExploder/iexploder-1.3.2/htdocs/htmlattrs.in: Copied from iExploder/htdocs/htmlattrs.in.
3750         * iExploder/iexploder-1.3.2/htdocs/htmltags.in: Copied from iExploder/htdocs/htmltags.in.
3751         * iExploder/iexploder-1.3.2/htdocs/htmlvalues.in: Copied from iExploder/htdocs/htmlvalues.in.
3752         * iExploder/iexploder-1.3.2/htdocs/iexploder.cgi: Copied from iExploder/htdocs/iexploder.cgi.
3753         * iExploder/iexploder-1.3.2/htdocs/iexploder.rb: Copied from iExploder/htdocs/iexploder.rb.
3754         * iExploder/iexploder-1.3.2/htdocs/index.html: Copied from iExploder/htdocs/index.html.
3755         * iExploder/iexploder-1.3.2/htdocs/webserver.rb: Copied from iExploder/htdocs/webserver.rb.
3756         * iExploder/iexploder-1.3.2/tools: Added.
3757         * iExploder/iexploder-1.3.2/tools/lasthit.rb: Copied from iExploder/tools/lasthit.rb.
3758         * iExploder/iexploder-1.3.2/tools/osx_last_crash.rb: Copied from iExploder/tools/osx_last_crash.rb.
3759         * iExploder/iexploder-1.3.2/tools/showtest.rb: Copied from iExploder/tools/showtest.rb.
3760         * iExploder/iexploder-1.7.2: Added.
3761         * iExploder/iexploder-1.7.2/ChangeLog.txt: Added.
3762         * iExploder/iexploder-1.7.2/LICENSE.txt: Added.
3763         * iExploder/iexploder-1.7.2/README.txt: Added.
3764         * iExploder/iexploder-1.7.2/output: Added.
3765         * iExploder/iexploder-1.7.2/src: Added.
3766         * iExploder/iexploder-1.7.2/src/browser_harness.rb: Added.
3767         * iExploder/iexploder-1.7.2/src/config.yaml: Added.
3768         * iExploder/iexploder-1.7.2/src/css-atrules: Added.
3769         * iExploder/iexploder-1.7.2/src/css-atrules/mozilla: Added.
3770         * iExploder/iexploder-1.7.2/src/css-atrules/webkit: Added.
3771         * iExploder/iexploder-1.7.2/src/css-properties: Added.
3772         * iExploder/iexploder-1.7.2/src/css-properties/dillo: Added.
3773         * iExploder/iexploder-1.7.2/src/css-properties/gtkhtml: Added.
3774         * iExploder/iexploder-1.7.2/src/css-properties/internet_explorer6: Added.
3775         * iExploder/iexploder-1.7.2/src/css-properties/mozilla: Added.
3776         * iExploder/iexploder-1.7.2/src/css-properties/webkit: Added.
3777         * iExploder/iexploder-1.7.2/src/css-pseudo: Added.
3778         * iExploder/iexploder-1.7.2/src/css-pseudo/mozilla: Added.
3779         * iExploder/iexploder-1.7.2/src/css-pseudo/webkit: Added.
3780         * iExploder/iexploder-1.7.2/src/css-values: Added.
3781         * iExploder/iexploder-1.7.2/src/css-values/dillo: Added.
3782         * iExploder/iexploder-1.7.2/src/css-values/gtkhtml: Added.
3783         * iExploder/iexploder-1.7.2/src/css-values/mozilla: Added.
3784         * iExploder/iexploder-1.7.2/src/css-values/other: Added.
3785         * iExploder/iexploder-1.7.2/src/css-values/webkit: Added.
3786         * iExploder/iexploder-1.7.2/src/headers: Added.
3787         * iExploder/iexploder-1.7.2/src/headers/dillo: Added.
3788         * iExploder/iexploder-1.7.2/src/headers/gtkhtml: Added.
3789         * iExploder/iexploder-1.7.2/src/headers/mozilla: Added.
3790         * iExploder/iexploder-1.7.2/src/headers/webkit: Added.
3791         * iExploder/iexploder-1.7.2/src/html-attrs: Added.
3792         * iExploder/iexploder-1.7.2/src/html-attrs/dillo: Added.
3793         * iExploder/iexploder-1.7.2/src/html-attrs/gtkhtml: Added.
3794         * iExploder/iexploder-1.7.2/src/html-attrs/internet_explorer6: Added.
3795         * iExploder/iexploder-1.7.2/src/html-attrs/mozilla: Added.
3796         * iExploder/iexploder-1.7.2/src/html-attrs/other: Added.
3797         * iExploder/iexploder-1.7.2/src/html-attrs/webkit: Added.
3798         * iExploder/iexploder-1.7.2/src/html-tags: Added.
3799         * iExploder/iexploder-1.7.2/src/html-tags/dillo: Added.
3800         * iExploder/iexploder-1.7.2/src/html-tags/gtkhtml: Added.
3801         * iExploder/iexploder-1.7.2/src/html-tags/mozilla: Added.
3802         * iExploder/iexploder-1.7.2/src/html-tags/other: Added.
3803         * iExploder/iexploder-1.7.2/src/html-tags/webkit: Added.
3804         * iExploder/iexploder-1.7.2/src/html-values: Added.
3805         * iExploder/iexploder-1.7.2/src/html-values/dillo: Added.
3806         * iExploder/iexploder-1.7.2/src/html-values/gtkhtml: Added.
3807         * iExploder/iexploder-1.7.2/src/html-values/mozilla: Added.
3808         * iExploder/iexploder-1.7.2/src/html-values/other: Added.
3809         * iExploder/iexploder-1.7.2/src/html-values/webkit: Added.
3810         * iExploder/iexploder-1.7.2/src/iexploder.cgi: Added.
3811         * iExploder/iexploder-1.7.2/src/iexploder.rb: Added.
3812         * iExploder/iexploder-1.7.2/src/index.html: Added.
3813         * iExploder/iexploder-1.7.2/src/media: Added.
3814         * iExploder/iexploder-1.7.2/src/media/blank.ogg: Added.
3815         * iExploder/iexploder-1.7.2/src/media/blank.snd: Added.
3816         * iExploder/iexploder-1.7.2/src/media/blank.wav: Added.
3817         * iExploder/iexploder-1.7.2/src/media/bug.bmp: Added.
3818         * iExploder/iexploder-1.7.2/src/media/bug.gif: Added.
3819         * iExploder/iexploder-1.7.2/src/media/bug.ico: Added.
3820         * iExploder/iexploder-1.7.2/src/media/bug.jng: Added.
3821         * iExploder/iexploder-1.7.2/src/media/bug.jpg: Added.
3822         * iExploder/iexploder-1.7.2/src/media/bug.png: Added.
3823         * iExploder/iexploder-1.7.2/src/media/bug.svg: Added.
3824         * iExploder/iexploder-1.7.2/src/media/bug.tiff: Added.
3825         * iExploder/iexploder-1.7.2/src/media/bug.xbm: Added.
3826         * iExploder/iexploder-1.7.2/src/media/bug.xpm: Added.
3827         * iExploder/iexploder-1.7.2/src/mime-types: Added.
3828         * iExploder/iexploder-1.7.2/src/mime-types/dillo: Added.
3829         * iExploder/iexploder-1.7.2/src/mime-types/mozilla: Added.
3830         * iExploder/iexploder-1.7.2/src/mime-types/webkit: Added.
3831         * iExploder/iexploder-1.7.2/src/protocols: Added.
3832         * iExploder/iexploder-1.7.2/src/protocols/dillo: Added.
3833         * iExploder/iexploder-1.7.2/src/protocols/gtkhtml: Added.
3834         * iExploder/iexploder-1.7.2/src/protocols/mozilla: Added.
3835         * iExploder/iexploder-1.7.2/src/protocols/webkit: Added.
3836         * iExploder/iexploder-1.7.2/src/scanner.rb: Added.
3837         * iExploder/iexploder-1.7.2/src/version.rb: Added.
3838         * iExploder/iexploder-1.7.2/src/webserver.rb: Added.
3839         * iExploder/iexploder-1.7.2/testcases: Added.
3840         * iExploder/iexploder-1.7.2/testcases/testcase-Linux_x86_64_rv2.0b6pre_Gecko-20100904_Firefox-4.0b6pre-TEST-8375-1_59.html: Added.
3841         * iExploder/iexploder-1.7.2/testcases/testcase-Opera-9.80_Linux_x86_64_en_Presto-2.6.30_Version-10.61-16704-3_108,3.html: Added.
3842         * iExploder/iexploder-1.7.2/testcases/testcase-U_Intel_Mac_OS_X_10_6_4_en-US_AppleWebKit-534.8_Chrome-7.0.529.0-TEST-611-3_36,9.html: Added.
3843         * iExploder/iexploder-1.7.2/testcases/testcase-U_Intel_Mac_OS_X_10_6_4_en-US_AppleWebKit-534.8_hrome-7.0.529.0-TEST-55313622206-3_6,0.html: Added.
3844         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.6_Chrome-7.0.503.1-TEST-120813-8_72,56,24,8,0.html: Added.
3845         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.6_Chrome-7.0.503.1-TEST-121240-3_81,3.html: Added.
3846         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.7_Chrome-7.0.513.0-4800-5_80,65,15.html: Added.
3847         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.7_Chrome-7.0.513.0-TEST-23583190347-3_15,12.html: Added.
3848         * iExploder/iexploder-1.7.2/tools: Added.
3849         * iExploder/iexploder-1.7.2/tools/lasthit.rb: Added.
3850         * iExploder/iexploder-1.7.2/tools/osx_last_crash.rb: Added.
3851         * iExploder/iexploder-1.7.2/tools/release_src.sh: Added.
3852         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh: Added.
3853         * iExploder/tools: Removed.
3854
3855 2010-12-13  Sam Weinig  <sam@webkit.org>
3856
3857         Reviewed by Anders Carlsson.
3858
3859         Remove associated page concept from WKView constructor
3860         https://bugs.webkit.org/show_bug.cgi?id=50983
3861
3862         Step 1: Remove associate page constructors from WKView and make
3863         all views use the shared namespace for the context.
3864
3865         * TestWebKitAPI/PlatformWebView.h:
3866         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
3867         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
3868         * WebKitTestRunner/PlatformWebView.h:
3869         * WebKitTestRunner/TestController.cpp:
3870         (WTR::createOtherPage):
3871         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3872         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3873         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3874
3875 2010-12-13  Sam Weinig  <sam@webkit.org>
3876
3877         Reviewed by Anders Carlsson.
3878
3879         Change the WebKit2 public API so there is no explicit WKPageNamespace object
3880         https://bugs.webkit.org/show_bug.cgi?id=50898
3881
3882         * MiniBrowser/mac/AppDelegate.h:
3883         * MiniBrowser/mac/AppDelegate.m:
3884         * MiniBrowser/mac/BrowserWindowController.h:
3885         * MiniBrowser/mac/BrowserWindowController.m:
3886         * MiniBrowser/win/BrowserView.cpp:
3887         Convert MiniBrowser to not use PageNamespaces.
3888
3889         * TestWebKitAPI/PlatformWebView.h:
3890         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
3891         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
3892         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
3893         * TestWebKitAPI/Tests/WebKit2/Find.cpp:
3894         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
3895         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
3896         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
3897         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
3898         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
3899         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
3900         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
3901         * TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp:
3902         * TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp:
3903         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
3904         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
3905         Convert TestWebKitAPI to not use PageNamespaces.
3906
3907         * WebKitTestRunner/PlatformWebView.h:
3908         * WebKitTestRunner/TestController.cpp:
3909         * WebKitTestRunner/TestController.h:
3910         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3911         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3912         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3913         Convert WebKitTestRunner to not use PageNamespaces.
3914
3915 2010-12-13  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
3916
3917         Reviewed by Eric Seidel.
3918
3919         webkit-patch rollout should be able to do multi-revision rollouts
3920         https://bugs.webkit.org/show_bug.cgi?id=33336
3921
3922         Make it possible to pass more than one revision to webkit-patch.
3923
3924         * Scripts/webkitpy/common/checkout/api.py:
3925         * Scripts/webkitpy/common/checkout/changelog.py:
3926         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
3927         * Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:
3928         * Scripts/webkitpy/tool/commands/download.py:
3929         * Scripts/webkitpy/tool/commands/download_unittest.py:
3930         * Scripts/webkitpy/tool/mocktool.py:
3931         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
3932         * Scripts/webkitpy/tool/steps/revertrevision.py:
3933
3934 2010-12-13  Eric Seidel  <eric@webkit.org>
3935
3936         Unreviewed.
3937
3938         Teach webkit-patch how to search bugzilla
3939         https://bugs.webkit.org/show_bug.cgi?id=50500
3940
3941         webkit-patch bug-search fails when there is only one result.
3942         Turns out we needed a bit more logic in our result count parsing code.
3943
3944         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3945         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
3946
3947 2010-12-13  Antti Koivisto  <antti@apple.com>
3948
3949         Reviewed by Alexey Proskuryakov.
3950
3951         Add setSerializeHTTPLoads function to allow testing resource load order on OS X.
3952         https://bugs.webkit.org/show_bug.cgi?id=50758
3953
3954         * DumpRenderTree/LayoutTestController.cpp:
3955         (setSerializeHTTPLoadsCallback):
3956         (LayoutTestController::staticFunctions):
3957         * DumpRenderTree/LayoutTestController.h:
3958         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3959         (LayoutTestController::setSerializeHTTPLoads):
3960         * DumpRenderTree/mac/DumpRenderTree.mm:
3961         (resetDefaultsToConsistentValues):
3962         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3963         (LayoutTestController::setSerializeHTTPLoads):
3964         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3965         (LayoutTestController::setSerializeHTTPLoads):
3966
3967 2010-12-13  Dimitri Glazkov  <dglazkov@chromium.org>
3968
3969         Reviewed by Ojan Vafai.
3970
3971         Remove "use-drt" option from test step command line, since the option was removed in r73748.
3972         https://bugs.webkit.org/show_bug.cgi?id=50936
3973
3974         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Removed the option.
3975
3976 2010-12-13  Patrick Gansterer  <paroga@webkit.org>
3977
3978         Reviewed by Csaba Osztrogonác.
3979
3980         Add revlink to BuildBot status
3981         https://bugs.webkit.org/show_bug.cgi?id=50914
3982
3983         This adds a hyperlink to trac changeset on the revision numbers.
3984
3985         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3986
3987 2010-12-13  Andras Becsi  <abecsi@webkit.org>
3988
3989         Reviewed by Csaba Osztrogonác.
3990
3991         [Qt][WK2] Fix build if WebKitTools are not available
3992         https://bugs.webkit.org/show_bug.cgi?id=50242
3993
3994         * MiniBrowser/qt/MiniBrowser.pro: Correct the comment.
3995         * Scripts/webkitdirs.pm: Added WebKitTools/MiniBrowser to $subdirs.
3996         * MiniBrowser/DerivedSources.pro: Added.
3997
3998 2010-12-13  Eric Seidel  <eric@webkit.org>
3999
4000         Reviewed by Adam Barth.
4001
4002         EWS Queues should remove orpahned pyc files before starting
4003         https://bugs.webkit.org/show_bug.cgi?id=50904
4004
4005         A previous check added a platform.py which caused
4006         EWS bots on some platforms to hit an import exception.
4007         The platform.py file was removed in a subsequent commit, but
4008         the EWS bots in question stayed stuck.  This change will
4009         fix those bots once restarted (and prevent this in the future).
4010
4011         I also went ahead and unified start-queue and start-commit-queue
4012         since they were nearly identical.  I also added bot_id support
4013         to both force all EWSes to have bot ids as well as get rid of the one
4014         remaining reason why I had my own copies of these scripts.
4015         Hopefully this will be enough to get all the other bot admins
4016         (ahem, Adam, ahem) to move to using these checked in copies as well.
4017
4018         * EWSTools/start-commit-queue.sh: Removed.
4019         * EWSTools/start-queue.sh:
4020
4021 2010-10-28  MORITA Hajime  <morrita@google.com>
4022
4023         Reviewed by Ojan Vafai.
4024
4025         spellcheck does not check pasted text
4026         https://bugs.webkit.org/show_bug.cgi?id=40092
4027
4028         Added LayoutTestController::setAsynchronousSpellCheckingEnabled()
4029         to control the setting.
4030
4031         * DumpRenderTree/LayoutTestController.cpp:
4032         (setAsynchronousSpellCheckingEnabledCallback):
4033         (LayoutTestController::staticFunctions):
4034         * DumpRenderTree/LayoutTestController.h:
4035         * DumpRenderTree/chromium/LayoutTestController.h:
4036         * DumpRenderTree/chromium/LayoutTestController.cpp:
4037         (LayoutTestController::LayoutTestController):
4038         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
4039         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
4040         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
4041         * DumpRenderTree/mac/DumpRenderTree.mm:
4042         (resetDefaultsToConsistentValues):
4043         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
4044         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
4045         * DumpRenderTree/qt/LayoutTestControllerQt.h:
4046         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
4047         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
4048         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
4049         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
4050         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
4051         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
4052
4053 2010-12-12  Sam Weinig  <sam@webkit.org>
4054
4055         Reviewed by Anders Carlsson.
4056
4057         Fix failing API test. It turns out that a pop-state event
4058         is sent before every fragment navigation, so we have to test
4059         for it in addition in PageLoadDidChangeLocationWithinPageForFrame.
4060
4061         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
4062         (TestWebKitAPI::didSameDocumentNavigationForFrame):
4063
4064 2010-12-12  Alejandro G. Castro  <alex@igalia.com>
4065
4066         Reviewed by Eric Seidel.
4067
4068         [GTK] Add new-run-webkit-tests support to gtk
4069         https://bugs.webkit.org/show_bug.cgi?id=50681
4070
4071         Adding the basic support to run the new-run-webkit-tests.
4072
4073         * Scripts/webkitpy/layout_tests/port/gtk.py:
4074
4075 2010-10-11  Diego Gonzalez  <diegohcg@webkit.org>
4076
4077         Reviewed by Kenneth Rohde Christiansen.
4078
4079         [Qt] Mock DeviceOrientation client for DRT
4080         https://bugs.webkit.org/show_bug.cgi?id=47490
4081
4082         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
4083         (WebCore::DumpRenderTree::DumpRenderTree):
4084         (WebCore::DumpRenderTree::~DumpRenderTree):
4085         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
4086         (LayoutTestController::setMockDeviceOrientation):
4087
4088 2010-12-11  Philippe Normand  <pnormand@igalia.com>
4089
4090         Reviewed by Gustavo Noronha Silva.
4091
4092         [GTK] launcher: disable the Mozilla-style fullscreen API
4093         https://bugs.webkit.org/show_bug.cgi?id=50874
4094
4095         Disabling the fullscreen API until its implementation for GTK is
4096         mature enough. The webview setting for it is already FALSE by
4097         default.
4098
4099         * GtkLauncher/main.c:
4100         (createWindow):
4101
4102 2010-12-10  Eric Seidel  <eric@webkit.org>
4103
4104         Reviewed by Adam Barth.
4105
4106         commit-queue flaky test messages show cryptic version information for mac os x
4107         https://bugs.webkit.org/show_bug.cgi?id=50864
4108
4109         Turns out platform.platform() returns kernel version information
4110         which isn't helpful, and just plain confusing on Mac
4111         (OS X 10.6.5 uses Darwin Kernel 10.5.0).
4112
4113         So I've updated PlatformInfo.display_name() to special case
4114         mac.  I also found a bad use of sys.platform in the process
4115         and fixed that.  (sys.platform always returns 'darwin' on mac).
4116
4117         * Scripts/webkitpy/common/system/platforminfo.py:
4118         * Scripts/webkitpy/common/system/user.py:
4119         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
4120         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
4121         * Scripts/webkitpy/tool/commands/queues_unittest.py:
4122
4123 2010-12-10  Eric Seidel  <eric@webkit.org>
4124
4125         Unreviewed.
4126
4127         Exception seen while reporting flaky test with commit-queue.
4128         Just a missing include.
4129
4130         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
4131         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
4132
4133 2010-12-10  Kinuko Yasuda  <kinuko@chromium.org>
4134
4135         Reviewed by Eric Seidel.
4136
4137         [Chromium] Remove old JSONResultsGenerator script that existed for backward-compatibility
4138         https://bugs.webkit.org/show_bug.cgi?id=50796
4139
4140         Also updating the test code to use JSONResultsGeneratorBase and
4141         to improve test coverage for incremental cases.
4142
4143         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
4144         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
4145
4146 2010-12-10  Joseph Pecoraro  <joepeck@webkit.org>
4147
4148         Reviewed by Darin Adler.
4149
4150         prepare-ChangeLog --help doesn't mention --bug shorthand -b
4151         https://bugs.webkit.org/show_bug.cgi?id=50835
4152
4153         * Scripts/prepare-ChangeLog: be more explicit about -b and match file style.
4154
4155 2010-12-10  Eric Seidel  <eric@webkit.org>
4156
4157         Reviewed by Adam Barth.
4158
4159         Bugs created by the commit-queue should all block on a master bug
4160         https://bugs.webkit.org/show_bug.cgi?id=50857
4161
4162         This makes all bugs created by the commit-queue block on:
4163         https://bugs.webkit.org/show_bug.cgi?id=50856
4164
4165         In the process of testing this, I found that the existing
4166         create_bug code was wrong.  I also found that existing
4167         unit tests for create-rollout used invalid values
4168         for options.blocks.  I fixed both issues and tested.
4169
4170         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
4171         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
4172         * Scripts/webkitpy/tool/commands/commandtest.py:
4173         * Scripts/webkitpy/tool/commands/download_unittest.py:
4174         * Scripts/webkitpy/tool/commands/upload_unittest.py:
4175         * Scripts/webkitpy/tool/mocktool.py:
4176         * Scripts/webkitpy/tool/steps/options.py:
4177
4178 2010-12-10  Eric Seidel  <eric@webkit.org>
4179
4180         Reviewed by Adam Barth.
4181
4182         Teach webkitpy how to follow duplicate chains when posting comments on flake bugs
4183         https://bugs.webkit.org/show_bug.cgi?id=50853
4184
4185         I also discovered when doing this that the code was posting
4186         the comment on the wrong bug, but that's fixed here too.
4187
4188         * Scripts/webkitpy/common/net/bugzilla/bug.py:
4189         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
4190         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
4191         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
4192         * Scripts/webkitpy/tool/commands/queues_unittest.py:
4193         * Scripts/webkitpy/tool/mocktool.py:
4194
4195 2010-12-10  Anders Carlsson  <andersca@apple.com>
4196
4197         Reviewed by John Sullivan.
4198
4199         Make WKContextGetStatistics gather global statistics
4200         https://bugs.webkit.org/show_bug.cgi?id=50850
4201
4202         Remove the code that gets the statistics and fills in the per context
4203         statistics information for now.
4204
4205         * MiniBrowser/mac/BrowserStatisticsWindowController.m:
4206         (-[BrowserStatisticsWindowController refreshStatistics:]):
4207
4208 2010-12-10  Eric Seidel  <eric@webkit.org>
4209
4210         Unreviewed.
4211
4212         commit-queue should report port/platform information when commenting on flaky test bugs
4213         https://bugs.webkit.org/show_bug.cgi?id=50839
4214
4215         Renamed platform.py to platforminfo.py.  This broke import platform in executive.py
4216         which was only used by new run webkit tests (and clearly not unit tested).
4217
4218         * Scripts/webkitpy/common/system/platforminfo.py: Renamed from WebKitTools/Scripts/webkitpy/common/system/platform.py.
4219         * Scripts/webkitpy/tool/main.py:
4220         * Scripts/webkitpy/tool/mocktool.py:
4221
4222 2010-12-10  Eric Seidel  <eric@webkit.org>
4223
4224         Reviewed by Tony Chang.
4225
4226         commit-queue should report port/platform information when commenting on flaky test bugs
4227         https://bugs.webkit.org/show_bug.cgi?id=50839
4228
4229         This was a suggestion from Tony Chang this morning.
4230         I added a platform.py class so I could easily mock the platform call,
4231         but that may not be the final solution for this mocking.
4232         We'll try it and see.
4233
4234         * Scripts/webkitpy/common/system/platform.py: Added.
4235         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
4236         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
4237         * Scripts/webkitpy/tool/commands/queues_unittest.py:
4238         * Scripts/webkitpy/tool/main.py:
4239         * Scripts/webkitpy/tool/mocktool.py:
4240
4241 2010-12-10  Krithigassree Sambamurthy  <krithigassree.sambamurthy@nokia.com>
4242
4243         Reviewed by Joseph Pecoraro.
4244
4245         Bug 43455 - [Qt]: Implement Application Cache Quotas
4246         https://bugs.webkit.org/show_bug.cgi?id=43455
4247
4248         Introduce functions to allow new appcache layout test origin-quota.html
4249         to work correctly under Qt.
4250
4251         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
4252         (WebCore::DumpRenderTree::DumpRenderTree):
4253         (WebCore::DumpRenderTree::dumpApplicationCacheQuota):
4254         * DumpRenderTree/qt/DumpRenderTreeQt.h:
4255
4256         Introduce functions to allow new appcache layout test origin-quota.html
4257         to be successful under qt. Changes required because LayoutTestControllerQt
4258         does not inherit from LayoutController.
4259
4260         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
4261         (LayoutTestController::reset):
4262         (LayoutTestController::clearAllApplicationCaches):
4263         (LayoutTestController::setApplicationCacheOriginQuota):
4264         * DumpRenderTree/qt/LayoutTestControllerQt.h:
4265         (LayoutTestController::shouldDumpApplicationCacheDelegateCallbacks):
4266         (LayoutTestController::dumpApplicationCacheDelegateCallbacks):
4267
4268 2010-12-10  Eric Seidel  <eric@webkit.org>
4269
4270         Reviewed by Adam Barth.
4271
4272         Move buildbot.py into its own module so we can split it out into one-file-per-class
4273         https://bugs.webkit.org/show_bug.cgi?id=50806
4274
4275         We're adding more buildbot logic these days, so it makes sense
4276         to give buildbot its own module.
4277
4278         * Scripts/webkitpy/common/net/buildbot/__init__.py: Added.
4279         * Scripts/webkitpy/common/net/buildbot/buildbot.py: Renamed from WebKitTools/Scripts/webkitpy/common/net/buildbot.py.
4280         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py: Renamed from WebKitTools/Scripts/webkitpy/common/net/buildbot_unittest.py.
4281         * Scripts/webkitpy/common/net/failuremap.py:
4282         * Scripts/webkitpy/common/net/regressionwindow.py:
4283         * Scripts/webkitpy/tool/commands/rebaseline.py:
4284
4285 2010-12-10  Tony Chang  <tony@chromium.org>
4286
4287         Reviewed by Eric Seidel.
4288
4289         Use FileSystem::remove when cleaning up http lock files
4290         https://bugs.webkit.org/show_bug.cgi?id=50830
4291
4292         * Scripts/webkitpy/layout_tests/port/http_lock.py:
4293
4294 2010-12-10  Joone Hur  <joone@kldp.org>
4295
4296         Reviewed by Martin Robinson.
4297
4298         [GTK] DRT needs layoutTestController.setCacheModel
4299         https://bugs.webkit.org/show_bug.cgi?id=50705
4300
4301         webkit_set_cache_mode() is called to set the cache model.
4302
4303         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
4304         (LayoutTestController::setCacheModel): Set the cache model.
4305
4306 2010-12-10  Tony Chang  <tony@chromium.org>
4307
4308         Reviewed by Ojan Vafai.
4309
4310         [chromium] remove --use-drt and add --use-test-shell
4311         https://bugs.webkit.org/show_bug.cgi?id=50701
4312
4313         * Scripts/webkitpy/common/config/ports.py:
4314         * Scripts/webkitpy/common/config/ports_unittest.py:
4315         * Scripts/webkitpy/layout_tests/port/chromium.py:
4316         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
4317         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
4318         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
4319         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
4320         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
4321         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
4322         * Scripts/webkitpy/layout_tests/port/webkit.py:
4323         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4324         * Scripts/webkitpy/style/checkers/test_expectations.py:
4325         * Scripts/webkitpy/tool/commands/queries.py:
4326
4327 2010-12-10  John Knottenbelt  <jknotten@chromium.org>
4328
4329         Reviewed by Steve Block.
4330
4331         [Chromium] Implement mocks for client-based geolocation
4332         https://bugs.webkit.org/show_bug.cgi?id=46895
4333
4334         * DumpRenderTree/chromium/LayoutTestController.cpp:
4335         (LayoutTestController::setGeolocationPermission):
4336         (LayoutTestController::setMockGeolocationPosition):
4337         (LayoutTestController::setMockGeolocationError):
4338         * DumpRenderTree/chromium/LayoutTestController.h:
4339         * DumpRenderTree/chromium/WebViewHost.cpp:
4340         (WebViewHost::geolocationClient):
4341         (WebViewHost::geolocationClientMock):
4342         (WebViewHost::reset):
4343         * DumpRenderTree/chromium/WebViewHost.h:
4344
4345 2010-12-10  Alejandro G. Castro  <alex@igalia.com>
4346
4347         Reviewed by Martin Robinson.
4348
4349         [GTK] Add hasSpellingMarker support to the DRT
4350         https://bugs.webkit.org/show_bug.cgi?id=50739
4351
4352         Implemented the hasSpellingMarker to support spelling tests.
4353
4354         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
4355         (LayoutTestController::hasSpellingMarker):
4356
4357 2010-12-10  Eric Seidel  <eric@webkit.org>
4358
4359         Reviewed by Ojan Vafai.
4360
4361         webkit-patch: not possible to use build-and-test with local commits
4362         https://bugs.webkit.org/show_bug.cgi?id=33378
4363
4364         Make --no-clean not even check if we have local commits.
4365         It's unclear to me why the code was originally written this way.
4366         I was unable to dig up a reason from svn history.
4367
4368         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
4369         * Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py: Copied from WebKitTools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.
4370
4371 2010-12-10  Mario Sanchez Prada  <msanchez@igalia.com>
4372
4373         Reviewed by Martin Robinson.
4374
4375         [GTK] AX: implement isEnabled in DRT
4376         https://bugs.webkit.org/show_bug.cgi?id=50814
4377
4378         Implement AccessibilityUIElement::isEnabled() for GTK.
4379
4380         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
4381         (checkElementState): New function to refactor common code.
4382         (AccessibilityUIElement::isEnabled): Implement this by checking
4383         the current state of the AtkObject.
4384         (AccessibilityUIElement::isSelected): Use the new
4385         checkElementState function.
4386
4387 2010-12-10  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
4388
4389         Reviewed by Kenneth Rohde Christiansen.
4390
4391         [Qt][WK2] Add the QWKContext API class to wrap the WebContext.
4392         https://bugs.webkit.org/show_bug.cgi?id=50750
4393
4394         * MiniBrowser/qt/BrowserView.cpp:
4395         (BrowserView::BrowserView):
4396         * MiniBrowser/qt/BrowserView.h:
4397         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
4398         (WTR::WebView::WebView):
4399
4400 2010-12-10  Joone Hur  <joone@kldp.org>
4401
4402         Reviewed by Xan Lopez.
4403
4404         [GTK] Unskipping some test cases in userscripts dependent on addUserStyleSheet
4405         https://bugs.webkit.org/show_bug.cgi?id=50808
4406
4407         Unskipping the following test cases:
4408         userscripts/mixed-case-stylesheet.html
4409         userscripts/simple-stylesheet.html
4410         userscripts/user-style-all-frames.html
4411
4412         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
4413         (LayoutTestController::addUserStyleSheet):
4414
4415 2010-12-10  Joone Hur  <joone@kldp.org>
4416
4417         Reviewed by Eric Seidel.
4418
4419         [GTK] Add DRT support for pageProperty, isPageBoxVisible, pageSizeAndMarginsInPixels, and addUserStyleSheet
4420         https://bugs.webkit.org/show_bug.cgi?id=50783
4421
4422         This patch allows to unskip the following test cases:
4423         printing/page-rule-selection.html
4424         printing/page-format-data.html
4425
4426         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
4427         (LayoutTestController::pageProperty): Added.
4428         (LayoutTestController::isPageBoxVisible): Ditto.
4429         (LayoutTestController::pageSizeAndMarginsInPixels): Ditto.
4430         (LayoutTestController::addUserStyleSheet): Ditto.
4431
4432 2010-12-10  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
4433
4434         Reviewed by Kenneth Rohde Christiansen.
4435
4436         [Qt] Make QtTestBrowser spawn QNAM in a secondary thread.
4437
4438         A menu allows to switch QNAM back to the same thread.
4439
4440         * QtTestBrowser/launcherwindow.cpp:
4441         (LauncherWindow::initializeView):
4442         (LauncherWindow::createChrome):
4443         (LauncherWindow::toggleThreadedQnam):