2011-02-06 Maciej Stachowiak <mjs@apple.com>
[WebKit.git] / Tools / ChangeLog
1 2011-02-06  Maciej Stachowiak  <mjs@apple.com>
2
3         Reviewed by Ryosuke Niwa.
4
5         Update test expectations for new core builder
6         https://bugs.webkit.org/show_bug.cgi?id=53904
7
8         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
9
10 2011-02-06  Maciej Stachowiak  <mjs@apple.com>
11
12         Reviewed by David Levin.
13
14         Add WebKit2 test bot to core builders
15         https://bugs.webkit.org/show_bug.cgi?id=53901
16
17         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
18
19 2011-02-06  Ryosuke Niwa  <rniwa@webkit.org>
20
21         Another unreviewed Chromium build fix.
22
23         * DumpRenderTree/chromium/LayoutTestController.cpp:
24         (LayoutTestController::pathToLocalResource):
25
26 2011-02-06  Ryosuke Niwa  <rniwa@webkit.org>
27
28         Unreviewed Chromium build fix.
29
30         * DumpRenderTree/chromium/LayoutTestController.cpp:
31         (LayoutTestController::pathToLocalResource):
32
33 2011-02-06  Ryosuke Niwa  <rniwa@webkit.org>
34
35         Reviewed by Darin Adler.
36
37         OwnArraryPtr.h uses deleteOwnedPtr but doesn’t include OwnPtrCommon.h
38         https://bugs.webkit.org/show_bug.cgi?id=52867
39
40         * DumpRenderTree/chromium/ImageDiff.cpp:
41         (Image::craeteFromStdin): Call adoptArrayPtr.
42
43 2011-02-06  James Kozianski  <koz@chromium.org>
44
45         Reviewed by Ojan Vafai.
46
47         Add classes for representing test outputs.
48         https://bugs.webkit.org/show_bug.cgi?id=52136
49
50         These classes will make it easier to write scripts that deal with test
51         outputs such as rebaselining and deduping scripts. The intent is that
52         eventually we will be have buildbot return TestOutputs for a
53         particular build which can be compared with TestOutputs derived from a
54         local LayoutTests directory.
55
56         * Scripts/webkitpy/common/net/testoutput.py: Added.
57         * Scripts/webkitpy/common/net/testoutput_unittest.py: Added.
58         * Scripts/webkitpy/common/net/testoutputset.py: Added.
59         * Scripts/webkitpy/common/net/testoutputset_unittest.py: Added.
60         * Scripts/webkitpy/common/system/zip_mock.py: Added.
61
62 2011-02-06  Robert Hogan  <robert@webkit.org>
63
64         Reviewed by Andreas Kling.
65
66         [Qt] Clear page's groupName even when not in DRT
67         https://bugs.webkit.org/show_bug.cgi?id=53874
68
69         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
70         (WebCore::DumpRenderTree::windowCloseRequested):
71
72 2011-02-06  Patrick Gansterer  <paroga@webkit.org>
73
74         Reviewed by Andreas Kling.
75
76         [CMake] Add dependencies for Visual Studio projects
77         https://bugs.webkit.org/show_bug.cgi?id=53773
78
79         Add a WebKit dependecy to WinCELauncher, so CMake can 
80         generate the correct build order for the solution.
81
82         * CMakeListsWinCE.txt:
83
84 2011-02-06  Andreas Kling  <kling@webkit.org>
85
86         Reviewed by Antonio Gomes.
87
88         [Qt] MiniBrowser: Clean up handling of titleChanged() signal
89         https://bugs.webkit.org/show_bug.cgi?id=53869
90
91         * MiniBrowser/qt/BrowserView.cpp:
92         (BrowserView::BrowserView): Remove unnecessary titleChanged() handling.
93         * MiniBrowser/qt/BrowserWindow.cpp:
94         (BrowserWindow::BrowserWindow): Connect titleChanged() directly to setWindowTitle().
95         * MiniBrowser/qt/BrowserWindow.h:
96
97 2011-02-06  Maciej Stachowiak  <mjs@apple.com>
98
99         Reviewed by Dan Bernstein.
100
101         WebKitTestRunner needs layoutTestController.setWillSendRequestReturnsNull
102         https://bugs.webkit.org/show_bug.cgi?id=42690
103         <rdar://problem/8213851>
104
105         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
106         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
107         (WTR::InjectedBundlePage::willSendRequestForFrame):
108         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
109         (WTR::LayoutTestController::LayoutTestController):
110         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
111         (WTR::LayoutTestController::willSendRequestReturnsNull):
112         (WTR::LayoutTestController::setWillSendRequestReturnsNull):
113
114 2011-02-05  Sheriff Bot  <webkit.review.bot@gmail.com>
115
116         Unreviewed, rolling out r77720.
117         http://trac.webkit.org/changeset/77720
118         https://bugs.webkit.org/show_bug.cgi?id=53854
119
120         "Broke nrwt on Chromium win." (Requested by dglazkov|away on
121         #webkit).
122
123         * Scripts/webkitpy/common/system/executive.py:
124
125 2011-02-05  Sheriff Bot  <webkit.review.bot@gmail.com>
126
127         Unreviewed, rolling out r77725.
128         http://trac.webkit.org/changeset/77725
129         https://bugs.webkit.org/show_bug.cgi?id=53844
130
131         It broke Qt minimal build (Requested by Ossy_ on #webkit).
132
133         * QtTestBrowser/launcherwindow.cpp:
134         (LauncherWindow::createChrome):
135         * QtTestBrowser/launcherwindow.h:
136         (WindowOptions::WindowOptions):
137         * QtTestBrowser/main.cpp:
138         (LauncherApplication::handleUserOptions):
139
140 2011-02-04  Martin Robinson  <mrobinson@igalia.com>
141
142         Reviewed by Adam Barth.
143
144         [GTK] plugins/plugin-document-back-forward.html fails
145         https://bugs.webkit.org/show_bug.cgi?id=53833
146
147         Add the new "alert on load" functionality for the Unix version of the
148         test plugin. This functionality was originally introduced in r77706.
149
150         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
151         (webkit_test_plugin_new_instance): Add new plugin fuctionality.
152
153 2011-02-04  Kundu Suchismita  <suchi.kundu@nokia.com>
154
155         Reviewed by Andreas Kling.
156
157         Local Storage settings can be enable/disable from "Develop" menu
158         https://bugs.webkit.org/show_bug.cgi?id=52296
159
160         * QtTestBrowser/launcherwindow.cpp:
161         (LauncherWindow::createChrome):
162         (LauncherWindow::toggleLocalStorage):
163         (LauncherWindow::toggleOfflineStorageDatabase):
164         (LauncherWindow::toggleOfflineWebApplicationCache):
165         (LauncherWindow::setOfflineStorageDefaultQuota):
166         * QtTestBrowser/launcherwindow.h:
167         (WindowOptions::WindowOptions):
168         * QtTestBrowser/main.cpp:
169         (LauncherApplication::handleUserOptions):
170
171 2011-02-04  Tony Chang  <tony@chromium.org>
172
173         Reviewed by Eric Seidel.
174
175         get test-webkitpy running on win32 python
176         https://bugs.webkit.org/show_bug.cgi?id=53822
177
178         The test harness crashes with a WindowsError because it can't find
179         'svn' when using subprocess.Popen.  This gets us past the error
180         so we can see the failing tests on the Chromium Win Release Tests
181         bot.
182
183         * Scripts/webkitpy/common/system/executive.py:
184
185 2011-02-04  Martin Robinson  <mrobinson@igalia.com>
186
187         Reviewed by Gustavo Noronha Silva.
188
189         [GTK] fast/events/pagehide-timeout.html fails
190         https://bugs.webkit.org/show_bug.cgi?id=53771
191
192         Add knowledge of the document browser cache model the DRT. When resetting
193         WebKit settings to consistent values between tests, default to the document
194         browser cache model.
195
196         * DumpRenderTree/gtk/DumpRenderTree.cpp:
197         (resetDefaultsToConsistentValues): Reset the cache model to the document browser
198         cache model between tests.
199         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
200         (LayoutTestController::setCacheModel): An int value of 2 here corresponds to the
201         document browser cache model.
202
203 2011-02-04  Adam Barth  <abarth@webkit.org>
204
205         Reviewed by Eric Seidel.
206
207         PluginDocuments don't create widgets for plugins on back/forward
208         https://bugs.webkit.org/show_bug.cgi?id=53474
209
210         Teach the test plugin how to call alert on load.
211
212         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
213         (NPP_New):
214
215 2011-02-04  Adam Roben  <aroben@apple.com>
216
217         Add a test case for encode/decode of FormData/FormDataElement
218
219         If the fix made in r77401 is broken, this new test will crash.
220
221         Fixes <http://webkit.org/b/53616> <rdar://problem/8949883>.
222
223         Reviewed by Sam Weinig.
224
225         * TestWebKitAPI/Test.h: Moved the bulk of TEST_ASSERT into a new _TEST_ASSERT_HELPER macro.
226         Added a new TEST_ASSERT_RETURN macro that can be used in functions with a return value.
227
228         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp: Added.
229         (TestWebKitAPI::didFinishLoadForFrame): Record that the load is finished.
230         (TestWebKitAPI::setPageLoaderClient): Hook up the loader client.
231         (TestWebKitAPI::createSessionStateContainingFormData): Load simple-form.html, submit the
232         form, an return the session state data.
233         (TestWebKitAPI::TEST): Create some session state that contains form data from one WKPage,
234         and restore it into another WKPage.
235
236         * TestWebKitAPI/Tests/WebKit2/simple-form.html: Added.
237
238         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
239         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
240         * TestWebKitAPI/win/copy-resources.cmd:
241         Added new files.
242
243 2011-02-04  Adam Roben  <aroben@apple.com>
244
245         Move code to run JavaScript tests into its own files
246
247         This will allow other tests to use this mechanism.
248
249         Fixes <http://webkit.org/b/53806> SpacebarScrolling should share its JavaScript-fu with the
250         world
251
252         Reviewed by Sam Weinig.
253
254         * TestWebKitAPI/JavaScriptTest.cpp: Added.
255         * TestWebKitAPI/JavaScriptTest.h: Added.
256         Moved code here...
257
258         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp: ...from here.
259
260         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
261         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
262         Added the new files.
263
264 2011-02-04  Dirk Pranke  <dpranke@chromium.org>
265
266         Reviewed by Mihai Parparita.
267
268         merge test expectations for chromium, chromium-gpu. The
269         chromium-gpu port will no longer maintain its own
270         test expectations file.
271
272         Also add in a graphics_type() call on the port object to
273         determine what graphics type to use in the test configuration,
274         and log the configuration as a config setting.
275
276         https://bugs.webkit.org/show_bug.cgi?id=53562
277
278         * Scripts/webkitpy/layout_tests/port/base.py:
279         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
280         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
281         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
282
283 2011-02-04  Mikhail Naganov  <mnaganov@chromium.org>
284
285         Reviewed by Pavel Feldman.
286
287         Web Inspector: fix processing Unicode literals from .js sources in check-inspector-strings.
288         https://bugs.webkit.org/show_bug.cgi?id=53781
289
290         * Scripts/check-inspector-strings:
291
292 2011-02-04  Adam Roben  <aroben@apple.com>
293
294         Include the crashing function in the link to a crash log on Mac
295
296         Fixes <http://webkit.org/b/53780> Crash log links in results.html should include the
297         function that crashed on Mac
298
299         Reviewed by David Kilzer.
300
301         * Scripts/old-run-webkit-tests:
302         (crashLocation): Moved all the Windows code inside an if instead of using an early return,
303         but didn't otherwise change it. Added an if for Mac that parses the crashing function out of
304         the crash log.
305
306 2011-02-04  Adam Roben  <aroben@apple.com>
307
308         Link to Mac crash logs from results.html
309
310         Fixes <http://webkit.org/b/14861> run-webkit-tests should link to Mac crash logs in
311         results.html
312
313         Reviewed by David Kilzer.
314
315         * Scripts/old-run-webkit-tests:
316         (captureSavedCrashLog): Added a case for Apple's Mac port. We get the crash log out of
317         ~/Library/Logs/CrashReporter, and wait for ReportCrash to exit before trying to get the log.
318
319 2011-02-03  Maciej Stachowiak  <mjs@apple.com>
320
321         Reviewed by Dan Bernstein.
322
323         WebKit2: Need WebKit2 equivalent of WebResourceLoadDelegate::willSendRequest in the Bundle
324         https://bugs.webkit.org/show_bug.cgi?id=52897
325         <rdar://problem/8898294>
326
327         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
328         (WTR::InjectedBundlePage::InjectedBundlePage):
329         (WTR::InjectedBundlePage::willSendRequestForFrame):
330         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
331
332 2011-02-03  Ivan Krstić  <ike@apple.com>
333
334         Unreviewed.
335
336         Adding myself to committers.py.
337
338         * Scripts/webkitpy/common/config/committers.py:
339
340 2011-02-03  James Kozianski  <koz@chromium.org>
341
342         Reviewed by Dimitri Glazkov.
343
344         Add navigator.registerProtocolHandler behind a flag.
345         https://bugs.webkit.org/show_bug.cgi?id=52609
346
347         * Scripts/build-webkit:
348
349 2011-02-03  Hayato Ito  <hayato@chromium.org>
350
351         Reviewed by Eric Seidel.
352
353         [NRWT] Remove TestArgs class, which is wrongly used.
354
355         https://bugs.webkit.org/show_bug.cgi?id=53063
356
357         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
358         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
359         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
360         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
361         * Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py:
362         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
363
364 2011-02-03  Andrew Wason  <rectalogic@rectalogic.com>
365
366         Reviewed by Kenneth Russell.
367
368         Change ENABLE_3D_CANVAS to ENABLE_WEBGL
369         https://bugs.webkit.org/show_bug.cgi?id=53714
370
371         * Scripts/build-webkit: change --3d-canvas build option
372           to set ENABLE_WEBGL
373
374 2011-02-03  Hayato Ito  <hayato@chromium.org>
375
376         Reviewed by Tony Chang.
377
378         [NRWT] Introduces Input/Output class used by base.Driver into port/base.py and
379         move _run_single_test() and _process_output() functions from
380         dump_render_tree_thread.py to a single_test_runner.py as an individual module.
381
382         This is clean up and acts as a preparation for elimination of test_types/*
383         classes. These classes will move to the single_test_runner module introduced
384         in this patch.
385
386         https://bugs.webkit.org/show_bug.cgi?id=53004
387
388         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
389         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py: Added.
390         * Scripts/webkitpy/layout_tests/layout_package/test_input.py:
391         * Scripts/webkitpy/layout_tests/layout_package/test_output.py: Removed.
392         * Scripts/webkitpy/layout_tests/port/base.py:
393         * Scripts/webkitpy/layout_tests/port/chromium.py:
394         * Scripts/webkitpy/layout_tests/port/dryrun.py:
395         * Scripts/webkitpy/layout_tests/port/test.py:
396         * Scripts/webkitpy/layout_tests/port/webkit.py:
397         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
398         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
399         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
400
401 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
402
403         Unreviewed, build fix.
404
405         Delete a line that was accidentally missed in r77586; without it
406         there is still a race between the two threads.
407
408         https://bugs.webkit.org/show_bug.cgi?id=51572
409
410         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
411
412 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
413
414         Reviewed by Tony Chang.
415
416         nrwt: handle "broken pipe" notifications from DRT more cleanly.
417
418         https://bugs.webkit.org/show_bug.cgi?id=52927
419
420         * Scripts/webkitpy/layout_tests/port/server_process.py:
421         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
422
423 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
424
425         Reviewed by Kenneth Russell.
426
427         Update, resubmit change to bug 51572. I think the race that was
428         fixed in r76703 caused the hang that caused us to roll this
429         patch out before, so I'd like to try again.
430
431         https://bugs.webkit.org/show_bug.cgi?id=51572
432
433         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
434         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
435
436 2011-02-03  Daniel Cheng  <dcheng@chromium.org>
437
438         Unreviewed.
439
440         Adding myself to committers.py.
441
442         * Scripts/webkitpy/common/config/committers.py:
443
444 2011-02-03  Adam Roben  <aroben@apple.com>
445
446         Include the crashing function in the link to a crash log
447
448         Fixes <http://webkit.org/b/53739> Crash log links in results.html should include the
449         function that crashed
450
451         Reviewed by David Kilzer.
452
453         * Scripts/old-run-webkit-tests:
454         (crashLocation): Added. Returns the location of the crash.
455         (linksForErrorTest): Include the crash location in the link text for the crash log, if one
456         could be determined.
457
458 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
459
460         Unreviewed, build fix.
461
462         Actually make the changes suggested by Mihai in his review
463         of bug 53720 :(
464
465         https://bugs.webkit.org/show_bug.cgi?id=53720
466
467         * Scripts/webkitpy/layout_tests/port/test_files.py:
468         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
469
470 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
471
472         Reviewed by Mihai Parparita.
473
474         new-run-webkit-tests: Fix bug introduced in r77434 that was
475         causing us to run the canvas GPU tests on the Mac GPU port. This
476         bug revealed that we were not setting the port.name() field
477         properly in many cases, so I've cleaned up all of that code, and
478         removed a few comments about "version-specific" GPU ports that
479         don't exist and just confused things.
480
481         Testing also revealed that port.abspath_for_test() wasn't
482         normalizing paths on Windows properly, so I fixed that as well.
483
484         https://bugs.webkit.org/show_bug.cgi?id=53719
485
486         * Scripts/webkitpy/layout_tests/port/base.py:
487         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
488         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
489
490 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
491
492         Reviewed by Mihai Parparita.
493
494         new-run-webkit-tests: fix normalization of paths on windows when gathering files
495
496         r77434 introduced a bug that was causing the test expectations
497         for the GPU ports to not be treated properly. It turns out that
498         when we gathered the list of test files on Windows, we would
499         return paths of the form "c:\LayoutTests/fast/canvas", and the
500         mixture of backslashes and forward slashes was confusing things.
501
502         This patch normalizes all of the filenames returned from
503         test_files.find(), and adds better tests for this (fixing a
504         couple of other bugs found in the meantime).
505
506         https://bugs.webkit.org/show_bug.cgi?id=53720
507
508         * Scripts/webkitpy/layout_tests/port/test.py:
509         * Scripts/webkitpy/layout_tests/port/test_files.py:
510         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
511
512 2011-02-03  Adam Roben  <aroben@apple.com>
513
514         Add links to Windows crash logs in results.html
515
516         Fixes <http://webkit.org/b/53718> run-webkit-tests should link to Windows crash logs in
517         results.html
518
519         Reviewed by David Kilzer.
520
521         * Scripts/old-run-webkit-tests:
522         (top level): Added $crashLogTag and $windowsCrashLogFilePrefix (which came from
523         createDebuggerCommandFile).
524         (testCrashedOrTimedOut): If the test crashed, capture any saved crash log after the dump
525         tool has exited.
526         (captureSavedCrashLog): Added. Finds the crash log for the test that just crashed and moves
527         it into the test results directory tree. Only implemented for Cygwin currently.
528         (findNewestFileMatchingGlob): Added. Does what it says.
529         (htmlForResultsSection): Only link to files that exist.
530         (linksForErrorTest): Add a link to the crash log.
531         (deleteExpectedAndActualResults): Delete any old crash log for this test.
532         (createDebuggerCommandFile): Use the new $windowsCrashLogFilePrefix constant instead of
533         hardcoding it here.
534
535 2011-02-03  Adam Roben  <aroben@apple.com>
536
537         Tell the debugger the path to the WebKit source tree when saving a crash log
538
539         This allows the debugger to include the crashing line of code in the log.
540
541         Fixes <http://webkit.org/b/53678> Crash logs from buildslaves don't show the crashing line
542         of code
543
544         Reviewed by Sam Weinig.
545
546         * Scripts/old-run-webkit-tests:
547         (createDebuggerCommandFile): Added. Saves commands that we'd like the debugger to run to a
548         file and returns the path to that file. The commands we pass came from
549         setUpWindowsCrashLogSaving, but I've added a .srcpath command to tell the debugger where the
550         WebKit source code lives.
551         (setUpWindowsCrashLogSaving): Instead of specifying the commands directly on the command
552         line using -c, save them to a file and specify the path to that file using -cf. This works
553         around what is presumably a bug in Windows's command line parsing, where having multiple
554         quoted paths in the debugger commands causes the post-mortem debugger not to be invoked at
555         all. Also pulled the options we pass to the debugger out into a list that is then join()ed
556         together to make them easier to modify in the future.
557
558 2011-02-02  Sam Weinig  <sam@webkit.org>
559
560         Reviewed by Anders Carlsson.
561
562         Add notification of the end of a rubber band.
563         <rdar://problem/8940648>
564
565         * MiniBrowser/mac/BrowserWindowController.m:
566         (-[BrowserWindowController awakeFromNib]):
567         * WebKitTestRunner/TestController.cpp:
568         (WTR::TestController::createOtherPage):
569         (WTR::TestController::initialize):
570         Stub out the new WKUIClient function.
571
572 2011-02-03  Gabor Rapcsanyi  <rgabor@webkit.org>
573
574         Unreviewed.
575
576         Adding myself to committers.py.
577
578         * Scripts/webkitpy/common/config/committers.py:
579
580 2011-02-03  Balazs Kelemen  <kbalazs@webkit.org>
581
582         Reviewed by Csaba Osztrogonác.
583
584         [Qt][WK2] MiniBrowser's window size should be 800x600
585         https://bugs.webkit.org/show_bug.cgi?id=53670
586
587         Make layout test failure debugging easier.
588         * MiniBrowser/qt/BrowserWindow.cpp:
589         (BrowserWindow::BrowserWindow):
590
591 2011-02-02  Andy Estes  <aestes@apple.com>
592
593         Reviewed by Mark Rowe.
594
595         'update-webkit' should handle OpenSource and Internal using different
596         VCSs.
597
598         * Scripts/update-webkit: Re-check the VCS type when updating Apple's
599         Internal directory.
600
601 2011-02-02  Dirk Pranke  <dpranke@chromium.org>
602
603         Reviewed by Mihai Parparita.
604
605         new-run-webkit-tests: hardcode the directories to scan for tests
606         for GPU bots instead of SKIPping them. See bug 53562 for some
607         context, but we will now hard-code the list of directories to
608         use by default instead of skipping over directories in the
609         expectations file. We do this so that we will be able to merge
610         the expectations files without getting conflicting SKIP
611         directives. Note that this change will reduce the # of tests
612         being run on the Mac GPU bots, because we're accidentally
613         including some today.
614
615         https://bugs.webkit.org/show_bug.cgi?id=53631
616
617         * Scripts/webkitpy/layout_tests/port/base.py:
618         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
619         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
620
621 2011-02-02  Sam Weinig  <sam@webkit.org>
622
623         Reviewed by Beth Dakin.
624
625         Add ChromeClient function to paint custom overhang areas.
626         https://bugs.webkit.org/show_bug.cgi?id=53639
627
628         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
629         (WTR::InjectedBundlePage::InjectedBundlePage):
630         Stub out new callback.
631
632 2011-02-02  Dirk Pranke  <dpranke@chromium.org>
633
634         Reviewed by Tony Chang.
635
636         new-run-webkit-tests: support chromium code paths in mock_drt
637
638         https://bugs.webkit.org/show_bug.cgi?id=53471
639
640         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
641         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
642
643 2011-02-02  Adam Klein  <adamk@chromium.org>
644
645         Reviewed by Tony Chang.
646
647         Update new-run-webkit-tests --chromium to put output under Source/...
648         https://bugs.webkit.org/show_bug.cgi?id=53612
649
650         * BuildSlaveSupport/test-result-archive:
651         * Scripts/webkitpy/layout_tests/port/chromium.py:
652
653 2011-01-28  Tony Chang  <tony@chromium.org>
654
655         Reviewed by Eric Seidel.
656
657         [chromium] remove --use-test-shell from NRWT
658         https://bugs.webkit.org/show_bug.cgi?id=53346
659
660         I've already started removing some of the bindings like eventSender so
661         this already doesn't work isn't useful.  Also updated some comments to
662         refer to DRT instead of test_shell.
663
664         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
665         * Scripts/webkitpy/layout_tests/port/chromium.py:
666         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
667         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
668         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
669         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
670         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
671         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
672
673 2011-02-02  Steve Lacey  <sjl@chromium.org>
674
675         Reviewed by Eric Carlson.
676
677         Implement basic media statistics on media elements.
678         https://bugs.webkit.org/show_bug.cgi?id=53322
679
680         * Scripts/build-webkit:
681
682 2011-02-02  Kevin Ollivier  <kevino@theolliviers.com>
683
684         [wx] Build fixes for wxWebKit.
685
686         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
687         (LayoutTestController::setSerializeHTTPLoads):
688         * wx/browser/wscript:
689         * wx/build/build_utils.py:
690         * wx/build/settings.py:
691
692 2011-02-01  Dirk Pranke  <dpranke@chromium.org>
693
694         Reviewed by Mihai Parparita.
695
696         new-run-webkit-tests: stop skipping so many tests
697
698         r77163 introduced a regression where we weren't resetting test
699         expectations properly and were skipping too many tests as a
700         result. This patch fixes that and adds a test for it.
701
702         https://bugs.webkit.org/show_bug.cgi?id=53551
703
704         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
705         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
706
707 2011-02-01  Dirk Pranke  <dpranke@chromium.org>
708
709         Reviewed by Tony Chang.
710
711         new-run-webkit-tests: add first stub of test_runner2. This
712         will add support for the 'inline', 'threads', and 'processes'
713         flags to --worker-model, but for now the implementatios just
714         fall back on the old ones.
715
716         https://bugs.webkit.org/show_bug.cgi?id=53157
717
718         * Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
719         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
720
721 2011-02-01  Mihai Parparita  <mihaip@chromium.org>
722
723         Reviewed by James Robinson.
724
725         [Chromium] run-chromium-webkit-unit-tests looks for binaries in the wrong place
726         https://bugs.webkit.org/show_bug.cgi?id=53522
727
728         * Scripts/run-chromium-webkit-unit-tests:
729
730 2011-02-01  Adam Barth  <abarth@webkit.org>
731
732         Reviewed by Mihai Parparita.
733
734         Using Control-C to cancel webkit-patch or other python tools causes
735         unpleasant traceback console spew
736         https://bugs.webkit.org/show_bug.cgi?id=53462
737
738         Catch the exception and don't print the stack trace.
739
740         * Scripts/webkit-patch:
741
742 2011-02-01  Scott Cameron  <sccameron@rim.com>
743
744         Reviewed by Daniel Bates.
745
746         Use Windows format for MinGW HTTPD path.
747         https://bugs.webkit.org/show_bug.cgi?id=53503
748
749         * Scripts/webkitperl/httpd.pm:
750           - Use single-quotes around MySys value for $httpdPath in getHTTPDPath()
751             so that we don't have to escape the space characters in the path. Also,
752             changed path to Windows-style path and removed FIXME comment.
753
754 2011-02-01  Balazs Kelemen  <kbalazs@webkit.org>
755
756         Reviewed by Andreas Kling.
757
758         [Qt][WK2] Add a way to use shared process model in MiniBrowser
759         https://bugs.webkit.org/show_bug.cgi?id=53090
760
761         * MiniBrowser/qt/BrowserView.cpp:
762         (BrowserView::BrowserView): Removed the m_context member.
763         From now the context is guaranteed to be non-null and we
764         don't need to store that in the object.
765         * MiniBrowser/qt/BrowserView.h:
766         * MiniBrowser/qt/BrowserWindow.cpp:
767         Added static bool to determine that new windows need to be
768         created with their own context or not. Use the same context
769         and web process by default to be inilne with the other ports.
770         (BrowserWindow::BrowserWindow):
771         (BrowserWindow::newWindow):
772         * MiniBrowser/qt/BrowserWindow.h:
773         * MiniBrowser/qt/main.cpp:
774         (main): Added command line switch to be able to use the
775         non-shared process model. Simplify the handling of the command line
776         switches a little bit.
777
778 2011-02-01  Zoltan Horvath  <zoltan@webkit.org>
779
780         Reviewed by Andreas Kling.
781
782         [Qt] Add Window menu and Toggle FullScreen action to MiniBrowser.
783         https://bugs.webkit.org/show_bug.cgi?id=53491
784
785         * MiniBrowser/qt/BrowserWindow.cpp:
786         (BrowserWindow::BrowserWindow):
787         (BrowserWindow::toggleFullScreenMode):
788         * MiniBrowser/qt/BrowserWindow.h:
789
790 2011-02-01  Zoltan Horvath  <zoltan@webkit.org>
791
792         Reviewed by Andreas Kling.
793
794         [Qt] Add Toggle Frame Flattening, Auto Load Images and Disable JavaScript actions to MiniBrowser.
795         https://bugs.webkit.org/show_bug.cgi?id=53489
796
797         Add Toggle Frame Flattening action to Develop menu. Add Auto Load Images and Disable JavaScript actions
798         to Settings menu.
799
800         * MiniBrowser/qt/BrowserWindow.cpp:
801         (BrowserWindow::BrowserWindow):
802         (BrowserWindow::toggleFrameFlattening):
803         (BrowserWindow::toggleDisableJavaScript):
804         (BrowserWindow::toggleAutoLoadImages):
805         * MiniBrowser/qt/BrowserWindow.h:
806
807 2011-01-31  Mihai Parparita  <mihaip@chromium.org>
808
809         Reviewed by Tony Chang.
810
811         [Chromium] Switch chromium-mac to use ChromiumDriver
812         https://bugs.webkit.org/show_bug.cgi?id=53461
813         
814         For the sake of consistency with the other Chromium platforms (and so
815         that chromium-mac picks up special flags like --enable-hardware-gpu),
816         switch chromium-mac from the WebKitDriver to ChromiumDriver.
817
818         * Scripts/webkitpy/layout_tests/port/chromium.py:
819
820 2011-01-31  Dirk Pranke  <dpranke@chromium.org>
821
822         Reviewed by Mihai Parparita.
823
824         The current modifier parsing code in test_expectations is
825         fragile and hard-coded, so it's not easy to understand the logic
826         or easily add new types of modifiers (like GPU vs. CPU testing
827         for graphics tests, or 32-bit vs. 64-bit differences).
828
829         This is the first of two patches that will add in more generic
830         support and then eliminate the GPU-specific test expectations
831         files for Chromium.
832
833         This patch adds two standalone objects for handling modifiers. The
834         rules for interpreting modifiers, precedence, and conflicts are
835         given in the docstring to the ModifierMatcher class, which
836         returns ModifierMatchResult objects.
837         
838         This patch also adds routines to the Port interface and a
839         default set of values in the base object, in order to obtain the
840         values needed on a given test run. These values are then passed
841         to the expectation parser. This also allows us to clean up the
842         logic used to lint all of the different configurations in a
843         single test_expectations.txt file.
844
845         The next patch will merge in the separate GPU expectations file.
846
847         https://bugs.webkit.org/show_bug.cgi?id=51222
848
849         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
850         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
851         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
852         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
853         * Scripts/webkitpy/layout_tests/port/base.py:
854         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
855         * Scripts/webkitpy/layout_tests/port/chromium.py:
856         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
857         * Scripts/webkitpy/layout_tests/port/test.py:
858         * Scripts/webkitpy/layout_tests/port/webkit.py:
859         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
860         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
861         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
862         * Tools/Scripts/webkitpy/style/checkers/test_expectations.py:
863         * Tools/Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
864
865 2011-01-31  Scott Cameron  <sccameron@rim.com>
866
867         Reviewed by Daniel Bates.
868
869         update run-webkit-httpd to be able to launch Apache2.2 in a MSYS environment
870         https://bugs.webkit.org/show_bug.cgi?id=50036
871
872         This will add an Apache2.2 configuration file and modifies scripts to allow
873         running an httpd server in an MSYS environment.
874
875         The default Apache2.2 installation path has been preserved and PHP5 modules disabled
876         in order to allow for simple installation/execution.  Simply install the latest
877         Apache2.2 version with OpenSSL from http://httpd.apache.org/download.cgi#apache22 to
878         be able to execute run-webkit-httpd.
879         
880
881         * Scripts/run-webkit-httpd:
882         * Scripts/webkitperl/httpd.pm:
883
884 2011-01-31  Tony Chang  <tony@chromium.org>
885
886         Reviewed by Eric Seidel.
887
888         mac DRT should report RTL scroll offset relative to top right corner
889         https://bugs.webkit.org/show_bug.cgi?id=53324
890
891         * DumpRenderTree/mac/DumpRenderTree.mm:
892         (dumpFrameScrollPosition):
893
894 2011-01-31  Zoltan Horvath  <zoltan@webkit.org>
895
896         Reviewed by Andreas Kling.
897
898         [Qt] Add Take Screen Shot action to MiniBrowser
899         https://bugs.webkit.org/show_bug.cgi?id=53422
900
901         Add Take Screen Shot action to MiniBrowser's view menu.
902
903         * MiniBrowser/qt/BrowserWindow.cpp:
904         (BrowserWindow::BrowserWindow):
905         (BrowserWindow::screenshot):
906         * MiniBrowser/qt/BrowserWindow.h:
907
908 2011-01-31  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
909
910         Reviewed by Xan Lopez.
911
912         [GTK] REGRESSION:  http/tests/media/video-{cookie,referer}.html failing
913         https://bugs.webkit.org/show_bug.cgi?id=53379
914
915         Remove left over #ifdef's. I thought all of the conditional code
916         had been freed from the condition, but I forgot to check DRT.
917
918         * DumpRenderTree/gtk/DumpRenderTree.cpp:
919         (resetDefaultsToConsistentValues):
920         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
921         (LayoutTestController::setAlwaysAcceptCookies):
922
923 2011-01-30  Dirk Pranke  <dpranke@chromium.org>
924
925         Unreviewed, build fix.
926
927         Fix regression introduced in r77093 - path.rsplit() doesn't
928         take keyword arguments.
929
930         https://bugs.webkit.org/show_bug.cgi?id=53326
931
932         * Scripts/webkitpy/common/system/filesystem_mock.py:
933
934 2011-01-30  Dirk Pranke  <dpranke@chromium.org>
935
936         Reviewed by Mihai Parparita.
937
938         Add more unit tests for rebaseline-chromium-webkit-tests. This
939         change involves restructuring a bunch of r-c-w-t code to make it
940         more testable as well. We also add wrapper classes for handling
941         testing zip files and fetching URLs.
942
943         https://bugs.webkit.org/show_bug.cgi?id=53040
944
945         * Scripts/webkitpy/common/system/urlfetcher.py:
946         * Scripts/webkitpy/common/system/urlfetcher_mock.py:
947         * Scripts/webkitpy/common/system/zipfileset_mock.py:
948         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
949         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
950         * Scripts/webkitpy/tool/mocktool.py:
951
952 2011-01-30  Dirk Pranke  <dpranke@chromium.org>
953
954         Reviewed by Eric Seidel.
955
956         Clean up of the filesystem-related modules used in webkitpy.
957         I've added relpath() to the filesystem interface, modified
958         ospath.relpath() so that it could work with the filesystem
959         interface, and modified the fileset* routines to use the
960         filesystem interface consistently.
961
962         This patch also adds a close() routine to the fileset routines
963         to indicate that the caller is done with the fileset. This
964         allows zipfileset to clean up after itself when it creates
965         tempfiles to store downloads.
966
967         https://bugs.webkit.org/show_bug.cgi?id=53326
968
969         * Scripts/webkitpy/common/system/directoryfileset.py:
970         * Scripts/webkitpy/common/system/fileset.py:
971         * Scripts/webkitpy/common/system/filesystem.py:
972         * Scripts/webkitpy/common/system/filesystem_mock.py:
973         * Scripts/webkitpy/common/system/filesystem_unittest.py:
974         * Scripts/webkitpy/common/system/ospath.py:
975         * Scripts/webkitpy/common/system/zipfileset.py:
976         * Scripts/webkitpy/common/system/zipfileset_unittest.py:
977
978 2011-01-30  Balazs Kelemen  <kbalazs@webkit.org>
979
980         Reviewed by Csaba Osztrogonác.
981
982         [Qt][WK2]REGRESSION (r76991): Fix build errors
983         https://bugs.webkit.org/show_bug.cgi?id=53400
984
985         Revert the temporary build fix (http://trac.webkit.org/changeset/77088)
986         and remove WebKit2Prefix.h from the build.
987         * MiniBrowser/qt/MiniBrowser.pro:
988
989 2011-01-30  Csaba Osztrogonác  <ossy@webkit.org>
990
991         Unreviewed.
992
993         [Qt][WK2] Buildfix.
994
995         * MiniBrowser/qt/MiniBrowser.pro:
996
997 2011-01-28  Simon Fraser  <simon.fraser@apple.com>
998
999         Reviewed by Adam Roben.
1000         
1001         define NOMINMAX when building ImageDiff, as we do elsewhere.
1002
1003         Add various clampToInt() methods to MathExtras.h
1004         https://bugs.webkit.org/show_bug.cgi?id=52910
1005
1006         * DumpRenderTree/win/ImageDiffCommon.vsprops:
1007
1008 2011-01-28  Maciej Stachowiak  <mjs@apple.com>
1009
1010         Reviewed by Darin Adler.
1011
1012         WebKitTestRunner needs layoutTestController.setPOSIXLocale
1013         https://bugs.webkit.org/show_bug.cgi?id=42682
1014
1015         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1016         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1017         (WTR::InjectedBundle::resetLocalSettings):
1018         (WTR::InjectedBundle::didReceiveMessage):
1019         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1020         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1021         (WTR::LayoutTestController::setPOSIXLocale):
1022         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1023
1024 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
1025  
1026          Reviewed by Mihai Parparita.
1027  
1028          test-webkitpy: fix webkitpy.layout_tests.port.mac_unittest.MacTest.test_skipped_file_paths
1029  
1030          This patch re-enables this test and changes it to
1031          handle all of the mac platform versions, not just the one
1032          it is running on.
1033  
1034          https://bugs.webkit.org/show_bug.cgi?id=53356
1035  
1036          * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1037  
1038 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
1039
1040         Unreviewed, build fix.
1041
1042         Take two. The fix in 77023 didn't work, because we were
1043         still calling path.abspath_to_uri, which calls _cygpath under
1044         the covers, and it appears the cygpath on the bots does
1045         something different than it does on my machine. This patch
1046         removes the calls to path.abspath_to_uri, so it should be safe.
1047         If it doesn't work, I'll roll it out along with r76982 and 77023.
1048
1049         https://bugs.webkit.org/show_bug.cgi?id=53126
1050
1051         * Scripts/webkitpy/layout_tests/port/test.py:
1052
1053 2011-01-28  David Kilzer  <ddkilzer@apple.com>
1054
1055         <rdar://problem/8930699> build-webkit gives a bogus warning with newer versions of Xcode 
1056         <http://webkit.org/b/53353>
1057
1058         Reviewed by Mark Rowe.
1059
1060         * Scripts/webkitdirs.pm:
1061         (checkRequiredSystemConfig): Check the Xcode marketing version
1062         in addition to the DevCoreTools build version before complaining
1063         about an old version of Xcode.  Also make the Mac OS X version
1064         check use Perl's built-in version string comparitor.
1065
1066 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
1067
1068         Unreviewed, build fix.
1069
1070         Work around breakage on Win 7 Release bot caused by r76982
1071         and the fact that windows ports use "file:////" instead of
1072         "file:///". Ideally the test code should be isolated from
1073         this, but it isn't yet. Will fix properly in a bit.
1074
1075         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
1076
1077 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
1078
1079         Reviewed by Tony Chang.
1080
1081         new-run-webkit-tests: change worker model values to
1082         "old-inline", "old-threads" in preparation for test_runner2 /
1083         multiprocessing changes.
1084
1085         https://bugs.webkit.org/show_bug.cgi?id=53156
1086
1087         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1088         * Scripts/webkitpy/layout_tests/port/base.py:
1089         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1090         * Scripts/webkitpy/layout_tests/port/mac.py:
1091         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1092
1093 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
1094
1095         Reviewed by Tony Chang.
1096
1097         committers.py - add an IRC nickname for dpranke
1098         https://bugs.webkit.org/show_bug.cgi?id=53335
1099
1100         * Scripts/webkitpy/common/config/committers.py:
1101
1102 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
1103
1104         Reviewed by Tony Chang.
1105
1106         new-run-webkit-tests: add a "mock DRT" port implementation
1107         and a separate class that emulates what we expect the
1108         DumpRenderTree behavior to be.
1109
1110         This will eventually replace port/dryrun.py and allow us to get
1111         better test coverage of the new-run-webkit-tests code as well as
1112         a reference for what new-run-webkit-tests expects from DRT.
1113
1114         This is the first attempt at this, and it is pretty bare-boned. It
1115         really only has been tested on the 'mac' port (and a little on
1116         the 'chromium-mac' port.
1117
1118         https://bugs.webkit.org/show_bug.cgi?id=53126
1119
1120         * Scripts/webkitpy/common/system/filesystem_mock.py:
1121         * Scripts/webkitpy/layout_tests/port/dryrun.py:
1122         * Scripts/webkitpy/layout_tests/port/factory.py:
1123         * Scripts/webkitpy/layout_tests/port/mock_drt.py: Added.
1124         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Added.
1125         * Scripts/webkitpy/layout_tests/port/test.py:
1126
1127 2011-01-28  Pratik Solanki  <psolanki@apple.com>
1128
1129         Unreviewed. Removing .swp file checked in by mistake.
1130
1131         * Scripts/.webkitdirs.pm.swp: Removed.
1132
1133 2011-01-28  Pratik Solanki  <psolanki@apple.com>
1134
1135         Reviewed by David Kilzer.
1136
1137         Space not necessary for undefined feature
1138         https://bugs.webkit.org/show_bug.cgi?id=53317
1139
1140         * Scripts/build-webkit:
1141
1142 2011-01-28  Chang Shu  <chang.shu@nokia.com>
1143
1144         Reviewed by Andreas Kling.
1145
1146         Reset NetworkAccessManager to clean up credentials from previous tests.
1147         This change causes no performance overhead either.
1148         https://bugs.webkit.org/show_bug.cgi?id=36688
1149
1150         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1151         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1152         (WebCore::DumpRenderTree::open):
1153         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1154
1155 2011-01-28  Zoltan Horvath  <zoltan@webkit.org>
1156
1157         Reviewed by Andreas Kling.
1158
1159         [Qt] Add Zoom Text Only action to MiniBrowser
1160         https://bugs.webkit.org/show_bug.cgi?id=53297
1161
1162         Add Zoom Text Only action to MiniBrowser's view menu, change zoom levels to avoid unnecessary divides.
1163
1164         * MiniBrowser/qt/BrowserWindow.cpp:
1165         (BrowserWindow::BrowserWindow):
1166         (BrowserWindow::zoomIn):
1167         (BrowserWindow::zoomOut):
1168         (BrowserWindow::resetZoom):
1169         (BrowserWindow::toggleZoomTextOnly):
1170         (BrowserWindow::applyZoom):
1171         * MiniBrowser/qt/BrowserWindow.h:
1172
1173 2011-01-28  Adam Barth  <abarth@webkit.org>
1174
1175         Reviewed by Eric Seidel.
1176
1177         Add webkit-patch roll-chromium-deps
1178         https://bugs.webkit.org/show_bug.cgi?id=53288
1179
1180         This command updates the Source/WebKit/chromium/DEPS file with the
1181         last-known good revision of Chromium (or a revision specified on the
1182         command line).  I'd eventually like to turn this into a SheriffBot
1183         command, but this is the first step.
1184
1185         This patch somewhat sprawled because I needed to move a bunch of code
1186         out of ChangeLog that should never have been there in the first place.
1187         Also, I had to fix a bug in MockUser in order to test the new command.
1188
1189         * Scripts/webkitpy/common/checkout/api.py:
1190         * Scripts/webkitpy/common/checkout/changelog.py:
1191         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1192         * Scripts/webkitpy/common/checkout/deps.py: Added.
1193         * Scripts/webkitpy/common/config/urls.py:
1194         * Scripts/webkitpy/tool/commands/__init__.py:
1195         * Scripts/webkitpy/tool/commands/download_unittest.py:
1196         * Scripts/webkitpy/tool/commands/roll.py: Added.
1197         * Scripts/webkitpy/tool/commands/roll_unittest.py: Added.
1198         * Scripts/webkitpy/tool/commands/upload_unittest.py:
1199         * Scripts/webkitpy/tool/mocktool.py:
1200         * Scripts/webkitpy/tool/steps/__init__.py:
1201         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py: Added.
1202         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
1203         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py: Added.
1204         * Scripts/webkitpy/tool/steps/suggestreviewers_unittest.py:
1205         * Scripts/webkitpy/tool/steps/updatechromiumdeps.py: Added.
1206         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
1207
1208 2011-01-27  Greg Coletta  <greg.coletta@nokia.com>
1209
1210         Reviewed by Laszlo Gombos.
1211
1212         Get rid of prefix header dependency for WebKit2 build system
1213         https://bugs.webkit.org/show_bug.cgi?id=50174
1214
1215         Change the style checker so that it enforces config.h include for
1216         WebKit2.
1217
1218         * Scripts/webkitpy/style/checker.py:
1219
1220 2011-01-27  Maciej Stachowiak  <mjs@apple.com>
1221
1222         Reviewed by Darin Adler.
1223
1224         execCommand("Paste") doesn't work in WebKitTestRunner
1225         https://bugs.webkit.org/show_bug.cgi?id=52785
1226
1227         Enable both of the settings needed to allow paste.
1228         
1229         * WebKitTestRunner/TestController.cpp:
1230         (WTR::TestController::resetStateToConsistentValues):
1231
1232 2011-01-27  Jacob Dinu  <dinu.jacob@nokia.com>
1233
1234         Reviewed by Andreas Kling.
1235
1236         [Qt] QtTestBrowser: User input lost when toggling use of QGraphicsView
1237         https://bugs.webkit.org/show_bug.cgi?id=48440
1238
1239         Preserve user input when toggling use of QGraphicsView
1240
1241         * QtTestBrowser/launcherwindow.cpp:
1242         (LauncherWindow::initializeView):
1243         (LauncherWindow::loadFinished):
1244         * QtTestBrowser/launcherwindow.h:
1245         * QtTestBrowser/mainwindow.cpp:
1246         (MainWindow::addressUrl):
1247         * QtTestBrowser/mainwindow.h:
1248
1249 2011-01-27  Dirk Pranke  <dpranke@chromium.org>
1250
1251         Reviewed by Mihai Parparita.
1252
1253         new-run-webkit-tests: turn off pixel tests correctly by default
1254         for webkit-based ports. r70013 (bug 47510) used
1255         port.set_option_default() to attempt to set default values, but
1256         that didn't work correctly. I have removed set_option_default
1257         for now since it was only being used in two places and in three
1258         useless unit tests. There is a separate bug open to fix the
1259         option parsing (48095), so this workaround is fine for now.
1260
1261         https://bugs.webkit.org/show_bug.cgi?id=53217
1262
1263         * Scripts/webkitpy/layout_tests/port/webkit.py:
1264         * Scripts/webkitpy/layout_tests/port/base.py:
1265         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1266
1267 2011-01-27  Balazs Kelemen  <kbalazs@webkit.org>
1268
1269         Rubber-stamped by Ariya Hidayat.
1270
1271         Trivial crash fix in WTR.
1272
1273         * WebKitTestRunner/TestController.cpp:
1274         (WTR::TestController::initialize): Increase the size
1275         of the vector by one to be able to store the null character.
1276
1277 2011-01-27  Balazs Kelemen  <kbalazs@webkit.org>
1278
1279         Reviewed by Csaba Osztrogonác.
1280
1281         [Qt][WK2] WTR should be initialized in the same way as DRT
1282         https://bugs.webkit.org/show_bug.cgi?id=53240
1283
1284         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
1285         (WTR::activateFonts): Added missing initialization steps.
1286
1287 2011-01-27  Joone Hur <joone.hur@collabora.co.uk>
1288
1289         Unreviewed. 
1290
1291         Adding myself to committers.py.
1292
1293         * Scripts/webkitpy/common/config/committers.py:
1294
1295 2011-01-27  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1296
1297         Reviewed by Csaba Osztrogonác.
1298
1299         [Qt] [Symbian] Move project files into Source
1300         https://bugs.webkit.org/show_bug.cgi?id=52891
1301
1302         Fix the Symbian build after the project files
1303         are moved to Source directory. On Symbian qmake
1304         needs to run in the same directory where the main
1305         pro files (WebKit.pro, Tools.pro) are located.
1306
1307         * Scripts/webkitdirs.pm: Change to the directory where the pro file
1308         is located before running qmake for Symbian. Qmake on Symbian
1309         does not properly honor the "-o" option, work it around by setting
1310         the name of the Makefile to bld.inf.
1311
1312 2011-01-27  Zoltan Horvath  <zoltan@webkit.org>
1313
1314         Reviewed by Andreas Kling.
1315
1316         [Qt] Add simple zooming features to MiniBrowser
1317         https://bugs.webkit.org/show_bug.cgi?id=53231
1318
1319         Add View menu and Zoom In, Zoom Out, Zoom Reset actions to MiniBrowser.
1320
1321         * MiniBrowser/qt/BrowserWindow.cpp:
1322         (BrowserWindow::BrowserWindow):
1323         (BrowserWindow::zoomIn):
1324         (BrowserWindow::zoomOut):
1325         (BrowserWindow::resetZoom):
1326         (BrowserWindow::updateUserAgentList):
1327         (BrowserWindow::applyZoom):
1328         * MiniBrowser/qt/BrowserWindow.h:
1329
1330 2011-01-26  Maciej Stachowiak  <mjs@apple.com>
1331
1332         Reviewed by Dan Bernstein.
1333
1334         WebKitTestRunner needs to support layoutTestController.evaluateInWebInspector
1335         https://bugs.webkit.org/show_bug.cgi?id=42319
1336         
1337         Add evaluateInWebInspector and other APIs needed for inspector tests to run.
1338
1339         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1340         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1341         (WTR::LayoutTestController::showWebInspector):
1342         (WTR::LayoutTestController::closeWebInspector):
1343         (WTR::LayoutTestController::evaluateInWebInspector):
1344         (WTR::LayoutTestController::setTimelineProfilingEnabled):
1345         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1346         * WebKitTestRunner/TestInvocation.cpp:
1347         (WTR::shouldOpenWebInspector):
1348         (WTR::TestInvocation::invoke):
1349         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
1350
1351 2011-01-26  Martin Robinson  <mrobinson@igalia.com>
1352
1353         Reviewed by Xan Lopez.
1354
1355         [GTK] Pixel dumps do not include scrollbars in output images
1356         https://bugs.webkit.org/show_bug.cgi?id=53216
1357
1358         Show scrollbars in pixel dumps. This will fix pixel dumps for tests
1359         that have scrollbars.
1360
1361         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
1362         (createBitmapContextFromWebView): Take the snapshot of the containing GtkScrolledWindow
1363         instead of the web view itself.
1364
1365 2011-01-26  Dirk Pranke  <dpranke@chromium.org>
1366
1367         Reviewed by Mihai Parparita.
1368
1369         Fix regression introduced in r76322 ... new-run-webkit-tests
1370         was attempting to save the image diff output as a UTF-8-encoded
1371         file.
1372
1373         https://bugs.webkit.org/show_bug.cgi?id=53210
1374
1375         * Scripts/webkitpy/layout_tests/port/webkit.py:
1376
1377 2011-01-26  Sheriff Bot  <webkit.review.bot@gmail.com>
1378
1379         Unreviewed, rolling out r76709.
1380         http://trac.webkit.org/changeset/76709
1381         https://bugs.webkit.org/show_bug.cgi?id=53194
1382
1383         "broke python tests on non-snowleopard platforms" (Requested
1384         by dpranke on #webkit).
1385
1386         * Scripts/webkitpy/layout_tests/port/factory.py:
1387         * Scripts/webkitpy/layout_tests/port/mock_drt.py: Removed.
1388         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Removed.
1389
1390 2011-01-26  Dirk Pranke  <dpranke@chromium.org>
1391
1392         Reviewed by Tony Chang.
1393
1394         new-run-webkit-tests: add a "mock DRT" port implementation
1395         and a separate class that emulates what we expect the
1396         DumpRenderTree behavior to be.
1397
1398         This will eventually replace port/dryrun.py and allow us to get
1399         better test coverage of the new-run-webkit-tests code as well as
1400         a reference for what new-run-webkit-tests expects from DRT.
1401
1402         This is the first attempt at this, and it is pretty bare-boned. It
1403         really only has been tested on the 'mac' port (and a little on
1404         the 'chromium-mac' port.
1405
1406         https://bugs.webkit.org/show_bug.cgi?id=53126
1407
1408         * Scripts/webkitpy/layout_tests/port/mock_drt.py: Added.
1409         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Added.
1410         * Scripts/webkitpy/layout_tests/port/factory.py:
1411
1412 2011-01-26  Xianzhu Wang  <wangxianzhu@google.com>
1413
1414         Reviewed by Tony Chang.
1415
1416         Add '--no-timeout' option to Chromium DRT to ease debugging.
1417         https://bugs.webkit.org/show_bug.cgi?id=52873
1418
1419         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1420         (main):
1421
1422 2011-01-26  Csaba Osztrogonác  <ossy@webkit.org>
1423
1424         Reviewed by Andreas Kling.
1425
1426         [Qt] Fix qt_minimal build
1427         https://bugs.webkit.org/show_bug.cgi?id=53172
1428
1429         * QtTestBrowser/locationedit.h:
1430
1431 2011-01-26  Mansi Mithal  <mansi.mithal@nokia.com>
1432
1433         Reviewed by Antonio Gomes.
1434
1435         QtTestBrowser should have a UI Setting to disable plugins
1436         https://bugs.webkit.org/show_bug.cgi?id=52408
1437         
1438         Added a new action item named "Disable Plugins"
1439         under the "Settings" menu. 
1440
1441         * QtTestBrowser/launcherwindow.cpp:
1442         (LauncherWindow::createChrome):
1443         (LauncherWindow::togglePlugins):
1444         * QtTestBrowser/launcherwindow.h:
1445
1446 2011-01-25  Patrick Gansterer  <paroga@webkit.org>
1447
1448         Reviewed by Adam Barth.
1449
1450         Move main CMakeLists.txt into Source directory
1451         https://bugs.webkit.org/show_bug.cgi?id=52888
1452
1453         * Scripts/webkitdirs.pm:
1454
1455 2011-01-25  Patrick Gansterer  <paroga@webkit.org>
1456
1457         Reviewed by Eric Seidel.
1458
1459         Improve label text in submit-to-ews
1460         https://bugs.webkit.org/show_bug.cgi?id=53130
1461
1462         * QueueStatusServer/templates/submittoews.html:
1463
1464 2011-01-25  Mansi Mithal  <mansi.mithal@nokia.com>
1465
1466         Reviewed by Antonio Gomes.
1467
1468         QtTestBrowser should have a UI Settings to prevent loading images
1469         https://bugs.webkit.org/show_bug.cgi?id=52409
1470         
1471         Added a new action item named "DisableAutoLoadImages"
1472         under the "Settings" menu 
1473
1474         * QtTestBrowser/launcherwindow.cpp:
1475         (LauncherWindow::createChrome):
1476         (LauncherWindow::toggleAutoLoadImages):
1477         * QtTestBrowser/launcherwindow.h:
1478
1479 2011-01-25  Dirk Pranke  <dpranke@chromium.org>
1480
1481         Reviewed by Tony Chang.
1482
1483         Minor bug fixes and cleanup for filesystem wrappers, port/* test
1484         classes, test_expectations.py. This change adds "test-win" and
1485         "test-mac" variants to the test port so that we can better test
1486         rebaselining, and adds a MockUser() object for reuse in testing.
1487
1488         https://bugs.webkit.org/show_bug.cgi?id=53036
1489
1490         * Scripts/webkitpy/common/system/filesystem.py:
1491         * Scripts/webkitpy/common/system/filesystem_mock.py:
1492         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1493         * Scripts/webkitpy/layout_tests/port/factory.py:
1494         * Scripts/webkitpy/layout_tests/port/base.py:
1495         * Scripts/webkitpy/layout_tests/port/test.py:
1496         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1497         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
1498         * Scripts/webkitpy/tool/mocktool.py:
1499
1500 2011-01-25  Tony Chang  <tony@chromium.org>
1501
1502         Reviewed by Dimitri Glazkov.
1503
1504         [chromium] remove unused layoutTestController callback
1505         https://bugs.webkit.org/show_bug.cgi?id=53103
1506
1507         This method is used by a test_shell_test, but not needed by DRT.
1508
1509         * DumpRenderTree/chromium/LayoutTestController.cpp:
1510         (LayoutTestController::LayoutTestController):
1511         * DumpRenderTree/chromium/LayoutTestController.h:
1512
1513 2011-01-25  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1514
1515         Reviewed by Andreas Kling.
1516
1517         [GTK] Remove 64 bits release bot from the buildbot master
1518         https://bugs.webkit.org/show_bug.cgi?id=52899
1519
1520         Removes the 64 bits release slave from the buildbot configuration,
1521         so that we can use it as an EWS.
1522
1523         * BuildSlaveSupport/build.webkit.org-config/config.json:
1524
1525 2011-01-24  Maciej Stachowiak  <mjs@apple.com>
1526
1527         Reviewed by Dan Bernstein.
1528
1529         Implement database quota callback to fix storage tests on WebKit2 bot
1530         https://bugs.webkit.org/show_bug.cgi?id=53064
1531
1532         * WebKitTestRunner/TestController.cpp:
1533         (WTR::exceededDatabaseQuota):
1534         (WTR::TestController::createOtherPage):
1535         (WTR::TestController::initialize):
1536
1537 2011-01-24  Maciej Stachowiak  <mjs@apple.com>
1538
1539         Reviewed by Anders Carlsson.
1540
1541         Use designated temp directory for the database for WebKit2
1542         https://bugs.webkit.org/show_bug.cgi?id=53052
1543         
1544         Adopt the new WK2 API for this.
1545
1546         * WebKitTestRunner/TestController.cpp:
1547         (WTR::TestController::libraryPathForTesting):
1548         (WTR::TestController::initialize):
1549         * WebKitTestRunner/TestController.h:
1550         * WebKitTestRunner/mac/TestControllerMac.mm:
1551         (WTR::TestController::platformLibraryPathForTesting):
1552         * WebKitTestRunner/qt/TestControllerQt.cpp:
1553         (WTR::TestController::platformLibraryPathForTesting):
1554         * WebKitTestRunner/win/TestControllerWin.cpp:
1555         (WTR::TestController::platformLibraryPathForTesting):
1556
1557 2011-01-24  Lucas Forschler  <lforschler@apple.com>
1558
1559         Reviewed by Stephanie Lewis.
1560
1561         Add a new Leopard test bot.
1562
1563         * BuildSlaveSupport/build.webkit.org-config/config.json:
1564
1565 2011-01-24  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1566
1567         Reviewed by Adam Barth.
1568
1569         Add EFL Builder to core waterfall
1570         https://bugs.webkit.org/show_bug.cgi?id=52704
1571
1572         Add EFL Builder to the core waterfall again.
1573
1574         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1575         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1576
1577 2011-01-24  Xianzhu Wang  <wangxianzhu@google.com>
1578
1579         Reviewed by Tony Chang.
1580
1581         new-run-webkit-tests fails to start HTTP server if there are proxy settings
1582         https://bugs.webkit.org/show_bug.cgi?id=52872
1583
1584         Force disabling proxy to resolve the problem.
1585
1586         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
1587         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
1588
1589 2011-01-24  Andreas Kling  <kling@webkit.org>
1590
1591         Reviewed by Darin Adler.
1592
1593         check-webkit-style: Update exemptions following Source/ move.
1594         https://bugs.webkit.org/show_bug.cgi?id=53017
1595
1596         * Scripts/webkitpy/style/checker.py:
1597         * Scripts/webkitpy/style/checker_unittest.py:
1598
1599 2011-01-24  Andras Becsi  <abecsi@webkit.org>
1600
1601         Rubber-stamped by Csaba Osztrogonác.
1602
1603         [Qt] Move project files into Source
1604         https://bugs.webkit.org/show_bug.cgi?id=52891
1605
1606         * DumpRenderTree/qt/ImageDiff.pro: Add missing "Source" to WebKit.pri path
1607
1608 2011-01-24  Mikhail Naganov  <mnaganov@chromium.org>
1609
1610         Reviewed by Yury Semikhatsky.
1611
1612         Web Inspector: Find duplicate strings in localizedStrings.js
1613
1614         https://bugs.webkit.org/show_bug.cgi?id=53005
1615
1616         * Scripts/check-inspector-strings:
1617
1618 2011-01-24  Zoltan Horvath  <zoltan@webkit.org>
1619
1620         Reviewed by Andreas Kling.
1621
1622         [Qt] Regroup MiniBrowser's menubar and add open file action
1623         https://bugs.webkit.org/show_bug.cgi?id=53000
1624
1625         Add File and Develop menu to MiniBrowser's menubar and add open file action to File menu.
1626
1627         * MiniBrowser/qt/BrowserWindow.cpp:
1628         (BrowserWindow::BrowserWindow):
1629         (BrowserWindow::openFile):
1630         (BrowserWindow::~BrowserWindow):
1631         * MiniBrowser/qt/BrowserWindow.h:
1632
1633 2011-01-24  Csaba Osztrogonác  <ossy@webkit.org>
1634
1635         Unreviewed fix after r76496
1636
1637         [Qt] Move project files into Source
1638         https://bugs.webkit.org/show_bug.cgi?id=52891
1639
1640         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Remove unnecessary "Source" from the path.
1641         * BuildSlaveSupport/built-product-archive: Remove unnecessary "Source" from the path.
1642         * Scripts/webkitdirs.pm: Add the accidentally removed slash to the path.
1643
1644 2011-01-24  Andras Becsi  <abecsi@webkit.org>
1645
1646         Reviewed by Csaba Osztrogonác.
1647
1648         [Qt] Move project files into Source
1649         https://bugs.webkit.org/show_bug.cgi?id=52891
1650
1651         * DerivedSources.pro: Renamed from DerivedSources.pro.
1652         * DumpRenderTree/qt/DumpRenderTree.pro:
1653         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1654         * MiniBrowser/DerivedSources.pro:
1655         * MiniBrowser/qt/MiniBrowser.pro:
1656         * QtTestBrowser/QtTestBrowser.pro:
1657         * Scripts/webkitdirs.pm:
1658         * Tools.pro: Added.
1659         * WebKitTestRunner/DerivedSources.pro:
1660         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1661         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1662
1663 2011-01-22  Geoffrey Garen  <ggaren@apple.com>
1664
1665         Reviewed by Dan Bernstein.
1666
1667         Beefed up --threaded mode to catch even more kinds of errors.
1668         https://bugs.webkit.org/show_bug.cgi?id=52971
1669
1670         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Use a shared
1671         context group to force JSC to mark multiple threads. (This used to be
1672         the default, but it changed in SnowLeopard.)
1673         (runJavaScriptThread): Do more locking and unlocking, and more allocation,
1674         to give threading mistakes more chances to show themselves.
1675         (startJavaScriptThreads):
1676         (stopJavaScriptThreads):
1677
1678 2011-01-22  Robert Hogan  <robert@webkit.org>
1679
1680         Reviewed by Andreas Kling.
1681
1682         [Qt] Support layoutTestController.addURLToRedirect()
1683         https://bugs.webkit.org/show_bug.cgi?id=52956
1684
1685         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1686         (LayoutTestController::addURLToRedirect):
1687         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1688
1689 2011-01-22  Robert Hogan  <robert@webkit.org>
1690
1691         Reviewed by Kenneth Rohde Christiansen.
1692
1693         [Qt] REGRESSION (r72360): http/tests/security/aboutBlank/xss-DENIED-* tests fail
1694         https://bugs.webkit.org/show_bug.cgi?id=49802
1695
1696         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1697         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1698         (WebCore::DumpRenderTree::open):
1699
1700 2011-01-21  Adam Barth  <abarth@webkit.org>
1701
1702         Reviewed by Maciej Stachowiak.
1703
1704         Disable mac_unittest.py that fails on some of the Mac bots
1705         https://bugs.webkit.org/show_bug.cgi?id=52947
1706
1707         As noted in the comment, this test does not appear to be correct
1708         because the function this test is testing returns different results
1709         depending on which flavor of Mac the test is run on.  This patch
1710         disable the test.  Hopefully we can re-enable the test once we've
1711         probably insulated the test from its environment.
1712
1713         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1714
1715 2011-01-21  Dirk Pranke  <dpranke@chromium.org>
1716
1717         Reviewed by Mihai Parparita.
1718
1719         Fix bug introduced in r76322 that caused NRWT to not actually
1720         read the Skipped files properly.
1721
1722         https://bugs.webkit.org/show_bug.cgi?id=52771
1723
1724         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1725         * Scripts/webkitpy/layout_tests/port/webkit.py:
1726         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1727
1728 2011-01-21  Sam Weinig  <sam@webkit.org>
1729
1730         Reviewed by Geoffrey Sean Garen and Mark Rowe.
1731
1732         WebKitTestRunner needs the HOME environment variable to be set.
1733         <rdar://problem/8896573>
1734
1735         * Scripts/old-run-webkit-tests: Set the HOME environment variable if
1736         it exists.
1737
1738 2011-01-21  Dirk Pranke  <dpranke@chromium.org>
1739
1740         Reviewed by Eric Seidel.
1741
1742         Suppress a few remaining integration tests so that none of the
1743         layout_test unit tests ever read from the filesystem or launch
1744         subprocesses that aren't part of the unit tests.
1745
1746         Also fix a minor bug in the printing unit tests that was
1747         incorrectly relying on sys.argv.
1748
1749         https://bugs.webkit.org/show_bug.cgi?id=52863
1750
1751         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1752         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1753         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1754
1755 2011-01-21  Darin Adler  <darin@apple.com>
1756
1757        Fix Mac build.
1758
1759         * MiniBrowser/mac/BrowserWindowController.m:
1760         (-[BrowserWindowController awakeFromNib]): Pass 0 for runModal function.
1761
1762 2011-01-20  Darin Adler  <darin@apple.com>
1763
1764         Reviewed by Dan Bernstein.
1765
1766         WebKit2: Implement showModalDialog
1767         https://bugs.webkit.org/show_bug.cgi?id=52855
1768
1769         This fixes WebKitTestRunner to compile, but more work is probably
1770         needed to get it to pass the tests.
1771
1772         * WebKitTestRunner/TestController.cpp:
1773         (WTR::TestController::runModal): Added. Calls through to the
1774         platform-specific version of runModal.
1775         (WTR::TestController::createOtherPage): Changed to be a private
1776         static member function so it can refer to runModal, which is
1777         a private static member function.
1778         (WTR::TestController::initialize): Pass 0 for the runModal
1779         function since we don't need to run the main window modal.
1780         I suspect this is wrong and will need to change.
1781         * WebKitTestRunner/TestController.h: Added declarations for
1782         the functions added above.
1783         * WebKitTestRunner/mac/TestControllerMac.mm:
1784         (WTR::TestController::runModal): Added. Untested implementation.
1785         * WebKitTestRunner/qt/TestControllerQt.cpp:
1786         (WTR::TestController::runModal): Added.
1787         * WebKitTestRunner/win/TestControllerWin.cpp:
1788         (WTR::TestController::runModal): Added.
1789
1790 2011-01-21  Eric Seidel  <eric@webkit.org>
1791
1792         Reviewed by Adam Barth.
1793
1794         Split Host object off from WebKitPatch for easier re-use
1795         https://bugs.webkit.org/show_bug.cgi?id=52284
1796
1797         new-run-webkit-tests and other tools are eventually going to want one of these.
1798         Basically you need to inherit from this class if you want to pretend to be a
1799         self.tool object for Steps/Commands.
1800
1801         * Scripts/webkitpy/common/host.py: Added.
1802         * Scripts/webkitpy/tool/main.py:
1803
1804 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1805
1806         Reviewed by Adam Barth.
1807
1808         Disable the tests that start and stop the http server and web
1809         server, so that we don't have to worry about port collisions on
1810         the bots.
1811
1812         https://bugs.webkit.org/show_bug.cgi?id=52861
1813
1814         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1815
1816 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1817
1818         Reviewed by Eric Seidel.
1819
1820         nrwt: rewrite google_chrome_unittest to use mock filesystem.
1821         
1822         https://bugs.webkit.org/show_bug.cgi?id=52772
1823         
1824         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
1825
1826 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1827
1828         Reviewed by Eric Siedel.
1829
1830         nrwt: clean up almost all remaining port references, remove
1831         unnecessary import clauses. The only remaining references are
1832         in places where a mock filesystem makes no sense or can't be
1833         used, and in one routine in port/google_chrome_unittest that
1834         I'll rewrite in a separate patch.
1835
1836         https://bugs.webkit.org/show_bug.cgi?id=52771
1837
1838         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1839         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1840         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1841         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1842         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1843         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1844         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1845         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
1846         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
1847         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
1848         * Scripts/webkitpy/layout_tests/port/gtk.py:
1849         * Scripts/webkitpy/layout_tests/port/mac.py:
1850         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1851         * Scripts/webkitpy/layout_tests/port/qt.py:
1852         * Scripts/webkitpy/layout_tests/port/webkit.py:
1853         * Scripts/webkitpy/layout_tests/port/win.py:
1854         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
1855
1856 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1857
1858         Reviewed by Mihai Parparita.
1859
1860         remove fs refs from run_webkit_tests, rebaseline_chromium_webkit_tests
1861
1862         https://bugs.webkit.org/show_bug.cgi?id=52762
1863
1864         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1865         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1866
1867 2011-01-20  Tony Chang  <tony@chromium.org>
1868
1869         Reviewed by Ojan Vafai.
1870
1871         [chromium] fix the paths used for the rebaseline tool
1872         https://bugs.webkit.org/show_bug.cgi?id=52857
1873
1874         Some of the bots were renamed so the path to grab the results zip
1875         file has changed.
1876
1877         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1878
1879 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1880
1881         Reviewed by Tony Chang.
1882
1883         Fix bug introduced in r72688 / bug 52768 that broke the
1884         generation of the output filename links in the results.html
1885         output. Apparently none of the unit tests actually checked to
1886         make sure the generated links were correct :(
1887
1888         https://bugs.webkit.org/show_bug.cgi?id=52854
1889
1890         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1891         * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
1892
1893 2011-01-20  Alexey Proskuryakov  <ap@apple.com>
1894
1895         Reviewed by Darin Adler.
1896
1897         https://bugs.webkit.org/show_bug.cgi?id=52849
1898         Make window.print work with WebKit2
1899
1900         * MiniBrowser/mac/BrowserWindowController.m:
1901         (-[BrowserWindowController awakeFromNib]):
1902         * WebKitTestRunner/TestController.cpp:
1903         (WTR::createOtherPage):
1904         (WTR::TestController::initialize):
1905         Added zeroes to WKPageUIClient structures to avoid build failures.
1906
1907 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1908
1909         Reviewed by Eric Seidel.
1910
1911         nrwt: remove fs refs from printing, test_failures, test_expectations, text_diff
1912
1913         https://bugs.webkit.org/show_bug.cgi?id=52756
1914
1915         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1916         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1917         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1918         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
1919         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1920         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
1921
1922 2011-01-20  Mansi Mithal  <mansi.mithal@nokia.com>
1923
1924         Reviewed by Antonio Gomes.
1925
1926         QtTestBrowser should have a seperate menu for Settings
1927         https://bugs.webkit.org/show_bug.cgi?id=52817
1928         
1929         Added a new menu item named "Settings"
1930         and moved the "Enable interrupting js scripts" and "Enable js pop up windows" under the "Settings" menu 
1931
1932         * QtTestBrowser/launcherwindow.cpp:
1933         (LauncherWindow::createChrome):
1934
1935 2011-01-20  Sam Weinig  <sam@webkit.org>
1936
1937         Reviewed by John Sullivan.
1938
1939         Update update-webkit-localizable-strings with new path to WebKit.
1940
1941         * Scripts/update-webkit-localizable-strings:
1942
1943 2011-01-20  James Robinson  <jamesr@chromium.org>
1944
1945         Reviewed by Darin Fisher.
1946
1947         Implement mozilla's requestAnimationFrame API
1948         https://bugs.webkit.org/show_bug.cgi?id=51218
1949
1950         Chromium DumpRenderTree support for window.webkitRequestAnimationFrame.
1951
1952         * DumpRenderTree/chromium/WebViewHost.cpp:
1953         (invokeScheduleComposite):
1954         (WebViewHost::scheduleAnimation):
1955         (WebViewHost::paintInvalidatedRegion):
1956         * DumpRenderTree/chromium/WebViewHost.h:
1957
1958 2011-01-20  Maciej Stachowiak  <mjs@apple.com>
1959
1960         Reviewed by Adam Roben.
1961
1962         WebKitTestRunner needs to support layoutTestController.evaluateScriptInIsolatedWorld
1963         https://bugs.webkit.org/show_bug.cgi?id=42327
1964
1965         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm: Add support
1966         for methods that take their normal arguments but also a JSContextRef.
1967         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: IDL definition
1968         for evaluateScriptInIsolatedWorld.
1969         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1970         (WTR::InjectedBundlePage::didClearWindowForFrame): Set a magic variable only if
1971         this call is for an isolated world.
1972         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1973         (WTR::worldMap): Helper to create a world map.
1974         (WTR::LayoutTestController::worldIDForWorld): Map from an ID to a world.
1975         (WTR::LayoutTestController::evaluateScriptInIsolatedWorld): The newly
1976         added LayoutTestController API.
1977         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1978
1979 2011-01-19  Adam Roben  <aroben@apple.com>
1980
1981         Convert paths in environment variables back to msys-style inside commit-log-editor
1982
1983         When this script gets run from inside git commit, msys-style paths in the environment will
1984         have been turned into Windows-style paths with forward slashes. This screws up functions
1985         like File::Spec->rel2abs, which seem to rely on $PWD having an msys-style path. We convert
1986         the paths back to msys-style before doing anything else.
1987
1988         Fixes <http://webkit.org/b/48527> commit-log-editor uses full paths for section headers when
1989         using msysgit's Perl and multiple ChangeLogs have been edited
1990
1991         Reviewed by David Kilzer.
1992
1993         * Scripts/commit-log-editor: Call fixEnvironment before doing anything else.
1994         (fixEnvironment): Added. When run in msys in conjunction with git (i.e., when invoked from
1995         inside git commit), convert Windows-style paths in the environment back to msys-style paths.
1996
1997 2011-01-20  Zoltan Horvath  <zoltan@webkit.org>
1998
1999         [Win] Unreviewed build fix after r76248.
2000
2001         * DumpRenderTree/ForwardingHeaders/wtf/FastAllocBase.h: Added.
2002
2003 2011-01-20  Zoltan Horvath  <zoltan@webkit.org>
2004
2005         Reviewed by Csaba Osztrogonác.
2006
2007         Refactoring of the custom allocation framework
2008         https://bugs.webkit.org/show_bug.cgi?id=49897
2009
2010         Inheriting from FastAllocBase can result in objects getting larger (bug #33896, #46589).
2011         The modification replaces Noncopyable and FastAllocBase classes and these inherits with their
2012         equivalent macro implementation at the necessary places.
2013 2011-01-20  Yi Shen  <yi.4.shen@nokia.com>
2014
2015         Unreviewed. 
2016
2017         Adding myself to committers.py.
2018
2019         * Scripts/webkitpy/common/config/committers.py:
2020
2021 2011-01-20  Adam Barth  <abarth@webkit.org>
2022
2023         Reviewed by Tony Chang.
2024
2025         Chromium builders don't delete unversioned directories when DEPS change
2026         https://bugs.webkit.org/show_bug.cgi?id=52745
2027
2028         If we pass this option to gclient sync, gclient will delete directories
2029         that are no longer part of DEPS instead of leaving them around to
2030         confuse us later.  Apparently, the downstream buildbots use this option
2031         already.
2032
2033         * Scripts/update-webkit-chromium:
2034
2035 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2036
2037         Unreviewed, build fix - I pulled this patch in to fix an issue
2038         revealed by r76195 running on some new bots). Also fix a couple
2039         of other issues revealed in testing.
2040
2041         nrwt: remove fs refs from layout_package/json*
2042
2043         https://bugs.webkit.org/show_bug.cgi?id=52754
2044
2045         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2046         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
2047         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
2048         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2049         * Scripts/webkitpy/layout_tests/port/base.py:
2050
2051 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2052
2053         Unreviewed, build fix.
2054
2055         Fix a couple of minor bugs discovered while bringing up new bots
2056         for testing.
2057
2058         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2059         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2060
2061 2011-01-19  James Robinson  <jamesr@chromium.org>
2062
2063         Unreviewed, rolling out r76194.
2064         http://trac.webkit.org/changeset/76194
2065         https://bugs.webkit.org/show_bug.cgi?id=51218
2066
2067         Caused mysterious compile failure on the chromium win
2068         build.webkit.org bots
2069
2070         * DumpRenderTree/chromium/WebViewHost.cpp:
2071         (WebViewHost::paintInvalidatedRegion):
2072         * DumpRenderTree/chromium/WebViewHost.h:
2073
2074 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2075
2076         Reviewed by Mihai Parparita.
2077
2078         remove fs refs from test_runner, dump_render_tree_thread
2079
2080         https://bugs.webkit.org/show_bug.cgi?id=52753
2081
2082         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2083         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2084         * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
2085         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2086
2087 2011-01-19  James Robinson  <jamesr@chromium.org>
2088
2089         Reviewed by Darin Fisher.
2090
2091         Implement mozilla's requestAnimationFrame API
2092         https://bugs.webkit.org/show_bug.cgi?id=51218
2093
2094         Chromium DumpRenderTree support for window.webkitRequestAnimationFrame.
2095
2096         * DumpRenderTree/chromium/WebViewHost.cpp:
2097         (invokeScheduleComposite):
2098         (WebViewHost::scheduleAnimation):
2099         (WebViewHost::paintInvalidatedRegion):
2100         * DumpRenderTree/chromium/WebViewHost.h:
2101
2102 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2103
2104         Unreviewed, build fix.
2105
2106         Fix a few incorrect "self._filesystem" references introduced in
2107         r76184.
2108
2109         * Scripts/webkitpy/layout_tests/port/chromium.py:
2110         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2111
2112 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2113
2114         Reviewed by Mihai Parparita.
2115
2116         add a .sep property, abspath(), isabs(), mtime(), and
2117         open_text_file_for_writing() to filesystem modules. Some of
2118         these properties are not needed in this patch but will be needed
2119         in subsequent patches (I'm doing this to avoid having to track
2120         multiple versions of a single file).
2121
2122         Also, change most of the port/* modules to use the filesystem
2123         objects instead of referencing the filesystem directly.
2124
2125         https://bugs.webkit.org/show_bug.cgi?id=52748
2126
2127         * Scripts/webkitpy/common/system/filesystem.py:
2128         * Scripts/webkitpy/common/system/filesystem_mock.py:
2129         * Scripts/webkitpy/layout_tests/port/__init__.py:
2130         * Scripts/webkitpy/layout_tests/port/base.py:
2131         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2132         * Scripts/webkitpy/layout_tests/port/chromium.py:
2133         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2134         * Scripts/webkitpy/layout_tests/port/config.py:
2135         * Scripts/webkitpy/layout_tests/port/test.py:
2136         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
2137
2138 2011-01-19  Maciej Stachowiak  <mjs@apple.com>
2139
2140         Reviewed by Anders Carlsson.
2141
2142         If resetting between tests times out, treat it as a WebProcess crash
2143         https://bugs.webkit.org/show_bug.cgi?id=52757
2144
2145         * WebKitTestRunner/TestController.cpp:
2146         (WTR::TestController::runTest):
2147
2148 2011-01-19  Alexey Proskuryakov  <ap@apple.com>
2149
2150         Reviewed by Darin Adler.
2151
2152         https://bugs.webkit.org/show_bug.cgi?id=52739
2153         Make it possible for a WebKit2 client to print headers and footers
2154
2155         Added dummy implementations for new printing UIClient calls.
2156
2157         * MiniBrowser/mac/BrowserWindowController.m:
2158         (-[BrowserWindowController awakeFromNib]):
2159         * WebKitTestRunner/TestController.cpp:
2160         (WTR::createOtherPage):
2161         (WTR::TestController::initialize):
2162
2163 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2164
2165         Reviewed by Ojan Vafai.
2166
2167         Change webkitpy/layout_tests/port/test.py to use the
2168         in-memory filesystem for cleaner unit testing. This
2169         change allows us to kill a lot of code that was
2170         specific to the test port, at the cost of being a
2171         little less clear about how things would work if
2172         you didn't have a filesystem.
2173
2174         https://bugs.webkit.org/show_bug.cgi?id=52605
2175
2176         * Scripts/webkitpy/layout_tests/port/test.py:
2177
2178 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2179
2180         Unreviewed, build fix.
2181
2182         Fix test failure caused by committing attachment 79368 instead
2183         of attachment 79461 on bug 52604.
2184
2185         * Scripts/webkitpy/common/system/filesystem_mock.py:
2186
2187 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2188
2189         Reviewed by Mihai Parparita.
2190
2191         new-run-webkit-tests: remove use of os.walk, use mock filesystem for better
2192         unit testing. os.walk() is too much of a hassle to implement on
2193         top of the in-memory mock filesystem and adding the necessary
2194         interface to files_under() gives clients a cleaner API anyway
2195         (for this particular usage model).
2196
2197         https://bugs.webkit.org/show_bug.cgi?id=52691
2198
2199         * Scripts/webkitpy/common/system/filesystem.py:
2200         * Scripts/webkitpy/common/system/filesystem_mock.py:
2201         * Scripts/webkitpy/layout_tests/port/test_files.py:
2202         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
2203
2204 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2205
2206         Reviewed by Tony Chang.
2207
2208         Change more modules in the layout-tests code to use the
2209         filesystem wrapper for cleaner unit testing.
2210
2211         This patch also adds the glob() wrapper to the filesystem
2212         abstraction.
2213         
2214         https://bugs.webkit.org/show_bug.cgi?id=52604
2215
2216         * Scripts/webkitpy/layout_tests/port/test_files.py:
2217         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
2218         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
2219         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2220         * Scripts/webkitpy/common/system/filesystem.py:
2221         * Scripts/webkitpy/common/system/filesystem_mock.py:
2222
2223 2011-01-19  Levi Weintraub  <leviw@chromium.org>
2224
2225         Unreviewed.
2226
2227         Updating my email addresses and irc nick.
2228
2229         * Scripts/webkitpy/common/config/committers.py:
2230
2231 2011-01-19  Tony Chang  <tony@chromium.org>
2232
2233         Reviewed by Mihai Parparita.
2234
2235         [chromium] [linux] if check-sys-deps fails, output the failure reason
2236         https://bugs.webkit.org/show_bug.cgi?id=52671
2237
2238         * Scripts/webkitpy/common/system/executive_mock.py: Add support for
2239             error handler functions.
2240         * Scripts/webkitpy/layout_tests/port/chromium.py:
2241             output the error text from --check-sys-deps
2242         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2243
2244 2011-01-19  Aparna Nandyal  <aparna.nand@wipro.com>
2245
2246         Reviewed by Andreas Kling.
2247
2248         [Qt] QtTestBrowser crashes when closing if Facebook is opened
2249         https://bugs.webkit.org/show_bug.cgi?id=52554
2250         
2251         QtNetworkAccessManager is created in a thread and set as
2252         member variable in QWebPage. When the thread is destroyed
2253         the object is still used. So fix will set the object to
2254         NULL once the thread is destroyed.
2255
2256         * QtTestBrowser/launcherwindow.cpp:
2257         (LauncherWindow::~LauncherWindow):
2258
2259 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
2260
2261         Rubber stamped by Csaba Osztrogonac
2262
2263         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: Removed unncessary inculde of WKStringCF.h
2264
2265 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
2266
2267         Reviewed by Tony Chang.
2268
2269         new-run-webkit-tests: add a --build-directory command line argument
2270
2271         Official Google Chrome builds use a non-standard build directory
2272         location. This patch adds a --build-directory argument that
2273         allows that location to be specified on the command line. Only
2274         Chromium-based builds will use this flag for now, but anyone can
2275         in the future.
2276
2277         There are no unit tests for this since it's difficult to test
2278         until mock filesystems are fully supported in the code. This was
2279         tested by hand for now.
2280
2281         https://bugs.webkit.org/show_bug.cgi?id=52694
2282
2283         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2284         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2285         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2286         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2287
2288 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
2289
2290         Not reviewed. Bot fix.
2291
2292         Remove an inadvertently committed debugging print.
2293
2294         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2295         (LayoutTestController::notifyDone):
2296
2297 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
2298
2299         Reviewed by Sam Weinig.
2300
2301         WebKitTestRunner should track loading more like DumpRenderTree
2302         https://bugs.webkit.org/show_bug.cgi?id=52692
2303
2304         Change load tracking to track the current top loading frame, in the manner of DumpRenderTree.
2305         This makes some tests that call notifyDone multiple times pass.
2306         
2307         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2308         (WTR::InjectedBundle::InjectedBundle):
2309         (WTR::InjectedBundle::done):
2310         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2311         (WTR::InjectedBundle::topLoadingFrame):
2312         (WTR::InjectedBundle::setTopLoadingFrame):
2313         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2314         (WTR::InjectedBundlePage::InjectedBundlePage):
2315         (WTR::InjectedBundlePage::stopLoading):
2316         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
2317         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
2318         (WTR::InjectedBundlePage::didFinishLoadForFrame):
2319         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
2320         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2321         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2322         (WTR::LayoutTestController::notifyDone):
2323         * WebKitTestRunner/TestController.cpp:
2324         (WTR::TestController::didReceiveMessageFromInjectedBundle):
2325
2326 2011-01-18  Mihai Parparita  <mihaip@chromium.org>
2327
2328         Reviewed by Kent Tamura.
2329
2330         [Chromium] NRWT looking for DRT binary in the wrong path on Mac
2331         https://bugs.webkit.org/show_bug.cgi?id=52678
2332         
2333         Update path now that WebKit is inside Source.
2334
2335         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2336
2337 2011-01-18  Robert Hogan  <robert@webkit.org>
2338
2339         Reviewed by Simon Hausmann.
2340
2341         [Qt] http/tests/incremental/slow-utf8-text.pl fails
2342         https://bugs.webkit.org/show_bug.cgi?id=44282
2343
2344         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2345         (WebCore::DumpRenderTree::dump):
2346
2347 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
2348
2349         Reviewed by Mihai Parparita.
2350
2351         Fix a small race condition that could cause the unit tests for
2352         new-run-webkit-tests to fail in a multithreaded environment.
2353         There was a small window in the code where one thread would
2354         check to see if a thread had raised an exception, do something,
2355         and then check to see if the thread was alive. If the other
2356         thread raised an exception and exited in between these two
2357         steps, the exception would be lost. Flipping the order of the
2358         two checks fixes the race, since we will now always check for an
2359         exception on the thread before exiting.
2360
2361         https://bugs.webkit.org/show_bug.cgi?id=51579
2362
2363         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
2364
2365 2011-01-18  Eric Seidel  <eric@webkit.org>
2366
2367         Reviewed by Adam Barth.
2368
2369         commit-queue dies when test archiving fails
2370         https://bugs.webkit.org/show_bug.cgi?id=52617
2371
2372         I looked at the machine and it had 10 archives already
2373         thus find_unused_name was returning None.  I've upped
2374         the limit to 100 (per bug) and tested the case where
2375         find_unused_name returns None (making archive return None).
2376
2377         * Scripts/webkitpy/common/system/workspace.py:
2378         * Scripts/webkitpy/common/system/workspace_unittest.py:
2379         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2380         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2381         * Scripts/webkitpy/tool/commands/queues.py:
2382
2383 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
2384
2385         Reviewed by Ojan Vafai.
2386
2387         Update rebaseline-chromium-webkit-tests unit tests to use a mock
2388         filesystem. Also fix a couple of "with" statements missed by
2389         r76050.
2390
2391         https://bugs.webkit.org/show_bug.cgi?id=52487
2392
2393         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
2394
2395 2011-01-18  Sergio Villar Senin  <svillar@igalia.com>
2396
2397         Reviewed by Martin Robinson.
2398
2399         [Gtk] Build fixes for gtk3 build
2400         https://bugs.webkit.org/show_bug.cgi?id=52648
2401
2402         * DumpRenderTree/gtk/EventSender.cpp:
2403         (beginDragWithFilesCallback):
2404
2405 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
2406
2407         Reviewed by Mihai Parparita.
2408
2409         Update rebaseline-chromium-webkit-tests to use filesystem objects
2410         instead of direct references to os.path, shutil, tempfile, etc.
2411
2412         This patch doesn't change anything, but will allow subsequent
2413         patches to change the unit tests to no longer use the real
2414         filesystem.
2415
2416         This patch adds a bunch more methods to the filesystem object as
2417         well.
2418
2419         https://bugs.webkit.org/show_bug.cgi?id=52482
2420
2421         * Scripts/webkitpy/common/system/filesystem.py:
2422         * Scripts/webkitpy/common/system/filesystem_mock.py:
2423         * Scripts/webkitpy/tool/commands/queues.py:
2424         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2425         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
2426
2427 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
2428
2429         Reviewed by Mihai Parparita.
2430
2431         new-run-webkit-tests shouldn't crash when you try to run a
2432         directory containing only skipped files.
2433
2434         https://bugs.webkit.org/show_bug.cgi?id=52478
2435         
2436         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2437         * Scripts/webkitpy/layout_tests/port/test.py:
2438         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2439
2440 2011-01-18  Adam Bergkvist  <adam.bergkvist@ericsson.com> and Martin Robinson  <mrobinson@igalia.com>
2441
2442         Reviewed by Gustavo Noronha Silva.
2443
2444         [GTK] The GTK+ EventSender needs support for beginDragWithFiles
2445         https://bugs.webkit.org/show_bug.cgi?id=40833
2446
2447         * DumpRenderTree/gtk/EventSender.cpp: Add a beginDragWithFiles implementation for the
2448         GTK+ event sender.
2449         (dragWithFilesDragDataGetCallback): Added.
2450         (dragWithFilesDragEndCallback): Added.
2451         (beginDragWithFilesCallback): Added.
2452
2453 2011-01-18  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2454
2455         Reviewed by Adam Barth.
2456
2457         ews: Add additional watcher to efl ews
2458         https://bugs.webkit.org/show_bug.cgi?id=52613
2459
2460         Add gyuyoung.kim@samsung.com to watcher list of efl-ews.
2461
2462         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2463
2464 2011-01-17  Tony Gentilcore  <tonyg@chromium.org>
2465
2466         Reviewed by Alexey Proskuryakov.
2467
2468         Fix some headers with missing or misspelled #ifndef guards
2469         https://bugs.webkit.org/show_bug.cgi?id=52545
2470
2471         * DumpRenderTree/chromium/TestEventPrinter.h:
2472         * DumpRenderTree/chromium/WebPreferences.h:
2473
2474 2011-01-17  Jessie Berlin  <jberlin@apple.com>
2475
2476         Reviewed by Anders Carlsson.
2477
2478         REGRESSION: Assertion failure in FrameLoader::continueLoadAfterWillSubmitForm() when
2479         navigating back to an unreachable URL
2480         https://bugs.webkit.org/show_bug.cgi?id=52388
2481
2482         Add a third parameter (unreachableURL) to queueLoadHTMLString.
2483
2484         * DumpRenderTree/LayoutTestController.cpp:
2485         (queueLoadHTMLStringCallback):
2486         (LayoutTestController::queueLoadHTMLString):
2487         (LayoutTestController::queueLoadAlternateHTMLString):
2488         * DumpRenderTree/LayoutTestController.h:
2489
2490         * DumpRenderTree/WorkQueueItem.h:
2491         (LoadHTMLStringItem::LoadHTMLStringItem):
2492
2493         * DumpRenderTree/chromium/LayoutTestController.cpp:
2494         (WorkItemLoadHTMLString::WorkItemLoadHTMLString):
2495         (WorkItemLoadHTMLString::run):
2496         (LayoutTestController::queueLoadHTMLString):
2497
2498         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
2499         (LoadHTMLStringItem::invoke):
2500         * DumpRenderTree/mac/WorkQueueItemMac.mm:
2501         (LoadHTMLStringItem::invoke):
2502         * DumpRenderTree/win/WorkQueueItemWin.cpp:
2503         (LoadHTMLStringItem::invoke):
2504
2505 2011-01-17  Dan Bernstein  <mitz@apple.com>
2506
2507         Rubber-stamped by Mark Rowe.
2508
2509         Update xcodeproj svn:ignore to include xcuserdata.
2510
2511         * DumpRenderTree/DumpRenderTree.xcodeproj: Modified property svn:ignore.
2512         * MiniBrowser/MiniBrowser.xcodeproj: Modified property svn:ignore.
2513         * TestWebKitAPI/TestWebKitAPI.xcodeproj: Modified property svn:ignore.
2514         * WebKitLauncher/WebKitLauncher.xcodeproj: Modified property svn:ignore.
2515         * WebKitTestRunner/WebKitTestRunner.xcodeproj: Modified property svn:ignore.
2516
2517 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
2518
2519         Unreviewed fix after r75908.
2520
2521         Move WebKit into Source
2522         https://bugs.webkit.org/show_bug.cgi?id=52530
2523
2524         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add Source to the path for Qt API tests.
2525
2526 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
2527
2528         Unreviewed.
2529
2530         Remove accidentally committed debug printing after r75908.
2531
2532         * Scripts/webkitdirs.pm:
2533
2534 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
2535
2536         Unreviewed.
2537
2538         Add myself to committers list
2539         https://bugs.webkit.org/show_bug.cgi?id=52566
2540
2541         * Scripts/webkitpy/common/config/committers.py:
2542
2543 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
2544
2545         Reviewed by Jeremy Orlow.
2546
2547         GeolocationController should call stopUpdating on destruction
2548         https://bugs.webkit.org/show_bug.cgi?id=52216
2549
2550         fast/dom/Geolocation/window-close-crash.html requires that a
2551         Geolocation watch be started in a secondary window. Consequently,
2552         we need to allow geolocation permission and provide a mock
2553         geolocation position for the secondary window's
2554         GeolocationClientMock.
2555
2556         * DumpRenderTree/chromium/LayoutTestController.cpp:
2557         (LayoutTestController::setGeolocationPermission):
2558         (LayoutTestController::setMockGeolocationPosition):
2559         (LayoutTestController::setMockGeolocationError):
2560         * DumpRenderTree/chromium/TestShell.h:
2561         (TestShell::windowList):
2562
2563 2011-01-16  Adam Barth  <abarth@webkit.org>
2564
2565         Update more include paths to reflect WebKit move.
2566
2567         * DumpRenderTree/chromium/EventSender.cpp:
2568         (EventSender::keyDown):
2569         (EventSender::needsShiftModifier):
2570         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
2571         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
2572
2573 2011-01-16  Kent Tamura  <tkent@chromium.org>
2574
2575         Unreviewed, Chromium build fix.
2576
2577         * Scripts/update-webkit-chromium: Webkit/chromium -> Source/WebKit/chromium
2578
2579 2011-01-16  Martin Robinson  <mrobinson@igalia.com>
2580
2581         Build fix for GTK+ after source directory movement.
2582
2583         * GNUmakefile.am: Correct include paths.
2584
2585 2011-01-16  Adam Barth  <abarth@webkit.org>
2586
2587         Teach svn-apply about WebKit move.
2588
2589         * Scripts/VCSUtils.pm:
2590
2591 2011-01-16  Adam Barth  <abarth@webkit.org>
2592
2593         Rubber-stamped by Eric Seidel.
2594
2595         Move WebKit into Source
2596         https://bugs.webkit.org/show_bug.cgi?id=52530
2597
2598         * DumpRenderTree/mac/InternalHeaders/WebKit/WebTypesInternal.h:
2599         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2600         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2601         * DumpRenderTree/qt/GCControllerQt.cpp:
2602         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2603         * DumpRenderTree/qt/PlainTextControllerQt.cpp:
2604         * DumpRenderTree/qt/TextInputControllerQt.cpp:
2605         * DumpRenderTree/wscript:
2606         * QtTestBrowser/launcherwindow.h:
2607         * Scripts/build-webkit:
2608         * Scripts/webkitdirs.pm:
2609
2610 2011-01-15  Adam Barth  <abarth@webkit.org>
2611
2612         Teach svn-apply about WebKit2 move.
2613
2614         * Scripts/VCSUtils.pm:
2615
2616 2011-01-15  Adam Barth  <abarth@webkit.org>
2617
2618         Rubber-stamped by Eric Seidel.
2619
2620         Move WebKit2 into Source
2621         https://bugs.webkit.org/show_bug.cgi?id=52438
2622
2623         * MiniBrowser/qt/MiniBrowser.pro:
2624         * Scripts/build-webkit:
2625         * Scripts/do-file-rename:
2626         * Scripts/do-webcore-rename:
2627         * Scripts/test-webkitpy:
2628         * Scripts/webkitdirs.pm:
2629         * Scripts/webkitpy/style/checker.py:
2630         * WebKitTestRunner/DerivedSources.pro:
2631         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2632         * WebKitTestRunner/qt/WebKitTestRunner.pro:
2633
2634 2011-01-15  Jochen Eisinger  <jochen@chromium.org>
2635
2636         Reviewed by David Levin.
2637
2638         [chromium] remove obsolete createView method
2639         https://bugs.webkit.org/show_bug.cgi?id=52437
2640
2641         * DumpRenderTree/chromium/WebViewHost.cpp:
2642         (WebViewHost::createView):
2643         * DumpRenderTree/chromium/WebViewHost.h:
2644
2645 2011-01-14  Brian Weinstein  <bweinstein@apple.com>
2646
2647         Reviewed by Geoff Garen.
2648
2649         ShouldLoadResourceForFrame should use strings, not URLs.
2650         https://bugs.webkit.org/show_bug.cgi?id=52476
2651
2652         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2653         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Update to use a WKStringRef.
2654         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2655
2656 2011-01-14  Tony Gentilcore  <tonyg@chromium.org>
2657
2658         Reviewed by David Levin.
2659
2660         Add Tony Gentilcore as a reviewer
2661         https://bugs.webkit.org/show_bug.cgi?id=52480
2662
2663         * Scripts/webkitpy/common/config/committers.py:
2664
2665 2011-01-14  David Levin  <levin@chromium.org>
2666
2667         Reviewed by Eric Seidel.
2668
2669         check-webkit-style: _FunctionState should keep track of where the function name starts.
2670         https://bugs.webkit.org/show_bug.cgi?id=52454
2671
2672         * Scripts/webkitpy/style/checkers/cpp.py: Added function_name_start_position to
2673         _FunctionState and logic for setting it correctly.
2674         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests.
2675
2676 2011-01-14  Vincent Scheib  <scheib@chromium.org>
2677
2678         Reviewed by David Levin.
2679
2680         Add support to DumpRenderTree to use the GPU rather than software renderer
2681         https://bugs.webkit.org/show_bug.cgi?id=52333
2682
2683         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2684         (main):
2685         * Scripts/webkitpy/layout_tests/port/chromium.py:
2686         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2687
2688 2011-01-14  Tony Chang  <tony@chromium.org>
2689
2690         Reviewed by Kent Tamura.
2691
2692         [chromium] update fonts.conf to fix 6 linux tests in drt
2693         https://bugs.webkit.org/show_bug.cgi?id=52411
2694
2695         * DumpRenderTree/chromium/fonts.conf: Update to match the copy in
2696             chromium's src/webkit/tools/test_shell/resources/fonts.conf
2697
2698 2011-01-14  Eric Seidel  <eric@webkit.org>
2699
2700         Original patch from Peter Gal  <galpater@inf.u-szeged.hu>
2701
2702         Reviewed by Adam Barth.
2703
2704         Fix when running Tools/Scripts/check-webkit-style without arguments.
2705         https://bugs.webkit.org/show_bug.cgi?id=52261#c16
2706
2707         * Scripts/webkitpy/common/checkout/scm.py: Handle None for changed_files argument better in Git.create_patch method.
2708         * Scripts/webkitpy/common/checkout/scm_unittest.py:
2709
2710 2011-01-04  Jochen Eisinger  <jochen@chromium.org>
2711
2712         Reviewed by David Levin.
2713
2714         Store the tempdir object in a variable so it doesn't get deleted too early.
2715         https://bugs.webkit.org/show_bug.cgi?id=51875
2716
2717         * Scripts/update-webkit-auxiliary-libs:
2718         * Scripts/update-webkit-support-libs:
2719
2720 2011-01-14  Eric Seidel  <eric@webkit.org>
2721
2722         Unreviewed.  Make it work in python 2.5.
2723
2724         webkit-patch suggest-reviewers dies when ChangeLogs are missing
2725         https://bugs.webkit.org/show_bug.cgi?id=49158
2726
2727         * Scripts/webkitpy/common/checkout/api_unittest.py:
2728
2729 2011-01-14  Sheriff Bot  <webkit.review.bot@gmail.com>
2730
2731         Unreviewed, rolling out r75774.
2732         http://trac.webkit.org/changeset/75774
2733         https://bugs.webkit.org/show_bug.cgi?id=52431
2734
2735         gtk builds were broken (Requested by loislo2 on #webkit).
2736
2737         * Scripts/webkitpy/common/checkout/scm.py:
2738
2739 2011-01-14  David Levin  <levin@chromium.org>
2740
2741         Reviewed by Shinichiro Hamaji.
2742
2743         check-webkit-style: _FunctionState should detect pure functions.
2744         https://bugs.webkit.org/show_bug.cgi?id=52428
2745
2746         * Scripts/webkitpy/style/checkers/cpp.py: Added detection for if a function declaration
2747         is a pure virtual function.
2748         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests for verifying that pure
2749         virtual functions are correctly detected.
2750
2751 2011-01-13  Ilya Tikhonovsky  <loislo@chromium.org>
2752
2753         Reviewed by Yury Semikhatsky.
2754
2755         Just small fix for problem with check-webkit-style.
2756         It just didn't work for this patch.
2757         Old code can't concatenate a list of strings with None.
2758
2759         * Scripts/webkitpy/common/checkout/scm.py:
2760
2761 2011-01-13  David Levin  <levin@chromium.org>
2762
2763         Reviewed by Shinichiro Hamaji.
2764
2765         check-webkit-style: _FunctionState should use Position to know where items are.
2766         https://bugs.webkit.org/show_bug.cgi?id=52424
2767
2768         * Scripts/webkitpy/style/checkers/cpp.py:
2769         (_FunctionState.*): Changed _FunctionState to use Position instead of line numbers.
2770         (detect_functions): Changed to pass Position's to _FunctionState.begin and
2771         did some minor clean-up.
2772         (*): Other changes are simply about converting to use the Position's in_FunctionState
2773         instead of line numbers.
2774         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Changed the test code
2775         to verify the positions stored in _FunctionState.
2776
2777 2011-01-13  Eric Seidel  <eric@webkit.org>
2778
2779         Reviewed by David Levin.
2780
2781         webkit-patch suggest-reviewers dies when ChangeLogs are missing
2782         https://bugs.webkit.org/show_bug.cgi?id=49158
2783
2784         This is not the most elegant, but it is a very safe fix to this bug.
2785         One advantage of catching ScriptError like this instead of adding a
2786         new added_or_modified_files or fixing all changed_files callers
2787         to use a more specific change_files variant, is that we catch
2788         all kinds of ScriptErrors which might cause our (non-essential)
2789         suggest-reviewers code to fail out.  This should make passing
2790         --suggest-reviewers to webkit-patch upload much more robust
2791         and may even make it possible for us to make it default.
2792
2793         The root of the problem here is that SCM.changed_files includes
2794         deleted ChangeLog paths (from moves, etc) which then when we ask
2795         SVN/Git for the contents of the file at that revision, the command
2796         errors out and Executive.run_command raises a ScriptError.
2797
2798         In the future we might fix this differently by making all current
2799         callers of chagned_files use a more specific method for requesting
2800         what types of changes they're interested in (adds, modifies, deletes, etc.)
2801
2802         * Scripts/webkitpy/common/checkout/api.py:
2803         * Scripts/webkitpy/common/checkout/api_unittest.py:
2804
2805 2011-01-13  Dan Bernstein  <mitz@apple.com>
2806
2807         Reviewed by Alexey Proskuryakov.
2808
2809         <rdar://problem/8827065> REGRESSION (r71884): Cross-origin XHR fails if willSendRequest changes the URL
2810         https://bugs.webkit.org/show_bug.cgi?id=52419
2811
2812         Allow to further control the behavior of the willSendRequest delegate callback by making it
2813         set a different URL in the new request.
2814
2815         * DumpRenderTree/LayoutTestController.cpp:
2816         (addURLToRedirectCallback): Added.
2817         (LayoutTestController::staticFunctions): Added addURLToRedirect.
2818         (LayoutTestController::addURLToRedirect): Added. Adds the redirection to the map.
2819         (LayoutTestController::redirectionDestinationForURL): Added this getter.
2820         * DumpRenderTree/LayoutTestController.h:
2821         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2822         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]): Check
2823         if there is a redirection for the request’s URL, established by addURLToRedirect(), and if so,
2824         change the URL in the new request to the redirect destination.
2825
2826 2011-01-13  Eric Seidel  <eric@webkit.org>
2827
2828         Reviewed by Mihai Parparita.
2829
2830         webkit-patch suggest-reviewers fails due to invalid utf8 in ChangeLog files
2831         https://bugs.webkit.org/show_bug.cgi?id=52416
2832
2833         Example: webkit-patch suggest-reviewers -g ca3890fe74d94d85d6bfa48f9ea497b094d8e717 
2834         UnicodeDecodeError: 'utf8' codec can't decode bytes in position 536-538: invalid data
2835
2836         I also added FIXMEs about the changed_files returning deleted files problem
2837         which is causing the other most common exception for suggest-reviewers
2838         (and is probably breaking sheriff-bots blame detection).
2839
2840         * Scripts/webkitpy/common/checkout/api.py:
2841         * Scripts/webkitpy/common/checkout/api_unittest.py:
2842         * Scripts/webkitpy/common/checkout/scm.py:
2843
2844 2011-01-13  Eric Seidel  <eric@webkit.org>
2845
2846         Reviewed by Adam Barth.
2847
2848         results archives from commit-queue are too large to upload
2849         https://bugs.webkit.org/show_bug.cgi?id=52405
2850
2851         * Scripts/webkitpy/common/system/filesystem.py:
2852         * Scripts/webkitpy/common/system/filesystem_mock.py:
2853         * Scripts/webkitpy/tool/commands/queues.py:
2854
2855 2011-01-13  Alejandro G. Castro  <alex@igalia.com>
2856
2857         Reviewed by Martin Robinson.
2858
2859         [gtk] Zero-sized font does not yet work
2860         https://bugs.webkit.org/show_bug.cgi?id=49793
2861
2862         Set minimum-font-size to 0 for the DRT.
2863
2864         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2865         (resetDefaultsToConsistentValues):
2866
2867 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
2868
2869         Reviewed by Darin Adler.
2870
2871         Make old-run-webkit-tests more robust on buildbots
2872         https://bugs.webkit.org/show_bug.cgi?id=52364
2873
2874         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Pass --exit-after-n-failures 500 to old-run-webkit-tests script.
2875
2876 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
2877
2878         Reviewed by Darin Adler.
2879
2880         Make old-run-webkit-tests more robust on buildbots
2881         https://bugs.webkit.org/show_bug.cgi?id=52364
2882
2883         * Scripts/old-run-webkit-tests: Ensure that testResultsDirectory is empty.
2884
2885 2011-01-13  Tony Chang  <tony@chromium.org>
2886
2887         Reviewed by Kent Tamura.
2888
2889         [chromium] fix plugins/plugin-javascript-access.html on Linux and Mac
2890         https://bugs.webkit.org/show_bug.cgi?id=52332
2891
2892         Forked Info.plist is not longer needed.
2893
2894         * DumpRenderTree/chromium/TestNetscapePlugIn/Info.plist: Removed.
2895
2896 2011-01-13  Mikhail Naganov  <mnaganov@chromium.org>
2897
2898         Reviewed by Timothy Hatcher.
2899
2900         Web Inspector: Cleanup after r75613 -- make all UI-facing strings
2901         to be passed directly to WebInspector.UIString
2902
2903         https://bugs.webkit.org/show_bug.cgi?id=52365
2904
2905         * Scripts/check-inspector-strings:
2906
2907 2011-01-13  Sheriff Bot  <webkit.review.bot@gmail.com>
2908
2909         Unreviewed, rolling out r74881.
2910         http://trac.webkit.org/changeset/74881
2911         https://bugs.webkit.org/show_bug.cgi?id=52357
2912
2913         The EFL builder has been red for days (Requested by abarth on
2914         #webkit).
2915
2916         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2917         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2918
2919 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
2920
2921         Reviewed by David Levin.
2922
2923         Add beforeunload support to WebKitTestRunner
2924         https://bugs.webkit.org/show_bug.cgi?id=52353
2925         
2926         This makes a number of currently failing tests pass.
2927
2928         * WebKitTestRunner/TestController.cpp:
2929         (WTR::runBeforeUnloadConfirmPanel):
2930         (WTR::createOtherPage):
2931         (WTR::TestController::initialize):
2932
2933 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
2934
2935         Reviewed by Sam Weinig.
2936
2937         Detect, identify and recover from WebProcess crashes in run-webkit-tests
2938         https://bugs.webkit.org/show_bug.cgi?id=52330
2939
2940         * Scripts/old-run-webkit-tests: Detect when the regression test tool reports
2941         a web process crash.
2942         * WebKitTestRunner/TestController.cpp:
2943         (WTR::TestController::initialize): Set up a processDidCrash
2944         callback.
2945         (WTR::TestController::processDidCrash): Report that the Web process
2946         crashed.
2947         * WebKitTestRunner/TestController.h:
2948
2949 2011-01-12  David Levin  <levin@chromium.org>
2950
2951         Reviewed by Shinichiro Hamaji.
2952
2953         check-webkit-style -- close_expression function doesn't work correctly.
2954         https://bugs.webkit.org/show_bug.cgi?id=52272
2955
2956         * Scripts/webkitpy/style/checkers/cpp.py:
2957         (Position.__str__): Added a way to convert it to a string which is useful in tests.
2958         (Position.__cmp__): Added a way to compare Position which is useful in tests and
2959         generally useful (for upcoming code changes).
2960         (close_expression): Changed to use Position for input and output.
2961         Also, fixed many bugs such as only working correctly for parenthesis,
2962         not working correctly if given an offset in a line and not finding
2963         the real closing element if there were multiple closing elements in
2964         the same line.
2965         (detect_functions): Adjusted due to the change in arguments for
2966         close_expression.
2967         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2968         (CppStyleTestBase.assert_positions_equal): Added a way to verify that
2969         two positions are the same.
2970         (CppStyleTest.test_position): Added tests for the __str_ and __cmp__ methods.
2971         (CppStyleTest.test_close_expression): Added tests to catch the issues
2972         that were fixed.
2973
2974 2011-01-12  Sheriff Bot  <webkit.review.bot@gmail.com>
2975
2976         Unreviewed, rolling out r75576.
2977         http://trac.webkit.org/changeset/75576
2978         https://bugs.webkit.org/show_bug.cgi?id=52304
2979
2980         broke rebaseline-chromium-webkit-test (Requested by thakis on
2981         #webkit).
2982
2983         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2984         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2985         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
2986         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2987         * Scripts/webkitpy/layout_tests/port/base.py:
2988         * Scripts/webkitpy/layout_tests/port/chromium.py:
2989         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2990         * Scripts/webkitpy/layout_tests/port/test.py:
2991         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2992         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2993         * Scripts/webkitpy/style/checkers/test_expectations.py:
2994         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
2995
2996 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
2997
2998         Reviewed by Darin Adler.
2999
3000         Add a no-build option to run-webkit-tests, to avoid building DRT/WKTR
3001         https://bugs.webkit.org/show_bug.cgi?id=52307
3002
3003         * Scripts/old-run-webkit-tests:
3004
3005 2011-01-12  Koan-Sin Tan  <koansin.tan@gmail.com>
3006
3007         Reviewed by Martin Robinson.
3008
3009         [Gtk] WebKitGtk+ doesn't build on Mac OS X 10.6
3010         https://bugs.webkit.org/show_bug.cgi?id=50867
3011
3012         Fixed library extention for Mac in webkitdirs.pm and type conflict in
3013         TestNetscapePlugin.cpp 
3014
3015         * GNUmakefile.am: Don't use AppKit when compiling TestNetscapePlugin for GTK+
3016         * Scripts/webkitdirs.pm:
3017
3018 2011-01-12  Mikhail Naganov  <mnaganov@chromium.org>
3019
3020         Reviewed by Pavel Feldman.
3021
3022         Add check-inspector-strings script.
3023
3024         https://bugs.webkit.org/show_bug.cgi?id=52295
3025
3026         * Scripts/check-inspector-strings: Added.
3027
3028 2011-01-12  Adam Roben  <aroben@apple.com>
3029
3030         Advertise the .testnetscape file extension on Windows
3031
3032         Fixes <http://webkit.org/b/52298>
3033         plugins/no-mime-with-valid-extension.html fails on Windows
3034
3035         Reviewed by Dan Bernstein.
3036
3037         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Added a
3038         FileExtents field to map the .testnetscape file extension to the
3039         application/x-webkit-test-netscape MIME type, just as we do on Mac.
3040
3041 2011-01-12  Adam Barth  <abarth@webkit.org>
3042
3043         Reviewed by Eric Seidel.
3044
3045         Make webkit-patch support subdirectories for SVN checkouts
3046         https://bugs.webkit.org/show_bug.cgi?id=52261
3047
3048         os.relpath does not exist on Python 2.5, so we need to call our version
3049         of the API.
3050
3051         * Scripts/webkitpy/common/checkout/scm.py:
3052
3053 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
3054
3055         Reviewed by Eric Seidel.
3056
3057         Close additional pages opened during a test once the test completes.
3058         https://bugs.webkit.org/show_bug.cgi?id=52276
3059
3060         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3061         (WTR::InjectedBundle::done):
3062
3063 2011-01-11  David Levin  <levin@chromium.org>
3064
3065         Reviewed by Eric Seidel.
3066
3067         Errors should be separated from the command line in bot messages.
3068         https://bugs.webkit.org/show_bug.cgi?id=52275
3069
3070         * Scripts/webkitpy/common/system/executive.py:
3071         (ScriptError.message_with_output): Added a newline to separate the command
3072         line from the errors.
3073         * Scripts/webkitpy/common/system/executive_unittest.py:
3074         (ScriptErrorTest.test_message_with_output): Added tests for the various code
3075         paths in message_with_output.
3076
3077 2011-01-11  Eric Seidel  <eric@webkit.org>
3078
3079         Unreviewed.
3080
3081         commit-queue should know how to upload archived results (for test flakes or general failures)
3082         https://bugs.webkit.org/show_bug.cgi?id=52048
3083
3084         The zips are mostly empty due to forgetting -r.
3085         Expected diffs were not being pulled from the archive due
3086         to the archive having longer paths than I realized.
3087
3088         * Scripts/webkitpy/common/system/workspace.py:
3089         * Scripts/webkitpy/common/system/workspace_unittest.py:
3090         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3091         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3092
3093 2011-01-11  Dirk Pranke  <dpranke@chromium.org>
3094
3095         Reviewed by Ojan Vafai.
3096
3097         The current modifier parsing code in test_expectations is
3098         fragile and hard-coded, so it's not easy to understand the logic
3099         or easily add new types of modifiers (like GPU vs. CPU testing
3100         for graphics tests, or 32-bit vs. 64-bit differences).
3101
3102         This is the first of two patches that will add in more generic
3103         support and then eliminate the GPU-specific test expectations
3104         files for Chromium.
3105
3106         This patch adds two standalone objects for handling modifiers. The
3107         rules for interpreting modifiers, precedence, and conflicts are
3108         given in the docstring to the ModifierMatcher class, which
3109         returns ModifierMatchResult objects.
3110         
3111         This patch also adds routines to the Port interface and a
3112         default set of values in the base object, in order to obtain the
3113         values needed on a given test run. These values are then passed
3114         to the expectation parser. This also allows us to clean up the
3115         logic used to lint all of the different configurations in a
3116         single test_expectations.txt file.
3117
3118         The next patch will merge in the separate GPU expectations file.
3119
3120         https://bugs.webkit.org/show_bug.cgi?id=51222
3121
3122         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
3123         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
3124         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
3125         * Scripts/webkitpy/layout_tests/port/base.py:
3126         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3127         * Scripts/webkitpy/layout_tests/port/chromium.py:
3128         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3129         * Scripts/webkitpy/layout_tests/port/test.py:
3130         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3131         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3132
3133 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
3134
3135         Reviewed by Adam Barth.
3136
3137         Make webkit-patch support subdirectories for SVN checkouts
3138         https://bugs.webkit.org/show_bug.cgi?id=52261
3139
3140         * Scripts/webkitpy/common/checkout/scm.py:
3141         * Scripts/webkitpy/style_references.py:
3142         * Scripts/webkitpy/tool/main.py:
3143         * Scripts/webkitpy/tool/steps/preparechangelog.py:
3144
3145 2011-01-11  Eric Seidel  <eric@webkit.org>
3146
3147         Unreviewed.
3148
3149         commit-queue should know how to upload archived results (for test flakes or general failures)
3150         https://bugs.webkit.org/show_bug.cgi?id=52048
3151
3152         I changed the API for archive_last_layout_test_results w/o updating the implementation.  Oops.
3153         This fixes an exception seen on the commit-queue when attempting to report flaky tests.
3154
3155         * Scripts/webkitpy/common/system/workspace.py:
3156         * Scripts/webkitpy/common/system/workspace_unittest.py:
3157         * Scripts/webkitpy/tool/commands/queues.py:
3158
3159 2011-01-11  Sam Weinig  <sam@webkit.org>
3160
3161         Roll r75474 back in.
3162
3163 2011-01-11  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
3164
3165         Reviewed by Kenneth Rohde Christiansen.
3166
3167         [Qt] Remove uses of QFuture since it isn't supported on all platforms.
3168         https://bugs.webkit.org/show_bug.cgi?id=51204
3169
3170         * QtTestBrowser/webpage.h:
3171         (QtNAMThread::QtNAMThread):
3172         (QtNAMThread::networkAccessManager):
3173         (QtNAMThread::run):
3174
3175 2011-01-11  Peter Varga  <pvarga@webkit.org>
3176
3177         Unreviewed.
3178
3179         Add myself to committers' list.
3180
3181         * Scripts/webkitpy/common/config/committers.py:
3182
3183 2011-01-11  Eric Seidel  <eric@webkit.org>
3184
3185         Reviewed by Adam Barth.
3186
3187         commit-queue should know how to upload archived results (for test flakes or general failures)
3188         https://bugs.webkit.org/show_bug.cgi?id=52048
3189
3190         Now the queue will always upload results.  Either the entire zip, or just
3191         the diffs.txt in the case of text failures.
3192
3193         This should make understanding flakes much easier, and paves the way
3194         for having the EWS run layout tests (and upload failures).
3195
3196         In order to upload .zip files I had to teach bugzilla.py to autodetect
3197         mime types from the filename.  Since mimetypes.py doesn't include a mapping
3198         for .patch files, I have it add one before calling guess_type.
3199
3200         We may find that always uploading the whole zip instead of just the -diffs.txt
3201         file is preferable, but for now I'm keeping the old behavior because it makes
3202         quickly understanding text failures easy.
3203
3204         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3205         * Scripts/webkitpy/common/system/workspace.py: Added.
3206         * Scripts/webkitpy/common/system/workspace_unittest.py: Added.
3207         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3208         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3209         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3210         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3211         * Scripts/webkitpy/tool/commands/queues.py:
3212         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3213
3214 2011-01-10  Sheriff Bot  <webkit.review.bot@gmail.com>
3215
3216         Unreviewed, rolling out r75464.
3217         http://trac.webkit.org/changeset/75464
3218         https://bugs.webkit.org/show_bug.cgi?id=52193
3219
3220         Followup rollout for 75474 (Requested by Ossy on #webkit).
3221
3222         * MiniBrowser/mac/BrowserWindowController.m:
3223         (-[BrowserWindowController awakeFromNib]):
3224         * MiniBrowser/win/BrowserView.cpp:
3225         (BrowserView::create):
3226         * WebKitTestRunner/TestController.cpp:
3227         (WTR::createOtherPage):
3228         (WTR::TestController::initialize):
3229
3230 2011-01-10  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3231
3232         Reviewed by Csaba Osztrogonác.
3233
3234         [Qt] Baseline qt_minimal configuration
3235         https://bugs.webkit.org/show_bug.cgi?id=51313
3236
3237         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3238         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): Add
3239         QT_NO_UNDOSTACK guard.
3240
3241         * QtTestBrowser/launcherwindow.cpp:
3242         (LauncherWindow::createChrome): Add QT_NO_SHORTCUT and QT_NO_PRINTER
3243         guards.
3244         (LauncherWindow::applyZoom): Add QT_NO_ANIMATION guard.
3245         (LauncherWindow::screenshot): Add QT_NO_FILEDIALOG guard.
3246         (LauncherWindow::selectElements): Add QT_NO_INPUTDIALOG guard.
3247         (LauncherWindow::showUserAgentDialog): Add QT_NO_COMBOBOX guard.
3248
3249         * QtTestBrowser/launcherwindow.h:
3250         * QtTestBrowser/locationedit.cpp: Add QT_NO_INPUTDIALOG guard.
3251         * QtTestBrowser/locationedit.h: Ditto.
3252
3253         * QtTestBrowser/mainwindow.cpp:
3254         (MainWindow::buildUI): Add QT_NO_INPUTDIALOG, QT_NO_SHORTCUT and
3255         QT_NO_UNDOSTACK guards.
3256         (MainWindow::setAddressUrl): Add QT_NO_INPUTDIALOG guard.
3257         (MainWindow::changeLocation): Ditto.
3258         (MainWindow::openFile): Add QT_NO_FILEDIALOG guard.
3259         (MainWindow::openLocation): Add QT_NO_INPUTDIALOG guard.
3260
3261         * QtTestBrowser/webpage.cpp:
3262         (WebPage::openUrlInDefaultBrowser): Add QT_NO_DESKTOPSERVICES guard.
3263         (WebPage::authenticationRequired): Add QT_NO_LINEEDIT guard.
3264
3265         * QtTestBrowser/webview.cpp:
3266         (WebViewGraphicsBased::animatedFlip): Add QT_NO_ANIMATION guard.
3267         (WebViewGraphicsBased::animatedYFlip): Ditto.
3268
3269 2011-01-10  Sam Weinig  <sam@webkit.org>
3270
3271         Fix build.
3272
3273         * MiniBrowser/mac/BrowserWindowController.m:
3274         (-[BrowserWindowController awakeFromNib]):
3275         * MiniBrowser/win/BrowserView.cpp:
3276         (BrowserView::create):
3277         * WebKitTestRunner/TestController.cpp:
3278         (WTR::createOtherPage):
3279         (WTR::TestController::initialize):
3280
3281 2011-01-10  Eric Seidel  <eric@webkit.org>
3282
3283         Reviewed by Ojan Vafai.
3284
3285         style-queue messages are way too long for big patches
3286         https://bugs.webkit.org/show_bug.cgi?id=52161
3287
3288         We definitely could build much fancier list-to-string-with-limit functions
3289         but this should be sufficient for our needs at the moment.
3290
3291         * Scripts/webkitpy/common/system/executive.py:
3292         * Scripts/webkitpy/common/system/executive_unittest.py:
3293
3294 2011-01-10  Tony Chang  <tony@chromium.org>
3295
3296         Unreviewed, rolling out r75398.
3297         http://trac.webkit.org/changeset/75398
3298         https://bugs.webkit.org/show_bug.cgi?id=52008
3299
3300         Some layout tests are crashing on Chromium Win.
3301
3302         * DumpRenderTree/chromium/WebViewHost.cpp:
3303         (WebViewHost::updatePaintRect):
3304         * DumpRenderTree/chromium/WebViewHost.h:
3305
3306 2011-01-10  Adam Roben  <aroben@apple.com>
3307
3308         Roll out r75392
3309
3310         It isn't needed now that r75289 has been rolled out.
3311
3312         * Scripts/run-javascriptcore-tests:
3313
3314 2011-01-10  Maciej Stachowiak  <mjs@apple.com>
3315
3316         Reviewed by Anders Carlsson.
3317
3318         WebKitTestRunner uses crazy amounts of CPU, making layout tests slow and flaky
3319         https://bugs.webkit.org/show_bug.cgi?id=52160
3320
3321         * WebKitTestRunner/mac/TestControllerMac.mm:
3322         (WTR::TestController::platformRunUntil): Instead of busy-looping, wait for the timeout.
3323         Anything that can make runUntil() conditions turn true will happen on a run loop cycle
3324         anyway.
3325
3326 2011-01-10  Tony Chang  <tony@chromium.org>
3327
3328         Reviewed by Mihai Parparita.
3329
3330         [chromium] fix for animated gif layout tests
3331         https://bugs.webkit.org/show_bug.cgi?id=52008
3332
3333         * DumpRenderTree/chromium/WebViewHost.cpp: Schedule a paint when we update the paint rect
3334             to trigger gif animations.
3335         (WebViewHostPaintTask::WebViewHostPaintTask):
3336         (WebViewHostPaintTask::runIfValid):
3337         (WebViewHost::updatePaintRect):
3338         * DumpRenderTree/chromium/WebViewHost.h:
3339         (WebViewHost::taskList):
3340
3341 2011-01-10  Alejandro G. Castro  <alex@igalia.com>
3342
3343         Reviewed by Xan Lopez.
3344
3345         [GTK] Fix gtk2 compilation for master
3346         https://bugs.webkit.org/show_bug.cgi?id=51885
3347
3348         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
3349         (createBitmapContextFromWebView): Replaced the old
3350         gdk_drawable_get_size with gdk_pixmap_get_size.
3351
3352 2011-01-10  Patrick Gansterer  <paroga@webkit.org>
3353
3354         Reviewed by Laszlo Gombos.
3355
3356         [WINCE] Reenable NPAPI after r75203
3357         https://bugs.webkit.org/show_bug.cgi?id=52109
3358
3359         Remove the !isWinCE() check for ENABLE_NETSCAPE_PLUGIN_API and replace
3360         it with !isEfl(), because EFL port does not support NPAPI (yet).
3361
3362         * Scripts/build-webkit:
3363
3364 2011-01-10  Adam Roben  <aroben@apple.com>
3365
3366         Skip some asserting JS tests
3367
3368         See <http://webkit.org/b/52156>.
3369
3370         * Scripts/run-javascriptcore-tests:
3371
3372 2011-01-10  Martin Robinson  <mrobinson@igalia.com>
3373
3374         Reviewed by Xan Lopez.
3375
3376         [GTK] build-webkit disable Blob support via arguments passed to automake
3377         https://bugs.webkit.org/show_bug.cgi?id=52097
3378
3379         * Scripts/build-webkit: Enable Blob support when building WebKitGTK+ via
3380         build-webkit.
3381
3382 2011-01-10  Adam Roben  <aroben@apple.com>
3383
3384         Use the same name and description for TestNetscapePlugin on Windows and
3385         Mac
3386
3387         Fixes <http://webkit.org/b/52151>
3388         fast/frames/iframe-reparenting-plugins.html fails on Windows
3389
3390         Reviewed by Steve Falkenburg.
3391
3392         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Copied
3393         the name and description from Mac's Info.plist.
3394
3395 2011-01-10  Siddharth Mathur <siddharth.mathur@nokia.com>
3396
3397         Reviewed by Laszlo Gombos.
3398
3399         [Qt][WK2] Guard gcc-specific syntax
3400
3401         Non-gcc based compliers choke on the "-include"
3402         syntax for preinclude, place guard around it.
3403
3404         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3405         * WebKitTestRunner/qt/WebKitTestRunner.pro:
3406
3407 2011-01-10  Andreas Kling  <kling@webkit.org>
3408
3409         Reviewed by Simon Hausmann.
3410
3411         [Qt] [WK2] MiniBrowser does not load pages opened in new windows
3412         https://bugs.webkit.org/show_bug.cgi?id=52111
3413
3414         When getting a createNewPage() callback from QWKPage, create the
3415         new page with the same QWKContext as the page that is passed to
3416         the callback.
3417
3418         * MiniBrowser/qt/BrowserView.h:
3419         * MiniBrowser/qt/BrowserWindow.cpp:
3420         (newPageFunction):
3421         (BrowserWindow::BrowserWindow):
3422         * MiniBrowser/qt/BrowserWindow.h:
3423
3424 2011-01-10  Andreas Kling  <kling@webkit.org>
3425
3426         Reviewed by Kenneth Rohde Christiansen.
3427
3428         [Qt] MiniBrowser: Remove superfluous createNewPage() callback
3429
3430         BrowserView set its own useless createNewPage() callback on QWKPage.
3431         This was immediately overridden by BrowserWindow anyway, so remove
3432         the BrowserView one.
3433
3434         * MiniBrowser/qt/BrowserView.cpp:
3435         (BrowserView::BrowserView):
3436
3437 2011-01-10  John Knottenbelt  <jknotten@chromium.org>
3438
3439         Reviewed by Jeremy Orlow.
3440
3441         [Chromium] Remove non-client-based Geolocation code
3442         https://bugs.webkit.org/show_bug.cgi?id=50921
3443
3444         * DumpRenderTree/chromium/LayoutTestController.cpp:
3445         (LayoutTestController::setGeolocationPermission):
3446         (LayoutTestController::setMockGeolocationPosition):
3447         (LayoutTestController::setMockGeolocationError):
3448         * DumpRenderTree/chromium/WebViewHost.cpp:
3449         (WebViewHost::geolocationClientMock):
3450         (WebViewHost::reset):
3451         * DumpRenderTree/chromium/WebViewHost.h:
3452
3453 2011-01-10  Eric Seidel  <eric@webkit.org>
3454
3455         Reviewed by Adam Barth.
3456
3457         Commit bot tried to land r? cq+ patch
3458         https://bugs.webkit.org/show_bug.cgi?id=36638
3459
3460         It should now be possible to post a patch with r? and cq+ and the
3461         commit-queue will correctly wait for the r+ before attempting to land the patch.
3462         (This was a feature requested by several users.)
3463
3464         One caveat: We don't actually reject r-, cq+ patches from the queue
3465         (we just ignore them), but I think that's OK for now.
3466
3467         I also noticed that setting r- once a commit-queue node had grabbed
3468         a patch would not properly cancel the landing.  That's fixed and
3469         tested in this patch.
3470
3471         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3472         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3473         * Scripts/webkitpy/tool/bot/feeders.py:
3474         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
3475
3476 2011-01-08  Benjamin Poulain  <benjamin.poulain@nokia.com>
3477
3478         Reviewed by Kenneth Rohde Christiansen.
3479
3480         [Qt] QtWebKit crashes when using XMLHttpRequest from the unload event
3481         https://bugs.webkit.org/show_bug.cgi?id=51934
3482
3483         When accessing the network from the destructor of QWebPage, the network access manager
3484         was already deleted because the object WebPage was already destructed.
3485
3486         This solve the problem by linking the lifetime of the network access manager to WebPage's QObject.
3487         The object is now destructed in the destructor of QObject.
3488
3489         * QtTestBrowser/webpage.cpp:
3490         (WebPage::WebPage):
3491         (WebPage::setQnamThreaded):
3492         * QtTestBrowser/webpage.h:
3493         (QtNAMThread::QtNAMThread):
3494
3495 2011-01-08  Eric Seidel  <eric@webkit.org>
3496
3497         Reviewed by Ojan Vafai.
3498
3499         test_failures.py should not mention TestShell (long live DumpRenderTree!)
3500         https://bugs.webkit.org/show_bug.cgi?id=52067
3501
3502         I ran test-webkitpy, but didn't bother adding a unit test for this string change.
3503         https://bugs.webkit.org/show_bug.cgi?id=51138#c3 is an example of why this is needed.
3504
3505         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
3506
3507 2011-01-08  Eric Seidel  <eric@webkit.org>
3508
3509         Reviewed by Mihai Parparita.
3510
3511         commit-queue hangs when the ChangeLog diff is bad
3512         https://bugs.webkit.org/show_bug.cgi?id=52072
3513
3514         * Scripts/webkitpy/tool/steps/validatechangelogs.py:
3515         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
3516
3517 2011-01-08  Adam Barth  <abarth@webkit.org>
3518
3519         Teach svn-apply how to re-write WebCore to Source/WebCore.
3520
3521         * Scripts/VCSUtils.pm:
3522
3523 2011-01-07  Adam Barth  <abarth@webkit.org>
3524
3525         Rubber-stamped by Eric Seidel.
3526
3527         Move WebCore to Source
3528         https://bugs.webkit.org/show_bug.cgi?id=52050
3529
3530         Update the tools to understand WebCore's new location.
3531
3532         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3533         * DumpRenderTree/wscript:
3534         * GNUmakefile.am:
3535         * Scripts/build-webkit:
3536         * Scripts/do-file-rename:
3537         * Scripts/do-webcore-rename:
3538         * Scripts/generate-qt-inspector-resource:
3539         * Scripts/prepare-ChangeLog:
3540         * Scripts/run-bindings-tests:
3541         * Scripts/update-iexploder-cssproperties:
3542         * Scripts/update-sources-list.py:
3543         * Scripts/update-webkit-localizable-strings:
3544         * Scripts/webkitdirs.pm:
3545         * Scripts/webkitpy/common/config/build.py:
3546         * Scripts/webkitpy/common/config/build_unittest.py:
3547         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
3548         * Scripts/webkitpy/style/checker.py:
3549         * Scripts/webkitpy/style/checker_unittest.py:
3550         * WebKitTestRunner/DerivedSources.pro:
3551         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3552         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh:
3553         * wx/browser/wscript:
3554         * wx/build/settings.py:
3555
3556 2011-01-07  Maciej Stachowiak  <mjs@apple.com>
3557
3558         Reviewed by Sam Weinig.
3559
3560         Make WebKitTestRunner rest between loads more robust to avoid test crashes
3561         https://bugs.webkit.org/show_bug.cgi?id=52086
3562
3563         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3564         (WTR::InjectedBundle::didReceiveMessage):
3565         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3566         (WTR::LayoutTestController::notifyDone):
3567         * WebKitTestRunner/TestController.cpp:
3568         (WTR::TestController::resetStateToConsistentValues):
3569         (WTR::TestController::run):
3570
3571 2011-01-07  James Robinson  <jamesr@chromium.org>
3572
3573         Revert "Implement mozilla's animationTime property"
3574         https://bugs.webkit.org/show_bug.cgi?id=51952
3575
3576         This approach isn't quite right.
3577
3578         * DumpRenderTree/chromium/WebViewHost.cpp:
3579         (WebViewHost::paintInvalidatedRegion):
3580
3581 2011-01-07  Adam Roben  <aroben@apple.com>
3582
3583         Build master fix
3584
3585         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3586         (RunWebKitTests.start): Don't try to concatenate a list and a string.
3587
3588 2011-01-07  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>
3589
3590         Reviewed by Csaba Osztrogonác.
3591
3592         run-qtwebkit-tests should be able to kill a testsuite.
3593
3594         Add new option in the script that can setup a timeout for a test.
3595         If the test execution takes more then specified time then the test
3596         would be terminated.
3597
3598         [Qt] run-qtwebkit-tests needs timeout
3599         https://bugs.webkit.org/show_bug.cgi?id=51894
3600
3601         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3602         * Scripts/run-qtwebkit-tests:
3603
3604 2011-01-07  Csaba Osztrogonác  <ossy@webkit.org>
3605
3606         Unreviewed fix after r75233.
3607
3608         Based on idea from Eric Seidel.
3609
3610         Add remote zip file handling to webkitpy.
3611         https://bugs.webkit.org/show_bug.cgi?id=50901
3612
3613         * Scripts/webkitpy/common/system/fileset.py: Make python 2.5 happy.
3614
3615 2011-01-07  Shane Stephens  <shanestephens@google.com>
3616
3617         Reviewed by Eric Seidel.
3618
3619         svn-apply: should support git binary delta diffs
3620         https://bugs.webkit.org/show_bug.cgi?id=38864
3621
3622         * Scripts/VCSUtils.pm:
3623         * Scripts/svn-apply:
3624
3625 2011-01-06  Julie Parent  <jparent@chromium.org>
3626
3627         Reviewed by Eric Seidel.
3628
3629         Test Result Server not removing old results.
3630         https://bugs.webkit.org/show_bug.cgi?id=52012
3631
3632         * TestResultServer/model/jsonresults.py:
3633         Fix off-by-one: Truncate if >= num_runs, not just >.
3634         * TestResultServer/model/jsonresults_unittest.py:
3635         Add unit test to test that merging in a new result with the same value
3636         as the last result causes previous result to fall off.
3637
3638 2011-01-06  James Kozianski  <koz@chromium.org>
3639
3640         Reviewed by Mihai Parparita.
3641
3642         Add classes to provide a consistent interface to a set of files.
3643         https://bugs.webkit.org/show_bug.cgi?id=50901
3644
3645         These classes allow us to write code that is agnostic to whether a
3646         particular set of files resides in a local directory or in a zip file
3647         on a remote machine.
3648
3649         * Scripts/webkitpy/common/system/directoryfileset.py: Added.
3650         * Scripts/webkitpy/common/system/directoryfileset_unittest.py: Added.
3651         * Scripts/webkitpy/common/system/fileset.py: Added.
3652         * Scripts/webkitpy/common/system/filesystem.py:
3653         * Scripts/webkitpy/common/system/filesystem_mock.py:
3654         * Scripts/webkitpy/common/system/zipfileset.py: Added.
3655         * Scripts/webkitpy/common/system/zipfileset_unittest.py: Added.
3656
3657 2011-01-06  Eric Seidel  <eric@webkit.org>
3658
3659         Reviewed by Adam Barth.
3660
3661         NetworkTransaction should log the url it is retrying
3662         https://bugs.webkit.org/show_bug.cgi?id=52043
3663
3664         * Scripts/webkitpy/common/net/networktransaction.py:
3665         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
3666
3667 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
3668
3669         Windows build fix.
3670         Import os before using it.
3671
3672         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3673
3674 2011-01-06  Eric Seidel  <eric@webkit.org>
3675
3676         Reviewed by Adam Barth.
3677
3678         StyleQueue fails to report errors when patches have many files
3679         https://bugs.webkit.org/show_bug.cgi?id=52042
3680
3681         This is one of at least two errors preventing style error reporting at the moment.
3682         When we moved to passing the list of files to check explicitly,
3683         we started to exceed the 500 character TEXT field limit for our AppEngine model object.
3684         We could change the type of the QueueStatus.message type, or we could
3685         just teach statusserver.py how to clamp values (and warn when it does).
3686         I chose the latter path.
3687
3688         * Scripts/webkitpy/common/net/statusserver.py:
3689
3690 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
3691
3692         Reviewed by Stephanie Lewis.
3693         
3694         Fix syntax error in script.
3695
3696         Windows bots need to archive/unarchive builds to/from configuration-specific directories
3697         https://bugs.webkit.org/show_bug.cgi?id=51996
3698
3699         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3700
3701 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3702
3703         Unreviewed, fixing WinCE build after r75196.
3704
3705         WinCE port does not (yet) support NPAPI.
3706
3707         * Scripts/build-webkit:
3708
3709 2011-01-06  Xan Lopez  <xlopez@igalia.com>
3710
3711         Reviewed by Darin Adler.
3712
3713         File::Spec->rel2abs in sunspider-compare-results mangles parameters
3714         https://bugs.webkit.org/show_bug.cgi?id=52015
3715
3716         * Scripts/sunspider-compare-results: call rel2abs on our arguments
3717         after the platform has been detected, otherwise the script will
3718         mangle things like '--gtk' into '/a/path/--gtk', breaking the
3719         detection.
3720
3721 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3722
3723         Reviewed by Eric Seidel.
3724
3725         Add ENABLE_NETSCAPE_PLUGIN_API, ENABLE_ORIENTATION_EVENTS and ENABLE_TOUCH_EVENTS flags to build-webkit
3726         https://bugs.webkit.org/show_bug.cgi?id=51346
3727
3728         * Scripts/build-webkit:
3729
3730 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
3731
3732         Reviewed by Adam Roben.
3733
3734         Windows bots need to archive/unarchive builds to/from configuration-specific directories
3735         https://bugs.webkit.org/show_bug.cgi?id=51996
3736         
3737         After the configuration directory change, we were archiving the incorrect directory for
3738         build product, so we were running tests on the wrong binaries.
3739         
3740         This change archives the correct directory, and also unarchives it into a configuration-
3741         specific directory.
3742
3743         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Use a configuration-specific directory on Windows.
3744         * BuildSlaveSupport/built-product-archive: Unarchive/archive to/from proper directory.
3745
3746 2011-01-06  Eric Seidel  <eric@webkit.org>
3747
3748         Reviewed by Mihai Parparita.
3749
3750         commit-queue mentions "Text diff mismatch" 4 times instead of once per failure
3751         https://bugs.webkit.org/show_bug.cgi?id=52002
3752
3753         See an example of this here:
3754         https://bugs.webkit.org/show_bug.cgi?id=51314#c2
3755
3756         It's due to the fact that we pass around TestFailure() instance
3757         objects and yet expect them to all compare to be the same.
3758
3759         This is bad.  We should either have shared instances of these values
3760         or we should just pass around the class names.  There are already hacks
3761         in place to make TestFailure objects pass equality tests, I just added
3762         a __hash__ implementation so they can be used in sets as expected.
3763
3764         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3765         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
3766
3767 2011-01-06  Evan Martin  <evan@chromium.org>
3768
3769         Reviewed by Tony Chang.
3770
3771         [gdb] handle inaccessible memory and UChar*
3772         https://bugs.webkit.org/show_bug.cgi?id=52003
3773
3774         To pretty-print a UChar*, we just grope around in the memory
3775         looking for a terminating NUL.  We need to handle the exception
3776         that can occur when we poke into an invalid location.
3777
3778         Additionally, the logic for choosing which pretty-printer would
3779         early return before hitting the point where we'd use the UChar*
3780         printer.  (Did this ever work?  How did it regress?)
3781
3782         * gdb/webkit.py:
3783
3784 2011-01-05  Brian Weinstein  <bweinstein@apple.com>
3785
3786         Reviewed by Ada Chan.
3787
3788         WebKit2: Should be able to call into injected bundle to ask if we should allow resource loads
3789         https://bugs.webkit.org/show_bug.cgi?id=51969
3790         
3791         Add shouldLoadResourceForFrame to WTR::InjectedBundlePage.
3792
3793         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3794         (WTR::InjectedBundlePage::InjectedBundlePage):
3795         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Stub implementation.