Use simctl instead of LayoutTestRelay
[WebKit.git] / Tools / ChangeLog
1 2017-01-30  Jonathan Bedard  <jbedard@apple.com>
2
3         Use simctl instead of LayoutTestRelay
4         https://bugs.webkit.org/show_bug.cgi?id=165927
5
6         Reviewed by Daniel Bates.
7
8         Part 1
9
10         LayoutTestRelay uses SPI, since recent versions of the iOS SDK allow for installing apps on
11         simulators through simctl (iOS 10 and later), use this functionality instead.
12
13         * Scripts/webkitpy/port/base.py:
14         (Port.__init__): Added _test_runner_process_constructor.
15         * Scripts/webkitpy/port/darwin.py:
16         (DarwinPort.app_identifier_from_bundle): Added function to extract bundle ID from plist.
17         * Scripts/webkitpy/port/driver.py:
18         (Driver._start): Pass worker_number to server_process so we can look up the correct simulator device to use.
19         (IOSSimulatorDriver): Deleted.
20         * Scripts/webkitpy/port/driver_unittest.py:
21         (DriverTest.test_stop_cleans_up_properly): Set _test_runner_process_constructor for testing.
22         (DriverTest.test_two_starts_cleans_up_properly): Ditto.
23         (DriverTest.test_start_actually_starts): Ditto.
24         * Scripts/webkitpy/port/ios.py:
25         (IOSSimulatorPort): Remove relay_name.
26         (IOSSimulatorPort.__init__): Set _test_runner_process_constructor to SimulatorProcess for IOSSimulatorPort.
27         (IOSSimulatorPort._create_simulators): Formatting change.
28         (IOSSimulatorPort.relay_path): Deleted.
29         (IOSSimulatorPort._check_relay): Deleted.
30         (IOSSimulatorPort._check_port_build): Deleted. Use base class implementation
31         (IOSSimulatorPort._build_relay): Deleted.
32         (IOSSimulatorPort._build_driver): Deleted. Use base class implementation
33         (IOSSimulatorPort._driver_class): Deleted. Use base class implementation
34         * Scripts/webkitpy/port/ios_unittest.py:
35         (iosTest.test_32bit): Update test.
36         (iosTest.test_64bit): Update test.
37         * Scripts/webkitpy/port/server_process.py:
38         (ServerProcess.__init__): Added argument worker_number. This class does not make use of it. We will make use of this argument in SimulatorProcess to lookup the associated simulator device.
39         (ServerProcess._set_file_nonblocking): Added to share common code.
40         * Scripts/webkitpy/port/server_process_mock.py:
41         (MockServerProcess.__init__): Added argument worker_number.
42         * Scripts/webkitpy/port/simulator_process.py: Added.
43         (SimulatorProcess): Added.
44         (SimulatorProcess.Popen): Added.
45         (SimulatorProcess.Popen.__init__): Added. Initialize Popen structure with stdin, stdout, stderr and pid.
46         (SimulatorProcess.Popen.poll): Added. Check if the process is running.
47         (SimulatorProcess.Popen.wait): Added. Wait for process to close.
48         (SimulatorProcess.__init__): Added. Install app to device specified through port and worker_number.
49         (SimulatorProcess._reset): Added. Unlink fifos.
50         (SimulatorProcess._start): Added. Launch app on simulator, link fifos.
51         (SimulatorProcess._kill): Added. Shutdown app on simulator.
52         * Scripts/webkitpy/xcode/simulator.py:
53         (Device.__init__): Accept host to run install/launch/terminate.
54         (Device.install_app): Install app to target Device.
55         (Device.launch_app): Launch app on target Device.
56         (Device.terminate_app): Shutdown app on target Device.
57         (Simulator._parse_devices): Pass host to Device.
58
59 2017-01-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
60
61         [GTK] pixman fails to compile on Raspberry Pi (GCC crash)
62         https://bugs.webkit.org/show_bug.cgi?id=167411
63
64         Reviewed by Michael Catanzaro.
65
66         Disable the ARM iwMMXt fast path for pixman, because it triggers
67         a GCC bug on the RPi with Raspbian/PIXEL causing a build failure.
68
69         * gtk/jhbuild.modules:
70
71 2017-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
72
73         [GTK] Add API to handle the accelerated compositing policy
74         https://bugs.webkit.org/show_bug.cgi?id=167509
75
76         Reviewed by Michael Catanzaro.
77
78         Handle new setting in MiniBrowser. The settings dialog doesn't support enum settings so it needs to be handled
79         as a special case. Also add test cases to the get/set API.
80
81         * MiniBrowser/gtk/BrowserSettingsDialog.c:
82         (hardwareAccelerationPolicyToString):
83         (stringToHardwareAccelerationPolicy):
84         (cellRendererChanged):
85         (browserSettingsDialogConstructed):
86         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
87         (testWebKitSettings):
88
89 2017-01-29  Andy Estes  <aestes@apple.com>
90
91         [QuickLook] Add a WebPreference to enable saving QuickLook documents in WebKitLegacy
92         https://bugs.webkit.org/show_bug.cgi?id=167563
93         <rdar://problem/30253207>
94
95         Reviewed by Andreas Kling.
96
97         * TestWebKitAPI/Tests/WebKit2Cocoa/QuickLook.mm:
98         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
99         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
100         (runTest):
101         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
102         (TEST):
103
104 2017-01-29  Dan Bernstein  <mitz@apple.com>
105
106         [iOS] Expose WebCore::DataDetection::detectContentInRange WKWebProcessPlugInRangeHandle
107         https://bugs.webkit.org/show_bug.cgi?id=167565
108
109         Reviewed by Sam Weinig.
110
111         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
112         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandle.mm: Added.
113         (-[BundleRangeHandleRemoteObject textFromBodyRange:]):
114         (-[BundleRangeHandleRemoteObject bodyInnerHTMLAfterDetectingData:]):
115         (TEST):
116         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandlePlugIn.mm: Added.
117         (-[BundleRangeHandlePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
118         (-[BundleRangeHandlePlugIn webProcessPlugInBrowserContextController:didFinishDocumentLoadForFrame:]):
119         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandleProtocol.h: Added.
120
121 2017-01-28  Yoav Weiss  <yoav@yoav.ws>
122
123         Add Link Preload as an off-by-default experimental feature menu item.
124         https://bugs.webkit.org/show_bug.cgi?id=167201
125
126         Reviewed by Ryosuke Niwa.
127
128         * DumpRenderTree/mac/DumpRenderTree.mm:
129         (resetWebPreferencesToConsistentValues):
130         * DumpRenderTree/win/DumpRenderTree.cpp:
131         (resetWebPreferencesToConsistentValues):
132
133 2017-01-28  Joseph Pecoraro  <pecoraro@apple.com>
134
135         Add User Timing Experimental Feature
136         https://bugs.webkit.org/show_bug.cgi?id=167542
137         <rdar://problem/22746307>
138
139         Reviewed by Ryosuke Niwa.
140
141         * DumpRenderTree/mac/DumpRenderTree.mm:
142         (enableExperimentalFeatures):
143         (resetWebPreferencesToConsistentValues):
144         * DumpRenderTree/win/DumpRenderTree.cpp:
145         (enableExperimentalFeatures):
146
147 2017-01-28  Joseph Pecoraro  <pecoraro@apple.com>
148
149         Patch Review: EWS Bubbles wrap to multiple lines but can fit on one line
150         https://bugs.webkit.org/show_bug.cgi?id=167519
151
152         Reviewed by Ryosuke Niwa.
153
154         * QueueStatusServer/templates/statusbubble.html:
155         To measure the bubbleContainer's width, it must not be wrapping based
156         on its parent container. So when measuring the width temporarily set
157         the parent to a very large width so as to not artificially wrap us.
158         Restore the parent's width after measuring.
159
160 2017-01-27  Andy Estes  <aestes@apple.com>
161
162         [iOS] Add a test for _WKNSFileManagerExtras
163         https://bugs.webkit.org/show_bug.cgi?id=167478
164
165         Reviewed by Andreas Kling.
166
167         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
168         * TestWebKitAPI/Tests/WebKit2Cocoa/NSFileManagerExtras.mm: Added.
169         (expectAttributes):
170         (TEST):
171
172 2017-01-27  Keith Miller  <keith_miller@apple.com>
173
174         run-benchmarks should make sure it passes the test url to the right application
175         https://bugs.webkit.org/show_bug.cgi?id=167533
176
177         Reviewed by Joseph Pecoraro.
178
179         This fixes an issue when trying to run-benchmark script with the
180         system default browser set to STP. Previously, it would run
181         the test in STP rather than the provided build. Now, it should run
182         in the provided build.
183
184         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
185         (OSXSafariDriver.launch_url):
186
187 2017-01-27  Myles C. Maxfield  <mmaxfield@apple.com>
188
189         [Cocoa] Prepare ComplexTextController for unit testing
190         https://bugs.webkit.org/show_bug.cgi?id=167493
191
192         Reviewed by Simon Fraser.
193
194         Addressing post-review comments from Simon Fraser.
195
196         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
197         (TestWebKitAPI::TEST_F):
198
199 2017-01-27  Myles C. Maxfield  <mmaxfield@apple.com>
200
201         [Cocoa] Prepare ComplexTextController for unit testing
202         https://bugs.webkit.org/show_bug.cgi?id=167493
203
204         Reviewed by Dean Jackson.
205
206         Create four unit tests.
207
208         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
209         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp: Added.
210         (TestWebKitAPI::ComplexTextControllerTest::SetUp):
211         (TestWebKitAPI::TEST_F):
212
213 2017-01-26  Chris Dumez  <cdumez@apple.com>
214
215         Crash when navigating back to a page in PacheCache when one of its frames has been removed
216         https://bugs.webkit.org/show_bug.cgi?id=167421
217         <rdar://problem/30188490>
218
219         Reviewed by Darin Adler.
220
221         Add a new setting allowing layout tests to enable PageCache in a window
222         that has an opener, for convenience.
223
224         * DumpRenderTree/mac/DumpRenderTree.mm:
225         (resetWebPreferencesToConsistentValues):
226         * DumpRenderTree/win/DumpRenderTree.cpp:
227         (resetWebPreferencesToConsistentValues):
228         * WebKitTestRunner/TestController.cpp:
229         (WTR::TestController::resetPreferencesToConsistentValues):
230
231 2017-01-26  Keith Miller  <keith_miller@apple.com>
232
233         classInfo should take a VM so it is not materialized from the object on each call
234         https://bugs.webkit.org/show_bug.cgi?id=167424
235
236         Rubber Stamped by Michael Saboff.
237
238         Previously, classInfo() would get the VM from the target's
239         MarkedBlock.  Most callers already have a VM on hand, so it is
240         wasteful to compute the VM from the marked block every time. This
241         patch refactors some of the most common callers of classInfo(),
242         jsDynamicCast and inherits to take a VM as well.
243
244         * DumpRenderTree/TestRunner.cpp:
245         (setAudioResultCallback):
246
247 2017-01-26  Jer Noble  <jer.noble@apple.com>
248
249         Autoplay muted videos stop playback of any streaming app in the background
250         https://bugs.webkit.org/show_bug.cgi?id=163993
251         <rdar://problem/29020431>
252
253         Reviewed by Eric Carlson.
254
255         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
256         * TestWebKitAPI/Tests/WebKit/ios/AudioSessionCategoryIOS.mm:
257         (TestWebKitAPI::TEST):
258         * TestWebKitAPI/Tests/WebKit/ios/video-with-muted-audio-and-webaudio.html: Added.
259
260 2017-01-26  Ryan Haddad  <ryanhaddad@apple.com>
261
262         Disable API test WebKit2.WebsitePoliciesPlayAfterPreventedAutoplay.
263         https://bugs.webkit.org/show_bug.cgi?id=167466
264
265         Unreviewed test gardening.
266
267         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
268         (TEST):
269
270 2017-01-26  Matt Rajca  <mrajca@apple.com>
271
272         Notify clients when the user plays media otherwise prevented from autoplaying
273         https://bugs.webkit.org/show_bug.cgi?id=167390
274
275         Reviewed by Alex Christensen.
276
277         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
278         * TestWebKitAPI/Tests/WebKit2/autoplay-with-controls.html: Added.
279         * TestWebKitAPI/Tests/WebKit2/js-play-with-controls.html: Added.
280         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
281         (didPlayMediaPreventedFromPlayingWithoutUserGesture):
282         (TEST):
283         * TestWebKitAPI/cocoa/TestWKWebView.h:
284         * TestWebKitAPI/cocoa/TestWKWebView.mm:
285         (-[TestWKWebViewHostWindow _mouseUpAtPoint:]):
286         (-[TestWKWebView waitForLoad]):
287         (-[TestWKWebView mouseUpAtPoint:]):
288         * WebKitTestRunner/TestController.cpp:
289         (WTR::TestController::createOtherPage):
290         (WTR::TestController::createWebViewWithOptions):
291
292 2017-01-26  Per Arne Vollan  <pvollan@apple.com>
293
294         Crash when setting custom scale factor.
295         https://bugs.webkit.org/show_bug.cgi?id=167369
296
297         Reviewed by Sam Weinig.
298
299         Added API test.
300
301         * TestWebKitAPI/PlatformWin.cmake:
302         * TestWebKitAPI/Tests/WebKit/win/ScaleWebView.cpp: Added.
303         (TestWebKitAPI::WebKitCreateInstance):
304         (TestWebKitAPI::ScaleWebView::SetUp):
305         (TestWebKitAPI::ScaleWebView::TearDown):
306         (TestWebKitAPI::TEST_F):
307
308 2017-01-25  Ryosuke Niwa  <rniwa@webkit.org>
309
310         run-benchmark nests MotionMark results by the suite name twice
311         https://bugs.webkit.org/show_bug.cgi?id=164948
312
313         Reviewed by Said Abou-Hallawa.
314
315         Use a single level MotionMark now that this is the name of the benchmark,
316         and we no longer have tests that aren't part of the MotionMark suite.
317
318         * Scripts/webkitpy/benchmark_runner/data/patches/MotionMark.patch:
319
320 2017-01-25  Ryan Haddad  <ryanhaddad@apple.com>
321
322         Unreviewed, rolling out r211193.
323
324         This change broke internal builds.
325
326         Reverted changeset:
327
328         "Notify clients when the user plays media otherwise prevented
329         from autoplaying"
330         https://bugs.webkit.org/show_bug.cgi?id=167390
331         http://trac.webkit.org/changeset/211193
332
333 2017-01-25  Matt Rajca  <mrajca@apple.com>
334
335         Notify clients when the user plays media otherwise prevented from autoplaying
336         https://bugs.webkit.org/show_bug.cgi?id=167390
337
338         Reviewed by Alex Christensen.
339
340         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
341         * TestWebKitAPI/Tests/WebKit2/autoplay-with-controls.html: Added.
342         * TestWebKitAPI/Tests/WebKit2/js-play-with-controls.html: Added.
343         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
344         (didPlayMediaPreventedFromPlayingWithoutUserGesture):
345         (TEST):
346         * TestWebKitAPI/cocoa/TestWKWebView.h:
347         * TestWebKitAPI/cocoa/TestWKWebView.mm:
348         (-[TestWKWebViewHostWindow _mouseUpAtPoint:]):
349         (-[TestWKWebView waitForLoad]):
350         (-[TestWKWebView mouseUpAtPoint:]):
351         * WebKitTestRunner/TestController.cpp:
352         (WTR::TestController::createOtherPage):
353         (WTR::TestController::createWebViewWithOptions):
354
355 2017-01-25  Matt Rajca  <mrajca@apple.com>
356
357         [ios-simulator] API test WebKit2.WebsitePoliciesAutoplayEnabled timing out
358         https://bugs.webkit.org/show_bug.cgi?id=167385
359
360         Reviewed by Alex Christensen.
361
362         * TestWebKitAPI/Tests/WebKit2/autoplay-check.html: Avoid arbitrary timeouts in favor of promises.
363         * TestWebKitAPI/Tests/WebKit2/autoplay-no-audio-check.html:
364         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
365         (TEST): Allow inline (rather than full screen) media playback on iOS.
366
367 2017-01-25  Carlos Garcia Campos  <cgarcia@igalia.com>
368
369         [GTK] Icon Database should be in private browsing mode for ephemeral web views
370         https://bugs.webkit.org/show_bug.cgi?id=167414
371
372         Reviewed by Michael Catanzaro.
373
374         Add a test case to check ephemeral web views don't write favicons to the database.
375
376         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:
377         (ephemeralViewLoadChanged):
378         (testPrivateBrowsing):
379         (testFaviconDatabase):
380
381 2017-01-25  Carlos Garcia Campos  <cgarcia@igalia.com>
382
383         [GTK] Add a private browsing mode to MiniBrowser
384         https://bugs.webkit.org/show_bug.cgi?id=167413
385
386         Reviewed by Michael Catanzaro.
387
388         Add -p/--private command line option to create a private instance. Also add CTRL+SHIFT+P shortcut to create
389         private windows, even on non-private instances.
390
391         * MiniBrowser/gtk/BrowserWindow.c:
392         (webViewTitleChanged): Add [Private] to title window for private windows.
393         (webViewCreate): Pass web context to browser_window_new.
394         (openPrivateWindow): Create a new ephemeral web view and add it to a new window.
395         (browserWindowFinalize): Disconnect web context signal handlers.
396         (browser_window_init): Add shortcut for opening private window.
397         (browser_window_new): It now receives the context and connect to download-started here.
398         (browser_window_get_web_context): Return the context.
399         * MiniBrowser/gtk/BrowserWindow.h:
400         * MiniBrowser/gtk/main.c:
401         (createBrowserTab): Create the web view for the window web context.
402         (aboutDataScriptMessageReceivedCallback): Do not use the default web context, but the window one.
403         (aboutDataHandleRequest): Ditto.
404         (aboutURISchemeRequestCallback): Ditto.
405         (main): Create ephemeral web context if private command line option is used.
406
407 2017-01-25  Ryosuke Niwa  <rniwa@webkit.org>
408
409         collectMatchingElementsInFlatTree should not find elements inside an user agent shadow tree
410         https://bugs.webkit.org/show_bug.cgi?id=167409
411
412         Reviewed by Antti Koivisto.
413
414         Added a test case for collectMatchingElementsInFlatTree not finding elements inside an user agent shadow tree
415         as well as tests for the newly added matchingElementInFlatTree.
416
417         * TestWebKitAPI/Tests/WebKit2/InjectedBundleMakeAllShadowRootsOpen.cpp:
418         (TestWebKitAPI::runJavaScriptAlert):
419         * TestWebKitAPI/Tests/WebKit2/InjectedBundleMakeAllShadowRootsOpen_Bundle.cpp:
420         (TestWebKitAPI::InjectedBundleMakeAllShadowRootOpenTest::initialize):
421         * TestWebKitAPI/Tests/WebKit2/closed-shadow-tree-test.html:
422
423 2017-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
424
425         [GTK] Add API to create ephemeral web views and deprecate the private browsing setting
426         https://bugs.webkit.org/show_bug.cgi?id=167370
427
428         Reviewed by Michael Catanzaro.
429
430         Add several test cases of ephemeral web views.
431
432         * TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp:
433         (testWebViewAuthenticationStorage):
434         * TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp:
435         (ephemeralViewloadChanged):
436         (testCookieManagerEphemeral):
437         (beforeAll):
438         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
439         (testWebKitSettings):
440         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
441         (testWebContextEphemeral):
442         (ephemeralViewloadChanged):
443         (testWebContextProxySettings):
444         (beforeAll):
445         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
446         (ephemeralViewloadChanged):
447         (testWebViewEphemeral):
448         (beforeAll):
449         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebsiteData.cpp:
450         (ephemeralViewloadChanged):
451         (testWebsiteDataEphemeral):
452         (beforeAll):
453
454 2017-01-24  Alex Christensen  <achristensen@webkit.org>
455
456         REGRESSION (r208902): URLWithUserTypedString returns nil with file URLs
457         https://bugs.webkit.org/show_bug.cgi?id=167402
458
459         Reviewed by Ryosuke Niwa.
460
461         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm:
462         (TestWebKitAPI::TEST):
463
464 2017-01-24  Zalan Bujtas  <zalan@apple.com>
465
466         Add simple line layout toggle to MiniBrowser
467         https://bugs.webkit.org/show_bug.cgi?id=167405
468
469         Reviewed by Andreas Kling.
470
471         * MiniBrowser/mac/SettingsController.h:
472         * MiniBrowser/mac/SettingsController.m:
473         (-[SettingsController _populateMenu]):
474         (-[SettingsController validateMenuItem:]):
475         (-[SettingsController toggleSimpleLineLayoutEnabled:]):
476         (-[SettingsController simpleLineLayoutEnabled]):
477         * MiniBrowser/mac/WK1BrowserWindowController.m:
478         (-[WK1BrowserWindowController didChangeSettings]):
479         * MiniBrowser/mac/WK2BrowserWindowController.m:
480         (-[WK2BrowserWindowController didChangeSettings]):
481
482 2017-01-24  Joseph Pecoraro  <pecoraro@apple.com>
483
484         WKR does not include my nick when commit-queue lands my patch
485         https://bugs.webkit.org/show_bug.cgi?id=167388
486
487         Reviewed by Ryosuke Niwa.
488
489         * Scripts/webkitpy/tool/commands/newcommitbot.py:
490         (NewCommitBot._summarize_commit_log):
491         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py:
492         Perform nickname insertion before grabbing "Patch by" details.
493         This way we can include the nickname with the full name.
494
495 2017-01-24  Joseph Pecoraro  <pecoraro@apple.com>
496
497         Fold USER_TIMING into WEB_TIMING and make it a RuntimeEnabledFeature
498         https://bugs.webkit.org/show_bug.cgi?id=167394
499
500         Reviewed by Ryosuke Niwa.
501
502         * Scripts/webkitperl/FeatureList.pm:
503         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
504
505 2017-01-24  Youenn Fablet  <youenn@apple.com>
506
507         [WebRTC] Use HAVE_PTHREAD_COND_TIMEDWAIT_RELATIVE for libwebrtc
508         https://bugs.webkit.org/show_bug.cgi?id=167353
509
510         Reviewed by Alex Christensen.
511
512         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
513         (CMakeGenerator.initialize_targets):
514
515 2017-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
516
517         WKR should not confuse Miguel Gomez with Andres Gomez
518         https://bugs.webkit.org/show_bug.cgi?id=167389
519
520         Reviewed by Lucas Forschler.
521
522         Andres's email is a substring of Miguel's, causing WKR to credit Miguel's commits to
523         "mAndres Gomez". Fix this.
524
525         * Scripts/webkitpy/tool/commands/newcommitbot.py:
526         (NewCommitBot._summarize_commit_log): Be stricter about matching emails. SVN logs include a
527         space on each side of the email address, so expect both spaces to be there before
528         considering the email for replacement.
529         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py: Add a test.
530
531 2017-01-24  Matt Rajca  <mrajca@apple.com>
532
533         Pass down website autoplay policies to media elements
534         https://bugs.webkit.org/show_bug.cgi?id=167355
535
536         Reviewed by Alex Christensen.
537
538         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
539         * TestWebKitAPI/Tests/WebKit2/autoplay-check.html: Renamed from Tools/TestWebKitAPI/Tests/WebKit2/autoplayCheck.html to match our naming conventions.
540         * TestWebKitAPI/Tests/WebKit2/autoplay-no-audio-check.html: Added.
541         * TestWebKitAPI/Tests/WebKit2/test-without-audio-track.mp4: Added.
542         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
543         (-[AutoplayPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
544         (TEST):
545
546 2017-01-24  Nan Wang  <n_wang@apple.com>
547
548         AX: Speak Selection does not work in an iframe
549         https://bugs.webkit.org/show_bug.cgi?id=166794
550         <rdar://problem/29913013>
551
552         Reviewed by Chris Fleizach.
553
554         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
555         (WTR::UIScriptController::retrieveSpeakSelectionContent):
556         (WTR::UIScriptController::accessibilitySpeakSelectionContent):
557         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
558         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
559         (WTR::UIScriptController::retrieveSpeakSelectionContent):
560         (WTR::UIScriptController::accessibilitySpeakSelectionContent):
561         * TestRunnerShared/UIScriptContext/UIScriptController.h:
562         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
563         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
564         (-[TestRunnerWKWebView dealloc]):
565         (-[TestRunnerWKWebView _accessibilityDidGetSpeakSelectionContent:]):
566         (-[TestRunnerWKWebView accessibilityRetrieveSpeakSelectionContentWithCompletionHandler:]):
567         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
568         (WTR::UIScriptController::retrieveSpeakSelectionContent):
569         (WTR::UIScriptController::accessibilitySpeakSelectionContent):
570
571 2017-01-24  Daniel Bates  <dabates@apple.com>
572
573         StringView.split() should use an iterator design pattern instead of allocating a Vector
574         https://bugs.webkit.org/show_bug.cgi?id=163225
575
576         Reviewed by Darin Adler.
577
578         Add unit tests for StringView.split().
579
580         * TestWebKitAPI/Tests/WTF/StringView.cpp:
581         (TestWebKitAPI::stringViewFromLiteral): Moved to the top of the file so that it can be
582         used in the StringView.split() unit tests.
583         (TestWebKitAPI::stringViewFromUTF8): Ditto.
584         (TestWebKitAPI::vectorFromSplitResult): Convenience function to convert a StringView::SplitResult
585         object to a Vector of String objects.
586         (TestWebKitAPI::TEST): Added the following tests:
587             - WTF.StringViewSplitEmptyAndNullStrings
588             - WTF.StringViewSplitBasic
589             - WTF.StringViewSplitWithConsecutiveSeparators
590
591 2017-01-23  Anders Carlsson  <andersca@apple.com>
592
593         The Score Esports crashes on launch
594         https://bugs.webkit.org/show_bug.cgi?id=167338
595         rdar://problem/29948645
596
597         Reviewed by Dan Bernstein.
598
599         * TestWebKitAPI/Tests/WebKit2Cocoa/WKObject.mm:
600         (TestWebKitAPI::TEST):
601         Add a test.
602
603 2017-01-23  Carlos Garcia Campos  <cgarcia@igalia.com>
604
605         [GTK] Add API to WebKitWebsiteDataManager to handle website data
606         https://bugs.webkit.org/show_bug.cgi?id=146589
607
608         Reviewed by Michael Catanzaro.
609
610         Add about:data handler to MiniBrowser to manually test the website data API. Also add unit tests to test all the
611         new API, moving the WebKitWebsiteDataManager configuration API to the new file too.
612
613         * MiniBrowser/gtk/BrowserWindow.c:
614         (webViewDecidePolicy):
615         (newTabCallback):
616         * MiniBrowser/gtk/main.c:
617         (createBrowserTab):
618         (aboutDataRequestFree):
619         (aboutDataRequestNew):
620         (aboutDataRequestForView):
621         (websiteDataRemovedCallback):
622         (websiteDataClearedCallback):
623         (aboutDataScriptMessageReceivedCallback):
624         (domainListFree):
625         (aboutDataFillTable):
626         (gotWebsiteDataCallback):
627         (aboutDataHandleRequest):
628         (aboutURISchemeRequestCallback):
629         (main):
630         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
631         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
632         (serverCallback):
633         (beforeAll):
634         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebsiteData.cpp: Added.
635         (serverCallback):
636         (WebsiteDataTest::WebsiteDataTest):
637         (WebsiteDataTest::~WebsiteDataTest):
638         (WebsiteDataTest::fetch):
639         (WebsiteDataTest::remove):
640         (WebsiteDataTest::clear):
641         (testWebsiteDataConfiguration):
642         (testWebsiteDataCache):
643         (testWebsiteDataStorage):
644         (testWebsiteDataDatabases):
645         (testWebsiteDataAppcache):
646         (beforeAll):
647         (afterAll):
648
649 2017-01-23  Commit Queue  <commit-queue@webkit.org>
650
651         Unreviewed, rolling out r211062.
652         https://bugs.webkit.org/show_bug.cgi?id=167354
653
654         broke API tests (Requested by alexchristensen on #webkit).
655
656         Reverted changeset:
657
658         "Pass down website autoplay policies to media elements"
659         https://bugs.webkit.org/show_bug.cgi?id=167132
660         http://trac.webkit.org/changeset/211062
661
662 2017-01-23  Alex Christensen  <achristensen@webkit.org>
663
664         URLParser should fail to parse percent-encoded invalid UTF-8 sequences
665         https://bugs.webkit.org/show_bug.cgi?id=167330
666
667         Reviewed by Tim Horton.
668
669         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
670         (TestWebKitAPI::TEST_F):
671
672 2017-01-23  Alex Christensen  <achristensen@webkit.org>
673
674         Make URLs with non-special schemes and a query or fragment but no slash after the host more compatible
675         https://bugs.webkit.org/show_bug.cgi?id=167317
676
677         Reviewed by Sam Weinig.
678
679         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
680         (TestWebKitAPI::TEST_F):
681
682 2017-01-23  Jonathan Bedard  <jbedard@apple.com>
683
684         svn-create-patch should emit properties when files are moved or copied
685         https://bugs.webkit.org/show_bug.cgi?id=167264
686
687         Reviewed by Daniel Bates.
688
689         * Scripts/svn-create-patch:
690         (manufacturePatchForAdditionWithHistory): Diff the source file against nothing to get properties.
691
692 2017-01-23  Youenn Fablet  <youenn@apple.com>
693
694         [WebRTC] Filter libwebrtc link flags
695         https://bugs.webkit.org/show_bug.cgi?id=167287
696
697         Reviewed by Alex Christensen.
698
699         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
700         (CMakeGenerator._compute_link_flags):
701         (CMakeGenerator._compute_link_flags.keep_flag):
702         (CMakeGenerator._generate_compile_target_options):
703
704 2017-01-23  Youenn Fablet  <youennf@gmail.com>
705
706         [WebRTC] Make VP8 optional in libwebrtc
707         https://bugs.webkit.org/show_bug.cgi?id=167257
708
709         Reviewed by Darin Adler.
710
711         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
712         (CMakeGenerator.remove_libvpx): Adding vp8_noop.cc to the build system.
713
714 2017-01-23  Jer Noble  <jer.noble@apple.com>
715
716         Video details does not apear and missing scrubber in Control Center
717         https://bugs.webkit.org/show_bug.cgi?id=167233
718
719         Reviewed by Alex Christensen.
720
721         Refactor TestWKWebViewMac to work on PLATFORM(IOS). Add a new test to
722         NowPlayingControlTests for iOS.
723
724         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
725         * TestWebKitAPI/Tests/WebKit2Cocoa/NowPlayingControlsTests.mm:
726         (-[NowPlayingTestWebView setWindowVisible:]):
727         (TestWebKitAPI::TEST):
728         * TestWebKitAPI/Tests/WebKit2Cocoa/SnapshotStore.mm:
729         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
730         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewCandidateTests.mm:
731         * TestWebKitAPI/cocoa/TestWKWebView.h: Renamed from Tools/TestWebKitAPI/mac/TestWKWebViewMac.h.
732         * TestWebKitAPI/cocoa/TestWKWebView.mm: Renamed from Tools/TestWebKitAPI/mac/TestWKWebViewMac.mm.
733         (SOFT_LINK_CLASS):
734         (-[TestMessageHandler addMessage:withHandler:]):
735         (-[TestMessageHandler userContentController:didReceiveScriptMessage:]):
736         (__simulated_forceClickAssociatedEventsMask):
737         (-[TestWKWebViewHostWindow _mouseDownAtPoint:simulatePressure:]):
738         (-[TestWKWebViewHostWindow isKeyWindow]):
739         (-[TestWKWebViewHostWindow makeKeyWindow]):
740         (-[TestWKWebViewHostWindow resignKeyWindow]):
741         (-[TestWKWebView initWithFrame:]):
742         (-[TestWKWebView initWithFrame:configuration:]):
743         (-[TestWKWebView _setUpTestWindow:]):
744         (-[TestWKWebView performAfterReceivingMessage:action:]):
745         (-[TestWKWebView loadTestPageNamed:]):
746         (-[TestWKWebView synchronouslyLoadTestPageNamed:]):
747         (-[TestWKWebView stringByEvaluatingJavaScript:]):
748         (-[TestWKWebView waitForMessage:]):
749         (-[TestWKWebView performAfterLoading:]):
750         (-[TestWKWebView mouseDownAtPoint:simulatePressure:]):
751         (-[TestWKWebView typeCharacter:]):
752
753 2017-01-21  Carlos Garcia Campos  <cgarcia@igalia.com>
754
755         Unreviewed. Bring back gtk-doc error messages after r209981.
756
757         Since r209981, if gtk-doc shows warnings the build fails but those warnings are not printed to stdout so it's
758         impossible to know what's wrong.
759
760         * gtk/gtkdoc.py:
761         (GTKDoc._run_command): Make print_output True by default again and use debug instead of info to log "Running" messages.
762
763 2017-01-20  Youenn Fablet  <youennf@gmail.com>
764
765         [WebRTC] Update build system to make G711 optional in libwebrtc
766         https://bugs.webkit.org/show_bug.cgi?id=167256
767
768         Reviewed by Alex Christensen.
769
770         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
771         (CMakeGenerator.remove_webrtc_g711): Adding a missing file to the build system as this file includes generic pcm encoder functions.
772
773 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
774
775         Cleanup RuntimeEnabledFeatures
776         https://bugs.webkit.org/show_bug.cgi?id=167228
777
778         Reviewed by Simon Fraser.
779
780         * DumpRenderTree/mac/DumpRenderTree.mm:
781         (enableExperimentalFeatures):
782         (resetWebPreferencesToConsistentValues):
783         (setWebPreferencesForTestOptions):
784         (resetWebViewToConsistentStateBeforeTesting):
785         * DumpRenderTree/win/DumpRenderTree.cpp:
786         (enableExperimentalFeatures):
787         (resetWebPreferencesToConsistentValues):
788         More closely match WebKitTestRunner initialization of preferences
789         for experimental features.
790
791 2017-01-20  Alex Christensen  <achristensen@webkit.org>
792
793         Build Fix for Windows DumpRenderTree after r210976
794         https://bugs.webkit.org/show_bug.cgi?id=167115
795
796         * DumpRenderTree/win/DumpRenderTree.cpp:
797         (resetWebPreferencesToConsistentValues):
798
799 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
800
801         Remove outdated ENABLE(CSP_NEXT) build flag
802         https://bugs.webkit.org/show_bug.cgi?id=167252
803
804         Reviewed by Brent Fulgham.
805
806         * Scripts/webkitperl/FeatureList.pm:
807         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
808
809 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
810
811         Build Fix for Windows DumpRenderTree after r210976
812
813         * DumpRenderTree/win/DumpRenderTree.cpp:
814         (resetWebPreferencesToConsistentValues):
815
816 2017-01-20  Antoine Quint  <graouts@apple.com>
817
818         Web Animations should be off by default and enabled as an experimental feature
819         https://bugs.webkit.org/show_bug.cgi?id=167115
820         <rdar://problem/30048963>
821
822         Reviewed by Joseph Pecoraro.
823
824         Turn Web Animations on in DRT.
825
826         * DumpRenderTree/mac/DumpRenderTree.mm:
827         (resetWebPreferencesToConsistentValues):
828         * DumpRenderTree/win/DumpRenderTree.cpp:
829         (resetWebPreferencesToConsistentValues):
830
831 2017-01-20  Youenn Fablet  <youenn@apple.com>
832
833         [WebRTC] Add libwebrtc build infrastructure
834         https://bugs.webkit.org/show_bug.cgi?id=167207
835
836         Reviewed by Alex Christensen.
837
838         Adding a script doing the libwebrtc project json to CMake file conversion.
839
840         * Scripts/generate-libwebrtc-cmake: Added.
841         * Scripts/webkitpy/libwebrtc/__init__.py: Added.
842         * Scripts/webkitpy/libwebrtc/generate_cmake.py: Added.
843
844 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
845
846         Mini Browser: Show tooltip for Experimental Features
847         https://bugs.webkit.org/show_bug.cgi?id=167225
848
849         Reviewed by Alex Christensen.
850
851         * MiniBrowser/mac/SettingsController.m:
852         (-[SettingsController _populateMenu]):
853         Include the full details string as a tooltip.
854
855 2017-01-20  Per Arne Vollan  <pvollan@apple.com>
856
857         [Win] Test output results should not be written twice.
858         https://bugs.webkit.org/show_bug.cgi?id=167197
859
860         Reviewed by Brent Fulgham.
861
862         Prevent test output from being written twice by returning early from
863         the dump() function, if it already has been called.
864         This patch also adds a missing newline to a test output line. 
865         
866         * DumpRenderTree/win/DumpRenderTree.cpp:
867         (dump):
868
869 2017-01-20  Antoine Quint  <graouts@apple.com>
870
871         [Modern Media Controls] Turn modern media controls on by default
872         https://bugs.webkit.org/show_bug.cgi?id=165668
873
874         Reviewed by Dean Jackson.
875
876         Enabled modern media controls by default in test runners.
877
878         * DumpRenderTree/TestOptions.h:
879         * WebKitTestRunner/TestOptions.h:
880
881 2017-01-19  Chris Dumez  <cdumez@apple.com>
882
883         iterable<> should be enabled on WK1
884         https://bugs.webkit.org/show_bug.cgi?id=167221
885         <rdar://problem/30108531>
886
887         Reviewed by Youenn Fablet.
888
889         * DumpRenderTree/mac/DumpRenderTree.mm:
890         (resetWebPreferencesToConsistentValues):
891         * DumpRenderTree/win/DumpRenderTree.cpp:
892         (resetWebPreferencesToConsistentValues):
893         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
894         (WTR::InjectedBundle::beginTesting):
895         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
896         (WTR::TestRunner::setDOMIteratorEnabled): Deleted.
897         * WebKitTestRunner/InjectedBundle/TestRunner.h:
898
899 2017-01-19  Aakash Jain  <aakash_jain@apple.com>
900
901         Ensure status server logs go to log file
902         https://bugs.webkit.org/show_bug.cgi?id=167210
903
904         Reviewed by Alexey Proskuryakov.
905
906         * Scripts/webkitpy/common/net/statusserver.py:
907         (StatusServer.next_work_item): Change log level from debug to info in
908         order to facilitate deubgging issues.
909         (StatusServer.update_work_items): Same.
910
911 2017-01-19  Megan Gardner  <megan_gardner@apple.com>
912
913         Additional selection tests and interpolation fix
914         https://bugs.webkit.org/show_bug.cgi?id=167171
915
916         Reviewed by Simon Fraser.
917
918         We weren't adding the final event when interpolating event streams.
919
920         * WebKitTestRunner/ios/HIDEventGenerator.mm:
921         (-[HIDEventGenerator interpolatedEvents:]):
922
923 2017-01-19  Myles C. Maxfield  <mmaxfield@apple.com>
924
925         [Cocoa] Variation fonts are erroneously disabled on iOS
926         https://bugs.webkit.org/show_bug.cgi?id=167172
927
928         Reviewed by Simon Fraser.
929
930         OpenSource builders don't seem to understand sdk=embedded*.
931
932         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
933
934 2017-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
935
936         Unreviewed. Fix GTK+ unit tests failing since r210531.
937
938         Avoid using paths to files that don't actually exist.
939
940         * TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp:
941         (testWebKitConsoleMessageNetworkError):
942         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
943         (testContextMenuDefaultMenu):
944         * TestWebKitAPI/Tests/WebKit2Gtk/resources/silence.mpg: Added.
945         * TestWebKitAPI/Tests/WebKit2Gtk/resources/simple.json: Added.
946         * TestWebKitAPI/Tests/WebKit2Gtk/resources/tracks.ogg: Added.
947
948 2017-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
949
950         [GTK] Provide API to set proxy settings
951         https://bugs.webkit.org/show_bug.cgi?id=128674
952
953         Reviewed by Michael Catanzaro.
954
955         Add tests for new proxy settings API.
956
957         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
958         (serverCallback):
959         (ProxyTest::ProxyTest):
960         (ProxyTest::~ProxyTest):
961         (ProxyTest::loadURIAndGetMainResourceData):
962         (ProxyTest::proxyServerPortAsString):
963         (testWebContextProxySettings):
964         (beforeAll):
965
966 2017-01-19  Timothy Hatcher  <timothy@hatcher.name>
967
968         Add back my old email address so old commits will still match it.
969
970         * Scripts/webkitpy/common/config/contributors.json:
971
972 2017-01-19  Timothy Hatcher  <timothy@hatcher.name>
973
974         Remove my old email address from contributors.json and watchlist.
975
976         * Scripts/validate-committer-lists:
977         (CommitterListFromGit): Change the mapping to the correct email.
978         * Scripts/webkitpy/common/config/contributors.json:
979         * Scripts/webkitpy/common/config/watchlist:
980
981 2017-01-18  Ryan Haddad  <ryanhaddad@apple.com>
982
983         Unreviewed, rolling out r210848.
984
985         This change introduced media-related LayoutTest failures and
986         crashes on macOS.
987
988         Reverted changeset:
989
990         "[Modern Media Controls] Turn modern media controls on by
991         default"
992         https://bugs.webkit.org/show_bug.cgi?id=165668
993         http://trac.webkit.org/changeset/210848
994
995 2017-01-18  Andreas Kling  <akling@apple.com>
996
997         Document::securityOrigin() should return a reference.
998         <https://webkit.org/b/167124>
999
1000         Reviewed by Sam Weinig.
1001
1002         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
1003         (TestWebKitAPI::TEST_F):
1004
1005 2017-01-18  Per Arne Vollan  <pvollan@apple.com>
1006
1007         [Win] Clipboard tests are flaky.
1008         https://bugs.webkit.org/show_bug.cgi?id=167088
1009
1010         Reviewed by Brent Fulgham.
1011
1012         Tests involving the clipboard are flaky when running with multiple DRTs, since the clipboard is global. 
1013         We can fix this by assigning each DRT a separate window station (each window station has its own clipboard).
1014
1015         * DumpRenderTree/win/DumpRenderTree.cpp:
1016         (main):
1017
1018 2017-01-18  Antoine Quint  <graouts@apple.com>
1019
1020         [Modern Media Controls] Turn modern media controls on by default
1021         https://bugs.webkit.org/show_bug.cgi?id=165668
1022
1023         Reviewed by Dean Jackson.
1024
1025         Enabled modern media controls by default in test runners. 
1026
1027         * DumpRenderTree/TestOptions.h:
1028         * WebKitTestRunner/TestOptions.h:
1029
1030 2017-01-17  Michael Catanzaro  <mcatanzaro@igalia.com>
1031
1032         Unreviewed, rolling out r210834
1033         https://bugs.webkit.org/show_bug.cgi?id=165668
1034
1035         It introduced dozens of test timeouts.
1036
1037         Reverted changeset:
1038         "[Modern Media Controls] Turn modern media controls on by default"
1039         https://bugs.webkit.org/show_bug.cgi?id=165668
1040         http://trac.webkit.org/changeset/210834
1041
1042 2017-01-17  Antoine Quint  <graouts@apple.com>
1043
1044         [Modern Media Controls] Turn modern media controls on by default
1045         https://bugs.webkit.org/show_bug.cgi?id=165668
1046
1047         Reviewed by Dean Jackson.
1048
1049         Enabled modern media controls by default in test runners. 
1050
1051         * DumpRenderTree/TestOptions.h:
1052         * WebKitTestRunner/TestOptions.h:
1053
1054 2017-01-17  Chris Dumez  <cdumez@apple.com>
1055
1056         Document title changed twice when setting document.title
1057         https://bugs.webkit.org/show_bug.cgi?id=167065
1058
1059         Reviewed by Darin Adler.
1060
1061         Add WebKit2GTK API test that was written by Michael Catanzaro.
1062
1063         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1064         (testWebViewTitleChange):
1065         (beforeAll):
1066
1067 2017-01-17  Joseph Pecoraro  <pecoraro@apple.com>
1068
1069         ENABLE(USER_TIMING) Not Defined for Apple Windows or OS X Ports
1070         https://bugs.webkit.org/show_bug.cgi?id=116551
1071         <rdar://problem/13949830>
1072
1073         Reviewed by Alex Christensen.
1074
1075         * Scripts/webkitperl/FeatureList.pm:
1076         Remove stale RESOURCE_TIMING references which are now a runtime enabled feature
1077         that is part of the existing WEB_TIMING feature.
1078
1079         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1080
1081 2017-01-17  Jonathan Bedard  <jbedard@apple.com>
1082
1083         'webkit-patch post' no longer works with moved/copied files
1084         https://bugs.webkit.org/show_bug.cgi?id=166914
1085         <rdar://problem/29979707>
1086
1087         Reviewed by Daniel Bates.
1088
1089         SVN 1.9 has a bug where when a file has been moved or copied, the svn diff of the new
1090         file outputs only the "Index:" line with an empty body.  This workaround
1091         ignores such output from svn diff.  A issue has been filed with SVN, a link to the
1092         public email list tracking this bug is below.
1093         http://mail-archives.apache.org/mod_mbox/subversion-users/201701.mbox/%3cCF9BDE0A-7454-4405-8259-1120C6B76A03@apple.com%3e
1094         
1095
1096         * Scripts/svn-create-patch:
1097         (generateDiff): Ignore an "Index:" line with an empty body.
1098
1099 2017-01-16  Joseph Pecoraro  <pecoraro@apple.com>
1100
1101         Remove the REQUEST_ANIMATION_FRAME flag
1102         https://bugs.webkit.org/show_bug.cgi?id=156980
1103         <rdar://problem/25906849>
1104
1105         Reviewed by Simon Fraser.
1106
1107         * Scripts/webkitperl/FeatureList.pm:
1108         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1109
1110 2017-01-15  Sam Weinig  <sam@webkit.org>
1111
1112         Add the ability to use numbers in makeString()
1113         https://bugs.webkit.org/show_bug.cgi?id=167087
1114
1115         Reviewed by Darin Adler.
1116
1117         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1118         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Added.
1119         Add tests for StringConcatenate, focusing on new numeric additions.
1120
1121 2017-01-15  Michael Catanzaro  <mcatanzaro@igalia.com>
1122
1123         Unreviewed, remove stale comment.
1124
1125         This test was fixed by r163173.
1126
1127         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
1128
1129 2017-01-14  Yusuke Suzuki  <utatane.tea@gmail.com>
1130
1131         Annotate large string tests with largeHeap
1132         https://bugs.webkit.org/show_bug.cgi?id=167054
1133
1134         Reviewed by Filip Pizlo.
1135
1136         * Scripts/run-javascriptcore-tests:
1137         * Scripts/run-jsc-stress-tests:
1138
1139 2017-01-14  Joseph Pecoraro  <pecoraro@apple.com>
1140
1141         Remove stale references to ENABLE_ES6_GENERATORS and ENABLE_PROMISES
1142         https://bugs.webkit.org/show_bug.cgi?id=167043
1143
1144         Reviewed by Darin Adler.
1145
1146         * Scripts/webkitperl/FeatureList.pm:
1147
1148 2017-01-13  Joseph Pecoraro  <pecoraro@apple.com>
1149
1150         Remove ENABLE(DETAILS_ELEMENT) guards
1151         https://bugs.webkit.org/show_bug.cgi?id=167042
1152
1153         Reviewed by Alex Christensen.
1154
1155         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1156
1157 2017-01-13  Said Abou-Hallawa  <sabouhallawa@apple.com>
1158
1159         26 MotionMark performance tests failing
1160         https://bugs.webkit.org/show_bug.cgi?id=166854
1161
1162         Reviewed by Ryosuke Niwa.
1163
1164         Unrelated change. This is the last place that we need to rename Animometer
1165         to MotionMark.
1166
1167         * Scripts/webkitpy/common/config/watchlist:
1168
1169 2017-01-13  Yusuke Suzuki  <utatane.tea@gmail.com>
1170
1171         run-jsc-benchmarks' echo should have -e option
1172         https://bugs.webkit.org/show_bug.cgi?id=167009
1173
1174         Reviewed by Sam Weinig.
1175
1176         echo requires `-e` option to use escape sequence.
1177         Without it, in some environment (in my Fedora 25), the escape sequence is not
1178         recognized and just dumped as `\c` etc.
1179
1180         * Scripts/run-jsc-benchmarks:
1181
1182 2017-01-12  Chris Dumez  <cdumez@apple.com>
1183
1184         Add KEYBOARD_KEY_ATTRIBUTE / KEYBOARD_CODE_ATTRIBUTE to FeatureDefines.xcconfig
1185         https://bugs.webkit.org/show_bug.cgi?id=166995
1186
1187         Reviewed by Jer Noble.
1188
1189         Add KEYBOARD_KEY_ATTRIBUTE / KEYBOARD_CODE_ATTRIBUTE to FeatureDefines.xcconfig
1190         as some people are having trouble building without it.
1191
1192         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1193
1194 2017-01-12  Sam Weinig  <sam@webkit.org>
1195
1196         Add the ability to filter the set of bindings tests you want to run
1197         https://bugs.webkit.org/show_bug.cgi?id=166977
1198
1199         Reviewed by Tim Horton.
1200
1201         Allows doing things like:
1202             run-bindings-tests TestObj* TestCEReactions*
1203         
1204         to run only those tests that match the patterns.
1205
1206         * Scripts/run-bindings-tests:
1207         (main):
1208         Switch to using optparse and pass the remaining args as the filters.
1209
1210         * Scripts/webkitpy/bindings/main.py:
1211         (BindingsTests.__init__):
1212         Store the pattens.
1213
1214         (BindingsTests.test_matches_patterns):
1215         Add helper predicate to determine if a test should be run. When no
1216         patterns are present, all tests should run.
1217
1218         (BindingsTests.run_tests):
1219         Filter tests using the passed in patterns.
1220
1221 2017-01-12  Per Arne Vollan  <pvollan@apple.com>
1222
1223         Followup fix after r210503.
1224         https://bugs.webkit.org/show_bug.cgi?id=166887
1225
1226         Reviewed by Alex Christensen.
1227
1228         After <http://trac.webkit.org/changeset/210503>, test results are written to a
1229         duplicated file handle on Windows. This patch fixes the remaining call sites.
1230
1231         * DumpRenderTree/PixelDumpSupport.cpp:
1232         * DumpRenderTree/TestRunner.cpp:
1233         (TestRunner::waitToDumpWatchdogTimerFired):
1234         * DumpRenderTree/TestRunner.h:
1235         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
1236         * DumpRenderTree/win/DumpRenderTree.cpp:
1237         * DumpRenderTree/win/DumpRenderTreeWin.h:
1238         * DumpRenderTree/win/TestRunnerWin.cpp:
1239         (TestRunner::setSpellCheckerLoggingEnabled):
1240
1241 2017-01-11  Megan Gardner  <megan_gardner@apple.com>
1242
1243         Add committer status for Megan
1244         https://bugs.webkit.org/show_bug.cgi?id=166954
1245
1246         Reviewed by Tim Horton.
1247
1248         Add committer status for Megan Gardner
1249
1250         * Scripts/webkitpy/common/config/contributors.json:
1251
1252 2017-01-11  Brent Fulgham  <bfulgham@apple.com>
1253
1254         Unreviewed test fix after r210599.
1255
1256         * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp:
1257         (TestWebKitAPI::TEST): Remove debugging code that was causing a timeout.
1258
1259 2017-01-11  Brent Fulgham  <bfulgham@apple.com>
1260
1261         Unreviewed build fix after r210599.
1262
1263         Add missing files.
1264
1265         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
1266         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
1267
1268 2017-01-11  Brent Fulgham  <bfulgham@apple.com>
1269
1270         File scheme should not allow access of a resource on a different volume.
1271         https://bugs.webkit.org/show_bug.cgi?id=158552
1272         <rdar://problem/15307582>
1273
1274         Reviewed by Alex Christensen.
1275
1276         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
1277         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
1278         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
1279
1280 2017-01-11  Ryan Haddad  <ryanhaddad@apple.com>
1281
1282         Unreviewed, rolling out r210571.
1283
1284         This change broke the 32-bit macOS build and caused LayoutTest
1285         failures.
1286
1287         Reverted changeset:
1288
1289         "File scheme should not allow access of a resource on a
1290         different volume."
1291         https://bugs.webkit.org/show_bug.cgi?id=158552
1292         http://trac.webkit.org/changeset/210571
1293
1294 2017-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1295
1296         [GTK] install-dependencies script misses gdb
1297         https://bugs.webkit.org/show_bug.cgi?id=166917
1298
1299         Reviewed by Michael Catanzaro.
1300
1301         gdb is needed for generating the crash logs.
1302
1303         * gtk/install-dependencies:
1304
1305 2017-01-10  Michael Catanzaro  <mcatanzaro@igalia.com>
1306
1307         [GTK] No way for applications to set notification permissions without waiting for permission request
1308         https://bugs.webkit.org/show_bug.cgi?id=163366
1309
1310         Reviewed by Carlos Garcia Campos.
1311
1312         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1313         (testWebViewNotification):
1314         (setInitialNotificationPermissionsAllowedCallback):
1315         (setInitialNotificationPermissionsDisallowedCallback):
1316         (testWebViewNotificationInitialPermissionAllowed):
1317         (testWebViewNotificationInitialPermissionDisallowed):
1318         (beforeAll):
1319         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
1320         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
1321         (WebViewTest::WebViewTest):
1322         (WebViewTest::initializeWebView):
1323         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
1324
1325 2017-01-10  Tim Horton  <timothy_horton@apple.com>
1326
1327         MobileMiniBrowser tests don't work by default
1328         https://bugs.webkit.org/show_bug.cgi?id=166910
1329
1330         Reviewed by Alex Christensen.
1331
1332         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/xcshareddata/xcschemes/MobileMiniBrowserUITests.xcscheme: Added.
1333         Add a shared scheme; the Makefile depends on the MobileMiniBrowserUITests scheme existing, at the very least.
1334
1335 2017-01-10  Brent Fulgham  <bfulgham@apple.com>
1336
1337         File scheme should not allow access of a resource on a different volume.
1338         https://bugs.webkit.org/show_bug.cgi?id=158552
1339         <rdar://problem/15307582>
1340
1341         Reviewed by Alex Christensen.
1342
1343         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
1344         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
1345         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
1346
1347 2017-01-10  Mark Lam  <mark.lam@apple.com>
1348
1349         Reverting run-jsc-stress-tests' $buildType to use string values.
1350         https://bugs.webkit.org/show_bug.cgi?id=166912
1351
1352         Rubber stamped by Filip Pizlo.
1353
1354         This is so that we can test for it in the tests e.g.
1355         //@ if $buildType == "debug" then runDefault("--maxSingleAllocationSize=1048576") else skip end
1356
1357         * Scripts/run-jsc-stress-tests:
1358
1359 2017-01-10  Ryosuke Niwa  <rniwa@webkit.org>
1360
1361         Temporarily add back the file removed in r210463 to unbreak internal bots.
1362
1363         * Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch: Copied from Tools/Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch.
1364
1365 2017-01-10  Jonathan Bedard  <jbedard@apple.com>
1366
1367         svn-apply failed to apply a patch (deleting file with svn property)
1368         https://bugs.webkit.org/show_bug.cgi?id=165953
1369
1370         Reviewed by Daniel Bates.
1371
1372         * Scripts/VCSUtils.pm:
1373         (parseSvnPropertyValue): The beginning of a diff will cause an early exit in the case of no empty newlines.
1374         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl: Add tests without break between diffs for properties.
1375
1376 2017-01-10  Ryan Haddad  <ryanhaddad@apple.com>
1377
1378         Update flakiness dashboard configuration.
1379         https://bugs.webkit.org/show_bug.cgi?id=166869
1380
1381         Reviewed by Alexey Proskuryakov.
1382
1383         * TestResultServer/static-dashboards/builders.jsonp:
1384         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1385
1386 2017-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1387
1388         [GTK] Stop honoring the environment variable USE_NATIVE_XDISPLAY
1389         https://bugs.webkit.org/show_bug.cgi?id=165232
1390
1391         Unreviewed follow-up patch after r210539 and r210523.
1392
1393         Instead of using that environment variable, the argument
1394         --display-server=xorg should be passed now.
1395
1396         The GTK+ performance bot was the only bot using this, and is
1397         already passing --display-server=xorg after r210539.
1398
1399         * Scripts/webkitpy/port/gtk.py:
1400         (GtkPort._driver_class):
1401
1402 2017-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1403
1404         [GTK] Add a new release test bot for Wayland and pass --display-server=xorg to the GTK Perf bot.
1405         https://bugs.webkit.org/show_bug.cgi?id=166872
1406
1407         Reviewed by Michael Catanzaro.
1408
1409         Add the new wayland release test bot as a test-only bot. It will download the built product from the release build-only bot.
1410         Define the required "--display-server=driver" in the bot additionalArguments config entry.
1411         Implement support for honoring additionalArguments on the RunGtkAPITests and RunAndUploadPerfTests steps.
1412         The step RunWebKitTests already has support for it.
1413
1414         * BuildSlaveSupport/build.webkit.org-config/config.json:
1415         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1416         (RunGtkAPITests.start):
1417         (RunAndUploadPerfTests.start):
1418         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1419
1420 2017-01-09  Ryan Haddad  <ryanhaddad@apple.com>
1421
1422         Unreviewed, rolling out r210531.
1423
1424         This change broke the 32-bit macOS build and caused LayoutTest
1425         failures.
1426
1427         Reverted changeset:
1428
1429         "File scheme should not allow access of a resource on a
1430         different volume."
1431         https://bugs.webkit.org/show_bug.cgi?id=158552
1432         http://trac.webkit.org/changeset/210531
1433
1434 2017-01-09  Brent Fulgham  <bfulgham@apple.com>
1435
1436         File scheme should not allow access of a resource on a different volume.
1437         https://bugs.webkit.org/show_bug.cgi?id=158552
1438         <rdar://problem/15307582>
1439
1440         Reviewed by Alex Christensen.
1441
1442         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
1443         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
1444         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
1445
1446 2017-01-09  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1447
1448         [GTK][Wayland] Allow running the layout tests under a native Wayland environment.
1449         https://bugs.webkit.org/show_bug.cgi?id=165232
1450
1451         Reviewed by Michael Catanzaro.
1452
1453         Add a new WaylandDriver to run the tests in the user current wayland session.
1454
1455         Also merge all the configuration options for selecting the display server inside one
1456         switch --display-server=xvfb/xorg/wayland/weston (defaulting to xvfb).
1457
1458         This switch is supported on the scripts: run-gtk-tests, run-perf-tests and run-webkit-tests.
1459
1460         * Scripts/run-gtk-tests: Add missing logging.basicConfig() initialization for the error logger.
1461         (TestRunner._create_driver):
1462         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1463         (parse_args):
1464         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1465         (PerfTestsRunner._parse_args):
1466         * Scripts/webkitpy/port/gtk.py:
1467         (GtkPort.__init__):
1468         (GtkPort._driver_class):
1469         (GtkPort._search_paths):
1470         * Scripts/webkitpy/port/waylanddriver.py: Added.
1471         (WaylandDriver):
1472         (WaylandDriver.check_driver):
1473         (WaylandDriver._setup_environ_for_test):
1474         (WaylandDriver._start):
1475
1476 2017-01-09  Andy Estes  <aestes@apple.com>
1477
1478         [QuickLook] Add a layout test for webkit.org/b/135651
1479         https://bugs.webkit.org/show_bug.cgi?id=166855
1480
1481         Reviewed by Andreas Kling.
1482
1483         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1484         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]): Added output for
1485         errors with code WebKitErrorCannotShowURL.
1486         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1487         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame): Made the error output
1488         not specific to WebKit2 error codes.
1489
1490 2017-01-09  Antoine Quint  <graouts@apple.com>
1491
1492         Support webkit-test-runner key-value pairs in http tests in DumpRenderTree
1493         https://bugs.webkit.org/show_bug.cgi?id=166837
1494
1495         Reviewed by Alex Christensen.
1496
1497         We now correctly handle the --absolutePath argument in DumpRenderTree and use
1498         the provided value when trying to determine the path to the test file. Failing
1499         that, we use the computed URL or the raw path provided to cover all cases.
1500         
1501         This was tested in the context of https://bugs.webkit.org/show_bug.cgi?id=165668
1502         by applying this patch and seeing the number test failures dramatically reduced
1503         with WK1 due to the option to turn modern media controls off for older media controls
1504         tests.
1505
1506         * DumpRenderTree/DumpRenderTree.h:
1507         * DumpRenderTree/DumpRenderTreeCommon.cpp:
1508         (parseInputLine):
1509         * DumpRenderTree/TestOptions.h:
1510         * DumpRenderTree/TestOptions.mm:
1511         (TestOptions::TestOptions):
1512         * DumpRenderTree/mac/DumpRenderTree.mm:
1513         (runTest):
1514
1515 2017-01-09  Milan Crha  <mcrha@redhat.com>
1516
1517         prepare-ChangeLog: Correct help string for --style option
1518         https://bugs.webkit.org/show_bug.cgi?id=166725
1519
1520         Reviewed by Alexey Proskuryakov.
1521
1522         * Scripts/prepare-ChangeLog:
1523         (main):
1524
1525 2017-01-09  Lucas Forschler  <lforschler@apple.com>
1526
1527         https://bugs.webkit.org/show_bug.cgi?id=166839
1528         Add php7 support for macOS.
1529         Mirror the debian logic to look for a php7 module on disk, and return the appropriate apache config file.
1530
1531         Reviewed by Alexey Proskuryakov.
1532
1533         * Scripts/webkitpy/port/base.py:
1534         (Port._is_darwin_php_version_7):
1535         (Port._debian_php_version):
1536         (Port):
1537         (Port._darwin_php_version):
1538         (Port._apache_config_file_name_for_platform):
1539
1540 2017-01-06  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1541
1542         [GTK] Should support key and code properties on keyboard events
1543         https://bugs.webkit.org/show_bug.cgi?id=166759
1544
1545         Reviewed by Carlos Garcia Campos.
1546
1547         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
1548         (WTR::getGDKKeySymForKeyRef): add missing modifier keys which were being reported as 'l' and 'r' only
1549         on tests.
1550
1551 2017-01-06  Per Arne Vollan  <pvollan@apple.com>
1552
1553         [Win] Some tests are flaky because certain DLLs are writing to stdout.
1554         https://bugs.webkit.org/show_bug.cgi?id=166760
1555
1556         Reviewed by Darin Adler.
1557
1558         Some tests are flaky because certain DLLs are writing to stdout, giving incorrect test results.
1559         We can work around that by duplicating and redirecting stdout.
1560
1561         * DumpRenderTree/PixelDumpSupport.cpp:
1562         (dumpWebViewAsPixelsAndCompareWithExpected):
1563         (printPNG):
1564         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
1565         (logEventProc):
1566         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
1567         (DRTDesktopNotificationPresenter::showDesktopNotification):
1568         (DRTDesktopNotificationPresenter::cancelDesktopNotification):
1569         (DRTDesktopNotificationPresenter::requestNotificationPermission):
1570         * DumpRenderTree/win/DumpRenderTree.cpp:
1571         (dumpFrameScrollPosition):
1572         (dumpHistoryItem):
1573         (dumpBackForwardList):
1574         (dump):
1575         (runTest):
1576         (main):
1577         * DumpRenderTree/win/DumpRenderTreeWin.h:
1578         * DumpRenderTree/win/EditingDelegate.cpp:
1579         (EditingDelegate::shouldBeginEditingInDOMRange):
1580         (EditingDelegate::shouldEndEditingInDOMRange):
1581         (EditingDelegate::shouldInsertNode):
1582         (EditingDelegate::shouldInsertText):
1583         (EditingDelegate::shouldDeleteDOMRange):
1584         (EditingDelegate::shouldChangeSelectedDOMRange):
1585         (EditingDelegate::shouldApplyStyle):
1586         (EditingDelegate::shouldChangeTypingStyle):
1587         (EditingDelegate::doPlatformCommand):
1588         (EditingDelegate::webViewDidBeginEditing):
1589         (EditingDelegate::webViewDidChange):
1590         (EditingDelegate::webViewDidEndEditing):
1591         (EditingDelegate::webViewDidChangeTypingStyle):
1592         (EditingDelegate::webViewDidChangeSelection):
1593         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1594         (FrameLoadDelegate::didStartProvisionalLoadForFrame):
1595         (FrameLoadDelegate::didReceiveServerRedirectForProvisionalLoadForFrame):
1596         (FrameLoadDelegate::didChangeLocationWithinPageForFrame):
1597         (FrameLoadDelegate::didFailProvisionalLoadWithError):
1598         (FrameLoadDelegate::didCommitLoadForFrame):
1599         (FrameLoadDelegate::didReceiveTitle):
1600         (FrameLoadDelegate::didFinishLoadForFrame):
1601         (FrameLoadDelegate::didFailLoadWithError):
1602         (FrameLoadDelegate::willPerformClientRedirectToURL):
1603         (FrameLoadDelegate::didCancelClientRedirectForFrame):
1604         (FrameLoadDelegate::windowScriptObjectAvailable):
1605         (FrameLoadDelegate::didFinishDocumentLoadForFrame):
1606         (FrameLoadDelegate::didHandleOnloadEventsForFrame):
1607         (FrameLoadDelegate::didDisplayInsecureContent):
1608         (FrameLoadDelegate::didRunInsecureContent):
1609         (FrameLoadDelegate::webViewProgressFinishedNotification):
1610         * DumpRenderTree/win/HistoryDelegate.cpp:
1611         (HistoryDelegate::didNavigateWithNavigationData):
1612         (HistoryDelegate::didPerformClientRedirectFromURL):
1613         (HistoryDelegate::didPerformServerRedirectFromURL):
1614         (HistoryDelegate::updateHistoryTitle):
1615         (HistoryDelegate::populateVisitedLinksForWebView):
1616         * DumpRenderTree/win/PolicyDelegate.cpp:
1617         (PolicyDelegate::decidePolicyForNavigationAction):
1618         (PolicyDelegate::unableToImplementPolicyWithError):
1619         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
1620         (ResourceLoadDelegate::willSendRequest):
1621         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
1622         (ResourceLoadDelegate::didReceiveResponse):
1623         (ResourceLoadDelegate::didFinishLoadingFromDataSource):
1624         (ResourceLoadDelegate::didFailLoadingWithError):
1625         * DumpRenderTree/win/TestRunnerWin.cpp:
1626         (TestRunner::addDisallowedURL):
1627         (TestRunner::originsWithApplicationCache):
1628         (TestRunner::setStorageDatabaseIdleInterval):
1629         (TestRunner::closeIdleLocalStorageDatabases):
1630         (TestRunner::copyDecodedHostName):
1631         (TestRunner::copyEncodedHostName):
1632         (TestRunner::numberOfPendingGeolocationPermissionRequests):
1633         (TestRunner::isGeolocationProviderActive):
1634         (TestRunner::pathToLocalResource):
1635         (TestRunner::setMockDeviceOrientation):
1636         (TestRunner::setMockGeolocationPosition):
1637         (TestRunner::setMockGeolocationPositionUnavailableError):
1638         (TestRunner::setSpatialNavigationEnabled):
1639         (TestRunner::setAutomaticLinkDetectionEnabled):
1640         (TestRunner::isCommandEnabled):
1641         (TestRunner::authenticateSession):
1642         (TestRunner::addChromeInputField):
1643         (TestRunner::removeChromeInputField):
1644         (TestRunner::focusWebView):
1645         (TestRunner::grantWebNotificationPermission):
1646         (TestRunner::denyWebNotificationPermission):
1647         (TestRunner::removeAllWebNotificationPermissions):
1648         (TestRunner::simulateWebNotificationClick):
1649         (TestRunner::imageCountInGeneralPasteboard):
1650         * DumpRenderTree/win/UIDelegate.cpp:
1651         (UIDelegate::runJavaScriptAlertPanelWithMessage):
1652         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
1653         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
1654         (UIDelegate::runBeforeUnloadConfirmPanelWithMessage):
1655         (UIDelegate::webViewAddMessageToConsole):
1656         (UIDelegate::exceededDatabaseQuota):
1657         (UIDelegate::setStatusText):
1658         (UIDelegate::didPressMissingPluginButton):
1659
1660 2017-01-07  Tim Horton  <timothy_horton@apple.com>
1661
1662         Add a setting to create editable MiniBrowser windows by default
1663         https://bugs.webkit.org/show_bug.cgi?id=166806
1664
1665         Reviewed by Beth Dakin.
1666
1667         * MiniBrowser/mac/AppDelegate.m:
1668         (-[BrowserAppDelegate createBrowserWindowController:]):
1669         (-[BrowserAppDelegate applicationDidFinishLaunching:]):
1670         (-[BrowserAppDelegate _updateNewWindowKeyEquivalents]):
1671         * MiniBrowser/mac/SettingsController.h:
1672         * MiniBrowser/mac/SettingsController.m:
1673         (-[SettingsController _populateMenu]):
1674         (-[SettingsController validateMenuItem:]):
1675         (-[SettingsController toggleCreateEditorByDefault:]):
1676         (-[SettingsController createEditorByDefault]):
1677         Add a setting and update the key equivalents accordingly.
1678         Also make sure to make the right kind of window on launch.
1679
1680 2017-01-07  Tim Horton  <timothy_horton@apple.com>
1681
1682         Fix the 32-bit build.
1683
1684         * MiniBrowser/mac/BrowserWindowController.h:
1685         * MiniBrowser/mac/BrowserWindowController.m:
1686
1687 2017-01-07  Tim Horton  <timothy_horton@apple.com>
1688
1689         Fix the 32-bit build.
1690
1691         * MiniBrowser/mac/BrowserWindowController.m:
1692
1693 2017-01-07  Tim Horton  <timothy_horton@apple.com>
1694
1695         Make it possible to drop HTML files on the MiniBrowser icon
1696         https://bugs.webkit.org/show_bug.cgi?id=166802
1697
1698         Reviewed by Simon Fraser.
1699
1700         * MiniBrowser/mac/AppDelegate.m:
1701         (-[BrowserAppDelegate application:openFile:]):
1702         * MiniBrowser/mac/Info.plist:
1703         If you're using an editable window, the usual trick of dropping on the
1704         window doesn't work anymore (it makes an <attachment> instead).
1705
1706 2017-01-07  Tim Horton  <timothy_horton@apple.com>
1707
1708         MiniBrowser window gets smaller each time it is instantiated
1709         https://bugs.webkit.org/show_bug.cgi?id=166807
1710
1711         Reviewed by Andy Estes.
1712
1713         * MiniBrowser/mac/BrowserWindowController.m:
1714         (-[BrowserWindowController windowDidLoad]):
1715         * MiniBrowser/mac/BrowserWindow.xib:
1716         Turn on full-window content view support with IB, instead of waiting
1717         until after the views have been loaded. This seems to resolve the
1718         longstanding ever-shrinking-window problem.
1719
1720 2017-01-07  Tim Horton  <timothy_horton@apple.com>
1721
1722         Add indent/outdent items to MiniBrowser's new format menu
1723         https://bugs.webkit.org/show_bug.cgi?id=166805
1724
1725         Reviewed by Dan Bernstein.
1726
1727         * MiniBrowser/mac/MainMenu.xib:
1728
1729 2017-01-07  Tim Horton  <timothy_horton@apple.com>
1730
1731         Add a stock Format menu to MiniBrowser
1732         https://bugs.webkit.org/show_bug.cgi?id=166804
1733
1734         Reviewed by Andy Estes.
1735
1736         * MiniBrowser/mac/MainMenu.xib:
1737         Many of the features automatically work with editable web views.
1738         However, this seems to expose a bug where none of the font-related features
1739         (Cmd-B, for example) work until the first time the font panel is shown,
1740         per process, which will need to be investigated separately.
1741
1742 2017-01-07  Tim Horton  <timothy_horton@apple.com>
1743
1744         Remove unused applicationWillTerminate methods from MiniBrowser
1745         https://bugs.webkit.org/show_bug.cgi?id=166803
1746
1747         Reviewed by Andy Estes.
1748
1749         * MiniBrowser/mac/AppDelegate.m:
1750         (-[BrowserAppDelegate applicationWillTerminate:]): Deleted.
1751         * MiniBrowser/mac/BrowserWindowController.h:
1752         * MiniBrowser/mac/BrowserWindowController.m:
1753         (-[BrowserWindowController applicationTerminating]): Deleted.
1754         * MiniBrowser/mac/WK1BrowserWindowController.m:
1755         (-[WK1BrowserWindowController applicationTerminating]): Deleted.
1756         * MiniBrowser/mac/WK2BrowserWindowController.m:
1757         (-[WK2BrowserWindowController applicationTerminating]): Deleted.
1758
1759 2017-01-07  Tim Horton  <timothy_horton@apple.com>
1760
1761         Add the ability to create empty contentEditable windows in MiniBrowser
1762         https://bugs.webkit.org/show_bug.cgi?id=166801
1763
1764         Reviewed by Wenson Hsieh.
1765
1766         * MiniBrowser/mac/AppDelegate.h:
1767         * MiniBrowser/mac/AppDelegate.m:
1768         (-[BrowserAppDelegate createBrowserWindowController:]):
1769         (-[BrowserAppDelegate newWindow:]):
1770         (-[BrowserAppDelegate newEditorWindow:]):
1771         (-[BrowserAppDelegate openDocument:]):
1772         (-[BrowserAppDelegate _updateNewWindowKeyEquivalents]):
1773         * MiniBrowser/mac/BrowserWindowController.h:
1774         * MiniBrowser/mac/BrowserWindowController.m:
1775         (-[BrowserWindowController loadHTMLString:]):
1776         (-[BrowserWindowController toggleEditable:]):
1777         * MiniBrowser/mac/MainMenu.xib:
1778         * MiniBrowser/mac/WK1BrowserWindowController.m:
1779         (-[WK1BrowserWindowController awakeFromNib]):
1780         (-[WK1BrowserWindowController loadHTMLString:]):
1781         (-[WK1BrowserWindowController validateMenuItem:]):
1782         (-[WK1BrowserWindowController setEditable:]):
1783         (-[WK1BrowserWindowController updateTitle:]):
1784         * MiniBrowser/mac/WK2BrowserWindowController.m:
1785         (-[WK2BrowserWindowController awakeFromNib]):
1786         (-[WK2BrowserWindowController validateMenuItem:]):
1787         (-[WK2BrowserWindowController setEditable:]):
1788         (-[WK2BrowserWindowController updateTitle:]):
1789         (-[WK2BrowserWindowController loadHTMLString:]):
1790         Merge more functionality from WebEditingTester.
1791         Add two menu items for creating empty editable WebKit1/2 windows.
1792         Add a menu item to the Edit menu to toggle editability on any window.
1793
1794 2017-01-07  Tim Horton  <timothy_horton@apple.com>
1795
1796         Implement find-in-page in MiniBrowser
1797         https://bugs.webkit.org/show_bug.cgi?id=166799
1798
1799         Reviewed by Andy Estes.
1800
1801         * MiniBrowser/mac/BrowserWindow.xib:
1802         * MiniBrowser/mac/BrowserWindowController.h:
1803         * MiniBrowser/mac/BrowserWindowController.m:
1804         (-[BrowserWindowController find:]): Deleted.
1805         * MiniBrowser/mac/MainMenu.xib:
1806         * MiniBrowser/mac/WK1BrowserWindowController.m:
1807         (-[WK1BrowserWindowController toggleShrinkToFit:]):
1808         (-[WK1BrowserWindowController find:]): Deleted.
1809         * MiniBrowser/mac/WK2BrowserWindowController.m:
1810         (-[WK2BrowserWindowController awakeFromNib]):
1811         (-[WK2BrowserWindowController dealloc]):
1812         (-[WK2BrowserWindowController validateMenuItem:]):
1813         (-[WK2BrowserWindowController performTextFinderAction:]):
1814         (-[WK2BrowserWindowController findBarView]):
1815         (-[WK2BrowserWindowController setFindBarView:]):
1816         (-[WK2BrowserWindowController isFindBarVisible]):
1817         (-[WK2BrowserWindowController setFindBarVisible:]):
1818         (-[WK2BrowserWindowController contentView]):
1819         (-[WK2BrowserWindowController findBarViewDidChangeHeight]):
1820         (-[WK2BrowserWindowController performFindPanelAction:]): Deleted.
1821         (-[WK2BrowserWindowController find:]): Deleted.
1822         Implement find-in-page using WKWebView's conformance to the NSTextFinderClient
1823         protocol. At first glance, it's pretty broken, but vaguely works.
1824
1825 2017-01-07  Tim Horton  <timothy_horton@apple.com>
1826
1827         Share the implementation of MiniBrowser view hiding functionality
1828         https://bugs.webkit.org/show_bug.cgi?id=166800
1829
1830         Reviewed by Andy Estes.
1831
1832         * MiniBrowser/mac/BrowserWindowController.m:
1833         (-[BrowserWindowController showHideWebView:]):
1834         (-[BrowserWindowController removeReinsertWebView:]):
1835         * MiniBrowser/mac/WK1BrowserWindowController.m:
1836         (-[WK1BrowserWindowController showHideWebView:]): Deleted.
1837         (-[WK1BrowserWindowController removeReinsertWebView:]): Deleted.
1838         * MiniBrowser/mac/WK2BrowserWindowController.m:
1839         (-[WK2BrowserWindowController showHideWebView:]): Deleted.
1840         (-[WK2BrowserWindowController removeReinsertWebView:]): Deleted.
1841         Move the implementation of these two things to the shared superclass,
1842         since they don't depend on WebKit-specific things.
1843         Also, there was no reason to retain the (WK)WebView while it was unparented,
1844         as the BrowserWindowController maintains a reference the entire time.
1845
1846 2017-01-06  Andy Estes  <aestes@apple.com>
1847
1848         [Cocoa] Consolidate duplicate copies of WebArchiveDumpSupport in DRT and WKTR into WebCoreTestSupport
1849         https://bugs.webkit.org/show_bug.cgi?id=166789
1850
1851         Reviewed by Alex Christensen.
1852
1853         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1854         * DumpRenderTree/PlatformMac.cmake:
1855         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp: Removed.
1856         * DumpRenderTree/cf/WebArchiveDumpSupport.h: Removed.
1857         * DumpRenderTree/mac/DumpRenderTree.mm:
1858         Called WebCoreTestSupport::createXMLStringFromWebArchiveData() instead of
1859         createXMLStringFromWebArchiveData().
1860         * DumpRenderTree/mac/WebArchiveDumpSupportMac.mm: Removed.
1861         * WebKitTestRunner/Configurations/Base.xcconfig:
1862         Added $(BUILT_PRODUCTS_DIR)/WebCoreTestSupport to HEADER_SEARCH_PATHS.
1863         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1864         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
1865         Called WebCoreTestSupport::createXMLStringFromWebArchiveData() instead of
1866         createXMLStringFromWebArchiveData().
1867         * WebKitTestRunner/InjectedBundle/cocoa/WebArchiveDumpSupportCocoa.mm: Removed.
1868         * WebKitTestRunner/PlatformMac.cmake:
1869         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1870         * WebKitTestRunner/cf/WebArchiveDumpSupport.h: Removed.
1871
1872 2017-01-06  Tim Horton  <timothy_horton@apple.com>
1873
1874         Minor cleanups to IndentOutdentCommand and related code
1875         https://bugs.webkit.org/show_bug.cgi?id=166791
1876
1877         Reviewed by Simon Fraser.
1878
1879         * WebEditingTester/EditingOperations.m:
1880         (editingOperations):
1881         Add the outdent operation to WebEditingTester.
1882
1883 2017-01-06  Said Abou-Hallawa  <sabouhallawa@apple.com>
1884
1885         Create a plan and a patch files for MotionMark and delete the Animometer's ones
1886         https://bugs.webkit.org/show_bug.cgi?id=166785
1887
1888         Reviewed by Ryosuke Niwa.
1889
1890         * Scripts/webkitpy/benchmark_runner/data/patches/MotionMark.patch: Renamed from Tools/Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch.
1891         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark.plan: Renamed from Tools/Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan.
1892
1893 2017-01-06  Antoine Quint  <graouts@apple.com>
1894
1895         Support webkit-test-runner key-value pairs in http tests
1896         https://bugs.webkit.org/show_bug.cgi?id=149812
1897
1898         Reviewed by Alex Christensen.
1899
1900         We pass the absolute path for a test through to WKTR so that we can parse
1901         tests that are running as URLs for webkit-test-runner options.
1902
1903         * DumpRenderTree/DumpRenderTreeCommon.cpp:
1904         (parseInputLine):
1905
1906         Explicitly skip the --absolute-path option in DRT or else we'd crash.
1907
1908         * Scripts/webkitpy/port/driver.py:
1909         (Driver._command_from_driver_input):
1910
1911         Pass the absolute path to the file through the CLI.
1912
1913         * WebKitTestRunner/TestController.cpp:
1914         (WTR::updateTestOptionsFromTestHeader):
1915         (WTR::TestController::testOptionsForTest):
1916         (WTR::parseInputLine):
1917         (WTR::TestController::runTest):
1918         * WebKitTestRunner/TestController.h:
1919
1920 2017-01-06  Tim Horton  <timothy_horton@apple.com>
1921
1922         Warning about unconnectable outlets when opening a MiniBrowser window
1923         https://bugs.webkit.org/show_bug.cgi?id=166756
1924
1925         Reviewed by Dan Bernstein.
1926
1927         * MiniBrowser/mac/BrowserWindow.xib:
1928         When launching MiniBrowser, it says:
1929         Failed to connect (Share) outlet from (WK1BrowserWindowController) to
1930             (MBToolbarItem): missing setter or instance variable
1931         Failed to connect (shareButton) outlet from (WK1BrowserWindowController) to
1932             (NSButtonCell): missing setter or instance variable.
1933
1934         It looks like someone added the connection from the share button
1935         to the BrowserWindowController three times; only one of the connections
1936         is valid. Remove the other two.
1937
1938 2017-01-05  Keith Rollin  <krollin@apple.com>
1939
1940         Add WebCore::URL::protocolHostAndPort
1941         https://bugs.webkit.org/show_bug.cgi?id=166426
1942
1943         Reviewed by Alex Christensen.
1944
1945         Add test for protocolHostAndPort.
1946
1947         * TestWebKitAPI/Tests/WebCore/URL.cpp:
1948         (TestWebKitAPI::TEST_F):
1949
1950 2017-01-05  Per Arne Vollan  <pvollan@apple.com>
1951
1952         [Win] Archive test result is failing.
1953         https://bugs.webkit.org/show_bug.cgi?id=166720
1954
1955         Reviewed by Alex Christensen.
1956
1957         Deleting the layout test result folder is sometimes failing
1958         on Windows. This is not a critical error.
1959
1960         * BuildSlaveSupport/test-result-archive:
1961         (archiveTestResults):
1962
1963 2017-01-04  Tomas Popela  <tpopela@redhat.com>
1964
1965         [GTK] Minibrowser: Add printing support
1966         https://bugs.webkit.org/show_bug.cgi?id=165298
1967
1968         Open a print dialog when the Ctrl + P shortcut is pressed. If there is
1969         an error during the print, it's printed on the console.
1970
1971         Reviewed by Michael Catanzaro.
1972
1973         * MiniBrowser/gtk/BrowserWindow.c:
1974         (webKitPrintOperationFailedCallback):
1975         (printPage):
1976         (browser_window_init):
1977
1978 2017-01-04  Manuel Rego Casasnovas  <rego@igalia.com>
1979
1980         [css-grid] Fix crash clamping grid lines
1981         https://bugs.webkit.org/show_bug.cgi?id=166637
1982
1983         Reviewed by Darin Adler.
1984
1985         Creates new unit test to verify that the maximum tracks limit
1986         is used in GridPosition too.
1987
1988         * TestWebKitAPI/PlatformEfl.cmake:
1989         * TestWebKitAPI/PlatformGTK.cmake:
1990         * TestWebKitAPI/PlatformWin.cmake:
1991         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1992         * TestWebKitAPI/Tests/WebCore/GridPosition.cpp: Added.
1993         (TestWebKitAPI::TEST):
1994
1995 2017-01-04  Wenson Hsieh  <wenson_hsieh@apple.com>
1996
1997         Move editing history scripts to WebCore PrivateHeaders
1998         https://bugs.webkit.org/show_bug.cgi?id=166709
1999         <rdar://problem/29876612>
2000
2001         Reviewed by Dan Bernstein.
2002
2003         Update references to editing script files in WebCore that were moved.
2004
2005         * EditingHistory/EditingHistory.xcodeproj/project.pbxproj:
2006
2007 2017-01-04  Yusuke Suzuki  <utatane.tea@gmail.com>
2008
2009         Unreviewed, build fix after r210313 part 2
2010         https://bugs.webkit.org/show_bug.cgi?id=166676
2011
2012         Add 'U' suffix.
2013
2014         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2015         (TestWebKitAPI::TEST):
2016         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
2017         (TestWebKitAPI::TEST):
2018
2019 2017-01-04  Yusuke Suzuki  <utatane.tea@gmail.com>
2020
2021         Limit thread name appropriately
2022         https://bugs.webkit.org/show_bug.cgi?id=166676
2023
2024         Reviewed by Sam Weinig.
2025
2026         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2027         (TestWebKitAPI::TEST):
2028         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
2029         (TestWebKitAPI::TEST):
2030
2031 2017-01-04  Andy Estes  <aestes@apple.com>
2032
2033         [Cocoa] Teach SharedBuffer to return an NSArray of data segments to avoid flattening
2034         https://bugs.webkit.org/show_bug.cgi?id=166696
2035
2036         Reviewed by Tim Horton.
2037
2038         * TestWebKitAPI/PlatformGTK.cmake:
2039         * TestWebKitAPI/PlatformWin.cmake:
2040         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2041         * TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp: Moved class SharedBufferTest to SharedBufferTest.{cpp,h}.
2042         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.cpp: Moved class SharedBufferTest from SharedBuffer.cpp.
2043         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.h: Ditto.
2044         * TestWebKitAPI/Tests/WebCore/cocoa/SharedBuffer.mm: Added.
2045         (TestWebKitAPI::expectDataArraysEqual): Added a helper to assert that two NSArrays of NSData are equal.
2046         (TestWebKitAPI::TEST_F): Added a test for createNSDataArray.
2047
2048 2017-01-03  Brian Burg  <bburg@apple.com>
2049
2050         Web Inspector: teach the protocol generator about platform-specific types, events, and commands
2051         https://bugs.webkit.org/show_bug.cgi?id=166003
2052         <rdar://problem/28718990>
2053
2054         Reviewed by Joseph Pecoraro.
2055
2056         Teach run-inspector-generator-tests to generate test output using the platform name
2057         derived from the directory that the test is in. For example, tests in the /generic/
2058         subdirectory will pass `--platform generic` to generate-inspector-protocol-bindings.py.
2059
2060         * Scripts/webkitpy/inspector/main.py:
2061         (InspectorGeneratorTests.generate_from_json):
2062         (InspectorGeneratorTests.run_tests):
2063         (InspectorGeneratorTests.main):
2064
2065 2017-01-04  Csaba Osztrogonác  <ossy@webkit.org>
2066
2067         Unreviewed cmake buildfix after r210266.
2068
2069         * DumpRenderTree/PlatformMac.cmake:
2070
2071 2017-01-04  Tim Horton  <timothy_horton@apple.com>
2072
2073         Provide a setting for clients to always prefer low-power WebGL
2074         https://bugs.webkit.org/show_bug.cgi?id=166675
2075         <rdar://problem/29834093>
2076
2077         Reviewed by Dan Bernstein.
2078
2079         * MiniBrowser/mac/Info.plist:
2080         Have MiniBrowser claim to be a modern app that supports
2081         automatic graphics switching. WebKit needs to support automatic
2082         graphics switching, so our test app might as well. Without this
2083         Info.plist parameter, this change has no effect, and bringing up
2084         a WebGL context still brings up the discrete GPU (also true of the
2085         existing web-exposed preferLowPowerToHighPerformance API).
2086
2087 2017-01-03  Yusuke Suzuki  <utatane.tea@gmail.com>
2088
2089         WorkQueueGeneric's platformInvalidate() can deadlock when called on the RunLoop's thread
2090         https://bugs.webkit.org/show_bug.cgi?id=166645
2091
2092         Reviewed by Carlos Garcia Campos.
2093
2094         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
2095         (TestWebKitAPI::TEST):
2096
2097 2017-01-03  Andy Estes  <aestes@apple.com>
2098
2099         Place all the Cocoa WebCore API tests in the same directory
2100         https://bugs.webkit.org/show_bug.cgi?id=166673
2101
2102         Reviewed by Michael Catanzaro.
2103
2104         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2105         * TestWebKitAPI/Tests/WebCore/cocoa/SerializedCryptoKeyWrap.mm: Renamed from Tools/TestWebKitAPI/Tests/WebCore/SerializedCryptoKeyWrap.mm.
2106         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm: Renamed from Tools/TestWebKitAPI/Tests/Cocoa/URLExtras.mm.
2107         * TestWebKitAPI/Tests/WebCore/cocoa/WebCoreNSURLSession.mm: Renamed from Tools/TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm.
2108
2109 2017-01-03  Tim Horton  <timothy_horton@apple.com>
2110
2111         NSSpellChecker's recordResponse isn't called for unseen automatic corrections
2112         https://bugs.webkit.org/show_bug.cgi?id=166450
2113         <rdar://problem/29447824>
2114
2115         Reviewed by Darin Adler.
2116
2117         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2118         * DumpRenderTree/TestRunner.cpp:
2119         (TestRunner::staticFunctions):
2120         * DumpRenderTree/mac/TestRunnerMac.mm:
2121         (setSpellCheckerLoggingEnabledCallback):
2122         * DumpRenderTree/win/TestRunnerWin.cpp:
2123         (setSpellCheckerLoggingEnabledCallback):
2124         * DumpRenderTree/mac/DumpRenderTree.mm:
2125         (resetWebViewToConsistentStateBeforeTesting):
2126         * DumpRenderTree/mac/DumpRenderTreeSpellChecker.h: Added.
2127         * DumpRenderTree/mac/DumpRenderTreeSpellChecker.mm: Added.
2128         (stringForCorrectionResponse):
2129         (drt_NSSpellChecker_recordResponseToCorrection):
2130         (swizzleNSSpellCheckerMethodsIfNeeded):
2131         (setSpellCheckerLoggingEnabled):
2132         Add a new testRunner method, setSpellCheckerLoggingEnabled, which, when
2133         set to true, logs to stdout (which ends up in the test result) whenever
2134         NSSpellChecker recordResponse:toCorrection:forWord:language:inSpellDocumentWithTag:
2135         is called, and then calls the original method. It is reset to false between tests.
2136
2137 2017-01-03  Sam Weinig  <sam@webkit.org>
2138
2139         Make WTF::Expected support Ref template parameters
2140         https://bugs.webkit.org/show_bug.cgi?id=166662
2141
2142         Reviewed by Alex Christensen.
2143
2144         * TestWebKitAPI/Tests/WTF/Expected.cpp:
2145         (TestWebKitAPI::TEST):
2146         Add tests for using Ref with Expected.
2147
2148 2017-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
2149
2150         [GTK] Expose WebKitSecurityOrigin API
2151         https://bugs.webkit.org/show_bug.cgi?id=166632
2152
2153         Reviewed by Carlos Garcia Campos.
2154
2155         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
2156         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSecurityOrigin.cpp: Added.
2157         (testSecurityOriginBasicConstructor):
2158         (testSecurityOriginURIConstructor):
2159         (testSecurityOriginDefaultPort):
2160         (testSecurityOriginFileURI):
2161         (testSecurityOriginDataURI):
2162         (beforeAll):
2163         (afterAll):
2164
2165 2017-01-03  Carlos Garcia Campos  <cgarcia@igalia.com>
2166
2167         [GTK] HTTP auth layout tests are flaky
2168         https://bugs.webkit.org/show_bug.cgi?id=158919
2169
2170         Reviewed by Michael Catanzaro.
2171
2172         * gtk/jhbuild.modules: Update libsoup to version 2.57.1.
2173         * gtk/jhbuildrc: Stop passing --enable-introspection unconditionally to all modules. We don't really need
2174         introspection for the dependencies in the internal build, and it makes newer libsoup build fail because of
2175         missing valac in the bots.
2176
2177 2017-01-03  Carlos Garcia Campos  <cgarcia@igalia.com>
2178
2179         REGRESSION(r173753): [GTK] Source/WebKit is distributed in tarballs
2180         https://bugs.webkit.org/show_bug.cgi?id=165797
2181
2182         Reviewed by Michael Catanzaro.
2183
2184         Move directory ruleset after all exclude rules of Source rulset.
2185
2186         * gtk/manifest.txt.in:
2187
2188 2017-01-02  Yusuke Suzuki  <utatane.tea@gmail.com>
2189
2190         Leverage Substring to create new AtomicStringImpl for StaticStringImpl and SymbolImpl
2191         https://bugs.webkit.org/show_bug.cgi?id=166636
2192
2193         Reviewed by Darin Adler.
2194
2195         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
2196         (TestWebKitAPI::TEST):
2197
2198 2017-01-02  Manuel Rego Casasnovas  <rego@igalia.com>
2199
2200         [GTK] WebCore/CSSParser unit test is not being built
2201         https://bugs.webkit.org/show_bug.cgi?id=166492
2202
2203         Reviewed by Michael Catanzaro.
2204
2205         This test was introduced in r175930, but we were not building
2206         it on GTK+ port since r176015.
2207         This patch marks the test to be built again on GTK+.
2208         JFTR, the test is passing right now.
2209
2210         * TestWebKitAPI/PlatformGTK.cmake: Add CSSParser.cpp test file and use
2211         ADD_WHOLE_ARCHIVE_TO_LIBRARIES to avoid linking errors.
2212
2213 2017-01-02  Chris Fleizach  <cfleizach@apple.com>
2214
2215         AX: Expose block quote level to iOS API
2216         https://bugs.webkit.org/show_bug.cgi?id=166629
2217         <rdar://problem/29834793>
2218
2219         Reviewed by Darin Adler.
2220
2221         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2222         (AccessibilityUIElement::numberAttributeValue):
2223         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2224         (WTR::AccessibilityUIElement::numberAttributeValue):
2225
2226 2016-12-31  Michael Catanzaro  <mcatanzaro@igalia.com>
2227
2228         SecurityOrigin::create triplet constructor does not canonicalize port
2229         https://bugs.webkit.org/show_bug.cgi?id=166624
2230
2231         Reviewed by Daniel Bates.
2232
2233         * TestWebKitAPI/PlatformGTK.cmake:
2234         * TestWebKitAPI/PlatformWin.cmake:
2235         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2236         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp: Added.
2237         (TestWebKitAPI::SecurityOriginTest::SetUp):
2238         (TestWebKitAPI::TEST_F):
2239
2240 2016-12-30  Michael Catanzaro  <mcatanzaro@igalia.com>
2241
2242         [GTK] Improve user agent construction
2243         https://bugs.webkit.org/show_bug.cgi?id=142074
2244
2245         Reviewed by Carlos Garcia Campos.
2246
2247         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
2248         (TestWebKitAPI::assertUserAgentForURLHasChromeBrowserQuirk):
2249         (TestWebKitAPI::assertUserAgentForURLHasFirefoxBrowserQuirk):
2250         (TestWebKitAPI::assertUserAgentForURLHasLinuxPlatformQuirk):
2251         (TestWebKitAPI::assertUserAgentForURLHasMacPlatformQuirk):
2252         (TestWebKitAPI::TEST):
2253
2254 2016-12-27  Michael Catanzaro  <mcatanzaro@igalia.com>
2255
2256         [GTK] Improve user agent construction
2257         https://bugs.webkit.org/show_bug.cgi?id=142074
2258
2259         Reviewed by Carlos Garcia Campos.
2260
2261         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
2262         (TestWebKitAPI::TEST):
2263
2264 2016-12-23  Simon Fraser  <simon.fraser@apple.com>
2265
2266         REGRESSION (r209299): Selection is broken when you zoom in webpage using trackpad
2267         https://bugs.webkit.org/show_bug.cgi?id=166472
2268         rdar://problem/29675551
2269
2270         Reviewed by Tim Horton.
2271
2272         These changes are necessary to allow the mouse to leave the WTR window while
2273         drag-scrolling, to test autoscroll. Previously, we were never calling -mouseDragged
2274         (which DRT does); we'd always go through mouseMoved, which hits an early return
2275         in WebViewImpl::mouseMoved() when the point is outside the view.
2276
2277         * WebKitTestRunner/mac/EventSenderProxy.mm:
2278         (WTR::EventSenderProxy::mouseMoveTo):
2279
2280 2016-12-23  Andy Estes  <aestes@apple.com>
2281
2282         [iOS] Fix some crashing webarchive tests
2283         https://bugs.webkit.org/show_bug.cgi?id=166470
2284
2285         Reviewed by Andreas Kling.
2286
2287         Tests that use TestRunner.dumpDOMAsWebArchive() crashed on iOS due to a stub implementation
2288         of WebArchiveDumpSupport in WebKitTestRunner. The Mac implementation works fine on iOS too,
2289         so this change uses that on both platforms.
2290
2291         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig: Removed
2292         WebArchiveDumpSupportMac.mm from EXCLUDED_SOURCE_FILE_NAMES.
2293         * WebKitTestRunner/InjectedBundle/cocoa/WebArchiveDumpSupportCocoa.mm: Renamed from
2294         Tools/WebKitTestRunner/mac/WebArchiveDumpSupportMac.mm.
2295         * WebKitTestRunner/PlatformMac.cmake:
2296         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2297         * WebKitTestRunner/ios/WebArchiveDumpSupportIOS.mm: Removed.
2298
2299 2016-12-22  Saam Barati  <sbarati@apple.com>
2300
2301         WebAssembly: Silence the output of the spec-tests
2302         https://bugs.webkit.org/show_bug.cgi?id=166417
2303
2304         Reviewed by Mark Lam.
2305
2306         * Scripts/run-jsc-stress-tests:
2307
2308 2016-12-22  Zhuo Li  <zachli@apple.com>
2309
2310         [Cocoa] SPI for setloadsImagesAutomatically.
2311         https://bugs.webkit.org/show_bug.cgi?id=166401.
2312
2313         Reviewed by Darin Adler.
2314
2315         * TestWebKitAPI/Tests/WebKit2Cocoa/Preferences.mm:
2316         (TEST): Test the _setLoadsImagesAutomatically SPI. By default,
2317         _loadsImagesAutomatically returns YES.
2318
2319 2016-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
2320
2321         fast/events/ios/viewport-shrink-to-fit-allows-double-tap.html is flaky/order dependent
2322         https://bugs.webkit.org/show_bug.cgi?id=161328
2323         <rdar://problem/28475977>
2324
2325         Reviewed by Darin Adler.
2326
2327         Running a test that scales the viewport and listens to a didEndZooming callback (such as
2328         viewport-shrink-to-fit-allows-double-tap.html) immediately after a test that may begin to trigger viewport
2329         scaling as the test completes (such as viewport-device-width-at-initial-scale-fast-clicks.html) may result in
2330         the didEndZooming callback of the latter test being fired early due to the previous test triggering a zoom
2331         animation. Ideally, -[WKScrollView _stopScrollingAndZoomingAnimations], which is called when committing the page
2332         load, should prevent this from happening, but from reading documentation and code inspection, this is not
2333         intended to fire any associated delegate methods or notifications of the UIScrollView, instead deferring them
2334         for later. Instead, what we need in this case is to clear out any started but not yet completed animations after
2335         we finish running a test and before we load the next test.
2336
2337         One way to do this is to remove all animations from the WKScrollView's layer, and the layers of its children,
2338         recursively. Doing so causes scrollViewDidEndZooming:withView:atScale: to fire at the end of the runloop if the
2339         previous test started zooming and then finished before zooming completed. Since this happens before the next
2340         test has a chance to run UI-side scripts, we won't end up firing this callback prematurely during the next test.
2341
2342         * WebKitTestRunner/ios/TestControllerIOS.mm:
2343         (WTR::TestController::platformResetStateToConsistentValues):
2344
2345 2016-12-22  Jer Noble  <jer.noble@apple.com>
2346
2347         Muted media element playback should not interrupt other audio playback
2348         https://bugs.webkit.org/show_bug.cgi?id=166347
2349
2350         Reviewed by Eric Carlson.
2351
2352         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2353         * TestWebKitAPI/Tests/WebKit/ios/AudioSessionCategoryIOS.mm:
2354         (TestWebKitAPI::TEST):
2355         * TestWebKitAPI/Tests/WebKit/ios/video-with-muted-audio.html: Added.
2356
2357 2016-12-22  Alejandro G. Castro  <alex@igalia.com>
2358
2359         [WebRTC] Add support for runtime PeeConnection setting, required after r209757
2360         https://bugs.webkit.org/show_bug.cgi?id=166346
2361
2362         Reviewed by Carlos Garcia Campos.
2363
2364         Enable WebRTC by default to simplify testing.
2365
2366         * MiniBrowser/gtk/main.c:
2367         (main):
2368
2369 2016-12-21  Alexey Proskuryakov  <ap@apple.com>
2370
2371         REGRESSION: API test failure: WKWebView.LocalStorageClear
2372         https://bugs.webkit.org/show_bug.cgi?id=166032
2373         <rdar://problem/29758423>
2374
2375         Reviewed by Simon Fraser.
2376
2377         Add an @autoreleasepool around the code that allocates then clears the WKWebView, 
2378         to ensure that the view is destroyed before the callback fires.
2379
2380         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
2381         (TEST):
2382
2383 2016-12-21  Saam Barati  <sbarati@apple.com>
2384
2385         WebAssembly: Import spec tests
2386         https://bugs.webkit.org/show_bug.cgi?id=166395
2387
2388         Rubber stamped by Keith Miller.
2389
2390         * Scripts/run-jsc-stress-tests:
2391
2392 2016-12-21  Alexey Proskuryakov  <ap@apple.com>
2393
2394         REGRESSION: API test failure: _WKDownload.OriginatingWebView
2395         https://bugs.webkit.org/show_bug.cgi?id=166033
2396         <rdar://problem/29758428>
2397
2398         Reviewed by Simon Fraser.
2399
2400         Add an @autoreleasepool around the code that allocates the WKWebView, 
2401         so that it can be destroyed by removing the last reference in _downloadDidStart.
2402
2403         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2404         (TEST):
2405
2406 2016-12-21  Daniel Bates  <dabates@apple.com>
2407
2408         WebKitTestRunner: Add comment to TestRunner::setCanOpenWindows()
2409         https://bugs.webkit.org/show_bug.cgi?id=166356
2410
2411         Add comment in TestRunner::setCanOpenWindows() to elaborate further on its purpose
2412         as a means to allow a test to explicit allow an embedding client to open a new windows
2413         such that the default behavior is for the embedding client to forbid such an action.
2414         The test plugins/get-url-with-blank-target.html assumes this default behavior though
2415         it is currently skipped on WebKit2 because questions were raised in the patch for
2416         <https://bugs.webkit.org/show_bug.cgi?id=43389> about its correctness and usefulness.
2417         We will need to implement TestRunner::setCanOpenWindows() should we decide to unskip
2418         this test.
2419
2420         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2421         (WTR::TestRunner::setCanOpenWindows):
2422
2423 2016-12-20  Simon Fraser  <simon.fraser@apple.com>
2424
2425         REGRESSION: API test failure: WKWebView.EvaluateJavaScriptBlockCrash
2426         https://bugs.webkit.org/show_bug.cgi?id=166031
2427
2428         Reviewed by Tim Horton.
2429         
2430         Add an @autoreleasepool around the code that allocates then clears the WKWebView, 
2431         to ensure that the view is destroyed before the callback fires.
2432
2433         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewEvaluateJavaScript.mm:
2434
2435 2016-12-20  Megan Gardner  <megan_gardner@apple.com>
2436
2437         Throw Exception when test doesn't clean up HID Events properly
2438         https://bugs.webkit.org/show_bug.cgi?id=166271
2439
2440         Reviewed by Simon Fraser.
2441
2442         Add in a check when UIScriptController is deleted to make sure that the HID event
2443         callback dictionary is empty. If it is not, and a HID event is hit, this will cause
2444         the program to crash without any good information. Crashes are race-y, and will still
2445         happen with malformed test, but the information will be much more helpful. 
2446
2447         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2448         (WTR::UIScriptController::checkForClean):
2449         * TestRunnerShared/UIScriptContext/UIScriptContext.cpp:
2450         (UIScriptContext::~UIScriptContext):
2451         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2452         (WTR::UIScriptController::checkForClean):
2453         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2454         * WebKitTestRunner/ios/HIDEventGenerator.h:
2455         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2456         (-[HIDEventGenerator checkHIDCallbacksClear]):
2457         * WebKitTestRunner/ios/TestControllerIOS.mm:
2458         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2459         (WTR::UIScriptController::checkForClean):
2460
2461 2016-12-20  Andy Estes  <aestes@apple.com>
2462
2463         [Cocoa] REGRESSION (r209558): Calling decisionHandler multiple times in webView:decidePolicyForNavigationAction:decisionHandler: leads to a crash
2464         https://bugs.webkit.org/show_bug.cgi?id=165992
2465
2466         Reviewed by Brady Eidson.
2467
2468         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2469         * TestWebKitAPI/Tests/WebKit2Cocoa/DuplicateCompletionHandlerCalls.mm: Added.
2470         (expectException):
2471         (-[DuplicateCompletionHandlerCallsDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2472         (-[DuplicateCompletionHandlerCallsDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
2473         (-[DuplicateCompletionHandlerCallsDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
2474         (-[DuplicateCompletionHandlerCallsDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
2475         (-[DuplicateCompletionHandlerCallsDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:completionHandler:]):
2476         (-[DuplicateCompletionHandlerCallsDelegate _webView:decideDatabaseQuotaForSecurityOrigin:currentQuota:currentOriginUsage:currentDatabaseUsage:expectedUsage:decisionHandler:]):
2477         (-[DuplicateCompletionHandlerCallsDelegate _webView:willSubmitFormValues:userObject:submissionHandler:]):
2478         (TEST):
2479         * TestWebKitAPI/Tests/WebKit2Cocoa/duplicate-completion-handler-calls.html: Added.
2480
2481 2016-12-20  Dean Jackson  <dino@apple.com>
2482
2483         Remove INDIE_UI
2484         https://bugs.webkit.org/show_bug.cgi?id=165881
2485         <rdar://problem/29672532>
2486
2487         Reviewed by Simon Fraser.
2488
2489         The Indie UI work has been discontinued.
2490
2491         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2492
2493 2016-12-19  Yusuke Suzuki  <utatane.tea@gmail.com>
2494
2495         [ES6] Enable ES6 Modules
2496         https://bugs.webkit.org/show_bug.cgi?id=165849
2497
2498         Reviewed by Geoffrey Garen.
2499
2500         * DumpRenderTree/mac/DumpRenderTree.mm:
2501         (resetWebPreferencesToConsistentValues):
2502         * DumpRenderTree/win/DumpRenderTree.cpp:
2503         (resetWebPreferencesToConsistentValues):
2504         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2505         (WTR::InjectedBundle::beginTesting):
2506         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2507         (WTR::TestRunner::setES6ModulesEnabled): Deleted.
2508         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2509
2510 2016-12-19  Ryan Haddad  <ryanhaddad@apple.com>
2511
2512         Repurpose bots and clean up dashboard.
2513         https://bugs.webkit.org/show_bug.cgi?id=166045
2514
2515         Reviewed by Lucas Forschler.
2516
2517         * BuildSlaveSupport/build.webkit.org-config/config.json:
2518         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
2519         (BubbleQueueServer):
2520         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
2521         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2522         (WebKitBuildbot):
2523         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2524         (table.queue-grid tr.platform.mac-os-x-yosemite img.logo): Deleted.
2525
2526 2016-12-19  Michael Catanzaro  <mcatanzaro@igalia.com>
2527
2528         [CMake] TestWebKitAPIBase links to itself
2529         https://bugs.webkit.org/show_bug.cgi?id=165985
2530
2531         Reviewed by Alex Christensen.
2532
2533         Fix CMake warning about a target linking to itself, which makes no sense.
2534
2535         * TestWebKitAPI/CMakeLists.txt:
2536
2537 2016-12-19  Michael Catanzaro  <mcatanzaro@igalia.com>
2538
2539         [GTK] GtkDoc build should be quieter
2540         https://bugs.webkit.org/show_bug.cgi?id=165994
2541
2542         Reviewed by Carlos Garcia Campos.
2543
2544         Make it not print by default.
2545
2546         * gtk/generate-gtkdoc:
2547         (get_generator_for_config):
2548         (generate_doc):
2549         * gtk/gtkdoc.py:
2550         (GTKDoc._run_command):
2551         (GTKDoc._copy_doc_files_to_output_dir):
2552
2553 2016-12-18  Simon Fraser  <simon.fraser@apple.com>
2554
2555         Expose a way for MiniBrowser to simulate header and footer banners
2556         https://bugs.webkit.org/show_bug.cgi?id=166005
2557
2558         Reviewed by Wenson Hsieh.
2559         
2560         Add a MiniBrowser menu item and setting to toggle adding space for header and footer
2561         banners. This only works in WebKit2.
2562         
2563         We need to reset these on each navigation, since newly created FrameViews
2564         don't re-fetch the header and footer height stored on Page.
2565         
2566         Also fix the signature of webView:didFinishNavigation: to follow API changes,
2567         as well as fixing webViewWebContentProcessDidTerminate:
2568
2569         * MiniBrowser/mac/SettingsController.h:
2570         * MiniBrowser/mac/SettingsController.m:
2571         (-[SettingsController _populateMenu]):
2572         (-[SettingsController validateMenuItem:]):
2573         (-[SettingsController toggleReserveSpaceForBanners:]):
2574         (-[SettingsController isSpaceReservedForBanners]):
2575         * MiniBrowser/mac/WK2BrowserWindowController.m:
2576         (-[WK2BrowserWindowController didChangeSettings]):
2577         (-[WK2BrowserWindowController webView:didFinishNavigation:]):
2578         (-[WK2BrowserWindowController webViewWebContentProcessDidTerminate:]):
2579         (-[WK2BrowserWindowController webView:didFinishLoadingNavigation:]): Deleted.
2580         (-[WK2BrowserWindowController _webViewWebProcessDidCrash:]): Deleted.
2581
2582 2016-12-17  Simon Fraser  <simon.fraser@apple.com>
2583
2584         Fix iOS test results after r209967.
2585         
2586         Subtracting out the status bar height was erroneously happening for all tests,
2587         not just for flexible viewport tests.
2588         
2589         Fix by plumbing WebViewSizingMode through resizeTo() and setWindowFrame().
2590
2591         * WebKitTestRunner/PlatformWebView.h:
2592         * WebKitTestRunner/TestController.cpp:
2593         (WTR::TestController::resetStateToConsistentValues):
2594         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2595         (WTR::PlatformWebView::resizeTo):
2596         (WTR::PlatformWebView::setWindowFrame):
2597         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
2598         (WTR::PlatformWebView::resizeTo):
2599         (WTR::PlatformWebView::setWindowFrame):
2600         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2601         (WTR::PlatformWebView::resizeTo):
2602         (WTR::PlatformWebView::setWindowFrame):
2603         * WebKitTestRunner/ios/TestControllerIOS.mm:
2604         (WTR::TestController::platformConfigureViewForTest):
2605         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2606         (WTR::PlatformWebView::resizeTo):
2607         (WTR::PlatformWebView::setWindowFrame):
2608
2609 2016-12-17  Joonghun Park  <jh718.park@samsung.com>
2610
2611         [EFL] bump EFL version to 1.18.4
2612         https://bugs.webkit.org/show_bug.cgi?id=166004
2613
2614         Reviewed by Gyuyoung Kim.
2615
2616         * efl/jhbuild.modules: Use efl-1.18.4 instead of 1.18.1.
2617
2618 2016-12-17  Wenson Hsieh  <wenson_hsieh@apple.com>
2619
2620         Visual viewports: bottom fixed elements disappear behind the keyboard
2621         https://bugs.webkit.org/show_bug.cgi?id=165983
2622         <rdar://problem/29409852>
2623
2624         Reviewed by Simon Fraser.
2625
2626         Add support for UIScriptController.inputViewBounds, which UI-side scripts may use to fetch the bounding rect of
2627         the keyboard when it is up.
2628
2629         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2630         (WTR::UIScriptController::inputViewBounds):
2631         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2632         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2633         (WTR::UIScriptController::inputViewBounds):
2634         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2635         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2636         (WTR::viewRectForWindowRect):
2637
2638         Previously, we accounted for the status bar height by translating the entire web view down by the height of the
2639         status bar. However, we did not shrink the height of the web view itself, which means that for tests which
2640         involve scrolling past the end of the document, the bottom strip of the web view is out of bounds of the window.
2641
2642         (WTR::PlatformWebView::PlatformWebView):
2643         (WTR::PlatformWebView::setWindowFrame):
2644         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2645         (WTR::UIScriptController::inputViewBounds):
2646
2647 2016-12-16  Ryosuke Niwa  <rniwa@webkit.org>
2648
2649         Deleting a character converted from pinyin after an image causes a Safari crash
2650         https://bugs.webkit.org/show_bug.cgi?id=165839
2651         <rdar://problem/27951933>
2652
2653         Reviewed by Wenson Hsieh.
2654
2655         Add a WebKit API test to call attributedSubstringForProposedRange on a WKWebView
2656         while the proposed range contains an image. This should not cause a WebProcess to crash
2657         or send an invalid message to the UIProcess.
2658
2659         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2660         * TestWebKitAPI/Tests/WebKit2/chinese-character-with-image.html: Added.
2661         * TestWebKitAPI/Tests/WebKit2/mac/AttributedSubstringForProposedRangeWithImage.mm: Added.
2662         (TestWebKitAPI::didFinishLoadForFrame):
2663         (TestWebKitAPI::processDidCrash):
2664         (TestWebKitAPI::invalidMessageFunction):
2665         (TestWebKitAPI::WebKit2.AttributedSubstringForProposedRangeWithImage):
2666
2667 2016-12-16  Wenson Hsieh  <wenson_hsieh@apple.com>
2668
2669         Visual viewports: carets and selection UI are incorrectly positioned when editing fixed elements
2670         https://bugs.webkit.org/show_bug.cgi?id=165767
2671         <rdar://problem/29602382>
2672
2673         Reviewed by Simon Fraser.
2674
2675         Introduces two new UIScriptController methods: doAfterWebPageIsInStableState and textSelectionCaretRect. See
2676         WebKit2 ChangeLog for more details.
2677
2678         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2679         (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
2680         (WTR::UIScriptController::textSelectionCaretRect):
2681         * DumpRenderTree/mac/UIScriptControllerMac.mm:
2682         (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
2683         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2684         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2685         (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
2686         (WTR::UIScriptController::textSelectionCaretRect):
2687         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2688         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2689         (-[TestRunnerWKWebView _setStableStateOverride:]):
2690
2691         Force the WKWebView to update its visible content rects when changing the stable state override.
2692
2693         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2694         (WTR::toNSDictionary):
2695         (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
2696         (WTR::UIScriptController::selectionRangeViewRects):
2697         (WTR::UIScriptController::textSelectionCaretRect):
2698         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
2699         (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
2700
2701 2016-12-15  Brent Fulgham  <bfulgham@apple.com>
2702
2703         Arguments called in wrong order
2704         https://bugs.webkit.org/show_bug.cgi?id=165923
2705
2706         Reviewed by Simon Fraser.
2707
2708         The 'audioDeviceUIDs' array is being passed to the argument that expects video devices,
2709         and the 'videoDeviceUIDs' array is being passed to the audo device argument. Fix this.
2710
2711         * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp:
2712         (TestWebKitAPI::decidePolicyForUserMediaPermissionRequestCallBack): The
2713         order of arguments to WKUserMediaPermissionRequestAllow are flipped.
2714
2715 2016-12-16  Hunseop Jeong  <hs85.jeong@samsung.com>
2716
2717         [EFL] Disable non-srcdir builds for failing libraries
2718         https://bugs.webkit.org/show_bug.cgi?id=165896
2719
2720         Reviewed by Gyuyoung Kim.
2721
2722         * efl/jhbuild.modules: Set non srcdir builds to no
2723
2724 2016-12-15  Daniel Bates  <dabates@apple.com>
2725
2726         check-style should not complain about code in icu directories
2727         https://bugs.webkit.org/show_bug.cgi?id=53929
2728
2729         Reviewed by Darin Adler.
2730
2731         Skip style checking of imported ICU headers to avoid a deluge of style issues
2732         as they do not conform to the WebKit Code Style guideline. We want to preserve
2733         the formatting of these headers so as to make it straightforward to merge
2734         changes to them, if necessary.
2735
2736         * Scripts/webkitpy/style/checker.py:
2737
2738 2016-12-15  Alexey Proskuryakov  <ap@apple.com>
2739
2740         Move JSC testers from Yosemite to Sierra
2741         https://bugs.webkit.org/show_bug.cgi?id=165925
2742
2743         Reviewed by Lucas Forschler.
2744
2745         * BuildSlaveSupport/build.webkit.org-config/config.json:
2746         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2747         (WebKitBuildbot):
2748
2749 2016-12-15  Megan Gardner  <megan_gardner@apple.com>
2750
2751         Add coordinate space to event streams and streamline tests
2752         https://bugs.webkit.org/show_bug.cgi?id=165119
2753
2754         Reviewed by Simon Fraser.
2755
2756         Update event streams to allow for both content and global coordinate space.
2757         Update example script to more accurately show all the available options.
2758
2759         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2760         * WebKitTestRunner/ios/HIDEventGenerator.h:
2761         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2762         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2763         (WTR::convertCoordinates):
2764         (WTR::UIScriptController::sendEventStream):
2765
2766 2016-12-15  Claudio Saavedra  <csaavedra@igalia.com>
2767
2768         [GTK] Ensure gst* docs are not built with update-webkitgtk-libs
2769         https://bugs.webkit.org/show_bug.cgi?id=165855
2770
2771         Reviewed by Philippe Normand.
2772
2773         GStreamer's autogen.sh enables gtk-doc always so we end up building
2774         docs even if we disable them. Use the configure script instead, since
2775         we build from packages and these include it already.
2776
2777         * gtk/jhbuild.modules: Use shipped configure instead of autogen.sh for
2778         upstream gstreamer packages.
2779
2780 2016-12-15  Alex Christensen  <achristensen@webkit.org>
2781
2782         REGRESSION (r208902) Null pointer dereference in wkIsPublicSuffix
2783         https://bugs.webkit.org/show_bug.cgi?id=165885
2784         <rdar://problem/29476917>
2785
2786         Reviewed by Darin Adler.
2787
2788         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2789         (TestWebKitAPI::utf16String): Deleted.
2790         * TestWebKitAPI/Tests/mac/PublicSuffix.mm:
2791         (TestWebKitAPI::TEST_F):
2792         * TestWebKitAPI/WTFStringUtilities.h:
2793         (utf16String):
2794         Moved from URLParser to share with other tests.
2795
2796 2016-12-14  Ryosuke Niwa  <rniwa@webkit.org>
2797
2798         iOS: An element with tabindex is not focusable unless there is no mouse event handler
2799         https://bugs.webkit.org/show_bug.cgi?id=165843
2800
2801         Reviewed by Antti Koivisto.
2802
2803         Add testRunner.isWebKit2 which is always true in WebKitTestRunner.
2804         Without this, it's really hard to reliably differentiate DumpRenderTree and WebKitTestRunner,
2805         and DumpRenderTree's runUIScript would hit an assertion :(
2806
2807         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2808         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2809         (WTR::TestRunner::isWebKit2):
2810
2811 2016-12-14  Brady Eidson  <beidson@apple.com>
2812
2813         IndexedDB 2.0: Massively speedup IDBIndex.get().
2814         https://bugs.webkit.org/show_bug.cgi?id=165802
2815
2816         Reviewed by Alex Christensen.
2817
2818         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2819         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBIndexUpgradeToV2.html: Added.
2820         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBIndexUpgradeToV2.mm: Added.
2821         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexUpgrade.blob: Added.
2822         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexUpgrade.sqlite3: Added.
2823
2824 2016-12-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2825
2826         [GTK][EFL] Update the JHBuild version.
2827         https://bugs.webkit.org/show_bug.cgi?id=165838
2828
2829         Reviewed by Michael Catanzaro.
2830
2831         * jhbuild/jhbuild-wrapper: This new version fixes a bug with the
2832         usage of the JHBUILD_MIRROR feature with git repositories.
2833
2834 2016-12-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2835
2836         [GTK] Yasm is needed for building the JHBuild after r208940
2837         https://bugs.webkit.org/show_bug.cgi?id=165837
2838
2839         Reviewed by Alejandro G. Castro.
2840
2841         * gtk/install-dependencies: Yasm is needed for building libvpx.
2842
2843 2016-12-14  Youenn Fablet  <youenn@apple.com>
2844
2845         Test infrastructure should allow to filter out text output before doing a comparison with the baseline
2846         https://bugs.webkit.org/show_bug.cgi?id=161310
2847
2848         Reviewed by Ryosuke Niwa.
2849
2850         Adding --dump-jsconsolelog-in-stderr test option for DRT and WTR.
2851         When set, WTR and DRT output JS console log in the stderr and not the test output.
2852         This allows removing potentially flaky information while still being able to read it for investigation.
2853
2854         Updated webkitpy infrastructure to use this test option in case of DumpJSConsoleLogInStdErr modifier.
2855
2856         Changes are covered by updating a fetch test to output console log and set its option to --dump-jsconsolelog-in-stderr in TestExpectations.
2857         This test should have this option when fetch API will start logging resource loader errors.
2858
2859         * DumpRenderTree/DumpRenderTree.h:
2860         (TestCommand::TestCommand): Deleted.
2861         * DumpRenderTree/DumpRenderTreeCommon.cpp:
2862         (parseInputLine):
2863         * DumpRenderTree/TestRunner.h:
2864         (TestRunner::setDumpJSConsoleLogInStdErr):
2865         (TestRunner::dumpJSConsoleLogInStdErr):
2866         * DumpRenderTree/mac/DumpRenderTree.mm:
2867         (runTest):
2868         * DumpRenderTree/mac/UIDelegate.mm:
2869         (-[UIDelegate webView:addMessageToConsole:withSource:]):
2870         * DumpRenderTree/win/DumpRenderTree.cpp:
2871         (runTest):
2872         * DumpRenderTree/win/UIDelegate.cpp:
2873         (UIDelegate::webViewAddMessageToConsole):
2874         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2875         (TestExpectationParser._tokenize_line):
2876         * Scripts/webkitpy/port/driver.py:
2877         (Driver._command_from_driver_input):
2878         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2879         (WTR::InjectedBundle::didReceiveMessageToPage):
2880         (WTR::InjectedBundle::dumpToStdErr):
2881         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2882         (WTR::InjectedBundle::dumpJSConsoleLogInStdErr):
2883         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2884         (WTR::InjectedBundlePage::willAddMessageToConsole):
2885         * WebKitTestRunner/TestController.cpp:
2886         (WTR::parseInputLine):
2887         (WTR::TestController::runTest):
2888         (WTR::TestCommand::TestCommand): Deleted.
2889         * WebKitTestRunner/TestInvocation.cpp:
2890         (WTR::TestInvocation::invoke):
2891         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2892         * WebKitTestRunner/TestInvocation.h:
2893         (WTR::TestInvocation::setDumpJSConsoleLogInStdErr):
2894
2895
2896 2016-12-14  Enrique Ocaña González  <eocanha@igalia.com>
2897
2898         REGRESSION(r207879-207891): [GStreamer] Introduced many layout test failures and crashes, bots exiting early
2899         https://bugs.webkit.org/show_bug.cgi?id=164022
2900
2901         Reviewed by Xabier Rodriguez-Calvar.
2902
2903         * Scripts/webkitperl/FeatureList.pm:
2904           Re-enable MEDIA_SOURCE for the GTK+ port.
2905
2906 2016-12-13  Alex Christensen  <achristensen@webkit.org>
2907
2908         Fix CMake build.
2909
2910         * DumpRenderTree/PlatformMac.cmake:
2911         Define NS_RETURNS_RETAINED as nothing for now.
2912
2913 2016-12-13  Jer Noble  <jer.noble@apple.com>
2914
2915         Fullscreen in WebKit2 does not restore topContentInset upon exiting; leaves top of page not visible
2916         https://bugs.webkit.org/show_bug.cgi?id=165697
2917
2918         Reviewed by Tim Horton.
2919
2920         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenTopContentInset.mm:
2921         (TestWebKitAPI::TEST):
2922
2923 2016-12-13  Andy Estes  <aestes@apple.com>
2924
2925         [Cocoa] Implement -shouldInsertText: on WKWebProcessPlugInEditingDelegate
2926         https://bugs.webkit.org/show_bug.cgi?id=165785
2927         <rdar://problem/26929398>
2928
2929         Reviewed by Darin Adler.
2930
2931         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegate.mm:
2932         (-[BundleEditingDelegateRemoteObject shouldInsertText:replacingRange:givenAction:]): Added
2933         expectations for the text, range, and action.
2934         (TEST): Set the "EditingDelegateShouldInsertText" bundle parameter to NO so that the plug-in
2935         will return NO in -_webProcessPlugInBrowserContextController:willInsertText:. Added a
2936         plain-text string to the pasteboard, executed a paste action, and verified that the selected
2937         text in the web view did not change.
2938         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegatePlugIn.mm:
2939         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]): Set
2940         _editingDelegateShouldInsertText according to the "EditingDelegateShouldInsertText" bundle
2941         parameter.
2942         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:shouldInsertText:replacingRange:givenAction:]):
2943         Added. Called -shouldInsertText:replacingRange:givenAction: on the remote object proxy
2944         and returned the value of _editingDelegateShouldInsertText.
2945         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegateProtocol.h: Declared
2946         -shouldInsertText:replacingRange:givenAction:.
2947
2948 2016-12-13  Chris Dumez  <cdumez@apple.com>
2949
2950         Unreviewed, rolling out r209544.
2951
2952         Looks like r209489 did not cause the performance regression
2953         after all
2954
2955         Reverted changeset:
2956
2957         "Unreviewed, rolling out r209489."
2958         https://bugs.webkit.org/show_bug.cgi?id=165550
2959         http://trac.webkit.org/changeset/209544
2960
2961 2016-12-12  Sam Weinig  <sam@webkit.org>
2962
2963         [WebIDL] Remove use of Dictionary in ApplePaySession
2964         https://bugs.webkit.org/show_bug.cgi?id=165787
2965
2966         Reviewed by Anders Carlsson.
2967
2968         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2969         (WTR::initializeWebViewConfiguration):
2970         (WTR::TestController::platformCreateWebView):
2971         Enable ApplePay for the tests (where supported).
2972
2973 2016-12-13  Eric Carlson  <eric.carlson@apple.com>
2974
2975         Annotate MediaStream and WebRTC idl with EnabledAtRuntime flag
2976         https://bugs.webkit.org/show_bug.cgi?id=165251
2977
2978         Reviewed by Youenn Fablet.
2979
2980         * TestWebKitAPI/Tests/WebKit2/EnumerateMediaDevices.cpp:
2981         (TestWebKitAPI::TEST): Enable MediaStream, create web view from the page group upon which
2982         the preferences have been set.
2983
2984 2016-12-08  Antti Koivisto  <antti@apple.com>
2985
2986         Enable network cache speculative revalidation in MiniBrowser
2987         https://bugs.webkit.org/show_bug.cgi?id=165616
2988
2989         Reviewed by Darin Adler.
2990
2991         Match Safari. Also add a menu item to disable it.
2992
2993         * MiniBrowser/mac/AppDelegate.m:
2994         (defaultConfiguration):
2995         * MiniBrowser/mac/SettingsController.h:
2996         * MiniBrowser/mac/SettingsController.m:
2997         (-[SettingsController _populateMenu]):
2998         (-[SettingsController validateMenuItem:]):
2999         (-[SettingsController networkCacheSpeculativeRevalidationDisabled]):
3000         (-[SettingsController toggleNetworkCacheSpeculativeRevalidationDisabled:]):
3001
3002 2016-12-12  Alexey Proskuryakov  <ap@apple.com>
3003
3004         ChangeLogs become readonly after resolving a conflict
3005         https://bugs.webkit.org/show_bug.cgi?id=165440
3006         rdar://problem/29491002
3007
3008         Reviewed by Darin Adler.
3009
3010         * Scripts/resolve-ChangeLogs: (resolveChangeLog): Set correct permissions when
3011         moving the file.
3012
3013 2016-12-12  Filip Pizlo  <fpizlo@apple.com>
3014
3015         Re-enable collectContinuously since it doesn't crash anymore
3016
3017         Rubber stamped by Michael Saboff.
3018
3019         * Scripts/run-jsc-stress-tests:
3020
3021 2016-12-11  Konstantin Tokarev  <annulen@yandex.ru>
3022
3023         Unreviewed attempt to fix EFL and Mac/cmake builds after r209665.
3024         https://bugs.webkit.org/show_bug.cgi?id=165686
3025
3026         * DumpRenderTree/CMakeLists.txt: WebKit2 should precede other target
3027         so that right config.h comes first in include path.
3028
3029 2016-12-11  Dave Hyatt  <hyatt@apple.com>
3030
3031         [CSS Parser] Make sure content extensions initialize AtomicString
3032         https://bugs.webkit.org/show_bug.cgi?id=165737
3033
3034         Reviewed by Darin Adler.
3035
3036         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3037         (TestWebKitAPI::makeBackend):
3038
3039 2016-12-08  Dave Hyatt  <hyatt@apple.com>
3040
3041         [CSS Parser] Remove the old CSS Parser
3042         https://bugs.webkit.org/show_bug.cgi?id=165645
3043
3044         Reviewed by Daniel Bates.
3045
3046         * TestWebKitAPI/Tests/WebCore/CSSParser.cpp:
3047         (TestWebKitAPI::TEST):
3048
3049 2016-12-10  Konstantin Tokarev  <annulen@yandex.ru>
3050
3051         [cmake] Include WTF, JSC, and WebCore headers automatically to targers using them
3052         https://bugs.webkit.org/show_bug.cgi?id=165686
3053
3054         Reviewed by Michael Catanzaro.
3055
3056         This change reduces duplication of include path lists between modules,
3057         and reduces future need for fixes like r209605 (broken build because of
3058         WebCore header suddenly becoming used in WebKit2).
3059
3060         * DumpRenderTree/CMakeLists.txt:
3061         * DumpRenderTree/PlatformMac.cmake:
3062         * ImageDiff/CMakeLists.txt:
3063         * MiniBrowser/gtk/CMakeLists.txt:
3064         * MiniBrowser/mac/CMakeLists.txt:
3065         * MiniBrowser/win/CMakeLists.txt:
3066         * TestWebKitAPI/CMakeLists.txt:
3067         * TestWebKitAPI/PlatformEfl.cmake:
3068         * TestWebKitAPI/PlatformJSCOnly.cmake:
3069         * TestWebKitAPI/PlatformMac.cmake:
3070         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
3071         * WebKitTestRunner/CMakeLists.txt:
3072         * WebKitTestRunner/PlatformGTK.cmake:
3073         * WebKitTestRunner/PlatformMac.cmake:
3074
3075 2016-12-09  Csaba Osztrogonác  <ossy@webkit.org>
3076
3077         Unreviewed buildfix after r209630.
3078
3079         * Scripts/build-jsc: Remove building the non-existing testWASM.
3080
3081 2016-12-09  Eric Carlson  <eric.carlson@apple.com>
3082
3083         Annotate MediaStream and WebRTC idl with EnabledAtRuntime flag
3084         https://bugs.webkit.org/show_bug.cgi?id=165251
3085
3086         Reviewed by Dean Jackson.
3087
3088         Based on a patch by Dr Alex Gouaillard <agouaillard@gmail.com>
3089
3090         * DumpRenderTree/mac/DumpRenderTree.mm:
3091         (resetWebPreferencesToConsistentValues): Enable MediaStream and PeerConnection.
3092
3093         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3094         (WTR::InjectedBundle::beginTesting): Ditto.
3095
3096         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3097         (WTR::TestRunner::setMediaStreamEnabled): New.
3098         (WTR::TestRunner::setPeerConnectionEnabled): New.
3099         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3100
3101 2016-12-09  Brady Eidson  <beidson@apple.com> 
3102  
3103         Re-landing:
3104         Add _WKIconLoadingDelegate SPI. 
3105         https://bugs.webkit.org/show_bug.cgi?id=164894 
3106  
3107         Reviewed by Alex Christensen. 
3108         
3109         Add MiniBrowser support for this new SPI, configurable with a setting. 
3110  
3111         * MiniBrowser/mac/SettingsController.h: 
3112         * MiniBrowser/mac/SettingsController.m: 
3113         (-[SettingsController _populateMenu]): 
3114         (-[SettingsController validateMenuItem:]): 
3115         (-[SettingsController loadsAllSiteIcons]): 
3116         (-[SettingsController toggleLoadsAllSiteIcons:]): 
3117         * MiniBrowser/mac/WK2BrowserWindowController.m: 
3118         (-[WK2BrowserWindowController awakeFromNib]): 
3119         (-[WK2BrowserWindowController webView:shouldLoadIconWithParameters:completionHandler:]): 
3120
3121 2016-12-09  Ryan Haddad  <ryanhaddad@apple.com>
3122
3123         Fix the 32-bit build.
3124
3125         Unreviewed build fix.
3126
3127         * MiniBrowser/mac/SettingsController.h:
3128
3129 2016-12-09  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
3130
3131         Fedora also needs a PHP7 config file alternative
3132         https://bugs.webkit.org/show_bug.cgi?id=165606
3133
3134         Reviewed by Michael Catanzaro.
3135
3136         * Scripts/webkitpy/port/base.py:
3137         (Port._is_fedora_php_version_7): check for the php7 library.
3138         (Port._fedora_php_version): get the appropriate filename for Fedora.
3139         (Port._apache_config_file_name_for_platform):
3140
3141 2016-12-09  Ryan Haddad  <ryanhaddad@apple.com>
3142
3143         Complete the revert of r208865.
3144         https://bugs.webkit.org/show_bug.cgi?id=164894
3145
3146         Unreviewed build fix.
3147
3148         * MiniBrowser/mac/SettingsController.h:
3149         * MiniBrowser/mac/SettingsController.m:
3150         (-[SettingsController _populateMenu]):
3151         (-[SettingsController validateMenuItem:]):
3152         (-[SettingsController loadsAllSiteIcons]): Deleted.
3153         (-[SettingsController toggleLoadsAllSiteIcons:]): Deleted.
3154         * MiniBrowser/mac/WK2BrowserWindowController.m:
3155         (-[WK2BrowserWindowController awakeFromNib]):
3156         (-[WK2BrowserWindowController webView:shouldLoadIconWithParameters:completionHandler:]): Deleted.
3157
3158 2016-12-09  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
3159
3160         [GTK] Force GDK backend to x11 when running with XvfbDriver
3161         https://bugs.webkit.org/show_bug.cgi?id=165612
3162
3163         Reviewed by Michael Catanzaro.
3164
3165         When the developer is running a Wayland session, GDK may get confused
3166         and try to use its Wayland backend (which is higher priority) instead.
3167         This ensures it will use the appropriate backend when running under
3168         Xvfb.
3169
3170         * Scripts/webkitpy/port/gtk.py:
3171         (GtkPort.setup_environ_for_server): when running with XvfbDriver,
3172         force GDK_BACKEND to x11.
3173
3174 2016-12-08  Keith Miller  <keith_miller@apple.com>
3175
3176         Add 64-bit signed LEB decode method
3177         https://bugs.webkit.org/show_bug.cgi?id=165630
3178
3179         Reviewed by Ryosuke Niwa.
3180
3181         Add tests for LEB int64 and uint64 decode since I guess
3182         I forgot to add tests before.
3183
3184         * TestWebKitAPI/Tests/WTF/LEBDecoder.cpp:
3185         (TestWebKitAPI::testUInt32LEBDecode):
3186         (TestWebKitAPI::TEST):
3187         (TestWebKitAPI::testUInt64LEBDecode):
3188         (TestWebKitAPI::testInt32LEBDecode):
3189         (TestWebKitAPI::testInt64LEBDecode):
3190         (TestWebKitAPI::testUnsignedLEBDecode): Deleted.
3191
3192 2016-12-08  Filip Pizlo  <fpizlo@apple.com>
3193
3194         Make it easy to enable --force-collectContinuously
3195         https://bugs.webkit.org/show_bug.cgi?id=165638
3196
3197         Reviewed by Keith Miller.
3198
3199         * Scripts/run-javascriptcore-tests:
3200         (runJSCStressTests):
3201
3202 2016-12-08  Filip Pizlo  <fpizlo@apple.com>
3203
3204         Disable the collectContinuously mode until I investigate failures.
3205
3206         Rubber stamped by Keith Miller.
3207         
3208         I'm seeing collectContinuously crashes on some platforms. Disabling that testing mode
3209         while I investigate.
3210
3211         * Scripts/run-jsc-stress-tests:
3212
3213 2016-12-08  Alex Christensen  <achristensen@webkit.org>
3214
3215         REGRESSION (URL parser): Relative URLs aren’t resolved correctly when the base URL is an applewebdata: URL
3216         https://bugs.webkit.org/show_bug.cgi?id=165621
3217
3218         Reviewed by Dan Bernstein.
3219
3220         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3221         (TestWebKitAPI::TEST_F):
3222
3223 2016-12-06  Filip Pizlo  <fpizlo@apple.com>
3224
3225         Concurrent GC should be stable enough to land enabled
3226         https://bugs.webkit.org/show_bug.cgi?id=164990
3227
3228         Reviewed by Geoffrey Garen.
3229         
3230         Add a new mode that runs GC continuously. Also made eager modes run GC continuously.
3231         
3232         It's clear that this works just fine in release, but I'm still trying to figure out if it's
3233         safe for debug. It might be too slow for debug.
3234
3235         * Scripts/run-jsc-stress-tests:
3236
3237 2016-12-08  Alex Christensen  <achristensen@webkit.org>
3238
3239         Add SPI for sending WebsiteSettings to WebProcess during navigation
3240         https://bugs.webkit.org/show_bug.cgi?id=165517
3241         <rdar://29341068>
3242
3243         Reviewed by Anders Carlsson.
3244
3245         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3246         * TestWebKitAPI/Tests/WebKit2/contentBlockerCheck.html: Added.
3247         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm: Added.
3248         (-[WebsitePoliciesDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3249         (-[WebsitePoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
3250         (-[WebsitePoliciesDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
3251         (TEST):
3252
3253 2016-12-08  Chris Dumez  <cdumez@apple.com>
3254
3255         Unreviewed, rolling out r209489.
3256
3257         Likely caused large regressions on JetStream, Sunspider and
3258         Speedometer
3259
3260         Reverted changeset:
3261
3262         "Add system trace points for JavaScript VM entry/exit"
3263         https://bugs.webkit.org/show_bug.cgi?id=165550
3264         http://trac.webkit.org/changeset/209489
3265
3266 2016-12-08  Keith Miller  <keith_miller@apple.com>
3267
3268         Move LEB tests to API tests
3269         https://bugs.webkit.org/show_bug.cgi?id=165586
3270
3271         Reviewed by Saam Barati.
3272
3273         Move the tests from testWasm.cpp and make them functions
3274         rather than macros.
3275
3276         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3277         * TestWebKitAPI/Tests/WTF/LEBDecoder.cpp: Added.
3278         (TestWebKitAPI::testUnsignedLEBDecode):
3279         (TestWebKitAPI::TEST):
3280         (TestWebKitAPI::testInt32LEBDecode):
3281
3282 2016-12-08  Chris Dumez  <cdumez@apple.com>
3283
3284         Support running the layout tests offline
3285         https://bugs.webkit.org/show_bug.cgi?id=165534
3286
3287         Reviewed by Ryosuke Niwa.
3288
3289         * Scripts/webkitpy/common/system/autoinstall.py:
3290         (AutoInstaller._download_to_stream):
3291         getcode() returns None for file URLs so handle this.
3292
3293         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
3294         (WebPlatformTestServer._install_modules):
3295         Deal with local path in the json file and resolve them into file URLs
3296         before using AutoInstall.
3297
3298 2016-12-08  Alex Christensen  <achristensen@webkit.org>
3299
3300         Fix CMake build.
3301
3302         * DumpRenderTree/PlatformMac.cmake:
3303         Remove CheckedMalloc.cpp after r209516.
3304
3305 2016-12-07  Mark Lam  <mark.lam@apple.com>
3306
3307         DumpRenderTree should stop using CheckedMalloc.
3308         https://bugs.webkit.org/show_bug.cgi?id=165563
3309         <rdar://problem/28945820>
3310
3311         Reviewed by Geoffrey Garen.
3312
3313         1. WebKitTestRunner does not have equivalent behavior to that which is implemented
3314            in CheckedMalloc.
3315         2. bmalloc does not honor the settings of CheckedMalloc.
3316
3317         The only time CheckedMalloc comes into play is when DRT uses gmalloc or system
3318         malloc.  As a result, DRT exhibits different behavior from the normal way we run
3319         our tests.  We should obsolete CheckedMalloc and make DRT behave consistently
3320         with WKTR.
3321
3322         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3323         * DumpRenderTree/mac/CheckedMalloc.cpp: Removed.
3324         * DumpRenderTree/mac/CheckedMalloc.h: Removed.
3325         * DumpRenderTree/mac/DumpRenderTree.mm:
3326         (prepareConsistentTestingEnvironment):
3327
3328 2016-12-07  Dean Jackson  <dino@apple.com>
3329
3330         Remove runtime toggle for pointer-lock
3331         https://bugs.webkit.org/show_bug.cgi?id=165577
3332         <rdar://problems/29566996>
3333
3334         Reviewed by Jon Lee.
3335
3336         Remove any runtime calls to check if pointer-lock is enabled. It's
3337         either compiled in or out.
3338
3339         * DumpRenderTree/mac/DumpRenderTree.mm:
3340         (resetWebPreferencesToConsistentValues):
3341         * WebKitTestRunner/TestController.cpp:
3342         (WTR::TestController::resetPreferencesToConsistentValues):
3343
3344 2016-12-07  Eric Carlson  <eric.carlson@apple.com>
3345
3346         [MediaStream][Mac] Revoke sandbox extensions when capture ends
3347         https://bugs.webkit.org/show_bug.cgi?id=165476
3348
3349         Reviewed by Brady Eidson.
3350         
3351         Add a test which loads a page that calls navigator.mediaDevices.enumerateDevices, kills the
3352         page, and loads the same page again to ensure that the WK2 UserMediaPermissionRequestManagerProxy
3353         is reset and recreated when a web page exits and is reloaded.
3354
3355         * TestWebKitAPI/PlatformGTK.cmake:
3356         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3357         * TestWebKitAPI/Tests/WebKit2/EnumerateMediaDevices.cpp: Added.
3358         (TestWebKitAPI::checkUserMediaPermissionCallback):
3359         (TestWebKitAPI::TEST):
3360         * TestWebKitAPI/Tests/WebKit2/enumerateMediaDevices.html: Added.
3361
3362 2016-12-07  Jeremy Jones  <jeremyj@apple.com>
3363
3364         One esc to exit fullscreen and pointer lock
3365         https://bugs.webkit.org/show_bug.cgi?id=165416
3366         rdar://problem/29430711
3367
3368         Reviewed by Jer Noble.
3369
3370         Implement WKPageUIClientV8 for pointer lock support.
3371         Add "escape" key support in EventSenderProxy.
3372
3373         * WebKitTestRunner/TestController.cpp:
3374         (WTR::requestPointerLock):
3375         (WTR::TestController::createOtherPage):
3376         (WTR::TestController::createWebViewWithOptions):
3377         * WebKitTestRunner/mac/EventSenderProxy.mm:
3378         (WTR::EventSenderProxy::keyDown):
3379
3380 2016-12-07  Simon Fraser  <simon.fraser@apple.com>
3381
3382         Add system trace points for JavaScript VM entry/exit
3383         https://bugs.webkit.org/show_bug.cgi?id=165550
3384
3385         Reviewed by Tim Horton.
3386
3387         Add trace points for entry/exit into/out of the JS VM.
3388
3389         * Tracing/SystemTracePoints.plist:
3390
3391 2016-12-07  ChangSeok Oh  <changseok@webkit.org>
3392
3393         [GTK] Cannot build GTK+ with CUPS 2.* versions
3394         https://bugs.webkit.org/show_bug.cgi?id=163591
3395
3396         Reviewed by Michael Catanzaro.
3397
3398         GTK+ build has failed on the system which CUPS 2.x is installed in. GTK+ 3.16.4
3399         does not assume to use the recent CUPS thus it fails to detect the CUPS in configuration.
3400         GTK+ upstream fixed this issue but it is not easy to apply the original patch to our
3401         old gtk+ since it requires not only bumping up glib accordingly and its consequence
3402         causes many printing test failures. So, I propose to fix the configuration issue by
3403         applying the change to the configure file directly. By doing this, we don't need to
3404         upgrade glib and worry about any test failures as a consequence of the upgraded glib.
3405
3406         * gtk/jhbuild.modules:
3407         * gtk/patches/gtk+-configure-fix-detecting-CUPS-2.x.patch: Added.
3408
3409 2016-12-07  Simon Fraser  <simon.fraser@apple.com>
3410
3411         Fix use of enum in a WK2 C SPI header.
3412         rdar://problem/28725583
3413
3414         Followup to correctly prefix the enum values.
3415
3416         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3417         (WTR::InjectedBundlePage::prepare):
3418
3419 2016-12-07  Simon Fraser  <simon.fraser@apple.com>
3420
3421         Fix use of enum in a WK2 C SPI header.
3422         rdar://problem/28725583
3423
3424         Reviewed by Dan Bernstein.
3425
3426         Use correct enum style for a C SPI header and fix the callers.
3427
3428         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3429         (WTR::InjectedBundlePage::prepare):
3430
3431 2016-12-07  Wenson Hsieh  <wenson_hsieh@apple.com>
3432
3433         Add a new project for recording and playing back editing commands in editable web content
3434         https://bugs.webkit.org/show_bug.cgi?id=165114
3435         <rdar://problem/29408135>
3436
3437         Reviewed by Beth Dakin.
3438
3439         Adds a new Xcode project containing work towards rewinding and playing back editing commands. This work is
3440         wrapped in an Xcode project to take advantage of the XCTest framework. To manually test recording, open the
3441         capture test harness, edit the contenteditable body, and then hit cmd-S. This downloads a .json file which may
3442         then be dragged into the playback test harness.
3443
3444         Also adds 3 new unit tests in EditingHistoryTests/RewindAndPlaybackTests.m. These tests carry out the following
3445         steps:
3446
3447         1. Load the capture harness and perform test-specific editing on the web view.
3448         2. Let originalState be a dump of the DOM at this point in time.
3449         3. Extract the JSON-serialized editing history data and load the playback harness with this data.
3450         4. Rewind all editing to the beginning.
3451         5. Playback all editing to the end.
3452         6. Dump the state of the DOM. This should be identical to originalState.
3453
3454         * EditingHistory/EditingHistory.xcodeproj/project.pbxproj: Added.
3455         * EditingHistory/EditingHistory/Info.plist: Added.
3456         * EditingHistory/EditingHistory/Resources/CaptureHarness.html: Added.
3457         * EditingHistory/EditingHistory/Resources/DOMTestingUtil.js: Added.
3458         * EditingHistory/EditingHistory/Resources/PlaybackHarness.html: Added.
3459         * EditingHistory/EditingHistory/TestRunner.h: Added.
3460         * EditingHistory/EditingHistory/TestRunner.m: Added.
3461         (injectedMessageEventHandlerScript):
3462         (-[TestRunner init]):
3463         (-[TestRunner deleteBackwards:]):
3464         (-[TestRunner typeString:]):
3465         (-[TestRunner bodyElementSubtree]):
3466         (-[TestRunner bodyTextContent]):
3467         (-[TestRunner editingHistoryJSON]):
3468         (-[TestRunner loadPlaybackTestHarnessWithJSON:]):
3469         (-[TestRunner numberOfUpdates]):
3470         (-[TestRunner jumpToUpdateIndex:]):
3471         (-[TestRunner expectEvents:afterPerforming:]):
3472         (-[TestRunner loadCaptureTestHarness]):
3473         (-[TestRunner setTextObfuscationEnabled:]):
3474         (-[TestRunner isDoneWaitingForPendingEvents]):
3475         (-[TestRunner userContentController:didReceiveScriptMessage:]):
3476
3477         The TestRunner provides utilities that a unit test should use to drive the test forward (e.g. loading harnesses)
3478         or inspect the state of the loaded page (e.g. extracting JSON editing history data from the capture harness).
3479
3480         * EditingHistory/EditingHistory/TestUtil.h: Added.
3481         * EditingHistory/EditingHistory/TestUtil.m: Added.
3482         (waitUntilWithTimeout):
3483         (waitUntil):
3484
3485         Provides utilities for running tests. For now, this is just spinning the runloop on a given condition.
3486
3487         * EditingHistory/EditingHistory/WKWebViewAdditions.h: Added.
3488         * EditingHistory/EditingHistory/WKWebViewAdditions.m: Added.
3489         (-[WKWebView loadPageFromBundleNamed:]):
3490         (-[WKWebView typeCharacter:]):
3491         (-[WKWebView keyPressWithCharacters:keyCode:]):
3492         (-[WKWebView stringByEvaluatingJavaScriptFromString:]):
3493
3494         Provides utilities for simulating interaction in a web view.
3495
3496         * EditingHistory/EditingHistory/main.m: Added.
3497         (main):
3498         * EditingHistory/EditingHistoryTests/Info.plist: Added.
3499         * EditingHistory/EditingHistoryTests/RewindAndPlaybackTests.m: Added.
3500         (-[RewindAndPlaybackTests setUp]):
3501         (-[RewindAndPlaybackTests tearDown]):
3502         (-[RewindAndPlaybackTests testTypingSingleLineOfText]):
3503         (-[RewindAndPlaybackTests testTypingMultipleLinesOfText]):
3504         (-[RewindAndPlaybackTests testTypingAndDeletingText]):
3505         (-[RewindAndPlaybackTests rewindAndPlaybackEditingInPlaybackTestHarness]):
3506         (-[RewindAndPlaybackTests originalBodySubtree:isEqualToFinalSubtree:]):
3507
3508 2016-12-07  Philippe Normand  <pnormand@igalia.com>
3509
3510         [GTK][jhbuild] missing dependency on libvpx in gst-plugins-good
3511         https://bugs.webkit.org/show_bug.cgi?id=165525
3512
3513         Reviewed by Carlos Garcia Campos.
3514
3515         * gtk/jhbuild.modules: gst-plugins-good should depend on the
3516         libvpx package built within jhbuild.
3517
3518 2016-12-07  Philippe Normand  <pnormand@igalia.com>
3519
3520         [GTK][jhbuild] gst-plugins-bad fails to build with OpenSSL 1.1.0
3521         https://bugs.webkit.org/show_bug.cgi?id=165520
3522
3523         Reviewed by Carlos Garcia Campos.
3524
3525         * gtk/jhbuild.modules: Added missing dependency on openh264 in
3526         gst-plugins-bad, along with 2 upstream patches fixing the build
3527         against OpenSSL 1.1.0.
3528         * gtk/patches/gst-plugins-bad-0001-dtls-port-to-OpenSSL-1.1.0.patch: Added.
3529         * gtk/patches/gst-plugins-bad-0002-dtlscertificate-Fix-error-checking-in-RSA_generate_k.patch: Added.
3530
3531 2016-12-06  Alexey Proskuryakov  <ap@apple.com>
3532
3533         Correct SDKROOT values in xcconfig files
3534         https://bugs.webkit.org/show_bug.cgi?id=165487
3535         rdar://problem/29539209
3536
3537         Reviewed by Dan Bernstein.
3538
3539         Fix suggested by Dan Bernstein.
3540
3541         * ContentExtensionTester/Configurations/DebugRelease.xcconfig:
3542         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
3543         * MiniBrowser/Configurations/DebugRelease.xcconfig:
3544         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
3545         * WebEditingTester/Configurations/DebugRelease.xcconfig:
3546         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
3547
3548 2016-12-06  Daniel Bates  <dabates@apple.com>
3549
3550         WebKitTestRunner: Plugins are disabled in new windows
3551         https://bugs.webkit.org/show_bug.cgi?id=165410
3552
3553         Reviewed by Alex Christensen.
3554
3555         Currently WebKitTestRunner only enables plugins in the main window. So, a test that opens
3556         a new window and loads a plugin will fail. We should enable plugins in all windows by
3557         default. Moreover toggling testRunner.setPluginsEnabled() should effect all windows.
3558
3559         Making these changes is a step towards running plugins/open-and-close-window-with-plugin.html
3560         in WebKitTestRunner (we still need to fix <https://bugs.webkit.org/show_bug.cgi?id=46714>) and
3561         will make the behavior of WebKitTestRunner more closely match the behavior DumpRenderTree.
3562
3563         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3564         (WTR::InjectedBundle::beginTesting): Call TestRunner::setPluginsEnabled() instead of
3565         WKBundleSetPluginsEnabled().
3566         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3567         (WTR::TestRunner::setPluginsEnabled): Take a similar approach as TestRunner::setXSSAuditorEnabled()
3568         and make use of WKBundleOverrideBoolPreferenceForTestRunner().
3569
3570 2016-12-05  Dean Jackson  <dino@apple.com>
3571
3572         pointer lock needs to be feature detectable
3573         https://bugs.webkit.org/show_bug.cgi?id=165426
3574         <rdar://problem/29486715>
3575
3576         Reviewed by Antoine Quint.
3577
3578         Expose the comment line to turn on/off pointer lock.
3579
3580         * DumpRenderTree/TestOptions.h:
3581         * DumpRenderTree/TestOptions.mm:
3582         (TestOptions::TestOptions):
3583         * DumpRenderTree/mac/DumpRenderTree.mm:
3584         (resetWebPreferencesToConsistentValues):
3585         * WebKitTestRunner/TestController.cpp:
3586         (WTR::TestController::resetPreferencesToConsistentValues):
3587         (WTR::updateTestOptionsFromTestHeader):
3588         * WebKitTestRunner/TestOptions.h:
3589         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3590         (WTR::PlatformWebView::viewSupportsOptions):
3591         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3592         (WTR::PlatformWebView::viewSupportsOptions):
3593
3594 2016-12-05  Jonathan Bedard  <jbedard@apple.com>
3595
3596         Make it possible to use an existing simulator instance for one-off testing
3597         https://bugs.webkit.org/show_bug.cgi?id=164568
3598         <rdar://problem/29189133>
3599
3600         Reviewed by Daniel Bates.
3601
3602         With this patch, if a simulator is currently running on the machine and
3603         '--dedicated-simulators' is not passed into the application, only one simulator
3604         instance will be used, and this instance will be the existing instance.
3605         If no simulator is running or '--dedicated-simulators' is passed to the script,
3606         previous behavior will be used.
3607
3608         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3609         (parse_args):
3610         * Scripts/webkitpy/port/ios.py:
3611         (IOSSimulatorPort.__init__): Logic for enabling usage of currently running simulator.
3612         (IOSSimulatorPort._create_simulators): Only create simulators when needed, don't reset already running simulators.
3613         (IOSSimulatorPort.setup_test_run): Don't open already running simulators.
3614         (IOSSimulatorPort._quit_ios_simulator): Only quit simulators if we manage them.
3615         (IOSSimulatorPort.clean_up_test_run): Only clean up simulators if we manage them. 
3616         (IOSSimulatorPort._using_dedicated_simulators): True if simulators need to be managed, false if using an existing instance.
3617         (IOSSimulatorPort.device_id_for_worker_number): Access currently running simulator if not managing devices.
3618         * Scripts/webkitpy/xcode/simulator.py:
3619         (Simulator.refresh): Check if xcode_simctl_list returned None instead of a generator.
3620         (Simulator.current_device): Get currently running device.
3621
3622 2016-12-05  Dan Bernstein  <mitz@apple.com>
3623
3624         Disable a crashing test on iOS.
3625
3626         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegate.mm:
3627
3628 2016-12-04  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3629
3630         Fix a build break on EFL since r209303.
3631
3632         Unreviewed build fix.
3633
3634         * Scripts/webkitperl/FeatureList.pm: Disable SS Device Adaptation temporarily.
3635
3636 2016-12-03  Yusuke Suzuki  <utatane.tea@gmail.com>
3637
3638         Refactor SymbolImpl layout
3639         https://bugs.webkit.org/show_bug.cgi?id=165247
3640
3641         Reviewed by Darin Adler.
3642
3643         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
3644         (TestWebKitAPI::TEST):
3645
3646 2016-12-03  Dan Bernstein  <mitz@apple.com>
3647
3648         Fixed the build after r209307.
3649
3650         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegate.mm:
3651         (TEST):
3652
3653 2016-12-03  Dan Bernstein  <mitz@apple.com>
3654
3655         [Cocoa] Expose InjectedBundlePageEditorClient via the Objective-C bundle SPI
3656         https://bugs.webkit.org/show_bug.cgi?id=165276
3657         <rdar://problem/29467040>
3658
3659         Reviewed by Darin Adler.
3660
3661         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3662         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegate.mm: Added.
3663         (-[BundleEditingDelegateRemoteObject willWriteToPasteboard:]):
3664         (-[BundleEditingDelegateRemoteObject didWriteToPasteboard]):
3665         (TEST):
3666         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegatePlugIn.mm: Added.
3667         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
3668         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:willWriteRangeToPasteboard:]):
3669         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:pasteboardDataForRange:]):
3670         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextControllerDidWriteToPasteboard:]):
3671         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegateProtocol.h: Added.
3672
3673 2016-12-02  Andy Estes  <aestes@apple.com>
3674
3675         [Cocoa] Adopt the PRODUCT_BUNDLE_IDENTIFIER build setting
3676         https://bugs.webkit.org/show_bug.cgi?id=164492
3677
3678         Reviewed by Dan Bernstein.
3679
3680         * DumpRenderTree/TestNetscapePlugIn/mac/Info.plist: Changed CFBundleIdentifier's value from
3681         com.apple.testnetscapeplugin to ${PRODUCT_BUNDLE_IDENTIFIER}.
3682         * DumpRenderTree/ios/Info.plist: Changed CFBundleIdentifier's value from
3683         org.webkit.DumpRenderTree to ${PRODUCT_BUNDLE_IDENTIFIER}.
3684         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig: Set
3685         PRODUCT_BUNDLE_IDENTIFIER to org.webkit.DumpRenderTree.
3686         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig: Set
3687         PRODUCT_BUNDLE_IDENTIFIER to com.apple.testnetscapeplugin.
3688         * MiniBrowser/Configurations/MiniBrowser.xcconfig: Set PRODUCT_BUNDLE_IDENTIFIER to
3689         org.webkit.$(PRODUCT_NAME:rfc1034identifier).
3690         * MiniBrowser/Configurations/MiniBrowserBundle.xcconfig: Set PRODUCT_BUNDLE_IDENTIFIER to
3691         com.apple.$(PRODUCT_NAME:rfc1034identifier).
3692         * MiniBrowser/mac/Bundle/Info.plist: Changed CFBundleIdentifier's value from
3693         com.apple.${PRODUCT_NAME:rfc1034identifier} to ${PRODUCT_BUNDLE_IDENTIFIER}.
3694         * MiniBrowser/mac/Info.plist: Changed CFBundleIdentifier's value from
3695         org.webkit.${PRODUCT_NAME} to ${PRODUCT_BUNDLE_IDENTIFIER}.
3696         * TestWebKitAPI/Configurations/InjectedBundle.xcconfig: Set INFOPLIST_FILE to
3697         InjectedBundle-Info.plist and set PRODUCT_BUNDLE_IDENTIFIER to
3698         com.apple.$(PRODUCT_NAME:rfc1034identifier).
3699         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Set PRODUCT_BUNDLE_IDENTIFIER to
3700         com.apple.$(PRODUCT_NAME:rfc1034identifier).
3701         * TestWebKitAPI/InjectedBundle-Info.plist: Changed CFBundleIdentifier's value from
3702         com.yourcompany.${PRODUCT_NAME:rfc1034identifier} to ${PRODUCT_BUNDLE_IDENTIFIER}.
3703         * TestWebKitAPI/cocoa/WebProcessPlugIn/Info.plist: Added a CFBundleIdentifier key with the
3704         value ${PRODUCT_BUNDLE_IDENTIFIER}.
3705         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig: Set INFOPLIST_FILE to
3706         InjectedBundle-Info.plist and set PRODUCT_BUNDLE_IDENTIFIER to
3707         com.apple.WebKitTestRunner.InjectedBundle.
3708         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig: Set
3709         PRODUCT_BUNDLE_IDENTIFIER to org.webkit.$(PRODUCT_NAME:rfc1034identifier).
3710         * WebKitTestRunner/InjectedBundle-Info.plist: Changed CFBundleIdentifier's value from
3711         com.apple.WebKitTestRunner.InjectedBundle to ${PRODUCT_BUNDLE_IDENTIFIER}.
3712         * WebKitTestRunner/WebKitTestRunnerApp/WebKitTestRunnerApp-Info.plist: Changed
3713         CFBundleIdentifier's value from org.webkit.${PRODUCT_NAME:rfc1034identifier} to
3714         ${PRODUCT_BUNDLE_IDENTIFIER}.
3715
3716 2016-12-02  Brady Eidson  <beidson@apple.com>
3717
3718         Make IndexedDB.WebProcessKillIDBCleanup even more reliable.
3719         https://bugs.webkit.org/show_bug.cgi?id=165330
3720
3721         Reviewed by Alex Christensen.
3722
3723         The test currently nulls out a RetainPtr<WKWebView> to try to destroy the view and kill the process.
3724
3725         Problem is that doesn't reliably destroy the view.
3726         We should explicitly kill the process instead.
3727
3728         Also, by relocating when we kill the process, we can better test behavior of the IndexedDB mechanism.
3729         e.g. We explicitly confirm that a second WebProcess can simultaneously attach to the same unique database as the first.
3730
3731         * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup.mm:
3732         (TEST):
3733
3734 2016-12-02  Commit Queue  <commit-queue@webkit.org>
3735
3736         Unreviewed, rolling out r209136.