80133e0b923f1d58586941d437e5ba4ea510d5ff
[WebKit.git] / Tools / ChangeLog
1 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2
3         Reviewed by Tony Chang.
4
5         Change more modules in the layout-tests code to use the
6         filesystem wrapper for cleaner unit testing.
7
8         This patch also adds the glob() wrapper to the filesystem
9         abstraction.
10         
11         https://bugs.webkit.org/show_bug.cgi?id=52604
12
13         * Scripts/webkitpy/layout_tests/port/test_files.py:
14         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
15         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
16         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
17         * Scripts/webkitpy/common/system/filesystem.py:
18         * Scripts/webkitpy/common/system/filesystem_mock.py:
19
20 2011-01-19  Levi Weintraub  <leviw@chromium.org>
21
22         Unreviewed.
23
24         Updating my email addresses and irc nick.
25
26         * Scripts/webkitpy/common/config/committers.py:
27
28 2011-01-19  Tony Chang  <tony@chromium.org>
29
30         Reviewed by Mihai Parparita.
31
32         [chromium] [linux] if check-sys-deps fails, output the failure reason
33         https://bugs.webkit.org/show_bug.cgi?id=52671
34
35         * Scripts/webkitpy/common/system/executive_mock.py: Add support for
36             error handler functions.
37         * Scripts/webkitpy/layout_tests/port/chromium.py:
38             output the error text from --check-sys-deps
39         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
40
41 2011-01-19  Aparna Nandyal  <aparna.nand@wipro.com>
42
43         Reviewed by Andreas Kling.
44
45         [Qt] QtTestBrowser crashes when closing if Facebook is opened
46         https://bugs.webkit.org/show_bug.cgi?id=52554
47         
48         QtNetworkAccessManager is created in a thread and set as
49         member variable in QWebPage. When the thread is destroyed
50         the object is still used. So fix will set the object to
51         NULL once the thread is destroyed.
52
53         * QtTestBrowser/launcherwindow.cpp:
54         (LauncherWindow::~LauncherWindow):
55
56 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
57
58         Rubber stamped by Csaba Osztrogonac
59
60         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: Removed unncessary inculde of WKStringCF.h
61
62 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
63
64         Reviewed by Tony Chang.
65
66         new-run-webkit-tests: add a --build-directory command line argument
67
68         Official Google Chrome builds use a non-standard build directory
69         location. This patch adds a --build-directory argument that
70         allows that location to be specified on the command line. Only
71         Chromium-based builds will use this flag for now, but anyone can
72         in the future.
73
74         There are no unit tests for this since it's difficult to test
75         until mock filesystems are fully supported in the code. This was
76         tested by hand for now.
77
78         https://bugs.webkit.org/show_bug.cgi?id=52694
79
80         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
81         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
82         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
83         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
84
85 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
86
87         Not reviewed. Bot fix.
88
89         Remove an inadvertently committed debugging print.
90
91         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
92         (LayoutTestController::notifyDone):
93
94 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
95
96         Reviewed by Sam Weinig.
97
98         WebKitTestRunner should track loading more like DumpRenderTree
99         https://bugs.webkit.org/show_bug.cgi?id=52692
100
101         Change load tracking to track the current top loading frame, in the manner of DumpRenderTree.
102         This makes some tests that call notifyDone multiple times pass.
103         
104         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
105         (WTR::InjectedBundle::InjectedBundle):
106         (WTR::InjectedBundle::done):
107         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
108         (WTR::InjectedBundle::topLoadingFrame):
109         (WTR::InjectedBundle::setTopLoadingFrame):
110         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
111         (WTR::InjectedBundlePage::InjectedBundlePage):
112         (WTR::InjectedBundlePage::stopLoading):
113         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
114         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
115         (WTR::InjectedBundlePage::didFinishLoadForFrame):
116         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
117         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
118         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
119         (WTR::LayoutTestController::notifyDone):
120         * WebKitTestRunner/TestController.cpp:
121         (WTR::TestController::didReceiveMessageFromInjectedBundle):
122
123 2011-01-18  Mihai Parparita  <mihaip@chromium.org>
124
125         Reviewed by Kent Tamura.
126
127         [Chromium] NRWT looking for DRT binary in the wrong path on Mac
128         https://bugs.webkit.org/show_bug.cgi?id=52678
129         
130         Update path now that WebKit is inside Source.
131
132         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
133
134 2011-01-18  Robert Hogan  <robert@webkit.org>
135
136         Reviewed by Simon Hausmann.
137
138         [Qt] http/tests/incremental/slow-utf8-text.pl fails
139         https://bugs.webkit.org/show_bug.cgi?id=44282
140
141         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
142         (WebCore::DumpRenderTree::dump):
143
144 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
145
146         Reviewed by Mihai Parparita.
147
148         Fix a small race condition that could cause the unit tests for
149         new-run-webkit-tests to fail in a multithreaded environment.
150         There was a small window in the code where one thread would
151         check to see if a thread had raised an exception, do something,
152         and then check to see if the thread was alive. If the other
153         thread raised an exception and exited in between these two
154         steps, the exception would be lost. Flipping the order of the
155         two checks fixes the race, since we will now always check for an
156         exception on the thread before exiting.
157
158         https://bugs.webkit.org/show_bug.cgi?id=51579
159
160         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
161
162 2011-01-18  Eric Seidel  <eric@webkit.org>
163
164         Reviewed by Adam Barth.
165
166         commit-queue dies when test archiving fails
167         https://bugs.webkit.org/show_bug.cgi?id=52617
168
169         I looked at the machine and it had 10 archives already
170         thus find_unused_name was returning None.  I've upped
171         the limit to 100 (per bug) and tested the case where
172         find_unused_name returns None (making archive return None).
173
174         * Scripts/webkitpy/common/system/workspace.py:
175         * Scripts/webkitpy/common/system/workspace_unittest.py:
176         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
177         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
178         * Scripts/webkitpy/tool/commands/queues.py:
179
180 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
181
182         Reviewed by Ojan Vafai.
183
184         Update rebaseline-chromium-webkit-tests unit tests to use a mock
185         filesystem. Also fix a couple of "with" statements missed by
186         r76050.
187
188         https://bugs.webkit.org/show_bug.cgi?id=52487
189
190         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
191
192 2011-01-18  Sergio Villar Senin  <svillar@igalia.com>
193
194         Reviewed by Martin Robinson.
195
196         [Gtk] Build fixes for gtk3 build
197         https://bugs.webkit.org/show_bug.cgi?id=52648
198
199         * DumpRenderTree/gtk/EventSender.cpp:
200         (beginDragWithFilesCallback):
201
202 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
203
204         Reviewed by Mihai Parparita.
205
206         Update rebaseline-chromium-webkit-tests to use filesystem objects
207         instead of direct references to os.path, shutil, tempfile, etc.
208
209         This patch doesn't change anything, but will allow subsequent
210         patches to change the unit tests to no longer use the real
211         filesystem.
212
213         This patch adds a bunch more methods to the filesystem object as
214         well.
215
216         https://bugs.webkit.org/show_bug.cgi?id=52482
217
218         * Scripts/webkitpy/common/system/filesystem.py:
219         * Scripts/webkitpy/common/system/filesystem_mock.py:
220         * Scripts/webkitpy/tool/commands/queues.py:
221         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
222         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
223
224 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
225
226         Reviewed by Mihai Parparita.
227
228         new-run-webkit-tests shouldn't crash when you try to run a
229         directory containing only skipped files.
230
231         https://bugs.webkit.org/show_bug.cgi?id=52478
232         
233         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
234         * Scripts/webkitpy/layout_tests/port/test.py:
235         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
236
237 2011-01-18  Adam Bergkvist  <adam.bergkvist@ericsson.com> and Martin Robinson  <mrobinson@igalia.com>
238
239         Reviewed by Gustavo Noronha Silva.
240
241         [GTK] The GTK+ EventSender needs support for beginDragWithFiles
242         https://bugs.webkit.org/show_bug.cgi?id=40833
243
244         * DumpRenderTree/gtk/EventSender.cpp: Add a beginDragWithFiles implementation for the
245         GTK+ event sender.
246         (dragWithFilesDragDataGetCallback): Added.
247         (dragWithFilesDragEndCallback): Added.
248         (beginDragWithFilesCallback): Added.
249
250 2011-01-18  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
251
252         Reviewed by Adam Barth.
253
254         ews: Add additional watcher to efl ews
255         https://bugs.webkit.org/show_bug.cgi?id=52613
256
257         Add gyuyoung.kim@samsung.com to watcher list of efl-ews.
258
259         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
260
261 2011-01-17  Tony Gentilcore  <tonyg@chromium.org>
262
263         Reviewed by Alexey Proskuryakov.
264
265         Fix some headers with missing or misspelled #ifndef guards
266         https://bugs.webkit.org/show_bug.cgi?id=52545
267
268         * DumpRenderTree/chromium/TestEventPrinter.h:
269         * DumpRenderTree/chromium/WebPreferences.h:
270
271 2011-01-17  Jessie Berlin  <jberlin@apple.com>
272
273         Reviewed by Anders Carlsson.
274
275         REGRESSION: Assertion failure in FrameLoader::continueLoadAfterWillSubmitForm() when
276         navigating back to an unreachable URL
277         https://bugs.webkit.org/show_bug.cgi?id=52388
278
279         Add a third parameter (unreachableURL) to queueLoadHTMLString.
280
281         * DumpRenderTree/LayoutTestController.cpp:
282         (queueLoadHTMLStringCallback):
283         (LayoutTestController::queueLoadHTMLString):
284         (LayoutTestController::queueLoadAlternateHTMLString):
285         * DumpRenderTree/LayoutTestController.h:
286
287         * DumpRenderTree/WorkQueueItem.h:
288         (LoadHTMLStringItem::LoadHTMLStringItem):
289
290         * DumpRenderTree/chromium/LayoutTestController.cpp:
291         (WorkItemLoadHTMLString::WorkItemLoadHTMLString):
292         (WorkItemLoadHTMLString::run):
293         (LayoutTestController::queueLoadHTMLString):
294
295         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
296         (LoadHTMLStringItem::invoke):
297         * DumpRenderTree/mac/WorkQueueItemMac.mm:
298         (LoadHTMLStringItem::invoke):
299         * DumpRenderTree/win/WorkQueueItemWin.cpp:
300         (LoadHTMLStringItem::invoke):
301
302 2011-01-17  Dan Bernstein  <mitz@apple.com>
303
304         Rubber-stamped by Mark Rowe.
305
306         Update xcodeproj svn:ignore to include xcuserdata.
307
308         * DumpRenderTree/DumpRenderTree.xcodeproj: Modified property svn:ignore.
309         * MiniBrowser/MiniBrowser.xcodeproj: Modified property svn:ignore.
310         * TestWebKitAPI/TestWebKitAPI.xcodeproj: Modified property svn:ignore.
311         * WebKitLauncher/WebKitLauncher.xcodeproj: Modified property svn:ignore.
312         * WebKitTestRunner/WebKitTestRunner.xcodeproj: Modified property svn:ignore.
313
314 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
315
316         Unreviewed fix after r75908.
317
318         Move WebKit into Source
319         https://bugs.webkit.org/show_bug.cgi?id=52530
320
321         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add Source to the path for Qt API tests.
322
323 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
324
325         Unreviewed.
326
327         Remove accidentally committed debug printing after r75908.
328
329         * Scripts/webkitdirs.pm:
330
331 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
332
333         Unreviewed.
334
335         Add myself to committers list
336         https://bugs.webkit.org/show_bug.cgi?id=52566
337
338         * Scripts/webkitpy/common/config/committers.py:
339
340 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
341
342         Reviewed by Jeremy Orlow.
343
344         GeolocationController should call stopUpdating on destruction
345         https://bugs.webkit.org/show_bug.cgi?id=52216
346
347         fast/dom/Geolocation/window-close-crash.html requires that a
348         Geolocation watch be started in a secondary window. Consequently,
349         we need to allow geolocation permission and provide a mock
350         geolocation position for the secondary window's
351         GeolocationClientMock.
352
353         * DumpRenderTree/chromium/LayoutTestController.cpp:
354         (LayoutTestController::setGeolocationPermission):
355         (LayoutTestController::setMockGeolocationPosition):
356         (LayoutTestController::setMockGeolocationError):
357         * DumpRenderTree/chromium/TestShell.h:
358         (TestShell::windowList):
359
360 2011-01-16  Adam Barth  <abarth@webkit.org>
361
362         Update more include paths to reflect WebKit move.
363
364         * DumpRenderTree/chromium/EventSender.cpp:
365         (EventSender::keyDown):
366         (EventSender::needsShiftModifier):
367         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
368         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
369
370 2011-01-16  Kent Tamura  <tkent@chromium.org>
371
372         Unreviewed, Chromium build fix.
373
374         * Scripts/update-webkit-chromium: Webkit/chromium -> Source/WebKit/chromium
375
376 2011-01-16  Martin Robinson  <mrobinson@igalia.com>
377
378         Build fix for GTK+ after source directory movement.
379
380         * GNUmakefile.am: Correct include paths.
381
382 2011-01-16  Adam Barth  <abarth@webkit.org>
383
384         Teach svn-apply about WebKit move.
385
386         * Scripts/VCSUtils.pm:
387
388 2011-01-16  Adam Barth  <abarth@webkit.org>
389
390         Rubber-stamped by Eric Seidel.
391
392         Move WebKit into Source
393         https://bugs.webkit.org/show_bug.cgi?id=52530
394
395         * DumpRenderTree/mac/InternalHeaders/WebKit/WebTypesInternal.h:
396         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
397         * DumpRenderTree/qt/DumpRenderTreeQt.h:
398         * DumpRenderTree/qt/GCControllerQt.cpp:
399         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
400         * DumpRenderTree/qt/PlainTextControllerQt.cpp:
401         * DumpRenderTree/qt/TextInputControllerQt.cpp:
402         * DumpRenderTree/wscript:
403         * QtTestBrowser/launcherwindow.h:
404         * Scripts/build-webkit:
405         * Scripts/webkitdirs.pm:
406
407 2011-01-15  Adam Barth  <abarth@webkit.org>
408
409         Teach svn-apply about WebKit2 move.
410
411         * Scripts/VCSUtils.pm:
412
413 2011-01-15  Adam Barth  <abarth@webkit.org>
414
415         Rubber-stamped by Eric Seidel.
416
417         Move WebKit2 into Source
418         https://bugs.webkit.org/show_bug.cgi?id=52438
419
420         * MiniBrowser/qt/MiniBrowser.pro:
421         * Scripts/build-webkit:
422         * Scripts/do-file-rename:
423         * Scripts/do-webcore-rename:
424         * Scripts/test-webkitpy:
425         * Scripts/webkitdirs.pm:
426         * Scripts/webkitpy/style/checker.py:
427         * WebKitTestRunner/DerivedSources.pro:
428         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
429         * WebKitTestRunner/qt/WebKitTestRunner.pro:
430
431 2011-01-15  Jochen Eisinger  <jochen@chromium.org>
432
433         Reviewed by David Levin.
434
435         [chromium] remove obsolete createView method
436         https://bugs.webkit.org/show_bug.cgi?id=52437
437
438         * DumpRenderTree/chromium/WebViewHost.cpp:
439         (WebViewHost::createView):
440         * DumpRenderTree/chromium/WebViewHost.h:
441
442 2011-01-14  Brian Weinstein  <bweinstein@apple.com>
443
444         Reviewed by Geoff Garen.
445
446         ShouldLoadResourceForFrame should use strings, not URLs.
447         https://bugs.webkit.org/show_bug.cgi?id=52476
448
449         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
450         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Update to use a WKStringRef.
451         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
452
453 2011-01-14  Tony Gentilcore  <tonyg@chromium.org>
454
455         Reviewed by David Levin.
456
457         Add Tony Gentilcore as a reviewer
458         https://bugs.webkit.org/show_bug.cgi?id=52480
459
460         * Scripts/webkitpy/common/config/committers.py:
461
462 2011-01-14  David Levin  <levin@chromium.org>
463
464         Reviewed by Eric Seidel.
465
466         check-webkit-style: _FunctionState should keep track of where the function name starts.
467         https://bugs.webkit.org/show_bug.cgi?id=52454
468
469         * Scripts/webkitpy/style/checkers/cpp.py: Added function_name_start_position to
470         _FunctionState and logic for setting it correctly.
471         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests.
472
473 2011-01-14  Vincent Scheib  <scheib@chromium.org>
474
475         Reviewed by David Levin.
476
477         Add support to DumpRenderTree to use the GPU rather than software renderer
478         https://bugs.webkit.org/show_bug.cgi?id=52333
479
480         * DumpRenderTree/chromium/DumpRenderTree.cpp:
481         (main):
482         * Scripts/webkitpy/layout_tests/port/chromium.py:
483         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
484
485 2011-01-14  Tony Chang  <tony@chromium.org>
486
487         Reviewed by Kent Tamura.
488
489         [chromium] update fonts.conf to fix 6 linux tests in drt
490         https://bugs.webkit.org/show_bug.cgi?id=52411
491
492         * DumpRenderTree/chromium/fonts.conf: Update to match the copy in
493             chromium's src/webkit/tools/test_shell/resources/fonts.conf
494
495 2011-01-14  Eric Seidel  <eric@webkit.org>
496
497         Original patch from Peter Gal  <galpater@inf.u-szeged.hu>
498
499         Reviewed by Adam Barth.
500
501         Fix when running Tools/Scripts/check-webkit-style without arguments.
502         https://bugs.webkit.org/show_bug.cgi?id=52261#c16
503
504         * Scripts/webkitpy/common/checkout/scm.py: Handle None for changed_files argument better in Git.create_patch method.
505         * Scripts/webkitpy/common/checkout/scm_unittest.py:
506
507 2011-01-04  Jochen Eisinger  <jochen@chromium.org>
508
509         Reviewed by David Levin.
510
511         Store the tempdir object in a variable so it doesn't get deleted too early.
512         https://bugs.webkit.org/show_bug.cgi?id=51875
513
514         * Scripts/update-webkit-auxiliary-libs:
515         * Scripts/update-webkit-support-libs:
516
517 2011-01-14  Eric Seidel  <eric@webkit.org>
518
519         Unreviewed.  Make it work in python 2.5.
520
521         webkit-patch suggest-reviewers dies when ChangeLogs are missing
522         https://bugs.webkit.org/show_bug.cgi?id=49158
523
524         * Scripts/webkitpy/common/checkout/api_unittest.py:
525
526 2011-01-14  Sheriff Bot  <webkit.review.bot@gmail.com>
527
528         Unreviewed, rolling out r75774.
529         http://trac.webkit.org/changeset/75774
530         https://bugs.webkit.org/show_bug.cgi?id=52431
531
532         gtk builds were broken (Requested by loislo2 on #webkit).
533
534         * Scripts/webkitpy/common/checkout/scm.py:
535
536 2011-01-14  David Levin  <levin@chromium.org>
537
538         Reviewed by Shinichiro Hamaji.
539
540         check-webkit-style: _FunctionState should detect pure functions.
541         https://bugs.webkit.org/show_bug.cgi?id=52428
542
543         * Scripts/webkitpy/style/checkers/cpp.py: Added detection for if a function declaration
544         is a pure virtual function.
545         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests for verifying that pure
546         virtual functions are correctly detected.
547
548 2011-01-13  Ilya Tikhonovsky  <loislo@chromium.org>
549
550         Reviewed by Yury Semikhatsky.
551
552         Just small fix for problem with check-webkit-style.
553         It just didn't work for this patch.
554         Old code can't concatenate a list of strings with None.
555
556         * Scripts/webkitpy/common/checkout/scm.py:
557
558 2011-01-13  David Levin  <levin@chromium.org>
559
560         Reviewed by Shinichiro Hamaji.
561
562         check-webkit-style: _FunctionState should use Position to know where items are.
563         https://bugs.webkit.org/show_bug.cgi?id=52424
564
565         * Scripts/webkitpy/style/checkers/cpp.py:
566         (_FunctionState.*): Changed _FunctionState to use Position instead of line numbers.
567         (detect_functions): Changed to pass Position's to _FunctionState.begin and
568         did some minor clean-up.
569         (*): Other changes are simply about converting to use the Position's in_FunctionState
570         instead of line numbers.
571         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Changed the test code
572         to verify the positions stored in _FunctionState.
573
574 2011-01-13  Eric Seidel  <eric@webkit.org>
575
576         Reviewed by David Levin.
577
578         webkit-patch suggest-reviewers dies when ChangeLogs are missing
579         https://bugs.webkit.org/show_bug.cgi?id=49158
580
581         This is not the most elegant, but it is a very safe fix to this bug.
582         One advantage of catching ScriptError like this instead of adding a
583         new added_or_modified_files or fixing all changed_files callers
584         to use a more specific change_files variant, is that we catch
585         all kinds of ScriptErrors which might cause our (non-essential)
586         suggest-reviewers code to fail out.  This should make passing
587         --suggest-reviewers to webkit-patch upload much more robust
588         and may even make it possible for us to make it default.
589
590         The root of the problem here is that SCM.changed_files includes
591         deleted ChangeLog paths (from moves, etc) which then when we ask
592         SVN/Git for the contents of the file at that revision, the command
593         errors out and Executive.run_command raises a ScriptError.
594
595         In the future we might fix this differently by making all current
596         callers of chagned_files use a more specific method for requesting
597         what types of changes they're interested in (adds, modifies, deletes, etc.)
598
599         * Scripts/webkitpy/common/checkout/api.py:
600         * Scripts/webkitpy/common/checkout/api_unittest.py:
601
602 2011-01-13  Dan Bernstein  <mitz@apple.com>
603
604         Reviewed by Alexey Proskuryakov.
605
606         <rdar://problem/8827065> REGRESSION (r71884): Cross-origin XHR fails if willSendRequest changes the URL
607         https://bugs.webkit.org/show_bug.cgi?id=52419
608
609         Allow to further control the behavior of the willSendRequest delegate callback by making it
610         set a different URL in the new request.
611
612         * DumpRenderTree/LayoutTestController.cpp:
613         (addURLToRedirectCallback): Added.
614         (LayoutTestController::staticFunctions): Added addURLToRedirect.
615         (LayoutTestController::addURLToRedirect): Added. Adds the redirection to the map.
616         (LayoutTestController::redirectionDestinationForURL): Added this getter.
617         * DumpRenderTree/LayoutTestController.h:
618         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
619         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]): Check
620         if there is a redirection for the request’s URL, established by addURLToRedirect(), and if so,
621         change the URL in the new request to the redirect destination.
622
623 2011-01-13  Eric Seidel  <eric@webkit.org>
624
625         Reviewed by Mihai Parparita.
626
627         webkit-patch suggest-reviewers fails due to invalid utf8 in ChangeLog files
628         https://bugs.webkit.org/show_bug.cgi?id=52416
629
630         Example: webkit-patch suggest-reviewers -g ca3890fe74d94d85d6bfa48f9ea497b094d8e717 
631         UnicodeDecodeError: 'utf8' codec can't decode bytes in position 536-538: invalid data
632
633         I also added FIXMEs about the changed_files returning deleted files problem
634         which is causing the other most common exception for suggest-reviewers
635         (and is probably breaking sheriff-bots blame detection).
636
637         * Scripts/webkitpy/common/checkout/api.py:
638         * Scripts/webkitpy/common/checkout/api_unittest.py:
639         * Scripts/webkitpy/common/checkout/scm.py:
640
641 2011-01-13  Eric Seidel  <eric@webkit.org>
642
643         Reviewed by Adam Barth.
644
645         results archives from commit-queue are too large to upload
646         https://bugs.webkit.org/show_bug.cgi?id=52405
647
648         * Scripts/webkitpy/common/system/filesystem.py:
649         * Scripts/webkitpy/common/system/filesystem_mock.py:
650         * Scripts/webkitpy/tool/commands/queues.py:
651
652 2011-01-13  Alejandro G. Castro  <alex@igalia.com>
653
654         Reviewed by Martin Robinson.
655
656         [gtk] Zero-sized font does not yet work
657         https://bugs.webkit.org/show_bug.cgi?id=49793
658
659         Set minimum-font-size to 0 for the DRT.
660
661         * DumpRenderTree/gtk/DumpRenderTree.cpp:
662         (resetDefaultsToConsistentValues):
663
664 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
665
666         Reviewed by Darin Adler.
667
668         Make old-run-webkit-tests more robust on buildbots
669         https://bugs.webkit.org/show_bug.cgi?id=52364
670
671         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Pass --exit-after-n-failures 500 to old-run-webkit-tests script.
672
673 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
674
675         Reviewed by Darin Adler.
676
677         Make old-run-webkit-tests more robust on buildbots
678         https://bugs.webkit.org/show_bug.cgi?id=52364
679
680         * Scripts/old-run-webkit-tests: Ensure that testResultsDirectory is empty.
681
682 2011-01-13  Tony Chang  <tony@chromium.org>
683
684         Reviewed by Kent Tamura.
685
686         [chromium] fix plugins/plugin-javascript-access.html on Linux and Mac
687         https://bugs.webkit.org/show_bug.cgi?id=52332
688
689         Forked Info.plist is not longer needed.
690
691         * DumpRenderTree/chromium/TestNetscapePlugIn/Info.plist: Removed.
692
693 2011-01-13  Mikhail Naganov  <mnaganov@chromium.org>
694
695         Reviewed by Timothy Hatcher.
696
697         Web Inspector: Cleanup after r75613 -- make all UI-facing strings
698         to be passed directly to WebInspector.UIString
699
700         https://bugs.webkit.org/show_bug.cgi?id=52365
701
702         * Scripts/check-inspector-strings:
703
704 2011-01-13  Sheriff Bot  <webkit.review.bot@gmail.com>
705
706         Unreviewed, rolling out r74881.
707         http://trac.webkit.org/changeset/74881
708         https://bugs.webkit.org/show_bug.cgi?id=52357
709
710         The EFL builder has been red for days (Requested by abarth on
711         #webkit).
712
713         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
714         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
715
716 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
717
718         Reviewed by David Levin.
719
720         Add beforeunload support to WebKitTestRunner
721         https://bugs.webkit.org/show_bug.cgi?id=52353
722         
723         This makes a number of currently failing tests pass.
724
725         * WebKitTestRunner/TestController.cpp:
726         (WTR::runBeforeUnloadConfirmPanel):
727         (WTR::createOtherPage):
728         (WTR::TestController::initialize):
729
730 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
731
732         Reviewed by Sam Weinig.
733
734         Detect, identify and recover from WebProcess crashes in run-webkit-tests
735         https://bugs.webkit.org/show_bug.cgi?id=52330
736
737         * Scripts/old-run-webkit-tests: Detect when the regression test tool reports
738         a web process crash.
739         * WebKitTestRunner/TestController.cpp:
740         (WTR::TestController::initialize): Set up a processDidCrash
741         callback.
742         (WTR::TestController::processDidCrash): Report that the Web process
743         crashed.
744         * WebKitTestRunner/TestController.h:
745
746 2011-01-12  David Levin  <levin@chromium.org>
747
748         Reviewed by Shinichiro Hamaji.
749
750         check-webkit-style -- close_expression function doesn't work correctly.
751         https://bugs.webkit.org/show_bug.cgi?id=52272
752
753         * Scripts/webkitpy/style/checkers/cpp.py:
754         (Position.__str__): Added a way to convert it to a string which is useful in tests.
755         (Position.__cmp__): Added a way to compare Position which is useful in tests and
756         generally useful (for upcoming code changes).
757         (close_expression): Changed to use Position for input and output.
758         Also, fixed many bugs such as only working correctly for parenthesis,
759         not working correctly if given an offset in a line and not finding
760         the real closing element if there were multiple closing elements in
761         the same line.
762         (detect_functions): Adjusted due to the change in arguments for
763         close_expression.
764         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
765         (CppStyleTestBase.assert_positions_equal): Added a way to verify that
766         two positions are the same.
767         (CppStyleTest.test_position): Added tests for the __str_ and __cmp__ methods.
768         (CppStyleTest.test_close_expression): Added tests to catch the issues
769         that were fixed.
770
771 2011-01-12  Sheriff Bot  <webkit.review.bot@gmail.com>
772
773         Unreviewed, rolling out r75576.
774         http://trac.webkit.org/changeset/75576
775         https://bugs.webkit.org/show_bug.cgi?id=52304
776
777         broke rebaseline-chromium-webkit-test (Requested by thakis on
778         #webkit).
779
780         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
781         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
782         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
783         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
784         * Scripts/webkitpy/layout_tests/port/base.py:
785         * Scripts/webkitpy/layout_tests/port/chromium.py:
786         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
787         * Scripts/webkitpy/layout_tests/port/test.py:
788         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
789         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
790         * Scripts/webkitpy/style/checkers/test_expectations.py:
791         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
792
793 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
794
795         Reviewed by Darin Adler.
796
797         Add a no-build option to run-webkit-tests, to avoid building DRT/WKTR
798         https://bugs.webkit.org/show_bug.cgi?id=52307
799
800         * Scripts/old-run-webkit-tests:
801
802 2011-01-12  Koan-Sin Tan  <koansin.tan@gmail.com>
803
804         Reviewed by Martin Robinson.
805
806         [Gtk] WebKitGtk+ doesn't build on Mac OS X 10.6
807         https://bugs.webkit.org/show_bug.cgi?id=50867
808
809         Fixed library extention for Mac in webkitdirs.pm and type conflict in
810         TestNetscapePlugin.cpp 
811
812         * GNUmakefile.am: Don't use AppKit when compiling TestNetscapePlugin for GTK+
813         * Scripts/webkitdirs.pm:
814
815 2011-01-12  Mikhail Naganov  <mnaganov@chromium.org>
816
817         Reviewed by Pavel Feldman.
818
819         Add check-inspector-strings script.
820
821         https://bugs.webkit.org/show_bug.cgi?id=52295
822
823         * Scripts/check-inspector-strings: Added.
824
825 2011-01-12  Adam Roben  <aroben@apple.com>
826
827         Advertise the .testnetscape file extension on Windows
828
829         Fixes <http://webkit.org/b/52298>
830         plugins/no-mime-with-valid-extension.html fails on Windows
831
832         Reviewed by Dan Bernstein.
833
834         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Added a
835         FileExtents field to map the .testnetscape file extension to the
836         application/x-webkit-test-netscape MIME type, just as we do on Mac.
837
838 2011-01-12  Adam Barth  <abarth@webkit.org>
839
840         Reviewed by Eric Seidel.
841
842         Make webkit-patch support subdirectories for SVN checkouts
843         https://bugs.webkit.org/show_bug.cgi?id=52261
844
845         os.relpath does not exist on Python 2.5, so we need to call our version
846         of the API.
847
848         * Scripts/webkitpy/common/checkout/scm.py:
849
850 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
851
852         Reviewed by Eric Seidel.
853
854         Close additional pages opened during a test once the test completes.
855         https://bugs.webkit.org/show_bug.cgi?id=52276
856
857         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
858         (WTR::InjectedBundle::done):
859
860 2011-01-11  David Levin  <levin@chromium.org>
861
862         Reviewed by Eric Seidel.
863
864         Errors should be separated from the command line in bot messages.
865         https://bugs.webkit.org/show_bug.cgi?id=52275
866
867         * Scripts/webkitpy/common/system/executive.py:
868         (ScriptError.message_with_output): Added a newline to separate the command
869         line from the errors.
870         * Scripts/webkitpy/common/system/executive_unittest.py:
871         (ScriptErrorTest.test_message_with_output): Added tests for the various code
872         paths in message_with_output.
873
874 2011-01-11  Eric Seidel  <eric@webkit.org>
875
876         Unreviewed.
877
878         commit-queue should know how to upload archived results (for test flakes or general failures)
879         https://bugs.webkit.org/show_bug.cgi?id=52048
880
881         The zips are mostly empty due to forgetting -r.
882         Expected diffs were not being pulled from the archive due
883         to the archive having longer paths than I realized.
884
885         * Scripts/webkitpy/common/system/workspace.py:
886         * Scripts/webkitpy/common/system/workspace_unittest.py:
887         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
888         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
889
890 2011-01-11  Dirk Pranke  <dpranke@chromium.org>
891
892         Reviewed by Ojan Vafai.
893
894         The current modifier parsing code in test_expectations is
895         fragile and hard-coded, so it's not easy to understand the logic
896         or easily add new types of modifiers (like GPU vs. CPU testing
897         for graphics tests, or 32-bit vs. 64-bit differences).
898
899         This is the first of two patches that will add in more generic
900         support and then eliminate the GPU-specific test expectations
901         files for Chromium.
902
903         This patch adds two standalone objects for handling modifiers. The
904         rules for interpreting modifiers, precedence, and conflicts are
905         given in the docstring to the ModifierMatcher class, which
906         returns ModifierMatchResult objects.
907         
908         This patch also adds routines to the Port interface and a
909         default set of values in the base object, in order to obtain the
910         values needed on a given test run. These values are then passed
911         to the expectation parser. This also allows us to clean up the
912         logic used to lint all of the different configurations in a
913         single test_expectations.txt file.
914
915         The next patch will merge in the separate GPU expectations file.
916
917         https://bugs.webkit.org/show_bug.cgi?id=51222
918
919         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
920         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
921         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
922         * Scripts/webkitpy/layout_tests/port/base.py:
923         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
924         * Scripts/webkitpy/layout_tests/port/chromium.py:
925         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
926         * Scripts/webkitpy/layout_tests/port/test.py:
927         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
928         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
929
930 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
931
932         Reviewed by Adam Barth.
933
934         Make webkit-patch support subdirectories for SVN checkouts
935         https://bugs.webkit.org/show_bug.cgi?id=52261
936
937         * Scripts/webkitpy/common/checkout/scm.py:
938         * Scripts/webkitpy/style_references.py:
939         * Scripts/webkitpy/tool/main.py:
940         * Scripts/webkitpy/tool/steps/preparechangelog.py:
941
942 2011-01-11  Eric Seidel  <eric@webkit.org>
943
944         Unreviewed.
945
946         commit-queue should know how to upload archived results (for test flakes or general failures)
947         https://bugs.webkit.org/show_bug.cgi?id=52048
948
949         I changed the API for archive_last_layout_test_results w/o updating the implementation.  Oops.
950         This fixes an exception seen on the commit-queue when attempting to report flaky tests.
951
952         * Scripts/webkitpy/common/system/workspace.py:
953         * Scripts/webkitpy/common/system/workspace_unittest.py:
954         * Scripts/webkitpy/tool/commands/queues.py:
955
956 2011-01-11  Sam Weinig  <sam@webkit.org>
957
958         Roll r75474 back in.
959
960 2011-01-11  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
961
962         Reviewed by Kenneth Rohde Christiansen.
963
964         [Qt] Remove uses of QFuture since it isn't supported on all platforms.
965         https://bugs.webkit.org/show_bug.cgi?id=51204
966
967         * QtTestBrowser/webpage.h:
968         (QtNAMThread::QtNAMThread):
969         (QtNAMThread::networkAccessManager):
970         (QtNAMThread::run):
971
972 2011-01-11  Peter Varga  <pvarga@webkit.org>
973
974         Unreviewed.
975
976         Add myself to committers' list.
977
978         * Scripts/webkitpy/common/config/committers.py:
979
980 2011-01-11  Eric Seidel  <eric@webkit.org>
981
982         Reviewed by Adam Barth.
983
984         commit-queue should know how to upload archived results (for test flakes or general failures)
985         https://bugs.webkit.org/show_bug.cgi?id=52048
986
987         Now the queue will always upload results.  Either the entire zip, or just
988         the diffs.txt in the case of text failures.
989
990         This should make understanding flakes much easier, and paves the way
991         for having the EWS run layout tests (and upload failures).
992
993         In order to upload .zip files I had to teach bugzilla.py to autodetect
994         mime types from the filename.  Since mimetypes.py doesn't include a mapping
995         for .patch files, I have it add one before calling guess_type.
996
997         We may find that always uploading the whole zip instead of just the -diffs.txt
998         file is preferable, but for now I'm keeping the old behavior because it makes
999         quickly understanding text failures easy.
1000
1001         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1002         * Scripts/webkitpy/common/system/workspace.py: Added.
1003         * Scripts/webkitpy/common/system/workspace_unittest.py: Added.
1004         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1005         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1006         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1007         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1008         * Scripts/webkitpy/tool/commands/queues.py:
1009         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1010
1011 2011-01-10  Sheriff Bot  <webkit.review.bot@gmail.com>
1012
1013         Unreviewed, rolling out r75464.
1014         http://trac.webkit.org/changeset/75464
1015         https://bugs.webkit.org/show_bug.cgi?id=52193
1016
1017         Followup rollout for 75474 (Requested by Ossy on #webkit).
1018
1019         * MiniBrowser/mac/BrowserWindowController.m:
1020         (-[BrowserWindowController awakeFromNib]):
1021         * MiniBrowser/win/BrowserView.cpp:
1022         (BrowserView::create):
1023         * WebKitTestRunner/TestController.cpp:
1024         (WTR::createOtherPage):
1025         (WTR::TestController::initialize):
1026
1027 2011-01-10  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1028
1029         Reviewed by Csaba Osztrogonác.
1030
1031         [Qt] Baseline qt_minimal configuration
1032         https://bugs.webkit.org/show_bug.cgi?id=51313
1033
1034         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1035         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): Add
1036         QT_NO_UNDOSTACK guard.
1037
1038         * QtTestBrowser/launcherwindow.cpp:
1039         (LauncherWindow::createChrome): Add QT_NO_SHORTCUT and QT_NO_PRINTER
1040         guards.
1041         (LauncherWindow::applyZoom): Add QT_NO_ANIMATION guard.
1042         (LauncherWindow::screenshot): Add QT_NO_FILEDIALOG guard.
1043         (LauncherWindow::selectElements): Add QT_NO_INPUTDIALOG guard.
1044         (LauncherWindow::showUserAgentDialog): Add QT_NO_COMBOBOX guard.
1045
1046         * QtTestBrowser/launcherwindow.h:
1047         * QtTestBrowser/locationedit.cpp: Add QT_NO_INPUTDIALOG guard.
1048         * QtTestBrowser/locationedit.h: Ditto.
1049
1050         * QtTestBrowser/mainwindow.cpp:
1051         (MainWindow::buildUI): Add QT_NO_INPUTDIALOG, QT_NO_SHORTCUT and
1052         QT_NO_UNDOSTACK guards.
1053         (MainWindow::setAddressUrl): Add QT_NO_INPUTDIALOG guard.
1054         (MainWindow::changeLocation): Ditto.
1055         (MainWindow::openFile): Add QT_NO_FILEDIALOG guard.
1056         (MainWindow::openLocation): Add QT_NO_INPUTDIALOG guard.
1057
1058         * QtTestBrowser/webpage.cpp:
1059         (WebPage::openUrlInDefaultBrowser): Add QT_NO_DESKTOPSERVICES guard.
1060         (WebPage::authenticationRequired): Add QT_NO_LINEEDIT guard.
1061
1062         * QtTestBrowser/webview.cpp:
1063         (WebViewGraphicsBased::animatedFlip): Add QT_NO_ANIMATION guard.
1064         (WebViewGraphicsBased::animatedYFlip): Ditto.
1065
1066 2011-01-10  Sam Weinig  <sam@webkit.org>
1067
1068         Fix build.
1069
1070         * MiniBrowser/mac/BrowserWindowController.m:
1071         (-[BrowserWindowController awakeFromNib]):
1072         * MiniBrowser/win/BrowserView.cpp:
1073         (BrowserView::create):
1074         * WebKitTestRunner/TestController.cpp:
1075         (WTR::createOtherPage):
1076         (WTR::TestController::initialize):
1077
1078 2011-01-10  Eric Seidel  <eric@webkit.org>
1079
1080         Reviewed by Ojan Vafai.
1081
1082         style-queue messages are way too long for big patches
1083         https://bugs.webkit.org/show_bug.cgi?id=52161
1084
1085         We definitely could build much fancier list-to-string-with-limit functions
1086         but this should be sufficient for our needs at the moment.
1087
1088         * Scripts/webkitpy/common/system/executive.py:
1089         * Scripts/webkitpy/common/system/executive_unittest.py:
1090
1091 2011-01-10  Tony Chang  <tony@chromium.org>
1092
1093         Unreviewed, rolling out r75398.
1094         http://trac.webkit.org/changeset/75398
1095         https://bugs.webkit.org/show_bug.cgi?id=52008
1096
1097         Some layout tests are crashing on Chromium Win.
1098
1099         * DumpRenderTree/chromium/WebViewHost.cpp:
1100         (WebViewHost::updatePaintRect):
1101         * DumpRenderTree/chromium/WebViewHost.h:
1102
1103 2011-01-10  Adam Roben  <aroben@apple.com>
1104
1105         Roll out r75392
1106
1107         It isn't needed now that r75289 has been rolled out.
1108
1109         * Scripts/run-javascriptcore-tests:
1110
1111 2011-01-10  Maciej Stachowiak  <mjs@apple.com>
1112
1113         Reviewed by Anders Carlsson.
1114
1115         WebKitTestRunner uses crazy amounts of CPU, making layout tests slow and flaky
1116         https://bugs.webkit.org/show_bug.cgi?id=52160
1117
1118         * WebKitTestRunner/mac/TestControllerMac.mm:
1119         (WTR::TestController::platformRunUntil): Instead of busy-looping, wait for the timeout.
1120         Anything that can make runUntil() conditions turn true will happen on a run loop cycle
1121         anyway.
1122
1123 2011-01-10  Tony Chang  <tony@chromium.org>
1124
1125         Reviewed by Mihai Parparita.
1126
1127         [chromium] fix for animated gif layout tests
1128         https://bugs.webkit.org/show_bug.cgi?id=52008
1129
1130         * DumpRenderTree/chromium/WebViewHost.cpp: Schedule a paint when we update the paint rect
1131             to trigger gif animations.
1132         (WebViewHostPaintTask::WebViewHostPaintTask):
1133         (WebViewHostPaintTask::runIfValid):
1134         (WebViewHost::updatePaintRect):
1135         * DumpRenderTree/chromium/WebViewHost.h:
1136         (WebViewHost::taskList):
1137
1138 2011-01-10  Alejandro G. Castro  <alex@igalia.com>
1139
1140         Reviewed by Xan Lopez.
1141
1142         [GTK] Fix gtk2 compilation for master
1143         https://bugs.webkit.org/show_bug.cgi?id=51885
1144
1145         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
1146         (createBitmapContextFromWebView): Replaced the old
1147         gdk_drawable_get_size with gdk_pixmap_get_size.
1148
1149 2011-01-10  Patrick Gansterer  <paroga@webkit.org>
1150
1151         Reviewed by Laszlo Gombos.
1152
1153         [WINCE] Reenable NPAPI after r75203
1154         https://bugs.webkit.org/show_bug.cgi?id=52109
1155
1156         Remove the !isWinCE() check for ENABLE_NETSCAPE_PLUGIN_API and replace
1157         it with !isEfl(), because EFL port does not support NPAPI (yet).
1158
1159         * Scripts/build-webkit:
1160
1161 2011-01-10  Adam Roben  <aroben@apple.com>
1162
1163         Skip some asserting JS tests
1164
1165         See <http://webkit.org/b/52156>.
1166
1167         * Scripts/run-javascriptcore-tests:
1168
1169 2011-01-10  Martin Robinson  <mrobinson@igalia.com>
1170
1171         Reviewed by Xan Lopez.
1172
1173         [GTK] build-webkit disable Blob support via arguments passed to automake
1174         https://bugs.webkit.org/show_bug.cgi?id=52097
1175
1176         * Scripts/build-webkit: Enable Blob support when building WebKitGTK+ via
1177         build-webkit.
1178
1179 2011-01-10  Adam Roben  <aroben@apple.com>
1180
1181         Use the same name and description for TestNetscapePlugin on Windows and
1182         Mac
1183
1184         Fixes <http://webkit.org/b/52151>
1185         fast/frames/iframe-reparenting-plugins.html fails on Windows
1186
1187         Reviewed by Steve Falkenburg.
1188
1189         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Copied
1190         the name and description from Mac's Info.plist.
1191
1192 2011-01-10  Siddharth Mathur <siddharth.mathur@nokia.com>
1193
1194         Reviewed by Laszlo Gombos.
1195
1196         [Qt][WK2] Guard gcc-specific syntax
1197
1198         Non-gcc based compliers choke on the "-include"
1199         syntax for preinclude, place guard around it.
1200
1201         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1202         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1203
1204 2011-01-10  Andreas Kling  <kling@webkit.org>
1205
1206         Reviewed by Simon Hausmann.
1207
1208         [Qt] [WK2] MiniBrowser does not load pages opened in new windows
1209         https://bugs.webkit.org/show_bug.cgi?id=52111
1210
1211         When getting a createNewPage() callback from QWKPage, create the
1212         new page with the same QWKContext as the page that is passed to
1213         the callback.
1214
1215         * MiniBrowser/qt/BrowserView.h:
1216         * MiniBrowser/qt/BrowserWindow.cpp:
1217         (newPageFunction):
1218         (BrowserWindow::BrowserWindow):
1219         * MiniBrowser/qt/BrowserWindow.h:
1220
1221 2011-01-10  Andreas Kling  <kling@webkit.org>
1222
1223         Reviewed by Kenneth Rohde Christiansen.
1224
1225         [Qt] MiniBrowser: Remove superfluous createNewPage() callback
1226
1227         BrowserView set its own useless createNewPage() callback on QWKPage.
1228         This was immediately overridden by BrowserWindow anyway, so remove
1229         the BrowserView one.
1230
1231         * MiniBrowser/qt/BrowserView.cpp:
1232         (BrowserView::BrowserView):
1233
1234 2011-01-10  John Knottenbelt  <jknotten@chromium.org>
1235
1236         Reviewed by Jeremy Orlow.
1237
1238         [Chromium] Remove non-client-based Geolocation code
1239         https://bugs.webkit.org/show_bug.cgi?id=50921
1240
1241         * DumpRenderTree/chromium/LayoutTestController.cpp:
1242         (LayoutTestController::setGeolocationPermission):
1243         (LayoutTestController::setMockGeolocationPosition):
1244         (LayoutTestController::setMockGeolocationError):
1245         * DumpRenderTree/chromium/WebViewHost.cpp:
1246         (WebViewHost::geolocationClientMock):
1247         (WebViewHost::reset):
1248         * DumpRenderTree/chromium/WebViewHost.h:
1249
1250 2011-01-10  Eric Seidel  <eric@webkit.org>
1251
1252         Reviewed by Adam Barth.
1253
1254         Commit bot tried to land r? cq+ patch
1255         https://bugs.webkit.org/show_bug.cgi?id=36638
1256
1257         It should now be possible to post a patch with r? and cq+ and the
1258         commit-queue will correctly wait for the r+ before attempting to land the patch.
1259         (This was a feature requested by several users.)
1260
1261         One caveat: We don't actually reject r-, cq+ patches from the queue
1262         (we just ignore them), but I think that's OK for now.
1263
1264         I also noticed that setting r- once a commit-queue node had grabbed
1265         a patch would not properly cancel the landing.  That's fixed and
1266         tested in this patch.
1267
1268         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1269         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1270         * Scripts/webkitpy/tool/bot/feeders.py:
1271         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
1272
1273 2011-01-08  Benjamin Poulain  <benjamin.poulain@nokia.com>
1274
1275         Reviewed by Kenneth Rohde Christiansen.
1276
1277         [Qt] QtWebKit crashes when using XMLHttpRequest from the unload event
1278         https://bugs.webkit.org/show_bug.cgi?id=51934
1279
1280         When accessing the network from the destructor of QWebPage, the network access manager
1281         was already deleted because the object WebPage was already destructed.
1282
1283         This solve the problem by linking the lifetime of the network access manager to WebPage's QObject.
1284         The object is now destructed in the destructor of QObject.
1285
1286         * QtTestBrowser/webpage.cpp:
1287         (WebPage::WebPage):
1288         (WebPage::setQnamThreaded):
1289         * QtTestBrowser/webpage.h:
1290         (QtNAMThread::QtNAMThread):
1291
1292 2011-01-08  Eric Seidel  <eric@webkit.org>
1293
1294         Reviewed by Ojan Vafai.
1295
1296         test_failures.py should not mention TestShell (long live DumpRenderTree!)
1297         https://bugs.webkit.org/show_bug.cgi?id=52067
1298
1299         I ran test-webkitpy, but didn't bother adding a unit test for this string change.
1300         https://bugs.webkit.org/show_bug.cgi?id=51138#c3 is an example of why this is needed.
1301
1302         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1303
1304 2011-01-08  Eric Seidel  <eric@webkit.org>
1305
1306         Reviewed by Mihai Parparita.
1307
1308         commit-queue hangs when the ChangeLog diff is bad
1309         https://bugs.webkit.org/show_bug.cgi?id=52072
1310
1311         * Scripts/webkitpy/tool/steps/validatechangelogs.py:
1312         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
1313
1314 2011-01-08  Adam Barth  <abarth@webkit.org>
1315
1316         Teach svn-apply how to re-write WebCore to Source/WebCore.
1317
1318         * Scripts/VCSUtils.pm:
1319
1320 2011-01-07  Adam Barth  <abarth@webkit.org>
1321
1322         Rubber-stamped by Eric Seidel.
1323
1324         Move WebCore to Source
1325         https://bugs.webkit.org/show_bug.cgi?id=52050
1326
1327         Update the tools to understand WebCore's new location.
1328
1329         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1330         * DumpRenderTree/wscript:
1331         * GNUmakefile.am:
1332         * Scripts/build-webkit:
1333         * Scripts/do-file-rename:
1334         * Scripts/do-webcore-rename:
1335         * Scripts/generate-qt-inspector-resource:
1336         * Scripts/prepare-ChangeLog:
1337         * Scripts/run-bindings-tests:
1338         * Scripts/update-iexploder-cssproperties:
1339         * Scripts/update-sources-list.py:
1340         * Scripts/update-webkit-localizable-strings:
1341         * Scripts/webkitdirs.pm:
1342         * Scripts/webkitpy/common/config/build.py:
1343         * Scripts/webkitpy/common/config/build_unittest.py:
1344         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
1345         * Scripts/webkitpy/style/checker.py:
1346         * Scripts/webkitpy/style/checker_unittest.py:
1347         * WebKitTestRunner/DerivedSources.pro:
1348         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1349         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh:
1350         * wx/browser/wscript:
1351         * wx/build/settings.py:
1352
1353 2011-01-07  Maciej Stachowiak  <mjs@apple.com>
1354
1355         Reviewed by Sam Weinig.
1356
1357         Make WebKitTestRunner rest between loads more robust to avoid test crashes
1358         https://bugs.webkit.org/show_bug.cgi?id=52086
1359
1360         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1361         (WTR::InjectedBundle::didReceiveMessage):
1362         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1363         (WTR::LayoutTestController::notifyDone):
1364         * WebKitTestRunner/TestController.cpp:
1365         (WTR::TestController::resetStateToConsistentValues):
1366         (WTR::TestController::run):
1367
1368 2011-01-07  James Robinson  <jamesr@chromium.org>
1369
1370         Revert "Implement mozilla's animationTime property"
1371         https://bugs.webkit.org/show_bug.cgi?id=51952
1372
1373         This approach isn't quite right.
1374
1375         * DumpRenderTree/chromium/WebViewHost.cpp:
1376         (WebViewHost::paintInvalidatedRegion):
1377
1378 2011-01-07  Adam Roben  <aroben@apple.com>
1379
1380         Build master fix
1381
1382         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1383         (RunWebKitTests.start): Don't try to concatenate a list and a string.
1384
1385 2011-01-07  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>
1386
1387         Reviewed by Csaba Osztrogonác.
1388
1389         run-qtwebkit-tests should be able to kill a testsuite.
1390
1391         Add new option in the script that can setup a timeout for a test.
1392         If the test execution takes more then specified time then the test
1393         would be terminated.
1394
1395         [Qt] run-qtwebkit-tests needs timeout
1396         https://bugs.webkit.org/show_bug.cgi?id=51894
1397
1398         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1399         * Scripts/run-qtwebkit-tests:
1400
1401 2011-01-07  Csaba Osztrogonác  <ossy@webkit.org>
1402
1403         Unreviewed fix after r75233.
1404
1405         Based on idea from Eric Seidel.
1406
1407         Add remote zip file handling to webkitpy.
1408         https://bugs.webkit.org/show_bug.cgi?id=50901
1409
1410         * Scripts/webkitpy/common/system/fileset.py: Make python 2.5 happy.
1411
1412 2011-01-07  Shane Stephens  <shanestephens@google.com>
1413
1414         Reviewed by Eric Seidel.
1415
1416         svn-apply: should support git binary delta diffs
1417         https://bugs.webkit.org/show_bug.cgi?id=38864
1418
1419         * Scripts/VCSUtils.pm:
1420         * Scripts/svn-apply:
1421
1422 2011-01-06  Julie Parent  <jparent@chromium.org>
1423
1424         Reviewed by Eric Seidel.
1425
1426         Test Result Server not removing old results.
1427         https://bugs.webkit.org/show_bug.cgi?id=52012
1428
1429         * TestResultServer/model/jsonresults.py:
1430         Fix off-by-one: Truncate if >= num_runs, not just >.
1431         * TestResultServer/model/jsonresults_unittest.py:
1432         Add unit test to test that merging in a new result with the same value
1433         as the last result causes previous result to fall off.
1434
1435 2011-01-06  James Kozianski  <koz@chromium.org>
1436
1437         Reviewed by Mihai Parparita.
1438
1439         Add classes to provide a consistent interface to a set of files.
1440         https://bugs.webkit.org/show_bug.cgi?id=50901
1441
1442         These classes allow us to write code that is agnostic to whether a
1443         particular set of files resides in a local directory or in a zip file
1444         on a remote machine.
1445
1446         * Scripts/webkitpy/common/system/directoryfileset.py: Added.
1447         * Scripts/webkitpy/common/system/directoryfileset_unittest.py: Added.
1448         * Scripts/webkitpy/common/system/fileset.py: Added.
1449         * Scripts/webkitpy/common/system/filesystem.py:
1450         * Scripts/webkitpy/common/system/filesystem_mock.py:
1451         * Scripts/webkitpy/common/system/zipfileset.py: Added.
1452         * Scripts/webkitpy/common/system/zipfileset_unittest.py: Added.
1453
1454 2011-01-06  Eric Seidel  <eric@webkit.org>
1455
1456         Reviewed by Adam Barth.
1457
1458         NetworkTransaction should log the url it is retrying
1459         https://bugs.webkit.org/show_bug.cgi?id=52043
1460
1461         * Scripts/webkitpy/common/net/networktransaction.py:
1462         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
1463
1464 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
1465
1466         Windows build fix.
1467         Import os before using it.
1468
1469         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1470
1471 2011-01-06  Eric Seidel  <eric@webkit.org>
1472
1473         Reviewed by Adam Barth.
1474
1475         StyleQueue fails to report errors when patches have many files
1476         https://bugs.webkit.org/show_bug.cgi?id=52042
1477
1478         This is one of at least two errors preventing style error reporting at the moment.
1479         When we moved to passing the list of files to check explicitly,
1480         we started to exceed the 500 character TEXT field limit for our AppEngine model object.
1481         We could change the type of the QueueStatus.message type, or we could
1482         just teach statusserver.py how to clamp values (and warn when it does).
1483         I chose the latter path.
1484
1485         * Scripts/webkitpy/common/net/statusserver.py:
1486
1487 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
1488
1489         Reviewed by Stephanie Lewis.
1490         
1491         Fix syntax error in script.
1492
1493         Windows bots need to archive/unarchive builds to/from configuration-specific directories
1494         https://bugs.webkit.org/show_bug.cgi?id=51996
1495
1496         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1497
1498 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1499
1500         Unreviewed, fixing WinCE build after r75196.
1501
1502         WinCE port does not (yet) support NPAPI.
1503
1504         * Scripts/build-webkit:
1505
1506 2011-01-06  Xan Lopez  <xlopez@igalia.com>
1507
1508         Reviewed by Darin Adler.
1509
1510         File::Spec->rel2abs in sunspider-compare-results mangles parameters
1511         https://bugs.webkit.org/show_bug.cgi?id=52015
1512
1513         * Scripts/sunspider-compare-results: call rel2abs on our arguments
1514         after the platform has been detected, otherwise the script will
1515         mangle things like '--gtk' into '/a/path/--gtk', breaking the
1516         detection.
1517
1518 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1519
1520         Reviewed by Eric Seidel.
1521
1522         Add ENABLE_NETSCAPE_PLUGIN_API, ENABLE_ORIENTATION_EVENTS and ENABLE_TOUCH_EVENTS flags to build-webkit
1523         https://bugs.webkit.org/show_bug.cgi?id=51346
1524
1525         * Scripts/build-webkit:
1526
1527 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
1528
1529         Reviewed by Adam Roben.
1530
1531         Windows bots need to archive/unarchive builds to/from configuration-specific directories
1532         https://bugs.webkit.org/show_bug.cgi?id=51996
1533         
1534         After the configuration directory change, we were archiving the incorrect directory for
1535         build product, so we were running tests on the wrong binaries.
1536         
1537         This change archives the correct directory, and also unarchives it into a configuration-
1538         specific directory.
1539
1540         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Use a configuration-specific directory on Windows.
1541         * BuildSlaveSupport/built-product-archive: Unarchive/archive to/from proper directory.
1542
1543 2011-01-06  Eric Seidel  <eric@webkit.org>
1544
1545         Reviewed by Mihai Parparita.
1546
1547         commit-queue mentions "Text diff mismatch" 4 times instead of once per failure
1548         https://bugs.webkit.org/show_bug.cgi?id=52002
1549
1550         See an example of this here:
1551         https://bugs.webkit.org/show_bug.cgi?id=51314#c2
1552
1553         It's due to the fact that we pass around TestFailure() instance
1554         objects and yet expect them to all compare to be the same.
1555
1556         This is bad.  We should either have shared instances of these values
1557         or we should just pass around the class names.  There are already hacks
1558         in place to make TestFailure objects pass equality tests, I just added
1559         a __hash__ implementation so they can be used in sets as expected.
1560
1561         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1562         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1563
1564 2011-01-06  Evan Martin  <evan@chromium.org>
1565
1566         Reviewed by Tony Chang.
1567
1568         [gdb] handle inaccessible memory and UChar*
1569         https://bugs.webkit.org/show_bug.cgi?id=52003
1570
1571         To pretty-print a UChar*, we just grope around in the memory
1572         looking for a terminating NUL.  We need to handle the exception
1573         that can occur when we poke into an invalid location.
1574
1575         Additionally, the logic for choosing which pretty-printer would
1576         early return before hitting the point where we'd use the UChar*
1577         printer.  (Did this ever work?  How did it regress?)
1578
1579         * gdb/webkit.py:
1580
1581 2011-01-05  Brian Weinstein  <bweinstein@apple.com>
1582
1583         Reviewed by Ada Chan.
1584
1585         WebKit2: Should be able to call into injected bundle to ask if we should allow resource loads
1586         https://bugs.webkit.org/show_bug.cgi?id=51969
1587         
1588         Add shouldLoadResourceForFrame to WTR::InjectedBundlePage.
1589
1590         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1591         (WTR::InjectedBundlePage::InjectedBundlePage):
1592         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Stub implementation.
1593         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1594
1595 2011-01-06  James Robinson  <jamesr@chromium.org>
1596
1597         Reviewed by Simon Fraser.
1598
1599         Implement mozilla's animationTime property
1600         https://bugs.webkit.org/show_bug.cgi?id=51952
1601
1602         Chromium DRT support for webkitAnimationTime.
1603
1604         * DumpRenderTree/chromium/WebViewHost.cpp:
1605         (WebViewHost::paintInvalidatedRegion):
1606
1607 2011-01-06  Julie Parent  <jparent@chromium.org>
1608
1609         Reviewed by Tony Chang.
1610
1611         Test Result Server always truncates number of results to JSON_RESULTS_MAX_BUILDS
1612         https://bugs.webkit.org/show_bug.cgi?id=51217
1613
1614         * TestResultServer/model/jsonresults.py:
1615         Pass num_runs through to _remove_items_over_max_number_of_builds, and use the value.
1616         Adds missing documentation.
1617         * TestResultServer/model/jsonresults_unittest.py:
1618         Add unit test to test that truncation happens at smaller value than JSON_RESULTS_MAX_BUILDS.
1619         Update test_merge to take a number of builds to truncate at.
1620
1621 2011-01-06  Adam Barth  <abarth@webkit.org>
1622
1623         Reviewed by Eric Seidel.
1624
1625         The EWS should log outside of the working directory
1626         https://bugs.webkit.org/show_bug.cgi?id=51986
1627
1628         This patch prepare us for using git clean -x -d -f in the EWS wrapper
1629         script, which will actually clean the working copy back to a pristine
1630         state instead of leaving untracked directories and ignored files.
1631
1632         * Scripts/webkitpy/tool/commands/queues.py:
1633         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1634
1635 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
1636
1637         Windows build fix.
1638         Back out attempted change to built-product-archive.
1639
1640         * BuildSlaveSupport/built-product-archive:
1641
1642 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
1643
1644         Windows build fix.
1645         Include configuration name when unpacking a build archive.
1646
1647         Needed, since we split Windows build results into configuration-specific directories
1648         under WebKitOutputDir.
1649
1650         * BuildSlaveSupport/built-product-archive:
1651
1652 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
1653
1654         Reviewed by Darin Adler.
1655
1656         Debug and Release builds on Windows clobber each other
1657         https://bugs.webkit.org/show_bug.cgi?id=49185
1658
1659         Changes the structure of WebKitBuild build products directory so we
1660         completely separate each build configuration into independent directories.
1661         
1662         Although we previously had per-configuration directories for obj, this change adds
1663         per-configuration directories for bin, lib, obj, and include. Each configuration's
1664         build products are stored within a directory inside of WebKitBuild.
1665         
1666         Most use of $(WebKitOutputDir) in the build files has been replaced by $(ConfigurationBuildDir),
1667         defined in common.vsprops to be $(WebKitOutputDir)\$(ConfigurationName).
1668
1669         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops:
1670         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd:
1671         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd:
1672         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
1673         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd:
1674         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd:
1675         * DumpRenderTree/win/ImageDiffCommon.vsprops:
1676         * DumpRenderTree/win/ImageDiffPostBuild.cmd:
1677         * DumpRenderTree/win/ImageDiffPreBuild.cmd:
1678         * FindSafari/FindSafari.vcproj:
1679         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
1680         * MiniBrowser/MiniBrowserPostBuild.cmd:
1681         * MiniBrowser/MiniBrowserPreBuild.cmd:
1682         * Scripts/webkitdirs.pm:
1683         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
1684         * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops:
1685         * TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd:
1686         * TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd:
1687         * TestWebKitAPI/win/copy-resources.cmd:
1688         * WebKitAPITest/WebKitAPITestCommon.vsprops:
1689         * WebKitAPITest/WebKitAPITestPostBuild.cmd:
1690         * WebKitAPITest/WebKitAPITestPreBuild.cmd:
1691         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
1692         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
1693         * WebKitTestRunner/win/InjectedBundle.vcproj:
1694         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops:
1695         * WebKitTestRunner/win/InjectedBundlePostBuild.cmd:
1696         * WebKitTestRunner/win/InjectedBundlePreBuild.cmd:
1697         * WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd:
1698         * WebKitTestRunner/win/WebKitTestRunnerPreBuild.cmd:
1699         * WinLauncher/WinLauncherCommon.vsprops:
1700         * WinLauncher/WinLauncherPostBuild.cmd:
1701         * WinLauncher/WinLauncherPreBuild.cmd:
1702
1703 2011-01-05  Jan Erik Hanssen  <jhanssen@sencha.com>
1704
1705         Reviewed by Ariya Hidayat.
1706
1707         [Qt] TestNetscapePlugin doesn't link on OS X
1708         https://bugs.webkit.org/show_bug.cgi?id=51948
1709
1710         Only add a dependency on libX11 on X11 systems
1711
1712         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1713
1714 2011-01-05  Jeff Miller  <jeffm@apple.com>
1715
1716         Reviewed by Adam Roben.
1717
1718         check-webkit-style should allow unnecessary parameter names in WebKit2 APIs because we're matching CF's header style
1719         https://bugs.webkit.org/show_bug.cgi?id=51970
1720
1721         * Scripts/webkitpy/style/checker.py:
1722         Add -readability/naming for WebKit2 C API directories.
1723
1724 2011-01-05  Eric Seidel  <eric@webkit.org>
1725
1726         Unreviewed, just fixing one more log error from my previous python patch.
1727
1728         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
1729         https://bugs.webkit.org/show_bug.cgi?id=51802
1730
1731         webkit-patch failure-reason was logging about parsing errors
1732         due to my misunderstanding of how BeautifulSoup.findAll worked.
1733
1734         Fixed, and added a unit test.
1735
1736         * Scripts/webkitpy/common/net/layouttestresults.py:
1737         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1738
1739 2011-01-05  Benjamin Poulain  <benjamin.poulain@nokia.com>
1740
1741         Reviewed by Kenneth Rohde Christiansen.
1742
1743         [Qt] [WK2] Add the possibility to open window from the WebProcess in Minibrowser
1744         https://bugs.webkit.org/show_bug.cgi?id=51951
1745
1746         Set a function to QWKPage::setCreateNewPageFunction() in Minibrowser so there is a way
1747         to create new window from WebKit.
1748
1749         * MiniBrowser/qt/BrowserWindow.cpp:
1750         (newPageFunction):
1751         (BrowserWindow::BrowserWindow):
1752         (BrowserWindow::page): Added to avoid the indirect access to QWKPage spread in the class
1753         (BrowserWindow::newWindow):
1754         (BrowserWindow::updateUserAgentList):
1755         (BrowserWindow::showUserAgentDialog):
1756         * MiniBrowser/qt/BrowserWindow.h: Add the global variable backingStoreTypeForNewWindow to
1757         define the type of the backing store used for new windows.
1758         * MiniBrowser/qt/main.cpp:
1759         (main):
1760
1761 2011-01-05  Eric Seidel  <eric@webkit.org>
1762
1763         Reviewed by Ojan Vafai.
1764
1765         commit-queue should report failure type when reporting flaky tests
1766         https://bugs.webkit.org/show_bug.cgi?id=51900
1767
1768         This patch was a ridiculous amount of plumbing.  In the end I like
1769         the NRWT-style TestResult class even less.  But now we're passing
1770         a list of TestResult objects from the queue to the FlakyTestReporter.
1771         Thus the FlakyTestReporter can more easily report what type of failure
1772         occurred.
1773
1774         In the process, I found that I was not alone in finding TestResult
1775         cumbersome to use.  A bunch of code was trying to create a TestResult
1776         object with default values.  However since the constructor didn't make
1777         this easy, some places were getting it wrong (including the TestResult unit test)!
1778         I've fixed the TestResult constructor to have default values for non-essential
1779         arguments.
1780
1781         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1782         * Scripts/webkitpy/common/net/layouttestresults.py:
1783         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1784         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1785         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1786         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1787         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
1788         * Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py:
1789         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1790         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1791         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1792         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1793         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1794         * Scripts/webkitpy/tool/commands/queues.py:
1795         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1796
1797 2011-01-05  Eric Seidel  <eric@webkit.org>
1798
1799         Unreviewed.
1800
1801         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
1802         https://bugs.webkit.org/show_bug.cgi?id=51802
1803
1804         Add another unit test to cover a previously missing import.
1805
1806         * Scripts/webkitpy/common/net/layouttestresults.py:
1807         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1808
1809 2011-01-05  Mihai Parparita  <mihaip@chromium.org>
1810
1811         Reviewed by David Levin.
1812
1813         Add mihaip@chromium.org as a reviewer
1814         https://bugs.webkit.org/show_bug.cgi?id=51966
1815         
1816         Add myself as a reviewer.
1817
1818         * Scripts/webkitpy/common/config/committers.py:
1819
1820 2011-01-05  James Simonsen  <simonjam@chromium.org>
1821
1822         Unreviewed. Adding myself to the list of committers.
1823
1824         * Scripts/webkitpy/common/config/committers.py:
1825
1826 2011-01-05  Eric Seidel  <eric@webkit.org>
1827
1828         Unreviewed.
1829
1830         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
1831         https://bugs.webkit.org/show_bug.cgi?id=51802
1832
1833         Fix two exceptions seen on the bots after my original commit.
1834
1835         * Scripts/webkitpy/common/net/layouttestresults.py:
1836         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1837
1838 2011-01-05  Kundu Suchismita  <suchi.kundu@nokia.com>
1839
1840         Reviewed by Andreas Kling.
1841
1842         [Qt]Add local storage settings to QtTestBrowser command line arguments 
1843         https://bugs.webkit.org/show_bug.cgi?id=51750
1844
1845         * QtTestBrowser/main.cpp:
1846         (LauncherApplication::handleUserOptions):
1847          Local storage settings can be enable form command line arguments for
1848          QtTestBrowser.
1849
1850 2011-01-05  Chris Fleizach  <cfleizach@apple.com>
1851
1852         Reviewed by Martin Robinson.
1853
1854         GTK: AX: DRT needs to use correct root object method.
1855         https://bugs.webkit.org/show_bug.cgi?id=51911
1856
1857         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
1858         (AccessibilityController::rootElement):
1859
1860 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
1861
1862         Rubber-stamped by Csaba Osztrogonác.
1863
1864         Based on idea from Péter Gál.
1865
1866         * Scripts/webkitpy/tool/bot/sheriff.py: Remove unnecessary apostrophes around revision numbers.
1867
1868 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
1869
1870         Reviewed by Adam Barth.
1871
1872         sheriff-bot should be able to do multi-revision rollouts
1873         https://bugs.webkit.org/show_bug.cgi?id=51176
1874
1875         * Scripts/webkitpy/tool/bot/irc_command.py:
1876         * Scripts/webkitpy/tool/bot/sheriff.py:
1877         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
1878
1879 2011-01-05  Eric Seidel  <eric@webkit.org>
1880
1881         Reviewed by Adam Barth.
1882
1883         queues.webkit.org should have per-bot status pages
1884         https://bugs.webkit.org/show_bug.cgi?id=51906
1885
1886         Just adds a /queue-status/QUEUE_NAME/bots/BOT_ID page to show
1887         statuses from a single queue.  Now that we have many bots servicing
1888         some queues (commit-queue, win-ews, etc.) its easy to have the messages
1889         you care about scroll off the end of the 15-message limit on the main page.
1890
1891         Eventually we should probably rename /queue-status to /queue or /queues,
1892         but that's fodder for another patch.
1893
1894         * QueueStatusServer/handlers/queuestatus.py:
1895         * QueueStatusServer/index.yaml:
1896         * QueueStatusServer/main.py:
1897         * QueueStatusServer/templates/includes/singlequeuestatus.html:
1898          - This probably should use a custom filter instead of hard-coding
1899            the URL scheme here, but I couldn't figure out how to easily
1900            create such a filter.  Most filters work with "strings" so we can't
1901            pass the status object.  We could add a method to the status
1902            object and call that, but that seemed a bit strange too.
1903         * QueueStatusServer/templates/queuestatus.html:
1904
1905 2011-01-05  Carlos Garcia Campos  <cgarcia@igalia.com>
1906
1907         Unreviewed. Adding myself to the list of committers.
1908
1909         * Scripts/webkitpy/common/config/committers.py:
1910
1911 2011-01-04  Koan-Sin Tan  <koansin.tan@gmail.com>
1912
1913         Reviewed by David Levin.
1914
1915         check-webkit-style treated some macros with parentheses after #elif as function calls
1916         https://bugs.webkit.org/show_bug.cgi?id=51695
1917
1918         Ingore function call space checking in any preprocessor directives
1919         (things starting with #). Change search() to match() because 
1920         preprocessor directives are supposed to be in the beginning of lines.
1921
1922         * Scripts/webkitpy/style/checkers/cpp.py:
1923         * Scripts/webkitpy/style/checkers/cpp_unittest.py: make sure there is no false positives for #elif cases
1924
1925 2011-01-04  Søren Gjesse  <sgjesse@chromium.org>
1926
1927         Reviewed by Tony Chang.
1928
1929         Change the --multi-load test option to --stress-opt
1930         https://bugs.webkit.org/show_bug.cgi?id=50751
1931
1932         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1933         (runTest):
1934         (main):
1935         * DumpRenderTree/chromium/TestShell.cpp:
1936         (TestShell::TestShell):
1937         * DumpRenderTree/chromium/TestShell.h:
1938         (TestShell::stressOpt):
1939         (TestShell::setStressOpt):
1940         (TestShell::stressDeopt):
1941         (TestShell::setStressDeopt):
1942         (TestShell::javaScriptFlags):
1943         (TestShell::setJavaScriptFlags):
1944         * Scripts/webkitpy/layout_tests/port/chromium.py:
1945         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1946
1947 2011-01-04  Chris Fleizach  <cfleizach@apple.com>
1948
1949         Reviewed by Sam Weinig.
1950
1951         WK2: Support Accessibility
1952         https://bugs.webkit.org/show_bug.cgi?id=51859
1953
1954         Use rootObject() method to get top of accessibility tree.
1955
1956         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
1957         (AccessibilityController::focusedElement):
1958         (AccessibilityController::rootElement):
1959
1960 2011-01-03  Martin Robinson  <mrobinson@igalia.com>
1961
1962         Reviewed by Darin Adler.
1963
1964         Remove the last non-GObject usage of PlatformRefPtr and move the code to GRefPtr
1965         https://bugs.webkit.org/show_bug.cgi?id=51846
1966
1967         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: Change usage of PlatformRefPtr
1968         back to GRefPtr.
1969
1970 2011-01-04  Zhe Su  <suzhe@chromium.org>
1971
1972         Reviewed by Kenneth Russell.
1973
1974         Fix insertText, setMarkedText and unmarkText methods of
1975         TextInputController to call corresponding methods of WebKit::WebView
1976         rather than WebKit::WebFrame. This change matches the behavior of
1977         chromium browser.
1978         insertText corresponds to WebView::confirmComposition(text)
1979         setMarkedText corresponds to WebView::setComposition(...)
1980         unmarkText corresponds to WebView::confirmComposition()
1981         https://bugs.webkit.org/show_bug.cgi?id=51693
1982
1983         * DumpRenderTree/chromium/TextInputController.cpp:
1984         (TextInputController::insertText):
1985         (TextInputController::setMarkedText):
1986         (TextInputController::unmarkText):
1987
1988 2011-01-04  Dihan Wickremasuriya  <dihan.wickremasuriya@nokia.com>
1989
1990         Reviewed by Laszlo Gombos.
1991
1992         [Qt] [Symbian] Do not remove 0 byte sized files from productDir
1993
1994         On Symbian productDir points to the source directory. Removing all the
1995         empty files from the productDir directory corrupts the svn repository.
1996
1997         * Scripts/build-webkit:
1998
1999 2011-01-03  Yi Shen  <yi.4.shen@nokia.com>
2000
2001         Reviewed by Adam Barth.
2002
2003         [Qt] Add SelectAll option to the context menu for the editor
2004         https://bugs.webkit.org/show_bug.cgi?id=50049
2005
2006         Set shortcut for the SelectAll action.
2007
2008         * QtTestBrowser/mainwindow.cpp:
2009         (MainWindow::buildUI):
2010
2011 2011-01-03  David Levin  <levin@chromium.org>
2012
2013         Reviewed by Eric Seidel.
2014
2015         check-webkit-style shouldn't consider "value" automatically to be a meaningless name.
2016         https://bugs.webkit.org/show_bug.cgi?id=51842
2017
2018         * Scripts/webkitpy/style/checkers/cpp.py: Remove the check for value.
2019         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Remove the test for value.
2020
2021 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
2022
2023         Reviewed by David Kilzer.
2024
2025         [WINCE] Adds a build slave.
2026         https://bugs.webkit.org/show_bug.cgi?id=50523
2027
2028         * BuildSlaveSupport/build.webkit.org-config/config.json: Add an
2029         entry for a release build of the WinCE port.
2030         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add platform
2031         flag to build the WinCE port.
2032
2033 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
2034
2035         Reviewed by David Kilzer.
2036
2037         Add WinCE support to build-webkit
2038         https://bugs.webkit.org/show_bug.cgi?id=51642
2039
2040         * Scripts/build-webkit:
2041         * Scripts/webkitdirs.pm:
2042
2043 2011-01-03  Eric Seidel  <eric@webkit.org>
2044
2045         Reviewed by Adam Barth.
2046
2047         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
2048         https://bugs.webkit.org/show_bug.cgi?id=51802
2049
2050         I'm not the biggest fan of the test_failures or test_results classes,
2051         but it's better to have one shared set of classes, than separate ones
2052         for new vs. old run-webkit-test result handling.
2053
2054         This moves the ORWT results class "LayoutTestResults" over to using
2055         TestResult and TestFailure classes, making it easy for us to
2056         make all our sheriff-bot and other webkitpy code NRWT ready.
2057
2058         This also makes it a trivial patch to generate results.json information
2059         from ORWT results.html files (for flaky test analysis, etc.) as well
2060         as making it a one-liner to report test failure types when the
2061         commit-queue sees flaky tests.
2062
2063         This patch tried not to add new functionality, but only to replace
2064         the guts of LayoutTestResults, while adding unit tests and hoping
2065         not to break anything.
2066
2067         I also moved callers which assumed User.prompt* were static/class methods
2068         to using them as instance methods (since we'll eventually want to make them such).
2069
2070         In the process of re-writing things, I broke the rebaseline command, so I wrote
2071         a unit test to catch my breakage were I do do so again in the future.
2072
2073         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2074         * Scripts/webkitpy/common/net/layouttestresults.py:
2075         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2076         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
2077         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
2078         * Scripts/webkitpy/tool/commands/queries.py:
2079         * Scripts/webkitpy/tool/commands/rebaseline.py:
2080         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2081         * Scripts/webkitpy/tool/mocktool.py:
2082
2083 2011-01-03  Adam Barth  <abarth@webkit.org>
2084
2085         Reviewed by Simon Fraser.
2086
2087         webkit-patch shouldn't waste time cleaning a working directory that's already clean
2088         https://bugs.webkit.org/show_bug.cgi?id=51840
2089
2090         * Scripts/webkitpy/common/checkout/scm.py:
2091
2092 2011-01-03  Adam Barth  <abarth@webkit.org>
2093
2094         Reviewed by Simon Fraser.
2095
2096         webkit-patch should only hide update output if --quiet
2097         https://bugs.webkit.org/show_bug.cgi?id=51838
2098
2099         As requested by smfr.
2100
2101         * Scripts/webkitpy/tool/steps/update.py:
2102
2103 2011-01-03  Adam Barth  <abarth@webkit.org>
2104
2105         Reviewed by David Levin.
2106
2107         commit-queue shouldn't reject patches twice if two bots process the same patch
2108         https://bugs.webkit.org/show_bug.cgi?id=51805
2109
2110         Before raising an error, we first check whether the patch is still in
2111         the commit-queue.  This check is still racy, of course, but the time
2112         window is much smaller.
2113
2114         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2115
2116 2011-01-03  Sam Weinig  <sam@webkit.org>
2117
2118         Reviewed by Anders Carlsson.
2119
2120         Make run-api-tests less chatty.
2121         https://bugs.webkit.org/show_bug.cgi?id=51831
2122
2123         - Make script quiet by default and add --verbose option (replacing --quiet).
2124         - When not verbose, pipe stdout and stderr to devnull.
2125
2126         * Scripts/run-api-tests:
2127
2128 2011-01-03  Pratik Solanki  <psolanki@apple.com>
2129
2130         Unreviewed. Adding myself to committers.py.
2131
2132         * Scripts/webkitpy/common/config/committers.py:
2133
2134 2011-01-03  Koan-Sin Tan  <koansin.tan@gmail.com>
2135
2136         Reviewed by Xan Lopez.
2137
2138         "Tool/Scripts/run-launcher --gtk" stopped working after 74855
2139         https://bugs.webkit.org/show_bug.cgi?id=51806
2140
2141         Originally, the $libraryName is 'JavaScriptCore'. When building release 
2142         one, the $libraryDir was 'WebKitBuild/Release/JavaScriptCore/../.libs/'
2143         which doesn't exist anymore ('WebKitBuild/Release/JavaScriptCore'
2144         is 'WebKitBuild/Release/Source/JavaScriptCore' now), and 
2145         'WebKitBuild/Release/Source/JavaScriptCore/../../.libs' looks weird,
2146         so make it 'WebKitBuild/Release/.libs'
2147
2148         * Scripts/webkitdirs.pm: 
2149
2150 2011-01-02  Patrick Gansterer  <paroga@webkit.org>
2151
2152         Reviewed by Adam Barth.
2153
2154         Make EFL a core builder
2155         https://bugs.webkit.org/show_bug.cgi?id=51804
2156
2157         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2158         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2159
2160 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
2161
2162         [Qt] Unreviewed fix after r74855 and r74875.
2163
2164         * BuildSlaveSupport/built-product-archive:
2165          - Create directories explicitly.
2166          - Pass shell=True to subprocess.call().
2167
2168 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
2169
2170         [Qt] Unreviewed fix after r74855.
2171
2172         Move JavaScriptCore to Source
2173         https://bugs.webkit.org/show_bug.cgi?id=51604
2174
2175         * BuildSlaveSupport/built-product-archive: JavaScriptCore -> Source/JavaScriptCore
2176
2177 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
2178
2179         [Qt] Unreviewed run-javasriptcore-tests fix after r74855.
2180
2181         Move JavaScriptCore to Source
2182         https://bugs.webkit.org/show_bug.cgi?id=51604
2183
2184         * Scripts/webkitdirs.pm:
2185
2186 2011-01-02  Robert Hogan  <robert@webkit.org>
2187
2188         Unreviewed, build fix.
2189
2190         [Qt] Fix DRT build after 74855
2191
2192         * DumpRenderTree/qt/DumpRenderTree.pro:
2193
2194 2011-01-01  Adam Barth  <abarth@webkit.org>
2195
2196         Remove the assumption from the Qt and Gtk builds that every project is
2197         in the root directory.
2198
2199         * Scripts/build-webkit:
2200
2201 2011-01-01  Adam Barth  <abarth@webkit.org>
2202
2203         Reviewed by Eric Seidel.
2204
2205         Teach svn-apply how to apply patches even though JavaScriptCore has moved
2206         https://bugs.webkit.org/show_bug.cgi?id=51796
2207
2208         After this change, svn-apply will magically apply patches to
2209         JavaScriptCore/foo to Source/JavaScriptCore/foo.
2210
2211         * Scripts/VCSUtils.pm:
2212
2213 2011-01-01  Adam Barth  <abarth@webkit.org>
2214
2215         Reviewed by Eric Seidel.
2216
2217         Move JavaScriptCore to Source
2218         https://bugs.webkit.org/show_bug.cgi?id=51604
2219
2220         Update references to JavaScriptCore to point to the new location.
2221
2222         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2223         * DumpRenderTree/qt/DumpRenderTree.pro:
2224         * DumpRenderTree/qt/ImageDiff.pro:
2225         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2226         * DumpRenderTree/wscript:
2227         * Scripts/build-jsc:
2228         * Scripts/build-webkit:
2229         * Scripts/do-file-rename:
2230         * Scripts/do-webcore-rename:
2231         * Scripts/run-javascriptcore-tests:
2232         * Scripts/update-javascriptcore-test-results:
2233         * Scripts/webkitdirs.pm:
2234         * Scripts/webkitpy/common/config/build_unittest.py:
2235         * Scripts/webkitpy/style/checker.py:
2236         * Scripts/webkitpy/style/checker_unittest.py:
2237         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2238         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2239         * WebKitTestRunner/qt/WebKitTestRunner.pro:
2240         * wx/build/settings.py:
2241
2242 2011-01-01  Adam Barth  <abarth@webkit.org>
2243
2244         Reviewed by Eric Seidel.
2245
2246         Move Sources to Source
2247         https://bugs.webkit.org/show_bug.cgi?id=51794
2248
2249         Update scripts to point to the new location.
2250
2251         * Scripts/build-webkit:
2252         * Scripts/do-file-rename:
2253         * Scripts/do-webcore-rename:
2254         * Scripts/webkitpy/common/config/build.py:
2255         * Scripts/webkitpy/common/config/build_unittest.py:
2256
2257 2010-12-31  Kent Tamura  <tkent@chromium.org>
2258
2259         Reviewed by Eric Seidel.
2260
2261         [DRT/Chromium] Enable mock spell checker on non-OSX
2262         https://bugs.webkit.org/show_bug.cgi?id=51401
2263
2264         * DumpRenderTree/chromium/WebViewHost.cpp:
2265         (WebViewHost::spellCheck):
2266
2267 2010-12-31  Adam Barth  <abarth@webkit.org>
2268
2269         Reviewed by Ariya Hidayat.
2270
2271         Remove Tools/Scripts/wkstyle
2272         https://bugs.webkit.org/show_bug.cgi?id=51774
2273
2274         This script appears to not have been touched in a while and seems to
2275         have been replaced by check-webkit-style.
2276
2277         * Scripts/wkstyle: Removed.
2278
2279 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
2280
2281         Unreviewed. Coding style fix.
2282
2283         * DumpRenderTree/chromium/TestShell.h:
2284
2285 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
2286
2287         Reviewed by Pavel Feldman.
2288
2289         Web Inspector: [Chromium] Inspector's tests are very slow on Win(Dbg).
2290
2291         It was a problem with Chromium DRT. DevToolsAgent object instance was
2292         attached not only to the inspected page but to the DevTools window too.
2293         As result all the inspector files were interpreted as a content of inspected page
2294         and were transfered to the DevTools scripts panel for debugging etc.
2295
2296         https://bugs.webkit.org/show_bug.cgi?id=51735
2297
2298         * DumpRenderTree/chromium/TestShell.cpp:
2299         (TestShell::TestShell):
2300         (TestShell::bindJSObjectsToWindow):
2301         (TestShell::createNewWindow):
2302         * DumpRenderTree/chromium/TestShell.h:
2303
2304 2010-12-31  Adam Barth  <abarth@webkit.org>
2305
2306         Rubber-stamped by Eric Seidel.
2307
2308         Move PageLoadTests to PerformanceTests/PageLoad
2309         https://bugs.webkit.org/show_bug.cgi?id=51771
2310
2311         Update references to PageLoadTests to point to the new location.
2312
2313         * Scripts/run-pageloadtest:
2314         * Scripts/webkitpy/common/config/build.py:
2315
2316 2010-12-31  Adam Barth  <abarth@webkit.org>
2317
2318         Rubber-stamped by Eric Seidel.
2319
2320         Move SunSpider into PerformanceTests
2321         https://bugs.webkit.org/show_bug.cgi?id=51769
2322
2323         Update these scripts to point to the new location.
2324
2325         * Scripts/run-sunspider:
2326         * Scripts/sunspider-compare-results:
2327
2328 2010-12-30  Mihai Parparita  <mihaip@chromium.org>
2329
2330         Reviewed by Kent Tamura.
2331
2332         [Chromium] Add WebThemeEngineDRTMac so that Chromium DRT scrollbar rendering can match the Mac port's
2333         https://bugs.webkit.org/show_bug.cgi?id=51728
2334         
2335         Add implementation of the Mac WebThemeEngine that uses an NSScroller
2336         to render top-level scrollbars. This makes them match the Mac port's
2337         use of an NSScrollView, which means that we'll be able to share more
2338         pixel baselines.
2339         
2340         The new rendering code will not be activated until the 
2341         USE_WEB_THEME_ENGINE_TO_PAINT_THUMB #define is fliped in
2342         ScrollbarThemeChromiumMac.
2343
2344         * DumpRenderTree/DumpRenderTree.gypi:
2345         * DumpRenderTree/chromium/TestShellMac.mm:
2346         (platformInit):
2347         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Added.
2348         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Added.
2349         (+[FakeActiveWindow alwaysActiveWindow]):
2350         (+[FakeActiveWindow alwaysInactiveWindow]):
2351         (-[FakeActiveWindow initWithActiveControls:]):
2352         (-[FakeActiveWindow _hasActiveControls]):
2353         (WebThemeEngineDRTMac::paintScrollbarThumb):
2354         (stateToHIEnableState):
2355         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
2356         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
2357
2358 2010-12-30  Konstantin Tokarev  <annulen@yandex.ru>
2359
2360         Reviewed by David Kilzer.
2361
2362         [Qt] Don't build wtf/TCSystemAlloc.cpp if --system-malloc option is
2363         used
2364         https://bugs.webkit.org/show_bug.cgi?id=51672
2365
2366         * DumpRenderTree/qt/DumpRenderTree.pro: Replaced USE_SYSTEM_MALLOC
2367         with USE_SYSTEM_MALLOC=1
2368         * WebKitTestRunner/qt/WebKitTestRunner.pro: Replaced USE_SYSTEM_MALLOC
2369         with USE_SYSTEM_MALLOC=1
2370
2371 2010-12-30  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2372
2373         Reviewed by David Kilzer.
2374
2375         [Qt] [Symbian] Fix build-webkit script for Symbian
2376         https://bugs.webkit.org/show_bug.cgi?id=51509
2377
2378         Set the OUTPUT_DIR for Symbian to be the same as the source
2379         directory.
2380
2381         * Scripts/webkitdirs.pm:
2382
2383 2010-12-30  Martin Robinson  <mrobinson@igalia.com>
2384
2385         Reviewed by Darin Adler.
2386
2387         check-webkit-style should ignore NULL usage in calls to gtk_widget_style_get
2388         https://bugs.webkit.org/show_bug.cgi?id=51758
2389
2390         Add a check-webkit-style exception for gtk_widget_style_get and NULL usage.
2391
2392         * Scripts/webkitpy/style/checkers/cpp.py: Add the exception.
2393         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Add some tests for this.
2394
2395 2010-12-29  Patrick Gansterer  <paroga@webkit.org>
2396
2397         Unreviewed WinCE buildfix.
2398
2399         * WinCELauncher/main.cpp: Add missing include.
2400
2401 2010-12-29  Daniel Bates  <dbates@rim.com>
2402
2403         Reviewed by Darin Adler.
2404
2405         svn-apply updates date of wrong change log entry for a change log diff that
2406         contains two consecutive entries with the same author and date
2407         https://bugs.webkit.org/show_bug.cgi?id=46061
2408
2409         Fixes an issue where the date of the wrong change log entry may be modified.
2410         Moreover, changes fixChangeLogPatch() to move entries inserted earlier
2411         in a ChangeLog file to the top of the file.
2412
2413         Currently, fixChangeLogPatch() explicitly bails out and returns an unchanged
2414         diff when it detects that the diff inserts a change log entry earlier in a
2415         ChangeLog. It is unusual to land a patch that has such a deliberate ChangeLog
2416         change. With the advent of the commit-queue this functionality of bailing out
2417         and hence landing the patch as-is is harmful to the accuracy of the ChangeLog.
2418         Instead, we should always move the change log entry to the top of the ChangeLog file.
2419
2420         A side-effect of this change is that setChangeLogDateAndReviewer() now updates
2421         the date line of the correct change log entry in a ChangeLog diff.
2422
2423         * Scripts/VCSUtils.pm: Modified fixChangeLogPatch() to move entries inserted earlier to the top.
2424
2425         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
2426           Updated the following unit tests now that we move entries inserted earlier to the top:
2427           - "fixChangeLogPatch: New entry inserted in middle."
2428             (formerly named "fixChangeLogPatch: [no change] New entry inserted in middle.")
2429
2430           - "fixChangeLogPatch: New entry inserted earlier in the file, but after an entry with the same author and date."
2431             (formerly named "fixChangeLogPatch: [no change] New entry inserted earlier in the file, but after an entry with the same author and date.")
2432
2433         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatchThenSetChangeLogDateAndReviewer.pl: Added.
2434
2435 2010-12-29  Konstantin Tokarev  <annulen@yandex.ru>
2436
2437         Reviewed by Eric Seidel.
2438
2439         [Qt] Fixed compatibility with gold linker on X11 platforms
2440         https://bugs.webkit.org/show_bug.cgi?id=51700
2441
2442         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2443         Linked TestNetscapePlugin with libX11 on Unix platforms
2444
2445 2010-12-29  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>
2446
2447         Reviewed by Darin Adler.
2448
2449         Circular dependency in webkitpy.common.checkout.changelog module
2450         https://bugs.webkit.org/show_bug.cgi?id=50475
2451
2452         Remove automatic import of api.Checkout module when any checkout/
2453         submodule is imported (e.g.: when checkout.scm.Git is imported).
2454
2455         * Scripts/webkitpy/common/checkout/__init__.py:
2456
2457 2010-12-29  Martin Robinson  <mrobinson@igalia.com>
2458
2459         Reviewed by Ojan Vafai.
2460
2461         prepare-ChangeLog should support the -g option for specifying the git-commit
2462         https://bugs.webkit.org/show_bug.cgi?id=51708
2463
2464         Add a -g shortcut for the --git-commit prepare-ChangeLog option. This matches
2465         webkit-patch, though the exact meaning of the two options remain different.
2466
2467         * Scripts/prepare-ChangeLog: Add -g.
2468
2469 2010-12-29  Kent Hansen  <kent.hansen@nokia.com>
2470
2471         Reviewed by Simon Hausmann.
2472
2473         [Qt] Fix compilation with Qt in namespace
2474         https://bugs.webkit.org/show_bug.cgi?id=51701
2475
2476         * QtTestBrowser/webview.h:
2477
2478 2010-12-28  Daniel Bates  <dbates@rim.com>
2479
2480         Reviewed by Sam Weinig.
2481
2482         Substitute // MARK: for compiler-specific #pragma mark
2483         https://bugs.webkit.org/show_bug.cgi?id=51657
2484
2485         Fix future compilation warnings about "#pragma mark" on GTK+ bots by
2486         substituting  "// MARK:" for "#pragma mark", which provides
2487         analogous code-bookmarking functionality under Xcode.
2488
2489         Also, for consistency, we should substitute "// MARK:" for compiler-
2490         specific "#pragma mark" in the source files for the Mac port.
2491
2492         * DumpRenderTree/AccessibilityTextMarker.cpp:
2493         * DumpRenderTree/cf/WebArchiveDumpSupport.h:
2494         * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm:
2495         * DumpRenderTree/mac/ObjCController.m:
2496         * MiniBrowser/mac/AppDelegate.m:
2497         * MiniBrowser/mac/BrowserWindowController.m:
2498
2499 2010-12-28  Xan Lopez  <xlopez@igalia.com>
2500
2501         Reviewed by Eric Seidel.
2502
2503         Add --no-build option to run-sunspider
2504         https://bugs.webkit.org/show_bug.cgi?id=51658
2505
2506         * Scripts/run-sunspider: add --no-build flag to skip building
2507         phase.
2508
2509 2010-12-27  Daniel Bates  <dbates@rim.com>
2510
2511         Rubber-stamped by Martin Robinson.
2512
2513         Append the directory Tools/DumpRenderTree to the list of directories that
2514         do-webcore-rename should search so that it can rename DRT files and
2515         source code.
2516
2517         * Scripts/do-webcore-rename:
2518
2519 2010-12-27  Eric Seidel  <eric@webkit.org>
2520
2521         Reviewed by Adam Barth.
2522
2523         build-webkit should detect missing Java SDK and explain how to install it
2524         https://bugs.webkit.org/show_bug.cgi?id=51651
2525
2526         * Scripts/build-webkit:
2527
2528 2010-12-26  Martin Robinson  <mrobinson@igalia.com>
2529
2530         Reviewed by Daniel Bates.
2531
2532         [GTK] Add support for build-jsc
2533         https://bugs.webkit.org/show_bug.cgi?id=51625
2534
2535         Add GTK+ support to build-jsc now that building the jsc executable as
2536         a standalone target is easy.
2537
2538         * Scripts/build-jsc: Call buildGtkProject for the GTK+ case now.
2539         * Scripts/build-webkit: Pass in the proper target name to buildGtkProject.
2540         * Scripts/webkitdirs.pm: Actually process the project parameter in buildGtkProject
2541         and pass it along to buildAutotoolsProject.
2542
2543 2010-12-27  David Levin  <levin@chromium.org>
2544
2545         Reviewed by Eric Seidel.
2546
2547         check-webkit-style check for meaningless variable names in function declarations.
2548         https://bugs.webkit.org/show_bug.cgi?id=51523
2549
2550         * Scripts/webkitpy/style/checker.py: Exempted JavaScriptCore/jit/JITStubs.cpp
2551         from the new check and whitespace/parens because the syntax is unusual and
2552         produced a fair number of positives for these checks.
2553         * Scripts/webkitpy/style/checkers/cpp.py:
2554         (_convert_to_lower_with_underscores): Used as a canonical form for type names
2555         and parameter names when determining if the parameter name is useless.
2556         (_create_acronym): Used to check for redundant variable names in cases like "ExceptionCode ec"
2557         (Parameter.lower_with_underscores_name): Gives back the parameter name in a lower_with_underscore
2558         format.
2559         (_check_parameter_name_against_text):  Checks to see if the parameter name is in the
2560         text or an acronym of it.
2561         (check_function_definition): Checks function definitions for meaningless variable names.
2562         (process_line): Added call to check_function_definition.
2563         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2564         (CppFunctionsTest.test_convert_to_lower_with_underscores): Test for _convert_to_lower_with_underscores.
2565         (CppFunctionsTest.test_create_acronym): Test for _create_acronym.
2566         (CppFunctionsTest.test_check_parameter_against_text): Test for _check_parameter_against_text.
2567         (CppStyleTestBase.perform_single_line_lint): Removed the parameter name check
2568         because when only checking a snippet, there are a lot of bogus functions.
2569         (CppStyleTestBase.perform_multi_line_lint): Ditto and removed a bogus filter
2570         that I put there previously and just noticed.
2571         (WebKitStyleTest.test_parameter_names): Tests for the functionality -- both
2572         check_function_definition and process_line.
2573
2574 2010-12-27  Carlos Garcia Campos  <cgarcia@igalia.com>
2575
2576         Reviewed by Martin Robinson.
2577
2578         [GTK] Disable flash plugin in GtkLauncher when using gtk3
2579         https://bugs.webkit.org/show_bug.cgi?id=51591
2580
2581         Flash plugin uses gtk2 that is incompatible with gtk3 making
2582         webkit crash when it's built with gtk3.
2583
2584         * GtkLauncher/main.c:
2585         (main):
2586
2587 2010-12-25  Adam Barth  <abarth@webkit.org>
2588
2589         Reviewed by Eric Seidel.
2590
2591         Move ANGLE to Sources/ThirdParty
2592         https://bugs.webkit.org/show_bug.cgi?id=51605
2593
2594         * Scripts/build-webkit:
2595           - Point to the new ANGLE location.
2596
2597 2010-12-26  David Levin  <levin@chromium.org>
2598
2599         Reviewed by Eric Seidel.
2600
2601         check-webkit-style should be able to parse function declaration parameters.
2602         https://bugs.webkit.org/show_bug.cgi?id=51451
2603
2604         * Scripts/webkitpy/style/checkers/cpp.py:
2605         (Position.__init__): Holds simple position information (row, column).
2606         (Parameter.__init__): Holds information about a parameter.
2607         (SingleLineView.__init): Converts multiple lines into a single line for simpler searches.
2608         (SingleLineView.convert_column_to_row): Returns the original row given a column.
2609         (create_skeleton_parameters): Simplifies a parameter list for easier searching.
2610         (find_parameter_name_index): Finds where the parameter name is.
2611         (parameter_list): Generates the list of parameters for a function.
2612         (_FunctionState.begin): Added information to allow determining the parameters
2613         on demand.
2614         (_FunctionState.get_parameter_list): Returns a tuple of function parameters.
2615         (detect_functions): Improve function detection for operator functions and
2616         determine where the parameters end and pass that to _FunctionState.begin.
2617         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2618         (CppFunctionsTest.test_parameter): Verifies Parameter functionality.
2619         (CppFunctionsTest.test_single_line_view): Verifies SingleLineView functionality.
2620         (CppFunctionsTest.test_create_skeleton_parameters): Verifies create_skeleton_parameters.
2621         (CppFunctionsTest.test_find_parameter_name_index): Verifies find_parameter_name_index.
2622         (CppFunctionsTest.test_parameter_list): Does some minimal verification for parameter list.
2623         Much more thorough verification is done as part of FunctionDetectionTest.test_parameter_list.
2624         (FunctionDetectionTest.perform_function_detection): Added support for verifying
2625         the parameters found.
2626         (FunctionDetectionTest.test_function_declaration_detection): Added more function
2627         detection test to verify that we catch the operator functions.
2628         (FunctionDetectionTest.test_ignore_macros): Verify that function detection ignores macros.
2629         (FunctionDetectionTest.test_parameter_list): Added tests to verify the parameter parsing.
2630         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_bad_test_doesnt_break): Removed
2631         because the error. The test is about the bad function name. Fixing the name makes the test exactly like
2632         test_function_length_check_definition_severity1_for_test.
2633
2634 2010-12-25  Patrick Gansterer  <paroga@webkit.org>
2635
2636         Unreviewed WinCE buildfix after r74334.
2637
2638         * CMakeListsWinCE.txt:
2639
2640 2010-12-24  Sheriff Bot  <webkit.review.bot@gmail.com>
2641
2642         Unreviewed, rolling out r74632.
2643         http://trac.webkit.org/changeset/74632
2644         https://bugs.webkit.org/show_bug.cgi?id=51600
2645
2646         makes test-webkitpy hang forever on GTK (Requested by philn-tp
2647         on #webkit).
2648
2649         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
2650         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
2651
2652 2010-12-24  Ryuan Choi  <ryuan.choi@samsung.com>
2653
2654         Reviewed by Kenneth Rohde Christiansen.
2655
2656         [EFL] Screen doesn't be rendered when changing size of EWebLauncher
2657         https://bugs.webkit.org/show_bug.cgi?id=43528
2658
2659         Remove on_resize because ewk_view_fixed_layout_size_set should not be
2660         called on callback of EVAS_CALLBACK_RESIZE. As it change size of
2661         FrameView, rendering was ignored when _ewk_view_smart_calculate was
2662         called.
2663
2664         * EWebLauncher/main.c:
2665         (browserCreate):
2666
2667 2010-12-24  Eric Seidel  <eric@webkit.org>
2668
2669         Reviewed by Adam Barth.
2670
2671         webkit-patch (or a pre-commit hook) needs to prevent bad ChangeLog changes
2672         https://bugs.webkit.org/show_bug.cgi?id=28291
2673
2674         This is a start.  At least now webkit-patch will prompt when your ChangeLog looks questionable.
2675         We could do more advanced things, like parsing the ChangeLog (with changelog.py) and comparing that
2676         to strings with find in the diff.
2677         Since non-interactive always returns the default, this should cause patches with bad changelogs to fail on the commit-queue.
2678
2679         * Scripts/webkitpy/common/checkout/api.py:
2680         * Scripts/webkitpy/common/checkout/diff_parser.py:
2681         * Scripts/webkitpy/tool/steps/abstractstep.py:
2682         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
2683         * Scripts/webkitpy/tool/steps/validatechangelogs.py: Copied from Tools/Scripts/webkitpy/tool/steps/validatereviewer.py.
2684         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py: Copied from Tools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.
2685         * Scripts/webkitpy/tool/steps/validatereviewer.py:
2686
2687 2010-12-24  Dirk Pranke  <dpranke@chromium.org>
2688
2689         Reviewed by Kenneth Russell.
2690
2691         Modify new-run-webkit-tests to shut up and exit when all the threads
2692         are wedged so that test runs complete faster and we don't end up
2693         w/ enormous log files.
2694
2695         https://bugs.webkit.org/show_bug.cgi?id=51572
2696
2697         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
2698         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
2699
2700 2010-12-24  Eric Seidel  <eric@webkit.org>
2701
2702         Reviewed by David Levin.
2703
2704         commit-queue should better explain how it will re-open bugs and follow duplicate chains
2705         https://bugs.webkit.org/show_bug.cgi?id=51549
2706
2707         I've had multiple people ask me about the commit-queue's behavior
2708         regarding reporting flaky tests.  I figured it would be best to just
2709         have the queue explain itself in the bugs it files.
2710
2711         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2712         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2713
2714 2010-12-24  Shinichiro Hamaji  <hamaji@chromium.org>
2715
2716         Reviewed by Eric Seidel.
2717
2718         check-webkit-style: should ignore "wrong" namings in JavaScriptCore/qt
2719         https://bugs.webkit.org/show_bug.cgi?id=51467
2720
2721         * Scripts/webkitpy/style/checker.py:
2722         * Scripts/webkitpy/style/checker_unittest.py:
2723
2724 2010-12-23  Adam Barth  <abarth@webkit.org>
2725
2726         Rubber-stamped by Eric Seidel.
2727
2728         Move JavaScriptGlue into Sources
2729         https://bugs.webkit.org/show_bug.cgi?id=51583
2730
2731         These tools refer to JavaScriptGlue and need to be updated to its new
2732         location.
2733
2734         * Scripts/build-webkit:
2735         * Scripts/do-file-rename:
2736         * Scripts/do-webcore-rename:
2737         * Scripts/webkitpy/common/config/build.py:
2738         * Scripts/webkitpy/common/config/build_unittest.py:
2739
2740 2010-12-23  Lucas Forschler  <lforschler@apple.com>
2741
2742         Reviewed by Eric Seidel.
2743
2744         Bug 51539 - update iexploder scripts to point to new location
2745
2746         * Scripts/run-iexploder-tests:
2747         * Scripts/update-iexploder-cssproperties:
2748
2749 2010-12-23  Evan Martin  <evan@chromium.org>
2750
2751         Reviewed by Ryosuke Niwa.
2752
2753         [chromium] LayoutTestController warning in float->int conversion
2754         https://bugs.webkit.org/show_bug.cgi?id=51553
2755
2756         Rather than reading an int, converting to a float, then getting a compiler
2757         warning on passing the float to something that expects an int, instead
2758         just pass around ints.
2759
2760         No tests, fixes a compiler warning.
2761
2762         * DumpRenderTree/chromium/LayoutTestController.cpp:
2763         (parsePageSizeParameters):
2764         (LayoutTestController::pageNumberForElementById):
2765         (LayoutTestController::numberOfPages):
2766
2767 2010-12-23  Lucas Forschler  <lforschler@apple.com>
2768
2769         Reviewed by Darin Adler.
2770
2771         Bug 51537 - iexploder needs cleanup
2772         
2773         * iExploder/htdocs: Removed.
2774         * iExploder/htdocs/config.rb: Removed.
2775         * iExploder/htdocs/cssproperties.in: Removed.
2776         * iExploder/htdocs/cssvalues.in: Removed.
2777         * iExploder/htdocs/htmlattrs.in: Removed.
2778         * iExploder/htdocs/htmltags.in: Removed.
2779         * iExploder/htdocs/htmlvalues.in: Removed.
2780         * iExploder/htdocs/iexploder.cgi: Removed.
2781         * iExploder/htdocs/iexploder.rb: Removed.
2782         * iExploder/htdocs/index.html: Removed.
2783         * iExploder/htdocs/webserver.rb: Removed.
2784         * iExploder/iexploder-1.7.2/output: Removed.
2785         * iExploder/tools: Removed.
2786         * iExploder/tools/lasthit.rb: Removed.
2787         * iExploder/tools/osx_last_crash.rb: Removed.
2788         * iExploder/tools/showtest.rb: Removed.
2789
2790 2010-12-23  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
2791
2792         Reviewed by Kenneth Rohde Christiansen.
2793
2794         [EFL] Make 'single' the default backing store in EWebLauncher
2795         https://bugs.webkit.org/show_bug.cgi?id=51534
2796
2797         'single' is the simplest backing store and the one intended to be the
2798         default in the test browser. By mistake the tiled backing store was
2799         left as default in r72617.
2800
2801         * EWebLauncher/main.c:
2802         (browserCreate): ditto.
2803
2804 2010-12-23  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
2805
2806         Reviewed by Kenneth Rohde Christiansen.
2807
2808         [EFL] Subject: [webkit 4/4] [EFL] Remove non-sense workaround
2809         https://bugs.webkit.org/show_bug.cgi?id=51533
2810
2811         There's no point in concatenating env("HOME") with "blah", so remove
2812         option from EWebLauncher.
2813
2814         * EWebLauncher/main.c:
2815         (main): ditto.
2816
2817 2010-12-23  Ilya Tikhonovsky  <loislo@chromium.org>
2818
2819         Reviewed by Eric Seidel.
2820
2821         Web Inspector: chromium: inspector's tests are quite slow especially at windows(Debug).
2822
2823         Almost all inspector's tests become flaky on chromium Win(dbg) after switching to DRT.
2824         I just discovered that we have two additional GC runs per each WebViewHost.
2825         Test_shell had no such calls.
2826         These gc runs eat 15% of cpu time.
2827
2828         https://bugs.webkit.org/show_bug.cgi?id=51479
2829
2830         * DumpRenderTree/chromium/WebViewHost.cpp:
2831         (WebViewHost::~WebViewHost):
2832
2833 2010-12-22  Dirk Pranke  <dpranke@chromium.org>
2834
2835         Reviewed by Ojan Vafai.
2836
2837         This change splits out the TestRunner class into its own file.
2838         When we fork the code for message passing, we will create a new
2839         TestRunner, and this change will allow that to be more modular.
2840
2841         While we're at it, split out TestInput and ResultSummary into
2842         their own files, to reduce the size of run_webkit_tests to
2843         something more managable.
2844
2845         https://bugs.webkit.org/show_bug.cgi?id=51092
2846
2847         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2848         * Scripts/webkitpy/layout_tests/layout_package/result_summary.py:
2849         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2850         * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
2851         * Scripts/webkitpy/layout_tests/layout_package/test_input.py:
2852         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2853         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2854
2855  2010-12-22  Dirk Pranke  <dpranke@chromium.org>
2856
2857         Reviewed by Ojan Vafai.
2858
2859         nrwt multiprocessing - start over, prepare to fork the code
2860  
2861         This code cleans up the signatures and implementation of the
2862         TestRunner class so we can easily fork it to run either the
2863         stable implementation or the new, unstable message-passing
2864         implementation. The two variants will have different
2865         implementations of the run_tests() method. We will switch
2866         between the two based on the setting for the '--worker-model'
2867         switch. We rename the two currently valid values to 'old-inline'
2868         and 'old-threads'.
2869
2870         https://bugs.webkit.org/show_bug.cgi?id=51081
2871
2872         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2873         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2874
2875 2010-12-22  Victor Wang  <victorw@chromium.org>
2876
2877         Reviewed by Darin Fisher.
2878
2879         [Chromium] Update chromium archive test result url in rebaseline script.
2880
2881         https://bugs.webkit.org/show_bug.cgi?id=51503
2882
2883         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2884
2885 2010-12-22  Lucas Forschler  <lforschler@apple.com>
2886
2887         Reviewed by Alice Liu.
2888
2889         <rdar://problem/8633222> record-memory-win needs to record memory used by the webprocess.
2890         Verified on Chrome, Safari, and IE.
2891         With this change, we will record memory from a parent browser window and all child processes.
2892
2893         * record-memory-win/main.cpp:
2894         (ProcessArgs):
2895         (PrintUsage):
2896         (getMemoryInfo):
2897         (printProcessInfo):
2898         (evalProcesses):
2899         (UseImage):
2900         (QueryContinuously):
2901         (ElapsedTime):
2902
2903 2010-12-22  Lucas Forschler  <lforschler@apple.com>
2904
2905         Unreviewed rollout r74489, because it was missing changelog.
2906
2907         * record-memory-win/main.cpp:
2908         
2909 2010-12-22  Ryosuke Niwa  <rniwa@webkit.org>
2910
2911         Adding myself as a reviewer.
2912
2913         * Scripts/webkitpy/common/config/committers.py:
2914
2915 2010-12-22  Andrew Scherkus  <scherkus@chromium.org>
2916
2917         Unreviewed.  Adding myself to committers.py.
2918
2919         * Scripts/webkitpy/common/config/committers.py:
2920
2921 2010-12-22  Ariya Hidayat  <ariya@sencha.com>
2922
2923         Reviewed by Kenneth Rohde Christiansen.
2924
2925         TestNetscapePlugIn should use #if defined
2926         https://bugs.webkit.org/show_bug.cgi?id=51471
2927
2928         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2929         (NP_Initialize):
2930         (NPP_New):
2931
2932 2010-12-22  Ilya Tikhonovsky  <loislo@chromium.org>
2933
2934         Reviewed by Yury Semikhatsky.
2935
2936         Web Inspector: [chromium] DRT inspector layout tests are flaky in debug.
2937
2938         DevTools window should be closed explicitly because it has custom deinitialization code.
2939
2940         https://bugs.webkit.org/show_bug.cgi?id=50722
2941
2942         * DumpRenderTree/chromium/TestShell.cpp:
2943         (TestShell::closeRemainingWindows):
2944
2945 2010-12-22  David Levin  <levin@chromium.org>
2946
2947         Reviewed by Shinichiro Hamaji.
2948
2949         check-webkit-style shouldn't complaint about underscores in variables in objective C files.
2950         https://bugs.webkit.org/show_bug.cgi?id=51452
2951
2952         * Scripts/webkitpy/style/checkers/cpp.py:
2953         (_FileState.__init__): Added the information to determine if a file is C or Objective C.
2954         Using the file extension if possible but falling back to the file contents if we have a header file.
2955         (_FileState.is_objective_c): Determine if we have an Objective C by examining the file contents if needed.
2956         (_FileState.is_c_or_objective_c):
2957         (check_using_std): Changed to using _FileState to determine the file type.
2958         (check_max_min_macros): Ditto.
2959         (check_for_null): Ditto.
2960         (check_style): Changed the parameters to various calls since they now need _FileState
2961         to determine the file type.
2962         (check_language): Added the file_state parameter so it could be passed
2963         to check_identifier_name_in_declaration.
2964         (check_identifier_name_in_declaration): Don't warn about underscores in variables if
2965         this is an Objective C file.
2966         (_process_lines): Added information for the _FileState constructor (and moved the
2967         call to a place that had the information).
2968         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2969         (CppFunctionsTest.test_is_c_or_objective_c): Changed the tests to use FileState and exercise
2970         its functionality.
2971         (WebKitStyleTest.test_names): Add tests for underscores in Objective C files.
2972
2973 2010-12-21  Andy Estes  <aestes@apple.com>
2974
2975         Reviewed by Mark Rowe.
2976
2977         Do not build non-Intel architectures for WebKit2-related projects.
2978         https://bugs.webkit.org/show_bug.cgi?id=51440
2979
2980         * MiniBrowser/Configurations/Base.xcconfig: Only build for i386 and x86_64.
2981         * TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
2982         * WebKitTestRunner/Configurations/Base.xcconfig: Ditto.
2983
2984 2010-12-21  Mihai Parparita  <mihaip@chromium.org>
2985
2986         Reviewed by Darin Fisher.
2987
2988         [Chromium] Rename WebThemeEngine/ControlDRT to WebThemeEngine/ControlDRTWin
2989         https://bugs.webkit.org/show_bug.cgi?id=51406 
2990         
2991         Rename WebThemeControlDRT to WebThemeControlDRTWin and WebThemeEngineDRT
2992         to WebThemeEngineDRTWin and update references everywhere.
2993
2994         * DumpRenderTree/DumpRenderTree.gypi:
2995         * DumpRenderTree/chromium/TestShellWin.cpp:
2996         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRT.cpp.
2997         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRT.h.
2998         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRT.cpp.
2999         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRT.h.
3000
3001 2010-12-21  Anders Carlsson  <andersca@apple.com>
3002
3003         Reviewed by John Sullivan.
3004
3005         Clicking missing plug-in text does not show a sheet
3006         https://bugs.webkit.org/show_bug.cgi?id=51403
3007
3008         Update for changes to the WebPageUIClient.
3009
3010         * MiniBrowser/mac/BrowserWindowController.m:
3011         (-[BrowserWindowController awakeFromNib]):
3012         * WebKitTestRunner/TestController.cpp:
3013         (WTR::createOtherPage):
3014         (WTR::TestController::initialize):
3015
3016 2010-12-21  Eric Seidel  <eric@webkit.org>
3017
3018         Reviewed by Adam Barth.
3019
3020         commit-queue will report constant failures as flaky if other tests flake
3021         https://bugs.webkit.org/show_bug.cgi?id=51272
3022
3023         This patch just removes functionality and adds testing.
3024         Previously we attempted to report flaky tests when we had
3025         two different tests fail in a row.  However, since we stop
3026         running the tests at the first failure, our code was wrong in
3027         trying to determine flakiness from the incomplete runs.
3028
3029         Originally I posted an alternate patch:
3030         https://bug-51272-attachments.webkit.org/attachment.cgi?id=77078
3031         which fixed our flaky logic in this case, however it was decided
3032         that that patch would be too difficult to maintain, so now
3033         I'm just removing the broken logic.
3034
3035         This will dramatically cut-down on our flaky-test false positives
3036         at the (small) cost of the queues being unable to report
3037         any flakiness if the tree is very flaky.  (With at least one test
3038         flaking on every run, we'll never report failures anymore.)  I think
3039         this is a tradeoff worth making.
3040
3041         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3042         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3043
3044 2010-12-20  Eric Seidel  <eric@webkit.org>
3045
3046         Reviewed by Adam Barth.
3047
3048         commit-queue wrongly rejects patches when it can't update itself
3049         https://bugs.webkit.org/show_bug.cgi?id=46636
3050
3051         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3052         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3053         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3054
3055 2010-12-20  Adam Barth  <abarth@webkit.org>
3056
3057         Move web sites to Websites directory
3058         https://bugs.webkit.org/show_bug.cgi?id=51323
3059
3060         Update references to BugsSite to point to the new location.
3061
3062         This patch was never officially reviewed (because it was too large to
3063         upload to bugs.webkit.org), but it was discussed on webkit-dev and Mark
3064         Rowe gave me the green light.
3065
3066         * Scripts/old-run-webkit-tests:
3067         * Scripts/webkitpy/common/config/build.py:
3068         * Scripts/webkitpy/common/config/build_unittest.py:
3069         * Scripts/webkitpy/common/prettypatch.py:
3070         * Scripts/webkitpy/layout_tests/port/base.py:
3071         * Scripts/webkitpy/style/main.py:
3072
3073 2010-12-20  Adrienne Walker  <enne@google.com>
3074
3075         Unreviewed. Adding myself to the list of committers.
3076
3077         * webkitpy/common/config/committers.py:
3078
3079 2010-12-20  Mark Rowe  <mrowe@apple.com>
3080
3081         Reviewed by Dan Bernstein.
3082
3083         <rdar://problem/8757601> Don't install header files in to the Resources directory.
3084
3085         * Scripts/check-for-inappropriate-files-in-framework: Don't allow .h files in the
3086         Resources directory.
3087
3088 2010-12-20  Eric Seidel  <eric@webkit.org>
3089
3090         Reviewed by Adam Barth.
3091
3092         commit-queue should include bot id when attaching failure diffs
3093         https://bugs.webkit.org/show_bug.cgi?id=51280
3094
3095         This is a tiny change to include the bot id in the name of the attachment.
3096         Most of this diff is just changing the unit test expectations
3097         now that I hid the comment printing when the comment is None.
3098
3099         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3100         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3101         * Scripts/webkitpy/tool/commands/upload_unittest.py:
3102         * Scripts/webkitpy/tool/mocktool.py:
3103
3104 2010-12-20  Jeff Miller  <jeffm@apple.com>
3105
3106         Reviewed by Dan Bernstein.
3107
3108         Tools/vcbin/midl.exe needs to be rebuilt
3109         https://bugs.webkit.org/show_bug.cgi?id=51347
3110
3111         * vcbin/midl.exe: Rebuilt.
3112
3113 2010-12-20  David Levin  <levin@chromium.org>
3114
3115         Reviewed by Ariya Hidayat.
3116
3117         .gitignore and webkit-tools-completion.sh have references to WebKitTools that should be Tools.
3118         https://bugs.webkit.org/show_bug.cgi?id=51343
3119
3120         Follow up from the WebKitTools -> Tools rename.
3121
3122         * Scripts/webkit-tools-completion.sh:
3123
3124 2010-12-20  Cosmin Truta  <ctruta@chromium.org>
3125
3126         Reviewed by James Robinson.
3127
3128         new-run-webkit-tests ignores trailing EOL differences in text tests
3129         https://bugs.webkit.org/show_bug.cgi?id=36983
3130
3131         Changed the handling of new-line characters within new-run-webkit-tests
3132         to match old-run-webkit-tests.  Differences in leading and trailing empty
3133         lines in text expectation files are no longer ignored.
3134
3135         * Scripts/webkitpy/layout_tests/port/base.py:
3136         * Scripts/webkitpy/layout_tests/port/test.py:
3137         Added unit tests.  Removed old duplicate unit test entries.
3138         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
3139
3140 2010-12-20  David Levin  <levin@chromium.org>
3141
3142         Reviewed by Shinichiro Hamaji.
3143
3144         check-webkit-style should detect function declarations (and trivial functions).
3145         https://bugs.webkit.org/show_bug.cgi?id=51303
3146
3147         * Scripts/webkitpy/style/checkers/cpp.py:
3148         (_FunctionState.begin): Add is_declaration and changed the line count
3149         start to begin at -1 (which will keep the results consistent, since
3150         the starting line number passed in is one less in this change).
3151         (detect_functions): changed function detection to now catch trivial
3152         functions and declarations.
3153         (check_pass_ptr_usage): Don't check for Pass*Ptr on the first line
3154         of the function as this may look at return values (when processing
3155         a declaration).
3156         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3157         (FunctionDetectionTest.perform_function_detection): Basic mechanics
3158         of testing the function detection.
3159         (FunctionDetectionTest.test_basic_function_detection): Test a simple
3160         function.
3161         (FunctionDetectionTest.test_function_declaration_detection): Test a
3162         declaration.
3163         (FunctionDetectionTest.test_non_functions): A test case for a case
3164         that caused the code to fail due to the { being in quotes.
3165         (PassPtrTest.test_pass_ref_ptr_return_value): Added some more test
3166         cases to help catch false alarms for return values.
3167         (PassPtrTest.test_pass_ref_ptr_member_variable): Ensure that
3168         we don't get false alarms for member variables either.
3169
3170 2010-12-20  Ryuan Choi  <ryuan.choi@samsung.com>
3171
3172         Reviewed by Antonio Gomes.
3173
3174         [CMAKE] Rename WEBKITTOOLS_DIR to TOOLS_DIR
3175         https://bugs.webkit.org/show_bug.cgi?id=51319
3176
3177         * CMakeListsEfl.txt:
3178
3179 2010-12-18  Adam Barth  <abarth@webkit.org>
3180
3181         Reviewed by Sam Weinig.
3182
3183         Move WebKitExamplePlugins to Examples
3184         https://bugs.webkit.org/show_bug.cgi?id=51291
3185
3186         * Scripts/webkitpy/common/config/build.py:
3187
3188 2010-12-17  Csaba Osztrogonác  <ossy@webkit.org>
3189
3190         Unreviewed Qt buildfix after r74301.
3191
3192         Rename WebKitTools to Tools
3193         https://bugs.webkit.org/show_bug.cgi?id=49861
3194
3195         * MiniBrowser/DerivedSources.pro:
3196         * MiniBrowser/qt/MiniBrowser.pro:
3197
3198 2010-12-17  Dan Bernstein  <mitz@apple.com>
3199
3200         Reviewed by Simon Fraser.
3201
3202         Rename WebKitTools to Tools
3203         https://bugs.webkit.org/show_bug.cgi?id=49861
3204
3205         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3206         * CodeCoverage/README:
3207         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3208         (WebCore::DumpRenderTree::initializeFonts):
3209         * EWSTools/start-commit-queue.sh:
3210         * EWSTools/start-queue.sh:
3211         * GNUmakefile.am:
3212         * MIDLWrapper/MIDLWrapper.cpp:
3213         (wmain):
3214         * MiniBrowser/qt/MiniBrowser.pro:
3215         * Scripts/build-api-tests:
3216         * Scripts/build-dumprendertree:
3217         * Scripts/build-webkit:
3218         * Scripts/build-webkittestrunner:
3219         * Scripts/generate-coverage-data:
3220         * Scripts/old-run-webkit-tests:
3221         * Scripts/run-api-tests:
3222         * Scripts/run-iexploder-tests:
3223         * Scripts/run-javascriptcore-tests:
3224         * Scripts/run-mangleme-tests:
3225         * Scripts/run-sunspider:
3226         * Scripts/run-webkit-websocketserver:
3227         * Scripts/sunspider-compare-results:
3228         * Scripts/test-webkitperl:
3229         * Scripts/test-webkitpy:
3230         * Scripts/update-iexploder-cssproperties:
3231         * Scripts/update-webkit:
3232         * Scripts/update-webkit-localizable-strings:
3233         * Scripts/webkitdirs.pm:
3234         * Scripts/webkitpy/common/checkout/scm.py:
3235         * Scripts/webkitpy/common/checkout/scm_unittest.py:
3236         * Scripts/webkitpy/common/config/committervalidator.py:
3237         * Scripts/webkitpy/common/config/committervalidator_unittest.py:
3238         * Scripts/webkitpy/common/config/ports.py:
3239         * Scripts/webkitpy/common/config/ports_unittest.py:
3240         * Scripts/webkitpy/common/system/logutils_unittest.py:
3241         * Scripts/webkitpy/common/system/ospath_unittest.py:
3242         * Scripts/webkitpy/layout_tests/port/chromium.py:
3243         * Scripts/webkitpy/layout_tests/port/config.py:
3244         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
3245         * Scripts/webkitpy/layout_tests/port/http_server.py:
3246         * Scripts/webkitpy/layout_tests/port/test.py:
3247         * Scripts/webkitpy/style/checker.py:
3248         * Scripts/webkitpy/style/checker_unittest.py:
3249         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
3250         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3251         * Scripts/webkitpy/tool/steps/steps_unittest.py:
3252         * WebKitTestRunner/DerivedSources.pro:
3253         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
3254         (WTR::activateFonts):
3255         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3256         * wx/build/build_utils.py:
3257
3258 2010-12-16  Antonio Gomes  <agomes@rim.com>
3259
3260         Reviewed by Martin Robinson.
3261
3262         Settings::editingBehaviorType() incorrectly returns mac for the gtk build when running tests
3263         https://bugs.webkit.org/show_bug.cgi?id=51163
3264
3265         Since GTK+'s default editing behavior was changed to UNIX in r70975 (see webkitwebsettings.cpp),
3266         GTK+'s DRT should also reset to UNIX after each test execution.
3267
3268         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3269         (resetDefaultsToConsistentValues):
3270
3271 2010-12-17  David Levin  <levin@chromium.org>
3272
3273         Reviewed by Eric Seidel.
3274
3275         check-webkit-style should understand WTF #include guards
3276         https://bugs.webkit.org/show_bug.cgi?id=44911
3277
3278         * Scripts/webkitpy/style/checkers/cpp.py:
3279         (get_header_guard_cpp_variable): modify to suggest the WTF style
3280         of header guard when appropriate.
3281         (check_for_header_guard): handle multiple return values from
3282         get_header_guard_cpp_variable
3283         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3284         (CppStyleTest.test_build_header_guard): Added tests for the WTF
3285         header style.
3286
3287 2010-12-16  David Levin  <levin@chromium.org>
3288
3289         Reviewed by Eric Seidel.
3290
3291         test-webkitpy: unittest for the xml.py checker displays a decprecation warning.
3292         https://bugs.webkit.org/show_bug.cgi?id=51210
3293
3294         The error only shows up when using python 2.6 or later.
3295
3296         * Scripts/webkitpy/style/checkers/xml.py: Replace the usage of
3297         the decprecated field error,message with something equivalent.
3298
3299 2010-12-16  Mihai Parparita  <mihaip@chromium.org>
3300
3301         Reviewed by Eric Seidel.
3302
3303         Add --exit-after-n-failures/crashes to NRWT
3304         https://bugs.webkit.org/show_bug.cgi?id=51160
3305         
3306         Abort test run (in a similar way to how control-C is handled) when
3307         --exit-after-n-failures/crashes-or-timeouts are passed and we've reached
3308         that number of unexpected failures/crashes/timeouts.
3309
3310         * Scripts/webkitpy/layout_tests/port/test.py:
3311         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3312         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3313
3314 2010-12-16  David Levin  <levin@chromium.org>
3315
3316         Reviewed by Shinichiro Hamaji.
3317
3318         check-webkit-style unit tests has some duplicate boilerplate code.
3319         https://bugs.webkit.org/show_bug.cgi?id=49519
3320
3321         * Scripts/webkitpy/style/checkers/cpp.py:
3322         (update_include_state): Replaced the "io" parameter with the global
3323         configuration _unit_test_config. This allowed not calling into
3324         functions at a low level and also not plumbing through the injection
3325         information through many levels of code.
3326         (check_for_include_what_you_use): Ditto.
3327         (process_file_data): Added the ability to set up the unit test config
3328         to allow for injection.
3329         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3330         (ErrorCollector.__init__): Added support for having a filter for errors.
3331         (ErrorCollector.__call__): Ditto.
3332         (CppStyleTestBase.process_file_data): Added the ability to set unit_test_config.
3333         (CppStyleTestBase.perform_lint): Consolidated logic for the perform functions.
3334         (CppStyleTestBase.perform_single_line_lint): Replace specific calls to
3335         functions in the cpp.py with generic processing and a filter that
3336         indicates what errors should be kept.
3337         (CppStyleTestBase.perform_multi_line_lint): Ditto.
3338         (CppStyleTestBase.perform_language_rules_check): Ditto.
3339         (CppStyleTestBase.perform_function_lengths_check): Ditto.
3340         (CppStyleTestBase.perform_pass_ptr_check): Ditto.
3341         (CppStyleTestBase.perform_include_what_you_use): Ditto.
3342         (CppStyleTest.test_multi_line_comments): Added another
3343         error message which applies to the test case.
3344         (CppStyleTest.test_spacing_for_binary_ops): Fixed test
3345         to not have config.h, since it is processed as a header file.
3346         (CppStyleTest.test_static_or_global_stlstrings): Fixed variable name
3347         style and indentation in checked code.
3348         (OrderOfIncludesTest.test_check_preprocessor_in_include_section):
3349         Fixed line number.
3350         (NoNonVirtualDestructorsTest.test_multi_line_declaration_with_error):
3351         Ditto.
3352
3353 2010-12-15  Sheriff Bot  <webkit.review.bot@gmail.com>
3354
3355         Unreviewed, rolling out r74136.
3356         http://trac.webkit.org/changeset/74136
3357         https://bugs.webkit.org/show_bug.cgi?id=51135
3358
3359         r74136 breaks chromium canary bots because some tests are not
3360         rebaselined correctly to resolve EOL differences (Requested by
3361         jianli on #webkit).
3362
3363         * Scripts/webkitpy/layout_tests/port/base.py:
3364         * Scripts/webkitpy/layout_tests/port/test.py:
3365         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
3366
3367 2010-12-15  Adam Roben  <aroben@apple.com>
3368
3369         Teach check-webkit-style to check .vcproj and .vsprops files for XML
3370         syntax errors
3371
3372         Fixes <http://webkit.org/b/51103> check-webkit-style should check for
3373         XML syntax errors in .vcproj/.vsprops files
3374
3375         Reviewed by Dave Levin.
3376
3377         * Scripts/webkitpy/style/checker.py: Added lists of file extensions
3378         that should be treated as XML and that should be allowed to contain
3379         carriage returns. (These lists happen to be identical currently.)
3380         (FileType): Added a new XML type.
3381         (CheckerDispatcher.should_check_and_strip_carriage_returns): Added.
3382         Just does a simple file extension check.
3383         (CheckerDispatcher._file_type): Added a case for XML files.
3384         (CheckerDispatcher._create_checker): Ditto. We use XMLChecker for XML
3385         files (surprise!).
3386         (StyleProcessor.process): Ask the dispatcher whether we should pass the
3387         lines through the carriage checker.
3388
3389         * Scripts/webkitpy/style/checker_unittest.py:
3390         (CheckerDispatcherCarriageReturnTest.test_should_check_and_strip_carriage_returns):
3391         Added. Checks a few file names to see if carriage returns are allowed
3392         or not.
3393         (CheckerDispatcherDispatchTest.assert_checker_xml): Added. Similar to
3394         other assert_checker_* functions.
3395         (CheckerDispatcherDispatchTest.test_xml_paths): Added. Similar to other
3396         test_*_paths functions.
3397         (CheckerDispatcherDispatchTest.test_xml_paths): Added. Similar to other
3398         test_*_paths functions.
3399         (CheckerDispatcherDispatchTest.test_none_paths): Removed the vcproj
3400         file from this test case, as vcproj files now have a type.
3401         (StyleProcessor_CodeCoverageTest.MockDispatcher.should_check_and_strip_carriage_returns):
3402         Added. Similar to the other should_* functions.
3403         (StyleProcessor_CodeCoverageTest.test_process__carriage_returns_not_stripped):
3404         Added. Checks that carriage returns aren't checked for or stripped for
3405         allowed files.
3406
3407         * Scripts/webkitpy/style/checkers/xml.py: Added.
3408         (XMLChecker.__init__): Simple init method.
3409         (XMLChecker.check): Pass each line through the expat parser, and record
3410         a style error for any errors thrown by the parser.
3411
3412         * Scripts/webkitpy/style/checkers/xml_unittest.py: Added.
3413         (XMLCheckerTest.assert_no_error): Checks that the given XML does not
3414         produce a style error.
3415         (XMLCheckerTest.assert_error): Checks that the given XML produces an
3416         error of the given category on the given line.
3417         (XMLCheckerTest.mock_handle_style_error): Does nothing. Used for
3418         checking that the XMLChecker constructor works properly.
3419         (XMLCheckerTest.test_conflict_marker): Tests that conflict markers
3420         cause a style error (see, e.g., r73887).
3421         (XMLCheckerTest.test_extra_closing_tag): Tests that extra closing tags
3422         cause a style error (see, e.g., r73773).
3423         (XMLCheckerTest.test_init): Tests that the XMLChecker constructor works
3424         properly.
3425         (XMLCheckerTest.test_missing_closing_tag): Tests that missing closing
3426         tags cause a style error (see, e.g., r72795).
3427         (XMLCheckerTest.test_no_error): Tests that valid XML does not cause a
3428         style error.
3429
3430 2010-12-15  Lucas Forschler  <lforschler@apple.com>
3431
3432         Reviewed by Stephanie Lewis.
3433
3434         https://bugs.webkit.org/show_bug.cgi?id=51117
3435         Add a new leopard test bot
3436         really really commit to trunk this time.
3437
3438         * BuildSlaveSupport/build.webkit.org-config/config.json:
3439
3440 2010-12-15  Sam Weinig  <sam@webkit.org>
3441
3442         Reviewed by Anders Carlsson.
3443
3444         WebKit2: Can't add files to an <input type=file>
3445         https://bugs.webkit.org/show_bug.cgi?id=51087
3446
3447         * MiniBrowser/mac/BrowserWindowController.m:
3448         (runOpenPanel):
3449         (-[BrowserWindowController awakeFromNib]):
3450         Add simple implementation of runOpenPanel callback.
3451
3452         * MiniBrowser/win/BrowserView.cpp:
3453         (BrowserView::create):
3454         * WebKitTestRunner/TestController.cpp:
3455         (WTR::createOtherPage):
3456         (WTR::TestController::initialize):
3457         Stub out runOpenPanel callback. 
3458
3459 2010-12-14  Eric Seidel  <eric@webkit.org>
3460
3461         Reviewed by Adam Barth.
3462
3463         commit-queue should upload failure diffs when tests flake
3464         https://bugs.webkit.org/show_bug.cgi?id=51051
3465
3466         To make this testable I needed to pipe FileSystem down onto tool.
3467         We've wanted it there for a long time anyway.
3468
3469         This patch is kinda a big hack.  But we don't have a nice
3470         way to read results.html files.  I think this will need further
3471         revision before this code actually feels clean.
3472
3473         As part of testing this change, I had to make MockBugzilla.create_bug
3474         actually return an id (like it should) which required updating
3475         a few other unit test results (for the better).
3476
3477         The results_matching_keys change in layouttestresults/rebasline
3478         was an alternate path which I decided not to use in the end, but
3479         I left the change as it seemed an improvement.
3480
3481         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3482         * Scripts/webkitpy/common/net/layouttestresults.py:
3483         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3484         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3485         * Scripts/webkitpy/tool/commands/queues.py:
3486         * Scripts/webkitpy/tool/commands/rebaseline.py:
3487         * Scripts/webkitpy/tool/main.py:
3488         * Scripts/webkitpy/tool/mocktool.py:
3489
3490 2010-12-15  Cosmin Truta  <ctruta@chromium.org>
3491
3492         Reviewed by James Robinson.
3493
3494         new-run-webkit-tests ignores trailing EOL differences in text tests
3495         https://bugs.webkit.org/show_bug.cgi?id=36983
3496
3497         Changed the handling of new-line characters within new-run-webkit-tests
3498         to match old-run-webkit-tests.  Differences in leading and trailing empty
3499         lines in text expectation files are no longer ignored.
3500
3501         * Scripts/webkitpy/layout_tests/port/base.py:
3502         * Scripts/webkitpy/layout_tests/port/test.py:
3503         Added unit tests.  Removed old duplicate unit test entries.
3504         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
3505
3506 2010-12-15  Ojan Vafai  <ojan@chromium.org>
3507
3508         Reviewed by Adam Barth.
3509
3510         make status-bubble white-space:nowrap so we can measure it's width without wrapping
3511         https://bugs.webkit.org/show_bug.cgi?id=51149
3512
3513         * QueueStatusServer/templates/statusbubble.html:
3514
3515 2010-12-15  Ojan Vafai  <ojan@chromium.org>
3516
3517         Reviewed by Adam Barth.
3518
3519         have the statusbubble postMessage it's metrics so that embedders can properly size the iframe
3520         https://bugs.webkit.org/show_bug.cgi?id=51125
3521
3522         * QueueStatusServer/templates/statusbubble.html:
3523
3524 2010-12-15  Darin Adler  <darin@apple.com>
3525
3526         * Scripts/webkitpy/common/net/buildbot: Added property svn:ignore.
3527
3528 2010-12-15  Sheriff Bot  <webkit.review.bot@gmail.com>
3529
3530         Unreviewed, rolling out r74117.
3531         http://trac.webkit.org/changeset/74117
3532         https://bugs.webkit.org/show_bug.cgi?id=51113
3533
3534         This broke the GTK1 build. (Requested by mrobinson on
3535         #webkit).
3536
3537         * Scripts/webkitdirs.pm:
3538
3539 2010-12-15  Amruth Raj  <amruthraj@motorola.com> and Ravi Kasibhatla  <ravi.kasibhatla@motorola.com>
3540
3541         Reviewed by Martin Robinson.
3542
3543         Change generate-forwarding-headers.pl for GTK port usage 
3544         (https://bugs.webkit.org/show_bug.cgi?id=37369)
3545
3546         * Scripts/webkitdirs.pm: Added changes to build webkit2 for GTK port using build-webkit script.
3547
3548 2010-12-14  Kent Tamura  <tkent@chromium.org>
3549
3550         Reviewed by Jian Li.
3551
3552         [DRT/Chromium] Remove another unnecessary error message
3553         https://bugs.webkit.org/show_bug.cgi?id=51083
3554
3555         * DumpRenderTree/chromium/WebViewHost.cpp:
3556         (WebViewHost::didInvalidateRect):
3557
3558 2010-12-14  Lucas Forschler  <lforschler@apple.com>
3559
3560         Reviewed by Stephanie Lewis.
3561
3562         Add a new Leopard Debug Test WK2 Bot
3563
3564         * BuildSlaveSupport/build.webkit.org-config/config.json:
3565
3566 2010-12-14  Ojan Vafai  <ojan@chromium.org>
3567
3568         Fix python unittests after http://trac.webkit.org/changeset/74070.
3569
3570         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
3571
3572 2010-12-14  Kent Tamura  <tkent@chromium.org>
3573
3574         Reviewed by Jian Li.
3575
3576         [DRT/Chromium] Remove a unnecessary error message
3577         https://bugs.webkit.org/show_bug.cgi?id=51069
3578
3579         * DumpRenderTree/chromium/WebViewHost.cpp:
3580         (WebViewHost::paintInvalidatedRegion):
3581
3582 2010-12-14  Benjamin Kalman  <kalman@chromium.org>
3583
3584         Reviewed by Ojan Vafai.
3585
3586         Using BUG/BUGWK in test_expectations is error prone, should use BUGCR/BUGWK
3587         https://bugs.webkit.org/show_bug.cgi?id=48926
3588
3589         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
3590         Add presubmit check that BUG isn't used, either BUGCR/BUGWK/BUGV8_.
3591
3592 2010-12-14  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3593
3594         Reviewed by Eric Seidel.
3595
3596         [Qt] [Symbian] Do not use pkg-config on Symbian as it is not supported
3597         https://bugs.webkit.org/show_bug.cgi?id=50231
3598
3599         Guard CONFIG+=link_pkgconfig with !symbian.
3600
3601         * DumpRenderTree/qt/DumpRenderTree.pro:
3602         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3603         * WebKitTestRunner/qt/WebKitTestRunner.pro:
3604
3605 2010-12-14  Philippe Normand  <pnormand@igalia.com>
3606
3607         Reviewed by Ojan Vafai.
3608
3609         [new-run-webkit-tests] expectations parsing is slow
3610         https://bugs.webkit.org/show_bug.cgi?id=50635
3611
3612         Avoid expensive iteration of all the tests when checking if a test
3613         file is to be skipped or not.
3614
3615         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
3616         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
3617         * Scripts/webkitpy/layout_tests/port/test.py:
3618
3619 2010-12-14  Mario Sanchez Prada  <msanchez@igalia.com>
3620
3621         Reviewed by Xan Lopez.
3622
3623         [Gtk] Implement STATE_FOCUSED, STATE_FOCUSABLE, and corresponding events for text objects
3624         https://bugs.webkit.org/show_bug.cgi?id=27048
3625
3626         Add support in DRT for checking whether an accessibility UI
3627         element is focusable and/or focused. Implemented for GTK.
3628
3629         * DumpRenderTree/AccessibilityUIElement.cpp:
3630         (getIsFocusedCallback): New.
3631         (getIsFocusableCallback): New.
3632         (AccessibilityUIElement::getJSClass): Add the new available
3633         callbacks for isFocused and isFocusable.
3634         * DumpRenderTree/AccessibilityUIElement.h:
3635         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3636         (AccessibilityUIElement::isFocused): New, implemented by checking
3637         whether the related AtkState value is in the object's state set.
3638         (AccessibilityUIElement::isFocusable): Ditto.
3639         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3640         (AccessibilityUIElement::isFocused): New, dummy implementation.
3641         (AccessibilityUIElement::isFocusable): Ditto.
3642         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3643         (AccessibilityUIElement::isFocused): Ditto.
3644         (AccessibilityUIElement::isFocusable): Ditto.
3645
3646 2010-12-14  Eric Seidel  <eric@webkit.org>
3647
3648         Reviewed by Ojan Vafai.
3649
3650         webkit-patch should warn users when they're using a 32-bit git on a 64-bit system
3651         https://bugs.webkit.org/show_bug.cgi?id=50715
3652
3653         This patch makes webkit-patch print the following:
3654
3655         Warning: This machine is 64-bit, but the git binary (/usr/local/git/bin/git) does not support 64-bit.
3656         Install a 64-bit git for better performance, see:
3657         https://lists.webkit.org/pipermail/webkit-dev/2010-December/015249.html
3658
3659         I wrote this mostly because I have approximately 8 machines that I use
3660         and making sure each one is using a good Git install seemed folly.
3661         webkit-patch makes a lot of git calls, so using a fast git can shave
3662         several seconds in every invocation.  See the webkit-dev thread for more info.
3663
3664         This message will print twice during 'webkit-patch upload',
3665         once from webkit-patch and once from check-webkit-style.
3666
3667         Unfortunately there is no good way to test this due to how machine-dependent
3668         the code is.  I considered writing a test for the log message, but it seemed not worth it.
3669
3670         * Scripts/webkitpy/common/checkout/scm.py:
3671
3672 2010-12-13  Eric Seidel  <eric@webkit.org>
3673
3674         Reviewed by Adam Barth.
3675
3676         FlakyTestReporter doesn't understand bots running from multiple email addresses
3677         https://bugs.webkit.org/show_bug.cgi?id=50960
3678
3679         This explains at least one of the dupes of:
3680         https://bugs.webkit.org/show_bug.cgi?id=50863
3681         that we saw filed by the commit-queue this morning.
3682         I think the other one was explained by my previous fix to result counting code.
3683
3684         Since this is really hard to test with a unit test, instead I
3685         create a new (possibly useful in the future) command
3686         which given a layout test path will return you
3687         the one bug which our tools would assume it the flaky test bug.
3688         If some other script wants to use bug-for-test we'll
3689         need to extend it with some options like --create-if-missing or similar.
3690
3691         * Scripts/webkitpy/common/net/bugzilla/bug.py:
3692         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3693         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3694         * Scripts/webkitpy/tool/commands/__init__.py:
3695         * Scripts/webkitpy/tool/commands/bugfortest.py: Added.
3696
3697 2010-12-13  Mihai Parparita  <mihaip@chromium.org>
3698
3699         Reviewed by James Robinson.
3700
3701         Add option to build-webkit to not build WebKit2
3702         https://bugs.webkit.org/show_bug.cgi?id=50988
3703         
3704         Add support for a --no-webkit2 option to build-webkit. It seems to save
3705         ~1 minute from clean builds and ~10 seconds from no-op builds.
3706
3707         * Scripts/build-webkit:
3708
3709 2010-12-13  Lucas Forschler  <lforschler@apple.com>
3710
3711         Reviewed by Dave Kilzer.
3712
3713         Update iexploder from 1.3.2 to 1.7.2
3714         Move 1.3.2 into its own subdir
3715         Add 1.7.2 into its own subdir
3716         update scripts to point to new 1.3.2 location (avoid breaking existing scripts)
3717
3718         * Scripts/run-iexploder-tests:
3719         * Scripts/update-iexploder-cssproperties:
3720         * iExploder/CHANGELOG.txt: Removed.
3721         * iExploder/LICENSE.txt: Removed.
3722         * iExploder/README.txt: Removed.
3723         * iExploder/htdocs: Removed.
3724         * iExploder/iexploder-1.3.2: Added.
3725         * iExploder/iexploder-1.3.2/CHANGELOG.txt: Copied from iExploder/CHANGELOG.txt.
3726         * iExploder/iexploder-1.3.2/LICENSE.txt: Copied from iExploder/LICENSE.txt.
3727         * iExploder/iexploder-1.3.2/README.txt: Copied from iExploder/README.txt.
3728         * iExploder/iexploder-1.3.2/htdocs: Added.
3729         * iExploder/iexploder-1.3.2/htdocs/config.rb: Copied from iExploder/htdocs/config.rb.
3730         * iExploder/iexploder-1.3.2/htdocs/cssproperties.in: Copied from iExploder/htdocs/cssproperties.in.
3731         * iExploder/iexploder-1.3.2/htdocs/cssvalues.in: Copied from iExploder/htdocs/cssvalues.in.
3732         * iExploder/iexploder-1.3.2/htdocs/htmlattrs.in: Copied from iExploder/htdocs/htmlattrs.in.
3733         * iExploder/iexploder-1.3.2/htdocs/htmltags.in: Copied from iExploder/htdocs/htmltags.in.
3734         * iExploder/iexploder-1.3.2/htdocs/htmlvalues.in: Copied from iExploder/htdocs/htmlvalues.in.
3735         * iExploder/iexploder-1.3.2/htdocs/iexploder.cgi: Copied from iExploder/htdocs/iexploder.cgi.
3736         * iExploder/iexploder-1.3.2/htdocs/iexploder.rb: Copied from iExploder/htdocs/iexploder.rb.
3737         * iExploder/iexploder-1.3.2/htdocs/index.html: Copied from iExploder/htdocs/index.html.
3738         * iExploder/iexploder-1.3.2/htdocs/webserver.rb: Copied from iExploder/htdocs/webserver.rb.
3739         * iExploder/iexploder-1.3.2/tools: Added.
3740         * iExploder/iexploder-1.3.2/tools/lasthit.rb: Copied from iExploder/tools/lasthit.rb.
3741         * iExploder/iexploder-1.3.2/tools/osx_last_crash.rb: Copied from iExploder/tools/osx_last_crash.rb.
3742         * iExploder/iexploder-1.3.2/tools/showtest.rb: Copied from iExploder/tools/showtest.rb.
3743         * iExploder/iexploder-1.7.2: Added.
3744         * iExploder/iexploder-1.7.2/ChangeLog.txt: Added.
3745         * iExploder/iexploder-1.7.2/LICENSE.txt: Added.
3746         * iExploder/iexploder-1.7.2/README.txt: Added.
3747         * iExploder/iexploder-1.7.2/output: Added.
3748         * iExploder/iexploder-1.7.2/src: Added.
3749         * iExploder/iexploder-1.7.2/src/browser_harness.rb: Added.
3750         * iExploder/iexploder-1.7.2/src/config.yaml: Added.
3751         * iExploder/iexploder-1.7.2/src/css-atrules: Added.
3752         * iExploder/iexploder-1.7.2/src/css-atrules/mozilla: Added.
3753         * iExploder/iexploder-1.7.2/src/css-atrules/webkit: Added.
3754         * iExploder/iexploder-1.7.2/src/css-properties: Added.
3755         * iExploder/iexploder-1.7.2/src/css-properties/dillo: Added.
3756         * iExploder/iexploder-1.7.2/src/css-properties/gtkhtml: Added.
3757         * iExploder/iexploder-1.7.2/src/css-properties/internet_explorer6: Added.
3758         * iExploder/iexploder-1.7.2/src/css-properties/mozilla: Added.
3759         * iExploder/iexploder-1.7.2/src/css-properties/webkit: Added.
3760         * iExploder/iexploder-1.7.2/src/css-pseudo: Added.
3761         * iExploder/iexploder-1.7.2/src/css-pseudo/mozilla: Added.
3762         * iExploder/iexploder-1.7.2/src/css-pseudo/webkit: Added.
3763         * iExploder/iexploder-1.7.2/src/css-values: Added.
3764         * iExploder/iexploder-1.7.2/src/css-values/dillo: Added.
3765         * iExploder/iexploder-1.7.2/src/css-values/gtkhtml: Added.
3766         * iExploder/iexploder-1.7.2/src/css-values/mozilla: Added.
3767         * iExploder/iexploder-1.7.2/src/css-values/other: Added.
3768         * iExploder/iexploder-1.7.2/src/css-values/webkit: Added.
3769         * iExploder/iexploder-1.7.2/src/headers: Added.
3770         * iExploder/iexploder-1.7.2/src/headers/dillo: Added.
3771         * iExploder/iexploder-1.7.2/src/headers/gtkhtml: Added.
3772         * iExploder/iexploder-1.7.2/src/headers/mozilla: Added.
3773         * iExploder/iexploder-1.7.2/src/headers/webkit: Added.
3774         * iExploder/iexploder-1.7.2/src/html-attrs: Added.
3775         * iExploder/iexploder-1.7.2/src/html-attrs/dillo: Added.
3776         * iExploder/iexploder-1.7.2/src/html-attrs/gtkhtml: Added.
3777         * iExploder/iexploder-1.7.2/src/html-attrs/internet_explorer6: Added.
3778         * iExploder/iexploder-1.7.2/src/html-attrs/mozilla: Added.
3779         * iExploder/iexploder-1.7.2/src/html-attrs/other: Added.
3780         * iExploder/iexploder-1.7.2/src/html-attrs/webkit: Added.
3781         * iExploder/iexploder-1.7.2/src/html-tags: Added.
3782         * iExploder/iexploder-1.7.2/src/html-tags/dillo: Added.
3783         * iExploder/iexploder-1.7.2/src/html-tags/gtkhtml: Added.
3784         * iExploder/iexploder-1.7.2/src/html-tags/mozilla: Added.
3785         * iExploder/iexploder-1.7.2/src/html-tags/other: Added.
3786         * iExploder/iexploder-1.7.2/src/html-tags/webkit: Added.
3787         * iExploder/iexploder-1.7.2/src/html-values: Added.
3788         * iExploder/iexploder-1.7.2/src/html-values/dillo: Added.
3789         * iExploder/iexploder-1.7.2/src/html-values/gtkhtml: Added.
3790         * iExploder/iexploder-1.7.2/src/html-values/mozilla: Added.
3791         * iExploder/iexploder-1.7.2/src/html-values/other: Added.
3792         * iExploder/iexploder-1.7.2/src/html-values/webkit: Added.
3793         * iExploder/iexploder-1.7.2/src/iexploder.cgi: Added.
3794         * iExploder/iexploder-1.7.2/src/iexploder.rb: Added.
3795         * iExploder/iexploder-1.7.2/src/index.html: Added.
3796         * iExploder/iexploder-1.7.2/src/media: Added.
3797         * iExploder/iexploder-1.7.2/src/media/blank.ogg: Added.
3798         * iExploder/iexploder-1.7.2/src/media/blank.snd: Added.
3799         * iExploder/iexploder-1.7.2/src/media/blank.wav: Added.
3800         * iExploder/iexploder-1.7.2/src/media/bug.bmp: Added.
3801         * iExploder/iexploder-1.7.2/src/media/bug.gif: Added.
3802         * iExploder/iexploder-1.7.2/src/media/bug.ico: Added.
3803         * iExploder/iexploder-1.7.2/src/media/bug.jng: Added.
3804         * iExploder/iexploder-1.7.2/src/media/bug.jpg: Added.
3805         * iExploder/iexploder-1.7.2/src/media/bug.png: Added.
3806         * iExploder/iexploder-1.7.2/src/media/bug.svg: Added.
3807         * iExploder/iexploder-1.7.2/src/media/bug.tiff: Added.
3808         * iExploder/iexploder-1.7.2/src/media/bug.xbm: Added.
3809         * iExploder/iexploder-1.7.2/src/media/bug.xpm: Added.
3810         * iExploder/iexploder-1.7.2/src/mime-types: Added.
3811         * iExploder/iexploder-1.7.2/src/mime-types/dillo: Added.
3812         * iExploder/iexploder-1.7.2/src/mime-types/mozilla: Added.
3813         * iExploder/iexploder-1.7.2/src/mime-types/webkit: Added.
3814         * iExploder/iexploder-1.7.2/src/protocols: Added.
3815         * iExploder/iexploder-1.7.2/src/protocols/dillo: Added.
3816         * iExploder/iexploder-1.7.2/src/protocols/gtkhtml: Added.
3817         * iExploder/iexploder-1.7.2/src/protocols/mozilla: Added.
3818         * iExploder/iexploder-1.7.2/src/protocols/webkit: Added.
3819         * iExploder/iexploder-1.7.2/src/scanner.rb: Added.
3820         * iExploder/iexploder-1.7.2/src/version.rb: Added.
3821         * iExploder/iexploder-1.7.2/src/webserver.rb: Added.
3822         * iExploder/iexploder-1.7.2/testcases: Added.
3823         * iExploder/iexploder-1.7.2/testcases/testcase-Linux_x86_64_rv2.0b6pre_Gecko-20100904_Firefox-4.0b6pre-TEST-8375-1_59.html: Added.
3824         * iExploder/iexploder-1.7.2/testcases/testcase-Opera-9.80_Linux_x86_64_en_Presto-2.6.30_Version-10.61-16704-3_108,3.html: Added.
3825         * iExploder/iexploder-1.7.2/testcases/testcase-U_Intel_Mac_OS_X_10_6_4_en-US_AppleWebKit-534.8_Chrome-7.0.529.0-TEST-611-3_36,9.html: Added.
3826         * iExploder/iexploder-1.7.2/testcases/testcase-U_Intel_Mac_OS_X_10_6_4_en-US_AppleWebKit-534.8_hrome-7.0.529.0-TEST-55313622206-3_6,0.html: Added.
3827         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.6_Chrome-7.0.503.1-TEST-120813-8_72,56,24,8,0.html: Added.
3828         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.6_Chrome-7.0.503.1-TEST-121240-3_81,3.html: Added.
3829         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.7_Chrome-7.0.513.0-4800-5_80,65,15.html: Added.
3830         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.7_Chrome-7.0.513.0-TEST-23583190347-3_15,12.html: Added.
3831         * iExploder/iexploder-1.7.2/tools: Added.
3832         * iExploder/iexploder-1.7.2/tools/lasthit.rb: Added.
3833         * iExploder/iexploder-1.7.2/tools/osx_last_crash.rb: Added.
3834         * iExploder/iexploder-1.7.2/tools/release_src.sh: Added.
3835         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh: Added.
3836         * iExploder/tools: Removed.
3837
3838 2010-12-13  Sam Weinig  <sam@webkit.org>
3839
3840         Reviewed by Anders Carlsson.
3841
3842         Remove associated page concept from WKView constructor
3843         https://bugs.webkit.org/show_bug.cgi?id=50983
3844
3845         Step 1: Remove associate page constructors from WKView and make
3846         all views use the shared namespace for the context.
3847
3848         * TestWebKitAPI/PlatformWebView.h:
3849         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
3850         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
3851         * WebKitTestRunner/PlatformWebView.h:
3852         * WebKitTestRunner/TestController.cpp:
3853         (WTR::createOtherPage):
3854         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3855         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3856         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3857
3858 2010-12-13  Sam Weinig  <sam@webkit.org>
3859
3860         Reviewed by Anders Carlsson.
3861
3862         Change the WebKit2 public API so there is no explicit WKPageNamespace object
3863         https://bugs.webkit.org/show_bug.cgi?id=50898
3864
3865         * MiniBrowser/mac/AppDelegate.h:
3866         * MiniBrowser/mac/AppDelegate.m:
3867         * MiniBrowser/mac/BrowserWindowController.h:
3868         * MiniBrowser/mac/BrowserWindowController.m:
3869         * MiniBrowser/win/BrowserView.cpp:
3870         Convert MiniBrowser to not use PageNamespaces.
3871
3872         * TestWebKitAPI/PlatformWebView.h:
3873         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
3874         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
3875         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
3876         * TestWebKitAPI/Tests/WebKit2/Find.cpp:
3877         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
3878         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
3879         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
3880         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
3881         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
3882         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
3883         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
3884         * TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp:
3885         * TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp:
3886         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
3887         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
3888         Convert TestWebKitAPI to not use PageNamespaces.
3889
3890         * WebKitTestRunner/PlatformWebView.h:
3891         * WebKitTestRunner/TestController.cpp:
3892         * WebKitTestRunner/TestController.h:
3893         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3894         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3895         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3896         Convert WebKitTestRunner to not use PageNamespaces.
3897
3898 2010-12-13  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
3899
3900         Reviewed by Eric Seidel.
3901
3902         webkit-patch rollout should be able to do multi-revision rollouts
3903         https://bugs.webkit.org/show_bug.cgi?id=33336
3904
3905         Make it possible to pass more than one revision to webkit-patch.
3906
3907         * Scripts/webkitpy/common/checkout/api.py:
3908         * Scripts/webkitpy/common/checkout/changelog.py:
3909         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
3910         * Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:
3911         * Scripts/webkitpy/tool/commands/download.py:
3912         * Scripts/webkitpy/tool/commands/download_unittest.py:
3913         * Scripts/webkitpy/tool/mocktool.py:
3914         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
3915         * Scripts/webkitpy/tool/steps/revertrevision.py:
3916
3917 2010-12-13  Eric Seidel  <eric@webkit.org>
3918
3919         Unreviewed.
3920
3921         Teach webkit-patch how to search bugzilla
3922         https://bugs.webkit.org/show_bug.cgi?id=50500
3923
3924         webkit-patch bug-search fails when there is only one result.
3925         Turns out we needed a bit more logic in our result count parsing code.
3926
3927         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3928         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
3929
3930 2010-12-13  Antti Koivisto  <antti@apple.com>
3931
3932         Reviewed by Alexey Proskuryakov.
3933
3934         Add setSerializeHTTPLoads function to allow testing resource load order on OS X.
3935         https://bugs.webkit.org/show_bug.cgi?id=50758
3936
3937         * DumpRenderTree/LayoutTestController.cpp:
3938         (setSerializeHTTPLoadsCallback):
3939         (LayoutTestController::staticFunctions):
3940         * DumpRenderTree/LayoutTestController.h:
3941         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3942         (LayoutTestController::setSerializeHTTPLoads):
3943         * DumpRenderTree/mac/DumpRenderTree.mm:
3944         (resetDefaultsToConsistentValues):
3945         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3946         (LayoutTestController::setSerializeHTTPLoads):
3947         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3948         (LayoutTestController::setSerializeHTTPLoads):
3949
3950 2010-12-13  Dimitri Glazkov  <dglazkov@chromium.org>
3951
3952         Reviewed by Ojan Vafai.
3953
3954         Remove "use-drt" option from test step command line, since the option was removed in r73748.
3955         https://bugs.webkit.org/show_bug.cgi?id=50936
3956
3957         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Removed the option.
3958
3959 2010-12-13  Patrick Gansterer  <paroga@webkit.org>
3960
3961         Reviewed by Csaba Osztrogonác.
3962
3963         Add revlink to BuildBot status
3964         https://bugs.webkit.org/show_bug.cgi?id=50914
3965
3966         This adds a hyperlink to trac changeset on the revision numbers. 
3967
3968         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3969
3970 2010-12-13  Andras Becsi  <abecsi@webkit.org>
3971
3972         Reviewed by Csaba Osztrogonác.
3973
3974         [Qt][WK2] Fix build if WebKitTools are not available
3975         https://bugs.webkit.org/show_bug.cgi?id=50242
3976
3977         * MiniBrowser/qt/MiniBrowser.pro: Correct the comment.
3978         * Scripts/webkitdirs.pm: Added WebKitTools/MiniBrowser to $subdirs.
3979         * MiniBrowser/DerivedSources.pro: Added.
3980
3981 2010-12-13  Eric Seidel  <eric@webkit.org>
3982
3983         Reviewed by Adam Barth.
3984
3985         EWS Queues should remove orpahned pyc files before starting
3986         https://bugs.webkit.org/show_bug.cgi?id=50904
3987
3988         A previous check added a platform.py which caused
3989         EWS bots on some platforms to hit an import exception.
3990         The platform.py file was removed in a subsequent commit, but
3991         the EWS bots in question stayed stuck.  This change will
3992         fix those bots once restarted (and prevent this in the future).
3993
3994         I also went ahead and unified start-queue and start-commit-queue
3995         since they were nearly identical.  I also added bot_id support
3996         to both force all EWSes to have bot ids as well as get rid of the one
3997         remaining reason why I had my own copies of these scripts.
3998         Hopefully this will be enough to get all the other bot admins
3999         (ahem, Adam, ahem) to move to using these checked in copies as well.
4000
4001         * EWSTools/start-commit-queue.sh: Removed.
4002         * EWSTools/start-queue.sh:
4003
4004 2010-10-28  MORITA Hajime  <morrita@google.com>
4005
4006         Reviewed by Ojan Vafai.
4007
4008         spellcheck does not check pasted text
4009         https://bugs.webkit.org/show_bug.cgi?id=40092
4010
4011         Added LayoutTestController::setAsynchronousSpellCheckingEnabled()
4012         to control the setting.
4013
4014         * DumpRenderTree/LayoutTestController.cpp:
4015         (setAsynchronousSpellCheckingEnabledCallback):
4016         (LayoutTestController::staticFunctions):
4017         * DumpRenderTree/LayoutTestController.h:
4018         * DumpRenderTree/chromium/LayoutTestController.h:
4019         * DumpRenderTree/chromium/LayoutTestController.cpp:
4020         (LayoutTestController::LayoutTestController):
4021         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
4022         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
4023         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
4024         * DumpRenderTree/mac/DumpRenderTree.mm:
4025         (resetDefaultsToConsistentValues):
4026         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
4027         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
4028         * DumpRenderTree/qt/LayoutTestControllerQt.h:
4029         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
4030         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
4031         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
4032         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
4033         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
4034         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
4035
4036 2010-12-12  Sam Weinig  <sam@webkit.org>
4037
4038         Reviewed by Anders Carlsson.
4039
4040         Fix failing API test. It turns out that a pop-state event
4041         is sent before every fragment navigation, so we have to test
4042         for it in addition in PageLoadDidChangeLocationWithinPageForFrame.
4043
4044         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
4045         (TestWebKitAPI::didSameDocumentNavigationForFrame):
4046
4047 2010-12-12  Alejandro G. Castro  <alex@igalia.com>
4048
4049         Reviewed by Eric Seidel.
4050
4051         [GTK] Add new-run-webkit-tests support to gtk
4052         https://bugs.webkit.org/show_bug.cgi?id=50681
4053
4054         Adding the basic support to run the new-run-webkit-tests.
4055
4056         * Scripts/webkitpy/layout_tests/port/gtk.py:
4057
4058 2010-10-11  Diego Gonzalez  <diegohcg@webkit.org>
4059
4060         Reviewed by Kenneth Rohde Christiansen.
4061
4062         [Qt] Mock DeviceOrientation client for DRT
4063         https://bugs.webkit.org/show_bug.cgi?id=47490
4064
4065         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
4066         (WebCore::DumpRenderTree::DumpRenderTree):
4067         (WebCore::DumpRenderTree::~DumpRenderTree):
4068         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
4069         (LayoutTestController::setMockDeviceOrientation):
4070
4071 2010-12-11  Philippe Normand  <pnormand@igalia.com>
4072
4073         Reviewed by Gustavo Noronha Silva.
4074
4075         [GTK] launcher: disable the Mozilla-style fullscreen API
4076         https://bugs.webkit.org/show_bug.cgi?id=50874
4077
4078         Disabling the fullscreen API until its implementation for GTK is
4079         mature enough. The webview setting for it is already FALSE by
4080         default.
4081
4082         * GtkLauncher/main.c:
4083         (createWindow):
4084
4085 2010-12-10  Eric Seidel  <eric@webkit.org>
4086
4087         Reviewed by Adam Barth.
4088
4089         commit-queue flaky test messages show cryptic version information for mac os x
4090         https://bugs.webkit.org/show_bug.cgi?id=50864
4091
4092         Turns out platform.platform() returns kernel version information
4093         which isn't helpful, and just plain confusing on Mac
4094         (OS X 10.6.5 uses Darwin Kernel 10.5.0).
4095
4096         So I've updated PlatformInfo.display_name() to special case
4097         mac.  I also found a bad use of sys.platform in the process
4098         and fixed that.  (sys.platform always returns 'darwin' on mac).
4099
4100         * Scripts/webkitpy/common/system/platforminfo.py:
4101         * Scripts/webkitpy/common/system/user.py:
4102         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
4103         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
4104         * Scripts/webkitpy/tool/commands/queues_unittest.py:
4105
4106 2010-12-10  Eric Seidel  <eric@webkit.org>
4107
4108         Unreviewed.
4109
4110         Exception seen while reporting flaky test with commit-queue.
4111         Just a missing include.
4112
4113         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
4114         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
4115
4116 2010-12-10  Kinuko Yasuda  <kinuko@chromium.org>
4117
4118         Reviewed by Eric Seidel.
4119
4120         [Chromium] Remove old JSONResultsGenerator script that existed for backward-compatibility
4121         https://bugs.webkit.org/show_bug.cgi?id=50796
4122
4123         Also updating the test code to use JSONResultsGeneratorBase and
4124         to improve test coverage for incremental cases.
4125
4126         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
4127         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
4128
4129 2010-12-10  Joseph Pecoraro  <joepeck@webkit.org>
4130
4131         Reviewed by Darin Adler.
4132
4133         prepare-ChangeLog --help doesn't mention --bug shorthand -b
4134         https://bugs.webkit.org/show_bug.cgi?id=50835
4135
4136         * Scripts/prepare-ChangeLog: be more explicit about -b and match file style.
4137
4138 2010-12-10  Eric Seidel  <eric@webkit.org>
4139
4140         Reviewed by Adam Barth.
4141
4142         Bugs created by the commit-queue should all block on a master bug
4143         https://bugs.webkit.org/show_bug.cgi?id=50857
4144
4145         This makes all bugs created by the commit-queue block on:
4146         https://bugs.webkit.org/show_bug.cgi?id=50856
4147
4148         In the process of testing this, I found that the existing
4149         create_bug code was wrong.  I also found that existing
4150         unit tests for create-rollout used invalid values
4151         for options.blocks.  I fixed both issues and tested.
4152
4153         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
4154         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
4155         * Scripts/webkitpy/tool/commands/commandtest.py:
4156         * Scripts/webkitpy/tool/commands/download_unittest.py:
4157         * Scripts/webkitpy/tool/commands/upload_unittest.py:
4158         * Scripts/webkitpy/tool/mocktool.py:
4159         * Scripts/webkitpy/tool/steps/options.py:
4160
4161 2010-12-10  Eric Seidel  <eric@webkit.org>
4162
4163         Reviewed by Adam Barth.
4164
4165         Teach webkitpy how to follow duplicate chains when posting comments on flake bugs
4166         https://bugs.webkit.org/show_bug.cgi?id=50853
4167
4168         I also discovered when doing this that the code was posting
4169         the comment on the wrong bug, but that's fixed here too.
4170
4171         * Scripts/webkitpy/common/net/bugzilla/bug.py:
4172         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
4173         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
4174         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
4175         * Scripts/webkitpy/tool/commands/queues_unittest.py:
4176         * Scripts/webkitpy/tool/mocktool.py:
4177
4178 2010-12-10  Anders Carlsson  <andersca@apple.com>
4179
4180         Reviewed by John Sullivan.
4181
4182         Make WKContextGetStatistics gather global statistics
4183         https://bugs.webkit.org/show_bug.cgi?id=50850
4184
4185         Remove the code that gets the statistics and fills in the per context
4186         statistics information for now.
4187
4188         * MiniBrowser/mac/BrowserStatisticsWindowController.m:
4189         (-[BrowserStatisticsWindowController refreshStatistics:]):
4190
4191 2010-12-10  Eric Seidel  <eric@webkit.org>
4192
4193         Unreviewed.
4194
4195         commit-queue should report port/platform information when commenting on flaky test bugs
4196         https://bugs.webkit.org/show_bug.cgi?id=50839
4197
4198         Renamed platform.py to platforminfo.py.  This broke import platform in executive.py
4199         which was only used by new run webkit tests (and clearly not unit tested).
4200
4201         * Scripts/webkitpy/common/system/platforminfo.py: Renamed from WebKitTools/Scripts/webkitpy/common/system/platform.py.
4202         * Scripts/webkitpy/tool/main.py:
4203         * Scripts/webkitpy/tool/mocktool.py:
4204
4205 2010-12-10  Eric Seidel  <eric@webkit.org>
4206
4207         Reviewed by Tony Chang.
4208
4209         commit-queue should report port/platform information when commenting on flaky test bugs
4210         https://bugs.webkit.org/show_bug.cgi?id=50839
4211
4212         This was a suggestion from Tony Chang this morning.
4213         I added a platform.py class so I could easily mock the platform call,
4214         but that may not be the final solution for this mocking.
4215         We'll try it and see.
4216
4217         * Scripts/webkitpy/common/system/platform.py: Added.
4218         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
4219         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
4220         * Scripts/webkitpy/tool/commands/queues_unittest.py:
4221         * Scripts/webkitpy/tool/main.py:
4222         * Scripts/webkitpy/tool/mocktool.py:
4223
4224 2010-12-10  Krithigassree Sambamurthy  <krithigassree.sambamurthy@nokia.com>
4225
4226         Reviewed by Joseph Pecoraro.
4227
4228         Bug 43455 - [Qt]: Implement Application Cache Quotas
4229         https://bugs.webkit.org/show_bug.cgi?id=43455
4230
4231         Introduce functions to allow new appcache layout test origin-quota.html
4232         to work correctly under Qt.
4233
4234         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
4235         (WebCore::DumpRenderTree::DumpRenderTree):
4236         (WebCore::DumpRenderTree::dumpApplicationCacheQuota):
4237         * DumpRenderTree/qt/DumpRenderTreeQt.h:
4238
4239         Introduce functions to allow new appcache layout test origin-quota.html
4240         to be successful under qt. Changes required because LayoutTestControllerQt
4241         does not inherit from LayoutController.
4242
4243         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
4244         (LayoutTestController::reset):
4245         (LayoutTestController::clearAllApplicationCaches):
4246         (LayoutTestController::setApplicationCacheOriginQuota):
4247         * DumpRenderTree/qt/LayoutTestControllerQt.h:
4248         (LayoutTestController::shouldDumpApplicationCacheDelegateCallbacks):
4249         (LayoutTestController::dumpApplicationCacheDelegateCallbacks):
4250
4251 2010-12-10  Eric Seidel  <eric@webkit.org>
4252
4253         Reviewed by Adam Barth.
4254
4255         Move buildbot.py into its own module so we can split it out into one-file-per-class
4256         https://bugs.webkit.org/show_bug.cgi?id=50806
4257
4258         We're adding more buildbot logic these days, so it makes sense
4259         to give buildbot its own module.
4260
4261         * Scripts/webkitpy/common/net/buildbot/__init__.py: Added.
4262         * Scripts/webkitpy/common/net/buildbot/buildbot.py: Renamed from WebKitTools/Scripts/webkitpy/common/net/buildbot.py.
4263         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py: Renamed from WebKitTools/Scripts/webkitpy/common/net/buildbot_unittest.py.
4264         * Scripts/webkitpy/common/net/failuremap.py:
4265         * Scripts/webkitpy/common/net/regressionwindow.py:
4266         * Scripts/webkitpy/tool/commands/rebaseline.py:
4267
4268 2010-12-10  Tony Chang  <tony@chromium.org>
4269
4270         Reviewed by Eric Seidel.
4271
4272         Use FileSystem::remove when cleaning up http lock files
4273         https://bugs.webkit.org/show_bug.cgi?id=50830
4274
4275         * Scripts/webkitpy/layout_tests/port/http_lock.py:
4276
4277 2010-12-10  Joone Hur  <joone@kldp.org>
4278
4279         Reviewed by Martin Robinson.
4280
4281         [GTK] DRT needs layoutTestController.setCacheModel
4282         https://bugs.webkit.org/show_bug.cgi?id=50705
4283         
4284         webkit_set_cache_mode() is called to set the cache model.
4285         
4286         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
4287         (LayoutTestController::setCacheModel): Set the cache model. 
4288
4289 2010-12-10  Tony Chang  <tony@chromium.org>
4290
4291         Reviewed by Ojan Vafai.
4292
4293         [chromium] remove --use-drt and add --use-test-shell
4294         https://bugs.webkit.org/show_bug.cgi?id=50701
4295
4296         * Scripts/webkitpy/common/config/ports.py:
4297         * Scripts/webkitpy/common/config/ports_unittest.py:
4298         * Scripts/webkitpy/layout_tests/port/chromium.py:
4299         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
4300         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
4301         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
4302         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
4303         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
4304         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
4305         * Scripts/webkitpy/layout_tests/port/webkit.py:
4306         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4307         * Scripts/webkitpy/style/checkers/test_expectations.py:
4308         * Scripts/webkitpy/tool/commands/queries.py:
4309
4310 2010-12-10  John Knottenbelt  <jknotten@chromium.org>
4311
4312         Reviewed by Steve Block.
4313
4314         [Chromium] Implement mocks for client-based geolocation
4315         https://bugs.webkit.org/show_bug.cgi?id=46895
4316
4317         * DumpRenderTree/chromium/LayoutTestController.cpp:
4318         (LayoutTestController::setGeolocationPermission):
4319         (LayoutTestController::setMockGeolocationPosition):
4320         (LayoutTestController::setMockGeolocationError):
4321         * DumpRenderTree/chromium/LayoutTestController.h:
4322         * DumpRenderTree/chromium/WebViewHost.cpp:
4323         (WebViewHost::geolocationClient):
4324         (WebViewHost::geolocationClientMock):
4325         (WebViewHost::reset):
4326         * DumpRenderTree/chromium/WebViewHost.h:
4327
4328 2010-12-10  Alejandro G. Castro  <alex@igalia.com>
4329
4330         Reviewed by Martin Robinson.
4331
4332         [GTK] Add hasSpellingMarker support to the DRT
4333         https://bugs.webkit.org/show_bug.cgi?id=50739
4334
4335         Implemented the hasSpellingMarker to support spelling tests.
4336
4337         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
4338         (LayoutTestController::hasSpellingMarker):
4339
4340 2010-12-10  Eric Seidel  <eric@webkit.org>
4341
4342         Reviewed by Ojan Vafai.
4343
4344         webkit-patch: not possible to use build-and-test with local commits
4345         https://bugs.webkit.org/show_bug.cgi?id=33378
4346
4347         Make --no-clean not even check if we have local commits.
4348         It's unclear to me why the code was originally written this way.
4349         I was unable to dig up a reason from svn history.
4350
4351         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
4352         * Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py: Copied from WebKitTools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.
4353
4354 2010-12-10  Mario Sanchez Prada  <msanchez@igalia.com>
4355
4356         Reviewed by Martin Robinson.
4357
4358         [GTK] AX: implement isEnabled in DRT
4359         https://bugs.webkit.org/show_bug.cgi?id=50814
4360
4361         Implement AccessibilityUIElement::isEnabled() for GTK.
4362
4363         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
4364         (checkElementState): New function to refactor common code.
4365         (AccessibilityUIElement::isEnabled): Implement this by checking
4366         the current state of the AtkObject.
4367         (AccessibilityUIElement::isSelected): Use the new
4368         checkElementState function.
4369
4370 2010-12-10  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
4371
4372         Reviewed by Kenneth Rohde Christiansen.
4373
4374         [Qt][WK2] Add the QWKContext API class to wrap the WebContext.
4375         https://bugs.webkit.org/show_bug.cgi?id=50750
4376
4377         * MiniBrowser/qt/BrowserView.cpp:
4378         (BrowserView::BrowserView):
4379         * MiniBrowser/qt/BrowserView.h:
4380         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
4381         (WTR::WebView::WebView):
4382
4383 2010-12-10  Joone Hur  <joone@kldp.org>
4384
4385         Reviewed by Xan Lopez.
4386
4387         [GTK] Unskipping some test cases in userscripts dependent on addUserStyleSheet
4388         https://bugs.webkit.org/show_bug.cgi?id=50808
4389
4390         Unskipping the following test cases:
4391         userscripts/mixed-case-stylesheet.html
4392         userscripts/simple-stylesheet.html
4393         userscripts/user-style-all-frames.html
4394
4395         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
4396         (LayoutTestController::addUserStyleSheet):
4397
4398 2010-12-10  Joone Hur  <joone@kldp.org>
4399
4400         Reviewed by Eric Seidel.
4401
4402         [GTK] Add DRT support for pageProperty, isPageBoxVisible, pageSizeAndMarginsInPixels, and addUserStyleSheet
4403         https://bugs.webkit.org/show_bug.cgi?id=50783
4404
4405         This patch allows to unskip the following test cases:
4406         printing/page-rule-selection.html
4407         printing/page-format-data.html
4408
4409         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
4410         (LayoutTestController::pageProperty): Added.
4411         (LayoutTestController::isPageBoxVisible): Ditto.
4412         (LayoutTestController::pageSizeAndMarginsInPixels): Ditto.
4413         (LayoutTestController::addUserStyleSheet): Ditto.
4414
4415 2010-12-10  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
4416
4417         Reviewed by Kenneth Rohde Christiansen.
4418
4419         [Qt] Make QtTestBrowser spawn QNAM in a secondary thread.
4420
4421         A menu allows to switch QNAM back to the same thread.
4422
4423         * QtTestBrowser/launcherwindow.cpp:
4424         (LauncherWindow::initializeView):
4425         (LauncherWindow::createChrome):
4426         (LauncherWindow::toggleThreadedQnam):
4427         * QtTestBrowser/launcherwindow.h:
4428         (WindowOptions::WindowOptions):
4429         * QtTestBrowser/webpage.cpp:
4430         (WebPage::WebPage):
4431         (WebPage::setQnamThreaded):
4432         * QtTestBrowser/webpage.h:
4433         (QnamThread::QnamThread):
4434         (QnamThread::~QnamThread):
4435         (QnamThread::networkAccessManager):
4436         (QnamThread::run):
4437
4438 2010-12-10  Martin Robinson  <mrobinson@igalia.com>
4439
4440         Reviewed by Xan Lopez.
4441
4442         [Gtk] style="font-family: courier" makes text disappear
4443         https://bugs.webkit.org/show_bug.cgi?id=47452
4444
4445         Add a test