Not reviewed.
[WebKit.git] / Tools / ChangeLog
1 2011-02-07  Maciej Stachowiak  <mjs@apple.com>
2
3         Not reviewed.
4
5         Fix WebKitTestRunner build on the SL bot.
6
7         * WebKitTestRunner/Configurations/Base.xcconfig: Look for the JSC copy
8         of ICU headers.
9
10 2011-02-07  Csaba Osztrogonác  <ossy@webkit.org>
11
12         Unreviewed.
13
14         [Qt][WK2] Buildfix after r77794.
15
16        WebKitTestRunner does not block remote resources or complain about them
17        https://bugs.webkit.org/show_bug.cgi?id=42139
18        <rdar://problem/8183942>
19
20         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: Add missing includepaths.
21
22 2011-02-07  Maciej Stachowiak  <mjs@apple.com>
23
24         Not reviewed.
25
26         More bot appeasement.
27
28         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
29
30 2011-02-07  Maciej Stachowiak  <mjs@apple.com>
31
32         Not reviewed.
33
34         Remove accidental references to directories on my laptop.
35
36         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
37
38 2011-02-07  Maciej Stachowiak  <mjs@apple.com>
39
40         Reviewed by Antti Koivisto.
41
42         WebKitTestRunner does not block remote resources or complain about them
43         https://bugs.webkit.org/show_bug.cgi?id=42139
44         <rdar://problem/8183942>
45
46         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
47         (WTR::InjectedBundlePage::willSendRequestForFrame): Implement the required
48         checks (using KURL, to avoid need to invent a whole URL API).
49         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Link WebCore
50         directly to get at KURL symbols.
51
52 2011-02-06  Maciej Stachowiak  <mjs@apple.com>
53
54         Reviewed by Daniel Bates.
55
56         Add WebKit2 bot to list of expected builders in Python regression test results.
57         https://bugs.webkit.org/show_bug.cgi?id=53905
58
59         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
60
61 2011-02-06  Maciej Stachowiak  <mjs@apple.com>
62
63         Reviewed by Ryosuke Niwa.
64
65         Update test expectations for new core builder
66         https://bugs.webkit.org/show_bug.cgi?id=53904
67
68         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
69
70 2011-02-06  Maciej Stachowiak  <mjs@apple.com>
71
72         Reviewed by David Levin.
73
74         Add WebKit2 test bot to core builders
75         https://bugs.webkit.org/show_bug.cgi?id=53901
76
77         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
78
79 2011-02-06  Ryosuke Niwa  <rniwa@webkit.org>
80
81         Another unreviewed Chromium build fix.
82
83         * DumpRenderTree/chromium/LayoutTestController.cpp:
84         (LayoutTestController::pathToLocalResource):
85
86 2011-02-06  Ryosuke Niwa  <rniwa@webkit.org>
87
88         Unreviewed Chromium build fix.
89
90         * DumpRenderTree/chromium/LayoutTestController.cpp:
91         (LayoutTestController::pathToLocalResource):
92
93 2011-02-06  Ryosuke Niwa  <rniwa@webkit.org>
94
95         Reviewed by Darin Adler.
96
97         OwnArraryPtr.h uses deleteOwnedPtr but doesn’t include OwnPtrCommon.h
98         https://bugs.webkit.org/show_bug.cgi?id=52867
99
100         * DumpRenderTree/chromium/ImageDiff.cpp:
101         (Image::craeteFromStdin): Call adoptArrayPtr.
102
103 2011-02-06  James Kozianski  <koz@chromium.org>
104
105         Reviewed by Ojan Vafai.
106
107         Add classes for representing test outputs.
108         https://bugs.webkit.org/show_bug.cgi?id=52136
109
110         These classes will make it easier to write scripts that deal with test
111         outputs such as rebaselining and deduping scripts. The intent is that
112         eventually we will be have buildbot return TestOutputs for a
113         particular build which can be compared with TestOutputs derived from a
114         local LayoutTests directory.
115
116         * Scripts/webkitpy/common/net/testoutput.py: Added.
117         * Scripts/webkitpy/common/net/testoutput_unittest.py: Added.
118         * Scripts/webkitpy/common/net/testoutputset.py: Added.
119         * Scripts/webkitpy/common/net/testoutputset_unittest.py: Added.
120         * Scripts/webkitpy/common/system/zip_mock.py: Added.
121
122 2011-02-06  Robert Hogan  <robert@webkit.org>
123
124         Reviewed by Andreas Kling.
125
126         [Qt] Clear page's groupName even when not in DRT
127         https://bugs.webkit.org/show_bug.cgi?id=53874
128
129         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
130         (WebCore::DumpRenderTree::windowCloseRequested):
131
132 2011-02-06  Patrick Gansterer  <paroga@webkit.org>
133
134         Reviewed by Andreas Kling.
135
136         [CMake] Add dependencies for Visual Studio projects
137         https://bugs.webkit.org/show_bug.cgi?id=53773
138
139         Add a WebKit dependecy to WinCELauncher, so CMake can 
140         generate the correct build order for the solution.
141
142         * CMakeListsWinCE.txt:
143
144 2011-02-06  Andreas Kling  <kling@webkit.org>
145
146         Reviewed by Antonio Gomes.
147
148         [Qt] MiniBrowser: Clean up handling of titleChanged() signal
149         https://bugs.webkit.org/show_bug.cgi?id=53869
150
151         * MiniBrowser/qt/BrowserView.cpp:
152         (BrowserView::BrowserView): Remove unnecessary titleChanged() handling.
153         * MiniBrowser/qt/BrowserWindow.cpp:
154         (BrowserWindow::BrowserWindow): Connect titleChanged() directly to setWindowTitle().
155         * MiniBrowser/qt/BrowserWindow.h:
156
157 2011-02-06  Maciej Stachowiak  <mjs@apple.com>
158
159         Reviewed by Dan Bernstein.
160
161         WebKitTestRunner needs layoutTestController.setWillSendRequestReturnsNull
162         https://bugs.webkit.org/show_bug.cgi?id=42690
163         <rdar://problem/8213851>
164
165         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
166         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
167         (WTR::InjectedBundlePage::willSendRequestForFrame):
168         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
169         (WTR::LayoutTestController::LayoutTestController):
170         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
171         (WTR::LayoutTestController::willSendRequestReturnsNull):
172         (WTR::LayoutTestController::setWillSendRequestReturnsNull):
173
174 2011-02-05  Sheriff Bot  <webkit.review.bot@gmail.com>
175
176         Unreviewed, rolling out r77720.
177         http://trac.webkit.org/changeset/77720
178         https://bugs.webkit.org/show_bug.cgi?id=53854
179
180         "Broke nrwt on Chromium win." (Requested by dglazkov|away on
181         #webkit).
182
183         * Scripts/webkitpy/common/system/executive.py:
184
185 2011-02-05  Sheriff Bot  <webkit.review.bot@gmail.com>
186
187         Unreviewed, rolling out r77725.
188         http://trac.webkit.org/changeset/77725
189         https://bugs.webkit.org/show_bug.cgi?id=53844
190
191         It broke Qt minimal build (Requested by Ossy_ on #webkit).
192
193         * QtTestBrowser/launcherwindow.cpp:
194         (LauncherWindow::createChrome):
195         * QtTestBrowser/launcherwindow.h:
196         (WindowOptions::WindowOptions):
197         * QtTestBrowser/main.cpp:
198         (LauncherApplication::handleUserOptions):
199
200 2011-02-04  Martin Robinson  <mrobinson@igalia.com>
201
202         Reviewed by Adam Barth.
203
204         [GTK] plugins/plugin-document-back-forward.html fails
205         https://bugs.webkit.org/show_bug.cgi?id=53833
206
207         Add the new "alert on load" functionality for the Unix version of the
208         test plugin. This functionality was originally introduced in r77706.
209
210         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
211         (webkit_test_plugin_new_instance): Add new plugin fuctionality.
212
213 2011-02-04  Kundu Suchismita  <suchi.kundu@nokia.com>
214
215         Reviewed by Andreas Kling.
216
217         Local Storage settings can be enable/disable from "Develop" menu
218         https://bugs.webkit.org/show_bug.cgi?id=52296
219
220         * QtTestBrowser/launcherwindow.cpp:
221         (LauncherWindow::createChrome):
222         (LauncherWindow::toggleLocalStorage):
223         (LauncherWindow::toggleOfflineStorageDatabase):
224         (LauncherWindow::toggleOfflineWebApplicationCache):
225         (LauncherWindow::setOfflineStorageDefaultQuota):
226         * QtTestBrowser/launcherwindow.h:
227         (WindowOptions::WindowOptions):
228         * QtTestBrowser/main.cpp:
229         (LauncherApplication::handleUserOptions):
230
231 2011-02-04  Tony Chang  <tony@chromium.org>
232
233         Reviewed by Eric Seidel.
234
235         get test-webkitpy running on win32 python
236         https://bugs.webkit.org/show_bug.cgi?id=53822
237
238         The test harness crashes with a WindowsError because it can't find
239         'svn' when using subprocess.Popen.  This gets us past the error
240         so we can see the failing tests on the Chromium Win Release Tests
241         bot.
242
243         * Scripts/webkitpy/common/system/executive.py:
244
245 2011-02-04  Martin Robinson  <mrobinson@igalia.com>
246
247         Reviewed by Gustavo Noronha Silva.
248
249         [GTK] fast/events/pagehide-timeout.html fails
250         https://bugs.webkit.org/show_bug.cgi?id=53771
251
252         Add knowledge of the document browser cache model the DRT. When resetting
253         WebKit settings to consistent values between tests, default to the document
254         browser cache model.
255
256         * DumpRenderTree/gtk/DumpRenderTree.cpp:
257         (resetDefaultsToConsistentValues): Reset the cache model to the document browser
258         cache model between tests.
259         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
260         (LayoutTestController::setCacheModel): An int value of 2 here corresponds to the
261         document browser cache model.
262
263 2011-02-04  Adam Barth  <abarth@webkit.org>
264
265         Reviewed by Eric Seidel.
266
267         PluginDocuments don't create widgets for plugins on back/forward
268         https://bugs.webkit.org/show_bug.cgi?id=53474
269
270         Teach the test plugin how to call alert on load.
271
272         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
273         (NPP_New):
274
275 2011-02-04  Adam Roben  <aroben@apple.com>
276
277         Add a test case for encode/decode of FormData/FormDataElement
278
279         If the fix made in r77401 is broken, this new test will crash.
280
281         Fixes <http://webkit.org/b/53616> <rdar://problem/8949883>.
282
283         Reviewed by Sam Weinig.
284
285         * TestWebKitAPI/Test.h: Moved the bulk of TEST_ASSERT into a new _TEST_ASSERT_HELPER macro.
286         Added a new TEST_ASSERT_RETURN macro that can be used in functions with a return value.
287
288         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp: Added.
289         (TestWebKitAPI::didFinishLoadForFrame): Record that the load is finished.
290         (TestWebKitAPI::setPageLoaderClient): Hook up the loader client.
291         (TestWebKitAPI::createSessionStateContainingFormData): Load simple-form.html, submit the
292         form, an return the session state data.
293         (TestWebKitAPI::TEST): Create some session state that contains form data from one WKPage,
294         and restore it into another WKPage.
295
296         * TestWebKitAPI/Tests/WebKit2/simple-form.html: Added.
297
298         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
299         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
300         * TestWebKitAPI/win/copy-resources.cmd:
301         Added new files.
302
303 2011-02-04  Adam Roben  <aroben@apple.com>
304
305         Move code to run JavaScript tests into its own files
306
307         This will allow other tests to use this mechanism.
308
309         Fixes <http://webkit.org/b/53806> SpacebarScrolling should share its JavaScript-fu with the
310         world
311
312         Reviewed by Sam Weinig.
313
314         * TestWebKitAPI/JavaScriptTest.cpp: Added.
315         * TestWebKitAPI/JavaScriptTest.h: Added.
316         Moved code here...
317
318         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp: ...from here.
319
320         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
321         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
322         Added the new files.
323
324 2011-02-04  Dirk Pranke  <dpranke@chromium.org>
325
326         Reviewed by Mihai Parparita.
327
328         merge test expectations for chromium, chromium-gpu. The
329         chromium-gpu port will no longer maintain its own
330         test expectations file.
331
332         Also add in a graphics_type() call on the port object to
333         determine what graphics type to use in the test configuration,
334         and log the configuration as a config setting.
335
336         https://bugs.webkit.org/show_bug.cgi?id=53562
337
338         * Scripts/webkitpy/layout_tests/port/base.py:
339         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
340         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
341         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
342
343 2011-02-04  Mikhail Naganov  <mnaganov@chromium.org>
344
345         Reviewed by Pavel Feldman.
346
347         Web Inspector: fix processing Unicode literals from .js sources in check-inspector-strings.
348         https://bugs.webkit.org/show_bug.cgi?id=53781
349
350         * Scripts/check-inspector-strings:
351
352 2011-02-04  Adam Roben  <aroben@apple.com>
353
354         Include the crashing function in the link to a crash log on Mac
355
356         Fixes <http://webkit.org/b/53780> Crash log links in results.html should include the
357         function that crashed on Mac
358
359         Reviewed by David Kilzer.
360
361         * Scripts/old-run-webkit-tests:
362         (crashLocation): Moved all the Windows code inside an if instead of using an early return,
363         but didn't otherwise change it. Added an if for Mac that parses the crashing function out of
364         the crash log.
365
366 2011-02-04  Adam Roben  <aroben@apple.com>
367
368         Link to Mac crash logs from results.html
369
370         Fixes <http://webkit.org/b/14861> run-webkit-tests should link to Mac crash logs in
371         results.html
372
373         Reviewed by David Kilzer.
374
375         * Scripts/old-run-webkit-tests:
376         (captureSavedCrashLog): Added a case for Apple's Mac port. We get the crash log out of
377         ~/Library/Logs/CrashReporter, and wait for ReportCrash to exit before trying to get the log.
378
379 2011-02-03  Maciej Stachowiak  <mjs@apple.com>
380
381         Reviewed by Dan Bernstein.
382
383         WebKit2: Need WebKit2 equivalent of WebResourceLoadDelegate::willSendRequest in the Bundle
384         https://bugs.webkit.org/show_bug.cgi?id=52897
385         <rdar://problem/8898294>
386
387         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
388         (WTR::InjectedBundlePage::InjectedBundlePage):
389         (WTR::InjectedBundlePage::willSendRequestForFrame):
390         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
391
392 2011-02-03  Ivan Krstić  <ike@apple.com>
393
394         Unreviewed.
395
396         Adding myself to committers.py.
397
398         * Scripts/webkitpy/common/config/committers.py:
399
400 2011-02-03  James Kozianski  <koz@chromium.org>
401
402         Reviewed by Dimitri Glazkov.
403
404         Add navigator.registerProtocolHandler behind a flag.
405         https://bugs.webkit.org/show_bug.cgi?id=52609
406
407         * Scripts/build-webkit:
408
409 2011-02-03  Hayato Ito  <hayato@chromium.org>
410
411         Reviewed by Eric Seidel.
412
413         [NRWT] Remove TestArgs class, which is wrongly used.
414
415         https://bugs.webkit.org/show_bug.cgi?id=53063
416
417         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
418         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
419         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
420         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
421         * Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py:
422         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
423
424 2011-02-03  Andrew Wason  <rectalogic@rectalogic.com>
425
426         Reviewed by Kenneth Russell.
427
428         Change ENABLE_3D_CANVAS to ENABLE_WEBGL
429         https://bugs.webkit.org/show_bug.cgi?id=53714
430
431         * Scripts/build-webkit: change --3d-canvas build option
432           to set ENABLE_WEBGL
433
434 2011-02-03  Hayato Ito  <hayato@chromium.org>
435
436         Reviewed by Tony Chang.
437
438         [NRWT] Introduces Input/Output class used by base.Driver into port/base.py and
439         move _run_single_test() and _process_output() functions from
440         dump_render_tree_thread.py to a single_test_runner.py as an individual module.
441
442         This is clean up and acts as a preparation for elimination of test_types/*
443         classes. These classes will move to the single_test_runner module introduced
444         in this patch.
445
446         https://bugs.webkit.org/show_bug.cgi?id=53004
447
448         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
449         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py: Added.
450         * Scripts/webkitpy/layout_tests/layout_package/test_input.py:
451         * Scripts/webkitpy/layout_tests/layout_package/test_output.py: Removed.
452         * Scripts/webkitpy/layout_tests/port/base.py:
453         * Scripts/webkitpy/layout_tests/port/chromium.py:
454         * Scripts/webkitpy/layout_tests/port/dryrun.py:
455         * Scripts/webkitpy/layout_tests/port/test.py:
456         * Scripts/webkitpy/layout_tests/port/webkit.py:
457         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
458         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
459         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
460
461 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
462
463         Unreviewed, build fix.
464
465         Delete a line that was accidentally missed in r77586; without it
466         there is still a race between the two threads.
467
468         https://bugs.webkit.org/show_bug.cgi?id=51572
469
470         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
471
472 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
473
474         Reviewed by Tony Chang.
475
476         nrwt: handle "broken pipe" notifications from DRT more cleanly.
477
478         https://bugs.webkit.org/show_bug.cgi?id=52927
479
480         * Scripts/webkitpy/layout_tests/port/server_process.py:
481         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
482
483 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
484
485         Reviewed by Kenneth Russell.
486
487         Update, resubmit change to bug 51572. I think the race that was
488         fixed in r76703 caused the hang that caused us to roll this
489         patch out before, so I'd like to try again.
490
491         https://bugs.webkit.org/show_bug.cgi?id=51572
492
493         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
494         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
495
496 2011-02-03  Daniel Cheng  <dcheng@chromium.org>
497
498         Unreviewed.
499
500         Adding myself to committers.py.
501
502         * Scripts/webkitpy/common/config/committers.py:
503
504 2011-02-03  Adam Roben  <aroben@apple.com>
505
506         Include the crashing function in the link to a crash log
507
508         Fixes <http://webkit.org/b/53739> Crash log links in results.html should include the
509         function that crashed
510
511         Reviewed by David Kilzer.
512
513         * Scripts/old-run-webkit-tests:
514         (crashLocation): Added. Returns the location of the crash.
515         (linksForErrorTest): Include the crash location in the link text for the crash log, if one
516         could be determined.
517
518 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
519
520         Unreviewed, build fix.
521
522         Actually make the changes suggested by Mihai in his review
523         of bug 53720 :(
524
525         https://bugs.webkit.org/show_bug.cgi?id=53720
526
527         * Scripts/webkitpy/layout_tests/port/test_files.py:
528         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
529
530 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
531
532         Reviewed by Mihai Parparita.
533
534         new-run-webkit-tests: Fix bug introduced in r77434 that was
535         causing us to run the canvas GPU tests on the Mac GPU port. This
536         bug revealed that we were not setting the port.name() field
537         properly in many cases, so I've cleaned up all of that code, and
538         removed a few comments about "version-specific" GPU ports that
539         don't exist and just confused things.
540
541         Testing also revealed that port.abspath_for_test() wasn't
542         normalizing paths on Windows properly, so I fixed that as well.
543
544         https://bugs.webkit.org/show_bug.cgi?id=53719
545
546         * Scripts/webkitpy/layout_tests/port/base.py:
547         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
548         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
549
550 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
551
552         Reviewed by Mihai Parparita.
553
554         new-run-webkit-tests: fix normalization of paths on windows when gathering files
555
556         r77434 introduced a bug that was causing the test expectations
557         for the GPU ports to not be treated properly. It turns out that
558         when we gathered the list of test files on Windows, we would
559         return paths of the form "c:\LayoutTests/fast/canvas", and the
560         mixture of backslashes and forward slashes was confusing things.
561
562         This patch normalizes all of the filenames returned from
563         test_files.find(), and adds better tests for this (fixing a
564         couple of other bugs found in the meantime).
565
566         https://bugs.webkit.org/show_bug.cgi?id=53720
567
568         * Scripts/webkitpy/layout_tests/port/test.py:
569         * Scripts/webkitpy/layout_tests/port/test_files.py:
570         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
571
572 2011-02-03  Adam Roben  <aroben@apple.com>
573
574         Add links to Windows crash logs in results.html
575
576         Fixes <http://webkit.org/b/53718> run-webkit-tests should link to Windows crash logs in
577         results.html
578
579         Reviewed by David Kilzer.
580
581         * Scripts/old-run-webkit-tests:
582         (top level): Added $crashLogTag and $windowsCrashLogFilePrefix (which came from
583         createDebuggerCommandFile).
584         (testCrashedOrTimedOut): If the test crashed, capture any saved crash log after the dump
585         tool has exited.
586         (captureSavedCrashLog): Added. Finds the crash log for the test that just crashed and moves
587         it into the test results directory tree. Only implemented for Cygwin currently.
588         (findNewestFileMatchingGlob): Added. Does what it says.
589         (htmlForResultsSection): Only link to files that exist.
590         (linksForErrorTest): Add a link to the crash log.
591         (deleteExpectedAndActualResults): Delete any old crash log for this test.
592         (createDebuggerCommandFile): Use the new $windowsCrashLogFilePrefix constant instead of
593         hardcoding it here.
594
595 2011-02-03  Adam Roben  <aroben@apple.com>
596
597         Tell the debugger the path to the WebKit source tree when saving a crash log
598
599         This allows the debugger to include the crashing line of code in the log.
600
601         Fixes <http://webkit.org/b/53678> Crash logs from buildslaves don't show the crashing line
602         of code
603
604         Reviewed by Sam Weinig.
605
606         * Scripts/old-run-webkit-tests:
607         (createDebuggerCommandFile): Added. Saves commands that we'd like the debugger to run to a
608         file and returns the path to that file. The commands we pass came from
609         setUpWindowsCrashLogSaving, but I've added a .srcpath command to tell the debugger where the
610         WebKit source code lives.
611         (setUpWindowsCrashLogSaving): Instead of specifying the commands directly on the command
612         line using -c, save them to a file and specify the path to that file using -cf. This works
613         around what is presumably a bug in Windows's command line parsing, where having multiple
614         quoted paths in the debugger commands causes the post-mortem debugger not to be invoked at
615         all. Also pulled the options we pass to the debugger out into a list that is then join()ed
616         together to make them easier to modify in the future.
617
618 2011-02-02  Sam Weinig  <sam@webkit.org>
619
620         Reviewed by Anders Carlsson.
621
622         Add notification of the end of a rubber band.
623         <rdar://problem/8940648>
624
625         * MiniBrowser/mac/BrowserWindowController.m:
626         (-[BrowserWindowController awakeFromNib]):
627         * WebKitTestRunner/TestController.cpp:
628         (WTR::TestController::createOtherPage):
629         (WTR::TestController::initialize):
630         Stub out the new WKUIClient function.
631
632 2011-02-03  Gabor Rapcsanyi  <rgabor@webkit.org>
633
634         Unreviewed.
635
636         Adding myself to committers.py.
637
638         * Scripts/webkitpy/common/config/committers.py:
639
640 2011-02-03  Balazs Kelemen  <kbalazs@webkit.org>
641
642         Reviewed by Csaba Osztrogonác.
643
644         [Qt][WK2] MiniBrowser's window size should be 800x600
645         https://bugs.webkit.org/show_bug.cgi?id=53670
646
647         Make layout test failure debugging easier.
648         * MiniBrowser/qt/BrowserWindow.cpp:
649         (BrowserWindow::BrowserWindow):
650
651 2011-02-02  Andy Estes  <aestes@apple.com>
652
653         Reviewed by Mark Rowe.
654
655         'update-webkit' should handle OpenSource and Internal using different
656         VCSs.
657
658         * Scripts/update-webkit: Re-check the VCS type when updating Apple's
659         Internal directory.
660
661 2011-02-02  Dirk Pranke  <dpranke@chromium.org>
662
663         Reviewed by Mihai Parparita.
664
665         new-run-webkit-tests: hardcode the directories to scan for tests
666         for GPU bots instead of SKIPping them. See bug 53562 for some
667         context, but we will now hard-code the list of directories to
668         use by default instead of skipping over directories in the
669         expectations file. We do this so that we will be able to merge
670         the expectations files without getting conflicting SKIP
671         directives. Note that this change will reduce the # of tests
672         being run on the Mac GPU bots, because we're accidentally
673         including some today.
674
675         https://bugs.webkit.org/show_bug.cgi?id=53631
676
677         * Scripts/webkitpy/layout_tests/port/base.py:
678         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
679         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
680
681 2011-02-02  Sam Weinig  <sam@webkit.org>
682
683         Reviewed by Beth Dakin.
684
685         Add ChromeClient function to paint custom overhang areas.
686         https://bugs.webkit.org/show_bug.cgi?id=53639
687
688         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
689         (WTR::InjectedBundlePage::InjectedBundlePage):
690         Stub out new callback.
691
692 2011-02-02  Dirk Pranke  <dpranke@chromium.org>
693
694         Reviewed by Tony Chang.
695
696         new-run-webkit-tests: support chromium code paths in mock_drt
697
698         https://bugs.webkit.org/show_bug.cgi?id=53471
699
700         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
701         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
702
703 2011-02-02  Adam Klein  <adamk@chromium.org>
704
705         Reviewed by Tony Chang.
706
707         Update new-run-webkit-tests --chromium to put output under Source/...
708         https://bugs.webkit.org/show_bug.cgi?id=53612
709
710         * BuildSlaveSupport/test-result-archive:
711         * Scripts/webkitpy/layout_tests/port/chromium.py:
712
713 2011-01-28  Tony Chang  <tony@chromium.org>
714
715         Reviewed by Eric Seidel.
716
717         [chromium] remove --use-test-shell from NRWT
718         https://bugs.webkit.org/show_bug.cgi?id=53346
719
720         I've already started removing some of the bindings like eventSender so
721         this already doesn't work isn't useful.  Also updated some comments to
722         refer to DRT instead of test_shell.
723
724         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
725         * Scripts/webkitpy/layout_tests/port/chromium.py:
726         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
727         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
728         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
729         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
730         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
731         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
732
733 2011-02-02  Steve Lacey  <sjl@chromium.org>
734
735         Reviewed by Eric Carlson.
736
737         Implement basic media statistics on media elements.
738         https://bugs.webkit.org/show_bug.cgi?id=53322
739
740         * Scripts/build-webkit:
741
742 2011-02-02  Kevin Ollivier  <kevino@theolliviers.com>
743
744         [wx] Build fixes for wxWebKit.
745
746         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
747         (LayoutTestController::setSerializeHTTPLoads):
748         * wx/browser/wscript:
749         * wx/build/build_utils.py:
750         * wx/build/settings.py:
751
752 2011-02-01  Dirk Pranke  <dpranke@chromium.org>
753
754         Reviewed by Mihai Parparita.
755
756         new-run-webkit-tests: stop skipping so many tests
757
758         r77163 introduced a regression where we weren't resetting test
759         expectations properly and were skipping too many tests as a
760         result. This patch fixes that and adds a test for it.
761
762         https://bugs.webkit.org/show_bug.cgi?id=53551
763
764         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
765         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
766
767 2011-02-01  Dirk Pranke  <dpranke@chromium.org>
768
769         Reviewed by Tony Chang.
770
771         new-run-webkit-tests: add first stub of test_runner2. This
772         will add support for the 'inline', 'threads', and 'processes'
773         flags to --worker-model, but for now the implementatios just
774         fall back on the old ones.
775
776         https://bugs.webkit.org/show_bug.cgi?id=53157
777
778         * Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
779         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
780
781 2011-02-01  Mihai Parparita  <mihaip@chromium.org>
782
783         Reviewed by James Robinson.
784
785         [Chromium] run-chromium-webkit-unit-tests looks for binaries in the wrong place
786         https://bugs.webkit.org/show_bug.cgi?id=53522
787
788         * Scripts/run-chromium-webkit-unit-tests:
789
790 2011-02-01  Adam Barth  <abarth@webkit.org>
791
792         Reviewed by Mihai Parparita.
793
794         Using Control-C to cancel webkit-patch or other python tools causes
795         unpleasant traceback console spew
796         https://bugs.webkit.org/show_bug.cgi?id=53462
797
798         Catch the exception and don't print the stack trace.
799
800         * Scripts/webkit-patch:
801
802 2011-02-01  Scott Cameron  <sccameron@rim.com>
803
804         Reviewed by Daniel Bates.
805
806         Use Windows format for MinGW HTTPD path.
807         https://bugs.webkit.org/show_bug.cgi?id=53503
808
809         * Scripts/webkitperl/httpd.pm:
810           - Use single-quotes around MySys value for $httpdPath in getHTTPDPath()
811             so that we don't have to escape the space characters in the path. Also,
812             changed path to Windows-style path and removed FIXME comment.
813
814 2011-02-01  Balazs Kelemen  <kbalazs@webkit.org>
815
816         Reviewed by Andreas Kling.
817
818         [Qt][WK2] Add a way to use shared process model in MiniBrowser
819         https://bugs.webkit.org/show_bug.cgi?id=53090
820
821         * MiniBrowser/qt/BrowserView.cpp:
822         (BrowserView::BrowserView): Removed the m_context member.
823         From now the context is guaranteed to be non-null and we
824         don't need to store that in the object.
825         * MiniBrowser/qt/BrowserView.h:
826         * MiniBrowser/qt/BrowserWindow.cpp:
827         Added static bool to determine that new windows need to be
828         created with their own context or not. Use the same context
829         and web process by default to be inilne with the other ports.
830         (BrowserWindow::BrowserWindow):
831         (BrowserWindow::newWindow):
832         * MiniBrowser/qt/BrowserWindow.h:
833         * MiniBrowser/qt/main.cpp:
834         (main): Added command line switch to be able to use the
835         non-shared process model. Simplify the handling of the command line
836         switches a little bit.
837
838 2011-02-01  Zoltan Horvath  <zoltan@webkit.org>
839
840         Reviewed by Andreas Kling.
841
842         [Qt] Add Window menu and Toggle FullScreen action to MiniBrowser.
843         https://bugs.webkit.org/show_bug.cgi?id=53491
844
845         * MiniBrowser/qt/BrowserWindow.cpp:
846         (BrowserWindow::BrowserWindow):
847         (BrowserWindow::toggleFullScreenMode):
848         * MiniBrowser/qt/BrowserWindow.h:
849
850 2011-02-01  Zoltan Horvath  <zoltan@webkit.org>
851
852         Reviewed by Andreas Kling.
853
854         [Qt] Add Toggle Frame Flattening, Auto Load Images and Disable JavaScript actions to MiniBrowser.
855         https://bugs.webkit.org/show_bug.cgi?id=53489
856
857         Add Toggle Frame Flattening action to Develop menu. Add Auto Load Images and Disable JavaScript actions
858         to Settings menu.
859
860         * MiniBrowser/qt/BrowserWindow.cpp:
861         (BrowserWindow::BrowserWindow):
862         (BrowserWindow::toggleFrameFlattening):
863         (BrowserWindow::toggleDisableJavaScript):
864         (BrowserWindow::toggleAutoLoadImages):
865         * MiniBrowser/qt/BrowserWindow.h:
866
867 2011-01-31  Mihai Parparita  <mihaip@chromium.org>
868
869         Reviewed by Tony Chang.
870
871         [Chromium] Switch chromium-mac to use ChromiumDriver
872         https://bugs.webkit.org/show_bug.cgi?id=53461
873         
874         For the sake of consistency with the other Chromium platforms (and so
875         that chromium-mac picks up special flags like --enable-hardware-gpu),
876         switch chromium-mac from the WebKitDriver to ChromiumDriver.
877
878         * Scripts/webkitpy/layout_tests/port/chromium.py:
879
880 2011-01-31  Dirk Pranke  <dpranke@chromium.org>
881
882         Reviewed by Mihai Parparita.
883
884         The current modifier parsing code in test_expectations is
885         fragile and hard-coded, so it's not easy to understand the logic
886         or easily add new types of modifiers (like GPU vs. CPU testing
887         for graphics tests, or 32-bit vs. 64-bit differences).
888
889         This is the first of two patches that will add in more generic
890         support and then eliminate the GPU-specific test expectations
891         files for Chromium.
892
893         This patch adds two standalone objects for handling modifiers. The
894         rules for interpreting modifiers, precedence, and conflicts are
895         given in the docstring to the ModifierMatcher class, which
896         returns ModifierMatchResult objects.
897         
898         This patch also adds routines to the Port interface and a
899         default set of values in the base object, in order to obtain the
900         values needed on a given test run. These values are then passed
901         to the expectation parser. This also allows us to clean up the
902         logic used to lint all of the different configurations in a
903         single test_expectations.txt file.
904
905         The next patch will merge in the separate GPU expectations file.
906
907         https://bugs.webkit.org/show_bug.cgi?id=51222
908
909         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
910         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
911         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
912         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
913         * Scripts/webkitpy/layout_tests/port/base.py:
914         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
915         * Scripts/webkitpy/layout_tests/port/chromium.py:
916         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
917         * Scripts/webkitpy/layout_tests/port/test.py:
918         * Scripts/webkitpy/layout_tests/port/webkit.py:
919         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
920         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
921         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
922         * Tools/Scripts/webkitpy/style/checkers/test_expectations.py:
923         * Tools/Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
924
925 2011-01-31  Scott Cameron  <sccameron@rim.com>
926
927         Reviewed by Daniel Bates.
928
929         update run-webkit-httpd to be able to launch Apache2.2 in a MSYS environment
930         https://bugs.webkit.org/show_bug.cgi?id=50036
931
932         This will add an Apache2.2 configuration file and modifies scripts to allow
933         running an httpd server in an MSYS environment.
934
935         The default Apache2.2 installation path has been preserved and PHP5 modules disabled
936         in order to allow for simple installation/execution.  Simply install the latest
937         Apache2.2 version with OpenSSL from http://httpd.apache.org/download.cgi#apache22 to
938         be able to execute run-webkit-httpd.
939         
940
941         * Scripts/run-webkit-httpd:
942         * Scripts/webkitperl/httpd.pm:
943
944 2011-01-31  Tony Chang  <tony@chromium.org>
945
946         Reviewed by Eric Seidel.
947
948         mac DRT should report RTL scroll offset relative to top right corner
949         https://bugs.webkit.org/show_bug.cgi?id=53324
950
951         * DumpRenderTree/mac/DumpRenderTree.mm:
952         (dumpFrameScrollPosition):
953
954 2011-01-31  Zoltan Horvath  <zoltan@webkit.org>
955
956         Reviewed by Andreas Kling.
957
958         [Qt] Add Take Screen Shot action to MiniBrowser
959         https://bugs.webkit.org/show_bug.cgi?id=53422
960
961         Add Take Screen Shot action to MiniBrowser's view menu.
962
963         * MiniBrowser/qt/BrowserWindow.cpp:
964         (BrowserWindow::BrowserWindow):
965         (BrowserWindow::screenshot):
966         * MiniBrowser/qt/BrowserWindow.h:
967
968 2011-01-31  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
969
970         Reviewed by Xan Lopez.
971
972         [GTK] REGRESSION:  http/tests/media/video-{cookie,referer}.html failing
973         https://bugs.webkit.org/show_bug.cgi?id=53379
974
975         Remove left over #ifdef's. I thought all of the conditional code
976         had been freed from the condition, but I forgot to check DRT.
977
978         * DumpRenderTree/gtk/DumpRenderTree.cpp:
979         (resetDefaultsToConsistentValues):
980         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
981         (LayoutTestController::setAlwaysAcceptCookies):
982
983 2011-01-30  Dirk Pranke  <dpranke@chromium.org>
984
985         Unreviewed, build fix.
986
987         Fix regression introduced in r77093 - path.rsplit() doesn't
988         take keyword arguments.
989
990         https://bugs.webkit.org/show_bug.cgi?id=53326
991
992         * Scripts/webkitpy/common/system/filesystem_mock.py:
993
994 2011-01-30  Dirk Pranke  <dpranke@chromium.org>
995
996         Reviewed by Mihai Parparita.
997
998         Add more unit tests for rebaseline-chromium-webkit-tests. This
999         change involves restructuring a bunch of r-c-w-t code to make it
1000         more testable as well. We also add wrapper classes for handling
1001         testing zip files and fetching URLs.
1002
1003         https://bugs.webkit.org/show_bug.cgi?id=53040
1004
1005         * Scripts/webkitpy/common/system/urlfetcher.py:
1006         * Scripts/webkitpy/common/system/urlfetcher_mock.py:
1007         * Scripts/webkitpy/common/system/zipfileset_mock.py:
1008         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1009         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
1010         * Scripts/webkitpy/tool/mocktool.py:
1011
1012 2011-01-30  Dirk Pranke  <dpranke@chromium.org>
1013
1014         Reviewed by Eric Seidel.
1015
1016         Clean up of the filesystem-related modules used in webkitpy.
1017         I've added relpath() to the filesystem interface, modified
1018         ospath.relpath() so that it could work with the filesystem
1019         interface, and modified the fileset* routines to use the
1020         filesystem interface consistently.
1021
1022         This patch also adds a close() routine to the fileset routines
1023         to indicate that the caller is done with the fileset. This
1024         allows zipfileset to clean up after itself when it creates
1025         tempfiles to store downloads.
1026
1027         https://bugs.webkit.org/show_bug.cgi?id=53326
1028
1029         * Scripts/webkitpy/common/system/directoryfileset.py:
1030         * Scripts/webkitpy/common/system/fileset.py:
1031         * Scripts/webkitpy/common/system/filesystem.py:
1032         * Scripts/webkitpy/common/system/filesystem_mock.py:
1033         * Scripts/webkitpy/common/system/filesystem_unittest.py:
1034         * Scripts/webkitpy/common/system/ospath.py:
1035         * Scripts/webkitpy/common/system/zipfileset.py:
1036         * Scripts/webkitpy/common/system/zipfileset_unittest.py:
1037
1038 2011-01-30  Balazs Kelemen  <kbalazs@webkit.org>
1039
1040         Reviewed by Csaba Osztrogonác.
1041
1042         [Qt][WK2]REGRESSION (r76991): Fix build errors
1043         https://bugs.webkit.org/show_bug.cgi?id=53400
1044
1045         Revert the temporary build fix (http://trac.webkit.org/changeset/77088)
1046         and remove WebKit2Prefix.h from the build.
1047         * MiniBrowser/qt/MiniBrowser.pro:
1048
1049 2011-01-30  Csaba Osztrogonác  <ossy@webkit.org>
1050
1051         Unreviewed.
1052
1053         [Qt][WK2] Buildfix.
1054
1055         * MiniBrowser/qt/MiniBrowser.pro:
1056
1057 2011-01-28  Simon Fraser  <simon.fraser@apple.com>
1058
1059         Reviewed by Adam Roben.
1060         
1061         define NOMINMAX when building ImageDiff, as we do elsewhere.
1062
1063         Add various clampToInt() methods to MathExtras.h
1064         https://bugs.webkit.org/show_bug.cgi?id=52910
1065
1066         * DumpRenderTree/win/ImageDiffCommon.vsprops:
1067
1068 2011-01-28  Maciej Stachowiak  <mjs@apple.com>
1069
1070         Reviewed by Darin Adler.
1071
1072         WebKitTestRunner needs layoutTestController.setPOSIXLocale
1073         https://bugs.webkit.org/show_bug.cgi?id=42682
1074
1075         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1076         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1077         (WTR::InjectedBundle::resetLocalSettings):
1078         (WTR::InjectedBundle::didReceiveMessage):
1079         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1080         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1081         (WTR::LayoutTestController::setPOSIXLocale):
1082         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1083
1084 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
1085  
1086          Reviewed by Mihai Parparita.
1087  
1088          test-webkitpy: fix webkitpy.layout_tests.port.mac_unittest.MacTest.test_skipped_file_paths
1089  
1090          This patch re-enables this test and changes it to
1091          handle all of the mac platform versions, not just the one
1092          it is running on.
1093  
1094          https://bugs.webkit.org/show_bug.cgi?id=53356
1095  
1096          * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1097  
1098 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
1099
1100         Unreviewed, build fix.
1101
1102         Take two. The fix in 77023 didn't work, because we were
1103         still calling path.abspath_to_uri, which calls _cygpath under
1104         the covers, and it appears the cygpath on the bots does
1105         something different than it does on my machine. This patch
1106         removes the calls to path.abspath_to_uri, so it should be safe.
1107         If it doesn't work, I'll roll it out along with r76982 and 77023.
1108
1109         https://bugs.webkit.org/show_bug.cgi?id=53126
1110
1111         * Scripts/webkitpy/layout_tests/port/test.py:
1112
1113 2011-01-28  David Kilzer  <ddkilzer@apple.com>
1114
1115         <rdar://problem/8930699> build-webkit gives a bogus warning with newer versions of Xcode 
1116         <http://webkit.org/b/53353>
1117
1118         Reviewed by Mark Rowe.
1119
1120         * Scripts/webkitdirs.pm:
1121         (checkRequiredSystemConfig): Check the Xcode marketing version
1122         in addition to the DevCoreTools build version before complaining
1123         about an old version of Xcode.  Also make the Mac OS X version
1124         check use Perl's built-in version string comparitor.
1125
1126 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
1127
1128         Unreviewed, build fix.
1129
1130         Work around breakage on Win 7 Release bot caused by r76982
1131         and the fact that windows ports use "file:////" instead of
1132         "file:///". Ideally the test code should be isolated from
1133         this, but it isn't yet. Will fix properly in a bit.
1134
1135         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
1136
1137 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
1138
1139         Reviewed by Tony Chang.
1140
1141         new-run-webkit-tests: change worker model values to
1142         "old-inline", "old-threads" in preparation for test_runner2 /
1143         multiprocessing changes.
1144
1145         https://bugs.webkit.org/show_bug.cgi?id=53156
1146
1147         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1148         * Scripts/webkitpy/layout_tests/port/base.py:
1149         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1150         * Scripts/webkitpy/layout_tests/port/mac.py:
1151         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1152
1153 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
1154
1155         Reviewed by Tony Chang.
1156
1157         committers.py - add an IRC nickname for dpranke
1158         https://bugs.webkit.org/show_bug.cgi?id=53335
1159
1160         * Scripts/webkitpy/common/config/committers.py:
1161
1162 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
1163
1164         Reviewed by Tony Chang.
1165
1166         new-run-webkit-tests: add a "mock DRT" port implementation
1167         and a separate class that emulates what we expect the
1168         DumpRenderTree behavior to be.
1169
1170         This will eventually replace port/dryrun.py and allow us to get
1171         better test coverage of the new-run-webkit-tests code as well as
1172         a reference for what new-run-webkit-tests expects from DRT.
1173
1174         This is the first attempt at this, and it is pretty bare-boned. It
1175         really only has been tested on the 'mac' port (and a little on
1176         the 'chromium-mac' port.
1177
1178         https://bugs.webkit.org/show_bug.cgi?id=53126
1179
1180         * Scripts/webkitpy/common/system/filesystem_mock.py:
1181         * Scripts/webkitpy/layout_tests/port/dryrun.py:
1182         * Scripts/webkitpy/layout_tests/port/factory.py:
1183         * Scripts/webkitpy/layout_tests/port/mock_drt.py: Added.
1184         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Added.
1185         * Scripts/webkitpy/layout_tests/port/test.py:
1186
1187 2011-01-28  Pratik Solanki  <psolanki@apple.com>
1188
1189         Unreviewed. Removing .swp file checked in by mistake.
1190
1191         * Scripts/.webkitdirs.pm.swp: Removed.
1192
1193 2011-01-28  Pratik Solanki  <psolanki@apple.com>
1194
1195         Reviewed by David Kilzer.
1196
1197         Space not necessary for undefined feature
1198         https://bugs.webkit.org/show_bug.cgi?id=53317
1199
1200         * Scripts/build-webkit:
1201
1202 2011-01-28  Chang Shu  <chang.shu@nokia.com>
1203
1204         Reviewed by Andreas Kling.
1205
1206         Reset NetworkAccessManager to clean up credentials from previous tests.
1207         This change causes no performance overhead either.
1208         https://bugs.webkit.org/show_bug.cgi?id=36688
1209
1210         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1211         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1212         (WebCore::DumpRenderTree::open):
1213         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1214
1215 2011-01-28  Zoltan Horvath  <zoltan@webkit.org>
1216
1217         Reviewed by Andreas Kling.
1218
1219         [Qt] Add Zoom Text Only action to MiniBrowser
1220         https://bugs.webkit.org/show_bug.cgi?id=53297
1221
1222         Add Zoom Text Only action to MiniBrowser's view menu, change zoom levels to avoid unnecessary divides.
1223
1224         * MiniBrowser/qt/BrowserWindow.cpp:
1225         (BrowserWindow::BrowserWindow):
1226         (BrowserWindow::zoomIn):
1227         (BrowserWindow::zoomOut):
1228         (BrowserWindow::resetZoom):
1229         (BrowserWindow::toggleZoomTextOnly):
1230         (BrowserWindow::applyZoom):
1231         * MiniBrowser/qt/BrowserWindow.h:
1232
1233 2011-01-28  Adam Barth  <abarth@webkit.org>
1234
1235         Reviewed by Eric Seidel.
1236
1237         Add webkit-patch roll-chromium-deps
1238         https://bugs.webkit.org/show_bug.cgi?id=53288
1239
1240         This command updates the Source/WebKit/chromium/DEPS file with the
1241         last-known good revision of Chromium (or a revision specified on the
1242         command line).  I'd eventually like to turn this into a SheriffBot
1243         command, but this is the first step.
1244
1245         This patch somewhat sprawled because I needed to move a bunch of code
1246         out of ChangeLog that should never have been there in the first place.
1247         Also, I had to fix a bug in MockUser in order to test the new command.
1248
1249         * Scripts/webkitpy/common/checkout/api.py:
1250         * Scripts/webkitpy/common/checkout/changelog.py:
1251         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1252         * Scripts/webkitpy/common/checkout/deps.py: Added.
1253         * Scripts/webkitpy/common/config/urls.py:
1254         * Scripts/webkitpy/tool/commands/__init__.py:
1255         * Scripts/webkitpy/tool/commands/download_unittest.py:
1256         * Scripts/webkitpy/tool/commands/roll.py: Added.
1257         * Scripts/webkitpy/tool/commands/roll_unittest.py: Added.
1258         * Scripts/webkitpy/tool/commands/upload_unittest.py:
1259         * Scripts/webkitpy/tool/mocktool.py:
1260         * Scripts/webkitpy/tool/steps/__init__.py:
1261         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py: Added.
1262         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
1263         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py: Added.
1264         * Scripts/webkitpy/tool/steps/suggestreviewers_unittest.py:
1265         * Scripts/webkitpy/tool/steps/updatechromiumdeps.py: Added.
1266         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
1267
1268 2011-01-27  Greg Coletta  <greg.coletta@nokia.com>
1269
1270         Reviewed by Laszlo Gombos.
1271
1272         Get rid of prefix header dependency for WebKit2 build system
1273         https://bugs.webkit.org/show_bug.cgi?id=50174
1274
1275         Change the style checker so that it enforces config.h include for
1276         WebKit2.
1277
1278         * Scripts/webkitpy/style/checker.py:
1279
1280 2011-01-27  Maciej Stachowiak  <mjs@apple.com>
1281
1282         Reviewed by Darin Adler.
1283
1284         execCommand("Paste") doesn't work in WebKitTestRunner
1285         https://bugs.webkit.org/show_bug.cgi?id=52785
1286
1287         Enable both of the settings needed to allow paste.
1288         
1289         * WebKitTestRunner/TestController.cpp:
1290         (WTR::TestController::resetStateToConsistentValues):
1291
1292 2011-01-27  Jacob Dinu  <dinu.jacob@nokia.com>
1293
1294         Reviewed by Andreas Kling.
1295
1296         [Qt] QtTestBrowser: User input lost when toggling use of QGraphicsView
1297         https://bugs.webkit.org/show_bug.cgi?id=48440
1298
1299         Preserve user input when toggling use of QGraphicsView
1300
1301         * QtTestBrowser/launcherwindow.cpp:
1302         (LauncherWindow::initializeView):
1303         (LauncherWindow::loadFinished):
1304         * QtTestBrowser/launcherwindow.h:
1305         * QtTestBrowser/mainwindow.cpp:
1306         (MainWindow::addressUrl):
1307         * QtTestBrowser/mainwindow.h:
1308
1309 2011-01-27  Dirk Pranke  <dpranke@chromium.org>
1310
1311         Reviewed by Mihai Parparita.
1312
1313         new-run-webkit-tests: turn off pixel tests correctly by default
1314         for webkit-based ports. r70013 (bug 47510) used
1315         port.set_option_default() to attempt to set default values, but
1316         that didn't work correctly. I have removed set_option_default
1317         for now since it was only being used in two places and in three
1318         useless unit tests. There is a separate bug open to fix the
1319         option parsing (48095), so this workaround is fine for now.
1320
1321         https://bugs.webkit.org/show_bug.cgi?id=53217
1322
1323         * Scripts/webkitpy/layout_tests/port/webkit.py:
1324         * Scripts/webkitpy/layout_tests/port/base.py:
1325         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1326
1327 2011-01-27  Balazs Kelemen  <kbalazs@webkit.org>
1328
1329         Rubber-stamped by Ariya Hidayat.
1330
1331         Trivial crash fix in WTR.
1332
1333         * WebKitTestRunner/TestController.cpp:
1334         (WTR::TestController::initialize): Increase the size
1335         of the vector by one to be able to store the null character.
1336
1337 2011-01-27  Balazs Kelemen  <kbalazs@webkit.org>
1338
1339         Reviewed by Csaba Osztrogonác.
1340
1341         [Qt][WK2] WTR should be initialized in the same way as DRT
1342         https://bugs.webkit.org/show_bug.cgi?id=53240
1343
1344         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
1345         (WTR::activateFonts): Added missing initialization steps.
1346
1347 2011-01-27  Joone Hur <joone.hur@collabora.co.uk>
1348
1349         Unreviewed. 
1350
1351         Adding myself to committers.py.
1352
1353         * Scripts/webkitpy/common/config/committers.py:
1354
1355 2011-01-27  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1356
1357         Reviewed by Csaba Osztrogonác.
1358
1359         [Qt] [Symbian] Move project files into Source
1360         https://bugs.webkit.org/show_bug.cgi?id=52891
1361
1362         Fix the Symbian build after the project files
1363         are moved to Source directory. On Symbian qmake
1364         needs to run in the same directory where the main
1365         pro files (WebKit.pro, Tools.pro) are located.
1366
1367         * Scripts/webkitdirs.pm: Change to the directory where the pro file
1368         is located before running qmake for Symbian. Qmake on Symbian
1369         does not properly honor the "-o" option, work it around by setting
1370         the name of the Makefile to bld.inf.
1371
1372 2011-01-27  Zoltan Horvath  <zoltan@webkit.org>
1373
1374         Reviewed by Andreas Kling.
1375
1376         [Qt] Add simple zooming features to MiniBrowser
1377         https://bugs.webkit.org/show_bug.cgi?id=53231
1378
1379         Add View menu and Zoom In, Zoom Out, Zoom Reset actions to MiniBrowser.
1380
1381         * MiniBrowser/qt/BrowserWindow.cpp:
1382         (BrowserWindow::BrowserWindow):
1383         (BrowserWindow::zoomIn):
1384         (BrowserWindow::zoomOut):
1385         (BrowserWindow::resetZoom):
1386         (BrowserWindow::updateUserAgentList):
1387         (BrowserWindow::applyZoom):
1388         * MiniBrowser/qt/BrowserWindow.h:
1389
1390 2011-01-26  Maciej Stachowiak  <mjs@apple.com>
1391
1392         Reviewed by Dan Bernstein.
1393
1394         WebKitTestRunner needs to support layoutTestController.evaluateInWebInspector
1395         https://bugs.webkit.org/show_bug.cgi?id=42319
1396         
1397         Add evaluateInWebInspector and other APIs needed for inspector tests to run.
1398
1399         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1400         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1401         (WTR::LayoutTestController::showWebInspector):
1402         (WTR::LayoutTestController::closeWebInspector):
1403         (WTR::LayoutTestController::evaluateInWebInspector):
1404         (WTR::LayoutTestController::setTimelineProfilingEnabled):
1405         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1406         * WebKitTestRunner/TestInvocation.cpp:
1407         (WTR::shouldOpenWebInspector):
1408         (WTR::TestInvocation::invoke):
1409         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
1410
1411 2011-01-26  Martin Robinson  <mrobinson@igalia.com>
1412
1413         Reviewed by Xan Lopez.
1414
1415         [GTK] Pixel dumps do not include scrollbars in output images
1416         https://bugs.webkit.org/show_bug.cgi?id=53216
1417
1418         Show scrollbars in pixel dumps. This will fix pixel dumps for tests
1419         that have scrollbars.
1420
1421         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
1422         (createBitmapContextFromWebView): Take the snapshot of the containing GtkScrolledWindow
1423         instead of the web view itself.
1424
1425 2011-01-26  Dirk Pranke  <dpranke@chromium.org>
1426
1427         Reviewed by Mihai Parparita.
1428
1429         Fix regression introduced in r76322 ... new-run-webkit-tests
1430         was attempting to save the image diff output as a UTF-8-encoded
1431         file.
1432
1433         https://bugs.webkit.org/show_bug.cgi?id=53210
1434
1435         * Scripts/webkitpy/layout_tests/port/webkit.py:
1436
1437 2011-01-26  Sheriff Bot  <webkit.review.bot@gmail.com>
1438
1439         Unreviewed, rolling out r76709.
1440         http://trac.webkit.org/changeset/76709
1441         https://bugs.webkit.org/show_bug.cgi?id=53194
1442
1443         "broke python tests on non-snowleopard platforms" (Requested
1444         by dpranke on #webkit).
1445
1446         * Scripts/webkitpy/layout_tests/port/factory.py:
1447         * Scripts/webkitpy/layout_tests/port/mock_drt.py: Removed.
1448         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Removed.
1449
1450 2011-01-26  Dirk Pranke  <dpranke@chromium.org>
1451
1452         Reviewed by Tony Chang.
1453
1454         new-run-webkit-tests: add a "mock DRT" port implementation
1455         and a separate class that emulates what we expect the
1456         DumpRenderTree behavior to be.
1457
1458         This will eventually replace port/dryrun.py and allow us to get
1459         better test coverage of the new-run-webkit-tests code as well as
1460         a reference for what new-run-webkit-tests expects from DRT.
1461
1462         This is the first attempt at this, and it is pretty bare-boned. It
1463         really only has been tested on the 'mac' port (and a little on
1464         the 'chromium-mac' port.
1465
1466         https://bugs.webkit.org/show_bug.cgi?id=53126
1467
1468         * Scripts/webkitpy/layout_tests/port/mock_drt.py: Added.
1469         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Added.
1470         * Scripts/webkitpy/layout_tests/port/factory.py:
1471
1472 2011-01-26  Xianzhu Wang  <wangxianzhu@google.com>
1473
1474         Reviewed by Tony Chang.
1475
1476         Add '--no-timeout' option to Chromium DRT to ease debugging.
1477         https://bugs.webkit.org/show_bug.cgi?id=52873
1478
1479         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1480         (main):
1481
1482 2011-01-26  Csaba Osztrogonác  <ossy@webkit.org>
1483
1484         Reviewed by Andreas Kling.
1485
1486         [Qt] Fix qt_minimal build
1487         https://bugs.webkit.org/show_bug.cgi?id=53172
1488
1489         * QtTestBrowser/locationedit.h:
1490
1491 2011-01-26  Mansi Mithal  <mansi.mithal@nokia.com>
1492
1493         Reviewed by Antonio Gomes.
1494
1495         QtTestBrowser should have a UI Setting to disable plugins
1496         https://bugs.webkit.org/show_bug.cgi?id=52408
1497         
1498         Added a new action item named "Disable Plugins"
1499         under the "Settings" menu. 
1500
1501         * QtTestBrowser/launcherwindow.cpp:
1502         (LauncherWindow::createChrome):
1503         (LauncherWindow::togglePlugins):
1504         * QtTestBrowser/launcherwindow.h:
1505
1506 2011-01-25  Patrick Gansterer  <paroga@webkit.org>
1507
1508         Reviewed by Adam Barth.
1509
1510         Move main CMakeLists.txt into Source directory
1511         https://bugs.webkit.org/show_bug.cgi?id=52888
1512
1513         * Scripts/webkitdirs.pm:
1514
1515 2011-01-25  Patrick Gansterer  <paroga@webkit.org>
1516
1517         Reviewed by Eric Seidel.
1518
1519         Improve label text in submit-to-ews
1520         https://bugs.webkit.org/show_bug.cgi?id=53130
1521
1522         * QueueStatusServer/templates/submittoews.html:
1523
1524 2011-01-25  Mansi Mithal  <mansi.mithal@nokia.com>
1525
1526         Reviewed by Antonio Gomes.
1527
1528         QtTestBrowser should have a UI Settings to prevent loading images
1529         https://bugs.webkit.org/show_bug.cgi?id=52409
1530         
1531         Added a new action item named "DisableAutoLoadImages"
1532         under the "Settings" menu 
1533
1534         * QtTestBrowser/launcherwindow.cpp:
1535         (LauncherWindow::createChrome):
1536         (LauncherWindow::toggleAutoLoadImages):
1537         * QtTestBrowser/launcherwindow.h:
1538
1539 2011-01-25  Dirk Pranke  <dpranke@chromium.org>
1540
1541         Reviewed by Tony Chang.
1542
1543         Minor bug fixes and cleanup for filesystem wrappers, port/* test
1544         classes, test_expectations.py. This change adds "test-win" and
1545         "test-mac" variants to the test port so that we can better test
1546         rebaselining, and adds a MockUser() object for reuse in testing.
1547
1548         https://bugs.webkit.org/show_bug.cgi?id=53036
1549
1550         * Scripts/webkitpy/common/system/filesystem.py:
1551         * Scripts/webkitpy/common/system/filesystem_mock.py:
1552         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1553         * Scripts/webkitpy/layout_tests/port/factory.py:
1554         * Scripts/webkitpy/layout_tests/port/base.py:
1555         * Scripts/webkitpy/layout_tests/port/test.py:
1556         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1557         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
1558         * Scripts/webkitpy/tool/mocktool.py:
1559
1560 2011-01-25  Tony Chang  <tony@chromium.org>
1561
1562         Reviewed by Dimitri Glazkov.
1563
1564         [chromium] remove unused layoutTestController callback
1565         https://bugs.webkit.org/show_bug.cgi?id=53103
1566
1567         This method is used by a test_shell_test, but not needed by DRT.
1568
1569         * DumpRenderTree/chromium/LayoutTestController.cpp:
1570         (LayoutTestController::LayoutTestController):
1571         * DumpRenderTree/chromium/LayoutTestController.h:
1572
1573 2011-01-25  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1574
1575         Reviewed by Andreas Kling.
1576
1577         [GTK] Remove 64 bits release bot from the buildbot master
1578         https://bugs.webkit.org/show_bug.cgi?id=52899
1579
1580         Removes the 64 bits release slave from the buildbot configuration,
1581         so that we can use it as an EWS.
1582
1583         * BuildSlaveSupport/build.webkit.org-config/config.json:
1584
1585 2011-01-24  Maciej Stachowiak  <mjs@apple.com>
1586
1587         Reviewed by Dan Bernstein.
1588
1589         Implement database quota callback to fix storage tests on WebKit2 bot
1590         https://bugs.webkit.org/show_bug.cgi?id=53064
1591
1592         * WebKitTestRunner/TestController.cpp:
1593         (WTR::exceededDatabaseQuota):
1594         (WTR::TestController::createOtherPage):
1595         (WTR::TestController::initialize):
1596
1597 2011-01-24  Maciej Stachowiak  <mjs@apple.com>
1598
1599         Reviewed by Anders Carlsson.
1600
1601         Use designated temp directory for the database for WebKit2
1602         https://bugs.webkit.org/show_bug.cgi?id=53052
1603         
1604         Adopt the new WK2 API for this.
1605
1606         * WebKitTestRunner/TestController.cpp:
1607         (WTR::TestController::libraryPathForTesting):
1608         (WTR::TestController::initialize):
1609         * WebKitTestRunner/TestController.h:
1610         * WebKitTestRunner/mac/TestControllerMac.mm:
1611         (WTR::TestController::platformLibraryPathForTesting):
1612         * WebKitTestRunner/qt/TestControllerQt.cpp:
1613         (WTR::TestController::platformLibraryPathForTesting):
1614         * WebKitTestRunner/win/TestControllerWin.cpp:
1615         (WTR::TestController::platformLibraryPathForTesting):
1616
1617 2011-01-24  Lucas Forschler  <lforschler@apple.com>
1618
1619         Reviewed by Stephanie Lewis.
1620
1621         Add a new Leopard test bot.
1622
1623         * BuildSlaveSupport/build.webkit.org-config/config.json:
1624
1625 2011-01-24  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1626
1627         Reviewed by Adam Barth.
1628
1629         Add EFL Builder to core waterfall
1630         https://bugs.webkit.org/show_bug.cgi?id=52704
1631
1632         Add EFL Builder to the core waterfall again.
1633
1634         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1635         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1636
1637 2011-01-24  Xianzhu Wang  <wangxianzhu@google.com>
1638
1639         Reviewed by Tony Chang.
1640
1641         new-run-webkit-tests fails to start HTTP server if there are proxy settings
1642         https://bugs.webkit.org/show_bug.cgi?id=52872
1643
1644         Force disabling proxy to resolve the problem.
1645
1646         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
1647         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
1648
1649 2011-01-24  Andreas Kling  <kling@webkit.org>
1650
1651         Reviewed by Darin Adler.
1652
1653         check-webkit-style: Update exemptions following Source/ move.
1654         https://bugs.webkit.org/show_bug.cgi?id=53017
1655
1656         * Scripts/webkitpy/style/checker.py:
1657         * Scripts/webkitpy/style/checker_unittest.py:
1658
1659 2011-01-24  Andras Becsi  <abecsi@webkit.org>
1660
1661         Rubber-stamped by Csaba Osztrogonác.
1662
1663         [Qt] Move project files into Source
1664         https://bugs.webkit.org/show_bug.cgi?id=52891
1665
1666         * DumpRenderTree/qt/ImageDiff.pro: Add missing "Source" to WebKit.pri path
1667
1668 2011-01-24  Mikhail Naganov  <mnaganov@chromium.org>
1669
1670         Reviewed by Yury Semikhatsky.
1671
1672         Web Inspector: Find duplicate strings in localizedStrings.js
1673
1674         https://bugs.webkit.org/show_bug.cgi?id=53005
1675
1676         * Scripts/check-inspector-strings:
1677
1678 2011-01-24  Zoltan Horvath  <zoltan@webkit.org>
1679
1680         Reviewed by Andreas Kling.
1681
1682         [Qt] Regroup MiniBrowser's menubar and add open file action
1683         https://bugs.webkit.org/show_bug.cgi?id=53000
1684
1685         Add File and Develop menu to MiniBrowser's menubar and add open file action to File menu.
1686
1687         * MiniBrowser/qt/BrowserWindow.cpp:
1688         (BrowserWindow::BrowserWindow):
1689         (BrowserWindow::openFile):
1690         (BrowserWindow::~BrowserWindow):
1691         * MiniBrowser/qt/BrowserWindow.h:
1692
1693 2011-01-24  Csaba Osztrogonác  <ossy@webkit.org>
1694
1695         Unreviewed fix after r76496
1696
1697         [Qt] Move project files into Source
1698         https://bugs.webkit.org/show_bug.cgi?id=52891
1699
1700         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Remove unnecessary "Source" from the path.
1701         * BuildSlaveSupport/built-product-archive: Remove unnecessary "Source" from the path.
1702         * Scripts/webkitdirs.pm: Add the accidentally removed slash to the path.
1703
1704 2011-01-24  Andras Becsi  <abecsi@webkit.org>
1705
1706         Reviewed by Csaba Osztrogonác.
1707
1708         [Qt] Move project files into Source
1709         https://bugs.webkit.org/show_bug.cgi?id=52891
1710
1711         * DerivedSources.pro: Renamed from DerivedSources.pro.
1712         * DumpRenderTree/qt/DumpRenderTree.pro:
1713         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1714         * MiniBrowser/DerivedSources.pro:
1715         * MiniBrowser/qt/MiniBrowser.pro:
1716         * QtTestBrowser/QtTestBrowser.pro:
1717         * Scripts/webkitdirs.pm:
1718         * Tools.pro: Added.
1719         * WebKitTestRunner/DerivedSources.pro:
1720         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1721         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1722
1723 2011-01-22  Geoffrey Garen  <ggaren@apple.com>
1724
1725         Reviewed by Dan Bernstein.
1726
1727         Beefed up --threaded mode to catch even more kinds of errors.
1728         https://bugs.webkit.org/show_bug.cgi?id=52971
1729
1730         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Use a shared
1731         context group to force JSC to mark multiple threads. (This used to be
1732         the default, but it changed in SnowLeopard.)
1733         (runJavaScriptThread): Do more locking and unlocking, and more allocation,
1734         to give threading mistakes more chances to show themselves.
1735         (startJavaScriptThreads):
1736         (stopJavaScriptThreads):
1737
1738 2011-01-22  Robert Hogan  <robert@webkit.org>
1739
1740         Reviewed by Andreas Kling.
1741
1742         [Qt] Support layoutTestController.addURLToRedirect()
1743         https://bugs.webkit.org/show_bug.cgi?id=52956
1744
1745         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1746         (LayoutTestController::addURLToRedirect):
1747         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1748
1749 2011-01-22  Robert Hogan  <robert@webkit.org>
1750
1751         Reviewed by Kenneth Rohde Christiansen.
1752
1753         [Qt] REGRESSION (r72360): http/tests/security/aboutBlank/xss-DENIED-* tests fail
1754         https://bugs.webkit.org/show_bug.cgi?id=49802
1755
1756         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1757         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1758         (WebCore::DumpRenderTree::open):
1759
1760 2011-01-21  Adam Barth  <abarth@webkit.org>
1761
1762         Reviewed by Maciej Stachowiak.
1763
1764         Disable mac_unittest.py that fails on some of the Mac bots
1765         https://bugs.webkit.org/show_bug.cgi?id=52947
1766
1767         As noted in the comment, this test does not appear to be correct
1768         because the function this test is testing returns different results
1769         depending on which flavor of Mac the test is run on.  This patch
1770         disable the test.  Hopefully we can re-enable the test once we've
1771         probably insulated the test from its environment.
1772
1773         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1774
1775 2011-01-21  Dirk Pranke  <dpranke@chromium.org>
1776
1777         Reviewed by Mihai Parparita.
1778
1779         Fix bug introduced in r76322 that caused NRWT to not actually
1780         read the Skipped files properly.
1781
1782         https://bugs.webkit.org/show_bug.cgi?id=52771
1783
1784         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1785         * Scripts/webkitpy/layout_tests/port/webkit.py:
1786         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1787
1788 2011-01-21  Sam Weinig  <sam@webkit.org>
1789
1790         Reviewed by Geoffrey Sean Garen and Mark Rowe.
1791
1792         WebKitTestRunner needs the HOME environment variable to be set.
1793         <rdar://problem/8896573>
1794
1795         * Scripts/old-run-webkit-tests: Set the HOME environment variable if
1796         it exists.
1797
1798 2011-01-21  Dirk Pranke  <dpranke@chromium.org>
1799
1800         Reviewed by Eric Seidel.
1801
1802         Suppress a few remaining integration tests so that none of the
1803         layout_test unit tests ever read from the filesystem or launch
1804         subprocesses that aren't part of the unit tests.
1805
1806         Also fix a minor bug in the printing unit tests that was
1807         incorrectly relying on sys.argv.
1808
1809         https://bugs.webkit.org/show_bug.cgi?id=52863
1810
1811         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1812         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1813         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1814
1815 2011-01-21  Darin Adler  <darin@apple.com>
1816
1817        Fix Mac build.
1818
1819         * MiniBrowser/mac/BrowserWindowController.m:
1820         (-[BrowserWindowController awakeFromNib]): Pass 0 for runModal function.
1821
1822 2011-01-20  Darin Adler  <darin@apple.com>
1823
1824         Reviewed by Dan Bernstein.
1825
1826         WebKit2: Implement showModalDialog
1827         https://bugs.webkit.org/show_bug.cgi?id=52855
1828
1829         This fixes WebKitTestRunner to compile, but more work is probably
1830         needed to get it to pass the tests.
1831
1832         * WebKitTestRunner/TestController.cpp:
1833         (WTR::TestController::runModal): Added. Calls through to the
1834         platform-specific version of runModal.
1835         (WTR::TestController::createOtherPage): Changed to be a private
1836         static member function so it can refer to runModal, which is
1837         a private static member function.
1838         (WTR::TestController::initialize): Pass 0 for the runModal
1839         function since we don't need to run the main window modal.
1840         I suspect this is wrong and will need to change.
1841         * WebKitTestRunner/TestController.h: Added declarations for
1842         the functions added above.
1843         * WebKitTestRunner/mac/TestControllerMac.mm:
1844         (WTR::TestController::runModal): Added. Untested implementation.
1845         * WebKitTestRunner/qt/TestControllerQt.cpp:
1846         (WTR::TestController::runModal): Added.
1847         * WebKitTestRunner/win/TestControllerWin.cpp:
1848         (WTR::TestController::runModal): Added.
1849
1850 2011-01-21  Eric Seidel  <eric@webkit.org>
1851
1852         Reviewed by Adam Barth.
1853
1854         Split Host object off from WebKitPatch for easier re-use
1855         https://bugs.webkit.org/show_bug.cgi?id=52284
1856
1857         new-run-webkit-tests and other tools are eventually going to want one of these.
1858         Basically you need to inherit from this class if you want to pretend to be a
1859         self.tool object for Steps/Commands.
1860
1861         * Scripts/webkitpy/common/host.py: Added.
1862         * Scripts/webkitpy/tool/main.py:
1863
1864 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1865
1866         Reviewed by Adam Barth.
1867
1868         Disable the tests that start and stop the http server and web
1869         server, so that we don't have to worry about port collisions on
1870         the bots.
1871
1872         https://bugs.webkit.org/show_bug.cgi?id=52861
1873
1874         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1875
1876 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1877
1878         Reviewed by Eric Seidel.
1879
1880         nrwt: rewrite google_chrome_unittest to use mock filesystem.
1881         
1882         https://bugs.webkit.org/show_bug.cgi?id=52772
1883         
1884         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
1885
1886 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1887
1888         Reviewed by Eric Siedel.
1889
1890         nrwt: clean up almost all remaining port references, remove
1891         unnecessary import clauses. The only remaining references are
1892         in places where a mock filesystem makes no sense or can't be
1893         used, and in one routine in port/google_chrome_unittest that
1894         I'll rewrite in a separate patch.
1895
1896         https://bugs.webkit.org/show_bug.cgi?id=52771
1897
1898         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1899         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1900         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1901         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1902         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1903         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1904         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1905         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
1906         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
1907         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
1908         * Scripts/webkitpy/layout_tests/port/gtk.py:
1909         * Scripts/webkitpy/layout_tests/port/mac.py:
1910         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1911         * Scripts/webkitpy/layout_tests/port/qt.py:
1912         * Scripts/webkitpy/layout_tests/port/webkit.py:
1913         * Scripts/webkitpy/layout_tests/port/win.py:
1914         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
1915
1916 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1917
1918         Reviewed by Mihai Parparita.
1919
1920         remove fs refs from run_webkit_tests, rebaseline_chromium_webkit_tests
1921
1922         https://bugs.webkit.org/show_bug.cgi?id=52762
1923
1924         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1925         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1926
1927 2011-01-20  Tony Chang  <tony@chromium.org>
1928
1929         Reviewed by Ojan Vafai.
1930
1931         [chromium] fix the paths used for the rebaseline tool
1932         https://bugs.webkit.org/show_bug.cgi?id=52857
1933
1934         Some of the bots were renamed so the path to grab the results zip
1935         file has changed.
1936
1937         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1938
1939 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1940
1941         Reviewed by Tony Chang.
1942
1943         Fix bug introduced in r72688 / bug 52768 that broke the
1944         generation of the output filename links in the results.html
1945         output. Apparently none of the unit tests actually checked to
1946         make sure the generated links were correct :(
1947
1948         https://bugs.webkit.org/show_bug.cgi?id=52854
1949
1950         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1951         * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
1952
1953 2011-01-20  Alexey Proskuryakov  <ap@apple.com>
1954
1955         Reviewed by Darin Adler.
1956
1957         https://bugs.webkit.org/show_bug.cgi?id=52849
1958         Make window.print work with WebKit2
1959
1960         * MiniBrowser/mac/BrowserWindowController.m:
1961         (-[BrowserWindowController awakeFromNib]):
1962         * WebKitTestRunner/TestController.cpp:
1963         (WTR::createOtherPage):
1964         (WTR::TestController::initialize):
1965         Added zeroes to WKPageUIClient structures to avoid build failures.
1966
1967 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1968
1969         Reviewed by Eric Seidel.
1970
1971         nrwt: remove fs refs from printing, test_failures, test_expectations, text_diff
1972
1973         https://bugs.webkit.org/show_bug.cgi?id=52756
1974
1975         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1976         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1977         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1978         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
1979         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1980         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
1981
1982 2011-01-20  Mansi Mithal  <mansi.mithal@nokia.com>
1983
1984         Reviewed by Antonio Gomes.
1985
1986         QtTestBrowser should have a seperate menu for Settings
1987         https://bugs.webkit.org/show_bug.cgi?id=52817
1988         
1989         Added a new menu item named "Settings"
1990         and moved the "Enable interrupting js scripts" and "Enable js pop up windows" under the "Settings" menu 
1991
1992         * QtTestBrowser/launcherwindow.cpp:
1993         (LauncherWindow::createChrome):
1994
1995 2011-01-20  Sam Weinig  <sam@webkit.org>
1996
1997         Reviewed by John Sullivan.
1998
1999         Update update-webkit-localizable-strings with new path to WebKit.
2000
2001         * Scripts/update-webkit-localizable-strings:
2002
2003 2011-01-20  James Robinson  <jamesr@chromium.org>
2004
2005         Reviewed by Darin Fisher.
2006
2007         Implement mozilla's requestAnimationFrame API
2008         https://bugs.webkit.org/show_bug.cgi?id=51218
2009
2010         Chromium DumpRenderTree support for window.webkitRequestAnimationFrame.
2011
2012         * DumpRenderTree/chromium/WebViewHost.cpp:
2013         (invokeScheduleComposite):
2014         (WebViewHost::scheduleAnimation):
2015         (WebViewHost::paintInvalidatedRegion):
2016         * DumpRenderTree/chromium/WebViewHost.h:
2017
2018 2011-01-20  Maciej Stachowiak  <mjs@apple.com>
2019
2020         Reviewed by Adam Roben.
2021
2022         WebKitTestRunner needs to support layoutTestController.evaluateScriptInIsolatedWorld
2023         https://bugs.webkit.org/show_bug.cgi?id=42327
2024
2025         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm: Add support
2026         for methods that take their normal arguments but also a JSContextRef.
2027         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: IDL definition
2028         for evaluateScriptInIsolatedWorld.
2029         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2030         (WTR::InjectedBundlePage::didClearWindowForFrame): Set a magic variable only if
2031         this call is for an isolated world.
2032         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2033         (WTR::worldMap): Helper to create a world map.
2034         (WTR::LayoutTestController::worldIDForWorld): Map from an ID to a world.
2035         (WTR::LayoutTestController::evaluateScriptInIsolatedWorld): The newly
2036         added LayoutTestController API.
2037         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2038
2039 2011-01-19  Adam Roben  <aroben@apple.com>
2040
2041         Convert paths in environment variables back to msys-style inside commit-log-editor
2042
2043         When this script gets run from inside git commit, msys-style paths in the environment will
2044         have been turned into Windows-style paths with forward slashes. This screws up functions
2045         like File::Spec->rel2abs, which seem to rely on $PWD having an msys-style path. We convert
2046         the paths back to msys-style before doing anything else.
2047
2048         Fixes <http://webkit.org/b/48527> commit-log-editor uses full paths for section headers when
2049         using msysgit's Perl and multiple ChangeLogs have been edited
2050
2051         Reviewed by David Kilzer.
2052
2053         * Scripts/commit-log-editor: Call fixEnvironment before doing anything else.
2054         (fixEnvironment): Added. When run in msys in conjunction with git (i.e., when invoked from
2055         inside git commit), convert Windows-style paths in the environment back to msys-style paths.
2056
2057 2011-01-20  Zoltan Horvath  <zoltan@webkit.org>
2058
2059         [Win] Unreviewed build fix after r76248.
2060
2061         * DumpRenderTree/ForwardingHeaders/wtf/FastAllocBase.h: Added.
2062
2063 2011-01-20  Zoltan Horvath  <zoltan@webkit.org>
2064
2065         Reviewed by Csaba Osztrogonác.
2066
2067         Refactoring of the custom allocation framework
2068         https://bugs.webkit.org/show_bug.cgi?id=49897
2069
2070         Inheriting from FastAllocBase can result in objects getting larger (bug #33896, #46589).
2071         The modification replaces Noncopyable and FastAllocBase classes and these inherits with their
2072         equivalent macro implementation at the necessary places.
2073 2011-01-20  Yi Shen  <yi.4.shen@nokia.com>
2074
2075         Unreviewed. 
2076
2077         Adding myself to committers.py.
2078
2079         * Scripts/webkitpy/common/config/committers.py:
2080
2081 2011-01-20  Adam Barth  <abarth@webkit.org>
2082
2083         Reviewed by Tony Chang.
2084
2085         Chromium builders don't delete unversioned directories when DEPS change
2086         https://bugs.webkit.org/show_bug.cgi?id=52745
2087
2088         If we pass this option to gclient sync, gclient will delete directories
2089         that are no longer part of DEPS instead of leaving them around to
2090         confuse us later.  Apparently, the downstream buildbots use this option
2091         already.
2092
2093         * Scripts/update-webkit-chromium:
2094
2095 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2096
2097         Unreviewed, build fix - I pulled this patch in to fix an issue
2098         revealed by r76195 running on some new bots). Also fix a couple
2099         of other issues revealed in testing.
2100
2101         nrwt: remove fs refs from layout_package/json*
2102
2103         https://bugs.webkit.org/show_bug.cgi?id=52754
2104
2105         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2106         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
2107         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
2108         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2109         * Scripts/webkitpy/layout_tests/port/base.py:
2110
2111 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2112
2113         Unreviewed, build fix.
2114
2115         Fix a couple of minor bugs discovered while bringing up new bots
2116         for testing.
2117
2118         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2119         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2120
2121 2011-01-19  James Robinson  <jamesr@chromium.org>
2122
2123         Unreviewed, rolling out r76194.
2124         http://trac.webkit.org/changeset/76194
2125         https://bugs.webkit.org/show_bug.cgi?id=51218
2126
2127         Caused mysterious compile failure on the chromium win
2128         build.webkit.org bots
2129
2130         * DumpRenderTree/chromium/WebViewHost.cpp:
2131         (WebViewHost::paintInvalidatedRegion):
2132         * DumpRenderTree/chromium/WebViewHost.h:
2133
2134 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2135
2136         Reviewed by Mihai Parparita.
2137
2138         remove fs refs from test_runner, dump_render_tree_thread
2139
2140         https://bugs.webkit.org/show_bug.cgi?id=52753
2141
2142         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2143         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2144         * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
2145         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2146
2147 2011-01-19  James Robinson  <jamesr@chromium.org>
2148
2149         Reviewed by Darin Fisher.
2150
2151         Implement mozilla's requestAnimationFrame API
2152         https://bugs.webkit.org/show_bug.cgi?id=51218
2153
2154         Chromium DumpRenderTree support for window.webkitRequestAnimationFrame.
2155
2156         * DumpRenderTree/chromium/WebViewHost.cpp:
2157         (invokeScheduleComposite):
2158         (WebViewHost::scheduleAnimation):
2159         (WebViewHost::paintInvalidatedRegion):
2160         * DumpRenderTree/chromium/WebViewHost.h:
2161
2162 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2163
2164         Unreviewed, build fix.
2165
2166         Fix a few incorrect "self._filesystem" references introduced in
2167         r76184.
2168
2169         * Scripts/webkitpy/layout_tests/port/chromium.py:
2170         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2171
2172 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2173
2174         Reviewed by Mihai Parparita.
2175
2176         add a .sep property, abspath(), isabs(), mtime(), and
2177         open_text_file_for_writing() to filesystem modules. Some of
2178         these properties are not needed in this patch but will be needed
2179         in subsequent patches (I'm doing this to avoid having to track
2180         multiple versions of a single file).
2181
2182         Also, change most of the port/* modules to use the filesystem
2183         objects instead of referencing the filesystem directly.
2184
2185         https://bugs.webkit.org/show_bug.cgi?id=52748
2186
2187         * Scripts/webkitpy/common/system/filesystem.py:
2188         * Scripts/webkitpy/common/system/filesystem_mock.py:
2189         * Scripts/webkitpy/layout_tests/port/__init__.py:
2190         * Scripts/webkitpy/layout_tests/port/base.py:
2191         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2192         * Scripts/webkitpy/layout_tests/port/chromium.py:
2193         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2194         * Scripts/webkitpy/layout_tests/port/config.py:
2195         * Scripts/webkitpy/layout_tests/port/test.py:
2196         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
2197
2198 2011-01-19  Maciej Stachowiak  <mjs@apple.com>
2199
2200         Reviewed by Anders Carlsson.
2201
2202         If resetting between tests times out, treat it as a WebProcess crash
2203         https://bugs.webkit.org/show_bug.cgi?id=52757
2204
2205         * WebKitTestRunner/TestController.cpp:
2206         (WTR::TestController::runTest):
2207
2208 2011-01-19  Alexey Proskuryakov  <ap@apple.com>
2209
2210         Reviewed by Darin Adler.
2211
2212         https://bugs.webkit.org/show_bug.cgi?id=52739
2213         Make it possible for a WebKit2 client to print headers and footers
2214
2215         Added dummy implementations for new printing UIClient calls.
2216
2217         * MiniBrowser/mac/BrowserWindowController.m:
2218         (-[BrowserWindowController awakeFromNib]):
2219         * WebKitTestRunner/TestController.cpp:
2220         (WTR::createOtherPage):
2221         (WTR::TestController::initialize):
2222
2223 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2224
2225         Reviewed by Ojan Vafai.
2226
2227         Change webkitpy/layout_tests/port/test.py to use the
2228         in-memory filesystem for cleaner unit testing. This
2229         change allows us to kill a lot of code that was
2230         specific to the test port, at the cost of being a
2231         little less clear about how things would work if
2232         you didn't have a filesystem.
2233
2234         https://bugs.webkit.org/show_bug.cgi?id=52605
2235
2236         * Scripts/webkitpy/layout_tests/port/test.py:
2237
2238 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2239
2240         Unreviewed, build fix.
2241
2242         Fix test failure caused by committing attachment 79368 instead
2243         of attachment 79461 on bug 52604.
2244
2245         * Scripts/webkitpy/common/system/filesystem_mock.py:
2246
2247 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2248
2249         Reviewed by Mihai Parparita.
2250
2251         new-run-webkit-tests: remove use of os.walk, use mock filesystem for better
2252         unit testing. os.walk() is too much of a hassle to implement on
2253         top of the in-memory mock filesystem and adding the necessary
2254         interface to files_under() gives clients a cleaner API anyway
2255         (for this particular usage model).
2256
2257         https://bugs.webkit.org/show_bug.cgi?id=52691
2258
2259         * Scripts/webkitpy/common/system/filesystem.py:
2260         * Scripts/webkitpy/common/system/filesystem_mock.py:
2261         * Scripts/webkitpy/layout_tests/port/test_files.py:
2262         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
2263
2264 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2265
2266         Reviewed by Tony Chang.
2267
2268         Change more modules in the layout-tests code to use the
2269         filesystem wrapper for cleaner unit testing.
2270
2271         This patch also adds the glob() wrapper to the filesystem
2272         abstraction.
2273         
2274         https://bugs.webkit.org/show_bug.cgi?id=52604
2275
2276         * Scripts/webkitpy/layout_tests/port/test_files.py:
2277         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
2278         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
2279         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2280         * Scripts/webkitpy/common/system/filesystem.py:
2281         * Scripts/webkitpy/common/system/filesystem_mock.py:
2282
2283 2011-01-19  Levi Weintraub  <leviw@chromium.org>
2284
2285         Unreviewed.
2286
2287         Updating my email addresses and irc nick.
2288
2289         * Scripts/webkitpy/common/config/committers.py:
2290
2291 2011-01-19  Tony Chang  <tony@chromium.org>
2292
2293         Reviewed by Mihai Parparita.
2294
2295         [chromium] [linux] if check-sys-deps fails, output the failure reason
2296         https://bugs.webkit.org/show_bug.cgi?id=52671
2297
2298         * Scripts/webkitpy/common/system/executive_mock.py: Add support for
2299             error handler functions.
2300         * Scripts/webkitpy/layout_tests/port/chromium.py:
2301             output the error text from --check-sys-deps
2302         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2303
2304 2011-01-19  Aparna Nandyal  <aparna.nand@wipro.com>
2305
2306         Reviewed by Andreas Kling.
2307
2308         [Qt] QtTestBrowser crashes when closing if Facebook is opened
2309         https://bugs.webkit.org/show_bug.cgi?id=52554
2310         
2311         QtNetworkAccessManager is created in a thread and set as
2312         member variable in QWebPage. When the thread is destroyed
2313         the object is still used. So fix will set the object to
2314         NULL once the thread is destroyed.
2315
2316         * QtTestBrowser/launcherwindow.cpp:
2317         (LauncherWindow::~LauncherWindow):
2318
2319 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
2320
2321         Rubber stamped by Csaba Osztrogonac
2322
2323         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: Removed unncessary inculde of WKStringCF.h
2324
2325 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
2326
2327         Reviewed by Tony Chang.
2328
2329         new-run-webkit-tests: add a --build-directory command line argument
2330
2331         Official Google Chrome builds use a non-standard build directory
2332         location. This patch adds a --build-directory argument that
2333         allows that location to be specified on the command line. Only
2334         Chromium-based builds will use this flag for now, but anyone can
2335         in the future.
2336
2337         There are no unit tests for this since it's difficult to test
2338         until mock filesystems are fully supported in the code. This was
2339         tested by hand for now.
2340
2341         https://bugs.webkit.org/show_bug.cgi?id=52694
2342
2343         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2344         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2345         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2346         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2347
2348 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
2349
2350         Not reviewed. Bot fix.
2351
2352         Remove an inadvertently committed debugging print.
2353
2354         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2355         (LayoutTestController::notifyDone):
2356
2357 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
2358
2359         Reviewed by Sam Weinig.
2360
2361         WebKitTestRunner should track loading more like DumpRenderTree
2362         https://bugs.webkit.org/show_bug.cgi?id=52692
2363
2364         Change load tracking to track the current top loading frame, in the manner of DumpRenderTree.
2365         This makes some tests that call notifyDone multiple times pass.
2366         
2367         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2368         (WTR::InjectedBundle::InjectedBundle):
2369         (WTR::InjectedBundle::done):
2370         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2371         (WTR::InjectedBundle::topLoadingFrame):
2372         (WTR::InjectedBundle::setTopLoadingFrame):
2373         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2374         (WTR::InjectedBundlePage::InjectedBundlePage):
2375         (WTR::InjectedBundlePage::stopLoading):
2376         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
2377         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
2378         (WTR::InjectedBundlePage::didFinishLoadForFrame):
2379         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
2380         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2381         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2382         (WTR::LayoutTestController::notifyDone):
2383         * WebKitTestRunner/TestController.cpp:
2384         (WTR::TestController::didReceiveMessageFromInjectedBundle):
2385
2386 2011-01-18  Mihai Parparita  <mihaip@chromium.org>
2387
2388         Reviewed by Kent Tamura.
2389
2390         [Chromium] NRWT looking for DRT binary in the wrong path on Mac
2391         https://bugs.webkit.org/show_bug.cgi?id=52678
2392         
2393         Update path now that WebKit is inside Source.
2394
2395         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2396
2397 2011-01-18  Robert Hogan  <robert@webkit.org>
2398
2399         Reviewed by Simon Hausmann.
2400
2401         [Qt] http/tests/incremental/slow-utf8-text.pl fails
2402         https://bugs.webkit.org/show_bug.cgi?id=44282
2403
2404         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2405         (WebCore::DumpRenderTree::dump):
2406
2407 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
2408
2409         Reviewed by Mihai Parparita.
2410
2411         Fix a small race condition that could cause the unit tests for
2412         new-run-webkit-tests to fail in a multithreaded environment.
2413         There was a small window in the code where one thread would
2414         check to see if a thread had raised an exception, do something,
2415         and then check to see if the thread was alive. If the other
2416         thread raised an exception and exited in between these two
2417         steps, the exception would be lost. Flipping the order of the
2418         two checks fixes the race, since we will now always check for an
2419         exception on the thread before exiting.
2420
2421         https://bugs.webkit.org/show_bug.cgi?id=51579
2422
2423         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
2424
2425 2011-01-18  Eric Seidel  <eric@webkit.org>
2426
2427         Reviewed by Adam Barth.
2428
2429         commit-queue dies when test archiving fails
2430         https://bugs.webkit.org/show_bug.cgi?id=52617
2431
2432         I looked at the machine and it had 10 archives already
2433         thus find_unused_name was returning None.  I've upped
2434         the limit to 100 (per bug) and tested the case where
2435         find_unused_name returns None (making archive return None).
2436
2437         * Scripts/webkitpy/common/system/workspace.py:
2438         * Scripts/webkitpy/common/system/workspace_unittest.py:
2439         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2440         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2441         * Scripts/webkitpy/tool/commands/queues.py:
2442
2443 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
2444
2445         Reviewed by Ojan Vafai.
2446
2447         Update rebaseline-chromium-webkit-tests unit tests to use a mock
2448         filesystem. Also fix a couple of "with" statements missed by
2449         r76050.
2450
2451         https://bugs.webkit.org/show_bug.cgi?id=52487
2452
2453         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
2454
2455 2011-01-18  Sergio Villar Senin  <svillar@igalia.com>
2456
2457         Reviewed by Martin Robinson.
2458
2459         [Gtk] Build fixes for gtk3 build
2460         https://bugs.webkit.org/show_bug.cgi?id=52648
2461
2462         * DumpRenderTree/gtk/EventSender.cpp:
2463         (beginDragWithFilesCallback):
2464
2465 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
2466
2467         Reviewed by Mihai Parparita.
2468
2469         Update rebaseline-chromium-webkit-tests to use filesystem objects
2470         instead of direct references to os.path, shutil, tempfile, etc.
2471
2472         This patch doesn't change anything, but will allow subsequent
2473         patches to change the unit tests to no longer use the real
2474         filesystem.
2475
2476         This patch adds a bunch more methods to the filesystem object as
2477         well.
2478
2479         https://bugs.webkit.org/show_bug.cgi?id=52482
2480
2481         * Scripts/webkitpy/common/system/filesystem.py:
2482         * Scripts/webkitpy/common/system/filesystem_mock.py:
2483         * Scripts/webkitpy/tool/commands/queues.py:
2484         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2485         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
2486
2487 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
2488
2489         Reviewed by Mihai Parparita.
2490
2491         new-run-webkit-tests shouldn't crash when you try to run a
2492         directory containing only skipped files.
2493
2494         https://bugs.webkit.org/show_bug.cgi?id=52478
2495         
2496         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2497         * Scripts/webkitpy/layout_tests/port/test.py:
2498         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2499
2500 2011-01-18  Adam Bergkvist  <adam.bergkvist@ericsson.com> and Martin Robinson  <mrobinson@igalia.com>
2501
2502         Reviewed by Gustavo Noronha Silva.
2503
2504         [GTK] The GTK+ EventSender needs support for beginDragWithFiles
2505         https://bugs.webkit.org/show_bug.cgi?id=40833
2506
2507         * DumpRenderTree/gtk/EventSender.cpp: Add a beginDragWithFiles implementation for the
2508         GTK+ event sender.
2509         (dragWithFilesDragDataGetCallback): Added.
2510         (dragWithFilesDragEndCallback): Added.
2511         (beginDragWithFilesCallback): Added.
2512
2513 2011-01-18  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2514
2515         Reviewed by Adam Barth.
2516
2517         ews: Add additional watcher to efl ews
2518         https://bugs.webkit.org/show_bug.cgi?id=52613
2519
2520         Add gyuyoung.kim@samsung.com to watcher list of efl-ews.
2521
2522         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2523
2524 2011-01-17  Tony Gentilcore  <tonyg@chromium.org>
2525
2526         Reviewed by Alexey Proskuryakov.
2527
2528         Fix some headers with missing or misspelled #ifndef guards
2529         https://bugs.webkit.org/show_bug.cgi?id=52545
2530
2531         * DumpRenderTree/chromium/TestEventPrinter.h:
2532         * DumpRenderTree/chromium/WebPreferences.h:
2533
2534 2011-01-17  Jessie Berlin  <jberlin@apple.com>
2535
2536         Reviewed by Anders Carlsson.
2537
2538         REGRESSION: Assertion failure in FrameLoader::continueLoadAfterWillSubmitForm() when
2539         navigating back to an unreachable URL
2540         https://bugs.webkit.org/show_bug.cgi?id=52388
2541
2542         Add a third parameter (unreachableURL) to queueLoadHTMLString.
2543
2544         * DumpRenderTree/LayoutTestController.cpp:
2545         (queueLoadHTMLStringCallback):
2546         (LayoutTestController::queueLoadHTMLString):
2547         (LayoutTestController::queueLoadAlternateHTMLString):
2548         * DumpRenderTree/LayoutTestController.h:
2549
2550         * DumpRenderTree/WorkQueueItem.h:
2551         (LoadHTMLStringItem::LoadHTMLStringItem):
2552
2553         * DumpRenderTree/chromium/LayoutTestController.cpp:
2554         (WorkItemLoadHTMLString::WorkItemLoadHTMLString):
2555         (WorkItemLoadHTMLString::run):
2556         (LayoutTestController::queueLoadHTMLString):
2557
2558         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
2559         (LoadHTMLStringItem::invoke):
2560         * DumpRenderTree/mac/WorkQueueItemMac.mm:
2561         (LoadHTMLStringItem::invoke):
2562         * DumpRenderTree/win/WorkQueueItemWin.cpp:
2563         (LoadHTMLStringItem::invoke):
2564
2565 2011-01-17  Dan Bernstein  <mitz@apple.com>
2566
2567         Rubber-stamped by Mark Rowe.
2568
2569         Update xcodeproj svn:ignore to include xcuserdata.
2570
2571         * DumpRenderTree/DumpRenderTree.xcodeproj: Modified property svn:ignore.
2572         * MiniBrowser/MiniBrowser.xcodeproj: Modified property svn:ignore.
2573         * TestWebKitAPI/TestWebKitAPI.xcodeproj: Modified property svn:ignore.
2574         * WebKitLauncher/WebKitLauncher.xcodeproj: Modified property svn:ignore.
2575         * WebKitTestRunner/WebKitTestRunner.xcodeproj: Modified property svn:ignore.
2576
2577 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
2578
2579         Unreviewed fix after r75908.
2580
2581         Move WebKit into Source
2582         https://bugs.webkit.org/show_bug.cgi?id=52530
2583
2584         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add Source to the path for Qt API tests.
2585
2586 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
2587
2588         Unreviewed.
2589
2590         Remove accidentally committed debug printing after r75908.
2591
2592         * Scripts/webkitdirs.pm:
2593
2594 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
2595
2596         Unreviewed.
2597
2598         Add myself to committers list
2599         https://bugs.webkit.org/show_bug.cgi?id=52566
2600
2601         * Scripts/webkitpy/common/config/committers.py:
2602
2603 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
2604
2605         Reviewed by Jeremy Orlow.
2606
2607         GeolocationController should call stopUpdating on destruction
2608         https://bugs.webkit.org/show_bug.cgi?id=52216
2609
2610         fast/dom/Geolocation/window-close-crash.html requires that a
2611         Geolocation watch be started in a secondary window. Consequently,
2612         we need to allow geolocation permission and provide a mock
2613         geolocation position for the secondary window's
2614         GeolocationClientMock.
2615
2616         * DumpRenderTree/chromium/LayoutTestController.cpp:
2617         (LayoutTestController::setGeolocationPermission):
2618         (LayoutTestController::setMockGeolocationPosition):
2619         (LayoutTestController::setMockGeolocationError):
2620         * DumpRenderTree/chromium/TestShell.h:
2621         (TestShell::windowList):
2622
2623 2011-01-16  Adam Barth  <abarth@webkit.org>
2624
2625         Update more include paths to reflect WebKit move.
2626
2627         * DumpRenderTree/chromium/EventSender.cpp:
2628         (EventSender::keyDown):
2629         (EventSender::needsShiftModifier):
2630         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
2631         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
2632
2633 2011-01-16  Kent Tamura  <tkent@chromium.org>
2634
2635         Unreviewed, Chromium build fix.
2636
2637         * Scripts/update-webkit-chromium: Webkit/chromium -> Source/WebKit/chromium
2638
2639 2011-01-16  Martin Robinson  <mrobinson@igalia.com>
2640
2641         Build fix for GTK+ after source directory movement.
2642
2643         * GNUmakefile.am: Correct include paths.
2644
2645 2011-01-16  Adam Barth  <abarth@webkit.org>
2646
2647         Teach svn-apply about WebKit move.
2648
2649         * Scripts/VCSUtils.pm:
2650
2651 2011-01-16  Adam Barth  <abarth@webkit.org>
2652
2653         Rubber-stamped by Eric Seidel.
2654
2655         Move WebKit into Source
2656         https://bugs.webkit.org/show_bug.cgi?id=52530
2657
2658         * DumpRenderTree/mac/InternalHeaders/WebKit/WebTypesInternal.h:
2659         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2660         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2661         * DumpRenderTree/qt/GCControllerQt.cpp:
2662         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2663         * DumpRenderTree/qt/PlainTextControllerQt.cpp:
2664         * DumpRenderTree/qt/TextInputControllerQt.cpp:
2665         * DumpRenderTree/wscript:
2666         * QtTestBrowser/launcherwindow.h:
2667         * Scripts/build-webkit:
2668         * Scripts/webkitdirs.pm:
2669
2670 2011-01-15  Adam Barth  <abarth@webkit.org>
2671
2672         Teach svn-apply about WebKit2 move.
2673
2674         * Scripts/VCSUtils.pm:
2675
2676 2011-01-15  Adam Barth  <abarth@webkit.org>
2677
2678         Rubber-stamped by Eric Seidel.
2679
2680         Move WebKit2 into Source
2681         https://bugs.webkit.org/show_bug.cgi?id=52438
2682
2683         * MiniBrowser/qt/MiniBrowser.pro:
2684         * Scripts/build-webkit:
2685         * Scripts/do-file-rename:
2686         * Scripts/do-webcore-rename:
2687         * Scripts/test-webkitpy:
2688         * Scripts/webkitdirs.pm:
2689         * Scripts/webkitpy/style/checker.py:
2690         * WebKitTestRunner/DerivedSources.pro:
2691         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2692         * WebKitTestRunner/qt/WebKitTestRunner.pro:
2693
2694 2011-01-15  Jochen Eisinger  <jochen@chromium.org>
2695
2696         Reviewed by David Levin.
2697
2698         [chromium] remove obsolete createView method
2699         https://bugs.webkit.org/show_bug.cgi?id=52437
2700
2701         * DumpRenderTree/chromium/WebViewHost.cpp:
2702         (WebViewHost::createView):
2703         * DumpRenderTree/chromium/WebViewHost.h:
2704
2705 2011-01-14  Brian Weinstein  <bweinstein@apple.com>
2706
2707         Reviewed by Geoff Garen.
2708
2709         ShouldLoadResourceForFrame should use strings, not URLs.
2710         https://bugs.webkit.org/show_bug.cgi?id=52476
2711
2712         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2713         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Update to use a WKStringRef.
2714         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2715
2716 2011-01-14  Tony Gentilcore  <tonyg@chromium.org>
2717
2718         Reviewed by David Levin.
2719
2720         Add Tony Gentilcore as a reviewer
2721         https://bugs.webkit.org/show_bug.cgi?id=52480
2722
2723         * Scripts/webkitpy/common/config/committers.py:
2724
2725 2011-01-14  David Levin  <levin@chromium.org>
2726
2727         Reviewed by Eric Seidel.
2728
2729         check-webkit-style: _FunctionState should keep track of where the function name starts.
2730         https://bugs.webkit.org/show_bug.cgi?id=52454
2731
2732         * Scripts/webkitpy/style/checkers/cpp.py: Added function_name_start_position to
2733         _FunctionState and logic for setting it correctly.
2734         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests.
2735
2736 2011-01-14  Vincent Scheib  <scheib@chromium.org>
2737
2738         Reviewed by David Levin.
2739
2740         Add support to DumpRenderTree to use the GPU rather than software renderer
2741         https://bugs.webkit.org/show_bug.cgi?id=52333
2742
2743         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2744         (main):
2745         * Scripts/webkitpy/layout_tests/port/chromium.py:
2746         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2747
2748 2011-01-14  Tony Chang  <tony@chromium.org>
2749
2750         Reviewed by Kent Tamura.
2751
2752         [chromium] update fonts.conf to fix 6 linux tests in drt
2753         https://bugs.webkit.org/show_bug.cgi?id=52411
2754
2755         * DumpRenderTree/chromium/fonts.conf: Update to match the copy in
2756             chromium's src/webkit/tools/test_shell/resources/fonts.conf
2757
2758 2011-01-14  Eric Seidel  <eric@webkit.org>
2759
2760         Original patch from Peter Gal  <galpater@inf.u-szeged.hu>
2761
2762         Reviewed by Adam Barth.
2763
2764         Fix when running Tools/Scripts/check-webkit-style without arguments.
2765         https://bugs.webkit.org/show_bug.cgi?id=52261#c16
2766
2767         * Scripts/webkitpy/common/checkout/scm.py: Handle None for changed_files argument better in Git.create_patch method.
2768         * Scripts/webkitpy/common/checkout/scm_unittest.py:
2769
2770 2011-01-04  Jochen Eisinger  <jochen@chromium.org>
2771
2772         Reviewed by David Levin.
2773
2774         Store the tempdir object in a variable so it doesn't get deleted too early.
2775         https://bugs.webkit.org/show_bug.cgi?id=51875
2776
2777         * Scripts/update-webkit-auxiliary-libs:
2778         * Scripts/update-webkit-support-libs:
2779
2780 2011-01-14  Eric Seidel  <eric@webkit.org>
2781
2782         Unreviewed.  Make it work in python 2.5.
2783
2784         webkit-patch suggest-reviewers dies when ChangeLogs are missing
2785         https://bugs.webkit.org/show_bug.cgi?id=49158
2786
2787         * Scripts/webkitpy/common/checkout/api_unittest.py:
2788
2789 2011-01-14  Sheriff Bot  <webkit.review.bot@gmail.com>
2790
2791         Unreviewed, rolling out r75774.
2792         http://trac.webkit.org/changeset/75774
2793         https://bugs.webkit.org/show_bug.cgi?id=52431
2794
2795         gtk builds were broken (Requested by loislo2 on #webkit).
2796
2797         * Scripts/webkitpy/common/checkout/scm.py:
2798
2799 2011-01-14  David Levin  <levin@chromium.org>
2800
2801         Reviewed by Shinichiro Hamaji.
2802
2803         check-webkit-style: _FunctionState should detect pure functions.
2804         https://bugs.webkit.org/show_bug.cgi?id=52428
2805
2806         * Scripts/webkitpy/style/checkers/cpp.py: Added detection for if a function declaration
2807         is a pure virtual function.
2808         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests for verifying that pure
2809         virtual functions are correctly detected.
2810
2811 2011-01-13  Ilya Tikhonovsky  <loislo@chromium.org>
2812
2813         Reviewed by Yury Semikhatsky.
2814
2815         Just small fix for problem with check-webkit-style.
2816         It just didn't work for this patch.
2817         Old code can't concatenate a list of strings with None.
2818
2819         * Scripts/webkitpy/common/checkout/scm.py:
2820
2821 2011-01-13  David Levin  <levin@chromium.org>
2822
2823         Reviewed by Shinichiro Hamaji.
2824
2825         check-webkit-style: _FunctionState should use Position to know where items are.
2826         https://bugs.webkit.org/show_bug.cgi?id=52424
2827
2828         * Scripts/webkitpy/style/checkers/cpp.py:
2829         (_FunctionState.*): Changed _FunctionState to use Position instead of line numbers.
2830         (detect_functions): Changed to pass Position's to _FunctionState.begin and
2831         did some minor clean-up.
2832         (*): Other changes are simply about converting to use the Position's in_FunctionState
2833         instead of line numbers.
2834         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Changed the test code
2835         to verify the positions stored in _FunctionState.
2836
2837 2011-01-13  Eric Seidel  <eric@webkit.org>
2838
2839         Reviewed by David Levin.
2840
2841         webkit-patch suggest-reviewers dies when ChangeLogs are missing
2842         https://bugs.webkit.org/show_bug.cgi?id=49158
2843
2844         This is not the most elegant, but it is a very safe fix to this bug.
2845         One advantage of catching ScriptError like this instead of adding a
2846         new added_or_modified_files or fixing all changed_files callers
2847         to use a more specific change_files variant, is that we catch
2848         all kinds of ScriptErrors which might cause our (non-essential)
2849         suggest-reviewers code to fail out.  This should make passing
2850         --suggest-reviewers to webkit-patch upload much more robust
2851         and may even make it possible for us to make it default.
2852
2853         The root of the problem here is that SCM.changed_files includes
2854         deleted ChangeLog paths (from moves, etc) which then when we ask
2855         SVN/Git for the contents of the file at that revision, the command
2856         errors out and Executive.run_command raises a ScriptError.
2857
2858         In the future we might fix this differently by making all current
2859         callers of chagned_files use a more specific method for requesting
2860         what types of changes they're interested in (adds, modifies, deletes, etc.)
2861
2862         * Scripts/webkitpy/common/checkout/api.py:
2863         * Scripts/webkitpy/common/checkout/api_unittest.py:
2864
2865 2011-01-13  Dan Bernstein  <mitz@apple.com>
2866
2867         Reviewed by Alexey Proskuryakov.
2868
2869         <rdar://problem/8827065> REGRESSION (r71884): Cross-origin XHR fails if willSendRequest changes the URL
2870         https://bugs.webkit.org/show_bug.cgi?id=52419
2871
2872         Allow to further control the behavior of the willSendRequest delegate callback by making it
2873         set a different URL in the new request.
2874
2875         * DumpRenderTree/LayoutTestController.cpp:
2876         (addURLToRedirectCallback): Added.
2877         (LayoutTestController::staticFunctions): Added addURLToRedirect.
2878         (LayoutTestController::addURLToRedirect): Added. Adds the redirection to the map.
2879         (LayoutTestController::redirectionDestinationForURL): Added this getter.
2880         * DumpRenderTree/LayoutTestController.h:
2881         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2882         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]): Check
2883         if there is a redirection for the request’s URL, established by addURLToRedirect(), and if so,
2884         change the URL in the new request to the redirect destination.
2885
2886 2011-01-13  Eric Seidel  <eric@webkit.org>
2887
2888         Reviewed by Mihai Parparita.
2889
2890         webkit-patch suggest-reviewers fails due to invalid utf8 in ChangeLog files
2891         https://bugs.webkit.org/show_bug.cgi?id=52416
2892
2893         Example: webkit-patch suggest-reviewers -g ca3890fe74d94d85d6bfa48f9ea497b094d8e717 
2894         UnicodeDecodeError: 'utf8' codec can't decode bytes in position 536-538: invalid data
2895
2896         I also added FIXMEs about the changed_files returning deleted files problem
2897         which is causing the other most common exception for suggest-reviewers
2898         (and is probably breaking sheriff-bots blame detection).
2899
2900         * Scripts/webkitpy/common/checkout/api.py:
2901         * Scripts/webkitpy/common/checkout/api_unittest.py:
2902         * Scripts/webkitpy/common/checkout/scm.py:
2903
2904 2011-01-13  Eric Seidel  <eric@webkit.org>
2905
2906         Reviewed by Adam Barth.
2907
2908         results archives from commit-queue are too large to upload
2909         https://bugs.webkit.org/show_bug.cgi?id=52405
2910
2911         * Scripts/webkitpy/common/system/filesystem.py:
2912         * Scripts/webkitpy/common/system/filesystem_mock.py:
2913         * Scripts/webkitpy/tool/commands/queues.py:
2914
2915 2011-01-13  Alejandro G. Castro  <alex@igalia.com>
2916
2917         Reviewed by Martin Robinson.
2918
2919         [gtk] Zero-sized font does not yet work
2920         https://bugs.webkit.org/show_bug.cgi?id=49793
2921
2922         Set minimum-font-size to 0 for the DRT.
2923
2924         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2925         (resetDefaultsToConsistentValues):
2926
2927 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
2928
2929         Reviewed by Darin Adler.
2930
2931         Make old-run-webkit-tests more robust on buildbots
2932         https://bugs.webkit.org/show_bug.cgi?id=52364
2933
2934         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Pass --exit-after-n-failures 500 to old-run-webkit-tests script.
2935
2936 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
2937
2938         Reviewed by Darin Adler.
2939
2940         Make old-run-webkit-tests more robust on buildbots
2941         https://bugs.webkit.org/show_bug.cgi?id=52364
2942
2943         * Scripts/old-run-webkit-tests: Ensure that testResultsDirectory is empty.
2944
2945 2011-01-13  Tony Chang  <tony@chromium.org>
2946
2947         Reviewed by Kent Tamura.
2948
2949         [chromium] fix plugins/plugin-javascript-access.html on Linux and Mac
2950         https://bugs.webkit.org/show_bug.cgi?id=52332
2951
2952         Forked Info.plist is not longer needed.
2953
2954         * DumpRenderTree/chromium/TestNetscapePlugIn/Info.plist: Removed.
2955
2956 2011-01-13  Mikhail Naganov  <mnaganov@chromium.org>
2957
2958         Reviewed by Timothy Hatcher.
2959
2960         Web Inspector: Cleanup after r75613 -- make all UI-facing strings
2961         to be passed directly to WebInspector.UIString
2962
2963         https://bugs.webkit.org/show_bug.cgi?id=52365
2964
2965         * Scripts/check-inspector-strings:
2966
2967 2011-01-13  Sheriff Bot  <webkit.review.bot@gmail.com>
2968
2969         Unreviewed, rolling out r74881.
2970         http://trac.webkit.org/changeset/74881
2971         https://bugs.webkit.org/show_bug.cgi?id=52357
2972
2973         The EFL builder has been red for days (Requested by abarth on
2974         #webkit).
2975
2976         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2977         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2978
2979 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
2980
2981         Reviewed by David Levin.
2982
2983         Add beforeunload support to WebKitTestRunner
2984         https://bugs.webkit.org/show_bug.cgi?id=52353
2985         
2986         This makes a number of currently failing tests pass.
2987
2988         * WebKitTestRunner/TestController.cpp:
2989         (WTR::runBeforeUnloadConfirmPanel):
2990         (WTR::createOtherPage):
2991         (WTR::TestController::initialize):
2992
2993 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
2994
2995         Reviewed by Sam Weinig.
2996
2997         Detect, identify and recover from WebProcess crashes in run-webkit-tests
2998         https://bugs.webkit.org/show_bug.cgi?id=52330
2999
3000         * Scripts/old-run-webkit-tests: Detect when the regression test tool reports
3001         a web process crash.
3002         * WebKitTestRunner/TestController.cpp:
3003         (WTR::TestController::initialize): Set up a processDidCrash
3004         callback.
3005         (WTR::TestController::processDidCrash): Report that the Web process
3006         crashed.
3007         * WebKitTestRunner/TestController.h:
3008
3009 2011-01-12  David Levin  <levin@chromium.org>
3010
3011         Reviewed by Shinichiro Hamaji.
3012
3013         check-webkit-style -- close_expression function doesn't work correctly.
3014         https://bugs.webkit.org/show_bug.cgi?id=52272
3015
3016         * Scripts/webkitpy/style/checkers/cpp.py:
3017         (Position.__str__): Added a way to convert it to a string which is useful in tests.
3018         (Position.__cmp__): Added a way to compare Position which is useful in tests and
3019         generally useful (for upcoming code changes).
3020         (close_expression): Changed to use Position for input and output.
3021         Also, fixed many bugs such as only working correctly for parenthesis,
3022         not working correctly if given an offset in a line and not finding
3023         the real closing element if there were multiple closing elements in
3024         the same line.
3025         (detect_functions): Adjusted due to the change in arguments for
3026         close_expression.
3027         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3028         (CppStyleTestBase.assert_positions_equal): Added a way to verify that
3029         two positions are the same.
3030         (CppStyleTest.test_position): Added tests for the __str_ and __cmp__ methods.
3031         (CppStyleTest.test_close_expression): Added tests to catch the issues
3032         that were fixed.
3033
3034 2011-01-12  Sheriff Bot  <webkit.review.bot@gmail.com>
3035
3036         Unreviewed, rolling out r75576.
3037         http://trac.webkit.org/changeset/75576
3038         https://bugs.webkit.org/show_bug.cgi?id=52304
3039
3040         broke rebaseline-chromium-webkit-test (Requested by thakis on
3041         #webkit).
3042
3043         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
3044         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
3045         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
3046         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
3047         * Scripts/webkitpy/layout_tests/port/base.py:
3048         * Scripts/webkitpy/layout_tests/port/chromium.py:
3049         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3050         * Scripts/webkitpy/layout_tests/port/test.py:
3051         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
3052         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3053         * Scripts/webkitpy/style/checkers/test_expectations.py:
3054         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
3055
3056 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
3057
3058         Reviewed by Darin Adler.
3059
3060         Add a no-build option to run-webkit-tests, to avoid building DRT/WKTR
3061         https://bugs.webkit.org/show_bug.cgi?id=52307
3062
3063         * Scripts/old-run-webkit-tests:
3064
3065 2011-01-12  Koan-Sin Tan  <koansin.tan@gmail.com>
3066
3067         Reviewed by Martin Robinson.
3068
3069         [Gtk] WebKitGtk+ doesn't build on Mac OS X 10.6
3070         https://bugs.webkit.org/show_bug.cgi?id=50867
3071
3072         Fixed library extention for Mac in webkitdirs.pm and type conflict in
3073         TestNetscapePlugin.cpp 
3074
3075         * GNUmakefile.am: Don't use AppKit when compiling TestNetscapePlugin for GTK+
3076         * Scripts/webkitdirs.pm:
3077
3078 2011-01-12  Mikhail Naganov  <mnaganov@chromium.org>
3079
3080         Reviewed by Pavel Feldman.
3081
3082         Add check-inspector-strings script.
3083
3084         https://bugs.webkit.org/show_bug.cgi?id=52295
3085
3086         * Scripts/check-inspector-strings: Added.
3087
3088 2011-01-12  Adam Roben  <aroben@apple.com>
3089
3090         Advertise the .testnetscape file extension on Windows
3091
3092         Fixes <http://webkit.org/b/52298>
3093         plugins/no-mime-with-valid-extension.html fails on Windows
3094
3095         Reviewed by Dan Bernstein.
3096
3097         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Added a
3098         FileExtents field to map the .testnetscape file extension to the
3099         application/x-webkit-test-netscape MIME type, just as we do on Mac.
3100
3101 2011-01-12  Adam Barth  <abarth@webkit.org>
3102
3103         Reviewed by Eric Seidel.
3104
3105         Make webkit-patch support subdirectories for SVN checkouts
3106         https://bugs.webkit.org/show_bug.cgi?id=52261
3107
3108         os.relpath does not exist on Python 2.5, so we need to call our version
3109         of the API.
3110
3111         * Scripts/webkitpy/common/checkout/scm.py:
3112
3113 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
3114
3115         Reviewed by Eric Seidel.
3116
3117         Close additional pages opened during a test once the test completes.
3118         https://bugs.webkit.org/show_bug.cgi?id=52276
3119
3120         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3121         (WTR::InjectedBundle::done):
3122
3123 2011-01-11  David Levin  <levin@chromium.org>
3124
3125         Reviewed by Eric Seidel.
3126
3127         Errors should be separated from the command line in bot messages.
3128         https://bugs.webkit.org/show_bug.cgi?id=52275
3129
3130         * Scripts/webkitpy/common/system/executive.py:
3131         (ScriptError.message_with_output): Added a newline to separate the command
3132         line from the errors.
3133         * Scripts/webkitpy/common/system/executive_unittest.py:
3134         (ScriptErrorTest.test_message_with_output): Added tests for the various code
3135         paths in message_with_output.
3136
3137 2011-01-11  Eric Seidel  <eric@webkit.org>
3138
3139         Unreviewed.
3140
3141         commit-queue should know how to upload archived results (for test flakes or general failures)
3142         https://bugs.webkit.org/show_bug.cgi?id=52048
3143
3144         The zips are mostly empty due to forgetting -r.
3145         Expected diffs were not being pulled from the archive due
3146         to the archive having longer paths than I realized.
3147
3148         * Scripts/webkitpy/common/system/workspace.py:
3149         * Scripts/webkitpy/common/system/workspace_unittest.py:
3150         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3151         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3152
3153 2011-01-11  Dirk Pranke  <dpranke@chromium.org>
3154
3155         Reviewed by Ojan Vafai.
3156
3157         The current modifier parsing code in test_expectations is
3158         fragile and hard-coded, so it's not easy to understand the logic
3159         or easily add new types of modifiers (like GPU vs. CPU testing
3160         for graphics tests, or 32-bit vs. 64-bit differences).
3161
3162         This is the first of two patches that will add in more generic
3163         support and then eliminate the GPU-specific test expectations
3164         files for Chromium.
3165
3166         This patch adds two standalone objects for handling modifiers. The
3167         rules for interpreting modifiers, precedence, and conflicts are
3168         given in the docstring to the ModifierMatcher class, which
3169         returns ModifierMatchResult objects.
3170         
3171         This patch also adds routines to the Port interface and a
3172         default set of values in the base object, in order to obtain the
3173         values needed on a given test run. These values are then passed
3174         to the expectation parser. This also allows us to clean up the
3175         logic used to lint all of the different configurations in a
3176         single test_expectations.txt file.
3177
3178         The next patch will merge in the separate GPU expectations file.
3179
3180         https://bugs.webkit.org/show_bug.cgi?id=51222
3181
3182         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
3183         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
3184         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
3185         * Scripts/webkitpy/layout_tests/port/base.py:
3186         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3187         * Scripts/webkitpy/layout_tests/port/chromium.py:
3188         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3189         * Scripts/webkitpy/layout_tests/port/test.py:
3190         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3191         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3192
3193 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
3194
3195         Reviewed by Adam Barth.
3196
3197         Make webkit-patch support subdirectories for SVN checkouts
3198         https://bugs.webkit.org/show_bug.cgi?id=52261
3199
3200         * Scripts/webkitpy/common/checkout/scm.py:
3201         * Scripts/webkitpy/style_references.py:
3202         * Scripts/webkitpy/tool/main.py:
3203         * Scripts/webkitpy/tool/steps/preparechangelog.py:
3204
3205 2011-01-11  Eric Seidel  <eric@webkit.org>
3206
3207         Unreviewed.
3208
3209         commit-queue should know how to upload archived results (for test flakes or general failures)
3210         https://bugs.webkit.org/show_bug.cgi?id=52048
3211
3212         I changed the API for archive_last_layout_test_results w/o updating the implementation.  Oops.
3213         This fixes an exception seen on the commit-queue when attempting to report flaky tests.
3214
3215         * Scripts/webkitpy/common/system/workspace.py:
3216         * Scripts/webkitpy/common/system/workspace_unittest.py:
3217         * Scripts/webkitpy/tool/commands/queues.py:
3218
3219 2011-01-11  Sam Weinig  <sam@webkit.org>
3220
3221         Roll r75474 back in.
3222
3223 2011-01-11  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
3224
3225         Reviewed by Kenneth Rohde Christiansen.
3226
3227         [Qt] Remove uses of QFuture since it isn't supported on all platforms.
3228         https://bugs.webkit.org/show_bug.cgi?id=51204
3229
3230         * QtTestBrowser/webpage.h:
3231         (QtNAMThread::QtNAMThread):
3232         (QtNAMThread::networkAccessManager):
3233         (QtNAMThread::run):
3234
3235 2011-01-11  Peter Varga  <pvarga@webkit.org>
3236
3237         Unreviewed.
3238
3239         Add myself to committers' list.
3240
3241         * Scripts/webkitpy/common/config/committers.py:
3242
3243 2011-01-11  Eric Seidel  <eric@webkit.org>
3244
3245         Reviewed by Adam Barth.
3246
3247         commit-queue should know how to upload archived results (for test flakes or general failures)
3248         https://bugs.webkit.org/show_bug.cgi?id=52048
3249
3250         Now the queue will always upload results.  Either the entire zip, or just
3251         the diffs.txt in the case of text failures.
3252
3253         This should make understanding flakes much easier, and paves the way
3254         for having the EWS run layout tests (and upload failures).
3255
3256         In order to upload .zip files I had to teach bugzilla.py to autodetect
3257         mime types from the filename.  Since mimetypes.py doesn't include a mapping
3258         for .patch files, I have it add one before calling guess_type.
3259
3260         We may find that always uploading the whole zip instead of just the -diffs.txt
3261         file is preferable, but for now I'm keeping the old behavior because it makes
3262         quickly understanding text failures easy.
3263
3264         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3265         * Scripts/webkitpy/common/system/workspace.py: Added.
3266         * Scripts/webkitpy/common/system/workspace_unittest.py: Added.
3267         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3268         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3269         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3270         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3271         * Scripts/webkitpy/tool/commands/queues.py:
3272         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3273
3274 2011-01-10  Sheriff Bot  <webkit.review.bot@gmail.com>
3275
3276         Unreviewed, rolling out r75464.
3277         http://trac.webkit.org/changeset/75464
3278         https://bugs.webkit.org/show_bug.cgi?id=52193
3279
3280         Followup rollout for 75474 (Requested by Ossy on #webkit).
3281
3282         * MiniBrowser/mac/BrowserWindowController.m:
3283         (-[BrowserWindowController awakeFromNib]):
3284         * MiniBrowser/win/BrowserView.cpp:
3285         (BrowserView::create):
3286         * WebKitTestRunner/TestController.cpp:
3287         (WTR::createOtherPage):
3288         (WTR::TestController::initialize):
3289
3290 2011-01-10  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3291
3292         Reviewed by Csaba Osztrogonác.
3293
3294         [Qt] Baseline qt_minimal configuration
3295         https://bugs.webkit.org/show_bug.cgi?id=51313
3296
3297         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3298         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): Add
3299         QT_NO_UNDOSTACK guard.
3300
3301         * QtTestBrowser/launcherwindow.cpp:
3302         (LauncherWindow::createChrome): Add QT_NO_SHORTCUT and QT_NO_PRINTER
3303         guards.
3304         (LauncherWindow::applyZoom): Add QT_NO_ANIMATION guard.
3305         (LauncherWindow::screenshot): Add QT_NO_FILEDIALOG guard.
3306         (LauncherWindow::selectElements): Add QT_NO_INPUTDIALOG guard.
3307         (LauncherWindow::showUserAgentDialog): Add QT_NO_COMBOBOX guard.
3308
3309         * QtTestBrowser/launcherwindow.h:
3310         * QtTestBrowser/locationedit.cpp: Add QT_NO_INPUTDIALOG guard.
3311         * QtTestBrowser/locationedit.h: Ditto.
3312
3313         * QtTestBrowser/mainwindow.cpp:
3314         (MainWindow::buildUI): Add QT_NO_INPUTDIALOG, QT_NO_SHORTCUT and
3315         QT_NO_UNDOSTACK guards.
3316         (MainWindow::setAddressUrl): Add QT_NO_INPUTDIALOG guard.
3317         (MainWindow::changeLocation): Ditto.
3318         (MainWindow::openFile): Add QT_NO_FILEDIALOG guard.
3319         (MainWindow::openLocation): Add QT_NO_INPUTDIALOG guard.
3320
3321         * QtTestBrowser/webpage.cpp:
3322         (WebPage::openUrlInDefaultBrowser): Add QT_NO_DESKTOPSERVICES guard.
3323         (WebPage::authenticationRequired): Add QT_NO_LINEEDIT guard.
3324
3325         * QtTestBrowser/webview.cpp:
3326         (WebViewGraphicsBased::animatedFlip): Add QT_NO_ANIMATION guard.
3327         (WebViewGraphicsBased::animatedYFlip): Ditto.
3328
3329 2011-01-10  Sam Weinig  <sam@webkit.org>
3330
3331         Fix build.
3332
3333         * MiniBrowser/mac/BrowserWindowController.m:
3334         (-[BrowserWindowController awakeFromNib]):
3335         * MiniBrowser/win/BrowserView.cpp:
3336         (BrowserView::create):
3337         * WebKitTestRunner/TestController.cpp:
3338         (WTR::createOtherPage):
3339         (WTR::TestController::initialize):
3340
3341 2011-01-10  Eric Seidel  <eric@webkit.org>
3342
3343         Reviewed by Ojan Vafai.
3344
3345         style-queue messages are way too long for big patches
3346         https://bugs.webkit.org/show_bug.cgi?id=52161
3347
3348         We definitely could build much fancier list-to-string-with-limit functions
3349         but this should be sufficient for our needs at the moment.
3350
3351         * Scripts/webkitpy/common/system/executive.py:
3352         * Scripts/webkitpy/common/system/executive_unittest.py:
3353
3354 2011-01-10  Tony Chang  <tony@chromium.org>
3355
3356         Unreviewed, rolling out r75398.
3357         http://trac.webkit.org/changeset/75398
3358         https://bugs.webkit.org/show_bug.cgi?id=52008
3359
3360         Some layout tests are crashing on Chromium Win.
3361
3362         * DumpRenderTree/chromium/WebViewHost.cpp:
3363         (WebViewHost::updatePaintRect):
3364         * DumpRenderTree/chromium/WebViewHost.h:
3365
3366 2011-01-10  Adam Roben  <aroben@apple.com>
3367
3368         Roll out r75392
3369
3370         It isn't needed now that r75289 has been rolled out.
3371
3372         * Scripts/run-javascriptcore-tests:
3373
3374 2011-01-10  Maciej Stachowiak  <mjs@apple.com>
3375
3376         Reviewed by Anders Carlsson.
3377
3378         WebKitTestRunner uses crazy amounts of CPU, making layout tests slow and flaky
3379         https://bugs.webkit.org/show_bug.cgi?id=52160
3380
3381         * WebKitTestRunner/mac/TestControllerMac.mm:
3382         (WTR::TestController::platformRunUntil): Instead of busy-looping, wait for the timeout.
3383         Anything that can make runUntil() conditions turn true will happen on a run loop cycle
3384         anyway.
3385
3386 2011-01-10  Tony Chang  <tony@chromium.org>
3387
3388         Reviewed by Mihai Parparita.
3389
3390         [chromium] fix for animated gif layout tests
3391         https://bugs.webkit.org/show_bug.cgi?id=52008
3392
3393         * DumpRenderTree/chromium/WebViewHost.cpp: Schedule a paint when we update the paint rect
3394             to trigger gif animations.
3395         (WebViewHostPaintTask::WebViewHostPaintTask):
3396         (WebViewHostPaintTask::runIfValid):
3397         (WebViewHost::updatePaintRect):
3398         * DumpRenderTree/chromium/WebViewHost.h:
3399         (WebViewHost::taskList):
3400
3401 2011-01-10  Alejandro G. Castro  <alex@igalia.com>
3402
3403         Reviewed by Xan Lopez.
3404
3405         [GTK] Fix gtk2 compilation for master
3406         https://bugs.webkit.org/show_bug.cgi?id=51885
3407
3408         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
3409         (createBitmapContextFromWebView): Replaced the old
3410         gdk_drawable_get_size with gdk_pixmap_get_size.
3411
3412 2011-01-10  Patrick Gansterer  <paroga@webkit.org>
3413
3414         Reviewed by Laszlo Gombos.
3415
3416         [WINCE] Reenable NPAPI after r75203
3417         https://bugs.webkit.org/show_bug.cgi?id=52109
3418
3419         Remove the !isWinCE() check for ENABLE_NETSCAPE_PLUGIN_API and replace
3420         it with !isEfl(), because EFL port does not support NPAPI (yet).
3421
3422         * Scripts/build-webkit:
3423
3424 2011-01-10  Adam Roben  <aroben@apple.com>
3425
3426         Skip some asserting JS tests
3427
3428         See <http://webkit.org/b/52156>.
3429
3430         * Scripts/run-javascriptcore-tests:
3431
3432 2011-01-10  Martin Robinson  <mrobinson@igalia.com>
3433
3434         Reviewed by Xan Lopez.
3435
3436         [GTK] build-webkit disable Blob support via arguments passed to automake
3437         https://bugs.webkit.org/show_bug.cgi?id=52097
3438
3439         * Scripts/build-webkit: Enable Blob support when building WebKitGTK+ via
3440         build-webkit.
3441
3442 2011-01-10  Adam Roben  <aroben@apple.com>
3443
3444         Use the same name and description for TestNetscapePlugin on Windows and
3445         Mac
3446
3447         Fixes <http://webkit.org/b/52151>
3448         fast/frames/iframe-reparenting-plugins.html fails on Windows
3449
3450         Reviewed by Steve Falkenburg.
3451
3452         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Copied
3453         the name and description from Mac's Info.plist.
3454
3455 2011-01-10  Siddharth Mathur <siddharth.mathur@nokia.com>
3456
3457         Reviewed by Laszlo Gombos.
3458
3459         [Qt][WK2] Guard gcc-specific syntax
3460
3461         Non-gcc based compliers choke on the "-include"
3462         syntax for preinclude, place guard around it.
3463
3464         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3465         * WebKitTestRunner/qt/WebKitTestRunner.pro:
3466
3467 2011-01-10  Andreas Kling  <kling@webkit.org>
3468
3469         Reviewed by Simon Hausmann.
3470
3471         [Qt] [WK2] MiniBrowser does not load pages opened in new windows
3472         https://bugs.webkit.org/show_bug.cgi?id=52111
3473
3474         When getting a createNewPage() callback from QWKPage, create the
3475         new page with the same QWKContext as the page that is passed to
3476         the callback.
3477
3478         * MiniBrowser/qt/BrowserView.h:
3479         * MiniBrowser/qt/BrowserWindow.cpp:
3480         (newPageFunction):
3481         (BrowserWindow::BrowserWindow):
3482         * MiniBrowser/qt/BrowserWindow.h:
3483
3484 2011-01-10  Andreas Kling  <kling@webkit.org>
3485
3486         Reviewed by Kenneth Rohde Christiansen.
3487
3488         [Qt] MiniBrowser: Remove superfluous createNewPage() callback
3489
3490         BrowserView set its own useless createNewPage() callback on QWKPage.
3491         This was immediately overridden by BrowserWindow anyway, so remove
3492         the BrowserView one.
3493
3494         * MiniBrowser/qt/BrowserView.cpp:
3495         (BrowserView::BrowserView):
3496
3497 2011-01-10  John Knottenbelt  <jknotten@chromium.org>
3498
3499         Reviewed by Jeremy Orlow.
3500
3501         [Chromium] Remove non-client-based Geolocation code
3502         https://bugs.webkit.org/show_bug.cgi?id=50921
3503
3504         * DumpRenderTree/chromium/LayoutTestController.cpp:
3505         (LayoutTestController::setGeolocationPermission):
3506         (LayoutTestController::setMockGeolocationPosition):
3507         (LayoutTestController::setMockGeolocationError):
3508         * DumpRenderTree/chromium/WebViewHost.cpp:
3509         (WebViewHost::geolocationClientMock):
3510         (WebViewHost::reset):
3511         * DumpRenderTree/chromium/WebViewHost.h:
3512
3513 2011-01-10  Eric Seidel  <eric@webkit.org>
3514
3515         Reviewed by Adam Barth.
3516
3517         Commit bot tried to land r? cq+ patch
3518         https://bugs.webkit.org/show_bug.cgi?id=36638
3519
3520         It should now be possible to post a patch with r? and cq+ and the
3521         commit-queue will correctly wait for the r+ before attempting to land the patch.
3522         (This was a feature requested by several users.)
3523
3524         One caveat: We don't actually reject r-, cq+ patches from the queue
3525         (we just ignore them), but I think that's OK for now.
3526
3527         I also noticed that setting r- once a commit-queue node had grabbed
3528         a patch would not properly cancel the landing.  That's fixed and
3529         tested in this patch.
3530
3531         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3532         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3533         * Scripts/webkitpy/tool/bot/feeders.py:
3534         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
3535
3536 2011-01-08  Benjamin Poulain  <benjamin.poulain@nokia.com>
3537
3538         Reviewed by Kenneth Rohde Christiansen.
3539
3540         [Qt] QtWebKit crashes when using XMLHttpRequest from the unload event
3541         https://bugs.webkit.org/show_bug.cgi?id=51934
3542
3543         When accessing the network from the destructor of QWebPage, the network access manager
3544         was already deleted because the object WebPage was already destructed.
3545
3546         This solve the problem by linking the lifetime of the network access manager to WebPage's QObject.
3547         The object is now destructed in the destructor of QObject.
3548
3549         * QtTestBrowser/webpage.cpp:
3550         (WebPage::WebPage):
3551         (WebPage::setQnamThreaded):
3552         * QtTestBrowser/webpage.h:
3553         (QtNAMThread::QtNAMThread):
3554
3555 2011-01-08  Eric Seidel  <eric@webkit.org>
3556
3557         Reviewed by Ojan Vafai.
3558
3559         test_failures.py should not mention TestShell (long live DumpRenderTree!)
3560         https://bugs.webkit.org/show_bug.cgi?id=52067
3561
3562         I ran test-webkitpy, but didn't bother adding a unit test for this string change.
3563         https://bugs.webkit.org/show_bug.cgi?id=51138#c3 is an example of why this is needed.
3564
3565         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
3566
3567 2011-01-08  Eric Seidel  <eric@webkit.org>
3568
3569         Reviewed by Mihai Parparita.
3570
3571         commit-queue hangs when the ChangeLog diff is bad
3572         https://bugs.webkit.org/show_bug.cgi?id=52072
3573
3574         * Scripts/webkitpy/tool/steps/validatechangelogs.py:
3575         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
3576
3577 2011-01-08  Adam Barth  <abarth@webkit.org>
3578
3579         Teach svn-apply how to re-write WebCore to Source/WebCore.
3580
3581         * Scripts/VCSUtils.pm:
3582
3583 2011-01-07  Adam Barth  <abarth@webkit.org>
3584
3585         Rubber-stamped by Eric Seidel.
3586
3587         Move WebCore to Source
3588         https://bugs.webkit.org/show_bug.cgi?id=52050
3589
3590         Update the tools to understand WebCore's new location.
3591
3592         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3593         * DumpRenderTree/wscript:
3594         * GNUmakefile.am:
3595         * Scripts/build-webkit:
3596         * Scripts/do-file-rename:
3597         * Scripts/do-webcore-rename:
3598         * Scripts/generate-qt-inspector-resource:
3599         * Scripts/prepare-ChangeLog:
3600         * Scripts/run-bindings-tests:
3601         * Scripts/update-iexploder-cssproperties:
3602         * Scripts/update-sources-list.py:
3603         * Scripts/update-webkit-localizable-strings:
3604         * Scripts/webkitdirs.pm:
3605         * Scripts/webkitpy/common/config/build.py:
3606         * Scripts/webkitpy/common/config/build_unittest.py:
3607         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
3608         * Scripts/webkitpy/style/checker.py:
3609         * Scripts/webkitpy/style/checker_unittest.py:
3610         * WebKitTestRunner/DerivedSources.pro:
3611         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3612         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh:
3613         * wx/browser/wscript:
3614         * wx/build/settings.py:
3615
3616 2011-01-07  Maciej Stachowiak  <mjs@apple.com>
3617
3618         Reviewed by Sam Weinig.
3619
3620         Make WebKitTestRunner rest between loads more robust to avoid test crashes
3621         https://bugs.webkit.org/show_bug.cgi?id=52086
3622
3623         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3624         (WTR::InjectedBundle::didReceiveMessage):
3625         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3626         (WTR::LayoutTestController::notifyDone):
3627         * WebKitTestRunner/TestController.cpp:
3628         (WTR::TestController::resetStateToConsistentValues):
3629         (WTR::TestController::run):
3630
3631 2011-01-07  James Robinson  <jamesr@chromium.org>
3632
3633         Revert "Implement mozilla's animationTime property"
3634         https://bugs.webkit.org/show_bug.cgi?id=51952
3635
3636         This approach isn't quite right.
3637
3638         * DumpRenderTree/chromium/WebViewHost.cpp:
3639         (WebViewHost::paintInvalidatedRegion):
3640
3641 2011-01-07  Adam Roben  <aroben@apple.com>
3642
3643         Build master fix
3644
3645         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3646         (RunWebKitTests.start): Don't try to concatenate a list and a string.
3647
3648 2011-01-07  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>
3649
3650         Reviewed by Csaba Osztrogonác.
3651
3652         run-qtwebkit-tests should be able to kill a testsuite.
3653
3654         Add new option in the script that can setup a timeout for a test.
3655         If the test execution takes more then specified time then the test
3656         would be terminated.
3657
3658         [Qt] run-qtwebkit-tests needs timeout
3659         https://bugs.webkit.org/show_bug.cgi?id=51894
3660
3661         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3662         * Scripts/run-qtwebkit-tests:
3663
3664 2011-01-07  Csaba Osztrogonác  <ossy@webkit.org>
3665
3666         Unreviewed fix after r75233.
3667
3668         Based on idea from Eric Seidel.
3669
3670         Add remote zip file handling to webkitpy.
3671         https://bugs.webkit.org/show_bug.cgi?id=50901
3672
3673         * Scripts/webkitpy/common/system/fileset.py: Make python 2.5 happy.
3674
3675 2011-01-07  Shane Stephens  <shanestephens@google.com>
3676
3677         Reviewed by Eric Seidel.
3678
3679         svn-apply: should support git binary delta diffs
3680         https://bugs.webkit.org/show_bug.cgi?id=38864
3681
3682         * Scripts/VCSUtils.pm:
3683         * Scripts/svn-apply:
3684
3685 2011-01-06  Julie Parent  <jparent@chromium.org>
3686
3687         Reviewed by Eric Seidel.
3688
3689         Test Result Server not removing old results.
3690         https://bugs.webkit.org/show_bug.cgi?id=52012
3691
3692         * TestResultServer/model/jsonresults.py:
3693         Fix off-by-one: Truncate if >= num_runs, not just >.
3694         * TestResultServer/model/jsonresults_unittest.py:
3695         Add unit test to test that merging in a new result with the same value
3696         as the last result causes previous result to fall off.
3697
3698 2011-01-06  James Kozianski  <koz@chromium.org>
3699
3700         Reviewed by Mihai Parparita.
3701
3702         Add classes to provide a consistent interface to a set of files.
3703         https://bugs.webkit.org/show_bug.cgi?id=50901
3704
3705         These classes allow us to write code that is agnostic to whether a
3706         particular set of files resides in a local directory or in a zip file
3707         on a remote machine.
3708
3709         * Scripts/webkitpy/common/system/directoryfileset.py: Added.
3710         * Scripts/webkitpy/common/system/directoryfileset_unittest.py: Added.
3711         * Scripts/webkitpy/common/system/fileset.py: Added.
3712         * Scripts/webkitpy/common/system/filesystem.py:
3713         * Scripts/webkitpy/common/system/filesystem_mock.py:
3714         * Scripts/webkitpy/common/system/zipfileset.py: Added.
3715         * Scripts/webkitpy/common/system/zipfileset_unittest.py: Added.
3716
3717 2011-01-06  Eric Seidel  <eric@webkit.org>
3718
3719         Reviewed by Adam Barth.
3720
3721         NetworkTransaction should log the url it is retrying
3722         https://bugs.webkit.org/show_bug.cgi?id=52043
3723
3724         * Scripts/webkitpy/common/net/networktransaction.py:
3725         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
3726
3727 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
3728
3729         Windows build fix.
3730         Import os before using it.
3731
3732         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3733
3734 2011-01-06  Eric Seidel  <eric@webkit.org>
3735
3736         Reviewed by Adam Barth.
3737
3738         StyleQueue fails to report errors when patches have many files
3739         https://bugs.webkit.org/show_bug.cgi?id=52042
3740
3741         This is one of at least two errors preventing style error reporting at the moment.
3742         When we moved to passing the list of files to check explicitly,
3743         we started to exceed the 500 character TEXT field limit for our AppEngine model object.
3744         We could change the type of the QueueStatus.message type, or we could
3745         just teach statusserver.py how to clamp values (and warn when it does).
3746         I chose the latter path.
3747
3748         * Scripts/webkitpy/common/net/statusserver.py:
3749
3750 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
3751
3752         Reviewed by Stephanie Lewis.
3753         
3754         Fix syntax error in script.
3755
3756         Windows bots need to archive/unarchive builds to/from configuration-specific directories
3757         https://bugs.webkit.org/show_bug.cgi?id=51996
3758
3759         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3760
3761 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3762
3763         Unreviewed, fixing WinCE build after r75196.
3764
3765         WinCE port does not (yet) support NPAPI.
3766
3767         * Scripts/build-webkit:
3768
3769 2011-01-06  Xan Lopez  <xlopez@igalia.com>
3770
3771         Reviewed by Darin Adler.
3772
3773         File::Spec->rel2abs in sunspider-compare-results mangles parameters
3774         https://bugs.webkit.org/show_bug.cgi?id=52015
3775
3776         * Scripts/sunspider-compare-results: call rel2abs on our arguments
3777         after the platform has been detected, otherwise the script will
3778         mangle things like '--gtk' into '/a/path/--gtk', breaking the
3779         detection.
3780
3781 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3782
3783         Reviewed by Eric Seidel.
3784
3785         Add ENABLE_NETSCAPE_PLUGIN_API, ENABLE_ORIENTATION_EVENTS and ENABLE_TOUCH_EVENTS flags to build-webkit
3786         https://bugs.webkit.org/show_bug.cgi?id=51346
3787
3788         * Scripts/build-webkit:
3789
3790 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
3791
3792         Reviewed by Adam Roben.
3793
3794         Windows bots need to archive/unarchive builds to/from configuration-specific directories
3795         https://bugs.webkit.org/show_bug.cgi?id=51996
3796         
3797         After the configuration directory change, we were archiving the incorrect directory for
3798         build product, so we were running tests on the wrong binaries.
3799         
3800         This change archives the correct directory, and also unarchives it into a configuration-