685630ce36d1a5833e63140632a15d089d25297e
[WebKit.git] / Tools / ChangeLog
1 2011-01-20  Alexey Proskuryakov  <ap@apple.com>
2
3         Reviewed by Darin Adler.
4
5         https://bugs.webkit.org/show_bug.cgi?id=52849
6         Make window.print work with WebKit2
7
8         * MiniBrowser/mac/BrowserWindowController.m:
9         (-[BrowserWindowController awakeFromNib]):
10         * WebKitTestRunner/TestController.cpp:
11         (WTR::createOtherPage):
12         (WTR::TestController::initialize):
13         Added zeroes to WKPageUIClient structures to avoid build failures.
14
15 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
16
17         Reviewed by Eric Seidel.
18
19         nrwt: remove fs refs from printing, test_failures, test_expectations, text_diff
20
21         https://bugs.webkit.org/show_bug.cgi?id=52756
22
23         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
24         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
25         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
26         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
27         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
28         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
29
30 2011-01-20  Mansi Mithal  <mansi.mithal@nokia.com>
31
32         Reviewed by Antonio Gomes.
33
34         QtTestBrowser should have a seperate menu for Settings
35         https://bugs.webkit.org/show_bug.cgi?id=52817
36         
37         Added a new menu item named "Settings"
38         and moved the "Enable interrupting js scripts" and "Enable js pop up windows" under the "Settings" menu 
39
40         * QtTestBrowser/launcherwindow.cpp:
41         (LauncherWindow::createChrome):
42
43 2011-01-20  Sam Weinig  <sam@webkit.org>
44
45         Reviewed by John Sullivan.
46
47         Update update-webkit-localizable-strings with new path to WebKit.
48
49         * Scripts/update-webkit-localizable-strings:
50
51 2011-01-20  James Robinson  <jamesr@chromium.org>
52
53         Reviewed by Darin Fisher.
54
55         Implement mozilla's requestAnimationFrame API
56         https://bugs.webkit.org/show_bug.cgi?id=51218
57
58         Chromium DumpRenderTree support for window.webkitRequestAnimationFrame.
59
60         * DumpRenderTree/chromium/WebViewHost.cpp:
61         (invokeScheduleComposite):
62         (WebViewHost::scheduleAnimation):
63         (WebViewHost::paintInvalidatedRegion):
64         * DumpRenderTree/chromium/WebViewHost.h:
65
66 2011-01-20  Maciej Stachowiak  <mjs@apple.com>
67
68         Reviewed by Adam Roben.
69
70         WebKitTestRunner needs to support layoutTestController.evaluateScriptInIsolatedWorld
71         https://bugs.webkit.org/show_bug.cgi?id=42327
72
73         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm: Add support
74         for methods that take their normal arguments but also a JSContextRef.
75         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: IDL definition
76         for evaluateScriptInIsolatedWorld.
77         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
78         (WTR::InjectedBundlePage::didClearWindowForFrame): Set a magic variable only if
79         this call is for an isolated world.
80         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
81         (WTR::worldMap): Helper to create a world map.
82         (WTR::LayoutTestController::worldIDForWorld): Map from an ID to a world.
83         (WTR::LayoutTestController::evaluateScriptInIsolatedWorld): The newly
84         added LayoutTestController API.
85         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
86
87 2011-01-19  Adam Roben  <aroben@apple.com>
88
89         Convert paths in environment variables back to msys-style inside commit-log-editor
90
91         When this script gets run from inside git commit, msys-style paths in the environment will
92         have been turned into Windows-style paths with forward slashes. This screws up functions
93         like File::Spec->rel2abs, which seem to rely on $PWD having an msys-style path. We convert
94         the paths back to msys-style before doing anything else.
95
96         Fixes <http://webkit.org/b/48527> commit-log-editor uses full paths for section headers when
97         using msysgit's Perl and multiple ChangeLogs have been edited
98
99         Reviewed by David Kilzer.
100
101         * Scripts/commit-log-editor: Call fixEnvironment before doing anything else.
102         (fixEnvironment): Added. When run in msys in conjunction with git (i.e., when invoked from
103         inside git commit), convert Windows-style paths in the environment back to msys-style paths.
104
105 2011-01-20  Zoltan Horvath  <zoltan@webkit.org>
106
107         [Win] Unreviewed build fix after r76248.
108
109         * DumpRenderTree/ForwardingHeaders/wtf/FastAllocBase.h: Added.
110
111 2011-01-20  Zoltan Horvath  <zoltan@webkit.org>
112
113         Reviewed by Csaba Osztrogonác.
114
115         Refactoring of the custom allocation framework
116         https://bugs.webkit.org/show_bug.cgi?id=49897
117
118         Inheriting from FastAllocBase can result in objects getting larger (bug #33896, #46589).
119         The modification replaces Noncopyable and FastAllocBase classes and these inherits with their
120         equivalent macro implementation at the necessary places.
121 2011-01-20  Yi Shen  <yi.4.shen@nokia.com>
122
123         Unreviewed. 
124
125         Adding myself to committers.py.
126
127         * Scripts/webkitpy/common/config/committers.py:
128
129 2011-01-20  Adam Barth  <abarth@webkit.org>
130
131         Reviewed by Tony Chang.
132
133         Chromium builders don't delete unversioned directories when DEPS change
134         https://bugs.webkit.org/show_bug.cgi?id=52745
135
136         If we pass this option to gclient sync, gclient will delete directories
137         that are no longer part of DEPS instead of leaving them around to
138         confuse us later.  Apparently, the downstream buildbots use this option
139         already.
140
141         * Scripts/update-webkit-chromium:
142
143 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
144
145         Unreviewed, build fix - I pulled this patch in to fix an issue
146         revealed by r76195 running on some new bots). Also fix a couple
147         of other issues revealed in testing.
148
149         nrwt: remove fs refs from layout_package/json*
150
151         https://bugs.webkit.org/show_bug.cgi?id=52754
152
153         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
154         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
155         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
156         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
157         * Scripts/webkitpy/layout_tests/port/base.py:
158
159 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
160
161         Unreviewed, build fix.
162
163         Fix a couple of minor bugs discovered while bringing up new bots
164         for testing.
165
166         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
167         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
168
169 2011-01-19  James Robinson  <jamesr@chromium.org>
170
171         Unreviewed, rolling out r76194.
172         http://trac.webkit.org/changeset/76194
173         https://bugs.webkit.org/show_bug.cgi?id=51218
174
175         Caused mysterious compile failure on the chromium win
176         build.webkit.org bots
177
178         * DumpRenderTree/chromium/WebViewHost.cpp:
179         (WebViewHost::paintInvalidatedRegion):
180         * DumpRenderTree/chromium/WebViewHost.h:
181
182 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
183
184         Reviewed by Mihai Parparita.
185
186         remove fs refs from test_runner, dump_render_tree_thread
187
188         https://bugs.webkit.org/show_bug.cgi?id=52753
189
190         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
191         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
192         * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
193         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
194
195 2011-01-19  James Robinson  <jamesr@chromium.org>
196
197         Reviewed by Darin Fisher.
198
199         Implement mozilla's requestAnimationFrame API
200         https://bugs.webkit.org/show_bug.cgi?id=51218
201
202         Chromium DumpRenderTree support for window.webkitRequestAnimationFrame.
203
204         * DumpRenderTree/chromium/WebViewHost.cpp:
205         (invokeScheduleComposite):
206         (WebViewHost::scheduleAnimation):
207         (WebViewHost::paintInvalidatedRegion):
208         * DumpRenderTree/chromium/WebViewHost.h:
209
210 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
211
212         Unreviewed, build fix.
213
214         Fix a few incorrect "self._filesystem" references introduced in
215         r76184.
216
217         * Scripts/webkitpy/layout_tests/port/chromium.py:
218         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
219
220 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
221
222         Reviewed by Mihai Parparita.
223
224         add a .sep property, abspath(), isabs(), mtime(), and
225         open_text_file_for_writing() to filesystem modules. Some of
226         these properties are not needed in this patch but will be needed
227         in subsequent patches (I'm doing this to avoid having to track
228         multiple versions of a single file).
229
230         Also, change most of the port/* modules to use the filesystem
231         objects instead of referencing the filesystem directly.
232
233         https://bugs.webkit.org/show_bug.cgi?id=52748
234
235         * Scripts/webkitpy/common/system/filesystem.py:
236         * Scripts/webkitpy/common/system/filesystem_mock.py:
237         * Scripts/webkitpy/layout_tests/port/__init__.py:
238         * Scripts/webkitpy/layout_tests/port/base.py:
239         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
240         * Scripts/webkitpy/layout_tests/port/chromium.py:
241         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
242         * Scripts/webkitpy/layout_tests/port/config.py:
243         * Scripts/webkitpy/layout_tests/port/test.py:
244         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
245
246 2011-01-19  Maciej Stachowiak  <mjs@apple.com>
247
248         Reviewed by Anders Carlsson.
249
250         If resetting between tests times out, treat it as a WebProcess crash
251         https://bugs.webkit.org/show_bug.cgi?id=52757
252
253         * WebKitTestRunner/TestController.cpp:
254         (WTR::TestController::runTest):
255
256 2011-01-19  Alexey Proskuryakov  <ap@apple.com>
257
258         Reviewed by Darin Adler.
259
260         https://bugs.webkit.org/show_bug.cgi?id=52739
261         Make it possible for a WebKit2 client to print headers and footers
262
263         Added dummy implementations for new printing UIClient calls.
264
265         * MiniBrowser/mac/BrowserWindowController.m:
266         (-[BrowserWindowController awakeFromNib]):
267         * WebKitTestRunner/TestController.cpp:
268         (WTR::createOtherPage):
269         (WTR::TestController::initialize):
270
271 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
272
273         Reviewed by Ojan Vafai.
274
275         Change webkitpy/layout_tests/port/test.py to use the
276         in-memory filesystem for cleaner unit testing. This
277         change allows us to kill a lot of code that was
278         specific to the test port, at the cost of being a
279         little less clear about how things would work if
280         you didn't have a filesystem.
281
282         https://bugs.webkit.org/show_bug.cgi?id=52605
283
284         * Scripts/webkitpy/layout_tests/port/test.py:
285
286 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
287
288         Unreviewed, build fix.
289
290         Fix test failure caused by committing attachment 79368 instead
291         of attachment 79461 on bug 52604.
292
293         * Scripts/webkitpy/common/system/filesystem_mock.py:
294
295 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
296
297         Reviewed by Mihai Parparita.
298
299         new-run-webkit-tests: remove use of os.walk, use mock filesystem for better
300         unit testing. os.walk() is too much of a hassle to implement on
301         top of the in-memory mock filesystem and adding the necessary
302         interface to files_under() gives clients a cleaner API anyway
303         (for this particular usage model).
304
305         https://bugs.webkit.org/show_bug.cgi?id=52691
306
307         * Scripts/webkitpy/common/system/filesystem.py:
308         * Scripts/webkitpy/common/system/filesystem_mock.py:
309         * Scripts/webkitpy/layout_tests/port/test_files.py:
310         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
311
312 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
313
314         Reviewed by Tony Chang.
315
316         Change more modules in the layout-tests code to use the
317         filesystem wrapper for cleaner unit testing.
318
319         This patch also adds the glob() wrapper to the filesystem
320         abstraction.
321         
322         https://bugs.webkit.org/show_bug.cgi?id=52604
323
324         * Scripts/webkitpy/layout_tests/port/test_files.py:
325         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
326         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
327         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
328         * Scripts/webkitpy/common/system/filesystem.py:
329         * Scripts/webkitpy/common/system/filesystem_mock.py:
330
331 2011-01-19  Levi Weintraub  <leviw@chromium.org>
332
333         Unreviewed.
334
335         Updating my email addresses and irc nick.
336
337         * Scripts/webkitpy/common/config/committers.py:
338
339 2011-01-19  Tony Chang  <tony@chromium.org>
340
341         Reviewed by Mihai Parparita.
342
343         [chromium] [linux] if check-sys-deps fails, output the failure reason
344         https://bugs.webkit.org/show_bug.cgi?id=52671
345
346         * Scripts/webkitpy/common/system/executive_mock.py: Add support for
347             error handler functions.
348         * Scripts/webkitpy/layout_tests/port/chromium.py:
349             output the error text from --check-sys-deps
350         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
351
352 2011-01-19  Aparna Nandyal  <aparna.nand@wipro.com>
353
354         Reviewed by Andreas Kling.
355
356         [Qt] QtTestBrowser crashes when closing if Facebook is opened
357         https://bugs.webkit.org/show_bug.cgi?id=52554
358         
359         QtNetworkAccessManager is created in a thread and set as
360         member variable in QWebPage. When the thread is destroyed
361         the object is still used. So fix will set the object to
362         NULL once the thread is destroyed.
363
364         * QtTestBrowser/launcherwindow.cpp:
365         (LauncherWindow::~LauncherWindow):
366
367 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
368
369         Rubber stamped by Csaba Osztrogonac
370
371         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: Removed unncessary inculde of WKStringCF.h
372
373 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
374
375         Reviewed by Tony Chang.
376
377         new-run-webkit-tests: add a --build-directory command line argument
378
379         Official Google Chrome builds use a non-standard build directory
380         location. This patch adds a --build-directory argument that
381         allows that location to be specified on the command line. Only
382         Chromium-based builds will use this flag for now, but anyone can
383         in the future.
384
385         There are no unit tests for this since it's difficult to test
386         until mock filesystems are fully supported in the code. This was
387         tested by hand for now.
388
389         https://bugs.webkit.org/show_bug.cgi?id=52694
390
391         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
392         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
393         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
394         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
395
396 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
397
398         Not reviewed. Bot fix.
399
400         Remove an inadvertently committed debugging print.
401
402         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
403         (LayoutTestController::notifyDone):
404
405 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
406
407         Reviewed by Sam Weinig.
408
409         WebKitTestRunner should track loading more like DumpRenderTree
410         https://bugs.webkit.org/show_bug.cgi?id=52692
411
412         Change load tracking to track the current top loading frame, in the manner of DumpRenderTree.
413         This makes some tests that call notifyDone multiple times pass.
414         
415         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
416         (WTR::InjectedBundle::InjectedBundle):
417         (WTR::InjectedBundle::done):
418         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
419         (WTR::InjectedBundle::topLoadingFrame):
420         (WTR::InjectedBundle::setTopLoadingFrame):
421         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
422         (WTR::InjectedBundlePage::InjectedBundlePage):
423         (WTR::InjectedBundlePage::stopLoading):
424         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
425         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
426         (WTR::InjectedBundlePage::didFinishLoadForFrame):
427         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
428         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
429         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
430         (WTR::LayoutTestController::notifyDone):
431         * WebKitTestRunner/TestController.cpp:
432         (WTR::TestController::didReceiveMessageFromInjectedBundle):
433
434 2011-01-18  Mihai Parparita  <mihaip@chromium.org>
435
436         Reviewed by Kent Tamura.
437
438         [Chromium] NRWT looking for DRT binary in the wrong path on Mac
439         https://bugs.webkit.org/show_bug.cgi?id=52678
440         
441         Update path now that WebKit is inside Source.
442
443         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
444
445 2011-01-18  Robert Hogan  <robert@webkit.org>
446
447         Reviewed by Simon Hausmann.
448
449         [Qt] http/tests/incremental/slow-utf8-text.pl fails
450         https://bugs.webkit.org/show_bug.cgi?id=44282
451
452         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
453         (WebCore::DumpRenderTree::dump):
454
455 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
456
457         Reviewed by Mihai Parparita.
458
459         Fix a small race condition that could cause the unit tests for
460         new-run-webkit-tests to fail in a multithreaded environment.
461         There was a small window in the code where one thread would
462         check to see if a thread had raised an exception, do something,
463         and then check to see if the thread was alive. If the other
464         thread raised an exception and exited in between these two
465         steps, the exception would be lost. Flipping the order of the
466         two checks fixes the race, since we will now always check for an
467         exception on the thread before exiting.
468
469         https://bugs.webkit.org/show_bug.cgi?id=51579
470
471         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
472
473 2011-01-18  Eric Seidel  <eric@webkit.org>
474
475         Reviewed by Adam Barth.
476
477         commit-queue dies when test archiving fails
478         https://bugs.webkit.org/show_bug.cgi?id=52617
479
480         I looked at the machine and it had 10 archives already
481         thus find_unused_name was returning None.  I've upped
482         the limit to 100 (per bug) and tested the case where
483         find_unused_name returns None (making archive return None).
484
485         * Scripts/webkitpy/common/system/workspace.py:
486         * Scripts/webkitpy/common/system/workspace_unittest.py:
487         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
488         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
489         * Scripts/webkitpy/tool/commands/queues.py:
490
491 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
492
493         Reviewed by Ojan Vafai.
494
495         Update rebaseline-chromium-webkit-tests unit tests to use a mock
496         filesystem. Also fix a couple of "with" statements missed by
497         r76050.
498
499         https://bugs.webkit.org/show_bug.cgi?id=52487
500
501         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
502
503 2011-01-18  Sergio Villar Senin  <svillar@igalia.com>
504
505         Reviewed by Martin Robinson.
506
507         [Gtk] Build fixes for gtk3 build
508         https://bugs.webkit.org/show_bug.cgi?id=52648
509
510         * DumpRenderTree/gtk/EventSender.cpp:
511         (beginDragWithFilesCallback):
512
513 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
514
515         Reviewed by Mihai Parparita.
516
517         Update rebaseline-chromium-webkit-tests to use filesystem objects
518         instead of direct references to os.path, shutil, tempfile, etc.
519
520         This patch doesn't change anything, but will allow subsequent
521         patches to change the unit tests to no longer use the real
522         filesystem.
523
524         This patch adds a bunch more methods to the filesystem object as
525         well.
526
527         https://bugs.webkit.org/show_bug.cgi?id=52482
528
529         * Scripts/webkitpy/common/system/filesystem.py:
530         * Scripts/webkitpy/common/system/filesystem_mock.py:
531         * Scripts/webkitpy/tool/commands/queues.py:
532         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
533         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
534
535 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
536
537         Reviewed by Mihai Parparita.
538
539         new-run-webkit-tests shouldn't crash when you try to run a
540         directory containing only skipped files.
541
542         https://bugs.webkit.org/show_bug.cgi?id=52478
543         
544         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
545         * Scripts/webkitpy/layout_tests/port/test.py:
546         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
547
548 2011-01-18  Adam Bergkvist  <adam.bergkvist@ericsson.com> and Martin Robinson  <mrobinson@igalia.com>
549
550         Reviewed by Gustavo Noronha Silva.
551
552         [GTK] The GTK+ EventSender needs support for beginDragWithFiles
553         https://bugs.webkit.org/show_bug.cgi?id=40833
554
555         * DumpRenderTree/gtk/EventSender.cpp: Add a beginDragWithFiles implementation for the
556         GTK+ event sender.
557         (dragWithFilesDragDataGetCallback): Added.
558         (dragWithFilesDragEndCallback): Added.
559         (beginDragWithFilesCallback): Added.
560
561 2011-01-18  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
562
563         Reviewed by Adam Barth.
564
565         ews: Add additional watcher to efl ews
566         https://bugs.webkit.org/show_bug.cgi?id=52613
567
568         Add gyuyoung.kim@samsung.com to watcher list of efl-ews.
569
570         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
571
572 2011-01-17  Tony Gentilcore  <tonyg@chromium.org>
573
574         Reviewed by Alexey Proskuryakov.
575
576         Fix some headers with missing or misspelled #ifndef guards
577         https://bugs.webkit.org/show_bug.cgi?id=52545
578
579         * DumpRenderTree/chromium/TestEventPrinter.h:
580         * DumpRenderTree/chromium/WebPreferences.h:
581
582 2011-01-17  Jessie Berlin  <jberlin@apple.com>
583
584         Reviewed by Anders Carlsson.
585
586         REGRESSION: Assertion failure in FrameLoader::continueLoadAfterWillSubmitForm() when
587         navigating back to an unreachable URL
588         https://bugs.webkit.org/show_bug.cgi?id=52388
589
590         Add a third parameter (unreachableURL) to queueLoadHTMLString.
591
592         * DumpRenderTree/LayoutTestController.cpp:
593         (queueLoadHTMLStringCallback):
594         (LayoutTestController::queueLoadHTMLString):
595         (LayoutTestController::queueLoadAlternateHTMLString):
596         * DumpRenderTree/LayoutTestController.h:
597
598         * DumpRenderTree/WorkQueueItem.h:
599         (LoadHTMLStringItem::LoadHTMLStringItem):
600
601         * DumpRenderTree/chromium/LayoutTestController.cpp:
602         (WorkItemLoadHTMLString::WorkItemLoadHTMLString):
603         (WorkItemLoadHTMLString::run):
604         (LayoutTestController::queueLoadHTMLString):
605
606         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
607         (LoadHTMLStringItem::invoke):
608         * DumpRenderTree/mac/WorkQueueItemMac.mm:
609         (LoadHTMLStringItem::invoke):
610         * DumpRenderTree/win/WorkQueueItemWin.cpp:
611         (LoadHTMLStringItem::invoke):
612
613 2011-01-17  Dan Bernstein  <mitz@apple.com>
614
615         Rubber-stamped by Mark Rowe.
616
617         Update xcodeproj svn:ignore to include xcuserdata.
618
619         * DumpRenderTree/DumpRenderTree.xcodeproj: Modified property svn:ignore.
620         * MiniBrowser/MiniBrowser.xcodeproj: Modified property svn:ignore.
621         * TestWebKitAPI/TestWebKitAPI.xcodeproj: Modified property svn:ignore.
622         * WebKitLauncher/WebKitLauncher.xcodeproj: Modified property svn:ignore.
623         * WebKitTestRunner/WebKitTestRunner.xcodeproj: Modified property svn:ignore.
624
625 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
626
627         Unreviewed fix after r75908.
628
629         Move WebKit into Source
630         https://bugs.webkit.org/show_bug.cgi?id=52530
631
632         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add Source to the path for Qt API tests.
633
634 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
635
636         Unreviewed.
637
638         Remove accidentally committed debug printing after r75908.
639
640         * Scripts/webkitdirs.pm:
641
642 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
643
644         Unreviewed.
645
646         Add myself to committers list
647         https://bugs.webkit.org/show_bug.cgi?id=52566
648
649         * Scripts/webkitpy/common/config/committers.py:
650
651 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
652
653         Reviewed by Jeremy Orlow.
654
655         GeolocationController should call stopUpdating on destruction
656         https://bugs.webkit.org/show_bug.cgi?id=52216
657
658         fast/dom/Geolocation/window-close-crash.html requires that a
659         Geolocation watch be started in a secondary window. Consequently,
660         we need to allow geolocation permission and provide a mock
661         geolocation position for the secondary window's
662         GeolocationClientMock.
663
664         * DumpRenderTree/chromium/LayoutTestController.cpp:
665         (LayoutTestController::setGeolocationPermission):
666         (LayoutTestController::setMockGeolocationPosition):
667         (LayoutTestController::setMockGeolocationError):
668         * DumpRenderTree/chromium/TestShell.h:
669         (TestShell::windowList):
670
671 2011-01-16  Adam Barth  <abarth@webkit.org>
672
673         Update more include paths to reflect WebKit move.
674
675         * DumpRenderTree/chromium/EventSender.cpp:
676         (EventSender::keyDown):
677         (EventSender::needsShiftModifier):
678         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
679         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
680
681 2011-01-16  Kent Tamura  <tkent@chromium.org>
682
683         Unreviewed, Chromium build fix.
684
685         * Scripts/update-webkit-chromium: Webkit/chromium -> Source/WebKit/chromium
686
687 2011-01-16  Martin Robinson  <mrobinson@igalia.com>
688
689         Build fix for GTK+ after source directory movement.
690
691         * GNUmakefile.am: Correct include paths.
692
693 2011-01-16  Adam Barth  <abarth@webkit.org>
694
695         Teach svn-apply about WebKit move.
696
697         * Scripts/VCSUtils.pm:
698
699 2011-01-16  Adam Barth  <abarth@webkit.org>
700
701         Rubber-stamped by Eric Seidel.
702
703         Move WebKit into Source
704         https://bugs.webkit.org/show_bug.cgi?id=52530
705
706         * DumpRenderTree/mac/InternalHeaders/WebKit/WebTypesInternal.h:
707         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
708         * DumpRenderTree/qt/DumpRenderTreeQt.h:
709         * DumpRenderTree/qt/GCControllerQt.cpp:
710         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
711         * DumpRenderTree/qt/PlainTextControllerQt.cpp:
712         * DumpRenderTree/qt/TextInputControllerQt.cpp:
713         * DumpRenderTree/wscript:
714         * QtTestBrowser/launcherwindow.h:
715         * Scripts/build-webkit:
716         * Scripts/webkitdirs.pm:
717
718 2011-01-15  Adam Barth  <abarth@webkit.org>
719
720         Teach svn-apply about WebKit2 move.
721
722         * Scripts/VCSUtils.pm:
723
724 2011-01-15  Adam Barth  <abarth@webkit.org>
725
726         Rubber-stamped by Eric Seidel.
727
728         Move WebKit2 into Source
729         https://bugs.webkit.org/show_bug.cgi?id=52438
730
731         * MiniBrowser/qt/MiniBrowser.pro:
732         * Scripts/build-webkit:
733         * Scripts/do-file-rename:
734         * Scripts/do-webcore-rename:
735         * Scripts/test-webkitpy:
736         * Scripts/webkitdirs.pm:
737         * Scripts/webkitpy/style/checker.py:
738         * WebKitTestRunner/DerivedSources.pro:
739         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
740         * WebKitTestRunner/qt/WebKitTestRunner.pro:
741
742 2011-01-15  Jochen Eisinger  <jochen@chromium.org>
743
744         Reviewed by David Levin.
745
746         [chromium] remove obsolete createView method
747         https://bugs.webkit.org/show_bug.cgi?id=52437
748
749         * DumpRenderTree/chromium/WebViewHost.cpp:
750         (WebViewHost::createView):
751         * DumpRenderTree/chromium/WebViewHost.h:
752
753 2011-01-14  Brian Weinstein  <bweinstein@apple.com>
754
755         Reviewed by Geoff Garen.
756
757         ShouldLoadResourceForFrame should use strings, not URLs.
758         https://bugs.webkit.org/show_bug.cgi?id=52476
759
760         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
761         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Update to use a WKStringRef.
762         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
763
764 2011-01-14  Tony Gentilcore  <tonyg@chromium.org>
765
766         Reviewed by David Levin.
767
768         Add Tony Gentilcore as a reviewer
769         https://bugs.webkit.org/show_bug.cgi?id=52480
770
771         * Scripts/webkitpy/common/config/committers.py:
772
773 2011-01-14  David Levin  <levin@chromium.org>
774
775         Reviewed by Eric Seidel.
776
777         check-webkit-style: _FunctionState should keep track of where the function name starts.
778         https://bugs.webkit.org/show_bug.cgi?id=52454
779
780         * Scripts/webkitpy/style/checkers/cpp.py: Added function_name_start_position to
781         _FunctionState and logic for setting it correctly.
782         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests.
783
784 2011-01-14  Vincent Scheib  <scheib@chromium.org>
785
786         Reviewed by David Levin.
787
788         Add support to DumpRenderTree to use the GPU rather than software renderer
789         https://bugs.webkit.org/show_bug.cgi?id=52333
790
791         * DumpRenderTree/chromium/DumpRenderTree.cpp:
792         (main):
793         * Scripts/webkitpy/layout_tests/port/chromium.py:
794         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
795
796 2011-01-14  Tony Chang  <tony@chromium.org>
797
798         Reviewed by Kent Tamura.
799
800         [chromium] update fonts.conf to fix 6 linux tests in drt
801         https://bugs.webkit.org/show_bug.cgi?id=52411
802
803         * DumpRenderTree/chromium/fonts.conf: Update to match the copy in
804             chromium's src/webkit/tools/test_shell/resources/fonts.conf
805
806 2011-01-14  Eric Seidel  <eric@webkit.org>
807
808         Original patch from Peter Gal  <galpater@inf.u-szeged.hu>
809
810         Reviewed by Adam Barth.
811
812         Fix when running Tools/Scripts/check-webkit-style without arguments.
813         https://bugs.webkit.org/show_bug.cgi?id=52261#c16
814
815         * Scripts/webkitpy/common/checkout/scm.py: Handle None for changed_files argument better in Git.create_patch method.
816         * Scripts/webkitpy/common/checkout/scm_unittest.py:
817
818 2011-01-04  Jochen Eisinger  <jochen@chromium.org>
819
820         Reviewed by David Levin.
821
822         Store the tempdir object in a variable so it doesn't get deleted too early.
823         https://bugs.webkit.org/show_bug.cgi?id=51875
824
825         * Scripts/update-webkit-auxiliary-libs:
826         * Scripts/update-webkit-support-libs:
827
828 2011-01-14  Eric Seidel  <eric@webkit.org>
829
830         Unreviewed.  Make it work in python 2.5.
831
832         webkit-patch suggest-reviewers dies when ChangeLogs are missing
833         https://bugs.webkit.org/show_bug.cgi?id=49158
834
835         * Scripts/webkitpy/common/checkout/api_unittest.py:
836
837 2011-01-14  Sheriff Bot  <webkit.review.bot@gmail.com>
838
839         Unreviewed, rolling out r75774.
840         http://trac.webkit.org/changeset/75774
841         https://bugs.webkit.org/show_bug.cgi?id=52431
842
843         gtk builds were broken (Requested by loislo2 on #webkit).
844
845         * Scripts/webkitpy/common/checkout/scm.py:
846
847 2011-01-14  David Levin  <levin@chromium.org>
848
849         Reviewed by Shinichiro Hamaji.
850
851         check-webkit-style: _FunctionState should detect pure functions.
852         https://bugs.webkit.org/show_bug.cgi?id=52428
853
854         * Scripts/webkitpy/style/checkers/cpp.py: Added detection for if a function declaration
855         is a pure virtual function.
856         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests for verifying that pure
857         virtual functions are correctly detected.
858
859 2011-01-13  Ilya Tikhonovsky  <loislo@chromium.org>
860
861         Reviewed by Yury Semikhatsky.
862
863         Just small fix for problem with check-webkit-style.
864         It just didn't work for this patch.
865         Old code can't concatenate a list of strings with None.
866
867         * Scripts/webkitpy/common/checkout/scm.py:
868
869 2011-01-13  David Levin  <levin@chromium.org>
870
871         Reviewed by Shinichiro Hamaji.
872
873         check-webkit-style: _FunctionState should use Position to know where items are.
874         https://bugs.webkit.org/show_bug.cgi?id=52424
875
876         * Scripts/webkitpy/style/checkers/cpp.py:
877         (_FunctionState.*): Changed _FunctionState to use Position instead of line numbers.
878         (detect_functions): Changed to pass Position's to _FunctionState.begin and
879         did some minor clean-up.
880         (*): Other changes are simply about converting to use the Position's in_FunctionState
881         instead of line numbers.
882         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Changed the test code
883         to verify the positions stored in _FunctionState.
884
885 2011-01-13  Eric Seidel  <eric@webkit.org>
886
887         Reviewed by David Levin.
888
889         webkit-patch suggest-reviewers dies when ChangeLogs are missing
890         https://bugs.webkit.org/show_bug.cgi?id=49158
891
892         This is not the most elegant, but it is a very safe fix to this bug.
893         One advantage of catching ScriptError like this instead of adding a
894         new added_or_modified_files or fixing all changed_files callers
895         to use a more specific change_files variant, is that we catch
896         all kinds of ScriptErrors which might cause our (non-essential)
897         suggest-reviewers code to fail out.  This should make passing
898         --suggest-reviewers to webkit-patch upload much more robust
899         and may even make it possible for us to make it default.
900
901         The root of the problem here is that SCM.changed_files includes
902         deleted ChangeLog paths (from moves, etc) which then when we ask
903         SVN/Git for the contents of the file at that revision, the command
904         errors out and Executive.run_command raises a ScriptError.
905
906         In the future we might fix this differently by making all current
907         callers of chagned_files use a more specific method for requesting
908         what types of changes they're interested in (adds, modifies, deletes, etc.)
909
910         * Scripts/webkitpy/common/checkout/api.py:
911         * Scripts/webkitpy/common/checkout/api_unittest.py:
912
913 2011-01-13  Dan Bernstein  <mitz@apple.com>
914
915         Reviewed by Alexey Proskuryakov.
916
917         <rdar://problem/8827065> REGRESSION (r71884): Cross-origin XHR fails if willSendRequest changes the URL
918         https://bugs.webkit.org/show_bug.cgi?id=52419
919
920         Allow to further control the behavior of the willSendRequest delegate callback by making it
921         set a different URL in the new request.
922
923         * DumpRenderTree/LayoutTestController.cpp:
924         (addURLToRedirectCallback): Added.
925         (LayoutTestController::staticFunctions): Added addURLToRedirect.
926         (LayoutTestController::addURLToRedirect): Added. Adds the redirection to the map.
927         (LayoutTestController::redirectionDestinationForURL): Added this getter.
928         * DumpRenderTree/LayoutTestController.h:
929         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
930         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]): Check
931         if there is a redirection for the request’s URL, established by addURLToRedirect(), and if so,
932         change the URL in the new request to the redirect destination.
933
934 2011-01-13  Eric Seidel  <eric@webkit.org>
935
936         Reviewed by Mihai Parparita.
937
938         webkit-patch suggest-reviewers fails due to invalid utf8 in ChangeLog files
939         https://bugs.webkit.org/show_bug.cgi?id=52416
940
941         Example: webkit-patch suggest-reviewers -g ca3890fe74d94d85d6bfa48f9ea497b094d8e717 
942         UnicodeDecodeError: 'utf8' codec can't decode bytes in position 536-538: invalid data
943
944         I also added FIXMEs about the changed_files returning deleted files problem
945         which is causing the other most common exception for suggest-reviewers
946         (and is probably breaking sheriff-bots blame detection).
947
948         * Scripts/webkitpy/common/checkout/api.py:
949         * Scripts/webkitpy/common/checkout/api_unittest.py:
950         * Scripts/webkitpy/common/checkout/scm.py:
951
952 2011-01-13  Eric Seidel  <eric@webkit.org>
953
954         Reviewed by Adam Barth.
955
956         results archives from commit-queue are too large to upload
957         https://bugs.webkit.org/show_bug.cgi?id=52405
958
959         * Scripts/webkitpy/common/system/filesystem.py:
960         * Scripts/webkitpy/common/system/filesystem_mock.py:
961         * Scripts/webkitpy/tool/commands/queues.py:
962
963 2011-01-13  Alejandro G. Castro  <alex@igalia.com>
964
965         Reviewed by Martin Robinson.
966
967         [gtk] Zero-sized font does not yet work
968         https://bugs.webkit.org/show_bug.cgi?id=49793
969
970         Set minimum-font-size to 0 for the DRT.
971
972         * DumpRenderTree/gtk/DumpRenderTree.cpp:
973         (resetDefaultsToConsistentValues):
974
975 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
976
977         Reviewed by Darin Adler.
978
979         Make old-run-webkit-tests more robust on buildbots
980         https://bugs.webkit.org/show_bug.cgi?id=52364
981
982         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Pass --exit-after-n-failures 500 to old-run-webkit-tests script.
983
984 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
985
986         Reviewed by Darin Adler.
987
988         Make old-run-webkit-tests more robust on buildbots
989         https://bugs.webkit.org/show_bug.cgi?id=52364
990
991         * Scripts/old-run-webkit-tests: Ensure that testResultsDirectory is empty.
992
993 2011-01-13  Tony Chang  <tony@chromium.org>
994
995         Reviewed by Kent Tamura.
996
997         [chromium] fix plugins/plugin-javascript-access.html on Linux and Mac
998         https://bugs.webkit.org/show_bug.cgi?id=52332
999
1000         Forked Info.plist is not longer needed.
1001
1002         * DumpRenderTree/chromium/TestNetscapePlugIn/Info.plist: Removed.
1003
1004 2011-01-13  Mikhail Naganov  <mnaganov@chromium.org>
1005
1006         Reviewed by Timothy Hatcher.
1007
1008         Web Inspector: Cleanup after r75613 -- make all UI-facing strings
1009         to be passed directly to WebInspector.UIString
1010
1011         https://bugs.webkit.org/show_bug.cgi?id=52365
1012
1013         * Scripts/check-inspector-strings:
1014
1015 2011-01-13  Sheriff Bot  <webkit.review.bot@gmail.com>
1016
1017         Unreviewed, rolling out r74881.
1018         http://trac.webkit.org/changeset/74881
1019         https://bugs.webkit.org/show_bug.cgi?id=52357
1020
1021         The EFL builder has been red for days (Requested by abarth on
1022         #webkit).
1023
1024         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1025         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1026
1027 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
1028
1029         Reviewed by David Levin.
1030
1031         Add beforeunload support to WebKitTestRunner
1032         https://bugs.webkit.org/show_bug.cgi?id=52353
1033         
1034         This makes a number of currently failing tests pass.
1035
1036         * WebKitTestRunner/TestController.cpp:
1037         (WTR::runBeforeUnloadConfirmPanel):
1038         (WTR::createOtherPage):
1039         (WTR::TestController::initialize):
1040
1041 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
1042
1043         Reviewed by Sam Weinig.
1044
1045         Detect, identify and recover from WebProcess crashes in run-webkit-tests
1046         https://bugs.webkit.org/show_bug.cgi?id=52330
1047
1048         * Scripts/old-run-webkit-tests: Detect when the regression test tool reports
1049         a web process crash.
1050         * WebKitTestRunner/TestController.cpp:
1051         (WTR::TestController::initialize): Set up a processDidCrash
1052         callback.
1053         (WTR::TestController::processDidCrash): Report that the Web process
1054         crashed.
1055         * WebKitTestRunner/TestController.h:
1056
1057 2011-01-12  David Levin  <levin@chromium.org>
1058
1059         Reviewed by Shinichiro Hamaji.
1060
1061         check-webkit-style -- close_expression function doesn't work correctly.
1062         https://bugs.webkit.org/show_bug.cgi?id=52272
1063
1064         * Scripts/webkitpy/style/checkers/cpp.py:
1065         (Position.__str__): Added a way to convert it to a string which is useful in tests.
1066         (Position.__cmp__): Added a way to compare Position which is useful in tests and
1067         generally useful (for upcoming code changes).
1068         (close_expression): Changed to use Position for input and output.
1069         Also, fixed many bugs such as only working correctly for parenthesis,
1070         not working correctly if given an offset in a line and not finding
1071         the real closing element if there were multiple closing elements in
1072         the same line.
1073         (detect_functions): Adjusted due to the change in arguments for
1074         close_expression.
1075         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1076         (CppStyleTestBase.assert_positions_equal): Added a way to verify that
1077         two positions are the same.
1078         (CppStyleTest.test_position): Added tests for the __str_ and __cmp__ methods.
1079         (CppStyleTest.test_close_expression): Added tests to catch the issues
1080         that were fixed.
1081
1082 2011-01-12  Sheriff Bot  <webkit.review.bot@gmail.com>
1083
1084         Unreviewed, rolling out r75576.
1085         http://trac.webkit.org/changeset/75576
1086         https://bugs.webkit.org/show_bug.cgi?id=52304
1087
1088         broke rebaseline-chromium-webkit-test (Requested by thakis on
1089         #webkit).
1090
1091         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1092         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1093         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
1094         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1095         * Scripts/webkitpy/layout_tests/port/base.py:
1096         * Scripts/webkitpy/layout_tests/port/chromium.py:
1097         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1098         * Scripts/webkitpy/layout_tests/port/test.py:
1099         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1100         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1101         * Scripts/webkitpy/style/checkers/test_expectations.py:
1102         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1103
1104 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
1105
1106         Reviewed by Darin Adler.
1107
1108         Add a no-build option to run-webkit-tests, to avoid building DRT/WKTR
1109         https://bugs.webkit.org/show_bug.cgi?id=52307
1110
1111         * Scripts/old-run-webkit-tests:
1112
1113 2011-01-12  Koan-Sin Tan  <koansin.tan@gmail.com>
1114
1115         Reviewed by Martin Robinson.
1116
1117         [Gtk] WebKitGtk+ doesn't build on Mac OS X 10.6
1118         https://bugs.webkit.org/show_bug.cgi?id=50867
1119
1120         Fixed library extention for Mac in webkitdirs.pm and type conflict in
1121         TestNetscapePlugin.cpp 
1122
1123         * GNUmakefile.am: Don't use AppKit when compiling TestNetscapePlugin for GTK+
1124         * Scripts/webkitdirs.pm:
1125
1126 2011-01-12  Mikhail Naganov  <mnaganov@chromium.org>
1127
1128         Reviewed by Pavel Feldman.
1129
1130         Add check-inspector-strings script.
1131
1132         https://bugs.webkit.org/show_bug.cgi?id=52295
1133
1134         * Scripts/check-inspector-strings: Added.
1135
1136 2011-01-12  Adam Roben  <aroben@apple.com>
1137
1138         Advertise the .testnetscape file extension on Windows
1139
1140         Fixes <http://webkit.org/b/52298>
1141         plugins/no-mime-with-valid-extension.html fails on Windows
1142
1143         Reviewed by Dan Bernstein.
1144
1145         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Added a
1146         FileExtents field to map the .testnetscape file extension to the
1147         application/x-webkit-test-netscape MIME type, just as we do on Mac.
1148
1149 2011-01-12  Adam Barth  <abarth@webkit.org>
1150
1151         Reviewed by Eric Seidel.
1152
1153         Make webkit-patch support subdirectories for SVN checkouts
1154         https://bugs.webkit.org/show_bug.cgi?id=52261
1155
1156         os.relpath does not exist on Python 2.5, so we need to call our version
1157         of the API.
1158
1159         * Scripts/webkitpy/common/checkout/scm.py:
1160
1161 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
1162
1163         Reviewed by Eric Seidel.
1164
1165         Close additional pages opened during a test once the test completes.
1166         https://bugs.webkit.org/show_bug.cgi?id=52276
1167
1168         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1169         (WTR::InjectedBundle::done):
1170
1171 2011-01-11  David Levin  <levin@chromium.org>
1172
1173         Reviewed by Eric Seidel.
1174
1175         Errors should be separated from the command line in bot messages.
1176         https://bugs.webkit.org/show_bug.cgi?id=52275
1177
1178         * Scripts/webkitpy/common/system/executive.py:
1179         (ScriptError.message_with_output): Added a newline to separate the command
1180         line from the errors.
1181         * Scripts/webkitpy/common/system/executive_unittest.py:
1182         (ScriptErrorTest.test_message_with_output): Added tests for the various code
1183         paths in message_with_output.
1184
1185 2011-01-11  Eric Seidel  <eric@webkit.org>
1186
1187         Unreviewed.
1188
1189         commit-queue should know how to upload archived results (for test flakes or general failures)
1190         https://bugs.webkit.org/show_bug.cgi?id=52048
1191
1192         The zips are mostly empty due to forgetting -r.
1193         Expected diffs were not being pulled from the archive due
1194         to the archive having longer paths than I realized.
1195
1196         * Scripts/webkitpy/common/system/workspace.py:
1197         * Scripts/webkitpy/common/system/workspace_unittest.py:
1198         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1199         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1200
1201 2011-01-11  Dirk Pranke  <dpranke@chromium.org>
1202
1203         Reviewed by Ojan Vafai.
1204
1205         The current modifier parsing code in test_expectations is
1206         fragile and hard-coded, so it's not easy to understand the logic
1207         or easily add new types of modifiers (like GPU vs. CPU testing
1208         for graphics tests, or 32-bit vs. 64-bit differences).
1209
1210         This is the first of two patches that will add in more generic
1211         support and then eliminate the GPU-specific test expectations
1212         files for Chromium.
1213
1214         This patch adds two standalone objects for handling modifiers. The
1215         rules for interpreting modifiers, precedence, and conflicts are
1216         given in the docstring to the ModifierMatcher class, which
1217         returns ModifierMatchResult objects.
1218         
1219         This patch also adds routines to the Port interface and a
1220         default set of values in the base object, in order to obtain the
1221         values needed on a given test run. These values are then passed
1222         to the expectation parser. This also allows us to clean up the
1223         logic used to lint all of the different configurations in a
1224         single test_expectations.txt file.
1225
1226         The next patch will merge in the separate GPU expectations file.
1227
1228         https://bugs.webkit.org/show_bug.cgi?id=51222
1229
1230         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1231         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1232         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
1233         * Scripts/webkitpy/layout_tests/port/base.py:
1234         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1235         * Scripts/webkitpy/layout_tests/port/chromium.py:
1236         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1237         * Scripts/webkitpy/layout_tests/port/test.py:
1238         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1239         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1240
1241 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
1242
1243         Reviewed by Adam Barth.
1244
1245         Make webkit-patch support subdirectories for SVN checkouts
1246         https://bugs.webkit.org/show_bug.cgi?id=52261
1247
1248         * Scripts/webkitpy/common/checkout/scm.py:
1249         * Scripts/webkitpy/style_references.py:
1250         * Scripts/webkitpy/tool/main.py:
1251         * Scripts/webkitpy/tool/steps/preparechangelog.py:
1252
1253 2011-01-11  Eric Seidel  <eric@webkit.org>
1254
1255         Unreviewed.
1256
1257         commit-queue should know how to upload archived results (for test flakes or general failures)
1258         https://bugs.webkit.org/show_bug.cgi?id=52048
1259
1260         I changed the API for archive_last_layout_test_results w/o updating the implementation.  Oops.
1261         This fixes an exception seen on the commit-queue when attempting to report flaky tests.
1262
1263         * Scripts/webkitpy/common/system/workspace.py:
1264         * Scripts/webkitpy/common/system/workspace_unittest.py:
1265         * Scripts/webkitpy/tool/commands/queues.py:
1266
1267 2011-01-11  Sam Weinig  <sam@webkit.org>
1268
1269         Roll r75474 back in.
1270
1271 2011-01-11  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
1272
1273         Reviewed by Kenneth Rohde Christiansen.
1274
1275         [Qt] Remove uses of QFuture since it isn't supported on all platforms.
1276         https://bugs.webkit.org/show_bug.cgi?id=51204
1277
1278         * QtTestBrowser/webpage.h:
1279         (QtNAMThread::QtNAMThread):
1280         (QtNAMThread::networkAccessManager):
1281         (QtNAMThread::run):
1282
1283 2011-01-11  Peter Varga  <pvarga@webkit.org>
1284
1285         Unreviewed.
1286
1287         Add myself to committers' list.
1288
1289         * Scripts/webkitpy/common/config/committers.py:
1290
1291 2011-01-11  Eric Seidel  <eric@webkit.org>
1292
1293         Reviewed by Adam Barth.
1294
1295         commit-queue should know how to upload archived results (for test flakes or general failures)
1296         https://bugs.webkit.org/show_bug.cgi?id=52048
1297
1298         Now the queue will always upload results.  Either the entire zip, or just
1299         the diffs.txt in the case of text failures.
1300
1301         This should make understanding flakes much easier, and paves the way
1302         for having the EWS run layout tests (and upload failures).
1303
1304         In order to upload .zip files I had to teach bugzilla.py to autodetect
1305         mime types from the filename.  Since mimetypes.py doesn't include a mapping
1306         for .patch files, I have it add one before calling guess_type.
1307
1308         We may find that always uploading the whole zip instead of just the -diffs.txt
1309         file is preferable, but for now I'm keeping the old behavior because it makes
1310         quickly understanding text failures easy.
1311
1312         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1313         * Scripts/webkitpy/common/system/workspace.py: Added.
1314         * Scripts/webkitpy/common/system/workspace_unittest.py: Added.
1315         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1316         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1317         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1318         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1319         * Scripts/webkitpy/tool/commands/queues.py:
1320         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1321
1322 2011-01-10  Sheriff Bot  <webkit.review.bot@gmail.com>
1323
1324         Unreviewed, rolling out r75464.
1325         http://trac.webkit.org/changeset/75464
1326         https://bugs.webkit.org/show_bug.cgi?id=52193
1327
1328         Followup rollout for 75474 (Requested by Ossy on #webkit).
1329
1330         * MiniBrowser/mac/BrowserWindowController.m:
1331         (-[BrowserWindowController awakeFromNib]):
1332         * MiniBrowser/win/BrowserView.cpp:
1333         (BrowserView::create):
1334         * WebKitTestRunner/TestController.cpp:
1335         (WTR::createOtherPage):
1336         (WTR::TestController::initialize):
1337
1338 2011-01-10  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1339
1340         Reviewed by Csaba Osztrogonác.
1341
1342         [Qt] Baseline qt_minimal configuration
1343         https://bugs.webkit.org/show_bug.cgi?id=51313
1344
1345         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1346         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): Add
1347         QT_NO_UNDOSTACK guard.
1348
1349         * QtTestBrowser/launcherwindow.cpp:
1350         (LauncherWindow::createChrome): Add QT_NO_SHORTCUT and QT_NO_PRINTER
1351         guards.
1352         (LauncherWindow::applyZoom): Add QT_NO_ANIMATION guard.
1353         (LauncherWindow::screenshot): Add QT_NO_FILEDIALOG guard.
1354         (LauncherWindow::selectElements): Add QT_NO_INPUTDIALOG guard.
1355         (LauncherWindow::showUserAgentDialog): Add QT_NO_COMBOBOX guard.
1356
1357         * QtTestBrowser/launcherwindow.h:
1358         * QtTestBrowser/locationedit.cpp: Add QT_NO_INPUTDIALOG guard.
1359         * QtTestBrowser/locationedit.h: Ditto.
1360
1361         * QtTestBrowser/mainwindow.cpp:
1362         (MainWindow::buildUI): Add QT_NO_INPUTDIALOG, QT_NO_SHORTCUT and
1363         QT_NO_UNDOSTACK guards.
1364         (MainWindow::setAddressUrl): Add QT_NO_INPUTDIALOG guard.
1365         (MainWindow::changeLocation): Ditto.
1366         (MainWindow::openFile): Add QT_NO_FILEDIALOG guard.
1367         (MainWindow::openLocation): Add QT_NO_INPUTDIALOG guard.
1368
1369         * QtTestBrowser/webpage.cpp:
1370         (WebPage::openUrlInDefaultBrowser): Add QT_NO_DESKTOPSERVICES guard.
1371         (WebPage::authenticationRequired): Add QT_NO_LINEEDIT guard.
1372
1373         * QtTestBrowser/webview.cpp:
1374         (WebViewGraphicsBased::animatedFlip): Add QT_NO_ANIMATION guard.
1375         (WebViewGraphicsBased::animatedYFlip): Ditto.
1376
1377 2011-01-10  Sam Weinig  <sam@webkit.org>
1378
1379         Fix build.
1380
1381         * MiniBrowser/mac/BrowserWindowController.m:
1382         (-[BrowserWindowController awakeFromNib]):
1383         * MiniBrowser/win/BrowserView.cpp:
1384         (BrowserView::create):
1385         * WebKitTestRunner/TestController.cpp:
1386         (WTR::createOtherPage):
1387         (WTR::TestController::initialize):
1388
1389 2011-01-10  Eric Seidel  <eric@webkit.org>
1390
1391         Reviewed by Ojan Vafai.
1392
1393         style-queue messages are way too long for big patches
1394         https://bugs.webkit.org/show_bug.cgi?id=52161
1395
1396         We definitely could build much fancier list-to-string-with-limit functions
1397         but this should be sufficient for our needs at the moment.
1398
1399         * Scripts/webkitpy/common/system/executive.py:
1400         * Scripts/webkitpy/common/system/executive_unittest.py:
1401
1402 2011-01-10  Tony Chang  <tony@chromium.org>
1403
1404         Unreviewed, rolling out r75398.
1405         http://trac.webkit.org/changeset/75398
1406         https://bugs.webkit.org/show_bug.cgi?id=52008
1407
1408         Some layout tests are crashing on Chromium Win.
1409
1410         * DumpRenderTree/chromium/WebViewHost.cpp:
1411         (WebViewHost::updatePaintRect):
1412         * DumpRenderTree/chromium/WebViewHost.h:
1413
1414 2011-01-10  Adam Roben  <aroben@apple.com>
1415
1416         Roll out r75392
1417
1418         It isn't needed now that r75289 has been rolled out.
1419
1420         * Scripts/run-javascriptcore-tests:
1421
1422 2011-01-10  Maciej Stachowiak  <mjs@apple.com>
1423
1424         Reviewed by Anders Carlsson.
1425
1426         WebKitTestRunner uses crazy amounts of CPU, making layout tests slow and flaky
1427         https://bugs.webkit.org/show_bug.cgi?id=52160
1428
1429         * WebKitTestRunner/mac/TestControllerMac.mm:
1430         (WTR::TestController::platformRunUntil): Instead of busy-looping, wait for the timeout.
1431         Anything that can make runUntil() conditions turn true will happen on a run loop cycle
1432         anyway.
1433
1434 2011-01-10  Tony Chang  <tony@chromium.org>
1435
1436         Reviewed by Mihai Parparita.
1437
1438         [chromium] fix for animated gif layout tests
1439         https://bugs.webkit.org/show_bug.cgi?id=52008
1440
1441         * DumpRenderTree/chromium/WebViewHost.cpp: Schedule a paint when we update the paint rect
1442             to trigger gif animations.
1443         (WebViewHostPaintTask::WebViewHostPaintTask):
1444         (WebViewHostPaintTask::runIfValid):
1445         (WebViewHost::updatePaintRect):
1446         * DumpRenderTree/chromium/WebViewHost.h:
1447         (WebViewHost::taskList):
1448
1449 2011-01-10  Alejandro G. Castro  <alex@igalia.com>
1450
1451         Reviewed by Xan Lopez.
1452
1453         [GTK] Fix gtk2 compilation for master
1454         https://bugs.webkit.org/show_bug.cgi?id=51885
1455
1456         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
1457         (createBitmapContextFromWebView): Replaced the old
1458         gdk_drawable_get_size with gdk_pixmap_get_size.
1459
1460 2011-01-10  Patrick Gansterer  <paroga@webkit.org>
1461
1462         Reviewed by Laszlo Gombos.
1463
1464         [WINCE] Reenable NPAPI after r75203
1465         https://bugs.webkit.org/show_bug.cgi?id=52109
1466
1467         Remove the !isWinCE() check for ENABLE_NETSCAPE_PLUGIN_API and replace
1468         it with !isEfl(), because EFL port does not support NPAPI (yet).
1469
1470         * Scripts/build-webkit:
1471
1472 2011-01-10  Adam Roben  <aroben@apple.com>
1473
1474         Skip some asserting JS tests
1475
1476         See <http://webkit.org/b/52156>.
1477
1478         * Scripts/run-javascriptcore-tests:
1479
1480 2011-01-10  Martin Robinson  <mrobinson@igalia.com>
1481
1482         Reviewed by Xan Lopez.
1483
1484         [GTK] build-webkit disable Blob support via arguments passed to automake
1485         https://bugs.webkit.org/show_bug.cgi?id=52097
1486
1487         * Scripts/build-webkit: Enable Blob support when building WebKitGTK+ via
1488         build-webkit.
1489
1490 2011-01-10  Adam Roben  <aroben@apple.com>
1491
1492         Use the same name and description for TestNetscapePlugin on Windows and
1493         Mac
1494
1495         Fixes <http://webkit.org/b/52151>
1496         fast/frames/iframe-reparenting-plugins.html fails on Windows
1497
1498         Reviewed by Steve Falkenburg.
1499
1500         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Copied
1501         the name and description from Mac's Info.plist.
1502
1503 2011-01-10  Siddharth Mathur <siddharth.mathur@nokia.com>
1504
1505         Reviewed by Laszlo Gombos.
1506
1507         [Qt][WK2] Guard gcc-specific syntax
1508
1509         Non-gcc based compliers choke on the "-include"
1510         syntax for preinclude, place guard around it.
1511
1512         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1513         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1514
1515 2011-01-10  Andreas Kling  <kling@webkit.org>
1516
1517         Reviewed by Simon Hausmann.
1518
1519         [Qt] [WK2] MiniBrowser does not load pages opened in new windows
1520         https://bugs.webkit.org/show_bug.cgi?id=52111
1521
1522         When getting a createNewPage() callback from QWKPage, create the
1523         new page with the same QWKContext as the page that is passed to
1524         the callback.
1525
1526         * MiniBrowser/qt/BrowserView.h:
1527         * MiniBrowser/qt/BrowserWindow.cpp:
1528         (newPageFunction):
1529         (BrowserWindow::BrowserWindow):
1530         * MiniBrowser/qt/BrowserWindow.h:
1531
1532 2011-01-10  Andreas Kling  <kling@webkit.org>
1533
1534         Reviewed by Kenneth Rohde Christiansen.
1535
1536         [Qt] MiniBrowser: Remove superfluous createNewPage() callback
1537
1538         BrowserView set its own useless createNewPage() callback on QWKPage.
1539         This was immediately overridden by BrowserWindow anyway, so remove
1540         the BrowserView one.
1541
1542         * MiniBrowser/qt/BrowserView.cpp:
1543         (BrowserView::BrowserView):
1544
1545 2011-01-10  John Knottenbelt  <jknotten@chromium.org>
1546
1547         Reviewed by Jeremy Orlow.
1548
1549         [Chromium] Remove non-client-based Geolocation code
1550         https://bugs.webkit.org/show_bug.cgi?id=50921
1551
1552         * DumpRenderTree/chromium/LayoutTestController.cpp:
1553         (LayoutTestController::setGeolocationPermission):
1554         (LayoutTestController::setMockGeolocationPosition):
1555         (LayoutTestController::setMockGeolocationError):
1556         * DumpRenderTree/chromium/WebViewHost.cpp:
1557         (WebViewHost::geolocationClientMock):
1558         (WebViewHost::reset):
1559         * DumpRenderTree/chromium/WebViewHost.h:
1560
1561 2011-01-10  Eric Seidel  <eric@webkit.org>
1562
1563         Reviewed by Adam Barth.
1564
1565         Commit bot tried to land r? cq+ patch
1566         https://bugs.webkit.org/show_bug.cgi?id=36638
1567
1568         It should now be possible to post a patch with r? and cq+ and the
1569         commit-queue will correctly wait for the r+ before attempting to land the patch.
1570         (This was a feature requested by several users.)
1571
1572         One caveat: We don't actually reject r-, cq+ patches from the queue
1573         (we just ignore them), but I think that's OK for now.
1574
1575         I also noticed that setting r- once a commit-queue node had grabbed
1576         a patch would not properly cancel the landing.  That's fixed and
1577         tested in this patch.
1578
1579         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1580         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1581         * Scripts/webkitpy/tool/bot/feeders.py:
1582         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
1583
1584 2011-01-08  Benjamin Poulain  <benjamin.poulain@nokia.com>
1585
1586         Reviewed by Kenneth Rohde Christiansen.
1587
1588         [Qt] QtWebKit crashes when using XMLHttpRequest from the unload event
1589         https://bugs.webkit.org/show_bug.cgi?id=51934
1590
1591         When accessing the network from the destructor of QWebPage, the network access manager
1592         was already deleted because the object WebPage was already destructed.
1593
1594         This solve the problem by linking the lifetime of the network access manager to WebPage's QObject.
1595         The object is now destructed in the destructor of QObject.
1596
1597         * QtTestBrowser/webpage.cpp:
1598         (WebPage::WebPage):
1599         (WebPage::setQnamThreaded):
1600         * QtTestBrowser/webpage.h:
1601         (QtNAMThread::QtNAMThread):
1602
1603 2011-01-08  Eric Seidel  <eric@webkit.org>
1604
1605         Reviewed by Ojan Vafai.
1606
1607         test_failures.py should not mention TestShell (long live DumpRenderTree!)
1608         https://bugs.webkit.org/show_bug.cgi?id=52067
1609
1610         I ran test-webkitpy, but didn't bother adding a unit test for this string change.
1611         https://bugs.webkit.org/show_bug.cgi?id=51138#c3 is an example of why this is needed.
1612
1613         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1614
1615 2011-01-08  Eric Seidel  <eric@webkit.org>
1616
1617         Reviewed by Mihai Parparita.
1618
1619         commit-queue hangs when the ChangeLog diff is bad
1620         https://bugs.webkit.org/show_bug.cgi?id=52072
1621
1622         * Scripts/webkitpy/tool/steps/validatechangelogs.py:
1623         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
1624
1625 2011-01-08  Adam Barth  <abarth@webkit.org>
1626
1627         Teach svn-apply how to re-write WebCore to Source/WebCore.
1628
1629         * Scripts/VCSUtils.pm:
1630
1631 2011-01-07  Adam Barth  <abarth@webkit.org>
1632
1633         Rubber-stamped by Eric Seidel.
1634
1635         Move WebCore to Source
1636         https://bugs.webkit.org/show_bug.cgi?id=52050
1637
1638         Update the tools to understand WebCore's new location.
1639
1640         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1641         * DumpRenderTree/wscript:
1642         * GNUmakefile.am:
1643         * Scripts/build-webkit:
1644         * Scripts/do-file-rename:
1645         * Scripts/do-webcore-rename:
1646         * Scripts/generate-qt-inspector-resource:
1647         * Scripts/prepare-ChangeLog:
1648         * Scripts/run-bindings-tests:
1649         * Scripts/update-iexploder-cssproperties:
1650         * Scripts/update-sources-list.py:
1651         * Scripts/update-webkit-localizable-strings:
1652         * Scripts/webkitdirs.pm:
1653         * Scripts/webkitpy/common/config/build.py:
1654         * Scripts/webkitpy/common/config/build_unittest.py:
1655         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
1656         * Scripts/webkitpy/style/checker.py:
1657         * Scripts/webkitpy/style/checker_unittest.py:
1658         * WebKitTestRunner/DerivedSources.pro:
1659         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1660         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh:
1661         * wx/browser/wscript:
1662         * wx/build/settings.py:
1663
1664 2011-01-07  Maciej Stachowiak  <mjs@apple.com>
1665
1666         Reviewed by Sam Weinig.
1667
1668         Make WebKitTestRunner rest between loads more robust to avoid test crashes
1669         https://bugs.webkit.org/show_bug.cgi?id=52086
1670
1671         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1672         (WTR::InjectedBundle::didReceiveMessage):
1673         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1674         (WTR::LayoutTestController::notifyDone):
1675         * WebKitTestRunner/TestController.cpp:
1676         (WTR::TestController::resetStateToConsistentValues):
1677         (WTR::TestController::run):
1678
1679 2011-01-07  James Robinson  <jamesr@chromium.org>
1680
1681         Revert "Implement mozilla's animationTime property"
1682         https://bugs.webkit.org/show_bug.cgi?id=51952
1683
1684         This approach isn't quite right.
1685
1686         * DumpRenderTree/chromium/WebViewHost.cpp:
1687         (WebViewHost::paintInvalidatedRegion):
1688
1689 2011-01-07  Adam Roben  <aroben@apple.com>
1690
1691         Build master fix
1692
1693         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1694         (RunWebKitTests.start): Don't try to concatenate a list and a string.
1695
1696 2011-01-07  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>
1697
1698         Reviewed by Csaba Osztrogonác.
1699
1700         run-qtwebkit-tests should be able to kill a testsuite.
1701
1702         Add new option in the script that can setup a timeout for a test.
1703         If the test execution takes more then specified time then the test
1704         would be terminated.
1705
1706         [Qt] run-qtwebkit-tests needs timeout
1707         https://bugs.webkit.org/show_bug.cgi?id=51894
1708
1709         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1710         * Scripts/run-qtwebkit-tests:
1711
1712 2011-01-07  Csaba Osztrogonác  <ossy@webkit.org>
1713
1714         Unreviewed fix after r75233.
1715
1716         Based on idea from Eric Seidel.
1717
1718         Add remote zip file handling to webkitpy.
1719         https://bugs.webkit.org/show_bug.cgi?id=50901
1720
1721         * Scripts/webkitpy/common/system/fileset.py: Make python 2.5 happy.
1722
1723 2011-01-07  Shane Stephens  <shanestephens@google.com>
1724
1725         Reviewed by Eric Seidel.
1726
1727         svn-apply: should support git binary delta diffs
1728         https://bugs.webkit.org/show_bug.cgi?id=38864
1729
1730         * Scripts/VCSUtils.pm:
1731         * Scripts/svn-apply:
1732
1733 2011-01-06  Julie Parent  <jparent@chromium.org>
1734
1735         Reviewed by Eric Seidel.
1736
1737         Test Result Server not removing old results.
1738         https://bugs.webkit.org/show_bug.cgi?id=52012
1739
1740         * TestResultServer/model/jsonresults.py:
1741         Fix off-by-one: Truncate if >= num_runs, not just >.
1742         * TestResultServer/model/jsonresults_unittest.py:
1743         Add unit test to test that merging in a new result with the same value
1744         as the last result causes previous result to fall off.
1745
1746 2011-01-06  James Kozianski  <koz@chromium.org>
1747
1748         Reviewed by Mihai Parparita.
1749
1750         Add classes to provide a consistent interface to a set of files.
1751         https://bugs.webkit.org/show_bug.cgi?id=50901
1752
1753         These classes allow us to write code that is agnostic to whether a
1754         particular set of files resides in a local directory or in a zip file
1755         on a remote machine.
1756
1757         * Scripts/webkitpy/common/system/directoryfileset.py: Added.
1758         * Scripts/webkitpy/common/system/directoryfileset_unittest.py: Added.
1759         * Scripts/webkitpy/common/system/fileset.py: Added.
1760         * Scripts/webkitpy/common/system/filesystem.py:
1761         * Scripts/webkitpy/common/system/filesystem_mock.py:
1762         * Scripts/webkitpy/common/system/zipfileset.py: Added.
1763         * Scripts/webkitpy/common/system/zipfileset_unittest.py: Added.
1764
1765 2011-01-06  Eric Seidel  <eric@webkit.org>
1766
1767         Reviewed by Adam Barth.
1768
1769         NetworkTransaction should log the url it is retrying
1770         https://bugs.webkit.org/show_bug.cgi?id=52043
1771
1772         * Scripts/webkitpy/common/net/networktransaction.py:
1773         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
1774
1775 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
1776
1777         Windows build fix.
1778         Import os before using it.
1779
1780         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1781
1782 2011-01-06  Eric Seidel  <eric@webkit.org>
1783
1784         Reviewed by Adam Barth.
1785
1786         StyleQueue fails to report errors when patches have many files
1787         https://bugs.webkit.org/show_bug.cgi?id=52042
1788
1789         This is one of at least two errors preventing style error reporting at the moment.
1790         When we moved to passing the list of files to check explicitly,
1791         we started to exceed the 500 character TEXT field limit for our AppEngine model object.
1792         We could change the type of the QueueStatus.message type, or we could
1793         just teach statusserver.py how to clamp values (and warn when it does).
1794         I chose the latter path.
1795
1796         * Scripts/webkitpy/common/net/statusserver.py:
1797
1798 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
1799
1800         Reviewed by Stephanie Lewis.
1801         
1802         Fix syntax error in script.
1803
1804         Windows bots need to archive/unarchive builds to/from configuration-specific directories
1805         https://bugs.webkit.org/show_bug.cgi?id=51996
1806
1807         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1808
1809 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1810
1811         Unreviewed, fixing WinCE build after r75196.
1812
1813         WinCE port does not (yet) support NPAPI.
1814
1815         * Scripts/build-webkit:
1816
1817 2011-01-06  Xan Lopez  <xlopez@igalia.com>
1818
1819         Reviewed by Darin Adler.
1820
1821         File::Spec->rel2abs in sunspider-compare-results mangles parameters
1822         https://bugs.webkit.org/show_bug.cgi?id=52015
1823
1824         * Scripts/sunspider-compare-results: call rel2abs on our arguments
1825         after the platform has been detected, otherwise the script will
1826         mangle things like '--gtk' into '/a/path/--gtk', breaking the
1827         detection.
1828
1829 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1830
1831         Reviewed by Eric Seidel.
1832
1833         Add ENABLE_NETSCAPE_PLUGIN_API, ENABLE_ORIENTATION_EVENTS and ENABLE_TOUCH_EVENTS flags to build-webkit
1834         https://bugs.webkit.org/show_bug.cgi?id=51346
1835
1836         * Scripts/build-webkit:
1837
1838 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
1839
1840         Reviewed by Adam Roben.
1841
1842         Windows bots need to archive/unarchive builds to/from configuration-specific directories
1843         https://bugs.webkit.org/show_bug.cgi?id=51996
1844         
1845         After the configuration directory change, we were archiving the incorrect directory for
1846         build product, so we were running tests on the wrong binaries.
1847         
1848         This change archives the correct directory, and also unarchives it into a configuration-
1849         specific directory.
1850
1851         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Use a configuration-specific directory on Windows.
1852         * BuildSlaveSupport/built-product-archive: Unarchive/archive to/from proper directory.
1853
1854 2011-01-06  Eric Seidel  <eric@webkit.org>
1855
1856         Reviewed by Mihai Parparita.
1857
1858         commit-queue mentions "Text diff mismatch" 4 times instead of once per failure
1859         https://bugs.webkit.org/show_bug.cgi?id=52002
1860
1861         See an example of this here:
1862         https://bugs.webkit.org/show_bug.cgi?id=51314#c2
1863
1864         It's due to the fact that we pass around TestFailure() instance
1865         objects and yet expect them to all compare to be the same.
1866
1867         This is bad.  We should either have shared instances of these values
1868         or we should just pass around the class names.  There are already hacks
1869         in place to make TestFailure objects pass equality tests, I just added
1870         a __hash__ implementation so they can be used in sets as expected.
1871
1872         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1873         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1874
1875 2011-01-06  Evan Martin  <evan@chromium.org>
1876
1877         Reviewed by Tony Chang.
1878
1879         [gdb] handle inaccessible memory and UChar*
1880         https://bugs.webkit.org/show_bug.cgi?id=52003
1881
1882         To pretty-print a UChar*, we just grope around in the memory
1883         looking for a terminating NUL.  We need to handle the exception
1884         that can occur when we poke into an invalid location.
1885
1886         Additionally, the logic for choosing which pretty-printer would
1887         early return before hitting the point where we'd use the UChar*
1888         printer.  (Did this ever work?  How did it regress?)
1889
1890         * gdb/webkit.py:
1891
1892 2011-01-05  Brian Weinstein  <bweinstein@apple.com>
1893
1894         Reviewed by Ada Chan.
1895
1896         WebKit2: Should be able to call into injected bundle to ask if we should allow resource loads
1897         https://bugs.webkit.org/show_bug.cgi?id=51969
1898         
1899         Add shouldLoadResourceForFrame to WTR::InjectedBundlePage.
1900
1901         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1902         (WTR::InjectedBundlePage::InjectedBundlePage):
1903         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Stub implementation.
1904         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1905
1906 2011-01-06  James Robinson  <jamesr@chromium.org>
1907
1908         Reviewed by Simon Fraser.
1909
1910         Implement mozilla's animationTime property
1911         https://bugs.webkit.org/show_bug.cgi?id=51952
1912
1913         Chromium DRT support for webkitAnimationTime.
1914
1915         * DumpRenderTree/chromium/WebViewHost.cpp:
1916         (WebViewHost::paintInvalidatedRegion):
1917
1918 2011-01-06  Julie Parent  <jparent@chromium.org>
1919
1920         Reviewed by Tony Chang.
1921
1922         Test Result Server always truncates number of results to JSON_RESULTS_MAX_BUILDS
1923         https://bugs.webkit.org/show_bug.cgi?id=51217
1924
1925         * TestResultServer/model/jsonresults.py:
1926         Pass num_runs through to _remove_items_over_max_number_of_builds, and use the value.
1927         Adds missing documentation.
1928         * TestResultServer/model/jsonresults_unittest.py:
1929         Add unit test to test that truncation happens at smaller value than JSON_RESULTS_MAX_BUILDS.
1930         Update test_merge to take a number of builds to truncate at.
1931
1932 2011-01-06  Adam Barth  <abarth@webkit.org>
1933
1934         Reviewed by Eric Seidel.
1935
1936         The EWS should log outside of the working directory
1937         https://bugs.webkit.org/show_bug.cgi?id=51986
1938
1939         This patch prepare us for using git clean -x -d -f in the EWS wrapper
1940         script, which will actually clean the working copy back to a pristine
1941         state instead of leaving untracked directories and ignored files.
1942
1943         * Scripts/webkitpy/tool/commands/queues.py:
1944         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1945
1946 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
1947
1948         Windows build fix.
1949         Back out attempted change to built-product-archive.
1950
1951         * BuildSlaveSupport/built-product-archive:
1952
1953 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
1954
1955         Windows build fix.
1956         Include configuration name when unpacking a build archive.
1957
1958         Needed, since we split Windows build results into configuration-specific directories
1959         under WebKitOutputDir.
1960
1961         * BuildSlaveSupport/built-product-archive:
1962
1963 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
1964
1965         Reviewed by Darin Adler.
1966
1967         Debug and Release builds on Windows clobber each other
1968         https://bugs.webkit.org/show_bug.cgi?id=49185
1969
1970         Changes the structure of WebKitBuild build products directory so we
1971         completely separate each build configuration into independent directories.
1972         
1973         Although we previously had per-configuration directories for obj, this change adds
1974         per-configuration directories for bin, lib, obj, and include. Each configuration's
1975         build products are stored within a directory inside of WebKitBuild.
1976         
1977         Most use of $(WebKitOutputDir) in the build files has been replaced by $(ConfigurationBuildDir),
1978         defined in common.vsprops to be $(WebKitOutputDir)\$(ConfigurationName).
1979
1980         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops:
1981         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd:
1982         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd:
1983         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
1984         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd:
1985         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd:
1986         * DumpRenderTree/win/ImageDiffCommon.vsprops:
1987         * DumpRenderTree/win/ImageDiffPostBuild.cmd:
1988         * DumpRenderTree/win/ImageDiffPreBuild.cmd:
1989         * FindSafari/FindSafari.vcproj:
1990         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
1991         * MiniBrowser/MiniBrowserPostBuild.cmd:
1992         * MiniBrowser/MiniBrowserPreBuild.cmd:
1993         * Scripts/webkitdirs.pm:
1994         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
1995         * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops:
1996         * TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd:
1997         * TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd:
1998         * TestWebKitAPI/win/copy-resources.cmd:
1999         * WebKitAPITest/WebKitAPITestCommon.vsprops:
2000         * WebKitAPITest/WebKitAPITestPostBuild.cmd:
2001         * WebKitAPITest/WebKitAPITestPreBuild.cmd:
2002         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
2003         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
2004         * WebKitTestRunner/win/InjectedBundle.vcproj:
2005         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops:
2006         * WebKitTestRunner/win/InjectedBundlePostBuild.cmd:
2007         * WebKitTestRunner/win/InjectedBundlePreBuild.cmd:
2008         * WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd:
2009         * WebKitTestRunner/win/WebKitTestRunnerPreBuild.cmd:
2010         * WinLauncher/WinLauncherCommon.vsprops:
2011         * WinLauncher/WinLauncherPostBuild.cmd:
2012         * WinLauncher/WinLauncherPreBuild.cmd:
2013
2014 2011-01-05  Jan Erik Hanssen  <jhanssen@sencha.com>
2015
2016         Reviewed by Ariya Hidayat.
2017
2018         [Qt] TestNetscapePlugin doesn't link on OS X
2019         https://bugs.webkit.org/show_bug.cgi?id=51948
2020
2021         Only add a dependency on libX11 on X11 systems
2022
2023         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2024
2025 2011-01-05  Jeff Miller  <jeffm@apple.com>
2026
2027         Reviewed by Adam Roben.
2028
2029         check-webkit-style should allow unnecessary parameter names in WebKit2 APIs because we're matching CF's header style
2030         https://bugs.webkit.org/show_bug.cgi?id=51970
2031
2032         * Scripts/webkitpy/style/checker.py:
2033         Add -readability/naming for WebKit2 C API directories.
2034
2035 2011-01-05  Eric Seidel  <eric@webkit.org>
2036
2037         Unreviewed, just fixing one more log error from my previous python patch.
2038
2039         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
2040         https://bugs.webkit.org/show_bug.cgi?id=51802
2041
2042         webkit-patch failure-reason was logging about parsing errors
2043         due to my misunderstanding of how BeautifulSoup.findAll worked.
2044
2045         Fixed, and added a unit test.
2046
2047         * Scripts/webkitpy/common/net/layouttestresults.py:
2048         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2049
2050 2011-01-05  Benjamin Poulain  <benjamin.poulain@nokia.com>
2051
2052         Reviewed by Kenneth Rohde Christiansen.
2053
2054         [Qt] [WK2] Add the possibility to open window from the WebProcess in Minibrowser
2055         https://bugs.webkit.org/show_bug.cgi?id=51951
2056
2057         Set a function to QWKPage::setCreateNewPageFunction() in Minibrowser so there is a way
2058         to create new window from WebKit.
2059
2060         * MiniBrowser/qt/BrowserWindow.cpp:
2061         (newPageFunction):
2062         (BrowserWindow::BrowserWindow):
2063         (BrowserWindow::page): Added to avoid the indirect access to QWKPage spread in the class
2064         (BrowserWindow::newWindow):
2065         (BrowserWindow::updateUserAgentList):
2066         (BrowserWindow::showUserAgentDialog):
2067         * MiniBrowser/qt/BrowserWindow.h: Add the global variable backingStoreTypeForNewWindow to
2068         define the type of the backing store used for new windows.
2069         * MiniBrowser/qt/main.cpp:
2070         (main):
2071
2072 2011-01-05  Eric Seidel  <eric@webkit.org>
2073
2074         Reviewed by Ojan Vafai.
2075
2076         commit-queue should report failure type when reporting flaky tests
2077         https://bugs.webkit.org/show_bug.cgi?id=51900
2078
2079         This patch was a ridiculous amount of plumbing.  In the end I like
2080         the NRWT-style TestResult class even less.  But now we're passing
2081         a list of TestResult objects from the queue to the FlakyTestReporter.
2082         Thus the FlakyTestReporter can more easily report what type of failure
2083         occurred.
2084
2085         In the process, I found that I was not alone in finding TestResult
2086         cumbersome to use.  A bunch of code was trying to create a TestResult
2087         object with default values.  However since the constructor didn't make
2088         this easy, some places were getting it wrong (including the TestResult unit test)!
2089         I've fixed the TestResult constructor to have default values for non-essential
2090         arguments.
2091
2092         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2093         * Scripts/webkitpy/common/net/layouttestresults.py:
2094         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2095         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2096         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2097         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2098         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
2099         * Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py:
2100         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2101         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2102         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2103         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2104         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2105         * Scripts/webkitpy/tool/commands/queues.py:
2106         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2107
2108 2011-01-05  Eric Seidel  <eric@webkit.org>
2109
2110         Unreviewed.
2111
2112         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
2113         https://bugs.webkit.org/show_bug.cgi?id=51802
2114
2115         Add another unit test to cover a previously missing import.
2116
2117         * Scripts/webkitpy/common/net/layouttestresults.py:
2118         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2119
2120 2011-01-05  Mihai Parparita  <mihaip@chromium.org>
2121
2122         Reviewed by David Levin.
2123
2124         Add mihaip@chromium.org as a reviewer
2125         https://bugs.webkit.org/show_bug.cgi?id=51966
2126         
2127         Add myself as a reviewer.
2128
2129         * Scripts/webkitpy/common/config/committers.py:
2130
2131 2011-01-05  James Simonsen  <simonjam@chromium.org>
2132
2133         Unreviewed. Adding myself to the list of committers.
2134
2135         * Scripts/webkitpy/common/config/committers.py:
2136
2137 2011-01-05  Eric Seidel  <eric@webkit.org>
2138
2139         Unreviewed.
2140
2141         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
2142         https://bugs.webkit.org/show_bug.cgi?id=51802
2143
2144         Fix two exceptions seen on the bots after my original commit.
2145
2146         * Scripts/webkitpy/common/net/layouttestresults.py:
2147         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2148
2149 2011-01-05  Kundu Suchismita  <suchi.kundu@nokia.com>
2150
2151         Reviewed by Andreas Kling.
2152
2153         [Qt]Add local storage settings to QtTestBrowser command line arguments 
2154         https://bugs.webkit.org/show_bug.cgi?id=51750
2155
2156         * QtTestBrowser/main.cpp:
2157         (LauncherApplication::handleUserOptions):
2158          Local storage settings can be enable form command line arguments for
2159          QtTestBrowser.
2160
2161 2011-01-05  Chris Fleizach  <cfleizach@apple.com>
2162
2163         Reviewed by Martin Robinson.
2164
2165         GTK: AX: DRT needs to use correct root object method.
2166         https://bugs.webkit.org/show_bug.cgi?id=51911
2167
2168         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
2169         (AccessibilityController::rootElement):
2170
2171 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
2172
2173         Rubber-stamped by Csaba Osztrogonác.
2174
2175         Based on idea from Péter Gál.
2176
2177         * Scripts/webkitpy/tool/bot/sheriff.py: Remove unnecessary apostrophes around revision numbers.
2178
2179 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
2180
2181         Reviewed by Adam Barth.
2182
2183         sheriff-bot should be able to do multi-revision rollouts
2184         https://bugs.webkit.org/show_bug.cgi?id=51176
2185
2186         * Scripts/webkitpy/tool/bot/irc_command.py:
2187         * Scripts/webkitpy/tool/bot/sheriff.py:
2188         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
2189
2190 2011-01-05  Eric Seidel  <eric@webkit.org>
2191
2192         Reviewed by Adam Barth.
2193
2194         queues.webkit.org should have per-bot status pages
2195         https://bugs.webkit.org/show_bug.cgi?id=51906
2196
2197         Just adds a /queue-status/QUEUE_NAME/bots/BOT_ID page to show
2198         statuses from a single queue.  Now that we have many bots servicing
2199         some queues (commit-queue, win-ews, etc.) its easy to have the messages
2200         you care about scroll off the end of the 15-message limit on the main page.
2201
2202         Eventually we should probably rename /queue-status to /queue or /queues,
2203         but that's fodder for another patch.
2204
2205         * QueueStatusServer/handlers/queuestatus.py:
2206         * QueueStatusServer/index.yaml:
2207         * QueueStatusServer/main.py:
2208         * QueueStatusServer/templates/includes/singlequeuestatus.html:
2209          - This probably should use a custom filter instead of hard-coding
2210            the URL scheme here, but I couldn't figure out how to easily
2211            create such a filter.  Most filters work with "strings" so we can't
2212            pass the status object.  We could add a method to the status
2213            object and call that, but that seemed a bit strange too.
2214         * QueueStatusServer/templates/queuestatus.html:
2215
2216 2011-01-05  Carlos Garcia Campos  <cgarcia@igalia.com>
2217
2218         Unreviewed. Adding myself to the list of committers.
2219
2220         * Scripts/webkitpy/common/config/committers.py:
2221
2222 2011-01-04  Koan-Sin Tan  <koansin.tan@gmail.com>
2223
2224         Reviewed by David Levin.
2225
2226         check-webkit-style treated some macros with parentheses after #elif as function calls
2227         https://bugs.webkit.org/show_bug.cgi?id=51695
2228
2229         Ingore function call space checking in any preprocessor directives
2230         (things starting with #). Change search() to match() because 
2231         preprocessor directives are supposed to be in the beginning of lines.
2232
2233         * Scripts/webkitpy/style/checkers/cpp.py:
2234         * Scripts/webkitpy/style/checkers/cpp_unittest.py: make sure there is no false positives for #elif cases
2235
2236 2011-01-04  Søren Gjesse  <sgjesse@chromium.org>
2237
2238         Reviewed by Tony Chang.
2239
2240         Change the --multi-load test option to --stress-opt
2241         https://bugs.webkit.org/show_bug.cgi?id=50751
2242
2243         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2244         (runTest):
2245         (main):
2246         * DumpRenderTree/chromium/TestShell.cpp:
2247         (TestShell::TestShell):
2248         * DumpRenderTree/chromium/TestShell.h:
2249         (TestShell::stressOpt):
2250         (TestShell::setStressOpt):
2251         (TestShell::stressDeopt):
2252         (TestShell::setStressDeopt):
2253         (TestShell::javaScriptFlags):
2254         (TestShell::setJavaScriptFlags):
2255         * Scripts/webkitpy/layout_tests/port/chromium.py:
2256         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2257
2258 2011-01-04  Chris Fleizach  <cfleizach@apple.com>
2259
2260         Reviewed by Sam Weinig.
2261
2262         WK2: Support Accessibility
2263         https://bugs.webkit.org/show_bug.cgi?id=51859
2264
2265         Use rootObject() method to get top of accessibility tree.
2266
2267         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
2268         (AccessibilityController::focusedElement):
2269         (AccessibilityController::rootElement):
2270
2271 2011-01-03  Martin Robinson  <mrobinson@igalia.com>
2272
2273         Reviewed by Darin Adler.
2274
2275         Remove the last non-GObject usage of PlatformRefPtr and move the code to GRefPtr
2276         https://bugs.webkit.org/show_bug.cgi?id=51846
2277
2278         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: Change usage of PlatformRefPtr
2279         back to GRefPtr.
2280
2281 2011-01-04  Zhe Su  <suzhe@chromium.org>
2282
2283         Reviewed by Kenneth Russell.
2284
2285         Fix insertText, setMarkedText and unmarkText methods of
2286         TextInputController to call corresponding methods of WebKit::WebView
2287         rather than WebKit::WebFrame. This change matches the behavior of
2288         chromium browser.
2289         insertText corresponds to WebView::confirmComposition(text)
2290         setMarkedText corresponds to WebView::setComposition(...)
2291         unmarkText corresponds to WebView::confirmComposition()
2292         https://bugs.webkit.org/show_bug.cgi?id=51693
2293
2294         * DumpRenderTree/chromium/TextInputController.cpp:
2295         (TextInputController::insertText):
2296         (TextInputController::setMarkedText):
2297         (TextInputController::unmarkText):
2298
2299 2011-01-04  Dihan Wickremasuriya  <dihan.wickremasuriya@nokia.com>
2300
2301         Reviewed by Laszlo Gombos.
2302
2303         [Qt] [Symbian] Do not remove 0 byte sized files from productDir
2304
2305         On Symbian productDir points to the source directory. Removing all the
2306         empty files from the productDir directory corrupts the svn repository.
2307
2308         * Scripts/build-webkit:
2309
2310 2011-01-03  Yi Shen  <yi.4.shen@nokia.com>
2311
2312         Reviewed by Adam Barth.
2313
2314         [Qt] Add SelectAll option to the context menu for the editor
2315         https://bugs.webkit.org/show_bug.cgi?id=50049
2316
2317         Set shortcut for the SelectAll action.
2318
2319         * QtTestBrowser/mainwindow.cpp:
2320         (MainWindow::buildUI):
2321
2322 2011-01-03  David Levin  <levin@chromium.org>
2323
2324         Reviewed by Eric Seidel.
2325
2326         check-webkit-style shouldn't consider "value" automatically to be a meaningless name.
2327         https://bugs.webkit.org/show_bug.cgi?id=51842
2328
2329         * Scripts/webkitpy/style/checkers/cpp.py: Remove the check for value.
2330         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Remove the test for value.
2331
2332 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
2333
2334         Reviewed by David Kilzer.
2335
2336         [WINCE] Adds a build slave.
2337         https://bugs.webkit.org/show_bug.cgi?id=50523
2338
2339         * BuildSlaveSupport/build.webkit.org-config/config.json: Add an
2340         entry for a release build of the WinCE port.
2341         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add platform
2342         flag to build the WinCE port.
2343
2344 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
2345
2346         Reviewed by David Kilzer.
2347
2348         Add WinCE support to build-webkit
2349         https://bugs.webkit.org/show_bug.cgi?id=51642
2350
2351         * Scripts/build-webkit:
2352         * Scripts/webkitdirs.pm:
2353
2354 2011-01-03  Eric Seidel  <eric@webkit.org>
2355
2356         Reviewed by Adam Barth.
2357
2358         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
2359         https://bugs.webkit.org/show_bug.cgi?id=51802
2360
2361         I'm not the biggest fan of the test_failures or test_results classes,
2362         but it's better to have one shared set of classes, than separate ones
2363         for new vs. old run-webkit-test result handling.
2364
2365         This moves the ORWT results class "LayoutTestResults" over to using
2366         TestResult and TestFailure classes, making it easy for us to
2367         make all our sheriff-bot and other webkitpy code NRWT ready.
2368
2369         This also makes it a trivial patch to generate results.json information
2370         from ORWT results.html files (for flaky test analysis, etc.) as well
2371         as making it a one-liner to report test failure types when the
2372         commit-queue sees flaky tests.
2373
2374         This patch tried not to add new functionality, but only to replace
2375         the guts of LayoutTestResults, while adding unit tests and hoping
2376         not to break anything.
2377
2378         I also moved callers which assumed User.prompt* were static/class methods
2379         to using them as instance methods (since we'll eventually want to make them such).
2380
2381         In the process of re-writing things, I broke the rebaseline command, so I wrote
2382         a unit test to catch my breakage were I do do so again in the future.
2383
2384         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2385         * Scripts/webkitpy/common/net/layouttestresults.py:
2386         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2387         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
2388         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
2389         * Scripts/webkitpy/tool/commands/queries.py:
2390         * Scripts/webkitpy/tool/commands/rebaseline.py:
2391         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2392         * Scripts/webkitpy/tool/mocktool.py:
2393
2394 2011-01-03  Adam Barth  <abarth@webkit.org>
2395
2396         Reviewed by Simon Fraser.
2397
2398         webkit-patch shouldn't waste time cleaning a working directory that's already clean
2399         https://bugs.webkit.org/show_bug.cgi?id=51840
2400
2401         * Scripts/webkitpy/common/checkout/scm.py:
2402
2403 2011-01-03  Adam Barth  <abarth@webkit.org>
2404
2405         Reviewed by Simon Fraser.
2406
2407         webkit-patch should only hide update output if --quiet
2408         https://bugs.webkit.org/show_bug.cgi?id=51838
2409
2410         As requested by smfr.
2411
2412         * Scripts/webkitpy/tool/steps/update.py:
2413
2414 2011-01-03  Adam Barth  <abarth@webkit.org>
2415
2416         Reviewed by David Levin.
2417
2418         commit-queue shouldn't reject patches twice if two bots process the same patch
2419         https://bugs.webkit.org/show_bug.cgi?id=51805
2420
2421         Before raising an error, we first check whether the patch is still in
2422         the commit-queue.  This check is still racy, of course, but the time
2423         window is much smaller.
2424
2425         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2426
2427 2011-01-03  Sam Weinig  <sam@webkit.org>
2428
2429         Reviewed by Anders Carlsson.
2430
2431         Make run-api-tests less chatty.
2432         https://bugs.webkit.org/show_bug.cgi?id=51831
2433
2434         - Make script quiet by default and add --verbose option (replacing --quiet).
2435         - When not verbose, pipe stdout and stderr to devnull.
2436
2437         * Scripts/run-api-tests:
2438
2439 2011-01-03  Pratik Solanki  <psolanki@apple.com>
2440
2441         Unreviewed. Adding myself to committers.py.
2442
2443         * Scripts/webkitpy/common/config/committers.py:
2444
2445 2011-01-03  Koan-Sin Tan  <koansin.tan@gmail.com>
2446
2447         Reviewed by Xan Lopez.
2448
2449         "Tool/Scripts/run-launcher --gtk" stopped working after 74855
2450         https://bugs.webkit.org/show_bug.cgi?id=51806
2451
2452         Originally, the $libraryName is 'JavaScriptCore'. When building release 
2453         one, the $libraryDir was 'WebKitBuild/Release/JavaScriptCore/../.libs/'
2454         which doesn't exist anymore ('WebKitBuild/Release/JavaScriptCore'
2455         is 'WebKitBuild/Release/Source/JavaScriptCore' now), and 
2456         'WebKitBuild/Release/Source/JavaScriptCore/../../.libs' looks weird,
2457         so make it 'WebKitBuild/Release/.libs'
2458
2459         * Scripts/webkitdirs.pm: 
2460
2461 2011-01-02  Patrick Gansterer  <paroga@webkit.org>
2462
2463         Reviewed by Adam Barth.
2464
2465         Make EFL a core builder
2466         https://bugs.webkit.org/show_bug.cgi?id=51804
2467
2468         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2469         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2470
2471 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
2472
2473         [Qt] Unreviewed fix after r74855 and r74875.
2474
2475         * BuildSlaveSupport/built-product-archive:
2476          - Create directories explicitly.
2477          - Pass shell=True to subprocess.call().
2478
2479 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
2480
2481         [Qt] Unreviewed fix after r74855.
2482
2483         Move JavaScriptCore to Source
2484         https://bugs.webkit.org/show_bug.cgi?id=51604
2485
2486         * BuildSlaveSupport/built-product-archive: JavaScriptCore -> Source/JavaScriptCore
2487
2488 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
2489
2490         [Qt] Unreviewed run-javasriptcore-tests fix after r74855.
2491
2492         Move JavaScriptCore to Source
2493         https://bugs.webkit.org/show_bug.cgi?id=51604
2494
2495         * Scripts/webkitdirs.pm:
2496
2497 2011-01-02  Robert Hogan  <robert@webkit.org>
2498
2499         Unreviewed, build fix.
2500
2501         [Qt] Fix DRT build after 74855
2502
2503         * DumpRenderTree/qt/DumpRenderTree.pro:
2504
2505 2011-01-01  Adam Barth  <abarth@webkit.org>
2506
2507         Remove the assumption from the Qt and Gtk builds that every project is
2508         in the root directory.
2509
2510         * Scripts/build-webkit:
2511
2512 2011-01-01  Adam Barth  <abarth@webkit.org>
2513
2514         Reviewed by Eric Seidel.
2515
2516         Teach svn-apply how to apply patches even though JavaScriptCore has moved
2517         https://bugs.webkit.org/show_bug.cgi?id=51796
2518
2519         After this change, svn-apply will magically apply patches to
2520         JavaScriptCore/foo to Source/JavaScriptCore/foo.
2521
2522         * Scripts/VCSUtils.pm:
2523
2524 2011-01-01  Adam Barth  <abarth@webkit.org>
2525
2526         Reviewed by Eric Seidel.
2527
2528         Move JavaScriptCore to Source
2529         https://bugs.webkit.org/show_bug.cgi?id=51604
2530
2531         Update references to JavaScriptCore to point to the new location.
2532
2533         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2534         * DumpRenderTree/qt/DumpRenderTree.pro:
2535         * DumpRenderTree/qt/ImageDiff.pro:
2536         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2537         * DumpRenderTree/wscript:
2538         * Scripts/build-jsc:
2539         * Scripts/build-webkit:
2540         * Scripts/do-file-rename:
2541         * Scripts/do-webcore-rename:
2542         * Scripts/run-javascriptcore-tests:
2543         * Scripts/update-javascriptcore-test-results:
2544         * Scripts/webkitdirs.pm:
2545         * Scripts/webkitpy/common/config/build_unittest.py:
2546         * Scripts/webkitpy/style/checker.py:
2547         * Scripts/webkitpy/style/checker_unittest.py:
2548         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2549         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2550         * WebKitTestRunner/qt/WebKitTestRunner.pro:
2551         * wx/build/settings.py:
2552
2553 2011-01-01  Adam Barth  <abarth@webkit.org>
2554
2555         Reviewed by Eric Seidel.
2556
2557         Move Sources to Source
2558         https://bugs.webkit.org/show_bug.cgi?id=51794
2559
2560         Update scripts to point to the new location.
2561
2562         * Scripts/build-webkit:
2563         * Scripts/do-file-rename:
2564         * Scripts/do-webcore-rename:
2565         * Scripts/webkitpy/common/config/build.py:
2566         * Scripts/webkitpy/common/config/build_unittest.py:
2567
2568 2010-12-31  Kent Tamura  <tkent@chromium.org>
2569
2570         Reviewed by Eric Seidel.
2571
2572         [DRT/Chromium] Enable mock spell checker on non-OSX
2573         https://bugs.webkit.org/show_bug.cgi?id=51401
2574
2575         * DumpRenderTree/chromium/WebViewHost.cpp:
2576         (WebViewHost::spellCheck):
2577
2578 2010-12-31  Adam Barth  <abarth@webkit.org>
2579
2580         Reviewed by Ariya Hidayat.
2581
2582         Remove Tools/Scripts/wkstyle
2583         https://bugs.webkit.org/show_bug.cgi?id=51774
2584
2585         This script appears to not have been touched in a while and seems to
2586         have been replaced by check-webkit-style.
2587
2588         * Scripts/wkstyle: Removed.
2589
2590 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
2591
2592         Unreviewed. Coding style fix.
2593
2594         * DumpRenderTree/chromium/TestShell.h:
2595
2596 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
2597
2598         Reviewed by Pavel Feldman.
2599
2600         Web Inspector: [Chromium] Inspector's tests are very slow on Win(Dbg).
2601
2602         It was a problem with Chromium DRT. DevToolsAgent object instance was
2603         attached not only to the inspected page but to the DevTools window too.
2604         As result all the inspector files were interpreted as a content of inspected page
2605         and were transfered to the DevTools scripts panel for debugging etc.
2606
2607         https://bugs.webkit.org/show_bug.cgi?id=51735
2608
2609         * DumpRenderTree/chromium/TestShell.cpp:
2610         (TestShell::TestShell):
2611         (TestShell::bindJSObjectsToWindow):
2612         (TestShell::createNewWindow):
2613         * DumpRenderTree/chromium/TestShell.h:
2614
2615 2010-12-31  Adam Barth  <abarth@webkit.org>
2616
2617         Rubber-stamped by Eric Seidel.
2618
2619         Move PageLoadTests to PerformanceTests/PageLoad
2620         https://bugs.webkit.org/show_bug.cgi?id=51771
2621
2622         Update references to PageLoadTests to point to the new location.
2623
2624         * Scripts/run-pageloadtest:
2625         * Scripts/webkitpy/common/config/build.py:
2626
2627 2010-12-31  Adam Barth  <abarth@webkit.org>
2628
2629         Rubber-stamped by Eric Seidel.
2630
2631         Move SunSpider into PerformanceTests
2632         https://bugs.webkit.org/show_bug.cgi?id=51769
2633
2634         Update these scripts to point to the new location.
2635
2636         * Scripts/run-sunspider:
2637         * Scripts/sunspider-compare-results:
2638
2639 2010-12-30  Mihai Parparita  <mihaip@chromium.org>
2640
2641         Reviewed by Kent Tamura.
2642
2643         [Chromium] Add WebThemeEngineDRTMac so that Chromium DRT scrollbar rendering can match the Mac port's
2644         https://bugs.webkit.org/show_bug.cgi?id=51728
2645         
2646         Add implementation of the Mac WebThemeEngine that uses an NSScroller
2647         to render top-level scrollbars. This makes them match the Mac port's
2648         use of an NSScrollView, which means that we'll be able to share more
2649         pixel baselines.
2650         
2651         The new rendering code will not be activated until the 
2652         USE_WEB_THEME_ENGINE_TO_PAINT_THUMB #define is fliped in
2653         ScrollbarThemeChromiumMac.
2654
2655         * DumpRenderTree/DumpRenderTree.gypi:
2656         * DumpRenderTree/chromium/TestShellMac.mm:
2657         (platformInit):
2658         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Added.
2659         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Added.
2660         (+[FakeActiveWindow alwaysActiveWindow]):
2661         (+[FakeActiveWindow alwaysInactiveWindow]):
2662         (-[FakeActiveWindow initWithActiveControls:]):
2663         (-[FakeActiveWindow _hasActiveControls]):
2664         (WebThemeEngineDRTMac::paintScrollbarThumb):
2665         (stateToHIEnableState):
2666         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
2667         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
2668
2669 2010-12-30  Konstantin Tokarev  <annulen@yandex.ru>
2670
2671         Reviewed by David Kilzer.
2672
2673         [Qt] Don't build wtf/TCSystemAlloc.cpp if --system-malloc option is
2674         used
2675         https://bugs.webkit.org/show_bug.cgi?id=51672
2676
2677         * DumpRenderTree/qt/DumpRenderTree.pro: Replaced USE_SYSTEM_MALLOC
2678         with USE_SYSTEM_MALLOC=1
2679         * WebKitTestRunner/qt/WebKitTestRunner.pro: Replaced USE_SYSTEM_MALLOC
2680         with USE_SYSTEM_MALLOC=1
2681
2682 2010-12-30  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2683
2684         Reviewed by David Kilzer.
2685
2686         [Qt] [Symbian] Fix build-webkit script for Symbian
2687         https://bugs.webkit.org/show_bug.cgi?id=51509
2688
2689         Set the OUTPUT_DIR for Symbian to be the same as the source
2690         directory.
2691
2692         * Scripts/webkitdirs.pm:
2693
2694 2010-12-30  Martin Robinson  <mrobinson@igalia.com>
2695
2696         Reviewed by Darin Adler.
2697
2698         check-webkit-style should ignore NULL usage in calls to gtk_widget_style_get
2699         https://bugs.webkit.org/show_bug.cgi?id=51758
2700
2701         Add a check-webkit-style exception for gtk_widget_style_get and NULL usage.
2702
2703         * Scripts/webkitpy/style/checkers/cpp.py: Add the exception.
2704         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Add some tests for this.
2705
2706 2010-12-29  Patrick Gansterer  <paroga@webkit.org>
2707
2708         Unreviewed WinCE buildfix.
2709
2710         * WinCELauncher/main.cpp: Add missing include.
2711
2712 2010-12-29  Daniel Bates  <dbates@rim.com>
2713
2714         Reviewed by Darin Adler.
2715
2716         svn-apply updates date of wrong change log entry for a change log diff that
2717         contains two consecutive entries with the same author and date
2718         https://bugs.webkit.org/show_bug.cgi?id=46061
2719
2720         Fixes an issue where the date of the wrong change log entry may be modified.
2721         Moreover, changes fixChangeLogPatch() to move entries inserted earlier
2722         in a ChangeLog file to the top of the file.
2723
2724         Currently, fixChangeLogPatch() explicitly bails out and returns an unchanged
2725         diff when it detects that the diff inserts a change log entry earlier in a
2726         ChangeLog. It is unusual to land a patch that has such a deliberate ChangeLog
2727         change. With the advent of the commit-queue this functionality of bailing out
2728         and hence landing the patch as-is is harmful to the accuracy of the ChangeLog.
2729         Instead, we should always move the change log entry to the top of the ChangeLog file.
2730
2731         A side-effect of this change is that setChangeLogDateAndReviewer() now updates
2732         the date line of the correct change log entry in a ChangeLog diff.
2733
2734         * Scripts/VCSUtils.pm: Modified fixChangeLogPatch() to move entries inserted earlier to the top.
2735
2736         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
2737           Updated the following unit tests now that we move entries inserted earlier to the top:
2738           - "fixChangeLogPatch: New entry inserted in middle."
2739             (formerly named "fixChangeLogPatch: [no change] New entry inserted in middle.")
2740
2741           - "fixChangeLogPatch: New entry inserted earlier in the file, but after an entry with the same author and date."
2742             (formerly named "fixChangeLogPatch: [no change] New entry inserted earlier in the file, but after an entry with the same author and date.")
2743
2744         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatchThenSetChangeLogDateAndReviewer.pl: Added.
2745
2746 2010-12-29  Konstantin Tokarev  <annulen@yandex.ru>
2747
2748         Reviewed by Eric Seidel.
2749
2750         [Qt] Fixed compatibility with gold linker on X11 platforms
2751         https://bugs.webkit.org/show_bug.cgi?id=51700
2752
2753         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2754         Linked TestNetscapePlugin with libX11 on Unix platforms
2755
2756 2010-12-29  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>
2757
2758         Reviewed by Darin Adler.
2759
2760         Circular dependency in webkitpy.common.checkout.changelog module
2761         https://bugs.webkit.org/show_bug.cgi?id=50475
2762
2763         Remove automatic import of api.Checkout module when any checkout/
2764         submodule is imported (e.g.: when checkout.scm.Git is imported).
2765
2766         * Scripts/webkitpy/common/checkout/__init__.py:
2767
2768 2010-12-29  Martin Robinson  <mrobinson@igalia.com>
2769
2770         Reviewed by Ojan Vafai.
2771
2772         prepare-ChangeLog should support the -g option for specifying the git-commit
2773         https://bugs.webkit.org/show_bug.cgi?id=51708
2774
2775         Add a -g shortcut for the --git-commit prepare-ChangeLog option. This matches
2776         webkit-patch, though the exact meaning of the two options remain different.
2777
2778         * Scripts/prepare-ChangeLog: Add -g.
2779
2780 2010-12-29  Kent Hansen  <kent.hansen@nokia.com>
2781
2782         Reviewed by Simon Hausmann.
2783
2784         [Qt] Fix compilation with Qt in namespace
2785         https://bugs.webkit.org/show_bug.cgi?id=51701
2786
2787         * QtTestBrowser/webview.h:
2788
2789 2010-12-28  Daniel Bates  <dbates@rim.com>
2790
2791         Reviewed by Sam Weinig.
2792
2793         Substitute // MARK: for compiler-specific #pragma mark
2794         https://bugs.webkit.org/show_bug.cgi?id=51657
2795
2796         Fix future compilation warnings about "#pragma mark" on GTK+ bots by
2797         substituting  "// MARK:" for "#pragma mark", which provides
2798         analogous code-bookmarking functionality under Xcode.
2799
2800         Also, for consistency, we should substitute "// MARK:" for compiler-
2801         specific "#pragma mark" in the source files for the Mac port.
2802
2803         * DumpRenderTree/AccessibilityTextMarker.cpp:
2804         * DumpRenderTree/cf/WebArchiveDumpSupport.h:
2805         * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm:
2806         * DumpRenderTree/mac/ObjCController.m:
2807         * MiniBrowser/mac/AppDelegate.m:
2808         * MiniBrowser/mac/BrowserWindowController.m:
2809
2810 2010-12-28  Xan Lopez  <xlopez@igalia.com>
2811
2812         Reviewed by Eric Seidel.
2813
2814         Add --no-build option to run-sunspider
2815         https://bugs.webkit.org/show_bug.cgi?id=51658
2816
2817         * Scripts/run-sunspider: add --no-build flag to skip building
2818         phase.
2819
2820 2010-12-27  Daniel Bates  <dbates@rim.com>
2821
2822         Rubber-stamped by Martin Robinson.
2823
2824         Append the directory Tools/DumpRenderTree to the list of directories that
2825         do-webcore-rename should search so that it can rename DRT files and
2826         source code.
2827
2828         * Scripts/do-webcore-rename:
2829
2830 2010-12-27  Eric Seidel  <eric@webkit.org>
2831
2832         Reviewed by Adam Barth.
2833
2834         build-webkit should detect missing Java SDK and explain how to install it
2835         https://bugs.webkit.org/show_bug.cgi?id=51651
2836
2837         * Scripts/build-webkit:
2838
2839 2010-12-26  Martin Robinson  <mrobinson@igalia.com>
2840
2841         Reviewed by Daniel Bates.
2842
2843         [GTK] Add support for build-jsc
2844         https://bugs.webkit.org/show_bug.cgi?id=51625
2845
2846         Add GTK+ support to build-jsc now that building the jsc executable as
2847         a standalone target is easy.
2848
2849         * Scripts/build-jsc: Call buildGtkProject for the GTK+ case now.
2850         * Scripts/build-webkit: Pass in the proper target name to buildGtkProject.
2851         * Scripts/webkitdirs.pm: Actually process the project parameter in buildGtkProject
2852         and pass it along to buildAutotoolsProject.
2853
2854 2010-12-27  David Levin  <levin@chromium.org>
2855
2856         Reviewed by Eric Seidel.
2857
2858         check-webkit-style check for meaningless variable names in function declarations.
2859         https://bugs.webkit.org/show_bug.cgi?id=51523
2860
2861         * Scripts/webkitpy/style/checker.py: Exempted JavaScriptCore/jit/JITStubs.cpp
2862         from the new check and whitespace/parens because the syntax is unusual and
2863         produced a fair number of positives for these checks.
2864         * Scripts/webkitpy/style/checkers/cpp.py:
2865         (_convert_to_lower_with_underscores): Used as a canonical form for type names
2866         and parameter names when determining if the parameter name is useless.
2867         (_create_acronym): Used to check for redundant variable names in cases like "ExceptionCode ec"
2868         (Parameter.lower_with_underscores_name): Gives back the parameter name in a lower_with_underscore
2869         format.
2870         (_check_parameter_name_against_text):  Checks to see if the parameter name is in the
2871         text or an acronym of it.
2872         (check_function_definition): Checks function definitions for meaningless variable names.
2873         (process_line): Added call to check_function_definition.
2874         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2875         (CppFunctionsTest.test_convert_to_lower_with_underscores): Test for _convert_to_lower_with_underscores.
2876         (CppFunctionsTest.test_create_acronym): Test for _create_acronym.
2877         (CppFunctionsTest.test_check_parameter_against_text): Test for _check_parameter_against_text.
2878         (CppStyleTestBase.perform_single_line_lint): Removed the parameter name check
2879         because when only checking a snippet, there are a lot of bogus functions.
2880         (CppStyleTestBase.perform_multi_line_lint): Ditto and removed a bogus filter
2881         that I put there previously and just noticed.
2882         (WebKitStyleTest.test_parameter_names): Tests for the functionality -- both
2883         check_function_definition and process_line.
2884
2885 2010-12-27  Carlos Garcia Campos  <cgarcia@igalia.com>
2886
2887         Reviewed by Martin Robinson.
2888
2889         [GTK] Disable flash plugin in GtkLauncher when using gtk3
2890         https://bugs.webkit.org/show_bug.cgi?id=51591
2891
2892         Flash plugin uses gtk2 that is incompatible with gtk3 making
2893         webkit crash when it's built with gtk3.
2894
2895         * GtkLauncher/main.c:
2896         (main):
2897
2898 2010-12-25  Adam Barth  <abarth@webkit.org>
2899
2900         Reviewed by Eric Seidel.
2901
2902         Move ANGLE to Sources/ThirdParty
2903         https://bugs.webkit.org/show_bug.cgi?id=51605
2904
2905         * Scripts/build-webkit:
2906           - Point to the new ANGLE location.
2907
2908 2010-12-26  David Levin  <levin@chromium.org>
2909
2910         Reviewed by Eric Seidel.
2911
2912         check-webkit-style should be able to parse function declaration parameters.
2913         https://bugs.webkit.org/show_bug.cgi?id=51451
2914
2915         * Scripts/webkitpy/style/checkers/cpp.py:
2916         (Position.__init__): Holds simple position information (row, column).
2917         (Parameter.__init__): Holds information about a parameter.
2918         (SingleLineView.__init): Converts multiple lines into a single line for simpler searches.
2919         (SingleLineView.convert_column_to_row): Returns the original row given a column.
2920         (create_skeleton_parameters): Simplifies a parameter list for easier searching.
2921         (find_parameter_name_index): Finds where the parameter name is.
2922         (parameter_list): Generates the list of parameters for a function.
2923         (_FunctionState.begin): Added information to allow determining the parameters
2924         on demand.
2925         (_FunctionState.get_parameter_list): Returns a tuple of function parameters.
2926         (detect_functions): Improve function detection for operator functions and
2927         determine where the parameters end and pass that to _FunctionState.begin.
2928         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2929         (CppFunctionsTest.test_parameter): Verifies Parameter functionality.
2930         (CppFunctionsTest.test_single_line_view): Verifies SingleLineView functionality.
2931         (CppFunctionsTest.test_create_skeleton_parameters): Verifies create_skeleton_parameters.
2932         (CppFunctionsTest.test_find_parameter_name_index): Verifies find_parameter_name_index.
2933         (CppFunctionsTest.test_parameter_list): Does some minimal verification for parameter list.
2934         Much more thorough verification is done as part of FunctionDetectionTest.test_parameter_list.
2935         (FunctionDetectionTest.perform_function_detection): Added support for verifying
2936         the parameters found.
2937         (FunctionDetectionTest.test_function_declaration_detection): Added more function
2938         detection test to verify that we catch the operator functions.
2939         (FunctionDetectionTest.test_ignore_macros): Verify that function detection ignores macros.
2940         (FunctionDetectionTest.test_parameter_list): Added tests to verify the parameter parsing.
2941         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_bad_test_doesnt_break): Removed
2942         because the error. The test is about the bad function name. Fixing the name makes the test exactly like
2943         test_function_length_check_definition_severity1_for_test.
2944
2945 2010-12-25  Patrick Gansterer  <paroga@webkit.org>
2946
2947         Unreviewed WinCE buildfix after r74334.
2948
2949         * CMakeListsWinCE.txt:
2950
2951 2010-12-24  Sheriff Bot  <webkit.review.bot@gmail.com>
2952
2953         Unreviewed, rolling out r74632.
2954         http://trac.webkit.org/changeset/74632
2955         https://bugs.webkit.org/show_bug.cgi?id=51600
2956
2957         makes test-webkitpy hang forever on GTK (Requested by philn-tp
2958         on #webkit).
2959
2960         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
2961         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
2962
2963 2010-12-24  Ryuan Choi  <ryuan.choi@samsung.com>
2964
2965         Reviewed by Kenneth Rohde Christiansen.
2966
2967         [EFL] Screen doesn't be rendered when changing size of EWebLauncher
2968         https://bugs.webkit.org/show_bug.cgi?id=43528
2969
2970         Remove on_resize because ewk_view_fixed_layout_size_set should not be
2971         called on callback of EVAS_CALLBACK_RESIZE. As it change size of
2972         FrameView, rendering was ignored when _ewk_view_smart_calculate was
2973         called.
2974
2975         * EWebLauncher/main.c:
2976         (browserCreate):
2977
2978 2010-12-24  Eric Seidel  <eric@webkit.org>
2979
2980         Reviewed by Adam Barth.
2981
2982         webkit-patch (or a pre-commit hook) needs to prevent bad ChangeLog changes
2983         https://bugs.webkit.org/show_bug.cgi?id=28291
2984
2985         This is a start.  At least now webkit-patch will prompt when your ChangeLog looks questionable.
2986         We could do more advanced things, like parsing the ChangeLog (with changelog.py) and comparing that
2987         to strings with find in the diff.
2988         Since non-interactive always returns the default, this should cause patches with bad changelogs to fail on the commit-queue.
2989
2990         * Scripts/webkitpy/common/checkout/api.py:
2991         * Scripts/webkitpy/common/checkout/diff_parser.py:
2992         * Scripts/webkitpy/tool/steps/abstractstep.py:
2993         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
2994         * Scripts/webkitpy/tool/steps/validatechangelogs.py: Copied from Tools/Scripts/webkitpy/tool/steps/validatereviewer.py.
2995         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py: Copied from Tools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.
2996         * Scripts/webkitpy/tool/steps/validatereviewer.py:
2997
2998 2010-12-24  Dirk Pranke  <dpranke@chromium.org>
2999
3000         Reviewed by Kenneth Russell.
3001
3002         Modify new-run-webkit-tests to shut up and exit when all the threads
3003         are wedged so that test runs complete faster and we don't end up
3004         w/ enormous log files.
3005
3006         https://bugs.webkit.org/show_bug.cgi?id=51572
3007
3008         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
3009         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
3010
3011 2010-12-24  Eric Seidel  <eric@webkit.org>
3012
3013         Reviewed by David Levin.
3014
3015         commit-queue should better explain how it will re-open bugs and follow duplicate chains
3016         https://bugs.webkit.org/show_bug.cgi?id=51549
3017
3018         I've had multiple people ask me about the commit-queue's behavior
3019         regarding reporting flaky tests.  I figured it would be best to just
3020         have the queue explain itself in the bugs it files.
3021
3022         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3023         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3024
3025 2010-12-24  Shinichiro Hamaji  <hamaji@chromium.org>
3026
3027         Reviewed by Eric Seidel.
3028
3029         check-webkit-style: should ignore "wrong" namings in JavaScriptCore/qt
3030         https://bugs.webkit.org/show_bug.cgi?id=51467
3031
3032         * Scripts/webkitpy/style/checker.py:
3033         * Scripts/webkitpy/style/checker_unittest.py:
3034
3035 2010-12-23  Adam Barth  <abarth@webkit.org>
3036
3037         Rubber-stamped by Eric Seidel.
3038
3039         Move JavaScriptGlue into Sources
3040         https://bugs.webkit.org/show_bug.cgi?id=51583
3041
3042         These tools refer to JavaScriptGlue and need to be updated to its new
3043         location.
3044
3045         * Scripts/build-webkit:
3046         * Scripts/do-file-rename:
3047         * Scripts/do-webcore-rename:
3048         * Scripts/webkitpy/common/config/build.py:
3049         * Scripts/webkitpy/common/config/build_unittest.py:
3050
3051 2010-12-23  Lucas Forschler  <lforschler@apple.com>
3052
3053         Reviewed by Eric Seidel.
3054
3055         Bug 51539 - update iexploder scripts to point to new location
3056
3057         * Scripts/run-iexploder-tests:
3058         * Scripts/update-iexploder-cssproperties:
3059
3060 2010-12-23  Evan Martin  <evan@chromium.org>
3061
3062         Reviewed by Ryosuke Niwa.
3063
3064         [chromium] LayoutTestController warning in float->int conversion
3065         https://bugs.webkit.org/show_bug.cgi?id=51553
3066
3067         Rather than reading an int, converting to a float, then getting a compiler
3068         warning on passing the float to something that expects an int, instead
3069         just pass around ints.
3070
3071         No tests, fixes a compiler warning.
3072
3073         * DumpRenderTree/chromium/LayoutTestController.cpp:
3074         (parsePageSizeParameters):
3075         (LayoutTestController::pageNumberForElementById):
3076         (LayoutTestController::numberOfPages):
3077
3078 2010-12-23  Lucas Forschler  <lforschler@apple.com>
3079
3080         Reviewed by Darin Adler.
3081
3082         Bug 51537 - iexploder needs cleanup
3083         
3084         * iExploder/htdocs: Removed.
3085         * iExploder/htdocs/config.rb: Removed.
3086         * iExploder/htdocs/cssproperties.in: Removed.
3087         * iExploder/htdocs/cssvalues.in: Removed.
3088         * iExploder/htdocs/htmlattrs.in: Removed.
3089         * iExploder/htdocs/htmltags.in: Removed.
3090         * iExploder/htdocs/htmlvalues.in: Removed.
3091         * iExploder/htdocs/iexploder.cgi: Removed.
3092         * iExploder/htdocs/iexploder.rb: Removed.
3093         * iExploder/htdocs/index.html: Removed.
3094         * iExploder/htdocs/webserver.rb: Removed.
3095         * iExploder/iexploder-1.7.2/output: Removed.
3096         * iExploder/tools: Removed.
3097         * iExploder/tools/lasthit.rb: Removed.
3098         * iExploder/tools/osx_last_crash.rb: Removed.
3099         * iExploder/tools/showtest.rb: Removed.
3100
3101 2010-12-23  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
3102
3103         Reviewed by Kenneth Rohde Christiansen.
3104
3105         [EFL] Make 'single' the default backing store in EWebLauncher
3106         https://bugs.webkit.org/show_bug.cgi?id=51534
3107
3108         'single' is the simplest backing store and the one intended to be the
3109         default in the test browser. By mistake the tiled backing store was
3110         left as default in r72617.
3111
3112         * EWebLauncher/main.c:
3113         (browserCreate): ditto.
3114
3115 2010-12-23  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
3116
3117         Reviewed by Kenneth Rohde Christiansen.
3118
3119         [EFL] Subject: [webkit 4/4] [EFL] Remove non-sense workaround
3120         https://bugs.webkit.org/show_bug.cgi?id=51533
3121
3122         There's no point in concatenating env("HOME") with "blah", so remove
3123         option from EWebLauncher.
3124
3125         * EWebLauncher/main.c:
3126         (main): ditto.
3127
3128 2010-12-23  Ilya Tikhonovsky  <loislo@chromium.org>
3129
3130         Reviewed by Eric Seidel.
3131
3132         Web Inspector: chromium: inspector's tests are quite slow especially at windows(Debug).
3133
3134         Almost all inspector's tests become flaky on chromium Win(dbg) after switching to DRT.
3135         I just discovered that we have two additional GC runs per each WebViewHost.
3136         Test_shell had no such calls.
3137         These gc runs eat 15% of cpu time.
3138
3139         https://bugs.webkit.org/show_bug.cgi?id=51479
3140
3141         * DumpRenderTree/chromium/WebViewHost.cpp:
3142         (WebViewHost::~WebViewHost):
3143
3144 2010-12-22  Dirk Pranke  <dpranke@chromium.org>
3145
3146         Reviewed by Ojan Vafai.
3147
3148         This change splits out the TestRunner class into its own file.
3149         When we fork the code for message passing, we will create a new
3150         TestRunner, and this change will allow that to be more modular.
3151
3152         While we're at it, split out TestInput and ResultSummary into
3153         their own files, to reduce the size of run_webkit_tests to
3154         something more managable.
3155
3156         https://bugs.webkit.org/show_bug.cgi?id=51092
3157
3158         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
3159         * Scripts/webkitpy/layout_tests/layout_package/result_summary.py:
3160         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
3161         * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
3162         * Scripts/webkitpy/layout_tests/layout_package/test_input.py:
3163         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3164         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3165
3166  2010-12-22  Dirk Pranke  <dpranke@chromium.org>
3167
3168         Reviewed by Ojan Vafai.
3169
3170         nrwt multiprocessing - start over, prepare to fork the code
3171  
3172         This code cleans up the signatures and implementation of the
3173         TestRunner class so we can easily fork it to run either the
3174         stable implementation or the new, unstable message-passing
3175         implementation. The two variants will have different
3176         implementations of the run_tests() method. We will switch
3177         between the two based on the setting for the '--worker-model'
3178         switch. We rename the two currently valid values to 'old-inline'
3179         and 'old-threads'.
3180
3181         https://bugs.webkit.org/show_bug.cgi?id=51081
3182
3183         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3184         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3185
3186 2010-12-22  Victor Wang  <victorw@chromium.org>
3187
3188         Reviewed by Darin Fisher.
3189
3190         [Chromium] Update chromium archive test result url in rebaseline script.
3191
3192         https://bugs.webkit.org/show_bug.cgi?id=51503
3193
3194         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
3195
3196 2010-12-22  Lucas Forschler  <lforschler@apple.com>
3197
3198         Reviewed by Alice Liu.
3199
3200         <rdar://problem/8633222> record-memory-win needs to record memory used by the webprocess.
3201         Verified on Chrome, Safari, and IE.
3202         With this change, we will record memory from a parent browser window and all child processes.
3203
3204         * record-memory-win/main.cpp:
3205         (ProcessArgs):
3206         (PrintUsage):
3207         (getMemoryInfo):
3208         (printProcessInfo):
3209         (evalProcesses):
3210         (UseImage):
3211         (QueryContinuously):
3212         (ElapsedTime):
3213
3214 2010-12-22  Lucas Forschler  <lforschler@apple.com>
3215
3216         Unreviewed rollout r74489, because it was missing changelog.
3217
3218         * record-memory-win/main.cpp:
3219         
3220 2010-12-22  Ryosuke Niwa  <rniwa@webkit.org>
3221
3222         Adding myself as a reviewer.
3223
3224         * Scripts/webkitpy/common/config/committers.py:
3225
3226 2010-12-22  Andrew Scherkus  <scherkus@chromium.org>
3227
3228         Unreviewed.  Adding myself to committers.py.
3229
3230         * Scripts/webkitpy/common/config/committers.py:
3231
3232 2010-12-22  Ariya Hidayat  <ariya@sencha.com>
3233
3234         Reviewed by Kenneth Rohde Christiansen.
3235
3236         TestNetscapePlugIn should use #if defined
3237         https://bugs.webkit.org/show_bug.cgi?id=51471
3238
3239         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3240         (NP_Initialize):
3241         (NPP_New):
3242
3243 2010-12-22  Ilya Tikhonovsky  <loislo@chromium.org>
3244
3245         Reviewed by Yury Semikhatsky.
3246
3247         Web Inspector: [chromium] DRT inspector layout tests are flaky in debug.
3248
3249         DevTools window should be closed explicitly because it has custom deinitialization code.
3250
3251         https://bugs.webkit.org/show_bug.cgi?id=50722
3252
3253         * DumpRenderTree/chromium/TestShell.cpp:
3254         (TestShell::closeRemainingWindows):
3255
3256 2010-12-22  David Levin  <levin@chromium.org>
3257
3258         Reviewed by Shinichiro Hamaji.
3259
3260         check-webkit-style shouldn't complaint about underscores in variables in objective C files.
3261         https://bugs.webkit.org/show_bug.cgi?id=51452
3262
3263         * Scripts/webkitpy/style/checkers/cpp.py:
3264         (_FileState.__init__): Added the information to determine if a file is C or Objective C.
3265         Using the file extension if possible but falling back to the file contents if we have a header file.
3266         (_FileState.is_objective_c): Determine if we have an Objective C by examining the file contents if needed.
3267         (_FileState.is_c_or_objective_c):
3268         (check_using_std): Changed to using _FileState to determine the file type.
3269         (check_max_min_macros): Ditto.
3270         (check_for_null): Ditto.
3271         (check_style): Changed the parameters to various calls since they now need _FileState
3272         to determine the file type.
3273         (check_language): Added the file_state parameter so it could be passed
3274         to check_identifier_name_in_declaration.
3275         (check_identifier_name_in_declaration): Don't warn about underscores in variables if
3276         this is an Objective C file.
3277         (_process_lines): Added information for the _FileState constructor (and moved the
3278         call to a place that had the information).
3279         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3280         (CppFunctionsTest.test_is_c_or_objective_c): Changed the tests to use FileState and exercise
3281         its functionality.
3282         (WebKitStyleTest.test_names): Add tests for underscores in Objective C files.
3283
3284 2010-12-21  Andy Estes  <aestes@apple.com>
3285
3286         Reviewed by Mark Rowe.
3287
3288         Do not build non-Intel architectures for WebKit2-related projects.
3289         https://bugs.webkit.org/show_bug.cgi?id=51440
3290
3291         * MiniBrowser/Configurations/Base.xcconfig: Only build for i386 and x86_64.
3292         * TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
3293         * WebKitTestRunner/Configurations/Base.xcconfig: Ditto.
3294
3295 2010-12-21  Mihai Parparita  <mihaip@chromium.org>
3296
3297         Reviewed by Darin Fisher.
3298
3299         [Chromium] Rename WebThemeEngine/ControlDRT to WebThemeEngine/ControlDRTWin
3300         https://bugs.webkit.org/show_bug.cgi?id=51406 
3301         
3302         Rename WebThemeControlDRT to WebThemeControlDRTWin and WebThemeEngineDRT
3303         to WebThemeEngineDRTWin and update references everywhere.
3304
3305         * DumpRenderTree/DumpRenderTree.gypi:
3306         * DumpRenderTree/chromium/TestShellWin.cpp:
3307         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRT.cpp.
3308         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRT.h.
3309         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRT.cpp.
3310         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRT.h.
3311
3312 2010-12-21  Anders Carlsson  <andersca@apple.com>
3313
3314         Reviewed by John Sullivan.
3315
3316         Clicking missing plug-in text does not show a sheet
3317         https://bugs.webkit.org/show_bug.cgi?id=51403
3318
3319         Update for changes to the WebPageUIClient.
3320
3321         * MiniBrowser/mac/BrowserWindowController.m:
3322         (-[BrowserWindowController awakeFromNib]):
3323         * WebKitTestRunner/TestController.cpp:
3324         (WTR::createOtherPage):
3325         (WTR::TestController::initialize):
3326
3327 2010-12-21  Eric Seidel  <eric@webkit.org>
3328
3329         Reviewed by Adam Barth.
3330
3331         commit-queue will report constant failures as flaky if other tests flake
3332         https://bugs.webkit.org/show_bug.cgi?id=51272
3333
3334         This patch just removes functionality and adds testing.
3335         Previously we attempted to report flaky tests when we had
3336         two different tests fail in a row.  However, since we stop
3337         running the tests at the first failure, our code was wrong in
3338         trying to determine flakiness from the incomplete runs.
3339
3340         Originally I posted an alternate patch:
3341         https://bug-51272-attachments.webkit.org/attachment.cgi?id=77078
3342         which fixed our flaky logic in this case, however it was decided
3343         that that patch would be too difficult to maintain, so now
3344         I'm just removing the broken logic.
3345
3346         This will dramatically cut-down on our flaky-test false positives
3347         at the (small) cost of the queues being unable to report
3348         any flakiness if the tree is very flaky.  (With at least one test
3349         flaking on every run, we'll never report failures anymore.)  I think
3350         this is a tradeoff worth making.
3351
3352         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3353         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3354
3355 2010-12-20  Eric Seidel  <eric@webkit.org>
3356
3357         Reviewed by Adam Barth.
3358
3359         commit-queue wrongly rejects patches when it can't update itself
3360         https://bugs.webkit.org/show_bug.cgi?id=46636
3361
3362         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3363         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3364         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3365
3366 2010-12-20  Adam Barth  <abarth@webkit.org>
3367
3368         Move web sites to Websites directory
3369         https://bugs.webkit.org/show_bug.cgi?id=51323
3370
3371         Update references to BugsSite to point to the new location.
3372
3373         This patch was never officially reviewed (because it was too large to
3374         upload to bugs.webkit.org), but it was discussed on webkit-dev and Mark
3375         Rowe gave me the green light.
3376
3377         * Scripts/old-run-webkit-tests:
3378         * Scripts/webkitpy/common/config/build.py:
3379         * Scripts/webkitpy/common/config/build_unittest.py:
3380         * Scripts/webkitpy/common/prettypatch.py:
3381         * Scripts/webkitpy/layout_tests/port/base.py:
3382         * Scripts/webkitpy/style/main.py:
3383
3384 2010-12-20  Adrienne Walker  <enne@google.com>
3385
3386         Unreviewed. Adding myself to the list of committers.
3387
3388         * webkitpy/common/config/committers.py:
3389
3390 2010-12-20  Mark Rowe  <mrowe@apple.com>
3391
3392         Reviewed by Dan Bernstein.
3393
3394         <rdar://problem/8757601> Don't install header files in to the Resources directory.
3395
3396         * Scripts/check-for-inappropriate-files-in-framework: Don't allow .h files in the
3397         Resources directory.
3398
3399 2010-12-20  Eric Seidel  <eric@webkit.org>
3400
3401         Reviewed by Adam Barth.
3402
3403         commit-queue should include bot id when attaching failure diffs
3404         https://bugs.webkit.org/show_bug.cgi?id=51280
3405
3406         This is a tiny change to include the bot id in the name of the attachment.
3407         Most of this diff is just changing the unit test expectations
3408         now that I hid the comment printing when the comment is None.
3409
3410         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3411         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3412         * Scripts/webkitpy/tool/commands/upload_unittest.py:
3413         * Scripts/webkitpy/tool/mocktool.py:
3414
3415 2010-12-20  Jeff Miller  <jeffm@apple.com>
3416
3417         Reviewed by Dan Bernstein.
3418
3419         Tools/vcbin/midl.exe needs to be rebuilt
3420         https://bugs.webkit.org/show_bug.cgi?id=51347
3421
3422         * vcbin/midl.exe: Rebuilt.
3423
3424 2010-12-20  David Levin  <levin@chromium.org>
3425
3426         Reviewed by Ariya Hidayat.
3427
3428         .gitignore and webkit-tools-completion.sh have references to WebKitTools that should be Tools.
3429         https://bugs.webkit.org/show_bug.cgi?id=51343
3430
3431         Follow up from the WebKitTools -> Tools rename.
3432
3433         * Scripts/webkit-tools-completion.sh:
3434
3435 2010-12-20  Cosmin Truta  <ctruta@chromium.org>
3436
3437         Reviewed by James Robinson.
3438
3439         new-run-webkit-tests ignores trailing EOL differences in text tests
3440         https://bugs.webkit.org/show_bug.cgi?id=36983
3441
3442         Changed the handling of new-line characters within new-run-webkit-tests
3443         to match old-run-webkit-tests.  Differences in leading and trailing empty
3444         lines in text expectation files are no longer ignored.
3445
3446         * Scripts/webkitpy/layout_tests/port/base.py:
3447         * Scripts/webkitpy/layout_tests/port/test.py:
3448         Added unit tests.  Removed old duplicate unit test entries.
3449         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
3450
3451 2010-12-20  David Levin  <levin@chromium.org>
3452
3453         Reviewed by Shinichiro Hamaji.
3454
3455         check-webkit-style should detect function declarations (and trivial functions).
3456         https://bugs.webkit.org/show_bug.cgi?id=51303
3457
3458         * Scripts/webkitpy/style/checkers/cpp.py:
3459         (_FunctionState.begin): Add is_declaration and changed the line count
3460         start to begin at -1 (which will keep the results consistent, since
3461         the starting line number passed in is one less in this change).
3462         (detect_functions): changed function detection to now catch trivial
3463         functions and declarations.
3464         (check_pass_ptr_usage): Don't check for Pass*Ptr on the first line
3465         of the function as this may look at return values (when processing
3466         a declaration).
3467         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3468         (FunctionDetectionTest.perform_function_detection): Basic mechanics
3469         of testing the function detection.
3470         (FunctionDetectionTest.test_basic_function_detection): Test a simple
3471         function.
3472         (FunctionDetectionTest.test_function_declaration_detection): Test a
3473         declaration.
3474         (FunctionDetectionTest.test_non_functions): A test case for a case
3475         that caused the code to fail due to the { being in quotes.
3476         (PassPtrTest.test_pass_ref_ptr_return_value): Added some more test
3477         cases to help catch false alarms for return values.
3478         (PassPtrTest.test_pass_ref_ptr_member_variable): Ensure that
3479         we don't get false alarms for member variables either.
3480
3481 2010-12-20  Ryuan Choi  <ryuan.choi@samsung.com>
3482
3483         Reviewed by Antonio Gomes.
3484
3485         [CMAKE] Rename WEBKITTOOLS_DIR to TOOLS_DIR
3486         https://bugs.webkit.org/show_bug.cgi?id=51319
3487
3488         * CMakeListsEfl.txt:
3489
3490 2010-12-18  Adam Barth  <abarth@webkit.org>
3491
3492         Reviewed by Sam Weinig.
3493
3494         Move WebKitExamplePlugins to Examples
3495         https://bugs.webkit.org/show_bug.cgi?id=51291
3496
3497         * Scripts/webkitpy/common/config/build.py:
3498
3499 2010-12-17  Csaba Osztrogonác  <ossy@webkit.org>
3500
3501         Unreviewed Qt buildfix after r74301.
3502
3503         Rename WebKitTools to Tools
3504         https://bugs.webkit.org/show_bug.cgi?id=49861
3505
3506         * MiniBrowser/DerivedSources.pro:
3507         * MiniBrowser/qt/MiniBrowser.pro:
3508
3509 2010-12-17  Dan Bernstein  <mitz@apple.com>
3510
3511         Reviewed by Simon Fraser.
3512
3513         Rename WebKitTools to Tools
3514         https://bugs.webkit.org/show_bug.cgi?id=49861
3515
3516         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3517         * CodeCoverage/README:
3518         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3519         (WebCore::DumpRenderTree::initializeFonts):
3520         * EWSTools/start-commit-queue.sh:
3521         * EWSTools/start-queue.sh:
3522         * GNUmakefile.am:
3523         * MIDLWrapper/MIDLWrapper.cpp:
3524         (wmain):
3525         * MiniBrowser/qt/MiniBrowser.pro:
3526         * Scripts/build-api-tests:
3527         * Scripts/build-dumprendertree:
3528         * Scripts/build-webkit:
3529         * Scripts/build-webkittestrunner:
3530         * Scripts/generate-coverage-data:
3531         * Scripts/old-run-webkit-tests:
3532         * Scripts/run-api-tests:
3533         * Scripts/run-iexploder-tests:
3534         * Scripts/run-javascriptcore-tests:
3535         * Scripts/run-mangleme-tests:
3536         * Scripts/run-sunspider:
3537         * Scripts/run-webkit-websocketserver:
3538         * Scripts/sunspider-compare-results:
3539         * Scripts/test-webkitperl:
3540         * Scripts/test-webkitpy:
3541         * Scripts/update-iexploder-cssproperties:
3542         * Scripts/update-webkit:
3543         * Scripts/update-webkit-localizable-strings:
3544         * Scripts/webkitdirs.pm:
3545         * Scripts/webkitpy/common/checkout/scm.py:
3546         * Scripts/webkitpy/common/checkout/scm_unittest.py:
3547         * Scripts/webkitpy/common/config/committervalidator.py:
3548         * Scripts/webkitpy/common/config/committervalidator_unittest.py:
3549         * Scripts/webkitpy/common/config/ports.py:
3550         * Scripts/webkitpy/common/config/ports_unittest.py:
3551         * Scripts/webkitpy/common/system/logutils_unittest.py:
3552         * Scripts/webkitpy/common/system/ospath_unittest.py:
3553         * Scripts/webkitpy/layout_tests/port/chromium.py:
3554         * Scripts/webkitpy/layout_tests/port/config.py:
3555         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
3556         * Scripts/webkitpy/layout_tests/port/http_server.py:
3557         * Scripts/webkitpy/layout_tests/port/test.py:
3558         * Scripts/webkitpy/style/checker.py:
3559         * Scripts/webkitpy/style/checker_unittest.py:
3560         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
3561         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3562         * Scripts/webkitpy/tool/steps/steps_unittest.py:
3563         * WebKitTestRunner/DerivedSources.pro:
3564         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
3565         (WTR::activateFonts):
3566         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3567         * wx/build/build_utils.py:
3568
3569 2010-12-16  Antonio Gomes  <agomes@rim.com>
3570
3571         Reviewed by Martin Robinson.
3572
3573         Settings::editingBehaviorType() incorrectly returns mac for the gtk build when running tests
3574         https://bugs.webkit.org/show_bug.cgi?id=51163
3575
3576         Since GTK+'s default editing behavior was changed to UNIX in r70975 (see webkitwebsettings.cpp),
3577         GTK+'s DRT should also reset to UNIX after each test execution.
3578
3579         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3580         (resetDefaultsToConsistentValues):
3581
3582 2010-12-17  David Levin  <levin@chromium.org>
3583
3584         Reviewed by Eric Seidel.
3585
3586         check-webkit-style should understand WTF #include guards
3587         https://bugs.webkit.org/show_bug.cgi?id=44911
3588
3589         * Scripts/webkitpy/style/checkers/cpp.py:
3590         (get_header_guard_cpp_variable): modify to suggest the WTF style
3591         of header guard when appropriate.
3592         (check_for_header_guard): handle multiple return values from
3593         get_header_guard_cpp_variable
3594         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3595         (CppStyleTest.test_build_header_guard): Added tests for the WTF
3596         header style.
3597
3598 2010-12-16  David Levin  <levin@chromium.org>
3599
3600         Reviewed by Eric Seidel.
3601
3602         test-webkitpy: unittest for the xml.py checker displays a decprecation warning.
3603         https://bugs.webkit.org/show_bug.cgi?id=51210
3604
3605         The error only shows up when using python 2.6 or later.
3606
3607         * Scripts/webkitpy/style/checkers/xml.py: Replace the usage of
3608         the decprecated field error,message with something equivalent.
3609
3610 2010-12-16  Mihai Parparita  <mihaip@chromium.org>
3611
3612         Reviewed by Eric Seidel.
3613
3614         Add --exit-after-n-failures/crashes to NRWT
3615         https://bugs.webkit.org/show_bug.cgi?id=51160
3616         
3617         Abort test run (in a similar way to how control-C is handled) when
3618         --exit-after-n-failures/crashes-or-timeouts are passed and we've reached
3619         that number of unexpected failures/crashes/timeouts.
3620
3621         * Scripts/webkitpy/layout_tests/port/test.py:
3622         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3623         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3624
3625 2010-12-16  David Levin  <levin@chromium.org>
3626
3627         Reviewed by Shinichiro Hamaji.
3628
3629         check-webkit-style unit tests has some duplicate boilerplate code.
3630         https://bugs.webkit.org/show_bug.cgi?id=49519
3631
3632         * Scripts/webkitpy/style/checkers/cpp.py:
3633         (update_include_state): Replaced the "io" parameter with the global
3634         configuration _unit_test_config. This allowed not calling into
3635         functions at a low level and also not plumbing through the injection
3636         information through many levels of code.
3637         (check_for_include_what_you_use): Ditto.
3638         (process_file_data): Added the ability to set up the unit test config
3639         to allow for injection.
3640         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3641         (ErrorCollector.__init__): Added support for having a filter for errors.
3642         (ErrorCollector.__call__): Ditto.
3643         (CppStyleTestBase.process_file_data): Added the ability to set unit_test_config.
3644         (CppStyleTestBase.perform_lint): Consolidated logic for the perform functions.
3645         (CppStyleTestBase.perform_single_line_lint): Replace specific calls to
3646         functions in the cpp.py with generic processing and a filter that
3647         indicates what errors should be kept.
3648         (CppStyleTestBase.perform_multi_line_lint): Ditto.
3649         (CppStyleTestBase.perform_language_rules_check): Ditto.
3650         (CppStyleTestBase.perform_function_lengths_check): Ditto.
3651         (CppStyleTestBase.perform_pass_ptr_check): Ditto.
3652         (CppStyleTestBase.perform_include_what_you_use): Ditto.
3653         (CppStyleTest.test_multi_line_comments): Added another
3654         error message which applies to the test case.
3655         (CppStyleTest.test_spacing_for_binary_ops): Fixed test
3656         to not have config.h, since it is processed as a header file.
3657         (CppStyleTest.test_static_or_global_stlstrings): Fixed variable name
3658         style and indentation in checked code.
3659         (OrderOfIncludesTest.test_check_preprocessor_in_include_section):
3660         Fixed line number.
3661         (NoNonVirtualDestructorsTest.test_multi_line_declaration_with_error):
3662         Ditto.
3663
3664 2010-12-15  Sheriff Bot  <webkit.review.bot@gmail.com>
3665
3666         Unreviewed, rolling out r74136.
3667         http://trac.webkit.org/changeset/74136
3668         https://bugs.webkit.org/show_bug.cgi?id=51135
3669
3670         r74136 breaks chromium canary bots because some tests are not
3671         rebaselined correctly to resolve EOL differences (Requested by
3672         jianli on #webkit).
3673
3674         * Scripts/webkitpy/layout_tests/port/base.py:
3675         * Scripts/webkitpy/layout_tests/port/test.py:
3676         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
3677
3678 2010-12-15  Adam Roben  <aroben@apple.com>
3679
3680         Teach check-webkit-style to check .vcproj and .vsprops files for XML
3681         syntax errors
3682
3683         Fixes <http://webkit.org/b/51103> check-webkit-style should check for
3684         XML syntax errors in .vcproj/.vsprops files
3685
3686         Reviewed by Dave Levin.
3687
3688         * Scripts/webkitpy/style/checker.py: Added lists of file extensions
3689         that should be treated as XML and that should be allowed to contain
3690         carriage returns. (These lists happen to be identical currently.)
3691         (FileType): Added a new XML type.
3692         (CheckerDispatcher.should_check_and_strip_carriage_returns): Added.
3693         Just does a simple file extension check.
3694         (CheckerDispatcher._file_type): Added a case for XML files.
3695         (CheckerDispatcher._create_checker): Ditto. We use XMLChecker for XML
3696         files (surprise!).
3697         (StyleProcessor.process): Ask the dispatcher whether we should pass the
3698         lines through the carriage checker.
3699
3700         * Scripts/webkitpy/style/checker_unittest.py:
3701         (CheckerDispatcherCarriageReturnTest.test_should_check_and_strip_carriage_returns):
3702         Added. Checks a few file names to see if carriage returns are allowed
3703         or not.
3704         (CheckerDispatcherDispatchTest.assert_checker_xml): Added. Similar to
3705         other assert_checker_* functions.
3706         (CheckerDispatcherDispatchTest.test_xml_paths): Added. Similar to other
3707         test_*_paths functions.
3708         (CheckerDispatcherDispatchTest.test_xml_paths): Added. Similar to other
3709         test_*_paths functions.
3710         (CheckerDispatcherDispatchTest.test_none_paths): Removed the vcproj
3711         file from this test case, as vcproj files now have a type.
3712         (StyleProcessor_CodeCoverageTest.MockDispatcher.should_check_and_strip_carriage_returns):
3713         Added. Similar to the other should_* functions.
3714         (StyleProcessor_CodeCoverageTest.test_process__carriage_returns_not_stripped):
3715         Added. Checks that carriage returns aren't checked for or stripped for
3716         allowed files.
3717
3718         * Scripts/webkitpy/style/checkers/xml.py: Added.
3719         (XMLChecker.__init__): Simple init method.
3720         (XMLChecker.check): Pass each line through the expat parser, and record
3721         a style error for any errors thrown by the parser.
3722
3723         * Scripts/webkitpy/style/checkers/xml_unittest.py: Added.
3724         (XMLCheckerTest.assert_no_error): Checks that the given XML does not
3725         produce a style error.
3726         (XMLCheckerTest.assert_error): Checks that the given XML produces an
3727         error of the given category on the given line.
3728         (XMLCheckerTest.mock_handle_style_error): Does nothing. Used for
3729         checking that the XMLChecker constructor works properly.
3730         (XMLCheckerTest.test_conflict_marker): Tests that conflict markers
3731         cause a style error (see, e.g., r73887).
3732         (XMLCheckerTest.test_extra_closing_tag): Tests that extra closing tags
3733         cause a style error (see, e.g., r73773).
3734         (XMLCheckerTest.test_init): Tests that the XMLChecker constructor works
3735         properly.
3736         (XMLCheckerTest.test_missing_closing_tag): Tests that missing closing
3737         tags cause a style error (see, e.g., r72795).
3738         (XMLCheckerTest.test_no_error): Tests that valid XML does not cause a
3739         style error.
3740
3741 2010-12-15  Lucas Forschler  <lforschler@apple.com>
3742
3743         Reviewed by Stephanie Lewis.
3744
3745         https://bugs.webkit.org/show_bug.cgi?id=51117
3746         Add a new leopard test bot
3747         really really commit to trunk this time.
3748
3749         * BuildSlaveSupport/build.webkit.org-config/config.json:
3750
3751 2010-12-15  Sam Weinig  <sam@webkit.org>
3752
3753         Reviewed by Anders Carlsson.
3754
3755         WebKit2: Can't add files to an <input type=file>
3756         https://bugs.webkit.org/show_bug.cgi?id=51087
3757
3758         * MiniBrowser/mac/BrowserWindowController.m:
3759         (runOpenPanel):
3760         (-[BrowserWindowController awakeFromNib]):
3761         Add simple implementation of runOpenPanel callback.
3762
3763         * MiniBrowser/win/BrowserView.cpp:
3764