Tools/ChangeLog

   1 2011-01-19  James Robinson  <jamesr@chromium.org>
   2
   3         Unreviewed, rolling out r76194.
   4         http://trac.webkit.org/changeset/76194
   5         https://bugs.webkit.org/show_bug.cgi?id=51218
   6
   7         Caused mysterious compile failure on the chromium win
   8         build.webkit.org bots
   9
  10         * DumpRenderTree/chromium/WebViewHost.cpp:
  11         (WebViewHost::paintInvalidatedRegion):
  12         * DumpRenderTree/chromium/WebViewHost.h:
  13
  14 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
  15
  16         Reviewed by Mihai Parparita.
  17
  18         remove fs refs from test_runner, dump_render_tree_thread
  19
  20         https://bugs.webkit.org/show_bug.cgi?id=52753
  21
  22         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
  23         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
  24         * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
  25         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
  26
  27 2011-01-19  James Robinson  <jamesr@chromium.org>
  28
  29         Reviewed by Darin Fisher.
  30
  31         Implement mozilla's requestAnimationFrame API
  32         https://bugs.webkit.org/show_bug.cgi?id=51218
  33
  34         Chromium DumpRenderTree support for window.webkitRequestAnimationFrame.
  35
  36         * DumpRenderTree/chromium/WebViewHost.cpp:
  37         (invokeScheduleComposite):
  38         (WebViewHost::scheduleAnimation):
  39         (WebViewHost::paintInvalidatedRegion):
  40         * DumpRenderTree/chromium/WebViewHost.h:
  41
  42 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
  43
  44         Unreviewed, build fix.
  45
  46         Fix a few incorrect "self._filesystem" references introduced in
  47         r76184.
  48
  49         * Scripts/webkitpy/layout_tests/port/chromium.py:
  50         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
  51
  52 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
  53
  54         Reviewed by Mihai Parparita.
  55
  56         add a .sep property, abspath(), isabs(), mtime(), and
  57         open_text_file_for_writing() to filesystem modules. Some of
  58         these properties are not needed in this patch but will be needed
  59         in subsequent patches (I'm doing this to avoid having to track
  60         multiple versions of a single file).
  61
  62         Also, change most of the port/* modules to use the filesystem
  63         objects instead of referencing the filesystem directly.
  64
  65         https://bugs.webkit.org/show_bug.cgi?id=52748
  66
  67         * Scripts/webkitpy/common/system/filesystem.py:
  68         * Scripts/webkitpy/common/system/filesystem_mock.py:
  69         * Scripts/webkitpy/layout_tests/port/__init__.py:
  70         * Scripts/webkitpy/layout_tests/port/base.py:
  71         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
  72         * Scripts/webkitpy/layout_tests/port/chromium.py:
  73         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
  74         * Scripts/webkitpy/layout_tests/port/config.py:
  75         * Scripts/webkitpy/layout_tests/port/test.py:
  76         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
  77
  78 2011-01-19  Maciej Stachowiak  <mjs@apple.com>
  79
  80         Reviewed by Anders Carlsson.
  81
  82         If resetting between tests times out, treat it as a WebProcess crash
  83         https://bugs.webkit.org/show_bug.cgi?id=52757
  84
  85         * WebKitTestRunner/TestController.cpp:
  86         (WTR::TestController::runTest):
  87
  88 2011-01-19  Alexey Proskuryakov  <ap@apple.com>
  89
  90         Reviewed by Darin Adler.
  91
  92         https://bugs.webkit.org/show_bug.cgi?id=52739
  93         Make it possible for a WebKit2 client to print headers and footers
  94
  95         Added dummy implementations for new printing UIClient calls.
  96
  97         * MiniBrowser/mac/BrowserWindowController.m:
  98         (-[BrowserWindowController awakeFromNib]):
  99         * WebKitTestRunner/TestController.cpp:
 100         (WTR::createOtherPage):
 101         (WTR::TestController::initialize):
 102
 103 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
 104
 105         Reviewed by Ojan Vafai.
 106
 107         Change webkitpy/layout_tests/port/test.py to use the
 108         in-memory filesystem for cleaner unit testing. This
 109         change allows us to kill a lot of code that was
 110         specific to the test port, at the cost of being a
 111         little less clear about how things would work if
 112         you didn't have a filesystem.
 113
 114         https://bugs.webkit.org/show_bug.cgi?id=52605
 115
 116         * Scripts/webkitpy/layout_tests/port/test.py:
 117
 118 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
 119
 120         Unreviewed, build fix.
 121
 122         Fix test failure caused by committing attachment 79368 instead
 123         of attachment 79461 on bug 52604.
 124
 125         * Scripts/webkitpy/common/system/filesystem_mock.py:
 126
 127 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
 128
 129         Reviewed by Mihai Parparita.
 130
 131         new-run-webkit-tests: remove use of os.walk, use mock filesystem for better
 132         unit testing. os.walk() is too much of a hassle to implement on
 133         top of the in-memory mock filesystem and adding the necessary
 134         interface to files_under() gives clients a cleaner API anyway
 135         (for this particular usage model).
 136
 137         https://bugs.webkit.org/show_bug.cgi?id=52691
 138
 139         * Scripts/webkitpy/common/system/filesystem.py:
 140         * Scripts/webkitpy/common/system/filesystem_mock.py:
 141         * Scripts/webkitpy/layout_tests/port/test_files.py:
 142         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
 143
 144 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
 145
 146         Reviewed by Tony Chang.
 147
 148         Change more modules in the layout-tests code to use the
 149         filesystem wrapper for cleaner unit testing.
 150
 151         This patch also adds the glob() wrapper to the filesystem
 152         abstraction.
 153
 154         https://bugs.webkit.org/show_bug.cgi?id=52604
 155
 156         * Scripts/webkitpy/layout_tests/port/test_files.py:
 157         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
 158         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
 159         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
 160         * Scripts/webkitpy/common/system/filesystem.py:
 161         * Scripts/webkitpy/common/system/filesystem_mock.py:
 162
 163 2011-01-19  Levi Weintraub  <leviw@chromium.org>
 164
 165         Unreviewed.
 166
 167         Updating my email addresses and irc nick.
 168
 169         * Scripts/webkitpy/common/config/committers.py:
 170
 171 2011-01-19  Tony Chang  <tony@chromium.org>
 172
 173         Reviewed by Mihai Parparita.
 174
 175         [chromium] [linux] if check-sys-deps fails, output the failure reason
 176         https://bugs.webkit.org/show_bug.cgi?id=52671
 177
 178         * Scripts/webkitpy/common/system/executive_mock.py: Add support for
 179             error handler functions.
 180         * Scripts/webkitpy/layout_tests/port/chromium.py:
 181             output the error text from --check-sys-deps
 182         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
 183
 184 2011-01-19  Aparna Nandyal  <aparna.nand@wipro.com>
 185
 186         Reviewed by Andreas Kling.
 187
 188         [Qt] QtTestBrowser crashes when closing if Facebook is opened
 189         https://bugs.webkit.org/show_bug.cgi?id=52554
 190
 191         QtNetworkAccessManager is created in a thread and set as
 192         member variable in QWebPage. When the thread is destroyed
 193         the object is still used. So fix will set the object to
 194         NULL once the thread is destroyed.
 195
 196         * QtTestBrowser/launcherwindow.cpp:
 197         (LauncherWindow::~LauncherWindow):
 198
 199 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
 200
 201         Rubber stamped by Csaba Osztrogonac
 202
 203         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: Removed unncessary inculde of WKStringCF.h
 204
 205 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
 206
 207         Reviewed by Tony Chang.
 208
 209         new-run-webkit-tests: add a --build-directory command line argument
 210
 211         Official Google Chrome builds use a non-standard build directory
 212         location. This patch adds a --build-directory argument that
 213         allows that location to be specified on the command line. Only
 214         Chromium-based builds will use this flag for now, but anyone can
 215         in the future.
 216
 217         There are no unit tests for this since it's difficult to test
 218         until mock filesystems are fully supported in the code. This was
 219         tested by hand for now.
 220
 221         https://bugs.webkit.org/show_bug.cgi?id=52694
 222
 223         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
 224         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
 225         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
 226         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
 227
 228 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
 229
 230         Not reviewed. Bot fix.
 231
 232         Remove an inadvertently committed debugging print.
 233
 234         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
 235         (LayoutTestController::notifyDone):
 236
 237 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
 238
 239         Reviewed by Sam Weinig.
 240
 241         WebKitTestRunner should track loading more like DumpRenderTree
 242         https://bugs.webkit.org/show_bug.cgi?id=52692
 243
 244         Change load tracking to track the current top loading frame, in the manner of DumpRenderTree.
 245         This makes some tests that call notifyDone multiple times pass.
 246
 247         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
 248         (WTR::InjectedBundle::InjectedBundle):
 249         (WTR::InjectedBundle::done):
 250         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
 251         (WTR::InjectedBundle::topLoadingFrame):
 252         (WTR::InjectedBundle::setTopLoadingFrame):
 253         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
 254         (WTR::InjectedBundlePage::InjectedBundlePage):
 255         (WTR::InjectedBundlePage::stopLoading):
 256         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
 257         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
 258         (WTR::InjectedBundlePage::didFinishLoadForFrame):
 259         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
 260         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
 261         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
 262         (WTR::LayoutTestController::notifyDone):
 263         * WebKitTestRunner/TestController.cpp:
 264         (WTR::TestController::didReceiveMessageFromInjectedBundle):
 265
 266 2011-01-18  Mihai Parparita  <mihaip@chromium.org>
 267
 268         Reviewed by Kent Tamura.
 269
 270         [Chromium] NRWT looking for DRT binary in the wrong path on Mac
 271         https://bugs.webkit.org/show_bug.cgi?id=52678
 272
 273         Update path now that WebKit is inside Source.
 274
 275         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
 276
 277 2011-01-18  Robert Hogan  <robert@webkit.org>
 278
 279         Reviewed by Simon Hausmann.
 280
 281         [Qt] http/tests/incremental/slow-utf8-text.pl fails
 282         https://bugs.webkit.org/show_bug.cgi?id=44282
 283
 284         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
 285         (WebCore::DumpRenderTree::dump):
 286
 287 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
 288
 289         Reviewed by Mihai Parparita.
 290
 291         Fix a small race condition that could cause the unit tests for
 292         new-run-webkit-tests to fail in a multithreaded environment.
 293         There was a small window in the code where one thread would
 294         check to see if a thread had raised an exception, do something,
 295         and then check to see if the thread was alive. If the other
 296         thread raised an exception and exited in between these two
 297         steps, the exception would be lost. Flipping the order of the
 298         two checks fixes the race, since we will now always check for an
 299         exception on the thread before exiting.
 300
 301         https://bugs.webkit.org/show_bug.cgi?id=51579
 302
 303         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
 304
 305 2011-01-18  Eric Seidel  <eric@webkit.org>
 306
 307         Reviewed by Adam Barth.
 308
 309         commit-queue dies when test archiving fails
 310         https://bugs.webkit.org/show_bug.cgi?id=52617
 311
 312         I looked at the machine and it had 10 archives already
 313         thus find_unused_name was returning None.  I've upped
 314         the limit to 100 (per bug) and tested the case where
 315         find_unused_name returns None (making archive return None).
 316
 317         * Scripts/webkitpy/common/system/workspace.py:
 318         * Scripts/webkitpy/common/system/workspace_unittest.py:
 319         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
 320         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
 321         * Scripts/webkitpy/tool/commands/queues.py:
 322
 323 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
 324
 325         Reviewed by Ojan Vafai.
 326
 327         Update rebaseline-chromium-webkit-tests unit tests to use a mock
 328         filesystem. Also fix a couple of "with" statements missed by
 329         r76050.
 330
 331         https://bugs.webkit.org/show_bug.cgi?id=52487
 332
 333         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
 334
 335 2011-01-18  Sergio Villar Senin  <svillar@igalia.com>
 336
 337         Reviewed by Martin Robinson.
 338
 339         [Gtk] Build fixes for gtk3 build
 340         https://bugs.webkit.org/show_bug.cgi?id=52648
 341
 342         * DumpRenderTree/gtk/EventSender.cpp:
 343         (beginDragWithFilesCallback):
 344
 345 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
 346
 347         Reviewed by Mihai Parparita.
 348
 349         Update rebaseline-chromium-webkit-tests to use filesystem objects
 350         instead of direct references to os.path, shutil, tempfile, etc.
 351
 352         This patch doesn't change anything, but will allow subsequent
 353         patches to change the unit tests to no longer use the real
 354         filesystem.
 355
 356         This patch adds a bunch more methods to the filesystem object as
 357         well.
 358
 359         https://bugs.webkit.org/show_bug.cgi?id=52482
 360
 361         * Scripts/webkitpy/common/system/filesystem.py:
 362         * Scripts/webkitpy/common/system/filesystem_mock.py:
 363         * Scripts/webkitpy/tool/commands/queues.py:
 364         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
 365         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
 366
 367 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
 368
 369         Reviewed by Mihai Parparita.
 370
 371         new-run-webkit-tests shouldn't crash when you try to run a
 372         directory containing only skipped files.
 373
 374         https://bugs.webkit.org/show_bug.cgi?id=52478
 375
 376         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
 377         * Scripts/webkitpy/layout_tests/port/test.py:
 378         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
 379
 380 2011-01-18  Adam Bergkvist  <adam.bergkvist@ericsson.com> and Martin Robinson  <mrobinson@igalia.com>
 381
 382         Reviewed by Gustavo Noronha Silva.
 383
 384         [GTK] The GTK+ EventSender needs support for beginDragWithFiles
 385         https://bugs.webkit.org/show_bug.cgi?id=40833
 386
 387         * DumpRenderTree/gtk/EventSender.cpp: Add a beginDragWithFiles implementation for the
 388         GTK+ event sender.
 389         (dragWithFilesDragDataGetCallback): Added.
 390         (dragWithFilesDragEndCallback): Added.
 391         (beginDragWithFilesCallback): Added.
 392
 393 2011-01-18  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
 394
 395         Reviewed by Adam Barth.
 396
 397         ews: Add additional watcher to efl ews
 398         https://bugs.webkit.org/show_bug.cgi?id=52613
 399
 400         Add gyuyoung.kim@samsung.com to watcher list of efl-ews.
 401
 402         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
 403
 404 2011-01-17  Tony Gentilcore  <tonyg@chromium.org>
 405
 406         Reviewed by Alexey Proskuryakov.
 407
 408         Fix some headers with missing or misspelled #ifndef guards
 409         https://bugs.webkit.org/show_bug.cgi?id=52545
 410
 411         * DumpRenderTree/chromium/TestEventPrinter.h:
 412         * DumpRenderTree/chromium/WebPreferences.h:
 413
 414 2011-01-17  Jessie Berlin  <jberlin@apple.com>
 415
 416         Reviewed by Anders Carlsson.
 417
 418         REGRESSION: Assertion failure in FrameLoader::continueLoadAfterWillSubmitForm() when
 419         navigating back to an unreachable URL
 420         https://bugs.webkit.org/show_bug.cgi?id=52388
 421
 422         Add a third parameter (unreachableURL) to queueLoadHTMLString.
 423
 424         * DumpRenderTree/LayoutTestController.cpp:
 425         (queueLoadHTMLStringCallback):
 426         (LayoutTestController::queueLoadHTMLString):
 427         (LayoutTestController::queueLoadAlternateHTMLString):
 428         * DumpRenderTree/LayoutTestController.h:
 429
 430         * DumpRenderTree/WorkQueueItem.h:
 431         (LoadHTMLStringItem::LoadHTMLStringItem):
 432
 433         * DumpRenderTree/chromium/LayoutTestController.cpp:
 434         (WorkItemLoadHTMLString::WorkItemLoadHTMLString):
 435         (WorkItemLoadHTMLString::run):
 436         (LayoutTestController::queueLoadHTMLString):
 437
 438         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
 439         (LoadHTMLStringItem::invoke):
 440         * DumpRenderTree/mac/WorkQueueItemMac.mm:
 441         (LoadHTMLStringItem::invoke):
 442         * DumpRenderTree/win/WorkQueueItemWin.cpp:
 443         (LoadHTMLStringItem::invoke):
 444
 445 2011-01-17  Dan Bernstein  <mitz@apple.com>
 446
 447         Rubber-stamped by Mark Rowe.
 448
 449         Update xcodeproj svn:ignore to include xcuserdata.
 450
 451         * DumpRenderTree/DumpRenderTree.xcodeproj: Modified property svn:ignore.
 452         * MiniBrowser/MiniBrowser.xcodeproj: Modified property svn:ignore.
 453         * TestWebKitAPI/TestWebKitAPI.xcodeproj: Modified property svn:ignore.
 454         * WebKitLauncher/WebKitLauncher.xcodeproj: Modified property svn:ignore.
 455         * WebKitTestRunner/WebKitTestRunner.xcodeproj: Modified property svn:ignore.
 456
 457 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
 458
 459         Unreviewed fix after r75908.
 460
 461         Move WebKit into Source
 462         https://bugs.webkit.org/show_bug.cgi?id=52530
 463
 464         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add Source to the path for Qt API tests.
 465
 466 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
 467
 468         Unreviewed.
 469
 470         Remove accidentally committed debug printing after r75908.
 471
 472         * Scripts/webkitdirs.pm:
 473
 474 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
 475
 476         Unreviewed.
 477
 478         Add myself to committers list
 479         https://bugs.webkit.org/show_bug.cgi?id=52566
 480
 481         * Scripts/webkitpy/common/config/committers.py:
 482
 483 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
 484
 485         Reviewed by Jeremy Orlow.
 486
 487         GeolocationController should call stopUpdating on destruction
 488         https://bugs.webkit.org/show_bug.cgi?id=52216
 489
 490         fast/dom/Geolocation/window-close-crash.html requires that a
 491         Geolocation watch be started in a secondary window. Consequently,
 492         we need to allow geolocation permission and provide a mock
 493         geolocation position for the secondary window's
 494         GeolocationClientMock.
 495
 496         * DumpRenderTree/chromium/LayoutTestController.cpp:
 497         (LayoutTestController::setGeolocationPermission):
 498         (LayoutTestController::setMockGeolocationPosition):
 499         (LayoutTestController::setMockGeolocationError):
 500         * DumpRenderTree/chromium/TestShell.h:
 501         (TestShell::windowList):
 502
 503 2011-01-16  Adam Barth  <abarth@webkit.org>
 504
 505         Update more include paths to reflect WebKit move.
 506
 507         * DumpRenderTree/chromium/EventSender.cpp:
 508         (EventSender::keyDown):
 509         (EventSender::needsShiftModifier):
 510         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
 511         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
 512
 513 2011-01-16  Kent Tamura  <tkent@chromium.org>
 514
 515         Unreviewed, Chromium build fix.
 516
 517         * Scripts/update-webkit-chromium: Webkit/chromium -> Source/WebKit/chromium
 518
 519 2011-01-16  Martin Robinson  <mrobinson@igalia.com>
 520
 521         Build fix for GTK+ after source directory movement.
 522
 523         * GNUmakefile.am: Correct include paths.
 524
 525 2011-01-16  Adam Barth  <abarth@webkit.org>
 526
 527         Teach svn-apply about WebKit move.
 528
 529         * Scripts/VCSUtils.pm:
 530
 531 2011-01-16  Adam Barth  <abarth@webkit.org>
 532
 533         Rubber-stamped by Eric Seidel.
 534
 535         Move WebKit into Source
 536         https://bugs.webkit.org/show_bug.cgi?id=52530
 537
 538         * DumpRenderTree/mac/InternalHeaders/WebKit/WebTypesInternal.h:
 539         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
 540         * DumpRenderTree/qt/DumpRenderTreeQt.h:
 541         * DumpRenderTree/qt/GCControllerQt.cpp:
 542         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
 543         * DumpRenderTree/qt/PlainTextControllerQt.cpp:
 544         * DumpRenderTree/qt/TextInputControllerQt.cpp:
 545         * DumpRenderTree/wscript:
 546         * QtTestBrowser/launcherwindow.h:
 547         * Scripts/build-webkit:
 548         * Scripts/webkitdirs.pm:
 549
 550 2011-01-15  Adam Barth  <abarth@webkit.org>
 551
 552         Teach svn-apply about WebKit2 move.
 553
 554         * Scripts/VCSUtils.pm:
 555
 556 2011-01-15  Adam Barth  <abarth@webkit.org>
 557
 558         Rubber-stamped by Eric Seidel.
 559
 560         Move WebKit2 into Source
 561         https://bugs.webkit.org/show_bug.cgi?id=52438
 562
 563         * MiniBrowser/qt/MiniBrowser.pro:
 564         * Scripts/build-webkit:
 565         * Scripts/do-file-rename:
 566         * Scripts/do-webcore-rename:
 567         * Scripts/test-webkitpy:
 568         * Scripts/webkitdirs.pm:
 569         * Scripts/webkitpy/style/checker.py:
 570         * WebKitTestRunner/DerivedSources.pro:
 571         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
 572         * WebKitTestRunner/qt/WebKitTestRunner.pro:
 573
 574 2011-01-15  Jochen Eisinger  <jochen@chromium.org>
 575
 576         Reviewed by David Levin.
 577
 578         [chromium] remove obsolete createView method
 579         https://bugs.webkit.org/show_bug.cgi?id=52437
 580
 581         * DumpRenderTree/chromium/WebViewHost.cpp:
 582         (WebViewHost::createView):
 583         * DumpRenderTree/chromium/WebViewHost.h:
 584
 585 2011-01-14  Brian Weinstein  <bweinstein@apple.com>
 586
 587         Reviewed by Geoff Garen.
 588
 589         ShouldLoadResourceForFrame should use strings, not URLs.
 590         https://bugs.webkit.org/show_bug.cgi?id=52476
 591
 592         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
 593         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Update to use a WKStringRef.
 594         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
 595
 596 2011-01-14  Tony Gentilcore  <tonyg@chromium.org>
 597
 598         Reviewed by David Levin.
 599
 600         Add Tony Gentilcore as a reviewer
 601         https://bugs.webkit.org/show_bug.cgi?id=52480
 602
 603         * Scripts/webkitpy/common/config/committers.py:
 604
 605 2011-01-14  David Levin  <levin@chromium.org>
 606
 607         Reviewed by Eric Seidel.
 608
 609         check-webkit-style: _FunctionState should keep track of where the function name starts.
 610         https://bugs.webkit.org/show_bug.cgi?id=52454
 611
 612         * Scripts/webkitpy/style/checkers/cpp.py: Added function_name_start_position to
 613         _FunctionState and logic for setting it correctly.
 614         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests.
 615
 616 2011-01-14  Vincent Scheib  <scheib@chromium.org>
 617
 618         Reviewed by David Levin.
 619
 620         Add support to DumpRenderTree to use the GPU rather than software renderer
 621         https://bugs.webkit.org/show_bug.cgi?id=52333
 622
 623         * DumpRenderTree/chromium/DumpRenderTree.cpp:
 624         (main):
 625         * Scripts/webkitpy/layout_tests/port/chromium.py:
 626         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
 627
 628 2011-01-14  Tony Chang  <tony@chromium.org>
 629
 630         Reviewed by Kent Tamura.
 631
 632         [chromium] update fonts.conf to fix 6 linux tests in drt
 633         https://bugs.webkit.org/show_bug.cgi?id=52411
 634
 635         * DumpRenderTree/chromium/fonts.conf: Update to match the copy in
 636             chromium's src/webkit/tools/test_shell/resources/fonts.conf
 637
 638 2011-01-14  Eric Seidel  <eric@webkit.org>
 639
 640         Original patch from Peter Gal  <galpater@inf.u-szeged.hu>
 641
 642         Reviewed by Adam Barth.
 643
 644         Fix when running Tools/Scripts/check-webkit-style without arguments.
 645         https://bugs.webkit.org/show_bug.cgi?id=52261#c16
 646
 647         * Scripts/webkitpy/common/checkout/scm.py: Handle None for changed_files argument better in Git.create_patch method.
 648         * Scripts/webkitpy/common/checkout/scm_unittest.py:
 649
 650 2011-01-04  Jochen Eisinger  <jochen@chromium.org>
 651
 652         Reviewed by David Levin.
 653
 654         Store the tempdir object in a variable so it doesn't get deleted too early.
 655         https://bugs.webkit.org/show_bug.cgi?id=51875
 656
 657         * Scripts/update-webkit-auxiliary-libs:
 658         * Scripts/update-webkit-support-libs:
 659
 660 2011-01-14  Eric Seidel  <eric@webkit.org>
 661
 662         Unreviewed.  Make it work in python 2.5.
 663
 664         webkit-patch suggest-reviewers dies when ChangeLogs are missing
 665         https://bugs.webkit.org/show_bug.cgi?id=49158
 666
 667         * Scripts/webkitpy/common/checkout/api_unittest.py:
 668
 669 2011-01-14  Sheriff Bot  <webkit.review.bot@gmail.com>
 670
 671         Unreviewed, rolling out r75774.
 672         http://trac.webkit.org/changeset/75774
 673         https://bugs.webkit.org/show_bug.cgi?id=52431
 674
 675         gtk builds were broken (Requested by loislo2 on #webkit).
 676
 677         * Scripts/webkitpy/common/checkout/scm.py:
 678
 679 2011-01-14  David Levin  <levin@chromium.org>
 680
 681         Reviewed by Shinichiro Hamaji.
 682
 683         check-webkit-style: _FunctionState should detect pure functions.
 684         https://bugs.webkit.org/show_bug.cgi?id=52428
 685
 686         * Scripts/webkitpy/style/checkers/cpp.py: Added detection for if a function declaration
 687         is a pure virtual function.
 688         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests for verifying that pure
 689         virtual functions are correctly detected.
 690
 691 2011-01-13  Ilya Tikhonovsky  <loislo@chromium.org>
 692
 693         Reviewed by Yury Semikhatsky.
 694
 695         Just small fix for problem with check-webkit-style.
 696         It just didn't work for this patch.
 697         Old code can't concatenate a list of strings with None.
 698
 699         * Scripts/webkitpy/common/checkout/scm.py:
 700
 701 2011-01-13  David Levin  <levin@chromium.org>
 702
 703         Reviewed by Shinichiro Hamaji.
 704
 705         check-webkit-style: _FunctionState should use Position to know where items are.
 706         https://bugs.webkit.org/show_bug.cgi?id=52424
 707
 708         * Scripts/webkitpy/style/checkers/cpp.py:
 709         (_FunctionState.*): Changed _FunctionState to use Position instead of line numbers.
 710         (detect_functions): Changed to pass Position's to _FunctionState.begin and
 711         did some minor clean-up.
 712         (*): Other changes are simply about converting to use the Position's in_FunctionState
 713         instead of line numbers.
 714         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Changed the test code
 715         to verify the positions stored in _FunctionState.
 716
 717 2011-01-13  Eric Seidel  <eric@webkit.org>
 718
 719         Reviewed by David Levin.
 720
 721         webkit-patch suggest-reviewers dies when ChangeLogs are missing
 722         https://bugs.webkit.org/show_bug.cgi?id=49158
 723
 724         This is not the most elegant, but it is a very safe fix to this bug.
 725         One advantage of catching ScriptError like this instead of adding a
 726         new added_or_modified_files or fixing all changed_files callers
 727         to use a more specific change_files variant, is that we catch
 728         all kinds of ScriptErrors which might cause our (non-essential)
 729         suggest-reviewers code to fail out.  This should make passing
 730         --suggest-reviewers to webkit-patch upload much more robust
 731         and may even make it possible for us to make it default.
 732
 733         The root of the problem here is that SCM.changed_files includes
 734         deleted ChangeLog paths (from moves, etc) which then when we ask
 735         SVN/Git for the contents of the file at that revision, the command
 736         errors out and Executive.run_command raises a ScriptError.
 737
 738         In the future we might fix this differently by making all current
 739         callers of chagned_files use a more specific method for requesting
 740         what types of changes they're interested in (adds, modifies, deletes, etc.)
 741
 742         * Scripts/webkitpy/common/checkout/api.py:
 743         * Scripts/webkitpy/common/checkout/api_unittest.py:
 744
 745 2011-01-13  Dan Bernstein  <mitz@apple.com>
 746
 747         Reviewed by Alexey Proskuryakov.
 748
 749         <rdar://problem/8827065> REGRESSION (r71884): Cross-origin XHR fails if willSendRequest changes the URL
 750         https://bugs.webkit.org/show_bug.cgi?id=52419
 751
 752         Allow to further control the behavior of the willSendRequest delegate callback by making it
 753         set a different URL in the new request.
 754
 755         * DumpRenderTree/LayoutTestController.cpp:
 756         (addURLToRedirectCallback): Added.
 757         (LayoutTestController::staticFunctions): Added addURLToRedirect.
 758         (LayoutTestController::addURLToRedirect): Added. Adds the redirection to the map.
 759         (LayoutTestController::redirectionDestinationForURL): Added this getter.
 760         * DumpRenderTree/LayoutTestController.h:
 761         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
 762         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]): Check
 763         if there is a redirection for the request’s URL, established by addURLToRedirect(), and if so,
 764         change the URL in the new request to the redirect destination.
 765
 766 2011-01-13  Eric Seidel  <eric@webkit.org>
 767
 768         Reviewed by Mihai Parparita.
 769
 770         webkit-patch suggest-reviewers fails due to invalid utf8 in ChangeLog files
 771         https://bugs.webkit.org/show_bug.cgi?id=52416
 772
 773         Example: webkit-patch suggest-reviewers -g ca3890fe74d94d85d6bfa48f9ea497b094d8e717
 774         UnicodeDecodeError: 'utf8' codec can't decode bytes in position 536-538: invalid data
 775
 776         I also added FIXMEs about the changed_files returning deleted files problem
 777         which is causing the other most common exception for suggest-reviewers
 778         (and is probably breaking sheriff-bots blame detection).
 779
 780         * Scripts/webkitpy/common/checkout/api.py:
 781         * Scripts/webkitpy/common/checkout/api_unittest.py:
 782         * Scripts/webkitpy/common/checkout/scm.py:
 783
 784 2011-01-13  Eric Seidel  <eric@webkit.org>
 785
 786         Reviewed by Adam Barth.
 787
 788         results archives from commit-queue are too large to upload
 789         https://bugs.webkit.org/show_bug.cgi?id=52405
 790
 791         * Scripts/webkitpy/common/system/filesystem.py:
 792         * Scripts/webkitpy/common/system/filesystem_mock.py:
 793         * Scripts/webkitpy/tool/commands/queues.py:
 794
 795 2011-01-13  Alejandro G. Castro  <alex@igalia.com>
 796
 797         Reviewed by Martin Robinson.
 798
 799         [gtk] Zero-sized font does not yet work
 800         https://bugs.webkit.org/show_bug.cgi?id=49793
 801
 802         Set minimum-font-size to 0 for the DRT.
 803
 804         * DumpRenderTree/gtk/DumpRenderTree.cpp:
 805         (resetDefaultsToConsistentValues):
 806
 807 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
 808
 809         Reviewed by Darin Adler.
 810
 811         Make old-run-webkit-tests more robust on buildbots
 812         https://bugs.webkit.org/show_bug.cgi?id=52364
 813
 814         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Pass --exit-after-n-failures 500 to old-run-webkit-tests script.
 815
 816 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
 817
 818         Reviewed by Darin Adler.
 819
 820         Make old-run-webkit-tests more robust on buildbots
 821         https://bugs.webkit.org/show_bug.cgi?id=52364
 822
 823         * Scripts/old-run-webkit-tests: Ensure that testResultsDirectory is empty.
 824
 825 2011-01-13  Tony Chang  <tony@chromium.org>
 826
 827         Reviewed by Kent Tamura.
 828
 829         [chromium] fix plugins/plugin-javascript-access.html on Linux and Mac
 830         https://bugs.webkit.org/show_bug.cgi?id=52332
 831
 832         Forked Info.plist is not longer needed.
 833
 834         * DumpRenderTree/chromium/TestNetscapePlugIn/Info.plist: Removed.
 835
 836 2011-01-13  Mikhail Naganov  <mnaganov@chromium.org>
 837
 838         Reviewed by Timothy Hatcher.
 839
 840         Web Inspector: Cleanup after r75613 -- make all UI-facing strings
 841         to be passed directly to WebInspector.UIString
 842
 843         https://bugs.webkit.org/show_bug.cgi?id=52365
 844
 845         * Scripts/check-inspector-strings:
 846
 847 2011-01-13  Sheriff Bot  <webkit.review.bot@gmail.com>
 848
 849         Unreviewed, rolling out r74881.
 850         http://trac.webkit.org/changeset/74881
 851         https://bugs.webkit.org/show_bug.cgi?id=52357
 852
 853         The EFL builder has been red for days (Requested by abarth on
 854         #webkit).
 855
 856         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
 857         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
 858
 859 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
 860
 861         Reviewed by David Levin.
 862
 863         Add beforeunload support to WebKitTestRunner
 864         https://bugs.webkit.org/show_bug.cgi?id=52353
 865
 866         This makes a number of currently failing tests pass.
 867
 868         * WebKitTestRunner/TestController.cpp:
 869         (WTR::runBeforeUnloadConfirmPanel):
 870         (WTR::createOtherPage):
 871         (WTR::TestController::initialize):
 872
 873 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
 874
 875         Reviewed by Sam Weinig.
 876
 877         Detect, identify and recover from WebProcess crashes in run-webkit-tests
 878         https://bugs.webkit.org/show_bug.cgi?id=52330
 879
 880         * Scripts/old-run-webkit-tests: Detect when the regression test tool reports
 881         a web process crash.
 882         * WebKitTestRunner/TestController.cpp:
 883         (WTR::TestController::initialize): Set up a processDidCrash
 884         callback.
 885         (WTR::TestController::processDidCrash): Report that the Web process
 886         crashed.
 887         * WebKitTestRunner/TestController.h:
 888
 889 2011-01-12  David Levin  <levin@chromium.org>
 890
 891         Reviewed by Shinichiro Hamaji.
 892
 893         check-webkit-style -- close_expression function doesn't work correctly.
 894         https://bugs.webkit.org/show_bug.cgi?id=52272
 895
 896         * Scripts/webkitpy/style/checkers/cpp.py:
 897         (Position.__str__): Added a way to convert it to a string which is useful in tests.
 898         (Position.__cmp__): Added a way to compare Position which is useful in tests and
 899         generally useful (for upcoming code changes).
 900         (close_expression): Changed to use Position for input and output.
 901         Also, fixed many bugs such as only working correctly for parenthesis,
 902         not working correctly if given an offset in a line and not finding
 903         the real closing element if there were multiple closing elements in
 904         the same line.
 905         (detect_functions): Adjusted due to the change in arguments for
 906         close_expression.
 907         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
 908         (CppStyleTestBase.assert_positions_equal): Added a way to verify that
 909         two positions are the same.
 910         (CppStyleTest.test_position): Added tests for the __str_ and __cmp__ methods.
 911         (CppStyleTest.test_close_expression): Added tests to catch the issues
 912         that were fixed.
 913
 914 2011-01-12  Sheriff Bot  <webkit.review.bot@gmail.com>
 915
 916         Unreviewed, rolling out r75576.
 917         http://trac.webkit.org/changeset/75576
 918         https://bugs.webkit.org/show_bug.cgi?id=52304
 919
 920         broke rebaseline-chromium-webkit-test (Requested by thakis on
 921         #webkit).
 922
 923         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
 924         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
 925         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
 926         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
 927         * Scripts/webkitpy/layout_tests/port/base.py:
 928         * Scripts/webkitpy/layout_tests/port/chromium.py:
 929         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
 930         * Scripts/webkitpy/layout_tests/port/test.py:
 931         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
 932         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
 933         * Scripts/webkitpy/style/checkers/test_expectations.py:
 934         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
 935
 936 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
 937
 938         Reviewed by Darin Adler.
 939
 940         Add a no-build option to run-webkit-tests, to avoid building DRT/WKTR
 941         https://bugs.webkit.org/show_bug.cgi?id=52307
 942
 943         * Scripts/old-run-webkit-tests:
 944
 945 2011-01-12  Koan-Sin Tan  <koansin.tan@gmail.com>
 946
 947         Reviewed by Martin Robinson.
 948
 949         [Gtk] WebKitGtk+ doesn't build on Mac OS X 10.6
 950         https://bugs.webkit.org/show_bug.cgi?id=50867
 951
 952         Fixed library extention for Mac in webkitdirs.pm and type conflict in
 953         TestNetscapePlugin.cpp
 954
 955         * GNUmakefile.am: Don't use AppKit when compiling TestNetscapePlugin for GTK+
 956         * Scripts/webkitdirs.pm:
 957
 958 2011-01-12  Mikhail Naganov  <mnaganov@chromium.org>
 959
 960         Reviewed by Pavel Feldman.
 961
 962         Add check-inspector-strings script.
 963
 964         https://bugs.webkit.org/show_bug.cgi?id=52295
 965
 966         * Scripts/check-inspector-strings: Added.
 967
 968 2011-01-12  Adam Roben  <aroben@apple.com>
 969
 970         Advertise the .testnetscape file extension on Windows
 971
 972         Fixes <http://webkit.org/b/52298>
 973         plugins/no-mime-with-valid-extension.html fails on Windows
 974
 975         Reviewed by Dan Bernstein.
 976
 977         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Added a
 978         FileExtents field to map the .testnetscape file extension to the
 979         application/x-webkit-test-netscape MIME type, just as we do on Mac.
 980
 981 2011-01-12  Adam Barth  <abarth@webkit.org>
 982
 983         Reviewed by Eric Seidel.
 984
 985         Make webkit-patch support subdirectories for SVN checkouts
 986         https://bugs.webkit.org/show_bug.cgi?id=52261
 987
 988         os.relpath does not exist on Python 2.5, so we need to call our version
 989         of the API.
 990
 991         * Scripts/webkitpy/common/checkout/scm.py:
 992
 993 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
 994
 995         Reviewed by Eric Seidel.
 996
 997         Close additional pages opened during a test once the test completes.
 998         https://bugs.webkit.org/show_bug.cgi?id=52276
 999
1000         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1001         (WTR::InjectedBundle::done):
1002
1003 2011-01-11  David Levin  <levin@chromium.org>
1004
1005         Reviewed by Eric Seidel.
1006
1007         Errors should be separated from the command line in bot messages.
1008         https://bugs.webkit.org/show_bug.cgi?id=52275
1009
1010         * Scripts/webkitpy/common/system/executive.py:
1011         (ScriptError.message_with_output): Added a newline to separate the command
1012         line from the errors.
1013         * Scripts/webkitpy/common/system/executive_unittest.py:
1014         (ScriptErrorTest.test_message_with_output): Added tests for the various code
1015         paths in message_with_output.
1016
1017 2011-01-11  Eric Seidel  <eric@webkit.org>
1018
1019         Unreviewed.
1020
1021         commit-queue should know how to upload archived results (for test flakes or general failures)
1022         https://bugs.webkit.org/show_bug.cgi?id=52048
1023
1024         The zips are mostly empty due to forgetting -r.
1025         Expected diffs were not being pulled from the archive due
1026         to the archive having longer paths than I realized.
1027
1028         * Scripts/webkitpy/common/system/workspace.py:
1029         * Scripts/webkitpy/common/system/workspace_unittest.py:
1030         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1031         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1032
1033 2011-01-11  Dirk Pranke  <dpranke@chromium.org>
1034
1035         Reviewed by Ojan Vafai.
1036
1037         The current modifier parsing code in test_expectations is
1038         fragile and hard-coded, so it's not easy to understand the logic
1039         or easily add new types of modifiers (like GPU vs. CPU testing
1040         for graphics tests, or 32-bit vs. 64-bit differences).
1041
1042         This is the first of two patches that will add in more generic
1043         support and then eliminate the GPU-specific test expectations
1044         files for Chromium.
1045
1046         This patch adds two standalone objects for handling modifiers. The
1047         rules for interpreting modifiers, precedence, and conflicts are
1048         given in the docstring to the ModifierMatcher class, which
1049         returns ModifierMatchResult objects.
1050
1051         This patch also adds routines to the Port interface and a
1052         default set of values in the base object, in order to obtain the
1053         values needed on a given test run. These values are then passed
1054         to the expectation parser. This also allows us to clean up the
1055         logic used to lint all of the different configurations in a
1056         single test_expectations.txt file.
1057
1058         The next patch will merge in the separate GPU expectations file.
1059
1060         https://bugs.webkit.org/show_bug.cgi?id=51222
1061
1062         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1063         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1064         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
1065         * Scripts/webkitpy/layout_tests/port/base.py:
1066         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1067         * Scripts/webkitpy/layout_tests/port/chromium.py:
1068         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1069         * Scripts/webkitpy/layout_tests/port/test.py:
1070         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1071         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1072
1073 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
1074
1075         Reviewed by Adam Barth.
1076
1077         Make webkit-patch support subdirectories for SVN checkouts
1078         https://bugs.webkit.org/show_bug.cgi?id=52261
1079
1080         * Scripts/webkitpy/common/checkout/scm.py:
1081         * Scripts/webkitpy/style_references.py:
1082         * Scripts/webkitpy/tool/main.py:
1083         * Scripts/webkitpy/tool/steps/preparechangelog.py:
1084
1085 2011-01-11  Eric Seidel  <eric@webkit.org>
1086
1087         Unreviewed.
1088
1089         commit-queue should know how to upload archived results (for test flakes or general failures)
1090         https://bugs.webkit.org/show_bug.cgi?id=52048
1091
1092         I changed the API for archive_last_layout_test_results w/o updating the implementation.  Oops.
1093         This fixes an exception seen on the commit-queue when attempting to report flaky tests.
1094
1095         * Scripts/webkitpy/common/system/workspace.py:
1096         * Scripts/webkitpy/common/system/workspace_unittest.py:
1097         * Scripts/webkitpy/tool/commands/queues.py:
1098
1099 2011-01-11  Sam Weinig  <sam@webkit.org>
1100
1101         Roll r75474 back in.
1102
1103 2011-01-11  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
1104
1105         Reviewed by Kenneth Rohde Christiansen.
1106
1107         [Qt] Remove uses of QFuture since it isn't supported on all platforms.
1108         https://bugs.webkit.org/show_bug.cgi?id=51204
1109
1110         * QtTestBrowser/webpage.h:
1111         (QtNAMThread::QtNAMThread):
1112         (QtNAMThread::networkAccessManager):
1113         (QtNAMThread::run):
1114
1115 2011-01-11  Peter Varga  <pvarga@webkit.org>
1116
1117         Unreviewed.
1118
1119         Add myself to committers' list.
1120
1121         * Scripts/webkitpy/common/config/committers.py:
1122
1123 2011-01-11  Eric Seidel  <eric@webkit.org>
1124
1125         Reviewed by Adam Barth.
1126
1127         commit-queue should know how to upload archived results (for test flakes or general failures)
1128         https://bugs.webkit.org/show_bug.cgi?id=52048
1129
1130         Now the queue will always upload results.  Either the entire zip, or just
1131         the diffs.txt in the case of text failures.
1132
1133         This should make understanding flakes much easier, and paves the way
1134         for having the EWS run layout tests (and upload failures).
1135
1136         In order to upload .zip files I had to teach bugzilla.py to autodetect
1137         mime types from the filename.  Since mimetypes.py doesn't include a mapping
1138         for .patch files, I have it add one before calling guess_type.
1139
1140         We may find that always uploading the whole zip instead of just the -diffs.txt
1141         file is preferable, but for now I'm keeping the old behavior because it makes
1142         quickly understanding text failures easy.
1143
1144         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1145         * Scripts/webkitpy/common/system/workspace.py: Added.
1146         * Scripts/webkitpy/common/system/workspace_unittest.py: Added.
1147         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1148         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1149         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1150         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1151         * Scripts/webkitpy/tool/commands/queues.py:
1152         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1153
1154 2011-01-10  Sheriff Bot  <webkit.review.bot@gmail.com>
1155
1156         Unreviewed, rolling out r75464.
1157         http://trac.webkit.org/changeset/75464
1158         https://bugs.webkit.org/show_bug.cgi?id=52193
1159
1160         Followup rollout for 75474 (Requested by Ossy on #webkit).
1161
1162         * MiniBrowser/mac/BrowserWindowController.m:
1163         (-[BrowserWindowController awakeFromNib]):
1164         * MiniBrowser/win/BrowserView.cpp:
1165         (BrowserView::create):
1166         * WebKitTestRunner/TestController.cpp:
1167         (WTR::createOtherPage):
1168         (WTR::TestController::initialize):
1169
1170 2011-01-10  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1171
1172         Reviewed by Csaba Osztrogonác.
1173
1174         [Qt] Baseline qt_minimal configuration
1175         https://bugs.webkit.org/show_bug.cgi?id=51313
1176
1177         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1178         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): Add
1179         QT_NO_UNDOSTACK guard.
1180
1181         * QtTestBrowser/launcherwindow.cpp:
1182         (LauncherWindow::createChrome): Add QT_NO_SHORTCUT and QT_NO_PRINTER
1183         guards.
1184         (LauncherWindow::applyZoom): Add QT_NO_ANIMATION guard.
1185         (LauncherWindow::screenshot): Add QT_NO_FILEDIALOG guard.
1186         (LauncherWindow::selectElements): Add QT_NO_INPUTDIALOG guard.
1187         (LauncherWindow::showUserAgentDialog): Add QT_NO_COMBOBOX guard.
1188
1189         * QtTestBrowser/launcherwindow.h:
1190         * QtTestBrowser/locationedit.cpp: Add QT_NO_INPUTDIALOG guard.
1191         * QtTestBrowser/locationedit.h: Ditto.
1192
1193         * QtTestBrowser/mainwindow.cpp:
1194         (MainWindow::buildUI): Add QT_NO_INPUTDIALOG, QT_NO_SHORTCUT and
1195         QT_NO_UNDOSTACK guards.
1196         (MainWindow::setAddressUrl): Add QT_NO_INPUTDIALOG guard.
1197         (MainWindow::changeLocation): Ditto.
1198         (MainWindow::openFile): Add QT_NO_FILEDIALOG guard.
1199         (MainWindow::openLocation): Add QT_NO_INPUTDIALOG guard.
1200
1201         * QtTestBrowser/webpage.cpp:
1202         (WebPage::openUrlInDefaultBrowser): Add QT_NO_DESKTOPSERVICES guard.
1203         (WebPage::authenticationRequired): Add QT_NO_LINEEDIT guard.
1204
1205         * QtTestBrowser/webview.cpp:
1206         (WebViewGraphicsBased::animatedFlip): Add QT_NO_ANIMATION guard.
1207         (WebViewGraphicsBased::animatedYFlip): Ditto.
1208
1209 2011-01-10  Sam Weinig  <sam@webkit.org>
1210
1211         Fix build.
1212
1213         * MiniBrowser/mac/BrowserWindowController.m:
1214         (-[BrowserWindowController awakeFromNib]):
1215         * MiniBrowser/win/BrowserView.cpp:
1216         (BrowserView::create):
1217         * WebKitTestRunner/TestController.cpp:
1218         (WTR::createOtherPage):
1219         (WTR::TestController::initialize):
1220
1221 2011-01-10  Eric Seidel  <eric@webkit.org>
1222
1223         Reviewed by Ojan Vafai.
1224
1225         style-queue messages are way too long for big patches
1226         https://bugs.webkit.org/show_bug.cgi?id=52161
1227
1228         We definitely could build much fancier list-to-string-with-limit functions
1229         but this should be sufficient for our needs at the moment.
1230
1231         * Scripts/webkitpy/common/system/executive.py:
1232         * Scripts/webkitpy/common/system/executive_unittest.py:
1233
1234 2011-01-10  Tony Chang  <tony@chromium.org>
1235
1236         Unreviewed, rolling out r75398.
1237         http://trac.webkit.org/changeset/75398
1238         https://bugs.webkit.org/show_bug.cgi?id=52008
1239
1240         Some layout tests are crashing on Chromium Win.
1241
1242         * DumpRenderTree/chromium/WebViewHost.cpp:
1243         (WebViewHost::updatePaintRect):
1244         * DumpRenderTree/chromium/WebViewHost.h:
1245
1246 2011-01-10  Adam Roben  <aroben@apple.com>
1247
1248         Roll out r75392
1249
1250         It isn't needed now that r75289 has been rolled out.
1251
1252         * Scripts/run-javascriptcore-tests:
1253
1254 2011-01-10  Maciej Stachowiak  <mjs@apple.com>
1255
1256         Reviewed by Anders Carlsson.
1257
1258         WebKitTestRunner uses crazy amounts of CPU, making layout tests slow and flaky
1259         https://bugs.webkit.org/show_bug.cgi?id=52160
1260
1261         * WebKitTestRunner/mac/TestControllerMac.mm:
1262         (WTR::TestController::platformRunUntil): Instead of busy-looping, wait for the timeout.
1263         Anything that can make runUntil() conditions turn true will happen on a run loop cycle
1264         anyway.
1265
1266 2011-01-10  Tony Chang  <tony@chromium.org>
1267
1268         Reviewed by Mihai Parparita.
1269
1270         [chromium] fix for animated gif layout tests
1271         https://bugs.webkit.org/show_bug.cgi?id=52008
1272
1273         * DumpRenderTree/chromium/WebViewHost.cpp: Schedule a paint when we update the paint rect
1274             to trigger gif animations.
1275         (WebViewHostPaintTask::WebViewHostPaintTask):
1276         (WebViewHostPaintTask::runIfValid):
1277         (WebViewHost::updatePaintRect):
1278         * DumpRenderTree/chromium/WebViewHost.h:
1279         (WebViewHost::taskList):
1280
1281 2011-01-10  Alejandro G. Castro  <alex@igalia.com>
1282
1283         Reviewed by Xan Lopez.
1284
1285         [GTK] Fix gtk2 compilation for master
1286         https://bugs.webkit.org/show_bug.cgi?id=51885
1287
1288         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
1289         (createBitmapContextFromWebView): Replaced the old
1290         gdk_drawable_get_size with gdk_pixmap_get_size.
1291
1292 2011-01-10  Patrick Gansterer  <paroga@webkit.org>
1293
1294         Reviewed by Laszlo Gombos.
1295
1296         [WINCE] Reenable NPAPI after r75203
1297         https://bugs.webkit.org/show_bug.cgi?id=52109
1298
1299         Remove the !isWinCE() check for ENABLE_NETSCAPE_PLUGIN_API and replace
1300         it with !isEfl(), because EFL port does not support NPAPI (yet).
1301
1302         * Scripts/build-webkit:
1303
1304 2011-01-10  Adam Roben  <aroben@apple.com>
1305
1306         Skip some asserting JS tests
1307
1308         See <http://webkit.org/b/52156>.
1309
1310         * Scripts/run-javascriptcore-tests:
1311
1312 2011-01-10  Martin Robinson  <mrobinson@igalia.com>
1313
1314         Reviewed by Xan Lopez.
1315
1316         [GTK] build-webkit disable Blob support via arguments passed to automake
1317         https://bugs.webkit.org/show_bug.cgi?id=52097
1318
1319         * Scripts/build-webkit: Enable Blob support when building WebKitGTK+ via
1320         build-webkit.
1321
1322 2011-01-10  Adam Roben  <aroben@apple.com>
1323
1324         Use the same name and description for TestNetscapePlugin on Windows and
1325         Mac
1326
1327         Fixes <http://webkit.org/b/52151>
1328         fast/frames/iframe-reparenting-plugins.html fails on Windows
1329
1330         Reviewed by Steve Falkenburg.
1331
1332         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Copied
1333         the name and description from Mac's Info.plist.
1334
1335 2011-01-10  Siddharth Mathur <siddharth.mathur@nokia.com>
1336
1337         Reviewed by Laszlo Gombos.
1338
1339         [Qt][WK2] Guard gcc-specific syntax
1340
1341         Non-gcc based compliers choke on the "-include"
1342         syntax for preinclude, place guard around it.
1343
1344         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1345         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1346
1347 2011-01-10  Andreas Kling  <kling@webkit.org>
1348
1349         Reviewed by Simon Hausmann.
1350
1351         [Qt] [WK2] MiniBrowser does not load pages opened in new windows
1352         https://bugs.webkit.org/show_bug.cgi?id=52111
1353
1354         When getting a createNewPage() callback from QWKPage, create the
1355         new page with the same QWKContext as the page that is passed to
1356         the callback.
1357
1358         * MiniBrowser/qt/BrowserView.h:
1359         * MiniBrowser/qt/BrowserWindow.cpp:
1360         (newPageFunction):
1361         (BrowserWindow::BrowserWindow):
1362         * MiniBrowser/qt/BrowserWindow.h:
1363
1364 2011-01-10  Andreas Kling  <kling@webkit.org>
1365
1366         Reviewed by Kenneth Rohde Christiansen.
1367
1368         [Qt] MiniBrowser: Remove superfluous createNewPage() callback
1369
1370         BrowserView set its own useless createNewPage() callback on QWKPage.
1371         This was immediately overridden by BrowserWindow anyway, so remove
1372         the BrowserView one.
1373
1374         * MiniBrowser/qt/BrowserView.cpp:
1375         (BrowserView::BrowserView):
1376
1377 2011-01-10  John Knottenbelt  <jknotten@chromium.org>
1378
1379         Reviewed by Jeremy Orlow.
1380
1381         [Chromium] Remove non-client-based Geolocation code
1382         https://bugs.webkit.org/show_bug.cgi?id=50921
1383
1384         * DumpRenderTree/chromium/LayoutTestController.cpp:
1385         (LayoutTestController::setGeolocationPermission):
1386         (LayoutTestController::setMockGeolocationPosition):
1387         (LayoutTestController::setMockGeolocationError):
1388         * DumpRenderTree/chromium/WebViewHost.cpp:
1389         (WebViewHost::geolocationClientMock):
1390         (WebViewHost::reset):
1391         * DumpRenderTree/chromium/WebViewHost.h:
1392
1393 2011-01-10  Eric Seidel  <eric@webkit.org>
1394
1395         Reviewed by Adam Barth.
1396
1397         Commit bot tried to land r? cq+ patch
1398         https://bugs.webkit.org/show_bug.cgi?id=36638
1399
1400         It should now be possible to post a patch with r? and cq+ and the
1401         commit-queue will correctly wait for the r+ before attempting to land the patch.
1402         (This was a feature requested by several users.)
1403
1404         One caveat: We don't actually reject r-, cq+ patches from the queue
1405         (we just ignore them), but I think that's OK for now.
1406
1407         I also noticed that setting r- once a commit-queue node had grabbed
1408         a patch would not properly cancel the landing.  That's fixed and
1409         tested in this patch.
1410
1411         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1412         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1413         * Scripts/webkitpy/tool/bot/feeders.py:
1414         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
1415
1416 2011-01-08  Benjamin Poulain  <benjamin.poulain@nokia.com>
1417
1418         Reviewed by Kenneth Rohde Christiansen.
1419
1420         [Qt] QtWebKit crashes when using XMLHttpRequest from the unload event
1421         https://bugs.webkit.org/show_bug.cgi?id=51934
1422
1423         When accessing the network from the destructor of QWebPage, the network access manager
1424         was already deleted because the object WebPage was already destructed.
1425
1426         This solve the problem by linking the lifetime of the network access manager to WebPage's QObject.
1427         The object is now destructed in the destructor of QObject.
1428
1429         * QtTestBrowser/webpage.cpp:
1430         (WebPage::WebPage):
1431         (WebPage::setQnamThreaded):
1432         * QtTestBrowser/webpage.h:
1433         (QtNAMThread::QtNAMThread):
1434
1435 2011-01-08  Eric Seidel  <eric@webkit.org>
1436
1437         Reviewed by Ojan Vafai.
1438
1439         test_failures.py should not mention TestShell (long live DumpRenderTree!)
1440         https://bugs.webkit.org/show_bug.cgi?id=52067
1441
1442         I ran test-webkitpy, but didn't bother adding a unit test for this string change.
1443         https://bugs.webkit.org/show_bug.cgi?id=51138#c3 is an example of why this is needed.
1444
1445         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1446
1447 2011-01-08  Eric Seidel  <eric@webkit.org>
1448
1449         Reviewed by Mihai Parparita.
1450
1451         commit-queue hangs when the ChangeLog diff is bad
1452         https://bugs.webkit.org/show_bug.cgi?id=52072
1453
1454         * Scripts/webkitpy/tool/steps/validatechangelogs.py:
1455         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
1456
1457 2011-01-08  Adam Barth  <abarth@webkit.org>
1458
1459         Teach svn-apply how to re-write WebCore to Source/WebCore.
1460
1461         * Scripts/VCSUtils.pm:
1462
1463 2011-01-07  Adam Barth  <abarth@webkit.org>
1464
1465         Rubber-stamped by Eric Seidel.
1466
1467         Move WebCore to Source
1468         https://bugs.webkit.org/show_bug.cgi?id=52050
1469
1470         Update the tools to understand WebCore's new location.
1471
1472         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1473         * DumpRenderTree/wscript:
1474         * GNUmakefile.am:
1475         * Scripts/build-webkit:
1476         * Scripts/do-file-rename:
1477         * Scripts/do-webcore-rename:
1478         * Scripts/generate-qt-inspector-resource:
1479         * Scripts/prepare-ChangeLog:
1480         * Scripts/run-bindings-tests:
1481         * Scripts/update-iexploder-cssproperties:
1482         * Scripts/update-sources-list.py:
1483         * Scripts/update-webkit-localizable-strings:
1484         * Scripts/webkitdirs.pm:
1485         * Scripts/webkitpy/common/config/build.py:
1486         * Scripts/webkitpy/common/config/build_unittest.py:
1487         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
1488         * Scripts/webkitpy/style/checker.py:
1489         * Scripts/webkitpy/style/checker_unittest.py:
1490         * WebKitTestRunner/DerivedSources.pro:
1491         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1492         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh:
1493         * wx/browser/wscript:
1494         * wx/build/settings.py:
1495
1496 2011-01-07  Maciej Stachowiak  <mjs@apple.com>
1497
1498         Reviewed by Sam Weinig.
1499
1500         Make WebKitTestRunner rest between loads more robust to avoid test crashes
1501         https://bugs.webkit.org/show_bug.cgi?id=52086
1502
1503         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1504         (WTR::InjectedBundle::didReceiveMessage):
1505         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1506         (WTR::LayoutTestController::notifyDone):
1507         * WebKitTestRunner/TestController.cpp:
1508         (WTR::TestController::resetStateToConsistentValues):
1509         (WTR::TestController::run):
1510
1511 2011-01-07  James Robinson  <jamesr@chromium.org>
1512
1513         Revert "Implement mozilla's animationTime property"
1514         https://bugs.webkit.org/show_bug.cgi?id=51952
1515
1516         This approach isn't quite right.
1517
1518         * DumpRenderTree/chromium/WebViewHost.cpp:
1519         (WebViewHost::paintInvalidatedRegion):
1520
1521 2011-01-07  Adam Roben  <aroben@apple.com>
1522
1523         Build master fix
1524
1525         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1526         (RunWebKitTests.start): Don't try to concatenate a list and a string.
1527
1528 2011-01-07  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>
1529
1530         Reviewed by Csaba Osztrogonác.
1531
1532         run-qtwebkit-tests should be able to kill a testsuite.
1533
1534         Add new option in the script that can setup a timeout for a test.
1535         If the test execution takes more then specified time then the test
1536         would be terminated.
1537
1538         [Qt] run-qtwebkit-tests needs timeout
1539         https://bugs.webkit.org/show_bug.cgi?id=51894
1540
1541         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1542         * Scripts/run-qtwebkit-tests:
1543
1544 2011-01-07  Csaba Osztrogonác  <ossy@webkit.org>
1545
1546         Unreviewed fix after r75233.
1547
1548         Based on idea from Eric Seidel.
1549
1550         Add remote zip file handling to webkitpy.
1551         https://bugs.webkit.org/show_bug.cgi?id=50901
1552
1553         * Scripts/webkitpy/common/system/fileset.py: Make python 2.5 happy.
1554
1555 2011-01-07  Shane Stephens  <shanestephens@google.com>
1556
1557         Reviewed by Eric Seidel.
1558
1559         svn-apply: should support git binary delta diffs
1560         https://bugs.webkit.org/show_bug.cgi?id=38864
1561
1562         * Scripts/VCSUtils.pm:
1563         * Scripts/svn-apply:
1564
1565 2011-01-06  Julie Parent  <jparent@chromium.org>
1566
1567         Reviewed by Eric Seidel.
1568
1569         Test Result Server not removing old results.
1570         https://bugs.webkit.org/show_bug.cgi?id=52012
1571
1572         * TestResultServer/model/jsonresults.py:
1573         Fix off-by-one: Truncate if >= num_runs, not just >.
1574         * TestResultServer/model/jsonresults_unittest.py:
1575         Add unit test to test that merging in a new result with the same value
1576         as the last result causes previous result to fall off.
1577
1578 2011-01-06  James Kozianski  <koz@chromium.org>
1579
1580         Reviewed by Mihai Parparita.
1581
1582         Add classes to provide a consistent interface to a set of files.
1583         https://bugs.webkit.org/show_bug.cgi?id=50901
1584
1585         These classes allow us to write code that is agnostic to whether a
1586         particular set of files resides in a local directory or in a zip file
1587         on a remote machine.
1588
1589         * Scripts/webkitpy/common/system/directoryfileset.py: Added.
1590         * Scripts/webkitpy/common/system/directoryfileset_unittest.py: Added.
1591         * Scripts/webkitpy/common/system/fileset.py: Added.
1592         * Scripts/webkitpy/common/system/filesystem.py:
1593         * Scripts/webkitpy/common/system/filesystem_mock.py:
1594         * Scripts/webkitpy/common/system/zipfileset.py: Added.
1595         * Scripts/webkitpy/common/system/zipfileset_unittest.py: Added.
1596
1597 2011-01-06  Eric Seidel  <eric@webkit.org>
1598
1599         Reviewed by Adam Barth.
1600
1601         NetworkTransaction should log the url it is retrying
1602         https://bugs.webkit.org/show_bug.cgi?id=52043
1603
1604         * Scripts/webkitpy/common/net/networktransaction.py:
1605         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
1606
1607 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
1608
1609         Windows build fix.
1610         Import os before using it.
1611
1612         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1613
1614 2011-01-06  Eric Seidel  <eric@webkit.org>
1615
1616         Reviewed by Adam Barth.
1617
1618         StyleQueue fails to report errors when patches have many files
1619         https://bugs.webkit.org/show_bug.cgi?id=52042
1620
1621         This is one of at least two errors preventing style error reporting at the moment.
1622         When we moved to passing the list of files to check explicitly,
1623         we started to exceed the 500 character TEXT field limit for our AppEngine model object.
1624         We could change the type of the QueueStatus.message type, or we could
1625         just teach statusserver.py how to clamp values (and warn when it does).
1626         I chose the latter path.
1627
1628         * Scripts/webkitpy/common/net/statusserver.py:
1629
1630 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
1631
1632         Reviewed by Stephanie Lewis.
1633
1634         Fix syntax error in script.
1635
1636         Windows bots need to archive/unarchive builds to/from configuration-specific directories
1637         https://bugs.webkit.org/show_bug.cgi?id=51996
1638
1639         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1640
1641 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1642
1643         Unreviewed, fixing WinCE build after r75196.
1644
1645         WinCE port does not (yet) support NPAPI.
1646
1647         * Scripts/build-webkit:
1648
1649 2011-01-06  Xan Lopez  <xlopez@igalia.com>
1650
1651         Reviewed by Darin Adler.
1652
1653         File::Spec->rel2abs in sunspider-compare-results mangles parameters
1654         https://bugs.webkit.org/show_bug.cgi?id=52015
1655
1656         * Scripts/sunspider-compare-results: call rel2abs on our arguments
1657         after the platform has been detected, otherwise the script will
1658         mangle things like '--gtk' into '/a/path/--gtk', breaking the
1659         detection.
1660
1661 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1662
1663         Reviewed by Eric Seidel.
1664
1665         Add ENABLE_NETSCAPE_PLUGIN_API, ENABLE_ORIENTATION_EVENTS and ENABLE_TOUCH_EVENTS flags to build-webkit
1666         https://bugs.webkit.org/show_bug.cgi?id=51346
1667
1668         * Scripts/build-webkit:
1669
1670 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
1671
1672         Reviewed by Adam Roben.
1673
1674         Windows bots need to archive/unarchive builds to/from configuration-specific directories
1675         https://bugs.webkit.org/show_bug.cgi?id=51996
1676
1677         After the configuration directory change, we were archiving the incorrect directory for
1678         build product, so we were running tests on the wrong binaries.
1679
1680         This change archives the correct directory, and also unarchives it into a configuration-
1681         specific directory.
1682
1683         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Use a configuration-specific directory on Windows.
1684         * BuildSlaveSupport/built-product-archive: Unarchive/archive to/from proper directory.
1685
1686 2011-01-06  Eric Seidel  <eric@webkit.org>
1687
1688         Reviewed by Mihai Parparita.
1689
1690         commit-queue mentions "Text diff mismatch" 4 times instead of once per failure
1691         https://bugs.webkit.org/show_bug.cgi?id=52002
1692
1693         See an example of this here:
1694         https://bugs.webkit.org/show_bug.cgi?id=51314#c2
1695
1696         It's due to the fact that we pass around TestFailure() instance
1697         objects and yet expect them to all compare to be the same.
1698
1699         This is bad.  We should either have shared instances of these values
1700         or we should just pass around the class names.  There are already hacks
1701         in place to make TestFailure objects pass equality tests, I just added
1702         a __hash__ implementation so they can be used in sets as expected.
1703
1704         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1705         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1706
1707 2011-01-06  Evan Martin  <evan@chromium.org>
1708
1709         Reviewed by Tony Chang.
1710
1711         [gdb] handle inaccessible memory and UChar*
1712         https://bugs.webkit.org/show_bug.cgi?id=52003
1713
1714         To pretty-print a UChar*, we just grope around in the memory
1715         looking for a terminating NUL.  We need to handle the exception
1716         that can occur when we poke into an invalid location.
1717
1718         Additionally, the logic for choosing which pretty-printer would
1719         early return before hitting the point where we'd use the UChar*
1720         printer.  (Did this ever work?  How did it regress?)
1721
1722         * gdb/webkit.py:
1723
1724 2011-01-05  Brian Weinstein  <bweinstein@apple.com>
1725
1726         Reviewed by Ada Chan.
1727
1728         WebKit2: Should be able to call into injected bundle to ask if we should allow resource loads
1729         https://bugs.webkit.org/show_bug.cgi?id=51969
1730
1731         Add shouldLoadResourceForFrame to WTR::InjectedBundlePage.
1732
1733         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1734         (WTR::InjectedBundlePage::InjectedBundlePage):
1735         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Stub implementation.
1736         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1737
1738 2011-01-06  James Robinson  <jamesr@chromium.org>
1739
1740         Reviewed by Simon Fraser.
1741
1742         Implement mozilla's animationTime property
1743         https://bugs.webkit.org/show_bug.cgi?id=51952
1744
1745         Chromium DRT support for webkitAnimationTime.
1746
1747         * DumpRenderTree/chromium/WebViewHost.cpp:
1748         (WebViewHost::paintInvalidatedRegion):
1749
1750 2011-01-06  Julie Parent  <jparent@chromium.org>
1751
1752         Reviewed by Tony Chang.
1753
1754         Test Result Server always truncates number of results to JSON_RESULTS_MAX_BUILDS
1755         https://bugs.webkit.org/show_bug.cgi?id=51217
1756
1757         * TestResultServer/model/jsonresults.py:
1758         Pass num_runs through to _remove_items_over_max_number_of_builds, and use the value.
1759         Adds missing documentation.
1760         * TestResultServer/model/jsonresults_unittest.py:
1761         Add unit test to test that truncation happens at smaller value than JSON_RESULTS_MAX_BUILDS.
1762         Update test_merge to take a number of builds to truncate at.
1763
1764 2011-01-06  Adam Barth  <abarth@webkit.org>
1765
1766         Reviewed by Eric Seidel.
1767
1768         The EWS should log outside of the working directory
1769         https://bugs.webkit.org/show_bug.cgi?id=51986
1770
1771         This patch prepare us for using git clean -x -d -f in the EWS wrapper
1772         script, which will actually clean the working copy back to a pristine
1773         state instead of leaving untracked directories and ignored files.
1774
1775         * Scripts/webkitpy/tool/commands/queues.py:
1776         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1777
1778 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
1779
1780         Windows build fix.
1781         Back out attempted change to built-product-archive.
1782
1783         * BuildSlaveSupport/built-product-archive:
1784
1785 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
1786
1787         Windows build fix.
1788         Include configuration name when unpacking a build archive.
1789
1790         Needed, since we split Windows build results into configuration-specific directories
1791         under WebKitOutputDir.
1792
1793         * BuildSlaveSupport/built-product-archive:
1794
1795 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
1796
1797         Reviewed by Darin Adler.
1798
1799         Debug and Release builds on Windows clobber each other
1800         https://bugs.webkit.org/show_bug.cgi?id=49185
1801
1802         Changes the structure of WebKitBuild build products directory so we
1803         completely separate each build configuration into independent directories.
1804
1805         Although we previously had per-configuration directories for obj, this change adds
1806         per-configuration directories for bin, lib, obj, and include. Each configuration's
1807         build products are stored within a directory inside of WebKitBuild.
1808
1809         Most use of $(WebKitOutputDir) in the build files has been replaced by $(ConfigurationBuildDir),
1810         defined in common.vsprops to be $(WebKitOutputDir)\$(ConfigurationName).
1811
1812         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops:
1813         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd:
1814         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd:
1815         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
1816         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd:
1817         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd:
1818         * DumpRenderTree/win/ImageDiffCommon.vsprops:
1819         * DumpRenderTree/win/ImageDiffPostBuild.cmd:
1820         * DumpRenderTree/win/ImageDiffPreBuild.cmd:
1821         * FindSafari/FindSafari.vcproj:
1822         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
1823         * MiniBrowser/MiniBrowserPostBuild.cmd:
1824         * MiniBrowser/MiniBrowserPreBuild.cmd:
1825         * Scripts/webkitdirs.pm:
1826         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
1827         * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops:
1828         * TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd:
1829         * TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd:
1830         * TestWebKitAPI/win/copy-resources.cmd:
1831         * WebKitAPITest/WebKitAPITestCommon.vsprops:
1832         * WebKitAPITest/WebKitAPITestPostBuild.cmd:
1833         * WebKitAPITest/WebKitAPITestPreBuild.cmd:
1834         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
1835         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
1836         * WebKitTestRunner/win/InjectedBundle.vcproj:
1837         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops:
1838         * WebKitTestRunner/win/InjectedBundlePostBuild.cmd:
1839         * WebKitTestRunner/win/InjectedBundlePreBuild.cmd:
1840         * WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd:
1841         * WebKitTestRunner/win/WebKitTestRunnerPreBuild.cmd:
1842         * WinLauncher/WinLauncherCommon.vsprops:
1843         * WinLauncher/WinLauncherPostBuild.cmd:
1844         * WinLauncher/WinLauncherPreBuild.cmd:
1845
1846 2011-01-05  Jan Erik Hanssen  <jhanssen@sencha.com>
1847
1848         Reviewed by Ariya Hidayat.
1849
1850         [Qt] TestNetscapePlugin doesn't link on OS X
1851         https://bugs.webkit.org/show_bug.cgi?id=51948
1852
1853         Only add a dependency on libX11 on X11 systems
1854
1855         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1856
1857 2011-01-05  Jeff Miller  <jeffm@apple.com>
1858
1859         Reviewed by Adam Roben.
1860
1861         check-webkit-style should allow unnecessary parameter names in WebKit2 APIs because we're matching CF's header style
1862         https://bugs.webkit.org/show_bug.cgi?id=51970
1863
1864         * Scripts/webkitpy/style/checker.py:
1865         Add -readability/naming for WebKit2 C API directories.
1866
1867 2011-01-05  Eric Seidel  <eric@webkit.org>
1868
1869         Unreviewed, just fixing one more log error from my previous python patch.
1870
1871         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
1872         https://bugs.webkit.org/show_bug.cgi?id=51802
1873
1874         webkit-patch failure-reason was logging about parsing errors
1875         due to my misunderstanding of how BeautifulSoup.findAll worked.
1876
1877         Fixed, and added a unit test.
1878
1879         * Scripts/webkitpy/common/net/layouttestresults.py:
1880         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1881
1882 2011-01-05  Benjamin Poulain  <benjamin.poulain@nokia.com>
1883
1884         Reviewed by Kenneth Rohde Christiansen.
1885
1886         [Qt] [WK2] Add the possibility to open window from the WebProcess in Minibrowser
1887         https://bugs.webkit.org/show_bug.cgi?id=51951
1888
1889         Set a function to QWKPage::setCreateNewPageFunction() in Minibrowser so there is a way
1890         to create new window from WebKit.
1891
1892         * MiniBrowser/qt/BrowserWindow.cpp:
1893         (newPageFunction):
1894         (BrowserWindow::BrowserWindow):
1895         (BrowserWindow::page): Added to avoid the indirect access to QWKPage spread in the class
1896         (BrowserWindow::newWindow):
1897         (BrowserWindow::updateUserAgentList):
1898         (BrowserWindow::showUserAgentDialog):
1899         * MiniBrowser/qt/BrowserWindow.h: Add the global variable backingStoreTypeForNewWindow to
1900         define the type of the backing store used for new windows.
1901         * MiniBrowser/qt/main.cpp:
1902         (main):
1903
1904 2011-01-05  Eric Seidel  <eric@webkit.org>
1905
1906         Reviewed by Ojan Vafai.
1907
1908         commit-queue should report failure type when reporting flaky tests
1909         https://bugs.webkit.org/show_bug.cgi?id=51900
1910
1911         This patch was a ridiculous amount of plumbing.  In the end I like
1912         the NRWT-style TestResult class even less.  But now we're passing
1913         a list of TestResult objects from the queue to the FlakyTestReporter.
1914         Thus the FlakyTestReporter can more easily report what type of failure
1915         occurred.
1916
1917         In the process, I found that I was not alone in finding TestResult
1918         cumbersome to use.  A bunch of code was trying to create a TestResult
1919         object with default values.  However since the constructor didn't make
1920         this easy, some places were getting it wrong (including the TestResult unit test)!
1921         I've fixed the TestResult constructor to have default values for non-essential
1922         arguments.
1923
1924         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1925         * Scripts/webkitpy/common/net/layouttestresults.py:
1926         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1927         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1928         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1929         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1930         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
1931         * Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py:
1932         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1933         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1934         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1935         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1936         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1937         * Scripts/webkitpy/tool/commands/queues.py:
1938         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1939
1940 2011-01-05  Eric Seidel  <eric@webkit.org>
1941
1942         Unreviewed.
1943
1944         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
1945         https://bugs.webkit.org/show_bug.cgi?id=51802
1946
1947         Add another unit test to cover a previously missing import.
1948
1949         * Scripts/webkitpy/common/net/layouttestresults.py:
1950         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1951
1952 2011-01-05  Mihai Parparita  <mihaip@chromium.org>
1953
1954         Reviewed by David Levin.
1955
1956         Add mihaip@chromium.org as a reviewer
1957         https://bugs.webkit.org/show_bug.cgi?id=51966
1958
1959         Add myself as a reviewer.
1960
1961         * Scripts/webkitpy/common/config/committers.py:
1962
1963 2011-01-05  James Simonsen  <simonjam@chromium.org>
1964
1965         Unreviewed. Adding myself to the list of committers.
1966
1967         * Scripts/webkitpy/common/config/committers.py:
1968
1969 2011-01-05  Eric Seidel  <eric@webkit.org>
1970
1971         Unreviewed.
1972
1973         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
1974         https://bugs.webkit.org/show_bug.cgi?id=51802
1975
1976         Fix two exceptions seen on the bots after my original commit.
1977
1978         * Scripts/webkitpy/common/net/layouttestresults.py:
1979         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1980
1981 2011-01-05  Kundu Suchismita  <suchi.kundu@nokia.com>
1982
1983         Reviewed by Andreas Kling.
1984
1985         [Qt]Add local storage settings to QtTestBrowser command line arguments
1986         https://bugs.webkit.org/show_bug.cgi?id=51750
1987
1988         * QtTestBrowser/main.cpp:
1989         (LauncherApplication::handleUserOptions):
1990          Local storage settings can be enable form command line arguments for
1991          QtTestBrowser.
1992
1993 2011-01-05  Chris Fleizach  <cfleizach@apple.com>
1994
1995         Reviewed by Martin Robinson.
1996
1997         GTK: AX: DRT needs to use correct root object method.
1998         https://bugs.webkit.org/show_bug.cgi?id=51911
1999
2000         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
2001         (AccessibilityController::rootElement):
2002
2003 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
2004
2005         Rubber-stamped by Csaba Osztrogonác.
2006
2007         Based on idea from Péter Gál.
2008
2009         * Scripts/webkitpy/tool/bot/sheriff.py: Remove unnecessary apostrophes around revision numbers.
2010
2011 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
2012
2013         Reviewed by Adam Barth.
2014
2015         sheriff-bot should be able to do multi-revision rollouts
2016         https://bugs.webkit.org/show_bug.cgi?id=51176
2017
2018         * Scripts/webkitpy/tool/bot/irc_command.py:
2019         * Scripts/webkitpy/tool/bot/sheriff.py:
2020         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
2021
2022 2011-01-05  Eric Seidel  <eric@webkit.org>
2023
2024         Reviewed by Adam Barth.
2025
2026         queues.webkit.org should have per-bot status pages
2027         https://bugs.webkit.org/show_bug.cgi?id=51906
2028
2029         Just adds a /queue-status/QUEUE_NAME/bots/BOT_ID page to show
2030         statuses from a single queue.  Now that we have many bots servicing
2031         some queues (commit-queue, win-ews, etc.) its easy to have the messages
2032         you care about scroll off the end of the 15-message limit on the main page.
2033
2034         Eventually we should probably rename /queue-status to /queue or /queues,
2035         but that's fodder for another patch.
2036
2037         * QueueStatusServer/handlers/queuestatus.py:
2038         * QueueStatusServer/index.yaml:
2039         * QueueStatusServer/main.py:
2040         * QueueStatusServer/templates/includes/singlequeuestatus.html:
2041          - This probably should use a custom filter instead of hard-coding
2042            the URL scheme here, but I couldn't figure out how to easily
2043            create such a filter.  Most filters work with "strings" so we can't
2044            pass the status object.  We could add a method to the status
2045            object and call that, but that seemed a bit strange too.
2046         * QueueStatusServer/templates/queuestatus.html:
2047
2048 2011-01-05  Carlos Garcia Campos  <cgarcia@igalia.com>
2049
2050         Unreviewed. Adding myself to the list of committers.
2051
2052         * Scripts/webkitpy/common/config/committers.py:
2053
2054 2011-01-04  Koan-Sin Tan  <koansin.tan@gmail.com>
2055
2056         Reviewed by David Levin.
2057
2058         check-webkit-style treated some macros with parentheses after #elif as function calls
2059         https://bugs.webkit.org/show_bug.cgi?id=51695
2060
2061         Ingore function call space checking in any preprocessor directives
2062         (things starting with #). Change search() to match() because
2063         preprocessor directives are supposed to be in the beginning of lines.
2064
2065         * Scripts/webkitpy/style/checkers/cpp.py:
2066         * Scripts/webkitpy/style/checkers/cpp_unittest.py: make sure there is no false positives for #elif cases
2067
2068 2011-01-04  Søren Gjesse  <sgjesse@chromium.org>
2069
2070         Reviewed by Tony Chang.
2071
2072         Change the --multi-load test option to --stress-opt
2073         https://bugs.webkit.org/show_bug.cgi?id=50751
2074
2075         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2076         (runTest):
2077         (main):
2078         * DumpRenderTree/chromium/TestShell.cpp:
2079         (TestShell::TestShell):
2080         * DumpRenderTree/chromium/TestShell.h:
2081         (TestShell::stressOpt):
2082         (TestShell::setStressOpt):
2083         (TestShell::stressDeopt):
2084         (TestShell::setStressDeopt):
2085         (TestShell::javaScriptFlags):
2086         (TestShell::setJavaScriptFlags):
2087         * Scripts/webkitpy/layout_tests/port/chromium.py:
2088         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2089
2090 2011-01-04  Chris Fleizach  <cfleizach@apple.com>
2091
2092         Reviewed by Sam Weinig.
2093
2094         WK2: Support Accessibility
2095         https://bugs.webkit.org/show_bug.cgi?id=51859
2096
2097         Use rootObject() method to get top of accessibility tree.
2098
2099         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
2100         (AccessibilityController::focusedElement):
2101         (AccessibilityController::rootElement):
2102
2103 2011-01-03  Martin Robinson  <mrobinson@igalia.com>
2104
2105         Reviewed by Darin Adler.
2106
2107         Remove the last non-GObject usage of PlatformRefPtr and move the code to GRefPtr
2108         https://bugs.webkit.org/show_bug.cgi?id=51846
2109
2110         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: Change usage of PlatformRefPtr
2111         back to GRefPtr.
2112
2113 2011-01-04  Zhe Su  <suzhe@chromium.org>
2114
2115         Reviewed by Kenneth Russell.
2116
2117         Fix insertText, setMarkedText and unmarkText methods of
2118         TextInputController to call corresponding methods of WebKit::WebView
2119         rather than WebKit::WebFrame. This change matches the behavior of
2120         chromium browser.
2121         insertText corresponds to WebView::confirmComposition(text)
2122         setMarkedText corresponds to WebView::setComposition(...)
2123         unmarkText corresponds to WebView::confirmComposition()
2124         https://bugs.webkit.org/show_bug.cgi?id=51693
2125
2126         * DumpRenderTree/chromium/TextInputController.cpp:
2127         (TextInputController::insertText):
2128         (TextInputController::setMarkedText):
2129         (TextInputController::unmarkText):
2130
2131 2011-01-04  Dihan Wickremasuriya  <dihan.wickremasuriya@nokia.com>
2132
2133         Reviewed by Laszlo Gombos.
2134
2135         [Qt] [Symbian] Do not remove 0 byte sized files from productDir
2136
2137         On Symbian productDir points to the source directory. Removing all the
2138         empty files from the productDir directory corrupts the svn repository.
2139
2140         * Scripts/build-webkit:
2141
2142 2011-01-03  Yi Shen  <yi.4.shen@nokia.com>
2143
2144         Reviewed by Adam Barth.
2145
2146         [Qt] Add SelectAll option to the context menu for the editor
2147         https://bugs.webkit.org/show_bug.cgi?id=50049
2148
2149         Set shortcut for the SelectAll action.
2150
2151         * QtTestBrowser/mainwindow.cpp:
2152         (MainWindow::buildUI):
2153
2154 2011-01-03  David Levin  <levin@chromium.org>
2155
2156         Reviewed by Eric Seidel.
2157
2158         check-webkit-style shouldn't consider "value" automatically to be a meaningless name.
2159         https://bugs.webkit.org/show_bug.cgi?id=51842
2160
2161         * Scripts/webkitpy/style/checkers/cpp.py: Remove the check for value.
2162         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Remove the test for value.
2163
2164 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
2165
2166         Reviewed by David Kilzer.
2167
2168         [WINCE] Adds a build slave.
2169         https://bugs.webkit.org/show_bug.cgi?id=50523
2170
2171         * BuildSlaveSupport/build.webkit.org-config/config.json: Add an
2172         entry for a release build of the WinCE port.
2173         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add platform
2174         flag to build the WinCE port.
2175
2176 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
2177
2178         Reviewed by David Kilzer.
2179
2180         Add WinCE support to build-webkit
2181         https://bugs.webkit.org/show_bug.cgi?id=51642
2182
2183         * Scripts/build-webkit:
2184         * Scripts/webkitdirs.pm:
2185
2186 2011-01-03  Eric Seidel  <eric@webkit.org>
2187
2188         Reviewed by Adam Barth.
2189
2190         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
2191         https://bugs.webkit.org/show_bug.cgi?id=51802
2192
2193         I'm not the biggest fan of the test_failures or test_results classes,
2194         but it's better to have one shared set of classes, than separate ones
2195         for new vs. old run-webkit-test result handling.
2196
2197         This moves the ORWT results class "LayoutTestResults" over to using
2198         TestResult and TestFailure classes, making it easy for us to
2199         make all our sheriff-bot and other webkitpy code NRWT ready.
2200
2201         This also makes it a trivial patch to generate results.json information
2202         from ORWT results.html files (for flaky test analysis, etc.) as well
2203         as making it a one-liner to report test failure types when the
2204         commit-queue sees flaky tests.
2205
2206         This patch tried not to add new functionality, but only to replace
2207         the guts of LayoutTestResults, while adding unit tests and hoping
2208         not to break anything.
2209
2210         I also moved callers which assumed User.prompt* were static/class methods
2211         to using them as instance methods (since we'll eventually want to make them such).
2212
2213         In the process of re-writing things, I broke the rebaseline command, so I wrote
2214         a unit test to catch my breakage were I do do so again in the future.
2215
2216         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2217         * Scripts/webkitpy/common/net/layouttestresults.py:
2218         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2219         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
2220         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
2221         * Scripts/webkitpy/tool/commands/queries.py:
2222         * Scripts/webkitpy/tool/commands/rebaseline.py:
2223         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2224         * Scripts/webkitpy/tool/mocktool.py:
2225
2226 2011-01-03  Adam Barth  <abarth@webkit.org>
2227
2228         Reviewed by Simon Fraser.
2229
2230         webkit-patch shouldn't waste time cleaning a working directory that's already clean
2231         https://bugs.webkit.org/show_bug.cgi?id=51840
2232
2233         * Scripts/webkitpy/common/checkout/scm.py:
2234
2235 2011-01-03  Adam Barth  <abarth@webkit.org>
2236
2237         Reviewed by Simon Fraser.
2238
2239         webkit-patch should only hide update output if --quiet
2240         https://bugs.webkit.org/show_bug.cgi?id=51838
2241
2242         As requested by smfr.
2243
2244         * Scripts/webkitpy/tool/steps/update.py:
2245
2246 2011-01-03  Adam Barth  <abarth@webkit.org>
2247
2248         Reviewed by David Levin.
2249
2250         commit-queue shouldn't reject patches twice if two bots process the same patch
2251         https://bugs.webkit.org/show_bug.cgi?id=51805
2252
2253         Before raising an error, we first check whether the patch is still in
2254         the commit-queue.  This check is still racy, of course, but the time
2255         window is much smaller.
2256
2257         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2258
2259 2011-01-03  Sam Weinig  <sam@webkit.org>
2260
2261         Reviewed by Anders Carlsson.
2262
2263         Make run-api-tests less chatty.
2264         https://bugs.webkit.org/show_bug.cgi?id=51831
2265
2266         - Make script quiet by default and add --verbose option (replacing --quiet).
2267         - When not verbose, pipe stdout and stderr to devnull.
2268
2269         * Scripts/run-api-tests:
2270
2271 2011-01-03  Pratik Solanki  <psolanki@apple.com>
2272
2273         Unreviewed. Adding myself to committers.py.
2274
2275         * Scripts/webkitpy/common/config/committers.py:
2276
2277 2011-01-03  Koan-Sin Tan  <koansin.tan@gmail.com>
2278
2279         Reviewed by Xan Lopez.
2280
2281         "Tool/Scripts/run-launcher --gtk" stopped working after 74855
2282         https://bugs.webkit.org/show_bug.cgi?id=51806
2283
2284         Originally, the $libraryName is 'JavaScriptCore'. When building release
2285         one, the $libraryDir was 'WebKitBuild/Release/JavaScriptCore/../.libs/'
2286         which doesn't exist anymore ('WebKitBuild/Release/JavaScriptCore'
2287         is 'WebKitBuild/Release/Source/JavaScriptCore' now), and
2288         'WebKitBuild/Release/Source/JavaScriptCore/../../.libs' looks weird,
2289         so make it 'WebKitBuild/Release/.libs'
2290
2291         * Scripts/webkitdirs.pm:
2292
2293 2011-01-02  Patrick Gansterer  <paroga@webkit.org>
2294
2295         Reviewed by Adam Barth.
2296
2297         Make EFL a core builder
2298         https://bugs.webkit.org/show_bug.cgi?id=51804
2299
2300         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2301         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2302
2303 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
2304
2305         [Qt] Unreviewed fix after r74855 and r74875.
2306
2307         * BuildSlaveSupport/built-product-archive:
2308          - Create directories explicitly.
2309          - Pass shell=True to subprocess.call().
2310
2311 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
2312
2313         [Qt] Unreviewed fix after r74855.
2314
2315         Move JavaScriptCore to Source
2316         https://bugs.webkit.org/show_bug.cgi?id=51604
2317
2318         * BuildSlaveSupport/built-product-archive: JavaScriptCore -> Source/JavaScriptCore
2319
2320 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
2321
2322         [Qt] Unreviewed run-javasriptcore-tests fix after r74855.
2323
2324         Move JavaScriptCore to Source
2325         https://bugs.webkit.org/show_bug.cgi?id=51604
2326
2327         * Scripts/webkitdirs.pm:
2328
2329 2011-01-02  Robert Hogan  <robert@webkit.org>
2330
2331         Unreviewed, build fix.
2332
2333         [Qt] Fix DRT build after 74855
2334
2335         * DumpRenderTree/qt/DumpRenderTree.pro:
2336
2337 2011-01-01  Adam Barth  <abarth@webkit.org>
2338
2339         Remove the assumption from the Qt and Gtk builds that every project is
2340         in the root directory.
2341
2342         * Scripts/build-webkit:
2343
2344 2011-01-01  Adam Barth  <abarth@webkit.org>
2345
2346         Reviewed by Eric Seidel.
2347
2348         Teach svn-apply how to apply patches even though JavaScriptCore has moved
2349         https://bugs.webkit.org/show_bug.cgi?id=51796
2350
2351         After this change, svn-apply will magically apply patches to
2352         JavaScriptCore/foo to Source/JavaScriptCore/foo.
2353
2354         * Scripts/VCSUtils.pm:
2355
2356 2011-01-01  Adam Barth  <abarth@webkit.org>
2357
2358         Reviewed by Eric Seidel.
2359
2360         Move JavaScriptCore to Source
2361         https://bugs.webkit.org/show_bug.cgi?id=51604
2362
2363         Update references to JavaScriptCore to point to the new location.
2364
2365         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2366         * DumpRenderTree/qt/DumpRenderTree.pro:
2367         * DumpRenderTree/qt/ImageDiff.pro:
2368         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2369         * DumpRenderTree/wscript:
2370         * Scripts/build-jsc:
2371         * Scripts/build-webkit:
2372         * Scripts/do-file-rename:
2373         * Scripts/do-webcore-rename:
2374         * Scripts/run-javascriptcore-tests:
2375         * Scripts/update-javascriptcore-test-results:
2376         * Scripts/webkitdirs.pm:
2377         * Scripts/webkitpy/common/config/build_unittest.py:
2378         * Scripts/webkitpy/style/checker.py:
2379         * Scripts/webkitpy/style/checker_unittest.py:
2380         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2381         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2382         * WebKitTestRunner/qt/WebKitTestRunner.pro:
2383         * wx/build/settings.py:
2384
2385 2011-01-01  Adam Barth  <abarth@webkit.org>
2386
2387         Reviewed by Eric Seidel.
2388
2389         Move Sources to Source
2390         https://bugs.webkit.org/show_bug.cgi?id=51794
2391
2392         Update scripts to point to the new location.
2393
2394         * Scripts/build-webkit:
2395         * Scripts/do-file-rename:
2396         * Scripts/do-webcore-rename:
2397         * Scripts/webkitpy/common/config/build.py:
2398         * Scripts/webkitpy/common/config/build_unittest.py:
2399
2400 2010-12-31  Kent Tamura  <tkent@chromium.org>
2401
2402         Reviewed by Eric Seidel.
2403
2404         [DRT/Chromium] Enable mock spell checker on non-OSX
2405         https://bugs.webkit.org/show_bug.cgi?id=51401
2406
2407         * DumpRenderTree/chromium/WebViewHost.cpp:
2408         (WebViewHost::spellCheck):
2409
2410 2010-12-31  Adam Barth  <abarth@webkit.org>
2411
2412         Reviewed by Ariya Hidayat.
2413
2414         Remove Tools/Scripts/wkstyle
2415         https://bugs.webkit.org/show_bug.cgi?id=51774
2416
2417         This script appears to not have been touched in a while and seems to
2418         have been replaced by check-webkit-style.
2419
2420         * Scripts/wkstyle: Removed.
2421
2422 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
2423
2424         Unreviewed. Coding style fix.
2425
2426         * DumpRenderTree/chromium/TestShell.h:
2427
2428 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
2429
2430         Reviewed by Pavel Feldman.
2431
2432         Web Inspector: [Chromium] Inspector's tests are very slow on Win(Dbg).
2433
2434         It was a problem with Chromium DRT. DevToolsAgent object instance was
2435         attached not only to the inspected page but to the DevTools window too.
2436         As result all the inspector files were interpreted as a content of inspected page
2437         and were transfered to the DevTools scripts panel for debugging etc.
2438
2439         https://bugs.webkit.org/show_bug.cgi?id=51735
2440
2441         * DumpRenderTree/chromium/TestShell.cpp:
2442         (TestShell::TestShell):
2443         (TestShell::bindJSObjectsToWindow):
2444         (TestShell::createNewWindow):
2445         * DumpRenderTree/chromium/TestShell.h:
2446
2447 2010-12-31  Adam Barth  <abarth@webkit.org>
2448
2449         Rubber-stamped by Eric Seidel.
2450
2451         Move PageLoadTests to PerformanceTests/PageLoad
2452         https://bugs.webkit.org/show_bug.cgi?id=51771
2453
2454         Update references to PageLoadTests to point to the new location.
2455
2456         * Scripts/run-pageloadtest:
2457         * Scripts/webkitpy/common/config/build.py:
2458
2459 2010-12-31  Adam Barth  <abarth@webkit.org>
2460
2461         Rubber-stamped by Eric Seidel.
2462
2463         Move SunSpider into PerformanceTests
2464         https://bugs.webkit.org/show_bug.cgi?id=51769
2465
2466         Update these scripts to point to the new location.
2467
2468         * Scripts/run-sunspider:
2469         * Scripts/sunspider-compare-results:
2470
2471 2010-12-30  Mihai Parparita  <mihaip@chromium.org>
2472
2473         Reviewed by Kent Tamura.
2474
2475         [Chromium] Add WebThemeEngineDRTMac so that Chromium DRT scrollbar rendering can match the Mac port's
2476         https://bugs.webkit.org/show_bug.cgi?id=51728
2477
2478         Add implementation of the Mac WebThemeEngine that uses an NSScroller
2479         to render top-level scrollbars. This makes them match the Mac port's
2480         use of an NSScrollView, which means that we'll be able to share more
2481         pixel baselines.
2482
2483         The new rendering code will not be activated until the
2484         USE_WEB_THEME_ENGINE_TO_PAINT_THUMB #define is fliped in
2485         ScrollbarThemeChromiumMac.
2486
2487         * DumpRenderTree/DumpRenderTree.gypi:
2488         * DumpRenderTree/chromium/TestShellMac.mm:
2489         (platformInit):
2490         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Added.
2491         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Added.
2492         (+[FakeActiveWindow alwaysActiveWindow]):
2493         (+[FakeActiveWindow alwaysInactiveWindow]):
2494         (-[FakeActiveWindow initWithActiveControls:]):
2495         (-[FakeActiveWindow _hasActiveControls]):
2496         (WebThemeEngineDRTMac::paintScrollbarThumb):
2497         (stateToHIEnableState):
2498         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
2499         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
2500
2501 2010-12-30  Konstantin Tokarev  <annulen@yandex.ru>
2502
2503         Reviewed by David Kilzer.
2504
2505         [Qt] Don't build wtf/TCSystemAlloc.cpp if --system-malloc option is
2506         used
2507         https://bugs.webkit.org/show_bug.cgi?id=51672
2508
2509         * DumpRenderTree/qt/DumpRenderTree.pro: Replaced USE_SYSTEM_MALLOC
2510         with USE_SYSTEM_MALLOC=1
2511         * WebKitTestRunner/qt/WebKitTestRunner.pro: Replaced USE_SYSTEM_MALLOC
2512         with USE_SYSTEM_MALLOC=1
2513
2514 2010-12-30  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2515
2516         Reviewed by David Kilzer.
2517
2518         [Qt] [Symbian] Fix build-webkit script for Symbian
2519         https://bugs.webkit.org/show_bug.cgi?id=51509
2520
2521         Set the OUTPUT_DIR for Symbian to be the same as the source
2522         directory.
2523
2524         * Scripts/webkitdirs.pm:
2525
2526 2010-12-30  Martin Robinson  <mrobinson@igalia.com>
2527
2528         Reviewed by Darin Adler.
2529
2530         check-webkit-style should ignore NULL usage in calls to gtk_widget_style_get
2531         https://bugs.webkit.org/show_bug.cgi?id=51758
2532
2533         Add a check-webkit-style exception for gtk_widget_style_get and NULL usage.
2534
2535         * Scripts/webkitpy/style/checkers/cpp.py: Add the exception.
2536         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Add some tests for this.
2537
2538 2010-12-29  Patrick Gansterer  <paroga@webkit.org>
2539
2540         Unreviewed WinCE buildfix.
2541
2542         * WinCELauncher/main.cpp: Add missing include.
2543
2544 2010-12-29  Daniel Bates  <dbates@rim.com>
2545
2546         Reviewed by Darin Adler.
2547
2548         svn-apply updates date of wrong change log entry for a change log diff that
2549         contains two consecutive entries with the same author and date
2550         https://bugs.webkit.org/show_bug.cgi?id=46061
2551
2552         Fixes an issue where the date of the wrong change log entry may be modified.
2553         Moreover, changes fixChangeLogPatch() to move entries inserted earlier
2554         in a ChangeLog file to the top of the file.
2555
2556         Currently, fixChangeLogPatch() explicitly bails out and returns an unchanged
2557         diff when it detects that the diff inserts a change log entry earlier in a
2558         ChangeLog. It is unusual to land a patch that has such a deliberate ChangeLog
2559         change. With the advent of the commit-queue this functionality of bailing out
2560         and hence landing the patch as-is is harmful to the accuracy of the ChangeLog.
2561         Instead, we should always move the change log entry to the top of the ChangeLog file.
2562
2563         A side-effect of this change is that setChangeLogDateAndReviewer() now updates
2564         the date line of the correct change log entry in a ChangeLog diff.
2565
2566         * Scripts/VCSUtils.pm: Modified fixChangeLogPatch() to move entries inserted earlier to the top.
2567
2568         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
2569           Updated the following unit tests now that we move entries inserted earlier to the top:
2570           - "fixChangeLogPatch: New entry inserted in middle."
2571             (formerly named "fixChangeLogPatch: [no change] New entry inserted in middle.")
2572
2573           - "fixChangeLogPatch: New entry inserted earlier in the file, but after an entry with the same author and date."
2574             (formerly named "fixChangeLogPatch: [no change] New entry inserted earlier in the file, but after an entry with the same author and date.")
2575
2576         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatchThenSetChangeLogDateAndReviewer.pl: Added.
2577
2578 2010-12-29  Konstantin Tokarev  <annulen@yandex.ru>
2579
2580         Reviewed by Eric Seidel.
2581
2582         [Qt] Fixed compatibility with gold linker on X11 platforms
2583         https://bugs.webkit.org/show_bug.cgi?id=51700
2584
2585         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2586         Linked TestNetscapePlugin with libX11 on Unix platforms
2587
2588 2010-12-29  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>
2589
2590         Reviewed by Darin Adler.
2591
2592         Circular dependency in webkitpy.common.checkout.changelog module
2593         https://bugs.webkit.org/show_bug.cgi?id=50475
2594
2595         Remove automatic import of api.Checkout module when any checkout/
2596         submodule is imported (e.g.: when checkout.scm.Git is imported).
2597
2598         * Scripts/webkitpy/common/checkout/__init__.py:
2599
2600 2010-12-29  Martin Robinson  <mrobinson@igalia.com>
2601
2602         Reviewed by Ojan Vafai.
2603
2604         prepare-ChangeLog should support the -g option for specifying the git-commit
2605         https://bugs.webkit.org/show_bug.cgi?id=51708
2606
2607         Add a -g shortcut for the --git-commit prepare-ChangeLog option. This matches
2608         webkit-patch, though the exact meaning of the two options remain different.
2609
2610         * Scripts/prepare-ChangeLog: Add -g.
2611
2612 2010-12-29  Kent Hansen  <kent.hansen@nokia.com>
2613
2614         Reviewed by Simon Hausmann.
2615
2616         [Qt] Fix compilation with Qt in namespace
2617         https://bugs.webkit.org/show_bug.cgi?id=51701
2618
2619         * QtTestBrowser/webview.h:
2620
2621 2010-12-28  Daniel Bates  <dbates@rim.com>
2622
2623         Reviewed by Sam Weinig.
2624
2625         Substitute // MARK: for compiler-specific #pragma mark
2626         https://bugs.webkit.org/show_bug.cgi?id=51657
2627
2628         Fix future compilation warnings about "#pragma mark" on GTK+ bots by
2629         substituting  "// MARK:" for "#pragma mark", which provides
2630         analogous code-bookmarking functionality under Xcode.
2631
2632         Also, for consistency, we should substitute "// MARK:" for compiler-
2633         specific "#pragma mark" in the source files for the Mac port.
2634
2635         * DumpRenderTree/AccessibilityTextMarker.cpp:
2636         * DumpRenderTree/cf/WebArchiveDumpSupport.h:
2637         * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm:
2638         * DumpRenderTree/mac/ObjCController.m:
2639         * MiniBrowser/mac/AppDelegate.m:
2640         * MiniBrowser/mac/BrowserWindowController.m:
2641
2642 2010-12-28  Xan Lopez  <xlopez@igalia.com>
2643
2644         Reviewed by Eric Seidel.
2645
2646         Add --no-build option to run-sunspider
2647         https://bugs.webkit.org/show_bug.cgi?id=51658
2648
2649         * Scripts/run-sunspider: add --no-build flag to skip building
2650         phase.
2651
2652 2010-12-27  Daniel Bates  <dbates@rim.com>
2653
2654         Rubber-stamped by Martin Robinson.
2655
2656         Append the directory Tools/DumpRenderTree to the list of directories that
2657         do-webcore-rename should search so that it can rename DRT files and
2658         source code.
2659
2660         * Scripts/do-webcore-rename:
2661
2662 2010-12-27  Eric Seidel  <eric@webkit.org>
2663
2664         Reviewed by Adam Barth.
2665
2666         build-webkit should detect missing Java SDK and explain how to install it
2667         https://bugs.webkit.org/show_bug.cgi?id=51651
2668
2669         * Scripts/build-webkit:
2670
2671 2010-12-26  Martin Robinson  <mrobinson@igalia.com>
2672
2673         Reviewed by Daniel Bates.
2674
2675         [GTK] Add support for build-jsc
2676         https://bugs.webkit.org/show_bug.cgi?id=51625
2677
2678         Add GTK+ support to build-jsc now that building the jsc executable as
2679         a standalone target is easy.
2680
2681         * Scripts/build-jsc: Call buildGtkProject for the GTK+ case now.
2682         * Scripts/build-webkit: Pass in the proper target name to buildGtkProject.
2683         * Scripts/webkitdirs.pm: Actually process the project parameter in buildGtkProject
2684         and pass it along to buildAutotoolsProject.
2685
2686 2010-12-27  David Levin  <levin@chromium.org>
2687
2688         Reviewed by Eric Seidel.
2689
2690         check-webkit-style check for meaningless variable names in function declarations.
2691         https://bugs.webkit.org/show_bug.cgi?id=51523
2692
2693         * Scripts/webkitpy/style/checker.py: Exempted JavaScriptCore/jit/JITStubs.cpp
2694         from the new check and whitespace/parens because the syntax is unusual and
2695         produced a fair number of positives for these checks.
2696         * Scripts/webkitpy/style/checkers/cpp.py:
2697         (_convert_to_lower_with_underscores): Used as a canonical form for type names
2698         and parameter names when determining if the parameter name is useless.
2699         (_create_acronym): Used to check for redundant variable names in cases like "ExceptionCode ec"
2700         (Parameter.lower_with_underscores_name): Gives back the parameter name in a lower_with_underscore
2701         format.
2702         (_check_parameter_name_against_text):  Checks to see if the parameter name is in the
2703         text or an acronym of it.
2704         (check_function_definition): Checks function definitions for meaningless variable names.
2705         (process_line): Added call to check_function_definition.
2706         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2707         (CppFunctionsTest.test_convert_to_lower_with_underscores): Test for _convert_to_lower_with_underscores.
2708         (CppFunctionsTest.test_create_acronym): Test for _create_acronym.
2709         (CppFunctionsTest.test_check_parameter_against_text): Test for _check_parameter_against_text.
2710         (CppStyleTestBase.perform_single_line_lint): Removed the parameter name check
2711         because when only checking a snippet, there are a lot of bogus functions.
2712         (CppStyleTestBase.perform_multi_line_lint): Ditto and removed a bogus filter
2713         that I put there previously and just noticed.
2714         (WebKitStyleTest.test_parameter_names): Tests for the functionality -- both
2715         check_function_definition and process_line.
2716
2717 2010-12-27  Carlos Garcia Campos  <cgarcia@igalia.com>
2718
2719         Reviewed by Martin Robinson.
2720
2721         [GTK] Disable flash plugin in GtkLauncher when using gtk3
2722         https://bugs.webkit.org/show_bug.cgi?id=51591
2723
2724         Flash plugin uses gtk2 that is incompatible with gtk3 making
2725         webkit crash when it's built with gtk3.
2726
2727         * GtkLauncher/main.c:
2728         (main):
2729
2730 2010-12-25  Adam Barth  <abarth@webkit.org>
2731
2732         Reviewed by Eric Seidel.
2733
2734         Move ANGLE to Sources/ThirdParty
2735         https://bugs.webkit.org/show_bug.cgi?id=51605
2736
2737         * Scripts/build-webkit:
2738           - Point to the new ANGLE location.
2739
2740 2010-12-26  David Levin  <levin@chromium.org>
2741
2742         Reviewed by Eric Seidel.
2743
2744         check-webkit-style should be able to parse function declaration parameters.
2745         https://bugs.webkit.org/show_bug.cgi?id=51451
2746
2747         * Scripts/webkitpy/style/checkers/cpp.py:
2748         (Position.__init__): Holds simple position information (row, column).
2749         (Parameter.__init__): Holds information about a parameter.
2750         (SingleLineView.__init): Converts multiple lines into a single line for simpler searches.
2751         (SingleLineView.convert_column_to_row): Returns the original row given a column.
2752         (create_skeleton_parameters): Simplifies a parameter list for easier searching.
2753         (find_parameter_name_index): Finds where the parameter name is.
2754         (parameter_list): Generates the list of parameters for a function.
2755         (_FunctionState.begin): Added information to allow determining the parameters
2756         on demand.
2757         (_FunctionState.get_parameter_list): Returns a tuple of function parameters.
2758         (detect_functions): Improve function detection for operator functions and
2759         determine where the parameters end and pass that to _FunctionState.begin.
2760         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2761         (CppFunctionsTest.test_parameter): Verifies Parameter functionality.
2762         (CppFunctionsTest.test_single_line_view): Verifies SingleLineView functionality.
2763         (CppFunctionsTest.test_create_skeleton_parameters): Verifies create_skeleton_parameters.
2764         (CppFunctionsTest.test_find_parameter_name_index): Verifies find_parameter_name_index.
2765         (CppFunctionsTest.test_parameter_list): Does some minimal verification for parameter list.
2766         Much more thorough verification is done as part of FunctionDetectionTest.test_parameter_list.
2767         (FunctionDetectionTest.perform_function_detection): Added support for verifying
2768         the parameters found.
2769         (FunctionDetectionTest.test_function_declaration_detection): Added more function
2770         detection test to verify that we catch the operator functions.
2771         (FunctionDetectionTest.test_ignore_macros): Verify that function detection ignores macros.
2772         (FunctionDetectionTest.test_parameter_list): Added tests to verify the parameter parsing.
2773         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_bad_test_doesnt_break): Removed
2774         because the error. The test is about the bad function name. Fixing the name makes the test exactly like
2775         test_function_length_check_definition_severity1_for_test.
2776
2777 2010-12-25  Patrick Gansterer  <paroga@webkit.org>
2778
2779         Unreviewed WinCE buildfix after r74334.
2780
2781         * CMakeListsWinCE.txt:
2782
2783 2010-12-24  Sheriff Bot  <webkit.review.bot@gmail.com>
2784
2785         Unreviewed, rolling out r74632.
2786         http://trac.webkit.org/changeset/74632
2787         https://bugs.webkit.org/show_bug.cgi?id=51600
2788
2789         makes test-webkitpy hang forever on GTK (Requested by philn-tp
2790         on #webkit).
2791
2792         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
2793         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
2794
2795 2010-12-24  Ryuan Choi  <ryuan.choi@samsung.com>
2796
2797         Reviewed by Kenneth Rohde Christiansen.
2798
2799         [EFL] Screen doesn't be rendered when changing size of EWebLauncher
2800         https://bugs.webkit.org/show_bug.cgi?id=43528
2801
2802         Remove on_resize because ewk_view_fixed_layout_size_set should not be
2803         called on callback of EVAS_CALLBACK_RESIZE. As it change size of
2804         FrameView, rendering was ignored when _ewk_view_smart_calculate was
2805         called.
2806
2807         * EWebLauncher/main.c:
2808         (browserCreate):
2809
2810 2010-12-24  Eric Seidel  <eric@webkit.org>
2811
2812         Reviewed by Adam Barth.
2813
2814         webkit-patch (or a pre-commit hook) needs to prevent bad ChangeLog changes
2815         https://bugs.webkit.org/show_bug.cgi?id=28291
2816
2817         This is a start.  At least now webkit-patch will prompt when your ChangeLog looks questionable.
2818         We could do more advanced things, like parsing the ChangeLog (with changelog.py) and comparing that
2819         to strings with find in the diff.
2820         Since non-interactive always returns the default, this should cause patches with bad changelogs to fail on the commit-queue.
2821
2822         * Scripts/webkitpy/common/checkout/api.py:
2823         * Scripts/webkitpy/common/checkout/diff_parser.py:
2824         * Scripts/webkitpy/tool/steps/abstractstep.py:
2825         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
2826         * Scripts/webkitpy/tool/steps/validatechangelogs.py: Copied from Tools/Scripts/webkitpy/tool/steps/validatereviewer.py.
2827         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py: Copied from Tools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.
2828         * Scripts/webkitpy/tool/steps/validatereviewer.py:
2829
2830 2010-12-24  Dirk Pranke  <dpranke@chromium.org>
2831
2832         Reviewed by Kenneth Russell.
2833
2834         Modify new-run-webkit-tests to shut up and exit when all the threads
2835         are wedged so that test runs complete faster and we don't end up
2836         w/ enormous log files.
2837
2838         https://bugs.webkit.org/show_bug.cgi?id=51572
2839
2840         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
2841         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
2842
2843 2010-12-24  Eric Seidel  <eric@webkit.org>
2844
2845         Reviewed by David Levin.
2846
2847         commit-queue should better explain how it will re-open bugs and follow duplicate chains
2848         https://bugs.webkit.org/show_bug.cgi?id=51549
2849
2850         I've had multiple people ask me about the commit-queue's behavior
2851         regarding reporting flaky tests.  I figured it would be best to just
2852         have the queue explain itself in the bugs it files.
2853
2854         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2855         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2856
2857 2010-12-24  Shinichiro Hamaji  <hamaji@chromium.org>
2858
2859         Reviewed by Eric Seidel.
2860
2861         check-webkit-style: should ignore "wrong" namings in JavaScriptCore/qt
2862         https://bugs.webkit.org/show_bug.cgi?id=51467
2863
2864         * Scripts/webkitpy/style/checker.py:
2865         * Scripts/webkitpy/style/checker_unittest.py:
2866
2867 2010-12-23  Adam Barth  <abarth@webkit.org>
2868
2869         Rubber-stamped by Eric Seidel.
2870
2871         Move JavaScriptGlue into Sources
2872         https://bugs.webkit.org/show_bug.cgi?id=51583
2873
2874         These tools refer to JavaScriptGlue and need to be updated to its new
2875         location.
2876
2877         * Scripts/build-webkit:
2878         * Scripts/do-file-rename:
2879         * Scripts/do-webcore-rename:
2880         * Scripts/webkitpy/common/config/build.py:
2881         * Scripts/webkitpy/common/config/build_unittest.py:
2882
2883 2010-12-23  Lucas Forschler  <lforschler@apple.com>
2884
2885         Reviewed by Eric Seidel.
2886
2887         Bug 51539 - update iexploder scripts to point to new location
2888
2889         * Scripts/run-iexploder-tests:
2890         * Scripts/update-iexploder-cssproperties:
2891
2892 2010-12-23  Evan Martin  <evan@chromium.org>
2893
2894         Reviewed by Ryosuke Niwa.
2895
2896         [chromium] LayoutTestController warning in float->int conversion
2897         https://bugs.webkit.org/show_bug.cgi?id=51553
2898
2899         Rather than reading an int, converting to a float, then getting a compiler
2900         warning on passing the float to something that expects an int, instead
2901         just pass around ints.
2902
2903         No tests, fixes a compiler warning.
2904
2905         * DumpRenderTree/chromium/LayoutTestController.cpp:
2906         (parsePageSizeParameters):
2907         (LayoutTestController::pageNumberForElementById):
2908         (LayoutTestController::numberOfPages):
2909
2910 2010-12-23  Lucas Forschler  <lforschler@apple.com>
2911
2912         Reviewed by Darin Adler.
2913
2914         Bug 51537 - iexploder needs cleanup
2915
2916         * iExploder/htdocs: Removed.
2917         * iExploder/htdocs/config.rb: Removed.
2918         * iExploder/htdocs/cssproperties.in: Removed.
2919         * iExploder/htdocs/cssvalues.in: Removed.
2920         * iExploder/htdocs/htmlattrs.in: Removed.
2921         * iExploder/htdocs/htmltags.in: Removed.
2922         * iExploder/htdocs/htmlvalues.in: Removed.
2923         * iExploder/htdocs/iexploder.cgi: Removed.
2924         * iExploder/htdocs/iexploder.rb: Removed.
2925         * iExploder/htdocs/index.html: Removed.
2926         * iExploder/htdocs/webserver.rb: Removed.
2927         * iExploder/iexploder-1.7.2/output: Removed.
2928         * iExploder/tools: Removed.
2929         * iExploder/tools/lasthit.rb: Removed.
2930         * iExploder/tools/osx_last_crash.rb: Removed.
2931         * iExploder/tools/showtest.rb: Removed.
2932
2933 2010-12-23  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
2934
2935         Reviewed by Kenneth Rohde Christiansen.
2936
2937         [EFL] Make 'single' the default backing store in EWebLauncher
2938         https://bugs.webkit.org/show_bug.cgi?id=51534
2939
2940         'single' is the simplest backing store and the one intended to be the
2941         default in the test browser. By mistake the tiled backing store was
2942         left as default in r72617.
2943
2944         * EWebLauncher/main.c:
2945         (browserCreate): ditto.
2946
2947 2010-12-23  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
2948
2949         Reviewed by Kenneth Rohde Christiansen.
2950
2951         [EFL] Subject: [webkit 4/4] [EFL] Remove non-sense workaround
2952         https://bugs.webkit.org/show_bug.cgi?id=51533
2953
2954         There's no point in concatenating env("HOME") with "blah", so remove
2955         option from EWebLauncher.
2956
2957         * EWebLauncher/main.c:
2958         (main): ditto.
2959
2960 2010-12-23  Ilya Tikhonovsky  <loislo@chromium.org>
2961
2962         Reviewed by Eric Seidel.
2963
2964         Web Inspector: chromium: inspector's tests are quite slow especially at windows(Debug).
2965
2966         Almost all inspector's tests become flaky on chromium Win(dbg) after switching to DRT.
2967         I just discovered that we have two additional GC runs per each WebViewHost.
2968         Test_shell had no such calls.
2969         These gc runs eat 15% of cpu time.
2970
2971         https://bugs.webkit.org/show_bug.cgi?id=51479
2972
2973         * DumpRenderTree/chromium/WebViewHost.cpp:
2974         (WebViewHost::~WebViewHost):
2975
2976 2010-12-22  Dirk Pranke  <dpranke@chromium.org>
2977
2978         Reviewed by Ojan Vafai.
2979
2980         This change splits out the TestRunner class into its own file.
2981         When we fork the code for message passing, we will create a new
2982         TestRunner, and this change will allow that to be more modular.
2983
2984         While we're at it, split out TestInput and ResultSummary into
2985         their own files, to reduce the size of run_webkit_tests to
2986         something more managable.
2987
2988         https://bugs.webkit.org/show_bug.cgi?id=51092
2989
2990         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2991         * Scripts/webkitpy/layout_tests/layout_package/result_summary.py:
2992         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2993         * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
2994         * Scripts/webkitpy/layout_tests/layout_package/test_input.py:
2995         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2996         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2997
2998  2010-12-22  Dirk Pranke  <dpranke@chromium.org>
2999
3000         Reviewed by Ojan Vafai.
3001
3002         nrwt multiprocessing - start over, prepare to fork the code
3003
3004         This code cleans up the signatures and implementation of the
3005         TestRunner class so we can easily fork it to run either the
3006         stable implementation or the new, unstable message-passing
3007         implementation. The two variants will have different
3008         implementations of the run_tests() method. We will switch
3009         between the two based on the setting for the '--worker-model'
3010         switch. We rename the two currently valid values to 'old-inline'
3011         and 'old-threads'.
3012
3013         https://bugs.webkit.org/show_bug.cgi?id=51081
3014
3015         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3016         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3017
3018 2010-12-22  Victor Wang  <victorw@chromium.org>
3019
3020         Reviewed by Darin Fisher.
3021
3022         [Chromium] Update chromium archive test result url in rebaseline script.
3023
3024         https://bugs.webkit.org/show_bug.cgi?id=51503
3025
3026         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
3027
3028 2010-12-22  Lucas Forschler  <lforschler@apple.com>
3029
3030         Reviewed by Alice Liu.
3031
3032         <rdar://problem/8633222> record-memory-win needs to record memory used by the webprocess.
3033         Verified on Chrome, Safari, and IE.
3034         With this change, we will record memory from a parent browser window and all child processes.
3035
3036         * record-memory-win/main.cpp:
3037         (ProcessArgs):
3038         (PrintUsage):
3039         (getMemoryInfo):
3040         (printProcessInfo):
3041         (evalProcesses):
3042         (UseImage):
3043         (QueryContinuously):
3044         (ElapsedTime):
3045
3046 2010-12-22  Lucas Forschler  <lforschler@apple.com>
3047
3048         Unreviewed rollout r74489, because it was missing changelog.
3049
3050         * record-memory-win/main.cpp:
3051
3052 2010-12-22  Ryosuke Niwa  <rniwa@webkit.org>
3053
3054         Adding myself as a reviewer.
3055
3056         * Scripts/webkitpy/common/config/committers.py:
3057
3058 2010-12-22  Andrew Scherkus  <scherkus@chromium.org>
3059
3060         Unreviewed.  Adding myself to committers.py.
3061
3062         * Scripts/webkitpy/common/config/committers.py:
3063
3064 2010-12-22  Ariya Hidayat  <ariya@sencha.com>
3065
3066         Reviewed by Kenneth Rohde Christiansen.
3067
3068         TestNetscapePlugIn should use #if defined
3069         https://bugs.webkit.org/show_bug.cgi?id=51471
3070
3071         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3072         (NP_Initialize):
3073         (NPP_New):
3074
3075 2010-12-22  Ilya Tikhonovsky  <loislo@chromium.org>
3076
3077         Reviewed by Yury Semikhatsky.
3078
3079         Web Inspector: [chromium] DRT inspector layout tests are flaky in debug.
3080
3081         DevTools window should be closed explicitly because it has custom deinitialization code.
3082
3083         https://bugs.webkit.org/show_bug.cgi?id=50722
3084
3085         * DumpRenderTree/chromium/TestShell.cpp:
3086         (TestShell::closeRemainingWindows):
3087
3088 2010-12-22  David Levin  <levin@chromium.org>
3089
3090         Reviewed by Shinichiro Hamaji.
3091
3092         check-webkit-style shouldn't complaint about underscores in variables in objective C files.
3093         https://bugs.webkit.org/show_bug.cgi?id=51452
3094
3095         * Scripts/webkitpy/style/checkers/cpp.py:
3096         (_FileState.__init__): Added the information to determine if a file is C or Objective C.
3097         Using the file extension if possible but falling back to the file contents if we have a header file.
3098         (_FileState.is_objective_c): Determine if we have an Objective C by examining the file contents if needed.
3099         (_FileState.is_c_or_objective_c):
3100         (check_using_std): Changed to using _FileState to determine the file type.
3101         (check_max_min_macros): Ditto.
3102         (check_for_null): Ditto.
3103         (check_style): Changed the parameters to various calls since they now need _FileState
3104         to determine the file type.
3105         (check_language): Added the file_state parameter so it could be passed
3106         to check_identifier_name_in_declaration.
3107         (check_identifier_name_in_declaration): Don't warn about underscores in variables if
3108         this is an Objective C file.
3109         (_process_lines): Added information for the _FileState constructor (and moved the
3110         call to a place that had the information).
3111         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3112         (CppFunctionsTest.test_is_c_or_objective_c): Changed the tests to use FileState and exercise
3113         its functionality.
3114         (WebKitStyleTest.test_names): Add tests for underscores in Objective C files.
3115
3116 2010-12-21  Andy Estes  <aestes@apple.com>
3117
3118         Reviewed by Mark Rowe.
3119
3120         Do not build non-Intel architectures for WebKit2-related projects.
3121         https://bugs.webkit.org/show_bug.cgi?id=51440
3122
3123         * MiniBrowser/Configurations/Base.xcconfig: Only build for i386 and x86_64.
3124         * TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
3125         * WebKitTestRunner/Configurations/Base.xcconfig: Ditto.
3126
3127 2010-12-21  Mihai Parparita  <mihaip@chromium.org>
3128
3129         Reviewed by Darin Fisher.
3130
3131         [Chromium] Rename WebThemeEngine/ControlDRT to WebThemeEngine/ControlDRTWin
3132         https://bugs.webkit.org/show_bug.cgi?id=51406
3133
3134         Rename WebThemeControlDRT to WebThemeControlDRTWin and WebThemeEngineDRT
3135         to WebThemeEngineDRTWin and update references everywhere.
3136
3137         * DumpRenderTree/DumpRenderTree.gypi:
3138         * DumpRenderTree/chromium/TestShellWin.cpp:
3139         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRT.cpp.
3140         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRT.h.
3141         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRT.cpp.
3142         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRT.h.
3143
3144 2010-12-21  Anders Carlsson  <andersca@apple.com>
3145
3146         Reviewed by John Sullivan.
3147
3148         Clicking missing plug-in text does not show a sheet
3149         https://bugs.webkit.org/show_bug.cgi?id=51403
3150
3151         Update for changes to the WebPageUIClient.
3152
3153         * MiniBrowser/mac/BrowserWindowController.m:
3154         (-[BrowserWindowController awakeFromNib]):
3155         * WebKitTestRunner/TestController.cpp:
3156         (WTR::createOtherPage):
3157         (WTR::TestController::initialize):
3158
3159 2010-12-21  Eric Seidel  <eric@webkit.org>
3160
3161         Reviewed by Adam Barth.
3162
3163         commit-queue will report constant failures as flaky if other tests flake
3164         https://bugs.webkit.org/show_bug.cgi?id=51272
3165
3166         This patch just removes functionality and adds testing.
3167         Previously we attempted to report flaky tests when we had
3168         two different tests fail in a row.  However, since we stop
3169         running the tests at the first failure, our code was wrong in
3170         trying to determine flakiness from the incomplete runs.
3171
3172         Originally I posted an alternate patch:
3173         https://bug-51272-attachments.webkit.org/attachment.cgi?id=77078
3174         which fixed our flaky logic in this case, however it was decided
3175         that that patch would be too difficult to maintain, so now
3176         I'm just removing the broken logic.
3177
3178         This will dramatically cut-down on our flaky-test false positives
3179         at the (small) cost of the queues being unable to report
3180         any flakiness if the tree is very flaky.  (With at least one test
3181         flaking on every run, we'll never report failures anymore.)  I think
3182         this is a tradeoff worth making.
3183
3184         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3185         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3186
3187 2010-12-20  Eric Seidel  <eric@webkit.org>
3188
3189         Reviewed by Adam Barth.
3190
3191         commit-queue wrongly rejects patches when it can't update itself
3192         https://bugs.webkit.org/show_bug.cgi?id=46636
3193
3194         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3195         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3196         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3197
3198 2010-12-20  Adam Barth  <abarth@webkit.org>
3199
3200         Move web sites to Websites directory
3201         https://bugs.webkit.org/show_bug.cgi?id=51323
3202
3203         Update references to BugsSite to point to the new location.
3204
3205         This patch was never officially reviewed (because it was too large to
3206         upload to bugs.webkit.org), but it was discussed on webkit-dev and Mark
3207         Rowe gave me the green light.
3208
3209         * Scripts/old-run-webkit-tests:
3210         * Scripts/webkitpy/common/config/build.py:
3211         * Scripts/webkitpy/common/config/build_unittest.py:
3212         * Scripts/webkitpy/common/prettypatch.py:
3213         * Scripts/webkitpy/layout_tests/port/base.py:
3214         * Scripts/webkitpy/style/main.py:
3215
3216 2010-12-20  Adrienne Walker  <enne@google.com>
3217
3218         Unreviewed. Adding myself to the list of committers.
3219
3220         * webkitpy/common/config/committers.py:
3221
3222 2010-12-20  Mark Rowe  <mrowe@apple.com>
3223
3224         Reviewed by Dan Bernstein.
3225
3226         <rdar://problem/8757601> Don't install header files in to the Resources directory.
3227
3228         * Scripts/check-for-inappropriate-files-in-framework: Don't allow .h files in the
3229         Resources directory.
3230
3231 2010-12-20  Eric Seidel  <eric@webkit.org>
3232
3233         Reviewed by Adam Barth.
3234
3235         commit-queue should include bot id when attaching failure diffs
3236         https://bugs.webkit.org/show_bug.cgi?id=51280
3237
3238         This is a tiny change to include the bot id in the name of the attachment.
3239         Most of this diff is just changing the unit test expectations
3240         now that I hid the comment printing when the comment is None.
3241
3242         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3243         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3244         * Scripts/webkitpy/tool/commands/upload_unittest.py:
3245         * Scripts/webkitpy/tool/mocktool.py:
3246
3247 2010-12-20  Jeff Miller  <jeffm@apple.com>
3248
3249         Reviewed by Dan Bernstein.
3250
3251         Tools/vcbin/midl.exe needs to be rebuilt
3252         https://bugs.webkit.org/show_bug.cgi?id=51347
3253
3254         * vcbin/midl.exe: Rebuilt.
3255
3256 2010-12-20  David Levin  <levin@chromium.org>
3257
3258         Reviewed by Ariya Hidayat.
3259
3260         .gitignore and webkit-tools-completion.sh have references to WebKitTools that should be Tools.
3261         https://bugs.webkit.org/show_bug.cgi?id=51343
3262
3263         Follow up from the WebKitTools -> Tools rename.
3264
3265         * Scripts/webkit-tools-completion.sh:
3266
3267 2010-12-20  Cosmin Truta  <ctruta@chromium.org>
3268
3269         Reviewed by James Robinson.
3270
3271         new-run-webkit-tests ignores trailing EOL differences in text tests
3272         https://bugs.webkit.org/show_bug.cgi?id=36983
3273
3274         Changed the handling of new-line characters within new-run-webkit-tests
3275         to match old-run-webkit-tests.  Differences in leading and trailing empty
3276         lines in text expectation files are no longer ignored.
3277
3278         * Scripts/webkitpy/layout_tests/port/base.py:
3279         * Scripts/webkitpy/layout_tests/port/test.py:
3280         Added unit tests.  Removed old duplicate unit test entries.
3281         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
3282
3283 2010-12-20  David Levin  <levin@chromium.org>
3284
3285         Reviewed by Shinichiro Hamaji.
3286
3287         check-webkit-style should detect function declarations (and trivial functions).
3288         https://bugs.webkit.org/show_bug.cgi?id=51303
3289
3290         * Scripts/webkitpy/style/checkers/cpp.py:
3291         (_FunctionState.begin): Add is_declaration and changed the line count
3292         start to begin at -1 (which will keep the results consistent, since
3293         the starting line number passed in is one less in this change).
3294         (detect_functions): changed function detection to now catch trivial
3295         functions and declarations.
3296         (check_pass_ptr_usage): Don't check for Pass*Ptr on the first line
3297         of the function as this may look at return values (when processing
3298         a declaration).
3299         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3300         (FunctionDetectionTest.perform_function_detection): Basic mechanics
3301         of testing the function detection.
3302         (FunctionDetectionTest.test_basic_function_detection): Test a simple
3303         function.
3304         (FunctionDetectionTest.test_function_declaration_detection): Test a
3305         declaration.
3306         (FunctionDetectionTest.test_non_functions): A test case for a case
3307         that caused the code to fail due to the { being in quotes.
3308         (PassPtrTest.test_pass_ref_ptr_return_value): Added some more test
3309         cases to help catch false alarms for return values.
3310         (PassPtrTest.test_pass_ref_ptr_member_variable): Ensure that
3311         we don't get false alarms for member variables either.
3312
3313 2010-12-20  Ryuan Choi  <ryuan.choi@samsung.com>
3314
3315         Reviewed by Antonio Gomes.
3316
3317         [CMAKE] Rename WEBKITTOOLS_DIR to TOOLS_DIR
3318         https://bugs.webkit.org/show_bug.cgi?id=51319
3319
3320         * CMakeListsEfl.txt:
3321
3322 2010-12-18  Adam Barth  <abarth@webkit.org>
3323
3324         Reviewed by Sam Weinig.
3325
3326         Move WebKitExamplePlugins to Examples
3327         https://bugs.webkit.org/show_bug.cgi?id=51291
3328
3329         * Scripts/webkitpy/common/config/build.py:
3330
3331 2010-12-17  Csaba Osztrogonác  <ossy@webkit.org>
3332
3333         Unreviewed Qt buildfix after r74301.
3334
3335         Rename WebKitTools to Tools
3336         https://bugs.webkit.org/show_bug.cgi?id=49861
3337
3338         * MiniBrowser/DerivedSources.pro:
3339         * MiniBrowser/qt/MiniBrowser.pro:
3340
3341 2010-12-17  Dan Bernstein  <mitz@apple.com>
3342
3343         Reviewed by Simon Fraser.
3344
3345         Rename WebKitTools to Tools
3346         https://bugs.webkit.org/show_bug.cgi?id=49861
3347
3348         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3349         * CodeCoverage/README:
3350         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3351         (WebCore::DumpRenderTree::initializeFonts):
3352         * EWSTools/start-commit-queue.sh:
3353         * EWSTools/start-queue.sh:
3354         * GNUmakefile.am:
3355         * MIDLWrapper/MIDLWrapper.cpp:
3356         (wmain):
3357         * MiniBrowser/qt/MiniBrowser.pro:
3358         * Scripts/build-api-tests:
3359         * Scripts/build-dumprendertree:
3360         * Scripts/build-webkit:
3361         * Scripts/build-webkittestrunner:
3362         * Scripts/generate-coverage-data:
3363         * Scripts/old-run-webkit-tests:
3364         * Scripts/run-api-tests:
3365         * Scripts/run-iexploder-tests:
3366         * Scripts/run-javascriptcore-tests:
3367         * Scripts/run-mangleme-tests:
3368         * Scripts/run-sunspider:
3369         * Scripts/run-webkit-websocketserver:
3370         * Scripts/sunspider-compare-results:
3371         * Scripts/test-webkitperl:
3372         * Scripts/test-webkitpy:
3373         * Scripts/update-iexploder-cssproperties:
3374         * Scripts/update-webkit:
3375         * Scripts/update-webkit-localizable-strings:
3376         * Scripts/webkitdirs.pm:
3377         * Scripts/webkitpy/common/checkout/scm.py:
3378         * Scripts/webkitpy/common/checkout/scm_unittest.py:
3379         * Scripts/webkitpy/common/config/committervalidator.py:
3380         * Scripts/webkitpy/common/config/committervalidator_unittest.py:
3381         * Scripts/webkitpy/common/config/ports.py:
3382         * Scripts/webkitpy/common/config/ports_unittest.py:
3383         * Scripts/webkitpy/common/system/logutils_unittest.py:
3384         * Scripts/webkitpy/common/system/ospath_unittest.py:
3385         * Scripts/webkitpy/layout_tests/port/chromium.py:
3386         * Scripts/webkitpy/layout_tests/port/config.py:
3387         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
3388         * Scripts/webkitpy/layout_tests/port/http_server.py:
3389         * Scripts/webkitpy/layout_tests/port/test.py:
3390         * Scripts/webkitpy/style/checker.py:
3391         * Scripts/webkitpy/style/checker_unittest.py:
3392         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
3393         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3394         * Scripts/webkitpy/tool/steps/steps_unittest.py:
3395         * WebKitTestRunner/DerivedSources.pro:
3396         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
3397         (WTR::activateFonts):
3398         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3399         * wx/build/build_utils.py:
3400
3401 2010-12-16  Antonio Gomes  <agomes@rim.com>
3402
3403         Reviewed by Martin Robinson.
3404
3405         Settings::editingBehaviorType() incorrectly returns mac for the gtk build when running tests
3406         https://bugs.webkit.org/show_bug.cgi?id=51163
3407
3408         Since GTK+'s default editing behavior was changed to UNIX in r70975 (see webkitwebsettings.cpp),
3409         GTK+'s DRT should also reset to UNIX after each test execution.
3410
3411         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3412         (resetDefaultsToConsistentValues):
3413
3414 2010-12-17  David Levin  <levin@chromium.org>
3415
3416         Reviewed by Eric Seidel.
3417
3418         check-webkit-style should understand WTF #include guards
3419         https://bugs.webkit.org/show_bug.cgi?id=44911
3420
3421         * Scripts/webkitpy/style/checkers/cpp.py:
3422         (get_header_guard_cpp_variable): modify to suggest the WTF style
3423         of header guard when appropriate.
3424         (check_for_header_guard): handle multiple return values from
3425         get_header_guard_cpp_variable
3426         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3427         (CppStyleTest.test_build_header_guard): Added tests for the WTF
3428         header style.
3429
3430 2010-12-16  David Levin  <levin@chromium.org>
3431
3432         Reviewed by Eric Seidel.
3433
3434         test-webkitpy: unittest for the xml.py checker displays a decprecation warning.
3435         https://bugs.webkit.org/show_bug.cgi?id=51210
3436
3437         The error only shows up when using python 2.6 or later.
3438
3439         * Scripts/webkitpy/style/checkers/xml.py: Replace the usage of
3440         the decprecated field error,message with something equivalent.
3441
3442 2010-12-16  Mihai Parparita  <mihaip@chromium.org>
3443
3444         Reviewed by Eric Seidel.
3445
3446         Add --exit-after-n-failures/crashes to NRWT
3447         https://bugs.webkit.org/show_bug.cgi?id=51160
3448
3449         Abort test run (in a similar way to how control-C is handled) when
3450         --exit-after-n-failures/crashes-or-timeouts are passed and we've reached
3451         that number of unexpected failures/crashes/timeouts.
3452
3453         * Scripts/webkitpy/layout_tests/port/test.py:
3454         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3455         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3456
3457 2010-12-16  David Levin  <levin@chromium.org>
3458
3459         Reviewed by Shinichiro Hamaji.
3460
3461         check-webkit-style unit tests has some duplicate boilerplate code.
3462         https://bugs.webkit.org/show_bug.cgi?id=49519
3463
3464         * Scripts/webkitpy/style/checkers/cpp.py:
3465         (update_include_state): Replaced the "io" parameter with the global
3466         configuration _unit_test_config. This allowed not calling into
3467         functions at a low level and also not plumbing through the injection
3468         information through many levels of code.
3469         (check_for_include_what_you_use): Ditto.
3470         (process_file_data): Added the ability to set up the unit test config
3471         to allow for injection.
3472         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3473         (ErrorCollector.__init__): Added support for having a filter for errors.
3474         (ErrorCollector.__call__): Ditto.
3475         (CppStyleTestBase.process_file_data): Added the ability to set unit_test_config.
3476         (CppStyleTestBase.perform_lint): Consolidated logic for the perform functions.
3477         (CppStyleTestBase.perform_single_line_lint): Replace specific calls to
3478         functions in the cpp.py with generic processing and a filter that
3479         indicates what errors should be kept.
3480         (CppStyleTestBase.perform_multi_line_lint): Ditto.
3481         (CppStyleTestBase.perform_language_rules_check): Ditto.
3482         (CppStyleTestBase.perform_function_lengths_check): Ditto.
3483         (CppStyleTestBase.perform_pass_ptr_check): Ditto.
3484         (CppStyleTestBase.perform_include_what_you_use): Ditto.
3485         (CppStyleTest.test_multi_line_comments): Added another
3486         error message which applies to the test case.
3487         (CppStyleTest.test_spacing_for_binary_ops): Fixed test
3488         to not have config.h, since it is processed as a header file.
3489         (CppStyleTest.test_static_or_global_stlstrings): Fixed variable name
3490         style and indentation in checked code.
3491         (OrderOfIncludesTest.test_check_preprocessor_in_include_section):
3492         Fixed line number.
3493         (NoNonVirtualDestructorsTest.test_multi_line_declaration_with_error):
3494         Ditto.
3495
3496 2010-12-15  Sheriff Bot  <webkit.review.bot@gmail.com>
3497
3498         Unreviewed, rolling out r74136.
3499         http://trac.webkit.org/changeset/74136
3500         https://bugs.webkit.org/show_bug.cgi?id=51135
3501
3502         r74136 breaks chromium canary bots because some tests are not
3503         rebaselined correctly to resolve EOL differences (Requested by
3504         jianli on #webkit).
3505
3506         * Scripts/webkitpy/layout_tests/port/base.py:
3507         * Scripts/webkitpy/layout_tests/port/test.py:
3508         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
3509
3510 2010-12-15  Adam Roben  <aroben@apple.com>
3511
3512         Teach check-webkit-style to check .vcproj and .vsprops files for XML
3513         syntax errors
3514
3515         Fixes <http://webkit.org/b/51103> check-webkit-style should check for
3516         XML syntax errors in .vcproj/.vsprops files
3517
3518         Reviewed by Dave Levin.
3519
3520         * Scripts/webkitpy/style/checker.py: Added lists of file extensions
3521         that should be treated as XML and that should be allowed to contain
3522         carriage returns. (These lists happen to be identical currently.)
3523         (FileType): Added a new XML type.
3524         (CheckerDispatcher.should_check_and_strip_carriage_returns): Added.
3525         Just does a simple file extension check.
3526         (CheckerDispatcher._file_type): Added a case for XML files.
3527         (CheckerDispatcher._create_checker): Ditto. We use XMLChecker for XML
3528         files (surprise!).
3529         (StyleProcessor.process): Ask the dispatcher whether we should pass the
3530         lines through the carriage checker.
3531
3532         * Scripts/webkitpy/style/checker_unittest.py:
3533         (CheckerDispatcherCarriageReturnTest.test_should_check_and_strip_carriage_returns):
3534         Added. Checks a few file names to see if carriage returns are allowed
3535         or not.
3536         (CheckerDispatcherDispatchTest.assert_checker_xml): Added. Similar to
3537         other assert_checker_* functions.
3538         (CheckerDispatcherDispatchTest.test_xml_paths): Added. Similar to other
3539         test_*_paths functions.
3540         (CheckerDispatcherDispatchTest.test_xml_paths): Added. Similar to other
3541         test_*_paths functions.
3542         (CheckerDispatcherDispatchTest.test_none_paths): Removed the vcproj
3543         file from this test case, as vcproj files now have a type.
3544         (StyleProcessor_CodeCoverageTest.MockDispatcher.should_check_and_strip_carriage_returns):
3545         Added. Similar to the other should_* functions.
3546         (StyleProcessor_CodeCoverageTest.test_process__carriage_returns_not_stripped):
3547         Added. Checks that carriage returns aren't checked for or stripped for
3548         allowed files.
3549
3550         * Scripts/webkitpy/style/checkers/xml.py: Added.
3551         (XMLChecker.__init__): Simple init method.
3552         (XMLChecker.check): Pass each line through the expat parser, and record
3553         a style error for any errors thrown by the parser.
3554
3555         * Scripts/webkitpy/style/checkers/xml_unittest.py: Added.
3556         (XMLCheckerTest.assert_no_error): Checks that the given XML does not
3557         produce a style error.
3558         (XMLCheckerTest.assert_error): Checks that the given XML produces an
3559         error of the given category on the given line.
3560         (XMLCheckerTest.mock_handle_style_error): Does nothing. Used for
3561         checking that the XMLChecker constructor works properly.
3562         (XMLCheckerTest.test_conflict_marker): Tests that conflict markers
3563         cause a style error (see, e.g., r73887).
3564         (XMLCheckerTest.test_extra_closing_tag): Tests that extra closing tags
3565         cause a style error (see, e.g., r73773).
3566         (XMLCheckerTest.test_init): Tests that the XMLChecker constructor works
3567         properly.
3568         (XMLCheckerTest.test_missing_closing_tag): Tests that missing closing
3569         tags cause a style error (see, e.g., r72795).
3570         (XMLCheckerTest.test_no_error): Tests that valid XML does not cause a
3571         style error.
3572
3573 2010-12-15  Lucas Forschler  <lforschler@apple.com>
3574
3575         Reviewed by Stephanie Lewis.
3576
3577         https://bugs.webkit.org/show_bug.cgi?id=51117
3578         Add a new leopard test bot
3579         really really commit to trunk this time.
3580
3581         * BuildSlaveSupport/build.webkit.org-config/config.json:
3582
3583 2010-12-15  Sam Weinig  <sam@webkit.org>
3584
3585         Reviewed by Anders Carlsson.
3586
3587         WebKit2: Can't add files to an <input type=file>
3588         https://bugs.webkit.org/show_bug.cgi?id=51087
3589
3590         * MiniBrowser/mac/BrowserWindowController.m:
3591         (runOpenPanel):
3592         (-[BrowserWindowController awakeFromNib]):
3593         Add simple implementation of runOpenPanel callback.
3594
3595         * MiniBrowser/win/BrowserView.cpp:
3596         (BrowserView::create):
3597         * WebKitTestRunner/TestController.cpp:
3598         (WTR::createOtherPage):
3599         (WTR::TestController::initialize):
3600         Stub out runOpenPanel callback.
3601
3602 2010-12-14  Eric Seidel  <eric@webkit.org>
3603
3604         Reviewed by Adam Barth.
3605
3606         commit-queue should upload failure diffs when tests flake
3607         https://bugs.webkit.org/show_bug.cgi?id=51051
3608
3609         To make this testable I needed to pipe FileSystem down onto tool.
3610         We've wanted it there for a long time anyway.
3611
3612         This patch is kinda a big hack.  But we don't have a nice
3613         way to read results.html files.  I think this will need further
3614         revision before this code actually feels clean.
3615
3616         As part of testing this change, I had to make MockBugzilla.create_bug
3617         actually return an id (like it should) which required updating
3618         a few other unit test results (for the better).
3619
3620         The results_matching_keys change in layouttestresults/rebasline
3621         was an alternate path which I decided not to use in the end, but
3622         I left the change as it seemed an improvement.
3623
3624         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3625         * Scripts/webkitpy/common/net/layouttestresults.py:
3626         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3627         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3628         * Scripts/webkitpy/tool/commands/queues.py:
3629         * Scripts/webkitpy/tool/commands/rebaseline.py:
3630         * Scripts/webkitpy/tool/main.py:
3631         * Scripts/webkitpy/tool/mocktool.py:
3632
3633 2010-12-15  Cosmin Truta  <ctruta@chromium.org>
3634
3635         Reviewed by James Robinson.
3636
3637         new-run-webkit-tests ignores trailing EOL differences in text tests
3638         https://bugs.webkit.org/show_bug.cgi?id=36983
3639
3640         Changed the handling of new-line characters within new-run-webkit-tests
3641         to match old-run-webkit-tests.  Differences in leading and trailing empty
3642         lines in text expectation files are no longer ignored.
3643
3644         * Scripts/webkitpy/layout_tests/port/base.py:
3645         * Scripts/webkitpy/layout_tests/port/test.py:
3646         Added unit tests.  Removed old duplicate unit test entries.
3647         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
3648
3649 2010-12-15  Ojan Vafai  <ojan@chromium.org>
3650
3651         Reviewed by Adam Barth.
3652
3653         make status-bubble white-space:nowrap so we can measure it's width without wrapping
3654         https://bugs.webkit.org/show_bug.cgi?id=51149
3655
3656         * QueueStatusServer/templates/statusbubble.html:
3657
3658 2010-12-15  Ojan Vafai  <ojan@chromium.org>
3659
3660         Reviewed by Adam Barth.
3661
3662         have the statusbubble postMessage it's metrics so that embedders can properly size the iframe
3663         https://bugs.webkit.org/show_bug.cgi?id=51125
3664
3665         * QueueStatusServer/templates/statusbubble.html:
3666
3667 2010-12-15  Darin Adler  <darin@apple.com>
3668
3669         * Scripts/webkitpy/common/net/buildbot: Added property svn:ignore.
3670
3671 2010-12-15  Sheriff Bot  <webkit.review.bot@gmail.com>
3672
3673         Unreviewed, rolling out r74117.
3674         http://trac.webkit.org/changeset/74117
3675         https://bugs.webkit.org/show_bug.cgi?id=51113
3676
3677         This broke the GTK1 build. (Requested by mrobinson on
3678         #webkit).
3679
3680         * Scripts/webkitdirs.pm:
3681
3682 2010-12-15  Amruth Raj  <amruthraj@motorola.com> and Ravi Kasibhatla  <ravi.kasibhatla@motorola.com>
3683
3684         Reviewed by Martin Robinson.
3685
3686         Change generate-forwarding-headers.pl for GTK port usage
3687         (https://bugs.webkit.org/show_bug.cgi?id=37369)
3688
3689         * Scripts/webkitdirs.pm: Added changes to build webkit2 for GTK port using build-webkit script.
3690
3691 2010-12-14  Kent Tamura  <tkent@chromium.org>
3692
3693         Reviewed by Jian Li.
3694
3695         [DRT/Chromium] Remove another unnecessary error message
3696         https://bugs.webkit.org/show_bug.cgi?id=51083
3697
3698         * DumpRenderTree/chromium/WebViewHost.cpp:
3699         (WebViewHost::didInvalidateRect):
3700
3701 2010-12-14  Lucas Forschler  <lforschler@apple.com>
3702
3703         Reviewed by Stephanie Lewis.
3704
3705         Add a new Leopard Debug Test WK2 Bot
3706
3707         * BuildSlaveSupport/build.webkit.org-config/config.json:
3708
3709 2010-12-14  Ojan Vafai  <ojan@chromium.org>
3710
3711         Fix python unittests after http://trac.webkit.org/changeset/74070.
3712
3713         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
3714
3715 2010-12-14  Kent Tamura  <tkent@chromium.org>
3716
3717         Reviewed by Jian Li.
3718
3719         [DRT/Chromium] Remove a unnecessary error message
3720         https://bugs.webkit.org/show_bug.cgi?id=51069
3721
3722         * DumpRenderTree/chromium/WebViewHost.cpp:
3723         (WebViewHost::paintInvalidatedRegion):
3724
3725 2010-12-14  Benjamin Kalman  <kalman@chromium.org>
3726
3727         Reviewed by Ojan Vafai.
3728
3729         Using BUG/BUGWK in test_expectations is error prone, should use BUGCR/BUGWK
3730         https://bugs.webkit.org/show_bug.cgi?id=48926
3731
3732         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
3733         Add presubmit check that BUG isn't used, either BUGCR/BUGWK/BUGV8_.
3734
3735 2010-12-14  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3736
3737         Reviewed by Eric Seidel.
3738
3739         [Qt] [Symbian] Do not use pkg-config on Symbian as it is not supported
3740         https://bugs.webkit.org/show_bug.cgi?id=50231
3741
3742         Guard CONFIG+=link_pkgconfig with !symbian.
3743
3744         * DumpRenderTree/qt/DumpRenderTree.pro:
3745         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3746         * WebKitTestRunner/qt/WebKitTestRunner.pro:
3747
3748 2010-12-14  Philippe Normand  <pnormand@igalia.com>
3749
3750         Reviewed by Ojan Vafai.
3751
3752         [new-run-webkit-tests] expectations parsing is slow
3753         https://bugs.webkit.org/show_bug.cgi?id=50635
3754
3755         Avoid expensive iteration of all the tests when checking if a test
3756         file is to be skipped or not.
3757
3758         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
3759         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
3760         * Scripts/webkitpy/layout_tests/port/test.py:
3761
3762 2010-12-14  Mario Sanchez Prada  <msanchez@igalia.com>
3763
3764         Reviewed by Xan Lopez.
3765
3766         [Gtk] Implement STATE_FOCUSED, STATE_FOCUSABLE, and corresponding events for text objects
3767         https://bugs.webkit.org/show_bug.cgi?id=27048
3768
3769         Add support in DRT for checking whether an accessibility UI
3770         element is focusable and/or focused. Implemented for GTK.
3771
3772         * DumpRenderTree/AccessibilityUIElement.cpp:
3773         (getIsFocusedCallback): New.
3774         (getIsFocusableCallback): New.
3775         (AccessibilityUIElement::getJSClass): Add the new available
3776         callbacks for isFocused and isFocusable.
3777         * DumpRenderTree/AccessibilityUIElement.h:
3778         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3779         (AccessibilityUIElement::isFocused): New, implemented by checking
3780         whether the related AtkState value is in the object's state set.
3781         (AccessibilityUIElement::isFocusable): Ditto.
3782         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3783         (AccessibilityUIElement::isFocused): New, dummy implementation.
3784         (AccessibilityUIElement::isFocusable): Ditto.
3785         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3786         (AccessibilityUIElement::isFocused): Ditto.
3787         (AccessibilityUIElement::isFocusable): Ditto.
3788
3789 2010-12-14  Eric Seidel  <eric@webkit.org>
3790
3791         Reviewed by Ojan Vafai.
3792
3793         webkit-patch should warn users when they're using a 32-bit git on a 64-bit system
3794         https://bugs.webkit.org/show_bug.cgi?id=50715
3795
3796         This patch makes webkit-patch print the following:
3797
3798         Warning: This machine is 64-bit, but the git binary (/usr/local/git/bin/git) does not support 64-bit.
3799         Install a 64-bit git for better performance, see:
3800         https://lists.webkit.org/pipermail/webkit-dev/2010-December/015249.html
3801
3802         I wrote this mostly because I have approximately 8 machines that I use
3803         and making sure each one is using a good Git install seemed folly.
3804         webkit-patch makes a lot of git calls, so using a fast git can shave
3805         several seconds in every invocation.  See the webkit-dev thread for more info.
3806
3807         This message will print twice during 'webkit-patch upload',
3808         once from webkit-patch and once from check-webkit-style.
3809
3810         Unfortunately there is no good way to test this due to how machine-dependent
3811         the code is.  I considered writing a test for the log message, but it seemed not worth it.
3812
3813         * Scripts/webkitpy/common/checkout/scm.py:
3814
3815 2010-12-13  Eric Seidel  <eric@webkit.org>
3816
3817         Reviewed by Adam Barth.
3818
3819         FlakyTestReporter doesn't understand bots running from multiple email addresses
3820         https://bugs.webkit.org/show_bug.cgi?id=50960
3821
3822         This explains at least one of the dupes of:
3823         https://bugs.webkit.org/show_bug.cgi?id=50863
3824         that we saw filed by the commit-queue this morning.
3825         I think the other one was explained by my previous fix to result counting code.
3826
3827         Since this is really hard to test with a unit test, instead I
3828         create a new (possibly useful in the future) command
3829         which given a layout test path will return you
3830         the one bug which our tools would assume it the flaky test bug.
3831         If some other script wants to use bug-for-test we'll
3832         need to extend it with some options like --create-if-missing or similar.
3833
3834         * Scripts/webkitpy/common/net/bugzilla/bug.py:
3835         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3836         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3837         * Scripts/webkitpy/tool/commands/__init__.py:
3838         * Scripts/webkitpy/tool/commands/bugfortest.py: Added.
3839
3840 2010-12-13  Mihai Parparita  <mihaip@chromium.org>
3841
3842         Reviewed by James Robinson.
3843
3844         Add option to build-webkit to not build WebKit2
3845         https://bugs.webkit.org/show_bug.cgi?id=50988
3846
3847         Add support for a --no-webkit2 option to build-webkit. It seems to save
3848         ~1 minute from clean builds and ~10 seconds from no-op builds.
3849
3850         * Scripts/build-webkit:
3851
3852 2010-12-13  Lucas Forschler  <lforschler@apple.com>
3853
3854         Reviewed by Dave Kilzer.
3855
3856         Update iexploder from 1.3.2 to 1.7.2
3857         Move 1.3.2 into its own subdir
3858         Add 1.7.2 into its own subdir
3859         update scripts to point to new 1.3.2 location (avoid breaking existing scripts)
3860
3861         * Scripts/run-iexploder-tests:
3862         * Scripts/update-iexploder-cssproperties:
3863         * iExploder/CHANGELOG.txt: Removed.
3864         * iExploder/LICENSE.txt: Removed.
3865         * iExploder/README.txt: Removed.
3866         * iExploder/htdocs: Removed.
3867         * iExploder/iexploder-1.3.2: Added.
3868         * iExploder/iexploder-1.3.2/CHANGELOG.txt: Copied from iExploder/CHANGELOG.txt.
3869         * iExploder/iexploder-1.3.2/LICENSE.txt: Copied from iExploder/LICENSE.txt.
3870         * iExploder/iexploder-1.3.2/README.txt: Copied from iExploder/README.txt.
3871         * iExploder/iexploder-1.3.2/htdocs: Added.
3872         * iExploder/iexploder-1.3.2/htdocs/config.rb: Copied from iExploder/htdocs/config.rb.
3873         * iExploder/iexploder-1.3.2/htdocs/cssproperties.in: Copied from iExploder/htdocs/cssproperties.in.
3874         * iExploder/iexploder-1.3.2/htdocs/cssvalues.in: Copied from iExploder/htdocs/cssvalues.in.
3875         * iExploder/iexploder-1.3.2/htdocs/htmlattrs.in: Copied from iExploder/htdocs/htmlattrs.in.
3876         * iExploder/iexploder-1.3.2/htdocs/htmltags.in: Copied from iExploder/htdocs/htmltags.in.
3877         * iExploder/iexploder-1.3.2/htdocs/htmlvalues.in: Copied from iExploder/htdocs/htmlvalues.in.
3878         * iExploder/iexploder-1.3.2/htdocs/iexploder.cgi: Copied from iExploder/htdocs/iexploder.cgi.
3879         * iExploder/iexploder-1.3.2/htdocs/iexploder.rb: Copied from iExploder/htdocs/iexploder.rb.
3880         * iExploder/iexploder-1.3.2/htdocs/index.html: Copied from iExploder/htdocs/index.html.
3881         * iExploder/iexploder-1.3.2/htdocs/webserver.rb: Copied from iExploder/htdocs/webserver.rb.
3882         * iExploder/iexploder-1.3.2/tools: Added.
3883         * iExploder/iexploder-1.3.2/tools/lasthit.rb: Copied from iExploder/tools/lasthit.rb.
3884         * iExploder/iexploder-1.3.2/tools/osx_last_crash.rb: Copied from iExploder/tools/osx_last_crash.rb.
3885         * iExploder/iexploder-1.3.2/tools/showtest.rb: Copied from iExploder/tools/showtest.rb.
3886         * iExploder/iexploder-1.7.2: Added.
3887         * iExploder/iexploder-1.7.2/ChangeLog.txt: Added.
3888         * iExploder/iexploder-1.7.2/LICENSE.txt: Added.
3889         * iExploder/iexploder-1.7.2/README.txt: Added.
3890         * iExploder/iexploder-1.7.2/output: Added.
3891         * iExploder/iexploder-1.7.2/src: Added.
3892         * iExploder/iexploder-1.7.2/src/browser_harness.rb: Added.
3893         * iExploder/iexploder-1.7.2/src/config.yaml: Added.
3894         * iExploder/iexploder-1.7.2/src/css-atrules: Added.
3895         * iExploder/iexploder-1.7.2/src/css-atrules/mozilla: Added.
3896         * iExploder/iexploder-1.7.2/src/css-atrules/webkit: Added.
3897         * iExploder/iexploder-1.7.2/src/css-properties: Added.
3898         * iExploder/iexploder-1.7.2/src/css-properties/dillo: Added.
3899         * iExploder/iexploder-1.7.2/src/css-properties/gtkhtml: Added.
3900         * iExploder/iexploder-1.7.2/src/css-properties/internet_explorer6: Added.
3901         * iExploder/iexploder-1.7.2/src/css-properties/mozilla: Added.
3902         * iExploder/iexploder-1.7.2/src/css-properties/webkit: Added.
3903         * iExploder/iexploder-1.7.2/src/css-pseudo: Added.
3904         * iExploder/iexploder-1.7.2/src/css-pseudo/mozilla: Added.
3905         * iExploder/iexploder-1.7.2/src/css-pseudo/webkit: Added.
3906         * iExploder/iexploder-1.7.2/src/css-values: Added.
3907         * iExploder/iexploder-1.7.2/src/css-values/dillo: Added.
3908         * iExploder/iexploder-1.7.2/src/css-values/gtkhtml: Added.
3909         * iExploder/iexploder-1.7.2/src/css-values/mozilla: Added.
3910         * iExploder/iexploder-1.7.2/src/css-values/other: Added.
3911         * iExploder/iexploder-1.7.2/src/css-values/webkit: Added.
3912         * iExploder/iexploder-1.7.2/src/headers: Added.
3913         * iExploder/iexploder-1.7.2/src/headers/dillo: Added.
3914         * iExploder/iexploder-1.7.2/src/headers/gtkhtml: Added.
3915         * iExploder/iexploder-1.7.2/src/headers/mozilla: Added.
3916         * iExploder/iexploder-1.7.2/src/headers/webkit: Added.
3917         * iExploder/iexploder-1.7.2/src/html-attrs: Added.
3918         * iExploder/iexploder-1.7.2/src/html-attrs/dillo: Added.
3919         * iExploder/iexploder-1.7.2/src/html-attrs/gtkhtml: Added.
3920         * iExploder/iexploder-1.7.2/src/html-attrs/internet_explorer6: Added.
3921         * iExploder/iexploder-1.7.2/src/html-attrs/mozilla: Added.
3922         * iExploder/iexploder-1.7.2/src/html-attrs/other: Added.
3923         * iExploder/iexploder-1.7.2/src/html-attrs/webkit: Added.
3924         * iExploder/iexploder-1.7.2/src/html-tags: Added.
3925         * iExploder/iexploder-1.7.2/src/html-tags/dillo: Added.
3926         * iExploder/iexploder-1.7.2/src/html-tags/gtkhtml: Added.
3927         * iExploder/iexploder-1.7.2/src/html-tags/mozilla: Added.
3928         * iExploder/iexploder-1.7.2/src/html-tags/other: Added.
3929         * iExploder/iexploder-1.7.2/src/html-tags/webkit: Added.
3930         * iExploder/iexploder-1.7.2/src/html-values: Added.
3931         * iExploder/iexploder-1.7.2/src/html-values/dillo: Added.
3932         * iExploder/iexploder-1.7.2/src/html-values/gtkhtml: Added.
3933         * iExploder/iexploder-1.7.2/src/html-values/mozilla: Added.
3934         * iExploder/iexploder-1.7.2/src/html-values/other: Added.
3935         * iExploder/iexploder-1.7.2/src/html-values/webkit: Added.
3936         * iExploder/iexploder-1.7.2/src/iexploder.cgi: Added.
3937         * iExploder/iexploder-1.7.2/src/iexploder.rb: Added.
3938         * iExploder/iexploder-1.7.2/src/index.html: Added.
3939         * iExploder/iexploder-1.7.2/src/media: Added.
3940         * iExploder/iexploder-1.7.2/src/media/blank.ogg: Added.
3941         * iExploder/iexploder-1.7.2/src/media/blank.snd: Added.
3942         * iExploder/iexploder-1.7.2/src/media/blank.wav: Added.
3943         * iExploder/iexploder-1.7.2/src/media/bug.bmp: Added.
3944         * iExploder/iexploder-1.7.2/src/media/bug.gif: Added.
3945         * iExploder/iexploder-1.7.2/src/media/bug.ico: Added.
3946         * iExploder/iexploder-1.7.2/src/media/bug.jng: Added.
3947         * iExploder/iexploder-1.7.2/src/media/bug.jpg: Added.
3948         * iExploder/iexploder-1.7.2/src/media/bug.png: Added.
3949         * iExploder/iexploder-1.7.2/src/media/bug.svg: Added.
3950         * iExploder/iexploder-1.7.2/src/media/bug.tiff: Added.
3951         * iExploder/iexploder-1.7.2/src/media/bug.xbm: Added.
3952         * iExploder/iexploder-1.7.2/src/media/bug.xpm: Added.
3953         * iExploder/iexploder-1.7.2/src/mime-types: Added.
3954         * iExploder/iexploder-1.7.2/src/mime-types/dillo: Added.
3955         * iExploder/iexploder-1.7.2/src/mime-types/mozilla: Added.
3956         * iExploder/iexploder-1.7.2/src/mime-types/webkit: Added.
3957         * iExploder/iexploder-1.7.2/src/protocols: Added.
3958         * iExploder/iexploder-1.7.2/src/protocols/dillo: Added.
3959         * iExploder/iexploder-1.7.2/src/protocols/gtkhtml: Added.
3960         * iExploder/iexploder-1.7.2/src/protocols/mozilla: Added.
3961         * iExploder/iexploder-1.7.2/src/protocols/webkit: Added.
3962         * iExploder/iexploder-1.7.2/src/scanner.rb: Added.
3963         * iExploder/iexploder-1.7.2/src/version.rb: Added.
3964         * iExploder/iexploder-1.7.2/src/webserver.rb: Added.
3965         * iExploder/iexploder-1.7.2/testcases: Added.
3966         * iExploder/iexploder-1.7.2/testcases/testcase-Linux_x86_64_rv2.0b6pre_Gecko-20100904_Firefox-4.0b6pre-TEST-8375-1_59.html: Added.
3967         * iExploder/iexploder-1.7.2/testcases/testcase-Opera-9.80_Linux_x86_64_en_Presto-2.6.30_Version-10.61-16704-3_108,3.html: Added.
3968         * iExploder/iexploder-1.7.2/testcases/testcase-U_Intel_Mac_OS_X_10_6_4_en-US_AppleWebKit-534.8_Chrome-7.0.529.0-TEST-611-3_36,9.html: Added.
3969         * iExploder/iexploder-1.7.2/testcases/testcase-U_Intel_Mac_OS_X_10_6_4_en-US_AppleWebKit-534.8_hrome-7.0.529.0-TEST-55313622206-3_6,0.html: Added.
3970         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.6_Chrome-7.0.503.1-TEST-120813-8_72,56,24,8,0.html: Added.
3971         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.6_Chrome-7.0.503.1-TEST-121240-3_81,3.html: Added.
3972         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.7_Chrome-7.0.513.0-4800-5_80,65,15.html: Added.
3973         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.7_Chrome-7.0.513.0-TEST-23583190347-3_15,12.html: Added.
3974         * iExploder/iexploder-1.7.2/tools: Added.
3975         * iExploder/iexploder-1.7.2/tools/lasthit.rb: Added.
3976         * iExploder/iexploder-1.7.2/tools/osx_last_crash.rb: Added.
3977         * iExploder/iexploder-1.7.2/tools/release_src.sh: Added.
3978         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh: Added.
3979         * iExploder/tools: Removed.
3980
3981 2010-12-13  Sam Weinig  <sam@webkit.org>
3982
3983         Reviewed by Anders Carlsson.
3984
3985         Remove associated page concept from WKView constructor
3986         https://bugs.webkit.org/show_bug.cgi?id=50983
3987
3988         Step 1: Remove associate page constructors from WKView and make
3989         all views use the shared namespace for the context.
3990
3991         * TestWebKitAPI/PlatformWebView.h:
3992         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
3993         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
3994         * WebKitTestRunner/PlatformWebView.h:
3995         * WebKitTestRunner/TestController.cpp:
3996         (WTR::createOtherPage):
3997         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3998         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3999         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
4000
4001 2010-12-13  Sam Weinig  <sam@webkit.org>
4002
4003         Reviewed by Anders Carlsson.
4004
4005         Change the WebKit2 public API so there is no explicit WKPageNamespace object
4006         https://bugs.webkit.org/show_bug.cgi?id=50898
4007
4008         * MiniBrowser/mac/AppDelegate.h:
4009         * MiniBrowser/mac/AppDelegate.m:
4010         * MiniBrowser/mac/BrowserWindowController.h:
4011         * MiniBrowser/mac/BrowserWindowController.m:
4012         * MiniBrowser/win/BrowserView.cpp:
4013         Convert MiniBrowser to not use PageNamespaces.
4014
4015         * TestWebKitAPI/PlatformWebView.h:
4016         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
4017         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
4018         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
4019         * TestWebKitAPI/Tests/WebKit2/Find.cpp:
4020         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
4021         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
4022         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
4023         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
4024         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
4025         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
4026         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
4027         * TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp:
4028         * TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp:
4029         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
4030         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
4031         Convert TestWebKitAPI to not use PageNamespaces.
4032
4033         * WebKitTestRunner/PlatformWebView.h:
4034         * WebKitTestRunner/TestController.cpp:
4035         * WebKitTestRunner/TestController.h:
4036         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
4037         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
4038         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
4039         Convert WebKitTestRunner to not use PageNamespaces.
4040
4041 2010-12-13  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
4042
4043         Reviewed by Eric Seidel.
4044
4045         webkit-patch rollout should be able to do multi-revision rollouts
4046         https://bugs.webkit.org/show_bug.cgi?id=33336
4047
4048         Make it possible to pass more than one revision to webkit-patch.
4049
4050         * Scripts/webkitpy/common/checkout/api.py:
4051         * Scripts/webkitpy/common/checkout/changelog.py:
4052         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
4053         * Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:
4054         * Scripts/webkitpy/tool/commands/download.py:
4055         * Scripts/webkitpy/tool/commands/download_unittest.py:
4056         * Scripts/webkitpy/tool/mocktool.py:
4057         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
4058         * Scripts/webkitpy/tool/steps/revertrevision.py:
4059
4060 2010-12-13  Eric Seidel  <eric@webkit.org>
4061
4062         Unreviewed.
4063
4064         Teach webkit-patch how to search bugzilla
4065         https://bugs.webkit.org/show_bug.cgi?id=50500
4066
4067         webkit-patch bug-search fails when there is only one result.
4068         Turns out we needed a bit more logic in our result count parsing code.
4069
4070         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
4071         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
4072
4073 2010-12-13  Antti Koivisto  <antti@apple.com>
4074
4075         Reviewed by Alexey Proskuryakov.
4076
4077         Add setSerializeHTTPLoads function to allow testing resource load order on OS X.
4078         https://bugs.webkit.org/show_bug.cgi?id=50758
4079
4080         * DumpRenderTree/LayoutTestController.cpp:
4081         (setSerializeHTTPLoadsCallback):
4082         (LayoutTestController::staticFunctions):
4083         * DumpRenderTree/LayoutTestController.h:
4084         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
4085         (LayoutTestController::setSerializeHTTPLoads):
4086         * DumpRenderTree/mac/DumpRenderTree.mm:
4087         (resetDefaultsToConsistentValues):
4088         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
4089         (LayoutTestController::setSerializeHTTPLoads):
4090         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
4091         (LayoutTestController::setSerializeHTTPLoads):
4092
4093 2010-12-13  Dimitri Glazkov  <dglazkov@chromium.org>
4094
4095         Reviewed by Ojan Vafai.
4096
4097         Remove "use-drt" option from test step command line, since the option was removed in r73748.
4098         https://bugs.webkit.org/show_bug.cgi?id=50936
4099
4100         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Removed the option.
4101
4102 2010-12-13  Patrick Gansterer  <paroga@webkit.org>
4103
4104         Reviewed by Csaba Osztrogonác.
4105
4106         Add revlink to BuildBot status
4107         https://bugs.webkit.org/show_bug.cgi?id=50914
4108
4109         This adds a hyperlink to trac changeset on the revision numbers.
4110
4111         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
4112
4113 2010-12-13  Andras Becsi  <abecsi@webkit.org>
4114
4115         Reviewed by Csaba Osztrogonác.
4116
4117         [Qt][WK2] Fix build if WebKitTools are not available
4118         https://bugs.webkit.org/show_bug.cgi?id=50242
4119
4120         * MiniBrowser/qt/MiniBrowser.pro: Correct the comment.
4121         * Scripts/webkitdirs.pm: Added WebKitTools/MiniBrowser to $subdirs.
4122         * MiniBrowser/DerivedSources.pro: Added.
4123
4124 2010-12-13  Eric Seidel  <eric@webkit.org>
4125
4126         Reviewed by Adam Barth.
4127
4128         EWS Queues should remove orpahned pyc files before starting
4129         https://bugs.webkit.org/show_bug.cgi?id=50904
4130
4131         A previous check added a platform.py which caused
4132         EWS bots on some platforms to hit an import exception.
4133         The platform.py file was removed in a subsequent commit, but
4134         the EWS bots in question stayed stuck.  This change will
4135         fix those bots once restarted (and prevent this in the future).
4136
4137         I also went ahead and unified start-queue and start-commit-queue
4138         since they were nearly identical.  I also added bot_id support
4139         to both force all EWSes to have bot ids as well as get rid of the one
4140         remaining reason why I had my own copies of these scripts.
4141         Hopefully this will be enough to get all the other bot admins
4142         (ahem, Adam, ahem) to move to using these checked in copies as well.
4143
4144         * EWSTools/start-commit-queue.sh: Removed.
4145         * EWSTools/start-queue.sh:
4146
4147 2010-10-28  MORITA Hajime  <morrita@google.com>
4148
4149         Reviewed by Ojan Vafai.
4150
4151         spellcheck does not check pasted text
4152         https://bugs.webkit.org/show_bug.cgi?id=40092
4153
4154         Added LayoutTestController::setAsynchronousSpellCheckingEnabled()
4155         to control the setting.
4156
4157         * DumpRenderTree/LayoutTestController.cpp:
4158         (setAsynchronousSpellCheckingEnabledCallback):
4159         (LayoutTestController::staticFunctions):
4160         * DumpRenderTree/LayoutTestController.h:
4161         * DumpRenderTree/chromium/LayoutTestController.h:
4162         * DumpRenderTree/chromium/LayoutTestController.cpp:
4163         (LayoutTestController::LayoutTestController):
4164         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
4165         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
4166         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
4167         * DumpRenderTree/mac/DumpRenderTree.mm:
4168         (resetDefaultsToConsistentValues):
4169         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
4170         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
4171         * DumpRenderTree/qt/LayoutTestControllerQt.h:
4172         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
4173         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
4174         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
4175         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
4176         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
4177         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
4178
4179 2010-12-12  Sam Weinig  <sam@webkit.org>
4180
4181         Reviewed by Anders Carlsson.
4182
4183         Fix failing API test. It turns out that a pop-state event
4184         is sent before every fragment navigation, so we have to test
4185         for it in addition in PageLoadDidChangeLocationWithinPageForFrame.
4186
4187         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
4188         (TestWebKitAPI::didSameDocumentNavigationForFrame):
4189
4190 2010-12-12  Alejandro G. Castro  <alex@igalia.com>
4191
4192         Reviewed by Eric Seidel.
4193
4194         [GTK] Add new-run-webkit-tests support to gtk
4195         https://bugs.webkit.org/show_bug.cgi?id=50681
4196
4197         Adding the basic support to run the new-run-webkit-tests.
4198
4199         * Scripts/webkitpy/layout_tests/port/gtk.py:
4200
4201 2010-10-11  Diego Gonzalez  <diegohcg@webkit.org>
4202
4203         Reviewed by Kenneth Rohde Christiansen.
4204
4205         [Qt] Mock DeviceOrientation client for DRT
4206         https://bugs.webkit.org/show_bug.cgi?id=47490
4207
4208         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
4209         (WebCore::DumpRenderTree::DumpRenderTree):
4210         (WebCore::DumpRenderTree::~DumpRenderTree):
4211         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
4212         (LayoutTestController::setMockDeviceOrientation):
4213
4214 2010-12-11  Philippe Normand  <pnormand@igalia.com>
4215
4216         Reviewed by Gustavo Noronha Silva.
4217
4218         [GTK] launcher: disable the Mozilla-style fullscreen API
4219         https://bugs.webkit.org/show_bug.cgi?id=50874
4220
4221         Disabling the fullscreen API until its implementation for GTK is
4222         mature enough. The webview setting for it is already FALSE by
4223         default.
4224
4225         * GtkLauncher/main.c:
4226         (createWindow):
4227
4228 2010-12-10  Eric Seidel  <eric@webkit.org>
4229
4230         Reviewed by Adam Barth.
4231
4232         commit-queue flaky test messages show cryptic version information for mac os x
4233         https://bugs.webkit.org/show_bug.cgi?id=50864
4234
4235         Turns out platform.platform() returns kernel version information
4236         which isn't helpful, and just plain confusing on Mac
4237         (OS X 10.6.5 uses Darwin Kernel 10.5.0).
4238
4239         So I've updated PlatformInfo.display_name() to special case
4240         mac.  I also found a bad use of sys.platform in the process
4241         and fixed that.  (sys.platform always returns 'darwin' on mac).
4242
4243         * Scripts/webkitpy/common/system/platforminfo.py:
4244         * Scripts/webkitpy/common/system/user.py:
4245         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
4246         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
4247         * Scripts/webkitpy/tool/commands/queues_unittest.py:
4248
4249 2010-12-10  Eric Seidel  <eric@webkit.org>
4250
4251         Unreviewed.
4252
4253         Exception seen while reporting flaky test with commit-queue.
4254         Just a missing include.
4255
4256         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
4257         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
4258
4259 2010-12-10  Kinuko Yasuda  <kinuko@chromium.org>
4260
4261         Reviewed by Eric Seidel.
4262
4263         [Chromium] Remove old JSONResultsGenerator script that existed for backward-compatibility
4264         https://bugs.webkit.org/show_bug.cgi?id=50796
4265
4266         Also updating the test code to use JSONResultsGeneratorBase and
4267         to improve test coverage for incremental cases.
4268
4269         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
4270         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
4271
4272 2010-12-10  Joseph Pecoraro  <joepeck@webkit.org>
4273
4274         Reviewed by Darin Adler.
4275
4276         prepare-ChangeLog --help doesn't mention --bug shorthand -b
4277         https://bugs.webkit.org/show_bug.cgi?id=50835
4278
4279         * Scripts/prepare-ChangeLog: be more explicit about -b and match file style.
4280
4281 2010-12-10  Eric Seidel  <eric@webkit.org>
4282
4283         Reviewed by Adam Barth.
4284
4285         Bugs created by the commit-queue should all block on a master bug
4286         https://bugs.webkit.org/show_bug.cgi?id=50857
4287
4288         This makes all bugs created by the commit-queue block on:
4289         https://bugs.webkit.org/show_bug.cgi?id=50856
4290
4291         In the process of testing this, I found that the existing
4292         create_bug code was wrong.  I also found that existing
4293         unit tests for create-rollout used invalid values
4294         for options.blocks.  I fixed both issues and tested.
4295
4296         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
4297         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
4298         * Scripts/webkitpy/tool/commands/commandtest.py:
4299         * Scripts/webkitpy/tool/commands/download_unittest.py:
4300         * Scripts/webkitpy/tool/commands/upload_unittest.py:
4301         * Scripts/webkitpy/tool/mocktool.py:
4302         * Scripts/webkitpy/tool/steps/options.py:
4303
4304 2010-12-10  Eric Seidel  <eric@webkit.org>
4305
4306         Reviewed by Adam Barth.
4307
4308         Teach webkitpy how to follow duplicate chains when posting comments on flake bugs
4309         https://bugs.webkit.org/show_bug.cgi?id=50853
4310
4311         I also discovered when doing this that the code was posting
4312         the comment on the wrong bug, but that's fixed here too.
4313
4314         * Scripts/webkitpy/common/net/bugzilla/bug.py:
4315         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
4316         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
4317         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
4318         * Scripts/webkitpy/tool/commands/queues_unittest.py:
4319         * Scripts/webkitpy/tool/mocktool.py:
4320
4321 2010-12-10  Anders Carlsson  <andersca@apple.com>
4322
4323         Reviewed by John Sullivan.
4324
4325         Make WKContextGetStatistics gather global statistics
4326         https://bugs.webkit.org/show_bug.cgi?id=50850
4327
4328         Remove the code that gets the statistics and fills in the per context
4329         statistics information for now.
4330
4331         * MiniBrowser/mac/BrowserStatisticsWindowController.m:
4332         (-[BrowserStatisticsWindowController refreshStatistics:]):
4333
4334 2010-12-10  Eric Seidel  <eric@webkit.org>
4335
4336         Unreviewed.
4337
4338         commit-queue should report port/platform information when commenting on flaky test bugs
4339         https://bugs.webkit.org/show_bug.cgi?id=50839
4340
4341         Renamed platform.py to platforminfo.py.  This broke import platform in executive.py
4342         which was only used by new run webkit tests (and clearly not unit tested).
4343
4344         * Scripts/webkitpy/common/system/platforminfo.py: Renamed from WebKitTools/Scripts/webkitpy/common/system/platform.py.
4345         * Scripts/webkitpy/tool/main.py:
4346         * Scripts/webkitpy/tool/mocktool.py:
4347
4348 2010-12-10  Eric Seidel  <eric@webkit.org>
4349
4350         Reviewed by Tony Chang.
4351
4352         commit-queue should report port/platform information when commenting on flaky test bugs
4353         https://bugs.webkit.org/show_bug.cgi?id=50839
4354
4355         This was a suggestion from Tony Chang this morning.
4356         I added a platform.py class so I could easily mock the platform call,
4357         but that may not be the final solution for this mocking.
4358         We'll try it and see.
4359
4360         * Scripts/webkitpy/common/system/platform.py: Added.
4361         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
4362         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
4363         * Scripts/webkitpy/tool/commands/queues_unittest.py:
4364         * Scripts/webkitpy/tool/main.py:
4365         * Scripts/webkitpy/tool/mocktool.py:
4366
4367 2010-12-10  Krithigassree Sambamurthy  <krithigassree.sambamurthy@nokia.com>
4368
4369         Reviewed by Joseph Pecoraro.
4370
4371         Bug 43455 - [Qt]: Implement Application Cache Quotas
4372         https://bugs.webkit.org/show_bug.cgi?id=43455
4373
4374         Introduce functions to allow new appcache layout test origin-quota.html
4375         to work correctly under Qt.
4376
4377         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
4378         (WebCore::DumpRenderTree::DumpRenderTree):
4379         (WebCore::DumpRenderTree::dumpApplicationCacheQuota):
4380         * DumpRenderTree/qt/DumpRenderTreeQt.h:
4381
4382         Introduce functions to allow new appcache layout test origin-quota.html
4383         to be successful under qt. Changes required because LayoutTestControllerQt
4384         does not inherit from LayoutController.
4385
4386         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
4387         (LayoutTestController::reset):
4388         (LayoutTestController::clearAllApplicationCaches):
4389         (LayoutTestController::setApplicationCacheOriginQuota):
4390         * DumpRenderTree/qt/LayoutTestControllerQt.h:
4391         (LayoutTestController::shouldDumpApplicationCacheDelegateCallbacks):
4392         (LayoutTestController::dumpApplicationCacheDelegateCallbacks):
4393
4394 2010-12-10  Eric Seidel  <eric@webkit.org>
4395
4396         Reviewed by Adam Barth.
4397
4398         Move buildbot.py into its own module so we can split it out into one-file-per-class
4399         https://bugs.webkit.org/show_bug.cgi?id=50806
4400
4401         We're adding more buildbot logic these days, so it makes sense
4402         to give buildbot its own module.
4403
4404         * Scripts/webkitpy/common/net/buildbot/__init__.py: Added.
4405         * Scripts/webkitpy/common/net/buildbot/buildbot.py: Renamed from WebKitTools/Scripts/webkitpy/common/net/buildbot.py.
4406         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py: Renamed from WebKitTools/Scripts/webkitpy/common/net/buildbot_unittest.py.
4407         * Scripts/webkitpy/common/net/failuremap.py:
4408         * Scripts/webkitpy/common/net/regressionwindow.py:
4409         * Scripts/webkitpy/tool/commands/rebaseline.py:
4410
4411 2010-12-10  Tony Chang  <tony@chromium.org>
4412
4413         Reviewed by Eric Seidel.
4414
4415         Use FileSystem::remove when cleaning up http lock files
4416         https://bugs.webkit.org/show_bug.cgi?id=50830
4417
4418         * Scripts/webkitpy/layout_tests/port/http_lock.py:
4419
4420 2010-12-10  Joone Hur  <joone@kldp.org>
4421
4422         Reviewed by Martin Robinson.
4423
4424         [GTK] DRT needs layoutTestController.setCacheModel
4425         https://bugs.webkit.org/show_bug.cgi?id=50705
4426
4427         webkit_set_cache_mode() is called to set the cache model.
4428
4429         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
4430         (LayoutTestController::setCacheModel): Set the cache model.
4431
4432 2010-12-10  Tony Chang  <tony@chromium.org>
4433
4434         Reviewed by Ojan Vafai.
4435
4436         [chromium] remove --use-drt and add --use-test-shell
4437         https://bugs.webkit.org/show_bug.cgi?id=50701
4438
4439         * Scripts/webkitpy/common/config/ports.py:
4440         * Scripts/webkitpy/common/config/ports_unittest.py:
4441         * Scripts/webkitpy/layout_tests/port/chromium.py:
4442         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
4443         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
4444         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
4445         * Scripts/webkitpy/layout_tes