67a8e52fa69507b9e941c78de5bd24ac746a80a0
[WebKit.git] / Tools / ChangeLog
1 2011-03-30  Maciej Stachowiak  <mjs@apple.com>
2
3         Reviewed by Adam Barth.
4
5         Make "webkit-patch --dry-run --verbose land" log the SVN command it's going to use
6         https://bugs.webkit.org/show_bug.cgi?id=57429
7
8         * Scripts/webkitpy/common/checkout/scm.py:
9
10 2011-03-29  Sheriff Bot  <webkit.review.bot@gmail.com>
11
12         Unreviewed, rolling out r82383.
13         http://trac.webkit.org/changeset/82383
14         https://bugs.webkit.org/show_bug.cgi?id=57417
15
16         "nrwt isn't shutting down cleanly" (Requested by dpranke on
17         #webkit).
18
19         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
20         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
21         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
22
23 2011-03-29  Kent Tamura  <tkent@chromium.org>
24
25         Reviewed by Dimitri Glazkov.
26
27         Make validation message bubble testable
28         https://bugs.webkit.org/show_bug.cgi?id=57290
29
30         * DumpRenderTree/mac/DumpRenderTree.mm:
31         (createWebViewAndOffscreenWindow): Change a setting so that validation
32           bubbles isn't hidden automatically.
33
34 2011-03-29  Dirk Pranke  <dpranke@chromium.org>
35
36         Reviewed by Ojan Vafai.
37
38         new-run-webkit-tests: use 'threads' on win instead of 'old-threads'
39
40         It's a bit unclear whether multiple threads or multiple
41         processes will be a better model on windows. This change will
42         test threads for now while we're still working out the bugs in
43         multiple-processes.
44
45         https://bugs.webkit.org/show_bug.cgi?id=57410
46
47         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
48         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
49         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
50
51 2011-03-29  David Levin  <levin@chromium.org>
52
53         Reviewed by Shinichiro Hamaji.
54
55         check-webkit-style confused by two ChangeLog entries in a row from same user
56         https://bugs.webkit.org/show_bug.cgi?id=57250
57
58         * Scripts/webkitpy/style/checker.py: Add the line should be checked function to ChangeLogChecker.
59         * Scripts/webkitpy/style/checker_unittest.py: Fix test due to that new function.
60         * Scripts/webkitpy/style/checkers/changelog.py: Made this code aware of what lines were being checked.
61           It basically assumes only one ChangeLog entry is being processed because that is the standard case and
62           checking more than that would be very messey.
63         * Scripts/webkitpy/style/checkers/changelog_unittest.py: Add testing to catch the broken case.
64         * Scripts/webkitpy/style/error_handlers.py: Added should_line_be_checked.
65
66 2011-03-29  Kent Tamura  <tkent@chromium.org>
67
68         Reviewed by Dimitri Glazkov.
69
70         [Mac] Enable interactive-validation tests on Mac DRT
71         https://bugs.webkit.org/show_bug.cgi?id=57308
72
73         * DumpRenderTree/mac/DumpRenderTree.mm:
74         (createWebViewAndOffscreenWindow): Enable the form interactive validation feature.
75
76 2011-03-29  Chang Shu  <cshu@webkit.org>
77
78         Reviewed by Kenneth Rohde Christiansen.
79
80         WebKitTestRunner needs layoutTestController.setAllowUniversalAccessFromFileURLs
81         https://bugs.webkit.org/show_bug.cgi?id=42692
82
83         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
84         (WTR::InjectedBundle::beginTesting):
85         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
86         (WTR::LayoutTestController::setAllowUniversalAccessFromFileURLs):
87         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
88
89 2011-03-24  Martin Robinson  <mrobinson@igalia.com>
90
91         Reviewed by Xan Lopez.
92
93         [GTK] [DRT] GtkScrolledWindow adds three pixels of padding between the WebView and the scrollbar
94         https://bugs.webkit.org/show_bug.cgi?id=57067
95
96         Eliminate extra spacing between the DRT GtkScrolledWindow and the DRT WebView. This
97         will allow WebKit1GTK+ and WebKit2GTK+ to share test results. Followup commits will
98         update DRT and pixel results as hundreds of results will need to be updated.
99
100         * DumpRenderTree/gtk/DumpRenderTree.cpp:
101         (setDefaultsToConsistentStateValuesForTesting): Eliminate spacing on the GtkScrolledWindow
102         by overriding the theme RC/CSS files.
103
104 2011-03-29  Steve Falkenburg  <sfalken@apple.com>
105
106         Reviewed by Adam Roben.
107
108         Use per-configuration vsprops in tools projects to avoid WebKitVSPropsRedirectionDir removal by MSVC IDE
109         https://bugs.webkit.org/show_bug.cgi?id=57394
110
111         Visual Studio's IDE was removing instances of $(WebKitVSPropsRedirectionDir) from
112         InheritedPropertySheet rules in our vcproj files when the vcproj was edited from within
113         the IDE. To avoid this, add a separate vsprops file for each project configuration that
114         contains the required inherited property sheets.
115
116         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
117         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebug.vsprops: Added.
118         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebugAll.vsprops: Added.
119         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebugCairoCFLite.vsprops: Added.
120         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginRelease.vsprops: Added.
121         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseCairoCFLite.vsprops: Added.
122         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseLTCG.vsprops: Added.
123         * DumpRenderTree/win/DumpRenderTree.vcproj:
124         * DumpRenderTree/win/DumpRenderTreeDebug.vsprops: Added.
125         * DumpRenderTree/win/DumpRenderTreeDebugAll.vsprops: Added.
126         * DumpRenderTree/win/DumpRenderTreeDebugCairoCFLite.vsprops: Added.
127         * DumpRenderTree/win/DumpRenderTreeRelease.vsprops: Added.
128         * DumpRenderTree/win/DumpRenderTreeReleaseCairoCFLite.vsprops: Added.
129         * DumpRenderTree/win/DumpRenderTreeReleaseLTCG.vsprops: Added.
130         * DumpRenderTree/win/ImageDiff.vcproj:
131         * DumpRenderTree/win/ImageDiffDebug.vsprops: Added.
132         * DumpRenderTree/win/ImageDiffDebugAll.vsprops: Added.
133         * DumpRenderTree/win/ImageDiffDebugCairoCFLite.vsprops: Added.
134         * DumpRenderTree/win/ImageDiffRelease.vsprops: Added.
135         * DumpRenderTree/win/ImageDiffReleaseCairoCFLite.vsprops: Added.
136         * DumpRenderTree/win/ImageDiffReleaseLTCG.vsprops: Added.
137         * FindSafari/FindSafari.vcproj:
138         * FindSafari/FindSafariDebug.vsprops: Added.
139         * FindSafari/FindSafariDebugAll.vsprops: Added.
140         * FindSafari/FindSafariDebugCairoCFLite.vsprops: Added.
141         * FindSafari/FindSafariRelease.vsprops: Added.
142         * FindSafari/FindSafariReleaseCairoCFLite.vsprops: Added.
143         * FindSafari/FindSafariReleaseLTCG.vsprops: Added.
144         * FindSafari/FindSafariReleasePGO.vsprops: Added.
145         * MiniBrowser/Configurations/MiniBrowserDebug.vsprops: Added.
146         * MiniBrowser/Configurations/MiniBrowserDebugAll.vsprops: Added.
147         * MiniBrowser/Configurations/MiniBrowserDebugCairoCFLite.vsprops: Added.
148         * MiniBrowser/Configurations/MiniBrowserRelease.vsprops: Added.
149         * MiniBrowser/Configurations/MiniBrowserReleaseCairoCFLite.vsprops: Added.
150         * MiniBrowser/Configurations/MiniBrowserReleaseLTCG.vsprops: Added.
151         * MiniBrowser/MiniBrowser.vcproj:
152         * WebKitAPITest/WebKitAPITest.vcproj:
153         * WebKitAPITest/WebKitAPITestDebug.vsprops: Added.
154         * WebKitAPITest/WebKitAPITestDebugAll.vsprops: Added.
155         * WebKitAPITest/WebKitAPITestDebugCairoCFLite.vsprops: Added.
156         * WebKitAPITest/WebKitAPITestRelease.vsprops: Added.
157         * WebKitAPITest/WebKitAPITestReleaseCairoCFLite.vsprops: Added.
158         * WebKitAPITest/WebKitAPITestReleaseLTCG.vsprops: Added.
159         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
160         * WebKitLauncherWin/WebKitLauncherWinDebug.vsprops: Added.
161         * WebKitLauncherWin/WebKitLauncherWinDebugAll.vsprops: Added.
162         * WebKitLauncherWin/WebKitLauncherWinDebugCairoCFLite.vsprops: Added.
163         * WebKitLauncherWin/WebKitLauncherWinRelease.vsprops: Added.
164         * WebKitLauncherWin/WebKitLauncherWinReleaseCairoCFLite.vsprops: Added.
165         * WebKitLauncherWin/WebKitLauncherWinReleaseLTCG.vsprops: Added.
166         * WebKitTestRunner/win/InjectedBundle.vcproj:
167         * WebKitTestRunner/win/InjectedBundleDebug.vsprops: Added.
168         * WebKitTestRunner/win/InjectedBundleDebugAll.vsprops: Added.
169         * WebKitTestRunner/win/InjectedBundleDebugCairoCFLite.vsprops: Added.
170         * WebKitTestRunner/win/InjectedBundleRelease.vsprops: Added.
171         * WebKitTestRunner/win/InjectedBundleReleaseCairoCFLite.vsprops: Added.
172         * WebKitTestRunner/win/InjectedBundleReleaseLTCG.vsprops: Added.
173         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
174         * WebKitTestRunner/win/WebKitTestRunnerDebug.vsprops: Added.
175         * WebKitTestRunner/win/WebKitTestRunnerDebugAll.vsprops: Added.
176         * WebKitTestRunner/win/WebKitTestRunnerDebugCairoCFLite.vsprops: Added.
177         * WebKitTestRunner/win/WebKitTestRunnerRelease.vsprops: Added.
178         * WebKitTestRunner/win/WebKitTestRunnerReleaseCairoCFLite.vsprops: Added.
179         * WebKitTestRunner/win/WebKitTestRunnerReleaseLTCG.vsprops: Added.
180         * WinLauncher/WinLauncher.vcproj:
181         * WinLauncher/WinLauncherDebug.vsprops: Added.
182         * WinLauncher/WinLauncherDebugAll.vsprops: Added.
183         * WinLauncher/WinLauncherDebugCairoCFLite.vsprops: Added.
184         * WinLauncher/WinLauncherRelease.vsprops: Added.
185         * WinLauncher/WinLauncherReleaseCairoCFLite.vsprops: Added.
186         * WinLauncher/WinLauncherReleaseLTCG.vsprops: Added.
187         * record-memory-win/record-memory-win.vcproj:
188         * record-memory-win/record-memory-winDebug.vsprops: Added.
189         * record-memory-win/record-memory-winDebugAll.vsprops: Added.
190         * record-memory-win/record-memory-winDebugCairoCFLite.vsprops: Added.
191         * record-memory-win/record-memory-winRelease.vsprops: Added.
192         * record-memory-win/record-memory-winReleaseCairoCFLite.vsprops: Added.
193         * record-memory-win/record-memory-winReleaseLTCG.vsprops: Added.
194
195 2011-03-29  Adam Barth  <abarth@webkit.org>
196
197         Reviewed by Darin Adler.
198
199         test_runner2.py can crash due to undefined variable
200         https://bugs.webkit.org/show_bug.cgi?id=57356
201
202         Replace reference to undefined variable with a variable that's actually
203         defined.  AFAICT, there's no way to test this code.
204
205         * Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
206
207 2011-03-29  Tony Chang  <tony@chromium.org>
208
209         Reviewed by Eric Seidel.
210
211         cleanup rebaseline-chromium-webkit-tests
212         https://bugs.webkit.org/show_bug.cgi?id=57375
213
214         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
215             - Split _extract_and_add_new_baselines into 3 functions
216             - Reduce the amount of line wrapping (the file already has lines
217               over 80 col, so may as well try to make the file consistent)
218             - Remove unnecessary ()s
219
220 2011-03-29  Brent Fulgham  <bfulgham@webkit.org>
221
222         Reviewed by Adam Roben.
223
224         Make WinCairo a core builder.
225         https://bugs.webkit.org/show_bug.cgi?id=57373
226
227         * Scripts/webkitpy/common/net/buildbot/buildbot.py: Add WinCairo.
228         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py: Add WinCairo.
229
230 2011-03-29  Timothy Hatcher  <timothy@apple.com>
231
232         Update update-webkit-localizable-strings to understand that WebKit and
233         WebKit2 strings go in WebCore.
234
235         Also make extract-localizable-strings optionally use an exclude file. No individual
236         warnings are produced about unlocalized strings when there is no exclude file. This
237         is needed for WebCore, since there are too many bare strings.
238
239         https://webkit.org/b/57354
240
241         Reviewed by Sam Weinig.
242
243         * Scripts/extract-localizable-strings: Support "-" to mean no exclude file.
244         * Scripts/update-webkit-localizable-strings: Update paths to scan WebCore and WebKit2.
245
246 2011-03-29  Darin Adler  <darin@apple.com>
247
248         Reviewed by Adam Roben.
249
250         WebKit2 bundle page needs to offer generated file hooks
251         https://bugs.webkit.org/show_bug.cgi?id=57279
252
253         (Land missing part of the original patch after r82289.)
254
255         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
256         (WTR::InjectedBundlePage::InjectedBundlePage): Added new callbacks.
257
258 2011-03-29  Tony Chang  <tony@chromium.org>
259
260         Reviewed by Ojan Vafai.
261
262         [chromium] NRWT should be able to read checksums from png comments
263         https://bugs.webkit.org/show_bug.cgi?id=57280
264
265         * Scripts/read-checksum-from-png: Added. Utility script to read the checksum
266             from a file.
267         * Scripts/webkitpy/common/system/filesystem.py: Add open_binary_file_for_reading
268         * Scripts/webkitpy/common/system/filesystem_mock.py:
269         * Scripts/webkitpy/layout_tests/port/base.py: When loading a checksum,
270             if the -checksum.txt file doesn't exist, try looking in the png.
271         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
272         * Scripts/webkitpy/layout_tests/port/test.py:
273         * Scripts/webkitpy/layout_tests/read_checksum_from_png.py: Added. Scan the first
274             2k for a png comment with the checksum
275         * Scripts/webkitpy/layout_tests/read_checksum_from_png_unittest.py: Added.
276
277 2011-03-29  Philippe Normand  <pnormand@igalia.com>
278
279         Rubber-stamped by Gustavo Noronha Silva.
280
281         [GTK] http/tests/uri/username-with-no-hostname.html fails
282         https://bugs.webkit.org/show_bug.cgi?id=57325
283
284         * DumpRenderTree/gtk/DumpRenderTree.cpp:
285         (willSendRequestCallback): URI host value check done case-insensitively.
286
287 2011-03-29  Philippe Normand  <pnormand@igalia.com>
288
289         Reviewed by Martin Robinson.
290
291         [GTK] http/tests/uri/username-with-no-hostname.html fails
292         https://bugs.webkit.org/show_bug.cgi?id=57325
293
294         * DumpRenderTree/gtk/DumpRenderTree.cpp:
295         (willSendRequestCallback): Check URI before submitting the request
296         to WebCore.
297
298 2011-03-29  Noel Gordon  <noel.gordon@gmail.com>
299
300         Reviewed by Ojan Vafai.
301
302         [chromium] DRT EventSender: remove identity from dragTargetDragEnter() calls
303         https://bugs.webkit.org/show_bug.cgi?id=57303
304
305         * DumpRenderTree/chromium/EventSender.cpp:
306         (EventSender::doDragDrop):
307         (EventSender::beginDragWithFiles):
308
309 2011-03-29  Zoltan Horvath  <zoltan@webkit.org>
310
311         Reviewed by Andreas Kling.
312
313         [Qt] Add -print-loaded-urls option to Qt's MiniBrowser and to QtTestBrowser
314         https://bugs.webkit.org/show_bug.cgi?id=57314
315
316         Provide possibility to print loaded urls to the standard output.
317
318         * MiniBrowser/qt/BrowserWindow.cpp:
319         (BrowserWindow::BrowserWindow):
320         (BrowserWindow::printURL):
321         * MiniBrowser/qt/BrowserWindow.h:
322         * MiniBrowser/qt/MiniBrowserApplication.cpp:
323         (MiniBrowserApplication::handleUserOptions):
324         * MiniBrowser/qt/MiniBrowserApplication.h:
325         (WindowOptions::WindowOptions):
326         * QtTestBrowser/launcherwindow.cpp:
327         (LauncherWindow::initializeView):
328         (LauncherWindow::printURL):
329         (LauncherWindow::cloneWindow):
330         * QtTestBrowser/launcherwindow.h:
331         (WindowOptions::WindowOptions):
332         * QtTestBrowser/main.cpp:
333         (LauncherApplication::handleUserOptions):
334
335 2011-03-29  Gabor Loki  <loki@webkit.org>
336
337         Rubber-stamped by Csaba Osztrogonác.
338
339         [Qt] Teach build-jsc how to build JavaScriptCore on Qt
340         https://bugs.webkit.org/show_bug.cgi?id=56918
341
342         * Scripts/build-jsc: Remove duplicated --qt options to avoid passing them to qmake.
343
344 2011-03-28  Gabor Loki  <loki@webkit.org>
345
346         Reviewed by Csaba Osztrogonác.
347
348         [Qt] Teach build-jsc how to build JavaScriptCore on Qt
349         https://bugs.webkit.org/show_bug.cgi?id=56918
350
351         * Scripts/build-jsc:
352         * Scripts/webkitdirs.pm:
353
354 2011-03-28  Andrew Foster  <andrewf@chromium.org>
355
356         Reviewed by Ojan Vafai.
357
358         webkit-patch should be more intelligent about whether a bug applies to a patch
359         Create a new function, parse_bug_id_from_changelog() which determines
360         that a bug is related to a patch by parsing the output generated from
361         prepare-ChangeLog, rather than arbitrarily matching a URL to a bug in
362         the description of a patch.
363         https://bugs.webkit.org/show_bug.cgi?id=56989
364
365         * Scripts/webkitpy/common/checkout/api.py:
366         * Scripts/webkitpy/common/checkout/changelog.py:
367         * Scripts/webkitpy/common/net/bugzilla/__init__.py:
368         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
369         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
370         * Scripts/webkitpy/style/checkers/changelog.py:
371         * Scripts/webkitpy/tool/commands/upload.py:
372
373 2011-03-28  Maciej Stachowiak  <mjs@apple.com>
374
375         Revert accidentally commited change.
376
377         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
378         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
379
380 2011-03-28  Tony Chang  <tony@chromium.org>
381
382         Reviewed by Adam Barth.
383
384         [chromium] have DRT write the png checksum into a png comment
385         https://bugs.webkit.org/show_bug.cgi?id=57255
386
387         * DumpRenderTree/chromium/TestShell.cpp:
388         (TestShell::dumpImage):
389
390 2011-03-28  Adele Peterson  <adele@apple.com>
391
392         Removing Qt stub, since it doesn't use the same header as the others.
393
394         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
395
396 2011-03-28  Adele Peterson  <adele@apple.com>
397
398         Added a few more stubs.
399
400         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
401         (LayoutTestController::hasGrammarMarker):
402         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
403         (LayoutTestController::hasGrammarMarker):
404         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
405         (LayoutTestController::hasGrammarMarker):
406
407 2011-03-28  Adele Peterson  <adele@apple.com>
408
409         Build fix.
410
411         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
412         (LayoutTestController::hasGrammarMarker):
413
414 2011-03-28  Adele Peterson  <adele@apple.com>
415
416         Reviewed by Eric Seidel.
417
418         Testing support for <rdar://problem/9112694> REGRESSION (r79411): "Check grammar with spelling" context menu doesn't check as you type
419         https://bugs.webkit.org/show_bug.cgi?id=57173
420
421         * DumpRenderTree/LayoutTestController.cpp:
422         (hasGrammarMarkerCallback): Added.
423         (LayoutTestController::staticFunctions): Added case for hasGrammarMarker.
424         * DumpRenderTree/LayoutTestController.h:
425         * DumpRenderTree/mac/DumpRenderTree.mm: (createWebViewAndOffscreenWindow): Call setGrammarCheckingEnabled.
426         * DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::hasGrammarMarker): Added. Call new hasGrammarMarker method.
427
428 2011-03-28  Csaba Osztrogonác  <ossy@webkit.org>
429
430         Reviewed by Benjamin Poulain.
431
432         [Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
433         https://bugs.webkit.org/show_bug.cgi?id=57087
434
435         Trivial typo fix after r82082.
436
437         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
438         (WTR::activateFonts):
439
440 2011-03-28  Alexis Menard  <alexis.menard@openbossa.org>
441
442         Reviewed by Andreas Kling.
443
444         Add myself to the committers list.
445
446         * Scripts/webkitpy/common/config/committers.py:
447
448 2011-03-28  Simon Fraser  <simon.fraser@apple.com>
449
450         Reviewed by Sam Weinig.
451
452         WebKit2 unfortunately uses code from WebKit, so MiniBrowser needs
453         to link against WebKit.framework for now.
454
455         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
456
457 2011-03-28  Benjamin Poulain  <benjamin.poulain@nokia.com>
458
459         Reviewed by Andreas Kling.
460
461         [Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
462         https://bugs.webkit.org/show_bug.cgi?id=57087
463
464         Disable QT_ASCII_CAST_WARNINGS for applications.
465
466         * DumpRenderTree/qt/DumpRenderTree.pro:
467         * DumpRenderTree/qt/ImageDiff.pro:
468         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
469         * MiniBrowser/qt/MiniBrowser.pro:
470         * QtTestBrowser/QtTestBrowser.pro:
471         * WebKitTestRunner/qt/WebKitTestRunner.pro:
472
473 2011-03-28  Andreas Kling  <kling@webkit.org>
474
475         Reviewed by Kenneth Rohde Christiansen.
476
477         [Qt] QtTestBrowser doesn't reset its window title when opening about:blank
478         https://bugs.webkit.org/show_bug.cgi?id=57224
479
480         * QtTestBrowser/mainwindow.cpp:
481         (MainWindow::buildUI):
482         (MainWindow::onTitleChanged):
483         * QtTestBrowser/mainwindow.h:
484
485 2011-03-27  Jer Noble  <jer.noble@apple.com>
486
487         Reviewed by Maciej Stachowiak.
488
489         Full Screen: disable keyboard access by default
490         https://bugs.webkit.org/show_bug.cgi?id=56684
491
492         Accept the withKeyboard parameter to supportsFullScreenForElement.
493
494         * DumpRenderTree/mac/UIDelegate.mm:
495         (-[UIDelegate webView:supportsFullScreenForElement:withKeyboard:]):
496
497 2011-03-27  Patrick Gansterer  <paroga@webkit.org>
498
499         Reviewed by David Levin.
500
501         check-webkit-style should check ChangeLog for a valid bug number
502         https://bugs.webkit.org/show_bug.cgi?id=57184
503
504         * Scripts/webkitpy/style/checker.py:
505         * Scripts/webkitpy/style/checker_unittest.py:
506         * Scripts/webkitpy/style/checkers/changelog.py: Added.
507         * Scripts/webkitpy/style/checkers/changelog_unittest.py: Added.
508
509 2011-03-27  Benjamin Poulain  <benjamin.poulain@nokia.com>
510
511         Reviewed by Andreas Kling.
512
513         [Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
514         https://bugs.webkit.org/show_bug.cgi?id=57087
515
516         Use explicit conversion for string to avoid depending on the default codec
517         installed by the user code.
518
519         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
520         (WTR::activateFonts):
521
522 2011-03-26  Maciej Stachowiak  <mjs@apple.com>
523
524         Revert inadvertantly committed changes.
525
526         * Scripts/old-run-webkit-tests:
527         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
528
529 2011-03-26  Andreas Kling  <kling@webkit.org>
530
531         Reviewed by Kenneth Rohde Christiansen.
532
533         [Qt] Show page icons (favicons) in QtTestBrowser location bar.
534         https://bugs.webkit.org/show_bug.cgi?id=57162
535
536         * QtTestBrowser/QtTestBrowser.qrc:
537         * QtTestBrowser/favicon.png: Added.
538         * QtTestBrowser/locationedit.cpp:
539         (defaultPageIcon):
540         (LocationEdit::LocationEdit):
541         (LocationEdit::setPageIcon):
542         (LocationEdit::resizeEvent):
543         (LocationEdit::updateInternalGeometry):
544         * QtTestBrowser/locationedit.h:
545         * QtTestBrowser/mainwindow.cpp:
546         (MainWindow::buildUI):
547         (MainWindow::onIconChanged):
548         (MainWindow::onLoadStarted):
549         * QtTestBrowser/mainwindow.h:
550
551 2011-03-23  Martin Robinson  <mrobinson@igalia.com>
552
553         Reviewed by Xan Lopez.
554
555         [GTK] Force DumpRenderTree to use 96 DPI
556         https://bugs.webkit.org/show_bug.cgi?id=56866
557
558         Make sure that GTK+ is set to use 96 DPI when running tests. This ensures
559         broader compatibility with WebKit2 and makes setting font sizes more straightforward.
560
561         * DumpRenderTree/gtk/DumpRenderTree.cpp:
562         (initializeGtkFontSettings): Set the screen resolution and GTK+ xft property to 96 DPI.
563         (resetDefaultsToConsistentValues):Remove the call which repeatedly set the GDK screen resolution.
564         (setDefaultsToConsistentStateValuesForTesting): Update the font sizes to reflect the new DPI.
565
566 2011-03-25  Andy Estes  <aestes@apple.com>
567
568         Reviewed by Adele Peterson.
569
570         REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
571         https://bugs.webkit.org/show_bug.cgi?id=49016
572
573         TestNetscapePlugIn needs to register support for an image MIME type so
574         we can test that the embed tag prefers plug-ins to render image MIME
575         types.
576
577         * DumpRenderTree/TestNetscapePlugIn/mac/Info.plist: Register image/png.
578         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
579         (NP_GetMIMEDescription): Ditto.
580         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Ditto.
581
582 2011-03-25  Jessie Berlin  <jberlin@apple.com>
583
584         Reviewed by Sam Weinig.
585
586         WebKit2: Need to be able to set and get the Cookie Storage Policy.
587         https://bugs.webkit.org/show_bug.cgi?id=50780
588
589         Add a test for getting and setting the HTTP Cookie Accept Policy in WebKit2.
590
591         The test is named "CookieManager" so that we can eventually exercise more of the
592         CookieManager functionality in the test.
593
594         * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp: Added.
595         (TestWebKitAPI::didGetTestHTTPCookieAcceptPolicy):
596         Assert that the policy returned is equal to the policy set in
597         didGetUserHTTPCookieAcceptPolicy, and then restore the user's policy.
598         (TestWebKitAPI::didGetUserHTTPCookieAcceptPolicy):
599         Set the policy to something different than the user's policy and get the policy again.
600         (TestWebKitAPI::didFinishLoadForFrame):
601         Get the user's policy so that it can be restored at the end of the test.
602         (TestWebKitAPI::TEST):
603         Load about:blank so that the Web Process gets instatiated (needed to get the
604         CookieManager).
605
606         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
607         Add CookieManager.cpp.
608
609 2011-03-24  Kevin Ollivier  <kevino@theolliviers.com>
610
611         [wx] Fix the build so that gcc-4.1 and up can be used to build on SnowLeopard.
612
613         * wx/build/settings.py:
614
615 2011-03-24  Ilya Sherman  <isherman@chromium.org>
616
617         Reviewed by Adam Roben.
618
619         Implement layoutTestController.setAutoFilled in DRT on Windows
620         https://bugs.webkit.org/show_bug.cgi?id=56828
621
622         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
623         (LayoutTestController::setAutofilled): Implemented.
624
625 2011-03-24  Brent Fulgham  <bfulgham@webkit.org>
626
627         Unreviewed build correction.
628
629         Correct vsprops file for Debug variant of the CFLite build.
630         Disable a CFNETWORK-specific test when building for CFLite.
631
632         * TestWebKitAPI/Configurations/TestWebKitAPIDebugCairoCFLite.vsprops:
633         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
634
635 2011-03-24  Dirk Pranke  <dpranke@chromium.org>
636
637         Reviewed by Adam Barth.
638
639         fix regressions introduced in 81908 - there were a couple of
640         code paths that only fired under python 2.5 that I missed.
641
642         Also change a couple of 'python' references to sys.executable
643         in order to handle runing test-webkitpy with a binary other than
644         something called 'python'.
645
646         https://bugs.webkit.org/show_bug.cgi?id=57063
647
648         * Scripts/webkitpy/layout_tests/port/mac.py:
649         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
650         * Scripts/webkitpy/test/cat.py:
651         * Scripts/webkitpy/test/echo.py:
652
653 2011-03-24  Brent Fulgham  <bfulgham@webkit.org>
654
655         Unreviewed build correction.
656
657         Add a stub implementation of the TestInvocation dumping logic.
658         Update project files to reflect new file.
659
660         * WebKitTestRunner/cairo: Added.
661         * WebKitTestRunner/cairo/TestInvocationCairo.cpp: Added.
662         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
663         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
664
665 2011-03-24  Dirk Pranke  <dpranke@chromium.org>
666
667         Reviewed by Tony Chang.
668
669         new-run-webkit-tests: clean up worker model defaults. This
670         changes the default behavior to 'threads' instead of
671         'old-threads', and clarifies that chromium-win-* and
672         chromium-mac-leopard are exceptions.
673
674         https://bugs.webkit.org/show_bug.cgi?id=56971
675
676         * Scripts/webkitpy/layout_tests/port/base.py:
677         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
678         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
679         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
680         * Scripts/webkitpy/layout_tests/port/test.py:
681         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
682
683 2011-03-23  Leandro Gracia Gil  <leandrogracia@chromium.org>
684
685         Reviewed by Darin Adler.
686
687         Media Stream API: fix the order of the options in build-webkit.
688         https://bugs.webkit.org/show_bug.cgi?id=56949
689
690         Fix the order of the options in build-webkit.
691
692         * Scripts/build-webkit:
693
694 2011-03-23  Adam Klein  <adamk@chromium.org>
695
696         Reviewed by Mihai Parparita.
697
698         Add an option to new-run-webkit-httpd to allow overriding the location of LayoutTests directory
699         https://bugs.webkit.org/show_bug.cgi?id=56884
700
701         This option will be utilized by Chromium's ui_tests to allow
702         referencing js-test-resources from a layout test over HTTP.
703
704         * Scripts/new-run-webkit-httpd:
705         Added --layout_tests_dir option.
706         * Scripts/webkitpy/layout_tests/port/http_server.py:
707         Plumbed through as layout_tests_dir param.
708
709 2011-03-23  Dirk Pranke  <dpranke@chromium.org>
710
711         Reviewed by Mihai Parparita.
712
713         new-run-webkit-tests: run tests in ascending alphabetical order per
714         dir. This is a second attempt at the fix; the first attempt, in 
715         r81597, broke the behavior on the old-inline and old-threads
716         worker models.
717
718         https://bugs.webkit.org/show_bug.cgi?id=56760
719
720         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
721         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
722         * Scripts/webkitpy/layout_tests/port/test.py:
723         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
724
725 2011-03-23  Mario Sanchez Prada  <msanchez@igalia.com>
726
727         Reviewed by Martin Robinson.
728
729         [GTK] GTK's DRT to ouput detail's string for the 'property-change' signal
730         https://bugs.webkit.org/show_bug.cgi?id=56953
731
732         Print the string for the detail of 'property-change' signal.
733
734         * DumpRenderTree/gtk/AccessibilityCallbacks.cpp:
735         (axObjectEventListener): Print the detail string.
736
737 2011-03-23  Yury Semikhatsky  <yurys@chromium.org>
738
739         Reviewed by Pavel Feldman.
740
741         [V8] Web Inspector: compile DebuggerScript.js into DebuggerScriptSource.h
742         https://bugs.webkit.org/show_bug.cgi?id=56843
743
744         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
745         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
746
747 2011-03-22  Eric Seidel  <eric@webkit.org>
748
749         Reviewed by Adam Barth.
750
751         Teach update-webkit about gyp
752         https://bugs.webkit.org/show_bug.cgi?id=56881
753
754         This makes it possible for someone who builds from Xcode
755         to just run update-webkit --gyp and have the project files
756         generated after update automatically.
757
758         I also added a stand-alone "generate-project-files" script
759         wrapping Source/gyp/configure.  This makes running gyp simpler
760         since most people will not have gyp or Source/gyp in their path.
761
762         * Scripts/build-webkit:
763         * Scripts/generate-project-files: Added.
764         * Scripts/update-webkit:
765
766 2011-03-22  Anton D'Auria  <adauria@apple.com>
767
768         Reviewed by Alexey Proskuryakov.
769
770         Add +[WebApplicationCache getOriginsWithCache]
771         https://bugs.webkit.org/show_bug.cgi?id=56722
772
773         * DumpRenderTree/LayoutTestController.cpp:
774         (originsWithApplicationCacheCallback):
775         (LayoutTestController::staticFunctions):
776         * DumpRenderTree/LayoutTestController.h:
777         * DumpRenderTree/chromium/LayoutTestController.cpp: Added stub.
778         (LayoutTestController::originsWithApplicationCache):
779         * DumpRenderTree/chromium/LayoutTestController.h:
780         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Added stub.
781         (LayoutTestController::originsWithApplicationCache):
782         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Pass array of origin's database identifiers.
783         (originsArrayToJS): Helper function for converting array of WebSecurityOrigins to a JS array of origin identifiers.
784         (LayoutTestController::originsWithApplicationCache):
785         (LayoutTestController::originsWithLocalStorage):
786         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Added stub.
787         (LayoutTestController::originsWithApplicationCache):
788         * DumpRenderTree/qt/LayoutTestControllerQt.h:
789         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Added stub.
790         (LayoutTestController::originsWithApplicationCache):
791         * DumpRenderTree/wx/LayoutTestControllerWx.cpp: Added stub.
792         (LayoutTestController::originsWithApplicationCache):
793
794 2011-03-22  Eric Seidel  <eric@webkit.org>
795
796         Reviewed by Adam Barth.
797
798         Add support to build-webkit for building with gyp-generated project files
799         https://bugs.webkit.org/show_bug.cgi?id=56877
800
801         build-webkit is a cesspool.  This change just hacks in --gyp support for Mac.
802         Eventually we'll want to support gyp-generated projects in a more general manner.
803
804         * Scripts/build-webkit:
805
806 2011-03-22  David Kilzer  <ddkilzer@apple.com>
807
808         <http://webkit.org/b/56781> Add --dsym switch to enable dsym generation when building with Xcode
809
810         Reviewed by Joseph Pecoraro.
811
812         * Scripts/build-webkit: Updated usage statement to include
813         --dsym.
814         * Scripts/webkitdirs.pm: Added $generateDsym variable.
815         (generateDsym): Added. Call determineGenerateDsym() and
816         return $generateDsym.
817         (determineGenerateDsym): Added.  Parse @ARGV for --dsym and set
818         $generateDsym.
819         (argumentsForXcode): Added.  Returns additional arguments for
820         xcodebuild based on command-line switches.
821         (XcodeOptions): Updated to include argumentsForXcode() in the
822         array returned.
823
824 2011-03-22  Adam Roben  <aroben@apple.com>
825
826         Make Leopard Debug bots and Windows XP Debug (Tests) core builders
827
828         These bots are consistently green again.
829
830         Fixes <http://webkit.org/b/56830> Leopard Debug bots and Windows XP Debug (Tests) should be
831         core builders
832
833         Rubber-stamped by Antti Koivisto.
834
835         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
836         (BuildBot.__init__): Loosened the regexps for Leopard and Windows.
837
838         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
839         (BuildBotTest.test_builder_name_regexps): Updated expectations.
840
841 2011-03-21  Sheriff Bot  <webkit.review.bot@gmail.com>
842
843         Unreviewed, rolling out r81597.
844         http://trac.webkit.org/changeset/81597
845         https://bugs.webkit.org/show_bug.cgi?id=56801
846
847         Change results in lots of unexpected flaky on the dashboard.
848         (Requested by pfeldman on #webkit).
849
850         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
851         * Scripts/webkitpy/layout_tests/port/test.py:
852         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
853
854 2011-03-21  Sam Weinig  <sam@webkit.org>
855
856         Fix failing tests on the WebKit2 bots.
857
858         * WebKitTestRunner/TestController.cpp:
859         (WTR::TestController::resetStateToConsistentValues):
860
861 2011-03-21  Daniel Sievers  <sievers@google.com>
862
863         Reviewed by Simon Fraser.
864
865         [Chromium] Make RenderAsTextBehavior and LayerTreeAsTextBehavior tweakable from the DumpRenderTree commandline
866         https://bugs.webkit.org/show_bug.cgi?id=56139
867
868         * DumpRenderTree/chromium/DumpRenderTree.cpp:
869         (main):
870         * DumpRenderTree/chromium/LayoutTestController.cpp:
871         (LayoutTestController::LayoutTestController):
872         (LayoutTestController::layerTreeAsText):
873         * DumpRenderTree/chromium/LayoutTestController.h:
874         (LayoutTestController::setShowDebugLayerTree):
875         * DumpRenderTree/chromium/TestShell.cpp:
876         (TestShell::runFileTest):
877         (TestShell::dump):
878         * DumpRenderTree/chromium/TestShell.h:
879         (TestParams::TestParams):
880
881 2011-03-21  Adam Roben  <aroben@apple.com>
882
883         Try again to get buildbot to show run-javascriptcore-tests's actual.html as an HTML file
884
885         Fixes <http://webkit.org/b/56746> build.webkit.org shows run-javascriptcore-tests's HTML
886         output as plain text
887
888         Reviewed by David Kilzer.
889
890         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
891         (RunJavaScriptCoreTests): List actual.html as one of our log files so it will get uploaded
892         to the master.
893         (RunJavaScriptCoreTests.commandComplete): Reading the actual.html file here won't work,
894         since we're running on the build master, not the slave. Instead, turn the raw source of
895         actual.html which the build slave uploaded into an HTML log.
896
897 2011-03-21  Dirk Pranke  <dpranke@chromium.org>
898
899         Reviewed by Mihai Parparita.
900
901         new-run-webkit-tests: run tests in ascending alphabetical order per dir
902         https://bugs.webkit.org/show_bug.cgi?id=56760
903
904         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
905         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
906         * Scripts/webkitpy/layout_tests/port/test.py:
907
908 2011-03-21  Leandro Gracia Gil  <leandrogracia@chromium.org>
909
910         Reviewed by Steve Block.
911
912         Media Stream API patch 0: adding compilation guards.
913         https://bugs.webkit.org/show_bug.cgi?id=56458
914
915         Adding options to enable the media stream API feature in Chromium.
916
917         * Scripts/build-webkit:
918
919 2011-03-21  Qi Zhang  <qi.2.zhang@nokia.com>
920
921         Reviewed by Laszlo Gombos.
922
923         [Qt] Add a command line option to capture stdout and stderr for DumpRenderTree
924         https://bugs.webkit.org/show_bug.cgi?id=56323
925
926         Using freopen to redirect STDOUT and STDERR when DumpRenderTree command line provide 
927         "--stdout" or "--stderr" option.
928
929         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
930         (WebCore::DumpRenderTree::~DumpRenderTree):
931         (WebCore::DumpRenderTree::processArgsLine):
932         (WebCore::DumpRenderTree::loadNextTestInStandAloneMode):
933         * DumpRenderTree/qt/DumpRenderTreeQt.h:
934         (WebCore::DumpRenderTree::setRedirectOutputFileName):
935         (WebCore::DumpRenderTree::setRedirectErrorFileName):
936         * DumpRenderTree/qt/main.cpp:
937         (isOption):
938         (takeOptionValue):
939         (printUsage):
940         (main):
941
942 2011-03-21  Adam Roben  <aroben@apple.com>
943
944         Fix exceptions on the buildbot due to my last change
945
946         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
947         (RunJavaScriptCoreTests.commandComplete): Catch exceptions due to actual.html not existing.
948
949 2011-03-21  Adam Roben  <aroben@apple.com>
950
951         Teach buildbot to treat run-javascriptcore-tests's actual.html as an HTML file
952
953         Fixes <http://webkit.org/b/56746> build.webkit.org shows run-javascriptcore-tests's HTML
954         output as plain text
955
956         Reviewed by Darin Adler.
957
958         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
959         (RunJavaScriptCoreTests): Removed the logfiles variable, which can only handle plaintext
960         logs.
961         (RunJavaScriptCoreTests.commandComplete): Use the addHTMLLog method to upload actual.html to
962         the build master. This will correctly treat it as HTML.
963
964 2011-03-20  Bill Budge  <bbudge@chromium.org>
965
966         Reviewed by Adam Barth.
967
968         Rename ThreadSafeShared to ThreadSafeRefCounted
969         https://bugs.webkit.org/show_bug.cgi?id=56714
970
971         No new tests. Exposes no new functionality.
972
973         * DumpRenderTree/ForwardingHeaders/wtf/ThreadSafeRefCounted.h: Copied from DumpRenderTree/ForwardingHeaders/wtf/ThreadSafeShared.h.
974         * DumpRenderTree/ForwardingHeaders/wtf/ThreadSafeShared.h: Removed.
975         * Scripts/do-webcore-rename:
976
977 2011-03-19  Anton D'Auria  <adauria@apple.com>
978
979         Reviewed by Dan Bernstein.
980
981         Add stub to LayoutTestControllerGtk.cpp to fix GTK build
982         https://bugs.webkit.org/show_bug.cgi?id=56719
983
984         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Adding stub.
985         (LayoutTestController::clearApplicationCacheForOrigin):
986
987 2011-03-19  Anton D'Auria  <adauria@apple.com>
988
989         Reviewed by Alexey Proskuryakov.
990
991         ApplicationCacheGroup is not obsolete after being deleted via ApplicationCacheStorage::deleteEntriesForOrigin
992         https://bugs.webkit.org/show_bug.cgi?id=56415
993
994         * DumpRenderTree/LayoutTestController.cpp:
995         (clearApplicationCacheForOriginCallback):
996         (LayoutTestController::staticFunctions):
997         * DumpRenderTree/LayoutTestController.h:
998         * DumpRenderTree/chromium/LayoutTestController.cpp: Adding stubs.
999         (LayoutTestController::LayoutTestController):
1000         (LayoutTestController::clearAllApplicationCaches):
1001         (LayoutTestController::clearApplicationCacheForOrigin): 
1002         * DumpRenderTree/chromium/LayoutTestController.h:
1003         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Adding stub.
1004         (LayoutTestController::clearApplicationCacheForOrigin):
1005         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Adding stub.
1006         (LayoutTestController::clearApplicationCacheForOrigin):
1007         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1008         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Adding stub.
1009         (LayoutTestController::clearApplicationCacheForOrigin):
1010         * DumpRenderTree/wx/LayoutTestControllerWx.cpp: Adding stub.
1011         (LayoutTestController::clearApplicationCacheForOrigin):
1012
1013 2011-03-18  Dan Bernstein  <mitz@apple.com>
1014
1015         Revised build fix for r81135.
1016
1017         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
1018         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1019
1020 2011-03-18  Adam Roben  <aroben@apple.com>
1021
1022         Windows build fix
1023
1024         * WebKitTestRunner/config.h: Add a missing #endif.
1025
1026 2011-03-18  Andreas Kling  <kling@webkit.org>
1027
1028         Unbreak Qt build after r81494.
1029
1030         * WebKitTestRunner/qt/TestInvocationQt.cpp:
1031         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
1032
1033 2011-03-18  Sam Weinig  <sam@webkit.org>
1034
1035         Fix windows build. This was really Adam Roben's fault. I swear!
1036
1037         * WebKitTestRunner/config.h:
1038
1039 2011-03-18  Sam Weinig  <sam@webkit.org>
1040
1041         Reviewed by Adam Roben.
1042
1043         Pixel tests don't work in WebKitTestRunner on Windows
1044         https://bugs.webkit.org/show_bug.cgi?id=56630
1045
1046         Cross-platformize (Mac and Windows CG) the pixel dumping code in WebKitTestRunner to use WebKit2
1047         built-in snapshotting instead of using the window server on the Mac.
1048
1049         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1050         (WTR::InjectedBundle::InjectedBundle):
1051         (WTR::InjectedBundle::didReceiveMessage):
1052         (WTR::InjectedBundle::beginTesting):
1053         (WTR::InjectedBundle::done):
1054         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1055         (WTR::InjectedBundle::setPixelResult):
1056         (WTR::InjectedBundle::shouldDumpPixels):
1057         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1058         (WTR::InjectedBundlePage::dump):
1059         Take the snapshot in the bundle and send it to the UIProcess for dumping.
1060
1061         * WebKitTestRunner/TestInvocation.cpp:
1062         (WTR::TestInvocation::invoke):
1063         (WTR::TestInvocation::dump):
1064         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1065         * WebKitTestRunner/TestInvocation.h:
1066         * WebKitTestRunner/cg: Added.
1067         * WebKitTestRunner/cg/TestInvocationCG.cpp: Copied from WebKitTestRunner/mac/TestInvocationMac.mm.
1068         (WTR::createCGContextFromImage):
1069         (WTR::computeMD5HashStringForContext):
1070         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
1071         * WebKitTestRunner/mac/TestInvocationMac.mm: Removed.
1072         Making pixel dumping code shared for CG ports. Also use the WTF/MD5 instead of platform specific code.
1073
1074         * WebKitTestRunner/win/TestInvocationWin.cpp:
1075         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
1076         Keep stub for Cairo build.
1077
1078         * WebKitTestRunner/Configurations/WebKitTestRunnerCoreGraphics.vsprops: Added.
1079         Add CG configuration.
1080
1081         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1082         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
1083         Add new files.
1084
1085 2011-03-18  Adam Roben  <aroben@apple.com>
1086
1087         Don't allow Leaks Viewer's vertical scrollbar to cover up long function names
1088
1089         Rubber-stamped by Simon Fraser.
1090
1091         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
1092         (.data-grid .data-container): Use overflow-y:auto instead of the Inspector's default
1093         overflow-y:overlay so that the scrollbar doesn't overlay the content.
1094
1095 2011-03-18  Adam Roben  <aroben@apple.com>
1096
1097         Don't ellipsize long or indented function names in Leaks Viewer
1098
1099         Fixes <http://webkit.org/b/56037> Leaks viewer needs horizontal
1100         scrollbar
1101
1102         Reviewed by Simon Fraser.
1103
1104         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
1105         (.data-grid .data-container):
1106         (.data-grid td > div, .data-grid th > div):
1107         Allow the contents to extend to the right.
1108
1109 2011-03-18  Adam Roben  <aroben@apple.com>
1110
1111         Fix some leaks in DRT seen on the leaks bot
1112
1113         Fixes <http://webkit.org/b/56638> addURLToRedirectCallback and
1114         setWillSendRequestClearHeaderCallback in DRT are leaky
1115
1116         Reviewed by Alexey Proskuryakov.
1117
1118         * DumpRenderTree/ForwardingHeaders/wtf/OwnArrayPtr.h: Added.
1119
1120         * DumpRenderTree/LayoutTestController.cpp:
1121         (addURLToRedirectCallback):
1122         (setWillSendRequestClearHeaderCallback):
1123         Use OwnArrayPtr to cause the strings to be deleted.
1124
1125 2011-03-18  Adam Roben  <aroben@apple.com>
1126
1127         Fix a NSURLCredential leak seen on the leaks bot
1128
1129         Fixes <http://webkit.org/b/56637> -[SynchronousLoader
1130         connection:didReceiveAuthenticationChallenge:] is leaky
1131
1132         Reviewed by John Sullivan.
1133
1134         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1135         (-[SynchronousLoader connection:didReceiveAuthenticationChallenge:]): Use a RetainPtr to
1136         cause the NSURLCredential to be released.
1137
1138 2011-03-18  John Knottenbelt  <jknotten@chromium.org>
1139
1140         Unreviewed.
1141
1142         Remove unnecessary brackets around my email address.
1143
1144         * Scripts/webkitpy/common/config/committers.py:
1145
1146 2011-03-18  Adam Roben  <aroben@apple.com>
1147         
1148         Remove some files I accidentally added in r81454
1149
1150         * WebKitTestRunner/Configurations/WebKitTestRunnerCoreGraphics.vsprops: Removed.
1151         * WebKitTestRunner/cg/TestInvocationCG.cpp: Removed.
1152
1153 2011-03-18  Adam Roben  <aroben@apple.com>
1154
1155         Ignore an NSNumberFormatter leak on SnowLeopard
1156
1157         * Scripts/old-run-webkit-tests:
1158         (countAndPrintLeaks): Ignore leaks in -[NSNumberFormatter
1159         getObjectValue:forString:errorDescription:].
1160
1161 2011-03-18  Adam Roben  <aroben@apple.com>
1162
1163         Fix a leak beneath LayoutTestController::authenticateSession seen on the bots
1164
1165         Rubber-stamped by Mark Rowe.
1166
1167         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1168         (LayoutTestController::authenticateSession): Use a RetainPtr to cause the NSURLRequest to be
1169         released.
1170
1171 2011-03-17  Adam Roben  <aroben@apple.com>
1172
1173         Address a review comment I missed in r81445
1174
1175         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js:
1176         (LeaksParserWorker.prototype._parseLeaks): Anchor the RegExp used to find the number of
1177         leaked bytes to speed up searching on long lines.
1178
1179 2011-03-17  Adam Roben  <aroben@apple.com>
1180
1181         Mark leaky builds orange, even if all regression tests passed
1182
1183         Fixes <http://webkit.org/b/56609> SnowLeopard Intel Leaks bot appears green on
1184         build.webkit.org when all tests pass even though there are still leaks
1185
1186         Reviewed by Dan Bernstein.
1187
1188         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1189         (RunWebKitLeakTests): Set the warnOnWarnings property to True so that the entire build will
1190         be marked orange if this build step generates warnings.
1191
1192 2011-03-17  Adam Roben  <aroben@apple.com>
1193
1194         Allow values in Leaks Viewer to be shown as percentages
1195
1196         Double-clicking on a column will toggle between showing percentages and showing real values.
1197
1198         Fixes <http://webkit.org/b/56628> Would like to view values as percentages of the total
1199         number of leaked bytes in Leaks Viewer
1200
1201         Reviewed by Joe Pecoraro.
1202
1203         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js:
1204         (LeaksParserWorker.prototype._incorporateLeaks): Calculate the (never-shown) top-level
1205         node's totalTime, which is used in calculating percentages.
1206
1207         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js:
1208         (monkeyPatchInspectorObjects): Only format values as bytes if we aren't supposed to be
1209         showing them as percentages.
1210
1211 2011-03-17  Adam Roben  <aroben@apple.com>
1212
1213         Show the number of leaked bytes, not just leaked allocations, in Leaks Viewer
1214
1215         The Self and Total columns now report the number of leaked bytes. The new Calls column shows
1216         the number of leaked allocations. And the new Average column shows the average number of
1217         leaked bytes per call.
1218
1219         Fixes <http://webkit.org/b/56344> Leaks Viewer should show how many bytes were leaked, not
1220         just how many allocations
1221
1222         Reviewed by Joe Pecoraro.
1223
1224         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js:
1225         (LeaksParserWorker.prototype._parseLeaks): Parse the number of leaked bytes from the "Leak:"
1226         line and store it with the leak stack.
1227         (LeaksParserWorker.prototype._createNode): Initialize the averageTime and numberOfCalls
1228         properties.
1229         (LeaksParserWorker.prototype._incorporateLeaks): Updated to get the stack from the .stack
1230         property, and changed to store the number of leaked bytes in .selfTime/.totalTime.
1231         .numberOfCalls now holds the number of leaked allocations.
1232
1233         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js:
1234         (Preferences): Set samplingCPUProfiler to false so that the Average and Calls columns will
1235         appear.
1236         (monkeyPatchInspectorObjects): Format the values as bytes.
1237
1238 2011-03-17  Adam Roben  <aroben@apple.com>
1239
1240         Make Leaks Viewer able to count leaks in builds that didn't fail any regression tests
1241
1242         Fixes <http://webkit.org/b/56626> Leaks Viewer omits recent builds which didn't fail any
1243         regression tests
1244
1245         Reviewed by James Robinson.
1246
1247         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
1248         (RecentBuildsLoader.prototype.start): Get the number of leaks out of the "text" array, which
1249         is always populated, even when all regression tests pass.
1250
1251 2011-03-10  Hayato Ito  <hayato@chromium.org>
1252
1253         Reviewed by Tony Chang.
1254
1255         Add a check logic for reftests in case that a reftest is marked AS REBASELINE.
1256
1257         https://bugs.webkit.org/show_bug.cgi?id=56076
1258
1259         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1260
1261 2011-03-17  Adam Roben  <aroben@apple.com>
1262
1263         Skip a compositing-sensitive test when accelerated compositing is disabled
1264
1265         Reviewed by Sam Weinig.
1266
1267         * Scripts/old-run-webkit-tests: Skip media/media-document-audio-repaint.html when
1268         accelerated compositing is disabled.
1269
1270 2011-03-17  Adam Roben  <aroben@apple.com>
1271
1272         Start using PlatformSpecificScheduler for the Mac builders
1273
1274         The current set of file/directory patterns should work for Mac builders. We may discover
1275         that there are more files and directories we can exclude from the Mac builds, but they can
1276         be added later.
1277
1278         Fixes <http://webkit.org/b/56593> Mac builders do lots of unnecessary builds
1279
1280         Reviewed by Mark Rowe.
1281
1282         * BuildSlaveSupport/build.webkit.org-config/config.json: Moved the Mac builders into two
1283         PlatformSpecificSchedulers: one for Leopard, and one for SnowLeopard.
1284
1285         * Scripts/webkitpy/common/config/build.py:
1286         (_should_file_trigger_build): Allow "mac-leopard" and "mac-snowleopard" platforms, and
1287         cleaned up patterns a little bit.
1288
1289         * Scripts/webkitpy/common/config/build_unittest.py:
1290         (ShouldBuildTest): Fixed some expected results.
1291         (ShouldBuildTest.test_should_build): Start testing "mac-leopard" and "mac-snowleopard"
1292         platforms.
1293
1294 2011-03-17  Jeff Miller  <jeffm@apple.com>
1295
1296         Use a consistent set of file patterns in the svn:ignore property for all .xcodeproj directories, specifically:
1297         
1298         *.mode*
1299         *.pbxuser
1300         *.perspective*
1301         project.xcworkspace
1302         xcuserdata
1303
1304         * DumpRenderTree/DumpRenderTree.xcodeproj: Modified property svn:ignore.
1305         * MiniBrowser/MiniBrowser.xcodeproj: Modified property svn:ignore.
1306         * TestWebKitAPI/TestWebKitAPI.xcodeproj: Modified property svn:ignore.
1307         * WebKitLauncher/WebKitLauncher.xcodeproj: Modified property svn:ignore.
1308         * WebKitTestRunner/WebKitTestRunner.xcodeproj: Modified property svn:ignore.
1309
1310 2011-03-17  Adam Roben  <aroben@apple.com>
1311
1312         Make old-run-webkit-tests pick up mac-wk2 results when running in WebKit2 mode on Windows
1313
1314         Fixes <http://webkit.org/b/56563> Running WebKit2 tests on Windows should use results from
1315         mac-wk2
1316
1317         Reviewed by Anders Carlsson.
1318
1319         * Scripts/old-run-webkit-tests:
1320         (expectedDirectoryForTest): Clean up the code to search in extra Mac platform result
1321         directories on Windows. Add mac-wk2 to the set of extra platforms we look in on Windows when
1322         we're running in WebKit2 mode.
1323
1324 2011-03-17  Mikhail Naganov  <mnaganov@chromium.org>
1325
1326         Reviewed by Yury Semikhatsky.
1327
1328         Web Inspector: Clean up Inspector strings.
1329         https://bugs.webkit.org/show_bug.cgi?id=56557
1330
1331         Modify the script to deal correctly with "\xNN" escapes, and to
1332         check strings in Chromium's DevTools.js.
1333
1334         * Scripts/check-inspector-strings:
1335
1336 2011-03-17  Keith Kyzivat  <keith.kyzivat@nokia.com>
1337
1338         Reviewed by Benjamin Poulain.
1339
1340         Update autoinstall to install mechanize 0.2.4
1341         https://bugs.webkit.org/show_bug.cgi?id=56499
1342
1343         Newer versions of mechanize support HTTPS proxies, which is necessary
1344         for people using webkit-patch behind firewalls.
1345
1346         * Scripts/webkitpy/common/system/autoinstall.py:
1347         * Scripts/webkitpy/thirdparty/__init__.py:
1348
1349 2011-03-16  Sam Weinig  <sam@webkit.org>
1350
1351         Reviewed by Adam Roben.
1352
1353         REGRESSION (r81084): media/invalid-media-url-crash.html and editing/execCommand/indent-paragraphs.html failing on WebKit2
1354         https://bugs.webkit.org/show_bug.cgi?id=56541
1355
1356         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1357         (WTR::InjectedBundlePage::willSendRequestForFrame):
1358         Check for an empty host in addition to a null host.  This bug was introduced
1359         when porting off of the KURL code and onto the WKURLRef version.
1360
1361 2011-03-16  Sam Weinig  <sam@webkit.org>
1362
1363         Reviewed by Adam Roben.
1364
1365         Add Lucas Forschler to the list of WebKit committers.
1366
1367         * Scripts/webkitpy/common/config/committers.py:
1368
1369 2011-03-16  Sam Weinig  <sam@webkit.org>
1370
1371         Reviewed upon and dictated through Adam Roben.
1372
1373         Escape crashing function names in results.html. This fixes an issue
1374         when a crash involves a type with templates.
1375
1376         * Scripts/old-run-webkit-tests:
1377
1378 2011-03-16  Daniel Sievers  <sievers@google.com>
1379
1380         Reviewed by James Robinson.
1381
1382         Add setting to always force compositing mode
1383         https://bugs.webkit.org/show_bug.cgi?id=56156
1384
1385         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1386         (main):
1387         * DumpRenderTree/chromium/TestShell.cpp:
1388         (TestShell::TestShell):
1389         (TestShell::resetWebSettings):
1390         * DumpRenderTree/chromium/TestShell.h:
1391         (TestShell::setForceCompositingMode):
1392         * DumpRenderTree/chromium/WebPreferences.cpp:
1393         (WebPreferences::reset):
1394         (WebPreferences::applyTo):
1395         * DumpRenderTree/chromium/WebPreferences.h:
1396
1397 2011-03-15  Hayato Ito  <hayato@chromium.org>
1398
1399         Reviewed by Ojan Vafai.
1400
1401         Ignore files that will be used by reftests in old-run-webkit-tests.
1402
1403         https://bugs.webkit.org/show_bug.cgi?id=55936
1404
1405         * Scripts/old-run-webkit-tests:
1406
1407 2011-03-15  Felipe Oliveira da Silva Netto  <f.dachshund@gmail.com>
1408
1409         Reviewed by Adam Roben.
1410
1411         Function relativeScriptsDir doesn't return the correct relative
1412         Scripts directory.
1413
1414         * Scripts/webkitdirs.pm:
1415         (relativeScriptsDir): Ensure we use the directory that contains
1416         webkitdirs.pm, not the one that contains the original script that
1417         was invoked.
1418
1419 2011-03-15  Kevin Ollivier  <kevino@theolliviers.com>
1420
1421         [wx] Build fixes for long linker commands on Win and method return error, plus a Mac
1422         fix to link against the Security framework after recent WebKitSystemInterface changes.
1423
1424         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1425         (LayoutTestController::originsWithLocalStorage):
1426         * wx/build/settings.py:
1427         * wx/build/waf_extensions.py:
1428
1429 2011-03-15  Sam Weinig  <sam@webkit.org>
1430
1431         Reviewed by Darin Adler.
1432
1433         Add script to convert a patch to a prettypatch and show in the default browser
1434         https://bugs.webkit.org/show_bug.cgi?id=56416
1435
1436         This can be used either like
1437             $ svn-create-patch | show-pretty-diff
1438         or
1439             $ show-pretty-diff patch.diff
1440
1441         * Scripts/show-pretty-diff: Added.
1442
1443 2011-03-15  Brian Weinstein  <bweinstein@apple.com>
1444
1445         Rubber-stamped by Adam Roben.
1446
1447         Adding myself as a reviewer.
1448
1449         * Scripts/webkitpy/common/config/committers.py:
1450
1451 2011-03-15  Anders Carlsson  <andersca@apple.com>
1452
1453         Try to fix the Windows build.
1454
1455         * DumpRenderTree/TestNetscapePlugIn/Tests/NPDeallocateCalledBeforeNPShutdown.cpp:
1456         (NPDeallocateCalledBeforeNPShutdown::TestObject::~TestObject):
1457
1458 2011-03-15  Anders Carlsson  <andersca@apple.com>
1459
1460         Reviewed by Sam Weinig.
1461
1462         Make sure that NP_Shutdown is always the last NPP function called
1463         https://bugs.webkit.org/show_bug.cgi?id=56391
1464
1465         Add a test that times out if an NP_Deallocate object is called after NP_Shutdown.
1466
1467         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1468         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
1469         (PluginTest::PluginTest):
1470         (PluginTest::NP_Shutdown):
1471         (PluginTest::registerNPShutdownFunction):
1472         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
1473         * DumpRenderTree/TestNetscapePlugIn/Tests/NPDeallocateCalledBeforeNPShutdown.cpp: Added.
1474         (NPDeallocateCalledBeforeNPShutdown::NPDeallocateCalledBeforeNPShutdown):
1475         (NPDeallocateCalledBeforeNPShutdown::TestObject::~TestObject):
1476         (NPDeallocateCalledBeforeNPShutdown::ScriptableObject::hasProperty):
1477         (NPDeallocateCalledBeforeNPShutdown::ScriptableObject::getProperty):
1478         (NPDeallocateCalledBeforeNPShutdown::NPP_New):
1479         (NPDeallocateCalledBeforeNPShutdown::NPP_GetValue):
1480         (NPDeallocateCalledBeforeNPShutdown::shutdown):
1481         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1482         (NP_Shutdown):
1483         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1484         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1485         * GNUmakefile.am:
1486
1487 2011-03-15  Ilya Sherman  <isherman@chromium.org>
1488
1489         Reviewed by Tony Chang.
1490
1491         Autofilled form elements are assigned fixed background color but not text color
1492         https://bugs.webkit.org/show_bug.cgi?id=48382
1493
1494         * DumpRenderTree/LayoutTestController.cpp:
1495         (setAutofilledCallback): Added.
1496         (LayoutTestController::staticFunctions):
1497         * DumpRenderTree/LayoutTestController.h:
1498         * DumpRenderTree/chromium/LayoutTestController.cpp:
1499         (LayoutTestController::LayoutTestController):
1500         (LayoutTestController::setAutofilled): Added.
1501         * DumpRenderTree/chromium/LayoutTestController.h:
1502         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1503         (LayoutTestController::setAutofilled): Added.
1504         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1505         (LayoutTestController::setAutofilled): Added.
1506         (LayoutTestController::setValueForUser): Style tweak.
1507         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1508         (LayoutTestController::setAutofilled): Added (stub).
1509         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1510         (LayoutTestController::setAutofilled): Added (stub).
1511
1512 2011-03-15  Dan Bernstein  <mitz@apple.com>
1513
1514         Build fix after r81135.
1515
1516         * TestWebKitAPI/Configurations/InjectedBundle.xcconfig:
1517
1518 2011-03-15  Dan Bernstein  <mitz@apple.com>
1519
1520         Build fix after r81135.
1521
1522         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
1523         * WebKitTestRunner/mac/TestControllerMac.mm:
1524         * WebKitTestRunner/mac/TestInvocationMac.mm:
1525         * WebKitTestRunner/mac/main.mm:
1526
1527 2011-03-15  Balazs Kelemen  <kbalazs@webkit.org>
1528
1529         Reviewed by Adam Barth.
1530
1531         REGRESSION(80977): breaks Qt ARMv7 Linux Release bot
1532         https://bugs.webkit.org/show_bug.cgi?id=56349
1533
1534         * QtTestBrowser/QtTestBrowser.pro: Link against fontconfig
1535         on platforms where we use it. Copied from DumpRenderTree.pro.
1536
1537 2011-03-15  Dan Bernstein  <mitz@apple.com>
1538
1539         Build fix after r81135.
1540
1541         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
1542         * DumpRenderTree/mac/WebArchiveDumpSupportMac.mm:
1543
1544 2011-03-15  Kevin Ollivier  <kevino@theolliviers.com>
1545
1546         Reviewed by Darin Adler.
1547
1548         Introduce WTF_USE_EXPORT_MACROS, which will allow us to put shared library import/export
1549         info into the headers rather than in export symbol definition files, but disable it on 
1550         all platforms initially so we can deal with port build issues one port at a time.
1551         
1552         https://bugs.webkit.org/show_bug.cgi?id=27551
1553
1554         * DumpRenderTree/cg/ImageDiffCG.cpp:
1555         * DumpRenderTree/chromium/config.h:
1556         * DumpRenderTree/config.h:
1557         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1558         * TestWebKitAPI/TestWebKitAPIPrefix.h:
1559         * WebKitAPITest/HostWindow.cpp:
1560         * WebKitAPITest/TestsController.cpp:
1561         * WebKitAPITest/config.h: Added.
1562         * WebKitAPITest/main.cpp:
1563         * WebKitAPITest/tests/WebViewDestruction.cpp:
1564         * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.cpp:
1565         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1566         * WebKitTestRunner/InjectedBundle/GCController.cpp:
1567         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1568         * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp:
1569         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1570         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1571         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
1572         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
1573         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
1574         * WebKitTestRunner/InjectedBundle/win/ActivateFonts.cpp:
1575         * WebKitTestRunner/InjectedBundle/win/InjectedBundleWin.cpp:
1576         * WebKitTestRunner/InjectedBundle/win/LayoutTestControllerWin.cpp:
1577         * WebKitTestRunner/TestController.cpp:
1578         * WebKitTestRunner/TestInvocation.cpp:
1579         * WebKitTestRunner/config.h: Added.
1580         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1581         * WebKitTestRunner/qt/TestControllerQt.cpp:
1582         * WebKitTestRunner/qt/TestInvocationQt.cpp:
1583         * WebKitTestRunner/qt/main.cpp:
1584         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
1585         * WebKitTestRunner/win/TestControllerWin.cpp:
1586         * WebKitTestRunner/win/TestInvocationWin.cpp:
1587         * WebKitTestRunner/win/main.cpp:
1588         * wx/build/settings.py:
1589
1590 2011-03-15  Hayato Ito  <hayato@chromium.org>
1591
1592         Reviewed by Shinichiro Hamaji.
1593
1594         [NRWT] Add support for reftests to new-run-webkit-tests.
1595
1596         https://bugs.webkit.org/show_bug.cgi?id=55457
1597
1598         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
1599         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1600         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
1601         * Scripts/webkitpy/layout_tests/port/base.py:
1602         * Scripts/webkitpy/layout_tests/port/dryrun.py:
1603         * Scripts/webkitpy/layout_tests/port/test.py:
1604         * Scripts/webkitpy/layout_tests/port/test_files.py:
1605         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1606
1607 2011-03-15  Alejandro G. Castro  <alex@igalia.com>
1608
1609         Reviewed by Martin Robinson.
1610
1611         [GTK] Fix compilation warning after r80892
1612         https://bugs.webkit.org/show_bug.cgi?id=56302
1613
1614         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1615         (LayoutTestController::originsWithLocalStorage):
1616
1617 2011-03-15  Robert Hogan  <robert@webkit.org>
1618
1619         Reviewed by Adam Barth.
1620
1621         Document the qmakearg argument, and hint how to build webkit2 on Qt
1622         https://bugs.webkit.org/show_bug.cgi?id=56326
1623
1624         * Scripts/build-webkit: add --qmakearg to build-webkit --help
1625
1626 2011-03-15  Adam Roben  <aroben@apple.com>
1627
1628         Make Windows 7 Release (Tests) a core builder
1629
1630         We can probably make Windows XP Debug (Tests) a core builder, too, but we should probably
1631         give it a few more days of greenness first.
1632
1633         Fixes <http://webkit.org/b/55665> Windows 7 Release (Tests) should be a core builder
1634
1635         Reviewed by Sam Weinig.
1636
1637         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1638         (BuildBot): Added a regexp to match Windows 7 Release (Tests).
1639
1640         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1641         (BuildBotTest): Updated the list of builders to match the current list on build.webkit.org.
1642         Updated the core regexps to match the buildbot module. Updated the expected results to match
1643         the current set of core builders.
1644
1645 2011-03-14  Adam Roben  <aroben@apple.com>
1646
1647         Add forgotten file from r81116
1648
1649         * TestWebKitAPI/Configurations/TestWebKitAPICFNetwork.vsprops: Added.
1650
1651 2011-03-14  Sam Weinig  <sam@webkit.org>
1652
1653         Reviewed by Adam Roben.
1654
1655         about:blank fake responses don't get serialized when sent the UIProcess
1656         <rdar://problem/9108119>
1657         https://bugs.webkit.org/show_bug.cgi?id=56357
1658
1659         * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp: Added.
1660         (TestWebKitAPI::decidePolicyForResponse):
1661         (TestWebKitAPI::TEST):
1662         Add test that loads of about:blank have a response with a MIMEType of text/html.
1663
1664         * TestWebKitAPI/PlatformUtilities.h:
1665         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
1666         (TestWebKitAPI::Util::MIMETypeForWKURLResponse):
1667         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
1668         (TestWebKitAPI::Util::MIMETypeForWKURLResponse):
1669         Add helper to get the MIMEType from a WKURLResponse.
1670
1671         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1672         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1673         Add new files.
1674
1675 2011-03-14  Jarkko Sakkinen  <jarkko.j.sakkinen@gmail.com>
1676
1677         Reviewed by Kenneth Rohde Christiansen.
1678
1679         [Qt] Command-line options for QGLWidget and WebGL to QtTestBrowser
1680         https://bugs.webkit.org/show_bug.cgi?id=56006
1681
1682         * QtTestBrowser/launcherwindow.cpp:
1683         (LauncherWindow::initializeView):
1684         * QtTestBrowser/main.cpp:
1685         (LauncherApplication::handleUserOptions):
1686
1687 2011-03-14  James Kozianski  <koz@chromium.org>
1688
1689         Reviewed by Ojan Vafai.
1690
1691         Add method to make BuildBot return test outputs
1692         https://bugs.webkit.org/show_bug.cgi?id=54374
1693
1694         The Builder.latest_cached_build will be used by the new rebaseline
1695         script to determine the build to use baselines from.
1696
1697         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1698         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1699
1700 2011-03-14  Adam Roben  <aroben@apple.com>
1701
1702         Test that WKBundlePageCanHandleRequest returns true for empty document URLs
1703
1704         Reviewed by Sam Weinig.
1705
1706         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp: Added.
1707         (TestWebKitAPI::didReceiveMessageFromInjectedBundle): Store the result of the test.
1708         (TestWebKitAPI::setInjectedBundleClient): Hook up our callback.
1709         (TestWebKitAPI::TEST): Register "emptyscheme" as an empty document scheme, load a page to
1710         ensure the web process is initialized, then ask the bundle to run the test and assert that
1711         it succeeded.
1712
1713         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest_Bundle.cpp: Added.
1714         (TestWebKitAPI::CanHandleRequestTest::CanHandleRequestTest): Just call up to the base class.
1715         (TestWebKitAPI::canHandleURL): Helper function to test whether WebKit2 claims to be able to
1716         handle a given URL.
1717         (TestWebKitAPI::runTest): Check that empty document URLs can be handled (and that an unknown
1718         URL type cannot be handled).
1719         (TestWebKitAPI::CanHandleRequestTest::didReceiveMessage): Run the test and return the
1720         result.
1721
1722         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1723         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1724         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
1725         Added new files to the project.
1726
1727 2011-03-14  Sheriff Bot  <webkit.review.bot@gmail.com>
1728
1729         Unreviewed, rolling out r81094.
1730         http://trac.webkit.org/changeset/81094
1731         https://bugs.webkit.org/show_bug.cgi?id=56355
1732
1733         Broke the chromium DRT related build. (Requested by dave_levin
1734         on #webkit).
1735
1736         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1737         (main):
1738         * DumpRenderTree/chromium/LayoutTestController.cpp:
1739         (LayoutTestController::LayoutTestController):
1740         (LayoutTestController::layerTreeAsText):
1741         * DumpRenderTree/chromium/LayoutTestController.h:
1742         * DumpRenderTree/chromium/TestShell.cpp:
1743         (TestShell::runFileTest):
1744         (TestShell::dump):
1745         * DumpRenderTree/chromium/TestShell.h:
1746         (TestParams::TestParams):
1747
1748 2011-03-14  Daniel Sievers  <sievers@google.com>
1749
1750         Reviewed by Simon Fraser.
1751
1752         [Chromium] Make RenderAsTextBehavior and LayerTreeAsTextBehavior tweakable from the DumpRenderTree commandline
1753         https://bugs.webkit.org/show_bug.cgi?id=56139
1754
1755         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1756         (main):
1757         * DumpRenderTree/chromium/LayoutTestController.cpp:
1758         (LayoutTestController::LayoutTestController):
1759         (LayoutTestController::layerTreeAsText):
1760         * DumpRenderTree/chromium/LayoutTestController.h:
1761         (LayoutTestController::setShowDebugLayerTree):
1762         * DumpRenderTree/chromium/TestShell.cpp:
1763         (TestShell::runFileTest):
1764         (TestShell::dump):
1765         * DumpRenderTree/chromium/TestShell.h:
1766         (TestParams::TestParams):
1767
1768 2011-03-14  Balazs Kelemen  <kbalazs@webkit.org>
1769
1770         Reviewed by Adam Roben.
1771
1772         [Qt][WK2]Unbreak InjectedBundle on Qt
1773         https://bugs.webkit.org/show_bug.cgi?id=54109
1774
1775         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1776         (WTR::InjectedBundlePage::willSendRequestForFrame): Use new WebKit2
1777         API's instead of KURL to analyze the URL.
1778         * WebKitTestRunner/StringFunctions.h:
1779         (WTR::adoptWK): Moved from InjectedBundlePage.cpp to make it available globally
1780         in the WebKitTestRunner project.
1781         (WTR::toWK): Use adoptWK.
1782         (WTR::operator<<): Added helper for printing a WKURL.
1783         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Do not link
1784         against WebCore.
1785
1786 2011-03-14  Balazs Kelemen  <kbalazs@webkit.org>
1787
1788         Reviewed by Kenneth Rohde Christiansen.
1789
1790         check-webkit-style falsely should not complain about WebKit2 API headers in the Shared directory
1791         https://bugs.webkit.org/show_bug.cgi?id=56321
1792
1793         * Scripts/webkitpy/style/checker.py: Add the patch "Source/WebKit2/Shared/API/c"
1794         to the list of exceptions for WebKit2 C API headers.
1795
1796 2011-03-14  Adam Roben  <aroben@apple.com>
1797
1798         Show the list of recent leaky builds in reverse chronological order
1799
1800         Previously they were being shown in a deterministic but surprising order based on
1801         lexicographically sorting the build offsets (-1, -10, -2, -3...).
1802
1803         Fixes <http://webkit.org/b/56342> Leaks Viewer shows recent builds in a strange order
1804
1805         Reviewed by Darin Adler.
1806
1807         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
1808         (RecentBuildsLoader.prototype.start): Sort the builds by revision before passing them to our
1809         callback.
1810
1811 2011-03-14  Adam Roben  <aroben@apple.com>
1812
1813         Show a list of up to 10 recent leaky builds when Leaks Viewer loads
1814
1815         Fixes <http://webkit.org/b/56043> Leaks Viewer should present a list of recent builds to
1816         analyze
1817
1818         Reviewed by David Kilzer and Joe Pecoraro.
1819
1820         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
1821         (#url-prompt): Made this a bit taller to make room for the list of builds.
1822
1823         (#recent-builds-loading-indicator):
1824         (#recent-builds-list):
1825         Added styles for the build list and loading indicator.
1826
1827         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
1828         (LeaksViewer.loaded): Pass the URL from the query through decodeURIComponent before loading
1829         it. This will unescape it.
1830         (LeaksViewer.urlPromptButtonClicked): Moved code from here to _urlChosenFromPrompt.
1831         (LeaksViewer._didLoadRecentBuilds): Added. Stores the builds and updates the prompt.
1832         (LeaksViewer._displayURLPrompt): Start loading the recent leaky builds.
1833         (LeaksViewer._updateURLPrompt): Create a list of the recent leaky builds and add them to the
1834         prompt UI.
1835         (LeaksViewer._urlChosenFromPrompt): Added. Code came from urlPromptButtonClicked. This is
1836         now also used when a recent build is clicked.
1837
1838         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js: Added.
1839         (RecentBuildsLoader): Store the callback.
1840         (RecentBuildsLoader.prototype.start): Load the N most recent builds from the specified
1841         builder. Find the revision number, leak count, and results URL for each one. Pass the
1842         resulting info to our callback.
1843
1844         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Utilities.js:
1845         (range): Added this helper function to return an array containing the integers [0, n).
1846
1847         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html: Added
1848         RecentBuildsLoader.js and added text to the prompt UI to show the recent builds.
1849
1850 2011-03-14  Mark Rowe  <mrowe@apple.com>
1851
1852         Reviewed by Adam Roben.
1853
1854         Fix two memory leaks within LayoutTestController's storage support.
1855
1856         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1857         (LayoutTestController::originsWithLocalStorage): Don't leak the JSStringRef that is returned
1858         by JSStringCreateWithCFString.
1859         (LayoutTestController::deleteLocalStorageForOrigin): Don't leak the WebSecurityOrigin that we
1860         allocate.
1861
1862 2011-03-14  Mark Rowe  <mrowe@apple.com>
1863
1864         Reviewed by Oliver Hunt.
1865
1866         <http://webkit.org/b/56304> REGRESSION(r80892): 100,000+ leaks seen on the build bot
1867
1868         * DumpRenderTree/LayoutTestController.cpp:
1869         (LayoutTestController::staticFunctions): Remove duplicate entries.
1870
1871 2011-03-14  Alice Liu  <alice.liu@apple.com>
1872
1873         Reviewed by Dan Bernstein.
1874
1875         DumpRenderTree Perl Support fails to build with ARCHS="i386 x86_64"
1876
1877         * DumpRenderTree/mac/PerlSupport/Makefile:
1878         Add whitespace when joining "-arch" with the architectures passed in as arguments.
1879
1880 2011-03-14  Daniel Bates  <dbates@rim.com>
1881
1882         https://bugs.webkit.org/show_bug.cgi?id=55438
1883         Add double quotes around value of -DCMAKE_WINCE_SDK that I inadvertently did not add
1884         when landing changeset 81041 <http://trac.webkit.org/changeset/81041>.
1885
1886         * Scripts/build-webkit:
1887
1888 2011-03-14  Daniel Bates  <dbates@rim.com>
1889
1890         Reviewed by David Kilzer.
1891
1892         Cleanup: Separate port-specific implementation details from webkitdirs::buildCMakeProject()
1893         https://bugs.webkit.org/show_bug.cgi?id=55438
1894
1895         Separate out the EFL- and WinCE-specific logic from the port-independent logic in
1896         webkitdirs::buildCMakeProject(). Also, remove redundant code for generating the
1897         CMake arguments for feature defines.
1898
1899         * Scripts/build-webkit:
1900           - Added cMakeArgsFromFeatures() to convert the @features array to CMake arguments.
1901           - Modified EFL and WinCE-specific building logic to call buildCMakeProjectOrExit().
1902           - Sorted forward declarations.
1903           - Initialize $makeArgs with the empty string so as to simplify its use in string operations;
1904             Modified call sites as needed.
1905         * Scripts/webkitdirs.pm:
1906           - Added cleanCMakeGeneratedProject() to clean a CMake build.
1907           - Added buildCMakeGeneratedProject() to build using generated build system.
1908           - Added buildCMakeProjectOrExit() which is a facade for building a CMake project.
1909           - Added generateBuildSystemFromCMakeProject() to generate the build system from
1910             a CMake project.
1911           - Removed buildCMakeProject(). This functionality is in buildCMakeProjectOrExit().
1912
1913 2011-03-14  John Knottenbelt  <jknotten@chromium.org>
1914
1915         Reviewed by Steve Block.
1916
1917         Detach Geolocation from Frame when Page destroyed.
1918         https://bugs.webkit.org/show_bug.cgi?id=52877
1919
1920         Extend the layout test controller to expose the number of pending
1921         geolocation requests, so that we can test that the requests have
1922         been cancelled on page close.
1923
1924         * DumpRenderTree/LayoutTestController.cpp:
1925         (numberOfPendingGeolocationPermissionRequestsCallback):
1926         (LayoutTestController::staticFunctions):
1927         * DumpRenderTree/LayoutTestController.h:
1928         * DumpRenderTree/chromium/LayoutTestController.cpp:
1929         (LayoutTestController::LayoutTestController):
1930         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
1931         * DumpRenderTree/chromium/LayoutTestController.h:
1932         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1933         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
1934         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1935         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
1936         * DumpRenderTree/mac/UIDelegate.h:
1937         * DumpRenderTree/mac/UIDelegate.mm:
1938         (-[UIDelegate numberOfPendingGeolocationPermissionRequests]):
1939         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1940         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
1941         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1942         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1943         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
1944         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1945         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
1946
1947
1948 2011-03-14  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1949
1950         Unreviewed. Modify my email address in committers.py.
1951
1952         * Scripts/webkitpy/common/config/committers.py:
1953
1954 2011-03-13  Joe Wild  <joseph.wild@nokia.com>
1955
1956         Reviewed by Kenneth Rohde Christiansen.
1957
1958         [Qt] QtLauncher does not load the same set of fonts as the DRT
1959         https://bugs.webkit.org/show_bug.cgi?id=34959
1960
1961         This patch adds the option "-use-test-fonts" to the QtTestBrowser.
1962         When this option is used the webkit fonts are loaded the same
1963         as they are in DumpRenderTree.  This option can be used on
1964         QtTestBrowser and run-launcher.  It can only be used
1965         on Linux systems with FcInit and is configured as such.
1966
1967         * QtTestBrowser/launcherwindow.h:
1968         (WindowOptions::WindowOptions):
1969         * QtTestBrowser/main.cpp:
1970         (initWebKitTestFonts):
1971         (launcherMain):
1972         (LauncherApplication::handleUserOptions):
1973
1974 2011-03-12  Dan Bernstein  <mitz@apple.com>
1975
1976         Reviewed by Mark Rowe.
1977
1978         <rdar://problem/8995822> Build DumpRenderTree perl support only for the architectures
1979         DumpRenderTree is being built for.
1980
1981         * DumpRenderTree/mac/PerlSupport/Makefile:
1982
1983 2011-03-12  Dan Bernstein  <mitz@apple.com>
1984
1985         Suggested by Mark Rowe.
1986
1987         * DumpRenderTree/mac/Configurations/Base.xcconfig: Leave C++ exceptions enabled
1988         as they were before r80915.
1989
1990 2011-03-12  Anders Carlsson  <andersca@apple.com>
1991
1992         Reviewed by Sam Weinig.
1993
1994         Should be able to download a PDF to the Downloads folder
1995         https://bugs.webkit.org/show_bug.cgi?id=56256
1996
1997         * MiniBrowser/mac/BrowserWindowController.m:
1998         (-[BrowserWindowController awakeFromNib]):
1999         * WebKitTestRunner/TestController.cpp:
2000         (WTR::TestController::createOtherPage):
2001         (WTR::TestController::initialize):
2002         Update for API changes.
2003
2004 2011-03-11  Anton D'Auria  <adauria@apple.com>
2005
2006         Reviewed and landed by Brady Eidson.
2007
2008         https://bugs.webkit.org/show_bug.cgi?id=51878
2009         Add WebKit1 API to view and delete local storage
2010
2011         Added tests that write to LocalStorage, delete one origin, get list of origins with local storage, delete all origins.
2012
2013         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2014         * DumpRenderTree/LayoutTestController.cpp:
2015         (syncLocalStorageCallback):
2016         (observeStorageTrackerNotificationsCallback):
2017         (deleteAllLocalStorageCallback):
2018         (deleteLocalStorageForOriginCallback):
2019         (originsWithLocalStorageCallback):
2020         (LayoutTestController::staticFunctions):
2021         * DumpRenderTree/LayoutTestController.h:
2022         * DumpRenderTree/StorageTrackerDelegate.h: Added.
2023         * DumpRenderTree/StorageTrackerDelegate.mm: Added.
2024         (-[StorageTrackerDelegate init]):
2025         (-[StorageTrackerDelegate logNotifications:controller:]):
2026         (-[StorageTrackerDelegate originModified:]):
2027         (-[StorageTrackerDelegate dealloc]):
2028         (-[StorageTrackerDelegate setControllerToNotifyDone:]):
2029         * DumpRenderTree/chromium/LayoutTestController.cpp:
2030         (LayoutTestController::LayoutTestController):
2031         (LayoutTestController::deleteAllLocalStorage):
2032         (LayoutTestController::originsWithLocalStorage):
2033         (LayoutTestController::deleteLocalStorageForOrigin):
2034         (observeStorageTrackerNotifications):
2035         (syncLocalStorage):
2036         * DumpRenderTree/chromium/LayoutTestController.h:
2037         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2038         (LayoutTestController::originsWithLocalStorage):
2039         (LayoutTestController::deleteAllLocalStorage):
2040         (LayoutTestController::deleteLocalStorageForOrigin):
2041         (LayoutTestController::observeStorageTrackerNotifications):
2042         (LayoutTestController::syncLocalStorage):
2043         * DumpRenderTree/mac/DumpRenderTree.mm:
2044         (resetDefaultsToConsistentValues):
2045         (allocateGlobalControllers):
2046         (releaseGlobalControllers):
2047         * DumpRenderTree/mac/DumpRenderTreeMac.h:
2048         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2049         (LayoutTestController::syncLocalStorage):
2050         (LayoutTestController::observeStorageTrackerNotifications):
2051         (LayoutTestController::deleteAllLocalStorage):
2052         (LayoutTestController::originsWithLocalStorage):
2053         (LayoutTestController::deleteLocalStorageForOrigin):
2054         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2055         (LayoutTestController::originsWithLocalStorage):
2056         (LayoutTestController::deleteAllLocalStorage):
2057         (LayoutTestController::deleteLocalStorageForOrigin):
2058         (LayoutTestController::observeStorageTrackerNotifications):
2059         (LayoutTestController::syncLocalStorage):
2060         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2061         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2062         (LayoutTestController::clearAllApplicationCaches):
2063         (LayoutTestController::syncLocalStorage):
2064         (LayoutTestController::observeStorageTrackerNotifications):
2065         (LayoutTestController::clearAllDatabases):
2066         (LayoutTestController::deleteAllLocalStorage):
2067         (LayoutTestController::originsWithLocalStorage):
2068         (LayoutTestController::deleteLocalStorageForOrigin):
2069         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2070         (LayoutTestController::syncLocalStorage):
2071         (LayoutTestController::observeStorageTrackerNotifications):
2072         (LayoutTestController::clearAllDatabases):
2073         (LayoutTestController::deleteAllLocalStorage):
2074         (LayoutTestController::originsWithLocalStorage):
2075         (LayoutTestController::deleteLocalStorageForOrigin):
2076
2077 2011-03-11  Jessie Berlin  <jberlin@apple.com>
2078
2079         Reviewed by Adam Roben.
2080
2081         Crash calling WebContext::clearResourceCaches(InMemoryResourceCachesOnly) before the Web
2082         Process has finished launching.
2083         https://bugs.webkit.org/show_bug.cgi?id=56208
2084
2085         * TestWebKitAPI/Tests/WebKit2/SendingMessagesToTheWebProcessBeforeItIsValid.cpp: Added.
2086         (TestWebKitAPI::TEST):
2087         Test that calling WKContextClearResourceCaches works with both options when called before
2088         the Web Process is valid.
2089
2090         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2091         Add the new test.
2092         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2093         Ditto.
2094
2095 2011-03-11  Adam Roben  <aroben@apple.com>
2096
2097         Make it possible to view all leaks from a build at once in Leaks Viewer
2098
2099         You can now give Leaks Viewer the URL of a build results page (e.g.,
2100         <http://build.webkit.org/results/SnowLeopard%20Intel%20Leaks/r80847%20(15493)/>), and it
2101         will load all the leaks files from that build.
2102
2103         Fixes <http://webkit.org/b/56030> Leaks Viewer: Would like to be able to look at all leaks
2104         files from a particular build at once, rather than one at a time
2105
2106         Reviewed by David Kilzer.
2107
2108         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksLoader.js: Added.
2109         (LeaksLoader): Initialize our properties.
2110         (LeaksLoader.prototype.start): If the URL ends in .txt, assume it's a single leaks file and
2111         load it. Otherwise assume it's a build results page URL and start fetching the leaks files
2112         from that page.
2113         (LeaksLoader.prototype._loadLeaksFiles): Tell our client how many leaks files we're loading
2114         so it can provide feedback. Then load each one and pass it to the client.
2115         (LeaksLoader.prototype._loadLeaksFromResultsPage): Load the HTML of the results page, parse
2116         it into a DOM, pull out all the links to leaks files, and load each one.
2117
2118         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParser.js: Added.
2119         (LeaksParser): Initialize our worker.
2120         (LeaksParser.prototype.addLeaksFile): Tell the worker about the leaks file's contents.
2121
2122         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js: Added.
2123         This code mostly came from Worker.js.
2124         (LeaksParserWorker): Initialize our profile.
2125         (LeaksParserWorker.prototype.addLeaksFile): Parse the leaks file and incorporate it into our
2126         profile.
2127         (LeaksParserWorker.prototype._parseLeaks):
2128         (LeaksParserWorker.prototype._createNode):
2129         (LeaksParserWorker.prototype._incorporateLeaks):
2130         Moved these functions here from LeaksViewer. _incorporateLeaks is essentially just a renamed
2131         version of createProfile which adds to this.profile instead of making a new profile each
2132         time.
2133         (onmessage): Parse the file and send back the new profile.
2134
2135         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
2136         (#loading-indicator):
2137         (#spinner):
2138         (#loading-indicator-label):
2139         Tweaked styles to accomodate a longer label.
2140
2141         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
2142         (LeaksViewer.loaded): Set up a loader and parser.
2143
2144         (LeaksViewer.get filesLeftToParse):
2145         (LeaksViewer.set filesLeftToParse):
2146         Added these simple accessors.
2147
2148         (LeaksViewer._didCountLeaksFiles): Callback from LeaksLoader. Stores the count.
2149         (LeaksViewer._didLoadLeaksFile): Callback from LeaksLoader. Passes the file contents off to
2150         the parser.
2151         (LeaksViewer._didParseLeaksFile): Callback from LeaksParser. If all files have been parsed,
2152         tell the ProfilerAgent and mark that we're done loading. (Code came from the old
2153         _loadLeaksFromURL function).
2154         (LeaksViewer._loadLeaksFromURL): Now just calls through to the loader.
2155         (LeaksViewer._loadingIndicatorText): Added. Returns the text that should show up in the
2156         loading indicator, including the number of files being loaded.
2157         (LeaksViewer._loadingStatusChanged): Update the loading indicator's label, too.
2158         (LeaksViewer._updateLoadingIndicatorLabel): Added. Just updates the label!
2159         (LeaksViewer._updateTitle): Moved code to compute the "Loading" text to
2160         _loadingIndicatorText.
2161
2162         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Utilities.js: Added.
2163         (getResource): Moved here from LeaksViewer.js.
2164
2165         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Worker.js: Subsumed by
2166         LeaksParserWorker.js.
2167
2168         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html: Added new JS
2169         files, added a #loading-indicator-label element, and tweaked the prompt wording.
2170
2171 2011-03-11  Adam Roben  <aroben@apple.com>
2172
2173         Don't trigger a build when build.webkit.org's HTML files are modified
2174
2175         Fixes <http://webkit.org/b/56190> Windows bots shouldn't have built r80848/r80851, but did
2176
2177         Reviewed by Dan Bernstein.
2178
2179         * Scripts/webkitpy/common/config/build.py:
2180         (_should_file_trigger_build): Added build.webkit.org's public_html directory to the list of
2181         directories that shouldn't trigger builds. Re-sorted the list.
2182
2183         * Scripts/webkitpy/common/config/build_unittest.py:
2184         (ShouldBuildTest): Added a test to cover the above change.
2185
2186 2011-03-11  Adam Roben  <aroben@apple.com>
2187
2188         Roll out r80848
2189
2190         It was accidentally committed.
2191
2192         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
2193         (LeaksViewer._loadLeaksFromURL):
2194
2195 2011-03-11  Tony Chang  <tony@chromium.org>
2196
2197         Reviewed by Ojan Vafai.
2198
2199         kill hung lighttpd processes on the chromium win bot
2200         https://bugs.webkit.org/show_bug.cgi?id=56152
2201
2202         Sometimes this process doesn't exit and it holds on to
2203         a log file that we can't delete or copy, causing the tests
2204         to go red.
2205
2206         * BuildSlaveSupport/win/kill-old-processes:
2207
2208 2011-03-11  Ilya Sherman  <isherman@chromium.org>
2209
2210         Reviewed by Kent Tamura.
2211
2212         [Chromium] missing HTMLInputElement::setValueForUser() to tests
2213         https://bugs.webkit.org/show_bug.cgi?id=55854
2214
2215         * DumpRenderTree/chromium/LayoutTestController.cpp:
2216         (LayoutTestController::LayoutTestController):
2217         (LayoutTestController::setValueForUser): Added.
2218         * DumpRenderTree/chromium/LayoutTestController.h:
2219
2220 2011-03-10  Peter Kasting  <pkasting@google.com>
2221
2222         Reviewed by Dimitri Glazkov.
2223
2224         Clean up some gross code in TestShellWin.cpp.  No functional change.
2225         https://bugs.webkit.org/show_bug.cgi?id=56048
2226
2227         * DumpRenderTree/chromium/TestShellWin.cpp:
2228         (checkLayoutTestSystemDependencies):
2229
2230 2011-03-10  Keith Kyzivat  <keith.kyzivat@nokia.com>
2231
2232         Reviewed by Laszlo Gombos.
2233
2234         [Qt] Buildfix for platforms where X11 is not available (e.g. Symbian)
2235
2236         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
2237         (WTR::activateFonts): Guard X11-specific code with Q_WS_X11.
2238
2239 2011-03-10  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2240
2241         Reviewed by Kenneth Rohde Christiansen.
2242
2243         [EFL] Make single backing store the default for EWebLauncher
2244         https://bugs.webkit.org/show_bug.cgi?id=55753
2245
2246         Set single backing store the default for EWebLauncher.
2247
2248         * EWebLauncher/main.c:
2249         (main):
2250
2251 2011-03-10  Adam Roben  <aroben@apple.com>
2252
2253         Ignore errors from files being held open when creating a test result archive
2254
2255         Fixes <http://webkit.org/b/55581> Test results don't get uploaded if test-result-archive
2256         fails to delete the results directory
2257
2258         Reviewed by Mark Rowe.
2259
2260         * BuildSlaveSupport/test-result-archive:
2261         (archiveTestResults): Ignore errno 2 when deleting the results directory, since it can be
2262         thrown when a process is holding a file open.
2263
2264 2011-03-10  Sheriff Bot  <webkit.review.bot@gmail.com>
2265
2266         Unreviewed, rolling out r80701.
2267         http://trac.webkit.org/changeset/80701
2268         https://bugs.webkit.org/show_bug.cgi?id=56126
2269
2270         fast/dom/Geolocation/window-close-crash.html fails on Snow
2271         Leopard release builds (Requested by mihaip on #webkit).
2272
2273         * DumpRenderTree/LayoutTestController.cpp:
2274         (LayoutTestController::staticFunctions):
2275         * DumpRenderTree/LayoutTestController.h:
2276         * DumpRenderTree/chromium/LayoutTestController.cpp:
2277         (LayoutTestController::LayoutTestController):
2278         * DumpRenderTree/chromium/LayoutTestController.h:
2279         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2280         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2281         * DumpRenderTree/mac/UIDelegate.h:
2282         * DumpRenderTree/mac/UIDelegate.mm:
2283         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2284         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2285         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2286         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2287
2288 2011-03-10  Philippe Normand  <pnormand@igalia.com>
2289
2290         Reviewed by Gustavo Noronha Silva.
2291
2292         [GTK] run-gtk-tests doesn't fail if a test crashes
2293         https://bugs.webkit.org/show_bug.cgi?id=56089
2294
2295         * Scripts/run-gtk-tests: gtester -k exits with a 0 exit status
2296         even if a test crashes. So run the tests individually and if a
2297         test fails remember its exit code so run-gtk-test fails too, if
2298         required.
2299
2300 2011-01-26  John Knottenbelt  <jknotten@chromium.org>
2301
2302         Reviewed by Dmitry Titov.
2303
2304         Detach Geolocation from Frame when Page destroyed.
2305         https://bugs.webkit.org/show_bug.cgi?id=52877
2306
2307         Extend the layout test controller to expose the number of pending
2308         geolocation requests, so that we can test that the requests have
2309         been cancelled on page close.
2310
2311         * DumpRenderTree/LayoutTestController.cpp:
2312         (numberOfPendingGeolocationPermissionRequestsCallback):
2313         (LayoutTestController::staticFunctions):
2314         * DumpRenderTree/LayoutTestController.h:
2315         * DumpRenderTree/chromium/LayoutTestController.cpp:
2316         (LayoutTestController::LayoutTestController):
2317         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2318         * DumpRenderTree/chromium/LayoutTestController.h:
2319         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2320         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2321         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2322         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2323         * DumpRenderTree/mac/UIDelegate.h:
2324         * DumpRenderTree/mac/UIDelegate.mm:
2325         (-[UIDelegate numberOfPendingGeolocationPermissionRequests]):
2326         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2327         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2328         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2329         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2330         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2331         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2332         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2333
2334
2335 2011-03-09  Adam Roben  <aroben@apple.com>
2336
2337         Hide Leaks Viewer's URL prompt by default
2338
2339         We will show it as needed. I think I left it visible by default by accident after doing some
2340         testing.
2341
2342         Fixes <http://webkit.org/b/56031> Leaks Viewer: URL prompt overlay shouldn't appear when a
2343         URL is passed as a query parameter, but does
2344
2345         Reviewed by Simon Fraser.
2346
2347         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html:
2348
2349 2011-03-09  Adam Roben  <aroben@apple.com>
2350
2351         Don't use Element.classList or box-shadow in Leaks Viewer
2352
2353         They aren't supported by Safari 5. Luckily we have substitutes for them!
2354
2355         Fixes <http://webkit.org/b/56035> Leaks viewer doesn't work in Safari 5
2356
2357         Reviewed by Simon Fraser.
2358
2359         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
2360         (#url-prompt): Use -webkit-box-shadow instead of box-shadow.
2361
2362         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
2363         (LeaksViewer.urlPromptButtonClicked):
2364         (LeaksViewer._displayURLPrompt):
2365         (LeaksViewer._setLoadingIndicatorHidden):
2366         Use add/removeStyleClass (from utilities.js) instead of Element.classList.
2367
2368 2011-03-09  Adam Roben  <aroben@apple.com>
2369
2370         Add a link to the Leaks Viewer tool on the build.webkit.org homepage
2371
2372         Rubber-stamped by David Kilzer.
2373
2374         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
2375
2376 2011-03-09  Adam Roben  <aroben@apple.com>
2377
2378         Add a Leaks Viewer tool to build.webkit.org
2379
2380         This tool parses leaks from the files generated by the leaks bot and displays them in a
2381         view similar to the Web Inspector's Profiles pane (in fact, it uses the Web Inspector's
2382         code).
2383
2384         The URL of the leaks file can be entered in a prompt when the tools is first shown, or can
2385         be passed to the tool via the "url" query parameter.
2386
2387         Only one leaks file can be viewed at a time for now. Only the number of leaks, as opposed to
2388         the number of leaked bytes, is shown. And this tool has made apparent some bugs in the Web
2389         Inspector's Heavy profile view. But it's still pretty useful as-is.
2390
2391         Fixes <http://webkit.org/b/56028> Would like a Shark-like tool for viewing leaks from leak bots
2392
2393         Reviewed by Darin Adler.
2394
2395         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css: Added.
2396         (#url-prompt-container): This is the dark overlay that is shown behind the URL prompt.
2397         (#url-prompt): This is the prompt itself.
2398
2399         (#loading-indicator):
2400         (#loading-indicator > img):
2401         These show a spinner in the bottom-right when we're loading a leaks file.
2402
2403         (.percent-time-status-bar-item): Hide the Percent button since we never want to show leaks
2404         as percentages.
2405
2406         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js: Added.
2407         (LeaksViewer.loaded): Initialize ourselves and start loading the leaks file (or prompt for a
2408         URL if one wasn't given to us as a query parameter).
2409
2410         (LeaksViewer.get loading):
2411         (LeaksViewer.set loading):
2412         (LeaksViewer.get url):
2413         (LeaksViewer.set url):
2414         Pretty simple accessors.
2415
2416         (LeaksViewer.urlPromptButtonClicked): Start loading the URL from the prompt and hide the
2417         prompt.
2418         (LeaksViewer._displayURLPrompt): Show the prompt and focus the URL input.
2419         (LeaksViewer._loadLeaksFromURL): Start fetching the leaks file. When we've retrieved the
2420         file, hand it off to a Web Worker that will parse it into a fake "profile", then hand off
2421         the profile to the Web Inspector code once it's been created.
2422         (LeaksViewer._loadingStatusChanged): Update our loading indicator and title.
2423         (LeaksViewer._setLoadingIndicatorHidden): Simply hide or show the indicator.
2424         (LeaksViewer._updateTitle): Set our title based on our URL and loading status.
2425         (getResource): Helper function to fetch a resource via XHR and pass it to a callback.
2426
2427         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js: Added.
2428         (WebInspector.UIString): Just a simple implementation since this tool isn't localized.
2429         (ProfilerAgent.getProfile): Store the callback.
2430         (ProfilerAgent.profileReady): Call the callback.
2431         (monkeyPatchInspectorObjects): Fix up WebInspector.ProfileDataGridNode to show the self leak
2432         count and total leak counts as real values, not percentages or milliseconds.
2433
2434         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Worker.js: Added.
2435         (onmessage): Create a profile based on the leaks file and pass it back to our caller.
2436         (parseLeaks): Extract call stacks out of a leaks file.
2437         (createNode): Helper function to create a new empty profile node.
2438         (createProfile): Take the leak stacks and turn them into a fake "profile" for consumption by
2439         WebInspector.ProfileView.
2440
2441         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html: Added.
2442
2443 2011-03-09  Dan Bernstein  <mitz@apple.com>
2444
2445         Reviewed by Adam Roben.
2446
2447         Combine multiple --ignore-tests values
2448         https://bugs.webkit.org/show_bug.cgi?id=56016
2449
2450         * Scripts/old-run-webkit-tests:
2451
2452 2011-03-08  Kenji Imasaki  <imasaki@chromium.org>
2453
2454         Reviewed by David Levin.
2455
2456         Adding myself to the committer file.
2457
2458         * Scripts/webkitpy/common/config/committers.py:
2459
2460 2011-03-08  Jessie Berlin  <jberlin@apple.com>
2461
2462         Rubber-stamped by Adam Roben.
2463
2464         Fix two leaks I introduced into the API tests.
2465
2466         * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp:
2467         (TestWebKitAPI::TEST):
2468
2469 2011-03-08  Jessie Berlin  <jberlin@apple.com>
2470
2471         Reviewed by Anders Carlsson.
2472
2473         Crash in CFNetwork visiting google.com
2474         https://bugs.webkit.org/show_bug.cgi?id=55958
2475
2476         Add a test for not trying to copy a null CFURLResponse.
2477
2478         * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp: Added.
2479         (TestWebKitAPI::TEST):
2480         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2481
2482 2011-03-08  Hayato Ito  <hayato@chromium.org>
2483
2484         Reviewed by Ojan Vafai.
2485
2486         [NRWT] Renamed a FailureWithType class to a ComparisonTestFailure class.
2487
2488         FailureWithType is a confusing naming because we have removed test_type/* classes in r79840.
2489
2490         https://bugs.webkit.org/show_bug.cgi?id=55450
2491
2492         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
2493
2494 2011-03-08  Carlos Garcia Campos  <cgarcia@igalia.com>
2495
2496         Reviewed by Martin Robinson.
2497
2498         [GTK] Add layoutTestController.setValueForUser() after r80412
2499         https://bugs.webkit.org/show_bug.cgi?id=55862
2500
2501         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2502         (LayoutTestController::setValueForUser): Implement setValueForUser()
2503
2504 2011-03-08  Patrick Gansterer  <paroga@webkit.org>
2505
2506         Reviewed by Adam Barth.
2507
2508         Add script_shell_command to WebKitPort
2509         https://bugs.webkit.org/show_bug.cgi?id=55925
2510
2511         Add a central place where we generate the shell command from the script name.
2512         This function will be used later to detect the correct script interpreter on Win32.
2513
2514         * Scripts/webkitpy/common/config/ports.py:
2515         * Scripts/webkitpy/layout_tests/port/base.py:
2516         * Scripts/webkitpy/tool/steps/abstractstep.py:
2517         * Scripts/webkitpy/tool/steps/preparechangelog.py:
2518
2519 2011-03-07  Ojan Vafai  <ojan@chromium.org>
2520
2521         Reviewed by Adam Barth.
2522
2523         add webkit-patch attach-to-bug for posting to bugzilla from the commandline
2524         https://bugs.webkit.org/show_bug.cgi?id=55749
2525
2526         * Scripts/webkitpy/tool/commands/upload.py:
2527         * Scripts/webkitpy/tool/commands/upload_unittest.py:
2528         * Scripts/webkitpy/tool/steps/__init__.py:
2529         * Scripts/webkitpy/tool/steps/attachtobug.py: Added.
2530         * Scripts/webkitpy/tool/steps/options.py:
2531
2532 2011-03-07  Daniel Cheng  <dcheng@chromium.org>
2533
2534         Reviewed by David Levin.
2535
2536         Add support for DataTransferItems
2537         https://bugs.webkit.org/show_bug.cgi?id=55115
2538
2539         Enable data transfer items in DRT.
2540
2541         * DumpRenderTree/chromium/TestShell.cpp:
2542         (TestShell::TestShell):
2543
2544 2011-03-06  Ojan Vafai  <ojan@chromium.org>
2545
2546         Reviewed by Tony Chang.
2547
2548         [test dashboard] pull treemap files
2549         https://bugs.webkit.org/show_bug.cgi?id=55852
2550
2551         * TestResultServer/handlers/dashboardhandler.py:
2552
2553 2011-03-03  Hayato Ito  <hayato@chromium.org>
2554
2555         Reviewed by Mihai Parparita.
2556
2557         [NRWT] Clear output image file used by DumpRenderTree to make sure the
2558         previous image should not be used in the ChromiumDriver.
2559
2560         Also make sure that output image from the ChromiumDriver should be ''
2561         (empty string) if a test crashes for consistency with the WebKitDriver
2562         implementation.
2563
2564         https://bugs.webkit.org/show_bug.cgi?id=55746
2565
2566         * Scripts/webkitpy/layout_tests/port/chromium.py:
2567
2568 2011-03-07  Zan Dobersek  <zandobersek@gmail.com>
2569
2570         Reviewed by Martin Robinson.
2571
2572         [Gtk] fast/js/navigator-language.html fails locally
2573         https://bugs.webkit.org/show_bug.cgi?id=55880
2574
2575         Add LANG variable to the clean environment when running
2576         old-run-webkit-tests script.
2577
2578         * Scripts/old-run-webkit-tests:
2579
2580 2011-03-07  Tony Chang  <tony@chromium.org>
2581
2582         Reviewed by Mihai Parparita.
2583
2584         [Chromium] Find .checksum files without .pngs and vice-versa
2585         https://bugs.webkit.org/show_bug.cgi?id=55236
2586
2587         * Scripts/find-mismatched-layout-test-results: Added. A script for finding
2588             mismatched results.
2589
2590 2011-03-07  Chris Fleizach  <cfleizach@apple.com>
2591
2592         Reviewed by Beth Dakin.
2593
2594         AX: WK1 needs to use the ScrollView attachment for AXScrollArea, WK2 should not use this element.
2595         https://bugs.webkit.org/show_bug.cgi?id=55706
2596
2597         The rootElement in DRT should point to the scroll view. In WK1, that will be the parent of the rootObject.
2598
2599         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
2600         (AccessibilityController::focusedElement):
2601            Remove FIXME comment about caching the focusedElement. In fact, we shouldn't cache this 
2602            because it could change at any time.
2603         (AccessibilityController::rootElement):
2604
2605 2011-03-07  Sam Weinig  <sam@webkit.org>
2606
2607         Reviewed by Anders Carlsson.
2608
2609         Add unableToImplementPolicy callback for WebKit2 policy client
2610         <rdar://problem/9071902>
2611         https://bugs.webkit.org/show_bug.cgi?id=55884
2612
2613         * MiniBrowser/mac/BrowserWindowController.m:
2614         (-[BrowserWindowController awakeFromNib]):
2615         Update policy client initialization struct for new member.
2616
2617 2011-03-07  Sam Weinig  <sam@webkit.org>
2618
2619         Reviewed by Anders Carlsson.
2620
2621         Replace WebKit2's decidePolicyForMIMEType with decidePolicyForResponse
2622         https://bugs.webkit.org/show_bug.cgi?id=55827
2623
2624         * MiniBrowser/mac/BrowserWindowController.m:
2625         (decidePolicyForResponse):
2626         (-[BrowserWindowController awakeFromNib]):
2627         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
2628         (TestWebKitAPI::decidePolicyForResponse):
2629         (TestWebKitAPI::TEST):
2630         Update tools for new name.
2631
2632 2011-03-06  Daniel Bates  <dbates@rim.com>
2633
2634         Reviewed by Eric Seidel and David Kilzer.
2635
2636         Fix misspelled word in build-webkit's checkForJavaSDK() and sort forward declarations
2637         https://bugs.webkit.org/show_bug.cgi?id=55503
2638
2639         Fix misspelled word "Dowloads" [sic] in the message printed to standard output
2640         in checkForJavaSDK().
2641
2642         Also, remove extraneous space in function prototype for unlinkZeroFiles.
2643
2644         * Scripts/build-webkit:
2645
2646 2011-03-05  Brian Weinstein  <bweinstein@apple.com>
2647
2648         Reviewed by Sam Weinig.
2649
2650         Fix Web Process crashes caused by https://bugs.webkit.org/show_bug.cgi?id=53919.
2651
2652         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2653         (WTR::InjectedBundlePage::willSendRequestForFrame): Retain the WKURLRequestRef returned
2654             by willSendRequestForFrame. The API expects a retained reference to the URL request.
2655
2656 2011-03-05  Ilya Sherman  <isherman@chromium.org>
2657
2658         Reviewed by Darin Adler.
2659
2660         HTMLInputElement::setValue() should schedule change event when the element is focused
2661         In service of https://code.google.com/p/chromium/issues/detail?id=42716
2662         https://bugs.webkit.org/show_bug.cgi?id=53160
2663
2664         * DumpRenderTree/LayoutTestController.cpp:
2665         (setValueForUserCallback):
2666         (LayoutTestController::staticFunctions):
2667         * DumpRenderTree/LayoutTestController.h:
2668         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2669         (LayoutTestController::setValueForUser): Stubbed out; need real implementation.
2670         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2671         (LayoutTestController::setValueForUser): Expose HTMLInputElement::setValueForUser() to tests
2672         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2673         (LayoutTestController::setValueForUser): Stubbed out; need real implementation.
2674         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2675         (LayoutTestController::setValueForUser): Stubbed out; need real implementation.
2676         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2677         (LayoutTestController::setValueForUser): Stubbed out; need real implementation.
2678
2679 2011-03-04  Mark Rowe  <mrowe@apple.com>
2680
2681         Reviewed by Alexey Proskuryakov.
2682
2683         <rdar://problem/9055252> DumpRenderTree is crashing with GuardMalloc
2684
2685         GuardMalloc does not expect the memory containing its malloc_zone_t to ever be read-only.
2686         
2687         * DumpRenderTree/mac/CheckedMalloc.cpp:
2688         (protectionOfRegion): Retrieve the protection flags for the VM region containing the given address.
2689         (makeLargeMallocFailSilently): Save the initial protection flags, temporarily make the region writeable,
2690         and then restore the initial protection flags when we're done.
2691
2692 2011-03-04  Evan Martin  <evan@chromium.org>
2693
2694         Reviewed by Tony Chang.
2695
2696         [gdb] pretty-print KURL in gdb
2697         https://bugs.webkit.org/show_bug.cgi?id=55788
2698
2699         * gdb/webkit.py: extend the pretty-printers to print WTF::CString
2700         and KURLGooglePrivate.  As always, "p/r" can be used to sidestep
2701         pretty-printing.
2702
2703 2011-03-03  Timothy Hatcher  <timothy@apple.com>
2704
2705         Update the tests that use WKPageRunJavaScriptInMainFrame use the WKSerializedScriptValueRef.
2706
2707         Reviewed by Darin Adler.
2708
2709         * TestWebKitAPI/JavaScriptTest.cpp:
2710         (TestWebKitAPI::javaScriptCallback):
2711         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
2712         (TestWebKitAPI::didRunJavaScript):
2713         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
2714         (TestWebKitAPI::nullJavaScriptCallback):
2715         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
2716         (TestWebKitAPI::didRunJavaScript):
2717
2718 2011-03-03  Timothy Hatcher  <timothy@apple.com>
2719
2720         Make run-api-tests show failed if a test fails.
2721
2722         https://webkit.org/b/55725
2723
2724         Reviewed by Sam Weinig.
2725
2726         * Scripts/run-api-tests:
2727         (runTest): Remove "my" from the nested $result assignment so the
2728         check outside the condition sees the real result.
2729
2730 2011-03-02  MORITA Hajime  <morrita@google.com>
2731
2732         Reviewed by Kent Tamura.
2733
2734         [Chromium][DRT] WebTask should use webkit_support::TaskAdaptor
2735         https://bugs.webkit.org/show_bug.cgi?id=55434
2736
2737         Changed WebTask to be a subclass of webkit_support::TaskAdaptor
2738         and passed the object webkit_support::PostDelayedTask directly.
2739
2740         Note that the change keeps postTask() as is because it has a
2741         semantics taht webkit_support::PostDelayedTask() has; It jumps to
2742         the main thread.
2743
2744         * DumpRenderTree/chromium/Task.cpp:
2745         (postDelayedTask):
2746         * DumpRenderTree/chromium/Task.h:
2747         (WebTask::Run):
2748
2749 2011-03-03  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
2750
2751         Reviewed by Kenneth Rohde Christiansen.
2752
2753         [QT] Implement mock client-based geolocation for layout testing
2754         https://bugs.webkit.org/show_bug.cgi?id=54334
2755
2756         Implement testing for Client-Based geolocation for QtWebkit.
2757
2758         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2759         (WebCore::DumpRenderTree::DumpRenderTree):
2760         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2761         (LayoutTestController::reset):
2762         (LayoutTestController::setGeolocationPermission):
2763         (LayoutTestController::setMockGeolocationError):
2764         (LayoutTestController::setMockGeolocationPosition):
2765
2766 2011-03-03  Sheriff Bot  <webkit.review.bot@gmail.com>
2767
2768         Unreviewed, rolling out r80237.
2769         http://trac.webkit.org/changeset/80237
2770         https://bugs.webkit.org/show_bug.cgi?id=55714
2771
2772         Windows bots aren't ready to be core (Requested by aroben on
2773         #webkit).
2774
2775         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2776         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2777
2778 2011-03-03  Mihai Parparita  <mihaip@chromium.org>
2779
2780         Reviewed by Tony Chang.
2781
2782         NRWT: AttributeError: TestRunner2 instance has no attribute '_cancel_workers'
2783         https://bugs.webkit.org/show_bug.cgi?id=55694
2784         
2785         Fixes for interruptions in NRWT:
2786         - Make TestRunInterruptedException be pickleable correctly (the base
2787           Exception class defines a __reduce__ that does not include the reason)
2788         - Fix ordering of returned arguments from TestRunner2._run_tests
2789           (interrupted and keyboard_interrupted were reversed)
2790         - Fix cancel_workers callsites (was using old name).
2791         - In handle_exception re-raise actual exception instance that was thrown
2792
2793         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2794         * Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
2795         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
2796         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2797
2798 2011-03-03  Qi Zhang  <qi.2.zhang@nokia.com>
2799
2800         Unreviewed.
2801
2802         Adding myself as a committer.
2803
2804         * Scripts/webkitpy/common/config/committers.py:
2805
2806 2011-03-03  Tony Gentilcore  <tonyg@chromium.org>
2807
2808         Reviewed by Mihai Parparita.
2809
2810         Teach sheriffbot to answer whois commands
2811         https://bugs.webkit.org/show_bug.cgi?id=55687
2812
2813         * Scripts/webkitpy/tool/bot/irc_command.py:
2814         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2815         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
2816
2817 2011-03-03  Victoria Kirst  <vrk@google.com>
2818
2819         Reviewed by Eric Carlson.
2820
2821         Enable media tests in chromium-gpu/test_expectations
2822         https://bugs.webkit.org/show_bug.cgi?id=53608
2823
2824         Add media folder to the list of GPU test paths.
2825
2826         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2827
2828 2011-03-03  Adam Roben  <aroben@apple.com>
2829
2830         Work around a bug in KURL's parsing of Windows-style absolute file: URLs
2831
2832         Fixes <http://webkit.org/b/55674> Many tests fail in WebKit2 mode on Windows due to
2833         incorrect parsing of absolute Windows-style file: URLs
2834
2835         Reviewed by Tim Hatcher.
2836
2837         * WebKitTestRunner/TestInvocation.cpp:
2838         (WTR::createWKURL): Add a "localhost" host to file: URLs we create to work around
2839         <http://webkit.org/b/55683>.
2840
2841 2011-03-03  Tony Chang  <tony@chromium.org>
2842
2843         Reviewed by Dimitri Glazkov.
2844
2845         [chromium] Run kill-old-processes on the chromium-win bot too
2846         https://bugs.webkit.org/show_bug.cgi?id=55630
2847
2848         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2849         * BuildSlaveSupport/win/kill-old-processes: Add wdiff.exe to the kill list.
2850
2851 2011-03-03  Carlos Garcia Campos  <cgarcia@igalia.com>
2852
2853         Reviewed by Martin Robinson.
2854
2855         [GTK] DRT needs implementation of EventSender.scheduleAsynchronousClick
2856         https://bugs.webkit.org/show_bug.cgi?id=53960
2857
2858         * DumpRenderTree/gtk/EventSender.cpp:
2859         (sendClick):
2860         (scheduleAsynchronousClickCallback):
2861
2862 2011-03-03  Adam Roben  <aroben@apple.com>
2863
2864         Look for Windows-style paths when checking whether a test is an Inspector test
2865
2866         WTR part of <http://webkit.org/b/55672> <rdar://problem/9080867> All inspector tests time
2867         out or crash on Windows 7 Release (WebKit2 Tests)
2868
2869         Reviewed by Darin Adler.
2870
2871         * WebKitTestRunner/TestInvocation.cpp:
2872         (WTR::shouldOpenWebInspector): Also look for backslashes, since that's what we'll get on
2873         Windows.
2874
2875 2011-03-03  Adam Roben  <aroben@apple.com>
2876
2877         Make Windows 7 Release (Tests) a core builder
2878
2879         We can probably make Windows XP Debug (Tests) a core builder, too, but we should probably
2880         give it a few more days of greenness first.
2881
2882         Fixes <http://webkit.org/b/55665> Windows 7 Release (Tests) should be a core builder
2883
2884         Reviewed by Andreas Kling.
2885
2886         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2887         (BuildBot): Added a regexp to match Windows 7 Release (Tests).
2888
2889         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2890         (BuildBotTest): Updated the list of builders to match the current list on build.webkit.org.
2891         Updated the core regexps to match the buildbot module. Updated the expected results to match
2892         the current set of core builders.
2893
2894 2011-03-03  Benjamin Poulain  <benjamin.poulain@nokia.com>
2895
2896         Reviewed by Andreas Kling.
2897
2898         Adding myself as a reviewer.
2899
2900         * Scripts/webkitpy/common/config/committers.py:
2901
2902 2011-03-03  Lukasz Slachciak  <l.slachciak@samsung.com>
2903
2904         Reviewed by Xan Lopez.
2905
2906         [GTK] Extended application cache database API and added unit tests file.
2907         https://bugs.webkit.org/show_bug.cgi?id=55335
2908
2909         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: removed external declaration
2910         of webkit_application_cache_set_maximum_size due to API exposal.
2911
2912 2011-03-02  Ojan Vafai  <ojan@chromium.org>
2913
2914         Reviewed by Adam Barth.
2915
2916         make webkit-patch upload work for security bugs
2917         https://bugs.webkit.org/show_bug.cgi?id=55655
2918
2919         The problem is that we shell out to prepare-ChangeLog,
2920         which does not authenticate with bugzilla. All it needs from
2921         bugzilla is the bug title though. We just pass it through from
2922         webkit-patch instead.
2923
2924         * Scripts/prepare-ChangeLog:
2925         * Scripts/webkitpy/common/net/bugzilla/bug.py:
2926         * Scripts/webkitpy/tool/steps/preparechangelog.py:
2927
2928 2011-03-01  Ojan Vafai  <ojan@chromium.org>
2929
2930         Reviewed by Tony Chang.
2931
2932         [test-dashboard] make gtest JSON match layout-tests JSON
2933         https://bugs.webkit.org/show_bug.cgi?id=55556
2934
2935         http://trac.webkit.org/changeset/80090 stopped converting time_ms to t.
2936         Make this code match.
2937
2938         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2939
2940 2011-03-02  Dirk Pranke  <dpranke@chromium.org>
2941
2942         Reviewed by Tony Chang.
2943
2944         NRWT - implement Linux Hardy 64-bit port support. This involves
2945         adding support for non-'x86' architectures and updating the
2946         "deduplicate_tests" script to correctly understand that
2947         port.name() is not always equal to basename(port.baseline_path()).
2948
2949         This change introduces two new port names: 'chromium-linux-x86'
2950         and 'chromium-linux-x86_64'. Using the prior 'chromium-linux'
2951         flag will cause the code to determine which one to use at
2952         runtime, just like we currently do with 'chromium-win'.
2953
2954         https://bugs.webkit.org/show_bug.cgi?id=55535
2955
2956         * Scripts/webkitpy/common/system/executive_mock.py:
2957           Handle 'return_stderr' keyword arg to run_command()
2958         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
2959         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
2960         * Scripts/webkitpy/layout_tests/port/base.py:
2961         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2962         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
2963         * Scripts/webkitpy/layout_tests/port/factory.py:
2964         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
2965
2966 2011-03-02  Kevin Ollivier  <kevino@theolliviers.com>
2967
2968         [wx] Build fix, make sure we put the wxWebKit dylib in the right directory and
2969         update symlinks accordingly.
2970
2971         * wx/packaging/build-mac-installer.py:
2972
2973 2011-03-02  Sheriff Bot  <webkit.review.bot@gmail.com>
2974
2975         Unreviewed, rolling out r80139.
2976         http://trac.webkit.org/changeset/80139
2977         https://bugs.webkit.org/show_bug.cgi?id=55620
2978
2979         failing and crashing tests on Snow Leopard bot (Requested by
2980         mihaip1 on #webkit).
2981
2982         * DumpRenderTree/LayoutTestController.cpp:
2983         (LayoutTestController::staticFunctions):
2984         * DumpRenderTree/LayoutTestController.h:
2985         * DumpRenderTree/chromium/LayoutTestController.cpp:
2986         (LayoutTestController::LayoutTestController):
2987         * DumpRenderTree/chromium/LayoutTestController.h:
2988         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2989         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2990         * DumpRenderTree/mac/UIDelegate.h:
2991         * DumpRenderTree/mac/UIDelegate.mm:
2992         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2993         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2994         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2995         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2996
2997 2011-03-02  Adam Roben  <aroben@apple.com>
2998
2999         Wait for force a paint in WebKitTestRunner until we're actually ready to dump the output
3000
3001         This matches DumpRenderTree on Windows.
3002
3003         Fixes <http://webkit.org/b/55469> <rdar://problem/9068539> REGRESSION (r79863): Lots of
3004         dom/html/level2/html/HTMLFrameElement*.html tests crashing in FrameView::paintOverhangAreas
3005         in WebKit2
3006
3007         Reviewed by Beth Dakin.
3008
3009         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3010         (WTR::InjectedBundlePage::dump): Moved code to force a paint here...
3011         (WTR::InjectedBundlePage::didFinishLoadForFrame): ...from here.
3012
3013 2011-03-02  Daniel Cheng  <dcheng@chromium.org>
3014
3015         Reviewed by David Levin.
3016
3017         Add feature define for data transfer items
3018         https://bugs.webkit.org/show_bug.cgi?id=55510
3019
3020         * Scripts/build-webkit:
3021
3022 2011-03-02  Adam Roben  <aroben@apple.com>
3023
3024         Look in the new-to-SnowLeopard location for crash logs on SnowLeopard and newer
3025
3026         ReportCrash saves logs to ~/Library/Logs/CrashReporter on Leopard, but to
3027         ~/Library/Logs/DiagnosticReports on SnowLeopard. old-run-webkit-tests was only looking in
3028         the former location, but was getting lucky on some SnowLeopard machines because symlinks
3029         were being created there pointing into DiagnosticReports. For machines without these
3030         symlinks, crash logs were not getting captured.
3031
3032         Fixes <http://webkit.org/b/55607> old-run-webkit-tests doesn't capture crash logs on some
3033         SnowLeopard machines
3034
3035         Reviewed by Eric Seidel.
3036
3037         * Scripts/old-run-webkit-tests:
3038         (captureSavedCrashLog): Look in ~/Library/Logs/DiagnosticReports on SnowLeopard and newer.
3039
3040 2011-03-02  Adam Roben  <aroben@apple.com>
3041
3042         Don't try to capture crash logs on platforms that haven't implemented that feature
3043
3044         Fixes <http://webkit.org/b/55504> Use of uninitialized value in numeric lt (<) at
3045         Tools/Scripts/old-run-webkit-tests line 1778 seen on Qt bots after a crash
3046
3047         Reviewed by Joseph Pecoraro.
3048
3049         * Scripts/old-run-webkit-tests:
3050         (captureSavedCrashLog): Bail if we don't have a crash log glob.
3051         (findNewestFileMatchingGlob): Fix a buggy test for when no paths match the glob. This isn't
3052         strictly required to fix bug 55504, but seems worthwhile.
3053
3054 2011-01-26  John Knottenbelt  <jknotten@chromium.org>
3055
3056         Reviewed by Dmitry Titov.
3057
3058         Detach Geolocation from Frame when Page destroyed.
3059         https://bugs.webkit.org/show_bug.cgi?id=52877
3060
3061         Extend the layout test controller to expose the number of pending
3062         geolocation requests, so that we can test that the requests have
3063         been cancelled on page close.
3064
3065         * DumpRenderTree/LayoutTestController.cpp:
3066         (numberOfPendingGeolocationPermissionRequestsCallback):
3067         (LayoutTestController::staticFunctions):
3068         * DumpRenderTree/LayoutTestController.h:
3069         * DumpRenderTree/chromium/LayoutTestController.cpp:
3070         (LayoutTestController::LayoutTestController):
3071         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
3072         * DumpRenderTree/chromium/LayoutTestController.h:
3073         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3074         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
3075         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3076         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
3077         * DumpRenderTree/mac/UIDelegate.h:
3078         * DumpRenderTree/mac/UIDelegate.mm:
3079         (-[UIDelegate numberOfPendingGeolocationPermissionRequests]):
3080         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3081         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
3082         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3083         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3084         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
3085         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3086         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
3087
3088
3089 2011-03-01  Kent Tamura  <tkent@chromium.org>
3090
3091         Reviewed by Dimitri Glazkov.
3092
3093         Assertion fails when a form validation bubble appears
3094         https://bugs.webkit.org/show_bug.cgi?id=55550
3095
3096         Test: fast/forms/interactive-validation-attach-assertion.html
3097
3098         * DumpRenderTree/chromium/WebPreferences.cpp:
3099         (WebPreferences::applyTo): Enable the interactive validation feature by
3100           default. This matches to Chromium browser.
3101
3102 2011-03-01  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3103
3104         Reviewed by Kent Tamura.
3105
3106         Remove efl port style exception of Webcore/JavaScriptCore
3107         https://bugs.webkit.org/show_bug.cgi?id=55549
3108
3109         WebCore and JavaScriptCore need to adhere WebKit coding style.
3110
3111         * Scripts/webkitpy/style/checker.py:
3112
3113 2011-03-01  Tony Chang  <tony@chromium.org>
3114
3115         Reviewed by Ojan Vafai.
3116
3117         [chromium] clean up temp files on chromium-mac builder too
3118         https://bugs.webkit.org/show_bug.cgi?id=55525
3119
3120         * BuildSlaveSupport/chromium/remove-crash-logs:
3121
3122 2011-02-28  Ojan Vafai  <ojan@chromium.org>
3123
3124         Reviewed by Tony Chang.
3125
3126         wrap json in a function call to afford cross-domain loading
3127         https://bugs.webkit.org/show_bug.cgi?id=55353
3128
3129         Also delete the code that compacts the JSON. It turns out this
3130         breaks the rebaseline tool and is probably a premature optimization anyways.
3131
3132         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3133         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
3134         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3135         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
3136
3137 2011-03-01  Sheriff Bot  <webkit.review.bot@gmail.com>
3138
3139         Unreviewed, rolling out r80079.
3140         http://trac.webkit.org/changeset/80079
3141         https://bugs.webkit.org/show_bug.cgi?id=55547
3142
3143         "Broke the Win debug build?" (Requested by dcheng on #webkit).
3144
3145         * Scripts/build-webkit:
3146
3147 2011-03-01  Mark Rowe  <mrowe@apple.com>
3148
3149         Reviewed by Sam Weinig.
3150
3151         Update verification scripts to handle WebKit2.
3152
3153         * Scripts/check-for-global-initializers: Skip object files that use RefCountedLeakChecker.
3154         * Scripts/check-for-inappropriate-files-in-framework: Add some inappropriate file types for
3155         WebKit2.
3156
3157 2011-03-01  Daniel Cheng  <dcheng@chromium.org>
3158
3159         Reviewed by David Levin.
3160
3161         Add feature define for data transfer items
3162         https://bugs.webkit.org/show_bug.cgi?id=55510
3163
3164         * Scripts/build-webkit:
3165
3166 2011-02-23  Joseph Pecoraro  <joepeck@webkit.org>
3167
3168         Reviewed by Timothy Hatcher.
3169
3170         All Console Messages should be passed to ChromeClients.
3171         https://bugs.webkit.org/show_bug.cgi?id=54926
3172
3173         Update DumpRenderTree's UIDelegate to use the new console message delegate.
3174
3175         * DumpRenderTree/mac/UIDelegate.mm:
3176         (-[UIDelegate webView:addMessageToConsole:withSource:]):
3177
3178 2011-03-01  Dirk Pranke  <dpranke@chromium.org>
3179
3180         Reviewed by Adam Barth.
3181
3182         Tragically, we stopped running the python unit tests
3183         on Chromium Win just as I was getting them to be green.
3184         This patch turns them back on.
3185
3186         https://bugs.webkit.org/show_bug.cgi?id=55521
3187
3188         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3189
3190 2011-03-01  Dirk Pranke  <dpranke@chromium.org>
3191
3192         Reviewed by Adam Roben.
3193
3194         Disable
3195         webkitpy.common.system.executive_unittest.ExecutiveTest.\
3196            test_kill_all fails on win until it can be properly triaged.
3197
3198         https://bugs.webkit.org/show_bug.cgi?id=54790
3199
3200         * Scripts/webkitpy/common/system/executive_unittest.py:
3201
3202     2011-03-01  Helder Correia  <helder@sencha.com>
3203
3204             Unreviewed. Add myself to committers.py.
3205
3206             * Scripts/webkitpy/common/config/committers.py:
3207
3208 2011-03-01  Adam Roben  <aroben@apple.com>
3209
3210         Give up if a crash log for the web process is taking too long to be saved on Windows
3211
3212         This should keep the bots from getting stuck while waiting for a crash log, if writing a
3213         crash log ever hangs or the UI process for some reason doesn't notice it's finished.
3214
3215         Fixes <http://webkit.org/b/55499> WebKitTestRunner can hang forever waiting for a crash log
3216         to be saved for the web process
3217
3218         Reviewed by Steve Falkenburg.
3219
3220         * WebKitTestRunner/win/TestControllerWin.cpp:
3221         (WTR::runRunLoopUntil): Moved code to run the run loop here here from platformRunUntil.
3222         Generalized the code slightly to handle the optional object to wait on.
3223         (WTR::TestController::platformRunUntil): Use the new runRunLoopUntil function, and also use
3224         it (with a timeout) when waiting for a crash log for the web process to be saved. This will
3225         prevent us from waiting forever.
3226
3227 2011-03-01  Adam Roben  <aroben@apple.com>
3228
3229         Give WebKitLauncherWin's PDB file a name different from WebKit's
3230
3231         WebKitLauncherWin (which builds WebKit.exe) and WebKit (which builds WebKit.dll) were
3232         fighting over the same PDB file, meaning that one of them was going to lose and not have
3233         symbols. WebKitLauncherWin's PDB file is now named WebKitLauncherWin.pdb.
3234
3235         Fixes <http://webkit.org/b/55495> Crashes in WebKit.dll have bad backtraces for some test
3236         runs (due to missing symbols)
3237
3238         Reviewed by David Kilzer.
3239
3240         * WebKitLauncherWin/WebKitLauncherWinCommon.vsprops: Use the project name,
3241         "WebKitLauncherWin", instead of the target name, "WebKit", when naming the PDB file.
3242
3243 2011-03-01  Adam Roben  <aroben@apple.com>
3244
3245         Count web process crashes toward the --exit-after-n-crashes-or-timeouts limit
3246
3247         Fixes <http://webkit.org/b/55492> Web process crashes aren't counted toward the
3248         --exit-after-n-crashes-or-timeouts limit
3249
3250         Reviewed by David Kilzer.
3251
3252         * Scripts/old-run-webkit-tests:
3253         (stopRunningTestsEarlyIfNeeded): Include web process crashes in the computation, and print
3254         the number of tests that caused the web process to crash when exiting early.
3255
3256 2011-03-01  Adam Roben  <aroben@apple.com>
3257
3258         Save a crash log when the web process crashes
3259
3260         On Windows, WebKitTestRunner now detects when the web process is crashing and waits to exit
3261         until it has finished crashing, which guarantees that the crash log will have had time to be
3262         saved, too. On Mac, we always wait until ReportCrash has exited before capturing the crash
3263         log, so all we have to do is choose the right crash log out of the CrashReporter directory.
3264
3265         Fixes <http://webkit.org/b/44121> <rdar://problem/8320759> When the web process crashes and
3266         a crash log is being saved, WebKitTestRunner thinks the web process has become unresponsive
3267
3268         Reviewed by Sam Weinig.
3269
3270         * Scripts/old-run-webkit-tests:
3271         (testCrashedOrTimedOut): Don't kill WebKitTestRunner when the web process crashes. It will
3272         kill itself. On Windows, this will cause us to wait until the crash log has been saved. On
3273         Mac, it should have no effect. Capture saved crash logs for web process crashes, too.
3274         (captureSavedCrashLog): Added $webProcessCrashed argument. On Mac, look for
3275         WebProces_*.crash files when the web process crashes.
3276
3277         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3278         (WTR::InjectedBundle::initialize): Added an initializationUserData argument. Updated for
3279         initializePlatformDefaults -> platformInitialize rename. Pass the initializationUserData
3280         along to platformInitialize.
3281
3282         * WebKitTestRunner/InjectedBundle/InjectedBundle.h: See above.
3283
3284         * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp:
3285         (WKBundleInitialize): Pass along the initializationUserData to the InjectedBundle.
3286
3287         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
3288         (WTR::InjectedBundle::platformInitialize):
3289         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
3290         (WTR::InjectedBundle::platformInitialize):
3291         Updated function signature.
3292
3293         * WebKitTestRunner/InjectedBundle/win/InjectedBundleWin.cpp:
3294         (WTR::exceptionFilter): Added. Tells the UI process we're crashing by signaling the
3295         webProcessCrashingEvent, then lets the crash continue as normal.
3296
3297         (WTR::InjectedBundle::platformInitialize): Hook up exceptionFilter. Retrieve the name of the
3298         event we should use to tell the UI process we're crashing from the initializationUserData,
3299         and get a handle to that event.
3300
3301         * WebKitTestRunner/TestController.cpp:
3302         (WTR::TestController::TestController): Initialize new members.
3303         (WTR::TestController::processDidCrash): Removed unnecessary WKPageRef argument. Changed to
3304         only print the "#CRASHED - WebProcess" message once, since this can be called more than once
3305         when a crash log is being saved on Windows. Exit right away if specified. (This is the
3306         default.)
3307
3308         * WebKitTestRunner/TestController.h: Added new members.
3309
3310         * WebKitTestRunner/win/TestControllerWin.cpp:
3311         (WTR::TestController::platformInitialize): Set up the event the web process will use to tell
3312         us it's crashing.
3313         (WTR::TestController::platformRunUntil): Pass MWMO_INPUTAVAILABLE to
3314         ::MsgWaitForMultipleObjectsEx so we'll process messages that have already been seen by
3315         ::PeekMessage. (This is unrelated to the bug fix.) Notice when the webProcessCrashingEvent
3316         has been signaled. When this happens, print the "#CRASHED - WebProcess" message right away
3317         so the test harness will know the web process has crashed and not try to kill us, then wait
3318         for the web process to finish crashing so a crash log will have time to be saved.
3319         (WTR::toWK): Simple hepler function.
3320         (WTR::TestController::platformInitializeContext): Pass along the name of the event the web
3321         process should use to tell us it is crashing in the context's initialization user data.
3322
3323 2011-03-01  Dimitri Glazkov  <dglazkov@chromium.org>
3324
3325         Reviewed by Tony Gentilcore.
3326
3327         Move the checks to exclude Python/Perl tests for Chromium Win build to the right place.
3328         https://bugs.webkit.org/show_bug.cgi?id=55476
3329
3330         Chromium Win uses BuildAndTestFactory, not TestFactory.
3331
3332         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Moved to the right place.
3333
3334 2011-03-01  Adam Roben  <aroben@apple.com>
3335
3336         Test that the WebKit2 responsiveness timer doesn't fire too early
3337
3338         Test for <http://webkit.org/b/55417> <rdar://problem/9065287> RunLoop::Timer fires 1000x too
3339         early on Windows
3340
3341         Reviewed by Anders Carlsson.
3342
3343         * TestWebKitAPI/PlatformUtilities.h: Added sleep().
3344
3345         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly.cpp: Added.
3346         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
3347         (TestWebKitAPI::didFinishLoadForFrame):
3348         (TestWebKitAPI::processDidBecomeUnresponsive):
3349         (TestWebKitAPI::setInjectedBundleClient):
3350         (TestWebKitAPI::setPageLoaderClient):
3351         Simple helper functions.
3352
3353         (TestWebKitAPI::TEST): Load an HTML file to make sure the web process is initialized. Then
3354         tell the web process to pause and press the spacebar key. The spacebar keypress should cause
3355         the responsiveness timer to start, but the web process should unpause before it has a chance
3356         to fire. Run until the web process has unpaused, and assert that the timer didn't fire.
3357
3358         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly_Bundle.cpp: Added.
3359         (TestWebKitAPI::ResponsivenessTimerDoesntFireEarlyTest::ResponsivenessTimerDoesntFireEarlyTest):
3360         Call up to the base class.
3361         (TestWebKitAPI::ResponsivenessTimerDoesntFireEarlyTest::didReceiveMessage): When asked to
3362         pause, sleep for 0.5 seconds, then send back a message saying we paused.
3363
3364         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
3365         (TestWebKitAPI::Util::sleep): Added. Calls through to usleep.
3366         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
3367         (TestWebKitAPI::Util::sleep): Added. Calls through to ::Sleep.
3368
3369         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3370         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3371         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
3372         Added new files.
3373
3374 2011-03-01  Andras Becsi  <abecsi@webkit.org>
3375
3376         Reviewed by Csaba Osztrogonác.
3377
3378         [Qt] Clean up the project files and move common options to WebKit.pri.
3379
3380         * WebKitTestRunner/qt/WebKitTestRunner.pro: Deduplicate.
3381
3382
3383 2011-03-01  Adam Roben  <aroben@apple.com>
3384
3385         Skip another multiprocessing test on Windows
3386
3387         It is sometimes failing (and may be leaving child Python processes around).
3388         <http://webkit.org/b/55087> tracks the failure.
3389
3390         * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker_unittest.py:
3391         (FuncitonTests.test_get__processes): Skip this test on Windows.
3392
3393 2011-03-01  Ilya Tikhonovsky  <loislo@chromium.org>
3394
3395         Reviewed by Pavel Feldman.
3396
3397         Web Inspector: reduce inspector tests flakiness.
3398         https://bugs.webkit.org/show_bug.cgi?id=55401
3399
3400         * DumpRenderTree/chromium/TestShell.cpp:
3401         (TestShell::runFileTest):
3402         * DumpRenderTree/chromium/WebPreferences.cpp:
3403         (WebPreferences::reset):
3404
3405 2011-02-28  Mihai Parparita  <mihaip@chromium.org>
3406
3407         Reviewed by James Robinson.
3408
3409         NRWT should still upload results when it exits early due to too many failures
3410         https://bugs.webkit.org/show_bug.cgi?id=55432
3411         
3412         Only keyboard interrupts should prevent results from being uploaded.
3413
3414         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
3415         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3416
3417 2011-02-28  Alice Liu  <alice.liu@apple.com>
3418
3419         Reviewed by Adam Roben and Gavin Barraclough.
3420
3421         Test for https://bugs.webkit.org/show_bug.cgi?id=54898
3422         InjectedBundleNodeHandle dies too early in WKBundleHitTestResultGetNodeHandle.
3423
3424         * TestWebKitAPI/InjectedBundleController.h:
3425         (TestWebKitAPI::InjectedBundleController::bundle):
3426         * TestWebKitAPI/PlatformWebView.h:
3427         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp: Added.
3428         (TestWebKitAPI::didFinishLoadForFrame):
3429         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
3430         (TestWebKitAPI::setPageLoaderClient):
3431         (TestWebKitAPI::TEST):
3432         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle_Bundle.cpp: Added.
3433         (TestWebKitAPI::HitTestResultNodeHandleTest::HitTestResultNodeHandleTest):
3434         (TestWebKitAPI::HitTestResultNodeHandleTest::getContextMenuFromDefaultMenu):
3435         (TestWebKitAPI::HitTestResultNodeHandleTest::didCreatePage):
3436         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
3437         (TestWebKitAPI::PlatformWebView::simulateRightClick):
3438         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
3439         (TestWebKitAPI::PlatformWebView::simulateRightClick):
3440         
3441         Added files to:
3442         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3443         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3444         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
3445
3446 2011-02-28  Adam Roben  <aroben@apple.com>
3447
3448         Start running InjectedBundle API tests on Windows
3449
3450         A new project, TestWebKitAPIInjectedBundle, builds the injected bundle DLL.
3451
3452         Fixes <http://webkit.org/b/55420> run-api-tests doesn't run injected bundle tests on Windows
3453
3454         Reviewed by Darin Adler.
3455
3456         * TestWebKitAPI/Configurations/TestWebKitAPIDebug.vsprops: Added.
3457         * TestWebKitAPI/Configurations/TestWebKitAPIDebugAll.vsprops: Added.
3458         * TestWebKitAPI/Configurations/TestWebKitAPIDebugCairoCFLite.vsprops: Added.
3459         * TestWebKitAPI/Configurations/TestWebKitAPIRelease.vsprops: Added.
3460         * TestWebKitAPI/Configurations/TestWebKitAPIReleaseCairoCFLite.vsprops: Added.
3461         These are just extracted from TestWebKitAPI.vcproj.
3462
3463         * TestWebKitAPI/Configurations/TestWebKitAPIInjectedBundleCommon.vsprops: Added. Just sets
3464         up the DLL's filename.
3465
3466         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp: Fixed DLL name.
3467         (TestWebKitAPI::Util::createInjectedBundlePath): Changed to use kCFAllocatorNull instead of
3468         0 (== kCFAllocatorDefault) so that CF won't try to deallocate our C string.
3469
3470         * TestWebKitAPI/win/TestWebKitAPI.sln: Added TestWebKitAPIInjectedBundle. Removed the bogus
3471         "all" configuration.
3472
3473         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Changed to use the new .vsprops files. Added
3474         injected bundle tests. Let VS resort things.
3475
3476         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj: Copied from Tools/TestWebKitAPI/win/TestWebKitAPI.vcproj.
3477
3478 2011-02-28  Adam Roben  <aroben@apple.com>
3479
3480         Add a test for the paint rect passed via WM_PAINT to windowless plugins
3481
3482         Test for <http://webkit.org/b/55365> <rdar://problem/9031089> REGRESSION (r79040): WebKit2:
3483         Large portions of pages with plugins paint black
3484
3485         Reviewed by Anders Carlsson.
3486
3487         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
3488         (PluginTest::NPP_HandleEvent):
3489         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
3490         Added NPP_HandleEvent. Just returns 0 at this level.
3491
3492         * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowlessPaintRectCoordinates.cpp: Added.
3493         (WindowlessPaintRectCoordinates::WindowlessPaintRectCoordinates): Call up to the base class.
3494         (WindowlessPaintRectCoordinates::NPP_New): Mark ourselves as windowless.
3495         (WindowlessPaintRectCoordinates::NPP_HandleEvent): Check that the paint rect passed via
3496         WM_PAINT has the expected coordinates.
3497
3498         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3499         (NPP_HandleEvent): Give the PluginTest a chance to handle the event before doing anything
3500         else.
3501
3502         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Added new file, let VS
3503         resort things.
3504
3505         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3506         (WTR::InjectedBundlePage::didFinishLoadForFrame): Added a call to WKBundlePageForceRepaint.
3507         This is roughly equivalent to the call to -[WebView displayIfNeeded] in -[FrameLoadDelegate
3508         webView:didFinishLoadForFrame:] in DumpRenderTree.
3509
3510         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3511         (WTR::PlatformWebView::PlatformWebView): Tell the WKView it's in a window so that plugins
3512         can start running.
3513
3514 2011-02-28  Adam Roben  <aroben@apple.com>
3515
3516         Tell MiniBrowser's WKViews that they're in a window
3517
3518         Fixes <http://webkit.org/b/55364> Plugins don't work in MiniBrowser on Windows
3519
3520         Reviewed by Anders Carlsson.
3521
3522         * MiniBrowser/win/BrowserView.cpp:
3523         (BrowserView::create): Call WKViewSetIsInWindow after creating the view.
3524
3525 2011-02-28  Alexis Menard  <alexis.menard@openbossa.org>
3526
3527         Reviewed by Csaba Osztrogonác.
3528
3529         The new QML tests require QML_IMPORT_PATH variable to be set in order to
3530         load the proper plugin.
3531
3532         * Scripts/run-qtwebkit-tests:
3533
3534 2011-02-28  Joone Hur  <joone.hur@collabora.co.uk>
3535
3536         Unreviewed, fix spelling mistake.
3537
3538         hardware-accelated => hardware-accelerated.
3539
3540         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3541
3542 2011-02-28  Kristian Amlie  <kristian.amlie@nokia.com>
3543
3544         Reviewed by Andreas Kling.
3545
3546         Made sure that the build-webkit --qmake argument is always respected.
3547
3548         Previously, it would be respected during the build, but not during
3549         the early feature detection. The build would also fail if qmake was
3550         not in your path, even if you specified --qmake with a valid qmake
3551         binary.
3552
3553         [Qt] WebKit patches required to work with a modularized version of Qt
3554         https://bugs.webkit.org/show_bug.cgi?id=53916
3555
3556         * Scripts/build-webkit:
3557         * Scripts/webkitdirs.pm:
3558
3559 2011-02-27  Ojan Vafai  <ojan@chromium.org>
3560
3561         Fix failing tests from http://trac.webkit.org/changeset/79837.
3562
3563         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
3564         This was just a mistake that would break if someone tried printing with this configuration.
3565         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
3566         Method signature changed. Didn't notice that this method was being calling in a unittest.
3567
3568 2011-02-24  Hayato Ito  <hayato@chromium.org>
3569
3570         Reviewed by Eric Seidel.
3571
3572         [NRWT] Remove test_types/* classes.
3573
3574         This is the last patch in the series of efforts which tried to remove test_types classes.
3575         A single_test_runner module will take over responsibilities of test_type classes.
3576
3577         From this patch, we won't display statistics per test_type even if a '--verbose' option is given.
3578
3579         https://bugs.webkit.org/show_bug.cgi?id=55123
3580
3581         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
3582         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
3583         * Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py:
3584         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
3585         * Scripts/webkitpy/layout_tests/layout_package/worker_mixin.py:
3586         * Scripts/webkitpy/layout_tests/test_types/__init__.py: Removed.
3587         * Scripts/webkitpy/layout_tests/test_types/image_diff.py: Removed.
3588         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py: Removed.
3589         * Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py: Removed.
3590         * Scripts/webkitpy/layout_tests/test_types/text_diff.py: Removed.
3591
3592 2011-02-25  Ojan Vafai  <ojan@chromium.org>
3593
3594         Reviewed by Tony Chang.
3595
3596         Change results.json format to the one used by unexpected_results.json
3597         https://bugs.webkit.org/show_bug.cgi?id=52267
3598
3599         Also add runtimes in milliseconds to the JSON and make the output format more compact.
3600         Named the file full_results.json to avoid conflicting with the results.json
3601         file the test-results server currently serves up.
3602
3603         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
3604         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3605         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
3606         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
3607         * Scripts/webkitpy/layout_tests/layout_package/result_summary.py:
3608         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
3609
3610 2011-02-27  Adam Roben  <aroben@apple.com>
3611
3612         Followup fix to r79827
3613
3614         * DumpRenderTree/win/UIDelegate.cpp:
3615         (UIDelegate::webViewAddMessageToConsole): Replaced call to urlSuitableForTestResult with
3616         lastPathComponent. This matches what we did here before r79827, and matches Mac.
3617
3618 2011-02-27  Dan Bernstein  <mitz@apple.com>
3619
3620         Reviewed by Adam Roben.
3621
3622         Make bisect-builds print a trac link for the regression range
3623         https://bugs.webkit.org/show_bug.cgi?id=55331
3624
3625         * Scripts/bisect-builds:
3626
3627 2011-02-27  Adam Roben  <aroben@apple.com>
3628
3629         Use iswalpha instead of isalpha when dealing with wchar_ts in EditingDelegate
3630
3631         Fixes <http://webkit.org/b/55062> <rdar://problem/9059907> Crash beneath
3632         EditingDelegate::checkSpellingOfString when running fast/forms/input-text-maxlength.html or
3633         fast/forms/input-text-paste-maxlength.html on Windows with full page heap enabled
3634
3635         Reviewed by Anders Carlsson.
3636
3637         * DumpRenderTree/win/EditingDelegate.cpp:
3638         (indexOfFirstWordCharacter):
3639         (wordLength):
3640         Use iswalpha instead of isalpha, since TCHAR is really just wchar_t.
3641
3642 2011-02-27  Adam Roben  <aroben@apple.com>
3643
3644         Make ResourceLoadDelegate print URLs relative to the main resource on Windows
3645
3646         This matches Mac. (In fact, the code was ported from Mac!)
3647
3648         Fixes <http://webkit.org/b/55328> URLs printed by ResourceLoadDelegate on Windows don't
3649         match Mac
3650
3651         Reviewed by Anders Carlsson.
3652
3653         * DumpRenderTree/win/DumpRenderTree.cpp:
3654         (substringFromIndex): Added. Emulates -[NSString substringFromIndex:].
3655         (urlSuitableForTestResult): Ported code from -[NSURL(DRTExtras)
3656         _drt_descriptionSuitableForTestResult].
3657         (cfStringRefToWString): Moved here from LayoutTestControllerWin.cpp.
3658
3659         * DumpRenderTree/win/DumpRenderTreeWin.h: Added declaration of cfStringRefToWString.
3660
3661         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Moved cfStringRefToWString to
3662         DumpRenderTree.cpp.
3663
3664 2011-02-27  Adam Roben  <aroben@apple.com>
3665
3666         Change the order of Chang Shu's email addresses so the first one is their Bugzilla username
3667
3668         This makes Bugzilla autocompletion work correctly.
3669
3670         * Scripts/webkitpy/common/config/committers.py:
3671
3672 2011-02-27  Patrick Gansterer  <paroga@webkit.org>
3673
3674         Reviewed by Andreas Kling.
3675
3676         [Qt] fast/loader/user-stylesheet-fast-path.html fails
3677         https://bugs.webkit.org/show_bug.cgi?id=50911
3678
3679         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3680         (LayoutTestController::setUserStyleSheetLocation):
3681         Use QUrl::fromEncoded since the passed string is already encoded.
3682
3683 2011-02-27  Adam Roben  <aroben@apple.com>
3684
3685         Ensure $testResultsDirectory is an absolute path before setting up Windows crash log saving
3686
3687         Windows 7 (and maybe Vista?) launches the post-mortem debugger with a working directory that
3688         is different from old-run-webkit-test's. Because of this, the path to the crash log file
3689         (which is relative to $testResultsDirectory) must be an absolute path. See the bug for more
3690         details.
3691
3692         Fixes <http://webkit.org/b/55318> Crash logs aren't saved on Windows 7 when a relative
3693         --results-directory path is used (like on the test slaves)
3694
3695         Reviewed by Dan Bernstein.
3696
3697         * Scripts/old-run-webkit-tests: Moved the call to setUpWindowsCrashLogSaving after we've
3698         made $testResultsDirectory an absolute path.
3699
3700 2011-02-26  Dominic Mazzoni  <dmazzoni@google.com>
3701
3702         Reviewed by Adam Barth.
3703
3704         m_dumpAccessibilityNotifications should be initialized.
3705         https://bugs.webkit.org/show_bug.cgi?id=54874
3706
3707         * DumpRenderTree/chromium/AccessibilityController.cpp:
3708         (AccessibilityController::AccessibilityController):
3709
3710 2011-02-26  Vsevolod Vlasov  <vsevik@chromium.org>
3711
3712         Reviewed by Pavel Feldman.
3713
3714         DumpRenderTree should reset frame opener between tests.
3715         https://bugs.webkit.org/show_bug.cgi?id=54874
3716
3717         Added clearOpener() calls between tests.
3718         Some tests are using window.open() to change current window location.
3719         This changes window.opener property whose nullity is checked before
3720         showing xml viewer.
3721
3722         * DumpRenderTree/chromium/TestShell.cpp:
3723         (TestShell::resetTestController):
3724         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3725         (resetDefaultsToConsistentValues):
3726         * DumpRenderTree/mac/DumpRenderTree.mm:
3727         (resetWebViewToConsistentStateBeforeTesting):
3728         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3729         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
3730         * DumpRenderTree/win/DumpRenderTree.cpp:
3731         (resetWebViewToConsistentStateBeforeTesting):
3732         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3733         (WTR::InjectedBundlePage::reset):
3734
3735 2011-02-26  Yael Aharon  <yael.aharon@nokia.com>
3736
3737         Reviewed by Andreas Kling.
3738
3739         [Qt] Fix the focus in MiniBrowser.
3740         https://bugs.webkit.org/show_bug.cgi?id=55288
3741
3742         Give focus to the web view when a load starts.
3743
3744         * MiniBrowser/qt/BrowserWindow.cpp:
3745         (BrowserWindow::urlChanged):
3746
3747 2011-02-26  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3748
3749         Reviewed by Adam Barth.
3750
3751         [EFL] Add coding style exceptions for EFL port
3752         https://bugs.webkit.org/show_bug.cgi?id=54733
3753
3754         The EFL APIs use EFL naming style, which includes both lower-cased and camel-cased,
3755         underscore-sparated values. But, style checking rule have found parameter_name errors
3756         in efl directories so far.
3757
3758         * Scripts/webkitpy/style/checker.py: Add prameter_name rule's exception and efl directories.
3759
3760 2011-02-26  David Levin  <levin@chromium.org>
3761
3762         Reviewed by Darin Adler.
3763
3764         check-webkit-style should check for spaces after periods in comments
3765         https://bugs.webkit.org/show_bug.cgi?id=55253
3766
3767         * Scripts/webkitpy/style/checkers/cpp.py: Added the check.
3768         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests
3769           and fixed the name of one related test.
3770
3771 2011-02-26  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3772
3773         Reviewed by Andreas Kling.
3774
3775         Make it possible to test the targetdensity-dpi support
3776         https://bugs.webkit.org/show_bug.cgi?id=55142
3777
3778         Test the viewport meta tag feature targetdensity-dpi by
3779         adding extra arguments to dumpConfigurationForViewport
3780
3781         Add the new arguments to the shared header and all
3782         implementation.
3783
3784         * DumpRenderTree/LayoutTestController.cpp:
3785         (dumpConfigurationForViewportCallback):
3786         * DumpRenderTree/LayoutTestController.h:
3787         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3788         (LayoutTestController::dumpConfigurationForViewport):
3789         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3790         (LayoutTestController::dumpConfigurationForViewport):
3791         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3792         (LayoutTestController::dumpConfigurationForViewport):
3793         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3794         (LayoutTestController::dumpConfigurationForViewport):
3795         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3796         (LayoutTestController::dumpConfigurationForViewport):
3797         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3798
3799 2011-02-26  Sheriff Bot  <webkit.review.bot@gmail.com>
3800
3801         Unreviewed, rolling out r79764.
3802         http://trac.webkit.org/changeset/79764
3803         https://bugs.webkit.org/show_bug.cgi?id=55295
3804
3805         "broke Chromium builds" (Requested by rniwa on #webkit).
3806
3807         * DumpRenderTree/chromium/TestShell.cpp:
3808         (TestShell::resetTestController):
3809         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3810         (resetDefaultsToConsistentValues):
3811         * DumpRenderTree/mac/DumpRenderTree.mm:
3812         (resetWebViewToConsistentStateBeforeTesting):
3813         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3814         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
3815         * DumpRenderTree/win/DumpRenderTree.cpp:
3816         (resetWebViewToConsistentStateBeforeTesting):
3817         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3818         (WTR::InjectedBundlePage::reset):
3819
3820 2011-02-26  Yongjun Zhang  <yongjun_zhang@apple.com>
3821
3822         Reviewed by David Kilzer.
3823
3824         https://bugs.webkit.org/show_bug.cgi?id=48781
3825
3826         Add a resource load delegate method to query if WebCore should paint the default broken image for failed images.
3827
3828         Add a new resource load client method (shouldPaintBrokenImage).  WebKit client can decide if WebCore
3829         should paint the default broken image when an image fails to load or decode.
3830
3831         * DumpRenderTree/LayoutTestController.cpp:
3832         (LayoutTestController::LayoutTestController):
3833         (setShouldPaintBrokenImageCallback):
3834         (LayoutTestController::staticFunctions):
3835         (LayoutTestController::setShouldPaintBrokenImage):
3836         * DumpRenderTree/LayoutTestController.h:
3837         (LayoutTestController::shouldPaintBrokenImage):
3838         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
3839         (-[ResourceLoadDelegate webView:shouldPaintBrokenImageForURL:]):
3840
3841 2011-02-26  Vsevolod Vlasov  <vsevik@chromium.org>
3842
3843         Reviewed by Pavel Feldman.
3844
3845         DumpRenderTree should reset frame opener between tests.
3846         https://bugs.webkit.org/show_bug.cgi?id=54874
3847
3848         Added clearOpener() calls between tests.
3849         Some tests are using window.open() to change current window location.
3850         This changes window.opener property whose nullity is checked before
3851         showing xml viewer.
3852
3853         * DumpRenderTree/chromium/TestShell.cpp:
3854         (TestShell::resetTestController):
3855         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3856         (resetDefaultsToConsistentValues):
3857         * DumpRenderTree/mac/DumpRenderTree.mm:
3858         (resetWebViewToConsistentStateBeforeTesting):
3859         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3860         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
3861         * DumpRenderTree/win/DumpRenderTree.cpp:
3862         (resetWebViewToConsistentStateBeforeTesting):
3863         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3864         (WTR::InjectedBundlePage::reset):
3865
3866 2011-02-25  Lukasz Slachciak  <l.slachciak@samsung.com>
3867
3868         Reviewed by Kenneth Rohde Christiansen.
3869
3870         [EFL] Added EWebLauncher command line option to turn on/off frame flattening
3871         https://bugs.webkit.org/show_bug.cgi?id=54809
3872
3873         * EWebLauncher/main.c: Handling -f option added.
3874         (on_key_down):
3875         (browserCreate):
3876         (main):
3877
3878 2011-02-25  Sheriff Bot  <webkit.review.bot@gmail.com>
3879
3880         Unreviewed, rolling out r79324.
3881         http://trac.webkit.org/changeset/79324
3882         https://bugs.webkit.org/show_bug.cgi?id=55260
3883
3884         Leopard Debug is once again running out of address space while
3885         linking (Requested by aroben on #webkit).
3886
3887         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
3888         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3889
3890 2011-02-25  Tony Chang  <tony@chromium.org>
3891
3892         Reviewed by James Robinson.
3893
3894         Clean up temp files left by crashing DRTs on chromium-win
3895         https://bugs.webkit.org/show_bug.cgi?id=55182
3896
3897         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3898         * BuildSlaveSupport/chromium/remove-crash-logs: Added.
3899
3900 2011-02-25  Adam Roben  <aroben@apple.com>
3901
3902         Double-check that modifying the registry worked
3903
3904         On Windows Vista/7 with UAC enabled, regtool will fail to modify the registry, but it will
3905         still return a successful exit code. So we double-check here that the value we tried to
3906         write to the registry was really written.
3907
3908         Fixes <http://webkit.org/b/55227> old-run-webkit-tests falsely claims to be saving crash
3909         logs on Windows Vista/7
3910
3911         Reviewed by Darin Adler.
3912
3913         * Scripts/old-run-webkit-tests:
3914         (writeRegistryString): After trying to write the string value, check that it was really
3915         written.
3916
3917 2011-02-25  Adam Roben  <aroben@apple.com>
3918
3919         Set the 32-bit post-mortem debugger on 64-bit OSes
3920
3921         The post-mortem debugger is controlled by some registry values in
3922         HKLM\SOFTWARE\Microsoft\Windows NT\CurrentVersion\AeDebug. On 64-bit OSes, you can either
3923         set the values in that key, which will be used for 64-bit apps, or in the equivalent key
3924         under Wow6432Node, which will be used for 32-bit apps. Since DumpRenderTree and
3925         WebKitTestRunner are 32-bit, we want to use the latter location.
3926
3927         Fixes <http://webkit.org/b/55225> old-run-webkit-tests sets the post-mortem debugger for
3928         64-bit apps, but should set it for 32-bit apps instead
3929
3930         Reviewed by Darin Adler.
3931
3932         * Scripts/old-run-webkit-tests:
3933         (readRegistryString):
3934         (writeRegistryString):
3935         Pass --wow32 to regtool so it will get/set values beneath Wow6432Node, which is where
3936         Windows looks for the post-mortem debugger values when a 32-bit app crashes on a 64-bit OS.
3937         Passing --wow32 on a 32-bit OS will not have any effect.
3938
3939 2011-02-25  Adam Roben  <aroben@apple.com>
3940
3941         Clean up code to set up crash log saving on Windows
3942
3943         Fixes <http://webkit.org/b/55224> old-run-webkit-test's Windows registry code is ugly
3944
3945         Reviewed by David Kilzer.
3946
3947         * Scripts/old-run-webkit-tests:
3948         (readRegistryString):
3949         (writeRegistryString):
3950         Moved code to read strings from and write strings to the registry here...
3951
3952         (setUpWindowsCrashLogSaving): ...from here.
3953
3954 2011-02-25  Adam Roben  <aroben@apple.com>
3955
3956         Work around Cygwin's crash-suppression behavior
3957
3958         Cygwin calls ::SetErrorMode(SEM_FAILCRITICALERRORS), which any processes it launches will
3959         inherit. This is bad for testing/debugging, as it causes the post-mortem debugger not to be
3960         invoked. (Cygwin does this because it makes crashes more UNIX-y.) We reset the error mode
3961         when our test apps launch to work around Cygwin's behavior.
3962
3963         Fixes <http://webkit.org/b/55222> Test apps crash silently (without invoking post-mortem
3964         debugger) when launched from Cygwin 1.7
3965
3966         Reviewed by Darin Adler.
3967
3968         * DumpRenderTree/win/DumpRenderTree.cpp:
3969         (main):
3970         * TestWebKitAPI/win/main.cpp:
3971         (main):
3972         * WebKitAPITest/main.cpp:
3973         (main):
3974         * WebKitTestRunner/win/TestControllerWin.cpp:
3975         (WTR::TestController::platformInitialize):
3976         Call ::SetErrorMode(0) to undo Cygwin's folly.
3977
3978 2011-02-24  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
3979
3980         Reviewed by Andreas Kling.
3981
3982         [Qt] Revert the support for QNAM affined to a different thread.
3983         https://bugs.webkit.org/show_bug.cgi?id=55149
3984
3985         Qt 4.8 will have QNAM use its own thread internally by default,
3986         no need to keep this complexity in WebKit.
3987
3988         This mainly reverts:
3989         http://trac.webkit.org/changeset/73710
3990         http://trac.webkit.org/changeset/73712
3991
3992         * QtTestBrowser/launcherwindow.cpp:
3993         (LauncherWindow::~LauncherWindow):
3994         (LauncherWindow::initializeView):
3995         (LauncherWindow::createChrome):
3996         * QtTestBrowser/launcherwindow.h:
3997         (WindowOptions::WindowOptions):
3998         * QtTestBrowser/webpage.cpp:
3999         (WebPage::WebPage):
4000         * QtTestBrowser/webpage.h:
4001
4002 2011-02-24  Adam Barth  <abarth@webkit.org>
4003
4004         Reviewed by Eric Seidel.
4005
4006         Add a script for creating gypi files
4007         https://bugs.webkit.org/show_bug.cgi?id=55113
4008
4009         This is a trivial script to create gypi files from the source code in
4010         the current directory.
4011
4012         * Scripts/make-gypi: Added.
4013
4014 2011-02-24  Sheriff Bot  <webkit.review.bot@gmail.com>
4015
4016         Unreviewed, rolling out r79628.
4017         http://trac.webkit.org/changeset/79628
4018         https://bugs.webkit.org/show_bug.cgi?id=55195
4019
4020         "broke chromium win tests" (Requested by dpranke on #webkit).
4021
4022         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
4023         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
4024
4025 2011-02-24  Dirk Pranke  <dpranke@chromium.org>
4026
4027         Reviewed by Mihai Parparita.
4028
4029         rebaseline-chromium-webkit-tests can't handle GPU variants
4030         https://bugs.webkit.org/show_bug.cgi?id=55002
4031
4032         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
4033         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
4034
4035 2011-02-24  Dirk Pranke  <dpranke@chromium.org>
4036
4037         Reviewed by Mihai Parparita.
4038
4039         nrwt: log command used to start web server to --verbose
4040
4041         https://bugs.webkit.org/show_bug.cgi?id=55188
4042
4043         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
4044         * Scripts/webkitpy/layout_tests/port/http_server.py:
4045
4046 2011-02-24  Victoria Kirst  <vrk@google.com>
4047
4048         Reviewed by Mihai Parparita.
4049
4050         [chromium] Move media-file.js and video-test.js back to media/ for UILayoutTests
4051         https://bugs.webkit.org/show_bug.cgi?id=55089
4052
4053         This adds an alias into the media/ directory so that http/tests/media
4054         tests can access the media resources when running in an httpd process.
4055
4056         * Scripts/webkitperl/httpd.pm:
4057         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
4058         * Scripts/webkitpy/layout_tests/port/http_server.py:
4059
4060 2011-02-24  Dirk Pranke  <dpranke@chromium.org>
4061
4062         Reviewed by Mihai Parparita.
4063
4064         nrwt: enable multiple processes by default on Chromium Win.
4065
4066         https://bugs.webkit.org/show_bug.cgi?id=55163
4067
4068         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
4069         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
4070
4071 2011-02-24  Sam Weinig  <sam@webkit.org>
4072
4073         Attempt to fix Qt.
4074
4075         * WebKitTestRunner/TestInvocation.cpp:
4076
4077 2011-02-24  James Robinson  <jamesr@chromium.org>
4078
4079         Unreviewed, rolling out r79598.
4080         http://trac.webkit.org/changeset/79598
4081         https://bugs.webkit.org/show_bug.cgi?id=55089
4082
4083         Appears to be causing trouble with httpd on windows
4084
4085         * Scripts/webkitperl/httpd.pm:
4086         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
4087         * Scripts/webkitpy/layout_tests/port/http_server.py:
4088
4089 2011-02-24  Sam Weinig  <sam@webkit.org>
4090
4091         Reviewed by Darin Adler.
4092
4093         Add basic pixel testing support to WebKitTestRunner
4094         https://bugs.webkit.org/show_bug.cgi?id=55161
4095
4096         * Scripts/old-run-webkit-tests:
4097         Don't print color space information when using WebKitTestRunner since
4098         we don't need to change the screen.
4099
4100         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
4101         (WTR::InjectedBundle::initialize):
4102         Add call to initializePlatformDefaults.
4103         
4104         (WTR::InjectedBundle::done):
4105         Return a dictionary on completion with both the text output and pixel dump override.
4106
4107         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
4108         Add declaration for initializePlatformDefaults.
4109
4110         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
4111         (WTR::LayoutTestController::LayoutTestController):
4112         (WTR::LayoutTestController::dumpAsText):
4113         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
4114         (WTR::LayoutTestController::shouldDumpPixels):
4115         Make setting dumpAsText override the dump pixels preference.
4116
4117         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm: Added.
4118         (WTR::InjectedBundle::initializePlatformDefaults):
4119         Set platform defaults matching DumpRenderTree.
4120
4121         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp: Added.
4122         (WTR::InjectedBundle::initializePlatformDefaults):
4123         * WebKitTestRunner/InjectedBundle/win/InjectedBundleWin.cpp: Added.
4124         (WTR::InjectedBundle::initializePlatformDefaults):
4125         Add stubs for initializePlatformDefaults.
4126
4127         * WebKitTestRunner/TestController.cpp:
4128         (WTR::TestController::runTest):
4129         (WTR::TestController::runTestingServerLoop):
4130         (WTR::TestController::run):
4131         Parse expected pixel results out of stdin and setup the invocation with it.
4132
4133         * WebKitTestRunner/TestInvocation.cpp:
4134         (WTR::TestInvocation::TestInvocation):
4135         Initialize new members.
4136
4137         (WTR::TestInvocation::~TestInvocation):
4138         (WTR::TestInvocation::setIsPixelTest):
4139         (WTR::sizeWebViewForCurrentTest):
4140         (WTR::TestInvocation::invoke):
4141         (WTR::TestInvocation::dump):
4142         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
4143         * WebKitTestRunner/TestInvocation.h:
4144         Dump pixels in addition to text by calling dumpPixelsAndCompareWithExpected.
4145
4146         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
4147         (WTR::PlatformWebView::PlatformWebView):
4148         Use -[NSColorSpace genericRGBColorSpace] instead of the main screen color space.
4149
4150         * WebKitTestRunner/mac/TestInvocationMac.mm: Added.
4151         (WTR::createCGContextFromPlatformView):
4152         (WTR::computeMD5HashStringForContext):
4153         (WTR::dumpBitmap):
4154         (WTR::forceRepaintFunction):
4155         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
4156         Add mac specific pixel dumping support. Right now, we always pull pixels
4157         from the window server.
4158
4159         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
4160         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
4161         * WebKitTestRunner/qt/WebKitTestRunner.pro:
4162         * WebKitTestRunner/win/InjectedBundle.vcproj:
4163         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
4164         Add new files.
4165
4166 2011-02-24  Chang Shu  <cshu@webkit.org>
4167
4168         Reviewed by Kenneth Rohde Christiansen.
4169
4170         [Qt] Launch MiniBrowser if the test run is WebKit2. 
4171         https://bugs.webkit.org/show_bug.cgi?id=55145
4172
4173         * Scripts/old-run-webkit-tests:
4174         * Scripts/run-launcher:
4175         * Scripts/webkitdirs.pm:
4176
4177 2011-02-24  Victoria Kirst  <vrk@google.com>
4178
4179         Reviewed by Mihai Parparita.
4180
4181         [chromium] Move media-file.js and video-test.js back to media/ for UILayoutTests
4182         https://bugs.webkit.org/show_bug.cgi?id=55089
4183
4184         This adds an alias into the media/ directory so that http/tests/media
4185         tests can access the media resources when running in an httpd process.
4186
4187         * Scripts/webkitperl/httpd.pm:
4188         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
4189         * Scripts/webkitpy/layout_tests/port/http_server.py:
4190
4191 2011-02-24  Andrew Wilson  <atwilson@chromium.org>
4192
4193         Unreviewed, rolling out r79570.
4194         http://trac.webkit.org/changeset/79570
4195         https://bugs.webkit.org/show_bug.cgi?id=54874
4196
4197         Breaks chromium build because glue/mocks/mock_web_frame.h/cc
4198         was not updated
4199
4200         * DumpRenderTree/chromium/TestShell.cpp:
4201         (TestShell::resetTestController):
4202         * DumpRenderTree/gtk/DumpRenderTree.cpp:
4203         (resetDefaultsToConsistentValues):
4204         * DumpRenderTree/mac/DumpRenderTree.mm:
4205         (resetWebViewToConsistentStateBeforeTesting):
4206         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
4207         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
4208         * DumpRenderTree/win/DumpRenderTree.cpp:
4209         (resetWebViewToConsistentStateBeforeTesting):
4210         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
4211         (WTR::InjectedBundlePage::reset):
4212
4213 2011-02-24  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
4214
4215         Reviewed by Laszlo Gombos.
4216
4217         [Qt] add android 2.2 user agent to QtTestBrowser
4218         https://bugs.webkit.org/show_bug.cgi?id=55085
4219
4220         Credit to Forrest Hodgkins to find right user-agent which works for youtube.
4221         * QtTestBrowser/useragentlist.txt:
4222
4223 2011-02-24  Adam Roben  <aroben@apple.com>
4224
4225         Change FrameLoadDelegate to support any number of delegates with delayed work to process
4226
4227         This makes our behavior match Mac more closely, and allows us to remove an incorrect
4228         assertion that was firing during some tests. (The assertion was claiming that there was
4229         never more than one delegate with delayed work to process, but that was not the case.)
4230
4231         Fixes <http://webkit.org/b/55146> Assertion failure in FrameLoadDelegate::locationChangeDone
4232         when running http/tests/navigation/back-twice-without-commit.html
4233
4234         Reviewed by Eric Carlson.
4235
4236         * DumpRenderTree/win/FrameLoadDelegate.cpp:
4237         (delegatesWithDelayedWork): Added. Returns all FrameLoadDelegates that have delayed work to
4238         process. A single delegate may appear in this Vector more than once (just as, on Mac, a
4239         single delegate may have multiple performSelector requests).
4240         (processWorkTimer): Pass the HWND to ::KillTimer, for pedantic brownie points. Added an
4241         assertion that the timer firing is the shared process work timer. Instead of using the
4242         single, global "delegate waiting for timer" delegate, give all delegates that have delayed
4243         work to process a chance to process their work.
4244         (FrameLoadDelegate::locationChangeDone): If we don't already have an active timer for
4245         processing delayed work, create one. Then add ourselves to the delegatesWithDelayedWork
4246         Vector so our processWork function will be called when the timer fires.
4247
4248 2011-02-24  Vsevolod Vlasov  <vsevik@chromium.org>
4249
4250         Reviewed by Alexey Proskuryakov.
4251
4252         DumpRenderTree should reset frame opener between tests.
4253         https://bugs.webkit.org/show_bug.cgi?id=54874
4254
4255         Added clearOpener() calls between tests.
4256         Some tests are using window.open() to change current window location.
4257         This changes window.opener property whose nullity is checked before
4258         showing xml viewer.
4259
4260         * DumpRenderTree/chromium/TestShell.cpp:
4261         (TestShell::resetTestController):
4262         * DumpRenderTree/gtk/DumpRenderTree.cpp:
4263         (resetDefaultsToConsistentValues):
4264         * DumpRenderTree/mac/DumpRenderTree.mm:
4265         (resetWebViewToConsistentStateBeforeTesting):
4266         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
4267         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
4268         * DumpRenderTree/win/DumpRenderTree.cpp:
4269         (resetWebViewToConsistentStateBeforeTesting):
4270         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
4271         (WTR::InjectedBundlePage::reset):
4272
4273 2011-02-24  Adam Roben  <aroben@apple.com>
4274
4275         Don't trigger Windows builds for changes to WebCore.exp.in or the top-level GNUmakefile.am
4276
4277         Fixes <http://webkit.org/b/55144> Windows builders should not have built r79343 or r79440,
4278         but did
4279
4280         Reviewed by Anders Carlsson.
4281
4282         * Scripts/webkitpy/common/config/build.py:
4283         (_should_file_trigger_build): Loosened the pattern for GNUmakefile.am to include the
4284         top-level GNUmakefile.am, and loosened the pattern for .exp files to include WebCore.exp.in.
4285
4286         * Scripts/webkitpy/common/config/build_unittest.py:
4287         (ShouldBuildTest): Added some more tests.
4288
4289 2011-02-24  Andras Becsi  <abecsi@webkit.org>
4290
4291         Reviewed by Laszlo Gombos.
4292
4293         [Qt] MinGW build fails to link
4294         https://bugs.webkit.org/show_bug.cgi?id=55050
4295
4296         Prepend the libraries of subcomponents instead of appending them
4297         to fix the library order according to the dependency of the libraries
4298
4299         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
4300         * WebKitTestRunner/qt/WebKitTestRunner.pro:
4301
4302 2011-02-24  Gabor Loki  <loki@webkit.org>
4303
4304         Reviewed by Csaba Osztrogonác.
4305
4306         [Qt] Remove ARMv5 Release buildbot.
4307
4308         Remove ARMv5 Release buildbot, because there is very little difference
4309         between ARMv5 and ARMv7 Release bots, and there is also very little
4310         interest in ARMv5 build slave (compared to ARMv7).
4311
4312         * BuildSlaveSupport/build.webkit.org-config/config.json:
4313         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
4314
4315 2011-02-22  Ojan Vafai  <ojan@chromium.org>
4316
4317         Reviewed by Tony Chang.
4318
4319         fix revision number finding when creating git patches
4320         https://bugs.webkit.org/show_bug.cgi?id=55024
4321
4322         HEAD~n does not walk merge commits correctly. git log however does.
4323
4324         * Scripts/webkitpy/common/checkout/scm.py:
4325         * Scripts/webkitpy/common/checkout/scm_unittest.py:
4326
4327 2011-02-23  Kenneth Russell  <kbr@google.com>
4328
4329         Unreviewed, rolling out r79387.
4330         https://bugs.webkit.org/show_bug.cgi?id=54885
4331
4332         Reapply the code changes from r79038 since they weren't the root
4333         cause of the test timeouts.
4334
4335         * DumpRenderTree/chromium/WebViewHost.cpp:
4336         (WebViewHost::reset):
4337
4338 2011-02-23  Siddharth Mathur  <siddharth.mathur@nokia.com>
4339
4340         Reviewed by Laszlo Gombos.
4341
4342         [Qt] Make sure Symbian binary UIDs are unique
4343
4344         * MiniBrowser/qt/MiniBrowser.pro: Resolve the UID collision with
4345         QtTestBrowser.pro by changing the UID.
4346
4347 2011-02-23  Patrick Gansterer  <paroga@webkit.org>
4348
4349         Reviewed by Darin Adler.
4350
4351         Rename PLATFORM(CF) to USE(CF)
4352         https://bugs.webkit.org/show_bug.cgi?id=53540
4353
4354         * DumpRenderTree/config.h:
4355
4356 2011-02-23  Dirk Pranke  <dpranke@chromium.org>
4357
4358         Reviewed by Ojan Vafai.
4359
4360         nrwt: turn on multiprocessing on chromium_linux, clean up unit tests for worker model defaults
4361         https://bugs.webkit.org/show_bug.cgi?id=55016
4362
4363         * Scripts/webkitpy/layout_tests/port/base.py:
4364         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
4365         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py: Added.
4366         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
4367         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
4368         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
4369         * Scripts/webkitpy/layout_tests/port/mac.py:
4370         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
4371         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
4372         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
4373
4374 2011-02-23  Tony Chang  <tony@chromium.org>
4375
4376         Reviewed by Kent Tamura.
4377
4378         [chromium] DumpRenderTree --check-layout-test-sys-deps leaks 4 temp dirs
4379         https://bugs.webkit.org/show_bug.cgi?id=55004
4380
4381         * DumpRenderTree/chromium/DumpRenderTree.cpp:
4382         (WebKitSupportTestEnvironment::WebKitSupportTestEnvironment):
4383         (WebKitSupportTestEnvironment::~WebKitSupportTestEnvironment):
4384         (main): Use a C++ object to ensure that TearDownTestEnvironment
4385             gets called when --check-layout-test-sys-deps is called
4386
4387 2011-02-23  Gopal Raghavan  <gopal.1.raghavan@nokia.com>
4388
4389         Reviewed by Anders Carlsson.
4390
4391         [Qt] [Qt] check webkit style fails in qt/tests
4392         https://bugs.webkit.org/show_bug.cgi?id=54998
4393
4394         check-webkit-style was complaining about missing config.h in WebKit/qt/test/qdeclarativewebview. This patch was originally part of 50222. Reviewer suggested to split and create a separate patch for checker.
4395
4396         * Scripts/webkitpy/style/checker.py:
4397
4398 2011-02-22  Vsevolod Vlasov  <vsevik@chromium.org>
4399
4400         Reviewed by Pavel Feldman.
4401
4402         DumpRenderTree should dump as text if test path contains "dumpAsText/"
4403         https://bugs.webkit.org/show_bug.cgi?id=54873
4404
4405         * DumpRenderTree/chromium/LayoutTestController.h:
4406         (LayoutTestController::setShouldDumpAsText):
4407         (LayoutTestController::setShouldGeneratePixelResults):
4408         * DumpRenderTree/chromium/TestShell.cpp:
4409         (TestShell::runFileTest):
4410         * DumpRenderTree/gtk/DumpRenderTree.cpp:
4411         (shouldDumpAsText):
4412         (dump):
4413         (runTest):
4414         * DumpRenderTree/mac/DumpRenderTree.mm:
4415         (shouldDumpAsText):
4416         (runTest):
4417         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
4418         (WebCore::isDumpAsTextTest):
4419         (WebCore::DumpRenderTree::open):
4420         * DumpRenderTree/win/DumpRenderTree.cpp:
4421 &n