2010-12-22 Dirk Pranke <dpranke@chromium.org>
[WebKit.git] / Tools / ChangeLog
1 2010-12-22  Dirk Pranke  <dpranke@chromium.org>
2
3         Reviewed by Ojan Vafai.
4
5         This change splits out the TestRunner class into its own file.
6         When we fork the code for message passing, we will create a new
7         TestRunner, and this change will allow that to be more modular.
8
9         While we're at it, split out TestInput and ResultSummary into
10         their own files, to reduce the size of run_webkit_tests to
11         something more managable.
12
13         https://bugs.webkit.org/show_bug.cgi?id=51092
14
15         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
16         * Scripts/webkitpy/layout_tests/layout_package/result_summary.py:
17         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
18         * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
19         * Scripts/webkitpy/layout_tests/layout_package/test_input.py:
20         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
21         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
22
23  2010-12-22  Dirk Pranke  <dpranke@chromium.org>
24
25         Reviewed by Ojan Vafai.
26
27         nrwt multiprocessing - start over, prepare to fork the code
28  
29         This code cleans up the signatures and implementation of the
30         TestRunner class so we can easily fork it to run either the
31         stable implementation or the new, unstable message-passing
32         implementation. The two variants will have different
33         implementations of the run_tests() method. We will switch
34         between the two based on the setting for the '--worker-model'
35         switch. We rename the two currently valid values to 'old-inline'
36         and 'old-threads'.
37
38         https://bugs.webkit.org/show_bug.cgi?id=51081
39
40         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
41         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
42
43 2010-12-22  Victor Wang  <victorw@chromium.org>
44
45         Reviewed by Darin Fisher.
46
47         [Chromium] Update chromium archive test result url in rebaseline script.
48
49         https://bugs.webkit.org/show_bug.cgi?id=51503
50
51         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
52
53 2010-12-22  Lucas Forschler  <lforschler@apple.com>
54
55         Reviewed by Alice Liu.
56
57         <rdar://problem/8633222> record-memory-win needs to record memory used by the webprocess.
58         Verified on Chrome, Safari, and IE.
59         With this change, we will record memory from a parent browser window and all child processes.
60
61         * record-memory-win/main.cpp:
62         (ProcessArgs):
63         (PrintUsage):
64         (getMemoryInfo):
65         (printProcessInfo):
66         (evalProcesses):
67         (UseImage):
68         (QueryContinuously):
69         (ElapsedTime):
70
71 2010-12-22  Lucas Forschler  <lforschler@apple.com>
72
73         Unreviewed rollout r74489, because it was missing changelog.
74
75         * record-memory-win/main.cpp:
76         
77 2010-12-22  Ryosuke Niwa  <rniwa@webkit.org>
78
79         Adding myself as a reviewer.
80
81         * Scripts/webkitpy/common/config/committers.py:
82
83 2010-12-22  Andrew Scherkus  <scherkus@chromium.org>
84
85         Unreviewed.  Adding myself to committers.py.
86
87         * Scripts/webkitpy/common/config/committers.py:
88
89 2010-12-22  Ariya Hidayat  <ariya@sencha.com>
90
91         Reviewed by Kenneth Rohde Christiansen.
92
93         TestNetscapePlugIn should use #if defined
94         https://bugs.webkit.org/show_bug.cgi?id=51471
95
96         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
97         (NP_Initialize):
98         (NPP_New):
99
100 2010-12-22  Ilya Tikhonovsky  <loislo@chromium.org>
101
102         Reviewed by Yury Semikhatsky.
103
104         Web Inspector: [chromium] DRT inspector layout tests are flaky in debug.
105
106         DevTools window should be closed explicitly because it has custom deinitialization code.
107
108         https://bugs.webkit.org/show_bug.cgi?id=50722
109
110         * DumpRenderTree/chromium/TestShell.cpp:
111         (TestShell::closeRemainingWindows):
112
113 2010-12-22  David Levin  <levin@chromium.org>
114
115         Reviewed by Shinichiro Hamaji.
116
117         check-webkit-style shouldn't complaint about underscores in variables in objective C files.
118         https://bugs.webkit.org/show_bug.cgi?id=51452
119
120         * Scripts/webkitpy/style/checkers/cpp.py:
121         (_FileState.__init__): Added the information to determine if a file is C or Objective C.
122         Using the file extension if possible but falling back to the file contents if we have a header file.
123         (_FileState.is_objective_c): Determine if we have an Objective C by examining the file contents if needed.
124         (_FileState.is_c_or_objective_c):
125         (check_using_std): Changed to using _FileState to determine the file type.
126         (check_max_min_macros): Ditto.
127         (check_for_null): Ditto.
128         (check_style): Changed the parameters to various calls since they now need _FileState
129         to determine the file type.
130         (check_language): Added the file_state parameter so it could be passed
131         to check_identifier_name_in_declaration.
132         (check_identifier_name_in_declaration): Don't warn about underscores in variables if
133         this is an Objective C file.
134         (_process_lines): Added information for the _FileState constructor (and moved the
135         call to a place that had the information).
136         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
137         (CppFunctionsTest.test_is_c_or_objective_c): Changed the tests to use FileState and exercise
138         its functionality.
139         (WebKitStyleTest.test_names): Add tests for underscores in Objective C files.
140
141 2010-12-21  Andy Estes  <aestes@apple.com>
142
143         Reviewed by Mark Rowe.
144
145         Do not build non-Intel architectures for WebKit2-related projects.
146         https://bugs.webkit.org/show_bug.cgi?id=51440
147
148         * MiniBrowser/Configurations/Base.xcconfig: Only build for i386 and x86_64.
149         * TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
150         * WebKitTestRunner/Configurations/Base.xcconfig: Ditto.
151
152 2010-12-21  Mihai Parparita  <mihaip@chromium.org>
153
154         Reviewed by Darin Fisher.
155
156         [Chromium] Rename WebThemeEngine/ControlDRT to WebThemeEngine/ControlDRTWin
157         https://bugs.webkit.org/show_bug.cgi?id=51406 
158         
159         Rename WebThemeControlDRT to WebThemeControlDRTWin and WebThemeEngineDRT
160         to WebThemeEngineDRTWin and update references everywhere.
161
162         * DumpRenderTree/DumpRenderTree.gypi:
163         * DumpRenderTree/chromium/TestShellWin.cpp:
164         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRT.cpp.
165         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRT.h.
166         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRT.cpp.
167         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRT.h.
168
169 2010-12-21  Anders Carlsson  <andersca@apple.com>
170
171         Reviewed by John Sullivan.
172
173         Clicking missing plug-in text does not show a sheet
174         https://bugs.webkit.org/show_bug.cgi?id=51403
175
176         Update for changes to the WebPageUIClient.
177
178         * MiniBrowser/mac/BrowserWindowController.m:
179         (-[BrowserWindowController awakeFromNib]):
180         * WebKitTestRunner/TestController.cpp:
181         (WTR::createOtherPage):
182         (WTR::TestController::initialize):
183
184 2010-12-21  Eric Seidel  <eric@webkit.org>
185
186         Reviewed by Adam Barth.
187
188         commit-queue will report constant failures as flaky if other tests flake
189         https://bugs.webkit.org/show_bug.cgi?id=51272
190
191         This patch just removes functionality and adds testing.
192         Previously we attempted to report flaky tests when we had
193         two different tests fail in a row.  However, since we stop
194         running the tests at the first failure, our code was wrong in
195         trying to determine flakiness from the incomplete runs.
196
197         Originally I posted an alternate patch:
198         https://bug-51272-attachments.webkit.org/attachment.cgi?id=77078
199         which fixed our flaky logic in this case, however it was decided
200         that that patch would be too difficult to maintain, so now
201         I'm just removing the broken logic.
202
203         This will dramatically cut-down on our flaky-test false positives
204         at the (small) cost of the queues being unable to report
205         any flakiness if the tree is very flaky.  (With at least one test
206         flaking on every run, we'll never report failures anymore.)  I think
207         this is a tradeoff worth making.
208
209         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
210         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
211
212 2010-12-20  Eric Seidel  <eric@webkit.org>
213
214         Reviewed by Adam Barth.
215
216         commit-queue wrongly rejects patches when it can't update itself
217         https://bugs.webkit.org/show_bug.cgi?id=46636
218
219         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
220         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
221         * Scripts/webkitpy/tool/commands/queues_unittest.py:
222
223 2010-12-20  Adam Barth  <abarth@webkit.org>
224
225         Move web sites to Websites directory
226         https://bugs.webkit.org/show_bug.cgi?id=51323
227
228         Update references to BugsSite to point to the new location.
229
230         This patch was never officially reviewed (because it was too large to
231         upload to bugs.webkit.org), but it was discussed on webkit-dev and Mark
232         Rowe gave me the green light.
233
234         * Scripts/old-run-webkit-tests:
235         * Scripts/webkitpy/common/config/build.py:
236         * Scripts/webkitpy/common/config/build_unittest.py:
237         * Scripts/webkitpy/common/prettypatch.py:
238         * Scripts/webkitpy/layout_tests/port/base.py:
239         * Scripts/webkitpy/style/main.py:
240
241 2010-12-20  Adrienne Walker  <enne@google.com>
242
243         Unreviewed. Adding myself to the list of committers.
244
245         * webkitpy/common/config/committers.py:
246
247 2010-12-20  Mark Rowe  <mrowe@apple.com>
248
249         Reviewed by Dan Bernstein.
250
251         <rdar://problem/8757601> Don't install header files in to the Resources directory.
252
253         * Scripts/check-for-inappropriate-files-in-framework: Don't allow .h files in the
254         Resources directory.
255
256 2010-12-20  Eric Seidel  <eric@webkit.org>
257
258         Reviewed by Adam Barth.
259
260         commit-queue should include bot id when attaching failure diffs
261         https://bugs.webkit.org/show_bug.cgi?id=51280
262
263         This is a tiny change to include the bot id in the name of the attachment.
264         Most of this diff is just changing the unit test expectations
265         now that I hid the comment printing when the comment is None.
266
267         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
268         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
269         * Scripts/webkitpy/tool/commands/upload_unittest.py:
270         * Scripts/webkitpy/tool/mocktool.py:
271
272 2010-12-20  Jeff Miller  <jeffm@apple.com>
273
274         Reviewed by Dan Bernstein.
275
276         Tools/vcbin/midl.exe needs to be rebuilt
277         https://bugs.webkit.org/show_bug.cgi?id=51347
278
279         * vcbin/midl.exe: Rebuilt.
280
281 2010-12-20  David Levin  <levin@chromium.org>
282
283         Reviewed by Ariya Hidayat.
284
285         .gitignore and webkit-tools-completion.sh have references to WebKitTools that should be Tools.
286         https://bugs.webkit.org/show_bug.cgi?id=51343
287
288         Follow up from the WebKitTools -> Tools rename.
289
290         * Scripts/webkit-tools-completion.sh:
291
292 2010-12-20  Cosmin Truta  <ctruta@chromium.org>
293
294         Reviewed by James Robinson.
295
296         new-run-webkit-tests ignores trailing EOL differences in text tests
297         https://bugs.webkit.org/show_bug.cgi?id=36983
298
299         Changed the handling of new-line characters within new-run-webkit-tests
300         to match old-run-webkit-tests.  Differences in leading and trailing empty
301         lines in text expectation files are no longer ignored.
302
303         * Scripts/webkitpy/layout_tests/port/base.py:
304         * Scripts/webkitpy/layout_tests/port/test.py:
305         Added unit tests.  Removed old duplicate unit test entries.
306         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
307
308 2010-12-20  David Levin  <levin@chromium.org>
309
310         Reviewed by Shinichiro Hamaji.
311
312         check-webkit-style should detect function declarations (and trivial functions).
313         https://bugs.webkit.org/show_bug.cgi?id=51303
314
315         * Scripts/webkitpy/style/checkers/cpp.py:
316         (_FunctionState.begin): Add is_declaration and changed the line count
317         start to begin at -1 (which will keep the results consistent, since
318         the starting line number passed in is one less in this change).
319         (detect_functions): changed function detection to now catch trivial
320         functions and declarations.
321         (check_pass_ptr_usage): Don't check for Pass*Ptr on the first line
322         of the function as this may look at return values (when processing
323         a declaration).
324         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
325         (FunctionDetectionTest.perform_function_detection): Basic mechanics
326         of testing the function detection.
327         (FunctionDetectionTest.test_basic_function_detection): Test a simple
328         function.
329         (FunctionDetectionTest.test_function_declaration_detection): Test a
330         declaration.
331         (FunctionDetectionTest.test_non_functions): A test case for a case
332         that caused the code to fail due to the { being in quotes.
333         (PassPtrTest.test_pass_ref_ptr_return_value): Added some more test
334         cases to help catch false alarms for return values.
335         (PassPtrTest.test_pass_ref_ptr_member_variable): Ensure that
336         we don't get false alarms for member variables either.
337
338 2010-12-20  Ryuan Choi  <ryuan.choi@samsung.com>
339
340         Reviewed by Antonio Gomes.
341
342         [CMAKE] Rename WEBKITTOOLS_DIR to TOOLS_DIR
343         https://bugs.webkit.org/show_bug.cgi?id=51319
344
345         * CMakeListsEfl.txt:
346
347 2010-12-18  Adam Barth  <abarth@webkit.org>
348
349         Reviewed by Sam Weinig.
350
351         Move WebKitExamplePlugins to Examples
352         https://bugs.webkit.org/show_bug.cgi?id=51291
353
354         * Scripts/webkitpy/common/config/build.py:
355
356 2010-12-17  Csaba Osztrogonác  <ossy@webkit.org>
357
358         Unreviewed Qt buildfix after r74301.
359
360         Rename WebKitTools to Tools
361         https://bugs.webkit.org/show_bug.cgi?id=49861
362
363         * MiniBrowser/DerivedSources.pro:
364         * MiniBrowser/qt/MiniBrowser.pro:
365
366 2010-12-17  Dan Bernstein  <mitz@apple.com>
367
368         Reviewed by Simon Fraser.
369
370         Rename WebKitTools to Tools
371         https://bugs.webkit.org/show_bug.cgi?id=49861
372
373         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
374         * CodeCoverage/README:
375         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
376         (WebCore::DumpRenderTree::initializeFonts):
377         * EWSTools/start-commit-queue.sh:
378         * EWSTools/start-queue.sh:
379         * GNUmakefile.am:
380         * MIDLWrapper/MIDLWrapper.cpp:
381         (wmain):
382         * MiniBrowser/qt/MiniBrowser.pro:
383         * Scripts/build-api-tests:
384         * Scripts/build-dumprendertree:
385         * Scripts/build-webkit:
386         * Scripts/build-webkittestrunner:
387         * Scripts/generate-coverage-data:
388         * Scripts/old-run-webkit-tests:
389         * Scripts/run-api-tests:
390         * Scripts/run-iexploder-tests:
391         * Scripts/run-javascriptcore-tests:
392         * Scripts/run-mangleme-tests:
393         * Scripts/run-sunspider:
394         * Scripts/run-webkit-websocketserver:
395         * Scripts/sunspider-compare-results:
396         * Scripts/test-webkitperl:
397         * Scripts/test-webkitpy:
398         * Scripts/update-iexploder-cssproperties:
399         * Scripts/update-webkit:
400         * Scripts/update-webkit-localizable-strings:
401         * Scripts/webkitdirs.pm:
402         * Scripts/webkitpy/common/checkout/scm.py:
403         * Scripts/webkitpy/common/checkout/scm_unittest.py:
404         * Scripts/webkitpy/common/config/committervalidator.py:
405         * Scripts/webkitpy/common/config/committervalidator_unittest.py:
406         * Scripts/webkitpy/common/config/ports.py:
407         * Scripts/webkitpy/common/config/ports_unittest.py:
408         * Scripts/webkitpy/common/system/logutils_unittest.py:
409         * Scripts/webkitpy/common/system/ospath_unittest.py:
410         * Scripts/webkitpy/layout_tests/port/chromium.py:
411         * Scripts/webkitpy/layout_tests/port/config.py:
412         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
413         * Scripts/webkitpy/layout_tests/port/http_server.py:
414         * Scripts/webkitpy/layout_tests/port/test.py:
415         * Scripts/webkitpy/style/checker.py:
416         * Scripts/webkitpy/style/checker_unittest.py:
417         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
418         * Scripts/webkitpy/tool/commands/queues_unittest.py:
419         * Scripts/webkitpy/tool/steps/steps_unittest.py:
420         * WebKitTestRunner/DerivedSources.pro:
421         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
422         (WTR::activateFonts):
423         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
424         * wx/build/build_utils.py:
425
426 2010-12-16  Antonio Gomes  <agomes@rim.com>
427
428         Reviewed by Martin Robinson.
429
430         Settings::editingBehaviorType() incorrectly returns mac for the gtk build when running tests
431         https://bugs.webkit.org/show_bug.cgi?id=51163
432
433         Since GTK+'s default editing behavior was changed to UNIX in r70975 (see webkitwebsettings.cpp),
434         GTK+'s DRT should also reset to UNIX after each test execution.
435
436         * DumpRenderTree/gtk/DumpRenderTree.cpp:
437         (resetDefaultsToConsistentValues):
438
439 2010-12-17  David Levin  <levin@chromium.org>
440
441         Reviewed by Eric Seidel.
442
443         check-webkit-style should understand WTF #include guards
444         https://bugs.webkit.org/show_bug.cgi?id=44911
445
446         * Scripts/webkitpy/style/checkers/cpp.py:
447         (get_header_guard_cpp_variable): modify to suggest the WTF style
448         of header guard when appropriate.
449         (check_for_header_guard): handle multiple return values from
450         get_header_guard_cpp_variable
451         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
452         (CppStyleTest.test_build_header_guard): Added tests for the WTF
453         header style.
454
455 2010-12-16  David Levin  <levin@chromium.org>
456
457         Reviewed by Eric Seidel.
458
459         test-webkitpy: unittest for the xml.py checker displays a decprecation warning.
460         https://bugs.webkit.org/show_bug.cgi?id=51210
461
462         The error only shows up when using python 2.6 or later.
463
464         * Scripts/webkitpy/style/checkers/xml.py: Replace the usage of
465         the decprecated field error,message with something equivalent.
466
467 2010-12-16  Mihai Parparita  <mihaip@chromium.org>
468
469         Reviewed by Eric Seidel.
470
471         Add --exit-after-n-failures/crashes to NRWT
472         https://bugs.webkit.org/show_bug.cgi?id=51160
473         
474         Abort test run (in a similar way to how control-C is handled) when
475         --exit-after-n-failures/crashes-or-timeouts are passed and we've reached
476         that number of unexpected failures/crashes/timeouts.
477
478         * Scripts/webkitpy/layout_tests/port/test.py:
479         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
480         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
481
482 2010-12-16  David Levin  <levin@chromium.org>
483
484         Reviewed by Shinichiro Hamaji.
485
486         check-webkit-style unit tests has some duplicate boilerplate code.
487         https://bugs.webkit.org/show_bug.cgi?id=49519
488
489         * Scripts/webkitpy/style/checkers/cpp.py:
490         (update_include_state): Replaced the "io" parameter with the global
491         configuration _unit_test_config. This allowed not calling into
492         functions at a low level and also not plumbing through the injection
493         information through many levels of code.
494         (check_for_include_what_you_use): Ditto.
495         (process_file_data): Added the ability to set up the unit test config
496         to allow for injection.
497         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
498         (ErrorCollector.__init__): Added support for having a filter for errors.
499         (ErrorCollector.__call__): Ditto.
500         (CppStyleTestBase.process_file_data): Added the ability to set unit_test_config.
501         (CppStyleTestBase.perform_lint): Consolidated logic for the perform functions.
502         (CppStyleTestBase.perform_single_line_lint): Replace specific calls to
503         functions in the cpp.py with generic processing and a filter that
504         indicates what errors should be kept.
505         (CppStyleTestBase.perform_multi_line_lint): Ditto.
506         (CppStyleTestBase.perform_language_rules_check): Ditto.
507         (CppStyleTestBase.perform_function_lengths_check): Ditto.
508         (CppStyleTestBase.perform_pass_ptr_check): Ditto.
509         (CppStyleTestBase.perform_include_what_you_use): Ditto.
510         (CppStyleTest.test_multi_line_comments): Added another
511         error message which applies to the test case.
512         (CppStyleTest.test_spacing_for_binary_ops): Fixed test
513         to not have config.h, since it is processed as a header file.
514         (CppStyleTest.test_static_or_global_stlstrings): Fixed variable name
515         style and indentation in checked code.
516         (OrderOfIncludesTest.test_check_preprocessor_in_include_section):
517         Fixed line number.
518         (NoNonVirtualDestructorsTest.test_multi_line_declaration_with_error):
519         Ditto.
520
521 2010-12-15  Sheriff Bot  <webkit.review.bot@gmail.com>
522
523         Unreviewed, rolling out r74136.
524         http://trac.webkit.org/changeset/74136
525         https://bugs.webkit.org/show_bug.cgi?id=51135
526
527         r74136 breaks chromium canary bots because some tests are not
528         rebaselined correctly to resolve EOL differences (Requested by
529         jianli on #webkit).
530
531         * Scripts/webkitpy/layout_tests/port/base.py:
532         * Scripts/webkitpy/layout_tests/port/test.py:
533         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
534
535 2010-12-15  Adam Roben  <aroben@apple.com>
536
537         Teach check-webkit-style to check .vcproj and .vsprops files for XML
538         syntax errors
539
540         Fixes <http://webkit.org/b/51103> check-webkit-style should check for
541         XML syntax errors in .vcproj/.vsprops files
542
543         Reviewed by Dave Levin.
544
545         * Scripts/webkitpy/style/checker.py: Added lists of file extensions
546         that should be treated as XML and that should be allowed to contain
547         carriage returns. (These lists happen to be identical currently.)
548         (FileType): Added a new XML type.
549         (CheckerDispatcher.should_check_and_strip_carriage_returns): Added.
550         Just does a simple file extension check.
551         (CheckerDispatcher._file_type): Added a case for XML files.
552         (CheckerDispatcher._create_checker): Ditto. We use XMLChecker for XML
553         files (surprise!).
554         (StyleProcessor.process): Ask the dispatcher whether we should pass the
555         lines through the carriage checker.
556
557         * Scripts/webkitpy/style/checker_unittest.py:
558         (CheckerDispatcherCarriageReturnTest.test_should_check_and_strip_carriage_returns):
559         Added. Checks a few file names to see if carriage returns are allowed
560         or not.
561         (CheckerDispatcherDispatchTest.assert_checker_xml): Added. Similar to
562         other assert_checker_* functions.
563         (CheckerDispatcherDispatchTest.test_xml_paths): Added. Similar to other
564         test_*_paths functions.
565         (CheckerDispatcherDispatchTest.test_xml_paths): Added. Similar to other
566         test_*_paths functions.
567         (CheckerDispatcherDispatchTest.test_none_paths): Removed the vcproj
568         file from this test case, as vcproj files now have a type.
569         (StyleProcessor_CodeCoverageTest.MockDispatcher.should_check_and_strip_carriage_returns):
570         Added. Similar to the other should_* functions.
571         (StyleProcessor_CodeCoverageTest.test_process__carriage_returns_not_stripped):
572         Added. Checks that carriage returns aren't checked for or stripped for
573         allowed files.
574
575         * Scripts/webkitpy/style/checkers/xml.py: Added.
576         (XMLChecker.__init__): Simple init method.
577         (XMLChecker.check): Pass each line through the expat parser, and record
578         a style error for any errors thrown by the parser.
579
580         * Scripts/webkitpy/style/checkers/xml_unittest.py: Added.
581         (XMLCheckerTest.assert_no_error): Checks that the given XML does not
582         produce a style error.
583         (XMLCheckerTest.assert_error): Checks that the given XML produces an
584         error of the given category on the given line.
585         (XMLCheckerTest.mock_handle_style_error): Does nothing. Used for
586         checking that the XMLChecker constructor works properly.
587         (XMLCheckerTest.test_conflict_marker): Tests that conflict markers
588         cause a style error (see, e.g., r73887).
589         (XMLCheckerTest.test_extra_closing_tag): Tests that extra closing tags
590         cause a style error (see, e.g., r73773).
591         (XMLCheckerTest.test_init): Tests that the XMLChecker constructor works
592         properly.
593         (XMLCheckerTest.test_missing_closing_tag): Tests that missing closing
594         tags cause a style error (see, e.g., r72795).
595         (XMLCheckerTest.test_no_error): Tests that valid XML does not cause a
596         style error.
597
598 2010-12-15  Lucas Forschler  <lforschler@apple.com>
599
600         Reviewed by Stephanie Lewis.
601
602         https://bugs.webkit.org/show_bug.cgi?id=51117
603         Add a new leopard test bot
604         really really commit to trunk this time.
605
606         * BuildSlaveSupport/build.webkit.org-config/config.json:
607
608 2010-12-15  Sam Weinig  <sam@webkit.org>
609
610         Reviewed by Anders Carlsson.
611
612         WebKit2: Can't add files to an <input type=file>
613         https://bugs.webkit.org/show_bug.cgi?id=51087
614
615         * MiniBrowser/mac/BrowserWindowController.m:
616         (runOpenPanel):
617         (-[BrowserWindowController awakeFromNib]):
618         Add simple implementation of runOpenPanel callback.
619
620         * MiniBrowser/win/BrowserView.cpp:
621         (BrowserView::create):
622         * WebKitTestRunner/TestController.cpp:
623         (WTR::createOtherPage):
624         (WTR::TestController::initialize):
625         Stub out runOpenPanel callback. 
626
627 2010-12-14  Eric Seidel  <eric@webkit.org>
628
629         Reviewed by Adam Barth.
630
631         commit-queue should upload failure diffs when tests flake
632         https://bugs.webkit.org/show_bug.cgi?id=51051
633
634         To make this testable I needed to pipe FileSystem down onto tool.
635         We've wanted it there for a long time anyway.
636
637         This patch is kinda a big hack.  But we don't have a nice
638         way to read results.html files.  I think this will need further
639         revision before this code actually feels clean.
640
641         As part of testing this change, I had to make MockBugzilla.create_bug
642         actually return an id (like it should) which required updating
643         a few other unit test results (for the better).
644
645         The results_matching_keys change in layouttestresults/rebasline
646         was an alternate path which I decided not to use in the end, but
647         I left the change as it seemed an improvement.
648
649         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
650         * Scripts/webkitpy/common/net/layouttestresults.py:
651         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
652         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
653         * Scripts/webkitpy/tool/commands/queues.py:
654         * Scripts/webkitpy/tool/commands/rebaseline.py:
655         * Scripts/webkitpy/tool/main.py:
656         * Scripts/webkitpy/tool/mocktool.py:
657
658 2010-12-15  Cosmin Truta  <ctruta@chromium.org>
659
660         Reviewed by James Robinson.
661
662         new-run-webkit-tests ignores trailing EOL differences in text tests
663         https://bugs.webkit.org/show_bug.cgi?id=36983
664
665         Changed the handling of new-line characters within new-run-webkit-tests
666         to match old-run-webkit-tests.  Differences in leading and trailing empty
667         lines in text expectation files are no longer ignored.
668
669         * Scripts/webkitpy/layout_tests/port/base.py:
670         * Scripts/webkitpy/layout_tests/port/test.py:
671         Added unit tests.  Removed old duplicate unit test entries.
672         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
673
674 2010-12-15  Ojan Vafai  <ojan@chromium.org>
675
676         Reviewed by Adam Barth.
677
678         make status-bubble white-space:nowrap so we can measure it's width without wrapping
679         https://bugs.webkit.org/show_bug.cgi?id=51149
680
681         * QueueStatusServer/templates/statusbubble.html:
682
683 2010-12-15  Ojan Vafai  <ojan@chromium.org>
684
685         Reviewed by Adam Barth.
686
687         have the statusbubble postMessage it's metrics so that embedders can properly size the iframe
688         https://bugs.webkit.org/show_bug.cgi?id=51125
689
690         * QueueStatusServer/templates/statusbubble.html:
691
692 2010-12-15  Darin Adler  <darin@apple.com>
693
694         * Scripts/webkitpy/common/net/buildbot: Added property svn:ignore.
695
696 2010-12-15  Sheriff Bot  <webkit.review.bot@gmail.com>
697
698         Unreviewed, rolling out r74117.
699         http://trac.webkit.org/changeset/74117
700         https://bugs.webkit.org/show_bug.cgi?id=51113
701
702         This broke the GTK1 build. (Requested by mrobinson on
703         #webkit).
704
705         * Scripts/webkitdirs.pm:
706
707 2010-12-15  Amruth Raj  <amruthraj@motorola.com> and Ravi Kasibhatla  <ravi.kasibhatla@motorola.com>
708
709         Reviewed by Martin Robinson.
710
711         Change generate-forwarding-headers.pl for GTK port usage 
712         (https://bugs.webkit.org/show_bug.cgi?id=37369)
713
714         * Scripts/webkitdirs.pm: Added changes to build webkit2 for GTK port using build-webkit script.
715
716 2010-12-14  Kent Tamura  <tkent@chromium.org>
717
718         Reviewed by Jian Li.
719
720         [DRT/Chromium] Remove another unnecessary error message
721         https://bugs.webkit.org/show_bug.cgi?id=51083
722
723         * DumpRenderTree/chromium/WebViewHost.cpp:
724         (WebViewHost::didInvalidateRect):
725
726 2010-12-14  Lucas Forschler  <lforschler@apple.com>
727
728         Reviewed by Stephanie Lewis.
729
730         Add a new Leopard Debug Test WK2 Bot
731
732         * BuildSlaveSupport/build.webkit.org-config/config.json:
733
734 2010-12-14  Ojan Vafai  <ojan@chromium.org>
735
736         Fix python unittests after http://trac.webkit.org/changeset/74070.
737
738         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
739
740 2010-12-14  Kent Tamura  <tkent@chromium.org>
741
742         Reviewed by Jian Li.
743
744         [DRT/Chromium] Remove a unnecessary error message
745         https://bugs.webkit.org/show_bug.cgi?id=51069
746
747         * DumpRenderTree/chromium/WebViewHost.cpp:
748         (WebViewHost::paintInvalidatedRegion):
749
750 2010-12-14  Benjamin Kalman  <kalman@chromium.org>
751
752         Reviewed by Ojan Vafai.
753
754         Using BUG/BUGWK in test_expectations is error prone, should use BUGCR/BUGWK
755         https://bugs.webkit.org/show_bug.cgi?id=48926
756
757         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
758         Add presubmit check that BUG isn't used, either BUGCR/BUGWK/BUGV8_.
759
760 2010-12-14  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
761
762         Reviewed by Eric Seidel.
763
764         [Qt] [Symbian] Do not use pkg-config on Symbian as it is not supported
765         https://bugs.webkit.org/show_bug.cgi?id=50231
766
767         Guard CONFIG+=link_pkgconfig with !symbian.
768
769         * DumpRenderTree/qt/DumpRenderTree.pro:
770         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
771         * WebKitTestRunner/qt/WebKitTestRunner.pro:
772
773 2010-12-14  Philippe Normand  <pnormand@igalia.com>
774
775         Reviewed by Ojan Vafai.
776
777         [new-run-webkit-tests] expectations parsing is slow
778         https://bugs.webkit.org/show_bug.cgi?id=50635
779
780         Avoid expensive iteration of all the tests when checking if a test
781         file is to be skipped or not.
782
783         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
784         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
785         * Scripts/webkitpy/layout_tests/port/test.py:
786
787 2010-12-14  Mario Sanchez Prada  <msanchez@igalia.com>
788
789         Reviewed by Xan Lopez.
790
791         [Gtk] Implement STATE_FOCUSED, STATE_FOCUSABLE, and corresponding events for text objects
792         https://bugs.webkit.org/show_bug.cgi?id=27048
793
794         Add support in DRT for checking whether an accessibility UI
795         element is focusable and/or focused. Implemented for GTK.
796
797         * DumpRenderTree/AccessibilityUIElement.cpp:
798         (getIsFocusedCallback): New.
799         (getIsFocusableCallback): New.
800         (AccessibilityUIElement::getJSClass): Add the new available
801         callbacks for isFocused and isFocusable.
802         * DumpRenderTree/AccessibilityUIElement.h:
803         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
804         (AccessibilityUIElement::isFocused): New, implemented by checking
805         whether the related AtkState value is in the object's state set.
806         (AccessibilityUIElement::isFocusable): Ditto.
807         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
808         (AccessibilityUIElement::isFocused): New, dummy implementation.
809         (AccessibilityUIElement::isFocusable): Ditto.
810         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
811         (AccessibilityUIElement::isFocused): Ditto.
812         (AccessibilityUIElement::isFocusable): Ditto.
813
814 2010-12-14  Eric Seidel  <eric@webkit.org>
815
816         Reviewed by Ojan Vafai.
817
818         webkit-patch should warn users when they're using a 32-bit git on a 64-bit system
819         https://bugs.webkit.org/show_bug.cgi?id=50715
820
821         This patch makes webkit-patch print the following:
822
823         Warning: This machine is 64-bit, but the git binary (/usr/local/git/bin/git) does not support 64-bit.
824         Install a 64-bit git for better performance, see:
825         https://lists.webkit.org/pipermail/webkit-dev/2010-December/015249.html
826
827         I wrote this mostly because I have approximately 8 machines that I use
828         and making sure each one is using a good Git install seemed folly.
829         webkit-patch makes a lot of git calls, so using a fast git can shave
830         several seconds in every invocation.  See the webkit-dev thread for more info.
831
832         This message will print twice during 'webkit-patch upload',
833         once from webkit-patch and once from check-webkit-style.
834
835         Unfortunately there is no good way to test this due to how machine-dependent
836         the code is.  I considered writing a test for the log message, but it seemed not worth it.
837
838         * Scripts/webkitpy/common/checkout/scm.py:
839
840 2010-12-13  Eric Seidel  <eric@webkit.org>
841
842         Reviewed by Adam Barth.
843
844         FlakyTestReporter doesn't understand bots running from multiple email addresses
845         https://bugs.webkit.org/show_bug.cgi?id=50960
846
847         This explains at least one of the dupes of:
848         https://bugs.webkit.org/show_bug.cgi?id=50863
849         that we saw filed by the commit-queue this morning.
850         I think the other one was explained by my previous fix to result counting code.
851
852         Since this is really hard to test with a unit test, instead I
853         create a new (possibly useful in the future) command
854         which given a layout test path will return you
855         the one bug which our tools would assume it the flaky test bug.
856         If some other script wants to use bug-for-test we'll
857         need to extend it with some options like --create-if-missing or similar.
858
859         * Scripts/webkitpy/common/net/bugzilla/bug.py:
860         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
861         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
862         * Scripts/webkitpy/tool/commands/__init__.py:
863         * Scripts/webkitpy/tool/commands/bugfortest.py: Added.
864
865 2010-12-13  Mihai Parparita  <mihaip@chromium.org>
866
867         Reviewed by James Robinson.
868
869         Add option to build-webkit to not build WebKit2
870         https://bugs.webkit.org/show_bug.cgi?id=50988
871         
872         Add support for a --no-webkit2 option to build-webkit. It seems to save
873         ~1 minute from clean builds and ~10 seconds from no-op builds.
874
875         * Scripts/build-webkit:
876
877 2010-12-13  Lucas Forschler  <lforschler@apple.com>
878
879         Reviewed by Dave Kilzer.
880
881         Update iexploder from 1.3.2 to 1.7.2
882         Move 1.3.2 into its own subdir
883         Add 1.7.2 into its own subdir
884         update scripts to point to new 1.3.2 location (avoid breaking existing scripts)
885
886         * Scripts/run-iexploder-tests:
887         * Scripts/update-iexploder-cssproperties:
888         * iExploder/CHANGELOG.txt: Removed.
889         * iExploder/LICENSE.txt: Removed.
890         * iExploder/README.txt: Removed.
891         * iExploder/htdocs: Removed.
892         * iExploder/iexploder-1.3.2: Added.
893         * iExploder/iexploder-1.3.2/CHANGELOG.txt: Copied from iExploder/CHANGELOG.txt.
894         * iExploder/iexploder-1.3.2/LICENSE.txt: Copied from iExploder/LICENSE.txt.
895         * iExploder/iexploder-1.3.2/README.txt: Copied from iExploder/README.txt.
896         * iExploder/iexploder-1.3.2/htdocs: Added.
897         * iExploder/iexploder-1.3.2/htdocs/config.rb: Copied from iExploder/htdocs/config.rb.
898         * iExploder/iexploder-1.3.2/htdocs/cssproperties.in: Copied from iExploder/htdocs/cssproperties.in.
899         * iExploder/iexploder-1.3.2/htdocs/cssvalues.in: Copied from iExploder/htdocs/cssvalues.in.
900         * iExploder/iexploder-1.3.2/htdocs/htmlattrs.in: Copied from iExploder/htdocs/htmlattrs.in.
901         * iExploder/iexploder-1.3.2/htdocs/htmltags.in: Copied from iExploder/htdocs/htmltags.in.
902         * iExploder/iexploder-1.3.2/htdocs/htmlvalues.in: Copied from iExploder/htdocs/htmlvalues.in.
903         * iExploder/iexploder-1.3.2/htdocs/iexploder.cgi: Copied from iExploder/htdocs/iexploder.cgi.
904         * iExploder/iexploder-1.3.2/htdocs/iexploder.rb: Copied from iExploder/htdocs/iexploder.rb.
905         * iExploder/iexploder-1.3.2/htdocs/index.html: Copied from iExploder/htdocs/index.html.
906         * iExploder/iexploder-1.3.2/htdocs/webserver.rb: Copied from iExploder/htdocs/webserver.rb.
907         * iExploder/iexploder-1.3.2/tools: Added.
908         * iExploder/iexploder-1.3.2/tools/lasthit.rb: Copied from iExploder/tools/lasthit.rb.
909         * iExploder/iexploder-1.3.2/tools/osx_last_crash.rb: Copied from iExploder/tools/osx_last_crash.rb.
910         * iExploder/iexploder-1.3.2/tools/showtest.rb: Copied from iExploder/tools/showtest.rb.
911         * iExploder/iexploder-1.7.2: Added.
912         * iExploder/iexploder-1.7.2/ChangeLog.txt: Added.
913         * iExploder/iexploder-1.7.2/LICENSE.txt: Added.
914         * iExploder/iexploder-1.7.2/README.txt: Added.
915         * iExploder/iexploder-1.7.2/output: Added.
916         * iExploder/iexploder-1.7.2/src: Added.
917         * iExploder/iexploder-1.7.2/src/browser_harness.rb: Added.
918         * iExploder/iexploder-1.7.2/src/config.yaml: Added.
919         * iExploder/iexploder-1.7.2/src/css-atrules: Added.
920         * iExploder/iexploder-1.7.2/src/css-atrules/mozilla: Added.
921         * iExploder/iexploder-1.7.2/src/css-atrules/webkit: Added.
922         * iExploder/iexploder-1.7.2/src/css-properties: Added.
923         * iExploder/iexploder-1.7.2/src/css-properties/dillo: Added.
924         * iExploder/iexploder-1.7.2/src/css-properties/gtkhtml: Added.
925         * iExploder/iexploder-1.7.2/src/css-properties/internet_explorer6: Added.
926         * iExploder/iexploder-1.7.2/src/css-properties/mozilla: Added.
927         * iExploder/iexploder-1.7.2/src/css-properties/webkit: Added.
928         * iExploder/iexploder-1.7.2/src/css-pseudo: Added.
929         * iExploder/iexploder-1.7.2/src/css-pseudo/mozilla: Added.
930         * iExploder/iexploder-1.7.2/src/css-pseudo/webkit: Added.
931         * iExploder/iexploder-1.7.2/src/css-values: Added.
932         * iExploder/iexploder-1.7.2/src/css-values/dillo: Added.
933         * iExploder/iexploder-1.7.2/src/css-values/gtkhtml: Added.
934         * iExploder/iexploder-1.7.2/src/css-values/mozilla: Added.
935         * iExploder/iexploder-1.7.2/src/css-values/other: Added.
936         * iExploder/iexploder-1.7.2/src/css-values/webkit: Added.
937         * iExploder/iexploder-1.7.2/src/headers: Added.
938         * iExploder/iexploder-1.7.2/src/headers/dillo: Added.
939         * iExploder/iexploder-1.7.2/src/headers/gtkhtml: Added.
940         * iExploder/iexploder-1.7.2/src/headers/mozilla: Added.
941         * iExploder/iexploder-1.7.2/src/headers/webkit: Added.
942         * iExploder/iexploder-1.7.2/src/html-attrs: Added.
943         * iExploder/iexploder-1.7.2/src/html-attrs/dillo: Added.
944         * iExploder/iexploder-1.7.2/src/html-attrs/gtkhtml: Added.
945         * iExploder/iexploder-1.7.2/src/html-attrs/internet_explorer6: Added.
946         * iExploder/iexploder-1.7.2/src/html-attrs/mozilla: Added.
947         * iExploder/iexploder-1.7.2/src/html-attrs/other: Added.
948         * iExploder/iexploder-1.7.2/src/html-attrs/webkit: Added.
949         * iExploder/iexploder-1.7.2/src/html-tags: Added.
950         * iExploder/iexploder-1.7.2/src/html-tags/dillo: Added.
951         * iExploder/iexploder-1.7.2/src/html-tags/gtkhtml: Added.
952         * iExploder/iexploder-1.7.2/src/html-tags/mozilla: Added.
953         * iExploder/iexploder-1.7.2/src/html-tags/other: Added.
954         * iExploder/iexploder-1.7.2/src/html-tags/webkit: Added.
955         * iExploder/iexploder-1.7.2/src/html-values: Added.
956         * iExploder/iexploder-1.7.2/src/html-values/dillo: Added.
957         * iExploder/iexploder-1.7.2/src/html-values/gtkhtml: Added.
958         * iExploder/iexploder-1.7.2/src/html-values/mozilla: Added.
959         * iExploder/iexploder-1.7.2/src/html-values/other: Added.
960         * iExploder/iexploder-1.7.2/src/html-values/webkit: Added.
961         * iExploder/iexploder-1.7.2/src/iexploder.cgi: Added.
962         * iExploder/iexploder-1.7.2/src/iexploder.rb: Added.
963         * iExploder/iexploder-1.7.2/src/index.html: Added.
964         * iExploder/iexploder-1.7.2/src/media: Added.
965         * iExploder/iexploder-1.7.2/src/media/blank.ogg: Added.
966         * iExploder/iexploder-1.7.2/src/media/blank.snd: Added.
967         * iExploder/iexploder-1.7.2/src/media/blank.wav: Added.
968         * iExploder/iexploder-1.7.2/src/media/bug.bmp: Added.
969         * iExploder/iexploder-1.7.2/src/media/bug.gif: Added.
970         * iExploder/iexploder-1.7.2/src/media/bug.ico: Added.
971         * iExploder/iexploder-1.7.2/src/media/bug.jng: Added.
972         * iExploder/iexploder-1.7.2/src/media/bug.jpg: Added.
973         * iExploder/iexploder-1.7.2/src/media/bug.png: Added.
974         * iExploder/iexploder-1.7.2/src/media/bug.svg: Added.
975         * iExploder/iexploder-1.7.2/src/media/bug.tiff: Added.
976         * iExploder/iexploder-1.7.2/src/media/bug.xbm: Added.
977         * iExploder/iexploder-1.7.2/src/media/bug.xpm: Added.
978         * iExploder/iexploder-1.7.2/src/mime-types: Added.
979         * iExploder/iexploder-1.7.2/src/mime-types/dillo: Added.
980         * iExploder/iexploder-1.7.2/src/mime-types/mozilla: Added.
981         * iExploder/iexploder-1.7.2/src/mime-types/webkit: Added.
982         * iExploder/iexploder-1.7.2/src/protocols: Added.
983         * iExploder/iexploder-1.7.2/src/protocols/dillo: Added.
984         * iExploder/iexploder-1.7.2/src/protocols/gtkhtml: Added.
985         * iExploder/iexploder-1.7.2/src/protocols/mozilla: Added.
986         * iExploder/iexploder-1.7.2/src/protocols/webkit: Added.
987         * iExploder/iexploder-1.7.2/src/scanner.rb: Added.
988         * iExploder/iexploder-1.7.2/src/version.rb: Added.
989         * iExploder/iexploder-1.7.2/src/webserver.rb: Added.
990         * iExploder/iexploder-1.7.2/testcases: Added.
991         * iExploder/iexploder-1.7.2/testcases/testcase-Linux_x86_64_rv2.0b6pre_Gecko-20100904_Firefox-4.0b6pre-TEST-8375-1_59.html: Added.
992         * iExploder/iexploder-1.7.2/testcases/testcase-Opera-9.80_Linux_x86_64_en_Presto-2.6.30_Version-10.61-16704-3_108,3.html: Added.
993         * iExploder/iexploder-1.7.2/testcases/testcase-U_Intel_Mac_OS_X_10_6_4_en-US_AppleWebKit-534.8_Chrome-7.0.529.0-TEST-611-3_36,9.html: Added.
994         * iExploder/iexploder-1.7.2/testcases/testcase-U_Intel_Mac_OS_X_10_6_4_en-US_AppleWebKit-534.8_hrome-7.0.529.0-TEST-55313622206-3_6,0.html: Added.
995         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.6_Chrome-7.0.503.1-TEST-120813-8_72,56,24,8,0.html: Added.
996         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.6_Chrome-7.0.503.1-TEST-121240-3_81,3.html: Added.
997         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.7_Chrome-7.0.513.0-4800-5_80,65,15.html: Added.
998         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.7_Chrome-7.0.513.0-TEST-23583190347-3_15,12.html: Added.
999         * iExploder/iexploder-1.7.2/tools: Added.
1000         * iExploder/iexploder-1.7.2/tools/lasthit.rb: Added.
1001         * iExploder/iexploder-1.7.2/tools/osx_last_crash.rb: Added.
1002         * iExploder/iexploder-1.7.2/tools/release_src.sh: Added.
1003         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh: Added.
1004         * iExploder/tools: Removed.
1005
1006 2010-12-13  Sam Weinig  <sam@webkit.org>
1007
1008         Reviewed by Anders Carlsson.
1009
1010         Remove associated page concept from WKView constructor
1011         https://bugs.webkit.org/show_bug.cgi?id=50983
1012
1013         Step 1: Remove associate page constructors from WKView and make
1014         all views use the shared namespace for the context.
1015
1016         * TestWebKitAPI/PlatformWebView.h:
1017         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
1018         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
1019         * WebKitTestRunner/PlatformWebView.h:
1020         * WebKitTestRunner/TestController.cpp:
1021         (WTR::createOtherPage):
1022         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1023         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1024         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
1025
1026 2010-12-13  Sam Weinig  <sam@webkit.org>
1027
1028         Reviewed by Anders Carlsson.
1029
1030         Change the WebKit2 public API so there is no explicit WKPageNamespace object
1031         https://bugs.webkit.org/show_bug.cgi?id=50898
1032
1033         * MiniBrowser/mac/AppDelegate.h:
1034         * MiniBrowser/mac/AppDelegate.m:
1035         * MiniBrowser/mac/BrowserWindowController.h:
1036         * MiniBrowser/mac/BrowserWindowController.m:
1037         * MiniBrowser/win/BrowserView.cpp:
1038         Convert MiniBrowser to not use PageNamespaces.
1039
1040         * TestWebKitAPI/PlatformWebView.h:
1041         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
1042         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
1043         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
1044         * TestWebKitAPI/Tests/WebKit2/Find.cpp:
1045         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
1046         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
1047         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
1048         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
1049         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
1050         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
1051         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
1052         * TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp:
1053         * TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp:
1054         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
1055         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
1056         Convert TestWebKitAPI to not use PageNamespaces.
1057
1058         * WebKitTestRunner/PlatformWebView.h:
1059         * WebKitTestRunner/TestController.cpp:
1060         * WebKitTestRunner/TestController.h:
1061         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1062         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1063         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
1064         Convert WebKitTestRunner to not use PageNamespaces.
1065
1066 2010-12-13  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
1067
1068         Reviewed by Eric Seidel.
1069
1070         webkit-patch rollout should be able to do multi-revision rollouts
1071         https://bugs.webkit.org/show_bug.cgi?id=33336
1072
1073         Make it possible to pass more than one revision to webkit-patch.
1074
1075         * Scripts/webkitpy/common/checkout/api.py:
1076         * Scripts/webkitpy/common/checkout/changelog.py:
1077         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1078         * Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:
1079         * Scripts/webkitpy/tool/commands/download.py:
1080         * Scripts/webkitpy/tool/commands/download_unittest.py:
1081         * Scripts/webkitpy/tool/mocktool.py:
1082         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
1083         * Scripts/webkitpy/tool/steps/revertrevision.py:
1084
1085 2010-12-13  Eric Seidel  <eric@webkit.org>
1086
1087         Unreviewed.
1088
1089         Teach webkit-patch how to search bugzilla
1090         https://bugs.webkit.org/show_bug.cgi?id=50500
1091
1092         webkit-patch bug-search fails when there is only one result.
1093         Turns out we needed a bit more logic in our result count parsing code.
1094
1095         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1096         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
1097
1098 2010-12-13  Antti Koivisto  <antti@apple.com>
1099
1100         Reviewed by Alexey Proskuryakov.
1101
1102         Add setSerializeHTTPLoads function to allow testing resource load order on OS X.
1103         https://bugs.webkit.org/show_bug.cgi?id=50758
1104
1105         * DumpRenderTree/LayoutTestController.cpp:
1106         (setSerializeHTTPLoadsCallback):
1107         (LayoutTestController::staticFunctions):
1108         * DumpRenderTree/LayoutTestController.h:
1109         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1110         (LayoutTestController::setSerializeHTTPLoads):
1111         * DumpRenderTree/mac/DumpRenderTree.mm:
1112         (resetDefaultsToConsistentValues):
1113         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1114         (LayoutTestController::setSerializeHTTPLoads):
1115         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1116         (LayoutTestController::setSerializeHTTPLoads):
1117
1118 2010-12-13  Dimitri Glazkov  <dglazkov@chromium.org>
1119
1120         Reviewed by Ojan Vafai.
1121
1122         Remove "use-drt" option from test step command line, since the option was removed in r73748.
1123         https://bugs.webkit.org/show_bug.cgi?id=50936
1124
1125         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Removed the option.
1126
1127 2010-12-13  Patrick Gansterer  <paroga@webkit.org>
1128
1129         Reviewed by Csaba Osztrogonác.
1130
1131         Add revlink to BuildBot status
1132         https://bugs.webkit.org/show_bug.cgi?id=50914
1133
1134         This adds a hyperlink to trac changeset on the revision numbers. 
1135
1136         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1137
1138 2010-12-13  Andras Becsi  <abecsi@webkit.org>
1139
1140         Reviewed by Csaba Osztrogonác.
1141
1142         [Qt][WK2] Fix build if WebKitTools are not available
1143         https://bugs.webkit.org/show_bug.cgi?id=50242
1144
1145         * MiniBrowser/qt/MiniBrowser.pro: Correct the comment.
1146         * Scripts/webkitdirs.pm: Added WebKitTools/MiniBrowser to $subdirs.
1147         * MiniBrowser/DerivedSources.pro: Added.
1148
1149 2010-12-13  Eric Seidel  <eric@webkit.org>
1150
1151         Reviewed by Adam Barth.
1152
1153         EWS Queues should remove orpahned pyc files before starting
1154         https://bugs.webkit.org/show_bug.cgi?id=50904
1155
1156         A previous check added a platform.py which caused
1157         EWS bots on some platforms to hit an import exception.
1158         The platform.py file was removed in a subsequent commit, but
1159         the EWS bots in question stayed stuck.  This change will
1160         fix those bots once restarted (and prevent this in the future).
1161
1162         I also went ahead and unified start-queue and start-commit-queue
1163         since they were nearly identical.  I also added bot_id support
1164         to both force all EWSes to have bot ids as well as get rid of the one
1165         remaining reason why I had my own copies of these scripts.
1166         Hopefully this will be enough to get all the other bot admins
1167         (ahem, Adam, ahem) to move to using these checked in copies as well.
1168
1169         * EWSTools/start-commit-queue.sh: Removed.
1170         * EWSTools/start-queue.sh:
1171
1172 2010-10-28  MORITA Hajime  <morrita@google.com>
1173
1174         Reviewed by Ojan Vafai.
1175
1176         spellcheck does not check pasted text
1177         https://bugs.webkit.org/show_bug.cgi?id=40092
1178
1179         Added LayoutTestController::setAsynchronousSpellCheckingEnabled()
1180         to control the setting.
1181
1182         * DumpRenderTree/LayoutTestController.cpp:
1183         (setAsynchronousSpellCheckingEnabledCallback):
1184         (LayoutTestController::staticFunctions):
1185         * DumpRenderTree/LayoutTestController.h:
1186         * DumpRenderTree/chromium/LayoutTestController.h:
1187         * DumpRenderTree/chromium/LayoutTestController.cpp:
1188         (LayoutTestController::LayoutTestController):
1189         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
1190         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1191         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
1192         * DumpRenderTree/mac/DumpRenderTree.mm:
1193         (resetDefaultsToConsistentValues):
1194         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1195         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
1196         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1197         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1198         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
1199         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1200         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
1201         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1202         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
1203
1204 2010-12-12  Sam Weinig  <sam@webkit.org>
1205
1206         Reviewed by Anders Carlsson.
1207
1208         Fix failing API test. It turns out that a pop-state event
1209         is sent before every fragment navigation, so we have to test
1210         for it in addition in PageLoadDidChangeLocationWithinPageForFrame.
1211
1212         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
1213         (TestWebKitAPI::didSameDocumentNavigationForFrame):
1214
1215 2010-12-12  Alejandro G. Castro  <alex@igalia.com>
1216
1217         Reviewed by Eric Seidel.
1218
1219         [GTK] Add new-run-webkit-tests support to gtk
1220         https://bugs.webkit.org/show_bug.cgi?id=50681
1221
1222         Adding the basic support to run the new-run-webkit-tests.
1223
1224         * Scripts/webkitpy/layout_tests/port/gtk.py:
1225
1226 2010-10-11  Diego Gonzalez  <diegohcg@webkit.org>
1227
1228         Reviewed by Kenneth Rohde Christiansen.
1229
1230         [Qt] Mock DeviceOrientation client for DRT
1231         https://bugs.webkit.org/show_bug.cgi?id=47490
1232
1233         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1234         (WebCore::DumpRenderTree::DumpRenderTree):
1235         (WebCore::DumpRenderTree::~DumpRenderTree):
1236         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1237         (LayoutTestController::setMockDeviceOrientation):
1238
1239 2010-12-11  Philippe Normand  <pnormand@igalia.com>
1240
1241         Reviewed by Gustavo Noronha Silva.
1242
1243         [GTK] launcher: disable the Mozilla-style fullscreen API
1244         https://bugs.webkit.org/show_bug.cgi?id=50874
1245
1246         Disabling the fullscreen API until its implementation for GTK is
1247         mature enough. The webview setting for it is already FALSE by
1248         default.
1249
1250         * GtkLauncher/main.c:
1251         (createWindow):
1252
1253 2010-12-10  Eric Seidel  <eric@webkit.org>
1254
1255         Reviewed by Adam Barth.
1256
1257         commit-queue flaky test messages show cryptic version information for mac os x
1258         https://bugs.webkit.org/show_bug.cgi?id=50864
1259
1260         Turns out platform.platform() returns kernel version information
1261         which isn't helpful, and just plain confusing on Mac
1262         (OS X 10.6.5 uses Darwin Kernel 10.5.0).
1263
1264         So I've updated PlatformInfo.display_name() to special case
1265         mac.  I also found a bad use of sys.platform in the process
1266         and fixed that.  (sys.platform always returns 'darwin' on mac).
1267
1268         * Scripts/webkitpy/common/system/platforminfo.py:
1269         * Scripts/webkitpy/common/system/user.py:
1270         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1271         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1272         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1273
1274 2010-12-10  Eric Seidel  <eric@webkit.org>
1275
1276         Unreviewed.
1277
1278         Exception seen while reporting flaky test with commit-queue.
1279         Just a missing include.
1280
1281         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1282         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1283
1284 2010-12-10  Kinuko Yasuda  <kinuko@chromium.org>
1285
1286         Reviewed by Eric Seidel.
1287
1288         [Chromium] Remove old JSONResultsGenerator script that existed for backward-compatibility
1289         https://bugs.webkit.org/show_bug.cgi?id=50796
1290
1291         Also updating the test code to use JSONResultsGeneratorBase and
1292         to improve test coverage for incremental cases.
1293
1294         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1295         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
1296
1297 2010-12-10  Joseph Pecoraro  <joepeck@webkit.org>
1298
1299         Reviewed by Darin Adler.
1300
1301         prepare-ChangeLog --help doesn't mention --bug shorthand -b
1302         https://bugs.webkit.org/show_bug.cgi?id=50835
1303
1304         * Scripts/prepare-ChangeLog: be more explicit about -b and match file style.
1305
1306 2010-12-10  Eric Seidel  <eric@webkit.org>
1307
1308         Reviewed by Adam Barth.
1309
1310         Bugs created by the commit-queue should all block on a master bug
1311         https://bugs.webkit.org/show_bug.cgi?id=50857
1312
1313         This makes all bugs created by the commit-queue block on:
1314         https://bugs.webkit.org/show_bug.cgi?id=50856
1315
1316         In the process of testing this, I found that the existing
1317         create_bug code was wrong.  I also found that existing
1318         unit tests for create-rollout used invalid values
1319         for options.blocks.  I fixed both issues and tested.
1320
1321         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1322         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1323         * Scripts/webkitpy/tool/commands/commandtest.py:
1324         * Scripts/webkitpy/tool/commands/download_unittest.py:
1325         * Scripts/webkitpy/tool/commands/upload_unittest.py:
1326         * Scripts/webkitpy/tool/mocktool.py:
1327         * Scripts/webkitpy/tool/steps/options.py:
1328
1329 2010-12-10  Eric Seidel  <eric@webkit.org>
1330
1331         Reviewed by Adam Barth.
1332
1333         Teach webkitpy how to follow duplicate chains when posting comments on flake bugs
1334         https://bugs.webkit.org/show_bug.cgi?id=50853
1335
1336         I also discovered when doing this that the code was posting
1337         the comment on the wrong bug, but that's fixed here too.
1338
1339         * Scripts/webkitpy/common/net/bugzilla/bug.py:
1340         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1341         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1342         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1343         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1344         * Scripts/webkitpy/tool/mocktool.py:
1345
1346 2010-12-10  Anders Carlsson  <andersca@apple.com>
1347
1348         Reviewed by John Sullivan.
1349
1350         Make WKContextGetStatistics gather global statistics
1351         https://bugs.webkit.org/show_bug.cgi?id=50850
1352
1353         Remove the code that gets the statistics and fills in the per context
1354         statistics information for now.
1355
1356         * MiniBrowser/mac/BrowserStatisticsWindowController.m:
1357         (-[BrowserStatisticsWindowController refreshStatistics:]):
1358
1359 2010-12-10  Eric Seidel  <eric@webkit.org>
1360
1361         Unreviewed.
1362
1363         commit-queue should report port/platform information when commenting on flaky test bugs
1364         https://bugs.webkit.org/show_bug.cgi?id=50839
1365
1366         Renamed platform.py to platforminfo.py.  This broke import platform in executive.py
1367         which was only used by new run webkit tests (and clearly not unit tested).
1368
1369         * Scripts/webkitpy/common/system/platforminfo.py: Renamed from WebKitTools/Scripts/webkitpy/common/system/platform.py.
1370         * Scripts/webkitpy/tool/main.py:
1371         * Scripts/webkitpy/tool/mocktool.py:
1372
1373 2010-12-10  Eric Seidel  <eric@webkit.org>
1374
1375         Reviewed by Tony Chang.
1376
1377         commit-queue should report port/platform information when commenting on flaky test bugs
1378         https://bugs.webkit.org/show_bug.cgi?id=50839
1379
1380         This was a suggestion from Tony Chang this morning.
1381         I added a platform.py class so I could easily mock the platform call,
1382         but that may not be the final solution for this mocking.
1383         We'll try it and see.
1384
1385         * Scripts/webkitpy/common/system/platform.py: Added.
1386         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1387         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1388         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1389         * Scripts/webkitpy/tool/main.py:
1390         * Scripts/webkitpy/tool/mocktool.py:
1391
1392 2010-12-10  Krithigassree Sambamurthy  <krithigassree.sambamurthy@nokia.com>
1393
1394         Reviewed by Joseph Pecoraro.
1395
1396         Bug 43455 - [Qt]: Implement Application Cache Quotas
1397         https://bugs.webkit.org/show_bug.cgi?id=43455
1398
1399         Introduce functions to allow new appcache layout test origin-quota.html
1400         to work correctly under Qt.
1401
1402         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1403         (WebCore::DumpRenderTree::DumpRenderTree):
1404         (WebCore::DumpRenderTree::dumpApplicationCacheQuota):
1405         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1406
1407         Introduce functions to allow new appcache layout test origin-quota.html
1408         to be successful under qt. Changes required because LayoutTestControllerQt
1409         does not inherit from LayoutController.
1410
1411         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1412         (LayoutTestController::reset):
1413         (LayoutTestController::clearAllApplicationCaches):
1414         (LayoutTestController::setApplicationCacheOriginQuota):
1415         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1416         (LayoutTestController::shouldDumpApplicationCacheDelegateCallbacks):
1417         (LayoutTestController::dumpApplicationCacheDelegateCallbacks):
1418
1419 2010-12-10  Eric Seidel  <eric@webkit.org>
1420
1421         Reviewed by Adam Barth.
1422
1423         Move buildbot.py into its own module so we can split it out into one-file-per-class
1424         https://bugs.webkit.org/show_bug.cgi?id=50806
1425
1426         We're adding more buildbot logic these days, so it makes sense
1427         to give buildbot its own module.
1428
1429         * Scripts/webkitpy/common/net/buildbot/__init__.py: Added.
1430         * Scripts/webkitpy/common/net/buildbot/buildbot.py: Renamed from WebKitTools/Scripts/webkitpy/common/net/buildbot.py.
1431         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py: Renamed from WebKitTools/Scripts/webkitpy/common/net/buildbot_unittest.py.
1432         * Scripts/webkitpy/common/net/failuremap.py:
1433         * Scripts/webkitpy/common/net/regressionwindow.py:
1434         * Scripts/webkitpy/tool/commands/rebaseline.py:
1435
1436 2010-12-10  Tony Chang  <tony@chromium.org>
1437
1438         Reviewed by Eric Seidel.
1439
1440         Use FileSystem::remove when cleaning up http lock files
1441         https://bugs.webkit.org/show_bug.cgi?id=50830
1442
1443         * Scripts/webkitpy/layout_tests/port/http_lock.py:
1444
1445 2010-12-10  Joone Hur  <joone@kldp.org>
1446
1447         Reviewed by Martin Robinson.
1448
1449         [GTK] DRT needs layoutTestController.setCacheModel
1450         https://bugs.webkit.org/show_bug.cgi?id=50705
1451         
1452         webkit_set_cache_mode() is called to set the cache model.
1453         
1454         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1455         (LayoutTestController::setCacheModel): Set the cache model. 
1456
1457 2010-12-10  Tony Chang  <tony@chromium.org>
1458
1459         Reviewed by Ojan Vafai.
1460
1461         [chromium] remove --use-drt and add --use-test-shell
1462         https://bugs.webkit.org/show_bug.cgi?id=50701
1463
1464         * Scripts/webkitpy/common/config/ports.py:
1465         * Scripts/webkitpy/common/config/ports_unittest.py:
1466         * Scripts/webkitpy/layout_tests/port/chromium.py:
1467         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1468         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1469         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1470         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1471         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1472         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1473         * Scripts/webkitpy/layout_tests/port/webkit.py:
1474         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1475         * Scripts/webkitpy/style/checkers/test_expectations.py:
1476         * Scripts/webkitpy/tool/commands/queries.py:
1477
1478 2010-12-10  John Knottenbelt  <jknotten@chromium.org>
1479
1480         Reviewed by Steve Block.
1481
1482         [Chromium] Implement mocks for client-based geolocation
1483         https://bugs.webkit.org/show_bug.cgi?id=46895
1484
1485         * DumpRenderTree/chromium/LayoutTestController.cpp:
1486         (LayoutTestController::setGeolocationPermission):
1487         (LayoutTestController::setMockGeolocationPosition):
1488         (LayoutTestController::setMockGeolocationError):
1489         * DumpRenderTree/chromium/LayoutTestController.h:
1490         * DumpRenderTree/chromium/WebViewHost.cpp:
1491         (WebViewHost::geolocationClient):
1492         (WebViewHost::geolocationClientMock):
1493         (WebViewHost::reset):
1494         * DumpRenderTree/chromium/WebViewHost.h:
1495
1496 2010-12-10  Alejandro G. Castro  <alex@igalia.com>
1497
1498         Reviewed by Martin Robinson.
1499
1500         [GTK] Add hasSpellingMarker support to the DRT
1501         https://bugs.webkit.org/show_bug.cgi?id=50739
1502
1503         Implemented the hasSpellingMarker to support spelling tests.
1504
1505         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1506         (LayoutTestController::hasSpellingMarker):
1507
1508 2010-12-10  Eric Seidel  <eric@webkit.org>
1509
1510         Reviewed by Ojan Vafai.
1511
1512         webkit-patch: not possible to use build-and-test with local commits
1513         https://bugs.webkit.org/show_bug.cgi?id=33378
1514
1515         Make --no-clean not even check if we have local commits.
1516         It's unclear to me why the code was originally written this way.
1517         I was unable to dig up a reason from svn history.
1518
1519         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
1520         * Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py: Copied from WebKitTools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.
1521
1522 2010-12-10  Mario Sanchez Prada  <msanchez@igalia.com>
1523
1524         Reviewed by Martin Robinson.
1525
1526         [GTK] AX: implement isEnabled in DRT
1527         https://bugs.webkit.org/show_bug.cgi?id=50814
1528
1529         Implement AccessibilityUIElement::isEnabled() for GTK.
1530
1531         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1532         (checkElementState): New function to refactor common code.
1533         (AccessibilityUIElement::isEnabled): Implement this by checking
1534         the current state of the AtkObject.
1535         (AccessibilityUIElement::isSelected): Use the new
1536         checkElementState function.
1537
1538 2010-12-10  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
1539
1540         Reviewed by Kenneth Rohde Christiansen.
1541
1542         [Qt][WK2] Add the QWKContext API class to wrap the WebContext.
1543         https://bugs.webkit.org/show_bug.cgi?id=50750
1544
1545         * MiniBrowser/qt/BrowserView.cpp:
1546         (BrowserView::BrowserView):
1547         * MiniBrowser/qt/BrowserView.h:
1548         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1549         (WTR::WebView::WebView):
1550
1551 2010-12-10  Joone Hur  <joone@kldp.org>
1552
1553         Reviewed by Xan Lopez.
1554
1555         [GTK] Unskipping some test cases in userscripts dependent on addUserStyleSheet
1556         https://bugs.webkit.org/show_bug.cgi?id=50808
1557
1558         Unskipping the following test cases:
1559         userscripts/mixed-case-stylesheet.html
1560         userscripts/simple-stylesheet.html
1561         userscripts/user-style-all-frames.html
1562
1563         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1564         (LayoutTestController::addUserStyleSheet):
1565
1566 2010-12-10  Joone Hur  <joone@kldp.org>
1567
1568         Reviewed by Eric Seidel.
1569
1570         [GTK] Add DRT support for pageProperty, isPageBoxVisible, pageSizeAndMarginsInPixels, and addUserStyleSheet
1571         https://bugs.webkit.org/show_bug.cgi?id=50783
1572
1573         This patch allows to unskip the following test cases:
1574         printing/page-rule-selection.html
1575         printing/page-format-data.html
1576
1577         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1578         (LayoutTestController::pageProperty): Added.
1579         (LayoutTestController::isPageBoxVisible): Ditto.
1580         (LayoutTestController::pageSizeAndMarginsInPixels): Ditto.
1581         (LayoutTestController::addUserStyleSheet): Ditto.
1582
1583 2010-12-10  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
1584
1585         Reviewed by Kenneth Rohde Christiansen.
1586
1587         [Qt] Make QtTestBrowser spawn QNAM in a secondary thread.
1588
1589         A menu allows to switch QNAM back to the same thread.
1590
1591         * QtTestBrowser/launcherwindow.cpp:
1592         (LauncherWindow::initializeView):
1593         (LauncherWindow::createChrome):
1594         (LauncherWindow::toggleThreadedQnam):
1595         * QtTestBrowser/launcherwindow.h:
1596         (WindowOptions::WindowOptions):
1597         * QtTestBrowser/webpage.cpp:
1598         (WebPage::WebPage):
1599         (WebPage::setQnamThreaded):
1600         * QtTestBrowser/webpage.h:
1601         (QnamThread::QnamThread):
1602         (QnamThread::~QnamThread):
1603         (QnamThread::networkAccessManager):
1604         (QnamThread::run):
1605
1606 2010-12-10  Martin Robinson  <mrobinson@igalia.com>
1607
1608         Reviewed by Xan Lopez.
1609
1610         [Gtk] style="font-family: courier" makes text disappear
1611         https://bugs.webkit.org/show_bug.cgi?id=47452
1612
1613         Add a test that verifies that fonts without valid charmaps are
1614         never selected.
1615
1616         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1617         (initializeFonts): Initialize DRT with our font (derived from Ahem)
1618         that has no valid charmap.
1619         * DumpRenderTree/gtk/fonts/FontWithNoValidEncoding.fon: Added.
1620         * DumpRenderTree/gtk/fonts/fonts.conf: Updated settings to override users'
1621         settings which may disable selection of bitmap fonts.
1622
1623 2010-12-10  Eric Seidel  <eric@webkit.org>
1624
1625         Unreviewed.
1626
1627         The commit-queue should file bugs about flaky tests it encounters
1628         https://bugs.webkit.org/show_bug.cgi?id=50803
1629
1630         create_bug_for_flaky_test was insufficiently tested, thus buggy.
1631         Now it's tested.
1632
1633         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1634         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1635
1636 2010-12-10  Eric Seidel  <eric@webkit.org>
1637
1638         Unreviewed.  Somehow this last-minute edit didn't quite get committed.
1639
1640         The commit-queue should file bugs about flaky tests it encounters
1641         https://bugs.webkit.org/show_bug.cgi?id=50803
1642
1643         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1644
1645 2010-12-09  Eric Seidel  <eric@webkit.org>
1646
1647         Reviewed by Adam Barth.
1648
1649         The commit-queue should file bugs about flaky tests it encounters
1650         https://bugs.webkit.org/show_bug.cgi?id=50803
1651
1652         This change got a bit big.  I also added a new config.urls file
1653         because I needed to share the view_source_url code with committervalidator.py.
1654
1655         This adds a new class FlakyTestReporter which holds all the logic about
1656         reporting flaky tests to bugzilla.
1657
1658         Right now this code knows how to look up bugs for flaky tests.
1659         If it can't find a bug filed from the commit-queue, it will open a new
1660         one, ccing the relevant people and adding information about the failure.
1661
1662         It is not yet smart enough to chase down duplicate chains, or to include
1663         the actual failure diff.  But those can be added in later iterations.
1664
1665         * Scripts/webkitpy/common/checkout/api.py:
1666         * Scripts/webkitpy/common/checkout/changelog.py:
1667         * Scripts/webkitpy/common/checkout/commitinfo.py:
1668         * Scripts/webkitpy/common/config/committervalidator.py:
1669         * Scripts/webkitpy/common/config/urls.py: Copied from WebKitTools/Scripts/webkitpy/tool/comments.py.
1670         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1671         * Scripts/webkitpy/tool/bot/flakytestreporter.py: Added.
1672         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py: Copied from WebKitTools/Scripts/webkitpy/tool/comments.py.
1673         * Scripts/webkitpy/tool/bot/irc_command.py:
1674         * Scripts/webkitpy/tool/bot/sheriff.py:
1675         * Scripts/webkitpy/tool/commands/download.py:
1676         * Scripts/webkitpy/tool/commands/queues.py:
1677         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1678         * Scripts/webkitpy/tool/comments.py:
1679         * Scripts/webkitpy/tool/mocktool.py:
1680         * Scripts/webkitpy/tool/steps/commit.py:
1681
1682 2010-12-09  Eric Seidel  <eric@webkit.org>
1683
1684         Reviewed by Adam Barth.
1685
1686         Teach webkit-patch how to search bugzilla
1687         https://bugs.webkit.org/show_bug.cgi?id=50500
1688
1689         This is a step towards teaching webkitpy how to file
1690         new bugs for flaky tests and update them when new flakes occur.
1691
1692         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1693         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
1694         * Scripts/webkitpy/tool/commands/__init__.py:
1695         * Scripts/webkitpy/tool/commands/bugsearch.py: Added.
1696
1697 2010-12-09  Adam Barth  <abarth@webkit.org>
1698
1699         Reviewed by Ojan Vafai.
1700
1701         commit-queue errors out due to local commits
1702         https://bugs.webkit.org/show_bug.cgi?id=50766
1703
1704         We seem to be tripping over having local commits in the working copy a
1705         lot recently.  I don't quite fully understand what the issue is, but
1706         this patch attempts to solve the problem by adding an explicit clean
1707         step before processing a patch.  Previously, we did the cleaning as
1708         part of the apply-attachment step, so this might not actually fix the
1709         problem.
1710
1711         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1712         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1713         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1714
1715 2010-12-09  Dirk Pranke  <dpranke@chromium.org>
1716
1717         Reviewed by Ojan Vafai.
1718
1719         Make new-run-webkit-tests --lint-test-files log slightly better
1720         messages and return -1 if lint fails. Remove the
1721         'suppress_errors' keyword param to the TestExpectationsFile
1722         class, and clean up logging and exception raising for error
1723         handling. Also add more unit tests and clean up the unit test code a bit.
1724
1725         https://bugs.webkit.org/show_bug.cgi?id=50205
1726
1727         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1728         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1729         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py
1730         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py
1731         * Scripts/webkitpy/layout_tests/port/chromium.py:
1732         * Scripts/webkitpy/style/checkers/test_expectations.py:
1733         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1734
1735 2010-12-09  Tony Chang  <tony@chromium.org>
1736
1737         Unreviewed, fix for windows code.  We were catching the wrong
1738         exception in Windows.
1739
1740         * Scripts/webkitpy/common/system/filesystem.py:
1741
1742 2010-12-09  Antonio Gomes  <agomes@rim.com>
1743
1744         Reviewed by Martin Robinson.
1745
1746         [Gtk] Populate DumpRenderTreeSupportGtk (part IV)
1747         https://bugs.webkit.org/show_bug.cgi?id=48429
1748
1749         Adjust call sites of webkit_thread_count to use the DumpRenderTreeSupportGtk version now.
1750
1751         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1752         (LayoutTestController::workerThreadCount):
1753
1754 2010-12-06  Philippe Normand  <pnormand@igalia.com>
1755
1756         Reviewed by Martin Robinson.
1757
1758         [GTK] Support the Mozilla-style Fullscreen Javascript API
1759         https://bugs.webkit.org/show_bug.cgi?id=50572
1760
1761         Enable the Javascript Fullscreen support in the GtkLauncher. Also
1762         make DRT update the Chrome when the WebView settings have been
1763         reset to consistent values.
1764
1765         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1766         (resetDefaultsToConsistentValues):
1767         * GtkLauncher/main.c:
1768         (create_window):
1769         * Scripts/build-webkit:
1770
1771 2010-12-09  Koan-Sin Tan  <koansin.tan@gmail.com>
1772
1773         Reviewed by Tor Arne Vestbø
1774
1775         [Qt] run-launcher doesn't start the browser on Mac OS X 10.6
1776         https://bugs.webkit.org/show_bug.cgi?id=50742
1777
1778         check not only QtWebKit.framework/QtWebKit but also libQtWebKit.dylib
1779
1780         * Scripts/webkitdirs.pm:
1781
1782 2010-12-09  Joone Hur  <joone@kldp.org>
1783
1784          Reviewed by Martin Robinson.
1785
1786          [GTK] Support for viewport meta tag
1787          https://bugs.webkit.org/show_bug.cgi?id=45443
1788
1789          Add support for testing the viewport properties for WebKitGtk.
1790
1791          * DumpRenderTree/LayoutTestController.cpp:
1792          (dumpConfigurationForViewportCallback): Added this JS callback to set the size of the visible viewport.
1793          (LayoutTestController::staticFunctions):
1794          * DumpRenderTree/LayoutTestController.h:
1795          * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1796          (LayoutTestController::dumpConfigurationForViewport): Added this function to test the viewport properties.
1797          * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1798          (LayoutTestController::dumpConfigurationForViewport): Ditto.
1799          * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1800          (LayoutTestController::dumpConfigurationForViewport): Ditto.
1801          * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1802          (LayoutTestController::dumpConfigurationForViewport): Ditto.
1803          * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1804          (LayoutTestController::dumpConfigurationForViewport): Ditto.
1805
1806 2010-12-08  William Siegrist <wsiegrist@apple.com>
1807
1808         Reviewed by Eric Seidel.
1809
1810         Migrate buildbot.py from xmlrpc to json.
1811         https://bugs.webkit.org/show_bug.cgi?id=50647
1812
1813         * Scripts/webkitpy/common/net/buildbot.py:
1814
1815 2010-12-08  Tony Chang  <tony@chromium.org>
1816
1817         Reviewed by Eric Seidel.
1818
1819         make starting the websocket server more reliable on windows
1820         https://bugs.webkit.org/show_bug.cgi?id=50712
1821
1822         * Scripts/webkitpy/common/system/filesystem.py:
1823         (remove): Substitute method for os.remove to retry on error on Windows
1824         * Scripts/webkitpy/common/system/filesystem_unittest.py:
1825         * Scripts/webkitpy/layout_tests/port/http_server_base.py: Use FileSystem.remove
1826
1827 2010-12-08  Jessie Berlin  <jberlin@apple.com>
1828
1829         Reviewed by Adam Roben.
1830
1831         WebKit2: Implement WebChromeClient::exceededDatabaseQuota
1832         https://bugs.webkit.org/show_bug.cgi?id=50656
1833
1834         * MiniBrowser/mac/BrowserWindowController.m:
1835         (-[BrowserWindowController awakeFromNib]):
1836         Indicate that exceededDatabaseQuota is not implemented.
1837         * MiniBrowser/win/BrowserView.cpp:
1838         (BrowserView::create):
1839         Ditto.
1840         * WebKitTestRunner/TestController.cpp:
1841         (WTR::createOtherPage):
1842         Ditto.
1843         (WTR::TestController::initialize):
1844         Ditto.
1845
1846 2010-12-08  Antonio Gomes  <agomes@rim.com>
1847
1848         Reviewed by Martin Robinson.
1849
1850         [Gtk] Populate DumpRenderTreeSupportGtk (part III)
1851         https://bugs.webkit.org/show_bug.cgi?id=48429
1852
1853         Moved the following methods from webkitprivate.h to DumpRenderTreeSupportGtk.cpp|h:
1854         * webkit_gc_collect_javascript_objects;
1855         * webkit_gc_collect_javascript_objects_on_alternate_thread;
1856         * webkit_gc_count_javascript_objects;
1857         * webkit_web_frame_layout.
1858
1859         These were all only used by GTK+ DRT.
1860
1861         * DumpRenderTree/gtk/EventSender.cpp:
1862         (dispatchEvent):
1863         * DumpRenderTree/gtk/GCControllerGtk.cpp:
1864         (GCController::collect):
1865         (GCController::collectOnAlternateThread):
1866         (GCController::getJSObjectCount):
1867
1868 2010-12-07  Tony Chang  <tony@chromium.org>
1869
1870         Reviewed by Ojan Vafai.
1871
1872         [chromium] force NRWT to use DRT
1873         https://bugs.webkit.org/show_bug.cgi?id=50359
1874
1875         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1876
1877 2010-12-06  Sam Weinig  <sam@webkit.org>
1878
1879         Reviewed by Anders Carlsson.
1880
1881         Generalize didChangeLocationWithinPageForFrame for all same document navigations
1882         https://bugs.webkit.org/show_bug.cgi?id=50584
1883
1884         * MiniBrowser/mac/BrowserWindowController.m:
1885         (didSameDocumentNavigationForFrame):
1886         (-[BrowserWindowController awakeFromNib]):
1887         (-[BrowserWindowController didSameDocumentNavigationForFrame:]):
1888         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
1889         (TestWebKitAPI::didSameDocumentNavigationForFrame):
1890         (TestWebKitAPI::TEST):
1891         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1892         (WTR::InjectedBundlePage::InjectedBundlePage):
1893         (WTR::InjectedBundlePage::didSameDocumentNavigationForFrame):
1894         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1895         * WebKitTestRunner/TestController.cpp:
1896         (WTR::TestController::initialize):
1897
1898 2010-12-06  Kinuko Yasuda  <kinuko@chromium.org>
1899
1900         Reviewed by Ojan Vafai.
1901
1902         Make TestResultsServer return 404 for non-existing results files.
1903         https://bugs.webkit.org/show_bug.cgi?id=50581
1904
1905         * TestResultServer/handlers/testfilehandler.py:
1906
1907 2010-12-06  Tony Chang  <tony@chromium.org>
1908
1909         Reviewed by Ojan Vafai.
1910
1911         [chromium] fix an assert hit in DRT
1912         https://bugs.webkit.org/show_bug.cgi?id=50575
1913
1914         This class uses WTF's RefPtr, but expects chrome's base::RefPtr
1915         semantics.
1916
1917         Otherwise, we hit ASSERTION FAILED: !m_adoptionIsRequired
1918         (third_party/WebKit/JavaScriptCore/wtf/RefCounted.h:37 void
1919         WTF::RefCountedBase::ref()).
1920
1921         * DumpRenderTree/chromium/TestWebWorker.h:
1922         (TestWebWorker::TestWebWorker):
1923
1924 2010-12-02  Ojan Vafai  <ojan@chromium.org>
1925
1926         Reviewed by Eric Seidel.
1927
1928         make webkit-patch command work when the git branch is not synced to the remote svn branch
1929         https://bugs.webkit.org/show_bug.cgi?id=50424
1930
1931         * Scripts/webkitpy/common/checkout/scm.py:
1932         * Scripts/webkitpy/common/checkout/scm_unittest.py:
1933
1934 2010-12-06  Patrick Gansterer  <paroga@webkit.org>
1935
1936         Reviewed by Andreas Kling.
1937
1938         [WINCE] Add build system
1939         https://bugs.webkit.org/show_bug.cgi?id=50522
1940
1941         * CMakeListsWinCE.txt: Added.
1942
1943 2010-12-03  Mihai Parparita  <mihaip@chromium.org>
1944
1945         Reviewed by Tony Chang.
1946
1947         Allow the Chromium port to have Leopard-specific baselines
1948         https://bugs.webkit.org/show_bug.cgi?id=50506
1949
1950         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1951
1952 2010-12-03  Tony Chang  <tony@chromium.org>
1953
1954         Reviewed by Kent Tamura.
1955
1956         [chromium] fix 2 bugs with inspector tests in DRT
1957         https://bugs.webkit.org/show_bug.cgi?id=50492
1958
1959         Tasks can outlive the tasklist (even when canceled) so this was
1960         causing a crash when ~WebTask() ran.  Avoid this by unregistering
1961         when a task is canceled.
1962
1963         Also fix an assert when closing devtool windows by copying some
1964         logic from test_shell.
1965
1966         * DumpRenderTree/chromium/Task.cpp:
1967         (WebTask::~WebTask):
1968         (TaskList::revokeAll):
1969         * DumpRenderTree/chromium/Task.h: Canceling a task now removes it from
1970             the tasklist (since the task can outlive the tasklist).
1971         * DumpRenderTree/chromium/TestShell.h:
1972         (TestShell::devToolsWebView):
1973         * DumpRenderTree/chromium/WebViewHost.cpp:
1974         (WebViewHost::~WebViewHost): Don't load about:blank when closing
1975             a window if the window has devtools loaded.  This avoids an
1976             ASSERT and matches test_shell.
1977
1978 2010-12-06  Alejandro G. Castro  <alex@igalia.com>
1979
1980         Reviewed by Martin Robinson.
1981
1982         [GTK] Fix GtkLauncher.c style, use webkit style
1983         https://bugs.webkit.org/show_bug.cgi?id=50542
1984
1985         * GtkLauncher/main.c:
1986         (activateUriEntryCb):
1987         (updateTitle):
1988         (linkHoverCb):
1989         (notifyTitleCb):
1990         (notifyLoadStatusCb):
1991         (notifyProgressCb):
1992         (destroyCb):
1993         (goBackCb):
1994         (goForwardCb):
1995         (create_webViewCb):
1996         (webViewReadyCb):
1997         (closeWebViewCb):
1998         (createBrowser):
1999         (createStatusbar):
2000         (createToolbar):
2001         (createWindow):
2002         (main):
2003
2004 2010-12-04  Antonio Gomes  <agomes@rim.com>
2005
2006         Reviewed by Martin Robinson.
2007
2008         [Gtk] Populate DumpRenderTreeSupportGtk (Part II)
2009         https://bugs.webkit.org/show_bug.cgi?id=48429
2010
2011         Moved more private method declared with WEBKIT_API to
2012         DumpRenderTreeSupportGtk, since they were only being used by DRT.
2013
2014         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2015         (resetDefaultsToConsistentValues):
2016         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2017         (LayoutTestController::addOriginAccessWhitelistEntry):
2018         (LayoutTestController::execCommand):
2019         (LayoutTestController::isCommandEnabled):
2020
2021 2010-12-04  Antonio Gomes  <agomes@rim.com>
2022
2023         Reviewed by Andreas Kling.
2024
2025         Removed extern webkit_web_view_set_group_name from gtk/DumpRenderTree.cpp
2026
2027         Method was removed by http://trac.webkit.org/changeset/71604
2028
2029         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2030
2031 2010-12-05  Alejandro G. Castro  <alex@igalia.com>
2032
2033         Reviewed by Xan Lopez.
2034
2035         [GTK] Fix compilation warnings reported by clang
2036         https://bugs.webkit.org/show_bug.cgi?id=50252
2037
2038         * GtkLauncher/main.c:
2039         (create_window): The create_statusbar function does not have
2040         parameters.
2041
2042 2010-12-05  Robert Hogan  <robert@webkit.org>
2043
2044         Reviewed by Andreas Kling.
2045
2046         [Qt] Zero-sized font does not yet work
2047
2048         Fix fast/text/font-size-zero.html
2049
2050         Copy other ports by setting minimumFontSize to 0 for DRT runs.
2051
2052         https://bugs.webkit.org/show_bug.cgi?id=49759
2053
2054         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2055         (WebCore::WebPage::WebPage):
2056
2057 2010-12-04  Sam Weinig  <sam@webkit.org>
2058
2059         Reviewed by Jon Honeycutt.
2060
2061         WebKit2: Need client functions to notify app when the url changes due to a fragment navigation
2062         https://bugs.webkit.org/show_bug.cgi?id=50511
2063
2064         Update tools for new didChangeLocationWithinPageForFrame client function (and changed bundle
2065         signature) and added a test for the functionality (PageLoadDidChangeLocationWithinPageForFrame.cpp)
2066
2067         * MiniBrowser/mac/BrowserWindowController.m:
2068         (didChangeLocationWithinPageForFrame):
2069         (-[BrowserWindowController awakeFromNib]):
2070         (-[BrowserWindowController didChangeLocationWithinPageForFrame:]):
2071         * TestWebKitAPI/PlatformUtilities.cpp:
2072         (TestWebKitAPI::Util::toWK):
2073         * TestWebKitAPI/PlatformUtilities.h:
2074         (TestWebKitAPI::Util::adoptWK):
2075         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2076         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp: Added.
2077         (TestWebKitAPI::nullJavaScriptCallback):
2078         (TestWebKitAPI::didFinishLoadForFrame):
2079         (TestWebKitAPI::didChangeLocationWithinPageForFrame):
2080         (TestWebKitAPI::TEST):
2081         * TestWebKitAPI/Tests/WebKit2/file-with-anchor.html: Added.
2082         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2083         * TestWebKitAPI/win/copy-resources.cmd:
2084         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2085         (WTR::InjectedBundlePage::InjectedBundlePage):
2086         (WTR::InjectedBundlePage::didChangeLocationWithinPageForFrame):
2087         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2088         * WebKitTestRunner/TestController.cpp:
2089         (WTR::TestController::initialize):
2090
2091 2010-11-08  Antonio Gomes  <agomes@rim.com>
2092
2093         Reviewed by Martin Robinson.
2094
2095         [Gtk] Populate DumpRenderTreeSupportGtk
2096         https://bugs.webkit.org/show_bug.cgi?id=48429
2097
2098         Made the previous calls to webkit_web_frame* functions defined as private
2099         APIs in webkitprivate.h go through DRTSupportGtk.
2100
2101         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
2102         (AccessibilityController::focusedElement):
2103         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2104         (dumpFramesAsText):
2105         (resetDefaultsToConsistentValues):
2106         (dump):
2107         (webViewDocumentLoadFinished):
2108         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2109         (LayoutTestController::counterValueForElementById):
2110         (LayoutTestController::pageNumberForElementById):
2111         (LayoutTestController::numberOfPages):
2112         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
2113         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
2114         (LayoutTestController::sampleSVGAnimationForElementAtTime):
2115         (LayoutTestController::numberOfActiveAnimations):
2116         (LayoutTestController::suspendAnimations):
2117         (LayoutTestController::resumeAnimations):
2118         (LayoutTestController::markerTextForListItem):
2119
2120 2010-12-03  Mihai Parparita  <mihaip@chromium.org>
2121
2122         Reviewed by Tony Chang.
2123
2124         Rebaseline server: use pretty text diff output
2125         https://bugs.webkit.org/show_bug.cgi?id=50484
2126         
2127         Serve *-pretty-diff.html for text diff output.
2128
2129         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
2130         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
2131         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
2132         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
2133
2134 2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
2135
2136         Unreviewed, rolling out r73302.
2137         http://trac.webkit.org/changeset/73302
2138         https://bugs.webkit.org/show_bug.cgi?id=50499
2139
2140         Causes crashes in debug LayoutTests (Requested by xan_ on
2141         #webkit).
2142
2143         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
2144         (AccessibilityUIElement::AccessibilityUIElement):
2145         (AccessibilityUIElement::parentElementCallback):
2146         * DumpRenderTree/chromium/AccessibilityUIElement.h:
2147         * DumpRenderTree/chromium/CppBoundClass.cpp:
2148         * DumpRenderTree/chromium/CppBoundClass.h:
2149
2150 2010-12-03  Sam Weinig  <sam@webkit.org>
2151
2152         Reviewed by Maciej Stachowiak.
2153
2154         Enable <a ping> for Mac/Windows/WebKit2 builds
2155         <rdar://problem/8504473>
2156         https://bugs.webkit.org/show_bug.cgi?id=50488
2157
2158         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
2159         (TestWebKitAPI::TEST): Test that the default value of
2160         WKPreferencesGetHyperlinkAuditingEnabled is true.
2161
2162 2010-12-03  Chris Guillory  <chris.guillory@google.com>
2163
2164         Reviewed by Chris Fleizach.
2165
2166         Include the FrameView widget of a RenderWidget in the accessibility tree.
2167         https://bugs.webkit.org/show_bug.cgi?id=49106
2168
2169         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
2170         (AccessibilityUIElement::AccessibilityUIElement):
2171         (AccessibilityUIElement::parentElementCallback):
2172         (AccessibilityUIElement::isEqualCallback):
2173         * DumpRenderTree/chromium/AccessibilityUIElement.h:
2174         * DumpRenderTree/chromium/CppBoundClass.cpp:
2175         (CppBoundClass::getFromCppVariant):
2176         * DumpRenderTree/chromium/CppBoundClass.h:
2177
2178 2010-12-03  Mihai Parparita  <mihaip@chromium.org>
2179
2180         Reviewed by Tony Chang.
2181
2182         Rebaseline server: organize tests by state, add dry run mode
2183         https://bugs.webkit.org/show_bug.cgi?id=50473
2184         
2185         Group tests in the menu by state, so that it's easier to see after
2186         processing the queue which failed.
2187         
2188         Add support for the --dry-run flag so that it's easier to test changes
2189         such as this (stubs out filesystem and SCM operations).
2190
2191         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
2192         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js:
2193         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
2194
2195 2010-12-03  Brady Eidson  <beidson@apple.com>
2196
2197         Reviewed by Anders Carlsson.
2198
2199         Groundwork for <rdar://problem/7660733> and https://bugs.webkit.org/show_bug.cgi?id=50191
2200         WebKit2 Authentication Support
2201
2202         Keep these builds working:
2203         * MiniBrowser/mac/BrowserWindowController.m:
2204         (-[BrowserWindowController awakeFromNib]):
2205
2206         * WebKitTestRunner/TestController.cpp:
2207         (WTR::TestController::initialize):
2208
2209 2010-12-02  Mihai Parparita  <mihaip@chromium.org>
2210
2211         Reviewed by Tony Chang.
2212
2213         Rebaseline server: move existing baselines
2214         https://bugs.webkit.org/show_bug.cgi?id=50421
2215         
2216         Implement moving of existing baselines: move all files that are about
2217         to be overwriten by update baselines.
2218         
2219         Also fix a typo in the UI JS.
2220
2221         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js:
2222         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
2223         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py:
2224
2225 2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
2226
2227         Unreviewed, rolling out r73211.
2228         http://trac.webkit.org/changeset/73211
2229         https://bugs.webkit.org/show_bug.cgi?id=50450
2230
2231         Broke Chromium's "Webkit Win (dbg)(2)" bot. (Requested by
2232         yutak on #webkit).
2233
2234         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2235
2236 2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
2237
2238         Unreviewed, rolling out r73222.
2239         http://trac.webkit.org/changeset/73222
2240         https://bugs.webkit.org/show_bug.cgi?id=50449
2241
2242         r73211 seemed to break Chromium's "Webkit Win (dbg)(2)" bot.
2243         (Requested by yutak on #webkit).
2244
2245         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2246         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
2247         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
2248         * Scripts/webkitpy/layout_tests/port/base.py:
2249         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2250         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2251
2252 2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
2253
2254         Unreviewed, rolling out r73228.
2255         http://trac.webkit.org/changeset/73228
2256         https://bugs.webkit.org/show_bug.cgi?id=50448
2257
2258         r73211 seemed to break Chromium's "Webkit Win (dbg)(2)" bot.
2259         (Requested by yutak on #webkit).
2260
2261         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2262         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
2263         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
2264         * Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py:
2265         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
2266
2267 2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
2268
2269         Unreviewed, rolling out r73231.
2270         http://trac.webkit.org/changeset/73231
2271         https://bugs.webkit.org/show_bug.cgi?id=50443
2272
2273         r73211 seemed to broke Chromium's "Webkit Win (dbg)(2)" bot.
2274         (Requested by yutak on #webkit).
2275
2276         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
2277         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
2278         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2279         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2280
2281 2010-12-03  David Levin  <levin@chromium.org>
2282
2283         Reviewed by Shinichiro Hamaji.
2284
2285         check-webkit-style: false positive reported for #if macro
2286         https://bugs.webkit.org/show_bug.cgi?id=48242
2287
2288         * Scripts/webkitpy/style/checkers/cpp.py: Adjusted check to avoid
2289           all preprocessor commands.
2290         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added test.
2291
2292 2010-12-02  Eric Seidel  <eric@webkit.org>
2293
2294         Reviewed by Adam Barth.
2295
2296         Update the EWSTools scripts to use modern-style git repos
2297         https://bugs.webkit.org/show_bug.cgi?id=50402
2298
2299         * EWSTools/create-webkit-git:
2300         * EWSTools/start-commit-queue.sh:
2301         * EWSTools/start-queue.sh:
2302
2303 2010-12-02  Simon Fraser  <simon.fraser@apple.com>
2304
2305         Fix Chromium Linux plugin tests by not logging
2306         unconditionally from the event handling code.
2307
2308         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2309         (handleEventX11):
2310
2311 2010-12-02  Dirk Pranke  <dpranke@chromium.org>
2312
2313         Reviewed by Tony Chang.
2314
2315         nrwt multiprocessing - move logic back into run_webkit_tests
2316
2317         This change moves a bunch of logic that I had put into
2318         message_broker back into run_webkit_tests, in a slightly
2319         different format. WorkerMessageBroker needed to become less aware of
2320         the logic the TestRunner class uses, and more generic.
2321         Eventually the MessageBroker will only do generic messaging and
2322         thread/process-pooling, and (almost) all of the
2323         run-webkit-tests-specific logic will be moved to
2324         run_webkit_tests.py and dump_render_tree_thread.py.
2325         
2326         The biggest changes are that the Broker can now start a single
2327         worker, but the responsibility for starting all of them is pushed
2328         back to the TestRunner (Manager), and the logic for checking if
2329         the threads are done or wedged is moved back to TestRunner. We
2330         also remove WorkerMessageBroker.cleanup (not needed) and
2331         cancel_workers (they have to be cancelled individually).
2332         
2333         The  message_broker is now encapsulated inside
2334         TestRunner._run_tests(); it only needs to exist while actually
2335         running the tests.
2336
2337         Also, delete a bunch of tests in message_broker_unittest that no
2338         longer make much sense.
2339
2340         This patch depends on bug 50372.
2341
2342         https://bugs.webkit.org/show_bug.cgi?id=50374
2343
2344         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2345         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
2346         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
2347         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2348         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2349
2350 2010-12-02  Hayato Ito  <hayato@chromium.org>
2351
2352         Reviewed by Eric Seidel.
2353
2354         Refactor test_types's compare_output() method so that it takes a
2355         TestInput object.
2356
2357         compare_output() will need additional information included in a TestInput
2358         object to support reftests. This change is a pre-requirement of that.
2359
2360         https://bugs.webkit.org/show_bug.cgi?id=50362
2361
2362         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2363         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
2364         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
2365         * Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py:
2366         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
2367
2368 2010-12-02  Simon Fraser  <simon.fraser@apple.com>
2369
2370         Reviewed by Anders Carlsson.
2371
2372         Add the ability to run script on 'new' and 'paint' in the test plugin
2373         https://bugs.webkit.org/show_bug.cgi?id=50425
2374         
2375         Add "onnew" and "onpaintevent" attributes to the test plugin,
2376         so that tests can run JS at these times.
2377
2378         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
2379         (pluginAllocate):
2380         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
2381         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2382         (NPP_New):
2383         (NPP_Destroy):
2384         (handleEventCarbon):
2385         (handleEventCocoa):
2386         (NPP_HandleEvent):
2387
2388 2010-12-02  Sam Weinig  <sam@webkit.org>
2389
2390         Fix Qt build.
2391
2392         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2393         (WTR::PlatformWebView::PlatformWebView):
2394
2395 2010-12-02  Sam Weinig  <sam@webkit.org>
2396
2397         Reviewed by Anders Carlsson.
2398
2399         WebKit2 Preferences should be held off the PageGroup, not the Context
2400         https://bugs.webkit.org/show_bug.cgi?id=50414
2401
2402         Update for API changes.
2403
2404         * WebKitTestRunner/PlatformWebView.h:
2405         * WebKitTestRunner/TestController.cpp:
2406         (WTR::createOtherPage):
2407         (WTR::TestController::initialize):
2408         (WTR::TestController::resetStateToConsistentValues):
2409         * WebKitTestRunner/TestController.h:
2410         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2411         (WTR::PlatformWebView::PlatformWebView):
2412         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2413         (WTR::PlatformWebView::PlatformWebView):
2414
2415 2010-12-02  Dirk Pranke  <dpranke@chromium.org>
2416
2417         Reviewed by Tony Chang.
2418
2419         new-run-webkit-tests: minor cleanup for multiprocessing work
2420
2421         This change:
2422         * moves worker naming into TestShellThread, eliminating a
2423           parameter to the constructor and putting the responsibility in
2424           the correct place.
2425         * eliminates the _WorkerState() class in message_broker, because
2426           it turns out that state really needs to be in run_webkit_tests
2427         * renames the Broker classes to be module-private.
2428         * fixes a bunch of minor commenting and whitespace issues to
2429           make subsequent patches a bit clearer.
2430         * Adds a Port hook for default_worker_model() so that we can
2431           accomodate the potential for different worker models on
2432           different ports.
2433         * merge in the fix from 50420 for the brokenness introduced in
2434           bug 50367.
2435
2436         This patch depends on bug 50367.
2437
2438         https://bugs.webkit.org/show_bug.cgi?id=50372
2439
2440         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2441         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
2442         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
2443         * Scripts/webkitpy/layout_tests/port/base.py:
2444         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2445         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2446
2447 2010-12-02  Dirk Pranke  <dpranke@chromium.org>
2448
2449         Reviewed by Tony Chang.
2450
2451         This change is a bunch of cleanup / refactoring of the file
2452         below. It moves a bunch of free functions to methods on the
2453         TestShellThread class, and restructures other methods to be
2454         closer to the structure we'll need for the multiprocessing
2455         rewrite.
2456
2457         It also makes the logic of --run-singly a *lot* easier to follow
2458         by nestling all of the separate-thread logic into a single
2459         routine.
2460
2461         There should be no semantic changes in this patch, just cleanup.
2462
2463         https://bugs.webkit.org/show_bug.cgi?id=50367
2464
2465         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2466
2467 2010-12-02  Tony Chang  <tony@chromium.org>
2468
2469         Unreviewed, rolling out r73164.
2470         http://trac.webkit.org/changeset/73164
2471         https://bugs.webkit.org/show_bug.cgi?id=50359
2472
2473         broke debugger tests on win
2474
2475         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2476
2477 2010-11-30  Mihai Parparita  <mihaip@chromium.org>
2478
2479         Reviewed by Tony Chang.
2480
2481         Rebaseline server: add updating of baselines
2482         https://bugs.webkit.org/show_bug.cgi?id=50305
2483         
2484         Implements updating of baselines, where we copy -actual.* files over
2485         the current -expected.* files. To do this, we need a
2486         _get_actual_result_files method to get test results files and a
2487         _rebaseline_test method to actually do the file copy and SCM operation.
2488         _rebaseline_test logs output into a buffer, this is useful for both
2489         showing result in the UI and for unit tests.
2490         
2491         To make passing around of the various test environment properties
2492         (results directory, filesystem, SCM, etc) easier, add a TestConfig
2493         class for them.
2494         
2495         Moving of existing baselines is not implemented yet, this patch is big
2496         enough as it is.
2497
2498         * Scripts/webkitpy/common/system/filesystem.py:
2499         * Scripts/webkitpy/common/system/filesystem_mock.py:
2500         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js:
2501         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
2502         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py:
2503         * Scripts/webkitpy/tool/mocktool.py:
2504
2505 2010-12-02  Brent Fulgham  <bfulgham@webkit.org>
2506
2507         Unreviewed build fix after vcproj updates.
2508
2509         * DumpRenderTree/win/DumpRenderTreeCairo.vsprops: Make sure
2510         that WIN_CAIRO is defined for this build.
2511         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd: Update file
2512         to reflect new 'Debug_Cairo_CFLite' and 'Release_Cairo_CFLite'
2513         (these were previously 'Debug_Cairo' and 'Release_Cairo'
2514
2515 2010-12-02  Sam Weinig  <sam@webkit.org>
2516
2517         Reviewed by Anders Carlsson.
2518
2519         WebKit2 needs API to turn on popup blocking
2520         https://bugs.webkit.org/show_bug.cgi?id=50407
2521
2522         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
2523         (TestWebKitAPI::TEST):
2524         * WebKitTestRunner/TestController.cpp:
2525         (WTR::TestController::resetStateToConsistentValues):
2526
2527 2010-12-01  Tony Chang  <tony@chromium.org>
2528
2529         Reviewed by Ojan Vafai.
2530
2531         [chromium] force NRWT to use DRT
2532         https://bugs.webkit.org/show_bug.cgi?id=50359
2533
2534         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2535
2536 2010-12-02  Martin Robinson  <mrobinson@igalia.com>
2537
2538         Reviewed by Xan Lopez.
2539
2540         [GTK] DumpRenderTree has two copies of JavaScriptCore
2541         https://bugs.webkit.org/show_bug.cgi?id=49877
2542
2543         * GNUmakefile.am: Remove the second copy of JavaScriptCore from the
2544         LDADD list for DumpRenderTree.
2545
2546 2010-12-02  Sergio Villar Senin  <svillar@igalia.com>
2547
2548         Unreviewed: Added myself to list of Committers.
2549
2550         * Scripts/webkitpy/common/config/committers.py:
2551
2552 2010-12-01  Mihai Parparita  <mihaip@chromium.org>
2553
2554         Reviewed by Adam Barth.
2555
2556         build-webkit --chromium always updates DEPS and re-generates project files
2557         https://bugs.webkit.org/show_bug.cgi?id=50340
2558         
2559         Make build-webkit --chromium invoke update-webkit-chromium only when
2560         --update-chromium is passed in, so that we don't add 20 seconds to all
2561         builds.
2562         
2563         Making all invocations update was added with r61883, with the goal of
2564         making EWS bots always update. The bots will switch to using this flag
2565         (as will all other webkit-patch build steps) so nothing should change
2566         for them.
2567
2568         * Scripts/webkitdirs.pm:
2569         * Scripts/webkitpy/common/config/ports.py:
2570         * Scripts/webkitpy/common/config/ports_unittest.py:
2571
2572 2010-12-01  Dirk Pranke  <dpranke@chromium.org>
2573
2574         Reviewed by Tony Chang.
2575
2576         new-run-webkit-tests: add a --dry-run / -n flag
2577         https://bugs.webkit.org/show_bug.cgi?id=50045
2578
2579         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2580         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2581
2582 2010-12-01  Steve Falkenburg  <sfalken@apple.com>
2583
2584         Reviewed by Adam Roben.
2585
2586         WinCairo build should not use link-time code generation (LTCG)
2587         https://bugs.webkit.org/show_bug.cgi?id=50353
2588
2589         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2590         * DumpRenderTree/win/DumpRenderTree.vcproj:
2591         * DumpRenderTree/win/ImageDiff.vcproj:
2592         * FindSafari/FindSafari.vcproj:
2593         * MiniBrowser/MiniBrowser.vcproj:
2594         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2595         * WebKitAPITest/WebKitAPITest.vcproj:
2596         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
2597         * WebKitTestRunner/win/InjectedBundle.vcproj:
2598         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
2599         * WinLauncher/WinLauncher.vcproj:
2600         * record-memory-win/record-memory-win.vcproj:
2601
2602 2010-12-01  Martin Robinson  <mrobinson@igalia.com>
2603
2604         Touch GetUserAgentWithNullNPPFromNPPNew.cpp in an effort to force
2605         a rebuild of TestNetscapePlugin.la on GTK+. It seems that simply
2606         adding the file to the sources list was not enough to force the rebuild.
2607
2608         * DumpRenderTree/TestNetscapePlugIn/Tests/GetUserAgentWithNullNPPFromNPPNew.cpp:
2609         Remove an empty line at the end of this file to force a rebuild.
2610
2611 2010-12-01  Sam Weinig  <sam@webkit.org>
2612
2613         Fix windows build.
2614
2615         * MiniBrowser/win/BrowserView.cpp:
2616         (BrowserView::create):
2617
2618 2010-12-01  Martin Robinson  <mrobinson@igalia.com>
2619
2620         Add missing file to the TestNetscapePlugin sources list after r73057.
2621
2622         * GNUmakefile.am: Add missing file.
2623
2624 2010-12-01  Sam Weinig  <sam@webkit.org>
2625
2626         Reviewed by Anders Carlsson.
2627
2628         Add PageGrouping to WebKit2 API
2629         https://bugs.webkit.org/show_bug.cgi?id=50332
2630
2631         - Update testing harnesses to deal with new PageGroup API.
2632
2633         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
2634         (WKBundleInitialize):
2635         * TestWebKitAPI/InjectedBundleController.cpp:
2636         (TestWebKitAPI::InjectedBundleController::initialize):
2637         (TestWebKitAPI::InjectedBundleController::didInitializePageGroup):
2638         (TestWebKitAPI::InjectedBundleController::initializeTestNamed):
2639         * TestWebKitAPI/InjectedBundleController.h:
2640         * TestWebKitAPI/InjectedBundleTest.h:
2641         (TestWebKitAPI::InjectedBundleTest::initialize):
2642         (TestWebKitAPI::InjectedBundleTest::didInitializePageGroup):
2643         * TestWebKitAPI/PlatformUtilities.cpp:
2644         (TestWebKitAPI::Util::createContextForInjectedBundleTest):
2645         * TestWebKitAPI/PlatformUtilities.h:
2646         * TestWebKitAPI/PlatformWebView.h:
2647         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
2648         (TestWebKitAPI::TEST):
2649         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp:
2650         (TestWebKitAPI::DocumentStartUserScriptAlertCrashTest::initialize):
2651         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
2652         (TestWebKitAPI::PlatformWebView::PlatformWebView):
2653         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
2654         (TestWebKitAPI::PlatformWebView::PlatformWebView):
2655         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2656         (WTR::InjectedBundle::didInitializePageGroup):
2657         (WTR::InjectedBundle::initialize):
2658         (WTR::InjectedBundle::beginTesting):
2659         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2660         (WTR::InjectedBundle::pageGroup):
2661         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2662         (WTR::LayoutTestController::addUserScript):
2663         (WTR::LayoutTestController::addUserStyleSheet):
2664         (WTR::LayoutTestController::setXSSAuditorEnabled):
2665         * WebKitTestRunner/TestController.cpp:
2666         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2667         (WTR::PlatformWebView::PlatformWebView):
2668
2669 2010-12-01  Steve Falkenburg  <sfalken@apple.com>
2670
2671         Reviewed by Adam Roben.
2672
2673         vcproj changes can't be applied cleanly by the Windows EWS bot
2674         https://bugs.webkit.org/show_bug.cgi?id=50328
2675
2676         * CLWrapper/CLWrapper.sln: Modified property svn:eol-style.
2677         * CLWrapper/CLWrapper.vcproj: Modified property svn:eol-style.
2678         * DumpRenderTree/DumpRenderTree.sln: Modified property svn:eol-style.
2679         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops: Added property svn:eol-style.
2680         * DumpRenderTree/win/DumpRenderTree.vcproj: Modified property svn:eol-style.
2681         * DumpRenderTree/win/DumpRenderTreeApple.vsprops: Added property svn:eol-style.
2682         * DumpRenderTree/win/DumpRenderTreeCFLite.vsprops: Added property svn:eol-style.
2683         * DumpRenderTree/win/DumpRenderTreeCairo.vsprops: Added property svn:eol-style.
2684         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops: Added property svn:eol-style.
2685         * DumpRenderTree/win/ImageDiff.vcproj: Modified property svn:eol-style.
2686         * DumpRenderTree/win/ImageDiffCommon.vsprops: Added property svn:eol-style.
2687         * FindSafari/FindSafari.vcproj: Modified property svn:eol-style.
2688         * FindSafari/FindSafariCommon.vsprops: Added property svn:eol-style.
2689         * MIDLWrapper/MIDLWrapper.sln: Modified property svn:eol-style.
2690         * MIDLWrapper/MIDLWrapper.vcproj: Modified property svn:eol-style.
2691         * MiniBrowser/Configurations/MiniBrowserCFLite.vsprops: Added property svn:eol-style.
2692         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops: Added property svn:eol-style.
2693         * MiniBrowser/Configurations/MiniBrowserCoreFoundation.vsprops: Added property svn:eol-style.
2694         * MiniBrowser/MiniBrowser.vcproj: Added property svn:eol-style.
2695         * TestWebKitAPI/Configurations/TestWebKitAPICFLite.vsprops: Added property svn:eol-style.
2696         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops: Added property svn:eol-style.
2697         * TestWebKitAPI/Configurations/TestWebKitAPICoreFoundation.vsprops: Added property svn:eol-style.
2698         * TestWebKitAPI/win/TestWebKitAPI.sln: Added property svn:eol-style.
2699         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Added property svn:eol-style.
2700         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj: Added property svn:eol-style.
2701         * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops: Added property svn:eol-style.
2702         * WebKitAPITest/WebKitAPITest.vcproj: Added property svn:eol-style.
2703         * WebKitAPITest/WebKitAPITestCommon.vsprops: Added property svn:eol-style.
2704         * WebKitLauncherWin/WebKitLauncherWin.vcproj: Modified property svn:eol-style.
2705         * WebKitLauncherWin/WebKitLauncherWinCommon.vsprops: Added property svn:eol-style.
2706         * WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops: Added property svn:eol-style.
2707         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops: Added property svn:eol-style.
2708         * WebKitTestRunner/Configurations/InjectedBundleCoreFoundation.vsprops: Added property svn:eol-style.
2709         * WebKitTestRunner/Configurations/WebKitTestRunnerCFLite.vsprops: Added property svn:eol-style.
2710         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops: Added property svn:eol-style.
2711         * WebKitTestRunner/Configurations/WebKitTestRunnerCoreFoundation.vsprops: Added property svn:eol-style.
2712         * WebKitTestRunner/WebKitTestRunner.sln: Added property svn:eol-style.
2713         * WebKitTestRunner/win/InjectedBundle.vcproj: Added property svn:eol-style.
2714         * WebKitTestRunner/win/InjectedBundleGenerated.vcproj: Added property svn:eol-style.
2715         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops: Added property svn:eol-style.
2716         * WebKitTestRunner/win/WebKitTestRunner.vcproj: Added property svn:eol-style.
2717         * WinLauncher/WinLauncher.vcproj: Modified property svn:eol-style.
2718         * WinLauncher/WinLauncherCommon.vsprops: Added property svn:eol-style.
2719         * record-memory-win/record-memory-win-common.vsprops: Added property svn:eol-style.
2720         * record-memory-win/record-memory-win.vcproj: Modified property svn:eol-style.
2721
2722 2010-12-01  Anders Carlsson  <andersca@apple.com>
2723
2724         Reviewed by Darin Adler.
2725
2726         Return a correct user agent if NPN_UserAgent is called with a null NPP from NPP_New.
2727         https://bugs.webkit.org/show_bug.cgi?id=50336
2728
2729         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2730         Add new test.
2731
2732         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
2733         (PluginTest::NPP_New):
2734         Add default implementation/
2735
2736         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
2737         * DumpRenderTree/TestNetscapePlugIn/Tests/GetUserAgentWithNullNPPFromNPPNew.cpp: Added.
2738         (GetUserAgentWithNullNPPFromNPPNew::GetUserAgentWithNullNPPFromNPPNew):
2739         (GetUserAgentWithNullNPPFromNPPNew::NPP_New):
2740         Get the user agent.
2741
2742         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2743         (NPP_New):
2744         Call PluginTest::NPP_New.
2745
2746         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2747         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2748         Add new files.
2749
2750         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2751         (webkit_test_plugin_new_instance):
2752         Call PluginTest::NPP_New.
2753
2754 2010-12-01  Kevin Ollivier  <kevino@theolliviers.com>
2755
2756         [wx] Build fixes after recent trunk changes.
2757
2758         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2759         (LayoutTestController::findString):
2760         * wx/build/settings.py:
2761
2762 2010-12-01  Dan Bernstein  <mitz@apple.com>
2763
2764         Reviewed by Darin Adler.
2765
2766         WebKitTestRunner needs layoutTestController.findString
2767         https://bugs.webkit.org/show_bug.cgi?id=50238
2768
2769         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Added findString().
2770         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2771         (WTR::LayoutTestController::findString): Updated signature for autogenerated bindings.
2772         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Ditto.
2773
2774 2010-12-01  Steve Falkenburg  <sfalken@apple.com>
2775
2776         Try using svn:eol-style native on a vcproj file.
2777
2778         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Modified property svn:eol-style.
2779
2780 2010-12-01  Patrick Gansterer  <paroga@webkit.org>
2781
2782         Reviewed by Adam Roben.
2783
2784         [WINCE] Add WinCELauncher
2785         https://bugs.webkit.org/show_bug.cgi?id=50217
2786
2787         * WinCELauncher/main.cpp: Added.
2788
2789 2010-11-30  Benjamin Poulain  <benjamin.poulain@nokia.com>
2790
2791         Reviewed by Kenneth Rohde Christiansen.
2792
2793         [Qt] Implement layoutTestController.findString
2794         https://bugs.webkit.org/show_bug.cgi?id=50236
2795
2796         Add the missing function to the LayoutTestController.
2797
2798         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2799         (LayoutTestController::findString):
2800         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2801
2802 2010-11-30  Tony Chang  <tony@chromium.org>
2803
2804         Reviewed by Adam Barth.
2805
2806         [chromium] fix get-int-identifier-special-values.html using TestNetscapePlugIn
2807         https://bugs.webkit.org/show_bug.cgi?id=49036
2808
2809         * DumpRenderTree/chromium/LayoutTestController.cpp: Use IsNumber instead of IsInt32
2810             for CppVariants.
2811         (LayoutTestController::cppVariantToBool):
2812         (LayoutTestController::cppVariantToInt32):
2813         (LayoutTestController::setDatabaseQuota):
2814         (LayoutTestController::evaluateInWebInspector):
2815         (LayoutTestController::setMockGeolocationError):
2816
2817 2010-11-30  Eric Seidel  <eric@webkit.org>
2818
2819         Reviewed by Tony Chang.
2820
2821         update-webkit should call git fetch before git svn rebase
2822         https://bugs.webkit.org/show_bug.cgi?id=50273
2823
2824         After discussion on webkit-dev, we've decided to move the "default"
2825         git setup to pulling updates from git.webkit.org in preference
2826         to rebuilding the local svn index using git svn fetch every time.
2827
2828         This change should have no effect on people using the "old" git setup
2829         and should dramatically increase the speed of updates for those using
2830         the "new" git setup along with update-webkit.  I'm about to move the
2831         EWS and other queues over to this setup once this lands.
2832
2833         * Scripts/update-webkit:
2834
2835 2010-11-30  Mario Sanchez Prada  <msanchez@igalia.com>
2836
2837         Reviewed by Xan Lopez.
2838
2839         GTK: AX: implement press in DRT
2840         https://bugs.webkit.org/show_bug.cgi?id=36146
2841
2842         Implement AccessibilityUIElement::press() for GTK.
2843
2844         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2845         (AccessibilityUIElement::press): Implemented.
2846
2847 2010-11-29  Mihai Parparita  <mihaip@chromium.org>
2848
2849         Reviewed by Tony Chang.
2850
2851         config.webkit_base_dir returns a path with a trailing slash
2852         https://bugs.webkit.org/show_bug.cgi?id=50197
2853         
2854         config.webkit_base_dir() should return a path without a trailing slash,
2855         like all the other methods that return paths.
2856         
2857         Undoes MockFileSytem changes by r72640, since they're no longer
2858         necessary for GetBaselinesTest to pass.
2859
2860         * Scripts/webkitpy/common/system/filesystem_mock.py:
2861         * Scripts/webkitpy/layout_tests/port/base.py:
2862         * Scripts/webkitpy/layout_tests/port/config.py:
2863         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
2864
2865 2010-11-30  Mihai Parparita  <mihaip@chromium.org>
2866
2867         Reviewed by Tony Chang.
2868
2869         Rebaseline server: baseline display tweaks
2870         https://bugs.webkit.org/show_bug.cgi?id=50207
2871         
2872         Determine which baselines were used when running the tests and highlight
2873         them in the UI. Sort platform names alphabetically.
2874         
2875         Also makes the server URL be launched in the user's browser
2876         automatically.
2877
2878         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
2879         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
2880         * Scripts/webkitpy/tool/commands/data/rebaselineserver/util.js:
2881         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
2882         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py:
2883
2884 2010-11-30  Dan Bernstein  <mitz@apple.com>
2885
2886         Reviewed by Anders Carlsson.
2887
2888         <rdar://problem/8710645> WebKitTestRunner needs layoutTestController.findString
2889         https://bugs.webkit.org/show_bug.cgi?id=50238
2890
2891         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2892         (WTR::LayoutTestController::findString): Added.
2893         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2894
2895 2010-11-30  Steve Falkenburg  <sfalken@apple.com>
2896
2897         Reviewed by Adam Roben.
2898
2899         All projects on Windows should use cmd files for build events
2900         https://bugs.webkit.org/show_bug.cgi?id=50213
2901
2902         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops:
2903         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd: Added.
2904         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd: Added.
2905         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
2906         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd: Added.
2907         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd: Added.
2908         * DumpRenderTree/win/ImageDiffCommon.vsprops:
2909         * DumpRenderTree/win/ImageDiffPostBuild.cmd: Added.
2910         * DumpRenderTree/win/ImageDiffPreBuild.cmd: Added.
2911         * MiniBrowser/Configurations/MiniBrowserCFLite.vsprops:
2912         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
2913         * MiniBrowser/Configurations/MiniBrowserCoreFoundation.vsprops:
2914         * MiniBrowser/MiniBrowserPostBuild.cmd: Added.
2915         * MiniBrowser/MiniBrowserPreBuild.cmd: Added.
2916         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
2917         * TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd: Added.
2918         * TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd: Added.
2919         * WebKitAPITest/WebKitAPITestCommon.vsprops:
2920         * WebKitAPITest/WebKitAPITestPostBuild.cmd: Added.
2921         * WebKitAPITest/WebKitAPITestPreBuild.cmd: Added.
2922         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
2923         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
2924         * WebKitTestRunner/win/InjectedBundlePostBuild.cmd: Added.
2925         * WebKitTestRunner/win/InjectedBundlePreBuild.cmd: Added.
2926         * WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd: Added.
2927         * WebKitTestRunner/win/WebKitTestRunnerPreBuild.cmd: Added.
2928         * WinLauncher/WinLauncherCommon.vsprops:
2929         * WinLauncher/WinLauncherPostBuild.cmd: Added.
2930         * WinLauncher/WinLauncherPreBuild.cmd: Added.
2931
2932 2010-11-29  Dan Bernstein  <mitz@apple.com>
2933
2934         GTK DumpRenderTree build fix after r72887.
2935
2936         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2937         (LayoutTestController::findString):
2938
2939 2010-11-29  Dan Bernstein  <mitz@apple.com>
2940
2941         Windows DumpRenderTree build fix after r72887.
2942
2943         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2944         (LayoutTestController::findString): Added empty implementation.
2945
2946 2010-11-29  Dan Bernstein  <mitz@apple.com>
2947
2948         Reviewed by Darin Adler.
2949
2950         DumpRenderTree changes for testing the text search API.
2951         https://bugs.webkit.org/show_bug.cgi?id=50038
2952
2953         * DumpRenderTree/LayoutTestController.cpp:
2954         (findStringCallback):
2955         (LayoutTestController::staticFunctions):
2956         * DumpRenderTree/LayoutTestController.h:
2957         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2958         (LayoutTestController::findString):
2959         * MiniBrowser/mac/BrowserWindowController.m:
2960         (-[BrowserWindowController find:]):
2961
2962 2010-11-29  Johnny Ding  <jnd@chromium.org>
2963
2964         Unreviewed: Add myself to the list of Committers.
2965
2966         * Scripts/webkitpy/common/config/committers.py:
2967
2968 2010-11-29  Mark Rowe  <mrowe@apple.com>
2969
2970         Reviewed by Adele Peterson.
2971
2972         <rdar://problem/8694997> DumpRenderTree fails to build.
2973
2974         * DumpRenderTree/mac/PerlSupport/Makefile: Skip generating wrappers.
2975
2976 2010-11-29  Mark Rowe  <mrowe@apple.com>
2977
2978         Reviewed by Adele Peterson.
2979
2980         <rdar://problem/8694997> DumpRenderTree fails to build.
2981
2982         * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupportPregenerated.pm: Renamed from WebKitTools/DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupportTiger.pm.
2983         * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport_wrapPregenerated.c: Renamed from WebKitTools/DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport_wrapTiger.c.
2984         * DumpRenderTree/mac/PerlSupport/Makefile:
2985
2986 2010-11-29  Mario Sanchez Prada  <msanchez@igalia.com>
2987
2988         Reviewed by Martin Robinson.
2989
2990         [GTK] Null-check needed in DRT's AccessibilityUIElement::allAtributes()
2991         https://bugs.webkit.org/show_bug.cgi?id=50154
2992
2993         Added missing checks to allAttributes().
2994
2995         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2996         (AccessibilityUIElement::allAttributes): Added missing checks.
2997
2998 2010-11-29  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2999
3000         Reviewed by Kenneth Rohde Christiansen.
3001
3002         [Qt] Allow pre-generation for package builds for WebKit2
3003         https://bugs.webkit.org/show_bug.cgi?id=50139
3004
3005         Use a build variable for the generated directory path and set the
3006         value based on CONFIG just like for WebKit1.
3007
3008         For non-package builds use a relative base path for the
3009         genrated directory just like for WebKit1.
3010
3011         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3012         * WebKitTestRunner/qt/WebKitTestRunner.pro:
3013
3014 2010-11-28  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3015
3016         Reviewed by Kenneth Rohde Christiansen.
3017
3018         [Qt] Move some build logic from Qt to platform independent code
3019         https://bugs.webkit.org/show_bug.cgi?id=50134
3020
3021         Create target directories inside generate-forwarding-headers.pl.
3022
3023         * Scripts/generate-forwarding-headers.pl:
3024
3025 2010-11-24  Nicolas Dufresne  <nicolas.dufresne@collabora.co.uk>
3026
3027         Reviewed by Martin Robinson.
3028
3029         [GTK] Windowless plugins gets broken key input
3030         https://bugs.webkit.org/show_bug.cgi?id=49927
3031
3032         Convert the XEvent::keycode to ASCII before printing it. Not
3033         doing this was causing false positive in 
3034         plugins/keyboard-events.html.
3035
3036         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
3037         (keycode_to_char):
3038         (webkit_test_plugin_handle_event):
3039
3040 2010-11-24  Jan Erik Hanssen  <jhanssen@sencha.com>
3041
3042         Reviewed by Antonio Gomes.
3043
3044         [Qt] Html autofocus not working with QGraphicsWebView
3045         https://bugs.webkit.org/show_bug.cgi?id=43169
3046
3047         Tell the scene to set the webview item as the currently
3048         focused item. This makes the input field with autofocus get
3049         focus as it should.
3050
3051         * QtTestBrowser/webview.cpp:
3052         (WebViewGraphicsBased::WebViewGraphicsBased):
3053
3054 2010-11-24  Dirk Pranke  <dpranke@chromium.org>
3055
3056         Reviewed by Tony Chang.
3057
3058         nrwt - clean up create_driver interface and print out the
3059         command line used for DumpRenderTree/TestShell.
3060
3061         This patch adds a driver_cmd_line() call to the Port class in
3062         order to retrive the command line to print it out (as part of
3063         --print config).
3064
3065         In addition, this patch cleans up the Port.create_driver()
3066         signature and the Driver constructor interface to take a worker
3067         number and no longer require the image_path argument (Chromium's
3068         drivers now synthesize the image_path from the worker number
3069         internally).
3070
3071         https://bugs.webkit.org/show_bug.cgi?id=49934
3072
3073         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3074         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
3075         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
3076         * Scripts/webkitpy/layout_tests/port/base.py:
3077         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3078         * Scripts/webkitpy/layout_tests/port/chromium.py:
3079         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3080         * Scripts/webkitpy/layout_tests/port/dryrun.py:
3081         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3082         * Scripts/webkitpy/layout_tests/port/test.py:
3083         * Scripts/webkitpy/layout_tests/port/webkit.py:
3084         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3085         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3086
3087 2010-11-24  Ojan Vafai  <ojan@chromium.org>
3088
3089         Reviewed by Tony Chang.
3090
3091         [chromium] improve memory usage for test results server and store fewer runs
3092         https://bugs.webkit.org/show_bug.cgi?id=50035
3093
3094         Store fewer runs and don't pass full files around when we only need bools.
3095         Greatly improves error rates on test-results.appspot.com.
3096
3097         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3098         * TestResultServer/handlers/testfilehandler.py:
3099         * TestResultServer/model/dashboardfile.py:
3100         * TestResultServer/model/jsonresults.py:
3101
3102 2010-11-24  Dirk Pranke  <dpranke@chromium.org>
3103
3104         Reviewed by Tony Chang.
3105
3106         This patch implements the first part of the manager side of the
3107         Broker objects - it handles creating threads, waiting for them
3108         to complete, and running a single-threaded loop as well.
3109
3110         https://bugs.webkit.org/show_bug.cgi?id=49779
3111
3112         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
3113         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
3114         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3115         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3116
3117 2010-11-24  Mihai Parparita  <mihaip@chromium.org>
3118
3119         Reviewed by David Levin.
3120
3121         DRT should not generate pixel output for text/plain tests
3122         https://bugs.webkit.org/show_bug.cgi?id=50002
3123         
3124         Modify Mac, Windows and GTK DRT implementations to disable pixel output
3125         when encountering a text/plain response (the Chromium one already does
3126         this, and none of the other ports special-case text/plain output in
3127         the first place).
3128
3129         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3130         (dump):
3131         * DumpRenderTree/mac/DumpRenderTree.mm:
3132         (dump):
3133         * DumpRenderTree/win/DumpRenderTree.cpp:
3134         (dump):
3135
3136 2010-11-24  Andras Becsi  <abecsi@inf.u-szeged.hu>
3137
3138         Unreviewed.
3139
3140         Add my other email address to committers.py.
3141
3142         * Scripts/webkitpy/common/config/committers.py:
3143
3144 2010-11-24  Andras Becsi  <abecsi@inf.u-szeged.hu>
3145
3146         Reviewed by Csaba Osztrogonác.
3147
3148         Make build-webkit --minimal build with ENABLE_INSPECTOR=0
3149         https://bugs.webkit.org/show_bug.cgi?id=49975
3150
3151         * Scripts/build-webkit: Add ENABLE_INSPECTOR define to features,
3152         to enable the script to define it 0 in case of a minimal build.
3153
3154 2010-11-24  Martin Robinson  <mrobinson@igalia.com>
3155
3156         Reviewed by Xan Lopez.
3157
3158         [GTK] The WebKitWebView should expose a set of signals encapsulating the behavior of the EditorClient
3159         https://bugs.webkit.org/show_bug.cgi?id=49143
3160
3161         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3162         (createWebView): Call the new connectEditingCallbacks function.
3163         * DumpRenderTree/gtk/EditingCallbacks.cpp: Added.
3164         (dumpNodePath):
3165         (dumpRange):
3166         (insertActionString):
3167         (selectionAffinityString):
3168         (shouldBeginEditing):
3169         (shouldEndEditing):
3170         (shouldInsertNode):
3171         (shouldInsertText):
3172         (shouldDeleteRange):
3173         (shouldShowDeleteInterfaceForElement):
3174         (shouldChangeSelectedRange):
3175         (shouldApplyStyle):
3176         (editingBegan):
3177         (userChangedContents):
3178         (editingEnded):
3179         (selectionChanged):
3180         (connectEditingCallbacks):
3181         * DumpRenderTree/gtk/EditingCallbacks.h: Added.
3182         * GNUmakefile.am: Added EditingCallbacks.{h,cpp} to the source list.
3183
3184 2010-11-24  Yi Shen  <yi.4.shen@nokia.com>
3185
3186         Reviewed by Andreas Kling.
3187
3188         [Qt] Make QtTestBrowser remember the selected user agent
3189         https://bugs.webkit.org/show_bug.cgi?id=50021
3190
3191         Set user agent for a new page by using the old page's
3192
3193         * QtTestBrowser/mainwindow.cpp:
3194         (MainWindow::setPage):
3195
3196 2010-11-24 Patrick Gansterer <paroga@webkit.org>
3197
3198         Reviewed by Csaba Osztrogonác.
3199
3200         Remove Bakefile build system files
3201         https://bugs.webkit.org/show_bug.cgi?id=49983
3202
3203         r53757 only removed the content, but not the files.
3204         This patch removes that empty files.
3205
3206         * DumpRenderTree/wx/DumpRenderTree.bkl: Removed.
3207         * wx/browser/browser.bkl: Removed.
3208         * wx/build-wxwebkit: Removed.
3209
3210 2010-11-23  Dirk Pranke  <dpranke@chromium.org>
3211
3212         Reviewed by Tony Chang.
3213
3214         This patch cleans up the logic used to shard tests into groups a
3215         bit and adds the --worker-model flag to NRWT. The flag is only
3216         used at the moment to control whether to run single-threaded or
3217         not, but eventually will also allow toggling between threads and
3218         processes.
3219
3220         Also add a minor cleanup with _test_is_slow(), which just
3221         eliminates some repetition and gives slightly better encapsulation.
3222
3223         https://bugs.webkit.org/show_bug.cgi?id=49773
3224
3225         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3226         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3227
3228 2010-11-23  Mihai Parparita  <mihaip@chromium.org>
3229
3230         Reviewed by Tony Chang.
3231
3232         Rebaseline server: list current baselines and platforms
3233         https://bugs.webkit.org/show_bug.cgi?id=49991
3234         
3235         List existing baselines (with Trac links) for tests.
3236         
3237         Add dropdowns for choosing with platform baselines to target (and what
3238         to do with existing ones).
3239
3240         Also fix MockFileSystem.join to behave more like os.path.join (unit
3241         test was ending up with two consecutive slashes in a layout test
3242         path).        
3243
3244         * Scripts/webkitpy/common/system/filesystem_mock.py:
3245         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
3246         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
3247         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
3248         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js:
3249         * Scripts/webkitpy/tool/commands/data/rebaselineserver/util.js:
3250         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
3251         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py: Added.
3252
3253 2010-11-23  Ojan Vafai  <ojan@chromium.org>
3254
3255         Reviewed by Tony Chang.
3256
3257         remove timeout argument to urlopen
3258         https://bugs.webkit.org/show_bug.cgi?id=49995
3259
3260         Apparently the version of python we have on the bots doesn't accept a timeout argument.
3261
3262         * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py:
3263
3264 2010-11-23  Sheriff Bot  <webkit.review.bot@gmail.com>
3265
3266         Unreviewed, rolling out r72628.
3267         http://trac.webkit.org/changeset/72628
3268         https://bugs.webkit.org/show_bug.cgi?id=49994
3269
3270         This patch is causing layout-test failtures on GTK Linux
3271         64-bit Debug (Requested by ctguil on #webkit).
3272
3273         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
3274         (AccessibilityUIElement::AccessibilityUIElement):
3275         (AccessibilityUIElement::parentElementCallback):
3276         * DumpRenderTree/chromium/AccessibilityUIElement.h:
3277         * DumpRenderTree/chromium/CppBoundClass.cpp:
3278         * DumpRenderTree/chromium/CppBoundClass.h:
3279
3280 2010-11-22  Ojan Vafai  <ojan@chromium.org>
3281
3282         Reviewed by Tony Chang.
3283
3284         speculative fix for upload errors: stop using mechanize to upload to test-results.appspot.com
3285         https://bugs.webkit.org/show_bug.cgi?id=49944
3286
3287         * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py:
3288
3289 2010-11-23  Chris Guillory  <chris.guillory@google.com>
3290
3291         Reviewed by Dimitri Glazkov.
3292
3293         Include the FrameView widget of a RenderWidget in the accessibility tree.
3294         https://bugs.webkit.org/show_bug.cgi?id=49106
3295
3296         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
3297         (AccessibilityUIElement::AccessibilityUIElement):
3298         (AccessibilityUIElement::parentElementCallback):
3299         (AccessibilityUIElement::isEqualCallback):
3300         * DumpRenderTree/chromium/AccessibilityUIElement.h:
3301         * DumpRenderTree/chromium/CppBoundClass.cpp:
3302         (CppBoundClass::getFromCppVariant):
3303         * DumpRenderTree/chromium/CppBoundClass.h:
3304
3305 2010-11-23  Alex Grilo  <abgrilo@profusion.mobi>
3306
3307         Reviewed by Kenneth Rohde Christiansen.
3308
3309         [EFL] Add tiled backing store to EWebLauncher
3310         https://bugs.webkit.org/show_bug.cgi?id=45777
3311
3312         Allow EWebLauncher to choose between single and tiled backing store
3313
3314         * EWebLauncher/main.c:
3315         (on_key_down):
3316         (browserCreate):
3317         (main):
3318
3319 2010-11-23  Simon Hausmann  <simon.hausmann@nokia.com>
3320
3321         Reviewed by Tor Arne Vestbø.
3322
3323         [Qt] Review the setUserPermission & friends API
3324         https://bugs.webkit.org/show_bug.cgi?id=46810
3325
3326         Renamed requestPermissionFromUser to featurePermissionRequested
3327         and cancelRequestsForPermission to featurePermissionRequestCanceled.
3328
3329         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3330         (WebCore::WebPage::WebPage):
3331         * QtTestBrowser/webpage.cpp:
3332         (WebPage::WebPage):
3333         (WebPage::featurePermissionRequestCanceled):
3334         * QtTestBrowser/webpage.h:
3335
3336 2010-11-23  Simon Hausmann  <simon.hausmann@nokia.com>
3337
3338         Reviewed by Tor Arne Vestbø.
3339
3340         [Qt] Review the setUserPermission & friends API
3341         https://bugs.webkit.org/show_bug.cgi?id=46810
3342
3343         Rename setUserPermission to setFeaturePermission
3344
3345         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3346         (WebCore::WebPage::requestPermission):
3347         (WebCore::WebPage::permissionSet):
3348         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3349         (LayoutTestController::grantDesktopNotificationPermission):
3350         * QtTestBrowser/webpage.cpp:
3351         (WebPage::requestPermission):
3352
3353 2010-11-23  Simon Hausmann  <simon.hausmann@nokia.com>
3354
3355         Reviewed by Tor Arne Vestbø.
3356
3357         [Qt] Review the setUserPermission & friends API
3358         https://bugs.webkit.org/show_bug.cgi?id=46810
3359
3360         Rename PermissionDomain to Feature, NotificationsPermissionDomain to Notifications
3361         and GeolocationPermissionDomain to Geolocation.
3362
3363         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3364         (WebCore::WebPage::WebPage):
3365         (WebCore::WebPage::requestPermission):
3366         (WebCore::WebPage::cancelPermission):
3367         (WebCore::WebPage::permissionSet):
3368         (WebCore::DumpRenderTree::geolocationPermissionSet):
3369         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3370         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3371         (LayoutTestController::grantDesktopNotificationPermission):
3372         * QtTestBrowser/webpage.cpp:
3373         (WebPage::WebPage):
3374         (WebPage::requestPermission):
3375         (WebPage::cancelRequestsForPermission):
3376         * QtTestBrowser/webpage.h:
3377
3378 2010-11-23  Simon Hausmann  <simon.hausmann@nokia.com>
3379
3380         Reviewed by Tor Arne Vestbø.
3381
3382         [Qt] Review the setUserPermission & friends API
3383         https://bugs.webkit.org/show_bug.cgi?id=46810
3384
3385         Add a ByUser suffix to PermissionGranted/Denied. In the future
3386         we can add PermissionGrantedByDefault.
3387
3388
3389         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3390         (WebCore::WebPage::requestPermission):
3391         (WebCore::WebPage::permissionSet):
3392         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3393         (LayoutTestController::grantDesktopNotificationPermission):
3394         * QtTestBrowser/webpage.cpp:
3395         (WebPage::requestPermission):
3396
3397 2010-11-18  Satish Sampath  <satish@chromium.org>
3398
3399         Reviewed by Jeremy Orlow.
3400
3401         For speech input event, send an event object containing all the recognition results and metadata.
3402         https://bugs.webkit.org/show_bug.cgi?id=49736
3403
3404         Updated DRT by renaming the mock result method on all platforms to the new signature.
3405
3406         * DumpRenderTree/LayoutTestController.cpp:
3407         (addMockSpeechInputResultCallback):
3408         (LayoutTestController::staticFunctions):
3409         * DumpRenderTree/LayoutTestController.h:
3410         * DumpRenderTree/chromium/LayoutTestController.cpp:
3411         (LayoutTestController::LayoutTestController):
3412         (LayoutTestController::addMockSpeechInputResult):
3413         * DumpRenderTree/chromium/LayoutTestController.h:
3414         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3415         (LayoutTestController::addMockSpeechInputResult):
3416         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3417         (LayoutTestController::addMockSpeechInputResult):
3418         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3419         (LayoutTestController::addMockSpeechInputResult):
3420         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3421         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3422         (LayoutTestController::addMockSpeechInputResult):
3423         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3424         (LayoutTestController::addMockSpeechInputResult):
3425
3426 2010-11-22  Dirk Pranke  <dpranke@chromium.org>
3427
3428         Reviewed by Tony Chang.
3429
3430         Fix some spacing issues with log messages with
3431         new-run-webkit-tests --verbose.
3432
3433         https://bugs.webkit.org/show_bug.cgi?id=49936
3434
3435         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
3436
3437 2010-11-22  Ojan Vafai  <ojan@chromium.org>
3438
3439         Reviewed by Adam Barth.
3440
3441         update scm to work with different remote branches
3442         https://bugs.webkit.org/show_bug.cgi?id=49949
3443
3444         This works if there are multiple svn tracking branches
3445         and/or if the tracking branch is refs/remots/origin/master
3446         instead of refs/remotes/trunk which is the direction we're trying
3447         to head since that makes fetches faster.
3448
3449         * Scripts/webkitpy/common/checkout/scm.py:
3450         * Scripts/webkitpy/common/checkout/scm_unittest.py:
3451
3452 2010-11-22  Hayato Ito  <hayato@chromium.org>
3453
3454         Reviewed by Shinichiro Hamaji.
3455
3456         Ignore reference files which will be used by reftests when collecting
3457         test cases.
3458         https://bugs.webkit.org/show_bug.cgi?id=49835
3459
3460         * Scripts/webkitpy/layout_tests/port/test_files.py:
3461         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
3462
3463 2010-11-22  Adam Roben  <aroben@apple.com>
3464
3465         Use paths relative to $WebKitVSPropsRedirectionDir to access shared .vsprops files
3466
3467         Apple's Windows build allows placing header files and import libraries for WebKit's
3468         dependencies (CoreGraphics, CFNetwork, SQLite, etc.) outside the source tree via the
3469         $WebKitLibrariesDir environment variable. This is both required for production builds and
3470         convenient for Apple-internal developer builds. Apple's production builds also require that
3471         WebKit's shared .vsprops files be accessed relative to $WebKitLibrariesDir. In production
3472         builds, the files are copied into that directory tree by the
3473         WebKitLibraries/win/tools/WinTools.make file. In Apple-internal developer builds, the
3474         copying is done by
3475         JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make.
3476
3477         This .vsprops copying is problematic in one very important case: when a developer updates
3478         their source tree and then tries to build. Visual Studio only reads .vsprops files when a
3479         project is first loaded. So, when Visual Studio is first opened after the .vsprops files are
3480         updated, it reads in the old files that were already residing in $WebKitLibrariesDir. When a
3481         build is started, JavaScriptCoreGenerated.make copies the new .vsprops files into
3482         $WebKitLibrariesDir, but Visual Studio will not pick up the changes.  The rest of the build
3483         will proceed with out-of-date .vsprops files, which will likely result in a build failure.
3484
3485         To fix this, we now use normal relative paths to access the .vsprops files in the source
3486         tree rather than in $WebKitLibrariesDir, but prefix those paths with a new environment
3487         variable, $WebKitVSPropsRedirectionDir. In developer builds, this environment variable is
3488         unset, so the normal relative paths are used to read the .vsprops files out of the source
3489         tree directly. In production builds, this environment variable is set to a fake directory
3490         that will cause the .vsprops files in $WebKitLibrariesDir to be found when the relative path
3491         is resolved.
3492         
3493         For example, JavaScriptCore.vcproj uses this path for FeatureDefines.vsprops:
3494
3495         $(WebKitVSPropsRedirectionDir)..\..\..\WebKitLibraries\win\tools\vsprops\FeatureDefines.vsprops
3496
3497         In developer builds, where $WebKitVSPropsRedirectionDir is unset, this will point to the
3498         files in WebKitLibraries\win\tools\vsprops in the source tree. In production builds,
3499         JavaScriptCore.make sets $WebKitVSPropsRedirectionDir to
3500         "$(SRCROOT)\AppleInternal\tools\vsprops\OpenSource\1\2\3\", so the full path for
3501         FeatureDefines.vsprops becomes:
3502
3503         $(SRCROOT)\AppleInternal\tools\vsprops\OpenSource\1\2\3\..\..\..\WebKitLibraries\win\tools\vsprops\FeatureDefines.vsprops
3504
3505         which resolves to:
3506
3507         $(SRCROOT)\AppleInternal\tools\vsprops\OpenSource\WebKitLibraries\win\tools\vsprops\FeatureDefines.vsprops
3508
3509         (We rely on the fact that Windows doesn't care whether the directories "1", "2", and "3"
3510         actually exist since they are matched by an equal number of ".." path components.)
3511
3512         Note that Visual Studio still won't pick up changes made to .vsprops files while Visual
3513         Studio is open, but that problem hasn't seemed to cause developers many headaches so far.
3514
3515         Fixes <http://webkit.org/b/49181> Windows build fails mysteriously when .vsprops files are
3516         updated
3517
3518         Reviewed by Dave Hyatt.
3519
3520         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3521         * DumpRenderTree/win/DumpRenderTree.vcproj:
3522         * DumpRenderTree/win/ImageDiff.vcproj:
3523         * FindSafari/FindSafari.vcproj:
3524         * MiniBrowser/MiniBrowser.vcproj:
3525         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3526         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj:
3527         * WebKitAPITest/WebKitAPITest.vcproj:
3528         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
3529         * WebKitTestRunner/win/InjectedBundle.vcproj:
3530         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
3531         * WinLauncher/WinLauncher.vcproj:
3532         * record-memory-win/record-memory-win.vcproj:
3533         Changed to use paths relative to $WebKitVSPropsRedirectionDir to access shared .vsprops
3534         files.
3535
3536 2010-11-22  Adam Roben  <aroben@apple.com>
3537
3538         Make it possible to run tests on Windows without Visual Studio or VC++
3539         Express installed
3540
3541         webkitdir.pm::setupCygwinEnv dies when Visual Studio and VC++ Express
3542         are not installed. But this function doesn't need to be called when we
3543         already have a build available and are just trying to run the tests.
3544
3545         Fixes <http://webkit.org/b/49932> New Windows 7 bot can't run tests
3546         because Visual Studio/VC++ Express aren't installed
3547
3548         Reviewed by Dave Hyatt.
3549
3550         * Scripts/webkitdirs.pm:
3551         (determineConfigurationForVisualStudio): Don't call setupCygwinEnv, as
3552         it is not needed by this function. Also added a FIXME.
3553
3554         (usingVisualStudioExpress): Call setupCygwinEnv directly rather than
3555         relying on determineConfigurationForVisualStudio doing it.
3556
3557 2010-11-19  Hayato Ito  <hayato@chromium.org>
3558
3559         Reviewed by Shinichiro Hamaji.
3560
3561         Simplify Driver.run_test() so that it takes only one parameter, TestInput.
3562
3563         https://bugs.webkit.org/show_bug.cgi?id=49812
3564
3565         * Scripts/webkitpy/layout_tests/driver_test.py:
3566         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3567         * Scripts/webkitpy/layout_tests/port/base.py:
3568         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3569         * Scripts/webkitpy/layout_tests/port/chromium.py:
3570         * Scripts/webkitpy/layout_tests/port/dryrun.py:
3571         * Scripts/webkitpy/layout_tests/port/test.py:
3572         * Scripts/webkitpy/layout_tests/port/webkit.py:
3573         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3574         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3575
3576 2010-11-22  Hayato Ito  <hayato@chromium.org>
3577
3578         Reviewed by Tony Chang.
3579
3580         [NRWT] Retry a few times in reading a png image to avoid a race condition.
3581
3582         https://bugs.webkit.org/show_bug.cgi?id=49924
3583
3584         * Scripts/webkitpy/layout_tests/port/chromium.py:
3585
3586 2010-11-22  João Paulo Rechi Vita  <jprvita@profusion.mobi>
3587
3588         Reviewed by Kenneth Rohde Christiansen.
3589
3590         Fix EWebLauncher zoom discretization
3591         https://bugs.webkit.org/show_bug.cgi?id=49810
3592
3593         * EWebLauncher/main.c:
3594         (nearest_zoom_level_get):
3595         (zoom_level_set):
3596         (on_load_finished):
3597         (on_key_down):
3598
3599 2010-11-21  Sam Weinig  <sam@webkit.org>
3600
3601         Rubber-stamped by Dan Bernstein.
3602
3603         Fix ~300 WebKit2 tests by enabling developer extras preference.
3604
3605         * WebKitTestRunner/TestController.cpp:
3606         (WTR::TestController::resetStateToConsistentValues):
3607
3608 2010-11-21  Sam Weinig  <sam@webkit.org>
3609
3610         Reviewed by Dan Bernstein.
3611
3612         Textareas should be resizable by default
3613         https://bugs.webkit.org/show_bug.cgi?id=49892
3614
3615         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3616         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp: Added.
3617         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3618         Add preferences test.
3619
3620 2010-11-19  Mihai Parparita  <mihaip@chromium.org>
3621
3622         Reviewed by Tony Chang.
3623
3624         Rebaseline server: checksum-only differences and prefetching
3625         https://bugs.webkit.org/show_bug.cgi?id=49841
3626         
3627         Add support for image test results where the only difference is in the
3628         checksum.
3629         
3630         Add prefetching of the image results from the next test.
3631         
3632         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
3633         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
3634         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
3635
3636 2010-11-19  Dirk Pranke  <dpranke@chromium.org>
3637
3638         Reviewed by Tony Chang.
3639
3640         nrwt multiprocessing - add 'worker number' concept, move stuff to worker thread
3641
3642         Add the 'worker number' and 'worker name' concepts to the 
3643         TestShellThread objects, and move test_types and test_args from
3644         the TestRunner to the TestShellThread.
3645
3646         https://bugs.webkit.org/show_bug.cgi?id=49768
3647
3648         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3649         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3650
3651 2010-11-19  Dirk Pranke  <dpranke@chromium.org>
3652
3653         Reviewed by Ojan Vafai.
3654
3655         Do some minor cleanup and bug fixing.
3656
3657         https://bugs.webkit.org/show_bug.cgi?id=49777
3658
3659         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3660         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3661
3662 2010-11-19  Dirk Pranke  <dpranke@chromium.org>
3663
3664         Reviewed by Ojan Vafai.
3665
3666         nrwt - config.build_directory() is busted
3667
3668         Fixes a typo that was causing us to usually return the top level
3669         directory WebKitBuild instead of WebKitBuild/{Debug,Release}. The
3670         bug was hidden by test stubs that were too simplistic :(.
3671
3672         https://bugs.webkit.org/show_bug.cgi?id=49815
3673
3674         * Scripts/webkitpy/common/system/executive_mock.py:
3675         * Scripts/webkitpy/layout_tests/port/config.py:
3676         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
3677
3678 2010-11-19  Steve Falkenburg  <sfalken@apple.com>
3679
3680         Reviewed by Adam Roben.
3681
3682         Add Debug_Cairo_CFLite and Release_Cairo_CFLite configurations for all vcproj files
3683         https://bugs.webkit.org/show_bug.cgi?id=49819
3684
3685         * DumpRenderTree/DumpRenderTree.sln:
3686         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3687         * DumpRenderTree/win/DumpRenderTree.vcproj:
3688         * DumpRenderTree/win/ImageDiff.vcproj:
3689         * FindSafari/FindSafari.vcproj:
3690         * MiniBrowser/MiniBrowser.vcproj:
3691         * TestWebKitAPI/win/TestWebKitAPI.sln:
3692         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3693         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj:
3694         * WebKitAPITest/WebKitAPITest.vcproj:
3695         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
3696         * WebKitTestRunner/win/InjectedBundle.vcproj:
3697         * WebKitTestRunner/win/InjectedBundleGenerated.vcproj:
3698         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
3699         * WinLauncher/WinLauncher.vcproj:
3700         * record-memory-win/record-memory-win.vcproj:
3701
3702 2010-11-19  Adam Roben  <aroben@apple.com>
3703
3704         Add some more Windows slaves
3705
3706         This is probably more than we will be using in the immediate future,
3707         but having some extra slave names makes experimenting with different
3708         configurations easier.
3709
3710         Reviewed by Jon Honeycutt.
3711
3712         * BuildSlaveSupport/build.webkit.org-config/config.json: Added 5 more
3713         Windows slaves and distributed them among the three different Test
3714         builders.
3715
3716 2010-11-19  Kinuko Yasuda  <kinuko@chromium.org>