2011-01-22 Geoffrey Garen <ggaren@apple.com>
[WebKit.git] / Tools / ChangeLog
1 2011-01-22  Geoffrey Garen  <ggaren@apple.com>
2
3         Reviewed by Dan Bernstein.
4
5         Beefed up --threaded mode to catch even more kinds of errors.
6         https://bugs.webkit.org/show_bug.cgi?id=52971
7
8         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Use a shared
9         context group to force JSC to mark multiple threads. (This used to be
10         the default, but it changed in SnowLeopard.)
11         (runJavaScriptThread): Do more locking and unlocking, and more allocation,
12         to give threading mistakes more chances to show themselves.
13         (startJavaScriptThreads):
14         (stopJavaScriptThreads):
15
16 2011-01-22  Robert Hogan  <robert@webkit.org>
17
18         Reviewed by Andreas Kling.
19
20         [Qt] Support layoutTestController.addURLToRedirect()
21         https://bugs.webkit.org/show_bug.cgi?id=52956
22
23         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
24         (LayoutTestController::addURLToRedirect):
25         * DumpRenderTree/qt/LayoutTestControllerQt.h:
26
27 2011-01-22  Robert Hogan  <robert@webkit.org>
28
29         Reviewed by Kenneth Rohde Christiansen.
30
31         [Qt] REGRESSION (r72360): http/tests/security/aboutBlank/xss-DENIED-* tests fail
32         https://bugs.webkit.org/show_bug.cgi?id=49802
33
34         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
35         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
36         (WebCore::DumpRenderTree::open):
37
38 2011-01-21  Adam Barth  <abarth@webkit.org>
39
40         Reviewed by Maciej Stachowiak.
41
42         Disable mac_unittest.py that fails on some of the Mac bots
43         https://bugs.webkit.org/show_bug.cgi?id=52947
44
45         As noted in the comment, this test does not appear to be correct
46         because the function this test is testing returns different results
47         depending on which flavor of Mac the test is run on.  This patch
48         disable the test.  Hopefully we can re-enable the test once we've
49         probably insulated the test from its environment.
50
51         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
52
53 2011-01-21  Dirk Pranke  <dpranke@chromium.org>
54
55         Reviewed by Mihai Parparita.
56
57         Fix bug introduced in r76322 that caused NRWT to not actually
58         read the Skipped files properly.
59
60         https://bugs.webkit.org/show_bug.cgi?id=52771
61
62         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
63         * Scripts/webkitpy/layout_tests/port/webkit.py:
64         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
65
66 2011-01-21  Sam Weinig  <sam@webkit.org>
67
68         Reviewed by Geoffrey Sean Garen and Mark Rowe.
69
70         WebKitTestRunner needs the HOME environment variable to be set.
71         <rdar://problem/8896573>
72
73         * Scripts/old-run-webkit-tests: Set the HOME environment variable if
74         it exists.
75
76 2011-01-21  Dirk Pranke  <dpranke@chromium.org>
77
78         Reviewed by Eric Seidel.
79
80         Suppress a few remaining integration tests so that none of the
81         layout_test unit tests ever read from the filesystem or launch
82         subprocesses that aren't part of the unit tests.
83
84         Also fix a minor bug in the printing unit tests that was
85         incorrectly relying on sys.argv.
86
87         https://bugs.webkit.org/show_bug.cgi?id=52863
88
89         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
90         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
91         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
92
93 2011-01-21  Darin Adler  <darin@apple.com>
94
95        Fix Mac build.
96
97         * MiniBrowser/mac/BrowserWindowController.m:
98         (-[BrowserWindowController awakeFromNib]): Pass 0 for runModal function.
99
100 2011-01-20  Darin Adler  <darin@apple.com>
101
102         Reviewed by Dan Bernstein.
103
104         WebKit2: Implement showModalDialog
105         https://bugs.webkit.org/show_bug.cgi?id=52855
106
107         This fixes WebKitTestRunner to compile, but more work is probably
108         needed to get it to pass the tests.
109
110         * WebKitTestRunner/TestController.cpp:
111         (WTR::TestController::runModal): Added. Calls through to the
112         platform-specific version of runModal.
113         (WTR::TestController::createOtherPage): Changed to be a private
114         static member function so it can refer to runModal, which is
115         a private static member function.
116         (WTR::TestController::initialize): Pass 0 for the runModal
117         function since we don't need to run the main window modal.
118         I suspect this is wrong and will need to change.
119         * WebKitTestRunner/TestController.h: Added declarations for
120         the functions added above.
121         * WebKitTestRunner/mac/TestControllerMac.mm:
122         (WTR::TestController::runModal): Added. Untested implementation.
123         * WebKitTestRunner/qt/TestControllerQt.cpp:
124         (WTR::TestController::runModal): Added.
125         * WebKitTestRunner/win/TestControllerWin.cpp:
126         (WTR::TestController::runModal): Added.
127
128 2011-01-21  Eric Seidel  <eric@webkit.org>
129
130         Reviewed by Adam Barth.
131
132         Split Host object off from WebKitPatch for easier re-use
133         https://bugs.webkit.org/show_bug.cgi?id=52284
134
135         new-run-webkit-tests and other tools are eventually going to want one of these.
136         Basically you need to inherit from this class if you want to pretend to be a
137         self.tool object for Steps/Commands.
138
139         * Scripts/webkitpy/common/host.py: Added.
140         * Scripts/webkitpy/tool/main.py:
141
142 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
143
144         Reviewed by Adam Barth.
145
146         Disable the tests that start and stop the http server and web
147         server, so that we don't have to worry about port collisions on
148         the bots.
149
150         https://bugs.webkit.org/show_bug.cgi?id=52861
151
152         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
153
154 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
155
156         Reviewed by Eric Seidel.
157
158         nrwt: rewrite google_chrome_unittest to use mock filesystem.
159         
160         https://bugs.webkit.org/show_bug.cgi?id=52772
161         
162         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
163
164 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
165
166         Reviewed by Eric Siedel.
167
168         nrwt: clean up almost all remaining port references, remove
169         unnecessary import clauses. The only remaining references are
170         in places where a mock filesystem makes no sense or can't be
171         used, and in one routine in port/google_chrome_unittest that
172         I'll rewrite in a separate patch.
173
174         https://bugs.webkit.org/show_bug.cgi?id=52771
175
176         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
177         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
178         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
179         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
180         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
181         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
182         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
183         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
184         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
185         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
186         * Scripts/webkitpy/layout_tests/port/gtk.py:
187         * Scripts/webkitpy/layout_tests/port/mac.py:
188         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
189         * Scripts/webkitpy/layout_tests/port/qt.py:
190         * Scripts/webkitpy/layout_tests/port/webkit.py:
191         * Scripts/webkitpy/layout_tests/port/win.py:
192         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
193
194 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
195
196         Reviewed by Mihai Parparita.
197
198         remove fs refs from run_webkit_tests, rebaseline_chromium_webkit_tests
199
200         https://bugs.webkit.org/show_bug.cgi?id=52762
201
202         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
203         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
204
205 2011-01-20  Tony Chang  <tony@chromium.org>
206
207         Reviewed by Ojan Vafai.
208
209         [chromium] fix the paths used for the rebaseline tool
210         https://bugs.webkit.org/show_bug.cgi?id=52857
211
212         Some of the bots were renamed so the path to grab the results zip
213         file has changed.
214
215         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
216
217 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
218
219         Reviewed by Tony Chang.
220
221         Fix bug introduced in r72688 / bug 52768 that broke the
222         generation of the output filename links in the results.html
223         output. Apparently none of the unit tests actually checked to
224         make sure the generated links were correct :(
225
226         https://bugs.webkit.org/show_bug.cgi?id=52854
227
228         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
229         * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
230
231 2011-01-20  Alexey Proskuryakov  <ap@apple.com>
232
233         Reviewed by Darin Adler.
234
235         https://bugs.webkit.org/show_bug.cgi?id=52849
236         Make window.print work with WebKit2
237
238         * MiniBrowser/mac/BrowserWindowController.m:
239         (-[BrowserWindowController awakeFromNib]):
240         * WebKitTestRunner/TestController.cpp:
241         (WTR::createOtherPage):
242         (WTR::TestController::initialize):
243         Added zeroes to WKPageUIClient structures to avoid build failures.
244
245 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
246
247         Reviewed by Eric Seidel.
248
249         nrwt: remove fs refs from printing, test_failures, test_expectations, text_diff
250
251         https://bugs.webkit.org/show_bug.cgi?id=52756
252
253         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
254         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
255         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
256         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
257         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
258         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
259
260 2011-01-20  Mansi Mithal  <mansi.mithal@nokia.com>
261
262         Reviewed by Antonio Gomes.
263
264         QtTestBrowser should have a seperate menu for Settings
265         https://bugs.webkit.org/show_bug.cgi?id=52817
266         
267         Added a new menu item named "Settings"
268         and moved the "Enable interrupting js scripts" and "Enable js pop up windows" under the "Settings" menu 
269
270         * QtTestBrowser/launcherwindow.cpp:
271         (LauncherWindow::createChrome):
272
273 2011-01-20  Sam Weinig  <sam@webkit.org>
274
275         Reviewed by John Sullivan.
276
277         Update update-webkit-localizable-strings with new path to WebKit.
278
279         * Scripts/update-webkit-localizable-strings:
280
281 2011-01-20  James Robinson  <jamesr@chromium.org>
282
283         Reviewed by Darin Fisher.
284
285         Implement mozilla's requestAnimationFrame API
286         https://bugs.webkit.org/show_bug.cgi?id=51218
287
288         Chromium DumpRenderTree support for window.webkitRequestAnimationFrame.
289
290         * DumpRenderTree/chromium/WebViewHost.cpp:
291         (invokeScheduleComposite):
292         (WebViewHost::scheduleAnimation):
293         (WebViewHost::paintInvalidatedRegion):
294         * DumpRenderTree/chromium/WebViewHost.h:
295
296 2011-01-20  Maciej Stachowiak  <mjs@apple.com>
297
298         Reviewed by Adam Roben.
299
300         WebKitTestRunner needs to support layoutTestController.evaluateScriptInIsolatedWorld
301         https://bugs.webkit.org/show_bug.cgi?id=42327
302
303         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm: Add support
304         for methods that take their normal arguments but also a JSContextRef.
305         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: IDL definition
306         for evaluateScriptInIsolatedWorld.
307         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
308         (WTR::InjectedBundlePage::didClearWindowForFrame): Set a magic variable only if
309         this call is for an isolated world.
310         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
311         (WTR::worldMap): Helper to create a world map.
312         (WTR::LayoutTestController::worldIDForWorld): Map from an ID to a world.
313         (WTR::LayoutTestController::evaluateScriptInIsolatedWorld): The newly
314         added LayoutTestController API.
315         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
316
317 2011-01-19  Adam Roben  <aroben@apple.com>
318
319         Convert paths in environment variables back to msys-style inside commit-log-editor
320
321         When this script gets run from inside git commit, msys-style paths in the environment will
322         have been turned into Windows-style paths with forward slashes. This screws up functions
323         like File::Spec->rel2abs, which seem to rely on $PWD having an msys-style path. We convert
324         the paths back to msys-style before doing anything else.
325
326         Fixes <http://webkit.org/b/48527> commit-log-editor uses full paths for section headers when
327         using msysgit's Perl and multiple ChangeLogs have been edited
328
329         Reviewed by David Kilzer.
330
331         * Scripts/commit-log-editor: Call fixEnvironment before doing anything else.
332         (fixEnvironment): Added. When run in msys in conjunction with git (i.e., when invoked from
333         inside git commit), convert Windows-style paths in the environment back to msys-style paths.
334
335 2011-01-20  Zoltan Horvath  <zoltan@webkit.org>
336
337         [Win] Unreviewed build fix after r76248.
338
339         * DumpRenderTree/ForwardingHeaders/wtf/FastAllocBase.h: Added.
340
341 2011-01-20  Zoltan Horvath  <zoltan@webkit.org>
342
343         Reviewed by Csaba Osztrogonác.
344
345         Refactoring of the custom allocation framework
346         https://bugs.webkit.org/show_bug.cgi?id=49897
347
348         Inheriting from FastAllocBase can result in objects getting larger (bug #33896, #46589).
349         The modification replaces Noncopyable and FastAllocBase classes and these inherits with their
350         equivalent macro implementation at the necessary places.
351 2011-01-20  Yi Shen  <yi.4.shen@nokia.com>
352
353         Unreviewed. 
354
355         Adding myself to committers.py.
356
357         * Scripts/webkitpy/common/config/committers.py:
358
359 2011-01-20  Adam Barth  <abarth@webkit.org>
360
361         Reviewed by Tony Chang.
362
363         Chromium builders don't delete unversioned directories when DEPS change
364         https://bugs.webkit.org/show_bug.cgi?id=52745
365
366         If we pass this option to gclient sync, gclient will delete directories
367         that are no longer part of DEPS instead of leaving them around to
368         confuse us later.  Apparently, the downstream buildbots use this option
369         already.
370
371         * Scripts/update-webkit-chromium:
372
373 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
374
375         Unreviewed, build fix - I pulled this patch in to fix an issue
376         revealed by r76195 running on some new bots). Also fix a couple
377         of other issues revealed in testing.
378
379         nrwt: remove fs refs from layout_package/json*
380
381         https://bugs.webkit.org/show_bug.cgi?id=52754
382
383         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
384         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
385         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
386         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
387         * Scripts/webkitpy/layout_tests/port/base.py:
388
389 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
390
391         Unreviewed, build fix.
392
393         Fix a couple of minor bugs discovered while bringing up new bots
394         for testing.
395
396         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
397         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
398
399 2011-01-19  James Robinson  <jamesr@chromium.org>
400
401         Unreviewed, rolling out r76194.
402         http://trac.webkit.org/changeset/76194
403         https://bugs.webkit.org/show_bug.cgi?id=51218
404
405         Caused mysterious compile failure on the chromium win
406         build.webkit.org bots
407
408         * DumpRenderTree/chromium/WebViewHost.cpp:
409         (WebViewHost::paintInvalidatedRegion):
410         * DumpRenderTree/chromium/WebViewHost.h:
411
412 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
413
414         Reviewed by Mihai Parparita.
415
416         remove fs refs from test_runner, dump_render_tree_thread
417
418         https://bugs.webkit.org/show_bug.cgi?id=52753
419
420         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
421         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
422         * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
423         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
424
425 2011-01-19  James Robinson  <jamesr@chromium.org>
426
427         Reviewed by Darin Fisher.
428
429         Implement mozilla's requestAnimationFrame API
430         https://bugs.webkit.org/show_bug.cgi?id=51218
431
432         Chromium DumpRenderTree support for window.webkitRequestAnimationFrame.
433
434         * DumpRenderTree/chromium/WebViewHost.cpp:
435         (invokeScheduleComposite):
436         (WebViewHost::scheduleAnimation):
437         (WebViewHost::paintInvalidatedRegion):
438         * DumpRenderTree/chromium/WebViewHost.h:
439
440 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
441
442         Unreviewed, build fix.
443
444         Fix a few incorrect "self._filesystem" references introduced in
445         r76184.
446
447         * Scripts/webkitpy/layout_tests/port/chromium.py:
448         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
449
450 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
451
452         Reviewed by Mihai Parparita.
453
454         add a .sep property, abspath(), isabs(), mtime(), and
455         open_text_file_for_writing() to filesystem modules. Some of
456         these properties are not needed in this patch but will be needed
457         in subsequent patches (I'm doing this to avoid having to track
458         multiple versions of a single file).
459
460         Also, change most of the port/* modules to use the filesystem
461         objects instead of referencing the filesystem directly.
462
463         https://bugs.webkit.org/show_bug.cgi?id=52748
464
465         * Scripts/webkitpy/common/system/filesystem.py:
466         * Scripts/webkitpy/common/system/filesystem_mock.py:
467         * Scripts/webkitpy/layout_tests/port/__init__.py:
468         * Scripts/webkitpy/layout_tests/port/base.py:
469         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
470         * Scripts/webkitpy/layout_tests/port/chromium.py:
471         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
472         * Scripts/webkitpy/layout_tests/port/config.py:
473         * Scripts/webkitpy/layout_tests/port/test.py:
474         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
475
476 2011-01-19  Maciej Stachowiak  <mjs@apple.com>
477
478         Reviewed by Anders Carlsson.
479
480         If resetting between tests times out, treat it as a WebProcess crash
481         https://bugs.webkit.org/show_bug.cgi?id=52757
482
483         * WebKitTestRunner/TestController.cpp:
484         (WTR::TestController::runTest):
485
486 2011-01-19  Alexey Proskuryakov  <ap@apple.com>
487
488         Reviewed by Darin Adler.
489
490         https://bugs.webkit.org/show_bug.cgi?id=52739
491         Make it possible for a WebKit2 client to print headers and footers
492
493         Added dummy implementations for new printing UIClient calls.
494
495         * MiniBrowser/mac/BrowserWindowController.m:
496         (-[BrowserWindowController awakeFromNib]):
497         * WebKitTestRunner/TestController.cpp:
498         (WTR::createOtherPage):
499         (WTR::TestController::initialize):
500
501 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
502
503         Reviewed by Ojan Vafai.
504
505         Change webkitpy/layout_tests/port/test.py to use the
506         in-memory filesystem for cleaner unit testing. This
507         change allows us to kill a lot of code that was
508         specific to the test port, at the cost of being a
509         little less clear about how things would work if
510         you didn't have a filesystem.
511
512         https://bugs.webkit.org/show_bug.cgi?id=52605
513
514         * Scripts/webkitpy/layout_tests/port/test.py:
515
516 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
517
518         Unreviewed, build fix.
519
520         Fix test failure caused by committing attachment 79368 instead
521         of attachment 79461 on bug 52604.
522
523         * Scripts/webkitpy/common/system/filesystem_mock.py:
524
525 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
526
527         Reviewed by Mihai Parparita.
528
529         new-run-webkit-tests: remove use of os.walk, use mock filesystem for better
530         unit testing. os.walk() is too much of a hassle to implement on
531         top of the in-memory mock filesystem and adding the necessary
532         interface to files_under() gives clients a cleaner API anyway
533         (for this particular usage model).
534
535         https://bugs.webkit.org/show_bug.cgi?id=52691
536
537         * Scripts/webkitpy/common/system/filesystem.py:
538         * Scripts/webkitpy/common/system/filesystem_mock.py:
539         * Scripts/webkitpy/layout_tests/port/test_files.py:
540         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
541
542 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
543
544         Reviewed by Tony Chang.
545
546         Change more modules in the layout-tests code to use the
547         filesystem wrapper for cleaner unit testing.
548
549         This patch also adds the glob() wrapper to the filesystem
550         abstraction.
551         
552         https://bugs.webkit.org/show_bug.cgi?id=52604
553
554         * Scripts/webkitpy/layout_tests/port/test_files.py:
555         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
556         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
557         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
558         * Scripts/webkitpy/common/system/filesystem.py:
559         * Scripts/webkitpy/common/system/filesystem_mock.py:
560
561 2011-01-19  Levi Weintraub  <leviw@chromium.org>
562
563         Unreviewed.
564
565         Updating my email addresses and irc nick.
566
567         * Scripts/webkitpy/common/config/committers.py:
568
569 2011-01-19  Tony Chang  <tony@chromium.org>
570
571         Reviewed by Mihai Parparita.
572
573         [chromium] [linux] if check-sys-deps fails, output the failure reason
574         https://bugs.webkit.org/show_bug.cgi?id=52671
575
576         * Scripts/webkitpy/common/system/executive_mock.py: Add support for
577             error handler functions.
578         * Scripts/webkitpy/layout_tests/port/chromium.py:
579             output the error text from --check-sys-deps
580         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
581
582 2011-01-19  Aparna Nandyal  <aparna.nand@wipro.com>
583
584         Reviewed by Andreas Kling.
585
586         [Qt] QtTestBrowser crashes when closing if Facebook is opened
587         https://bugs.webkit.org/show_bug.cgi?id=52554
588         
589         QtNetworkAccessManager is created in a thread and set as
590         member variable in QWebPage. When the thread is destroyed
591         the object is still used. So fix will set the object to
592         NULL once the thread is destroyed.
593
594         * QtTestBrowser/launcherwindow.cpp:
595         (LauncherWindow::~LauncherWindow):
596
597 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
598
599         Rubber stamped by Csaba Osztrogonac
600
601         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: Removed unncessary inculde of WKStringCF.h
602
603 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
604
605         Reviewed by Tony Chang.
606
607         new-run-webkit-tests: add a --build-directory command line argument
608
609         Official Google Chrome builds use a non-standard build directory
610         location. This patch adds a --build-directory argument that
611         allows that location to be specified on the command line. Only
612         Chromium-based builds will use this flag for now, but anyone can
613         in the future.
614
615         There are no unit tests for this since it's difficult to test
616         until mock filesystems are fully supported in the code. This was
617         tested by hand for now.
618
619         https://bugs.webkit.org/show_bug.cgi?id=52694
620
621         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
622         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
623         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
624         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
625
626 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
627
628         Not reviewed. Bot fix.
629
630         Remove an inadvertently committed debugging print.
631
632         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
633         (LayoutTestController::notifyDone):
634
635 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
636
637         Reviewed by Sam Weinig.
638
639         WebKitTestRunner should track loading more like DumpRenderTree
640         https://bugs.webkit.org/show_bug.cgi?id=52692
641
642         Change load tracking to track the current top loading frame, in the manner of DumpRenderTree.
643         This makes some tests that call notifyDone multiple times pass.
644         
645         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
646         (WTR::InjectedBundle::InjectedBundle):
647         (WTR::InjectedBundle::done):
648         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
649         (WTR::InjectedBundle::topLoadingFrame):
650         (WTR::InjectedBundle::setTopLoadingFrame):
651         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
652         (WTR::InjectedBundlePage::InjectedBundlePage):
653         (WTR::InjectedBundlePage::stopLoading):
654         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
655         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
656         (WTR::InjectedBundlePage::didFinishLoadForFrame):
657         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
658         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
659         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
660         (WTR::LayoutTestController::notifyDone):
661         * WebKitTestRunner/TestController.cpp:
662         (WTR::TestController::didReceiveMessageFromInjectedBundle):
663
664 2011-01-18  Mihai Parparita  <mihaip@chromium.org>
665
666         Reviewed by Kent Tamura.
667
668         [Chromium] NRWT looking for DRT binary in the wrong path on Mac
669         https://bugs.webkit.org/show_bug.cgi?id=52678
670         
671         Update path now that WebKit is inside Source.
672
673         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
674
675 2011-01-18  Robert Hogan  <robert@webkit.org>
676
677         Reviewed by Simon Hausmann.
678
679         [Qt] http/tests/incremental/slow-utf8-text.pl fails
680         https://bugs.webkit.org/show_bug.cgi?id=44282
681
682         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
683         (WebCore::DumpRenderTree::dump):
684
685 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
686
687         Reviewed by Mihai Parparita.
688
689         Fix a small race condition that could cause the unit tests for
690         new-run-webkit-tests to fail in a multithreaded environment.
691         There was a small window in the code where one thread would
692         check to see if a thread had raised an exception, do something,
693         and then check to see if the thread was alive. If the other
694         thread raised an exception and exited in between these two
695         steps, the exception would be lost. Flipping the order of the
696         two checks fixes the race, since we will now always check for an
697         exception on the thread before exiting.
698
699         https://bugs.webkit.org/show_bug.cgi?id=51579
700
701         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
702
703 2011-01-18  Eric Seidel  <eric@webkit.org>
704
705         Reviewed by Adam Barth.
706
707         commit-queue dies when test archiving fails
708         https://bugs.webkit.org/show_bug.cgi?id=52617
709
710         I looked at the machine and it had 10 archives already
711         thus find_unused_name was returning None.  I've upped
712         the limit to 100 (per bug) and tested the case where
713         find_unused_name returns None (making archive return None).
714
715         * Scripts/webkitpy/common/system/workspace.py:
716         * Scripts/webkitpy/common/system/workspace_unittest.py:
717         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
718         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
719         * Scripts/webkitpy/tool/commands/queues.py:
720
721 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
722
723         Reviewed by Ojan Vafai.
724
725         Update rebaseline-chromium-webkit-tests unit tests to use a mock
726         filesystem. Also fix a couple of "with" statements missed by
727         r76050.
728
729         https://bugs.webkit.org/show_bug.cgi?id=52487
730
731         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
732
733 2011-01-18  Sergio Villar Senin  <svillar@igalia.com>
734
735         Reviewed by Martin Robinson.
736
737         [Gtk] Build fixes for gtk3 build
738         https://bugs.webkit.org/show_bug.cgi?id=52648
739
740         * DumpRenderTree/gtk/EventSender.cpp:
741         (beginDragWithFilesCallback):
742
743 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
744
745         Reviewed by Mihai Parparita.
746
747         Update rebaseline-chromium-webkit-tests to use filesystem objects
748         instead of direct references to os.path, shutil, tempfile, etc.
749
750         This patch doesn't change anything, but will allow subsequent
751         patches to change the unit tests to no longer use the real
752         filesystem.
753
754         This patch adds a bunch more methods to the filesystem object as
755         well.
756
757         https://bugs.webkit.org/show_bug.cgi?id=52482
758
759         * Scripts/webkitpy/common/system/filesystem.py:
760         * Scripts/webkitpy/common/system/filesystem_mock.py:
761         * Scripts/webkitpy/tool/commands/queues.py:
762         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
763         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
764
765 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
766
767         Reviewed by Mihai Parparita.
768
769         new-run-webkit-tests shouldn't crash when you try to run a
770         directory containing only skipped files.
771
772         https://bugs.webkit.org/show_bug.cgi?id=52478
773         
774         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
775         * Scripts/webkitpy/layout_tests/port/test.py:
776         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
777
778 2011-01-18  Adam Bergkvist  <adam.bergkvist@ericsson.com> and Martin Robinson  <mrobinson@igalia.com>
779
780         Reviewed by Gustavo Noronha Silva.
781
782         [GTK] The GTK+ EventSender needs support for beginDragWithFiles
783         https://bugs.webkit.org/show_bug.cgi?id=40833
784
785         * DumpRenderTree/gtk/EventSender.cpp: Add a beginDragWithFiles implementation for the
786         GTK+ event sender.
787         (dragWithFilesDragDataGetCallback): Added.
788         (dragWithFilesDragEndCallback): Added.
789         (beginDragWithFilesCallback): Added.
790
791 2011-01-18  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
792
793         Reviewed by Adam Barth.
794
795         ews: Add additional watcher to efl ews
796         https://bugs.webkit.org/show_bug.cgi?id=52613
797
798         Add gyuyoung.kim@samsung.com to watcher list of efl-ews.
799
800         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
801
802 2011-01-17  Tony Gentilcore  <tonyg@chromium.org>
803
804         Reviewed by Alexey Proskuryakov.
805
806         Fix some headers with missing or misspelled #ifndef guards
807         https://bugs.webkit.org/show_bug.cgi?id=52545
808
809         * DumpRenderTree/chromium/TestEventPrinter.h:
810         * DumpRenderTree/chromium/WebPreferences.h:
811
812 2011-01-17  Jessie Berlin  <jberlin@apple.com>
813
814         Reviewed by Anders Carlsson.
815
816         REGRESSION: Assertion failure in FrameLoader::continueLoadAfterWillSubmitForm() when
817         navigating back to an unreachable URL
818         https://bugs.webkit.org/show_bug.cgi?id=52388
819
820         Add a third parameter (unreachableURL) to queueLoadHTMLString.
821
822         * DumpRenderTree/LayoutTestController.cpp:
823         (queueLoadHTMLStringCallback):
824         (LayoutTestController::queueLoadHTMLString):
825         (LayoutTestController::queueLoadAlternateHTMLString):
826         * DumpRenderTree/LayoutTestController.h:
827
828         * DumpRenderTree/WorkQueueItem.h:
829         (LoadHTMLStringItem::LoadHTMLStringItem):
830
831         * DumpRenderTree/chromium/LayoutTestController.cpp:
832         (WorkItemLoadHTMLString::WorkItemLoadHTMLString):
833         (WorkItemLoadHTMLString::run):
834         (LayoutTestController::queueLoadHTMLString):
835
836         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
837         (LoadHTMLStringItem::invoke):
838         * DumpRenderTree/mac/WorkQueueItemMac.mm:
839         (LoadHTMLStringItem::invoke):
840         * DumpRenderTree/win/WorkQueueItemWin.cpp:
841         (LoadHTMLStringItem::invoke):
842
843 2011-01-17  Dan Bernstein  <mitz@apple.com>
844
845         Rubber-stamped by Mark Rowe.
846
847         Update xcodeproj svn:ignore to include xcuserdata.
848
849         * DumpRenderTree/DumpRenderTree.xcodeproj: Modified property svn:ignore.
850         * MiniBrowser/MiniBrowser.xcodeproj: Modified property svn:ignore.
851         * TestWebKitAPI/TestWebKitAPI.xcodeproj: Modified property svn:ignore.
852         * WebKitLauncher/WebKitLauncher.xcodeproj: Modified property svn:ignore.
853         * WebKitTestRunner/WebKitTestRunner.xcodeproj: Modified property svn:ignore.
854
855 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
856
857         Unreviewed fix after r75908.
858
859         Move WebKit into Source
860         https://bugs.webkit.org/show_bug.cgi?id=52530
861
862         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add Source to the path for Qt API tests.
863
864 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
865
866         Unreviewed.
867
868         Remove accidentally committed debug printing after r75908.
869
870         * Scripts/webkitdirs.pm:
871
872 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
873
874         Unreviewed.
875
876         Add myself to committers list
877         https://bugs.webkit.org/show_bug.cgi?id=52566
878
879         * Scripts/webkitpy/common/config/committers.py:
880
881 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
882
883         Reviewed by Jeremy Orlow.
884
885         GeolocationController should call stopUpdating on destruction
886         https://bugs.webkit.org/show_bug.cgi?id=52216
887
888         fast/dom/Geolocation/window-close-crash.html requires that a
889         Geolocation watch be started in a secondary window. Consequently,
890         we need to allow geolocation permission and provide a mock
891         geolocation position for the secondary window's
892         GeolocationClientMock.
893
894         * DumpRenderTree/chromium/LayoutTestController.cpp:
895         (LayoutTestController::setGeolocationPermission):
896         (LayoutTestController::setMockGeolocationPosition):
897         (LayoutTestController::setMockGeolocationError):
898         * DumpRenderTree/chromium/TestShell.h:
899         (TestShell::windowList):
900
901 2011-01-16  Adam Barth  <abarth@webkit.org>
902
903         Update more include paths to reflect WebKit move.
904
905         * DumpRenderTree/chromium/EventSender.cpp:
906         (EventSender::keyDown):
907         (EventSender::needsShiftModifier):
908         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
909         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
910
911 2011-01-16  Kent Tamura  <tkent@chromium.org>
912
913         Unreviewed, Chromium build fix.
914
915         * Scripts/update-webkit-chromium: Webkit/chromium -> Source/WebKit/chromium
916
917 2011-01-16  Martin Robinson  <mrobinson@igalia.com>
918
919         Build fix for GTK+ after source directory movement.
920
921         * GNUmakefile.am: Correct include paths.
922
923 2011-01-16  Adam Barth  <abarth@webkit.org>
924
925         Teach svn-apply about WebKit move.
926
927         * Scripts/VCSUtils.pm:
928
929 2011-01-16  Adam Barth  <abarth@webkit.org>
930
931         Rubber-stamped by Eric Seidel.
932
933         Move WebKit into Source
934         https://bugs.webkit.org/show_bug.cgi?id=52530
935
936         * DumpRenderTree/mac/InternalHeaders/WebKit/WebTypesInternal.h:
937         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
938         * DumpRenderTree/qt/DumpRenderTreeQt.h:
939         * DumpRenderTree/qt/GCControllerQt.cpp:
940         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
941         * DumpRenderTree/qt/PlainTextControllerQt.cpp:
942         * DumpRenderTree/qt/TextInputControllerQt.cpp:
943         * DumpRenderTree/wscript:
944         * QtTestBrowser/launcherwindow.h:
945         * Scripts/build-webkit:
946         * Scripts/webkitdirs.pm:
947
948 2011-01-15  Adam Barth  <abarth@webkit.org>
949
950         Teach svn-apply about WebKit2 move.
951
952         * Scripts/VCSUtils.pm:
953
954 2011-01-15  Adam Barth  <abarth@webkit.org>
955
956         Rubber-stamped by Eric Seidel.
957
958         Move WebKit2 into Source
959         https://bugs.webkit.org/show_bug.cgi?id=52438
960
961         * MiniBrowser/qt/MiniBrowser.pro:
962         * Scripts/build-webkit:
963         * Scripts/do-file-rename:
964         * Scripts/do-webcore-rename:
965         * Scripts/test-webkitpy:
966         * Scripts/webkitdirs.pm:
967         * Scripts/webkitpy/style/checker.py:
968         * WebKitTestRunner/DerivedSources.pro:
969         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
970         * WebKitTestRunner/qt/WebKitTestRunner.pro:
971
972 2011-01-15  Jochen Eisinger  <jochen@chromium.org>
973
974         Reviewed by David Levin.
975
976         [chromium] remove obsolete createView method
977         https://bugs.webkit.org/show_bug.cgi?id=52437
978
979         * DumpRenderTree/chromium/WebViewHost.cpp:
980         (WebViewHost::createView):
981         * DumpRenderTree/chromium/WebViewHost.h:
982
983 2011-01-14  Brian Weinstein  <bweinstein@apple.com>
984
985         Reviewed by Geoff Garen.
986
987         ShouldLoadResourceForFrame should use strings, not URLs.
988         https://bugs.webkit.org/show_bug.cgi?id=52476
989
990         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
991         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Update to use a WKStringRef.
992         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
993
994 2011-01-14  Tony Gentilcore  <tonyg@chromium.org>
995
996         Reviewed by David Levin.
997
998         Add Tony Gentilcore as a reviewer
999         https://bugs.webkit.org/show_bug.cgi?id=52480
1000
1001         * Scripts/webkitpy/common/config/committers.py:
1002
1003 2011-01-14  David Levin  <levin@chromium.org>
1004
1005         Reviewed by Eric Seidel.
1006
1007         check-webkit-style: _FunctionState should keep track of where the function name starts.
1008         https://bugs.webkit.org/show_bug.cgi?id=52454
1009
1010         * Scripts/webkitpy/style/checkers/cpp.py: Added function_name_start_position to
1011         _FunctionState and logic for setting it correctly.
1012         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests.
1013
1014 2011-01-14  Vincent Scheib  <scheib@chromium.org>
1015
1016         Reviewed by David Levin.
1017
1018         Add support to DumpRenderTree to use the GPU rather than software renderer
1019         https://bugs.webkit.org/show_bug.cgi?id=52333
1020
1021         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1022         (main):
1023         * Scripts/webkitpy/layout_tests/port/chromium.py:
1024         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1025
1026 2011-01-14  Tony Chang  <tony@chromium.org>
1027
1028         Reviewed by Kent Tamura.
1029
1030         [chromium] update fonts.conf to fix 6 linux tests in drt
1031         https://bugs.webkit.org/show_bug.cgi?id=52411
1032
1033         * DumpRenderTree/chromium/fonts.conf: Update to match the copy in
1034             chromium's src/webkit/tools/test_shell/resources/fonts.conf
1035
1036 2011-01-14  Eric Seidel  <eric@webkit.org>
1037
1038         Original patch from Peter Gal  <galpater@inf.u-szeged.hu>
1039
1040         Reviewed by Adam Barth.
1041
1042         Fix when running Tools/Scripts/check-webkit-style without arguments.
1043         https://bugs.webkit.org/show_bug.cgi?id=52261#c16
1044
1045         * Scripts/webkitpy/common/checkout/scm.py: Handle None for changed_files argument better in Git.create_patch method.
1046         * Scripts/webkitpy/common/checkout/scm_unittest.py:
1047
1048 2011-01-04  Jochen Eisinger  <jochen@chromium.org>
1049
1050         Reviewed by David Levin.
1051
1052         Store the tempdir object in a variable so it doesn't get deleted too early.
1053         https://bugs.webkit.org/show_bug.cgi?id=51875
1054
1055         * Scripts/update-webkit-auxiliary-libs:
1056         * Scripts/update-webkit-support-libs:
1057
1058 2011-01-14  Eric Seidel  <eric@webkit.org>
1059
1060         Unreviewed.  Make it work in python 2.5.
1061
1062         webkit-patch suggest-reviewers dies when ChangeLogs are missing
1063         https://bugs.webkit.org/show_bug.cgi?id=49158
1064
1065         * Scripts/webkitpy/common/checkout/api_unittest.py:
1066
1067 2011-01-14  Sheriff Bot  <webkit.review.bot@gmail.com>
1068
1069         Unreviewed, rolling out r75774.
1070         http://trac.webkit.org/changeset/75774
1071         https://bugs.webkit.org/show_bug.cgi?id=52431
1072
1073         gtk builds were broken (Requested by loislo2 on #webkit).
1074
1075         * Scripts/webkitpy/common/checkout/scm.py:
1076
1077 2011-01-14  David Levin  <levin@chromium.org>
1078
1079         Reviewed by Shinichiro Hamaji.
1080
1081         check-webkit-style: _FunctionState should detect pure functions.
1082         https://bugs.webkit.org/show_bug.cgi?id=52428
1083
1084         * Scripts/webkitpy/style/checkers/cpp.py: Added detection for if a function declaration
1085         is a pure virtual function.
1086         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests for verifying that pure
1087         virtual functions are correctly detected.
1088
1089 2011-01-13  Ilya Tikhonovsky  <loislo@chromium.org>
1090
1091         Reviewed by Yury Semikhatsky.
1092
1093         Just small fix for problem with check-webkit-style.
1094         It just didn't work for this patch.
1095         Old code can't concatenate a list of strings with None.
1096
1097         * Scripts/webkitpy/common/checkout/scm.py:
1098
1099 2011-01-13  David Levin  <levin@chromium.org>
1100
1101         Reviewed by Shinichiro Hamaji.
1102
1103         check-webkit-style: _FunctionState should use Position to know where items are.
1104         https://bugs.webkit.org/show_bug.cgi?id=52424
1105
1106         * Scripts/webkitpy/style/checkers/cpp.py:
1107         (_FunctionState.*): Changed _FunctionState to use Position instead of line numbers.
1108         (detect_functions): Changed to pass Position's to _FunctionState.begin and
1109         did some minor clean-up.
1110         (*): Other changes are simply about converting to use the Position's in_FunctionState
1111         instead of line numbers.
1112         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Changed the test code
1113         to verify the positions stored in _FunctionState.
1114
1115 2011-01-13  Eric Seidel  <eric@webkit.org>
1116
1117         Reviewed by David Levin.
1118
1119         webkit-patch suggest-reviewers dies when ChangeLogs are missing
1120         https://bugs.webkit.org/show_bug.cgi?id=49158
1121
1122         This is not the most elegant, but it is a very safe fix to this bug.
1123         One advantage of catching ScriptError like this instead of adding a
1124         new added_or_modified_files or fixing all changed_files callers
1125         to use a more specific change_files variant, is that we catch
1126         all kinds of ScriptErrors which might cause our (non-essential)
1127         suggest-reviewers code to fail out.  This should make passing
1128         --suggest-reviewers to webkit-patch upload much more robust
1129         and may even make it possible for us to make it default.
1130
1131         The root of the problem here is that SCM.changed_files includes
1132         deleted ChangeLog paths (from moves, etc) which then when we ask
1133         SVN/Git for the contents of the file at that revision, the command
1134         errors out and Executive.run_command raises a ScriptError.
1135
1136         In the future we might fix this differently by making all current
1137         callers of chagned_files use a more specific method for requesting
1138         what types of changes they're interested in (adds, modifies, deletes, etc.)
1139
1140         * Scripts/webkitpy/common/checkout/api.py:
1141         * Scripts/webkitpy/common/checkout/api_unittest.py:
1142
1143 2011-01-13  Dan Bernstein  <mitz@apple.com>
1144
1145         Reviewed by Alexey Proskuryakov.
1146
1147         <rdar://problem/8827065> REGRESSION (r71884): Cross-origin XHR fails if willSendRequest changes the URL
1148         https://bugs.webkit.org/show_bug.cgi?id=52419
1149
1150         Allow to further control the behavior of the willSendRequest delegate callback by making it
1151         set a different URL in the new request.
1152
1153         * DumpRenderTree/LayoutTestController.cpp:
1154         (addURLToRedirectCallback): Added.
1155         (LayoutTestController::staticFunctions): Added addURLToRedirect.
1156         (LayoutTestController::addURLToRedirect): Added. Adds the redirection to the map.
1157         (LayoutTestController::redirectionDestinationForURL): Added this getter.
1158         * DumpRenderTree/LayoutTestController.h:
1159         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1160         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]): Check
1161         if there is a redirection for the request’s URL, established by addURLToRedirect(), and if so,
1162         change the URL in the new request to the redirect destination.
1163
1164 2011-01-13  Eric Seidel  <eric@webkit.org>
1165
1166         Reviewed by Mihai Parparita.
1167
1168         webkit-patch suggest-reviewers fails due to invalid utf8 in ChangeLog files
1169         https://bugs.webkit.org/show_bug.cgi?id=52416
1170
1171         Example: webkit-patch suggest-reviewers -g ca3890fe74d94d85d6bfa48f9ea497b094d8e717 
1172         UnicodeDecodeError: 'utf8' codec can't decode bytes in position 536-538: invalid data
1173
1174         I also added FIXMEs about the changed_files returning deleted files problem
1175         which is causing the other most common exception for suggest-reviewers
1176         (and is probably breaking sheriff-bots blame detection).
1177
1178         * Scripts/webkitpy/common/checkout/api.py:
1179         * Scripts/webkitpy/common/checkout/api_unittest.py:
1180         * Scripts/webkitpy/common/checkout/scm.py:
1181
1182 2011-01-13  Eric Seidel  <eric@webkit.org>
1183
1184         Reviewed by Adam Barth.
1185
1186         results archives from commit-queue are too large to upload
1187         https://bugs.webkit.org/show_bug.cgi?id=52405
1188
1189         * Scripts/webkitpy/common/system/filesystem.py:
1190         * Scripts/webkitpy/common/system/filesystem_mock.py:
1191         * Scripts/webkitpy/tool/commands/queues.py:
1192
1193 2011-01-13  Alejandro G. Castro  <alex@igalia.com>
1194
1195         Reviewed by Martin Robinson.
1196
1197         [gtk] Zero-sized font does not yet work
1198         https://bugs.webkit.org/show_bug.cgi?id=49793
1199
1200         Set minimum-font-size to 0 for the DRT.
1201
1202         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1203         (resetDefaultsToConsistentValues):
1204
1205 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
1206
1207         Reviewed by Darin Adler.
1208
1209         Make old-run-webkit-tests more robust on buildbots
1210         https://bugs.webkit.org/show_bug.cgi?id=52364
1211
1212         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Pass --exit-after-n-failures 500 to old-run-webkit-tests script.
1213
1214 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
1215
1216         Reviewed by Darin Adler.
1217
1218         Make old-run-webkit-tests more robust on buildbots
1219         https://bugs.webkit.org/show_bug.cgi?id=52364
1220
1221         * Scripts/old-run-webkit-tests: Ensure that testResultsDirectory is empty.
1222
1223 2011-01-13  Tony Chang  <tony@chromium.org>
1224
1225         Reviewed by Kent Tamura.
1226
1227         [chromium] fix plugins/plugin-javascript-access.html on Linux and Mac
1228         https://bugs.webkit.org/show_bug.cgi?id=52332
1229
1230         Forked Info.plist is not longer needed.
1231
1232         * DumpRenderTree/chromium/TestNetscapePlugIn/Info.plist: Removed.
1233
1234 2011-01-13  Mikhail Naganov  <mnaganov@chromium.org>
1235
1236         Reviewed by Timothy Hatcher.
1237
1238         Web Inspector: Cleanup after r75613 -- make all UI-facing strings
1239         to be passed directly to WebInspector.UIString
1240
1241         https://bugs.webkit.org/show_bug.cgi?id=52365
1242
1243         * Scripts/check-inspector-strings:
1244
1245 2011-01-13  Sheriff Bot  <webkit.review.bot@gmail.com>
1246
1247         Unreviewed, rolling out r74881.
1248         http://trac.webkit.org/changeset/74881
1249         https://bugs.webkit.org/show_bug.cgi?id=52357
1250
1251         The EFL builder has been red for days (Requested by abarth on
1252         #webkit).
1253
1254         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1255         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1256
1257 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
1258
1259         Reviewed by David Levin.
1260
1261         Add beforeunload support to WebKitTestRunner
1262         https://bugs.webkit.org/show_bug.cgi?id=52353
1263         
1264         This makes a number of currently failing tests pass.
1265
1266         * WebKitTestRunner/TestController.cpp:
1267         (WTR::runBeforeUnloadConfirmPanel):
1268         (WTR::createOtherPage):
1269         (WTR::TestController::initialize):
1270
1271 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
1272
1273         Reviewed by Sam Weinig.
1274
1275         Detect, identify and recover from WebProcess crashes in run-webkit-tests
1276         https://bugs.webkit.org/show_bug.cgi?id=52330
1277
1278         * Scripts/old-run-webkit-tests: Detect when the regression test tool reports
1279         a web process crash.
1280         * WebKitTestRunner/TestController.cpp:
1281         (WTR::TestController::initialize): Set up a processDidCrash
1282         callback.
1283         (WTR::TestController::processDidCrash): Report that the Web process
1284         crashed.
1285         * WebKitTestRunner/TestController.h:
1286
1287 2011-01-12  David Levin  <levin@chromium.org>
1288
1289         Reviewed by Shinichiro Hamaji.
1290
1291         check-webkit-style -- close_expression function doesn't work correctly.
1292         https://bugs.webkit.org/show_bug.cgi?id=52272
1293
1294         * Scripts/webkitpy/style/checkers/cpp.py:
1295         (Position.__str__): Added a way to convert it to a string which is useful in tests.
1296         (Position.__cmp__): Added a way to compare Position which is useful in tests and
1297         generally useful (for upcoming code changes).
1298         (close_expression): Changed to use Position for input and output.
1299         Also, fixed many bugs such as only working correctly for parenthesis,
1300         not working correctly if given an offset in a line and not finding
1301         the real closing element if there were multiple closing elements in
1302         the same line.
1303         (detect_functions): Adjusted due to the change in arguments for
1304         close_expression.
1305         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1306         (CppStyleTestBase.assert_positions_equal): Added a way to verify that
1307         two positions are the same.
1308         (CppStyleTest.test_position): Added tests for the __str_ and __cmp__ methods.
1309         (CppStyleTest.test_close_expression): Added tests to catch the issues
1310         that were fixed.
1311
1312 2011-01-12  Sheriff Bot  <webkit.review.bot@gmail.com>
1313
1314         Unreviewed, rolling out r75576.
1315         http://trac.webkit.org/changeset/75576
1316         https://bugs.webkit.org/show_bug.cgi?id=52304
1317
1318         broke rebaseline-chromium-webkit-test (Requested by thakis on
1319         #webkit).
1320
1321         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1322         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1323         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
1324         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1325         * Scripts/webkitpy/layout_tests/port/base.py:
1326         * Scripts/webkitpy/layout_tests/port/chromium.py:
1327         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1328         * Scripts/webkitpy/layout_tests/port/test.py:
1329         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1330         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1331         * Scripts/webkitpy/style/checkers/test_expectations.py:
1332         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1333
1334 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
1335
1336         Reviewed by Darin Adler.
1337
1338         Add a no-build option to run-webkit-tests, to avoid building DRT/WKTR
1339         https://bugs.webkit.org/show_bug.cgi?id=52307
1340
1341         * Scripts/old-run-webkit-tests:
1342
1343 2011-01-12  Koan-Sin Tan  <koansin.tan@gmail.com>
1344
1345         Reviewed by Martin Robinson.
1346
1347         [Gtk] WebKitGtk+ doesn't build on Mac OS X 10.6
1348         https://bugs.webkit.org/show_bug.cgi?id=50867
1349
1350         Fixed library extention for Mac in webkitdirs.pm and type conflict in
1351         TestNetscapePlugin.cpp 
1352
1353         * GNUmakefile.am: Don't use AppKit when compiling TestNetscapePlugin for GTK+
1354         * Scripts/webkitdirs.pm:
1355
1356 2011-01-12  Mikhail Naganov  <mnaganov@chromium.org>
1357
1358         Reviewed by Pavel Feldman.
1359
1360         Add check-inspector-strings script.
1361
1362         https://bugs.webkit.org/show_bug.cgi?id=52295
1363
1364         * Scripts/check-inspector-strings: Added.
1365
1366 2011-01-12  Adam Roben  <aroben@apple.com>
1367
1368         Advertise the .testnetscape file extension on Windows
1369
1370         Fixes <http://webkit.org/b/52298>
1371         plugins/no-mime-with-valid-extension.html fails on Windows
1372
1373         Reviewed by Dan Bernstein.
1374
1375         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Added a
1376         FileExtents field to map the .testnetscape file extension to the
1377         application/x-webkit-test-netscape MIME type, just as we do on Mac.
1378
1379 2011-01-12  Adam Barth  <abarth@webkit.org>
1380
1381         Reviewed by Eric Seidel.
1382
1383         Make webkit-patch support subdirectories for SVN checkouts
1384         https://bugs.webkit.org/show_bug.cgi?id=52261
1385
1386         os.relpath does not exist on Python 2.5, so we need to call our version
1387         of the API.
1388
1389         * Scripts/webkitpy/common/checkout/scm.py:
1390
1391 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
1392
1393         Reviewed by Eric Seidel.
1394
1395         Close additional pages opened during a test once the test completes.
1396         https://bugs.webkit.org/show_bug.cgi?id=52276
1397
1398         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1399         (WTR::InjectedBundle::done):
1400
1401 2011-01-11  David Levin  <levin@chromium.org>
1402
1403         Reviewed by Eric Seidel.
1404
1405         Errors should be separated from the command line in bot messages.
1406         https://bugs.webkit.org/show_bug.cgi?id=52275
1407
1408         * Scripts/webkitpy/common/system/executive.py:
1409         (ScriptError.message_with_output): Added a newline to separate the command
1410         line from the errors.
1411         * Scripts/webkitpy/common/system/executive_unittest.py:
1412         (ScriptErrorTest.test_message_with_output): Added tests for the various code
1413         paths in message_with_output.
1414
1415 2011-01-11  Eric Seidel  <eric@webkit.org>
1416
1417         Unreviewed.
1418
1419         commit-queue should know how to upload archived results (for test flakes or general failures)
1420         https://bugs.webkit.org/show_bug.cgi?id=52048
1421
1422         The zips are mostly empty due to forgetting -r.
1423         Expected diffs were not being pulled from the archive due
1424         to the archive having longer paths than I realized.
1425
1426         * Scripts/webkitpy/common/system/workspace.py:
1427         * Scripts/webkitpy/common/system/workspace_unittest.py:
1428         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1429         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1430
1431 2011-01-11  Dirk Pranke  <dpranke@chromium.org>
1432
1433         Reviewed by Ojan Vafai.
1434
1435         The current modifier parsing code in test_expectations is
1436         fragile and hard-coded, so it's not easy to understand the logic
1437         or easily add new types of modifiers (like GPU vs. CPU testing
1438         for graphics tests, or 32-bit vs. 64-bit differences).
1439
1440         This is the first of two patches that will add in more generic
1441         support and then eliminate the GPU-specific test expectations
1442         files for Chromium.
1443
1444         This patch adds two standalone objects for handling modifiers. The
1445         rules for interpreting modifiers, precedence, and conflicts are
1446         given in the docstring to the ModifierMatcher class, which
1447         returns ModifierMatchResult objects.
1448         
1449         This patch also adds routines to the Port interface and a
1450         default set of values in the base object, in order to obtain the
1451         values needed on a given test run. These values are then passed
1452         to the expectation parser. This also allows us to clean up the
1453         logic used to lint all of the different configurations in a
1454         single test_expectations.txt file.
1455
1456         The next patch will merge in the separate GPU expectations file.
1457
1458         https://bugs.webkit.org/show_bug.cgi?id=51222
1459
1460         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1461         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1462         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
1463         * Scripts/webkitpy/layout_tests/port/base.py:
1464         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1465         * Scripts/webkitpy/layout_tests/port/chromium.py:
1466         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1467         * Scripts/webkitpy/layout_tests/port/test.py:
1468         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1469         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1470
1471 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
1472
1473         Reviewed by Adam Barth.
1474
1475         Make webkit-patch support subdirectories for SVN checkouts
1476         https://bugs.webkit.org/show_bug.cgi?id=52261
1477
1478         * Scripts/webkitpy/common/checkout/scm.py:
1479         * Scripts/webkitpy/style_references.py:
1480         * Scripts/webkitpy/tool/main.py:
1481         * Scripts/webkitpy/tool/steps/preparechangelog.py:
1482
1483 2011-01-11  Eric Seidel  <eric@webkit.org>
1484
1485         Unreviewed.
1486
1487         commit-queue should know how to upload archived results (for test flakes or general failures)
1488         https://bugs.webkit.org/show_bug.cgi?id=52048
1489
1490         I changed the API for archive_last_layout_test_results w/o updating the implementation.  Oops.
1491         This fixes an exception seen on the commit-queue when attempting to report flaky tests.
1492
1493         * Scripts/webkitpy/common/system/workspace.py:
1494         * Scripts/webkitpy/common/system/workspace_unittest.py:
1495         * Scripts/webkitpy/tool/commands/queues.py:
1496
1497 2011-01-11  Sam Weinig  <sam@webkit.org>
1498
1499         Roll r75474 back in.
1500
1501 2011-01-11  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
1502
1503         Reviewed by Kenneth Rohde Christiansen.
1504
1505         [Qt] Remove uses of QFuture since it isn't supported on all platforms.
1506         https://bugs.webkit.org/show_bug.cgi?id=51204
1507
1508         * QtTestBrowser/webpage.h:
1509         (QtNAMThread::QtNAMThread):
1510         (QtNAMThread::networkAccessManager):
1511         (QtNAMThread::run):
1512
1513 2011-01-11  Peter Varga  <pvarga@webkit.org>
1514
1515         Unreviewed.
1516
1517         Add myself to committers' list.
1518
1519         * Scripts/webkitpy/common/config/committers.py:
1520
1521 2011-01-11  Eric Seidel  <eric@webkit.org>
1522
1523         Reviewed by Adam Barth.
1524
1525         commit-queue should know how to upload archived results (for test flakes or general failures)
1526         https://bugs.webkit.org/show_bug.cgi?id=52048
1527
1528         Now the queue will always upload results.  Either the entire zip, or just
1529         the diffs.txt in the case of text failures.
1530
1531         This should make understanding flakes much easier, and paves the way
1532         for having the EWS run layout tests (and upload failures).
1533
1534         In order to upload .zip files I had to teach bugzilla.py to autodetect
1535         mime types from the filename.  Since mimetypes.py doesn't include a mapping
1536         for .patch files, I have it add one before calling guess_type.
1537
1538         We may find that always uploading the whole zip instead of just the -diffs.txt
1539         file is preferable, but for now I'm keeping the old behavior because it makes
1540         quickly understanding text failures easy.
1541
1542         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1543         * Scripts/webkitpy/common/system/workspace.py: Added.
1544         * Scripts/webkitpy/common/system/workspace_unittest.py: Added.
1545         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1546         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1547         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1548         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1549         * Scripts/webkitpy/tool/commands/queues.py:
1550         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1551
1552 2011-01-10  Sheriff Bot  <webkit.review.bot@gmail.com>
1553
1554         Unreviewed, rolling out r75464.
1555         http://trac.webkit.org/changeset/75464
1556         https://bugs.webkit.org/show_bug.cgi?id=52193
1557
1558         Followup rollout for 75474 (Requested by Ossy on #webkit).
1559
1560         * MiniBrowser/mac/BrowserWindowController.m:
1561         (-[BrowserWindowController awakeFromNib]):
1562         * MiniBrowser/win/BrowserView.cpp:
1563         (BrowserView::create):
1564         * WebKitTestRunner/TestController.cpp:
1565         (WTR::createOtherPage):
1566         (WTR::TestController::initialize):
1567
1568 2011-01-10  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1569
1570         Reviewed by Csaba Osztrogonác.
1571
1572         [Qt] Baseline qt_minimal configuration
1573         https://bugs.webkit.org/show_bug.cgi?id=51313
1574
1575         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1576         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): Add
1577         QT_NO_UNDOSTACK guard.
1578
1579         * QtTestBrowser/launcherwindow.cpp:
1580         (LauncherWindow::createChrome): Add QT_NO_SHORTCUT and QT_NO_PRINTER
1581         guards.
1582         (LauncherWindow::applyZoom): Add QT_NO_ANIMATION guard.
1583         (LauncherWindow::screenshot): Add QT_NO_FILEDIALOG guard.
1584         (LauncherWindow::selectElements): Add QT_NO_INPUTDIALOG guard.
1585         (LauncherWindow::showUserAgentDialog): Add QT_NO_COMBOBOX guard.
1586
1587         * QtTestBrowser/launcherwindow.h:
1588         * QtTestBrowser/locationedit.cpp: Add QT_NO_INPUTDIALOG guard.
1589         * QtTestBrowser/locationedit.h: Ditto.
1590
1591         * QtTestBrowser/mainwindow.cpp:
1592         (MainWindow::buildUI): Add QT_NO_INPUTDIALOG, QT_NO_SHORTCUT and
1593         QT_NO_UNDOSTACK guards.
1594         (MainWindow::setAddressUrl): Add QT_NO_INPUTDIALOG guard.
1595         (MainWindow::changeLocation): Ditto.
1596         (MainWindow::openFile): Add QT_NO_FILEDIALOG guard.
1597         (MainWindow::openLocation): Add QT_NO_INPUTDIALOG guard.
1598
1599         * QtTestBrowser/webpage.cpp:
1600         (WebPage::openUrlInDefaultBrowser): Add QT_NO_DESKTOPSERVICES guard.
1601         (WebPage::authenticationRequired): Add QT_NO_LINEEDIT guard.
1602
1603         * QtTestBrowser/webview.cpp:
1604         (WebViewGraphicsBased::animatedFlip): Add QT_NO_ANIMATION guard.
1605         (WebViewGraphicsBased::animatedYFlip): Ditto.
1606
1607 2011-01-10  Sam Weinig  <sam@webkit.org>
1608
1609         Fix build.
1610
1611         * MiniBrowser/mac/BrowserWindowController.m:
1612         (-[BrowserWindowController awakeFromNib]):
1613         * MiniBrowser/win/BrowserView.cpp:
1614         (BrowserView::create):
1615         * WebKitTestRunner/TestController.cpp:
1616         (WTR::createOtherPage):
1617         (WTR::TestController::initialize):
1618
1619 2011-01-10  Eric Seidel  <eric@webkit.org>
1620
1621         Reviewed by Ojan Vafai.
1622
1623         style-queue messages are way too long for big patches
1624         https://bugs.webkit.org/show_bug.cgi?id=52161
1625
1626         We definitely could build much fancier list-to-string-with-limit functions
1627         but this should be sufficient for our needs at the moment.
1628
1629         * Scripts/webkitpy/common/system/executive.py:
1630         * Scripts/webkitpy/common/system/executive_unittest.py:
1631
1632 2011-01-10  Tony Chang  <tony@chromium.org>
1633
1634         Unreviewed, rolling out r75398.
1635         http://trac.webkit.org/changeset/75398
1636         https://bugs.webkit.org/show_bug.cgi?id=52008
1637
1638         Some layout tests are crashing on Chromium Win.
1639
1640         * DumpRenderTree/chromium/WebViewHost.cpp:
1641         (WebViewHost::updatePaintRect):
1642         * DumpRenderTree/chromium/WebViewHost.h:
1643
1644 2011-01-10  Adam Roben  <aroben@apple.com>
1645
1646         Roll out r75392
1647
1648         It isn't needed now that r75289 has been rolled out.
1649
1650         * Scripts/run-javascriptcore-tests:
1651
1652 2011-01-10  Maciej Stachowiak  <mjs@apple.com>
1653
1654         Reviewed by Anders Carlsson.
1655
1656         WebKitTestRunner uses crazy amounts of CPU, making layout tests slow and flaky
1657         https://bugs.webkit.org/show_bug.cgi?id=52160
1658
1659         * WebKitTestRunner/mac/TestControllerMac.mm:
1660         (WTR::TestController::platformRunUntil): Instead of busy-looping, wait for the timeout.
1661         Anything that can make runUntil() conditions turn true will happen on a run loop cycle
1662         anyway.
1663
1664 2011-01-10  Tony Chang  <tony@chromium.org>
1665
1666         Reviewed by Mihai Parparita.
1667
1668         [chromium] fix for animated gif layout tests
1669         https://bugs.webkit.org/show_bug.cgi?id=52008
1670
1671         * DumpRenderTree/chromium/WebViewHost.cpp: Schedule a paint when we update the paint rect
1672             to trigger gif animations.
1673         (WebViewHostPaintTask::WebViewHostPaintTask):
1674         (WebViewHostPaintTask::runIfValid):
1675         (WebViewHost::updatePaintRect):
1676         * DumpRenderTree/chromium/WebViewHost.h:
1677         (WebViewHost::taskList):
1678
1679 2011-01-10  Alejandro G. Castro  <alex@igalia.com>
1680
1681         Reviewed by Xan Lopez.
1682
1683         [GTK] Fix gtk2 compilation for master
1684         https://bugs.webkit.org/show_bug.cgi?id=51885
1685
1686         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
1687         (createBitmapContextFromWebView): Replaced the old
1688         gdk_drawable_get_size with gdk_pixmap_get_size.
1689
1690 2011-01-10  Patrick Gansterer  <paroga@webkit.org>
1691
1692         Reviewed by Laszlo Gombos.
1693
1694         [WINCE] Reenable NPAPI after r75203
1695         https://bugs.webkit.org/show_bug.cgi?id=52109
1696
1697         Remove the !isWinCE() check for ENABLE_NETSCAPE_PLUGIN_API and replace
1698         it with !isEfl(), because EFL port does not support NPAPI (yet).
1699
1700         * Scripts/build-webkit:
1701
1702 2011-01-10  Adam Roben  <aroben@apple.com>
1703
1704         Skip some asserting JS tests
1705
1706         See <http://webkit.org/b/52156>.
1707
1708         * Scripts/run-javascriptcore-tests:
1709
1710 2011-01-10  Martin Robinson  <mrobinson@igalia.com>
1711
1712         Reviewed by Xan Lopez.
1713
1714         [GTK] build-webkit disable Blob support via arguments passed to automake
1715         https://bugs.webkit.org/show_bug.cgi?id=52097
1716
1717         * Scripts/build-webkit: Enable Blob support when building WebKitGTK+ via
1718         build-webkit.
1719
1720 2011-01-10  Adam Roben  <aroben@apple.com>
1721
1722         Use the same name and description for TestNetscapePlugin on Windows and
1723         Mac
1724
1725         Fixes <http://webkit.org/b/52151>
1726         fast/frames/iframe-reparenting-plugins.html fails on Windows
1727
1728         Reviewed by Steve Falkenburg.
1729
1730         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Copied
1731         the name and description from Mac's Info.plist.
1732
1733 2011-01-10  Siddharth Mathur <siddharth.mathur@nokia.com>
1734
1735         Reviewed by Laszlo Gombos.
1736
1737         [Qt][WK2] Guard gcc-specific syntax
1738
1739         Non-gcc based compliers choke on the "-include"
1740         syntax for preinclude, place guard around it.
1741
1742         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1743         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1744
1745 2011-01-10  Andreas Kling  <kling@webkit.org>
1746
1747         Reviewed by Simon Hausmann.
1748
1749         [Qt] [WK2] MiniBrowser does not load pages opened in new windows
1750         https://bugs.webkit.org/show_bug.cgi?id=52111
1751
1752         When getting a createNewPage() callback from QWKPage, create the
1753         new page with the same QWKContext as the page that is passed to
1754         the callback.
1755
1756         * MiniBrowser/qt/BrowserView.h:
1757         * MiniBrowser/qt/BrowserWindow.cpp:
1758         (newPageFunction):
1759         (BrowserWindow::BrowserWindow):
1760         * MiniBrowser/qt/BrowserWindow.h:
1761
1762 2011-01-10  Andreas Kling  <kling@webkit.org>
1763
1764         Reviewed by Kenneth Rohde Christiansen.
1765
1766         [Qt] MiniBrowser: Remove superfluous createNewPage() callback
1767
1768         BrowserView set its own useless createNewPage() callback on QWKPage.
1769         This was immediately overridden by BrowserWindow anyway, so remove
1770         the BrowserView one.
1771
1772         * MiniBrowser/qt/BrowserView.cpp:
1773         (BrowserView::BrowserView):
1774
1775 2011-01-10  John Knottenbelt  <jknotten@chromium.org>
1776
1777         Reviewed by Jeremy Orlow.
1778
1779         [Chromium] Remove non-client-based Geolocation code
1780         https://bugs.webkit.org/show_bug.cgi?id=50921
1781
1782         * DumpRenderTree/chromium/LayoutTestController.cpp:
1783         (LayoutTestController::setGeolocationPermission):
1784         (LayoutTestController::setMockGeolocationPosition):
1785         (LayoutTestController::setMockGeolocationError):
1786         * DumpRenderTree/chromium/WebViewHost.cpp:
1787         (WebViewHost::geolocationClientMock):
1788         (WebViewHost::reset):
1789         * DumpRenderTree/chromium/WebViewHost.h:
1790
1791 2011-01-10  Eric Seidel  <eric@webkit.org>
1792
1793         Reviewed by Adam Barth.
1794
1795         Commit bot tried to land r? cq+ patch
1796         https://bugs.webkit.org/show_bug.cgi?id=36638
1797
1798         It should now be possible to post a patch with r? and cq+ and the
1799         commit-queue will correctly wait for the r+ before attempting to land the patch.
1800         (This was a feature requested by several users.)
1801
1802         One caveat: We don't actually reject r-, cq+ patches from the queue
1803         (we just ignore them), but I think that's OK for now.
1804
1805         I also noticed that setting r- once a commit-queue node had grabbed
1806         a patch would not properly cancel the landing.  That's fixed and
1807         tested in this patch.
1808
1809         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1810         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1811         * Scripts/webkitpy/tool/bot/feeders.py:
1812         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
1813
1814 2011-01-08  Benjamin Poulain  <benjamin.poulain@nokia.com>
1815
1816         Reviewed by Kenneth Rohde Christiansen.
1817
1818         [Qt] QtWebKit crashes when using XMLHttpRequest from the unload event
1819         https://bugs.webkit.org/show_bug.cgi?id=51934
1820
1821         When accessing the network from the destructor of QWebPage, the network access manager
1822         was already deleted because the object WebPage was already destructed.
1823
1824         This solve the problem by linking the lifetime of the network access manager to WebPage's QObject.
1825         The object is now destructed in the destructor of QObject.
1826
1827         * QtTestBrowser/webpage.cpp:
1828         (WebPage::WebPage):
1829         (WebPage::setQnamThreaded):
1830         * QtTestBrowser/webpage.h:
1831         (QtNAMThread::QtNAMThread):
1832
1833 2011-01-08  Eric Seidel  <eric@webkit.org>
1834
1835         Reviewed by Ojan Vafai.
1836
1837         test_failures.py should not mention TestShell (long live DumpRenderTree!)
1838         https://bugs.webkit.org/show_bug.cgi?id=52067
1839
1840         I ran test-webkitpy, but didn't bother adding a unit test for this string change.
1841         https://bugs.webkit.org/show_bug.cgi?id=51138#c3 is an example of why this is needed.
1842
1843         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1844
1845 2011-01-08  Eric Seidel  <eric@webkit.org>
1846
1847         Reviewed by Mihai Parparita.
1848
1849         commit-queue hangs when the ChangeLog diff is bad
1850         https://bugs.webkit.org/show_bug.cgi?id=52072
1851
1852         * Scripts/webkitpy/tool/steps/validatechangelogs.py:
1853         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
1854
1855 2011-01-08  Adam Barth  <abarth@webkit.org>
1856
1857         Teach svn-apply how to re-write WebCore to Source/WebCore.
1858
1859         * Scripts/VCSUtils.pm:
1860
1861 2011-01-07  Adam Barth  <abarth@webkit.org>
1862
1863         Rubber-stamped by Eric Seidel.
1864
1865         Move WebCore to Source
1866         https://bugs.webkit.org/show_bug.cgi?id=52050
1867
1868         Update the tools to understand WebCore's new location.
1869
1870         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1871         * DumpRenderTree/wscript:
1872         * GNUmakefile.am:
1873         * Scripts/build-webkit:
1874         * Scripts/do-file-rename:
1875         * Scripts/do-webcore-rename:
1876         * Scripts/generate-qt-inspector-resource:
1877         * Scripts/prepare-ChangeLog:
1878         * Scripts/run-bindings-tests:
1879         * Scripts/update-iexploder-cssproperties:
1880         * Scripts/update-sources-list.py:
1881         * Scripts/update-webkit-localizable-strings:
1882         * Scripts/webkitdirs.pm:
1883         * Scripts/webkitpy/common/config/build.py:
1884         * Scripts/webkitpy/common/config/build_unittest.py:
1885         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
1886         * Scripts/webkitpy/style/checker.py:
1887         * Scripts/webkitpy/style/checker_unittest.py:
1888         * WebKitTestRunner/DerivedSources.pro:
1889         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1890         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh:
1891         * wx/browser/wscript:
1892         * wx/build/settings.py:
1893
1894 2011-01-07  Maciej Stachowiak  <mjs@apple.com>
1895
1896         Reviewed by Sam Weinig.
1897
1898         Make WebKitTestRunner rest between loads more robust to avoid test crashes
1899         https://bugs.webkit.org/show_bug.cgi?id=52086
1900
1901         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1902         (WTR::InjectedBundle::didReceiveMessage):
1903         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1904         (WTR::LayoutTestController::notifyDone):
1905         * WebKitTestRunner/TestController.cpp:
1906         (WTR::TestController::resetStateToConsistentValues):
1907         (WTR::TestController::run):
1908
1909 2011-01-07  James Robinson  <jamesr@chromium.org>
1910
1911         Revert "Implement mozilla's animationTime property"
1912         https://bugs.webkit.org/show_bug.cgi?id=51952
1913
1914         This approach isn't quite right.
1915
1916         * DumpRenderTree/chromium/WebViewHost.cpp:
1917         (WebViewHost::paintInvalidatedRegion):
1918
1919 2011-01-07  Adam Roben  <aroben@apple.com>
1920
1921         Build master fix
1922
1923         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1924         (RunWebKitTests.start): Don't try to concatenate a list and a string.
1925
1926 2011-01-07  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>
1927
1928         Reviewed by Csaba Osztrogonác.
1929
1930         run-qtwebkit-tests should be able to kill a testsuite.
1931
1932         Add new option in the script that can setup a timeout for a test.
1933         If the test execution takes more then specified time then the test
1934         would be terminated.
1935
1936         [Qt] run-qtwebkit-tests needs timeout
1937         https://bugs.webkit.org/show_bug.cgi?id=51894
1938
1939         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1940         * Scripts/run-qtwebkit-tests:
1941
1942 2011-01-07  Csaba Osztrogonác  <ossy@webkit.org>
1943
1944         Unreviewed fix after r75233.
1945
1946         Based on idea from Eric Seidel.
1947
1948         Add remote zip file handling to webkitpy.
1949         https://bugs.webkit.org/show_bug.cgi?id=50901
1950
1951         * Scripts/webkitpy/common/system/fileset.py: Make python 2.5 happy.
1952
1953 2011-01-07  Shane Stephens  <shanestephens@google.com>
1954
1955         Reviewed by Eric Seidel.
1956
1957         svn-apply: should support git binary delta diffs
1958         https://bugs.webkit.org/show_bug.cgi?id=38864
1959
1960         * Scripts/VCSUtils.pm:
1961         * Scripts/svn-apply:
1962
1963 2011-01-06  Julie Parent  <jparent@chromium.org>
1964
1965         Reviewed by Eric Seidel.
1966
1967         Test Result Server not removing old results.
1968         https://bugs.webkit.org/show_bug.cgi?id=52012
1969
1970         * TestResultServer/model/jsonresults.py:
1971         Fix off-by-one: Truncate if >= num_runs, not just >.
1972         * TestResultServer/model/jsonresults_unittest.py:
1973         Add unit test to test that merging in a new result with the same value
1974         as the last result causes previous result to fall off.
1975
1976 2011-01-06  James Kozianski  <koz@chromium.org>
1977
1978         Reviewed by Mihai Parparita.
1979
1980         Add classes to provide a consistent interface to a set of files.
1981         https://bugs.webkit.org/show_bug.cgi?id=50901
1982
1983         These classes allow us to write code that is agnostic to whether a
1984         particular set of files resides in a local directory or in a zip file
1985         on a remote machine.
1986
1987         * Scripts/webkitpy/common/system/directoryfileset.py: Added.
1988         * Scripts/webkitpy/common/system/directoryfileset_unittest.py: Added.
1989         * Scripts/webkitpy/common/system/fileset.py: Added.
1990         * Scripts/webkitpy/common/system/filesystem.py:
1991         * Scripts/webkitpy/common/system/filesystem_mock.py:
1992         * Scripts/webkitpy/common/system/zipfileset.py: Added.
1993         * Scripts/webkitpy/common/system/zipfileset_unittest.py: Added.
1994
1995 2011-01-06  Eric Seidel  <eric@webkit.org>
1996
1997         Reviewed by Adam Barth.
1998
1999         NetworkTransaction should log the url it is retrying
2000         https://bugs.webkit.org/show_bug.cgi?id=52043
2001
2002         * Scripts/webkitpy/common/net/networktransaction.py:
2003         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
2004
2005 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
2006
2007         Windows build fix.
2008         Import os before using it.
2009
2010         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2011
2012 2011-01-06  Eric Seidel  <eric@webkit.org>
2013
2014         Reviewed by Adam Barth.
2015
2016         StyleQueue fails to report errors when patches have many files
2017         https://bugs.webkit.org/show_bug.cgi?id=52042
2018
2019         This is one of at least two errors preventing style error reporting at the moment.
2020         When we moved to passing the list of files to check explicitly,
2021         we started to exceed the 500 character TEXT field limit for our AppEngine model object.
2022         We could change the type of the QueueStatus.message type, or we could
2023         just teach statusserver.py how to clamp values (and warn when it does).
2024         I chose the latter path.
2025
2026         * Scripts/webkitpy/common/net/statusserver.py:
2027
2028 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
2029
2030         Reviewed by Stephanie Lewis.
2031         
2032         Fix syntax error in script.
2033
2034         Windows bots need to archive/unarchive builds to/from configuration-specific directories
2035         https://bugs.webkit.org/show_bug.cgi?id=51996
2036
2037         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2038
2039 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2040
2041         Unreviewed, fixing WinCE build after r75196.
2042
2043         WinCE port does not (yet) support NPAPI.
2044
2045         * Scripts/build-webkit:
2046
2047 2011-01-06  Xan Lopez  <xlopez@igalia.com>
2048
2049         Reviewed by Darin Adler.
2050
2051         File::Spec->rel2abs in sunspider-compare-results mangles parameters
2052         https://bugs.webkit.org/show_bug.cgi?id=52015
2053
2054         * Scripts/sunspider-compare-results: call rel2abs on our arguments
2055         after the platform has been detected, otherwise the script will
2056         mangle things like '--gtk' into '/a/path/--gtk', breaking the
2057         detection.
2058
2059 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2060
2061         Reviewed by Eric Seidel.
2062
2063         Add ENABLE_NETSCAPE_PLUGIN_API, ENABLE_ORIENTATION_EVENTS and ENABLE_TOUCH_EVENTS flags to build-webkit
2064         https://bugs.webkit.org/show_bug.cgi?id=51346
2065
2066         * Scripts/build-webkit:
2067
2068 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
2069
2070         Reviewed by Adam Roben.
2071
2072         Windows bots need to archive/unarchive builds to/from configuration-specific directories
2073         https://bugs.webkit.org/show_bug.cgi?id=51996
2074         
2075         After the configuration directory change, we were archiving the incorrect directory for
2076         build product, so we were running tests on the wrong binaries.
2077         
2078         This change archives the correct directory, and also unarchives it into a configuration-
2079         specific directory.
2080
2081         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Use a configuration-specific directory on Windows.
2082         * BuildSlaveSupport/built-product-archive: Unarchive/archive to/from proper directory.
2083
2084 2011-01-06  Eric Seidel  <eric@webkit.org>
2085
2086         Reviewed by Mihai Parparita.
2087
2088         commit-queue mentions "Text diff mismatch" 4 times instead of once per failure
2089         https://bugs.webkit.org/show_bug.cgi?id=52002
2090
2091         See an example of this here:
2092         https://bugs.webkit.org/show_bug.cgi?id=51314#c2
2093
2094         It's due to the fact that we pass around TestFailure() instance
2095         objects and yet expect them to all compare to be the same.
2096
2097         This is bad.  We should either have shared instances of these values
2098         or we should just pass around the class names.  There are already hacks
2099         in place to make TestFailure objects pass equality tests, I just added
2100         a __hash__ implementation so they can be used in sets as expected.
2101
2102         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2103         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
2104
2105 2011-01-06  Evan Martin  <evan@chromium.org>
2106
2107         Reviewed by Tony Chang.
2108
2109         [gdb] handle inaccessible memory and UChar*
2110         https://bugs.webkit.org/show_bug.cgi?id=52003
2111
2112         To pretty-print a UChar*, we just grope around in the memory
2113         looking for a terminating NUL.  We need to handle the exception
2114         that can occur when we poke into an invalid location.
2115
2116         Additionally, the logic for choosing which pretty-printer would
2117         early return before hitting the point where we'd use the UChar*
2118         printer.  (Did this ever work?  How did it regress?)
2119
2120         * gdb/webkit.py:
2121
2122 2011-01-05  Brian Weinstein  <bweinstein@apple.com>
2123
2124         Reviewed by Ada Chan.
2125
2126         WebKit2: Should be able to call into injected bundle to ask if we should allow resource loads
2127         https://bugs.webkit.org/show_bug.cgi?id=51969
2128         
2129         Add shouldLoadResourceForFrame to WTR::InjectedBundlePage.
2130
2131         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2132         (WTR::InjectedBundlePage::InjectedBundlePage):
2133         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Stub implementation.
2134         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2135
2136 2011-01-06  James Robinson  <jamesr@chromium.org>
2137
2138         Reviewed by Simon Fraser.
2139
2140         Implement mozilla's animationTime property
2141         https://bugs.webkit.org/show_bug.cgi?id=51952
2142
2143         Chromium DRT support for webkitAnimationTime.
2144
2145         * DumpRenderTree/chromium/WebViewHost.cpp:
2146         (WebViewHost::paintInvalidatedRegion):
2147
2148 2011-01-06  Julie Parent  <jparent@chromium.org>
2149
2150         Reviewed by Tony Chang.
2151
2152         Test Result Server always truncates number of results to JSON_RESULTS_MAX_BUILDS
2153         https://bugs.webkit.org/show_bug.cgi?id=51217
2154
2155         * TestResultServer/model/jsonresults.py:
2156         Pass num_runs through to _remove_items_over_max_number_of_builds, and use the value.
2157         Adds missing documentation.
2158         * TestResultServer/model/jsonresults_unittest.py:
2159         Add unit test to test that truncation happens at smaller value than JSON_RESULTS_MAX_BUILDS.
2160         Update test_merge to take a number of builds to truncate at.
2161
2162 2011-01-06  Adam Barth  <abarth@webkit.org>
2163
2164         Reviewed by Eric Seidel.
2165
2166         The EWS should log outside of the working directory
2167         https://bugs.webkit.org/show_bug.cgi?id=51986
2168
2169         This patch prepare us for using git clean -x -d -f in the EWS wrapper
2170         script, which will actually clean the working copy back to a pristine
2171         state instead of leaving untracked directories and ignored files.
2172
2173         * Scripts/webkitpy/tool/commands/queues.py:
2174         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2175
2176 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
2177
2178         Windows build fix.
2179         Back out attempted change to built-product-archive.
2180
2181         * BuildSlaveSupport/built-product-archive:
2182
2183 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
2184
2185         Windows build fix.
2186         Include configuration name when unpacking a build archive.
2187
2188         Needed, since we split Windows build results into configuration-specific directories
2189         under WebKitOutputDir.
2190
2191         * BuildSlaveSupport/built-product-archive:
2192
2193 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
2194
2195         Reviewed by Darin Adler.
2196
2197         Debug and Release builds on Windows clobber each other
2198         https://bugs.webkit.org/show_bug.cgi?id=49185
2199
2200         Changes the structure of WebKitBuild build products directory so we
2201         completely separate each build configuration into independent directories.
2202         
2203         Although we previously had per-configuration directories for obj, this change adds
2204         per-configuration directories for bin, lib, obj, and include. Each configuration's
2205         build products are stored within a directory inside of WebKitBuild.
2206         
2207         Most use of $(WebKitOutputDir) in the build files has been replaced by $(ConfigurationBuildDir),
2208         defined in common.vsprops to be $(WebKitOutputDir)\$(ConfigurationName).
2209
2210         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops:
2211         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd:
2212         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd:
2213         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
2214         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd:
2215         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd:
2216         * DumpRenderTree/win/ImageDiffCommon.vsprops:
2217         * DumpRenderTree/win/ImageDiffPostBuild.cmd:
2218         * DumpRenderTree/win/ImageDiffPreBuild.cmd:
2219         * FindSafari/FindSafari.vcproj:
2220         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
2221         * MiniBrowser/MiniBrowserPostBuild.cmd:
2222         * MiniBrowser/MiniBrowserPreBuild.cmd:
2223         * Scripts/webkitdirs.pm:
2224         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
2225         * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops:
2226         * TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd:
2227         * TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd:
2228         * TestWebKitAPI/win/copy-resources.cmd:
2229         * WebKitAPITest/WebKitAPITestCommon.vsprops:
2230         * WebKitAPITest/WebKitAPITestPostBuild.cmd:
2231         * WebKitAPITest/WebKitAPITestPreBuild.cmd:
2232         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
2233         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
2234         * WebKitTestRunner/win/InjectedBundle.vcproj:
2235         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops:
2236         * WebKitTestRunner/win/InjectedBundlePostBuild.cmd:
2237         * WebKitTestRunner/win/InjectedBundlePreBuild.cmd:
2238         * WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd:
2239         * WebKitTestRunner/win/WebKitTestRunnerPreBuild.cmd:
2240         * WinLauncher/WinLauncherCommon.vsprops:
2241         * WinLauncher/WinLauncherPostBuild.cmd:
2242         * WinLauncher/WinLauncherPreBuild.cmd:
2243
2244 2011-01-05  Jan Erik Hanssen  <jhanssen@sencha.com>
2245
2246         Reviewed by Ariya Hidayat.
2247
2248         [Qt] TestNetscapePlugin doesn't link on OS X
2249         https://bugs.webkit.org/show_bug.cgi?id=51948
2250
2251         Only add a dependency on libX11 on X11 systems
2252
2253         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2254
2255 2011-01-05  Jeff Miller  <jeffm@apple.com>
2256
2257         Reviewed by Adam Roben.
2258
2259         check-webkit-style should allow unnecessary parameter names in WebKit2 APIs because we're matching CF's header style
2260         https://bugs.webkit.org/show_bug.cgi?id=51970
2261
2262         * Scripts/webkitpy/style/checker.py:
2263         Add -readability/naming for WebKit2 C API directories.
2264
2265 2011-01-05  Eric Seidel  <eric@webkit.org>
2266
2267         Unreviewed, just fixing one more log error from my previous python patch.
2268
2269         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
2270         https://bugs.webkit.org/show_bug.cgi?id=51802
2271
2272         webkit-patch failure-reason was logging about parsing errors
2273         due to my misunderstanding of how BeautifulSoup.findAll worked.
2274
2275         Fixed, and added a unit test.
2276
2277         * Scripts/webkitpy/common/net/layouttestresults.py:
2278         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2279
2280 2011-01-05  Benjamin Poulain  <benjamin.poulain@nokia.com>
2281
2282         Reviewed by Kenneth Rohde Christiansen.
2283
2284         [Qt] [WK2] Add the possibility to open window from the WebProcess in Minibrowser
2285         https://bugs.webkit.org/show_bug.cgi?id=51951
2286
2287         Set a function to QWKPage::setCreateNewPageFunction() in Minibrowser so there is a way
2288         to create new window from WebKit.
2289
2290         * MiniBrowser/qt/BrowserWindow.cpp:
2291         (newPageFunction):
2292         (BrowserWindow::BrowserWindow):
2293         (BrowserWindow::page): Added to avoid the indirect access to QWKPage spread in the class
2294         (BrowserWindow::newWindow):
2295         (BrowserWindow::updateUserAgentList):
2296         (BrowserWindow::showUserAgentDialog):
2297         * MiniBrowser/qt/BrowserWindow.h: Add the global variable backingStoreTypeForNewWindow to
2298         define the type of the backing store used for new windows.
2299         * MiniBrowser/qt/main.cpp:
2300         (main):
2301
2302 2011-01-05  Eric Seidel  <eric@webkit.org>
2303
2304         Reviewed by Ojan Vafai.
2305
2306         commit-queue should report failure type when reporting flaky tests
2307         https://bugs.webkit.org/show_bug.cgi?id=51900
2308
2309         This patch was a ridiculous amount of plumbing.  In the end I like
2310         the NRWT-style TestResult class even less.  But now we're passing
2311         a list of TestResult objects from the queue to the FlakyTestReporter.
2312         Thus the FlakyTestReporter can more easily report what type of failure
2313         occurred.
2314
2315         In the process, I found that I was not alone in finding TestResult
2316         cumbersome to use.  A bunch of code was trying to create a TestResult
2317         object with default values.  However since the constructor didn't make
2318         this easy, some places were getting it wrong (including the TestResult unit test)!
2319         I've fixed the TestResult constructor to have default values for non-essential
2320         arguments.
2321
2322         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2323         * Scripts/webkitpy/common/net/layouttestresults.py:
2324         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2325         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2326         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2327         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2328         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
2329         * Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py:
2330         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2331         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2332         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2333         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2334         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2335         * Scripts/webkitpy/tool/commands/queues.py:
2336         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2337
2338 2011-01-05  Eric Seidel  <eric@webkit.org>
2339
2340         Unreviewed.
2341
2342         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
2343         https://bugs.webkit.org/show_bug.cgi?id=51802
2344
2345         Add another unit test to cover a previously missing import.
2346
2347         * Scripts/webkitpy/common/net/layouttestresults.py:
2348         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2349
2350 2011-01-05  Mihai Parparita  <mihaip@chromium.org>
2351
2352         Reviewed by David Levin.
2353
2354         Add mihaip@chromium.org as a reviewer
2355         https://bugs.webkit.org/show_bug.cgi?id=51966
2356         
2357         Add myself as a reviewer.
2358
2359         * Scripts/webkitpy/common/config/committers.py:
2360
2361 2011-01-05  James Simonsen  <simonjam@chromium.org>
2362
2363         Unreviewed. Adding myself to the list of committers.
2364
2365         * Scripts/webkitpy/common/config/committers.py:
2366
2367 2011-01-05  Eric Seidel  <eric@webkit.org>
2368
2369         Unreviewed.
2370
2371         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
2372         https://bugs.webkit.org/show_bug.cgi?id=51802
2373
2374         Fix two exceptions seen on the bots after my original commit.
2375
2376         * Scripts/webkitpy/common/net/layouttestresults.py:
2377         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2378
2379 2011-01-05  Kundu Suchismita  <suchi.kundu@nokia.com>
2380
2381         Reviewed by Andreas Kling.
2382
2383         [Qt]Add local storage settings to QtTestBrowser command line arguments 
2384         https://bugs.webkit.org/show_bug.cgi?id=51750
2385
2386         * QtTestBrowser/main.cpp:
2387         (LauncherApplication::handleUserOptions):
2388          Local storage settings can be enable form command line arguments for
2389          QtTestBrowser.
2390
2391 2011-01-05  Chris Fleizach  <cfleizach@apple.com>
2392
2393         Reviewed by Martin Robinson.
2394
2395         GTK: AX: DRT needs to use correct root object method.
2396         https://bugs.webkit.org/show_bug.cgi?id=51911
2397
2398         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
2399         (AccessibilityController::rootElement):
2400
2401 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
2402
2403         Rubber-stamped by Csaba Osztrogonác.
2404
2405         Based on idea from Péter Gál.
2406
2407         * Scripts/webkitpy/tool/bot/sheriff.py: Remove unnecessary apostrophes around revision numbers.
2408
2409 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
2410
2411         Reviewed by Adam Barth.
2412
2413         sheriff-bot should be able to do multi-revision rollouts
2414         https://bugs.webkit.org/show_bug.cgi?id=51176
2415
2416         * Scripts/webkitpy/tool/bot/irc_command.py:
2417         * Scripts/webkitpy/tool/bot/sheriff.py:
2418         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
2419
2420 2011-01-05  Eric Seidel  <eric@webkit.org>
2421
2422         Reviewed by Adam Barth.
2423
2424         queues.webkit.org should have per-bot status pages
2425         https://bugs.webkit.org/show_bug.cgi?id=51906
2426
2427         Just adds a /queue-status/QUEUE_NAME/bots/BOT_ID page to show
2428         statuses from a single queue.  Now that we have many bots servicing
2429         some queues (commit-queue, win-ews, etc.) its easy to have the messages
2430         you care about scroll off the end of the 15-message limit on the main page.
2431
2432         Eventually we should probably rename /queue-status to /queue or /queues,
2433         but that's fodder for another patch.
2434
2435         * QueueStatusServer/handlers/queuestatus.py:
2436         * QueueStatusServer/index.yaml:
2437         * QueueStatusServer/main.py:
2438         * QueueStatusServer/templates/includes/singlequeuestatus.html:
2439          - This probably should use a custom filter instead of hard-coding
2440            the URL scheme here, but I couldn't figure out how to easily
2441            create such a filter.  Most filters work with "strings" so we can't
2442            pass the status object.  We could add a method to the status
2443            object and call that, but that seemed a bit strange too.
2444         * QueueStatusServer/templates/queuestatus.html:
2445
2446 2011-01-05  Carlos Garcia Campos  <cgarcia@igalia.com>
2447
2448         Unreviewed. Adding myself to the list of committers.
2449
2450         * Scripts/webkitpy/common/config/committers.py:
2451
2452 2011-01-04  Koan-Sin Tan  <koansin.tan@gmail.com>
2453
2454         Reviewed by David Levin.
2455
2456         check-webkit-style treated some macros with parentheses after #elif as function calls
2457         https://bugs.webkit.org/show_bug.cgi?id=51695
2458
2459         Ingore function call space checking in any preprocessor directives
2460         (things starting with #). Change search() to match() because 
2461         preprocessor directives are supposed to be in the beginning of lines.
2462
2463         * Scripts/webkitpy/style/checkers/cpp.py:
2464         * Scripts/webkitpy/style/checkers/cpp_unittest.py: make sure there is no false positives for #elif cases
2465
2466 2011-01-04  Søren Gjesse  <sgjesse@chromium.org>
2467
2468         Reviewed by Tony Chang.
2469
2470         Change the --multi-load test option to --stress-opt
2471         https://bugs.webkit.org/show_bug.cgi?id=50751
2472
2473         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2474         (runTest):
2475         (main):
2476         * DumpRenderTree/chromium/TestShell.cpp:
2477         (TestShell::TestShell):
2478         * DumpRenderTree/chromium/TestShell.h:
2479         (TestShell::stressOpt):
2480         (TestShell::setStressOpt):
2481         (TestShell::stressDeopt):
2482         (TestShell::setStressDeopt):
2483         (TestShell::javaScriptFlags):
2484         (TestShell::setJavaScriptFlags):
2485         * Scripts/webkitpy/layout_tests/port/chromium.py:
2486         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2487
2488 2011-01-04  Chris Fleizach  <cfleizach@apple.com>
2489
2490         Reviewed by Sam Weinig.
2491
2492         WK2: Support Accessibility
2493         https://bugs.webkit.org/show_bug.cgi?id=51859
2494
2495         Use rootObject() method to get top of accessibility tree.
2496
2497         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
2498         (AccessibilityController::focusedElement):
2499         (AccessibilityController::rootElement):
2500
2501 2011-01-03  Martin Robinson  <mrobinson@igalia.com>
2502
2503         Reviewed by Darin Adler.
2504
2505         Remove the last non-GObject usage of PlatformRefPtr and move the code to GRefPtr
2506         https://bugs.webkit.org/show_bug.cgi?id=51846
2507
2508         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: Change usage of PlatformRefPtr
2509         back to GRefPtr.
2510
2511 2011-01-04  Zhe Su  <suzhe@chromium.org>
2512
2513         Reviewed by Kenneth Russell.
2514
2515         Fix insertText, setMarkedText and unmarkText methods of
2516         TextInputController to call corresponding methods of WebKit::WebView
2517         rather than WebKit::WebFrame. This change matches the behavior of
2518         chromium browser.
2519         insertText corresponds to WebView::confirmComposition(text)
2520         setMarkedText corresponds to WebView::setComposition(...)
2521         unmarkText corresponds to WebView::confirmComposition()
2522         https://bugs.webkit.org/show_bug.cgi?id=51693
2523
2524         * DumpRenderTree/chromium/TextInputController.cpp:
2525         (TextInputController::insertText):
2526         (TextInputController::setMarkedText):
2527         (TextInputController::unmarkText):
2528
2529 2011-01-04  Dihan Wickremasuriya  <dihan.wickremasuriya@nokia.com>
2530
2531         Reviewed by Laszlo Gombos.
2532
2533         [Qt] [Symbian] Do not remove 0 byte sized files from productDir
2534
2535         On Symbian productDir points to the source directory. Removing all the
2536         empty files from the productDir directory corrupts the svn repository.
2537
2538         * Scripts/build-webkit:
2539
2540 2011-01-03  Yi Shen  <yi.4.shen@nokia.com>
2541
2542         Reviewed by Adam Barth.
2543
2544         [Qt] Add SelectAll option to the context menu for the editor
2545         https://bugs.webkit.org/show_bug.cgi?id=50049
2546
2547         Set shortcut for the SelectAll action.
2548
2549         * QtTestBrowser/mainwindow.cpp:
2550         (MainWindow::buildUI):
2551
2552 2011-01-03  David Levin  <levin@chromium.org>
2553
2554         Reviewed by Eric Seidel.
2555
2556         check-webkit-style shouldn't consider "value" automatically to be a meaningless name.
2557         https://bugs.webkit.org/show_bug.cgi?id=51842
2558
2559         * Scripts/webkitpy/style/checkers/cpp.py: Remove the check for value.
2560         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Remove the test for value.
2561
2562 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
2563
2564         Reviewed by David Kilzer.
2565
2566         [WINCE] Adds a build slave.
2567         https://bugs.webkit.org/show_bug.cgi?id=50523
2568
2569         * BuildSlaveSupport/build.webkit.org-config/config.json: Add an
2570         entry for a release build of the WinCE port.
2571         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add platform
2572         flag to build the WinCE port.
2573
2574 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
2575
2576         Reviewed by David Kilzer.
2577
2578         Add WinCE support to build-webkit
2579         https://bugs.webkit.org/show_bug.cgi?id=51642
2580
2581         * Scripts/build-webkit:
2582         * Scripts/webkitdirs.pm:
2583
2584 2011-01-03  Eric Seidel  <eric@webkit.org>
2585
2586         Reviewed by Adam Barth.
2587
2588         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
2589         https://bugs.webkit.org/show_bug.cgi?id=51802
2590
2591         I'm not the biggest fan of the test_failures or test_results classes,
2592         but it's better to have one shared set of classes, than separate ones
2593         for new vs. old run-webkit-test result handling.
2594
2595         This moves the ORWT results class "LayoutTestResults" over to using
2596         TestResult and TestFailure classes, making it easy for us to
2597         make all our sheriff-bot and other webkitpy code NRWT ready.
2598
2599         This also makes it a trivial patch to generate results.json information
2600         from ORWT results.html files (for flaky test analysis, etc.) as well
2601         as making it a one-liner to report test failure types when the
2602         commit-queue sees flaky tests.
2603
2604         This patch tried not to add new functionality, but only to replace
2605         the guts of LayoutTestResults, while adding unit tests and hoping
2606         not to break anything.
2607
2608         I also moved callers which assumed User.prompt* were static/class methods
2609         to using them as instance methods (since we'll eventually want to make them such).
2610
2611         In the process of re-writing things, I broke the rebaseline command, so I wrote
2612         a unit test to catch my breakage were I do do so again in the future.
2613
2614         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2615         * Scripts/webkitpy/common/net/layouttestresults.py:
2616         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2617         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
2618         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
2619         * Scripts/webkitpy/tool/commands/queries.py:
2620         * Scripts/webkitpy/tool/commands/rebaseline.py:
2621         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2622         * Scripts/webkitpy/tool/mocktool.py:
2623
2624 2011-01-03  Adam Barth  <abarth@webkit.org>
2625
2626         Reviewed by Simon Fraser.
2627
2628         webkit-patch shouldn't waste time cleaning a working directory that's already clean
2629         https://bugs.webkit.org/show_bug.cgi?id=51840
2630
2631         * Scripts/webkitpy/common/checkout/scm.py:
2632
2633 2011-01-03  Adam Barth  <abarth@webkit.org>
2634
2635         Reviewed by Simon Fraser.
2636
2637         webkit-patch should only hide update output if --quiet
2638         https://bugs.webkit.org/show_bug.cgi?id=51838
2639
2640         As requested by smfr.
2641
2642         * Scripts/webkitpy/tool/steps/update.py:
2643
2644 2011-01-03  Adam Barth  <abarth@webkit.org>
2645
2646         Reviewed by David Levin.
2647
2648         commit-queue shouldn't reject patches twice if two bots process the same patch
2649         https://bugs.webkit.org/show_bug.cgi?id=51805
2650
2651         Before raising an error, we first check whether the patch is still in
2652         the commit-queue.  This check is still racy, of course, but the time
2653         window is much smaller.
2654
2655         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2656
2657 2011-01-03  Sam Weinig  <sam@webkit.org>
2658
2659         Reviewed by Anders Carlsson.
2660
2661         Make run-api-tests less chatty.
2662         https://bugs.webkit.org/show_bug.cgi?id=51831
2663
2664         - Make script quiet by default and add --verbose option (replacing --quiet).
2665         - When not verbose, pipe stdout and stderr to devnull.
2666
2667         * Scripts/run-api-tests:
2668
2669 2011-01-03  Pratik Solanki  <psolanki@apple.com>
2670
2671         Unreviewed. Adding myself to committers.py.
2672
2673         * Scripts/webkitpy/common/config/committers.py:
2674
2675 2011-01-03  Koan-Sin Tan  <koansin.tan@gmail.com>
2676
2677         Reviewed by Xan Lopez.
2678
2679         "Tool/Scripts/run-launcher --gtk" stopped working after 74855
2680         https://bugs.webkit.org/show_bug.cgi?id=51806
2681
2682         Originally, the $libraryName is 'JavaScriptCore'. When building release 
2683         one, the $libraryDir was 'WebKitBuild/Release/JavaScriptCore/../.libs/'
2684         which doesn't exist anymore ('WebKitBuild/Release/JavaScriptCore'
2685         is 'WebKitBuild/Release/Source/JavaScriptCore' now), and 
2686         'WebKitBuild/Release/Source/JavaScriptCore/../../.libs' looks weird,
2687         so make it 'WebKitBuild/Release/.libs'
2688
2689         * Scripts/webkitdirs.pm: 
2690
2691 2011-01-02  Patrick Gansterer  <paroga@webkit.org>
2692
2693         Reviewed by Adam Barth.
2694
2695         Make EFL a core builder
2696         https://bugs.webkit.org/show_bug.cgi?id=51804
2697
2698         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2699         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2700
2701 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
2702
2703         [Qt] Unreviewed fix after r74855 and r74875.
2704
2705         * BuildSlaveSupport/built-product-archive:
2706          - Create directories explicitly.
2707          - Pass shell=True to subprocess.call().
2708
2709 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
2710
2711         [Qt] Unreviewed fix after r74855.
2712
2713         Move JavaScriptCore to Source
2714         https://bugs.webkit.org/show_bug.cgi?id=51604
2715
2716         * BuildSlaveSupport/built-product-archive: JavaScriptCore -> Source/JavaScriptCore
2717
2718 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
2719
2720         [Qt] Unreviewed run-javasriptcore-tests fix after r74855.
2721
2722         Move JavaScriptCore to Source
2723         https://bugs.webkit.org/show_bug.cgi?id=51604
2724
2725         * Scripts/webkitdirs.pm:
2726
2727 2011-01-02  Robert Hogan  <robert@webkit.org>
2728
2729         Unreviewed, build fix.
2730
2731         [Qt] Fix DRT build after 74855
2732
2733         * DumpRenderTree/qt/DumpRenderTree.pro:
2734
2735 2011-01-01  Adam Barth  <abarth@webkit.org>
2736
2737         Remove the assumption from the Qt and Gtk builds that every project is
2738         in the root directory.
2739
2740         * Scripts/build-webkit:
2741
2742 2011-01-01  Adam Barth  <abarth@webkit.org>
2743
2744         Reviewed by Eric Seidel.
2745
2746         Teach svn-apply how to apply patches even though JavaScriptCore has moved
2747         https://bugs.webkit.org/show_bug.cgi?id=51796
2748
2749         After this change, svn-apply will magically apply patches to
2750         JavaScriptCore/foo to Source/JavaScriptCore/foo.
2751
2752         * Scripts/VCSUtils.pm:
2753
2754 2011-01-01  Adam Barth  <abarth@webkit.org>
2755
2756         Reviewed by Eric Seidel.
2757
2758         Move JavaScriptCore to Source
2759         https://bugs.webkit.org/show_bug.cgi?id=51604
2760
2761         Update references to JavaScriptCore to point to the new location.
2762
2763         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2764         * DumpRenderTree/qt/DumpRenderTree.pro:
2765         * DumpRenderTree/qt/ImageDiff.pro:
2766         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2767         * DumpRenderTree/wscript:
2768         * Scripts/build-jsc:
2769         * Scripts/build-webkit:
2770         * Scripts/do-file-rename:
2771         * Scripts/do-webcore-rename:
2772         * Scripts/run-javascriptcore-tests:
2773         * Scripts/update-javascriptcore-test-results:
2774         * Scripts/webkitdirs.pm:
2775         * Scripts/webkitpy/common/config/build_unittest.py:
2776         * Scripts/webkitpy/style/checker.py:
2777         * Scripts/webkitpy/style/checker_unittest.py:
2778         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2779         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2780         * WebKitTestRunner/qt/WebKitTestRunner.pro:
2781         * wx/build/settings.py:
2782
2783 2011-01-01  Adam Barth  <abarth@webkit.org>
2784
2785         Reviewed by Eric Seidel.
2786
2787         Move Sources to Source
2788         https://bugs.webkit.org/show_bug.cgi?id=51794
2789
2790         Update scripts to point to the new location.
2791
2792         * Scripts/build-webkit:
2793         * Scripts/do-file-rename:
2794         * Scripts/do-webcore-rename:
2795         * Scripts/webkitpy/common/config/build.py:
2796         * Scripts/webkitpy/common/config/build_unittest.py:
2797
2798 2010-12-31  Kent Tamura  <tkent@chromium.org>
2799
2800         Reviewed by Eric Seidel.
2801
2802         [DRT/Chromium] Enable mock spell checker on non-OSX
2803         https://bugs.webkit.org/show_bug.cgi?id=51401
2804
2805         * DumpRenderTree/chromium/WebViewHost.cpp:
2806         (WebViewHost::spellCheck):
2807
2808 2010-12-31  Adam Barth  <abarth@webkit.org>
2809
2810         Reviewed by Ariya Hidayat.
2811
2812         Remove Tools/Scripts/wkstyle
2813         https://bugs.webkit.org/show_bug.cgi?id=51774
2814
2815         This script appears to not have been touched in a while and seems to
2816         have been replaced by check-webkit-style.
2817
2818         * Scripts/wkstyle: Removed.
2819
2820 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
2821
2822         Unreviewed. Coding style fix.
2823
2824         * DumpRenderTree/chromium/TestShell.h:
2825
2826 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
2827
2828         Reviewed by Pavel Feldman.
2829
2830         Web Inspector: [Chromium] Inspector's tests are very slow on Win(Dbg).
2831
2832         It was a problem with Chromium DRT. DevToolsAgent object instance was
2833         attached not only to the inspected page but to the DevTools window too.
2834         As result all the inspector files were interpreted as a content of inspected page
2835         and were transfered to the DevTools scripts panel for debugging etc.
2836
2837         https://bugs.webkit.org/show_bug.cgi?id=51735
2838
2839         * DumpRenderTree/chromium/TestShell.cpp:
2840         (TestShell::TestShell):
2841         (TestShell::bindJSObjectsToWindow):
2842         (TestShell::createNewWindow):
2843         * DumpRenderTree/chromium/TestShell.h:
2844
2845 2010-12-31  Adam Barth  <abarth@webkit.org>
2846
2847         Rubber-stamped by Eric Seidel.
2848
2849         Move PageLoadTests to PerformanceTests/PageLoad
2850         https://bugs.webkit.org/show_bug.cgi?id=51771
2851
2852         Update references to PageLoadTests to point to the new location.
2853
2854         * Scripts/run-pageloadtest:
2855         * Scripts/webkitpy/common/config/build.py:
2856
2857 2010-12-31  Adam Barth  <abarth@webkit.org>
2858
2859         Rubber-stamped by Eric Seidel.
2860
2861         Move SunSpider into PerformanceTests
2862         https://bugs.webkit.org/show_bug.cgi?id=51769
2863
2864         Update these scripts to point to the new location.
2865
2866         * Scripts/run-sunspider:
2867         * Scripts/sunspider-compare-results:
2868
2869 2010-12-30  Mihai Parparita  <mihaip@chromium.org>
2870
2871         Reviewed by Kent Tamura.
2872
2873         [Chromium] Add WebThemeEngineDRTMac so that Chromium DRT scrollbar rendering can match the Mac port's
2874         https://bugs.webkit.org/show_bug.cgi?id=51728
2875         
2876         Add implementation of the Mac WebThemeEngine that uses an NSScroller
2877         to render top-level scrollbars. This makes them match the Mac port's
2878         use of an NSScrollView, which means that we'll be able to share more
2879         pixel baselines.
2880         
2881         The new rendering code will not be activated until the 
2882         USE_WEB_THEME_ENGINE_TO_PAINT_THUMB #define is fliped in
2883         ScrollbarThemeChromiumMac.
2884
2885         * DumpRenderTree/DumpRenderTree.gypi:
2886         * DumpRenderTree/chromium/TestShellMac.mm:
2887         (platformInit):
2888         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Added.
2889         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Added.
2890         (+[FakeActiveWindow alwaysActiveWindow]):
2891         (+[FakeActiveWindow alwaysInactiveWindow]):
2892         (-[FakeActiveWindow initWithActiveControls:]):
2893         (-[FakeActiveWindow _hasActiveControls]):
2894         (WebThemeEngineDRTMac::paintScrollbarThumb):
2895         (stateToHIEnableState):
2896         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
2897         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
2898
2899 2010-12-30  Konstantin Tokarev  <annulen@yandex.ru>
2900
2901         Reviewed by David Kilzer.
2902
2903         [Qt] Don't build wtf/TCSystemAlloc.cpp if --system-malloc option is
2904         used
2905         https://bugs.webkit.org/show_bug.cgi?id=51672
2906
2907         * DumpRenderTree/qt/DumpRenderTree.pro: Replaced USE_SYSTEM_MALLOC
2908         with USE_SYSTEM_MALLOC=1
2909         * WebKitTestRunner/qt/WebKitTestRunner.pro: Replaced USE_SYSTEM_MALLOC
2910         with USE_SYSTEM_MALLOC=1
2911
2912 2010-12-30  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2913
2914         Reviewed by David Kilzer.
2915
2916         [Qt] [Symbian] Fix build-webkit script for Symbian
2917         https://bugs.webkit.org/show_bug.cgi?id=51509
2918
2919         Set the OUTPUT_DIR for Symbian to be the same as the source
2920         directory.
2921
2922         * Scripts/webkitdirs.pm:
2923
2924 2010-12-30  Martin Robinson  <mrobinson@igalia.com>
2925
2926         Reviewed by Darin Adler.
2927
2928         check-webkit-style should ignore NULL usage in calls to gtk_widget_style_get
2929         https://bugs.webkit.org/show_bug.cgi?id=51758
2930
2931         Add a check-webkit-style exception for gtk_widget_style_get and NULL usage.
2932
2933         * Scripts/webkitpy/style/checkers/cpp.py: Add the exception.
2934         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Add some tests for this.
2935
2936 2010-12-29  Patrick Gansterer  <paroga@webkit.org>
2937
2938         Unreviewed WinCE buildfix.
2939
2940         * WinCELauncher/main.cpp: Add missing include.
2941
2942 2010-12-29  Daniel Bates  <dbates@rim.com>
2943
2944         Reviewed by Darin Adler.
2945
2946         svn-apply updates date of wrong change log entry for a change log diff that
2947         contains two consecutive entries with the same author and date
2948         https://bugs.webkit.org/show_bug.cgi?id=46061
2949
2950         Fixes an issue where the date of the wrong change log entry may be modified.
2951         Moreover, changes fixChangeLogPatch() to move entries inserted earlier
2952         in a ChangeLog file to the top of the file.
2953
2954         Currently, fixChangeLogPatch() explicitly bails out and returns an unchanged
2955         diff when it detects that the diff inserts a change log entry earlier in a
2956         ChangeLog. It is unusual to land a patch that has such a deliberate ChangeLog
2957         change. With the advent of the commit-queue this functionality of bailing out
2958         and hence landing the patch as-is is harmful to the accuracy of the ChangeLog.
2959         Instead, we should always move the change log entry to the top of the ChangeLog file.
2960
2961         A side-effect of this change is that setChangeLogDateAndReviewer() now updates
2962         the date line of the correct change log entry in a ChangeLog diff.
2963
2964         * Scripts/VCSUtils.pm: Modified fixChangeLogPatch() to move entries inserted earlier to the top.
2965
2966         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
2967           Updated the following unit tests now that we move entries inserted earlier to the top:
2968           - "fixChangeLogPatch: New entry inserted in middle."
2969             (formerly named "fixChangeLogPatch: [no change] New entry inserted in middle.")
2970
2971           - "fixChangeLogPatch: New entry inserted earlier in the file, but after an entry with the same author and date."
2972             (formerly named "fixChangeLogPatch: [no change] New entry inserted earlier in the file, but after an entry with the same author and date.")
2973
2974         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatchThenSetChangeLogDateAndReviewer.pl: Added.
2975
2976 2010-12-29  Konstantin Tokarev  <annulen@yandex.ru>
2977
2978         Reviewed by Eric Seidel.
2979
2980         [Qt] Fixed compatibility with gold linker on X11 platforms
2981         https://bugs.webkit.org/show_bug.cgi?id=51700
2982
2983         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2984         Linked TestNetscapePlugin with libX11 on Unix platforms
2985
2986 2010-12-29  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>
2987
2988         Reviewed by Darin Adler.
2989
2990         Circular dependency in webkitpy.common.checkout.changelog module
2991         https://bugs.webkit.org/show_bug.cgi?id=50475
2992
2993         Remove automatic import of api.Checkout module when any checkout/
2994         submodule is imported (e.g.: when checkout.scm.Git is imported).
2995
2996         * Scripts/webkitpy/common/checkout/__init__.py:
2997
2998 2010-12-29  Martin Robinson  <mrobinson@igalia.com>
2999
3000         Reviewed by Ojan Vafai.
3001
3002         prepare-ChangeLog should support the -g option for specifying the git-commit
3003         https://bugs.webkit.org/show_bug.cgi?id=51708
3004
3005         Add a -g shortcut for the --git-commit prepare-ChangeLog option. This matches
3006         webkit-patch, though the exact meaning of the two options remain different.
3007
3008         * Scripts/prepare-ChangeLog: Add -g.
3009
3010 2010-12-29  Kent Hansen  <kent.hansen@nokia.com>
3011
3012         Reviewed by Simon Hausmann.
3013
3014         [Qt] Fix compilation with Qt in namespace
3015         https://bugs.webkit.org/show_bug.cgi?id=51701
3016
3017         * QtTestBrowser/webview.h:
3018
3019 2010-12-28  Daniel Bates  <dbates@rim.com>
3020
3021         Reviewed by Sam Weinig.
3022
3023         Substitute // MARK: for compiler-specific #pragma mark
3024         https://bugs.webkit.org/show_bug.cgi?id=51657
3025
3026         Fix future compilation warnings about "#pragma mark" on GTK+ bots by
3027         substituting  "// MARK:" for "#pragma mark", which provides
3028         analogous code-bookmarking functionality under Xcode.
3029
3030         Also, for consistency, we should substitute "// MARK:" for compiler-
3031         specific "#pragma mark" in the source files for the Mac port.
3032
3033         * DumpRenderTree/AccessibilityTextMarker.cpp:
3034         * DumpRenderTree/cf/WebArchiveDumpSupport.h:
3035         * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm:
3036         * DumpRenderTree/mac/ObjCController.m:
3037         * MiniBrowser/mac/AppDelegate.m:
3038         * MiniBrowser/mac/BrowserWindowController.m:
3039
3040 2010-12-28  Xan Lopez  <xlopez@igalia.com>
3041
3042         Reviewed by Eric Seidel.
3043
3044         Add --no-build option to run-sunspider
3045         https://bugs.webkit.org/show_bug.cgi?id=51658
3046
3047         * Scripts/run-sunspider: add --no-build flag to skip building
3048         phase.
3049
3050 2010-12-27  Daniel Bates  <dbates@rim.com>
3051
3052         Rubber-stamped by Martin Robinson.
3053
3054         Append the directory Tools/DumpRenderTree to the list of directories that
3055         do-webcore-rename should search so that it can rename DRT files and
3056         source code.
3057
3058         * Scripts/do-webcore-rename:
3059
3060 2010-12-27  Eric Seidel  <eric@webkit.org>
3061
3062         Reviewed by Adam Barth.
3063
3064         build-webkit should detect missing Java SDK and explain how to install it
3065         https://bugs.webkit.org/show_bug.cgi?id=51651
3066
3067         * Scripts/build-webkit:
3068
3069 2010-12-26  Martin Robinson  <mrobinson@igalia.com>
3070
3071         Reviewed by Daniel Bates.
3072
3073         [GTK] Add support for build-jsc
3074         https://bugs.webkit.org/show_bug.cgi?id=51625
3075
3076         Add GTK+ support to build-jsc now that building the jsc executable as
3077         a standalone target is easy.
3078
3079         * Scripts/build-jsc: Call buildGtkProject for the GTK+ case now.
3080         * Scripts/build-webkit: Pass in the proper target name to buildGtkProject.
3081         * Scripts/webkitdirs.pm: Actually process the project parameter in buildGtkProject
3082         and pass it along to buildAutotoolsProject.
3083
3084 2010-12-27  David Levin  <levin@chromium.org>
3085
3086         Reviewed by Eric Seidel.
3087
3088         check-webkit-style check for meaningless variable names in function declarations.
3089         https://bugs.webkit.org/show_bug.cgi?id=51523
3090
3091         * Scripts/webkitpy/style/checker.py: Exempted JavaScriptCore/jit/JITStubs.cpp
3092         from the new check and whitespace/parens because the syntax is unusual and
3093         produced a fair number of positives for these checks.
3094         * Scripts/webkitpy/style/checkers/cpp.py:
3095         (_convert_to_lower_with_underscores): Used as a canonical form for type names
3096         and parameter names when determining if the parameter name is useless.
3097         (_create_acronym): Used to check for redundant variable names in cases like "ExceptionCode ec"
3098         (Parameter.lower_with_underscores_name): Gives back the parameter name in a lower_with_underscore
3099         format.
3100         (_check_parameter_name_against_text):  Checks to see if the parameter name is in the
3101         text or an acronym of it.
3102         (check_function_definition): Checks function definitions for meaningless variable names.
3103         (process_line): Added call to check_function_definition.
3104         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3105         (CppFunctionsTest.test_convert_to_lower_with_underscores): Test for _convert_to_lower_with_underscores.
3106         (CppFunctionsTest.test_create_acronym): Test for _create_acronym.
3107         (CppFunctionsTest.test_check_parameter_against_text): Test for _check_parameter_against_text.
3108         (CppStyleTestBase.perform_single_line_lint): Removed the parameter name check
3109         because when only checking a snippet, there are a lot of bogus functions.
3110         (CppStyleTestBase.perform_multi_line_lint): Ditto and removed a bogus filter
3111         that I put there previously and just noticed.
3112         (WebKitStyleTest.test_parameter_names): Tests for the functionality -- both
3113         check_function_definition and process_line.
3114
3115 2010-12-27  Carlos Garcia Campos  <cgarcia@igalia.com>
3116
3117         Reviewed by Martin Robinson.
3118
3119         [GTK] Disable flash plugin in GtkLauncher when using gtk3
3120         https://bugs.webkit.org/show_bug.cgi?id=51591
3121
3122         Flash plugin uses gtk2 that is incompatible with gtk3 making
3123         webkit crash when it's built with gtk3.
3124
3125         * GtkLauncher/main.c:
3126         (main):
3127
3128 2010-12-25  Adam Barth  <abarth@webkit.org>
3129
3130         Reviewed by Eric Seidel.
3131
3132         Move ANGLE to Sources/ThirdParty
3133         https://bugs.webkit.org/show_bug.cgi?id=51605
3134
3135         * Scripts/build-webkit:
3136           - Point to the new ANGLE location.
3137
3138 2010-12-26  David Levin  <levin@chromium.org>
3139
3140         Reviewed by Eric Seidel.
3141
3142         check-webkit-style should be able to parse function declaration parameters.
3143         https://bugs.webkit.org/show_bug.cgi?id=51451
3144
3145         * Scripts/webkitpy/style/checkers/cpp.py:
3146         (Position.__init__): Holds simple position information (row, column).
3147         (Parameter.__init__): Holds information about a parameter.
3148         (SingleLineView.__init): Converts multiple lines into a single line for simpler searches.
3149         (SingleLineView.convert_column_to_row): Returns the original row given a column.
3150         (create_skeleton_parameters): Simplifies a parameter list for easier searching.
3151         (find_parameter_name_index): Finds where the parameter name is.
3152         (parameter_list): Generates the list of parameters for a function.
3153         (_FunctionState.begin): Added information to allow determining the parameters
3154         on demand.
3155         (_FunctionState.get_parameter_list): Returns a tuple of function parameters.
3156         (detect_functions): Improve function detection for operator functions and
3157         determine where the parameters end and pass that to _FunctionState.begin.
3158         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3159         (CppFunctionsTest.test_parameter): Verifies Parameter functionality.
3160         (CppFunctionsTest.test_single_line_view): Verifies SingleLineView functionality.
3161         (CppFunctionsTest.test_create_skeleton_parameters): Verifies create_skeleton_parameters.
3162         (CppFunctionsTest.test_find_parameter_name_index): Verifies find_parameter_name_index.
3163         (CppFunctionsTest.test_parameter_list): Does some minimal verification for parameter list.
3164         Much more thorough verification is done as part of FunctionDetectionTest.test_parameter_list.
3165         (FunctionDetectionTest.perform_function_detection): Added support for verifying
3166         the parameters found.
3167         (FunctionDetectionTest.test_function_declaration_detection): Added more function
3168         detection test to verify that we catch the operator functions.
3169         (FunctionDetectionTest.test_ignore_macros): Verify that function detection ignores macros.
3170         (FunctionDetectionTest.test_parameter_list): Added tests to verify the parameter parsing.
3171         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_bad_test_doesnt_break): Removed
3172         because the error. The test is about the bad function name. Fixing the name makes the test exactly like
3173         test_function_length_check_definition_severity1_for_test.
3174
3175 2010-12-25  Patrick Gansterer  <paroga@webkit.org>
3176
3177         Unreviewed WinCE buildfix after r74334.
3178
3179         * CMakeListsWinCE.txt:
3180
3181 2010-12-24  Sheriff Bot  <webkit.review.bot@gmail.com>
3182
3183         Unreviewed, rolling out r74632.
3184         http://trac.webkit.org/changeset/74632
3185         https://bugs.webkit.org/show_bug.cgi?id=51600
3186
3187         makes test-webkitpy hang forever on GTK (Requested by philn-tp
3188         on #webkit).
3189
3190         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
3191         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
3192
3193 2010-12-24  Ryuan Choi  <ryuan.choi@samsung.com>
3194
3195         Reviewed by Kenneth Rohde Christiansen.
3196
3197         [EFL] Screen doesn't be rendered when changing size of EWebLauncher
3198         https://bugs.webkit.org/show_bug.cgi?id=43528
3199
3200         Remove on_resize because ewk_view_fixed_layout_size_set should not be
3201         called on callback of EVAS_CALLBACK_RESIZE. As it change size of
3202         FrameView, rendering was ignored when _ewk_view_smart_calculate was
3203         called.
3204
3205         * EWebLauncher/main.c:
3206         (browserCreate):
3207
3208 2010-12-24  Eric Seidel  <eric@webkit.org>
3209
3210         Reviewed by Adam Barth.
3211
3212         webkit-patch (or a pre-commit hook) needs to prevent bad ChangeLog changes
3213         https://bugs.webkit.org/show_bug.cgi?id=28291
3214
3215         This is a start.  At least now webkit-patch will prompt when your ChangeLog looks questionable.
3216         We could do more advanced things, like parsing the ChangeLog (with changelog.py) and comparing that
3217         to strings with find in the diff.
3218         Since non-interactive always returns the default, this should cause patches with bad changelogs to fail on the commit-queue.
3219
3220         * Scripts/webkitpy/common/checkout/api.py:
3221         * Scripts/webkitpy/common/checkout/diff_parser.py:
3222         * Scripts/webkitpy/tool/steps/abstractstep.py:
3223         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
3224         * Scripts/webkitpy/tool/steps/validatechangelogs.py: Copied from Tools/Scripts/webkitpy/tool/steps/validatereviewer.py.
3225         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py: Copied from Tools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.
3226         * Scripts/webkitpy/tool/steps/validatereviewer.py:
3227
3228 2010-12-24  Dirk Pranke  <dpranke@chromium.org>
3229
3230         Reviewed by Kenneth Russell.
3231
3232         Modify new-run-webkit-tests to shut up and exit when all the threads
3233         are wedged so that test runs complete faster and we don't end up
3234         w/ enormous log files.
3235
3236         https://bugs.webkit.org/show_bug.cgi?id=51572
3237
3238         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
3239         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
3240
3241 2010-12-24  Eric Seidel  <eric@webkit.org>
3242
3243         Reviewed by David Levin.
3244
3245         commit-queue should better explain how it will re-open bugs and follow duplicate chains
3246         https://bugs.webkit.org/show_bug.cgi?id=51549
3247
3248         I've had multiple people ask me about the commit-queue's behavior
3249         regarding reporting flaky tests.  I figured it would be best to just
3250         have the queue explain itself in the bugs it files.
3251
3252         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3253         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3254
3255 2010-12-24  Shinichiro Hamaji  <hamaji@chromium.org>
3256
3257         Reviewed by Eric Seidel.
3258
3259         check-webkit-style: should ignore "wrong" namings in JavaScriptCore/qt
3260         https://bugs.webkit.org/show_bug.cgi?id=51467
3261
3262         * Scripts/webkitpy/style/checker.py:
3263         * Scripts/webkitpy/style/checker_unittest.py:
3264
3265 2010-12-23  Adam Barth  <abarth@webkit.org>
3266
3267         Rubber-stamped by Eric Seidel.
3268
3269         Move JavaScriptGlue into Sources
3270         https://bugs.webkit.org/show_bug.cgi?id=51583
3271
3272         These tools refer to JavaScriptGlue and need to be updated to its new
3273         location.
3274
3275         * Scripts/build-webkit:
3276         * Scripts/do-file-rename:
3277         * Scripts/do-webcore-rename:
3278         * Scripts/webkitpy/common/config/build.py:
3279         * Scripts/webkitpy/common/config/build_unittest.py:
3280
3281 2010-12-23  Lucas Forschler  <lforschler@apple.com>
3282
3283         Reviewed by Eric Seidel.
3284
3285         Bug 51539 - update iexploder scripts to point to new location
3286
3287         * Scripts/run-iexploder-tests:
3288         * Scripts/update-iexploder-cssproperties:
3289
3290 2010-12-23  Evan Martin  <evan@chromium.org>
3291
3292         Reviewed by Ryosuke Niwa.
3293
3294         [chromium] LayoutTestController warning in float->int conversion
3295         https://bugs.webkit.org/show_bug.cgi?id=51553
3296
3297         Rather than reading an int, converting to a float, then getting a compiler
3298         warning on passing the float to something that expects an int, instead
3299         just pass around ints.
3300
3301         No tests, fixes a compiler warning.
3302
3303         * DumpRenderTree/chromium/LayoutTestController.cpp:
3304         (parsePageSizeParameters):
3305         (LayoutTestController::pageNumberForElementById):
3306         (LayoutTestController::numberOfPages):
3307
3308 2010-12-23  Lucas Forschler  <lforschler@apple.com>
3309
3310         Reviewed by Darin Adler.
3311
3312         Bug 51537 - iexploder needs cleanup
3313         
3314         * iExploder/htdocs: Removed.
3315         * iExploder/htdocs/config.rb: Removed.
3316         * iExploder/htdocs/cssproperties.in: Removed.
3317         * iExploder/htdocs/cssvalues.in: Removed.
3318         * iExploder/htdocs/htmlattrs.in: Removed.
3319         * iExploder/htdocs/htmltags.in: Removed.
3320         * iExploder/htdocs/htmlvalues.in: Removed.
3321         * iExploder/htdocs/iexploder.cgi: Removed.
3322         * iExploder/htdocs/iexploder.rb: Removed.
3323         * iExploder/htdocs/index.html: Removed.
3324         * iExploder/htdocs/webserver.rb: Removed.
3325         * iExploder/iexploder-1.7.2/output: Removed.
3326         * iExploder/tools: Removed.
3327         * iExploder/tools/lasthit.rb: Removed.
3328         * iExploder/tools/osx_last_crash.rb: Removed.
3329         * iExploder/tools/showtest.rb: Removed.
3330
3331 2010-12-23  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
3332
3333         Reviewed by Kenneth Rohde Christiansen.
3334
3335         [EFL] Make 'single' the default backing store in EWebLauncher
3336         https://bugs.webkit.org/show_bug.cgi?id=51534
3337
3338         'single' is the simplest backing store and the one intended to be the
3339         default in the test browser. By mistake the tiled backing store was
3340         left as default in r72617.
3341
3342         * EWebLauncher/main.c:
3343         (browserCreate): ditto.
3344
3345 2010-12-23  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
3346
3347         Reviewed by Kenneth Rohde Christiansen.
3348
3349         [EFL] Subject: [webkit 4/4] [EFL] Remove non-sense workaround
3350         https://bugs.webkit.org/show_bug.cgi?id=51533
3351
3352         There's no point in concatenating env("HOME") with "blah", so remove
3353         option from EWebLauncher.
3354
3355         * EWebLauncher/main.c:
3356         (main): ditto.
3357
3358 2010-12-23  Ilya Tikhonovsky  <loislo@chromium.org>
3359
3360         Reviewed by Eric Seidel.
3361
3362         Web Inspector: chromium: inspector's tests are quite slow especially at windows(Debug).
3363
3364         Almost all inspector's tests become flaky on chromium Win(dbg) after switching to DRT.
3365         I just discovered that we have two additional GC runs per each WebViewHost.
3366         Test_shell had no such calls.
3367         These gc runs eat 15% of cpu time.
3368
3369         https://bugs.webkit.org/show_bug.cgi?id=51479
3370
3371         * DumpRenderTree/chromium/WebViewHost.cpp:
3372         (WebViewHost::~WebViewHost):
3373
3374 2010-12-22  Dirk Pranke  <dpranke@chromium.org>
3375
3376         Reviewed by Ojan Vafai.
3377
3378         This change splits out the TestRunner class into its own file.
3379         When we fork the code for message passing, we will create a new
3380         TestRunner, and this change will allow that to be more modular.
3381
3382         While we're at it, split out TestInput and ResultSummary into
3383         their own files, to reduce the size of run_webkit_tests to
3384         something more managable.
3385
3386         https://bugs.webkit.org/show_bug.cgi?id=51092
3387
3388         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
3389         * Scripts/webkitpy/layout_tests/layout_package/result_summary.py:
3390         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
3391         * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
3392         * Scripts/webkitpy/layout_tests/layout_package/test_input.py:
3393         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3394         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3395
3396  2010-12-22  Dirk Pranke  <dpranke@chromium.org>
3397
3398         Reviewed by Ojan Vafai.
3399
3400         nrwt multiprocessing - start over, prepare to fork the code
3401  
3402         This code cleans up the signatures and implementation of the
3403         TestRunner class so we can easily fork it to run either the
3404         stable implementation or the new, unstable message-passing
3405         implementation. The two variants will have different
3406         implementations of the run_tests() method. We will switch
3407         between the two based on the setting for the '--worker-model'
3408         switch. We rename the two currently valid values to 'old-inline'
3409         and 'old-threads'.
3410
3411         https://bugs.webkit.org/show_bug.cgi?id=51081
3412
3413         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3414         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3415
3416 2010-12-22  Victor Wang  <victorw@chromium.org>
3417
3418         Reviewed by Darin Fisher.
3419
3420         [Chromium] Update chromium archive test result url in rebaseline script.
3421
3422         https://bugs.webkit.org/show_bug.cgi?id=51503
3423
3424         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
3425
3426 2010-12-22  Lucas Forschler  <lforschler@apple.com>
3427
3428         Reviewed by Alice Liu.
3429
3430         <rdar://problem/8633222> record-memory-win needs to record memory used by the webprocess.
3431         Verified on Chrome, Safari, and IE.
3432         With this change, we will record memory from a parent browser window and all child processes.
3433
3434         * record-memory-win/main.cpp:
3435         (ProcessArgs):
3436         (PrintUsage):
3437         (getMemoryInfo):
3438         (printProcessInfo):
3439         (evalProcesses):
3440         (UseImage):
3441         (QueryContinuously):
3442         (ElapsedTime):
3443
3444 2010-12-22  Lucas Forschler  <lforschler@apple.com>
3445
3446         Unreviewed rollout r74489, because it was missing changelog.
3447
3448         * record-memory-win/main.cpp:
3449         
3450 2010-12-22  Ryosuke Niwa  <rniwa@webkit.org>
3451
3452         Adding myself as a reviewer.
3453
3454         * Scripts/webkitpy/common/config/committers.py:
3455
3456 2010-12-22  Andrew Scherkus  <scherkus@chromium.org>
3457
3458         Unreviewed.  Adding myself to committers.py.
3459
3460         * Scripts/webkitpy/common/config/committers.py:
3461
3462 2010-12-22  Ariya Hidayat  <ariya@sencha.com>
3463
3464         Reviewed by Kenneth Rohde Christiansen.
3465
3466         TestNetscapePlugIn should use #if defined
3467         https://bugs.webkit.org/show_bug.cgi?id=51471
3468
3469         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3470         (NP_Initialize):
3471         (NPP_New):
3472
3473 2010-12-22  Ilya Tikhonovsky  <loislo@chromium.org>
3474
3475         Reviewed by Yury Semikhatsky.
3476
3477         Web Inspector: [chromium] DRT inspector layout tests are flaky in debug.
3478
3479         DevTools window should be closed explicitly because it has custom deinitialization code.
3480
3481         https://bugs.webkit.org/show_bug.cgi?id=50722
3482
3483         * DumpRenderTree/chromium/TestShell.cpp:
3484         (TestShell::closeRemainingWindows):
3485
3486 2010-12-22  David Levin  <levin@chromium.org>
3487
3488         Reviewed by Shinichiro Hamaji.
3489
3490         check-webkit-style shouldn't complaint about underscores in variables in objective C files.
3491         https://bugs.webkit.org/show_bug.cgi?id=51452
3492
3493         * Scripts/webkitpy/style/checkers/cpp.py:
3494         (_FileState.__init__): Added the information to determine if a file is C or Objective C.
3495         Using the file extension if possible but falling back to the file contents if we have a header file.
3496         (_FileState.is_objective_c): Determine if we have an Objective C by examining the file contents if needed.
3497         (_FileState.is_c_or_objective_c):
3498         (check_using_std): Changed to using _FileState to determine the file type.
3499         (check_max_min_macros): Ditto.
3500         (check_for_null): Ditto.
3501         (check_style): Changed the parameters to various calls since they now need _FileState
3502         to determine the file type.
3503         (check_language): Added the file_state parameter so it could be passed
3504         to check_identifier_name_in_declaration.
3505         (check_identifier_name_in_declaration): Don't warn about underscores in variables if
3506         this is an Objective C file.
3507         (_process_lines): Added information for the _FileState constructor (and moved the
3508         call to a place that had the information).
3509         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3510         (CppFunctionsTest.test_is_c_or_objective_c): Changed the tests to use FileState and exercise
3511         its functionality.
3512         (WebKitStyleTest.test_names): Add tests for underscores in Objective C files.
3513
3514 2010-12-21  Andy Estes  <aestes@apple.com>
3515
3516         Reviewed by Mark Rowe.
3517
3518         Do not build non-Intel architectures for WebKit2-related projects.
3519         https://bugs.webkit.org/show_bug.cgi?id=51440
3520
3521         * MiniBrowser/Configurations/Base.xcconfig: Only build for i386 and x86_64.
3522         * TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
3523         * WebKitTestRunner/Configurations/Base.xcconfig: Ditto.
3524
3525 2010-12-21  Mihai Parparita  <mihaip@chromium.org>
3526
3527         Reviewed by Darin Fisher.
3528
3529         [Chromium] Rename WebThemeEngine/ControlDRT to WebThemeEngine/ControlDRTWin
3530         https://bugs.webkit.org/show_bug.cgi?id=51406 
3531         
3532         Rename WebThemeControlDRT to WebThemeControlDRTWin and WebThemeEngineDRT
3533         to WebThemeEngineDRTWin and update references everywhere.
3534
3535         * DumpRenderTree/DumpRenderTree.gypi:
3536         * DumpRenderTree/chromium/TestShellWin.cpp:
3537         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRT.cpp.
3538         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRT.h.
3539         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRT.cpp.
3540         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRT.h.
3541
3542 2010-12-21  Anders Carlsson  <andersca@apple.com>
3543
3544         Reviewed by John Sullivan.
3545
3546         Clicking missing plug-in text does not show a sheet
3547         https://bugs.webkit.org/show_bug.cgi?id=51403
3548
3549         Update for changes to the WebPageUIClient.
3550
3551         * MiniBrowser/mac/BrowserWindowController.m:
3552         (-[BrowserWindowController awakeFromNib]):
3553         * WebKitTestRunner/TestController.cpp:
3554         (WTR::createOtherPage):
3555         (WTR::TestController::initialize):
3556
3557 2010-12-21  Eric Seidel  <eric@webkit.org>
3558
3559         Reviewed by Adam Barth.
3560
3561         commit-queue will report constant failures as flaky if other tests flake
3562         https://bugs.webkit.org/show_bug.cgi?id=51272
3563
3564         This patch just removes functionality and adds testing.
3565         Previously we attempted to report flaky tests when we had
3566         two different tests fail in a row.  However, since we stop
3567         running the tests at the first failure, our code was wrong in
3568         trying to determine flakiness from the incomplete runs.
3569
3570         Originally I posted an alternate patch:
3571         https://bug-51272-attachments.webkit.org/attachment.cgi?id=77078
3572         which fixed our flaky logic in this case, however it was decided
3573         that that patch would be too difficult to maintain, so now
3574         I'm just removing the broken logic.
3575
3576         This will dramatically cut-down on our flaky-test false positives
3577         at the (small) cost of the queues being unable to report
3578         any flakiness if the tree is very flaky.  (With at least one test
3579         flaking on every run, we'll never report failures anymore.)  I think
3580         this is a tradeoff worth making.
3581
3582         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3583         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3584
3585 2010-12-20  Eric Seidel  <eric@webkit.org>
3586
3587         Reviewed by Adam Barth.
3588
3589         commit-queue wrongly rejects patches when it can't update itself
3590         https://bugs.webkit.org/show_bug.cgi?id=46636
3591
3592         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3593         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3594         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3595
3596 2010-12-20  Adam Barth  <abarth@webkit.org>
3597
3598         Move web sites to Websites directory
3599         https://bugs.webkit.org/show_bug.cgi?id=51323
3600
3601         Update references to BugsSite to point to the new location.
3602
3603         This patch was never officially reviewed (because it was too large to
3604         upload to bugs.webkit.org), but it was discussed on webkit-dev and Mark
3605         Rowe gave me the green light.
3606
3607         * Scripts/old-run-webkit-tests:
3608         * Scripts/webkitpy/common/config/build.py:
3609         * Scripts/webkitpy/common/config/build_unittest.py:
3610         * Scripts/webkitpy/common/prettypatch.py:
3611         * Scripts/webkitpy/layout_tests/port/base.py:
3612         * Scripts/webkitpy/style/main.py:
3613
3614 2010-12-20  Adrienne Walker  <enne@google.com>
3615
3616         Unreviewed. Adding myself to the list of committers.
3617
3618         * webkitpy/common/config/committers.py:
3619
3620 2010-12-20  Mark Rowe  <mrowe@apple.com>
3621
3622         Reviewed by Dan Bernstein.
3623
3624         <rdar://problem/8757601> Don't install header files in to the Resources directory.
3625
3626         * Scripts/check-for-inappropriate-files-in-framework: Don't allow .h files in the
3627         Resources directory.
3628
3629 2010-12-20  Eric Seidel  <eric@webkit.org>
3630
3631         Reviewed by Adam Barth.
3632
3633         commit-queue should include bot id when attaching failure diffs
3634         https://bugs.webkit.org/show_bug.cgi?id=51280
3635
3636         This is a tiny change to include the bot id in the name of the attachment.
3637         Most of this diff is just changing the unit test expectations
3638         now that I hid the comment printing when the comment is None.
3639
3640         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3641         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3642         * Scripts/webkitpy/tool/commands/upload_unittest.py:
3643         * Scripts/webkitpy/tool/mocktool.py:
3644
3645 2010-12-20  Jeff Miller  <jeffm@apple.com>
3646
3647         Reviewed by Dan Bernstein.
3648
3649         Tools/vcbin/midl.exe needs to be rebuilt
3650         https://bugs.webkit.org/show_bug.cgi?id=51347
3651
3652         * vcbin/midl.exe: Rebuilt.
3653
3654 2010-12-20  David Levin  <levin@chromium.org>
3655
3656         Reviewed by Ariya Hidayat.
3657
3658         .gitignore and webkit-tools-completion.sh have references to WebKitTools that should be Tools.
3659         https://bugs.webkit.org/show_bug.cgi?id=51343
3660
3661         Follow up from the WebKitTools -> Tools rename.
3662
3663         * Scripts/webkit-tools-completion.sh:
3664
3665 2010-12-20  Cosmin Truta  <ctruta@chromium.org>
3666
3667         Reviewed by James Robinson.
3668
3669         new-run-webkit-tests ignores trailing EOL differences in text tests
3670         https://bugs.webkit.org/show_bug.cgi?id=36983
3671
3672         Changed the handling of new-line characters within new-run-webkit-tests
3673         to match old-run-webkit-tests.  Differences in leading and trailing empty
3674         lines in text expectation files are no longer ignored.
3675
3676         * Scripts/webkitpy/layout_tests/port/base.py:
3677         * Scripts/webkitpy/layout_tests/port/test.py:
3678         Added unit tests.  Removed old duplicate unit test entries.
3679         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
3680
3681 2010-12-20  David Levin  <levin@chromium.org>
3682
3683         Reviewed by Shinichiro Hamaji.
3684
3685         check-webkit-style should detect function declarations (and trivial functions).
3686         https://bugs.webkit.org/show_bug.cgi?id=51303
3687
3688         * Scripts/webkitpy/style/checkers/cpp.py:
3689         (_FunctionState.begin): Add is_declaration and changed the line count
3690         start to begin at -1 (which will keep the results consistent, since
3691         the starting line number passed in is one less in this change).
3692         (detect_functions): changed function detection to now catch trivial
3693         functions and declarations.
3694         (check_pass_ptr_usage): Don't check for Pass*Ptr on the first line
3695         of the function as this may look at return values (when processing
3696         a declaration).
3697         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3698         (FunctionDetectionTest.perform_function_detection): Basic mechanics
3699         of testing the function detection.
3700         (FunctionDetectionTest.test_basic_function_detection): Test a simple
3701         function.
3702         (FunctionDetectionTest.test_function_declaration_detection): Test a
3703         declaration.
3704         (FunctionDetectionTest.test_non_functions): A test case for a case
3705         that caused the code to fail due to the { being in quotes.
3706         (PassPtrTest.test_pass_ref_ptr_return_value): Added some more test
3707         cases to help catch false alarms for return values.
3708         (PassPtrTest.test_pass_ref_ptr_member_variable): Ensure that
3709         we don't get false alarms for member variables either.
3710
3711 2010-12-20  Ryuan Choi  <ryuan.choi@samsung.com>
3712
3713         Reviewed by Antonio Gomes.
3714
3715         [CMAKE] Rename WEBKITTOOLS_DIR to TOOLS_DIR
3716         https://bugs.webkit.org/show_bug.cgi?id=51319
3717
3718         * CMakeListsEfl.txt:
3719
3720 2010-12-18  Adam Barth  <abarth@webkit.org>
3721
3722         Reviewed by Sam Weinig.
3723
3724         Move WebKitExamplePlugins to Examples
3725         https://bugs.webkit.org/show_bug.cgi?id=51291
3726
3727         * Scripts/webkitpy/common/config/build.py:
3728
3729 2010-12-17  Csaba Osztrogonác  <ossy@webkit.org>
3730
3731         Unreviewed Qt buildfix after r74301.
3732
3733         Rename WebKitTools to Tools
3734         https://bugs.webkit.org/show_bug.cgi?id=49861
3735
3736         * MiniBrowser/DerivedSources.pro:
3737         * MiniBrowser/qt/MiniBrowser.pro:
3738
3739 2010-12-17  Dan Bernstein  <mitz@apple.com>
3740
3741         Reviewed by Simon Fraser.
3742
3743         Rename WebKitTools to Tools
3744         https://bugs.webkit.org/show_bug.cgi?id=49861
3745
3746         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3747         * CodeCoverage/README:
3748         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3749         (WebCore::DumpRenderTree::initializeFonts):
3750         * EWSTools/start-commit-queue.sh:
3751         * EWSTools/start-queue.sh:
3752         * GNUmakefile.am:
3753         * MIDLWrapper/MIDLWrapper.cpp:
3754         (wmain):
3755         * MiniBrowser/qt/MiniBrowser.pro:
3756         * Scripts/build-api-tests:
3757         * Scripts/build-dumprendertree:
3758         * Scripts/build-webkit:
3759         * Scripts/build-webkittestrunner:
3760         * Scripts/generate-coverage-data:
3761         * Scripts/old-run-webkit-tests:
3762         * Scripts/run-api-tests:
3763         * Scripts/run-iexploder-tests:
3764         * Scripts/run-javascriptcore-tests:
3765         * Scripts/run-mangleme-tests:
3766         * Scripts/run-sunspider:
3767         * Scripts/run-webkit-websocketserver:
3768         * Scripts/sunspider-compare-results:
3769         * Scripts/test-webkitperl:
3770         * Scripts/test-webkitpy:
3771         * Scripts/update-iexploder-cssproperties:
3772         * Scripts/update-webkit: