2010-12-20 Ryuan Choi <ryuan.choi@samsung.com>
[WebKit.git] / Tools / ChangeLog
1 2010-12-20  Ryuan Choi  <ryuan.choi@samsung.com>
2
3         Reviewed by Antonio Gomes.
4
5         [CMAKE] Rename WEBKITTOOLS_DIR to TOOLS_DIR
6         https://bugs.webkit.org/show_bug.cgi?id=51319
7
8         * CMakeListsEfl.txt:
9
10 2010-12-18  Adam Barth  <abarth@webkit.org>
11
12         Reviewed by Sam Weinig.
13
14         Move WebKitExamplePlugins to Examples
15         https://bugs.webkit.org/show_bug.cgi?id=51291
16
17         * Scripts/webkitpy/common/config/build.py:
18
19 2010-12-17  Csaba Osztrogonác  <ossy@webkit.org>
20
21         Unreviewed Qt buildfix after r74301.
22
23         Rename WebKitTools to Tools
24         https://bugs.webkit.org/show_bug.cgi?id=49861
25
26         * MiniBrowser/DerivedSources.pro:
27         * MiniBrowser/qt/MiniBrowser.pro:
28
29 2010-12-17  Dan Bernstein  <mitz@apple.com>
30
31         Reviewed by Simon Fraser.
32
33         Rename WebKitTools to Tools
34         https://bugs.webkit.org/show_bug.cgi?id=49861
35
36         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
37         * CodeCoverage/README:
38         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
39         (WebCore::DumpRenderTree::initializeFonts):
40         * EWSTools/start-commit-queue.sh:
41         * EWSTools/start-queue.sh:
42         * GNUmakefile.am:
43         * MIDLWrapper/MIDLWrapper.cpp:
44         (wmain):
45         * MiniBrowser/qt/MiniBrowser.pro:
46         * Scripts/build-api-tests:
47         * Scripts/build-dumprendertree:
48         * Scripts/build-webkit:
49         * Scripts/build-webkittestrunner:
50         * Scripts/generate-coverage-data:
51         * Scripts/old-run-webkit-tests:
52         * Scripts/run-api-tests:
53         * Scripts/run-iexploder-tests:
54         * Scripts/run-javascriptcore-tests:
55         * Scripts/run-mangleme-tests:
56         * Scripts/run-sunspider:
57         * Scripts/run-webkit-websocketserver:
58         * Scripts/sunspider-compare-results:
59         * Scripts/test-webkitperl:
60         * Scripts/test-webkitpy:
61         * Scripts/update-iexploder-cssproperties:
62         * Scripts/update-webkit:
63         * Scripts/update-webkit-localizable-strings:
64         * Scripts/webkitdirs.pm:
65         * Scripts/webkitpy/common/checkout/scm.py:
66         * Scripts/webkitpy/common/checkout/scm_unittest.py:
67         * Scripts/webkitpy/common/config/committervalidator.py:
68         * Scripts/webkitpy/common/config/committervalidator_unittest.py:
69         * Scripts/webkitpy/common/config/ports.py:
70         * Scripts/webkitpy/common/config/ports_unittest.py:
71         * Scripts/webkitpy/common/system/logutils_unittest.py:
72         * Scripts/webkitpy/common/system/ospath_unittest.py:
73         * Scripts/webkitpy/layout_tests/port/chromium.py:
74         * Scripts/webkitpy/layout_tests/port/config.py:
75         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
76         * Scripts/webkitpy/layout_tests/port/http_server.py:
77         * Scripts/webkitpy/layout_tests/port/test.py:
78         * Scripts/webkitpy/style/checker.py:
79         * Scripts/webkitpy/style/checker_unittest.py:
80         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
81         * Scripts/webkitpy/tool/commands/queues_unittest.py:
82         * Scripts/webkitpy/tool/steps/steps_unittest.py:
83         * WebKitTestRunner/DerivedSources.pro:
84         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
85         (WTR::activateFonts):
86         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
87         * wx/build/build_utils.py:
88
89 2010-12-16  Antonio Gomes  <agomes@rim.com>
90
91         Reviewed by Martin Robinson.
92
93         Settings::editingBehaviorType() incorrectly returns mac for the gtk build when running tests
94         https://bugs.webkit.org/show_bug.cgi?id=51163
95
96         Since GTK+'s default editing behavior was changed to UNIX in r70975 (see webkitwebsettings.cpp),
97         GTK+'s DRT should also reset to UNIX after each test execution.
98
99         * DumpRenderTree/gtk/DumpRenderTree.cpp:
100         (resetDefaultsToConsistentValues):
101
102 2010-12-17  David Levin  <levin@chromium.org>
103
104         Reviewed by Eric Seidel.
105
106         check-webkit-style should understand WTF #include guards
107         https://bugs.webkit.org/show_bug.cgi?id=44911
108
109         * Scripts/webkitpy/style/checkers/cpp.py:
110         (get_header_guard_cpp_variable): modify to suggest the WTF style
111         of header guard when appropriate.
112         (check_for_header_guard): handle multiple return values from
113         get_header_guard_cpp_variable
114         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
115         (CppStyleTest.test_build_header_guard): Added tests for the WTF
116         header style.
117
118 2010-12-16  David Levin  <levin@chromium.org>
119
120         Reviewed by Eric Seidel.
121
122         test-webkitpy: unittest for the xml.py checker displays a decprecation warning.
123         https://bugs.webkit.org/show_bug.cgi?id=51210
124
125         The error only shows up when using python 2.6 or later.
126
127         * Scripts/webkitpy/style/checkers/xml.py: Replace the usage of
128         the decprecated field error,message with something equivalent.
129
130 2010-12-16  Mihai Parparita  <mihaip@chromium.org>
131
132         Reviewed by Eric Seidel.
133
134         Add --exit-after-n-failures/crashes to NRWT
135         https://bugs.webkit.org/show_bug.cgi?id=51160
136         
137         Abort test run (in a similar way to how control-C is handled) when
138         --exit-after-n-failures/crashes-or-timeouts are passed and we've reached
139         that number of unexpected failures/crashes/timeouts.
140
141         * Scripts/webkitpy/layout_tests/port/test.py:
142         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
143         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
144
145 2010-12-16  David Levin  <levin@chromium.org>
146
147         Reviewed by Shinichiro Hamaji.
148
149         check-webkit-style unit tests has some duplicate boilerplate code.
150         https://bugs.webkit.org/show_bug.cgi?id=49519
151
152         * Scripts/webkitpy/style/checkers/cpp.py:
153         (update_include_state): Replaced the "io" parameter with the global
154         configuration _unit_test_config. This allowed not calling into
155         functions at a low level and also not plumbing through the injection
156         information through many levels of code.
157         (check_for_include_what_you_use): Ditto.
158         (process_file_data): Added the ability to set up the unit test config
159         to allow for injection.
160         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
161         (ErrorCollector.__init__): Added support for having a filter for errors.
162         (ErrorCollector.__call__): Ditto.
163         (CppStyleTestBase.process_file_data): Added the ability to set unit_test_config.
164         (CppStyleTestBase.perform_lint): Consolidated logic for the perform functions.
165         (CppStyleTestBase.perform_single_line_lint): Replace specific calls to
166         functions in the cpp.py with generic processing and a filter that
167         indicates what errors should be kept.
168         (CppStyleTestBase.perform_multi_line_lint): Ditto.
169         (CppStyleTestBase.perform_language_rules_check): Ditto.
170         (CppStyleTestBase.perform_function_lengths_check): Ditto.
171         (CppStyleTestBase.perform_pass_ptr_check): Ditto.
172         (CppStyleTestBase.perform_include_what_you_use): Ditto.
173         (CppStyleTest.test_multi_line_comments): Added another
174         error message which applies to the test case.
175         (CppStyleTest.test_spacing_for_binary_ops): Fixed test
176         to not have config.h, since it is processed as a header file.
177         (CppStyleTest.test_static_or_global_stlstrings): Fixed variable name
178         style and indentation in checked code.
179         (OrderOfIncludesTest.test_check_preprocessor_in_include_section):
180         Fixed line number.
181         (NoNonVirtualDestructorsTest.test_multi_line_declaration_with_error):
182         Ditto.
183
184 2010-12-15  Sheriff Bot  <webkit.review.bot@gmail.com>
185
186         Unreviewed, rolling out r74136.
187         http://trac.webkit.org/changeset/74136
188         https://bugs.webkit.org/show_bug.cgi?id=51135
189
190         r74136 breaks chromium canary bots because some tests are not
191         rebaselined correctly to resolve EOL differences (Requested by
192         jianli on #webkit).
193
194         * Scripts/webkitpy/layout_tests/port/base.py:
195         * Scripts/webkitpy/layout_tests/port/test.py:
196         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
197
198 2010-12-15  Adam Roben  <aroben@apple.com>
199
200         Teach check-webkit-style to check .vcproj and .vsprops files for XML
201         syntax errors
202
203         Fixes <http://webkit.org/b/51103> check-webkit-style should check for
204         XML syntax errors in .vcproj/.vsprops files
205
206         Reviewed by Dave Levin.
207
208         * Scripts/webkitpy/style/checker.py: Added lists of file extensions
209         that should be treated as XML and that should be allowed to contain
210         carriage returns. (These lists happen to be identical currently.)
211         (FileType): Added a new XML type.
212         (CheckerDispatcher.should_check_and_strip_carriage_returns): Added.
213         Just does a simple file extension check.
214         (CheckerDispatcher._file_type): Added a case for XML files.
215         (CheckerDispatcher._create_checker): Ditto. We use XMLChecker for XML
216         files (surprise!).
217         (StyleProcessor.process): Ask the dispatcher whether we should pass the
218         lines through the carriage checker.
219
220         * Scripts/webkitpy/style/checker_unittest.py:
221         (CheckerDispatcherCarriageReturnTest.test_should_check_and_strip_carriage_returns):
222         Added. Checks a few file names to see if carriage returns are allowed
223         or not.
224         (CheckerDispatcherDispatchTest.assert_checker_xml): Added. Similar to
225         other assert_checker_* functions.
226         (CheckerDispatcherDispatchTest.test_xml_paths): Added. Similar to other
227         test_*_paths functions.
228         (CheckerDispatcherDispatchTest.test_xml_paths): Added. Similar to other
229         test_*_paths functions.
230         (CheckerDispatcherDispatchTest.test_none_paths): Removed the vcproj
231         file from this test case, as vcproj files now have a type.
232         (StyleProcessor_CodeCoverageTest.MockDispatcher.should_check_and_strip_carriage_returns):
233         Added. Similar to the other should_* functions.
234         (StyleProcessor_CodeCoverageTest.test_process__carriage_returns_not_stripped):
235         Added. Checks that carriage returns aren't checked for or stripped for
236         allowed files.
237
238         * Scripts/webkitpy/style/checkers/xml.py: Added.
239         (XMLChecker.__init__): Simple init method.
240         (XMLChecker.check): Pass each line through the expat parser, and record
241         a style error for any errors thrown by the parser.
242
243         * Scripts/webkitpy/style/checkers/xml_unittest.py: Added.
244         (XMLCheckerTest.assert_no_error): Checks that the given XML does not
245         produce a style error.
246         (XMLCheckerTest.assert_error): Checks that the given XML produces an
247         error of the given category on the given line.
248         (XMLCheckerTest.mock_handle_style_error): Does nothing. Used for
249         checking that the XMLChecker constructor works properly.
250         (XMLCheckerTest.test_conflict_marker): Tests that conflict markers
251         cause a style error (see, e.g., r73887).
252         (XMLCheckerTest.test_extra_closing_tag): Tests that extra closing tags
253         cause a style error (see, e.g., r73773).
254         (XMLCheckerTest.test_init): Tests that the XMLChecker constructor works
255         properly.
256         (XMLCheckerTest.test_missing_closing_tag): Tests that missing closing
257         tags cause a style error (see, e.g., r72795).
258         (XMLCheckerTest.test_no_error): Tests that valid XML does not cause a
259         style error.
260
261 2010-12-15  Lucas Forschler  <lforschler@apple.com>
262
263         Reviewed by Stephanie Lewis.
264
265         https://bugs.webkit.org/show_bug.cgi?id=51117
266         Add a new leopard test bot
267         really really commit to trunk this time.
268
269         * BuildSlaveSupport/build.webkit.org-config/config.json:
270
271 2010-12-15  Sam Weinig  <sam@webkit.org>
272
273         Reviewed by Anders Carlsson.
274
275         WebKit2: Can't add files to an <input type=file>
276         https://bugs.webkit.org/show_bug.cgi?id=51087
277
278         * MiniBrowser/mac/BrowserWindowController.m:
279         (runOpenPanel):
280         (-[BrowserWindowController awakeFromNib]):
281         Add simple implementation of runOpenPanel callback.
282
283         * MiniBrowser/win/BrowserView.cpp:
284         (BrowserView::create):
285         * WebKitTestRunner/TestController.cpp:
286         (WTR::createOtherPage):
287         (WTR::TestController::initialize):
288         Stub out runOpenPanel callback. 
289
290 2010-12-14  Eric Seidel  <eric@webkit.org>
291
292         Reviewed by Adam Barth.
293
294         commit-queue should upload failure diffs when tests flake
295         https://bugs.webkit.org/show_bug.cgi?id=51051
296
297         To make this testable I needed to pipe FileSystem down onto tool.
298         We've wanted it there for a long time anyway.
299
300         This patch is kinda a big hack.  But we don't have a nice
301         way to read results.html files.  I think this will need further
302         revision before this code actually feels clean.
303
304         As part of testing this change, I had to make MockBugzilla.create_bug
305         actually return an id (like it should) which required updating
306         a few other unit test results (for the better).
307
308         The results_matching_keys change in layouttestresults/rebasline
309         was an alternate path which I decided not to use in the end, but
310         I left the change as it seemed an improvement.
311
312         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
313         * Scripts/webkitpy/common/net/layouttestresults.py:
314         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
315         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
316         * Scripts/webkitpy/tool/commands/queues.py:
317         * Scripts/webkitpy/tool/commands/rebaseline.py:
318         * Scripts/webkitpy/tool/main.py:
319         * Scripts/webkitpy/tool/mocktool.py:
320
321 2010-12-15  Cosmin Truta  <ctruta@chromium.org>
322
323         Reviewed by James Robinson.
324
325         new-run-webkit-tests ignores trailing EOL differences in text tests
326         https://bugs.webkit.org/show_bug.cgi?id=36983
327
328         Changed the handling of new-line characters within new-run-webkit-tests
329         to match old-run-webkit-tests.  Differences in leading and trailing empty
330         lines in text expectation files are no longer ignored.
331
332         * Scripts/webkitpy/layout_tests/port/base.py:
333         * Scripts/webkitpy/layout_tests/port/test.py:
334         Added unit tests.  Removed old duplicate unit test entries.
335         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
336
337 2010-12-15  Ojan Vafai  <ojan@chromium.org>
338
339         Reviewed by Adam Barth.
340
341         make status-bubble white-space:nowrap so we can measure it's width without wrapping
342         https://bugs.webkit.org/show_bug.cgi?id=51149
343
344         * QueueStatusServer/templates/statusbubble.html:
345
346 2010-12-15  Ojan Vafai  <ojan@chromium.org>
347
348         Reviewed by Adam Barth.
349
350         have the statusbubble postMessage it's metrics so that embedders can properly size the iframe
351         https://bugs.webkit.org/show_bug.cgi?id=51125
352
353         * QueueStatusServer/templates/statusbubble.html:
354
355 2010-12-15  Darin Adler  <darin@apple.com>
356
357         * Scripts/webkitpy/common/net/buildbot: Added property svn:ignore.
358
359 2010-12-15  Sheriff Bot  <webkit.review.bot@gmail.com>
360
361         Unreviewed, rolling out r74117.
362         http://trac.webkit.org/changeset/74117
363         https://bugs.webkit.org/show_bug.cgi?id=51113
364
365         This broke the GTK1 build. (Requested by mrobinson on
366         #webkit).
367
368         * Scripts/webkitdirs.pm:
369
370 2010-12-15  Amruth Raj  <amruthraj@motorola.com> and Ravi Kasibhatla  <ravi.kasibhatla@motorola.com>
371
372         Reviewed by Martin Robinson.
373
374         Change generate-forwarding-headers.pl for GTK port usage 
375         (https://bugs.webkit.org/show_bug.cgi?id=37369)
376
377         * Scripts/webkitdirs.pm: Added changes to build webkit2 for GTK port using build-webkit script.
378
379 2010-12-14  Kent Tamura  <tkent@chromium.org>
380
381         Reviewed by Jian Li.
382
383         [DRT/Chromium] Remove another unnecessary error message
384         https://bugs.webkit.org/show_bug.cgi?id=51083
385
386         * DumpRenderTree/chromium/WebViewHost.cpp:
387         (WebViewHost::didInvalidateRect):
388
389 2010-12-14  Lucas Forschler  <lforschler@apple.com>
390
391         Reviewed by Stephanie Lewis.
392
393         Add a new Leopard Debug Test WK2 Bot
394
395         * BuildSlaveSupport/build.webkit.org-config/config.json:
396
397 2010-12-14  Ojan Vafai  <ojan@chromium.org>
398
399         Fix python unittests after http://trac.webkit.org/changeset/74070.
400
401         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
402
403 2010-12-14  Kent Tamura  <tkent@chromium.org>
404
405         Reviewed by Jian Li.
406
407         [DRT/Chromium] Remove a unnecessary error message
408         https://bugs.webkit.org/show_bug.cgi?id=51069
409
410         * DumpRenderTree/chromium/WebViewHost.cpp:
411         (WebViewHost::paintInvalidatedRegion):
412
413 2010-12-14  Benjamin Kalman  <kalman@chromium.org>
414
415         Reviewed by Ojan Vafai.
416
417         Using BUG/BUGWK in test_expectations is error prone, should use BUGCR/BUGWK
418         https://bugs.webkit.org/show_bug.cgi?id=48926
419
420         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
421         Add presubmit check that BUG isn't used, either BUGCR/BUGWK/BUGV8_.
422
423 2010-12-14  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
424
425         Reviewed by Eric Seidel.
426
427         [Qt] [Symbian] Do not use pkg-config on Symbian as it is not supported
428         https://bugs.webkit.org/show_bug.cgi?id=50231
429
430         Guard CONFIG+=link_pkgconfig with !symbian.
431
432         * DumpRenderTree/qt/DumpRenderTree.pro:
433         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
434         * WebKitTestRunner/qt/WebKitTestRunner.pro:
435
436 2010-12-14  Philippe Normand  <pnormand@igalia.com>
437
438         Reviewed by Ojan Vafai.
439
440         [new-run-webkit-tests] expectations parsing is slow
441         https://bugs.webkit.org/show_bug.cgi?id=50635
442
443         Avoid expensive iteration of all the tests when checking if a test
444         file is to be skipped or not.
445
446         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
447         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
448         * Scripts/webkitpy/layout_tests/port/test.py:
449
450 2010-12-14  Mario Sanchez Prada  <msanchez@igalia.com>
451
452         Reviewed by Xan Lopez.
453
454         [Gtk] Implement STATE_FOCUSED, STATE_FOCUSABLE, and corresponding events for text objects
455         https://bugs.webkit.org/show_bug.cgi?id=27048
456
457         Add support in DRT for checking whether an accessibility UI
458         element is focusable and/or focused. Implemented for GTK.
459
460         * DumpRenderTree/AccessibilityUIElement.cpp:
461         (getIsFocusedCallback): New.
462         (getIsFocusableCallback): New.
463         (AccessibilityUIElement::getJSClass): Add the new available
464         callbacks for isFocused and isFocusable.
465         * DumpRenderTree/AccessibilityUIElement.h:
466         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
467         (AccessibilityUIElement::isFocused): New, implemented by checking
468         whether the related AtkState value is in the object's state set.
469         (AccessibilityUIElement::isFocusable): Ditto.
470         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
471         (AccessibilityUIElement::isFocused): New, dummy implementation.
472         (AccessibilityUIElement::isFocusable): Ditto.
473         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
474         (AccessibilityUIElement::isFocused): Ditto.
475         (AccessibilityUIElement::isFocusable): Ditto.
476
477 2010-12-14  Eric Seidel  <eric@webkit.org>
478
479         Reviewed by Ojan Vafai.
480
481         webkit-patch should warn users when they're using a 32-bit git on a 64-bit system
482         https://bugs.webkit.org/show_bug.cgi?id=50715
483
484         This patch makes webkit-patch print the following:
485
486         Warning: This machine is 64-bit, but the git binary (/usr/local/git/bin/git) does not support 64-bit.
487         Install a 64-bit git for better performance, see:
488         https://lists.webkit.org/pipermail/webkit-dev/2010-December/015249.html
489
490         I wrote this mostly because I have approximately 8 machines that I use
491         and making sure each one is using a good Git install seemed folly.
492         webkit-patch makes a lot of git calls, so using a fast git can shave
493         several seconds in every invocation.  See the webkit-dev thread for more info.
494
495         This message will print twice during 'webkit-patch upload',
496         once from webkit-patch and once from check-webkit-style.
497
498         Unfortunately there is no good way to test this due to how machine-dependent
499         the code is.  I considered writing a test for the log message, but it seemed not worth it.
500
501         * Scripts/webkitpy/common/checkout/scm.py:
502
503 2010-12-13  Eric Seidel  <eric@webkit.org>
504
505         Reviewed by Adam Barth.
506
507         FlakyTestReporter doesn't understand bots running from multiple email addresses
508         https://bugs.webkit.org/show_bug.cgi?id=50960
509
510         This explains at least one of the dupes of:
511         https://bugs.webkit.org/show_bug.cgi?id=50863
512         that we saw filed by the commit-queue this morning.
513         I think the other one was explained by my previous fix to result counting code.
514
515         Since this is really hard to test with a unit test, instead I
516         create a new (possibly useful in the future) command
517         which given a layout test path will return you
518         the one bug which our tools would assume it the flaky test bug.
519         If some other script wants to use bug-for-test we'll
520         need to extend it with some options like --create-if-missing or similar.
521
522         * Scripts/webkitpy/common/net/bugzilla/bug.py:
523         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
524         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
525         * Scripts/webkitpy/tool/commands/__init__.py:
526         * Scripts/webkitpy/tool/commands/bugfortest.py: Added.
527
528 2010-12-13  Mihai Parparita  <mihaip@chromium.org>
529
530         Reviewed by James Robinson.
531
532         Add option to build-webkit to not build WebKit2
533         https://bugs.webkit.org/show_bug.cgi?id=50988
534         
535         Add support for a --no-webkit2 option to build-webkit. It seems to save
536         ~1 minute from clean builds and ~10 seconds from no-op builds.
537
538         * Scripts/build-webkit:
539
540 2010-12-13  Lucas Forschler  <lforschler@apple.com>
541
542         Reviewed by Dave Kilzer.
543
544         Update iexploder from 1.3.2 to 1.7.2
545         Move 1.3.2 into its own subdir
546         Add 1.7.2 into its own subdir
547         update scripts to point to new 1.3.2 location (avoid breaking existing scripts)
548
549         * Scripts/run-iexploder-tests:
550         * Scripts/update-iexploder-cssproperties:
551         * iExploder/CHANGELOG.txt: Removed.
552         * iExploder/LICENSE.txt: Removed.
553         * iExploder/README.txt: Removed.
554         * iExploder/htdocs: Removed.
555         * iExploder/iexploder-1.3.2: Added.
556         * iExploder/iexploder-1.3.2/CHANGELOG.txt: Copied from iExploder/CHANGELOG.txt.
557         * iExploder/iexploder-1.3.2/LICENSE.txt: Copied from iExploder/LICENSE.txt.
558         * iExploder/iexploder-1.3.2/README.txt: Copied from iExploder/README.txt.
559         * iExploder/iexploder-1.3.2/htdocs: Added.
560         * iExploder/iexploder-1.3.2/htdocs/config.rb: Copied from iExploder/htdocs/config.rb.
561         * iExploder/iexploder-1.3.2/htdocs/cssproperties.in: Copied from iExploder/htdocs/cssproperties.in.
562         * iExploder/iexploder-1.3.2/htdocs/cssvalues.in: Copied from iExploder/htdocs/cssvalues.in.
563         * iExploder/iexploder-1.3.2/htdocs/htmlattrs.in: Copied from iExploder/htdocs/htmlattrs.in.
564         * iExploder/iexploder-1.3.2/htdocs/htmltags.in: Copied from iExploder/htdocs/htmltags.in.
565         * iExploder/iexploder-1.3.2/htdocs/htmlvalues.in: Copied from iExploder/htdocs/htmlvalues.in.
566         * iExploder/iexploder-1.3.2/htdocs/iexploder.cgi: Copied from iExploder/htdocs/iexploder.cgi.
567         * iExploder/iexploder-1.3.2/htdocs/iexploder.rb: Copied from iExploder/htdocs/iexploder.rb.
568         * iExploder/iexploder-1.3.2/htdocs/index.html: Copied from iExploder/htdocs/index.html.
569         * iExploder/iexploder-1.3.2/htdocs/webserver.rb: Copied from iExploder/htdocs/webserver.rb.
570         * iExploder/iexploder-1.3.2/tools: Added.
571         * iExploder/iexploder-1.3.2/tools/lasthit.rb: Copied from iExploder/tools/lasthit.rb.
572         * iExploder/iexploder-1.3.2/tools/osx_last_crash.rb: Copied from iExploder/tools/osx_last_crash.rb.
573         * iExploder/iexploder-1.3.2/tools/showtest.rb: Copied from iExploder/tools/showtest.rb.
574         * iExploder/iexploder-1.7.2: Added.
575         * iExploder/iexploder-1.7.2/ChangeLog.txt: Added.
576         * iExploder/iexploder-1.7.2/LICENSE.txt: Added.
577         * iExploder/iexploder-1.7.2/README.txt: Added.
578         * iExploder/iexploder-1.7.2/output: Added.
579         * iExploder/iexploder-1.7.2/src: Added.
580         * iExploder/iexploder-1.7.2/src/browser_harness.rb: Added.
581         * iExploder/iexploder-1.7.2/src/config.yaml: Added.
582         * iExploder/iexploder-1.7.2/src/css-atrules: Added.
583         * iExploder/iexploder-1.7.2/src/css-atrules/mozilla: Added.
584         * iExploder/iexploder-1.7.2/src/css-atrules/webkit: Added.
585         * iExploder/iexploder-1.7.2/src/css-properties: Added.
586         * iExploder/iexploder-1.7.2/src/css-properties/dillo: Added.
587         * iExploder/iexploder-1.7.2/src/css-properties/gtkhtml: Added.
588         * iExploder/iexploder-1.7.2/src/css-properties/internet_explorer6: Added.
589         * iExploder/iexploder-1.7.2/src/css-properties/mozilla: Added.
590         * iExploder/iexploder-1.7.2/src/css-properties/webkit: Added.
591         * iExploder/iexploder-1.7.2/src/css-pseudo: Added.
592         * iExploder/iexploder-1.7.2/src/css-pseudo/mozilla: Added.
593         * iExploder/iexploder-1.7.2/src/css-pseudo/webkit: Added.
594         * iExploder/iexploder-1.7.2/src/css-values: Added.
595         * iExploder/iexploder-1.7.2/src/css-values/dillo: Added.
596         * iExploder/iexploder-1.7.2/src/css-values/gtkhtml: Added.
597         * iExploder/iexploder-1.7.2/src/css-values/mozilla: Added.
598         * iExploder/iexploder-1.7.2/src/css-values/other: Added.
599         * iExploder/iexploder-1.7.2/src/css-values/webkit: Added.
600         * iExploder/iexploder-1.7.2/src/headers: Added.
601         * iExploder/iexploder-1.7.2/src/headers/dillo: Added.
602         * iExploder/iexploder-1.7.2/src/headers/gtkhtml: Added.
603         * iExploder/iexploder-1.7.2/src/headers/mozilla: Added.
604         * iExploder/iexploder-1.7.2/src/headers/webkit: Added.
605         * iExploder/iexploder-1.7.2/src/html-attrs: Added.
606         * iExploder/iexploder-1.7.2/src/html-attrs/dillo: Added.
607         * iExploder/iexploder-1.7.2/src/html-attrs/gtkhtml: Added.
608         * iExploder/iexploder-1.7.2/src/html-attrs/internet_explorer6: Added.
609         * iExploder/iexploder-1.7.2/src/html-attrs/mozilla: Added.
610         * iExploder/iexploder-1.7.2/src/html-attrs/other: Added.
611         * iExploder/iexploder-1.7.2/src/html-attrs/webkit: Added.
612         * iExploder/iexploder-1.7.2/src/html-tags: Added.
613         * iExploder/iexploder-1.7.2/src/html-tags/dillo: Added.
614         * iExploder/iexploder-1.7.2/src/html-tags/gtkhtml: Added.
615         * iExploder/iexploder-1.7.2/src/html-tags/mozilla: Added.
616         * iExploder/iexploder-1.7.2/src/html-tags/other: Added.
617         * iExploder/iexploder-1.7.2/src/html-tags/webkit: Added.
618         * iExploder/iexploder-1.7.2/src/html-values: Added.
619         * iExploder/iexploder-1.7.2/src/html-values/dillo: Added.
620         * iExploder/iexploder-1.7.2/src/html-values/gtkhtml: Added.
621         * iExploder/iexploder-1.7.2/src/html-values/mozilla: Added.
622         * iExploder/iexploder-1.7.2/src/html-values/other: Added.
623         * iExploder/iexploder-1.7.2/src/html-values/webkit: Added.
624         * iExploder/iexploder-1.7.2/src/iexploder.cgi: Added.
625         * iExploder/iexploder-1.7.2/src/iexploder.rb: Added.
626         * iExploder/iexploder-1.7.2/src/index.html: Added.
627         * iExploder/iexploder-1.7.2/src/media: Added.
628         * iExploder/iexploder-1.7.2/src/media/blank.ogg: Added.
629         * iExploder/iexploder-1.7.2/src/media/blank.snd: Added.
630         * iExploder/iexploder-1.7.2/src/media/blank.wav: Added.
631         * iExploder/iexploder-1.7.2/src/media/bug.bmp: Added.
632         * iExploder/iexploder-1.7.2/src/media/bug.gif: Added.
633         * iExploder/iexploder-1.7.2/src/media/bug.ico: Added.
634         * iExploder/iexploder-1.7.2/src/media/bug.jng: Added.
635         * iExploder/iexploder-1.7.2/src/media/bug.jpg: Added.
636         * iExploder/iexploder-1.7.2/src/media/bug.png: Added.
637         * iExploder/iexploder-1.7.2/src/media/bug.svg: Added.
638         * iExploder/iexploder-1.7.2/src/media/bug.tiff: Added.
639         * iExploder/iexploder-1.7.2/src/media/bug.xbm: Added.
640         * iExploder/iexploder-1.7.2/src/media/bug.xpm: Added.
641         * iExploder/iexploder-1.7.2/src/mime-types: Added.
642         * iExploder/iexploder-1.7.2/src/mime-types/dillo: Added.
643         * iExploder/iexploder-1.7.2/src/mime-types/mozilla: Added.
644         * iExploder/iexploder-1.7.2/src/mime-types/webkit: Added.
645         * iExploder/iexploder-1.7.2/src/protocols: Added.
646         * iExploder/iexploder-1.7.2/src/protocols/dillo: Added.
647         * iExploder/iexploder-1.7.2/src/protocols/gtkhtml: Added.
648         * iExploder/iexploder-1.7.2/src/protocols/mozilla: Added.
649         * iExploder/iexploder-1.7.2/src/protocols/webkit: Added.
650         * iExploder/iexploder-1.7.2/src/scanner.rb: Added.
651         * iExploder/iexploder-1.7.2/src/version.rb: Added.
652         * iExploder/iexploder-1.7.2/src/webserver.rb: Added.
653         * iExploder/iexploder-1.7.2/testcases: Added.
654         * iExploder/iexploder-1.7.2/testcases/testcase-Linux_x86_64_rv2.0b6pre_Gecko-20100904_Firefox-4.0b6pre-TEST-8375-1_59.html: Added.
655         * iExploder/iexploder-1.7.2/testcases/testcase-Opera-9.80_Linux_x86_64_en_Presto-2.6.30_Version-10.61-16704-3_108,3.html: Added.
656         * iExploder/iexploder-1.7.2/testcases/testcase-U_Intel_Mac_OS_X_10_6_4_en-US_AppleWebKit-534.8_Chrome-7.0.529.0-TEST-611-3_36,9.html: Added.
657         * iExploder/iexploder-1.7.2/testcases/testcase-U_Intel_Mac_OS_X_10_6_4_en-US_AppleWebKit-534.8_hrome-7.0.529.0-TEST-55313622206-3_6,0.html: Added.
658         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.6_Chrome-7.0.503.1-TEST-120813-8_72,56,24,8,0.html: Added.
659         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.6_Chrome-7.0.503.1-TEST-121240-3_81,3.html: Added.
660         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.7_Chrome-7.0.513.0-4800-5_80,65,15.html: Added.
661         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.7_Chrome-7.0.513.0-TEST-23583190347-3_15,12.html: Added.
662         * iExploder/iexploder-1.7.2/tools: Added.
663         * iExploder/iexploder-1.7.2/tools/lasthit.rb: Added.
664         * iExploder/iexploder-1.7.2/tools/osx_last_crash.rb: Added.
665         * iExploder/iexploder-1.7.2/tools/release_src.sh: Added.
666         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh: Added.
667         * iExploder/tools: Removed.
668
669 2010-12-13  Sam Weinig  <sam@webkit.org>
670
671         Reviewed by Anders Carlsson.
672
673         Remove associated page concept from WKView constructor
674         https://bugs.webkit.org/show_bug.cgi?id=50983
675
676         Step 1: Remove associate page constructors from WKView and make
677         all views use the shared namespace for the context.
678
679         * TestWebKitAPI/PlatformWebView.h:
680         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
681         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
682         * WebKitTestRunner/PlatformWebView.h:
683         * WebKitTestRunner/TestController.cpp:
684         (WTR::createOtherPage):
685         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
686         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
687         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
688
689 2010-12-13  Sam Weinig  <sam@webkit.org>
690
691         Reviewed by Anders Carlsson.
692
693         Change the WebKit2 public API so there is no explicit WKPageNamespace object
694         https://bugs.webkit.org/show_bug.cgi?id=50898
695
696         * MiniBrowser/mac/AppDelegate.h:
697         * MiniBrowser/mac/AppDelegate.m:
698         * MiniBrowser/mac/BrowserWindowController.h:
699         * MiniBrowser/mac/BrowserWindowController.m:
700         * MiniBrowser/win/BrowserView.cpp:
701         Convert MiniBrowser to not use PageNamespaces.
702
703         * TestWebKitAPI/PlatformWebView.h:
704         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
705         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
706         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
707         * TestWebKitAPI/Tests/WebKit2/Find.cpp:
708         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
709         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
710         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
711         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
712         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
713         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
714         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
715         * TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp:
716         * TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp:
717         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
718         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
719         Convert TestWebKitAPI to not use PageNamespaces.
720
721         * WebKitTestRunner/PlatformWebView.h:
722         * WebKitTestRunner/TestController.cpp:
723         * WebKitTestRunner/TestController.h:
724         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
725         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
726         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
727         Convert WebKitTestRunner to not use PageNamespaces.
728
729 2010-12-13  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
730
731         Reviewed by Eric Seidel.
732
733         webkit-patch rollout should be able to do multi-revision rollouts
734         https://bugs.webkit.org/show_bug.cgi?id=33336
735
736         Make it possible to pass more than one revision to webkit-patch.
737
738         * Scripts/webkitpy/common/checkout/api.py:
739         * Scripts/webkitpy/common/checkout/changelog.py:
740         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
741         * Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:
742         * Scripts/webkitpy/tool/commands/download.py:
743         * Scripts/webkitpy/tool/commands/download_unittest.py:
744         * Scripts/webkitpy/tool/mocktool.py:
745         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
746         * Scripts/webkitpy/tool/steps/revertrevision.py:
747
748 2010-12-13  Eric Seidel  <eric@webkit.org>
749
750         Unreviewed.
751
752         Teach webkit-patch how to search bugzilla
753         https://bugs.webkit.org/show_bug.cgi?id=50500
754
755         webkit-patch bug-search fails when there is only one result.
756         Turns out we needed a bit more logic in our result count parsing code.
757
758         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
759         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
760
761 2010-12-13  Antti Koivisto  <antti@apple.com>
762
763         Reviewed by Alexey Proskuryakov.
764
765         Add setSerializeHTTPLoads function to allow testing resource load order on OS X.
766         https://bugs.webkit.org/show_bug.cgi?id=50758
767
768         * DumpRenderTree/LayoutTestController.cpp:
769         (setSerializeHTTPLoadsCallback):
770         (LayoutTestController::staticFunctions):
771         * DumpRenderTree/LayoutTestController.h:
772         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
773         (LayoutTestController::setSerializeHTTPLoads):
774         * DumpRenderTree/mac/DumpRenderTree.mm:
775         (resetDefaultsToConsistentValues):
776         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
777         (LayoutTestController::setSerializeHTTPLoads):
778         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
779         (LayoutTestController::setSerializeHTTPLoads):
780
781 2010-12-13  Dimitri Glazkov  <dglazkov@chromium.org>
782
783         Reviewed by Ojan Vafai.
784
785         Remove "use-drt" option from test step command line, since the option was removed in r73748.
786         https://bugs.webkit.org/show_bug.cgi?id=50936
787
788         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Removed the option.
789
790 2010-12-13  Patrick Gansterer  <paroga@webkit.org>
791
792         Reviewed by Csaba Osztrogonác.
793
794         Add revlink to BuildBot status
795         https://bugs.webkit.org/show_bug.cgi?id=50914
796
797         This adds a hyperlink to trac changeset on the revision numbers. 
798
799         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
800
801 2010-12-13  Andras Becsi  <abecsi@webkit.org>
802
803         Reviewed by Csaba Osztrogonác.
804
805         [Qt][WK2] Fix build if WebKitTools are not available
806         https://bugs.webkit.org/show_bug.cgi?id=50242
807
808         * MiniBrowser/qt/MiniBrowser.pro: Correct the comment.
809         * Scripts/webkitdirs.pm: Added WebKitTools/MiniBrowser to $subdirs.
810         * MiniBrowser/DerivedSources.pro: Added.
811
812 2010-12-13  Eric Seidel  <eric@webkit.org>
813
814         Reviewed by Adam Barth.
815
816         EWS Queues should remove orpahned pyc files before starting
817         https://bugs.webkit.org/show_bug.cgi?id=50904
818
819         A previous check added a platform.py which caused
820         EWS bots on some platforms to hit an import exception.
821         The platform.py file was removed in a subsequent commit, but
822         the EWS bots in question stayed stuck.  This change will
823         fix those bots once restarted (and prevent this in the future).
824
825         I also went ahead and unified start-queue and start-commit-queue
826         since they were nearly identical.  I also added bot_id support
827         to both force all EWSes to have bot ids as well as get rid of the one
828         remaining reason why I had my own copies of these scripts.
829         Hopefully this will be enough to get all the other bot admins
830         (ahem, Adam, ahem) to move to using these checked in copies as well.
831
832         * EWSTools/start-commit-queue.sh: Removed.
833         * EWSTools/start-queue.sh:
834
835 2010-10-28  MORITA Hajime  <morrita@google.com>
836
837         Reviewed by Ojan Vafai.
838
839         spellcheck does not check pasted text
840         https://bugs.webkit.org/show_bug.cgi?id=40092
841
842         Added LayoutTestController::setAsynchronousSpellCheckingEnabled()
843         to control the setting.
844
845         * DumpRenderTree/LayoutTestController.cpp:
846         (setAsynchronousSpellCheckingEnabledCallback):
847         (LayoutTestController::staticFunctions):
848         * DumpRenderTree/LayoutTestController.h:
849         * DumpRenderTree/chromium/LayoutTestController.h:
850         * DumpRenderTree/chromium/LayoutTestController.cpp:
851         (LayoutTestController::LayoutTestController):
852         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
853         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
854         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
855         * DumpRenderTree/mac/DumpRenderTree.mm:
856         (resetDefaultsToConsistentValues):
857         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
858         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
859         * DumpRenderTree/qt/LayoutTestControllerQt.h:
860         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
861         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
862         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
863         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
864         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
865         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
866
867 2010-12-12  Sam Weinig  <sam@webkit.org>
868
869         Reviewed by Anders Carlsson.
870
871         Fix failing API test. It turns out that a pop-state event
872         is sent before every fragment navigation, so we have to test
873         for it in addition in PageLoadDidChangeLocationWithinPageForFrame.
874
875         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
876         (TestWebKitAPI::didSameDocumentNavigationForFrame):
877
878 2010-12-12  Alejandro G. Castro  <alex@igalia.com>
879
880         Reviewed by Eric Seidel.
881
882         [GTK] Add new-run-webkit-tests support to gtk
883         https://bugs.webkit.org/show_bug.cgi?id=50681
884
885         Adding the basic support to run the new-run-webkit-tests.
886
887         * Scripts/webkitpy/layout_tests/port/gtk.py:
888
889 2010-10-11  Diego Gonzalez  <diegohcg@webkit.org>
890
891         Reviewed by Kenneth Rohde Christiansen.
892
893         [Qt] Mock DeviceOrientation client for DRT
894         https://bugs.webkit.org/show_bug.cgi?id=47490
895
896         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
897         (WebCore::DumpRenderTree::DumpRenderTree):
898         (WebCore::DumpRenderTree::~DumpRenderTree):
899         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
900         (LayoutTestController::setMockDeviceOrientation):
901
902 2010-12-11  Philippe Normand  <pnormand@igalia.com>
903
904         Reviewed by Gustavo Noronha Silva.
905
906         [GTK] launcher: disable the Mozilla-style fullscreen API
907         https://bugs.webkit.org/show_bug.cgi?id=50874
908
909         Disabling the fullscreen API until its implementation for GTK is
910         mature enough. The webview setting for it is already FALSE by
911         default.
912
913         * GtkLauncher/main.c:
914         (createWindow):
915
916 2010-12-10  Eric Seidel  <eric@webkit.org>
917
918         Reviewed by Adam Barth.
919
920         commit-queue flaky test messages show cryptic version information for mac os x
921         https://bugs.webkit.org/show_bug.cgi?id=50864
922
923         Turns out platform.platform() returns kernel version information
924         which isn't helpful, and just plain confusing on Mac
925         (OS X 10.6.5 uses Darwin Kernel 10.5.0).
926
927         So I've updated PlatformInfo.display_name() to special case
928         mac.  I also found a bad use of sys.platform in the process
929         and fixed that.  (sys.platform always returns 'darwin' on mac).
930
931         * Scripts/webkitpy/common/system/platforminfo.py:
932         * Scripts/webkitpy/common/system/user.py:
933         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
934         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
935         * Scripts/webkitpy/tool/commands/queues_unittest.py:
936
937 2010-12-10  Eric Seidel  <eric@webkit.org>
938
939         Unreviewed.
940
941         Exception seen while reporting flaky test with commit-queue.
942         Just a missing include.
943
944         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
945         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
946
947 2010-12-10  Kinuko Yasuda  <kinuko@chromium.org>
948
949         Reviewed by Eric Seidel.
950
951         [Chromium] Remove old JSONResultsGenerator script that existed for backward-compatibility
952         https://bugs.webkit.org/show_bug.cgi?id=50796
953
954         Also updating the test code to use JSONResultsGeneratorBase and
955         to improve test coverage for incremental cases.
956
957         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
958         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
959
960 2010-12-10  Joseph Pecoraro  <joepeck@webkit.org>
961
962         Reviewed by Darin Adler.
963
964         prepare-ChangeLog --help doesn't mention --bug shorthand -b
965         https://bugs.webkit.org/show_bug.cgi?id=50835
966
967         * Scripts/prepare-ChangeLog: be more explicit about -b and match file style.
968
969 2010-12-10  Eric Seidel  <eric@webkit.org>
970
971         Reviewed by Adam Barth.
972
973         Bugs created by the commit-queue should all block on a master bug
974         https://bugs.webkit.org/show_bug.cgi?id=50857
975
976         This makes all bugs created by the commit-queue block on:
977         https://bugs.webkit.org/show_bug.cgi?id=50856
978
979         In the process of testing this, I found that the existing
980         create_bug code was wrong.  I also found that existing
981         unit tests for create-rollout used invalid values
982         for options.blocks.  I fixed both issues and tested.
983
984         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
985         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
986         * Scripts/webkitpy/tool/commands/commandtest.py:
987         * Scripts/webkitpy/tool/commands/download_unittest.py:
988         * Scripts/webkitpy/tool/commands/upload_unittest.py:
989         * Scripts/webkitpy/tool/mocktool.py:
990         * Scripts/webkitpy/tool/steps/options.py:
991
992 2010-12-10  Eric Seidel  <eric@webkit.org>
993
994         Reviewed by Adam Barth.
995
996         Teach webkitpy how to follow duplicate chains when posting comments on flake bugs
997         https://bugs.webkit.org/show_bug.cgi?id=50853
998
999         I also discovered when doing this that the code was posting
1000         the comment on the wrong bug, but that's fixed here too.
1001
1002         * Scripts/webkitpy/common/net/bugzilla/bug.py:
1003         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1004         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1005         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1006         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1007         * Scripts/webkitpy/tool/mocktool.py:
1008
1009 2010-12-10  Anders Carlsson  <andersca@apple.com>
1010
1011         Reviewed by John Sullivan.
1012
1013         Make WKContextGetStatistics gather global statistics
1014         https://bugs.webkit.org/show_bug.cgi?id=50850
1015
1016         Remove the code that gets the statistics and fills in the per context
1017         statistics information for now.
1018
1019         * MiniBrowser/mac/BrowserStatisticsWindowController.m:
1020         (-[BrowserStatisticsWindowController refreshStatistics:]):
1021
1022 2010-12-10  Eric Seidel  <eric@webkit.org>
1023
1024         Unreviewed.
1025
1026         commit-queue should report port/platform information when commenting on flaky test bugs
1027         https://bugs.webkit.org/show_bug.cgi?id=50839
1028
1029         Renamed platform.py to platforminfo.py.  This broke import platform in executive.py
1030         which was only used by new run webkit tests (and clearly not unit tested).
1031
1032         * Scripts/webkitpy/common/system/platforminfo.py: Renamed from WebKitTools/Scripts/webkitpy/common/system/platform.py.
1033         * Scripts/webkitpy/tool/main.py:
1034         * Scripts/webkitpy/tool/mocktool.py:
1035
1036 2010-12-10  Eric Seidel  <eric@webkit.org>
1037
1038         Reviewed by Tony Chang.
1039
1040         commit-queue should report port/platform information when commenting on flaky test bugs
1041         https://bugs.webkit.org/show_bug.cgi?id=50839
1042
1043         This was a suggestion from Tony Chang this morning.
1044         I added a platform.py class so I could easily mock the platform call,
1045         but that may not be the final solution for this mocking.
1046         We'll try it and see.
1047
1048         * Scripts/webkitpy/common/system/platform.py: Added.
1049         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1050         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1051         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1052         * Scripts/webkitpy/tool/main.py:
1053         * Scripts/webkitpy/tool/mocktool.py:
1054
1055 2010-12-10  Krithigassree Sambamurthy  <krithigassree.sambamurthy@nokia.com>
1056
1057         Reviewed by Joseph Pecoraro.
1058
1059         Bug 43455 - [Qt]: Implement Application Cache Quotas
1060         https://bugs.webkit.org/show_bug.cgi?id=43455
1061
1062         Introduce functions to allow new appcache layout test origin-quota.html
1063         to work correctly under Qt.
1064
1065         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1066         (WebCore::DumpRenderTree::DumpRenderTree):
1067         (WebCore::DumpRenderTree::dumpApplicationCacheQuota):
1068         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1069
1070         Introduce functions to allow new appcache layout test origin-quota.html
1071         to be successful under qt. Changes required because LayoutTestControllerQt
1072         does not inherit from LayoutController.
1073
1074         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1075         (LayoutTestController::reset):
1076         (LayoutTestController::clearAllApplicationCaches):
1077         (LayoutTestController::setApplicationCacheOriginQuota):
1078         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1079         (LayoutTestController::shouldDumpApplicationCacheDelegateCallbacks):
1080         (LayoutTestController::dumpApplicationCacheDelegateCallbacks):
1081
1082 2010-12-10  Eric Seidel  <eric@webkit.org>
1083
1084         Reviewed by Adam Barth.
1085
1086         Move buildbot.py into its own module so we can split it out into one-file-per-class
1087         https://bugs.webkit.org/show_bug.cgi?id=50806
1088
1089         We're adding more buildbot logic these days, so it makes sense
1090         to give buildbot its own module.
1091
1092         * Scripts/webkitpy/common/net/buildbot/__init__.py: Added.
1093         * Scripts/webkitpy/common/net/buildbot/buildbot.py: Renamed from WebKitTools/Scripts/webkitpy/common/net/buildbot.py.
1094         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py: Renamed from WebKitTools/Scripts/webkitpy/common/net/buildbot_unittest.py.
1095         * Scripts/webkitpy/common/net/failuremap.py:
1096         * Scripts/webkitpy/common/net/regressionwindow.py:
1097         * Scripts/webkitpy/tool/commands/rebaseline.py:
1098
1099 2010-12-10  Tony Chang  <tony@chromium.org>
1100
1101         Reviewed by Eric Seidel.
1102
1103         Use FileSystem::remove when cleaning up http lock files
1104         https://bugs.webkit.org/show_bug.cgi?id=50830
1105
1106         * Scripts/webkitpy/layout_tests/port/http_lock.py:
1107
1108 2010-12-10  Joone Hur  <joone@kldp.org>
1109
1110         Reviewed by Martin Robinson.
1111
1112         [GTK] DRT needs layoutTestController.setCacheModel
1113         https://bugs.webkit.org/show_bug.cgi?id=50705
1114         
1115         webkit_set_cache_mode() is called to set the cache model.
1116         
1117         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1118         (LayoutTestController::setCacheModel): Set the cache model. 
1119
1120 2010-12-10  Tony Chang  <tony@chromium.org>
1121
1122         Reviewed by Ojan Vafai.
1123
1124         [chromium] remove --use-drt and add --use-test-shell
1125         https://bugs.webkit.org/show_bug.cgi?id=50701
1126
1127         * Scripts/webkitpy/common/config/ports.py:
1128         * Scripts/webkitpy/common/config/ports_unittest.py:
1129         * Scripts/webkitpy/layout_tests/port/chromium.py:
1130         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1131         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1132         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1133         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1134         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1135         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1136         * Scripts/webkitpy/layout_tests/port/webkit.py:
1137         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1138         * Scripts/webkitpy/style/checkers/test_expectations.py:
1139         * Scripts/webkitpy/tool/commands/queries.py:
1140
1141 2010-12-10  John Knottenbelt  <jknotten@chromium.org>
1142
1143         Reviewed by Steve Block.
1144
1145         [Chromium] Implement mocks for client-based geolocation
1146         https://bugs.webkit.org/show_bug.cgi?id=46895
1147
1148         * DumpRenderTree/chromium/LayoutTestController.cpp:
1149         (LayoutTestController::setGeolocationPermission):
1150         (LayoutTestController::setMockGeolocationPosition):
1151         (LayoutTestController::setMockGeolocationError):
1152         * DumpRenderTree/chromium/LayoutTestController.h:
1153         * DumpRenderTree/chromium/WebViewHost.cpp:
1154         (WebViewHost::geolocationClient):
1155         (WebViewHost::geolocationClientMock):
1156         (WebViewHost::reset):
1157         * DumpRenderTree/chromium/WebViewHost.h:
1158
1159 2010-12-10  Alejandro G. Castro  <alex@igalia.com>
1160
1161         Reviewed by Martin Robinson.
1162
1163         [GTK] Add hasSpellingMarker support to the DRT
1164         https://bugs.webkit.org/show_bug.cgi?id=50739
1165
1166         Implemented the hasSpellingMarker to support spelling tests.
1167
1168         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1169         (LayoutTestController::hasSpellingMarker):
1170
1171 2010-12-10  Eric Seidel  <eric@webkit.org>
1172
1173         Reviewed by Ojan Vafai.
1174
1175         webkit-patch: not possible to use build-and-test with local commits
1176         https://bugs.webkit.org/show_bug.cgi?id=33378
1177
1178         Make --no-clean not even check if we have local commits.
1179         It's unclear to me why the code was originally written this way.
1180         I was unable to dig up a reason from svn history.
1181
1182         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
1183         * Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py: Copied from WebKitTools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.
1184
1185 2010-12-10  Mario Sanchez Prada  <msanchez@igalia.com>
1186
1187         Reviewed by Martin Robinson.
1188
1189         [GTK] AX: implement isEnabled in DRT
1190         https://bugs.webkit.org/show_bug.cgi?id=50814
1191
1192         Implement AccessibilityUIElement::isEnabled() for GTK.
1193
1194         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1195         (checkElementState): New function to refactor common code.
1196         (AccessibilityUIElement::isEnabled): Implement this by checking
1197         the current state of the AtkObject.
1198         (AccessibilityUIElement::isSelected): Use the new
1199         checkElementState function.
1200
1201 2010-12-10  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
1202
1203         Reviewed by Kenneth Rohde Christiansen.
1204
1205         [Qt][WK2] Add the QWKContext API class to wrap the WebContext.
1206         https://bugs.webkit.org/show_bug.cgi?id=50750
1207
1208         * MiniBrowser/qt/BrowserView.cpp:
1209         (BrowserView::BrowserView):
1210         * MiniBrowser/qt/BrowserView.h:
1211         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1212         (WTR::WebView::WebView):
1213
1214 2010-12-10  Joone Hur  <joone@kldp.org>
1215
1216         Reviewed by Xan Lopez.
1217
1218         [GTK] Unskipping some test cases in userscripts dependent on addUserStyleSheet
1219         https://bugs.webkit.org/show_bug.cgi?id=50808
1220
1221         Unskipping the following test cases:
1222         userscripts/mixed-case-stylesheet.html
1223         userscripts/simple-stylesheet.html
1224         userscripts/user-style-all-frames.html
1225
1226         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1227         (LayoutTestController::addUserStyleSheet):
1228
1229 2010-12-10  Joone Hur  <joone@kldp.org>
1230
1231         Reviewed by Eric Seidel.
1232
1233         [GTK] Add DRT support for pageProperty, isPageBoxVisible, pageSizeAndMarginsInPixels, and addUserStyleSheet
1234         https://bugs.webkit.org/show_bug.cgi?id=50783
1235
1236         This patch allows to unskip the following test cases:
1237         printing/page-rule-selection.html
1238         printing/page-format-data.html
1239
1240         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1241         (LayoutTestController::pageProperty): Added.
1242         (LayoutTestController::isPageBoxVisible): Ditto.
1243         (LayoutTestController::pageSizeAndMarginsInPixels): Ditto.
1244         (LayoutTestController::addUserStyleSheet): Ditto.
1245
1246 2010-12-10  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
1247
1248         Reviewed by Kenneth Rohde Christiansen.
1249
1250         [Qt] Make QtTestBrowser spawn QNAM in a secondary thread.
1251
1252         A menu allows to switch QNAM back to the same thread.
1253
1254         * QtTestBrowser/launcherwindow.cpp:
1255         (LauncherWindow::initializeView):
1256         (LauncherWindow::createChrome):
1257         (LauncherWindow::toggleThreadedQnam):
1258         * QtTestBrowser/launcherwindow.h:
1259         (WindowOptions::WindowOptions):
1260         * QtTestBrowser/webpage.cpp:
1261         (WebPage::WebPage):
1262         (WebPage::setQnamThreaded):
1263         * QtTestBrowser/webpage.h:
1264         (QnamThread::QnamThread):
1265         (QnamThread::~QnamThread):
1266         (QnamThread::networkAccessManager):
1267         (QnamThread::run):
1268
1269 2010-12-10  Martin Robinson  <mrobinson@igalia.com>
1270
1271         Reviewed by Xan Lopez.
1272
1273         [Gtk] style="font-family: courier" makes text disappear
1274         https://bugs.webkit.org/show_bug.cgi?id=47452
1275
1276         Add a test that verifies that fonts without valid charmaps are
1277         never selected.
1278
1279         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1280         (initializeFonts): Initialize DRT with our font (derived from Ahem)
1281         that has no valid charmap.
1282         * DumpRenderTree/gtk/fonts/FontWithNoValidEncoding.fon: Added.
1283         * DumpRenderTree/gtk/fonts/fonts.conf: Updated settings to override users'
1284         settings which may disable selection of bitmap fonts.
1285
1286 2010-12-10  Eric Seidel  <eric@webkit.org>
1287
1288         Unreviewed.
1289
1290         The commit-queue should file bugs about flaky tests it encounters
1291         https://bugs.webkit.org/show_bug.cgi?id=50803
1292
1293         create_bug_for_flaky_test was insufficiently tested, thus buggy.
1294         Now it's tested.
1295
1296         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1297         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1298
1299 2010-12-10  Eric Seidel  <eric@webkit.org>
1300
1301         Unreviewed.  Somehow this last-minute edit didn't quite get committed.
1302
1303         The commit-queue should file bugs about flaky tests it encounters
1304         https://bugs.webkit.org/show_bug.cgi?id=50803
1305
1306         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1307
1308 2010-12-09  Eric Seidel  <eric@webkit.org>
1309
1310         Reviewed by Adam Barth.
1311
1312         The commit-queue should file bugs about flaky tests it encounters
1313         https://bugs.webkit.org/show_bug.cgi?id=50803
1314
1315         This change got a bit big.  I also added a new config.urls file
1316         because I needed to share the view_source_url code with committervalidator.py.
1317
1318         This adds a new class FlakyTestReporter which holds all the logic about
1319         reporting flaky tests to bugzilla.
1320
1321         Right now this code knows how to look up bugs for flaky tests.
1322         If it can't find a bug filed from the commit-queue, it will open a new
1323         one, ccing the relevant people and adding information about the failure.
1324
1325         It is not yet smart enough to chase down duplicate chains, or to include
1326         the actual failure diff.  But those can be added in later iterations.
1327
1328         * Scripts/webkitpy/common/checkout/api.py:
1329         * Scripts/webkitpy/common/checkout/changelog.py:
1330         * Scripts/webkitpy/common/checkout/commitinfo.py:
1331         * Scripts/webkitpy/common/config/committervalidator.py:
1332         * Scripts/webkitpy/common/config/urls.py: Copied from WebKitTools/Scripts/webkitpy/tool/comments.py.
1333         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1334         * Scripts/webkitpy/tool/bot/flakytestreporter.py: Added.
1335         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py: Copied from WebKitTools/Scripts/webkitpy/tool/comments.py.
1336         * Scripts/webkitpy/tool/bot/irc_command.py:
1337         * Scripts/webkitpy/tool/bot/sheriff.py:
1338         * Scripts/webkitpy/tool/commands/download.py:
1339         * Scripts/webkitpy/tool/commands/queues.py:
1340         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1341         * Scripts/webkitpy/tool/comments.py:
1342         * Scripts/webkitpy/tool/mocktool.py:
1343         * Scripts/webkitpy/tool/steps/commit.py:
1344
1345 2010-12-09  Eric Seidel  <eric@webkit.org>
1346
1347         Reviewed by Adam Barth.
1348
1349         Teach webkit-patch how to search bugzilla
1350         https://bugs.webkit.org/show_bug.cgi?id=50500
1351
1352         This is a step towards teaching webkitpy how to file
1353         new bugs for flaky tests and update them when new flakes occur.
1354
1355         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1356         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
1357         * Scripts/webkitpy/tool/commands/__init__.py:
1358         * Scripts/webkitpy/tool/commands/bugsearch.py: Added.
1359
1360 2010-12-09  Adam Barth  <abarth@webkit.org>
1361
1362         Reviewed by Ojan Vafai.
1363
1364         commit-queue errors out due to local commits
1365         https://bugs.webkit.org/show_bug.cgi?id=50766
1366
1367         We seem to be tripping over having local commits in the working copy a
1368         lot recently.  I don't quite fully understand what the issue is, but
1369         this patch attempts to solve the problem by adding an explicit clean
1370         step before processing a patch.  Previously, we did the cleaning as
1371         part of the apply-attachment step, so this might not actually fix the
1372         problem.
1373
1374         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1375         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1376         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1377
1378 2010-12-09  Dirk Pranke  <dpranke@chromium.org>
1379
1380         Reviewed by Ojan Vafai.
1381
1382         Make new-run-webkit-tests --lint-test-files log slightly better
1383         messages and return -1 if lint fails. Remove the
1384         'suppress_errors' keyword param to the TestExpectationsFile
1385         class, and clean up logging and exception raising for error
1386         handling. Also add more unit tests and clean up the unit test code a bit.
1387
1388         https://bugs.webkit.org/show_bug.cgi?id=50205
1389
1390         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1391         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1392         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py
1393         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py
1394         * Scripts/webkitpy/layout_tests/port/chromium.py:
1395         * Scripts/webkitpy/style/checkers/test_expectations.py:
1396         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1397
1398 2010-12-09  Tony Chang  <tony@chromium.org>
1399
1400         Unreviewed, fix for windows code.  We were catching the wrong
1401         exception in Windows.
1402
1403         * Scripts/webkitpy/common/system/filesystem.py:
1404
1405 2010-12-09  Antonio Gomes  <agomes@rim.com>
1406
1407         Reviewed by Martin Robinson.
1408
1409         [Gtk] Populate DumpRenderTreeSupportGtk (part IV)
1410         https://bugs.webkit.org/show_bug.cgi?id=48429
1411
1412         Adjust call sites of webkit_thread_count to use the DumpRenderTreeSupportGtk version now.
1413
1414         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1415         (LayoutTestController::workerThreadCount):
1416
1417 2010-12-06  Philippe Normand  <pnormand@igalia.com>
1418
1419         Reviewed by Martin Robinson.
1420
1421         [GTK] Support the Mozilla-style Fullscreen Javascript API
1422         https://bugs.webkit.org/show_bug.cgi?id=50572
1423
1424         Enable the Javascript Fullscreen support in the GtkLauncher. Also
1425         make DRT update the Chrome when the WebView settings have been
1426         reset to consistent values.
1427
1428         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1429         (resetDefaultsToConsistentValues):
1430         * GtkLauncher/main.c:
1431         (create_window):
1432         * Scripts/build-webkit:
1433
1434 2010-12-09  Koan-Sin Tan  <koansin.tan@gmail.com>
1435
1436         Reviewed by Tor Arne Vestbø
1437
1438         [Qt] run-launcher doesn't start the browser on Mac OS X 10.6
1439         https://bugs.webkit.org/show_bug.cgi?id=50742
1440
1441         check not only QtWebKit.framework/QtWebKit but also libQtWebKit.dylib
1442
1443         * Scripts/webkitdirs.pm:
1444
1445 2010-12-09  Joone Hur  <joone@kldp.org>
1446
1447          Reviewed by Martin Robinson.
1448
1449          [GTK] Support for viewport meta tag
1450          https://bugs.webkit.org/show_bug.cgi?id=45443
1451
1452          Add support for testing the viewport properties for WebKitGtk.
1453
1454          * DumpRenderTree/LayoutTestController.cpp:
1455          (dumpConfigurationForViewportCallback): Added this JS callback to set the size of the visible viewport.
1456          (LayoutTestController::staticFunctions):
1457          * DumpRenderTree/LayoutTestController.h:
1458          * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1459          (LayoutTestController::dumpConfigurationForViewport): Added this function to test the viewport properties.
1460          * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1461          (LayoutTestController::dumpConfigurationForViewport): Ditto.
1462          * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1463          (LayoutTestController::dumpConfigurationForViewport): Ditto.
1464          * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1465          (LayoutTestController::dumpConfigurationForViewport): Ditto.
1466          * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1467          (LayoutTestController::dumpConfigurationForViewport): Ditto.
1468
1469 2010-12-08  William Siegrist <wsiegrist@apple.com>
1470
1471         Reviewed by Eric Seidel.
1472
1473         Migrate buildbot.py from xmlrpc to json.
1474         https://bugs.webkit.org/show_bug.cgi?id=50647
1475
1476         * Scripts/webkitpy/common/net/buildbot.py:
1477
1478 2010-12-08  Tony Chang  <tony@chromium.org>
1479
1480         Reviewed by Eric Seidel.
1481
1482         make starting the websocket server more reliable on windows
1483         https://bugs.webkit.org/show_bug.cgi?id=50712
1484
1485         * Scripts/webkitpy/common/system/filesystem.py:
1486         (remove): Substitute method for os.remove to retry on error on Windows
1487         * Scripts/webkitpy/common/system/filesystem_unittest.py:
1488         * Scripts/webkitpy/layout_tests/port/http_server_base.py: Use FileSystem.remove
1489
1490 2010-12-08  Jessie Berlin  <jberlin@apple.com>
1491
1492         Reviewed by Adam Roben.
1493
1494         WebKit2: Implement WebChromeClient::exceededDatabaseQuota
1495         https://bugs.webkit.org/show_bug.cgi?id=50656
1496
1497         * MiniBrowser/mac/BrowserWindowController.m:
1498         (-[BrowserWindowController awakeFromNib]):
1499         Indicate that exceededDatabaseQuota is not implemented.
1500         * MiniBrowser/win/BrowserView.cpp:
1501         (BrowserView::create):
1502         Ditto.
1503         * WebKitTestRunner/TestController.cpp:
1504         (WTR::createOtherPage):
1505         Ditto.
1506         (WTR::TestController::initialize):
1507         Ditto.
1508
1509 2010-12-08  Antonio Gomes  <agomes@rim.com>
1510
1511         Reviewed by Martin Robinson.
1512
1513         [Gtk] Populate DumpRenderTreeSupportGtk (part III)
1514         https://bugs.webkit.org/show_bug.cgi?id=48429
1515
1516         Moved the following methods from webkitprivate.h to DumpRenderTreeSupportGtk.cpp|h:
1517         * webkit_gc_collect_javascript_objects;
1518         * webkit_gc_collect_javascript_objects_on_alternate_thread;
1519         * webkit_gc_count_javascript_objects;
1520         * webkit_web_frame_layout.
1521
1522         These were all only used by GTK+ DRT.
1523
1524         * DumpRenderTree/gtk/EventSender.cpp:
1525         (dispatchEvent):
1526         * DumpRenderTree/gtk/GCControllerGtk.cpp:
1527         (GCController::collect):
1528         (GCController::collectOnAlternateThread):
1529         (GCController::getJSObjectCount):
1530
1531 2010-12-07  Tony Chang  <tony@chromium.org>
1532
1533         Reviewed by Ojan Vafai.
1534
1535         [chromium] force NRWT to use DRT
1536         https://bugs.webkit.org/show_bug.cgi?id=50359
1537
1538         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1539
1540 2010-12-06  Sam Weinig  <sam@webkit.org>
1541
1542         Reviewed by Anders Carlsson.
1543
1544         Generalize didChangeLocationWithinPageForFrame for all same document navigations
1545         https://bugs.webkit.org/show_bug.cgi?id=50584
1546
1547         * MiniBrowser/mac/BrowserWindowController.m:
1548         (didSameDocumentNavigationForFrame):
1549         (-[BrowserWindowController awakeFromNib]):
1550         (-[BrowserWindowController didSameDocumentNavigationForFrame:]):
1551         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
1552         (TestWebKitAPI::didSameDocumentNavigationForFrame):
1553         (TestWebKitAPI::TEST):
1554         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1555         (WTR::InjectedBundlePage::InjectedBundlePage):
1556         (WTR::InjectedBundlePage::didSameDocumentNavigationForFrame):
1557         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1558         * WebKitTestRunner/TestController.cpp:
1559         (WTR::TestController::initialize):
1560
1561 2010-12-06  Kinuko Yasuda  <kinuko@chromium.org>
1562
1563         Reviewed by Ojan Vafai.
1564
1565         Make TestResultsServer return 404 for non-existing results files.
1566         https://bugs.webkit.org/show_bug.cgi?id=50581
1567
1568         * TestResultServer/handlers/testfilehandler.py:
1569
1570 2010-12-06  Tony Chang  <tony@chromium.org>
1571
1572         Reviewed by Ojan Vafai.
1573
1574         [chromium] fix an assert hit in DRT
1575         https://bugs.webkit.org/show_bug.cgi?id=50575
1576
1577         This class uses WTF's RefPtr, but expects chrome's base::RefPtr
1578         semantics.
1579
1580         Otherwise, we hit ASSERTION FAILED: !m_adoptionIsRequired
1581         (third_party/WebKit/JavaScriptCore/wtf/RefCounted.h:37 void
1582         WTF::RefCountedBase::ref()).
1583
1584         * DumpRenderTree/chromium/TestWebWorker.h:
1585         (TestWebWorker::TestWebWorker):
1586
1587 2010-12-02  Ojan Vafai  <ojan@chromium.org>
1588
1589         Reviewed by Eric Seidel.
1590
1591         make webkit-patch command work when the git branch is not synced to the remote svn branch
1592         https://bugs.webkit.org/show_bug.cgi?id=50424
1593
1594         * Scripts/webkitpy/common/checkout/scm.py:
1595         * Scripts/webkitpy/common/checkout/scm_unittest.py:
1596
1597 2010-12-06  Patrick Gansterer  <paroga@webkit.org>
1598
1599         Reviewed by Andreas Kling.
1600
1601         [WINCE] Add build system
1602         https://bugs.webkit.org/show_bug.cgi?id=50522
1603
1604         * CMakeListsWinCE.txt: Added.
1605
1606 2010-12-03  Mihai Parparita  <mihaip@chromium.org>
1607
1608         Reviewed by Tony Chang.
1609
1610         Allow the Chromium port to have Leopard-specific baselines
1611         https://bugs.webkit.org/show_bug.cgi?id=50506
1612
1613         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1614
1615 2010-12-03  Tony Chang  <tony@chromium.org>
1616
1617         Reviewed by Kent Tamura.
1618
1619         [chromium] fix 2 bugs with inspector tests in DRT
1620         https://bugs.webkit.org/show_bug.cgi?id=50492
1621
1622         Tasks can outlive the tasklist (even when canceled) so this was
1623         causing a crash when ~WebTask() ran.  Avoid this by unregistering
1624         when a task is canceled.
1625
1626         Also fix an assert when closing devtool windows by copying some
1627         logic from test_shell.
1628
1629         * DumpRenderTree/chromium/Task.cpp:
1630         (WebTask::~WebTask):
1631         (TaskList::revokeAll):
1632         * DumpRenderTree/chromium/Task.h: Canceling a task now removes it from
1633             the tasklist (since the task can outlive the tasklist).
1634         * DumpRenderTree/chromium/TestShell.h:
1635         (TestShell::devToolsWebView):
1636         * DumpRenderTree/chromium/WebViewHost.cpp:
1637         (WebViewHost::~WebViewHost): Don't load about:blank when closing
1638             a window if the window has devtools loaded.  This avoids an
1639             ASSERT and matches test_shell.
1640
1641 2010-12-06  Alejandro G. Castro  <alex@igalia.com>
1642
1643         Reviewed by Martin Robinson.
1644
1645         [GTK] Fix GtkLauncher.c style, use webkit style
1646         https://bugs.webkit.org/show_bug.cgi?id=50542
1647
1648         * GtkLauncher/main.c:
1649         (activateUriEntryCb):
1650         (updateTitle):
1651         (linkHoverCb):
1652         (notifyTitleCb):
1653         (notifyLoadStatusCb):
1654         (notifyProgressCb):
1655         (destroyCb):
1656         (goBackCb):
1657         (goForwardCb):
1658         (create_webViewCb):
1659         (webViewReadyCb):
1660         (closeWebViewCb):
1661         (createBrowser):
1662         (createStatusbar):
1663         (createToolbar):
1664         (createWindow):
1665         (main):
1666
1667 2010-12-04  Antonio Gomes  <agomes@rim.com>
1668
1669         Reviewed by Martin Robinson.
1670
1671         [Gtk] Populate DumpRenderTreeSupportGtk (Part II)
1672         https://bugs.webkit.org/show_bug.cgi?id=48429
1673
1674         Moved more private method declared with WEBKIT_API to
1675         DumpRenderTreeSupportGtk, since they were only being used by DRT.
1676
1677         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1678         (resetDefaultsToConsistentValues):
1679         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1680         (LayoutTestController::addOriginAccessWhitelistEntry):
1681         (LayoutTestController::execCommand):
1682         (LayoutTestController::isCommandEnabled):
1683
1684 2010-12-04  Antonio Gomes  <agomes@rim.com>
1685
1686         Reviewed by Andreas Kling.
1687
1688         Removed extern webkit_web_view_set_group_name from gtk/DumpRenderTree.cpp
1689
1690         Method was removed by http://trac.webkit.org/changeset/71604
1691
1692         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1693
1694 2010-12-05  Alejandro G. Castro  <alex@igalia.com>
1695
1696         Reviewed by Xan Lopez.
1697
1698         [GTK] Fix compilation warnings reported by clang
1699         https://bugs.webkit.org/show_bug.cgi?id=50252
1700
1701         * GtkLauncher/main.c:
1702         (create_window): The create_statusbar function does not have
1703         parameters.
1704
1705 2010-12-05  Robert Hogan  <robert@webkit.org>
1706
1707         Reviewed by Andreas Kling.
1708
1709         [Qt] Zero-sized font does not yet work
1710
1711         Fix fast/text/font-size-zero.html
1712
1713         Copy other ports by setting minimumFontSize to 0 for DRT runs.
1714
1715         https://bugs.webkit.org/show_bug.cgi?id=49759
1716
1717         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1718         (WebCore::WebPage::WebPage):
1719
1720 2010-12-04  Sam Weinig  <sam@webkit.org>
1721
1722         Reviewed by Jon Honeycutt.
1723
1724         WebKit2: Need client functions to notify app when the url changes due to a fragment navigation
1725         https://bugs.webkit.org/show_bug.cgi?id=50511
1726
1727         Update tools for new didChangeLocationWithinPageForFrame client function (and changed bundle
1728         signature) and added a test for the functionality (PageLoadDidChangeLocationWithinPageForFrame.cpp)
1729
1730         * MiniBrowser/mac/BrowserWindowController.m:
1731         (didChangeLocationWithinPageForFrame):
1732         (-[BrowserWindowController awakeFromNib]):
1733         (-[BrowserWindowController didChangeLocationWithinPageForFrame:]):
1734         * TestWebKitAPI/PlatformUtilities.cpp:
1735         (TestWebKitAPI::Util::toWK):
1736         * TestWebKitAPI/PlatformUtilities.h:
1737         (TestWebKitAPI::Util::adoptWK):
1738         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1739         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp: Added.
1740         (TestWebKitAPI::nullJavaScriptCallback):
1741         (TestWebKitAPI::didFinishLoadForFrame):
1742         (TestWebKitAPI::didChangeLocationWithinPageForFrame):
1743         (TestWebKitAPI::TEST):
1744         * TestWebKitAPI/Tests/WebKit2/file-with-anchor.html: Added.
1745         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1746         * TestWebKitAPI/win/copy-resources.cmd:
1747         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1748         (WTR::InjectedBundlePage::InjectedBundlePage):
1749         (WTR::InjectedBundlePage::didChangeLocationWithinPageForFrame):
1750         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1751         * WebKitTestRunner/TestController.cpp:
1752         (WTR::TestController::initialize):
1753
1754 2010-11-08  Antonio Gomes  <agomes@rim.com>
1755
1756         Reviewed by Martin Robinson.
1757
1758         [Gtk] Populate DumpRenderTreeSupportGtk
1759         https://bugs.webkit.org/show_bug.cgi?id=48429
1760
1761         Made the previous calls to webkit_web_frame* functions defined as private
1762         APIs in webkitprivate.h go through DRTSupportGtk.
1763
1764         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
1765         (AccessibilityController::focusedElement):
1766         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1767         (dumpFramesAsText):
1768         (resetDefaultsToConsistentValues):
1769         (dump):
1770         (webViewDocumentLoadFinished):
1771         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1772         (LayoutTestController::counterValueForElementById):
1773         (LayoutTestController::pageNumberForElementById):
1774         (LayoutTestController::numberOfPages):
1775         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
1776         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
1777         (LayoutTestController::sampleSVGAnimationForElementAtTime):
1778         (LayoutTestController::numberOfActiveAnimations):
1779         (LayoutTestController::suspendAnimations):
1780         (LayoutTestController::resumeAnimations):
1781         (LayoutTestController::markerTextForListItem):
1782
1783 2010-12-03  Mihai Parparita  <mihaip@chromium.org>
1784
1785         Reviewed by Tony Chang.
1786
1787         Rebaseline server: use pretty text diff output
1788         https://bugs.webkit.org/show_bug.cgi?id=50484
1789         
1790         Serve *-pretty-diff.html for text diff output.
1791
1792         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
1793         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
1794         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
1795         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
1796
1797 2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
1798
1799         Unreviewed, rolling out r73302.
1800         http://trac.webkit.org/changeset/73302
1801         https://bugs.webkit.org/show_bug.cgi?id=50499
1802
1803         Causes crashes in debug LayoutTests (Requested by xan_ on
1804         #webkit).
1805
1806         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
1807         (AccessibilityUIElement::AccessibilityUIElement):
1808         (AccessibilityUIElement::parentElementCallback):
1809         * DumpRenderTree/chromium/AccessibilityUIElement.h:
1810         * DumpRenderTree/chromium/CppBoundClass.cpp:
1811         * DumpRenderTree/chromium/CppBoundClass.h:
1812
1813 2010-12-03  Sam Weinig  <sam@webkit.org>
1814
1815         Reviewed by Maciej Stachowiak.
1816
1817         Enable <a ping> for Mac/Windows/WebKit2 builds
1818         <rdar://problem/8504473>
1819         https://bugs.webkit.org/show_bug.cgi?id=50488
1820
1821         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
1822         (TestWebKitAPI::TEST): Test that the default value of
1823         WKPreferencesGetHyperlinkAuditingEnabled is true.
1824
1825 2010-12-03  Chris Guillory  <chris.guillory@google.com>
1826
1827         Reviewed by Chris Fleizach.
1828
1829         Include the FrameView widget of a RenderWidget in the accessibility tree.
1830         https://bugs.webkit.org/show_bug.cgi?id=49106
1831
1832         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
1833         (AccessibilityUIElement::AccessibilityUIElement):
1834         (AccessibilityUIElement::parentElementCallback):
1835         (AccessibilityUIElement::isEqualCallback):
1836         * DumpRenderTree/chromium/AccessibilityUIElement.h:
1837         * DumpRenderTree/chromium/CppBoundClass.cpp:
1838         (CppBoundClass::getFromCppVariant):
1839         * DumpRenderTree/chromium/CppBoundClass.h:
1840
1841 2010-12-03  Mihai Parparita  <mihaip@chromium.org>
1842
1843         Reviewed by Tony Chang.
1844
1845         Rebaseline server: organize tests by state, add dry run mode
1846         https://bugs.webkit.org/show_bug.cgi?id=50473
1847         
1848         Group tests in the menu by state, so that it's easier to see after
1849         processing the queue which failed.
1850         
1851         Add support for the --dry-run flag so that it's easier to test changes
1852         such as this (stubs out filesystem and SCM operations).
1853
1854         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
1855         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js:
1856         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
1857
1858 2010-12-03  Brady Eidson  <beidson@apple.com>
1859
1860         Reviewed by Anders Carlsson.
1861
1862         Groundwork for <rdar://problem/7660733> and https://bugs.webkit.org/show_bug.cgi?id=50191
1863         WebKit2 Authentication Support
1864
1865         Keep these builds working:
1866         * MiniBrowser/mac/BrowserWindowController.m:
1867         (-[BrowserWindowController awakeFromNib]):
1868
1869         * WebKitTestRunner/TestController.cpp:
1870         (WTR::TestController::initialize):
1871
1872 2010-12-02  Mihai Parparita  <mihaip@chromium.org>
1873
1874         Reviewed by Tony Chang.
1875
1876         Rebaseline server: move existing baselines
1877         https://bugs.webkit.org/show_bug.cgi?id=50421
1878         
1879         Implement moving of existing baselines: move all files that are about
1880         to be overwriten by update baselines.
1881         
1882         Also fix a typo in the UI JS.
1883
1884         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js:
1885         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
1886         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py:
1887
1888 2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
1889
1890         Unreviewed, rolling out r73211.
1891         http://trac.webkit.org/changeset/73211
1892         https://bugs.webkit.org/show_bug.cgi?id=50450
1893
1894         Broke Chromium's "Webkit Win (dbg)(2)" bot. (Requested by
1895         yutak on #webkit).
1896
1897         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1898
1899 2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
1900
1901         Unreviewed, rolling out r73222.
1902         http://trac.webkit.org/changeset/73222
1903         https://bugs.webkit.org/show_bug.cgi?id=50449
1904
1905         r73211 seemed to break Chromium's "Webkit Win (dbg)(2)" bot.
1906         (Requested by yutak on #webkit).
1907
1908         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1909         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
1910         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
1911         * Scripts/webkitpy/layout_tests/port/base.py:
1912         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1913         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1914
1915 2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
1916
1917         Unreviewed, rolling out r73228.
1918         http://trac.webkit.org/changeset/73228
1919         https://bugs.webkit.org/show_bug.cgi?id=50448
1920
1921         r73211 seemed to break Chromium's "Webkit Win (dbg)(2)" bot.
1922         (Requested by yutak on #webkit).
1923
1924         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1925         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
1926         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
1927         * Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py:
1928         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
1929
1930 2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
1931
1932         Unreviewed, rolling out r73231.
1933         http://trac.webkit.org/changeset/73231
1934         https://bugs.webkit.org/show_bug.cgi?id=50443
1935
1936         r73211 seemed to broke Chromium's "Webkit Win (dbg)(2)" bot.
1937         (Requested by yutak on #webkit).
1938
1939         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
1940         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
1941         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1942         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1943
1944 2010-12-03  David Levin  <levin@chromium.org>
1945
1946         Reviewed by Shinichiro Hamaji.
1947
1948         check-webkit-style: false positive reported for #if macro
1949         https://bugs.webkit.org/show_bug.cgi?id=48242
1950
1951         * Scripts/webkitpy/style/checkers/cpp.py: Adjusted check to avoid
1952           all preprocessor commands.
1953         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added test.
1954
1955 2010-12-02  Eric Seidel  <eric@webkit.org>
1956
1957         Reviewed by Adam Barth.
1958
1959         Update the EWSTools scripts to use modern-style git repos
1960         https://bugs.webkit.org/show_bug.cgi?id=50402
1961
1962         * EWSTools/create-webkit-git:
1963         * EWSTools/start-commit-queue.sh:
1964         * EWSTools/start-queue.sh:
1965
1966 2010-12-02  Simon Fraser  <simon.fraser@apple.com>
1967
1968         Fix Chromium Linux plugin tests by not logging
1969         unconditionally from the event handling code.
1970
1971         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1972         (handleEventX11):
1973
1974 2010-12-02  Dirk Pranke  <dpranke@chromium.org>
1975
1976         Reviewed by Tony Chang.
1977
1978         nrwt multiprocessing - move logic back into run_webkit_tests
1979
1980         This change moves a bunch of logic that I had put into
1981         message_broker back into run_webkit_tests, in a slightly
1982         different format. WorkerMessageBroker needed to become less aware of
1983         the logic the TestRunner class uses, and more generic.
1984         Eventually the MessageBroker will only do generic messaging and
1985         thread/process-pooling, and (almost) all of the
1986         run-webkit-tests-specific logic will be moved to
1987         run_webkit_tests.py and dump_render_tree_thread.py.
1988         
1989         The biggest changes are that the Broker can now start a single
1990         worker, but the responsibility for starting all of them is pushed
1991         back to the TestRunner (Manager), and the logic for checking if
1992         the threads are done or wedged is moved back to TestRunner. We
1993         also remove WorkerMessageBroker.cleanup (not needed) and
1994         cancel_workers (they have to be cancelled individually).
1995         
1996         The  message_broker is now encapsulated inside
1997         TestRunner._run_tests(); it only needs to exist while actually
1998         running the tests.
1999
2000         Also, delete a bunch of tests in message_broker_unittest that no
2001         longer make much sense.
2002
2003         This patch depends on bug 50372.
2004
2005         https://bugs.webkit.org/show_bug.cgi?id=50374
2006
2007         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2008         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
2009         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
2010         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2011         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2012
2013 2010-12-02  Hayato Ito  <hayato@chromium.org>
2014
2015         Reviewed by Eric Seidel.
2016
2017         Refactor test_types's compare_output() method so that it takes a
2018         TestInput object.
2019
2020         compare_output() will need additional information included in a TestInput
2021         object to support reftests. This change is a pre-requirement of that.
2022
2023         https://bugs.webkit.org/show_bug.cgi?id=50362
2024
2025         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2026         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
2027         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
2028         * Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py:
2029         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
2030
2031 2010-12-02  Simon Fraser  <simon.fraser@apple.com>
2032
2033         Reviewed by Anders Carlsson.
2034
2035         Add the ability to run script on 'new' and 'paint' in the test plugin
2036         https://bugs.webkit.org/show_bug.cgi?id=50425
2037         
2038         Add "onnew" and "onpaintevent" attributes to the test plugin,
2039         so that tests can run JS at these times.
2040
2041         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
2042         (pluginAllocate):
2043         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
2044         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2045         (NPP_New):
2046         (NPP_Destroy):
2047         (handleEventCarbon):
2048         (handleEventCocoa):
2049         (NPP_HandleEvent):
2050
2051 2010-12-02  Sam Weinig  <sam@webkit.org>
2052
2053         Fix Qt build.
2054
2055         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2056         (WTR::PlatformWebView::PlatformWebView):
2057
2058 2010-12-02  Sam Weinig  <sam@webkit.org>
2059
2060         Reviewed by Anders Carlsson.
2061
2062         WebKit2 Preferences should be held off the PageGroup, not the Context
2063         https://bugs.webkit.org/show_bug.cgi?id=50414
2064
2065         Update for API changes.
2066
2067         * WebKitTestRunner/PlatformWebView.h:
2068         * WebKitTestRunner/TestController.cpp:
2069         (WTR::createOtherPage):
2070         (WTR::TestController::initialize):
2071         (WTR::TestController::resetStateToConsistentValues):
2072         * WebKitTestRunner/TestController.h:
2073         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2074         (WTR::PlatformWebView::PlatformWebView):
2075         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2076         (WTR::PlatformWebView::PlatformWebView):
2077
2078 2010-12-02  Dirk Pranke  <dpranke@chromium.org>
2079
2080         Reviewed by Tony Chang.
2081
2082         new-run-webkit-tests: minor cleanup for multiprocessing work
2083
2084         This change:
2085         * moves worker naming into TestShellThread, eliminating a
2086           parameter to the constructor and putting the responsibility in
2087           the correct place.
2088         * eliminates the _WorkerState() class in message_broker, because
2089           it turns out that state really needs to be in run_webkit_tests
2090         * renames the Broker classes to be module-private.
2091         * fixes a bunch of minor commenting and whitespace issues to
2092           make subsequent patches a bit clearer.
2093         * Adds a Port hook for default_worker_model() so that we can
2094           accomodate the potential for different worker models on
2095           different ports.
2096         * merge in the fix from 50420 for the brokenness introduced in
2097           bug 50367.
2098
2099         This patch depends on bug 50367.
2100
2101         https://bugs.webkit.org/show_bug.cgi?id=50372
2102
2103         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2104         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
2105         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
2106         * Scripts/webkitpy/layout_tests/port/base.py:
2107         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2108         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2109
2110 2010-12-02  Dirk Pranke  <dpranke@chromium.org>
2111
2112         Reviewed by Tony Chang.
2113
2114         This change is a bunch of cleanup / refactoring of the file
2115         below. It moves a bunch of free functions to methods on the
2116         TestShellThread class, and restructures other methods to be
2117         closer to the structure we'll need for the multiprocessing
2118         rewrite.
2119
2120         It also makes the logic of --run-singly a *lot* easier to follow
2121         by nestling all of the separate-thread logic into a single
2122         routine.
2123
2124         There should be no semantic changes in this patch, just cleanup.
2125
2126         https://bugs.webkit.org/show_bug.cgi?id=50367
2127
2128         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2129
2130 2010-12-02  Tony Chang  <tony@chromium.org>
2131
2132         Unreviewed, rolling out r73164.
2133         http://trac.webkit.org/changeset/73164
2134         https://bugs.webkit.org/show_bug.cgi?id=50359
2135
2136         broke debugger tests on win
2137
2138         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2139
2140 2010-11-30  Mihai Parparita  <mihaip@chromium.org>
2141
2142         Reviewed by Tony Chang.
2143
2144         Rebaseline server: add updating of baselines
2145         https://bugs.webkit.org/show_bug.cgi?id=50305
2146         
2147         Implements updating of baselines, where we copy -actual.* files over
2148         the current -expected.* files. To do this, we need a
2149         _get_actual_result_files method to get test results files and a
2150         _rebaseline_test method to actually do the file copy and SCM operation.
2151         _rebaseline_test logs output into a buffer, this is useful for both
2152         showing result in the UI and for unit tests.
2153         
2154         To make passing around of the various test environment properties
2155         (results directory, filesystem, SCM, etc) easier, add a TestConfig
2156         class for them.
2157         
2158         Moving of existing baselines is not implemented yet, this patch is big
2159         enough as it is.
2160
2161         * Scripts/webkitpy/common/system/filesystem.py:
2162         * Scripts/webkitpy/common/system/filesystem_mock.py:
2163         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js:
2164         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
2165         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py:
2166         * Scripts/webkitpy/tool/mocktool.py:
2167
2168 2010-12-02  Brent Fulgham  <bfulgham@webkit.org>
2169
2170         Unreviewed build fix after vcproj updates.
2171
2172         * DumpRenderTree/win/DumpRenderTreeCairo.vsprops: Make sure
2173         that WIN_CAIRO is defined for this build.
2174         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd: Update file
2175         to reflect new 'Debug_Cairo_CFLite' and 'Release_Cairo_CFLite'
2176         (these were previously 'Debug_Cairo' and 'Release_Cairo'
2177
2178 2010-12-02  Sam Weinig  <sam@webkit.org>
2179
2180         Reviewed by Anders Carlsson.
2181
2182         WebKit2 needs API to turn on popup blocking
2183         https://bugs.webkit.org/show_bug.cgi?id=50407
2184
2185         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
2186         (TestWebKitAPI::TEST):
2187         * WebKitTestRunner/TestController.cpp:
2188         (WTR::TestController::resetStateToConsistentValues):
2189
2190 2010-12-01  Tony Chang  <tony@chromium.org>
2191
2192         Reviewed by Ojan Vafai.
2193
2194         [chromium] force NRWT to use DRT
2195         https://bugs.webkit.org/show_bug.cgi?id=50359
2196
2197         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2198
2199 2010-12-02  Martin Robinson  <mrobinson@igalia.com>
2200
2201         Reviewed by Xan Lopez.
2202
2203         [GTK] DumpRenderTree has two copies of JavaScriptCore
2204         https://bugs.webkit.org/show_bug.cgi?id=49877
2205
2206         * GNUmakefile.am: Remove the second copy of JavaScriptCore from the
2207         LDADD list for DumpRenderTree.
2208
2209 2010-12-02  Sergio Villar Senin  <svillar@igalia.com>
2210
2211         Unreviewed: Added myself to list of Committers.
2212
2213         * Scripts/webkitpy/common/config/committers.py:
2214
2215 2010-12-01  Mihai Parparita  <mihaip@chromium.org>
2216
2217         Reviewed by Adam Barth.
2218
2219         build-webkit --chromium always updates DEPS and re-generates project files
2220         https://bugs.webkit.org/show_bug.cgi?id=50340
2221         
2222         Make build-webkit --chromium invoke update-webkit-chromium only when
2223         --update-chromium is passed in, so that we don't add 20 seconds to all
2224         builds.
2225         
2226         Making all invocations update was added with r61883, with the goal of
2227         making EWS bots always update. The bots will switch to using this flag
2228         (as will all other webkit-patch build steps) so nothing should change
2229         for them.
2230
2231         * Scripts/webkitdirs.pm:
2232         * Scripts/webkitpy/common/config/ports.py:
2233         * Scripts/webkitpy/common/config/ports_unittest.py:
2234
2235 2010-12-01  Dirk Pranke  <dpranke@chromium.org>
2236
2237         Reviewed by Tony Chang.
2238
2239         new-run-webkit-tests: add a --dry-run / -n flag
2240         https://bugs.webkit.org/show_bug.cgi?id=50045
2241
2242         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2243         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2244
2245 2010-12-01  Steve Falkenburg  <sfalken@apple.com>
2246
2247         Reviewed by Adam Roben.
2248
2249         WinCairo build should not use link-time code generation (LTCG)
2250         https://bugs.webkit.org/show_bug.cgi?id=50353
2251
2252         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2253         * DumpRenderTree/win/DumpRenderTree.vcproj:
2254         * DumpRenderTree/win/ImageDiff.vcproj:
2255         * FindSafari/FindSafari.vcproj:
2256         * MiniBrowser/MiniBrowser.vcproj:
2257         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2258         * WebKitAPITest/WebKitAPITest.vcproj:
2259         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
2260         * WebKitTestRunner/win/InjectedBundle.vcproj:
2261         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
2262         * WinLauncher/WinLauncher.vcproj:
2263         * record-memory-win/record-memory-win.vcproj:
2264
2265 2010-12-01  Martin Robinson  <mrobinson@igalia.com>
2266
2267         Touch GetUserAgentWithNullNPPFromNPPNew.cpp in an effort to force
2268         a rebuild of TestNetscapePlugin.la on GTK+. It seems that simply
2269         adding the file to the sources list was not enough to force the rebuild.
2270
2271         * DumpRenderTree/TestNetscapePlugIn/Tests/GetUserAgentWithNullNPPFromNPPNew.cpp:
2272         Remove an empty line at the end of this file to force a rebuild.
2273
2274 2010-12-01  Sam Weinig  <sam@webkit.org>
2275
2276         Fix windows build.
2277
2278         * MiniBrowser/win/BrowserView.cpp:
2279         (BrowserView::create):
2280
2281 2010-12-01  Martin Robinson  <mrobinson@igalia.com>
2282
2283         Add missing file to the TestNetscapePlugin sources list after r73057.
2284
2285         * GNUmakefile.am: Add missing file.
2286
2287 2010-12-01  Sam Weinig  <sam@webkit.org>
2288
2289         Reviewed by Anders Carlsson.
2290
2291         Add PageGrouping to WebKit2 API
2292         https://bugs.webkit.org/show_bug.cgi?id=50332
2293
2294         - Update testing harnesses to deal with new PageGroup API.
2295
2296         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
2297         (WKBundleInitialize):
2298         * TestWebKitAPI/InjectedBundleController.cpp:
2299         (TestWebKitAPI::InjectedBundleController::initialize):
2300         (TestWebKitAPI::InjectedBundleController::didInitializePageGroup):
2301         (TestWebKitAPI::InjectedBundleController::initializeTestNamed):
2302         * TestWebKitAPI/InjectedBundleController.h:
2303         * TestWebKitAPI/InjectedBundleTest.h:
2304         (TestWebKitAPI::InjectedBundleTest::initialize):
2305         (TestWebKitAPI::InjectedBundleTest::didInitializePageGroup):
2306         * TestWebKitAPI/PlatformUtilities.cpp:
2307         (TestWebKitAPI::Util::createContextForInjectedBundleTest):
2308         * TestWebKitAPI/PlatformUtilities.h:
2309         * TestWebKitAPI/PlatformWebView.h:
2310         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
2311         (TestWebKitAPI::TEST):
2312         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp:
2313         (TestWebKitAPI::DocumentStartUserScriptAlertCrashTest::initialize):
2314         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
2315         (TestWebKitAPI::PlatformWebView::PlatformWebView):
2316         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
2317         (TestWebKitAPI::PlatformWebView::PlatformWebView):
2318         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2319         (WTR::InjectedBundle::didInitializePageGroup):
2320         (WTR::InjectedBundle::initialize):
2321         (WTR::InjectedBundle::beginTesting):
2322         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2323         (WTR::InjectedBundle::pageGroup):
2324         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2325         (WTR::LayoutTestController::addUserScript):
2326         (WTR::LayoutTestController::addUserStyleSheet):
2327         (WTR::LayoutTestController::setXSSAuditorEnabled):
2328         * WebKitTestRunner/TestController.cpp:
2329         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2330         (WTR::PlatformWebView::PlatformWebView):
2331
2332 2010-12-01  Steve Falkenburg  <sfalken@apple.com>
2333
2334         Reviewed by Adam Roben.
2335
2336         vcproj changes can't be applied cleanly by the Windows EWS bot
2337         https://bugs.webkit.org/show_bug.cgi?id=50328
2338
2339         * CLWrapper/CLWrapper.sln: Modified property svn:eol-style.
2340         * CLWrapper/CLWrapper.vcproj: Modified property svn:eol-style.
2341         * DumpRenderTree/DumpRenderTree.sln: Modified property svn:eol-style.
2342         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops: Added property svn:eol-style.
2343         * DumpRenderTree/win/DumpRenderTree.vcproj: Modified property svn:eol-style.
2344         * DumpRenderTree/win/DumpRenderTreeApple.vsprops: Added property svn:eol-style.
2345         * DumpRenderTree/win/DumpRenderTreeCFLite.vsprops: Added property svn:eol-style.
2346         * DumpRenderTree/win/DumpRenderTreeCairo.vsprops: Added property svn:eol-style.
2347         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops: Added property svn:eol-style.
2348         * DumpRenderTree/win/ImageDiff.vcproj: Modified property svn:eol-style.
2349         * DumpRenderTree/win/ImageDiffCommon.vsprops: Added property svn:eol-style.
2350         * FindSafari/FindSafari.vcproj: Modified property svn:eol-style.
2351         * FindSafari/FindSafariCommon.vsprops: Added property svn:eol-style.
2352         * MIDLWrapper/MIDLWrapper.sln: Modified property svn:eol-style.
2353         * MIDLWrapper/MIDLWrapper.vcproj: Modified property svn:eol-style.
2354         * MiniBrowser/Configurations/MiniBrowserCFLite.vsprops: Added property svn:eol-style.
2355         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops: Added property svn:eol-style.
2356         * MiniBrowser/Configurations/MiniBrowserCoreFoundation.vsprops: Added property svn:eol-style.
2357         * MiniBrowser/MiniBrowser.vcproj: Added property svn:eol-style.
2358         * TestWebKitAPI/Configurations/TestWebKitAPICFLite.vsprops: Added property svn:eol-style.
2359         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops: Added property svn:eol-style.
2360         * TestWebKitAPI/Configurations/TestWebKitAPICoreFoundation.vsprops: Added property svn:eol-style.
2361         * TestWebKitAPI/win/TestWebKitAPI.sln: Added property svn:eol-style.
2362         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Added property svn:eol-style.
2363         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj: Added property svn:eol-style.
2364         * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops: Added property svn:eol-style.
2365         * WebKitAPITest/WebKitAPITest.vcproj: Added property svn:eol-style.
2366         * WebKitAPITest/WebKitAPITestCommon.vsprops: Added property svn:eol-style.
2367         * WebKitLauncherWin/WebKitLauncherWin.vcproj: Modified property svn:eol-style.
2368         * WebKitLauncherWin/WebKitLauncherWinCommon.vsprops: Added property svn:eol-style.
2369         * WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops: Added property svn:eol-style.
2370         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops: Added property svn:eol-style.
2371         * WebKitTestRunner/Configurations/InjectedBundleCoreFoundation.vsprops: Added property svn:eol-style.
2372         * WebKitTestRunner/Configurations/WebKitTestRunnerCFLite.vsprops: Added property svn:eol-style.
2373         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops: Added property svn:eol-style.
2374         * WebKitTestRunner/Configurations/WebKitTestRunnerCoreFoundation.vsprops: Added property svn:eol-style.
2375         * WebKitTestRunner/WebKitTestRunner.sln: Added property svn:eol-style.
2376         * WebKitTestRunner/win/InjectedBundle.vcproj: Added property svn:eol-style.
2377         * WebKitTestRunner/win/InjectedBundleGenerated.vcproj: Added property svn:eol-style.
2378         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops: Added property svn:eol-style.
2379         * WebKitTestRunner/win/WebKitTestRunner.vcproj: Added property svn:eol-style.
2380         * WinLauncher/WinLauncher.vcproj: Modified property svn:eol-style.
2381         * WinLauncher/WinLauncherCommon.vsprops: Added property svn:eol-style.
2382         * record-memory-win/record-memory-win-common.vsprops: Added property svn:eol-style.
2383         * record-memory-win/record-memory-win.vcproj: Modified property svn:eol-style.
2384
2385 2010-12-01  Anders Carlsson  <andersca@apple.com>
2386
2387         Reviewed by Darin Adler.
2388
2389         Return a correct user agent if NPN_UserAgent is called with a null NPP from NPP_New.
2390         https://bugs.webkit.org/show_bug.cgi?id=50336
2391
2392         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2393         Add new test.
2394
2395         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
2396         (PluginTest::NPP_New):
2397         Add default implementation/
2398
2399         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
2400         * DumpRenderTree/TestNetscapePlugIn/Tests/GetUserAgentWithNullNPPFromNPPNew.cpp: Added.
2401         (GetUserAgentWithNullNPPFromNPPNew::GetUserAgentWithNullNPPFromNPPNew):
2402         (GetUserAgentWithNullNPPFromNPPNew::NPP_New):
2403         Get the user agent.
2404
2405         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2406         (NPP_New):
2407         Call PluginTest::NPP_New.
2408
2409         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
2410         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2411         Add new files.
2412
2413         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2414         (webkit_test_plugin_new_instance):
2415         Call PluginTest::NPP_New.
2416
2417 2010-12-01  Kevin Ollivier  <kevino@theolliviers.com>
2418
2419         [wx] Build fixes after recent trunk changes.
2420
2421         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2422         (LayoutTestController::findString):
2423         * wx/build/settings.py:
2424
2425 2010-12-01  Dan Bernstein  <mitz@apple.com>
2426
2427         Reviewed by Darin Adler.
2428
2429         WebKitTestRunner needs layoutTestController.findString
2430         https://bugs.webkit.org/show_bug.cgi?id=50238
2431
2432         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Added findString().
2433         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2434         (WTR::LayoutTestController::findString): Updated signature for autogenerated bindings.
2435         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Ditto.
2436
2437 2010-12-01  Steve Falkenburg  <sfalken@apple.com>
2438
2439         Try using svn:eol-style native on a vcproj file.
2440
2441         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Modified property svn:eol-style.
2442
2443 2010-12-01  Patrick Gansterer  <paroga@webkit.org>
2444
2445         Reviewed by Adam Roben.
2446
2447         [WINCE] Add WinCELauncher
2448         https://bugs.webkit.org/show_bug.cgi?id=50217
2449
2450         * WinCELauncher/main.cpp: Added.
2451
2452 2010-11-30  Benjamin Poulain  <benjamin.poulain@nokia.com>
2453
2454         Reviewed by Kenneth Rohde Christiansen.
2455
2456         [Qt] Implement layoutTestController.findString
2457         https://bugs.webkit.org/show_bug.cgi?id=50236
2458
2459         Add the missing function to the LayoutTestController.
2460
2461         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2462         (LayoutTestController::findString):
2463         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2464
2465 2010-11-30  Tony Chang  <tony@chromium.org>
2466
2467         Reviewed by Adam Barth.
2468
2469         [chromium] fix get-int-identifier-special-values.html using TestNetscapePlugIn
2470         https://bugs.webkit.org/show_bug.cgi?id=49036
2471
2472         * DumpRenderTree/chromium/LayoutTestController.cpp: Use IsNumber instead of IsInt32
2473             for CppVariants.
2474         (LayoutTestController::cppVariantToBool):
2475         (LayoutTestController::cppVariantToInt32):
2476         (LayoutTestController::setDatabaseQuota):
2477         (LayoutTestController::evaluateInWebInspector):
2478         (LayoutTestController::setMockGeolocationError):
2479
2480 2010-11-30  Eric Seidel  <eric@webkit.org>
2481
2482         Reviewed by Tony Chang.
2483
2484         update-webkit should call git fetch before git svn rebase
2485         https://bugs.webkit.org/show_bug.cgi?id=50273
2486
2487         After discussion on webkit-dev, we've decided to move the "default"
2488         git setup to pulling updates from git.webkit.org in preference
2489         to rebuilding the local svn index using git svn fetch every time.
2490
2491         This change should have no effect on people using the "old" git setup
2492         and should dramatically increase the speed of updates for those using
2493         the "new" git setup along with update-webkit.  I'm about to move the
2494         EWS and other queues over to this setup once this lands.
2495
2496         * Scripts/update-webkit:
2497
2498 2010-11-30  Mario Sanchez Prada  <msanchez@igalia.com>
2499
2500         Reviewed by Xan Lopez.
2501
2502         GTK: AX: implement press in DRT
2503         https://bugs.webkit.org/show_bug.cgi?id=36146
2504
2505         Implement AccessibilityUIElement::press() for GTK.
2506
2507         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2508         (AccessibilityUIElement::press): Implemented.
2509
2510 2010-11-29  Mihai Parparita  <mihaip@chromium.org>
2511
2512         Reviewed by Tony Chang.
2513
2514         config.webkit_base_dir returns a path with a trailing slash
2515         https://bugs.webkit.org/show_bug.cgi?id=50197
2516         
2517         config.webkit_base_dir() should return a path without a trailing slash,
2518         like all the other methods that return paths.
2519         
2520         Undoes MockFileSytem changes by r72640, since they're no longer
2521         necessary for GetBaselinesTest to pass.
2522
2523         * Scripts/webkitpy/common/system/filesystem_mock.py:
2524         * Scripts/webkitpy/layout_tests/port/base.py:
2525         * Scripts/webkitpy/layout_tests/port/config.py:
2526         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
2527
2528 2010-11-30  Mihai Parparita  <mihaip@chromium.org>
2529
2530         Reviewed by Tony Chang.
2531
2532         Rebaseline server: baseline display tweaks
2533         https://bugs.webkit.org/show_bug.cgi?id=50207
2534         
2535         Determine which baselines were used when running the tests and highlight
2536         them in the UI. Sort platform names alphabetically.
2537         
2538         Also makes the server URL be launched in the user's browser
2539         automatically.
2540
2541         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
2542         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
2543         * Scripts/webkitpy/tool/commands/data/rebaselineserver/util.js:
2544         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
2545         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py:
2546
2547 2010-11-30  Dan Bernstein  <mitz@apple.com>
2548
2549         Reviewed by Anders Carlsson.
2550
2551         <rdar://problem/8710645> WebKitTestRunner needs layoutTestController.findString
2552         https://bugs.webkit.org/show_bug.cgi?id=50238
2553
2554         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2555         (WTR::LayoutTestController::findString): Added.
2556         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2557
2558 2010-11-30  Steve Falkenburg  <sfalken@apple.com>
2559
2560         Reviewed by Adam Roben.
2561
2562         All projects on Windows should use cmd files for build events
2563         https://bugs.webkit.org/show_bug.cgi?id=50213
2564
2565         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops:
2566         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd: Added.
2567         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd: Added.
2568         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
2569         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd: Added.
2570         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd: Added.
2571         * DumpRenderTree/win/ImageDiffCommon.vsprops:
2572         * DumpRenderTree/win/ImageDiffPostBuild.cmd: Added.
2573         * DumpRenderTree/win/ImageDiffPreBuild.cmd: Added.
2574         * MiniBrowser/Configurations/MiniBrowserCFLite.vsprops:
2575         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
2576         * MiniBrowser/Configurations/MiniBrowserCoreFoundation.vsprops:
2577         * MiniBrowser/MiniBrowserPostBuild.cmd: Added.
2578         * MiniBrowser/MiniBrowserPreBuild.cmd: Added.
2579         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
2580         * TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd: Added.
2581         * TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd: Added.
2582         * WebKitAPITest/WebKitAPITestCommon.vsprops:
2583         * WebKitAPITest/WebKitAPITestPostBuild.cmd: Added.
2584         * WebKitAPITest/WebKitAPITestPreBuild.cmd: Added.
2585         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
2586         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
2587         * WebKitTestRunner/win/InjectedBundlePostBuild.cmd: Added.
2588         * WebKitTestRunner/win/InjectedBundlePreBuild.cmd: Added.
2589         * WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd: Added.
2590         * WebKitTestRunner/win/WebKitTestRunnerPreBuild.cmd: Added.
2591         * WinLauncher/WinLauncherCommon.vsprops:
2592         * WinLauncher/WinLauncherPostBuild.cmd: Added.
2593         * WinLauncher/WinLauncherPreBuild.cmd: Added.
2594
2595 2010-11-29  Dan Bernstein  <mitz@apple.com>
2596
2597         GTK DumpRenderTree build fix after r72887.
2598
2599         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2600         (LayoutTestController::findString):
2601
2602 2010-11-29  Dan Bernstein  <mitz@apple.com>
2603
2604         Windows DumpRenderTree build fix after r72887.
2605
2606         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2607         (LayoutTestController::findString): Added empty implementation.
2608
2609 2010-11-29  Dan Bernstein  <mitz@apple.com>
2610
2611         Reviewed by Darin Adler.
2612
2613         DumpRenderTree changes for testing the text search API.
2614         https://bugs.webkit.org/show_bug.cgi?id=50038
2615
2616         * DumpRenderTree/LayoutTestController.cpp:
2617         (findStringCallback):
2618         (LayoutTestController::staticFunctions):
2619         * DumpRenderTree/LayoutTestController.h:
2620         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2621         (LayoutTestController::findString):
2622         * MiniBrowser/mac/BrowserWindowController.m:
2623         (-[BrowserWindowController find:]):
2624
2625 2010-11-29  Johnny Ding  <jnd@chromium.org>
2626
2627         Unreviewed: Add myself to the list of Committers.
2628
2629         * Scripts/webkitpy/common/config/committers.py:
2630
2631 2010-11-29  Mark Rowe  <mrowe@apple.com>
2632
2633         Reviewed by Adele Peterson.
2634
2635         <rdar://problem/8694997> DumpRenderTree fails to build.
2636
2637         * DumpRenderTree/mac/PerlSupport/Makefile: Skip generating wrappers.
2638
2639 2010-11-29  Mark Rowe  <mrowe@apple.com>
2640
2641         Reviewed by Adele Peterson.
2642
2643         <rdar://problem/8694997> DumpRenderTree fails to build.
2644
2645         * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupportPregenerated.pm: Renamed from WebKitTools/DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupportTiger.pm.
2646         * DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport_wrapPregenerated.c: Renamed from WebKitTools/DumpRenderTree/mac/PerlSupport/DumpRenderTreeSupport_wrapTiger.c.
2647         * DumpRenderTree/mac/PerlSupport/Makefile:
2648
2649 2010-11-29  Mario Sanchez Prada  <msanchez@igalia.com>
2650
2651         Reviewed by Martin Robinson.
2652
2653         [GTK] Null-check needed in DRT's AccessibilityUIElement::allAtributes()
2654         https://bugs.webkit.org/show_bug.cgi?id=50154
2655
2656         Added missing checks to allAttributes().
2657
2658         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2659         (AccessibilityUIElement::allAttributes): Added missing checks.
2660
2661 2010-11-29  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2662
2663         Reviewed by Kenneth Rohde Christiansen.
2664
2665         [Qt] Allow pre-generation for package builds for WebKit2
2666         https://bugs.webkit.org/show_bug.cgi?id=50139
2667
2668         Use a build variable for the generated directory path and set the
2669         value based on CONFIG just like for WebKit1.
2670
2671         For non-package builds use a relative base path for the
2672         genrated directory just like for WebKit1.
2673
2674         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2675         * WebKitTestRunner/qt/WebKitTestRunner.pro:
2676
2677 2010-11-28  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2678
2679         Reviewed by Kenneth Rohde Christiansen.
2680
2681         [Qt] Move some build logic from Qt to platform independent code
2682         https://bugs.webkit.org/show_bug.cgi?id=50134
2683
2684         Create target directories inside generate-forwarding-headers.pl.
2685
2686         * Scripts/generate-forwarding-headers.pl:
2687
2688 2010-11-24  Nicolas Dufresne  <nicolas.dufresne@collabora.co.uk>
2689
2690         Reviewed by Martin Robinson.
2691
2692         [GTK] Windowless plugins gets broken key input
2693         https://bugs.webkit.org/show_bug.cgi?id=49927
2694
2695         Convert the XEvent::keycode to ASCII before printing it. Not
2696         doing this was causing false positive in 
2697         plugins/keyboard-events.html.
2698
2699         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
2700         (keycode_to_char):
2701         (webkit_test_plugin_handle_event):
2702
2703 2010-11-24  Jan Erik Hanssen  <jhanssen@sencha.com>
2704
2705         Reviewed by Antonio Gomes.
2706
2707         [Qt] Html autofocus not working with QGraphicsWebView
2708         https://bugs.webkit.org/show_bug.cgi?id=43169
2709
2710         Tell the scene to set the webview item as the currently
2711         focused item. This makes the input field with autofocus get
2712         focus as it should.
2713
2714         * QtTestBrowser/webview.cpp:
2715         (WebViewGraphicsBased::WebViewGraphicsBased):
2716
2717 2010-11-24  Dirk Pranke  <dpranke@chromium.org>
2718
2719         Reviewed by Tony Chang.
2720
2721         nrwt - clean up create_driver interface and print out the
2722         command line used for DumpRenderTree/TestShell.
2723
2724         This patch adds a driver_cmd_line() call to the Port class in
2725         order to retrive the command line to print it out (as part of
2726         --print config).
2727
2728         In addition, this patch cleans up the Port.create_driver()
2729         signature and the Driver constructor interface to take a worker
2730         number and no longer require the image_path argument (Chromium's
2731         drivers now synthesize the image_path from the worker number
2732         internally).
2733
2734         https://bugs.webkit.org/show_bug.cgi?id=49934
2735
2736         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2737         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
2738         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2739         * Scripts/webkitpy/layout_tests/port/base.py:
2740         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2741         * Scripts/webkitpy/layout_tests/port/chromium.py:
2742         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2743         * Scripts/webkitpy/layout_tests/port/dryrun.py:
2744         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2745         * Scripts/webkitpy/layout_tests/port/test.py:
2746         * Scripts/webkitpy/layout_tests/port/webkit.py:
2747         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2748         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2749
2750 2010-11-24  Ojan Vafai  <ojan@chromium.org>
2751
2752         Reviewed by Tony Chang.
2753
2754         [chromium] improve memory usage for test results server and store fewer runs
2755         https://bugs.webkit.org/show_bug.cgi?id=50035
2756
2757         Store fewer runs and don't pass full files around when we only need bools.
2758         Greatly improves error rates on test-results.appspot.com.
2759
2760         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2761         * TestResultServer/handlers/testfilehandler.py:
2762         * TestResultServer/model/dashboardfile.py:
2763         * TestResultServer/model/jsonresults.py:
2764
2765 2010-11-24  Dirk Pranke  <dpranke@chromium.org>
2766
2767         Reviewed by Tony Chang.
2768
2769         This patch implements the first part of the manager side of the
2770         Broker objects - it handles creating threads, waiting for them
2771         to complete, and running a single-threaded loop as well.
2772
2773         https://bugs.webkit.org/show_bug.cgi?id=49779
2774
2775         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
2776         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
2777         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2778         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2779
2780 2010-11-24  Mihai Parparita  <mihaip@chromium.org>
2781
2782         Reviewed by David Levin.
2783
2784         DRT should not generate pixel output for text/plain tests
2785         https://bugs.webkit.org/show_bug.cgi?id=50002
2786         
2787         Modify Mac, Windows and GTK DRT implementations to disable pixel output
2788         when encountering a text/plain response (the Chromium one already does
2789         this, and none of the other ports special-case text/plain output in
2790         the first place).
2791
2792         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2793         (dump):
2794         * DumpRenderTree/mac/DumpRenderTree.mm:
2795         (dump):
2796         * DumpRenderTree/win/DumpRenderTree.cpp:
2797         (dump):
2798
2799 2010-11-24  Andras Becsi  <abecsi@inf.u-szeged.hu>
2800
2801         Unreviewed.
2802
2803         Add my other email address to committers.py.
2804
2805         * Scripts/webkitpy/common/config/committers.py:
2806
2807 2010-11-24  Andras Becsi  <abecsi@inf.u-szeged.hu>
2808
2809         Reviewed by Csaba Osztrogonác.
2810
2811         Make build-webkit --minimal build with ENABLE_INSPECTOR=0
2812         https://bugs.webkit.org/show_bug.cgi?id=49975
2813
2814         * Scripts/build-webkit: Add ENABLE_INSPECTOR define to features,
2815         to enable the script to define it 0 in case of a minimal build.
2816
2817 2010-11-24  Martin Robinson  <mrobinson@igalia.com>
2818
2819         Reviewed by Xan Lopez.
2820
2821         [GTK] The WebKitWebView should expose a set of signals encapsulating the behavior of the EditorClient
2822         https://bugs.webkit.org/show_bug.cgi?id=49143
2823
2824         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2825         (createWebView): Call the new connectEditingCallbacks function.
2826         * DumpRenderTree/gtk/EditingCallbacks.cpp: Added.
2827         (dumpNodePath):
2828         (dumpRange):
2829         (insertActionString):
2830         (selectionAffinityString):
2831         (shouldBeginEditing):
2832         (shouldEndEditing):
2833         (shouldInsertNode):
2834         (shouldInsertText):
2835         (shouldDeleteRange):
2836         (shouldShowDeleteInterfaceForElement):
2837         (shouldChangeSelectedRange):
2838         (shouldApplyStyle):
2839         (editingBegan):
2840         (userChangedContents):
2841         (editingEnded):
2842         (selectionChanged):
2843         (connectEditingCallbacks):
2844         * DumpRenderTree/gtk/EditingCallbacks.h: Added.
2845         * GNUmakefile.am: Added EditingCallbacks.{h,cpp} to the source list.
2846
2847 2010-11-24  Yi Shen  <yi.4.shen@nokia.com>
2848
2849         Reviewed by Andreas Kling.
2850
2851         [Qt] Make QtTestBrowser remember the selected user agent
2852         https://bugs.webkit.org/show_bug.cgi?id=50021
2853
2854         Set user agent for a new page by using the old page's
2855
2856         * QtTestBrowser/mainwindow.cpp:
2857         (MainWindow::setPage):
2858
2859 2010-11-24 Patrick Gansterer <paroga@webkit.org>
2860
2861         Reviewed by Csaba Osztrogonác.
2862
2863         Remove Bakefile build system files
2864         https://bugs.webkit.org/show_bug.cgi?id=49983
2865
2866         r53757 only removed the content, but not the files.
2867         This patch removes that empty files.
2868
2869         * DumpRenderTree/wx/DumpRenderTree.bkl: Removed.
2870         * wx/browser/browser.bkl: Removed.
2871         * wx/build-wxwebkit: Removed.
2872
2873 2010-11-23  Dirk Pranke  <dpranke@chromium.org>
2874
2875         Reviewed by Tony Chang.
2876
2877         This patch cleans up the logic used to shard tests into groups a
2878         bit and adds the --worker-model flag to NRWT. The flag is only
2879         used at the moment to control whether to run single-threaded or
2880         not, but eventually will also allow toggling between threads and
2881         processes.
2882
2883         Also add a minor cleanup with _test_is_slow(), which just
2884         eliminates some repetition and gives slightly better encapsulation.
2885
2886         https://bugs.webkit.org/show_bug.cgi?id=49773
2887
2888         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2889         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2890
2891 2010-11-23  Mihai Parparita  <mihaip@chromium.org>
2892
2893         Reviewed by Tony Chang.
2894
2895         Rebaseline server: list current baselines and platforms
2896         https://bugs.webkit.org/show_bug.cgi?id=49991
2897         
2898         List existing baselines (with Trac links) for tests.
2899         
2900         Add dropdowns for choosing with platform baselines to target (and what
2901         to do with existing ones).
2902
2903         Also fix MockFileSystem.join to behave more like os.path.join (unit
2904         test was ending up with two consecutive slashes in a layout test
2905         path).        
2906
2907         * Scripts/webkitpy/common/system/filesystem_mock.py:
2908         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
2909         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
2910         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
2911         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js:
2912         * Scripts/webkitpy/tool/commands/data/rebaselineserver/util.js:
2913         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
2914         * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py: Added.
2915
2916 2010-11-23  Ojan Vafai  <ojan@chromium.org>
2917
2918         Reviewed by Tony Chang.
2919
2920         remove timeout argument to urlopen
2921         https://bugs.webkit.org/show_bug.cgi?id=49995
2922
2923         Apparently the version of python we have on the bots doesn't accept a timeout argument.
2924
2925         * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py:
2926
2927 2010-11-23  Sheriff Bot  <webkit.review.bot@gmail.com>
2928
2929         Unreviewed, rolling out r72628.
2930         http://trac.webkit.org/changeset/72628
2931         https://bugs.webkit.org/show_bug.cgi?id=49994
2932
2933         This patch is causing layout-test failtures on GTK Linux
2934         64-bit Debug (Requested by ctguil on #webkit).
2935
2936         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
2937         (AccessibilityUIElement::AccessibilityUIElement):
2938         (AccessibilityUIElement::parentElementCallback):
2939         * DumpRenderTree/chromium/AccessibilityUIElement.h:
2940         * DumpRenderTree/chromium/CppBoundClass.cpp:
2941         * DumpRenderTree/chromium/CppBoundClass.h:
2942
2943 2010-11-22  Ojan Vafai  <ojan@chromium.org>
2944
2945         Reviewed by Tony Chang.
2946
2947         speculative fix for upload errors: stop using mechanize to upload to test-results.appspot.com
2948         https://bugs.webkit.org/show_bug.cgi?id=49944
2949
2950         * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py:
2951
2952 2010-11-23  Chris Guillory  <chris.guillory@google.com>
2953
2954         Reviewed by Dimitri Glazkov.
2955
2956         Include the FrameView widget of a RenderWidget in the accessibility tree.
2957         https://bugs.webkit.org/show_bug.cgi?id=49106
2958
2959         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
2960         (AccessibilityUIElement::AccessibilityUIElement):
2961         (AccessibilityUIElement::parentElementCallback):
2962         (AccessibilityUIElement::isEqualCallback):
2963         * DumpRenderTree/chromium/AccessibilityUIElement.h:
2964         * DumpRenderTree/chromium/CppBoundClass.cpp:
2965         (CppBoundClass::getFromCppVariant):
2966         * DumpRenderTree/chromium/CppBoundClass.h:
2967
2968 2010-11-23  Alex Grilo  <abgrilo@profusion.mobi>
2969
2970         Reviewed by Kenneth Rohde Christiansen.
2971
2972         [EFL] Add tiled backing store to EWebLauncher
2973         https://bugs.webkit.org/show_bug.cgi?id=45777
2974
2975         Allow EWebLauncher to choose between single and tiled backing store
2976
2977         * EWebLauncher/main.c:
2978         (on_key_down):
2979         (browserCreate):
2980         (main):
2981
2982 2010-11-23  Simon Hausmann  <simon.hausmann@nokia.com>
2983
2984         Reviewed by Tor Arne Vestbø.
2985
2986         [Qt] Review the setUserPermission & friends API
2987         https://bugs.webkit.org/show_bug.cgi?id=46810
2988
2989         Renamed requestPermissionFromUser to featurePermissionRequested
2990         and cancelRequestsForPermission to featurePermissionRequestCanceled.
2991
2992         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2993         (WebCore::WebPage::WebPage):
2994         * QtTestBrowser/webpage.cpp:
2995         (WebPage::WebPage):
2996         (WebPage::featurePermissionRequestCanceled):
2997         * QtTestBrowser/webpage.h:
2998
2999 2010-11-23  Simon Hausmann  <simon.hausmann@nokia.com>
3000
3001         Reviewed by Tor Arne Vestbø.
3002
3003         [Qt] Review the setUserPermission & friends API
3004         https://bugs.webkit.org/show_bug.cgi?id=46810
3005
3006         Rename setUserPermission to setFeaturePermission
3007
3008         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3009         (WebCore::WebPage::requestPermission):
3010         (WebCore::WebPage::permissionSet):
3011         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3012         (LayoutTestController::grantDesktopNotificationPermission):
3013         * QtTestBrowser/webpage.cpp:
3014         (WebPage::requestPermission):
3015
3016 2010-11-23  Simon Hausmann  <simon.hausmann@nokia.com>
3017
3018         Reviewed by Tor Arne Vestbø.
3019
3020         [Qt] Review the setUserPermission & friends API
3021         https://bugs.webkit.org/show_bug.cgi?id=46810
3022
3023         Rename PermissionDomain to Feature, NotificationsPermissionDomain to Notifications
3024         and GeolocationPermissionDomain to Geolocation.
3025
3026         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3027         (WebCore::WebPage::WebPage):
3028         (WebCore::WebPage::requestPermission):
3029         (WebCore::WebPage::cancelPermission):
3030         (WebCore::WebPage::permissionSet):
3031         (WebCore::DumpRenderTree::geolocationPermissionSet):
3032         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3033         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3034         (LayoutTestController::grantDesktopNotificationPermission):
3035         * QtTestBrowser/webpage.cpp:
3036         (WebPage::WebPage):
3037         (WebPage::requestPermission):
3038         (WebPage::cancelRequestsForPermission):
3039         * QtTestBrowser/webpage.h:
3040
3041 2010-11-23  Simon Hausmann  <simon.hausmann@nokia.com>
3042
3043         Reviewed by Tor Arne Vestbø.
3044
3045         [Qt] Review the setUserPermission & friends API
3046         https://bugs.webkit.org/show_bug.cgi?id=46810
3047
3048         Add a ByUser suffix to PermissionGranted/Denied. In the future
3049         we can add PermissionGrantedByDefault.
3050
3051
3052         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3053         (WebCore::WebPage::requestPermission):
3054         (WebCore::WebPage::permissionSet):
3055         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3056         (LayoutTestController::grantDesktopNotificationPermission):
3057         * QtTestBrowser/webpage.cpp:
3058         (WebPage::requestPermission):
3059
3060 2010-11-18  Satish Sampath  <satish@chromium.org>
3061
3062         Reviewed by Jeremy Orlow.
3063
3064         For speech input event, send an event object containing all the recognition results and metadata.
3065         https://bugs.webkit.org/show_bug.cgi?id=49736
3066
3067         Updated DRT by renaming the mock result method on all platforms to the new signature.
3068
3069         * DumpRenderTree/LayoutTestController.cpp:
3070         (addMockSpeechInputResultCallback):
3071         (LayoutTestController::staticFunctions):
3072         * DumpRenderTree/LayoutTestController.h:
3073         * DumpRenderTree/chromium/LayoutTestController.cpp:
3074         (LayoutTestController::LayoutTestController):
3075         (LayoutTestController::addMockSpeechInputResult):
3076         * DumpRenderTree/chromium/LayoutTestController.h:
3077         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3078         (LayoutTestController::addMockSpeechInputResult):
3079         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3080         (LayoutTestController::addMockSpeechInputResult):
3081         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3082         (LayoutTestController::addMockSpeechInputResult):
3083         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3084         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3085         (LayoutTestController::addMockSpeechInputResult):
3086         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3087         (LayoutTestController::addMockSpeechInputResult):
3088
3089 2010-11-22  Dirk Pranke  <dpranke@chromium.org>
3090
3091         Reviewed by Tony Chang.
3092
3093         Fix some spacing issues with log messages with
3094         new-run-webkit-tests --verbose.
3095
3096         https://bugs.webkit.org/show_bug.cgi?id=49936
3097
3098         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
3099
3100 2010-11-22  Ojan Vafai  <ojan@chromium.org>
3101
3102         Reviewed by Adam Barth.
3103
3104         update scm to work with different remote branches
3105         https://bugs.webkit.org/show_bug.cgi?id=49949
3106
3107         This works if there are multiple svn tracking branches
3108         and/or if the tracking branch is refs/remots/origin/master
3109         instead of refs/remotes/trunk which is the direction we're trying
3110         to head since that makes fetches faster.
3111
3112         * Scripts/webkitpy/common/checkout/scm.py:
3113         * Scripts/webkitpy/common/checkout/scm_unittest.py:
3114
3115 2010-11-22  Hayato Ito  <hayato@chromium.org>
3116
3117         Reviewed by Shinichiro Hamaji.
3118
3119         Ignore reference files which will be used by reftests when collecting
3120         test cases.
3121         https://bugs.webkit.org/show_bug.cgi?id=49835
3122
3123         * Scripts/webkitpy/layout_tests/port/test_files.py:
3124         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
3125
3126 2010-11-22  Adam Roben  <aroben@apple.com>
3127
3128         Use paths relative to $WebKitVSPropsRedirectionDir to access shared .vsprops files
3129
3130         Apple's Windows build allows placing header files and import libraries for WebKit's
3131         dependencies (CoreGraphics, CFNetwork, SQLite, etc.) outside the source tree via the
3132         $WebKitLibrariesDir environment variable. This is both required for production builds and
3133         convenient for Apple-internal developer builds. Apple's production builds also require that
3134         WebKit's shared .vsprops files be accessed relative to $WebKitLibrariesDir. In production
3135         builds, the files are copied into that directory tree by the
3136         WebKitLibraries/win/tools/WinTools.make file. In Apple-internal developer builds, the
3137         copying is done by
3138         JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make.
3139
3140         This .vsprops copying is problematic in one very important case: when a developer updates
3141         their source tree and then tries to build. Visual Studio only reads .vsprops files when a
3142         project is first loaded. So, when Visual Studio is first opened after the .vsprops files are
3143         updated, it reads in the old files that were already residing in $WebKitLibrariesDir. When a
3144         build is started, JavaScriptCoreGenerated.make copies the new .vsprops files into
3145         $WebKitLibrariesDir, but Visual Studio will not pick up the changes.  The rest of the build
3146         will proceed with out-of-date .vsprops files, which will likely result in a build failure.
3147
3148         To fix this, we now use normal relative paths to access the .vsprops files in the source
3149         tree rather than in $WebKitLibrariesDir, but prefix those paths with a new environment
3150         variable, $WebKitVSPropsRedirectionDir. In developer builds, this environment variable is
3151         unset, so the normal relative paths are used to read the .vsprops files out of the source
3152         tree directly. In production builds, this environment variable is set to a fake directory
3153         that will cause the .vsprops files in $WebKitLibrariesDir to be found when the relative path
3154         is resolved.
3155         
3156         For example, JavaScriptCore.vcproj uses this path for FeatureDefines.vsprops:
3157
3158         $(WebKitVSPropsRedirectionDir)..\..\..\WebKitLibraries\win\tools\vsprops\FeatureDefines.vsprops
3159
3160         In developer builds, where $WebKitVSPropsRedirectionDir is unset, this will point to the
3161         files in WebKitLibraries\win\tools\vsprops in the source tree. In production builds,
3162         JavaScriptCore.make sets $WebKitVSPropsRedirectionDir to
3163         "$(SRCROOT)\AppleInternal\tools\vsprops\OpenSource\1\2\3\", so the full path for
3164         FeatureDefines.vsprops becomes:
3165
3166         $(SRCROOT)\AppleInternal\tools\vsprops\OpenSource\1\2\3\..\..\..\WebKitLibraries\win\tools\vsprops\FeatureDefines.vsprops
3167
3168         which resolves to:
3169
3170         $(SRCROOT)\AppleInternal\tools\vsprops\OpenSource\WebKitLibraries\win\tools\vsprops\FeatureDefines.vsprops
3171
3172         (We rely on the fact that Windows doesn't care whether the directories "1", "2", and "3"
3173         actually exist since they are matched by an equal number of ".." path components.)
3174
3175         Note that Visual Studio still won't pick up changes made to .vsprops files while Visual
3176         Studio is open, but that problem hasn't seemed to cause developers many headaches so far.
3177
3178         Fixes <http://webkit.org/b/49181> Windows build fails mysteriously when .vsprops files are
3179         updated
3180
3181         Reviewed by Dave Hyatt.
3182
3183         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3184         * DumpRenderTree/win/DumpRenderTree.vcproj:
3185         * DumpRenderTree/win/ImageDiff.vcproj:
3186         * FindSafari/FindSafari.vcproj:
3187         * MiniBrowser/MiniBrowser.vcproj:
3188         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3189         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj:
3190         * WebKitAPITest/WebKitAPITest.vcproj:
3191         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
3192         * WebKitTestRunner/win/InjectedBundle.vcproj:
3193         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
3194         * WinLauncher/WinLauncher.vcproj:
3195         * record-memory-win/record-memory-win.vcproj:
3196         Changed to use paths relative to $WebKitVSPropsRedirectionDir to access shared .vsprops
3197         files.
3198
3199 2010-11-22  Adam Roben  <aroben@apple.com>
3200
3201         Make it possible to run tests on Windows without Visual Studio or VC++
3202         Express installed
3203
3204         webkitdir.pm::setupCygwinEnv dies when Visual Studio and VC++ Express
3205         are not installed. But this function doesn't need to be called when we
3206         already have a build available and are just trying to run the tests.
3207
3208         Fixes <http://webkit.org/b/49932> New Windows 7 bot can't run tests
3209         because Visual Studio/VC++ Express aren't installed
3210
3211         Reviewed by Dave Hyatt.
3212
3213         * Scripts/webkitdirs.pm:
3214         (determineConfigurationForVisualStudio): Don't call setupCygwinEnv, as
3215         it is not needed by this function. Also added a FIXME.
3216
3217         (usingVisualStudioExpress): Call setupCygwinEnv directly rather than
3218         relying on determineConfigurationForVisualStudio doing it.
3219
3220 2010-11-19  Hayato Ito  <hayato@chromium.org>
3221
3222         Reviewed by Shinichiro Hamaji.
3223
3224         Simplify Driver.run_test() so that it takes only one parameter, TestInput.
3225
3226         https://bugs.webkit.org/show_bug.cgi?id=49812
3227
3228         * Scripts/webkitpy/layout_tests/driver_test.py:
3229         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3230         * Scripts/webkitpy/layout_tests/port/base.py:
3231         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3232         * Scripts/webkitpy/layout_tests/port/chromium.py:
3233         * Scripts/webkitpy/layout_tests/port/dryrun.py:
3234         * Scripts/webkitpy/layout_tests/port/test.py:
3235         * Scripts/webkitpy/layout_tests/port/webkit.py:
3236         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3237         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3238
3239 2010-11-22  Hayato Ito  <hayato@chromium.org>
3240
3241         Reviewed by Tony Chang.
3242
3243         [NRWT] Retry a few times in reading a png image to avoid a race condition.
3244
3245         https://bugs.webkit.org/show_bug.cgi?id=49924
3246
3247         * Scripts/webkitpy/layout_tests/port/chromium.py:
3248
3249 2010-11-22  João Paulo Rechi Vita  <jprvita@profusion.mobi>
3250
3251         Reviewed by Kenneth Rohde Christiansen.
3252
3253         Fix EWebLauncher zoom discretization
3254         https://bugs.webkit.org/show_bug.cgi?id=49810
3255
3256         * EWebLauncher/main.c:
3257         (nearest_zoom_level_get):
3258         (zoom_level_set):
3259         (on_load_finished):
3260         (on_key_down):
3261
3262 2010-11-21  Sam Weinig  <sam@webkit.org>
3263
3264         Rubber-stamped by Dan Bernstein.
3265
3266         Fix ~300 WebKit2 tests by enabling developer extras preference.
3267
3268         * WebKitTestRunner/TestController.cpp:
3269         (WTR::TestController::resetStateToConsistentValues):
3270
3271 2010-11-21  Sam Weinig  <sam@webkit.org>
3272
3273         Reviewed by Dan Bernstein.
3274
3275         Textareas should be resizable by default
3276         https://bugs.webkit.org/show_bug.cgi?id=49892
3277
3278         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3279         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp: Added.
3280         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3281         Add preferences test.
3282
3283 2010-11-19  Mihai Parparita  <mihaip@chromium.org>
3284
3285         Reviewed by Tony Chang.
3286
3287         Rebaseline server: checksum-only differences and prefetching
3288         https://bugs.webkit.org/show_bug.cgi?id=49841
3289         
3290         Add support for image test results where the only difference is in the
3291         checksum.
3292         
3293         Add prefetching of the image results from the next test.
3294         
3295         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
3296         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
3297         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
3298
3299 2010-11-19  Dirk Pranke  <dpranke@chromium.org>
3300
3301         Reviewed by Tony Chang.
3302
3303         nrwt multiprocessing - add 'worker number' concept, move stuff to worker thread
3304
3305         Add the 'worker number' and 'worker name' concepts to the 
3306         TestShellThread objects, and move test_types and test_args from
3307         the TestRunner to the TestShellThread.
3308
3309         https://bugs.webkit.org/show_bug.cgi?id=49768
3310
3311         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3312         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3313
3314 2010-11-19  Dirk Pranke  <dpranke@chromium.org>
3315
3316         Reviewed by Ojan Vafai.
3317
3318         Do some minor cleanup and bug fixing.
3319
3320         https://bugs.webkit.org/show_bug.cgi?id=49777
3321
3322         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3323         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3324
3325 2010-11-19  Dirk Pranke  <dpranke@chromium.org>
3326
3327         Reviewed by Ojan Vafai.
3328
3329         nrwt - config.build_directory() is busted
3330
3331         Fixes a typo that was causing us to usually return the top level
3332         directory WebKitBuild instead of WebKitBuild/{Debug,Release}. The
3333         bug was hidden by test stubs that were too simplistic :(.
3334
3335         https://bugs.webkit.org/show_bug.cgi?id=49815
3336
3337         * Scripts/webkitpy/common/system/executive_mock.py:
3338         * Scripts/webkitpy/layout_tests/port/config.py:
3339         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
3340
3341 2010-11-19  Steve Falkenburg  <sfalken@apple.com>
3342
3343         Reviewed by Adam Roben.
3344
3345         Add Debug_Cairo_CFLite and Release_Cairo_CFLite configurations for all vcproj files
3346         https://bugs.webkit.org/show_bug.cgi?id=49819
3347
3348         * DumpRenderTree/DumpRenderTree.sln:
3349         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3350         * DumpRenderTree/win/DumpRenderTree.vcproj:
3351         * DumpRenderTree/win/ImageDiff.vcproj:
3352         * FindSafari/FindSafari.vcproj:
3353         * MiniBrowser/MiniBrowser.vcproj:
3354         * TestWebKitAPI/win/TestWebKitAPI.sln:
3355         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3356         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj:
3357         * WebKitAPITest/WebKitAPITest.vcproj:
3358         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
3359         * WebKitTestRunner/win/InjectedBundle.vcproj:
3360         * WebKitTestRunner/win/InjectedBundleGenerated.vcproj:
3361         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
3362         * WinLauncher/WinLauncher.vcproj:
3363         * record-memory-win/record-memory-win.vcproj:
3364
3365 2010-11-19  Adam Roben  <aroben@apple.com>
3366
3367         Add some more Windows slaves
3368
3369         This is probably more than we will be using in the immediate future,
3370         but having some extra slave names makes experimenting with different
3371         configurations easier.
3372
3373         Reviewed by Jon Honeycutt.
3374
3375         * BuildSlaveSupport/build.webkit.org-config/config.json: Added 5 more
3376         Windows slaves and distributed them among the three different Test
3377         builders.
3378
3379 2010-11-19  Kinuko Yasuda  <kinuko@chromium.org>
3380
3381         Reviewed by Ojan Vafai.
3382
3383         [Chromium] REGRESSION: Record actual test results in the JSON result summary for non-layout tests
3384         https://bugs.webkit.org/show_bug.cgi?id=49702
3385
3386         Re-landing r72357 with a test fix.
3387
3388         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
3389         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3390         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
3391
3392 2010-11-19  Avi Drissman  <avi@google.com>
3393
3394         Reviewed by Antonio Gomes.
3395
3396         Complete support for Unix editing mode
3397         https://bugs.webkit.org/show_bug.cgi?id=49757
3398
3399         * DumpRenderTree/LayoutTestController.cpp:
3400         (setEditingBehaviorCallback):
3401         * DumpRenderTree/chromium/LayoutTestController.cpp:
3402         (LayoutTestController::setEditingBehavior):
3403
3404 2010-11-19  Adam Roben  <aroben@apple.com>
3405
3406         Fix run-javascriptcore-tests when there's a space in the path to
3407         testapi
3408
3409         Reviewed by Sam Weinig.
3410
3411         * Scripts/run-javascriptcore-tests: Use an indirect object when calling
3412         system() to force it to interpret spaces in the path correctly.
3413
3414 2010-11-19  Adam Roben  <aroben@apple.com>
3415
3416         Update scripts for .exe name changes after r72327
3417
3418         As of r72327, the "_debug" suffix is only used in Debug_All builds.
3419
3420         Reviewed by Sam Weinig.
3421
3422         * Scripts/run-javascriptcore-tests:
3423         (testapiPath):
3424
3425         * Scripts/sunspider-compare-results:
3426         (pathToBuiltJSC):
3427
3428         * Scripts/webkitdirs.pm:
3429         (jscPath):
3430         (safariPath):
3431
3432 2010-11-19  Steve Falkenburg  <sfalken@apple.com>
3433
3434         Reviewed by Darin Adler.
3435
3436         Normalize Cairo/CFLite project/solution configuration names
3437         https://bugs.webkit.org/show_bug.cgi?id=49818
3438
3439         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3440         * DumpRenderTree/win/DumpRenderTree.vcproj:
3441         * DumpRenderTree/win/ImageDiff.vcproj:
3442         * MiniBrowser/MiniBrowser.vcproj:
3443         * TestWebKitAPI/win/TestWebKitAPI.sln:
3444         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3445         * WebKitAPITest/WebKitAPITest.vcproj:
3446         * WebKitTestRunner/win/InjectedBundle.vcproj:
3447         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
3448         * WinLauncher/WinLauncher.vcproj:
3449         * Scripts/webkitdirs.pm: Updated cairo build configs.
3450
3451 2010-11-18  Steve Falkenburg  <sfalken@apple.com>
3452
3453         Reviewed by Adam Roben.
3454
3455         Windows vcproj configuration names should be normalized across projects
3456         https://bugs.webkit.org/show_bug.cgi?id=49776
3457
3458         * DumpRenderTree/DumpRenderTree.sln:
3459         * FindSafari/FindSafari.vcproj:
3460         * TestWebKitAPI/win/TestWebKitAPI.sln:
3461         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj:
3462         * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops: Added.
3463         * WebKitAPITest/WebKitAPITest.vcproj:
3464         * WebKitAPITest/WebKitAPITestCommon.vsprops:
3465         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
3466         * WebKitTestRunner/WebKitTestRunner.sln:
3467         * WebKitTestRunner/win/InjectedBundleGenerated.vcproj:
3468         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops: Added.
3469         * record-memory-win/record-memory-win.vcproj:
3470
3471 2010-11-18  Gavin Barraclough  <barraclough@apple.com>
3472
3473         Build fix - as per DRT-mac, always enabled developer extras,
3474         in win/qt/gtk DRT.
3475
3476         This is necessary to enable rich exception messages to be generated
3477         following https://bugs.webkit.org/show_bug.cgi?id=49708.
3478
3479         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3480         (shouldEnableDeveloperExtras):
3481         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3482         (WebCore::shouldEnableDeveloperExtras):
3483         * DumpRenderTree/win/DumpRenderTree.cpp:
3484         (shouldEnableDeveloperExtras):
3485
3486 2010-11-18  Sheriff Bot  <webkit.review.bot@gmail.com>
3487
3488         Unreviewed, rolling out r72357.
3489         http://trac.webkit.org/changeset/72357
3490         https://bugs.webkit.org/show_bug.cgi?id=49784
3491
3492         It broke test-webkitpy tests since the patch didn't have the
3493         corresponding test update (Requested by kinuko on #webkit).
3494
3495         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
3496         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3497
3498 2010-11-18  Mihai Parparita  <mihaip@chromium.org>
3499
3500         Reviewed by Tony Chang.
3501
3502         Rebaseline server: add rebaseline queue
3503         https://bugs.webkit.org/show_bug.cgi?id=49763
3504         
3505         Add a UI queue (a multi-item <select>) where tests to be baselined
3506         can be enqueued (also supports basic removal). A queue is used instead
3507         of immediately doing rebaselines since SCM operations can take a while.
3508         It's better to go through lots of tests quickly to mark them as
3509         needing rebaselining and then batch the SCM operations.
3510         
3511         Also adds a simple log where results can be displayed.
3512
3513         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
3514         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
3515         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
3516         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js: Added.
3517         * Scripts/webkitpy/tool/commands/data/rebaselineserver/util.js:
3518         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
3519
3520 2010-11-18  Gavin Barraclough  <barraclough@apple.com>
3521
3522         Reviewed by Oliver Hunt.
3523
3524         Bug 49708 - Stop recompiling functions to regenerate exception info.
3525
3526         Instead only hold info as necessary – keep divot info is the inspector
3527         is enabled, line number info is debugging or profiling, and handler
3528         info for functions with try/catch.
3529
3530         * DumpRenderTree/mac/DumpRenderTree.mm:
3531         (shouldEnableDeveloperExtras):
3532             - always enable the developer tools from DRT, to ensure we
3533               produce rich error messages on JavaScript exceptions.
3534
3535 2010-11-18  Kinuko Yasuda  <kinuko@chromium.org>
3536
3537         Reviewed by Ojan Vafai.
3538
3539         [Chromium] REGRESSION: Record actual test results in the JSON result summary for non-layout tests
3540         https://bugs.webkit.org/show_bug.cgi?id=49702
3541
3542         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
3543         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3544
3545 2010-11-18  Dirk Pranke  <dpranke@chromium.org>
3546
3547         Reviewed by Tony Chang.
3548
3549         new-run-webkit-tests: create first part of 'message_broker' class for multiprocessing fixes
3550
3551         Create the first version of the 'message_broker' package. This
3552         class will encapsulate all of the threading/multiprocessing and
3553         message-sending details for the communication between the
3554         'manager' object and the 'worker' objects. For the moment, it
3555         just holds some routines and tests for logging thread stacks.
3556
3557         There should be no functional changes in this patch, just moving stuff
3558         around.
3559
3560         https://bugs.webkit.org/show_bug.cgi?id=49707
3561
3562         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3563         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread_unittest.py: Removed.
3564         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py: Added.
3565         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py: Added.
3566         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3567         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3568
3569 2010-11-18  Steve Falkenburg  <sfalken@apple.com>
3570
3571         Reviewed by Adam Roben.
3572
3573         Remove leftover Windows Debug_Internal configurations
3574         https://bugs.webkit.org/show_bug.cgi?id=49758
3575
3576         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3577         * DumpRenderTree/win/DumpRenderTree.vcproj:
3578         * DumpRenderTree/win/ImageDiff.vcproj:
3579         * MiniBrowser/MiniBrowser.vcproj:
3580         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3581         * WebKitAPITest/WebKitAPITest.vcproj:
3582         * WebKitTestRunner/win/InjectedBundle.vcproj:
3583         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
3584         * WinLauncher/WinLauncher.vcproj:
3585
3586 2010-11-18  Adam Roben  <aroben@apple.com>
3587
3588         Add three new Windows XP build slaves
3589
3590         Reviewed by Steve Falkenburg.
3591
3592         * BuildSlaveSupport/build.webkit.org-config/config.json: Added three
3593         new slaves, and added them to the Windows XP Debug (Tests) builder.
3594
3595 2010-11-18  Daniel Bates  <dbates@rim.com>
3596
3597         Reviewed by Adam Roben.
3598
3599         update-webkit-support-libs should fall back to existing
3600         WebKitSupportLibrary version if there is no internet connectivity
3601         https://bugs.webkit.org/show_bug.cgi?id=49503
3602
3603         Fall back to existing support libraries (if present) when there is
3604         no internet connection.
3605
3606         Currently, update-webkit-support-libs dies with an "out-of-date"
3607         error when there is no internet connection because it cannot
3608         retrieve versioning information from developer.apple.com. Because
3609         update-webkit-support-libs fails, build-webkit fails. Instead,
3610         if there is no internet connection and the support libraries are
3611         present then we should warn the user and exit() with success so
3612         that build-webkit can work without an internet connection.
3613
3614         * Scripts/update-webkit-support-libs:
3615
3616 2010-11-18  Steve Falkenburg  <sfalken@apple.com>
3617
3618         Reviewed by Adam Roben.
3619
3620         Debug_Internal Windows configuration is unnecessary, should be removed
3621         https://bugs.webkit.org/show_bug.cgi?id=49753
3622
3623         * DumpRenderTree/win/DumpRenderTree.cpp:
3624         * MiniBrowser/win/stdafx.h:
3625         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
3626         * WebKitTestRunner/win/TestControllerWin.cpp:
3627
3628 2010-11-18  Steve Falkenburg  <sfalken@apple.com>
3629
3630         Reviewed by Adam Roben.
3631
3632         Clean up vcproj errors
3633         https://bugs.webkit.org/show_bug.cgi?id=49741
3634
3635         * MiniBrowser/MiniBrowser.vcproj:
3636         * WebKitAPITest/WebKitAPITest.vcproj:
3637         * WebKitTestRunner/win/InjectedBundle.vcproj:
3638         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
3639
3640 2010-11-18  Hayato Ito  <hayato@chromium.org>
3641
3642         Reviewed by Shinichiro Hamaji.
3643
3644         [NRWT] Fix a break of '--new-baseline' feature in pixel_test
3645         which is caused by r72249.
3646
3647         https://bugs.webkit.org/show_bug.cgi?id=49751
3648
3649         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
3650
3651 2010-11-18  Adam Roben  <aroben@apple.com>
3652
3653         Implement layoutTestController.waitForPolicyDelegate on Windows
3654
3655         Fixes <http://webkit.org/b/25038> <rdar://problem/6790213>.
3656
3657         Reviewed by Simon Fraser.
3658
3659         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3660         (LayoutTestController::waitForPolicyDelegate): Implemented by porting
3661         code from LayoutTestControllerMac.mm.
3662
3663 2010-11-18  Hayato Ito  <hayato@chromium.org>
3664
3665         Reviewed by Shinichiro Hamaji.
3666
3667         [NRWT] Fix a break of '--new-baseline' feature which is caused by r72249.
3668
3669         https://bugs.webkit.org/show_bug.cgi?id=49740
3670
3671         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
3672
3673 2010-11-18  Tony Chang  <tony@chromium.org>
3674
3675         Reviewed by Adam Barth.
3676
3677         run platform/chromium/plugins/refcount-leaks.html on all platforms
3678         https://bugs.webkit.org/show_bug.cgi?id=49485
3679
3680         Add PluginObject.testObjectCount which returns the number of allocated
3681         TestObjects. Add PluginObject.testCreateTestObject which allocates
3682         and returns a TestObject.
3683
3684         Add TestObject.refCount which returns the number of refs on the
3685         TestObject.
3686
3687         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
3688         (pluginGetProperty):
3689         (pluginInvoke):
3690         * DumpRenderTree/TestNetscapePlugIn/TestObject.cpp:
3691         (getTestObjectCount):
3692         (testAllocate):
3693         (testDeallocate):
3694         (testGetProperty):
3695         (testScriptObjectInvoke): Release a ref to a plugin object that was
3696             previously leaked.
3697         * DumpRenderTree/TestNetscapePlugIn/TestObject.h:
3698
3699 2010-11-17  Steve Falkenburg  <sfalken@apple.com>
3700
3701         Reviewed by Adam Roben.
3702
3703         WebKitTools projects (WebKitTestRunner, record-memory-win) should use vsprops for common build settings
3704         https://bugs.webkit.org/show_bug.cgi?id=49711
3705
3706         * WebKitTestRunner/Configurations/WebKitTestRunnerCFLite.vsprops: Added.
3707         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops: Added.
3708         * WebKitTestRunner/Configurations/WebKitTestRunnerCoreFoundation.vsprops: Added.
3709         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
3710         * record-memory-win/record-memory-win-common.vsprops: Added.
3711         * record-memory-win/record-memory-win.vcproj:
3712
3713 2010-11-18  Andras Becsi  <abecsi@inf.u-szeged.hu>
3714
3715         Reviewed by Csaba Osztrogonác.
3716
3717         [Qt][WK2] Only add user agent strings to the list which aren't listed yet.
3718
3719         * MiniBrowser/qt/BrowserWindow.cpp:
3720         (BrowserWindow::updateUserAgentList):
3721
3722 2010-11-17  Adam Roben  <aroben@apple.com>
3723
3724         Don't trigger Windows builds when chromium-win test results change