5afe6db12fa5d4cd8e20603ddd0ba9cd6e053d8c
[WebKit.git] / Tools / ChangeLog
1 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
2
3         Reviewed by Mihai Parparita.
4
5         new-run-webkit-tests: fix normalization of paths on windows when gathering files
6
7         r77434 introduced a bug that was causing the test expectations
8         for the GPU ports to not be treated properly. It turns out that
9         when we gathered the list of test files on Windows, we would
10         return paths of the form "c:\LayoutTests/fast/canvas", and the
11         mixture of backslashes and forward slashes was confusing things.
12
13         This patch normalizes all of the filenames returned from
14         test_files.find(), and adds better tests for this (fixing a
15         couple of other bugs found in the meantime).
16
17         https://bugs.webkit.org/show_bug.cgi?id=53720
18
19         * Scripts/webkitpy/layout_tests/port/test.py:
20         * Scripts/webkitpy/layout_tests/port/test_files.py:
21         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
22
23 2011-02-03  Adam Roben  <aroben@apple.com>
24
25         Add links to Windows crash logs in results.html
26
27         Fixes <http://webkit.org/b/53718> run-webkit-tests should link to Windows crash logs in
28         results.html
29
30         Reviewed by David Kilzer.
31
32         * Scripts/old-run-webkit-tests:
33         (top level): Added $crashLogTag and $windowsCrashLogFilePrefix (which came from
34         createDebuggerCommandFile).
35         (testCrashedOrTimedOut): If the test crashed, capture any saved crash log after the dump
36         tool has exited.
37         (captureSavedCrashLog): Added. Finds the crash log for the test that just crashed and moves
38         it into the test results directory tree. Only implemented for Cygwin currently.
39         (findNewestFileMatchingGlob): Added. Does what it says.
40         (htmlForResultsSection): Only link to files that exist.
41         (linksForErrorTest): Add a link to the crash log.
42         (deleteExpectedAndActualResults): Delete any old crash log for this test.
43         (createDebuggerCommandFile): Use the new $windowsCrashLogFilePrefix constant instead of
44         hardcoding it here.
45
46 2011-02-03  Adam Roben  <aroben@apple.com>
47
48         Tell the debugger the path to the WebKit source tree when saving a crash log
49
50         This allows the debugger to include the crashing line of code in the log.
51
52         Fixes <http://webkit.org/b/53678> Crash logs from buildslaves don't show the crashing line
53         of code
54
55         Reviewed by Sam Weinig.
56
57         * Scripts/old-run-webkit-tests:
58         (createDebuggerCommandFile): Added. Saves commands that we'd like the debugger to run to a
59         file and returns the path to that file. The commands we pass came from
60         setUpWindowsCrashLogSaving, but I've added a .srcpath command to tell the debugger where the
61         WebKit source code lives.
62         (setUpWindowsCrashLogSaving): Instead of specifying the commands directly on the command
63         line using -c, save them to a file and specify the path to that file using -cf. This works
64         around what is presumably a bug in Windows's command line parsing, where having multiple
65         quoted paths in the debugger commands causes the post-mortem debugger not to be invoked at
66         all. Also pulled the options we pass to the debugger out into a list that is then join()ed
67         together to make them easier to modify in the future.
68
69 2011-02-02  Sam Weinig  <sam@webkit.org>
70
71         Reviewed by Anders Carlsson.
72
73         Add notification of the end of a rubber band.
74         <rdar://problem/8940648>
75
76         * MiniBrowser/mac/BrowserWindowController.m:
77         (-[BrowserWindowController awakeFromNib]):
78         * WebKitTestRunner/TestController.cpp:
79         (WTR::TestController::createOtherPage):
80         (WTR::TestController::initialize):
81         Stub out the new WKUIClient function.
82
83 2011-02-03  Gabor Rapcsanyi  <rgabor@webkit.org>
84
85         Unreviewed.
86
87         Adding myself to committers.py.
88
89         * Scripts/webkitpy/common/config/committers.py:
90
91 2011-02-03  Balazs Kelemen  <kbalazs@webkit.org>
92
93         Reviewed by Csaba Osztrogonác.
94
95         [Qt][WK2] MiniBrowser's window size should be 800x600
96         https://bugs.webkit.org/show_bug.cgi?id=53670
97
98         Make layout test failure debugging easier.
99         * MiniBrowser/qt/BrowserWindow.cpp:
100         (BrowserWindow::BrowserWindow):
101
102 2011-02-02  Andy Estes  <aestes@apple.com>
103
104         Reviewed by Mark Rowe.
105
106         'update-webkit' should handle OpenSource and Internal using different
107         VCSs.
108
109         * Scripts/update-webkit: Re-check the VCS type when updating Apple's
110         Internal directory.
111
112 2011-02-02  Dirk Pranke  <dpranke@chromium.org>
113
114         Reviewed by Mihai Parparita.
115
116         new-run-webkit-tests: hardcode the directories to scan for tests
117         for GPU bots instead of SKIPping them. See bug 53562 for some
118         context, but we will now hard-code the list of directories to
119         use by default instead of skipping over directories in the
120         expectations file. We do this so that we will be able to merge
121         the expectations files without getting conflicting SKIP
122         directives. Note that this change will reduce the # of tests
123         being run on the Mac GPU bots, because we're accidentally
124         including some today.
125
126         https://bugs.webkit.org/show_bug.cgi?id=53631
127
128         * Scripts/webkitpy/layout_tests/port/base.py:
129         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
130         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
131
132 2011-02-02  Sam Weinig  <sam@webkit.org>
133
134         Reviewed by Beth Dakin.
135
136         Add ChromeClient function to paint custom overhang areas.
137         https://bugs.webkit.org/show_bug.cgi?id=53639
138
139         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
140         (WTR::InjectedBundlePage::InjectedBundlePage):
141         Stub out new callback.
142
143 2011-02-02  Dirk Pranke  <dpranke@chromium.org>
144
145         Reviewed by Tony Chang.
146
147         new-run-webkit-tests: support chromium code paths in mock_drt
148
149         https://bugs.webkit.org/show_bug.cgi?id=53471
150
151         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
152         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
153
154 2011-02-02  Adam Klein  <adamk@chromium.org>
155
156         Reviewed by Tony Chang.
157
158         Update new-run-webkit-tests --chromium to put output under Source/...
159         https://bugs.webkit.org/show_bug.cgi?id=53612
160
161         * BuildSlaveSupport/test-result-archive:
162         * Scripts/webkitpy/layout_tests/port/chromium.py:
163
164 2011-01-28  Tony Chang  <tony@chromium.org>
165
166         Reviewed by Eric Seidel.
167
168         [chromium] remove --use-test-shell from NRWT
169         https://bugs.webkit.org/show_bug.cgi?id=53346
170
171         I've already started removing some of the bindings like eventSender so
172         this already doesn't work isn't useful.  Also updated some comments to
173         refer to DRT instead of test_shell.
174
175         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
176         * Scripts/webkitpy/layout_tests/port/chromium.py:
177         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
178         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
179         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
180         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
181         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
182         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
183
184 2011-02-02  Steve Lacey  <sjl@chromium.org>
185
186         Reviewed by Eric Carlson.
187
188         Implement basic media statistics on media elements.
189         https://bugs.webkit.org/show_bug.cgi?id=53322
190
191         * Scripts/build-webkit:
192
193 2011-02-02  Kevin Ollivier  <kevino@theolliviers.com>
194
195         [wx] Build fixes for wxWebKit.
196
197         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
198         (LayoutTestController::setSerializeHTTPLoads):
199         * wx/browser/wscript:
200         * wx/build/build_utils.py:
201         * wx/build/settings.py:
202
203 2011-02-01  Dirk Pranke  <dpranke@chromium.org>
204
205         Reviewed by Mihai Parparita.
206
207         new-run-webkit-tests: stop skipping so many tests
208
209         r77163 introduced a regression where we weren't resetting test
210         expectations properly and were skipping too many tests as a
211         result. This patch fixes that and adds a test for it.
212
213         https://bugs.webkit.org/show_bug.cgi?id=53551
214
215         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
216         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
217
218 2011-02-01  Dirk Pranke  <dpranke@chromium.org>
219
220         Reviewed by Tony Chang.
221
222         new-run-webkit-tests: add first stub of test_runner2. This
223         will add support for the 'inline', 'threads', and 'processes'
224         flags to --worker-model, but for now the implementatios just
225         fall back on the old ones.
226
227         https://bugs.webkit.org/show_bug.cgi?id=53157
228
229         * Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
230         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
231
232 2011-02-01  Mihai Parparita  <mihaip@chromium.org>
233
234         Reviewed by James Robinson.
235
236         [Chromium] run-chromium-webkit-unit-tests looks for binaries in the wrong place
237         https://bugs.webkit.org/show_bug.cgi?id=53522
238
239         * Scripts/run-chromium-webkit-unit-tests:
240
241 2011-02-01  Adam Barth  <abarth@webkit.org>
242
243         Reviewed by Mihai Parparita.
244
245         Using Control-C to cancel webkit-patch or other python tools causes
246         unpleasant traceback console spew
247         https://bugs.webkit.org/show_bug.cgi?id=53462
248
249         Catch the exception and don't print the stack trace.
250
251         * Scripts/webkit-patch:
252
253 2011-02-01  Scott Cameron  <sccameron@rim.com>
254
255         Reviewed by Daniel Bates.
256
257         Use Windows format for MinGW HTTPD path.
258         https://bugs.webkit.org/show_bug.cgi?id=53503
259
260         * Scripts/webkitperl/httpd.pm:
261           - Use single-quotes around MySys value for $httpdPath in getHTTPDPath()
262             so that we don't have to escape the space characters in the path. Also,
263             changed path to Windows-style path and removed FIXME comment.
264
265 2011-02-01  Balazs Kelemen  <kbalazs@webkit.org>
266
267         Reviewed by Andreas Kling.
268
269         [Qt][WK2] Add a way to use shared process model in MiniBrowser
270         https://bugs.webkit.org/show_bug.cgi?id=53090
271
272         * MiniBrowser/qt/BrowserView.cpp:
273         (BrowserView::BrowserView): Removed the m_context member.
274         From now the context is guaranteed to be non-null and we
275         don't need to store that in the object.
276         * MiniBrowser/qt/BrowserView.h:
277         * MiniBrowser/qt/BrowserWindow.cpp:
278         Added static bool to determine that new windows need to be
279         created with their own context or not. Use the same context
280         and web process by default to be inilne with the other ports.
281         (BrowserWindow::BrowserWindow):
282         (BrowserWindow::newWindow):
283         * MiniBrowser/qt/BrowserWindow.h:
284         * MiniBrowser/qt/main.cpp:
285         (main): Added command line switch to be able to use the
286         non-shared process model. Simplify the handling of the command line
287         switches a little bit.
288
289 2011-02-01  Zoltan Horvath  <zoltan@webkit.org>
290
291         Reviewed by Andreas Kling.
292
293         [Qt] Add Window menu and Toggle FullScreen action to MiniBrowser.
294         https://bugs.webkit.org/show_bug.cgi?id=53491
295
296         * MiniBrowser/qt/BrowserWindow.cpp:
297         (BrowserWindow::BrowserWindow):
298         (BrowserWindow::toggleFullScreenMode):
299         * MiniBrowser/qt/BrowserWindow.h:
300
301 2011-02-01  Zoltan Horvath  <zoltan@webkit.org>
302
303         Reviewed by Andreas Kling.
304
305         [Qt] Add Toggle Frame Flattening, Auto Load Images and Disable JavaScript actions to MiniBrowser.
306         https://bugs.webkit.org/show_bug.cgi?id=53489
307
308         Add Toggle Frame Flattening action to Develop menu. Add Auto Load Images and Disable JavaScript actions
309         to Settings menu.
310
311         * MiniBrowser/qt/BrowserWindow.cpp:
312         (BrowserWindow::BrowserWindow):
313         (BrowserWindow::toggleFrameFlattening):
314         (BrowserWindow::toggleDisableJavaScript):
315         (BrowserWindow::toggleAutoLoadImages):
316         * MiniBrowser/qt/BrowserWindow.h:
317
318 2011-01-31  Mihai Parparita  <mihaip@chromium.org>
319
320         Reviewed by Tony Chang.
321
322         [Chromium] Switch chromium-mac to use ChromiumDriver
323         https://bugs.webkit.org/show_bug.cgi?id=53461
324         
325         For the sake of consistency with the other Chromium platforms (and so
326         that chromium-mac picks up special flags like --enable-hardware-gpu),
327         switch chromium-mac from the WebKitDriver to ChromiumDriver.
328
329         * Scripts/webkitpy/layout_tests/port/chromium.py:
330
331 2011-01-31  Dirk Pranke  <dpranke@chromium.org>
332
333         Reviewed by Mihai Parparita.
334
335         The current modifier parsing code in test_expectations is
336         fragile and hard-coded, so it's not easy to understand the logic
337         or easily add new types of modifiers (like GPU vs. CPU testing
338         for graphics tests, or 32-bit vs. 64-bit differences).
339
340         This is the first of two patches that will add in more generic
341         support and then eliminate the GPU-specific test expectations
342         files for Chromium.
343
344         This patch adds two standalone objects for handling modifiers. The
345         rules for interpreting modifiers, precedence, and conflicts are
346         given in the docstring to the ModifierMatcher class, which
347         returns ModifierMatchResult objects.
348         
349         This patch also adds routines to the Port interface and a
350         default set of values in the base object, in order to obtain the
351         values needed on a given test run. These values are then passed
352         to the expectation parser. This also allows us to clean up the
353         logic used to lint all of the different configurations in a
354         single test_expectations.txt file.
355
356         The next patch will merge in the separate GPU expectations file.
357
358         https://bugs.webkit.org/show_bug.cgi?id=51222
359
360         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
361         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
362         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
363         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
364         * Scripts/webkitpy/layout_tests/port/base.py:
365         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
366         * Scripts/webkitpy/layout_tests/port/chromium.py:
367         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
368         * Scripts/webkitpy/layout_tests/port/test.py:
369         * Scripts/webkitpy/layout_tests/port/webkit.py:
370         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
371         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
372         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
373         * Tools/Scripts/webkitpy/style/checkers/test_expectations.py:
374         * Tools/Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
375
376 2011-01-31  Scott Cameron  <sccameron@rim.com>
377
378         Reviewed by Daniel Bates.
379
380         update run-webkit-httpd to be able to launch Apache2.2 in a MSYS environment
381         https://bugs.webkit.org/show_bug.cgi?id=50036
382
383         This will add an Apache2.2 configuration file and modifies scripts to allow
384         running an httpd server in an MSYS environment.
385
386         The default Apache2.2 installation path has been preserved and PHP5 modules disabled
387         in order to allow for simple installation/execution.  Simply install the latest
388         Apache2.2 version with OpenSSL from http://httpd.apache.org/download.cgi#apache22 to
389         be able to execute run-webkit-httpd.
390         
391
392         * Scripts/run-webkit-httpd:
393         * Scripts/webkitperl/httpd.pm:
394
395 2011-01-31  Tony Chang  <tony@chromium.org>
396
397         Reviewed by Eric Seidel.
398
399         mac DRT should report RTL scroll offset relative to top right corner
400         https://bugs.webkit.org/show_bug.cgi?id=53324
401
402         * DumpRenderTree/mac/DumpRenderTree.mm:
403         (dumpFrameScrollPosition):
404
405 2011-01-31  Zoltan Horvath  <zoltan@webkit.org>
406
407         Reviewed by Andreas Kling.
408
409         [Qt] Add Take Screen Shot action to MiniBrowser
410         https://bugs.webkit.org/show_bug.cgi?id=53422
411
412         Add Take Screen Shot action to MiniBrowser's view menu.
413
414         * MiniBrowser/qt/BrowserWindow.cpp:
415         (BrowserWindow::BrowserWindow):
416         (BrowserWindow::screenshot):
417         * MiniBrowser/qt/BrowserWindow.h:
418
419 2011-01-31  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
420
421         Reviewed by Xan Lopez.
422
423         [GTK] REGRESSION:  http/tests/media/video-{cookie,referer}.html failing
424         https://bugs.webkit.org/show_bug.cgi?id=53379
425
426         Remove left over #ifdef's. I thought all of the conditional code
427         had been freed from the condition, but I forgot to check DRT.
428
429         * DumpRenderTree/gtk/DumpRenderTree.cpp:
430         (resetDefaultsToConsistentValues):
431         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
432         (LayoutTestController::setAlwaysAcceptCookies):
433
434 2011-01-30  Dirk Pranke  <dpranke@chromium.org>
435
436         Unreviewed, build fix.
437
438         Fix regression introduced in r77093 - path.rsplit() doesn't
439         take keyword arguments.
440
441         https://bugs.webkit.org/show_bug.cgi?id=53326
442
443         * Scripts/webkitpy/common/system/filesystem_mock.py:
444
445 2011-01-30  Dirk Pranke  <dpranke@chromium.org>
446
447         Reviewed by Mihai Parparita.
448
449         Add more unit tests for rebaseline-chromium-webkit-tests. This
450         change involves restructuring a bunch of r-c-w-t code to make it
451         more testable as well. We also add wrapper classes for handling
452         testing zip files and fetching URLs.
453
454         https://bugs.webkit.org/show_bug.cgi?id=53040
455
456         * Scripts/webkitpy/common/system/urlfetcher.py:
457         * Scripts/webkitpy/common/system/urlfetcher_mock.py:
458         * Scripts/webkitpy/common/system/zipfileset_mock.py:
459         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
460         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
461         * Scripts/webkitpy/tool/mocktool.py:
462
463 2011-01-30  Dirk Pranke  <dpranke@chromium.org>
464
465         Reviewed by Eric Seidel.
466
467         Clean up of the filesystem-related modules used in webkitpy.
468         I've added relpath() to the filesystem interface, modified
469         ospath.relpath() so that it could work with the filesystem
470         interface, and modified the fileset* routines to use the
471         filesystem interface consistently.
472
473         This patch also adds a close() routine to the fileset routines
474         to indicate that the caller is done with the fileset. This
475         allows zipfileset to clean up after itself when it creates
476         tempfiles to store downloads.
477
478         https://bugs.webkit.org/show_bug.cgi?id=53326
479
480         * Scripts/webkitpy/common/system/directoryfileset.py:
481         * Scripts/webkitpy/common/system/fileset.py:
482         * Scripts/webkitpy/common/system/filesystem.py:
483         * Scripts/webkitpy/common/system/filesystem_mock.py:
484         * Scripts/webkitpy/common/system/filesystem_unittest.py:
485         * Scripts/webkitpy/common/system/ospath.py:
486         * Scripts/webkitpy/common/system/zipfileset.py:
487         * Scripts/webkitpy/common/system/zipfileset_unittest.py:
488
489 2011-01-30  Balazs Kelemen  <kbalazs@webkit.org>
490
491         Reviewed by Csaba Osztrogonác.
492
493         [Qt][WK2]REGRESSION (r76991): Fix build errors
494         https://bugs.webkit.org/show_bug.cgi?id=53400
495
496         Revert the temporary build fix (http://trac.webkit.org/changeset/77088)
497         and remove WebKit2Prefix.h from the build.
498         * MiniBrowser/qt/MiniBrowser.pro:
499
500 2011-01-30  Csaba Osztrogonác  <ossy@webkit.org>
501
502         Unreviewed.
503
504         [Qt][WK2] Buildfix.
505
506         * MiniBrowser/qt/MiniBrowser.pro:
507
508 2011-01-28  Simon Fraser  <simon.fraser@apple.com>
509
510         Reviewed by Adam Roben.
511         
512         define NOMINMAX when building ImageDiff, as we do elsewhere.
513
514         Add various clampToInt() methods to MathExtras.h
515         https://bugs.webkit.org/show_bug.cgi?id=52910
516
517         * DumpRenderTree/win/ImageDiffCommon.vsprops:
518
519 2011-01-28  Maciej Stachowiak  <mjs@apple.com>
520
521         Reviewed by Darin Adler.
522
523         WebKitTestRunner needs layoutTestController.setPOSIXLocale
524         https://bugs.webkit.org/show_bug.cgi?id=42682
525
526         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
527         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
528         (WTR::InjectedBundle::resetLocalSettings):
529         (WTR::InjectedBundle::didReceiveMessage):
530         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
531         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
532         (WTR::LayoutTestController::setPOSIXLocale):
533         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
534
535 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
536  
537          Reviewed by Mihai Parparita.
538  
539          test-webkitpy: fix webkitpy.layout_tests.port.mac_unittest.MacTest.test_skipped_file_paths
540  
541          This patch re-enables this test and changes it to
542          handle all of the mac platform versions, not just the one
543          it is running on.
544  
545          https://bugs.webkit.org/show_bug.cgi?id=53356
546  
547          * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
548  
549 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
550
551         Unreviewed, build fix.
552
553         Take two. The fix in 77023 didn't work, because we were
554         still calling path.abspath_to_uri, which calls _cygpath under
555         the covers, and it appears the cygpath on the bots does
556         something different than it does on my machine. This patch
557         removes the calls to path.abspath_to_uri, so it should be safe.
558         If it doesn't work, I'll roll it out along with r76982 and 77023.
559
560         https://bugs.webkit.org/show_bug.cgi?id=53126
561
562         * Scripts/webkitpy/layout_tests/port/test.py:
563
564 2011-01-28  David Kilzer  <ddkilzer@apple.com>
565
566         <rdar://problem/8930699> build-webkit gives a bogus warning with newer versions of Xcode 
567         <http://webkit.org/b/53353>
568
569         Reviewed by Mark Rowe.
570
571         * Scripts/webkitdirs.pm:
572         (checkRequiredSystemConfig): Check the Xcode marketing version
573         in addition to the DevCoreTools build version before complaining
574         about an old version of Xcode.  Also make the Mac OS X version
575         check use Perl's built-in version string comparitor.
576
577 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
578
579         Unreviewed, build fix.
580
581         Work around breakage on Win 7 Release bot caused by r76982
582         and the fact that windows ports use "file:////" instead of
583         "file:///". Ideally the test code should be isolated from
584         this, but it isn't yet. Will fix properly in a bit.
585
586         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
587
588 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
589
590         Reviewed by Tony Chang.
591
592         new-run-webkit-tests: change worker model values to
593         "old-inline", "old-threads" in preparation for test_runner2 /
594         multiprocessing changes.
595
596         https://bugs.webkit.org/show_bug.cgi?id=53156
597
598         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
599         * Scripts/webkitpy/layout_tests/port/base.py:
600         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
601         * Scripts/webkitpy/layout_tests/port/mac.py:
602         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
603
604 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
605
606         Reviewed by Tony Chang.
607
608         committers.py - add an IRC nickname for dpranke
609         https://bugs.webkit.org/show_bug.cgi?id=53335
610
611         * Scripts/webkitpy/common/config/committers.py:
612
613 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
614
615         Reviewed by Tony Chang.
616
617         new-run-webkit-tests: add a "mock DRT" port implementation
618         and a separate class that emulates what we expect the
619         DumpRenderTree behavior to be.
620
621         This will eventually replace port/dryrun.py and allow us to get
622         better test coverage of the new-run-webkit-tests code as well as
623         a reference for what new-run-webkit-tests expects from DRT.
624
625         This is the first attempt at this, and it is pretty bare-boned. It
626         really only has been tested on the 'mac' port (and a little on
627         the 'chromium-mac' port.
628
629         https://bugs.webkit.org/show_bug.cgi?id=53126
630
631         * Scripts/webkitpy/common/system/filesystem_mock.py:
632         * Scripts/webkitpy/layout_tests/port/dryrun.py:
633         * Scripts/webkitpy/layout_tests/port/factory.py:
634         * Scripts/webkitpy/layout_tests/port/mock_drt.py: Added.
635         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Added.
636         * Scripts/webkitpy/layout_tests/port/test.py:
637
638 2011-01-28  Pratik Solanki  <psolanki@apple.com>
639
640         Unreviewed. Removing .swp file checked in by mistake.
641
642         * Scripts/.webkitdirs.pm.swp: Removed.
643
644 2011-01-28  Pratik Solanki  <psolanki@apple.com>
645
646         Reviewed by David Kilzer.
647
648         Space not necessary for undefined feature
649         https://bugs.webkit.org/show_bug.cgi?id=53317
650
651         * Scripts/build-webkit:
652
653 2011-01-28  Chang Shu  <chang.shu@nokia.com>
654
655         Reviewed by Andreas Kling.
656
657         Reset NetworkAccessManager to clean up credentials from previous tests.
658         This change causes no performance overhead either.
659         https://bugs.webkit.org/show_bug.cgi?id=36688
660
661         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
662         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
663         (WebCore::DumpRenderTree::open):
664         * DumpRenderTree/qt/DumpRenderTreeQt.h:
665
666 2011-01-28  Zoltan Horvath  <zoltan@webkit.org>
667
668         Reviewed by Andreas Kling.
669
670         [Qt] Add Zoom Text Only action to MiniBrowser
671         https://bugs.webkit.org/show_bug.cgi?id=53297
672
673         Add Zoom Text Only action to MiniBrowser's view menu, change zoom levels to avoid unnecessary divides.
674
675         * MiniBrowser/qt/BrowserWindow.cpp:
676         (BrowserWindow::BrowserWindow):
677         (BrowserWindow::zoomIn):
678         (BrowserWindow::zoomOut):
679         (BrowserWindow::resetZoom):
680         (BrowserWindow::toggleZoomTextOnly):
681         (BrowserWindow::applyZoom):
682         * MiniBrowser/qt/BrowserWindow.h:
683
684 2011-01-28  Adam Barth  <abarth@webkit.org>
685
686         Reviewed by Eric Seidel.
687
688         Add webkit-patch roll-chromium-deps
689         https://bugs.webkit.org/show_bug.cgi?id=53288
690
691         This command updates the Source/WebKit/chromium/DEPS file with the
692         last-known good revision of Chromium (or a revision specified on the
693         command line).  I'd eventually like to turn this into a SheriffBot
694         command, but this is the first step.
695
696         This patch somewhat sprawled because I needed to move a bunch of code
697         out of ChangeLog that should never have been there in the first place.
698         Also, I had to fix a bug in MockUser in order to test the new command.
699
700         * Scripts/webkitpy/common/checkout/api.py:
701         * Scripts/webkitpy/common/checkout/changelog.py:
702         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
703         * Scripts/webkitpy/common/checkout/deps.py: Added.
704         * Scripts/webkitpy/common/config/urls.py:
705         * Scripts/webkitpy/tool/commands/__init__.py:
706         * Scripts/webkitpy/tool/commands/download_unittest.py:
707         * Scripts/webkitpy/tool/commands/roll.py: Added.
708         * Scripts/webkitpy/tool/commands/roll_unittest.py: Added.
709         * Scripts/webkitpy/tool/commands/upload_unittest.py:
710         * Scripts/webkitpy/tool/mocktool.py:
711         * Scripts/webkitpy/tool/steps/__init__.py:
712         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py: Added.
713         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
714         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py: Added.
715         * Scripts/webkitpy/tool/steps/suggestreviewers_unittest.py:
716         * Scripts/webkitpy/tool/steps/updatechromiumdeps.py: Added.
717         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
718
719 2011-01-27  Greg Coletta  <greg.coletta@nokia.com>
720
721         Reviewed by Laszlo Gombos.
722
723         Get rid of prefix header dependency for WebKit2 build system
724         https://bugs.webkit.org/show_bug.cgi?id=50174
725
726         Change the style checker so that it enforces config.h include for
727         WebKit2.
728
729         * Scripts/webkitpy/style/checker.py:
730
731 2011-01-27  Maciej Stachowiak  <mjs@apple.com>
732
733         Reviewed by Darin Adler.
734
735         execCommand("Paste") doesn't work in WebKitTestRunner
736         https://bugs.webkit.org/show_bug.cgi?id=52785
737
738         Enable both of the settings needed to allow paste.
739         
740         * WebKitTestRunner/TestController.cpp:
741         (WTR::TestController::resetStateToConsistentValues):
742
743 2011-01-27  Jacob Dinu  <dinu.jacob@nokia.com>
744
745         Reviewed by Andreas Kling.
746
747         [Qt] QtTestBrowser: User input lost when toggling use of QGraphicsView
748         https://bugs.webkit.org/show_bug.cgi?id=48440
749
750         Preserve user input when toggling use of QGraphicsView
751
752         * QtTestBrowser/launcherwindow.cpp:
753         (LauncherWindow::initializeView):
754         (LauncherWindow::loadFinished):
755         * QtTestBrowser/launcherwindow.h:
756         * QtTestBrowser/mainwindow.cpp:
757         (MainWindow::addressUrl):
758         * QtTestBrowser/mainwindow.h:
759
760 2011-01-27  Dirk Pranke  <dpranke@chromium.org>
761
762         Reviewed by Mihai Parparita.
763
764         new-run-webkit-tests: turn off pixel tests correctly by default
765         for webkit-based ports. r70013 (bug 47510) used
766         port.set_option_default() to attempt to set default values, but
767         that didn't work correctly. I have removed set_option_default
768         for now since it was only being used in two places and in three
769         useless unit tests. There is a separate bug open to fix the
770         option parsing (48095), so this workaround is fine for now.
771
772         https://bugs.webkit.org/show_bug.cgi?id=53217
773
774         * Scripts/webkitpy/layout_tests/port/webkit.py:
775         * Scripts/webkitpy/layout_tests/port/base.py:
776         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
777
778 2011-01-27  Balazs Kelemen  <kbalazs@webkit.org>
779
780         Rubber-stamped by Ariya Hidayat.
781
782         Trivial crash fix in WTR.
783
784         * WebKitTestRunner/TestController.cpp:
785         (WTR::TestController::initialize): Increase the size
786         of the vector by one to be able to store the null character.
787
788 2011-01-27  Balazs Kelemen  <kbalazs@webkit.org>
789
790         Reviewed by Csaba Osztrogonác.
791
792         [Qt][WK2] WTR should be initialized in the same way as DRT
793         https://bugs.webkit.org/show_bug.cgi?id=53240
794
795         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
796         (WTR::activateFonts): Added missing initialization steps.
797
798 2011-01-27  Joone Hur <joone.hur@collabora.co.uk>
799
800         Unreviewed. 
801
802         Adding myself to committers.py.
803
804         * Scripts/webkitpy/common/config/committers.py:
805
806 2011-01-27  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
807
808         Reviewed by Csaba Osztrogonác.
809
810         [Qt] [Symbian] Move project files into Source
811         https://bugs.webkit.org/show_bug.cgi?id=52891
812
813         Fix the Symbian build after the project files
814         are moved to Source directory. On Symbian qmake
815         needs to run in the same directory where the main
816         pro files (WebKit.pro, Tools.pro) are located.
817
818         * Scripts/webkitdirs.pm: Change to the directory where the pro file
819         is located before running qmake for Symbian. Qmake on Symbian
820         does not properly honor the "-o" option, work it around by setting
821         the name of the Makefile to bld.inf.
822
823 2011-01-27  Zoltan Horvath  <zoltan@webkit.org>
824
825         Reviewed by Andreas Kling.
826
827         [Qt] Add simple zooming features to MiniBrowser
828         https://bugs.webkit.org/show_bug.cgi?id=53231
829
830         Add View menu and Zoom In, Zoom Out, Zoom Reset actions to MiniBrowser.
831
832         * MiniBrowser/qt/BrowserWindow.cpp:
833         (BrowserWindow::BrowserWindow):
834         (BrowserWindow::zoomIn):
835         (BrowserWindow::zoomOut):
836         (BrowserWindow::resetZoom):
837         (BrowserWindow::updateUserAgentList):
838         (BrowserWindow::applyZoom):
839         * MiniBrowser/qt/BrowserWindow.h:
840
841 2011-01-26  Maciej Stachowiak  <mjs@apple.com>
842
843         Reviewed by Dan Bernstein.
844
845         WebKitTestRunner needs to support layoutTestController.evaluateInWebInspector
846         https://bugs.webkit.org/show_bug.cgi?id=42319
847         
848         Add evaluateInWebInspector and other APIs needed for inspector tests to run.
849
850         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
851         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
852         (WTR::LayoutTestController::showWebInspector):
853         (WTR::LayoutTestController::closeWebInspector):
854         (WTR::LayoutTestController::evaluateInWebInspector):
855         (WTR::LayoutTestController::setTimelineProfilingEnabled):
856         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
857         * WebKitTestRunner/TestInvocation.cpp:
858         (WTR::shouldOpenWebInspector):
859         (WTR::TestInvocation::invoke):
860         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
861
862 2011-01-26  Martin Robinson  <mrobinson@igalia.com>
863
864         Reviewed by Xan Lopez.
865
866         [GTK] Pixel dumps do not include scrollbars in output images
867         https://bugs.webkit.org/show_bug.cgi?id=53216
868
869         Show scrollbars in pixel dumps. This will fix pixel dumps for tests
870         that have scrollbars.
871
872         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
873         (createBitmapContextFromWebView): Take the snapshot of the containing GtkScrolledWindow
874         instead of the web view itself.
875
876 2011-01-26  Dirk Pranke  <dpranke@chromium.org>
877
878         Reviewed by Mihai Parparita.
879
880         Fix regression introduced in r76322 ... new-run-webkit-tests
881         was attempting to save the image diff output as a UTF-8-encoded
882         file.
883
884         https://bugs.webkit.org/show_bug.cgi?id=53210
885
886         * Scripts/webkitpy/layout_tests/port/webkit.py:
887
888 2011-01-26  Sheriff Bot  <webkit.review.bot@gmail.com>
889
890         Unreviewed, rolling out r76709.
891         http://trac.webkit.org/changeset/76709
892         https://bugs.webkit.org/show_bug.cgi?id=53194
893
894         "broke python tests on non-snowleopard platforms" (Requested
895         by dpranke on #webkit).
896
897         * Scripts/webkitpy/layout_tests/port/factory.py:
898         * Scripts/webkitpy/layout_tests/port/mock_drt.py: Removed.
899         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Removed.
900
901 2011-01-26  Dirk Pranke  <dpranke@chromium.org>
902
903         Reviewed by Tony Chang.
904
905         new-run-webkit-tests: add a "mock DRT" port implementation
906         and a separate class that emulates what we expect the
907         DumpRenderTree behavior to be.
908
909         This will eventually replace port/dryrun.py and allow us to get
910         better test coverage of the new-run-webkit-tests code as well as
911         a reference for what new-run-webkit-tests expects from DRT.
912
913         This is the first attempt at this, and it is pretty bare-boned. It
914         really only has been tested on the 'mac' port (and a little on
915         the 'chromium-mac' port.
916
917         https://bugs.webkit.org/show_bug.cgi?id=53126
918
919         * Scripts/webkitpy/layout_tests/port/mock_drt.py: Added.
920         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Added.
921         * Scripts/webkitpy/layout_tests/port/factory.py:
922
923 2011-01-26  Xianzhu Wang  <wangxianzhu@google.com>
924
925         Reviewed by Tony Chang.
926
927         Add '--no-timeout' option to Chromium DRT to ease debugging.
928         https://bugs.webkit.org/show_bug.cgi?id=52873
929
930         * DumpRenderTree/chromium/DumpRenderTree.cpp:
931         (main):
932
933 2011-01-26  Csaba Osztrogonác  <ossy@webkit.org>
934
935         Reviewed by Andreas Kling.
936
937         [Qt] Fix qt_minimal build
938         https://bugs.webkit.org/show_bug.cgi?id=53172
939
940         * QtTestBrowser/locationedit.h:
941
942 2011-01-26  Mansi Mithal  <mansi.mithal@nokia.com>
943
944         Reviewed by Antonio Gomes.
945
946         QtTestBrowser should have a UI Setting to disable plugins
947         https://bugs.webkit.org/show_bug.cgi?id=52408
948         
949         Added a new action item named "Disable Plugins"
950         under the "Settings" menu. 
951
952         * QtTestBrowser/launcherwindow.cpp:
953         (LauncherWindow::createChrome):
954         (LauncherWindow::togglePlugins):
955         * QtTestBrowser/launcherwindow.h:
956
957 2011-01-25  Patrick Gansterer  <paroga@webkit.org>
958
959         Reviewed by Adam Barth.
960
961         Move main CMakeLists.txt into Source directory
962         https://bugs.webkit.org/show_bug.cgi?id=52888
963
964         * Scripts/webkitdirs.pm:
965
966 2011-01-25  Patrick Gansterer  <paroga@webkit.org>
967
968         Reviewed by Eric Seidel.
969
970         Improve label text in submit-to-ews
971         https://bugs.webkit.org/show_bug.cgi?id=53130
972
973         * QueueStatusServer/templates/submittoews.html:
974
975 2011-01-25  Mansi Mithal  <mansi.mithal@nokia.com>
976
977         Reviewed by Antonio Gomes.
978
979         QtTestBrowser should have a UI Settings to prevent loading images
980         https://bugs.webkit.org/show_bug.cgi?id=52409
981         
982         Added a new action item named "DisableAutoLoadImages"
983         under the "Settings" menu 
984
985         * QtTestBrowser/launcherwindow.cpp:
986         (LauncherWindow::createChrome):
987         (LauncherWindow::toggleAutoLoadImages):
988         * QtTestBrowser/launcherwindow.h:
989
990 2011-01-25  Dirk Pranke  <dpranke@chromium.org>
991
992         Reviewed by Tony Chang.
993
994         Minor bug fixes and cleanup for filesystem wrappers, port/* test
995         classes, test_expectations.py. This change adds "test-win" and
996         "test-mac" variants to the test port so that we can better test
997         rebaselining, and adds a MockUser() object for reuse in testing.
998
999         https://bugs.webkit.org/show_bug.cgi?id=53036
1000
1001         * Scripts/webkitpy/common/system/filesystem.py:
1002         * Scripts/webkitpy/common/system/filesystem_mock.py:
1003         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1004         * Scripts/webkitpy/layout_tests/port/factory.py:
1005         * Scripts/webkitpy/layout_tests/port/base.py:
1006         * Scripts/webkitpy/layout_tests/port/test.py:
1007         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1008         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
1009         * Scripts/webkitpy/tool/mocktool.py:
1010
1011 2011-01-25  Tony Chang  <tony@chromium.org>
1012
1013         Reviewed by Dimitri Glazkov.
1014
1015         [chromium] remove unused layoutTestController callback
1016         https://bugs.webkit.org/show_bug.cgi?id=53103
1017
1018         This method is used by a test_shell_test, but not needed by DRT.
1019
1020         * DumpRenderTree/chromium/LayoutTestController.cpp:
1021         (LayoutTestController::LayoutTestController):
1022         * DumpRenderTree/chromium/LayoutTestController.h:
1023
1024 2011-01-25  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1025
1026         Reviewed by Andreas Kling.
1027
1028         [GTK] Remove 64 bits release bot from the buildbot master
1029         https://bugs.webkit.org/show_bug.cgi?id=52899
1030
1031         Removes the 64 bits release slave from the buildbot configuration,
1032         so that we can use it as an EWS.
1033
1034         * BuildSlaveSupport/build.webkit.org-config/config.json:
1035
1036 2011-01-24  Maciej Stachowiak  <mjs@apple.com>
1037
1038         Reviewed by Dan Bernstein.
1039
1040         Implement database quota callback to fix storage tests on WebKit2 bot
1041         https://bugs.webkit.org/show_bug.cgi?id=53064
1042
1043         * WebKitTestRunner/TestController.cpp:
1044         (WTR::exceededDatabaseQuota):
1045         (WTR::TestController::createOtherPage):
1046         (WTR::TestController::initialize):
1047
1048 2011-01-24  Maciej Stachowiak  <mjs@apple.com>
1049
1050         Reviewed by Anders Carlsson.
1051
1052         Use designated temp directory for the database for WebKit2
1053         https://bugs.webkit.org/show_bug.cgi?id=53052
1054         
1055         Adopt the new WK2 API for this.
1056
1057         * WebKitTestRunner/TestController.cpp:
1058         (WTR::TestController::libraryPathForTesting):
1059         (WTR::TestController::initialize):
1060         * WebKitTestRunner/TestController.h:
1061         * WebKitTestRunner/mac/TestControllerMac.mm:
1062         (WTR::TestController::platformLibraryPathForTesting):
1063         * WebKitTestRunner/qt/TestControllerQt.cpp:
1064         (WTR::TestController::platformLibraryPathForTesting):
1065         * WebKitTestRunner/win/TestControllerWin.cpp:
1066         (WTR::TestController::platformLibraryPathForTesting):
1067
1068 2011-01-24  Lucas Forschler  <lforschler@apple.com>
1069
1070         Reviewed by Stephanie Lewis.
1071
1072         Add a new Leopard test bot.
1073
1074         * BuildSlaveSupport/build.webkit.org-config/config.json:
1075
1076 2011-01-24  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1077
1078         Reviewed by Adam Barth.
1079
1080         Add EFL Builder to core waterfall
1081         https://bugs.webkit.org/show_bug.cgi?id=52704
1082
1083         Add EFL Builder to the core waterfall again.
1084
1085         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1086         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1087
1088 2011-01-24  Xianzhu Wang  <wangxianzhu@google.com>
1089
1090         Reviewed by Tony Chang.
1091
1092         new-run-webkit-tests fails to start HTTP server if there are proxy settings
1093         https://bugs.webkit.org/show_bug.cgi?id=52872
1094
1095         Force disabling proxy to resolve the problem.
1096
1097         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
1098         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
1099
1100 2011-01-24  Andreas Kling  <kling@webkit.org>
1101
1102         Reviewed by Darin Adler.
1103
1104         check-webkit-style: Update exemptions following Source/ move.
1105         https://bugs.webkit.org/show_bug.cgi?id=53017
1106
1107         * Scripts/webkitpy/style/checker.py:
1108         * Scripts/webkitpy/style/checker_unittest.py:
1109
1110 2011-01-24  Andras Becsi  <abecsi@webkit.org>
1111
1112         Rubber-stamped by Csaba Osztrogonác.
1113
1114         [Qt] Move project files into Source
1115         https://bugs.webkit.org/show_bug.cgi?id=52891
1116
1117         * DumpRenderTree/qt/ImageDiff.pro: Add missing "Source" to WebKit.pri path
1118
1119 2011-01-24  Mikhail Naganov  <mnaganov@chromium.org>
1120
1121         Reviewed by Yury Semikhatsky.
1122
1123         Web Inspector: Find duplicate strings in localizedStrings.js
1124
1125         https://bugs.webkit.org/show_bug.cgi?id=53005
1126
1127         * Scripts/check-inspector-strings:
1128
1129 2011-01-24  Zoltan Horvath  <zoltan@webkit.org>
1130
1131         Reviewed by Andreas Kling.
1132
1133         [Qt] Regroup MiniBrowser's menubar and add open file action
1134         https://bugs.webkit.org/show_bug.cgi?id=53000
1135
1136         Add File and Develop menu to MiniBrowser's menubar and add open file action to File menu.
1137
1138         * MiniBrowser/qt/BrowserWindow.cpp:
1139         (BrowserWindow::BrowserWindow):
1140         (BrowserWindow::openFile):
1141         (BrowserWindow::~BrowserWindow):
1142         * MiniBrowser/qt/BrowserWindow.h:
1143
1144 2011-01-24  Csaba Osztrogonác  <ossy@webkit.org>
1145
1146         Unreviewed fix after r76496
1147
1148         [Qt] Move project files into Source
1149         https://bugs.webkit.org/show_bug.cgi?id=52891
1150
1151         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Remove unnecessary "Source" from the path.
1152         * BuildSlaveSupport/built-product-archive: Remove unnecessary "Source" from the path.
1153         * Scripts/webkitdirs.pm: Add the accidentally removed slash to the path.
1154
1155 2011-01-24  Andras Becsi  <abecsi@webkit.org>
1156
1157         Reviewed by Csaba Osztrogonác.
1158
1159         [Qt] Move project files into Source
1160         https://bugs.webkit.org/show_bug.cgi?id=52891
1161
1162         * DerivedSources.pro: Renamed from DerivedSources.pro.
1163         * DumpRenderTree/qt/DumpRenderTree.pro:
1164         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1165         * MiniBrowser/DerivedSources.pro:
1166         * MiniBrowser/qt/MiniBrowser.pro:
1167         * QtTestBrowser/QtTestBrowser.pro:
1168         * Scripts/webkitdirs.pm:
1169         * Tools.pro: Added.
1170         * WebKitTestRunner/DerivedSources.pro:
1171         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1172         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1173
1174 2011-01-22  Geoffrey Garen  <ggaren@apple.com>
1175
1176         Reviewed by Dan Bernstein.
1177
1178         Beefed up --threaded mode to catch even more kinds of errors.
1179         https://bugs.webkit.org/show_bug.cgi?id=52971
1180
1181         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Use a shared
1182         context group to force JSC to mark multiple threads. (This used to be
1183         the default, but it changed in SnowLeopard.)
1184         (runJavaScriptThread): Do more locking and unlocking, and more allocation,
1185         to give threading mistakes more chances to show themselves.
1186         (startJavaScriptThreads):
1187         (stopJavaScriptThreads):
1188
1189 2011-01-22  Robert Hogan  <robert@webkit.org>
1190
1191         Reviewed by Andreas Kling.
1192
1193         [Qt] Support layoutTestController.addURLToRedirect()
1194         https://bugs.webkit.org/show_bug.cgi?id=52956
1195
1196         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1197         (LayoutTestController::addURLToRedirect):
1198         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1199
1200 2011-01-22  Robert Hogan  <robert@webkit.org>
1201
1202         Reviewed by Kenneth Rohde Christiansen.
1203
1204         [Qt] REGRESSION (r72360): http/tests/security/aboutBlank/xss-DENIED-* tests fail
1205         https://bugs.webkit.org/show_bug.cgi?id=49802
1206
1207         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1208         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1209         (WebCore::DumpRenderTree::open):
1210
1211 2011-01-21  Adam Barth  <abarth@webkit.org>
1212
1213         Reviewed by Maciej Stachowiak.
1214
1215         Disable mac_unittest.py that fails on some of the Mac bots
1216         https://bugs.webkit.org/show_bug.cgi?id=52947
1217
1218         As noted in the comment, this test does not appear to be correct
1219         because the function this test is testing returns different results
1220         depending on which flavor of Mac the test is run on.  This patch
1221         disable the test.  Hopefully we can re-enable the test once we've
1222         probably insulated the test from its environment.
1223
1224         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1225
1226 2011-01-21  Dirk Pranke  <dpranke@chromium.org>
1227
1228         Reviewed by Mihai Parparita.
1229
1230         Fix bug introduced in r76322 that caused NRWT to not actually
1231         read the Skipped files properly.
1232
1233         https://bugs.webkit.org/show_bug.cgi?id=52771
1234
1235         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1236         * Scripts/webkitpy/layout_tests/port/webkit.py:
1237         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1238
1239 2011-01-21  Sam Weinig  <sam@webkit.org>
1240
1241         Reviewed by Geoffrey Sean Garen and Mark Rowe.
1242
1243         WebKitTestRunner needs the HOME environment variable to be set.
1244         <rdar://problem/8896573>
1245
1246         * Scripts/old-run-webkit-tests: Set the HOME environment variable if
1247         it exists.
1248
1249 2011-01-21  Dirk Pranke  <dpranke@chromium.org>
1250
1251         Reviewed by Eric Seidel.
1252
1253         Suppress a few remaining integration tests so that none of the
1254         layout_test unit tests ever read from the filesystem or launch
1255         subprocesses that aren't part of the unit tests.
1256
1257         Also fix a minor bug in the printing unit tests that was
1258         incorrectly relying on sys.argv.
1259
1260         https://bugs.webkit.org/show_bug.cgi?id=52863
1261
1262         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1263         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1264         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1265
1266 2011-01-21  Darin Adler  <darin@apple.com>
1267
1268        Fix Mac build.
1269
1270         * MiniBrowser/mac/BrowserWindowController.m:
1271         (-[BrowserWindowController awakeFromNib]): Pass 0 for runModal function.
1272
1273 2011-01-20  Darin Adler  <darin@apple.com>
1274
1275         Reviewed by Dan Bernstein.
1276
1277         WebKit2: Implement showModalDialog
1278         https://bugs.webkit.org/show_bug.cgi?id=52855
1279
1280         This fixes WebKitTestRunner to compile, but more work is probably
1281         needed to get it to pass the tests.
1282
1283         * WebKitTestRunner/TestController.cpp:
1284         (WTR::TestController::runModal): Added. Calls through to the
1285         platform-specific version of runModal.
1286         (WTR::TestController::createOtherPage): Changed to be a private
1287         static member function so it can refer to runModal, which is
1288         a private static member function.
1289         (WTR::TestController::initialize): Pass 0 for the runModal
1290         function since we don't need to run the main window modal.
1291         I suspect this is wrong and will need to change.
1292         * WebKitTestRunner/TestController.h: Added declarations for
1293         the functions added above.
1294         * WebKitTestRunner/mac/TestControllerMac.mm:
1295         (WTR::TestController::runModal): Added. Untested implementation.
1296         * WebKitTestRunner/qt/TestControllerQt.cpp:
1297         (WTR::TestController::runModal): Added.
1298         * WebKitTestRunner/win/TestControllerWin.cpp:
1299         (WTR::TestController::runModal): Added.
1300
1301 2011-01-21  Eric Seidel  <eric@webkit.org>
1302
1303         Reviewed by Adam Barth.
1304
1305         Split Host object off from WebKitPatch for easier re-use
1306         https://bugs.webkit.org/show_bug.cgi?id=52284
1307
1308         new-run-webkit-tests and other tools are eventually going to want one of these.
1309         Basically you need to inherit from this class if you want to pretend to be a
1310         self.tool object for Steps/Commands.
1311
1312         * Scripts/webkitpy/common/host.py: Added.
1313         * Scripts/webkitpy/tool/main.py:
1314
1315 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1316
1317         Reviewed by Adam Barth.
1318
1319         Disable the tests that start and stop the http server and web
1320         server, so that we don't have to worry about port collisions on
1321         the bots.
1322
1323         https://bugs.webkit.org/show_bug.cgi?id=52861
1324
1325         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1326
1327 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1328
1329         Reviewed by Eric Seidel.
1330
1331         nrwt: rewrite google_chrome_unittest to use mock filesystem.
1332         
1333         https://bugs.webkit.org/show_bug.cgi?id=52772
1334         
1335         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
1336
1337 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1338
1339         Reviewed by Eric Siedel.
1340
1341         nrwt: clean up almost all remaining port references, remove
1342         unnecessary import clauses. The only remaining references are
1343         in places where a mock filesystem makes no sense or can't be
1344         used, and in one routine in port/google_chrome_unittest that
1345         I'll rewrite in a separate patch.
1346
1347         https://bugs.webkit.org/show_bug.cgi?id=52771
1348
1349         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1350         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1351         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1352         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1353         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1354         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1355         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1356         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
1357         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
1358         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
1359         * Scripts/webkitpy/layout_tests/port/gtk.py:
1360         * Scripts/webkitpy/layout_tests/port/mac.py:
1361         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1362         * Scripts/webkitpy/layout_tests/port/qt.py:
1363         * Scripts/webkitpy/layout_tests/port/webkit.py:
1364         * Scripts/webkitpy/layout_tests/port/win.py:
1365         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
1366
1367 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1368
1369         Reviewed by Mihai Parparita.
1370
1371         remove fs refs from run_webkit_tests, rebaseline_chromium_webkit_tests
1372
1373         https://bugs.webkit.org/show_bug.cgi?id=52762
1374
1375         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1376         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1377
1378 2011-01-20  Tony Chang  <tony@chromium.org>
1379
1380         Reviewed by Ojan Vafai.
1381
1382         [chromium] fix the paths used for the rebaseline tool
1383         https://bugs.webkit.org/show_bug.cgi?id=52857
1384
1385         Some of the bots were renamed so the path to grab the results zip
1386         file has changed.
1387
1388         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1389
1390 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1391
1392         Reviewed by Tony Chang.
1393
1394         Fix bug introduced in r72688 / bug 52768 that broke the
1395         generation of the output filename links in the results.html
1396         output. Apparently none of the unit tests actually checked to
1397         make sure the generated links were correct :(
1398
1399         https://bugs.webkit.org/show_bug.cgi?id=52854
1400
1401         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1402         * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
1403
1404 2011-01-20  Alexey Proskuryakov  <ap@apple.com>
1405
1406         Reviewed by Darin Adler.
1407
1408         https://bugs.webkit.org/show_bug.cgi?id=52849
1409         Make window.print work with WebKit2
1410
1411         * MiniBrowser/mac/BrowserWindowController.m:
1412         (-[BrowserWindowController awakeFromNib]):
1413         * WebKitTestRunner/TestController.cpp:
1414         (WTR::createOtherPage):
1415         (WTR::TestController::initialize):
1416         Added zeroes to WKPageUIClient structures to avoid build failures.
1417
1418 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1419
1420         Reviewed by Eric Seidel.
1421
1422         nrwt: remove fs refs from printing, test_failures, test_expectations, text_diff
1423
1424         https://bugs.webkit.org/show_bug.cgi?id=52756
1425
1426         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1427         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1428         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1429         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
1430         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1431         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
1432
1433 2011-01-20  Mansi Mithal  <mansi.mithal@nokia.com>
1434
1435         Reviewed by Antonio Gomes.
1436
1437         QtTestBrowser should have a seperate menu for Settings
1438         https://bugs.webkit.org/show_bug.cgi?id=52817
1439         
1440         Added a new menu item named "Settings"
1441         and moved the "Enable interrupting js scripts" and "Enable js pop up windows" under the "Settings" menu 
1442
1443         * QtTestBrowser/launcherwindow.cpp:
1444         (LauncherWindow::createChrome):
1445
1446 2011-01-20  Sam Weinig  <sam@webkit.org>
1447
1448         Reviewed by John Sullivan.
1449
1450         Update update-webkit-localizable-strings with new path to WebKit.
1451
1452         * Scripts/update-webkit-localizable-strings:
1453
1454 2011-01-20  James Robinson  <jamesr@chromium.org>
1455
1456         Reviewed by Darin Fisher.
1457
1458         Implement mozilla's requestAnimationFrame API
1459         https://bugs.webkit.org/show_bug.cgi?id=51218
1460
1461         Chromium DumpRenderTree support for window.webkitRequestAnimationFrame.
1462
1463         * DumpRenderTree/chromium/WebViewHost.cpp:
1464         (invokeScheduleComposite):
1465         (WebViewHost::scheduleAnimation):
1466         (WebViewHost::paintInvalidatedRegion):
1467         * DumpRenderTree/chromium/WebViewHost.h:
1468
1469 2011-01-20  Maciej Stachowiak  <mjs@apple.com>
1470
1471         Reviewed by Adam Roben.
1472
1473         WebKitTestRunner needs to support layoutTestController.evaluateScriptInIsolatedWorld
1474         https://bugs.webkit.org/show_bug.cgi?id=42327
1475
1476         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm: Add support
1477         for methods that take their normal arguments but also a JSContextRef.
1478         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: IDL definition
1479         for evaluateScriptInIsolatedWorld.
1480         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1481         (WTR::InjectedBundlePage::didClearWindowForFrame): Set a magic variable only if
1482         this call is for an isolated world.
1483         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1484         (WTR::worldMap): Helper to create a world map.
1485         (WTR::LayoutTestController::worldIDForWorld): Map from an ID to a world.
1486         (WTR::LayoutTestController::evaluateScriptInIsolatedWorld): The newly
1487         added LayoutTestController API.
1488         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1489
1490 2011-01-19  Adam Roben  <aroben@apple.com>
1491
1492         Convert paths in environment variables back to msys-style inside commit-log-editor
1493
1494         When this script gets run from inside git commit, msys-style paths in the environment will
1495         have been turned into Windows-style paths with forward slashes. This screws up functions
1496         like File::Spec->rel2abs, which seem to rely on $PWD having an msys-style path. We convert
1497         the paths back to msys-style before doing anything else.
1498
1499         Fixes <http://webkit.org/b/48527> commit-log-editor uses full paths for section headers when
1500         using msysgit's Perl and multiple ChangeLogs have been edited
1501
1502         Reviewed by David Kilzer.
1503
1504         * Scripts/commit-log-editor: Call fixEnvironment before doing anything else.
1505         (fixEnvironment): Added. When run in msys in conjunction with git (i.e., when invoked from
1506         inside git commit), convert Windows-style paths in the environment back to msys-style paths.
1507
1508 2011-01-20  Zoltan Horvath  <zoltan@webkit.org>
1509
1510         [Win] Unreviewed build fix after r76248.
1511
1512         * DumpRenderTree/ForwardingHeaders/wtf/FastAllocBase.h: Added.
1513
1514 2011-01-20  Zoltan Horvath  <zoltan@webkit.org>
1515
1516         Reviewed by Csaba Osztrogonác.
1517
1518         Refactoring of the custom allocation framework
1519         https://bugs.webkit.org/show_bug.cgi?id=49897
1520
1521         Inheriting from FastAllocBase can result in objects getting larger (bug #33896, #46589).
1522         The modification replaces Noncopyable and FastAllocBase classes and these inherits with their
1523         equivalent macro implementation at the necessary places.
1524 2011-01-20  Yi Shen  <yi.4.shen@nokia.com>
1525
1526         Unreviewed. 
1527
1528         Adding myself to committers.py.
1529
1530         * Scripts/webkitpy/common/config/committers.py:
1531
1532 2011-01-20  Adam Barth  <abarth@webkit.org>
1533
1534         Reviewed by Tony Chang.
1535
1536         Chromium builders don't delete unversioned directories when DEPS change
1537         https://bugs.webkit.org/show_bug.cgi?id=52745
1538
1539         If we pass this option to gclient sync, gclient will delete directories
1540         that are no longer part of DEPS instead of leaving them around to
1541         confuse us later.  Apparently, the downstream buildbots use this option
1542         already.
1543
1544         * Scripts/update-webkit-chromium:
1545
1546 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1547
1548         Unreviewed, build fix - I pulled this patch in to fix an issue
1549         revealed by r76195 running on some new bots). Also fix a couple
1550         of other issues revealed in testing.
1551
1552         nrwt: remove fs refs from layout_package/json*
1553
1554         https://bugs.webkit.org/show_bug.cgi?id=52754
1555
1556         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1557         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1558         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
1559         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1560         * Scripts/webkitpy/layout_tests/port/base.py:
1561
1562 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1563
1564         Unreviewed, build fix.
1565
1566         Fix a couple of minor bugs discovered while bringing up new bots
1567         for testing.
1568
1569         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1570         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1571
1572 2011-01-19  James Robinson  <jamesr@chromium.org>
1573
1574         Unreviewed, rolling out r76194.
1575         http://trac.webkit.org/changeset/76194
1576         https://bugs.webkit.org/show_bug.cgi?id=51218
1577
1578         Caused mysterious compile failure on the chromium win
1579         build.webkit.org bots
1580
1581         * DumpRenderTree/chromium/WebViewHost.cpp:
1582         (WebViewHost::paintInvalidatedRegion):
1583         * DumpRenderTree/chromium/WebViewHost.h:
1584
1585 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1586
1587         Reviewed by Mihai Parparita.
1588
1589         remove fs refs from test_runner, dump_render_tree_thread
1590
1591         https://bugs.webkit.org/show_bug.cgi?id=52753
1592
1593         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1594         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1595         * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
1596         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1597
1598 2011-01-19  James Robinson  <jamesr@chromium.org>
1599
1600         Reviewed by Darin Fisher.
1601
1602         Implement mozilla's requestAnimationFrame API
1603         https://bugs.webkit.org/show_bug.cgi?id=51218
1604
1605         Chromium DumpRenderTree support for window.webkitRequestAnimationFrame.
1606
1607         * DumpRenderTree/chromium/WebViewHost.cpp:
1608         (invokeScheduleComposite):
1609         (WebViewHost::scheduleAnimation):
1610         (WebViewHost::paintInvalidatedRegion):
1611         * DumpRenderTree/chromium/WebViewHost.h:
1612
1613 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1614
1615         Unreviewed, build fix.
1616
1617         Fix a few incorrect "self._filesystem" references introduced in
1618         r76184.
1619
1620         * Scripts/webkitpy/layout_tests/port/chromium.py:
1621         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1622
1623 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1624
1625         Reviewed by Mihai Parparita.
1626
1627         add a .sep property, abspath(), isabs(), mtime(), and
1628         open_text_file_for_writing() to filesystem modules. Some of
1629         these properties are not needed in this patch but will be needed
1630         in subsequent patches (I'm doing this to avoid having to track
1631         multiple versions of a single file).
1632
1633         Also, change most of the port/* modules to use the filesystem
1634         objects instead of referencing the filesystem directly.
1635
1636         https://bugs.webkit.org/show_bug.cgi?id=52748
1637
1638         * Scripts/webkitpy/common/system/filesystem.py:
1639         * Scripts/webkitpy/common/system/filesystem_mock.py:
1640         * Scripts/webkitpy/layout_tests/port/__init__.py:
1641         * Scripts/webkitpy/layout_tests/port/base.py:
1642         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1643         * Scripts/webkitpy/layout_tests/port/chromium.py:
1644         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1645         * Scripts/webkitpy/layout_tests/port/config.py:
1646         * Scripts/webkitpy/layout_tests/port/test.py:
1647         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
1648
1649 2011-01-19  Maciej Stachowiak  <mjs@apple.com>
1650
1651         Reviewed by Anders Carlsson.
1652
1653         If resetting between tests times out, treat it as a WebProcess crash
1654         https://bugs.webkit.org/show_bug.cgi?id=52757
1655
1656         * WebKitTestRunner/TestController.cpp:
1657         (WTR::TestController::runTest):
1658
1659 2011-01-19  Alexey Proskuryakov  <ap@apple.com>
1660
1661         Reviewed by Darin Adler.
1662
1663         https://bugs.webkit.org/show_bug.cgi?id=52739
1664         Make it possible for a WebKit2 client to print headers and footers
1665
1666         Added dummy implementations for new printing UIClient calls.
1667
1668         * MiniBrowser/mac/BrowserWindowController.m:
1669         (-[BrowserWindowController awakeFromNib]):
1670         * WebKitTestRunner/TestController.cpp:
1671         (WTR::createOtherPage):
1672         (WTR::TestController::initialize):
1673
1674 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1675
1676         Reviewed by Ojan Vafai.
1677
1678         Change webkitpy/layout_tests/port/test.py to use the
1679         in-memory filesystem for cleaner unit testing. This
1680         change allows us to kill a lot of code that was
1681         specific to the test port, at the cost of being a
1682         little less clear about how things would work if
1683         you didn't have a filesystem.
1684
1685         https://bugs.webkit.org/show_bug.cgi?id=52605
1686
1687         * Scripts/webkitpy/layout_tests/port/test.py:
1688
1689 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1690
1691         Unreviewed, build fix.
1692
1693         Fix test failure caused by committing attachment 79368 instead
1694         of attachment 79461 on bug 52604.
1695
1696         * Scripts/webkitpy/common/system/filesystem_mock.py:
1697
1698 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1699
1700         Reviewed by Mihai Parparita.
1701
1702         new-run-webkit-tests: remove use of os.walk, use mock filesystem for better
1703         unit testing. os.walk() is too much of a hassle to implement on
1704         top of the in-memory mock filesystem and adding the necessary
1705         interface to files_under() gives clients a cleaner API anyway
1706         (for this particular usage model).
1707
1708         https://bugs.webkit.org/show_bug.cgi?id=52691
1709
1710         * Scripts/webkitpy/common/system/filesystem.py:
1711         * Scripts/webkitpy/common/system/filesystem_mock.py:
1712         * Scripts/webkitpy/layout_tests/port/test_files.py:
1713         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
1714
1715 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1716
1717         Reviewed by Tony Chang.
1718
1719         Change more modules in the layout-tests code to use the
1720         filesystem wrapper for cleaner unit testing.
1721
1722         This patch also adds the glob() wrapper to the filesystem
1723         abstraction.
1724         
1725         https://bugs.webkit.org/show_bug.cgi?id=52604
1726
1727         * Scripts/webkitpy/layout_tests/port/test_files.py:
1728         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
1729         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
1730         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1731         * Scripts/webkitpy/common/system/filesystem.py:
1732         * Scripts/webkitpy/common/system/filesystem_mock.py:
1733
1734 2011-01-19  Levi Weintraub  <leviw@chromium.org>
1735
1736         Unreviewed.
1737
1738         Updating my email addresses and irc nick.
1739
1740         * Scripts/webkitpy/common/config/committers.py:
1741
1742 2011-01-19  Tony Chang  <tony@chromium.org>
1743
1744         Reviewed by Mihai Parparita.
1745
1746         [chromium] [linux] if check-sys-deps fails, output the failure reason
1747         https://bugs.webkit.org/show_bug.cgi?id=52671
1748
1749         * Scripts/webkitpy/common/system/executive_mock.py: Add support for
1750             error handler functions.
1751         * Scripts/webkitpy/layout_tests/port/chromium.py:
1752             output the error text from --check-sys-deps
1753         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1754
1755 2011-01-19  Aparna Nandyal  <aparna.nand@wipro.com>
1756
1757         Reviewed by Andreas Kling.
1758
1759         [Qt] QtTestBrowser crashes when closing if Facebook is opened
1760         https://bugs.webkit.org/show_bug.cgi?id=52554
1761         
1762         QtNetworkAccessManager is created in a thread and set as
1763         member variable in QWebPage. When the thread is destroyed
1764         the object is still used. So fix will set the object to
1765         NULL once the thread is destroyed.
1766
1767         * QtTestBrowser/launcherwindow.cpp:
1768         (LauncherWindow::~LauncherWindow):
1769
1770 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
1771
1772         Rubber stamped by Csaba Osztrogonac
1773
1774         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: Removed unncessary inculde of WKStringCF.h
1775
1776 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
1777
1778         Reviewed by Tony Chang.
1779
1780         new-run-webkit-tests: add a --build-directory command line argument
1781
1782         Official Google Chrome builds use a non-standard build directory
1783         location. This patch adds a --build-directory argument that
1784         allows that location to be specified on the command line. Only
1785         Chromium-based builds will use this flag for now, but anyone can
1786         in the future.
1787
1788         There are no unit tests for this since it's difficult to test
1789         until mock filesystems are fully supported in the code. This was
1790         tested by hand for now.
1791
1792         https://bugs.webkit.org/show_bug.cgi?id=52694
1793
1794         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1795         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1796         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1797         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1798
1799 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
1800
1801         Not reviewed. Bot fix.
1802
1803         Remove an inadvertently committed debugging print.
1804
1805         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1806         (LayoutTestController::notifyDone):
1807
1808 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
1809
1810         Reviewed by Sam Weinig.
1811
1812         WebKitTestRunner should track loading more like DumpRenderTree
1813         https://bugs.webkit.org/show_bug.cgi?id=52692
1814
1815         Change load tracking to track the current top loading frame, in the manner of DumpRenderTree.
1816         This makes some tests that call notifyDone multiple times pass.
1817         
1818         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1819         (WTR::InjectedBundle::InjectedBundle):
1820         (WTR::InjectedBundle::done):
1821         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1822         (WTR::InjectedBundle::topLoadingFrame):
1823         (WTR::InjectedBundle::setTopLoadingFrame):
1824         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1825         (WTR::InjectedBundlePage::InjectedBundlePage):
1826         (WTR::InjectedBundlePage::stopLoading):
1827         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
1828         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
1829         (WTR::InjectedBundlePage::didFinishLoadForFrame):
1830         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
1831         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1832         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1833         (WTR::LayoutTestController::notifyDone):
1834         * WebKitTestRunner/TestController.cpp:
1835         (WTR::TestController::didReceiveMessageFromInjectedBundle):
1836
1837 2011-01-18  Mihai Parparita  <mihaip@chromium.org>
1838
1839         Reviewed by Kent Tamura.
1840
1841         [Chromium] NRWT looking for DRT binary in the wrong path on Mac
1842         https://bugs.webkit.org/show_bug.cgi?id=52678
1843         
1844         Update path now that WebKit is inside Source.
1845
1846         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1847
1848 2011-01-18  Robert Hogan  <robert@webkit.org>
1849
1850         Reviewed by Simon Hausmann.
1851
1852         [Qt] http/tests/incremental/slow-utf8-text.pl fails
1853         https://bugs.webkit.org/show_bug.cgi?id=44282
1854
1855         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1856         (WebCore::DumpRenderTree::dump):
1857
1858 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
1859
1860         Reviewed by Mihai Parparita.
1861
1862         Fix a small race condition that could cause the unit tests for
1863         new-run-webkit-tests to fail in a multithreaded environment.
1864         There was a small window in the code where one thread would
1865         check to see if a thread had raised an exception, do something,
1866         and then check to see if the thread was alive. If the other
1867         thread raised an exception and exited in between these two
1868         steps, the exception would be lost. Flipping the order of the
1869         two checks fixes the race, since we will now always check for an
1870         exception on the thread before exiting.
1871
1872         https://bugs.webkit.org/show_bug.cgi?id=51579
1873
1874         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
1875
1876 2011-01-18  Eric Seidel  <eric@webkit.org>
1877
1878         Reviewed by Adam Barth.
1879
1880         commit-queue dies when test archiving fails
1881         https://bugs.webkit.org/show_bug.cgi?id=52617
1882
1883         I looked at the machine and it had 10 archives already
1884         thus find_unused_name was returning None.  I've upped
1885         the limit to 100 (per bug) and tested the case where
1886         find_unused_name returns None (making archive return None).
1887
1888         * Scripts/webkitpy/common/system/workspace.py:
1889         * Scripts/webkitpy/common/system/workspace_unittest.py:
1890         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1891         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1892         * Scripts/webkitpy/tool/commands/queues.py:
1893
1894 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
1895
1896         Reviewed by Ojan Vafai.
1897
1898         Update rebaseline-chromium-webkit-tests unit tests to use a mock
1899         filesystem. Also fix a couple of "with" statements missed by
1900         r76050.
1901
1902         https://bugs.webkit.org/show_bug.cgi?id=52487
1903
1904         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
1905
1906 2011-01-18  Sergio Villar Senin  <svillar@igalia.com>
1907
1908         Reviewed by Martin Robinson.
1909
1910         [Gtk] Build fixes for gtk3 build
1911         https://bugs.webkit.org/show_bug.cgi?id=52648
1912
1913         * DumpRenderTree/gtk/EventSender.cpp:
1914         (beginDragWithFilesCallback):
1915
1916 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
1917
1918         Reviewed by Mihai Parparita.
1919
1920         Update rebaseline-chromium-webkit-tests to use filesystem objects
1921         instead of direct references to os.path, shutil, tempfile, etc.
1922
1923         This patch doesn't change anything, but will allow subsequent
1924         patches to change the unit tests to no longer use the real
1925         filesystem.
1926
1927         This patch adds a bunch more methods to the filesystem object as
1928         well.
1929
1930         https://bugs.webkit.org/show_bug.cgi?id=52482
1931
1932         * Scripts/webkitpy/common/system/filesystem.py:
1933         * Scripts/webkitpy/common/system/filesystem_mock.py:
1934         * Scripts/webkitpy/tool/commands/queues.py:
1935         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1936         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
1937
1938 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
1939
1940         Reviewed by Mihai Parparita.
1941
1942         new-run-webkit-tests shouldn't crash when you try to run a
1943         directory containing only skipped files.
1944
1945         https://bugs.webkit.org/show_bug.cgi?id=52478
1946         
1947         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1948         * Scripts/webkitpy/layout_tests/port/test.py:
1949         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1950
1951 2011-01-18  Adam Bergkvist  <adam.bergkvist@ericsson.com> and Martin Robinson  <mrobinson@igalia.com>
1952
1953         Reviewed by Gustavo Noronha Silva.
1954
1955         [GTK] The GTK+ EventSender needs support for beginDragWithFiles
1956         https://bugs.webkit.org/show_bug.cgi?id=40833
1957
1958         * DumpRenderTree/gtk/EventSender.cpp: Add a beginDragWithFiles implementation for the
1959         GTK+ event sender.
1960         (dragWithFilesDragDataGetCallback): Added.
1961         (dragWithFilesDragEndCallback): Added.
1962         (beginDragWithFilesCallback): Added.
1963
1964 2011-01-18  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1965
1966         Reviewed by Adam Barth.
1967
1968         ews: Add additional watcher to efl ews
1969         https://bugs.webkit.org/show_bug.cgi?id=52613
1970
1971         Add gyuyoung.kim@samsung.com to watcher list of efl-ews.
1972
1973         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1974
1975 2011-01-17  Tony Gentilcore  <tonyg@chromium.org>
1976
1977         Reviewed by Alexey Proskuryakov.
1978
1979         Fix some headers with missing or misspelled #ifndef guards
1980         https://bugs.webkit.org/show_bug.cgi?id=52545
1981
1982         * DumpRenderTree/chromium/TestEventPrinter.h:
1983         * DumpRenderTree/chromium/WebPreferences.h:
1984
1985 2011-01-17  Jessie Berlin  <jberlin@apple.com>
1986
1987         Reviewed by Anders Carlsson.
1988
1989         REGRESSION: Assertion failure in FrameLoader::continueLoadAfterWillSubmitForm() when
1990         navigating back to an unreachable URL
1991         https://bugs.webkit.org/show_bug.cgi?id=52388
1992
1993         Add a third parameter (unreachableURL) to queueLoadHTMLString.
1994
1995         * DumpRenderTree/LayoutTestController.cpp:
1996         (queueLoadHTMLStringCallback):
1997         (LayoutTestController::queueLoadHTMLString):
1998         (LayoutTestController::queueLoadAlternateHTMLString):
1999         * DumpRenderTree/LayoutTestController.h:
2000
2001         * DumpRenderTree/WorkQueueItem.h:
2002         (LoadHTMLStringItem::LoadHTMLStringItem):
2003
2004         * DumpRenderTree/chromium/LayoutTestController.cpp:
2005         (WorkItemLoadHTMLString::WorkItemLoadHTMLString):
2006         (WorkItemLoadHTMLString::run):
2007         (LayoutTestController::queueLoadHTMLString):
2008
2009         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
2010         (LoadHTMLStringItem::invoke):
2011         * DumpRenderTree/mac/WorkQueueItemMac.mm:
2012         (LoadHTMLStringItem::invoke):
2013         * DumpRenderTree/win/WorkQueueItemWin.cpp:
2014         (LoadHTMLStringItem::invoke):
2015
2016 2011-01-17  Dan Bernstein  <mitz@apple.com>
2017
2018         Rubber-stamped by Mark Rowe.
2019
2020         Update xcodeproj svn:ignore to include xcuserdata.
2021
2022         * DumpRenderTree/DumpRenderTree.xcodeproj: Modified property svn:ignore.
2023         * MiniBrowser/MiniBrowser.xcodeproj: Modified property svn:ignore.
2024         * TestWebKitAPI/TestWebKitAPI.xcodeproj: Modified property svn:ignore.
2025         * WebKitLauncher/WebKitLauncher.xcodeproj: Modified property svn:ignore.
2026         * WebKitTestRunner/WebKitTestRunner.xcodeproj: Modified property svn:ignore.
2027
2028 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
2029
2030         Unreviewed fix after r75908.
2031
2032         Move WebKit into Source
2033         https://bugs.webkit.org/show_bug.cgi?id=52530
2034
2035         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add Source to the path for Qt API tests.
2036
2037 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
2038
2039         Unreviewed.
2040
2041         Remove accidentally committed debug printing after r75908.
2042
2043         * Scripts/webkitdirs.pm:
2044
2045 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
2046
2047         Unreviewed.
2048
2049         Add myself to committers list
2050         https://bugs.webkit.org/show_bug.cgi?id=52566
2051
2052         * Scripts/webkitpy/common/config/committers.py:
2053
2054 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
2055
2056         Reviewed by Jeremy Orlow.
2057
2058         GeolocationController should call stopUpdating on destruction
2059         https://bugs.webkit.org/show_bug.cgi?id=52216
2060
2061         fast/dom/Geolocation/window-close-crash.html requires that a
2062         Geolocation watch be started in a secondary window. Consequently,
2063         we need to allow geolocation permission and provide a mock
2064         geolocation position for the secondary window's
2065         GeolocationClientMock.
2066
2067         * DumpRenderTree/chromium/LayoutTestController.cpp:
2068         (LayoutTestController::setGeolocationPermission):
2069         (LayoutTestController::setMockGeolocationPosition):
2070         (LayoutTestController::setMockGeolocationError):
2071         * DumpRenderTree/chromium/TestShell.h:
2072         (TestShell::windowList):
2073
2074 2011-01-16  Adam Barth  <abarth@webkit.org>
2075
2076         Update more include paths to reflect WebKit move.
2077
2078         * DumpRenderTree/chromium/EventSender.cpp:
2079         (EventSender::keyDown):
2080         (EventSender::needsShiftModifier):
2081         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
2082         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
2083
2084 2011-01-16  Kent Tamura  <tkent@chromium.org>
2085
2086         Unreviewed, Chromium build fix.
2087
2088         * Scripts/update-webkit-chromium: Webkit/chromium -> Source/WebKit/chromium
2089
2090 2011-01-16  Martin Robinson  <mrobinson@igalia.com>
2091
2092         Build fix for GTK+ after source directory movement.
2093
2094         * GNUmakefile.am: Correct include paths.
2095
2096 2011-01-16  Adam Barth  <abarth@webkit.org>
2097
2098         Teach svn-apply about WebKit move.
2099
2100         * Scripts/VCSUtils.pm:
2101
2102 2011-01-16  Adam Barth  <abarth@webkit.org>
2103
2104         Rubber-stamped by Eric Seidel.
2105
2106         Move WebKit into Source
2107         https://bugs.webkit.org/show_bug.cgi?id=52530
2108
2109         * DumpRenderTree/mac/InternalHeaders/WebKit/WebTypesInternal.h:
2110         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2111         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2112         * DumpRenderTree/qt/GCControllerQt.cpp:
2113         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2114         * DumpRenderTree/qt/PlainTextControllerQt.cpp:
2115         * DumpRenderTree/qt/TextInputControllerQt.cpp:
2116         * DumpRenderTree/wscript:
2117         * QtTestBrowser/launcherwindow.h:
2118         * Scripts/build-webkit:
2119         * Scripts/webkitdirs.pm:
2120
2121 2011-01-15  Adam Barth  <abarth@webkit.org>
2122
2123         Teach svn-apply about WebKit2 move.
2124
2125         * Scripts/VCSUtils.pm:
2126
2127 2011-01-15  Adam Barth  <abarth@webkit.org>
2128
2129         Rubber-stamped by Eric Seidel.
2130
2131         Move WebKit2 into Source
2132         https://bugs.webkit.org/show_bug.cgi?id=52438
2133
2134         * MiniBrowser/qt/MiniBrowser.pro:
2135         * Scripts/build-webkit:
2136         * Scripts/do-file-rename:
2137         * Scripts/do-webcore-rename:
2138         * Scripts/test-webkitpy:
2139         * Scripts/webkitdirs.pm:
2140         * Scripts/webkitpy/style/checker.py:
2141         * WebKitTestRunner/DerivedSources.pro:
2142         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2143         * WebKitTestRunner/qt/WebKitTestRunner.pro:
2144
2145 2011-01-15  Jochen Eisinger  <jochen@chromium.org>
2146
2147         Reviewed by David Levin.
2148
2149         [chromium] remove obsolete createView method
2150         https://bugs.webkit.org/show_bug.cgi?id=52437
2151
2152         * DumpRenderTree/chromium/WebViewHost.cpp:
2153         (WebViewHost::createView):
2154         * DumpRenderTree/chromium/WebViewHost.h:
2155
2156 2011-01-14  Brian Weinstein  <bweinstein@apple.com>
2157
2158         Reviewed by Geoff Garen.
2159
2160         ShouldLoadResourceForFrame should use strings, not URLs.
2161         https://bugs.webkit.org/show_bug.cgi?id=52476
2162
2163         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2164         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Update to use a WKStringRef.
2165         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2166
2167 2011-01-14  Tony Gentilcore  <tonyg@chromium.org>
2168
2169         Reviewed by David Levin.
2170
2171         Add Tony Gentilcore as a reviewer
2172         https://bugs.webkit.org/show_bug.cgi?id=52480
2173
2174         * Scripts/webkitpy/common/config/committers.py:
2175
2176 2011-01-14  David Levin  <levin@chromium.org>
2177
2178         Reviewed by Eric Seidel.
2179
2180         check-webkit-style: _FunctionState should keep track of where the function name starts.
2181         https://bugs.webkit.org/show_bug.cgi?id=52454
2182
2183         * Scripts/webkitpy/style/checkers/cpp.py: Added function_name_start_position to
2184         _FunctionState and logic for setting it correctly.
2185         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests.
2186
2187 2011-01-14  Vincent Scheib  <scheib@chromium.org>
2188
2189         Reviewed by David Levin.
2190
2191         Add support to DumpRenderTree to use the GPU rather than software renderer
2192         https://bugs.webkit.org/show_bug.cgi?id=52333
2193
2194         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2195         (main):
2196         * Scripts/webkitpy/layout_tests/port/chromium.py:
2197         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2198
2199 2011-01-14  Tony Chang  <tony@chromium.org>
2200
2201         Reviewed by Kent Tamura.
2202
2203         [chromium] update fonts.conf to fix 6 linux tests in drt
2204         https://bugs.webkit.org/show_bug.cgi?id=52411
2205
2206         * DumpRenderTree/chromium/fonts.conf: Update to match the copy in
2207             chromium's src/webkit/tools/test_shell/resources/fonts.conf
2208
2209 2011-01-14  Eric Seidel  <eric@webkit.org>
2210
2211         Original patch from Peter Gal  <galpater@inf.u-szeged.hu>
2212
2213         Reviewed by Adam Barth.
2214
2215         Fix when running Tools/Scripts/check-webkit-style without arguments.
2216         https://bugs.webkit.org/show_bug.cgi?id=52261#c16
2217
2218         * Scripts/webkitpy/common/checkout/scm.py: Handle None for changed_files argument better in Git.create_patch method.
2219         * Scripts/webkitpy/common/checkout/scm_unittest.py:
2220
2221 2011-01-04  Jochen Eisinger  <jochen@chromium.org>
2222
2223         Reviewed by David Levin.
2224
2225         Store the tempdir object in a variable so it doesn't get deleted too early.
2226         https://bugs.webkit.org/show_bug.cgi?id=51875
2227
2228         * Scripts/update-webkit-auxiliary-libs:
2229         * Scripts/update-webkit-support-libs:
2230
2231 2011-01-14  Eric Seidel  <eric@webkit.org>
2232
2233         Unreviewed.  Make it work in python 2.5.
2234
2235         webkit-patch suggest-reviewers dies when ChangeLogs are missing
2236         https://bugs.webkit.org/show_bug.cgi?id=49158
2237
2238         * Scripts/webkitpy/common/checkout/api_unittest.py:
2239
2240 2011-01-14  Sheriff Bot  <webkit.review.bot@gmail.com>
2241
2242         Unreviewed, rolling out r75774.
2243         http://trac.webkit.org/changeset/75774
2244         https://bugs.webkit.org/show_bug.cgi?id=52431
2245
2246         gtk builds were broken (Requested by loislo2 on #webkit).
2247
2248         * Scripts/webkitpy/common/checkout/scm.py:
2249
2250 2011-01-14  David Levin  <levin@chromium.org>
2251
2252         Reviewed by Shinichiro Hamaji.
2253
2254         check-webkit-style: _FunctionState should detect pure functions.
2255         https://bugs.webkit.org/show_bug.cgi?id=52428
2256
2257         * Scripts/webkitpy/style/checkers/cpp.py: Added detection for if a function declaration
2258         is a pure virtual function.
2259         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests for verifying that pure
2260         virtual functions are correctly detected.
2261
2262 2011-01-13  Ilya Tikhonovsky  <loislo@chromium.org>
2263
2264         Reviewed by Yury Semikhatsky.
2265
2266         Just small fix for problem with check-webkit-style.
2267         It just didn't work for this patch.
2268         Old code can't concatenate a list of strings with None.
2269
2270         * Scripts/webkitpy/common/checkout/scm.py:
2271
2272 2011-01-13  David Levin  <levin@chromium.org>
2273
2274         Reviewed by Shinichiro Hamaji.
2275
2276         check-webkit-style: _FunctionState should use Position to know where items are.
2277         https://bugs.webkit.org/show_bug.cgi?id=52424
2278
2279         * Scripts/webkitpy/style/checkers/cpp.py:
2280         (_FunctionState.*): Changed _FunctionState to use Position instead of line numbers.
2281         (detect_functions): Changed to pass Position's to _FunctionState.begin and
2282         did some minor clean-up.
2283         (*): Other changes are simply about converting to use the Position's in_FunctionState
2284         instead of line numbers.
2285         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Changed the test code
2286         to verify the positions stored in _FunctionState.
2287
2288 2011-01-13  Eric Seidel  <eric@webkit.org>
2289
2290         Reviewed by David Levin.
2291
2292         webkit-patch suggest-reviewers dies when ChangeLogs are missing
2293         https://bugs.webkit.org/show_bug.cgi?id=49158
2294
2295         This is not the most elegant, but it is a very safe fix to this bug.
2296         One advantage of catching ScriptError like this instead of adding a
2297         new added_or_modified_files or fixing all changed_files callers
2298         to use a more specific change_files variant, is that we catch
2299         all kinds of ScriptErrors which might cause our (non-essential)
2300         suggest-reviewers code to fail out.  This should make passing
2301         --suggest-reviewers to webkit-patch upload much more robust
2302         and may even make it possible for us to make it default.
2303
2304         The root of the problem here is that SCM.changed_files includes
2305         deleted ChangeLog paths (from moves, etc) which then when we ask
2306         SVN/Git for the contents of the file at that revision, the command
2307         errors out and Executive.run_command raises a ScriptError.
2308
2309         In the future we might fix this differently by making all current
2310         callers of chagned_files use a more specific method for requesting
2311         what types of changes they're interested in (adds, modifies, deletes, etc.)
2312
2313         * Scripts/webkitpy/common/checkout/api.py:
2314         * Scripts/webkitpy/common/checkout/api_unittest.py:
2315
2316 2011-01-13  Dan Bernstein  <mitz@apple.com>
2317
2318         Reviewed by Alexey Proskuryakov.
2319
2320         <rdar://problem/8827065> REGRESSION (r71884): Cross-origin XHR fails if willSendRequest changes the URL
2321         https://bugs.webkit.org/show_bug.cgi?id=52419
2322
2323         Allow to further control the behavior of the willSendRequest delegate callback by making it
2324         set a different URL in the new request.
2325
2326         * DumpRenderTree/LayoutTestController.cpp:
2327         (addURLToRedirectCallback): Added.
2328         (LayoutTestController::staticFunctions): Added addURLToRedirect.
2329         (LayoutTestController::addURLToRedirect): Added. Adds the redirection to the map.
2330         (LayoutTestController::redirectionDestinationForURL): Added this getter.
2331         * DumpRenderTree/LayoutTestController.h:
2332         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2333         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]): Check
2334         if there is a redirection for the request’s URL, established by addURLToRedirect(), and if so,
2335         change the URL in the new request to the redirect destination.
2336
2337 2011-01-13  Eric Seidel  <eric@webkit.org>
2338
2339         Reviewed by Mihai Parparita.
2340
2341         webkit-patch suggest-reviewers fails due to invalid utf8 in ChangeLog files
2342         https://bugs.webkit.org/show_bug.cgi?id=52416
2343
2344         Example: webkit-patch suggest-reviewers -g ca3890fe74d94d85d6bfa48f9ea497b094d8e717 
2345         UnicodeDecodeError: 'utf8' codec can't decode bytes in position 536-538: invalid data
2346
2347         I also added FIXMEs about the changed_files returning deleted files problem
2348         which is causing the other most common exception for suggest-reviewers
2349         (and is probably breaking sheriff-bots blame detection).
2350
2351         * Scripts/webkitpy/common/checkout/api.py:
2352         * Scripts/webkitpy/common/checkout/api_unittest.py:
2353         * Scripts/webkitpy/common/checkout/scm.py:
2354
2355 2011-01-13  Eric Seidel  <eric@webkit.org>
2356
2357         Reviewed by Adam Barth.
2358
2359         results archives from commit-queue are too large to upload
2360         https://bugs.webkit.org/show_bug.cgi?id=52405
2361
2362         * Scripts/webkitpy/common/system/filesystem.py:
2363         * Scripts/webkitpy/common/system/filesystem_mock.py:
2364         * Scripts/webkitpy/tool/commands/queues.py:
2365
2366 2011-01-13  Alejandro G. Castro  <alex@igalia.com>
2367
2368         Reviewed by Martin Robinson.
2369
2370         [gtk] Zero-sized font does not yet work
2371         https://bugs.webkit.org/show_bug.cgi?id=49793
2372
2373         Set minimum-font-size to 0 for the DRT.
2374
2375         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2376         (resetDefaultsToConsistentValues):
2377
2378 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
2379
2380         Reviewed by Darin Adler.
2381
2382         Make old-run-webkit-tests more robust on buildbots
2383         https://bugs.webkit.org/show_bug.cgi?id=52364
2384
2385         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Pass --exit-after-n-failures 500 to old-run-webkit-tests script.
2386
2387 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
2388
2389         Reviewed by Darin Adler.
2390
2391         Make old-run-webkit-tests more robust on buildbots
2392         https://bugs.webkit.org/show_bug.cgi?id=52364
2393
2394         * Scripts/old-run-webkit-tests: Ensure that testResultsDirectory is empty.
2395
2396 2011-01-13  Tony Chang  <tony@chromium.org>
2397
2398         Reviewed by Kent Tamura.
2399
2400         [chromium] fix plugins/plugin-javascript-access.html on Linux and Mac
2401         https://bugs.webkit.org/show_bug.cgi?id=52332
2402
2403         Forked Info.plist is not longer needed.
2404
2405         * DumpRenderTree/chromium/TestNetscapePlugIn/Info.plist: Removed.
2406
2407 2011-01-13  Mikhail Naganov  <mnaganov@chromium.org>
2408
2409         Reviewed by Timothy Hatcher.
2410
2411         Web Inspector: Cleanup after r75613 -- make all UI-facing strings
2412         to be passed directly to WebInspector.UIString
2413
2414         https://bugs.webkit.org/show_bug.cgi?id=52365
2415
2416         * Scripts/check-inspector-strings:
2417
2418 2011-01-13  Sheriff Bot  <webkit.review.bot@gmail.com>
2419
2420         Unreviewed, rolling out r74881.
2421         http://trac.webkit.org/changeset/74881
2422         https://bugs.webkit.org/show_bug.cgi?id=52357
2423
2424         The EFL builder has been red for days (Requested by abarth on
2425         #webkit).
2426
2427         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2428         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2429
2430 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
2431
2432         Reviewed by David Levin.
2433
2434         Add beforeunload support to WebKitTestRunner
2435         https://bugs.webkit.org/show_bug.cgi?id=52353
2436         
2437         This makes a number of currently failing tests pass.
2438
2439         * WebKitTestRunner/TestController.cpp:
2440         (WTR::runBeforeUnloadConfirmPanel):
2441         (WTR::createOtherPage):
2442         (WTR::TestController::initialize):
2443
2444 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
2445
2446         Reviewed by Sam Weinig.
2447
2448         Detect, identify and recover from WebProcess crashes in run-webkit-tests
2449         https://bugs.webkit.org/show_bug.cgi?id=52330
2450
2451         * Scripts/old-run-webkit-tests: Detect when the regression test tool reports
2452         a web process crash.
2453         * WebKitTestRunner/TestController.cpp:
2454         (WTR::TestController::initialize): Set up a processDidCrash
2455         callback.
2456         (WTR::TestController::processDidCrash): Report that the Web process
2457         crashed.
2458         * WebKitTestRunner/TestController.h:
2459
2460 2011-01-12  David Levin  <levin@chromium.org>
2461
2462         Reviewed by Shinichiro Hamaji.
2463
2464         check-webkit-style -- close_expression function doesn't work correctly.
2465         https://bugs.webkit.org/show_bug.cgi?id=52272
2466
2467         * Scripts/webkitpy/style/checkers/cpp.py:
2468         (Position.__str__): Added a way to convert it to a string which is useful in tests.
2469         (Position.__cmp__): Added a way to compare Position which is useful in tests and
2470         generally useful (for upcoming code changes).
2471         (close_expression): Changed to use Position for input and output.
2472         Also, fixed many bugs such as only working correctly for parenthesis,
2473         not working correctly if given an offset in a line and not finding
2474         the real closing element if there were multiple closing elements in
2475         the same line.
2476         (detect_functions): Adjusted due to the change in arguments for
2477         close_expression.
2478         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2479         (CppStyleTestBase.assert_positions_equal): Added a way to verify that
2480         two positions are the same.
2481         (CppStyleTest.test_position): Added tests for the __str_ and __cmp__ methods.
2482         (CppStyleTest.test_close_expression): Added tests to catch the issues
2483         that were fixed.
2484
2485 2011-01-12  Sheriff Bot  <webkit.review.bot@gmail.com>
2486
2487         Unreviewed, rolling out r75576.
2488         http://trac.webkit.org/changeset/75576
2489         https://bugs.webkit.org/show_bug.cgi?id=52304
2490
2491         broke rebaseline-chromium-webkit-test (Requested by thakis on
2492         #webkit).
2493
2494         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2495         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2496         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
2497         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2498         * Scripts/webkitpy/layout_tests/port/base.py:
2499         * Scripts/webkitpy/layout_tests/port/chromium.py:
2500         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2501         * Scripts/webkitpy/layout_tests/port/test.py:
2502         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2503         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2504         * Scripts/webkitpy/style/checkers/test_expectations.py:
2505         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
2506
2507 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
2508
2509         Reviewed by Darin Adler.
2510
2511         Add a no-build option to run-webkit-tests, to avoid building DRT/WKTR
2512         https://bugs.webkit.org/show_bug.cgi?id=52307
2513
2514         * Scripts/old-run-webkit-tests:
2515
2516 2011-01-12  Koan-Sin Tan  <koansin.tan@gmail.com>
2517
2518         Reviewed by Martin Robinson.
2519
2520         [Gtk] WebKitGtk+ doesn't build on Mac OS X 10.6
2521         https://bugs.webkit.org/show_bug.cgi?id=50867
2522
2523         Fixed library extention for Mac in webkitdirs.pm and type conflict in
2524         TestNetscapePlugin.cpp 
2525
2526         * GNUmakefile.am: Don't use AppKit when compiling TestNetscapePlugin for GTK+
2527         * Scripts/webkitdirs.pm:
2528
2529 2011-01-12  Mikhail Naganov  <mnaganov@chromium.org>
2530
2531         Reviewed by Pavel Feldman.
2532
2533         Add check-inspector-strings script.
2534
2535         https://bugs.webkit.org/show_bug.cgi?id=52295
2536
2537         * Scripts/check-inspector-strings: Added.
2538
2539 2011-01-12  Adam Roben  <aroben@apple.com>
2540
2541         Advertise the .testnetscape file extension on Windows
2542
2543         Fixes <http://webkit.org/b/52298>
2544         plugins/no-mime-with-valid-extension.html fails on Windows
2545
2546         Reviewed by Dan Bernstein.
2547
2548         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Added a
2549         FileExtents field to map the .testnetscape file extension to the
2550         application/x-webkit-test-netscape MIME type, just as we do on Mac.
2551
2552 2011-01-12  Adam Barth  <abarth@webkit.org>
2553
2554         Reviewed by Eric Seidel.
2555
2556         Make webkit-patch support subdirectories for SVN checkouts
2557         https://bugs.webkit.org/show_bug.cgi?id=52261
2558
2559         os.relpath does not exist on Python 2.5, so we need to call our version
2560         of the API.
2561
2562         * Scripts/webkitpy/common/checkout/scm.py:
2563
2564 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
2565
2566         Reviewed by Eric Seidel.
2567
2568         Close additional pages opened during a test once the test completes.
2569         https://bugs.webkit.org/show_bug.cgi?id=52276
2570
2571         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2572         (WTR::InjectedBundle::done):
2573
2574 2011-01-11  David Levin  <levin@chromium.org>
2575
2576         Reviewed by Eric Seidel.
2577
2578         Errors should be separated from the command line in bot messages.
2579         https://bugs.webkit.org/show_bug.cgi?id=52275
2580
2581         * Scripts/webkitpy/common/system/executive.py:
2582         (ScriptError.message_with_output): Added a newline to separate the command
2583         line from the errors.
2584         * Scripts/webkitpy/common/system/executive_unittest.py:
2585         (ScriptErrorTest.test_message_with_output): Added tests for the various code
2586         paths in message_with_output.
2587
2588 2011-01-11  Eric Seidel  <eric@webkit.org>
2589
2590         Unreviewed.
2591
2592         commit-queue should know how to upload archived results (for test flakes or general failures)
2593         https://bugs.webkit.org/show_bug.cgi?id=52048
2594
2595         The zips are mostly empty due to forgetting -r.
2596         Expected diffs were not being pulled from the archive due
2597         to the archive having longer paths than I realized.
2598
2599         * Scripts/webkitpy/common/system/workspace.py:
2600         * Scripts/webkitpy/common/system/workspace_unittest.py:
2601         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2602         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2603
2604 2011-01-11  Dirk Pranke  <dpranke@chromium.org>
2605
2606         Reviewed by Ojan Vafai.
2607
2608         The current modifier parsing code in test_expectations is
2609         fragile and hard-coded, so it's not easy to understand the logic
2610         or easily add new types of modifiers (like GPU vs. CPU testing
2611         for graphics tests, or 32-bit vs. 64-bit differences).
2612
2613         This is the first of two patches that will add in more generic
2614         support and then eliminate the GPU-specific test expectations
2615         files for Chromium.
2616
2617         This patch adds two standalone objects for handling modifiers. The
2618         rules for interpreting modifiers, precedence, and conflicts are
2619         given in the docstring to the ModifierMatcher class, which
2620         returns ModifierMatchResult objects.
2621         
2622         This patch also adds routines to the Port interface and a
2623         default set of values in the base object, in order to obtain the
2624         values needed on a given test run. These values are then passed
2625         to the expectation parser. This also allows us to clean up the
2626         logic used to lint all of the different configurations in a
2627         single test_expectations.txt file.
2628
2629         The next patch will merge in the separate GPU expectations file.
2630
2631         https://bugs.webkit.org/show_bug.cgi?id=51222
2632
2633         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2634         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2635         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
2636         * Scripts/webkitpy/layout_tests/port/base.py:
2637         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2638         * Scripts/webkitpy/layout_tests/port/chromium.py:
2639         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2640         * Scripts/webkitpy/layout_tests/port/test.py:
2641         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2642         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2643
2644 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
2645
2646         Reviewed by Adam Barth.
2647
2648         Make webkit-patch support subdirectories for SVN checkouts
2649         https://bugs.webkit.org/show_bug.cgi?id=52261
2650
2651         * Scripts/webkitpy/common/checkout/scm.py:
2652         * Scripts/webkitpy/style_references.py:
2653         * Scripts/webkitpy/tool/main.py:
2654         * Scripts/webkitpy/tool/steps/preparechangelog.py:
2655
2656 2011-01-11  Eric Seidel  <eric@webkit.org>
2657
2658         Unreviewed.
2659
2660         commit-queue should know how to upload archived results (for test flakes or general failures)
2661         https://bugs.webkit.org/show_bug.cgi?id=52048
2662
2663         I changed the API for archive_last_layout_test_results w/o updating the implementation.  Oops.
2664         This fixes an exception seen on the commit-queue when attempting to report flaky tests.
2665
2666         * Scripts/webkitpy/common/system/workspace.py:
2667         * Scripts/webkitpy/common/system/workspace_unittest.py:
2668         * Scripts/webkitpy/tool/commands/queues.py:
2669
2670 2011-01-11  Sam Weinig  <sam@webkit.org>
2671
2672         Roll r75474 back in.
2673
2674 2011-01-11  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
2675
2676         Reviewed by Kenneth Rohde Christiansen.
2677
2678         [Qt] Remove uses of QFuture since it isn't supported on all platforms.
2679         https://bugs.webkit.org/show_bug.cgi?id=51204
2680
2681         * QtTestBrowser/webpage.h:
2682         (QtNAMThread::QtNAMThread):
2683         (QtNAMThread::networkAccessManager):
2684         (QtNAMThread::run):
2685
2686 2011-01-11  Peter Varga  <pvarga@webkit.org>
2687
2688         Unreviewed.
2689
2690         Add myself to committers' list.
2691
2692         * Scripts/webkitpy/common/config/committers.py:
2693
2694 2011-01-11  Eric Seidel  <eric@webkit.org>
2695
2696         Reviewed by Adam Barth.
2697
2698         commit-queue should know how to upload archived results (for test flakes or general failures)
2699         https://bugs.webkit.org/show_bug.cgi?id=52048
2700
2701         Now the queue will always upload results.  Either the entire zip, or just
2702         the diffs.txt in the case of text failures.
2703
2704         This should make understanding flakes much easier, and paves the way
2705         for having the EWS run layout tests (and upload failures).
2706
2707         In order to upload .zip files I had to teach bugzilla.py to autodetect
2708         mime types from the filename.  Since mimetypes.py doesn't include a mapping
2709         for .patch files, I have it add one before calling guess_type.
2710
2711         We may find that always uploading the whole zip instead of just the -diffs.txt
2712         file is preferable, but for now I'm keeping the old behavior because it makes
2713         quickly understanding text failures easy.
2714
2715         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2716         * Scripts/webkitpy/common/system/workspace.py: Added.
2717         * Scripts/webkitpy/common/system/workspace_unittest.py: Added.
2718         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2719         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2720         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2721         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2722         * Scripts/webkitpy/tool/commands/queues.py:
2723         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2724
2725 2011-01-10  Sheriff Bot  <webkit.review.bot@gmail.com>
2726
2727         Unreviewed, rolling out r75464.
2728         http://trac.webkit.org/changeset/75464
2729         https://bugs.webkit.org/show_bug.cgi?id=52193
2730
2731         Followup rollout for 75474 (Requested by Ossy on #webkit).
2732
2733         * MiniBrowser/mac/BrowserWindowController.m:
2734         (-[BrowserWindowController awakeFromNib]):
2735         * MiniBrowser/win/BrowserView.cpp:
2736         (BrowserView::create):
2737         * WebKitTestRunner/TestController.cpp:
2738         (WTR::createOtherPage):
2739         (WTR::TestController::initialize):
2740
2741 2011-01-10  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2742
2743         Reviewed by Csaba Osztrogonác.
2744
2745         [Qt] Baseline qt_minimal configuration
2746         https://bugs.webkit.org/show_bug.cgi?id=51313
2747
2748         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2749         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): Add
2750         QT_NO_UNDOSTACK guard.
2751
2752         * QtTestBrowser/launcherwindow.cpp:
2753         (LauncherWindow::createChrome): Add QT_NO_SHORTCUT and QT_NO_PRINTER
2754         guards.
2755         (LauncherWindow::applyZoom): Add QT_NO_ANIMATION guard.
2756         (LauncherWindow::screenshot): Add QT_NO_FILEDIALOG guard.
2757         (LauncherWindow::selectElements): Add QT_NO_INPUTDIALOG guard.
2758         (LauncherWindow::showUserAgentDialog): Add QT_NO_COMBOBOX guard.
2759
2760         * QtTestBrowser/launcherwindow.h:
2761         * QtTestBrowser/locationedit.cpp: Add QT_NO_INPUTDIALOG guard.
2762         * QtTestBrowser/locationedit.h: Ditto.
2763
2764         * QtTestBrowser/mainwindow.cpp:
2765         (MainWindow::buildUI): Add QT_NO_INPUTDIALOG, QT_NO_SHORTCUT and
2766         QT_NO_UNDOSTACK guards.
2767         (MainWindow::setAddressUrl): Add QT_NO_INPUTDIALOG guard.
2768         (MainWindow::changeLocation): Ditto.
2769         (MainWindow::openFile): Add QT_NO_FILEDIALOG guard.
2770         (MainWindow::openLocation): Add QT_NO_INPUTDIALOG guard.
2771
2772         * QtTestBrowser/webpage.cpp:
2773         (WebPage::openUrlInDefaultBrowser): Add QT_NO_DESKTOPSERVICES guard.
2774         (WebPage::authenticationRequired): Add QT_NO_LINEEDIT guard.
2775
2776         * QtTestBrowser/webview.cpp:
2777         (WebViewGraphicsBased::animatedFlip): Add QT_NO_ANIMATION guard.
2778         (WebViewGraphicsBased::animatedYFlip): Ditto.
2779
2780 2011-01-10  Sam Weinig  <sam@webkit.org>
2781
2782         Fix build.
2783
2784         * MiniBrowser/mac/BrowserWindowController.m:
2785         (-[BrowserWindowController awakeFromNib]):
2786         * MiniBrowser/win/BrowserView.cpp:
2787         (BrowserView::create):
2788         * WebKitTestRunner/TestController.cpp:
2789         (WTR::createOtherPage):
2790         (WTR::TestController::initialize):
2791
2792 2011-01-10  Eric Seidel  <eric@webkit.org>
2793
2794         Reviewed by Ojan Vafai.
2795
2796         style-queue messages are way too long for big patches
2797         https://bugs.webkit.org/show_bug.cgi?id=52161
2798
2799         We definitely could build much fancier list-to-string-with-limit functions
2800         but this should be sufficient for our needs at the moment.
2801
2802         * Scripts/webkitpy/common/system/executive.py:
2803         * Scripts/webkitpy/common/system/executive_unittest.py:
2804
2805 2011-01-10  Tony Chang  <tony@chromium.org>
2806
2807         Unreviewed, rolling out r75398.
2808         http://trac.webkit.org/changeset/75398
2809         https://bugs.webkit.org/show_bug.cgi?id=52008
2810
2811         Some layout tests are crashing on Chromium Win.
2812
2813         * DumpRenderTree/chromium/WebViewHost.cpp:
2814         (WebViewHost::updatePaintRect):
2815         * DumpRenderTree/chromium/WebViewHost.h:
2816
2817 2011-01-10  Adam Roben  <aroben@apple.com>
2818
2819         Roll out r75392
2820
2821         It isn't needed now that r75289 has been rolled out.
2822
2823         * Scripts/run-javascriptcore-tests:
2824
2825 2011-01-10  Maciej Stachowiak  <mjs@apple.com>
2826
2827         Reviewed by Anders Carlsson.
2828
2829         WebKitTestRunner uses crazy amounts of CPU, making layout tests slow and flaky
2830         https://bugs.webkit.org/show_bug.cgi?id=52160
2831
2832         * WebKitTestRunner/mac/TestControllerMac.mm:
2833         (WTR::TestController::platformRunUntil): Instead of busy-looping, wait for the timeout.
2834         Anything that can make runUntil() conditions turn true will happen on a run loop cycle
2835         anyway.
2836
2837 2011-01-10  Tony Chang  <tony@chromium.org>
2838
2839         Reviewed by Mihai Parparita.
2840
2841         [chromium] fix for animated gif layout tests
2842         https://bugs.webkit.org/show_bug.cgi?id=52008
2843
2844         * DumpRenderTree/chromium/WebViewHost.cpp: Schedule a paint when we update the paint rect
2845             to trigger gif animations.
2846         (WebViewHostPaintTask::WebViewHostPaintTask):
2847         (WebViewHostPaintTask::runIfValid):
2848         (WebViewHost::updatePaintRect):
2849         * DumpRenderTree/chromium/WebViewHost.h:
2850         (WebViewHost::taskList):
2851
2852 2011-01-10  Alejandro G. Castro  <alex@igalia.com>
2853
2854         Reviewed by Xan Lopez.
2855
2856         [GTK] Fix gtk2 compilation for master
2857         https://bugs.webkit.org/show_bug.cgi?id=51885
2858
2859         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
2860         (createBitmapContextFromWebView): Replaced the old
2861         gdk_drawable_get_size with gdk_pixmap_get_size.
2862
2863 2011-01-10  Patrick Gansterer  <paroga@webkit.org>
2864
2865         Reviewed by Laszlo Gombos.
2866
2867         [WINCE] Reenable NPAPI after r75203
2868         https://bugs.webkit.org/show_bug.cgi?id=52109
2869
2870         Remove the !isWinCE() check for ENABLE_NETSCAPE_PLUGIN_API and replace
2871         it with !isEfl(), because EFL port does not support NPAPI (yet).
2872
2873         * Scripts/build-webkit:
2874
2875 2011-01-10  Adam Roben  <aroben@apple.com>
2876
2877         Skip some asserting JS tests
2878
2879         See <http://webkit.org/b/52156>.
2880
2881         * Scripts/run-javascriptcore-tests:
2882
2883 2011-01-10  Martin Robinson  <mrobinson@igalia.com>
2884
2885         Reviewed by Xan Lopez.
2886
2887         [GTK] build-webkit disable Blob support via arguments passed to automake
2888         https://bugs.webkit.org/show_bug.cgi?id=52097
2889
2890         * Scripts/build-webkit: Enable Blob support when building WebKitGTK+ via
2891         build-webkit.
2892
2893 2011-01-10  Adam Roben  <aroben@apple.com>
2894
2895         Use the same name and description for TestNetscapePlugin on Windows and
2896         Mac
2897
2898         Fixes <http://webkit.org/b/52151>
2899         fast/frames/iframe-reparenting-plugins.html fails on Windows
2900
2901         Reviewed by Steve Falkenburg.
2902
2903         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Copied
2904         the name and description from Mac's Info.plist.
2905
2906 2011-01-10  Siddharth Mathur <siddharth.mathur@nokia.com>
2907
2908         Reviewed by Laszlo Gombos.
2909
2910         [Qt][WK2] Guard gcc-specific syntax
2911
2912         Non-gcc based compliers choke on the "-include"
2913         syntax for preinclude, place guard around it.
2914
2915         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2916         * WebKitTestRunner/qt/WebKitTestRunner.pro:
2917
2918 2011-01-10  Andreas Kling  <kling@webkit.org>
2919
2920         Reviewed by Simon Hausmann.
2921
2922         [Qt] [WK2] MiniBrowser does not load pages opened in new windows
2923         https://bugs.webkit.org/show_bug.cgi?id=52111
2924
2925         When getting a createNewPage() callback from QWKPage, create the
2926         new page with the same QWKContext as the page that is passed to
2927         the callback.
2928
2929         * MiniBrowser/qt/BrowserView.h:
2930         * MiniBrowser/qt/BrowserWindow.cpp:
2931         (newPageFunction):
2932         (BrowserWindow::BrowserWindow):
2933         * MiniBrowser/qt/BrowserWindow.h:
2934
2935 2011-01-10  Andreas Kling  <kling@webkit.org>
2936
2937         Reviewed by Kenneth Rohde Christiansen.
2938
2939         [Qt] MiniBrowser: Remove superfluous createNewPage() callback
2940
2941         BrowserView set its own useless createNewPage() callback on QWKPage.
2942         This was immediately overridden by BrowserWindow anyway, so remove
2943         the BrowserView one.
2944
2945         * MiniBrowser/qt/BrowserView.cpp:
2946         (BrowserView::BrowserView):
2947
2948 2011-01-10  John Knottenbelt  <jknotten@chromium.org>
2949
2950         Reviewed by Jeremy Orlow.
2951
2952         [Chromium] Remove non-client-based Geolocation code
2953         https://bugs.webkit.org/show_bug.cgi?id=50921
2954
2955         * DumpRenderTree/chromium/LayoutTestController.cpp:
2956         (LayoutTestController::setGeolocationPermission):
2957         (LayoutTestController::setMockGeolocationPosition):
2958         (LayoutTestController::setMockGeolocationError):
2959         * DumpRenderTree/chromium/WebViewHost.cpp:
2960         (WebViewHost::geolocationClientMock):
2961         (WebViewHost::reset):
2962         * DumpRenderTree/chromium/WebViewHost.h:
2963
2964 2011-01-10  Eric Seidel  <eric@webkit.org>
2965
2966         Reviewed by Adam Barth.
2967
2968         Commit bot tried to land r? cq+ patch
2969         https://bugs.webkit.org/show_bug.cgi?id=36638
2970
2971         It should now be possible to post a patch with r? and cq+ and the
2972         commit-queue will correctly wait for the r+ before attempting to land the patch.
2973         (This was a feature requested by several users.)
2974
2975         One caveat: We don't actually reject r-, cq+ patches from the queue
2976         (we just ignore them), but I think that's OK for now.
2977
2978         I also noticed that setting r- once a commit-queue node had grabbed
2979         a patch would not properly cancel the landing.  That's fixed and
2980         tested in this patch.
2981
2982         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2983         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2984         * Scripts/webkitpy/tool/bot/feeders.py:
2985         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
2986
2987 2011-01-08  Benjamin Poulain  <benjamin.poulain@nokia.com>
2988
2989         Reviewed by Kenneth Rohde Christiansen.
2990
2991         [Qt] QtWebKit crashes when using XMLHttpRequest from the unload event
2992         https://bugs.webkit.org/show_bug.cgi?id=51934
2993
2994         When accessing the network from the destructor of QWebPage, the network access manager
2995         was already deleted because the object WebPage was already destructed.
2996
2997         This solve the problem by linking the lifetime of the network access manager to WebPage's QObject.
2998         The object is now destructed in the destructor of QObject.
2999
3000         * QtTestBrowser/webpage.cpp:
3001         (WebPage::WebPage):
3002         (WebPage::setQnamThreaded):
3003         * QtTestBrowser/webpage.h:
3004         (QtNAMThread::QtNAMThread):
3005
3006 2011-01-08  Eric Seidel  <eric@webkit.org>
3007
3008         Reviewed by Ojan Vafai.
3009
3010         test_failures.py should not mention TestShell (long live DumpRenderTree!)
3011         https://bugs.webkit.org/show_bug.cgi?id=52067
3012
3013         I ran test-webkitpy, but didn't bother adding a unit test for this string change.
3014         https://bugs.webkit.org/show_bug.cgi?id=51138#c3 is an example of why this is needed.
3015
3016         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
3017
3018 2011-01-08  Eric Seidel  <eric@webkit.org>
3019
3020         Reviewed by Mihai Parparita.
3021
3022         commit-queue hangs when the ChangeLog diff is bad
3023         https://bugs.webkit.org/show_bug.cgi?id=52072
3024
3025         * Scripts/webkitpy/tool/steps/validatechangelogs.py:
3026         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
3027
3028 2011-01-08  Adam Barth  <abarth@webkit.org>
3029
3030         Teach svn-apply how to re-write WebCore to Source/WebCore.
3031
3032         * Scripts/VCSUtils.pm:
3033
3034 2011-01-07  Adam Barth  <abarth@webkit.org>
3035
3036         Rubber-stamped by Eric Seidel.
3037
3038         Move WebCore to Source
3039         https://bugs.webkit.org/show_bug.cgi?id=52050
3040
3041         Update the tools to understand WebCore's new location.
3042
3043         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3044         * DumpRenderTree/wscript:
3045         * GNUmakefile.am:
3046         * Scripts/build-webkit:
3047         * Scripts/do-file-rename:
3048         * Scripts/do-webcore-rename:
3049         * Scripts/generate-qt-inspector-resource:
3050         * Scripts/prepare-ChangeLog:
3051         * Scripts/run-bindings-tests:
3052         * Scripts/update-iexploder-cssproperties:
3053         * Scripts/update-sources-list.py:
3054         * Scripts/update-webkit-localizable-strings:
3055         * Scripts/webkitdirs.pm:
3056         * Scripts/webkitpy/common/config/build.py:
3057         * Scripts/webkitpy/common/config/build_unittest.py:
3058         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
3059         * Scripts/webkitpy/style/checker.py:
3060         * Scripts/webkitpy/style/checker_unittest.py:
3061         * WebKitTestRunner/DerivedSources.pro:
3062         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3063         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh:
3064         * wx/browser/wscript:
3065         * wx/build/settings.py:
3066
3067 2011-01-07  Maciej Stachowiak  <mjs@apple.com>
3068
3069         Reviewed by Sam Weinig.
3070
3071         Make WebKitTestRunner rest between loads more robust to avoid test crashes
3072         https://bugs.webkit.org/show_bug.cgi?id=52086
3073
3074         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3075         (WTR::InjectedBundle::didReceiveMessage):
3076         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3077         (WTR::LayoutTestController::notifyDone):
3078         * WebKitTestRunner/TestController.cpp:
3079         (WTR::TestController::resetStateToConsistentValues):
3080         (WTR::TestController::run):
3081
3082 2011-01-07  James Robinson  <jamesr@chromium.org>
3083
3084         Revert "Implement mozilla's animationTime property"
3085         https://bugs.webkit.org/show_bug.cgi?id=51952
3086
3087         This approach isn't quite right.
3088
3089         * DumpRenderTree/chromium/WebViewHost.cpp:
3090         (WebViewHost::paintInvalidatedRegion):
3091
3092 2011-01-07  Adam Roben  <aroben@apple.com>
3093
3094         Build master fix
3095
3096         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3097         (RunWebKitTests.start): Don't try to concatenate a list and a string.
3098
3099 2011-01-07  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>
3100
3101         Reviewed by Csaba Osztrogonác.
3102
3103         run-qtwebkit-tests should be able to kill a testsuite.
3104
3105         Add new option in the script that can setup a timeout for a test.
3106         If the test execution takes more then specified time then the test
3107         would be terminated.
3108
3109         [Qt] run-qtwebkit-tests needs timeout
3110         https://bugs.webkit.org/show_bug.cgi?id=51894
3111
3112         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3113         * Scripts/run-qtwebkit-tests:
3114
3115 2011-01-07  Csaba Osztrogonác  <ossy@webkit.org>
3116
3117         Unreviewed fix after r75233.
3118
3119         Based on idea from Eric Seidel.
3120
3121         Add remote zip file handling to webkitpy.
3122         https://bugs.webkit.org/show_bug.cgi?id=50901
3123
3124         * Scripts/webkitpy/common/system/fileset.py: Make python 2.5 happy.
3125
3126 2011-01-07  Shane Stephens  <shanestephens@google.com>
3127
3128         Reviewed by Eric Seidel.
3129
3130         svn-apply: should support git binary delta diffs
3131         https://bugs.webkit.org/show_bug.cgi?id=38864
3132
3133         * Scripts/VCSUtils.pm:
3134         * Scripts/svn-apply:
3135
3136 2011-01-06  Julie Parent  <jparent@chromium.org>
3137
3138         Reviewed by Eric Seidel.
3139
3140         Test Result Server not removing old results.
3141         https://bugs.webkit.org/show_bug.cgi?id=52012
3142
3143         * TestResultServer/model/jsonresults.py:
3144         Fix off-by-one: Truncate if >= num_runs, not just >.
3145         * TestResultServer/model/jsonresults_unittest.py:
3146         Add unit test to test that merging in a new result with the same value
3147         as the last result causes previous result to fall off.
3148
3149 2011-01-06  James Kozianski  <koz@chromium.org>
3150
3151         Reviewed by Mihai Parparita.
3152
3153         Add classes to provide a consistent interface to a set of files.
3154         https://bugs.webkit.org/show_bug.cgi?id=50901
3155
3156         These classes allow us to write code that is agnostic to whether a
3157         particular set of files resides in a local directory or in a zip file
3158         on a remote machine.
3159
3160         * Scripts/webkitpy/common/system/directoryfileset.py: Added.
3161         * Scripts/webkitpy/common/system/directoryfileset_unittest.py: Added.
3162         * Scripts/webkitpy/common/system/fileset.py: Added.
3163         * Scripts/webkitpy/common/system/filesystem.py:
3164         * Scripts/webkitpy/common/system/filesystem_mock.py:
3165         * Scripts/webkitpy/common/system/zipfileset.py: Added.
3166         * Scripts/webkitpy/common/system/zipfileset_unittest.py: Added.
3167
3168 2011-01-06  Eric Seidel  <eric@webkit.org>
3169
3170         Reviewed by Adam Barth.
3171
3172         NetworkTransaction should log the url it is retrying
3173         https://bugs.webkit.org/show_bug.cgi?id=52043
3174
3175         * Scripts/webkitpy/common/net/networktransaction.py:
3176         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
3177
3178 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
3179
3180         Windows build fix.
3181         Import os before using it.
3182
3183         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3184
3185 2011-01-06  Eric Seidel  <eric@webkit.org>
3186
3187         Reviewed by Adam Barth.
3188
3189         StyleQueue fails to report errors when patches have many files
3190         https://bugs.webkit.org/show_bug.cgi?id=52042
3191
3192         This is one of at least two errors preventing style error reporting at the moment.
3193         When we moved to passing the list of files to check explicitly,
3194         we started to exceed the 500 character TEXT field limit for our AppEngine model object.
3195         We could change the type of the QueueStatus.message type, or we could
3196         just teach statusserver.py how to clamp values (and warn when it does).
3197         I chose the latter path.
3198
3199         * Scripts/webkitpy/common/net/statusserver.py:
3200
3201 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
3202
3203         Reviewed by Stephanie Lewis.
3204         
3205         Fix syntax error in script.
3206
3207         Windows bots need to archive/unarchive builds to/from configuration-specific directories
3208         https://bugs.webkit.org/show_bug.cgi?id=51996
3209
3210         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3211
3212 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3213
3214         Unreviewed, fixing WinCE build after r75196.
3215
3216         WinCE port does not (yet) support NPAPI.
3217
3218         * Scripts/build-webkit:
3219
3220 2011-01-06  Xan Lopez  <xlopez@igalia.com>
3221
3222         Reviewed by Darin Adler.
3223
3224         File::Spec->rel2abs in sunspider-compare-results mangles parameters
3225         https://bugs.webkit.org/show_bug.cgi?id=52015
3226
3227         * Scripts/sunspider-compare-results: call rel2abs on our arguments
3228         after the platform has been detected, otherwise the script will
3229         mangle things like '--gtk' into '/a/path/--gtk', breaking the
3230         detection.
3231
3232 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3233
3234         Reviewed by Eric Seidel.
3235
3236         Add ENABLE_NETSCAPE_PLUGIN_API, ENABLE_ORIENTATION_EVENTS and ENABLE_TOUCH_EVENTS flags to build-webkit
3237         https://bugs.webkit.org/show_bug.cgi?id=51346
3238
3239         * Scripts/build-webkit:
3240
3241 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
3242
3243         Reviewed by Adam Roben.
3244
3245         Windows bots need to archive/unarchive builds to/from configuration-specific directories
3246         https://bugs.webkit.org/show_bug.cgi?id=51996
3247         
3248         After the configuration directory change, we were archiving the incorrect directory for
3249         build product, so we were running tests on the wrong binaries.
3250         
3251         This change archives the correct directory, and also unarchives it into a configuration-
3252         specific directory.
3253
3254         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Use a configuration-specific directory on Windows.
3255         * BuildSlaveSupport/built-product-archive: Unarchive/archive to/from proper directory.
3256
3257 2011-01-06  Eric Seidel  <eric@webkit.org>
3258
3259         Reviewed by Mihai Parparita.
3260
3261         commit-queue mentions "Text diff mismatch" 4 times instead of once per failure
3262         https://bugs.webkit.org/show_bug.cgi?id=52002
3263
3264         See an example of this here:
3265         https://bugs.webkit.org/show_bug.cgi?id=51314#c2
3266
3267         It's due to the fact that we pass around TestFailure() instance
3268         objects and yet expect them to all compare to be the same.
3269
3270         This is bad.  We should either have shared instances of these values
3271         or we should just pass around the class names.  There are already hacks
3272         in place to make TestFailure objects pass equality tests, I just added
3273         a __hash__ implementation so they can be used in sets as expected.
3274
3275         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3276         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
3277
3278 2011-01-06  Evan Martin  <evan@chromium.org>
3279
3280         Reviewed by Tony Chang.
3281
3282         [gdb] handle inaccessible memory and UChar*
3283         https://bugs.webkit.org/show_bug.cgi?id=52003
3284
3285         To pretty-print a UChar*, we just grope around in the memory
3286         looking for a terminating NUL.  We need to handle the exception
3287         that can occur when we poke into an invalid location.
3288
3289         Additionally, the logic for choosing which pretty-printer would
3290         early return before hitting the point where we'd use the UChar*
3291         printer.  (Did this ever work?  How did it regress?)
3292
3293         * gdb/webkit.py:
3294
3295 2011-01-05  Brian Weinstein  <bweinstein@apple.com>
3296
3297         Reviewed by Ada Chan.
3298
3299         WebKit2: Should be able to call into injected bundle to ask if we should allow resource loads
3300         https://bugs.webkit.org/show_bug.cgi?id=51969
3301         
3302         Add shouldLoadResourceForFrame to WTR::InjectedBundlePage.
3303
3304         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3305         (WTR::InjectedBundlePage::InjectedBundlePage):
3306         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Stub implementation.
3307         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3308
3309 2011-01-06  James Robinson  <jamesr@chromium.org>
3310
3311         Reviewed by Simon Fraser.
3312
3313         Implement mozilla's animationTime property
3314         https://bugs.webkit.org/show_bug.cgi?id=51952
3315
3316         Chromium DRT support for webkitAnimationTime.
3317
3318         * DumpRenderTree/chromium/WebViewHost.cpp:
3319         (WebViewHost::paintInvalidatedRegion):
3320
3321 2011-01-06  Julie Parent  <jparent@chromium.org>
3322
3323         Reviewed by Tony Chang.
3324
3325         Test Result Server always truncates number of results to JSON_RESULTS_MAX_BUILDS
3326         https://bugs.webkit.org/show_bug.cgi?id=51217
3327
3328         * TestResultServer/model/jsonresults.py:
3329         Pass num_runs through to _remove_items_over_max_number_of_builds, and use the value.
3330         Adds missing documentation.
3331         * TestResultServer/model/jsonresults_unittest.py:
3332         Add unit test to test that truncation happens at smaller value than JSON_RESULTS_MAX_BUILDS.
3333         Update test_merge to take a number of builds to truncate at.
3334
3335 2011-01-06  Adam Barth  <abarth@webkit.org>
3336
3337         Reviewed by Eric Seidel.
3338
3339         The EWS should log outside of the working directory
3340         https://bugs.webkit.org/show_bug.cgi?id=51986
3341
3342         This patch prepare us for using git clean -x -d -f in the EWS wrapper
3343         script, which will actually clean the working copy back to a pristine
3344         state instead of leaving untracked directories and ignored files.
3345
3346         * Scripts/webkitpy/tool/commands/queues.py:
3347         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3348
3349 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
3350
3351         Windows build fix.
3352         Back out attempted change to built-product-archive.
3353
3354         * BuildSlaveSupport/built-product-archive:
3355
3356 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
3357
3358         Windows build fix.
3359         Include configuration name when unpacking a build archive.
3360
3361         Needed, since we split Windows build results into configuration-specific directories
3362         under WebKitOutputDir.
3363
3364         * BuildSlaveSupport/built-product-archive:
3365
3366 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
3367
3368         Reviewed by Darin Adler.
3369
3370         Debug and Release builds on Windows clobber each other
3371         https://bugs.webkit.org/show_bug.cgi?id=49185
3372
3373         Changes the structure of WebKitBuild build products directory so we
3374         completely separate each build configuration into independent directories.
3375         
3376         Although we previously had per-configuration directories for obj, this change adds
3377         per-configuration directories for bin, lib, obj, and include. Each configuration's
3378         build products are stored within a directory inside of WebKitBuild.
3379         
3380         Most use of $(WebKitOutputDir) in the build files has been replaced by $(ConfigurationBuildDir),
3381         defined in common.vsprops to be $(WebKitOutputDir)\$(ConfigurationName).
3382
3383         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops:
3384         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd:
3385         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd:
3386         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
3387         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd:
3388         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd:
3389         * DumpRenderTree/win/ImageDiffCommon.vsprops:
3390         * DumpRenderTree/win/ImageDiffPostBuild.cmd:
3391         * DumpRenderTree/win/ImageDiffPreBuild.cmd:
3392         * FindSafari/FindSafari.vcproj:
3393         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
3394         * MiniBrowser/MiniBrowserPostBuild.cmd:
3395         * MiniBrowser/MiniBrowserPreBuild.cmd:
3396         * Scripts/webkitdirs.pm:
3397         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
3398         * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops:
3399         * TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd:
3400         * TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd:
3401         * TestWebKitAPI/win/copy-resources.cmd:
3402         * WebKitAPITest/WebKitAPITestCommon.vsprops:
3403         * WebKitAPITest/WebKitAPITestPostBuild.cmd:
3404         * WebKitAPITest/WebKitAPITestPreBuild.cmd:
3405         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
3406         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
3407         * WebKitTestRunner/win/InjectedBundle.vcproj:
3408         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops:
3409         * WebKitTestRunner/win/InjectedBundlePostBuild.cmd:
3410         * WebKitTestRunner/win/InjectedBundlePreBuild.cmd:
3411         * WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd:
3412         * WebKitTestRunner/win/WebKitTestRunnerPreBuild.cmd:
3413         * WinLauncher/WinLauncherCommon.vsprops:
3414         * WinLauncher/WinLauncherPostBuild.cmd:
3415         * WinLauncher/WinLauncherPreBuild.cmd:
3416
3417 2011-01-05  Jan Erik Hanssen  <jhanssen@sencha.com>
3418
3419         Reviewed by Ariya Hidayat.
3420
3421         [Qt] TestNetscapePlugin doesn't link on OS X
3422         https://bugs.webkit.org/show_bug.cgi?id=51948
3423
3424         Only add a dependency on libX11 on X11 systems
3425
3426         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3427
3428 2011-01-05  Jeff Miller  <jeffm@apple.com>
3429
3430         Reviewed by Adam Roben.
3431
3432         check-webkit-style should allow unnecessary parameter names in WebKit2 APIs because we're matching CF's header style
3433         https://bugs.webkit.org/show_bug.cgi?id=51970
3434
3435         * Scripts/webkitpy/style/checker.py:
3436         Add -readability/naming for WebKit2 C API directories.
3437
3438 2011-01-05  Eric Seidel  <eric@webkit.org>
3439
3440         Unreviewed, just fixing one more log error from my previous python patch.
3441
3442         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
3443         https://bugs.webkit.org/show_bug.cgi?id=51802
3444
3445         webkit-patch failure-reason was logging about parsing errors
3446         due to my misunderstanding of how BeautifulSoup.findAll worked.
3447
3448         Fixed, and added a unit test.
3449
3450         * Scripts/webkitpy/common/net/layouttestresults.py:
3451         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3452
3453 2011-01-05  Benjamin Poulain  <benjamin.poulain@nokia.com>
3454
3455         Reviewed by Kenneth Rohde Christiansen.
3456
3457         [Qt] [WK2] Add the possibility to open window from the WebProcess in Minibrowser
3458         https://bugs.webkit.org/show_bug.cgi?id=51951
3459
3460         Set a function to QWKPage::setCreateNewPageFunction() in Minibrowser so there is a way
3461         to create new window from WebKit.
3462
3463         * MiniBrowser/qt/BrowserWindow.cpp:
3464         (newPageFunction):
3465         (BrowserWindow::BrowserWindow):
3466         (BrowserWindow::page): Added to avoid the indirect access to QWKPage spread in the class
3467         (BrowserWindow::newWindow):
3468         (BrowserWindow::updateUserAgentList):
3469         (BrowserWindow::showUserAgentDialog):
3470         * MiniBrowser/qt/BrowserWindow.h: Add the global variable backingStoreTypeForNewWindow to
3471         define the type of the backing store used for new windows.
3472         * MiniBrowser/qt/main.cpp:
3473         (main):
3474
3475 2011-01-05  Eric Seidel  <eric@webkit.org>
3476
3477         Reviewed by Ojan Vafai.
3478
3479         commit-queue should report failure type when reporting flaky tests
3480         https://bugs.webkit.org/show_bug.cgi?id=51900
3481
3482         This patch was a ridiculous amount of plumbing.  In the end I like
3483         the NRWT-style TestResult class even less.  But now we're passing
3484         a list of TestResult objects from the queue to the FlakyTestReporter.
3485         Thus the FlakyTestReporter can more easily report what type of failure
3486         occurred.
3487
3488         In the process, I found that I was not alone in finding TestResult
3489         cumbersome to use.  A bunch of code was trying to create a TestResult
3490         object with default values.  However since the constructor didn't make
3491         this easy, some places were getting it wrong (including the TestResult unit test)!
3492         I've fixed the TestResult constructor to have default values for non-essential
3493         arguments.
3494
3495         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3496         * Scripts/webkitpy/common/net/layouttestresults.py:
3497         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3498         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3499         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3500         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
3501         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
3502         * Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py:
3503         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
3504         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3505         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3506         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3507         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3508         * Scripts/webkitpy/tool/commands/queues.py:
3509         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3510
3511 2011-01-05  Eric Seidel  <eric@webkit.org>
3512
3513         Unreviewed.
3514
3515         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
3516         https://bugs.webkit.org/show_bug.cgi?id=51802
3517
3518         Add another unit test to cover a previously missing import.
3519
3520         * Scripts/webkitpy/common/net/layouttestresults.py:
3521         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3522
3523 2011-01-05  Mihai Parparita  <mihaip@chromium.org>
3524
3525         Reviewed by David Levin.
3526
3527         Add mihaip@chromium.org as a reviewer
3528         https://bugs.webkit.org/show_bug.cgi?id=51966
3529         
3530         Add myself as a reviewer.
3531
3532         * Scripts/webkitpy/common/config/committers.py:
3533
3534 2011-01-05  James Simonsen  <simonjam@chromium.org>
3535
3536         Unreviewed. Adding myself to the list of committers.
3537
3538         * Scripts/webkitpy/common/config/committers.py:
3539
3540 2011-01-05  Eric Seidel  <eric@webkit.org>
3541
3542         Unreviewed.
3543
3544         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
3545         https://bugs.webkit.org/show_bug.cgi?id=51802
3546
3547         Fix two exceptions seen on the bots after my original commit.
3548
3549         * Scripts/webkitpy/common/net/layouttestresults.py:
3550         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3551
3552 2011-01-05  Kundu Suchismita  <suchi.kundu@nokia.com>
3553
3554         Reviewed by Andreas Kling.
3555
3556         [Qt]Add local storage settings to QtTestBrowser command line arguments 
3557         https://bugs.webkit.org/show_bug.cgi?id=51750
3558
3559         * QtTestBrowser/main.cpp:
3560         (LauncherApplication::handleUserOptions):
3561          Local storage settings can be enable form command line arguments for
3562          QtTestBrowser.
3563
3564 2011-01-05  Chris Fleizach  <cfleizach@apple.com>
3565
3566         Reviewed by Martin Robinson.
3567
3568         GTK: AX: DRT needs to use correct root object method.
3569         https://bugs.webkit.org/show_bug.cgi?id=51911
3570
3571         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
3572         (AccessibilityController::rootElement):
3573
3574 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
3575
3576         Rubber-stamped by Csaba Osztrogonác.
3577
3578         Based on idea from Péter Gál.
3579
3580         * Scripts/webkitpy/tool/bot/sheriff.py: Remove unnecessary apostrophes around revision numbers.
3581
3582 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
3583
3584         Reviewed by Adam Barth.
3585
3586         sheriff-bot should be able to do multi-revision rollouts
3587         https://bugs.webkit.org/show_bug.cgi?id=51176
3588
3589         * Scripts/webkitpy/tool/bot/irc_command.py:
3590         * Scripts/webkitpy/tool/bot/sheriff.py:
3591         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
3592
3593 2011-01-05  Eric Seidel  <eric@webkit.org>
3594
3595         Reviewed by Adam Barth.
3596
3597         queues.webkit.org should have per-bot status pages
3598         https://bugs.webkit.org/show_bug.cgi?id=51906
3599
3600         Just adds a /queue-status/QUEUE_NAME/bots/BOT_ID page to show
3601         statuses from a single queue.  Now that we have many bots servicing
3602         some queues (commit-queue, win-ews, etc.) its easy to have the messages
3603         you care about scroll off the end of the 15-message limit on the main page.
3604
3605         Eventually we should probably rename /queue-status to /queue or /queues,
3606         but that's fodder for another patch.
3607
3608         * QueueStatusServer/handlers/queuestatus.py:
3609         * QueueStatusServer/index.yaml:
3610         * QueueStatusServer/main.py:
3611         * QueueStatusServer/templates/includes/singlequeuestatus.html:
3612          - This probably should use a custom filter instead of hard-coding
3613            the URL scheme here, but I couldn't figure out how to easily
3614            create such a filter.  Most filters work with "strings" so we can't
3615            pass the status object.  We could add a method to the status
3616            object and call that, but that seemed a bit strange too.
3617         * QueueStatusServer/templates/queuestatus.html:
3618
3619 2011-01-05  Carlos Garcia Campos  <cgarcia@igalia.com>
3620
3621         Unreviewed. Adding myself to the list of committers.
3622
3623         * Scripts/webkitpy/common/config/committers.py:
3624
3625 2011-01-04  Koan-Sin Tan  <koansin.tan@gmail.com>
3626
3627         Reviewed by David Levin.
3628
3629         check-webkit-style treated some macros with parentheses after #elif as function calls
3630         https://bugs.webkit.org/show_bug.cgi?id=51695
3631
3632         Ingore function call space checking in any preprocessor directives
3633         (things starting with #). Change search() to match() because 
3634         preprocessor directives are supposed to be in the beginning of lines.
3635
3636         * Scripts/webkitpy/style/checkers/cpp.py:
3637         * Scripts/webkitpy/style/checkers/cpp_unittest.py: make sure there is no false positives for #elif cases
3638
3639 2011-01-04  Søren Gjesse  <sgjesse@chromium.org>
3640
3641         Reviewed by Tony Chang.
3642
3643         Change the --multi-load test option to --stress-opt
3644         https://bugs.webkit.org/show_bug.cgi?id=50751
3645
3646         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3647         (runTest):
3648         (main):
3649         * DumpRenderTree/chromium/TestShell.cpp:
3650         (TestShell::TestShell):
3651         * DumpRenderTree/chromium/TestShell.h:
3652         (TestShell::stressOpt):
3653         (TestShell::setStressOpt):
3654         (TestShell::stressDeopt):
3655         (TestShell::setStressDeopt):
3656         (TestShell::javaScriptFlags):
3657         (TestShell::setJavaScriptFlags):
3658         * Scripts/webkitpy/layout_tests/port/chromium.py:
3659         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3660
3661 2011-01-04  Chris Fleizach  <cfleizach@apple.com>
3662
3663         Reviewed by Sam Weinig.
3664
3665         WK2: Support Accessibility
3666         https://bugs.webkit.org/show_bug.cgi?id=51859
3667
3668         Use rootObject() method to get top of accessibility tree.
3669
3670         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
3671         (AccessibilityController::focusedElement):
3672         (AccessibilityController::rootElement):
3673
3674 2011-01-03  Martin Robinson  <mrobinson@igalia.com>
3675
3676         Reviewed by Darin Adler.
3677
3678         Remove the last non-GObject usage of PlatformRefPtr and move the code to GRefPtr
3679         https://bugs.webkit.org/show_bug.cgi?id=51846
3680
3681         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: Change usage of PlatformRefPtr
3682         back to GRefPtr.
3683
3684 2011-01-04  Zhe Su  <suzhe@chromium.org>
3685
3686         Reviewed by Kenneth Russell.
3687
3688         Fix insertText, setMarkedText and unmarkText methods of
3689         TextInputController to call corresponding methods of WebKit::WebView
3690         rather than WebKit::WebFrame. This change matches the behavior of
3691         chromium browser.
3692         insertText corresponds to WebView::confirmComposition(text)
3693         setMarkedText corresponds to WebView::setComposition(...)
3694         unmarkText corresponds to WebView::confirmComposition()
3695         https://bugs.webkit.org/show_bug.cgi?id=51693
3696
3697         * DumpRenderTree/chromium/TextInputController.cpp:
3698         (TextInputController::insertText):
3699         (TextInputController::setMarkedText):
3700         (TextInputController::unmarkText):
3701
3702 2011-01-04  Dihan Wickremasuriya  <dihan.wickremasuriya@nokia.com>
3703
3704         Reviewed by Laszlo Gombos.
3705
3706         [Qt] [Symbian] Do not remove 0 byte sized files from productDir
3707
3708         On Symbian productDir points to the source directory. Removing all the
3709         empty files from the productDir directory corrupts the svn repository.
3710
3711         * Scripts/build-webkit:
3712
3713 2011-01-03  Yi Shen  <yi.4.shen@nokia.com>
3714
3715         Reviewed by Adam Barth.
3716
3717         [Qt] Add SelectAll option to the context menu for the editor
3718         https://bugs.webkit.org/show_bug.cgi?id=50049
3719
3720         Set shortcut for the SelectAll action.
3721
3722         * QtTestBrowser/mainwindow.cpp:
3723         (MainWindow::buildUI):
3724
3725 2011-01-03  David Levin  <levin@chromium.org>
3726
3727         Reviewed by Eric Seidel.
3728
3729         check-webkit-style shouldn't consider "value" automatically to be a meaningless name.
3730         https://bugs.webkit.org/show_bug.cgi?id=51842
3731
3732         * Scripts/webkitpy/style/checkers/cpp.py: Remove the check for value.
3733         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Remove the test for value.
3734
3735 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
3736
3737         Reviewed by David Kilzer.
3738
3739         [WINCE] Adds a build slave.
3740         https://bugs.webkit.org/show_bug.cgi?id=50523
3741
3742         * BuildSlaveSupport/build.webkit.org-config/config.json: Add an
3743         entry for a release build of the WinCE port.
3744         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add platform
3745         flag to build the WinCE port.
3746
3747 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
3748
3749         Reviewed by David Kilzer.
3750
3751         Add WinCE support to build-webkit
3752         https://bugs.webkit.org/show_bug.cgi?id=51642
3753
3754         * Scripts/build-webkit:
3755         * Scripts/webkitdirs.pm:
3756
3757 2011-01-03  Eric Seidel  <eric@webkit.org>
3758
3759         Reviewed by Adam Barth.
3760
3761         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
3762         https://bugs.webkit.org/show_bug.cgi?id=51802
3763
3764         I'm not the biggest fan of the test_failures or test_results classes,
3765         but it's better to have one shared set of classes, than separate ones
3766         for new vs. old run-webkit-test result handling.
3767
3768         This moves the ORWT results class "LayoutTestResults" over to using
3769         TestResult and TestFailure classes, making it easy for us to
3770         make all our sheriff-bot and other webkitpy code NRWT ready.
3771
3772         This also makes it a trivial patch to generate results.json information
3773         from ORWT results.html files (for flaky test analysis, etc.) as well
3774         as making it a one-liner to report test failure types when the
3775         commit-queue sees flaky tests.
3776
3777         This patch tried not to add new functionality, but only to replace
3778         the guts of LayoutTestResults, while adding unit tests and hoping
3779         not to break anything.
3780
3781         I also moved callers which assumed User.prompt* were static/class methods
3782         to using them as instance methods (since we'll eventually want to make them such).
3783
3784         In the process of re-writing things, I broke the rebaseline command, so I wrote
3785         a unit test to catch my breakage were I do do so again in the future.
3786