Include the crashing function in the link to a crash log on Mac
[WebKit.git] / Tools / ChangeLog
1 2011-02-04  Adam Roben  <aroben@apple.com>
2
3         Include the crashing function in the link to a crash log on Mac
4
5         Fixes <http://webkit.org/b/53780> Crash log links in results.html should include the
6         function that crashed on Mac
7
8         Reviewed by David Kilzer.
9
10         * Scripts/old-run-webkit-tests:
11         (crashLocation): Moved all the Windows code inside an if instead of using an early return,
12         but didn't otherwise change it. Added an if for Mac that parses the crashing function out of
13         the crash log.
14
15 2011-02-04  Adam Roben  <aroben@apple.com>
16
17         Link to Mac crash logs from results.html
18
19         Fixes <http://webkit.org/b/14861> run-webkit-tests should link to Mac crash logs in
20         results.html
21
22         Reviewed by David Kilzer.
23
24         * Scripts/old-run-webkit-tests:
25         (captureSavedCrashLog): Added a case for Apple's Mac port. We get the crash log out of
26         ~/Library/Logs/CrashReporter, and wait for ReportCrash to exit before trying to get the log.
27
28 2011-02-03  Maciej Stachowiak  <mjs@apple.com>
29
30         Reviewed by Dan Bernstein.
31
32         WebKit2: Need WebKit2 equivalent of WebResourceLoadDelegate::willSendRequest in the Bundle
33         https://bugs.webkit.org/show_bug.cgi?id=52897
34         <rdar://problem/8898294>
35
36         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
37         (WTR::InjectedBundlePage::InjectedBundlePage):
38         (WTR::InjectedBundlePage::willSendRequestForFrame):
39         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
40
41 2011-02-03  Ivan Krstić  <ike@apple.com>
42
43         Unreviewed.
44
45         Adding myself to committers.py.
46
47         * Scripts/webkitpy/common/config/committers.py:
48
49 2011-02-03  James Kozianski  <koz@chromium.org>
50
51         Reviewed by Dimitri Glazkov.
52
53         Add navigator.registerProtocolHandler behind a flag.
54         https://bugs.webkit.org/show_bug.cgi?id=52609
55
56         * Scripts/build-webkit:
57
58 2011-02-03  Hayato Ito  <hayato@chromium.org>
59
60         Reviewed by Eric Seidel.
61
62         [NRWT] Remove TestArgs class, which is wrongly used.
63
64         https://bugs.webkit.org/show_bug.cgi?id=53063
65
66         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
67         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
68         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
69         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
70         * Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py:
71         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
72
73 2011-02-03  Andrew Wason  <rectalogic@rectalogic.com>
74
75         Reviewed by Kenneth Russell.
76
77         Change ENABLE_3D_CANVAS to ENABLE_WEBGL
78         https://bugs.webkit.org/show_bug.cgi?id=53714
79
80         * Scripts/build-webkit: change --3d-canvas build option
81           to set ENABLE_WEBGL
82
83 2011-02-03  Hayato Ito  <hayato@chromium.org>
84
85         Reviewed by Tony Chang.
86
87         [NRWT] Introduces Input/Output class used by base.Driver into port/base.py and
88         move _run_single_test() and _process_output() functions from
89         dump_render_tree_thread.py to a single_test_runner.py as an individual module.
90
91         This is clean up and acts as a preparation for elimination of test_types/*
92         classes. These classes will move to the single_test_runner module introduced
93         in this patch.
94
95         https://bugs.webkit.org/show_bug.cgi?id=53004
96
97         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
98         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py: Added.
99         * Scripts/webkitpy/layout_tests/layout_package/test_input.py:
100         * Scripts/webkitpy/layout_tests/layout_package/test_output.py: Removed.
101         * Scripts/webkitpy/layout_tests/port/base.py:
102         * Scripts/webkitpy/layout_tests/port/chromium.py:
103         * Scripts/webkitpy/layout_tests/port/dryrun.py:
104         * Scripts/webkitpy/layout_tests/port/test.py:
105         * Scripts/webkitpy/layout_tests/port/webkit.py:
106         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
107         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
108         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
109
110 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
111
112         Unreviewed, build fix.
113
114         Delete a line that was accidentally missed in r77586; without it
115         there is still a race between the two threads.
116
117         https://bugs.webkit.org/show_bug.cgi?id=51572
118
119         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
120
121 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
122
123         Reviewed by Tony Chang.
124
125         nrwt: handle "broken pipe" notifications from DRT more cleanly.
126
127         https://bugs.webkit.org/show_bug.cgi?id=52927
128
129         * Scripts/webkitpy/layout_tests/port/server_process.py:
130         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
131
132 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
133
134         Reviewed by Kenneth Russell.
135
136         Update, resubmit change to bug 51572. I think the race that was
137         fixed in r76703 caused the hang that caused us to roll this
138         patch out before, so I'd like to try again.
139
140         https://bugs.webkit.org/show_bug.cgi?id=51572
141
142         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
143         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
144
145 2011-02-03  Daniel Cheng  <dcheng@chromium.org>
146
147         Unreviewed.
148
149         Adding myself to committers.py.
150
151         * Scripts/webkitpy/common/config/committers.py:
152
153 2011-02-03  Adam Roben  <aroben@apple.com>
154
155         Include the crashing function in the link to a crash log
156
157         Fixes <http://webkit.org/b/53739> Crash log links in results.html should include the
158         function that crashed
159
160         Reviewed by David Kilzer.
161
162         * Scripts/old-run-webkit-tests:
163         (crashLocation): Added. Returns the location of the crash.
164         (linksForErrorTest): Include the crash location in the link text for the crash log, if one
165         could be determined.
166
167 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
168
169         Unreviewed, build fix.
170
171         Actually make the changes suggested by Mihai in his review
172         of bug 53720 :(
173
174         https://bugs.webkit.org/show_bug.cgi?id=53720
175
176         * Scripts/webkitpy/layout_tests/port/test_files.py:
177         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
178
179 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
180
181         Reviewed by Mihai Parparita.
182
183         new-run-webkit-tests: Fix bug introduced in r77434 that was
184         causing us to run the canvas GPU tests on the Mac GPU port. This
185         bug revealed that we were not setting the port.name() field
186         properly in many cases, so I've cleaned up all of that code, and
187         removed a few comments about "version-specific" GPU ports that
188         don't exist and just confused things.
189
190         Testing also revealed that port.abspath_for_test() wasn't
191         normalizing paths on Windows properly, so I fixed that as well.
192
193         https://bugs.webkit.org/show_bug.cgi?id=53719
194
195         * Scripts/webkitpy/layout_tests/port/base.py:
196         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
197         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
198
199 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
200
201         Reviewed by Mihai Parparita.
202
203         new-run-webkit-tests: fix normalization of paths on windows when gathering files
204
205         r77434 introduced a bug that was causing the test expectations
206         for the GPU ports to not be treated properly. It turns out that
207         when we gathered the list of test files on Windows, we would
208         return paths of the form "c:\LayoutTests/fast/canvas", and the
209         mixture of backslashes and forward slashes was confusing things.
210
211         This patch normalizes all of the filenames returned from
212         test_files.find(), and adds better tests for this (fixing a
213         couple of other bugs found in the meantime).
214
215         https://bugs.webkit.org/show_bug.cgi?id=53720
216
217         * Scripts/webkitpy/layout_tests/port/test.py:
218         * Scripts/webkitpy/layout_tests/port/test_files.py:
219         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
220
221 2011-02-03  Adam Roben  <aroben@apple.com>
222
223         Add links to Windows crash logs in results.html
224
225         Fixes <http://webkit.org/b/53718> run-webkit-tests should link to Windows crash logs in
226         results.html
227
228         Reviewed by David Kilzer.
229
230         * Scripts/old-run-webkit-tests:
231         (top level): Added $crashLogTag and $windowsCrashLogFilePrefix (which came from
232         createDebuggerCommandFile).
233         (testCrashedOrTimedOut): If the test crashed, capture any saved crash log after the dump
234         tool has exited.
235         (captureSavedCrashLog): Added. Finds the crash log for the test that just crashed and moves
236         it into the test results directory tree. Only implemented for Cygwin currently.
237         (findNewestFileMatchingGlob): Added. Does what it says.
238         (htmlForResultsSection): Only link to files that exist.
239         (linksForErrorTest): Add a link to the crash log.
240         (deleteExpectedAndActualResults): Delete any old crash log for this test.
241         (createDebuggerCommandFile): Use the new $windowsCrashLogFilePrefix constant instead of
242         hardcoding it here.
243
244 2011-02-03  Adam Roben  <aroben@apple.com>
245
246         Tell the debugger the path to the WebKit source tree when saving a crash log
247
248         This allows the debugger to include the crashing line of code in the log.
249
250         Fixes <http://webkit.org/b/53678> Crash logs from buildslaves don't show the crashing line
251         of code
252
253         Reviewed by Sam Weinig.
254
255         * Scripts/old-run-webkit-tests:
256         (createDebuggerCommandFile): Added. Saves commands that we'd like the debugger to run to a
257         file and returns the path to that file. The commands we pass came from
258         setUpWindowsCrashLogSaving, but I've added a .srcpath command to tell the debugger where the
259         WebKit source code lives.
260         (setUpWindowsCrashLogSaving): Instead of specifying the commands directly on the command
261         line using -c, save them to a file and specify the path to that file using -cf. This works
262         around what is presumably a bug in Windows's command line parsing, where having multiple
263         quoted paths in the debugger commands causes the post-mortem debugger not to be invoked at
264         all. Also pulled the options we pass to the debugger out into a list that is then join()ed
265         together to make them easier to modify in the future.
266
267 2011-02-02  Sam Weinig  <sam@webkit.org>
268
269         Reviewed by Anders Carlsson.
270
271         Add notification of the end of a rubber band.
272         <rdar://problem/8940648>
273
274         * MiniBrowser/mac/BrowserWindowController.m:
275         (-[BrowserWindowController awakeFromNib]):
276         * WebKitTestRunner/TestController.cpp:
277         (WTR::TestController::createOtherPage):
278         (WTR::TestController::initialize):
279         Stub out the new WKUIClient function.
280
281 2011-02-03  Gabor Rapcsanyi  <rgabor@webkit.org>
282
283         Unreviewed.
284
285         Adding myself to committers.py.
286
287         * Scripts/webkitpy/common/config/committers.py:
288
289 2011-02-03  Balazs Kelemen  <kbalazs@webkit.org>
290
291         Reviewed by Csaba Osztrogonác.
292
293         [Qt][WK2] MiniBrowser's window size should be 800x600
294         https://bugs.webkit.org/show_bug.cgi?id=53670
295
296         Make layout test failure debugging easier.
297         * MiniBrowser/qt/BrowserWindow.cpp:
298         (BrowserWindow::BrowserWindow):
299
300 2011-02-02  Andy Estes  <aestes@apple.com>
301
302         Reviewed by Mark Rowe.
303
304         'update-webkit' should handle OpenSource and Internal using different
305         VCSs.
306
307         * Scripts/update-webkit: Re-check the VCS type when updating Apple's
308         Internal directory.
309
310 2011-02-02  Dirk Pranke  <dpranke@chromium.org>
311
312         Reviewed by Mihai Parparita.
313
314         new-run-webkit-tests: hardcode the directories to scan for tests
315         for GPU bots instead of SKIPping them. See bug 53562 for some
316         context, but we will now hard-code the list of directories to
317         use by default instead of skipping over directories in the
318         expectations file. We do this so that we will be able to merge
319         the expectations files without getting conflicting SKIP
320         directives. Note that this change will reduce the # of tests
321         being run on the Mac GPU bots, because we're accidentally
322         including some today.
323
324         https://bugs.webkit.org/show_bug.cgi?id=53631
325
326         * Scripts/webkitpy/layout_tests/port/base.py:
327         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
328         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
329
330 2011-02-02  Sam Weinig  <sam@webkit.org>
331
332         Reviewed by Beth Dakin.
333
334         Add ChromeClient function to paint custom overhang areas.
335         https://bugs.webkit.org/show_bug.cgi?id=53639
336
337         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
338         (WTR::InjectedBundlePage::InjectedBundlePage):
339         Stub out new callback.
340
341 2011-02-02  Dirk Pranke  <dpranke@chromium.org>
342
343         Reviewed by Tony Chang.
344
345         new-run-webkit-tests: support chromium code paths in mock_drt
346
347         https://bugs.webkit.org/show_bug.cgi?id=53471
348
349         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
350         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
351
352 2011-02-02  Adam Klein  <adamk@chromium.org>
353
354         Reviewed by Tony Chang.
355
356         Update new-run-webkit-tests --chromium to put output under Source/...
357         https://bugs.webkit.org/show_bug.cgi?id=53612
358
359         * BuildSlaveSupport/test-result-archive:
360         * Scripts/webkitpy/layout_tests/port/chromium.py:
361
362 2011-01-28  Tony Chang  <tony@chromium.org>
363
364         Reviewed by Eric Seidel.
365
366         [chromium] remove --use-test-shell from NRWT
367         https://bugs.webkit.org/show_bug.cgi?id=53346
368
369         I've already started removing some of the bindings like eventSender so
370         this already doesn't work isn't useful.  Also updated some comments to
371         refer to DRT instead of test_shell.
372
373         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
374         * Scripts/webkitpy/layout_tests/port/chromium.py:
375         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
376         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
377         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
378         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
379         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
380         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
381
382 2011-02-02  Steve Lacey  <sjl@chromium.org>
383
384         Reviewed by Eric Carlson.
385
386         Implement basic media statistics on media elements.
387         https://bugs.webkit.org/show_bug.cgi?id=53322
388
389         * Scripts/build-webkit:
390
391 2011-02-02  Kevin Ollivier  <kevino@theolliviers.com>
392
393         [wx] Build fixes for wxWebKit.
394
395         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
396         (LayoutTestController::setSerializeHTTPLoads):
397         * wx/browser/wscript:
398         * wx/build/build_utils.py:
399         * wx/build/settings.py:
400
401 2011-02-01  Dirk Pranke  <dpranke@chromium.org>
402
403         Reviewed by Mihai Parparita.
404
405         new-run-webkit-tests: stop skipping so many tests
406
407         r77163 introduced a regression where we weren't resetting test
408         expectations properly and were skipping too many tests as a
409         result. This patch fixes that and adds a test for it.
410
411         https://bugs.webkit.org/show_bug.cgi?id=53551
412
413         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
414         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
415
416 2011-02-01  Dirk Pranke  <dpranke@chromium.org>
417
418         Reviewed by Tony Chang.
419
420         new-run-webkit-tests: add first stub of test_runner2. This
421         will add support for the 'inline', 'threads', and 'processes'
422         flags to --worker-model, but for now the implementatios just
423         fall back on the old ones.
424
425         https://bugs.webkit.org/show_bug.cgi?id=53157
426
427         * Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
428         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
429
430 2011-02-01  Mihai Parparita  <mihaip@chromium.org>
431
432         Reviewed by James Robinson.
433
434         [Chromium] run-chromium-webkit-unit-tests looks for binaries in the wrong place
435         https://bugs.webkit.org/show_bug.cgi?id=53522
436
437         * Scripts/run-chromium-webkit-unit-tests:
438
439 2011-02-01  Adam Barth  <abarth@webkit.org>
440
441         Reviewed by Mihai Parparita.
442
443         Using Control-C to cancel webkit-patch or other python tools causes
444         unpleasant traceback console spew
445         https://bugs.webkit.org/show_bug.cgi?id=53462
446
447         Catch the exception and don't print the stack trace.
448
449         * Scripts/webkit-patch:
450
451 2011-02-01  Scott Cameron  <sccameron@rim.com>
452
453         Reviewed by Daniel Bates.
454
455         Use Windows format for MinGW HTTPD path.
456         https://bugs.webkit.org/show_bug.cgi?id=53503
457
458         * Scripts/webkitperl/httpd.pm:
459           - Use single-quotes around MySys value for $httpdPath in getHTTPDPath()
460             so that we don't have to escape the space characters in the path. Also,
461             changed path to Windows-style path and removed FIXME comment.
462
463 2011-02-01  Balazs Kelemen  <kbalazs@webkit.org>
464
465         Reviewed by Andreas Kling.
466
467         [Qt][WK2] Add a way to use shared process model in MiniBrowser
468         https://bugs.webkit.org/show_bug.cgi?id=53090
469
470         * MiniBrowser/qt/BrowserView.cpp:
471         (BrowserView::BrowserView): Removed the m_context member.
472         From now the context is guaranteed to be non-null and we
473         don't need to store that in the object.
474         * MiniBrowser/qt/BrowserView.h:
475         * MiniBrowser/qt/BrowserWindow.cpp:
476         Added static bool to determine that new windows need to be
477         created with their own context or not. Use the same context
478         and web process by default to be inilne with the other ports.
479         (BrowserWindow::BrowserWindow):
480         (BrowserWindow::newWindow):
481         * MiniBrowser/qt/BrowserWindow.h:
482         * MiniBrowser/qt/main.cpp:
483         (main): Added command line switch to be able to use the
484         non-shared process model. Simplify the handling of the command line
485         switches a little bit.
486
487 2011-02-01  Zoltan Horvath  <zoltan@webkit.org>
488
489         Reviewed by Andreas Kling.
490
491         [Qt] Add Window menu and Toggle FullScreen action to MiniBrowser.
492         https://bugs.webkit.org/show_bug.cgi?id=53491
493
494         * MiniBrowser/qt/BrowserWindow.cpp:
495         (BrowserWindow::BrowserWindow):
496         (BrowserWindow::toggleFullScreenMode):
497         * MiniBrowser/qt/BrowserWindow.h:
498
499 2011-02-01  Zoltan Horvath  <zoltan@webkit.org>
500
501         Reviewed by Andreas Kling.
502
503         [Qt] Add Toggle Frame Flattening, Auto Load Images and Disable JavaScript actions to MiniBrowser.
504         https://bugs.webkit.org/show_bug.cgi?id=53489
505
506         Add Toggle Frame Flattening action to Develop menu. Add Auto Load Images and Disable JavaScript actions
507         to Settings menu.
508
509         * MiniBrowser/qt/BrowserWindow.cpp:
510         (BrowserWindow::BrowserWindow):
511         (BrowserWindow::toggleFrameFlattening):
512         (BrowserWindow::toggleDisableJavaScript):
513         (BrowserWindow::toggleAutoLoadImages):
514         * MiniBrowser/qt/BrowserWindow.h:
515
516 2011-01-31  Mihai Parparita  <mihaip@chromium.org>
517
518         Reviewed by Tony Chang.
519
520         [Chromium] Switch chromium-mac to use ChromiumDriver
521         https://bugs.webkit.org/show_bug.cgi?id=53461
522         
523         For the sake of consistency with the other Chromium platforms (and so
524         that chromium-mac picks up special flags like --enable-hardware-gpu),
525         switch chromium-mac from the WebKitDriver to ChromiumDriver.
526
527         * Scripts/webkitpy/layout_tests/port/chromium.py:
528
529 2011-01-31  Dirk Pranke  <dpranke@chromium.org>
530
531         Reviewed by Mihai Parparita.
532
533         The current modifier parsing code in test_expectations is
534         fragile and hard-coded, so it's not easy to understand the logic
535         or easily add new types of modifiers (like GPU vs. CPU testing
536         for graphics tests, or 32-bit vs. 64-bit differences).
537
538         This is the first of two patches that will add in more generic
539         support and then eliminate the GPU-specific test expectations
540         files for Chromium.
541
542         This patch adds two standalone objects for handling modifiers. The
543         rules for interpreting modifiers, precedence, and conflicts are
544         given in the docstring to the ModifierMatcher class, which
545         returns ModifierMatchResult objects.
546         
547         This patch also adds routines to the Port interface and a
548         default set of values in the base object, in order to obtain the
549         values needed on a given test run. These values are then passed
550         to the expectation parser. This also allows us to clean up the
551         logic used to lint all of the different configurations in a
552         single test_expectations.txt file.
553
554         The next patch will merge in the separate GPU expectations file.
555
556         https://bugs.webkit.org/show_bug.cgi?id=51222
557
558         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
559         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
560         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
561         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
562         * Scripts/webkitpy/layout_tests/port/base.py:
563         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
564         * Scripts/webkitpy/layout_tests/port/chromium.py:
565         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
566         * Scripts/webkitpy/layout_tests/port/test.py:
567         * Scripts/webkitpy/layout_tests/port/webkit.py:
568         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
569         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
570         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
571         * Tools/Scripts/webkitpy/style/checkers/test_expectations.py:
572         * Tools/Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
573
574 2011-01-31  Scott Cameron  <sccameron@rim.com>
575
576         Reviewed by Daniel Bates.
577
578         update run-webkit-httpd to be able to launch Apache2.2 in a MSYS environment
579         https://bugs.webkit.org/show_bug.cgi?id=50036
580
581         This will add an Apache2.2 configuration file and modifies scripts to allow
582         running an httpd server in an MSYS environment.
583
584         The default Apache2.2 installation path has been preserved and PHP5 modules disabled
585         in order to allow for simple installation/execution.  Simply install the latest
586         Apache2.2 version with OpenSSL from http://httpd.apache.org/download.cgi#apache22 to
587         be able to execute run-webkit-httpd.
588         
589
590         * Scripts/run-webkit-httpd:
591         * Scripts/webkitperl/httpd.pm:
592
593 2011-01-31  Tony Chang  <tony@chromium.org>
594
595         Reviewed by Eric Seidel.
596
597         mac DRT should report RTL scroll offset relative to top right corner
598         https://bugs.webkit.org/show_bug.cgi?id=53324
599
600         * DumpRenderTree/mac/DumpRenderTree.mm:
601         (dumpFrameScrollPosition):
602
603 2011-01-31  Zoltan Horvath  <zoltan@webkit.org>
604
605         Reviewed by Andreas Kling.
606
607         [Qt] Add Take Screen Shot action to MiniBrowser
608         https://bugs.webkit.org/show_bug.cgi?id=53422
609
610         Add Take Screen Shot action to MiniBrowser's view menu.
611
612         * MiniBrowser/qt/BrowserWindow.cpp:
613         (BrowserWindow::BrowserWindow):
614         (BrowserWindow::screenshot):
615         * MiniBrowser/qt/BrowserWindow.h:
616
617 2011-01-31  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
618
619         Reviewed by Xan Lopez.
620
621         [GTK] REGRESSION:  http/tests/media/video-{cookie,referer}.html failing
622         https://bugs.webkit.org/show_bug.cgi?id=53379
623
624         Remove left over #ifdef's. I thought all of the conditional code
625         had been freed from the condition, but I forgot to check DRT.
626
627         * DumpRenderTree/gtk/DumpRenderTree.cpp:
628         (resetDefaultsToConsistentValues):
629         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
630         (LayoutTestController::setAlwaysAcceptCookies):
631
632 2011-01-30  Dirk Pranke  <dpranke@chromium.org>
633
634         Unreviewed, build fix.
635
636         Fix regression introduced in r77093 - path.rsplit() doesn't
637         take keyword arguments.
638
639         https://bugs.webkit.org/show_bug.cgi?id=53326
640
641         * Scripts/webkitpy/common/system/filesystem_mock.py:
642
643 2011-01-30  Dirk Pranke  <dpranke@chromium.org>
644
645         Reviewed by Mihai Parparita.
646
647         Add more unit tests for rebaseline-chromium-webkit-tests. This
648         change involves restructuring a bunch of r-c-w-t code to make it
649         more testable as well. We also add wrapper classes for handling
650         testing zip files and fetching URLs.
651
652         https://bugs.webkit.org/show_bug.cgi?id=53040
653
654         * Scripts/webkitpy/common/system/urlfetcher.py:
655         * Scripts/webkitpy/common/system/urlfetcher_mock.py:
656         * Scripts/webkitpy/common/system/zipfileset_mock.py:
657         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
658         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
659         * Scripts/webkitpy/tool/mocktool.py:
660
661 2011-01-30  Dirk Pranke  <dpranke@chromium.org>
662
663         Reviewed by Eric Seidel.
664
665         Clean up of the filesystem-related modules used in webkitpy.
666         I've added relpath() to the filesystem interface, modified
667         ospath.relpath() so that it could work with the filesystem
668         interface, and modified the fileset* routines to use the
669         filesystem interface consistently.
670
671         This patch also adds a close() routine to the fileset routines
672         to indicate that the caller is done with the fileset. This
673         allows zipfileset to clean up after itself when it creates
674         tempfiles to store downloads.
675
676         https://bugs.webkit.org/show_bug.cgi?id=53326
677
678         * Scripts/webkitpy/common/system/directoryfileset.py:
679         * Scripts/webkitpy/common/system/fileset.py:
680         * Scripts/webkitpy/common/system/filesystem.py:
681         * Scripts/webkitpy/common/system/filesystem_mock.py:
682         * Scripts/webkitpy/common/system/filesystem_unittest.py:
683         * Scripts/webkitpy/common/system/ospath.py:
684         * Scripts/webkitpy/common/system/zipfileset.py:
685         * Scripts/webkitpy/common/system/zipfileset_unittest.py:
686
687 2011-01-30  Balazs Kelemen  <kbalazs@webkit.org>
688
689         Reviewed by Csaba Osztrogonác.
690
691         [Qt][WK2]REGRESSION (r76991): Fix build errors
692         https://bugs.webkit.org/show_bug.cgi?id=53400
693
694         Revert the temporary build fix (http://trac.webkit.org/changeset/77088)
695         and remove WebKit2Prefix.h from the build.
696         * MiniBrowser/qt/MiniBrowser.pro:
697
698 2011-01-30  Csaba Osztrogonác  <ossy@webkit.org>
699
700         Unreviewed.
701
702         [Qt][WK2] Buildfix.
703
704         * MiniBrowser/qt/MiniBrowser.pro:
705
706 2011-01-28  Simon Fraser  <simon.fraser@apple.com>
707
708         Reviewed by Adam Roben.
709         
710         define NOMINMAX when building ImageDiff, as we do elsewhere.
711
712         Add various clampToInt() methods to MathExtras.h
713         https://bugs.webkit.org/show_bug.cgi?id=52910
714
715         * DumpRenderTree/win/ImageDiffCommon.vsprops:
716
717 2011-01-28  Maciej Stachowiak  <mjs@apple.com>
718
719         Reviewed by Darin Adler.
720
721         WebKitTestRunner needs layoutTestController.setPOSIXLocale
722         https://bugs.webkit.org/show_bug.cgi?id=42682
723
724         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
725         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
726         (WTR::InjectedBundle::resetLocalSettings):
727         (WTR::InjectedBundle::didReceiveMessage):
728         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
729         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
730         (WTR::LayoutTestController::setPOSIXLocale):
731         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
732
733 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
734  
735          Reviewed by Mihai Parparita.
736  
737          test-webkitpy: fix webkitpy.layout_tests.port.mac_unittest.MacTest.test_skipped_file_paths
738  
739          This patch re-enables this test and changes it to
740          handle all of the mac platform versions, not just the one
741          it is running on.
742  
743          https://bugs.webkit.org/show_bug.cgi?id=53356
744  
745          * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
746  
747 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
748
749         Unreviewed, build fix.
750
751         Take two. The fix in 77023 didn't work, because we were
752         still calling path.abspath_to_uri, which calls _cygpath under
753         the covers, and it appears the cygpath on the bots does
754         something different than it does on my machine. This patch
755         removes the calls to path.abspath_to_uri, so it should be safe.
756         If it doesn't work, I'll roll it out along with r76982 and 77023.
757
758         https://bugs.webkit.org/show_bug.cgi?id=53126
759
760         * Scripts/webkitpy/layout_tests/port/test.py:
761
762 2011-01-28  David Kilzer  <ddkilzer@apple.com>
763
764         <rdar://problem/8930699> build-webkit gives a bogus warning with newer versions of Xcode 
765         <http://webkit.org/b/53353>
766
767         Reviewed by Mark Rowe.
768
769         * Scripts/webkitdirs.pm:
770         (checkRequiredSystemConfig): Check the Xcode marketing version
771         in addition to the DevCoreTools build version before complaining
772         about an old version of Xcode.  Also make the Mac OS X version
773         check use Perl's built-in version string comparitor.
774
775 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
776
777         Unreviewed, build fix.
778
779         Work around breakage on Win 7 Release bot caused by r76982
780         and the fact that windows ports use "file:////" instead of
781         "file:///". Ideally the test code should be isolated from
782         this, but it isn't yet. Will fix properly in a bit.
783
784         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
785
786 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
787
788         Reviewed by Tony Chang.
789
790         new-run-webkit-tests: change worker model values to
791         "old-inline", "old-threads" in preparation for test_runner2 /
792         multiprocessing changes.
793
794         https://bugs.webkit.org/show_bug.cgi?id=53156
795
796         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
797         * Scripts/webkitpy/layout_tests/port/base.py:
798         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
799         * Scripts/webkitpy/layout_tests/port/mac.py:
800         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
801
802 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
803
804         Reviewed by Tony Chang.
805
806         committers.py - add an IRC nickname for dpranke
807         https://bugs.webkit.org/show_bug.cgi?id=53335
808
809         * Scripts/webkitpy/common/config/committers.py:
810
811 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
812
813         Reviewed by Tony Chang.
814
815         new-run-webkit-tests: add a "mock DRT" port implementation
816         and a separate class that emulates what we expect the
817         DumpRenderTree behavior to be.
818
819         This will eventually replace port/dryrun.py and allow us to get
820         better test coverage of the new-run-webkit-tests code as well as
821         a reference for what new-run-webkit-tests expects from DRT.
822
823         This is the first attempt at this, and it is pretty bare-boned. It
824         really only has been tested on the 'mac' port (and a little on
825         the 'chromium-mac' port.
826
827         https://bugs.webkit.org/show_bug.cgi?id=53126
828
829         * Scripts/webkitpy/common/system/filesystem_mock.py:
830         * Scripts/webkitpy/layout_tests/port/dryrun.py:
831         * Scripts/webkitpy/layout_tests/port/factory.py:
832         * Scripts/webkitpy/layout_tests/port/mock_drt.py: Added.
833         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Added.
834         * Scripts/webkitpy/layout_tests/port/test.py:
835
836 2011-01-28  Pratik Solanki  <psolanki@apple.com>
837
838         Unreviewed. Removing .swp file checked in by mistake.
839
840         * Scripts/.webkitdirs.pm.swp: Removed.
841
842 2011-01-28  Pratik Solanki  <psolanki@apple.com>
843
844         Reviewed by David Kilzer.
845
846         Space not necessary for undefined feature
847         https://bugs.webkit.org/show_bug.cgi?id=53317
848
849         * Scripts/build-webkit:
850
851 2011-01-28  Chang Shu  <chang.shu@nokia.com>
852
853         Reviewed by Andreas Kling.
854
855         Reset NetworkAccessManager to clean up credentials from previous tests.
856         This change causes no performance overhead either.
857         https://bugs.webkit.org/show_bug.cgi?id=36688
858
859         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
860         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
861         (WebCore::DumpRenderTree::open):
862         * DumpRenderTree/qt/DumpRenderTreeQt.h:
863
864 2011-01-28  Zoltan Horvath  <zoltan@webkit.org>
865
866         Reviewed by Andreas Kling.
867
868         [Qt] Add Zoom Text Only action to MiniBrowser
869         https://bugs.webkit.org/show_bug.cgi?id=53297
870
871         Add Zoom Text Only action to MiniBrowser's view menu, change zoom levels to avoid unnecessary divides.
872
873         * MiniBrowser/qt/BrowserWindow.cpp:
874         (BrowserWindow::BrowserWindow):
875         (BrowserWindow::zoomIn):
876         (BrowserWindow::zoomOut):
877         (BrowserWindow::resetZoom):
878         (BrowserWindow::toggleZoomTextOnly):
879         (BrowserWindow::applyZoom):
880         * MiniBrowser/qt/BrowserWindow.h:
881
882 2011-01-28  Adam Barth  <abarth@webkit.org>
883
884         Reviewed by Eric Seidel.
885
886         Add webkit-patch roll-chromium-deps
887         https://bugs.webkit.org/show_bug.cgi?id=53288
888
889         This command updates the Source/WebKit/chromium/DEPS file with the
890         last-known good revision of Chromium (or a revision specified on the
891         command line).  I'd eventually like to turn this into a SheriffBot
892         command, but this is the first step.
893
894         This patch somewhat sprawled because I needed to move a bunch of code
895         out of ChangeLog that should never have been there in the first place.
896         Also, I had to fix a bug in MockUser in order to test the new command.
897
898         * Scripts/webkitpy/common/checkout/api.py:
899         * Scripts/webkitpy/common/checkout/changelog.py:
900         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
901         * Scripts/webkitpy/common/checkout/deps.py: Added.
902         * Scripts/webkitpy/common/config/urls.py:
903         * Scripts/webkitpy/tool/commands/__init__.py:
904         * Scripts/webkitpy/tool/commands/download_unittest.py:
905         * Scripts/webkitpy/tool/commands/roll.py: Added.
906         * Scripts/webkitpy/tool/commands/roll_unittest.py: Added.
907         * Scripts/webkitpy/tool/commands/upload_unittest.py:
908         * Scripts/webkitpy/tool/mocktool.py:
909         * Scripts/webkitpy/tool/steps/__init__.py:
910         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py: Added.
911         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
912         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py: Added.
913         * Scripts/webkitpy/tool/steps/suggestreviewers_unittest.py:
914         * Scripts/webkitpy/tool/steps/updatechromiumdeps.py: Added.
915         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
916
917 2011-01-27  Greg Coletta  <greg.coletta@nokia.com>
918
919         Reviewed by Laszlo Gombos.
920
921         Get rid of prefix header dependency for WebKit2 build system
922         https://bugs.webkit.org/show_bug.cgi?id=50174
923
924         Change the style checker so that it enforces config.h include for
925         WebKit2.
926
927         * Scripts/webkitpy/style/checker.py:
928
929 2011-01-27  Maciej Stachowiak  <mjs@apple.com>
930
931         Reviewed by Darin Adler.
932
933         execCommand("Paste") doesn't work in WebKitTestRunner
934         https://bugs.webkit.org/show_bug.cgi?id=52785
935
936         Enable both of the settings needed to allow paste.
937         
938         * WebKitTestRunner/TestController.cpp:
939         (WTR::TestController::resetStateToConsistentValues):
940
941 2011-01-27  Jacob Dinu  <dinu.jacob@nokia.com>
942
943         Reviewed by Andreas Kling.
944
945         [Qt] QtTestBrowser: User input lost when toggling use of QGraphicsView
946         https://bugs.webkit.org/show_bug.cgi?id=48440
947
948         Preserve user input when toggling use of QGraphicsView
949
950         * QtTestBrowser/launcherwindow.cpp:
951         (LauncherWindow::initializeView):
952         (LauncherWindow::loadFinished):
953         * QtTestBrowser/launcherwindow.h:
954         * QtTestBrowser/mainwindow.cpp:
955         (MainWindow::addressUrl):
956         * QtTestBrowser/mainwindow.h:
957
958 2011-01-27  Dirk Pranke  <dpranke@chromium.org>
959
960         Reviewed by Mihai Parparita.
961
962         new-run-webkit-tests: turn off pixel tests correctly by default
963         for webkit-based ports. r70013 (bug 47510) used
964         port.set_option_default() to attempt to set default values, but
965         that didn't work correctly. I have removed set_option_default
966         for now since it was only being used in two places and in three
967         useless unit tests. There is a separate bug open to fix the
968         option parsing (48095), so this workaround is fine for now.
969
970         https://bugs.webkit.org/show_bug.cgi?id=53217
971
972         * Scripts/webkitpy/layout_tests/port/webkit.py:
973         * Scripts/webkitpy/layout_tests/port/base.py:
974         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
975
976 2011-01-27  Balazs Kelemen  <kbalazs@webkit.org>
977
978         Rubber-stamped by Ariya Hidayat.
979
980         Trivial crash fix in WTR.
981
982         * WebKitTestRunner/TestController.cpp:
983         (WTR::TestController::initialize): Increase the size
984         of the vector by one to be able to store the null character.
985
986 2011-01-27  Balazs Kelemen  <kbalazs@webkit.org>
987
988         Reviewed by Csaba Osztrogonác.
989
990         [Qt][WK2] WTR should be initialized in the same way as DRT
991         https://bugs.webkit.org/show_bug.cgi?id=53240
992
993         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
994         (WTR::activateFonts): Added missing initialization steps.
995
996 2011-01-27  Joone Hur <joone.hur@collabora.co.uk>
997
998         Unreviewed. 
999
1000         Adding myself to committers.py.
1001
1002         * Scripts/webkitpy/common/config/committers.py:
1003
1004 2011-01-27  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1005
1006         Reviewed by Csaba Osztrogonác.
1007
1008         [Qt] [Symbian] Move project files into Source
1009         https://bugs.webkit.org/show_bug.cgi?id=52891
1010
1011         Fix the Symbian build after the project files
1012         are moved to Source directory. On Symbian qmake
1013         needs to run in the same directory where the main
1014         pro files (WebKit.pro, Tools.pro) are located.
1015
1016         * Scripts/webkitdirs.pm: Change to the directory where the pro file
1017         is located before running qmake for Symbian. Qmake on Symbian
1018         does not properly honor the "-o" option, work it around by setting
1019         the name of the Makefile to bld.inf.
1020
1021 2011-01-27  Zoltan Horvath  <zoltan@webkit.org>
1022
1023         Reviewed by Andreas Kling.
1024
1025         [Qt] Add simple zooming features to MiniBrowser
1026         https://bugs.webkit.org/show_bug.cgi?id=53231
1027
1028         Add View menu and Zoom In, Zoom Out, Zoom Reset actions to MiniBrowser.
1029
1030         * MiniBrowser/qt/BrowserWindow.cpp:
1031         (BrowserWindow::BrowserWindow):
1032         (BrowserWindow::zoomIn):
1033         (BrowserWindow::zoomOut):
1034         (BrowserWindow::resetZoom):
1035         (BrowserWindow::updateUserAgentList):
1036         (BrowserWindow::applyZoom):
1037         * MiniBrowser/qt/BrowserWindow.h:
1038
1039 2011-01-26  Maciej Stachowiak  <mjs@apple.com>
1040
1041         Reviewed by Dan Bernstein.
1042
1043         WebKitTestRunner needs to support layoutTestController.evaluateInWebInspector
1044         https://bugs.webkit.org/show_bug.cgi?id=42319
1045         
1046         Add evaluateInWebInspector and other APIs needed for inspector tests to run.
1047
1048         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1049         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1050         (WTR::LayoutTestController::showWebInspector):
1051         (WTR::LayoutTestController::closeWebInspector):
1052         (WTR::LayoutTestController::evaluateInWebInspector):
1053         (WTR::LayoutTestController::setTimelineProfilingEnabled):
1054         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1055         * WebKitTestRunner/TestInvocation.cpp:
1056         (WTR::shouldOpenWebInspector):
1057         (WTR::TestInvocation::invoke):
1058         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
1059
1060 2011-01-26  Martin Robinson  <mrobinson@igalia.com>
1061
1062         Reviewed by Xan Lopez.
1063
1064         [GTK] Pixel dumps do not include scrollbars in output images
1065         https://bugs.webkit.org/show_bug.cgi?id=53216
1066
1067         Show scrollbars in pixel dumps. This will fix pixel dumps for tests
1068         that have scrollbars.
1069
1070         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
1071         (createBitmapContextFromWebView): Take the snapshot of the containing GtkScrolledWindow
1072         instead of the web view itself.
1073
1074 2011-01-26  Dirk Pranke  <dpranke@chromium.org>
1075
1076         Reviewed by Mihai Parparita.
1077
1078         Fix regression introduced in r76322 ... new-run-webkit-tests
1079         was attempting to save the image diff output as a UTF-8-encoded
1080         file.
1081
1082         https://bugs.webkit.org/show_bug.cgi?id=53210
1083
1084         * Scripts/webkitpy/layout_tests/port/webkit.py:
1085
1086 2011-01-26  Sheriff Bot  <webkit.review.bot@gmail.com>
1087
1088         Unreviewed, rolling out r76709.
1089         http://trac.webkit.org/changeset/76709
1090         https://bugs.webkit.org/show_bug.cgi?id=53194
1091
1092         "broke python tests on non-snowleopard platforms" (Requested
1093         by dpranke on #webkit).
1094
1095         * Scripts/webkitpy/layout_tests/port/factory.py:
1096         * Scripts/webkitpy/layout_tests/port/mock_drt.py: Removed.
1097         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Removed.
1098
1099 2011-01-26  Dirk Pranke  <dpranke@chromium.org>
1100
1101         Reviewed by Tony Chang.
1102
1103         new-run-webkit-tests: add a "mock DRT" port implementation
1104         and a separate class that emulates what we expect the
1105         DumpRenderTree behavior to be.
1106
1107         This will eventually replace port/dryrun.py and allow us to get
1108         better test coverage of the new-run-webkit-tests code as well as
1109         a reference for what new-run-webkit-tests expects from DRT.
1110
1111         This is the first attempt at this, and it is pretty bare-boned. It
1112         really only has been tested on the 'mac' port (and a little on
1113         the 'chromium-mac' port.
1114
1115         https://bugs.webkit.org/show_bug.cgi?id=53126
1116
1117         * Scripts/webkitpy/layout_tests/port/mock_drt.py: Added.
1118         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Added.
1119         * Scripts/webkitpy/layout_tests/port/factory.py:
1120
1121 2011-01-26  Xianzhu Wang  <wangxianzhu@google.com>
1122
1123         Reviewed by Tony Chang.
1124
1125         Add '--no-timeout' option to Chromium DRT to ease debugging.
1126         https://bugs.webkit.org/show_bug.cgi?id=52873
1127
1128         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1129         (main):
1130
1131 2011-01-26  Csaba Osztrogonác  <ossy@webkit.org>
1132
1133         Reviewed by Andreas Kling.
1134
1135         [Qt] Fix qt_minimal build
1136         https://bugs.webkit.org/show_bug.cgi?id=53172
1137
1138         * QtTestBrowser/locationedit.h:
1139
1140 2011-01-26  Mansi Mithal  <mansi.mithal@nokia.com>
1141
1142         Reviewed by Antonio Gomes.
1143
1144         QtTestBrowser should have a UI Setting to disable plugins
1145         https://bugs.webkit.org/show_bug.cgi?id=52408
1146         
1147         Added a new action item named "Disable Plugins"
1148         under the "Settings" menu. 
1149
1150         * QtTestBrowser/launcherwindow.cpp:
1151         (LauncherWindow::createChrome):
1152         (LauncherWindow::togglePlugins):
1153         * QtTestBrowser/launcherwindow.h:
1154
1155 2011-01-25  Patrick Gansterer  <paroga@webkit.org>
1156
1157         Reviewed by Adam Barth.
1158
1159         Move main CMakeLists.txt into Source directory
1160         https://bugs.webkit.org/show_bug.cgi?id=52888
1161
1162         * Scripts/webkitdirs.pm:
1163
1164 2011-01-25  Patrick Gansterer  <paroga@webkit.org>
1165
1166         Reviewed by Eric Seidel.
1167
1168         Improve label text in submit-to-ews
1169         https://bugs.webkit.org/show_bug.cgi?id=53130
1170
1171         * QueueStatusServer/templates/submittoews.html:
1172
1173 2011-01-25  Mansi Mithal  <mansi.mithal@nokia.com>
1174
1175         Reviewed by Antonio Gomes.
1176
1177         QtTestBrowser should have a UI Settings to prevent loading images
1178         https://bugs.webkit.org/show_bug.cgi?id=52409
1179         
1180         Added a new action item named "DisableAutoLoadImages"
1181         under the "Settings" menu 
1182
1183         * QtTestBrowser/launcherwindow.cpp:
1184         (LauncherWindow::createChrome):
1185         (LauncherWindow::toggleAutoLoadImages):
1186         * QtTestBrowser/launcherwindow.h:
1187
1188 2011-01-25  Dirk Pranke  <dpranke@chromium.org>
1189
1190         Reviewed by Tony Chang.
1191
1192         Minor bug fixes and cleanup for filesystem wrappers, port/* test
1193         classes, test_expectations.py. This change adds "test-win" and
1194         "test-mac" variants to the test port so that we can better test
1195         rebaselining, and adds a MockUser() object for reuse in testing.
1196
1197         https://bugs.webkit.org/show_bug.cgi?id=53036
1198
1199         * Scripts/webkitpy/common/system/filesystem.py:
1200         * Scripts/webkitpy/common/system/filesystem_mock.py:
1201         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1202         * Scripts/webkitpy/layout_tests/port/factory.py:
1203         * Scripts/webkitpy/layout_tests/port/base.py:
1204         * Scripts/webkitpy/layout_tests/port/test.py:
1205         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1206         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
1207         * Scripts/webkitpy/tool/mocktool.py:
1208
1209 2011-01-25  Tony Chang  <tony@chromium.org>
1210
1211         Reviewed by Dimitri Glazkov.
1212
1213         [chromium] remove unused layoutTestController callback
1214         https://bugs.webkit.org/show_bug.cgi?id=53103
1215
1216         This method is used by a test_shell_test, but not needed by DRT.
1217
1218         * DumpRenderTree/chromium/LayoutTestController.cpp:
1219         (LayoutTestController::LayoutTestController):
1220         * DumpRenderTree/chromium/LayoutTestController.h:
1221
1222 2011-01-25  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1223
1224         Reviewed by Andreas Kling.
1225
1226         [GTK] Remove 64 bits release bot from the buildbot master
1227         https://bugs.webkit.org/show_bug.cgi?id=52899
1228
1229         Removes the 64 bits release slave from the buildbot configuration,
1230         so that we can use it as an EWS.
1231
1232         * BuildSlaveSupport/build.webkit.org-config/config.json:
1233
1234 2011-01-24  Maciej Stachowiak  <mjs@apple.com>
1235
1236         Reviewed by Dan Bernstein.
1237
1238         Implement database quota callback to fix storage tests on WebKit2 bot
1239         https://bugs.webkit.org/show_bug.cgi?id=53064
1240
1241         * WebKitTestRunner/TestController.cpp:
1242         (WTR::exceededDatabaseQuota):
1243         (WTR::TestController::createOtherPage):
1244         (WTR::TestController::initialize):
1245
1246 2011-01-24  Maciej Stachowiak  <mjs@apple.com>
1247
1248         Reviewed by Anders Carlsson.
1249
1250         Use designated temp directory for the database for WebKit2
1251         https://bugs.webkit.org/show_bug.cgi?id=53052
1252         
1253         Adopt the new WK2 API for this.
1254
1255         * WebKitTestRunner/TestController.cpp:
1256         (WTR::TestController::libraryPathForTesting):
1257         (WTR::TestController::initialize):
1258         * WebKitTestRunner/TestController.h:
1259         * WebKitTestRunner/mac/TestControllerMac.mm:
1260         (WTR::TestController::platformLibraryPathForTesting):
1261         * WebKitTestRunner/qt/TestControllerQt.cpp:
1262         (WTR::TestController::platformLibraryPathForTesting):
1263         * WebKitTestRunner/win/TestControllerWin.cpp:
1264         (WTR::TestController::platformLibraryPathForTesting):
1265
1266 2011-01-24  Lucas Forschler  <lforschler@apple.com>
1267
1268         Reviewed by Stephanie Lewis.
1269
1270         Add a new Leopard test bot.
1271
1272         * BuildSlaveSupport/build.webkit.org-config/config.json:
1273
1274 2011-01-24  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1275
1276         Reviewed by Adam Barth.
1277
1278         Add EFL Builder to core waterfall
1279         https://bugs.webkit.org/show_bug.cgi?id=52704
1280
1281         Add EFL Builder to the core waterfall again.
1282
1283         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1284         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1285
1286 2011-01-24  Xianzhu Wang  <wangxianzhu@google.com>
1287
1288         Reviewed by Tony Chang.
1289
1290         new-run-webkit-tests fails to start HTTP server if there are proxy settings
1291         https://bugs.webkit.org/show_bug.cgi?id=52872
1292
1293         Force disabling proxy to resolve the problem.
1294
1295         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
1296         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
1297
1298 2011-01-24  Andreas Kling  <kling@webkit.org>
1299
1300         Reviewed by Darin Adler.
1301
1302         check-webkit-style: Update exemptions following Source/ move.
1303         https://bugs.webkit.org/show_bug.cgi?id=53017
1304
1305         * Scripts/webkitpy/style/checker.py:
1306         * Scripts/webkitpy/style/checker_unittest.py:
1307
1308 2011-01-24  Andras Becsi  <abecsi@webkit.org>
1309
1310         Rubber-stamped by Csaba Osztrogonác.
1311
1312         [Qt] Move project files into Source
1313         https://bugs.webkit.org/show_bug.cgi?id=52891
1314
1315         * DumpRenderTree/qt/ImageDiff.pro: Add missing "Source" to WebKit.pri path
1316
1317 2011-01-24  Mikhail Naganov  <mnaganov@chromium.org>
1318
1319         Reviewed by Yury Semikhatsky.
1320
1321         Web Inspector: Find duplicate strings in localizedStrings.js
1322
1323         https://bugs.webkit.org/show_bug.cgi?id=53005
1324
1325         * Scripts/check-inspector-strings:
1326
1327 2011-01-24  Zoltan Horvath  <zoltan@webkit.org>
1328
1329         Reviewed by Andreas Kling.
1330
1331         [Qt] Regroup MiniBrowser's menubar and add open file action
1332         https://bugs.webkit.org/show_bug.cgi?id=53000
1333
1334         Add File and Develop menu to MiniBrowser's menubar and add open file action to File menu.
1335
1336         * MiniBrowser/qt/BrowserWindow.cpp:
1337         (BrowserWindow::BrowserWindow):
1338         (BrowserWindow::openFile):
1339         (BrowserWindow::~BrowserWindow):
1340         * MiniBrowser/qt/BrowserWindow.h:
1341
1342 2011-01-24  Csaba Osztrogonác  <ossy@webkit.org>
1343
1344         Unreviewed fix after r76496
1345
1346         [Qt] Move project files into Source
1347         https://bugs.webkit.org/show_bug.cgi?id=52891
1348
1349         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Remove unnecessary "Source" from the path.
1350         * BuildSlaveSupport/built-product-archive: Remove unnecessary "Source" from the path.
1351         * Scripts/webkitdirs.pm: Add the accidentally removed slash to the path.
1352
1353 2011-01-24  Andras Becsi  <abecsi@webkit.org>
1354
1355         Reviewed by Csaba Osztrogonác.
1356
1357         [Qt] Move project files into Source
1358         https://bugs.webkit.org/show_bug.cgi?id=52891
1359
1360         * DerivedSources.pro: Renamed from DerivedSources.pro.
1361         * DumpRenderTree/qt/DumpRenderTree.pro:
1362         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1363         * MiniBrowser/DerivedSources.pro:
1364         * MiniBrowser/qt/MiniBrowser.pro:
1365         * QtTestBrowser/QtTestBrowser.pro:
1366         * Scripts/webkitdirs.pm:
1367         * Tools.pro: Added.
1368         * WebKitTestRunner/DerivedSources.pro:
1369         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1370         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1371
1372 2011-01-22  Geoffrey Garen  <ggaren@apple.com>
1373
1374         Reviewed by Dan Bernstein.
1375
1376         Beefed up --threaded mode to catch even more kinds of errors.
1377         https://bugs.webkit.org/show_bug.cgi?id=52971
1378
1379         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Use a shared
1380         context group to force JSC to mark multiple threads. (This used to be
1381         the default, but it changed in SnowLeopard.)
1382         (runJavaScriptThread): Do more locking and unlocking, and more allocation,
1383         to give threading mistakes more chances to show themselves.
1384         (startJavaScriptThreads):
1385         (stopJavaScriptThreads):
1386
1387 2011-01-22  Robert Hogan  <robert@webkit.org>
1388
1389         Reviewed by Andreas Kling.
1390
1391         [Qt] Support layoutTestController.addURLToRedirect()
1392         https://bugs.webkit.org/show_bug.cgi?id=52956
1393
1394         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1395         (LayoutTestController::addURLToRedirect):
1396         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1397
1398 2011-01-22  Robert Hogan  <robert@webkit.org>
1399
1400         Reviewed by Kenneth Rohde Christiansen.
1401
1402         [Qt] REGRESSION (r72360): http/tests/security/aboutBlank/xss-DENIED-* tests fail
1403         https://bugs.webkit.org/show_bug.cgi?id=49802
1404
1405         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1406         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1407         (WebCore::DumpRenderTree::open):
1408
1409 2011-01-21  Adam Barth  <abarth@webkit.org>
1410
1411         Reviewed by Maciej Stachowiak.
1412
1413         Disable mac_unittest.py that fails on some of the Mac bots
1414         https://bugs.webkit.org/show_bug.cgi?id=52947
1415
1416         As noted in the comment, this test does not appear to be correct
1417         because the function this test is testing returns different results
1418         depending on which flavor of Mac the test is run on.  This patch
1419         disable the test.  Hopefully we can re-enable the test once we've
1420         probably insulated the test from its environment.
1421
1422         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1423
1424 2011-01-21  Dirk Pranke  <dpranke@chromium.org>
1425
1426         Reviewed by Mihai Parparita.
1427
1428         Fix bug introduced in r76322 that caused NRWT to not actually
1429         read the Skipped files properly.
1430
1431         https://bugs.webkit.org/show_bug.cgi?id=52771
1432
1433         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1434         * Scripts/webkitpy/layout_tests/port/webkit.py:
1435         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1436
1437 2011-01-21  Sam Weinig  <sam@webkit.org>
1438
1439         Reviewed by Geoffrey Sean Garen and Mark Rowe.
1440
1441         WebKitTestRunner needs the HOME environment variable to be set.
1442         <rdar://problem/8896573>
1443
1444         * Scripts/old-run-webkit-tests: Set the HOME environment variable if
1445         it exists.
1446
1447 2011-01-21  Dirk Pranke  <dpranke@chromium.org>
1448
1449         Reviewed by Eric Seidel.
1450
1451         Suppress a few remaining integration tests so that none of the
1452         layout_test unit tests ever read from the filesystem or launch
1453         subprocesses that aren't part of the unit tests.
1454
1455         Also fix a minor bug in the printing unit tests that was
1456         incorrectly relying on sys.argv.
1457
1458         https://bugs.webkit.org/show_bug.cgi?id=52863
1459
1460         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1461         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1462         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1463
1464 2011-01-21  Darin Adler  <darin@apple.com>
1465
1466        Fix Mac build.
1467
1468         * MiniBrowser/mac/BrowserWindowController.m:
1469         (-[BrowserWindowController awakeFromNib]): Pass 0 for runModal function.
1470
1471 2011-01-20  Darin Adler  <darin@apple.com>
1472
1473         Reviewed by Dan Bernstein.
1474
1475         WebKit2: Implement showModalDialog
1476         https://bugs.webkit.org/show_bug.cgi?id=52855
1477
1478         This fixes WebKitTestRunner to compile, but more work is probably
1479         needed to get it to pass the tests.
1480
1481         * WebKitTestRunner/TestController.cpp:
1482         (WTR::TestController::runModal): Added. Calls through to the
1483         platform-specific version of runModal.
1484         (WTR::TestController::createOtherPage): Changed to be a private
1485         static member function so it can refer to runModal, which is
1486         a private static member function.
1487         (WTR::TestController::initialize): Pass 0 for the runModal
1488         function since we don't need to run the main window modal.
1489         I suspect this is wrong and will need to change.
1490         * WebKitTestRunner/TestController.h: Added declarations for
1491         the functions added above.
1492         * WebKitTestRunner/mac/TestControllerMac.mm:
1493         (WTR::TestController::runModal): Added. Untested implementation.
1494         * WebKitTestRunner/qt/TestControllerQt.cpp:
1495         (WTR::TestController::runModal): Added.
1496         * WebKitTestRunner/win/TestControllerWin.cpp:
1497         (WTR::TestController::runModal): Added.
1498
1499 2011-01-21  Eric Seidel  <eric@webkit.org>
1500
1501         Reviewed by Adam Barth.
1502
1503         Split Host object off from WebKitPatch for easier re-use
1504         https://bugs.webkit.org/show_bug.cgi?id=52284
1505
1506         new-run-webkit-tests and other tools are eventually going to want one of these.
1507         Basically you need to inherit from this class if you want to pretend to be a
1508         self.tool object for Steps/Commands.
1509
1510         * Scripts/webkitpy/common/host.py: Added.
1511         * Scripts/webkitpy/tool/main.py:
1512
1513 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1514
1515         Reviewed by Adam Barth.
1516
1517         Disable the tests that start and stop the http server and web
1518         server, so that we don't have to worry about port collisions on
1519         the bots.
1520
1521         https://bugs.webkit.org/show_bug.cgi?id=52861
1522
1523         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1524
1525 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1526
1527         Reviewed by Eric Seidel.
1528
1529         nrwt: rewrite google_chrome_unittest to use mock filesystem.
1530         
1531         https://bugs.webkit.org/show_bug.cgi?id=52772
1532         
1533         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
1534
1535 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1536
1537         Reviewed by Eric Siedel.
1538
1539         nrwt: clean up almost all remaining port references, remove
1540         unnecessary import clauses. The only remaining references are
1541         in places where a mock filesystem makes no sense or can't be
1542         used, and in one routine in port/google_chrome_unittest that
1543         I'll rewrite in a separate patch.
1544
1545         https://bugs.webkit.org/show_bug.cgi?id=52771
1546
1547         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1548         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1549         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1550         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1551         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1552         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1553         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1554         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
1555         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
1556         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
1557         * Scripts/webkitpy/layout_tests/port/gtk.py:
1558         * Scripts/webkitpy/layout_tests/port/mac.py:
1559         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1560         * Scripts/webkitpy/layout_tests/port/qt.py:
1561         * Scripts/webkitpy/layout_tests/port/webkit.py:
1562         * Scripts/webkitpy/layout_tests/port/win.py:
1563         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
1564
1565 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1566
1567         Reviewed by Mihai Parparita.
1568
1569         remove fs refs from run_webkit_tests, rebaseline_chromium_webkit_tests
1570
1571         https://bugs.webkit.org/show_bug.cgi?id=52762
1572
1573         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1574         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1575
1576 2011-01-20  Tony Chang  <tony@chromium.org>
1577
1578         Reviewed by Ojan Vafai.
1579
1580         [chromium] fix the paths used for the rebaseline tool
1581         https://bugs.webkit.org/show_bug.cgi?id=52857
1582
1583         Some of the bots were renamed so the path to grab the results zip
1584         file has changed.
1585
1586         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1587
1588 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1589
1590         Reviewed by Tony Chang.
1591
1592         Fix bug introduced in r72688 / bug 52768 that broke the
1593         generation of the output filename links in the results.html
1594         output. Apparently none of the unit tests actually checked to
1595         make sure the generated links were correct :(
1596
1597         https://bugs.webkit.org/show_bug.cgi?id=52854
1598
1599         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1600         * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
1601
1602 2011-01-20  Alexey Proskuryakov  <ap@apple.com>
1603
1604         Reviewed by Darin Adler.
1605
1606         https://bugs.webkit.org/show_bug.cgi?id=52849
1607         Make window.print work with WebKit2
1608
1609         * MiniBrowser/mac/BrowserWindowController.m:
1610         (-[BrowserWindowController awakeFromNib]):
1611         * WebKitTestRunner/TestController.cpp:
1612         (WTR::createOtherPage):
1613         (WTR::TestController::initialize):
1614         Added zeroes to WKPageUIClient structures to avoid build failures.
1615
1616 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1617
1618         Reviewed by Eric Seidel.
1619
1620         nrwt: remove fs refs from printing, test_failures, test_expectations, text_diff
1621
1622         https://bugs.webkit.org/show_bug.cgi?id=52756
1623
1624         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1625         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1626         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1627         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
1628         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1629         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
1630
1631 2011-01-20  Mansi Mithal  <mansi.mithal@nokia.com>
1632
1633         Reviewed by Antonio Gomes.
1634
1635         QtTestBrowser should have a seperate menu for Settings
1636         https://bugs.webkit.org/show_bug.cgi?id=52817
1637         
1638         Added a new menu item named "Settings"
1639         and moved the "Enable interrupting js scripts" and "Enable js pop up windows" under the "Settings" menu 
1640
1641         * QtTestBrowser/launcherwindow.cpp:
1642         (LauncherWindow::createChrome):
1643
1644 2011-01-20  Sam Weinig  <sam@webkit.org>
1645
1646         Reviewed by John Sullivan.
1647
1648         Update update-webkit-localizable-strings with new path to WebKit.
1649
1650         * Scripts/update-webkit-localizable-strings:
1651
1652 2011-01-20  James Robinson  <jamesr@chromium.org>
1653
1654         Reviewed by Darin Fisher.
1655
1656         Implement mozilla's requestAnimationFrame API
1657         https://bugs.webkit.org/show_bug.cgi?id=51218
1658
1659         Chromium DumpRenderTree support for window.webkitRequestAnimationFrame.
1660
1661         * DumpRenderTree/chromium/WebViewHost.cpp:
1662         (invokeScheduleComposite):
1663         (WebViewHost::scheduleAnimation):
1664         (WebViewHost::paintInvalidatedRegion):
1665         * DumpRenderTree/chromium/WebViewHost.h:
1666
1667 2011-01-20  Maciej Stachowiak  <mjs@apple.com>
1668
1669         Reviewed by Adam Roben.
1670
1671         WebKitTestRunner needs to support layoutTestController.evaluateScriptInIsolatedWorld
1672         https://bugs.webkit.org/show_bug.cgi?id=42327
1673
1674         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm: Add support
1675         for methods that take their normal arguments but also a JSContextRef.
1676         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: IDL definition
1677         for evaluateScriptInIsolatedWorld.
1678         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1679         (WTR::InjectedBundlePage::didClearWindowForFrame): Set a magic variable only if
1680         this call is for an isolated world.
1681         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1682         (WTR::worldMap): Helper to create a world map.
1683         (WTR::LayoutTestController::worldIDForWorld): Map from an ID to a world.
1684         (WTR::LayoutTestController::evaluateScriptInIsolatedWorld): The newly
1685         added LayoutTestController API.
1686         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1687
1688 2011-01-19  Adam Roben  <aroben@apple.com>
1689
1690         Convert paths in environment variables back to msys-style inside commit-log-editor
1691
1692         When this script gets run from inside git commit, msys-style paths in the environment will
1693         have been turned into Windows-style paths with forward slashes. This screws up functions
1694         like File::Spec->rel2abs, which seem to rely on $PWD having an msys-style path. We convert
1695         the paths back to msys-style before doing anything else.
1696
1697         Fixes <http://webkit.org/b/48527> commit-log-editor uses full paths for section headers when
1698         using msysgit's Perl and multiple ChangeLogs have been edited
1699
1700         Reviewed by David Kilzer.
1701
1702         * Scripts/commit-log-editor: Call fixEnvironment before doing anything else.
1703         (fixEnvironment): Added. When run in msys in conjunction with git (i.e., when invoked from
1704         inside git commit), convert Windows-style paths in the environment back to msys-style paths.
1705
1706 2011-01-20  Zoltan Horvath  <zoltan@webkit.org>
1707
1708         [Win] Unreviewed build fix after r76248.
1709
1710         * DumpRenderTree/ForwardingHeaders/wtf/FastAllocBase.h: Added.
1711
1712 2011-01-20  Zoltan Horvath  <zoltan@webkit.org>
1713
1714         Reviewed by Csaba Osztrogonác.
1715
1716         Refactoring of the custom allocation framework
1717         https://bugs.webkit.org/show_bug.cgi?id=49897
1718
1719         Inheriting from FastAllocBase can result in objects getting larger (bug #33896, #46589).
1720         The modification replaces Noncopyable and FastAllocBase classes and these inherits with their
1721         equivalent macro implementation at the necessary places.
1722 2011-01-20  Yi Shen  <yi.4.shen@nokia.com>
1723
1724         Unreviewed. 
1725
1726         Adding myself to committers.py.
1727
1728         * Scripts/webkitpy/common/config/committers.py:
1729
1730 2011-01-20  Adam Barth  <abarth@webkit.org>
1731
1732         Reviewed by Tony Chang.
1733
1734         Chromium builders don't delete unversioned directories when DEPS change
1735         https://bugs.webkit.org/show_bug.cgi?id=52745
1736
1737         If we pass this option to gclient sync, gclient will delete directories
1738         that are no longer part of DEPS instead of leaving them around to
1739         confuse us later.  Apparently, the downstream buildbots use this option
1740         already.
1741
1742         * Scripts/update-webkit-chromium:
1743
1744 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1745
1746         Unreviewed, build fix - I pulled this patch in to fix an issue
1747         revealed by r76195 running on some new bots). Also fix a couple
1748         of other issues revealed in testing.
1749
1750         nrwt: remove fs refs from layout_package/json*
1751
1752         https://bugs.webkit.org/show_bug.cgi?id=52754
1753
1754         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1755         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1756         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
1757         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1758         * Scripts/webkitpy/layout_tests/port/base.py:
1759
1760 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1761
1762         Unreviewed, build fix.
1763
1764         Fix a couple of minor bugs discovered while bringing up new bots
1765         for testing.
1766
1767         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1768         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1769
1770 2011-01-19  James Robinson  <jamesr@chromium.org>
1771
1772         Unreviewed, rolling out r76194.
1773         http://trac.webkit.org/changeset/76194
1774         https://bugs.webkit.org/show_bug.cgi?id=51218
1775
1776         Caused mysterious compile failure on the chromium win
1777         build.webkit.org bots
1778
1779         * DumpRenderTree/chromium/WebViewHost.cpp:
1780         (WebViewHost::paintInvalidatedRegion):
1781         * DumpRenderTree/chromium/WebViewHost.h:
1782
1783 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1784
1785         Reviewed by Mihai Parparita.
1786
1787         remove fs refs from test_runner, dump_render_tree_thread
1788
1789         https://bugs.webkit.org/show_bug.cgi?id=52753
1790
1791         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1792         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1793         * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
1794         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1795
1796 2011-01-19  James Robinson  <jamesr@chromium.org>
1797
1798         Reviewed by Darin Fisher.
1799
1800         Implement mozilla's requestAnimationFrame API
1801         https://bugs.webkit.org/show_bug.cgi?id=51218
1802
1803         Chromium DumpRenderTree support for window.webkitRequestAnimationFrame.
1804
1805         * DumpRenderTree/chromium/WebViewHost.cpp:
1806         (invokeScheduleComposite):
1807         (WebViewHost::scheduleAnimation):
1808         (WebViewHost::paintInvalidatedRegion):
1809         * DumpRenderTree/chromium/WebViewHost.h:
1810
1811 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1812
1813         Unreviewed, build fix.
1814
1815         Fix a few incorrect "self._filesystem" references introduced in
1816         r76184.
1817
1818         * Scripts/webkitpy/layout_tests/port/chromium.py:
1819         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1820
1821 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1822
1823         Reviewed by Mihai Parparita.
1824
1825         add a .sep property, abspath(), isabs(), mtime(), and
1826         open_text_file_for_writing() to filesystem modules. Some of
1827         these properties are not needed in this patch but will be needed
1828         in subsequent patches (I'm doing this to avoid having to track
1829         multiple versions of a single file).
1830
1831         Also, change most of the port/* modules to use the filesystem
1832         objects instead of referencing the filesystem directly.
1833
1834         https://bugs.webkit.org/show_bug.cgi?id=52748
1835
1836         * Scripts/webkitpy/common/system/filesystem.py:
1837         * Scripts/webkitpy/common/system/filesystem_mock.py:
1838         * Scripts/webkitpy/layout_tests/port/__init__.py:
1839         * Scripts/webkitpy/layout_tests/port/base.py:
1840         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1841         * Scripts/webkitpy/layout_tests/port/chromium.py:
1842         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1843         * Scripts/webkitpy/layout_tests/port/config.py:
1844         * Scripts/webkitpy/layout_tests/port/test.py:
1845         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
1846
1847 2011-01-19  Maciej Stachowiak  <mjs@apple.com>
1848
1849         Reviewed by Anders Carlsson.
1850
1851         If resetting between tests times out, treat it as a WebProcess crash
1852         https://bugs.webkit.org/show_bug.cgi?id=52757
1853
1854         * WebKitTestRunner/TestController.cpp:
1855         (WTR::TestController::runTest):
1856
1857 2011-01-19  Alexey Proskuryakov  <ap@apple.com>
1858
1859         Reviewed by Darin Adler.
1860
1861         https://bugs.webkit.org/show_bug.cgi?id=52739
1862         Make it possible for a WebKit2 client to print headers and footers
1863
1864         Added dummy implementations for new printing UIClient calls.
1865
1866         * MiniBrowser/mac/BrowserWindowController.m:
1867         (-[BrowserWindowController awakeFromNib]):
1868         * WebKitTestRunner/TestController.cpp:
1869         (WTR::createOtherPage):
1870         (WTR::TestController::initialize):
1871
1872 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1873
1874         Reviewed by Ojan Vafai.
1875
1876         Change webkitpy/layout_tests/port/test.py to use the
1877         in-memory filesystem for cleaner unit testing. This
1878         change allows us to kill a lot of code that was
1879         specific to the test port, at the cost of being a
1880         little less clear about how things would work if
1881         you didn't have a filesystem.
1882
1883         https://bugs.webkit.org/show_bug.cgi?id=52605
1884
1885         * Scripts/webkitpy/layout_tests/port/test.py:
1886
1887 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1888
1889         Unreviewed, build fix.
1890
1891         Fix test failure caused by committing attachment 79368 instead
1892         of attachment 79461 on bug 52604.
1893
1894         * Scripts/webkitpy/common/system/filesystem_mock.py:
1895
1896 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1897
1898         Reviewed by Mihai Parparita.
1899
1900         new-run-webkit-tests: remove use of os.walk, use mock filesystem for better
1901         unit testing. os.walk() is too much of a hassle to implement on
1902         top of the in-memory mock filesystem and adding the necessary
1903         interface to files_under() gives clients a cleaner API anyway
1904         (for this particular usage model).
1905
1906         https://bugs.webkit.org/show_bug.cgi?id=52691
1907
1908         * Scripts/webkitpy/common/system/filesystem.py:
1909         * Scripts/webkitpy/common/system/filesystem_mock.py:
1910         * Scripts/webkitpy/layout_tests/port/test_files.py:
1911         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
1912
1913 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1914
1915         Reviewed by Tony Chang.
1916
1917         Change more modules in the layout-tests code to use the
1918         filesystem wrapper for cleaner unit testing.
1919
1920         This patch also adds the glob() wrapper to the filesystem
1921         abstraction.
1922         
1923         https://bugs.webkit.org/show_bug.cgi?id=52604
1924
1925         * Scripts/webkitpy/layout_tests/port/test_files.py:
1926         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
1927         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
1928         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1929         * Scripts/webkitpy/common/system/filesystem.py:
1930         * Scripts/webkitpy/common/system/filesystem_mock.py:
1931
1932 2011-01-19  Levi Weintraub  <leviw@chromium.org>
1933
1934         Unreviewed.
1935
1936         Updating my email addresses and irc nick.
1937
1938         * Scripts/webkitpy/common/config/committers.py:
1939
1940 2011-01-19  Tony Chang  <tony@chromium.org>
1941
1942         Reviewed by Mihai Parparita.
1943
1944         [chromium] [linux] if check-sys-deps fails, output the failure reason
1945         https://bugs.webkit.org/show_bug.cgi?id=52671
1946
1947         * Scripts/webkitpy/common/system/executive_mock.py: Add support for
1948             error handler functions.
1949         * Scripts/webkitpy/layout_tests/port/chromium.py:
1950             output the error text from --check-sys-deps
1951         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1952
1953 2011-01-19  Aparna Nandyal  <aparna.nand@wipro.com>
1954
1955         Reviewed by Andreas Kling.
1956
1957         [Qt] QtTestBrowser crashes when closing if Facebook is opened
1958         https://bugs.webkit.org/show_bug.cgi?id=52554
1959         
1960         QtNetworkAccessManager is created in a thread and set as
1961         member variable in QWebPage. When the thread is destroyed
1962         the object is still used. So fix will set the object to
1963         NULL once the thread is destroyed.
1964
1965         * QtTestBrowser/launcherwindow.cpp:
1966         (LauncherWindow::~LauncherWindow):
1967
1968 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
1969
1970         Rubber stamped by Csaba Osztrogonac
1971
1972         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: Removed unncessary inculde of WKStringCF.h
1973
1974 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
1975
1976         Reviewed by Tony Chang.
1977
1978         new-run-webkit-tests: add a --build-directory command line argument
1979
1980         Official Google Chrome builds use a non-standard build directory
1981         location. This patch adds a --build-directory argument that
1982         allows that location to be specified on the command line. Only
1983         Chromium-based builds will use this flag for now, but anyone can
1984         in the future.
1985
1986         There are no unit tests for this since it's difficult to test
1987         until mock filesystems are fully supported in the code. This was
1988         tested by hand for now.
1989
1990         https://bugs.webkit.org/show_bug.cgi?id=52694
1991
1992         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1993         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1994         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1995         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1996
1997 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
1998
1999         Not reviewed. Bot fix.
2000
2001         Remove an inadvertently committed debugging print.
2002
2003         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2004         (LayoutTestController::notifyDone):
2005
2006 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
2007
2008         Reviewed by Sam Weinig.
2009
2010         WebKitTestRunner should track loading more like DumpRenderTree
2011         https://bugs.webkit.org/show_bug.cgi?id=52692
2012
2013         Change load tracking to track the current top loading frame, in the manner of DumpRenderTree.
2014         This makes some tests that call notifyDone multiple times pass.
2015         
2016         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2017         (WTR::InjectedBundle::InjectedBundle):
2018         (WTR::InjectedBundle::done):
2019         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2020         (WTR::InjectedBundle::topLoadingFrame):
2021         (WTR::InjectedBundle::setTopLoadingFrame):
2022         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2023         (WTR::InjectedBundlePage::InjectedBundlePage):
2024         (WTR::InjectedBundlePage::stopLoading):
2025         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
2026         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
2027         (WTR::InjectedBundlePage::didFinishLoadForFrame):
2028         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
2029         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2030         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2031         (WTR::LayoutTestController::notifyDone):
2032         * WebKitTestRunner/TestController.cpp:
2033         (WTR::TestController::didReceiveMessageFromInjectedBundle):
2034
2035 2011-01-18  Mihai Parparita  <mihaip@chromium.org>
2036
2037         Reviewed by Kent Tamura.
2038
2039         [Chromium] NRWT looking for DRT binary in the wrong path on Mac
2040         https://bugs.webkit.org/show_bug.cgi?id=52678
2041         
2042         Update path now that WebKit is inside Source.
2043
2044         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2045
2046 2011-01-18  Robert Hogan  <robert@webkit.org>
2047
2048         Reviewed by Simon Hausmann.
2049
2050         [Qt] http/tests/incremental/slow-utf8-text.pl fails
2051         https://bugs.webkit.org/show_bug.cgi?id=44282
2052
2053         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2054         (WebCore::DumpRenderTree::dump):
2055
2056 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
2057
2058         Reviewed by Mihai Parparita.
2059
2060         Fix a small race condition that could cause the unit tests for
2061         new-run-webkit-tests to fail in a multithreaded environment.
2062         There was a small window in the code where one thread would
2063         check to see if a thread had raised an exception, do something,
2064         and then check to see if the thread was alive. If the other
2065         thread raised an exception and exited in between these two
2066         steps, the exception would be lost. Flipping the order of the
2067         two checks fixes the race, since we will now always check for an
2068         exception on the thread before exiting.
2069
2070         https://bugs.webkit.org/show_bug.cgi?id=51579
2071
2072         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
2073
2074 2011-01-18  Eric Seidel  <eric@webkit.org>
2075
2076         Reviewed by Adam Barth.
2077
2078         commit-queue dies when test archiving fails
2079         https://bugs.webkit.org/show_bug.cgi?id=52617
2080
2081         I looked at the machine and it had 10 archives already
2082         thus find_unused_name was returning None.  I've upped
2083         the limit to 100 (per bug) and tested the case where
2084         find_unused_name returns None (making archive return None).
2085
2086         * Scripts/webkitpy/common/system/workspace.py:
2087         * Scripts/webkitpy/common/system/workspace_unittest.py:
2088         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2089         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2090         * Scripts/webkitpy/tool/commands/queues.py:
2091
2092 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
2093
2094         Reviewed by Ojan Vafai.
2095
2096         Update rebaseline-chromium-webkit-tests unit tests to use a mock
2097         filesystem. Also fix a couple of "with" statements missed by
2098         r76050.
2099
2100         https://bugs.webkit.org/show_bug.cgi?id=52487
2101
2102         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
2103
2104 2011-01-18  Sergio Villar Senin  <svillar@igalia.com>
2105
2106         Reviewed by Martin Robinson.
2107
2108         [Gtk] Build fixes for gtk3 build
2109         https://bugs.webkit.org/show_bug.cgi?id=52648
2110
2111         * DumpRenderTree/gtk/EventSender.cpp:
2112         (beginDragWithFilesCallback):
2113
2114 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
2115
2116         Reviewed by Mihai Parparita.
2117
2118         Update rebaseline-chromium-webkit-tests to use filesystem objects
2119         instead of direct references to os.path, shutil, tempfile, etc.
2120
2121         This patch doesn't change anything, but will allow subsequent
2122         patches to change the unit tests to no longer use the real
2123         filesystem.
2124
2125         This patch adds a bunch more methods to the filesystem object as
2126         well.
2127
2128         https://bugs.webkit.org/show_bug.cgi?id=52482
2129
2130         * Scripts/webkitpy/common/system/filesystem.py:
2131         * Scripts/webkitpy/common/system/filesystem_mock.py:
2132         * Scripts/webkitpy/tool/commands/queues.py:
2133         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2134         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
2135
2136 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
2137
2138         Reviewed by Mihai Parparita.
2139
2140         new-run-webkit-tests shouldn't crash when you try to run a
2141         directory containing only skipped files.
2142
2143         https://bugs.webkit.org/show_bug.cgi?id=52478
2144         
2145         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2146         * Scripts/webkitpy/layout_tests/port/test.py:
2147         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2148
2149 2011-01-18  Adam Bergkvist  <adam.bergkvist@ericsson.com> and Martin Robinson  <mrobinson@igalia.com>
2150
2151         Reviewed by Gustavo Noronha Silva.
2152
2153         [GTK] The GTK+ EventSender needs support for beginDragWithFiles
2154         https://bugs.webkit.org/show_bug.cgi?id=40833
2155
2156         * DumpRenderTree/gtk/EventSender.cpp: Add a beginDragWithFiles implementation for the
2157         GTK+ event sender.
2158         (dragWithFilesDragDataGetCallback): Added.
2159         (dragWithFilesDragEndCallback): Added.
2160         (beginDragWithFilesCallback): Added.
2161
2162 2011-01-18  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2163
2164         Reviewed by Adam Barth.
2165
2166         ews: Add additional watcher to efl ews
2167         https://bugs.webkit.org/show_bug.cgi?id=52613
2168
2169         Add gyuyoung.kim@samsung.com to watcher list of efl-ews.
2170
2171         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2172
2173 2011-01-17  Tony Gentilcore  <tonyg@chromium.org>
2174
2175         Reviewed by Alexey Proskuryakov.
2176
2177         Fix some headers with missing or misspelled #ifndef guards
2178         https://bugs.webkit.org/show_bug.cgi?id=52545
2179
2180         * DumpRenderTree/chromium/TestEventPrinter.h:
2181         * DumpRenderTree/chromium/WebPreferences.h:
2182
2183 2011-01-17  Jessie Berlin  <jberlin@apple.com>
2184
2185         Reviewed by Anders Carlsson.
2186
2187         REGRESSION: Assertion failure in FrameLoader::continueLoadAfterWillSubmitForm() when
2188         navigating back to an unreachable URL
2189         https://bugs.webkit.org/show_bug.cgi?id=52388
2190
2191         Add a third parameter (unreachableURL) to queueLoadHTMLString.
2192
2193         * DumpRenderTree/LayoutTestController.cpp:
2194         (queueLoadHTMLStringCallback):
2195         (LayoutTestController::queueLoadHTMLString):
2196         (LayoutTestController::queueLoadAlternateHTMLString):
2197         * DumpRenderTree/LayoutTestController.h:
2198
2199         * DumpRenderTree/WorkQueueItem.h:
2200         (LoadHTMLStringItem::LoadHTMLStringItem):
2201
2202         * DumpRenderTree/chromium/LayoutTestController.cpp:
2203         (WorkItemLoadHTMLString::WorkItemLoadHTMLString):
2204         (WorkItemLoadHTMLString::run):
2205         (LayoutTestController::queueLoadHTMLString):
2206
2207         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
2208         (LoadHTMLStringItem::invoke):
2209         * DumpRenderTree/mac/WorkQueueItemMac.mm:
2210         (LoadHTMLStringItem::invoke):
2211         * DumpRenderTree/win/WorkQueueItemWin.cpp:
2212         (LoadHTMLStringItem::invoke):
2213
2214 2011-01-17  Dan Bernstein  <mitz@apple.com>
2215
2216         Rubber-stamped by Mark Rowe.
2217
2218         Update xcodeproj svn:ignore to include xcuserdata.
2219
2220         * DumpRenderTree/DumpRenderTree.xcodeproj: Modified property svn:ignore.
2221         * MiniBrowser/MiniBrowser.xcodeproj: Modified property svn:ignore.
2222         * TestWebKitAPI/TestWebKitAPI.xcodeproj: Modified property svn:ignore.
2223         * WebKitLauncher/WebKitLauncher.xcodeproj: Modified property svn:ignore.
2224         * WebKitTestRunner/WebKitTestRunner.xcodeproj: Modified property svn:ignore.
2225
2226 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
2227
2228         Unreviewed fix after r75908.
2229
2230         Move WebKit into Source
2231         https://bugs.webkit.org/show_bug.cgi?id=52530
2232
2233         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add Source to the path for Qt API tests.
2234
2235 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
2236
2237         Unreviewed.
2238
2239         Remove accidentally committed debug printing after r75908.
2240
2241         * Scripts/webkitdirs.pm:
2242
2243 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
2244
2245         Unreviewed.
2246
2247         Add myself to committers list
2248         https://bugs.webkit.org/show_bug.cgi?id=52566
2249
2250         * Scripts/webkitpy/common/config/committers.py:
2251
2252 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
2253
2254         Reviewed by Jeremy Orlow.
2255
2256         GeolocationController should call stopUpdating on destruction
2257         https://bugs.webkit.org/show_bug.cgi?id=52216
2258
2259         fast/dom/Geolocation/window-close-crash.html requires that a
2260         Geolocation watch be started in a secondary window. Consequently,
2261         we need to allow geolocation permission and provide a mock
2262         geolocation position for the secondary window's
2263         GeolocationClientMock.
2264
2265         * DumpRenderTree/chromium/LayoutTestController.cpp:
2266         (LayoutTestController::setGeolocationPermission):
2267         (LayoutTestController::setMockGeolocationPosition):
2268         (LayoutTestController::setMockGeolocationError):
2269         * DumpRenderTree/chromium/TestShell.h:
2270         (TestShell::windowList):
2271
2272 2011-01-16  Adam Barth  <abarth@webkit.org>
2273
2274         Update more include paths to reflect WebKit move.
2275
2276         * DumpRenderTree/chromium/EventSender.cpp:
2277         (EventSender::keyDown):
2278         (EventSender::needsShiftModifier):
2279         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
2280         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
2281
2282 2011-01-16  Kent Tamura  <tkent@chromium.org>
2283
2284         Unreviewed, Chromium build fix.
2285
2286         * Scripts/update-webkit-chromium: Webkit/chromium -> Source/WebKit/chromium
2287
2288 2011-01-16  Martin Robinson  <mrobinson@igalia.com>
2289
2290         Build fix for GTK+ after source directory movement.
2291
2292         * GNUmakefile.am: Correct include paths.
2293
2294 2011-01-16  Adam Barth  <abarth@webkit.org>
2295
2296         Teach svn-apply about WebKit move.
2297
2298         * Scripts/VCSUtils.pm:
2299
2300 2011-01-16  Adam Barth  <abarth@webkit.org>
2301
2302         Rubber-stamped by Eric Seidel.
2303
2304         Move WebKit into Source
2305         https://bugs.webkit.org/show_bug.cgi?id=52530
2306
2307         * DumpRenderTree/mac/InternalHeaders/WebKit/WebTypesInternal.h:
2308         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2309         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2310         * DumpRenderTree/qt/GCControllerQt.cpp:
2311         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2312         * DumpRenderTree/qt/PlainTextControllerQt.cpp:
2313         * DumpRenderTree/qt/TextInputControllerQt.cpp:
2314         * DumpRenderTree/wscript:
2315         * QtTestBrowser/launcherwindow.h:
2316         * Scripts/build-webkit:
2317         * Scripts/webkitdirs.pm:
2318
2319 2011-01-15  Adam Barth  <abarth@webkit.org>
2320
2321         Teach svn-apply about WebKit2 move.
2322
2323         * Scripts/VCSUtils.pm:
2324
2325 2011-01-15  Adam Barth  <abarth@webkit.org>
2326
2327         Rubber-stamped by Eric Seidel.
2328
2329         Move WebKit2 into Source
2330         https://bugs.webkit.org/show_bug.cgi?id=52438
2331
2332         * MiniBrowser/qt/MiniBrowser.pro:
2333         * Scripts/build-webkit:
2334         * Scripts/do-file-rename:
2335         * Scripts/do-webcore-rename:
2336         * Scripts/test-webkitpy:
2337         * Scripts/webkitdirs.pm:
2338         * Scripts/webkitpy/style/checker.py:
2339         * WebKitTestRunner/DerivedSources.pro:
2340         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2341         * WebKitTestRunner/qt/WebKitTestRunner.pro:
2342
2343 2011-01-15  Jochen Eisinger  <jochen@chromium.org>
2344
2345         Reviewed by David Levin.
2346
2347         [chromium] remove obsolete createView method
2348         https://bugs.webkit.org/show_bug.cgi?id=52437
2349
2350         * DumpRenderTree/chromium/WebViewHost.cpp:
2351         (WebViewHost::createView):
2352         * DumpRenderTree/chromium/WebViewHost.h:
2353
2354 2011-01-14  Brian Weinstein  <bweinstein@apple.com>
2355
2356         Reviewed by Geoff Garen.
2357
2358         ShouldLoadResourceForFrame should use strings, not URLs.
2359         https://bugs.webkit.org/show_bug.cgi?id=52476
2360
2361         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2362         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Update to use a WKStringRef.
2363         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2364
2365 2011-01-14  Tony Gentilcore  <tonyg@chromium.org>
2366
2367         Reviewed by David Levin.
2368
2369         Add Tony Gentilcore as a reviewer
2370         https://bugs.webkit.org/show_bug.cgi?id=52480
2371
2372         * Scripts/webkitpy/common/config/committers.py:
2373
2374 2011-01-14  David Levin  <levin@chromium.org>
2375
2376         Reviewed by Eric Seidel.
2377
2378         check-webkit-style: _FunctionState should keep track of where the function name starts.
2379         https://bugs.webkit.org/show_bug.cgi?id=52454
2380
2381         * Scripts/webkitpy/style/checkers/cpp.py: Added function_name_start_position to
2382         _FunctionState and logic for setting it correctly.
2383         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests.
2384
2385 2011-01-14  Vincent Scheib  <scheib@chromium.org>
2386
2387         Reviewed by David Levin.
2388
2389         Add support to DumpRenderTree to use the GPU rather than software renderer
2390         https://bugs.webkit.org/show_bug.cgi?id=52333
2391
2392         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2393         (main):
2394         * Scripts/webkitpy/layout_tests/port/chromium.py:
2395         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2396
2397 2011-01-14  Tony Chang  <tony@chromium.org>
2398
2399         Reviewed by Kent Tamura.
2400
2401         [chromium] update fonts.conf to fix 6 linux tests in drt
2402         https://bugs.webkit.org/show_bug.cgi?id=52411
2403
2404         * DumpRenderTree/chromium/fonts.conf: Update to match the copy in
2405             chromium's src/webkit/tools/test_shell/resources/fonts.conf
2406
2407 2011-01-14  Eric Seidel  <eric@webkit.org>
2408
2409         Original patch from Peter Gal  <galpater@inf.u-szeged.hu>
2410
2411         Reviewed by Adam Barth.
2412
2413         Fix when running Tools/Scripts/check-webkit-style without arguments.
2414         https://bugs.webkit.org/show_bug.cgi?id=52261#c16
2415
2416         * Scripts/webkitpy/common/checkout/scm.py: Handle None for changed_files argument better in Git.create_patch method.
2417         * Scripts/webkitpy/common/checkout/scm_unittest.py:
2418
2419 2011-01-04  Jochen Eisinger  <jochen@chromium.org>
2420
2421         Reviewed by David Levin.
2422
2423         Store the tempdir object in a variable so it doesn't get deleted too early.
2424         https://bugs.webkit.org/show_bug.cgi?id=51875
2425
2426         * Scripts/update-webkit-auxiliary-libs:
2427         * Scripts/update-webkit-support-libs:
2428
2429 2011-01-14  Eric Seidel  <eric@webkit.org>
2430
2431         Unreviewed.  Make it work in python 2.5.
2432
2433         webkit-patch suggest-reviewers dies when ChangeLogs are missing
2434         https://bugs.webkit.org/show_bug.cgi?id=49158
2435
2436         * Scripts/webkitpy/common/checkout/api_unittest.py:
2437
2438 2011-01-14  Sheriff Bot  <webkit.review.bot@gmail.com>
2439
2440         Unreviewed, rolling out r75774.
2441         http://trac.webkit.org/changeset/75774
2442         https://bugs.webkit.org/show_bug.cgi?id=52431
2443
2444         gtk builds were broken (Requested by loislo2 on #webkit).
2445
2446         * Scripts/webkitpy/common/checkout/scm.py:
2447
2448 2011-01-14  David Levin  <levin@chromium.org>
2449
2450         Reviewed by Shinichiro Hamaji.
2451
2452         check-webkit-style: _FunctionState should detect pure functions.
2453         https://bugs.webkit.org/show_bug.cgi?id=52428
2454
2455         * Scripts/webkitpy/style/checkers/cpp.py: Added detection for if a function declaration
2456         is a pure virtual function.
2457         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests for verifying that pure
2458         virtual functions are correctly detected.
2459
2460 2011-01-13  Ilya Tikhonovsky  <loislo@chromium.org>
2461
2462         Reviewed by Yury Semikhatsky.
2463
2464         Just small fix for problem with check-webkit-style.
2465         It just didn't work for this patch.
2466         Old code can't concatenate a list of strings with None.
2467
2468         * Scripts/webkitpy/common/checkout/scm.py:
2469
2470 2011-01-13  David Levin  <levin@chromium.org>
2471
2472         Reviewed by Shinichiro Hamaji.
2473
2474         check-webkit-style: _FunctionState should use Position to know where items are.
2475         https://bugs.webkit.org/show_bug.cgi?id=52424
2476
2477         * Scripts/webkitpy/style/checkers/cpp.py:
2478         (_FunctionState.*): Changed _FunctionState to use Position instead of line numbers.
2479         (detect_functions): Changed to pass Position's to _FunctionState.begin and
2480         did some minor clean-up.
2481         (*): Other changes are simply about converting to use the Position's in_FunctionState
2482         instead of line numbers.
2483         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Changed the test code
2484         to verify the positions stored in _FunctionState.
2485
2486 2011-01-13  Eric Seidel  <eric@webkit.org>
2487
2488         Reviewed by David Levin.
2489
2490         webkit-patch suggest-reviewers dies when ChangeLogs are missing
2491         https://bugs.webkit.org/show_bug.cgi?id=49158
2492
2493         This is not the most elegant, but it is a very safe fix to this bug.
2494         One advantage of catching ScriptError like this instead of adding a
2495         new added_or_modified_files or fixing all changed_files callers
2496         to use a more specific change_files variant, is that we catch
2497         all kinds of ScriptErrors which might cause our (non-essential)
2498         suggest-reviewers code to fail out.  This should make passing
2499         --suggest-reviewers to webkit-patch upload much more robust
2500         and may even make it possible for us to make it default.
2501
2502         The root of the problem here is that SCM.changed_files includes
2503         deleted ChangeLog paths (from moves, etc) which then when we ask
2504         SVN/Git for the contents of the file at that revision, the command
2505         errors out and Executive.run_command raises a ScriptError.
2506
2507         In the future we might fix this differently by making all current
2508         callers of chagned_files use a more specific method for requesting
2509         what types of changes they're interested in (adds, modifies, deletes, etc.)
2510
2511         * Scripts/webkitpy/common/checkout/api.py:
2512         * Scripts/webkitpy/common/checkout/api_unittest.py:
2513
2514 2011-01-13  Dan Bernstein  <mitz@apple.com>
2515
2516         Reviewed by Alexey Proskuryakov.
2517
2518         <rdar://problem/8827065> REGRESSION (r71884): Cross-origin XHR fails if willSendRequest changes the URL
2519         https://bugs.webkit.org/show_bug.cgi?id=52419
2520
2521         Allow to further control the behavior of the willSendRequest delegate callback by making it
2522         set a different URL in the new request.
2523
2524         * DumpRenderTree/LayoutTestController.cpp:
2525         (addURLToRedirectCallback): Added.
2526         (LayoutTestController::staticFunctions): Added addURLToRedirect.
2527         (LayoutTestController::addURLToRedirect): Added. Adds the redirection to the map.
2528         (LayoutTestController::redirectionDestinationForURL): Added this getter.
2529         * DumpRenderTree/LayoutTestController.h:
2530         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2531         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]): Check
2532         if there is a redirection for the request’s URL, established by addURLToRedirect(), and if so,
2533         change the URL in the new request to the redirect destination.
2534
2535 2011-01-13  Eric Seidel  <eric@webkit.org>
2536
2537         Reviewed by Mihai Parparita.
2538
2539         webkit-patch suggest-reviewers fails due to invalid utf8 in ChangeLog files
2540         https://bugs.webkit.org/show_bug.cgi?id=52416
2541
2542         Example: webkit-patch suggest-reviewers -g ca3890fe74d94d85d6bfa48f9ea497b094d8e717 
2543         UnicodeDecodeError: 'utf8' codec can't decode bytes in position 536-538: invalid data
2544
2545         I also added FIXMEs about the changed_files returning deleted files problem
2546         which is causing the other most common exception for suggest-reviewers
2547         (and is probably breaking sheriff-bots blame detection).
2548
2549         * Scripts/webkitpy/common/checkout/api.py:
2550         * Scripts/webkitpy/common/checkout/api_unittest.py:
2551         * Scripts/webkitpy/common/checkout/scm.py:
2552
2553 2011-01-13  Eric Seidel  <eric@webkit.org>
2554
2555         Reviewed by Adam Barth.
2556
2557         results archives from commit-queue are too large to upload
2558         https://bugs.webkit.org/show_bug.cgi?id=52405
2559
2560         * Scripts/webkitpy/common/system/filesystem.py:
2561         * Scripts/webkitpy/common/system/filesystem_mock.py:
2562         * Scripts/webkitpy/tool/commands/queues.py:
2563
2564 2011-01-13  Alejandro G. Castro  <alex@igalia.com>
2565
2566         Reviewed by Martin Robinson.
2567
2568         [gtk] Zero-sized font does not yet work
2569         https://bugs.webkit.org/show_bug.cgi?id=49793
2570
2571         Set minimum-font-size to 0 for the DRT.
2572
2573         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2574         (resetDefaultsToConsistentValues):
2575
2576 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
2577
2578         Reviewed by Darin Adler.
2579
2580         Make old-run-webkit-tests more robust on buildbots
2581         https://bugs.webkit.org/show_bug.cgi?id=52364
2582
2583         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Pass --exit-after-n-failures 500 to old-run-webkit-tests script.
2584
2585 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
2586
2587         Reviewed by Darin Adler.
2588
2589         Make old-run-webkit-tests more robust on buildbots
2590         https://bugs.webkit.org/show_bug.cgi?id=52364
2591
2592         * Scripts/old-run-webkit-tests: Ensure that testResultsDirectory is empty.
2593
2594 2011-01-13  Tony Chang  <tony@chromium.org>
2595
2596         Reviewed by Kent Tamura.
2597
2598         [chromium] fix plugins/plugin-javascript-access.html on Linux and Mac
2599         https://bugs.webkit.org/show_bug.cgi?id=52332
2600
2601         Forked Info.plist is not longer needed.
2602
2603         * DumpRenderTree/chromium/TestNetscapePlugIn/Info.plist: Removed.
2604
2605 2011-01-13  Mikhail Naganov  <mnaganov@chromium.org>
2606
2607         Reviewed by Timothy Hatcher.
2608
2609         Web Inspector: Cleanup after r75613 -- make all UI-facing strings
2610         to be passed directly to WebInspector.UIString
2611
2612         https://bugs.webkit.org/show_bug.cgi?id=52365
2613
2614         * Scripts/check-inspector-strings:
2615
2616 2011-01-13  Sheriff Bot  <webkit.review.bot@gmail.com>
2617
2618         Unreviewed, rolling out r74881.
2619         http://trac.webkit.org/changeset/74881
2620         https://bugs.webkit.org/show_bug.cgi?id=52357
2621
2622         The EFL builder has been red for days (Requested by abarth on
2623         #webkit).
2624
2625         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2626         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2627
2628 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
2629
2630         Reviewed by David Levin.
2631
2632         Add beforeunload support to WebKitTestRunner
2633         https://bugs.webkit.org/show_bug.cgi?id=52353
2634         
2635         This makes a number of currently failing tests pass.
2636
2637         * WebKitTestRunner/TestController.cpp:
2638         (WTR::runBeforeUnloadConfirmPanel):
2639         (WTR::createOtherPage):
2640         (WTR::TestController::initialize):
2641
2642 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
2643
2644         Reviewed by Sam Weinig.
2645
2646         Detect, identify and recover from WebProcess crashes in run-webkit-tests
2647         https://bugs.webkit.org/show_bug.cgi?id=52330
2648
2649         * Scripts/old-run-webkit-tests: Detect when the regression test tool reports
2650         a web process crash.
2651         * WebKitTestRunner/TestController.cpp:
2652         (WTR::TestController::initialize): Set up a processDidCrash
2653         callback.
2654         (WTR::TestController::processDidCrash): Report that the Web process
2655         crashed.
2656         * WebKitTestRunner/TestController.h:
2657
2658 2011-01-12  David Levin  <levin@chromium.org>
2659
2660         Reviewed by Shinichiro Hamaji.
2661
2662         check-webkit-style -- close_expression function doesn't work correctly.
2663         https://bugs.webkit.org/show_bug.cgi?id=52272
2664
2665         * Scripts/webkitpy/style/checkers/cpp.py:
2666         (Position.__str__): Added a way to convert it to a string which is useful in tests.
2667         (Position.__cmp__): Added a way to compare Position which is useful in tests and
2668         generally useful (for upcoming code changes).
2669         (close_expression): Changed to use Position for input and output.
2670         Also, fixed many bugs such as only working correctly for parenthesis,
2671         not working correctly if given an offset in a line and not finding
2672         the real closing element if there were multiple closing elements in
2673         the same line.
2674         (detect_functions): Adjusted due to the change in arguments for
2675         close_expression.
2676         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2677         (CppStyleTestBase.assert_positions_equal): Added a way to verify that
2678         two positions are the same.
2679         (CppStyleTest.test_position): Added tests for the __str_ and __cmp__ methods.
2680         (CppStyleTest.test_close_expression): Added tests to catch the issues
2681         that were fixed.
2682
2683 2011-01-12  Sheriff Bot  <webkit.review.bot@gmail.com>
2684
2685         Unreviewed, rolling out r75576.
2686         http://trac.webkit.org/changeset/75576
2687         https://bugs.webkit.org/show_bug.cgi?id=52304
2688
2689         broke rebaseline-chromium-webkit-test (Requested by thakis on
2690         #webkit).
2691
2692         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2693         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2694         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
2695         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2696         * Scripts/webkitpy/layout_tests/port/base.py:
2697         * Scripts/webkitpy/layout_tests/port/chromium.py:
2698         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2699         * Scripts/webkitpy/layout_tests/port/test.py:
2700         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2701         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2702         * Scripts/webkitpy/style/checkers/test_expectations.py:
2703         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
2704
2705 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
2706
2707         Reviewed by Darin Adler.
2708
2709         Add a no-build option to run-webkit-tests, to avoid building DRT/WKTR
2710         https://bugs.webkit.org/show_bug.cgi?id=52307
2711
2712         * Scripts/old-run-webkit-tests:
2713
2714 2011-01-12  Koan-Sin Tan  <koansin.tan@gmail.com>
2715
2716         Reviewed by Martin Robinson.
2717
2718         [Gtk] WebKitGtk+ doesn't build on Mac OS X 10.6
2719         https://bugs.webkit.org/show_bug.cgi?id=50867
2720
2721         Fixed library extention for Mac in webkitdirs.pm and type conflict in
2722         TestNetscapePlugin.cpp 
2723
2724         * GNUmakefile.am: Don't use AppKit when compiling TestNetscapePlugin for GTK+
2725         * Scripts/webkitdirs.pm:
2726
2727 2011-01-12  Mikhail Naganov  <mnaganov@chromium.org>
2728
2729         Reviewed by Pavel Feldman.
2730
2731         Add check-inspector-strings script.
2732
2733         https://bugs.webkit.org/show_bug.cgi?id=52295
2734
2735         * Scripts/check-inspector-strings: Added.
2736
2737 2011-01-12  Adam Roben  <aroben@apple.com>
2738
2739         Advertise the .testnetscape file extension on Windows
2740
2741         Fixes <http://webkit.org/b/52298>
2742         plugins/no-mime-with-valid-extension.html fails on Windows
2743
2744         Reviewed by Dan Bernstein.
2745
2746         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Added a
2747         FileExtents field to map the .testnetscape file extension to the
2748         application/x-webkit-test-netscape MIME type, just as we do on Mac.
2749
2750 2011-01-12  Adam Barth  <abarth@webkit.org>
2751
2752         Reviewed by Eric Seidel.
2753
2754         Make webkit-patch support subdirectories for SVN checkouts
2755         https://bugs.webkit.org/show_bug.cgi?id=52261
2756
2757         os.relpath does not exist on Python 2.5, so we need to call our version
2758         of the API.
2759
2760         * Scripts/webkitpy/common/checkout/scm.py:
2761
2762 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
2763
2764         Reviewed by Eric Seidel.
2765
2766         Close additional pages opened during a test once the test completes.
2767         https://bugs.webkit.org/show_bug.cgi?id=52276
2768
2769         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2770         (WTR::InjectedBundle::done):
2771
2772 2011-01-11  David Levin  <levin@chromium.org>
2773
2774         Reviewed by Eric Seidel.
2775
2776         Errors should be separated from the command line in bot messages.
2777         https://bugs.webkit.org/show_bug.cgi?id=52275
2778
2779         * Scripts/webkitpy/common/system/executive.py:
2780         (ScriptError.message_with_output): Added a newline to separate the command
2781         line from the errors.
2782         * Scripts/webkitpy/common/system/executive_unittest.py:
2783         (ScriptErrorTest.test_message_with_output): Added tests for the various code
2784         paths in message_with_output.
2785
2786 2011-01-11  Eric Seidel  <eric@webkit.org>
2787
2788         Unreviewed.
2789
2790         commit-queue should know how to upload archived results (for test flakes or general failures)
2791         https://bugs.webkit.org/show_bug.cgi?id=52048
2792
2793         The zips are mostly empty due to forgetting -r.
2794         Expected diffs were not being pulled from the archive due
2795         to the archive having longer paths than I realized.
2796
2797         * Scripts/webkitpy/common/system/workspace.py:
2798         * Scripts/webkitpy/common/system/workspace_unittest.py:
2799         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2800         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2801
2802 2011-01-11  Dirk Pranke  <dpranke@chromium.org>
2803
2804         Reviewed by Ojan Vafai.
2805
2806         The current modifier parsing code in test_expectations is
2807         fragile and hard-coded, so it's not easy to understand the logic
2808         or easily add new types of modifiers (like GPU vs. CPU testing
2809         for graphics tests, or 32-bit vs. 64-bit differences).
2810
2811         This is the first of two patches that will add in more generic
2812         support and then eliminate the GPU-specific test expectations
2813         files for Chromium.
2814
2815         This patch adds two standalone objects for handling modifiers. The
2816         rules for interpreting modifiers, precedence, and conflicts are
2817         given in the docstring to the ModifierMatcher class, which
2818         returns ModifierMatchResult objects.
2819         
2820         This patch also adds routines to the Port interface and a
2821         default set of values in the base object, in order to obtain the
2822         values needed on a given test run. These values are then passed
2823         to the expectation parser. This also allows us to clean up the
2824         logic used to lint all of the different configurations in a
2825         single test_expectations.txt file.
2826
2827         The next patch will merge in the separate GPU expectations file.
2828
2829         https://bugs.webkit.org/show_bug.cgi?id=51222
2830
2831         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2832         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2833         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
2834         * Scripts/webkitpy/layout_tests/port/base.py:
2835         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2836         * Scripts/webkitpy/layout_tests/port/chromium.py:
2837         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2838         * Scripts/webkitpy/layout_tests/port/test.py:
2839         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2840         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2841
2842 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
2843
2844         Reviewed by Adam Barth.
2845
2846         Make webkit-patch support subdirectories for SVN checkouts
2847         https://bugs.webkit.org/show_bug.cgi?id=52261
2848
2849         * Scripts/webkitpy/common/checkout/scm.py:
2850         * Scripts/webkitpy/style_references.py:
2851         * Scripts/webkitpy/tool/main.py:
2852         * Scripts/webkitpy/tool/steps/preparechangelog.py:
2853
2854 2011-01-11  Eric Seidel  <eric@webkit.org>
2855
2856         Unreviewed.
2857
2858         commit-queue should know how to upload archived results (for test flakes or general failures)
2859         https://bugs.webkit.org/show_bug.cgi?id=52048
2860
2861         I changed the API for archive_last_layout_test_results w/o updating the implementation.  Oops.
2862         This fixes an exception seen on the commit-queue when attempting to report flaky tests.
2863
2864         * Scripts/webkitpy/common/system/workspace.py:
2865         * Scripts/webkitpy/common/system/workspace_unittest.py:
2866         * Scripts/webkitpy/tool/commands/queues.py:
2867
2868 2011-01-11  Sam Weinig  <sam@webkit.org>
2869
2870         Roll r75474 back in.
2871
2872 2011-01-11  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
2873
2874         Reviewed by Kenneth Rohde Christiansen.
2875
2876         [Qt] Remove uses of QFuture since it isn't supported on all platforms.
2877         https://bugs.webkit.org/show_bug.cgi?id=51204
2878
2879         * QtTestBrowser/webpage.h:
2880         (QtNAMThread::QtNAMThread):
2881         (QtNAMThread::networkAccessManager):
2882         (QtNAMThread::run):
2883
2884 2011-01-11  Peter Varga  <pvarga@webkit.org>
2885
2886         Unreviewed.
2887
2888         Add myself to committers' list.
2889
2890         * Scripts/webkitpy/common/config/committers.py:
2891
2892 2011-01-11  Eric Seidel  <eric@webkit.org>
2893
2894         Reviewed by Adam Barth.
2895
2896         commit-queue should know how to upload archived results (for test flakes or general failures)
2897         https://bugs.webkit.org/show_bug.cgi?id=52048
2898
2899         Now the queue will always upload results.  Either the entire zip, or just
2900         the diffs.txt in the case of text failures.
2901
2902         This should make understanding flakes much easier, and paves the way
2903         for having the EWS run layout tests (and upload failures).
2904
2905         In order to upload .zip files I had to teach bugzilla.py to autodetect
2906         mime types from the filename.  Since mimetypes.py doesn't include a mapping
2907         for .patch files, I have it add one before calling guess_type.
2908
2909         We may find that always uploading the whole zip instead of just the -diffs.txt
2910         file is preferable, but for now I'm keeping the old behavior because it makes
2911         quickly understanding text failures easy.
2912
2913         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2914         * Scripts/webkitpy/common/system/workspace.py: Added.
2915         * Scripts/webkitpy/common/system/workspace_unittest.py: Added.
2916         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2917         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2918         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2919         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2920         * Scripts/webkitpy/tool/commands/queues.py:
2921         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2922
2923 2011-01-10  Sheriff Bot  <webkit.review.bot@gmail.com>
2924
2925         Unreviewed, rolling out r75464.
2926         http://trac.webkit.org/changeset/75464
2927         https://bugs.webkit.org/show_bug.cgi?id=52193
2928
2929         Followup rollout for 75474 (Requested by Ossy on #webkit).
2930
2931         * MiniBrowser/mac/BrowserWindowController.m:
2932         (-[BrowserWindowController awakeFromNib]):
2933         * MiniBrowser/win/BrowserView.cpp:
2934         (BrowserView::create):
2935         * WebKitTestRunner/TestController.cpp:
2936         (WTR::createOtherPage):
2937         (WTR::TestController::initialize):
2938
2939 2011-01-10  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2940
2941         Reviewed by Csaba Osztrogonác.
2942
2943         [Qt] Baseline qt_minimal configuration
2944         https://bugs.webkit.org/show_bug.cgi?id=51313
2945
2946         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2947         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): Add
2948         QT_NO_UNDOSTACK guard.
2949
2950         * QtTestBrowser/launcherwindow.cpp:
2951         (LauncherWindow::createChrome): Add QT_NO_SHORTCUT and QT_NO_PRINTER
2952         guards.
2953         (LauncherWindow::applyZoom): Add QT_NO_ANIMATION guard.
2954         (LauncherWindow::screenshot): Add QT_NO_FILEDIALOG guard.
2955         (LauncherWindow::selectElements): Add QT_NO_INPUTDIALOG guard.
2956         (LauncherWindow::showUserAgentDialog): Add QT_NO_COMBOBOX guard.
2957
2958         * QtTestBrowser/launcherwindow.h:
2959         * QtTestBrowser/locationedit.cpp: Add QT_NO_INPUTDIALOG guard.
2960         * QtTestBrowser/locationedit.h: Ditto.
2961
2962         * QtTestBrowser/mainwindow.cpp:
2963         (MainWindow::buildUI): Add QT_NO_INPUTDIALOG, QT_NO_SHORTCUT and
2964         QT_NO_UNDOSTACK guards.
2965         (MainWindow::setAddressUrl): Add QT_NO_INPUTDIALOG guard.
2966         (MainWindow::changeLocation): Ditto.
2967         (MainWindow::openFile): Add QT_NO_FILEDIALOG guard.
2968         (MainWindow::openLocation): Add QT_NO_INPUTDIALOG guard.
2969
2970         * QtTestBrowser/webpage.cpp:
2971         (WebPage::openUrlInDefaultBrowser): Add QT_NO_DESKTOPSERVICES guard.
2972         (WebPage::authenticationRequired): Add QT_NO_LINEEDIT guard.
2973
2974         * QtTestBrowser/webview.cpp:
2975         (WebViewGraphicsBased::animatedFlip): Add QT_NO_ANIMATION guard.
2976         (WebViewGraphicsBased::animatedYFlip): Ditto.
2977
2978 2011-01-10  Sam Weinig  <sam@webkit.org>
2979
2980         Fix build.
2981
2982         * MiniBrowser/mac/BrowserWindowController.m:
2983         (-[BrowserWindowController awakeFromNib]):
2984         * MiniBrowser/win/BrowserView.cpp:
2985         (BrowserView::create):
2986         * WebKitTestRunner/TestController.cpp:
2987         (WTR::createOtherPage):
2988         (WTR::TestController::initialize):
2989
2990 2011-01-10  Eric Seidel  <eric@webkit.org>
2991
2992         Reviewed by Ojan Vafai.
2993
2994         style-queue messages are way too long for big patches
2995         https://bugs.webkit.org/show_bug.cgi?id=52161
2996
2997         We definitely could build much fancier list-to-string-with-limit functions
2998         but this should be sufficient for our needs at the moment.
2999
3000         * Scripts/webkitpy/common/system/executive.py:
3001         * Scripts/webkitpy/common/system/executive_unittest.py:
3002
3003 2011-01-10  Tony Chang  <tony@chromium.org>
3004
3005         Unreviewed, rolling out r75398.
3006         http://trac.webkit.org/changeset/75398
3007         https://bugs.webkit.org/show_bug.cgi?id=52008
3008
3009         Some layout tests are crashing on Chromium Win.
3010
3011         * DumpRenderTree/chromium/WebViewHost.cpp:
3012         (WebViewHost::updatePaintRect):
3013         * DumpRenderTree/chromium/WebViewHost.h:
3014
3015 2011-01-10  Adam Roben  <aroben@apple.com>
3016
3017         Roll out r75392
3018
3019         It isn't needed now that r75289 has been rolled out.
3020
3021         * Scripts/run-javascriptcore-tests:
3022
3023 2011-01-10  Maciej Stachowiak  <mjs@apple.com>
3024
3025         Reviewed by Anders Carlsson.
3026
3027         WebKitTestRunner uses crazy amounts of CPU, making layout tests slow and flaky
3028         https://bugs.webkit.org/show_bug.cgi?id=52160
3029
3030         * WebKitTestRunner/mac/TestControllerMac.mm:
3031         (WTR::TestController::platformRunUntil): Instead of busy-looping, wait for the timeout.
3032         Anything that can make runUntil() conditions turn true will happen on a run loop cycle
3033         anyway.
3034
3035 2011-01-10  Tony Chang  <tony@chromium.org>
3036
3037         Reviewed by Mihai Parparita.
3038
3039         [chromium] fix for animated gif layout tests
3040         https://bugs.webkit.org/show_bug.cgi?id=52008
3041
3042         * DumpRenderTree/chromium/WebViewHost.cpp: Schedule a paint when we update the paint rect
3043             to trigger gif animations.
3044         (WebViewHostPaintTask::WebViewHostPaintTask):
3045         (WebViewHostPaintTask::runIfValid):
3046         (WebViewHost::updatePaintRect):
3047         * DumpRenderTree/chromium/WebViewHost.h:
3048         (WebViewHost::taskList):
3049
3050 2011-01-10  Alejandro G. Castro  <alex@igalia.com>
3051
3052         Reviewed by Xan Lopez.
3053
3054         [GTK] Fix gtk2 compilation for master
3055         https://bugs.webkit.org/show_bug.cgi?id=51885
3056
3057         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
3058         (createBitmapContextFromWebView): Replaced the old
3059         gdk_drawable_get_size with gdk_pixmap_get_size.
3060
3061 2011-01-10  Patrick Gansterer  <paroga@webkit.org>
3062
3063         Reviewed by Laszlo Gombos.
3064
3065         [WINCE] Reenable NPAPI after r75203
3066         https://bugs.webkit.org/show_bug.cgi?id=52109
3067
3068         Remove the !isWinCE() check for ENABLE_NETSCAPE_PLUGIN_API and replace
3069         it with !isEfl(), because EFL port does not support NPAPI (yet).
3070
3071         * Scripts/build-webkit:
3072
3073 2011-01-10  Adam Roben  <aroben@apple.com>
3074
3075         Skip some asserting JS tests
3076
3077         See <http://webkit.org/b/52156>.
3078
3079         * Scripts/run-javascriptcore-tests:
3080
3081 2011-01-10  Martin Robinson  <mrobinson@igalia.com>
3082
3083         Reviewed by Xan Lopez.
3084
3085         [GTK] build-webkit disable Blob support via arguments passed to automake
3086         https://bugs.webkit.org/show_bug.cgi?id=52097
3087
3088         * Scripts/build-webkit: Enable Blob support when building WebKitGTK+ via
3089         build-webkit.
3090
3091 2011-01-10  Adam Roben  <aroben@apple.com>
3092
3093         Use the same name and description for TestNetscapePlugin on Windows and
3094         Mac
3095
3096         Fixes <http://webkit.org/b/52151>
3097         fast/frames/iframe-reparenting-plugins.html fails on Windows
3098
3099         Reviewed by Steve Falkenburg.
3100
3101         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Copied
3102         the name and description from Mac's Info.plist.
3103
3104 2011-01-10  Siddharth Mathur <siddharth.mathur@nokia.com>
3105
3106         Reviewed by Laszlo Gombos.
3107
3108         [Qt][WK2] Guard gcc-specific syntax
3109
3110         Non-gcc based compliers choke on the "-include"
3111         syntax for preinclude, place guard around it.
3112
3113         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3114         * WebKitTestRunner/qt/WebKitTestRunner.pro:
3115
3116 2011-01-10  Andreas Kling  <kling@webkit.org>
3117
3118         Reviewed by Simon Hausmann.
3119
3120         [Qt] [WK2] MiniBrowser does not load pages opened in new windows
3121         https://bugs.webkit.org/show_bug.cgi?id=52111
3122
3123         When getting a createNewPage() callback from QWKPage, create the
3124         new page with the same QWKContext as the page that is passed to
3125         the callback.
3126
3127         * MiniBrowser/qt/BrowserView.h:
3128         * MiniBrowser/qt/BrowserWindow.cpp:
3129         (newPageFunction):
3130         (BrowserWindow::BrowserWindow):
3131         * MiniBrowser/qt/BrowserWindow.h:
3132
3133 2011-01-10  Andreas Kling  <kling@webkit.org>
3134
3135         Reviewed by Kenneth Rohde Christiansen.
3136
3137         [Qt] MiniBrowser: Remove superfluous createNewPage() callback
3138
3139         BrowserView set its own useless createNewPage() callback on QWKPage.
3140         This was immediately overridden by BrowserWindow anyway, so remove
3141         the BrowserView one.
3142
3143         * MiniBrowser/qt/BrowserView.cpp:
3144         (BrowserView::BrowserView):
3145
3146 2011-01-10  John Knottenbelt  <jknotten@chromium.org>
3147
3148         Reviewed by Jeremy Orlow.
3149
3150         [Chromium] Remove non-client-based Geolocation code
3151         https://bugs.webkit.org/show_bug.cgi?id=50921
3152
3153         * DumpRenderTree/chromium/LayoutTestController.cpp:
3154         (LayoutTestController::setGeolocationPermission):
3155         (LayoutTestController::setMockGeolocationPosition):
3156         (LayoutTestController::setMockGeolocationError):
3157         * DumpRenderTree/chromium/WebViewHost.cpp:
3158         (WebViewHost::geolocationClientMock):
3159         (WebViewHost::reset):
3160         * DumpRenderTree/chromium/WebViewHost.h:
3161
3162 2011-01-10  Eric Seidel  <eric@webkit.org>
3163
3164         Reviewed by Adam Barth.
3165
3166         Commit bot tried to land r? cq+ patch
3167         https://bugs.webkit.org/show_bug.cgi?id=36638
3168
3169         It should now be possible to post a patch with r? and cq+ and the
3170         commit-queue will correctly wait for the r+ before attempting to land the patch.
3171         (This was a feature requested by several users.)
3172
3173         One caveat: We don't actually reject r-, cq+ patches from the queue
3174         (we just ignore them), but I think that's OK for now.
3175
3176         I also noticed that setting r- once a commit-queue node had grabbed
3177         a patch would not properly cancel the landing.  That's fixed and
3178         tested in this patch.
3179
3180         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3181         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3182         * Scripts/webkitpy/tool/bot/feeders.py:
3183         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
3184
3185 2011-01-08  Benjamin Poulain  <benjamin.poulain@nokia.com>
3186
3187         Reviewed by Kenneth Rohde Christiansen.
3188
3189         [Qt] QtWebKit crashes when using XMLHttpRequest from the unload event
3190         https://bugs.webkit.org/show_bug.cgi?id=51934
3191
3192         When accessing the network from the destructor of QWebPage, the network access manager
3193         was already deleted because the object WebPage was already destructed.
3194
3195         This solve the problem by linking the lifetime of the network access manager to WebPage's QObject.
3196         The object is now destructed in the destructor of QObject.
3197
3198         * QtTestBrowser/webpage.cpp:
3199         (WebPage::WebPage):
3200         (WebPage::setQnamThreaded):
3201         * QtTestBrowser/webpage.h:
3202         (QtNAMThread::QtNAMThread):
3203
3204 2011-01-08  Eric Seidel  <eric@webkit.org>
3205
3206         Reviewed by Ojan Vafai.
3207
3208         test_failures.py should not mention TestShell (long live DumpRenderTree!)
3209         https://bugs.webkit.org/show_bug.cgi?id=52067
3210
3211         I ran test-webkitpy, but didn't bother adding a unit test for this string change.
3212         https://bugs.webkit.org/show_bug.cgi?id=51138#c3 is an example of why this is needed.
3213
3214         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
3215
3216 2011-01-08  Eric Seidel  <eric@webkit.org>
3217
3218         Reviewed by Mihai Parparita.
3219
3220         commit-queue hangs when the ChangeLog diff is bad
3221         https://bugs.webkit.org/show_bug.cgi?id=52072
3222
3223         * Scripts/webkitpy/tool/steps/validatechangelogs.py:
3224         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
3225
3226 2011-01-08  Adam Barth  <abarth@webkit.org>
3227
3228         Teach svn-apply how to re-write WebCore to Source/WebCore.
3229
3230         * Scripts/VCSUtils.pm:
3231
3232 2011-01-07  Adam Barth  <abarth@webkit.org>
3233
3234         Rubber-stamped by Eric Seidel.
3235
3236         Move WebCore to Source
3237         https://bugs.webkit.org/show_bug.cgi?id=52050
3238
3239         Update the tools to understand WebCore's new location.
3240
3241         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3242         * DumpRenderTree/wscript:
3243         * GNUmakefile.am:
3244         * Scripts/build-webkit:
3245         * Scripts/do-file-rename:
3246         * Scripts/do-webcore-rename:
3247         * Scripts/generate-qt-inspector-resource:
3248         * Scripts/prepare-ChangeLog:
3249         * Scripts/run-bindings-tests:
3250         * Scripts/update-iexploder-cssproperties:
3251         * Scripts/update-sources-list.py:
3252         * Scripts/update-webkit-localizable-strings:
3253         * Scripts/webkitdirs.pm:
3254         * Scripts/webkitpy/common/config/build.py:
3255         * Scripts/webkitpy/common/config/build_unittest.py:
3256         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
3257         * Scripts/webkitpy/style/checker.py:
3258         * Scripts/webkitpy/style/checker_unittest.py:
3259         * WebKitTestRunner/DerivedSources.pro:
3260         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3261         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh:
3262         * wx/browser/wscript:
3263         * wx/build/settings.py:
3264
3265 2011-01-07  Maciej Stachowiak  <mjs@apple.com>
3266
3267         Reviewed by Sam Weinig.
3268
3269         Make WebKitTestRunner rest between loads more robust to avoid test crashes
3270         https://bugs.webkit.org/show_bug.cgi?id=52086
3271
3272         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3273         (WTR::InjectedBundle::didReceiveMessage):
3274         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3275         (WTR::LayoutTestController::notifyDone):
3276         * WebKitTestRunner/TestController.cpp:
3277         (WTR::TestController::resetStateToConsistentValues):
3278         (WTR::TestController::run):
3279
3280 2011-01-07  James Robinson  <jamesr@chromium.org>
3281
3282         Revert "Implement mozilla's animationTime property"
3283         https://bugs.webkit.org/show_bug.cgi?id=51952
3284
3285         This approach isn't quite right.
3286
3287         * DumpRenderTree/chromium/WebViewHost.cpp:
3288         (WebViewHost::paintInvalidatedRegion):
3289
3290 2011-01-07  Adam Roben  <aroben@apple.com>
3291
3292         Build master fix
3293
3294         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3295         (RunWebKitTests.start): Don't try to concatenate a list and a string.
3296
3297 2011-01-07  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>
3298
3299         Reviewed by Csaba Osztrogonác.
3300
3301         run-qtwebkit-tests should be able to kill a testsuite.
3302
3303         Add new option in the script that can setup a timeout for a test.
3304         If the test execution takes more then specified time then the test
3305         would be terminated.
3306
3307         [Qt] run-qtwebkit-tests needs timeout
3308         https://bugs.webkit.org/show_bug.cgi?id=51894
3309
3310         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3311         * Scripts/run-qtwebkit-tests:
3312
3313 2011-01-07  Csaba Osztrogonác  <ossy@webkit.org>
3314
3315         Unreviewed fix after r75233.
3316
3317         Based on idea from Eric Seidel.
3318
3319         Add remote zip file handling to webkitpy.
3320         https://bugs.webkit.org/show_bug.cgi?id=50901
3321
3322         * Scripts/webkitpy/common/system/fileset.py: Make python 2.5 happy.
3323
3324 2011-01-07  Shane Stephens  <shanestephens@google.com>
3325
3326         Reviewed by Eric Seidel.
3327
3328         svn-apply: should support git binary delta diffs
3329         https://bugs.webkit.org/show_bug.cgi?id=38864
3330
3331         * Scripts/VCSUtils.pm:
3332         * Scripts/svn-apply:
3333
3334 2011-01-06  Julie Parent  <jparent@chromium.org>
3335
3336         Reviewed by Eric Seidel.
3337
3338         Test Result Server not removing old results.
3339         https://bugs.webkit.org/show_bug.cgi?id=52012
3340
3341         * TestResultServer/model/jsonresults.py:
3342         Fix off-by-one: Truncate if >= num_runs, not just >.
3343         * TestResultServer/model/jsonresults_unittest.py:
3344         Add unit test to test that merging in a new result with the same value
3345         as the last result causes previous result to fall off.
3346
3347 2011-01-06  James Kozianski  <koz@chromium.org>
3348
3349         Reviewed by Mihai Parparita.
3350
3351         Add classes to provide a consistent interface to a set of files.
3352         https://bugs.webkit.org/show_bug.cgi?id=50901
3353
3354         These classes allow us to write code that is agnostic to whether a
3355         particular set of files resides in a local directory or in a zip file
3356         on a remote machine.
3357
3358         * Scripts/webkitpy/common/system/directoryfileset.py: Added.
3359         * Scripts/webkitpy/common/system/directoryfileset_unittest.py: Added.
3360         * Scripts/webkitpy/common/system/fileset.py: Added.
3361         * Scripts/webkitpy/common/system/filesystem.py:
3362         * Scripts/webkitpy/common/system/filesystem_mock.py:
3363         * Scripts/webkitpy/common/system/zipfileset.py: Added.
3364         * Scripts/webkitpy/common/system/zipfileset_unittest.py: Added.
3365
3366 2011-01-06  Eric Seidel  <eric@webkit.org>
3367
3368         Reviewed by Adam Barth.
3369
3370         NetworkTransaction should log the url it is retrying
3371         https://bugs.webkit.org/show_bug.cgi?id=52043
3372
3373         * Scripts/webkitpy/common/net/networktransaction.py:
3374         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
3375
3376 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
3377
3378         Windows build fix.
3379         Import os before using it.
3380
3381         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3382
3383 2011-01-06  Eric Seidel  <eric@webkit.org>
3384
3385         Reviewed by Adam Barth.
3386
3387         StyleQueue fails to report errors when patches have many files
3388         https://bugs.webkit.org/show_bug.cgi?id=52042
3389
3390         This is one of at least two errors preventing style error reporting at the moment.
3391         When we moved to passing the list of files to check explicitly,
3392         we started to exceed the 500 character TEXT field limit for our AppEngine model object.
3393         We could change the type of the QueueStatus.message type, or we could
3394         just teach statusserver.py how to clamp values (and warn when it does).
3395         I chose the latter path.
3396
3397         * Scripts/webkitpy/common/net/statusserver.py:
3398
3399 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
3400
3401         Reviewed by Stephanie Lewis.
3402         
3403         Fix syntax error in script.
3404
3405         Windows bots need to archive/unarchive builds to/from configuration-specific directories
3406         https://bugs.webkit.org/show_bug.cgi?id=51996
3407
3408         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3409
3410 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3411
3412         Unreviewed, fixing WinCE build after r75196.
3413
3414         WinCE port does not (yet) support NPAPI.
3415
3416         * Scripts/build-webkit:
3417
3418 2011-01-06  Xan Lopez  <xlopez@igalia.com>
3419
3420         Reviewed by Darin Adler.
3421
3422         File::Spec->rel2abs in sunspider-compare-results mangles parameters
3423         https://bugs.webkit.org/show_bug.cgi?id=52015
3424
3425         * Scripts/sunspider-compare-results: call rel2abs on our arguments
3426         after the platform has been detected, otherwise the script will
3427         mangle things like '--gtk' into '/a/path/--gtk', breaking the
3428         detection.
3429
3430 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3431
3432         Reviewed by Eric Seidel.
3433
3434         Add ENABLE_NETSCAPE_PLUGIN_API, ENABLE_ORIENTATION_EVENTS and ENABLE_TOUCH_EVENTS flags to build-webkit
3435         https://bugs.webkit.org/show_bug.cgi?id=51346
3436
3437         * Scripts/build-webkit:
3438
3439 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
3440
3441         Reviewed by Adam Roben.
3442
3443         Windows bots need to archive/unarchive builds to/from configuration-specific directories
3444         https://bugs.webkit.org/show_bug.cgi?id=51996
3445         
3446         After the configuration directory change, we were archiving the incorrect directory for
3447         build product, so we were running tests on the wrong binaries.
3448         
3449         This change archives the correct directory, and also unarchives it into a configuration-
3450         specific directory.
3451
3452         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Use a configuration-specific directory on Windows.
3453         * BuildSlaveSupport/built-product-archive: Unarchive/archive to/from proper directory.
3454
3455 2011-01-06  Eric Seidel  <eric@webkit.org>
3456
3457         Reviewed by Mihai Parparita.
3458
3459         commit-queue mentions "Text diff mismatch" 4 times instead of once per failure
3460         https://bugs.webkit.org/show_bug.cgi?id=52002
3461
3462         See an example of this here:
3463         https://bugs.webkit.org/show_bug.cgi?id=51314#c2
3464
3465         It's due to the fact that we pass around TestFailure() instance
3466         objects and yet expect them to all compare to be the same.
3467
3468         This is bad.  We should either have shared instances of these values
3469         or we should just pass around the class names.  There are already hacks
3470         in place to make TestFailure objects pass equality tests, I just added
3471         a __hash__ implementation so they can be used in sets as expected.
3472
3473         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3474         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
3475
3476 2011-01-06  Evan Martin  <evan@chromium.org>
3477
3478         Reviewed by Tony Chang.
3479
3480         [gdb] handle inaccessible memory and UChar*
3481         https://bugs.webkit.org/show_bug.cgi?id=52003
3482
3483         To pretty-print a UChar*, we just grope around in the memory
3484         looking for a terminating NUL.  We need to handle the exception
3485         that can occur when we poke into an invalid location.
3486
3487         Additionally, the logic for choosing which pretty-printer would
3488         early return before hitting the point where we'd use the UChar*
3489         printer.  (Did this ever work?  How did it regress?)
3490
3491         * gdb/webkit.py:
3492
3493 2011-01-05  Brian Weinstein  <bweinstein@apple.com>
3494
3495         Reviewed by Ada Chan.
3496
3497         WebKit2: Should be able to call into injected bundle to ask if we should allow resource loads
3498         https://bugs.webkit.org/show_bug.cgi?id=51969
3499         
3500         Add shouldLoadResourceForFrame to WTR::InjectedBundlePage.
3501
3502         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3503         (WTR::InjectedBundlePage::InjectedBundlePage):
3504         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Stub implementation.
3505         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3506
3507 2011-01-06  James Robinson  <jamesr@chromium.org>
3508
3509         Reviewed by Simon Fraser.
3510
3511         Implement mozilla's animationTime property
3512         https://bugs.webkit.org/show_bug.cgi?id=51952
3513
3514         Chromium DRT support for webkitAnimationTime.
3515
3516         * DumpRenderTree/chromium/WebViewHost.cpp:
3517         (WebViewHost::paintInvalidatedRegion):
3518
3519 2011-01-06  Julie Parent  <jparent@chromium.org>
3520
3521         Reviewed by Tony Chang.
3522
3523         Test Result Server always truncates number of results to JSON_RESULTS_MAX_BUILDS
3524         https://bugs.webkit.org/show_bug.cgi?id=51217
3525
3526         * TestResultServer/model/jsonresults.py:
3527         Pass num_runs through to _remove_items_over_max_number_of_builds, and use the value.
3528         Adds missing documentation.
3529         * TestResultServer/model/jsonresults_unittest.py:
3530         Add unit test to test that truncation happens at smaller value than JSON_RESULTS_MAX_BUILDS.
3531         Update test_merge to take a number of builds to truncate at.
3532
3533 2011-01-06  Adam Barth  <abarth@webkit.org>
3534
3535         Reviewed by Eric Seidel.
3536
3537         The EWS should log outside of the working directory
3538         https://bugs.webkit.org/show_bug.cgi?id=51986
3539
3540         This patch prepare us for using git clean -x -d -f in the EWS wrapper
3541         script, which will actually clean the working copy back to a pristine
3542         state instead of leaving untracked directories and ignored files.
3543
3544         * Scripts/webkitpy/tool/commands/queues.py:
3545         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3546
3547 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
3548
3549         Windows build fix.
3550         Back out attempted change to built-product-archive.
3551
3552         * BuildSlaveSupport/built-product-archive:
3553
3554 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
3555
3556         Windows build fix.
3557         Include configuration name when unpacking a build archive.
3558
3559         Needed, since we split Windows build results into configuration-specific directories
3560         under WebKitOutputDir.
3561
3562         * BuildSlaveSupport/built-product-archive:
3563
3564 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
3565
3566         Reviewed by Darin Adler.
3567
3568         Debug and Release builds on Windows clobber each other
3569         https://bugs.webkit.org/show_bug.cgi?id=49185
3570
3571         Changes the structure of WebKitBuild build products directory so we
3572         completely separate each build configuration into independent directories.
3573         
3574         Although we previously had per-configuration directories for obj, this change adds
3575         per-configuration directories for bin, lib, obj, and include. Each configuration's
3576         build products are stored within a directory inside of WebKitBuild.
3577         
3578         Most use of $(WebKitOutputDir) in the build files has been replaced by $(ConfigurationBuildDir),
3579         defined in common.vsprops to be $(WebKitOutputDir)\$(ConfigurationName).
3580
3581         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops:
3582         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd:
3583         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd:
3584         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
3585         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd:
3586         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd:
3587         * DumpRenderTree/win/ImageDiffCommon.vsprops:
3588         * DumpRenderTree/win/ImageDiffPostBuild.cmd:
3589         * DumpRenderTree/win/ImageDiffPreBuild.cmd:
3590         * FindSafari/FindSafari.vcproj:
3591         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
3592         * MiniBrowser/MiniBrowserPostBuild.cmd:
3593         * MiniBrowser/MiniBrowserPreBuild.cmd:
3594         * Scripts/webkitdirs.pm:
3595         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
3596         * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops:
3597         * TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd:
3598         * TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd:
3599         * TestWebKitAPI/win/copy-resources.cmd:
3600         * WebKitAPITest/WebKitAPITestCommon.vsprops:
3601         * WebKitAPITest/WebKitAPITestPostBuild.cmd:
3602         * WebKitAPITest/WebKitAPITestPreBuild.cmd:
3603         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
3604         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
3605         * WebKitTestRunner/win/InjectedBundle.vcproj:
3606         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops:
3607         * WebKitTestRunner/win/InjectedBundlePostBuild.cmd:
3608         * WebKitTestRunner/win/InjectedBundlePreBuild.cmd:
3609         * WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd:
3610         * WebKitTestRunner/win/WebKitTestRunnerPreBuild.cmd:
3611         * WinLauncher/WinLauncherCommon.vsprops:
3612         * WinLauncher/WinLauncherPostBuild.cmd:
3613         * WinLauncher/WinLauncherPreBuild.cmd:
3614
3615 2011-01-05  Jan Erik Hanssen  <jhanssen@sencha.com>
3616
3617         Reviewed by Ariya Hidayat.
3618
3619         [Qt] TestNetscapePlugin doesn't link on OS X
3620         https://bugs.webkit.org/show_bug.cgi?id=51948
3621
3622         Only add a dependency on libX11 on X11 systems
3623
3624         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3625
3626 2011-01-05  Jeff Miller  <jeffm@apple.com>
3627
3628         Reviewed by Adam Roben.
3629
3630         check-webkit-style should allow unnecessary parameter names in WebKit2 APIs because we're matching CF's header style
3631         https://bugs.webkit.org/show_bug.cgi?id=51970
3632
3633         * Scripts/webkitpy/style/checker.py:
3634         Add -readability/naming for WebKit2 C API directories.
3635
3636 2011-01-05  Eric Seidel  <eric@webkit.org>
3637
3638         Unreviewed, just fixing one more log error from my previous python patch.
3639
3640         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
3641         https://bugs.webkit.org/show_bug.cgi?id=51802
3642
3643         webkit-patch failure-reason was logging about parsing errors
3644         due to my misunderstanding of how BeautifulSoup.findAll worked.
3645
3646         Fixed, and added a unit test.
3647
3648         * Scripts/webkitpy/common/net/layouttestresults.py:
3649         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3650
3651 2011-01-05  Benjamin Poulain  <benjamin.poulain@nokia.com>
3652
3653         Reviewed by Kenneth Rohde Christiansen.
3654
3655         [Qt] [WK2] Add the possibility to open window from the WebProcess in Minibrowser
3656         https://bugs.webkit.org/show_bug.cgi?id=51951
3657
3658         Set a function to QWKPage::setCreateNewPageFunction() in Minibrowser so there is a way
3659         to create new window from WebKit.
3660
3661         * MiniBrowser/qt/BrowserWindow.cpp:
3662         (newPageFunction):
3663         (BrowserWindow::BrowserWindow):
3664         (BrowserWindow::page): Added to avoid the indirect access to QWKPage spread in the class
3665         (BrowserWindow::newWindow):
3666         (BrowserWindow::updateUserAgentList):
3667         (BrowserWindow::showUserAgentDialog):
3668         * MiniBrowser/qt/BrowserWindow.h: Add the global variable backingStoreTypeForNewWindow to
3669         define the type of the backing store used for new windows.
3670         * MiniBrowser/qt/main.cpp:
3671         (main):
3672
3673 2011-01-05  Eric Seidel  <eric@webkit.org>
3674
3675         Reviewed by Ojan Vafai.
3676
3677         commit-queue should report failure type when reporting flaky tests
3678         https://bugs.webkit.org/show_bug.cgi?id=51900
3679
3680         This patch was a ridiculous amount of plumbing.  In the end I like
3681         the NRWT-style TestResult class even less.  But now we're passing
3682         a list of TestResult objects from the queue to the FlakyTestReporter.
3683         Thus the FlakyTestReporter can more easily report what type of failure
3684         occurred.
3685
3686         In the process, I found that I was not alone in finding TestResult
3687         cumbersome to use.  A bunch of code was trying to create a TestResult
3688         object with default values.  However since the constructor didn't make
3689         this easy, some places were getting it wrong (including the TestResult unit test)!
3690         I've fixed the TestResult constructor to have default values for non-essential
3691         arguments.
3692
3693         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3694         * Scripts/webkitpy/common/net/layouttestresults.py:
3695         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3696         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
3697         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3698         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
3699         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
3700         * Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py:
3701         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
3702         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3703         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3704         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3705         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3706         * Scripts/webkitpy/tool/commands/queues.py:
3707         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3708
3709 2011-01-05  Eric Seidel  <eric@webkit.org>
3710
3711         Unreviewed.
3712
3713         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
3714         https://bugs.webkit.org/show_bug.cgi?id=51802
3715
3716         Add another unit test to cover a previously missing import.
3717
3718         * Scripts/webkitpy/common/net/layouttestresults.py:
3719         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3720
3721 2011-01-05  Mihai Parparita  <mihaip@chromium.org>
3722
3723         Reviewed by David Levin.
3724
3725         Add mihaip@chromium.org as a reviewer
3726         https://bugs.webkit.org/show_bug.cgi?id=51966
3727         
3728         Add myself as a reviewer.
3729
3730         * Scripts/webkitpy/common/config/committers.py:
3731
3732 2011-01-05  James Simonsen  <simonjam@chromium.org>
3733
3734         Unreviewed. Adding myself to the list of committers.
3735
3736         * Scripts/webkitpy/common/config/committers.py:
3737
3738 2011-01-05  Eric Seidel  <eric@webkit.org>
3739
3740         Unreviewed.
3741
3742         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
3743         https://bugs.webkit.org/show_bug.cgi?id=51802
3744
3745         Fix two exceptions seen on the bots after my original commit.
3746
3747         * Scripts/webkitpy/common/net/layouttestresults.py:
3748         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3749
3750 2011-01-05  Kundu Suchismita  <suchi.kundu@nokia.com>
3751
3752         Reviewed by Andreas Kling.
3753
3754         [Qt]Add local storage settings to QtTestBrowser command line arguments 
3755         https://bugs.webkit.org/show_bug.cgi?id=51750
3756
3757         * QtTestBrowser/main.cpp:
3758         (LauncherApplication::handleUserOptions):
3759          Local storage settings can be enable form command line arguments for
3760          QtTestBrowser.
3761
3762 2011-01-05  Chris Fleizach  <cfleizach@apple.com>
3763
3764         Reviewed by Martin Robinson.
3765
3766         GTK: AX: DRT needs to use correct root object method.
3767         https://bugs.webkit.org/show_bug.cgi?id=51911
3768
3769         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
3770         (AccessibilityController::rootElement):
3771
3772 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
3773
3774         Rubber-stamped by Csaba Osztrogonác.
3775
3776         Based on idea from Péter Gál.
3777
3778         * Scripts/webkitpy/tool/bot/sheriff.py: Remove unnecessary apostrophes around revision numbers.
3779
3780 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
3781
3782         Reviewed by Adam Barth.
3783
3784         sheriff-bot should be able to do multi-revision rollouts
3785         https://bugs.webkit.org/show_bug.cgi?id=51176
3786
3787         * Scripts/webkitpy/tool/bot/irc_command.py: