58659e69c65d13bdb654a46d16b13739b47a17df
[WebKit.git] / Tools / ChangeLog
1 2011-01-26  Xianzhu Wang  <wangxianzhu@google.com>
2
3         Reviewed by Tony Chang.
4
5         Add '--no-timeout' option to Chromium DRT to ease debugging.
6         https://bugs.webkit.org/show_bug.cgi?id=52873
7
8         * DumpRenderTree/chromium/DumpRenderTree.cpp:
9         (main):
10
11 2011-01-26  Csaba Osztrogonác  <ossy@webkit.org>
12
13         Reviewed by Andreas Kling.
14
15         [Qt] Fix qt_minimal build
16         https://bugs.webkit.org/show_bug.cgi?id=53172
17
18         * QtTestBrowser/locationedit.h:
19
20 2011-01-26  Mansi Mithal  <mansi.mithal@nokia.com>
21
22         Reviewed by Antonio Gomes.
23
24         QtTestBrowser should have a UI Setting to disable plugins
25         https://bugs.webkit.org/show_bug.cgi?id=52408
26         
27         Added a new action item named "Disable Plugins"
28         under the "Settings" menu. 
29
30         * QtTestBrowser/launcherwindow.cpp:
31         (LauncherWindow::createChrome):
32         (LauncherWindow::togglePlugins):
33         * QtTestBrowser/launcherwindow.h:
34
35 2011-01-25  Patrick Gansterer  <paroga@webkit.org>
36
37         Reviewed by Adam Barth.
38
39         Move main CMakeLists.txt into Source directory
40         https://bugs.webkit.org/show_bug.cgi?id=52888
41
42         * Scripts/webkitdirs.pm:
43
44 2011-01-25  Patrick Gansterer  <paroga@webkit.org>
45
46         Reviewed by Eric Seidel.
47
48         Improve label text in submit-to-ews
49         https://bugs.webkit.org/show_bug.cgi?id=53130
50
51         * QueueStatusServer/templates/submittoews.html:
52
53 2011-01-25  Mansi Mithal  <mansi.mithal@nokia.com>
54
55         Reviewed by Antonio Gomes.
56
57         QtTestBrowser should have a UI Settings to prevent loading images
58         https://bugs.webkit.org/show_bug.cgi?id=52409
59         
60         Added a new action item named "DisableAutoLoadImages"
61         under the "Settings" menu 
62
63         * QtTestBrowser/launcherwindow.cpp:
64         (LauncherWindow::createChrome):
65         (LauncherWindow::toggleAutoLoadImages):
66         * QtTestBrowser/launcherwindow.h:
67
68 2011-01-25  Dirk Pranke  <dpranke@chromium.org>
69
70         Reviewed by Tony Chang.
71
72         Minor bug fixes and cleanup for filesystem wrappers, port/* test
73         classes, test_expectations.py. This change adds "test-win" and
74         "test-mac" variants to the test port so that we can better test
75         rebaselining, and adds a MockUser() object for reuse in testing.
76
77         https://bugs.webkit.org/show_bug.cgi?id=53036
78
79         * Scripts/webkitpy/common/system/filesystem.py:
80         * Scripts/webkitpy/common/system/filesystem_mock.py:
81         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
82         * Scripts/webkitpy/layout_tests/port/factory.py:
83         * Scripts/webkitpy/layout_tests/port/base.py:
84         * Scripts/webkitpy/layout_tests/port/test.py:
85         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
86         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
87         * Scripts/webkitpy/tool/mocktool.py:
88
89 2011-01-25  Tony Chang  <tony@chromium.org>
90
91         Reviewed by Dimitri Glazkov.
92
93         [chromium] remove unused layoutTestController callback
94         https://bugs.webkit.org/show_bug.cgi?id=53103
95
96         This method is used by a test_shell_test, but not needed by DRT.
97
98         * DumpRenderTree/chromium/LayoutTestController.cpp:
99         (LayoutTestController::LayoutTestController):
100         * DumpRenderTree/chromium/LayoutTestController.h:
101
102 2011-01-25  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
103
104         Reviewed by Andreas Kling.
105
106         [GTK] Remove 64 bits release bot from the buildbot master
107         https://bugs.webkit.org/show_bug.cgi?id=52899
108
109         Removes the 64 bits release slave from the buildbot configuration,
110         so that we can use it as an EWS.
111
112         * BuildSlaveSupport/build.webkit.org-config/config.json:
113
114 2011-01-24  Maciej Stachowiak  <mjs@apple.com>
115
116         Reviewed by Dan Bernstein.
117
118         Implement database quota callback to fix storage tests on WebKit2 bot
119         https://bugs.webkit.org/show_bug.cgi?id=53064
120
121         * WebKitTestRunner/TestController.cpp:
122         (WTR::exceededDatabaseQuota):
123         (WTR::TestController::createOtherPage):
124         (WTR::TestController::initialize):
125
126 2011-01-24  Maciej Stachowiak  <mjs@apple.com>
127
128         Reviewed by Anders Carlsson.
129
130         Use designated temp directory for the database for WebKit2
131         https://bugs.webkit.org/show_bug.cgi?id=53052
132         
133         Adopt the new WK2 API for this.
134
135         * WebKitTestRunner/TestController.cpp:
136         (WTR::TestController::libraryPathForTesting):
137         (WTR::TestController::initialize):
138         * WebKitTestRunner/TestController.h:
139         * WebKitTestRunner/mac/TestControllerMac.mm:
140         (WTR::TestController::platformLibraryPathForTesting):
141         * WebKitTestRunner/qt/TestControllerQt.cpp:
142         (WTR::TestController::platformLibraryPathForTesting):
143         * WebKitTestRunner/win/TestControllerWin.cpp:
144         (WTR::TestController::platformLibraryPathForTesting):
145
146 2011-01-24  Lucas Forschler  <lforschler@apple.com>
147
148         Reviewed by Stephanie Lewis.
149
150         Add a new Leopard test bot.
151
152         * BuildSlaveSupport/build.webkit.org-config/config.json:
153
154 2011-01-24  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
155
156         Reviewed by Adam Barth.
157
158         Add EFL Builder to core waterfall
159         https://bugs.webkit.org/show_bug.cgi?id=52704
160
161         Add EFL Builder to the core waterfall again.
162
163         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
164         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
165
166 2011-01-24  Xianzhu Wang  <wangxianzhu@google.com>
167
168         Reviewed by Tony Chang.
169
170         new-run-webkit-tests fails to start HTTP server if there are proxy settings
171         https://bugs.webkit.org/show_bug.cgi?id=52872
172
173         Force disabling proxy to resolve the problem.
174
175         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
176         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
177
178 2011-01-24  Andreas Kling  <kling@webkit.org>
179
180         Reviewed by Darin Adler.
181
182         check-webkit-style: Update exemptions following Source/ move.
183         https://bugs.webkit.org/show_bug.cgi?id=53017
184
185         * Scripts/webkitpy/style/checker.py:
186         * Scripts/webkitpy/style/checker_unittest.py:
187
188 2011-01-24  Andras Becsi  <abecsi@webkit.org>
189
190         Rubber-stamped by Csaba Osztrogonác.
191
192         [Qt] Move project files into Source
193         https://bugs.webkit.org/show_bug.cgi?id=52891
194
195         * DumpRenderTree/qt/ImageDiff.pro: Add missing "Source" to WebKit.pri path
196
197 2011-01-24  Mikhail Naganov  <mnaganov@chromium.org>
198
199         Reviewed by Yury Semikhatsky.
200
201         Web Inspector: Find duplicate strings in localizedStrings.js
202
203         https://bugs.webkit.org/show_bug.cgi?id=53005
204
205         * Scripts/check-inspector-strings:
206
207 2011-01-24  Zoltan Horvath  <zoltan@webkit.org>
208
209         Reviewed by Andreas Kling.
210
211         [Qt] Regroup MiniBrowser's menubar and add open file action
212         https://bugs.webkit.org/show_bug.cgi?id=53000
213
214         Add File and Develop menu to MiniBrowser's menubar and add open file action to File menu.
215
216         * MiniBrowser/qt/BrowserWindow.cpp:
217         (BrowserWindow::BrowserWindow):
218         (BrowserWindow::openFile):
219         (BrowserWindow::~BrowserWindow):
220         * MiniBrowser/qt/BrowserWindow.h:
221
222 2011-01-24  Csaba Osztrogonác  <ossy@webkit.org>
223
224         Unreviewed fix after r76496
225
226         [Qt] Move project files into Source
227         https://bugs.webkit.org/show_bug.cgi?id=52891
228
229         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Remove unnecessary "Source" from the path.
230         * BuildSlaveSupport/built-product-archive: Remove unnecessary "Source" from the path.
231         * Scripts/webkitdirs.pm: Add the accidentally removed slash to the path.
232
233 2011-01-24  Andras Becsi  <abecsi@webkit.org>
234
235         Reviewed by Csaba Osztrogonác.
236
237         [Qt] Move project files into Source
238         https://bugs.webkit.org/show_bug.cgi?id=52891
239
240         * DerivedSources.pro: Renamed from DerivedSources.pro.
241         * DumpRenderTree/qt/DumpRenderTree.pro:
242         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
243         * MiniBrowser/DerivedSources.pro:
244         * MiniBrowser/qt/MiniBrowser.pro:
245         * QtTestBrowser/QtTestBrowser.pro:
246         * Scripts/webkitdirs.pm:
247         * Tools.pro: Added.
248         * WebKitTestRunner/DerivedSources.pro:
249         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
250         * WebKitTestRunner/qt/WebKitTestRunner.pro:
251
252 2011-01-22  Geoffrey Garen  <ggaren@apple.com>
253
254         Reviewed by Dan Bernstein.
255
256         Beefed up --threaded mode to catch even more kinds of errors.
257         https://bugs.webkit.org/show_bug.cgi?id=52971
258
259         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Use a shared
260         context group to force JSC to mark multiple threads. (This used to be
261         the default, but it changed in SnowLeopard.)
262         (runJavaScriptThread): Do more locking and unlocking, and more allocation,
263         to give threading mistakes more chances to show themselves.
264         (startJavaScriptThreads):
265         (stopJavaScriptThreads):
266
267 2011-01-22  Robert Hogan  <robert@webkit.org>
268
269         Reviewed by Andreas Kling.
270
271         [Qt] Support layoutTestController.addURLToRedirect()
272         https://bugs.webkit.org/show_bug.cgi?id=52956
273
274         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
275         (LayoutTestController::addURLToRedirect):
276         * DumpRenderTree/qt/LayoutTestControllerQt.h:
277
278 2011-01-22  Robert Hogan  <robert@webkit.org>
279
280         Reviewed by Kenneth Rohde Christiansen.
281
282         [Qt] REGRESSION (r72360): http/tests/security/aboutBlank/xss-DENIED-* tests fail
283         https://bugs.webkit.org/show_bug.cgi?id=49802
284
285         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
286         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
287         (WebCore::DumpRenderTree::open):
288
289 2011-01-21  Adam Barth  <abarth@webkit.org>
290
291         Reviewed by Maciej Stachowiak.
292
293         Disable mac_unittest.py that fails on some of the Mac bots
294         https://bugs.webkit.org/show_bug.cgi?id=52947
295
296         As noted in the comment, this test does not appear to be correct
297         because the function this test is testing returns different results
298         depending on which flavor of Mac the test is run on.  This patch
299         disable the test.  Hopefully we can re-enable the test once we've
300         probably insulated the test from its environment.
301
302         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
303
304 2011-01-21  Dirk Pranke  <dpranke@chromium.org>
305
306         Reviewed by Mihai Parparita.
307
308         Fix bug introduced in r76322 that caused NRWT to not actually
309         read the Skipped files properly.
310
311         https://bugs.webkit.org/show_bug.cgi?id=52771
312
313         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
314         * Scripts/webkitpy/layout_tests/port/webkit.py:
315         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
316
317 2011-01-21  Sam Weinig  <sam@webkit.org>
318
319         Reviewed by Geoffrey Sean Garen and Mark Rowe.
320
321         WebKitTestRunner needs the HOME environment variable to be set.
322         <rdar://problem/8896573>
323
324         * Scripts/old-run-webkit-tests: Set the HOME environment variable if
325         it exists.
326
327 2011-01-21  Dirk Pranke  <dpranke@chromium.org>
328
329         Reviewed by Eric Seidel.
330
331         Suppress a few remaining integration tests so that none of the
332         layout_test unit tests ever read from the filesystem or launch
333         subprocesses that aren't part of the unit tests.
334
335         Also fix a minor bug in the printing unit tests that was
336         incorrectly relying on sys.argv.
337
338         https://bugs.webkit.org/show_bug.cgi?id=52863
339
340         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
341         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
342         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
343
344 2011-01-21  Darin Adler  <darin@apple.com>
345
346        Fix Mac build.
347
348         * MiniBrowser/mac/BrowserWindowController.m:
349         (-[BrowserWindowController awakeFromNib]): Pass 0 for runModal function.
350
351 2011-01-20  Darin Adler  <darin@apple.com>
352
353         Reviewed by Dan Bernstein.
354
355         WebKit2: Implement showModalDialog
356         https://bugs.webkit.org/show_bug.cgi?id=52855
357
358         This fixes WebKitTestRunner to compile, but more work is probably
359         needed to get it to pass the tests.
360
361         * WebKitTestRunner/TestController.cpp:
362         (WTR::TestController::runModal): Added. Calls through to the
363         platform-specific version of runModal.
364         (WTR::TestController::createOtherPage): Changed to be a private
365         static member function so it can refer to runModal, which is
366         a private static member function.
367         (WTR::TestController::initialize): Pass 0 for the runModal
368         function since we don't need to run the main window modal.
369         I suspect this is wrong and will need to change.
370         * WebKitTestRunner/TestController.h: Added declarations for
371         the functions added above.
372         * WebKitTestRunner/mac/TestControllerMac.mm:
373         (WTR::TestController::runModal): Added. Untested implementation.
374         * WebKitTestRunner/qt/TestControllerQt.cpp:
375         (WTR::TestController::runModal): Added.
376         * WebKitTestRunner/win/TestControllerWin.cpp:
377         (WTR::TestController::runModal): Added.
378
379 2011-01-21  Eric Seidel  <eric@webkit.org>
380
381         Reviewed by Adam Barth.
382
383         Split Host object off from WebKitPatch for easier re-use
384         https://bugs.webkit.org/show_bug.cgi?id=52284
385
386         new-run-webkit-tests and other tools are eventually going to want one of these.
387         Basically you need to inherit from this class if you want to pretend to be a
388         self.tool object for Steps/Commands.
389
390         * Scripts/webkitpy/common/host.py: Added.
391         * Scripts/webkitpy/tool/main.py:
392
393 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
394
395         Reviewed by Adam Barth.
396
397         Disable the tests that start and stop the http server and web
398         server, so that we don't have to worry about port collisions on
399         the bots.
400
401         https://bugs.webkit.org/show_bug.cgi?id=52861
402
403         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
404
405 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
406
407         Reviewed by Eric Seidel.
408
409         nrwt: rewrite google_chrome_unittest to use mock filesystem.
410         
411         https://bugs.webkit.org/show_bug.cgi?id=52772
412         
413         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
414
415 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
416
417         Reviewed by Eric Siedel.
418
419         nrwt: clean up almost all remaining port references, remove
420         unnecessary import clauses. The only remaining references are
421         in places where a mock filesystem makes no sense or can't be
422         used, and in one routine in port/google_chrome_unittest that
423         I'll rewrite in a separate patch.
424
425         https://bugs.webkit.org/show_bug.cgi?id=52771
426
427         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
428         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
429         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
430         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
431         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
432         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
433         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
434         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
435         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
436         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
437         * Scripts/webkitpy/layout_tests/port/gtk.py:
438         * Scripts/webkitpy/layout_tests/port/mac.py:
439         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
440         * Scripts/webkitpy/layout_tests/port/qt.py:
441         * Scripts/webkitpy/layout_tests/port/webkit.py:
442         * Scripts/webkitpy/layout_tests/port/win.py:
443         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
444
445 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
446
447         Reviewed by Mihai Parparita.
448
449         remove fs refs from run_webkit_tests, rebaseline_chromium_webkit_tests
450
451         https://bugs.webkit.org/show_bug.cgi?id=52762
452
453         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
454         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
455
456 2011-01-20  Tony Chang  <tony@chromium.org>
457
458         Reviewed by Ojan Vafai.
459
460         [chromium] fix the paths used for the rebaseline tool
461         https://bugs.webkit.org/show_bug.cgi?id=52857
462
463         Some of the bots were renamed so the path to grab the results zip
464         file has changed.
465
466         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
467
468 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
469
470         Reviewed by Tony Chang.
471
472         Fix bug introduced in r72688 / bug 52768 that broke the
473         generation of the output filename links in the results.html
474         output. Apparently none of the unit tests actually checked to
475         make sure the generated links were correct :(
476
477         https://bugs.webkit.org/show_bug.cgi?id=52854
478
479         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
480         * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
481
482 2011-01-20  Alexey Proskuryakov  <ap@apple.com>
483
484         Reviewed by Darin Adler.
485
486         https://bugs.webkit.org/show_bug.cgi?id=52849
487         Make window.print work with WebKit2
488
489         * MiniBrowser/mac/BrowserWindowController.m:
490         (-[BrowserWindowController awakeFromNib]):
491         * WebKitTestRunner/TestController.cpp:
492         (WTR::createOtherPage):
493         (WTR::TestController::initialize):
494         Added zeroes to WKPageUIClient structures to avoid build failures.
495
496 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
497
498         Reviewed by Eric Seidel.
499
500         nrwt: remove fs refs from printing, test_failures, test_expectations, text_diff
501
502         https://bugs.webkit.org/show_bug.cgi?id=52756
503
504         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
505         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
506         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
507         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
508         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
509         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
510
511 2011-01-20  Mansi Mithal  <mansi.mithal@nokia.com>
512
513         Reviewed by Antonio Gomes.
514
515         QtTestBrowser should have a seperate menu for Settings
516         https://bugs.webkit.org/show_bug.cgi?id=52817
517         
518         Added a new menu item named "Settings"
519         and moved the "Enable interrupting js scripts" and "Enable js pop up windows" under the "Settings" menu 
520
521         * QtTestBrowser/launcherwindow.cpp:
522         (LauncherWindow::createChrome):
523
524 2011-01-20  Sam Weinig  <sam@webkit.org>
525
526         Reviewed by John Sullivan.
527
528         Update update-webkit-localizable-strings with new path to WebKit.
529
530         * Scripts/update-webkit-localizable-strings:
531
532 2011-01-20  James Robinson  <jamesr@chromium.org>
533
534         Reviewed by Darin Fisher.
535
536         Implement mozilla's requestAnimationFrame API
537         https://bugs.webkit.org/show_bug.cgi?id=51218
538
539         Chromium DumpRenderTree support for window.webkitRequestAnimationFrame.
540
541         * DumpRenderTree/chromium/WebViewHost.cpp:
542         (invokeScheduleComposite):
543         (WebViewHost::scheduleAnimation):
544         (WebViewHost::paintInvalidatedRegion):
545         * DumpRenderTree/chromium/WebViewHost.h:
546
547 2011-01-20  Maciej Stachowiak  <mjs@apple.com>
548
549         Reviewed by Adam Roben.
550
551         WebKitTestRunner needs to support layoutTestController.evaluateScriptInIsolatedWorld
552         https://bugs.webkit.org/show_bug.cgi?id=42327
553
554         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm: Add support
555         for methods that take their normal arguments but also a JSContextRef.
556         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: IDL definition
557         for evaluateScriptInIsolatedWorld.
558         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
559         (WTR::InjectedBundlePage::didClearWindowForFrame): Set a magic variable only if
560         this call is for an isolated world.
561         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
562         (WTR::worldMap): Helper to create a world map.
563         (WTR::LayoutTestController::worldIDForWorld): Map from an ID to a world.
564         (WTR::LayoutTestController::evaluateScriptInIsolatedWorld): The newly
565         added LayoutTestController API.
566         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
567
568 2011-01-19  Adam Roben  <aroben@apple.com>
569
570         Convert paths in environment variables back to msys-style inside commit-log-editor
571
572         When this script gets run from inside git commit, msys-style paths in the environment will
573         have been turned into Windows-style paths with forward slashes. This screws up functions
574         like File::Spec->rel2abs, which seem to rely on $PWD having an msys-style path. We convert
575         the paths back to msys-style before doing anything else.
576
577         Fixes <http://webkit.org/b/48527> commit-log-editor uses full paths for section headers when
578         using msysgit's Perl and multiple ChangeLogs have been edited
579
580         Reviewed by David Kilzer.
581
582         * Scripts/commit-log-editor: Call fixEnvironment before doing anything else.
583         (fixEnvironment): Added. When run in msys in conjunction with git (i.e., when invoked from
584         inside git commit), convert Windows-style paths in the environment back to msys-style paths.
585
586 2011-01-20  Zoltan Horvath  <zoltan@webkit.org>
587
588         [Win] Unreviewed build fix after r76248.
589
590         * DumpRenderTree/ForwardingHeaders/wtf/FastAllocBase.h: Added.
591
592 2011-01-20  Zoltan Horvath  <zoltan@webkit.org>
593
594         Reviewed by Csaba Osztrogonác.
595
596         Refactoring of the custom allocation framework
597         https://bugs.webkit.org/show_bug.cgi?id=49897
598
599         Inheriting from FastAllocBase can result in objects getting larger (bug #33896, #46589).
600         The modification replaces Noncopyable and FastAllocBase classes and these inherits with their
601         equivalent macro implementation at the necessary places.
602 2011-01-20  Yi Shen  <yi.4.shen@nokia.com>
603
604         Unreviewed. 
605
606         Adding myself to committers.py.
607
608         * Scripts/webkitpy/common/config/committers.py:
609
610 2011-01-20  Adam Barth  <abarth@webkit.org>
611
612         Reviewed by Tony Chang.
613
614         Chromium builders don't delete unversioned directories when DEPS change
615         https://bugs.webkit.org/show_bug.cgi?id=52745
616
617         If we pass this option to gclient sync, gclient will delete directories
618         that are no longer part of DEPS instead of leaving them around to
619         confuse us later.  Apparently, the downstream buildbots use this option
620         already.
621
622         * Scripts/update-webkit-chromium:
623
624 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
625
626         Unreviewed, build fix - I pulled this patch in to fix an issue
627         revealed by r76195 running on some new bots). Also fix a couple
628         of other issues revealed in testing.
629
630         nrwt: remove fs refs from layout_package/json*
631
632         https://bugs.webkit.org/show_bug.cgi?id=52754
633
634         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
635         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
636         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
637         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
638         * Scripts/webkitpy/layout_tests/port/base.py:
639
640 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
641
642         Unreviewed, build fix.
643
644         Fix a couple of minor bugs discovered while bringing up new bots
645         for testing.
646
647         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
648         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
649
650 2011-01-19  James Robinson  <jamesr@chromium.org>
651
652         Unreviewed, rolling out r76194.
653         http://trac.webkit.org/changeset/76194
654         https://bugs.webkit.org/show_bug.cgi?id=51218
655
656         Caused mysterious compile failure on the chromium win
657         build.webkit.org bots
658
659         * DumpRenderTree/chromium/WebViewHost.cpp:
660         (WebViewHost::paintInvalidatedRegion):
661         * DumpRenderTree/chromium/WebViewHost.h:
662
663 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
664
665         Reviewed by Mihai Parparita.
666
667         remove fs refs from test_runner, dump_render_tree_thread
668
669         https://bugs.webkit.org/show_bug.cgi?id=52753
670
671         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
672         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
673         * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
674         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
675
676 2011-01-19  James Robinson  <jamesr@chromium.org>
677
678         Reviewed by Darin Fisher.
679
680         Implement mozilla's requestAnimationFrame API
681         https://bugs.webkit.org/show_bug.cgi?id=51218
682
683         Chromium DumpRenderTree support for window.webkitRequestAnimationFrame.
684
685         * DumpRenderTree/chromium/WebViewHost.cpp:
686         (invokeScheduleComposite):
687         (WebViewHost::scheduleAnimation):
688         (WebViewHost::paintInvalidatedRegion):
689         * DumpRenderTree/chromium/WebViewHost.h:
690
691 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
692
693         Unreviewed, build fix.
694
695         Fix a few incorrect "self._filesystem" references introduced in
696         r76184.
697
698         * Scripts/webkitpy/layout_tests/port/chromium.py:
699         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
700
701 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
702
703         Reviewed by Mihai Parparita.
704
705         add a .sep property, abspath(), isabs(), mtime(), and
706         open_text_file_for_writing() to filesystem modules. Some of
707         these properties are not needed in this patch but will be needed
708         in subsequent patches (I'm doing this to avoid having to track
709         multiple versions of a single file).
710
711         Also, change most of the port/* modules to use the filesystem
712         objects instead of referencing the filesystem directly.
713
714         https://bugs.webkit.org/show_bug.cgi?id=52748
715
716         * Scripts/webkitpy/common/system/filesystem.py:
717         * Scripts/webkitpy/common/system/filesystem_mock.py:
718         * Scripts/webkitpy/layout_tests/port/__init__.py:
719         * Scripts/webkitpy/layout_tests/port/base.py:
720         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
721         * Scripts/webkitpy/layout_tests/port/chromium.py:
722         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
723         * Scripts/webkitpy/layout_tests/port/config.py:
724         * Scripts/webkitpy/layout_tests/port/test.py:
725         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
726
727 2011-01-19  Maciej Stachowiak  <mjs@apple.com>
728
729         Reviewed by Anders Carlsson.
730
731         If resetting between tests times out, treat it as a WebProcess crash
732         https://bugs.webkit.org/show_bug.cgi?id=52757
733
734         * WebKitTestRunner/TestController.cpp:
735         (WTR::TestController::runTest):
736
737 2011-01-19  Alexey Proskuryakov  <ap@apple.com>
738
739         Reviewed by Darin Adler.
740
741         https://bugs.webkit.org/show_bug.cgi?id=52739
742         Make it possible for a WebKit2 client to print headers and footers
743
744         Added dummy implementations for new printing UIClient calls.
745
746         * MiniBrowser/mac/BrowserWindowController.m:
747         (-[BrowserWindowController awakeFromNib]):
748         * WebKitTestRunner/TestController.cpp:
749         (WTR::createOtherPage):
750         (WTR::TestController::initialize):
751
752 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
753
754         Reviewed by Ojan Vafai.
755
756         Change webkitpy/layout_tests/port/test.py to use the
757         in-memory filesystem for cleaner unit testing. This
758         change allows us to kill a lot of code that was
759         specific to the test port, at the cost of being a
760         little less clear about how things would work if
761         you didn't have a filesystem.
762
763         https://bugs.webkit.org/show_bug.cgi?id=52605
764
765         * Scripts/webkitpy/layout_tests/port/test.py:
766
767 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
768
769         Unreviewed, build fix.
770
771         Fix test failure caused by committing attachment 79368 instead
772         of attachment 79461 on bug 52604.
773
774         * Scripts/webkitpy/common/system/filesystem_mock.py:
775
776 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
777
778         Reviewed by Mihai Parparita.
779
780         new-run-webkit-tests: remove use of os.walk, use mock filesystem for better
781         unit testing. os.walk() is too much of a hassle to implement on
782         top of the in-memory mock filesystem and adding the necessary
783         interface to files_under() gives clients a cleaner API anyway
784         (for this particular usage model).
785
786         https://bugs.webkit.org/show_bug.cgi?id=52691
787
788         * Scripts/webkitpy/common/system/filesystem.py:
789         * Scripts/webkitpy/common/system/filesystem_mock.py:
790         * Scripts/webkitpy/layout_tests/port/test_files.py:
791         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
792
793 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
794
795         Reviewed by Tony Chang.
796
797         Change more modules in the layout-tests code to use the
798         filesystem wrapper for cleaner unit testing.
799
800         This patch also adds the glob() wrapper to the filesystem
801         abstraction.
802         
803         https://bugs.webkit.org/show_bug.cgi?id=52604
804
805         * Scripts/webkitpy/layout_tests/port/test_files.py:
806         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
807         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
808         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
809         * Scripts/webkitpy/common/system/filesystem.py:
810         * Scripts/webkitpy/common/system/filesystem_mock.py:
811
812 2011-01-19  Levi Weintraub  <leviw@chromium.org>
813
814         Unreviewed.
815
816         Updating my email addresses and irc nick.
817
818         * Scripts/webkitpy/common/config/committers.py:
819
820 2011-01-19  Tony Chang  <tony@chromium.org>
821
822         Reviewed by Mihai Parparita.
823
824         [chromium] [linux] if check-sys-deps fails, output the failure reason
825         https://bugs.webkit.org/show_bug.cgi?id=52671
826
827         * Scripts/webkitpy/common/system/executive_mock.py: Add support for
828             error handler functions.
829         * Scripts/webkitpy/layout_tests/port/chromium.py:
830             output the error text from --check-sys-deps
831         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
832
833 2011-01-19  Aparna Nandyal  <aparna.nand@wipro.com>
834
835         Reviewed by Andreas Kling.
836
837         [Qt] QtTestBrowser crashes when closing if Facebook is opened
838         https://bugs.webkit.org/show_bug.cgi?id=52554
839         
840         QtNetworkAccessManager is created in a thread and set as
841         member variable in QWebPage. When the thread is destroyed
842         the object is still used. So fix will set the object to
843         NULL once the thread is destroyed.
844
845         * QtTestBrowser/launcherwindow.cpp:
846         (LauncherWindow::~LauncherWindow):
847
848 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
849
850         Rubber stamped by Csaba Osztrogonac
851
852         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: Removed unncessary inculde of WKStringCF.h
853
854 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
855
856         Reviewed by Tony Chang.
857
858         new-run-webkit-tests: add a --build-directory command line argument
859
860         Official Google Chrome builds use a non-standard build directory
861         location. This patch adds a --build-directory argument that
862         allows that location to be specified on the command line. Only
863         Chromium-based builds will use this flag for now, but anyone can
864         in the future.
865
866         There are no unit tests for this since it's difficult to test
867         until mock filesystems are fully supported in the code. This was
868         tested by hand for now.
869
870         https://bugs.webkit.org/show_bug.cgi?id=52694
871
872         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
873         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
874         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
875         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
876
877 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
878
879         Not reviewed. Bot fix.
880
881         Remove an inadvertently committed debugging print.
882
883         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
884         (LayoutTestController::notifyDone):
885
886 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
887
888         Reviewed by Sam Weinig.
889
890         WebKitTestRunner should track loading more like DumpRenderTree
891         https://bugs.webkit.org/show_bug.cgi?id=52692
892
893         Change load tracking to track the current top loading frame, in the manner of DumpRenderTree.
894         This makes some tests that call notifyDone multiple times pass.
895         
896         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
897         (WTR::InjectedBundle::InjectedBundle):
898         (WTR::InjectedBundle::done):
899         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
900         (WTR::InjectedBundle::topLoadingFrame):
901         (WTR::InjectedBundle::setTopLoadingFrame):
902         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
903         (WTR::InjectedBundlePage::InjectedBundlePage):
904         (WTR::InjectedBundlePage::stopLoading):
905         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
906         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
907         (WTR::InjectedBundlePage::didFinishLoadForFrame):
908         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
909         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
910         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
911         (WTR::LayoutTestController::notifyDone):
912         * WebKitTestRunner/TestController.cpp:
913         (WTR::TestController::didReceiveMessageFromInjectedBundle):
914
915 2011-01-18  Mihai Parparita  <mihaip@chromium.org>
916
917         Reviewed by Kent Tamura.
918
919         [Chromium] NRWT looking for DRT binary in the wrong path on Mac
920         https://bugs.webkit.org/show_bug.cgi?id=52678
921         
922         Update path now that WebKit is inside Source.
923
924         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
925
926 2011-01-18  Robert Hogan  <robert@webkit.org>
927
928         Reviewed by Simon Hausmann.
929
930         [Qt] http/tests/incremental/slow-utf8-text.pl fails
931         https://bugs.webkit.org/show_bug.cgi?id=44282
932
933         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
934         (WebCore::DumpRenderTree::dump):
935
936 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
937
938         Reviewed by Mihai Parparita.
939
940         Fix a small race condition that could cause the unit tests for
941         new-run-webkit-tests to fail in a multithreaded environment.
942         There was a small window in the code where one thread would
943         check to see if a thread had raised an exception, do something,
944         and then check to see if the thread was alive. If the other
945         thread raised an exception and exited in between these two
946         steps, the exception would be lost. Flipping the order of the
947         two checks fixes the race, since we will now always check for an
948         exception on the thread before exiting.
949
950         https://bugs.webkit.org/show_bug.cgi?id=51579
951
952         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
953
954 2011-01-18  Eric Seidel  <eric@webkit.org>
955
956         Reviewed by Adam Barth.
957
958         commit-queue dies when test archiving fails
959         https://bugs.webkit.org/show_bug.cgi?id=52617
960
961         I looked at the machine and it had 10 archives already
962         thus find_unused_name was returning None.  I've upped
963         the limit to 100 (per bug) and tested the case where
964         find_unused_name returns None (making archive return None).
965
966         * Scripts/webkitpy/common/system/workspace.py:
967         * Scripts/webkitpy/common/system/workspace_unittest.py:
968         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
969         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
970         * Scripts/webkitpy/tool/commands/queues.py:
971
972 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
973
974         Reviewed by Ojan Vafai.
975
976         Update rebaseline-chromium-webkit-tests unit tests to use a mock
977         filesystem. Also fix a couple of "with" statements missed by
978         r76050.
979
980         https://bugs.webkit.org/show_bug.cgi?id=52487
981
982         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
983
984 2011-01-18  Sergio Villar Senin  <svillar@igalia.com>
985
986         Reviewed by Martin Robinson.
987
988         [Gtk] Build fixes for gtk3 build
989         https://bugs.webkit.org/show_bug.cgi?id=52648
990
991         * DumpRenderTree/gtk/EventSender.cpp:
992         (beginDragWithFilesCallback):
993
994 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
995
996         Reviewed by Mihai Parparita.
997
998         Update rebaseline-chromium-webkit-tests to use filesystem objects
999         instead of direct references to os.path, shutil, tempfile, etc.
1000
1001         This patch doesn't change anything, but will allow subsequent
1002         patches to change the unit tests to no longer use the real
1003         filesystem.
1004
1005         This patch adds a bunch more methods to the filesystem object as
1006         well.
1007
1008         https://bugs.webkit.org/show_bug.cgi?id=52482
1009
1010         * Scripts/webkitpy/common/system/filesystem.py:
1011         * Scripts/webkitpy/common/system/filesystem_mock.py:
1012         * Scripts/webkitpy/tool/commands/queues.py:
1013         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1014         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
1015
1016 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
1017
1018         Reviewed by Mihai Parparita.
1019
1020         new-run-webkit-tests shouldn't crash when you try to run a
1021         directory containing only skipped files.
1022
1023         https://bugs.webkit.org/show_bug.cgi?id=52478
1024         
1025         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1026         * Scripts/webkitpy/layout_tests/port/test.py:
1027         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1028
1029 2011-01-18  Adam Bergkvist  <adam.bergkvist@ericsson.com> and Martin Robinson  <mrobinson@igalia.com>
1030
1031         Reviewed by Gustavo Noronha Silva.
1032
1033         [GTK] The GTK+ EventSender needs support for beginDragWithFiles
1034         https://bugs.webkit.org/show_bug.cgi?id=40833
1035
1036         * DumpRenderTree/gtk/EventSender.cpp: Add a beginDragWithFiles implementation for the
1037         GTK+ event sender.
1038         (dragWithFilesDragDataGetCallback): Added.
1039         (dragWithFilesDragEndCallback): Added.
1040         (beginDragWithFilesCallback): Added.
1041
1042 2011-01-18  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1043
1044         Reviewed by Adam Barth.
1045
1046         ews: Add additional watcher to efl ews
1047         https://bugs.webkit.org/show_bug.cgi?id=52613
1048
1049         Add gyuyoung.kim@samsung.com to watcher list of efl-ews.
1050
1051         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1052
1053 2011-01-17  Tony Gentilcore  <tonyg@chromium.org>
1054
1055         Reviewed by Alexey Proskuryakov.
1056
1057         Fix some headers with missing or misspelled #ifndef guards
1058         https://bugs.webkit.org/show_bug.cgi?id=52545
1059
1060         * DumpRenderTree/chromium/TestEventPrinter.h:
1061         * DumpRenderTree/chromium/WebPreferences.h:
1062
1063 2011-01-17  Jessie Berlin  <jberlin@apple.com>
1064
1065         Reviewed by Anders Carlsson.
1066
1067         REGRESSION: Assertion failure in FrameLoader::continueLoadAfterWillSubmitForm() when
1068         navigating back to an unreachable URL
1069         https://bugs.webkit.org/show_bug.cgi?id=52388
1070
1071         Add a third parameter (unreachableURL) to queueLoadHTMLString.
1072
1073         * DumpRenderTree/LayoutTestController.cpp:
1074         (queueLoadHTMLStringCallback):
1075         (LayoutTestController::queueLoadHTMLString):
1076         (LayoutTestController::queueLoadAlternateHTMLString):
1077         * DumpRenderTree/LayoutTestController.h:
1078
1079         * DumpRenderTree/WorkQueueItem.h:
1080         (LoadHTMLStringItem::LoadHTMLStringItem):
1081
1082         * DumpRenderTree/chromium/LayoutTestController.cpp:
1083         (WorkItemLoadHTMLString::WorkItemLoadHTMLString):
1084         (WorkItemLoadHTMLString::run):
1085         (LayoutTestController::queueLoadHTMLString):
1086
1087         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
1088         (LoadHTMLStringItem::invoke):
1089         * DumpRenderTree/mac/WorkQueueItemMac.mm:
1090         (LoadHTMLStringItem::invoke):
1091         * DumpRenderTree/win/WorkQueueItemWin.cpp:
1092         (LoadHTMLStringItem::invoke):
1093
1094 2011-01-17  Dan Bernstein  <mitz@apple.com>
1095
1096         Rubber-stamped by Mark Rowe.
1097
1098         Update xcodeproj svn:ignore to include xcuserdata.
1099
1100         * DumpRenderTree/DumpRenderTree.xcodeproj: Modified property svn:ignore.
1101         * MiniBrowser/MiniBrowser.xcodeproj: Modified property svn:ignore.
1102         * TestWebKitAPI/TestWebKitAPI.xcodeproj: Modified property svn:ignore.
1103         * WebKitLauncher/WebKitLauncher.xcodeproj: Modified property svn:ignore.
1104         * WebKitTestRunner/WebKitTestRunner.xcodeproj: Modified property svn:ignore.
1105
1106 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
1107
1108         Unreviewed fix after r75908.
1109
1110         Move WebKit into Source
1111         https://bugs.webkit.org/show_bug.cgi?id=52530
1112
1113         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add Source to the path for Qt API tests.
1114
1115 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
1116
1117         Unreviewed.
1118
1119         Remove accidentally committed debug printing after r75908.
1120
1121         * Scripts/webkitdirs.pm:
1122
1123 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
1124
1125         Unreviewed.
1126
1127         Add myself to committers list
1128         https://bugs.webkit.org/show_bug.cgi?id=52566
1129
1130         * Scripts/webkitpy/common/config/committers.py:
1131
1132 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
1133
1134         Reviewed by Jeremy Orlow.
1135
1136         GeolocationController should call stopUpdating on destruction
1137         https://bugs.webkit.org/show_bug.cgi?id=52216
1138
1139         fast/dom/Geolocation/window-close-crash.html requires that a
1140         Geolocation watch be started in a secondary window. Consequently,
1141         we need to allow geolocation permission and provide a mock
1142         geolocation position for the secondary window's
1143         GeolocationClientMock.
1144
1145         * DumpRenderTree/chromium/LayoutTestController.cpp:
1146         (LayoutTestController::setGeolocationPermission):
1147         (LayoutTestController::setMockGeolocationPosition):
1148         (LayoutTestController::setMockGeolocationError):
1149         * DumpRenderTree/chromium/TestShell.h:
1150         (TestShell::windowList):
1151
1152 2011-01-16  Adam Barth  <abarth@webkit.org>
1153
1154         Update more include paths to reflect WebKit move.
1155
1156         * DumpRenderTree/chromium/EventSender.cpp:
1157         (EventSender::keyDown):
1158         (EventSender::needsShiftModifier):
1159         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
1160         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
1161
1162 2011-01-16  Kent Tamura  <tkent@chromium.org>
1163
1164         Unreviewed, Chromium build fix.
1165
1166         * Scripts/update-webkit-chromium: Webkit/chromium -> Source/WebKit/chromium
1167
1168 2011-01-16  Martin Robinson  <mrobinson@igalia.com>
1169
1170         Build fix for GTK+ after source directory movement.
1171
1172         * GNUmakefile.am: Correct include paths.
1173
1174 2011-01-16  Adam Barth  <abarth@webkit.org>
1175
1176         Teach svn-apply about WebKit move.
1177
1178         * Scripts/VCSUtils.pm:
1179
1180 2011-01-16  Adam Barth  <abarth@webkit.org>
1181
1182         Rubber-stamped by Eric Seidel.
1183
1184         Move WebKit into Source
1185         https://bugs.webkit.org/show_bug.cgi?id=52530
1186
1187         * DumpRenderTree/mac/InternalHeaders/WebKit/WebTypesInternal.h:
1188         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1189         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1190         * DumpRenderTree/qt/GCControllerQt.cpp:
1191         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1192         * DumpRenderTree/qt/PlainTextControllerQt.cpp:
1193         * DumpRenderTree/qt/TextInputControllerQt.cpp:
1194         * DumpRenderTree/wscript:
1195         * QtTestBrowser/launcherwindow.h:
1196         * Scripts/build-webkit:
1197         * Scripts/webkitdirs.pm:
1198
1199 2011-01-15  Adam Barth  <abarth@webkit.org>
1200
1201         Teach svn-apply about WebKit2 move.
1202
1203         * Scripts/VCSUtils.pm:
1204
1205 2011-01-15  Adam Barth  <abarth@webkit.org>
1206
1207         Rubber-stamped by Eric Seidel.
1208
1209         Move WebKit2 into Source
1210         https://bugs.webkit.org/show_bug.cgi?id=52438
1211
1212         * MiniBrowser/qt/MiniBrowser.pro:
1213         * Scripts/build-webkit:
1214         * Scripts/do-file-rename:
1215         * Scripts/do-webcore-rename:
1216         * Scripts/test-webkitpy:
1217         * Scripts/webkitdirs.pm:
1218         * Scripts/webkitpy/style/checker.py:
1219         * WebKitTestRunner/DerivedSources.pro:
1220         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1221         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1222
1223 2011-01-15  Jochen Eisinger  <jochen@chromium.org>
1224
1225         Reviewed by David Levin.
1226
1227         [chromium] remove obsolete createView method
1228         https://bugs.webkit.org/show_bug.cgi?id=52437
1229
1230         * DumpRenderTree/chromium/WebViewHost.cpp:
1231         (WebViewHost::createView):
1232         * DumpRenderTree/chromium/WebViewHost.h:
1233
1234 2011-01-14  Brian Weinstein  <bweinstein@apple.com>
1235
1236         Reviewed by Geoff Garen.
1237
1238         ShouldLoadResourceForFrame should use strings, not URLs.
1239         https://bugs.webkit.org/show_bug.cgi?id=52476
1240
1241         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1242         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Update to use a WKStringRef.
1243         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1244
1245 2011-01-14  Tony Gentilcore  <tonyg@chromium.org>
1246
1247         Reviewed by David Levin.
1248
1249         Add Tony Gentilcore as a reviewer
1250         https://bugs.webkit.org/show_bug.cgi?id=52480
1251
1252         * Scripts/webkitpy/common/config/committers.py:
1253
1254 2011-01-14  David Levin  <levin@chromium.org>
1255
1256         Reviewed by Eric Seidel.
1257
1258         check-webkit-style: _FunctionState should keep track of where the function name starts.
1259         https://bugs.webkit.org/show_bug.cgi?id=52454
1260
1261         * Scripts/webkitpy/style/checkers/cpp.py: Added function_name_start_position to
1262         _FunctionState and logic for setting it correctly.
1263         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests.
1264
1265 2011-01-14  Vincent Scheib  <scheib@chromium.org>
1266
1267         Reviewed by David Levin.
1268
1269         Add support to DumpRenderTree to use the GPU rather than software renderer
1270         https://bugs.webkit.org/show_bug.cgi?id=52333
1271
1272         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1273         (main):
1274         * Scripts/webkitpy/layout_tests/port/chromium.py:
1275         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1276
1277 2011-01-14  Tony Chang  <tony@chromium.org>
1278
1279         Reviewed by Kent Tamura.
1280
1281         [chromium] update fonts.conf to fix 6 linux tests in drt
1282         https://bugs.webkit.org/show_bug.cgi?id=52411
1283
1284         * DumpRenderTree/chromium/fonts.conf: Update to match the copy in
1285             chromium's src/webkit/tools/test_shell/resources/fonts.conf
1286
1287 2011-01-14  Eric Seidel  <eric@webkit.org>
1288
1289         Original patch from Peter Gal  <galpater@inf.u-szeged.hu>
1290
1291         Reviewed by Adam Barth.
1292
1293         Fix when running Tools/Scripts/check-webkit-style without arguments.
1294         https://bugs.webkit.org/show_bug.cgi?id=52261#c16
1295
1296         * Scripts/webkitpy/common/checkout/scm.py: Handle None for changed_files argument better in Git.create_patch method.
1297         * Scripts/webkitpy/common/checkout/scm_unittest.py:
1298
1299 2011-01-04  Jochen Eisinger  <jochen@chromium.org>
1300
1301         Reviewed by David Levin.
1302
1303         Store the tempdir object in a variable so it doesn't get deleted too early.
1304         https://bugs.webkit.org/show_bug.cgi?id=51875
1305
1306         * Scripts/update-webkit-auxiliary-libs:
1307         * Scripts/update-webkit-support-libs:
1308
1309 2011-01-14  Eric Seidel  <eric@webkit.org>
1310
1311         Unreviewed.  Make it work in python 2.5.
1312
1313         webkit-patch suggest-reviewers dies when ChangeLogs are missing
1314         https://bugs.webkit.org/show_bug.cgi?id=49158
1315
1316         * Scripts/webkitpy/common/checkout/api_unittest.py:
1317
1318 2011-01-14  Sheriff Bot  <webkit.review.bot@gmail.com>
1319
1320         Unreviewed, rolling out r75774.
1321         http://trac.webkit.org/changeset/75774
1322         https://bugs.webkit.org/show_bug.cgi?id=52431
1323
1324         gtk builds were broken (Requested by loislo2 on #webkit).
1325
1326         * Scripts/webkitpy/common/checkout/scm.py:
1327
1328 2011-01-14  David Levin  <levin@chromium.org>
1329
1330         Reviewed by Shinichiro Hamaji.
1331
1332         check-webkit-style: _FunctionState should detect pure functions.
1333         https://bugs.webkit.org/show_bug.cgi?id=52428
1334
1335         * Scripts/webkitpy/style/checkers/cpp.py: Added detection for if a function declaration
1336         is a pure virtual function.
1337         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests for verifying that pure
1338         virtual functions are correctly detected.
1339
1340 2011-01-13  Ilya Tikhonovsky  <loislo@chromium.org>
1341
1342         Reviewed by Yury Semikhatsky.
1343
1344         Just small fix for problem with check-webkit-style.
1345         It just didn't work for this patch.
1346         Old code can't concatenate a list of strings with None.
1347
1348         * Scripts/webkitpy/common/checkout/scm.py:
1349
1350 2011-01-13  David Levin  <levin@chromium.org>
1351
1352         Reviewed by Shinichiro Hamaji.
1353
1354         check-webkit-style: _FunctionState should use Position to know where items are.
1355         https://bugs.webkit.org/show_bug.cgi?id=52424
1356
1357         * Scripts/webkitpy/style/checkers/cpp.py:
1358         (_FunctionState.*): Changed _FunctionState to use Position instead of line numbers.
1359         (detect_functions): Changed to pass Position's to _FunctionState.begin and
1360         did some minor clean-up.
1361         (*): Other changes are simply about converting to use the Position's in_FunctionState
1362         instead of line numbers.
1363         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Changed the test code
1364         to verify the positions stored in _FunctionState.
1365
1366 2011-01-13  Eric Seidel  <eric@webkit.org>
1367
1368         Reviewed by David Levin.
1369
1370         webkit-patch suggest-reviewers dies when ChangeLogs are missing
1371         https://bugs.webkit.org/show_bug.cgi?id=49158
1372
1373         This is not the most elegant, but it is a very safe fix to this bug.
1374         One advantage of catching ScriptError like this instead of adding a
1375         new added_or_modified_files or fixing all changed_files callers
1376         to use a more specific change_files variant, is that we catch
1377         all kinds of ScriptErrors which might cause our (non-essential)
1378         suggest-reviewers code to fail out.  This should make passing
1379         --suggest-reviewers to webkit-patch upload much more robust
1380         and may even make it possible for us to make it default.
1381
1382         The root of the problem here is that SCM.changed_files includes
1383         deleted ChangeLog paths (from moves, etc) which then when we ask
1384         SVN/Git for the contents of the file at that revision, the command
1385         errors out and Executive.run_command raises a ScriptError.
1386
1387         In the future we might fix this differently by making all current
1388         callers of chagned_files use a more specific method for requesting
1389         what types of changes they're interested in (adds, modifies, deletes, etc.)
1390
1391         * Scripts/webkitpy/common/checkout/api.py:
1392         * Scripts/webkitpy/common/checkout/api_unittest.py:
1393
1394 2011-01-13  Dan Bernstein  <mitz@apple.com>
1395
1396         Reviewed by Alexey Proskuryakov.
1397
1398         <rdar://problem/8827065> REGRESSION (r71884): Cross-origin XHR fails if willSendRequest changes the URL
1399         https://bugs.webkit.org/show_bug.cgi?id=52419
1400
1401         Allow to further control the behavior of the willSendRequest delegate callback by making it
1402         set a different URL in the new request.
1403
1404         * DumpRenderTree/LayoutTestController.cpp:
1405         (addURLToRedirectCallback): Added.
1406         (LayoutTestController::staticFunctions): Added addURLToRedirect.
1407         (LayoutTestController::addURLToRedirect): Added. Adds the redirection to the map.
1408         (LayoutTestController::redirectionDestinationForURL): Added this getter.
1409         * DumpRenderTree/LayoutTestController.h:
1410         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1411         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]): Check
1412         if there is a redirection for the request’s URL, established by addURLToRedirect(), and if so,
1413         change the URL in the new request to the redirect destination.
1414
1415 2011-01-13  Eric Seidel  <eric@webkit.org>
1416
1417         Reviewed by Mihai Parparita.
1418
1419         webkit-patch suggest-reviewers fails due to invalid utf8 in ChangeLog files
1420         https://bugs.webkit.org/show_bug.cgi?id=52416
1421
1422         Example: webkit-patch suggest-reviewers -g ca3890fe74d94d85d6bfa48f9ea497b094d8e717 
1423         UnicodeDecodeError: 'utf8' codec can't decode bytes in position 536-538: invalid data
1424
1425         I also added FIXMEs about the changed_files returning deleted files problem
1426         which is causing the other most common exception for suggest-reviewers
1427         (and is probably breaking sheriff-bots blame detection).
1428
1429         * Scripts/webkitpy/common/checkout/api.py:
1430         * Scripts/webkitpy/common/checkout/api_unittest.py:
1431         * Scripts/webkitpy/common/checkout/scm.py:
1432
1433 2011-01-13  Eric Seidel  <eric@webkit.org>
1434
1435         Reviewed by Adam Barth.
1436
1437         results archives from commit-queue are too large to upload
1438         https://bugs.webkit.org/show_bug.cgi?id=52405
1439
1440         * Scripts/webkitpy/common/system/filesystem.py:
1441         * Scripts/webkitpy/common/system/filesystem_mock.py:
1442         * Scripts/webkitpy/tool/commands/queues.py:
1443
1444 2011-01-13  Alejandro G. Castro  <alex@igalia.com>
1445
1446         Reviewed by Martin Robinson.
1447
1448         [gtk] Zero-sized font does not yet work
1449         https://bugs.webkit.org/show_bug.cgi?id=49793
1450
1451         Set minimum-font-size to 0 for the DRT.
1452
1453         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1454         (resetDefaultsToConsistentValues):
1455
1456 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
1457
1458         Reviewed by Darin Adler.
1459
1460         Make old-run-webkit-tests more robust on buildbots
1461         https://bugs.webkit.org/show_bug.cgi?id=52364
1462
1463         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Pass --exit-after-n-failures 500 to old-run-webkit-tests script.
1464
1465 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
1466
1467         Reviewed by Darin Adler.
1468
1469         Make old-run-webkit-tests more robust on buildbots
1470         https://bugs.webkit.org/show_bug.cgi?id=52364
1471
1472         * Scripts/old-run-webkit-tests: Ensure that testResultsDirectory is empty.
1473
1474 2011-01-13  Tony Chang  <tony@chromium.org>
1475
1476         Reviewed by Kent Tamura.
1477
1478         [chromium] fix plugins/plugin-javascript-access.html on Linux and Mac
1479         https://bugs.webkit.org/show_bug.cgi?id=52332
1480
1481         Forked Info.plist is not longer needed.
1482
1483         * DumpRenderTree/chromium/TestNetscapePlugIn/Info.plist: Removed.
1484
1485 2011-01-13  Mikhail Naganov  <mnaganov@chromium.org>
1486
1487         Reviewed by Timothy Hatcher.
1488
1489         Web Inspector: Cleanup after r75613 -- make all UI-facing strings
1490         to be passed directly to WebInspector.UIString
1491
1492         https://bugs.webkit.org/show_bug.cgi?id=52365
1493
1494         * Scripts/check-inspector-strings:
1495
1496 2011-01-13  Sheriff Bot  <webkit.review.bot@gmail.com>
1497
1498         Unreviewed, rolling out r74881.
1499         http://trac.webkit.org/changeset/74881
1500         https://bugs.webkit.org/show_bug.cgi?id=52357
1501
1502         The EFL builder has been red for days (Requested by abarth on
1503         #webkit).
1504
1505         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1506         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1507
1508 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
1509
1510         Reviewed by David Levin.
1511
1512         Add beforeunload support to WebKitTestRunner
1513         https://bugs.webkit.org/show_bug.cgi?id=52353
1514         
1515         This makes a number of currently failing tests pass.
1516
1517         * WebKitTestRunner/TestController.cpp:
1518         (WTR::runBeforeUnloadConfirmPanel):
1519         (WTR::createOtherPage):
1520         (WTR::TestController::initialize):
1521
1522 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
1523
1524         Reviewed by Sam Weinig.
1525
1526         Detect, identify and recover from WebProcess crashes in run-webkit-tests
1527         https://bugs.webkit.org/show_bug.cgi?id=52330
1528
1529         * Scripts/old-run-webkit-tests: Detect when the regression test tool reports
1530         a web process crash.
1531         * WebKitTestRunner/TestController.cpp:
1532         (WTR::TestController::initialize): Set up a processDidCrash
1533         callback.
1534         (WTR::TestController::processDidCrash): Report that the Web process
1535         crashed.
1536         * WebKitTestRunner/TestController.h:
1537
1538 2011-01-12  David Levin  <levin@chromium.org>
1539
1540         Reviewed by Shinichiro Hamaji.
1541
1542         check-webkit-style -- close_expression function doesn't work correctly.
1543         https://bugs.webkit.org/show_bug.cgi?id=52272
1544
1545         * Scripts/webkitpy/style/checkers/cpp.py:
1546         (Position.__str__): Added a way to convert it to a string which is useful in tests.
1547         (Position.__cmp__): Added a way to compare Position which is useful in tests and
1548         generally useful (for upcoming code changes).
1549         (close_expression): Changed to use Position for input and output.
1550         Also, fixed many bugs such as only working correctly for parenthesis,
1551         not working correctly if given an offset in a line and not finding
1552         the real closing element if there were multiple closing elements in
1553         the same line.
1554         (detect_functions): Adjusted due to the change in arguments for
1555         close_expression.
1556         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1557         (CppStyleTestBase.assert_positions_equal): Added a way to verify that
1558         two positions are the same.
1559         (CppStyleTest.test_position): Added tests for the __str_ and __cmp__ methods.
1560         (CppStyleTest.test_close_expression): Added tests to catch the issues
1561         that were fixed.
1562
1563 2011-01-12  Sheriff Bot  <webkit.review.bot@gmail.com>
1564
1565         Unreviewed, rolling out r75576.
1566         http://trac.webkit.org/changeset/75576
1567         https://bugs.webkit.org/show_bug.cgi?id=52304
1568
1569         broke rebaseline-chromium-webkit-test (Requested by thakis on
1570         #webkit).
1571
1572         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1573         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1574         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
1575         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1576         * Scripts/webkitpy/layout_tests/port/base.py:
1577         * Scripts/webkitpy/layout_tests/port/chromium.py:
1578         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1579         * Scripts/webkitpy/layout_tests/port/test.py:
1580         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1581         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1582         * Scripts/webkitpy/style/checkers/test_expectations.py:
1583         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1584
1585 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
1586
1587         Reviewed by Darin Adler.
1588
1589         Add a no-build option to run-webkit-tests, to avoid building DRT/WKTR
1590         https://bugs.webkit.org/show_bug.cgi?id=52307
1591
1592         * Scripts/old-run-webkit-tests:
1593
1594 2011-01-12  Koan-Sin Tan  <koansin.tan@gmail.com>
1595
1596         Reviewed by Martin Robinson.
1597
1598         [Gtk] WebKitGtk+ doesn't build on Mac OS X 10.6
1599         https://bugs.webkit.org/show_bug.cgi?id=50867
1600
1601         Fixed library extention for Mac in webkitdirs.pm and type conflict in
1602         TestNetscapePlugin.cpp 
1603
1604         * GNUmakefile.am: Don't use AppKit when compiling TestNetscapePlugin for GTK+
1605         * Scripts/webkitdirs.pm:
1606
1607 2011-01-12  Mikhail Naganov  <mnaganov@chromium.org>
1608
1609         Reviewed by Pavel Feldman.
1610
1611         Add check-inspector-strings script.
1612
1613         https://bugs.webkit.org/show_bug.cgi?id=52295
1614
1615         * Scripts/check-inspector-strings: Added.
1616
1617 2011-01-12  Adam Roben  <aroben@apple.com>
1618
1619         Advertise the .testnetscape file extension on Windows
1620
1621         Fixes <http://webkit.org/b/52298>
1622         plugins/no-mime-with-valid-extension.html fails on Windows
1623
1624         Reviewed by Dan Bernstein.
1625
1626         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Added a
1627         FileExtents field to map the .testnetscape file extension to the
1628         application/x-webkit-test-netscape MIME type, just as we do on Mac.
1629
1630 2011-01-12  Adam Barth  <abarth@webkit.org>
1631
1632         Reviewed by Eric Seidel.
1633
1634         Make webkit-patch support subdirectories for SVN checkouts
1635         https://bugs.webkit.org/show_bug.cgi?id=52261
1636
1637         os.relpath does not exist on Python 2.5, so we need to call our version
1638         of the API.
1639
1640         * Scripts/webkitpy/common/checkout/scm.py:
1641
1642 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
1643
1644         Reviewed by Eric Seidel.
1645
1646         Close additional pages opened during a test once the test completes.
1647         https://bugs.webkit.org/show_bug.cgi?id=52276
1648
1649         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1650         (WTR::InjectedBundle::done):
1651
1652 2011-01-11  David Levin  <levin@chromium.org>
1653
1654         Reviewed by Eric Seidel.
1655
1656         Errors should be separated from the command line in bot messages.
1657         https://bugs.webkit.org/show_bug.cgi?id=52275
1658
1659         * Scripts/webkitpy/common/system/executive.py:
1660         (ScriptError.message_with_output): Added a newline to separate the command
1661         line from the errors.
1662         * Scripts/webkitpy/common/system/executive_unittest.py:
1663         (ScriptErrorTest.test_message_with_output): Added tests for the various code
1664         paths in message_with_output.
1665
1666 2011-01-11  Eric Seidel  <eric@webkit.org>
1667
1668         Unreviewed.
1669
1670         commit-queue should know how to upload archived results (for test flakes or general failures)
1671         https://bugs.webkit.org/show_bug.cgi?id=52048
1672
1673         The zips are mostly empty due to forgetting -r.
1674         Expected diffs were not being pulled from the archive due
1675         to the archive having longer paths than I realized.
1676
1677         * Scripts/webkitpy/common/system/workspace.py:
1678         * Scripts/webkitpy/common/system/workspace_unittest.py:
1679         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1680         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1681
1682 2011-01-11  Dirk Pranke  <dpranke@chromium.org>
1683
1684         Reviewed by Ojan Vafai.
1685
1686         The current modifier parsing code in test_expectations is
1687         fragile and hard-coded, so it's not easy to understand the logic
1688         or easily add new types of modifiers (like GPU vs. CPU testing
1689         for graphics tests, or 32-bit vs. 64-bit differences).
1690
1691         This is the first of two patches that will add in more generic
1692         support and then eliminate the GPU-specific test expectations
1693         files for Chromium.
1694
1695         This patch adds two standalone objects for handling modifiers. The
1696         rules for interpreting modifiers, precedence, and conflicts are
1697         given in the docstring to the ModifierMatcher class, which
1698         returns ModifierMatchResult objects.
1699         
1700         This patch also adds routines to the Port interface and a
1701         default set of values in the base object, in order to obtain the
1702         values needed on a given test run. These values are then passed
1703         to the expectation parser. This also allows us to clean up the
1704         logic used to lint all of the different configurations in a
1705         single test_expectations.txt file.
1706
1707         The next patch will merge in the separate GPU expectations file.
1708
1709         https://bugs.webkit.org/show_bug.cgi?id=51222
1710
1711         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1712         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1713         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
1714         * Scripts/webkitpy/layout_tests/port/base.py:
1715         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1716         * Scripts/webkitpy/layout_tests/port/chromium.py:
1717         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1718         * Scripts/webkitpy/layout_tests/port/test.py:
1719         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1720         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1721
1722 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
1723
1724         Reviewed by Adam Barth.
1725
1726         Make webkit-patch support subdirectories for SVN checkouts
1727         https://bugs.webkit.org/show_bug.cgi?id=52261
1728
1729         * Scripts/webkitpy/common/checkout/scm.py:
1730         * Scripts/webkitpy/style_references.py:
1731         * Scripts/webkitpy/tool/main.py:
1732         * Scripts/webkitpy/tool/steps/preparechangelog.py:
1733
1734 2011-01-11  Eric Seidel  <eric@webkit.org>
1735
1736         Unreviewed.
1737
1738         commit-queue should know how to upload archived results (for test flakes or general failures)
1739         https://bugs.webkit.org/show_bug.cgi?id=52048
1740
1741         I changed the API for archive_last_layout_test_results w/o updating the implementation.  Oops.
1742         This fixes an exception seen on the commit-queue when attempting to report flaky tests.
1743
1744         * Scripts/webkitpy/common/system/workspace.py:
1745         * Scripts/webkitpy/common/system/workspace_unittest.py:
1746         * Scripts/webkitpy/tool/commands/queues.py:
1747
1748 2011-01-11  Sam Weinig  <sam@webkit.org>
1749
1750         Roll r75474 back in.
1751
1752 2011-01-11  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
1753
1754         Reviewed by Kenneth Rohde Christiansen.
1755
1756         [Qt] Remove uses of QFuture since it isn't supported on all platforms.
1757         https://bugs.webkit.org/show_bug.cgi?id=51204
1758
1759         * QtTestBrowser/webpage.h:
1760         (QtNAMThread::QtNAMThread):
1761         (QtNAMThread::networkAccessManager):
1762         (QtNAMThread::run):
1763
1764 2011-01-11  Peter Varga  <pvarga@webkit.org>
1765
1766         Unreviewed.
1767
1768         Add myself to committers' list.
1769
1770         * Scripts/webkitpy/common/config/committers.py:
1771
1772 2011-01-11  Eric Seidel  <eric@webkit.org>
1773
1774         Reviewed by Adam Barth.
1775
1776         commit-queue should know how to upload archived results (for test flakes or general failures)
1777         https://bugs.webkit.org/show_bug.cgi?id=52048
1778
1779         Now the queue will always upload results.  Either the entire zip, or just
1780         the diffs.txt in the case of text failures.
1781
1782         This should make understanding flakes much easier, and paves the way
1783         for having the EWS run layout tests (and upload failures).
1784
1785         In order to upload .zip files I had to teach bugzilla.py to autodetect
1786         mime types from the filename.  Since mimetypes.py doesn't include a mapping
1787         for .patch files, I have it add one before calling guess_type.
1788
1789         We may find that always uploading the whole zip instead of just the -diffs.txt
1790         file is preferable, but for now I'm keeping the old behavior because it makes
1791         quickly understanding text failures easy.
1792
1793         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1794         * Scripts/webkitpy/common/system/workspace.py: Added.
1795         * Scripts/webkitpy/common/system/workspace_unittest.py: Added.
1796         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1797         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1798         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1799         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1800         * Scripts/webkitpy/tool/commands/queues.py:
1801         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1802
1803 2011-01-10  Sheriff Bot  <webkit.review.bot@gmail.com>
1804
1805         Unreviewed, rolling out r75464.
1806         http://trac.webkit.org/changeset/75464
1807         https://bugs.webkit.org/show_bug.cgi?id=52193
1808
1809         Followup rollout for 75474 (Requested by Ossy on #webkit).
1810
1811         * MiniBrowser/mac/BrowserWindowController.m:
1812         (-[BrowserWindowController awakeFromNib]):
1813         * MiniBrowser/win/BrowserView.cpp:
1814         (BrowserView::create):
1815         * WebKitTestRunner/TestController.cpp:
1816         (WTR::createOtherPage):
1817         (WTR::TestController::initialize):
1818
1819 2011-01-10  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1820
1821         Reviewed by Csaba Osztrogonác.
1822
1823         [Qt] Baseline qt_minimal configuration
1824         https://bugs.webkit.org/show_bug.cgi?id=51313
1825
1826         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1827         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): Add
1828         QT_NO_UNDOSTACK guard.
1829
1830         * QtTestBrowser/launcherwindow.cpp:
1831         (LauncherWindow::createChrome): Add QT_NO_SHORTCUT and QT_NO_PRINTER
1832         guards.
1833         (LauncherWindow::applyZoom): Add QT_NO_ANIMATION guard.
1834         (LauncherWindow::screenshot): Add QT_NO_FILEDIALOG guard.
1835         (LauncherWindow::selectElements): Add QT_NO_INPUTDIALOG guard.
1836         (LauncherWindow::showUserAgentDialog): Add QT_NO_COMBOBOX guard.
1837
1838         * QtTestBrowser/launcherwindow.h:
1839         * QtTestBrowser/locationedit.cpp: Add QT_NO_INPUTDIALOG guard.
1840         * QtTestBrowser/locationedit.h: Ditto.
1841
1842         * QtTestBrowser/mainwindow.cpp:
1843         (MainWindow::buildUI): Add QT_NO_INPUTDIALOG, QT_NO_SHORTCUT and
1844         QT_NO_UNDOSTACK guards.
1845         (MainWindow::setAddressUrl): Add QT_NO_INPUTDIALOG guard.
1846         (MainWindow::changeLocation): Ditto.
1847         (MainWindow::openFile): Add QT_NO_FILEDIALOG guard.
1848         (MainWindow::openLocation): Add QT_NO_INPUTDIALOG guard.
1849
1850         * QtTestBrowser/webpage.cpp:
1851         (WebPage::openUrlInDefaultBrowser): Add QT_NO_DESKTOPSERVICES guard.
1852         (WebPage::authenticationRequired): Add QT_NO_LINEEDIT guard.
1853
1854         * QtTestBrowser/webview.cpp:
1855         (WebViewGraphicsBased::animatedFlip): Add QT_NO_ANIMATION guard.
1856         (WebViewGraphicsBased::animatedYFlip): Ditto.
1857
1858 2011-01-10  Sam Weinig  <sam@webkit.org>
1859
1860         Fix build.
1861
1862         * MiniBrowser/mac/BrowserWindowController.m:
1863         (-[BrowserWindowController awakeFromNib]):
1864         * MiniBrowser/win/BrowserView.cpp:
1865         (BrowserView::create):
1866         * WebKitTestRunner/TestController.cpp:
1867         (WTR::createOtherPage):
1868         (WTR::TestController::initialize):
1869
1870 2011-01-10  Eric Seidel  <eric@webkit.org>
1871
1872         Reviewed by Ojan Vafai.
1873
1874         style-queue messages are way too long for big patches
1875         https://bugs.webkit.org/show_bug.cgi?id=52161
1876
1877         We definitely could build much fancier list-to-string-with-limit functions
1878         but this should be sufficient for our needs at the moment.
1879
1880         * Scripts/webkitpy/common/system/executive.py:
1881         * Scripts/webkitpy/common/system/executive_unittest.py:
1882
1883 2011-01-10  Tony Chang  <tony@chromium.org>
1884
1885         Unreviewed, rolling out r75398.
1886         http://trac.webkit.org/changeset/75398
1887         https://bugs.webkit.org/show_bug.cgi?id=52008
1888
1889         Some layout tests are crashing on Chromium Win.
1890
1891         * DumpRenderTree/chromium/WebViewHost.cpp:
1892         (WebViewHost::updatePaintRect):
1893         * DumpRenderTree/chromium/WebViewHost.h:
1894
1895 2011-01-10  Adam Roben  <aroben@apple.com>
1896
1897         Roll out r75392
1898
1899         It isn't needed now that r75289 has been rolled out.
1900
1901         * Scripts/run-javascriptcore-tests:
1902
1903 2011-01-10  Maciej Stachowiak  <mjs@apple.com>
1904
1905         Reviewed by Anders Carlsson.
1906
1907         WebKitTestRunner uses crazy amounts of CPU, making layout tests slow and flaky
1908         https://bugs.webkit.org/show_bug.cgi?id=52160
1909
1910         * WebKitTestRunner/mac/TestControllerMac.mm:
1911         (WTR::TestController::platformRunUntil): Instead of busy-looping, wait for the timeout.
1912         Anything that can make runUntil() conditions turn true will happen on a run loop cycle
1913         anyway.
1914
1915 2011-01-10  Tony Chang  <tony@chromium.org>
1916
1917         Reviewed by Mihai Parparita.
1918
1919         [chromium] fix for animated gif layout tests
1920         https://bugs.webkit.org/show_bug.cgi?id=52008
1921
1922         * DumpRenderTree/chromium/WebViewHost.cpp: Schedule a paint when we update the paint rect
1923             to trigger gif animations.
1924         (WebViewHostPaintTask::WebViewHostPaintTask):
1925         (WebViewHostPaintTask::runIfValid):
1926         (WebViewHost::updatePaintRect):
1927         * DumpRenderTree/chromium/WebViewHost.h:
1928         (WebViewHost::taskList):
1929
1930 2011-01-10  Alejandro G. Castro  <alex@igalia.com>
1931
1932         Reviewed by Xan Lopez.
1933
1934         [GTK] Fix gtk2 compilation for master
1935         https://bugs.webkit.org/show_bug.cgi?id=51885
1936
1937         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
1938         (createBitmapContextFromWebView): Replaced the old
1939         gdk_drawable_get_size with gdk_pixmap_get_size.
1940
1941 2011-01-10  Patrick Gansterer  <paroga@webkit.org>
1942
1943         Reviewed by Laszlo Gombos.
1944
1945         [WINCE] Reenable NPAPI after r75203
1946         https://bugs.webkit.org/show_bug.cgi?id=52109
1947
1948         Remove the !isWinCE() check for ENABLE_NETSCAPE_PLUGIN_API and replace
1949         it with !isEfl(), because EFL port does not support NPAPI (yet).
1950
1951         * Scripts/build-webkit:
1952
1953 2011-01-10  Adam Roben  <aroben@apple.com>
1954
1955         Skip some asserting JS tests
1956
1957         See <http://webkit.org/b/52156>.
1958
1959         * Scripts/run-javascriptcore-tests:
1960
1961 2011-01-10  Martin Robinson  <mrobinson@igalia.com>
1962
1963         Reviewed by Xan Lopez.
1964
1965         [GTK] build-webkit disable Blob support via arguments passed to automake
1966         https://bugs.webkit.org/show_bug.cgi?id=52097
1967
1968         * Scripts/build-webkit: Enable Blob support when building WebKitGTK+ via
1969         build-webkit.
1970
1971 2011-01-10  Adam Roben  <aroben@apple.com>
1972
1973         Use the same name and description for TestNetscapePlugin on Windows and
1974         Mac
1975
1976         Fixes <http://webkit.org/b/52151>
1977         fast/frames/iframe-reparenting-plugins.html fails on Windows
1978
1979         Reviewed by Steve Falkenburg.
1980
1981         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Copied
1982         the name and description from Mac's Info.plist.
1983
1984 2011-01-10  Siddharth Mathur <siddharth.mathur@nokia.com>
1985
1986         Reviewed by Laszlo Gombos.
1987
1988         [Qt][WK2] Guard gcc-specific syntax
1989
1990         Non-gcc based compliers choke on the "-include"
1991         syntax for preinclude, place guard around it.
1992
1993         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1994         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1995
1996 2011-01-10  Andreas Kling  <kling@webkit.org>
1997
1998         Reviewed by Simon Hausmann.
1999
2000         [Qt] [WK2] MiniBrowser does not load pages opened in new windows
2001         https://bugs.webkit.org/show_bug.cgi?id=52111
2002
2003         When getting a createNewPage() callback from QWKPage, create the
2004         new page with the same QWKContext as the page that is passed to
2005         the callback.
2006
2007         * MiniBrowser/qt/BrowserView.h:
2008         * MiniBrowser/qt/BrowserWindow.cpp:
2009         (newPageFunction):
2010         (BrowserWindow::BrowserWindow):
2011         * MiniBrowser/qt/BrowserWindow.h:
2012
2013 2011-01-10  Andreas Kling  <kling@webkit.org>
2014
2015         Reviewed by Kenneth Rohde Christiansen.
2016
2017         [Qt] MiniBrowser: Remove superfluous createNewPage() callback
2018
2019         BrowserView set its own useless createNewPage() callback on QWKPage.
2020         This was immediately overridden by BrowserWindow anyway, so remove
2021         the BrowserView one.
2022
2023         * MiniBrowser/qt/BrowserView.cpp:
2024         (BrowserView::BrowserView):
2025
2026 2011-01-10  John Knottenbelt  <jknotten@chromium.org>
2027
2028         Reviewed by Jeremy Orlow.
2029
2030         [Chromium] Remove non-client-based Geolocation code
2031         https://bugs.webkit.org/show_bug.cgi?id=50921
2032
2033         * DumpRenderTree/chromium/LayoutTestController.cpp:
2034         (LayoutTestController::setGeolocationPermission):
2035         (LayoutTestController::setMockGeolocationPosition):
2036         (LayoutTestController::setMockGeolocationError):
2037         * DumpRenderTree/chromium/WebViewHost.cpp:
2038         (WebViewHost::geolocationClientMock):
2039         (WebViewHost::reset):
2040         * DumpRenderTree/chromium/WebViewHost.h:
2041
2042 2011-01-10  Eric Seidel  <eric@webkit.org>
2043
2044         Reviewed by Adam Barth.
2045
2046         Commit bot tried to land r? cq+ patch
2047         https://bugs.webkit.org/show_bug.cgi?id=36638
2048
2049         It should now be possible to post a patch with r? and cq+ and the
2050         commit-queue will correctly wait for the r+ before attempting to land the patch.
2051         (This was a feature requested by several users.)
2052
2053         One caveat: We don't actually reject r-, cq+ patches from the queue
2054         (we just ignore them), but I think that's OK for now.
2055
2056         I also noticed that setting r- once a commit-queue node had grabbed
2057         a patch would not properly cancel the landing.  That's fixed and
2058         tested in this patch.
2059
2060         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2061         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2062         * Scripts/webkitpy/tool/bot/feeders.py:
2063         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
2064
2065 2011-01-08  Benjamin Poulain  <benjamin.poulain@nokia.com>
2066
2067         Reviewed by Kenneth Rohde Christiansen.
2068
2069         [Qt] QtWebKit crashes when using XMLHttpRequest from the unload event
2070         https://bugs.webkit.org/show_bug.cgi?id=51934
2071
2072         When accessing the network from the destructor of QWebPage, the network access manager
2073         was already deleted because the object WebPage was already destructed.
2074
2075         This solve the problem by linking the lifetime of the network access manager to WebPage's QObject.
2076         The object is now destructed in the destructor of QObject.
2077
2078         * QtTestBrowser/webpage.cpp:
2079         (WebPage::WebPage):
2080         (WebPage::setQnamThreaded):
2081         * QtTestBrowser/webpage.h:
2082         (QtNAMThread::QtNAMThread):
2083
2084 2011-01-08  Eric Seidel  <eric@webkit.org>
2085
2086         Reviewed by Ojan Vafai.
2087
2088         test_failures.py should not mention TestShell (long live DumpRenderTree!)
2089         https://bugs.webkit.org/show_bug.cgi?id=52067
2090
2091         I ran test-webkitpy, but didn't bother adding a unit test for this string change.
2092         https://bugs.webkit.org/show_bug.cgi?id=51138#c3 is an example of why this is needed.
2093
2094         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
2095
2096 2011-01-08  Eric Seidel  <eric@webkit.org>
2097
2098         Reviewed by Mihai Parparita.
2099
2100         commit-queue hangs when the ChangeLog diff is bad
2101         https://bugs.webkit.org/show_bug.cgi?id=52072
2102
2103         * Scripts/webkitpy/tool/steps/validatechangelogs.py:
2104         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
2105
2106 2011-01-08  Adam Barth  <abarth@webkit.org>
2107
2108         Teach svn-apply how to re-write WebCore to Source/WebCore.
2109
2110         * Scripts/VCSUtils.pm:
2111
2112 2011-01-07  Adam Barth  <abarth@webkit.org>
2113
2114         Rubber-stamped by Eric Seidel.
2115
2116         Move WebCore to Source
2117         https://bugs.webkit.org/show_bug.cgi?id=52050
2118
2119         Update the tools to understand WebCore's new location.
2120
2121         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2122         * DumpRenderTree/wscript:
2123         * GNUmakefile.am:
2124         * Scripts/build-webkit:
2125         * Scripts/do-file-rename:
2126         * Scripts/do-webcore-rename:
2127         * Scripts/generate-qt-inspector-resource:
2128         * Scripts/prepare-ChangeLog:
2129         * Scripts/run-bindings-tests:
2130         * Scripts/update-iexploder-cssproperties:
2131         * Scripts/update-sources-list.py:
2132         * Scripts/update-webkit-localizable-strings:
2133         * Scripts/webkitdirs.pm:
2134         * Scripts/webkitpy/common/config/build.py:
2135         * Scripts/webkitpy/common/config/build_unittest.py:
2136         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
2137         * Scripts/webkitpy/style/checker.py:
2138         * Scripts/webkitpy/style/checker_unittest.py:
2139         * WebKitTestRunner/DerivedSources.pro:
2140         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2141         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh:
2142         * wx/browser/wscript:
2143         * wx/build/settings.py:
2144
2145 2011-01-07  Maciej Stachowiak  <mjs@apple.com>
2146
2147         Reviewed by Sam Weinig.
2148
2149         Make WebKitTestRunner rest between loads more robust to avoid test crashes
2150         https://bugs.webkit.org/show_bug.cgi?id=52086
2151
2152         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2153         (WTR::InjectedBundle::didReceiveMessage):
2154         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2155         (WTR::LayoutTestController::notifyDone):
2156         * WebKitTestRunner/TestController.cpp:
2157         (WTR::TestController::resetStateToConsistentValues):
2158         (WTR::TestController::run):
2159
2160 2011-01-07  James Robinson  <jamesr@chromium.org>
2161
2162         Revert "Implement mozilla's animationTime property"
2163         https://bugs.webkit.org/show_bug.cgi?id=51952
2164
2165         This approach isn't quite right.
2166
2167         * DumpRenderTree/chromium/WebViewHost.cpp:
2168         (WebViewHost::paintInvalidatedRegion):
2169
2170 2011-01-07  Adam Roben  <aroben@apple.com>
2171
2172         Build master fix
2173
2174         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2175         (RunWebKitTests.start): Don't try to concatenate a list and a string.
2176
2177 2011-01-07  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>
2178
2179         Reviewed by Csaba Osztrogonác.
2180
2181         run-qtwebkit-tests should be able to kill a testsuite.
2182
2183         Add new option in the script that can setup a timeout for a test.
2184         If the test execution takes more then specified time then the test
2185         would be terminated.
2186
2187         [Qt] run-qtwebkit-tests needs timeout
2188         https://bugs.webkit.org/show_bug.cgi?id=51894
2189
2190         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2191         * Scripts/run-qtwebkit-tests:
2192
2193 2011-01-07  Csaba Osztrogonác  <ossy@webkit.org>
2194
2195         Unreviewed fix after r75233.
2196
2197         Based on idea from Eric Seidel.
2198
2199         Add remote zip file handling to webkitpy.
2200         https://bugs.webkit.org/show_bug.cgi?id=50901
2201
2202         * Scripts/webkitpy/common/system/fileset.py: Make python 2.5 happy.
2203
2204 2011-01-07  Shane Stephens  <shanestephens@google.com>
2205
2206         Reviewed by Eric Seidel.
2207
2208         svn-apply: should support git binary delta diffs
2209         https://bugs.webkit.org/show_bug.cgi?id=38864
2210
2211         * Scripts/VCSUtils.pm:
2212         * Scripts/svn-apply:
2213
2214 2011-01-06  Julie Parent  <jparent@chromium.org>
2215
2216         Reviewed by Eric Seidel.
2217
2218         Test Result Server not removing old results.
2219         https://bugs.webkit.org/show_bug.cgi?id=52012
2220
2221         * TestResultServer/model/jsonresults.py:
2222         Fix off-by-one: Truncate if >= num_runs, not just >.
2223         * TestResultServer/model/jsonresults_unittest.py:
2224         Add unit test to test that merging in a new result with the same value
2225         as the last result causes previous result to fall off.
2226
2227 2011-01-06  James Kozianski  <koz@chromium.org>
2228
2229         Reviewed by Mihai Parparita.
2230
2231         Add classes to provide a consistent interface to a set of files.
2232         https://bugs.webkit.org/show_bug.cgi?id=50901
2233
2234         These classes allow us to write code that is agnostic to whether a
2235         particular set of files resides in a local directory or in a zip file
2236         on a remote machine.
2237
2238         * Scripts/webkitpy/common/system/directoryfileset.py: Added.
2239         * Scripts/webkitpy/common/system/directoryfileset_unittest.py: Added.
2240         * Scripts/webkitpy/common/system/fileset.py: Added.
2241         * Scripts/webkitpy/common/system/filesystem.py:
2242         * Scripts/webkitpy/common/system/filesystem_mock.py:
2243         * Scripts/webkitpy/common/system/zipfileset.py: Added.
2244         * Scripts/webkitpy/common/system/zipfileset_unittest.py: Added.
2245
2246 2011-01-06  Eric Seidel  <eric@webkit.org>
2247
2248         Reviewed by Adam Barth.
2249
2250         NetworkTransaction should log the url it is retrying
2251         https://bugs.webkit.org/show_bug.cgi?id=52043
2252
2253         * Scripts/webkitpy/common/net/networktransaction.py:
2254         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
2255
2256 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
2257
2258         Windows build fix.
2259         Import os before using it.
2260
2261         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2262
2263 2011-01-06  Eric Seidel  <eric@webkit.org>
2264
2265         Reviewed by Adam Barth.
2266
2267         StyleQueue fails to report errors when patches have many files
2268         https://bugs.webkit.org/show_bug.cgi?id=52042
2269
2270         This is one of at least two errors preventing style error reporting at the moment.
2271         When we moved to passing the list of files to check explicitly,
2272         we started to exceed the 500 character TEXT field limit for our AppEngine model object.
2273         We could change the type of the QueueStatus.message type, or we could
2274         just teach statusserver.py how to clamp values (and warn when it does).
2275         I chose the latter path.
2276
2277         * Scripts/webkitpy/common/net/statusserver.py:
2278
2279 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
2280
2281         Reviewed by Stephanie Lewis.
2282         
2283         Fix syntax error in script.
2284
2285         Windows bots need to archive/unarchive builds to/from configuration-specific directories
2286         https://bugs.webkit.org/show_bug.cgi?id=51996
2287
2288         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2289
2290 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2291
2292         Unreviewed, fixing WinCE build after r75196.
2293
2294         WinCE port does not (yet) support NPAPI.
2295
2296         * Scripts/build-webkit:
2297
2298 2011-01-06  Xan Lopez  <xlopez@igalia.com>
2299
2300         Reviewed by Darin Adler.
2301
2302         File::Spec->rel2abs in sunspider-compare-results mangles parameters
2303         https://bugs.webkit.org/show_bug.cgi?id=52015
2304
2305         * Scripts/sunspider-compare-results: call rel2abs on our arguments
2306         after the platform has been detected, otherwise the script will
2307         mangle things like '--gtk' into '/a/path/--gtk', breaking the
2308         detection.
2309
2310 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2311
2312         Reviewed by Eric Seidel.
2313
2314         Add ENABLE_NETSCAPE_PLUGIN_API, ENABLE_ORIENTATION_EVENTS and ENABLE_TOUCH_EVENTS flags to build-webkit
2315         https://bugs.webkit.org/show_bug.cgi?id=51346
2316
2317         * Scripts/build-webkit:
2318
2319 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
2320
2321         Reviewed by Adam Roben.
2322
2323         Windows bots need to archive/unarchive builds to/from configuration-specific directories
2324         https://bugs.webkit.org/show_bug.cgi?id=51996
2325         
2326         After the configuration directory change, we were archiving the incorrect directory for
2327         build product, so we were running tests on the wrong binaries.
2328         
2329         This change archives the correct directory, and also unarchives it into a configuration-
2330         specific directory.
2331
2332         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Use a configuration-specific directory on Windows.
2333         * BuildSlaveSupport/built-product-archive: Unarchive/archive to/from proper directory.
2334
2335 2011-01-06  Eric Seidel  <eric@webkit.org>
2336
2337         Reviewed by Mihai Parparita.
2338
2339         commit-queue mentions "Text diff mismatch" 4 times instead of once per failure
2340         https://bugs.webkit.org/show_bug.cgi?id=52002
2341
2342         See an example of this here:
2343         https://bugs.webkit.org/show_bug.cgi?id=51314#c2
2344
2345         It's due to the fact that we pass around TestFailure() instance
2346         objects and yet expect them to all compare to be the same.
2347
2348         This is bad.  We should either have shared instances of these values
2349         or we should just pass around the class names.  There are already hacks
2350         in place to make TestFailure objects pass equality tests, I just added
2351         a __hash__ implementation so they can be used in sets as expected.
2352
2353         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2354         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
2355
2356 2011-01-06  Evan Martin  <evan@chromium.org>
2357
2358         Reviewed by Tony Chang.
2359
2360         [gdb] handle inaccessible memory and UChar*
2361         https://bugs.webkit.org/show_bug.cgi?id=52003
2362
2363         To pretty-print a UChar*, we just grope around in the memory
2364         looking for a terminating NUL.  We need to handle the exception
2365         that can occur when we poke into an invalid location.
2366
2367         Additionally, the logic for choosing which pretty-printer would
2368         early return before hitting the point where we'd use the UChar*
2369         printer.  (Did this ever work?  How did it regress?)
2370
2371         * gdb/webkit.py:
2372
2373 2011-01-05  Brian Weinstein  <bweinstein@apple.com>
2374
2375         Reviewed by Ada Chan.
2376
2377         WebKit2: Should be able to call into injected bundle to ask if we should allow resource loads
2378         https://bugs.webkit.org/show_bug.cgi?id=51969
2379         
2380         Add shouldLoadResourceForFrame to WTR::InjectedBundlePage.
2381
2382         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2383         (WTR::InjectedBundlePage::InjectedBundlePage):
2384         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Stub implementation.
2385         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2386
2387 2011-01-06  James Robinson  <jamesr@chromium.org>
2388
2389         Reviewed by Simon Fraser.
2390
2391         Implement mozilla's animationTime property
2392         https://bugs.webkit.org/show_bug.cgi?id=51952
2393
2394         Chromium DRT support for webkitAnimationTime.
2395
2396         * DumpRenderTree/chromium/WebViewHost.cpp:
2397         (WebViewHost::paintInvalidatedRegion):
2398
2399 2011-01-06  Julie Parent  <jparent@chromium.org>
2400
2401         Reviewed by Tony Chang.
2402
2403         Test Result Server always truncates number of results to JSON_RESULTS_MAX_BUILDS
2404         https://bugs.webkit.org/show_bug.cgi?id=51217
2405
2406         * TestResultServer/model/jsonresults.py:
2407         Pass num_runs through to _remove_items_over_max_number_of_builds, and use the value.
2408         Adds missing documentation.
2409         * TestResultServer/model/jsonresults_unittest.py:
2410         Add unit test to test that truncation happens at smaller value than JSON_RESULTS_MAX_BUILDS.
2411         Update test_merge to take a number of builds to truncate at.
2412
2413 2011-01-06  Adam Barth  <abarth@webkit.org>
2414
2415         Reviewed by Eric Seidel.
2416
2417         The EWS should log outside of the working directory
2418         https://bugs.webkit.org/show_bug.cgi?id=51986
2419
2420         This patch prepare us for using git clean -x -d -f in the EWS wrapper
2421         script, which will actually clean the working copy back to a pristine
2422         state instead of leaving untracked directories and ignored files.
2423
2424         * Scripts/webkitpy/tool/commands/queues.py:
2425         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2426
2427 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
2428
2429         Windows build fix.
2430         Back out attempted change to built-product-archive.
2431
2432         * BuildSlaveSupport/built-product-archive:
2433
2434 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
2435
2436         Windows build fix.
2437         Include configuration name when unpacking a build archive.
2438
2439         Needed, since we split Windows build results into configuration-specific directories
2440         under WebKitOutputDir.
2441
2442         * BuildSlaveSupport/built-product-archive:
2443
2444 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
2445
2446         Reviewed by Darin Adler.
2447
2448         Debug and Release builds on Windows clobber each other
2449         https://bugs.webkit.org/show_bug.cgi?id=49185
2450
2451         Changes the structure of WebKitBuild build products directory so we
2452         completely separate each build configuration into independent directories.
2453         
2454         Although we previously had per-configuration directories for obj, this change adds
2455         per-configuration directories for bin, lib, obj, and include. Each configuration's
2456         build products are stored within a directory inside of WebKitBuild.
2457         
2458         Most use of $(WebKitOutputDir) in the build files has been replaced by $(ConfigurationBuildDir),
2459         defined in common.vsprops to be $(WebKitOutputDir)\$(ConfigurationName).
2460
2461         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops:
2462         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd:
2463         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd:
2464         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
2465         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd:
2466         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd:
2467         * DumpRenderTree/win/ImageDiffCommon.vsprops:
2468         * DumpRenderTree/win/ImageDiffPostBuild.cmd:
2469         * DumpRenderTree/win/ImageDiffPreBuild.cmd:
2470         * FindSafari/FindSafari.vcproj:
2471         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
2472         * MiniBrowser/MiniBrowserPostBuild.cmd:
2473         * MiniBrowser/MiniBrowserPreBuild.cmd:
2474         * Scripts/webkitdirs.pm:
2475         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
2476         * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops:
2477         * TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd:
2478         * TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd:
2479         * TestWebKitAPI/win/copy-resources.cmd:
2480         * WebKitAPITest/WebKitAPITestCommon.vsprops:
2481         * WebKitAPITest/WebKitAPITestPostBuild.cmd:
2482         * WebKitAPITest/WebKitAPITestPreBuild.cmd:
2483         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
2484         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
2485         * WebKitTestRunner/win/InjectedBundle.vcproj:
2486         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops:
2487         * WebKitTestRunner/win/InjectedBundlePostBuild.cmd:
2488         * WebKitTestRunner/win/InjectedBundlePreBuild.cmd:
2489         * WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd:
2490         * WebKitTestRunner/win/WebKitTestRunnerPreBuild.cmd:
2491         * WinLauncher/WinLauncherCommon.vsprops:
2492         * WinLauncher/WinLauncherPostBuild.cmd:
2493         * WinLauncher/WinLauncherPreBuild.cmd:
2494
2495 2011-01-05  Jan Erik Hanssen  <jhanssen@sencha.com>
2496
2497         Reviewed by Ariya Hidayat.
2498
2499         [Qt] TestNetscapePlugin doesn't link on OS X
2500         https://bugs.webkit.org/show_bug.cgi?id=51948
2501
2502         Only add a dependency on libX11 on X11 systems
2503
2504         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2505
2506 2011-01-05  Jeff Miller  <jeffm@apple.com>
2507
2508         Reviewed by Adam Roben.
2509
2510         check-webkit-style should allow unnecessary parameter names in WebKit2 APIs because we're matching CF's header style
2511         https://bugs.webkit.org/show_bug.cgi?id=51970
2512
2513         * Scripts/webkitpy/style/checker.py:
2514         Add -readability/naming for WebKit2 C API directories.
2515
2516 2011-01-05  Eric Seidel  <eric@webkit.org>
2517
2518         Unreviewed, just fixing one more log error from my previous python patch.
2519
2520         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
2521         https://bugs.webkit.org/show_bug.cgi?id=51802
2522
2523         webkit-patch failure-reason was logging about parsing errors
2524         due to my misunderstanding of how BeautifulSoup.findAll worked.
2525
2526         Fixed, and added a unit test.
2527
2528         * Scripts/webkitpy/common/net/layouttestresults.py:
2529         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2530
2531 2011-01-05  Benjamin Poulain  <benjamin.poulain@nokia.com>
2532
2533         Reviewed by Kenneth Rohde Christiansen.
2534
2535         [Qt] [WK2] Add the possibility to open window from the WebProcess in Minibrowser
2536         https://bugs.webkit.org/show_bug.cgi?id=51951
2537
2538         Set a function to QWKPage::setCreateNewPageFunction() in Minibrowser so there is a way
2539         to create new window from WebKit.
2540
2541         * MiniBrowser/qt/BrowserWindow.cpp:
2542         (newPageFunction):
2543         (BrowserWindow::BrowserWindow):
2544         (BrowserWindow::page): Added to avoid the indirect access to QWKPage spread in the class
2545         (BrowserWindow::newWindow):
2546         (BrowserWindow::updateUserAgentList):
2547         (BrowserWindow::showUserAgentDialog):
2548         * MiniBrowser/qt/BrowserWindow.h: Add the global variable backingStoreTypeForNewWindow to
2549         define the type of the backing store used for new windows.
2550         * MiniBrowser/qt/main.cpp:
2551         (main):
2552
2553 2011-01-05  Eric Seidel  <eric@webkit.org>
2554
2555         Reviewed by Ojan Vafai.
2556
2557         commit-queue should report failure type when reporting flaky tests
2558         https://bugs.webkit.org/show_bug.cgi?id=51900
2559
2560         This patch was a ridiculous amount of plumbing.  In the end I like
2561         the NRWT-style TestResult class even less.  But now we're passing
2562         a list of TestResult objects from the queue to the FlakyTestReporter.
2563         Thus the FlakyTestReporter can more easily report what type of failure
2564         occurred.
2565
2566         In the process, I found that I was not alone in finding TestResult
2567         cumbersome to use.  A bunch of code was trying to create a TestResult
2568         object with default values.  However since the constructor didn't make
2569         this easy, some places were getting it wrong (including the TestResult unit test)!
2570         I've fixed the TestResult constructor to have default values for non-essential
2571         arguments.
2572
2573         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2574         * Scripts/webkitpy/common/net/layouttestresults.py:
2575         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2576         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2577         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2578         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2579         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
2580         * Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py:
2581         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2582         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2583         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2584         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2585         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2586         * Scripts/webkitpy/tool/commands/queues.py:
2587         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2588
2589 2011-01-05  Eric Seidel  <eric@webkit.org>
2590
2591         Unreviewed.
2592
2593         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
2594         https://bugs.webkit.org/show_bug.cgi?id=51802
2595
2596         Add another unit test to cover a previously missing import.
2597
2598         * Scripts/webkitpy/common/net/layouttestresults.py:
2599         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2600
2601 2011-01-05  Mihai Parparita  <mihaip@chromium.org>
2602
2603         Reviewed by David Levin.
2604
2605         Add mihaip@chromium.org as a reviewer
2606         https://bugs.webkit.org/show_bug.cgi?id=51966
2607         
2608         Add myself as a reviewer.
2609
2610         * Scripts/webkitpy/common/config/committers.py:
2611
2612 2011-01-05  James Simonsen  <simonjam@chromium.org>
2613
2614         Unreviewed. Adding myself to the list of committers.
2615
2616         * Scripts/webkitpy/common/config/committers.py:
2617
2618 2011-01-05  Eric Seidel  <eric@webkit.org>
2619
2620         Unreviewed.
2621
2622         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
2623         https://bugs.webkit.org/show_bug.cgi?id=51802
2624
2625         Fix two exceptions seen on the bots after my original commit.
2626
2627         * Scripts/webkitpy/common/net/layouttestresults.py:
2628         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2629
2630 2011-01-05  Kundu Suchismita  <suchi.kundu@nokia.com>
2631
2632         Reviewed by Andreas Kling.
2633
2634         [Qt]Add local storage settings to QtTestBrowser command line arguments 
2635         https://bugs.webkit.org/show_bug.cgi?id=51750
2636
2637         * QtTestBrowser/main.cpp:
2638         (LauncherApplication::handleUserOptions):
2639          Local storage settings can be enable form command line arguments for
2640          QtTestBrowser.
2641
2642 2011-01-05  Chris Fleizach  <cfleizach@apple.com>
2643
2644         Reviewed by Martin Robinson.
2645
2646         GTK: AX: DRT needs to use correct root object method.
2647         https://bugs.webkit.org/show_bug.cgi?id=51911
2648
2649         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
2650         (AccessibilityController::rootElement):
2651
2652 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
2653
2654         Rubber-stamped by Csaba Osztrogonác.
2655
2656         Based on idea from Péter Gál.
2657
2658         * Scripts/webkitpy/tool/bot/sheriff.py: Remove unnecessary apostrophes around revision numbers.
2659
2660 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
2661
2662         Reviewed by Adam Barth.
2663
2664         sheriff-bot should be able to do multi-revision rollouts
2665         https://bugs.webkit.org/show_bug.cgi?id=51176
2666
2667         * Scripts/webkitpy/tool/bot/irc_command.py:
2668         * Scripts/webkitpy/tool/bot/sheriff.py:
2669         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
2670
2671 2011-01-05  Eric Seidel  <eric@webkit.org>
2672
2673         Reviewed by Adam Barth.
2674
2675         queues.webkit.org should have per-bot status pages
2676         https://bugs.webkit.org/show_bug.cgi?id=51906
2677
2678         Just adds a /queue-status/QUEUE_NAME/bots/BOT_ID page to show
2679         statuses from a single queue.  Now that we have many bots servicing
2680         some queues (commit-queue, win-ews, etc.) its easy to have the messages
2681         you care about scroll off the end of the 15-message limit on the main page.
2682
2683         Eventually we should probably rename /queue-status to /queue or /queues,
2684         but that's fodder for another patch.
2685
2686         * QueueStatusServer/handlers/queuestatus.py:
2687         * QueueStatusServer/index.yaml:
2688         * QueueStatusServer/main.py:
2689         * QueueStatusServer/templates/includes/singlequeuestatus.html:
2690          - This probably should use a custom filter instead of hard-coding
2691            the URL scheme here, but I couldn't figure out how to easily
2692            create such a filter.  Most filters work with "strings" so we can't
2693            pass the status object.  We could add a method to the status
2694            object and call that, but that seemed a bit strange too.
2695         * QueueStatusServer/templates/queuestatus.html:
2696
2697 2011-01-05  Carlos Garcia Campos  <cgarcia@igalia.com>
2698
2699         Unreviewed. Adding myself to the list of committers.
2700
2701         * Scripts/webkitpy/common/config/committers.py:
2702
2703 2011-01-04  Koan-Sin Tan  <koansin.tan@gmail.com>
2704
2705         Reviewed by David Levin.
2706
2707         check-webkit-style treated some macros with parentheses after #elif as function calls
2708         https://bugs.webkit.org/show_bug.cgi?id=51695
2709
2710         Ingore function call space checking in any preprocessor directives
2711         (things starting with #). Change search() to match() because 
2712         preprocessor directives are supposed to be in the beginning of lines.
2713
2714         * Scripts/webkitpy/style/checkers/cpp.py:
2715         * Scripts/webkitpy/style/checkers/cpp_unittest.py: make sure there is no false positives for #elif cases
2716
2717 2011-01-04  Søren Gjesse  <sgjesse@chromium.org>
2718
2719         Reviewed by Tony Chang.
2720
2721         Change the --multi-load test option to --stress-opt
2722         https://bugs.webkit.org/show_bug.cgi?id=50751
2723
2724         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2725         (runTest):
2726         (main):
2727         * DumpRenderTree/chromium/TestShell.cpp:
2728         (TestShell::TestShell):
2729         * DumpRenderTree/chromium/TestShell.h:
2730         (TestShell::stressOpt):
2731         (TestShell::setStressOpt):
2732         (TestShell::stressDeopt):
2733         (TestShell::setStressDeopt):
2734         (TestShell::javaScriptFlags):
2735         (TestShell::setJavaScriptFlags):
2736         * Scripts/webkitpy/layout_tests/port/chromium.py:
2737         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2738
2739 2011-01-04  Chris Fleizach  <cfleizach@apple.com>
2740
2741         Reviewed by Sam Weinig.
2742
2743         WK2: Support Accessibility
2744         https://bugs.webkit.org/show_bug.cgi?id=51859
2745
2746         Use rootObject() method to get top of accessibility tree.
2747
2748         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
2749         (AccessibilityController::focusedElement):
2750         (AccessibilityController::rootElement):
2751
2752 2011-01-03  Martin Robinson  <mrobinson@igalia.com>
2753
2754         Reviewed by Darin Adler.
2755
2756         Remove the last non-GObject usage of PlatformRefPtr and move the code to GRefPtr
2757         https://bugs.webkit.org/show_bug.cgi?id=51846
2758
2759         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: Change usage of PlatformRefPtr
2760         back to GRefPtr.
2761
2762 2011-01-04  Zhe Su  <suzhe@chromium.org>
2763
2764         Reviewed by Kenneth Russell.
2765
2766         Fix insertText, setMarkedText and unmarkText methods of
2767         TextInputController to call corresponding methods of WebKit::WebView
2768         rather than WebKit::WebFrame. This change matches the behavior of
2769         chromium browser.
2770         insertText corresponds to WebView::confirmComposition(text)
2771         setMarkedText corresponds to WebView::setComposition(...)
2772         unmarkText corresponds to WebView::confirmComposition()
2773         https://bugs.webkit.org/show_bug.cgi?id=51693
2774
2775         * DumpRenderTree/chromium/TextInputController.cpp:
2776         (TextInputController::insertText):
2777         (TextInputController::setMarkedText):
2778         (TextInputController::unmarkText):
2779
2780 2011-01-04  Dihan Wickremasuriya  <dihan.wickremasuriya@nokia.com>
2781
2782         Reviewed by Laszlo Gombos.
2783
2784         [Qt] [Symbian] Do not remove 0 byte sized files from productDir
2785
2786         On Symbian productDir points to the source directory. Removing all the
2787         empty files from the productDir directory corrupts the svn repository.
2788
2789         * Scripts/build-webkit:
2790
2791 2011-01-03  Yi Shen  <yi.4.shen@nokia.com>
2792
2793         Reviewed by Adam Barth.
2794
2795         [Qt] Add SelectAll option to the context menu for the editor
2796         https://bugs.webkit.org/show_bug.cgi?id=50049
2797
2798         Set shortcut for the SelectAll action.
2799
2800         * QtTestBrowser/mainwindow.cpp:
2801         (MainWindow::buildUI):
2802
2803 2011-01-03  David Levin  <levin@chromium.org>
2804
2805         Reviewed by Eric Seidel.
2806
2807         check-webkit-style shouldn't consider "value" automatically to be a meaningless name.
2808         https://bugs.webkit.org/show_bug.cgi?id=51842
2809
2810         * Scripts/webkitpy/style/checkers/cpp.py: Remove the check for value.
2811         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Remove the test for value.
2812
2813 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
2814
2815         Reviewed by David Kilzer.
2816
2817         [WINCE] Adds a build slave.
2818         https://bugs.webkit.org/show_bug.cgi?id=50523
2819
2820         * BuildSlaveSupport/build.webkit.org-config/config.json: Add an
2821         entry for a release build of the WinCE port.
2822         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add platform
2823         flag to build the WinCE port.
2824
2825 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
2826
2827         Reviewed by David Kilzer.
2828
2829         Add WinCE support to build-webkit
2830         https://bugs.webkit.org/show_bug.cgi?id=51642
2831
2832         * Scripts/build-webkit:
2833         * Scripts/webkitdirs.pm:
2834
2835 2011-01-03  Eric Seidel  <eric@webkit.org>
2836
2837         Reviewed by Adam Barth.
2838
2839         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
2840         https://bugs.webkit.org/show_bug.cgi?id=51802
2841
2842         I'm not the biggest fan of the test_failures or test_results classes,
2843         but it's better to have one shared set of classes, than separate ones
2844         for new vs. old run-webkit-test result handling.
2845
2846         This moves the ORWT results class "LayoutTestResults" over to using
2847         TestResult and TestFailure classes, making it easy for us to
2848         make all our sheriff-bot and other webkitpy code NRWT ready.
2849
2850         This also makes it a trivial patch to generate results.json information
2851         from ORWT results.html files (for flaky test analysis, etc.) as well
2852         as making it a one-liner to report test failure types when the
2853         commit-queue sees flaky tests.
2854
2855         This patch tried not to add new functionality, but only to replace
2856         the guts of LayoutTestResults, while adding unit tests and hoping
2857         not to break anything.
2858
2859         I also moved callers which assumed User.prompt* were static/class methods
2860         to using them as instance methods (since we'll eventually want to make them such).
2861
2862         In the process of re-writing things, I broke the rebaseline command, so I wrote
2863         a unit test to catch my breakage were I do do so again in the future.
2864
2865         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2866         * Scripts/webkitpy/common/net/layouttestresults.py:
2867         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2868         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
2869         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
2870         * Scripts/webkitpy/tool/commands/queries.py:
2871         * Scripts/webkitpy/tool/commands/rebaseline.py:
2872         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2873         * Scripts/webkitpy/tool/mocktool.py:
2874
2875 2011-01-03  Adam Barth  <abarth@webkit.org>
2876
2877         Reviewed by Simon Fraser.
2878
2879         webkit-patch shouldn't waste time cleaning a working directory that's already clean
2880         https://bugs.webkit.org/show_bug.cgi?id=51840
2881
2882         * Scripts/webkitpy/common/checkout/scm.py:
2883
2884 2011-01-03  Adam Barth  <abarth@webkit.org>
2885
2886         Reviewed by Simon Fraser.
2887
2888         webkit-patch should only hide update output if --quiet
2889         https://bugs.webkit.org/show_bug.cgi?id=51838
2890
2891         As requested by smfr.
2892
2893         * Scripts/webkitpy/tool/steps/update.py:
2894
2895 2011-01-03  Adam Barth  <abarth@webkit.org>
2896
2897         Reviewed by David Levin.
2898
2899         commit-queue shouldn't reject patches twice if two bots process the same patch
2900         https://bugs.webkit.org/show_bug.cgi?id=51805
2901
2902         Before raising an error, we first check whether the patch is still in
2903         the commit-queue.  This check is still racy, of course, but the time
2904         window is much smaller.
2905
2906         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2907
2908 2011-01-03  Sam Weinig  <sam@webkit.org>
2909
2910         Reviewed by Anders Carlsson.
2911
2912         Make run-api-tests less chatty.
2913         https://bugs.webkit.org/show_bug.cgi?id=51831
2914
2915         - Make script quiet by default and add --verbose option (replacing --quiet).
2916         - When not verbose, pipe stdout and stderr to devnull.
2917
2918         * Scripts/run-api-tests:
2919
2920 2011-01-03  Pratik Solanki  <psolanki@apple.com>
2921
2922         Unreviewed. Adding myself to committers.py.
2923
2924         * Scripts/webkitpy/common/config/committers.py:
2925
2926 2011-01-03  Koan-Sin Tan  <koansin.tan@gmail.com>
2927
2928         Reviewed by Xan Lopez.
2929
2930         "Tool/Scripts/run-launcher --gtk" stopped working after 74855
2931         https://bugs.webkit.org/show_bug.cgi?id=51806
2932
2933         Originally, the $libraryName is 'JavaScriptCore'. When building release 
2934         one, the $libraryDir was 'WebKitBuild/Release/JavaScriptCore/../.libs/'
2935         which doesn't exist anymore ('WebKitBuild/Release/JavaScriptCore'
2936         is 'WebKitBuild/Release/Source/JavaScriptCore' now), and 
2937         'WebKitBuild/Release/Source/JavaScriptCore/../../.libs' looks weird,
2938         so make it 'WebKitBuild/Release/.libs'
2939
2940         * Scripts/webkitdirs.pm: 
2941
2942 2011-01-02  Patrick Gansterer  <paroga@webkit.org>
2943
2944         Reviewed by Adam Barth.
2945
2946         Make EFL a core builder
2947         https://bugs.webkit.org/show_bug.cgi?id=51804
2948
2949         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2950         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2951
2952 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
2953
2954         [Qt] Unreviewed fix after r74855 and r74875.
2955
2956         * BuildSlaveSupport/built-product-archive:
2957          - Create directories explicitly.
2958          - Pass shell=True to subprocess.call().
2959
2960 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
2961
2962         [Qt] Unreviewed fix after r74855.
2963
2964         Move JavaScriptCore to Source
2965         https://bugs.webkit.org/show_bug.cgi?id=51604
2966
2967         * BuildSlaveSupport/built-product-archive: JavaScriptCore -> Source/JavaScriptCore
2968
2969 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
2970
2971         [Qt] Unreviewed run-javasriptcore-tests fix after r74855.
2972
2973         Move JavaScriptCore to Source
2974         https://bugs.webkit.org/show_bug.cgi?id=51604
2975
2976         * Scripts/webkitdirs.pm:
2977
2978 2011-01-02  Robert Hogan  <robert@webkit.org>
2979
2980         Unreviewed, build fix.
2981
2982         [Qt] Fix DRT build after 74855
2983
2984         * DumpRenderTree/qt/DumpRenderTree.pro:
2985
2986 2011-01-01  Adam Barth  <abarth@webkit.org>
2987
2988         Remove the assumption from the Qt and Gtk builds that every project is
2989         in the root directory.
2990
2991         * Scripts/build-webkit:
2992
2993 2011-01-01  Adam Barth  <abarth@webkit.org>
2994
2995         Reviewed by Eric Seidel.
2996
2997         Teach svn-apply how to apply patches even though JavaScriptCore has moved
2998         https://bugs.webkit.org/show_bug.cgi?id=51796
2999
3000         After this change, svn-apply will magically apply patches to
3001         JavaScriptCore/foo to Source/JavaScriptCore/foo.
3002
3003         * Scripts/VCSUtils.pm:
3004
3005 2011-01-01  Adam Barth  <abarth@webkit.org>
3006
3007         Reviewed by Eric Seidel.
3008
3009         Move JavaScriptCore to Source
3010         https://bugs.webkit.org/show_bug.cgi?id=51604
3011
3012         Update references to JavaScriptCore to point to the new location.
3013
3014         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3015         * DumpRenderTree/qt/DumpRenderTree.pro:
3016         * DumpRenderTree/qt/ImageDiff.pro:
3017         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3018         * DumpRenderTree/wscript:
3019         * Scripts/build-jsc:
3020         * Scripts/build-webkit:
3021         * Scripts/do-file-rename:
3022         * Scripts/do-webcore-rename:
3023         * Scripts/run-javascriptcore-tests:
3024         * Scripts/update-javascriptcore-test-results:
3025         * Scripts/webkitdirs.pm:
3026         * Scripts/webkitpy/common/config/build_unittest.py:
3027         * Scripts/webkitpy/style/checker.py:
3028         * Scripts/webkitpy/style/checker_unittest.py:
3029         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3030         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3031         * WebKitTestRunner/qt/WebKitTestRunner.pro:
3032         * wx/build/settings.py:
3033
3034 2011-01-01  Adam Barth  <abarth@webkit.org>
3035
3036         Reviewed by Eric Seidel.
3037
3038         Move Sources to Source
3039         https://bugs.webkit.org/show_bug.cgi?id=51794
3040
3041         Update scripts to point to the new location.
3042
3043         * Scripts/build-webkit:
3044         * Scripts/do-file-rename:
3045         * Scripts/do-webcore-rename:
3046         * Scripts/webkitpy/common/config/build.py:
3047         * Scripts/webkitpy/common/config/build_unittest.py:
3048
3049 2010-12-31  Kent Tamura  <tkent@chromium.org>
3050
3051         Reviewed by Eric Seidel.
3052
3053         [DRT/Chromium] Enable mock spell checker on non-OSX
3054         https://bugs.webkit.org/show_bug.cgi?id=51401
3055
3056         * DumpRenderTree/chromium/WebViewHost.cpp:
3057         (WebViewHost::spellCheck):
3058
3059 2010-12-31  Adam Barth  <abarth@webkit.org>
3060
3061         Reviewed by Ariya Hidayat.
3062
3063         Remove Tools/Scripts/wkstyle
3064         https://bugs.webkit.org/show_bug.cgi?id=51774
3065
3066         This script appears to not have been touched in a while and seems to
3067         have been replaced by check-webkit-style.
3068
3069         * Scripts/wkstyle: Removed.
3070
3071 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
3072
3073         Unreviewed. Coding style fix.
3074
3075         * DumpRenderTree/chromium/TestShell.h:
3076
3077 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
3078
3079         Reviewed by Pavel Feldman.
3080
3081         Web Inspector: [Chromium] Inspector's tests are very slow on Win(Dbg).
3082
3083         It was a problem with Chromium DRT. DevToolsAgent object instance was
3084         attached not only to the inspected page but to the DevTools window too.
3085         As result all the inspector files were interpreted as a content of inspected page
3086         and were transfered to the DevTools scripts panel for debugging etc.
3087
3088         https://bugs.webkit.org/show_bug.cgi?id=51735
3089
3090         * DumpRenderTree/chromium/TestShell.cpp:
3091         (TestShell::TestShell):
3092         (TestShell::bindJSObjectsToWindow):
3093         (TestShell::createNewWindow):
3094         * DumpRenderTree/chromium/TestShell.h:
3095
3096 2010-12-31  Adam Barth  <abarth@webkit.org>
3097
3098         Rubber-stamped by Eric Seidel.
3099
3100         Move PageLoadTests to PerformanceTests/PageLoad
3101         https://bugs.webkit.org/show_bug.cgi?id=51771
3102
3103         Update references to PageLoadTests to point to the new location.
3104
3105         * Scripts/run-pageloadtest:
3106         * Scripts/webkitpy/common/config/build.py:
3107
3108 2010-12-31  Adam Barth  <abarth@webkit.org>
3109
3110         Rubber-stamped by Eric Seidel.
3111
3112         Move SunSpider into PerformanceTests
3113         https://bugs.webkit.org/show_bug.cgi?id=51769
3114
3115         Update these scripts to point to the new location.
3116
3117         * Scripts/run-sunspider:
3118         * Scripts/sunspider-compare-results:
3119
3120 2010-12-30  Mihai Parparita  <mihaip@chromium.org>
3121
3122         Reviewed by Kent Tamura.
3123
3124         [Chromium] Add WebThemeEngineDRTMac so that Chromium DRT scrollbar rendering can match the Mac port's
3125         https://bugs.webkit.org/show_bug.cgi?id=51728
3126         
3127         Add implementation of the Mac WebThemeEngine that uses an NSScroller
3128         to render top-level scrollbars. This makes them match the Mac port's
3129         use of an NSScrollView, which means that we'll be able to share more
3130         pixel baselines.
3131         
3132         The new rendering code will not be activated until the 
3133         USE_WEB_THEME_ENGINE_TO_PAINT_THUMB #define is fliped in
3134         ScrollbarThemeChromiumMac.
3135
3136         * DumpRenderTree/DumpRenderTree.gypi:
3137         * DumpRenderTree/chromium/TestShellMac.mm:
3138         (platformInit):
3139         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Added.
3140         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Added.
3141         (+[FakeActiveWindow alwaysActiveWindow]):
3142         (+[FakeActiveWindow alwaysInactiveWindow]):
3143         (-[FakeActiveWindow initWithActiveControls:]):
3144         (-[FakeActiveWindow _hasActiveControls]):
3145         (WebThemeEngineDRTMac::paintScrollbarThumb):
3146         (stateToHIEnableState):
3147         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
3148         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
3149
3150 2010-12-30  Konstantin Tokarev  <annulen@yandex.ru>
3151
3152         Reviewed by David Kilzer.
3153
3154         [Qt] Don't build wtf/TCSystemAlloc.cpp if --system-malloc option is
3155         used
3156         https://bugs.webkit.org/show_bug.cgi?id=51672
3157
3158         * DumpRenderTree/qt/DumpRenderTree.pro: Replaced USE_SYSTEM_MALLOC
3159         with USE_SYSTEM_MALLOC=1
3160         * WebKitTestRunner/qt/WebKitTestRunner.pro: Replaced USE_SYSTEM_MALLOC
3161         with USE_SYSTEM_MALLOC=1
3162
3163 2010-12-30  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3164
3165         Reviewed by David Kilzer.
3166
3167         [Qt] [Symbian] Fix build-webkit script for Symbian
3168         https://bugs.webkit.org/show_bug.cgi?id=51509
3169
3170         Set the OUTPUT_DIR for Symbian to be the same as the source
3171         directory.
3172
3173         * Scripts/webkitdirs.pm:
3174
3175 2010-12-30  Martin Robinson  <mrobinson@igalia.com>
3176
3177         Reviewed by Darin Adler.
3178
3179         check-webkit-style should ignore NULL usage in calls to gtk_widget_style_get
3180         https://bugs.webkit.org/show_bug.cgi?id=51758
3181
3182         Add a check-webkit-style exception for gtk_widget_style_get and NULL usage.
3183
3184         * Scripts/webkitpy/style/checkers/cpp.py: Add the exception.
3185         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Add some tests for this.
3186
3187 2010-12-29  Patrick Gansterer  <paroga@webkit.org>
3188
3189         Unreviewed WinCE buildfix.
3190
3191         * WinCELauncher/main.cpp: Add missing include.
3192
3193 2010-12-29  Daniel Bates  <dbates@rim.com>
3194
3195         Reviewed by Darin Adler.
3196
3197         svn-apply updates date of wrong change log entry for a change log diff that
3198         contains two consecutive entries with the same author and date
3199         https://bugs.webkit.org/show_bug.cgi?id=46061
3200
3201         Fixes an issue where the date of the wrong change log entry may be modified.
3202         Moreover, changes fixChangeLogPatch() to move entries inserted earlier
3203         in a ChangeLog file to the top of the file.
3204
3205         Currently, fixChangeLogPatch() explicitly bails out and returns an unchanged
3206         diff when it detects that the diff inserts a change log entry earlier in a
3207         ChangeLog. It is unusual to land a patch that has such a deliberate ChangeLog
3208         change. With the advent of the commit-queue this functionality of bailing out
3209         and hence landing the patch as-is is harmful to the accuracy of the ChangeLog.
3210         Instead, we should always move the change log entry to the top of the ChangeLog file.
3211
3212         A side-effect of this change is that setChangeLogDateAndReviewer() now updates
3213         the date line of the correct change log entry in a ChangeLog diff.
3214
3215         * Scripts/VCSUtils.pm: Modified fixChangeLogPatch() to move entries inserted earlier to the top.
3216
3217         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
3218           Updated the following unit tests now that we move entries inserted earlier to the top:
3219           - "fixChangeLogPatch: New entry inserted in middle."
3220             (formerly named "fixChangeLogPatch: [no change] New entry inserted in middle.")
3221
3222           - "fixChangeLogPatch: New entry inserted earlier in the file, but after an entry with the same author and date."
3223             (formerly named "fixChangeLogPatch: [no change] New entry inserted earlier in the file, but after an entry with the same author and date.")
3224
3225         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatchThenSetChangeLogDateAndReviewer.pl: Added.
3226
3227 2010-12-29  Konstantin Tokarev  <annulen@yandex.ru>
3228
3229         Reviewed by Eric Seidel.
3230
3231         [Qt] Fixed compatibility with gold linker on X11 platforms
3232         https://bugs.webkit.org/show_bug.cgi?id=51700
3233
3234         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3235         Linked TestNetscapePlugin with libX11 on Unix platforms
3236
3237 2010-12-29  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>
3238
3239         Reviewed by Darin Adler.
3240
3241         Circular dependency in webkitpy.common.checkout.changelog module
3242         https://bugs.webkit.org/show_bug.cgi?id=50475
3243
3244         Remove automatic import of api.Checkout module when any checkout/
3245         submodule is imported (e.g.: when checkout.scm.Git is imported).
3246
3247         * Scripts/webkitpy/common/checkout/__init__.py:
3248
3249 2010-12-29  Martin Robinson  <mrobinson@igalia.com>
3250
3251         Reviewed by Ojan Vafai.
3252
3253         prepare-ChangeLog should support the -g option for specifying the git-commit
3254         https://bugs.webkit.org/show_bug.cgi?id=51708
3255
3256         Add a -g shortcut for the --git-commit prepare-ChangeLog option. This matches
3257         webkit-patch, though the exact meaning of the two options remain different.
3258
3259         * Scripts/prepare-ChangeLog: Add -g.
3260
3261 2010-12-29  Kent Hansen  <kent.hansen@nokia.com>
3262
3263         Reviewed by Simon Hausmann.
3264
3265         [Qt] Fix compilation with Qt in namespace
3266         https://bugs.webkit.org/show_bug.cgi?id=51701
3267
3268         * QtTestBrowser/webview.h:
3269
3270 2010-12-28  Daniel Bates  <dbates@rim.com>
3271
3272         Reviewed by Sam Weinig.
3273
3274         Substitute // MARK: for compiler-specific #pragma mark
3275         https://bugs.webkit.org/show_bug.cgi?id=51657
3276
3277         Fix future compilation warnings about "#pragma mark" on GTK+ bots by
3278         substituting  "// MARK:" for "#pragma mark", which provides
3279         analogous code-bookmarking functionality under Xcode.
3280
3281         Also, for consistency, we should substitute "// MARK:" for compiler-
3282         specific "#pragma mark" in the source files for the Mac port.
3283
3284         * DumpRenderTree/AccessibilityTextMarker.cpp:
3285         * DumpRenderTree/cf/WebArchiveDumpSupport.h:
3286         * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm:
3287         * DumpRenderTree/mac/ObjCController.m:
3288         * MiniBrowser/mac/AppDelegate.m:
3289         * MiniBrowser/mac/BrowserWindowController.m:
3290
3291 2010-12-28  Xan Lopez  <xlopez@igalia.com>
3292
3293         Reviewed by Eric Seidel.
3294
3295         Add --no-build option to run-sunspider
3296         https://bugs.webkit.org/show_bug.cgi?id=51658
3297
3298         * Scripts/run-sunspider: add --no-build flag to skip building
3299         phase.
3300
3301 2010-12-27  Daniel Bates  <dbates@rim.com>
3302
3303         Rubber-stamped by Martin Robinson.
3304
3305         Append the directory Tools/DumpRenderTree to the list of directories that
3306         do-webcore-rename should search so that it can rename DRT files and
3307         source code.
3308
3309         * Scripts/do-webcore-rename:
3310
3311 2010-12-27  Eric Seidel  <eric@webkit.org>
3312
3313         Reviewed by Adam Barth.
3314
3315         build-webkit should detect missing Java SDK and explain how to install it
3316         https://bugs.webkit.org/show_bug.cgi?id=51651
3317
3318         * Scripts/build-webkit:
3319
3320 2010-12-26  Martin Robinson  <mrobinson@igalia.com>
3321
3322         Reviewed by Daniel Bates.
3323
3324         [GTK] Add support for build-jsc
3325         https://bugs.webkit.org/show_bug.cgi?id=51625
3326
3327         Add GTK+ support to build-jsc now that building the jsc executable as
3328         a standalone target is easy.
3329
3330         * Scripts/build-jsc: Call buildGtkProject for the GTK+ case now.
3331         * Scripts/build-webkit: Pass in the proper target name to buildGtkProject.
3332         * Scripts/webkitdirs.pm: Actually process the project parameter in buildGtkProject
3333         and pass it along to buildAutotoolsProject.
3334
3335 2010-12-27  David Levin  <levin@chromium.org>
3336
3337         Reviewed by Eric Seidel.
3338
3339         check-webkit-style check for meaningless variable names in function declarations.
3340         https://bugs.webkit.org/show_bug.cgi?id=51523
3341
3342         * Scripts/webkitpy/style/checker.py: Exempted JavaScriptCore/jit/JITStubs.cpp
3343         from the new check and whitespace/parens because the syntax is unusual and
3344         produced a fair number of positives for these checks.
3345         * Scripts/webkitpy/style/checkers/cpp.py:
3346         (_convert_to_lower_with_underscores): Used as a canonical form for type names
3347         and parameter names when determining if the parameter name is useless.
3348         (_create_acronym): Used to check for redundant variable names in cases like "ExceptionCode ec"
3349         (Parameter.lower_with_underscores_name): Gives back the parameter name in a lower_with_underscore
3350         format.
3351         (_check_parameter_name_against_text):  Checks to see if the parameter name is in the
3352         text or an acronym of it.
3353         (check_function_definition): Checks function definitions for meaningless variable names.
3354         (process_line): Added call to check_function_definition.
3355         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3356         (CppFunctionsTest.test_convert_to_lower_with_underscores): Test for _convert_to_lower_with_underscores.
3357         (CppFunctionsTest.test_create_acronym): Test for _create_acronym.
3358         (CppFunctionsTest.test_check_parameter_against_text): Test for _check_parameter_against_text.
3359         (CppStyleTestBase.perform_single_line_lint): Removed the parameter name check
3360         because when only checking a snippet, there are a lot of bogus functions.
3361         (CppStyleTestBase.perform_multi_line_lint): Ditto and removed a bogus filter
3362         that I put there previously and just noticed.
3363         (WebKitStyleTest.test_parameter_names): Tests for the functionality -- both
3364         check_function_definition and process_line.
3365
3366 2010-12-27  Carlos Garcia Campos  <cgarcia@igalia.com>
3367
3368         Reviewed by Martin Robinson.
3369
3370         [GTK] Disable flash plugin in GtkLauncher when using gtk3
3371         https://bugs.webkit.org/show_bug.cgi?id=51591
3372
3373         Flash plugin uses gtk2 that is incompatible with gtk3 making
3374         webkit crash when it's built with gtk3.
3375
3376         * GtkLauncher/main.c:
3377         (main):
3378
3379 2010-12-25  Adam Barth  <abarth@webkit.org>
3380
3381         Reviewed by Eric Seidel.
3382
3383         Move ANGLE to Sources/ThirdParty
3384         https://bugs.webkit.org/show_bug.cgi?id=51605
3385
3386         * Scripts/build-webkit:
3387           - Point to the new ANGLE location.
3388
3389 2010-12-26  David Levin  <levin@chromium.org>
3390
3391         Reviewed by Eric Seidel.
3392
3393         check-webkit-style should be able to parse function declaration parameters.
3394         https://bugs.webkit.org/show_bug.cgi?id=51451
3395
3396         * Scripts/webkitpy/style/checkers/cpp.py:
3397         (Position.__init__): Holds simple position information (row, column).
3398         (Parameter.__init__): Holds information about a parameter.
3399         (SingleLineView.__init): Converts multiple lines into a single line for simpler searches.
3400         (SingleLineView.convert_column_to_row): Returns the original row given a column.
3401         (create_skeleton_parameters): Simplifies a parameter list for easier searching.
3402         (find_parameter_name_index): Finds where the parameter name is.
3403         (parameter_list): Generates the list of parameters for a function.
3404         (_FunctionState.begin): Added information to allow determining the parameters
3405         on demand.
3406         (_FunctionState.get_parameter_list): Returns a tuple of function parameters.
3407         (detect_functions): Improve function detection for operator functions and
3408         determine where the parameters end and pass that to _FunctionState.begin.
3409         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3410         (CppFunctionsTest.test_parameter): Verifies Parameter functionality.
3411         (CppFunctionsTest.test_single_line_view): Verifies SingleLineView functionality.
3412         (CppFunctionsTest.test_create_skeleton_parameters): Verifies create_skeleton_parameters.
3413         (CppFunctionsTest.test_find_parameter_name_index): Verifies find_parameter_name_index.
3414         (CppFunctionsTest.test_parameter_list): Does some minimal verification for parameter list.
3415         Much more thorough verification is done as part of FunctionDetectionTest.test_parameter_list.
3416         (FunctionDetectionTest.perform_function_detection): Added support for verifying
3417         the parameters found.
3418         (FunctionDetectionTest.test_function_declaration_detection): Added more function
3419         detection test to verify that we catch the operator functions.
3420         (FunctionDetectionTest.test_ignore_macros): Verify that function detection ignores macros.
3421         (FunctionDetectionTest.test_parameter_list): Added tests to verify the parameter parsing.
3422         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_bad_test_doesnt_break): Removed
3423         because the error. The test is about the bad function name. Fixing the name makes the test exactly like
3424         test_function_length_check_definition_severity1_for_test.
3425
3426 2010-12-25  Patrick Gansterer  <paroga@webkit.org>
3427
3428         Unreviewed WinCE buildfix after r74334.
3429
3430         * CMakeListsWinCE.txt:
3431
3432 2010-12-24  Sheriff Bot  <webkit.review.bot@gmail.com>
3433
3434         Unreviewed, rolling out r74632.
3435         http://trac.webkit.org/changeset/74632
3436         https://bugs.webkit.org/show_bug.cgi?id=51600
3437
3438         makes test-webkitpy hang forever on GTK (Requested by philn-tp
3439         on #webkit).
3440
3441         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
3442         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
3443
3444 2010-12-24  Ryuan Choi  <ryuan.choi@samsung.com>
3445
3446         Reviewed by Kenneth Rohde Christiansen.
3447
3448         [EFL] Screen doesn't be rendered when changing size of EWebLauncher
3449         https://bugs.webkit.org/show_bug.cgi?id=43528
3450
3451         Remove on_resize because ewk_view_fixed_layout_size_set should not be
3452         called on callback of EVAS_CALLBACK_RESIZE. As it change size of
3453         FrameView, rendering was ignored when _ewk_view_smart_calculate was
3454         called.
3455
3456         * EWebLauncher/main.c:
3457         (browserCreate):
3458
3459 2010-12-24  Eric Seidel  <eric@webkit.org>
3460
3461         Reviewed by Adam Barth.
3462
3463         webkit-patch (or a pre-commit hook) needs to prevent bad ChangeLog changes
3464         https://bugs.webkit.org/show_bug.cgi?id=28291
3465
3466         This is a start.  At least now webkit-patch will prompt when your ChangeLog looks questionable.
3467         We could do more advanced things, like parsing the ChangeLog (with changelog.py) and comparing that
3468         to strings with find in the diff.
3469         Since non-interactive always returns the default, this should cause patches with bad changelogs to fail on the commit-queue.
3470
3471         * Scripts/webkitpy/common/checkout/api.py:
3472         * Scripts/webkitpy/common/checkout/diff_parser.py:
3473         * Scripts/webkitpy/tool/steps/abstractstep.py:
3474         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
3475         * Scripts/webkitpy/tool/steps/validatechangelogs.py: Copied from Tools/Scripts/webkitpy/tool/steps/validatereviewer.py.
3476         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py: Copied from Tools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.
3477         * Scripts/webkitpy/tool/steps/validatereviewer.py:
3478
3479 2010-12-24  Dirk Pranke  <dpranke@chromium.org>
3480
3481         Reviewed by Kenneth Russell.
3482
3483         Modify new-run-webkit-tests to shut up and exit when all the threads
3484         are wedged so that test runs complete faster and we don't end up
3485         w/ enormous log files.
3486
3487         https://bugs.webkit.org/show_bug.cgi?id=51572
3488
3489         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
3490         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
3491
3492 2010-12-24  Eric Seidel  <eric@webkit.org>
3493
3494         Reviewed by David Levin.
3495
3496         commit-queue should better explain how it will re-open bugs and follow duplicate chains
3497         https://bugs.webkit.org/show_bug.cgi?id=51549
3498
3499         I've had multiple people ask me about the commit-queue's behavior
3500         regarding reporting flaky tests.  I figured it would be best to just
3501         have the queue explain itself in the bugs it files.
3502
3503         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3504         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3505
3506 2010-12-24  Shinichiro Hamaji  <hamaji@chromium.org>
3507
3508         Reviewed by Eric Seidel.
3509
3510         check-webkit-style: should ignore "wrong" namings in JavaScriptCore/qt
3511         https://bugs.webkit.org/show_bug.cgi?id=51467
3512
3513         * Scripts/webkitpy/style/checker.py:
3514         * Scripts/webkitpy/style/checker_unittest.py:
3515
3516 2010-12-23  Adam Barth  <abarth@webkit.org>
3517
3518         Rubber-stamped by Eric Seidel.
3519
3520         Move JavaScriptGlue into Sources
3521         https://bugs.webkit.org/show_bug.cgi?id=51583
3522
3523         These tools refer to JavaScriptGlue and need to be updated to its new
3524         location.
3525
3526         * Scripts/build-webkit:
3527         * Scripts/do-file-rename:
3528         * Scripts/do-webcore-rename:
3529         * Scripts/webkitpy/common/config/build.py:
3530         * Scripts/webkitpy/common/config/build_unittest.py:
3531
3532 2010-12-23  Lucas Forschler  <lforschler@apple.com>
3533
3534         Reviewed by Eric Seidel.
3535
3536         Bug 51539 - update iexploder scripts to point to new location
3537
3538         * Scripts/run-iexploder-tests:
3539         * Scripts/update-iexploder-cssproperties:
3540
3541 2010-12-23  Evan Martin  <evan@chromium.org>
3542
3543         Reviewed by Ryosuke Niwa.
3544
3545         [chromium] LayoutTestController warning in float->int conversion
3546         https://bugs.webkit.org/show_bug.cgi?id=51553
3547
3548         Rather than reading an int, converting to a float, then getting a compiler
3549         warning on passing the float to something that expects an int, instead
3550         just pass around ints.
3551
3552         No tests, fixes a compiler warning.
3553
3554         * DumpRenderTree/chromium/LayoutTestController.cpp:
3555         (parsePageSizeParameters):
3556         (LayoutTestController::pageNumberForElementById):
3557         (LayoutTestController::numberOfPages):
3558
3559 2010-12-23  Lucas Forschler  <lforschler@apple.com>
3560
3561         Reviewed by Darin Adler.
3562
3563         Bug 51537 - iexploder needs cleanup
3564         
3565         * iExploder/htdocs: Removed.
3566         * iExploder/htdocs/config.rb: Removed.
3567         * iExploder/htdocs/cssproperties.in: Removed.
3568         * iExploder/htdocs/cssvalues.in: Removed.
3569         * iExploder/htdocs/htmlattrs.in: Removed.
3570         * iExploder/htdocs/htmltags.in: Removed.
3571         * iExploder/htdocs/htmlvalues.in: Removed.
3572         * iExploder/htdocs/iexploder.cgi: Removed.
3573         * iExploder/htdocs/iexploder.rb: Removed.
3574         * iExploder/htdocs/index.html: Removed.
3575         * iExploder/htdocs/webserver.rb: Removed.
3576         * iExploder/iexploder-1.7.2/output: Removed.
3577         * iExploder/tools: Removed.
3578         * iExploder/tools/lasthit.rb: Removed.
3579         * iExploder/tools/osx_last_crash.rb: Removed.
3580         * iExploder/tools/showtest.rb: Removed.
3581
3582 2010-12-23  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
3583
3584         Reviewed by Kenneth Rohde Christiansen.
3585
3586         [EFL] Make 'single' the default backing store in EWebLauncher
3587         https://bugs.webkit.org/show_bug.cgi?id=51534
3588
3589         'single' is the simplest backing store and the one intended to be the
3590         default in the test browser. By mistake the tiled backing store was
3591         left as default in r72617.
3592
3593         * EWebLauncher/main.c:
3594         (browserCreate): ditto.
3595
3596 2010-12-23  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
3597
3598         Reviewed by Kenneth Rohde Christiansen.
3599
3600         [EFL] Subject: [webkit 4/4] [EFL] Remove non-sense workaround
3601         https://bugs.webkit.org/show_bug.cgi?id=51533
3602
3603         There's no point in concatenating env("HOME") with "blah", so remove
3604         option from EWebLauncher.
3605
3606         * EWebLauncher/main.c:
3607         (main): ditto.
3608
3609 2010-12-23  Ilya Tikhonovsky  <loislo@chromium.org>
3610
3611         Reviewed by Eric Seidel.
3612
3613         Web Inspector: chromium: inspector's tests are quite slow especially at windows(Debug).
3614
3615         Almost all inspector's tests become flaky on chromium Win(dbg) after switching to DRT.
3616         I just discovered that we have two additional GC runs per each WebViewHost.
3617         Test_shell had no such calls.
3618         These gc runs eat 15% of cpu time.
3619
3620         https://bugs.webkit.org/show_bug.cgi?id=51479
3621
3622         * DumpRenderTree/chromium/WebViewHost.cpp:
3623         (WebViewHost::~WebViewHost):
3624
3625 2010-12-22  Dirk Pranke  <dpranke@chromium.org>
3626
3627         Reviewed by Ojan Vafai.
3628
3629         This change splits out the TestRunner class into its own file.
3630         When we fork the code for message passing, we will create a new
3631         TestRunner, and this change will allow that to be more modular.
3632
3633         While we're at it, split out TestInput and ResultSummary into
3634         their own files, to reduce the size of run_webkit_tests to
3635         something more managable.
3636
3637         https://bugs.webkit.org/show_bug.cgi?id=51092
3638
3639         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
3640         * Scripts/webkitpy/layout_tests/layout_package/result_summary.py:
3641         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
3642         * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
3643         * Scripts/webkitpy/layout_tests/layout_package/test_input.py:
3644         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3645         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3646
3647  2010-12-22  Dirk Pranke  <dpranke@chromium.org>
3648
3649         Reviewed by Ojan Vafai.
3650
3651         nrwt multiprocessing - start over, prepare to fork the code
3652  
3653         This code cleans up the signatures and implementation of the
3654         TestRunner class so we can easily fork it to run either the
3655         stable implementation or the new, unstable message-passing
3656         implementation. The two variants will have different
3657         implementations of the run_tests() method. We will switch
3658         between the two based on the setting for the '--worker-model'
3659         switch. We rename the two currently valid values to 'old-inline'
3660         and 'old-threads'.
3661
3662         https://bugs.webkit.org/show_bug.cgi?id=51081
3663
3664         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3665         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3666
3667 2010-12-22  Victor Wang  <victorw@chromium.org>
3668
3669         Reviewed by Darin Fisher.
3670
3671         [Chromium] Update chromium archive test result url in rebaseline script.
3672
3673         https://bugs.webkit.org/show_bug.cgi?id=51503
3674
3675         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
3676
3677 2010-12-22  Lucas Forschler  <lforschler@apple.com>
3678
3679         Reviewed by Alice Liu.
3680
3681         <rdar://problem/8633222> record-memory-win needs to record memory used by the webprocess.
3682         Verified on Chrome, Safari, and IE.
3683         With this change, we will record memory from a parent browser window and all child processes.
3684
3685         * record-memory-win/main.cpp:
3686         (ProcessArgs):
3687         (PrintUsage):
3688         (getMemoryInfo):
3689         (printProcessInfo):
3690         (evalProcesses):
3691         (UseImage):
3692         (QueryContinuously):
3693         (ElapsedTime):
3694
3695 2010-12-22  Lucas Forschler  <lforschler@apple.com>
3696
3697         Unreviewed rollout r74489, because it was missing changelog.
3698
3699         * record-memory-win/main.cpp:
3700         
3701 2010-12-22  Ryosuke Niwa  <rniwa@webkit.org>
3702
3703         Adding myself as a reviewer.
3704
3705         * Scripts/webkitpy/common/config/committers.py:
3706
3707 2010-12-22  Andrew Scherkus  <scherkus@chromium.org>
3708
3709         Unreviewed.  Adding myself to committers.py.
3710
3711         * Scripts/webkitpy/common/config/committers.py:
3712
3713 2010-12-22  Ariya Hidayat  <ariya@sencha.com>
3714
3715         Reviewed by Kenneth Rohde Christiansen.
3716
3717         TestNetscapePlugIn should use #if defined
3718         https://bugs.webkit.org/show_bug.cgi?id=51471
3719
3720         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3721         (NP_Initialize):
3722         (NPP_New):
3723
3724 2010-12-22  Ilya Tikhonovsky  <loislo@chromium.org>
3725
3726         Reviewed by Yury Semikhatsky.
3727
3728         Web Inspector: [chromium] DRT inspector layout tests are flaky in debug.
3729
3730         DevTools window should be closed explicitly because it has custom deinitialization code.
3731
3732         https://bugs.webkit.org/show_bug.cgi?id=50722
3733
3734         * DumpRenderTree/chromium/TestShell.cpp:
3735         (TestShell::closeRemainingWindows):
3736
3737 2010-12-22  David Levin  <levin@chromium.org>
3738
3739         Reviewed by Shinichiro Hamaji.
3740
3741         check-webkit-style shouldn't complaint about underscores in variables in objective C files.
3742         https://bugs.webkit.org/show_bug.cgi?id=51452
3743
3744         * Scripts/webkitpy/style/checkers/cpp.py:
3745         (_FileState.__init__): Added the information to determine if a file is C or Objective C.
3746         Using the file extension if possible but falling back to the file contents if we have a header file.
3747         (_FileState.is_objective_c): Determine if we have an Objective C by examining the file contents if needed.
3748         (_FileState.is_c_or_objective_c):
3749         (check_using_std): Changed to using _FileState to determine the file type.
3750         (check_max_min_macros): Ditto.
3751         (check_for_null): Ditto.
3752         (check_style): Changed the parameters to various calls since they now need _FileState
3753         to determine the file type.
3754         (check_language): Added the file_state parameter so it could be passed
3755         to check_identifier_name_in_declaration.
3756         (check_identifier_name_in_declaration): Don't warn about underscores in variables if
3757         this is an Objective C file.
3758         (_process_lines): Added information for the _FileState constructor (and moved the
3759         call to a place that had the information).
3760         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3761         (CppFunctionsTest.test_is_c_or_objective_c): Changed the tests to use FileState and exercise
3762         its functionality.
3763         (WebKitStyleTest.test_names): Add tests for underscores in Objective C files.
3764
3765 2010-12-21  Andy Estes  <aestes@apple.com>
3766
3767         Reviewed by Mark Rowe.
3768
3769         Do not build non-Intel architectures for WebKit2-related projects.
3770         https://bugs.webkit.org/show_bug.cgi?id=51440
3771
3772         * MiniBrowser/Configurations/Base.xcconfig: Only build for i386 and x86_64.
3773         * TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
3774         * WebKitTestRunner/Configurations/Base.xcconfig: Ditto.
3775
3776 2010-12-21  Mihai Parparita  <mihaip@chromium.org>
3777
3778         Reviewed by Darin Fisher.
3779
3780         [Chromium] Rename WebThemeEngine/ControlDRT to WebThemeEngine/ControlDRTWin
3781         https://bugs.webkit.org/show_bug.cgi?id=51406 
3782         
3783         Rename WebThemeControlDRT to WebThemeControlDRTWin and WebThemeEngineDRT
3784         to WebThemeEngineDRTWin and update references everywhere.
3785
3786         * DumpRenderTree/DumpRenderTree.gypi:
3787         * DumpRenderTree/chromium/TestShellWin.cpp:
3788         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRT.cpp.
3789         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRT.h.
3790         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRT.cpp.
3791         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRT.h.
3792
3793 2010-12-21  Anders Carlsson  <andersca@apple.com>
3794
3795         Reviewed by John Sullivan.
3796
3797         Clicking missing plug-in text does not show a sheet
3798         https://bugs.webkit.org/show_bug.cgi?id=51403
3799
3800         Update for changes to the WebPageUIClient.
3801
3802         * MiniBrowser/mac/BrowserWindowController.m:
3803         (-[BrowserWindowController awakeFromNib]):
3804         * WebKitTestRunner/TestController.cpp:
3805         (WTR::createOtherPage):
3806         (WTR::TestController::initialize):
3807
3808 2010-12-21  Eric Seidel  <eric@webkit.org>
3809
3810         Reviewed by Adam Barth.
3811
3812         commit-queue will report constant failures as flaky if other tests flake
3813         https://bugs.webkit.org/show_bug.cgi?id=51272
3814
3815         This patch just removes functionality and adds testing.
3816         Previously we attempted to report flaky tests when we had
3817         two different tests fail in a row.  However, since we stop
3818         running the tests at the first failure, our code was wrong in
3819         trying to determine flakiness from the incomplete runs.
3820
3821         Originally I posted an alternate patch:
3822         https://bug-51272-attachments.webkit.org/attachment.cgi?id=77078
3823         which fixed our flaky logic in this case, however it was decided
3824         that that patch would be too difficult to maintain, so now
3825         I'm just removing the broken logic.
3826
3827         This will dramatically cut-down on our flaky-test false positives
3828         at the (small) cost of the queues being unable to report
3829         any flakiness if the tree is very flaky.  (With at least one test
3830         flaking on every run, we'll never report failures anymore.)  I think
3831         this is a tradeoff worth making.
3832
3833         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3834         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3835
3836 2010-12-20  Eric Seidel  <eric@webkit.org>
3837
3838         Reviewed by Adam Barth.
3839
3840         commit-queue wrongly rejects patches when it can't update itself
3841         https://bugs.webkit.org/show_bug.cgi?id=46636
3842
3843         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3844         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3845         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3846
3847 2010-12-20  Adam Barth  <abarth@webkit.org>
3848
3849         Move web sites to Websites directory
3850         https://bugs.webkit.org/show_bug.cgi?id=51323
3851
3852         Update references to BugsSite to point to the new location.
3853
3854         This patch was never officially reviewed (because it was too large to
3855         upload to bugs.webkit.org), but it was discussed on webkit-dev and Mark
3856         Rowe gave me the green light.
3857
3858         * Scripts/old-run-webkit-tests:
3859         * Scripts/webkitpy/common/config/build.py:
3860         * Scripts/webkitpy/common/config/build_unittest.py:
3861         * Scripts/webkitpy/common/prettypatch.py:
3862         * Scripts/webkitpy/layout_tests/port/base.py:
3863         * Scripts/webkitpy/style/main.py:
3864
3865 2010-12-20  Adrienne Walker  <enne@google.com>
3866
3867         Unreviewed. Adding myself to the list of committers.
3868
3869         * webkitpy/common/config/committers.py:
3870
3871 2010-12-20  Mark Rowe  <mrowe@apple.com>
3872
3873         Reviewed by Dan Bernstein.
3874
3875         <rdar://problem/8757601> Don't install header files in to the Resources directory.
3876
3877         * Scripts/check-for-inappropriate-files-in-framework: Don't allow .h files in the
3878         Resources directory.
3879
3880 2010-12-20  Eric Seidel  <eric@webkit.org>
3881
3882         Reviewed by Adam Barth.
3883
3884         commit-queue should include bot id when attaching failure diffs
3885         https://bugs.webkit.org/show_bug.cgi?id=51280
3886
3887         This is a tiny change to include the bot id in the name of the attachment.
3888         Most of this diff is just changing the unit test expectations
3889         now that I hid the comment printing when the comment is None.
3890
3891         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3892         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3893         * Scripts/webkitpy/tool/commands/upload_unittest.py:
3894         * Scripts/webkitpy/tool/mocktool.py:
3895
3896 2010-12-20  Jeff Miller  <jeffm@apple.com>
3897
3898         Reviewed by Dan Bernstein.
3899
3900         Tools/vcbin/midl.exe needs to be rebuilt
3901         https://bugs.webkit.org/show_bug.cgi?id=51347
3902
3903         * vcbin/midl.exe: Rebuilt.
3904
3905 2010-12-20  David Levin  <levin@chromium.org>
3906
3907         Reviewed by Ariya Hidayat.
3908
3909         .gitignore and webkit-tools-completion.sh have references to WebKitTools that should be Tools.
3910         https://bugs.webkit.org/show_bug.cgi?id=51343
3911
3912         Follow up from the WebKitTools -> Tools rename.
3913
3914         * Scripts/webkit-tools-completion.sh:
3915
3916 2010-12-20  Cosmin Truta  <ctruta@chromium.org>
3917
3918         Reviewed by James Robinson.
3919
3920         new-run-webkit-tests ignores trailing EOL differences in text tests
3921         https://bugs.webkit.org/show_bug.cgi?id=36983
3922
3923         Changed the handling of new-line characters within new-run-webkit-tests
3924         to match old-run-webkit-tests.  Differences in leading and trailing empty
3925         lines in text expectation files are no longer ignored.
3926
3927         * Scripts/webkitpy/layout_tests/port/base.py:
3928         * Scripts/webkitpy/layout_tests/port/test.py:
3929         Added unit tests.  Removed old duplicate unit test entries.
3930         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
3931
3932 2010-12-20  David Levin  <levin@chromium.org>
3933
3934         Reviewed by Shinichiro Hamaji.
3935
3936         check-webkit-style should detect function declarations (and trivial functions).
3937         https://bugs.webkit.org/show_bug.cgi?id=51303
3938
3939         * Scripts/webkitpy/style/checkers/cpp.py:
3940         (_FunctionState.begin): Add is_declaration and changed the line count
3941         start to begin at -1 (which will keep the results consistent, since
3942         the starting line number passed in is one less in this change).
3943         (detect_functions): changed function detection to now catch trivial
3944         functions and declarations.
3945         (check_pass_ptr_usage): Don't check for Pass*Ptr on the first line
3946         of the function as this may look at return values (when processing
3947         a declaration).
3948         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3949         (FunctionDetectionTest.perform_function_detection): Basic mechanics
3950         of testing the function detection.
3951         (FunctionDetectionTest.test_basic_function_detection): Test a simple
3952         function.
3953         (FunctionDetectionTest.test_function_declaration_detection): Test a
3954         declaration.
3955         (FunctionDetectionTest.test_non_functions): A test case for a case
3956         that caused the code to fail due to the { being in quotes.
3957         (PassPtrTest.test_pass_ref_ptr_return_value): Added some more test
3958         cases to help catch false alarms for return values.
3959         (PassPtrTest.test_pass_ref_ptr_member_variable): Ensure that
3960         we don't get false alarms for member variables either.
3961
3962 2010-12-20  Ryuan Choi  <ryuan.choi@samsung.com>
3963
3964         Reviewed by Antonio Gomes.
3965
3966         [CMAKE] Rename WEBKITTOOLS_DIR to TOOLS_DIR
3967         https://bugs.webkit.org/show_bug.cgi?id=51319
3968
3969         * CMakeListsEfl.txt:
3970
3971 2010-12-18  Adam Barth  <abarth@webkit.org>
3972
3973         Reviewed by Sam Weinig.
3974
3975         Move WebKitExamplePlugins to Examples
3976         https://bugs.webkit.org/show_bug.cgi?id=51291
3977
3978         * Scripts/webkitpy/common/config/build.py:
3979
3980 2010-12-17  Csaba Osztrogonác  <ossy@webkit.org>
3981
3982         Unreviewed Qt buildfix after r74301.
3983
3984         Rename WebKitTools to Tools
3985         https://bugs.webkit.org/show_bug.cgi?id=49861
3986
3987         * MiniBrowser/DerivedSources.pro:
3988         * MiniBrowser/qt/MiniBrowser.pro:
3989
3990 2010-12-17  Dan Bernstein  <mitz@apple.com>
3991
3992         Reviewed by Simon Fraser.
3993
3994         Rename WebKitTools to Tools
3995         https://bugs.webkit.org/show_bug.cgi?id=49861
3996
3997         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3998         * CodeCoverage/README:
3999         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
4000         (WebCore::DumpRenderTree::initializeFonts):
4001         * EWSTools/start-commit-queue.sh:
4002         * EWSTools/start-queue.sh:
4003         * GNUmakefile.am:
4004         * MIDLWrapper/MIDLWrapper.cpp:
4005         (wmain):
4006         * MiniBrowser/qt/MiniBrowser.pro:
4007         * Scripts/build-api-tests:
4008         * Scripts/build-dumprendertree:
4009         * Scripts/build-webkit:
4010         * Scripts/build-webkittestrunner:
4011         * Scripts/generate-coverage-data:
4012         * Scripts/old-run-webkit-tests:
4013         * Scripts/run-api-tests:
4014         * Scripts/run-iexploder-tests:
4015         * Scripts/run-javascriptcore-tests:
4016         * Scripts/run-mangleme-tests:
4017         * Scripts/run-sunspider:
4018         * Scripts/run-webkit-websocketserver:
4019         * Scripts/sunspider-compare-results:
4020         * Scripts/test-webkitperl:
4021         * Scripts/test-webkitpy:
4022         * Scripts/update-iexploder-cssproperties:
4023         * Scripts/update-webkit:
4024         * Scripts/update-webkit-localizable-strings:
4025         * Scripts/webkitdirs.pm:
4026         * Scripts/webkitpy/common/checkout/scm.py:
4027         * Scripts/webkitpy/common/checkout/scm_unittest.py:
4028         * Scripts/webkitpy/common/config/committervalidator.py:
4029         * Scripts/webkitpy/common/config/committervalidator_unittest.py:
4030         * Scripts/webkitpy/common/config/ports.py:
4031         * Scripts/webkitpy/common/config/ports_unittest.py:
4032         * Scripts/webkitpy/common/system/logutils_unittest.py:
4033         * Scripts/webkitpy/common/system/ospath_unittest.py:
4034         * Scripts/webkitpy/layout_tests/port/chromium.py:
4035         * Scripts/webkitpy/layout_tests/port/config.py:
4036         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
4037         * Scripts/webkitpy/layout_tests/port/http_server.py:
4038         * Scripts/webkitpy/layout_tests/port/test.py:
4039         * Scripts/webkitpy/style/checker.py:
4040         * Scripts/webkitpy/style/checker_unittest.py:
4041         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
4042         * Scripts/webkitpy/tool/commands/queues_unittest.py:
4043         * Scripts/webkitpy/tool/steps/steps_unittest.py:
4044         * WebKitTestRunner/DerivedSources.pro:
4045         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
4046         (WTR::activateFonts):
4047         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
4048         * wx/build/build_utils.py:
4049
4050 2010-12-16  Antonio Gomes  <agomes@rim.com>
4051
4052         Reviewed by Martin Robinson.
4053
4054         Settings::editingBehaviorType() incorrectly returns mac for the gtk build when running tests
4055         https://bugs.webkit.org/show_bug.cgi?id=51163
4056
4057         Since GTK+'s default editing behavior was changed to UNIX in r70975 (see webkitwebsettings.cpp),
4058         GTK+'s DRT should also reset to UNIX after each test execution.
4059
4060         * DumpRenderTree/gtk/DumpRenderTree.cpp:
4061         (resetDefaultsToConsistentValues):
4062
4063 2010-12-17  David Levin  <levin@chromium.org>
4064
4065         Reviewed by Eric Seidel.
4066
4067         check-webkit-style should understand WTF #include guards
4068         https://bugs.webkit.org/show_bug.cgi?id=44911
4069
4070         * Scripts/webkitpy/style/checkers/cpp.py:
4071         (get_header_guard_cpp_variable): modify to suggest the WTF style
4072         of header guard when appropriate.
4073         (check_for_header_guard): handle multiple return values from
4074         get_header_guard_cpp_variable
4075         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
4076         (CppStyleTest.test_build_header_guard): Added tests for the WTF
4077         header style.
4078
4079 2010-12-16  David Levin  <levin@chromium.org>
4080
4081         Reviewed by Eric Seidel.
4082
4083         test-webkitpy: unittest for the xml.py checker displays a decprecation warning.
4084         https://bugs.webkit.org/show_bug.cgi?id=51210
4085
4086         The error only shows up when using python 2.6 or later.
4087
4088         * Scripts/webkitpy/style/checkers/xml.py: Replace the usage of
4089         the decprecated field error,message with something equivalent.
4090
4091 2010-12-16  Mihai Parparita  <mihaip@chromium.org>
4092
4093         Reviewed by Eric Seidel.
4094
4095         Add --exit-after-n-failures/crashes to NRWT
4096         https://bugs.webkit.org/show_bug.cgi?id=51160
4097         
4098         Abort test run (in a similar way to how control-C is handled) when
4099         --exit-after-n-failures/crashes-or-timeouts are passed and we've reached
4100         that number of unexpected failures/crashes/timeouts.
4101
4102         * Scripts/webkitpy/layout_tests/port/test.py:
4103         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4104         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
4105
4106 2010-12-16  David Levin  <levin@chromium.org>
4107
4108         Reviewed by Shinichiro Hamaji.
4109
4110         check-webkit-style unit tests has some duplicate boilerplate code.
4111         https://bugs.webkit.org/show_bug.cgi?id=49519
4112
4113         * Scripts/webkitpy/style/checkers/cpp.py:
4114         (update_include_state): Replaced the "io" parameter with the global
4115         configuration _unit_test_config. This allowed not calling into
4116         functions at a low level and also not plumbing through the injection
4117         information through many levels of code.
4118         (check_for_include_what_you_use): Ditto.
4119         (process_file_data): Added the ability to set up the unit test config
4120         to allow for injection.
4121         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
4122         (ErrorCollector.__init__): Added support for having a filter for errors.
4123         (ErrorCollector.__call__): Ditto.
4124         (CppStyleTestBase.process_file_data): Added the ability to set unit_test_config.
4125         (CppStyleTestBase.perform_lint): Consolidated logic for the perform functions.
4126         (CppStyleTestBase.perform_single_line_lint): Replace specific calls to
4127         functions in the cpp.py with generic processing and a filter that
4128         indicates what errors should be kept.
4129         (CppStyleTestBase.perform_multi_line_lint): Ditto.
4130         (CppStyleTestBase.perform_language_rules_check): Ditto.
4131         (CppStyleTestBase.perform_function_lengths_check): Ditto.
4132         (CppStyleTestBase.perform_pass_ptr_check): Ditto.
4133         (CppStyleTestBase.perform_include_what_you_use): Ditto.
4134         (CppStyleTest.test_multi_line_comments): Added another
4135         error message which applies to the test case.
4136         (CppStyleTest.test_spacing_for_binary_ops): Fixed test
4137         to not have config.h, since it is processed as a header file.
4138         (CppStyleTest.test_static_or_global_stlstrings): Fixed variable name
4139         style and indentation in checked code.
4140         (OrderOfIncludesTest.test_check_preprocessor_in_include_section):
4141         Fixed line number.
4142         (NoNonVirtualDestructorsTest.test_multi_line_declaration_with_error):
4143         Ditto.
4144
4145 2010-12-15  Sheriff Bot  <webkit.review.bot@gmail.com>
4146
4147         Unreviewed, rolling out r74136.
4148         http://trac.webkit.org/changeset/74136
4149         https://bugs.webkit.org/show_bug.cgi?id=51135
4150
4151         r74136 breaks chromium canary bots because some tests are not
4152         rebaselined correctly to resolve EOL differences (Requested by
4153         jianli on #webkit).
4154
4155         * Scripts/webkitpy/layout_tests/port/base.py:
4156         * Scripts/webkitpy/layout_tests/port/test.py:
4157         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
4158
4159 2010-12-15  Adam Roben  <aroben@apple.com>
4160
4161         Teach check-webkit-style to check .vcproj and .vsprops files for XML
4162         syntax errors
4163
4164         Fixes <http://webkit.org/b/51103> check-webkit-style should check for
4165         XML syntax errors in .vcproj/.vsprops files
4166
4167         Reviewed by Dave Levin.
4168
4169         * Scripts/webkitpy/style/checker.py: Added lists of file extensions
4170         that should be treated as XML and that should be allowed to contain
4171         carriage returns. (These lists happen to be identical currently.)
4172         (FileType): Added a new XML type.
4173         (CheckerDispatcher.should_check_and_strip_carriage_returns): Added.
4174         Just does a simple file extension check.
4175         (CheckerDispatcher._file_type): Added a case for XML files.
4176         (CheckerDispatcher._create_checker): Ditto. We use XMLChecker for XML
4177         files (surprise!).
4178         (StyleProcessor.process): Ask the dispatcher whether we should pass the
4179         lines through the carriage checker.
4180
4181         * Scripts/webkitpy/style/checker_unittest.py:
4182         (CheckerDispatcherCarriageReturnTest.test_should_check_and_strip_carriage_returns):
4183         Added. Checks a few file names to see if carriage returns are allowed
4184         or not.
4185         (CheckerDispatcherDispatchTest.assert_checker_xml): Added. Similar to
4186         other assert_checker_* functions.
4187         (CheckerDispatcherDispatchTest.test_xml_paths): Added. Similar to other
4188         test_*_paths functions.
4189         (CheckerDispatcherDispatchTest.test_xml_paths): Added. Similar to other
4190         test_*_paths functions.
4191         (CheckerDispatcherDispatchTest.test_none_paths): Removed the vcproj
4192         file from this test case, as vcproj files now have a type.
4193         (StyleProcessor_CodeCoverageTest.MockDispatcher.should_check_and_strip_carriage_returns):
4194         Added. Similar to the other should_* functions.
4195         (StyleProcessor_CodeCoverageTest.test_process__carriage_returns_not_stripped):
4196         Added. Checks that carriage returns aren't checked for or stripped for
4197         allowed files.
4198
4199         * Scripts/webkitpy/style/checkers/xml.py: Added.
4200         (XMLChecker.__init__): Simple init method.
4201         (XMLChecker.check): Pass each line through the expat parser, and record
4202         a style error for any errors thrown by the parser.
4203
4204         * Scripts/webkitpy/style/checkers/xml_unittest.py: Added.
4205         (XMLCheckerTest.assert_no_error): Checks that the given XML does not
4206         produce a style error.
4207         (XMLCheckerTest.assert_error): Checks that the given XML produces an
4208         error of the given category on the given line.
4209         (XMLCheckerTest.mock_handle_style_error): Does nothing. Used for
4210         checking that the XMLChecker constructor works properly.
4211         (XMLCheckerTest.test_conflict_marker): Tests that conflict markers
4212         cause a style error (see, e.g., r73887).
4213         (XMLCheckerTest.test_extra_closing_tag): Tests that extra closing tags
4214         cause a style error (see, e.g., r73773).
4215         (XMLCheckerTest.test_init): Tests that the XMLChecker constructor works
4216         properly.
4217         (XMLCheckerTest.test_missing_closing_tag): Tests that missing closing
4218         tags cause a style error (see, e.g., r72795).
4219         (XMLCheckerTest.test_no_error): Tests that valid XML does not cause a
4220         style error.
4221
4222 2010-12-15  Lucas Forschler  <lforschler@apple.com>
4223
4224         Reviewed by Stephanie Lewis.
4225
4226         https://bugs.webkit.org/show_bug.cgi?id=51117
4227         Add a new leopard test bot
4228         really really commit to trunk this time.
4229
4230         * BuildSlaveSupport/build.webkit.org-config/config.json:
4231
4232 2010-12-15  Sam Weinig  <sam@webkit.org>
4233
4234         Reviewed by Anders Carlsson.
4235
4236         WebKit2: Can't add files to an <input type=file>
4237         https://bugs.webkit.org/show_bug.cgi?id=51087
4238
4239         * MiniBrowser/mac/BrowserWindowController.m:
4240         (runOpenPanel):
4241         (-[BrowserWindowController awakeFromNib]):
4242         Add simple implementation of runOpenPanel callback.
4243
4244         * MiniBrowser/win/BrowserView.cpp:
4245         (BrowserView::create):
4246         * WebKitTestRunner/TestController.cpp:
4247         (WTR::createOtherPage):
4248         (WTR::TestController::initialize):
4249         Stub out runOpenPanel callback. 
4250
4251 2010-12-14  Eric Seidel  <eric@webkit.org>
4252
4253         Reviewed by Adam Barth.
4254
4255         commit-queue should upload failure diffs when tests flake
4256         https://bugs.webkit.org/show_bug.cgi?id=51051
4257
4258         To make this testable I needed to pipe FileSystem down onto tool.
4259         We've wanted it there for a long time anyway.
4260
4261         This patch is kinda a big hack.  But we don't have a nice
4262         way to read results.html files.  I think this will need further
4263         revision before this code actually feels clean.
4264
4265         As part of testing this change, I had to make MockBugzilla.create_bug
4266         actually return an id (like it should) which required updating
4267         a few other unit test results (for the better).
4268
4269         The results_matching_keys change in layouttestresults/rebasline
4270         was an alternate path which I decided not to use in the end, but
4271         I left the change as it seemed an improvement.
4272
4273         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
4274         * Scripts/webkitpy/common/net/layouttestresults.py:
4275         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
4276         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
4277         * Scripts/webkitpy/tool/commands/queues.py:
4278         * Scripts/webkitpy/tool/commands/rebaseline.py:
4279         * Scripts/webkitpy/tool/main.py:
4280         * Scripts/webkitpy/tool/mocktool.py:
4281
4282 2010-12-15  Cosmin Truta  <ctruta@chromium.org>
4283
4284         Reviewed by James Robinson.
4285
4286         new-run-webkit-tests ignores trailing EOL differences in text tests
4287         https://bugs.webkit.org/show_bug.cgi?id=36983
4288
4289         Changed the handling of new-line characters within new-run-webkit-tests
4290         to match old-run-webkit-tests.  Differences in leading and trailing empty
4291         lines in text expectation files are no longer ignored.
4292
4293         * Scripts/webkitpy/layout_tests/port/base.py:
4294         * Scripts/webkitpy/layout_tests/port/test.py:
4295         Added unit tests.  Removed old duplicate unit test entries.
4296         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
4297
4298 2010-12-15  Ojan Vafai  <ojan@chromium.org>
4299
4300         Reviewed by Adam Barth.
4301
4302         make status-bubble white-space:nowrap so we can measure it's width without wrapping
4303         https://bugs.webkit.org/show_bug.cgi?id=51149
4304
4305         * QueueStatusServer/templates/statusbubble.html:
4306
4307 2010-12-15  Ojan Vafai  <ojan@chromium.org>
4308
4309         Reviewed by Adam Barth.
4310
4311         have the statusbubble postMessage it's metrics so that embedders can properly size the iframe
4312         https://bugs.webkit.org/show_bug.cgi?id=51125
4313
4314         * QueueStatusServer/templates/statusbubble.html:
4315
4316 2010-12-15  Darin Adler  <darin@apple.com>
4317
4318         * Scripts/webkitpy/common/net/buildbot: Added property svn:ignore.
4319
4320 2010-12-15  Sheriff Bot  <webkit.review.bot@gmail.com>
4321
4322         Unreviewed, rolling out r74117.
4323         http://trac.webkit.org/changeset/74117
4324         https://bugs.webkit.org/show_bug.cgi?id=51113
4325
4326         This broke the GTK1 build. (Requested by mrobinson on
4327         #webkit).
4328
4329         * Scripts/webkitdirs.pm:
4330
4331 2010-12-15  Amruth Raj  <amruthraj@motorola.com> and Ravi Kasibhatla  <ravi.kasibhatla@motorola.com>
4332
4333         Reviewed by Martin Robinson.
4334
4335         Change generate-forwarding-headers.pl for GTK port usage 
4336         (https://bugs.webkit.org/show_bug.cgi?id=37369)
4337
4338         * Scripts/webkitdirs.pm: Added changes to build webkit2 for GTK port using build-webkit script.
4339
4340 2010-12-14  Kent Tamura  <tkent@chromium.org>
4341
4342         Reviewed by Jian Li.
4343
4344         [DRT/Chromium] Remove another unnecessary error message
4345         https://bugs.webkit.org/show_bug.cgi?id=51083
4346
4347         * DumpRenderTree/chromium/WebViewHost.cpp:
4348         (WebViewHost::didInvalidateRect):
4349
4350 2010-12-14  Lucas Forschler  <lforschler@apple.com>
4351
4352         Reviewed by Stephanie Lewis.
4353
4354         Add a new Leopard Debug Test WK2 Bot
4355
4356         * BuildSlaveSupport/build.webkit.org-config/config.json:
4357
4358 2010-12-14  Ojan Vafai  <ojan@chromium.org>
4359
4360         Fix python unittests after http://trac.webkit.org/changeset/74070.
4361
4362         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
4363
4364 2010-12-14  Kent Tamura  <tkent@chromium.org>
4365
4366         Reviewed by Jian Li.
4367
4368         [DRT/Chromium] Remove a unnecessary error message
4369         https://bugs.webkit.org/show_bug.cgi?id=51069
4370
4371         * DumpRenderTree/chromium/WebViewHost.cpp:
4372         (WebViewHost::paintInvalidatedRegion):
4373
4374 2010-12-14  Benjamin Kalman  <kalman@chromium.org>
4375
4376         Reviewed by Ojan Vafai.
4377
4378         Using BUG/BUGWK in test_expectations is error prone, should use BUGCR/BUGWK
4379         https://bugs.webkit.org/show_bug.cgi?id=48926
4380
4381         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
4382         Add presubmit check that BUG isn't used, either BUGCR/BUGWK/BUGV8_.
4383
4384 2010-12-14  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
4385
4386         Reviewed by Eric Seidel.
4387
4388         [Qt] [Symbian] Do not use pkg-config on Symbian as it is not supported
4389         https://bugs.webkit.org/show_bug.cgi?id=50231
4390
4391         Guard CONFIG+=link_pkgconfig with !symbian.
4392
4393         * DumpRenderTree/qt/DumpRenderTree.pro:
4394         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
4395         * WebKitTestRunner/qt/WebKitTestRunner.pro:
4396
4397 2010-12-14  Philippe Normand  <pnormand@igalia.com>
4398
4399         Reviewed by Ojan Vafai.
4400
4401         [new-run-webkit-tests] expectations parsing is slow
4402         https://bugs.webkit.org/show_bug.cgi?id=50635
4403
4404         Avoid expensive iteration of all the tests when checking if a test
4405         file is to be skipped or not.
4406
4407         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
4408         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
4409         * Scripts/webkitpy/layout_tests/port/test.py:
4410
4411 2010-12-14  Mario Sanchez Prada  <msanchez@igalia.com>
4412
4413         Reviewed by Xan Lopez.
4414
4415         [Gtk] Implement STATE_FOCUSED, STATE_FOCUSABLE, and corresponding events for text objects
4416         https://bugs.webkit.org/show_bug.cgi?id=27048
4417
4418         Add support in DRT for checking whether an accessibility UI
4419         element is focusable and/or focused. Implemented for GTK.
4420
4421         * DumpRenderTree/AccessibilityUIElement.cpp:
4422         (getIsFocusedCallback): New.
4423         (getIsFocusableCallback): New.
4424         (AccessibilityUIElement::getJSClass): Add the new available
4425         callbacks for isFocused and isFocusable.
4426         * DumpRenderTree/AccessibilityUIElement.h:
4427         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
4428         (AccessibilityUIElement::isFocused): New, implemented by checking
4429         whether the related AtkState value is in the object's state set.
4430         (AccessibilityUIElement::isFocusable): Ditto.
4431         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
4432         (AccessibilityUIElement::isFocused): New, dummy implementation.
4433         (AccessibilityUIElement::isFocusable): Ditto.
4434         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
4435         (AccessibilityUIElement::isFocused): Ditto.
4436         (AccessibilityUIElement::isFocusable): Ditto.
4437
4438 2010-12-14  Eric Seidel  <eric@webkit.org>
4439
4440         Reviewed by Ojan Vafai.
4441
4442         webkit-patch should warn users when they're using a 32-bit git on a 64-bit system
4443         https://bugs.webkit.org/show_bug.cgi?id=50715
4444
4445         This patch makes webkit-patch print the following:
4446
4447         Warning: This machine is 64-bit, but the git binary (/usr/local/git/bin/git) does not support 64-bit.
4448         Install a 64-bit git for better performance, see:
4449         https://lists.webkit.org/pipermail/webkit-dev/2010-December/015249.html
4450
4451         I wrote this mostly because I have approximately 8 machines that I use
4452         and making sure each one is using a good Git install seemed folly.
4453         webkit-patch makes a lot of git calls, so using a fast git can shave
4454         several seconds in every invocation.  See the webkit-dev thread for more info.
4455
4456         This message will print twice during 'webkit-patch upload',
4457         once from webkit-patch and once from check-webkit-style.
4458
4459         Unfortunately there is no good way to test this due to how machine-dependent
4460         the code is.  I considered writing a test for the log message, but it seemed not worth it.
4461
4462         * Scripts/webkitpy/common/checkout/scm.py:
4463
4464 2010-12-13  Eric Seidel  <eric@webkit.org>
4465
4466         Reviewed by Adam Barth.
4467
4468         FlakyTestReporter doesn't understand bots running from multiple email addresses
4469         https://bugs.webkit.org/show_bug.cgi?id=50960
4470
4471         This explains at least one of the dupes of:
4472         https://bugs.webkit.org/show_bug.cgi?id=50863
4473         that we saw filed by the commit-queue this morning.
4474         I think the other one was explained by my previous fix to result counting code.
4475
4476         Since this is really hard to test with a unit test, instead I
4477         create a new (possibly useful in the future) command
4478         which given a layout test path will return you
4479         the one bug which our tools would assume it the flaky test bug.
4480         If some other script wants to use bug-for-test we'll
4481         need to extend it with some options like&n