2011-03-24 Dirk Pranke <dpranke@chromium.org>
[WebKit.git] / Tools / ChangeLog
1 2011-03-24  Dirk Pranke  <dpranke@chromium.org>
2
3         Reviewed by Adam Barth.
4
5         fix regressions introduced in 81908 - there were a couple of
6         code paths that only fired under python 2.5 that I missed.
7
8         Also change a couple of 'python' references to sys.executable
9         in order to handle runing test-webkitpy with a binary other than
10         something called 'python'.
11
12         https://bugs.webkit.org/show_bug.cgi?id=57063
13
14         * Scripts/webkitpy/layout_tests/port/mac.py:
15         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
16         * Scripts/webkitpy/test/cat.py:
17         * Scripts/webkitpy/test/echo.py:
18
19 2011-03-24  Brent Fulgham  <bfulgham@webkit.org>
20
21         Unreviewed build correction.
22
23         Add a stub implementation of the TestInvocation dumping logic.
24         Update project files to reflect new file.
25
26         * WebKitTestRunner/cairo: Added.
27         * WebKitTestRunner/cairo/TestInvocationCairo.cpp: Added.
28         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
29         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
30
31 2011-03-24  Dirk Pranke  <dpranke@chromium.org>
32
33         Reviewed by Tony Chang.
34
35         new-run-webkit-tests: clean up worker model defaults. This
36         changes the default behavior to 'threads' instead of
37         'old-threads', and clarifies that chromium-win-* and
38         chromium-mac-leopard are exceptions.
39
40         https://bugs.webkit.org/show_bug.cgi?id=56971
41
42         * Scripts/webkitpy/layout_tests/port/base.py:
43         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
44         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
45         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
46         * Scripts/webkitpy/layout_tests/port/test.py:
47         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
48
49 2011-03-23  Leandro Gracia Gil  <leandrogracia@chromium.org>
50
51         Reviewed by Darin Adler.
52
53         Media Stream API: fix the order of the options in build-webkit.
54         https://bugs.webkit.org/show_bug.cgi?id=56949
55
56         Fix the order of the options in build-webkit.
57
58         * Scripts/build-webkit:
59
60 2011-03-23  Adam Klein  <adamk@chromium.org>
61
62         Reviewed by Mihai Parparita.
63
64         Add an option to new-run-webkit-httpd to allow overriding the location of LayoutTests directory
65         https://bugs.webkit.org/show_bug.cgi?id=56884
66
67         This option will be utilized by Chromium's ui_tests to allow
68         referencing js-test-resources from a layout test over HTTP.
69
70         * Scripts/new-run-webkit-httpd:
71         Added --layout_tests_dir option.
72         * Scripts/webkitpy/layout_tests/port/http_server.py:
73         Plumbed through as layout_tests_dir param.
74
75 2011-03-23  Dirk Pranke  <dpranke@chromium.org>
76
77         Reviewed by Mihai Parparita.
78
79         new-run-webkit-tests: run tests in ascending alphabetical order per
80         dir. This is a second attempt at the fix; the first attempt, in 
81         r81597, broke the behavior on the old-inline and old-threads
82         worker models.
83
84         https://bugs.webkit.org/show_bug.cgi?id=56760
85
86         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
87         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
88         * Scripts/webkitpy/layout_tests/port/test.py:
89         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
90
91 2011-03-23  Mario Sanchez Prada  <msanchez@igalia.com>
92
93         Reviewed by Martin Robinson.
94
95         [GTK] GTK's DRT to ouput detail's string for the 'property-change' signal
96         https://bugs.webkit.org/show_bug.cgi?id=56953
97
98         Print the string for the detail of 'property-change' signal.
99
100         * DumpRenderTree/gtk/AccessibilityCallbacks.cpp:
101         (axObjectEventListener): Print the detail string.
102
103 2011-03-23  Yury Semikhatsky  <yurys@chromium.org>
104
105         Reviewed by Pavel Feldman.
106
107         [V8] Web Inspector: compile DebuggerScript.js into DebuggerScriptSource.h
108         https://bugs.webkit.org/show_bug.cgi?id=56843
109
110         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
111         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
112
113 2011-03-22  Eric Seidel  <eric@webkit.org>
114
115         Reviewed by Adam Barth.
116
117         Teach update-webkit about gyp
118         https://bugs.webkit.org/show_bug.cgi?id=56881
119
120         This makes it possible for someone who builds from Xcode
121         to just run update-webkit --gyp and have the project files
122         generated after update automatically.
123
124         I also added a stand-alone "generate-project-files" script
125         wrapping Source/gyp/configure.  This makes running gyp simpler
126         since most people will not have gyp or Source/gyp in their path.
127
128         * Scripts/build-webkit:
129         * Scripts/generate-project-files: Added.
130         * Scripts/update-webkit:
131
132 2011-03-22  Anton D'Auria  <adauria@apple.com>
133
134         Reviewed by Alexey Proskuryakov.
135
136         Add +[WebApplicationCache getOriginsWithCache]
137         https://bugs.webkit.org/show_bug.cgi?id=56722
138
139         * DumpRenderTree/LayoutTestController.cpp:
140         (originsWithApplicationCacheCallback):
141         (LayoutTestController::staticFunctions):
142         * DumpRenderTree/LayoutTestController.h:
143         * DumpRenderTree/chromium/LayoutTestController.cpp: Added stub.
144         (LayoutTestController::originsWithApplicationCache):
145         * DumpRenderTree/chromium/LayoutTestController.h:
146         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Added stub.
147         (LayoutTestController::originsWithApplicationCache):
148         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Pass array of origin's database identifiers.
149         (originsArrayToJS): Helper function for converting array of WebSecurityOrigins to a JS array of origin identifiers.
150         (LayoutTestController::originsWithApplicationCache):
151         (LayoutTestController::originsWithLocalStorage):
152         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Added stub.
153         (LayoutTestController::originsWithApplicationCache):
154         * DumpRenderTree/qt/LayoutTestControllerQt.h:
155         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Added stub.
156         (LayoutTestController::originsWithApplicationCache):
157         * DumpRenderTree/wx/LayoutTestControllerWx.cpp: Added stub.
158         (LayoutTestController::originsWithApplicationCache):
159
160 2011-03-22  Eric Seidel  <eric@webkit.org>
161
162         Reviewed by Adam Barth.
163
164         Add support to build-webkit for building with gyp-generated project files
165         https://bugs.webkit.org/show_bug.cgi?id=56877
166
167         build-webkit is a cesspool.  This change just hacks in --gyp support for Mac.
168         Eventually we'll want to support gyp-generated projects in a more general manner.
169
170         * Scripts/build-webkit:
171
172 2011-03-22  David Kilzer  <ddkilzer@apple.com>
173
174         <http://webkit.org/b/56781> Add --dsym switch to enable dsym generation when building with Xcode
175
176         Reviewed by Joseph Pecoraro.
177
178         * Scripts/build-webkit: Updated usage statement to include
179         --dsym.
180         * Scripts/webkitdirs.pm: Added $generateDsym variable.
181         (generateDsym): Added. Call determineGenerateDsym() and
182         return $generateDsym.
183         (determineGenerateDsym): Added.  Parse @ARGV for --dsym and set
184         $generateDsym.
185         (argumentsForXcode): Added.  Returns additional arguments for
186         xcodebuild based on command-line switches.
187         (XcodeOptions): Updated to include argumentsForXcode() in the
188         array returned.
189
190 2011-03-22  Adam Roben  <aroben@apple.com>
191
192         Make Leopard Debug bots and Windows XP Debug (Tests) core builders
193
194         These bots are consistently green again.
195
196         Fixes <http://webkit.org/b/56830> Leopard Debug bots and Windows XP Debug (Tests) should be
197         core builders
198
199         Rubber-stamped by Antti Koivisto.
200
201         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
202         (BuildBot.__init__): Loosened the regexps for Leopard and Windows.
203
204         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
205         (BuildBotTest.test_builder_name_regexps): Updated expectations.
206
207 2011-03-21  Sheriff Bot  <webkit.review.bot@gmail.com>
208
209         Unreviewed, rolling out r81597.
210         http://trac.webkit.org/changeset/81597
211         https://bugs.webkit.org/show_bug.cgi?id=56801
212
213         Change results in lots of unexpected flaky on the dashboard.
214         (Requested by pfeldman on #webkit).
215
216         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
217         * Scripts/webkitpy/layout_tests/port/test.py:
218         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
219
220 2011-03-21  Sam Weinig  <sam@webkit.org>
221
222         Fix failing tests on the WebKit2 bots.
223
224         * WebKitTestRunner/TestController.cpp:
225         (WTR::TestController::resetStateToConsistentValues):
226
227 2011-03-21  Daniel Sievers  <sievers@google.com>
228
229         Reviewed by Simon Fraser.
230
231         [Chromium] Make RenderAsTextBehavior and LayerTreeAsTextBehavior tweakable from the DumpRenderTree commandline
232         https://bugs.webkit.org/show_bug.cgi?id=56139
233
234         * DumpRenderTree/chromium/DumpRenderTree.cpp:
235         (main):
236         * DumpRenderTree/chromium/LayoutTestController.cpp:
237         (LayoutTestController::LayoutTestController):
238         (LayoutTestController::layerTreeAsText):
239         * DumpRenderTree/chromium/LayoutTestController.h:
240         (LayoutTestController::setShowDebugLayerTree):
241         * DumpRenderTree/chromium/TestShell.cpp:
242         (TestShell::runFileTest):
243         (TestShell::dump):
244         * DumpRenderTree/chromium/TestShell.h:
245         (TestParams::TestParams):
246
247 2011-03-21  Adam Roben  <aroben@apple.com>
248
249         Try again to get buildbot to show run-javascriptcore-tests's actual.html as an HTML file
250
251         Fixes <http://webkit.org/b/56746> build.webkit.org shows run-javascriptcore-tests's HTML
252         output as plain text
253
254         Reviewed by David Kilzer.
255
256         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
257         (RunJavaScriptCoreTests): List actual.html as one of our log files so it will get uploaded
258         to the master.
259         (RunJavaScriptCoreTests.commandComplete): Reading the actual.html file here won't work,
260         since we're running on the build master, not the slave. Instead, turn the raw source of
261         actual.html which the build slave uploaded into an HTML log.
262
263 2011-03-21  Dirk Pranke  <dpranke@chromium.org>
264
265         Reviewed by Mihai Parparita.
266
267         new-run-webkit-tests: run tests in ascending alphabetical order per dir
268         https://bugs.webkit.org/show_bug.cgi?id=56760
269
270         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
271         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
272         * Scripts/webkitpy/layout_tests/port/test.py:
273
274 2011-03-21  Leandro Gracia Gil  <leandrogracia@chromium.org>
275
276         Reviewed by Steve Block.
277
278         Media Stream API patch 0: adding compilation guards.
279         https://bugs.webkit.org/show_bug.cgi?id=56458
280
281         Adding options to enable the media stream API feature in Chromium.
282
283         * Scripts/build-webkit:
284
285 2011-03-21  Qi Zhang  <qi.2.zhang@nokia.com>
286
287         Reviewed by Laszlo Gombos.
288
289         [Qt] Add a command line option to capture stdout and stderr for DumpRenderTree
290         https://bugs.webkit.org/show_bug.cgi?id=56323
291
292         Using freopen to redirect STDOUT and STDERR when DumpRenderTree command line provide 
293         "--stdout" or "--stderr" option.
294
295         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
296         (WebCore::DumpRenderTree::~DumpRenderTree):
297         (WebCore::DumpRenderTree::processArgsLine):
298         (WebCore::DumpRenderTree::loadNextTestInStandAloneMode):
299         * DumpRenderTree/qt/DumpRenderTreeQt.h:
300         (WebCore::DumpRenderTree::setRedirectOutputFileName):
301         (WebCore::DumpRenderTree::setRedirectErrorFileName):
302         * DumpRenderTree/qt/main.cpp:
303         (isOption):
304         (takeOptionValue):
305         (printUsage):
306         (main):
307
308 2011-03-21  Adam Roben  <aroben@apple.com>
309
310         Fix exceptions on the buildbot due to my last change
311
312         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
313         (RunJavaScriptCoreTests.commandComplete): Catch exceptions due to actual.html not existing.
314
315 2011-03-21  Adam Roben  <aroben@apple.com>
316
317         Teach buildbot to treat run-javascriptcore-tests's actual.html as an HTML file
318
319         Fixes <http://webkit.org/b/56746> build.webkit.org shows run-javascriptcore-tests's HTML
320         output as plain text
321
322         Reviewed by Darin Adler.
323
324         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
325         (RunJavaScriptCoreTests): Removed the logfiles variable, which can only handle plaintext
326         logs.
327         (RunJavaScriptCoreTests.commandComplete): Use the addHTMLLog method to upload actual.html to
328         the build master. This will correctly treat it as HTML.
329
330 2011-03-20  Bill Budge  <bbudge@chromium.org>
331
332         Reviewed by Adam Barth.
333
334         Rename ThreadSafeShared to ThreadSafeRefCounted
335         https://bugs.webkit.org/show_bug.cgi?id=56714
336
337         No new tests. Exposes no new functionality.
338
339         * DumpRenderTree/ForwardingHeaders/wtf/ThreadSafeRefCounted.h: Copied from DumpRenderTree/ForwardingHeaders/wtf/ThreadSafeShared.h.
340         * DumpRenderTree/ForwardingHeaders/wtf/ThreadSafeShared.h: Removed.
341         * Scripts/do-webcore-rename:
342
343 2011-03-19  Anton D'Auria  <adauria@apple.com>
344
345         Reviewed by Dan Bernstein.
346
347         Add stub to LayoutTestControllerGtk.cpp to fix GTK build
348         https://bugs.webkit.org/show_bug.cgi?id=56719
349
350         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Adding stub.
351         (LayoutTestController::clearApplicationCacheForOrigin):
352
353 2011-03-19  Anton D'Auria  <adauria@apple.com>
354
355         Reviewed by Alexey Proskuryakov.
356
357         ApplicationCacheGroup is not obsolete after being deleted via ApplicationCacheStorage::deleteEntriesForOrigin
358         https://bugs.webkit.org/show_bug.cgi?id=56415
359
360         * DumpRenderTree/LayoutTestController.cpp:
361         (clearApplicationCacheForOriginCallback):
362         (LayoutTestController::staticFunctions):
363         * DumpRenderTree/LayoutTestController.h:
364         * DumpRenderTree/chromium/LayoutTestController.cpp: Adding stubs.
365         (LayoutTestController::LayoutTestController):
366         (LayoutTestController::clearAllApplicationCaches):
367         (LayoutTestController::clearApplicationCacheForOrigin): 
368         * DumpRenderTree/chromium/LayoutTestController.h:
369         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Adding stub.
370         (LayoutTestController::clearApplicationCacheForOrigin):
371         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Adding stub.
372         (LayoutTestController::clearApplicationCacheForOrigin):
373         * DumpRenderTree/qt/LayoutTestControllerQt.h:
374         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Adding stub.
375         (LayoutTestController::clearApplicationCacheForOrigin):
376         * DumpRenderTree/wx/LayoutTestControllerWx.cpp: Adding stub.
377         (LayoutTestController::clearApplicationCacheForOrigin):
378
379 2011-03-18  Dan Bernstein  <mitz@apple.com>
380
381         Revised build fix for r81135.
382
383         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
384         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
385
386 2011-03-18  Adam Roben  <aroben@apple.com>
387
388         Windows build fix
389
390         * WebKitTestRunner/config.h: Add a missing #endif.
391
392 2011-03-18  Andreas Kling  <kling@webkit.org>
393
394         Unbreak Qt build after r81494.
395
396         * WebKitTestRunner/qt/TestInvocationQt.cpp:
397         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
398
399 2011-03-18  Sam Weinig  <sam@webkit.org>
400
401         Fix windows build. This was really Adam Roben's fault. I swear!
402
403         * WebKitTestRunner/config.h:
404
405 2011-03-18  Sam Weinig  <sam@webkit.org>
406
407         Reviewed by Adam Roben.
408
409         Pixel tests don't work in WebKitTestRunner on Windows
410         https://bugs.webkit.org/show_bug.cgi?id=56630
411
412         Cross-platformize (Mac and Windows CG) the pixel dumping code in WebKitTestRunner to use WebKit2
413         built-in snapshotting instead of using the window server on the Mac.
414
415         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
416         (WTR::InjectedBundle::InjectedBundle):
417         (WTR::InjectedBundle::didReceiveMessage):
418         (WTR::InjectedBundle::beginTesting):
419         (WTR::InjectedBundle::done):
420         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
421         (WTR::InjectedBundle::setPixelResult):
422         (WTR::InjectedBundle::shouldDumpPixels):
423         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
424         (WTR::InjectedBundlePage::dump):
425         Take the snapshot in the bundle and send it to the UIProcess for dumping.
426
427         * WebKitTestRunner/TestInvocation.cpp:
428         (WTR::TestInvocation::invoke):
429         (WTR::TestInvocation::dump):
430         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
431         * WebKitTestRunner/TestInvocation.h:
432         * WebKitTestRunner/cg: Added.
433         * WebKitTestRunner/cg/TestInvocationCG.cpp: Copied from WebKitTestRunner/mac/TestInvocationMac.mm.
434         (WTR::createCGContextFromImage):
435         (WTR::computeMD5HashStringForContext):
436         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
437         * WebKitTestRunner/mac/TestInvocationMac.mm: Removed.
438         Making pixel dumping code shared for CG ports. Also use the WTF/MD5 instead of platform specific code.
439
440         * WebKitTestRunner/win/TestInvocationWin.cpp:
441         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
442         Keep stub for Cairo build.
443
444         * WebKitTestRunner/Configurations/WebKitTestRunnerCoreGraphics.vsprops: Added.
445         Add CG configuration.
446
447         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
448         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
449         Add new files.
450
451 2011-03-18  Adam Roben  <aroben@apple.com>
452
453         Don't allow Leaks Viewer's vertical scrollbar to cover up long function names
454
455         Rubber-stamped by Simon Fraser.
456
457         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
458         (.data-grid .data-container): Use overflow-y:auto instead of the Inspector's default
459         overflow-y:overlay so that the scrollbar doesn't overlay the content.
460
461 2011-03-18  Adam Roben  <aroben@apple.com>
462
463         Don't ellipsize long or indented function names in Leaks Viewer
464
465         Fixes <http://webkit.org/b/56037> Leaks viewer needs horizontal
466         scrollbar
467
468         Reviewed by Simon Fraser.
469
470         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
471         (.data-grid .data-container):
472         (.data-grid td > div, .data-grid th > div):
473         Allow the contents to extend to the right.
474
475 2011-03-18  Adam Roben  <aroben@apple.com>
476
477         Fix some leaks in DRT seen on the leaks bot
478
479         Fixes <http://webkit.org/b/56638> addURLToRedirectCallback and
480         setWillSendRequestClearHeaderCallback in DRT are leaky
481
482         Reviewed by Alexey Proskuryakov.
483
484         * DumpRenderTree/ForwardingHeaders/wtf/OwnArrayPtr.h: Added.
485
486         * DumpRenderTree/LayoutTestController.cpp:
487         (addURLToRedirectCallback):
488         (setWillSendRequestClearHeaderCallback):
489         Use OwnArrayPtr to cause the strings to be deleted.
490
491 2011-03-18  Adam Roben  <aroben@apple.com>
492
493         Fix a NSURLCredential leak seen on the leaks bot
494
495         Fixes <http://webkit.org/b/56637> -[SynchronousLoader
496         connection:didReceiveAuthenticationChallenge:] is leaky
497
498         Reviewed by John Sullivan.
499
500         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
501         (-[SynchronousLoader connection:didReceiveAuthenticationChallenge:]): Use a RetainPtr to
502         cause the NSURLCredential to be released.
503
504 2011-03-18  John Knottenbelt  <jknotten@chromium.org>
505
506         Unreviewed.
507
508         Remove unnecessary brackets around my email address.
509
510         * Scripts/webkitpy/common/config/committers.py:
511
512 2011-03-18  Adam Roben  <aroben@apple.com>
513         
514         Remove some files I accidentally added in r81454
515
516         * WebKitTestRunner/Configurations/WebKitTestRunnerCoreGraphics.vsprops: Removed.
517         * WebKitTestRunner/cg/TestInvocationCG.cpp: Removed.
518
519 2011-03-18  Adam Roben  <aroben@apple.com>
520
521         Ignore an NSNumberFormatter leak on SnowLeopard
522
523         * Scripts/old-run-webkit-tests:
524         (countAndPrintLeaks): Ignore leaks in -[NSNumberFormatter
525         getObjectValue:forString:errorDescription:].
526
527 2011-03-18  Adam Roben  <aroben@apple.com>
528
529         Fix a leak beneath LayoutTestController::authenticateSession seen on the bots
530
531         Rubber-stamped by Mark Rowe.
532
533         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
534         (LayoutTestController::authenticateSession): Use a RetainPtr to cause the NSURLRequest to be
535         released.
536
537 2011-03-17  Adam Roben  <aroben@apple.com>
538
539         Address a review comment I missed in r81445
540
541         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js:
542         (LeaksParserWorker.prototype._parseLeaks): Anchor the RegExp used to find the number of
543         leaked bytes to speed up searching on long lines.
544
545 2011-03-17  Adam Roben  <aroben@apple.com>
546
547         Mark leaky builds orange, even if all regression tests passed
548
549         Fixes <http://webkit.org/b/56609> SnowLeopard Intel Leaks bot appears green on
550         build.webkit.org when all tests pass even though there are still leaks
551
552         Reviewed by Dan Bernstein.
553
554         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
555         (RunWebKitLeakTests): Set the warnOnWarnings property to True so that the entire build will
556         be marked orange if this build step generates warnings.
557
558 2011-03-17  Adam Roben  <aroben@apple.com>
559
560         Allow values in Leaks Viewer to be shown as percentages
561
562         Double-clicking on a column will toggle between showing percentages and showing real values.
563
564         Fixes <http://webkit.org/b/56628> Would like to view values as percentages of the total
565         number of leaked bytes in Leaks Viewer
566
567         Reviewed by Joe Pecoraro.
568
569         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js:
570         (LeaksParserWorker.prototype._incorporateLeaks): Calculate the (never-shown) top-level
571         node's totalTime, which is used in calculating percentages.
572
573         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js:
574         (monkeyPatchInspectorObjects): Only format values as bytes if we aren't supposed to be
575         showing them as percentages.
576
577 2011-03-17  Adam Roben  <aroben@apple.com>
578
579         Show the number of leaked bytes, not just leaked allocations, in Leaks Viewer
580
581         The Self and Total columns now report the number of leaked bytes. The new Calls column shows
582         the number of leaked allocations. And the new Average column shows the average number of
583         leaked bytes per call.
584
585         Fixes <http://webkit.org/b/56344> Leaks Viewer should show how many bytes were leaked, not
586         just how many allocations
587
588         Reviewed by Joe Pecoraro.
589
590         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js:
591         (LeaksParserWorker.prototype._parseLeaks): Parse the number of leaked bytes from the "Leak:"
592         line and store it with the leak stack.
593         (LeaksParserWorker.prototype._createNode): Initialize the averageTime and numberOfCalls
594         properties.
595         (LeaksParserWorker.prototype._incorporateLeaks): Updated to get the stack from the .stack
596         property, and changed to store the number of leaked bytes in .selfTime/.totalTime.
597         .numberOfCalls now holds the number of leaked allocations.
598
599         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js:
600         (Preferences): Set samplingCPUProfiler to false so that the Average and Calls columns will
601         appear.
602         (monkeyPatchInspectorObjects): Format the values as bytes.
603
604 2011-03-17  Adam Roben  <aroben@apple.com>
605
606         Make Leaks Viewer able to count leaks in builds that didn't fail any regression tests
607
608         Fixes <http://webkit.org/b/56626> Leaks Viewer omits recent builds which didn't fail any
609         regression tests
610
611         Reviewed by James Robinson.
612
613         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
614         (RecentBuildsLoader.prototype.start): Get the number of leaks out of the "text" array, which
615         is always populated, even when all regression tests pass.
616
617 2011-03-10  Hayato Ito  <hayato@chromium.org>
618
619         Reviewed by Tony Chang.
620
621         Add a check logic for reftests in case that a reftest is marked AS REBASELINE.
622
623         https://bugs.webkit.org/show_bug.cgi?id=56076
624
625         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
626
627 2011-03-17  Adam Roben  <aroben@apple.com>
628
629         Skip a compositing-sensitive test when accelerated compositing is disabled
630
631         Reviewed by Sam Weinig.
632
633         * Scripts/old-run-webkit-tests: Skip media/media-document-audio-repaint.html when
634         accelerated compositing is disabled.
635
636 2011-03-17  Adam Roben  <aroben@apple.com>
637
638         Start using PlatformSpecificScheduler for the Mac builders
639
640         The current set of file/directory patterns should work for Mac builders. We may discover
641         that there are more files and directories we can exclude from the Mac builds, but they can
642         be added later.
643
644         Fixes <http://webkit.org/b/56593> Mac builders do lots of unnecessary builds
645
646         Reviewed by Mark Rowe.
647
648         * BuildSlaveSupport/build.webkit.org-config/config.json: Moved the Mac builders into two
649         PlatformSpecificSchedulers: one for Leopard, and one for SnowLeopard.
650
651         * Scripts/webkitpy/common/config/build.py:
652         (_should_file_trigger_build): Allow "mac-leopard" and "mac-snowleopard" platforms, and
653         cleaned up patterns a little bit.
654
655         * Scripts/webkitpy/common/config/build_unittest.py:
656         (ShouldBuildTest): Fixed some expected results.
657         (ShouldBuildTest.test_should_build): Start testing "mac-leopard" and "mac-snowleopard"
658         platforms.
659
660 2011-03-17  Jeff Miller  <jeffm@apple.com>
661
662         Use a consistent set of file patterns in the svn:ignore property for all .xcodeproj directories, specifically:
663         
664         *.mode*
665         *.pbxuser
666         *.perspective*
667         project.xcworkspace
668         xcuserdata
669
670         * DumpRenderTree/DumpRenderTree.xcodeproj: Modified property svn:ignore.
671         * MiniBrowser/MiniBrowser.xcodeproj: Modified property svn:ignore.
672         * TestWebKitAPI/TestWebKitAPI.xcodeproj: Modified property svn:ignore.
673         * WebKitLauncher/WebKitLauncher.xcodeproj: Modified property svn:ignore.
674         * WebKitTestRunner/WebKitTestRunner.xcodeproj: Modified property svn:ignore.
675
676 2011-03-17  Adam Roben  <aroben@apple.com>
677
678         Make old-run-webkit-tests pick up mac-wk2 results when running in WebKit2 mode on Windows
679
680         Fixes <http://webkit.org/b/56563> Running WebKit2 tests on Windows should use results from
681         mac-wk2
682
683         Reviewed by Anders Carlsson.
684
685         * Scripts/old-run-webkit-tests:
686         (expectedDirectoryForTest): Clean up the code to search in extra Mac platform result
687         directories on Windows. Add mac-wk2 to the set of extra platforms we look in on Windows when
688         we're running in WebKit2 mode.
689
690 2011-03-17  Mikhail Naganov  <mnaganov@chromium.org>
691
692         Reviewed by Yury Semikhatsky.
693
694         Web Inspector: Clean up Inspector strings.
695         https://bugs.webkit.org/show_bug.cgi?id=56557
696
697         Modify the script to deal correctly with "\xNN" escapes, and to
698         check strings in Chromium's DevTools.js.
699
700         * Scripts/check-inspector-strings:
701
702 2011-03-17  Keith Kyzivat  <keith.kyzivat@nokia.com>
703
704         Reviewed by Benjamin Poulain.
705
706         Update autoinstall to install mechanize 0.2.4
707         https://bugs.webkit.org/show_bug.cgi?id=56499
708
709         Newer versions of mechanize support HTTPS proxies, which is necessary
710         for people using webkit-patch behind firewalls.
711
712         * Scripts/webkitpy/common/system/autoinstall.py:
713         * Scripts/webkitpy/thirdparty/__init__.py:
714
715 2011-03-16  Sam Weinig  <sam@webkit.org>
716
717         Reviewed by Adam Roben.
718
719         REGRESSION (r81084): media/invalid-media-url-crash.html and editing/execCommand/indent-paragraphs.html failing on WebKit2
720         https://bugs.webkit.org/show_bug.cgi?id=56541
721
722         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
723         (WTR::InjectedBundlePage::willSendRequestForFrame):
724         Check for an empty host in addition to a null host.  This bug was introduced
725         when porting off of the KURL code and onto the WKURLRef version.
726
727 2011-03-16  Sam Weinig  <sam@webkit.org>
728
729         Reviewed by Adam Roben.
730
731         Add Lucas Forschler to the list of WebKit committers.
732
733         * Scripts/webkitpy/common/config/committers.py:
734
735 2011-03-16  Sam Weinig  <sam@webkit.org>
736
737         Reviewed upon and dictated through Adam Roben.
738
739         Escape crashing function names in results.html. This fixes an issue
740         when a crash involves a type with templates.
741
742         * Scripts/old-run-webkit-tests:
743
744 2011-03-16  Daniel Sievers  <sievers@google.com>
745
746         Reviewed by James Robinson.
747
748         Add setting to always force compositing mode
749         https://bugs.webkit.org/show_bug.cgi?id=56156
750
751         * DumpRenderTree/chromium/DumpRenderTree.cpp:
752         (main):
753         * DumpRenderTree/chromium/TestShell.cpp:
754         (TestShell::TestShell):
755         (TestShell::resetWebSettings):
756         * DumpRenderTree/chromium/TestShell.h:
757         (TestShell::setForceCompositingMode):
758         * DumpRenderTree/chromium/WebPreferences.cpp:
759         (WebPreferences::reset):
760         (WebPreferences::applyTo):
761         * DumpRenderTree/chromium/WebPreferences.h:
762
763 2011-03-15  Hayato Ito  <hayato@chromium.org>
764
765         Reviewed by Ojan Vafai.
766
767         Ignore files that will be used by reftests in old-run-webkit-tests.
768
769         https://bugs.webkit.org/show_bug.cgi?id=55936
770
771         * Scripts/old-run-webkit-tests:
772
773 2011-03-15  Felipe Oliveira da Silva Netto  <f.dachshund@gmail.com>
774
775         Reviewed by Adam Roben.
776
777         Function relativeScriptsDir doesn't return the correct relative
778         Scripts directory.
779
780         * Scripts/webkitdirs.pm:
781         (relativeScriptsDir): Ensure we use the directory that contains
782         webkitdirs.pm, not the one that contains the original script that
783         was invoked.
784
785 2011-03-15  Kevin Ollivier  <kevino@theolliviers.com>
786
787         [wx] Build fixes for long linker commands on Win and method return error, plus a Mac
788         fix to link against the Security framework after recent WebKitSystemInterface changes.
789
790         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
791         (LayoutTestController::originsWithLocalStorage):
792         * wx/build/settings.py:
793         * wx/build/waf_extensions.py:
794
795 2011-03-15  Sam Weinig  <sam@webkit.org>
796
797         Reviewed by Darin Adler.
798
799         Add script to convert a patch to a prettypatch and show in the default browser
800         https://bugs.webkit.org/show_bug.cgi?id=56416
801
802         This can be used either like
803             $ svn-create-patch | show-pretty-diff
804         or
805             $ show-pretty-diff patch.diff
806
807         * Scripts/show-pretty-diff: Added.
808
809 2011-03-15  Brian Weinstein  <bweinstein@apple.com>
810
811         Rubber-stamped by Adam Roben.
812
813         Adding myself as a reviewer.
814
815         * Scripts/webkitpy/common/config/committers.py:
816
817 2011-03-15  Anders Carlsson  <andersca@apple.com>
818
819         Try to fix the Windows build.
820
821         * DumpRenderTree/TestNetscapePlugIn/Tests/NPDeallocateCalledBeforeNPShutdown.cpp:
822         (NPDeallocateCalledBeforeNPShutdown::TestObject::~TestObject):
823
824 2011-03-15  Anders Carlsson  <andersca@apple.com>
825
826         Reviewed by Sam Weinig.
827
828         Make sure that NP_Shutdown is always the last NPP function called
829         https://bugs.webkit.org/show_bug.cgi?id=56391
830
831         Add a test that times out if an NP_Deallocate object is called after NP_Shutdown.
832
833         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
834         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
835         (PluginTest::PluginTest):
836         (PluginTest::NP_Shutdown):
837         (PluginTest::registerNPShutdownFunction):
838         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
839         * DumpRenderTree/TestNetscapePlugIn/Tests/NPDeallocateCalledBeforeNPShutdown.cpp: Added.
840         (NPDeallocateCalledBeforeNPShutdown::NPDeallocateCalledBeforeNPShutdown):
841         (NPDeallocateCalledBeforeNPShutdown::TestObject::~TestObject):
842         (NPDeallocateCalledBeforeNPShutdown::ScriptableObject::hasProperty):
843         (NPDeallocateCalledBeforeNPShutdown::ScriptableObject::getProperty):
844         (NPDeallocateCalledBeforeNPShutdown::NPP_New):
845         (NPDeallocateCalledBeforeNPShutdown::NPP_GetValue):
846         (NPDeallocateCalledBeforeNPShutdown::shutdown):
847         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
848         (NP_Shutdown):
849         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
850         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
851         * GNUmakefile.am:
852
853 2011-03-15  Ilya Sherman  <isherman@chromium.org>
854
855         Reviewed by Tony Chang.
856
857         Autofilled form elements are assigned fixed background color but not text color
858         https://bugs.webkit.org/show_bug.cgi?id=48382
859
860         * DumpRenderTree/LayoutTestController.cpp:
861         (setAutofilledCallback): Added.
862         (LayoutTestController::staticFunctions):
863         * DumpRenderTree/LayoutTestController.h:
864         * DumpRenderTree/chromium/LayoutTestController.cpp:
865         (LayoutTestController::LayoutTestController):
866         (LayoutTestController::setAutofilled): Added.
867         * DumpRenderTree/chromium/LayoutTestController.h:
868         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
869         (LayoutTestController::setAutofilled): Added.
870         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
871         (LayoutTestController::setAutofilled): Added.
872         (LayoutTestController::setValueForUser): Style tweak.
873         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
874         (LayoutTestController::setAutofilled): Added (stub).
875         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
876         (LayoutTestController::setAutofilled): Added (stub).
877
878 2011-03-15  Dan Bernstein  <mitz@apple.com>
879
880         Build fix after r81135.
881
882         * TestWebKitAPI/Configurations/InjectedBundle.xcconfig:
883
884 2011-03-15  Dan Bernstein  <mitz@apple.com>
885
886         Build fix after r81135.
887
888         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
889         * WebKitTestRunner/mac/TestControllerMac.mm:
890         * WebKitTestRunner/mac/TestInvocationMac.mm:
891         * WebKitTestRunner/mac/main.mm:
892
893 2011-03-15  Balazs Kelemen  <kbalazs@webkit.org>
894
895         Reviewed by Adam Barth.
896
897         REGRESSION(80977): breaks Qt ARMv7 Linux Release bot
898         https://bugs.webkit.org/show_bug.cgi?id=56349
899
900         * QtTestBrowser/QtTestBrowser.pro: Link against fontconfig
901         on platforms where we use it. Copied from DumpRenderTree.pro.
902
903 2011-03-15  Dan Bernstein  <mitz@apple.com>
904
905         Build fix after r81135.
906
907         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
908         * DumpRenderTree/mac/WebArchiveDumpSupportMac.mm:
909
910 2011-03-15  Kevin Ollivier  <kevino@theolliviers.com>
911
912         Reviewed by Darin Adler.
913
914         Introduce WTF_USE_EXPORT_MACROS, which will allow us to put shared library import/export
915         info into the headers rather than in export symbol definition files, but disable it on 
916         all platforms initially so we can deal with port build issues one port at a time.
917         
918         https://bugs.webkit.org/show_bug.cgi?id=27551
919
920         * DumpRenderTree/cg/ImageDiffCG.cpp:
921         * DumpRenderTree/chromium/config.h:
922         * DumpRenderTree/config.h:
923         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
924         * TestWebKitAPI/TestWebKitAPIPrefix.h:
925         * WebKitAPITest/HostWindow.cpp:
926         * WebKitAPITest/TestsController.cpp:
927         * WebKitAPITest/config.h: Added.
928         * WebKitAPITest/main.cpp:
929         * WebKitAPITest/tests/WebViewDestruction.cpp:
930         * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.cpp:
931         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
932         * WebKitTestRunner/InjectedBundle/GCController.cpp:
933         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
934         * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp:
935         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
936         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
937         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
938         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
939         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
940         * WebKitTestRunner/InjectedBundle/win/ActivateFonts.cpp:
941         * WebKitTestRunner/InjectedBundle/win/InjectedBundleWin.cpp:
942         * WebKitTestRunner/InjectedBundle/win/LayoutTestControllerWin.cpp:
943         * WebKitTestRunner/TestController.cpp:
944         * WebKitTestRunner/TestInvocation.cpp:
945         * WebKitTestRunner/config.h: Added.
946         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
947         * WebKitTestRunner/qt/TestControllerQt.cpp:
948         * WebKitTestRunner/qt/TestInvocationQt.cpp:
949         * WebKitTestRunner/qt/main.cpp:
950         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
951         * WebKitTestRunner/win/TestControllerWin.cpp:
952         * WebKitTestRunner/win/TestInvocationWin.cpp:
953         * WebKitTestRunner/win/main.cpp:
954         * wx/build/settings.py:
955
956 2011-03-15  Hayato Ito  <hayato@chromium.org>
957
958         Reviewed by Shinichiro Hamaji.
959
960         [NRWT] Add support for reftests to new-run-webkit-tests.
961
962         https://bugs.webkit.org/show_bug.cgi?id=55457
963
964         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
965         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
966         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
967         * Scripts/webkitpy/layout_tests/port/base.py:
968         * Scripts/webkitpy/layout_tests/port/dryrun.py:
969         * Scripts/webkitpy/layout_tests/port/test.py:
970         * Scripts/webkitpy/layout_tests/port/test_files.py:
971         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
972
973 2011-03-15  Alejandro G. Castro  <alex@igalia.com>
974
975         Reviewed by Martin Robinson.
976
977         [GTK] Fix compilation warning after r80892
978         https://bugs.webkit.org/show_bug.cgi?id=56302
979
980         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
981         (LayoutTestController::originsWithLocalStorage):
982
983 2011-03-15  Robert Hogan  <robert@webkit.org>
984
985         Reviewed by Adam Barth.
986
987         Document the qmakearg argument, and hint how to build webkit2 on Qt
988         https://bugs.webkit.org/show_bug.cgi?id=56326
989
990         * Scripts/build-webkit: add --qmakearg to build-webkit --help
991
992 2011-03-15  Adam Roben  <aroben@apple.com>
993
994         Make Windows 7 Release (Tests) a core builder
995
996         We can probably make Windows XP Debug (Tests) a core builder, too, but we should probably
997         give it a few more days of greenness first.
998
999         Fixes <http://webkit.org/b/55665> Windows 7 Release (Tests) should be a core builder
1000
1001         Reviewed by Sam Weinig.
1002
1003         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1004         (BuildBot): Added a regexp to match Windows 7 Release (Tests).
1005
1006         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1007         (BuildBotTest): Updated the list of builders to match the current list on build.webkit.org.
1008         Updated the core regexps to match the buildbot module. Updated the expected results to match
1009         the current set of core builders.
1010
1011 2011-03-14  Adam Roben  <aroben@apple.com>
1012
1013         Add forgotten file from r81116
1014
1015         * TestWebKitAPI/Configurations/TestWebKitAPICFNetwork.vsprops: Added.
1016
1017 2011-03-14  Sam Weinig  <sam@webkit.org>
1018
1019         Reviewed by Adam Roben.
1020
1021         about:blank fake responses don't get serialized when sent the UIProcess
1022         <rdar://problem/9108119>
1023         https://bugs.webkit.org/show_bug.cgi?id=56357
1024
1025         * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp: Added.
1026         (TestWebKitAPI::decidePolicyForResponse):
1027         (TestWebKitAPI::TEST):
1028         Add test that loads of about:blank have a response with a MIMEType of text/html.
1029
1030         * TestWebKitAPI/PlatformUtilities.h:
1031         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
1032         (TestWebKitAPI::Util::MIMETypeForWKURLResponse):
1033         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
1034         (TestWebKitAPI::Util::MIMETypeForWKURLResponse):
1035         Add helper to get the MIMEType from a WKURLResponse.
1036
1037         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1038         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1039         Add new files.
1040
1041 2011-03-14  Jarkko Sakkinen  <jarkko.j.sakkinen@gmail.com>
1042
1043         Reviewed by Kenneth Rohde Christiansen.
1044
1045         [Qt] Command-line options for QGLWidget and WebGL to QtTestBrowser
1046         https://bugs.webkit.org/show_bug.cgi?id=56006
1047
1048         * QtTestBrowser/launcherwindow.cpp:
1049         (LauncherWindow::initializeView):
1050         * QtTestBrowser/main.cpp:
1051         (LauncherApplication::handleUserOptions):
1052
1053 2011-03-14  James Kozianski  <koz@chromium.org>
1054
1055         Reviewed by Ojan Vafai.
1056
1057         Add method to make BuildBot return test outputs
1058         https://bugs.webkit.org/show_bug.cgi?id=54374
1059
1060         The Builder.latest_cached_build will be used by the new rebaseline
1061         script to determine the build to use baselines from.
1062
1063         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1064         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1065
1066 2011-03-14  Adam Roben  <aroben@apple.com>
1067
1068         Test that WKBundlePageCanHandleRequest returns true for empty document URLs
1069
1070         Reviewed by Sam Weinig.
1071
1072         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp: Added.
1073         (TestWebKitAPI::didReceiveMessageFromInjectedBundle): Store the result of the test.
1074         (TestWebKitAPI::setInjectedBundleClient): Hook up our callback.
1075         (TestWebKitAPI::TEST): Register "emptyscheme" as an empty document scheme, load a page to
1076         ensure the web process is initialized, then ask the bundle to run the test and assert that
1077         it succeeded.
1078
1079         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest_Bundle.cpp: Added.
1080         (TestWebKitAPI::CanHandleRequestTest::CanHandleRequestTest): Just call up to the base class.
1081         (TestWebKitAPI::canHandleURL): Helper function to test whether WebKit2 claims to be able to
1082         handle a given URL.
1083         (TestWebKitAPI::runTest): Check that empty document URLs can be handled (and that an unknown
1084         URL type cannot be handled).
1085         (TestWebKitAPI::CanHandleRequestTest::didReceiveMessage): Run the test and return the
1086         result.
1087
1088         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1089         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1090         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
1091         Added new files to the project.
1092
1093 2011-03-14  Sheriff Bot  <webkit.review.bot@gmail.com>
1094
1095         Unreviewed, rolling out r81094.
1096         http://trac.webkit.org/changeset/81094
1097         https://bugs.webkit.org/show_bug.cgi?id=56355
1098
1099         Broke the chromium DRT related build. (Requested by dave_levin
1100         on #webkit).
1101
1102         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1103         (main):
1104         * DumpRenderTree/chromium/LayoutTestController.cpp:
1105         (LayoutTestController::LayoutTestController):
1106         (LayoutTestController::layerTreeAsText):
1107         * DumpRenderTree/chromium/LayoutTestController.h:
1108         * DumpRenderTree/chromium/TestShell.cpp:
1109         (TestShell::runFileTest):
1110         (TestShell::dump):
1111         * DumpRenderTree/chromium/TestShell.h:
1112         (TestParams::TestParams):
1113
1114 2011-03-14  Daniel Sievers  <sievers@google.com>
1115
1116         Reviewed by Simon Fraser.
1117
1118         [Chromium] Make RenderAsTextBehavior and LayerTreeAsTextBehavior tweakable from the DumpRenderTree commandline
1119         https://bugs.webkit.org/show_bug.cgi?id=56139
1120
1121         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1122         (main):
1123         * DumpRenderTree/chromium/LayoutTestController.cpp:
1124         (LayoutTestController::LayoutTestController):
1125         (LayoutTestController::layerTreeAsText):
1126         * DumpRenderTree/chromium/LayoutTestController.h:
1127         (LayoutTestController::setShowDebugLayerTree):
1128         * DumpRenderTree/chromium/TestShell.cpp:
1129         (TestShell::runFileTest):
1130         (TestShell::dump):
1131         * DumpRenderTree/chromium/TestShell.h:
1132         (TestParams::TestParams):
1133
1134 2011-03-14  Balazs Kelemen  <kbalazs@webkit.org>
1135
1136         Reviewed by Adam Roben.
1137
1138         [Qt][WK2]Unbreak InjectedBundle on Qt
1139         https://bugs.webkit.org/show_bug.cgi?id=54109
1140
1141         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1142         (WTR::InjectedBundlePage::willSendRequestForFrame): Use new WebKit2
1143         API's instead of KURL to analyze the URL.
1144         * WebKitTestRunner/StringFunctions.h:
1145         (WTR::adoptWK): Moved from InjectedBundlePage.cpp to make it available globally
1146         in the WebKitTestRunner project.
1147         (WTR::toWK): Use adoptWK.
1148         (WTR::operator<<): Added helper for printing a WKURL.
1149         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Do not link
1150         against WebCore.
1151
1152 2011-03-14  Balazs Kelemen  <kbalazs@webkit.org>
1153
1154         Reviewed by Kenneth Rohde Christiansen.
1155
1156         check-webkit-style falsely should not complain about WebKit2 API headers in the Shared directory
1157         https://bugs.webkit.org/show_bug.cgi?id=56321
1158
1159         * Scripts/webkitpy/style/checker.py: Add the patch "Source/WebKit2/Shared/API/c"
1160         to the list of exceptions for WebKit2 C API headers.
1161
1162 2011-03-14  Adam Roben  <aroben@apple.com>
1163
1164         Show the list of recent leaky builds in reverse chronological order
1165
1166         Previously they were being shown in a deterministic but surprising order based on
1167         lexicographically sorting the build offsets (-1, -10, -2, -3...).
1168
1169         Fixes <http://webkit.org/b/56342> Leaks Viewer shows recent builds in a strange order
1170
1171         Reviewed by Darin Adler.
1172
1173         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
1174         (RecentBuildsLoader.prototype.start): Sort the builds by revision before passing them to our
1175         callback.
1176
1177 2011-03-14  Adam Roben  <aroben@apple.com>
1178
1179         Show a list of up to 10 recent leaky builds when Leaks Viewer loads
1180
1181         Fixes <http://webkit.org/b/56043> Leaks Viewer should present a list of recent builds to
1182         analyze
1183
1184         Reviewed by David Kilzer and Joe Pecoraro.
1185
1186         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
1187         (#url-prompt): Made this a bit taller to make room for the list of builds.
1188
1189         (#recent-builds-loading-indicator):
1190         (#recent-builds-list):
1191         Added styles for the build list and loading indicator.
1192
1193         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
1194         (LeaksViewer.loaded): Pass the URL from the query through decodeURIComponent before loading
1195         it. This will unescape it.
1196         (LeaksViewer.urlPromptButtonClicked): Moved code from here to _urlChosenFromPrompt.
1197         (LeaksViewer._didLoadRecentBuilds): Added. Stores the builds and updates the prompt.
1198         (LeaksViewer._displayURLPrompt): Start loading the recent leaky builds.
1199         (LeaksViewer._updateURLPrompt): Create a list of the recent leaky builds and add them to the
1200         prompt UI.
1201         (LeaksViewer._urlChosenFromPrompt): Added. Code came from urlPromptButtonClicked. This is
1202         now also used when a recent build is clicked.
1203
1204         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js: Added.
1205         (RecentBuildsLoader): Store the callback.
1206         (RecentBuildsLoader.prototype.start): Load the N most recent builds from the specified
1207         builder. Find the revision number, leak count, and results URL for each one. Pass the
1208         resulting info to our callback.
1209
1210         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Utilities.js:
1211         (range): Added this helper function to return an array containing the integers [0, n).
1212
1213         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html: Added
1214         RecentBuildsLoader.js and added text to the prompt UI to show the recent builds.
1215
1216 2011-03-14  Mark Rowe  <mrowe@apple.com>
1217
1218         Reviewed by Adam Roben.
1219
1220         Fix two memory leaks within LayoutTestController's storage support.
1221
1222         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1223         (LayoutTestController::originsWithLocalStorage): Don't leak the JSStringRef that is returned
1224         by JSStringCreateWithCFString.
1225         (LayoutTestController::deleteLocalStorageForOrigin): Don't leak the WebSecurityOrigin that we
1226         allocate.
1227
1228 2011-03-14  Mark Rowe  <mrowe@apple.com>
1229
1230         Reviewed by Oliver Hunt.
1231
1232         <http://webkit.org/b/56304> REGRESSION(r80892): 100,000+ leaks seen on the build bot
1233
1234         * DumpRenderTree/LayoutTestController.cpp:
1235         (LayoutTestController::staticFunctions): Remove duplicate entries.
1236
1237 2011-03-14  Alice Liu  <alice.liu@apple.com>
1238
1239         Reviewed by Dan Bernstein.
1240
1241         DumpRenderTree Perl Support fails to build with ARCHS="i386 x86_64"
1242
1243         * DumpRenderTree/mac/PerlSupport/Makefile:
1244         Add whitespace when joining "-arch" with the architectures passed in as arguments.
1245
1246 2011-03-14  Daniel Bates  <dbates@rim.com>
1247
1248         https://bugs.webkit.org/show_bug.cgi?id=55438
1249         Add double quotes around value of -DCMAKE_WINCE_SDK that I inadvertently did not add
1250         when landing changeset 81041 <http://trac.webkit.org/changeset/81041>.
1251
1252         * Scripts/build-webkit:
1253
1254 2011-03-14  Daniel Bates  <dbates@rim.com>
1255
1256         Reviewed by David Kilzer.
1257
1258         Cleanup: Separate port-specific implementation details from webkitdirs::buildCMakeProject()
1259         https://bugs.webkit.org/show_bug.cgi?id=55438
1260
1261         Separate out the EFL- and WinCE-specific logic from the port-independent logic in
1262         webkitdirs::buildCMakeProject(). Also, remove redundant code for generating the
1263         CMake arguments for feature defines.
1264
1265         * Scripts/build-webkit:
1266           - Added cMakeArgsFromFeatures() to convert the @features array to CMake arguments.
1267           - Modified EFL and WinCE-specific building logic to call buildCMakeProjectOrExit().
1268           - Sorted forward declarations.
1269           - Initialize $makeArgs with the empty string so as to simplify its use in string operations;
1270             Modified call sites as needed.
1271         * Scripts/webkitdirs.pm:
1272           - Added cleanCMakeGeneratedProject() to clean a CMake build.
1273           - Added buildCMakeGeneratedProject() to build using generated build system.
1274           - Added buildCMakeProjectOrExit() which is a facade for building a CMake project.
1275           - Added generateBuildSystemFromCMakeProject() to generate the build system from
1276             a CMake project.
1277           - Removed buildCMakeProject(). This functionality is in buildCMakeProjectOrExit().
1278
1279 2011-03-14  John Knottenbelt  <jknotten@chromium.org>
1280
1281         Reviewed by Steve Block.
1282
1283         Detach Geolocation from Frame when Page destroyed.
1284         https://bugs.webkit.org/show_bug.cgi?id=52877
1285
1286         Extend the layout test controller to expose the number of pending
1287         geolocation requests, so that we can test that the requests have
1288         been cancelled on page close.
1289
1290         * DumpRenderTree/LayoutTestController.cpp:
1291         (numberOfPendingGeolocationPermissionRequestsCallback):
1292         (LayoutTestController::staticFunctions):
1293         * DumpRenderTree/LayoutTestController.h:
1294         * DumpRenderTree/chromium/LayoutTestController.cpp:
1295         (LayoutTestController::LayoutTestController):
1296         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
1297         * DumpRenderTree/chromium/LayoutTestController.h:
1298         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1299         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
1300         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1301         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
1302         * DumpRenderTree/mac/UIDelegate.h:
1303         * DumpRenderTree/mac/UIDelegate.mm:
1304         (-[UIDelegate numberOfPendingGeolocationPermissionRequests]):
1305         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1306         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
1307         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1308         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1309         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
1310         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1311         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
1312
1313
1314 2011-03-14  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1315
1316         Unreviewed. Modify my email address in committers.py.
1317
1318         * Scripts/webkitpy/common/config/committers.py:
1319
1320 2011-03-13  Joe Wild  <joseph.wild@nokia.com>
1321
1322         Reviewed by Kenneth Rohde Christiansen.
1323
1324         [Qt] QtLauncher does not load the same set of fonts as the DRT
1325         https://bugs.webkit.org/show_bug.cgi?id=34959
1326
1327         This patch adds the option "-use-test-fonts" to the QtTestBrowser.
1328         When this option is used the webkit fonts are loaded the same
1329         as they are in DumpRenderTree.  This option can be used on
1330         QtTestBrowser and run-launcher.  It can only be used
1331         on Linux systems with FcInit and is configured as such.
1332
1333         * QtTestBrowser/launcherwindow.h:
1334         (WindowOptions::WindowOptions):
1335         * QtTestBrowser/main.cpp:
1336         (initWebKitTestFonts):
1337         (launcherMain):
1338         (LauncherApplication::handleUserOptions):
1339
1340 2011-03-12  Dan Bernstein  <mitz@apple.com>
1341
1342         Reviewed by Mark Rowe.
1343
1344         <rdar://problem/8995822> Build DumpRenderTree perl support only for the architectures
1345         DumpRenderTree is being built for.
1346
1347         * DumpRenderTree/mac/PerlSupport/Makefile:
1348
1349 2011-03-12  Dan Bernstein  <mitz@apple.com>
1350
1351         Suggested by Mark Rowe.
1352
1353         * DumpRenderTree/mac/Configurations/Base.xcconfig: Leave C++ exceptions enabled
1354         as they were before r80915.
1355
1356 2011-03-12  Anders Carlsson  <andersca@apple.com>
1357
1358         Reviewed by Sam Weinig.
1359
1360         Should be able to download a PDF to the Downloads folder
1361         https://bugs.webkit.org/show_bug.cgi?id=56256
1362
1363         * MiniBrowser/mac/BrowserWindowController.m:
1364         (-[BrowserWindowController awakeFromNib]):
1365         * WebKitTestRunner/TestController.cpp:
1366         (WTR::TestController::createOtherPage):
1367         (WTR::TestController::initialize):
1368         Update for API changes.
1369
1370 2011-03-11  Anton D'Auria  <adauria@apple.com>
1371
1372         Reviewed and landed by Brady Eidson.
1373
1374         https://bugs.webkit.org/show_bug.cgi?id=51878
1375         Add WebKit1 API to view and delete local storage
1376
1377         Added tests that write to LocalStorage, delete one origin, get list of origins with local storage, delete all origins.
1378
1379         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1380         * DumpRenderTree/LayoutTestController.cpp:
1381         (syncLocalStorageCallback):
1382         (observeStorageTrackerNotificationsCallback):
1383         (deleteAllLocalStorageCallback):
1384         (deleteLocalStorageForOriginCallback):
1385         (originsWithLocalStorageCallback):
1386         (LayoutTestController::staticFunctions):
1387         * DumpRenderTree/LayoutTestController.h:
1388         * DumpRenderTree/StorageTrackerDelegate.h: Added.
1389         * DumpRenderTree/StorageTrackerDelegate.mm: Added.
1390         (-[StorageTrackerDelegate init]):
1391         (-[StorageTrackerDelegate logNotifications:controller:]):
1392         (-[StorageTrackerDelegate originModified:]):
1393         (-[StorageTrackerDelegate dealloc]):
1394         (-[StorageTrackerDelegate setControllerToNotifyDone:]):
1395         * DumpRenderTree/chromium/LayoutTestController.cpp:
1396         (LayoutTestController::LayoutTestController):
1397         (LayoutTestController::deleteAllLocalStorage):
1398         (LayoutTestController::originsWithLocalStorage):
1399         (LayoutTestController::deleteLocalStorageForOrigin):
1400         (observeStorageTrackerNotifications):
1401         (syncLocalStorage):
1402         * DumpRenderTree/chromium/LayoutTestController.h:
1403         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1404         (LayoutTestController::originsWithLocalStorage):
1405         (LayoutTestController::deleteAllLocalStorage):
1406         (LayoutTestController::deleteLocalStorageForOrigin):
1407         (LayoutTestController::observeStorageTrackerNotifications):
1408         (LayoutTestController::syncLocalStorage):
1409         * DumpRenderTree/mac/DumpRenderTree.mm:
1410         (resetDefaultsToConsistentValues):
1411         (allocateGlobalControllers):
1412         (releaseGlobalControllers):
1413         * DumpRenderTree/mac/DumpRenderTreeMac.h:
1414         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1415         (LayoutTestController::syncLocalStorage):
1416         (LayoutTestController::observeStorageTrackerNotifications):
1417         (LayoutTestController::deleteAllLocalStorage):
1418         (LayoutTestController::originsWithLocalStorage):
1419         (LayoutTestController::deleteLocalStorageForOrigin):
1420         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1421         (LayoutTestController::originsWithLocalStorage):
1422         (LayoutTestController::deleteAllLocalStorage):
1423         (LayoutTestController::deleteLocalStorageForOrigin):
1424         (LayoutTestController::observeStorageTrackerNotifications):
1425         (LayoutTestController::syncLocalStorage):
1426         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1427         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1428         (LayoutTestController::clearAllApplicationCaches):
1429         (LayoutTestController::syncLocalStorage):
1430         (LayoutTestController::observeStorageTrackerNotifications):
1431         (LayoutTestController::clearAllDatabases):
1432         (LayoutTestController::deleteAllLocalStorage):
1433         (LayoutTestController::originsWithLocalStorage):
1434         (LayoutTestController::deleteLocalStorageForOrigin):
1435         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1436         (LayoutTestController::syncLocalStorage):
1437         (LayoutTestController::observeStorageTrackerNotifications):
1438         (LayoutTestController::clearAllDatabases):
1439         (LayoutTestController::deleteAllLocalStorage):
1440         (LayoutTestController::originsWithLocalStorage):
1441         (LayoutTestController::deleteLocalStorageForOrigin):
1442
1443 2011-03-11  Jessie Berlin  <jberlin@apple.com>
1444
1445         Reviewed by Adam Roben.
1446
1447         Crash calling WebContext::clearResourceCaches(InMemoryResourceCachesOnly) before the Web
1448         Process has finished launching.
1449         https://bugs.webkit.org/show_bug.cgi?id=56208
1450
1451         * TestWebKitAPI/Tests/WebKit2/SendingMessagesToTheWebProcessBeforeItIsValid.cpp: Added.
1452         (TestWebKitAPI::TEST):
1453         Test that calling WKContextClearResourceCaches works with both options when called before
1454         the Web Process is valid.
1455
1456         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1457         Add the new test.
1458         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1459         Ditto.
1460
1461 2011-03-11  Adam Roben  <aroben@apple.com>
1462
1463         Make it possible to view all leaks from a build at once in Leaks Viewer
1464
1465         You can now give Leaks Viewer the URL of a build results page (e.g.,
1466         <http://build.webkit.org/results/SnowLeopard%20Intel%20Leaks/r80847%20(15493)/>), and it
1467         will load all the leaks files from that build.
1468
1469         Fixes <http://webkit.org/b/56030> Leaks Viewer: Would like to be able to look at all leaks
1470         files from a particular build at once, rather than one at a time
1471
1472         Reviewed by David Kilzer.
1473
1474         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksLoader.js: Added.
1475         (LeaksLoader): Initialize our properties.
1476         (LeaksLoader.prototype.start): If the URL ends in .txt, assume it's a single leaks file and
1477         load it. Otherwise assume it's a build results page URL and start fetching the leaks files
1478         from that page.
1479         (LeaksLoader.prototype._loadLeaksFiles): Tell our client how many leaks files we're loading
1480         so it can provide feedback. Then load each one and pass it to the client.
1481         (LeaksLoader.prototype._loadLeaksFromResultsPage): Load the HTML of the results page, parse
1482         it into a DOM, pull out all the links to leaks files, and load each one.
1483
1484         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParser.js: Added.
1485         (LeaksParser): Initialize our worker.
1486         (LeaksParser.prototype.addLeaksFile): Tell the worker about the leaks file's contents.
1487
1488         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js: Added.
1489         This code mostly came from Worker.js.
1490         (LeaksParserWorker): Initialize our profile.
1491         (LeaksParserWorker.prototype.addLeaksFile): Parse the leaks file and incorporate it into our
1492         profile.
1493         (LeaksParserWorker.prototype._parseLeaks):
1494         (LeaksParserWorker.prototype._createNode):
1495         (LeaksParserWorker.prototype._incorporateLeaks):
1496         Moved these functions here from LeaksViewer. _incorporateLeaks is essentially just a renamed
1497         version of createProfile which adds to this.profile instead of making a new profile each
1498         time.
1499         (onmessage): Parse the file and send back the new profile.
1500
1501         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
1502         (#loading-indicator):
1503         (#spinner):
1504         (#loading-indicator-label):
1505         Tweaked styles to accomodate a longer label.
1506
1507         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
1508         (LeaksViewer.loaded): Set up a loader and parser.
1509
1510         (LeaksViewer.get filesLeftToParse):
1511         (LeaksViewer.set filesLeftToParse):
1512         Added these simple accessors.
1513
1514         (LeaksViewer._didCountLeaksFiles): Callback from LeaksLoader. Stores the count.
1515         (LeaksViewer._didLoadLeaksFile): Callback from LeaksLoader. Passes the file contents off to
1516         the parser.
1517         (LeaksViewer._didParseLeaksFile): Callback from LeaksParser. If all files have been parsed,
1518         tell the ProfilerAgent and mark that we're done loading. (Code came from the old
1519         _loadLeaksFromURL function).
1520         (LeaksViewer._loadLeaksFromURL): Now just calls through to the loader.
1521         (LeaksViewer._loadingIndicatorText): Added. Returns the text that should show up in the
1522         loading indicator, including the number of files being loaded.
1523         (LeaksViewer._loadingStatusChanged): Update the loading indicator's label, too.
1524         (LeaksViewer._updateLoadingIndicatorLabel): Added. Just updates the label!
1525         (LeaksViewer._updateTitle): Moved code to compute the "Loading" text to
1526         _loadingIndicatorText.
1527
1528         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Utilities.js: Added.
1529         (getResource): Moved here from LeaksViewer.js.
1530
1531         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Worker.js: Subsumed by
1532         LeaksParserWorker.js.
1533
1534         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html: Added new JS
1535         files, added a #loading-indicator-label element, and tweaked the prompt wording.
1536
1537 2011-03-11  Adam Roben  <aroben@apple.com>
1538
1539         Don't trigger a build when build.webkit.org's HTML files are modified
1540
1541         Fixes <http://webkit.org/b/56190> Windows bots shouldn't have built r80848/r80851, but did
1542
1543         Reviewed by Dan Bernstein.
1544
1545         * Scripts/webkitpy/common/config/build.py:
1546         (_should_file_trigger_build): Added build.webkit.org's public_html directory to the list of
1547         directories that shouldn't trigger builds. Re-sorted the list.
1548
1549         * Scripts/webkitpy/common/config/build_unittest.py:
1550         (ShouldBuildTest): Added a test to cover the above change.
1551
1552 2011-03-11  Adam Roben  <aroben@apple.com>
1553
1554         Roll out r80848
1555
1556         It was accidentally committed.
1557
1558         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
1559         (LeaksViewer._loadLeaksFromURL):
1560
1561 2011-03-11  Tony Chang  <tony@chromium.org>
1562
1563         Reviewed by Ojan Vafai.
1564
1565         kill hung lighttpd processes on the chromium win bot
1566         https://bugs.webkit.org/show_bug.cgi?id=56152
1567
1568         Sometimes this process doesn't exit and it holds on to
1569         a log file that we can't delete or copy, causing the tests
1570         to go red.
1571
1572         * BuildSlaveSupport/win/kill-old-processes:
1573
1574 2011-03-11  Ilya Sherman  <isherman@chromium.org>
1575
1576         Reviewed by Kent Tamura.
1577
1578         [Chromium] missing HTMLInputElement::setValueForUser() to tests
1579         https://bugs.webkit.org/show_bug.cgi?id=55854
1580
1581         * DumpRenderTree/chromium/LayoutTestController.cpp:
1582         (LayoutTestController::LayoutTestController):
1583         (LayoutTestController::setValueForUser): Added.
1584         * DumpRenderTree/chromium/LayoutTestController.h:
1585
1586 2011-03-10  Peter Kasting  <pkasting@google.com>
1587
1588         Reviewed by Dimitri Glazkov.
1589
1590         Clean up some gross code in TestShellWin.cpp.  No functional change.
1591         https://bugs.webkit.org/show_bug.cgi?id=56048
1592
1593         * DumpRenderTree/chromium/TestShellWin.cpp:
1594         (checkLayoutTestSystemDependencies):
1595
1596 2011-03-10  Keith Kyzivat  <keith.kyzivat@nokia.com>
1597
1598         Reviewed by Laszlo Gombos.
1599
1600         [Qt] Buildfix for platforms where X11 is not available (e.g. Symbian)
1601
1602         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
1603         (WTR::activateFonts): Guard X11-specific code with Q_WS_X11.
1604
1605 2011-03-10  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1606
1607         Reviewed by Kenneth Rohde Christiansen.
1608
1609         [EFL] Make single backing store the default for EWebLauncher
1610         https://bugs.webkit.org/show_bug.cgi?id=55753
1611
1612         Set single backing store the default for EWebLauncher.
1613
1614         * EWebLauncher/main.c:
1615         (main):
1616
1617 2011-03-10  Adam Roben  <aroben@apple.com>
1618
1619         Ignore errors from files being held open when creating a test result archive
1620
1621         Fixes <http://webkit.org/b/55581> Test results don't get uploaded if test-result-archive
1622         fails to delete the results directory
1623
1624         Reviewed by Mark Rowe.
1625
1626         * BuildSlaveSupport/test-result-archive:
1627         (archiveTestResults): Ignore errno 2 when deleting the results directory, since it can be
1628         thrown when a process is holding a file open.
1629
1630 2011-03-10  Sheriff Bot  <webkit.review.bot@gmail.com>
1631
1632         Unreviewed, rolling out r80701.
1633         http://trac.webkit.org/changeset/80701
1634         https://bugs.webkit.org/show_bug.cgi?id=56126
1635
1636         fast/dom/Geolocation/window-close-crash.html fails on Snow
1637         Leopard release builds (Requested by mihaip on #webkit).
1638
1639         * DumpRenderTree/LayoutTestController.cpp:
1640         (LayoutTestController::staticFunctions):
1641         * DumpRenderTree/LayoutTestController.h:
1642         * DumpRenderTree/chromium/LayoutTestController.cpp:
1643         (LayoutTestController::LayoutTestController):
1644         * DumpRenderTree/chromium/LayoutTestController.h:
1645         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1646         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1647         * DumpRenderTree/mac/UIDelegate.h:
1648         * DumpRenderTree/mac/UIDelegate.mm:
1649         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1650         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1651         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1652         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1653
1654 2011-03-10  Philippe Normand  <pnormand@igalia.com>
1655
1656         Reviewed by Gustavo Noronha Silva.
1657
1658         [GTK] run-gtk-tests doesn't fail if a test crashes
1659         https://bugs.webkit.org/show_bug.cgi?id=56089
1660
1661         * Scripts/run-gtk-tests: gtester -k exits with a 0 exit status
1662         even if a test crashes. So run the tests individually and if a
1663         test fails remember its exit code so run-gtk-test fails too, if
1664         required.
1665
1666 2011-01-26  John Knottenbelt  <jknotten@chromium.org>
1667
1668         Reviewed by Dmitry Titov.
1669
1670         Detach Geolocation from Frame when Page destroyed.
1671         https://bugs.webkit.org/show_bug.cgi?id=52877
1672
1673         Extend the layout test controller to expose the number of pending
1674         geolocation requests, so that we can test that the requests have
1675         been cancelled on page close.
1676
1677         * DumpRenderTree/LayoutTestController.cpp:
1678         (numberOfPendingGeolocationPermissionRequestsCallback):
1679         (LayoutTestController::staticFunctions):
1680         * DumpRenderTree/LayoutTestController.h:
1681         * DumpRenderTree/chromium/LayoutTestController.cpp:
1682         (LayoutTestController::LayoutTestController):
1683         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
1684         * DumpRenderTree/chromium/LayoutTestController.h:
1685         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1686         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
1687         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1688         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
1689         * DumpRenderTree/mac/UIDelegate.h:
1690         * DumpRenderTree/mac/UIDelegate.mm:
1691         (-[UIDelegate numberOfPendingGeolocationPermissionRequests]):
1692         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1693         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
1694         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1695         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1696         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
1697         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1698         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
1699
1700
1701 2011-03-09  Adam Roben  <aroben@apple.com>
1702
1703         Hide Leaks Viewer's URL prompt by default
1704
1705         We will show it as needed. I think I left it visible by default by accident after doing some
1706         testing.
1707
1708         Fixes <http://webkit.org/b/56031> Leaks Viewer: URL prompt overlay shouldn't appear when a
1709         URL is passed as a query parameter, but does
1710
1711         Reviewed by Simon Fraser.
1712
1713         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html:
1714
1715 2011-03-09  Adam Roben  <aroben@apple.com>
1716
1717         Don't use Element.classList or box-shadow in Leaks Viewer
1718
1719         They aren't supported by Safari 5. Luckily we have substitutes for them!
1720
1721         Fixes <http://webkit.org/b/56035> Leaks viewer doesn't work in Safari 5
1722
1723         Reviewed by Simon Fraser.
1724
1725         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
1726         (#url-prompt): Use -webkit-box-shadow instead of box-shadow.
1727
1728         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
1729         (LeaksViewer.urlPromptButtonClicked):
1730         (LeaksViewer._displayURLPrompt):
1731         (LeaksViewer._setLoadingIndicatorHidden):
1732         Use add/removeStyleClass (from utilities.js) instead of Element.classList.
1733
1734 2011-03-09  Adam Roben  <aroben@apple.com>
1735
1736         Add a link to the Leaks Viewer tool on the build.webkit.org homepage
1737
1738         Rubber-stamped by David Kilzer.
1739
1740         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
1741
1742 2011-03-09  Adam Roben  <aroben@apple.com>
1743
1744         Add a Leaks Viewer tool to build.webkit.org
1745
1746         This tool parses leaks from the files generated by the leaks bot and displays them in a
1747         view similar to the Web Inspector's Profiles pane (in fact, it uses the Web Inspector's
1748         code).
1749
1750         The URL of the leaks file can be entered in a prompt when the tools is first shown, or can
1751         be passed to the tool via the "url" query parameter.
1752
1753         Only one leaks file can be viewed at a time for now. Only the number of leaks, as opposed to
1754         the number of leaked bytes, is shown. And this tool has made apparent some bugs in the Web
1755         Inspector's Heavy profile view. But it's still pretty useful as-is.
1756
1757         Fixes <http://webkit.org/b/56028> Would like a Shark-like tool for viewing leaks from leak bots
1758
1759         Reviewed by Darin Adler.
1760
1761         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css: Added.
1762         (#url-prompt-container): This is the dark overlay that is shown behind the URL prompt.
1763         (#url-prompt): This is the prompt itself.
1764
1765         (#loading-indicator):
1766         (#loading-indicator > img):
1767         These show a spinner in the bottom-right when we're loading a leaks file.
1768
1769         (.percent-time-status-bar-item): Hide the Percent button since we never want to show leaks
1770         as percentages.
1771
1772         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js: Added.
1773         (LeaksViewer.loaded): Initialize ourselves and start loading the leaks file (or prompt for a
1774         URL if one wasn't given to us as a query parameter).
1775
1776         (LeaksViewer.get loading):
1777         (LeaksViewer.set loading):
1778         (LeaksViewer.get url):
1779         (LeaksViewer.set url):
1780         Pretty simple accessors.
1781
1782         (LeaksViewer.urlPromptButtonClicked): Start loading the URL from the prompt and hide the
1783         prompt.
1784         (LeaksViewer._displayURLPrompt): Show the prompt and focus the URL input.
1785         (LeaksViewer._loadLeaksFromURL): Start fetching the leaks file. When we've retrieved the
1786         file, hand it off to a Web Worker that will parse it into a fake "profile", then hand off
1787         the profile to the Web Inspector code once it's been created.
1788         (LeaksViewer._loadingStatusChanged): Update our loading indicator and title.
1789         (LeaksViewer._setLoadingIndicatorHidden): Simply hide or show the indicator.
1790         (LeaksViewer._updateTitle): Set our title based on our URL and loading status.
1791         (getResource): Helper function to fetch a resource via XHR and pass it to a callback.
1792
1793         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js: Added.
1794         (WebInspector.UIString): Just a simple implementation since this tool isn't localized.
1795         (ProfilerAgent.getProfile): Store the callback.
1796         (ProfilerAgent.profileReady): Call the callback.
1797         (monkeyPatchInspectorObjects): Fix up WebInspector.ProfileDataGridNode to show the self leak
1798         count and total leak counts as real values, not percentages or milliseconds.
1799
1800         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Worker.js: Added.
1801         (onmessage): Create a profile based on the leaks file and pass it back to our caller.
1802         (parseLeaks): Extract call stacks out of a leaks file.
1803         (createNode): Helper function to create a new empty profile node.
1804         (createProfile): Take the leak stacks and turn them into a fake "profile" for consumption by
1805         WebInspector.ProfileView.
1806
1807         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html: Added.
1808
1809 2011-03-09  Dan Bernstein  <mitz@apple.com>
1810
1811         Reviewed by Adam Roben.
1812
1813         Combine multiple --ignore-tests values
1814         https://bugs.webkit.org/show_bug.cgi?id=56016
1815
1816         * Scripts/old-run-webkit-tests:
1817
1818 2011-03-08  Kenji Imasaki  <imasaki@chromium.org>
1819
1820         Reviewed by David Levin.
1821
1822         Adding myself to the committer file.
1823
1824         * Scripts/webkitpy/common/config/committers.py:
1825
1826 2011-03-08  Jessie Berlin  <jberlin@apple.com>
1827
1828         Rubber-stamped by Adam Roben.
1829
1830         Fix two leaks I introduced into the API tests.
1831
1832         * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp:
1833         (TestWebKitAPI::TEST):
1834
1835 2011-03-08  Jessie Berlin  <jberlin@apple.com>
1836
1837         Reviewed by Anders Carlsson.
1838
1839         Crash in CFNetwork visiting google.com
1840         https://bugs.webkit.org/show_bug.cgi?id=55958
1841
1842         Add a test for not trying to copy a null CFURLResponse.
1843
1844         * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp: Added.
1845         (TestWebKitAPI::TEST):
1846         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1847
1848 2011-03-08  Hayato Ito  <hayato@chromium.org>
1849
1850         Reviewed by Ojan Vafai.
1851
1852         [NRWT] Renamed a FailureWithType class to a ComparisonTestFailure class.
1853
1854         FailureWithType is a confusing naming because we have removed test_type/* classes in r79840.
1855
1856         https://bugs.webkit.org/show_bug.cgi?id=55450
1857
1858         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1859
1860 2011-03-08  Carlos Garcia Campos  <cgarcia@igalia.com>
1861
1862         Reviewed by Martin Robinson.
1863
1864         [GTK] Add layoutTestController.setValueForUser() after r80412
1865         https://bugs.webkit.org/show_bug.cgi?id=55862
1866
1867         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1868         (LayoutTestController::setValueForUser): Implement setValueForUser()
1869
1870 2011-03-08  Patrick Gansterer  <paroga@webkit.org>
1871
1872         Reviewed by Adam Barth.
1873
1874         Add script_shell_command to WebKitPort
1875         https://bugs.webkit.org/show_bug.cgi?id=55925
1876
1877         Add a central place where we generate the shell command from the script name.
1878         This function will be used later to detect the correct script interpreter on Win32.
1879
1880         * Scripts/webkitpy/common/config/ports.py:
1881         * Scripts/webkitpy/layout_tests/port/base.py:
1882         * Scripts/webkitpy/tool/steps/abstractstep.py:
1883         * Scripts/webkitpy/tool/steps/preparechangelog.py:
1884
1885 2011-03-07  Ojan Vafai  <ojan@chromium.org>
1886
1887         Reviewed by Adam Barth.
1888
1889         add webkit-patch attach-to-bug for posting to bugzilla from the commandline
1890         https://bugs.webkit.org/show_bug.cgi?id=55749
1891
1892         * Scripts/webkitpy/tool/commands/upload.py:
1893         * Scripts/webkitpy/tool/commands/upload_unittest.py:
1894         * Scripts/webkitpy/tool/steps/__init__.py:
1895         * Scripts/webkitpy/tool/steps/attachtobug.py: Added.
1896         * Scripts/webkitpy/tool/steps/options.py:
1897
1898 2011-03-07  Daniel Cheng  <dcheng@chromium.org>
1899
1900         Reviewed by David Levin.
1901
1902         Add support for DataTransferItems
1903         https://bugs.webkit.org/show_bug.cgi?id=55115
1904
1905         Enable data transfer items in DRT.
1906
1907         * DumpRenderTree/chromium/TestShell.cpp:
1908         (TestShell::TestShell):
1909
1910 2011-03-06  Ojan Vafai  <ojan@chromium.org>
1911
1912         Reviewed by Tony Chang.
1913
1914         [test dashboard] pull treemap files
1915         https://bugs.webkit.org/show_bug.cgi?id=55852
1916
1917         * TestResultServer/handlers/dashboardhandler.py:
1918
1919 2011-03-03  Hayato Ito  <hayato@chromium.org>
1920
1921         Reviewed by Mihai Parparita.
1922
1923         [NRWT] Clear output image file used by DumpRenderTree to make sure the
1924         previous image should not be used in the ChromiumDriver.
1925
1926         Also make sure that output image from the ChromiumDriver should be ''
1927         (empty string) if a test crashes for consistency with the WebKitDriver
1928         implementation.
1929
1930         https://bugs.webkit.org/show_bug.cgi?id=55746
1931
1932         * Scripts/webkitpy/layout_tests/port/chromium.py:
1933
1934 2011-03-07  Zan Dobersek  <zandobersek@gmail.com>
1935
1936         Reviewed by Martin Robinson.
1937
1938         [Gtk] fast/js/navigator-language.html fails locally
1939         https://bugs.webkit.org/show_bug.cgi?id=55880
1940
1941         Add LANG variable to the clean environment when running
1942         old-run-webkit-tests script.
1943
1944         * Scripts/old-run-webkit-tests:
1945
1946 2011-03-07  Tony Chang  <tony@chromium.org>
1947
1948         Reviewed by Mihai Parparita.
1949
1950         [Chromium] Find .checksum files without .pngs and vice-versa
1951         https://bugs.webkit.org/show_bug.cgi?id=55236
1952
1953         * Scripts/find-mismatched-layout-test-results: Added. A script for finding
1954             mismatched results.
1955
1956 2011-03-07  Chris Fleizach  <cfleizach@apple.com>
1957
1958         Reviewed by Beth Dakin.
1959
1960         AX: WK1 needs to use the ScrollView attachment for AXScrollArea, WK2 should not use this element.
1961         https://bugs.webkit.org/show_bug.cgi?id=55706
1962
1963         The rootElement in DRT should point to the scroll view. In WK1, that will be the parent of the rootObject.
1964
1965         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
1966         (AccessibilityController::focusedElement):
1967            Remove FIXME comment about caching the focusedElement. In fact, we shouldn't cache this 
1968            because it could change at any time.
1969         (AccessibilityController::rootElement):
1970
1971 2011-03-07  Sam Weinig  <sam@webkit.org>
1972
1973         Reviewed by Anders Carlsson.
1974
1975         Add unableToImplementPolicy callback for WebKit2 policy client
1976         <rdar://problem/9071902>
1977         https://bugs.webkit.org/show_bug.cgi?id=55884
1978
1979         * MiniBrowser/mac/BrowserWindowController.m:
1980         (-[BrowserWindowController awakeFromNib]):
1981         Update policy client initialization struct for new member.
1982
1983 2011-03-07  Sam Weinig  <sam@webkit.org>
1984
1985         Reviewed by Anders Carlsson.
1986
1987         Replace WebKit2's decidePolicyForMIMEType with decidePolicyForResponse
1988         https://bugs.webkit.org/show_bug.cgi?id=55827
1989
1990         * MiniBrowser/mac/BrowserWindowController.m:
1991         (decidePolicyForResponse):
1992         (-[BrowserWindowController awakeFromNib]):
1993         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
1994         (TestWebKitAPI::decidePolicyForResponse):
1995         (TestWebKitAPI::TEST):
1996         Update tools for new name.
1997
1998 2011-03-06  Daniel Bates  <dbates@rim.com>
1999
2000         Reviewed by Eric Seidel and David Kilzer.
2001
2002         Fix misspelled word in build-webkit's checkForJavaSDK() and sort forward declarations
2003         https://bugs.webkit.org/show_bug.cgi?id=55503
2004
2005         Fix misspelled word "Dowloads" [sic] in the message printed to standard output
2006         in checkForJavaSDK().
2007
2008         Also, remove extraneous space in function prototype for unlinkZeroFiles.
2009
2010         * Scripts/build-webkit:
2011
2012 2011-03-05  Brian Weinstein  <bweinstein@apple.com>
2013
2014         Reviewed by Sam Weinig.
2015
2016         Fix Web Process crashes caused by https://bugs.webkit.org/show_bug.cgi?id=53919.
2017
2018         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2019         (WTR::InjectedBundlePage::willSendRequestForFrame): Retain the WKURLRequestRef returned
2020             by willSendRequestForFrame. The API expects a retained reference to the URL request.
2021
2022 2011-03-05  Ilya Sherman  <isherman@chromium.org>
2023
2024         Reviewed by Darin Adler.
2025
2026         HTMLInputElement::setValue() should schedule change event when the element is focused
2027         In service of https://code.google.com/p/chromium/issues/detail?id=42716
2028         https://bugs.webkit.org/show_bug.cgi?id=53160
2029
2030         * DumpRenderTree/LayoutTestController.cpp:
2031         (setValueForUserCallback):
2032         (LayoutTestController::staticFunctions):
2033         * DumpRenderTree/LayoutTestController.h:
2034         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2035         (LayoutTestController::setValueForUser): Stubbed out; need real implementation.
2036         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2037         (LayoutTestController::setValueForUser): Expose HTMLInputElement::setValueForUser() to tests
2038         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2039         (LayoutTestController::setValueForUser): Stubbed out; need real implementation.
2040         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2041         (LayoutTestController::setValueForUser): Stubbed out; need real implementation.
2042         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2043         (LayoutTestController::setValueForUser): Stubbed out; need real implementation.
2044
2045 2011-03-04  Mark Rowe  <mrowe@apple.com>
2046
2047         Reviewed by Alexey Proskuryakov.
2048
2049         <rdar://problem/9055252> DumpRenderTree is crashing with GuardMalloc
2050
2051         GuardMalloc does not expect the memory containing its malloc_zone_t to ever be read-only.
2052         
2053         * DumpRenderTree/mac/CheckedMalloc.cpp:
2054         (protectionOfRegion): Retrieve the protection flags for the VM region containing the given address.
2055         (makeLargeMallocFailSilently): Save the initial protection flags, temporarily make the region writeable,
2056         and then restore the initial protection flags when we're done.
2057
2058 2011-03-04  Evan Martin  <evan@chromium.org>
2059
2060         Reviewed by Tony Chang.
2061
2062         [gdb] pretty-print KURL in gdb
2063         https://bugs.webkit.org/show_bug.cgi?id=55788
2064
2065         * gdb/webkit.py: extend the pretty-printers to print WTF::CString
2066         and KURLGooglePrivate.  As always, "p/r" can be used to sidestep
2067         pretty-printing.
2068
2069 2011-03-03  Timothy Hatcher  <timothy@apple.com>
2070
2071         Update the tests that use WKPageRunJavaScriptInMainFrame use the WKSerializedScriptValueRef.
2072
2073         Reviewed by Darin Adler.
2074
2075         * TestWebKitAPI/JavaScriptTest.cpp:
2076         (TestWebKitAPI::javaScriptCallback):
2077         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
2078         (TestWebKitAPI::didRunJavaScript):
2079         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
2080         (TestWebKitAPI::nullJavaScriptCallback):
2081         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
2082         (TestWebKitAPI::didRunJavaScript):
2083
2084 2011-03-03  Timothy Hatcher  <timothy@apple.com>
2085
2086         Make run-api-tests show failed if a test fails.
2087
2088         https://webkit.org/b/55725
2089
2090         Reviewed by Sam Weinig.
2091
2092         * Scripts/run-api-tests:
2093         (runTest): Remove "my" from the nested $result assignment so the
2094         check outside the condition sees the real result.
2095
2096 2011-03-02  MORITA Hajime  <morrita@google.com>
2097
2098         Reviewed by Kent Tamura.
2099
2100         [Chromium][DRT] WebTask should use webkit_support::TaskAdaptor
2101         https://bugs.webkit.org/show_bug.cgi?id=55434
2102
2103         Changed WebTask to be a subclass of webkit_support::TaskAdaptor
2104         and passed the object webkit_support::PostDelayedTask directly.
2105
2106         Note that the change keeps postTask() as is because it has a
2107         semantics taht webkit_support::PostDelayedTask() has; It jumps to
2108         the main thread.
2109
2110         * DumpRenderTree/chromium/Task.cpp:
2111         (postDelayedTask):
2112         * DumpRenderTree/chromium/Task.h:
2113         (WebTask::Run):
2114
2115 2011-03-03  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
2116
2117         Reviewed by Kenneth Rohde Christiansen.
2118
2119         [QT] Implement mock client-based geolocation for layout testing
2120         https://bugs.webkit.org/show_bug.cgi?id=54334
2121
2122         Implement testing for Client-Based geolocation for QtWebkit.
2123
2124         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2125         (WebCore::DumpRenderTree::DumpRenderTree):
2126         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2127         (LayoutTestController::reset):
2128         (LayoutTestController::setGeolocationPermission):
2129         (LayoutTestController::setMockGeolocationError):
2130         (LayoutTestController::setMockGeolocationPosition):
2131
2132 2011-03-03  Sheriff Bot  <webkit.review.bot@gmail.com>
2133
2134         Unreviewed, rolling out r80237.
2135         http://trac.webkit.org/changeset/80237
2136         https://bugs.webkit.org/show_bug.cgi?id=55714
2137
2138         Windows bots aren't ready to be core (Requested by aroben on
2139         #webkit).
2140
2141         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2142         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2143
2144 2011-03-03  Mihai Parparita  <mihaip@chromium.org>
2145
2146         Reviewed by Tony Chang.
2147
2148         NRWT: AttributeError: TestRunner2 instance has no attribute '_cancel_workers'
2149         https://bugs.webkit.org/show_bug.cgi?id=55694
2150         
2151         Fixes for interruptions in NRWT:
2152         - Make TestRunInterruptedException be pickleable correctly (the base
2153           Exception class defines a __reduce__ that does not include the reason)
2154         - Fix ordering of returned arguments from TestRunner2._run_tests
2155           (interrupted and keyboard_interrupted were reversed)
2156         - Fix cancel_workers callsites (was using old name).
2157         - In handle_exception re-raise actual exception instance that was thrown
2158
2159         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2160         * Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
2161         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
2162         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2163
2164 2011-03-03  Qi Zhang  <qi.2.zhang@nokia.com>
2165
2166         Unreviewed.
2167
2168         Adding myself as a committer.
2169
2170         * Scripts/webkitpy/common/config/committers.py:
2171
2172 2011-03-03  Tony Gentilcore  <tonyg@chromium.org>
2173
2174         Reviewed by Mihai Parparita.
2175
2176         Teach sheriffbot to answer whois commands
2177         https://bugs.webkit.org/show_bug.cgi?id=55687
2178
2179         * Scripts/webkitpy/tool/bot/irc_command.py:
2180         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2181         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
2182
2183 2011-03-03  Victoria Kirst  <vrk@google.com>
2184
2185         Reviewed by Eric Carlson.
2186
2187         Enable media tests in chromium-gpu/test_expectations
2188         https://bugs.webkit.org/show_bug.cgi?id=53608
2189
2190         Add media folder to the list of GPU test paths.
2191
2192         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2193
2194 2011-03-03  Adam Roben  <aroben@apple.com>
2195
2196         Work around a bug in KURL's parsing of Windows-style absolute file: URLs
2197
2198         Fixes <http://webkit.org/b/55674> Many tests fail in WebKit2 mode on Windows due to
2199         incorrect parsing of absolute Windows-style file: URLs
2200
2201         Reviewed by Tim Hatcher.
2202
2203         * WebKitTestRunner/TestInvocation.cpp:
2204         (WTR::createWKURL): Add a "localhost" host to file: URLs we create to work around
2205         <http://webkit.org/b/55683>.
2206
2207 2011-03-03  Tony Chang  <tony@chromium.org>
2208
2209         Reviewed by Dimitri Glazkov.
2210
2211         [chromium] Run kill-old-processes on the chromium-win bot too
2212         https://bugs.webkit.org/show_bug.cgi?id=55630
2213
2214         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2215         * BuildSlaveSupport/win/kill-old-processes: Add wdiff.exe to the kill list.
2216
2217 2011-03-03  Carlos Garcia Campos  <cgarcia@igalia.com>
2218
2219         Reviewed by Martin Robinson.
2220
2221         [GTK] DRT needs implementation of EventSender.scheduleAsynchronousClick
2222         https://bugs.webkit.org/show_bug.cgi?id=53960
2223
2224         * DumpRenderTree/gtk/EventSender.cpp:
2225         (sendClick):
2226         (scheduleAsynchronousClickCallback):
2227
2228 2011-03-03  Adam Roben  <aroben@apple.com>
2229
2230         Look for Windows-style paths when checking whether a test is an Inspector test
2231
2232         WTR part of <http://webkit.org/b/55672> <rdar://problem/9080867> All inspector tests time
2233         out or crash on Windows 7 Release (WebKit2 Tests)
2234
2235         Reviewed by Darin Adler.
2236
2237         * WebKitTestRunner/TestInvocation.cpp:
2238         (WTR::shouldOpenWebInspector): Also look for backslashes, since that's what we'll get on
2239         Windows.
2240
2241 2011-03-03  Adam Roben  <aroben@apple.com>
2242
2243         Make Windows 7 Release (Tests) a core builder
2244
2245         We can probably make Windows XP Debug (Tests) a core builder, too, but we should probably
2246         give it a few more days of greenness first.
2247
2248         Fixes <http://webkit.org/b/55665> Windows 7 Release (Tests) should be a core builder
2249
2250         Reviewed by Andreas Kling.
2251
2252         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2253         (BuildBot): Added a regexp to match Windows 7 Release (Tests).
2254
2255         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2256         (BuildBotTest): Updated the list of builders to match the current list on build.webkit.org.
2257         Updated the core regexps to match the buildbot module. Updated the expected results to match
2258         the current set of core builders.
2259
2260 2011-03-03  Benjamin Poulain  <benjamin.poulain@nokia.com>
2261
2262         Reviewed by Andreas Kling.
2263
2264         Adding myself as a reviewer.
2265
2266         * Scripts/webkitpy/common/config/committers.py:
2267
2268 2011-03-03  Lukasz Slachciak  <l.slachciak@samsung.com>
2269
2270         Reviewed by Xan Lopez.
2271
2272         [GTK] Extended application cache database API and added unit tests file.
2273         https://bugs.webkit.org/show_bug.cgi?id=55335
2274
2275         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: removed external declaration
2276         of webkit_application_cache_set_maximum_size due to API exposal.
2277
2278 2011-03-02  Ojan Vafai  <ojan@chromium.org>
2279
2280         Reviewed by Adam Barth.
2281
2282         make webkit-patch upload work for security bugs
2283         https://bugs.webkit.org/show_bug.cgi?id=55655
2284
2285         The problem is that we shell out to prepare-ChangeLog,
2286         which does not authenticate with bugzilla. All it needs from
2287         bugzilla is the bug title though. We just pass it through from
2288         webkit-patch instead.
2289
2290         * Scripts/prepare-ChangeLog:
2291         * Scripts/webkitpy/common/net/bugzilla/bug.py:
2292         * Scripts/webkitpy/tool/steps/preparechangelog.py:
2293
2294 2011-03-01  Ojan Vafai  <ojan@chromium.org>
2295
2296         Reviewed by Tony Chang.
2297
2298         [test-dashboard] make gtest JSON match layout-tests JSON
2299         https://bugs.webkit.org/show_bug.cgi?id=55556
2300
2301         http://trac.webkit.org/changeset/80090 stopped converting time_ms to t.
2302         Make this code match.
2303
2304         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2305
2306 2011-03-02  Dirk Pranke  <dpranke@chromium.org>
2307
2308         Reviewed by Tony Chang.
2309
2310         NRWT - implement Linux Hardy 64-bit port support. This involves
2311         adding support for non-'x86' architectures and updating the
2312         "deduplicate_tests" script to correctly understand that
2313         port.name() is not always equal to basename(port.baseline_path()).
2314
2315         This change introduces two new port names: 'chromium-linux-x86'
2316         and 'chromium-linux-x86_64'. Using the prior 'chromium-linux'
2317         flag will cause the code to determine which one to use at
2318         runtime, just like we currently do with 'chromium-win'.
2319
2320         https://bugs.webkit.org/show_bug.cgi?id=55535
2321
2322         * Scripts/webkitpy/common/system/executive_mock.py:
2323           Handle 'return_stderr' keyword arg to run_command()
2324         * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
2325         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
2326         * Scripts/webkitpy/layout_tests/port/base.py:
2327         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2328         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
2329         * Scripts/webkitpy/layout_tests/port/factory.py:
2330         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
2331
2332 2011-03-02  Kevin Ollivier  <kevino@theolliviers.com>
2333
2334         [wx] Build fix, make sure we put the wxWebKit dylib in the right directory and
2335         update symlinks accordingly.
2336
2337         * wx/packaging/build-mac-installer.py:
2338
2339 2011-03-02  Sheriff Bot  <webkit.review.bot@gmail.com>
2340
2341         Unreviewed, rolling out r80139.
2342         http://trac.webkit.org/changeset/80139
2343         https://bugs.webkit.org/show_bug.cgi?id=55620
2344
2345         failing and crashing tests on Snow Leopard bot (Requested by
2346         mihaip1 on #webkit).
2347
2348         * DumpRenderTree/LayoutTestController.cpp:
2349         (LayoutTestController::staticFunctions):
2350         * DumpRenderTree/LayoutTestController.h:
2351         * DumpRenderTree/chromium/LayoutTestController.cpp:
2352         (LayoutTestController::LayoutTestController):
2353         * DumpRenderTree/chromium/LayoutTestController.h:
2354         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2355         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2356         * DumpRenderTree/mac/UIDelegate.h:
2357         * DumpRenderTree/mac/UIDelegate.mm:
2358         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2359         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2360         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2361         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2362
2363 2011-03-02  Adam Roben  <aroben@apple.com>
2364
2365         Wait for force a paint in WebKitTestRunner until we're actually ready to dump the output
2366
2367         This matches DumpRenderTree on Windows.
2368
2369         Fixes <http://webkit.org/b/55469> <rdar://problem/9068539> REGRESSION (r79863): Lots of
2370         dom/html/level2/html/HTMLFrameElement*.html tests crashing in FrameView::paintOverhangAreas
2371         in WebKit2
2372
2373         Reviewed by Beth Dakin.
2374
2375         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2376         (WTR::InjectedBundlePage::dump): Moved code to force a paint here...
2377         (WTR::InjectedBundlePage::didFinishLoadForFrame): ...from here.
2378
2379 2011-03-02  Daniel Cheng  <dcheng@chromium.org>
2380
2381         Reviewed by David Levin.
2382
2383         Add feature define for data transfer items
2384         https://bugs.webkit.org/show_bug.cgi?id=55510
2385
2386         * Scripts/build-webkit:
2387
2388 2011-03-02  Adam Roben  <aroben@apple.com>
2389
2390         Look in the new-to-SnowLeopard location for crash logs on SnowLeopard and newer
2391
2392         ReportCrash saves logs to ~/Library/Logs/CrashReporter on Leopard, but to
2393         ~/Library/Logs/DiagnosticReports on SnowLeopard. old-run-webkit-tests was only looking in
2394         the former location, but was getting lucky on some SnowLeopard machines because symlinks
2395         were being created there pointing into DiagnosticReports. For machines without these
2396         symlinks, crash logs were not getting captured.
2397
2398         Fixes <http://webkit.org/b/55607> old-run-webkit-tests doesn't capture crash logs on some
2399         SnowLeopard machines
2400
2401         Reviewed by Eric Seidel.
2402
2403         * Scripts/old-run-webkit-tests:
2404         (captureSavedCrashLog): Look in ~/Library/Logs/DiagnosticReports on SnowLeopard and newer.
2405
2406 2011-03-02  Adam Roben  <aroben@apple.com>
2407
2408         Don't try to capture crash logs on platforms that haven't implemented that feature
2409
2410         Fixes <http://webkit.org/b/55504> Use of uninitialized value in numeric lt (<) at
2411         Tools/Scripts/old-run-webkit-tests line 1778 seen on Qt bots after a crash
2412
2413         Reviewed by Joseph Pecoraro.
2414
2415         * Scripts/old-run-webkit-tests:
2416         (captureSavedCrashLog): Bail if we don't have a crash log glob.
2417         (findNewestFileMatchingGlob): Fix a buggy test for when no paths match the glob. This isn't
2418         strictly required to fix bug 55504, but seems worthwhile.
2419
2420 2011-01-26  John Knottenbelt  <jknotten@chromium.org>
2421
2422         Reviewed by Dmitry Titov.
2423
2424         Detach Geolocation from Frame when Page destroyed.
2425         https://bugs.webkit.org/show_bug.cgi?id=52877
2426
2427         Extend the layout test controller to expose the number of pending
2428         geolocation requests, so that we can test that the requests have
2429         been cancelled on page close.
2430
2431         * DumpRenderTree/LayoutTestController.cpp:
2432         (numberOfPendingGeolocationPermissionRequestsCallback):
2433         (LayoutTestController::staticFunctions):
2434         * DumpRenderTree/LayoutTestController.h:
2435         * DumpRenderTree/chromium/LayoutTestController.cpp:
2436         (LayoutTestController::LayoutTestController):
2437         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2438         * DumpRenderTree/chromium/LayoutTestController.h:
2439         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2440         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2441         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2442         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2443         * DumpRenderTree/mac/UIDelegate.h:
2444         * DumpRenderTree/mac/UIDelegate.mm:
2445         (-[UIDelegate numberOfPendingGeolocationPermissionRequests]):
2446         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2447         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2448         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2449         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2450         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2451         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2452         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2453
2454
2455 2011-03-01  Kent Tamura  <tkent@chromium.org>
2456
2457         Reviewed by Dimitri Glazkov.
2458
2459         Assertion fails when a form validation bubble appears
2460         https://bugs.webkit.org/show_bug.cgi?id=55550
2461
2462         Test: fast/forms/interactive-validation-attach-assertion.html
2463
2464         * DumpRenderTree/chromium/WebPreferences.cpp:
2465         (WebPreferences::applyTo): Enable the interactive validation feature by
2466           default. This matches to Chromium browser.
2467
2468 2011-03-01  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2469
2470         Reviewed by Kent Tamura.
2471
2472         Remove efl port style exception of Webcore/JavaScriptCore
2473         https://bugs.webkit.org/show_bug.cgi?id=55549
2474
2475         WebCore and JavaScriptCore need to adhere WebKit coding style.
2476
2477         * Scripts/webkitpy/style/checker.py:
2478
2479 2011-03-01  Tony Chang  <tony@chromium.org>
2480
2481         Reviewed by Ojan Vafai.
2482
2483         [chromium] clean up temp files on chromium-mac builder too
2484         https://bugs.webkit.org/show_bug.cgi?id=55525
2485
2486         * BuildSlaveSupport/chromium/remove-crash-logs:
2487
2488 2011-02-28  Ojan Vafai  <ojan@chromium.org>
2489
2490         Reviewed by Tony Chang.
2491
2492         wrap json in a function call to afford cross-domain loading
2493         https://bugs.webkit.org/show_bug.cgi?id=55353
2494
2495         Also delete the code that compacts the JSON. It turns out this
2496         breaks the rebaseline tool and is probably a premature optimization anyways.
2497
2498         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2499         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2500         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2501         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
2502
2503 2011-03-01  Sheriff Bot  <webkit.review.bot@gmail.com>
2504
2505         Unreviewed, rolling out r80079.
2506         http://trac.webkit.org/changeset/80079
2507         https://bugs.webkit.org/show_bug.cgi?id=55547
2508
2509         "Broke the Win debug build?" (Requested by dcheng on #webkit).
2510
2511         * Scripts/build-webkit:
2512
2513 2011-03-01  Mark Rowe  <mrowe@apple.com>
2514
2515         Reviewed by Sam Weinig.
2516
2517         Update verification scripts to handle WebKit2.
2518
2519         * Scripts/check-for-global-initializers: Skip object files that use RefCountedLeakChecker.
2520         * Scripts/check-for-inappropriate-files-in-framework: Add some inappropriate file types for
2521         WebKit2.
2522
2523 2011-03-01  Daniel Cheng  <dcheng@chromium.org>
2524
2525         Reviewed by David Levin.
2526
2527         Add feature define for data transfer items
2528         https://bugs.webkit.org/show_bug.cgi?id=55510
2529
2530         * Scripts/build-webkit:
2531
2532 2011-02-23  Joseph Pecoraro  <joepeck@webkit.org>
2533
2534         Reviewed by Timothy Hatcher.
2535
2536         All Console Messages should be passed to ChromeClients.
2537         https://bugs.webkit.org/show_bug.cgi?id=54926
2538
2539         Update DumpRenderTree's UIDelegate to use the new console message delegate.
2540
2541         * DumpRenderTree/mac/UIDelegate.mm:
2542         (-[UIDelegate webView:addMessageToConsole:withSource:]):
2543
2544 2011-03-01  Dirk Pranke  <dpranke@chromium.org>
2545
2546         Reviewed by Adam Barth.
2547
2548         Tragically, we stopped running the python unit tests
2549         on Chromium Win just as I was getting them to be green.
2550         This patch turns them back on.
2551
2552         https://bugs.webkit.org/show_bug.cgi?id=55521
2553
2554         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2555
2556 2011-03-01  Dirk Pranke  <dpranke@chromium.org>
2557
2558         Reviewed by Adam Roben.
2559
2560         Disable
2561         webkitpy.common.system.executive_unittest.ExecutiveTest.\
2562            test_kill_all fails on win until it can be properly triaged.
2563
2564         https://bugs.webkit.org/show_bug.cgi?id=54790
2565
2566         * Scripts/webkitpy/common/system/executive_unittest.py:
2567
2568     2011-03-01  Helder Correia  <helder@sencha.com>
2569
2570             Unreviewed. Add myself to committers.py.
2571
2572             * Scripts/webkitpy/common/config/committers.py:
2573
2574 2011-03-01  Adam Roben  <aroben@apple.com>
2575
2576         Give up if a crash log for the web process is taking too long to be saved on Windows
2577
2578         This should keep the bots from getting stuck while waiting for a crash log, if writing a
2579         crash log ever hangs or the UI process for some reason doesn't notice it's finished.
2580
2581         Fixes <http://webkit.org/b/55499> WebKitTestRunner can hang forever waiting for a crash log
2582         to be saved for the web process
2583
2584         Reviewed by Steve Falkenburg.
2585
2586         * WebKitTestRunner/win/TestControllerWin.cpp:
2587         (WTR::runRunLoopUntil): Moved code to run the run loop here here from platformRunUntil.
2588         Generalized the code slightly to handle the optional object to wait on.
2589         (WTR::TestController::platformRunUntil): Use the new runRunLoopUntil function, and also use
2590         it (with a timeout) when waiting for a crash log for the web process to be saved. This will
2591         prevent us from waiting forever.
2592
2593 2011-03-01  Adam Roben  <aroben@apple.com>
2594
2595         Give WebKitLauncherWin's PDB file a name different from WebKit's
2596
2597         WebKitLauncherWin (which builds WebKit.exe) and WebKit (which builds WebKit.dll) were
2598         fighting over the same PDB file, meaning that one of them was going to lose and not have
2599         symbols. WebKitLauncherWin's PDB file is now named WebKitLauncherWin.pdb.
2600
2601         Fixes <http://webkit.org/b/55495> Crashes in WebKit.dll have bad backtraces for some test
2602         runs (due to missing symbols)
2603
2604         Reviewed by David Kilzer.
2605
2606         * WebKitLauncherWin/WebKitLauncherWinCommon.vsprops: Use the project name,
2607         "WebKitLauncherWin", instead of the target name, "WebKit", when naming the PDB file.
2608
2609 2011-03-01  Adam Roben  <aroben@apple.com>
2610
2611         Count web process crashes toward the --exit-after-n-crashes-or-timeouts limit
2612
2613         Fixes <http://webkit.org/b/55492> Web process crashes aren't counted toward the
2614         --exit-after-n-crashes-or-timeouts limit
2615
2616         Reviewed by David Kilzer.
2617
2618         * Scripts/old-run-webkit-tests:
2619         (stopRunningTestsEarlyIfNeeded): Include web process crashes in the computation, and print
2620         the number of tests that caused the web process to crash when exiting early.
2621
2622 2011-03-01  Adam Roben  <aroben@apple.com>
2623
2624         Save a crash log when the web process crashes
2625
2626         On Windows, WebKitTestRunner now detects when the web process is crashing and waits to exit
2627         until it has finished crashing, which guarantees that the crash log will have had time to be
2628         saved, too. On Mac, we always wait until ReportCrash has exited before capturing the crash
2629         log, so all we have to do is choose the right crash log out of the CrashReporter directory.
2630
2631         Fixes <http://webkit.org/b/44121> <rdar://problem/8320759> When the web process crashes and
2632         a crash log is being saved, WebKitTestRunner thinks the web process has become unresponsive
2633
2634         Reviewed by Sam Weinig.
2635
2636         * Scripts/old-run-webkit-tests:
2637         (testCrashedOrTimedOut): Don't kill WebKitTestRunner when the web process crashes. It will
2638         kill itself. On Windows, this will cause us to wait until the crash log has been saved. On
2639         Mac, it should have no effect. Capture saved crash logs for web process crashes, too.
2640         (captureSavedCrashLog): Added $webProcessCrashed argument. On Mac, look for
2641         WebProces_*.crash files when the web process crashes.
2642
2643         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2644         (WTR::InjectedBundle::initialize): Added an initializationUserData argument. Updated for
2645         initializePlatformDefaults -> platformInitialize rename. Pass the initializationUserData
2646         along to platformInitialize.
2647
2648         * WebKitTestRunner/InjectedBundle/InjectedBundle.h: See above.
2649
2650         * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp:
2651         (WKBundleInitialize): Pass along the initializationUserData to the InjectedBundle.
2652
2653         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
2654         (WTR::InjectedBundle::platformInitialize):
2655         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
2656         (WTR::InjectedBundle::platformInitialize):
2657         Updated function signature.
2658
2659         * WebKitTestRunner/InjectedBundle/win/InjectedBundleWin.cpp:
2660         (WTR::exceptionFilter): Added. Tells the UI process we're crashing by signaling the
2661         webProcessCrashingEvent, then lets the crash continue as normal.
2662
2663         (WTR::InjectedBundle::platformInitialize): Hook up exceptionFilter. Retrieve the name of the
2664         event we should use to tell the UI process we're crashing from the initializationUserData,
2665         and get a handle to that event.
2666
2667         * WebKitTestRunner/TestController.cpp:
2668         (WTR::TestController::TestController): Initialize new members.
2669         (WTR::TestController::processDidCrash): Removed unnecessary WKPageRef argument. Changed to
2670         only print the "#CRASHED - WebProcess" message once, since this can be called more than once
2671         when a crash log is being saved on Windows. Exit right away if specified. (This is the
2672         default.)
2673
2674         * WebKitTestRunner/TestController.h: Added new members.
2675
2676         * WebKitTestRunner/win/TestControllerWin.cpp:
2677         (WTR::TestController::platformInitialize): Set up the event the web process will use to tell
2678         us it's crashing.
2679         (WTR::TestController::platformRunUntil): Pass MWMO_INPUTAVAILABLE to
2680         ::MsgWaitForMultipleObjectsEx so we'll process messages that have already been seen by
2681         ::PeekMessage. (This is unrelated to the bug fix.) Notice when the webProcessCrashingEvent
2682         has been signaled. When this happens, print the "#CRASHED - WebProcess" message right away
2683         so the test harness will know the web process has crashed and not try to kill us, then wait
2684         for the web process to finish crashing so a crash log will have time to be saved.
2685         (WTR::toWK): Simple hepler function.
2686         (WTR::TestController::platformInitializeContext): Pass along the name of the event the web
2687         process should use to tell us it is crashing in the context's initialization user data.
2688
2689 2011-03-01  Dimitri Glazkov  <dglazkov@chromium.org>
2690
2691         Reviewed by Tony Gentilcore.
2692
2693         Move the checks to exclude Python/Perl tests for Chromium Win build to the right place.
2694         https://bugs.webkit.org/show_bug.cgi?id=55476
2695
2696         Chromium Win uses BuildAndTestFactory, not TestFactory.
2697
2698         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Moved to the right place.
2699
2700 2011-03-01  Adam Roben  <aroben@apple.com>
2701
2702         Test that the WebKit2 responsiveness timer doesn't fire too early
2703
2704         Test for <http://webkit.org/b/55417> <rdar://problem/9065287> RunLoop::Timer fires 1000x too
2705         early on Windows
2706
2707         Reviewed by Anders Carlsson.
2708
2709         * TestWebKitAPI/PlatformUtilities.h: Added sleep().
2710
2711         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly.cpp: Added.
2712         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
2713         (TestWebKitAPI::didFinishLoadForFrame):
2714         (TestWebKitAPI::processDidBecomeUnresponsive):
2715         (TestWebKitAPI::setInjectedBundleClient):
2716         (TestWebKitAPI::setPageLoaderClient):
2717         Simple helper functions.
2718
2719         (TestWebKitAPI::TEST): Load an HTML file to make sure the web process is initialized. Then
2720         tell the web process to pause and press the spacebar key. The spacebar keypress should cause
2721         the responsiveness timer to start, but the web process should unpause before it has a chance
2722         to fire. Run until the web process has unpaused, and assert that the timer didn't fire.
2723
2724         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly_Bundle.cpp: Added.
2725         (TestWebKitAPI::ResponsivenessTimerDoesntFireEarlyTest::ResponsivenessTimerDoesntFireEarlyTest):
2726         Call up to the base class.
2727         (TestWebKitAPI::ResponsivenessTimerDoesntFireEarlyTest::didReceiveMessage): When asked to
2728         pause, sleep for 0.5 seconds, then send back a message saying we paused.
2729
2730         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
2731         (TestWebKitAPI::Util::sleep): Added. Calls through to usleep.
2732         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
2733         (TestWebKitAPI::Util::sleep): Added. Calls through to ::Sleep.
2734
2735         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2736         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2737         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
2738         Added new files.
2739
2740 2011-03-01  Andras Becsi  <abecsi@webkit.org>
2741
2742         Reviewed by Csaba Osztrogonác.
2743
2744         [Qt] Clean up the project files and move common options to WebKit.pri.
2745
2746         * WebKitTestRunner/qt/WebKitTestRunner.pro: Deduplicate.
2747
2748
2749 2011-03-01  Adam Roben  <aroben@apple.com>
2750
2751         Skip another multiprocessing test on Windows
2752
2753         It is sometimes failing (and may be leaving child Python processes around).
2754         <http://webkit.org/b/55087> tracks the failure.
2755
2756         * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker_unittest.py:
2757         (FuncitonTests.test_get__processes): Skip this test on Windows.
2758
2759 2011-03-01  Ilya Tikhonovsky  <loislo@chromium.org>
2760
2761         Reviewed by Pavel Feldman.
2762
2763         Web Inspector: reduce inspector tests flakiness.
2764         https://bugs.webkit.org/show_bug.cgi?id=55401
2765
2766         * DumpRenderTree/chromium/TestShell.cpp:
2767         (TestShell::runFileTest):
2768         * DumpRenderTree/chromium/WebPreferences.cpp:
2769         (WebPreferences::reset):
2770
2771 2011-02-28  Mihai Parparita  <mihaip@chromium.org>
2772
2773         Reviewed by James Robinson.
2774
2775         NRWT should still upload results when it exits early due to too many failures
2776         https://bugs.webkit.org/show_bug.cgi?id=55432
2777         
2778         Only keyboard interrupts should prevent results from being uploaded.
2779
2780         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2781         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2782
2783 2011-02-28  Alice Liu  <alice.liu@apple.com>
2784
2785         Reviewed by Adam Roben and Gavin Barraclough.
2786
2787         Test for https://bugs.webkit.org/show_bug.cgi?id=54898
2788         InjectedBundleNodeHandle dies too early in WKBundleHitTestResultGetNodeHandle.
2789
2790         * TestWebKitAPI/InjectedBundleController.h:
2791         (TestWebKitAPI::InjectedBundleController::bundle):
2792         * TestWebKitAPI/PlatformWebView.h:
2793         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp: Added.
2794         (TestWebKitAPI::didFinishLoadForFrame):
2795         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
2796         (TestWebKitAPI::setPageLoaderClient):
2797         (TestWebKitAPI::TEST):
2798         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle_Bundle.cpp: Added.
2799         (TestWebKitAPI::HitTestResultNodeHandleTest::HitTestResultNodeHandleTest):
2800         (TestWebKitAPI::HitTestResultNodeHandleTest::getContextMenuFromDefaultMenu):
2801         (TestWebKitAPI::HitTestResultNodeHandleTest::didCreatePage):
2802         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
2803         (TestWebKitAPI::PlatformWebView::simulateRightClick):
2804         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
2805         (TestWebKitAPI::PlatformWebView::simulateRightClick):
2806         
2807         Added files to:
2808         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2809         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2810         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
2811
2812 2011-02-28  Adam Roben  <aroben@apple.com>
2813
2814         Start running InjectedBundle API tests on Windows
2815
2816         A new project, TestWebKitAPIInjectedBundle, builds the injected bundle DLL.
2817
2818         Fixes <http://webkit.org/b/55420> run-api-tests doesn't run injected bundle tests on Windows
2819
2820         Reviewed by Darin Adler.
2821
2822         * TestWebKitAPI/Configurations/TestWebKitAPIDebug.vsprops: Added.
2823         * TestWebKitAPI/Configurations/TestWebKitAPIDebugAll.vsprops: Added.
2824         * TestWebKitAPI/Configurations/TestWebKitAPIDebugCairoCFLite.vsprops: Added.
2825         * TestWebKitAPI/Configurations/TestWebKitAPIRelease.vsprops: Added.
2826         * TestWebKitAPI/Configurations/TestWebKitAPIReleaseCairoCFLite.vsprops: Added.
2827         These are just extracted from TestWebKitAPI.vcproj.
2828
2829         * TestWebKitAPI/Configurations/TestWebKitAPIInjectedBundleCommon.vsprops: Added. Just sets
2830         up the DLL's filename.
2831
2832         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp: Fixed DLL name.
2833         (TestWebKitAPI::Util::createInjectedBundlePath): Changed to use kCFAllocatorNull instead of
2834         0 (== kCFAllocatorDefault) so that CF won't try to deallocate our C string.
2835
2836         * TestWebKitAPI/win/TestWebKitAPI.sln: Added TestWebKitAPIInjectedBundle. Removed the bogus
2837         "all" configuration.
2838
2839         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Changed to use the new .vsprops files. Added
2840         injected bundle tests. Let VS resort things.
2841
2842         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj: Copied from Tools/TestWebKitAPI/win/TestWebKitAPI.vcproj.
2843
2844 2011-02-28  Adam Roben  <aroben@apple.com>
2845
2846         Add a test for the paint rect passed via WM_PAINT to windowless plugins
2847
2848         Test for <http://webkit.org/b/55365> <rdar://problem/9031089> REGRESSION (r79040): WebKit2:
2849         Large portions of pages with plugins paint black
2850
2851         Reviewed by Anders Carlsson.
2852
2853         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
2854         (PluginTest::NPP_HandleEvent):
2855         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
2856         Added NPP_HandleEvent. Just returns 0 at this level.
2857
2858         * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowlessPaintRectCoordinates.cpp: Added.
2859         (WindowlessPaintRectCoordinates::WindowlessPaintRectCoordinates): Call up to the base class.
2860         (WindowlessPaintRectCoordinates::NPP_New): Mark ourselves as windowless.
2861         (WindowlessPaintRectCoordinates::NPP_HandleEvent): Check that the paint rect passed via
2862         WM_PAINT has the expected coordinates.
2863
2864         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2865         (NPP_HandleEvent): Give the PluginTest a chance to handle the event before doing anything
2866         else.
2867
2868         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Added new file, let VS
2869         resort things.
2870
2871         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2872         (WTR::InjectedBundlePage::didFinishLoadForFrame): Added a call to WKBundlePageForceRepaint.
2873         This is roughly equivalent to the call to -[WebView displayIfNeeded] in -[FrameLoadDelegate
2874         webView:didFinishLoadForFrame:] in DumpRenderTree.
2875
2876         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2877         (WTR::PlatformWebView::PlatformWebView): Tell the WKView it's in a window so that plugins
2878         can start running.
2879
2880 2011-02-28  Adam Roben  <aroben@apple.com>
2881
2882         Tell MiniBrowser's WKViews that they're in a window
2883
2884         Fixes <http://webkit.org/b/55364> Plugins don't work in MiniBrowser on Windows
2885
2886         Reviewed by Anders Carlsson.
2887
2888         * MiniBrowser/win/BrowserView.cpp:
2889         (BrowserView::create): Call WKViewSetIsInWindow after creating the view.
2890
2891 2011-02-28  Alexis Menard  <alexis.menard@openbossa.org>
2892
2893         Reviewed by Csaba Osztrogonác.
2894
2895         The new QML tests require QML_IMPORT_PATH variable to be set in order to
2896         load the proper plugin.
2897
2898         * Scripts/run-qtwebkit-tests:
2899
2900 2011-02-28  Joone Hur  <joone.hur@collabora.co.uk>
2901
2902         Unreviewed, fix spelling mistake.
2903
2904         hardware-accelated => hardware-accelerated.
2905
2906         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2907
2908 2011-02-28  Kristian Amlie  <kristian.amlie@nokia.com>
2909
2910         Reviewed by Andreas Kling.
2911
2912         Made sure that the build-webkit --qmake argument is always respected.
2913
2914         Previously, it would be respected during the build, but not during
2915         the early feature detection. The build would also fail if qmake was
2916         not in your path, even if you specified --qmake with a valid qmake
2917         binary.
2918
2919         [Qt] WebKit patches required to work with a modularized version of Qt
2920         https://bugs.webkit.org/show_bug.cgi?id=53916
2921
2922         * Scripts/build-webkit:
2923         * Scripts/webkitdirs.pm:
2924
2925 2011-02-27  Ojan Vafai  <ojan@chromium.org>
2926
2927         Fix failing tests from http://trac.webkit.org/changeset/79837.
2928
2929         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
2930         This was just a mistake that would break if someone tried printing with this configuration.
2931         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2932         Method signature changed. Didn't notice that this method was being calling in a unittest.
2933
2934 2011-02-24  Hayato Ito  <hayato@chromium.org>
2935
2936         Reviewed by Eric Seidel.
2937
2938         [NRWT] Remove test_types/* classes.
2939
2940         This is the last patch in the series of efforts which tried to remove test_types classes.
2941         A single_test_runner module will take over responsibilities of test_type classes.
2942
2943         From this patch, we won't display statistics per test_type even if a '--verbose' option is given.
2944
2945         https://bugs.webkit.org/show_bug.cgi?id=55123
2946
2947         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
2948         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
2949         * Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py:
2950         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2951         * Scripts/webkitpy/layout_tests/layout_package/worker_mixin.py:
2952         * Scripts/webkitpy/layout_tests/test_types/__init__.py: Removed.
2953         * Scripts/webkitpy/layout_tests/test_types/image_diff.py: Removed.
2954         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py: Removed.
2955         * Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py: Removed.
2956         * Scripts/webkitpy/layout_tests/test_types/text_diff.py: Removed.
2957
2958 2011-02-25  Ojan Vafai  <ojan@chromium.org>
2959
2960         Reviewed by Tony Chang.
2961
2962         Change results.json format to the one used by unexpected_results.json
2963         https://bugs.webkit.org/show_bug.cgi?id=52267
2964
2965         Also add runtimes in milliseconds to the JSON and make the output format more compact.
2966         Named the file full_results.json to avoid conflicting with the results.json
2967         file the test-results server currently serves up.
2968
2969         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
2970         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2971         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
2972         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
2973         * Scripts/webkitpy/layout_tests/layout_package/result_summary.py:
2974         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2975
2976 2011-02-27  Adam Roben  <aroben@apple.com>
2977
2978         Followup fix to r79827
2979
2980         * DumpRenderTree/win/UIDelegate.cpp:
2981         (UIDelegate::webViewAddMessageToConsole): Replaced call to urlSuitableForTestResult with
2982         lastPathComponent. This matches what we did here before r79827, and matches Mac.
2983
2984 2011-02-27  Dan Bernstein  <mitz@apple.com>
2985
2986         Reviewed by Adam Roben.
2987
2988         Make bisect-builds print a trac link for the regression range
2989         https://bugs.webkit.org/show_bug.cgi?id=55331
2990
2991         * Scripts/bisect-builds:
2992
2993 2011-02-27  Adam Roben  <aroben@apple.com>
2994
2995         Use iswalpha instead of isalpha when dealing with wchar_ts in EditingDelegate
2996
2997         Fixes <http://webkit.org/b/55062> <rdar://problem/9059907> Crash beneath
2998         EditingDelegate::checkSpellingOfString when running fast/forms/input-text-maxlength.html or
2999         fast/forms/input-text-paste-maxlength.html on Windows with full page heap enabled
3000
3001         Reviewed by Anders Carlsson.
3002
3003         * DumpRenderTree/win/EditingDelegate.cpp:
3004         (indexOfFirstWordCharacter):
3005         (wordLength):
3006         Use iswalpha instead of isalpha, since TCHAR is really just wchar_t.
3007
3008 2011-02-27  Adam Roben  <aroben@apple.com>
3009
3010         Make ResourceLoadDelegate print URLs relative to the main resource on Windows
3011
3012         This matches Mac. (In fact, the code was ported from Mac!)
3013
3014         Fixes <http://webkit.org/b/55328> URLs printed by ResourceLoadDelegate on Windows don't
3015         match Mac
3016
3017         Reviewed by Anders Carlsson.
3018
3019         * DumpRenderTree/win/DumpRenderTree.cpp:
3020         (substringFromIndex): Added. Emulates -[NSString substringFromIndex:].
3021         (urlSuitableForTestResult): Ported code from -[NSURL(DRTExtras)
3022         _drt_descriptionSuitableForTestResult].
3023         (cfStringRefToWString): Moved here from LayoutTestControllerWin.cpp.
3024
3025         * DumpRenderTree/win/DumpRenderTreeWin.h: Added declaration of cfStringRefToWString.
3026
3027         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Moved cfStringRefToWString to
3028         DumpRenderTree.cpp.
3029
3030 2011-02-27  Adam Roben  <aroben@apple.com>
3031
3032         Change the order of Chang Shu's email addresses so the first one is their Bugzilla username
3033
3034         This makes Bugzilla autocompletion work correctly.
3035
3036         * Scripts/webkitpy/common/config/committers.py:
3037
3038 2011-02-27  Patrick Gansterer  <paroga@webkit.org>
3039
3040         Reviewed by Andreas Kling.
3041
3042         [Qt] fast/loader/user-stylesheet-fast-path.html fails
3043         https://bugs.webkit.org/show_bug.cgi?id=50911
3044
3045         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3046         (LayoutTestController::setUserStyleSheetLocation):
3047         Use QUrl::fromEncoded since the passed string is already encoded.
3048
3049 2011-02-27  Adam Roben  <aroben@apple.com>
3050
3051         Ensure $testResultsDirectory is an absolute path before setting up Windows crash log saving
3052
3053         Windows 7 (and maybe Vista?) launches the post-mortem debugger with a working directory that
3054         is different from old-run-webkit-test's. Because of this, the path to the crash log file
3055         (which is relative to $testResultsDirectory) must be an absolute path. See the bug for more
3056         details.
3057
3058         Fixes <http://webkit.org/b/55318> Crash logs aren't saved on Windows 7 when a relative
3059         --results-directory path is used (like on the test slaves)
3060
3061         Reviewed by Dan Bernstein.
3062
3063         * Scripts/old-run-webkit-tests: Moved the call to setUpWindowsCrashLogSaving after we've
3064         made $testResultsDirectory an absolute path.
3065
3066 2011-02-26  Dominic Mazzoni  <dmazzoni@google.com>
3067
3068         Reviewed by Adam Barth.
3069
3070         m_dumpAccessibilityNotifications should be initialized.
3071         https://bugs.webkit.org/show_bug.cgi?id=54874
3072
3073         * DumpRenderTree/chromium/AccessibilityController.cpp:
3074         (AccessibilityController::AccessibilityController):
3075
3076 2011-02-26  Vsevolod Vlasov  <vsevik@chromium.org>
3077
3078         Reviewed by Pavel Feldman.
3079
3080         DumpRenderTree should reset frame opener between tests.
3081         https://bugs.webkit.org/show_bug.cgi?id=54874
3082
3083         Added clearOpener() calls between tests.
3084         Some tests are using window.open() to change current window location.
3085         This changes window.opener property whose nullity is checked before
3086         showing xml viewer.
3087
3088         * DumpRenderTree/chromium/TestShell.cpp:
3089         (TestShell::resetTestController):
3090         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3091         (resetDefaultsToConsistentValues):
3092         * DumpRenderTree/mac/DumpRenderTree.mm:
3093         (resetWebViewToConsistentStateBeforeTesting):
3094         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3095         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
3096         * DumpRenderTree/win/DumpRenderTree.cpp:
3097         (resetWebViewToConsistentStateBeforeTesting):
3098         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3099         (WTR::InjectedBundlePage::reset):
3100
3101 2011-02-26  Yael Aharon  <yael.aharon@nokia.com>
3102
3103         Reviewed by Andreas Kling.
3104
3105         [Qt] Fix the focus in MiniBrowser.
3106         https://bugs.webkit.org/show_bug.cgi?id=55288
3107
3108         Give focus to the web view when a load starts.
3109
3110         * MiniBrowser/qt/BrowserWindow.cpp:
3111         (BrowserWindow::urlChanged):
3112
3113 2011-02-26  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3114
3115         Reviewed by Adam Barth.
3116
3117         [EFL] Add coding style exceptions for EFL port
3118         https://bugs.webkit.org/show_bug.cgi?id=54733
3119
3120         The EFL APIs use EFL naming style, which includes both lower-cased and camel-cased,
3121         underscore-sparated values. But, style checking rule have found parameter_name errors
3122         in efl directories so far.
3123
3124         * Scripts/webkitpy/style/checker.py: Add prameter_name rule's exception and efl directories.
3125
3126 2011-02-26  David Levin  <levin@chromium.org>
3127
3128         Reviewed by Darin Adler.
3129
3130         check-webkit-style should check for spaces after periods in comments
3131         https://bugs.webkit.org/show_bug.cgi?id=55253
3132
3133         * Scripts/webkitpy/style/checkers/cpp.py: Added the check.
3134         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests
3135           and fixed the name of one related test.
3136
3137 2011-02-26  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3138
3139         Reviewed by Andreas Kling.
3140
3141         Make it possible to test the targetdensity-dpi support
3142         https://bugs.webkit.org/show_bug.cgi?id=55142
3143
3144         Test the viewport meta tag feature targetdensity-dpi by
3145         adding extra arguments to dumpConfigurationForViewport
3146
3147         Add the new arguments to the shared header and all
3148         implementation.
3149
3150         * DumpRenderTree/LayoutTestController.cpp:
3151         (dumpConfigurationForViewportCallback):
3152         * DumpRenderTree/LayoutTestController.h:
3153         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3154         (LayoutTestController::dumpConfigurationForViewport):
3155         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3156         (LayoutTestController::dumpConfigurationForViewport):
3157         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3158         (LayoutTestController::dumpConfigurationForViewport):
3159         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3160         (LayoutTestController::dumpConfigurationForViewport):
3161         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3162         (LayoutTestController::dumpConfigurationForViewport):
3163         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3164
3165 2011-02-26  Sheriff Bot  <webkit.review.bot@gmail.com>
3166
3167         Unreviewed, rolling out r79764.
3168         http://trac.webkit.org/changeset/79764
3169         https://bugs.webkit.org/show_bug.cgi?id=55295
3170
3171         "broke Chromium builds" (Requested by rniwa on #webkit).
3172
3173         * DumpRenderTree/chromium/TestShell.cpp:
3174         (TestShell::resetTestController):
3175         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3176         (resetDefaultsToConsistentValues):
3177         * DumpRenderTree/mac/DumpRenderTree.mm:
3178         (resetWebViewToConsistentStateBeforeTesting):
3179         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3180         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
3181         * DumpRenderTree/win/DumpRenderTree.cpp:
3182         (resetWebViewToConsistentStateBeforeTesting):
3183         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3184         (WTR::InjectedBundlePage::reset):
3185
3186 2011-02-26  Yongjun Zhang  <yongjun_zhang@apple.com>
3187
3188         Reviewed by David Kilzer.
3189
3190         https://bugs.webkit.org/show_bug.cgi?id=48781
3191
3192         Add a resource load delegate method to query if WebCore should paint the default broken image for failed images.
3193
3194         Add a new resource load client method (shouldPaintBrokenImage).  WebKit client can decide if WebCore
3195         should paint the default broken image when an image fails to load or decode.
3196
3197         * DumpRenderTree/LayoutTestController.cpp:
3198         (LayoutTestController::LayoutTestController):
3199         (setShouldPaintBrokenImageCallback):
3200         (LayoutTestController::staticFunctions):
3201         (LayoutTestController::setShouldPaintBrokenImage):
3202         * DumpRenderTree/LayoutTestController.h:
3203         (LayoutTestController::shouldPaintBrokenImage):
3204         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
3205         (-[ResourceLoadDelegate webView:shouldPaintBrokenImageForURL:]):
3206
3207 2011-02-26  Vsevolod Vlasov  <vsevik@chromium.org>
3208
3209         Reviewed by Pavel Feldman.
3210
3211         DumpRenderTree should reset frame opener between tests.
3212         https://bugs.webkit.org/show_bug.cgi?id=54874
3213
3214         Added clearOpener() calls between tests.
3215         Some tests are using window.open() to change current window location.
3216         This changes window.opener property whose nullity is checked before
3217         showing xml viewer.
3218
3219         * DumpRenderTree/chromium/TestShell.cpp:
3220         (TestShell::resetTestController):
3221         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3222         (resetDefaultsToConsistentValues):
3223         * DumpRenderTree/mac/DumpRenderTree.mm:
3224         (resetWebViewToConsistentStateBeforeTesting):
3225         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3226         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
3227         * DumpRenderTree/win/DumpRenderTree.cpp:
3228         (resetWebViewToConsistentStateBeforeTesting):
3229         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3230         (WTR::InjectedBundlePage::reset):
3231
3232 2011-02-25  Lukasz Slachciak  <l.slachciak@samsung.com>
3233
3234         Reviewed by Kenneth Rohde Christiansen.
3235
3236         [EFL] Added EWebLauncher command line option to turn on/off frame flattening
3237         https://bugs.webkit.org/show_bug.cgi?id=54809
3238
3239         * EWebLauncher/main.c: Handling -f option added.
3240         (on_key_down):
3241         (browserCreate):
3242         (main):
3243
3244 2011-02-25  Sheriff Bot  <webkit.review.bot@gmail.com>
3245
3246         Unreviewed, rolling out r79324.
3247         http://trac.webkit.org/changeset/79324
3248         https://bugs.webkit.org/show_bug.cgi?id=55260
3249
3250         Leopard Debug is once again running out of address space while
3251         linking (Requested by aroben on #webkit).
3252
3253         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
3254         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3255
3256 2011-02-25  Tony Chang  <tony@chromium.org>
3257
3258         Reviewed by James Robinson.
3259
3260         Clean up temp files left by crashing DRTs on chromium-win
3261         https://bugs.webkit.org/show_bug.cgi?id=55182
3262
3263         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3264         * BuildSlaveSupport/chromium/remove-crash-logs: Added.
3265
3266 2011-02-25  Adam Roben  <aroben@apple.com>
3267
3268         Double-check that modifying the registry worked
3269
3270         On Windows Vista/7 with UAC enabled, regtool will fail to modify the registry, but it will
3271         still return a successful exit code. So we double-check here that the value we tried to
3272         write to the registry was really written.
3273
3274         Fixes <http://webkit.org/b/55227> old-run-webkit-tests falsely claims to be saving crash
3275         logs on Windows Vista/7
3276
3277         Reviewed by Darin Adler.
3278
3279         * Scripts/old-run-webkit-tests:
3280         (writeRegistryString): After trying to write the string value, check that it was really
3281         written.
3282
3283 2011-02-25  Adam Roben  <aroben@apple.com>
3284
3285         Set the 32-bit post-mortem debugger on 64-bit OSes
3286
3287         The post-mortem debugger is controlled by some registry values in
3288         HKLM\SOFTWARE\Microsoft\Windows NT\CurrentVersion\AeDebug. On 64-bit OSes, you can either
3289         set the values in that key, which will be used for 64-bit apps, or in the equivalent key
3290         under Wow6432Node, which will be used for 32-bit apps. Since DumpRenderTree and
3291         WebKitTestRunner are 32-bit, we want to use the latter location.
3292
3293         Fixes <http://webkit.org/b/55225> old-run-webkit-tests sets the post-mortem debugger for
3294         64-bit apps, but should set it for 32-bit apps instead
3295
3296         Reviewed by Darin Adler.
3297
3298         * Scripts/old-run-webkit-tests:
3299         (readRegistryString):
3300         (writeRegistryString):
3301         Pass --wow32 to regtool so it will get/set values beneath Wow6432Node, which is where
3302         Windows looks for the post-mortem debugger values when a 32-bit app crashes on a 64-bit OS.
3303         Passing --wow32 on a 32-bit OS will not have any effect.
3304
3305 2011-02-25  Adam Roben  <aroben@apple.com>
3306
3307         Clean up code to set up crash log saving on Windows
3308
3309         Fixes <http://webkit.org/b/55224> old-run-webkit-test's Windows registry code is ugly
3310
3311         Reviewed by David Kilzer.
3312
3313         * Scripts/old-run-webkit-tests:
3314         (readRegistryString):
3315         (writeRegistryString):
3316         Moved code to read strings from and write strings to the registry here...
3317
3318         (setUpWindowsCrashLogSaving): ...from here.
3319
3320 2011-02-25  Adam Roben  <aroben@apple.com>
3321
3322         Work around Cygwin's crash-suppression behavior
3323
3324         Cygwin calls ::SetErrorMode(SEM_FAILCRITICALERRORS), which any processes it launches will
3325         inherit. This is bad for testing/debugging, as it causes the post-mortem debugger not to be
3326         invoked. (Cygwin does this because it makes crashes more UNIX-y.) We reset the error mode
3327         when our test apps launch to work around Cygwin's behavior.
3328
3329         Fixes <http://webkit.org/b/55222> Test apps crash silently (without invoking post-mortem
3330         debugger) when launched from Cygwin 1.7
3331
3332         Reviewed by Darin Adler.
3333
3334         * DumpRenderTree/win/DumpRenderTree.cpp:
3335         (main):
3336         * TestWebKitAPI/win/main.cpp:
3337         (main):
3338         * WebKitAPITest/main.cpp:
3339         (main):
3340         * WebKitTestRunner/win/TestControllerWin.cpp:
3341         (WTR::TestController::platformInitialize):
3342         Call ::SetErrorMode(0) to undo Cygwin's folly.
3343
3344 2011-02-24  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
3345
3346         Reviewed by Andreas Kling.
3347
3348         [Qt] Revert the support for QNAM affined to a different thread.
3349         https://bugs.webkit.org/show_bug.cgi?id=55149
3350
3351         Qt 4.8 will have QNAM use its own thread internally by default,
3352         no need to keep this complexity in WebKit.
3353
3354         This mainly reverts:
3355         http://trac.webkit.org/changeset/73710
3356         http://trac.webkit.org/changeset/73712
3357
3358         * QtTestBrowser/launcherwindow.cpp:
3359         (LauncherWindow::~LauncherWindow):
3360         (LauncherWindow::initializeView):
3361         (LauncherWindow::createChrome):
3362         * QtTestBrowser/launcherwindow.h:
3363         (WindowOptions::WindowOptions):
3364         * QtTestBrowser/webpage.cpp:
3365         (WebPage::WebPage):
3366         * QtTestBrowser/webpage.h:
3367
3368 2011-02-24  Adam Barth  <abarth@webkit.org>
3369
3370         Reviewed by Eric Seidel.
3371
3372         Add a script for creating gypi files
3373         https://bugs.webkit.org/show_bug.cgi?id=55113
3374
3375         This is a trivial script to create gypi files from the source code in
3376         the current directory.
3377
3378         * Scripts/make-gypi: Added.
3379
3380 2011-02-24  Sheriff Bot  <webkit.review.bot@gmail.com>
3381
3382         Unreviewed, rolling out r79628.
3383         http://trac.webkit.org/changeset/79628
3384         https://bugs.webkit.org/show_bug.cgi?id=55195
3385
3386         "broke chromium win tests" (Requested by dpranke on #webkit).
3387
3388         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3389         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
3390
3391 2011-02-24  Dirk Pranke  <dpranke@chromium.org>
3392
3393         Reviewed by Mihai Parparita.
3394
3395         rebaseline-chromium-webkit-tests can't handle GPU variants
3396         https://bugs.webkit.org/show_bug.cgi?id=55002
3397
3398         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
3399         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
3400
3401 2011-02-24  Dirk Pranke  <dpranke@chromium.org>
3402
3403         Reviewed by Mihai Parparita.
3404
3405         nrwt: log command used to start web server to --verbose
3406
3407         https://bugs.webkit.org/show_bug.cgi?id=55188
3408
3409         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
3410         * Scripts/webkitpy/layout_tests/port/http_server.py:
3411
3412 2011-02-24  Victoria Kirst  <vrk@google.com>
3413
3414         Reviewed by Mihai Parparita.
3415
3416         [chromium] Move media-file.js and video-test.js back to media/ for UILayoutTests
3417         https://bugs.webkit.org/show_bug.cgi?id=55089
3418
3419         This adds an alias into the media/ directory so that http/tests/media
3420         tests can access the media resources when running in an httpd process.
3421
3422         * Scripts/webkitperl/httpd.pm:
3423         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
3424         * Scripts/webkitpy/layout_tests/port/http_server.py:
3425
3426 2011-02-24  Dirk Pranke  <dpranke@chromium.org>
3427
3428         Reviewed by Mihai Parparita.
3429
3430         nrwt: enable multiple processes by default on Chromium Win.
3431
3432         https://bugs.webkit.org/show_bug.cgi?id=55163
3433
3434         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3435         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
3436
3437 2011-02-24  Sam Weinig  <sam@webkit.org>
3438
3439         Attempt to fix Qt.
3440
3441         * WebKitTestRunner/TestInvocation.cpp:
3442
3443 2011-02-24  James Robinson  <jamesr@chromium.org>
3444
3445         Unreviewed, rolling out r79598.
3446         http://trac.webkit.org/changeset/79598
3447         https://bugs.webkit.org/show_bug.cgi?id=55089
3448
3449         Appears to be causing trouble with httpd on windows
3450
3451         * Scripts/webkitperl/httpd.pm:
3452         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
3453         * Scripts/webkitpy/layout_tests/port/http_server.py:
3454
3455 2011-02-24  Sam Weinig  <sam@webkit.org>
3456
3457         Reviewed by Darin Adler.
3458
3459         Add basic pixel testing support to WebKitTestRunner
3460         https://bugs.webkit.org/show_bug.cgi?id=55161
3461
3462         * Scripts/old-run-webkit-tests:
3463         Don't print color space information when using WebKitTestRunner since
3464         we don't need to change the screen.
3465
3466         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3467         (WTR::InjectedBundle::initialize):
3468         Add call to initializePlatformDefaults.
3469         
3470         (WTR::InjectedBundle::done):
3471         Return a dictionary on completion with both the text output and pixel dump override.
3472
3473         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3474         Add declaration for initializePlatformDefaults.
3475
3476         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3477         (WTR::LayoutTestController::LayoutTestController):
3478         (WTR::LayoutTestController::dumpAsText):
3479         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3480         (WTR::LayoutTestController::shouldDumpPixels):
3481         Make setting dumpAsText override the dump pixels preference.
3482
3483         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm: Added.
3484         (WTR::InjectedBundle::initializePlatformDefaults):
3485         Set platform defaults matching DumpRenderTree.
3486
3487         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp: Added.
3488         (WTR::InjectedBundle::initializePlatformDefaults):
3489         * WebKitTestRunner/InjectedBundle/win/InjectedBundleWin.cpp: Added.
3490         (WTR::InjectedBundle::initializePlatformDefaults):
3491         Add stubs for initializePlatformDefaults.
3492
3493         * WebKitTestRunner/TestController.cpp:
3494         (WTR::TestController::runTest):
3495         (WTR::TestController::runTestingServerLoop):
3496         (WTR::TestController::run):
3497         Parse expected pixel results out of stdin and setup the invocation with it.
3498
3499         * WebKitTestRunner/TestInvocation.cpp:
3500         (WTR::TestInvocation::TestInvocation):
3501         Initialize new members.
3502
3503         (WTR::TestInvocation::~TestInvocation):
3504         (WTR::TestInvocation::setIsPixelTest):
3505         (WTR::sizeWebViewForCurrentTest):
3506         (WTR::TestInvocation::invoke):
3507         (WTR::TestInvocation::dump):
3508         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3509         * WebKitTestRunner/TestInvocation.h:
3510         Dump pixels in addition to text by calling dumpPixelsAndCompareWithExpected.
3511
3512         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3513         (WTR::PlatformWebView::PlatformWebView):
3514         Use -[NSColorSpace genericRGBColorSpace] instead of the main screen color space.
3515
3516         * WebKitTestRunner/mac/TestInvocationMac.mm: Added.
3517         (WTR::createCGContextFromPlatformView):
3518         (WTR::computeMD5HashStringForContext):
3519         (WTR::dumpBitmap):
3520         (WTR::forceRepaintFunction):
3521         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
3522         Add mac specific pixel dumping support. Right now, we always pull pixels
3523         from the window server.
3524
3525         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3526         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3527         * WebKitTestRunner/qt/WebKitTestRunner.pro:
3528         * WebKitTestRunner/win/InjectedBundle.vcproj:
3529         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
3530         Add new files.
3531
3532 2011-02-24  Chang Shu  <cshu@webkit.org>
3533
3534         Reviewed by Kenneth Rohde Christiansen.
3535
3536         [Qt] Launch MiniBrowser if the test run is WebKit2. 
3537         https://bugs.webkit.org/show_bug.cgi?id=55145
3538
3539         * Scripts/old-run-webkit-tests:
3540         * Scripts/run-launcher:
3541         * Scripts/webkitdirs.pm:
3542
3543 2011-02-24  Victoria Kirst  <vrk@google.com>
3544
3545         Reviewed by Mihai Parparita.
3546
3547         [chromium] Move media-file.js and video-test.js back to media/ for UILayoutTests
3548         https://bugs.webkit.org/show_bug.cgi?id=55089
3549
3550         This adds an alias into the media/ directory so that http/tests/media
3551         tests can access the media resources when running in an httpd process.
3552
3553         * Scripts/webkitperl/httpd.pm:
3554         * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
3555         * Scripts/webkitpy/layout_tests/port/http_server.py:
3556
3557 2011-02-24  Andrew Wilson  <atwilson@chromium.org>
3558
3559         Unreviewed, rolling out r79570.
3560         http://trac.webkit.org/changeset/79570
3561         https://bugs.webkit.org/show_bug.cgi?id=54874
3562
3563         Breaks chromium build because glue/mocks/mock_web_frame.h/cc
3564         was not updated
3565
3566         * DumpRenderTree/chromium/TestShell.cpp:
3567         (TestShell::resetTestController):
3568         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3569         (resetDefaultsToConsistentValues):
3570         * DumpRenderTree/mac/DumpRenderTree.mm:
3571         (resetWebViewToConsistentStateBeforeTesting):
3572         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3573         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
3574         * DumpRenderTree/win/DumpRenderTree.cpp:
3575         (resetWebViewToConsistentStateBeforeTesting):
3576         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3577         (WTR::InjectedBundlePage::reset):
3578
3579 2011-02-24  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>
3580
3581         Reviewed by Laszlo Gombos.
3582
3583         [Qt] add android 2.2 user agent to QtTestBrowser
3584         https://bugs.webkit.org/show_bug.cgi?id=55085
3585
3586         Credit to Forrest Hodgkins to find right user-agent which works for youtube.
3587         * QtTestBrowser/useragentlist.txt:
3588
3589 2011-02-24  Adam Roben  <aroben@apple.com>
3590
3591         Change FrameLoadDelegate to support any number of delegates with delayed work to process
3592
3593         This makes our behavior match Mac more closely, and allows us to remove an incorrect
3594         assertion that was firing during some tests. (The assertion was claiming that there was
3595         never more than one delegate with delayed work to process, but that was not the case.)
3596
3597         Fixes <http://webkit.org/b/55146> Assertion failure in FrameLoadDelegate::locationChangeDone
3598         when running http/tests/navigation/back-twice-without-commit.html
3599
3600         Reviewed by Eric Carlson.
3601
3602         * DumpRenderTree/win/FrameLoadDelegate.cpp:
3603         (delegatesWithDelayedWork): Added. Returns all FrameLoadDelegates that have delayed work to
3604         process. A single delegate may appear in this Vector more than once (just as, on Mac, a
3605         single delegate may have multiple performSelector requests).
3606         (processWorkTimer): Pass the HWND to ::KillTimer, for pedantic brownie points. Added an
3607         assertion that the timer firing is the shared process work timer. Instead of using the
3608         single, global "delegate waiting for timer" delegate, give all delegates that have delayed
3609         work to process a chance to process their work.
3610         (FrameLoadDelegate::locationChangeDone): If we don't already have an active timer for
3611         processing delayed work, create one. Then add ourselves to the delegatesWithDelayedWork
3612         Vector so our processWork function will be called when the timer fires.
3613
3614 2011-02-24  Vsevolod Vlasov  <vsevik@chromium.org>
3615
3616         Reviewed by Alexey Proskuryakov.
3617
3618         DumpRenderTree should reset frame opener between tests.
3619         https://bugs.webkit.org/show_bug.cgi?id=54874
3620
3621         Added clearOpener() calls between tests.
3622         Some tests are using window.open() to change current window location.
3623         This changes window.opener property whose nullity is checked before
3624         showing xml viewer.
3625
3626         * DumpRenderTree/chromium/TestShell.cpp:
3627         (TestShell::resetTestController):
3628         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3629         (resetDefaultsToConsistentValues):
3630         * DumpRenderTree/mac/DumpRenderTree.mm:
3631         (resetWebViewToConsistentStateBeforeTesting):
3632         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3633         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
3634         * DumpRenderTree/win/DumpRenderTree.cpp:
3635         (resetWebViewToConsistentStateBeforeTesting):
3636         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3637         (WTR::InjectedBundlePage::reset):
3638
3639 2011-02-24  Adam Roben  <aroben@apple.com>
3640
3641         Don't trigger Windows builds for changes to WebCore.exp.in or the top-level GNUmakefile.am
3642
3643         Fixes <http://webkit.org/b/55144> Windows builders should not have built r79343 or r79440,
3644         but did
3645
3646         Reviewed by Anders Carlsson.
3647
3648         * Scripts/webkitpy/common/config/build.py:
3649         (_should_file_trigger_build): Loosened the pattern for GNUmakefile.am to include the
3650         top-level GNUmakefile.am, and loosened the pattern for .exp files to include WebCore.exp.in.
3651
3652         * Scripts/webkitpy/common/config/build_unittest.py:
3653         (ShouldBuildTest): Added some more tests.
3654
3655 2011-02-24  Andras Becsi  <abecsi@webkit.org>
3656
3657         Reviewed by Laszlo Gombos.
3658
3659         [Qt] MinGW build fails to link
3660         https://bugs.webkit.org/show_bug.cgi?id=55050
3661
3662         Prepend the libraries of subcomponents instead of appending them
3663         to fix the library order according to the dependency of the libraries
3664
3665         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3666         * WebKitTestRunner/qt/WebKitTestRunner.pro:
3667
3668 2011-02-24  Gabor Loki  <loki@webkit.org>
3669
3670         Reviewed by Csaba Osztrogonác.
3671
3672         [Qt] Remove ARMv5 Release buildbot.
3673
3674         Remove ARMv5 Release buildbot, because there is very little difference
3675         between ARMv5 and ARMv7 Release bots, and there is also very little
3676         interest in ARMv5 build slave (compared to ARMv7).
3677
3678         * BuildSlaveSupport/build.webkit.org-config/config.json:
3679         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3680
3681 2011-02-22  Ojan Vafai  <ojan@chromium.org>
3682
3683         Reviewed by Tony Chang.
3684
3685         fix revision number finding when creating git patches
3686         https://bugs.webkit.org/show_bug.cgi?id=55024
3687
3688         HEAD~n does not walk merge commits correctly. git log however does.
3689
3690         * Scripts/webkitpy/common/checkout/scm.py:
3691         * Scripts/webkitpy/common/checkout/scm_unittest.py:
3692
3693 2011-02-23  Kenneth Russell  <kbr@google.com>
3694
3695         Unreviewed, rolling out r79387.
3696         https://bugs.webkit.org/show_bug.cgi?id=54885
3697
3698         Reapply the code changes from r79038 since they weren't the root
3699         cause of the test timeouts.
3700
3701         * DumpRenderTree/chromium/WebViewHost.cpp:
3702         (WebViewHost::reset):
3703
3704 2011-02-23  Siddharth Mathur  <siddharth.mathur@nokia.com>
3705
3706         Reviewed by Laszlo Gombos.
3707
3708         [Qt] Make sure Symbian binary UIDs are unique
3709
3710         * MiniBrowser/qt/MiniBrowser.pro: Resolve the UID collision with
3711         QtTestBrowser.pro by changing the UID.
3712
3713 2011-02-23  Patrick Gansterer  <paroga@webkit.org>
3714
3715         Reviewed by Darin Adler.
3716
3717         Rename PLATFORM(CF) to USE(CF)
3718         https://bugs.webkit.org/show_bug.cgi?id=53540
3719
3720         * DumpRenderTree/config.h:
3721
3722 2011-02-23  Dirk Pranke  <dpranke@chromium.org>
3723
3724         Reviewed by Ojan Vafai.
3725