2011-01-24 Maciej Stachowiak <mjs@apple.com>
[WebKit.git] / Tools / ChangeLog
1 2011-01-24  Maciej Stachowiak  <mjs@apple.com>
2
3         Reviewed by Dan Bernstein.
4
5         Implement database quota callback to fix storage tests on WebKit2 bot
6         https://bugs.webkit.org/show_bug.cgi?id=53064
7
8         * WebKitTestRunner/TestController.cpp:
9         (WTR::exceededDatabaseQuota):
10         (WTR::TestController::createOtherPage):
11         (WTR::TestController::initialize):
12
13 2011-01-24  Maciej Stachowiak  <mjs@apple.com>
14
15         Reviewed by Anders Carlsson.
16
17         Use designated temp directory for the database for WebKit2
18         https://bugs.webkit.org/show_bug.cgi?id=53052
19         
20         Adopt the new WK2 API for this.
21
22         * WebKitTestRunner/TestController.cpp:
23         (WTR::TestController::libraryPathForTesting):
24         (WTR::TestController::initialize):
25         * WebKitTestRunner/TestController.h:
26         * WebKitTestRunner/mac/TestControllerMac.mm:
27         (WTR::TestController::platformLibraryPathForTesting):
28         * WebKitTestRunner/qt/TestControllerQt.cpp:
29         (WTR::TestController::platformLibraryPathForTesting):
30         * WebKitTestRunner/win/TestControllerWin.cpp:
31         (WTR::TestController::platformLibraryPathForTesting):
32
33 2011-01-24  Lucas Forschler  <lforschler@apple.com>
34
35         Reviewed by Stephanie Lewis.
36
37         Add a new Leopard test bot.
38
39         * BuildSlaveSupport/build.webkit.org-config/config.json:
40
41 2011-01-24  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
42
43         Reviewed by Adam Barth.
44
45         Add EFL Builder to core waterfall
46         https://bugs.webkit.org/show_bug.cgi?id=52704
47
48         Add EFL Builder to the core waterfall again.
49
50         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
51         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
52
53 2011-01-24  Xianzhu Wang  <wangxianzhu@google.com>
54
55         Reviewed by Tony Chang.
56
57         new-run-webkit-tests fails to start HTTP server if there are proxy settings
58         https://bugs.webkit.org/show_bug.cgi?id=52872
59
60         Force disabling proxy to resolve the problem.
61
62         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
63         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
64
65 2011-01-24  Andreas Kling  <kling@webkit.org>
66
67         Reviewed by Darin Adler.
68
69         check-webkit-style: Update exemptions following Source/ move.
70         https://bugs.webkit.org/show_bug.cgi?id=53017
71
72         * Scripts/webkitpy/style/checker.py:
73         * Scripts/webkitpy/style/checker_unittest.py:
74
75 2011-01-24  Andras Becsi  <abecsi@webkit.org>
76
77         Rubber-stamped by Csaba Osztrogonác.
78
79         [Qt] Move project files into Source
80         https://bugs.webkit.org/show_bug.cgi?id=52891
81
82         * DumpRenderTree/qt/ImageDiff.pro: Add missing "Source" to WebKit.pri path
83
84 2011-01-24  Mikhail Naganov  <mnaganov@chromium.org>
85
86         Reviewed by Yury Semikhatsky.
87
88         Web Inspector: Find duplicate strings in localizedStrings.js
89
90         https://bugs.webkit.org/show_bug.cgi?id=53005
91
92         * Scripts/check-inspector-strings:
93
94 2011-01-24  Zoltan Horvath  <zoltan@webkit.org>
95
96         Reviewed by Andreas Kling.
97
98         [Qt] Regroup MiniBrowser's menubar and add open file action
99         https://bugs.webkit.org/show_bug.cgi?id=53000
100
101         Add File and Develop menu to MiniBrowser's menubar and add open file action to File menu.
102
103         * MiniBrowser/qt/BrowserWindow.cpp:
104         (BrowserWindow::BrowserWindow):
105         (BrowserWindow::openFile):
106         (BrowserWindow::~BrowserWindow):
107         * MiniBrowser/qt/BrowserWindow.h:
108
109 2011-01-24  Csaba Osztrogonác  <ossy@webkit.org>
110
111         Unreviewed fix after r76496
112
113         [Qt] Move project files into Source
114         https://bugs.webkit.org/show_bug.cgi?id=52891
115
116         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Remove unnecessary "Source" from the path.
117         * BuildSlaveSupport/built-product-archive: Remove unnecessary "Source" from the path.
118         * Scripts/webkitdirs.pm: Add the accidentally removed slash to the path.
119
120 2011-01-24  Andras Becsi  <abecsi@webkit.org>
121
122         Reviewed by Csaba Osztrogonác.
123
124         [Qt] Move project files into Source
125         https://bugs.webkit.org/show_bug.cgi?id=52891
126
127         * DerivedSources.pro: Renamed from DerivedSources.pro.
128         * DumpRenderTree/qt/DumpRenderTree.pro:
129         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
130         * MiniBrowser/DerivedSources.pro:
131         * MiniBrowser/qt/MiniBrowser.pro:
132         * QtTestBrowser/QtTestBrowser.pro:
133         * Scripts/webkitdirs.pm:
134         * Tools.pro: Added.
135         * WebKitTestRunner/DerivedSources.pro:
136         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
137         * WebKitTestRunner/qt/WebKitTestRunner.pro:
138
139 2011-01-22  Geoffrey Garen  <ggaren@apple.com>
140
141         Reviewed by Dan Bernstein.
142
143         Beefed up --threaded mode to catch even more kinds of errors.
144         https://bugs.webkit.org/show_bug.cgi?id=52971
145
146         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Use a shared
147         context group to force JSC to mark multiple threads. (This used to be
148         the default, but it changed in SnowLeopard.)
149         (runJavaScriptThread): Do more locking and unlocking, and more allocation,
150         to give threading mistakes more chances to show themselves.
151         (startJavaScriptThreads):
152         (stopJavaScriptThreads):
153
154 2011-01-22  Robert Hogan  <robert@webkit.org>
155
156         Reviewed by Andreas Kling.
157
158         [Qt] Support layoutTestController.addURLToRedirect()
159         https://bugs.webkit.org/show_bug.cgi?id=52956
160
161         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
162         (LayoutTestController::addURLToRedirect):
163         * DumpRenderTree/qt/LayoutTestControllerQt.h:
164
165 2011-01-22  Robert Hogan  <robert@webkit.org>
166
167         Reviewed by Kenneth Rohde Christiansen.
168
169         [Qt] REGRESSION (r72360): http/tests/security/aboutBlank/xss-DENIED-* tests fail
170         https://bugs.webkit.org/show_bug.cgi?id=49802
171
172         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
173         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
174         (WebCore::DumpRenderTree::open):
175
176 2011-01-21  Adam Barth  <abarth@webkit.org>
177
178         Reviewed by Maciej Stachowiak.
179
180         Disable mac_unittest.py that fails on some of the Mac bots
181         https://bugs.webkit.org/show_bug.cgi?id=52947
182
183         As noted in the comment, this test does not appear to be correct
184         because the function this test is testing returns different results
185         depending on which flavor of Mac the test is run on.  This patch
186         disable the test.  Hopefully we can re-enable the test once we've
187         probably insulated the test from its environment.
188
189         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
190
191 2011-01-21  Dirk Pranke  <dpranke@chromium.org>
192
193         Reviewed by Mihai Parparita.
194
195         Fix bug introduced in r76322 that caused NRWT to not actually
196         read the Skipped files properly.
197
198         https://bugs.webkit.org/show_bug.cgi?id=52771
199
200         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
201         * Scripts/webkitpy/layout_tests/port/webkit.py:
202         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
203
204 2011-01-21  Sam Weinig  <sam@webkit.org>
205
206         Reviewed by Geoffrey Sean Garen and Mark Rowe.
207
208         WebKitTestRunner needs the HOME environment variable to be set.
209         <rdar://problem/8896573>
210
211         * Scripts/old-run-webkit-tests: Set the HOME environment variable if
212         it exists.
213
214 2011-01-21  Dirk Pranke  <dpranke@chromium.org>
215
216         Reviewed by Eric Seidel.
217
218         Suppress a few remaining integration tests so that none of the
219         layout_test unit tests ever read from the filesystem or launch
220         subprocesses that aren't part of the unit tests.
221
222         Also fix a minor bug in the printing unit tests that was
223         incorrectly relying on sys.argv.
224
225         https://bugs.webkit.org/show_bug.cgi?id=52863
226
227         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
228         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
229         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
230
231 2011-01-21  Darin Adler  <darin@apple.com>
232
233        Fix Mac build.
234
235         * MiniBrowser/mac/BrowserWindowController.m:
236         (-[BrowserWindowController awakeFromNib]): Pass 0 for runModal function.
237
238 2011-01-20  Darin Adler  <darin@apple.com>
239
240         Reviewed by Dan Bernstein.
241
242         WebKit2: Implement showModalDialog
243         https://bugs.webkit.org/show_bug.cgi?id=52855
244
245         This fixes WebKitTestRunner to compile, but more work is probably
246         needed to get it to pass the tests.
247
248         * WebKitTestRunner/TestController.cpp:
249         (WTR::TestController::runModal): Added. Calls through to the
250         platform-specific version of runModal.
251         (WTR::TestController::createOtherPage): Changed to be a private
252         static member function so it can refer to runModal, which is
253         a private static member function.
254         (WTR::TestController::initialize): Pass 0 for the runModal
255         function since we don't need to run the main window modal.
256         I suspect this is wrong and will need to change.
257         * WebKitTestRunner/TestController.h: Added declarations for
258         the functions added above.
259         * WebKitTestRunner/mac/TestControllerMac.mm:
260         (WTR::TestController::runModal): Added. Untested implementation.
261         * WebKitTestRunner/qt/TestControllerQt.cpp:
262         (WTR::TestController::runModal): Added.
263         * WebKitTestRunner/win/TestControllerWin.cpp:
264         (WTR::TestController::runModal): Added.
265
266 2011-01-21  Eric Seidel  <eric@webkit.org>
267
268         Reviewed by Adam Barth.
269
270         Split Host object off from WebKitPatch for easier re-use
271         https://bugs.webkit.org/show_bug.cgi?id=52284
272
273         new-run-webkit-tests and other tools are eventually going to want one of these.
274         Basically you need to inherit from this class if you want to pretend to be a
275         self.tool object for Steps/Commands.
276
277         * Scripts/webkitpy/common/host.py: Added.
278         * Scripts/webkitpy/tool/main.py:
279
280 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
281
282         Reviewed by Adam Barth.
283
284         Disable the tests that start and stop the http server and web
285         server, so that we don't have to worry about port collisions on
286         the bots.
287
288         https://bugs.webkit.org/show_bug.cgi?id=52861
289
290         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
291
292 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
293
294         Reviewed by Eric Seidel.
295
296         nrwt: rewrite google_chrome_unittest to use mock filesystem.
297         
298         https://bugs.webkit.org/show_bug.cgi?id=52772
299         
300         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
301
302 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
303
304         Reviewed by Eric Siedel.
305
306         nrwt: clean up almost all remaining port references, remove
307         unnecessary import clauses. The only remaining references are
308         in places where a mock filesystem makes no sense or can't be
309         used, and in one routine in port/google_chrome_unittest that
310         I'll rewrite in a separate patch.
311
312         https://bugs.webkit.org/show_bug.cgi?id=52771
313
314         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
315         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
316         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
317         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
318         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
319         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
320         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
321         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
322         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
323         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
324         * Scripts/webkitpy/layout_tests/port/gtk.py:
325         * Scripts/webkitpy/layout_tests/port/mac.py:
326         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
327         * Scripts/webkitpy/layout_tests/port/qt.py:
328         * Scripts/webkitpy/layout_tests/port/webkit.py:
329         * Scripts/webkitpy/layout_tests/port/win.py:
330         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
331
332 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
333
334         Reviewed by Mihai Parparita.
335
336         remove fs refs from run_webkit_tests, rebaseline_chromium_webkit_tests
337
338         https://bugs.webkit.org/show_bug.cgi?id=52762
339
340         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
341         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
342
343 2011-01-20  Tony Chang  <tony@chromium.org>
344
345         Reviewed by Ojan Vafai.
346
347         [chromium] fix the paths used for the rebaseline tool
348         https://bugs.webkit.org/show_bug.cgi?id=52857
349
350         Some of the bots were renamed so the path to grab the results zip
351         file has changed.
352
353         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
354
355 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
356
357         Reviewed by Tony Chang.
358
359         Fix bug introduced in r72688 / bug 52768 that broke the
360         generation of the output filename links in the results.html
361         output. Apparently none of the unit tests actually checked to
362         make sure the generated links were correct :(
363
364         https://bugs.webkit.org/show_bug.cgi?id=52854
365
366         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
367         * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
368
369 2011-01-20  Alexey Proskuryakov  <ap@apple.com>
370
371         Reviewed by Darin Adler.
372
373         https://bugs.webkit.org/show_bug.cgi?id=52849
374         Make window.print work with WebKit2
375
376         * MiniBrowser/mac/BrowserWindowController.m:
377         (-[BrowserWindowController awakeFromNib]):
378         * WebKitTestRunner/TestController.cpp:
379         (WTR::createOtherPage):
380         (WTR::TestController::initialize):
381         Added zeroes to WKPageUIClient structures to avoid build failures.
382
383 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
384
385         Reviewed by Eric Seidel.
386
387         nrwt: remove fs refs from printing, test_failures, test_expectations, text_diff
388
389         https://bugs.webkit.org/show_bug.cgi?id=52756
390
391         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
392         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
393         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
394         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
395         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
396         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
397
398 2011-01-20  Mansi Mithal  <mansi.mithal@nokia.com>
399
400         Reviewed by Antonio Gomes.
401
402         QtTestBrowser should have a seperate menu for Settings
403         https://bugs.webkit.org/show_bug.cgi?id=52817
404         
405         Added a new menu item named "Settings"
406         and moved the "Enable interrupting js scripts" and "Enable js pop up windows" under the "Settings" menu 
407
408         * QtTestBrowser/launcherwindow.cpp:
409         (LauncherWindow::createChrome):
410
411 2011-01-20  Sam Weinig  <sam@webkit.org>
412
413         Reviewed by John Sullivan.
414
415         Update update-webkit-localizable-strings with new path to WebKit.
416
417         * Scripts/update-webkit-localizable-strings:
418
419 2011-01-20  James Robinson  <jamesr@chromium.org>
420
421         Reviewed by Darin Fisher.
422
423         Implement mozilla's requestAnimationFrame API
424         https://bugs.webkit.org/show_bug.cgi?id=51218
425
426         Chromium DumpRenderTree support for window.webkitRequestAnimationFrame.
427
428         * DumpRenderTree/chromium/WebViewHost.cpp:
429         (invokeScheduleComposite):
430         (WebViewHost::scheduleAnimation):
431         (WebViewHost::paintInvalidatedRegion):
432         * DumpRenderTree/chromium/WebViewHost.h:
433
434 2011-01-20  Maciej Stachowiak  <mjs@apple.com>
435
436         Reviewed by Adam Roben.
437
438         WebKitTestRunner needs to support layoutTestController.evaluateScriptInIsolatedWorld
439         https://bugs.webkit.org/show_bug.cgi?id=42327
440
441         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm: Add support
442         for methods that take their normal arguments but also a JSContextRef.
443         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: IDL definition
444         for evaluateScriptInIsolatedWorld.
445         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
446         (WTR::InjectedBundlePage::didClearWindowForFrame): Set a magic variable only if
447         this call is for an isolated world.
448         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
449         (WTR::worldMap): Helper to create a world map.
450         (WTR::LayoutTestController::worldIDForWorld): Map from an ID to a world.
451         (WTR::LayoutTestController::evaluateScriptInIsolatedWorld): The newly
452         added LayoutTestController API.
453         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
454
455 2011-01-19  Adam Roben  <aroben@apple.com>
456
457         Convert paths in environment variables back to msys-style inside commit-log-editor
458
459         When this script gets run from inside git commit, msys-style paths in the environment will
460         have been turned into Windows-style paths with forward slashes. This screws up functions
461         like File::Spec->rel2abs, which seem to rely on $PWD having an msys-style path. We convert
462         the paths back to msys-style before doing anything else.
463
464         Fixes <http://webkit.org/b/48527> commit-log-editor uses full paths for section headers when
465         using msysgit's Perl and multiple ChangeLogs have been edited
466
467         Reviewed by David Kilzer.
468
469         * Scripts/commit-log-editor: Call fixEnvironment before doing anything else.
470         (fixEnvironment): Added. When run in msys in conjunction with git (i.e., when invoked from
471         inside git commit), convert Windows-style paths in the environment back to msys-style paths.
472
473 2011-01-20  Zoltan Horvath  <zoltan@webkit.org>
474
475         [Win] Unreviewed build fix after r76248.
476
477         * DumpRenderTree/ForwardingHeaders/wtf/FastAllocBase.h: Added.
478
479 2011-01-20  Zoltan Horvath  <zoltan@webkit.org>
480
481         Reviewed by Csaba Osztrogonác.
482
483         Refactoring of the custom allocation framework
484         https://bugs.webkit.org/show_bug.cgi?id=49897
485
486         Inheriting from FastAllocBase can result in objects getting larger (bug #33896, #46589).
487         The modification replaces Noncopyable and FastAllocBase classes and these inherits with their
488         equivalent macro implementation at the necessary places.
489 2011-01-20  Yi Shen  <yi.4.shen@nokia.com>
490
491         Unreviewed. 
492
493         Adding myself to committers.py.
494
495         * Scripts/webkitpy/common/config/committers.py:
496
497 2011-01-20  Adam Barth  <abarth@webkit.org>
498
499         Reviewed by Tony Chang.
500
501         Chromium builders don't delete unversioned directories when DEPS change
502         https://bugs.webkit.org/show_bug.cgi?id=52745
503
504         If we pass this option to gclient sync, gclient will delete directories
505         that are no longer part of DEPS instead of leaving them around to
506         confuse us later.  Apparently, the downstream buildbots use this option
507         already.
508
509         * Scripts/update-webkit-chromium:
510
511 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
512
513         Unreviewed, build fix - I pulled this patch in to fix an issue
514         revealed by r76195 running on some new bots). Also fix a couple
515         of other issues revealed in testing.
516
517         nrwt: remove fs refs from layout_package/json*
518
519         https://bugs.webkit.org/show_bug.cgi?id=52754
520
521         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
522         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
523         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
524         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
525         * Scripts/webkitpy/layout_tests/port/base.py:
526
527 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
528
529         Unreviewed, build fix.
530
531         Fix a couple of minor bugs discovered while bringing up new bots
532         for testing.
533
534         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
535         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
536
537 2011-01-19  James Robinson  <jamesr@chromium.org>
538
539         Unreviewed, rolling out r76194.
540         http://trac.webkit.org/changeset/76194
541         https://bugs.webkit.org/show_bug.cgi?id=51218
542
543         Caused mysterious compile failure on the chromium win
544         build.webkit.org bots
545
546         * DumpRenderTree/chromium/WebViewHost.cpp:
547         (WebViewHost::paintInvalidatedRegion):
548         * DumpRenderTree/chromium/WebViewHost.h:
549
550 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
551
552         Reviewed by Mihai Parparita.
553
554         remove fs refs from test_runner, dump_render_tree_thread
555
556         https://bugs.webkit.org/show_bug.cgi?id=52753
557
558         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
559         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
560         * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
561         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
562
563 2011-01-19  James Robinson  <jamesr@chromium.org>
564
565         Reviewed by Darin Fisher.
566
567         Implement mozilla's requestAnimationFrame API
568         https://bugs.webkit.org/show_bug.cgi?id=51218
569
570         Chromium DumpRenderTree support for window.webkitRequestAnimationFrame.
571
572         * DumpRenderTree/chromium/WebViewHost.cpp:
573         (invokeScheduleComposite):
574         (WebViewHost::scheduleAnimation):
575         (WebViewHost::paintInvalidatedRegion):
576         * DumpRenderTree/chromium/WebViewHost.h:
577
578 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
579
580         Unreviewed, build fix.
581
582         Fix a few incorrect "self._filesystem" references introduced in
583         r76184.
584
585         * Scripts/webkitpy/layout_tests/port/chromium.py:
586         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
587
588 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
589
590         Reviewed by Mihai Parparita.
591
592         add a .sep property, abspath(), isabs(), mtime(), and
593         open_text_file_for_writing() to filesystem modules. Some of
594         these properties are not needed in this patch but will be needed
595         in subsequent patches (I'm doing this to avoid having to track
596         multiple versions of a single file).
597
598         Also, change most of the port/* modules to use the filesystem
599         objects instead of referencing the filesystem directly.
600
601         https://bugs.webkit.org/show_bug.cgi?id=52748
602
603         * Scripts/webkitpy/common/system/filesystem.py:
604         * Scripts/webkitpy/common/system/filesystem_mock.py:
605         * Scripts/webkitpy/layout_tests/port/__init__.py:
606         * Scripts/webkitpy/layout_tests/port/base.py:
607         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
608         * Scripts/webkitpy/layout_tests/port/chromium.py:
609         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
610         * Scripts/webkitpy/layout_tests/port/config.py:
611         * Scripts/webkitpy/layout_tests/port/test.py:
612         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
613
614 2011-01-19  Maciej Stachowiak  <mjs@apple.com>
615
616         Reviewed by Anders Carlsson.
617
618         If resetting between tests times out, treat it as a WebProcess crash
619         https://bugs.webkit.org/show_bug.cgi?id=52757
620
621         * WebKitTestRunner/TestController.cpp:
622         (WTR::TestController::runTest):
623
624 2011-01-19  Alexey Proskuryakov  <ap@apple.com>
625
626         Reviewed by Darin Adler.
627
628         https://bugs.webkit.org/show_bug.cgi?id=52739
629         Make it possible for a WebKit2 client to print headers and footers
630
631         Added dummy implementations for new printing UIClient calls.
632
633         * MiniBrowser/mac/BrowserWindowController.m:
634         (-[BrowserWindowController awakeFromNib]):
635         * WebKitTestRunner/TestController.cpp:
636         (WTR::createOtherPage):
637         (WTR::TestController::initialize):
638
639 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
640
641         Reviewed by Ojan Vafai.
642
643         Change webkitpy/layout_tests/port/test.py to use the
644         in-memory filesystem for cleaner unit testing. This
645         change allows us to kill a lot of code that was
646         specific to the test port, at the cost of being a
647         little less clear about how things would work if
648         you didn't have a filesystem.
649
650         https://bugs.webkit.org/show_bug.cgi?id=52605
651
652         * Scripts/webkitpy/layout_tests/port/test.py:
653
654 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
655
656         Unreviewed, build fix.
657
658         Fix test failure caused by committing attachment 79368 instead
659         of attachment 79461 on bug 52604.
660
661         * Scripts/webkitpy/common/system/filesystem_mock.py:
662
663 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
664
665         Reviewed by Mihai Parparita.
666
667         new-run-webkit-tests: remove use of os.walk, use mock filesystem for better
668         unit testing. os.walk() is too much of a hassle to implement on
669         top of the in-memory mock filesystem and adding the necessary
670         interface to files_under() gives clients a cleaner API anyway
671         (for this particular usage model).
672
673         https://bugs.webkit.org/show_bug.cgi?id=52691
674
675         * Scripts/webkitpy/common/system/filesystem.py:
676         * Scripts/webkitpy/common/system/filesystem_mock.py:
677         * Scripts/webkitpy/layout_tests/port/test_files.py:
678         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
679
680 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
681
682         Reviewed by Tony Chang.
683
684         Change more modules in the layout-tests code to use the
685         filesystem wrapper for cleaner unit testing.
686
687         This patch also adds the glob() wrapper to the filesystem
688         abstraction.
689         
690         https://bugs.webkit.org/show_bug.cgi?id=52604
691
692         * Scripts/webkitpy/layout_tests/port/test_files.py:
693         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
694         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
695         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
696         * Scripts/webkitpy/common/system/filesystem.py:
697         * Scripts/webkitpy/common/system/filesystem_mock.py:
698
699 2011-01-19  Levi Weintraub  <leviw@chromium.org>
700
701         Unreviewed.
702
703         Updating my email addresses and irc nick.
704
705         * Scripts/webkitpy/common/config/committers.py:
706
707 2011-01-19  Tony Chang  <tony@chromium.org>
708
709         Reviewed by Mihai Parparita.
710
711         [chromium] [linux] if check-sys-deps fails, output the failure reason
712         https://bugs.webkit.org/show_bug.cgi?id=52671
713
714         * Scripts/webkitpy/common/system/executive_mock.py: Add support for
715             error handler functions.
716         * Scripts/webkitpy/layout_tests/port/chromium.py:
717             output the error text from --check-sys-deps
718         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
719
720 2011-01-19  Aparna Nandyal  <aparna.nand@wipro.com>
721
722         Reviewed by Andreas Kling.
723
724         [Qt] QtTestBrowser crashes when closing if Facebook is opened
725         https://bugs.webkit.org/show_bug.cgi?id=52554
726         
727         QtNetworkAccessManager is created in a thread and set as
728         member variable in QWebPage. When the thread is destroyed
729         the object is still used. So fix will set the object to
730         NULL once the thread is destroyed.
731
732         * QtTestBrowser/launcherwindow.cpp:
733         (LauncherWindow::~LauncherWindow):
734
735 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
736
737         Rubber stamped by Csaba Osztrogonac
738
739         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: Removed unncessary inculde of WKStringCF.h
740
741 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
742
743         Reviewed by Tony Chang.
744
745         new-run-webkit-tests: add a --build-directory command line argument
746
747         Official Google Chrome builds use a non-standard build directory
748         location. This patch adds a --build-directory argument that
749         allows that location to be specified on the command line. Only
750         Chromium-based builds will use this flag for now, but anyone can
751         in the future.
752
753         There are no unit tests for this since it's difficult to test
754         until mock filesystems are fully supported in the code. This was
755         tested by hand for now.
756
757         https://bugs.webkit.org/show_bug.cgi?id=52694
758
759         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
760         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
761         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
762         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
763
764 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
765
766         Not reviewed. Bot fix.
767
768         Remove an inadvertently committed debugging print.
769
770         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
771         (LayoutTestController::notifyDone):
772
773 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
774
775         Reviewed by Sam Weinig.
776
777         WebKitTestRunner should track loading more like DumpRenderTree
778         https://bugs.webkit.org/show_bug.cgi?id=52692
779
780         Change load tracking to track the current top loading frame, in the manner of DumpRenderTree.
781         This makes some tests that call notifyDone multiple times pass.
782         
783         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
784         (WTR::InjectedBundle::InjectedBundle):
785         (WTR::InjectedBundle::done):
786         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
787         (WTR::InjectedBundle::topLoadingFrame):
788         (WTR::InjectedBundle::setTopLoadingFrame):
789         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
790         (WTR::InjectedBundlePage::InjectedBundlePage):
791         (WTR::InjectedBundlePage::stopLoading):
792         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
793         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
794         (WTR::InjectedBundlePage::didFinishLoadForFrame):
795         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
796         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
797         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
798         (WTR::LayoutTestController::notifyDone):
799         * WebKitTestRunner/TestController.cpp:
800         (WTR::TestController::didReceiveMessageFromInjectedBundle):
801
802 2011-01-18  Mihai Parparita  <mihaip@chromium.org>
803
804         Reviewed by Kent Tamura.
805
806         [Chromium] NRWT looking for DRT binary in the wrong path on Mac
807         https://bugs.webkit.org/show_bug.cgi?id=52678
808         
809         Update path now that WebKit is inside Source.
810
811         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
812
813 2011-01-18  Robert Hogan  <robert@webkit.org>
814
815         Reviewed by Simon Hausmann.
816
817         [Qt] http/tests/incremental/slow-utf8-text.pl fails
818         https://bugs.webkit.org/show_bug.cgi?id=44282
819
820         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
821         (WebCore::DumpRenderTree::dump):
822
823 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
824
825         Reviewed by Mihai Parparita.
826
827         Fix a small race condition that could cause the unit tests for
828         new-run-webkit-tests to fail in a multithreaded environment.
829         There was a small window in the code where one thread would
830         check to see if a thread had raised an exception, do something,
831         and then check to see if the thread was alive. If the other
832         thread raised an exception and exited in between these two
833         steps, the exception would be lost. Flipping the order of the
834         two checks fixes the race, since we will now always check for an
835         exception on the thread before exiting.
836
837         https://bugs.webkit.org/show_bug.cgi?id=51579
838
839         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
840
841 2011-01-18  Eric Seidel  <eric@webkit.org>
842
843         Reviewed by Adam Barth.
844
845         commit-queue dies when test archiving fails
846         https://bugs.webkit.org/show_bug.cgi?id=52617
847
848         I looked at the machine and it had 10 archives already
849         thus find_unused_name was returning None.  I've upped
850         the limit to 100 (per bug) and tested the case where
851         find_unused_name returns None (making archive return None).
852
853         * Scripts/webkitpy/common/system/workspace.py:
854         * Scripts/webkitpy/common/system/workspace_unittest.py:
855         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
856         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
857         * Scripts/webkitpy/tool/commands/queues.py:
858
859 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
860
861         Reviewed by Ojan Vafai.
862
863         Update rebaseline-chromium-webkit-tests unit tests to use a mock
864         filesystem. Also fix a couple of "with" statements missed by
865         r76050.
866
867         https://bugs.webkit.org/show_bug.cgi?id=52487
868
869         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
870
871 2011-01-18  Sergio Villar Senin  <svillar@igalia.com>
872
873         Reviewed by Martin Robinson.
874
875         [Gtk] Build fixes for gtk3 build
876         https://bugs.webkit.org/show_bug.cgi?id=52648
877
878         * DumpRenderTree/gtk/EventSender.cpp:
879         (beginDragWithFilesCallback):
880
881 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
882
883         Reviewed by Mihai Parparita.
884
885         Update rebaseline-chromium-webkit-tests to use filesystem objects
886         instead of direct references to os.path, shutil, tempfile, etc.
887
888         This patch doesn't change anything, but will allow subsequent
889         patches to change the unit tests to no longer use the real
890         filesystem.
891
892         This patch adds a bunch more methods to the filesystem object as
893         well.
894
895         https://bugs.webkit.org/show_bug.cgi?id=52482
896
897         * Scripts/webkitpy/common/system/filesystem.py:
898         * Scripts/webkitpy/common/system/filesystem_mock.py:
899         * Scripts/webkitpy/tool/commands/queues.py:
900         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
901         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
902
903 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
904
905         Reviewed by Mihai Parparita.
906
907         new-run-webkit-tests shouldn't crash when you try to run a
908         directory containing only skipped files.
909
910         https://bugs.webkit.org/show_bug.cgi?id=52478
911         
912         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
913         * Scripts/webkitpy/layout_tests/port/test.py:
914         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
915
916 2011-01-18  Adam Bergkvist  <adam.bergkvist@ericsson.com> and Martin Robinson  <mrobinson@igalia.com>
917
918         Reviewed by Gustavo Noronha Silva.
919
920         [GTK] The GTK+ EventSender needs support for beginDragWithFiles
921         https://bugs.webkit.org/show_bug.cgi?id=40833
922
923         * DumpRenderTree/gtk/EventSender.cpp: Add a beginDragWithFiles implementation for the
924         GTK+ event sender.
925         (dragWithFilesDragDataGetCallback): Added.
926         (dragWithFilesDragEndCallback): Added.
927         (beginDragWithFilesCallback): Added.
928
929 2011-01-18  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
930
931         Reviewed by Adam Barth.
932
933         ews: Add additional watcher to efl ews
934         https://bugs.webkit.org/show_bug.cgi?id=52613
935
936         Add gyuyoung.kim@samsung.com to watcher list of efl-ews.
937
938         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
939
940 2011-01-17  Tony Gentilcore  <tonyg@chromium.org>
941
942         Reviewed by Alexey Proskuryakov.
943
944         Fix some headers with missing or misspelled #ifndef guards
945         https://bugs.webkit.org/show_bug.cgi?id=52545
946
947         * DumpRenderTree/chromium/TestEventPrinter.h:
948         * DumpRenderTree/chromium/WebPreferences.h:
949
950 2011-01-17  Jessie Berlin  <jberlin@apple.com>
951
952         Reviewed by Anders Carlsson.
953
954         REGRESSION: Assertion failure in FrameLoader::continueLoadAfterWillSubmitForm() when
955         navigating back to an unreachable URL
956         https://bugs.webkit.org/show_bug.cgi?id=52388
957
958         Add a third parameter (unreachableURL) to queueLoadHTMLString.
959
960         * DumpRenderTree/LayoutTestController.cpp:
961         (queueLoadHTMLStringCallback):
962         (LayoutTestController::queueLoadHTMLString):
963         (LayoutTestController::queueLoadAlternateHTMLString):
964         * DumpRenderTree/LayoutTestController.h:
965
966         * DumpRenderTree/WorkQueueItem.h:
967         (LoadHTMLStringItem::LoadHTMLStringItem):
968
969         * DumpRenderTree/chromium/LayoutTestController.cpp:
970         (WorkItemLoadHTMLString::WorkItemLoadHTMLString):
971         (WorkItemLoadHTMLString::run):
972         (LayoutTestController::queueLoadHTMLString):
973
974         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
975         (LoadHTMLStringItem::invoke):
976         * DumpRenderTree/mac/WorkQueueItemMac.mm:
977         (LoadHTMLStringItem::invoke):
978         * DumpRenderTree/win/WorkQueueItemWin.cpp:
979         (LoadHTMLStringItem::invoke):
980
981 2011-01-17  Dan Bernstein  <mitz@apple.com>
982
983         Rubber-stamped by Mark Rowe.
984
985         Update xcodeproj svn:ignore to include xcuserdata.
986
987         * DumpRenderTree/DumpRenderTree.xcodeproj: Modified property svn:ignore.
988         * MiniBrowser/MiniBrowser.xcodeproj: Modified property svn:ignore.
989         * TestWebKitAPI/TestWebKitAPI.xcodeproj: Modified property svn:ignore.
990         * WebKitLauncher/WebKitLauncher.xcodeproj: Modified property svn:ignore.
991         * WebKitTestRunner/WebKitTestRunner.xcodeproj: Modified property svn:ignore.
992
993 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
994
995         Unreviewed fix after r75908.
996
997         Move WebKit into Source
998         https://bugs.webkit.org/show_bug.cgi?id=52530
999
1000         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add Source to the path for Qt API tests.
1001
1002 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
1003
1004         Unreviewed.
1005
1006         Remove accidentally committed debug printing after r75908.
1007
1008         * Scripts/webkitdirs.pm:
1009
1010 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
1011
1012         Unreviewed.
1013
1014         Add myself to committers list
1015         https://bugs.webkit.org/show_bug.cgi?id=52566
1016
1017         * Scripts/webkitpy/common/config/committers.py:
1018
1019 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
1020
1021         Reviewed by Jeremy Orlow.
1022
1023         GeolocationController should call stopUpdating on destruction
1024         https://bugs.webkit.org/show_bug.cgi?id=52216
1025
1026         fast/dom/Geolocation/window-close-crash.html requires that a
1027         Geolocation watch be started in a secondary window. Consequently,
1028         we need to allow geolocation permission and provide a mock
1029         geolocation position for the secondary window's
1030         GeolocationClientMock.
1031
1032         * DumpRenderTree/chromium/LayoutTestController.cpp:
1033         (LayoutTestController::setGeolocationPermission):
1034         (LayoutTestController::setMockGeolocationPosition):
1035         (LayoutTestController::setMockGeolocationError):
1036         * DumpRenderTree/chromium/TestShell.h:
1037         (TestShell::windowList):
1038
1039 2011-01-16  Adam Barth  <abarth@webkit.org>
1040
1041         Update more include paths to reflect WebKit move.
1042
1043         * DumpRenderTree/chromium/EventSender.cpp:
1044         (EventSender::keyDown):
1045         (EventSender::needsShiftModifier):
1046         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
1047         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
1048
1049 2011-01-16  Kent Tamura  <tkent@chromium.org>
1050
1051         Unreviewed, Chromium build fix.
1052
1053         * Scripts/update-webkit-chromium: Webkit/chromium -> Source/WebKit/chromium
1054
1055 2011-01-16  Martin Robinson  <mrobinson@igalia.com>
1056
1057         Build fix for GTK+ after source directory movement.
1058
1059         * GNUmakefile.am: Correct include paths.
1060
1061 2011-01-16  Adam Barth  <abarth@webkit.org>
1062
1063         Teach svn-apply about WebKit move.
1064
1065         * Scripts/VCSUtils.pm:
1066
1067 2011-01-16  Adam Barth  <abarth@webkit.org>
1068
1069         Rubber-stamped by Eric Seidel.
1070
1071         Move WebKit into Source
1072         https://bugs.webkit.org/show_bug.cgi?id=52530
1073
1074         * DumpRenderTree/mac/InternalHeaders/WebKit/WebTypesInternal.h:
1075         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1076         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1077         * DumpRenderTree/qt/GCControllerQt.cpp:
1078         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1079         * DumpRenderTree/qt/PlainTextControllerQt.cpp:
1080         * DumpRenderTree/qt/TextInputControllerQt.cpp:
1081         * DumpRenderTree/wscript:
1082         * QtTestBrowser/launcherwindow.h:
1083         * Scripts/build-webkit:
1084         * Scripts/webkitdirs.pm:
1085
1086 2011-01-15  Adam Barth  <abarth@webkit.org>
1087
1088         Teach svn-apply about WebKit2 move.
1089
1090         * Scripts/VCSUtils.pm:
1091
1092 2011-01-15  Adam Barth  <abarth@webkit.org>
1093
1094         Rubber-stamped by Eric Seidel.
1095
1096         Move WebKit2 into Source
1097         https://bugs.webkit.org/show_bug.cgi?id=52438
1098
1099         * MiniBrowser/qt/MiniBrowser.pro:
1100         * Scripts/build-webkit:
1101         * Scripts/do-file-rename:
1102         * Scripts/do-webcore-rename:
1103         * Scripts/test-webkitpy:
1104         * Scripts/webkitdirs.pm:
1105         * Scripts/webkitpy/style/checker.py:
1106         * WebKitTestRunner/DerivedSources.pro:
1107         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1108         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1109
1110 2011-01-15  Jochen Eisinger  <jochen@chromium.org>
1111
1112         Reviewed by David Levin.
1113
1114         [chromium] remove obsolete createView method
1115         https://bugs.webkit.org/show_bug.cgi?id=52437
1116
1117         * DumpRenderTree/chromium/WebViewHost.cpp:
1118         (WebViewHost::createView):
1119         * DumpRenderTree/chromium/WebViewHost.h:
1120
1121 2011-01-14  Brian Weinstein  <bweinstein@apple.com>
1122
1123         Reviewed by Geoff Garen.
1124
1125         ShouldLoadResourceForFrame should use strings, not URLs.
1126         https://bugs.webkit.org/show_bug.cgi?id=52476
1127
1128         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1129         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Update to use a WKStringRef.
1130         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1131
1132 2011-01-14  Tony Gentilcore  <tonyg@chromium.org>
1133
1134         Reviewed by David Levin.
1135
1136         Add Tony Gentilcore as a reviewer
1137         https://bugs.webkit.org/show_bug.cgi?id=52480
1138
1139         * Scripts/webkitpy/common/config/committers.py:
1140
1141 2011-01-14  David Levin  <levin@chromium.org>
1142
1143         Reviewed by Eric Seidel.
1144
1145         check-webkit-style: _FunctionState should keep track of where the function name starts.
1146         https://bugs.webkit.org/show_bug.cgi?id=52454
1147
1148         * Scripts/webkitpy/style/checkers/cpp.py: Added function_name_start_position to
1149         _FunctionState and logic for setting it correctly.
1150         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests.
1151
1152 2011-01-14  Vincent Scheib  <scheib@chromium.org>
1153
1154         Reviewed by David Levin.
1155
1156         Add support to DumpRenderTree to use the GPU rather than software renderer
1157         https://bugs.webkit.org/show_bug.cgi?id=52333
1158
1159         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1160         (main):
1161         * Scripts/webkitpy/layout_tests/port/chromium.py:
1162         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1163
1164 2011-01-14  Tony Chang  <tony@chromium.org>
1165
1166         Reviewed by Kent Tamura.
1167
1168         [chromium] update fonts.conf to fix 6 linux tests in drt
1169         https://bugs.webkit.org/show_bug.cgi?id=52411
1170
1171         * DumpRenderTree/chromium/fonts.conf: Update to match the copy in
1172             chromium's src/webkit/tools/test_shell/resources/fonts.conf
1173
1174 2011-01-14  Eric Seidel  <eric@webkit.org>
1175
1176         Original patch from Peter Gal  <galpater@inf.u-szeged.hu>
1177
1178         Reviewed by Adam Barth.
1179
1180         Fix when running Tools/Scripts/check-webkit-style without arguments.
1181         https://bugs.webkit.org/show_bug.cgi?id=52261#c16
1182
1183         * Scripts/webkitpy/common/checkout/scm.py: Handle None for changed_files argument better in Git.create_patch method.
1184         * Scripts/webkitpy/common/checkout/scm_unittest.py:
1185
1186 2011-01-04  Jochen Eisinger  <jochen@chromium.org>
1187
1188         Reviewed by David Levin.
1189
1190         Store the tempdir object in a variable so it doesn't get deleted too early.
1191         https://bugs.webkit.org/show_bug.cgi?id=51875
1192
1193         * Scripts/update-webkit-auxiliary-libs:
1194         * Scripts/update-webkit-support-libs:
1195
1196 2011-01-14  Eric Seidel  <eric@webkit.org>
1197
1198         Unreviewed.  Make it work in python 2.5.
1199
1200         webkit-patch suggest-reviewers dies when ChangeLogs are missing
1201         https://bugs.webkit.org/show_bug.cgi?id=49158
1202
1203         * Scripts/webkitpy/common/checkout/api_unittest.py:
1204
1205 2011-01-14  Sheriff Bot  <webkit.review.bot@gmail.com>
1206
1207         Unreviewed, rolling out r75774.
1208         http://trac.webkit.org/changeset/75774
1209         https://bugs.webkit.org/show_bug.cgi?id=52431
1210
1211         gtk builds were broken (Requested by loislo2 on #webkit).
1212
1213         * Scripts/webkitpy/common/checkout/scm.py:
1214
1215 2011-01-14  David Levin  <levin@chromium.org>
1216
1217         Reviewed by Shinichiro Hamaji.
1218
1219         check-webkit-style: _FunctionState should detect pure functions.
1220         https://bugs.webkit.org/show_bug.cgi?id=52428
1221
1222         * Scripts/webkitpy/style/checkers/cpp.py: Added detection for if a function declaration
1223         is a pure virtual function.
1224         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests for verifying that pure
1225         virtual functions are correctly detected.
1226
1227 2011-01-13  Ilya Tikhonovsky  <loislo@chromium.org>
1228
1229         Reviewed by Yury Semikhatsky.
1230
1231         Just small fix for problem with check-webkit-style.
1232         It just didn't work for this patch.
1233         Old code can't concatenate a list of strings with None.
1234
1235         * Scripts/webkitpy/common/checkout/scm.py:
1236
1237 2011-01-13  David Levin  <levin@chromium.org>
1238
1239         Reviewed by Shinichiro Hamaji.
1240
1241         check-webkit-style: _FunctionState should use Position to know where items are.
1242         https://bugs.webkit.org/show_bug.cgi?id=52424
1243
1244         * Scripts/webkitpy/style/checkers/cpp.py:
1245         (_FunctionState.*): Changed _FunctionState to use Position instead of line numbers.
1246         (detect_functions): Changed to pass Position's to _FunctionState.begin and
1247         did some minor clean-up.
1248         (*): Other changes are simply about converting to use the Position's in_FunctionState
1249         instead of line numbers.
1250         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Changed the test code
1251         to verify the positions stored in _FunctionState.
1252
1253 2011-01-13  Eric Seidel  <eric@webkit.org>
1254
1255         Reviewed by David Levin.
1256
1257         webkit-patch suggest-reviewers dies when ChangeLogs are missing
1258         https://bugs.webkit.org/show_bug.cgi?id=49158
1259
1260         This is not the most elegant, but it is a very safe fix to this bug.
1261         One advantage of catching ScriptError like this instead of adding a
1262         new added_or_modified_files or fixing all changed_files callers
1263         to use a more specific change_files variant, is that we catch
1264         all kinds of ScriptErrors which might cause our (non-essential)
1265         suggest-reviewers code to fail out.  This should make passing
1266         --suggest-reviewers to webkit-patch upload much more robust
1267         and may even make it possible for us to make it default.
1268
1269         The root of the problem here is that SCM.changed_files includes
1270         deleted ChangeLog paths (from moves, etc) which then when we ask
1271         SVN/Git for the contents of the file at that revision, the command
1272         errors out and Executive.run_command raises a ScriptError.
1273
1274         In the future we might fix this differently by making all current
1275         callers of chagned_files use a more specific method for requesting
1276         what types of changes they're interested in (adds, modifies, deletes, etc.)
1277
1278         * Scripts/webkitpy/common/checkout/api.py:
1279         * Scripts/webkitpy/common/checkout/api_unittest.py:
1280
1281 2011-01-13  Dan Bernstein  <mitz@apple.com>
1282
1283         Reviewed by Alexey Proskuryakov.
1284
1285         <rdar://problem/8827065> REGRESSION (r71884): Cross-origin XHR fails if willSendRequest changes the URL
1286         https://bugs.webkit.org/show_bug.cgi?id=52419
1287
1288         Allow to further control the behavior of the willSendRequest delegate callback by making it
1289         set a different URL in the new request.
1290
1291         * DumpRenderTree/LayoutTestController.cpp:
1292         (addURLToRedirectCallback): Added.
1293         (LayoutTestController::staticFunctions): Added addURLToRedirect.
1294         (LayoutTestController::addURLToRedirect): Added. Adds the redirection to the map.
1295         (LayoutTestController::redirectionDestinationForURL): Added this getter.
1296         * DumpRenderTree/LayoutTestController.h:
1297         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1298         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]): Check
1299         if there is a redirection for the request’s URL, established by addURLToRedirect(), and if so,
1300         change the URL in the new request to the redirect destination.
1301
1302 2011-01-13  Eric Seidel  <eric@webkit.org>
1303
1304         Reviewed by Mihai Parparita.
1305
1306         webkit-patch suggest-reviewers fails due to invalid utf8 in ChangeLog files
1307         https://bugs.webkit.org/show_bug.cgi?id=52416
1308
1309         Example: webkit-patch suggest-reviewers -g ca3890fe74d94d85d6bfa48f9ea497b094d8e717 
1310         UnicodeDecodeError: 'utf8' codec can't decode bytes in position 536-538: invalid data
1311
1312         I also added FIXMEs about the changed_files returning deleted files problem
1313         which is causing the other most common exception for suggest-reviewers
1314         (and is probably breaking sheriff-bots blame detection).
1315
1316         * Scripts/webkitpy/common/checkout/api.py:
1317         * Scripts/webkitpy/common/checkout/api_unittest.py:
1318         * Scripts/webkitpy/common/checkout/scm.py:
1319
1320 2011-01-13  Eric Seidel  <eric@webkit.org>
1321
1322         Reviewed by Adam Barth.
1323
1324         results archives from commit-queue are too large to upload
1325         https://bugs.webkit.org/show_bug.cgi?id=52405
1326
1327         * Scripts/webkitpy/common/system/filesystem.py:
1328         * Scripts/webkitpy/common/system/filesystem_mock.py:
1329         * Scripts/webkitpy/tool/commands/queues.py:
1330
1331 2011-01-13  Alejandro G. Castro  <alex@igalia.com>
1332
1333         Reviewed by Martin Robinson.
1334
1335         [gtk] Zero-sized font does not yet work
1336         https://bugs.webkit.org/show_bug.cgi?id=49793
1337
1338         Set minimum-font-size to 0 for the DRT.
1339
1340         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1341         (resetDefaultsToConsistentValues):
1342
1343 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
1344
1345         Reviewed by Darin Adler.
1346
1347         Make old-run-webkit-tests more robust on buildbots
1348         https://bugs.webkit.org/show_bug.cgi?id=52364
1349
1350         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Pass --exit-after-n-failures 500 to old-run-webkit-tests script.
1351
1352 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
1353
1354         Reviewed by Darin Adler.
1355
1356         Make old-run-webkit-tests more robust on buildbots
1357         https://bugs.webkit.org/show_bug.cgi?id=52364
1358
1359         * Scripts/old-run-webkit-tests: Ensure that testResultsDirectory is empty.
1360
1361 2011-01-13  Tony Chang  <tony@chromium.org>
1362
1363         Reviewed by Kent Tamura.
1364
1365         [chromium] fix plugins/plugin-javascript-access.html on Linux and Mac
1366         https://bugs.webkit.org/show_bug.cgi?id=52332
1367
1368         Forked Info.plist is not longer needed.
1369
1370         * DumpRenderTree/chromium/TestNetscapePlugIn/Info.plist: Removed.
1371
1372 2011-01-13  Mikhail Naganov  <mnaganov@chromium.org>
1373
1374         Reviewed by Timothy Hatcher.
1375
1376         Web Inspector: Cleanup after r75613 -- make all UI-facing strings
1377         to be passed directly to WebInspector.UIString
1378
1379         https://bugs.webkit.org/show_bug.cgi?id=52365
1380
1381         * Scripts/check-inspector-strings:
1382
1383 2011-01-13  Sheriff Bot  <webkit.review.bot@gmail.com>
1384
1385         Unreviewed, rolling out r74881.
1386         http://trac.webkit.org/changeset/74881
1387         https://bugs.webkit.org/show_bug.cgi?id=52357
1388
1389         The EFL builder has been red for days (Requested by abarth on
1390         #webkit).
1391
1392         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1393         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1394
1395 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
1396
1397         Reviewed by David Levin.
1398
1399         Add beforeunload support to WebKitTestRunner
1400         https://bugs.webkit.org/show_bug.cgi?id=52353
1401         
1402         This makes a number of currently failing tests pass.
1403
1404         * WebKitTestRunner/TestController.cpp:
1405         (WTR::runBeforeUnloadConfirmPanel):
1406         (WTR::createOtherPage):
1407         (WTR::TestController::initialize):
1408
1409 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
1410
1411         Reviewed by Sam Weinig.
1412
1413         Detect, identify and recover from WebProcess crashes in run-webkit-tests
1414         https://bugs.webkit.org/show_bug.cgi?id=52330
1415
1416         * Scripts/old-run-webkit-tests: Detect when the regression test tool reports
1417         a web process crash.
1418         * WebKitTestRunner/TestController.cpp:
1419         (WTR::TestController::initialize): Set up a processDidCrash
1420         callback.
1421         (WTR::TestController::processDidCrash): Report that the Web process
1422         crashed.
1423         * WebKitTestRunner/TestController.h:
1424
1425 2011-01-12  David Levin  <levin@chromium.org>
1426
1427         Reviewed by Shinichiro Hamaji.
1428
1429         check-webkit-style -- close_expression function doesn't work correctly.
1430         https://bugs.webkit.org/show_bug.cgi?id=52272
1431
1432         * Scripts/webkitpy/style/checkers/cpp.py:
1433         (Position.__str__): Added a way to convert it to a string which is useful in tests.
1434         (Position.__cmp__): Added a way to compare Position which is useful in tests and
1435         generally useful (for upcoming code changes).
1436         (close_expression): Changed to use Position for input and output.
1437         Also, fixed many bugs such as only working correctly for parenthesis,
1438         not working correctly if given an offset in a line and not finding
1439         the real closing element if there were multiple closing elements in
1440         the same line.
1441         (detect_functions): Adjusted due to the change in arguments for
1442         close_expression.
1443         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1444         (CppStyleTestBase.assert_positions_equal): Added a way to verify that
1445         two positions are the same.
1446         (CppStyleTest.test_position): Added tests for the __str_ and __cmp__ methods.
1447         (CppStyleTest.test_close_expression): Added tests to catch the issues
1448         that were fixed.
1449
1450 2011-01-12  Sheriff Bot  <webkit.review.bot@gmail.com>
1451
1452         Unreviewed, rolling out r75576.
1453         http://trac.webkit.org/changeset/75576
1454         https://bugs.webkit.org/show_bug.cgi?id=52304
1455
1456         broke rebaseline-chromium-webkit-test (Requested by thakis on
1457         #webkit).
1458
1459         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1460         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1461         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
1462         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1463         * Scripts/webkitpy/layout_tests/port/base.py:
1464         * Scripts/webkitpy/layout_tests/port/chromium.py:
1465         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1466         * Scripts/webkitpy/layout_tests/port/test.py:
1467         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1468         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1469         * Scripts/webkitpy/style/checkers/test_expectations.py:
1470         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1471
1472 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
1473
1474         Reviewed by Darin Adler.
1475
1476         Add a no-build option to run-webkit-tests, to avoid building DRT/WKTR
1477         https://bugs.webkit.org/show_bug.cgi?id=52307
1478
1479         * Scripts/old-run-webkit-tests:
1480
1481 2011-01-12  Koan-Sin Tan  <koansin.tan@gmail.com>
1482
1483         Reviewed by Martin Robinson.
1484
1485         [Gtk] WebKitGtk+ doesn't build on Mac OS X 10.6
1486         https://bugs.webkit.org/show_bug.cgi?id=50867
1487
1488         Fixed library extention for Mac in webkitdirs.pm and type conflict in
1489         TestNetscapePlugin.cpp 
1490
1491         * GNUmakefile.am: Don't use AppKit when compiling TestNetscapePlugin for GTK+
1492         * Scripts/webkitdirs.pm:
1493
1494 2011-01-12  Mikhail Naganov  <mnaganov@chromium.org>
1495
1496         Reviewed by Pavel Feldman.
1497
1498         Add check-inspector-strings script.
1499
1500         https://bugs.webkit.org/show_bug.cgi?id=52295
1501
1502         * Scripts/check-inspector-strings: Added.
1503
1504 2011-01-12  Adam Roben  <aroben@apple.com>
1505
1506         Advertise the .testnetscape file extension on Windows
1507
1508         Fixes <http://webkit.org/b/52298>
1509         plugins/no-mime-with-valid-extension.html fails on Windows
1510
1511         Reviewed by Dan Bernstein.
1512
1513         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Added a
1514         FileExtents field to map the .testnetscape file extension to the
1515         application/x-webkit-test-netscape MIME type, just as we do on Mac.
1516
1517 2011-01-12  Adam Barth  <abarth@webkit.org>
1518
1519         Reviewed by Eric Seidel.
1520
1521         Make webkit-patch support subdirectories for SVN checkouts
1522         https://bugs.webkit.org/show_bug.cgi?id=52261
1523
1524         os.relpath does not exist on Python 2.5, so we need to call our version
1525         of the API.
1526
1527         * Scripts/webkitpy/common/checkout/scm.py:
1528
1529 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
1530
1531         Reviewed by Eric Seidel.
1532
1533         Close additional pages opened during a test once the test completes.
1534         https://bugs.webkit.org/show_bug.cgi?id=52276
1535
1536         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1537         (WTR::InjectedBundle::done):
1538
1539 2011-01-11  David Levin  <levin@chromium.org>
1540
1541         Reviewed by Eric Seidel.
1542
1543         Errors should be separated from the command line in bot messages.
1544         https://bugs.webkit.org/show_bug.cgi?id=52275
1545
1546         * Scripts/webkitpy/common/system/executive.py:
1547         (ScriptError.message_with_output): Added a newline to separate the command
1548         line from the errors.
1549         * Scripts/webkitpy/common/system/executive_unittest.py:
1550         (ScriptErrorTest.test_message_with_output): Added tests for the various code
1551         paths in message_with_output.
1552
1553 2011-01-11  Eric Seidel  <eric@webkit.org>
1554
1555         Unreviewed.
1556
1557         commit-queue should know how to upload archived results (for test flakes or general failures)
1558         https://bugs.webkit.org/show_bug.cgi?id=52048
1559
1560         The zips are mostly empty due to forgetting -r.
1561         Expected diffs were not being pulled from the archive due
1562         to the archive having longer paths than I realized.
1563
1564         * Scripts/webkitpy/common/system/workspace.py:
1565         * Scripts/webkitpy/common/system/workspace_unittest.py:
1566         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1567         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1568
1569 2011-01-11  Dirk Pranke  <dpranke@chromium.org>
1570
1571         Reviewed by Ojan Vafai.
1572
1573         The current modifier parsing code in test_expectations is
1574         fragile and hard-coded, so it's not easy to understand the logic
1575         or easily add new types of modifiers (like GPU vs. CPU testing
1576         for graphics tests, or 32-bit vs. 64-bit differences).
1577
1578         This is the first of two patches that will add in more generic
1579         support and then eliminate the GPU-specific test expectations
1580         files for Chromium.
1581
1582         This patch adds two standalone objects for handling modifiers. The
1583         rules for interpreting modifiers, precedence, and conflicts are
1584         given in the docstring to the ModifierMatcher class, which
1585         returns ModifierMatchResult objects.
1586         
1587         This patch also adds routines to the Port interface and a
1588         default set of values in the base object, in order to obtain the
1589         values needed on a given test run. These values are then passed
1590         to the expectation parser. This also allows us to clean up the
1591         logic used to lint all of the different configurations in a
1592         single test_expectations.txt file.
1593
1594         The next patch will merge in the separate GPU expectations file.
1595
1596         https://bugs.webkit.org/show_bug.cgi?id=51222
1597
1598         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1599         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1600         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
1601         * Scripts/webkitpy/layout_tests/port/base.py:
1602         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1603         * Scripts/webkitpy/layout_tests/port/chromium.py:
1604         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1605         * Scripts/webkitpy/layout_tests/port/test.py:
1606         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1607         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1608
1609 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
1610
1611         Reviewed by Adam Barth.
1612
1613         Make webkit-patch support subdirectories for SVN checkouts
1614         https://bugs.webkit.org/show_bug.cgi?id=52261
1615
1616         * Scripts/webkitpy/common/checkout/scm.py:
1617         * Scripts/webkitpy/style_references.py:
1618         * Scripts/webkitpy/tool/main.py:
1619         * Scripts/webkitpy/tool/steps/preparechangelog.py:
1620
1621 2011-01-11  Eric Seidel  <eric@webkit.org>
1622
1623         Unreviewed.
1624
1625         commit-queue should know how to upload archived results (for test flakes or general failures)
1626         https://bugs.webkit.org/show_bug.cgi?id=52048
1627
1628         I changed the API for archive_last_layout_test_results w/o updating the implementation.  Oops.
1629         This fixes an exception seen on the commit-queue when attempting to report flaky tests.
1630
1631         * Scripts/webkitpy/common/system/workspace.py:
1632         * Scripts/webkitpy/common/system/workspace_unittest.py:
1633         * Scripts/webkitpy/tool/commands/queues.py:
1634
1635 2011-01-11  Sam Weinig  <sam@webkit.org>
1636
1637         Roll r75474 back in.
1638
1639 2011-01-11  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
1640
1641         Reviewed by Kenneth Rohde Christiansen.
1642
1643         [Qt] Remove uses of QFuture since it isn't supported on all platforms.
1644         https://bugs.webkit.org/show_bug.cgi?id=51204
1645
1646         * QtTestBrowser/webpage.h:
1647         (QtNAMThread::QtNAMThread):
1648         (QtNAMThread::networkAccessManager):
1649         (QtNAMThread::run):
1650
1651 2011-01-11  Peter Varga  <pvarga@webkit.org>
1652
1653         Unreviewed.
1654
1655         Add myself to committers' list.
1656
1657         * Scripts/webkitpy/common/config/committers.py:
1658
1659 2011-01-11  Eric Seidel  <eric@webkit.org>
1660
1661         Reviewed by Adam Barth.
1662
1663         commit-queue should know how to upload archived results (for test flakes or general failures)
1664         https://bugs.webkit.org/show_bug.cgi?id=52048
1665
1666         Now the queue will always upload results.  Either the entire zip, or just
1667         the diffs.txt in the case of text failures.
1668
1669         This should make understanding flakes much easier, and paves the way
1670         for having the EWS run layout tests (and upload failures).
1671
1672         In order to upload .zip files I had to teach bugzilla.py to autodetect
1673         mime types from the filename.  Since mimetypes.py doesn't include a mapping
1674         for .patch files, I have it add one before calling guess_type.
1675
1676         We may find that always uploading the whole zip instead of just the -diffs.txt
1677         file is preferable, but for now I'm keeping the old behavior because it makes
1678         quickly understanding text failures easy.
1679
1680         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1681         * Scripts/webkitpy/common/system/workspace.py: Added.
1682         * Scripts/webkitpy/common/system/workspace_unittest.py: Added.
1683         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1684         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1685         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1686         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1687         * Scripts/webkitpy/tool/commands/queues.py:
1688         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1689
1690 2011-01-10  Sheriff Bot  <webkit.review.bot@gmail.com>
1691
1692         Unreviewed, rolling out r75464.
1693         http://trac.webkit.org/changeset/75464
1694         https://bugs.webkit.org/show_bug.cgi?id=52193
1695
1696         Followup rollout for 75474 (Requested by Ossy on #webkit).
1697
1698         * MiniBrowser/mac/BrowserWindowController.m:
1699         (-[BrowserWindowController awakeFromNib]):
1700         * MiniBrowser/win/BrowserView.cpp:
1701         (BrowserView::create):
1702         * WebKitTestRunner/TestController.cpp:
1703         (WTR::createOtherPage):
1704         (WTR::TestController::initialize):
1705
1706 2011-01-10  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1707
1708         Reviewed by Csaba Osztrogonác.
1709
1710         [Qt] Baseline qt_minimal configuration
1711         https://bugs.webkit.org/show_bug.cgi?id=51313
1712
1713         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1714         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): Add
1715         QT_NO_UNDOSTACK guard.
1716
1717         * QtTestBrowser/launcherwindow.cpp:
1718         (LauncherWindow::createChrome): Add QT_NO_SHORTCUT and QT_NO_PRINTER
1719         guards.
1720         (LauncherWindow::applyZoom): Add QT_NO_ANIMATION guard.
1721         (LauncherWindow::screenshot): Add QT_NO_FILEDIALOG guard.
1722         (LauncherWindow::selectElements): Add QT_NO_INPUTDIALOG guard.
1723         (LauncherWindow::showUserAgentDialog): Add QT_NO_COMBOBOX guard.
1724
1725         * QtTestBrowser/launcherwindow.h:
1726         * QtTestBrowser/locationedit.cpp: Add QT_NO_INPUTDIALOG guard.
1727         * QtTestBrowser/locationedit.h: Ditto.
1728
1729         * QtTestBrowser/mainwindow.cpp:
1730         (MainWindow::buildUI): Add QT_NO_INPUTDIALOG, QT_NO_SHORTCUT and
1731         QT_NO_UNDOSTACK guards.
1732         (MainWindow::setAddressUrl): Add QT_NO_INPUTDIALOG guard.
1733         (MainWindow::changeLocation): Ditto.
1734         (MainWindow::openFile): Add QT_NO_FILEDIALOG guard.
1735         (MainWindow::openLocation): Add QT_NO_INPUTDIALOG guard.
1736
1737         * QtTestBrowser/webpage.cpp:
1738         (WebPage::openUrlInDefaultBrowser): Add QT_NO_DESKTOPSERVICES guard.
1739         (WebPage::authenticationRequired): Add QT_NO_LINEEDIT guard.
1740
1741         * QtTestBrowser/webview.cpp:
1742         (WebViewGraphicsBased::animatedFlip): Add QT_NO_ANIMATION guard.
1743         (WebViewGraphicsBased::animatedYFlip): Ditto.
1744
1745 2011-01-10  Sam Weinig  <sam@webkit.org>
1746
1747         Fix build.
1748
1749         * MiniBrowser/mac/BrowserWindowController.m:
1750         (-[BrowserWindowController awakeFromNib]):
1751         * MiniBrowser/win/BrowserView.cpp:
1752         (BrowserView::create):
1753         * WebKitTestRunner/TestController.cpp:
1754         (WTR::createOtherPage):
1755         (WTR::TestController::initialize):
1756
1757 2011-01-10  Eric Seidel  <eric@webkit.org>
1758
1759         Reviewed by Ojan Vafai.
1760
1761         style-queue messages are way too long for big patches
1762         https://bugs.webkit.org/show_bug.cgi?id=52161
1763
1764         We definitely could build much fancier list-to-string-with-limit functions
1765         but this should be sufficient for our needs at the moment.
1766
1767         * Scripts/webkitpy/common/system/executive.py:
1768         * Scripts/webkitpy/common/system/executive_unittest.py:
1769
1770 2011-01-10  Tony Chang  <tony@chromium.org>
1771
1772         Unreviewed, rolling out r75398.
1773         http://trac.webkit.org/changeset/75398
1774         https://bugs.webkit.org/show_bug.cgi?id=52008
1775
1776         Some layout tests are crashing on Chromium Win.
1777
1778         * DumpRenderTree/chromium/WebViewHost.cpp:
1779         (WebViewHost::updatePaintRect):
1780         * DumpRenderTree/chromium/WebViewHost.h:
1781
1782 2011-01-10  Adam Roben  <aroben@apple.com>
1783
1784         Roll out r75392
1785
1786         It isn't needed now that r75289 has been rolled out.
1787
1788         * Scripts/run-javascriptcore-tests:
1789
1790 2011-01-10  Maciej Stachowiak  <mjs@apple.com>
1791
1792         Reviewed by Anders Carlsson.
1793
1794         WebKitTestRunner uses crazy amounts of CPU, making layout tests slow and flaky
1795         https://bugs.webkit.org/show_bug.cgi?id=52160
1796
1797         * WebKitTestRunner/mac/TestControllerMac.mm:
1798         (WTR::TestController::platformRunUntil): Instead of busy-looping, wait for the timeout.
1799         Anything that can make runUntil() conditions turn true will happen on a run loop cycle
1800         anyway.
1801
1802 2011-01-10  Tony Chang  <tony@chromium.org>
1803
1804         Reviewed by Mihai Parparita.
1805
1806         [chromium] fix for animated gif layout tests
1807         https://bugs.webkit.org/show_bug.cgi?id=52008
1808
1809         * DumpRenderTree/chromium/WebViewHost.cpp: Schedule a paint when we update the paint rect
1810             to trigger gif animations.
1811         (WebViewHostPaintTask::WebViewHostPaintTask):
1812         (WebViewHostPaintTask::runIfValid):
1813         (WebViewHost::updatePaintRect):
1814         * DumpRenderTree/chromium/WebViewHost.h:
1815         (WebViewHost::taskList):
1816
1817 2011-01-10  Alejandro G. Castro  <alex@igalia.com>
1818
1819         Reviewed by Xan Lopez.
1820
1821         [GTK] Fix gtk2 compilation for master
1822         https://bugs.webkit.org/show_bug.cgi?id=51885
1823
1824         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
1825         (createBitmapContextFromWebView): Replaced the old
1826         gdk_drawable_get_size with gdk_pixmap_get_size.
1827
1828 2011-01-10  Patrick Gansterer  <paroga@webkit.org>
1829
1830         Reviewed by Laszlo Gombos.
1831
1832         [WINCE] Reenable NPAPI after r75203
1833         https://bugs.webkit.org/show_bug.cgi?id=52109
1834
1835         Remove the !isWinCE() check for ENABLE_NETSCAPE_PLUGIN_API and replace
1836         it with !isEfl(), because EFL port does not support NPAPI (yet).
1837
1838         * Scripts/build-webkit:
1839
1840 2011-01-10  Adam Roben  <aroben@apple.com>
1841
1842         Skip some asserting JS tests
1843
1844         See <http://webkit.org/b/52156>.
1845
1846         * Scripts/run-javascriptcore-tests:
1847
1848 2011-01-10  Martin Robinson  <mrobinson@igalia.com>
1849
1850         Reviewed by Xan Lopez.
1851
1852         [GTK] build-webkit disable Blob support via arguments passed to automake
1853         https://bugs.webkit.org/show_bug.cgi?id=52097
1854
1855         * Scripts/build-webkit: Enable Blob support when building WebKitGTK+ via
1856         build-webkit.
1857
1858 2011-01-10  Adam Roben  <aroben@apple.com>
1859
1860         Use the same name and description for TestNetscapePlugin on Windows and
1861         Mac
1862
1863         Fixes <http://webkit.org/b/52151>
1864         fast/frames/iframe-reparenting-plugins.html fails on Windows
1865
1866         Reviewed by Steve Falkenburg.
1867
1868         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Copied
1869         the name and description from Mac's Info.plist.
1870
1871 2011-01-10  Siddharth Mathur <siddharth.mathur@nokia.com>
1872
1873         Reviewed by Laszlo Gombos.
1874
1875         [Qt][WK2] Guard gcc-specific syntax
1876
1877         Non-gcc based compliers choke on the "-include"
1878         syntax for preinclude, place guard around it.
1879
1880         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1881         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1882
1883 2011-01-10  Andreas Kling  <kling@webkit.org>
1884
1885         Reviewed by Simon Hausmann.
1886
1887         [Qt] [WK2] MiniBrowser does not load pages opened in new windows
1888         https://bugs.webkit.org/show_bug.cgi?id=52111
1889
1890         When getting a createNewPage() callback from QWKPage, create the
1891         new page with the same QWKContext as the page that is passed to
1892         the callback.
1893
1894         * MiniBrowser/qt/BrowserView.h:
1895         * MiniBrowser/qt/BrowserWindow.cpp:
1896         (newPageFunction):
1897         (BrowserWindow::BrowserWindow):
1898         * MiniBrowser/qt/BrowserWindow.h:
1899
1900 2011-01-10  Andreas Kling  <kling@webkit.org>
1901
1902         Reviewed by Kenneth Rohde Christiansen.
1903
1904         [Qt] MiniBrowser: Remove superfluous createNewPage() callback
1905
1906         BrowserView set its own useless createNewPage() callback on QWKPage.
1907         This was immediately overridden by BrowserWindow anyway, so remove
1908         the BrowserView one.
1909
1910         * MiniBrowser/qt/BrowserView.cpp:
1911         (BrowserView::BrowserView):
1912
1913 2011-01-10  John Knottenbelt  <jknotten@chromium.org>
1914
1915         Reviewed by Jeremy Orlow.
1916
1917         [Chromium] Remove non-client-based Geolocation code
1918         https://bugs.webkit.org/show_bug.cgi?id=50921
1919
1920         * DumpRenderTree/chromium/LayoutTestController.cpp:
1921         (LayoutTestController::setGeolocationPermission):
1922         (LayoutTestController::setMockGeolocationPosition):
1923         (LayoutTestController::setMockGeolocationError):
1924         * DumpRenderTree/chromium/WebViewHost.cpp:
1925         (WebViewHost::geolocationClientMock):
1926         (WebViewHost::reset):
1927         * DumpRenderTree/chromium/WebViewHost.h:
1928
1929 2011-01-10  Eric Seidel  <eric@webkit.org>
1930
1931         Reviewed by Adam Barth.
1932
1933         Commit bot tried to land r? cq+ patch
1934         https://bugs.webkit.org/show_bug.cgi?id=36638
1935
1936         It should now be possible to post a patch with r? and cq+ and the
1937         commit-queue will correctly wait for the r+ before attempting to land the patch.
1938         (This was a feature requested by several users.)
1939
1940         One caveat: We don't actually reject r-, cq+ patches from the queue
1941         (we just ignore them), but I think that's OK for now.
1942
1943         I also noticed that setting r- once a commit-queue node had grabbed
1944         a patch would not properly cancel the landing.  That's fixed and
1945         tested in this patch.
1946
1947         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1948         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1949         * Scripts/webkitpy/tool/bot/feeders.py:
1950         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
1951
1952 2011-01-08  Benjamin Poulain  <benjamin.poulain@nokia.com>
1953
1954         Reviewed by Kenneth Rohde Christiansen.
1955
1956         [Qt] QtWebKit crashes when using XMLHttpRequest from the unload event
1957         https://bugs.webkit.org/show_bug.cgi?id=51934
1958
1959         When accessing the network from the destructor of QWebPage, the network access manager
1960         was already deleted because the object WebPage was already destructed.
1961
1962         This solve the problem by linking the lifetime of the network access manager to WebPage's QObject.
1963         The object is now destructed in the destructor of QObject.
1964
1965         * QtTestBrowser/webpage.cpp:
1966         (WebPage::WebPage):
1967         (WebPage::setQnamThreaded):
1968         * QtTestBrowser/webpage.h:
1969         (QtNAMThread::QtNAMThread):
1970
1971 2011-01-08  Eric Seidel  <eric@webkit.org>
1972
1973         Reviewed by Ojan Vafai.
1974
1975         test_failures.py should not mention TestShell (long live DumpRenderTree!)
1976         https://bugs.webkit.org/show_bug.cgi?id=52067
1977
1978         I ran test-webkitpy, but didn't bother adding a unit test for this string change.
1979         https://bugs.webkit.org/show_bug.cgi?id=51138#c3 is an example of why this is needed.
1980
1981         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1982
1983 2011-01-08  Eric Seidel  <eric@webkit.org>
1984
1985         Reviewed by Mihai Parparita.
1986
1987         commit-queue hangs when the ChangeLog diff is bad
1988         https://bugs.webkit.org/show_bug.cgi?id=52072
1989
1990         * Scripts/webkitpy/tool/steps/validatechangelogs.py:
1991         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
1992
1993 2011-01-08  Adam Barth  <abarth@webkit.org>
1994
1995         Teach svn-apply how to re-write WebCore to Source/WebCore.
1996
1997         * Scripts/VCSUtils.pm:
1998
1999 2011-01-07  Adam Barth  <abarth@webkit.org>
2000
2001         Rubber-stamped by Eric Seidel.
2002
2003         Move WebCore to Source
2004         https://bugs.webkit.org/show_bug.cgi?id=52050
2005
2006         Update the tools to understand WebCore's new location.
2007
2008         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2009         * DumpRenderTree/wscript:
2010         * GNUmakefile.am:
2011         * Scripts/build-webkit:
2012         * Scripts/do-file-rename:
2013         * Scripts/do-webcore-rename:
2014         * Scripts/generate-qt-inspector-resource:
2015         * Scripts/prepare-ChangeLog:
2016         * Scripts/run-bindings-tests:
2017         * Scripts/update-iexploder-cssproperties:
2018         * Scripts/update-sources-list.py:
2019         * Scripts/update-webkit-localizable-strings:
2020         * Scripts/webkitdirs.pm:
2021         * Scripts/webkitpy/common/config/build.py:
2022         * Scripts/webkitpy/common/config/build_unittest.py:
2023         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
2024         * Scripts/webkitpy/style/checker.py:
2025         * Scripts/webkitpy/style/checker_unittest.py:
2026         * WebKitTestRunner/DerivedSources.pro:
2027         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2028         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh:
2029         * wx/browser/wscript:
2030         * wx/build/settings.py:
2031
2032 2011-01-07  Maciej Stachowiak  <mjs@apple.com>
2033
2034         Reviewed by Sam Weinig.
2035
2036         Make WebKitTestRunner rest between loads more robust to avoid test crashes
2037         https://bugs.webkit.org/show_bug.cgi?id=52086
2038
2039         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2040         (WTR::InjectedBundle::didReceiveMessage):
2041         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2042         (WTR::LayoutTestController::notifyDone):
2043         * WebKitTestRunner/TestController.cpp:
2044         (WTR::TestController::resetStateToConsistentValues):
2045         (WTR::TestController::run):
2046
2047 2011-01-07  James Robinson  <jamesr@chromium.org>
2048
2049         Revert "Implement mozilla's animationTime property"
2050         https://bugs.webkit.org/show_bug.cgi?id=51952
2051
2052         This approach isn't quite right.
2053
2054         * DumpRenderTree/chromium/WebViewHost.cpp:
2055         (WebViewHost::paintInvalidatedRegion):
2056
2057 2011-01-07  Adam Roben  <aroben@apple.com>
2058
2059         Build master fix
2060
2061         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2062         (RunWebKitTests.start): Don't try to concatenate a list and a string.
2063
2064 2011-01-07  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>
2065
2066         Reviewed by Csaba Osztrogonác.
2067
2068         run-qtwebkit-tests should be able to kill a testsuite.
2069
2070         Add new option in the script that can setup a timeout for a test.
2071         If the test execution takes more then specified time then the test
2072         would be terminated.
2073
2074         [Qt] run-qtwebkit-tests needs timeout
2075         https://bugs.webkit.org/show_bug.cgi?id=51894
2076
2077         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2078         * Scripts/run-qtwebkit-tests:
2079
2080 2011-01-07  Csaba Osztrogonác  <ossy@webkit.org>
2081
2082         Unreviewed fix after r75233.
2083
2084         Based on idea from Eric Seidel.
2085
2086         Add remote zip file handling to webkitpy.
2087         https://bugs.webkit.org/show_bug.cgi?id=50901
2088
2089         * Scripts/webkitpy/common/system/fileset.py: Make python 2.5 happy.
2090
2091 2011-01-07  Shane Stephens  <shanestephens@google.com>
2092
2093         Reviewed by Eric Seidel.
2094
2095         svn-apply: should support git binary delta diffs
2096         https://bugs.webkit.org/show_bug.cgi?id=38864
2097
2098         * Scripts/VCSUtils.pm:
2099         * Scripts/svn-apply:
2100
2101 2011-01-06  Julie Parent  <jparent@chromium.org>
2102
2103         Reviewed by Eric Seidel.
2104
2105         Test Result Server not removing old results.
2106         https://bugs.webkit.org/show_bug.cgi?id=52012
2107
2108         * TestResultServer/model/jsonresults.py:
2109         Fix off-by-one: Truncate if >= num_runs, not just >.
2110         * TestResultServer/model/jsonresults_unittest.py:
2111         Add unit test to test that merging in a new result with the same value
2112         as the last result causes previous result to fall off.
2113
2114 2011-01-06  James Kozianski  <koz@chromium.org>
2115
2116         Reviewed by Mihai Parparita.
2117
2118         Add classes to provide a consistent interface to a set of files.
2119         https://bugs.webkit.org/show_bug.cgi?id=50901
2120
2121         These classes allow us to write code that is agnostic to whether a
2122         particular set of files resides in a local directory or in a zip file
2123         on a remote machine.
2124
2125         * Scripts/webkitpy/common/system/directoryfileset.py: Added.
2126         * Scripts/webkitpy/common/system/directoryfileset_unittest.py: Added.
2127         * Scripts/webkitpy/common/system/fileset.py: Added.
2128         * Scripts/webkitpy/common/system/filesystem.py:
2129         * Scripts/webkitpy/common/system/filesystem_mock.py:
2130         * Scripts/webkitpy/common/system/zipfileset.py: Added.
2131         * Scripts/webkitpy/common/system/zipfileset_unittest.py: Added.
2132
2133 2011-01-06  Eric Seidel  <eric@webkit.org>
2134
2135         Reviewed by Adam Barth.
2136
2137         NetworkTransaction should log the url it is retrying
2138         https://bugs.webkit.org/show_bug.cgi?id=52043
2139
2140         * Scripts/webkitpy/common/net/networktransaction.py:
2141         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
2142
2143 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
2144
2145         Windows build fix.
2146         Import os before using it.
2147
2148         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2149
2150 2011-01-06  Eric Seidel  <eric@webkit.org>
2151
2152         Reviewed by Adam Barth.
2153
2154         StyleQueue fails to report errors when patches have many files
2155         https://bugs.webkit.org/show_bug.cgi?id=52042
2156
2157         This is one of at least two errors preventing style error reporting at the moment.
2158         When we moved to passing the list of files to check explicitly,
2159         we started to exceed the 500 character TEXT field limit for our AppEngine model object.
2160         We could change the type of the QueueStatus.message type, or we could
2161         just teach statusserver.py how to clamp values (and warn when it does).
2162         I chose the latter path.
2163
2164         * Scripts/webkitpy/common/net/statusserver.py:
2165
2166 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
2167
2168         Reviewed by Stephanie Lewis.
2169         
2170         Fix syntax error in script.
2171
2172         Windows bots need to archive/unarchive builds to/from configuration-specific directories
2173         https://bugs.webkit.org/show_bug.cgi?id=51996
2174
2175         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2176
2177 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2178
2179         Unreviewed, fixing WinCE build after r75196.
2180
2181         WinCE port does not (yet) support NPAPI.
2182
2183         * Scripts/build-webkit:
2184
2185 2011-01-06  Xan Lopez  <xlopez@igalia.com>
2186
2187         Reviewed by Darin Adler.
2188
2189         File::Spec->rel2abs in sunspider-compare-results mangles parameters
2190         https://bugs.webkit.org/show_bug.cgi?id=52015
2191
2192         * Scripts/sunspider-compare-results: call rel2abs on our arguments
2193         after the platform has been detected, otherwise the script will
2194         mangle things like '--gtk' into '/a/path/--gtk', breaking the
2195         detection.
2196
2197 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2198
2199         Reviewed by Eric Seidel.
2200
2201         Add ENABLE_NETSCAPE_PLUGIN_API, ENABLE_ORIENTATION_EVENTS and ENABLE_TOUCH_EVENTS flags to build-webkit
2202         https://bugs.webkit.org/show_bug.cgi?id=51346
2203
2204         * Scripts/build-webkit:
2205
2206 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
2207
2208         Reviewed by Adam Roben.
2209
2210         Windows bots need to archive/unarchive builds to/from configuration-specific directories
2211         https://bugs.webkit.org/show_bug.cgi?id=51996
2212         
2213         After the configuration directory change, we were archiving the incorrect directory for
2214         build product, so we were running tests on the wrong binaries.
2215         
2216         This change archives the correct directory, and also unarchives it into a configuration-
2217         specific directory.
2218
2219         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Use a configuration-specific directory on Windows.
2220         * BuildSlaveSupport/built-product-archive: Unarchive/archive to/from proper directory.
2221
2222 2011-01-06  Eric Seidel  <eric@webkit.org>
2223
2224         Reviewed by Mihai Parparita.
2225
2226         commit-queue mentions "Text diff mismatch" 4 times instead of once per failure
2227         https://bugs.webkit.org/show_bug.cgi?id=52002
2228
2229         See an example of this here:
2230         https://bugs.webkit.org/show_bug.cgi?id=51314#c2
2231
2232         It's due to the fact that we pass around TestFailure() instance
2233         objects and yet expect them to all compare to be the same.
2234
2235         This is bad.  We should either have shared instances of these values
2236         or we should just pass around the class names.  There are already hacks
2237         in place to make TestFailure objects pass equality tests, I just added
2238         a __hash__ implementation so they can be used in sets as expected.
2239
2240         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2241         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
2242
2243 2011-01-06  Evan Martin  <evan@chromium.org>
2244
2245         Reviewed by Tony Chang.
2246
2247         [gdb] handle inaccessible memory and UChar*
2248         https://bugs.webkit.org/show_bug.cgi?id=52003
2249
2250         To pretty-print a UChar*, we just grope around in the memory
2251         looking for a terminating NUL.  We need to handle the exception
2252         that can occur when we poke into an invalid location.
2253
2254         Additionally, the logic for choosing which pretty-printer would
2255         early return before hitting the point where we'd use the UChar*
2256         printer.  (Did this ever work?  How did it regress?)
2257
2258         * gdb/webkit.py:
2259
2260 2011-01-05  Brian Weinstein  <bweinstein@apple.com>
2261
2262         Reviewed by Ada Chan.
2263
2264         WebKit2: Should be able to call into injected bundle to ask if we should allow resource loads
2265         https://bugs.webkit.org/show_bug.cgi?id=51969
2266         
2267         Add shouldLoadResourceForFrame to WTR::InjectedBundlePage.
2268
2269         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2270         (WTR::InjectedBundlePage::InjectedBundlePage):
2271         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Stub implementation.
2272         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2273
2274 2011-01-06  James Robinson  <jamesr@chromium.org>
2275
2276         Reviewed by Simon Fraser.
2277
2278         Implement mozilla's animationTime property
2279         https://bugs.webkit.org/show_bug.cgi?id=51952
2280
2281         Chromium DRT support for webkitAnimationTime.
2282
2283         * DumpRenderTree/chromium/WebViewHost.cpp:
2284         (WebViewHost::paintInvalidatedRegion):
2285
2286 2011-01-06  Julie Parent  <jparent@chromium.org>
2287
2288         Reviewed by Tony Chang.
2289
2290         Test Result Server always truncates number of results to JSON_RESULTS_MAX_BUILDS
2291         https://bugs.webkit.org/show_bug.cgi?id=51217
2292
2293         * TestResultServer/model/jsonresults.py:
2294         Pass num_runs through to _remove_items_over_max_number_of_builds, and use the value.
2295         Adds missing documentation.
2296         * TestResultServer/model/jsonresults_unittest.py:
2297         Add unit test to test that truncation happens at smaller value than JSON_RESULTS_MAX_BUILDS.
2298         Update test_merge to take a number of builds to truncate at.
2299
2300 2011-01-06  Adam Barth  <abarth@webkit.org>
2301
2302         Reviewed by Eric Seidel.
2303
2304         The EWS should log outside of the working directory
2305         https://bugs.webkit.org/show_bug.cgi?id=51986
2306
2307         This patch prepare us for using git clean -x -d -f in the EWS wrapper
2308         script, which will actually clean the working copy back to a pristine
2309         state instead of leaving untracked directories and ignored files.
2310
2311         * Scripts/webkitpy/tool/commands/queues.py:
2312         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2313
2314 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
2315
2316         Windows build fix.
2317         Back out attempted change to built-product-archive.
2318
2319         * BuildSlaveSupport/built-product-archive:
2320
2321 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
2322
2323         Windows build fix.
2324         Include configuration name when unpacking a build archive.
2325
2326         Needed, since we split Windows build results into configuration-specific directories
2327         under WebKitOutputDir.
2328
2329         * BuildSlaveSupport/built-product-archive:
2330
2331 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
2332
2333         Reviewed by Darin Adler.
2334
2335         Debug and Release builds on Windows clobber each other
2336         https://bugs.webkit.org/show_bug.cgi?id=49185
2337
2338         Changes the structure of WebKitBuild build products directory so we
2339         completely separate each build configuration into independent directories.
2340         
2341         Although we previously had per-configuration directories for obj, this change adds
2342         per-configuration directories for bin, lib, obj, and include. Each configuration's
2343         build products are stored within a directory inside of WebKitBuild.
2344         
2345         Most use of $(WebKitOutputDir) in the build files has been replaced by $(ConfigurationBuildDir),
2346         defined in common.vsprops to be $(WebKitOutputDir)\$(ConfigurationName).
2347
2348         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops:
2349         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd:
2350         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd:
2351         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
2352         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd:
2353         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd:
2354         * DumpRenderTree/win/ImageDiffCommon.vsprops:
2355         * DumpRenderTree/win/ImageDiffPostBuild.cmd:
2356         * DumpRenderTree/win/ImageDiffPreBuild.cmd:
2357         * FindSafari/FindSafari.vcproj:
2358         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
2359         * MiniBrowser/MiniBrowserPostBuild.cmd:
2360         * MiniBrowser/MiniBrowserPreBuild.cmd:
2361         * Scripts/webkitdirs.pm:
2362         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
2363         * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops:
2364         * TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd:
2365         * TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd:
2366         * TestWebKitAPI/win/copy-resources.cmd:
2367         * WebKitAPITest/WebKitAPITestCommon.vsprops:
2368         * WebKitAPITest/WebKitAPITestPostBuild.cmd:
2369         * WebKitAPITest/WebKitAPITestPreBuild.cmd:
2370         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
2371         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
2372         * WebKitTestRunner/win/InjectedBundle.vcproj:
2373         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops:
2374         * WebKitTestRunner/win/InjectedBundlePostBuild.cmd:
2375         * WebKitTestRunner/win/InjectedBundlePreBuild.cmd:
2376         * WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd:
2377         * WebKitTestRunner/win/WebKitTestRunnerPreBuild.cmd:
2378         * WinLauncher/WinLauncherCommon.vsprops:
2379         * WinLauncher/WinLauncherPostBuild.cmd:
2380         * WinLauncher/WinLauncherPreBuild.cmd:
2381
2382 2011-01-05  Jan Erik Hanssen  <jhanssen@sencha.com>
2383
2384         Reviewed by Ariya Hidayat.
2385
2386         [Qt] TestNetscapePlugin doesn't link on OS X
2387         https://bugs.webkit.org/show_bug.cgi?id=51948
2388
2389         Only add a dependency on libX11 on X11 systems
2390
2391         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2392
2393 2011-01-05  Jeff Miller  <jeffm@apple.com>
2394
2395         Reviewed by Adam Roben.
2396
2397         check-webkit-style should allow unnecessary parameter names in WebKit2 APIs because we're matching CF's header style
2398         https://bugs.webkit.org/show_bug.cgi?id=51970
2399
2400         * Scripts/webkitpy/style/checker.py:
2401         Add -readability/naming for WebKit2 C API directories.
2402
2403 2011-01-05  Eric Seidel  <eric@webkit.org>
2404
2405         Unreviewed, just fixing one more log error from my previous python patch.
2406
2407         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
2408         https://bugs.webkit.org/show_bug.cgi?id=51802
2409
2410         webkit-patch failure-reason was logging about parsing errors
2411         due to my misunderstanding of how BeautifulSoup.findAll worked.
2412
2413         Fixed, and added a unit test.
2414
2415         * Scripts/webkitpy/common/net/layouttestresults.py:
2416         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2417
2418 2011-01-05  Benjamin Poulain  <benjamin.poulain@nokia.com>
2419
2420         Reviewed by Kenneth Rohde Christiansen.
2421
2422         [Qt] [WK2] Add the possibility to open window from the WebProcess in Minibrowser
2423         https://bugs.webkit.org/show_bug.cgi?id=51951
2424
2425         Set a function to QWKPage::setCreateNewPageFunction() in Minibrowser so there is a way
2426         to create new window from WebKit.
2427
2428         * MiniBrowser/qt/BrowserWindow.cpp:
2429         (newPageFunction):
2430         (BrowserWindow::BrowserWindow):
2431         (BrowserWindow::page): Added to avoid the indirect access to QWKPage spread in the class
2432         (BrowserWindow::newWindow):
2433         (BrowserWindow::updateUserAgentList):
2434         (BrowserWindow::showUserAgentDialog):
2435         * MiniBrowser/qt/BrowserWindow.h: Add the global variable backingStoreTypeForNewWindow to
2436         define the type of the backing store used for new windows.
2437         * MiniBrowser/qt/main.cpp:
2438         (main):
2439
2440 2011-01-05  Eric Seidel  <eric@webkit.org>
2441
2442         Reviewed by Ojan Vafai.
2443
2444         commit-queue should report failure type when reporting flaky tests
2445         https://bugs.webkit.org/show_bug.cgi?id=51900
2446
2447         This patch was a ridiculous amount of plumbing.  In the end I like
2448         the NRWT-style TestResult class even less.  But now we're passing
2449         a list of TestResult objects from the queue to the FlakyTestReporter.
2450         Thus the FlakyTestReporter can more easily report what type of failure
2451         occurred.
2452
2453         In the process, I found that I was not alone in finding TestResult
2454         cumbersome to use.  A bunch of code was trying to create a TestResult
2455         object with default values.  However since the constructor didn't make
2456         this easy, some places were getting it wrong (including the TestResult unit test)!
2457         I've fixed the TestResult constructor to have default values for non-essential
2458         arguments.
2459
2460         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2461         * Scripts/webkitpy/common/net/layouttestresults.py:
2462         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2463         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2464         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2465         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2466         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
2467         * Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py:
2468         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2469         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2470         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2471         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2472         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2473         * Scripts/webkitpy/tool/commands/queues.py:
2474         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2475
2476 2011-01-05  Eric Seidel  <eric@webkit.org>
2477
2478         Unreviewed.
2479
2480         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
2481         https://bugs.webkit.org/show_bug.cgi?id=51802
2482
2483         Add another unit test to cover a previously missing import.
2484
2485         * Scripts/webkitpy/common/net/layouttestresults.py:
2486         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2487
2488 2011-01-05  Mihai Parparita  <mihaip@chromium.org>
2489
2490         Reviewed by David Levin.
2491
2492         Add mihaip@chromium.org as a reviewer
2493         https://bugs.webkit.org/show_bug.cgi?id=51966
2494         
2495         Add myself as a reviewer.
2496
2497         * Scripts/webkitpy/common/config/committers.py:
2498
2499 2011-01-05  James Simonsen  <simonjam@chromium.org>
2500
2501         Unreviewed. Adding myself to the list of committers.
2502
2503         * Scripts/webkitpy/common/config/committers.py:
2504
2505 2011-01-05  Eric Seidel  <eric@webkit.org>
2506
2507         Unreviewed.
2508
2509         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
2510         https://bugs.webkit.org/show_bug.cgi?id=51802
2511
2512         Fix two exceptions seen on the bots after my original commit.
2513
2514         * Scripts/webkitpy/common/net/layouttestresults.py:
2515         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2516
2517 2011-01-05  Kundu Suchismita  <suchi.kundu@nokia.com>
2518
2519         Reviewed by Andreas Kling.
2520
2521         [Qt]Add local storage settings to QtTestBrowser command line arguments 
2522         https://bugs.webkit.org/show_bug.cgi?id=51750
2523
2524         * QtTestBrowser/main.cpp:
2525         (LauncherApplication::handleUserOptions):
2526          Local storage settings can be enable form command line arguments for
2527          QtTestBrowser.
2528
2529 2011-01-05  Chris Fleizach  <cfleizach@apple.com>
2530
2531         Reviewed by Martin Robinson.
2532
2533         GTK: AX: DRT needs to use correct root object method.
2534         https://bugs.webkit.org/show_bug.cgi?id=51911
2535
2536         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
2537         (AccessibilityController::rootElement):
2538
2539 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
2540
2541         Rubber-stamped by Csaba Osztrogonác.
2542
2543         Based on idea from Péter Gál.
2544
2545         * Scripts/webkitpy/tool/bot/sheriff.py: Remove unnecessary apostrophes around revision numbers.
2546
2547 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
2548
2549         Reviewed by Adam Barth.
2550
2551         sheriff-bot should be able to do multi-revision rollouts
2552         https://bugs.webkit.org/show_bug.cgi?id=51176
2553
2554         * Scripts/webkitpy/tool/bot/irc_command.py:
2555         * Scripts/webkitpy/tool/bot/sheriff.py:
2556         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
2557
2558 2011-01-05  Eric Seidel  <eric@webkit.org>
2559
2560         Reviewed by Adam Barth.
2561
2562         queues.webkit.org should have per-bot status pages
2563         https://bugs.webkit.org/show_bug.cgi?id=51906
2564
2565         Just adds a /queue-status/QUEUE_NAME/bots/BOT_ID page to show
2566         statuses from a single queue.  Now that we have many bots servicing
2567         some queues (commit-queue, win-ews, etc.) its easy to have the messages
2568         you care about scroll off the end of the 15-message limit on the main page.
2569
2570         Eventually we should probably rename /queue-status to /queue or /queues,
2571         but that's fodder for another patch.
2572
2573         * QueueStatusServer/handlers/queuestatus.py:
2574         * QueueStatusServer/index.yaml:
2575         * QueueStatusServer/main.py:
2576         * QueueStatusServer/templates/includes/singlequeuestatus.html:
2577          - This probably should use a custom filter instead of hard-coding
2578            the URL scheme here, but I couldn't figure out how to easily
2579            create such a filter.  Most filters work with "strings" so we can't
2580            pass the status object.  We could add a method to the status
2581            object and call that, but that seemed a bit strange too.
2582         * QueueStatusServer/templates/queuestatus.html:
2583
2584 2011-01-05  Carlos Garcia Campos  <cgarcia@igalia.com>
2585
2586         Unreviewed. Adding myself to the list of committers.
2587
2588         * Scripts/webkitpy/common/config/committers.py:
2589
2590 2011-01-04  Koan-Sin Tan  <koansin.tan@gmail.com>
2591
2592         Reviewed by David Levin.
2593
2594         check-webkit-style treated some macros with parentheses after #elif as function calls
2595         https://bugs.webkit.org/show_bug.cgi?id=51695
2596
2597         Ingore function call space checking in any preprocessor directives
2598         (things starting with #). Change search() to match() because 
2599         preprocessor directives are supposed to be in the beginning of lines.
2600
2601         * Scripts/webkitpy/style/checkers/cpp.py:
2602         * Scripts/webkitpy/style/checkers/cpp_unittest.py: make sure there is no false positives for #elif cases
2603
2604 2011-01-04  Søren Gjesse  <sgjesse@chromium.org>
2605
2606         Reviewed by Tony Chang.
2607
2608         Change the --multi-load test option to --stress-opt
2609         https://bugs.webkit.org/show_bug.cgi?id=50751
2610
2611         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2612         (runTest):
2613         (main):
2614         * DumpRenderTree/chromium/TestShell.cpp:
2615         (TestShell::TestShell):
2616         * DumpRenderTree/chromium/TestShell.h:
2617         (TestShell::stressOpt):
2618         (TestShell::setStressOpt):
2619         (TestShell::stressDeopt):
2620         (TestShell::setStressDeopt):
2621         (TestShell::javaScriptFlags):
2622         (TestShell::setJavaScriptFlags):
2623         * Scripts/webkitpy/layout_tests/port/chromium.py:
2624         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2625
2626 2011-01-04  Chris Fleizach  <cfleizach@apple.com>
2627
2628         Reviewed by Sam Weinig.
2629
2630         WK2: Support Accessibility
2631         https://bugs.webkit.org/show_bug.cgi?id=51859
2632
2633         Use rootObject() method to get top of accessibility tree.
2634
2635         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
2636         (AccessibilityController::focusedElement):
2637         (AccessibilityController::rootElement):
2638
2639 2011-01-03  Martin Robinson  <mrobinson@igalia.com>
2640
2641         Reviewed by Darin Adler.
2642
2643         Remove the last non-GObject usage of PlatformRefPtr and move the code to GRefPtr
2644         https://bugs.webkit.org/show_bug.cgi?id=51846
2645
2646         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: Change usage of PlatformRefPtr
2647         back to GRefPtr.
2648
2649 2011-01-04  Zhe Su  <suzhe@chromium.org>
2650
2651         Reviewed by Kenneth Russell.
2652
2653         Fix insertText, setMarkedText and unmarkText methods of
2654         TextInputController to call corresponding methods of WebKit::WebView
2655         rather than WebKit::WebFrame. This change matches the behavior of
2656         chromium browser.
2657         insertText corresponds to WebView::confirmComposition(text)
2658         setMarkedText corresponds to WebView::setComposition(...)
2659         unmarkText corresponds to WebView::confirmComposition()
2660         https://bugs.webkit.org/show_bug.cgi?id=51693
2661
2662         * DumpRenderTree/chromium/TextInputController.cpp:
2663         (TextInputController::insertText):
2664         (TextInputController::setMarkedText):
2665         (TextInputController::unmarkText):
2666
2667 2011-01-04  Dihan Wickremasuriya  <dihan.wickremasuriya@nokia.com>
2668
2669         Reviewed by Laszlo Gombos.
2670
2671         [Qt] [Symbian] Do not remove 0 byte sized files from productDir
2672
2673         On Symbian productDir points to the source directory. Removing all the
2674         empty files from the productDir directory corrupts the svn repository.
2675
2676         * Scripts/build-webkit:
2677
2678 2011-01-03  Yi Shen  <yi.4.shen@nokia.com>
2679
2680         Reviewed by Adam Barth.
2681
2682         [Qt] Add SelectAll option to the context menu for the editor
2683         https://bugs.webkit.org/show_bug.cgi?id=50049
2684
2685         Set shortcut for the SelectAll action.
2686
2687         * QtTestBrowser/mainwindow.cpp:
2688         (MainWindow::buildUI):
2689
2690 2011-01-03  David Levin  <levin@chromium.org>
2691
2692         Reviewed by Eric Seidel.
2693
2694         check-webkit-style shouldn't consider "value" automatically to be a meaningless name.
2695         https://bugs.webkit.org/show_bug.cgi?id=51842
2696
2697         * Scripts/webkitpy/style/checkers/cpp.py: Remove the check for value.
2698         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Remove the test for value.
2699
2700 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
2701
2702         Reviewed by David Kilzer.
2703
2704         [WINCE] Adds a build slave.
2705         https://bugs.webkit.org/show_bug.cgi?id=50523
2706
2707         * BuildSlaveSupport/build.webkit.org-config/config.json: Add an
2708         entry for a release build of the WinCE port.
2709         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add platform
2710         flag to build the WinCE port.
2711
2712 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
2713
2714         Reviewed by David Kilzer.
2715
2716         Add WinCE support to build-webkit
2717         https://bugs.webkit.org/show_bug.cgi?id=51642
2718
2719         * Scripts/build-webkit:
2720         * Scripts/webkitdirs.pm:
2721
2722 2011-01-03  Eric Seidel  <eric@webkit.org>
2723
2724         Reviewed by Adam Barth.
2725
2726         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
2727         https://bugs.webkit.org/show_bug.cgi?id=51802
2728
2729         I'm not the biggest fan of the test_failures or test_results classes,
2730         but it's better to have one shared set of classes, than separate ones
2731         for new vs. old run-webkit-test result handling.
2732
2733         This moves the ORWT results class "LayoutTestResults" over to using
2734         TestResult and TestFailure classes, making it easy for us to
2735         make all our sheriff-bot and other webkitpy code NRWT ready.
2736
2737         This also makes it a trivial patch to generate results.json information
2738         from ORWT results.html files (for flaky test analysis, etc.) as well
2739         as making it a one-liner to report test failure types when the
2740         commit-queue sees flaky tests.
2741
2742         This patch tried not to add new functionality, but only to replace
2743         the guts of LayoutTestResults, while adding unit tests and hoping
2744         not to break anything.
2745
2746         I also moved callers which assumed User.prompt* were static/class methods
2747         to using them as instance methods (since we'll eventually want to make them such).
2748
2749         In the process of re-writing things, I broke the rebaseline command, so I wrote
2750         a unit test to catch my breakage were I do do so again in the future.
2751
2752         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2753         * Scripts/webkitpy/common/net/layouttestresults.py:
2754         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2755         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
2756         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
2757         * Scripts/webkitpy/tool/commands/queries.py:
2758         * Scripts/webkitpy/tool/commands/rebaseline.py:
2759         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2760         * Scripts/webkitpy/tool/mocktool.py:
2761
2762 2011-01-03  Adam Barth  <abarth@webkit.org>
2763
2764         Reviewed by Simon Fraser.
2765
2766         webkit-patch shouldn't waste time cleaning a working directory that's already clean
2767         https://bugs.webkit.org/show_bug.cgi?id=51840
2768
2769         * Scripts/webkitpy/common/checkout/scm.py:
2770
2771 2011-01-03  Adam Barth  <abarth@webkit.org>
2772
2773         Reviewed by Simon Fraser.
2774
2775         webkit-patch should only hide update output if --quiet
2776         https://bugs.webkit.org/show_bug.cgi?id=51838
2777
2778         As requested by smfr.
2779
2780         * Scripts/webkitpy/tool/steps/update.py:
2781
2782 2011-01-03  Adam Barth  <abarth@webkit.org>
2783
2784         Reviewed by David Levin.
2785
2786         commit-queue shouldn't reject patches twice if two bots process the same patch
2787         https://bugs.webkit.org/show_bug.cgi?id=51805
2788
2789         Before raising an error, we first check whether the patch is still in
2790         the commit-queue.  This check is still racy, of course, but the time
2791         window is much smaller.
2792
2793         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2794
2795 2011-01-03  Sam Weinig  <sam@webkit.org>
2796
2797         Reviewed by Anders Carlsson.
2798
2799         Make run-api-tests less chatty.
2800         https://bugs.webkit.org/show_bug.cgi?id=51831
2801
2802         - Make script quiet by default and add --verbose option (replacing --quiet).
2803         - When not verbose, pipe stdout and stderr to devnull.
2804
2805         * Scripts/run-api-tests:
2806
2807 2011-01-03  Pratik Solanki  <psolanki@apple.com>
2808
2809         Unreviewed. Adding myself to committers.py.
2810
2811         * Scripts/webkitpy/common/config/committers.py:
2812
2813 2011-01-03  Koan-Sin Tan  <koansin.tan@gmail.com>
2814
2815         Reviewed by Xan Lopez.
2816
2817         "Tool/Scripts/run-launcher --gtk" stopped working after 74855
2818         https://bugs.webkit.org/show_bug.cgi?id=51806
2819
2820         Originally, the $libraryName is 'JavaScriptCore'. When building release 
2821         one, the $libraryDir was 'WebKitBuild/Release/JavaScriptCore/../.libs/'
2822         which doesn't exist anymore ('WebKitBuild/Release/JavaScriptCore'
2823         is 'WebKitBuild/Release/Source/JavaScriptCore' now), and 
2824         'WebKitBuild/Release/Source/JavaScriptCore/../../.libs' looks weird,
2825         so make it 'WebKitBuild/Release/.libs'
2826
2827         * Scripts/webkitdirs.pm: 
2828
2829 2011-01-02  Patrick Gansterer  <paroga@webkit.org>
2830
2831         Reviewed by Adam Barth.
2832
2833         Make EFL a core builder
2834         https://bugs.webkit.org/show_bug.cgi?id=51804
2835
2836         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2837         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2838
2839 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
2840
2841         [Qt] Unreviewed fix after r74855 and r74875.
2842
2843         * BuildSlaveSupport/built-product-archive:
2844          - Create directories explicitly.
2845          - Pass shell=True to subprocess.call().
2846
2847 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
2848
2849         [Qt] Unreviewed fix after r74855.
2850
2851         Move JavaScriptCore to Source
2852         https://bugs.webkit.org/show_bug.cgi?id=51604
2853
2854         * BuildSlaveSupport/built-product-archive: JavaScriptCore -> Source/JavaScriptCore
2855
2856 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
2857
2858         [Qt] Unreviewed run-javasriptcore-tests fix after r74855.
2859
2860         Move JavaScriptCore to Source
2861         https://bugs.webkit.org/show_bug.cgi?id=51604
2862
2863         * Scripts/webkitdirs.pm:
2864
2865 2011-01-02  Robert Hogan  <robert@webkit.org>
2866
2867         Unreviewed, build fix.
2868
2869         [Qt] Fix DRT build after 74855
2870
2871         * DumpRenderTree/qt/DumpRenderTree.pro:
2872
2873 2011-01-01  Adam Barth  <abarth@webkit.org>
2874
2875         Remove the assumption from the Qt and Gtk builds that every project is
2876         in the root directory.
2877
2878         * Scripts/build-webkit:
2879
2880 2011-01-01  Adam Barth  <abarth@webkit.org>
2881
2882         Reviewed by Eric Seidel.
2883
2884         Teach svn-apply how to apply patches even though JavaScriptCore has moved
2885         https://bugs.webkit.org/show_bug.cgi?id=51796
2886
2887         After this change, svn-apply will magically apply patches to
2888         JavaScriptCore/foo to Source/JavaScriptCore/foo.
2889
2890         * Scripts/VCSUtils.pm:
2891
2892 2011-01-01  Adam Barth  <abarth@webkit.org>
2893
2894         Reviewed by Eric Seidel.
2895
2896         Move JavaScriptCore to Source
2897         https://bugs.webkit.org/show_bug.cgi?id=51604
2898
2899         Update references to JavaScriptCore to point to the new location.
2900
2901         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2902         * DumpRenderTree/qt/DumpRenderTree.pro:
2903         * DumpRenderTree/qt/ImageDiff.pro:
2904         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2905         * DumpRenderTree/wscript:
2906         * Scripts/build-jsc:
2907         * Scripts/build-webkit:
2908         * Scripts/do-file-rename:
2909         * Scripts/do-webcore-rename:
2910         * Scripts/run-javascriptcore-tests:
2911         * Scripts/update-javascriptcore-test-results:
2912         * Scripts/webkitdirs.pm:
2913         * Scripts/webkitpy/common/config/build_unittest.py:
2914         * Scripts/webkitpy/style/checker.py:
2915         * Scripts/webkitpy/style/checker_unittest.py:
2916         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2917         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2918         * WebKitTestRunner/qt/WebKitTestRunner.pro:
2919         * wx/build/settings.py:
2920
2921 2011-01-01  Adam Barth  <abarth@webkit.org>
2922
2923         Reviewed by Eric Seidel.
2924
2925         Move Sources to Source
2926         https://bugs.webkit.org/show_bug.cgi?id=51794
2927
2928         Update scripts to point to the new location.
2929
2930         * Scripts/build-webkit:
2931         * Scripts/do-file-rename:
2932         * Scripts/do-webcore-rename:
2933         * Scripts/webkitpy/common/config/build.py:
2934         * Scripts/webkitpy/common/config/build_unittest.py:
2935
2936 2010-12-31  Kent Tamura  <tkent@chromium.org>
2937
2938         Reviewed by Eric Seidel.
2939
2940         [DRT/Chromium] Enable mock spell checker on non-OSX
2941         https://bugs.webkit.org/show_bug.cgi?id=51401
2942
2943         * DumpRenderTree/chromium/WebViewHost.cpp:
2944         (WebViewHost::spellCheck):
2945
2946 2010-12-31  Adam Barth  <abarth@webkit.org>
2947
2948         Reviewed by Ariya Hidayat.
2949
2950         Remove Tools/Scripts/wkstyle
2951         https://bugs.webkit.org/show_bug.cgi?id=51774
2952
2953         This script appears to not have been touched in a while and seems to
2954         have been replaced by check-webkit-style.
2955
2956         * Scripts/wkstyle: Removed.
2957
2958 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
2959
2960         Unreviewed. Coding style fix.
2961
2962         * DumpRenderTree/chromium/TestShell.h:
2963
2964 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
2965
2966         Reviewed by Pavel Feldman.
2967
2968         Web Inspector: [Chromium] Inspector's tests are very slow on Win(Dbg).
2969
2970         It was a problem with Chromium DRT. DevToolsAgent object instance was
2971         attached not only to the inspected page but to the DevTools window too.
2972         As result all the inspector files were interpreted as a content of inspected page
2973         and were transfered to the DevTools scripts panel for debugging etc.
2974
2975         https://bugs.webkit.org/show_bug.cgi?id=51735
2976
2977         * DumpRenderTree/chromium/TestShell.cpp:
2978         (TestShell::TestShell):
2979         (TestShell::bindJSObjectsToWindow):
2980         (TestShell::createNewWindow):
2981         * DumpRenderTree/chromium/TestShell.h:
2982
2983 2010-12-31  Adam Barth  <abarth@webkit.org>
2984
2985         Rubber-stamped by Eric Seidel.
2986
2987         Move PageLoadTests to PerformanceTests/PageLoad
2988         https://bugs.webkit.org/show_bug.cgi?id=51771
2989
2990         Update references to PageLoadTests to point to the new location.
2991
2992         * Scripts/run-pageloadtest:
2993         * Scripts/webkitpy/common/config/build.py:
2994
2995 2010-12-31  Adam Barth  <abarth@webkit.org>
2996
2997         Rubber-stamped by Eric Seidel.
2998
2999         Move SunSpider into PerformanceTests
3000         https://bugs.webkit.org/show_bug.cgi?id=51769
3001
3002         Update these scripts to point to the new location.
3003
3004         * Scripts/run-sunspider:
3005         * Scripts/sunspider-compare-results:
3006
3007 2010-12-30  Mihai Parparita  <mihaip@chromium.org>
3008
3009         Reviewed by Kent Tamura.
3010
3011         [Chromium] Add WebThemeEngineDRTMac so that Chromium DRT scrollbar rendering can match the Mac port's
3012         https://bugs.webkit.org/show_bug.cgi?id=51728
3013         
3014         Add implementation of the Mac WebThemeEngine that uses an NSScroller
3015         to render top-level scrollbars. This makes them match the Mac port's
3016         use of an NSScrollView, which means that we'll be able to share more
3017         pixel baselines.
3018         
3019         The new rendering code will not be activated until the 
3020         USE_WEB_THEME_ENGINE_TO_PAINT_THUMB #define is fliped in
3021         ScrollbarThemeChromiumMac.
3022
3023         * DumpRenderTree/DumpRenderTree.gypi:
3024         * DumpRenderTree/chromium/TestShellMac.mm:
3025         (platformInit):
3026         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Added.
3027         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Added.
3028         (+[FakeActiveWindow alwaysActiveWindow]):
3029         (+[FakeActiveWindow alwaysInactiveWindow]):
3030         (-[FakeActiveWindow initWithActiveControls:]):
3031         (-[FakeActiveWindow _hasActiveControls]):
3032         (WebThemeEngineDRTMac::paintScrollbarThumb):
3033         (stateToHIEnableState):
3034         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
3035         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
3036
3037 2010-12-30  Konstantin Tokarev  <annulen@yandex.ru>
3038
3039         Reviewed by David Kilzer.
3040
3041         [Qt] Don't build wtf/TCSystemAlloc.cpp if --system-malloc option is
3042         used
3043         https://bugs.webkit.org/show_bug.cgi?id=51672
3044
3045         * DumpRenderTree/qt/DumpRenderTree.pro: Replaced USE_SYSTEM_MALLOC
3046         with USE_SYSTEM_MALLOC=1
3047         * WebKitTestRunner/qt/WebKitTestRunner.pro: Replaced USE_SYSTEM_MALLOC
3048         with USE_SYSTEM_MALLOC=1
3049
3050 2010-12-30  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3051
3052         Reviewed by David Kilzer.
3053
3054         [Qt] [Symbian] Fix build-webkit script for Symbian
3055         https://bugs.webkit.org/show_bug.cgi?id=51509
3056
3057         Set the OUTPUT_DIR for Symbian to be the same as the source
3058         directory.
3059
3060         * Scripts/webkitdirs.pm:
3061
3062 2010-12-30  Martin Robinson  <mrobinson@igalia.com>
3063
3064         Reviewed by Darin Adler.
3065
3066         check-webkit-style should ignore NULL usage in calls to gtk_widget_style_get
3067         https://bugs.webkit.org/show_bug.cgi?id=51758
3068
3069         Add a check-webkit-style exception for gtk_widget_style_get and NULL usage.
3070
3071         * Scripts/webkitpy/style/checkers/cpp.py: Add the exception.
3072         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Add some tests for this.
3073
3074 2010-12-29  Patrick Gansterer  <paroga@webkit.org>
3075
3076         Unreviewed WinCE buildfix.
3077
3078         * WinCELauncher/main.cpp: Add missing include.
3079
3080 2010-12-29  Daniel Bates  <dbates@rim.com>
3081
3082         Reviewed by Darin Adler.
3083
3084         svn-apply updates date of wrong change log entry for a change log diff that
3085         contains two consecutive entries with the same author and date
3086         https://bugs.webkit.org/show_bug.cgi?id=46061
3087
3088         Fixes an issue where the date of the wrong change log entry may be modified.
3089         Moreover, changes fixChangeLogPatch() to move entries inserted earlier
3090         in a ChangeLog file to the top of the file.
3091
3092         Currently, fixChangeLogPatch() explicitly bails out and returns an unchanged
3093         diff when it detects that the diff inserts a change log entry earlier in a
3094         ChangeLog. It is unusual to land a patch that has such a deliberate ChangeLog
3095         change. With the advent of the commit-queue this functionality of bailing out
3096         and hence landing the patch as-is is harmful to the accuracy of the ChangeLog.
3097         Instead, we should always move the change log entry to the top of the ChangeLog file.
3098
3099         A side-effect of this change is that setChangeLogDateAndReviewer() now updates
3100         the date line of the correct change log entry in a ChangeLog diff.
3101
3102         * Scripts/VCSUtils.pm: Modified fixChangeLogPatch() to move entries inserted earlier to the top.
3103
3104         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
3105           Updated the following unit tests now that we move entries inserted earlier to the top:
3106           - "fixChangeLogPatch: New entry inserted in middle."
3107             (formerly named "fixChangeLogPatch: [no change] New entry inserted in middle.")
3108
3109           - "fixChangeLogPatch: New entry inserted earlier in the file, but after an entry with the same author and date."
3110             (formerly named "fixChangeLogPatch: [no change] New entry inserted earlier in the file, but after an entry with the same author and date.")
3111
3112         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatchThenSetChangeLogDateAndReviewer.pl: Added.
3113
3114 2010-12-29  Konstantin Tokarev  <annulen@yandex.ru>
3115
3116         Reviewed by Eric Seidel.
3117
3118         [Qt] Fixed compatibility with gold linker on X11 platforms
3119         https://bugs.webkit.org/show_bug.cgi?id=51700
3120
3121         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3122         Linked TestNetscapePlugin with libX11 on Unix platforms
3123
3124 2010-12-29  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>
3125
3126         Reviewed by Darin Adler.
3127
3128         Circular dependency in webkitpy.common.checkout.changelog module
3129         https://bugs.webkit.org/show_bug.cgi?id=50475
3130
3131         Remove automatic import of api.Checkout module when any checkout/
3132         submodule is imported (e.g.: when checkout.scm.Git is imported).
3133
3134         * Scripts/webkitpy/common/checkout/__init__.py:
3135
3136 2010-12-29  Martin Robinson  <mrobinson@igalia.com>
3137
3138         Reviewed by Ojan Vafai.
3139
3140         prepare-ChangeLog should support the -g option for specifying the git-commit
3141         https://bugs.webkit.org/show_bug.cgi?id=51708
3142
3143         Add a -g shortcut for the --git-commit prepare-ChangeLog option. This matches
3144         webkit-patch, though the exact meaning of the two options remain different.
3145
3146         * Scripts/prepare-ChangeLog: Add -g.
3147
3148 2010-12-29  Kent Hansen  <kent.hansen@nokia.com>
3149
3150         Reviewed by Simon Hausmann.
3151
3152         [Qt] Fix compilation with Qt in namespace
3153         https://bugs.webkit.org/show_bug.cgi?id=51701
3154
3155         * QtTestBrowser/webview.h:
3156
3157 2010-12-28  Daniel Bates  <dbates@rim.com>
3158
3159         Reviewed by Sam Weinig.
3160
3161         Substitute // MARK: for compiler-specific #pragma mark
3162         https://bugs.webkit.org/show_bug.cgi?id=51657
3163
3164         Fix future compilation warnings about "#pragma mark" on GTK+ bots by
3165         substituting  "// MARK:" for "#pragma mark", which provides
3166         analogous code-bookmarking functionality under Xcode.
3167
3168         Also, for consistency, we should substitute "// MARK:" for compiler-
3169         specific "#pragma mark" in the source files for the Mac port.
3170
3171         * DumpRenderTree/AccessibilityTextMarker.cpp:
3172         * DumpRenderTree/cf/WebArchiveDumpSupport.h:
3173         * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm:
3174         * DumpRenderTree/mac/ObjCController.m:
3175         * MiniBrowser/mac/AppDelegate.m:
3176         * MiniBrowser/mac/BrowserWindowController.m:
3177
3178 2010-12-28  Xan Lopez  <xlopez@igalia.com>
3179
3180         Reviewed by Eric Seidel.
3181
3182         Add --no-build option to run-sunspider
3183         https://bugs.webkit.org/show_bug.cgi?id=51658
3184
3185         * Scripts/run-sunspider: add --no-build flag to skip building
3186         phase.
3187
3188 2010-12-27  Daniel Bates  <dbates@rim.com>
3189
3190         Rubber-stamped by Martin Robinson.
3191
3192         Append the directory Tools/DumpRenderTree to the list of directories that
3193         do-webcore-rename should search so that it can rename DRT files and
3194         source code.
3195
3196         * Scripts/do-webcore-rename:
3197
3198 2010-12-27  Eric Seidel  <eric@webkit.org>
3199
3200         Reviewed by Adam Barth.
3201
3202         build-webkit should detect missing Java SDK and explain how to install it
3203         https://bugs.webkit.org/show_bug.cgi?id=51651
3204
3205         * Scripts/build-webkit:
3206
3207 2010-12-26  Martin Robinson  <mrobinson@igalia.com>
3208
3209         Reviewed by Daniel Bates.
3210
3211         [GTK] Add support for build-jsc
3212         https://bugs.webkit.org/show_bug.cgi?id=51625
3213
3214         Add GTK+ support to build-jsc now that building the jsc executable as
3215         a standalone target is easy.
3216
3217         * Scripts/build-jsc: Call buildGtkProject for the GTK+ case now.
3218         * Scripts/build-webkit: Pass in the proper target name to buildGtkProject.
3219         * Scripts/webkitdirs.pm: Actually process the project parameter in buildGtkProject
3220         and pass it along to buildAutotoolsProject.
3221
3222 2010-12-27  David Levin  <levin@chromium.org>
3223
3224         Reviewed by Eric Seidel.
3225
3226         check-webkit-style check for meaningless variable names in function declarations.
3227         https://bugs.webkit.org/show_bug.cgi?id=51523
3228
3229         * Scripts/webkitpy/style/checker.py: Exempted JavaScriptCore/jit/JITStubs.cpp
3230         from the new check and whitespace/parens because the syntax is unusual and
3231         produced a fair number of positives for these checks.
3232         * Scripts/webkitpy/style/checkers/cpp.py:
3233         (_convert_to_lower_with_underscores): Used as a canonical form for type names
3234         and parameter names when determining if the parameter name is useless.
3235         (_create_acronym): Used to check for redundant variable names in cases like "ExceptionCode ec"
3236         (Parameter.lower_with_underscores_name): Gives back the parameter name in a lower_with_underscore
3237         format.
3238         (_check_parameter_name_against_text):  Checks to see if the parameter name is in the
3239         text or an acronym of it.
3240         (check_function_definition): Checks function definitions for meaningless variable names.
3241         (process_line): Added call to check_function_definition.
3242         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3243         (CppFunctionsTest.test_convert_to_lower_with_underscores): Test for _convert_to_lower_with_underscores.
3244         (CppFunctionsTest.test_create_acronym): Test for _create_acronym.
3245         (CppFunctionsTest.test_check_parameter_against_text): Test for _check_parameter_against_text.
3246         (CppStyleTestBase.perform_single_line_lint): Removed the parameter name check
3247         because when only checking a snippet, there are a lot of bogus functions.
3248         (CppStyleTestBase.perform_multi_line_lint): Ditto and removed a bogus filter
3249         that I put there previously and just noticed.
3250         (WebKitStyleTest.test_parameter_names): Tests for the functionality -- both
3251         check_function_definition and process_line.
3252
3253 2010-12-27  Carlos Garcia Campos  <cgarcia@igalia.com>
3254
3255         Reviewed by Martin Robinson.
3256
3257         [GTK] Disable flash plugin in GtkLauncher when using gtk3
3258         https://bugs.webkit.org/show_bug.cgi?id=51591
3259
3260         Flash plugin uses gtk2 that is incompatible with gtk3 making
3261         webkit crash when it's built with gtk3.
3262
3263         * GtkLauncher/main.c:
3264         (main):
3265
3266 2010-12-25  Adam Barth  <abarth@webkit.org>
3267
3268         Reviewed by Eric Seidel.
3269
3270         Move ANGLE to Sources/ThirdParty
3271         https://bugs.webkit.org/show_bug.cgi?id=51605
3272
3273         * Scripts/build-webkit:
3274           - Point to the new ANGLE location.
3275
3276 2010-12-26  David Levin  <levin@chromium.org>
3277
3278         Reviewed by Eric Seidel.
3279
3280         check-webkit-style should be able to parse function declaration parameters.
3281         https://bugs.webkit.org/show_bug.cgi?id=51451
3282
3283         * Scripts/webkitpy/style/checkers/cpp.py:
3284         (Position.__init__): Holds simple position information (row, column).
3285         (Parameter.__init__): Holds information about a parameter.
3286         (SingleLineView.__init): Converts multiple lines into a single line for simpler searches.
3287         (SingleLineView.convert_column_to_row): Returns the original row given a column.
3288         (create_skeleton_parameters): Simplifies a parameter list for easier searching.
3289         (find_parameter_name_index): Finds where the parameter name is.
3290         (parameter_list): Generates the list of parameters for a function.
3291         (_FunctionState.begin): Added information to allow determining the parameters
3292         on demand.
3293         (_FunctionState.get_parameter_list): Returns a tuple of function parameters.
3294         (detect_functions): Improve function detection for operator functions and
3295         determine where the parameters end and pass that to _FunctionState.begin.
3296         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3297         (CppFunctionsTest.test_parameter): Verifies Parameter functionality.
3298         (CppFunctionsTest.test_single_line_view): Verifies SingleLineView functionality.
3299         (CppFunctionsTest.test_create_skeleton_parameters): Verifies create_skeleton_parameters.
3300         (CppFunctionsTest.test_find_parameter_name_index): Verifies find_parameter_name_index.
3301         (CppFunctionsTest.test_parameter_list): Does some minimal verification for parameter list.
3302         Much more thorough verification is done as part of FunctionDetectionTest.test_parameter_list.
3303         (FunctionDetectionTest.perform_function_detection): Added support for verifying
3304         the parameters found.
3305         (FunctionDetectionTest.test_function_declaration_detection): Added more function
3306         detection test to verify that we catch the operator functions.
3307         (FunctionDetectionTest.test_ignore_macros): Verify that function detection ignores macros.
3308         (FunctionDetectionTest.test_parameter_list): Added tests to verify the parameter parsing.
3309         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_bad_test_doesnt_break): Removed
3310         because the error. The test is about the bad function name. Fixing the name makes the test exactly like
3311         test_function_length_check_definition_severity1_for_test.
3312
3313 2010-12-25  Patrick Gansterer  <paroga@webkit.org>
3314
3315         Unreviewed WinCE buildfix after r74334.
3316
3317         * CMakeListsWinCE.txt:
3318
3319 2010-12-24  Sheriff Bot  <webkit.review.bot@gmail.com>
3320
3321         Unreviewed, rolling out r74632.
3322         http://trac.webkit.org/changeset/74632
3323         https://bugs.webkit.org/show_bug.cgi?id=51600
3324
3325         makes test-webkitpy hang forever on GTK (Requested by philn-tp
3326         on #webkit).
3327
3328         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
3329         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
3330
3331 2010-12-24  Ryuan Choi  <ryuan.choi@samsung.com>
3332
3333         Reviewed by Kenneth Rohde Christiansen.
3334
3335         [EFL] Screen doesn't be rendered when changing size of EWebLauncher
3336         https://bugs.webkit.org/show_bug.cgi?id=43528
3337
3338         Remove on_resize because ewk_view_fixed_layout_size_set should not be
3339         called on callback of EVAS_CALLBACK_RESIZE. As it change size of
3340         FrameView, rendering was ignored when _ewk_view_smart_calculate was
3341         called.
3342
3343         * EWebLauncher/main.c:
3344         (browserCreate):
3345
3346 2010-12-24  Eric Seidel  <eric@webkit.org>
3347
3348         Reviewed by Adam Barth.
3349
3350         webkit-patch (or a pre-commit hook) needs to prevent bad ChangeLog changes
3351         https://bugs.webkit.org/show_bug.cgi?id=28291
3352
3353         This is a start.  At least now webkit-patch will prompt when your ChangeLog looks questionable.
3354         We could do more advanced things, like parsing the ChangeLog (with changelog.py) and comparing that
3355         to strings with find in the diff.
3356         Since non-interactive always returns the default, this should cause patches with bad changelogs to fail on the commit-queue.
3357
3358         * Scripts/webkitpy/common/checkout/api.py:
3359         * Scripts/webkitpy/common/checkout/diff_parser.py:
3360         * Scripts/webkitpy/tool/steps/abstractstep.py:
3361         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
3362         * Scripts/webkitpy/tool/steps/validatechangelogs.py: Copied from Tools/Scripts/webkitpy/tool/steps/validatereviewer.py.
3363         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py: Copied from Tools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.
3364         * Scripts/webkitpy/tool/steps/validatereviewer.py:
3365
3366 2010-12-24  Dirk Pranke  <dpranke@chromium.org>
3367
3368         Reviewed by Kenneth Russell.
3369
3370         Modify new-run-webkit-tests to shut up and exit when all the threads
3371         are wedged so that test runs complete faster and we don't end up
3372         w/ enormous log files.
3373
3374         https://bugs.webkit.org/show_bug.cgi?id=51572
3375
3376         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
3377         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
3378
3379 2010-12-24  Eric Seidel  <eric@webkit.org>
3380
3381         Reviewed by David Levin.
3382
3383         commit-queue should better explain how it will re-open bugs and follow duplicate chains
3384         https://bugs.webkit.org/show_bug.cgi?id=51549
3385
3386         I've had multiple people ask me about the commit-queue's behavior
3387         regarding reporting flaky tests.  I figured it would be best to just
3388         have the queue explain itself in the bugs it files.
3389
3390         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3391         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3392
3393 2010-12-24  Shinichiro Hamaji  <hamaji@chromium.org>
3394
3395         Reviewed by Eric Seidel.
3396
3397         check-webkit-style: should ignore "wrong" namings in JavaScriptCore/qt
3398         https://bugs.webkit.org/show_bug.cgi?id=51467
3399
3400         * Scripts/webkitpy/style/checker.py:
3401         * Scripts/webkitpy/style/checker_unittest.py:
3402
3403 2010-12-23  Adam Barth  <abarth@webkit.org>
3404
3405         Rubber-stamped by Eric Seidel.
3406
3407         Move JavaScriptGlue into Sources
3408         https://bugs.webkit.org/show_bug.cgi?id=51583
3409
3410         These tools refer to JavaScriptGlue and need to be updated to its new
3411         location.
3412
3413         * Scripts/build-webkit:
3414         * Scripts/do-file-rename:
3415         * Scripts/do-webcore-rename:
3416         * Scripts/webkitpy/common/config/build.py:
3417         * Scripts/webkitpy/common/config/build_unittest.py:
3418
3419 2010-12-23  Lucas Forschler  <lforschler@apple.com>
3420
3421         Reviewed by Eric Seidel.
3422
3423         Bug 51539 - update iexploder scripts to point to new location
3424
3425         * Scripts/run-iexploder-tests:
3426         * Scripts/update-iexploder-cssproperties:
3427
3428 2010-12-23  Evan Martin  <evan@chromium.org>
3429
3430         Reviewed by Ryosuke Niwa.
3431
3432         [chromium] LayoutTestController warning in float->int conversion
3433         https://bugs.webkit.org/show_bug.cgi?id=51553
3434
3435         Rather than reading an int, converting to a float, then getting a compiler
3436         warning on passing the float to something that expects an int, instead
3437         just pass around ints.
3438
3439         No tests, fixes a compiler warning.
3440
3441         * DumpRenderTree/chromium/LayoutTestController.cpp:
3442         (parsePageSizeParameters):
3443         (LayoutTestController::pageNumberForElementById):
3444         (LayoutTestController::numberOfPages):
3445
3446 2010-12-23  Lucas Forschler  <lforschler@apple.com>
3447
3448         Reviewed by Darin Adler.
3449
3450         Bug 51537 - iexploder needs cleanup
3451         
3452         * iExploder/htdocs: Removed.
3453         * iExploder/htdocs/config.rb: Removed.
3454         * iExploder/htdocs/cssproperties.in: Removed.
3455         * iExploder/htdocs/cssvalues.in: Removed.
3456         * iExploder/htdocs/htmlattrs.in: Removed.
3457         * iExploder/htdocs/htmltags.in: Removed.
3458         * iExploder/htdocs/htmlvalues.in: Removed.
3459         * iExploder/htdocs/iexploder.cgi: Removed.
3460         * iExploder/htdocs/iexploder.rb: Removed.
3461         * iExploder/htdocs/index.html: Removed.
3462         * iExploder/htdocs/webserver.rb: Removed.
3463         * iExploder/iexploder-1.7.2/output: Removed.
3464         * iExploder/tools: Removed.
3465         * iExploder/tools/lasthit.rb: Removed.
3466         * iExploder/tools/osx_last_crash.rb: Removed.
3467         * iExploder/tools/showtest.rb: Removed.
3468
3469 2010-12-23  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
3470
3471         Reviewed by Kenneth Rohde Christiansen.
3472
3473         [EFL] Make 'single' the default backing store in EWebLauncher
3474         https://bugs.webkit.org/show_bug.cgi?id=51534
3475
3476         'single' is the simplest backing store and the one intended to be the
3477         default in the test browser. By mistake the tiled backing store was
3478         left as default in r72617.
3479
3480         * EWebLauncher/main.c:
3481         (browserCreate): ditto.
3482
3483 2010-12-23  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
3484
3485         Reviewed by Kenneth Rohde Christiansen.
3486
3487         [EFL] Subject: [webkit 4/4] [EFL] Remove non-sense workaround
3488         https://bugs.webkit.org/show_bug.cgi?id=51533
3489
3490         There's no point in concatenating env("HOME") with "blah", so remove
3491         option from EWebLauncher.
3492
3493         * EWebLauncher/main.c:
3494         (main): ditto.
3495
3496 2010-12-23  Ilya Tikhonovsky  <loislo@chromium.org>
3497
3498         Reviewed by Eric Seidel.
3499
3500         Web Inspector: chromium: inspector's tests are quite slow especially at windows(Debug).
3501
3502         Almost all inspector's tests become flaky on chromium Win(dbg) after switching to DRT.
3503         I just discovered that we have two additional GC runs per each WebViewHost.
3504         Test_shell had no such calls.
3505         These gc runs eat 15% of cpu time.
3506
3507         https://bugs.webkit.org/show_bug.cgi?id=51479
3508
3509         * DumpRenderTree/chromium/WebViewHost.cpp:
3510         (WebViewHost::~WebViewHost):
3511
3512 2010-12-22  Dirk Pranke  <dpranke@chromium.org>
3513
3514         Reviewed by Ojan Vafai.
3515
3516         This change splits out the TestRunner class into its own file.
3517         When we fork the code for message passing, we will create a new
3518         TestRunner, and this change will allow that to be more modular.
3519
3520         While we're at it, split out TestInput and ResultSummary into
3521         their own files, to reduce the size of run_webkit_tests to
3522         something more managable.
3523
3524         https://bugs.webkit.org/show_bug.cgi?id=51092
3525
3526         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
3527         * Scripts/webkitpy/layout_tests/layout_package/result_summary.py:
3528         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
3529         * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
3530         * Scripts/webkitpy/layout_tests/layout_package/test_input.py:
3531         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3532         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3533
3534  2010-12-22  Dirk Pranke  <dpranke@chromium.org>
3535
3536         Reviewed by Ojan Vafai.
3537
3538         nrwt multiprocessing - start over, prepare to fork the code
3539  
3540         This code cleans up the signatures and implementation of the
3541         TestRunner class so we can easily fork it to run either the
3542         stable implementation or the new, unstable message-passing
3543         implementation. The two variants will have different
3544         implementations of the run_tests() method. We will switch
3545         between the two based on the setting for the '--worker-model'
3546         switch. We rename the two currently valid values to 'old-inline'
3547         and 'old-threads'.
3548
3549         https://bugs.webkit.org/show_bug.cgi?id=51081
3550
3551         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3552         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3553
3554 2010-12-22  Victor Wang  <victorw@chromium.org>
3555
3556         Reviewed by Darin Fisher.
3557
3558         [Chromium] Update chromium archive test result url in rebaseline script.
3559
3560         https://bugs.webkit.org/show_bug.cgi?id=51503
3561
3562         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
3563
3564 2010-12-22  Lucas Forschler  <lforschler@apple.com>
3565
3566         Reviewed by Alice Liu.
3567
3568         <rdar://problem/8633222> record-memory-win needs to record memory used by the webprocess.
3569         Verified on Chrome, Safari, and IE.
3570         With this change, we will record memory from a parent browser window and all child processes.
3571
3572         * record-memory-win/main.cpp:
3573         (ProcessArgs):
3574         (PrintUsage):
3575         (getMemoryInfo):
3576         (printProcessInfo):
3577         (evalProcesses):
3578         (UseImage):
3579         (QueryContinuously):
3580         (ElapsedTime):
3581
3582 2010-12-22  Lucas Forschler  <lforschler@apple.com>
3583
3584         Unreviewed rollout r74489, because it was missing changelog.
3585
3586         * record-memory-win/main.cpp:
3587         
3588 2010-12-22  Ryosuke Niwa  <rniwa@webkit.org>
3589
3590         Adding myself as a reviewer.
3591
3592         * Scripts/webkitpy/common/config/committers.py:
3593
3594 2010-12-22  Andrew Scherkus  <scherkus@chromium.org>
3595
3596         Unreviewed.  Adding myself to committers.py.
3597
3598         * Scripts/webkitpy/common/config/committers.py:
3599
3600 2010-12-22  Ariya Hidayat  <ariya@sencha.com>
3601
3602         Reviewed by Kenneth Rohde Christiansen.
3603
3604         TestNetscapePlugIn should use #if defined
3605         https://bugs.webkit.org/show_bug.cgi?id=51471
3606
3607         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3608         (NP_Initialize):
3609         (NPP_New):
3610
3611 2010-12-22  Ilya Tikhonovsky  <loislo@chromium.org>
3612
3613         Reviewed by Yury Semikhatsky.
3614
3615         Web Inspector: [chromium] DRT inspector layout tests are flaky in debug.
3616
3617         DevTools window should be closed explicitly because it has custom deinitialization code.
3618
3619         https://bugs.webkit.org/show_bug.cgi?id=50722
3620
3621         * DumpRenderTree/chromium/TestShell.cpp:
3622         (TestShell::closeRemainingWindows):
3623
3624 2010-12-22  David Levin  <levin@chromium.org>
3625
3626         Reviewed by Shinichiro Hamaji.
3627
3628         check-webkit-style shouldn't complaint about underscores in variables in objective C files.
3629         https://bugs.webkit.org/show_bug.cgi?id=51452
3630
3631         * Scripts/webkitpy/style/checkers/cpp.py:
3632         (_FileState.__init__): Added the information to determine if a file is C or Objective C.
3633         Using the file extension if possible but falling back to the file contents if we have a header file.
3634         (_FileState.is_objective_c): Determine if we have an Objective C by examining the file contents if needed.
3635         (_FileState.is_c_or_objective_c):
3636         (check_using_std): Changed to using _FileState to determine the file type.
3637         (check_max_min_macros): Ditto.
3638         (check_for_null): Ditto.
3639         (check_style): Changed the parameters to various calls since they now need _FileState
3640         to determine the file type.
3641         (check_language): Added the file_state parameter so it could be passed
3642         to check_identifier_name_in_declaration.
3643         (check_identifier_name_in_declaration): Don't warn about underscores in variables if
3644         this is an Objective C file.
3645         (_process_lines): Added information for the _FileState constructor (and moved the
3646         call to a place that had the information).
3647         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3648         (CppFunctionsTest.test_is_c_or_objective_c): Changed the tests to use FileState and exercise
3649         its functionality.
3650         (WebKitStyleTest.test_names): Add tests for underscores in Objective C files.
3651
3652 2010-12-21  Andy Estes  <aestes@apple.com>
3653
3654         Reviewed by Mark Rowe.
3655
3656         Do not build non-Intel architectures for WebKit2-related projects.
3657         https://bugs.webkit.org/show_bug.cgi?id=51440
3658
3659         * MiniBrowser/Configurations/Base.xcconfig: Only build for i386 and x86_64.
3660         * TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
3661         * WebKitTestRunner/Configurations/Base.xcconfig: Ditto.
3662
3663 2010-12-21  Mihai Parparita  <mihaip@chromium.org>
3664
3665         Reviewed by Darin Fisher.
3666
3667         [Chromium] Rename WebThemeEngine/ControlDRT to WebThemeEngine/ControlDRTWin
3668         https://bugs.webkit.org/show_bug.cgi?id=51406 
3669         
3670         Rename WebThemeControlDRT to WebThemeControlDRTWin and WebThemeEngineDRT
3671         to WebThemeEngineDRTWin and update references everywhere.
3672
3673         * DumpRenderTree/DumpRenderTree.gypi:
3674         * DumpRenderTree/chromium/TestShellWin.cpp:
3675         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRT.cpp.
3676         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRT.h.
3677         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRT.cpp.
3678         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRT.h.
3679
3680 2010-12-21  Anders Carlsson  <andersca@apple.com>
3681
3682         Reviewed by John Sullivan.
3683
3684         Clicking missing plug-in text does not show a sheet
3685         https://bugs.webkit.org/show_bug.cgi?id=51403
3686
3687         Update for changes to the WebPageUIClient.
3688
3689         * MiniBrowser/mac/BrowserWindowController.m:
3690         (-[BrowserWindowController awakeFromNib]):
3691         * WebKitTestRunner/TestController.cpp:
3692         (WTR::createOtherPage):
3693         (WTR::TestController::initialize):
3694
3695 2010-12-21  Eric Seidel  <eric@webkit.org>
3696
3697         Reviewed by Adam Barth.
3698
3699         commit-queue will report constant failures as flaky if other tests flake
3700         https://bugs.webkit.org/show_bug.cgi?id=51272
3701
3702         This patch just removes functionality and adds testing.
3703         Previously we attempted to report flaky tests when we had
3704         two different tests fail in a row.  However, since we stop
3705         running the tests at the first failure, our code was wrong in
3706         trying to determine flakiness from the incomplete runs.
3707
3708         Originally I posted an alternate patch:
3709         https://bug-51272-attachments.webkit.org/attachment.cgi?id=77078
3710         which fixed our flaky logic in this case, however it was decided
3711         that that patch would be too difficult to maintain, so now
3712         I'm just removing the broken logic.
3713
3714         This will dramatically cut-down on our flaky-test false positives
3715         at the (small) cost of the queues being unable to report
3716         any flakiness if the tree is very flaky.  (With at least one test
3717         flaking on every run, we'll never report failures anymore.)  I think
3718         this is a tradeoff worth making.
3719
3720         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3721         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3722
3723 2010-12-20  Eric Seidel  <eric@webkit.org>
3724
3725         Reviewed by Adam Barth.
3726
3727         commit-queue wrongly rejects patches when it can't update itself
3728         https://bugs.webkit.org/show_bug.cgi?id=46636
3729
3730         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3731         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3732         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3733
3734 2010-12-20  Adam Barth  <abarth@webkit.org>
3735
3736         Move web sites to Websites directory
3737         https://bugs.webkit.org/show_bug.cgi?id=51323
3738
3739         Update references to BugsSite to point to the new location.
3740
3741         This patch was never officially reviewed (because it was too large to
3742         upload to bugs.webkit.org), but it was discussed on webkit-dev and Mark
3743         Rowe gave me the green light.
3744
3745         * Scripts/old-run-webkit-tests:
3746         * Scripts/webkitpy/common/config/build.py:
3747         * Scripts/webkitpy/common/config/build_unittest.py:
3748         * Scripts/webkitpy/common/prettypatch.py:
3749         * Scripts/webkitpy/layout_tests/port/base.py:
3750         * Scripts/webkitpy/style/main.py:
3751
3752 2010-12-20  Adrienne Walker  <enne@google.com>
3753
3754         Unreviewed. Adding myself to the list of committers.
3755
3756         * webkitpy/common/config/committers.py:
3757
3758 2010-12-20  Mark Rowe  <mrowe@apple.com>
3759
3760         Reviewed by Dan Bernstein.
3761
3762         <rdar://problem/8757601> Don't install header files in to the Resources directory.
3763
3764         * Scripts/check-for-inappropriate-files-in-framework: Don't allow .h files in the
3765         Resources directory.
3766
3767 2010-12-20  Eric Seidel  <eric@webkit.org>
3768
3769         Reviewed by Adam Barth.
3770
3771         commit-queue should include bot id when attaching failure diffs
3772         https://bugs.webkit.org/show_bug.cgi?id=51280
3773
3774         This is a tiny change to include the bot id in the name of the attachment.
3775         Most of this diff is just changing the unit test expectations
3776         now that I hid the comment printing when the comment is None.
3777