2011-02-07 Maciej Stachowiak <mjs@apple.com>
[WebKit.git] / Tools / ChangeLog
1 2011-02-07  Maciej Stachowiak  <mjs@apple.com>
2
3         Reviewed by Antti Koivisto.
4
5         WebKitTestRunner does not block remote resources or complain about them
6         https://bugs.webkit.org/show_bug.cgi?id=42139
7         <rdar://problem/8183942>
8
9         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
10         (WTR::InjectedBundlePage::willSendRequestForFrame): Implement the required
11         checks (using KURL, to avoid need to invent a whole URL API).
12         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Link WebCore
13         directly to get at KURL symbols.
14
15 2011-02-06  Maciej Stachowiak  <mjs@apple.com>
16
17         Reviewed by Daniel Bates.
18
19         Add WebKit2 bot to list of expected builders in Python regression test results.
20         https://bugs.webkit.org/show_bug.cgi?id=53905
21
22         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
23
24 2011-02-06  Maciej Stachowiak  <mjs@apple.com>
25
26         Reviewed by Ryosuke Niwa.
27
28         Update test expectations for new core builder
29         https://bugs.webkit.org/show_bug.cgi?id=53904
30
31         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
32
33 2011-02-06  Maciej Stachowiak  <mjs@apple.com>
34
35         Reviewed by David Levin.
36
37         Add WebKit2 test bot to core builders
38         https://bugs.webkit.org/show_bug.cgi?id=53901
39
40         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
41
42 2011-02-06  Ryosuke Niwa  <rniwa@webkit.org>
43
44         Another unreviewed Chromium build fix.
45
46         * DumpRenderTree/chromium/LayoutTestController.cpp:
47         (LayoutTestController::pathToLocalResource):
48
49 2011-02-06  Ryosuke Niwa  <rniwa@webkit.org>
50
51         Unreviewed Chromium build fix.
52
53         * DumpRenderTree/chromium/LayoutTestController.cpp:
54         (LayoutTestController::pathToLocalResource):
55
56 2011-02-06  Ryosuke Niwa  <rniwa@webkit.org>
57
58         Reviewed by Darin Adler.
59
60         OwnArraryPtr.h uses deleteOwnedPtr but doesn’t include OwnPtrCommon.h
61         https://bugs.webkit.org/show_bug.cgi?id=52867
62
63         * DumpRenderTree/chromium/ImageDiff.cpp:
64         (Image::craeteFromStdin): Call adoptArrayPtr.
65
66 2011-02-06  James Kozianski  <koz@chromium.org>
67
68         Reviewed by Ojan Vafai.
69
70         Add classes for representing test outputs.
71         https://bugs.webkit.org/show_bug.cgi?id=52136
72
73         These classes will make it easier to write scripts that deal with test
74         outputs such as rebaselining and deduping scripts. The intent is that
75         eventually we will be have buildbot return TestOutputs for a
76         particular build which can be compared with TestOutputs derived from a
77         local LayoutTests directory.
78
79         * Scripts/webkitpy/common/net/testoutput.py: Added.
80         * Scripts/webkitpy/common/net/testoutput_unittest.py: Added.
81         * Scripts/webkitpy/common/net/testoutputset.py: Added.
82         * Scripts/webkitpy/common/net/testoutputset_unittest.py: Added.
83         * Scripts/webkitpy/common/system/zip_mock.py: Added.
84
85 2011-02-06  Robert Hogan  <robert@webkit.org>
86
87         Reviewed by Andreas Kling.
88
89         [Qt] Clear page's groupName even when not in DRT
90         https://bugs.webkit.org/show_bug.cgi?id=53874
91
92         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
93         (WebCore::DumpRenderTree::windowCloseRequested):
94
95 2011-02-06  Patrick Gansterer  <paroga@webkit.org>
96
97         Reviewed by Andreas Kling.
98
99         [CMake] Add dependencies for Visual Studio projects
100         https://bugs.webkit.org/show_bug.cgi?id=53773
101
102         Add a WebKit dependecy to WinCELauncher, so CMake can 
103         generate the correct build order for the solution.
104
105         * CMakeListsWinCE.txt:
106
107 2011-02-06  Andreas Kling  <kling@webkit.org>
108
109         Reviewed by Antonio Gomes.
110
111         [Qt] MiniBrowser: Clean up handling of titleChanged() signal
112         https://bugs.webkit.org/show_bug.cgi?id=53869
113
114         * MiniBrowser/qt/BrowserView.cpp:
115         (BrowserView::BrowserView): Remove unnecessary titleChanged() handling.
116         * MiniBrowser/qt/BrowserWindow.cpp:
117         (BrowserWindow::BrowserWindow): Connect titleChanged() directly to setWindowTitle().
118         * MiniBrowser/qt/BrowserWindow.h:
119
120 2011-02-06  Maciej Stachowiak  <mjs@apple.com>
121
122         Reviewed by Dan Bernstein.
123
124         WebKitTestRunner needs layoutTestController.setWillSendRequestReturnsNull
125         https://bugs.webkit.org/show_bug.cgi?id=42690
126         <rdar://problem/8213851>
127
128         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
129         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
130         (WTR::InjectedBundlePage::willSendRequestForFrame):
131         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
132         (WTR::LayoutTestController::LayoutTestController):
133         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
134         (WTR::LayoutTestController::willSendRequestReturnsNull):
135         (WTR::LayoutTestController::setWillSendRequestReturnsNull):
136
137 2011-02-05  Sheriff Bot  <webkit.review.bot@gmail.com>
138
139         Unreviewed, rolling out r77720.
140         http://trac.webkit.org/changeset/77720
141         https://bugs.webkit.org/show_bug.cgi?id=53854
142
143         "Broke nrwt on Chromium win." (Requested by dglazkov|away on
144         #webkit).
145
146         * Scripts/webkitpy/common/system/executive.py:
147
148 2011-02-05  Sheriff Bot  <webkit.review.bot@gmail.com>
149
150         Unreviewed, rolling out r77725.
151         http://trac.webkit.org/changeset/77725
152         https://bugs.webkit.org/show_bug.cgi?id=53844
153
154         It broke Qt minimal build (Requested by Ossy_ on #webkit).
155
156         * QtTestBrowser/launcherwindow.cpp:
157         (LauncherWindow::createChrome):
158         * QtTestBrowser/launcherwindow.h:
159         (WindowOptions::WindowOptions):
160         * QtTestBrowser/main.cpp:
161         (LauncherApplication::handleUserOptions):
162
163 2011-02-04  Martin Robinson  <mrobinson@igalia.com>
164
165         Reviewed by Adam Barth.
166
167         [GTK] plugins/plugin-document-back-forward.html fails
168         https://bugs.webkit.org/show_bug.cgi?id=53833
169
170         Add the new "alert on load" functionality for the Unix version of the
171         test plugin. This functionality was originally introduced in r77706.
172
173         * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
174         (webkit_test_plugin_new_instance): Add new plugin fuctionality.
175
176 2011-02-04  Kundu Suchismita  <suchi.kundu@nokia.com>
177
178         Reviewed by Andreas Kling.
179
180         Local Storage settings can be enable/disable from "Develop" menu
181         https://bugs.webkit.org/show_bug.cgi?id=52296
182
183         * QtTestBrowser/launcherwindow.cpp:
184         (LauncherWindow::createChrome):
185         (LauncherWindow::toggleLocalStorage):
186         (LauncherWindow::toggleOfflineStorageDatabase):
187         (LauncherWindow::toggleOfflineWebApplicationCache):
188         (LauncherWindow::setOfflineStorageDefaultQuota):
189         * QtTestBrowser/launcherwindow.h:
190         (WindowOptions::WindowOptions):
191         * QtTestBrowser/main.cpp:
192         (LauncherApplication::handleUserOptions):
193
194 2011-02-04  Tony Chang  <tony@chromium.org>
195
196         Reviewed by Eric Seidel.
197
198         get test-webkitpy running on win32 python
199         https://bugs.webkit.org/show_bug.cgi?id=53822
200
201         The test harness crashes with a WindowsError because it can't find
202         'svn' when using subprocess.Popen.  This gets us past the error
203         so we can see the failing tests on the Chromium Win Release Tests
204         bot.
205
206         * Scripts/webkitpy/common/system/executive.py:
207
208 2011-02-04  Martin Robinson  <mrobinson@igalia.com>
209
210         Reviewed by Gustavo Noronha Silva.
211
212         [GTK] fast/events/pagehide-timeout.html fails
213         https://bugs.webkit.org/show_bug.cgi?id=53771
214
215         Add knowledge of the document browser cache model the DRT. When resetting
216         WebKit settings to consistent values between tests, default to the document
217         browser cache model.
218
219         * DumpRenderTree/gtk/DumpRenderTree.cpp:
220         (resetDefaultsToConsistentValues): Reset the cache model to the document browser
221         cache model between tests.
222         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
223         (LayoutTestController::setCacheModel): An int value of 2 here corresponds to the
224         document browser cache model.
225
226 2011-02-04  Adam Barth  <abarth@webkit.org>
227
228         Reviewed by Eric Seidel.
229
230         PluginDocuments don't create widgets for plugins on back/forward
231         https://bugs.webkit.org/show_bug.cgi?id=53474
232
233         Teach the test plugin how to call alert on load.
234
235         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
236         (NPP_New):
237
238 2011-02-04  Adam Roben  <aroben@apple.com>
239
240         Add a test case for encode/decode of FormData/FormDataElement
241
242         If the fix made in r77401 is broken, this new test will crash.
243
244         Fixes <http://webkit.org/b/53616> <rdar://problem/8949883>.
245
246         Reviewed by Sam Weinig.
247
248         * TestWebKitAPI/Test.h: Moved the bulk of TEST_ASSERT into a new _TEST_ASSERT_HELPER macro.
249         Added a new TEST_ASSERT_RETURN macro that can be used in functions with a return value.
250
251         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp: Added.
252         (TestWebKitAPI::didFinishLoadForFrame): Record that the load is finished.
253         (TestWebKitAPI::setPageLoaderClient): Hook up the loader client.
254         (TestWebKitAPI::createSessionStateContainingFormData): Load simple-form.html, submit the
255         form, an return the session state data.
256         (TestWebKitAPI::TEST): Create some session state that contains form data from one WKPage,
257         and restore it into another WKPage.
258
259         * TestWebKitAPI/Tests/WebKit2/simple-form.html: Added.
260
261         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
262         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
263         * TestWebKitAPI/win/copy-resources.cmd:
264         Added new files.
265
266 2011-02-04  Adam Roben  <aroben@apple.com>
267
268         Move code to run JavaScript tests into its own files
269
270         This will allow other tests to use this mechanism.
271
272         Fixes <http://webkit.org/b/53806> SpacebarScrolling should share its JavaScript-fu with the
273         world
274
275         Reviewed by Sam Weinig.
276
277         * TestWebKitAPI/JavaScriptTest.cpp: Added.
278         * TestWebKitAPI/JavaScriptTest.h: Added.
279         Moved code here...
280
281         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp: ...from here.
282
283         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
284         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
285         Added the new files.
286
287 2011-02-04  Dirk Pranke  <dpranke@chromium.org>
288
289         Reviewed by Mihai Parparita.
290
291         merge test expectations for chromium, chromium-gpu. The
292         chromium-gpu port will no longer maintain its own
293         test expectations file.
294
295         Also add in a graphics_type() call on the port object to
296         determine what graphics type to use in the test configuration,
297         and log the configuration as a config setting.
298
299         https://bugs.webkit.org/show_bug.cgi?id=53562
300
301         * Scripts/webkitpy/layout_tests/port/base.py:
302         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
303         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
304         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
305
306 2011-02-04  Mikhail Naganov  <mnaganov@chromium.org>
307
308         Reviewed by Pavel Feldman.
309
310         Web Inspector: fix processing Unicode literals from .js sources in check-inspector-strings.
311         https://bugs.webkit.org/show_bug.cgi?id=53781
312
313         * Scripts/check-inspector-strings:
314
315 2011-02-04  Adam Roben  <aroben@apple.com>
316
317         Include the crashing function in the link to a crash log on Mac
318
319         Fixes <http://webkit.org/b/53780> Crash log links in results.html should include the
320         function that crashed on Mac
321
322         Reviewed by David Kilzer.
323
324         * Scripts/old-run-webkit-tests:
325         (crashLocation): Moved all the Windows code inside an if instead of using an early return,
326         but didn't otherwise change it. Added an if for Mac that parses the crashing function out of
327         the crash log.
328
329 2011-02-04  Adam Roben  <aroben@apple.com>
330
331         Link to Mac crash logs from results.html
332
333         Fixes <http://webkit.org/b/14861> run-webkit-tests should link to Mac crash logs in
334         results.html
335
336         Reviewed by David Kilzer.
337
338         * Scripts/old-run-webkit-tests:
339         (captureSavedCrashLog): Added a case for Apple's Mac port. We get the crash log out of
340         ~/Library/Logs/CrashReporter, and wait for ReportCrash to exit before trying to get the log.
341
342 2011-02-03  Maciej Stachowiak  <mjs@apple.com>
343
344         Reviewed by Dan Bernstein.
345
346         WebKit2: Need WebKit2 equivalent of WebResourceLoadDelegate::willSendRequest in the Bundle
347         https://bugs.webkit.org/show_bug.cgi?id=52897
348         <rdar://problem/8898294>
349
350         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
351         (WTR::InjectedBundlePage::InjectedBundlePage):
352         (WTR::InjectedBundlePage::willSendRequestForFrame):
353         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
354
355 2011-02-03  Ivan Krstić  <ike@apple.com>
356
357         Unreviewed.
358
359         Adding myself to committers.py.
360
361         * Scripts/webkitpy/common/config/committers.py:
362
363 2011-02-03  James Kozianski  <koz@chromium.org>
364
365         Reviewed by Dimitri Glazkov.
366
367         Add navigator.registerProtocolHandler behind a flag.
368         https://bugs.webkit.org/show_bug.cgi?id=52609
369
370         * Scripts/build-webkit:
371
372 2011-02-03  Hayato Ito  <hayato@chromium.org>
373
374         Reviewed by Eric Seidel.
375
376         [NRWT] Remove TestArgs class, which is wrongly used.
377
378         https://bugs.webkit.org/show_bug.cgi?id=53063
379
380         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
381         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
382         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
383         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
384         * Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py:
385         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
386
387 2011-02-03  Andrew Wason  <rectalogic@rectalogic.com>
388
389         Reviewed by Kenneth Russell.
390
391         Change ENABLE_3D_CANVAS to ENABLE_WEBGL
392         https://bugs.webkit.org/show_bug.cgi?id=53714
393
394         * Scripts/build-webkit: change --3d-canvas build option
395           to set ENABLE_WEBGL
396
397 2011-02-03  Hayato Ito  <hayato@chromium.org>
398
399         Reviewed by Tony Chang.
400
401         [NRWT] Introduces Input/Output class used by base.Driver into port/base.py and
402         move _run_single_test() and _process_output() functions from
403         dump_render_tree_thread.py to a single_test_runner.py as an individual module.
404
405         This is clean up and acts as a preparation for elimination of test_types/*
406         classes. These classes will move to the single_test_runner module introduced
407         in this patch.
408
409         https://bugs.webkit.org/show_bug.cgi?id=53004
410
411         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
412         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py: Added.
413         * Scripts/webkitpy/layout_tests/layout_package/test_input.py:
414         * Scripts/webkitpy/layout_tests/layout_package/test_output.py: Removed.
415         * Scripts/webkitpy/layout_tests/port/base.py:
416         * Scripts/webkitpy/layout_tests/port/chromium.py:
417         * Scripts/webkitpy/layout_tests/port/dryrun.py:
418         * Scripts/webkitpy/layout_tests/port/test.py:
419         * Scripts/webkitpy/layout_tests/port/webkit.py:
420         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
421         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
422         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
423
424 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
425
426         Unreviewed, build fix.
427
428         Delete a line that was accidentally missed in r77586; without it
429         there is still a race between the two threads.
430
431         https://bugs.webkit.org/show_bug.cgi?id=51572
432
433         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
434
435 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
436
437         Reviewed by Tony Chang.
438
439         nrwt: handle "broken pipe" notifications from DRT more cleanly.
440
441         https://bugs.webkit.org/show_bug.cgi?id=52927
442
443         * Scripts/webkitpy/layout_tests/port/server_process.py:
444         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
445
446 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
447
448         Reviewed by Kenneth Russell.
449
450         Update, resubmit change to bug 51572. I think the race that was
451         fixed in r76703 caused the hang that caused us to roll this
452         patch out before, so I'd like to try again.
453
454         https://bugs.webkit.org/show_bug.cgi?id=51572
455
456         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
457         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
458
459 2011-02-03  Daniel Cheng  <dcheng@chromium.org>
460
461         Unreviewed.
462
463         Adding myself to committers.py.
464
465         * Scripts/webkitpy/common/config/committers.py:
466
467 2011-02-03  Adam Roben  <aroben@apple.com>
468
469         Include the crashing function in the link to a crash log
470
471         Fixes <http://webkit.org/b/53739> Crash log links in results.html should include the
472         function that crashed
473
474         Reviewed by David Kilzer.
475
476         * Scripts/old-run-webkit-tests:
477         (crashLocation): Added. Returns the location of the crash.
478         (linksForErrorTest): Include the crash location in the link text for the crash log, if one
479         could be determined.
480
481 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
482
483         Unreviewed, build fix.
484
485         Actually make the changes suggested by Mihai in his review
486         of bug 53720 :(
487
488         https://bugs.webkit.org/show_bug.cgi?id=53720
489
490         * Scripts/webkitpy/layout_tests/port/test_files.py:
491         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
492
493 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
494
495         Reviewed by Mihai Parparita.
496
497         new-run-webkit-tests: Fix bug introduced in r77434 that was
498         causing us to run the canvas GPU tests on the Mac GPU port. This
499         bug revealed that we were not setting the port.name() field
500         properly in many cases, so I've cleaned up all of that code, and
501         removed a few comments about "version-specific" GPU ports that
502         don't exist and just confused things.
503
504         Testing also revealed that port.abspath_for_test() wasn't
505         normalizing paths on Windows properly, so I fixed that as well.
506
507         https://bugs.webkit.org/show_bug.cgi?id=53719
508
509         * Scripts/webkitpy/layout_tests/port/base.py:
510         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
511         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
512
513 2011-02-03  Dirk Pranke  <dpranke@chromium.org>
514
515         Reviewed by Mihai Parparita.
516
517         new-run-webkit-tests: fix normalization of paths on windows when gathering files
518
519         r77434 introduced a bug that was causing the test expectations
520         for the GPU ports to not be treated properly. It turns out that
521         when we gathered the list of test files on Windows, we would
522         return paths of the form "c:\LayoutTests/fast/canvas", and the
523         mixture of backslashes and forward slashes was confusing things.
524
525         This patch normalizes all of the filenames returned from
526         test_files.find(), and adds better tests for this (fixing a
527         couple of other bugs found in the meantime).
528
529         https://bugs.webkit.org/show_bug.cgi?id=53720
530
531         * Scripts/webkitpy/layout_tests/port/test.py:
532         * Scripts/webkitpy/layout_tests/port/test_files.py:
533         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
534
535 2011-02-03  Adam Roben  <aroben@apple.com>
536
537         Add links to Windows crash logs in results.html
538
539         Fixes <http://webkit.org/b/53718> run-webkit-tests should link to Windows crash logs in
540         results.html
541
542         Reviewed by David Kilzer.
543
544         * Scripts/old-run-webkit-tests:
545         (top level): Added $crashLogTag and $windowsCrashLogFilePrefix (which came from
546         createDebuggerCommandFile).
547         (testCrashedOrTimedOut): If the test crashed, capture any saved crash log after the dump
548         tool has exited.
549         (captureSavedCrashLog): Added. Finds the crash log for the test that just crashed and moves
550         it into the test results directory tree. Only implemented for Cygwin currently.
551         (findNewestFileMatchingGlob): Added. Does what it says.
552         (htmlForResultsSection): Only link to files that exist.
553         (linksForErrorTest): Add a link to the crash log.
554         (deleteExpectedAndActualResults): Delete any old crash log for this test.
555         (createDebuggerCommandFile): Use the new $windowsCrashLogFilePrefix constant instead of
556         hardcoding it here.
557
558 2011-02-03  Adam Roben  <aroben@apple.com>
559
560         Tell the debugger the path to the WebKit source tree when saving a crash log
561
562         This allows the debugger to include the crashing line of code in the log.
563
564         Fixes <http://webkit.org/b/53678> Crash logs from buildslaves don't show the crashing line
565         of code
566
567         Reviewed by Sam Weinig.
568
569         * Scripts/old-run-webkit-tests:
570         (createDebuggerCommandFile): Added. Saves commands that we'd like the debugger to run to a
571         file and returns the path to that file. The commands we pass came from
572         setUpWindowsCrashLogSaving, but I've added a .srcpath command to tell the debugger where the
573         WebKit source code lives.
574         (setUpWindowsCrashLogSaving): Instead of specifying the commands directly on the command
575         line using -c, save them to a file and specify the path to that file using -cf. This works
576         around what is presumably a bug in Windows's command line parsing, where having multiple
577         quoted paths in the debugger commands causes the post-mortem debugger not to be invoked at
578         all. Also pulled the options we pass to the debugger out into a list that is then join()ed
579         together to make them easier to modify in the future.
580
581 2011-02-02  Sam Weinig  <sam@webkit.org>
582
583         Reviewed by Anders Carlsson.
584
585         Add notification of the end of a rubber band.
586         <rdar://problem/8940648>
587
588         * MiniBrowser/mac/BrowserWindowController.m:
589         (-[BrowserWindowController awakeFromNib]):
590         * WebKitTestRunner/TestController.cpp:
591         (WTR::TestController::createOtherPage):
592         (WTR::TestController::initialize):
593         Stub out the new WKUIClient function.
594
595 2011-02-03  Gabor Rapcsanyi  <rgabor@webkit.org>
596
597         Unreviewed.
598
599         Adding myself to committers.py.
600
601         * Scripts/webkitpy/common/config/committers.py:
602
603 2011-02-03  Balazs Kelemen  <kbalazs@webkit.org>
604
605         Reviewed by Csaba Osztrogonác.
606
607         [Qt][WK2] MiniBrowser's window size should be 800x600
608         https://bugs.webkit.org/show_bug.cgi?id=53670
609
610         Make layout test failure debugging easier.
611         * MiniBrowser/qt/BrowserWindow.cpp:
612         (BrowserWindow::BrowserWindow):
613
614 2011-02-02  Andy Estes  <aestes@apple.com>
615
616         Reviewed by Mark Rowe.
617
618         'update-webkit' should handle OpenSource and Internal using different
619         VCSs.
620
621         * Scripts/update-webkit: Re-check the VCS type when updating Apple's
622         Internal directory.
623
624 2011-02-02  Dirk Pranke  <dpranke@chromium.org>
625
626         Reviewed by Mihai Parparita.
627
628         new-run-webkit-tests: hardcode the directories to scan for tests
629         for GPU bots instead of SKIPping them. See bug 53562 for some
630         context, but we will now hard-code the list of directories to
631         use by default instead of skipping over directories in the
632         expectations file. We do this so that we will be able to merge
633         the expectations files without getting conflicting SKIP
634         directives. Note that this change will reduce the # of tests
635         being run on the Mac GPU bots, because we're accidentally
636         including some today.
637
638         https://bugs.webkit.org/show_bug.cgi?id=53631
639
640         * Scripts/webkitpy/layout_tests/port/base.py:
641         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
642         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
643
644 2011-02-02  Sam Weinig  <sam@webkit.org>
645
646         Reviewed by Beth Dakin.
647
648         Add ChromeClient function to paint custom overhang areas.
649         https://bugs.webkit.org/show_bug.cgi?id=53639
650
651         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
652         (WTR::InjectedBundlePage::InjectedBundlePage):
653         Stub out new callback.
654
655 2011-02-02  Dirk Pranke  <dpranke@chromium.org>
656
657         Reviewed by Tony Chang.
658
659         new-run-webkit-tests: support chromium code paths in mock_drt
660
661         https://bugs.webkit.org/show_bug.cgi?id=53471
662
663         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
664         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
665
666 2011-02-02  Adam Klein  <adamk@chromium.org>
667
668         Reviewed by Tony Chang.
669
670         Update new-run-webkit-tests --chromium to put output under Source/...
671         https://bugs.webkit.org/show_bug.cgi?id=53612
672
673         * BuildSlaveSupport/test-result-archive:
674         * Scripts/webkitpy/layout_tests/port/chromium.py:
675
676 2011-01-28  Tony Chang  <tony@chromium.org>
677
678         Reviewed by Eric Seidel.
679
680         [chromium] remove --use-test-shell from NRWT
681         https://bugs.webkit.org/show_bug.cgi?id=53346
682
683         I've already started removing some of the bindings like eventSender so
684         this already doesn't work isn't useful.  Also updated some comments to
685         refer to DRT instead of test_shell.
686
687         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
688         * Scripts/webkitpy/layout_tests/port/chromium.py:
689         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
690         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
691         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
692         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
693         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
694         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
695
696 2011-02-02  Steve Lacey  <sjl@chromium.org>
697
698         Reviewed by Eric Carlson.
699
700         Implement basic media statistics on media elements.
701         https://bugs.webkit.org/show_bug.cgi?id=53322
702
703         * Scripts/build-webkit:
704
705 2011-02-02  Kevin Ollivier  <kevino@theolliviers.com>
706
707         [wx] Build fixes for wxWebKit.
708
709         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
710         (LayoutTestController::setSerializeHTTPLoads):
711         * wx/browser/wscript:
712         * wx/build/build_utils.py:
713         * wx/build/settings.py:
714
715 2011-02-01  Dirk Pranke  <dpranke@chromium.org>
716
717         Reviewed by Mihai Parparita.
718
719         new-run-webkit-tests: stop skipping so many tests
720
721         r77163 introduced a regression where we weren't resetting test
722         expectations properly and were skipping too many tests as a
723         result. This patch fixes that and adds a test for it.
724
725         https://bugs.webkit.org/show_bug.cgi?id=53551
726
727         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
728         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
729
730 2011-02-01  Dirk Pranke  <dpranke@chromium.org>
731
732         Reviewed by Tony Chang.
733
734         new-run-webkit-tests: add first stub of test_runner2. This
735         will add support for the 'inline', 'threads', and 'processes'
736         flags to --worker-model, but for now the implementatios just
737         fall back on the old ones.
738
739         https://bugs.webkit.org/show_bug.cgi?id=53157
740
741         * Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
742         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
743
744 2011-02-01  Mihai Parparita  <mihaip@chromium.org>
745
746         Reviewed by James Robinson.
747
748         [Chromium] run-chromium-webkit-unit-tests looks for binaries in the wrong place
749         https://bugs.webkit.org/show_bug.cgi?id=53522
750
751         * Scripts/run-chromium-webkit-unit-tests:
752
753 2011-02-01  Adam Barth  <abarth@webkit.org>
754
755         Reviewed by Mihai Parparita.
756
757         Using Control-C to cancel webkit-patch or other python tools causes
758         unpleasant traceback console spew
759         https://bugs.webkit.org/show_bug.cgi?id=53462
760
761         Catch the exception and don't print the stack trace.
762
763         * Scripts/webkit-patch:
764
765 2011-02-01  Scott Cameron  <sccameron@rim.com>
766
767         Reviewed by Daniel Bates.
768
769         Use Windows format for MinGW HTTPD path.
770         https://bugs.webkit.org/show_bug.cgi?id=53503
771
772         * Scripts/webkitperl/httpd.pm:
773           - Use single-quotes around MySys value for $httpdPath in getHTTPDPath()
774             so that we don't have to escape the space characters in the path. Also,
775             changed path to Windows-style path and removed FIXME comment.
776
777 2011-02-01  Balazs Kelemen  <kbalazs@webkit.org>
778
779         Reviewed by Andreas Kling.
780
781         [Qt][WK2] Add a way to use shared process model in MiniBrowser
782         https://bugs.webkit.org/show_bug.cgi?id=53090
783
784         * MiniBrowser/qt/BrowserView.cpp:
785         (BrowserView::BrowserView): Removed the m_context member.
786         From now the context is guaranteed to be non-null and we
787         don't need to store that in the object.
788         * MiniBrowser/qt/BrowserView.h:
789         * MiniBrowser/qt/BrowserWindow.cpp:
790         Added static bool to determine that new windows need to be
791         created with their own context or not. Use the same context
792         and web process by default to be inilne with the other ports.
793         (BrowserWindow::BrowserWindow):
794         (BrowserWindow::newWindow):
795         * MiniBrowser/qt/BrowserWindow.h:
796         * MiniBrowser/qt/main.cpp:
797         (main): Added command line switch to be able to use the
798         non-shared process model. Simplify the handling of the command line
799         switches a little bit.
800
801 2011-02-01  Zoltan Horvath  <zoltan@webkit.org>
802
803         Reviewed by Andreas Kling.
804
805         [Qt] Add Window menu and Toggle FullScreen action to MiniBrowser.
806         https://bugs.webkit.org/show_bug.cgi?id=53491
807
808         * MiniBrowser/qt/BrowserWindow.cpp:
809         (BrowserWindow::BrowserWindow):
810         (BrowserWindow::toggleFullScreenMode):
811         * MiniBrowser/qt/BrowserWindow.h:
812
813 2011-02-01  Zoltan Horvath  <zoltan@webkit.org>
814
815         Reviewed by Andreas Kling.
816
817         [Qt] Add Toggle Frame Flattening, Auto Load Images and Disable JavaScript actions to MiniBrowser.
818         https://bugs.webkit.org/show_bug.cgi?id=53489
819
820         Add Toggle Frame Flattening action to Develop menu. Add Auto Load Images and Disable JavaScript actions
821         to Settings menu.
822
823         * MiniBrowser/qt/BrowserWindow.cpp:
824         (BrowserWindow::BrowserWindow):
825         (BrowserWindow::toggleFrameFlattening):
826         (BrowserWindow::toggleDisableJavaScript):
827         (BrowserWindow::toggleAutoLoadImages):
828         * MiniBrowser/qt/BrowserWindow.h:
829
830 2011-01-31  Mihai Parparita  <mihaip@chromium.org>
831
832         Reviewed by Tony Chang.
833
834         [Chromium] Switch chromium-mac to use ChromiumDriver
835         https://bugs.webkit.org/show_bug.cgi?id=53461
836         
837         For the sake of consistency with the other Chromium platforms (and so
838         that chromium-mac picks up special flags like --enable-hardware-gpu),
839         switch chromium-mac from the WebKitDriver to ChromiumDriver.
840
841         * Scripts/webkitpy/layout_tests/port/chromium.py:
842
843 2011-01-31  Dirk Pranke  <dpranke@chromium.org>
844
845         Reviewed by Mihai Parparita.
846
847         The current modifier parsing code in test_expectations is
848         fragile and hard-coded, so it's not easy to understand the logic
849         or easily add new types of modifiers (like GPU vs. CPU testing
850         for graphics tests, or 32-bit vs. 64-bit differences).
851
852         This is the first of two patches that will add in more generic
853         support and then eliminate the GPU-specific test expectations
854         files for Chromium.
855
856         This patch adds two standalone objects for handling modifiers. The
857         rules for interpreting modifiers, precedence, and conflicts are
858         given in the docstring to the ModifierMatcher class, which
859         returns ModifierMatchResult objects.
860         
861         This patch also adds routines to the Port interface and a
862         default set of values in the base object, in order to obtain the
863         values needed on a given test run. These values are then passed
864         to the expectation parser. This also allows us to clean up the
865         logic used to lint all of the different configurations in a
866         single test_expectations.txt file.
867
868         The next patch will merge in the separate GPU expectations file.
869
870         https://bugs.webkit.org/show_bug.cgi?id=51222
871
872         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
873         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
874         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
875         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
876         * Scripts/webkitpy/layout_tests/port/base.py:
877         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
878         * Scripts/webkitpy/layout_tests/port/chromium.py:
879         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
880         * Scripts/webkitpy/layout_tests/port/test.py:
881         * Scripts/webkitpy/layout_tests/port/webkit.py:
882         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
883         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
884         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
885         * Tools/Scripts/webkitpy/style/checkers/test_expectations.py:
886         * Tools/Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
887
888 2011-01-31  Scott Cameron  <sccameron@rim.com>
889
890         Reviewed by Daniel Bates.
891
892         update run-webkit-httpd to be able to launch Apache2.2 in a MSYS environment
893         https://bugs.webkit.org/show_bug.cgi?id=50036
894
895         This will add an Apache2.2 configuration file and modifies scripts to allow
896         running an httpd server in an MSYS environment.
897
898         The default Apache2.2 installation path has been preserved and PHP5 modules disabled
899         in order to allow for simple installation/execution.  Simply install the latest
900         Apache2.2 version with OpenSSL from http://httpd.apache.org/download.cgi#apache22 to
901         be able to execute run-webkit-httpd.
902         
903
904         * Scripts/run-webkit-httpd:
905         * Scripts/webkitperl/httpd.pm:
906
907 2011-01-31  Tony Chang  <tony@chromium.org>
908
909         Reviewed by Eric Seidel.
910
911         mac DRT should report RTL scroll offset relative to top right corner
912         https://bugs.webkit.org/show_bug.cgi?id=53324
913
914         * DumpRenderTree/mac/DumpRenderTree.mm:
915         (dumpFrameScrollPosition):
916
917 2011-01-31  Zoltan Horvath  <zoltan@webkit.org>
918
919         Reviewed by Andreas Kling.
920
921         [Qt] Add Take Screen Shot action to MiniBrowser
922         https://bugs.webkit.org/show_bug.cgi?id=53422
923
924         Add Take Screen Shot action to MiniBrowser's view menu.
925
926         * MiniBrowser/qt/BrowserWindow.cpp:
927         (BrowserWindow::BrowserWindow):
928         (BrowserWindow::screenshot):
929         * MiniBrowser/qt/BrowserWindow.h:
930
931 2011-01-31  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
932
933         Reviewed by Xan Lopez.
934
935         [GTK] REGRESSION:  http/tests/media/video-{cookie,referer}.html failing
936         https://bugs.webkit.org/show_bug.cgi?id=53379
937
938         Remove left over #ifdef's. I thought all of the conditional code
939         had been freed from the condition, but I forgot to check DRT.
940
941         * DumpRenderTree/gtk/DumpRenderTree.cpp:
942         (resetDefaultsToConsistentValues):
943         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
944         (LayoutTestController::setAlwaysAcceptCookies):
945
946 2011-01-30  Dirk Pranke  <dpranke@chromium.org>
947
948         Unreviewed, build fix.
949
950         Fix regression introduced in r77093 - path.rsplit() doesn't
951         take keyword arguments.
952
953         https://bugs.webkit.org/show_bug.cgi?id=53326
954
955         * Scripts/webkitpy/common/system/filesystem_mock.py:
956
957 2011-01-30  Dirk Pranke  <dpranke@chromium.org>
958
959         Reviewed by Mihai Parparita.
960
961         Add more unit tests for rebaseline-chromium-webkit-tests. This
962         change involves restructuring a bunch of r-c-w-t code to make it
963         more testable as well. We also add wrapper classes for handling
964         testing zip files and fetching URLs.
965
966         https://bugs.webkit.org/show_bug.cgi?id=53040
967
968         * Scripts/webkitpy/common/system/urlfetcher.py:
969         * Scripts/webkitpy/common/system/urlfetcher_mock.py:
970         * Scripts/webkitpy/common/system/zipfileset_mock.py:
971         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
972         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
973         * Scripts/webkitpy/tool/mocktool.py:
974
975 2011-01-30  Dirk Pranke  <dpranke@chromium.org>
976
977         Reviewed by Eric Seidel.
978
979         Clean up of the filesystem-related modules used in webkitpy.
980         I've added relpath() to the filesystem interface, modified
981         ospath.relpath() so that it could work with the filesystem
982         interface, and modified the fileset* routines to use the
983         filesystem interface consistently.
984
985         This patch also adds a close() routine to the fileset routines
986         to indicate that the caller is done with the fileset. This
987         allows zipfileset to clean up after itself when it creates
988         tempfiles to store downloads.
989
990         https://bugs.webkit.org/show_bug.cgi?id=53326
991
992         * Scripts/webkitpy/common/system/directoryfileset.py:
993         * Scripts/webkitpy/common/system/fileset.py:
994         * Scripts/webkitpy/common/system/filesystem.py:
995         * Scripts/webkitpy/common/system/filesystem_mock.py:
996         * Scripts/webkitpy/common/system/filesystem_unittest.py:
997         * Scripts/webkitpy/common/system/ospath.py:
998         * Scripts/webkitpy/common/system/zipfileset.py:
999         * Scripts/webkitpy/common/system/zipfileset_unittest.py:
1000
1001 2011-01-30  Balazs Kelemen  <kbalazs@webkit.org>
1002
1003         Reviewed by Csaba Osztrogonác.
1004
1005         [Qt][WK2]REGRESSION (r76991): Fix build errors
1006         https://bugs.webkit.org/show_bug.cgi?id=53400
1007
1008         Revert the temporary build fix (http://trac.webkit.org/changeset/77088)
1009         and remove WebKit2Prefix.h from the build.
1010         * MiniBrowser/qt/MiniBrowser.pro:
1011
1012 2011-01-30  Csaba Osztrogonác  <ossy@webkit.org>
1013
1014         Unreviewed.
1015
1016         [Qt][WK2] Buildfix.
1017
1018         * MiniBrowser/qt/MiniBrowser.pro:
1019
1020 2011-01-28  Simon Fraser  <simon.fraser@apple.com>
1021
1022         Reviewed by Adam Roben.
1023         
1024         define NOMINMAX when building ImageDiff, as we do elsewhere.
1025
1026         Add various clampToInt() methods to MathExtras.h
1027         https://bugs.webkit.org/show_bug.cgi?id=52910
1028
1029         * DumpRenderTree/win/ImageDiffCommon.vsprops:
1030
1031 2011-01-28  Maciej Stachowiak  <mjs@apple.com>
1032
1033         Reviewed by Darin Adler.
1034
1035         WebKitTestRunner needs layoutTestController.setPOSIXLocale
1036         https://bugs.webkit.org/show_bug.cgi?id=42682
1037
1038         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1039         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1040         (WTR::InjectedBundle::resetLocalSettings):
1041         (WTR::InjectedBundle::didReceiveMessage):
1042         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1043         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1044         (WTR::LayoutTestController::setPOSIXLocale):
1045         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1046
1047 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
1048  
1049          Reviewed by Mihai Parparita.
1050  
1051          test-webkitpy: fix webkitpy.layout_tests.port.mac_unittest.MacTest.test_skipped_file_paths
1052  
1053          This patch re-enables this test and changes it to
1054          handle all of the mac platform versions, not just the one
1055          it is running on.
1056  
1057          https://bugs.webkit.org/show_bug.cgi?id=53356
1058  
1059          * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1060  
1061 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
1062
1063         Unreviewed, build fix.
1064
1065         Take two. The fix in 77023 didn't work, because we were
1066         still calling path.abspath_to_uri, which calls _cygpath under
1067         the covers, and it appears the cygpath on the bots does
1068         something different than it does on my machine. This patch
1069         removes the calls to path.abspath_to_uri, so it should be safe.
1070         If it doesn't work, I'll roll it out along with r76982 and 77023.
1071
1072         https://bugs.webkit.org/show_bug.cgi?id=53126
1073
1074         * Scripts/webkitpy/layout_tests/port/test.py:
1075
1076 2011-01-28  David Kilzer  <ddkilzer@apple.com>
1077
1078         <rdar://problem/8930699> build-webkit gives a bogus warning with newer versions of Xcode 
1079         <http://webkit.org/b/53353>
1080
1081         Reviewed by Mark Rowe.
1082
1083         * Scripts/webkitdirs.pm:
1084         (checkRequiredSystemConfig): Check the Xcode marketing version
1085         in addition to the DevCoreTools build version before complaining
1086         about an old version of Xcode.  Also make the Mac OS X version
1087         check use Perl's built-in version string comparitor.
1088
1089 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
1090
1091         Unreviewed, build fix.
1092
1093         Work around breakage on Win 7 Release bot caused by r76982
1094         and the fact that windows ports use "file:////" instead of
1095         "file:///". Ideally the test code should be isolated from
1096         this, but it isn't yet. Will fix properly in a bit.
1097
1098         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
1099
1100 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
1101
1102         Reviewed by Tony Chang.
1103
1104         new-run-webkit-tests: change worker model values to
1105         "old-inline", "old-threads" in preparation for test_runner2 /
1106         multiprocessing changes.
1107
1108         https://bugs.webkit.org/show_bug.cgi?id=53156
1109
1110         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1111         * Scripts/webkitpy/layout_tests/port/base.py:
1112         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1113         * Scripts/webkitpy/layout_tests/port/mac.py:
1114         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1115
1116 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
1117
1118         Reviewed by Tony Chang.
1119
1120         committers.py - add an IRC nickname for dpranke
1121         https://bugs.webkit.org/show_bug.cgi?id=53335
1122
1123         * Scripts/webkitpy/common/config/committers.py:
1124
1125 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
1126
1127         Reviewed by Tony Chang.
1128
1129         new-run-webkit-tests: add a "mock DRT" port implementation
1130         and a separate class that emulates what we expect the
1131         DumpRenderTree behavior to be.
1132
1133         This will eventually replace port/dryrun.py and allow us to get
1134         better test coverage of the new-run-webkit-tests code as well as
1135         a reference for what new-run-webkit-tests expects from DRT.
1136
1137         This is the first attempt at this, and it is pretty bare-boned. It
1138         really only has been tested on the 'mac' port (and a little on
1139         the 'chromium-mac' port.
1140
1141         https://bugs.webkit.org/show_bug.cgi?id=53126
1142
1143         * Scripts/webkitpy/common/system/filesystem_mock.py:
1144         * Scripts/webkitpy/layout_tests/port/dryrun.py:
1145         * Scripts/webkitpy/layout_tests/port/factory.py:
1146         * Scripts/webkitpy/layout_tests/port/mock_drt.py: Added.
1147         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Added.
1148         * Scripts/webkitpy/layout_tests/port/test.py:
1149
1150 2011-01-28  Pratik Solanki  <psolanki@apple.com>
1151
1152         Unreviewed. Removing .swp file checked in by mistake.
1153
1154         * Scripts/.webkitdirs.pm.swp: Removed.
1155
1156 2011-01-28  Pratik Solanki  <psolanki@apple.com>
1157
1158         Reviewed by David Kilzer.
1159
1160         Space not necessary for undefined feature
1161         https://bugs.webkit.org/show_bug.cgi?id=53317
1162
1163         * Scripts/build-webkit:
1164
1165 2011-01-28  Chang Shu  <chang.shu@nokia.com>
1166
1167         Reviewed by Andreas Kling.
1168
1169         Reset NetworkAccessManager to clean up credentials from previous tests.
1170         This change causes no performance overhead either.
1171         https://bugs.webkit.org/show_bug.cgi?id=36688
1172
1173         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1174         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1175         (WebCore::DumpRenderTree::open):
1176         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1177
1178 2011-01-28  Zoltan Horvath  <zoltan@webkit.org>
1179
1180         Reviewed by Andreas Kling.
1181
1182         [Qt] Add Zoom Text Only action to MiniBrowser
1183         https://bugs.webkit.org/show_bug.cgi?id=53297
1184
1185         Add Zoom Text Only action to MiniBrowser's view menu, change zoom levels to avoid unnecessary divides.
1186
1187         * MiniBrowser/qt/BrowserWindow.cpp:
1188         (BrowserWindow::BrowserWindow):
1189         (BrowserWindow::zoomIn):
1190         (BrowserWindow::zoomOut):
1191         (BrowserWindow::resetZoom):
1192         (BrowserWindow::toggleZoomTextOnly):
1193         (BrowserWindow::applyZoom):
1194         * MiniBrowser/qt/BrowserWindow.h:
1195
1196 2011-01-28  Adam Barth  <abarth@webkit.org>
1197
1198         Reviewed by Eric Seidel.
1199
1200         Add webkit-patch roll-chromium-deps
1201         https://bugs.webkit.org/show_bug.cgi?id=53288
1202
1203         This command updates the Source/WebKit/chromium/DEPS file with the
1204         last-known good revision of Chromium (or a revision specified on the
1205         command line).  I'd eventually like to turn this into a SheriffBot
1206         command, but this is the first step.
1207
1208         This patch somewhat sprawled because I needed to move a bunch of code
1209         out of ChangeLog that should never have been there in the first place.
1210         Also, I had to fix a bug in MockUser in order to test the new command.
1211
1212         * Scripts/webkitpy/common/checkout/api.py:
1213         * Scripts/webkitpy/common/checkout/changelog.py:
1214         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1215         * Scripts/webkitpy/common/checkout/deps.py: Added.
1216         * Scripts/webkitpy/common/config/urls.py:
1217         * Scripts/webkitpy/tool/commands/__init__.py:
1218         * Scripts/webkitpy/tool/commands/download_unittest.py:
1219         * Scripts/webkitpy/tool/commands/roll.py: Added.
1220         * Scripts/webkitpy/tool/commands/roll_unittest.py: Added.
1221         * Scripts/webkitpy/tool/commands/upload_unittest.py:
1222         * Scripts/webkitpy/tool/mocktool.py:
1223         * Scripts/webkitpy/tool/steps/__init__.py:
1224         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py: Added.
1225         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
1226         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py: Added.
1227         * Scripts/webkitpy/tool/steps/suggestreviewers_unittest.py:
1228         * Scripts/webkitpy/tool/steps/updatechromiumdeps.py: Added.
1229         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
1230
1231 2011-01-27  Greg Coletta  <greg.coletta@nokia.com>
1232
1233         Reviewed by Laszlo Gombos.
1234
1235         Get rid of prefix header dependency for WebKit2 build system
1236         https://bugs.webkit.org/show_bug.cgi?id=50174
1237
1238         Change the style checker so that it enforces config.h include for
1239         WebKit2.
1240
1241         * Scripts/webkitpy/style/checker.py:
1242
1243 2011-01-27  Maciej Stachowiak  <mjs@apple.com>
1244
1245         Reviewed by Darin Adler.
1246
1247         execCommand("Paste") doesn't work in WebKitTestRunner
1248         https://bugs.webkit.org/show_bug.cgi?id=52785
1249
1250         Enable both of the settings needed to allow paste.
1251         
1252         * WebKitTestRunner/TestController.cpp:
1253         (WTR::TestController::resetStateToConsistentValues):
1254
1255 2011-01-27  Jacob Dinu  <dinu.jacob@nokia.com>
1256
1257         Reviewed by Andreas Kling.
1258
1259         [Qt] QtTestBrowser: User input lost when toggling use of QGraphicsView
1260         https://bugs.webkit.org/show_bug.cgi?id=48440
1261
1262         Preserve user input when toggling use of QGraphicsView
1263
1264         * QtTestBrowser/launcherwindow.cpp:
1265         (LauncherWindow::initializeView):
1266         (LauncherWindow::loadFinished):
1267         * QtTestBrowser/launcherwindow.h:
1268         * QtTestBrowser/mainwindow.cpp:
1269         (MainWindow::addressUrl):
1270         * QtTestBrowser/mainwindow.h:
1271
1272 2011-01-27  Dirk Pranke  <dpranke@chromium.org>
1273
1274         Reviewed by Mihai Parparita.
1275
1276         new-run-webkit-tests: turn off pixel tests correctly by default
1277         for webkit-based ports. r70013 (bug 47510) used
1278         port.set_option_default() to attempt to set default values, but
1279         that didn't work correctly. I have removed set_option_default
1280         for now since it was only being used in two places and in three
1281         useless unit tests. There is a separate bug open to fix the
1282         option parsing (48095), so this workaround is fine for now.
1283
1284         https://bugs.webkit.org/show_bug.cgi?id=53217
1285
1286         * Scripts/webkitpy/layout_tests/port/webkit.py:
1287         * Scripts/webkitpy/layout_tests/port/base.py:
1288         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1289
1290 2011-01-27  Balazs Kelemen  <kbalazs@webkit.org>
1291
1292         Rubber-stamped by Ariya Hidayat.
1293
1294         Trivial crash fix in WTR.
1295
1296         * WebKitTestRunner/TestController.cpp:
1297         (WTR::TestController::initialize): Increase the size
1298         of the vector by one to be able to store the null character.
1299
1300 2011-01-27  Balazs Kelemen  <kbalazs@webkit.org>
1301
1302         Reviewed by Csaba Osztrogonác.
1303
1304         [Qt][WK2] WTR should be initialized in the same way as DRT
1305         https://bugs.webkit.org/show_bug.cgi?id=53240
1306
1307         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
1308         (WTR::activateFonts): Added missing initialization steps.
1309
1310 2011-01-27  Joone Hur <joone.hur@collabora.co.uk>
1311
1312         Unreviewed. 
1313
1314         Adding myself to committers.py.
1315
1316         * Scripts/webkitpy/common/config/committers.py:
1317
1318 2011-01-27  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1319
1320         Reviewed by Csaba Osztrogonác.
1321
1322         [Qt] [Symbian] Move project files into Source
1323         https://bugs.webkit.org/show_bug.cgi?id=52891
1324
1325         Fix the Symbian build after the project files
1326         are moved to Source directory. On Symbian qmake
1327         needs to run in the same directory where the main
1328         pro files (WebKit.pro, Tools.pro) are located.
1329
1330         * Scripts/webkitdirs.pm: Change to the directory where the pro file
1331         is located before running qmake for Symbian. Qmake on Symbian
1332         does not properly honor the "-o" option, work it around by setting
1333         the name of the Makefile to bld.inf.
1334
1335 2011-01-27  Zoltan Horvath  <zoltan@webkit.org>
1336
1337         Reviewed by Andreas Kling.
1338
1339         [Qt] Add simple zooming features to MiniBrowser
1340         https://bugs.webkit.org/show_bug.cgi?id=53231
1341
1342         Add View menu and Zoom In, Zoom Out, Zoom Reset actions to MiniBrowser.
1343
1344         * MiniBrowser/qt/BrowserWindow.cpp:
1345         (BrowserWindow::BrowserWindow):
1346         (BrowserWindow::zoomIn):
1347         (BrowserWindow::zoomOut):
1348         (BrowserWindow::resetZoom):
1349         (BrowserWindow::updateUserAgentList):
1350         (BrowserWindow::applyZoom):
1351         * MiniBrowser/qt/BrowserWindow.h:
1352
1353 2011-01-26  Maciej Stachowiak  <mjs@apple.com>
1354
1355         Reviewed by Dan Bernstein.
1356
1357         WebKitTestRunner needs to support layoutTestController.evaluateInWebInspector
1358         https://bugs.webkit.org/show_bug.cgi?id=42319
1359         
1360         Add evaluateInWebInspector and other APIs needed for inspector tests to run.
1361
1362         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1363         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1364         (WTR::LayoutTestController::showWebInspector):
1365         (WTR::LayoutTestController::closeWebInspector):
1366         (WTR::LayoutTestController::evaluateInWebInspector):
1367         (WTR::LayoutTestController::setTimelineProfilingEnabled):
1368         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1369         * WebKitTestRunner/TestInvocation.cpp:
1370         (WTR::shouldOpenWebInspector):
1371         (WTR::TestInvocation::invoke):
1372         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
1373
1374 2011-01-26  Martin Robinson  <mrobinson@igalia.com>
1375
1376         Reviewed by Xan Lopez.
1377
1378         [GTK] Pixel dumps do not include scrollbars in output images
1379         https://bugs.webkit.org/show_bug.cgi?id=53216
1380
1381         Show scrollbars in pixel dumps. This will fix pixel dumps for tests
1382         that have scrollbars.
1383
1384         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
1385         (createBitmapContextFromWebView): Take the snapshot of the containing GtkScrolledWindow
1386         instead of the web view itself.
1387
1388 2011-01-26  Dirk Pranke  <dpranke@chromium.org>
1389
1390         Reviewed by Mihai Parparita.
1391
1392         Fix regression introduced in r76322 ... new-run-webkit-tests
1393         was attempting to save the image diff output as a UTF-8-encoded
1394         file.
1395
1396         https://bugs.webkit.org/show_bug.cgi?id=53210
1397
1398         * Scripts/webkitpy/layout_tests/port/webkit.py:
1399
1400 2011-01-26  Sheriff Bot  <webkit.review.bot@gmail.com>
1401
1402         Unreviewed, rolling out r76709.
1403         http://trac.webkit.org/changeset/76709
1404         https://bugs.webkit.org/show_bug.cgi?id=53194
1405
1406         "broke python tests on non-snowleopard platforms" (Requested
1407         by dpranke on #webkit).
1408
1409         * Scripts/webkitpy/layout_tests/port/factory.py:
1410         * Scripts/webkitpy/layout_tests/port/mock_drt.py: Removed.
1411         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Removed.
1412
1413 2011-01-26  Dirk Pranke  <dpranke@chromium.org>
1414
1415         Reviewed by Tony Chang.
1416
1417         new-run-webkit-tests: add a "mock DRT" port implementation
1418         and a separate class that emulates what we expect the
1419         DumpRenderTree behavior to be.
1420
1421         This will eventually replace port/dryrun.py and allow us to get
1422         better test coverage of the new-run-webkit-tests code as well as
1423         a reference for what new-run-webkit-tests expects from DRT.
1424
1425         This is the first attempt at this, and it is pretty bare-boned. It
1426         really only has been tested on the 'mac' port (and a little on
1427         the 'chromium-mac' port.
1428
1429         https://bugs.webkit.org/show_bug.cgi?id=53126
1430
1431         * Scripts/webkitpy/layout_tests/port/mock_drt.py: Added.
1432         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Added.
1433         * Scripts/webkitpy/layout_tests/port/factory.py:
1434
1435 2011-01-26  Xianzhu Wang  <wangxianzhu@google.com>
1436
1437         Reviewed by Tony Chang.
1438
1439         Add '--no-timeout' option to Chromium DRT to ease debugging.
1440         https://bugs.webkit.org/show_bug.cgi?id=52873
1441
1442         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1443         (main):
1444
1445 2011-01-26  Csaba Osztrogonác  <ossy@webkit.org>
1446
1447         Reviewed by Andreas Kling.
1448
1449         [Qt] Fix qt_minimal build
1450         https://bugs.webkit.org/show_bug.cgi?id=53172
1451
1452         * QtTestBrowser/locationedit.h:
1453
1454 2011-01-26  Mansi Mithal  <mansi.mithal@nokia.com>
1455
1456         Reviewed by Antonio Gomes.
1457
1458         QtTestBrowser should have a UI Setting to disable plugins
1459         https://bugs.webkit.org/show_bug.cgi?id=52408
1460         
1461         Added a new action item named "Disable Plugins"
1462         under the "Settings" menu. 
1463
1464         * QtTestBrowser/launcherwindow.cpp:
1465         (LauncherWindow::createChrome):
1466         (LauncherWindow::togglePlugins):
1467         * QtTestBrowser/launcherwindow.h:
1468
1469 2011-01-25  Patrick Gansterer  <paroga@webkit.org>
1470
1471         Reviewed by Adam Barth.
1472
1473         Move main CMakeLists.txt into Source directory
1474         https://bugs.webkit.org/show_bug.cgi?id=52888
1475
1476         * Scripts/webkitdirs.pm:
1477
1478 2011-01-25  Patrick Gansterer  <paroga@webkit.org>
1479
1480         Reviewed by Eric Seidel.
1481
1482         Improve label text in submit-to-ews
1483         https://bugs.webkit.org/show_bug.cgi?id=53130
1484
1485         * QueueStatusServer/templates/submittoews.html:
1486
1487 2011-01-25  Mansi Mithal  <mansi.mithal@nokia.com>
1488
1489         Reviewed by Antonio Gomes.
1490
1491         QtTestBrowser should have a UI Settings to prevent loading images
1492         https://bugs.webkit.org/show_bug.cgi?id=52409
1493         
1494         Added a new action item named "DisableAutoLoadImages"
1495         under the "Settings" menu 
1496
1497         * QtTestBrowser/launcherwindow.cpp:
1498         (LauncherWindow::createChrome):
1499         (LauncherWindow::toggleAutoLoadImages):
1500         * QtTestBrowser/launcherwindow.h:
1501
1502 2011-01-25  Dirk Pranke  <dpranke@chromium.org>
1503
1504         Reviewed by Tony Chang.
1505
1506         Minor bug fixes and cleanup for filesystem wrappers, port/* test
1507         classes, test_expectations.py. This change adds "test-win" and
1508         "test-mac" variants to the test port so that we can better test
1509         rebaselining, and adds a MockUser() object for reuse in testing.
1510
1511         https://bugs.webkit.org/show_bug.cgi?id=53036
1512
1513         * Scripts/webkitpy/common/system/filesystem.py:
1514         * Scripts/webkitpy/common/system/filesystem_mock.py:
1515         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1516         * Scripts/webkitpy/layout_tests/port/factory.py:
1517         * Scripts/webkitpy/layout_tests/port/base.py:
1518         * Scripts/webkitpy/layout_tests/port/test.py:
1519         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1520         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
1521         * Scripts/webkitpy/tool/mocktool.py:
1522
1523 2011-01-25  Tony Chang  <tony@chromium.org>
1524
1525         Reviewed by Dimitri Glazkov.
1526
1527         [chromium] remove unused layoutTestController callback
1528         https://bugs.webkit.org/show_bug.cgi?id=53103
1529
1530         This method is used by a test_shell_test, but not needed by DRT.
1531
1532         * DumpRenderTree/chromium/LayoutTestController.cpp:
1533         (LayoutTestController::LayoutTestController):
1534         * DumpRenderTree/chromium/LayoutTestController.h:
1535
1536 2011-01-25  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
1537
1538         Reviewed by Andreas Kling.
1539
1540         [GTK] Remove 64 bits release bot from the buildbot master
1541         https://bugs.webkit.org/show_bug.cgi?id=52899
1542
1543         Removes the 64 bits release slave from the buildbot configuration,
1544         so that we can use it as an EWS.
1545
1546         * BuildSlaveSupport/build.webkit.org-config/config.json:
1547
1548 2011-01-24  Maciej Stachowiak  <mjs@apple.com>
1549
1550         Reviewed by Dan Bernstein.
1551
1552         Implement database quota callback to fix storage tests on WebKit2 bot
1553         https://bugs.webkit.org/show_bug.cgi?id=53064
1554
1555         * WebKitTestRunner/TestController.cpp:
1556         (WTR::exceededDatabaseQuota):
1557         (WTR::TestController::createOtherPage):
1558         (WTR::TestController::initialize):
1559
1560 2011-01-24  Maciej Stachowiak  <mjs@apple.com>
1561
1562         Reviewed by Anders Carlsson.
1563
1564         Use designated temp directory for the database for WebKit2
1565         https://bugs.webkit.org/show_bug.cgi?id=53052
1566         
1567         Adopt the new WK2 API for this.
1568
1569         * WebKitTestRunner/TestController.cpp:
1570         (WTR::TestController::libraryPathForTesting):
1571         (WTR::TestController::initialize):
1572         * WebKitTestRunner/TestController.h:
1573         * WebKitTestRunner/mac/TestControllerMac.mm:
1574         (WTR::TestController::platformLibraryPathForTesting):
1575         * WebKitTestRunner/qt/TestControllerQt.cpp:
1576         (WTR::TestController::platformLibraryPathForTesting):
1577         * WebKitTestRunner/win/TestControllerWin.cpp:
1578         (WTR::TestController::platformLibraryPathForTesting):
1579
1580 2011-01-24  Lucas Forschler  <lforschler@apple.com>
1581
1582         Reviewed by Stephanie Lewis.
1583
1584         Add a new Leopard test bot.
1585
1586         * BuildSlaveSupport/build.webkit.org-config/config.json:
1587
1588 2011-01-24  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1589
1590         Reviewed by Adam Barth.
1591
1592         Add EFL Builder to core waterfall
1593         https://bugs.webkit.org/show_bug.cgi?id=52704
1594
1595         Add EFL Builder to the core waterfall again.
1596
1597         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1598         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1599
1600 2011-01-24  Xianzhu Wang  <wangxianzhu@google.com>
1601
1602         Reviewed by Tony Chang.
1603
1604         new-run-webkit-tests fails to start HTTP server if there are proxy settings
1605         https://bugs.webkit.org/show_bug.cgi?id=52872
1606
1607         Force disabling proxy to resolve the problem.
1608
1609         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
1610         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
1611
1612 2011-01-24  Andreas Kling  <kling@webkit.org>
1613
1614         Reviewed by Darin Adler.
1615
1616         check-webkit-style: Update exemptions following Source/ move.
1617         https://bugs.webkit.org/show_bug.cgi?id=53017
1618
1619         * Scripts/webkitpy/style/checker.py:
1620         * Scripts/webkitpy/style/checker_unittest.py:
1621
1622 2011-01-24  Andras Becsi  <abecsi@webkit.org>
1623
1624         Rubber-stamped by Csaba Osztrogonác.
1625
1626         [Qt] Move project files into Source
1627         https://bugs.webkit.org/show_bug.cgi?id=52891
1628
1629         * DumpRenderTree/qt/ImageDiff.pro: Add missing "Source" to WebKit.pri path
1630
1631 2011-01-24  Mikhail Naganov  <mnaganov@chromium.org>
1632
1633         Reviewed by Yury Semikhatsky.
1634
1635         Web Inspector: Find duplicate strings in localizedStrings.js
1636
1637         https://bugs.webkit.org/show_bug.cgi?id=53005
1638
1639         * Scripts/check-inspector-strings:
1640
1641 2011-01-24  Zoltan Horvath  <zoltan@webkit.org>
1642
1643         Reviewed by Andreas Kling.
1644
1645         [Qt] Regroup MiniBrowser's menubar and add open file action
1646         https://bugs.webkit.org/show_bug.cgi?id=53000
1647
1648         Add File and Develop menu to MiniBrowser's menubar and add open file action to File menu.
1649
1650         * MiniBrowser/qt/BrowserWindow.cpp:
1651         (BrowserWindow::BrowserWindow):
1652         (BrowserWindow::openFile):
1653         (BrowserWindow::~BrowserWindow):
1654         * MiniBrowser/qt/BrowserWindow.h:
1655
1656 2011-01-24  Csaba Osztrogonác  <ossy@webkit.org>
1657
1658         Unreviewed fix after r76496
1659
1660         [Qt] Move project files into Source
1661         https://bugs.webkit.org/show_bug.cgi?id=52891
1662
1663         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Remove unnecessary "Source" from the path.
1664         * BuildSlaveSupport/built-product-archive: Remove unnecessary "Source" from the path.
1665         * Scripts/webkitdirs.pm: Add the accidentally removed slash to the path.
1666
1667 2011-01-24  Andras Becsi  <abecsi@webkit.org>
1668
1669         Reviewed by Csaba Osztrogonác.
1670
1671         [Qt] Move project files into Source
1672         https://bugs.webkit.org/show_bug.cgi?id=52891
1673
1674         * DerivedSources.pro: Renamed from DerivedSources.pro.
1675         * DumpRenderTree/qt/DumpRenderTree.pro:
1676         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1677         * MiniBrowser/DerivedSources.pro:
1678         * MiniBrowser/qt/MiniBrowser.pro:
1679         * QtTestBrowser/QtTestBrowser.pro:
1680         * Scripts/webkitdirs.pm:
1681         * Tools.pro: Added.
1682         * WebKitTestRunner/DerivedSources.pro:
1683         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1684         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1685
1686 2011-01-22  Geoffrey Garen  <ggaren@apple.com>
1687
1688         Reviewed by Dan Bernstein.
1689
1690         Beefed up --threaded mode to catch even more kinds of errors.
1691         https://bugs.webkit.org/show_bug.cgi?id=52971
1692
1693         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Use a shared
1694         context group to force JSC to mark multiple threads. (This used to be
1695         the default, but it changed in SnowLeopard.)
1696         (runJavaScriptThread): Do more locking and unlocking, and more allocation,
1697         to give threading mistakes more chances to show themselves.
1698         (startJavaScriptThreads):
1699         (stopJavaScriptThreads):
1700
1701 2011-01-22  Robert Hogan  <robert@webkit.org>
1702
1703         Reviewed by Andreas Kling.
1704
1705         [Qt] Support layoutTestController.addURLToRedirect()
1706         https://bugs.webkit.org/show_bug.cgi?id=52956
1707
1708         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1709         (LayoutTestController::addURLToRedirect):
1710         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1711
1712 2011-01-22  Robert Hogan  <robert@webkit.org>
1713
1714         Reviewed by Kenneth Rohde Christiansen.
1715
1716         [Qt] REGRESSION (r72360): http/tests/security/aboutBlank/xss-DENIED-* tests fail
1717         https://bugs.webkit.org/show_bug.cgi?id=49802
1718
1719         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1720         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1721         (WebCore::DumpRenderTree::open):
1722
1723 2011-01-21  Adam Barth  <abarth@webkit.org>
1724
1725         Reviewed by Maciej Stachowiak.
1726
1727         Disable mac_unittest.py that fails on some of the Mac bots
1728         https://bugs.webkit.org/show_bug.cgi?id=52947
1729
1730         As noted in the comment, this test does not appear to be correct
1731         because the function this test is testing returns different results
1732         depending on which flavor of Mac the test is run on.  This patch
1733         disable the test.  Hopefully we can re-enable the test once we've
1734         probably insulated the test from its environment.
1735
1736         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1737
1738 2011-01-21  Dirk Pranke  <dpranke@chromium.org>
1739
1740         Reviewed by Mihai Parparita.
1741
1742         Fix bug introduced in r76322 that caused NRWT to not actually
1743         read the Skipped files properly.
1744
1745         https://bugs.webkit.org/show_bug.cgi?id=52771
1746
1747         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1748         * Scripts/webkitpy/layout_tests/port/webkit.py:
1749         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1750
1751 2011-01-21  Sam Weinig  <sam@webkit.org>
1752
1753         Reviewed by Geoffrey Sean Garen and Mark Rowe.
1754
1755         WebKitTestRunner needs the HOME environment variable to be set.
1756         <rdar://problem/8896573>
1757
1758         * Scripts/old-run-webkit-tests: Set the HOME environment variable if
1759         it exists.
1760
1761 2011-01-21  Dirk Pranke  <dpranke@chromium.org>
1762
1763         Reviewed by Eric Seidel.
1764
1765         Suppress a few remaining integration tests so that none of the
1766         layout_test unit tests ever read from the filesystem or launch
1767         subprocesses that aren't part of the unit tests.
1768
1769         Also fix a minor bug in the printing unit tests that was
1770         incorrectly relying on sys.argv.
1771
1772         https://bugs.webkit.org/show_bug.cgi?id=52863
1773
1774         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1775         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1776         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1777
1778 2011-01-21  Darin Adler  <darin@apple.com>
1779
1780        Fix Mac build.
1781
1782         * MiniBrowser/mac/BrowserWindowController.m:
1783         (-[BrowserWindowController awakeFromNib]): Pass 0 for runModal function.
1784
1785 2011-01-20  Darin Adler  <darin@apple.com>
1786
1787         Reviewed by Dan Bernstein.
1788
1789         WebKit2: Implement showModalDialog
1790         https://bugs.webkit.org/show_bug.cgi?id=52855
1791
1792         This fixes WebKitTestRunner to compile, but more work is probably
1793         needed to get it to pass the tests.
1794
1795         * WebKitTestRunner/TestController.cpp:
1796         (WTR::TestController::runModal): Added. Calls through to the
1797         platform-specific version of runModal.
1798         (WTR::TestController::createOtherPage): Changed to be a private
1799         static member function so it can refer to runModal, which is
1800         a private static member function.
1801         (WTR::TestController::initialize): Pass 0 for the runModal
1802         function since we don't need to run the main window modal.
1803         I suspect this is wrong and will need to change.
1804         * WebKitTestRunner/TestController.h: Added declarations for
1805         the functions added above.
1806         * WebKitTestRunner/mac/TestControllerMac.mm:
1807         (WTR::TestController::runModal): Added. Untested implementation.
1808         * WebKitTestRunner/qt/TestControllerQt.cpp:
1809         (WTR::TestController::runModal): Added.
1810         * WebKitTestRunner/win/TestControllerWin.cpp:
1811         (WTR::TestController::runModal): Added.
1812
1813 2011-01-21  Eric Seidel  <eric@webkit.org>
1814
1815         Reviewed by Adam Barth.
1816
1817         Split Host object off from WebKitPatch for easier re-use
1818         https://bugs.webkit.org/show_bug.cgi?id=52284
1819
1820         new-run-webkit-tests and other tools are eventually going to want one of these.
1821         Basically you need to inherit from this class if you want to pretend to be a
1822         self.tool object for Steps/Commands.
1823
1824         * Scripts/webkitpy/common/host.py: Added.
1825         * Scripts/webkitpy/tool/main.py:
1826
1827 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1828
1829         Reviewed by Adam Barth.
1830
1831         Disable the tests that start and stop the http server and web
1832         server, so that we don't have to worry about port collisions on
1833         the bots.
1834
1835         https://bugs.webkit.org/show_bug.cgi?id=52861
1836
1837         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1838
1839 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1840
1841         Reviewed by Eric Seidel.
1842
1843         nrwt: rewrite google_chrome_unittest to use mock filesystem.
1844         
1845         https://bugs.webkit.org/show_bug.cgi?id=52772
1846         
1847         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
1848
1849 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1850
1851         Reviewed by Eric Siedel.
1852
1853         nrwt: clean up almost all remaining port references, remove
1854         unnecessary import clauses. The only remaining references are
1855         in places where a mock filesystem makes no sense or can't be
1856         used, and in one routine in port/google_chrome_unittest that
1857         I'll rewrite in a separate patch.
1858
1859         https://bugs.webkit.org/show_bug.cgi?id=52771
1860
1861         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1862         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1863         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1864         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1865         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1866         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1867         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1868         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
1869         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
1870         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
1871         * Scripts/webkitpy/layout_tests/port/gtk.py:
1872         * Scripts/webkitpy/layout_tests/port/mac.py:
1873         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1874         * Scripts/webkitpy/layout_tests/port/qt.py:
1875         * Scripts/webkitpy/layout_tests/port/webkit.py:
1876         * Scripts/webkitpy/layout_tests/port/win.py:
1877         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
1878
1879 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1880
1881         Reviewed by Mihai Parparita.
1882
1883         remove fs refs from run_webkit_tests, rebaseline_chromium_webkit_tests
1884
1885         https://bugs.webkit.org/show_bug.cgi?id=52762
1886
1887         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1888         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1889
1890 2011-01-20  Tony Chang  <tony@chromium.org>
1891
1892         Reviewed by Ojan Vafai.
1893
1894         [chromium] fix the paths used for the rebaseline tool
1895         https://bugs.webkit.org/show_bug.cgi?id=52857
1896
1897         Some of the bots were renamed so the path to grab the results zip
1898         file has changed.
1899
1900         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1901
1902 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1903
1904         Reviewed by Tony Chang.
1905
1906         Fix bug introduced in r72688 / bug 52768 that broke the
1907         generation of the output filename links in the results.html
1908         output. Apparently none of the unit tests actually checked to
1909         make sure the generated links were correct :(
1910
1911         https://bugs.webkit.org/show_bug.cgi?id=52854
1912
1913         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1914         * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
1915
1916 2011-01-20  Alexey Proskuryakov  <ap@apple.com>
1917
1918         Reviewed by Darin Adler.
1919
1920         https://bugs.webkit.org/show_bug.cgi?id=52849
1921         Make window.print work with WebKit2
1922
1923         * MiniBrowser/mac/BrowserWindowController.m:
1924         (-[BrowserWindowController awakeFromNib]):
1925         * WebKitTestRunner/TestController.cpp:
1926         (WTR::createOtherPage):
1927         (WTR::TestController::initialize):
1928         Added zeroes to WKPageUIClient structures to avoid build failures.
1929
1930 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
1931
1932         Reviewed by Eric Seidel.
1933
1934         nrwt: remove fs refs from printing, test_failures, test_expectations, text_diff
1935
1936         https://bugs.webkit.org/show_bug.cgi?id=52756
1937
1938         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
1939         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1940         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1941         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
1942         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1943         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
1944
1945 2011-01-20  Mansi Mithal  <mansi.mithal@nokia.com>
1946
1947         Reviewed by Antonio Gomes.
1948
1949         QtTestBrowser should have a seperate menu for Settings
1950         https://bugs.webkit.org/show_bug.cgi?id=52817
1951         
1952         Added a new menu item named "Settings"
1953         and moved the "Enable interrupting js scripts" and "Enable js pop up windows" under the "Settings" menu 
1954
1955         * QtTestBrowser/launcherwindow.cpp:
1956         (LauncherWindow::createChrome):
1957
1958 2011-01-20  Sam Weinig  <sam@webkit.org>
1959
1960         Reviewed by John Sullivan.
1961
1962         Update update-webkit-localizable-strings with new path to WebKit.
1963
1964         * Scripts/update-webkit-localizable-strings:
1965
1966 2011-01-20  James Robinson  <jamesr@chromium.org>
1967
1968         Reviewed by Darin Fisher.
1969
1970         Implement mozilla's requestAnimationFrame API
1971         https://bugs.webkit.org/show_bug.cgi?id=51218
1972
1973         Chromium DumpRenderTree support for window.webkitRequestAnimationFrame.
1974
1975         * DumpRenderTree/chromium/WebViewHost.cpp:
1976         (invokeScheduleComposite):
1977         (WebViewHost::scheduleAnimation):
1978         (WebViewHost::paintInvalidatedRegion):
1979         * DumpRenderTree/chromium/WebViewHost.h:
1980
1981 2011-01-20  Maciej Stachowiak  <mjs@apple.com>
1982
1983         Reviewed by Adam Roben.
1984
1985         WebKitTestRunner needs to support layoutTestController.evaluateScriptInIsolatedWorld
1986         https://bugs.webkit.org/show_bug.cgi?id=42327
1987
1988         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm: Add support
1989         for methods that take their normal arguments but also a JSContextRef.
1990         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: IDL definition
1991         for evaluateScriptInIsolatedWorld.
1992         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1993         (WTR::InjectedBundlePage::didClearWindowForFrame): Set a magic variable only if
1994         this call is for an isolated world.
1995         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1996         (WTR::worldMap): Helper to create a world map.
1997         (WTR::LayoutTestController::worldIDForWorld): Map from an ID to a world.
1998         (WTR::LayoutTestController::evaluateScriptInIsolatedWorld): The newly
1999         added LayoutTestController API.
2000         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2001
2002 2011-01-19  Adam Roben  <aroben@apple.com>
2003
2004         Convert paths in environment variables back to msys-style inside commit-log-editor
2005
2006         When this script gets run from inside git commit, msys-style paths in the environment will
2007         have been turned into Windows-style paths with forward slashes. This screws up functions
2008         like File::Spec->rel2abs, which seem to rely on $PWD having an msys-style path. We convert
2009         the paths back to msys-style before doing anything else.
2010
2011         Fixes <http://webkit.org/b/48527> commit-log-editor uses full paths for section headers when
2012         using msysgit's Perl and multiple ChangeLogs have been edited
2013
2014         Reviewed by David Kilzer.
2015
2016         * Scripts/commit-log-editor: Call fixEnvironment before doing anything else.
2017         (fixEnvironment): Added. When run in msys in conjunction with git (i.e., when invoked from
2018         inside git commit), convert Windows-style paths in the environment back to msys-style paths.
2019
2020 2011-01-20  Zoltan Horvath  <zoltan@webkit.org>
2021
2022         [Win] Unreviewed build fix after r76248.
2023
2024         * DumpRenderTree/ForwardingHeaders/wtf/FastAllocBase.h: Added.
2025
2026 2011-01-20  Zoltan Horvath  <zoltan@webkit.org>
2027
2028         Reviewed by Csaba Osztrogonác.
2029
2030         Refactoring of the custom allocation framework
2031         https://bugs.webkit.org/show_bug.cgi?id=49897
2032
2033         Inheriting from FastAllocBase can result in objects getting larger (bug #33896, #46589).
2034         The modification replaces Noncopyable and FastAllocBase classes and these inherits with their
2035         equivalent macro implementation at the necessary places.
2036 2011-01-20  Yi Shen  <yi.4.shen@nokia.com>
2037
2038         Unreviewed. 
2039
2040         Adding myself to committers.py.
2041
2042         * Scripts/webkitpy/common/config/committers.py:
2043
2044 2011-01-20  Adam Barth  <abarth@webkit.org>
2045
2046         Reviewed by Tony Chang.
2047
2048         Chromium builders don't delete unversioned directories when DEPS change
2049         https://bugs.webkit.org/show_bug.cgi?id=52745
2050
2051         If we pass this option to gclient sync, gclient will delete directories
2052         that are no longer part of DEPS instead of leaving them around to
2053         confuse us later.  Apparently, the downstream buildbots use this option
2054         already.
2055
2056         * Scripts/update-webkit-chromium:
2057
2058 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2059
2060         Unreviewed, build fix - I pulled this patch in to fix an issue
2061         revealed by r76195 running on some new bots). Also fix a couple
2062         of other issues revealed in testing.
2063
2064         nrwt: remove fs refs from layout_package/json*
2065
2066         https://bugs.webkit.org/show_bug.cgi?id=52754
2067
2068         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2069         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
2070         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
2071         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2072         * Scripts/webkitpy/layout_tests/port/base.py:
2073
2074 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2075
2076         Unreviewed, build fix.
2077
2078         Fix a couple of minor bugs discovered while bringing up new bots
2079         for testing.
2080
2081         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2082         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2083
2084 2011-01-19  James Robinson  <jamesr@chromium.org>
2085
2086         Unreviewed, rolling out r76194.
2087         http://trac.webkit.org/changeset/76194
2088         https://bugs.webkit.org/show_bug.cgi?id=51218
2089
2090         Caused mysterious compile failure on the chromium win
2091         build.webkit.org bots
2092
2093         * DumpRenderTree/chromium/WebViewHost.cpp:
2094         (WebViewHost::paintInvalidatedRegion):
2095         * DumpRenderTree/chromium/WebViewHost.h:
2096
2097 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2098
2099         Reviewed by Mihai Parparita.
2100
2101         remove fs refs from test_runner, dump_render_tree_thread
2102
2103         https://bugs.webkit.org/show_bug.cgi?id=52753
2104
2105         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2106         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2107         * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
2108         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2109
2110 2011-01-19  James Robinson  <jamesr@chromium.org>
2111
2112         Reviewed by Darin Fisher.
2113
2114         Implement mozilla's requestAnimationFrame API
2115         https://bugs.webkit.org/show_bug.cgi?id=51218
2116
2117         Chromium DumpRenderTree support for window.webkitRequestAnimationFrame.
2118
2119         * DumpRenderTree/chromium/WebViewHost.cpp:
2120         (invokeScheduleComposite):
2121         (WebViewHost::scheduleAnimation):
2122         (WebViewHost::paintInvalidatedRegion):
2123         * DumpRenderTree/chromium/WebViewHost.h:
2124
2125 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2126
2127         Unreviewed, build fix.
2128
2129         Fix a few incorrect "self._filesystem" references introduced in
2130         r76184.
2131
2132         * Scripts/webkitpy/layout_tests/port/chromium.py:
2133         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2134
2135 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2136
2137         Reviewed by Mihai Parparita.
2138
2139         add a .sep property, abspath(), isabs(), mtime(), and
2140         open_text_file_for_writing() to filesystem modules. Some of
2141         these properties are not needed in this patch but will be needed
2142         in subsequent patches (I'm doing this to avoid having to track
2143         multiple versions of a single file).
2144
2145         Also, change most of the port/* modules to use the filesystem
2146         objects instead of referencing the filesystem directly.
2147
2148         https://bugs.webkit.org/show_bug.cgi?id=52748
2149
2150         * Scripts/webkitpy/common/system/filesystem.py:
2151         * Scripts/webkitpy/common/system/filesystem_mock.py:
2152         * Scripts/webkitpy/layout_tests/port/__init__.py:
2153         * Scripts/webkitpy/layout_tests/port/base.py:
2154         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2155         * Scripts/webkitpy/layout_tests/port/chromium.py:
2156         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2157         * Scripts/webkitpy/layout_tests/port/config.py:
2158         * Scripts/webkitpy/layout_tests/port/test.py:
2159         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
2160
2161 2011-01-19  Maciej Stachowiak  <mjs@apple.com>
2162
2163         Reviewed by Anders Carlsson.
2164
2165         If resetting between tests times out, treat it as a WebProcess crash
2166         https://bugs.webkit.org/show_bug.cgi?id=52757
2167
2168         * WebKitTestRunner/TestController.cpp:
2169         (WTR::TestController::runTest):
2170
2171 2011-01-19  Alexey Proskuryakov  <ap@apple.com>
2172
2173         Reviewed by Darin Adler.
2174
2175         https://bugs.webkit.org/show_bug.cgi?id=52739
2176         Make it possible for a WebKit2 client to print headers and footers
2177
2178         Added dummy implementations for new printing UIClient calls.
2179
2180         * MiniBrowser/mac/BrowserWindowController.m:
2181         (-[BrowserWindowController awakeFromNib]):
2182         * WebKitTestRunner/TestController.cpp:
2183         (WTR::createOtherPage):
2184         (WTR::TestController::initialize):
2185
2186 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2187
2188         Reviewed by Ojan Vafai.
2189
2190         Change webkitpy/layout_tests/port/test.py to use the
2191         in-memory filesystem for cleaner unit testing. This
2192         change allows us to kill a lot of code that was
2193         specific to the test port, at the cost of being a
2194         little less clear about how things would work if
2195         you didn't have a filesystem.
2196
2197         https://bugs.webkit.org/show_bug.cgi?id=52605
2198
2199         * Scripts/webkitpy/layout_tests/port/test.py:
2200
2201 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2202
2203         Unreviewed, build fix.
2204
2205         Fix test failure caused by committing attachment 79368 instead
2206         of attachment 79461 on bug 52604.
2207
2208         * Scripts/webkitpy/common/system/filesystem_mock.py:
2209
2210 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2211
2212         Reviewed by Mihai Parparita.
2213
2214         new-run-webkit-tests: remove use of os.walk, use mock filesystem for better
2215         unit testing. os.walk() is too much of a hassle to implement on
2216         top of the in-memory mock filesystem and adding the necessary
2217         interface to files_under() gives clients a cleaner API anyway
2218         (for this particular usage model).
2219
2220         https://bugs.webkit.org/show_bug.cgi?id=52691
2221
2222         * Scripts/webkitpy/common/system/filesystem.py:
2223         * Scripts/webkitpy/common/system/filesystem_mock.py:
2224         * Scripts/webkitpy/layout_tests/port/test_files.py:
2225         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
2226
2227 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
2228
2229         Reviewed by Tony Chang.
2230
2231         Change more modules in the layout-tests code to use the
2232         filesystem wrapper for cleaner unit testing.
2233
2234         This patch also adds the glob() wrapper to the filesystem
2235         abstraction.
2236         
2237         https://bugs.webkit.org/show_bug.cgi?id=52604
2238
2239         * Scripts/webkitpy/layout_tests/port/test_files.py:
2240         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
2241         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
2242         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2243         * Scripts/webkitpy/common/system/filesystem.py:
2244         * Scripts/webkitpy/common/system/filesystem_mock.py:
2245
2246 2011-01-19  Levi Weintraub  <leviw@chromium.org>
2247
2248         Unreviewed.
2249
2250         Updating my email addresses and irc nick.
2251
2252         * Scripts/webkitpy/common/config/committers.py:
2253
2254 2011-01-19  Tony Chang  <tony@chromium.org>
2255
2256         Reviewed by Mihai Parparita.
2257
2258         [chromium] [linux] if check-sys-deps fails, output the failure reason
2259         https://bugs.webkit.org/show_bug.cgi?id=52671
2260
2261         * Scripts/webkitpy/common/system/executive_mock.py: Add support for
2262             error handler functions.
2263         * Scripts/webkitpy/layout_tests/port/chromium.py:
2264             output the error text from --check-sys-deps
2265         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2266
2267 2011-01-19  Aparna Nandyal  <aparna.nand@wipro.com>
2268
2269         Reviewed by Andreas Kling.
2270
2271         [Qt] QtTestBrowser crashes when closing if Facebook is opened
2272         https://bugs.webkit.org/show_bug.cgi?id=52554
2273         
2274         QtNetworkAccessManager is created in a thread and set as
2275         member variable in QWebPage. When the thread is destroyed
2276         the object is still used. So fix will set the object to
2277         NULL once the thread is destroyed.
2278
2279         * QtTestBrowser/launcherwindow.cpp:
2280         (LauncherWindow::~LauncherWindow):
2281
2282 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
2283
2284         Rubber stamped by Csaba Osztrogonac
2285
2286         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: Removed unncessary inculde of WKStringCF.h
2287
2288 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
2289
2290         Reviewed by Tony Chang.
2291
2292         new-run-webkit-tests: add a --build-directory command line argument
2293
2294         Official Google Chrome builds use a non-standard build directory
2295         location. This patch adds a --build-directory argument that
2296         allows that location to be specified on the command line. Only
2297         Chromium-based builds will use this flag for now, but anyone can
2298         in the future.
2299
2300         There are no unit tests for this since it's difficult to test
2301         until mock filesystems are fully supported in the code. This was
2302         tested by hand for now.
2303
2304         https://bugs.webkit.org/show_bug.cgi?id=52694
2305
2306         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2307         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2308         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2309         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2310
2311 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
2312
2313         Not reviewed. Bot fix.
2314
2315         Remove an inadvertently committed debugging print.
2316
2317         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2318         (LayoutTestController::notifyDone):
2319
2320 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
2321
2322         Reviewed by Sam Weinig.
2323
2324         WebKitTestRunner should track loading more like DumpRenderTree
2325         https://bugs.webkit.org/show_bug.cgi?id=52692
2326
2327         Change load tracking to track the current top loading frame, in the manner of DumpRenderTree.
2328         This makes some tests that call notifyDone multiple times pass.
2329         
2330         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2331         (WTR::InjectedBundle::InjectedBundle):
2332         (WTR::InjectedBundle::done):
2333         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2334         (WTR::InjectedBundle::topLoadingFrame):
2335         (WTR::InjectedBundle::setTopLoadingFrame):
2336         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2337         (WTR::InjectedBundlePage::InjectedBundlePage):
2338         (WTR::InjectedBundlePage::stopLoading):
2339         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
2340         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
2341         (WTR::InjectedBundlePage::didFinishLoadForFrame):
2342         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
2343         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2344         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2345         (WTR::LayoutTestController::notifyDone):
2346         * WebKitTestRunner/TestController.cpp:
2347         (WTR::TestController::didReceiveMessageFromInjectedBundle):
2348
2349 2011-01-18  Mihai Parparita  <mihaip@chromium.org>
2350
2351         Reviewed by Kent Tamura.
2352
2353         [Chromium] NRWT looking for DRT binary in the wrong path on Mac
2354         https://bugs.webkit.org/show_bug.cgi?id=52678
2355         
2356         Update path now that WebKit is inside Source.
2357
2358         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2359
2360 2011-01-18  Robert Hogan  <robert@webkit.org>
2361
2362         Reviewed by Simon Hausmann.
2363
2364         [Qt] http/tests/incremental/slow-utf8-text.pl fails
2365         https://bugs.webkit.org/show_bug.cgi?id=44282
2366
2367         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2368         (WebCore::DumpRenderTree::dump):
2369
2370 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
2371
2372         Reviewed by Mihai Parparita.
2373
2374         Fix a small race condition that could cause the unit tests for
2375         new-run-webkit-tests to fail in a multithreaded environment.
2376         There was a small window in the code where one thread would
2377         check to see if a thread had raised an exception, do something,
2378         and then check to see if the thread was alive. If the other
2379         thread raised an exception and exited in between these two
2380         steps, the exception would be lost. Flipping the order of the
2381         two checks fixes the race, since we will now always check for an
2382         exception on the thread before exiting.
2383
2384         https://bugs.webkit.org/show_bug.cgi?id=51579
2385
2386         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
2387
2388 2011-01-18  Eric Seidel  <eric@webkit.org>
2389
2390         Reviewed by Adam Barth.
2391
2392         commit-queue dies when test archiving fails
2393         https://bugs.webkit.org/show_bug.cgi?id=52617
2394
2395         I looked at the machine and it had 10 archives already
2396         thus find_unused_name was returning None.  I've upped
2397         the limit to 100 (per bug) and tested the case where
2398         find_unused_name returns None (making archive return None).
2399
2400         * Scripts/webkitpy/common/system/workspace.py:
2401         * Scripts/webkitpy/common/system/workspace_unittest.py:
2402         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2403         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2404         * Scripts/webkitpy/tool/commands/queues.py:
2405
2406 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
2407
2408         Reviewed by Ojan Vafai.
2409
2410         Update rebaseline-chromium-webkit-tests unit tests to use a mock
2411         filesystem. Also fix a couple of "with" statements missed by
2412         r76050.
2413
2414         https://bugs.webkit.org/show_bug.cgi?id=52487
2415
2416         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
2417
2418 2011-01-18  Sergio Villar Senin  <svillar@igalia.com>
2419
2420         Reviewed by Martin Robinson.
2421
2422         [Gtk] Build fixes for gtk3 build
2423         https://bugs.webkit.org/show_bug.cgi?id=52648
2424
2425         * DumpRenderTree/gtk/EventSender.cpp:
2426         (beginDragWithFilesCallback):
2427
2428 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
2429
2430         Reviewed by Mihai Parparita.
2431
2432         Update rebaseline-chromium-webkit-tests to use filesystem objects
2433         instead of direct references to os.path, shutil, tempfile, etc.
2434
2435         This patch doesn't change anything, but will allow subsequent
2436         patches to change the unit tests to no longer use the real
2437         filesystem.
2438
2439         This patch adds a bunch more methods to the filesystem object as
2440         well.
2441
2442         https://bugs.webkit.org/show_bug.cgi?id=52482
2443
2444         * Scripts/webkitpy/common/system/filesystem.py:
2445         * Scripts/webkitpy/common/system/filesystem_mock.py:
2446         * Scripts/webkitpy/tool/commands/queues.py:
2447         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2448         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
2449
2450 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
2451
2452         Reviewed by Mihai Parparita.
2453
2454         new-run-webkit-tests shouldn't crash when you try to run a
2455         directory containing only skipped files.
2456
2457         https://bugs.webkit.org/show_bug.cgi?id=52478
2458         
2459         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2460         * Scripts/webkitpy/layout_tests/port/test.py:
2461         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2462
2463 2011-01-18  Adam Bergkvist  <adam.bergkvist@ericsson.com> and Martin Robinson  <mrobinson@igalia.com>
2464
2465         Reviewed by Gustavo Noronha Silva.
2466
2467         [GTK] The GTK+ EventSender needs support for beginDragWithFiles
2468         https://bugs.webkit.org/show_bug.cgi?id=40833
2469
2470         * DumpRenderTree/gtk/EventSender.cpp: Add a beginDragWithFiles implementation for the
2471         GTK+ event sender.
2472         (dragWithFilesDragDataGetCallback): Added.
2473         (dragWithFilesDragEndCallback): Added.
2474         (beginDragWithFilesCallback): Added.
2475
2476 2011-01-18  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2477
2478         Reviewed by Adam Barth.
2479
2480         ews: Add additional watcher to efl ews
2481         https://bugs.webkit.org/show_bug.cgi?id=52613
2482
2483         Add gyuyoung.kim@samsung.com to watcher list of efl-ews.
2484
2485         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2486
2487 2011-01-17  Tony Gentilcore  <tonyg@chromium.org>
2488
2489         Reviewed by Alexey Proskuryakov.
2490
2491         Fix some headers with missing or misspelled #ifndef guards
2492         https://bugs.webkit.org/show_bug.cgi?id=52545
2493
2494         * DumpRenderTree/chromium/TestEventPrinter.h:
2495         * DumpRenderTree/chromium/WebPreferences.h:
2496
2497 2011-01-17  Jessie Berlin  <jberlin@apple.com>
2498
2499         Reviewed by Anders Carlsson.
2500
2501         REGRESSION: Assertion failure in FrameLoader::continueLoadAfterWillSubmitForm() when
2502         navigating back to an unreachable URL
2503         https://bugs.webkit.org/show_bug.cgi?id=52388
2504
2505         Add a third parameter (unreachableURL) to queueLoadHTMLString.
2506
2507         * DumpRenderTree/LayoutTestController.cpp:
2508         (queueLoadHTMLStringCallback):
2509         (LayoutTestController::queueLoadHTMLString):
2510         (LayoutTestController::queueLoadAlternateHTMLString):
2511         * DumpRenderTree/LayoutTestController.h:
2512
2513         * DumpRenderTree/WorkQueueItem.h:
2514         (LoadHTMLStringItem::LoadHTMLStringItem):
2515
2516         * DumpRenderTree/chromium/LayoutTestController.cpp:
2517         (WorkItemLoadHTMLString::WorkItemLoadHTMLString):
2518         (WorkItemLoadHTMLString::run):
2519         (LayoutTestController::queueLoadHTMLString):
2520
2521         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
2522         (LoadHTMLStringItem::invoke):
2523         * DumpRenderTree/mac/WorkQueueItemMac.mm:
2524         (LoadHTMLStringItem::invoke):
2525         * DumpRenderTree/win/WorkQueueItemWin.cpp:
2526         (LoadHTMLStringItem::invoke):
2527
2528 2011-01-17  Dan Bernstein  <mitz@apple.com>
2529
2530         Rubber-stamped by Mark Rowe.
2531
2532         Update xcodeproj svn:ignore to include xcuserdata.
2533
2534         * DumpRenderTree/DumpRenderTree.xcodeproj: Modified property svn:ignore.
2535         * MiniBrowser/MiniBrowser.xcodeproj: Modified property svn:ignore.
2536         * TestWebKitAPI/TestWebKitAPI.xcodeproj: Modified property svn:ignore.
2537         * WebKitLauncher/WebKitLauncher.xcodeproj: Modified property svn:ignore.
2538         * WebKitTestRunner/WebKitTestRunner.xcodeproj: Modified property svn:ignore.
2539
2540 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
2541
2542         Unreviewed fix after r75908.
2543
2544         Move WebKit into Source
2545         https://bugs.webkit.org/show_bug.cgi?id=52530
2546
2547         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add Source to the path for Qt API tests.
2548
2549 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
2550
2551         Unreviewed.
2552
2553         Remove accidentally committed debug printing after r75908.
2554
2555         * Scripts/webkitdirs.pm:
2556
2557 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
2558
2559         Unreviewed.
2560
2561         Add myself to committers list
2562         https://bugs.webkit.org/show_bug.cgi?id=52566
2563
2564         * Scripts/webkitpy/common/config/committers.py:
2565
2566 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
2567
2568         Reviewed by Jeremy Orlow.
2569
2570         GeolocationController should call stopUpdating on destruction
2571         https://bugs.webkit.org/show_bug.cgi?id=52216
2572
2573         fast/dom/Geolocation/window-close-crash.html requires that a
2574         Geolocation watch be started in a secondary window. Consequently,
2575         we need to allow geolocation permission and provide a mock
2576         geolocation position for the secondary window's
2577         GeolocationClientMock.
2578
2579         * DumpRenderTree/chromium/LayoutTestController.cpp:
2580         (LayoutTestController::setGeolocationPermission):
2581         (LayoutTestController::setMockGeolocationPosition):
2582         (LayoutTestController::setMockGeolocationError):
2583         * DumpRenderTree/chromium/TestShell.h:
2584         (TestShell::windowList):
2585
2586 2011-01-16  Adam Barth  <abarth@webkit.org>
2587
2588         Update more include paths to reflect WebKit move.
2589
2590         * DumpRenderTree/chromium/EventSender.cpp:
2591         (EventSender::keyDown):
2592         (EventSender::needsShiftModifier):
2593         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
2594         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
2595
2596 2011-01-16  Kent Tamura  <tkent@chromium.org>
2597
2598         Unreviewed, Chromium build fix.
2599
2600         * Scripts/update-webkit-chromium: Webkit/chromium -> Source/WebKit/chromium
2601
2602 2011-01-16  Martin Robinson  <mrobinson@igalia.com>
2603
2604         Build fix for GTK+ after source directory movement.
2605
2606         * GNUmakefile.am: Correct include paths.
2607
2608 2011-01-16  Adam Barth  <abarth@webkit.org>
2609
2610         Teach svn-apply about WebKit move.
2611
2612         * Scripts/VCSUtils.pm:
2613
2614 2011-01-16  Adam Barth  <abarth@webkit.org>
2615
2616         Rubber-stamped by Eric Seidel.
2617
2618         Move WebKit into Source
2619         https://bugs.webkit.org/show_bug.cgi?id=52530
2620
2621         * DumpRenderTree/mac/InternalHeaders/WebKit/WebTypesInternal.h:
2622         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2623         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2624         * DumpRenderTree/qt/GCControllerQt.cpp:
2625         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2626         * DumpRenderTree/qt/PlainTextControllerQt.cpp:
2627         * DumpRenderTree/qt/TextInputControllerQt.cpp:
2628         * DumpRenderTree/wscript:
2629         * QtTestBrowser/launcherwindow.h:
2630         * Scripts/build-webkit:
2631         * Scripts/webkitdirs.pm:
2632
2633 2011-01-15  Adam Barth  <abarth@webkit.org>
2634
2635         Teach svn-apply about WebKit2 move.
2636
2637         * Scripts/VCSUtils.pm:
2638
2639 2011-01-15  Adam Barth  <abarth@webkit.org>
2640
2641         Rubber-stamped by Eric Seidel.
2642
2643         Move WebKit2 into Source
2644         https://bugs.webkit.org/show_bug.cgi?id=52438
2645
2646         * MiniBrowser/qt/MiniBrowser.pro:
2647         * Scripts/build-webkit:
2648         * Scripts/do-file-rename:
2649         * Scripts/do-webcore-rename:
2650         * Scripts/test-webkitpy:
2651         * Scripts/webkitdirs.pm:
2652         * Scripts/webkitpy/style/checker.py:
2653         * WebKitTestRunner/DerivedSources.pro:
2654         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2655         * WebKitTestRunner/qt/WebKitTestRunner.pro:
2656
2657 2011-01-15  Jochen Eisinger  <jochen@chromium.org>
2658
2659         Reviewed by David Levin.
2660
2661         [chromium] remove obsolete createView method
2662         https://bugs.webkit.org/show_bug.cgi?id=52437
2663
2664         * DumpRenderTree/chromium/WebViewHost.cpp:
2665         (WebViewHost::createView):
2666         * DumpRenderTree/chromium/WebViewHost.h:
2667
2668 2011-01-14  Brian Weinstein  <bweinstein@apple.com>
2669
2670         Reviewed by Geoff Garen.
2671
2672         ShouldLoadResourceForFrame should use strings, not URLs.
2673         https://bugs.webkit.org/show_bug.cgi?id=52476
2674
2675         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2676         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Update to use a WKStringRef.
2677         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2678
2679 2011-01-14  Tony Gentilcore  <tonyg@chromium.org>
2680
2681         Reviewed by David Levin.
2682
2683         Add Tony Gentilcore as a reviewer
2684         https://bugs.webkit.org/show_bug.cgi?id=52480
2685
2686         * Scripts/webkitpy/common/config/committers.py:
2687
2688 2011-01-14  David Levin  <levin@chromium.org>
2689
2690         Reviewed by Eric Seidel.
2691
2692         check-webkit-style: _FunctionState should keep track of where the function name starts.
2693         https://bugs.webkit.org/show_bug.cgi?id=52454
2694
2695         * Scripts/webkitpy/style/checkers/cpp.py: Added function_name_start_position to
2696         _FunctionState and logic for setting it correctly.
2697         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests.
2698
2699 2011-01-14  Vincent Scheib  <scheib@chromium.org>
2700
2701         Reviewed by David Levin.
2702
2703         Add support to DumpRenderTree to use the GPU rather than software renderer
2704         https://bugs.webkit.org/show_bug.cgi?id=52333
2705
2706         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2707         (main):
2708         * Scripts/webkitpy/layout_tests/port/chromium.py:
2709         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2710
2711 2011-01-14  Tony Chang  <tony@chromium.org>
2712
2713         Reviewed by Kent Tamura.
2714
2715         [chromium] update fonts.conf to fix 6 linux tests in drt
2716         https://bugs.webkit.org/show_bug.cgi?id=52411
2717
2718         * DumpRenderTree/chromium/fonts.conf: Update to match the copy in
2719             chromium's src/webkit/tools/test_shell/resources/fonts.conf
2720
2721 2011-01-14  Eric Seidel  <eric@webkit.org>
2722
2723         Original patch from Peter Gal  <galpater@inf.u-szeged.hu>
2724
2725         Reviewed by Adam Barth.
2726
2727         Fix when running Tools/Scripts/check-webkit-style without arguments.
2728         https://bugs.webkit.org/show_bug.cgi?id=52261#c16
2729
2730         * Scripts/webkitpy/common/checkout/scm.py: Handle None for changed_files argument better in Git.create_patch method.
2731         * Scripts/webkitpy/common/checkout/scm_unittest.py:
2732
2733 2011-01-04  Jochen Eisinger  <jochen@chromium.org>
2734
2735         Reviewed by David Levin.
2736
2737         Store the tempdir object in a variable so it doesn't get deleted too early.
2738         https://bugs.webkit.org/show_bug.cgi?id=51875
2739
2740         * Scripts/update-webkit-auxiliary-libs:
2741         * Scripts/update-webkit-support-libs:
2742
2743 2011-01-14  Eric Seidel  <eric@webkit.org>
2744
2745         Unreviewed.  Make it work in python 2.5.
2746
2747         webkit-patch suggest-reviewers dies when ChangeLogs are missing
2748         https://bugs.webkit.org/show_bug.cgi?id=49158
2749
2750         * Scripts/webkitpy/common/checkout/api_unittest.py:
2751
2752 2011-01-14  Sheriff Bot  <webkit.review.bot@gmail.com>
2753
2754         Unreviewed, rolling out r75774.
2755         http://trac.webkit.org/changeset/75774
2756         https://bugs.webkit.org/show_bug.cgi?id=52431
2757
2758         gtk builds were broken (Requested by loislo2 on #webkit).
2759
2760         * Scripts/webkitpy/common/checkout/scm.py:
2761
2762 2011-01-14  David Levin  <levin@chromium.org>
2763
2764         Reviewed by Shinichiro Hamaji.
2765
2766         check-webkit-style: _FunctionState should detect pure functions.
2767         https://bugs.webkit.org/show_bug.cgi?id=52428
2768
2769         * Scripts/webkitpy/style/checkers/cpp.py: Added detection for if a function declaration
2770         is a pure virtual function.
2771         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests for verifying that pure
2772         virtual functions are correctly detected.
2773
2774 2011-01-13  Ilya Tikhonovsky  <loislo@chromium.org>
2775
2776         Reviewed by Yury Semikhatsky.
2777
2778         Just small fix for problem with check-webkit-style.
2779         It just didn't work for this patch.
2780         Old code can't concatenate a list of strings with None.
2781
2782         * Scripts/webkitpy/common/checkout/scm.py:
2783
2784 2011-01-13  David Levin  <levin@chromium.org>
2785
2786         Reviewed by Shinichiro Hamaji.
2787
2788         check-webkit-style: _FunctionState should use Position to know where items are.
2789         https://bugs.webkit.org/show_bug.cgi?id=52424
2790
2791         * Scripts/webkitpy/style/checkers/cpp.py:
2792         (_FunctionState.*): Changed _FunctionState to use Position instead of line numbers.
2793         (detect_functions): Changed to pass Position's to _FunctionState.begin and
2794         did some minor clean-up.
2795         (*): Other changes are simply about converting to use the Position's in_FunctionState
2796         instead of line numbers.
2797         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Changed the test code
2798         to verify the positions stored in _FunctionState.
2799
2800 2011-01-13  Eric Seidel  <eric@webkit.org>
2801
2802         Reviewed by David Levin.
2803
2804         webkit-patch suggest-reviewers dies when ChangeLogs are missing
2805         https://bugs.webkit.org/show_bug.cgi?id=49158
2806
2807         This is not the most elegant, but it is a very safe fix to this bug.
2808         One advantage of catching ScriptError like this instead of adding a
2809         new added_or_modified_files or fixing all changed_files callers
2810         to use a more specific change_files variant, is that we catch
2811         all kinds of ScriptErrors which might cause our (non-essential)
2812         suggest-reviewers code to fail out.  This should make passing
2813         --suggest-reviewers to webkit-patch upload much more robust
2814         and may even make it possible for us to make it default.
2815
2816         The root of the problem here is that SCM.changed_files includes
2817         deleted ChangeLog paths (from moves, etc) which then when we ask
2818         SVN/Git for the contents of the file at that revision, the command
2819         errors out and Executive.run_command raises a ScriptError.
2820
2821         In the future we might fix this differently by making all current
2822         callers of chagned_files use a more specific method for requesting
2823         what types of changes they're interested in (adds, modifies, deletes, etc.)
2824
2825         * Scripts/webkitpy/common/checkout/api.py:
2826         * Scripts/webkitpy/common/checkout/api_unittest.py:
2827
2828 2011-01-13  Dan Bernstein  <mitz@apple.com>
2829
2830         Reviewed by Alexey Proskuryakov.
2831
2832         <rdar://problem/8827065> REGRESSION (r71884): Cross-origin XHR fails if willSendRequest changes the URL
2833         https://bugs.webkit.org/show_bug.cgi?id=52419
2834
2835         Allow to further control the behavior of the willSendRequest delegate callback by making it
2836         set a different URL in the new request.
2837
2838         * DumpRenderTree/LayoutTestController.cpp:
2839         (addURLToRedirectCallback): Added.
2840         (LayoutTestController::staticFunctions): Added addURLToRedirect.
2841         (LayoutTestController::addURLToRedirect): Added. Adds the redirection to the map.
2842         (LayoutTestController::redirectionDestinationForURL): Added this getter.
2843         * DumpRenderTree/LayoutTestController.h:
2844         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2845         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]): Check
2846         if there is a redirection for the request’s URL, established by addURLToRedirect(), and if so,
2847         change the URL in the new request to the redirect destination.
2848
2849 2011-01-13  Eric Seidel  <eric@webkit.org>
2850
2851         Reviewed by Mihai Parparita.
2852
2853         webkit-patch suggest-reviewers fails due to invalid utf8 in ChangeLog files
2854         https://bugs.webkit.org/show_bug.cgi?id=52416
2855
2856         Example: webkit-patch suggest-reviewers -g ca3890fe74d94d85d6bfa48f9ea497b094d8e717 
2857         UnicodeDecodeError: 'utf8' codec can't decode bytes in position 536-538: invalid data
2858
2859         I also added FIXMEs about the changed_files returning deleted files problem
2860         which is causing the other most common exception for suggest-reviewers
2861         (and is probably breaking sheriff-bots blame detection).
2862
2863         * Scripts/webkitpy/common/checkout/api.py:
2864         * Scripts/webkitpy/common/checkout/api_unittest.py:
2865         * Scripts/webkitpy/common/checkout/scm.py:
2866
2867 2011-01-13  Eric Seidel  <eric@webkit.org>
2868
2869         Reviewed by Adam Barth.
2870
2871         results archives from commit-queue are too large to upload
2872         https://bugs.webkit.org/show_bug.cgi?id=52405
2873
2874         * Scripts/webkitpy/common/system/filesystem.py:
2875         * Scripts/webkitpy/common/system/filesystem_mock.py:
2876         * Scripts/webkitpy/tool/commands/queues.py:
2877
2878 2011-01-13  Alejandro G. Castro  <alex@igalia.com>
2879
2880         Reviewed by Martin Robinson.
2881
2882         [gtk] Zero-sized font does not yet work
2883         https://bugs.webkit.org/show_bug.cgi?id=49793
2884
2885         Set minimum-font-size to 0 for the DRT.
2886
2887         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2888         (resetDefaultsToConsistentValues):
2889
2890 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
2891
2892         Reviewed by Darin Adler.
2893
2894         Make old-run-webkit-tests more robust on buildbots
2895         https://bugs.webkit.org/show_bug.cgi?id=52364
2896
2897         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Pass --exit-after-n-failures 500 to old-run-webkit-tests script.
2898
2899 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
2900
2901         Reviewed by Darin Adler.
2902
2903         Make old-run-webkit-tests more robust on buildbots
2904         https://bugs.webkit.org/show_bug.cgi?id=52364
2905
2906         * Scripts/old-run-webkit-tests: Ensure that testResultsDirectory is empty.
2907
2908 2011-01-13  Tony Chang  <tony@chromium.org>
2909
2910         Reviewed by Kent Tamura.
2911
2912         [chromium] fix plugins/plugin-javascript-access.html on Linux and Mac
2913         https://bugs.webkit.org/show_bug.cgi?id=52332
2914
2915         Forked Info.plist is not longer needed.
2916
2917         * DumpRenderTree/chromium/TestNetscapePlugIn/Info.plist: Removed.
2918
2919 2011-01-13  Mikhail Naganov  <mnaganov@chromium.org>
2920
2921         Reviewed by Timothy Hatcher.
2922
2923         Web Inspector: Cleanup after r75613 -- make all UI-facing strings
2924         to be passed directly to WebInspector.UIString
2925
2926         https://bugs.webkit.org/show_bug.cgi?id=52365
2927
2928         * Scripts/check-inspector-strings:
2929
2930 2011-01-13  Sheriff Bot  <webkit.review.bot@gmail.com>
2931
2932         Unreviewed, rolling out r74881.
2933         http://trac.webkit.org/changeset/74881
2934         https://bugs.webkit.org/show_bug.cgi?id=52357
2935
2936         The EFL builder has been red for days (Requested by abarth on
2937         #webkit).
2938
2939         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2940         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2941
2942 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
2943
2944         Reviewed by David Levin.
2945
2946         Add beforeunload support to WebKitTestRunner
2947         https://bugs.webkit.org/show_bug.cgi?id=52353
2948         
2949         This makes a number of currently failing tests pass.
2950
2951         * WebKitTestRunner/TestController.cpp:
2952         (WTR::runBeforeUnloadConfirmPanel):
2953         (WTR::createOtherPage):
2954         (WTR::TestController::initialize):
2955
2956 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
2957
2958         Reviewed by Sam Weinig.
2959
2960         Detect, identify and recover from WebProcess crashes in run-webkit-tests
2961         https://bugs.webkit.org/show_bug.cgi?id=52330
2962
2963         * Scripts/old-run-webkit-tests: Detect when the regression test tool reports
2964         a web process crash.
2965         * WebKitTestRunner/TestController.cpp:
2966         (WTR::TestController::initialize): Set up a processDidCrash
2967         callback.
2968         (WTR::TestController::processDidCrash): Report that the Web process
2969         crashed.
2970         * WebKitTestRunner/TestController.h:
2971
2972 2011-01-12  David Levin  <levin@chromium.org>
2973
2974         Reviewed by Shinichiro Hamaji.
2975
2976         check-webkit-style -- close_expression function doesn't work correctly.
2977         https://bugs.webkit.org/show_bug.cgi?id=52272
2978
2979         * Scripts/webkitpy/style/checkers/cpp.py:
2980         (Position.__str__): Added a way to convert it to a string which is useful in tests.
2981         (Position.__cmp__): Added a way to compare Position which is useful in tests and
2982         generally useful (for upcoming code changes).
2983         (close_expression): Changed to use Position for input and output.
2984         Also, fixed many bugs such as only working correctly for parenthesis,
2985         not working correctly if given an offset in a line and not finding
2986         the real closing element if there were multiple closing elements in
2987         the same line.
2988         (detect_functions): Adjusted due to the change in arguments for
2989         close_expression.
2990         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2991         (CppStyleTestBase.assert_positions_equal): Added a way to verify that
2992         two positions are the same.
2993         (CppStyleTest.test_position): Added tests for the __str_ and __cmp__ methods.
2994         (CppStyleTest.test_close_expression): Added tests to catch the issues
2995         that were fixed.
2996
2997 2011-01-12  Sheriff Bot  <webkit.review.bot@gmail.com>
2998
2999         Unreviewed, rolling out r75576.
3000         http://trac.webkit.org/changeset/75576
3001         https://bugs.webkit.org/show_bug.cgi?id=52304
3002
3003         broke rebaseline-chromium-webkit-test (Requested by thakis on
3004         #webkit).
3005
3006         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
3007         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
3008         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
3009         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
3010         * Scripts/webkitpy/layout_tests/port/base.py:
3011         * Scripts/webkitpy/layout_tests/port/chromium.py:
3012         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3013         * Scripts/webkitpy/layout_tests/port/test.py:
3014         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
3015         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3016         * Scripts/webkitpy/style/checkers/test_expectations.py:
3017         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
3018
3019 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
3020
3021         Reviewed by Darin Adler.
3022
3023         Add a no-build option to run-webkit-tests, to avoid building DRT/WKTR
3024         https://bugs.webkit.org/show_bug.cgi?id=52307
3025
3026         * Scripts/old-run-webkit-tests:
3027
3028 2011-01-12  Koan-Sin Tan  <koansin.tan@gmail.com>
3029
3030         Reviewed by Martin Robinson.
3031
3032         [Gtk] WebKitGtk+ doesn't build on Mac OS X 10.6
3033         https://bugs.webkit.org/show_bug.cgi?id=50867
3034
3035         Fixed library extention for Mac in webkitdirs.pm and type conflict in
3036         TestNetscapePlugin.cpp 
3037
3038         * GNUmakefile.am: Don't use AppKit when compiling TestNetscapePlugin for GTK+
3039         * Scripts/webkitdirs.pm:
3040
3041 2011-01-12  Mikhail Naganov  <mnaganov@chromium.org>
3042
3043         Reviewed by Pavel Feldman.
3044
3045         Add check-inspector-strings script.
3046
3047         https://bugs.webkit.org/show_bug.cgi?id=52295
3048
3049         * Scripts/check-inspector-strings: Added.
3050
3051 2011-01-12  Adam Roben  <aroben@apple.com>
3052
3053         Advertise the .testnetscape file extension on Windows
3054
3055         Fixes <http://webkit.org/b/52298>
3056         plugins/no-mime-with-valid-extension.html fails on Windows
3057
3058         Reviewed by Dan Bernstein.
3059
3060         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Added a
3061         FileExtents field to map the .testnetscape file extension to the
3062         application/x-webkit-test-netscape MIME type, just as we do on Mac.
3063
3064 2011-01-12  Adam Barth  <abarth@webkit.org>
3065
3066         Reviewed by Eric Seidel.
3067
3068         Make webkit-patch support subdirectories for SVN checkouts
3069         https://bugs.webkit.org/show_bug.cgi?id=52261
3070
3071         os.relpath does not exist on Python 2.5, so we need to call our version
3072         of the API.
3073
3074         * Scripts/webkitpy/common/checkout/scm.py:
3075
3076 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
3077
3078         Reviewed by Eric Seidel.
3079
3080         Close additional pages opened during a test once the test completes.
3081         https://bugs.webkit.org/show_bug.cgi?id=52276
3082
3083         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3084         (WTR::InjectedBundle::done):
3085
3086 2011-01-11  David Levin  <levin@chromium.org>
3087
3088         Reviewed by Eric Seidel.
3089
3090         Errors should be separated from the command line in bot messages.
3091         https://bugs.webkit.org/show_bug.cgi?id=52275
3092
3093         * Scripts/webkitpy/common/system/executive.py:
3094         (ScriptError.message_with_output): Added a newline to separate the command
3095         line from the errors.
3096         * Scripts/webkitpy/common/system/executive_unittest.py:
3097         (ScriptErrorTest.test_message_with_output): Added tests for the various code
3098         paths in message_with_output.
3099
3100 2011-01-11  Eric Seidel  <eric@webkit.org>
3101
3102         Unreviewed.
3103
3104         commit-queue should know how to upload archived results (for test flakes or general failures)
3105         https://bugs.webkit.org/show_bug.cgi?id=52048
3106
3107         The zips are mostly empty due to forgetting -r.
3108         Expected diffs were not being pulled from the archive due
3109         to the archive having longer paths than I realized.
3110
3111         * Scripts/webkitpy/common/system/workspace.py:
3112         * Scripts/webkitpy/common/system/workspace_unittest.py:
3113         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3114         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3115
3116 2011-01-11  Dirk Pranke  <dpranke@chromium.org>
3117
3118         Reviewed by Ojan Vafai.
3119
3120         The current modifier parsing code in test_expectations is
3121         fragile and hard-coded, so it's not easy to understand the logic
3122         or easily add new types of modifiers (like GPU vs. CPU testing
3123         for graphics tests, or 32-bit vs. 64-bit differences).
3124
3125         This is the first of two patches that will add in more generic
3126         support and then eliminate the GPU-specific test expectations
3127         files for Chromium.
3128
3129         This patch adds two standalone objects for handling modifiers. The
3130         rules for interpreting modifiers, precedence, and conflicts are
3131         given in the docstring to the ModifierMatcher class, which
3132         returns ModifierMatchResult objects.
3133         
3134         This patch also adds routines to the Port interface and a
3135         default set of values in the base object, in order to obtain the
3136         values needed on a given test run. These values are then passed
3137         to the expectation parser. This also allows us to clean up the
3138         logic used to lint all of the different configurations in a
3139         single test_expectations.txt file.
3140
3141         The next patch will merge in the separate GPU expectations file.
3142
3143         https://bugs.webkit.org/show_bug.cgi?id=51222
3144
3145         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
3146         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
3147         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
3148         * Scripts/webkitpy/layout_tests/port/base.py:
3149         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3150         * Scripts/webkitpy/layout_tests/port/chromium.py:
3151         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3152         * Scripts/webkitpy/layout_tests/port/test.py:
3153         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3154         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3155
3156 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
3157
3158         Reviewed by Adam Barth.
3159
3160         Make webkit-patch support subdirectories for SVN checkouts
3161         https://bugs.webkit.org/show_bug.cgi?id=52261
3162
3163         * Scripts/webkitpy/common/checkout/scm.py:
3164         * Scripts/webkitpy/style_references.py:
3165         * Scripts/webkitpy/tool/main.py:
3166         * Scripts/webkitpy/tool/steps/preparechangelog.py:
3167
3168 2011-01-11  Eric Seidel  <eric@webkit.org>
3169
3170         Unreviewed.
3171
3172         commit-queue should know how to upload archived results (for test flakes or general failures)
3173         https://bugs.webkit.org/show_bug.cgi?id=52048
3174
3175         I changed the API for archive_last_layout_test_results w/o updating the implementation.  Oops.
3176         This fixes an exception seen on the commit-queue when attempting to report flaky tests.
3177
3178         * Scripts/webkitpy/common/system/workspace.py:
3179         * Scripts/webkitpy/common/system/workspace_unittest.py:
3180         * Scripts/webkitpy/tool/commands/queues.py:
3181
3182 2011-01-11  Sam Weinig  <sam@webkit.org>
3183
3184         Roll r75474 back in.
3185
3186 2011-01-11  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
3187
3188         Reviewed by Kenneth Rohde Christiansen.
3189
3190         [Qt] Remove uses of QFuture since it isn't supported on all platforms.
3191         https://bugs.webkit.org/show_bug.cgi?id=51204
3192
3193         * QtTestBrowser/webpage.h:
3194         (QtNAMThread::QtNAMThread):
3195         (QtNAMThread::networkAccessManager):
3196         (QtNAMThread::run):
3197
3198 2011-01-11  Peter Varga  <pvarga@webkit.org>
3199
3200         Unreviewed.
3201
3202         Add myself to committers' list.
3203
3204         * Scripts/webkitpy/common/config/committers.py:
3205
3206 2011-01-11  Eric Seidel  <eric@webkit.org>
3207
3208         Reviewed by Adam Barth.
3209
3210         commit-queue should know how to upload archived results (for test flakes or general failures)
3211         https://bugs.webkit.org/show_bug.cgi?id=52048
3212
3213         Now the queue will always upload results.  Either the entire zip, or just
3214         the diffs.txt in the case of text failures.
3215
3216         This should make understanding flakes much easier, and paves the way
3217         for having the EWS run layout tests (and upload failures).
3218
3219         In order to upload .zip files I had to teach bugzilla.py to autodetect
3220         mime types from the filename.  Since mimetypes.py doesn't include a mapping
3221         for .patch files, I have it add one before calling guess_type.
3222
3223         We may find that always uploading the whole zip instead of just the -diffs.txt
3224         file is preferable, but for now I'm keeping the old behavior because it makes
3225         quickly understanding text failures easy.
3226
3227         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3228         * Scripts/webkitpy/common/system/workspace.py: Added.
3229         * Scripts/webkitpy/common/system/workspace_unittest.py: Added.
3230         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3231         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3232         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3233         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3234         * Scripts/webkitpy/tool/commands/queues.py:
3235         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3236
3237 2011-01-10  Sheriff Bot  <webkit.review.bot@gmail.com>
3238
3239         Unreviewed, rolling out r75464.
3240         http://trac.webkit.org/changeset/75464
3241         https://bugs.webkit.org/show_bug.cgi?id=52193
3242
3243         Followup rollout for 75474 (Requested by Ossy on #webkit).
3244
3245         * MiniBrowser/mac/BrowserWindowController.m:
3246         (-[BrowserWindowController awakeFromNib]):
3247         * MiniBrowser/win/BrowserView.cpp:
3248         (BrowserView::create):
3249         * WebKitTestRunner/TestController.cpp:
3250         (WTR::createOtherPage):
3251         (WTR::TestController::initialize):
3252
3253 2011-01-10  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3254
3255         Reviewed by Csaba Osztrogonác.
3256
3257         [Qt] Baseline qt_minimal configuration
3258         https://bugs.webkit.org/show_bug.cgi?id=51313
3259
3260         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3261         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): Add
3262         QT_NO_UNDOSTACK guard.
3263
3264         * QtTestBrowser/launcherwindow.cpp:
3265         (LauncherWindow::createChrome): Add QT_NO_SHORTCUT and QT_NO_PRINTER
3266         guards.
3267         (LauncherWindow::applyZoom): Add QT_NO_ANIMATION guard.
3268         (LauncherWindow::screenshot): Add QT_NO_FILEDIALOG guard.
3269         (LauncherWindow::selectElements): Add QT_NO_INPUTDIALOG guard.
3270         (LauncherWindow::showUserAgentDialog): Add QT_NO_COMBOBOX guard.
3271
3272         * QtTestBrowser/launcherwindow.h:
3273         * QtTestBrowser/locationedit.cpp: Add QT_NO_INPUTDIALOG guard.
3274         * QtTestBrowser/locationedit.h: Ditto.
3275
3276         * QtTestBrowser/mainwindow.cpp:
3277         (MainWindow::buildUI): Add QT_NO_INPUTDIALOG, QT_NO_SHORTCUT and
3278         QT_NO_UNDOSTACK guards.
3279         (MainWindow::setAddressUrl): Add QT_NO_INPUTDIALOG guard.
3280         (MainWindow::changeLocation): Ditto.
3281         (MainWindow::openFile): Add QT_NO_FILEDIALOG guard.
3282         (MainWindow::openLocation): Add QT_NO_INPUTDIALOG guard.
3283
3284         * QtTestBrowser/webpage.cpp:
3285         (WebPage::openUrlInDefaultBrowser): Add QT_NO_DESKTOPSERVICES guard.
3286         (WebPage::authenticationRequired): Add QT_NO_LINEEDIT guard.
3287
3288         * QtTestBrowser/webview.cpp:
3289         (WebViewGraphicsBased::animatedFlip): Add QT_NO_ANIMATION guard.
3290         (WebViewGraphicsBased::animatedYFlip): Ditto.
3291
3292 2011-01-10  Sam Weinig  <sam@webkit.org>
3293
3294         Fix build.
3295
3296         * MiniBrowser/mac/BrowserWindowController.m:
3297         (-[BrowserWindowController awakeFromNib]):
3298         * MiniBrowser/win/BrowserView.cpp:
3299         (BrowserView::create):
3300         * WebKitTestRunner/TestController.cpp:
3301         (WTR::createOtherPage):
3302         (WTR::TestController::initialize):
3303
3304 2011-01-10  Eric Seidel  <eric@webkit.org>
3305
3306         Reviewed by Ojan Vafai.
3307
3308         style-queue messages are way too long for big patches
3309         https://bugs.webkit.org/show_bug.cgi?id=52161
3310
3311         We definitely could build much fancier list-to-string-with-limit functions
3312         but this should be sufficient for our needs at the moment.
3313
3314         * Scripts/webkitpy/common/system/executive.py:
3315         * Scripts/webkitpy/common/system/executive_unittest.py:
3316
3317 2011-01-10  Tony Chang  <tony@chromium.org>
3318
3319         Unreviewed, rolling out r75398.
3320         http://trac.webkit.org/changeset/75398
3321         https://bugs.webkit.org/show_bug.cgi?id=52008
3322
3323         Some layout tests are crashing on Chromium Win.
3324
3325         * DumpRenderTree/chromium/WebViewHost.cpp:
3326         (WebViewHost::updatePaintRect):
3327         * DumpRenderTree/chromium/WebViewHost.h:
3328
3329 2011-01-10  Adam Roben  <aroben@apple.com>
3330
3331         Roll out r75392
3332
3333         It isn't needed now that r75289 has been rolled out.
3334
3335         * Scripts/run-javascriptcore-tests:
3336
3337 2011-01-10  Maciej Stachowiak  <mjs@apple.com>
3338
3339         Reviewed by Anders Carlsson.
3340
3341         WebKitTestRunner uses crazy amounts of CPU, making layout tests slow and flaky
3342         https://bugs.webkit.org/show_bug.cgi?id=52160
3343
3344         * WebKitTestRunner/mac/TestControllerMac.mm:
3345         (WTR::TestController::platformRunUntil): Instead of busy-looping, wait for the timeout.
3346         Anything that can make runUntil() conditions turn true will happen on a run loop cycle
3347         anyway.
3348
3349 2011-01-10  Tony Chang  <tony@chromium.org>
3350
3351         Reviewed by Mihai Parparita.
3352
3353         [chromium] fix for animated gif layout tests
3354         https://bugs.webkit.org/show_bug.cgi?id=52008
3355
3356         * DumpRenderTree/chromium/WebViewHost.cpp: Schedule a paint when we update the paint rect
3357             to trigger gif animations.
3358         (WebViewHostPaintTask::WebViewHostPaintTask):
3359         (WebViewHostPaintTask::runIfValid):
3360         (WebViewHost::updatePaintRect):
3361         * DumpRenderTree/chromium/WebViewHost.h:
3362         (WebViewHost::taskList):
3363
3364 2011-01-10  Alejandro G. Castro  <alex@igalia.com>
3365
3366         Reviewed by Xan Lopez.
3367
3368         [GTK] Fix gtk2 compilation for master
3369         https://bugs.webkit.org/show_bug.cgi?id=51885
3370
3371         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
3372         (createBitmapContextFromWebView): Replaced the old
3373         gdk_drawable_get_size with gdk_pixmap_get_size.
3374
3375 2011-01-10  Patrick Gansterer  <paroga@webkit.org>
3376
3377         Reviewed by Laszlo Gombos.
3378
3379         [WINCE] Reenable NPAPI after r75203
3380         https://bugs.webkit.org/show_bug.cgi?id=52109
3381
3382         Remove the !isWinCE() check for ENABLE_NETSCAPE_PLUGIN_API and replace
3383         it with !isEfl(), because EFL port does not support NPAPI (yet).
3384
3385         * Scripts/build-webkit:
3386
3387 2011-01-10  Adam Roben  <aroben@apple.com>
3388
3389         Skip some asserting JS tests
3390
3391         See <http://webkit.org/b/52156>.
3392
3393         * Scripts/run-javascriptcore-tests:
3394
3395 2011-01-10  Martin Robinson  <mrobinson@igalia.com>
3396
3397         Reviewed by Xan Lopez.
3398
3399         [GTK] build-webkit disable Blob support via arguments passed to automake
3400         https://bugs.webkit.org/show_bug.cgi?id=52097
3401
3402         * Scripts/build-webkit: Enable Blob support when building WebKitGTK+ via
3403         build-webkit.
3404
3405 2011-01-10  Adam Roben  <aroben@apple.com>
3406
3407         Use the same name and description for TestNetscapePlugin on Windows and
3408         Mac
3409
3410         Fixes <http://webkit.org/b/52151>
3411         fast/frames/iframe-reparenting-plugins.html fails on Windows
3412
3413         Reviewed by Steve Falkenburg.
3414
3415         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Copied
3416         the name and description from Mac's Info.plist.
3417
3418 2011-01-10  Siddharth Mathur <siddharth.mathur@nokia.com>
3419
3420         Reviewed by Laszlo Gombos.
3421
3422         [Qt][WK2] Guard gcc-specific syntax
3423
3424         Non-gcc based compliers choke on the "-include"
3425         syntax for preinclude, place guard around it.
3426
3427         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3428         * WebKitTestRunner/qt/WebKitTestRunner.pro:
3429
3430 2011-01-10  Andreas Kling  <kling@webkit.org>
3431
3432         Reviewed by Simon Hausmann.
3433
3434         [Qt] [WK2] MiniBrowser does not load pages opened in new windows
3435         https://bugs.webkit.org/show_bug.cgi?id=52111
3436
3437         When getting a createNewPage() callback from QWKPage, create the
3438         new page with the same QWKContext as the page that is passed to
3439         the callback.
3440
3441         * MiniBrowser/qt/BrowserView.h:
3442         * MiniBrowser/qt/BrowserWindow.cpp:
3443         (newPageFunction):
3444         (BrowserWindow::BrowserWindow):
3445         * MiniBrowser/qt/BrowserWindow.h:
3446
3447 2011-01-10  Andreas Kling  <kling@webkit.org>
3448
3449         Reviewed by Kenneth Rohde Christiansen.
3450
3451         [Qt] MiniBrowser: Remove superfluous createNewPage() callback
3452
3453         BrowserView set its own useless createNewPage() callback on QWKPage.
3454         This was immediately overridden by BrowserWindow anyway, so remove
3455         the BrowserView one.
3456
3457         * MiniBrowser/qt/BrowserView.cpp:
3458         (BrowserView::BrowserView):
3459
3460 2011-01-10  John Knottenbelt  <jknotten@chromium.org>
3461
3462         Reviewed by Jeremy Orlow.
3463
3464         [Chromium] Remove non-client-based Geolocation code
3465         https://bugs.webkit.org/show_bug.cgi?id=50921
3466
3467         * DumpRenderTree/chromium/LayoutTestController.cpp:
3468         (LayoutTestController::setGeolocationPermission):
3469         (LayoutTestController::setMockGeolocationPosition):
3470         (LayoutTestController::setMockGeolocationError):
3471         * DumpRenderTree/chromium/WebViewHost.cpp:
3472         (WebViewHost::geolocationClientMock):
3473         (WebViewHost::reset):
3474         * DumpRenderTree/chromium/WebViewHost.h:
3475
3476 2011-01-10  Eric Seidel  <eric@webkit.org>
3477
3478         Reviewed by Adam Barth.
3479
3480         Commit bot tried to land r? cq+ patch
3481         https://bugs.webkit.org/show_bug.cgi?id=36638
3482
3483         It should now be possible to post a patch with r? and cq+ and the
3484         commit-queue will correctly wait for the r+ before attempting to land the patch.
3485         (This was a feature requested by several users.)
3486
3487         One caveat: We don't actually reject r-, cq+ patches from the queue
3488         (we just ignore them), but I think that's OK for now.
3489
3490         I also noticed that setting r- once a commit-queue node had grabbed
3491         a patch would not properly cancel the landing.  That's fixed and
3492         tested in this patch.
3493
3494         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3495         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3496         * Scripts/webkitpy/tool/bot/feeders.py:
3497         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
3498
3499 2011-01-08  Benjamin Poulain  <benjamin.poulain@nokia.com>
3500
3501         Reviewed by Kenneth Rohde Christiansen.
3502
3503         [Qt] QtWebKit crashes when using XMLHttpRequest from the unload event
3504         https://bugs.webkit.org/show_bug.cgi?id=51934
3505
3506         When accessing the network from the destructor of QWebPage, the network access manager
3507         was already deleted because the object WebPage was already destructed.
3508
3509         This solve the problem by linking the lifetime of the network access manager to WebPage's QObject.
3510         The object is now destructed in the destructor of QObject.
3511
3512         * QtTestBrowser/webpage.cpp:
3513         (WebPage::WebPage):
3514         (WebPage::setQnamThreaded):
3515         * QtTestBrowser/webpage.h:
3516         (QtNAMThread::QtNAMThread):
3517
3518 2011-01-08  Eric Seidel  <eric@webkit.org>
3519
3520         Reviewed by Ojan Vafai.
3521
3522         test_failures.py should not mention TestShell (long live DumpRenderTree!)
3523         https://bugs.webkit.org/show_bug.cgi?id=52067
3524
3525         I ran test-webkitpy, but didn't bother adding a unit test for this string change.
3526         https://bugs.webkit.org/show_bug.cgi?id=51138#c3 is an example of why this is needed.
3527
3528         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
3529
3530 2011-01-08  Eric Seidel  <eric@webkit.org>
3531
3532         Reviewed by Mihai Parparita.
3533
3534         commit-queue hangs when the ChangeLog diff is bad
3535         https://bugs.webkit.org/show_bug.cgi?id=52072
3536
3537         * Scripts/webkitpy/tool/steps/validatechangelogs.py:
3538         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
3539
3540 2011-01-08  Adam Barth  <abarth@webkit.org>
3541
3542         Teach svn-apply how to re-write WebCore to Source/WebCore.
3543
3544         * Scripts/VCSUtils.pm:
3545
3546 2011-01-07  Adam Barth  <abarth@webkit.org>
3547
3548         Rubber-stamped by Eric Seidel.
3549
3550         Move WebCore to Source
3551         https://bugs.webkit.org/show_bug.cgi?id=52050
3552
3553         Update the tools to understand WebCore's new location.
3554
3555         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3556         * DumpRenderTree/wscript:
3557         * GNUmakefile.am:
3558         * Scripts/build-webkit:
3559         * Scripts/do-file-rename:
3560         * Scripts/do-webcore-rename:
3561         * Scripts/generate-qt-inspector-resource:
3562         * Scripts/prepare-ChangeLog:
3563         * Scripts/run-bindings-tests:
3564         * Scripts/update-iexploder-cssproperties:
3565         * Scripts/update-sources-list.py:
3566         * Scripts/update-webkit-localizable-strings:
3567         * Scripts/webkitdirs.pm:
3568         * Scripts/webkitpy/common/config/build.py:
3569         * Scripts/webkitpy/common/config/build_unittest.py:
3570         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
3571         * Scripts/webkitpy/style/checker.py:
3572         * Scripts/webkitpy/style/checker_unittest.py:
3573         * WebKitTestRunner/DerivedSources.pro:
3574         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3575         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh:
3576         * wx/browser/wscript:
3577         * wx/build/settings.py:
3578
3579 2011-01-07  Maciej Stachowiak  <mjs@apple.com>
3580
3581         Reviewed by Sam Weinig.
3582
3583         Make WebKitTestRunner rest between loads more robust to avoid test crashes
3584         https://bugs.webkit.org/show_bug.cgi?id=52086
3585
3586         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3587         (WTR::InjectedBundle::didReceiveMessage):
3588         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3589         (WTR::LayoutTestController::notifyDone):
3590         * WebKitTestRunner/TestController.cpp:
3591         (WTR::TestController::resetStateToConsistentValues):
3592         (WTR::TestController::run):
3593
3594 2011-01-07  James Robinson  <jamesr@chromium.org>
3595
3596         Revert "Implement mozilla's animationTime property"
3597         https://bugs.webkit.org/show_bug.cgi?id=51952
3598
3599         This approach isn't quite right.
3600
3601         * DumpRenderTree/chromium/WebViewHost.cpp:
3602         (WebViewHost::paintInvalidatedRegion):
3603
3604 2011-01-07  Adam Roben  <aroben@apple.com>
3605
3606         Build master fix
3607
3608         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3609         (RunWebKitTests.start): Don't try to concatenate a list and a string.
3610
3611 2011-01-07  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>
3612
3613         Reviewed by Csaba Osztrogonác.
3614
3615         run-qtwebkit-tests should be able to kill a testsuite.
3616
3617         Add new option in the script that can setup a timeout for a test.
3618         If the test execution takes more then specified time then the test
3619         would be terminated.
3620
3621         [Qt] run-qtwebkit-tests needs timeout
3622         https://bugs.webkit.org/show_bug.cgi?id=51894
3623
3624         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3625         * Scripts/run-qtwebkit-tests:
3626
3627 2011-01-07  Csaba Osztrogonác  <ossy@webkit.org>
3628
3629         Unreviewed fix after r75233.
3630
3631         Based on idea from Eric Seidel.
3632
3633         Add remote zip file handling to webkitpy.
3634         https://bugs.webkit.org/show_bug.cgi?id=50901
3635
3636         * Scripts/webkitpy/common/system/fileset.py: Make python 2.5 happy.
3637
3638 2011-01-07  Shane Stephens  <shanestephens@google.com>
3639
3640         Reviewed by Eric Seidel.
3641
3642         svn-apply: should support git binary delta diffs
3643         https://bugs.webkit.org/show_bug.cgi?id=38864
3644
3645         * Scripts/VCSUtils.pm:
3646         * Scripts/svn-apply:
3647
3648 2011-01-06  Julie Parent  <jparent@chromium.org>
3649
3650         Reviewed by Eric Seidel.
3651
3652         Test Result Server not removing old results.
3653         https://bugs.webkit.org/show_bug.cgi?id=52012
3654
3655         * TestResultServer/model/jsonresults.py:
3656         Fix off-by-one: Truncate if >= num_runs, not just >.
3657         * TestResultServer/model/jsonresults_unittest.py:
3658         Add unit test to test that merging in a new result with the same value
3659         as the last result causes previous result to fall off.
3660
3661 2011-01-06  James Kozianski  <koz@chromium.org>
3662
3663         Reviewed by Mihai Parparita.
3664
3665         Add classes to provide a consistent interface to a set of files.
3666         https://bugs.webkit.org/show_bug.cgi?id=50901
3667
3668         These classes allow us to write code that is agnostic to whether a
3669         particular set of files resides in a local directory or in a zip file
3670         on a remote machine.
3671
3672         * Scripts/webkitpy/common/system/directoryfileset.py: Added.
3673         * Scripts/webkitpy/common/system/directoryfileset_unittest.py: Added.
3674         * Scripts/webkitpy/common/system/fileset.py: Added.
3675         * Scripts/webkitpy/common/system/filesystem.py:
3676         * Scripts/webkitpy/common/system/filesystem_mock.py:
3677         * Scripts/webkitpy/common/system/zipfileset.py: Added.
3678         * Scripts/webkitpy/common/system/zipfileset_unittest.py: Added.
3679
3680 2011-01-06  Eric Seidel  <eric@webkit.org>
3681
3682         Reviewed by Adam Barth.
3683
3684         NetworkTransaction should log the url it is retrying
3685         https://bugs.webkit.org/show_bug.cgi?id=52043
3686
3687         * Scripts/webkitpy/common/net/networktransaction.py:
3688         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
3689
3690 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
3691
3692         Windows build fix.
3693         Import os before using it.
3694
3695         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3696
3697 2011-01-06  Eric Seidel  <eric@webkit.org>
3698
3699         Reviewed by Adam Barth.
3700
3701         StyleQueue fails to report errors when patches have many files
3702         https://bugs.webkit.org/show_bug.cgi?id=52042
3703
3704         This is one of at least two errors preventing style error reporting at the moment.
3705         When we moved to passing the list of files to check explicitly,
3706         we started to exceed the 500 character TEXT field limit for our AppEngine model object.
3707         We could change the type of the QueueStatus.message type, or we could
3708         just teach statusserver.py how to clamp values (and warn when it does).
3709         I chose the latter path.
3710
3711         * Scripts/webkitpy/common/net/statusserver.py:
3712
3713 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
3714
3715         Reviewed by Stephanie Lewis.
3716         
3717         Fix syntax error in script.
3718
3719         Windows bots need to archive/unarchive builds to/from configuration-specific directories
3720         https://bugs.webkit.org/show_bug.cgi?id=51996
3721
3722         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3723
3724 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3725
3726         Unreviewed, fixing WinCE build after r75196.
3727
3728         WinCE port does not (yet) support NPAPI.
3729
3730         * Scripts/build-webkit:
3731
3732 2011-01-06  Xan Lopez  <xlopez@igalia.com>
3733
3734         Reviewed by Darin Adler.
3735
3736         File::Spec->rel2abs in sunspider-compare-results mangles parameters
3737         https://bugs.webkit.org/show_bug.cgi?id=52015
3738
3739         * Scripts/sunspider-compare-results: call rel2abs on our arguments
3740         after the platform has been detected, otherwise the script will
3741         mangle things like '--gtk' into '/a/path/--gtk', breaking the
3742         detection.
3743
3744 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3745
3746         Reviewed by Eric Seidel.
3747
3748         Add ENABLE_NETSCAPE_PLUGIN_API, ENABLE_ORIENTATION_EVENTS and ENABLE_TOUCH_EVENTS flags to build-webkit
3749         https://bugs.webkit.org/show_bug.cgi?id=51346
3750
3751         * Scripts/build-webkit:
3752
3753 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
3754
3755         Reviewed by Adam Roben.
3756
3757         Windows bots need to archive/unarchive builds to/from configuration-specific directories
3758         https://bugs.webkit.org/show_bug.cgi?id=51996
3759         
3760         After the configuration directory change, we were archiving the incorrect directory for
3761         build product, so we were running tests on the wrong binaries.
3762         
3763         This change archives the correct directory, and also unarchives it into a configuration-
3764         specific directory.
3765
3766         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Use a configuration-specific directory on Windows.
3767         * BuildSlaveSupport/built-product-archive: Unarchive/archive to/from proper directory.
3768
3769 2011-01-06  Eric Seidel  <eric@webkit.org>
3770
3771         Reviewed by Mihai Parparita.
3772
3773         commit-queue mentions "Text diff mismatch" 4 times instead of once per failure
3774         https://bugs.webkit.org/show_bug.cgi?id=52002
3775
3776         See an example of this here:
3777         https://bugs.webkit.org/show_bug.cgi?id=51314#c2
3778
3779         It's due to the fact that we pass around TestFailure() instance
3780         objects and yet expect them to all compare to be the same.
3781
3782         This is bad.  We should either have shared instances of these values
3783         or we should just pass around the class names.  There are already hacks
3784         in place to make TestFailure objects pass equality tests, I just added
3785         a __hash__ implementation so they can be used in sets as expected.
3786
3787         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3788         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
3789
3790 2011-01-06  Evan Martin  <evan@chromium.org>
3791
3792         Reviewed by Tony Chang.
3793
3794         [gdb] handle inaccessible memory and UChar*
3795         https://bugs.webkit.org/show_bug.cgi?id=52003
3796