Tools/ChangeLog

   1 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
   2
   3         Unreviewed, build fix.
   4
   5         Fix a couple of minor bugs discovered while bringing up new bots
   6         for testing.
   7
   8         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
   9         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  10
  11 2011-01-19  James Robinson  <jamesr@chromium.org>
  12
  13         Unreviewed, rolling out r76194.
  14         http://trac.webkit.org/changeset/76194
  15         https://bugs.webkit.org/show_bug.cgi?id=51218
  16
  17         Caused mysterious compile failure on the chromium win
  18         build.webkit.org bots
  19
  20         * DumpRenderTree/chromium/WebViewHost.cpp:
  21         (WebViewHost::paintInvalidatedRegion):
  22         * DumpRenderTree/chromium/WebViewHost.h:
  23
  24 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
  25
  26         Reviewed by Mihai Parparita.
  27
  28         remove fs refs from test_runner, dump_render_tree_thread
  29
  30         https://bugs.webkit.org/show_bug.cgi?id=52753
  31
  32         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
  33         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
  34         * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
  35         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
  36
  37 2011-01-19  James Robinson  <jamesr@chromium.org>
  38
  39         Reviewed by Darin Fisher.
  40
  41         Implement mozilla's requestAnimationFrame API
  42         https://bugs.webkit.org/show_bug.cgi?id=51218
  43
  44         Chromium DumpRenderTree support for window.webkitRequestAnimationFrame.
  45
  46         * DumpRenderTree/chromium/WebViewHost.cpp:
  47         (invokeScheduleComposite):
  48         (WebViewHost::scheduleAnimation):
  49         (WebViewHost::paintInvalidatedRegion):
  50         * DumpRenderTree/chromium/WebViewHost.h:
  51
  52 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
  53
  54         Unreviewed, build fix.
  55
  56         Fix a few incorrect "self._filesystem" references introduced in
  57         r76184.
  58
  59         * Scripts/webkitpy/layout_tests/port/chromium.py:
  60         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
  61
  62 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
  63
  64         Reviewed by Mihai Parparita.
  65
  66         add a .sep property, abspath(), isabs(), mtime(), and
  67         open_text_file_for_writing() to filesystem modules. Some of
  68         these properties are not needed in this patch but will be needed
  69         in subsequent patches (I'm doing this to avoid having to track
  70         multiple versions of a single file).
  71
  72         Also, change most of the port/* modules to use the filesystem
  73         objects instead of referencing the filesystem directly.
  74
  75         https://bugs.webkit.org/show_bug.cgi?id=52748
  76
  77         * Scripts/webkitpy/common/system/filesystem.py:
  78         * Scripts/webkitpy/common/system/filesystem_mock.py:
  79         * Scripts/webkitpy/layout_tests/port/__init__.py:
  80         * Scripts/webkitpy/layout_tests/port/base.py:
  81         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
  82         * Scripts/webkitpy/layout_tests/port/chromium.py:
  83         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
  84         * Scripts/webkitpy/layout_tests/port/config.py:
  85         * Scripts/webkitpy/layout_tests/port/test.py:
  86         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
  87
  88 2011-01-19  Maciej Stachowiak  <mjs@apple.com>
  89
  90         Reviewed by Anders Carlsson.
  91
  92         If resetting between tests times out, treat it as a WebProcess crash
  93         https://bugs.webkit.org/show_bug.cgi?id=52757
  94
  95         * WebKitTestRunner/TestController.cpp:
  96         (WTR::TestController::runTest):
  97
  98 2011-01-19  Alexey Proskuryakov  <ap@apple.com>
  99
 100         Reviewed by Darin Adler.
 101
 102         https://bugs.webkit.org/show_bug.cgi?id=52739
 103         Make it possible for a WebKit2 client to print headers and footers
 104
 105         Added dummy implementations for new printing UIClient calls.
 106
 107         * MiniBrowser/mac/BrowserWindowController.m:
 108         (-[BrowserWindowController awakeFromNib]):
 109         * WebKitTestRunner/TestController.cpp:
 110         (WTR::createOtherPage):
 111         (WTR::TestController::initialize):
 112
 113 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
 114
 115         Reviewed by Ojan Vafai.
 116
 117         Change webkitpy/layout_tests/port/test.py to use the
 118         in-memory filesystem for cleaner unit testing. This
 119         change allows us to kill a lot of code that was
 120         specific to the test port, at the cost of being a
 121         little less clear about how things would work if
 122         you didn't have a filesystem.
 123
 124         https://bugs.webkit.org/show_bug.cgi?id=52605
 125
 126         * Scripts/webkitpy/layout_tests/port/test.py:
 127
 128 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
 129
 130         Unreviewed, build fix.
 131
 132         Fix test failure caused by committing attachment 79368 instead
 133         of attachment 79461 on bug 52604.
 134
 135         * Scripts/webkitpy/common/system/filesystem_mock.py:
 136
 137 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
 138
 139         Reviewed by Mihai Parparita.
 140
 141         new-run-webkit-tests: remove use of os.walk, use mock filesystem for better
 142         unit testing. os.walk() is too much of a hassle to implement on
 143         top of the in-memory mock filesystem and adding the necessary
 144         interface to files_under() gives clients a cleaner API anyway
 145         (for this particular usage model).
 146
 147         https://bugs.webkit.org/show_bug.cgi?id=52691
 148
 149         * Scripts/webkitpy/common/system/filesystem.py:
 150         * Scripts/webkitpy/common/system/filesystem_mock.py:
 151         * Scripts/webkitpy/layout_tests/port/test_files.py:
 152         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
 153
 154 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
 155
 156         Reviewed by Tony Chang.
 157
 158         Change more modules in the layout-tests code to use the
 159         filesystem wrapper for cleaner unit testing.
 160
 161         This patch also adds the glob() wrapper to the filesystem
 162         abstraction.
 163
 164         https://bugs.webkit.org/show_bug.cgi?id=52604
 165
 166         * Scripts/webkitpy/layout_tests/port/test_files.py:
 167         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
 168         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
 169         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
 170         * Scripts/webkitpy/common/system/filesystem.py:
 171         * Scripts/webkitpy/common/system/filesystem_mock.py:
 172
 173 2011-01-19  Levi Weintraub  <leviw@chromium.org>
 174
 175         Unreviewed.
 176
 177         Updating my email addresses and irc nick.
 178
 179         * Scripts/webkitpy/common/config/committers.py:
 180
 181 2011-01-19  Tony Chang  <tony@chromium.org>
 182
 183         Reviewed by Mihai Parparita.
 184
 185         [chromium] [linux] if check-sys-deps fails, output the failure reason
 186         https://bugs.webkit.org/show_bug.cgi?id=52671
 187
 188         * Scripts/webkitpy/common/system/executive_mock.py: Add support for
 189             error handler functions.
 190         * Scripts/webkitpy/layout_tests/port/chromium.py:
 191             output the error text from --check-sys-deps
 192         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
 193
 194 2011-01-19  Aparna Nandyal  <aparna.nand@wipro.com>
 195
 196         Reviewed by Andreas Kling.
 197
 198         [Qt] QtTestBrowser crashes when closing if Facebook is opened
 199         https://bugs.webkit.org/show_bug.cgi?id=52554
 200
 201         QtNetworkAccessManager is created in a thread and set as
 202         member variable in QWebPage. When the thread is destroyed
 203         the object is still used. So fix will set the object to
 204         NULL once the thread is destroyed.
 205
 206         * QtTestBrowser/launcherwindow.cpp:
 207         (LauncherWindow::~LauncherWindow):
 208
 209 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
 210
 211         Rubber stamped by Csaba Osztrogonac
 212
 213         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: Removed unncessary inculde of WKStringCF.h
 214
 215 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
 216
 217         Reviewed by Tony Chang.
 218
 219         new-run-webkit-tests: add a --build-directory command line argument
 220
 221         Official Google Chrome builds use a non-standard build directory
 222         location. This patch adds a --build-directory argument that
 223         allows that location to be specified on the command line. Only
 224         Chromium-based builds will use this flag for now, but anyone can
 225         in the future.
 226
 227         There are no unit tests for this since it's difficult to test
 228         until mock filesystems are fully supported in the code. This was
 229         tested by hand for now.
 230
 231         https://bugs.webkit.org/show_bug.cgi?id=52694
 232
 233         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
 234         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
 235         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
 236         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
 237
 238 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
 239
 240         Not reviewed. Bot fix.
 241
 242         Remove an inadvertently committed debugging print.
 243
 244         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
 245         (LayoutTestController::notifyDone):
 246
 247 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
 248
 249         Reviewed by Sam Weinig.
 250
 251         WebKitTestRunner should track loading more like DumpRenderTree
 252         https://bugs.webkit.org/show_bug.cgi?id=52692
 253
 254         Change load tracking to track the current top loading frame, in the manner of DumpRenderTree.
 255         This makes some tests that call notifyDone multiple times pass.
 256
 257         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
 258         (WTR::InjectedBundle::InjectedBundle):
 259         (WTR::InjectedBundle::done):
 260         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
 261         (WTR::InjectedBundle::topLoadingFrame):
 262         (WTR::InjectedBundle::setTopLoadingFrame):
 263         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
 264         (WTR::InjectedBundlePage::InjectedBundlePage):
 265         (WTR::InjectedBundlePage::stopLoading):
 266         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
 267         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
 268         (WTR::InjectedBundlePage::didFinishLoadForFrame):
 269         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
 270         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
 271         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
 272         (WTR::LayoutTestController::notifyDone):
 273         * WebKitTestRunner/TestController.cpp:
 274         (WTR::TestController::didReceiveMessageFromInjectedBundle):
 275
 276 2011-01-18  Mihai Parparita  <mihaip@chromium.org>
 277
 278         Reviewed by Kent Tamura.
 279
 280         [Chromium] NRWT looking for DRT binary in the wrong path on Mac
 281         https://bugs.webkit.org/show_bug.cgi?id=52678
 282
 283         Update path now that WebKit is inside Source.
 284
 285         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
 286
 287 2011-01-18  Robert Hogan  <robert@webkit.org>
 288
 289         Reviewed by Simon Hausmann.
 290
 291         [Qt] http/tests/incremental/slow-utf8-text.pl fails
 292         https://bugs.webkit.org/show_bug.cgi?id=44282
 293
 294         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
 295         (WebCore::DumpRenderTree::dump):
 296
 297 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
 298
 299         Reviewed by Mihai Parparita.
 300
 301         Fix a small race condition that could cause the unit tests for
 302         new-run-webkit-tests to fail in a multithreaded environment.
 303         There was a small window in the code where one thread would
 304         check to see if a thread had raised an exception, do something,
 305         and then check to see if the thread was alive. If the other
 306         thread raised an exception and exited in between these two
 307         steps, the exception would be lost. Flipping the order of the
 308         two checks fixes the race, since we will now always check for an
 309         exception on the thread before exiting.
 310
 311         https://bugs.webkit.org/show_bug.cgi?id=51579
 312
 313         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
 314
 315 2011-01-18  Eric Seidel  <eric@webkit.org>
 316
 317         Reviewed by Adam Barth.
 318
 319         commit-queue dies when test archiving fails
 320         https://bugs.webkit.org/show_bug.cgi?id=52617
 321
 322         I looked at the machine and it had 10 archives already
 323         thus find_unused_name was returning None.  I've upped
 324         the limit to 100 (per bug) and tested the case where
 325         find_unused_name returns None (making archive return None).
 326
 327         * Scripts/webkitpy/common/system/workspace.py:
 328         * Scripts/webkitpy/common/system/workspace_unittest.py:
 329         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
 330         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
 331         * Scripts/webkitpy/tool/commands/queues.py:
 332
 333 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
 334
 335         Reviewed by Ojan Vafai.
 336
 337         Update rebaseline-chromium-webkit-tests unit tests to use a mock
 338         filesystem. Also fix a couple of "with" statements missed by
 339         r76050.
 340
 341         https://bugs.webkit.org/show_bug.cgi?id=52487
 342
 343         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
 344
 345 2011-01-18  Sergio Villar Senin  <svillar@igalia.com>
 346
 347         Reviewed by Martin Robinson.
 348
 349         [Gtk] Build fixes for gtk3 build
 350         https://bugs.webkit.org/show_bug.cgi?id=52648
 351
 352         * DumpRenderTree/gtk/EventSender.cpp:
 353         (beginDragWithFilesCallback):
 354
 355 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
 356
 357         Reviewed by Mihai Parparita.
 358
 359         Update rebaseline-chromium-webkit-tests to use filesystem objects
 360         instead of direct references to os.path, shutil, tempfile, etc.
 361
 362         This patch doesn't change anything, but will allow subsequent
 363         patches to change the unit tests to no longer use the real
 364         filesystem.
 365
 366         This patch adds a bunch more methods to the filesystem object as
 367         well.
 368
 369         https://bugs.webkit.org/show_bug.cgi?id=52482
 370
 371         * Scripts/webkitpy/common/system/filesystem.py:
 372         * Scripts/webkitpy/common/system/filesystem_mock.py:
 373         * Scripts/webkitpy/tool/commands/queues.py:
 374         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
 375         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
 376
 377 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
 378
 379         Reviewed by Mihai Parparita.
 380
 381         new-run-webkit-tests shouldn't crash when you try to run a
 382         directory containing only skipped files.
 383
 384         https://bugs.webkit.org/show_bug.cgi?id=52478
 385
 386         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
 387         * Scripts/webkitpy/layout_tests/port/test.py:
 388         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
 389
 390 2011-01-18  Adam Bergkvist  <adam.bergkvist@ericsson.com> and Martin Robinson  <mrobinson@igalia.com>
 391
 392         Reviewed by Gustavo Noronha Silva.
 393
 394         [GTK] The GTK+ EventSender needs support for beginDragWithFiles
 395         https://bugs.webkit.org/show_bug.cgi?id=40833
 396
 397         * DumpRenderTree/gtk/EventSender.cpp: Add a beginDragWithFiles implementation for the
 398         GTK+ event sender.
 399         (dragWithFilesDragDataGetCallback): Added.
 400         (dragWithFilesDragEndCallback): Added.
 401         (beginDragWithFilesCallback): Added.
 402
 403 2011-01-18  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
 404
 405         Reviewed by Adam Barth.
 406
 407         ews: Add additional watcher to efl ews
 408         https://bugs.webkit.org/show_bug.cgi?id=52613
 409
 410         Add gyuyoung.kim@samsung.com to watcher list of efl-ews.
 411
 412         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
 413
 414 2011-01-17  Tony Gentilcore  <tonyg@chromium.org>
 415
 416         Reviewed by Alexey Proskuryakov.
 417
 418         Fix some headers with missing or misspelled #ifndef guards
 419         https://bugs.webkit.org/show_bug.cgi?id=52545
 420
 421         * DumpRenderTree/chromium/TestEventPrinter.h:
 422         * DumpRenderTree/chromium/WebPreferences.h:
 423
 424 2011-01-17  Jessie Berlin  <jberlin@apple.com>
 425
 426         Reviewed by Anders Carlsson.
 427
 428         REGRESSION: Assertion failure in FrameLoader::continueLoadAfterWillSubmitForm() when
 429         navigating back to an unreachable URL
 430         https://bugs.webkit.org/show_bug.cgi?id=52388
 431
 432         Add a third parameter (unreachableURL) to queueLoadHTMLString.
 433
 434         * DumpRenderTree/LayoutTestController.cpp:
 435         (queueLoadHTMLStringCallback):
 436         (LayoutTestController::queueLoadHTMLString):
 437         (LayoutTestController::queueLoadAlternateHTMLString):
 438         * DumpRenderTree/LayoutTestController.h:
 439
 440         * DumpRenderTree/WorkQueueItem.h:
 441         (LoadHTMLStringItem::LoadHTMLStringItem):
 442
 443         * DumpRenderTree/chromium/LayoutTestController.cpp:
 444         (WorkItemLoadHTMLString::WorkItemLoadHTMLString):
 445         (WorkItemLoadHTMLString::run):
 446         (LayoutTestController::queueLoadHTMLString):
 447
 448         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
 449         (LoadHTMLStringItem::invoke):
 450         * DumpRenderTree/mac/WorkQueueItemMac.mm:
 451         (LoadHTMLStringItem::invoke):
 452         * DumpRenderTree/win/WorkQueueItemWin.cpp:
 453         (LoadHTMLStringItem::invoke):
 454
 455 2011-01-17  Dan Bernstein  <mitz@apple.com>
 456
 457         Rubber-stamped by Mark Rowe.
 458
 459         Update xcodeproj svn:ignore to include xcuserdata.
 460
 461         * DumpRenderTree/DumpRenderTree.xcodeproj: Modified property svn:ignore.
 462         * MiniBrowser/MiniBrowser.xcodeproj: Modified property svn:ignore.
 463         * TestWebKitAPI/TestWebKitAPI.xcodeproj: Modified property svn:ignore.
 464         * WebKitLauncher/WebKitLauncher.xcodeproj: Modified property svn:ignore.
 465         * WebKitTestRunner/WebKitTestRunner.xcodeproj: Modified property svn:ignore.
 466
 467 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
 468
 469         Unreviewed fix after r75908.
 470
 471         Move WebKit into Source
 472         https://bugs.webkit.org/show_bug.cgi?id=52530
 473
 474         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add Source to the path for Qt API tests.
 475
 476 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
 477
 478         Unreviewed.
 479
 480         Remove accidentally committed debug printing after r75908.
 481
 482         * Scripts/webkitdirs.pm:
 483
 484 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
 485
 486         Unreviewed.
 487
 488         Add myself to committers list
 489         https://bugs.webkit.org/show_bug.cgi?id=52566
 490
 491         * Scripts/webkitpy/common/config/committers.py:
 492
 493 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
 494
 495         Reviewed by Jeremy Orlow.
 496
 497         GeolocationController should call stopUpdating on destruction
 498         https://bugs.webkit.org/show_bug.cgi?id=52216
 499
 500         fast/dom/Geolocation/window-close-crash.html requires that a
 501         Geolocation watch be started in a secondary window. Consequently,
 502         we need to allow geolocation permission and provide a mock
 503         geolocation position for the secondary window's
 504         GeolocationClientMock.
 505
 506         * DumpRenderTree/chromium/LayoutTestController.cpp:
 507         (LayoutTestController::setGeolocationPermission):
 508         (LayoutTestController::setMockGeolocationPosition):
 509         (LayoutTestController::setMockGeolocationError):
 510         * DumpRenderTree/chromium/TestShell.h:
 511         (TestShell::windowList):
 512
 513 2011-01-16  Adam Barth  <abarth@webkit.org>
 514
 515         Update more include paths to reflect WebKit move.
 516
 517         * DumpRenderTree/chromium/EventSender.cpp:
 518         (EventSender::keyDown):
 519         (EventSender::needsShiftModifier):
 520         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
 521         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
 522
 523 2011-01-16  Kent Tamura  <tkent@chromium.org>
 524
 525         Unreviewed, Chromium build fix.
 526
 527         * Scripts/update-webkit-chromium: Webkit/chromium -> Source/WebKit/chromium
 528
 529 2011-01-16  Martin Robinson  <mrobinson@igalia.com>
 530
 531         Build fix for GTK+ after source directory movement.
 532
 533         * GNUmakefile.am: Correct include paths.
 534
 535 2011-01-16  Adam Barth  <abarth@webkit.org>
 536
 537         Teach svn-apply about WebKit move.
 538
 539         * Scripts/VCSUtils.pm:
 540
 541 2011-01-16  Adam Barth  <abarth@webkit.org>
 542
 543         Rubber-stamped by Eric Seidel.
 544
 545         Move WebKit into Source
 546         https://bugs.webkit.org/show_bug.cgi?id=52530
 547
 548         * DumpRenderTree/mac/InternalHeaders/WebKit/WebTypesInternal.h:
 549         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
 550         * DumpRenderTree/qt/DumpRenderTreeQt.h:
 551         * DumpRenderTree/qt/GCControllerQt.cpp:
 552         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
 553         * DumpRenderTree/qt/PlainTextControllerQt.cpp:
 554         * DumpRenderTree/qt/TextInputControllerQt.cpp:
 555         * DumpRenderTree/wscript:
 556         * QtTestBrowser/launcherwindow.h:
 557         * Scripts/build-webkit:
 558         * Scripts/webkitdirs.pm:
 559
 560 2011-01-15  Adam Barth  <abarth@webkit.org>
 561
 562         Teach svn-apply about WebKit2 move.
 563
 564         * Scripts/VCSUtils.pm:
 565
 566 2011-01-15  Adam Barth  <abarth@webkit.org>
 567
 568         Rubber-stamped by Eric Seidel.
 569
 570         Move WebKit2 into Source
 571         https://bugs.webkit.org/show_bug.cgi?id=52438
 572
 573         * MiniBrowser/qt/MiniBrowser.pro:
 574         * Scripts/build-webkit:
 575         * Scripts/do-file-rename:
 576         * Scripts/do-webcore-rename:
 577         * Scripts/test-webkitpy:
 578         * Scripts/webkitdirs.pm:
 579         * Scripts/webkitpy/style/checker.py:
 580         * WebKitTestRunner/DerivedSources.pro:
 581         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
 582         * WebKitTestRunner/qt/WebKitTestRunner.pro:
 583
 584 2011-01-15  Jochen Eisinger  <jochen@chromium.org>
 585
 586         Reviewed by David Levin.
 587
 588         [chromium] remove obsolete createView method
 589         https://bugs.webkit.org/show_bug.cgi?id=52437
 590
 591         * DumpRenderTree/chromium/WebViewHost.cpp:
 592         (WebViewHost::createView):
 593         * DumpRenderTree/chromium/WebViewHost.h:
 594
 595 2011-01-14  Brian Weinstein  <bweinstein@apple.com>
 596
 597         Reviewed by Geoff Garen.
 598
 599         ShouldLoadResourceForFrame should use strings, not URLs.
 600         https://bugs.webkit.org/show_bug.cgi?id=52476
 601
 602         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
 603         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Update to use a WKStringRef.
 604         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
 605
 606 2011-01-14  Tony Gentilcore  <tonyg@chromium.org>
 607
 608         Reviewed by David Levin.
 609
 610         Add Tony Gentilcore as a reviewer
 611         https://bugs.webkit.org/show_bug.cgi?id=52480
 612
 613         * Scripts/webkitpy/common/config/committers.py:
 614
 615 2011-01-14  David Levin  <levin@chromium.org>
 616
 617         Reviewed by Eric Seidel.
 618
 619         check-webkit-style: _FunctionState should keep track of where the function name starts.
 620         https://bugs.webkit.org/show_bug.cgi?id=52454
 621
 622         * Scripts/webkitpy/style/checkers/cpp.py: Added function_name_start_position to
 623         _FunctionState and logic for setting it correctly.
 624         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests.
 625
 626 2011-01-14  Vincent Scheib  <scheib@chromium.org>
 627
 628         Reviewed by David Levin.
 629
 630         Add support to DumpRenderTree to use the GPU rather than software renderer
 631         https://bugs.webkit.org/show_bug.cgi?id=52333
 632
 633         * DumpRenderTree/chromium/DumpRenderTree.cpp:
 634         (main):
 635         * Scripts/webkitpy/layout_tests/port/chromium.py:
 636         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
 637
 638 2011-01-14  Tony Chang  <tony@chromium.org>
 639
 640         Reviewed by Kent Tamura.
 641
 642         [chromium] update fonts.conf to fix 6 linux tests in drt
 643         https://bugs.webkit.org/show_bug.cgi?id=52411
 644
 645         * DumpRenderTree/chromium/fonts.conf: Update to match the copy in
 646             chromium's src/webkit/tools/test_shell/resources/fonts.conf
 647
 648 2011-01-14  Eric Seidel  <eric@webkit.org>
 649
 650         Original patch from Peter Gal  <galpater@inf.u-szeged.hu>
 651
 652         Reviewed by Adam Barth.
 653
 654         Fix when running Tools/Scripts/check-webkit-style without arguments.
 655         https://bugs.webkit.org/show_bug.cgi?id=52261#c16
 656
 657         * Scripts/webkitpy/common/checkout/scm.py: Handle None for changed_files argument better in Git.create_patch method.
 658         * Scripts/webkitpy/common/checkout/scm_unittest.py:
 659
 660 2011-01-04  Jochen Eisinger  <jochen@chromium.org>
 661
 662         Reviewed by David Levin.
 663
 664         Store the tempdir object in a variable so it doesn't get deleted too early.
 665         https://bugs.webkit.org/show_bug.cgi?id=51875
 666
 667         * Scripts/update-webkit-auxiliary-libs:
 668         * Scripts/update-webkit-support-libs:
 669
 670 2011-01-14  Eric Seidel  <eric@webkit.org>
 671
 672         Unreviewed.  Make it work in python 2.5.
 673
 674         webkit-patch suggest-reviewers dies when ChangeLogs are missing
 675         https://bugs.webkit.org/show_bug.cgi?id=49158
 676
 677         * Scripts/webkitpy/common/checkout/api_unittest.py:
 678
 679 2011-01-14  Sheriff Bot  <webkit.review.bot@gmail.com>
 680
 681         Unreviewed, rolling out r75774.
 682         http://trac.webkit.org/changeset/75774
 683         https://bugs.webkit.org/show_bug.cgi?id=52431
 684
 685         gtk builds were broken (Requested by loislo2 on #webkit).
 686
 687         * Scripts/webkitpy/common/checkout/scm.py:
 688
 689 2011-01-14  David Levin  <levin@chromium.org>
 690
 691         Reviewed by Shinichiro Hamaji.
 692
 693         check-webkit-style: _FunctionState should detect pure functions.
 694         https://bugs.webkit.org/show_bug.cgi?id=52428
 695
 696         * Scripts/webkitpy/style/checkers/cpp.py: Added detection for if a function declaration
 697         is a pure virtual function.
 698         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests for verifying that pure
 699         virtual functions are correctly detected.
 700
 701 2011-01-13  Ilya Tikhonovsky  <loislo@chromium.org>
 702
 703         Reviewed by Yury Semikhatsky.
 704
 705         Just small fix for problem with check-webkit-style.
 706         It just didn't work for this patch.
 707         Old code can't concatenate a list of strings with None.
 708
 709         * Scripts/webkitpy/common/checkout/scm.py:
 710
 711 2011-01-13  David Levin  <levin@chromium.org>
 712
 713         Reviewed by Shinichiro Hamaji.
 714
 715         check-webkit-style: _FunctionState should use Position to know where items are.
 716         https://bugs.webkit.org/show_bug.cgi?id=52424
 717
 718         * Scripts/webkitpy/style/checkers/cpp.py:
 719         (_FunctionState.*): Changed _FunctionState to use Position instead of line numbers.
 720         (detect_functions): Changed to pass Position's to _FunctionState.begin and
 721         did some minor clean-up.
 722         (*): Other changes are simply about converting to use the Position's in_FunctionState
 723         instead of line numbers.
 724         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Changed the test code
 725         to verify the positions stored in _FunctionState.
 726
 727 2011-01-13  Eric Seidel  <eric@webkit.org>
 728
 729         Reviewed by David Levin.
 730
 731         webkit-patch suggest-reviewers dies when ChangeLogs are missing
 732         https://bugs.webkit.org/show_bug.cgi?id=49158
 733
 734         This is not the most elegant, but it is a very safe fix to this bug.
 735         One advantage of catching ScriptError like this instead of adding a
 736         new added_or_modified_files or fixing all changed_files callers
 737         to use a more specific change_files variant, is that we catch
 738         all kinds of ScriptErrors which might cause our (non-essential)
 739         suggest-reviewers code to fail out.  This should make passing
 740         --suggest-reviewers to webkit-patch upload much more robust
 741         and may even make it possible for us to make it default.
 742
 743         The root of the problem here is that SCM.changed_files includes
 744         deleted ChangeLog paths (from moves, etc) which then when we ask
 745         SVN/Git for the contents of the file at that revision, the command
 746         errors out and Executive.run_command raises a ScriptError.
 747
 748         In the future we might fix this differently by making all current
 749         callers of chagned_files use a more specific method for requesting
 750         what types of changes they're interested in (adds, modifies, deletes, etc.)
 751
 752         * Scripts/webkitpy/common/checkout/api.py:
 753         * Scripts/webkitpy/common/checkout/api_unittest.py:
 754
 755 2011-01-13  Dan Bernstein  <mitz@apple.com>
 756
 757         Reviewed by Alexey Proskuryakov.
 758
 759         <rdar://problem/8827065> REGRESSION (r71884): Cross-origin XHR fails if willSendRequest changes the URL
 760         https://bugs.webkit.org/show_bug.cgi?id=52419
 761
 762         Allow to further control the behavior of the willSendRequest delegate callback by making it
 763         set a different URL in the new request.
 764
 765         * DumpRenderTree/LayoutTestController.cpp:
 766         (addURLToRedirectCallback): Added.
 767         (LayoutTestController::staticFunctions): Added addURLToRedirect.
 768         (LayoutTestController::addURLToRedirect): Added. Adds the redirection to the map.
 769         (LayoutTestController::redirectionDestinationForURL): Added this getter.
 770         * DumpRenderTree/LayoutTestController.h:
 771         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
 772         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]): Check
 773         if there is a redirection for the request’s URL, established by addURLToRedirect(), and if so,
 774         change the URL in the new request to the redirect destination.
 775
 776 2011-01-13  Eric Seidel  <eric@webkit.org>
 777
 778         Reviewed by Mihai Parparita.
 779
 780         webkit-patch suggest-reviewers fails due to invalid utf8 in ChangeLog files
 781         https://bugs.webkit.org/show_bug.cgi?id=52416
 782
 783         Example: webkit-patch suggest-reviewers -g ca3890fe74d94d85d6bfa48f9ea497b094d8e717
 784         UnicodeDecodeError: 'utf8' codec can't decode bytes in position 536-538: invalid data
 785
 786         I also added FIXMEs about the changed_files returning deleted files problem
 787         which is causing the other most common exception for suggest-reviewers
 788         (and is probably breaking sheriff-bots blame detection).
 789
 790         * Scripts/webkitpy/common/checkout/api.py:
 791         * Scripts/webkitpy/common/checkout/api_unittest.py:
 792         * Scripts/webkitpy/common/checkout/scm.py:
 793
 794 2011-01-13  Eric Seidel  <eric@webkit.org>
 795
 796         Reviewed by Adam Barth.
 797
 798         results archives from commit-queue are too large to upload
 799         https://bugs.webkit.org/show_bug.cgi?id=52405
 800
 801         * Scripts/webkitpy/common/system/filesystem.py:
 802         * Scripts/webkitpy/common/system/filesystem_mock.py:
 803         * Scripts/webkitpy/tool/commands/queues.py:
 804
 805 2011-01-13  Alejandro G. Castro  <alex@igalia.com>
 806
 807         Reviewed by Martin Robinson.
 808
 809         [gtk] Zero-sized font does not yet work
 810         https://bugs.webkit.org/show_bug.cgi?id=49793
 811
 812         Set minimum-font-size to 0 for the DRT.
 813
 814         * DumpRenderTree/gtk/DumpRenderTree.cpp:
 815         (resetDefaultsToConsistentValues):
 816
 817 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
 818
 819         Reviewed by Darin Adler.
 820
 821         Make old-run-webkit-tests more robust on buildbots
 822         https://bugs.webkit.org/show_bug.cgi?id=52364
 823
 824         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Pass --exit-after-n-failures 500 to old-run-webkit-tests script.
 825
 826 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
 827
 828         Reviewed by Darin Adler.
 829
 830         Make old-run-webkit-tests more robust on buildbots
 831         https://bugs.webkit.org/show_bug.cgi?id=52364
 832
 833         * Scripts/old-run-webkit-tests: Ensure that testResultsDirectory is empty.
 834
 835 2011-01-13  Tony Chang  <tony@chromium.org>
 836
 837         Reviewed by Kent Tamura.
 838
 839         [chromium] fix plugins/plugin-javascript-access.html on Linux and Mac
 840         https://bugs.webkit.org/show_bug.cgi?id=52332
 841
 842         Forked Info.plist is not longer needed.
 843
 844         * DumpRenderTree/chromium/TestNetscapePlugIn/Info.plist: Removed.
 845
 846 2011-01-13  Mikhail Naganov  <mnaganov@chromium.org>
 847
 848         Reviewed by Timothy Hatcher.
 849
 850         Web Inspector: Cleanup after r75613 -- make all UI-facing strings
 851         to be passed directly to WebInspector.UIString
 852
 853         https://bugs.webkit.org/show_bug.cgi?id=52365
 854
 855         * Scripts/check-inspector-strings:
 856
 857 2011-01-13  Sheriff Bot  <webkit.review.bot@gmail.com>
 858
 859         Unreviewed, rolling out r74881.
 860         http://trac.webkit.org/changeset/74881
 861         https://bugs.webkit.org/show_bug.cgi?id=52357
 862
 863         The EFL builder has been red for days (Requested by abarth on
 864         #webkit).
 865
 866         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
 867         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
 868
 869 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
 870
 871         Reviewed by David Levin.
 872
 873         Add beforeunload support to WebKitTestRunner
 874         https://bugs.webkit.org/show_bug.cgi?id=52353
 875
 876         This makes a number of currently failing tests pass.
 877
 878         * WebKitTestRunner/TestController.cpp:
 879         (WTR::runBeforeUnloadConfirmPanel):
 880         (WTR::createOtherPage):
 881         (WTR::TestController::initialize):
 882
 883 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
 884
 885         Reviewed by Sam Weinig.
 886
 887         Detect, identify and recover from WebProcess crashes in run-webkit-tests
 888         https://bugs.webkit.org/show_bug.cgi?id=52330
 889
 890         * Scripts/old-run-webkit-tests: Detect when the regression test tool reports
 891         a web process crash.
 892         * WebKitTestRunner/TestController.cpp:
 893         (WTR::TestController::initialize): Set up a processDidCrash
 894         callback.
 895         (WTR::TestController::processDidCrash): Report that the Web process
 896         crashed.
 897         * WebKitTestRunner/TestController.h:
 898
 899 2011-01-12  David Levin  <levin@chromium.org>
 900
 901         Reviewed by Shinichiro Hamaji.
 902
 903         check-webkit-style -- close_expression function doesn't work correctly.
 904         https://bugs.webkit.org/show_bug.cgi?id=52272
 905
 906         * Scripts/webkitpy/style/checkers/cpp.py:
 907         (Position.__str__): Added a way to convert it to a string which is useful in tests.
 908         (Position.__cmp__): Added a way to compare Position which is useful in tests and
 909         generally useful (for upcoming code changes).
 910         (close_expression): Changed to use Position for input and output.
 911         Also, fixed many bugs such as only working correctly for parenthesis,
 912         not working correctly if given an offset in a line and not finding
 913         the real closing element if there were multiple closing elements in
 914         the same line.
 915         (detect_functions): Adjusted due to the change in arguments for
 916         close_expression.
 917         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
 918         (CppStyleTestBase.assert_positions_equal): Added a way to verify that
 919         two positions are the same.
 920         (CppStyleTest.test_position): Added tests for the __str_ and __cmp__ methods.
 921         (CppStyleTest.test_close_expression): Added tests to catch the issues
 922         that were fixed.
 923
 924 2011-01-12  Sheriff Bot  <webkit.review.bot@gmail.com>
 925
 926         Unreviewed, rolling out r75576.
 927         http://trac.webkit.org/changeset/75576
 928         https://bugs.webkit.org/show_bug.cgi?id=52304
 929
 930         broke rebaseline-chromium-webkit-test (Requested by thakis on
 931         #webkit).
 932
 933         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
 934         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
 935         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
 936         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
 937         * Scripts/webkitpy/layout_tests/port/base.py:
 938         * Scripts/webkitpy/layout_tests/port/chromium.py:
 939         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
 940         * Scripts/webkitpy/layout_tests/port/test.py:
 941         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
 942         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
 943         * Scripts/webkitpy/style/checkers/test_expectations.py:
 944         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
 945
 946 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
 947
 948         Reviewed by Darin Adler.
 949
 950         Add a no-build option to run-webkit-tests, to avoid building DRT/WKTR
 951         https://bugs.webkit.org/show_bug.cgi?id=52307
 952
 953         * Scripts/old-run-webkit-tests:
 954
 955 2011-01-12  Koan-Sin Tan  <koansin.tan@gmail.com>
 956
 957         Reviewed by Martin Robinson.
 958
 959         [Gtk] WebKitGtk+ doesn't build on Mac OS X 10.6
 960         https://bugs.webkit.org/show_bug.cgi?id=50867
 961
 962         Fixed library extention for Mac in webkitdirs.pm and type conflict in
 963         TestNetscapePlugin.cpp
 964
 965         * GNUmakefile.am: Don't use AppKit when compiling TestNetscapePlugin for GTK+
 966         * Scripts/webkitdirs.pm:
 967
 968 2011-01-12  Mikhail Naganov  <mnaganov@chromium.org>
 969
 970         Reviewed by Pavel Feldman.
 971
 972         Add check-inspector-strings script.
 973
 974         https://bugs.webkit.org/show_bug.cgi?id=52295
 975
 976         * Scripts/check-inspector-strings: Added.
 977
 978 2011-01-12  Adam Roben  <aroben@apple.com>
 979
 980         Advertise the .testnetscape file extension on Windows
 981
 982         Fixes <http://webkit.org/b/52298>
 983         plugins/no-mime-with-valid-extension.html fails on Windows
 984
 985         Reviewed by Dan Bernstein.
 986
 987         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Added a
 988         FileExtents field to map the .testnetscape file extension to the
 989         application/x-webkit-test-netscape MIME type, just as we do on Mac.
 990
 991 2011-01-12  Adam Barth  <abarth@webkit.org>
 992
 993         Reviewed by Eric Seidel.
 994
 995         Make webkit-patch support subdirectories for SVN checkouts
 996         https://bugs.webkit.org/show_bug.cgi?id=52261
 997
 998         os.relpath does not exist on Python 2.5, so we need to call our version
 999         of the API.
1000
1001         * Scripts/webkitpy/common/checkout/scm.py:
1002
1003 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
1004
1005         Reviewed by Eric Seidel.
1006
1007         Close additional pages opened during a test once the test completes.
1008         https://bugs.webkit.org/show_bug.cgi?id=52276
1009
1010         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1011         (WTR::InjectedBundle::done):
1012
1013 2011-01-11  David Levin  <levin@chromium.org>
1014
1015         Reviewed by Eric Seidel.
1016
1017         Errors should be separated from the command line in bot messages.
1018         https://bugs.webkit.org/show_bug.cgi?id=52275
1019
1020         * Scripts/webkitpy/common/system/executive.py:
1021         (ScriptError.message_with_output): Added a newline to separate the command
1022         line from the errors.
1023         * Scripts/webkitpy/common/system/executive_unittest.py:
1024         (ScriptErrorTest.test_message_with_output): Added tests for the various code
1025         paths in message_with_output.
1026
1027 2011-01-11  Eric Seidel  <eric@webkit.org>
1028
1029         Unreviewed.
1030
1031         commit-queue should know how to upload archived results (for test flakes or general failures)
1032         https://bugs.webkit.org/show_bug.cgi?id=52048
1033
1034         The zips are mostly empty due to forgetting -r.
1035         Expected diffs were not being pulled from the archive due
1036         to the archive having longer paths than I realized.
1037
1038         * Scripts/webkitpy/common/system/workspace.py:
1039         * Scripts/webkitpy/common/system/workspace_unittest.py:
1040         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1041         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1042
1043 2011-01-11  Dirk Pranke  <dpranke@chromium.org>
1044
1045         Reviewed by Ojan Vafai.
1046
1047         The current modifier parsing code in test_expectations is
1048         fragile and hard-coded, so it's not easy to understand the logic
1049         or easily add new types of modifiers (like GPU vs. CPU testing
1050         for graphics tests, or 32-bit vs. 64-bit differences).
1051
1052         This is the first of two patches that will add in more generic
1053         support and then eliminate the GPU-specific test expectations
1054         files for Chromium.
1055
1056         This patch adds two standalone objects for handling modifiers. The
1057         rules for interpreting modifiers, precedence, and conflicts are
1058         given in the docstring to the ModifierMatcher class, which
1059         returns ModifierMatchResult objects.
1060
1061         This patch also adds routines to the Port interface and a
1062         default set of values in the base object, in order to obtain the
1063         values needed on a given test run. These values are then passed
1064         to the expectation parser. This also allows us to clean up the
1065         logic used to lint all of the different configurations in a
1066         single test_expectations.txt file.
1067
1068         The next patch will merge in the separate GPU expectations file.
1069
1070         https://bugs.webkit.org/show_bug.cgi?id=51222
1071
1072         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1073         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1074         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
1075         * Scripts/webkitpy/layout_tests/port/base.py:
1076         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1077         * Scripts/webkitpy/layout_tests/port/chromium.py:
1078         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1079         * Scripts/webkitpy/layout_tests/port/test.py:
1080         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1081         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1082
1083 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
1084
1085         Reviewed by Adam Barth.
1086
1087         Make webkit-patch support subdirectories for SVN checkouts
1088         https://bugs.webkit.org/show_bug.cgi?id=52261
1089
1090         * Scripts/webkitpy/common/checkout/scm.py:
1091         * Scripts/webkitpy/style_references.py:
1092         * Scripts/webkitpy/tool/main.py:
1093         * Scripts/webkitpy/tool/steps/preparechangelog.py:
1094
1095 2011-01-11  Eric Seidel  <eric@webkit.org>
1096
1097         Unreviewed.
1098
1099         commit-queue should know how to upload archived results (for test flakes or general failures)
1100         https://bugs.webkit.org/show_bug.cgi?id=52048
1101
1102         I changed the API for archive_last_layout_test_results w/o updating the implementation.  Oops.
1103         This fixes an exception seen on the commit-queue when attempting to report flaky tests.
1104
1105         * Scripts/webkitpy/common/system/workspace.py:
1106         * Scripts/webkitpy/common/system/workspace_unittest.py:
1107         * Scripts/webkitpy/tool/commands/queues.py:
1108
1109 2011-01-11  Sam Weinig  <sam@webkit.org>
1110
1111         Roll r75474 back in.
1112
1113 2011-01-11  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
1114
1115         Reviewed by Kenneth Rohde Christiansen.
1116
1117         [Qt] Remove uses of QFuture since it isn't supported on all platforms.
1118         https://bugs.webkit.org/show_bug.cgi?id=51204
1119
1120         * QtTestBrowser/webpage.h:
1121         (QtNAMThread::QtNAMThread):
1122         (QtNAMThread::networkAccessManager):
1123         (QtNAMThread::run):
1124
1125 2011-01-11  Peter Varga  <pvarga@webkit.org>
1126
1127         Unreviewed.
1128
1129         Add myself to committers' list.
1130
1131         * Scripts/webkitpy/common/config/committers.py:
1132
1133 2011-01-11  Eric Seidel  <eric@webkit.org>
1134
1135         Reviewed by Adam Barth.
1136
1137         commit-queue should know how to upload archived results (for test flakes or general failures)
1138         https://bugs.webkit.org/show_bug.cgi?id=52048
1139
1140         Now the queue will always upload results.  Either the entire zip, or just
1141         the diffs.txt in the case of text failures.
1142
1143         This should make understanding flakes much easier, and paves the way
1144         for having the EWS run layout tests (and upload failures).
1145
1146         In order to upload .zip files I had to teach bugzilla.py to autodetect
1147         mime types from the filename.  Since mimetypes.py doesn't include a mapping
1148         for .patch files, I have it add one before calling guess_type.
1149
1150         We may find that always uploading the whole zip instead of just the -diffs.txt
1151         file is preferable, but for now I'm keeping the old behavior because it makes
1152         quickly understanding text failures easy.
1153
1154         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1155         * Scripts/webkitpy/common/system/workspace.py: Added.
1156         * Scripts/webkitpy/common/system/workspace_unittest.py: Added.
1157         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1158         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1159         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1160         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1161         * Scripts/webkitpy/tool/commands/queues.py:
1162         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1163
1164 2011-01-10  Sheriff Bot  <webkit.review.bot@gmail.com>
1165
1166         Unreviewed, rolling out r75464.
1167         http://trac.webkit.org/changeset/75464
1168         https://bugs.webkit.org/show_bug.cgi?id=52193
1169
1170         Followup rollout for 75474 (Requested by Ossy on #webkit).
1171
1172         * MiniBrowser/mac/BrowserWindowController.m:
1173         (-[BrowserWindowController awakeFromNib]):
1174         * MiniBrowser/win/BrowserView.cpp:
1175         (BrowserView::create):
1176         * WebKitTestRunner/TestController.cpp:
1177         (WTR::createOtherPage):
1178         (WTR::TestController::initialize):
1179
1180 2011-01-10  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1181
1182         Reviewed by Csaba Osztrogonác.
1183
1184         [Qt] Baseline qt_minimal configuration
1185         https://bugs.webkit.org/show_bug.cgi?id=51313
1186
1187         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1188         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): Add
1189         QT_NO_UNDOSTACK guard.
1190
1191         * QtTestBrowser/launcherwindow.cpp:
1192         (LauncherWindow::createChrome): Add QT_NO_SHORTCUT and QT_NO_PRINTER
1193         guards.
1194         (LauncherWindow::applyZoom): Add QT_NO_ANIMATION guard.
1195         (LauncherWindow::screenshot): Add QT_NO_FILEDIALOG guard.
1196         (LauncherWindow::selectElements): Add QT_NO_INPUTDIALOG guard.
1197         (LauncherWindow::showUserAgentDialog): Add QT_NO_COMBOBOX guard.
1198
1199         * QtTestBrowser/launcherwindow.h:
1200         * QtTestBrowser/locationedit.cpp: Add QT_NO_INPUTDIALOG guard.
1201         * QtTestBrowser/locationedit.h: Ditto.
1202
1203         * QtTestBrowser/mainwindow.cpp:
1204         (MainWindow::buildUI): Add QT_NO_INPUTDIALOG, QT_NO_SHORTCUT and
1205         QT_NO_UNDOSTACK guards.
1206         (MainWindow::setAddressUrl): Add QT_NO_INPUTDIALOG guard.
1207         (MainWindow::changeLocation): Ditto.
1208         (MainWindow::openFile): Add QT_NO_FILEDIALOG guard.
1209         (MainWindow::openLocation): Add QT_NO_INPUTDIALOG guard.
1210
1211         * QtTestBrowser/webpage.cpp:
1212         (WebPage::openUrlInDefaultBrowser): Add QT_NO_DESKTOPSERVICES guard.
1213         (WebPage::authenticationRequired): Add QT_NO_LINEEDIT guard.
1214
1215         * QtTestBrowser/webview.cpp:
1216         (WebViewGraphicsBased::animatedFlip): Add QT_NO_ANIMATION guard.
1217         (WebViewGraphicsBased::animatedYFlip): Ditto.
1218
1219 2011-01-10  Sam Weinig  <sam@webkit.org>
1220
1221         Fix build.
1222
1223         * MiniBrowser/mac/BrowserWindowController.m:
1224         (-[BrowserWindowController awakeFromNib]):
1225         * MiniBrowser/win/BrowserView.cpp:
1226         (BrowserView::create):
1227         * WebKitTestRunner/TestController.cpp:
1228         (WTR::createOtherPage):
1229         (WTR::TestController::initialize):
1230
1231 2011-01-10  Eric Seidel  <eric@webkit.org>
1232
1233         Reviewed by Ojan Vafai.
1234
1235         style-queue messages are way too long for big patches
1236         https://bugs.webkit.org/show_bug.cgi?id=52161
1237
1238         We definitely could build much fancier list-to-string-with-limit functions
1239         but this should be sufficient for our needs at the moment.
1240
1241         * Scripts/webkitpy/common/system/executive.py:
1242         * Scripts/webkitpy/common/system/executive_unittest.py:
1243
1244 2011-01-10  Tony Chang  <tony@chromium.org>
1245
1246         Unreviewed, rolling out r75398.
1247         http://trac.webkit.org/changeset/75398
1248         https://bugs.webkit.org/show_bug.cgi?id=52008
1249
1250         Some layout tests are crashing on Chromium Win.
1251
1252         * DumpRenderTree/chromium/WebViewHost.cpp:
1253         (WebViewHost::updatePaintRect):
1254         * DumpRenderTree/chromium/WebViewHost.h:
1255
1256 2011-01-10  Adam Roben  <aroben@apple.com>
1257
1258         Roll out r75392
1259
1260         It isn't needed now that r75289 has been rolled out.
1261
1262         * Scripts/run-javascriptcore-tests:
1263
1264 2011-01-10  Maciej Stachowiak  <mjs@apple.com>
1265
1266         Reviewed by Anders Carlsson.
1267
1268         WebKitTestRunner uses crazy amounts of CPU, making layout tests slow and flaky
1269         https://bugs.webkit.org/show_bug.cgi?id=52160
1270
1271         * WebKitTestRunner/mac/TestControllerMac.mm:
1272         (WTR::TestController::platformRunUntil): Instead of busy-looping, wait for the timeout.
1273         Anything that can make runUntil() conditions turn true will happen on a run loop cycle
1274         anyway.
1275
1276 2011-01-10  Tony Chang  <tony@chromium.org>
1277
1278         Reviewed by Mihai Parparita.
1279
1280         [chromium] fix for animated gif layout tests
1281         https://bugs.webkit.org/show_bug.cgi?id=52008
1282
1283         * DumpRenderTree/chromium/WebViewHost.cpp: Schedule a paint when we update the paint rect
1284             to trigger gif animations.
1285         (WebViewHostPaintTask::WebViewHostPaintTask):
1286         (WebViewHostPaintTask::runIfValid):
1287         (WebViewHost::updatePaintRect):
1288         * DumpRenderTree/chromium/WebViewHost.h:
1289         (WebViewHost::taskList):
1290
1291 2011-01-10  Alejandro G. Castro  <alex@igalia.com>
1292
1293         Reviewed by Xan Lopez.
1294
1295         [GTK] Fix gtk2 compilation for master
1296         https://bugs.webkit.org/show_bug.cgi?id=51885
1297
1298         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
1299         (createBitmapContextFromWebView): Replaced the old
1300         gdk_drawable_get_size with gdk_pixmap_get_size.
1301
1302 2011-01-10  Patrick Gansterer  <paroga@webkit.org>
1303
1304         Reviewed by Laszlo Gombos.
1305
1306         [WINCE] Reenable NPAPI after r75203
1307         https://bugs.webkit.org/show_bug.cgi?id=52109
1308
1309         Remove the !isWinCE() check for ENABLE_NETSCAPE_PLUGIN_API and replace
1310         it with !isEfl(), because EFL port does not support NPAPI (yet).
1311
1312         * Scripts/build-webkit:
1313
1314 2011-01-10  Adam Roben  <aroben@apple.com>
1315
1316         Skip some asserting JS tests
1317
1318         See <http://webkit.org/b/52156>.
1319
1320         * Scripts/run-javascriptcore-tests:
1321
1322 2011-01-10  Martin Robinson  <mrobinson@igalia.com>
1323
1324         Reviewed by Xan Lopez.
1325
1326         [GTK] build-webkit disable Blob support via arguments passed to automake
1327         https://bugs.webkit.org/show_bug.cgi?id=52097
1328
1329         * Scripts/build-webkit: Enable Blob support when building WebKitGTK+ via
1330         build-webkit.
1331
1332 2011-01-10  Adam Roben  <aroben@apple.com>
1333
1334         Use the same name and description for TestNetscapePlugin on Windows and
1335         Mac
1336
1337         Fixes <http://webkit.org/b/52151>
1338         fast/frames/iframe-reparenting-plugins.html fails on Windows
1339
1340         Reviewed by Steve Falkenburg.
1341
1342         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Copied
1343         the name and description from Mac's Info.plist.
1344
1345 2011-01-10  Siddharth Mathur <siddharth.mathur@nokia.com>
1346
1347         Reviewed by Laszlo Gombos.
1348
1349         [Qt][WK2] Guard gcc-specific syntax
1350
1351         Non-gcc based compliers choke on the "-include"
1352         syntax for preinclude, place guard around it.
1353
1354         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1355         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1356
1357 2011-01-10  Andreas Kling  <kling@webkit.org>
1358
1359         Reviewed by Simon Hausmann.
1360
1361         [Qt] [WK2] MiniBrowser does not load pages opened in new windows
1362         https://bugs.webkit.org/show_bug.cgi?id=52111
1363
1364         When getting a createNewPage() callback from QWKPage, create the
1365         new page with the same QWKContext as the page that is passed to
1366         the callback.
1367
1368         * MiniBrowser/qt/BrowserView.h:
1369         * MiniBrowser/qt/BrowserWindow.cpp:
1370         (newPageFunction):
1371         (BrowserWindow::BrowserWindow):
1372         * MiniBrowser/qt/BrowserWindow.h:
1373
1374 2011-01-10  Andreas Kling  <kling@webkit.org>
1375
1376         Reviewed by Kenneth Rohde Christiansen.
1377
1378         [Qt] MiniBrowser: Remove superfluous createNewPage() callback
1379
1380         BrowserView set its own useless createNewPage() callback on QWKPage.
1381         This was immediately overridden by BrowserWindow anyway, so remove
1382         the BrowserView one.
1383
1384         * MiniBrowser/qt/BrowserView.cpp:
1385         (BrowserView::BrowserView):
1386
1387 2011-01-10  John Knottenbelt  <jknotten@chromium.org>
1388
1389         Reviewed by Jeremy Orlow.
1390
1391         [Chromium] Remove non-client-based Geolocation code
1392         https://bugs.webkit.org/show_bug.cgi?id=50921
1393
1394         * DumpRenderTree/chromium/LayoutTestController.cpp:
1395         (LayoutTestController::setGeolocationPermission):
1396         (LayoutTestController::setMockGeolocationPosition):
1397         (LayoutTestController::setMockGeolocationError):
1398         * DumpRenderTree/chromium/WebViewHost.cpp:
1399         (WebViewHost::geolocationClientMock):
1400         (WebViewHost::reset):
1401         * DumpRenderTree/chromium/WebViewHost.h:
1402
1403 2011-01-10  Eric Seidel  <eric@webkit.org>
1404
1405         Reviewed by Adam Barth.
1406
1407         Commit bot tried to land r? cq+ patch
1408         https://bugs.webkit.org/show_bug.cgi?id=36638
1409
1410         It should now be possible to post a patch with r? and cq+ and the
1411         commit-queue will correctly wait for the r+ before attempting to land the patch.
1412         (This was a feature requested by several users.)
1413
1414         One caveat: We don't actually reject r-, cq+ patches from the queue
1415         (we just ignore them), but I think that's OK for now.
1416
1417         I also noticed that setting r- once a commit-queue node had grabbed
1418         a patch would not properly cancel the landing.  That's fixed and
1419         tested in this patch.
1420
1421         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1422         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1423         * Scripts/webkitpy/tool/bot/feeders.py:
1424         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
1425
1426 2011-01-08  Benjamin Poulain  <benjamin.poulain@nokia.com>
1427
1428         Reviewed by Kenneth Rohde Christiansen.
1429
1430         [Qt] QtWebKit crashes when using XMLHttpRequest from the unload event
1431         https://bugs.webkit.org/show_bug.cgi?id=51934
1432
1433         When accessing the network from the destructor of QWebPage, the network access manager
1434         was already deleted because the object WebPage was already destructed.
1435
1436         This solve the problem by linking the lifetime of the network access manager to WebPage's QObject.
1437         The object is now destructed in the destructor of QObject.
1438
1439         * QtTestBrowser/webpage.cpp:
1440         (WebPage::WebPage):
1441         (WebPage::setQnamThreaded):
1442         * QtTestBrowser/webpage.h:
1443         (QtNAMThread::QtNAMThread):
1444
1445 2011-01-08  Eric Seidel  <eric@webkit.org>
1446
1447         Reviewed by Ojan Vafai.
1448
1449         test_failures.py should not mention TestShell (long live DumpRenderTree!)
1450         https://bugs.webkit.org/show_bug.cgi?id=52067
1451
1452         I ran test-webkitpy, but didn't bother adding a unit test for this string change.
1453         https://bugs.webkit.org/show_bug.cgi?id=51138#c3 is an example of why this is needed.
1454
1455         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1456
1457 2011-01-08  Eric Seidel  <eric@webkit.org>
1458
1459         Reviewed by Mihai Parparita.
1460
1461         commit-queue hangs when the ChangeLog diff is bad
1462         https://bugs.webkit.org/show_bug.cgi?id=52072
1463
1464         * Scripts/webkitpy/tool/steps/validatechangelogs.py:
1465         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
1466
1467 2011-01-08  Adam Barth  <abarth@webkit.org>
1468
1469         Teach svn-apply how to re-write WebCore to Source/WebCore.
1470
1471         * Scripts/VCSUtils.pm:
1472
1473 2011-01-07  Adam Barth  <abarth@webkit.org>
1474
1475         Rubber-stamped by Eric Seidel.
1476
1477         Move WebCore to Source
1478         https://bugs.webkit.org/show_bug.cgi?id=52050
1479
1480         Update the tools to understand WebCore's new location.
1481
1482         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1483         * DumpRenderTree/wscript:
1484         * GNUmakefile.am:
1485         * Scripts/build-webkit:
1486         * Scripts/do-file-rename:
1487         * Scripts/do-webcore-rename:
1488         * Scripts/generate-qt-inspector-resource:
1489         * Scripts/prepare-ChangeLog:
1490         * Scripts/run-bindings-tests:
1491         * Scripts/update-iexploder-cssproperties:
1492         * Scripts/update-sources-list.py:
1493         * Scripts/update-webkit-localizable-strings:
1494         * Scripts/webkitdirs.pm:
1495         * Scripts/webkitpy/common/config/build.py:
1496         * Scripts/webkitpy/common/config/build_unittest.py:
1497         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
1498         * Scripts/webkitpy/style/checker.py:
1499         * Scripts/webkitpy/style/checker_unittest.py:
1500         * WebKitTestRunner/DerivedSources.pro:
1501         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1502         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh:
1503         * wx/browser/wscript:
1504         * wx/build/settings.py:
1505
1506 2011-01-07  Maciej Stachowiak  <mjs@apple.com>
1507
1508         Reviewed by Sam Weinig.
1509
1510         Make WebKitTestRunner rest between loads more robust to avoid test crashes
1511         https://bugs.webkit.org/show_bug.cgi?id=52086
1512
1513         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1514         (WTR::InjectedBundle::didReceiveMessage):
1515         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1516         (WTR::LayoutTestController::notifyDone):
1517         * WebKitTestRunner/TestController.cpp:
1518         (WTR::TestController::resetStateToConsistentValues):
1519         (WTR::TestController::run):
1520
1521 2011-01-07  James Robinson  <jamesr@chromium.org>
1522
1523         Revert "Implement mozilla's animationTime property"
1524         https://bugs.webkit.org/show_bug.cgi?id=51952
1525
1526         This approach isn't quite right.
1527
1528         * DumpRenderTree/chromium/WebViewHost.cpp:
1529         (WebViewHost::paintInvalidatedRegion):
1530
1531 2011-01-07  Adam Roben  <aroben@apple.com>
1532
1533         Build master fix
1534
1535         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1536         (RunWebKitTests.start): Don't try to concatenate a list and a string.
1537
1538 2011-01-07  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>
1539
1540         Reviewed by Csaba Osztrogonác.
1541
1542         run-qtwebkit-tests should be able to kill a testsuite.
1543
1544         Add new option in the script that can setup a timeout for a test.
1545         If the test execution takes more then specified time then the test
1546         would be terminated.
1547
1548         [Qt] run-qtwebkit-tests needs timeout
1549         https://bugs.webkit.org/show_bug.cgi?id=51894
1550
1551         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1552         * Scripts/run-qtwebkit-tests:
1553
1554 2011-01-07  Csaba Osztrogonác  <ossy@webkit.org>
1555
1556         Unreviewed fix after r75233.
1557
1558         Based on idea from Eric Seidel.
1559
1560         Add remote zip file handling to webkitpy.
1561         https://bugs.webkit.org/show_bug.cgi?id=50901
1562
1563         * Scripts/webkitpy/common/system/fileset.py: Make python 2.5 happy.
1564
1565 2011-01-07  Shane Stephens  <shanestephens@google.com>
1566
1567         Reviewed by Eric Seidel.
1568
1569         svn-apply: should support git binary delta diffs
1570         https://bugs.webkit.org/show_bug.cgi?id=38864
1571
1572         * Scripts/VCSUtils.pm:
1573         * Scripts/svn-apply:
1574
1575 2011-01-06  Julie Parent  <jparent@chromium.org>
1576
1577         Reviewed by Eric Seidel.
1578
1579         Test Result Server not removing old results.
1580         https://bugs.webkit.org/show_bug.cgi?id=52012
1581
1582         * TestResultServer/model/jsonresults.py:
1583         Fix off-by-one: Truncate if >= num_runs, not just >.
1584         * TestResultServer/model/jsonresults_unittest.py:
1585         Add unit test to test that merging in a new result with the same value
1586         as the last result causes previous result to fall off.
1587
1588 2011-01-06  James Kozianski  <koz@chromium.org>
1589
1590         Reviewed by Mihai Parparita.
1591
1592         Add classes to provide a consistent interface to a set of files.
1593         https://bugs.webkit.org/show_bug.cgi?id=50901
1594
1595         These classes allow us to write code that is agnostic to whether a
1596         particular set of files resides in a local directory or in a zip file
1597         on a remote machine.
1598
1599         * Scripts/webkitpy/common/system/directoryfileset.py: Added.
1600         * Scripts/webkitpy/common/system/directoryfileset_unittest.py: Added.
1601         * Scripts/webkitpy/common/system/fileset.py: Added.
1602         * Scripts/webkitpy/common/system/filesystem.py:
1603         * Scripts/webkitpy/common/system/filesystem_mock.py:
1604         * Scripts/webkitpy/common/system/zipfileset.py: Added.
1605         * Scripts/webkitpy/common/system/zipfileset_unittest.py: Added.
1606
1607 2011-01-06  Eric Seidel  <eric@webkit.org>
1608
1609         Reviewed by Adam Barth.
1610
1611         NetworkTransaction should log the url it is retrying
1612         https://bugs.webkit.org/show_bug.cgi?id=52043
1613
1614         * Scripts/webkitpy/common/net/networktransaction.py:
1615         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
1616
1617 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
1618
1619         Windows build fix.
1620         Import os before using it.
1621
1622         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1623
1624 2011-01-06  Eric Seidel  <eric@webkit.org>
1625
1626         Reviewed by Adam Barth.
1627
1628         StyleQueue fails to report errors when patches have many files
1629         https://bugs.webkit.org/show_bug.cgi?id=52042
1630
1631         This is one of at least two errors preventing style error reporting at the moment.
1632         When we moved to passing the list of files to check explicitly,
1633         we started to exceed the 500 character TEXT field limit for our AppEngine model object.
1634         We could change the type of the QueueStatus.message type, or we could
1635         just teach statusserver.py how to clamp values (and warn when it does).
1636         I chose the latter path.
1637
1638         * Scripts/webkitpy/common/net/statusserver.py:
1639
1640 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
1641
1642         Reviewed by Stephanie Lewis.
1643
1644         Fix syntax error in script.
1645
1646         Windows bots need to archive/unarchive builds to/from configuration-specific directories
1647         https://bugs.webkit.org/show_bug.cgi?id=51996
1648
1649         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1650
1651 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1652
1653         Unreviewed, fixing WinCE build after r75196.
1654
1655         WinCE port does not (yet) support NPAPI.
1656
1657         * Scripts/build-webkit:
1658
1659 2011-01-06  Xan Lopez  <xlopez@igalia.com>
1660
1661         Reviewed by Darin Adler.
1662
1663         File::Spec->rel2abs in sunspider-compare-results mangles parameters
1664         https://bugs.webkit.org/show_bug.cgi?id=52015
1665
1666         * Scripts/sunspider-compare-results: call rel2abs on our arguments
1667         after the platform has been detected, otherwise the script will
1668         mangle things like '--gtk' into '/a/path/--gtk', breaking the
1669         detection.
1670
1671 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1672
1673         Reviewed by Eric Seidel.
1674
1675         Add ENABLE_NETSCAPE_PLUGIN_API, ENABLE_ORIENTATION_EVENTS and ENABLE_TOUCH_EVENTS flags to build-webkit
1676         https://bugs.webkit.org/show_bug.cgi?id=51346
1677
1678         * Scripts/build-webkit:
1679
1680 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
1681
1682         Reviewed by Adam Roben.
1683
1684         Windows bots need to archive/unarchive builds to/from configuration-specific directories
1685         https://bugs.webkit.org/show_bug.cgi?id=51996
1686
1687         After the configuration directory change, we were archiving the incorrect directory for
1688         build product, so we were running tests on the wrong binaries.
1689
1690         This change archives the correct directory, and also unarchives it into a configuration-
1691         specific directory.
1692
1693         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Use a configuration-specific directory on Windows.
1694         * BuildSlaveSupport/built-product-archive: Unarchive/archive to/from proper directory.
1695
1696 2011-01-06  Eric Seidel  <eric@webkit.org>
1697
1698         Reviewed by Mihai Parparita.
1699
1700         commit-queue mentions "Text diff mismatch" 4 times instead of once per failure
1701         https://bugs.webkit.org/show_bug.cgi?id=52002
1702
1703         See an example of this here:
1704         https://bugs.webkit.org/show_bug.cgi?id=51314#c2
1705
1706         It's due to the fact that we pass around TestFailure() instance
1707         objects and yet expect them to all compare to be the same.
1708
1709         This is bad.  We should either have shared instances of these values
1710         or we should just pass around the class names.  There are already hacks
1711         in place to make TestFailure objects pass equality tests, I just added
1712         a __hash__ implementation so they can be used in sets as expected.
1713
1714         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1715         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1716
1717 2011-01-06  Evan Martin  <evan@chromium.org>
1718
1719         Reviewed by Tony Chang.
1720
1721         [gdb] handle inaccessible memory and UChar*
1722         https://bugs.webkit.org/show_bug.cgi?id=52003
1723
1724         To pretty-print a UChar*, we just grope around in the memory
1725         looking for a terminating NUL.  We need to handle the exception
1726         that can occur when we poke into an invalid location.
1727
1728         Additionally, the logic for choosing which pretty-printer would
1729         early return before hitting the point where we'd use the UChar*
1730         printer.  (Did this ever work?  How did it regress?)
1731
1732         * gdb/webkit.py:
1733
1734 2011-01-05  Brian Weinstein  <bweinstein@apple.com>
1735
1736         Reviewed by Ada Chan.
1737
1738         WebKit2: Should be able to call into injected bundle to ask if we should allow resource loads
1739         https://bugs.webkit.org/show_bug.cgi?id=51969
1740
1741         Add shouldLoadResourceForFrame to WTR::InjectedBundlePage.
1742
1743         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1744         (WTR::InjectedBundlePage::InjectedBundlePage):
1745         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Stub implementation.
1746         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1747
1748 2011-01-06  James Robinson  <jamesr@chromium.org>
1749
1750         Reviewed by Simon Fraser.
1751
1752         Implement mozilla's animationTime property
1753         https://bugs.webkit.org/show_bug.cgi?id=51952
1754
1755         Chromium DRT support for webkitAnimationTime.
1756
1757         * DumpRenderTree/chromium/WebViewHost.cpp:
1758         (WebViewHost::paintInvalidatedRegion):
1759
1760 2011-01-06  Julie Parent  <jparent@chromium.org>
1761
1762         Reviewed by Tony Chang.
1763
1764         Test Result Server always truncates number of results to JSON_RESULTS_MAX_BUILDS
1765         https://bugs.webkit.org/show_bug.cgi?id=51217
1766
1767         * TestResultServer/model/jsonresults.py:
1768         Pass num_runs through to _remove_items_over_max_number_of_builds, and use the value.
1769         Adds missing documentation.
1770         * TestResultServer/model/jsonresults_unittest.py:
1771         Add unit test to test that truncation happens at smaller value than JSON_RESULTS_MAX_BUILDS.
1772         Update test_merge to take a number of builds to truncate at.
1773
1774 2011-01-06  Adam Barth  <abarth@webkit.org>
1775
1776         Reviewed by Eric Seidel.
1777
1778         The EWS should log outside of the working directory
1779         https://bugs.webkit.org/show_bug.cgi?id=51986
1780
1781         This patch prepare us for using git clean -x -d -f in the EWS wrapper
1782         script, which will actually clean the working copy back to a pristine
1783         state instead of leaving untracked directories and ignored files.
1784
1785         * Scripts/webkitpy/tool/commands/queues.py:
1786         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1787
1788 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
1789
1790         Windows build fix.
1791         Back out attempted change to built-product-archive.
1792
1793         * BuildSlaveSupport/built-product-archive:
1794
1795 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
1796
1797         Windows build fix.
1798         Include configuration name when unpacking a build archive.
1799
1800         Needed, since we split Windows build results into configuration-specific directories
1801         under WebKitOutputDir.
1802
1803         * BuildSlaveSupport/built-product-archive:
1804
1805 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
1806
1807         Reviewed by Darin Adler.
1808
1809         Debug and Release builds on Windows clobber each other
1810         https://bugs.webkit.org/show_bug.cgi?id=49185
1811
1812         Changes the structure of WebKitBuild build products directory so we
1813         completely separate each build configuration into independent directories.
1814
1815         Although we previously had per-configuration directories for obj, this change adds
1816         per-configuration directories for bin, lib, obj, and include. Each configuration's
1817         build products are stored within a directory inside of WebKitBuild.
1818
1819         Most use of $(WebKitOutputDir) in the build files has been replaced by $(ConfigurationBuildDir),
1820         defined in common.vsprops to be $(WebKitOutputDir)\$(ConfigurationName).
1821
1822         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops:
1823         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd:
1824         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd:
1825         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
1826         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd:
1827         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd:
1828         * DumpRenderTree/win/ImageDiffCommon.vsprops:
1829         * DumpRenderTree/win/ImageDiffPostBuild.cmd:
1830         * DumpRenderTree/win/ImageDiffPreBuild.cmd:
1831         * FindSafari/FindSafari.vcproj:
1832         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
1833         * MiniBrowser/MiniBrowserPostBuild.cmd:
1834         * MiniBrowser/MiniBrowserPreBuild.cmd:
1835         * Scripts/webkitdirs.pm:
1836         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
1837         * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops:
1838         * TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd:
1839         * TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd:
1840         * TestWebKitAPI/win/copy-resources.cmd:
1841         * WebKitAPITest/WebKitAPITestCommon.vsprops:
1842         * WebKitAPITest/WebKitAPITestPostBuild.cmd:
1843         * WebKitAPITest/WebKitAPITestPreBuild.cmd:
1844         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
1845         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
1846         * WebKitTestRunner/win/InjectedBundle.vcproj:
1847         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops:
1848         * WebKitTestRunner/win/InjectedBundlePostBuild.cmd:
1849         * WebKitTestRunner/win/InjectedBundlePreBuild.cmd:
1850         * WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd:
1851         * WebKitTestRunner/win/WebKitTestRunnerPreBuild.cmd:
1852         * WinLauncher/WinLauncherCommon.vsprops:
1853         * WinLauncher/WinLauncherPostBuild.cmd:
1854         * WinLauncher/WinLauncherPreBuild.cmd:
1855
1856 2011-01-05  Jan Erik Hanssen  <jhanssen@sencha.com>
1857
1858         Reviewed by Ariya Hidayat.
1859
1860         [Qt] TestNetscapePlugin doesn't link on OS X
1861         https://bugs.webkit.org/show_bug.cgi?id=51948
1862
1863         Only add a dependency on libX11 on X11 systems
1864
1865         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1866
1867 2011-01-05  Jeff Miller  <jeffm@apple.com>
1868
1869         Reviewed by Adam Roben.
1870
1871         check-webkit-style should allow unnecessary parameter names in WebKit2 APIs because we're matching CF's header style
1872         https://bugs.webkit.org/show_bug.cgi?id=51970
1873
1874         * Scripts/webkitpy/style/checker.py:
1875         Add -readability/naming for WebKit2 C API directories.
1876
1877 2011-01-05  Eric Seidel  <eric@webkit.org>
1878
1879         Unreviewed, just fixing one more log error from my previous python patch.
1880
1881         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
1882         https://bugs.webkit.org/show_bug.cgi?id=51802
1883
1884         webkit-patch failure-reason was logging about parsing errors
1885         due to my misunderstanding of how BeautifulSoup.findAll worked.
1886
1887         Fixed, and added a unit test.
1888
1889         * Scripts/webkitpy/common/net/layouttestresults.py:
1890         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1891
1892 2011-01-05  Benjamin Poulain  <benjamin.poulain@nokia.com>
1893
1894         Reviewed by Kenneth Rohde Christiansen.
1895
1896         [Qt] [WK2] Add the possibility to open window from the WebProcess in Minibrowser
1897         https://bugs.webkit.org/show_bug.cgi?id=51951
1898
1899         Set a function to QWKPage::setCreateNewPageFunction() in Minibrowser so there is a way
1900         to create new window from WebKit.
1901
1902         * MiniBrowser/qt/BrowserWindow.cpp:
1903         (newPageFunction):
1904         (BrowserWindow::BrowserWindow):
1905         (BrowserWindow::page): Added to avoid the indirect access to QWKPage spread in the class
1906         (BrowserWindow::newWindow):
1907         (BrowserWindow::updateUserAgentList):
1908         (BrowserWindow::showUserAgentDialog):
1909         * MiniBrowser/qt/BrowserWindow.h: Add the global variable backingStoreTypeForNewWindow to
1910         define the type of the backing store used for new windows.
1911         * MiniBrowser/qt/main.cpp:
1912         (main):
1913
1914 2011-01-05  Eric Seidel  <eric@webkit.org>
1915
1916         Reviewed by Ojan Vafai.
1917
1918         commit-queue should report failure type when reporting flaky tests
1919         https://bugs.webkit.org/show_bug.cgi?id=51900
1920
1921         This patch was a ridiculous amount of plumbing.  In the end I like
1922         the NRWT-style TestResult class even less.  But now we're passing
1923         a list of TestResult objects from the queue to the FlakyTestReporter.
1924         Thus the FlakyTestReporter can more easily report what type of failure
1925         occurred.
1926
1927         In the process, I found that I was not alone in finding TestResult
1928         cumbersome to use.  A bunch of code was trying to create a TestResult
1929         object with default values.  However since the constructor didn't make
1930         this easy, some places were getting it wrong (including the TestResult unit test)!
1931         I've fixed the TestResult constructor to have default values for non-essential
1932         arguments.
1933
1934         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1935         * Scripts/webkitpy/common/net/layouttestresults.py:
1936         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1937         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1938         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1939         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1940         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
1941         * Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py:
1942         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1943         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1944         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1945         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1946         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1947         * Scripts/webkitpy/tool/commands/queues.py:
1948         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1949
1950 2011-01-05  Eric Seidel  <eric@webkit.org>
1951
1952         Unreviewed.
1953
1954         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
1955         https://bugs.webkit.org/show_bug.cgi?id=51802
1956
1957         Add another unit test to cover a previously missing import.
1958
1959         * Scripts/webkitpy/common/net/layouttestresults.py:
1960         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1961
1962 2011-01-05  Mihai Parparita  <mihaip@chromium.org>
1963
1964         Reviewed by David Levin.
1965
1966         Add mihaip@chromium.org as a reviewer
1967         https://bugs.webkit.org/show_bug.cgi?id=51966
1968
1969         Add myself as a reviewer.
1970
1971         * Scripts/webkitpy/common/config/committers.py:
1972
1973 2011-01-05  James Simonsen  <simonjam@chromium.org>
1974
1975         Unreviewed. Adding myself to the list of committers.
1976
1977         * Scripts/webkitpy/common/config/committers.py:
1978
1979 2011-01-05  Eric Seidel  <eric@webkit.org>
1980
1981         Unreviewed.
1982
1983         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
1984         https://bugs.webkit.org/show_bug.cgi?id=51802
1985
1986         Fix two exceptions seen on the bots after my original commit.
1987
1988         * Scripts/webkitpy/common/net/layouttestresults.py:
1989         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1990
1991 2011-01-05  Kundu Suchismita  <suchi.kundu@nokia.com>
1992
1993         Reviewed by Andreas Kling.
1994
1995         [Qt]Add local storage settings to QtTestBrowser command line arguments
1996         https://bugs.webkit.org/show_bug.cgi?id=51750
1997
1998         * QtTestBrowser/main.cpp:
1999         (LauncherApplication::handleUserOptions):
2000          Local storage settings can be enable form command line arguments for
2001          QtTestBrowser.
2002
2003 2011-01-05  Chris Fleizach  <cfleizach@apple.com>
2004
2005         Reviewed by Martin Robinson.
2006
2007         GTK: AX: DRT needs to use correct root object method.
2008         https://bugs.webkit.org/show_bug.cgi?id=51911
2009
2010         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
2011         (AccessibilityController::rootElement):
2012
2013 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
2014
2015         Rubber-stamped by Csaba Osztrogonác.
2016
2017         Based on idea from Péter Gál.
2018
2019         * Scripts/webkitpy/tool/bot/sheriff.py: Remove unnecessary apostrophes around revision numbers.
2020
2021 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
2022
2023         Reviewed by Adam Barth.
2024
2025         sheriff-bot should be able to do multi-revision rollouts
2026         https://bugs.webkit.org/show_bug.cgi?id=51176
2027
2028         * Scripts/webkitpy/tool/bot/irc_command.py:
2029         * Scripts/webkitpy/tool/bot/sheriff.py:
2030         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
2031
2032 2011-01-05  Eric Seidel  <eric@webkit.org>
2033
2034         Reviewed by Adam Barth.
2035
2036         queues.webkit.org should have per-bot status pages
2037         https://bugs.webkit.org/show_bug.cgi?id=51906
2038
2039         Just adds a /queue-status/QUEUE_NAME/bots/BOT_ID page to show
2040         statuses from a single queue.  Now that we have many bots servicing
2041         some queues (commit-queue, win-ews, etc.) its easy to have the messages
2042         you care about scroll off the end of the 15-message limit on the main page.
2043
2044         Eventually we should probably rename /queue-status to /queue or /queues,
2045         but that's fodder for another patch.
2046
2047         * QueueStatusServer/handlers/queuestatus.py:
2048         * QueueStatusServer/index.yaml:
2049         * QueueStatusServer/main.py:
2050         * QueueStatusServer/templates/includes/singlequeuestatus.html:
2051          - This probably should use a custom filter instead of hard-coding
2052            the URL scheme here, but I couldn't figure out how to easily
2053            create such a filter.  Most filters work with "strings" so we can't
2054            pass the status object.  We could add a method to the status
2055            object and call that, but that seemed a bit strange too.
2056         * QueueStatusServer/templates/queuestatus.html:
2057
2058 2011-01-05  Carlos Garcia Campos  <cgarcia@igalia.com>
2059
2060         Unreviewed. Adding myself to the list of committers.
2061
2062         * Scripts/webkitpy/common/config/committers.py:
2063
2064 2011-01-04  Koan-Sin Tan  <koansin.tan@gmail.com>
2065
2066         Reviewed by David Levin.
2067
2068         check-webkit-style treated some macros with parentheses after #elif as function calls
2069         https://bugs.webkit.org/show_bug.cgi?id=51695
2070
2071         Ingore function call space checking in any preprocessor directives
2072         (things starting with #). Change search() to match() because
2073         preprocessor directives are supposed to be in the beginning of lines.
2074
2075         * Scripts/webkitpy/style/checkers/cpp.py:
2076         * Scripts/webkitpy/style/checkers/cpp_unittest.py: make sure there is no false positives for #elif cases
2077
2078 2011-01-04  Søren Gjesse  <sgjesse@chromium.org>
2079
2080         Reviewed by Tony Chang.
2081
2082         Change the --multi-load test option to --stress-opt
2083         https://bugs.webkit.org/show_bug.cgi?id=50751
2084
2085         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2086         (runTest):
2087         (main):
2088         * DumpRenderTree/chromium/TestShell.cpp:
2089         (TestShell::TestShell):
2090         * DumpRenderTree/chromium/TestShell.h:
2091         (TestShell::stressOpt):
2092         (TestShell::setStressOpt):
2093         (TestShell::stressDeopt):
2094         (TestShell::setStressDeopt):
2095         (TestShell::javaScriptFlags):
2096         (TestShell::setJavaScriptFlags):
2097         * Scripts/webkitpy/layout_tests/port/chromium.py:
2098         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2099
2100 2011-01-04  Chris Fleizach  <cfleizach@apple.com>
2101
2102         Reviewed by Sam Weinig.
2103
2104         WK2: Support Accessibility
2105         https://bugs.webkit.org/show_bug.cgi?id=51859
2106
2107         Use rootObject() method to get top of accessibility tree.
2108
2109         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
2110         (AccessibilityController::focusedElement):
2111         (AccessibilityController::rootElement):
2112
2113 2011-01-03  Martin Robinson  <mrobinson@igalia.com>
2114
2115         Reviewed by Darin Adler.
2116
2117         Remove the last non-GObject usage of PlatformRefPtr and move the code to GRefPtr
2118         https://bugs.webkit.org/show_bug.cgi?id=51846
2119
2120         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: Change usage of PlatformRefPtr
2121         back to GRefPtr.
2122
2123 2011-01-04  Zhe Su  <suzhe@chromium.org>
2124
2125         Reviewed by Kenneth Russell.
2126
2127         Fix insertText, setMarkedText and unmarkText methods of
2128         TextInputController to call corresponding methods of WebKit::WebView
2129         rather than WebKit::WebFrame. This change matches the behavior of
2130         chromium browser.
2131         insertText corresponds to WebView::confirmComposition(text)
2132         setMarkedText corresponds to WebView::setComposition(...)
2133         unmarkText corresponds to WebView::confirmComposition()
2134         https://bugs.webkit.org/show_bug.cgi?id=51693
2135
2136         * DumpRenderTree/chromium/TextInputController.cpp:
2137         (TextInputController::insertText):
2138         (TextInputController::setMarkedText):
2139         (TextInputController::unmarkText):
2140
2141 2011-01-04  Dihan Wickremasuriya  <dihan.wickremasuriya@nokia.com>
2142
2143         Reviewed by Laszlo Gombos.
2144
2145         [Qt] [Symbian] Do not remove 0 byte sized files from productDir
2146
2147         On Symbian productDir points to the source directory. Removing all the
2148         empty files from the productDir directory corrupts the svn repository.
2149
2150         * Scripts/build-webkit:
2151
2152 2011-01-03  Yi Shen  <yi.4.shen@nokia.com>
2153
2154         Reviewed by Adam Barth.
2155
2156         [Qt] Add SelectAll option to the context menu for the editor
2157         https://bugs.webkit.org/show_bug.cgi?id=50049
2158
2159         Set shortcut for the SelectAll action.
2160
2161         * QtTestBrowser/mainwindow.cpp:
2162         (MainWindow::buildUI):
2163
2164 2011-01-03  David Levin  <levin@chromium.org>
2165
2166         Reviewed by Eric Seidel.
2167
2168         check-webkit-style shouldn't consider "value" automatically to be a meaningless name.
2169         https://bugs.webkit.org/show_bug.cgi?id=51842
2170
2171         * Scripts/webkitpy/style/checkers/cpp.py: Remove the check for value.
2172         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Remove the test for value.
2173
2174 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
2175
2176         Reviewed by David Kilzer.
2177
2178         [WINCE] Adds a build slave.
2179         https://bugs.webkit.org/show_bug.cgi?id=50523
2180
2181         * BuildSlaveSupport/build.webkit.org-config/config.json: Add an
2182         entry for a release build of the WinCE port.
2183         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add platform
2184         flag to build the WinCE port.
2185
2186 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
2187
2188         Reviewed by David Kilzer.
2189
2190         Add WinCE support to build-webkit
2191         https://bugs.webkit.org/show_bug.cgi?id=51642
2192
2193         * Scripts/build-webkit:
2194         * Scripts/webkitdirs.pm:
2195
2196 2011-01-03  Eric Seidel  <eric@webkit.org>
2197
2198         Reviewed by Adam Barth.
2199
2200         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
2201         https://bugs.webkit.org/show_bug.cgi?id=51802
2202
2203         I'm not the biggest fan of the test_failures or test_results classes,
2204         but it's better to have one shared set of classes, than separate ones
2205         for new vs. old run-webkit-test result handling.
2206
2207         This moves the ORWT results class "LayoutTestResults" over to using
2208         TestResult and TestFailure classes, making it easy for us to
2209         make all our sheriff-bot and other webkitpy code NRWT ready.
2210
2211         This also makes it a trivial patch to generate results.json information
2212         from ORWT results.html files (for flaky test analysis, etc.) as well
2213         as making it a one-liner to report test failure types when the
2214         commit-queue sees flaky tests.
2215
2216         This patch tried not to add new functionality, but only to replace
2217         the guts of LayoutTestResults, while adding unit tests and hoping
2218         not to break anything.
2219
2220         I also moved callers which assumed User.prompt* were static/class methods
2221         to using them as instance methods (since we'll eventually want to make them such).
2222
2223         In the process of re-writing things, I broke the rebaseline command, so I wrote
2224         a unit test to catch my breakage were I do do so again in the future.
2225
2226         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2227         * Scripts/webkitpy/common/net/layouttestresults.py:
2228         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2229         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
2230         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
2231         * Scripts/webkitpy/tool/commands/queries.py:
2232         * Scripts/webkitpy/tool/commands/rebaseline.py:
2233         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2234         * Scripts/webkitpy/tool/mocktool.py:
2235
2236 2011-01-03  Adam Barth  <abarth@webkit.org>
2237
2238         Reviewed by Simon Fraser.
2239
2240         webkit-patch shouldn't waste time cleaning a working directory that's already clean
2241         https://bugs.webkit.org/show_bug.cgi?id=51840
2242
2243         * Scripts/webkitpy/common/checkout/scm.py:
2244
2245 2011-01-03  Adam Barth  <abarth@webkit.org>
2246
2247         Reviewed by Simon Fraser.
2248
2249         webkit-patch should only hide update output if --quiet
2250         https://bugs.webkit.org/show_bug.cgi?id=51838
2251
2252         As requested by smfr.
2253
2254         * Scripts/webkitpy/tool/steps/update.py:
2255
2256 2011-01-03  Adam Barth  <abarth@webkit.org>
2257
2258         Reviewed by David Levin.
2259
2260         commit-queue shouldn't reject patches twice if two bots process the same patch
2261         https://bugs.webkit.org/show_bug.cgi?id=51805
2262
2263         Before raising an error, we first check whether the patch is still in
2264         the commit-queue.  This check is still racy, of course, but the time
2265         window is much smaller.
2266
2267         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2268
2269 2011-01-03  Sam Weinig  <sam@webkit.org>
2270
2271         Reviewed by Anders Carlsson.
2272
2273         Make run-api-tests less chatty.
2274         https://bugs.webkit.org/show_bug.cgi?id=51831
2275
2276         - Make script quiet by default and add --verbose option (replacing --quiet).
2277         - When not verbose, pipe stdout and stderr to devnull.
2278
2279         * Scripts/run-api-tests:
2280
2281 2011-01-03  Pratik Solanki  <psolanki@apple.com>
2282
2283         Unreviewed. Adding myself to committers.py.
2284
2285         * Scripts/webkitpy/common/config/committers.py:
2286
2287 2011-01-03  Koan-Sin Tan  <koansin.tan@gmail.com>
2288
2289         Reviewed by Xan Lopez.
2290
2291         "Tool/Scripts/run-launcher --gtk" stopped working after 74855
2292         https://bugs.webkit.org/show_bug.cgi?id=51806
2293
2294         Originally, the $libraryName is 'JavaScriptCore'. When building release
2295         one, the $libraryDir was 'WebKitBuild/Release/JavaScriptCore/../.libs/'
2296         which doesn't exist anymore ('WebKitBuild/Release/JavaScriptCore'
2297         is 'WebKitBuild/Release/Source/JavaScriptCore' now), and
2298         'WebKitBuild/Release/Source/JavaScriptCore/../../.libs' looks weird,
2299         so make it 'WebKitBuild/Release/.libs'
2300
2301         * Scripts/webkitdirs.pm:
2302
2303 2011-01-02  Patrick Gansterer  <paroga@webkit.org>
2304
2305         Reviewed by Adam Barth.
2306
2307         Make EFL a core builder
2308         https://bugs.webkit.org/show_bug.cgi?id=51804
2309
2310         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2311         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2312
2313 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
2314
2315         [Qt] Unreviewed fix after r74855 and r74875.
2316
2317         * BuildSlaveSupport/built-product-archive:
2318          - Create directories explicitly.
2319          - Pass shell=True to subprocess.call().
2320
2321 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
2322
2323         [Qt] Unreviewed fix after r74855.
2324
2325         Move JavaScriptCore to Source
2326         https://bugs.webkit.org/show_bug.cgi?id=51604
2327
2328         * BuildSlaveSupport/built-product-archive: JavaScriptCore -> Source/JavaScriptCore
2329
2330 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
2331
2332         [Qt] Unreviewed run-javasriptcore-tests fix after r74855.
2333
2334         Move JavaScriptCore to Source
2335         https://bugs.webkit.org/show_bug.cgi?id=51604
2336
2337         * Scripts/webkitdirs.pm:
2338
2339 2011-01-02  Robert Hogan  <robert@webkit.org>
2340
2341         Unreviewed, build fix.
2342
2343         [Qt] Fix DRT build after 74855
2344
2345         * DumpRenderTree/qt/DumpRenderTree.pro:
2346
2347 2011-01-01  Adam Barth  <abarth@webkit.org>
2348
2349         Remove the assumption from the Qt and Gtk builds that every project is
2350         in the root directory.
2351
2352         * Scripts/build-webkit:
2353
2354 2011-01-01  Adam Barth  <abarth@webkit.org>
2355
2356         Reviewed by Eric Seidel.
2357
2358         Teach svn-apply how to apply patches even though JavaScriptCore has moved
2359         https://bugs.webkit.org/show_bug.cgi?id=51796
2360
2361         After this change, svn-apply will magically apply patches to
2362         JavaScriptCore/foo to Source/JavaScriptCore/foo.
2363
2364         * Scripts/VCSUtils.pm:
2365
2366 2011-01-01  Adam Barth  <abarth@webkit.org>
2367
2368         Reviewed by Eric Seidel.
2369
2370         Move JavaScriptCore to Source
2371         https://bugs.webkit.org/show_bug.cgi?id=51604
2372
2373         Update references to JavaScriptCore to point to the new location.
2374
2375         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2376         * DumpRenderTree/qt/DumpRenderTree.pro:
2377         * DumpRenderTree/qt/ImageDiff.pro:
2378         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2379         * DumpRenderTree/wscript:
2380         * Scripts/build-jsc:
2381         * Scripts/build-webkit:
2382         * Scripts/do-file-rename:
2383         * Scripts/do-webcore-rename:
2384         * Scripts/run-javascriptcore-tests:
2385         * Scripts/update-javascriptcore-test-results:
2386         * Scripts/webkitdirs.pm:
2387         * Scripts/webkitpy/common/config/build_unittest.py:
2388         * Scripts/webkitpy/style/checker.py:
2389         * Scripts/webkitpy/style/checker_unittest.py:
2390         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2391         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2392         * WebKitTestRunner/qt/WebKitTestRunner.pro:
2393         * wx/build/settings.py:
2394
2395 2011-01-01  Adam Barth  <abarth@webkit.org>
2396
2397         Reviewed by Eric Seidel.
2398
2399         Move Sources to Source
2400         https://bugs.webkit.org/show_bug.cgi?id=51794
2401
2402         Update scripts to point to the new location.
2403
2404         * Scripts/build-webkit:
2405         * Scripts/do-file-rename:
2406         * Scripts/do-webcore-rename:
2407         * Scripts/webkitpy/common/config/build.py:
2408         * Scripts/webkitpy/common/config/build_unittest.py:
2409
2410 2010-12-31  Kent Tamura  <tkent@chromium.org>
2411
2412         Reviewed by Eric Seidel.
2413
2414         [DRT/Chromium] Enable mock spell checker on non-OSX
2415         https://bugs.webkit.org/show_bug.cgi?id=51401
2416
2417         * DumpRenderTree/chromium/WebViewHost.cpp:
2418         (WebViewHost::spellCheck):
2419
2420 2010-12-31  Adam Barth  <abarth@webkit.org>
2421
2422         Reviewed by Ariya Hidayat.
2423
2424         Remove Tools/Scripts/wkstyle
2425         https://bugs.webkit.org/show_bug.cgi?id=51774
2426
2427         This script appears to not have been touched in a while and seems to
2428         have been replaced by check-webkit-style.
2429
2430         * Scripts/wkstyle: Removed.
2431
2432 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
2433
2434         Unreviewed. Coding style fix.
2435
2436         * DumpRenderTree/chromium/TestShell.h:
2437
2438 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
2439
2440         Reviewed by Pavel Feldman.
2441
2442         Web Inspector: [Chromium] Inspector's tests are very slow on Win(Dbg).
2443
2444         It was a problem with Chromium DRT. DevToolsAgent object instance was
2445         attached not only to the inspected page but to the DevTools window too.
2446         As result all the inspector files were interpreted as a content of inspected page
2447         and were transfered to the DevTools scripts panel for debugging etc.
2448
2449         https://bugs.webkit.org/show_bug.cgi?id=51735
2450
2451         * DumpRenderTree/chromium/TestShell.cpp:
2452         (TestShell::TestShell):
2453         (TestShell::bindJSObjectsToWindow):
2454         (TestShell::createNewWindow):
2455         * DumpRenderTree/chromium/TestShell.h:
2456
2457 2010-12-31  Adam Barth  <abarth@webkit.org>
2458
2459         Rubber-stamped by Eric Seidel.
2460
2461         Move PageLoadTests to PerformanceTests/PageLoad
2462         https://bugs.webkit.org/show_bug.cgi?id=51771
2463
2464         Update references to PageLoadTests to point to the new location.
2465
2466         * Scripts/run-pageloadtest:
2467         * Scripts/webkitpy/common/config/build.py:
2468
2469 2010-12-31  Adam Barth  <abarth@webkit.org>
2470
2471         Rubber-stamped by Eric Seidel.
2472
2473         Move SunSpider into PerformanceTests
2474         https://bugs.webkit.org/show_bug.cgi?id=51769
2475
2476         Update these scripts to point to the new location.
2477
2478         * Scripts/run-sunspider:
2479         * Scripts/sunspider-compare-results:
2480
2481 2010-12-30  Mihai Parparita  <mihaip@chromium.org>
2482
2483         Reviewed by Kent Tamura.
2484
2485         [Chromium] Add WebThemeEngineDRTMac so that Chromium DRT scrollbar rendering can match the Mac port's
2486         https://bugs.webkit.org/show_bug.cgi?id=51728
2487
2488         Add implementation of the Mac WebThemeEngine that uses an NSScroller
2489         to render top-level scrollbars. This makes them match the Mac port's
2490         use of an NSScrollView, which means that we'll be able to share more
2491         pixel baselines.
2492
2493         The new rendering code will not be activated until the
2494         USE_WEB_THEME_ENGINE_TO_PAINT_THUMB #define is fliped in
2495         ScrollbarThemeChromiumMac.
2496
2497         * DumpRenderTree/DumpRenderTree.gypi:
2498         * DumpRenderTree/chromium/TestShellMac.mm:
2499         (platformInit):
2500         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Added.
2501         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Added.
2502         (+[FakeActiveWindow alwaysActiveWindow]):
2503         (+[FakeActiveWindow alwaysInactiveWindow]):
2504         (-[FakeActiveWindow initWithActiveControls:]):
2505         (-[FakeActiveWindow _hasActiveControls]):
2506         (WebThemeEngineDRTMac::paintScrollbarThumb):
2507         (stateToHIEnableState):
2508         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
2509         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
2510
2511 2010-12-30  Konstantin Tokarev  <annulen@yandex.ru>
2512
2513         Reviewed by David Kilzer.
2514
2515         [Qt] Don't build wtf/TCSystemAlloc.cpp if --system-malloc option is
2516         used
2517         https://bugs.webkit.org/show_bug.cgi?id=51672
2518
2519         * DumpRenderTree/qt/DumpRenderTree.pro: Replaced USE_SYSTEM_MALLOC
2520         with USE_SYSTEM_MALLOC=1
2521         * WebKitTestRunner/qt/WebKitTestRunner.pro: Replaced USE_SYSTEM_MALLOC
2522         with USE_SYSTEM_MALLOC=1
2523
2524 2010-12-30  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2525
2526         Reviewed by David Kilzer.
2527
2528         [Qt] [Symbian] Fix build-webkit script for Symbian
2529         https://bugs.webkit.org/show_bug.cgi?id=51509
2530
2531         Set the OUTPUT_DIR for Symbian to be the same as the source
2532         directory.
2533
2534         * Scripts/webkitdirs.pm:
2535
2536 2010-12-30  Martin Robinson  <mrobinson@igalia.com>
2537
2538         Reviewed by Darin Adler.
2539
2540         check-webkit-style should ignore NULL usage in calls to gtk_widget_style_get
2541         https://bugs.webkit.org/show_bug.cgi?id=51758
2542
2543         Add a check-webkit-style exception for gtk_widget_style_get and NULL usage.
2544
2545         * Scripts/webkitpy/style/checkers/cpp.py: Add the exception.
2546         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Add some tests for this.
2547
2548 2010-12-29  Patrick Gansterer  <paroga@webkit.org>
2549
2550         Unreviewed WinCE buildfix.
2551
2552         * WinCELauncher/main.cpp: Add missing include.
2553
2554 2010-12-29  Daniel Bates  <dbates@rim.com>
2555
2556         Reviewed by Darin Adler.
2557
2558         svn-apply updates date of wrong change log entry for a change log diff that
2559         contains two consecutive entries with the same author and date
2560         https://bugs.webkit.org/show_bug.cgi?id=46061
2561
2562         Fixes an issue where the date of the wrong change log entry may be modified.
2563         Moreover, changes fixChangeLogPatch() to move entries inserted earlier
2564         in a ChangeLog file to the top of the file.
2565
2566         Currently, fixChangeLogPatch() explicitly bails out and returns an unchanged
2567         diff when it detects that the diff inserts a change log entry earlier in a
2568         ChangeLog. It is unusual to land a patch that has such a deliberate ChangeLog
2569         change. With the advent of the commit-queue this functionality of bailing out
2570         and hence landing the patch as-is is harmful to the accuracy of the ChangeLog.
2571         Instead, we should always move the change log entry to the top of the ChangeLog file.
2572
2573         A side-effect of this change is that setChangeLogDateAndReviewer() now updates
2574         the date line of the correct change log entry in a ChangeLog diff.
2575
2576         * Scripts/VCSUtils.pm: Modified fixChangeLogPatch() to move entries inserted earlier to the top.
2577
2578         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
2579           Updated the following unit tests now that we move entries inserted earlier to the top:
2580           - "fixChangeLogPatch: New entry inserted in middle."
2581             (formerly named "fixChangeLogPatch: [no change] New entry inserted in middle.")
2582
2583           - "fixChangeLogPatch: New entry inserted earlier in the file, but after an entry with the same author and date."
2584             (formerly named "fixChangeLogPatch: [no change] New entry inserted earlier in the file, but after an entry with the same author and date.")
2585
2586         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatchThenSetChangeLogDateAndReviewer.pl: Added.
2587
2588 2010-12-29  Konstantin Tokarev  <annulen@yandex.ru>
2589
2590         Reviewed by Eric Seidel.
2591
2592         [Qt] Fixed compatibility with gold linker on X11 platforms
2593         https://bugs.webkit.org/show_bug.cgi?id=51700
2594
2595         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2596         Linked TestNetscapePlugin with libX11 on Unix platforms
2597
2598 2010-12-29  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>
2599
2600         Reviewed by Darin Adler.
2601
2602         Circular dependency in webkitpy.common.checkout.changelog module
2603         https://bugs.webkit.org/show_bug.cgi?id=50475
2604
2605         Remove automatic import of api.Checkout module when any checkout/
2606         submodule is imported (e.g.: when checkout.scm.Git is imported).
2607
2608         * Scripts/webkitpy/common/checkout/__init__.py:
2609
2610 2010-12-29  Martin Robinson  <mrobinson@igalia.com>
2611
2612         Reviewed by Ojan Vafai.
2613
2614         prepare-ChangeLog should support the -g option for specifying the git-commit
2615         https://bugs.webkit.org/show_bug.cgi?id=51708
2616
2617         Add a -g shortcut for the --git-commit prepare-ChangeLog option. This matches
2618         webkit-patch, though the exact meaning of the two options remain different.
2619
2620         * Scripts/prepare-ChangeLog: Add -g.
2621
2622 2010-12-29  Kent Hansen  <kent.hansen@nokia.com>
2623
2624         Reviewed by Simon Hausmann.
2625
2626         [Qt] Fix compilation with Qt in namespace
2627         https://bugs.webkit.org/show_bug.cgi?id=51701
2628
2629         * QtTestBrowser/webview.h:
2630
2631 2010-12-28  Daniel Bates  <dbates@rim.com>
2632
2633         Reviewed by Sam Weinig.
2634
2635         Substitute // MARK: for compiler-specific #pragma mark
2636         https://bugs.webkit.org/show_bug.cgi?id=51657
2637
2638         Fix future compilation warnings about "#pragma mark" on GTK+ bots by
2639         substituting  "// MARK:" for "#pragma mark", which provides
2640         analogous code-bookmarking functionality under Xcode.
2641
2642         Also, for consistency, we should substitute "// MARK:" for compiler-
2643         specific "#pragma mark" in the source files for the Mac port.
2644
2645         * DumpRenderTree/AccessibilityTextMarker.cpp:
2646         * DumpRenderTree/cf/WebArchiveDumpSupport.h:
2647         * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm:
2648         * DumpRenderTree/mac/ObjCController.m:
2649         * MiniBrowser/mac/AppDelegate.m:
2650         * MiniBrowser/mac/BrowserWindowController.m:
2651
2652 2010-12-28  Xan Lopez  <xlopez@igalia.com>
2653
2654         Reviewed by Eric Seidel.
2655
2656         Add --no-build option to run-sunspider
2657         https://bugs.webkit.org/show_bug.cgi?id=51658
2658
2659         * Scripts/run-sunspider: add --no-build flag to skip building
2660         phase.
2661
2662 2010-12-27  Daniel Bates  <dbates@rim.com>
2663
2664         Rubber-stamped by Martin Robinson.
2665
2666         Append the directory Tools/DumpRenderTree to the list of directories that
2667         do-webcore-rename should search so that it can rename DRT files and
2668         source code.
2669
2670         * Scripts/do-webcore-rename:
2671
2672 2010-12-27  Eric Seidel  <eric@webkit.org>
2673
2674         Reviewed by Adam Barth.
2675
2676         build-webkit should detect missing Java SDK and explain how to install it
2677         https://bugs.webkit.org/show_bug.cgi?id=51651
2678
2679         * Scripts/build-webkit:
2680
2681 2010-12-26  Martin Robinson  <mrobinson@igalia.com>
2682
2683         Reviewed by Daniel Bates.
2684
2685         [GTK] Add support for build-jsc
2686         https://bugs.webkit.org/show_bug.cgi?id=51625
2687
2688         Add GTK+ support to build-jsc now that building the jsc executable as
2689         a standalone target is easy.
2690
2691         * Scripts/build-jsc: Call buildGtkProject for the GTK+ case now.
2692         * Scripts/build-webkit: Pass in the proper target name to buildGtkProject.
2693         * Scripts/webkitdirs.pm: Actually process the project parameter in buildGtkProject
2694         and pass it along to buildAutotoolsProject.
2695
2696 2010-12-27  David Levin  <levin@chromium.org>
2697
2698         Reviewed by Eric Seidel.
2699
2700         check-webkit-style check for meaningless variable names in function declarations.
2701         https://bugs.webkit.org/show_bug.cgi?id=51523
2702
2703         * Scripts/webkitpy/style/checker.py: Exempted JavaScriptCore/jit/JITStubs.cpp
2704         from the new check and whitespace/parens because the syntax is unusual and
2705         produced a fair number of positives for these checks.
2706         * Scripts/webkitpy/style/checkers/cpp.py:
2707         (_convert_to_lower_with_underscores): Used as a canonical form for type names
2708         and parameter names when determining if the parameter name is useless.
2709         (_create_acronym): Used to check for redundant variable names in cases like "ExceptionCode ec"
2710         (Parameter.lower_with_underscores_name): Gives back the parameter name in a lower_with_underscore
2711         format.
2712         (_check_parameter_name_against_text):  Checks to see if the parameter name is in the
2713         text or an acronym of it.
2714         (check_function_definition): Checks function definitions for meaningless variable names.
2715         (process_line): Added call to check_function_definition.
2716         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2717         (CppFunctionsTest.test_convert_to_lower_with_underscores): Test for _convert_to_lower_with_underscores.
2718         (CppFunctionsTest.test_create_acronym): Test for _create_acronym.
2719         (CppFunctionsTest.test_check_parameter_against_text): Test for _check_parameter_against_text.
2720         (CppStyleTestBase.perform_single_line_lint): Removed the parameter name check
2721         because when only checking a snippet, there are a lot of bogus functions.
2722         (CppStyleTestBase.perform_multi_line_lint): Ditto and removed a bogus filter
2723         that I put there previously and just noticed.
2724         (WebKitStyleTest.test_parameter_names): Tests for the functionality -- both
2725         check_function_definition and process_line.
2726
2727 2010-12-27  Carlos Garcia Campos  <cgarcia@igalia.com>
2728
2729         Reviewed by Martin Robinson.
2730
2731         [GTK] Disable flash plugin in GtkLauncher when using gtk3
2732         https://bugs.webkit.org/show_bug.cgi?id=51591
2733
2734         Flash plugin uses gtk2 that is incompatible with gtk3 making
2735         webkit crash when it's built with gtk3.
2736
2737         * GtkLauncher/main.c:
2738         (main):
2739
2740 2010-12-25  Adam Barth  <abarth@webkit.org>
2741
2742         Reviewed by Eric Seidel.
2743
2744         Move ANGLE to Sources/ThirdParty
2745         https://bugs.webkit.org/show_bug.cgi?id=51605
2746
2747         * Scripts/build-webkit:
2748           - Point to the new ANGLE location.
2749
2750 2010-12-26  David Levin  <levin@chromium.org>
2751
2752         Reviewed by Eric Seidel.
2753
2754         check-webkit-style should be able to parse function declaration parameters.
2755         https://bugs.webkit.org/show_bug.cgi?id=51451
2756
2757         * Scripts/webkitpy/style/checkers/cpp.py:
2758         (Position.__init__): Holds simple position information (row, column).
2759         (Parameter.__init__): Holds information about a parameter.
2760         (SingleLineView.__init): Converts multiple lines into a single line for simpler searches.
2761         (SingleLineView.convert_column_to_row): Returns the original row given a column.
2762         (create_skeleton_parameters): Simplifies a parameter list for easier searching.
2763         (find_parameter_name_index): Finds where the parameter name is.
2764         (parameter_list): Generates the list of parameters for a function.
2765         (_FunctionState.begin): Added information to allow determining the parameters
2766         on demand.
2767         (_FunctionState.get_parameter_list): Returns a tuple of function parameters.
2768         (detect_functions): Improve function detection for operator functions and
2769         determine where the parameters end and pass that to _FunctionState.begin.
2770         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2771         (CppFunctionsTest.test_parameter): Verifies Parameter functionality.
2772         (CppFunctionsTest.test_single_line_view): Verifies SingleLineView functionality.
2773         (CppFunctionsTest.test_create_skeleton_parameters): Verifies create_skeleton_parameters.
2774         (CppFunctionsTest.test_find_parameter_name_index): Verifies find_parameter_name_index.
2775         (CppFunctionsTest.test_parameter_list): Does some minimal verification for parameter list.
2776         Much more thorough verification is done as part of FunctionDetectionTest.test_parameter_list.
2777         (FunctionDetectionTest.perform_function_detection): Added support for verifying
2778         the parameters found.
2779         (FunctionDetectionTest.test_function_declaration_detection): Added more function
2780         detection test to verify that we catch the operator functions.
2781         (FunctionDetectionTest.test_ignore_macros): Verify that function detection ignores macros.
2782         (FunctionDetectionTest.test_parameter_list): Added tests to verify the parameter parsing.
2783         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_bad_test_doesnt_break): Removed
2784         because the error. The test is about the bad function name. Fixing the name makes the test exactly like
2785         test_function_length_check_definition_severity1_for_test.
2786
2787 2010-12-25  Patrick Gansterer  <paroga@webkit.org>
2788
2789         Unreviewed WinCE buildfix after r74334.
2790
2791         * CMakeListsWinCE.txt:
2792
2793 2010-12-24  Sheriff Bot  <webkit.review.bot@gmail.com>
2794
2795         Unreviewed, rolling out r74632.
2796         http://trac.webkit.org/changeset/74632
2797         https://bugs.webkit.org/show_bug.cgi?id=51600
2798
2799         makes test-webkitpy hang forever on GTK (Requested by philn-tp
2800         on #webkit).
2801
2802         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
2803         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
2804
2805 2010-12-24  Ryuan Choi  <ryuan.choi@samsung.com>
2806
2807         Reviewed by Kenneth Rohde Christiansen.
2808
2809         [EFL] Screen doesn't be rendered when changing size of EWebLauncher
2810         https://bugs.webkit.org/show_bug.cgi?id=43528
2811
2812         Remove on_resize because ewk_view_fixed_layout_size_set should not be
2813         called on callback of EVAS_CALLBACK_RESIZE. As it change size of
2814         FrameView, rendering was ignored when _ewk_view_smart_calculate was
2815         called.
2816
2817         * EWebLauncher/main.c:
2818         (browserCreate):
2819
2820 2010-12-24  Eric Seidel  <eric@webkit.org>
2821
2822         Reviewed by Adam Barth.
2823
2824         webkit-patch (or a pre-commit hook) needs to prevent bad ChangeLog changes
2825         https://bugs.webkit.org/show_bug.cgi?id=28291
2826
2827         This is a start.  At least now webkit-patch will prompt when your ChangeLog looks questionable.
2828         We could do more advanced things, like parsing the ChangeLog (with changelog.py) and comparing that
2829         to strings with find in the diff.
2830         Since non-interactive always returns the default, this should cause patches with bad changelogs to fail on the commit-queue.
2831
2832         * Scripts/webkitpy/common/checkout/api.py:
2833         * Scripts/webkitpy/common/checkout/diff_parser.py:
2834         * Scripts/webkitpy/tool/steps/abstractstep.py:
2835         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
2836         * Scripts/webkitpy/tool/steps/validatechangelogs.py: Copied from Tools/Scripts/webkitpy/tool/steps/validatereviewer.py.
2837         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py: Copied from Tools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.
2838         * Scripts/webkitpy/tool/steps/validatereviewer.py:
2839
2840 2010-12-24  Dirk Pranke  <dpranke@chromium.org>
2841
2842         Reviewed by Kenneth Russell.
2843
2844         Modify new-run-webkit-tests to shut up and exit when all the threads
2845         are wedged so that test runs complete faster and we don't end up
2846         w/ enormous log files.
2847
2848         https://bugs.webkit.org/show_bug.cgi?id=51572
2849
2850         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
2851         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
2852
2853 2010-12-24  Eric Seidel  <eric@webkit.org>
2854
2855         Reviewed by David Levin.
2856
2857         commit-queue should better explain how it will re-open bugs and follow duplicate chains
2858         https://bugs.webkit.org/show_bug.cgi?id=51549
2859
2860         I've had multiple people ask me about the commit-queue's behavior
2861         regarding reporting flaky tests.  I figured it would be best to just
2862         have the queue explain itself in the bugs it files.
2863
2864         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2865         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2866
2867 2010-12-24  Shinichiro Hamaji  <hamaji@chromium.org>
2868
2869         Reviewed by Eric Seidel.
2870
2871         check-webkit-style: should ignore "wrong" namings in JavaScriptCore/qt
2872         https://bugs.webkit.org/show_bug.cgi?id=51467
2873
2874         * Scripts/webkitpy/style/checker.py:
2875         * Scripts/webkitpy/style/checker_unittest.py:
2876
2877 2010-12-23  Adam Barth  <abarth@webkit.org>
2878
2879         Rubber-stamped by Eric Seidel.
2880
2881         Move JavaScriptGlue into Sources
2882         https://bugs.webkit.org/show_bug.cgi?id=51583
2883
2884         These tools refer to JavaScriptGlue and need to be updated to its new
2885         location.
2886
2887         * Scripts/build-webkit:
2888         * Scripts/do-file-rename:
2889         * Scripts/do-webcore-rename:
2890         * Scripts/webkitpy/common/config/build.py:
2891         * Scripts/webkitpy/common/config/build_unittest.py:
2892
2893 2010-12-23  Lucas Forschler  <lforschler@apple.com>
2894
2895         Reviewed by Eric Seidel.
2896
2897         Bug 51539 - update iexploder scripts to point to new location
2898
2899         * Scripts/run-iexploder-tests:
2900         * Scripts/update-iexploder-cssproperties:
2901
2902 2010-12-23  Evan Martin  <evan@chromium.org>
2903
2904         Reviewed by Ryosuke Niwa.
2905
2906         [chromium] LayoutTestController warning in float->int conversion
2907         https://bugs.webkit.org/show_bug.cgi?id=51553
2908
2909         Rather than reading an int, converting to a float, then getting a compiler
2910         warning on passing the float to something that expects an int, instead
2911         just pass around ints.
2912
2913         No tests, fixes a compiler warning.
2914
2915         * DumpRenderTree/chromium/LayoutTestController.cpp:
2916         (parsePageSizeParameters):
2917         (LayoutTestController::pageNumberForElementById):
2918         (LayoutTestController::numberOfPages):
2919
2920 2010-12-23  Lucas Forschler  <lforschler@apple.com>
2921
2922         Reviewed by Darin Adler.
2923
2924         Bug 51537 - iexploder needs cleanup
2925
2926         * iExploder/htdocs: Removed.
2927         * iExploder/htdocs/config.rb: Removed.
2928         * iExploder/htdocs/cssproperties.in: Removed.
2929         * iExploder/htdocs/cssvalues.in: Removed.
2930         * iExploder/htdocs/htmlattrs.in: Removed.
2931         * iExploder/htdocs/htmltags.in: Removed.
2932         * iExploder/htdocs/htmlvalues.in: Removed.
2933         * iExploder/htdocs/iexploder.cgi: Removed.
2934         * iExploder/htdocs/iexploder.rb: Removed.
2935         * iExploder/htdocs/index.html: Removed.
2936         * iExploder/htdocs/webserver.rb: Removed.
2937         * iExploder/iexploder-1.7.2/output: Removed.
2938         * iExploder/tools: Removed.
2939         * iExploder/tools/lasthit.rb: Removed.
2940         * iExploder/tools/osx_last_crash.rb: Removed.
2941         * iExploder/tools/showtest.rb: Removed.
2942
2943 2010-12-23  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
2944
2945         Reviewed by Kenneth Rohde Christiansen.
2946
2947         [EFL] Make 'single' the default backing store in EWebLauncher
2948         https://bugs.webkit.org/show_bug.cgi?id=51534
2949
2950         'single' is the simplest backing store and the one intended to be the
2951         default in the test browser. By mistake the tiled backing store was
2952         left as default in r72617.
2953
2954         * EWebLauncher/main.c:
2955         (browserCreate): ditto.
2956
2957 2010-12-23  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
2958
2959         Reviewed by Kenneth Rohde Christiansen.
2960
2961         [EFL] Subject: [webkit 4/4] [EFL] Remove non-sense workaround
2962         https://bugs.webkit.org/show_bug.cgi?id=51533
2963
2964         There's no point in concatenating env("HOME") with "blah", so remove
2965         option from EWebLauncher.
2966
2967         * EWebLauncher/main.c:
2968         (main): ditto.
2969
2970 2010-12-23  Ilya Tikhonovsky  <loislo@chromium.org>
2971
2972         Reviewed by Eric Seidel.
2973
2974         Web Inspector: chromium: inspector's tests are quite slow especially at windows(Debug).
2975
2976         Almost all inspector's tests become flaky on chromium Win(dbg) after switching to DRT.
2977         I just discovered that we have two additional GC runs per each WebViewHost.
2978         Test_shell had no such calls.
2979         These gc runs eat 15% of cpu time.
2980
2981         https://bugs.webkit.org/show_bug.cgi?id=51479
2982
2983         * DumpRenderTree/chromium/WebViewHost.cpp:
2984         (WebViewHost::~WebViewHost):
2985
2986 2010-12-22  Dirk Pranke  <dpranke@chromium.org>
2987
2988         Reviewed by Ojan Vafai.
2989
2990         This change splits out the TestRunner class into its own file.
2991         When we fork the code for message passing, we will create a new
2992         TestRunner, and this change will allow that to be more modular.
2993
2994         While we're at it, split out TestInput and ResultSummary into
2995         their own files, to reduce the size of run_webkit_tests to
2996         something more managable.
2997
2998         https://bugs.webkit.org/show_bug.cgi?id=51092
2999
3000         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
3001         * Scripts/webkitpy/layout_tests/layout_package/result_summary.py:
3002         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
3003         * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
3004         * Scripts/webkitpy/layout_tests/layout_package/test_input.py:
3005         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3006         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3007
3008  2010-12-22  Dirk Pranke  <dpranke@chromium.org>
3009
3010         Reviewed by Ojan Vafai.
3011
3012         nrwt multiprocessing - start over, prepare to fork the code
3013
3014         This code cleans up the signatures and implementation of the
3015         TestRunner class so we can easily fork it to run either the
3016         stable implementation or the new, unstable message-passing
3017         implementation. The two variants will have different
3018         implementations of the run_tests() method. We will switch
3019         between the two based on the setting for the '--worker-model'
3020         switch. We rename the two currently valid values to 'old-inline'
3021         and 'old-threads'.
3022
3023         https://bugs.webkit.org/show_bug.cgi?id=51081
3024
3025         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3026         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3027
3028 2010-12-22  Victor Wang  <victorw@chromium.org>
3029
3030         Reviewed by Darin Fisher.
3031
3032         [Chromium] Update chromium archive test result url in rebaseline script.
3033
3034         https://bugs.webkit.org/show_bug.cgi?id=51503
3035
3036         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
3037
3038 2010-12-22  Lucas Forschler  <lforschler@apple.com>
3039
3040         Reviewed by Alice Liu.
3041
3042         <rdar://problem/8633222> record-memory-win needs to record memory used by the webprocess.
3043         Verified on Chrome, Safari, and IE.
3044         With this change, we will record memory from a parent browser window and all child processes.
3045
3046         * record-memory-win/main.cpp:
3047         (ProcessArgs):
3048         (PrintUsage):
3049         (getMemoryInfo):
3050         (printProcessInfo):
3051         (evalProcesses):
3052         (UseImage):
3053         (QueryContinuously):
3054         (ElapsedTime):
3055
3056 2010-12-22  Lucas Forschler  <lforschler@apple.com>
3057
3058         Unreviewed rollout r74489, because it was missing changelog.
3059
3060         * record-memory-win/main.cpp:
3061
3062 2010-12-22  Ryosuke Niwa  <rniwa@webkit.org>
3063
3064         Adding myself as a reviewer.
3065
3066         * Scripts/webkitpy/common/config/committers.py:
3067
3068 2010-12-22  Andrew Scherkus  <scherkus@chromium.org>
3069
3070         Unreviewed.  Adding myself to committers.py.
3071
3072         * Scripts/webkitpy/common/config/committers.py:
3073
3074 2010-12-22  Ariya Hidayat  <ariya@sencha.com>
3075
3076         Reviewed by Kenneth Rohde Christiansen.
3077
3078         TestNetscapePlugIn should use #if defined
3079         https://bugs.webkit.org/show_bug.cgi?id=51471
3080
3081         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3082         (NP_Initialize):
3083         (NPP_New):
3084
3085 2010-12-22  Ilya Tikhonovsky  <loislo@chromium.org>
3086
3087         Reviewed by Yury Semikhatsky.
3088
3089         Web Inspector: [chromium] DRT inspector layout tests are flaky in debug.
3090
3091         DevTools window should be closed explicitly because it has custom deinitialization code.
3092
3093         https://bugs.webkit.org/show_bug.cgi?id=50722
3094
3095         * DumpRenderTree/chromium/TestShell.cpp:
3096         (TestShell::closeRemainingWindows):
3097
3098 2010-12-22  David Levin  <levin@chromium.org>
3099
3100         Reviewed by Shinichiro Hamaji.
3101
3102         check-webkit-style shouldn't complaint about underscores in variables in objective C files.
3103         https://bugs.webkit.org/show_bug.cgi?id=51452
3104
3105         * Scripts/webkitpy/style/checkers/cpp.py:
3106         (_FileState.__init__): Added the information to determine if a file is C or Objective C.
3107         Using the file extension if possible but falling back to the file contents if we have a header file.
3108         (_FileState.is_objective_c): Determine if we have an Objective C by examining the file contents if needed.
3109         (_FileState.is_c_or_objective_c):
3110         (check_using_std): Changed to using _FileState to determine the file type.
3111         (check_max_min_macros): Ditto.
3112         (check_for_null): Ditto.
3113         (check_style): Changed the parameters to various calls since they now need _FileState
3114         to determine the file type.
3115         (check_language): Added the file_state parameter so it could be passed
3116         to check_identifier_name_in_declaration.
3117         (check_identifier_name_in_declaration): Don't warn about underscores in variables if
3118         this is an Objective C file.
3119         (_process_lines): Added information for the _FileState constructor (and moved the
3120         call to a place that had the information).
3121         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3122         (CppFunctionsTest.test_is_c_or_objective_c): Changed the tests to use FileState and exercise
3123         its functionality.
3124         (WebKitStyleTest.test_names): Add tests for underscores in Objective C files.
3125
3126 2010-12-21  Andy Estes  <aestes@apple.com>
3127
3128         Reviewed by Mark Rowe.
3129
3130         Do not build non-Intel architectures for WebKit2-related projects.
3131         https://bugs.webkit.org/show_bug.cgi?id=51440
3132
3133         * MiniBrowser/Configurations/Base.xcconfig: Only build for i386 and x86_64.
3134         * TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
3135         * WebKitTestRunner/Configurations/Base.xcconfig: Ditto.
3136
3137 2010-12-21  Mihai Parparita  <mihaip@chromium.org>
3138
3139         Reviewed by Darin Fisher.
3140
3141         [Chromium] Rename WebThemeEngine/ControlDRT to WebThemeEngine/ControlDRTWin
3142         https://bugs.webkit.org/show_bug.cgi?id=51406
3143
3144         Rename WebThemeControlDRT to WebThemeControlDRTWin and WebThemeEngineDRT
3145         to WebThemeEngineDRTWin and update references everywhere.
3146
3147         * DumpRenderTree/DumpRenderTree.gypi:
3148         * DumpRenderTree/chromium/TestShellWin.cpp:
3149         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRT.cpp.
3150         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRT.h.
3151         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRT.cpp.
3152         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRT.h.
3153
3154 2010-12-21  Anders Carlsson  <andersca@apple.com>
3155
3156         Reviewed by John Sullivan.
3157
3158         Clicking missing plug-in text does not show a sheet
3159         https://bugs.webkit.org/show_bug.cgi?id=51403
3160
3161         Update for changes to the WebPageUIClient.
3162
3163         * MiniBrowser/mac/BrowserWindowController.m:
3164         (-[BrowserWindowController awakeFromNib]):
3165         * WebKitTestRunner/TestController.cpp:
3166         (WTR::createOtherPage):
3167         (WTR::TestController::initialize):
3168
3169 2010-12-21  Eric Seidel  <eric@webkit.org>
3170
3171         Reviewed by Adam Barth.
3172
3173         commit-queue will report constant failures as flaky if other tests flake
3174         https://bugs.webkit.org/show_bug.cgi?id=51272
3175
3176         This patch just removes functionality and adds testing.
3177         Previously we attempted to report flaky tests when we had
3178         two different tests fail in a row.  However, since we stop
3179         running the tests at the first failure, our code was wrong in
3180         trying to determine flakiness from the incomplete runs.
3181
3182         Originally I posted an alternate patch:
3183         https://bug-51272-attachments.webkit.org/attachment.cgi?id=77078
3184         which fixed our flaky logic in this case, however it was decided
3185         that that patch would be too difficult to maintain, so now
3186         I'm just removing the broken logic.
3187
3188         This will dramatically cut-down on our flaky-test false positives
3189         at the (small) cost of the queues being unable to report
3190         any flakiness if the tree is very flaky.  (With at least one test
3191         flaking on every run, we'll never report failures anymore.)  I think
3192         this is a tradeoff worth making.
3193
3194         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3195         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3196
3197 2010-12-20  Eric Seidel  <eric@webkit.org>
3198
3199         Reviewed by Adam Barth.
3200
3201         commit-queue wrongly rejects patches when it can't update itself
3202         https://bugs.webkit.org/show_bug.cgi?id=46636
3203
3204         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3205         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3206         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3207
3208 2010-12-20  Adam Barth  <abarth@webkit.org>
3209
3210         Move web sites to Websites directory
3211         https://bugs.webkit.org/show_bug.cgi?id=51323
3212
3213         Update references to BugsSite to point to the new location.
3214
3215         This patch was never officially reviewed (because it was too large to
3216         upload to bugs.webkit.org), but it was discussed on webkit-dev and Mark
3217         Rowe gave me the green light.
3218
3219         * Scripts/old-run-webkit-tests:
3220         * Scripts/webkitpy/common/config/build.py:
3221         * Scripts/webkitpy/common/config/build_unittest.py:
3222         * Scripts/webkitpy/common/prettypatch.py:
3223         * Scripts/webkitpy/layout_tests/port/base.py:
3224         * Scripts/webkitpy/style/main.py:
3225
3226 2010-12-20  Adrienne Walker  <enne@google.com>
3227
3228         Unreviewed. Adding myself to the list of committers.
3229
3230         * webkitpy/common/config/committers.py:
3231
3232 2010-12-20  Mark Rowe  <mrowe@apple.com>
3233
3234         Reviewed by Dan Bernstein.
3235
3236         <rdar://problem/8757601> Don't install header files in to the Resources directory.
3237
3238         * Scripts/check-for-inappropriate-files-in-framework: Don't allow .h files in the
3239         Resources directory.
3240
3241 2010-12-20  Eric Seidel  <eric@webkit.org>
3242
3243         Reviewed by Adam Barth.
3244
3245         commit-queue should include bot id when attaching failure diffs
3246         https://bugs.webkit.org/show_bug.cgi?id=51280
3247
3248         This is a tiny change to include the bot id in the name of the attachment.
3249         Most of this diff is just changing the unit test expectations
3250         now that I hid the comment printing when the comment is None.
3251
3252         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3253         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3254         * Scripts/webkitpy/tool/commands/upload_unittest.py:
3255         * Scripts/webkitpy/tool/mocktool.py:
3256
3257 2010-12-20  Jeff Miller  <jeffm@apple.com>
3258
3259         Reviewed by Dan Bernstein.
3260
3261         Tools/vcbin/midl.exe needs to be rebuilt
3262         https://bugs.webkit.org/show_bug.cgi?id=51347
3263
3264         * vcbin/midl.exe: Rebuilt.
3265
3266 2010-12-20  David Levin  <levin@chromium.org>
3267
3268         Reviewed by Ariya Hidayat.
3269
3270         .gitignore and webkit-tools-completion.sh have references to WebKitTools that should be Tools.
3271         https://bugs.webkit.org/show_bug.cgi?id=51343
3272
3273         Follow up from the WebKitTools -> Tools rename.
3274
3275         * Scripts/webkit-tools-completion.sh:
3276
3277 2010-12-20  Cosmin Truta  <ctruta@chromium.org>
3278
3279         Reviewed by James Robinson.
3280
3281         new-run-webkit-tests ignores trailing EOL differences in text tests
3282         https://bugs.webkit.org/show_bug.cgi?id=36983
3283
3284         Changed the handling of new-line characters within new-run-webkit-tests
3285         to match old-run-webkit-tests.  Differences in leading and trailing empty
3286         lines in text expectation files are no longer ignored.
3287
3288         * Scripts/webkitpy/layout_tests/port/base.py:
3289         * Scripts/webkitpy/layout_tests/port/test.py:
3290         Added unit tests.  Removed old duplicate unit test entries.
3291         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
3292
3293 2010-12-20  David Levin  <levin@chromium.org>
3294
3295         Reviewed by Shinichiro Hamaji.
3296
3297         check-webkit-style should detect function declarations (and trivial functions).
3298         https://bugs.webkit.org/show_bug.cgi?id=51303
3299
3300         * Scripts/webkitpy/style/checkers/cpp.py:
3301         (_FunctionState.begin): Add is_declaration and changed the line count
3302         start to begin at -1 (which will keep the results consistent, since
3303         the starting line number passed in is one less in this change).
3304         (detect_functions): changed function detection to now catch trivial
3305         functions and declarations.
3306         (check_pass_ptr_usage): Don't check for Pass*Ptr on the first line
3307         of the function as this may look at return values (when processing
3308         a declaration).
3309         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3310         (FunctionDetectionTest.perform_function_detection): Basic mechanics
3311         of testing the function detection.
3312         (FunctionDetectionTest.test_basic_function_detection): Test a simple
3313         function.
3314         (FunctionDetectionTest.test_function_declaration_detection): Test a
3315         declaration.
3316         (FunctionDetectionTest.test_non_functions): A test case for a case
3317         that caused the code to fail due to the { being in quotes.
3318         (PassPtrTest.test_pass_ref_ptr_return_value): Added some more test
3319         cases to help catch false alarms for return values.
3320         (PassPtrTest.test_pass_ref_ptr_member_variable): Ensure that
3321         we don't get false alarms for member variables either.
3322
3323 2010-12-20  Ryuan Choi  <ryuan.choi@samsung.com>
3324
3325         Reviewed by Antonio Gomes.
3326
3327         [CMAKE] Rename WEBKITTOOLS_DIR to TOOLS_DIR
3328         https://bugs.webkit.org/show_bug.cgi?id=51319
3329
3330         * CMakeListsEfl.txt:
3331
3332 2010-12-18  Adam Barth  <abarth@webkit.org>
3333
3334         Reviewed by Sam Weinig.
3335
3336         Move WebKitExamplePlugins to Examples
3337         https://bugs.webkit.org/show_bug.cgi?id=51291
3338
3339         * Scripts/webkitpy/common/config/build.py:
3340
3341 2010-12-17  Csaba Osztrogonác  <ossy@webkit.org>
3342
3343         Unreviewed Qt buildfix after r74301.
3344
3345         Rename WebKitTools to Tools
3346         https://bugs.webkit.org/show_bug.cgi?id=49861
3347
3348         * MiniBrowser/DerivedSources.pro:
3349         * MiniBrowser/qt/MiniBrowser.pro:
3350
3351 2010-12-17  Dan Bernstein  <mitz@apple.com>
3352
3353         Reviewed by Simon Fraser.
3354
3355         Rename WebKitTools to Tools
3356         https://bugs.webkit.org/show_bug.cgi?id=49861
3357
3358         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3359         * CodeCoverage/README:
3360         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3361         (WebCore::DumpRenderTree::initializeFonts):
3362         * EWSTools/start-commit-queue.sh:
3363         * EWSTools/start-queue.sh:
3364         * GNUmakefile.am:
3365         * MIDLWrapper/MIDLWrapper.cpp:
3366         (wmain):
3367         * MiniBrowser/qt/MiniBrowser.pro:
3368         * Scripts/build-api-tests:
3369         * Scripts/build-dumprendertree:
3370         * Scripts/build-webkit:
3371         * Scripts/build-webkittestrunner:
3372         * Scripts/generate-coverage-data:
3373         * Scripts/old-run-webkit-tests:
3374         * Scripts/run-api-tests:
3375         * Scripts/run-iexploder-tests:
3376         * Scripts/run-javascriptcore-tests:
3377         * Scripts/run-mangleme-tests:
3378         * Scripts/run-sunspider:
3379         * Scripts/run-webkit-websocketserver:
3380         * Scripts/sunspider-compare-results:
3381         * Scripts/test-webkitperl:
3382         * Scripts/test-webkitpy:
3383         * Scripts/update-iexploder-cssproperties:
3384         * Scripts/update-webkit:
3385         * Scripts/update-webkit-localizable-strings:
3386         * Scripts/webkitdirs.pm:
3387         * Scripts/webkitpy/common/checkout/scm.py:
3388         * Scripts/webkitpy/common/checkout/scm_unittest.py:
3389         * Scripts/webkitpy/common/config/committervalidator.py:
3390         * Scripts/webkitpy/common/config/committervalidator_unittest.py:
3391         * Scripts/webkitpy/common/config/ports.py:
3392         * Scripts/webkitpy/common/config/ports_unittest.py:
3393         * Scripts/webkitpy/common/system/logutils_unittest.py:
3394         * Scripts/webkitpy/common/system/ospath_unittest.py:
3395         * Scripts/webkitpy/layout_tests/port/chromium.py:
3396         * Scripts/webkitpy/layout_tests/port/config.py:
3397         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
3398         * Scripts/webkitpy/layout_tests/port/http_server.py:
3399         * Scripts/webkitpy/layout_tests/port/test.py:
3400         * Scripts/webkitpy/style/checker.py:
3401         * Scripts/webkitpy/style/checker_unittest.py:
3402         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
3403         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3404         * Scripts/webkitpy/tool/steps/steps_unittest.py:
3405         * WebKitTestRunner/DerivedSources.pro:
3406         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
3407         (WTR::activateFonts):
3408         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3409         * wx/build/build_utils.py:
3410
3411 2010-12-16  Antonio Gomes  <agomes@rim.com>
3412
3413         Reviewed by Martin Robinson.
3414
3415         Settings::editingBehaviorType() incorrectly returns mac for the gtk build when running tests
3416         https://bugs.webkit.org/show_bug.cgi?id=51163
3417
3418         Since GTK+'s default editing behavior was changed to UNIX in r70975 (see webkitwebsettings.cpp),
3419         GTK+'s DRT should also reset to UNIX after each test execution.
3420
3421         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3422         (resetDefaultsToConsistentValues):
3423
3424 2010-12-17  David Levin  <levin@chromium.org>
3425
3426         Reviewed by Eric Seidel.
3427
3428         check-webkit-style should understand WTF #include guards
3429         https://bugs.webkit.org/show_bug.cgi?id=44911
3430
3431         * Scripts/webkitpy/style/checkers/cpp.py:
3432         (get_header_guard_cpp_variable): modify to suggest the WTF style
3433         of header guard when appropriate.
3434         (check_for_header_guard): handle multiple return values from
3435         get_header_guard_cpp_variable
3436         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3437         (CppStyleTest.test_build_header_guard): Added tests for the WTF
3438         header style.
3439
3440 2010-12-16  David Levin  <levin@chromium.org>
3441
3442         Reviewed by Eric Seidel.
3443
3444         test-webkitpy: unittest for the xml.py checker displays a decprecation warning.
3445         https://bugs.webkit.org/show_bug.cgi?id=51210
3446
3447         The error only shows up when using python 2.6 or later.
3448
3449         * Scripts/webkitpy/style/checkers/xml.py: Replace the usage of
3450         the decprecated field error,message with something equivalent.
3451
3452 2010-12-16  Mihai Parparita  <mihaip@chromium.org>
3453
3454         Reviewed by Eric Seidel.
3455
3456         Add --exit-after-n-failures/crashes to NRWT
3457         https://bugs.webkit.org/show_bug.cgi?id=51160
3458
3459         Abort test run (in a similar way to how control-C is handled) when
3460         --exit-after-n-failures/crashes-or-timeouts are passed and we've reached
3461         that number of unexpected failures/crashes/timeouts.
3462
3463         * Scripts/webkitpy/layout_tests/port/test.py:
3464         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3465         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3466
3467 2010-12-16  David Levin  <levin@chromium.org>
3468
3469         Reviewed by Shinichiro Hamaji.
3470
3471         check-webkit-style unit tests has some duplicate boilerplate code.
3472         https://bugs.webkit.org/show_bug.cgi?id=49519
3473
3474         * Scripts/webkitpy/style/checkers/cpp.py:
3475         (update_include_state): Replaced the "io" parameter with the global
3476         configuration _unit_test_config. This allowed not calling into
3477         functions at a low level and also not plumbing through the injection
3478         information through many levels of code.
3479         (check_for_include_what_you_use): Ditto.
3480         (process_file_data): Added the ability to set up the unit test config
3481         to allow for injection.
3482         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3483         (ErrorCollector.__init__): Added support for having a filter for errors.
3484         (ErrorCollector.__call__): Ditto.
3485         (CppStyleTestBase.process_file_data): Added the ability to set unit_test_config.
3486         (CppStyleTestBase.perform_lint): Consolidated logic for the perform functions.
3487         (CppStyleTestBase.perform_single_line_lint): Replace specific calls to
3488         functions in the cpp.py with generic processing and a filter that
3489         indicates what errors should be kept.
3490         (CppStyleTestBase.perform_multi_line_lint): Ditto.
3491         (CppStyleTestBase.perform_language_rules_check): Ditto.
3492         (CppStyleTestBase.perform_function_lengths_check): Ditto.
3493         (CppStyleTestBase.perform_pass_ptr_check): Ditto.
3494         (CppStyleTestBase.perform_include_what_you_use): Ditto.
3495         (CppStyleTest.test_multi_line_comments): Added another
3496         error message which applies to the test case.
3497         (CppStyleTest.test_spacing_for_binary_ops): Fixed test
3498         to not have config.h, since it is processed as a header file.
3499         (CppStyleTest.test_static_or_global_stlstrings): Fixed variable name
3500         style and indentation in checked code.
3501         (OrderOfIncludesTest.test_check_preprocessor_in_include_section):
3502         Fixed line number.
3503         (NoNonVirtualDestructorsTest.test_multi_line_declaration_with_error):
3504         Ditto.
3505
3506 2010-12-15  Sheriff Bot  <webkit.review.bot@gmail.com>
3507
3508         Unreviewed, rolling out r74136.
3509         http://trac.webkit.org/changeset/74136
3510         https://bugs.webkit.org/show_bug.cgi?id=51135
3511
3512         r74136 breaks chromium canary bots because some tests are not
3513         rebaselined correctly to resolve EOL differences (Requested by
3514         jianli on #webkit).
3515
3516         * Scripts/webkitpy/layout_tests/port/base.py:
3517         * Scripts/webkitpy/layout_tests/port/test.py:
3518         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
3519
3520 2010-12-15  Adam Roben  <aroben@apple.com>
3521
3522         Teach check-webkit-style to check .vcproj and .vsprops files for XML
3523         syntax errors
3524
3525         Fixes <http://webkit.org/b/51103> check-webkit-style should check for
3526         XML syntax errors in .vcproj/.vsprops files
3527
3528         Reviewed by Dave Levin.
3529
3530         * Scripts/webkitpy/style/checker.py: Added lists of file extensions
3531         that should be treated as XML and that should be allowed to contain
3532         carriage returns. (These lists happen to be identical currently.)
3533         (FileType): Added a new XML type.
3534         (CheckerDispatcher.should_check_and_strip_carriage_returns): Added.
3535         Just does a simple file extension check.
3536         (CheckerDispatcher._file_type): Added a case for XML files.
3537         (CheckerDispatcher._create_checker): Ditto. We use XMLChecker for XML
3538         files (surprise!).
3539         (StyleProcessor.process): Ask the dispatcher whether we should pass the
3540         lines through the carriage checker.
3541
3542         * Scripts/webkitpy/style/checker_unittest.py:
3543         (CheckerDispatcherCarriageReturnTest.test_should_check_and_strip_carriage_returns):
3544         Added. Checks a few file names to see if carriage returns are allowed
3545         or not.
3546         (CheckerDispatcherDispatchTest.assert_checker_xml): Added. Similar to
3547         other assert_checker_* functions.
3548         (CheckerDispatcherDispatchTest.test_xml_paths): Added. Similar to other
3549         test_*_paths functions.
3550         (CheckerDispatcherDispatchTest.test_xml_paths): Added. Similar to other
3551         test_*_paths functions.
3552         (CheckerDispatcherDispatchTest.test_none_paths): Removed the vcproj
3553         file from this test case, as vcproj files now have a type.
3554         (StyleProcessor_CodeCoverageTest.MockDispatcher.should_check_and_strip_carriage_returns):
3555         Added. Similar to the other should_* functions.
3556         (StyleProcessor_CodeCoverageTest.test_process__carriage_returns_not_stripped):
3557         Added. Checks that carriage returns aren't checked for or stripped for
3558         allowed files.
3559
3560         * Scripts/webkitpy/style/checkers/xml.py: Added.
3561         (XMLChecker.__init__): Simple init method.
3562         (XMLChecker.check): Pass each line through the expat parser, and record
3563         a style error for any errors thrown by the parser.
3564
3565         * Scripts/webkitpy/style/checkers/xml_unittest.py: Added.
3566         (XMLCheckerTest.assert_no_error): Checks that the given XML does not
3567         produce a style error.
3568         (XMLCheckerTest.assert_error): Checks that the given XML produces an
3569         error of the given category on the given line.
3570         (XMLCheckerTest.mock_handle_style_error): Does nothing. Used for
3571         checking that the XMLChecker constructor works properly.
3572         (XMLCheckerTest.test_conflict_marker): Tests that conflict markers
3573         cause a style error (see, e.g., r73887).
3574         (XMLCheckerTest.test_extra_closing_tag): Tests that extra closing tags
3575         cause a style error (see, e.g., r73773).
3576         (XMLCheckerTest.test_init): Tests that the XMLChecker constructor works
3577         properly.
3578         (XMLCheckerTest.test_missing_closing_tag): Tests that missing closing
3579         tags cause a style error (see, e.g., r72795).
3580         (XMLCheckerTest.test_no_error): Tests that valid XML does not cause a
3581         style error.
3582
3583 2010-12-15  Lucas Forschler  <lforschler@apple.com>
3584
3585         Reviewed by Stephanie Lewis.
3586
3587         https://bugs.webkit.org/show_bug.cgi?id=51117
3588         Add a new leopard test bot
3589         really really commit to trunk this time.
3590
3591         * BuildSlaveSupport/build.webkit.org-config/config.json:
3592
3593 2010-12-15  Sam Weinig  <sam@webkit.org>
3594
3595         Reviewed by Anders Carlsson.
3596
3597         WebKit2: Can't add files to an <input type=file>
3598         https://bugs.webkit.org/show_bug.cgi?id=51087
3599
3600         * MiniBrowser/mac/BrowserWindowController.m:
3601         (runOpenPanel):
3602         (-[BrowserWindowController awakeFromNib]):
3603         Add simple implementation of runOpenPanel callback.
3604
3605         * MiniBrowser/win/BrowserView.cpp:
3606         (BrowserView::create):
3607         * WebKitTestRunner/TestController.cpp:
3608         (WTR::createOtherPage):
3609         (WTR::TestController::initialize):
3610         Stub out runOpenPanel callback.
3611
3612 2010-12-14  Eric Seidel  <eric@webkit.org>
3613
3614         Reviewed by Adam Barth.
3615
3616         commit-queue should upload failure diffs when tests flake
3617         https://bugs.webkit.org/show_bug.cgi?id=51051
3618
3619         To make this testable I needed to pipe FileSystem down onto tool.
3620         We've wanted it there for a long time anyway.
3621
3622         This patch is kinda a big hack.  But we don't have a nice
3623         way to read results.html files.  I think this will need further
3624         revision before this code actually feels clean.
3625
3626         As part of testing this change, I had to make MockBugzilla.create_bug
3627         actually return an id (like it should) which required updating
3628         a few other unit test results (for the better).
3629
3630         The results_matching_keys change in layouttestresults/rebasline
3631         was an alternate path which I decided not to use in the end, but
3632         I left the change as it seemed an improvement.
3633
3634         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3635         * Scripts/webkitpy/common/net/layouttestresults.py:
3636         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3637         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3638         * Scripts/webkitpy/tool/commands/queues.py:
3639         * Scripts/webkitpy/tool/commands/rebaseline.py:
3640         * Scripts/webkitpy/tool/main.py:
3641         * Scripts/webkitpy/tool/mocktool.py:
3642
3643 2010-12-15  Cosmin Truta  <ctruta@chromium.org>
3644
3645         Reviewed by James Robinson.
3646
3647         new-run-webkit-tests ignores trailing EOL differences in text tests
3648         https://bugs.webkit.org/show_bug.cgi?id=36983
3649
3650         Changed the handling of new-line characters within new-run-webkit-tests
3651         to match old-run-webkit-tests.  Differences in leading and trailing empty
3652         lines in text expectation files are no longer ignored.
3653
3654         * Scripts/webkitpy/layout_tests/port/base.py:
3655         * Scripts/webkitpy/layout_tests/port/test.py:
3656         Added unit tests.  Removed old duplicate unit test entries.
3657         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
3658
3659 2010-12-15  Ojan Vafai  <ojan@chromium.org>
3660
3661         Reviewed by Adam Barth.
3662
3663         make status-bubble white-space:nowrap so we can measure it's width without wrapping
3664         https://bugs.webkit.org/show_bug.cgi?id=51149
3665
3666         * QueueStatusServer/templates/statusbubble.html:
3667
3668 2010-12-15  Ojan Vafai  <ojan@chromium.org>
3669
3670         Reviewed by Adam Barth.
3671
3672         have the statusbubble postMessage it's metrics so that embedders can properly size the iframe
3673         https://bugs.webkit.org/show_bug.cgi?id=51125
3674
3675         * QueueStatusServer/templates/statusbubble.html:
3676
3677 2010-12-15  Darin Adler  <darin@apple.com>
3678
3679         * Scripts/webkitpy/common/net/buildbot: Added property svn:ignore.
3680
3681 2010-12-15  Sheriff Bot  <webkit.review.bot@gmail.com>
3682
3683         Unreviewed, rolling out r74117.
3684         http://trac.webkit.org/changeset/74117
3685         https://bugs.webkit.org/show_bug.cgi?id=51113
3686
3687         This broke the GTK1 build. (Requested by mrobinson on
3688         #webkit).
3689
3690         * Scripts/webkitdirs.pm:
3691
3692 2010-12-15  Amruth Raj  <amruthraj@motorola.com> and Ravi Kasibhatla  <ravi.kasibhatla@motorola.com>
3693
3694         Reviewed by Martin Robinson.
3695
3696         Change generate-forwarding-headers.pl for GTK port usage
3697         (https://bugs.webkit.org/show_bug.cgi?id=37369)
3698
3699         * Scripts/webkitdirs.pm: Added changes to build webkit2 for GTK port using build-webkit script.
3700
3701 2010-12-14  Kent Tamura  <tkent@chromium.org>
3702
3703         Reviewed by Jian Li.
3704
3705         [DRT/Chromium] Remove another unnecessary error message
3706         https://bugs.webkit.org/show_bug.cgi?id=51083
3707
3708         * DumpRenderTree/chromium/WebViewHost.cpp:
3709         (WebViewHost::didInvalidateRect):
3710
3711 2010-12-14  Lucas Forschler  <lforschler@apple.com>
3712
3713         Reviewed by Stephanie Lewis.
3714
3715         Add a new Leopard Debug Test WK2 Bot
3716
3717         * BuildSlaveSupport/build.webkit.org-config/config.json:
3718
3719 2010-12-14  Ojan Vafai  <ojan@chromium.org>
3720
3721         Fix python unittests after http://trac.webkit.org/changeset/74070.
3722
3723         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
3724
3725 2010-12-14  Kent Tamura  <tkent@chromium.org>
3726
3727         Reviewed by Jian Li.
3728
3729         [DRT/Chromium] Remove a unnecessary error message
3730         https://bugs.webkit.org/show_bug.cgi?id=51069
3731
3732         * DumpRenderTree/chromium/WebViewHost.cpp:
3733         (WebViewHost::paintInvalidatedRegion):
3734
3735 2010-12-14  Benjamin Kalman  <kalman@chromium.org>
3736
3737         Reviewed by Ojan Vafai.
3738
3739         Using BUG/BUGWK in test_expectations is error prone, should use BUGCR/BUGWK
3740         https://bugs.webkit.org/show_bug.cgi?id=48926
3741
3742         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
3743         Add presubmit check that BUG isn't used, either BUGCR/BUGWK/BUGV8_.
3744
3745 2010-12-14  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3746
3747         Reviewed by Eric Seidel.
3748
3749         [Qt] [Symbian] Do not use pkg-config on Symbian as it is not supported
3750         https://bugs.webkit.org/show_bug.cgi?id=50231
3751
3752         Guard CONFIG+=link_pkgconfig with !symbian.
3753
3754         * DumpRenderTree/qt/DumpRenderTree.pro:
3755         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3756         * WebKitTestRunner/qt/WebKitTestRunner.pro:
3757
3758 2010-12-14  Philippe Normand  <pnormand@igalia.com>
3759
3760         Reviewed by Ojan Vafai.
3761
3762         [new-run-webkit-tests] expectations parsing is slow
3763         https://bugs.webkit.org/show_bug.cgi?id=50635
3764
3765         Avoid expensive iteration of all the tests when checking if a test